1 2010-07-03 Marek Safar <marek.safar@gmail.com>
3 * membercache.cs: Copy Membercache member state flags for 2 stage
4 inflate (Fixes #619555).
6 * ecore.cs: Use resolved accessors everywhere.
8 2010-07-02 Marek Safar <marek.safar@gmail.com>
11 * membercache.cs, property.cs: Check accessors of base property and
14 2010-07-02 Marek Safar <marek.safar@gmail.com>
16 * modifiers.cs, membercache.cs, import.cs, class.cs: Moved imported
17 override method checks into import.
19 * expression.cs: Removed redundant check.
21 2010-06-30 Marek Safar <marek.safar@gmail.com>
23 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs,
24 delegate.cs, cs-parser.jay, visit.cs: Use MemberAccess to resolve
25 base access expression, it has all bits done correctly.
27 2010-06-30 Marek Safar <marek.safar@gmail.com>
29 * support.cs: Removed unused code.
31 * ecore.cs: Don't use memberlookup for operators.
33 2010-06-30 Marek Safar <marek.safar@gmail.com>
35 * typemanager.cs, membercache.cs, convert.cs, expression.cs,
36 ecore.cs: Replace remaining MethodLookup with correct user operator
37 lookup (to do correct deep lookup). Clean up most of outstanding
38 quirks in binary operator overload resolution.
40 2010-06-29 Marek Safar <marek.safar@gmail.com>
42 * import.cs: Operators must have between 1 and 2 parameters.
44 * method.cs: Switch destructor to direct membercache lookup
46 2010-06-29 Marek Safar <marek.safar@gmail.com>
48 * driver.cs, expression.cs: Use Membercache for StringConcat when
49 it got all what is needed.
51 2010-06-29 Marek Safar <marek.safar@gmail.com>
53 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
54 Changed FindMembers to allocate a new list only when a filter is
55 used. Saves decent chunk of memory and should save even more in the
56 future when the filter is not used that often.
58 2010-06-28 Marek Safar <marek.safar@gmail.com>
60 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
61 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
62 structure for simple type fields (saves memory and makes few things
63 simpler). Clean up some hacks mostly for events.
65 2010-06-25 Marek Safar <marek.safar@gmail.com>
67 * statement.cs, cs-parser.jay: Don't create expensive block for
70 2010-06-24 Marek Safar <marek.safar@gmail.com>
72 * statement.cs, report.cs: Rethrow internal error when reporting is
75 * ecore.cs: Check for identical name only when simple name is set.
78 2010-06-24 Marek Safar <marek.safar@gmail.com>
81 * generic.cs, expression.cs, ecore.cs: Added a new type expression
82 for open generic type to pass unbound type arguments to typeof
85 2010-06-24 Marek Safar <marek.safar@gmail.com>
87 * statement.cs: Foreach collection implementation refactoring to
88 search for GetEnumerator more preciselly. Fixes #431453 and more
91 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
93 2010-06-23 Marek Safar <marek.safar@gmail.com>
95 * cs-parser.jay: Track more locations.
97 2010-06-22 Marek Safar <marek.safar@gmail.com>
99 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
101 2010-06-18 Marek Safar <marek.safar@gmail.com>
103 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
104 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
106 2010-06-18 Marek Safar <marek.safar@gmail.com>
108 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
111 2010-06-18 Marek Safar <marek.safar@gmail.com>
113 * typemanager.cs, namespace.cs: Report more predefined types and
114 imported types collision types as a warning.
115 Fixes #537414, #601157
117 2010-06-18 Marek Safar <marek.safar@gmail.com>
119 * generic.cs: Overrides base method constraint can use method type
122 * import.cs: Removed redundant cache.
124 2010-06-17 Marek Safar <marek.safar@gmail.com>
126 * generic.cs: Propagate type only inflate downwards.
128 2010-06-17 Marek Safar <marek.safar@gmail.com>
130 A fix for bug #614955
131 * method.cs: Do not reject binary dynamic operators.
133 2010-06-17 Marek Safar <marek.safar@gmail.com>
135 * typespec.cs: Internal types have no generic parameters.
138 2010-06-17 Marek Safar <marek.safar@gmail.com>
140 A fix for bug #614955
141 * cs-parser.jay: Correctly set expression mode for default parameter
144 2010-06-17 Marek Safar <marek.safar@gmail.com>
146 A fix for bug #615023
147 * ecore.cs: Resolve dynamic namespace and keyword collision in the
148 favour of the keyword.
150 2010-06-17 Marek Safar <marek.safar@gmail.com>
152 A fix for bug #614917
153 * convert.cs: Allow more undocumented 0 like values to enum type
156 2010-06-17 Marek Safar <marek.safar@gmail.com>
158 * generic.cs, method.cs: Inflate copied type parameters from base
159 class or explicit interfaces.
161 * convert.cs: Fixed conversion between two type parameters.
164 2010-06-16 Marek Safar <marek.safar@gmail.com>
166 * membercache.cs, convert.cs: Correctly resize an array used by
169 2010-06-15 Marek Safar <marek.safar@gmail.com>
171 A fix for bug #599601
172 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
173 generated member access left expression.
175 2010-06-16 Marek Safar <marek.safar@gmail.com>
177 * expression.cs: Dispatch dynamic invocation solely on left
180 2010-06-16 Marek Safar <marek.safar@gmail.com>
182 * expression.cs, statement.cs: Always persist explicit cast
183 semantic at expression level.
185 2010-06-15 Marek Safar <marek.safar@gmail.com>
187 * expression.cs, attribute.cs: Enable generic type parameters
190 2010-06-15 Marek Safar <marek.safar@gmail.com>
192 A fix for bug #612146
193 * generic.cs: Don't use fixed array for inflated type parameter
194 interface constraints.
196 2010-06-15 Marek Safar <marek.safar@gmail.com>
198 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
200 * report.cs: Unwrap elements for related symbols reporting.
202 2010-06-15 Marek Safar <marek.safar@gmail.com>
204 A fix for bug #612796
205 * cs-tokenizer.cs: Offset correctly keywords the first character
208 2010-06-15 Marek Safar <marek.safar@gmail.com>
210 A fix for bug #613397
211 * expression.cs: Removed too aggressive object initializers
214 2010-06-15 Marek Safar <marek.safar@gmail.com>
216 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
217 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
218 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
219 any intermediate steps and fake nodes, also saves few MBs of memory.
221 2010-06-11 Marek Safar <marek.safar@gmail.com>
223 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
224 precise modifiers parsing.
226 2010-06-09 Marek Safar <marek.safar@gmail.com>
228 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
229 Fixed few shift/reduce conflicts.
231 2010-06-09 Marek Safar <marek.safar@gmail.com>
233 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
234 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
235 specifiers and stop using string in AST.
237 2010-06-07 Marek Safar <marek.safar@gmail.com>
239 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
240 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
241 enum.cs: Hold location of predefined types.
243 2010-06-07 Marek Safar <marek.safar@gmail.com>
245 A fix for bug #610878
246 * pending.cs: Clone cached list before modifying.
248 2010-06-04 Marek Safar <marek.safar@gmail.com>
250 * convert.cs, typespec.cs, expression.cs: Start using array member
251 kind for better conversion checks.
253 * import.cs, report.cs: Report better error message for runtime
256 2010-06-04 Marek Safar <marek.safar@gmail.com>
258 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
259 user defined conversion probing and simplify user conversion for
260 nullabe types. Fixes #610940.
262 2010-06-03 Marek Safar <marek.safar@gmail.com>
264 A fix for bug #610919
265 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
266 parameters for explicit event accessors. Anonymous method capturing
267 won't otherwise work for event implicit parameter.
269 2010-06-02 Marek Safar <marek.safar@gmail.com>
271 A fix for bug #610088
272 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
273 Ignore overrides for base overload resolution as for non-base
274 expressions and convert the best candidate to closest override
277 2010-06-01 Marek Safar <marek.safar@gmail.com>
279 A fix for bug #610139
280 * generic.cs, convert.cs: Recursively check effective base interface
282 2010-06-01 Marek Safar <marek.safar@gmail.com>
284 * statement.cs: Handle nullable types and type parameters in using
285 statement, avoid boxing value types. Also fixes #571010
287 2010-06-01 Marek Safar <marek.safar@gmail.com>
289 * convert.cs, expression.cs: Emit unbox for underlying nullable
292 2010-05-29 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #610126
295 * expression.cs: Don't use branch optimization for types bigger than
298 2010-05-28 Marek Safar <marek.safar@gmail.com>
300 A fix for bug #609088
301 * import.cs: Check private modifier correctly.
303 2010-05-28 Marek Safar <marek.safar@gmail.com>
305 A fix for bug #609049
306 * ecore.cs: Don't ignore override methods when looking for base
309 2010-05-27 Marek Safar <marek.safar@gmail.com>
311 A fix for bugs #608007, #572540, #566130, #476358
313 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
314 More tricky refactoring of implicit linq blocks.
316 2010-05-25 Marek Safar <marek.safar@gmail.com>
318 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
320 2010-05-25 Marek Safar <marek.safar@gmail.com>
322 * context.cs, expression.cs, cs-parser.jay: Don't store current
323 block in This expression (it's too early for linq blocks).
325 2010-05-21 Marek Safar <marek.safar@gmail.com>
327 * expression.cs: Use constrained prefix more broadly to avoid boxing.
329 2010-05-20 Marek Safar <marek.safar@gmail.com>
331 A fix for bug #591149
332 * nullable.cs: Don't double wrap same expression.
334 2010-05-20 Marek Safar <marek.safar@gmail.com>
336 A fix for bug #569827
337 * anonymous.cs: Any issued error in probing mode means no match.
339 2010-05-20 Marek Safar <marek.safar@gmail.com>
341 * expression.cs: Search for base indexer using the closest match
344 2010-05-20 Marek Safar <marek.safar@gmail.com>
346 A fix for bug #572071
347 * method.cs: Set override constraints using unexpanded interface
350 2010-05-20 Marek Safar <marek.safar@gmail.com>
352 A fix for bug #572071
353 * ecore.cs: Include secondary extension method lookup in probing
356 2010-05-19 Marek Safar <marek.safar@gmail.com>
358 A fix for bug #515801
359 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
362 2010-05-19 Marek Safar <marek.safar@gmail.com>
364 A fix for bug #515801
365 * pending.cs: Advance counter correctly.
367 2010-05-19 Marek Safar <marek.safar@gmail.com>
369 A fix for bug #480139
370 * method.cs, pending.cs: Indexer override uses base name.
372 2010-05-19 Marek Safar <marek.safar@gmail.com>
374 A fix for bug #424064
375 * generic.cs: Replace original with inflated type parameter on
378 2010-05-19 Marek Safar <marek.safar@gmail.com>
380 A fix for bug #359733
381 * parameter.cs: Extension attribute can be defined in each assembly.
383 2010-05-18 Marek Safar <marek.safar@gmail.com>
385 A fix for bug #446507
386 * method.cs: Only one method can implement an interface.
388 2010-05-18 Marek Safar <marek.safar@gmail.com>
390 A fix for bug #594905
391 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
392 Typed null can be used as a source for expression methods.
394 2010-05-18 Marek Safar <marek.safar@gmail.com>
396 A fix for bug #606551
397 * namespace.cs: Using directive imports only types and not nested
400 2010-05-17 Marek Safar <marek.safar@gmail.com>
402 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
403 delegate.cs: Member instance is resolved after member overload
404 definitely resolves static/instance property of member expression.
405 Fixes #545047, #358848, #456605, #460016, #603299
407 2010-05-12 Marek Safar <marek.safar@gmail.com>
409 A fix for bug #604981
410 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
411 details for nested anonymous methods stories.
413 2010-05-11 Marek Safar <marek.safar@gmail.com>
415 A fix for bug #604735
416 * namespace.cs: Don't report namespace collision.
418 2010-05-11 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #604748
421 * class.cs, typespec.cs: Search full imported attribute hierarchy
424 2010-05-11 Marek Safar <marek.safar@gmail.com>
426 * namespace.cs: Ignore missing dependencies failure at
429 2010-05-11 Marek Safar <marek.safar@gmail.com>
431 A fix for bug #604640
432 * namespace.cs: Don't resolve using constraints too early.
434 2010-05-11 Marek Safar <marek.safar@gmail.com>
436 A fix for bug #604239
437 * generic.cs: Copy partial type constraints to partial container.
439 2010-05-10 Marek Safar <marek.safar@gmail.com>
441 A fix for bug #557210
442 * import.cs: Relax underlying enum field rules.
444 2010-05-10 Marek Safar <marek.safar@gmail.com>
446 A fix for bug #603476
447 * property.cs: Implement IParametersMember for indexer accessors.
449 2010-05-07 Marek Safar <marek.safar@gmail.com>
451 A fix for bug #601141
452 * class.cs: Update all partial modifiers.
454 2010-05-06 Marek Safar <marek.safar@gmail.com>
456 A fix for bug #601708
457 * method.cs, membercache.cs: Destructors cannot be hidden.
459 2010-05-06 Marek Safar <marek.safar@gmail.com>
461 A fix for bug #602551
462 * class.cs: Resursive reference of type definition is allowed.
464 2010-05-06 Marek Safar <marek.safar@gmail.com>
466 * anonymous.cs: Mutate cached storey instance types too.
468 2010-05-06 Marek Safar <marek.safar@gmail.com>
470 A fix for bug #602443
471 * convert.cs: Explicit enum conversion cannot involve user operators
473 2010-05-05 Miguel de Icaza <miguel@novell.com>
475 * class.cs (TypeContainer.DefineBaseTypes)
476 (TypeContainer.CheckRecursiveDefinition): check for the iface not
477 being null, as we could have failed resolution and crashed;
480 * cs-parser.jay: Productions to catch common mistakes when other
481 punctuation operators are used instead of comma. Fixes 571702
483 2010-05-05 Marek Safar <marek.safar@gmail.com>
485 * anonymous.cs: Mutate correct set of constraints.
487 2010-05-05 Marek Safar <marek.safar@gmail.com>
489 A fix for bug #602842
490 * expression.cs: Resolve all array bound arguments.
492 2010-05-05 Marek Safar <marek.safar@gmail.com>
494 * import.cs: Don't import private fields.
496 2010-04-30 Marek Safar <marek.safar@gmail.com>
498 Partially based on patch by <sami.lamti@gmail.com>
500 * eval.cs, ecore.cs: Fixed eval show methods.
502 2010-04-30 Marek Safar <marek.safar@gmail.com>
504 * generic.cs, delegate.cs: Implement output type inference of
505 methodgroup now when the specification was cleared at least little
508 2010-04-29 Marek Safar <marek.safar@gmail.com>
510 A fix for bug #575611
511 * class.cs: Fix recursive unmanaged recursice sruct check.
513 2010-04-29 Marek Safar <marek.safar@gmail.com>
515 A fix for bug #479776
516 * expression.cs: Implement typeof unbounded nested generic types.
518 2010-04-29 Marek Safar <marek.safar@gmail.com>
520 A fix for bug #474953
521 * class.cs: Fix valid recursive base type definition.
523 2010-04-29 Marek Safar <marek.safar@gmail.com>
525 A fix for bug #421737
526 * convert.cs, expression.cs: A boxing conversion exists from a
527 nullable-type to a reference type, if a boxing conversion exists
528 from the underlying non-nullable-value-type to the reference type.
530 2010-04-29 Marek Safar <marek.safar@gmail.com>
532 A fix for bug #376875
533 * import.cs: Import volatile modifier.
535 2010-04-29 Marek Safar <marek.safar@gmail.com>
537 A fix for bug #372412
538 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
541 2010-04-29 Marek Safar <marek.safar@gmail.com>
543 A fix for bug #568955
544 * statements.cs: Handle recursive scope initializers.
546 2010-04-28 Marek Safar <marek.safar@gmail.com>
548 A fix for bug #566511
549 * anonymous.cs: Always get inflated version of hoisted variable
550 on generic type definition.
552 2010-04-28 Marek Safar <marek.safar@gmail.com>
554 * import.cs, membercache.cs: Relax rules for valid properties.
556 2010-04-28 Marek Safar <marek.safar@gmail.com>
558 * import.cs: Intern arrays used in generic arguments.
560 2010-04-28 Marek Safar <marek.safar@gmail.com>
562 A fix for bug #600398
563 * convert.cs: Actually use effective base type for the comparison.
565 2010-04-28 Marek Safar <marek.safar@gmail.com>
567 A fix for bug #600326
568 * ecore.cs: Pass arity to base member lookup.
570 2010-04-28 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #573385
573 * expression.cs: MemberAccess is of generic type based on right
576 2010-05-28 Marek Safar <marek.safar@gmail.com>
578 * cs-tokenizer.cs: Made tab size configurable.
580 2010-05-27 Marek Safar <marek.safar@gmail.com>
582 * attribute.cs: Ensure Obsolete members are defined before doing
585 2010-05-27 Marek Safar <marek.safar@gmail.com>
587 * visit.cs: Add DOM visitor skeleton.
591 2010-05-27 Marek Safar <marek.safar@gmail.com>
593 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
595 2010-05-27 Marek Safar <marek.safar@gmail.com>
597 * *.cs: Major rewrite of compiler internals to better work with
598 unmodified System.Reflection.Emit. Some of the key changes are
599 - TypeSpec replaces reflection specific System.Type.
600 - All Type(TypeSpec) operations are now done in compiler therefore
601 no dependency on SRE to inflate generic members and types or to
602 query unclosed types.
603 - MemberCache is now the only and full hierarchical topology.
604 - Generic constraints are implemented properly.
605 - And as a bonus compilation is on average 30% faster.
607 2010-04-15 Jb Evain <jbevain@novell.com>
609 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
611 2010-04-12 Marek Safar <marek.safar@gmail.com>
613 * expression.cs, attribute.cs, parameter.cs: More attribute type
616 2010-04-12 Marek Safar <marek.safar@gmail.com>
618 A fix for bug #593342
620 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
621 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
622 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
623 codegen.cs: Add custom attribute encoder to deal with unfinished
624 types and easier corlib bootstrap from its own types.
626 2010-03-26 Marek Safar <marek.safar@gmail.com>
628 * cs-parser.jay: Report invalid constraint types.
630 2010-03-16 Jb Evain <jbevain@novell.com>
632 * Makefile: rename the net_2_1 profile to moonlight.
634 2010-03-11 Marek Safar <marek.safar@gmail.com>
636 * statement.cs, cs-parser.jay: Use correct location for empty
639 2010-03-11 Marek Safar <marek.safar@gmail.com>
641 * cs-parser.jay: Disable Location from expression.
643 * generic.cs: Check constraints for overrides in the parser.
645 2010-03-09 Marek Safar <marek.safar@gmail.com>
647 * cs-parser.jay (GetLocation): Use an expression when available.
649 2010-03-04 Marek Safar <marek.safar@gmail.com>
651 A fix for bug #582579
652 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
654 2010-03-04 Marek Safar <marek.safar@gmail.com>
656 A patch by kornelpal@gmail.com
658 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
659 compiler generated classes sealed by default. Emit and close top
660 level compiler generated classes as well.
662 * support.cs: Use RuntimeHelpers.GetHashCode.
664 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
666 * Makefile: We need to use the internal bootstrapping gmcs for
667 net_2_1_bootstrap too now.
669 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
671 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
673 2010-03-02 Marek Safar <marek.safar@gmail.com>
675 * cs-tokenizer.cs: Missed few locations in previous fix.
677 2010-03-02 Marek Safar <marek.safar@gmail.com>
679 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
680 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
681 Report correct location for operator errors.
683 2010-03-02 Marek Safar <marek.safar@gmail.com>
685 * typemanager.cs (IsDynamicType): Don't check external types when
686 the attribute is not external.
688 2010-02-24 Marek Safar <marek.safar@gmail.com>
690 A fix for bug #582579
691 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
694 2010-02-24 Marek Safar <marek.safar@gmail.com>
696 A fix for bug #581804
697 * ecore.cs: Fixed type comparison.
699 2010-02-08 Miguel de Icaza <miguel@novell.com>
701 * namespace.cs (CompletionGetTypesStartingWith): Do not include
702 private types in the completion results.
704 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
707 2010-02-17 Marek Safar <marek.safar@gmail.com>
709 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
712 2010-02-14 Miguel de Icaza <miguel@novell.com>
714 * eval.cs: Do not do the report printer dance unless the user has
715 set the DescribeTypes feature.
717 2010-02-10 Marek Safar <marek.safar@gmail.com>
719 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
721 2010-02-08 Marek Safar <marek.safar@gmail.com>
723 A fix for bug #577029
724 * anonymous.cs: Fixed TypeBuilder* check.
726 2010-02-06 Miguel de Icaza <miguel@novell.com>
728 * eval.cs (CompileBlock): Also undo if there are problems during
729 semantic analysis, fixes various cases where invalid C# code would
730 be reported, but the internal changes would not be undone.
732 2010-02-03 Miguel de Icaza <miguel@novell.com>
734 * driver.cs: Change the --fatal flag to allow a number to be
735 passed, this ignores the first N fatal errors. Useful to debug
736 errors that do not happen on the first hit.
738 * cs-parser.jay (invocation_expression): accept both the
739 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
740 inside an invocation.
742 * driver.cs: Expose FatalErrors.
744 * eval.cs: Initialize the printer's Fatal property from the
745 Driver's FatalError flag, this allows csharp --fatal to work
748 Add support for calling Describe (typeof (TYPE)) if the expression
751 2010-02-02 Marek Safar <marek.safar@gmail.com>
753 A fix for bug #574991
754 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
757 2010-02-02 Marek Safar <marek.safar@gmail.com>
759 A fix for bug #575986
760 * expression.cs: Don't mutate typeof type definitions.
762 2010-01-28 Marek Safar <marek.safar@gmail.com>
764 * decl.cs: Use only one set of modifiers.
766 2010-01-26 Marek Safar <marek.safar@gmail.com>
768 A fix for bug #573329
769 * eval.cs: Don't disable error reporting completely on silent mode.
771 2010-01-25 Marek Safar <marek.safar@gmail.com>
773 A fix for bug #573312
774 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
775 pointer index of unknown size types greater than 2.
777 2010-01-15 Marek Safar <marek.safar@gmail.com>
779 * *.cs: Use only 1 member kind enum.
781 2010-01-15 Marek Safar <marek.safar@gmail.com>
783 * *.cs: Add event specification.
785 2010-01-14 Marek Safar <marek.safar@gmail.com>
787 * membercache.cs: Extracted from decl.cs.
789 * *.cs: Put more infrastructure in place.
791 2010-01-13 Marek Safar <marek.safar@gmail.com>
793 * *.cs: Add property specification, unused yet.
795 2010-01-13 Marek Safar <marek.safar@gmail.com>
797 * property.cs: Move all property based declarations into a new file.
799 2010-01-13 Marek Safar <marek.safar at gmail.com>
801 * expression.cs (Conditional): Resolve reduced expression.
803 2010-01-13 Marek Safar <marek.safar at gmail.com>
805 * *.cs: Introduced non-generic method specification.
807 2010-01-07 Marek Safar <marek.safar@gmail.com>
809 * method.cs: Move all method based declarations into a new file.
811 2010-01-07 Marek Safar <marek.safar@gmail.com>
813 * *.cs: Extract field specification.
815 2009-12-17 Marek Safar <marek.safar@gmail.com>
817 * field.cs: Extracted from class.cs
819 2009-12-15 Marek Safar <marek.safar@gmail.com>
821 * attribute.cs (GetFixedBuffer): Work on field definition only.
823 2009-12-15 Marek Safar <marek.safar@gmail.com>
825 * *.cs: Clean up NET_4_0 conditional where possible.
827 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
829 support.cs (DynamicType): Assembly property returns the assembly builder.
830 This is required due to how compiler context works in corlib.
832 2009-12-14 Marek Safar <marek.safar@gmail.com>
834 A fix for bug #564376
835 * assign.cs (LocalTemporary): Removed no longer needed special
838 2009-12-11 Marek Safar <marek.safar@gmail.com>
840 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
841 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
842 enum for easier debugging.
844 2009-12-10 Marek Safar <marek.safar@gmail.com>
846 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
849 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
852 2009-12-10 Marek Safar <marek.safar@gmail.com>
854 * cs-parser.jay, statement.cs: Handle parser error in code
857 2009-12-10 Marek Safar <marek.safar@gmail.com>
859 * ecore.cs: Ignore base imported methods when they are already
862 * eval.cs: Handle non-existent keys.
864 * report.cs, driver.cs: Make fatal work with console printer only.
866 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
868 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
870 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
872 * typemanager.cs: Add MakeGenericMethod that checks if the method
873 is really the generic method definition.
875 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
876 to inflate generic methods.
878 2009-12-08 Marek Safar <marek.safar@gmail.com>
880 A fix for bug #561149
881 * anonymous.cs: Use actual type parameters when checking for generic
884 2009-12-08 Marek Safar <marek.safar@gmail.com>
886 A fix for bug #561369
887 * expression.cs (DoNumericPromotion): Fixed typo.
889 2009-12-08 Marek Safar <marek.safar@gmail.com>
891 *.cs: Moving to generics world.
893 cs-parser.jay: Removed current_array_type.
895 2009-12-07 Marek Safar <marek.safar@gmail.com>
897 *.cs: Moving to generics world.
899 2009-12-04 Marek Safar <marek.safar@gmail.com>
901 *.cs: Moving to generics world (day 2).
903 2009-12-03 Marek Safar <marek.safar@gmail.com>
905 *.cs: Moving to generics world.
907 2009-12-02 Marek Safar <marek.safar@gmail.com>
909 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
910 Encode dynamic type attribute for elements where attributes cannot
913 2009-12-01 Marek Safar <marek.safar@gmail.com>
915 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
918 2009-12-01 Marek Safar <marek.safar@gmail.com>
920 A fix for bug #360455
921 * class.cs: Never report a unused warning for generic events to
922 workaround wrong expression type.
924 2009-11-30 Marek Safar <marek.safar@gmail.com>
926 A fix for bug #558305
927 * decl.cs, class.cs: Check partial method definitions using correct
930 2009-11-30 Marek Safar <marek.safar@gmail.com>
932 * argument.cs: Don't cache rarely used dynamic flag.
934 2009-11-27 Marek Safar <marek.safar@gmail.com>
936 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
938 2009-11-27 Marek Safar <marek.safar@gmail.com>
940 * ecore.cs (SimpleName): Removed no longer needed in_transit as
941 Resolve is now non-reentrant (saves ~0.6MB for corlib).
943 2009-11-26 Marek Safar <marek.safar@gmail.com>
945 A fix for bug #545081
946 * decl.cs: Check private nested types of nested types recursively.
948 2009-11-26 Marek Safar <marek.safar@gmail.com>
950 A fix for bug #558305
951 * location.cs: Ignore self referencing #line directive
953 2009-11-26 Marek Safar <marek.safar@gmail.com>
955 A fix for bug #558292
956 * class.cs: Allow single unsafe fixed buffer fields.
958 2009-11-26 Marek Safar <marek.safar@gmail.com>
960 * expression: Optimize few more zero-based operations.
962 2009-11-26 Marek Safar <marek.safar@gmail.com>
964 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
965 avoids boxing of literal values.
967 2009-11-26 Marek Safar <marek.safar@gmail.com>
969 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
970 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
971 codegen.cs: LocatedToken redesing to avoid excessive allocation and
972 boxing (saves ~7MB for corlib). Also fixes presise token location.
974 2009-11-25 Marek Safar <marek.safar@gmail.com>
976 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
979 2009-11-24 Marek Safar <marek.safar@gmail.com>
981 * expression.cs: Lower static array initializer barrier.
983 * support.cs, driver.cs: Share reader buffer.
985 2009-11-23 Marek Safar <marek.safar@gmail.com>
987 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
989 2009-11-23 Marek Safar <marek.safar@gmail.com>
991 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
992 cleanup some obsolete code.
994 2009-11-20 Marek Safar <marek.safar@gmail.com>
996 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
999 2009-11-20 Marek Safar <marek.safar@gmail.com>
1001 * *.cs: Resolved expressions are never resolved again, this helps to
1002 uncover some not easy to find bugs and improve the performance.
1004 2009-11-19 Marek Safar <marek.safar@gmail.com>
1006 * *.cs: Made constant expressions fully compatible with any other
1009 2009-11-19 Marek Safar <marek.safar@gmail.com>
1011 * *.cs: DoResolve is a worker method and has to be protected.
1013 2009-11-18 Marek Safar <marek.safar@gmail.com>
1015 * *.cs: More context specific handling.
1017 2009-11-17 Marek Safar <marek.safar@gmail.com>
1019 * *.cs: More context specific handling.
1021 2009-11-16 Marek Safar <marek.safar@gmail.com>
1023 * dynamic.cs, class.cs: Removed few fixed user types conversions.
1025 * symbolwriter.cs: Uses public ILOffset.
1027 2009-11-13 Marek Safar <marek.safar@gmail.com>
1029 A fix for bug #553650
1030 * generic.cs: Another missing TypeToCoreType, still too many to fix.
1032 2009-11-13 Marek Safar <marek.safar@gmail.com>
1034 A fix for bug #555170
1036 * class.cs, delegate.cs, enum.cs: Constants have to be available
1037 for parameters resolve.
1039 2009-11-12 Marek Safar <marek.safar@gmail.com>
1041 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
1044 2009-11-12 Marek Safar <marek.safar@gmail.com>
1046 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
1047 with a statically known candidate set.
1049 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1051 * generic.cs: Made type inflation for generic constraint checks
1052 recursive. This fixes BGO #553655.
1054 2009-11-11 Marek Safar <marek.safar@gmail.com>
1056 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1059 2009-11-10 Marek Safar <marek.safar@gmail.com>
1061 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1062 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1063 attribute.cs: Add some dynamic error checking.
1065 2009-11-07 Marek Safar <marek.safar@gmail.com>
1067 A fix for bug #553465
1069 * expression.cs: Fixed mixed version of expression tree anonymous
1072 2009-11-06 Marek Safar <marek.safar@gmail.com>
1074 A fix for bug #553031
1076 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1077 expression tree version of anonymous type with members declaration.
1079 2009-11-05 Marek Safar <marek.safar@gmail.com>
1081 * parameter.cs: Handle nullable parameter default expression.
1083 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1084 class.cs, attribute.cs: Check for wrong dynamic arguments.
1086 2009-11-05 Marek Safar <marek.safar@gmail.com>
1088 * statement.cs: Dynamic statements.
1090 2009-11-04 Marek Safar <marek.safar@gmail.com>
1092 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1093 Compound assignments over dynamic type.
1095 2009-11-03 Marek Safar <marek.safar@gmail.com>
1097 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1098 constructor arguments.
1100 2009-10-30 Marek Safar <marek.safar@gmail.com>
1102 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1103 codegen.cs: Unary mutator on dynamic member access expression.
1105 2009-10-29 Marek Safar <marek.safar@gmail.com>
1107 A fix for bug #550580
1108 * convert.cs: Don't eliminate explicit precission casts.
1110 2009-10-28 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #550404
1114 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1115 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1118 2009-10-27 Marek Safar <marek.safar@gmail.com>
1120 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1123 * class.cs: Allow nullable binary user operators.
1125 2009-10-26 Marek Safar <marek.safar@gmail.com>
1127 * expression.cs: Move binary expression optimization at the end of
1130 2009-10-23 Marek Safar <marek.safar@gmail.com>
1132 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1133 Separate NullConstant from NullLiteral.
1135 2009-10-23 Marek Safar <marek.safar@gmail.com>
1137 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1138 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1139 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1140 ModuleContainer. Add common unclosed member check routine.
1142 2009-10-22 Marek Safar <marek.safar@gmail.com>
1144 * argument.cs: Use literal flag for real literals only.
1146 * dynamic.cs: Use correct return type for custom delegates.
1148 2009-10-22 Marek Safar <marek.safar@gmail.com>
1150 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1153 2009-10-22 Marek Safar <marek.safar@gmail.com>
1155 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1157 2009-10-21 Marek Safar <marek.safar@gmail.com>
1159 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1162 2009-10-21 Marek Safar <marek.safar@gmail.com>
1164 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1167 2009-10-20 Marek Safar <marek.safar@gmail.com>
1169 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1171 2009-10-19 Marek Safar <marek.safar@gmail.com>
1173 * typemanager.cs, expression.cs: Dynamic array initializer.
1175 2009-10-16 Marek Safar <marek.safar@gmail.com>
1177 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1180 2009-10-16 Marek Safar <marek.safar@gmail.com>
1182 A fix for bug #493523, #507067
1183 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1184 standard nullable conversion using underlying standard conversion
1185 and not full conversion.
1187 2009-10-15 Marek Safar <marek.safar@gmail.com>
1189 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1190 type in VerifyArgumentsCompat.
1192 2009-10-15 Marek Safar <marek.safar@gmail.com>
1194 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1195 Reject variable used with type arguments.
1197 2009-10-14 Marek Safar <marek.safar@gmail.com>
1199 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1200 Implement dynamic expressions assignment.
1202 2009-10-14 Marek Safar <marek.safar@gmail.com>
1204 * expression.cs: Build underlying expression when resolving unary
1207 2009-10-14 Marek Safar <marek.safar@gmail.com>
1209 * expression.cs: Emit enum array initializer using binary blob.
1211 2009-10-08 Marek Safar <marek.safar@gmail.com>
1213 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1216 2009-10-07 Marek Safar <marek.safar@gmail.com>
1218 * typemanager.cs: Reset object_type.
1220 * assign: Made SimpleAssign public.
1222 2009-10-06 Marek Safar <marek.safar@gmail.com>
1224 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1225 invocation assembly to IsThisOrFriendAssembly.
1227 2009-10-05 Marek Safar <marek.safar@gmail.com>
1229 * expression.cs: Equality comparison of generic parameter with
1232 2009-10-05 Marek Safar <marek.safar@gmail.com>
1234 A fix for bug #543570
1235 * generic.cs: Import predefined constraints correctly.
1237 2009-10-02 Marek Safar <marek.safar@gmail.com>
1239 * ecore.cs: Don't crash on overloads with optional paremeters where
1240 arguments count overflows.
1242 * parameter.cs: Import optional parameter constants using optional
1245 2009-10-01 Marek Safar <marek.safar@gmail.com>
1247 * Makefile: Default is gmcs compiler.
1249 2009-10-01 Marek Safar <marek.safar@gmail.com>
1251 * cs-parser.jay: Fixed few NRE.
1253 2009-10-01 Marek Safar <marek.safar@gmail.com>
1255 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1257 2009-09-30 Marek Safar <marek.safar@gmail.com>
1259 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1260 ShimExpression, ImplicitCast.
1262 2009-09-30 Marek Safar <marek.safar@gmail.com>
1264 A fix for bug #542959
1265 * delegate.cs: Emit correct delegate instance variable when there
1266 are static and non-static overloads.
1268 2009-09-29 Marek Safar <marek.safar@gmail.com>
1270 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1271 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1273 2009-09-28 Marek Safar <marek.safar@gmail.com>
1275 A fix for bug #542487
1276 * ecore.cs: Resolve extension methods hidden by properties.
1278 2009-09-25 Marek Safar <marek.safar@gmail.com>
1280 * expression.cs, ecore.cs: More dynamic binary expressions.
1282 2009-09-22 Marek Safar <marek.safar@gmail.com>
1284 * nullable.cs, expression.cs: Fixed null lifted conversion for
1285 bitwise enum operations.
1287 2009-09-22 Marek Safar <marek.safar@gmail.com>
1289 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1290 values in checked context.
1292 2009-09-22 Marek Safar <marek.safar@gmail.com>
1294 * expression.cs, ecore.cs: Fixed array index constant conversion.
1296 2009-09-20 Miguel de Icaza <miguel@novell.com>
1298 * expression.cs: Do not crash when MemberLookup returns something
1299 that is not a MemberExpr here. Report error 582 instead.
1303 2009-09-18 Marek Safar <marek.safar@gmail.com>
1305 * decl.cs, class.cs: Check protected property accessors.
1307 2009-09-18 Marek Safar <marek.safar@gmail.com>
1309 * dynamic.cs, assign.cs: Dynamic compound assignment.
1311 2009-09-17 Marek Safar <marek.safar@gmail.com>
1313 * expression.cs: Fixed compound assignment explicit conversion.
1315 2009-09-17 Marek Safar <marek.safar@gmail.com>
1317 * expression.cs, ecore.cs: Cannot infer variables from method group.
1319 2009-09-16 Marek Safar <marek.safar@gmail.com>
1321 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1322 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1323 codegen.cs: Dynamic binary operations scaffolding.
1325 2009-09-15 Marek Safar <marek.safar@gmail.com>
1327 * expression.cs: Fixes nullable promotion for enum type variables.
1329 2009-09-11 Marek Safar <marek.safar@gmail.com>
1331 * driver.cs, dynamic.cs: Reset more static variables.
1333 2009-09-11 Marek Safar <marek.safar@gmail.com>
1335 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1336 driver.cs: Introduced Expression::MakeExpression.
1338 2009-09-11 Marek Safar <marek.safar@gmail.com>
1340 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1342 2009-09-09 Marek Safar <marek.safar@gmail.com>
1344 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1347 2009-09-09 Marek Safar <marek.safar@gmail.com>
1349 A fix for bug #518707
1350 * expression.cs (Is): Optimize only generic parameter type
1351 expression probing value type generic parameter.
1353 2009-09-09 Marek Safar <marek.safar@gmail.com>
1355 A fix for bug #532571
1356 * ecore.cs: Check for simple name type arguments used with
1359 2009-09-08 Marek Safar <marek.safar@gmail.com>
1361 A fix for bug #497421
1362 * generic.cs (CheckConstraint): Don't use buildin types to check for
1363 parameterless constructor.
1365 2009-09-08 Marek Safar <marek.safar@gmail.com>
1367 A fix for bug #537402
1368 * generic.cs (CheckConstraint): Correctly inflate generic type
1369 arguments when checking generic method.
1371 2009-09-08 Marek Safar <marek.safar@gmail.com>
1373 A fix for bug #536463
1374 * decl.cs (AddToContainer): Don't report collision between explicit
1375 and parameterless non-explicit members.
1377 2009-09-08 Marek Safar <marek.safar@gmail.com>
1379 * eval.cs: Reset more static stuff.
1381 2009-09-07 Marek Safar <marek.safar@gmail.com>
1383 A fix for bug #324625
1384 * expression.cs, ecore.cs: Create nested generic type expression
1385 using declaring and not current type.
1387 2009-09-07 Marek Safar <marek.safar@gmail.com>
1389 * *.cs: Changed Report class to accept various output printers and
1390 be an instance class. An expression resolver can now use different
1391 message reporter for each call and Report.Error can safely throw
1392 an exception. Part of ongoing work to turn mcs into proper library.
1394 2009-09-04 Marek Safar <marek.safar@gmail.com>
1396 * statement.cs, ecore.cs: Removed error reporting from emit code.
1398 2009-09-04 Marek Safar <marek.safar@gmail.com>
1400 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1402 2009-09-03 Marek Safar <marek.safar@gmail.com>
1404 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1405 parser checks out of constructors.
1407 2009-09-02 Marek Safar <marek.safar@gmail.com>
1409 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1411 2009-09-02 Marek Safar <marek.safar@gmail.com>
1413 A fix for bug #535448
1414 * anonymous.cs, class.cs: Copy return label between all contexts.
1416 2009-09-02 Marek Safar <marek.safar@gmail.com>
1418 A fix for bug #535395
1419 * namespace.cs: Resolve context can be null.
1421 2009-08-25 Marek Safar <marek.safar@gmail.com>
1423 A fix for bug #533912
1424 * generic.cs: Use correct context for constraints resolving.
1426 2009-08-25 Marek Safar <marek.safar@gmail.com>
1428 A fix for bug #532630
1429 * driver.cs: Trim conditional symbols.
1431 2009-08-25 Marek Safar <marek.safar@gmail.com>
1433 * context.cs: New file.
1435 * *.exe.sources, *.csproj: Updated.
1437 2009-08-25 Marek Safar <marek.safar@gmail.com>
1439 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1440 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1441 IMembercontext, some small cleanups.
1443 2009-08-24 Marek Safar <marek.safar@gmail.com>
1445 * *.cs: Split ResolveContext and EmitContext.
1447 2009-08-24 Marek Safar <marek.safar@gmail.com>
1449 * *.cs: Only ResolveContext implements IMemberContext.
1451 2009-08-21 Marek Safar <marek.safar@gmail.com>
1453 * *.cs: Renamed IResolveContext to IMemberContext.
1455 2009-08-21 Marek Safar <marek.safar@gmail.com>
1457 * *.cs: Detached ResolveContext from EmitContext.
1459 2009-08-21 Marek Safar <marek.safar@gmail.com>
1461 * codegen.cs: Moved flow-analysis to BlockContext.
1463 2009-08-21 Marek Safar <marek.safar@gmail.com>
1465 * *.cs: Detached BlockContext from EmitContext.
1467 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1469 * statement.cs: avoid nullref when the return value of GetEnumerator()
1470 does not contain any MoveNext() method.
1472 2009-08-19 Marek Safar <marek.safar@gmail.com>
1474 * *.cs: Removed IResolveContext::GenericDeclContainer.
1476 2009-08-19 Marek Safar <marek.safar@gmail.com>
1478 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1480 2009-08-19 Marek Safar <marek.safar@gmail.com>
1482 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1483 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1485 2009-08-18 Marek Safar <marek.safar@gmail.com>
1487 * *.cs: Removed boolean fields from EmitContext.
1489 2009-08-18 Marek Safar <marek.safar@gmail.com>
1491 * *.cs: Add IResolveContext::IsStatic.
1493 2009-08-18 Marek Safar <marek.safar@gmail.com>
1495 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1497 2009-08-17 Marek Safar <marek.safar@gmail.com>
1499 * *.cs: Removed DeclContainer from EmitContext.
1501 2009-08-17 Marek Safar <marek.safar@gmail.com>
1503 * *.cs: Add IResolveContext::CurrentTypeParameters.
1505 2009-08-14 Marek Safar <marek.safar@gmail.com>
1507 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1509 2009-08-14 Marek Safar <marek.safar@gmail.com>
1511 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1512 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1514 2009-08-13 Marek Safar <marek.safar@gmail.com>
1516 * decl.cs: Look in PartialContainer for parent type parameters.
1518 2009-08-13 Marek Safar <marek.safar@gmail.com>
1520 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1521 codegen.cs: Add IResolveContext::LookupTypeParameter.
1523 2009-08-13 Marek Safar <marek.safar@gmail.com>
1525 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1526 Moved resolved logic from Emit to Resolve.
1528 2009-08-13 Marek Safar <marek.safar@gmail.com>
1530 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1531 codegen.cs: Reworked atttributes handling of ResolveContext.
1533 2009-08-12 Marek Safar <marek.safar@gmail.com>
1535 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1536 LookupNamespaceOrType to ResolveContext.
1538 2009-08-12 Marek Safar <marek.safar@gmail.com>
1540 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1541 class.cs: Removed unused parameters and methods.
1543 2009-08-11 Marek Safar <marek.safar@gmail.com>
1545 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1546 codegen.cs: Finding the best common type of a set of expressions for
1549 2009-08-07 Marek Safar <marek.safar@gmail.com>
1551 * dynamic.cs, expression.cs: More dynamic conversions.
1553 2009-08-06 Miguel de Icaza <miguel@novell.com>
1555 * generic.cs: This loop was incorrect, it was increment ii, but
1556 checking for `i'. This was a change introduced to fix #327497,
1559 * class.cs: Catch another case for cs0533 error, fixes #324782.
1561 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1563 * typemanager.cs (GetGenericArguments): SRE returns null for
1564 generic methods on type builder instances if they are not generic
1565 themselves. For example, for Foo<int>::Bar() it returns null, but
1566 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1568 2009-08-05 Marek Safar <marek.safar@gmail.com>
1570 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1571 delegate.cs: Work on dynamic binding.
1573 2009-08-04 Marek Safar <marek.safar@gmail.com>
1575 A second fix for bug #525342
1576 * class.cs: Attach partial method attributes to method
1579 2009-08-03 Marek Safar <marek.safar@gmail.com>
1581 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1584 * rootcontext.cs: Default to langversion v4.
1586 2009-08-03 Marek Safar <marek.safar@gmail.com>
1588 * pending.cs: Check return type before member info is set.
1590 2009-08-03 Marek Safar <marek.safar@gmail.com>
1592 * anonymous.cs: Fully initialize generic hoisted field expression.
1594 2009-08-02 Miguel de Icaza <miguel@novell.com>
1596 * cs-parser.jay: Flag variables declared on the interactive shell
1597 as used to prevent the 168 warning about local variable not being
1600 2009-07-31 Marek Safar <marek.safar@gmail.com>
1602 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1603 attribute.cs: Emit dynamic export attribute.
1605 2009-07-30 Marek Safar <marek.safar@gmail.com>
1607 * expression.cs: More verifier work.
1609 2009-07-29 Marek Safar <marek.safar@gmail.com>
1611 * nullable.cs: Fixed SRE crash during corlib compilation.
1613 2009-07-29 Marek Safar <marek.safar@gmail.com>
1615 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1616 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1617 More TypeManager.TypeToCoreType needed.
1619 2009-07-29 Marek Safar <marek.safar@gmail.com>
1621 * anonymous.cs: Update after recent SRE fixes.
1623 2009-07-28 Marek Safar <marek.safar@gmail.com>
1625 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1626 version of GetFieldHandle for fields of generic types.
1628 2009-07-27 Marek Safar <marek.safar@gmail.com>
1630 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1631 ecore.cs: Add TypeManager.IsDynamicType,
1632 PredefinedAttributes.Dynamic.
1634 2009-07-27 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #415375
1637 * expression.cs: Fixed object and reference type parameter
1640 2009-07-27 Marek Safar <marek.safar@gmail.com>
1642 A fix for bug #525342
1643 * class.cs: Attach partial method attributes to method
1646 2009-07-24 Marek Safar <marek.safar@gmail.com>
1648 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1651 2009-07-24 Marek Safar <marek.safar@gmail.com>
1653 * anonymous.cs (MutateField): Add imported types handling.
1655 2009-07-23 Marek Safar <marek.safar@gmail.com>
1657 * expression.cs, delegate.cs: Moved arguments resolve into their
1658 counterparts expressions. Removed argument resolve from
1659 CollectionElementInitializer.
1661 2009-07-23 Marek Safar <marek.safar@gmail.com>
1663 A fix for bug #523683
1664 * convert.cs, delegate.cs: Use common overload mechanism for method
1665 group conversion check.
1667 2009-07-22 Marek Safar <marek.safar@gmail.com>
1669 A fix for bug #523899
1670 * generics.cs: Exact type inference with other bound types.
1672 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1674 Don't complain when the same type is implemented by the output
1675 assembly as well as multiple referenced assemblies
1676 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1677 'must_be_unique' flag.
1678 (GlobalRootNamespace): Update to changes.
1679 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1680 already have a type in hand.
1682 2009-07-22 Marek Safar <marek.safar@gmail.com>
1684 * expression.cs: More verifier instrumentation.
1686 * statement.cs: Do proper throw expression conversion.
1688 2009-07-22 Marek Safar <marek.safar@gmail.com>
1690 A fix for bug #522789
1691 * expression.cs: Mutate invocation return type.
1693 2009-07-16 Marek Safar <marek.safar@gmail.com>
1695 * anonymous.cs: Split assignable and readonly generated variable
1698 2009-07-16 Marek Safar <marek.safar@gmail.com>
1700 A fix for bug #521671
1701 * statement.cs: Fixed crash when checking missing type.
1703 2009-07-16 Marek Safar <marek.safar@gmail.com>
1705 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1706 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1707 class.cs, driver.cs: Work on dynamic binding.
1709 * dynamic.cs: New file.
1711 * *.sources, *.proj: Updated.
1713 2009-07-15 Marek Safar <marek.safar@gmail.com>
1715 * expression.cs (Conditional): Avoid double Resolve.
1717 2009-07-13 Marcus Griep <marcus@griep.us>
1719 * ecore.cs: Fix obscure bug with resolving members of interfaces
1720 that hide parent interface members. Fixes bug #444388 and corrects
1723 2009-07-13 Marek Safar <marek.safar@gmail.com>
1725 * expression.cs (LocalVariableReference): Bounce resolve.
1727 2009-07-10 Marek Safar <marek.safar@gmail.com>
1729 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1730 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1733 * support.cs: New dynamic type wrapper.
1735 2009-07-08 Marek Safar <marek.safar@gmail.com>
1737 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1738 typed local variable.
1740 2009-07-06 Marek Safar <marek.safar@gmail.com>
1742 A fix for bug #519005
1743 * anonymous.cs: Use null_type as no return type placeholder.
1745 2009-07-02 Marek Safar <marek.safar@gmail.com>
1747 * generic.cs: Handle type inference of identical type parameters
1748 with different bounds.
1750 2009-07-01 Marek Safar <marek.safar@gmail.com>
1752 * expression.cs, class.cs: Events variance.
1754 * cs-parser.jay: Interface events error messages.
1756 2009-07-01 Marek Safar <marek.safar@gmail.com>
1758 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1760 2009-06-29 Marek Safar <marek.safar@gmail.com>
1762 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1763 parameter expression can be value-type New.
1765 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1767 2009-06-26 Marek Safar <marek.safar@gmail.com>
1769 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1770 Implemented C# 4.0 named arguments.
1772 2009-06-24 Marek Safar <marek.safar@gmail.com>
1774 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1775 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1776 parameter modifier. Also fixes bug #515497.
1778 2009-06-24 Marek Safar <marek.safar@gmail.com>
1780 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1781 arguments expression to be implemented.
1783 *.sources: Add argument.cs
1785 2009-06-23 Marek Safar <marek.safar@gmail.com>
1787 * parameter.cs: Moved GetParameterIndexByName to base class.
1789 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1790 unused AType. Use argument's version of GetExpressionTree.
1792 2009-06-22 Marek Safar <marek.safar@gmail.com>
1794 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1797 2009-06-17 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #514096
1800 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1802 2009-06-17 Marek Safar <marek.safar@gmail.com>
1804 * expression.cs: The first multi-dimensional array nested array
1805 initializers was not checked.
1807 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1809 2009-06-17 Marek Safar <marek.safar@gmail.com>
1811 A fix for bug #513400
1812 * nullable.cs (EmitEquality): Operands emit could be simplified for
1813 built-in types when we now emit user operators differently.
1815 2009-06-16 Marek Safar <marek.safar@gmail.com>
1817 * ecore.cs: Report inaccessible delegate methods correctly.
1819 2009-06-16 Marek Safar <marek.safar@gmail.com>
1821 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1822 cs-parser.jay: Implemented C# 4.0 optional parameters.
1824 2009-06-16 Marek Safar <marek.safar@gmail.com>
1826 * driver.cs: Removed broken DefineManifestResource.
1828 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1830 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1831 Use $(BOOTSTRAP_PROFILE) instead.
1833 2009-06-12 Jb Evain <jbevain@novell.com>
1835 * rootcontext.cs: add a Platform field.
1836 * driver.cs: handle /platform.
1837 * codegen.cs: pass the proper flags according to
1838 the platform when saving the assembly.
1840 2009-06-11 Marek Safar <marek.safar@gmail.com>
1842 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1843 Add optional parameters grammar.
1845 2009-06-10 Marek Safar <marek.safar@gmail.com>
1847 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1848 driver.cs: Split lang version and metadata version.
1850 2009-06-10 Marek Safar <marek.safar@gmail.com>
1852 * decl.cs: Better overload ctor collision error message.
1854 2009-06-05 Jb Evain <jbevain@novell.com>
1856 * driver.cs (EmbededResource): avoid using an internal method
1857 in gmcs to embed manifest resources.
1859 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1861 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1862 the compiler from older mono versions (like moon's bots)
1864 2009-06-04 Marek Safar <marek.safar@gmail.com>
1866 * namespace.cs (LookupTypeReflection): Ignore collisions between
1869 2009-06-04 Marek Safar <marek.safar@gmail.com>
1871 * codegen.cs: Enabled generic type forwarders.
1873 2009-06-04 Marek Safar <marek.safar@gmail.com>
1875 * dmcs.*: Add another version of SRE compiler.
1877 2009-06-03 Marek Safar <marek.safar@gmail.com>
1879 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1880 generic-mcs.cs: Fixed variant type conversions.
1882 2009-06-02 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #507863
1885 * codegen.cs: Fixes a crash on invalid string value attribute.
1887 2009-06-01 Marek Safar <marek.safar@gmail.com>
1889 A fix for bug #508334
1890 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1891 cs-parser.jay: Fully import __arglist modifier.
1893 2009-05-29 Marek Safar <marek.safar@gmail.com>
1895 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1896 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1897 actually work with closed generic types.
1899 2009-05-27 Alan McGovern <amcgovern@novell.com>
1901 * class.cs, decl.cs, delegate.cs, parameter.cs:
1902 Fix the build by replacing the use of 'var' with the actual type.
1904 2009-05-27 Marek Safar <marek.safar@gmail.com>
1906 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1907 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1910 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1913 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1914 Marek Safar <marek.safar@gmail.com>
1916 A fix for bug #377509
1917 * parameter.cs: Use predefined and not empty name for implicit
1920 2009-05-21 Marek Safar <marek.safar@gmail.com>
1922 * class.cs: Don't report wrong warnings for event fields.
1924 2009-05-21 Marek Safar <marek.safar@gmail.com>
1926 A fix for bug #504667
1927 * class.cs: Check for static class using parent container instead of
1930 2009-05-08 Marek Safar <marek.safar@gmail.com>
1932 A fix for bug #496922
1933 * expression.cs: Always use temporary variable when using object
1936 2009-04-28 Marek Safar <marek.safar@gmail.com>
1938 A fix for bug #495112
1939 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1942 2009-04-27 Miguel de Icaza <miguel@novell.com>
1944 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1946 2009-04-24 Miguel de Icaza <miguel@novell.com>
1948 * complete.cs: No idea how gonzalo got a null in the list, but
1951 2009-04-24 Miguel de Icaza <miguel@novell.com>
1953 * complete.cs (CompletionElementInitializer): New completion class
1954 to support completing inside a C# 3 element initializer, so this
1955 allows completion for Silverlight situations where it is very
1958 new TextBlock () { Fo<TAB>
1960 (CompletionSimpleName): Expose the prefix that was
1961 passed to the simple name.
1963 * cs-parser.jay (object_or_collection_initializer): Add support
1964 for element_initializers.
1966 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1967 special case completion expressions as this method aggressively
1968 collects data before it operates, and errors were being thrown
1969 earlier than we were able to complete.
1971 2009-04-23 Miguel de Icaza <miguel@novell.com>
1973 * eval.cs: Make getcompletions silent and enable debugging output
1974 if the -v option is passed.
1976 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1977 Consider looking up the namespace that matches the prefix being
1980 This is part of the support for allowing completions like:
1981 `System.Co<TAB>' to complete to System.Console.
1983 * complete.cs (CompletionSimpleName.AppendResults): Make this
1986 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1988 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1989 COMPLETE_COMPLETION as internal.
1991 2009-04-17 Miguel de Icaza <miguel@novell.com>
1993 * complete.cs: Include namespace resolution in simple names as
1994 well as global types and types in the using scope in the
1997 * namespace.cs: Supporting infrastrcture to provide completions
1998 based on the current using scope.
2000 * eval.cs: Introduce an entry point that allows for initialization
2001 to return a list of the files passed on the command line.
2003 2009-04-14 Marek Safar <marek.safar@gmail.com>
2005 A fix for bug #494243
2006 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
2008 2009-04-13 Marek Safar <marek.safar@gmail.com>
2010 A fix for bug #493887
2011 * statement.cs: Don't skip string multi-section with default or
2012 null label when populating string hashtable.
2014 2009-04-06 Marek Safar <marek.safar@gmail.com>
2016 A fix for bug #492329
2017 * expression.cs (New): Load variable when assigning type parameter
2020 2009-04-06 Marek Safar <marek.safar@gmail.com>
2022 A fix for bug #488960
2023 * decl.cs: Compare MVAR types using non-null values.
2025 2009-03-27 Marek Safar <marek.safar@gmail.com>
2027 * typemanager.cs, expression.cs: Removed unused nullable checks.
2029 2009-03-27 Marek Safar <marek.safar@gmail.com>
2031 * *.cs: Removed some gmcs conditionals.
2033 2009-03-26 Marek Safar <marek.safar@gmail.com>
2035 * generic.cs, support.cs: Moved generics stuff out of support.cs
2037 2009-03-24 Marek Safar <marek.safar@gmail.com>
2039 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
2042 2009-03-23 Marek Safar <marek.safar@gmail.com>
2044 * attribute.cs: Consider all members for error reporting when
2045 checking named arguments.
2047 2009-03-23 Marek Safar <marek.safar@gmail.com>
2049 A fix for bug #487625
2050 * namespace.cs: Use a warning for all predefined type conflicts.
2052 2009-03-23 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #485706
2055 * statement.cs: Explicitly type catch type argument to pass verifier
2058 2009-03-22 Miguel de Icaza <miguel@novell.com>
2060 Initial support to provide code completion facilities to consumers
2061 of the evaluator API.
2063 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2064 support the completion engine. When we reach the end of the
2065 input stream instead of returning EOF, when this flag is true the
2066 tokenizer instead produces:
2068 One GENERATE_COMPLETION token: this token then must be
2069 handled in the grammar at every point where the user
2070 would likely request a completion.
2072 As many COMPLETE_COMPLETION tokens as necessary. These
2073 tokens are generated to assist the parser in unwinding and
2074 producing a valid parse tree.
2076 The parser rules do not have to be perfect, the parser needs to be
2077 augmented with judicious use of GENERATE_COMPLETION tokens to
2078 improve the areas where we can provide completion and the parser
2079 needs to add support for COMPLETE_COMPLETION tokens in productions
2082 It is common to not have enough support for COMPLETE_COMPLETION
2083 under certain rules and that even if we generated the
2084 GENERATE_COMPLETION token that the resulting tree will be invalid
2085 due to the missing rules that support COMPLETE_COMPLETION.
2087 The final EOF token is produced by having the parser notify the
2088 tokenizer when it reaches the root production that the next token
2091 * support.cs (CompletionResult): New Exception. This exception
2092 is thrown to return the completion results when one of the special
2093 completion expressions is reached.
2095 This exception is thrown by the completing ExpressionStatements
2096 classes that live in complete.cs
2098 * complete.cs (CompletingExpression): a new base class for
2099 completing expressions. This derives from the
2100 ExpressionStatement class and not from Expression as it allows
2101 completion to happen not only where expressions are expected in
2102 the grammar, but also where statements are expected.
2104 (CompletionSimpleName): A new class used to provide completions
2105 for SimpleNames. This currently only resolves to local
2106 variables from the evaluator context (GetVars call).
2108 (CompletionMemberAccess): Implements support for completing member
2111 * cs-parser.jay: Add support for completion in a few places.
2113 * eval.cs (GetCompletions): New public API for the evaluator that
2114 returns a list of possible completions given the input. The
2115 return value is an array of completions
2117 * anonymous.cs (Compatible): If the exception thrown from the
2118 resolved expression is a CompletionResult exception let that one
2119 through instead of printing a diagnostic error in the try/catch.
2121 2009-03-22 Miguel de Icaza <miguel@novell.com>
2125 * driver.cs (Main): Use Environment.Exit to quit quickly and
2126 prevent the compiler from doing the usual wait for helper thread
2129 This is to prevent a slowdown that was reported by Gonzalo on
2132 2009-03-19 Marek Safar <marek.safar@gmail.com>
2134 * ecore.cs: Load build-in types directly instead of accessing
2137 2009-03-18 Marek Safar <marek.safar@gmail.com>
2139 * ecore.cs: Always use unbox.any when available.
2141 2009-03-18 Marek Safar <marek.safar@gmail.com>
2143 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2145 2009-03-17 Marek Safar <marek.safar@gmail.com>
2147 * generic.cs: Removed obsolete version of type inference.
2149 2009-03-16 Marek Safar <marek.safar@gmail.com>
2151 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2152 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2153 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2154 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2156 2009-03-11 Marek Safar <marek.safar@gmail.com>
2158 A fix for bug #482996
2159 * anonymous.cs: Make sure we are not infering return type when
2160 checking type compatibility.
2162 2009-03-11 Marek Safar <marek.safar@gmail.com>
2164 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2165 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2166 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2167 attributes in their own structure. Needed when accessing their
2168 properties before they are resolved.
2170 2009-03-09 Marek Safar <marek.safar@gmail.com>
2172 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2173 hashtable (~10x faster).
2175 * driver.cs: Removed wrong Reset.
2177 2009-03-08 Marek Safar <marek.safar@gmail.com>
2179 * class.cs: Use correct common base type for unmanaged delayed
2182 * rootcontext.cs: Wrap unhandled exception.
2184 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2186 Make SeekableStreamReader self-tuning and arbitrarily seekable
2187 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2189 (SeekableStreamReader.Position.set): Use it. Simplify logic
2190 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2191 buffer size when the stream needs to be re-read from the beginning.
2193 2009-03-05 Marek Safar <marek.safar@gmail.com>
2195 A fix for bug #480100
2196 * parameter.cs: A parameter is not hoisted when used directly as ET.
2198 2009-03-04 Marek Safar <marek.safar@gmail.com>
2200 * statement.cs: Fixed an issue when using variable is of interface
2203 2009-03-03 Marek Safar <marek.safar@gmail.com>
2205 A fix for bug #480319
2206 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2208 2009-03-03 Marek Safar <marek.safar@gmail.com>
2210 A fix for bug #480867
2211 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2212 expression to have no valid type.
2214 2009-03-03 Marek Safar <marek.safar@gmail.com>
2216 A fix for bug #481258
2217 * class.cs: Set extension method flag in partial container.
2219 2009-03-03 Marek Safar <marek.safar@gmail.com>
2221 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2223 * attribute.cs: Add sanity check.
2225 2009-02-27 Marek Safar <marek.safar@gmail.com>
2227 * class.cs: Add external constructor error.
2229 2009-02-26 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #475354
2232 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2233 correctly user defined nullable equality operators.
2235 2009-02-25 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #479532
2238 * expression.cs: Implement NewInitialize::AddressOf.
2240 2009-02-25 Marek Safar <marek.safar@gmail.com>
2242 A fix for bug #413633
2243 * expression.cs: Iterate all base class-constraint types.
2245 2009-02-24 Marek Safar <marek.safar@gmail.com>
2247 A fix for bug #479209
2248 * literal.cs: Mutate null underlying type.
2250 2009-02-24 Marek Safar <marek.safar@gmail.com>
2252 A fix for bug #476295
2253 * convert.cs: Avoid wrapping implicitly convertible reference type.
2255 2009-02-23 Marek Safar <marek.safar@gmail.com>
2257 * iterators.cs: Create MemberName correctly.
2259 2009-02-23 Marek Safar <marek.safar@gmail.com>
2261 A fix for bug #478655
2262 * literal.cs: Check also underlying null type conversion.
2264 2009-02-21 Marek Safar <marek.safar@gmail.com>
2266 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2268 2009-02-20 Marek Safar <marek.safar@gmail.com>
2270 A fix for bug #477447
2271 * statement.cs: Add reference to correct parent storey when this
2272 is accessible from deep children storey (more than 1 level).
2274 2009-02-19 Marek Safar <marek.safar@gmail.com>
2276 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2277 * class.cs: Define base type members before setting up member cache.
2279 2009-02-18 Marek Safar <marek.safar@gmail.com>
2281 A fix for bug #477378
2282 * nullable.cs, expression.cs, statement.cs: More precise null type
2285 2009-02-18 Marek Safar <marek.safar@gmail.com>
2287 A fix for bug #472805
2288 * typemanager.cs, namespace.cs: Import only visible extension method
2291 2009-02-18 Marek Safar <marek.safar@gmail.com>
2293 A fix for bug #476895
2294 * attribute.cs: Use correct resolve context for attribute type.
2296 2009-02-18 Marek Safar <marek.safar@gmail.com>
2298 A fix for bug #476266
2299 * anonymous.cs: Mutate multi-dimensional arrays.
2301 2009-02-18 Marek Safar <marek.safar@gmail.com>
2303 A fix for bug #476400
2304 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2306 2009-02-18 Marek Safar <marek.safar@gmail.com>
2308 A fix for bug #476811
2309 * generics.cs: Fixed null-literal check.
2311 2009-02-17 Marek Safar <marek.safar@gmail.com>
2313 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2314 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2315 messing with static variables.
2317 2009-02-16 Marek Safar <marek.safar@gmail.com>
2319 A fix for bug #475965
2320 * generics.cs: Check generic parameter type after extracting from
2323 2009-02-16 Marek Safar <marek.safar@gmail.com>
2325 A fix for bug #475823
2326 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2329 2009-02-14 Marek Safar <marek.safar@gmail.com>
2331 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2332 Simplified event field definition using backing field and not
2333 field builder directly.
2335 * expression.cs (EmitLdArg): Optimize fast paths.
2337 2009-02-13 Marek Safar <marek.safar@gmail.com>
2339 A fix for bug #475327
2340 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2342 2009-02-13 Marek Safar <marek.safar@gmail.com>
2344 A fix for bug #475342
2345 * cs-parser.jay: Using 'super' instead of 'base' to call base
2346 constructor crashes compiler.
2348 2009-02-13 Marek Safar <marek.safar@gmail.com>
2350 A fix for bug #475354
2351 * expression.cs (Constantify): Add nullable types.
2353 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2355 2009-02-12 Marek Safar <marek.safar@gmail.com>
2357 A fix for bug #475246
2358 * expression.cs: More broken flowanalysis hacking needed.
2360 2009-02-12 Marek Safar <marek.safar@gmail.com>
2362 * attribute.cs: Compare only ref/out array modifiers.
2364 2009-02-11 Marek Safar <marek.safar@gmail.com>
2366 * statement.cs: Use member cache when looking for foreach members.
2368 2009-02-11 Marek Safar <marek.safar@gmail.com>
2370 * expression.cs: Don't expose internal initializer types.
2372 * statement.cs: Check also explicit conversions for goto case.
2374 2009-02-11 Marek Safar <marek.safar@gmail.com>
2376 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2378 2009-02-10 Marek Safar <marek.safar@gmail.com>
2380 * *.cs: Replace null-type with NullLiteral where appropriate.
2382 2009-02-09 Marek Safar <marek.safar@gmail.com>
2384 * expression.cs: Initializer of reference argument use temporary
2385 variable to be verifiable.
2387 * parameter.cs: Share EmitLdArg.
2389 2009-02-09 Marek Safar <marek.safar@gmail.com>
2391 A fix for bug #473559
2392 * class.cs: Fixed: Not reporting error about nested class with the
2395 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2397 Contributed under the MIT/X11 license.
2399 * generic.cs: Added VerifyVariantTypeParameters which performs new
2400 variance verification logic. The old logic, based on the spec, was
2401 wrong because the spec is full of LIES!
2403 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2405 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2408 * ecore.cs: Added calls to the new variance verification logic.
2411 * delegate.cs: Removed calls to the old variance verification logic.
2413 2009-02-06 Marek Safar <marek.safar@gmail.com>
2415 * delegate.cs: Use cached Invoke method directly.
2417 2009-02-06 Marek Safar <marek.safar@gmail.com>
2419 * expression.cs: Emit expression tree for hoisted variable access.
2421 2009-02-04 Marek Safar <marek.safar@gmail.com>
2423 * namespace.cs: Add better extension class check.
2425 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2427 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2429 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2431 This patch adds initial generic variance support to the compiler.
2432 It is contributed under the MIT/X11 license.
2434 * typemanager.cs: Modified ImplementsInterface to check variance.
2435 Added VerifyVariantTypeParameters which checks the specified type to see
2436 if it uses a variant type parameter as a type argument (which is not
2437 allowed). Added IsVariantOf which determins if the first type is a
2438 variant of the second. NOTE: This only supports reference types at
2439 the moment to conform with the current level of VM support. When the
2440 VM supports value types, this will follow step.
2442 * generic.cs: Added the Variance enum. Added a Variance property to
2443 TypeParameter and added variance support to definition phase. Added a
2444 Variance property to TypeParameterName. Also check to make sure that
2445 no variant types appear in generic method parameters.
2447 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2448 keywords if the langversion supports it.
2450 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2451 that variant types are only used in legal positions. Also added
2452 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2455 * decl.cs: Construct TypeParameter with the variance information.
2457 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2458 and ImplicitConversionStandard.
2460 * rootcontext.cs: Added new "Future" language version.
2462 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2463 type parameters are not used as type arguments in interface inheritance.
2464 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2465 parameters are not used as method return types. In MemberBase.
2466 ResolveMemberType, ensure that variant type parameters are not used
2467 as type arguments. Also call VerifyNoVariantTypeParameters on every
2468 set of parameters which are resolved.
2470 * delegate.cs: Modified Delegate.Define to ensure that variant
2471 parameters are not used as type arguments and that a contravariant
2472 parameter is not used as the return type. Also call
2473 VerifyNoVariantTypeParameters on the delegate parameters.
2475 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2476 to specify generic variance.
2478 * driver.cs: Added support for LanguageVersion.Future in the form of
2479 "-langversion:future".
2481 * generic-mcs.cs: Stubbed out new members in generic.cs.
2483 2009-02-03 Marek Safar <marek.safar@gmail.com>
2485 * class.cs, generic.cs: Emit type parameter constraints for nested
2488 2009-02-02 Marek Safar <marek.safar@gmail.com>
2490 A fix for bug #471213
2491 * class.cs: Avoid emitting backing field for abstract event fields.
2493 2009-02-01 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #359731
2496 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2499 2009-01-30 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #470767
2502 * statement.cs: Introduced BlockScopeExpression, needed when
2503 expression tree conversion has to emit scope variables.
2505 2009-01-29 Marek Safar <marek.safar@gmail.com>
2507 * class.cs: Remove duplicate CallingConvention.
2509 2009-01-29 Marek Safar <marek.safar@gmail.com>
2511 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2512 when I finally found the right naming convention.
2514 2009-01-29 Marek Safar <marek.safar@gmail.com>
2516 * cs-tokenizer.cs: Put back different open parens optimization.
2518 2009-01-28 Marek Safar <marek.safar@gmail.com>
2520 A fix for bug #470227
2521 * cs-tokenizer.cs: Remove too agressive parser optimization.
2523 2009-01-28 Marek Safar <marek.safar@gmail.com>
2525 A fix for bug #324319
2526 * class.cs: Remove too early base type resolve.
2528 2009-01-27 Marek Safar <marek.safar@gmail.com>
2530 A fix for bug #324319
2531 * ecore.cs: Explicitly type null when assigning to type argument to
2532 make pass verifier check.
2534 2009-01-27 Marek Safar <marek.safar@gmail.com>
2536 * anonymous.cs: Fixed recent regression when initializing captured
2539 2009-01-26 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #469019
2542 * anonymous.cs: Use all parent type parameters when instantiating
2543 nested generic storey.
2545 2009-01-26 Marek Safar <marek.safar@gmail.com>
2547 * expression.cs: Check for null instance methodgroup expression.
2549 2009-01-26 Marek Safar <marek.safar@gmail.com>
2551 A fix for bug #469244
2552 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2553 instance inside a conditional expression.
2555 2009-01-23 Marek Safar <marek.safar@gmail.com>
2557 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2558 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2559 GetElementType and HasElementType. IsValueType clean up.
2561 2009-01-23 Marek Safar <marek.safar@gmail.com>
2563 * nullable.cs: Use common EmitCall.
2565 * expression.cs: Emit constraint. for virtual calls only.
2567 2009-01-23 Marek Safar <marek.safar@gmail.com>
2569 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2570 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2571 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2574 2009-01-22 Jb Evain <jbevain@novell.com>
2576 * anonymous.cs: make anonymous types' ToString implementation
2577 match what csc outputs.
2579 2009-01-21 Marek Safar <marek.safar@gmail.com>
2581 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2584 2009-01-17 Marek Safar <marek.safar@gmail.com>
2586 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2589 2009-01-16 Marek Safar <marek.safar@gmail.com>
2591 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2594 2009-01-15 Marek Safar <marek.safar@gmail.com>
2596 A fix for bug #466634
2597 * statement.cs: Add reference for nested storey when only this
2600 2009-01-15 Marek Safar <marek.safar@gmail.com>
2602 A fix for bug #466474
2603 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2606 2009-01-15 Marek Safar <marek.safar@gmail.com>
2608 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2609 Fixed nested stories parent referencing process. Also fixes #463985.
2611 2009-01-06 Marek Safar <marek.safar@gmail.com>
2613 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2614 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2615 implementation. Also fixes #463108.
2617 2009-01-05 Marek Safar <marek.safar@gmail.com>
2619 A fix for bug #416109
2620 * decl.cs: Issue correct CLSAttribute warning location.
2622 2009-01-05 Marek Safar <marek.safar@gmail.com>
2624 A fix for bug #456775
2625 * attribute.cs: Use attribute owner scope when resolving attribute
2628 2009-01-05 Marek Safar <marek.safar@gmail.com>
2630 A fix for bug #457257
2631 * decl.cs: Fixed incorrect member declaring type comparison.
2633 2009-01-05 Marek Safar <marek.safar@gmail.com>
2635 A fix for bug #460896
2636 * driver.cs: Handle /RES resources as embeddable.
2638 2009-01-05 Marek Safar <marek.safar@gmail.com>
2640 A fix for bug #462515
2641 * ecore.cs: Report inacessible members upwards.
2643 2009-01-05 Marek Safar <marek.safar@gmail.com>
2645 A fix for bug #463190, #463192
2646 * decl.cs, namespace.cs: Also import internal extension classes.
2648 2009-01-04 Marek Safar <marek.safar@gmail.com>
2650 A fix for bug #463415
2651 * generic.cs: Use right index for RemoveDependentTypes.
2653 2009-01-02 Marek Safar <marek.safar@gmail.com>
2655 A fix for bug #463196
2656 * expression.cs: Fixed enum to null comparison.
2658 2009-01-02 Marek Safar <marek.safar@gmail.com>
2660 A fix for bug #463121
2661 * nullable.cs: Fixed nullable user equality operator comparison.
2663 2009-01-02 Marek Safar <marek.safar@gmail.com>
2665 A fix for bug #462950
2666 * class.cs, decl.cs: Use full explicit name when defining automatic
2667 property backing field.
2669 2009-01-02 Marek Safar <marek.safar@gmail.com>
2671 A fix for bug #462592
2672 * pending.cs: Emit type arguments for generic proxy method.
2674 2008-12-30 Marek Safar <marek.safar@gmail.com>
2676 * expression.cs (As): Mutate all type arguments.
2678 2008-12-29 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #462622
2681 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2684 2008-12-29 Marek Safar <marek.safar@gmail.com>
2686 A fix for bug #450782
2687 * ecore.cs: Consider more variables of form V.I to be fixed.
2689 2008-12-29 Marek Safar <marek.safar@gmail.com>
2691 A fix for bug #460712
2692 * typemanager.cs: Core types could be imported.
2694 2008-12-28 Marek Safar <marek.safar@gmail.com>
2696 A fix for bugs #460847, #460772, #458049, #457339, #447807
2697 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2698 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2699 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2700 user lambdas used inside query clauses.
2702 2008-12-18 Marek Safar <marek.safar@gmail.com>
2704 A fix for bug #460229
2705 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2707 2008-12-18 Marek Safar <marek.safar@gmail.com>
2709 A fix for bug #459952
2710 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2712 2008-12-18 Marek Safar <marek.safar@gmail.com>
2714 A fix for bug #459630
2715 * convert.cs: Enum to valuetype conversion is not allowed.
2717 2008-12-18 Marek Safar <marek.safar@gmail.com>
2719 A fix for bug #457087
2720 * generic.cs: Don't crash when constraint comes from type
2723 2008-12-16 Marek Safar <marek.safar@gmail.com>
2725 A fix for bug #459221
2726 * anonymous.cs, statement.cs: Delay only captured this
2729 2008-12-12 Marek Safar <marek.safar@gmail.com>
2731 A fix for bug #457489
2732 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2733 and initialization to capture scope initializers correctly.
2735 2008-12-11 Marek Safar <marek.safar@gmail.com>
2737 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2738 ParameterReference refactoring.
2740 2008-12-03 Marek Safar <marek.safar@gmail.com>
2742 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2743 to be imported from any assembly.
2745 2008-12-03 Marek Safar <marek.safar@gmail.com>
2747 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2748 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2749 from anonymous method and lambda expression.
2751 2008-12-01 Marek Safar <marek.safar@gmail.com>
2753 A fix for bug #448560
2754 * expression.cs (As): Box any generic type arguments to be
2757 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2759 Add tripwire for implicit conversion bugs
2760 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2762 (MethodGroupExpr.OverloadResolve): Add sanity check between
2763 IsApplicable and VerifyArgumentsCompat.
2764 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2766 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2768 Fix build break in System.Data_test
2769 * convert.cs (ImplicitConversionExists): Move NullLiteral
2771 (ImplicitStandardConversionExists): ... here.
2773 2008-11-28 Marek Safar <marek.safar@gmail.com>
2775 * literal.cs: Emit correctly explicit null to nullable cast.
2777 2008-11-28 Marek Safar <marek.safar@gmail.com>
2779 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2782 2008-11-28 Marek Safar <marek.safar@gmail.com>
2784 A fix for bug #449005
2785 * convert.cs, nullable.cs: Use only one implicit nullable
2788 2008-11-27 Marek Safar <marek.safar@gmail.com>
2790 * convert.cs, literal.cs: More Convert cleanup is needed.
2792 2008-11-27 Marek Safar <marek.safar@gmail.com>
2794 * decl.cs, class.cs: Fixed misleading error message.
2796 2008-11-26 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #449005
2799 * nullable.cs (EmitEquality): Disable optimization for user operator
2802 2008-11-25 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #447027
2805 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2806 with context variables stored as expression instances.
2808 2008-11-25 Marek Safar <marek.safar@gmail.com>
2810 A fix for bug #447027
2811 * delegate.cs: Fixed delegate VerifyMethod logic.
2813 2008-11-24 Marek Safar <marek.safar@gmail.com>
2815 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2818 2008-11-21 Marek Safar <marek.safar@gmail.com>
2820 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2821 member type resolve to follow normal flow, instead of random
2824 2008-11-21 Marek Safar <marek.safar@gmail.com>
2826 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2829 2008-11-21 Marek Safar <marek.safar@gmail.com>
2831 * const.cs: Emit decimal array constant as literal.
2833 2008-11-20 Marek Safar <marek.safar@gmail.com>
2835 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2837 2008-11-19 Marek Safar <marek.safar@gmail.com>
2839 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2840 into real property (saves 8 MB for corlib compilation).
2842 2008-11-19 Marek Safar <marek.safar@gmail.com>
2844 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2845 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2846 generic-mcs.cs: Small cleanup of TypeArguments.
2848 2008-11-18 Marek Safar <marek.safar@gmail.com>
2850 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2851 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2852 of ConstructedType expression, renamed to GenericTypeExpr.
2854 2008-11-17 Marek Safar <marek.safar@gmail.com>
2856 A fix for bug #445303
2857 * location.cs (IsConditionalDefined): Handle undefined global
2860 2008-11-17 Marek Safar <marek.safar@gmail.com>
2862 A fix for bug #444678
2863 * expression.cs (TryReduceConstant): Always create new constant
2866 2008-11-17 Marek Safar <marek.safar@gmail.com>
2868 A fix for bug #444673
2869 * ecore.cs: Ignore open generic types when used as generic type
2872 2008-11-17 Marek Safar <marek.safar@gmail.com>
2874 A fix for bug #445458
2875 * expression.cs, cs-parser.jay: Don't crash when an expression
2878 2008-11-17 Marek Safar <marek.safar@gmail.com>
2880 A fix for bug #445464
2881 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2882 inside unbound type.
2884 2008-11-14 Jb Evain <jbevain@novell.com>
2886 * driver.cs: ignore empty -nowarn argument such as
2887 the one in -nowarn:12,13,,.
2889 2008-11-13 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #444271
2892 * anonymous.cs: Rescan parent storeys when best candidate was
2895 2008-11-13 Marek Safar <marek.safar@gmail.com>
2897 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2898 useless UnboundTypeExpression.
2900 * attribute.cs: Do check obsolete attribute on generic types.
2902 2008-11-12 Marek Safar <marek.safar@gmail.com>
2904 A fix for bugs #425680, #400139
2905 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2908 2008-11-11 Marek Safar <marek.safar@gmail.com>
2910 A fix for bug #435747
2911 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2912 compound value types assignment. Few micro optimizations added.
2914 2008-11-10 Marek Safar <marek.safar@gmail.com>
2916 A fix for bug #442610
2917 * anonymous.cs (MutateConstructor): More SRE hacking.
2919 2008-11-10 Marek Safar <marek.safar@gmail.com>
2921 A fix for bug #442579
2922 * ecore.cs: Also initialize expanded form of a method with 1 params
2925 2008-11-06 Marek Safar <marek.safar@gmail.com>
2927 * expression.cs (UnaryMutator): Do early l-side check.
2929 2008-11-05 Miguel de Icaza <miguel@novell.com>
2931 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2932 Init, otherwise we would crash later on when checking for friend
2935 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2936 Otherwise we never get any meaningful information as to what
2939 2008-11-05 Marek Safar <marek.safar@gmail.com>
2941 A fix for bug #436318
2942 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2944 2008-11-05 Miguel de Icaza <miguel@novell.com>
2946 * namespace.cs: Turns out that it was a really bad idea to hide
2947 the errors for namespaces not found here in eval mode.
2949 * eval.cs: When we process using clauses, only enter those into
2950 the list of valid using clauses after they have been validated.
2952 The above change gives the proper semantics: it does not
2953 senselessly report the same errors with broken using statements by
2954 never storing them in the first place when they are invalid.
2956 2008-11-05 Marek Safar <marek.safar@gmail.com>
2958 A fix for bug #421839
2959 * cs-parser.jay: Remove expression from coalesce rule to force lower
2960 priority than the assignment operator.
2962 2008-11-05 Marek Safar <marek.safar@gmail.com>
2964 A fix for bug #437875
2965 * nullable.cs: Compile correctly method group operand used with null
2966 coalescing operator.
2968 2008-11-04 Marek Safar <marek.safar@gmail.com>
2970 A fix for bug #434589
2971 * expression.cs (Binary): Ignore lifted conversions when at least
2972 one operand is of reference type.
2974 2008-11-04 Marek Safar <marek.safar@gmail.com>
2976 * cs-parser.jay: Better syntax error report.
2978 2008-11-03 Marek Safar <marek.safar@gmail.com>
2980 A fix for bug #436792
2981 * cs-parser.jay: Use GetLocation to access location.
2983 2008-11-03 Marek Safar <marek.safar@gmail.com>
2985 A fix for bug #440774
2986 * cs-parser.jay: Also set current_array_type when parsing local
2989 2008-11-03 Marek Safar <marek.safar@gmail.com>
2991 A fix for bug #440785
2992 * expression.cs (As): Don't resolve self modifing expression
2995 2008-11-03 Marek Safar <marek.safar@gmail.com>
2997 A fix for bug #439447
2998 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
3000 2008-11-03 Marek Safar <marek.safar@gmail.com>
3002 A fix for bug #437571
3003 * cs-parser.jay: Fixes internal error for invalid expression
3006 2008-10-17 Marek Safar <marek.safar@gmail.com>
3008 * ecore.cs: Resolve correctly ambiguous params delegate methods.
3010 2008-10-17 Marek Safar <marek.safar@gmail.com>
3012 * generic.cs, anonymous.cs: Simplified GetDeclarations.
3014 2008-10-17 Marek Safar <marek.safar@gmail.com>
3016 * cs-tokenizer.cs: More precise cast parsing.
3018 2008-10-16 Martin Baulig <martin@ximian.com>
3020 * anonymous.cs (AnonymousMethodStorey): Put back the
3021 `hoisted_locals' hashtable and use it in EmitType().
3023 2008-10-15 Marek Safar <marek.safar@gmail.com>
3025 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
3026 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
3029 2008-10-14 Marek Safar <marek.safar@gmail.com>
3031 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
3033 2008-10-14 Marek Safar <marek.safar@gmail.com>
3035 * statement.cs: Mutate scope initializers.
3037 2008-10-14 Marek Safar <marek.safar@gmail.com>
3039 * expression.cs: Use typeless value for This constant.
3041 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
3043 2008-10-14 Marek Safar <marek.safar@gmail.com>
3045 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
3048 2008-10-13 Marek Safar <marek.safar@gmail.com>
3050 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3053 2008-10-13 Marek Safar <marek.safar@gmail.com>
3055 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3056 parser and tokenizer. Fixes many ambiguities including #433258.
3058 2008-10-10 Marek Safar <marek.safar@gmail.com>
3060 * cs-parser.jay: Fixed missing accessor recovery.
3062 2008-10-10 Marek Safar <marek.safar@gmail.com>
3064 A fix for bug #433701
3065 * expression.cs: Better error message.
3067 2008-10-10 Marek Safar <marek.safar@gmail.com>
3069 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3071 * Makefile: Disabled unused debug symbols.
3073 Also fixes: #320556, #321097, #321656, #321876, #351316
3075 2008-10-09 Miguel de Icaza <miguel@novell.com>
3077 * eval.cs: rename "<interactive>" to "{interactive}", to work
3078 around a requirement in the compiler that this be a valid
3079 filename, and in Windows it is not (433886).
3081 2008-10-09 Marek Safar <marek.safar@gmail.com>
3083 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3085 2008-10-08 Marek Safar <marek.safar@gmail.com>
3087 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3088 cs-parser.jay: Generic type declaration and type arguments cleanup.
3090 2008-10-05 Marek Safar <marek.safar@gmail.com>
3092 * cs-parser.jay: Allow parsing weird array creation construct.
3094 2008-10-05 Marek Safar <marek.safar@gmail.com>
3096 * cs-parser.jay: Conflicts reduction.
3098 2008-10-04 Marek Safar <marek.safar@gmail.com>
3100 * cs-parser.jay: Conflicts reduction.
3102 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3105 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3106 property. Add a 'count' hint about the use of the shared vector.
3107 Ensure that we don't leak out dirty bits.
3108 (UsageVector.MergeChild): Throw away information about variables
3110 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3112 2008-10-03 Marek Safar <marek.safar@gmail.com>
3114 A fix for bug #431746
3115 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3116 parameters when iterator is created.
3118 2008-10-03 Marek Safar <marek.safar@gmail.com>
3120 A fix for bug #431827
3121 * expression.cs: Fixed right based pointer arithmetic operations
3124 2008-10-03 Marek Safar <marek.safar@gmail.com>
3126 A fix for bug #353779
3127 * assign.cs, expression.cs: Fixed compound assignment conversions.
3129 2008-10-02 Marek Safar <marek.safar@gmail.com>
3131 A fix for bug #375262
3132 * statement.cs: Refactor ArrayForeach to be usable with string
3133 indexer. Optimized single dimentional arrays foreach.
3135 2008-10-02 Marek Safar <marek.safar@gmail.com>
3137 A fix for bug #431255
3138 * anonymous.cs, expression.cs: Removed broken optimization.
3140 2008-10-01 Marek Safar <marek.safar@gmail.com>
3142 * anonymous.cs: Use full type parameters of parent generic
3143 containers. Removed unnecessary AddParentStoreyReference call.
3145 2008-10-01 Marek Safar <marek.safar@gmail.com>
3147 A fix for bug #324702
3148 * class.cs: Use better shorter names for explicit interface member
3151 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3153 2008-10-01 Marek Safar <marek.safar@gmail.com>
3155 * expression.cs: Use new interface to check fixed expression.
3157 2008-10-01 Marek Safar <marek.safar@gmail.com>
3159 A fix for bug #421101
3160 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3161 interface to check for fixed fixed-buffers.
3163 2008-10-01 Marek Safar <marek.safar@gmail.com>
3165 A fix for bug #429264
3166 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3168 * delegate.cs: Removed unnecessary casts.
3170 2008-09-30 Marek Safar <marek.safar@gmail.com>
3172 A fix for bug #352151
3173 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3174 class.cs: Fixed already defined explicit interface members check.
3176 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3178 cs-tokenizer.cs: Fix typo.
3180 2008-09-28 Miguel de Icaza <miguel@novell.com>
3182 * eval.cs (InteractiveBase): The quit command now just sets a
3183 flag, instead of calling Environment.Exit(), it is milder on
3186 CompiledMethod is now in Mono.CSharp, not nested inside
3187 the Evaluator, it was inconvenient to use.
3189 2008-09-27 Miguel de Icaza <miguel@novell.com>
3191 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3192 code to be invoked without having to reparse.
3194 2008-09-27 Miguel de Icaza <miguel@novell.com>
3196 * ecore.cs: The recent changes to FieldExpr broke this as well.
3197 Fixes LINQ queries in the interactive shell.
3199 * Multiple files: indentation fixing for the Mono coding
3200 guidelines for the switch statement.
3202 * eval.cs: Make the Evaluator API thread safe.
3204 2008-09-26 Marek Safar <marek.safar@gmail.com>
3206 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3207 constructor parsing.
3209 2008-09-26 Marek Safar <marek.safar@gmail.com>
3211 A fix for bug #325326
3212 * statement.cs: Check possible mistaken empty statement using
3213 explicit blocks only.
3215 2008-09-25 Miguel de Icaza <miguel@novell.com>
3217 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3218 RootNamespace.ComputeNamespaces to update the internal list of
3219 namespaces, this is no longer done for us.
3221 (InteractiveBase): Use the Evaluator APIs instead of calling into
3224 2008-09-25 Marek Safar <marek.safar@gmail.com>
3226 A fix for bug #429264
3227 * expression.cs: Missing mutator for access to multidimensional
3230 2008-09-25 Marek Safar <marek.safar@gmail.com>
3232 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3235 * driver.cs: Missing input argument check.
3237 2008-09-25 Marek Safar <marek.safar@gmail.com>
3239 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3240 expression.cs, statement.cs, rootcontext.cs, class.cs,
3241 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3244 2008-09-24 Miguel de Icaza <miguel@novell.com>
3246 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3247 fully constructed FieldExpr, fixes the regression introduced in
3250 * ecore.cs, expression.cs: Plug back the eclass initialization as
3251 otherwise it regresses `csharp'.
3253 2008-09-24 Marek Safar <marek.safar@gmail.com>
3255 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3256 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3257 phase to resolve phase. It resolves problems with expression trees
3258 and fixes bugs #323796, #325156.
3260 2008-09-23 Marek Safar <marek.safar@gmail.com>
3262 * codegen.cs: Report better error when symbol writer is missing.
3264 2008-09-23 Marek Safar <marek.safar@gmail.com>
3266 * codegen.cs: Set .NET symbol writer.
3268 * decl.cs: Guard against null generic arguments.
3270 * report.cs: Don't report exactly same additional details.
3272 2008-09-22 Marek Safar <marek.safar@gmail.com>
3274 A fix for bug #324917
3275 * cs-parser.jay: Add missing multidimensional non-expression type
3278 2008-09-22 Marek Safar <marek.safar@gmail.com>
3280 A fix for bug #428191
3281 * anonymous.cs: Create an outer generic fields also for non-storey
3284 2008-09-22 Marek Safar <marek.safar@gmail.com>
3286 A fix for bug #378294
3287 * class.cs: Make fixed size buffers gmcs feature only.
3289 2008-09-22 Marek Safar <marek.safar@gmail.com>
3291 A fix for bug #355622, #324993
3292 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3295 2008-09-19 Marek Safar <marek.safar@gmail.com>
3297 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3300 2008-09-19 Marek Safar <marek.safar@gmail.com>
3302 A fix for bug #416110
3303 * generic.cs: Struct constraint results in default ctor and
3304 ValueType base type constraint to be set.
3306 2008-09-19 Marek Safar <marek.safar@gmail.com>
3308 A fix for bug #423791
3309 * generic.cs: Fixed params output type type-inference.
3311 2008-09-19 Marek Safar <marek.safar@gmail.com>
3313 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3315 2008-09-19 Marek Safar <marek.safar@gmail.com>
3317 * cs-tokenizer.cs: Don't break on extra partial modifier.
3319 2008-09-19 Marek Safar <marek.safar@gmail.com>
3321 A fix for bug #427592
3322 * generic.cs: Use common parameter resolve method.
3324 2008-09-18 Marek Safar <marek.safar@gmail.com>
3326 A fix for bug #414758
3327 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3330 2008-09-18 Marek Safar <marek.safar@gmail.com>
3332 * driver.cs, namespace.cs: Read types and namespaces after all
3333 requested assemblies are loaded, fixes issues with System.Core
3334 auto-reference, and #419888.
3336 2008-09-18 Marek Safar <marek.safar@gmail.com>
3338 A fix for bug #417705
3339 * cs-parser.jay: Fixed as/is operator expression split.
3341 2008-09-18 Marek Safar <marek.safar@gmail.com>
3343 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3344 Fixed expression tree representation of empty new expression and
3345 new initializer expression.
3347 2008-09-18 Miguel de Icaza <miguel@novell.com>
3349 * eval.cs: Remove warning, keep reference to driver around.
3351 * Hide fields that do not need to be public.
3353 2008-09-17 Marek Safar <marek.safar@gmail.com>
3355 A fix for bug #426385
3356 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3357 conversion for array elements.
3359 2008-09-17 Marek Safar <marek.safar@gmail.com>
3361 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3362 void parsing conflicts.
3364 2008-09-15 Marek Safar <marek.safar@gmail.com>
3366 A fix for bug #425601
3367 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3368 System.Core only when there is no custom ExtensionAttribute
3371 2008-09-15 Miguel de Icaza <miguel@novell.com>
3373 * namespace.cs: Do not report CS0246 (name
3375 2008-09-12 Marek Safar <marek.safar@gmail.com>
3377 A fix for bug #425669
3378 * generic.cs: Don't cache generic static anonymous method
3381 2008-09-12 Marek Safar <marek.safar@gmail.com>
3383 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3384 conflicting constraints.
3386 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3388 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3391 2008-09-12 Marek Safar <marek.safar@gmail.com>
3393 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3394 to null pointer conversion fixes.
3396 2008-09-11 Marek Safar <marek.safar@gmail.com>
3398 * cs-parser.jay, expression.cs: An implicitly typed local variable
3399 declarator cannot use an array initializer.
3401 2008-09-11 Marek Safar <marek.safar@gmail.com>
3403 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3405 2008-09-11 Marek Safar <marek.safar@gmail.com>
3407 * generic.cs (InflatedConstraints): Don't crash when constraints
3410 * cs-parser.jay: const_declarator is a block.
3412 * constant.cs: Check for not allowed NaN conversions.
3414 2008-09-10 Miguel de Icaza <miguel@novell.com>
3416 * driver.cs: Drop --shell argument, the compiler is no longer a
3419 * eval.cs: Move most of the code that deals with evaluation into
3420 this file and document the public API from repl.cs
3422 * repl.cs: Remove from here.
3424 2008-09-10 Marek Safar <marek.safar@gmail.com>
3426 A fix for bug #424684
3427 * generic.cs: Generic class constraints must come first.
3429 2008-09-09 Miguel de Icaza <miguel@novell.com>
3431 * cs-parser.jay: Improve error reporting for syntax errors in
3432 statements and expressions, we now report the expected tokens
3433 instead of reporting the useless "; expected".
3435 Drop the strings from the token declaration, it turns out that
3436 they did not do what I thought they did. Instead they were adding
3437 two sets of tokens to the tables.
3439 2008-09-09 Marek Safar <marek.safar@gmail.com>
3441 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3442 delegate.cs: Share special type check.
3444 2008-09-09 Marek Safar <marek.safar@gmail.com>
3446 A fix for bug #423981
3447 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3449 2008-09-09 Marek Safar <marek.safar@gmail.com>
3451 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3454 2008-09-09 Marek Safar <marek.safar@gmail.com>
3456 A fix for bugs: #324750, #335946
3457 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3458 lookup rule to determine ?-based tokens.
3460 2008-09-08 Miguel de Icaza <miguel@novell.com>
3462 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3463 expressions (like event adding or removing) end up here, so we
3464 need to treat those as statements.
3466 Add LoadAssembly method.
3468 2008-09-04 Miguel de Icaza <miguel@novell.com>
3470 * repl.cs: Add Time method.
3472 2008-09-05 Marek Safar <marek.safar@gmail.com>
3474 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3476 2008-09-05 Miguel de Icaza <miguel@novell.com>
3478 * repl.cs: Add workaround for old compilers.
3480 2008-09-04 Jb Evain <jbevain@novell.com>
3482 * repl.cs (PrettyPrint): pretty print everything that
3483 implements IDictionary, as well as IEnumerables. Also,
3484 add a quit helper property.
3486 2008-09-04 Marek Safar <marek.safar@gmail.com>
3488 * constant.cs: Better error reporting for decimal literals.
3490 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3493 2008-09-04 Marek Safar <marek.safar@gmail.com>
3494 Miguel de Icaza <miguel@novell.com>
3496 A fix for bug #422951
3497 * assign.cs (Assign.DoResolve): Perform the type conversions
3498 checks before we attempt to initialize `New' initializers.
3500 2008-09-04 Marek Safar <marek.safar@gmail.com>
3502 A fix for bug #422853
3503 * delegate.cs (DelegateCreation): Add special handling for
3504 EmptyExpression.Null instance expression which is just another
3505 hack for undecided member instance exression.
3507 2008-09-04 Marek Safar <marek.safar@gmail.com>
3509 * expression.cs, ecore.cs: Emit full expression tree for reduced
3512 2008-09-04 Marek Safar <marek.safar@gmail.com>
3514 * expression.cs (This): Guard against multi-resolving.
3516 * ecore.cs, statement.cs (Throw): Simplified.
3518 * flowanalysis.cs: Also verify event fields.
3520 2008-09-04 Miguel de Icaza <miguel@novell.com>
3522 * assign.cs (Assign.DoResolve): Perform the type conversions
3523 checks before we attempt to initialize `New' initializers.
3525 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3527 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3530 * repl.cs: Update help.
3532 2008-09-03 Miguel de Icaza <miguel@novell.com>
3534 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3535 handling of the default config handling, including the special
3536 treatment of System.Core assembly.
3538 Fixes the REPL processing for LINQ.
3540 2008-09-03 Marek Safar <marek.safar@gmail.com>
3542 A fix for bug #422507
3543 * expression.cs (UnboxCast): Add missing child expression mutator.
3545 2008-09-03 Marek Safar <marek.safar@gmail.com>
3547 * driver.cs: Don't self reference System.Core assembly.
3549 2008-09-03 Marek Safar <marek.safar@gmail.com>
3551 A fix for bug #422507
3552 * expression.cs (StringConcat): Add missing type mutator.
3554 2008-09-03 Marek Safar <marek.safar@gmail.com>
3556 * generic.cs (TypeInferenceContext): Follow equality rule for
3557 constructed type lower bound type inference.
3559 2008-09-02 Miguel de Icaza <miguel@novell.com>
3561 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3562 <dblank@cs.brynmawr.edu> which updates the cursor position on
3565 2008-09-02 Marek Safar <marek.safar@gmail.com>
3567 A fix for bug #367145
3568 * driver.cs: Fixed import of extension methods when using -noconfig
3571 2008-09-02 Marek Safar <marek.safar@gmail.com>
3573 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3574 version from non-generic implementation instead.
3576 2008-09-01 Marek Safar <marek.safar@gmail.com>
3578 A fix for bug #418908
3579 * class.cs: Use AddScopeStatement for field initializers.
3581 2008-09-01 Marek Safar <marek.safar@gmail.com>
3583 A fix for bug #415385
3584 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3586 2008-09-01 Marek Safar <marek.safar@gmail.com>
3588 A fix for bug #421736
3589 * iterators.cs: Don't crash on unreachable iterators.
3591 2008-09-01 Marek Safar <marek.safar@gmail.com>
3593 A fix for bug #421628
3594 * parameter.cs, attribute.cs: Clone also parameter attributes.
3596 2008-08-30 Miguel de Icaza <miguel@novell.com>
3598 * namespace.cs (LookupType): In EvalMode, try to replace
3599 the TypeBuilder from our cache with a Type as Reflection.Emit does
3600 not like to mix code from older assemblies emitted and new
3603 This sounds like a serious Mono bug that prevents multiple
3604 assemblies to be generated and consumed at the same time.
3606 * cs-parser.jay (push_current_class): Do not make interactive
3607 classes internal or private, make them public as we currently
3608 generate each new class in a new assembly.
3610 2008-08-29 Miguel de Icaza <miguel@novell.com>
3612 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3613 remove types that are entered into the global namespace during
3614 parsing so that we can remove them on failure.
3616 * cs-parser.jay: Parsing: we now keep track of types that are
3617 entered into global variables and queue those in case the parsing
3620 This happens in a few situations: during partial-input, we invoke
3621 the parser repeatedly for example with the string "class X", this
3622 would cause X to be registed, and we need to remove this
3623 registration so that another parse attempt later with say "class X {"
3624 would actually work.
3626 Additionally, if there is an error in the resolution phase, for
3627 example: "class X : NonExistant {}" th
3629 * cs-parser.jay: Be more precise with the errors being raised,
3630 instead of flagging all exceptions during parsing to be attributed
3631 to the parsing process, distinguish those from errors happening in
3632 the actions and hint that using -v would produce the actual
3635 * repl.cs: Do not load all compiler references on each reset,
3636 doing the partial reset takes care of this.
3638 2008-08-28 Miguel de Icaza <miguel@novell.com>
3640 * repl.cs: Add support for loading all the files from
3641 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3644 Introduce a micro-parser that is able to deambiguate on its input
3645 whether we are dealing with a compilation unit (namespace, class,
3646 interface, struct, delegate) declaration or a statement. This
3647 allows both declarations and statements to be entered.
3649 Set history size by default to 300 lines.
3651 Instead of distinguishing based on the parser.InteractiveResult,
3652 have only two cases: statements were parsed, or a compilation unit
3653 was. Always pull the Using statement additions from the
3654 compilation unit parse.
3656 * cs-tokenizer.cs: Rename tokens to better describe their intent
3657 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3659 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3660 EvalMode is used to trigger the lookup of global variables while
3661 StatementMode is used turn variable declarations into static
3664 * getline.cs: Allow history size to be set.
3666 2008-08-29 Marek Safar <marek.safar@gmail.com>
3668 A fix for bug #360755
3669 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3671 2008-08-29 Marek Safar <marek.safar@gmail.com>
3673 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3675 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3676 member name, it is too confusing
3678 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3680 * rootcontext.cs: Finally default to warning level 4.
3682 2008-08-28 Marek Safar <marek.safar@gmail.com>
3684 * class.cs (CheckBase): Ignore overloaded operators.
3686 2008-08-28 Marek Safar <marek.safar@gmail.com>
3688 A fix for bug #420830
3689 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3691 2008-08-28 Marek Safar <marek.safar@gmail.com>
3693 A fix for bug #420832
3694 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3696 2008-08-28 Marek Safar <marek.safar@gmail.com>
3698 A fix for bug #420386
3699 * nullables.cs: Fixed logic of nullable user comparison operators involving
3702 2008-08-28 Marek Safar <marek.safar@gmail.com>
3704 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3706 2008-08-27 Miguel de Icaza <miguel@novell.com>
3708 * repl.cs: Add support for aborting the running code with C-c.
3710 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3712 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3714 2008-08-27 Miguel de Icaza <miguel@novell.com>
3716 * cs-parser.jay (interactive_statement_list): A new set of rules
3717 for hosting statements that uses the "interactive_" prefix.
3719 * repl.cs: Add support for parsing `using' as a statement or as a
3720 directive. Deambiguating before passing this to the parser.
3722 We need to distinguish statement_expressions that occur at the
3723 toplevel vs those that occur embedded into expressions.
3725 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3726 that fixes the cursor key handling, and a history bug.
3728 2008-08-26 Miguel de Icaza <miguel@novell.com>
3730 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3731 limitations in Console, instead the 2.0 bootstrap libraries now
3732 include the Console bits.
3734 Also, remove the use of Nullables from getline.cs
3738 Interactive support for the C# compiler. Use gmcs --shell to
3739 enter a read-eval-print loop shell.
3741 Docs: http://www.mono-project.com/CsharpRepl
3743 * sources: include repl.cs here and getline.cs for gmcs.exe,
3744 everything else is getline.cs impaired.
3746 * Makefile: when bootstrapping pass a special flag
3747 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3748 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3749 This distinguishes those two cases.
3751 * repl.cs: Support for a read-eval-print loop. Will be soon
3752 refactored into eval support and then REPL on top of it.
3754 * ecore.cs: If a simplename lookup fails, before erroring out,
3755 if we are in EvalMode to resolve the name to a declaration in the
3758 This means that variable declarations that happened in previous
3759 classes (as repl puts every statement in a separate class) are
3760 made visible in this way.
3762 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3763 triggered an error due to the end of file being reached. This is
3764 used to do multi-line input, and notify the caller that the user
3765 needs to provide more text before a successful parse.
3767 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3768 to drive the evaluation with a custom wrapper.
3770 * driver.cs: Add support for --shell, and refactor some code to be
3773 * namespace.cs: Add support for serializing the contents of the
3774 namespaces and reloading them.
3776 * getline.cs: A managed implementation of ReadLine under
3777 X11/Apache2 license terms. Easy to embed in other applications as
3780 * namespace.cs: Add some functions to save and restore the
3783 * rootcontext.cs: New public field.
3785 * cs-tokenizer.cs: Add support for one of the possible characters
3786 we introduce into the token stream.
3788 This patch does not affect the regular tokenization process, the
3789 only performance hit would happen if there is an invalid character
3790 on the input string.
3792 * support.cs: Move isatty helper routine here.
3794 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3795 code generator for in-memory assemblies.
3797 2008-08-26 Marek Safar <marek.safar@gmail.com>
3799 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3800 parameter cannot be always used as a type.
3802 2008-08-21 Marek Safar <marek.safar@gmail.com>
3804 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3806 2008-08-21 Marek Safar <marek.safar@gmail.com>
3808 * convert.cs: Implement explicit array to IList<T> conversion.
3810 2008-08-20 Marek Safar <marek.safar@gmail.com>
3812 A fix for bug #362740
3813 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3815 2008-08-20 Marek Safar <marek.safar@gmail.com>
3817 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3818 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3819 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3820 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3821 handling to use just one type of infrastructure and deal with generics
3824 2008-07-23 Martin Baulig <martin@ximian.com>
3826 *** Merged this from trunk revision 108527 ***
3829 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3830 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3833 2008-08-15 Marek Safar <marek.safar@gmail.com>
3835 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3838 2008-08-15 Marek Safar <marek.safar@gmail.com>
3840 * delegate.cs: Fixed compiler crash when creating delegate using partial
3843 * typemanager.cs: MulticastDelegate is not a delegate.
3845 2008-08-14 Marek Safar <marek.safar@gmail.com>
3847 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3850 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3852 * cs-parser.jay (type): Allow 'var' in mcs too.
3853 (local_variable_type): Likewise.
3855 2008-08-14 Marek Safar <marek.safar@gmail.com>
3857 * driver.cs: Removed broken -noconfig variants.
3859 2008-08-14 Marek Safar <marek.safar@gmail.com>
3861 A fix for bug #417078
3862 * expression.cs: Emit correctly left side pointer operators.
3864 2008-08-13 Marek Safar <marek.safar@gmail.com>
3866 * generic.cs, lambda.cs: Inflate method generic arguments only.
3868 2008-08-12 Marek Safar <marek.safar@gmail.com>
3870 * class.cs: Fixed struct layout check regression.
3872 2008-08-12 Marek Safar <marek.safar@gmail.com>
3874 * cs-parser.jay, enum.cs: Simplified enum parsing.
3876 * decl.cs: Check all type parameters conflicts.
3878 * expression.cs, statement.cs, attribute.cs: More expression checks.
3880 2008-08-11 Marek Safar <marek.safar@gmail.com>
3882 * generic.cs: Add type inference types restriction.
3884 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3885 anonymous.cs, expression.cs: Allocate less accessor parameters.
3887 2008-08-08 Marek Safar <marek.safar@gmail.com>
3889 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3892 2008-08-08 Marek Safar <marek.safar@gmail.com>
3894 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3896 2008-08-07 Marek Safar <marek.safar@gmail.com>
3898 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3899 Also fixes #362146 and #381592.
3901 2008-08-07 Marek Safar <marek.safar@gmail.com>
3903 * ecore.cs: Reduced constant cannot be used as an attribute value.
3905 * cs-parser.jay: Base expression has to be a type.
3907 * expression.cs (Conditional): Uses ReducedExpression.
3909 2008-08-06 Marek Safar <marek.safar@gmail.com>
3911 A fix for bug #376826
3912 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3913 address of hoisted local variable or parameter cannot be taken.
3915 2008-08-05 Marek Safar <marek.safar@gmail.com>
3917 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3918 anonymous method inside checked/unchecked expression.
3920 2008-08-05 Marek Safar <marek.safar@gmail.com>
3922 * typemanager.cs (IsEqual): Guard against null.
3924 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3925 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3926 routine. Fixed few misleading conversion errors.
3928 2008-08-04 Marek Safar <marek.safar@gmail.com>
3930 * class.cs: Consider generics when checking cycles in struct layout.
3932 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3934 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3936 2008-08-04 Marek Safar <marek.safar@gmail.com>
3938 A fix for bug #414165
3939 * anonymous.cs: Use same anonymous implementation method for all anonymous
3942 2008-08-04 Marek Safar <marek.safar@gmail.com>
3944 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3947 2008-08-04 Marek Safar <marek.safar@gmail.com>
3949 * cs-parser.jay: Typeof argument has to be a type expression.
3951 * namespace.cs: Check alias and namespace definitions collisions.
3953 * class.cs, pending.cs: Moved explicit interface accessor implementation
3956 * delegate.cs, expression.cs: Verify special name invocations.
3958 2008-08-01 Marek Safar <marek.safar@gmail.com>
3960 * cs-parser.jay: Don't choke on empty generic type arguments.
3962 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3964 * expression.cs, ecore.cs: Minor expressions bugs.
3966 2008-08-01 Marek Safar <marek.safar@gmail.com>
3968 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3969 and added more error handling.
3971 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3973 * modifiers.cs, enum.cs: Fixed.
3975 2008-07-31 Jb Evain <jbevain@novell.com>
3977 * driver.cs: remove -pkg ability of smcs.
3979 2008-07-30 Marek Safar <marek.safar@gmail.com>
3981 * statement.cs (Switch): Correctly set empty default target for single
3984 2008-07-30 Marek Safar <marek.safar@gmail.com>
3986 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3987 string switch statement implementation to use string dictionary which
3988 significantly (2-8x) improves performance of generated code.
3990 2008-07-29 Marek Safar <marek.safar@gmail.com>
3992 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3993 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3995 2008-07-29 Marek Safar <marek.safar@gmail.com>
3997 A fix for bug #412595
3998 * typemanager.cs, convert.cs, expression.cs: Some types are never
3999 convertible to each other.
4001 2008-07-29 Marek Safar <marek.safar@gmail.com>
4003 * nullable.cs (CreateNullConstant): An error messages update.
4005 2008-07-29 Marek Safar <marek.safar@gmail.com>
4007 A fix for bug #412595
4008 * cfold.cs: Don't cast undefined bool constant.
4010 2008-07-29 Martin Baulig <martin@ximian.com>
4013 (SymbolWriter.Reset): New public static method.
4016 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
4018 2008-07-28 Marek Safar <marek.safar@gmail.com>
4020 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
4022 * expression.cs (ElementAccess): Exact size allocation.
4024 2008-07-26 Marek Safar <marek.safar@gmail.com>
4026 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
4028 2008-07-25 Marek Safar <marek.safar@gmail.com>
4030 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
4032 * class.cs: Removed $PRIVATE$ field hack which caused problems during
4035 2008-07-25 Marek Safar <marek.safar@gmail.com>
4037 A fix for bug #412217
4038 * assign.cs: Mutate also assignment type.
4040 2008-07-25 Marek Safar <marek.safar@gmail.com>
4042 A fix for bug #323644
4043 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
4046 2008-07-25 Marek Safar <marek.safar@gmail.com>
4048 A fix for bug #412134
4049 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4050 non-enumerable operands when overloading equality or bitwise operators.
4052 2008-07-25 Marek Safar <marek.safar@gmail.com>
4054 * anonymous.cs: Cache closed generic anonymous method delegates.
4056 2008-07-24 Marek Safar <marek.safar@gmail.com>
4058 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4059 anonymous.cs, statement.cs: Always emit anonymous method as static method
4060 when is instance free. Use nesting for nested anynomous methods blocks.
4062 2008-07-23 Marek Safar <marek.safar@gmail.com>
4064 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4067 2008-07-23 Marek Safar <marek.safar@gmail.com>
4069 * expression.cs: Removed MakeSimpleCall.
4071 2008-07-23 Marek Safar <marek.safar@gmail.com>
4073 A fix for bug #323012
4074 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4075 Base method implementing interface has to be public.
4077 2008-07-23 Marek Safar <marek.safar@gmail.com>
4079 * cs-parser.jay: Don't break on missing argument.
4081 2008-07-22 Marek Safar <marek.safar@gmail.com>
4083 A fix for bug #320993
4084 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4085 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4087 2008-07-22 Marek Safar <marek.safar@gmail.com>
4089 A fix for bug #320748
4090 * convert.cs: Implicit user operators cannot convert to interfaces
4092 2008-07-22 Marek Safar <marek.safar@gmail.com>
4094 A fix for bug #312686
4095 * driver.cs: Ignore empty assembly references.
4097 2008-07-22 Marek Safar <marek.safar@gmail.com>
4099 A fix for bug #387040
4100 * ecore.cs: Skip constrains check for an explicit implementation.
4102 2008-07-21 Marek Safar <marek.safar@gmail.com>
4104 A fix for bug #409045
4105 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4106 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4107 identifiers are file specific unless passed as input arguments.
4109 2008-07-21 Marek Safar <marek.safar@gmail.com>
4111 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4112 to emit UnmanagedMarshal data under 2.0 profile.
4114 2008-07-21 Marek Safar <marek.safar@gmail.com>
4116 A fix for bug #410369
4117 * parameter.cs: Clone correctly ParamsParameter.
4119 2008-07-21 Marek Safar <marek.safar@gmail.com>
4121 * expression.cs (Argument): Always report type for type based expressions
4124 2008-07-18 Marek Safar <marek.safar@gmail.com>
4126 A fix for bug #410666
4127 * anonymous.cs: Correctly initialize generic storey reference.
4129 2008-07-18 Marek Safar <marek.safar@gmail.com>
4131 * convert.cs: Don't box same type arguments.
4133 2008-07-18 Marek Safar <marek.safar@gmail.com>
4135 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4136 Finished missing generic type mutators.
4138 2008-07-18 Marek Safar <marek.safar@gmail.com>
4140 * iterators.cs, statement.cs: Finished statements CloneTo.
4142 2008-07-18 Marek Safar <marek.safar@gmail.com>
4144 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4146 * expression.cs: Emit optimized default value expressions in expression tree
4149 2008-07-18 Marek Safar <marek.safar@gmail.com>
4151 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4153 2008-07-17 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #367536
4156 * cs-parser.jay: Check static constructor of generic types for an access
4159 2008-07-17 Marek Safar <marek.safar@gmail.com>
4161 A fix for bug #353800
4162 * lambda.cs: Emit ret for contextual statements.
4164 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4165 up emitting redundant ret for all anonymous methods with return.
4167 2008-07-17 Marek Safar <marek.safar@gmail.com>
4169 A fix for bug #365188
4170 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4171 create anonymous method storey in unreachable block.
4173 2008-07-17 Marek Safar <marek.safar@gmail.com>
4175 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4176 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4177 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4178 statement.cs: Fixed relevant defects found by Gendarme.
4180 2008-07-17 Marek Safar <marek.safar@gmail.com>
4182 A fix for bug #325291
4183 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4184 statement.cs: Replaced IAnonymousHost with top level block flag.
4186 2008-07-17 Marek Safar <marek.safar@gmail.com>
4188 * cs-parser.jay: Clean up unused open_parens.
4190 2008-07-17 Marek Safar <marek.safar@gmail.com>
4192 * ecore.cs: Custom error message for a range variable assignment.
4194 2008-07-16 Marek Safar <marek.safar@gmail.com>
4196 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4199 2008-07-16 Marek Safar <marek.safar@gmail.com>
4201 * literal.cs: Null literal is of object type.
4203 2008-07-16 Marek Safar <marek.safar@gmail.com>
4205 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4206 expression of nullable equality comparison.
4208 2008-07-15 Marek Safar <marek.safar@gmail.com>
4210 * expression.cs(PointerArithmetic): Removed redundant assignment.
4212 2008-07-15 Marek Safar <marek.safar@gmail.com>
4214 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4216 2008-07-14 Marek Safar <marek.safar@gmail.com>
4218 A fix for bug #408361
4219 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4220 they are replaced by GetMethod.
4222 2008-07-14 Marek Safar <marek.safar@gmail.com>
4224 A fix for bug #408721 by jeremie.laval@gmail.com
4225 * expression.cs (Indirection): Implemented CloneTo.
4227 2008-07-14 Marek Safar <marek.safar@gmail.com>
4229 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4232 2008-07-14 Marek Safar <marek.safar@gmail.com>
4234 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4236 2008-07-11 Marek Safar <marek.safar@gmail.com>
4238 * linq.cs: Reset tranparent parameter counter in probing mode.
4240 2008-07-11 Marek Safar <marek.safar@gmail.com>
4242 * anonymous.cs: Mutate anonymous method type.
4244 2008-07-11 Marek Safar <marek.safar@gmail.com>
4246 * ecore.cs, anonymous.cs: Mutate field expressions.
4248 2008-07-10 Marek Safar <marek.safar@gmail.com>
4250 A fix for bug #369670
4251 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4253 2008-07-10 Marek Safar <marek.safar@gmail.com>
4255 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4257 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4260 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4261 only one '>', and finds a '>>', abort the generic lookahead.
4263 2008-07-10 Marek Safar <marek.safar@gmail.com>
4265 A fix for bug #319902
4266 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4268 2008-07-10 Marek Safar <marek.safar@gmail.com>
4270 A fix for bug #406371
4271 * statement.cs: Moved EmitSymbolInfo to Block.
4273 2008-07-09 Marek Safar <marek.safar@gmail.com>
4275 * ecore.cs: Report better error for extension method overload failures.
4277 2008-07-09 Marek Safar <marek.safar@gmail.com>
4279 * expression.cs (Is): No need to box reference values.
4281 2008-07-09 Marek Safar <marek.safar@gmail.com>
4283 * class.cs: Use event resolve context when initializing CreateEmitContext.
4285 2008-07-09 Marek Safar <marek.safar@gmail.com>
4287 A fix for bug #394436
4288 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4289 method used inside expression trees. Added more LINQ to expression tree
4292 2008-07-08 Marek Safar <marek.safar@gmail.com>
4294 A fix for bug #378189, #370577
4295 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4298 2008-07-08 Marek Safar <marek.safar@gmail.com>
4300 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4303 2008-07-08 Marek Safar <marek.safar@gmail.com>
4305 A fix for bug #406702
4306 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4308 2008-07-07 Marek Safar <marek.safar@gmail.com>
4310 A fix for bug #406648
4311 * cs-parser.jay: Report nullable use in mcs for some cases.
4313 2008-07-07 Marek Safar <marek.safar@gmail.com>
4315 * ecore.cs: Improved argument mismatch error messages.
4317 2008-07-07 Marek Safar <marek.safar@gmail.com>
4319 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4321 2008-07-07 Marek Safar <marek.safar@gmail.com>
4323 * expression.cs (TypeOf): Mutate type argument.
4325 2008-07-04 Marek Safar <marek.safar@gmail.com>
4327 * class.cs: Report missing partial modifier for correct type.
4329 2008-07-04 Marek Safar <marek.safar@gmail.com>
4331 * ecore.cs, expression.cs (VariableReference): Variable property is
4334 2008-07-04 Marek Safar <marek.safar@gmail.com>
4336 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4338 2008-07-04 Marek Safar <marek.safar@gmail.com>
4340 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4343 2008-07-04 Marek Safar <marek.safar@gmail.com>
4345 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4346 anonymous method storey to an instance method when only "this" is hoisted.
4348 2008-07-03 Marek Safar <marek.safar@gmail.com>
4350 A fix for bug #321615
4351 * expression.cs: Pointer comparisons use unsigned operator.
4353 2008-07-03 Marek Safar <marek.safar@gmail.com>
4355 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4357 2008-07-02 Marek Safar <marek.safar@gmail.com>
4359 A fix for bug #404905
4360 * class.cs: Always initialize local unsafe variables.
4362 2008-06-30 Marek Safar <marek.safar@gmail.com>
4364 A fix for bug #396987
4365 * expression.cs (NewInitialize): Clear local temporary variable for next run
4367 2008-06-27 Marek Safar <marek.safar@gmail.com>
4369 A fix for bug #401020
4370 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4372 2008-06-27 Marek Safar <marek.safar@gmail.com>
4374 A fix for bug #398319
4375 * cs-parser.jay: Implemented undocumented base access expression inside
4378 2008-06-26 Marek Safar <marek.safar@gmail.com>
4380 A fix for bug #404227
4381 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4383 2008-06-26 Marek Safar <marek.safar@gmail.com>
4385 A fix for bug #404227
4386 * convert.cs: Fixed explicit array to interface cast.
4388 2008-06-26 Marek Safar <marek.safar@gmail.com>
4390 A fix for bug #403894
4391 * delegate.cs: Mutate DelegateInvocation type.
4393 2008-06-26 Marek Safar <marek.safar@gmail.com>
4395 A fix for bug #379348
4396 * delegate.cs: Box a load of generic parameters.
4398 2008-06-26 Marek Safar <marek.safar@gmail.com>
4400 * expression.cs: Add an array creation arguments mutate.
4402 2008-06-26 Marek Safar <marek.safar@gmail.com>
4404 A fix for bug #386068
4405 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4408 2008-06-25 Marek Safar <marek.safar@gmail.com>
4410 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4413 2008-06-25 Marek Safar <marek.safar@gmail.com>
4415 A fix for bug #403518
4416 * delegate.cs: Type correctly anonymous method new invocation.
4418 2008-06-24 Marek Safar <marek.safar@gmail.com>
4420 A fix for bug #394826
4421 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4424 2008-06-24 Marek Safar <marek.safar@gmail.com>
4426 A fix for bug #394826
4427 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4430 2008-06-24 Marek Safar <marek.safar@gmail.com>
4432 * class.cs: Clone indexer parameters for localized capturing.
4434 2008-06-24 Marek Safar <marek.safar@gmail.com>
4436 A fix for bug #402379
4437 * expression.cs: Don't crash when an object initializer resolve fails.
4439 2008-06-24 Marek Safar <marek.safar@gmail.com>
4441 A fix for bug #402888
4442 * expression.cs: Mutate conditional expression.
4444 2008-06-24 Marek Safar <marek.safar@gmail.com>
4446 A fix for bug #401012
4447 * class.cs: Keep StructLayout in shared container.
4449 2008-06-24 Marek Safar <marek.safar@gmail.com>
4451 A fix for bug #400438
4452 * decl.cs, class.cs: Only properties can be automatically implemented.
4454 2008-06-24 Marek Safar <marek.safar@gmail.com>
4456 * statement.cs (ChangeToIterator): Copy also labels.
4458 2008-06-23 Marek Safar <marek.safar@gmail.com>
4460 * ecore.cs: Pass type argument details to parent extension method.
4462 2008-06-23 Marek Safar <marek.safar@gmail.com>
4464 A fix for bug #375966
4465 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4467 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4469 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4471 2008-06-22 Marek Safar <marek.safar@gmail.com>
4473 A fix for bug #394347
4474 * anonymous.cs: Cache compatible delegates as compatibility check produces
4475 a new method every time.
4477 2008-06-20 Marek Safar <marek.safar@gmail.com>
4479 * anonymous.cs: Propagate storey reference for single references.
4481 2008-06-20 Marek Safar <marek.safar@gmail.com>
4483 A fix for bug #387615
4484 * assign.cs, expression.cs: Correctly clone compound assignment.
4486 2008-06-19 Marek Safar <marek.safar@gmail.com>
4488 A fix for bug #359611, #359604
4489 * anonymous.cs: Mutate all types of hoisted parameters.
4491 2008-06-19 Marek Safar <marek.safar@gmail.com>
4493 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4494 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4495 expression.cs, codegen.cs, statement.cs
4497 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4498 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4500 ** Anonymous methods, lambda expressions rewrite **
4502 Anonymous expressions are now resolved when an explicit block is resolved
4503 and they don't require any registration procedure anymore. Further,
4504 anonymous methods are defined when explicit block is emitted which allows
4505 better control of whole process and opens possibilities for more
4506 optimizations as well as alternative to reverse whole process.
4508 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4509 process consistent and to correctly emit hoisted generic methods when they
4510 have at least 1 hoisted variable.
4512 2008-06-17 Martin Baulig <martin@ximian.com>
4514 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4516 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4517 virtual property; check it in Emit().
4518 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4520 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4522 (Indexer.Define): Likewise.
4524 2008-06-17 Marek Safar <marek.safar@gmail.com>
4526 * convert.cs: Don't use IsInterface on type arguments.
4528 * delegate.cs: DelegateInvocation uses MethodInfo.
4530 * parameter.cs: Removed IsTypeParameter.
4532 * generic-mcs.cs: More missing stuff.
4534 2008-06-16 Martin Baulig <martin@ximian.com>
4537 (Modifiers.DEBUGGER_HIDDEN): New public const.
4540 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4543 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4544 (AbstractPropertyEventMethod): Likewise.
4545 (Constructor.Emit): Likewise.
4546 (SourceMethod.SetCompilerGenerated): Removed.
4548 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4552 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4553 if we're an `IteratorHost'.
4554 (AnonymousMethodMethod..ctor): Don't set
4555 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4558 2008-06-16 Marek Safar <marek.safar@gmail.com>
4560 * statement.cs: Clean-up foreach statements.
4562 2008-06-12 Marek Safar <marek.safar@gmail.com>
4564 * class.cs: Stop using public method which should not exist
4565 (MethodBuilder.SetGenericMethodSignature).
4567 2008-06-11 Martin Baulig <martin@ximian.com>
4570 (Location.LookupFile): Add `CompilationUnit' argument; when given
4571 a relative file name, make it relative to the directory the .cs
4572 file is located in instead of using the current directory.
4574 2008-06-11 Martin Baulig <martin@ximian.com>
4577 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4578 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4579 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4580 (SourceMethod.SetCompilerGenerated): Likewise.
4582 2008-06-11 Marek Safar <marek.safar@gmail.com>
4584 * codegen.cs, driver: Only write symbol file when it's asked for.
4586 2008-06-11 Marek Safar <marek.safar@gmail.com>
4588 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4590 2008-06-10 Martin Baulig <martin@ximian.com>
4592 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4594 2008-06-09 Marek Safar <marek.safar@gmail.com>
4596 A fix for bug #316290
4597 * expression.cs: Include decimal operators in predefined table.
4599 * parameters.cs: More readonlyness.
4601 2008-06-09 Marek Safar <marek.safar@gmail.com>
4603 A fix for bug #397213
4604 * cs-parser.jay: One more missing current_local_parameters reset.
4606 2008-06-09 Marek Safar <marek.safar@gmail.com>
4608 A fix for bug #396633
4609 * class.cs: Host backing field in partial container.
4611 2008-06-09 Marek Safar <marek.safar@gmail.com>
4613 A fix for bug #397068
4614 * expression.cs: Check both operand types when predefined operator is used.
4616 2008-06-05 Martin Baulig <martin@ximian.com>
4618 Merged the `debugger-kahalo' branch.
4621 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4622 we're an iterator method.
4623 (SourceMethod): Reflect latest symbol writer changes;
4624 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4625 now `start_row' and `end_row'.
4626 (Constructor.Emit): Fix the logic whether to emit symbol information.
4628 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4632 (CompilationUnit): New public class; derives from `SourceFile'.
4633 (SourceFileEntry.DefineSymbolInfo): New public method.
4634 (SourceFileEntry.SetChecksum): New public method.
4635 (Location): Encode hidden line numbers by using `column == 255';
4636 the .ctor now accepts `column == -1' to mark a hidden line number.
4637 (Location.Hidden): New public property.
4638 (Location.CheckPoint): Add `CompilationUnit'.
4639 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4640 (Location.Push): Add `CompilationUnit compile_unit' argument.
4641 (Location.CompilationUnit): New public property.
4644 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4646 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4648 * driver.cs: `SourceFile' -> `CompilationUnit'.
4650 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4652 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4654 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4658 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4659 new symbol writer API to also pass the file.
4661 2008-06-05 Marek Safar <marek.safar@gmail.com>
4663 * statement.cs: Emit catch variable assignment using variable expression.
4665 2008-06-05 Marek Safar <marek.safar@gmail.com>
4667 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4668 with other variable types.
4670 2008-06-04 Marek Safar <marek.safar@gmail.com>
4672 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4673 GetLength method emit, it breaks resolve rules.
4675 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4676 Marek Safar <marek.safar@gmail.com>
4678 A fix for bug #395542
4679 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4682 2008-06-02 Marek Safar <marek.safar@gmail.com>
4684 A fix for bug #395287
4685 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4687 2008-05-31 Marek Safar <marek.safar@gmail.com>
4689 A fix for bug #395845
4690 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4691 non-nullable parameter type.
4693 2008-05-31 Marek Safar <marek.safar@gmail.com>
4695 * class.cs: Handle contructor initializer as a statement in top-level block.
4697 2008-05-30 Marek Safar <marek.safar@gmail.com>
4699 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4700 security attributes.
4702 2008-05-24 Marek Safar <marek.safar@gmail.com>
4704 * ecore.cs, expression.cs: Small IVariable refactoring.
4706 2008-05-22 Marek Safar <marek.safar@gmail.com>
4708 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4710 2008-05-21 Marek Safar <marek.safar@gmail.com>
4712 * cs-parser.jay: Removed redundant catch type check.
4714 2008-05-21 Marek Safar <marek.safar@gmail.com>
4716 A fix for bug #390372
4717 * nullable.cs: Set correct return type.
4719 2008-05-21 Marek Safar <marek.safar@gmail.com>
4721 A fix for bug #391062
4722 * typemanager.cs: Fixed crash when comparing null types.
4724 2008-05-21 Marek Safar <marek.safar@gmail.com>
4726 A fix for bug #391871
4727 * cs-parser.jay: Better error handling for invalid catch type.
4729 2008-05-20 Marek Safar <marek.safar@gmail.com>
4731 A fix for bug #392155
4732 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4734 2008-05-15 Marek Safar <marek.safar@gmail.com>
4736 A fix for bug #390666
4737 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4740 2008-05-15 Marek Safar <marek.safar@gmail.com>
4742 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4745 2008-05-13 Marek Safar <marek.safar@gmail.com>
4747 A fix for bug #389625
4748 * delegate.cs, generic.cs: Some progress on method group return type
4751 2008-05-13 Marek Safar <marek.safar@gmail.com>
4753 A fix for bug #378419
4754 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4756 2008-05-12 Marek Safar <marek.safar@gmail.com>
4758 * class.cs (Constructor): Added IsCompilerGenerated.
4760 2008-05-12 Marek Safar <marek.safar@gmail.com>
4762 * expression.cs: Enum binary operators can accept non-enum operand only when
4763 is implicitly convertible to underlying type.
4765 2008-05-12 Marek Safar <marek.safar@gmail.com>
4767 A fix for bug #389272
4768 * support.cs: Workaround System.InvalidOperationException for enums.
4770 2008-05-12 Marek Safar <marek.safar@gmail.com>
4772 A fix for bug #389073
4773 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4775 2008-05-10 Marek Safar <marek.safar@gmail.com>
4777 * driver.cs: Split Parse.
4779 * location.cs (LookupFile): Uses string.Empty.
4781 2008-05-07 Marek Safar <marek.safar@gmail.com>
4783 * expression.cs, parameter.cs: Small ParameterReference clean up.
4785 2008-05-07 Marek Safar <marek.safar@gmail.com>
4787 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4788 hack. Fixes #387502.
4790 2008-05-06 Martin Baulig <martin@ximian.com>
4792 * class.cs (Constructor.Emit): Fix the logic whether to emit
4795 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4798 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4799 InvalidOperationException when the iterator is before the start or
4802 2008-05-06 Marek Safar <marek.safar@gmail.com>
4804 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4805 when left is nullable type.
4807 2008-05-06 Marek Safar <marek.safar@gmail.com>
4809 A fix for bug #386628
4810 * expression.cs (LocalVariableReference): Continue in resolving when
4811 variable is not assigned.
4813 2008-05-05 Marek Safar <marek.safar@gmail.com>
4815 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4816 nullable operations.
4818 2008-05-04 Marek Safar <marek.safar@gmail.com>
4820 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4821 it saves many redundant temporary variables for nullable operations.
4823 2008-05-03 Marek Safar <marek.safar@gmail.com>
4825 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4827 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4830 * nullable.cs: Constant coalescing operator optimizations.
4832 2008-05-03 Marek Safar <marek.safar@gmail.com>
4834 * constant.cs: Use unsigned conversion for values which are unsigned only.
4836 2008-05-03 Marek Safar <marek.safar@gmail.com>
4838 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4839 coalescing operator as it should be.
4841 2008-05-02 Marek Safar <marek.safar@gmail.com>
4843 A fix for bug #371016
4844 * expression.cs: All predefined delegate operators require implicit method
4847 2008-05-02 Marek Safar <marek.safar@gmail.com>
4849 * constant.cs: Emit long constant as uint when fits the range.
4851 * convert.cs, expression.cs: Fixed few unsafe conversions.
4853 2008-05-02 Marek Safar <marek.safar@gmail.com>
4855 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4857 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4860 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4862 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4864 2008-05-01 Marek Safar <marek.safar@gmail.com>
4866 * constant.cs, literal.cs: IsLiteral property for error reporting.
4868 * ecore.cs, expression.cs: Implemented Property expression.
4870 2008-05-01 Marek Safar <marek.safar@gmail.com>
4872 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4874 * nullable.cs: Implemented nullable coalescing null operator.
4876 * ecore.cs, expression.cs: Expression trees work.
4878 2008-05-01 Marek Safar <marek.safar@gmail.com>
4880 * ecore.cs: CreateExpressionTree is finally abstract.
4882 * expression.cs, linq.cs: Updated.
4884 2008-05-01 Marek Safar <marek.safar@gmail.com>
4886 * expression.cs, ecore.cs: Block base access expression inside expression
4889 2008-05-01 Marek Safar <marek.safar@gmail.com>
4891 A fix for bug #385058
4892 * expression.cs: User-defined operator implementations always take
4893 precedence over predefined operator implementations.
4895 2008-04-30 Marek Safar <marek.safar@gmail.com>
4897 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4898 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4899 expression tree conversions.
4901 2008-04-30 Marek Safar <marek.safar@gmail.com>
4903 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4904 operators method details to Operator class.
4906 2008-04-30 Marek Safar <marek.safar@gmail.com>
4908 * anonymous.cs: Pass unsafe flags to anonymous container.
4910 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4911 inside expression tree.
4913 2008-04-29 Martin Baulig <martin@ximian.com>
4915 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4916 (Tokenizer.PopPosition): Also restore the `line'.
4918 2008-04-29 Marek Safar <marek.safar@gmail.com>
4920 * delegate.cs: Implemented Invoke expression.
4922 2008-04-29 Marek Safar <marek.safar@gmail.com>
4924 * expression.cs: Fixed equality reference comparison regression.
4926 2008-04-29 Marek Safar <marek.safar@gmail.com>
4928 * ecore.cs: Clean up EmptyCast hack.
4930 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4931 using correct conversion rules. Also fixes #383993.
4933 2008-04-28 Martin Baulig <martin@ximian.com>
4935 * class.cs (Constructor.Emit): Don't emit debugging information
4936 for generated default .ctor's.
4938 2008-04-28 Marek Safar <marek.safar@gmail.com>
4940 * convert.cs: Empty-cast ushort to int conversion.
4942 2008-04-28 Marek Safar <marek.safar@gmail.com>
4944 A fix for bug #384191
4945 * ecore.cs, expression.cs: Fixed expression cloning.
4947 2008-04-28 Marek Safar <marek.safar@gmail.com>
4949 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4951 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4953 Fix #381559, test-638.cs, test-639.cs
4954 * assign.cs (CompoundAssign.Helper): New wrapper.
4955 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4957 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4958 Pass unconverted expressions to the params array creation expression.
4959 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4960 (PropertyExpr.EmitAssign): Likewise.
4961 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4962 element if it is of kind CompoundAssign.Helper.
4963 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4964 first before anything else.
4965 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4966 (ArrayAccess.LoadArrayAndArguments): Simplify.
4968 2008-04-27 Marek Safar <marek.safar@gmail.com>
4970 * expression.cs: Fixed cloning of typeof(void).
4972 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4974 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4975 (Assign.Emit): Likewise. Move it to ...
4976 (CompoundAssign.DoResolve): ... here and ...
4977 (CompoundAssign.Emit): ... here.
4978 (EventAddOrRemove): New helper to handle += and -= on events, and
4979 avoid the use of BinaryDelegates.
4980 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4981 (EventExpr.EmitAddOrRemove): Improve.
4982 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4984 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4985 create VarExprs for 'foo.bar.var'.
4986 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4987 is a highly inappropriate name for its functionality.
4989 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4991 Simplify handling of multiple assignments
4992 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4994 (SimpleAssign): New. Class to be used for normal assignments.
4995 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4996 * expression.cs, parameter.cs, statement.cs: Likewise.
4998 2008-04-25 Marek Safar <marek.safar@gmail.com>
5000 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
5001 for incompatible underlying types, more to come, uff.
5003 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
5006 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
5007 Handle 'leave_copy'.
5009 2008-04-25 Marek Safar <marek.safar@gmail.com>
5011 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
5013 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
5015 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
5016 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
5017 * statement.cs (While, Do, For): Allow test to have side effects.
5018 (For.DoEmit): Always emit InitStatement.
5021 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
5022 Always create SideEffectConstant.
5023 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
5024 of type EnumConstant.
5026 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5027 Handle 'right' being SideEffectConstant of type 'bool'.
5029 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5030 Use left.EmitBranchable instead of open coding it, so as to
5031 improve optimization opportunities.
5033 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
5035 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
5037 (Expression.EmitSideEffect): Document.
5039 2008-04-23 Marek Safar <marek.safar@gmail.com>
5041 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
5043 2008-04-23 Marek Safar <marek.safar@gmail.com>
5045 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
5047 2008-04-23 Marek Safar <marek.safar@gmail.com>
5049 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5050 conversion to expression tree.
5052 2008-04-23 Marek Safar <marek.safar@gmail.com>
5054 * ecore.cs: Removed unused expression.
5056 2008-04-22 Marek Safar <marek.safar@gmail.com>
5058 * expression.cs: Implemented NegateChecked and New expressions.
5060 2008-04-22 Marek Safar <marek.safar@gmail.com>
5062 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5064 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5067 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5068 needing final 'ret' instruction.
5070 2008-04-22 Marek Safar <marek.safar@gmail.com>
5072 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5074 2008-04-21 Marek Safar <marek.safar@gmail.com>
5076 * expression.cs: Emit ldnull and not null expression as an instance argument
5077 of static method expression calls.
5079 2008-04-21 Marek Safar <marek.safar@gmail.com>
5081 A fix for bug #378200
5082 * expression.cs: Fixed crash when creating parameterless expression tree
5085 2008-04-21 Marek Safar <marek.safar@gmail.com>
5087 A fix for bug #375297
5088 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5091 2008-04-21 Marek Safar <marek.safar@gmail.com>
5093 A fix for bug #377596
5094 * decl.cs, class.cs: Emit delegate type argument attributes.
5096 2008-04-21 Marek Safar <marek.safar@gmail.com>
5098 A fix for bug #365314
5099 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5101 2008-04-21 Marek Safar <marek.safar@gmail.com>
5103 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5106 2008-04-21 Marek Safar <marek.safar@gmail.com>
5108 * generic.cs (TypeParameter): Removed redundant location.
5110 2008-04-19 Marek Safar <marek.safar@gmail.com>
5112 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5113 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5114 FullNamedExpression in all declaration type expression, statements will come
5117 2008-04-18 Marek Safar <marek.safar@gmail.com>
5119 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5120 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5122 2008-04-18 Marek Safar <marek.safar@gmail.com>
5124 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5127 2008-04-17 Marek Safar <marek.safar@gmail.com>
5129 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5132 2008-04-17 Marek Safar <marek.safar@gmail.com>
5134 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5138 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5140 Hook up 'EmitSideEffect'
5141 * constant.cs (Constant.EmitSideEffect): New.
5142 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5143 (SideEffectConstant.EmitSideEffect): New.
5144 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5145 unconditional branch in EmitBranchable.
5146 (FieldExpr.EmitBranchable): New.
5147 * expression.cs (Unary.EmitSideEffect): New.
5148 (Binary.EmitSideEffect): New.
5149 (VariableReference.EmitSideEffect): New. Do nothing.
5151 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5153 Introduce 'EmitSideEffect'
5154 * ecore.cs (Expression.EmitSideEffect): New.
5155 (TypeCast): Rename from EmptyCast.
5157 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5158 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5159 * convert.cs, nullable.cs: Update to changes.
5161 2008-04-16 Marek Safar <marek.safar@gmail.com>
5163 * class.cs, cs-parser.jay: Early check for base types expression.
5165 2008-04-16 Marek Safar <marek.safar@gmail.com>
5167 * decl.cs (MemberName): Declare PrettyName as obsolete.
5169 2008-04-16 Marek Safar <marek.safar@gmail.com>
5171 * namespace.cs: Use MemberName comparison.
5173 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5176 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5178 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5179 (MemberName.FullyQualifiedName): New. Provides the functionality
5180 that users assume FullName would have.
5181 * ecore.cs, namespace.cs: Update to changes.
5183 * statement.cs (Using.assign): Make into ExpressionStatement.
5184 (Using.EmitPreTryBody): Simplify.
5186 2008-04-16 Marek Safar <marek.safar@gmail.com>
5188 * report.cs: ColorFormat is protected.
5190 * rootcontext.cs: Unused fields clean-up.
5192 * namespace.cs: Made UsingEntry name private.
5194 2008-04-16 Marek Safar <marek.safar@gmail.com>
5196 * cs-tokenizer.cs, location.cs: Removed unused field.
5198 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5199 Raja R Harinath <harinath@hurrynot.org>
5202 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5203 (SideEffectConstant.side_effect): Rename from 'right'.
5204 (SideEffectConstant..ctor): Normalize 'side_effect'.
5205 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5206 value of this constant.
5207 * cfold.cs: Update to changes.
5209 2008-04-15 Marek Safar <marek.safar@gmail.com>
5211 * cs-paser.jay: Removed unused variable.
5213 * driver.cs: Made Compile instance method.
5215 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5217 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5219 2008-04-15 Marek Safar <marek.safar@gmail.com>
5221 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5223 2008-04-13 Jb Evain <jbevain@novell.com>
5225 * namespace.cs: update the System.Core fullname for 2.1
5226 * driver.cs: update the list of required assemblies for 2.1.
5227 Merged from the Moonlight 2 branch.
5229 2008-04-11 Marek Safar <marek.safar@gmail.com>
5231 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5232 types and user defined operators. User operators arguments has to be checked
5233 for null value before invocation, which also means no operator is called
5234 when any argument is not convertible to unwrapped nullable type.
5236 2008-04-09 Marek Safar <marek.safar@gmail.com>
5238 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5239 of Unary expressions to follow operator overloading rules precisely.
5240 Also fixes #321794, #323794
5242 2008-04-08 Marek Safar <marek.safar@gmail.com>
5244 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5247 2008-04-08 Marek Safar <marek.safar@gmail.com>
5249 * expression.cs, ecore.cs: Implemented MemberInit expression.
5251 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5253 Fix mono/tests/exception4.cs
5254 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5255 ec.NeedReturnLabel () rather emitting a 'nop'.
5257 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5259 (TryCatch.SomeCodeFollows): Likewise.
5260 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5261 for 'break', 'continue' and 'return' statements inside a try.
5262 We're fairly sure that the generated IL stream will have more
5263 instructions textually following the try.
5264 (FlowBranchingTryCatch): Likewise.
5266 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5267 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5270 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5271 wrapper -- forward everything to CollectionForeach.
5272 (CollectionForeach.NonDisposableWrapper): New.
5273 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5274 instead of a pop + branch to end.
5276 2008-04-07 Marek Safar <marek.safar@gmail.com>
5278 A fix for bug #377485
5279 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5280 Propagate location for extension method groups. Report conversion failure at
5283 2008-04-07 Marek Safar <marek.safar@gmail.com>
5285 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5286 ListInit and Field expressions.
5288 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5290 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5291 Since $PC is always -1 inside the body of MoveNext, the fault
5293 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5294 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5295 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5297 The denouement! Fix #324708
5298 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5299 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5300 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5301 'finally' inside the finally clause.
5303 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5304 inside an iterator. Don't emit the body of the 'finally' inside
5305 the finally clause yet.
5307 Use the ResumableStatement infrastructure for MoveNext ()
5308 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5309 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5310 'old_resume_points'. Move dispatcher upfront.
5311 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5312 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5313 in an enumerator. This encodes the main fix in this patch series
5314 -- we can only jump into the first instruction of a try from the
5315 outside, but we want to emit try/finally regions in iterators and
5316 resume in the middle of them.
5318 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5320 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5321 of NeedReturnLabel here.
5323 Introduce a common point for emitting try/finally to IL
5324 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5325 features of the various subclasses, which are now driven by ...
5326 (ExceptionStatement.EmitPreTryBody): ... this and ...
5327 (ExceptionStatement.EmitTryBody): ... this and the original
5329 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5330 Remove DoEmit and update to follow above protocol.
5332 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5333 of the dispatcher are the same, skip emitting the 'switch'.
5334 * iterator.cs (Iterator.EmitDispose): Update to changes.
5336 Clean up handling of 'using' statement
5337 * statement.cs (UsingTemporary): New. Carved out of ...
5338 (Using): ... this. Simplify drastically. Handle exactly
5340 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5341 or Using as appropriate. If there are multiple variable declared,
5342 create nested Using statements.
5343 (resource_acquisition): Kill.
5345 * statement.cs (ExceptionStatement.EmitForDispose): Use
5346 EmitFinallyBody, not EmitFinally.
5348 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5349 * iterator.cs: Update to changes.
5351 Start using the ResumableStatement infrastructure
5352 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5353 (ResumableStatement.EmitForDispose): New.
5354 (ExceptionStatement): Override them.
5355 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5356 EmitForDispose to create the body of the Dispose method. Don't
5359 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5360 * statement.cs (Toplevel.AddResumePoint): ... here.
5361 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5362 * flowanalysis.cs (FlowBranchingIterator): New.
5363 * codegen.cs (EmitContext): Update to changes.
5365 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5366 (Iterator.old_resume_points): Rename from 'resume_points'.
5367 (Iterator.MoveNextStatement): Remove unused class.
5369 New infrastructure for try/finally in iterators (still unused)
5370 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5371 (FlowBranchingToplevel.AddResumePoint): Hook into
5372 ToplevelBlock.AddResumePoint.
5373 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5374 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5375 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5376 resume points and assign program-counter values.
5377 (ExceptionBlock.AddResumePoint): Collect resume points for
5378 de-muxer at the top of try block.
5379 * iterators.cs (Yield.CheckContext): Simplify.
5380 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5382 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5384 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5385 argument to an ExitStatement.
5386 (FlowBranchingException): Refactor saved origins code.
5387 * statement.cs (ExitStatement): Update to cahges.
5388 * iterator.cs (YieldBreak): Likewise.
5390 * statement.cs (ResumableStatement): New. Common base class for
5391 YieldReturn and ExceptionStatement.
5392 (ExitStatement): New. Common base class for Return and YieldBreak.
5393 (Return): Update to changes.
5394 * iterator.cs (YieldBreak): Likewise.
5395 * lambda.cs (ContextualReturn): Likewise.
5398 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5399 emit a meaningful error message.
5401 Fix #324765, #319508
5402 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5403 (VariableInfo.SetAssigned): Set it.
5404 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5405 determine if CS0219 or CS0168 is appropriate. Don't use
5406 flow-analysis information.
5407 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5408 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5409 (EmitContext.EndFlowBranching): ... this.
5411 2008-04-03 Marek Safar <marek.safar@gmail.com>
5413 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5415 2008-04-03 Marek Safar <marek.safar@gmail.com>
5417 A fix for bug #376508
5418 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5419 ImplicitConversionExists.
5421 2008-04-03 Marek Safar <marek.safar@gmail.com>
5423 * expression.cs (Binary): Added remaining binary operators to expression
5426 * nullable.cs: Optimize shift with null argument.
5428 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5430 Fix minor IL regression
5431 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5432 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5433 * cs-parser.jay (try_statement): Update to changes.
5435 * statement.cs (TryFinally.need_exc_block): Delete.
5436 (TryFinally): Update to changes.
5438 Now all ExceptionStatements are unconditional
5439 * statement.cs (CollectionForeach.DisposableWrapper): New.
5440 Extract out the try/finally code into a new wrapper.
5441 (CollectionForeach.Resolve): Use it to simplify the code.
5443 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5445 Start at simplifying ExceptionStatement semantics a bit
5446 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5447 * cs-parser.jay (try_statement): Update to changes.
5448 (opt_catch_clauses): Remove.
5449 * flowanalysis.cs: Update to changes.
5450 (FlowBranching.BranchingType.TryCatch): New.
5451 (FlowBranchingTryCatch): New.
5453 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5454 (FlowBranching.CreateBranching): Update to changes.
5455 (FlowBranchingBlock.AddSibling): Add sanity check.
5456 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5459 * iterators.cs (Iterator.MarkFinally): Remove.
5460 * statement.cs (ExceptionStatement): Update to changes.
5462 Add support for skipping over finally blocks at runtime. First
5463 in a series to fix #324708
5464 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5465 (Iterator.EmitMoveNext): Initialize it.
5466 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5467 branch over the body of the 'finally' clause.
5469 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5471 Avoid lopsided use of Foo/DoFoo names
5472 * statement.cs (ExpressionStatement.EmitFinallyBody):
5473 Rename from EmitFinally.
5474 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5475 * iterator.cs: Update to changes.
5477 2008-04-02 Marek Safar <marek.safar@gmail.com>
5479 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5480 based on UserOperatorCall. More binary nullable operators clean up.
5482 2008-04-02 Martin Baulig <martin@ximian.com>
5484 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5486 2008-04-02 Marek Safar <marek.safar@gmail.com>
5488 * nullable.cs: Merge user and empty conversions when lifting expression
5491 * expression.cs (StringConcat): Implemented expression tree representation.
5493 2008-04-01 Marek Safar <marek.safar@gmail.com>
5495 * nullable.cs: When lifting null literal and a user operator exists, no call
5498 2008-04-01 Marek Safar <marek.safar@gmail.com>
5500 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5503 2008-04-01 Marek Safar <marek.safar@gmail.com>
5505 * nullable.cs, expression.cs: Use namespace instead heavily nested
5506 monster abstract class.
5508 2008-04-01 Marek Safar <marek.safar@gmail.com>
5510 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5511 lifting of null literal and user operators. Clean up of some temporary
5514 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5516 Fix #368224, test-629.cs
5517 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5518 if it crossed an unwind-protect boundary.
5519 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5520 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5521 inside an unwind-protected region.
5522 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5523 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5524 'leave' instead of a 'br' if unwind-protected.
5525 (Iterator.EmitYieldBreak): Likewise.
5527 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5529 * driver.cs: Only define versioninfo resources if no win32 resource
5532 2008-03-28 Marek Safar <marek.safar@gmail.com>
5534 A fix for bug #372375
5535 * convert.cs: Fixed boxing of nullable types.
5537 2008-03-28 Marek Safar <marek.safar@gmail.com>
5539 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5542 2008-03-28 Marek Safar <marek.safar@gmail.com>
5544 A fix for bug #374619
5545 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5547 2008-03-27 Marek Safar <marek.safar@gmail.com>
5549 * lambda.cs: Check return type only for invocation.
5551 2008-03-27 Marek Safar <marek.safar@gmail.com>
5553 A fix for bug #374214
5554 * ecore.cs: Correctly report argument type mismatch.
5556 2008-03-27 Marek Safar <marek.safar@gmail.com>
5558 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5559 and not rely on broken IsEnum.
5561 2008-03-27 Marek Safar <marek.safar@gmail.com>
5563 * nullable.cs: New file, extracted from generic.cs.
5565 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5567 2008-03-27 Marek Safar <marek.safar@gmail.com>
5569 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5570 predefined comparison operators and null literals.
5572 * report.cs: New warning ID.
5574 2008-03-25 Marek Safar <marek.safar@gmail.com>
5576 A fix for bug #370577
5577 * lambda.cs: Check return type too.
5579 2008-03-25 Marek Safar <marek.safar@gmail.com>
5581 A fix for bug #372846
5582 * class.cs: Automatic properties can be declared as unsafe.
5584 2008-03-20 Marek Safar <marek.safar@gmail.com>
5586 * location.cs: Use string based concatenation.
5588 * expression.cs: LiftedBinaryOperator is gmcs only.
5590 2008-03-20 Marek Safar <marek.safar@gmail.com>
5592 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5593 conversions rules and expression trees.
5595 2008-03-19 Marek Safar <marek.safar@gmail.com>
5597 * delegate.cs: Use extension method source as delegate target.
5599 2008-03-19 Marek Safar <marek.safar@gmail.com>
5601 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5602 binary operations to be purely based on binary operations and optimized
5603 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5604 and other ET refactoring.
5606 * typemanager.cs: Fixed warning.
5608 2008-03-17 Marek Safar <marek.safar@gmail.com>
5610 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5612 * symbolwriter.cs: Fixed.
5614 2008-03-17 Marek Safar <marek.safar@gmail.com>
5616 * anonymous.cs, driver.cs: Reset anonymous types counters.
5618 2008-03-17 Marek Safar <marek.safar@gmail.com>
5620 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5622 * class.cs: Use fullname for all type member definitions.
5624 2008-02-19 Martin Baulig <martin@ximian.com>
5627 (IMethodData.EmitExtraSymbolInfo): New interface method.
5628 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5629 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5630 interface method here as an empty public virtual method.
5633 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5634 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5635 CodeGen.SymbolWriter.SetRealMethodName().
5637 2008-02-18 Martin Baulig <martin@ximian.com>
5640 (ScopeInfo.EmitType): Override this and emit debugging
5641 information for captured variables.
5642 (RootScopeInfo.EmitType): Override this and emit symbol
5643 information for a captured `this'.
5645 2008-02-15 Martin Baulig <martin@ximian.com>
5647 * iterators.cs: Emit debugging info.
5650 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5651 (EmitContext.OmitDebuggingInfo): New public property.
5654 (While): Override Emit() and don't emit symbol info there; do it
5655 inside DoEmit() instead.
5656 (Block.Emit): Omit symbol information while emitting the scope
5657 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5659 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5660 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5661 .ctor to make `IsIterator' work.
5663 2008-03-14 Martin Baulig <martin@ximian.com>
5665 * symbolwriter.cs: Added the new symbol writer function from the
5666 debugger's `terrania' branch; temporarily enclose them inside
5667 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5670 2008-03-14 Martin Baulig <martin@ximian.com>
5673 (SymbolWriter): Make this a public static class.
5676 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5677 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5679 2008-03-14 Marek Safar <marek.safar@gmail.com>
5681 A fix for bug #370577
5682 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5685 2008-03-14 Marek Safar <marek.safar@gmail.com>
5687 * typemanager.cs (CSharpName): Made 250 times faster.
5689 2008-03-13 Marek Safar <marek.safar@gmail.com>
5691 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5693 2008-03-12 Marek Safar <marek.safar@gmail.com>
5695 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5696 crash when predefined field does not exist.
5698 2008-03-12 Marek Safar <marek.safar@gmail.com>
5700 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5702 2008-03-12 Marek Safar <marek.safar@gmail.com>
5704 * class.cs (FixedField): Don't crash when contructors are missing.
5706 2008-03-11 Marek Safar <marek.safar@gmail.com>
5708 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5709 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5710 check internal types accessibility for internal and external types.
5711 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5713 2008-03-11 Marek Safar <marek.safar@gmail.com>
5715 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5716 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5717 attribute.cs, statement: Use corect instance of predefined types (work
5718 related to #364674).
5720 2008-03-07 Marek Safar <marek.safar@gmail.com>
5722 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5724 2008-03-07 Marek Safar <marek.safar@gmail.com>
5726 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5727 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5728 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5729 predefined types clean up, delayed predefined types members initialization
5730 (work related to #364674).
5732 2008-03-05 Marek Safar <marek.safar@gmail.com>
5734 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5736 2008-03-05 Marek Safar <marek.safar@gmail.com>
5738 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5739 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5740 predefined types clean up (work related to #364674).
5742 2008-03-04 Marek Safar <marek.safar@gmail.com>
5744 * ecore.cs: Print an error message instead of throwing exception.
5746 2008-03-04 Marek Safar <marek.safar@gmail.com>
5748 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5749 expression.cs, statement.cs: Unififed null literal representation.
5751 2008-03-03 Marek Safar <marek.safar@gmail.com>
5753 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5754 expression.cs: Refactored binary operators resolve phase and improved speed.
5755 The nullable code is still missing and won't work correctly, more fixes
5758 It also fixes #323726, #324312, #324248, and many other unreported issues.
5760 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5762 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5765 2008-02-27 Marek Safar <marek.safar@gmail.com>
5767 * ecore.cs: Clean-up and split BetterConversion.
5769 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5772 * enum.cs (EnumMember.Value): Only access 'value' if
5773 ResolveValue says it's ok.
5774 (EnumMember.DoResolveValue): Don't set prev_member.value.
5775 (Enum.GetDefinition): Reverse arguments of Equals --
5776 EnumMember.Value can return 'null'.
5778 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5780 2008-02-22 Marek Safar <marek.safar@gmail.com>
5782 * generic.cs, expression.cs: More ongoing work on expression trees.
5784 2008-02-21 Marek Safar <marek.safar@gmail.com>
5786 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5787 handle missing matches when mutiple operators exist.
5789 2008-02-20 Marek Safar <marek.safar@gmail.com>
5791 A fix for bug #363218
5792 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5795 2008-02-20 Marek Safar <marek.safar@gmail.com>
5797 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5798 update. This time to deal correctly with SideEffectConstant expression used
5799 as an argument for another constant folding.
5801 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5803 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5806 2008-02-19 Marek Safar <marek.safar@gmail.com>
5808 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5810 2008-02-19 Marek Safar <marek.safar@gmail.com>
5812 A fix for bug #328136
5813 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5814 side is a false constant, because we still need to evaluate the right-hand
5817 * statement.cs (If): Emit two types of boolean constants (simple constant,
5818 side-effect constant).
5820 2008-02-19 Marek Safar <marek.safar@gmail.com>
5822 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5824 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5827 2008-02-18 Marek Safar <marek.safar@gmail.com>
5829 A fix for bug #361457
5830 * ecore.cs (IsApplicable): Params methods have lower priority.
5832 * support.cs: Return correct parameter modifier for params types.
5834 2008-02-18 Marek Safar <marek.safar@gmail.com>
5836 * generic.cs (TypeParameter): Cache attribute target name.
5838 * support.cs: Removed unused variable.
5840 * typemanager.cs: Removed debugging leftover.
5842 * ecore.cs: Use local type instead of a property;
5844 * class.cs (VerifyMembers): Consider also parent to test whether type member
5847 * expression.cs (FullMethodDesc): Removed.
5849 * attribute.cs (IsValidArgumentType): Made static.
5851 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5853 Cleanup to be more readable.
5854 * Makefile (GMCS_PROFILE): Remove.
5855 (COMPILER_NAME): New helper.
5857 2008-02-15 Miguel de Icaza <miguel@novell.com>
5859 * cs-tokenizer.cs: if a conditional expression happens inside a
5860 (...) this also means that we do not need to de-ambiguate between
5861 an parenthesized expression and a cast.
5865 * constant.cs (SideEffectConstant): a constant value that happens
5866 to have a side effect.
5868 Fixes the build regressions introduced by the fix for #359789
5870 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5872 * expression.cs (Conditional.Emit): when emitting the ternary
5873 operator, use local variables to generate code verifiable code.
5875 The verifier cannot infer that the type on stack before the
5876 stloc.0 is executed is of type ParentB. This happens because the
5877 stack merge algorithm uses only parent types when deciding which
5878 is the common type. This is described in Part III 1.8.1.3 of ECMA
5881 This code compiled with mcs is not verifiable under MS. The MS
5882 verifier picks the first common interface of Foo and Bar, which is
5883 wrong, but doesn't use a full join type of the 2 interfaces.
5885 CSC uses a clever hack to compile such code in a verifiable
5886 way. It stores the intermediate values in a local variable with
5891 2008-02-14 Miguel de Icaza <miguel@novell.com>
5893 * expression.cs: Do not fold BitwiseAnd operators when the left
5894 side is a false constant, because we still need to evaluate the
5899 * support.cs: Instead of throwing an InternalErrorException when
5900 the position of the stream is outside the boundary of our buffer,
5901 reset the state of the reader, and restart the reading from the
5902 beginning of the file.
5904 2008-02-14 Marek Safar <marek.safar@gmail.com>
5906 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5908 2008-02-14 Marek Safar <marek.safar@gmail.com>
5910 A fix for bug #361686
5911 * decl.cs: A protected types used inside a private class which parents
5912 derives from the protected class are accessible.
5914 2008-02-13 Marek Safar <marek.safar@gmail.com>
5916 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5917 the parameterless constructor.
5919 2008-02-13 Marek Safar <marek.safar@gmail.com>
5921 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5922 lookup methods to use standard member cache when doing member lookup.
5924 2008-02-12 Marek Safar <marek.safar@gmail.com>
5926 * driver.cs: Don't report full path for referenced module as assembly error.
5928 2008-02-12 Marek Safar <marek.safar@gmail.com>
5930 * Makefile: Fixed `qh' target to work on all machines.
5932 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5933 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5934 and HasElementType with TypeManager implementation.
5936 2008-02-08 Marek Safar <marek.safar@gmail.com>
5938 A fix for bugs #325134, #359749
5939 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5940 first binds point to non-method member expression.
5942 2008-02-08 Marek Safar <marek.safar@gmail.com>
5944 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5946 2008-02-08 Marek Safar <marek.safar@gmail.com>
5948 A fix for bugs #321394, #323028
5949 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5950 Reworked naive IsAccessibleAs implementation to handle nested types.
5952 2008-02-05 Jb Evain <jbevain@novell.com>
5954 * class.cs: use generic type comparison for parameters
5957 2008-02-05 Marek Safar <marek.safar@gmail.com>
5959 A fix for bug #325372
5960 * class.cs: Use generic type comparison when testing method signatures.
5962 2008-02-05 Marek Safar <marek.safar@gmail.com>
5964 A fix for bug #357047
5965 * ecore.cs: Applied C# 3.0 changes to better conversion.
5967 2008-02-05 Marek Safar <marek.safar@gmail.com>
5969 A fix for bug #358374
5970 * cs-parser.jay: Correctly set modifiers for all constructor types.
5972 2008-02-04 Marek Safar <marek.safar@gmail.com>
5974 A fix for bug #355251
5975 * generic.cs: Added base class constraint based type inference.
5977 2008-02-01 Marek Safar <marek.safar@gmail.com>
5979 A fix for bug #357255
5980 * decl.cs: One more missing visibility check.
5982 2008-02-01 Marek Safar <marek.safar@gmail.com>
5984 * support.cs: Fixed broken return.
5986 2008-01-25 Marek Safar <marek.safar@gmail.com>
5988 * report.cs: Correctly reset warnings count after probing.
5990 2008-01-25 Martin Baulig <martin@ximian.com>
5993 (NamespaceEntry.SymbolFileID): Make this work again after
5994 MemberName.ToString() is gone.
5996 2008-01-25 Marek Safar <marek.safar@gmail.com>
5998 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
6001 2008-01-25 Marek Safar <marek.safar@gmail.com>
6003 * generic.cs: Use full implicit conversion for type inference fixing.
6005 2008-01-24 Marek Safar <marek.safar@gmail.com>
6007 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
6008 Fixed user operator conversions.
6010 2008-01-24 Marek Safar <marek.safar@gmail.com>
6012 * generic.cs: Do nullable type to null comparison optimization during
6015 2008-01-24 Marek Safar <marek.safar@gmail.com>
6017 A fix for bug #355163
6018 * generic.cs: Enabled l-value resolve on nullable expressions.
6020 2008-01-24 Marek Safar <marek.safar@gmail.com>
6022 A fix for bug #353986
6023 * class.cs: Ingore static ctors with parameters for any further checks.
6025 2008-01-24 Marek Safar <marek.safar@gmail.com>
6027 A fix for bug #354310
6028 * namespace.cs: Removed redundant check.
6030 2008-01-24 Marek Safar <marek.safar@gmail.com>
6032 A fix for bug #354928
6033 * expression.cs: ElementInitializers can be resolved only once.
6035 2008-01-24 Marek Safar <marek.safar@gmail.com>
6037 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
6038 Condition expressions.
6040 2008-01-23 Marek Safar <marek.safar@gmail.com>
6042 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
6044 2008-01-22 Marek Safar <marek.safar@gmail.com>
6046 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
6049 * generic.cs: Implemented coalesce expression.
6051 2008-01-22 Marek Safar <marek.safar@gmail.com>
6053 A fix for bug #355145
6054 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6055 expression tree type inference.
6057 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6060 * expression.cs (Binary.IsUnsignedType): Fix typo.
6062 2008-01-22 Marek Safar <marek.safar@gmail.com>
6064 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6066 2008-01-22 Marek Safar <marek.safar@gmail.com>
6068 A fix for bug #355161
6069 * ecore.cs, expression.cs: Wider range of extension method supported
6072 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6074 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6075 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6078 2008-01-22 Marek Safar <marek.safar@gmail.com>
6080 A fix for bug #355148
6081 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6083 2008-01-22 Miguel de Icaza <miguel@novell.com>
6085 * expression.cs (CreateExpressionTree): Add support for or and
6086 logical or, and indent following the coding conventions.
6088 * typemanager.cs (LinqExpression): renamed from
6089 ExpressionTreeManager, for a shorter name.
6091 Use TypeManager.CoreLookupType to lookup types from our core
6092 assemblies and turn those into "Type" variables.
6094 Consumers that previously used "Namespace" and "Type" from this
6095 class should instead use the TypeExpression which is a type that
6096 is fully resolved (without involving the regular C# resolution
6099 This typically looks like this:
6101 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6102 new MemberAccess (texpr, name, type_arguments, loc)
6104 This avoids the problem in: #355178
6106 2008-01-21 Marek Safar <marek.safar@gmail.com>
6108 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6109 feature in parser only as we do in other cases.
6111 2008-01-21 Marek Safar <marek.safar@gmail.com>
6113 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6114 typemanager.cs: A refactoring of params arguments to reuse existing
6115 expressions (params -> array initializer) to emit params argument instead
6116 of specialized handling.
6117 It was required by expression tree implementation and it has other benefits
6118 as well, we now apply same optimization for params arguments as we do for
6121 2008-01-18 Marek Safar <marek.safar@gmail.com>
6123 A fix for bug #353526
6124 * generic.cs: A type inference of params arguments may not required any
6125 temporary array creation.
6127 2008-01-18 Marek Safar <marek.safar@gmail.com>
6129 A fix for bug #353534
6130 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6131 supported for delegates only.
6133 2008-01-18 Marek Safar <marek.safar@gmail.com>
6135 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6136 type for more than 1 candidates.
6138 2008-01-18 Marek Safar <marek.safar@gmail.com>
6140 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6143 2008-01-16 Marek Safar <marek.safar@gmail.com>
6145 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6146 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6147 operator) expressions.
6149 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6151 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6152 not accessed from the generated IL.
6154 2008-01-14 Marek Safar <marek.safar@gmail.com>
6156 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6157 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6158 statement.cs: The first expression tree implementation drop, mostly
6159 infrastructure work.
6161 2008-01-14 Marek Safar <marek.safar@gmail.com>
6163 * ecore.cs (IsNestedChild): Refactored.
6165 2008-01-11 Marek Safar <marek.safar@gmail.com>
6167 * lambda.cs: Don't use a cast on unknown expression statement.
6169 2008-01-10 Geoff Norton <gnorton@novell.com>
6171 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6174 2008-01-09 Marek Safar <marek.safar@gmail.com>
6176 * doc.cs: Report better /doc crash details.
6178 2008-01-09 Marek Safar <marek.safar@gmail.com>
6180 A fix for bug #352536
6181 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6183 2008-01-08 Marek Safar <marek.safar@gmail.com>
6185 A fix for bug #352287
6186 * ecore.cs, expression.cs: Do `this' access checking in all member access
6189 2008-01-08 Marek Safar <marek.safar@gmail.com>
6191 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6193 * report.cs: Reset message stacks.
6195 2008-01-08 Marek Safar <marek.safar@gmail.com>
6197 * generic.cs (InferInPhases): Correctly calculate params position.
6199 2008-01-08 Marek Safar <marek.safar@gmail.com>
6201 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6204 2008-01-07 Marek Safar <marek.safar@gmail.com>
6206 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6208 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6210 * driver.cs: Updated --help option.
6212 2008-01-07 Marek Safar <marek.safar@gmail.com>
6214 * generic.cs (InferParamsTypeArguments): Removed.
6215 (InferInPhases): Add params type inference.
6216 (LowerBoundInference): Fixed scoring mechanism.
6218 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6220 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6222 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6223 byte array for unsigned "baked" assemblies.
6225 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6227 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6228 array for assemblies that are not strongnamed.
6230 2008-01-04 Marek Safar <marek.safar@gmail.com>
6232 A fix for bug #351481
6233 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6234 declaring type for nested generic types.
6236 2008-01-04 Marek Safar <marek.safar@gmail.com>
6238 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6239 instead of ToString.
6241 2008-01-03 Marek Safar <marek.safar@gmail.com>
6243 A fix for bug #351047
6244 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6245 null and structs only when equality and inequality operators are defined
6246 either as an user-operators or predefined operators.
6248 2008-01-03 Marek Safar <marek.safar@gmail.com>
6250 A fix for bug #351047
6251 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6253 2008-01-03 Marek Safar <marek.safar@gmail.com>
6255 A fix for bug #351257
6256 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6258 2008-01-03 Marek Safar <marek.safar@gmail.com>
6260 A fix for bug #351157
6261 * class.cs (Using): Fixed yet another broken cloning.
6263 (Block): Put back more sensible default value for statements.
6265 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6267 * codegen.cs: Allow AssemblyVersion with only major version component.
6270 2007-12-29 Marek Safar <marek.safar@gmail.com>
6272 A fix for bug #324654
6273 * class.cs: Use FullName property as member name.
6275 2007-12-28 Marek Safar <marek.safar@gmail.com>
6277 A fix for bug #342117
6278 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6279 constructor constraint.
6281 2007-12-28 Marek Safar <marek.safar@gmail.com>
6283 A fix for bug #338273
6284 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6287 2007-12-28 Marek Safar <marek.safar@gmail.com>
6289 A fix for bug #350839
6290 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6292 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6294 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6297 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6299 * statement.cs: Changed some Hashtables to use HybridDictionaries
6300 instead. It was observed that some HashTables only contained a few
6301 items in the vast majority of cases. Since HybridDictionary is
6302 more efficient on small sets (<10 elements), "known_variables"
6303 from class ExplicitBlock as well as "labels" and "constants " from
6304 class Block were changed to HybridDictionaries.
6306 Atsai results: (56216kb->54987kb)
6308 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6311 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6313 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6316 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6318 * expression.cs: foreach loop to for loop, saved on allocation of
6319 enumerator (59333kb->59141kb)
6321 * statement.cs. Changed foreach loops to for loops, saved on
6322 allocation of enumerator (59141kb->59006kb)
6324 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6325 when constructed with no specified capacity. This was causing a
6326 few ArrayLists to allocate more memory than they would potentially
6327 need in the Block class and MemberCache class. Setting the
6328 ArrayLists to construct with a capacity of 1 saves some
6329 memory. (56216kb->55585kb)
6331 2007-12-27 Marek Safar <marek.safar@gmail.com>
6333 A fix for bug #347189 (2nd issue)
6334 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6337 2007-12-27 Miguel de Icaza <miguel@novell.com>
6339 * report.cs: Do not use colors if stdout and stderr are not a
6342 2007-12-27 Marek Safar <marek.safar@gmail.com>
6344 A fix for bug #346998
6345 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6348 2007-12-27 Marek Safar <marek.safar@gmail.com>
6350 A fix for bug #343465
6351 * class.cs: Explicit method name for nested types uses dots only.
6353 2007-12-27 Marek Safar <marek.safar@gmail.com>
6355 A fix for bug #343707
6356 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6358 2007-12-27 Marek Safar <marek.safar@gmail.com>
6360 * ecore.cs: Report type inference errors only when arguments count matches
6363 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6365 * expression.cs, report.cs: New warning.
6367 * typemanager.cs: Catch anonymous method type too.
6369 2007-12-23 Marek Safar <marek.safar@gmail.com>
6371 A fix for bug #346379
6372 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6374 2007-12-23 Marek Safar <marek.safar@gmail.com>
6376 A fix for bug #347359
6377 * expression.cs (Invocation): Don't resolve already resolved expression.
6379 2007-12-23 Marek Safar <marek.safar@gmail.com>
6381 A fix for bug #347189
6382 * class.cs (FixedField): Use non-dependent code only in the define phase.
6384 2007-12-23 Marek Safar <marek.safar@gmail.com>
6386 A fix for bug #348076
6387 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6389 2007-12-22 Marek Safar <marek.safar@gmail.com>
6391 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6392 discovered extension methods.
6394 2007-12-22 Marek Safar <marek.safar@gmail.com>
6396 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6399 2007-12-21 Miguel de Icaza <miguel@novell.com>
6401 * report.cs (ErrorMessage): Add support for using colors on
6402 terminals that support it.
6404 2007-12-21 Marek Safar <marek.safar@gmail.com>
6406 * ecore.cs: Use information about expanded params for error reporting.
6408 2007-12-21 Marek Safar <marek.safar@gmail.com>
6410 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6411 and logic for params overloads.
6413 2007-12-15 Miguel de Icaza <miguel@novell.com>
6415 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6416 as this is also created from the parser. Fixes #349034
6418 2007-12-12 Miguel de Icaza <miguel@novell.com>
6420 * statement.cs (Throw.CloneTo): it is valid to have empty
6421 expressions for throw.
6423 2007-12-03 Marek Safar <marek.safar@gmail.com>
6425 * cs-parser.jay: Set delegate constraint parsing region correctly.
6427 2007-12-03 Marek Safar <marek.safar@gmail.com>
6429 A fix for bug #345467
6430 * typemanager.cs (IsEqual): Compare generic parameters position only.
6432 2007-11-28 Marek Safar <marek.safar@gmail.com>
6434 * expression.cs (BaseAccess): Type arguments can be null.
6436 2007-11-27 Raja R Harinath <harinath@gmail.com>
6438 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6439 consistent even when an error has occured.
6440 (Switch.Resolve): Likewise.
6442 2007-11-22 Marek Safar <marek.safar@gmail.com>
6444 A fix for bug #334505
6445 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6448 2007-11-22 Marek Safar <marek.safar@gmail.com>
6450 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6451 refactorings required to resolve extension methods correctly when mixing
6452 generics and non-generics members.
6454 2007-11-20 Marek Safar <marek.safar@gmail.com>
6456 A fix for bug #342584
6457 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6460 2007-11-19 Marek Safar <marek.safar@gmail.com>
6462 A fix for bug #342512
6463 * delegate.cs: Use delegate argument expression when is available. Don't
6464 emit virtual call when class is sealed.
6466 2007-11-16 Marek Safar <marek.safar@gmail.com>
6468 A fix for bug #325423
6469 * assign.cs (FieldInitializer): Use resolved expression for emit.
6471 * class.cs: Print less confusing error message.
6473 2007-11-16 Marek Safar <marek.safar@gmail.com>
6475 * cs-tokenizer.cs: Removed GMCS ifdefs.
6477 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6480 * cs-parser.jay: Disabled nullable check.
6482 * generic-mcs: Copied more generic stuff.
6484 2007-11-16 Marek Safar <marek.safar@gmail.com>
6486 * gcs-parser.jay: Merged to cs-parser.jay.
6488 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6489 * *.csproj, *.sources: Updated to use only jay parser file.
6491 2007-11-16 Marek Safar <marek.safar@gmail.com>
6493 * gcs-parser.jay: Added nullable and default expression feature checks.
6495 2007-11-16 Marek Safar <marek.safar@gmail.com>
6497 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6498 it fixes many TODOs and hidden bugs.
6500 * expression: Removed duplicate error check.
6502 2007-11-15 Marek Safar <marek.safar@gmail.com>
6504 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6505 implicitly type local variable only when it is used in a declaration.
6507 2007-11-15 Marek Safar <marek.safar@gmail.com>
6509 * attribute.cs: Use CS0612 for empty strings.
6511 2007-11-14 Marek Safar <marek.safar@gmail.com>
6513 * lambda.cs, statement.cs: Contextual return may act as a statement.
6515 2007-11-14 Marek Safar <marek.safar@gmail.com>
6517 A fix for a regression cause by #324222
6518 * class.cs: Don't report unused even when it implements an interface.
6520 2007-11-13 Marek Safar <marek.safar@gmail.com>
6522 A fix for bug #341205
6523 * ecore.cs, expression.cs: Method group expression cannot do static
6524 method access with an instance reference check before overloading takes
6527 2007-11-13 Marek Safar <marek.safar@gmail.com>
6529 A fix for bug #325359
6530 * class.cs: Use predictable name for automatically generated property.
6532 2007-11-12 Marek Safar <marek.safar@gmail.com>
6534 A fix for bug #324996
6535 * expression.cs (Is): Handle case where D is nullable and T is not
6538 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6540 2007-11-12 Marek Safar <marek.safar@gmail.com>
6542 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6543 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6544 Flush small error reporting changes.
6546 2007-11-09 Marek Safar <marek.safar@gmail.com>
6548 A fix for bug #324996
6549 * expression.cs: Rewrote Is expression implementation to work with
6550 generics, nullable types, anonymous method. A const result expression
6551 uses existing infrastructure instead of custom not fully-featured one.
6553 2007-11-08 Marek Safar <marek.safar@gmail.com>
6555 A fix for bug #340202
6556 * class.cs: Consider generics for volatile field.
6558 2007-11-08 Marek Safar <marek.safar@gmail.com>
6560 A fix for bug #335594
6561 * expression.cs: Use conversion rules when handling string addition.
6563 2007-11-07 Marek Safar <marek.safar@gmail.com>
6565 A fix for bug #336651
6566 * expression.cs: Fixed a crash when probing is on.
6568 2007-11-07 Marek Safar <marek.safar@gmail.com>
6570 A fix for bug #324242
6571 * covert.cs: Added a conversion from any nullable-type with an
6572 underlying enum-type to the type System.Enum.
6574 2007-11-07 Marek Safar <marek.safar@gmail.com>
6576 A fix for bug #324222
6577 * class.cs: Report all non-used event fields.
6579 2007-11-07 Marek Safar <marek.safar@gmail.com>
6581 A fix for bug #325161
6582 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6583 qualifier for generic types.
6585 2007-11-07 Marek Safar <marek.safar@gmail.com>
6587 A fix for bug #322971
6588 * expression.cs, ecore.cs: Added intermediate result value check for
6591 2007-11-07 Marek Safar <marek.safar@gmail.com>
6593 A fix for bug #324754
6594 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6595 when it was requested.
6597 2007-11-07 Marek Safar <marek.safar@gmail.com>
6599 A fix for bug #325101
6600 * expression.cs: Do type not value comparison for `is' expression.
6602 2007-11-07 Marek Safar <marek.safar@gmail.com>
6604 A fix for bug #320236
6605 * convert.cs: Don't apply user conversion on underlying target type.
6607 2007-11-06 Marek Safar <marek.safar@gmail.com>
6609 * expression.cs: Don't use unresolved expression for error reporting.
6611 2007-11-06 Marek Safar <marek.safar@gmail.com>
6613 A fix for bugs #337712, #324490
6614 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6615 overloading resolution too.
6617 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6618 the process consistent and more robust.
6620 * expression.cs, linq.cs, report.cs: Update.
6622 2007-11-02 Marek Safar <marek.safar@gmail.com>
6624 A fix for bug #332909
6625 * attribute.cs: Resolve attributes in correct context using error
6628 * rootcontext.cs: Define Obsolete attribute members as core members.
6630 2007-11-02 Marek Safar <marek.safar@gmail.com>
6632 * statement.cs: Removed unused methods.
6634 2007-10-31 Wade Berrier <wberrier@novell.com>
6636 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6637 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6640 2007-10-31 Marek Safar <marek.safar@gmail.com>
6642 A fix for bug #338102
6643 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6644 methods registered as non-generics.
6646 2007-10-31 Marek Safar <marek.safar@gmail.com>
6648 A fix for bugs #337712, #324490
6649 * delegate.cs: Delegate covariance and contravariance is not allowed for
6652 2007-10-31 Marek Safar <marek.safar@gmail.com>
6654 A fix for bug #337719
6655 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6658 2007-10-30 Marek Safar <marek.safar@gmail.com>
6660 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6662 2007-10-29 Marek Safar <marek.safar@gmail.com>
6664 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6667 2007-10-29 Raja R Harinath <rharinath@novell.com>
6669 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6671 2007-10-29 Marek Safar <marek.safar@gmail.com>
6673 A fix for bug #334652
6674 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6675 extension methods when we have not found the best candidate in normal
6678 2007-10-27 Marek Safar <marek.safar@gmail.com>
6680 * AssemblyInfo.cs: Keep up-to-date.
6682 2007-10-27 Marek Safar <marek.safar@gmail.com>
6684 * Makefile: Fixed generics compiler name.
6686 2007-10-27 Marek Safar <marek.safar@gmail.com>
6688 * lambda.test: removed, lambda parsing is done differently.
6690 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6692 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6694 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6696 2007-10-27 Marek Safar <marek.safar@gmail.com>
6698 * Makefile, *.sources : All C# compilers are in mcs folder.
6700 * *.cs: Use existing 2_1 define for smcs.
6702 2007-10-26 Marek Safar <marek.safar@gmail.com>
6704 A fix for bug #335847
6705 * assign.cs, expression.cs: Couple of changes to avoid creating a
6706 temporary variable for each object initializer assignment statement. It
6707 simplifies struct initialization too, otherwise two temporary variables
6709 Implemented optimization of redundant default element initializers.
6711 2007-10-25 Marek Safar <marek.safar@gmail.com>
6713 A fix for bug #336766
6714 * expression.cs (Class.CheckBase): Use generic name when method is
6717 2007-10-25 Marek Safar <marek.safar@gmail.com>
6719 A fix for bug #334737
6720 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6721 variable and not variable argument for prepared copies.
6723 2007-10-24 Marek Safar <marek.safar@gmail.com>
6725 A fix for bug #325110
6726 * class.cs, expression.cs, attribute.cs: Use open generic method when
6727 checking conditional attribute.
6729 2007-10-24 Marek Safar <marek.safar@gmail.com>
6731 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6732 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6733 FeatureIsNotAvailable.
6735 2007-10-24 Marek Safar <marek.safar@gmail.com>
6737 ** C# 3.0 Partial methods
6739 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6740 methods support. Because of member cache issue with generics only
6741 non-generics partial methods are fully supported.
6743 2007-10-23 Marek Safar <marek.safar@gmail.com>
6745 * class.cs, decl.cs: Rewrote member overloads check to cope with
6746 generics and to use member cache for member checking. It also improves
6747 performance and fixes remaining overloads issues.
6749 2007-10-20 Marek Safar <marek.safar@gmail.com>
6751 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6752 roottypes.cs, typemanager.cs:
6754 A member cache creation logic changed to add members immediately and
6755 not rely on fallback. The member cache is now only prefered way
6756 how to access and find type declaration members. It saves 5 MB of memory
6757 during MWF compilation and makes code ready for more optimizations and
6758 clean-ups, it's also a pre-requirement for partial methods.
6760 2007-10-18 Raja R Harinath <harinath@gmail.com>
6762 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6763 handling for generic parameters.
6765 2007-10-15 Marek Safar <marek.safar@gmail.com>
6767 * class.cs (FixedField): Removed redundant volatile check.
6769 2007-10-15 Marek Safar <marek.safar@gmail.com>
6771 * class.cs, decl.cs: Fixed overload members verification to do only one
6772 check per possible collision.
6774 2007-10-13 Marek Safar <marek.safar@gmail.com>
6776 A fix for bug #325478
6777 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6778 and create only one disposable flags container.
6780 2007-10-12 Marek Safar <marek.safar@gmail.com>
6782 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6783 * statement.cs (Fixed): Fixed variables cloning.
6785 2007-10-12 Marek Safar <marek.safar@gmail.com>
6787 A fix for bug #333342
6788 * class.cs (EventField): Don't mark value type event as synchronized.
6790 2007-10-12 Marek Safar <marek.safar@gmail.com>
6792 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6793 inference to identify best candidate method correctly.
6794 (ProperyExpr): A range variable is read only and cannot be modified.
6796 2007-10-11 Marek Safar <marek.safar@gmail.com>
6798 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6799 logic to identify best candidate method correctly.
6801 2007-10-11 Marek Safar <marek.safar@gmail.com>
6803 * location.cs (Equals, GetHashCode): Removed.
6805 2007-10-11 Marek Safar <marek.safar@gmail.com>
6807 * report.cs: Implemented message recorder. It is used mainly for lambda
6808 expressions to capture otherwise swallowed error messages.
6810 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6812 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6814 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6816 * expression.cs (MemberAccess): Always report lookup failure.
6818 * location.cs: Implemented Equals, GetHashCode.
6820 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6822 2007-10-10 Jb Evain <jbevain@novell.com>
6824 * codegen.cs: re-enable assembly version check.
6826 2007-10-09 Marek Safar <marek.safar@gmail.com>
6828 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6831 * namespace.cs (UsingAlias): Do correct version check.
6833 2007-10-08 Marek Safar <marek.safar@gmail.com>
6835 * expresison.cs, ecore.cs: Issue extension method error message when
6838 * rootcontext.cs: Added ISO_2 compiler mode option.
6840 2007-10-08 Marek Safar <marek.safar@gmail.com>
6842 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6845 2007-10-08 Marek Safar <marek.safar@gmail.com>
6847 * attribute.cs (GetString, GetBoolean): Work with both literal and
6850 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6851 Moved method overload specific methods to MethodGroupExpr.
6853 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6854 it should be less memory consuming.
6856 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6858 * codegen.cs: remove the assembly version check until the buildbot is
6861 2007-10-07 Jb Evain <jbevain@novell.com>
6863 * attribute.cs (Attribute.GetString): if the value
6864 expression is a StringConstant, return its string value.
6866 2007-10-07 Jb Evain <jbevain@novell.com>
6868 * typemanager.cs: add `assembly_version_attribute_type`.
6869 * codegen.cs: on attribute emission, check that the
6870 AssemblyVersionAttribute doesn't overflow.
6872 2007-10-05 Marek Safar <marek.safar@gmail.com>
6874 A fix for bug #324677
6875 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6876 parent container of a scope container with currently resolved one.
6878 2007-10-05 Marek Safar <marek.safar@gmail.com>
6880 A fix for bug #325534
6881 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6884 2007-10-05 Marek Safar <marek.safar@gmail.com>
6886 A fix for bug #327504
6887 * class.cs (Operator.Define): Refactored implicit and explicit user
6888 operator conversion rules.
6890 2007-10-05 Marek Safar <marek.safar@gmail.com>
6892 A fix for bug #327520
6893 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6895 2007-10-04 Marek Safar <marek.safar@gmail.com>
6897 A fix for bug #328022
6898 * class.cs (MethodData.Define): Use correct method to check whether
6899 a method implementents an accessor.
6901 2007-10-04 Marek Safar <marek.safar@gmail.com>
6903 A fix for bug #330069
6904 * statement.cs (Fixed.Resolve): Read the first array element only when
6905 an array is instantiated.
6907 2007-10-04 Marek Safar <marek.safar@gmail.com>
6909 * expression.cs, assign.cs, generics.cs: Print correct operator when
6910 compound assignment is used.
6912 2007-10-04 Marek Safar <marek.safar@gmail.com>
6914 A fix for bug #325841
6915 * expression.cs (ArrayAccess): Use full argument cloning only for
6916 string compound concatenation.
6918 2007-10-03 Marek Safar <marek.safar@gmail.com>
6920 A fix for bug #328774
6921 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6923 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6926 2007-10-03 Raja R Harinath <rharinath@novell.com>
6929 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6930 Event accessibility checks here. Remove some bogus code that
6931 accidently made GenericMethods work.
6932 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6934 2007-09-25 Marek Safar <marek.safar@gmail.com>
6936 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6938 * statement.cs (Block): Refactored AddVariable to allow error handling
6941 * generic.cs: New stub.
6943 2007-09-23 Marek Safar <marek.safar@gmail.com>
6945 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6948 2007-09-17 Marek Safar <marek.safar@gmail.com>
6950 * class.cs: Use partial container to record whether any partial part
6951 contains static field initializer and therefore default contructor has
6954 2007-09-14 Marek Safar <marek.safar@gmail.com>
6956 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6957 mono-list when only one of two partial parts has defined accessibility
6960 2007-09-14 Marek Safar <marek.safar@gmail.com>
6962 A fix for bug #82845
6964 * class.cs (TypeContainer): Set correct resolve context for all field
6967 2007-09-13 Marek Safar <marek.safar@gmail.com>
6969 * assign.cs: Fixed a crash when field is resolved twice with an error.
6971 * codegen.cs: Changed InFieldInitializer to be flag.
6973 * anonymous.cs, ecore.cs, expression.cs: Update after
6974 IsInFieldInitializer rename.
6976 * const.cs: Removed unused parameter.
6978 * class.cs: Changed the way how we resolve and emit field initializers.
6979 The field initilizers have to have access to contructor block to emit
6980 compiler generated code.
6982 2007-09-13 Marek Safar <marek.safar@gmail.com>
6984 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6985 generics use TypeContainer instead.
6987 2007-09-12 Marek Safar <marek.safar@gmail.com>
6989 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6991 * lambda.cs (ResolveParameters): Use more powerful
6992 InflateGenericArgument.
6994 * parameters.cs: Better exception message.
6996 2007-09-10 Marek Safar <marek.safar@gmail.com>
6998 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6999 correct expression block type.
7001 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
7003 * expression.cs (Invocation): Extracted method group resolve to
7006 2007-09-07 Marek Safar <marek.safar@gmail.com>
7008 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
7009 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
7011 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
7012 generic extension methods.
7014 2007-09-06 Marek Safar <marek.safar@gmail.com>
7016 A fix for bug #82676 (Do I get it right now?)
7017 * convert.cs (Binary.ResolveOperator): An interface is converted to the
7018 object before a standard conversion is applied.
7020 2007-09-06 Marek Safar <marek.safar@gmail.com>
7022 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
7025 2007-09-05 Marek Safar <marek.safar@gmail.com>
7027 A fix for bug #82676
7028 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
7029 non-generic interface types.
7031 2007-09-05 Marek Safar <marek.safar@gmail.com>
7033 A fix for bug #82690
7034 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
7036 2007-09-05 Marek Safar <marek.safar@gmail.com>
7038 A fix for bug #82571
7039 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
7040 modifier for container based methods.
7042 2007-09-05 Marek Safar <marek.safar@gmail.com>
7044 A fix for bug #82676
7045 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
7046 any interface-type T means to any of interface type T.
7048 2007-09-04 Marek Safar <marek.safar@gmail.com>
7050 * namespace.cs: We have 2 versions of System.Core assembly.
7052 2007-09-04 Marek Safar <marek.safar@gmail.com>
7054 A fix for bug #82652
7055 * class.cs (Class.GetClassBases): Compare types and not expressions.
7057 2007-09-04 Marek Safar <marek.safar@gmail.com>
7059 A fix for bug #82620
7060 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7061 actually never worked before.
7062 (IndexerAccess): Emit prepared arguments before they are modified.
7064 2007-09-04 Marek Safar <marek.safar@gmail.com>
7066 A fix for bug #82563
7067 * assign.cs: Revert wrong fix.
7069 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7071 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7072 Instead of ldelema/stdind we have to use temporary variables to handle
7073 cases like String.Concat (params string[]).
7075 2007-08-31 Marek Safar <marek.safar@gmail.com>
7077 * class.cs: EmitAttributes to Emit rename.
7079 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7081 (MemberCore.HasClsCompliantAttribute): Don't depend on
7082 GetClsCompliantAttributeValue execution.
7084 2007-08-31 Marek Safar <marek.safar@gmail.com>
7086 * anonymous.cs: Use shorter type prefix.
7088 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7091 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7092 variables when probing is on.
7094 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7095 unresolved variables.
7096 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7097 handle transparent identifiers.
7099 2007-08-26 Marek Safar <marek.safar@gmail.com>
7101 * attribute.cs (IsClsCompliant): Add nullable types test.
7103 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7105 * doc.cs : catch other types of exception than XmlException to
7106 report CS1570. Fixed bug #82565.
7108 2007-08-23 Marek Safar <marek.safar@gmail.com>
7110 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7111 The number of delegate parameters has to match.
7112 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7115 2007-08-21 Marek Safar <marek.safar@gmail.com>
7117 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7118 to fix problem with private arguments.
7120 2007-08-20 Marek Safar <marek.safar@gmail.com>
7122 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7124 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7126 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7127 empty. Add cloning suport.
7129 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7131 2007-08-20 Marek Safar <marek.safar@gmail.com>
7133 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7134 to create EmptyCast. It handles EmptyConstantCast specialization for
7137 2007-08-18 Marek Safar <marek.safar@gmail.com>
7139 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7140 (EmitArrayArgument): One routine for array arguments.
7141 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7143 2007-08-17 Marek Safar <marek.safar@gmail.com>
7145 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7147 2007-08-17 Marek Safar <marek.safar@gmail.com>
7149 * anonymous.cs: MemberLookupFinal update.
7151 * class.cs (ConstructorInitializer): Is expression based.
7153 * delegate.cs: MethodGroupExpr update.
7155 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7157 (Error_MemberLookupFailed): Customizable error override.
7158 (MethodGroupExpr): Keep queried type for later usage.
7159 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7162 * expression.cs: Error_MemberLookupFailed refactoring.
7163 (New.DoResolve): Resolve as much as possible.
7164 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7165 customization for invalid member types.
7167 * statement.cs: MethodGroupExpr update.
7169 2007-08-16 Marek Safar <marek.safar@gmail.com>
7171 * modifier.cs (Check): Check all modifiers and not only accessibility
7174 2007-08-16 Marek Safar <marek.safar@gmail.com>
7176 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7177 type and not an expression.
7179 2007-08-16 Marek Safar <marek.safar@gmail.com>
7181 * statement.cs (Catch.Clone): Type and variable can be null.
7183 2007-08-16 Marek Safar <marek.safar@gmail.com>
7185 A fix for bug #81979
7186 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7187 I am really not sure whether this is the best fix.
7189 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7192 2007-08-14 Marek Safar <marek.safar@gmail.com>
7194 ** C# 3.0 Object and collection initializers (major re-write)
7196 * assign.cs (DoResolve): Initializers are not assign related.
7198 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7199 used during collection or object initialization.
7201 * expression.cs (Error_InvalidArguments): Add initializers specific
7202 messages. More will come later because it requires some general
7204 (New.DoResolve): Better error handling for unsafe types.
7205 (EmptyExpressionStatement): New class.
7206 (ElementInitializer): An object initializer expression.
7207 (CollectionElementInitializer): A collection initializer expression.
7208 (CollectionOrObjectInitializers): A block of object or collection
7210 (NewInitialize): New expression with element/object initializers.
7212 * statement.cs: Reverted object/collection initializer hacks.
7214 * typemanager.cs (CSharpName): Filter __arglist type.
7216 2007-08-09 Marek Safar <marek.safar@gmail.com>
7218 ** C# 3.0 Anonymous Types (update to the latest standard)
7220 * expression.cs (Binary.ResolveOperator): Threat all null based types
7222 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7223 (AnonymousTypeParameter): Updated.
7225 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7226 (AnonymousTypeClass): New anonymous type container.
7228 * class.cs (AddField): Return operation result.
7230 * generic.cs: Another empty TypeArguments overload.
7232 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7233 are stored at top of normal hierarchy.
7235 * typemanager.cs (CSharpName): Filter anonymous types.
7237 2007-08-09 Marek Safar <marek.safar@gmail.com>
7239 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7240 as single Concat call. How could we miss that :-(
7242 2007-08-08 Marek Safar <marek.safar@gmail.com>
7244 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7246 2007-08-07 Miguel de Icaza <miguel@novell.com>
7248 * expression.cs: Fix the previous commit, the creation of the
7249 arguments array list needs also to be conditional on the arguments
7252 * class.cs: Add a little bit of help to help narrow down problems.
7254 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7255 not try to copy in that case.
7257 * driver.cs: When building SMCS, include a new different set of
7258 default assemblies here. Do this here so we can control whether
7259 to include the default assemblies with /noconfig.
7261 2007-08-03 Marek Safar <marek.safar@gmail.com>
7263 A fix for bug #81979
7264 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7267 2007-08-03 Marek Safar <marek.safar@gmail.com>
7269 A fix for bug #82300
7271 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7272 we are in probing scope.
7274 2007-08-03 Marek Safar <marek.safar@gmail.com>
7276 A fix for bug #82301
7278 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7279 (Statement.CloneTo): Clone and not map children blocks.
7281 2007-08-03 Marek Safar <marek.safar@gmail.com>
7283 A fix for bug #82299
7285 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7288 * statement.cs (Statement.CloneTo): Clone variables before statements
7289 to allow remaping of local variables.
7291 2007-08-03 Marek Safar <marek.safar@gmail.com>
7293 A fix for bug #82296
7296 * report.cs: Log crash details for future clone problems.
7298 * statement.cs (Return.Clone): Don't clone non-existent expression.
7300 2007-08-03 Raja R Harinath <harinath@gmail.com>
7302 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7303 (Class.AddBasesForPart): Move CS0537 check here from ...
7304 * cs-parser.jay (class_declaration): ... here. Move calling of
7305 'AddBasesForPart' to ...
7306 (class_bases): ... here.
7307 (struct_declaration, interface_declaration): Update to changes.
7309 2007-08-02 Marek Safar <marek.safar@gmail.com>
7311 A fix for bug #81923
7313 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7314 conversion is allowed.
7316 2007-08-02 Marek Safar <marek.safar@gmail.com>
7318 A fix for bug #81564
7320 * ecore.cs (EventExpr): Add IsBase handling.
7322 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7325 2007-08-02 Raja R Harinath <harinath@gmail.com>
7327 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7328 * cs-parser.jay: Some whitespace cleanups.
7329 (current_delegate): New.
7331 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7332 a dummy code block, and use 'type_name' instead of 'member_name'.
7333 (interface_declaration, class_declaration): Likewise.
7334 (delegate_declaration): Likewise. Rearrange slightly and use
7336 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7337 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7339 2007-08-02 Marek Safar <marek.safar@gmail.com>
7341 A fix for bug #82039
7343 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7346 * typemanager.cs (CSharpName): Split to string overload.
7348 2007-08-02 Marek Safar <marek.safar@gmail.com>
7351 * report.cs: Updated warning CS0472.
7353 2007-08-01 Marek Safar <marek.safar@gmail.com>
7355 A fix for bug #82181
7357 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7359 2007-08-01 Marek Safar <marek.safar@gmail.com>
7361 A fix for bug #82277
7362 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7364 2007-08-01 Marek Safar <marek.safar@gmail.com>
7366 ** C# 3.0 Type Inference (major bits are working)
7368 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7369 (.ImplicitStandardConversionExists): Uses compatible.
7370 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7371 (.InferReturnType): New method.
7372 (.Compatible): Refactored.
7373 (.ResolveParameters): Uses factory to create resolved parameters.
7374 (.CompatibleMethod): Add probing mode support.
7375 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7376 clearly distinguish between 2 different operations.
7377 (LambdaMethod): Moved to lambda.cs.
7378 (AnonymousMethod): Removed unused fields and methods.
7379 (AnonymousDelegate): Simplified.
7381 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7383 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7385 * delegate.cs (Delegate): New mehods to reduce code duplication.
7386 (.GetConstructor): New method.
7387 (.GetInvokeMethod): New method.
7388 (DelegateCreation): Updated.
7390 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7392 (OverloadResolve): Made probing little bit faster.
7394 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7397 * generic.cs (TypeInferenceContext): Dummy implementation.
7399 * iterators.cs: Updated after Resolve/Define rename.
7401 * lambda.cs (LambdaExpression)
7402 (.ResolveParameters): Handles both type of arguments and type inference too.
7404 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7405 (InflateTypes): Updated.
7407 * support.cs (InflateTypes): Changed signature and updated.
7409 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7410 (MemberLookup_FindMembers): More MS tricks.
7411 (GetParameterData): Ditto.
7412 (GetDelegateParameters): Uses quick path for dynamic types.
7414 2007-08-01 Marek Safar <marek.safar@gmail.com>
7416 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7419 2007-07-31 Marek Safar <marek.safar@gmail.com>
7421 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7424 2007-07-26 Jb Evain <jbevain@novell.com>
7426 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7427 which takes a boolean 'report_errors', similar to the GetMethod.
7428 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7429 in .net 2.1, do not report errors here.
7431 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7432 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7433 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7436 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7437 of the type InternalsVisibleToAttribute before the first call
7438 to CoreLookupType which is allowed to fail (third boolean parameter
7439 to true). Because, during the resolution for a type that is not
7440 immediately found, we try to check if the type is not defined in
7441 a friend assembly, and to do so, we need the
7442 InternalVisibleToAttribute.
7444 2007-07-23 Miguel de Icaza <miguel@novell.com>
7446 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7447 feature that allows structs to be compared against null and inline
7448 the result as true or false.
7450 Notice that the same code is not permitted inside a generic block
7451 of code that would do:
7453 class Foo<T> where T : struct {
7460 It is only allowed if the type of T is not bound (no where
7461 clause). In my opinion, this CSC 2 behavior is broken but people
7462 seem to be using it (IronRuby does, a few bug reports on bugzilla
7463 have it and some people have complained about it).
7465 All of the users that depend on this behavior have code that is
7468 * report.cs (Warning, Error): make these take object arguments,
7469 not strings, as that allows us to take advantage of Format.
7471 2007-07-20 William Holmes <billholmes54@gmail.com>
7473 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7474 Left member variable for the Count.
7475 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7476 MemberName.CountTypeArguments to avoid a NRE.
7478 This code is contributed under the MIT X11 license
7480 2007-07-18 Marek Safar <marek.safar@gmail.com>
7482 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7484 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7486 * doc.cs : generic method arguments are written as ``x while generic
7487 type arguments are `x. Combined with the previous change, fixed bug
7490 2007-07-18 Raja R Harinath <rharinath@novell.com>
7493 * expression.cs (Binary.ResolveOperator): When converting
7494 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7496 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7498 * doc.cs : when T: or whatever x: is specified, it does not really
7499 check the doc comment's syntax correctness. Fixed bug #82006.
7501 2007-07-18 Marek Safar <marek.safar@gmail.com>
7503 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7504 LambdaExpression better.
7506 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7508 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7510 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7511 as it can be generated.
7513 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7516 * lambda.cs (LambdaExpression): Refactored to share same code with
7517 AnonymousMethodExpression.
7519 2007-07-17 Marek Safar <marek.safar@gmail.com>
7521 * anonymous.cs (MakeName): Include host name for easier debugging.
7522 (LambdaMethod): New class for lambda spcecific stuff.
7524 * attribute.cs: Set EmitContext return type.
7526 * class.cs: Set EmitContext return type.
7528 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7529 with null/void meaning.
7531 * iterators.cs (ContainerType): Implemented.
7533 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7535 * statement.cs (Return): Updated to lambda expressions.
7536 (Block.CloneTo): Parent can be null.
7538 2007-07-13 Marek Safar <marek.safar@gmail.com>
7540 A fix for bug #81917
7541 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7543 * class.cs (FixedField): Check whether field is in unsafe scope.
7545 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7546 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7548 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7551 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7553 2007-07-13 Marek Safar <marek.safar@gmail.com>
7555 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7556 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7559 2007-07-13 Marek Safar <marek.safar@gmail.com>
7561 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7563 2007-07-13 Marek Safar <marek.safar@gmail.com>
7565 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7566 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7568 * codegen.cs(EmitContext): Add ProbingMode flag.
7570 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7572 * driver.cs: For now set both warning values.
7574 * ecore.cs (SimpleName): Name is readonly.
7575 (MethodGroup.OverloadResolve): One quick path for probing.
7577 * expression.cs (Unary): Set Oper r/o.
7578 (Binary): Set Oper r/o.
7579 (ParameterReference): Set few instance variables as r/o.
7580 (ParameterReference.DoResolveBase): Don't capture aruments when
7582 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7583 (Arglist): arguments are private.
7584 (SizeOf): type is private and r/o.
7585 (MemberAccess): arguments are private.
7587 * report.cs: Enhanced reporting on/off capabilities.
7589 * lambda.cs: Uses ec.IsInProbingMode.
7590 (ContextualReturn): Derives from return.
7592 * rootcontext.cs: For now set both warning values.
7594 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7596 (Return.Resolve): Don't die immediately.
7597 (Block.Resolve): Speed-up probing.
7598 (Block.CloneTo): Clone only child blocks.
7600 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7602 * iterators.cs: reverted Miguel's latest change (r81925) as it
7603 breaks the build in System.
7605 2007-07-13 Miguel de Icaza <miguel@novell.com>
7607 * iterators.cs (Yield.CheckContext): Check for the iterator type
7608 also here as we can call into Yield even in codepaths that are not
7610 (MethodOrOperator is the only path that was checked).
7612 In addition to the standard check, use a more specific check for
7613 constructors to report a more verbose error.
7615 2007-07-12 Miguel de Icaza <miguel@novell.com>
7617 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7618 report the warning and continue
7620 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7621 values on the stack on the call to Emit. Use EmitStatement if
7622 possible, or using Emit + Pop if not possible. Fixes #82064
7624 2007-07-12 Raja R Harinath <rharinath@novell.com>
7626 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7627 avoid try...finally in some cases.
7629 2007-07-10 Marek Safar <marek.safar@gmail.com>
7631 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7633 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7634 instead of method. Re-use standard error handling.
7635 (ConstructorInitializer.Emit): Simplified.
7637 * delegate.cs: Updated after Invocation.EmitCall change.
7639 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7640 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7641 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7642 method and don't permanently changing input arguments.
7643 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7644 is resolved it has one of the candidates is the best one which is later
7645 used to emit. Removed a few unused method.
7646 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7648 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7649 (Binary.ResolveOperator): Ditto.
7650 (ConditionalLogicalOperator.DoResolve): Ditto.
7651 (Invocation): Uses method group.
7652 (Invocation.DoResolve): Simplified.
7653 (Invocation.EmitCall): Removed useless is_static.
7654 (Invocation.Emit): Delegate to method group.
7655 (Invocation.EmitStatement): Simplified.
7656 (New): Uses method group.
7657 (MemberAccess.DoResolve): Don't destroy original expression.
7659 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7661 2007-07-04 Marek Safar <marek.safar@gmail.com>
7663 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7666 * lambda.cs: Add custom error message type.
7668 2007-07-03 Marek Safar <marek.safar@gmail.com>
7670 * lambda.cs: Simplified little bit.
7672 * parameter.cs: Introduced ImplicitLambdaParameter.
7673 (Parameters.CreateFullyResolved): New factory instead of ctor.
7677 * delegate.cs: Updated parameter creation.
7679 2007-07-03 Marek Safar <marek.safar@gmail.com>
7681 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7684 * generic.cs: Synchronized with gmcs.
7686 2007-07-03 Marek Safar <marek.safar@gmail.com>
7688 * class.cs (Indexer): Check return type as soon as possible.
7690 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7693 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7695 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7697 * parameter.cs (Parameter): Use expression type when it is available.
7699 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7700 method modifier for the first parameter only.
7702 2007-06-24 Marek Safar <marek.safar@gmail.com>
7704 A fix for bug #81938
7705 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7707 * constant.cs: Tide up an exception message.
7709 2007-06-22 Marek Safar <marek.safar@gmail.com>
7711 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7712 an uninitialized variable is used.
7714 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7716 2007-06-22 Marek Safar <marek.safar@gmail.com>
7718 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7719 not found error handling.
7721 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7723 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7724 (ArrayCreation.DoResolve): Simplified.
7725 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7726 its own resolve process.
7727 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7729 2007-06-20 Marek Safar <marek.safar@gmail.com>
7731 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7734 2007-06-20 Marek Safar <marek.safar@gmail.com>
7736 * cs-tokenizer.cs: Removed var related stuff.
7738 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7739 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7740 a type and a keyword at same time.
7742 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7745 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7746 implicitly typed arrays, more changes will follow.
7748 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7750 2007-06-19 Marek Safar <marek.safar@gmail.com>
7752 * ecore.cs (VarExpr): Removed Handled field.
7754 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7755 build-in assign functionality.
7756 (ForEach.Resolve): Removed all implicitly typed local variable code and
7758 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7759 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7761 2007-06-18 Marek Safar <marek.safar@gmail.com>
7763 * assign.cs: Removed implicitly typed local variable check.
7765 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7766 referencing implicitly typed local variable.
7767 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7770 * statement.cs (Fixed): Removed unsupported implicitly typed local
7773 2007-06-15 Marek Safar <marek.safar@gmail.com>
7775 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7777 2007-06-14 Marek Safar <marek.safar@gmail.com>
7779 A fix for bugs #81855 and #76274
7780 * attribute.cs (AttachTo): Always set owner for global attributes to
7783 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7786 * cs-parser.jay: Assembly and module attributes must precede all other
7787 elements except using clauses and extern alias declarations.
7789 2007-06-13 Marek Safar <marek.safar@gmail.com>
7791 A fix for bug #81748
7793 * expression.cs: More checks for non ISO-1 features.
7795 2007-06-12 Marek Safar <marek.safar@gmail.com>
7797 A fix for bug #81807
7798 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7799 present inside switch statement and it is required by nullable check.
7801 2007-06-12 Marek Safar <marek.safar@gmail.com>
7803 A fix for bug #81840
7804 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7805 when type matching fails.
7807 * namespace.cs: Tiny error message change.
7809 2007-06-12 Marek Safar <marek.safar@gmail.com>
7811 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7812 reporting. Added automatic property check.
7814 * class.cs: Updated after CheckAbstractAndExtern relocation.
7815 (AEventPropertyAccessor.GetSignatureForError): Customized.
7817 2007-06-11 Marek Safar <marek.safar@gmail.com>
7819 * class.cs (DefineBaseTypes): Base type can be undefined.
7821 * ecore.cs (TypeLookup): Minor refactoring.
7822 (DoResolveAsTypeStep): Removed redundant check.
7824 * namespace.cs (Lookup): Removed redundant check.
7826 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7827 ResolveAsTypeTerminal step.
7828 (BootstrapCorlib_*): Simplified.
7829 (PopulateCoreType): Core types can be now external.
7831 2007-06-07 Marek Safar <marek.safar@gmail.com>
7833 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7835 (InferTypeArguments): Infers anonymous expression type arguments.
7836 (Compatible): Split to Compatible and InferTypeArguments.
7838 * lambda.cs: Updated.
7840 2007-06-08 Marek Safar <marek.safar@gmail.com>
7842 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7844 2007-06-07 Raja R Harinath <harinath@gmail.com>
7846 Fix #80477, cs0135-2.cs, cs0135-3.cs
7847 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7848 names to the "known" variables list.
7849 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7850 parameter names are also "known".
7851 (Block.CheckError136): Remove.
7852 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7855 2007-06-07 Marek Safar <marek.safar@gmail.com>
7857 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7859 2007-06-06 Marek Safar <marek.safar@gmail.com>
7861 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7862 internal error not an user error.
7864 * expression.cs (IsApplicable): Refactored to make debugging easier.
7866 * support.cs: More tricks for non-mono runtimes.
7868 * typemanager.cs (CoreLookupType): Made public.
7869 (InitSystemCore): All linq specific stuff moved to linq.cs
7871 2007-06-05 Marek Safar <marek.safar@gmail.com>
7873 * typemanager.cs (CSharpSignature): One more missing build-in types
7875 More tricks for non-mono runtime.
7877 2007-06-05 Raja R Harinath <harinath@gmail.com>
7879 * statement.cs (Block.CheckError136_InParents): Remove.
7880 (Block.AddVariable): Use GetParameterInfo instead.
7881 (ToplevelBlock.ProcessArguments): Likewise.
7883 2007-06-04 Raja R Harinath <rharinath@novell.com>
7885 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7887 (ToplevelBlock.GetParameterInfo): Split out of ...
7888 (ToplevelBlock.GetParameterRefernce): ... this.
7889 (ToplevelBlock.ParameterMap): Remove.
7890 * expression.cs (ParameterReference): Update to use
7891 ToplevelParameterInfo.
7893 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7896 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7897 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7899 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7900 (ToplevelBlock.ProcessParameters) ... here.
7901 (ToplevelBlock..ctor): Invoke it.
7903 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7906 * statement.cs (IKnownVariable): New interface.
7907 (LocalInfo): Implement it.
7908 (ToplevelParameterInfo): New class.
7909 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7910 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7911 GetKnownVariableInfo.
7913 2007-06-03 Raja R Harinath <harinath@gmail.com>
7915 Partly speed up CS0136 error checks.
7916 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7917 'recurse' parameter.
7918 (Block.DoCheckError136): Only check errors in parameters. Move
7919 local variable checks ...
7920 (Block.AddVariable): ... here, and ...
7921 (ToplevelBlock.ResolveMeta): ... here.
7923 2007-06-02 Raja R Harinath <harinath@gmail.com>
7925 * statement.cs (Block.IsChildOf): Remove.
7927 * statement.cs (Statement.Clone): Move special case code ...
7928 (Block.CloneTo): ... here.
7930 2007-05-29 Raja R Harinath <rharinath@novell.com>
7932 * statement.cs (ToplevelBlock.container): Remove field. It's
7933 redundant with 'Parent'.
7934 (ToplevelBlock.ContainerBlock): Remove accessor.
7935 (ToplevelBlock..ctor): Update to changes. Register anonymous
7936 child with parent here, ...
7937 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7939 (start_anonymous): Don't save current_block.
7940 (top_current_block): Remove.
7942 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7943 (Block.Resolve): Update to changes.
7944 (Block..ctor): Move setting of "correct" 'Toplevel'
7945 and 'Explicit' fields to ...
7946 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7948 2007-05-27 Raja R Harinath <harinath@gmail.com>
7951 * statement.cs (Block.Implicit): Remove.
7952 (Block): Update to changes.
7953 * flowanalysis.cs: Likewise.
7955 Mildly speed up CheckInvariantMeaningInBlock
7956 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7957 Recursively call AddKnownVariable to all enclosing blocks.
7958 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7959 Remove recursive calls.
7960 (Block): Update to changes.
7962 New ExplicitBlock invariants
7963 * statement.cs (Block.Explicit): New field. It points to the
7964 immediately enclosing non-implicit block.
7965 (Block..ctor): Maintain the invariant.
7966 * cs-parser.jay: Take advantage of invariant.
7968 Introduce ExplicitBlock
7969 * statement.cs (ExplicitBlock): New.
7970 (ToplevelBlock): Derive from it.
7971 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7973 (Block.Implicit): Update to changes.
7974 * cs-parser.jay: Update to changes.
7977 * codegen.cs (EmitContext.IsLastStatement): Remove.
7978 * statement.cs (Block.DoEmit): Update to changes.
7980 2007-05-25 Raja R Harinath <rharinath@novell.com>
7982 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7983 modifying current_block directly.
7985 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7987 * class.cs: Implemented automatic properties (C# 3.0)
7988 Thanks to Marek for the help.
7990 2007-05-23 Raja R Harinath <rharinath@novell.com>
7992 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7993 variable as assigned, note also that all its components are
7995 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7997 2007-05-19 Marek Safar <marek.safar@gmail.com>
7999 * anonymous.cs, class.cs: Emit Compiler generated attribute when
8000 member is marked as compiler generated.
8002 * decl.cs (MemberCore): Refactored ModFlags into property.
8004 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
8005 (Check): Check only accessibility modifiers.
8007 2007-05-18 Raja R Harinath <rharinath@novell.com>
8009 Track all assignable slots in one bit array
8010 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
8011 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
8012 logic from VariableMap constructor here. Use the same 'offset'
8013 variable that's later used for computing offsets of local
8015 * flowanalysis.cs (UsageVector.parameters): Remove.
8016 (UsageVector): Update to changes.
8017 (VariableMap): Remove.
8019 Avoid creating ParameterMap in every block
8020 * statement.cs (Block.ParameterMap): Move ...
8021 (ToplevelBlock.ParameterMap): ... here.
8022 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
8024 * flowanalysis.cs (FlowBranching.param_map): Remove.
8025 (FlowBranching.UsageVector): Update to changes.
8026 (FlowBranchingToplevel.CheckOutParameters): Likewise.
8028 * statement.cs (Block.CloneTo): Clone Toplevel field too.
8030 * expression.cs (ParameterReference): Distinguish between block
8031 where parameter was referenced and declared.
8033 2007-05-18 Marek Safar <marek.safar@gmail.com>
8035 * flowanalysis.cs, statement.cs: Put back improved error handling.
8037 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
8041 Imporved object and collection initialization (C# 3.0).
8043 2007-05-15 Marek Safar <marek.safar@gmail.com>
8045 A fix for bug #81380
8046 * expression.cs (Is.DoResolve): Only value types have constant `is'
8049 2007-05-15 Raja R Harinath <rharinath@novell.com>
8051 * statement.cs (ToplevelBlock.child): Remove.
8053 2007-05-15 Raja R Harinath <harinath@gmail.com>
8055 Rationalize ResolveMeta: refactoring
8056 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8057 out constant handling code into ...
8058 (Block.DoResolveConstants): ... this.
8060 Rationalize ResolveMeta: kill local_map
8061 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8062 (Block.AssignableSlots): New.
8063 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8064 for locals -- move code from VariableMap here. Avoid unnecessary
8066 * flowanalysis.cs (FlowBranching.local_map): Remove.
8067 (FlowBranching..ctor): Use Block.AssignableSlots.
8068 (VariableMap): Remove unused constructors.
8070 2007-05-11 Raja R Harinath <rharinath@novell.com>
8072 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8074 2007-05-11 Marek Safar <marek.safar@gmail.com>
8076 * typemanager.cs (IsFriendAssembly): Should not be called for building
8079 2007-05-09 Marek Safar <marek.safar@gmail.com>
8081 * literal.cs (NullConstant): Print null in all cases.
8083 * expression.cs (Binary.ResolveOperator): Implemented delegate
8084 comparison based on C# 2.0 changes.
8086 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8088 This code is contributed under the MIT X11 license
8090 The following enables support for several C# 3.0 language features:
8092 * cs-tokenizer.cs: Added support for the "var" keyword.
8094 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8095 Added VarExpr class to facilitate type inferencing.
8097 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8098 to support anonymous types.
8100 * assign.cs: Added support for type inferencing and initialization.
8102 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8104 * expression.cs: Added implicit array support to ArrayCreation.
8105 Added 5 types and 1 interface:
8107 IInitializable Implementing classes can inject initializing
8108 statements after object instantiation.
8110 Initializer Stores data for object initialization.
8112 AnonymousType An expression for anonymous types.
8114 AnonymousTypeParameter Stores data about an anonymous type's field.
8116 NewInitialize An expression for object initialization.
8118 CollectionInitialize An expression for collection initialization.
8120 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8123 2007-05-06 Marek Safar <marek.safar@gmail.com>
8125 A fix for bug #81500
8126 * cs-tokenizer.cs: Add special handling for coalescing operator.
8128 2007-05-06 Marek Safar <marek.safar@gmail.com>
8130 A fix for bug #81529
8131 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8132 its value from base class until it is redefined.
8134 2007-05-02 Raja R Harinath <rharinath@novell.com>
8136 Fix regression in cs0631-3.cs
8137 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8138 fallback. Make error fallback catch more cases.
8140 2007-05-01 Miguel de Icaza <miguel@novell.com>
8142 * cs-parser.jay: Allow parameters in operator declarations to have
8145 2007-04-27 Miguel de Icaza <miguel@novell.com>
8147 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8150 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8151 inside the ContextualReturn, it does not have to be an
8152 ExpressionStatement.
8154 2007-04-24 Miguel de Icaza <miguel@novell.com>
8156 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8159 2007-04-23 Miguel de Icaza <miguel@novell.com>
8161 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8162 method in two methods: ResolveNoDefine and Resolve.
8164 ResolveNoDefine will stop just after ResolveTopBlock has been
8167 Resolve will then continue by creating a method and issuing the
8168 call to method.Define ().
8170 (AnonymousMethod): Split and implement the new Resolve and
8171 ResolveNoDefine as well.
8173 * lambda.cs (LambdaExpression): Split the anonymous method
8174 resolution code into a separate routine (CoreCompatibilityTest)
8175 from DoCompatibleTest.
8177 (LambdaExpression.TryBuild): New method, this method tries to
8178 build the LambdaExpression with the given set of types to be used
8179 as the types for the various parameters of the lambda expression.
8181 If the compilation succeed with the given types, the infered type
8182 of the Anonymous method is returned, otherwise null is returned.
8184 2007-04-23 Marek Safar <marek.safar@gmail.com>
8186 A fix for bug #81414
8187 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8189 2007-04-22 Miguel de Icaza <miguel@novell.com>
8191 * cs-tokenizer.cs: Change various identifiers here from the
8192 camelCasing to the recommended Linux-like style for instance
8193 variables from the Coding Guidelines.
8195 2007-04-19 Martin Baulig <martin@ximian.com>
8198 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8199 System.Enum to System.ValueType.
8201 2007-04-13 Martin Baulig <martin@ximian.com>
8203 Rewrote implicit reference conversions. We need to distinguish
8204 between implicit reference conversions (13.1.4) and implicit
8205 boxing conversions (13.1.5).
8207 According to the spec, there's an an implicit conversion
8208 "From a one-dimensional array-type S[] to IList<T> and base
8209 interfaces of this interface, provided there is an implicit
8210 reference conversion from S to T." Note that this does not
8211 include boxing conversions.
8214 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8215 (Convert.ImplicitReferenceConversion): Split into
8216 ImplicitReferenceConversionCore() and
8217 ImplicitBoxingConversionExist().
8218 (Convert.ImplicitReferenceConversionExists): Use the new
8219 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8221 2007-04-12 Martin Baulig <martin@ximian.com>
8223 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8224 `TypeManager.null_type' checks up to the top of the method.
8226 2007-04-11 Marek Safar <marek.safar@gmail.com>
8228 A fix for bug #81350
8229 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8232 2007-04-11 Martin Baulig <martin@ximian.com>
8234 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8235 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8236 to make this work for generic classes; fixes #79561.
8238 2007-04-11 Martin Baulig <martin@ximian.com>
8240 * expression.cs (As): Add support for nullable types; fixes #79371.
8242 2007-04-11 Martin Baulig <martin@ximian.com>
8244 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8245 `type.FullName' is null; fixes #80243.
8247 2007-04-11 Martin Baulig <martin@ximian.com>
8249 * expression.cs (Invocation.IsApplicable): Don't modify the method
8250 if type inference succeeded, but the method was not applicable.
8253 2007-04-10 Marek Safar <marek.safar@gmail.com>
8255 A fix for bug #81324
8256 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8257 internal and external namespaces containers.
8259 2007-04-10 Martin Baulig <martin@ximian.com>
8261 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8262 TypeManager.DropGenericMethodArguments() so we also call
8263 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8265 2007-04-10 Martin Baulig <martin@ximian.com>
8267 * iterators.cs (Iterator.CreateIterator): Don't crash if
8268 `method.ReturnType' is null. This happens if something went wrong
8269 while resolving that typ (we already reported an error in this case).
8271 2007-04-10 Martin Baulig <martin@ximian.com>
8273 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8274 generic interfaces; report the CS0144 directly.
8276 2007-04-10 Martin Baulig <martin@ximian.com>
8278 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8279 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8281 2007-04-10 Martin Baulig <martin@ximian.com>
8283 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8285 2007-04-09 Raja R Harinath <rharinath@novell.com>
8288 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8289 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8292 * statement.cs (For.Resolve): If resolution fails, use
8295 2007-04-08 Marek Safar <marek.safar@gmail.com>
8297 * anonymous.cs (MakeName): Make faster and zero-based.
8298 (VerifyExplicitParameterCompatibility): Back to mode where generic
8299 parameter is ignored.
8300 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8302 * class.cs (EmitType): Method can emit another new method.
8304 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8306 * driver.cs: Updated.
8308 * lambda.cs: Reuse predefined empty parameters.
8310 * parameter.cs: Updated
8312 * support.cs: Implemented InflateTypes.
8314 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8315 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8317 2007-04-03 Martin Baulig <martin@ximian.com>
8321 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8322 version of TypeManager.IsOverride() which also works with generic
8325 2007-04-03 Martin Baulig <martin@ximian.com>
8330 (Convert.ExplicitReferenceConversion): We need to cast when
8331 converting from IList<T> to S[].
8333 2007-04-01 Marek Safar <marek.safar@gmail.com>
8335 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8338 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8340 2007-03-31 Marek Safar <marek.safar@gmail.com>
8342 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8343 argument and return type inferring.
8345 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8346 (ReturnType): Turned to property.
8348 * statement.cs (Return): Implemented return type inferring.
8350 * support.cs (ReflectionParameters): Use local types if possible.
8352 2007-03-30 Raja R Harinath <rharinath@novell.com>
8354 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8355 (FlowBranching.UsageVector): Update to changes.
8357 Prepare to kill 'Reachability'
8358 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8359 argument of constructor.
8361 2007-03-29 Raja R Harinath <rharinath@novell.com>
8363 Prepare to kill 'Reachability'
8364 * flowanalysis.cs (UsageVector.is_unreachable): New.
8365 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8366 'reachability', and verify they're consistent.
8369 * expression.cs (New.EmitStatement): Handle type parameters here too.
8371 2007-03-29 Martin Baulig <martin@ximian.com>
8376 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8377 CompilerGeneratedClass.
8378 (ScopeInfo.EmitScopeInstance): Make this protected.
8379 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8380 `ec.CurrentAnonymousMethod.Scope == Scope'.
8382 * statement.cs (Block.ScopeInfo): Make this a property.
8384 2007-03-27 Raja R Harinath <harinath@gmail.com>
8386 Prepare to kill 'Reachability'
8387 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8388 (FlowBranching.UsageVector.Reachability): Remove property.
8389 (FlowBranching.UsageVector.IsUnreachable): New property.
8390 (FlowBranching.UsageVector.ResetBarrier): New.
8391 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8392 * codegen.cs, statement.cs: Update to changes.
8394 2007-03-27 Martin Baulig <martin@ximian.com>
8399 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8402 2007-03-26 Raja R Harinath <rharinath@novell.com>
8404 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8405 instead of TriState. Remove all mention of TriState.
8407 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8408 replaced by a boolean. Add boolean 'is_unreachable' field, check
8409 and maintain invariants.
8411 2007-03-25 Marek Safar <marek.safar@gmail.com>
8413 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8415 2007-03-25 Marek Safar <marek.safar@gmail.com>
8417 * expression.cs: Stop using obsolete 2.0 opcodes.
8419 2007-03-25 Marek Safar <marek.safar@gmail.com>
8421 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8422 one of the latests Martin's fixes.
8424 2007-03-23 Miguel de Icaza <miguel@novell.com>
8426 * expression.cs: On BigEndian systems, swap the bytes, temporary
8427 solution until we get a new bitconverter class.
8429 2007-03-23 Martin Baulig <martin@ximian.com>
8433 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8434 "Method" and "Method`1". Normally, a cache lookup is done on the
8435 "Method" form (ie. without the generic arity), but this one makes
8436 lookups on the full form work as well.
8438 2007-03-22 Raja R Harinath <rharinath@novell.com>
8440 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8443 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8445 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8446 ordered_member_list, to TypeBuilder to store members to be defined
8447 in the order they were parsed in.
8448 - ordered_explicit_member_list contains all properties indexers
8449 and methods that are defined as explicit implementation of an
8450 interface or base class.
8451 - ordered_member_list contains all properties indexers and methods
8452 that are not defined as explicit implementation of an interface
8455 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8456 functionality in these removed classes has been replaced with
8457 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8458 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8460 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8461 to CheckForDuplications inside GetMethod and SetMethod Define Method
8462 to handle method property and indexer name conflicts.
8466 All code is contributed under the MIT/X11 license.
8468 2007-03-20 Martin Baulig <martin@ximian.com>
8470 * class.cs (TypeContainer.Interfaces): Removed; they're now
8471 included in `TypeContainer.Types'.
8473 2007-03-20 Martin Baulig <martin@ximian.com>
8475 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8477 * class.cs (TypeContainer.CreateType): New public method. This is
8478 now called before DefineType() to create the TypeBuilders.
8479 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8480 has already been created by CreateType().
8481 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8482 don't resolve our base classes here; this has been moved into
8483 DefineBaseTypes(). We're now called from CreateType().
8484 (TypeContainer.DefineBaseTypes): New private method; resolve our
8485 base classes here. We're now called from DefineType().
8488 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8489 our types first to create all the TypeBuilders. After that, call
8490 TypeContainer.DefineType() on all the types which'll resolve their
8491 base classes and setup the resolve order.
8493 2007-03-20 Martin Baulig <martin@ximian.com>
8495 * class.cs (TypeContainer.Enums): Removed; they're now included in
8496 `TypeContainer.Types'.
8498 2007-03-20 Martin Baulig <martin@ximian.com>
8501 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8502 (TypeContainer.DoResolveMembers): Call DefineType() on our
8503 `compiler_generated' classes; moved here from DefineNestedTypes().
8506 (RootContext.ResolveTree): Call ResolveMembers() on all
8507 TypeContainer's in the `type_container_resolve_order'.
8509 2007-03-19 Marek Safar <marek.safar@gmail.com>
8511 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8513 2007-03-17 Marek Safar <marek.safar@gmail.com>
8515 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8516 implementation flags.
8518 2007-03-17 Marek Safar <marek.safar@gmail.com>
8520 * class.cs: More optimizations for type parameters.
8522 2007-03-15 Marek Safar <marek.safar@gmail.com>
8524 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8526 * ecore.cs, parameter.cs: More common code for both corlibs.
8528 * typemanager.cs (IsGenericMethod): Simplified.
8530 2007-03-15 Raja R Harinath <rharinath@novell.com>
8532 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8534 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8536 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8537 unconditionally. Simplify explanation.
8538 (Try.Resolve, Using.Resolve): Likewise.
8540 2007-03-15 Martin Baulig <martin@ximian.com>
8544 * decl.cs (DeclSpace): If we're a partial class, use our
8545 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8547 2007-03-15 Raja R Harinath <rharinath@novell.com>
8549 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8551 (FlowBranching.UsageVector): Update to changes.
8552 (FlowBranching.MergeSiblings): Likewise.
8553 * statement.cs: Likewise.
8555 2007-03-15 Martin Baulig <martin@ximian.com>
8560 (MemberCache): Added a special .ctor for type parameters.
8563 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8566 2007-03-09 Martin Baulig <martin@ximian.com>
8568 * enum.cs (Enum): Make this a TypeContainer.
8569 (EnumMember): Derive from `Const'.
8572 (Const.DoResolveValue): New protected virtual method; move most of
8573 the functionality of ResolveValue() here so we can override it in
8575 (Const.CreateConstantReference): Make this virtual.
8577 * class.cs (Kind): Add `Kind.Enum'.
8578 (TypeContainer.Emit): Don't emit the enums here; they're already
8579 in the `RootContext.typecontainer_resolve_order'.
8581 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8582 here; they're already in the `typecontainer_resolve_order'.
8584 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8585 TypeManager.DropGenericTypeArguments().
8588 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8589 (TypeManager.IsEnumType): Likewise.
8590 (TypeManager.EnumToUnderlying): Likewise.
8591 (TypeManager.IsEqual): Add support for enums.
8593 2007-03-12 Raja R Harinath <rharinath@novell.com>
8595 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8596 DefaultParameterValueAttribute to be undefined, say if System.dll
8599 2007-03-11 Marek Safar <marek.safar@gmail.com>
8601 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8604 2007-03-10 Marek Safar <marek.safar@gmail.com>
8606 * class.cs, parameter.cs: Unified parameters verification.
8608 2007-03-08 Martin Baulig <martin@ximian.com>
8610 * cs-parser.jay (constructor_header): Pass the location to the
8611 newly created TopLevelBlock.
8613 2007-03-07 Martin Baulig <martin@ximian.com>
8615 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8617 2007-03-06 Miguel de Icaza <miguel@novell.com>
8619 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8620 with the changes from David, fixes the build.
8622 2007-03-05 David Mitchell <dmitchell@logos.com>
8624 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8625 and its base interfaces to a one-dimensional array type S[],
8626 provided there is an implicit or explicit reference conversion
8629 2007-03-03 Marek Safar <marek.safar@gmail.com>
8631 * cs-tokenizer.cs: Implemented basic linq grammar.
8633 * driver.cs: Set linq lang version on demand.
8635 2007-02-26 Marek Safar <marek.safar@gmail.com>
8637 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8639 2007-02-25 Marek Safar <marek.safar@gmail.com>
8641 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8644 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8646 Check property and event extern attributes.
8648 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8651 2007-02-24 Marek Safar <marek.safar@gmail.com>
8653 A fix for bug #80407
8654 * ecore.cs: Don't report ambiguity error when methods have same parent.
8656 2007-02-23 Marek Safar <marek.safar@gmail.com>
8658 A fix for bug #80878
8659 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8661 2007-02-22 Marek Safar <marek.safar@gmail.com>
8663 * attribute.cs: Enable ExtensionAttribute presence test.
8665 2007-02-22 Marek Safar <marek.safar@gmail.com>
8667 * class.cs: Warn about missing GetHashCode only when Equals is override.
8669 * decl.cs: Check accessibility of type arguments.
8671 * typemanager.cs: Correctly report nullable array.
8673 2007-02-20 Marek Safar <marek.safar@gmail.com>
8675 * class.cs, report.cs: Capture more details when things go wrong.
8677 2007-02-20 Marek Safar <marek.safar@gmail.com>
8679 A fix for bug #80650
8680 * cs-parser.jay: Anonymous container starts at constructor declaration
8681 and not at block beginning because it has to be usable in constructor
8684 * statement.cs: Use context location and not block one for error reporting.
8686 2007-02-18 Marek Safar <marek.safar@gmail.com>
8688 A fix for bug #78712
8689 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8692 2007-02-18 Marek Safar <marek.safar@gmail.com>
8694 A fix for bug #80493 by Atsushi Enomoto
8695 * cs-parser.jay: Ignore invalid attribute target.
8697 2007-02-18 Marek Safar <marek.safar@gmail.com>
8699 * cs-tokenizer.cs: Ignore '\0' as white space character.
8701 2007-02-17 Miguel de Icaza <miguel@novell.com>
8703 * cs-parser.jay: Add support for lambda expressions to the mcs
8706 * lambda.cs: Only clone when we are probing, not on the final call
8707 (Compatible is the final call).
8709 * statement.cs (CloneContext): Introduce class to provide block
8710 remapping during clone.
8712 All statements Clone themselves now.
8714 (Clone): special handling for blocks, when we clone a block, we
8715 register the block inside this routine, as children of the block
8716 might trigger a lookup.
8718 * expression.cs: Add support for CloneContext in all expressions.
8720 2007-02-17 Marek Safar <marek.safar@gmail.com>
8722 A fix for bug #80493
8723 * statement.cs: Report ambiguous warning when interfaces are not related.
8725 2007-02-15 Marek Safar <marek.safar@gmail.com>
8727 C# 3.0 extension methods.
8729 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8730 cannot be used directly.
8732 * class.cs (Class.Emit): Emit extension attribute if any class method
8733 is extension method.
8734 (Method.Define): Add basic extension method validation conditions.
8735 (Method.Emit): Emit extension attribute for method.
8737 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8738 extension method exists. Currently we follow same approach as Microsoft
8739 does, emit even if a method or a class are private but this can change
8742 * cs-parser.jay: Add handling of `this' keyword in method parameters
8745 * decl.cs (DeclSpace.IsStaticClass): New property.
8746 (MemberCache.FindExtensionMethods): Looks for extension methods with
8747 defined name and extension type.
8749 * doc.cs: Updated after OverloadResolve changes.
8751 * driver.cs: Add new soft reference to System.Core.dll.
8753 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8754 (ExtensionMethodGroupExpr): Represents group of extension methods.
8756 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8757 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8758 to MethodGroupExpr and made non-static for easier customization.
8759 (Invocation.DoResolve): Add extension method lookup when no standard
8761 (MemberAccess.DoResolve): Try extension methods if no member exists.
8763 * modifiers.cs: Add METHOD_EXTENSION modifier.
8765 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8766 as well as candidate extension type.
8767 (ComputeNamespaces): When assembly constains extension methods registers
8769 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8770 extension method lookup.
8771 (Namespace.LookupExtensionMethod): Looks for extension method in this
8773 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8774 find a method which matches name and extensionType.
8776 * parameter.cs (Parameter): Add This modifer.
8777 (HasExtensionMethodModifier): New property.
8778 (Resolve): Add extension parameter check.
8779 (ModFlags): turned to property to exclude this modifier as it is not real
8781 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8783 * support.cs (ParameterData): Add ExtensionMethodType.
8784 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8786 * typemanager.cs: Add type and ctor extension attribute type.
8788 2007-02-15 Miguel de Icaza <miguel@novell.com>
8790 * report.cs (DisableErrors, EnableErrors): used to prevent error
8791 output when we are "trying" to compile various methods with
8794 * ecore.cs (Expression): Add Clone method that calls the virtual
8795 CloneTo method. The current CloneTo method in Expression throws
8796 an exception so we can track down all the places where this must
8797 be implemented (not using abstract, because that would be a lot of
8798 up-front-work before we can start testing the implementation
8801 Important: we only need Clone capabilities for expressions created
8802 by the parser, as the expressions we will be cloning are
8803 expressions in the pre-resolved state. This vastly simplifies
8806 (SimpleName): Add CloneTo that does nothing.
8807 (EmptyCast): Add CloneTo.
8809 * expression.cs (Binary): Implement CloneTo.
8810 (Invocation.IsApplicable): Store the current ec in
8811 EmitContext.TempEc and restore it on return. This is used so we
8812 do not have to sprinkle hundres of methods with an extra
8813 EmitContext, we know that the only user is the lambda expression
8814 ImplicitConversionExists code.
8816 (Argument): Add Cloning capabilities.
8817 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8818 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8819 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8820 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8821 IndexerAccess): Add Clone capability.
8823 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8825 (Argument): Add cloning capability.
8827 * assign.cs (Assign): Implement CloneTo.
8829 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8831 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8832 version by calling Convert with the EmitContext (that we are
8833 currently storing in ec, this is not great, but will do for now,
8834 to avoid passing EmitContext parameters to hundreds of functions
8835 that do not need them now).
8837 (SetExpression): Remove, it is not needed.
8839 (ContextualReturn): Implement CloneTo.
8841 * statement.cs (Statement): Implement cloning infrastructure,
8842 similar to expressions.
8844 (Block): Partial implementation of Clone for statements.
8846 (Return): Implement clone.
8848 * constant.cs (Constant.CloneTo): New method, does nothing.
8850 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8851 solution, until we decide how to exactly do this.
8853 2007-02-14 Marek Safar <marek.safar@gmail.com>
8855 A fix for bug #80493
8856 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8857 a property is override we need to use second accessor.
8859 2007-02-13 Marek Safar <marek.safar@gmail.com>
8861 A fix for bug #80418
8862 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8865 2007-02-13 Marek Safar <marek.safar@gmail.com>
8867 Another fix for bug #80749
8868 * pending.cs: Abstract class has priority over interfaces.
8870 2007-02-13 Marek Safar <marek.safar@gmail.com>
8872 Another fix for bug #80749
8873 * pending.cs: Abstract class has priority over interfaces.
8875 2007-02-13 Marek Safar <marek.safar@gmail.com>
8877 Another fix for bug #80749
8878 * pending.cs: Abstract class has priority over interfaces.
8880 2007-02-13 Marek Safar <marek.safar@gmail.com>
8882 Another fix for bug #80749
8883 * pending.cs: Abstract class has priority over interfaces.
8885 2007-02-13 Marek Safar <marek.safar@gmail.com>
8887 * class.cs Better error message.
8889 * driver.cs: Add shorter versions of -optimize option.
8891 2007-02-13 Martin Baulig <martin@ximian.com>
8893 * class.cs (Constructor.Emit): Check the return value of
8894 ec.ResolveTopBlock() and return on error.
8896 2007-02-13 Raja R Harinath <rharinath@novell.com>
8898 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8899 message to fix error message regression.
8901 2007-02-12 Marek Safar <marek.safar@gmail.com>
8903 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8905 2007-02-12 Marek Safar <marek.safar@gmail.com>
8907 A fix for bug #80749
8908 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8909 its parent container.
8911 * class.cs (DefineFieldInitializers): Each initializer can has different
8914 * const.cs: Updated.
8916 2007-02-11 Miguel de Icaza <miguel@novell.com>
8918 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8919 now all the heavy lifting to check that embedded statements or
8920 expressions have the right form is done in the ContextualReturn.
8922 (ContextualReturn): New class.
8924 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8925 method that can be invoked to report 201, so we do not replicate
8928 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8930 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8931 treating tabs as spaces.
8933 2007-02-09 Marek Safar <marek.safar@gmail.com>
8935 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8936 * assign.cs: Use full implicit conversion for right side check.
8938 2007-02-09 Marek Safar <marek.safar@gmail.com>
8940 * statement.cs (Switch): Switch over boolean type is not standardized.
8942 2007-02-08 Marek Safar <marek.safar@gmail.com>
8944 A fix for bug #80755
8945 * decl.cs (FindBaseEvent): Don't use method cache for events.
8947 2007-02-07 Marek Safar <marek.safar@gmail.com>
8949 * cs-parser.jay: Better syntax error handling.
8951 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8952 instead of underlying type value.
8954 2007-02-06 Marek Safar <marek.safar@gmail.com>
8956 * driver.cs: Check define identifier before is registered.
8958 * namespace.cs: Use existing error message.
8960 * report.cs: New warning.
8962 2007-02-06 Marek Safar <marek.safar@gmail.com>
8964 A fix for bug #80742
8965 * expression.cs: Delegate Invoke method can be called directly.
8967 2007-02-06 Marek Safar <marek.safar@gmail.com>
8969 A fix for bug #80676
8970 * class.cs (IsEntryPoint): The Main method can have params modifier.
8972 2007-02-04 Miguel de Icaza <miguel@novell.com>
8974 * parameter.cs (Parameter, Parameters): Add Clone method.
8976 * anonymous.cs (Compatible): Turn method into virtual method, so
8977 LambdaExpression can implement a different behavior.
8979 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8980 out the basic checking here, so it can be used by
8983 * lambda.cs: Introduce "Compatible" function that will do the
8986 2007-02-02 Marek Safar <marek.safar@gmail.com>
8988 * attribute.cs: Unified one error message.
8990 * class.cs (Class): Use type attributes and not properties to test static
8992 (IsEntryPoint): Don's pass local variable.
8994 * convert.cs: Removed duplicate check.
8996 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8998 * driver.cs: Don't crash when soft reference does not exist.
9000 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
9001 (UsingEntry): Removed redundant allocation.
9003 * parameter.cs: Add fast path for type parameters.
9005 * support.cs: Don't allocate attribute when it's not used.
9007 2007-01-30 Miguel de Icaza <miguel@novell.com>
9010 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
9011 this into a virtual method, so we can override it in LambdaExpression.
9013 * driver.cs: Improve diagnostics in case of failure.
9015 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
9016 write a function that is slightly more complex and that parses:
9018 type identifier [, type identifier]* )
9020 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
9023 (canEmpty ? i >= 0 : i > 0)
9025 2007-01-30 Raja R Harinath <rharinath@novell.com>
9027 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
9028 exception on possibly valid code.
9030 2007-01-29 Raja R Harinath <rharinath@novell.com>
9032 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
9034 (parse_opt_type_arguments): Remove. It's almost the same as
9036 (parse_namespace_or_typename): Use parse_less_than.
9038 2007-01-28 Miguel de Icaza <miguel@novell.com>
9040 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
9041 this bug took a few hours to find, because the state saved and
9042 restored by PushPosition and PopPosition was ignoring the state of
9043 parse_generic_less_than.
9045 I can also now remove the handling of OP_LT and OP_GT, this solves
9048 * cs-tokenizer.cs: store the location for the ARROW token, we use
9051 (PushPosition, PopPosition): save/restore also `current_token',
9052 restore `parse_generic_less_than' (was missing).
9054 (parse_opt_type_arguments): use parse_type, not
9055 parse_namespace_or_typename to parse types.
9057 * lambda.cs: Empty new file, will eventually have the lambda
9058 expression implementation.
9060 * lambda.test: used to test the internal tokenizer.
9062 * report.cs (FeatureIsNotISO1): Rename from
9063 FeatureIsNotStandardized, because it was about the language level
9064 (1 vs 2) it was not about standarization.
9066 (FeatureRequiresLINQ): New.
9068 * support.cs (SeekableStreamReader): Only require that the reader
9069 is a TextReader, not a StreamReader, so we can plug StringReader.
9071 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9072 given position in the input stream the following tokens can be
9073 parsed as a type followed by an identifier.
9075 (is_punct): after a '(' if parse_type_and_parameter returns true,
9076 then return a special token OPEN_PARENS_LAMBDA which is used to
9077 avoid reduce/reduce errors in the grammar for the
9078 lambda_expression rules.
9080 (parse_type): implement a type parser inside the
9081 tokenizer, the parser only returns true or false depending on
9082 whether the input at a given position can be parsed as a type.
9084 (peek_token): new method used during type parsing.
9086 2007-01-28 Raja R Harinath <rharinath@novell.com>
9089 * anonymous.cs (ScopeInfo.InflateParameters): New.
9090 (AnonymousContainer.Resolve): Use it to redirect types of
9091 delegate parameters.
9093 2007-01-27 Raja R Harinath <rharinath@novell.com>
9096 * expression.cs (Error_InvalidArguments): Don't use two different
9097 messages for CS1503. Use ExtraInformation and
9098 SymbolRelatedToPreviousError instead.
9101 * decl.cs (DeclSpace.initialize_type_params): Don't access
9102 'type_params' of a partial class directly.
9104 2007-01-26 Miguel de Icaza <miguel@novell.com>
9106 * constant.cs: Removed a handful of out-of-range checks that were
9109 2007-01-25 Marek Safar <marek.safar@gmail.com>
9111 * expression.cs (CheckUselessComparison): Add additional check for char
9114 * namespace.cs: Fixed typo.
9116 2007-01-23 Miguel de Icaza <miguel@novell.com>
9118 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9119 gone, instead we inline the test, preventing the needless casts to
9120 longs, ulongs and doubles for the parameters, avoiding calls to
9121 methods that overchecked stuff, and instead inlined things
9124 2007-01-20 Marek Safar <marek.safar@gmail.com>
9126 * cs-parser.jay: Better parameter error handling.
9128 2007-01-17 Marek Safar <marek.safar@gmail.com>
9130 A fix for bug #80368, #80522
9131 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9132 whether array initializer contains constants only.
9133 (ArrayCreation.Emit): Use better formula to decide when
9134 are array initializers for static initialization.
9135 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9136 have to emit even constants otherwise they are pre-initialized.
9138 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9139 Raja R Harinath <rharinath@novell.com>
9141 Fix emit order of 'get' vs. 'set'.
9142 * support.cs (Accessors): New.
9143 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9144 Note the order in which accessors are declared in the source.
9145 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9146 Refactored from Property.Define and Indexer.Define.
9147 (PropertyBase.DefineAccessors): New helper that calls the above in
9148 appropriate order as noted by the parser.
9149 (Property.Define, Indexer.Define): Update to changes.
9150 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9152 2007-01-17 Raja R Harinath <rharinath@novell.com>
9154 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9155 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9156 there's an implicit conversion from the current type to the target
9157 type before converting the underlying constant.
9159 2007-01-16 Marek Safar <marek.safar@gmail.com>
9161 * const.cs (ResolveValue): Updated after constant conversion was made more
9164 * constant.cs (GetAttributableValue): constant to object conversion is
9165 used for attributes only.
9166 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9167 constant conversions.
9168 (LongConstant.ConvertImplicitly): Ditto.
9170 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9171 (ImplicitConversionStandard): Handle constant conversion as extra step.
9172 It solves the issue when constant conversion was called indirectly like
9173 inside array initializer and constant folding was skipped.
9175 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9178 * statement.cs(ImplicitConversionStandard): Updated after constant
9179 conversion was made more generic.
9181 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9183 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9184 Constraints, solves the problem where the compiler incorrectly
9185 reported that a type parameter was not constrained to a class (Bug
9188 2007-01-14 Marek Habersack <grendello@gmail.com>
9190 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9192 2007-01-14 Marek Safar <marek.safar@gmail.com>
9194 A fix for bug #80368
9195 * assign.cs (FieldInitializer): New class implements field
9196 initializer statement.
9198 * attribute.cs: Update after FieldMember rename.
9200 * class.cs (PropertyBasedMember): New common class for property based
9202 (InterfaceMemberBase): New base class for all members which can be used as
9203 an interface members.
9204 (MethodCore): Moved really common code to InterfaceMemberBase.
9205 (Method.Define): Equal and GetHasCode detection is relevant for methods
9207 (MethodData.Define): Don't assume that public event implements an
9208 interface automatically.
9209 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9211 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9212 (FieldMember): Merged with FieldBase.
9213 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9214 event extern modifier can be used.
9215 (EventField.EventFieldAccessor): Moved event field specific code here.
9216 (Event.AllowedModifiers): Even event can be extern.
9217 (Event.FindOutBaseMethod): New override specific to events.
9218 (Indexer.parameters): Reintroduce parameters because base class holds
9219 only properties common data.
9220 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9221 need do extra parameters check.
9223 * const.cs: Update after FieldMember rename.
9225 * decl.cs (MemberCache.FindBaseEvent): New method.
9227 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9228 to reflect that indexer is now derived from PropertyBased.
9230 * ecore.cs (GetMemberType): Made public.
9231 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9234 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9236 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9237 (RegisterEvent): Removed.
9238 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9239 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9241 2007-01-11 Raja R Harinath <rharinath@novell.com>
9244 * statement.cs (CollectionForeach.TryType): Prefer generic
9245 GetEnumerator over non-generic variant. Fix code to follow comments.
9247 2007-01-09 Raja R Harinath <rharinath@novell.com>
9250 * support.cs (ReflectionParameter): Don't use an invalid index on
9251 the generic parameter data.
9253 2007-01-08 Miguel de Icaza <miguel@novell.com>
9255 * driver.cs: Just add a tiny bit of infrastructure.
9257 2007-01-02 Marek Safar <marek.safar@gmail.com>
9259 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9260 where field type is struct from current assembly.
9262 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9265 2007-01-02 Marek Safar <marek.safar@gmail.com>
9267 A fix for bug #80381
9268 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9271 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9273 (Namespace.LookupType): Always use core types from corlib when speficied.
9275 * report.cs: A new warning.
9277 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9278 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9279 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9281 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9282 (InitCoreTypes): Set expression type of object_type and value_type
9283 immediately after lookup.
9285 2007-01-01 Miguel de Icaza <miguel@novell.com>
9287 * cs-tokenizer.cs: Accept Pc class characters (Connector
9288 Punctuation) as valid identifiers. Fixes #78259
9290 * expression.cs (Invocation.DoResolve): Moved the check for the
9291 use of `this' for doing method calls to the Invocation resolution
9292 step, after overload resolution has taken place instead of doing
9293 the check at the low-level `This.DoResolve' level.
9295 The `This.DoResolve'(appens before overload resolution, so it has
9296 no way of knowing if the method that will be called will be
9297 instace or static, triggering an erroneous report for cs0188 (Bug
9300 We now do the check for instance method invocations after we know
9301 what method will be called.
9303 (This.CheckThisUsage): Move the actual use of this structure
9304 checking into its own method and expose it.
9306 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9309 Exceptions: Null.ConvertImplicitly,
9310 Constant.ImplicitConversionRequired as there are too many call
9311 sites for passing the ec.
9313 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9314 EmitContext, if the value is null, then we do not try to provide
9315 the extra information from the error (If a userdefined conversion
9316 exists, as UserDefinedConversion requires a non null-EmitContext).
9320 2006-12-30 Raja R Harinath <rharinath@novell.com>
9322 * flowanalysis.cs (MyBitVector): Document some invariants.
9323 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9324 introduced below, and add a couple of others,
9326 2006-12-30 Marek Safar <marek.safar@gmail.com>
9328 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9329 GetPropertyFromAccessor and GetEventFromAccessor.
9331 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9332 overrides non-obsolete one.
9333 (Indexer.Define): Error message has been moved to the parser.
9335 * cs-parser.jay: Better syntax errors handling.
9337 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9338 when an invocation has no arguments.
9340 * ecore.cs: Removed not used caching.
9342 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9345 * report.cs: Add a new warning.
9347 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9349 * typemanager.cs (enumeration_type): Removed.
9350 (CSharpSignature): Reuses IsSpecialMethod.
9351 (IsEqual): Hack for MS BCL.
9352 (GetPropertyFromAccessor): New method.
9353 (GetEventFromAccessor): New method.
9354 (IsSpecialMethod): Fixed to handle more cases.
9356 2006-12-30 Marek Safar <marek.safar@gmail.com>
9358 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9359 Made white spaces array static.
9361 * ecore.cs (RemoveGenericArity): Optimized.
9363 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9365 (MyBitVector.initialize_vector): Simplified.
9367 2006-12-22 Miguel de Icaza <miguel@novell.com>
9369 * ecore.cs: Am not entirely happy with this hack, but it seems to
9370 address the issue in 80257 (a small test case for
9373 I set the MethodGroupExpr.Type to an internal compiler type
9374 (itself in this case) to force the resolution to take place. Why
9375 it does not take place with a null is beyond me.
9377 2006-12-20 Marek Safar <marek.safar@gmail.com>
9379 A fix for bug #80288
9380 * expression.cs (ResolveOperator): Consider user defined conversion for
9381 logical and operator too.
9382 (EmitBranchable): Optimization for logical and when full constant folding
9383 could not be applied but one operand is constant.
9385 2006-12-19 Marek Safar <marek.safar@gmail.com>
9387 * class.cs (GetClassBases): Write 5 times every day, will never use
9388 FullName for error reporting.
9390 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9392 2006-12-19 Martin Baulig <martin@ximian.com>
9394 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9395 the symbol file info here.
9397 2006-12-18 Marek Safar <marek.safar@gmail.com>
9399 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9400 of `elseif' is taking then following sections are not taking.
9401 Fixes an issue reported on mono mailing list.
9403 2006-12-18 Marek Safar <marek.safar@gmail.com>
9405 A fix for bug #80300
9406 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9407 a caller is not taking.
9409 2006-12-18 Raja R Harinath <rharinath@novell.com>
9411 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9412 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9413 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9414 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9415 * class.cs: Update to changes.
9417 2006-12-17 Marek Safar <marek.safar@gmail.com>
9419 A fix for bug #79934
9420 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9423 * class.cs (ResolveMembers): Register an iterator in current container and
9426 2006-12-16 Raja R Harinath <rharinath@novell.com>
9429 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9430 satisfy a params annotated parameter.
9432 2006-12-16 Marek Safar <marek.safar@gmail.com>
9434 A fix for bug #77014
9435 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9436 paramters correctly and not rely on hacks in Parameters class.
9437 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9439 (Invocation.VerifyArgumentsCompat): Ditto.
9440 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9443 * parameter.cs (HasParams): Don't assume that params is the last one.
9445 * support.cs (ReflectionParameters.ctor): Look for params attribute
9447 (ReflectionParameters.ParameterType): Removed hack when we returned last
9448 parameter for out of range parameters.
9449 (ParameterName, ParameterModifier): Ditto.
9451 2006-12-14 Marek Safar <marek.safar@gmail.com>
9453 A fix for bug #79987
9454 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9455 when assembly is not CLS compliant but type is. I have no idea why is this
9458 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9460 2006-12-13 Miguel de Icaza <miguel@novell.com>
9462 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9463 in struct constructors, they are basically no-ops.
9465 2006-12-12 Marek Safar <marek.safar@gmail.com>
9467 * cs-tokenizer.cs (Position): Save preprocessor status too.
9469 2006-12-12 Marek Safar <marek.safar@gmail.com>
9471 A fix for bug #77794
9472 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9474 2006-12-12 Marek Safar <marek.safar@gmail.com>
9476 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9478 (pp_expr): Report error for an invalid expression.
9479 (handle_preprocessing_directive): Simplified; add more error checking.
9481 2006-12-11 Marek Safar <marek.safar@gmail.com>
9483 A fix for bug #74939
9484 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9485 directives handling.
9487 2006-12-10 Marek Safar <marek.safar@gmail.com>
9489 A fix for bugs #80093, and #75984
9490 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9491 logic, it seems to me as it worked before "by coincidence".
9492 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9493 (cleanup): Enabled endif check.
9495 2006-12-09 Marek Safar <marek.safar@gmail.com>
9497 A fix for bug #80162
9498 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9499 enumerators are never ambiguous.
9501 2006-12-08 Raja R Harinath <rharinath@novell.com>
9504 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9506 2006-12-06 Marek Safar <marek.safar@gmail.com>
9508 A fix for bug #80144
9509 * class.cs (EventProperty.Define): Explicit implementation means
9510 that an even is used.
9512 2006-12-06 Marek Safar <marek.safar@gmail.com>
9514 Fixes the operators implementation (part II)
9516 * cfold.cs (DoConstantNumericPromotions): Renamed to
9517 DoBinaryNumericPromotions and simplified.
9518 (BinaryFold): Couple of conversion fixes; simplified.
9520 * constant.cs, ecore.cs, literal.cs
9521 (ToType): Renamed to ConvertImplicitly.
9522 (Reduce): Renamed to ConvertExplicitly.
9524 * class.cs, convert.cs: Updated.
9526 * expression.cs: TryReduce doesn't throw an exception.
9528 2006-12-01 Marek Safar <marek.safar@gmail.com>
9530 A fix for bug #80108
9531 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9534 2006-11-30 Marek Safar <marek.safar@gmail.com>
9536 Fixes unary operators implementation (part I)
9539 * cfold.cs (Error_CompileTimeOverflow): Made internal
9541 * const.cs (IConstant): Changed to use reference to constant and
9542 not constant itself.
9543 Updated IConstant implementations.
9545 * constant.cs (CreateConstant): New factory method.
9546 Updated IConstant implementation.
9548 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9550 * ecore.cs: Updated to use CreateConstantReference.
9552 * enum.cs: Reflects IConstant changes.
9554 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9556 * literal.cs (NullConstant): Change to be independently usable.
9558 2006-11-29 Martin Baulig <martin@ximian.com>
9560 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9561 we need to emit the scope initializer before calling the base .ctor.
9563 * anonymous.cs: Merged back from the new anonymous methods branch.
9564 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9566 * expression.cs (ParameterReference.DoResolveBase): Create a
9567 "normal" ScopeInfo when capturing parameters rather than using the
9568 root scope; this makes things work with anonymous methods having
9572 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9574 2006-11-22 Marek Safar <marek.safar@gmail.com>
9576 A fix for bug #79987
9577 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9578 check to a base class.
9579 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9580 only when assembly has missing attribute.
9581 * report.cs: Update.
9583 2006-11-21 Marek Safar <marek.safar@gmail.com>
9585 * cs-tokenizer.cs: Merged with gmcs version.
9587 2006-11-20 Marek Safar <marek.safar@gmail.com>
9590 * cs-parser.jay: Better error message when partial keyword is misplaced.
9592 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9594 A fix for bug #79810
9595 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9596 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9597 a RuntimeWrappedException by default.
9599 2006-11-18 Marek Safar <marek.safar@gmail.com>
9601 A fix for bug #79843
9602 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9604 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9606 2006-11-18 Marek Safar <marek.safar@gmail.com>
9608 * driver.cs, namespace.cs: Uses faster IndexOf version.
9610 2006-11-17 Marek Safar <marek.safar@gmail.com>
9612 A fix for bug #79941
9613 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9615 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9616 even if internal name is different.
9617 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9618 (UserDefinedConversion): Simplified as the operators cannot be internal.
9619 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9621 (MethodLookup): Replaced EmitContext with parentType.
9622 * expression.cs: Updated.
9624 2006-11-09 Raja R Harinath <rharinath@novell.com>
9626 * driver.cs (BadAssembly): Handle all the ugliness of
9627 DefineDynamicAssembly.
9629 2006-11-08 Raja R Harinath <rharinath@novell.com>
9631 Address parts of #58244 -- most of what's left is in the runtime
9632 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9633 CS1509 error checks, and handle them for all assembly loads, not
9634 just the first invocation.
9635 (LoadModule): Likewise. Move handling of 'adder_method' ...
9636 * codegen.cs (AssemblyClass.AddModule): ... here.
9638 2006-11-02 Marek Safar <marek.safar@gmail.com>
9640 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9641 IEnumerable<T> is ambiguous.
9643 2006-10-31 Marek Safar <marek.safar@gmail.com>
9645 A fix for bug #67689
9646 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9647 GetEnumerator is ambiguous.
9649 * report.cs: Add new warning.
9651 2006-10-29 Marek Safar <marek.safar@gmail.com>
9653 A fix for bug #78602
9654 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9655 to protected member can be nested type.
9657 2006-10-28 Marek Safar <marek.safar@gmail.com>
9659 A fix for bug #78965
9660 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9661 to protected member must derive from current type.
9663 2006-10-27 Marek Safar <marek.safar@gmail.com>
9665 assign.cs: Reuses error method.
9667 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9668 instead of type for constants.
9669 (Expression.Error_ValueAssignment): Common error method.
9671 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9674 2006-10-27 Marek Safar <marek.safar@gmail.com>
9676 A fix for bug #79081
9677 * expression.cs (MemberAccess.DoResolve): Check nested type
9680 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9682 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9684 2006-10-26 Marek Safar <marek.safar@gmail.com>
9686 A fix for bug #76591
9687 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9689 2006-10-26 Marek Safar <marek.safar@gmail.com>
9691 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9692 type forwarder of the same type multiple times.
9694 2006-10-26 Raja R Harinath <rharinath@novell.com>
9697 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9698 instance as an rvalue, even when we later resolve as an lvalue.
9700 2006-10-25 Martin Baulig <martin@ximian.com>
9702 * anonymous.cs: Fix #79673.
9704 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9706 A fix for bug #79666
9707 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9708 ignored when is optimized (= default value) as its value is already set.
9710 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9712 A fix for bug #79724
9713 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9714 TypeContainer for type lookup.
9716 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9718 A fix for bug #79231
9719 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9720 * expression.cs (OverloadResolve): Always convert type name for
9722 (ResolveNamespaceOrType): Don't confuse a nested type with any
9725 2006-10-18 Martin Baulig <martin@ximian.com>
9727 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9729 2006-10-17 Miguel de Icaza <miguel@novell.com>
9731 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9732 an int32, but requesting an int64 from the conversion
9734 2006-10-12 Martin Baulig <martin@ximian.com>
9737 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9739 2006-10-12 Martin Baulig <martin@ximian.com>
9742 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9744 2006-10-11 Miguel de Icaza <miguel@novell.com>
9746 * convert.cs: Remove broken code: I was doing the "Existance"
9747 tests for Implicit conversions.
9749 2006-10-10 Miguel de Icaza <miguel@novell.com>
9751 * convert.cs: Added one missing case in
9752 ImplicitStandardConversionExists uint64 to intptr.
9756 * typemanager.cs (uintptr_type): another core known type.
9758 * ecore.cs (OperatorCast): routine used to do cast operations that
9759 depend on op_Explicit. We could change some of the Decimal
9760 conversions to use this.
9762 This one has a probe mechanism that checks both types for an op_
9763 which it coudl be used to eliminate two classes: CastToDecimal
9764 and CastFromDecimal.
9766 * convert.cs: Implement the conversions documented in #59800
9768 2006-10-10 Martin Baulig <martin@ximian.com>
9770 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9771 before RootScope.ResolveMembers().
9773 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9774 `CurrentType' if appropriate.
9776 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9778 A fix for bug #78568
9779 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9780 when contains binary operators.
9781 * cs-parser.jay: Updated.
9783 2006-10-09 Martin Baulig <martin@ximian.com>
9786 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9787 moved that into Define() and also do the other type parameter
9788 checks there. Fixes #79094. Added gtest-292.cs.
9791 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9792 since that doesn't include type parameters; don't use `Ldelema'
9793 for type parameters. Fixes #78980. Added gtest-293.cs.
9795 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9798 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9799 conversion is allowed.
9801 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9803 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9804 error reporting when no error occurs.
9806 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9808 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9811 2006-10-06 Raja R Harinath <rharinath@novell.com>
9814 * class.cs (DefineTypeBuilder): Check circular dependencies before
9815 setting the parent of the TypeBuilder.
9816 (CheckRecursiveDefinition): Don't use 'BaseType', since
9817 it may not be valid until after DefineTypeBuilder. Use
9818 'base_type' instead.
9820 2006-10-04 Martin Baulig <martin@ximian.com>
9822 Merged the Anonymous Methods patch.
9824 * anonymous.cs, iterators.cs: The new anonymous methods code.
9826 * statement.cs (Variable): New public abstract class.
9827 (LocalInfo.Variable): New public property.
9828 (LocalInfo.ResolveVariable): New public method.
9829 (Block.Flags): Add `IsIterator'.
9830 (Block.AddVariable): Improved the CS0136 check.
9831 (Block.AnonymousChildren): New public property.
9832 (Block.AddAnonymousChild): New public method.
9833 (ToplevelBlock): Update to use the new anonymous method framework.
9834 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9835 `ToplevelBlock'; this is required to correctly implement the
9837 (Fixed, Using): Use `TemporaryVariable' instead of directly
9838 creating the `LocalBuilder'.
9840 * parameter.cs (Parameter.ResolveVariable): New public method.
9841 (Parameters.ResolveVariable): Likewise.
9843 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9845 * class.cs (TypeContainer): Replaced the `iterators' list and
9846 corresponding methods with a list of `CompilerGeneratedClass'es.
9847 (TypeContainer.ResolveMembers): New public method.
9848 (Method): `IIteratorContainer' has been replaced by
9851 * expression.cs (VariableReference): New public abstract base
9852 class for `LocalVariableReference', `ParameterReference' and
9855 * codegen.cs (EmitContext): Removed `capture_context',
9856 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9857 (EmitContext.EmitThis): Removed.
9859 * cs-parser.jay: Replace `iterator_container' with
9862 2006-10-04 Martin Baulig <martin@ximian.com>
9864 * generic.cs (GenericMethod): Don't make this abstract.
9865 (Constraints.Clone): Added dummy implementation.
9867 2006-10-04 Raja R Harinath <harinath@gmail.com>
9870 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9871 'declspaces'. Avoid allocating arrays willy-nilly.
9874 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9875 cases out of the switch.
9877 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9879 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9880 message when non-generic type is used with the type arguments.
9881 * expression.cs: Updated.
9883 2006-09-28 Raja R Harinath <rharinath@novell.com>
9886 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9887 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9888 Change semantics slightly. Don't insist on having only one
9889 temporary EmptyExpression -- just throttle the creation of new ones.
9892 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9893 non-interfaces too. If no methods are found, don't try to create
9896 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9898 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9901 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9902 us produce better error message.
9904 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9906 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9907 of the `|' operator.
9909 * report.cs: A new warning added.
9911 2006-09-27 Martin Baulig <martin@ximian.com>
9913 * generic.cs (GenericMethod): Don't make this abstract.
9915 2006-09-27 Martin Baulig <martin@ximian.com>
9918 (InternalErrorException): Added overloaded ctor taking a params array.
9920 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9922 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9923 Fixed the cases when same error was reported twice.
9925 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9926 now report symbol information.
9928 2006-09-25 Martin Baulig <martin@ximian.com>
9930 * class.cs: Completely unified with the gmcs version.
9932 2006-09-25 Martin Baulig <martin@ximian.com>
9934 * typemanager.cs (TypeManager.IsNullableType): New public function.
9935 (TypeManager.IsNullableTypeOf): Likewise.
9936 (TypeManager.IsNullableValueType): Likewise.
9938 * class.cs (MethodCore): Added the `GenericMethod' argument from
9939 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9941 2006-09-24 Raja R Harinath <harinath@gmail.com>
9943 * convert.cs: Unify with gmcs version.
9945 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9947 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9948 verify them as well.
9950 * report.cs: New warning.
9952 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9954 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9955 for anonymous block with out argument.
9957 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9959 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9960 not used private events only.
9962 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9964 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9966 * const.cs (Const.Define): Check for constant type.
9967 (Const.IsConstantTypeValid): Looks for valid constant types.
9969 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9971 * ecore.cs (EmptyConstantCast): New common class for all constant based
9974 * expression.cs (Is.DoResolve): Handle null constant especially.
9975 (New.DoResolve): Check for new void().
9976 (MemberAccess.DoResolve): Cope with all kind of nulls.
9978 * literal.cs (NullConstant): Uses EmptyConstantCast.
9979 (NullDefault): Based on EmptyConstantCast.
9980 (NullLiteral): Uses EmptyConstantCast.
9982 * statement.cs (Block.ResolveMeta): Check for constant type.
9984 2006-09-22 Martin Baulig <martin@ximian.com>
9986 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9988 2006-09-22 Raja R Harinath <rharinath@novell.com>
9990 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9994 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9995 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9998 2006-09-22 Martin Baulig <martin@ximian.com>
10000 * ecore.cs: Merged with the gmcs version.
10002 * generic.cs (ConstructedType): New dummy class.
10003 (TypeArguments): Don't make this abstract.
10006 (TypeManager.IsGenericTypeDefinition): New method.
10007 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
10009 2006-09-22 Raja R Harinath <rharinath@novell.com>
10011 * expression.cs (ComposedCast): Check for arrays of TypedReference
10012 before creating the type, not after.
10014 2006-09-21 Marek Safar <marek.safar@seznam.cz>
10016 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
10017 after ToType change.
10019 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
10020 when constant must be implicitly convertible.
10022 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
10024 * ecore.cs (NullCast): Derives from NullConstant.
10026 * expression.cs (Is.DoResolve): Removed useless variables.
10027 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
10028 (New.Constantify): Add enum support.
10029 (MemberAccess.DoResolve): Add warning when accessing null constant or
10032 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
10035 * literal.cs (NullConstant): New abstract class with common
10036 functionality for all null specializations.
10037 (NullDefault): Represents default(X) when result can be
10039 (NullLiteral): Updated.
10041 * report.cs: Add new warning.
10043 2006-09-21 Martin Baulig <martin@ximian.com>
10045 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
10047 2006-09-21 Martin Baulig <martin@ximian.com>
10049 * generic.cs (GenericConstraints): New dummy class.
10050 (Constraints): Likewise.
10051 (TypeParameter): Likewise.
10052 (TypeParameterName): Likewise.
10053 (GenericMethod): Likewise.
10055 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10057 * decl.cs: Merged with the gmcs version.
10059 2006-09-21 Raja R Harinath <rharinath@novell.com>
10061 * generic.cs (TypeParameter): Implement IMemberContainer.
10062 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10064 * rootcontext.cs: Unify with gmcs version.
10066 * report.cs: Unify with gmcs version.
10067 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10068 from gmcs/generics.cs.
10069 * generics.cs (TypeParameter): New dummy class.
10071 * support.cs: Unify with gmcs version.
10073 2006-09-20 Raja R Harinath <rharinath@novell.com>
10075 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10076 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10078 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10079 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10080 * mcs.exe.sources: Add generic.cs.
10082 * codegen.cs: Unify with gmcs version.
10084 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10085 (EmitContext): Add GenericDeclContainer implementation.
10086 * decl.cs (MemberCore, DeclSpace): Likewise.
10087 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10089 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10090 MCS TypeManager has a corresponding dummy method.
10092 2006-09-19 Martin Baulig <martin@ximian.com>
10094 * expression.cs: Completely merged with the gmcs version.
10096 2006-09-19 Martin Baulig <martin@ximian.com>
10098 * expression.cs (Invocation): Merged with the gmcs version.
10099 (ArrayAccess.GetStoreOpcode): Likewise.
10101 2006-09-19 Martin Baulig <martin@ximian.com>
10104 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10105 (TypeManager.IsGenericMethodDefinition): Likewise.
10107 2006-09-19 Martin Baulig <martin@ximian.com>
10110 (TypeManager.IsEqual): Moved the gmcs implementation here.
10111 (TypeManager.DropGenericTypeArguments): Likewise.
10112 (TypeManager.DropGenericMethodArguments): Likewise.
10113 (TypeManager.GetTypeArguments): Moved here from gmcs.
10114 (TypeManager.HasGenericArguments): Likewise.
10116 2006-09-19 Martin Baulig <martin@ximian.com>
10118 * expression.cs (Binary): Merged with the gmcs version.
10120 2006-09-19 Martin Baulig <martin@ximian.com>
10122 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10124 2006-09-19 Martin Baulig <martin@ximian.com>
10126 * typemanager.cs: Merged with the gmcs version.
10128 2006-09-16 Raja R Harinath <rharinath@novell.com>
10130 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10131 * driver.cs: Likewise.
10133 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10136 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10137 only if parent type is class.
10138 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10141 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10144 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10146 * typemanager.cs(CSharpName): Converts NullType to null.
10148 2006-09-15 Martin Baulig <martin@ximian.com>
10151 (TypeManager.GetMethodName): Added mcs implementation.
10152 (TypeManager.IsEqual): Likewise.
10155 (SimpleName.RemoveGenericArity): Added dummy implementation.
10157 * pending.cs: Merged with the gmcs version.
10159 2006-09-15 Martin Baulig <martin@ximian.com>
10161 * statement.cs: Merge with the gmcs version.
10163 2006-09-15 Martin Baulig <martin@ximian.com>
10165 * statement.cs (Switch): Merge with the gmcs implementation
10166 (without nullables), which is newer.
10168 2006-09-15 Martin Baulig <martin@ximian.com>
10170 * statement.cs (Block.Variables): Make this public.
10171 (ToplevelBlock.Parameters): Make this a property.
10172 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10174 2006-09-15 Martin Baulig <martin@ximian.com>
10176 * namespace.cs: Merge with the gmcs version.
10178 2006-09-15 Martin Baulig <martin@ximian.com>
10180 * decl.cs (MemberName): Minor code cleanups.
10182 2006-09-15 Martin Baulig <martin@ximian.com>
10184 * parameter.cs: Merge with the gmcs version.
10186 2006-09-15 Martin Baulig <martin@ximian.com>
10188 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10189 and an error in mcs.
10191 2006-09-15 Martin Baulig <martin@ximian.com>
10193 * flowanalysis.cs: Merged from GMCS; added the generics code into
10194 a `GMCS_SOURCE' conditional so we can share this file.
10196 2006-09-08 Martin Baulig <martin@ximian.com>
10198 * typemanager.cs (TypeManager.interlocked_type): New public field.
10199 (TypeManager.int_interlocked_compare-exchange): New public field.
10200 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10201 enumerator types here and call InitGenericCoreTypes().
10202 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10203 after calling InitEnumUnderlyingTypes().
10206 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10207 `classes_second_stage'.
10209 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10211 * assign.cs, ecore.cs, expression.cs: Share error message text.
10212 * class.cs (FieldMember.Define): Check for varible of static type.
10213 * driver.cs (LoadAssembly): Uses error output for errors.
10214 * statement.cs: Updated.
10216 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10218 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10221 2006-09-07 Martin Baulig <martin@ximian.com>
10224 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10226 2006-08-29 Miguel de Icaza <miguel@novell.com>
10228 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10230 2006-08-17 Miguel de Icaza <miguel@novell.com>
10232 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10233 #52019 and #79064, the use of the \uXXXX sequence in source code
10234 to represent unicode characters.
10236 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10238 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10240 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10242 2006-08-13 Miguel de Icaza <miguel@novell.com>
10244 * assign.cs: Catch attempts to assign to a method groups in += and
10247 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10250 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10252 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10254 * class.cs (Method.Define): Issue a warning when generic method looks like
10256 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10259 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10261 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10263 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10264 search all base interfaces as a member can be ambiguous.
10265 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10266 Constructor member type filter.
10267 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10268 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10269 reporting for returned memberinfos.
10270 * report.cs: Updated.
10271 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10272 version to work on all runtimes.
10273 (TypeManager.RealMemberLookup): Removed members filtering.
10275 2006-08-08 Raja R Harinath <rharinath@novell.com>
10277 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10278 (PropertyExpr.EmitAssign): Likewise.
10279 * expression.cs (Indirection.EmitAssign): Likewise.
10280 (LocalVariableReference.EmitAssign): Likewise.
10281 (ParameterReference.EmitAssign): Likewise.
10282 (Invocation.EmitArguments): Likewise.
10283 (ArrayAccess.EmitAssign): Likewise.
10284 (IndexerAccess.EmitAssign): Likewise.
10285 (This.EmitAssign): Likewise.
10286 (ConditionalLogicalOperator.Emit): Likewise.
10289 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10290 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10291 leave it in after returning it.
10292 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10294 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10296 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10299 2006-08-03 Raja R Harinath <rharinath@novell.com>
10301 Fix cs0146-3.cs and cs0146-4.cs.
10302 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10303 enclosing types don't depend on the current type.
10305 2006-08-02 Raja R Harinath <rharinath@novell.com>
10308 * class.cs (TypeContainer.DoDefineMembers): Use
10309 FindBaseMemberWithSameName on Parent, since we're interested in
10310 whether we hide inherited members or not.
10311 (FindBaseMemberWithSameName): Make slightly more robust.
10313 Fix the non-generic testcase from #77396
10314 * decl.cs (DeclSpace.DeclContainer): Remove override.
10316 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10317 declspaces for doppelgangers too.
10318 (UsingEntry): Implement IResolveContext.
10319 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10320 'this' as the resolve context.
10321 (LocalAliasEntry): Likewise.
10323 Implement parts of #77403
10324 * roottypes.cs (RootDeclSpace): New. Used to represent the
10325 toplevel declaration space. Each namespace declaration introduces
10326 a "partial" root declaretion space.
10327 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10328 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10329 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10330 from 'current_namespace.SlaveDeclSpace'.
10331 (namespace_declaration): Likewise.
10332 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10333 check. It can't happen now.
10334 * decl.cs (DeclSpace.LookupType): Likewise.
10335 * driver.cs (MainDriver): Sanity check.
10337 2006-08-01 Raja R Harinath <rharinath@novell.com>
10339 * decl.cs (DeclSpace.FindNestedType): Remove.
10340 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10341 LookupTypeContainer to get the container of the nested type.
10342 * class.cs (TypeContainer.FindNestedType): Make non-override.
10344 2006-07-31 Raja R Harinath <rharinath@novell.com>
10346 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10347 * class.cs (TypeContainer.PartialContainer): ... here.
10348 (TypeContainer.AddBasesForPart): New helper.
10349 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10351 * cs-parser.jay (current_class): Convert to DeclSpace.
10352 (struct_declaration, interface_declaration, class_declaration):
10353 Use AddBasesForPart instead of .Bases directly.
10354 * const.cs, iterators.cs: Update to changes.
10356 2006-07-28 Raja R Harinath <rharinath@novell.com>
10358 * class.cs (TypeContainer.AddMemberType): Rename from
10359 AddToTypeContainer.
10360 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10361 (AddTypeContainer): New. Combine AddClassOrStruct and
10363 (AddPartial): Update. Add 'is_partial' argument.
10364 * roottypes.cs: Update to changes.
10365 * cs-parser.jay (push_current_class): New helper for handling
10366 current_container and current_class.
10367 (struct_declaration, interface_declaration, class_declaration):
10370 2006-07-26 Raja R Harinath <rharinath@novell.com>
10372 * roottypes.cs: Rename from tree.cs.
10374 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10375 * tree.cs (Tree, ITreeDump): Remove types.
10376 * rootcontext.cs (tree, Tree): Remove fields.
10377 (root, ToplevelTypes): New.
10378 * *.cs: Update to rename.
10380 * tree.cs (Tree.RecordDecl): Remove.
10381 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10383 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10385 2006-07-23 Raja R Harinath <harinath@gmail.com>
10387 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10388 DoFlowAnalysis and OmitStructFlowAnalysis here.
10389 (ec.With): Rename from WithUnsafe and generalize.
10390 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10391 (ec.WithFlowAnalyis): New.
10392 * ecore.cs, expression.cs, statement.cs: Update.
10394 2006-07-22 Raja R Harinath <harinath@gmail.com>
10396 * statement.cs (Block.ResolveMeta): Simplify slightly.
10398 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10399 multiple boolean fields. Convert InUnsafe, constant_check_state,
10400 check_state to flags.
10401 (CheckState, ConstantCheckState): Update.
10402 (InUnsafe): New read-only property.
10403 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10405 (WithUnsafe): New helper similar to WithCheckState.
10406 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10407 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10409 2006-07-21 Raja R Harinath <rharinath@novell.com>
10411 Make comparisons use the same IL irrespective of whether they're
10412 in a 'checked' or 'unchecked' context: one of the issues in #78899
10413 * codegen.cs (EmitContext.CheckState): Make read-only property.
10414 (EmitContext.ConstantCheckState): Likewise.
10415 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10416 helper that implement a save/restore stack for CheckState
10417 values. This is the only way to change check-state.
10418 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10419 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10420 (CheckedExpr.EmitBranchable): New forwarding method.
10421 (UnCheckedExpr): Likewise.
10422 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10423 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10424 (Checked.Resolve, checked.DoEmit): Likewise.
10426 2006-07-20 Miguel de Icaza <miguel@novell.com>
10428 * anonymous.cs: Cache the resolved anonymous delegate, and return
10429 this so that the ResolveTopBlock is only triggered once, not
10432 Currently we trigger ResolvetopBlock twice due to a first pass of
10433 argument check compatibility, and a second pass that does the
10436 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10438 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10440 * rootcontext.cs (Reset): Add helper_classes.
10442 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10445 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10448 2006-07-13 Miguel de Icaza <miguel@novell.com>
10450 * statement.cs (Lock): Handle expressions of type
10451 TypeManager.null_type specially. Fixes #78770
10453 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10455 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10458 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10460 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10461 for accessors as well.
10462 * ecore.cs (EventExpr): Add AccessorTable.
10464 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10467 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10468 for CS0122 where appropriate.
10469 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10471 (Filter): Assembly can be null in the case of top level attributes.
10473 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10477 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10478 is done at global level.
10480 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10482 A fix for #77002, Implemented TypeForwarder support.
10484 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10485 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10486 * typemanager.cs (): Add type_forwarder_attr_type.
10488 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10490 * report.cs: Add CS0469 warning.
10492 2006-06-21 Martin Baulig <martin@ximian.com>
10494 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10495 the `try'-block, so we also report CS0016 etc. there.
10497 2006-06-21 Martin Baulig <martin@ximian.com>
10500 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10502 2006-06-21 Martin Baulig <martin@ximian.com>
10504 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10505 also report CS1686 for parameters.
10507 2006-06-21 Martin Baulig <martin@ximian.com>
10509 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10510 instead of an error if the value is not implicitly convertible to
10511 the switch types; fixes #77964.
10513 2006-06-21 Raja R Harinath <rharinath@novell.com>
10516 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10517 FieldBuilder is null.
10520 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10521 'left' and 'right' before error-checking.
10523 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10525 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10527 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10528 (FieldExpr.DoResolve): likewise.
10529 (PropertyExpr.InstanceResolve): likewise.
10530 (EventExpr.InstanceResolve): likewise.
10532 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10534 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10535 attribute applicable tests for attribute argument.
10537 2006-06-02 Raja R Harinath <rharinath@novell.com>
10540 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10541 (Binary.OverloadResolve_PredefinedIntegral): New.
10542 (Binary.OverloadResolve_PredefinedFloating): New.
10543 (Binary.OverloadResolve_PredefinedString): New.
10544 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10545 Follow the standard more closely, and treat numeric promotions in
10546 terms of overload resolution.
10547 (Binary.CheckShiftArguments): Simplify.
10549 2006-06-01 Raja R Harinath <rharinath@novell.com>
10551 * flowanalysis.cs (MyBitVector): Simplify representation.
10552 (MyBitVector.Clone): Avoid allocating BitArray.
10553 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10554 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10555 (*): Update. Change all references to MyBitVector.And and
10556 MyBitVector.Or to &= and |=.
10558 2006-05-29 Raja R Harinath <rharinath@novell.com>
10560 Fix cs0231-[34].cs.
10561 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10562 to param arguments too.
10564 2006-05-26 Miguel de Icaza <miguel@novell.com>
10566 * cs-parser.jay: Catch another parsing form for arglist being
10567 followed by other arguments. Fixes #78313.
10569 2006-05-24 Raja R Harinath <rharinath@novell.com>
10571 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10572 checking of out parameters to ...
10573 (FlowBranchingToplevel.Merge): ... here.
10574 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10575 set, propagate the origin upward, and only complain if there was
10577 (FlowBranchingException.AddContinueOrigin): Likewise.
10578 (FlowBranchingException.AddReturnOrigin): Likewise.
10579 (FlowBranchingException.AddGotoOrigin): Likewise.
10581 2006-05-23 Raja R Harinath <rharinath@novell.com>
10583 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10584 unreachable, skip it.
10585 (FlowBranchingException.Merge): Always propagate jumps, even if
10586 the finally block renders subsequent code unreachable.
10588 2006-05-18 Raja R Harinath <rharinath@novell.com>
10591 * statement.cs (Goto.Resolve): Move responsibility for resolving
10592 'goto' to FlowBranching.AddGotoOrigin.
10593 (Goto.SetResolvedTarget): New. Callback to set the
10594 LabeledStatement that's the target of the goto.
10595 (Goto.DoEmit): Use Leave instead of Br when crossing an
10596 unwind-protect boundary.
10597 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10598 LookupLabel and adjust to new semantics.
10599 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10600 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10601 Goto.SetResolvedTarget to update target.
10602 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10603 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10604 AddBreakOrigin & co. Delay propagation until ...
10605 (FlowBranchingException.Merge): ... this.
10607 * statement.cs (Block.Resolve): Always depend on flow-branching to
10608 determine unreachability. Kill workaround that originally emitted
10609 only one statement after an "unreachable" label (see infloop in
10612 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10613 This is still "wrong", but anything better would probably need a
10614 multi-pass algorithm.
10615 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10616 usage vector. Force current usage vector to be reachable, to
10617 optimistically signify backward jumps.
10618 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10620 (FlowBranchingLabeled.Merge): New. If no backward jump was
10621 detected, return the original salted-away usage vector instead,
10622 updated with appropriate changes. Print unreachable warning if
10624 * statement.cs (Block.Resolve): Don't print unreachable warning on
10625 a labeled statement.
10627 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10629 * driver.cs: Pass filename without path to AssemblyBuilder's
10630 AddResourceFile. Fixes bug #78407.
10632 2006-05-17 Raja R Harinath <rharinath@novell.com>
10634 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10635 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10636 (FlowBranching.MergeChild): Overwrite
10637 reachability information from Labeled branchings too.
10639 2006-05-16 Raja R Harinath <rharinath@novell.com>
10641 * statement.cs (Goto.Resolve): Merge jump origins here ...
10642 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10644 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10645 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10646 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10647 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10649 * statement.cs (Goto.Resolve): ... not here.
10650 (Goto.Emit): Remove CS1632 check.
10652 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10654 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10657 2006-05-11 Raja R Harinath <rharinath@novell.com>
10659 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10660 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10661 (FlowBranchingException.Label): Likewise.
10663 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10665 (MyBitVector.Or): Use it to avoid losing information (Count).
10666 (FlowBranching.MergeOrigins): Likewise.
10668 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10669 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10670 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10671 (UsageVector.ToString): Simplify.
10672 (UsageVector.MergeSiblings): Move here from ...
10673 (FlowBranching.Merge): ... here.
10674 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10677 2006-05-10 Raja R Harinath <rharinath@novell.com>
10679 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10680 null bitvector is treated as all-true.
10682 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10683 (MyBitVector): Rationalize invariants. 'vector != null' implies
10684 that we have our own copy of the bitvector. Otherwise,
10685 'InheritsFrom == null' implies all inherited bits are true.
10687 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10689 * statement.cs (LocalInfo): Add IsConstant.
10690 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10691 local variable for constants.
10693 2006-05-09 Raja R Harinath <rharinath@novell.com>
10695 * flowanalysis.cs (MyBitVector.Empty): New.
10696 (MyBitVector): Don't allow InheritedFrom to be null.
10697 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10698 (UsageVector, FlowBranching): Update to changes.
10700 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10701 recursion. The 'Parent == null' condition isn't sufficient for
10703 (FlowBranching.AddBreakOrigin): Likewise.
10704 (FlowBranching.AddContinueOrigin): Likewise.
10705 (FlowBranching.AddReturnOrigin): Likewise.
10706 (FlowBranching.StealFinallyClauses): Likewise.
10707 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10708 (FlowBranching.CheckOutParameters): Likewise.
10709 (FlowBranchingToplevel): Terminate all the above recursions here.
10710 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10711 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10713 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10715 (FlowBranchingToplevel): New. Empty for now.
10716 (FlowBranching.MergeTopBlock): Update.
10717 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10718 branching for the anonymous delegate.
10719 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10721 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10722 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10723 information at the start of the merge. Reorganize.
10725 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10727 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10729 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10731 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10732 to newly introduced ctor.
10734 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10735 message to one place.
10736 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10739 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10741 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10743 * ecore.cs (Expression.ResolveAsConstant): Updated.
10745 * statement.cs (ResolveMeta): Updated.
10747 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10749 * cs-parser.jay: __arglist cannot be used in initializer.
10751 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10754 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10757 2006-05-05 Raja R Harinath <rharinath@novell.com>
10759 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10760 (LabeledStatement): Add 'name' parameter.
10761 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10762 (Block.AddLabel): Update to changes.
10763 * cs-parser.jay (labeled_statement): Likewise.
10765 * flowanalysis.cs (BranchingType.Labeled): New.
10766 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10767 (FlowBranchingLabeled): New. Does nothing for now, but will
10768 eventually handle 'goto' flows.
10769 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10770 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10771 that's terminated ...
10772 (Block.Resolve): ... here.
10774 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10775 (UsageVector.MergeFinallyOrigins): Likewise.
10776 (FlowBranching.InTryOrCatch): Likewise.
10777 (FlowBranching.AddFinallyVector): Likewise.
10778 (FlowBranchingException): Update to changes.
10781 * statement.cs (Return.Resolve): Move error checking to ...
10782 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10783 (FlowBranchingException): Handle return origins like break and
10785 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10787 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10790 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10793 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10796 * class.cs (MethodData.Define): Do public accessor check only when method
10797 implements an interface.
10799 2006-05-04 Raja R Harinath <rharinath@novell.com>
10801 Remove special handling of 'break'
10802 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10803 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10804 (UsageVector.Break): Remove.
10805 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10807 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10809 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10810 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10812 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10815 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10816 be the interface member.
10818 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10821 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10822 for emitting small (int) values.
10824 2006-05-03 Raja R Harinath <rharinath@novell.com>
10827 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10828 control-flow passes through the 'finally' after merging-in all the
10829 control-flows from 'try' and the 'catch' clauses.
10831 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10832 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10833 always true at the only non-recursive entry point.
10834 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10835 FlowBranchingBreakable.
10836 (FlowBranchingLoop): Remove.
10837 * statement.cs (Return.DoResolve): Update to changes.
10840 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10841 (FlowBranching.CreateBranching): Handle it: create a
10842 FlowBranchingContinuable.
10843 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10844 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10845 except that it handles the 'continue' command.
10846 (FlowBranching.UsageVector.MergeOrigins): Rename from
10848 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10849 except that it overrides AddContinueOrigin.
10850 (FlowBranchingException): Override AddContinueOrigin, similar to
10852 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10853 Create a new branching around the embedded statement.
10854 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10855 control flow after the embedded statement.
10856 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10858 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10859 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10860 FlowBranchingBreakable.
10861 (FlowBranchingSwitch): Remove.
10864 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10865 error reporting to ...
10866 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10867 Rename from 'AddBreakVector'. Add new location argument. Return
10868 a bool indicating whether the 'break' crosses an unwind-protect.
10869 (FlowBranchingException.AddBreakOrigin): Add.
10870 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10871 flowbranching after updating with the effects of the 'finally'
10873 (FlowBranchingBreakable): New common base class for
10874 FlowBranchingLoop and FlowBranchingSwitch.
10876 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10877 embedded statement.
10878 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10880 2006-05-02 Raja R Harinath <rharinath@novell.com>
10882 * statement.cs (Do.Resolve): If the loop is infinite, set the
10884 (While.Resolve, For.Resolve): Set a barrier after the embedded
10885 statement. There's no direct control flow that goes from the end
10886 of the embedded statement to the end of the loop.
10887 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10888 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10889 above ensure that the reachability is correctly computed.
10891 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10892 (UsageVector.MergeBreakOrigins): If the current path is
10893 unreachable, treat it as if all parameters/locals are initialized.
10894 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10895 infinite loops before merging-in break origins.
10897 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10898 (Reachability.Reachable): Split part into ...
10899 (Reachability.Unreachable): ... this. Simplify.
10900 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10902 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10903 (Reachability.SetThrowsSometimes): Likewise.
10904 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10905 TriState.Always, use corresponding property.
10906 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10907 (Block.Resolve): Likewise. Remove some redundant checks.
10909 2006-05-02 Raja R Harinath <harinath@gmail.com>
10911 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10912 (Reachability.Meet): Don't bother checking AlwaysThrows --
10913 barrier is always set.
10914 (FlowBranchingBlock.Merge): Likewise.
10916 2006-05-01 Raja R Harinath <harinath@gmail.com>
10918 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10919 checks for unreachable.
10921 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10924 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10926 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10927 whether field is really assigned.
10929 2006-04-30 Raja R Harinath <harinath@gmail.com>
10931 * flowanalysis.cs (Reachability): Make 4-argument constructor
10933 (Reachability.Meet): Rename from 'And'. Remove static variant.
10934 (Reachability.Always): Rename from the highly misleading
10935 'Reachability.Never'.
10936 (FlowBranching.Merge): Update to changes. Mark an impossible
10937 situation with a 'throw'.
10938 (*): Update to changes.
10940 2006-04-29 Raja R Harinath <harinath@gmail.com>
10942 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10943 Remove 'Undefined'.
10944 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10945 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10946 (*): Update to changes.
10947 * statement.cs: Update to changes.
10949 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10952 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10954 2006-04-28 Raja R Harinath <harinath@gmail.com>
10956 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10959 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10960 argument to two arguments: an usage-vector and a bool. Move call
10961 to FlowBranching.Merge () ...
10962 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10964 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10965 handling of loop and switch reachability to ...
10966 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10968 2006-04-27 Raja R Harinath <harinath@gmail.com>
10970 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10971 handling to FlowBranchingLoop.InLoop.
10972 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10974 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10977 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10978 anonymous method is allowed from AnonymousContainer here.
10980 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10982 2006-04-24 Raja R Harinath <rharinath@novell.com>
10985 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10987 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10990 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10991 (DoubleConstant.Reduce): Ditto.
10993 2006-04-23 Raja R Harinath <rharinath@novell.com>
10995 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10996 Remove 'lvalue_right_side' argument. Move parts to ...
10997 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10998 (LocalVariable.DoResolveLValue): ... these.
11000 2006-04-21 Raja R Harinath <rharinath@novell.com>
11003 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
11004 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
11005 (LocalVariableReference.DoResolveBase): Use it to implement new
11007 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
11008 (Argument.Resolve): Simplify. Move CS1510 check ...
11009 * ecore.cs (Expression.ResolveLValue): ... here.
11010 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
11011 (PropertyExpr.DoResolveLValue): Likewise.
11012 (FieldExpr.Report_AssignToReadonly): Likewise.
11013 (FieldExpr.DoResolve): Add 'out_access' argument. Use
11014 LValueMemberAccess or LValueMemberOutAccess on instance depending
11016 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
11017 DoResolve as appropriate.
11019 2006-04-20 Raja R Harinath <rharinath@novell.com>
11022 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
11023 implicit conversions on 'out' and 'ref' arguments.
11025 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
11026 improve clarity. Remove dead code.
11029 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
11030 (Catch.Resolve): Resolve VarBlock if it exists.
11032 2006-04-19 Miguel de Icaza <miguel@novell.com>
11034 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
11035 twice, this was some residual code, the enumerator was emitted
11036 properly in the two branche of if later.
11038 2006-04-19 Raja R Harinath <rharinath@novell.com>
11040 * expression.cs (Cast.ResolveLValue): Remove. The result of a
11041 cast is never an lvalue.
11042 (Cast.DoResolve, Cast.ResolveRest): Combine.
11043 (Argument.Emit): Simplify slightly. Move 'Expr is
11044 IMemoryLocation' check ...
11045 (Argument.Resolve): ... here.
11046 (Argument.Error_LValueRequired): Remove. Inline into only user.
11048 Simplifications. Fix cs0191-2.cs
11049 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11050 CS1649 and CS1651 to ...
11051 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11052 the actual selection of the error code and message to a lookup
11053 table. Add a dummy return value to simplify callsites.
11054 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11055 readonly fields of other instances of the same type. Move CS0197
11057 * expression.cs (Argument.Resolve): ... here. Simplify code.
11058 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11059 resolution of an out or ref argument. The code simplification
11060 above uses this invariant.
11062 2006-04-18 Raja R Harinath <rharinath@novell.com>
11064 Possibly fix #77752. Fix cs1690-[4-7].cs.
11065 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11066 CheckMarshallByRefAccess. Drop parameter.
11067 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11069 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11070 InstanceExpression.
11071 * report.cs (AllWarnings): Add CS1690.
11072 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11073 for ref access too.
11074 (LocalVariableReference.DoResolveBase): Update.
11076 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11078 * class.cs (MethodOrOperator): Moved common parts from method class.
11079 detect obsolete attributes.
11080 (Method.Define): Simplified as it reuses code from base.
11081 (Constructor.ValidAttributeTargets): Fixed issue found during
11083 (Destructor.ValidAttributeTargets): Fixed issue found during
11085 (Operator): Finished refactoring set off by #78020. Operator class is now
11086 ordinary method class.
11088 * anonymous.cs: Updated.
11090 * decl.cs (DeclSpace): Add IsGeneric
11092 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11094 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11096 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11098 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11099 detect obsolete attributes.
11100 (Method.CreateEmitContext): Moved to MethodOrOperator.
11102 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11105 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11106 customized exception to make crash detection easier.
11107 (MethodOrOperator): Started to work on new base class for methods and
11109 (Method): Derives from MethodOrOperator.
11110 (Constructor.Emit): Emits its own attributes.
11111 (AbstractPropertyEventMethod.Emit): Ditto.
11112 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11114 (Operator.Emit): It's temporary more tricky than should be.
11116 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11118 * report.cs (InternalErrorException): Add ctor with inner exception.
11120 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11123 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11126 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11129 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11132 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11134 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11135 attribute is present and Guid not.
11136 (Interface.ApplyAttributeBuilder): Ditto.
11138 * attribute.cs: Add error message.
11140 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11144 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11145 sources (it's composite) so hold them in extra array as they are used in
11146 Emit phase only. It worked in the previous versions by mistake.
11147 (Attribute.Emit): Emit attribute for more owners when exist.
11149 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11150 it has now different behaviour.
11152 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11154 * constant.cs (Constant.IsDefaultInitializer): New method.
11156 * class.cs: Updated.
11158 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11159 re-initialize default values. It saves KBs almost for every assembly.
11160 Thanks Zoltan for the idea.
11161 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11162 (ArrayCreation.DoResolve): Resolve only once.
11163 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11164 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11166 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11168 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11171 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11173 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11174 in an embedded statement too.
11176 2006-04-01 Raja R Harinath <rharinath@novell.com>
11179 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11181 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11185 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11188 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11190 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11192 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11195 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11196 LocalTemporary change.
11198 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11200 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11201 initializers optimization.
11202 (ClassOrStruct.TypeAttr): Moved from modifiers.
11203 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11204 (FieldBase.ResolveInitializer): Resolves initializer.
11205 (FieldBase.HasDefaultInitializer): New property.
11207 * cs-parser.jay: Removed message.
11209 * expression.cs (CompilerGeneratedThis): New specialization.
11211 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11213 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11215 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11217 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11219 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11220 be now EnumConstants only.
11222 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11224 * attribute.cs, driver.cs: Reset more caches.
11226 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11228 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11230 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11232 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11233 for easier reuse. Updated all overrides.
11234 (IntegralConstant): New base class for all integral constants.
11235 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11236 of the constant range, report custom error.
11237 (UIntConstant.Reduce): Fixed uint conversion.
11239 * ecore.cs, literal.cs: Reduce updates.
11241 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11245 * class.cs (Constructor.Define): Removed extra if for default ctors.
11246 A patch from Atsushi Enomoto.
11248 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11250 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11251 GetAttributableValue.
11253 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11256 * convert.cs (ImplicitConversionRequired): Error message moved to
11259 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11260 automatic implicit conversion of an output value.
11261 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11263 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11265 (TypeOf.GetAttributableValue): Add extra handling for object type.
11267 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11268 special error message.
11270 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11272 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11274 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11275 compatible with MS runtime.
11277 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11279 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11280 attribute arguments here.
11282 * class.cs (Indexer.Define): The check was moved to attribute class.
11284 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11286 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11287 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11290 2006-03-22 Raja R Harinath <rharinath@novell.com>
11292 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11293 mcs to keep code differences small.
11294 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11295 * typemanager.cs (parameter_default_value_attribute_type): New.
11296 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11299 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11301 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11303 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11305 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11307 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11310 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11312 * doc-bootstrap.cs : fix build.
11314 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11316 * expression.cs (StringConcat.Append): Issue a warning when empty string
11317 is going to append.
11319 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11321 * assign.cs (CompoundAssign.ResolveSource): Removed.
11323 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11326 * class.cs (TypeContainer.FindMethods): Removed.
11327 (TypeContainer.CheckMemberUsage): Made static.
11329 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11331 * constant.cs (CheckRange): Removed unused type argument.
11332 (CheckUnsigned): Removed unused type argument.
11334 * cs-parser.jay: Updated after MemberAccess clean up.
11335 Uses Length for empty string test.
11337 * cs-tokenizer.cs: Uses Length for empty string test.
11338 (IsCastToken): Made static.
11339 (is_hex): Made static.
11340 (real_type_suffix): Made static.
11342 * decl.cs (SetupCache): Made static.
11343 (OnGenerateDocComment): Removed unused ds argument.
11345 * delegate.cs (VerifyDelegate): Removed unused argument.
11347 * doc.cs: Uses Length for empty string test.
11349 * driver.cs: Uses Length for empty string test.
11351 * enum.cs (IsValidEnumType): Made static
11353 * expression.cs (EnumLiftUp): Removed unused argument.
11354 (ResolveMethodGroup): Ditto.
11355 (BetterConversion): Ditto.
11356 (GetVarargsTypes): Ditto.
11357 (UpdateIndices): Ditto.
11358 (ValidateInitializers): Ditto.
11359 (MemberAccess.ctor): Ditto.
11360 (GetIndexersForType): Ditto.
11362 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11364 * iterators.cs: Updated after MemberAccess clean up.
11366 * location.cs: Uses Length for empty string test.
11368 * namespace.cs: Uses Length for empty string test.
11370 * report.cs (CheckWarningCode): Made static.
11372 * statement.cs (LabeledStatement): Removed unused argument.
11374 * typemanager.cs (FilterNone): Removed.
11376 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11378 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11381 * class.cs: Updated.
11383 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11385 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11387 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11391 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11392 reporting, it's more tricky than I thought.
11394 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11398 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11400 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11401 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11402 Add more error reporting; Fixed issue with params.
11404 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11406 * cs-parser.jay: AnonymousMethod requires host container.
11408 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11410 2006-03-18 Raja R Harinath <harinath@gmail.com>
11412 * class.cs: Change 'TypeContainer ds' constructor argument to
11413 'DeclSpace parent'. Some classes were missed below due to
11414 different naming convention.
11416 * class.cs (MemberCore.Parent): Delete. This makes the
11417 ParentContainer changes below enforceable by the compiler.
11419 Treat pointers to enclosing declaration space as 'DeclSpace', not
11421 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11422 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11424 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11426 (Block.AddThisVariable): Likewise.
11427 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11428 (AbstractPropertyEventMethod.Emit): Likewise.
11429 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11430 (GetMethod.Define, SetMethod.Define): Likewise.
11431 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11432 (DelegateMethod.EmitMethod): Likewise.
11434 Fix regression test-partial-13.cs.
11435 Rationalize use of PartialContainer. Ensure that the partial
11436 class semantics can be tied to type-correctness, i.e., any
11437 violation will cause a compile error.
11438 * class.cs, const.cs: Access all fields that belong to class
11439 TypeContainer via ParentContainer. Arguments of EmitContexts and
11440 Resolve()-like functions still use 'Parent'.
11442 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11443 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11444 (PropertyMethod.CheckModifiers): Remove unused argument.
11445 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11448 2006-03-17 Raja R Harinath <harinath@gmail.com>
11450 Make semantics of PartialContainer simpler.
11451 * decl.cs (DeclSpace.IsPartial): Remove.
11452 * class.cs (TypeContainer.IsPartial): Likewise.
11453 (TypeContainer..ctor): Set PartialContainer to point to self.
11454 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11455 (TypeContainer.FindNestedType): Likewise.
11456 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11458 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11460 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11462 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11464 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11467 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11469 * class.cs (Operator.Define): An error for base conversion was not
11470 reported correctly.
11472 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11474 * iterator.cs : yield break is allowed in try statement which has
11475 catch clauses. Fixed bug #77767.
11477 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11479 A fix for #77593, #77574.
11481 * class.cs (MethodCore.CheckBase): Another if for operator.
11483 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11485 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11488 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11489 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11492 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11495 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11496 Updated after another emitcontext usage was clean up. It should help us to
11497 synchronize with gmcs easier.
11499 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11503 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11504 (Event.Define): ditto
11505 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11507 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11508 Removed redundant code and set NewSlot for Invoke method too.
11510 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11511 (Parameters.MergeGenerated): New method. Use this method when you merge
11512 compiler generated argument with user arguments.
11514 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11516 * attribute.cs (ResolveAsTypeTerminal): Removed.
11518 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11519 specialization for predefined types; 30% speed up.
11520 Finally placed obsolete check to right place.
11521 (Expression.ResolveType): Removed.
11523 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11524 Updated after ResolveType was removed.
11526 * expression.cs (Cast.ctor): Check void cast.
11527 (Binary.ResolveAsTypeTerminal): Is never type.
11528 (Conditional.ResolveAsTypeTerminal): Is never type.
11530 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11532 2006-03-01 Raja R Harinath <rharinath@novell.com>
11535 * expression.cs (ParameterReference.DoResolveBase): Change return
11537 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11541 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11544 * typemanager.cs (GetFullNameSignature): Don't nullref on
11545 protected accessors.
11547 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11549 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11550 these two separated members to simplify the code.
11551 (Attribute.Resolve): Refactored to use new fields and methods.
11552 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11553 implemented obsolete attribute checking.
11554 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11555 implemented obsolete checking again. It look line never ending quest ;-)
11556 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11558 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11560 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11562 *class.cs (Property.Define): Add RegisterProperty call.
11564 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11565 argument groups (only 2).
11567 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11568 encoding expression to arguments.
11569 (Expression.ExprClassToResolveFlags): Just turned to property.
11571 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11572 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11573 optimized as well as implemented support for zero-length attributes.
11575 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11576 Add caching of PropertyInfo's.
11578 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11580 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11581 error multiple times.
11583 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11585 New partial class implementation.
11586 A fix for #77027, #77029, #77403
11588 * attribute.cs (Attributable): Made attributes protected.
11590 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11591 the replacements of ClassPart and PartialContainer.
11592 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11593 (TypeContainer.AddInterface): Ditto.
11594 (TypeContainer.AddPartial): The main method for partial classes. It checks
11595 for errors and merges ModFlags and attributes. At the end class is added to
11596 partial_parts list.
11597 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11599 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11600 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11601 from the rest of partial classes.
11602 (TypeContainer.GetClassBases): Simplified.
11603 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11605 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11606 (TypeContainer.HasExplicitLayout): Uses Flags now.
11607 (PartialContainer): Removed.
11608 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11609 (StaticClass): Was merged with Class.
11610 (Class.GetClassBases): class and static class bases are verified here.
11611 (Class.TypeAttr): Added static attributes when class is static.
11612 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11613 (MemberBase): In some cases we need to call parent container for partial
11614 class. It should be eliminated but it's not easy now.
11616 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11618 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11619 partial classed to accumulate class comments.
11620 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11622 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11624 * driver.cs (MainDriver): Tree.GetDecl was removed.
11626 * modifiers.cs (Modifiers): Add partial modifier.
11628 * tree.cs (Tree.decl): Removed.
11629 (RootTypes): Started to use this class more often for root types
11632 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11636 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11637 external interface does not have an attribute.
11639 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11641 Another prerequisites for new partial classs implementation.
11643 * attribute.cs (Attribute.Equal): Implemented.
11644 (Attribute.Emit): Changed as attributes can be applied more than twice.
11645 (Attributes.Emit): Check for duplicate attributes here.
11647 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11648 as a parameter, clean-up.
11650 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11654 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11655 contains obsolete attribute check which can in some cases look for base
11656 type of current class which is not initialized yet.
11657 (TypeContainer.BaseType): Replacement of ptype.
11659 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11661 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11663 First of prerequisites for new partial classs implemention.
11665 * attribute.cs (Attributable): Extended by ResolveContext;
11666 Attributes finally have correct context for resolving in all cases.
11667 (AttachTo): Attribute owner is assigned here.
11669 * codegen.cs (IResolveContext): Introduce new interface to hold
11670 all information needed in resolving phase.
11671 (EmitContext): Implements IResolveContext; more clean-up needed here.
11673 * decl.cs (MemberCore): Implemented IResolveContext.
11675 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11676 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11677 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11678 Refactored to use new IResolveContext instead of EmitContext; cleanup
11680 2006-02-06 Miguel de Icaza <miguel@novell.com>
11682 * codegen.cs (EmitScopeInitFromBlock): check here the
11683 capture_context, there is no need to make two calls to the
11686 * anonymous.cs: Add some debugging messages that might help me
11687 track other instances of this problem in the future (the
11688 regression of test 467).
11690 * cs-parser.jay: track the variable block, as we need to initalize
11691 any captured variables declared in this block for the "catch"
11692 portion of the "Try" statement.
11694 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11695 scope initialization for captured variables.
11697 Also, move the emit for the variables after the block location has
11700 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11702 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11704 2006-02-02 Miguel de Icaza <miguel@novell.com>
11706 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11707 commit yesterday, the initialization for the roots is necessary.
11708 What is not necessary is the scope activation.
11710 2006-02-02 Raja R Harinath <rharinath@novell.com>
11712 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11713 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11715 (Argument.Resolve): Remove CS0206 checks.
11717 2006-02-01 Miguel de Icaza <miguel@novell.com>
11719 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11720 scopes for all the roots, the scopes will now be emitted when the
11721 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11723 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11724 code. This reduces a lot of existing cruft.
11726 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11727 that the ScopeInfo is generated as we enter the scope, not at the
11728 time of use, which is what we used to do before.
11730 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11731 every time a Block is about to be emitted if we have a
11734 2006-02-01 Raja R Harinath <rharinath@novell.com>
11736 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11738 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11740 * typemanager.cs (cons_param_array_attribute): Make private.
11741 (Reset): Set it to null.
11742 (InitCoreHelpers): Don't initialize it.
11743 (ConsParamArrayAttribute): New. Initialize it as needed.
11744 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11746 2006-01-31 Miguel de Icaza <miguel@novell.com>
11748 * expression.cs: There might be errors reported during the
11749 selection of applicable methods. If there are errors, do not
11750 continue execution as it will lead the compiler to crash.
11752 2006-01-30 Miguel de Icaza <miguel@novell.com>
11754 * expression.cs: Member access is not allowed on anonymous
11755 methods. Fixes #77402.
11757 2006-01-30 Raja R Harinath <rharinath@novell.com>
11760 * cs-parser.jay (VariableDeclaration): Don't set
11761 current_array_type to null.
11762 (field_declaration, event_declaration, declaration_statement):
11763 Set it to null here.
11765 2006-01-28 Raja R Harinath <harinath@gmail.com>
11767 * typemanager.cs (GenericParameterPosition): New.
11770 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11772 * doc.cs : To process "include" elements, first we should create
11773 another list than XmlNodeList, because it could result in node
11774 removal, which could result in that the XmlNodeList gives up
11775 yielding next node.
11777 (Also made code identical to gmcs again.)
11779 2006-01-25 Miguel de Icaza <miguel@novell.com>
11781 * ecore.cs: Introduce an error report that we were not catching
11782 before, if not silent, we must report the error. Gonzalo ran into
11785 2006-01-23 Miguel de Icaza <miguel@novell.com>
11787 A fix for bug: #76957
11789 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11790 ComputeMethodHost before creating the method, this is a new
11793 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11794 that this method references (RegisterScope). The actual scope
11795 where the method is hosted is computed with the ComputeMethodHost
11796 before we create the method.
11798 Moved the Deepest routine here.
11800 (AnonymousContainer.ComputeMethodHost): New routine used to
11801 compute the proper ScopeInfo that will host the anonymous method.
11803 (ScopeInfo): Deal with multiple roots. The problem was that we
11804 did not have a unique root where all ScopeInfos could be hanged
11805 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11808 Remove AdjustMethodScope which is now computed at the end. Remove
11809 LinkScope which did a partial link, instead link all ScopeInfos
11810 before code generation from the new "LinkScopes" routine.
11812 Simplify all the Add* routines as they no longer need to maintain
11813 the tree, they just need to record that they are using variables
11816 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11817 routines to produce the forest of ScopeInfo trees.
11819 * class.cs (TypeContainer.AppendMethod): This is just like
11820 AddMethod, but ensures that an interface implementation method
11821 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11822 methods, but at the end.
11824 We use this functionality to ensure that the generated MoveNext
11825 method in the iterator class is resolved/emitted before the
11826 enumerator methods created.
11828 This is required because the MoveNext method computes the right
11829 ScopeInfo for the method. And the other methods will eventually
11830 need to resolve and fetch information computed from the anonymous
11833 2006-01-21 Raja R Harinath <harinath@gmail.com>
11834 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11836 Fix rest of #76995.
11837 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11838 the 'aliases' hash.
11839 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11840 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11842 2006-01-18 Raja R Harinath <rharinath@novell.com>
11844 Fix #76656, cs0231-2.cs.
11845 * cs-parser.jay (formal_parameter_list): Make error case catch
11847 (parenthesized_expression_0): Add CS1026 check.
11848 (invocation_expression): Remove unused { $$ = lexer.Location }.
11850 2006-01-17 Raja R Harinath <rharinath@novell.com>
11853 * cs-parser.jay (statement_expression): Don't list out the
11854 individual statement-expressions. Convert syntax error into
11857 2006-01-16 Raja R Harinath <rharinath@novell.com>
11860 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11861 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11862 CheckIntermediateModification.
11863 (FieldExpr.DoResolve): Add new two-argument version that
11864 allows us to resolve the InstanceExpression as an lvalue.
11865 The one-argument variant is now just a wrapper.
11866 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11867 Resolve the lhs as an lvalue if the it has a value type.
11868 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11869 from Assign.DoResolve.
11870 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11871 resolved as an lvalue.
11872 (PropertyExpr.DoResolve): Update.
11873 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11874 has a value type. Move CS1612 check here from
11875 CheckIntermediateModification.
11876 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11877 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11878 'right_side' of a ResolveLValue on an 'out' argument.
11879 (EmptyExpression.LValueMemberAccess): New. Used as the
11880 'right_side' of a propagated ResolveLValue on a value type.
11881 (LocalVariableReference.DoResolveBase): Recognize
11882 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11884 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11885 EmptyExpression.Null.
11887 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11889 * typemanager.cs : added IsGenericParameter(). In mcs it always
11891 * doc.cs : for generic parameters, use GenericParameterPosition,
11894 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11896 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11898 2006-01-12 Miguel de Icaza <miguel@novell.com>
11900 This fixes the problem where we used ldfld instead of ldflda to
11901 load the "THIS" pointer on captured parameters, when THIS is a
11902 value type. See bug #77205.
11904 * iterators.cs (CapturedThisReference.Emit): Pass false to
11905 EmitThis (we do not need the address).
11907 * codegen.cs (EmitThis): it needs to know whether we need the
11908 address of `this' or not. This is used by value types.
11910 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11911 every other call passes false.
11913 2006-01-12 Raja R Harinath <rharinath@novell.com>
11916 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11918 * expression.cs (Invocation.OverloadResolve): Update.
11919 (Invocation.DoResolve): Avoid double resolution of invocation.
11921 2006-01-11 Raja R Harinath <rharinath@novell.com>
11924 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11925 unary negation of floating point types as 0-expr; negation cannot
11926 overflow in floating point types.
11929 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11930 on operands of 'void' type.
11933 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11934 and ExclusiveOr for boolean constants too.
11936 2006-01-09 Raja R Harinath <rharinath@novell.com>
11939 * expression.cs (Invocation.OverloadResolve): Replace reflected
11940 override methods with their base virtual methods, rather than
11941 skipping over them.
11942 * typemanager.cs (TypeManager.GetOverride): New.
11944 2006-01-05 Jb Evain <jbevain@gmail.com>
11946 * class.cs (Property.Define, Indexer.Define): do not tag the
11947 properties as SpecialName | RTSpecialName.
11949 2006-01-04 Miguel de Icaza <miguel@novell.com>
11951 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11952 doing a low-level comparission of parameter types. It was lacking
11953 a check for __argslist.
11955 2005-12-30 Miguel de Icaza <miguel@novell.com>
11957 * expression.cs (ParameterReference.DoResolveBase): Allow
11958 reference parameters if they are local to this block.
11960 This allows the ref and out parameters of a delegate to be used in
11961 an anonymous method, for example:
11963 delegate void set (out int x);
11965 set s = delegate (out int x){
11969 This is used by functionality introduced late in the C# language.
11971 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11972 method that take ref and out parameters.
11974 Fixes #77119 which was a late change in the spec.
11976 2005-12-23 Miguel de Icaza <miguel@novell.com>
11978 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11979 parent if its the same scope. Fixes #77060.
11981 2005-12-21 Miguel de Icaza <miguel@novell.com>
11983 * driver.cs: Report the case of no source files and no -out:
11986 2005-12-20 Raja R Harinath <rharinath@novell.com>
11989 * expression.cs (ComposedCast.GetSignatureForError): Define.
11991 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11995 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11996 ListDictionary, to contain the ExternAliasEntry entries (in
11997 addition to the NamespaceEntry.aliases hashtable). This field is
11998 shared between the original entry and its doppelganger (bodyless
12000 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
12001 extern_aliases field.
12002 (NamespaceEntry.Lookup): Move the IsImplicit check after the
12003 lookup in extern_aliases.
12005 2005-12-16 Raja R Harinath <rharinath@novell.com>
12008 * class.cs (TypeContainer.Mark_HasEquals): New.
12009 (TypeContainer.Mark_HasGetHashCode): New.
12010 (ClassPart): Override them.
12011 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
12014 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
12015 'parent' argument to the base constructor.
12017 Remove all mention of TypeContainer from decl.cs.
12018 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
12019 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
12020 (DeclSpace.DeclSpace): Likewise.
12021 (DeclSpace.DefineMembers): Remove unused argument.
12022 * cs-parser.jay (pop_current_class): Update to changes. Simplify
12023 debugging check -- we don't care if the debug code throws an
12024 InvalidCastException instead of an InternalErrorException.
12025 * class.cs (TypeContainer.DefineMembers): Update to changes.
12026 (TypeContainer.DoDefineMembers): Likewise.
12027 (TypeContainer.GetMethods): Likewise.
12028 (PropertyMember.Define): Likewise.
12029 (MemberBase.Parent): New property that forwards to
12030 MemberCore.Parent, but ensures that we get a TypeContainer.
12031 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
12032 (RootContext.PopulateTypes): Likewise. Remove special case code
12033 for !RootContext.StdLib: DefineMembers is idempotent.
12035 2005-12-14 Miguel de Icaza <miguel@novell.com>
12037 * convert.cs (ExplicitConversionCore): Check the return value from
12038 ExplicitConversionCore which can return null on failure. Fixes #76914
12040 2005-12-13 Marek Safar <marek.safar@seznam.cz>
12042 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
12044 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
12046 * doc.cs : The search for referenced namespace was insufficient to
12047 get global one as it used to do. Fixed bug #76965.
12049 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12051 * doc.cs : check name in cref in the last phase that whether it is
12054 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12056 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12059 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12061 * doc.cs : so it turned out that we cannot skip override check for
12062 interface members. Fixed bug #76954.
12064 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12066 * cs-tokenizer.cs : fixed bug #75984:
12067 - #warning and #error should not be handled when the source line
12069 - #line is not checked strictly when the source line is disabled.
12070 - #define and #undef is on the other hand checked strictly at any
12073 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12075 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12078 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12080 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12082 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12083 event initializers.
12084 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12085 (FieldBase.Initializer): Initializer is now optional.
12086 (EventField.Define): Only event field can have initializer.
12088 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12090 * const.cs (Const): Reuse initializer.
12092 * cs-parser.jay: Updated after FieldBase changes.
12093 Added current_array_type to simplify array initializers.
12095 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12097 * expression.cs, iterators.cs: Updated.
12099 * namespace.cs (NamespaceEntry): Made UsingFound private.
12101 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12103 * parameterCollection.cs: Obsolete, removed.
12104 * parser.cs: Obsolete, removed.
12106 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12109 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12111 * enum.cs (Enum.Define): Set obsolete context here.
12113 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12116 - FindDocumentedMember() now expects 1) paramList as null
12117 when "we don't have to check the number of parameters" and
12118 2) Type.EmptyTypes when "there is no arguments".
12119 - Introduced FoundMember struct to hold the exact type which was
12120 used to find the documented member (the above change broke
12121 test-xml-044; it might be better just to use DeclaringType than
12122 what MS does, like this change does, but it depends on usage.)
12124 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12126 * doc.cs : documented member might be from DeclaringType for nested
12127 types. Fixed bug #76782.
12129 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12131 * anonymous.cs: Have the param code handle leaving copies on the
12132 stack etc. Allows anonymous params to take part in the assignment
12133 code (++, +=, etc). Fixes bug #76550
12135 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12136 it down to the anon code.
12138 * iterators.cs: Use dummy var here
12140 * codegen.cs: Handle new vars
12142 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12145 * class.cs (MethodData.Define): Set proper Obsolete context.
12147 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12149 (FieldExpr.DoResolve): Ditto.
12151 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12154 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12155 parent is not obsolete.
12157 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12159 * doc.cs : (FindDocumentedMember) find parameterless members first
12160 and get CS0419 in the early stage. Fixed first case of bug #76727.
12162 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12165 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12166 no error was reported.
12168 *expression.cs (Binary.DoResolve): left can be null.
12170 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12173 * class.cs (MethodData.Emit): Parameters should be labeled first.
12175 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12178 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12180 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12182 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12184 * class.cs (MethodCore): Parameter clean up.
12185 (IMethodData): Added ParameterInfo.
12186 (MethodData): Parameter clean up.
12187 (Indexer.Define): Parameter clean up.
12199 * typemanager.cs: Parameter clean up.
12201 * delegate.cs (Define): Get rid of duplicated code.
12203 * expression.cs (ParameterReference): Removed useless parameters
12205 (Invocation): Ditto.
12207 * parameter.cs (ParamsParameter): New class, params specialization.
12208 (ArglistParameter): Attemp to separate arglist.
12209 (Parameter): Refactored to be reusable and faster.
12210 (Parameter.Modifier): Made understandable.
12211 (Parameters): Changed to be used as a class for `this' assembly
12212 parameters. Refactored to use new specialized classes.
12214 * support.cs (ParameterData): Added Types property.
12215 (InternalParameters): Deleted.
12217 2005-08-20 Martin Baulig <martin@ximian.com>
12219 Merging this patch from GMCS to fix #75867.
12221 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12222 scope if we don't already have it.
12224 2005-11-17 Martin Baulig <martin@ximian.com>
12227 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12228 inherit the scope from our parent. Fixes #76653.
12230 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12232 * doc.cs : the previous patch does not actually fix the bug.
12233 PropertyInfo override check is now implemented and really fixed it.
12234 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12236 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12238 * doc.cs : apply "override filter" also to properties.
12241 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12243 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12244 no need to check overrides. For classes, omit those results from
12245 interfaces since they must exist in the class. Fixed bug #76726.
12247 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12249 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12250 with different parameters. Fixed the second problem in #76685.
12252 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12254 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12255 get expected 'protected' access in CheckValidFamilyAccess()).
12258 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12260 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12261 Fixed bug #76705. CS1569 was incorrectly commented out.
12263 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12265 * doc.cs : use Invocation.IsOverride() to do real override check.
12266 * expression.cs : made Invocation.IsOverride() internal.
12268 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12270 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12271 TypeBuilder.FindMembers() and filter overriden base members out.
12274 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12276 * doc.cs : ref/out parameters are represented as '@' (instead of
12277 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12279 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12281 * doc.cs : when there was no '.' in cref to methods in doc comment,
12282 then parameters were missing in the output. Fixed bug #76691.
12284 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12286 * driver.cs : don't output docs when there is an error.
12289 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12292 Now it should detect indexers. Fixed primary concern in bug #76685.
12293 Fixed CS0419 message to not show the identical member signature in
12296 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12298 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12299 instead of Type.FindMembers() since it does not handle events.
12302 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12304 * codegen.cs: Fixed typo (speficied -> specified).
12306 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12309 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12311 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12313 * attribute.cs: Changed error message.
12315 * cs-tokenizer.cs: One more check.
12317 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12319 * statement.cs (Block.Resolve): Ignore empty statement.
12321 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12323 * report.cs: Made error/warning methods more strict to avoid
12326 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12327 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12328 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12329 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12331 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12333 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12334 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12336 * class.cs (TypeContainer.IsComImport): New property.
12337 (Constructor.Define): Create proper ctor for ComImport types.
12339 * expression.cs (New.CheckComImport): Fixed.
12341 2005-11-07 Miguel de Icaza <miguel@novell.com>
12343 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12344 that a parameter has been captured does not mean that we do not
12345 have to do the rest of the processing. This fixes the second part
12346 of #76592. If there was another anonymous method capturing
12347 values in the past, the Scope would never be set for the second
12348 method that captured the same parameter.
12350 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12351 properly manipulate the stack. Second part of fix for #76592.
12353 * expression.cs (New): Add support for invoking "new" on
12354 interfaces that have been flagged with the ComImport attribute and
12355 the CoClass. Fixes #76637
12357 * statement.cs (Try.DoEmit): When a variable is captured, do not
12358 try to emit the vi.LocalBuilder variable as it has been captured.
12359 Create a temporary variable and store the results on the
12360 FieldBuilder. Fixes #76642
12362 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12364 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12366 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12368 * expression.cs (Binary.DoResolve): Added && optimalization.
12370 * typemanager.cs (AddUserType): Removed useless argument.
12372 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12374 * statement.cs (Block.variables): Uses ListDictionary.
12376 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12379 * class.cs (PartialContainer.EmitType): Customized to emit
12380 security attributes.
12381 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12382 for partial classes.
12384 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12387 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12388 access has to be fixed.
12390 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12392 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12395 * ecore.cs (NullCast.Reduce): Implemented.
12397 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12400 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12402 (Foreach.Resolve): Catch null properly.
12404 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12406 * cs-tokenizer.cs: Warning text fix.
12408 * driver.cs: AllWarningNumbers exposed on public interface.
12410 * report.cs (): Reviewed warning numbers.
12411 (IsValidWarning): Use binary search.
12413 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12415 * driver.cs: Implemeted resource visibility.
12416 (Resources): New class for code sharing between /res: and
12419 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12422 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12425 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12428 * ecore.cs (NullCast): Child is contant only.
12430 * literal.cs (NullLiteral.Reduce): null can be converted to any
12433 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12435 * driver.cs: Use Encoding.Default as default code page instead
12438 2005-10-27 Raja R Harinath <rharinath@novell.com>
12441 * expression.cs (Invocation.Error_InvalidArguments): Handle
12442 __arglist parameters.
12443 (Invocation.VerifyArgumentsCompat): Likewise.
12444 * support.cs (ReflectionParameters.GetSignatureForError): Print
12445 __arglist parameters.
12446 (InternalParamters.GetSignatureForError): Likewise.
12447 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12449 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12451 * attribute.cs (GetPropertyValue): Made public.
12453 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12455 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12457 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12460 * driver.cs: Reflect method name change.
12462 * statement.cs (Try.Resolve): Warn when try has both general
12463 exception handlers.
12465 * typemanager.cs: runtime_compatibility_attr_type new predefined
12468 2005-10-26 Raja R Harinath <harinath@gmail.com>
12471 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12472 treat it as an empty parameter list.
12474 2005-10-26 Raja R Harinath <rharinath@novell.com>
12477 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12478 ResolveAsTypeStep silent.
12479 * statement.cs (Block.AddConstant): Mark block as used.
12480 (Block.ResolveMeta): Avoid piling on error messages
12481 if a constant initializer resolution fails.
12483 2005-10-25 Raja R Harinath <rharinath@novell.com>
12485 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12487 (NamespaceEntry.VerifyAllUsing): New.
12488 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12489 behaviour. Delegates actual resolution of alias to ...
12490 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12491 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12493 * driver.cs (Driver.MainDriver): Update.
12495 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12496 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12498 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12500 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12501 RootNamespace.DefineNamespacesForAll.
12503 2005-10-24 Raja R Harinath <harinath@gmail.com>
12505 * typemanager.cs (assemblies, external_aliases, modules)
12506 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12507 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12508 overhead. Move resposibility ...
12509 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12510 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12512 2005-10-23 Raja R Harinath <harinath@gmail.com>
12514 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12515 cached_namespaces. Improve usage.
12516 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12517 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12518 Move from GlobalRootNamespace and simplify.
12519 (RootNamespace.Global): Make instance variable.
12520 (RootNamespace.RootNamespace): Add "alias name" parameter.
12521 (GlobalRootNamespace): Simplify drastically.
12522 (Namespace.Lookup): Don't use GetNamespace.
12523 * typemanager.cs (GetRootNamespace): Rename from
12524 ComputeNamespaceForAlias.
12525 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12527 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12529 * anonymous.cs (AnonymousContainer): Don't crash when container
12532 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12534 * expression.cs (Binary.DoResolve): Warn when comparing same
12537 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12540 * expression.cs (Binary.DoResolve): It looks like there are no
12541 convetsion rules in enum context.
12543 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12545 Add support for extern alias qualifiers.
12546 * typemanager.cs: Move some LookupTypeReflection code
12547 to namespace.cs, to have cleaner code. Added some methods
12548 to help us keep track of the extern aliased references.
12549 * driver.cs: Add suport for extern alias assemblies on command
12550 line and check for their warnings/errors. Also keep track of the
12551 extern aliased assemblies.
12552 * namespace.cs: Move the global functionality of Namespace
12553 to GlobalRootNamespace/RootNamespace. Now the global namespace
12554 is GlobalRootNamespace.Globa. Also the code moved from
12555 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12556 Finally added LocalAliasEntry (AliasEntry before) and
12557 ExternAliasEntry, to handle alias statements.
12558 * cs-parser.jay: Add support in the grammar for extern alias
12560 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12561 Update callings to Namespace (now in GlobalRootNamespace).
12563 2005-10-18 Raja R Harinath <rharinath@novell.com>
12566 * class.cs (TypeContainer.DefineType): Move updating of
12567 topological sort earlier in the code.
12568 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12570 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12573 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12575 * constant.cs (Constant.TryReduce): Moved from Cast class.
12576 (Reduce): Made little bit more OO and fixed missing conversions.
12578 * ecore.cs (Reduce): Implemented.
12579 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12581 * literal.cs (Reduce): Implemented.
12583 * class.cs: Reverted Miguel's wrong commit.
12585 2005-10-14 Miguel de Icaza <miguel@novell.com>
12587 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12589 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12591 * cs-parser.jay, expression.cs : CS0214 was missing error location
12592 for constants. Fixed bug #76404.
12594 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12597 * convert.cs (ExplicitConversionCore): Fixed object->enum
12600 2005-10-10 Raja R Harinath <rharinath@novell.com>
12602 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12603 InstanceExpression.
12604 (PropertyExpr.EmitCall): Likewise.
12605 * expression.cs (Invocation.EmitArguments): Handle case where
12607 (Invocation.EmitCall): Avoid allocating temporary variable if
12608 there are no arguments.
12610 2005-10-07 Raja R Harinath <rharinath@novell.com>
12613 * convert.cs (ImplicitConversionStandard): Move conversion of
12614 void* to arbitrary pointer types ...
12615 (ExplicitConversionStandard): .. here.
12616 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12617 error to always print typenames.
12619 2005-10-07 Raja R Harinath <rharinath@novell.com>
12621 * convert.cs (GetConversionOperator): Rename from
12622 GetConversionOperators. Move operator selection code from ...
12623 (UserDefinedConversion): ... here.
12625 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12627 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12630 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12632 * assign.cs (Assign.DoResolve): Error method changed.
12634 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12636 * const.cs (ResolveValue): Reset in_transit immediately.
12638 * constant.cs: Error method changed.
12640 * convert.cs: Removed useless location parameter.
12641 (ExplicitNumericConversion): Don't do double enum check.
12642 (ExplicitConversionCore): Renamed from ExplicitConversion.
12643 (ExplicitUnsafe): Extracted from ExplicitConversion.
12644 (ExplicitConversion): Uses for error reporting.
12646 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12648 (ResolveBoolean): Uses common error method.
12649 (CastToDecimal): Get rid of ec.
12650 (CastFromDecimal): Optimized.
12651 (ConvCast): Get rid of ec.
12653 * enum.cs (ResolveValue): Reset in_transit immediately.
12654 (Emit): Return after first error.
12656 * expression.cs: Convert changes.
12658 * literal.cs: Error method changed.
12660 * statement.cs: Error method changed.
12662 2005-10-03 Raja R Harinath <rharinath@novell.com>
12664 * support.cs (SeekableStreamReader.Position): Don't error out when
12665 the requested position is just beyond the end of the current
12668 2005-09-28 Raja R Harinath <rharinath@novell.com>
12670 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12671 try to keep in sync with the byte count of the underlying Stream.
12672 However, this limits us to a window size of 2048 characters: i.e.,
12673 the maximum lookahead of our lexer/parser can be 2048 characters.
12675 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12678 * driver.cs: Fix compilation files with full root path.
12680 2005-09-25 Miguel de Icaza <miguel@novell.com>
12682 * report.cs (SymbolRelatedToPreviousError): Format the output so
12683 it does not use an open parenthesis that is never closed.
12685 * driver.cs: Follow coding guidelines
12687 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12690 * const.cs (Const.ResolveValue): Check for assigning non-null
12691 value to reference type.
12693 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12695 * anonymous.cs: Implemented ExprClassName.
12697 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12700 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12703 * class.cs (StaticClass.DefineContainerMembers): Report protected
12706 * codegen.cs: if(ed) PRODUCTION.
12708 * convert.cs (Error_CannotImplicitConversion): Better error
12711 * cs-parser.jay: More error checks.
12713 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12715 * driver.cs (CSCParseOption): Enabled wrong option check.
12717 * ecore.cs (Expression.ExprClassName): Turned to property.
12718 (MemberExpr.CheckIntermediateModification): For checking boxed
12719 value types modification.
12721 * statement.cs (Fixed.Resolve): Expression type must be
12722 convertible to fixed type.
12723 (CollectionForeach.GetEnumeratorFilter,TryType):
12724 Small refactoring for easier error checking.
12726 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12728 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12731 * class.cs (GeneratedBaseInitializer): New class for customization
12732 compiler generated initializers.
12733 (MemberBase.DoDefine): Check Obsolete attribute here.
12734 (FieldMember.DoDefine): Ditto.
12736 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12739 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12740 (MemberCore.GetObsoleteAttribute): Removed argument.
12741 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12742 (MemberCore.CheckObsoleteType): New helper.
12746 * statement.cs: Updates after MemberCore changes.
12748 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12749 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12751 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12752 obsolete attribute for compiler construct.
12753 (As.DoResolve): Cache result.
12755 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12757 2005-09-26 Raja R Harinath <rharinath@novell.com>
12760 * expression.cs (This.VerifyFixed): In a value type T, the type of
12761 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12762 value type R, 'this' is treated as a value parameter.
12764 2005-09-22 Miguel de Icaza <miguel@novell.com>
12766 * statement.cs (Lock): Use the TemporaryVariable class instead of
12767 manually using local variables as those do not work when variables
12770 * ecore.cs: Moved the TemporaryVariable class from being a nested
12771 class inside Foreach to be a public class that can be employed in
12774 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12776 * cs-parser.jay: interface_accessors replaced by
12777 accessor_declarations.
12779 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12782 * statement.cs (GotoCase.Resolve): Convert null constant to
12784 (SwitchLabel.ResolveAndReduce): Ditto.
12785 (SwitchLabel.NullStringCase): Custom null stamp.
12786 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12788 typemanager.cs (CSharpSignature): Don't skip first argument
12791 2005-09-18 Miguel de Icaza <miguel@novell.com>
12793 * driver.cs: Set InEmacs based on the environment variable EMACS.
12795 * location.cs (InEmacs): in this mode, do not report column
12796 location as it confuses Emacs.
12798 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12800 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12801 expression.cs, iterators.cs, literal.cs: Store constants and
12804 * class.cs (MemberBase.ShortName): Pass location.
12806 * cs-parser.jay: Some location fixes.
12808 * ecore.cs (Expression.Location): Made virtual.
12810 2005-09-05 Miguel de Icaza <miguel@novell.com>
12812 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12813 if the underlying types are the same, otherwise we need to produce
12814 code that will do the proper cast.
12816 This was exposed by Marek's constant rewrite which produced
12817 invalid code for the call site:
12819 enum X : long { a }
12820 void Method (X v) {}
12824 This fixes test-49.cs
12826 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12828 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12829 Type/Object should be allowed as well. Fixed bug #75968.
12831 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12833 * expression.cs : (Binary.DoResolve): when one is enum constant and
12834 another is constant 0, then return enum one *as enum type*.
12837 2005-09-02 Raja R Harinath <rharinath@novell.com>
12839 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12843 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12844 flow-branching for LocalVariableReferences in case we were invoked
12845 from a MemberAccess.
12846 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12848 (LocalVariableReference.DoResolveBase): ... this.
12849 (MemberAccess.Resolve): Do the check that was disabled during
12852 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12855 (PartialContainer.Create): check abstract/sealed/static strictly
12856 but abstract/sealed can exist only at one side. Fixed bug #75883.
12858 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12861 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12862 specified, don't default to UnmanagedType.I4.
12864 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12866 * expression.cs : conditional operator should check possibly
12867 incorrect assign expression. Fixed bug #75946.
12869 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12871 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12872 Reverting the change. gmcs is much complex than mcs on this matter.
12874 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12876 * cs-tokenizer.cs : To read another token ahead of the actual
12877 consumption, use new SavedToken and cache token instead of moving
12878 back the stream with SeekableStreamReader (it seemed problematic).
12880 driver.cs : Thus use StreamReader directly.
12881 * support.cs : Thus removed SeekableStreamReader.
12883 2005-08-30 Raja R Harinath <rharinath@novell.com>
12886 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12887 (ScopeInfo.EmitScopeType): Use it to construct field names from
12888 names of captured locals.
12891 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12892 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12893 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12894 (ExplicitConversion): Remove enum cases already handled by
12895 implicit conversion. Move implicit conversion check to the beginning.
12896 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12897 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12898 Don't treat System.Enum as a struct.
12900 2005-08-30 Jb Evain <jbevain@gmail.com>
12902 * attribute.cs: handles as expression in parameters.
12904 2005-08-30 Raja R Harinath <rharinath@novell.com>
12907 * class.cs (TypeContainer.VerifyClsName): Don't use a
12908 PartialContainer when verifying CLS compliance.
12909 (AbstractPropertyEventMethod): Set Parent here, ...
12910 (PropertyMethod): ... not here.
12912 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12914 * attribute.cs : escaped attribute name should not be allowed to be
12915 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12917 2005-08-29 Raja R Harinath <rharinath@novell.com>
12920 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12921 when converting a long constant to unsigned long.
12922 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12923 detect where IsApplicable and VerifyArgumentsCompat disagree.
12925 2005-08-29 Raja R Harinath <rharinath@novell.com>
12926 and Carlos Alberto Cortez <carlos@unixmexico.org>
12929 * class.cs (TypeContainer.CanElideInitializer): New helper.
12930 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12931 can safely emitting the initializer of a field.
12933 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12935 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12936 allowed inside a switch (without loop). Fixed bug #75433.
12938 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12940 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12941 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12943 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12945 * driver.cs : kinda reverting the default encoding changes (not exact
12946 revert since I noticed that "codepage:reset" might not work fine).
12948 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12950 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12951 Location. Now getter and setter store location correctly.
12952 (errors/cs0111-12.cs now reports the expected location.)
12954 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12956 * driver.cs : Use default encoding on the environment.
12957 Removed (now that) extra parameter for SeekableStreamReader.
12958 * support.cs : (SeekableStreamReader) third .ctor() argument for
12959 StreamReader is not required (always true). preamble size could
12960 be acquired in simpler and safe way.
12962 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12964 * cs-parser.jay: report CS0642 at warning level 3
12965 and report CS0642 for an if else statement also
12966 fixes bug #74745. Patch by John Luke (and a bit
12968 Removed extra CS0642 warning check for "while",
12970 * statement.cs: In Block.Resolve(), CS0642 check
12971 is reimplemented to check a sequence of an empty
12972 statement and a block.
12974 Both fix bug #66777.
12976 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12978 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12979 detection until I fix it.
12981 * cs-tokenizer.cs: Changed error message.
12983 * cs-parser.jay: Fixed 2 error locations.
12985 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12986 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12989 * enum.cs (GetSignatureForError): Fixed.
12991 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12995 * typemanager.cs (RegisterProperty): Removed.
12997 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12999 2005-08-24 Raja R Harinath <rharinath@novell.com>
13002 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
13003 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
13005 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13007 * expression.cs : tiny fix is required for not warning positive ulong.
13010 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13012 * expression.cs : add CS0652 check for constant and integral
13013 expression. Fixed bug #53974.
13015 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13017 * expression.cs : in DoNumericPromotions(), check if there is implicit
13018 conversion overload for string (to check CS0034). Fixed bug #52492.
13020 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13022 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
13024 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13026 * ecore.cs : report location when it is *not* Null.
13028 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13034 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
13035 correctly. Fixed bug #75721.
13037 2005-08-23 Raja R Harinath <rharinath@novell.com>
13039 * support.cs (SeekableStreamReader.Position): Avoid an expensive
13040 loop that performs 'min (pos, char_count)'.
13043 * expression.cs (Unary.ResolveOperator): Don't discard implicit
13044 converted value in Operator.OnesComplement.
13046 2005-08-22 Ben Maurer <bmaurer@ximian.com>
13048 * anonymous.cs: If the anon method is pulled into a helper class,
13049 it needs to be `internal' not `private'. Fixes runtime behavior on
13052 2005-08-20 Martin Baulig <martin@ximian.com>
13054 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13055 scope if we don't already have it.
13057 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13058 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13061 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13064 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13065 is a partial class.
13067 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13069 The big constants rewrite
13070 Fix #75746, #75685 and more
13071 As a side effect saved 1MB for MWF ;-)
13073 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13074 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13075 enum based for corlib compilation.
13077 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13080 * class.cs (FixedField.Define): Use ResolveAsConstant.
13082 * const.cs (IConstant): Interface constants and enums.
13083 (Const.ResolveValue): New method for constant resolvning.
13084 (ExternalConstant): Constants from imported assemblies.
13086 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13087 conversion; like enums.
13088 (Constant.ToType): Converts this constant to different type.
13089 (Constant.Increment): Adds 1.
13091 * convert.cs (ImplicitConversionRequired): Simplified.
13093 * cs-parser.jay: Create EnumMember directly.
13095 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13097 * doc.cs (GenerateEnumDocComment): Removed.
13099 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13100 (ConvertIntLiteral): Removed.
13101 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13103 * enum.cs (EnumMember): Implement IConstant.
13104 (Enum.IsValidEnumConstant): Removed.
13105 (Enum.GetNextDefaultValue): Removed.
13106 (Enum.FindMembers): Updated.
13107 (Enum.GenerateDocComment): Iterate enum members.
13109 * expression.cs (Cast.TryReduce): Handle enums correctly.
13110 (New.Constantify): Made public.
13111 (MemberAccess.DoResolve): Removed contant specific if(s).
13113 * literal.cs (NullLiteral): Implement new abstract methods.
13115 * statement.cs (GotoCase.Resolve): Use new constant methods.
13116 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13118 * typemanager.cs (LookupEnum): Removed.
13119 (IsEnumType): Fixed to work with corlib.
13120 (RegisterConstant): Removed.
13121 (LookupConstant): Removed.
13122 (GetConstant): Changed to work with IConstant.
13124 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13126 * location.cs : Fixed overflown (>255) column number.
13128 2005-08-03 Raja R Harinath <rharinath@novell.com>
13130 First cut of the qualified-alias-member feature.
13131 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13133 * cs-parser.jay (DOUBLE_COLON): New token.
13134 (namespace_or_type_name): Add rule for recognizing
13135 qualified-alias-members.
13136 (primary_expression): Likewise.
13137 (element_access): Allow QualifiedAliasMember as a possible
13138 type-bearing expression.
13139 (local_variable_type, local_variable_pointer_type): Likewise.
13140 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13141 aliases in the current and enclosing namespace declarations.
13142 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13143 * decl.cs (MemberName.is_double_colon): New.
13144 (MemberName.MemberName): Add new constructor for alias-member.
13145 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13146 * expression.cs (QualifiedAliasMember): New expression type.
13148 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13150 * location.cs : it borked when no argument was specified.
13152 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13154 * location.cs : tiny ToString() format fix.
13156 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13158 * statement.cs : oops, it was missing.
13160 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13162 A set of fixes for precise line/column location.
13165 "token" field now holds a file/line "delta", a line number offset
13166 from the segment, and a column number. See also:
13167 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13168 December/009508.html
13169 Removed static IsNull. Use instance IsNull property instead.
13170 * cs-tokenizer.cs :
13171 For some tokens it stores Location. For Identifier it stores
13172 LocatedToken which is a pair of string name and location.
13173 Column numbers are adjusted only at getChar().
13175 Use Location.ToString() for reporting (it now contains column).
13177 Largely modified to use LocatedToken instead of
13178 string (IDENTIFIER), and to acquire Location from some tokens.
13179 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13180 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13182 Now MemberName holds Location. DeclSpace.ctor() receives Location
13183 as a parameter. Removed extra parameters to all derived classes.
13184 Replaced Location.IsNull() with instance property.
13185 * assign.cs, expression.cs :
13186 Added .ctor() overload that omits Location.
13188 Added "nameEscaped" flag that indicates the identifier was escaped
13189 in the source file. This fixes bug #57047.
13191 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13193 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13194 New method, looking for lo-case imported cls type.
13196 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13199 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13201 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13203 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13204 all_imported_types.
13205 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13207 Optimized to save 3.5 MB for SWF compilation.
13209 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13211 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13212 (PartialContainer.Create): Moved logic AddToContainer.
13213 (PartialContainer.MarkForDuplicationCheck): Shares name.
13215 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13218 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13220 (Namespace.GetSignatureForError): New method.
13222 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13223 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13225 2005-08-01 Raja R Harinath <rharinath@novell.com>
13228 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13229 member lookup rather than qualifier_type, since qualifier_type can
13232 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13234 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13237 2005-07-31 Miguel de Icaza <miguel@novell.com>
13239 * statement.cs: Copy the local exception into the exception
13240 captured local. Fixes 75674
13242 2005-07-31 Raja R Harinath <harinath@gmail.com>
13245 * expression.cs (Invocation.OverloadResolve): Don't report error
13246 CS1501 if error CS1502 has been reported.
13247 (New.DoResolve): Delegate CS1501 reporting to
13248 Invocation.OverloadResolve.
13251 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13252 invariant-meaning-in-block property in an enclosing block if
13255 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13257 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13258 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13259 (Switch.CheckSwitch): Just save 50kb for SWF.
13261 2005-07-27 Martin Baulig <martin@ximian.com>
13263 * anonymous.cs (CaptureContext.AddField): Added
13264 `AnonymousContainer am' argument; compute its toplevel scope if
13265 it's not already computed. Fixes #75649.
13267 2005-07-26 Raja R Harinath <rharinath@novell.com>
13270 * class.cs (Constructor.Emit): Reset block to null if the block
13273 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13275 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13277 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13279 * class.cs (MethodData.Define): Check whether accessor implementing
13280 interface is public.
13282 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13284 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13287 * namespace.cs (LookupType): Moved same type check to...
13289 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13290 with the same name.
13292 2005-07-21 Raja R Harinath <rharinath@novell.com>
13294 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13295 already found a typebuilder.
13296 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13297 MemberNames, not strings.
13299 * const.cs (Error_ExpressionMustBeConst):
13300 Rename from Error_EpressionMustBeConst.
13301 * const.cs, class.cs, statement.cd: Update.
13303 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13307 * const.cs (Const.LookupConstantValue): Report missing contant expression
13309 (Error_EpressionMustBeConstant): Only one error method.
13311 * class.cs, statement.c: Updated.
13313 2005-07-20 Raja R Harinath <rharinath@novell.com>
13315 * statement.cs (Block.Flags): Add back HasVarargs.
13316 (Block.flags): Make protected.
13317 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13319 * typemanager.cs (types, typecontainers, user_types): Remove.
13320 (UserTypes, TypeContainers): Likewise.
13321 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13322 (CleanUp, Reset): Update.
13323 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13324 (GetNestedType): Use Type.GetNestedType.
13325 (CoreLookupType): Take two arguments, the namespace and the
13326 basename of the type. Update to use the Namespace.Lookup
13328 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13329 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13330 string concatenation and substring matches.
13331 * class.cs, enum.cs, delegate.cs: Update to changes.
13333 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13335 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13336 Expression and made virtual.
13338 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13339 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13341 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13343 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13346 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13349 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13352 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13353 AssemblyCultureAttribute is not used on executable.
13356 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13358 2005-07-16 Raja R Harinath <rharinath@novell.com>
13361 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13362 New. Reports CS0252/CS0253.
13363 Mostly taken from preliminary patch by Duncak Mak.
13364 (Binary.DoResolveOperator): Store results of operator lookup.
13365 Use them to detect if we need to warn about unintended reference
13368 2005-07-15 Raja R Harinath <rharinath@novell.com>
13371 * namespace.cs (Namespace.Lookup): Add back location parameter.
13372 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13373 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13375 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13376 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13377 (Namespace.LookupType): ... this.
13378 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13380 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13381 purported to handle pointers.
13382 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13385 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13387 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13390 2005-07-15 Raja R Harinath <rharinath@novell.com>
13392 * namespace.cs (Namespace.Lookup): Drop location parameter.
13393 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13394 (NamespaceEntry.Lookup): ... this.
13395 (NamespaceEntry.Error_AmbiguousTypeReference):
13396 Move here from DeclSpace.
13397 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13399 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13400 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13401 Move to NamespaceEntry.
13402 * delegate.cs, expression.cs: Update to changes.
13404 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13406 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13407 CheckAttributeType and refactored.
13408 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13409 ResolveAsTypeTerminal error handling.
13410 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13412 (GetSignatureForError): Print errors in same way.
13415 * codegen.cs: Reflect attribute GetSignatureForError change.
13418 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13420 * namespace.cs (UsingEntry): Refactored to make fields private.
13423 statement.cs: Error_UnexpectedKind has extra parameter.
13425 2005-07-14 Raja R Harinath <rharinath@novell.com>
13427 * ecore.cs (IAlias): Remove.
13428 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13429 that implement the interface.
13430 * namespace.cs (Namespace): Likewise.
13431 (Namespace.declspaces): Renamed from 'defined_names'.
13432 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13433 DeclSpace instead of an IAlias.
13434 * tree.cs (Tree.AddDecl): Update.
13436 2005-07-12 Raja R Harinath <rharinath@novell.com>
13438 * statement.cs (Block.Flags); Remove HasVarargs.
13439 (Block.HasVarargs): Move to ToplevelBlock.
13440 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13441 (Block.Variables): Make protected. Initialize variable hashtable
13443 (Block.AddVariable): Update.
13444 (Block.Resolve): Update to changes.
13445 (ToplevelBlock.HasVarargs): New boolean.
13446 (ToplevelBlock.ThisVariable): Move here from Block.
13447 (ToplevelBlock.AddThisVariable): Likewise.
13448 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13449 * expression.cs (This.ResolveBase): Update to changes.
13450 (ArglistAccess.DoResolve): Likewise.
13452 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13455 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13457 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13458 not used and not used & assigned.
13459 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13461 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13464 * expression.cs (Is.DoResolve): null is never provided type.
13466 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13469 * cs-parser.jay: Less strict event error rule to catch more errors.
13471 2005-07-08 Martin Baulig <martin@ximian.com>
13473 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13474 gettter (allowed) or setter (not allowed).
13476 * class.cs (Accessor): Implement IIteratorContainer.
13477 (Accessor.Yields): New public field.
13478 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13479 per-accessor basis.
13482 (get_accessor_declaration, set_accessor_declaration): Set the
13483 `yields' flag on the accessor, not the property.
13484 (property_declaration): Do the iterators check on a per-accessor
13485 basis and not for the whole property.
13487 2005-07-08 Martin Baulig <martin@ximian.com>
13489 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13490 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13492 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13495 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13496 (ExtractSecurityPermissionSet): Cope with self referencing security
13497 attributes properly.
13499 * driver.cs (SetOutputFile): Made public property OutputFile.
13501 2005-07-07 Raja R Harinath <rharinath@novell.com>
13504 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13505 has_nonstatic_fields. Make into a FieldBase pointer.
13506 (TypeContainer.AddField): Add CS0282 check.
13507 (TypeContainer.EmitType): Update.
13509 2005-07-06 Miguel de Icaza <miguel@novell.com>
13511 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13512 compare if they start with __.
13514 2005-07-06 Raja R Harinath <rharinath@novell.com>
13516 * statement.cs (Switch.SwitchGoverningType): Only look at
13517 UserCasts that don't need implicit standard conversions to one of
13518 the allowed switch types (Fixes test-322.cs).
13519 (LocalInfo.Resolve): Re-enable sanity-test.
13521 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13523 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13525 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13527 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13529 2005-07-06 Raja R Harinath <rharinath@novell.com>
13532 * ecore.cs (SimpleName.GetSignatureForError): Add.
13533 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13534 (MemberAccess.GetSignatureForError): Add.
13536 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13538 The big error and warning messages review.
13568 * typemanager.cs: Updated.
13570 * class.cs: (MethodCore.SetYields): Moved here to share.
13571 (PropertyMethod.Define): Moved iterator setup here.
13573 * iterators.cs: Add orig_method to have full access to parent
13576 2005-07-05 Raja R Harinath <rharinath@novell.com>
13578 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13579 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13580 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13581 variable of struct type.
13582 * expression.cs (Unary.ResolveOperator): Update to change.
13583 (Indirection.VerifyFixed): Likewise.
13584 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13585 (ParameterReference.VerifyFixed): Value parameters are fixed.
13586 (This.VerifyFixed): Treat 'this' as a value parameter.
13587 * statement.cs (LocalInfo.IsFixed): Remove.
13589 2005-07-01 Martin Baulig <martin@ximian.com>
13591 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13592 `ec.EmitThis ()' to get the correct scope.
13594 2005-07-01 Martin Baulig <martin@ximian.com>
13596 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13597 instance is a ParameterReference; fixes #75299.
13599 2005-07-01 Martin Baulig <martin@ximian.com>
13601 Reverted Marek's latest patch (r46725):
13602 - it contains structural changes which are neither mentioned in
13603 the ChangeLog nor explained anywhere; for example the additional
13604 argument of EmitContext's and Iterator's .ctor's and the
13605 TypeContainer.DefineMembers() change.
13606 - structural changes like this should go in in seperate patches
13607 and not be hidden in a huge patch which just seems to affect
13608 warnings and errors.
13609 a big and hard to understand patch.
13610 - it breaks iterators and causes regressions, for instance in
13613 2005-06-30 Raja R Harinath <rharinath@novell.com>
13616 * expression.cs (Indexers.map): Remove.
13617 (Indexers.Append): Filter out inaccessible setters and getters.
13618 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13621 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13622 Refactored from ...
13623 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13624 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13625 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13626 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13628 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13631 * class.cs (FieldBase.GetInitializerExpression): One more field
13634 2005-06-28 Miguel de Icaza <miguel@novell.com>
13636 * pending.cs: Do not define a proxy if the base method is virtual,
13637 it will be picked up by the runtime (bug 75270).
13639 2005-06-08 Martin Baulig <martin@ximian.com>
13641 The big Iterators rewrite :-)
13643 * iterators.cs: Rewrite this to use the anonymous methods framework.
13645 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13646 before the TypeContainers; see 2test-21.cs.
13649 (TypeContainer.DefineType): Don't create a new EmitContext if we
13650 already have one (this only happens if we're an Iterator).
13651 (TypeContainer.Define): Also call Define() on all our iterators.
13652 (Method.CreateEmitContext): Added support for iterators.
13655 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13656 (AnonymousContainer.CreateMethodHost): Moved here from
13657 AnonymousMethod and made abstract.
13658 (AnonymousContainer.CreateScopeType): New abstract method.
13659 (AnonymousContainer.IsIterator): New public property.
13660 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13661 get the ScopeTypeBuilder rather than manually defining it here.
13662 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13665 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13666 before RootContext.DefineTypes().
13668 * codegen.cs (EmitContext.RemapToProxy): Removed.
13669 (EmitContext.CurrentAnonymousMethod): Changed type from
13670 AnonymousMethod -> AnonymousContainer.
13671 (EmitContext.ResolveTopBlock): Protect from being called twice.
13672 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13673 (EmitContext.EmitThis): Removed the iterators hacks; use the
13674 anonymous methods framework for that.
13677 (ToplevelBlock.Container): Make this a property, not a field.
13678 (ToplevelBlock.ReParent): New public method; move the
13679 ToplevelBlock into a new container.
13680 (Foreach.TemporaryVariable): Simplify.
13682 2005-06-05 Martin Baulig <martin@ximian.com>
13684 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13685 (Block.AddTemporaryVariable): New public method; creates a new
13686 `LocalInfo' for a temporary variable.
13687 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13689 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13690 non-iterator variables.
13692 2005-06-05 Martin Baulig <martin@ximian.com>
13694 * statement.cs (Foreach.TemporaryVariable): Create the
13695 LocalBuilder in the Emit phase and not in Resolve since in some
13696 situations, we don't have an ILGenerator during Resolve; see
13697 2test-19.cs for an example.
13699 2005-06-04 Martin Baulig <martin@ximian.com>
13701 **** Merged r45395 from GCS ****
13703 The big Foreach rewrite - Part II.
13705 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13706 with `PropertyInfo ienumerator_getcurrent'.
13708 * codegen.cs (VariableStorage): Removed.
13711 (Foreach): Derive from Statement, not ExceptionStatement.
13712 (Foreach.CollectionForeach): New nested class. Moved all the code
13713 dealing with collection foreach here.
13714 (Foreach.ForeachHelperMethods): Removed.
13715 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13717 2005-05-23 Martin Baulig <martin@ximian.com>
13719 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13720 don't need to. Fix #75014.
13722 2005-05-20 Martin Baulig <martin@ximian.com>
13724 Merged r44808 from GMCS.
13726 * class.cs (TypeContainer.CircularDepException): Removed.
13727 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13728 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13729 (CS0146) and interface (CS0529) dependencies here.
13731 2005-06-21 Raja R Harinath <rharinath@novell.com>
13733 * expression.cs (Invocation.EmitCall): Fix initialization
13734 'this_call' to reflect current behaviour. Fix indentation.
13736 * convert.cs (FindMostEncompassedType): Add two trivial special
13737 cases (number_of_types == 0 || number_of_types == 1).
13738 (FindMostEncompasingType): Likewise.
13740 2005-06-17 Raja R Harinath <rharinath@novell.com>
13742 Some cleanups preparing for the fix of #75283.
13743 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13745 (EventExpr.InstanceResolve): Likewise.
13746 (EventExpr.DoResolve): Remove redundant checks.
13748 2005-06-10 Duncan Mak <duncan@novell.com>
13750 * cs-tokenizer.cs (process_directives): New flag for controlling
13751 the processing of preprocessor directives.
13752 (x_token): After seeing a '#', return Token.NONE instead of going
13753 to handle_preprocessing_directive() when not processing
13754 directives. This avoids unnecessary processing during the token peek in
13759 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13760 the existing error reporting methods instead of Report.Error.
13762 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13763 after Raja's rewrite.
13765 2005-06-08 Miguel de Icaza <miguel@novell.com>
13767 * class.cs: Small fix.
13769 2005-06-08 Raja R Harinath <rharinath@novell.com>
13772 * class.cs (GetPartialBases): Fix return value check of
13773 part.GetClassBases.
13775 2005-06-07 Raja R Harinath <rharinath@novell.com>
13777 Ensure that partial classes are registered in their enclosing
13778 namespace. Initial part of fix of #75160.
13779 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13780 Register declspace with namespace here, not in
13781 DeclSpace.RecordDecl.
13782 * cs-parser.jay: Pass namespace to RecordDecl.
13783 * class.cs (PartialContainer.Create): Likewise.
13784 (ClassPart.DefineType): New sanity-check. Throws an exception if
13786 * decl.cs (Declspace.RecordDecl): Remove.
13787 * namespace.cs (NamespaceEntry.DefineName): Remove.
13789 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13791 * rootcontext.cs: Reset TargetExt as well.
13793 2005-06-03 Raja R Harinath <rharinath@novell.com>
13795 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13796 -langversion:ISO-1.
13798 2005-06-02 Raja R Harinath <rharinath@novell.com>
13800 Fix #75080, cs0119.cs.
13801 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13803 (Expression.Resolve): ... this. Use it. Remove bogus code
13804 allowing ExprClass.Type and ExprClass.Namespace for
13805 ResolveFlags.VariableOrValue.
13806 (Expression.Resolve) [1-argument variant]: Change default resolve
13807 flags based on language version.
13808 (Expression.Error_UnexpectedKind): Use a simple string array
13809 rather than an ArrayList.
13810 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13811 not ExprClass.Type.
13812 (TypeOfVoid.DoResolve): Likewise.
13813 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13814 flags argument -- it always has the same value.
13816 2005-05-31 Raja R Harinath <rharinath@novell.com>
13819 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13820 Use it in the error message.
13821 * assign.cs, expression.cs, statement.cs: Update.
13823 2005-05-30 Raja R Harinath <rharinath@novell.com>
13826 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13827 the "almostMatchedMember" case too.
13828 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13829 that failed the accessibility checks to 'almost_match'.
13831 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13833 * attribute.cs: Use internal MethodBuilder methods to set
13834 ExactSpelling and SetLastError on PInvoke methods, instead
13835 of passing them via charset. Fixes #75060.
13837 2005-05-27 Raja R Harinath <rharinath@novell.com>
13839 * parameter.cs (Parameter): Remove TODO comment.
13840 (Parameter.DefineParameter): Remove Location parameter.
13841 (Parameters.LabelParameters): Likewise.
13842 * class.cs (Constructor.Emit): Update to change.
13843 (MethodData.Emit): Likewise.
13844 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13845 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13847 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13850 Removed Parameters.Location and added Parameter.Location instead.
13851 Removed Location parameter from Emit() and GetSignature().
13858 Modified all related calls.
13860 2005-05-26 Raja R Harinath <rharinath@novell.com>
13862 Improve user-defined conversion handling.
13863 * convert.cs (GetConversionOperators): Rewrite. Return only the
13864 applicable operators.
13865 (AddConversionOperators): New. Helper for GetConversionOperators.
13866 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13867 there is only one most encompassed/encompassing type.
13868 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13869 "applicable operator" handling.
13870 (UserConversion): Move cache here from GetConversionOperators.
13871 Directly cache the chosen operator, rather than the whole
13873 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13874 case. Allow conversion of decimal to sbyte and byte too.
13875 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13876 New static methods. Used to avoid allocating EmptyExpressions in
13879 2005-05-24 Duncan Mak <duncan@novell.com>
13881 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13882 another class, used in Convert.ExplicitNumericConversion.
13883 (CastToDecimal): New class, similar to above, but casts to
13884 System.Decimal, used in Convert.ImplicitNumericConversion and also
13885 in explicit convesion from double/float to decimal.
13887 * convert.cs (ImplicitNumericConversion): Handle implicit
13888 conversions to System.Decimal.
13889 (ExplicitNumericConversion): handle explicit conversions to
13894 2005-05-20 Miguel de Icaza <miguel@novell.com>
13896 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13897 know the type at this stage, just break through. Fixes #75008
13899 2005-05-19 Martin Baulig <martin@ximian.com>
13902 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13903 to disable error reporting.
13905 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13906 here since we don't want to report an error; see the new test-336.cs.
13908 2005-05-19 Raja R Harinath <rharinath@novell.com>
13910 * statement.cs (ToplevelBlock.GetParameterReference)
13911 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13912 Move here from class Block.
13913 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13914 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13916 2005-05-18 Martin Baulig <martin@ximian.com>
13921 (FlowBranching.Reachability): Add non-static public And() and Or()
13923 (FlowBranchingSwitch): New class; do the `break_origins' thing
13924 like in FlowBranchingLoop.
13925 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13926 reachability, not just locals and parameters.
13927 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13928 switch; MergeBreakOrigins() now takes care of that.
13930 2005-05-18 Martin Baulig <martin@ximian.com>
13932 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13933 a loop and may leave it, reset the barrier; fixes #74974.
13935 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13937 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13940 * cs-parser.jay: Catch more lexical errors.
13942 * report.cs: Add one more Error method.
13945 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13947 2005-05-17 Martin Baulig <martin@ximian.com>
13949 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13952 2005-05-16 Raja R Harinath <rharinath@novell.com>
13954 Fix test-382.cs. Emit values of decimal constants.
13955 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13957 (TypeContainer.AddField): ... this.
13958 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13959 with initializers to include 'Const's.
13960 (ClassPart.RegisterFieldForInitialization): Forward to
13962 * const.cs (Const.Const): Pass initializer to base class.
13963 (Const.Define): In case of decimal constants, register them for
13964 initialization in a static constructor.
13966 2005-05-14 Martin Baulig <martin@ximian.com>
13968 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13969 do not call ResolveUnreachable() on unreachable statements in
13970 here, see the comment in the source code.
13972 2005-05-13 Raja R Harinath <rharinath@novell.com>
13975 * expression.cs (BinaryResolveOperator): If one of the operands of
13976 an equality comparison is 'null' and the other is a pointer type,
13977 convert the null to a NullPointer.
13978 * convert.cs (ImplicitReferenceConversion): If the expression is a
13979 NullLiteral and the target type is a pointer type, return a
13980 NullPointer instead.
13981 (ImplicitConversionStandard): Likewise.
13983 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13985 * cs-parser.jay: Set readonly context based on special constructs.
13987 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13988 readonly variable error handling.
13990 * rootcontext.cs (EmitCode): Don't verify members when error
13993 * statement.cs (LocalInfo): Add reaodnly context information.
13994 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13996 2005-05-13 Raja R Harinath <rharinath@novell.com>
13998 * statement.cs (Block.Resolve): Revert change below. Modify fix
13999 for #74041 to initialize 'resolved' to false only for explicit
14000 blocks. Fixes #74873.
14002 2005-05-12 Raja R Harinath <harinath@gmail.com>
14005 * typemanager.cs (unmanaged_enclosing_types): New.
14006 (IsUnmanagedType): Avoid infloops by using
14007 'unmanaged_enclosing_types' to talk with recursive invocations.
14009 2005-05-13 Martin Baulig <martin@ximian.com>
14011 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
14012 instance variable, not a local. Fix #74873.
14013 (Block.ResolveUnreachable): Set it to true here.
14015 2005-05-11 Duncan Mak <duncan@novell.com>
14017 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
14018 continuing to process for 'arg'.
14019 (handle_preprocessing_directive): Check the argument of the #endif
14020 directive and report error CS1025 if there are any trailing
14023 According to the C# spec, having even whitespace after the #endif
14024 directive is illegal; however, because we call arg.TrimEnd ()
14025 beforehand, we have the same behavior as csc, allowing whitespace
14026 after the directive.
14030 2005-05-11 Marek Safar <marek.safar@seznam.cz>
14034 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
14035 (Constructor.GetObsoleteAttribute): Implemented correctly.
14037 2005-05-10 Martin Baulig <martin@ximian.com>
14039 * support.cs (ReflectionParameters.ParameterModifier): Use
14040 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
14041 and `ParameterAttributes.In'. Fixes #74884.
14043 2005-05-10 Marek Safar <marek.safar@seznam.cz>
14045 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
14047 * expression.cs (Argument.GetParameterModifier): Turned to property.
14048 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14050 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14053 2005-05-09 Raja R Harinath <rharinath@novell.com>
14056 * decl.cs (MemberCache.AddMethods): Register override methods,
14057 rather than non-override methods.
14058 * typemanager.cs (RegisterOverride): New.
14059 (IsOverride): Update.
14061 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14065 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14066 recursive declaration.
14068 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14070 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14072 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14074 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14076 2005-05-05 Raja R Harinath <rharinath@novell.com>
14079 * decl.cs (DeclSpace.FamilyAccessible):
14080 Use TypeManager.IsNestedFamilyAccessible.
14082 Fix reopened #64812.
14083 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14086 2005-05-04 Raja R Harinath <rharinath@novell.com>
14087 Abin Thomas <projectmonokochi@rediffmail.com>
14088 Anoob V E <projectmonokochi@rediffmail.com>
14089 Harilal P R <projectmonokochi@rediffmail.com>
14092 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14093 allow access to all static members.
14095 2005-05-04 Martin Baulig <martin@ximian.com>
14097 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14099 2005-05-04 Martin Baulig <martin@ximian.com>
14103 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14104 section at the end; make things work if `default' is not the last
14107 2005-05-04 Martin Baulig <martin@ximian.com>
14111 * statement.cs (Switch): Replaced the `got_default' field with a
14112 `default_section' one.
14113 (Switch.CheckSwitch): Set `default_section' here.
14114 (Switch.Resolve): If we're a constant switch and the constant is
14115 not found, use the default section.
14117 2005-05-03 Martin Baulig <martin@ximian.com>
14119 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14121 * statement.cs (Foreach.ArrayForeach): New nested class.
14122 (Foreach.TemporaryVariable): New nested class.
14123 (Foreach.EmitArrayForeach): Removed; this is now in the new
14124 ArrayForeach class.
14126 2005-05-03 Raja R Harinath <rharinath@novell.com>
14128 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14130 (VerifyPendingMethods): Revert change below.
14132 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14133 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14134 that used to trigger warning -28. Remove warning -28.
14135 * expression.cs (Invocation.OverloadResolve): Use
14136 TypeManager.IsOverride to distinguish override methods.
14139 * pending.cs (VerifyPendingMethods): If a base type implements the
14140 requested interface, don't bother checking individual methods of
14141 the base type. As a side-effect, this prevents the creation of
14142 unnecessary proxies.
14144 2005-05-02 Martin Baulig <martin@ximian.com>
14148 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14149 Also `And' the locals if the old vector is null.
14150 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14151 null; in this case we basically reset all the variables.
14153 2005-05-02 Martin Baulig <martin@ximian.com>
14157 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14158 Added `FlowBranching branching' argument; always `and' the
14159 variables instead of `or'ing them unless we're an infinite loop.
14161 * statement.cs (While.Resolve): Create a new sibling unless we're
14164 2005-05-02 Martin Baulig <martin@ximian.com>
14168 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14169 arguments; use it instead of creating a new TopLevelBlock.
14170 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14171 our ConstructorInitializer.
14174 (TopLevelBlock.TopLevelBranching): New public property.
14175 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14176 and create our `TopLevelBranching'.
14178 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14179 anonymous method host, use `block.TopLevelBranching' rather than
14180 creating a new branching.
14182 2005-04-20 Miguel de Icaza <miguel@novell.com>
14184 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14185 a ScopeInfo, if any of the current children is a child of the new
14186 entry, move those children there.
14188 2005-04-30 Martin Baulig <martin@ximian.com>
14190 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14191 at the beginning of a SwitchSection. Fix #73335.
14193 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14196 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14198 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14199 (FieldExpr.DoResolve): Obsolete members are ignored for field
14202 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14204 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14205 of arrays detection.
14207 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14209 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14211 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14214 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14216 * cs-parser.jay: Use the prefered version of -unsafe in error
14219 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14221 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14224 2005-04-20 John Luke <john.luke@gmail.com>
14226 * driver.cs: fix typo in error message, --outout to --output
14228 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14230 * codegen.cs (InRefOutArgumentResolving): New field.
14232 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14233 fields outside contructor.
14235 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14237 2005-04-19 Miguel de Icaza <miguel@novell.com>
14239 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14240 parameter code was not completed ever, so it was not as up-to-date
14241 as local variables. Must finish it.
14243 The bug fix was to compare the Toplevel of the block, not the
14244 current block. Thanks for Ben for pointing this out.
14246 2005-04-19 Raja R Harinath <rharinath@novell.com>
14248 * decl.cs (AddMethods): Use the declaring type of the problem
14249 method to determine if we want to squash a warning.
14251 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14253 * attribute.cs: Removed debug output.
14255 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14257 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14260 2005-04-18 Raja R Harinath <rharinath@novell.com>
14263 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14264 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14265 all null comparisons against reference types.
14267 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14270 * class.cs (TypeContainer.CircularDepException) New nested
14272 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14273 (TypeContainer.DefineType): Removed error, reset InTransit before
14275 (Class.DefineType): Throw exception when is in Transit.
14276 Catch exception and report error.
14277 (Struct.DefineType): Throw exception when is in Transit.
14278 Catch exception and report error.
14279 (Interface.DefineType): Throw exception when is in Transit.
14280 Catch exception and report error.
14282 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14283 handle nested exception handlers.
14285 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14288 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14289 InFinally and InCatch storage.
14291 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14292 (Catch.Resolve): Set and Restore ec.InCatch.
14293 (Try.Resolve): Set and Restore ec.InFinally.
14294 (Try.HasCatch): True when try has catch.
14296 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14298 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14299 for the same event member, so exclude such cases from warning 419.
14302 2005-04-16 Miguel de Icaza <miguel@novell.com>
14304 * expression.cs (Binary.ResolveOperator): Apply patch from John
14305 Luke to fix bug 59864: operators &, | and ^ on enumerations
14306 require that the same enum type on both sides.
14308 * driver.cs: Add warnings to old flag usage, this is to assist
14309 people who produce Makefiles and hope that the Makefiles will be
14312 * class.cs (TypeContainer.EmitType): Moved the definition of the
14313 special $PRIVATE$ field from the resolve phase to the Emit phase.
14314 During resolve we do not know if we are a struct with
14315 HasExplicitLayout, we know this only after the attributes for the
14318 Set the FieldOffset to zero on the dummy field that we create for
14319 the class. Fixes 74590.
14321 2005-04-16 Raja R Harinath <rharinath@novell.com>
14324 * ecore.cs (PropertyExpr.resolved): New.
14325 (DoResolve): Use it to handle a case of double resolution here.
14326 Handle a case of identical-name-and-type-name.
14327 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14328 resolution by storing the results of expression resolution back
14329 into the "probes" array.
14331 2005-04-15 Raja R Harinath <rharinath@novell.com>
14333 Fix cs0208-7.cs and cs0208-8.cs.
14334 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14335 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14336 error reporting to point out the reason a struct is not unmanaged.
14338 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14340 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14341 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14343 2005-04-13 Raja R Harinath <rharinath@novell.com>
14346 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14347 IdenticalNameAndTypeName here.
14348 (EventExpr.InstanceResolve): Likewise.
14350 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14352 C# 2.0 DefaultCharSetAttribute implementation
14354 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14355 which allows us to set GlobalNamespace for every resolve.
14356 (Attribute.ResolveArguments): Cut from Resolve.
14357 (Attribute.GetCharSetValue): Returns CharSet named argument.
14358 (Attribute.DefinePInvokeMethod): Gets default charset from
14360 (GlobalAttribute.ResolveAsTypeStep): Override.
14361 (GlobalAttribute.ResolveArguments): Override.
14363 * class.cs (TypeAttr): Is protected.
14365 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14366 (ModuleClass.DefaultCharSetType): New memeber.
14367 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14369 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14370 charset from module.
14372 * delegate.cs (TypeAttr): Override.
14373 (Delegate.DefineType): Use this TypeAttr.
14375 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14376 at very early stage (before types are defined) to resolve model
14377 module attributes. It will probably not work with corlib but it
14380 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14381 charset from module.
14383 * typemanager.cs (default_charset_type): New type.
14385 2005-04-13 Raja R Harinath <rharinath@novell.com>
14387 * decl.cs (MemberCache.AddMethods): Don't warn if
14388 System.Object.Finalize has buggy MethodAttributes.
14390 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14393 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14395 * doc.cs : detect ambiguous reference to overloaded members.
14396 Fixed bug #71603. MS 1.1 csc does not detect it.
14398 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14400 * doc.cs : delegates must not be referenced with parameters.
14403 2005-04-12 Miguel de Icaza <miguel@novell.com>
14405 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14407 2005-04-10 Miguel de Icaza <miguel@novell.com>
14409 * driver.cs (MainDriver): Stop processing if the CLS stage found
14412 (CompilerCallableEntryPoint.InvokeCompiler): Always
14413 reset after execution; Take a TextWriter argument for the
14416 * report.cs: Use the error stream instead of hardcoding stderr.
14418 2005-04-09 Miguel de Icaza <miguel@novell.com>
14420 * class.cs: Reduce code paths to test, too small of an
14421 optimization to make it worth the extra testing. Always perform
14424 2005-04-08 Raja R Harinath <rharinath@novell.com>
14427 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14428 operators that had errors reported on them.
14430 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14432 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14434 (Attribute.Resolve): Add named argument type checking.
14436 * class.cs (FixedField.Define): Use IsPrimitiveType
14438 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14440 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14441 unsafe parameter types.
14443 * statement.cs (Using.ResolveExpression): Add better error description.
14445 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14447 2005-04-08 Raja R Harinath <rharinath@novell.com>
14450 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14451 AttributeUsageAttribute in the emitcontext of the attribute class,
14452 not in the emitcontext of the attributable entity it was attached to.
14453 * cs-parser.jay: Use 'current_class', not 'current_container',
14454 when creating a GlobalAttribute.
14456 2005-04-08 Alp Toker <alp@atoker.com>
14458 * pending.cs: The fix to #58413 failed to compile methods implementing
14459 interfaces with/without params modifiers and vice versa, even though
14460 params modifiers aren't part of the signature. Make the modifier check
14461 less strict as in csc.
14463 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14464 Anoob V E <projectmonokochi@rediffmail.com>
14465 Harilal P R <projectmonokochi@rediffmail.com>
14468 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14469 modifiers of pending methods.
14470 (PendingImplementation.PendingImplementation): Initialize it.
14471 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14472 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14473 with ParameterData. Add check for modifiers.
14474 * class.cs (MethodData.Define): Update to changes.
14476 2005-04-07 Raja R Harinath <rharinath@novell.com>
14478 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14480 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14482 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14485 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14488 * typemanager.cs: Registered RequiredAttributeAttribute.
14490 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14492 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14493 Warning CS0169 is back at level 3.
14494 (IMethodData.SetMemberIsUsed): New method.
14496 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14497 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14499 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14501 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14503 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14506 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14509 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14510 to avoid the problems with nested types.
14512 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14513 Anoob V.E <projectmonokochi@rediffmail.com>
14514 Harilal P.R <projectmonokochi@rediffmail.com>
14515 Raja R Harinath <rharinath@novell.com>
14518 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14520 * typemanager (GetConstructor): Make public.
14522 2005-04-05 John Luke <john.luke@gmail.com>
14523 Raja R Harinath <rharinath@novell.com>
14526 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14527 struct too. Return false quicker in a few cases.
14528 (VerifyUnManaged): Use it.
14530 2005-04-05 Raja R Harinath <rharinath@novell.com>
14533 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14534 not 'unreachable_seen'.
14536 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14538 * attribute.cs (Attribute.GetValue): Removed unused.
14540 * codegen.cs (CodeGen.TrimExt): Removed unused.
14542 * cs-parser.jay (output): Removed unused.
14544 * cs-tokenizer.cs (hex_digits): Removed unused.
14546 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14548 * expression.cs (Indirection.LoadExprValue): Removed unused.
14549 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14551 * iterators.cs (Iterator.param_types): Removed unused.
14553 * statement.cs (Goto.block): Removed unused.
14554 (ToplevelBlock.did): Removed unused.
14555 (Switch.ResolveConstantSwitch): Removed unused.
14557 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14559 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14562 2005-04-01 Raja R Harinath <rharinath@novell.com>
14564 Fix #74232 and cs0208-3.cs.
14565 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14566 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14567 unmanaged type. Don't use FieldBuilders when 't' is a
14568 TypeBuilder. Use ModFlags and MemberType fields.
14569 * class.cs (MemberBase.member_type): Rename from MemberType.
14570 (MemberBase.MemberType): New property. Determines member_type on
14572 (MemberBase.DoDefine): Don't initialize MemberType here.
14573 (FieldMember.Define): Likewise.
14575 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14578 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14579 Attributes are emitted there.
14581 2005-04-01 Raja R Harinath <rharinath@novell.com>
14583 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14584 keyword in 'partial enum' too.
14585 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14587 Report from Kamil Skalski <nazgul@omega.pl>.
14590 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14591 have partial containers too.
14593 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14594 in block' checks to Block.CheckInvariantMeaningInBlock.
14595 * statement.cs (Block.GetKnownVariableInfo): Make private.
14596 (Block.IsVariableUsedInChildBlock): Remove.
14597 (Block.IsVariableUsedInBlock): Likewise.
14598 (Block.CheckInvariantMeaningInBlock): New. Show location of
14599 conflicting declaration.
14600 (Block.AddVariable): Make error messages less long-winded and more
14601 specific. Show location of conflicting declaration.
14602 * parameter.cs (Parameters.Location): New readonly property.
14604 2005-03-31 Raja R Harinath <rharinath@novell.com>
14606 Clean up semantics of invoking ResolveMemberAccess.
14607 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14608 can have an instance, ensure that we pass in a non-TypeExpression
14609 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14610 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14611 argument. Update to changes and simplify.
14612 (FieldExpr.Emitinstance): Remove CS0120 check.
14613 (PropertyExpr.EmitInstance): Likewise.
14614 * expression.cs (Argument.Resolve): Likewise.
14615 (Invocation.DoResolve): Update to changes in semantics of
14616 InstanceExpression.
14618 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14621 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14624 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14626 2005-03-31 Raja R Harinath <rharinath@novell.com>
14628 Fix difference in behaviour with commandline invocation.
14629 * driver.cs (Driver.Reset): New.
14630 (CompilerCallableEntryPoint): Call it.
14632 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14633 variable" warnings if the boolean expression failed to resolve.
14635 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14637 * attribute.cs: Fix the union of several permissions when some of them
14638 are unrestricted (so the result isn't an unrestricted permission set).
14641 2005-03-30 Raja R Harinath <rharinath@novell.com>
14643 * ecore.cs (MemberExpr): New class. Convert from interface
14645 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14646 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14648 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14649 (MethodGroupExpr.IsExplicitImpl): Remove.
14650 (Expression.GetFieldFromEvent): Remove.
14651 (SimpleName.MemberStaticCheck): Remove.
14652 (SimpleName.DoSimpleNameResolve): Update to changes.
14653 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14654 (MemberAccess.IdenticalNameAndTypeName): Remove.
14655 (MemberAccess.error176): Move to MemberExpr.
14656 (MemberAccess.DoResolve): Update to changes.
14657 (BaseAccess.DoResolve): Likewise.
14659 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14661 C# 2.0 Conditional attribute class implementation
14663 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14664 Analyzes class whether it has attribute which has ConditionalAttribute
14665 and its condition is not defined.
14667 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14668 (Class.IsExcluded): New method. Search for at least one defined
14669 condition in ConditionalAttribute of attribute class.
14671 2005-03-30 Raja R Harinath <rharinath@novell.com>
14673 * ecore.cs (PropertyExpr): Derive from Expression, not
14674 ExpressionStatement.
14675 (PropertyExpr.EmitStatement): Remove.
14677 2005-03-29 Raja R Harinath <rharinath@novell.com>
14680 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14681 internal field "value__" of an enum be private. The examples for
14682 "value__" that I found on MSDN all used FieldAttributes.Private.
14684 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14685 Don't mention IL method attribute names.
14687 Fix #47991. Remove a TODO.
14688 * statement.cs (Block.Toplevel): Make into a field.
14689 (Block.Parameters): Move into ToplevelBlock.
14690 (Block.known_variables): Rename from child_variable_names.
14691 (Block.Block): Remove variants that take Parameters. Initialize
14692 'Toplevel' with the immediately surrounding toplevel block.
14693 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14694 LocalInfo parameter.
14695 (Block.GetKnownVariableInfo): New.
14696 (Block.IsVariableNameUsedInChildBlock): Update.
14697 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14698 the block, even though it may not be in scope.
14699 (Block.AddVariable): Remove Parameters parameter. Use
14700 Toplevel.Parameters instead.
14701 (Block.AddConstant): Remove Parameters parameter.
14702 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14703 (Block.IsParamaterReference): Likewise.
14704 (Block.IsLocalParameter): Likewise. Simplify a lot.
14705 (ToplevelBlock.Parameters): New. Moved from Block.
14706 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14707 initialize Parameters to a non-null value.
14708 * cs-parser.jay: Update to changes.
14709 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14710 simple names that mean different things in the same block. Use
14711 Block.IsVariableNameUsedInBlock.
14713 2005-03-28 Raja R Harinath <rharinath@novell.com>
14715 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14716 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14717 GetTypeHandle. It is possible for a reflected type to derive from
14718 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14719 System.Array during mscorlib compilation).
14720 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14721 contain a method_hash, don't create one either. Don't create a
14722 deep copy of the base cache's method_hash.
14723 (MemberCache.SetupCache): Rename back from DeepCopy.
14724 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14725 already initialized. If we see an override function, add its
14726 underlying base virtual function to the member_hash too.
14728 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14730 2005-03-26 Raja R Harinath <harinath@acm.org>
14733 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14734 fails to resolve, ensure that the LHS is still resolved as an
14737 2005-03-25 Raja R Harinath <harinath@acm.org>
14739 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14741 (Enum.current_ec): Remove.
14742 (Enum.LookupEnumValue): Remove EmitContext argument.
14743 Just uses the one created during DefineType.
14744 (Enum.FindMembers): Update.
14745 * expression.cs (MemberAccess.DoResolve): Update.
14747 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14749 * assign.cs (Assign.DoResolve): Check for CS1717 when
14750 source and target are same (uses Equals).
14752 * expression.cs (LocalVariableReference, ParameterReference,
14753 This): Implemented Equals, GetHashCode.
14755 * statement.cs (Block.GetParameterReference): Removed useless
14758 2005-03-22 Raja R Harinath <rharinath@novell.com>
14761 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14762 blocks before deciding whether the error is cs0136 or cs0128.
14764 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14765 (using_alias_directive, using_namespace_directive): Pass
14766 MemberName, not an expression to Namespace.UsingAlias and
14768 (MakeName): Use the MemberName of the namespace.
14769 * namespace.cs (Namespace.MemberName): New.
14770 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14771 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14773 * decl.cs (MemberName.Name): Make readonly.
14774 (MemberName.FromDotted): New "constructor".
14775 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14776 (MemberCore.Name): Compute from MemberName on demand.
14777 (MemberCore.SetMemberName): Provide a way to change the
14779 (MemberCore.AddToContainer): Don't take a fullname parameter.
14780 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14781 fully qualified name of the container to the member name.
14782 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14783 only if the type is a member of the root container.
14784 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14785 MemberName.Left rather than searching for an embedded ".".
14786 (PartialContainer.CreatePart): Update to changes in RootContext.
14787 (MemberBase.ShortName): Turn into a property. Use
14788 MemberCore.SetMemberName.
14789 (MemberBase.ExplicitInterfaceName): Remove.
14790 (MemberBase.UpdateMemberName): Remove.
14791 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14792 (PropertyBase.SetMemberName): New override.
14793 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14794 (Tree.GetDecl): New.
14795 (Tree.AllDecls): Rename from Decls.
14796 * attribute.cs, enum.cs, report.cs: Update to changes.
14797 * driver.cs (MainDriver): Use MemberName.FromDotted on
14798 RootContext.MainClass.
14800 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14802 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14805 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14807 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14809 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14810 property accessor modifiers.
14812 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14813 fixed buffer attribute (CS1716).
14814 (PropertyMethod.HasCustomAccessModifier): When property accessor
14815 has custom modifier.
14817 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14819 (PropertyExpr.DoResolveLValue): Add CS0272.
14821 2005-03-17 Miguel de Icaza <miguel@novell.com>
14823 * convert.cs: When converting to a pointer, use the proper Conv.U
14824 or Conv.I depending on the source data type.
14826 * cs-tokenizer.cs: Make the size for large decimal constants,
14829 2005-03-17 Martin Baulig <martin@ximian.com>
14831 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14832 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14834 2005-03-17 Martin Baulig <martin@ximian.com>
14836 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14837 to bool so we can return an error condition.
14838 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14841 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14843 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14846 2005-03-16 Raja R Harinath <rharinath@novell.com>
14848 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14849 Refactor to avoid traversing the list of assemblies, and to avoid
14850 string concatenation.
14851 * typemanager.cs (guid_attr_type): Remove.
14852 (negative_hits, pointers, references): Remove hashes.
14854 (GetConstructedType): New. Uses type_hash to handle constructed
14855 types (arrays, references, pointers).
14856 (GetReferenceType, GetPointerType): Use it.
14857 (GetNestedType): New. Uses type_hash to handle nested types of
14859 (LookupType, LookupTypeDirect): Remove.
14860 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14861 'types' hash and LookupTypeReflection directly.
14862 (params_string, params_object): Use GetConstructedType.
14863 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14865 (Namespace.Lookup): Use cached_types.
14866 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14867 provided by old TypeManager.LookupType.
14868 * rootcontext.cs (MakeFQN): Remove.
14869 * decl.cs (DeclSpace.MakeFQN): Likewise.
14870 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14871 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14872 TypeManager.GetConstructedType.
14873 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14875 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14877 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14880 * cs-parser.jay: Reports CS1527 for any namespace element.
14882 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14885 * expression.cs (ParameterReference.IsAssigned): Changed error to
14887 (Error_WrongNumArguments): Moved CS0245 detection here.
14889 * statement.cs (Return.Resolve): Add CS1622 report.
14891 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14893 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14895 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14897 * attribute.cs expression.cs: Get rid of some allocations.
14899 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14901 * doc.cs : just eliminate the latest change.
14903 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14905 * doc.cs : commented out the latest change. It breaks xml-030.cs
14907 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14909 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14910 fail. So invoke CreateType() in FindDocumentedType().
14912 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14914 * cs-tokenizer.cs : added IsKeyword().
14915 * doc.cs : Detect keyword incorrectly used as identifier.
14916 Allow identifiers prefixed by @.
14918 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14920 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14921 It caused exception in namespace resolving (again!).
14923 * class.cs (Class.ctor): Removed exit.
14924 (PropertyMethod.ctor): ditto.
14926 * codegen.cs (Codegen.Reset): Reset static data.
14927 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14929 * cs-tokenizer.cs (Cleanup): Removed.
14931 * driver.cs (GetSystemDir): Rewrote to one line command.
14932 It caused problem with unloaded dynamic modules.
14933 (UnixParseOption): Removed Exit.
14934 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14935 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14936 Now can be mcs used as library.
14938 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14941 * location.cs (Reset): Reset static data.
14943 * namespace.cs (Reset): Reset static data.
14945 * report.cs (Report.Reset): Reset static data.
14947 * rootcontext.cs (RootContext.Reset): Reset static data.
14949 * tree.cs (RootTypes.ctor): Use Location.Null
14951 * typemanager.cs (TypeManager.Reset): Reset static data.
14952 (CoreLookupType): Removed Exit.
14953 (TypeHandle.Reset): Reset static data.
14955 2005-03-10 Raja R Harinath <rharinath@novell.com>
14958 * typemanager.cs (ComputeNamespaces): Import namespaces from
14959 referenced modules too.
14961 2005-03-09 Raja R Harinath <rharinath@novell.com>
14963 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14966 2005-03-09 Raja R Harinath <rharinath@novell.com>
14968 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14969 enclosing DeclSpace. This ensures that a name-lookup populates
14970 more caches and there are fewer 'TypeExpression's. Carve out
14971 nested type lookup into ...
14972 (LookupNestedTypeInHierarchy): ... this.
14974 2005-03-09 Raja R Harinath <rharinath@novell.com>
14976 Clean up a few partial-class semantics.
14977 Fixes test-357.cs and cs1618-2.cs.
14978 * cs-parser.jay (struct_declaration): Use 'current_class' as
14979 parent of newly-created struct. Remove call to Register ().
14980 Use 'pop_current_class' to complete handing the current struct.
14981 (interface_declaration): Likewise.
14982 (class_declaration): Likewise.
14983 (enum_declaration): Use 'current_class' as parent of newly created
14985 (delegate_declaration): Likewise.
14986 (pop_current_class): New function. This is used to handle closing
14987 up the 'current_class' and 'current_container', and pointing them
14988 to the enclosing class/container.
14989 (CSharpParser): Initialize 'current_class' too.
14990 * decl.cs (MemberCore): Add check for invariant: a partial
14991 container is not a parsed entity, and thus does not enclose any
14993 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14994 (DeclSpace.BaseTypeExpr): Use it.
14995 (DeclSpace.LookupType): Add check for invariant.
14996 * class.cs (TypeContainer): Add check for invariant: a nested
14997 class should have the same NamespaceEntry as its enclosing class.
14998 (TypeContainer.EmitFieldInitializers): Make virtual.
14999 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
15001 (TypeContainer.Register): Remove.
15002 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
15003 null. Use TypeResolveEmitContext for resolving base types and
15004 interfaces. Move initialization of Parts.TypeBuilder here from
15006 (TypeContainer.DefineNestedTypes): ... here.
15007 (PartialContainer): Take a Namespace not a NamespaceEntry.
15008 (PartialContainer.Create): Don't use Register. Call the
15009 appropriate Add... function directly.
15010 (ClassPart): Take both the PartialContainer and the enclosing
15011 class as constructor arguments.
15012 (ClassPart.EmitFieldInitializers): Override.
15013 (ClassPart.PartFindNestedTypes): Remove.
15014 (FieldBase.GetInitializerExpression): Resolve the initializer
15015 expression in the emit context of the enclosing class.
15016 * tree.cs (RootTypes): Remove Register ().
15018 2005-03-08 Marek Safar <marek.safar@seznam.cz>
15020 * cs-parser.jay: Removed CS0134.
15022 * driver.cs: Removed CS1901.
15024 * expression.cs (SizeOf.DoResolve): Don't report CS0233
15025 for predefined types.
15027 2005-03-07 Duncan Mak <duncan@novell.com>
15029 * codegen.cs (Save): Catch UnauthorizedAccessException as
15030 well. Fixes bug #73454.
15032 2005-03-07 Marek Safar <marek.safar@seznam.cz>
15034 * cs-tokenizer.cs (xtoken): Add CS1035.
15036 * class.cs (MethodData.Define): Add CS0683.
15037 (FieldMember.ctor): Add CS0681.
15039 2005-03-07 Raja R Harinath <rharinath@novell.com>
15041 * ecore.cs (SimpleName.DoResolve): Rename from
15042 SimpleName.DoResolveAllowStatic.
15043 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
15044 Pass 'intermediate' flag to MemberStaticCheck.
15045 (SimpleName.MemberStaticCheck): Skip "static check" only in case
15046 of "intermediate" lookups via MemberAccess.
15047 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
15048 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15050 2005-03-07 Raja R Harinath <rharinath@novell.com>
15053 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15054 slipped in because of variable names that are identical to a
15055 builtin type's BCL equivalent ('string String;', 'int Int32;').
15056 (PropertyExpr.EmitInstance): Likewise.
15058 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15060 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15062 * report.cs (warning_ignore_table): Made public.
15064 2005-03-04 Raja R Harinath <rharinath@novell.com>
15067 * class.cs (MethodData.Emit): Pass 'container' to
15068 container.GetObsoleteAttribute instead of 'container.Parent'.
15070 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15072 * cs-parser.jay: Add 1534 error test.
15074 * iterators.cs (Yield.CheckContext): Add error 1629.
15075 (Iterator.ctor): Save unsafe modifier.
15076 (MoveNextMethod.DoEmit): Restore unsafe context.
15078 * namespace.cs (UsingAlias): Better error message.
15080 2005-03-03 Dan Winship <danw@novell.com>
15082 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15083 the warning message [#73219]
15085 2005-03-03 Raja R Harinath <rharinath@novell.com>
15087 Fix compile with MCS 1.0.0.0.
15088 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15089 w_restore to not depend on string constant folding.
15091 2005-03-03 Raja R Harinath <rharinath@novell.com>
15093 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15094 CS0246 check to users who passed 'silent = false'.
15095 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15097 (SimpleName.SimpleNameResolve): Update.
15098 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15099 (MemberAccess.IdenticalNameAndTypeName): Update.
15100 * doc.cs (FindDocumentedTypeNonArray): Update.
15102 2005-03-03 Raja R Harinath <rharinath@novell.com>
15104 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15105 * parameters.cs (ComputeAndDefineParameters): Remove.
15106 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15107 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15108 Use GetParameterInfo.
15110 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15112 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15114 2005-03-02 Raja R Harinath <rharinath@novell.com>
15116 Unify DeclSpace.LookupType and DeclSpace.FindType.
15117 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15118 is in charge of defining nested types on demand.
15119 (DeclSpace.LookupType): Use it when the current_type is a
15120 TypeBuilder. Use LookupTypeDirect for reflected types.
15121 (DeclSpace.FindType): Remove.
15122 (DeclSpace.LookupInterfaceOrClass): Likewise.
15123 (DeclSpace.DefineTypeAndParents): Likewise.
15124 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15125 DeclSpace.LookupType.
15126 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15127 * typemanager.cs (LookupType): Simplify.
15128 (AddUserType): Remove type from negative_hits.
15129 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15130 * class.cs (TypeContainer.FindMembers): Move handling of nested
15132 (TypeContainer.FindMembers_NestedTypes): ... here.
15133 (TypeContainer.FindNestedType): Implement override.
15134 (ClassPart.FindNestedType): Delegate to PartialContainer.
15135 (ClassPart.PartFindNestedType): Looks up the nested types of the
15138 2005-03-02 Martin Baulig <martin@ximian.com>
15140 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15141 static constructor in static classes.
15143 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15145 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15146 sizeParamIndex is not specified.
15148 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15151 * report.cs (WarningMessage.IsEnabled): Missing null check.
15153 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15155 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15156 in the fields and not in the properties.
15158 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15160 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15163 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15165 * attribute.cs: Small refactoring (improved robustness).
15166 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15167 (ValidateGuid): Removed.
15168 (Resolve): Removed referenced to above mentioned.
15169 (GetAttributeUsage): Made private and changed to work without
15171 (GetIndexerAttributeValue): Don't crash.
15172 (GetConditionalAttributeValue): Ditto.
15173 (GetClsCompliantAttributeValue): Ditto.
15174 (ExtractSecurityPermissionSet): All attributes exceptions are
15176 (GetPropertyValue): New helper.
15177 (GetMethodImplOptions): New method.
15178 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15179 some missing properties.
15181 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15182 (Method.ApplyAttributeBuilder): Updated.
15184 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15187 2005-02-28 Raja R Harinath <rharinath@novell.com>
15190 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15191 non-simple types (array, pointer, reference).
15193 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15195 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15197 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15199 (Method.CheckBase): Catch wrong destructor here.
15200 (MethodData.Define): Add errors 550, 668.
15202 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15204 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15206 * pending.cs (VerifyPendingMethods): Add error 551.
15208 * typemanager.cs (CSharpName): Next error report helper.
15210 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15212 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15213 attributes. Removed useless attribute double check.
15214 It saves almost 2MBs for corlib.
15216 2005-02-25 Raja R Harinath <rharinath@novell.com>
15219 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15220 called twice in case of error.
15222 2005-02-23 Chris Toshok <toshok@ximian.com>
15224 Fix compiler portions of #72827.
15225 * statement.cs (Block.Emit): call Begin/EndScope on the
15226 EmitContext instead of the ILGenerator.
15228 * codegen.cs (EmitContext.BeginScope): new method, call
15229 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15231 (EmitContext.BeginScope): same, but EndScope and CloseScope
15233 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15234 offset and call the superclass's OpenScope(int) with it.
15235 (SymbolWriter.CloseScope): get the current il
15236 offset and call superclass's CloseScope(int) with it.
15238 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15240 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15241 CS1677 for out and ref as well.
15243 * class.cs (Method.Define): Add error CS1599 detection.
15245 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15247 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15249 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15251 * support.cs.cs (ModifierDesc): New helper method.
15253 2005-02-23 Raja R Harinath <rharinath@novell.com>
15254 Abin Thomas <projectmonokochi@rediffmail.com>
15255 Anoob V E <projectmonokochi@rediffmail.com>
15256 Harilal P R <projectmonokochi@rediffmail.com>
15258 Fix #57851, #72718.
15259 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15260 MemberLookup (used for error reporting) actually returns a result.
15261 Fix error report number (122, not 112).
15263 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15264 Anoob V E <projectmonokochi@rediffmail.com>
15265 Harilal P R <projectmonokochi@rediffmail.com>
15268 * pending.cs (PendingImplementation.GetAbstractMethods):
15269 Find NonPublic members too.
15271 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15273 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15276 * class.cs (MethodCore.CheckMethodAgainstBase):
15277 Add error 239 report.
15279 2005-02-21 Raja R Harinath <rharinath@novell.com>
15282 * expression.cs (Invocation.IsApplicable): Make public.
15283 (Invocation.IsParamsMethodApplicable): Likewise.
15284 * delegate.cs (Delegate.VerifyApplicability): Don't use
15285 Invocation.VerifyArgumentCompat for parameter applicability
15286 testing. Use Invocation.IsApplicable and
15287 Invocation.IsParamsMethodApplicable.
15289 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15291 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15293 * class.cs (Operator.Define): Add error 217 report.
15295 2005-02-21 Raja R Harinath <rharinath@novell.com>
15297 * namespace.cs (UsingEntry.Resolve): Undo change below.
15299 2005-02-21 Raja R Harinath <rharinath@novell.com>
15302 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15303 disable the error message when the extended MemberLookup also
15305 (Expression.MemberLookupFinal): Update.
15306 (SimpleName.DoSimpleNameResolve): Update.
15307 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15308 Don't use MemberLookupFinal.
15309 (New.DoResolve): Update.
15310 (BaseAccess.CommonResolve): Update.
15312 2005-02-21 Raja R Harinath <rharinath@novell.com>
15315 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15316 occured previously, don't resolve again.
15318 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15321 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15322 argument. Call ResolveAttributeUsage for unresolved.
15323 when types doesn't match ctor arguments.
15325 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15326 for nested attribute classes.
15327 (Class.attribute_usage): Removed.
15328 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15329 for attribute class.
15331 * ecore.cs (IsAttribute): Removed.
15333 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15335 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15337 (attribute_types): Removed.
15338 (EmitCode): Global attributes are emited as the latest.
15340 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15342 * class.cs (EmitFieldInitializers): Don't emit field initializer
15343 for default values when optimilization is on.
15345 * constant.cs (Constant.IsDefaultValue): New property.
15347 * driver.cs: Add /optimize handling.
15351 * literal.cs: Implement new IsDefaultValue property.
15353 * rootcontext.cs (Optimize): New field, holds /optimize option.
15355 2005-02-18 Raja R Harinath <rharinath@novell.com>
15357 Fix crasher in re-opened #72347.
15358 * namespace.cs (Namespace.Lookup): Return null if
15359 DeclSpace.DefineType returns null.
15362 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15364 2005-02-18 Raja R Harinath <rharinath@novell.com>
15366 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15367 now returns null if it cannot resolve to an lvalue.
15368 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15369 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15370 returned null. Remove check for SimpleName.
15371 (EventExpr.DoResolveLValue): New.
15372 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15373 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15375 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15376 avoid CS0131 error.
15377 (Unary.ResolveOperator): Move CS0211 check ...
15378 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15380 (Unary.DoResolveLValue): Simplify.
15381 (AddressOf.DoResolveLValue): New.
15382 (ArrayAccess.DoResolveLValue): New.
15384 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15386 * attribute.cs (Attribute.Resolve): Add arguments casting for
15387 when types doesn't match ctor arguments.
15389 2005-02-16 Raja R Harinath <rharinath@novell.com>
15391 Fix parts of #63202.
15392 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15393 lookup of operator in base type. Ensure that all checks happen
15394 when the operator resolves to an "op_..." method.
15396 2005-02-15 Raja R Harinath <rharinath@novell.com>
15399 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15400 'ignore_cs0104' parameter. Pass it to ...
15401 (NamespaceEntry.Lookup): ... this.
15402 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15403 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15404 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15405 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15406 Update. Request that cs0104 errors be ignored.
15407 (ComposedCast.ResolveAsTypeStep): Update.
15409 2005-02-14 Raja R Harinath <rharinath@novell.com>
15412 * expression.cs (Invocation.BetterFunction): Remove support for
15413 comparing virtual functions and their overrides.
15414 (Invocation.IsOverride): New.
15415 (Invocation.OverloadResolve): Don't consider 'override' functions
15416 during candidate selection. Store them in a lookaside list.
15417 If the selected method is a 'virtual' function, use the list to
15418 find any overrides that are closer to the LHS type.
15420 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15422 * expression.cs (New.DoResolve): Add complex core type reduction.
15423 (New.Constantify): Converts complex core type syntax like 'new int ()'
15424 to simple constant.
15426 2005-02-14 Raja R Harinath <rharinath@novell.com>
15428 * decl.cs (EntryType.EntryType): New constructor to create an
15429 updated copy of a cache entry.
15430 (MemberCache.AddMethods): Use it.
15431 (MemberCache.ClearDeclaredOnly): Remove.
15432 (MemberCache.MemberCache): Update.
15434 2005-02-11 Miguel de Icaza <miguel@novell.com>
15436 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15437 variable. This one is represents the actual low-level declaration
15438 of the method, as opposed to the semantic level `IsStatic'.
15440 An anonymous method which is hosted into a static method might be
15441 actually an instance method. IsStatic would reflect the
15442 container, while MethodIsStatic represents the actual code
15445 * expression.cs (ParameterReference): Use the new MethodIsStatic
15446 instead of IsStatic.
15448 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15449 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15450 set on the current EmitContext.
15452 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15453 resolve our casted expression as an LValue. This triggers the
15454 proper LValue processing that is later required by Assign.
15458 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15460 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15462 C# 2.0 Fixed buffer implementation
15464 * anonymous.cs: Update after RegisterHelperClass renaming.
15466 * attribute.cs (AttributeTester.fixed_buffer_cache):
15467 Cache of external fixed buffers.
15468 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15469 implementation if field is fixed buffer else null.
15472 (TypeContainer.AddField): Accept FieldMember instead of Field.
15473 (FieldBase.IsFieldClsCompliant): Extracted code from
15474 VerifyClsCompliance descendant customization.
15475 (FixedField): New class handles fixed buffer fields.
15476 (FixedFieldExternal): Keeps information about imported fixed
15478 (IFixedField): Make access to internal or external fixed buffer
15481 * cs-parser.jay: Add fixed buffer parsing.
15483 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15486 * expression.cs (Indirection): Extended implementation to accept
15487 fixed buffer field.
15488 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15489 (ElementAccess.MakePointerAccess): Get type as parameter.
15490 (DoResolve): Add fixed buffer field expression conversion.
15491 (DoResolveLValue): Ditto.
15492 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15493 (ArrayPtr): Derives from FixedBufferPtr.
15494 (ArrayPtr.Emit): Add extra emit for array elements.
15496 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15498 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15499 for compiler generated types.
15500 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15502 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15503 and consume less memory.
15504 (Fixed.Resolve): Add fixed buffer case.
15506 * typemanager.cs (compiler_generated_attr_ctor,
15507 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15508 (HasElementType): Add our own implementation to work on every
15511 2005-02-11 Miguel de Icaza <miguel@novell.com>
15513 * anonymous.cs (CaptureContext): Track whether `this' has been
15516 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15517 only captured `this' if it was implicitly done (instance
15518 methods/variables were used).
15520 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15521 `this' must be captured.
15523 2005-01-30 Miguel de Icaza <miguel@novell.com>
15525 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15526 is null it means that there has been no need to capture anything,
15527 so we just create a sibling.
15529 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15531 Just a partial fix. The other half is fairly elusive.
15533 2005-02-10 Raja R Harinath <rharinath@novell.com>
15535 Fix #52586, cs0121-4.cs.
15536 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15537 and return a hashtable.
15538 (MemberCache.ClearDeclaredOnly): New.
15539 (MemberCache.MemberCache): Update to change. Make a deep copy of
15540 the method_hash of a base type too.
15541 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15542 type methods. Overwrite entries with the same MethodHandle so
15543 that the ReflectedType is correct. The process leaves in base
15544 virtual functions and their overrides as distinct entries.
15545 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15546 matters since it was boxed in a ArrayList before.
15547 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15549 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15550 case of a virtual function and its override (choose the overload
15552 (Invocation.OverloadResolve): Avoid 'override' members during
15553 'applicable_type' calculation.
15555 2005-02-09 Raja R Harinath <rharinath@novell.com>
15557 Combine two near-redundant caches.
15558 * typemanager.cs (method_params): Rename from method_internal_params.
15559 (TypeManager.GetParameterData): New. Replace
15560 Invocation.GetParameterData.
15561 (TypeManager.LookupParametersByBuilder): Remove.
15562 * expression.cs (Invocation.method_parameter_cache): Remove.
15563 (Invocation.GetParameterData): Remove.
15565 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15568 2005-02-08 Raja R Harinath <rharinath@novell.com>
15571 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15572 TypeManager.multicast_delegate_type is null, resolve it by looking
15573 up "System.MulticastDelegate".
15574 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15576 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15577 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15578 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15581 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15582 (LabeledStatement.AddReference): New. Set 'referenced'.
15583 (Goto.Resolve): Use it.
15585 2005-02-05 John Luke <john.luke@gmail.com>
15587 * driver.cs: remove duplicate -doc line in Usage ()
15589 2005-02-04 Raja R Harinath <rharinath@novell.com>
15591 * location.cs (Location.AddFile): Fix CS2002 error report.
15593 2005-02-02 Martin Baulig <martin@ximian.com>
15595 * delegate.cs (Delegate.DefineType): Report an internal error if
15596 TypeManager.multicast_delegate_type is null. See bug #72015 for
15599 2005-02-02 Raja R Harinath <rharinath@novell.com>
15601 Fix a crasher in a variant of #31984.
15602 * const.cs (Constant.CheckBase): New override that defers the
15603 new-or-override check in case the base type hasn't been populated
15605 (Constant.Define): Ensure the new-or-override check is performed.
15607 2005-02-01 Duncan Mak <duncan@ximian.com>
15609 * const.cs (LookupConstantValue): Check that `ce' is not null
15610 before calling GetValue ().
15612 2005-02-01 Raja R Harinath <rharinath@novell.com>
15614 Fix test-334.cs (#69519).
15615 * cs-parser.jay (using_alias_directive): Pass in an expression to
15616 NamespaceEntry.UsingAlias.
15617 (using_namespace_directive): Pass in an expression to
15618 NamespaceEntry.Using.
15619 (namespace_name): Don't flatten to a string.
15620 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15621 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15623 (NamespaceEntry.UsingEntry): Likewise.
15624 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15626 (NamespaceEntry.LookupForUsing): Remove.
15627 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15629 (NamespaceEntry.Lookup): Remove support for dotted names.
15631 2005-02-01 Raja R Harinath <rharinath@novell.com>
15633 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15635 (NamespaceEntry.ImplicitParent): Compute on demand.
15636 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15637 parallels the current.
15638 (NamespaceEntry.LookupForUsing): Use it.
15639 (NamespaceEntry.Lookup): If the current namespace-entry is
15640 implicit, don't search aliases and using tables.
15642 2005-02-01 Raja R Harinath <rharinath@novell.com>
15645 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15647 (TypeContainer.BaseCache): Compute on demand.
15648 (TypeContainer.FindMembers): Define constants and types if they're
15649 not already created.
15650 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15652 * const.cs (Constant.Define): Make idempotent.
15654 2005-01-29 Miguel de Icaza <miguel@novell.com>
15656 * pending.cs: Produce better code (no nops produced by using Ldarg
15659 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15660 i - 1' it should be arg + 1.
15664 2005-01-28 Raja R Harinath <rharinath@novell.com>
15666 * attribute.cs (Attribute.CheckAttributeType): Make private
15668 (Attribute.ResolveType): Make virtual.
15669 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15670 handling of RootContext.Tree.Types.
15672 2005-01-27 Raja R Harinath <rharinath@novell.com>
15674 Update attribute-handling to use the SimpleName/MemberAccess
15676 * cs-parser.jay (attribute): Pass in an expression to the
15677 constructors of Attribute and GlobalAttribute.
15678 * attribute.cs (Attribute): Take an expression for the name.
15679 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15680 passed in attribute name expression.
15681 (Attribute.CheckAttributeType): Use it.
15682 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15683 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15684 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15685 argument to prevent error messages if the lookup fails.
15687 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15689 * expression.cs (Indirection): Implemented IVariable interface
15690 to support indirection in AddressOf operator.
15691 (PointerArithmetic.Emit): Add optimalization for case where
15692 result can be precomputed.
15694 2005-01-26 Martin Baulig <martin@ximian.com>
15696 * class.cs (TypeContainer.AttributeTargets): Return the correct
15697 AttributeTargets depending on our `Kind' instead of throwing an
15698 exception; fixes #71632.
15700 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15703 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15706 2005-01-25 Raja R Harinath <rharinath@novell.com>
15709 * expression.cs (MemberAccess.DoResolve): Don't complain with
15710 cs0572 when the LHS of a member access has identical name and type
15713 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15716 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15718 Create custom PermissionSet only for PermissionSetAttribute.
15720 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15723 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15724 delegates in static class.
15726 2005-01-24 Martin Baulig <martin@ximian.com>
15728 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15729 merging an implicit block, just use its reachability.
15731 * statement.cs (Block.Resolve): Make the unreachable code check
15732 work wrt. implicit blocks; see test-337 from #63842.
15734 2005-01-21 Alp Toker <alp@atoker.com>
15736 * cs-parser.jay: destructor_declaration's container is PartialContainer
15737 not Class when partial types are used, so use Kind prop instead of
15740 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15742 * cs-parser.jay: Improve error reporting when an interface
15743 declares new types.
15745 2005-01-20 Dick Porter <dick@ximian.com>
15747 * support.cs: SeekableStreamReader fix from Sandor Dobos
15748 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15749 chars are read. Fixes bug 70369.
15751 2005-01-20 Raja R Harinath <rharinath@novell.com>
15753 * cs-parser.jay (catch_clause): Simplify current_block handling
15756 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15758 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15759 code with ImplicitStandardConversion to handle the implicit
15760 conversion of method groups into valid delegate invocations.
15762 The problem is that in parameter handling we were using this code
15763 path. Fixes bug #64698
15765 2005-01-19 Raja R Harinath <rharinath@novell.com>
15767 * cs-parser.jay: Fix several infelicities.
15768 - Avoid assigning to the parser value stack. Code like
15769 '$3 = null' is unclean. Synthesize a value for the code block
15771 - Avoid using oob_stack for storing location information. Use ...
15772 (_mark_): ... this. New (empty) rule. Saves the current location
15774 (foreach_statement): Avoid using oob_stack for current_block
15775 handling. Use technique used in for_statement and
15776 using_statement. Synthesize a value for the code block to store
15777 additional intermediate information.
15779 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15781 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15782 of a different type is only allowed to private fields of a
15783 containing type, not on fields of a base class.
15785 See test-174.cs and error cs0122-9.cs
15787 2005-01-13 Raja R Harinath <rharinath@novell.com>
15789 Fix test-335.cs (bug #58126).
15790 * cs-parser.jay (argument): Split out non-expression parts of the
15791 rule into 'non_simple_argument'.
15792 (invocation_expression): Support parenthesized invocations with
15793 multiple arguments, and with single non-simple arguments.
15795 2005-01-13 Raja R Harinath <rharinath@novell.com>
15797 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15800 2005-01-12 Raja R Harinath <rharinath@novell.com>
15802 Fix cs0038-1.cs, cs1640-6.cs.
15803 * ecore.cs (Expression.Resolve): Remove special-case for
15804 SimpleName in error-handling.
15805 (Expression.almostMatchedMembers): Relax access permission to
15807 (Expression.MemberLookupFailed): Handle duplicates in
15808 almostMatchedMembers list.
15809 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15810 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15811 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15812 overload if the passed in MemberInfo is a MethodBase.
15814 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15817 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15818 for non-CAS & merge permission sets properly.
15820 2005-01-11 Raja R Harinath <rharinath@novell.com>
15822 Improve standard-compliance of simple name and member access
15823 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15824 * ecore.cs (FullNamedExpression): New abstract base class
15825 for Namespaces and TypeExpressions.
15826 (ResolveFlags.SimpleName): Remove.
15827 (SimpleName): Remove support for dotted names.
15828 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15829 DeclSpace.FindType and DeclSpace.LookupType.
15830 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15831 (Expression.ExprClassName): Make member function.
15832 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15833 a namespace. Remove creation of dotted "SimpleName"s.
15834 (MemberAccess.DoResolve): Likewise.
15835 * decl.cs (DeclSpace.Cache): Make private.
15836 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15837 (DeclSpace.FindType): Update.
15838 (DeclSpace.LookupType): Move here from RootContext. Return a
15839 FullNamedExpression.
15840 * namespace.cs (Namespace): Derive from FullNamedExpression
15841 so that it can be part of expression resolution.
15842 (Namespace.Lookup): Return an FullNamedExpression.
15843 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15845 * rootcontext.cs (NamespaceLookup): Remove.
15846 (LookupType): Move to DeclSpace.
15847 * attribute.cs (CheckAttributeType): Update.
15848 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15849 (FindDocumentedTypeNonArray): Likewise.
15851 2005-01-11 Raja R Harinath <rharinath@novell.com>
15853 Fix cs0509.cs, cs1632.cs.
15854 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15855 is the same as IsInterface.
15856 (TypeContainer.GetClassBases): Likewise.
15857 * statement.cs (LabeledStatement.ig): New field.
15858 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15860 (LabeledStatement.DoEmit): Check that the label was created with
15861 the same ILGenerator.
15863 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15866 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15867 accessors to its properties.
15869 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15870 from accessors to property.
15872 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15875 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15876 only for overrides.
15878 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15880 * attribute.cs: Check for null and empty strings.
15882 I have lost another battle to Paolo.
15884 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15887 * class.cs (PropertyMethod): Set Parent field in ctors.
15888 (SetMethod.InternalParameters): Add unsafe switch hack.
15889 Override MarkForDuplicationCheck where it is appropriate.
15891 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15892 It says whether container allows members with the same name.
15893 Base default is no.
15894 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15895 Removed is_method parameter.
15897 2005-01-06 Duncan Mak <duncan@ximian.com>
15899 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15900 because the previous change led to incorrect reporting of CS1032
15901 ("Cannot define/undefine preprocessor symbols after first token in
15902 file"). Instead of using `tokens_seen' as the only flag that
15903 triggers CS1040, introduce `comments_seen'. This new flag is used
15904 to signify having seen comments on the current line, so it is
15905 unset after a newline.
15907 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15909 * doc.cs : When searching for a type, find nested type too.
15910 This fixes bug #71040.
15912 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15915 - Warn missing member comment on those classes which also does not
15916 have doc comments. Fixed bug #71041.
15917 - Don't warn missing doc comment on default constructor.
15920 2005-01-06 Duncan Mak <duncan@ximian.com>
15922 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15923 comments, set `tokens_seen' to true. This allows us to detect
15924 misplaced preprocessor directives (i.e. not at the beginning of
15925 the a line, nor after whitespaces). In that case, report error
15926 CS1040. This fixes bug #56460.
15928 * cs-parser.jay (interface_member_declaration): Add checks for
15929 IsExplicitImpl, and report CS0541 error if an interface member is
15930 defined as an explicit interface declaration.
15932 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15935 * class.cs (PropertyMethod): Set Parent field in ctors.
15936 (SetMethod.InternalParameters): Add unsafe switch hack.
15938 * decl.cs (MemberCore.Parent): Cannot be readonly.
15940 2005-01-06 Raja R Harinath <rharinath@novell.com>
15942 * decl.cs (DeclSpace.ResolveType): Remove.
15943 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15944 Merge in code from ...
15945 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15946 * class.cs, enum.cs: Update to changes.
15948 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15950 * anonymous.cs: Ensure that we init the scope of our parent if it
15951 has not been initialized yet.
15953 2004-12-30 Duncan Mak <duncan@ximian.com>
15955 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15956 if field.FieldBuilder is null. Fixes #70758.
15958 * convert.cs: Fixed some typos and updated some of the comments.
15959 (ImplicitStandardConversionExists):
15960 (TryImplicitIntConversion): If `target_type' is an interface and
15961 the type of `ic' implements this interface, return true or a new
15962 BoxedCast instead of null. This fixes #70468.
15964 2004-12-29 Duncan Mak <duncan@ximian.com>
15966 * expression.cs (Argument.Emit): Check that Expr is
15967 IMemoryLocation before casting to it, and report CS1510 otherwise.
15971 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15973 * statement.cs (Block.ThisVariable): remove the recursion here, to
15974 make the --profile more sane.
15976 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15978 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15979 assembly, by JB Evain.
15981 2004-12-17 Raja R Harinath <rharinath@novell.com>
15983 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15984 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15985 "parent" refers to enclosing type/class. "base" refers to superclass.
15987 2004-12-17 Raja R Harinath <rharinath@novell.com>
15989 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15990 Ensure that we only have GlobalAttributes.
15991 * attribute.cs (Attribute.Emit): Make non-virtual.
15992 (GlobalAttribute.Emit): Remove.
15993 (Attribute.Resolve): Make virtual.
15994 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15995 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15996 the argument. Don't create one.
15997 (Attribute.GetObsoleteAttribute): Likewise.
15998 (Attribute.GetClsCompliantAttributeValue): Likewise.
15999 * class.cs, decl.cs: Update to changes.
16001 2004-12-17 Marek Safar <marek.safar@seznam.cz>
16003 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
16005 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
16007 * statement.cs (Foreach.Resolve): Add error 186 report.
16009 2004-12-16 Marek Safar <marek.safar@seznam.cz>
16011 * expression.cs (Conditional.DoResolve): Add warning 429.
16013 * statement.cs (If.Resolve): Add warning 665.
16015 2004-12-16 Raja R Harinath <rharinath@novell.com>
16017 New invariant: RootContext.Tree.Types.NamespaceEntry == null
16018 except when in the parser, and in GlobalAttribute.
16019 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
16020 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
16021 RootContext.Tree.Types.NamespaceEntry once work is done.
16022 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
16023 and resets RootContext.Tree.Types.NamespaceEntry.
16025 2004-12-15 Marek Safar <marek.safar@seznam.cz>
16027 * cs-parser.jay: Don't create a block for every variable.
16029 2004-12-14 Miguel de Icaza <miguel@ximian.com>
16031 * location.cs: Provide extra information.
16033 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
16034 variables from the captured environment, it is the ldarg_0.
16036 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16038 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
16041 * class.cs: Changed warning level for 169 to avoid developer
16042 displeasure from warning flooding. It will be changed back when they
16043 fix most of current BCL warnings.
16045 * RootContext.cs: Pushed default WarningLevel to 3.
16047 * statement.cs: Removed unused variable.
16049 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16051 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16052 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16053 Add error 502 report.
16054 (StaticClass.DefineType): Add error 441 report.
16055 (Class.AllowedModifiersProp): New virtual property as temporary
16056 extension to AllowedModifiers.
16057 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16058 to share implementation with StaticClass and don't call virtual
16061 * driver.cs (MainDriver): Add error 1558 test.
16063 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16064 report. Moved error 36 test here.
16066 * statement.cs (Throw.Resolve): Add error 724 report.
16068 * typemanager.cs: Add out_attribute_type core type.
16070 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16072 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16074 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16076 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16079 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16081 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16082 Add error 3023 report.
16083 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16085 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16088 2004-12-12 John Luke <john.luke@gmail.com>
16090 * driver.cs (AddArgs): take -- into account when
16091 adding arguments, fixes bug 65710
16093 2004-12-12 Martin Baulig <martin@ximian.com>
16095 * expression.cs (Unary.TryReduceNegative): Added support for
16096 SByteConstant and ByteConstant.
16097 (Unary.Reduce): Check error values from TryReduceNegative().
16099 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16101 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16102 and report exception as error 182.
16104 2004-12-10 Raja R Harinath <rharinath@novell.com>
16106 * driver.cs (Main): Fix message when there are warnings.
16108 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16110 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16112 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16114 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16115 Reduced number of warnings.
16117 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16119 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16121 * driver.cs: Removed message.
16123 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16125 2004-12-08 <vargaz@freemail.hu>
16127 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16129 2004-12-08 Martin Baulig <martin@ximian.com>
16131 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16132 instead of a CS3002 for properties and indexer.
16134 2004-12-08 Martin Baulig <martin@ximian.com>
16136 * decl.cs (MemberName.ToString): Make this work again.
16138 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16140 * attribute.cs (Resolve): Add error 591 detection.
16142 * class.cs (FieldMember.Define): Add error 1547 detection.
16143 (Indexer.Define): Add error 620 detection.
16144 (Operator.Define): Add error 590 detection.
16146 * ecore.cs: Missing argument for error 79.
16148 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16151 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16154 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16157 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16159 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16160 Some operator comments were suppressed.
16161 * doc.cs : Implicit/explicit operator name in doc comments are like
16162 "op_Explicit(type)~returnType", so added suffix handling.
16164 2004-12-07 Martin Baulig <martin@ximian.com>
16167 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16168 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16169 (DeclSpace.ec): New protected field; store the EmitContext here.
16170 (DeclSpace.EmitContext): New public property; moved here from
16172 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16175 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16176 (Enum.Emit): Don't create a new EmitContext.
16178 * delegate.cs (Delegate.DefineType): Always create the
16181 * iterators.cs (Iterators.DefineIterator): Create a new
16182 EmitContext and store it in `ec'.
16184 2004-08-24 Martin Baulig <martin@ximian.com>
16187 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16188 this for accessibility checks.
16189 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16190 IsNestedFamilyAccessible.
16191 (TypeManager.IsSubclassOf): New method, do what the name actually
16194 2004-12-06 Raja R Harinath <rharinath@novell.com>
16196 Fix crash on cs0657-17.cs.
16197 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16198 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16199 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16200 the case where the NamespaceEntry gets overwritten.
16202 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16204 Fixed #69195, #56821
16205 * ecore.cs (ResolveBoolean): Tiny refactoring.
16207 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16208 of right expression resolving when left is false constant and
16209 operator is LogicalAnd OR true constant and operator is LogicalOr.
16211 * statement.cs (ResolveUnreachable): Always reports warning.
16213 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16215 * class.cs: Distinguish between 1721 and 1722 (just a little help
16216 for the programmer).
16218 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16220 * delegate.cs: Only allow this on new versions of the language.
16222 2004-12-02 Duncan Mak <duncan@ximian.com>
16224 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16226 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16227 here as a static method. Take an additional bool out parameter
16228 `must_do_cs1540_check' for signaling to InstanceResolve.
16229 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16230 member field from PropertyExpr class and made it an argument of
16231 the method instead.
16232 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16233 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16234 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16235 and `remove_accessor' as well as InstanceResolve: report CS0122
16240 2004-12-03 Raja R Harinath <rharinath@novell.com>
16242 Fix test-327.cs, test-328.cs, and put in early infrastructure
16243 for eventually fixing #52697.
16244 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16245 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16246 from other methods.
16247 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16248 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16249 (VerifyUsing, error246): Update.
16250 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16251 'NamespaceEntry.LookupNamespaceOrType'.
16253 2004-12-03 Martin Baulig <martin@ximian.com>
16255 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16256 method as our child, call AnonymousMethod.Compatible() on it.
16258 2004-12-03 Raja R Harinath <rharinath@novell.com>
16260 Disable XML documentation support in 'basic' profile.
16261 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16262 Redirect XmlElement to System.Object.
16263 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16264 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16265 * mcs.exe.sources: Add doc-bootstrap.cs.
16266 * doc-bootstrap.cs: New file. Contains empty stub implementation
16269 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16271 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16272 comments are allowed.
16274 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16276 * delegate.cs: Add checks for subtypes in paramaters and return values
16277 in VerifyMethod () to add support for Covariance/Contravariance
16280 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16282 * report.cs: Remove extra closing parenthesis.
16284 * convert.cs (Error_CannotImplicitConversion): If the name of the
16285 types are the same, provide some extra information.
16287 * class.cs (FieldBase): Use an unused bit field from the field to
16288 encode the `has_offset' property from the FieldMember. This saves
16289 a couple of Ks on bootstrap compilation.
16291 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16292 method as our child, return the AnonymousMethod resolved
16295 * expression.cs (New.DoResolve): Allow return values from
16296 NewDelegate to also include AnonymousMethods.
16300 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16303 * attribute.cs (Resolve): Improved implementation of params
16304 attribute arguments.
16306 * support.cs (ParameterData): Add HasParams to be faster.
16308 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16310 all things are for /doc support:
16312 * doc.cs: new file that supports XML documentation generation.
16313 * mcs.exe.sources: added doc.cs.
16315 Handle /doc command line option.
16316 Report error 2006 instead of 5 for missing file name for /doc.
16317 Generate XML documentation when required, after type resolution.
16319 Added support for picking up documentation (/// and /** ... */),
16320 including a new XmlCommentState enumeration.
16322 Added lines to fill Documentation element for field, constant,
16323 property, indexer, method, constructor, destructor, operator, event
16324 and class, struct, interface, delegate, enum.
16325 Added lines to warn incorrect comment.
16327 Added Documentation field (passed only when /doc was specified).
16329 Added DocComment, DocCommentHeader, GenerateDocComment() and
16330 OnGenerateDocComment() and some supporting private members for
16331 /doc feature to MemberCore.
16333 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16335 Added overriden DocCommentHeader.
16337 Added overriden DocCommentHeader and GenerateDocComment().
16339 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16341 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16342 unwrapping the enumeration values, chain to
16343 DoConstantNumericPromotions again, so we can promote things to the
16344 fundamental types (takes care of enums that are bytes, sbytes).
16348 2004-12-01 Raja R Harinath <rharinath@novell.com>
16350 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16351 Fix long-standing bug in type-lookup. Use FindType instead of
16352 LookupType when ec.ResolvingTypeTree.
16353 (Attribute.ResolveType, Attribute.Resolve)
16354 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16356 (Attributes.Search): Remove internal version. Update.
16357 (Attributes.SearchMulti): Update.
16358 (Attributes.GetClsCompliantAttribute): Remove.
16359 (Attributes.GetIndexerNameAttribute): Remove.
16360 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16361 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16362 * class.cs (Indexer.Define): Likewise.
16364 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16367 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16368 MarshallByReference members access.
16370 * expression.cs: Use CheckMarshallByRefAccess;
16371 Better error CS0197 message.
16373 * report.cs: Print whole related error message.
16375 2004-11-30 Raja R Harinath <rharinath@novell.com>
16377 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16378 the current directory to help debugging.
16380 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16382 * class (GetClassBases): Better error 60 report.
16383 (EventProperty): Disabled warning 67 detection.
16385 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16388 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16390 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16393 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16396 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16398 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16400 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16402 * attribute.cs (Attribute.Resolve): Refine error reporting and
16403 report a cs0117 if the identifier does not exist, to distinguish
16404 from 0617 which is a miss-use of the actual identifier.
16406 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16407 between cs0070 and cs0079.
16409 * class.cs (MemberBase.DoDefine): When reporting a wrong
16410 accessibility level, we use MethodCore to compare instead of
16411 Method (this was a regression in some refactoring effort).
16413 So now we correctly report cs0056 again.
16415 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16416 testing the target_type (which was known to be object_type) and
16417 not the source type (which is anonymous_method).
16419 Fixed reporting of error cs1660.
16421 * expression.cs (UserCast.Source): Expose the underlying cast.
16423 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16424 allowed types to find a match to int32 first (most common).
16426 In addition, it ignores any ImplicitUserConversions that did an
16427 internal implicit conversion (as the switch statement allows only
16428 one integral conversion to exist).
16430 * class.cs (PartialContainer.Create): rename `name' to
16431 `member_name' for clarity. Then replace the string calls with a
16432 call to MemberName.GetPartialName, as now using
16433 MemberName.ToString is an error (this is due to the side effects
16434 it had, that were fixed in the past).
16436 This will restore the error reporting on a number of partial class
16437 errors that were missusing this (and getting an exception as a
16438 results, which is now just a plain textual warning, because
16439 yyparse debug output would crash otherwise).
16441 2004-11-26 Raja R Harinath <rharinath@novell.com>
16443 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16445 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16447 * rootcontext.cs (LookupType): Make sure to cache lookups that
16448 don't give us a negative result. This saves about 5% of corlib
16451 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16453 * report.cs (AbstractMessage.Print): messages are sent to stderr
16455 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16456 non-interface in the list of interfaces (at this point, either
16457 parent was properly set, or a base class is being listed in the
16458 interfaces section).
16460 This flags error 1722, and resolves the crash from bug 69259.
16462 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16464 * statement.cs (Using.EmitExpressionFinally): make this work right
16465 for valuetypes. Fixes 69926.
16467 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16469 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16470 converted to an enum" here, before we try to change the underlying
16471 type. This code exists, but it is a different code path than the
16472 one used while encoding constants.
16474 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16475 old bug: when converting from the null literal to a pointer,
16476 return an EmptyCast, not the NullLiteral.
16478 This fixes #69921, the recent null_type changes probably made this
16479 bug more prominent.
16481 (ImplicitReferenceConversionExists): In addition, resynchronized
16482 the code here, so it matches the same code in
16483 ImplicitReferenceConversionExists for the `from any class-type S
16484 to any interface-type T'.
16487 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16489 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16491 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16493 * cs-parser.jay: Use verbosity accordingly.
16495 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16497 * expression.cs (Unary.ResolveOperator): Do not report warning;
16498 AddressOf reads from variable.
16500 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16502 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16506 * attribute.cs (Attributable): Removed CheckTargets.
16507 (Attributes.Emit): Explicit attribute targets are tested here.
16509 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16510 not enabled for interfaces.
16512 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16513 (GetAssemblyName): Ouch next bug there.
16515 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16517 * expression.cs: Error 275 added.
16519 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16521 Fix bug #69177 (Implemented decimal constant support)
16523 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16524 (BinaryFold): Add DecimalConstant.
16526 * const.cs (Define): Decimal constant
16528 (ChangeType): Add decimal type handling.
16529 (LookupConstantValue): Don't set value for decimal type but
16530 emit DecimalConstantAttribute. Needed for constant optimization.
16532 * constant.cs (ToDecimal): New method.
16533 (ConvertToDecimal): New method.
16534 (IntConstant): Implemented ConvertToDecimal.
16535 (DecimalConstant.Emit): Emit optimized version for decimals in
16538 * expression.cs (ResolveOperator): Changed order of constant
16539 reduction to work correctly with native types which have
16540 overloaded operators.
16541 (ResolveMemberAccess): Extract constant value from attribute
16544 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16546 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16547 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16548 (ChangeType): Decimal is special.
16549 (TypeToCoreType): Add decimal type.
16551 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16553 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16556 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16558 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16561 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16563 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16565 * pending.cs (PendingImplementation): Grab only interfaces.
16567 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16569 * statement.cs (ForeachHelperMethods): Add location member and
16570 error 202 detection.
16572 2004-11-19 Raja R Harinath <rharinath@novell.com>
16574 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16575 automatically handled by executable.make.
16576 (PROGRAM): Make profile-specific.
16578 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16580 * expression.cs (DoResolveBase): Fixed wrong warning for out
16583 2004-11-18 Martin Baulig <martin@ximian.com>
16585 Merged latest changes into gmcs. Please keep this comment in
16586 here, it makes it easier for me to see what changed in MCS since
16587 the last time I merged.
16589 2004-11-17 Raja R Harinath <rharinath@novell.com>
16591 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16592 (TypeHandle.GetMemberCache): New.
16593 (TypeHandle.TypeHandle): Update.
16594 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16595 (TypeManager.LookupParentInterfacesCache):
16596 Rename from LookupInterfaceCache. Optimize slightly.
16597 (TypeManager.MemberLookup_FindMembers): Update.
16598 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16599 multi-type variant.
16600 (AddCacheContents): Rename from AddHashtable.
16601 * class.cs (TypeContainer.parent_container): Remove.
16602 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16603 (TypeContainer.DoDefineMembers): Don't initialize it.
16604 Update to name changes.
16606 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16608 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16609 that factors the code to check access modifiers on override.
16611 (PropertyBase): Use the code here.
16613 Patch from Lluis S'anchez, fixes bug #69361.
16615 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16617 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16618 routine that is used to report the use of a captured variable
16619 whose address has been taken.
16621 There are two checks: one when variables are being captured and
16622 the other check is when the address of a variable is taken.
16624 (because an anonymous methods might be resolved before *or* after
16625 the address has been taken) and
16627 * expression.cs (Conditional.DoResolve): Remove the special
16628 casing that Martin added to trueExpr and falseExpr being both
16629 NullLiteral. We get the right behavior now just by introducing
16630 the null_type into the compiler.
16632 * convert.cs (ExplicitConversion): Change the code to use
16633 null_type instead of testing `expr is NullLiteral'.
16634 (ImplicitConversionStandard): use null_type too.
16635 (ImplicitReferenceConversionExists): use null_type too.
16636 (ImplicitReferenceConversion): use null_type too.
16638 * literal.cs: The type of `NullLiteral' is now null_type instead
16640 (Resolve): Set the type here.
16642 * typemanager.cs: Introduce null_type.
16644 2004-11-17 Martin Baulig <martin@ximian.com>
16646 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16647 direction, like FindMembers() does. Fixes #69546, testcase is in
16650 2004-11-16 Martin Baulig <martin@ximian.com>
16652 This is based on a patch from Marek Safar, see bug #69082.
16653 Fixes bugs #63705 and #67130.
16655 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16656 method; create a MemberCache for an interface type and cache the
16659 * decl.cs (IMemberContainer.ParentContainer): Removed.
16660 (IMemberContainer.ParentCache): New property.
16661 (MemberCache.SetupCacheForInterface): Removed.
16662 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16663 to create a cache for an interface's "parent".
16665 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16668 2004-11-16 Martin Baulig <martin@ximian.com>
16670 Merged back from gmcs; these changes already went into gmcs a
16671 couple of weeks ago.
16674 (TypeManager.AddUserType): Removed the `ifaces' argument.
16675 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16677 (TypeManager.AddUserInterface): Removed.
16678 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16680 (TypeManager.GetInterfaces): Likewise.
16681 (TypeManager.GetExplicitInterfaces): Likewise.
16683 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16685 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16686 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16688 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16690 * statement.cs: Avoid adding bools to a hashtable.
16692 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16694 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16695 calling an unsafe method from a safe location.
16697 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16700 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16702 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16704 * namespace.cs (VerifyUsing): use GetPartialName instead of
16707 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16709 * statement.cs (Return.Resolve): Fix regression in typo: if
16710 `in_exc', we have to request a NeedReturnLabel, this was a typo
16711 introduced in the anonymous method check-in. Fixes #69131.
16713 * Indexers were using the ShortName when defining themselves,
16714 causing a regression in the compiler bootstrap when applying the
16715 patch from 2004-11-02 (first part), now they use their full name
16716 and the bug is gone.
16718 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16720 * driver.cs: Strip the path from the names of embedded resources. Fixes
16723 2004-11-04 Raja R Harinath <rharinath@novell.com>
16725 Fix error message regression: cs0104-2.cs.
16726 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16727 (AliasEntry.Resolve): Update.
16728 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16730 (RootContext.LookupType): Update.
16732 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16734 * cs-parser.jay: Add support for handling accessor modifiers
16735 * class: Add support port accessor modifiers and error checking,
16736 define PropertyMethod.Define as virtual (not abstract anymore)
16737 * ecore.cs: Add checking for proeprties access with access modifiers
16738 * iterators.cs: Modify Accessor constructor call based in the modified
16740 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16742 * expression.cs (StringConcat): Handle being called twice,
16743 as when we have a concat in a field init with more than two
16746 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16748 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16749 special case explicit implementations, we should always produce
16750 the .property or .event declaration.
16752 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16753 since it will not return correct data if people use this
16754 unresolved in the presence of using statements (see test-313).
16756 * class.cs (MethodData.Define): If we are an explicit interface
16757 implementation, set the method name to the full name of the
16758 interface plus the name of the method.
16760 Notice that using the method.MethodName.GetFullName() does not
16761 work, as it will only contain the name as declared on the source
16762 file (it can be a shorthand in the presence of using statements)
16763 and not the fully qualifed type name, for example:
16767 class D : ICloneable {
16768 object ICloneable.Clone () {
16772 Would produce a method called `ICloneable.Clone' instead of
16773 `System.ICloneable.Clone'.
16775 * namespace.cs (Alias.Resolve): Use GetPartialName.
16777 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16779 * cs-parser.jay: Add error 1055 report.
16781 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16783 * assign.cs (Assign.DoResolve): Only do the transform of
16784 assignment into a New if the types are compatible, if not, fall
16785 through and let the implicit code deal with the errors and with
16786 the necessary conversions.
16788 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16790 * cs-parser.jay: Add error 1031 report.
16792 * cs-tokenizer.cs: Add location for error 1038.
16794 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16796 * cs-parser.jay: Add error 1016 report.
16798 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16800 * cs-parser.jay: Add errors 1575,1611 report.
16802 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16804 * cs-parser.jay: Add error 1001 report.
16806 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16809 * attribute.cs (GetMarshal): Add method argument for
16810 caller identification.
16812 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16813 agument for GetMarshal and RuntimeMissingSupport.
16815 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16817 * attribute.cs (ExtractSecurityPermissionSet): Removed
16818 TypeManager.code_access_permission_type.
16820 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16822 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16824 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16825 for obsolete use of a variable here. Fixes regression on errors
16826 cs0619-25 and cs0619-26.
16828 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16830 Fix #62358, implemented security attribute encoding.
16832 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16833 Tests permitted SecurityAction for assembly or other types.
16834 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16835 data from SecurityPermissionAttribute to PermisionSet class.
16837 * class.cs (ApplyAttributeBuilder): Added special handling
16838 for System.Security.Permissions.SecurityAttribute based types.
16840 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16841 special handling for System.Security.Permissions.SecurityAttribute
16844 * enum.cs (ApplyAttributeBuilder): Added special handling
16845 for System.Security.Permissions.SecurityAttribute based types.
16847 * parameter.cs (ApplyAttributeBuilder): Added special handling
16848 for System.Security.Permissions.SecurityAttribute based types.
16850 * rootcontext.cs: Next 2 core types.
16852 * typemanager.cs (TypeManager.security_permission_attr_type):
16853 Built in type for the SecurityPermission Attribute.
16854 (code_access_permission_type): Build in type.
16856 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16858 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16859 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16860 all of this information into
16861 EmitContext.EmitCapturedVariableInstance.
16863 * codegen.cs (EmitCapturedVariableInstance): move here the
16864 funcionality of emitting an ldarg.0 in the presence of a
16865 remapping. This centralizes the instance emit code.
16867 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16868 then emit a load of this: it means that we have reached the
16869 topmost ScopeInfo: the one that contains the pointer to the
16870 instance of the class hosting the anonymous method.
16872 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16873 captures to the topmost CaptureContext.
16875 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16877 * expression.cs (LocalVariableReference): Move the knowledge about
16878 the iterators into codegen's EmitCapturedVariableInstance.
16880 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16882 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16883 all code paths return a value from an anonymous method (it is the
16884 same as the 161 error, but for anonymous methods).
16886 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16888 The introduction of anonymous methods in the compiler changed
16889 various ways of doing things in the compiler. The most
16890 significant one is the hard split between the resolution phase
16891 and the emission phases of the compiler.
16893 For instance, routines that referenced local variables no
16894 longer can safely create temporary variables during the
16895 resolution phase: they must do so from the emission phase,
16896 since the variable might have been "captured", hence access to
16897 it can not be done with the local-variable operations from the runtime.
16901 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16902 is a toplevel block.
16904 (ToplevelBlock): A new kind of Block, these are the blocks that
16905 are created by the parser for all toplevel method bodies. These
16906 include methods, accessors and anonymous methods.
16908 These contain some extra information not found in regular blocks:
16909 A pointer to an optional CaptureContext (for tracking captured
16910 local variables and parameters). A pointer to the parent
16913 (Return.Resolve): Catch missmatches when returning a value from an
16914 anonymous method (error 1662).
16915 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16918 (Break.Resolve): ditto.
16920 (SwitchLabel): instead of defining the labels during the
16921 resolution phase, we now turned the public ILLabel and ILLabelCode
16922 labels into methods called GetILLabelCode() and GetILLabel() that
16923 only define the label during the Emit phase.
16925 (GotoCase): Track the SwitchLabel instead of the computed label
16926 (its contained therein). Emit the code by using
16927 SwitchLabel.GetILLabelCode ().
16929 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16930 whether the Local has been captured or not.
16932 (LocalInfo.IsCaptured): New property, used to tell whether the
16933 local has been captured.
16935 * anonymous.cs: Vastly updated to contain the anonymous method
16938 The main classes here are: CaptureContext which tracks any
16939 captured information for a toplevel block and ScopeInfo used to
16940 track the activation frames for various local variables.
16942 Each toplevel block has an optional capture context associated
16943 with it. When a method contains an anonymous method both the
16944 toplevel method and the anonymous method will create a capture
16945 context. When variables or parameters are captured, they are
16946 recorded on the CaptureContext that owns them, for example:
16950 MyDelegate d = delegate {
16955 Here `a' will be recorded as captured on the toplevel
16956 CapturedContext, the inner captured context will not have anything
16957 (it will only have data if local variables or parameters from it
16958 are captured in a nested anonymous method.
16960 The ScopeInfo is used to track the activation frames for local
16961 variables, for example:
16963 for (int i = 0; i < 10; i++)
16964 for (int j = 0; j < 10; j++){
16965 MyDelegate d = delegate {
16970 At runtime this captures a single captured variable `i', but it
16971 captures 10 different versions of the variable `j'. The variable
16972 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16973 recorded on a child.
16975 The toplevel ScopeInfo will also track information like the `this'
16976 pointer if instance variables were referenced (this is necessary
16977 as the anonymous method lives inside a nested class in the host
16978 type of the method).
16980 (AnonymousMethod): Expanded to track the Toplevel, implement
16981 `AnonymousMethod.Compatible' to tell whether an anonymous method
16982 can be converted to a target delegate type.
16984 The routine now also produces the anonymous method content
16986 (AnonymousDelegate): A helper class that derives from
16987 DelegateCreation, this is used to generate the code necessary to
16988 produce the delegate for the anonymous method that was created.
16990 * assign.cs: API adjustments for new changes in
16991 Convert.ImplicitStandardConversionExists.
16993 * class.cs: Adjustments to cope with the fact that now toplevel
16994 blocks are of type `ToplevelBlock'.
16996 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16997 insteda of standard blocks.
16999 Flag errors if params arguments are passed to anonymous methods.
17001 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
17002 `CurrentAnonymousMethod' which points to the current Anonymous
17003 Method. The variable points to the AnonymousMethod class that
17004 holds the code being compiled. It is set in the new EmitContext
17005 created for the anonymous method.
17007 (EmitContext.Phase): Introduce a variable and an enumeration to
17008 assist in enforcing some rules about when and where we are allowed
17009 to invoke certain methods (EmitContext.NeedsReturnLabel is the
17010 only one that enfonces this right now).
17012 (EmitContext.HaveCaptureInfo): new helper method that returns
17013 whether we have a CapturedContext initialized.
17015 (EmitContext.CaptureVariable): New method used to register that a
17016 LocalInfo must be flagged for capturing.
17018 (EmitContext.CapturedParameter): New method used to register that a
17019 parameters must be flagged for capturing.
17021 (EmitContext.CapturedField): New method used to register that a
17022 field must be flagged for capturing.
17024 (EmitContext.HaveCapturedVariables,
17025 EmitContext.HaveCapturedFields): Return whether there are captured
17026 variables or fields.
17028 (EmitContext.EmitMethodHostInstance): This is used to emit the
17029 instance for the anonymous method. The instance might be null
17030 (static methods), this (for anonymous methods that capture nothing
17031 and happen to live side-by-side with the current method body) or a
17032 more complicated expression if the method has a CaptureContext.
17034 (EmitContext.EmitTopBlock): Routine that drives the emission of
17035 code: it will first resolve the top block, then emit any metadata
17036 and then emit the code. The split is done so that we can extract
17037 any anonymous methods and flag any captured variables/parameters.
17039 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
17040 during this phase, the ILGenerator should not be used as labels
17041 and local variables declared here might not be accessible to any
17042 code that is part of an anonymous method.
17044 Exceptions to this include the temporary variables that are
17045 created by some statements internally for holding temporary
17048 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17051 (EmitContext.TemporaryReturn): This method is typically called
17052 from the Emit phase, and its the only place where we allow the
17053 ReturnLabel to be defined other than the EmitMeta. The reason is
17054 that otherwise we would have to duplicate a lot of logic in the
17055 Resolve phases of various methods that today is on the Emit
17058 (EmitContext.NeedReturnLabel): This no longer creates the label,
17059 as the ILGenerator is not valid during the resolve phase.
17061 (EmitContext.EmitThis): Extended the knowledge in this class to
17062 work in anonymous methods in addition to iterators.
17064 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17065 code is necessary on the stack to access the instance to a local
17066 variable (the variable will be accessed as a field).
17068 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17069 EmitContext.EmitAddressOfParameter): Routines to support
17070 parameters (not completed at this point).
17072 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17073 will also remove the parameters.
17075 * convert.cs (Convert): Define a `ConstantEC' which points to a
17076 null. This is just to prefity some code that uses
17077 ImplicitStandardConversion code and do not have an EmitContext
17080 The idea is to flag explicitly that at that point in time, it is
17081 known that the conversion will not trigger the delegate checking
17082 code in implicit conversions (which requires a valid
17085 Everywhere: pass new EmitContext parameter since
17086 ImplicitStandardConversionExists now requires it to check for
17087 anonymous method conversions.
17089 (Convert.ImplicitStandardConversionExists): If the type of an
17090 expression is the anonymous_method_type, and the type is a
17091 delegate, we invoke the AnonymousMethod.Compatible method to check
17092 whether an implicit conversion is possible.
17094 (Convert.ImplicitConversionStandard): Only do implicit method
17095 group conversions if the language level is not ISO_1.
17097 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17098 MethodInfo for the Invoke method. used by Delegate and
17101 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17102 method conversions if the target type is a delegate.
17104 Removed extra debugging nops.
17106 (LocalVariableReference): Turn the `local_info' into a public
17109 Add `prepared' field, the same hack used for FieldExprs to cope
17110 with composed assignments, as Local variables do not necessarily
17111 operate purely on the stack as they used to: they can be captured
17114 Add `temp' for a temporary result, like fields.
17116 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17118 It now copes with Local variables that are captured and emits the
17119 proper instance variable to load it from a field in the captured
17122 (ParameterReference.DoResolveBase): During the resolve phase,
17123 capture parameters if we are in an anonymous method.
17125 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17126 anonymous method, use the EmitContext helper routines to emit the
17127 parameter reference.
17129 * iterators.cs: Set RemapToProxy to true/false during the
17132 * parameters.cs (GetParameterByName): New helper method.
17134 * typemanager.cs (anonymous_method_type) a new type that
17135 represents an anonyous method. This is always an internal type,
17136 used as a fencepost to test against the anonymous-methodness of an
17139 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17141 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17143 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17145 2004-10-18 Martin Baulig <martin@ximian.com>
17147 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17148 `Type' directly, but call ResolveType() on it.
17149 (Catch.Resolve): Likewise.
17150 (Foreach.Resolve): Likewise.
17152 2004-10-18 Martin Baulig <martin@ximian.com>
17154 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17155 `Type' directly, but call ResolveType() on it.
17156 (Probe.DoResolve): Likewise.
17157 (ArrayCreation.LookupType): Likewise.
17158 (TypeOf.DoResolve): Likewise.
17159 (SizeOf.DoResolve): Likewise.
17161 2004-10-18 Martin Baulig <martin@ximian.com>
17163 * expression.cs (Invocation.BetterFunction): Put back
17164 TypeManager.TypeToCoreType().
17166 2004-10-18 Raja R Harinath <rharinath@novell.com>
17168 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17171 2004-10-18 Martin Baulig <martin@ximian.com>
17173 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17174 `Type' directly, but call ResolveType() on it.
17176 2004-10-18 Martin Baulig <martin@ximian.com>
17178 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17179 `Type' directly, but call ResolveType() on it.
17180 (MemberBase.DoDefine): Likewise.
17182 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17183 `Type' directly, but call ResolveType() on it.
17184 (ComposedCast.DoResolveAsTypeStep): Likewise.
17186 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17187 `Type' directly, but call ResolveType() on it.
17189 2004-10-17 John Luke <john.luke@gmail.com>
17191 * class.cs (Operator.GetSignatureForError): use CSharpName
17193 * parameter.cs (Parameter.GetSignatureForError): Returns
17194 correct name even if was not defined.
17196 2004-10-13 Raja R Harinath <rharinath@novell.com>
17199 * class.cs (TypeContainer.EmitContext): New property.
17200 (DefineNestedTypes): Create an emitcontext for each part.
17201 (MethodCore.DoDefineParameters): Use container's emitcontext.
17202 Pass type array to InternalParameters.
17203 (MemberBase.DoDefine): Use container's emitcontext.
17204 (FieldMember.Define): Likewise.
17205 (Event.Define): Likewise.
17206 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17207 Pass type array to InternalParameters.
17208 (SetIndexerMethod.GetParameterInfo): Likewise.
17209 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17210 * delegate.cs (Define): Pass emitcontext to
17211 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17212 array to InternalParameters.
17213 * expression.cs (ParameterReference.DoResolveBase): Pass
17214 emitcontext to GetParameterInfo.
17215 (ComposedCast.DoResolveAsTypeStep): Remove check on
17216 ec.ResolvingTypeTree.
17217 * parameter.cs (Parameter.Resolve): Change argument to
17218 EmitContext. Use ResolveAsTypeTerminal.
17219 (Parameter.GetSignature): Change argument to EmitContext.
17220 (Parameters.ComputeSignature): Likewise.
17221 (Parameters.ComputeParameterTypes): Likewise.
17222 (Parameters.GetParameterInfo): Likewise.
17223 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17224 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17225 * support.cs (InternalParameters..ctor): Remove variant that takes
17227 * typemanager.cs (system_intptr_expr): New.
17228 (InitExpressionTypes): Initialize it.
17230 2004-10-12 Chris Toshok <toshok@ximian.com>
17232 * cs-parser.jay: fix location for try_statement and catch_clause.
17234 2004-10-11 Martin Baulig <martin@ximian.com>
17236 * report.cs: Don't make --fatal abort on warnings, we have
17237 -warnaserror for that.
17239 2004-10-07 Raja R Harinath <rharinath@novell.com>
17241 More DeclSpace.ResolveType avoidance.
17242 * decl.cs (MemberCore.InUnsafe): New property.
17243 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17244 with newly created EmitContext.
17245 (FieldMember.Define): Likewise.
17246 * delegate.cs (Delegate.Define): Likewise.
17247 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17248 only if normal name-lookup fails.
17249 (TypeExpr.DoResolve): Enable error-checking.
17250 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17251 (SizeOf.DoResolve): Likewise.
17252 (ComposedCast.DoResolveAsTypeStep): Likewise.
17253 (StackAlloc.DoResolve): Likewise.
17254 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17255 (Block.Unsafe): New property.
17256 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17257 (Unsafe): Set 'unsafe' flag of contained block.
17258 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17259 (Fixed.Resolve): Likewise.
17260 (Catch.Resolve): Likewise.
17261 (Using.ResolveLocalVariableDecls): Likewise.
17262 (Foreach.Resolve): Likewise.
17264 2004-10-05 John Luke <john.luke@gmail.com>
17266 * cs-parser.jay: add location to error CS0175
17268 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17270 * ecore.cs (Expression.Constantity): Add support for turning null
17273 * const.cs (Const.Define): Allow constants to be reference types
17274 as long as the value is Null.
17276 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17278 * namespace.cs (NamespaceEntry.Using): No matter which warning
17279 level is set, check if this namespace name has already been added.
17281 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17283 * expression.cs: reftype [!=]= null should always use br[true,false].
17286 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17289 * attribute.cs: Enum conversion moved to
17290 GetAttributeArgumentExpression to be applied to the all
17293 2004-10-01 Raja R Harinath <rharinath@novell.com>
17295 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17296 * class.c (TypeContainer.DefineType): Flag error if
17297 base types aren't accessible due to access permissions.
17298 * decl.cs (DeclSpace.ResolveType): Move logic to
17299 Expression.ResolveAsTypeTerminal.
17300 (DeclSpace.ResolveTypeExpr): Thin layer over
17301 Expression.ResolveAsTypeTerminal.
17302 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17303 Refactor code into NestedAccess. Use it.
17304 (DeclSpace.NestedAccess): New.
17305 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17306 argument to silence errors. Check access permissions.
17307 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17308 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17309 (Cast.DoResolve): Likewise.
17310 (New.DoResolve): Likewise.
17311 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17312 (TypeOf.DoResolve): Likewise.
17314 * expression.cs (Invocation.BetterConversion): Return the Type of
17315 the better conversion. Implement section 14.4.2.3 more faithfully.
17316 (Invocation.BetterFunction): Make boolean. Make correspondence to
17317 section 14.4.2.2 explicit.
17318 (Invocation.OverloadResolve): Update.
17319 (Invocation): Remove is_base field.
17320 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17321 (Invocation.Emit): Likewise.
17323 2004-09-27 Raja R Harinath <rharinath@novell.com>
17325 * README: Update to changes.
17327 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17329 * cs-parser.jay: Reverted 642 warning fix.
17331 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17334 * decl.cs (FindMemberWithSameName): Indexer can have more than
17337 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17339 * expression.cs (LocalVariableReference.DoResolveLValue):
17340 Do not report warning 219 for out values.
17341 (EmptyExpression.Null): New member to avoid extra allocations.
17343 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17345 * cs-parser.jay: Fix wrong warning 642 report.
17347 * cs-tokenizer.cs (CheckNextToken): New helper;
17348 Inspect next character if is same as expected.
17350 2004-09-23 Martin Baulig <martin@ximian.com>
17352 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17353 (Convert.ImplicitReferenceConversionExists): Likewise.
17355 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17357 * class.cs (Operator.Define): Add error 448 and 559 report.
17359 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17361 * class.cs (MemberBase.IsTypePermitted): New protected
17362 method for checking error CS0610.
17364 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17366 * class.cs (TypeContainer.HasExplicitLayout): New property
17367 Returns whether container has StructLayout attribute set Explicit.
17368 (FieldMember): New abstract class for consts and fields.
17369 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17370 (Field): Reuse FieldMember.
17372 * const.cs (Const): Reuse FieldMember.
17374 * rootcontext.cs: EmitConstants call moved to class.
17376 2004-09-22 Martin Baulig <martin@ximian.com>
17378 Thanks to Peter Sestoft for this bug report.
17380 * expression.cs (Conditional): If both the `trueExpr' and the
17381 `falseExpr' is a NullLiteral, return a NullLiteral.
17383 2004-09-22 Martin Baulig <martin@ximian.com>
17385 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17386 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17387 for the "get_Current" call.
17389 2004-09-22 Martin Baulig <martin@ximian.com>
17391 Marek and me just fixed one of our oldest bugs: #28562 :-)
17393 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17395 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17396 we're an EnumConstant, just return that.
17397 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17398 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17399 to get the value which'll actually be written into the attribute.
17400 However, we have to use GetValue() to access the attribute's value
17403 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17405 * constant.cs (Constant.IsNegative): New abstract property
17408 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17409 (StackAlloc.DoResolve): Reused IsNegative.
17411 2004-09-21 Martin Baulig <martin@ximian.com>
17413 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17414 if we're used in an iterator, we may be called from different
17417 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17418 we actually have an exception block.
17420 2004-09-20 John Luke <jluke@cfl.rr.com>
17422 * class.cs, cs-parser.jay: Improve the error report for 1520:
17423 report the actual line where the error happens, not where the
17424 class was declared.
17426 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17427 Pass location information that was available elsewhere.
17429 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17431 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17432 runtime to delay sign assemblies.
17434 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17436 * cs-parser.jay: Do not report the stack trace, this is barely
17439 2004-08-22 John Luke <john.luke@gmail.com>
17441 * driver.cs : check that a resource id is not already used
17442 before adding it, report CS1508 if it is, bug #63637
17444 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17446 * ecore.cs: Removed dead code.
17448 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17450 * class.cs: Do not report warning CS0067 on the interfaces.
17452 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17454 * cs-parser.jay: Add error 504 report.
17456 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17458 * rootcontext.cs: WarningLevel is 4 by default now.
17460 * statement.cs (Fixed.Resolve): Do not null
17463 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17466 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17467 deep search when property is not virtual.
17468 (PropertyExpr.ResolveAccessors): Make one call for both
17471 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17474 * statement.cs: Error 152 report constains also location.
17476 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17479 * const.cs: Explicitly set constant as static.
17481 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17484 * cs-parser.jay: Add error 1017 report.
17486 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17488 Fixed bug #59980, #64224
17489 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17491 * typemanager.cs (IsSpecialMethod): Simplified
17493 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17495 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17496 condition with better params.
17498 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17501 * attribute.cs (Resolve): Property has to have both
17504 2004-09-14 Martin Baulig <martin@ximian.com>
17506 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17508 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17511 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17512 called and is obsolete then this member suppress message
17513 when call is inside next [Obsolete] method or type.
17515 * expression.cs: Use TestObsoleteMethodUsage member.
17517 2004-09-14 Martin Baulig <martin@ximian.com>
17519 * cs-parser.jay: Sync a bit with the GMCS version.
17521 2004-09-14 Martin Baulig <martin@ximian.com>
17523 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17524 (CSharpParser.yacc_verbose_flag): New public field.
17526 * genericparser.cs: Removed.
17528 2004-09-14 Raja R Harinath <rharinath@novell.com>
17530 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17532 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17534 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17536 2004-09-10 Martin Baulig <martin@ximian.com>
17538 Backported my MemberName changes from GMCS into MCS.
17540 - we are now using a special `MemberName' class instead of using
17541 strings; in GMCS, the `MemberName' also contains the type
17544 - changed the grammar rules a bit:
17545 * the old `member_name' is now a `namespace_or_type_name':
17546 The rule is that we use `namespace_or_type_name' everywhere
17547 where we expect either a "member name" (GetEnumerator) or a
17548 "member name" with an explicit interface name
17549 (IEnumerable.GetEnumerator).
17550 In GMCS, the explicit interface name may include type arguments
17551 (IEnumerable<T>.GetEnumerator).
17552 * we use `member_name' instead of just `IDENTIFIER' for
17554 The rule is that we use `member_name' wherever a member may
17555 have type parameters in GMCS.
17557 * decl.cs (MemberName): New public class.
17558 (MemberCore.MemberName): New public readonly field.
17559 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17560 (DeclSpace): Likewise.
17562 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17563 * enum.cs (Enum.ctor): Likewise.
17565 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17567 (AliasEntry.ctor): Take a MemberName, not an Expression.
17568 (AliasEntry.UsingAlias): Likewise.
17570 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17571 (IMethodData.MemberName): Changed type from string to MemberName.
17572 (MemberBase.ExplicitInterfaceName): Likewise.
17573 (AbstractPropertyEventMethod.SetupName): Make this private.
17574 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17575 argument; compute the member name here.
17576 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17577 on the `member.MemberName' and the `prefix'.
17579 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17581 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17582 thus, we get a `MemberName' instead of a `string'. These
17583 declarations may have type parameters in GMCS.
17584 (interface_method_declaration, delegate_declaration): Likewise.
17585 (class_declaration, interface_declaration): Likewise.
17586 (method_header): Use `namespace_or_type_name' instead of
17587 `member_name'. We may be an explicit interface implementation.
17588 (property_declaration, event_declaration): Likewise.
17589 (member_name): This is now just an `IDENTIFIER', not a
17590 `namespace_or_type_name'.
17591 (type_name, interface_type): Removed.
17592 (namespace_or_type_name): Return a MemberName, not an Expression.
17593 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17594 call GetTypeExpression() on the MemberName to get an expression.
17595 (IndexerDeclaration.interface_type): Changed type from string to
17597 (MakeName): Operate on MemberName's instead of string's.
17599 2004-09-13 Raja R Harinath <rharinath@novell.com>
17602 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17603 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17604 lookup to avoid symbols introduced by 'using'.
17605 * rootcontext.cs (NamespaceLookup): Update.
17607 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17609 * class.cs (TypeContainer.DoDefineMembers): Do not call
17610 DefineDefaultConstructor for static classes.
17612 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17614 * attribute.cs (Attribute.Resolve): Add error 653 report.
17616 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17618 (Method.ApplyAttributeBuilder): Add error 685 report.
17619 (Operator.Define): Add error 564 report.
17621 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17623 * expression.cs (Invocation.DoResolve): Add error
17624 245 and 250 report.
17626 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17629 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17631 * class.cs (ConstructorInitializer.Resolve):
17632 Wrong error number (515->516).
17634 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17636 * class.cs (Indexer.Define): Add error 631 report.
17638 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17640 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17642 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17644 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17646 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17648 * cs-parser.jay: Added error CS0241 report.
17650 2004-09-10 Raja R Harinath <rharinath@novell.com>
17652 * cs-parser.jay (fixed_statement): Introduce a scope for the
17653 declaration in the 'fixed' statement.
17655 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17657 * cs-parser.jay: Added CS0230 error report.
17659 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17661 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17663 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17665 * expression.cs (Argument.Resolve): Added error CS0192 and
17668 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17670 C# 2.0 #pragma warning feature
17672 * cs-tokenizer.cs (PreProcessPragma): New method;
17673 Handles #pragma directive.
17675 * report.cs (WarningRegions): New class; Support
17676 class for #pragma warning directive. It tests whether
17677 warning is enabled for a given line.
17679 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17681 * const.cs: Add more descriptive error report, tahnks to
17684 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17686 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17688 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17690 * expression.cs: Apply patch from Ben: Remove dead code from
17691 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17692 as that code just threw an exception anwyays.
17694 * const.cs: Remove the call to the turnintoconstant, for details
17697 * literal.cs: The type of the null-literal is the null type; So
17698 we use a placeholder type (literal.cs:System.Null, defined here)
17701 * expression.cs (Conditional.DoResolve): Remove some old code that
17702 is no longer needed, conversions have been fixed.
17704 (ArrayCreationExpression.DoResolve): Return false if we fail to
17705 resolve the inner expression.
17707 2004-09-07 Raja R Harinath <rharinath@novell.com>
17710 * cs-parser.jay (delegate_declaration): Record a delegate
17711 declaration as a type declaration.
17712 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17714 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17716 * parameter.cs: Do not crash if the type can not be resolved.
17718 * expression.cs: Report errors with unsafe pointers, fixes #64896
17720 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17722 * expression.cs: Pointer arith always needs to do a conv.i
17723 if the operand is a long. fix 65320
17725 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17727 Fixed cs0619-37.cs, cs0619-38.cs
17729 * enum.cs (GetObsoleteAttribute): Removed.
17731 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17732 on Enum member is double staged. The first is tested member
17735 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17737 Fixed #56986, #63631, #65231
17739 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17740 adds member to name container.
17741 (TypeContainer.AddToTypeContainer): New method, adds type to
17743 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17744 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17745 AddOperator): Simplified by reusing AddToMemberContainer.
17746 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17748 (Method.CheckForDuplications): Fixed implementation to test all
17750 (MemberBase): Detection whether member is explicit interface
17751 implementation is now in constructor.
17752 (MemberBase.UpdateMemberName): Handles IndexerName.
17753 (Accessor): Changed to keep also location information.
17754 (AbstractPropertyEventMethod): Is derived from MemberCore.
17755 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17756 will be emited or not.
17757 (PropertyBase.AreAccessorsDuplicateImplementation):
17758 Tests whether accessors are not in collision with some method.
17759 (Operator): Is derived from MethodCore to simplify common
17762 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17764 (DeclSpace.AddToContainer): Adds the member to defined_names
17765 table. It tests for duplications and enclosing name conflicts.
17767 * enum.cs (EnumMember): Clean up to reuse the base structures
17769 2004-09-03 Martin Baulig <martin@ximian.com>
17771 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17772 into TypeContainer, to make partial classes work again.
17774 2004-09-03 Martin Baulig <martin@ximian.com>
17776 * rootcontext.cs (RootContext.V2): Removed.
17778 2004-03-23 Martin Baulig <martin@ximian.com>
17780 * expression.cs (Invocation.OverloadResolve): Added `bool
17781 may_fail' argument and use it instead of the Location.IsNull() hack.
17783 2004-09-03 Martin Baulig <martin@ximian.com>
17785 Merged latest changes into gmcs. Please keep this comment in
17786 here, it makes it easier for me to see what changed in MCS since
17787 the last time I merged.
17789 2004-09-03 Raja R Harinath <rharinath@novell.com>
17792 * expression.cs (BetterConversion): Don't allow either conversion
17793 to be null. Remove redundant implicit conversion test when 'q ==
17794 null' -- when this function is invoked, we already know that the
17795 implicit conversion exists.
17796 (BetterFunction): Assume that 'best' is non-null. Remove
17797 redundant reimplementation of IsApplicable when 'best' is null.
17798 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17799 number of arguments.
17800 (IsAncestralType): Extract from OverloadResolve.
17801 (OverloadResolve): Make robust to the MethodGroupExpr being
17802 unsorted. Implement all the logic of Section 14.5.5.1, and
17803 support overloading of methods from multiple applicable types.
17804 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17806 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17807 (RealError, Warning): Append type of report to related symbol.
17809 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17811 * enum.cs: Fixed CLS-Compliance checks for enum members.
17812 Error tests cs3008-8.cs, cs3014-8.cs
17814 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17816 Fixed bug #62342, #63102
17817 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17818 like ImplementMethod.
17820 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17822 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17825 2004-09-02 Martin Baulig <martin@ximian.com>
17827 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17828 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17831 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17833 C# 2.0 Static classes implemented
17835 * class.cs (TypeContainer): instance_constructors,
17836 initialized_fields, initialized_static_fields,
17837 default_constructor, base_inteface_types are protected to be
17838 accessible from StaticClass.
17839 (TypeContainer.DefineDefaultConstructor): New virtual method
17840 for custom default constructor generating
17841 (StaticClass): New class to handle "Static classes" feature.
17843 * cs-parser.jay: Handle static keyword on class like instance
17846 * driver.cs: Added "/langversion" command line switch with two
17847 options (iso-1, default).
17849 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17851 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17853 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17855 * delegate.cs: Style.
17857 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17859 * delegate.cs: Add seperate instance expr field for miguel.
17861 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17863 * PointerArithmetic (Resolve): make sure we are not doing
17864 pointer arith on void*. Also, make sure we are resolved
17865 by not setting eclass until resolve.
17867 All callers: Make sure that PointerArithmetic gets resolved.
17869 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17871 * ArrayCreation (LookupType): If the type does not resolve
17872 to an array, give an error.
17874 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17876 * statement.cs (Try.Resolve): Fixed bug #64222
17878 2004-08-27 Martin Baulig <martin@ximian.com>
17881 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17884 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17886 * ecore.cs (Constantify): Get underlying type via
17887 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17888 Windows in special cases.
17890 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17892 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17893 for obtaining also private methods.
17894 (GetRemoveMethod): Used GetRemoveMethod (true)
17895 for obtaining also private methods.
17897 2004-08-24 Martin Baulig <martin@ximian.com>
17899 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17900 MethodAttributes.HideBySig for operators.
17902 2004-08-23 Martin Baulig <martin@ximian.com>
17904 Back to the old error reporting system :-)
17906 * report.cs (Message): Removed.
17907 (Report.MessageData, ErrorData, WarningData): Removed.
17908 (Report.Error, Warning): Back to the old system.
17910 2004-08-23 Martin Baulig <martin@ximian.com>
17912 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17914 * class.cs (TypeContainer.ParentContainer): New public virtual
17915 method; replaces the explicit interface implementation.
17916 (ClassPart.ParentContainer): Override.
17918 2004-08-23 Martin Baulig <martin@ximian.com>
17920 * statement.cs (Switch): Added support for constant switches; see
17921 #59428 or test-285.cs.
17923 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17926 * statement.cs (GetEnumeratorFilter): Removed useless
17927 logic because C# specs is strict. GetEnumerator must be
17930 2004-08-22 Martin Baulig <martin@ximian.com>
17932 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17933 a switch and may break, reset the barrier. Fixes #59867.
17935 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17937 CLS-Compliance speed up (~5% for corlib)
17939 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17940 New method. Tests container for CLS-Compliant names
17942 * class.cs (TypeContainer.VerifyClsName): New method.
17943 Checks whether container name is CLS Compliant.
17944 (Constructor): Implements IMethodData.
17946 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17947 low-case table for CLS Compliance test.
17948 (MemberCache.VerifyClsParameterConflict): New method.
17949 Checks method parameters for CS3006 error.
17951 * enum.cs (EnumMember): Is derived from MemberCore.
17952 (Enum.VerifyClsName): Optimized for better performance.
17954 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17956 * report.cs: Renamed Error_T to Error and changed all
17959 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17961 * class.cs (TypeContainer.IndexerArrayList): New inner class
17962 container for indexers.
17963 (TypeContainer.DefaultIndexerName): New constant for default
17964 indexer name. Replaced all "Item" with this constant.
17965 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17967 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17968 DefaultMemberAttribute constructor.
17970 2004-08-05 Martin Baulig <martin@ximian.com>
17972 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17975 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17977 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17978 multi platforms problem.
17980 * compiler.csproj: Included shared files.
17982 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17984 Fix bug 60333, 55971 in the more general way
17985 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17986 Added arg_type argument for constant conversion.
17987 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17989 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17992 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17993 OperatorArrayList, MethodCoreArrayList for typecontainer
17994 containers. Changed class member types to these new types.
17995 (MethodArrayList.DefineMembers): Added test for CS0659.
17997 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17999 * cfold.cs: Synchronize the folding with the code in expression.cs
18000 Binary.DoNumericPromotions for uint operands.
18002 * attribute.cs: Revert patch from Raja, it introduced a regression
18003 while building Blam-1.2.1 (hard to isolate a test case).
18005 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18009 (TypeContainer.Define): Renamed to DefineContainerMembers because of
18011 (MethodCore.parent_method): New member. The method we're overriding
18012 if this is an override method.
18013 (MethodCore.CheckBase): Moved from Method class and made common.
18014 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
18016 (MethodCore.CheckForDuplications): New abstract method. For custom
18017 member duplication search in a container
18018 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
18019 method and its return type.
18020 (Event.conflict_symbol): New member. Symbol with same name in the
18024 (MemberCache.FindMemberWithSameName): New method. The method
18025 is looking for conflict with inherited symbols.
18027 2004-08-04 Martin Baulig <martin@ximian.com>
18029 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
18031 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
18033 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18035 * report.cs (Message): New enum for better error, warning reference in
18037 (MessageData): New inner abstract class. It generally handles printing of
18038 error and warning messages.
18039 Removed unused Error, Warning, Message methods.
18041 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18043 Fix for cs0592-8.cs test
18045 (Attributable.ValidAttributeTargets): Made public.
18046 (Attribute.ExplicitTarget): New member for explicit target value.
18047 (Attribute.CheckTargets): Now we translate explicit attribute
18048 target to Target here.
18050 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18052 * ecore.cs (MethodGroupExpr): new IsBase property.
18054 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18056 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18057 rather than an instance expr.
18059 (DelegateCreation.Emit): Use the method group rather than
18060 the instance expression. Also, if you have base.Foo as the
18061 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18063 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18065 (NewDelegate.DoResolve): Only check for the existance of Invoke
18066 if the method is going to be needed. Use MethodGroupExpr.
18068 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18070 * expression.cs: For pointer arith., make sure to use
18071 the size of the type, not the size of the pointer to
18074 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18077 * class.cs (Class): Added error CS0502 test.
18079 2004-08-03 John Luke <jluke@cfl.rr.com>
18080 Raja R Harinath <rharinath@novell.com>
18083 * attribute.cs (Attribute.complained_before): New flag.
18084 (Attribute.ResolveType, Attribute.Resolve),
18085 (Attribute.DefinePInvokeMethod): Set it.
18086 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18088 2004-08-03 Martin Baulig <martin@ximian.com>
18090 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18091 use a user-defined operator; we still need to do numeric
18092 promotions in case one argument is a builtin type and the other
18093 one has an implicit conversion to that type. Fixes #62322.
18095 2004-08-02 Martin Baulig <martin@ximian.com>
18097 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18098 (LocalInfo.IsThis): New public property.
18099 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18101 2004-08-01 Martin Baulig <martin@ximian.com>
18103 * class.cs (TypeContainer.GetClassBases): Don't set the default
18104 here since we may get called from GetPartialBases().
18105 (TypeContainer.DefineType): If GetClassBases() didn't return a
18106 parent, use the default one.
18108 2004-07-30 Duncan Mak <duncan@ximian.com>
18110 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18112 2004-07-30 Martin Baulig <martin@ximian.com>
18114 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18116 * class.cs (SourceMethod): New public class, derive from the
18117 symbol writer's ISourceMethod.
18118 (Method): Use the new symbol writer API.
18120 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18121 as argument and use the new symbol writer.
18124 (SourceFile): Implement the symbol writer's ISourceFile.
18125 (Location.SymbolDocument): Removed.
18126 (Location.SourceFile): New public property.
18128 * symbolwriter.cs: Use the new symbol writer API.
18130 2004-07-30 Raja R Harinath <rharinath@novell.com>
18132 * Makefile (install-local): Remove. Functionality moved to
18135 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18137 * Makefile: Install mcs.exe.config file together with mcs.exe.
18138 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18139 correct runtime version.
18141 2004-07-25 Martin Baulig <martin@ximian.com>
18144 (TypeContainer.RegisterOrder): Removed, this was unused.
18145 (TypeContainer, interface_order): Removed.
18146 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18147 TypeContainer as argument since we can also be called with a
18148 `PartialContainer' for a partial class/struct/interface.
18149 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18150 of checking whether we're an `Interface' - we could be a
18151 `PartialContainer'.
18152 (PartialContainer.Register): Override; call
18153 AddClass()/AddStruct()/AddInterface() on our parent.
18155 * cs-parser.jay (interface_member_declaration): Add things to the
18156 `current_container', not the `current_class'.
18158 * rootcontext.cs (RegisterOrder): The overloaded version which
18159 takes an `Interface' was unused, removed.
18161 * typemanager.cs (TypeManager.LookupInterface): Return a
18162 `TypeContainer', not an `Interface'.
18163 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18164 contain a `PartialContainer' for an interface, so check it's
18165 `Kind' to figure out what it is.
18167 2004-07-25 Martin Baulig <martin@ximian.com>
18169 * class.cs (Class.DefaultTypeAttributes): New public constant.
18170 (Struct.DefaultTypeAttributes): Likewise.
18171 (Interface.DefaultTypeAttributes): Likewise.
18172 (PartialContainer.TypeAttr): Override this and add the
18173 DefaultTypeAttributes.
18175 2004-07-25 Martin Baulig <martin@ximian.com>
18177 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18178 we can just use the `Parent' field instead.
18180 2004-07-25 Martin Baulig <martin@ximian.com>
18182 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18184 2004-07-25 Martin Baulig <martin@ximian.com>
18186 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18187 our parts before defining any methods.
18188 (TypeContainer.VerifyImplements): Make this virtual.
18189 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18190 on our PartialContainer.
18192 2004-07-25 Martin Baulig <martin@ximian.com>
18194 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18196 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18197 argument, we can just use the `Parent' field instead.
18200 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18201 (MemberBase.DoDefine): Likewise.
18203 2004-07-24 Martin Baulig <martin@ximian.com>
18205 * decl.cs (MemberCore.Parent): New public field.
18206 (DeclSpace.Parent): Moved to MemberCore.
18208 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18209 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18211 (FieldBase, Field, Operator): Likewise.
18212 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18213 (EventField, Event): Likewise.
18215 2004-07-23 Martin Baulig <martin@ximian.com>
18217 * class.cs (PartialContainer): New public class.
18218 (ClassPart): New public class.
18219 (TypeContainer): Added support for partial classes.
18220 (TypeContainer.GetClassBases): Splitted some of the functionality
18221 out into GetNormalBases() and GetPartialBases().
18223 * cs-tokenizer.cs (Token.PARTIAL): New token.
18224 (Tokenizer.consume_identifier): Added some hacks to recognize
18225 `partial', but only if it's immediately followed by `class',
18226 `struct' or `interface'.
18228 * cs-parser.jay: Added support for partial clases.
18230 2004-07-23 Martin Baulig <martin@ximian.com>
18232 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18233 a `DeclSpace' and also made it readonly.
18234 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18235 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18236 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18238 * cs-parser.jay: Pass the `current_class', not the
18239 `current_container' (at the moment, this is still the same thing)
18240 to a new Method, Property, Event, Indexer or Constructor.
18242 2004-07-23 Martin Baulig <martin@ximian.com>
18244 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18245 and removed the `current_interface' one.
18246 (struct_declaration, class_declaration, interface_declaration):
18247 Set `current_class' to the newly created class/struct/interface;
18248 set their `Bases' and call Register() before parsing their body.
18250 2004-07-23 Martin Baulig <martin@ximian.com>
18252 * class.cs (Kind): New public enum.
18253 (TypeContainer): Made this class abstract.
18254 (TypeContainer.Kind): New public readonly field.
18255 (TypeContainer.CheckDef): New public method; moved here from
18257 (TypeContainer.Register): New public abstract method.
18258 (TypeContainer.GetPendingImplementations): New public abstract
18260 (TypeContainer.GetClassBases): Removed the `is_class' and
18261 `is_iface' parameters.
18262 (TypeContainer.DefineNestedTypes): Formerly known as
18264 (ClassOrStruct): Made this class abstract.
18266 * tree.cs (RootTypes): New public type.
18268 2004-07-20 Martin Baulig <martin@ximian.com>
18270 * tree.cs (Tree.RecordNamespace): Removed.
18271 (Tree.Namespaces): Removed.
18273 * rootcontext.cs (RootContext.IsNamespace): Removed.
18275 * cs-parser.jay (namespace_declaration): Just create a new
18276 NamespaceEntry here.
18278 2004-07-20 Martin Baulig <martin@ximian.com>
18280 * statement.cs (ExceptionStatement): New abstract class. This is
18281 now used as a base class for everyone who's using `finally'.
18282 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18283 our local variables before using them.
18285 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18286 virtual method. This is used by Yield.Resolve() to "steal" an
18287 outer block's `finally' clauses.
18288 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18291 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18292 version which takes an ExceptionStatement. This version must be
18293 used to create exception branchings.
18296 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18297 (Iterator.EmitMoveNext): Added exception support; protect the
18298 block with a `fault' clause, properly handle 'finally' clauses.
18299 (Iterator.EmitDispose): Run all the `finally' clauses here.
18301 2004-07-20 Martin Baulig <martin@ximian.com>
18303 * iterator.cs: This is the first of a set of changes in the
18304 iterator code. Match the spec more closely: if we're an
18305 IEnumerable, then GetEnumerator() must be called. The first time
18306 GetEnumerator() is called, it returns the current instance; all
18307 subsequent invocations (if any) must create a copy.
18309 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18311 * expression.cs: Resolve the constant expression before returning
18314 2004-07-19 Martin Baulig <martin@ximian.com>
18316 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18317 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18318 the return type of the new EmitContext.
18320 2004-07-18 Martin Baulig <martin@ximian.com>
18322 * class.cs (Property.Define): Fix iterators.
18324 * iterators.cs (Iterator.Define): Moved the
18325 `container.AddInterator (this)' call here from the .ctor; only do
18326 it if we resolved successfully.
18328 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18330 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18331 `true' for preprocessing directives that we parse. The return
18332 value indicates whether we should return to regular tokenizing or
18333 not, not whether it was parsed successfully.
18335 In the past if we were in: #if false ... #line #endif, we would
18336 resume parsing after `#line'. See bug 61604.
18338 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18339 building: IsEnumType should return true only for enums, not for
18340 enums or System.Enum itself. This fixes #61593.
18342 Likely what happened is that corlib was wrong: mcs depended on
18343 this bug in some places. The bug got fixed, we had to add the
18344 hack, which caused bug 61593.
18346 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18347 that was a workaround for the older conditions.
18349 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18351 * assign.cs: IAssignMethod has a new interface, as documented
18352 inline. All assignment code now uses this new api.
18354 * ecore.cs, expression.cs: All classes which implement
18355 IAssignMethod now use the new interface.
18357 * expression.cs (Invocation): add a hack to EmitCall so that
18358 IndexerAccess can be the target of a compound assignment without
18359 evaluating its arguments twice.
18361 * statement.cs: Handle changes in Invocation api.
18363 2004-07-16 Martin Baulig <martin@ximian.com>
18365 * iterators.cs: Rewrote this. We're now using one single Proxy
18366 class for both the IEnumerable and the IEnumerator interface and
18367 `Iterator' derives from Class so we can use the high-level API.
18369 * class.cs (TypeContainer.AddIterator): New method.
18370 (TypeContainer.DoDefineType): New protected virtual method, which
18371 is called from DefineType().
18372 (TypeContainer.DoDefineMembers): Call DefineType() and
18373 DefineMembers() on all our iterators.
18374 (TypeContainer.Emit): Call Emit() on all our iterators.
18375 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18377 * codegen.cs (EmitContext.CurrentIterator): New public field.
18379 2004-07-15 Martin Baulig <martin@ximian.com>
18382 (TypeManager.not_supported_exception_type): New type.
18384 2004-07-14 Martin Baulig <martin@ximian.com>
18386 * iterators.cs: Use real error numbers.
18388 2004-07-14 Martin Baulig <martin@ximian.com>
18390 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18391 requires this to be a System.Collection.IEnumerable and not a
18392 class implementing that interface.
18393 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18395 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18397 * class.cs: Fixed previous fix, it broke some error tests.
18399 2004-07-12 Martin Baulig <martin@ximian.com>
18401 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18404 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18406 * assign.cs (LocalTemporary): Add new argument: is_address,If
18407 `is_address' is true, then the value that we store is the address
18408 to the real value, and not the value itself.
18410 * ecore.cs (PropertyExpr): use the new local temporary
18411 stuff to allow us to handle X.Y += z (where X is a struct)
18413 2004-07-08 Martin Baulig <martin@ximian.com>
18415 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18416 not always return, just like we're doing in Using.Resolve().
18418 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18420 * cs-parser.jay (fixed_statement): flag this as Pinned.
18422 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18424 * typemanager.cs (TypeManager): Removed MakePinned method, this
18425 mechanism is replaced with the .NET 2.x compatible mechanism of
18426 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18428 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18429 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18430 `IsFixed' property which has a different meaning.
18432 2004-07-02 Raja R Harinath <rharinath@novell.com>
18434 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18435 visible from inside a nested class, not just the names of the
18436 immediately enclosing class.
18437 Fix for bug #60730.
18439 2004-06-24 Raja R Harinath <rharinath@novell.com>
18441 * expression.cs (BetterConversion): Remove buggy special-case
18442 handling of "implicit constant expression conversions". At this
18443 point, we already know that the conversion is possible -- we're
18444 only checking to see which is better.
18446 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18448 * cs-parser.jay: Added error CS0210 test.
18450 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18452 * cs-parser.jay: Added error CS0134 test.
18454 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18457 * cs-parser.jay: Added error CS0145 test.
18459 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18461 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18463 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18465 * expression.cs (StackAlloc.Resolve): The argument may not
18466 be a constant; deal with this case.
18468 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18470 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18471 GetIndexerAttributeValue.
18472 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18474 * class.cs (Indexer.Define): Added error tests for CS0415,
18477 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18479 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18482 2004-06-23 Martin Baulig <martin@ximian.com>
18484 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18485 neither return nor throw, reset the barrier as well. Fixes #60457.
18487 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18489 * class.cs : EventAttributes is now set to None by default.
18490 This fixes bug #60459.
18492 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18495 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18496 Don't throw exception but return null (it's sufficient now).
18498 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18500 * typemanager.cs (GetArgumentTypes): Faster implementation.
18502 2004-06-18 Martin Baulig <martin@ximian.com>
18504 * attribute.cs (Attribute.Resolve): Check whether we're an
18505 EmptyCast which a Constant child. Fixes #60333.
18507 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18509 * statement.cs (EmitCollectionForeach): Account for the fact that
18510 not all valuetypes are in areas which we can take the address of.
18511 For these variables, we store to a temporary variable. Also, make
18512 sure that we dont emit a `callvirt' on a valuetype method.
18514 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18516 * expression.cs (StackAlloc.DoReSolve): Added test for
18517 negative parameter (CS0247).
18519 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18522 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18524 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18527 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18530 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18532 Fix bug #58254 & cs1555.cs, cs1556.cs
18533 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18535 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18537 * cs-parser.jay: Added error CS1669 test for indexers.
18539 2004-06-11 Martin Baulig <martin@ximian.com>
18541 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18542 call this twice: for params and varargs methods.
18544 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18547 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18549 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18551 * attribute.cs (Attribute.GetValidTargets): Made public.
18554 (AbstractPropertyEventMethod): New class for better code sharing.
18555 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18557 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18559 2004-06-11 Raja R Harinath <rharinath@novell.com>
18562 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18563 that the call to Resolve is part of a MemberAccess.
18564 (Expression.Resolve): Use it for SimpleName resolution.
18565 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18566 Add 'intermediate' boolean argument.
18567 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18568 error message when the SimpleName can be resolved ambiguously
18569 between an expression and a type.
18570 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18572 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18573 call on the left-side.
18575 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18578 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18580 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18582 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18584 2004-06-11 Martin Baulig <martin@ximian.com>
18586 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18587 varargs methods if applicable.
18589 2004-06-11 Martin Baulig <martin@ximian.com>
18591 * expression.cs (Invocation.EmitCall): Don't use
18592 `method.CallingConvention == CallingConventions.VarArgs' since the
18593 method could also have `CallingConventions.HasThis'.
18595 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18597 * class.cs (Event.GetSignatureForError): Implemented.
18598 Fixed crash in error test cs3010.cs
18600 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18602 * cs-tokenizer.cs: Change the way we track __arglist to be
18603 consistent with the other keywords.
18605 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18607 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18610 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18612 * codegen.cs: Check that all referenced assemblies have a strongname
18613 before strongnaming the compiled assembly. If not report error CS1577.
18614 Fix bug #56563. Patch by Jackson Harper.
18615 * typemanager.cs: Added a method to return all referenced assemblies.
18616 Fix bug #56563. Patch by Jackson Harper.
18618 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18621 (Method.ApplyAttributeBuilder): Moved and added conditional
18622 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18625 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18627 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18630 * class.cs: (EventField.attribute_targets): Changed default target.
18632 2004-06-08 Martin Baulig <martin@ximian.com>
18634 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18636 2004-06-08 Martin Baulig <martin@ximian.com>
18638 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18640 2004-06-07 Martin Baulig <martin@ximian.com>
18642 Added support for varargs methods.
18644 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18647 * cs-parser.jay: Added support for `__arglist'.
18649 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18651 * expression.cs (Argument.AType): Added `ArgList'.
18652 (Invocation): Added support for varargs methods.
18653 (ArglistAccess): New public class.
18654 (Arglist): New public class.
18656 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18658 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18659 a method's top-level block if the method has varargs.
18661 * support.cs (ReflectionParameters, InternalParameters): Added
18662 support for varargs methods.
18664 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18666 * class.cs: Provide location in indexer error report.
18668 * driver.cs: Use standard names.
18670 * namespace.cs: Catch the use of using after a namespace has been
18671 declared also on using aliases.
18673 2004-06-03 Raja R Harinath <rharinath@novell.com>
18676 * typemanager.cs (closure_private_ok, closure_invocation_type)
18677 (closure_qualifier_type, closure_invocation_assembly)
18678 (FilterWithClosure): Move to ...
18679 (Closure): New internal nested class.
18680 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18681 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18682 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18683 (MemberLookup, MemberLookupFailed): Use it.
18684 * expression.cs (New.DoResolve): Treat the lookup for the
18685 constructor as being qualified by the 'new'ed type.
18686 (Indexers.GetIndexersForTypeOrInterface): Update.
18688 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18691 (GetConditionalAttributeValue): New method. Returns
18692 condition of ConditionalAttribute.
18693 (SearchMulti): New method. Returns all attributes of type 't'.
18694 Use it when attribute is AllowMultiple = true.
18695 (IsConditionalMethodExcluded): New method.
18698 (Method.IsExcluded): Implemented. Returns true if method has conditional
18699 attribute and the conditions is not defined (method is excluded).
18700 (IMethodData): Extended interface for ConditionalAttribute support.
18701 (PropertyMethod.IsExcluded): Implemented.
18704 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18707 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18710 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18712 * expression.cs (ArrayCreationExpression): Make this just an
18713 `expression'. It can't be a statement, so the code here was
18716 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18719 * typemanager.cs (GetFullNameSignature): New method for
18722 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18725 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18726 Use this method when MethodBuilder is null.
18727 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18728 Added test for error CS0626 (MONO reports error for this situation).
18729 (IMethodData.GetSignatureForError): Extended interface.
18731 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18734 (AttributeTester.GetObsoleteAttribute): Returns instance of
18735 ObsoleteAttribute when type is obsolete.
18738 (TypeContainer.VerifyObsoleteAttribute): Override.
18739 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18740 (MethodCode.VerifyObsoleteAttribute): Override.
18741 (MemberBase.VerifyObsoleteAttribute): Override.
18744 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18745 and report proper error.
18748 Delegate.VerifyObsoleteAttribute): Override.
18751 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18752 and report proper error.
18753 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18756 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18760 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18761 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18762 Added test for ObsoleteAttribute.
18765 (Catch): Derived from Statement.
18767 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18769 Fixed bug #59071 & cs0160.cs
18771 * statement.cs (Try.Resolve): Check here whether order of catch
18772 clauses matches their dependencies.
18774 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18776 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18777 caused a regression: #59343. Referencing nested classes from an
18778 assembly stopped working.
18780 2004-05-31 Martin Baulig <martin@ximian.com>
18782 MCS is now frozen for beta 2.
18784 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18786 * convert.cs: add a trivial cache for overload operator resolution.
18788 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18790 * decl.cs: If possible, use lookuptypedirect here. We can only do
18791 this if there is no `.' after the namespace. Avoids using
18792 LookupType, which does lots of slow processing.
18793 (FindNestedType) New method, does what it says :-).
18794 * namespace.cs: use LookupTypeDirect.
18795 * rootcontext.cs: use membercache, if possible.
18796 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18798 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18801 According to the spec,
18803 In a member access of the form E.I, if E is a single identifier,
18804 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18805 field, property, localvariable, or parameter with the same type as
18806 the meaning of E as a type-name (§3.8), then both possible
18807 meanings of E are permitted.
18809 We did not check that E as a simple-name had the same type as E as
18812 This trivial check gives us 5-7% on bootstrap time.
18814 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18816 * expression.cs (Invocation.OverloadResolve): Avoid the
18817 use of hashtables and boxing here by allocating on demand.
18819 2004-05-30 Martin Baulig <martin@ximian.com>
18821 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18822 we're doing a silent lookup. Don't try to lookup nested types in
18823 TypeManager.object_type (thanks to Ben Maurer).
18825 2004-05-30 Martin Baulig <martin@ximian.com>
18827 Committing a patch from Ben Maurer.
18829 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18831 2004-05-29 Martin Baulig <martin@ximian.com>
18833 * class.cs (IMethodData.ShouldIgnore): New method.
18835 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18836 `Location' argument, we don't need it anywhere. Use
18837 `IMethodData.ShouldIgnore ()' instead of
18838 `MethodData.GetMethodFlags ()'.
18839 (TypeManager.AddMethod): Removed.
18840 (TypeManager.AddMethod2): Renamed to AddMethod.
18842 2004-05-29 Martin Baulig <martin@ximian.com>
18844 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18846 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18847 converting from a class type S to an interface type and we already
18848 have an object on the stack, don't box it again. Fixes #52578.
18850 2004-05-29 Martin Baulig <martin@ximian.com>
18852 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18853 Added support for `params' parameters. Fixes #59267.
18855 2004-05-29 Martin Baulig <martin@ximian.com>
18857 * literal.cs (NullPointer): Provide a private .ctor which sets
18858 `type' to TypeManager.object_type. Fixes #59048.
18860 2004-05-29 Martin Baulig <martin@ximian.com>
18862 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18863 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18865 * ecore.cs (EventExpr.instance_expr): Make the field private.
18867 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18869 Fixed bug #50080 & cs0214-2.cs
18870 * expression.cs (Cast.DoResolve): Check unsafe context here.
18872 * statement.cs (Resolve.DoResolve): Likewise.
18874 2004-05-26 Martin Baulig <martin@ximian.com>
18876 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18878 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18879 (RootContext.LookupType): Pass down the `silent' flag.
18881 2004-05-25 Martin Baulig <martin@ximian.com>
18884 (MethodGroupExpr.IdenticalTypeName): New public property.
18885 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18886 expression actually refers to a type.
18888 2004-05-25 Martin Baulig <martin@ximian.com>
18890 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18891 for #56176 and made it actually work.
18893 2004-05-25 Martin Baulig <martin@ximian.com>
18895 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18896 (FieldExpr, PropertyExpr): Override and implement
18897 CacheTemporaries. Fixes #52279.
18899 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18901 * location.cs: In the new compiler listing a file twice is a
18902 warning, not an error.
18904 2004-05-24 Martin Baulig <martin@ximian.com>
18906 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18907 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18909 2004-05-24 Martin Baulig <martin@ximian.com>
18911 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18912 walking the `using' list. Fixes #53921.
18914 2004-05-24 Martin Baulig <martin@ximian.com>
18916 * const.cs (Const.LookupConstantValue): Added support for
18917 EmptyCast's; fixes #55251.
18919 2004-05-24 Martin Baulig <martin@ximian.com>
18921 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18922 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18923 which does the CS0135 check. The reason is that we first need to
18924 check whether the variable actually exists.
18926 2004-05-24 Martin Baulig <martin@ximian.com>
18928 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18929 than RootContext.LookupType() to find the explicit interface
18930 type. Fixes #58584.
18932 2004-05-24 Raja R Harinath <rharinath@novell.com>
18934 * Makefile: Simplify. Use executable.make.
18935 * mcs.exe.sources: New file. List of sources of mcs.exe.
18937 2004-05-24 Anders Carlsson <andersca@gnome.org>
18941 Use the invariant culture when doing String.Compare for CLS case
18944 2004-05-23 Martin Baulig <martin@ximian.com>
18946 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18947 don't have any dots. Fixes #52622, added cs0246-8.cs.
18949 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18951 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18953 * class.cs (MemberBase.Define): Reuse MemberType member for
18954 resolved type. Other methods can use it too.
18956 2004-05-23 Martin Baulig <martin@ximian.com>
18958 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18959 the variable also exists in the current block (otherwise, we need
18960 to report a CS0103). Fixes #58670.
18962 2004-05-23 Martin Baulig <martin@ximian.com>
18964 * flowanalysis.cs (Reachability.Reachable): Compute this
18965 on-the-fly rather than storing it as a field.
18967 2004-05-23 Martin Baulig <martin@ximian.com>
18969 * flowanalysis.cs (Reachability.And): Manually compute the
18970 resulting `barrier' from the reachability.
18972 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18975 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18976 instance of ObsoleteAttribute when symbol is obsolete.
18979 (IMethodData): Extended interface for ObsoleteAttribute support.
18981 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18983 * attribute.cs: Fix bug #55970
18985 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18989 (GetObsoleteAttribute): New method. Creates the instance of
18991 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18992 ObsoleteAttribute when member is obsolete.
18993 (AttributeTester.Report_ObsoleteMessage): Common method for
18994 Obsolete error/warning reporting.
18997 (TypeContainer.base_classs_type): New member for storing parent type.
19000 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
19001 for this MemberCore.
19003 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19005 * attribute.cs, const.cs: Fix bug #58590
19007 2004-05-21 Martin Baulig <martin@ximian.com>
19009 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
19010 out parameters if the end of the method is unreachable. Fixes
19013 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19015 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
19016 Hari was right, why extra method.
19018 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19020 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
19022 2004-05-20 Martin Baulig <martin@ximian.com>
19024 Merged this back from gmcs to keep the differences to a minumum.
19026 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
19027 instead of a Declspace.
19028 (Attribute.ResolveType): Likewise.
19029 (Attributes.Search): Likewise.
19030 (Attributes.Contains): Likewise.
19031 (Attributes.GetClsCompliantAttribute): Likewise.
19033 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
19035 (MethodData.ApplyAttributes): Take an EmitContext instead of a
19038 2004-05-19 Marek Safar <marek.safar@seznam.cz>
19040 Fix bug #58688 (MCS does not report error when the same attribute
19043 * attribute.cs (Attribute.Emit): Distinction between null and default.
19045 2004-05-19 Raja R Harinath <rharinath@novell.com>
19047 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
19048 of a top-level attribute without an attribute target.
19049 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19051 (Attribute.Conditional_GetConditionName),
19052 (Attribute.Obsolete_GetObsoleteMessage): Update.
19053 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19054 part of ScanForIndexerName.
19055 (Attribute.CanIgnoreInvalidAttribute): New function.
19056 (Attribute.ScanForIndexerName): Move to ...
19057 (Attributes.ScanForIndexerName): ... here.
19058 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19059 (Attributes.Search): New internal variant that can choose not to
19060 complain if types aren't resolved. The original signature now
19062 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19063 complaints suppressed.
19064 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19065 only if it not useful.
19066 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19067 top-level for attributes that are shared between the assembly
19068 and a top-level class.
19069 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19070 * class.cs: Update to reflect changes.
19071 (DefineIndexers): Fuse loops.
19072 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19073 a couple more variants of attribute names.
19075 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19077 Fix bug #52585 (Implemented explicit attribute declaration)
19080 (Attributable.ValidAttributeTargets): New abstract method. It gets
19081 list of valid attribute targets for explicit target declaration.
19082 (Attribute.Target): It holds target itself.
19083 (AttributeSection): Removed.
19084 (Attribute.CheckTargets): New method. It checks whether attribute
19085 target is valid for the current element.
19088 (EventProperty): New class. For events that are declared like
19089 property (with add and remove accessors).
19090 (EventField): New class. For events that are declared like field.
19093 * cs-parser.jay: Implemented explicit attribute target declaration.
19095 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19096 Override ValidAttributeTargets.
19099 (ReturnParameter): Class for applying custom attributes on
19101 (ParameterAtribute): New class. Class for applying custom
19102 attributes on the parameter type.
19104 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19106 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19109 (Method): Allow UNSAFE here.
19111 * modifiers.cs: Support unsafe reporting.
19113 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19115 * decl.cs: Fix bug #58478.
19117 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19119 * statement.cs: When checking for unreachable code on an EmptyStatement,
19120 set the location. Fixes bug #58488.
19122 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19124 * driver.cs: Add -pkg handling.
19126 From Gonzalo: UseShelLExecute=false
19128 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19131 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19133 (Attribute.IsClsCompliaceRequired): Moved to base for better
19135 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19136 when attribute is AttributeUsageAttribute.
19137 (Attribute.GetValidTargets): Simplified.
19138 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19139 attribute for this type.
19140 (Attribute.ApplyAttributes): Method renamed to Emit and make
19142 (GlobalAttributeSection): New class for special handling of global
19143 attributes (assembly, module).
19144 (AttributeSection.Emit): New method.
19146 * class.cs: Implemented Attributable abstract methods.
19147 (MethodCore.LabelParameters): Moved to Parameter class.
19148 (Accessor): Is back simple class.
19149 (PropertyMethod): Implemented Attributable abstract class.
19150 (DelegateMethod): Implemented Attributable abstract class.
19151 (Event): New constructor for disctintion between normal Event
19152 and Event with accessors.
19154 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19156 * codegen.cs, const.cs, decl.cs, delegate.cs:
19157 (CommonAssemblyModulClass): Implemented Attributable abstract class
19160 * enum.cs: Implement IAttributeSupport interface.
19161 (EnumMember): New class for emum members. Implemented Attributable
19165 (ParameterBase): Is abstract.
19166 (ReturnParameter): New class for easier [return:] attribute handling.
19168 * typemanager.cs: Removed builder_to_attr.
19170 2004-05-11 Raja R Harinath <rharinath@novell.com>
19173 * attribute.cs (Attribute.GetPositionalValue): New function.
19174 * class.cs (TypeContainer.VerifyMembers): New function.
19175 (TypeContainer.Emit): Use it.
19176 (ClassOrStruct): New base class for Class and Struct.
19177 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19178 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19180 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19181 then each non-static field should have a FieldOffset attribute.
19182 Otherwise, none of the fields should have a FieldOffset attribute.
19183 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19184 and FieldOffset attributes.
19185 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19186 (TypeManager.field_offset_attribute_type): New core types.
19187 (TypeManager.InitCoreTypes): Initialize them.
19189 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19191 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19192 Return correct type.
19195 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19197 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19198 be implicitly converted to ulong.
19200 * expression.cs: The logic for allowing operator &, | and ^ worked
19201 was wrong, it worked before because we did not report an error in
19202 an else branch. Fixes 57895.
19204 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19205 allow volatile fields to be reference types.
19207 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19209 * driver.cs: Add support for /debug-
19211 2004-05-07 Raja R Harinath <rharinath@novell.com>
19213 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19214 Add a 'complain' parameter to silence errors.
19215 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19216 silently overlooked type-resolutions.
19217 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19218 to reflect changes.
19219 (Attributes.Search): New function.
19220 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19221 (Attributes.GetAttributeFullName): Remove hack.
19222 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19223 Update to reflect changes.
19224 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19225 Use Attributes.Search instead of nested loops.
19227 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19230 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19231 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19232 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19234 * report.cs: (Report.Warning): Renamed to Warning_T because of
19235 parameter collision.
19237 2004-05-05 Raja R Harinath <rharinath@novell.com>
19239 * expression.cs (MemberAccess.ResolveMemberAccess):
19240 Exit with non-zero status after Report.Error.
19241 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19243 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19245 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19247 * support.cs: Don't hang when the file is empty.
19249 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19251 * support.cs: In SeekableStreamReader, compute the preamble size of the
19252 underlying stream. Position changes should take into account that initial
19255 2004-05-03 Todd Berman <tberman@sevenl.net>
19257 * driver.cs: remove unused GetSysVersion function.
19259 2004-05-03 Todd Berman <tberman@sevenl.net>
19261 * driver.cs: Remove the hack from saturday, as well as the hack
19262 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19263 link_paths to get that bit proper.
19265 2004-05-01 Todd Berman <tberman@sevenl.net>
19267 * driver.cs: Try a LoadFrom before a Load, this checks the current
19268 path. This is currently a bug in mono that is be fixed, however, this
19269 provides a workaround for now. This will be removed when the bug
19272 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19274 * CryptoConvert.cs: Updated to latest version. Fix issue with
19275 incomplete key pairs (#57941).
19277 2004-05-01 Todd Berman <tberman@sevenl.net>
19279 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19282 2004-04-30 Jackson Harper <jackson@ximian.com>
19284 * codegen.cs: Open keys readonly.
19286 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19288 * typemanager.cs: don't report cyclic struct layout when a struct
19289 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19290 which has 2 Pango.Rectangle fields.
19292 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19294 * expression.cs: Handle IntPtr comparisons with IL code
19295 rather than a method call.
19297 2004-04-29 Martin Baulig <martin@ximian.com>
19299 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19300 the list of PropertyInfo's in class hierarchy and find the
19301 accessor. Fixes #56013.
19303 2004-04-29 Martin Baulig <martin@ximian.com>
19305 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19307 2004-04-29 Martin Baulig <martin@ximian.com>
19309 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19311 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19313 2004-04-29 Martin Baulig <martin@ximian.com>
19315 * class.cs (ConstructorInitializer.Resolve): Check whether the
19316 parent .ctor is accessible. Fixes #52146.
19318 2004-04-29 Martin Baulig <martin@ximian.com>
19320 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19322 * statement.cs (Using.EmitLocalVariableDecls): Use
19323 TypeManager.idisposable_type, not typeof (IDisposable).
19324 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19326 2004-04-29 Martin Baulig <martin@ximian.com>
19328 * class.cs (Event.Define): Don't emit the field and don't set
19329 RTSpecialName and SpecialName for events on interfaces. Fixes
19332 2004-04-29 Raja R Harinath <rharinath@novell.com>
19334 Refactor Attribute.ApplyAttributes.
19335 * attribute.cs (Attributable): New base class for objects that can
19336 have Attributes applied on them.
19337 (Attribute): Make AttributeUsage fields public.
19338 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19339 (Attribute.IsInternalCall): New property.
19340 (Attribute.UsageAttr): Convert to a public read-only property.
19341 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19342 (Attribute.ResolveType, Attribute.Resolve)
19343 (Attribute.ScanForIndexerName): Update to reflect changes.
19344 (Attribute.CheckAttributeTarget): Re-format.
19345 (Attribute.ApplyAttributes): Refactor, to various
19346 Attributable.ApplyAttributeBuilder methods.
19347 * decl.cs (MemberCore): Make Attributable.
19348 * class.cs (Accessor): Make Attributable.
19349 (MethodData.ApplyAttributes): Use proper attribute types, not
19351 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19352 (TypeContainer.ApplyAttributeBuilder)
19353 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19354 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19355 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19356 (Operator.ApplyAttributeBuilder): New factored-out methods.
19357 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19358 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19359 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19360 * parameter.cs (ParameterBase): New Attributable base class
19361 that can also represent Return types.
19362 (Parameter): Update to the changes.
19364 2004-04-29 Jackson Harper <jackson@ximian.com>
19366 * driver.cs: Prefer the corlib system version when looking for
19367 assemblies in the GAC. This is still a hack, but its a better hack
19370 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19372 * decl.cs, enum.cs: Improved error 3005 reporting.
19374 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19375 (related_symbols): New private member for list of symbols
19376 related to reported error/warning.
19378 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19380 2004-04-29 Martin Baulig <martin@ximian.com>
19382 * ecore.cs (Expression.Constantify): If we're an enum and
19383 TypeManager.TypeToCoreType() doesn't give us another type, use
19384 t.UnderlyingSystemType. Fixes #56178.
19386 2004-04-29 Martin Baulig <martin@ximian.com>
19388 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19389 interfaces and for each interface, only add members directly
19390 declared in that interface. Fixes #53255.
19392 2004-04-28 Martin Baulig <martin@ximian.com>
19394 * expression.cs (ConditionalLogicalOperator): Use a temporary
19395 variable for `left' to avoid that we evaluate it more than once;
19398 2004-04-28 Martin Baulig <martin@ximian.com>
19400 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19403 2004-04-28 Martin Baulig <martin@ximian.com>
19405 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19408 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19409 whether the type is not void (CS1547).
19411 2004-04-28 Martin Baulig <martin@ximian.com>
19413 * expression.cs (Unary.DoResolveLValue): Override this and report
19414 CS0131 for anything but Operator.Indirection.
19416 2004-04-28 Martin Baulig <martin@ximian.com>
19418 Committing a patch from Ben Maurer; see bug #50820.
19420 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19423 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19426 2004-04-28 Martin Baulig <martin@ximian.com>
19428 Committing a patch from Ben Maurer; see bug #50820.
19430 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19433 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19436 2004-04-28 Martin Baulig <martin@ximian.com>
19438 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19439 (Block.AddLabel): Call DoLookupLabel() to only search in the
19442 2004-04-28 Martin Baulig <martin@ximian.com>
19444 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19445 comparing StringConstants and NullLiterals in Equality and Inequality.
19447 2004-04-28 Jackson Harper <jackson@ximian.com>
19449 * driver.cs: Attempt to load referenced assemblies from the
19450 GAC. This is the quick and dirty version of this method that
19451 doesnt take into account versions and just takes the first
19452 canidate found. Will be good enough for now as we will not have more
19453 then one version installed into the GAC until I update this method.
19455 2004-04-28 Martin Baulig <martin@ximian.com>
19457 * typemanager.cs (TypeManager.CheckStructCycles): New public
19458 static method to check for cycles in the struct layout.
19460 * rootcontext.cs (RootContext.PopulateTypes): Call
19461 TypeManager.CheckStructCycles() for each TypeContainer.
19462 [Note: We only need to visit each type once.]
19464 2004-04-28 Martin Baulig <martin@ximian.com>
19466 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19468 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19469 success and added `out object value'. Use a `bool resolved' field
19470 to check whether we've already been called rather than
19471 `ConstantValue != null' since this breaks for NullLiterals.
19473 2004-04-28 Raja R Harinath <rharinath@novell.com>
19475 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19476 setting of this flag, since the 'set' method may be non-public.
19478 2004-04-28 Raja R Harinath <rharinath@novell.com>
19480 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19481 check on current_vector.Block.
19483 2004-04-27 Martin Baulig <martin@ximian.com>
19485 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19486 a field initializer. Fixes #56459.
19488 2004-04-27 Martin Baulig <martin@ximian.com>
19490 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19491 we're not attempting to use an indexer. Fixes #52154.
19493 2004-04-27 Martin Baulig <martin@ximian.com>
19495 * statement.cs (Return): Don't create a return label if we don't
19496 need it; reverts my change from January 20th. Thanks to Ben
19499 2004-04-27 Martin Baulig <martin@ximian.com>
19501 According to the spec, `goto' can only leave a nested scope, but
19504 * statement.cs (Block.LookupLabel): Only lookup in the current
19505 block, don't recurse into parent or child blocks.
19506 (Block.AddLabel): Check in parent and child blocks, report
19507 CS0140/CS0158 if we find a duplicate.
19508 (Block): Removed this indexer for label lookups.
19509 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19510 this already does the error reporting for us.
19513 (FlowBranching.UsageVector.Block): New public variable; may be null.
19514 (FlowBranching.CreateSibling): Added `Block' argument.
19515 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19516 label for the target of a `goto' and check whether we're not
19517 leaving a `finally'.
19519 2004-04-27 Martin Baulig <martin@ximian.com>
19521 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19522 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19525 2004-04-27 Martin Baulig <martin@ximian.com>
19527 * statement.cs (Block.AddLabel): Also check for implicit blocks
19528 and added a CS0158 check.
19530 2004-04-27 Martin Baulig <martin@ximian.com>
19532 * flowanalysis.cs (FlowBranchingLoop): New class.
19533 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19534 UsageVector's instead of an ArrayList.
19535 (FlowBranching.Label): Likewise.
19536 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19537 (FlowBranching.AddBreakVector): New method.
19539 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19541 * attribute.cs: Small regression fix: only convert the type if we
19542 the type is different, fixes System.Drawing build.
19544 2004-04-27 Martin Baulig <martin@ximian.com>
19546 * attribute.cs (Attribute.Resolve): If we have a constant value
19547 for a named field or property, implicity convert it to the correct
19550 2004-04-27 Raja R Harinath <rharinath@novell.com>
19552 * statement.cs (Block.Block): Implicit blocks share
19553 'child_variable_names' fields with parent blocks.
19554 (Block.AddChildVariableNames): Remove.
19555 (Block.AddVariable): Mark variable as "used by a child block" in
19556 every surrounding block.
19557 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19558 been used in a child block, complain about violation of "Invariant
19559 meaning in blocks" rule.
19560 * cs-parser.jay (declare_local_variables): Don't use
19561 AddChildVariableNames.
19562 (foreach_statement): Don't create an implicit block: 'foreach'
19563 introduces a scope.
19565 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19567 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19568 converting from 0L to ulong. Fixes 57522.
19570 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19572 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19573 derived class hides via 'new' keyword field from base class (test-242.cs).
19574 TODO: Handle this in the more general way.
19576 * class.cs (CheckBase): Ditto.
19578 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19580 * decl.cs (caching_flags): New member for storing cached values
19582 (MemberCore.Flags): New enum where bit flags for caching_flags
19584 (MemberCore.cls_compliance): Moved to caching_flags.
19585 (DeclSpace.Created): Moved to caching_flags.
19587 * class.cs: Use caching_flags instead of DeclSpace.Created
19589 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19591 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19592 if we are only a derived class, not a nested class.
19594 * typemanager.cs: Same as above, but do this at the MemberLookup
19595 level (used by field and methods, properties are handled in
19596 PropertyExpr). Allow for the qualified access if we are a nested
19599 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19601 * class.cs: Refactoring.
19602 (IMethodData): New inteface; Holds links to parent members
19603 to avoid member duplication (reduced memory allocation).
19604 (Method): Implemented IMethodData interface.
19605 (PropertyBase): New inner classes for get/set methods.
19606 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19607 (Event): New inner classes for add/remove methods.
19608 (Event.DelegateMethod): Implemented IMethodData interface.
19610 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19611 EmitContext (related to class.cs refactoring).
19613 2004-04-21 Raja R Harinath <rharinath@novell.com>
19615 * delegate.cs (Delegate.VerifyApplicability): If the number of
19616 arguments are the same as the number of parameters, first try to
19617 verify applicability ignoring any 'params' modifier on the last
19621 2004-04-16 Raja R Harinath <rharinath@novell.com>
19623 * class.cs (TypeContainer.AddIndexer): Use
19624 'ExplicitInterfaceName' to determine if interface name was
19625 explicitly specified. 'InterfaceType' is not initialized at this time.
19626 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19627 Indexers array is already in the required order. Initialize
19628 'IndexerName' only if there are normal indexers.
19629 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19630 (TypeContainer.Emit): Emit DefaultMember attribute only if
19631 IndexerName is initialized.
19634 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19636 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19639 2004-04-15 Raja R Harinath <rharinath@novell.com>
19641 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19645 * attribute.cs (Attribute.Resolve): Check for duplicate named
19649 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19651 * iterators.cs (MarkYield): track whether we are in an exception,
19652 and generate code accordingly. Use a temporary value to store the
19653 result for our state.
19655 I had ignored a bit the interaction of try/catch with iterators
19656 since their behavior was not entirely obvious, but now it is
19657 possible to verify that our behavior is the same as MS .NET 2.0
19661 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19663 * iterators.cs: Avoid creating temporaries if there is no work to
19666 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19667 Enumerations, use TypeManager.EnumToUnderlying and call
19670 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19673 (This.Emit): Use EmitContext.EmitThis to emit our
19676 (This.EmitAssign): Ditto.
19678 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19679 codepaths, we will move all the functionality into
19682 (FieldExpr.EmitAssign): Ditto.
19684 This fixes several hidden bugs that I uncovered while doing a code
19685 review of this today.
19687 * codegen.cs (EmitThis): reworked so the semantics are more clear
19688 and also support value types "this" instances.
19690 * iterators.cs: Changed so that for iterators in value types, we
19691 do not pass the value type as a parameter.
19693 Initialization of the enumerator helpers is now done in the caller
19694 instead of passing the parameters to the constructors and having
19695 the constructor set the fields.
19697 The fields have now `assembly' visibility instead of private.
19699 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19701 * expression.cs (Argument.Resolve): Check if fields passed as ref
19702 or out are contained in a MarshalByRefObject.
19704 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19705 another compiler type.
19707 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19709 * class.cs (Indexer.Define): use the new name checking method.
19710 Also, return false on an error.
19711 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19712 (is_identifier_[start/part]_character): make static.
19714 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19716 * expression.cs (Binary.ResolveOperator): Do no append strings
19717 twice: since we can be invoked more than once (array evaluation)
19718 on the same concatenation, take care of this here. Based on a fix
19719 from Ben (bug #56454)
19721 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19723 * codegen.cs: Fix another case where CS1548 must be reported (when
19724 delay-sign isn't specified and no private is available #56564). Fix
19725 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19726 error when MCS is used on the MS runtime and we need to delay-sign
19727 (which seems unsupported by AssemblyBuilder - see #56621).
19729 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19731 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19732 (TypeManager.ComputeNamespaces): Faster implementation for
19735 * compiler.csproj: Updated AssemblyName to mcs.
19737 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19739 * rootcontext.cs: Add new types to the boot resolution.
19741 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19742 MulticastDelegate is not allowed.
19744 * typemanager.cs: Add new types to lookup: System.TypedReference
19747 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19748 check for TypedReference or ArgIterator, they are not allowed.
19750 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19751 makes us properly catch 1510 in some conditions (see bug 56016 for
19754 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19756 * CryptoConvert.cs: update from corlib version
19759 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19761 * class.cs (Indexer.Define): Check indexername declaration
19763 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19765 * attribute.cs (IsClsCompliant): Fixed problem with handling
19766 all three states (compliant, not-compliant, undetected).
19768 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19770 * attribute.cs (Attribute): Location is now public.
19771 (Resolve): Store resolved arguments (pos_values) in attribute class.
19772 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19773 (GetClsCompliantAttributeValue): New method that gets
19774 CLSCompliantAttribute value.
19775 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19776 if exists else null.
19777 (AttributeTester): New class for CLS-Compliant verification routines.
19779 * class.cs (Emit): Add CLS-Compliant verification.
19780 (Method.GetSignatureForError): Implemented.
19781 (Constructor.GetSignatureForError): Implemented
19782 (Constructor.HasCompliantArgs): Returns if constructor has
19783 CLS-Compliant arguments.
19784 (Constructor.Emit): Override.
19785 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19786 is needed to test only parameters.
19787 (FieldBase.GetSignatureForError): Implemented.
19788 (TypeContainer): New member for storing base interfaces.
19789 (TypeContainer.FindMembers): Search in base interfaces too.
19791 * codegen.cs (GetClsComplianceAttribute): New method that gets
19792 assembly or module CLSCompliantAttribute value.
19793 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19795 (ModuleClass.Emit): Add error 3012 test.
19797 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19799 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19800 state for all decl types.
19801 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19802 if CLS-Compliant tests are required.
19803 (IsClsCompliaceRequired): New method. Analyze whether code
19804 must be CLS-Compliant.
19805 (IsExposedFromAssembly): New method. Returns true when MemberCore
19806 is exposed from assembly.
19807 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19808 value or gets cached value.
19809 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19810 is explicitly marked with CLSCompliantAttribute.
19811 (IsIdentifierClsCompliant): New abstract method. This method is
19812 used to testing error 3005.
19813 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19814 for identifier and parameters CLS-Compliant testing.
19815 (VerifyClsCompliance): New method. The main virtual method for
19816 CLS-Compliant verifications.
19817 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19818 null. I don't know why is null (too many public members !).
19819 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19820 and get value of first CLSCompliantAttribute that found.
19822 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19823 (VerifyClsCompliance): Override and add extra tests.
19825 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19826 clscheck- disable CLS-Compliant verification event if assembly is has
19827 CLSCompliantAttribute(true).
19829 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19830 ApllyAttribute is now called in emit section as in the other cases.
19831 Possible future Emit integration.
19832 (IsIdentifierClsCompliant): New override.
19833 (VerifyClsCompliance): New override.
19834 (GetEnumeratorName): Returns full enum name.
19836 * parameter.cs (GetSignatureForError): Implemented.
19838 * report.cs (WarningData): New struct for Warning message information.
19839 (LocationOfPreviousError): New method.
19840 (Warning): New method. Reports warning based on the warning table.
19841 (Error_T): New method. Reports error based on the error table.
19843 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19844 verifications are done here.
19846 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19848 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19849 CLSCompliantAttribute.
19850 (all_imported_types): New member holds all imported types from other
19852 (LoadAllImportedTypes): New method fills static table with exported types
19853 from all referenced assemblies.
19854 (Modules): New property returns all assembly modules.
19856 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19858 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19859 throwing a parser error.
19861 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19862 which removes the hardcoded get_/set_ prefixes for properties, as
19863 IL allows for the properties to be named something else.
19867 * expression.cs: Do not override operand before we know if it is
19868 non-null. Fix 56207
19870 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19872 * typemanager.cs: support for pinned variables.
19874 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19876 * decl.cs, typemanager.cs: Avoid using an arraylist
19877 as a buffer if there is only one result set.
19879 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19881 * expression.cs: Make sure you cant call a static method
19882 with an instance expression, bug #56174.
19884 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19886 * class.cs (IsDuplicateImplementation): Improve error reporting to
19887 flag 663 (method only differs in parameter modifier).
19889 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19890 in preprocessor directives.
19892 * location.cs (LookupFile): Allow for the empty path.
19894 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19895 better approach for some of that patch, but its failing with the
19896 CharSet enumeration. For now try/catch will do.
19898 * typemanager.cs: Do not crash if a struct does not have fields.
19901 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19903 * expression.cs: cs0213, cant fix a fixed expression.
19906 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19908 * cs-parser.jay: detect invalid embeded statements gracefully.
19911 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19913 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19916 the invocation type may not be a subclass of the tye of the item/
19917 The type of the item must be a subclass of the invocation item.
19922 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19924 * attribute.cs: Added methods to get a string and a bool from an
19925 attribute. Required to information from AssemblyKeyFileAttribute,
19926 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19927 * codegen.cs: Modified AssemblyName creation to include support for
19928 strongnames. Catch additional exceptions to report them as CS1548.
19929 * compiler.csproj: Updated include CryptoConvert.cs.
19930 * compiler.csproj.user: Removed file - user specific configuration.
19931 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19932 Mono.Security assembly. The original class is maintained and tested in
19933 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19934 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19935 like CSC 8.0 (C# v2) supports.
19936 * Makefile: Added CryptoConvert.cs to mcs sources.
19937 * rootcontext.cs: Added new options for strongnames.
19939 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19941 * driver.cs: For --expect-error, report error code `2'
19942 if the program compiled with no errors, error code `1' if
19943 it compiled with an error other than the one expected.
19945 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19947 * compiler.csproj: Updated for Visual Studio .NET 2003.
19948 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19949 * compiler.sln: Updated for Visual Studio .NET 2003.
19951 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19953 * expression.cs: Fix bug #47234. We basically need to apply the
19954 rule that we prefer the conversion of null to a reference type
19955 when faced with a conversion to 'object' (csc behaviour).
19957 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19959 * statement.cs: Shorter form for foreach, eliminates
19960 a local variable. r=Martin.
19962 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19964 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19965 checks if we can use brtrue/brfalse to test for 0.
19966 * expression.cs: use the above in the test for using brtrue/brfalse.
19967 cleanup code a bit.
19969 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19971 * expression.cs: Rewrite string concat stuff. Benefits:
19973 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19974 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19975 rather than a concat chain.
19977 * typemanager.cs: Add lookups for more concat overloads.
19979 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19981 * expression.cs: Emit shorter il code for array init.
19998 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
20000 * statement.cs: Before, two switch blocks would be merged if the
20001 total size of the blocks (end_item - begin_item + 1) was less than
20002 two times the combined sizes of the blocks.
20004 Now, it will only merge if after the merge at least half of the
20009 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
20011 * class.cs : csc build fix for GetMethods(). See bug #52503.
20013 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
20015 * expression.cs: Make sure fp comparisons work with NaN.
20016 This fixes bug #54303. Mig approved this patch a long
20017 time ago, but we were not able to test b/c the runtime
20020 2004-03-19 Miguel de Icaza <miguel@ximian.com>
20022 * ecore.cs (TypExpr.GetHashCode): implement this overload.
20024 2004-03-19 Martin Baulig <martin@ximian.com>
20026 * class.cs (MemberCore.IsDuplicateImplementation): Report the
20027 error here and not in our caller.
20029 2004-03-19 Martin Baulig <martin@ximian.com>
20031 * interface.cs: Completely killed this file.
20032 (Interface): We're now a TypeContainer and live in class.cs.
20034 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
20035 argument; we're now also called for interfaces.
20036 (TypeContainer.DefineMembers): Allow this method being called
20038 (TypeContainer.GetMethods): New public method; formerly known as
20039 Interface.GetMethod(). This is used by PendingImplementation.
20040 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
20041 it's now private and non-static.
20042 (Interface): Moved this here; it's now implemented similar to
20044 (Method, Property, Event, Indexer): Added `bool is_interface'
20045 argument to their .ctor's.
20046 (MemberBase.IsInterface): New public field.
20048 * cs-parser.jay: Create normal Method, Property, Event, Indexer
20049 instances instead of InterfaceMethod, InterfaceProperty, etc.
20050 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20051 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20053 2004-03-19 Martin Baulig <martin@ximian.com>
20055 * class.cs (MethodCore.IsDuplicateImplementation): New private
20056 method which does the CS0111 checking.
20057 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20058 Use IsDuplicateImplementation().
20060 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20062 * decl.cs (FindMemberToOverride): New method to find the correct
20063 method or property to override in the base class.
20065 - Make Method/Property use the above method to find the
20066 version in the base class.
20067 - Remove the InheritableMemberSignatureCompare as it is now
20070 This patch makes large code bases much faster to compile, as it is
20071 O(n) rather than O(n^2) to do this validation.
20073 Also, it fixes bug 52458 which is that nested classes are not
20074 taken into account when finding the base class member.
20076 Reviewed/Approved by Martin.
20078 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20080 * interface.cs: In all interface classes removed redundant
20081 member initialization.
20083 2004-03-16 Martin Baulig <martin@ximian.com>
20085 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20087 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20089 * decl.cs (DefineTypeAndParents): New helper method to define a
20090 type's containers before the type itself is defined; This is a
20091 bug exposed by the recent changes to Windows.Forms when an
20092 implemented interface was defined inside a class that had not been
20095 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20097 (Check): Loop correctly to report errors modifiers
20098 (UNSAFE was not in the loop, since it was the same as TOP).
20100 * interface.cs: Every interface member now takes a ModFlags,
20101 instead of a "is_new" bool, which we set on the base MemberCore.
20103 Every place where we called "UnsafeOk" in the interface, now we
20104 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20105 the unsafe settings from the member declaration instead of the
20106 container interface.
20108 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20110 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20111 `set_indexer_name' to the pending bits (one per type).
20113 We fixed a bug today that was picking the wrong method to
20114 override, since for properties the existing InterfaceMethod code
20115 basically ignored the method name. Now we make sure that the
20116 method name is one of the valid indexer names.
20118 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20120 * support.cs (SeekableStreamReader): Keep track of stream byte
20121 positions and don't mix them with character offsets to the buffer.
20123 Patch from Gustavo Giráldez
20125 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20127 * interface.cs (InterfaceSetGetBase): Removed double member
20128 initialization, base class does it as well.
20130 2004-03-13 Martin Baulig <martin@ximian.com>
20132 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20133 when compiling corlib.
20135 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20137 * convert.cs (ExplicitConversion): We were reporting an error on
20138 certain conversions (object_type source to a value type, when the
20139 expression was `null') before we had a chance to pass it through
20140 the user defined conversions.
20142 * driver.cs: Replace / and \ in resource specifications to dots.
20145 * class.cs: Add check for duplicate operators. Fixes 52477
20147 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20149 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20150 that are in the middle of the statements, not only at the end.
20153 * class.cs (TypeContainer.AddField): No longer set the
20154 `HaveStaticConstructor' flag, now we call it
20155 `UserDefineStaticConstructor' to diferentiate the slightly
20156 semantic difference.
20158 The situation is that we were not adding BeforeFieldInit (from
20159 Modifiers.TypeAttr) to classes that could have it.
20160 BeforeFieldInit should be set to classes that have no static
20165 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20167 And most importantly Zoltan's comment:
20169 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20171 "I think beforefieldinit means 'it's ok to initialize the type sometime
20172 before its static fields are used', i.e. initialization does not need
20173 to be triggered by the first access to the type. Setting this flag
20174 helps the JIT to compile better code, since it can run the static
20175 constructor at JIT time, and does not need to generate code to call it
20176 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20177 this flag for lots of classes like String.
20179 csc sets this flag if the type does not have an explicit static
20180 constructor. The reasoning seems to be that if there are only static
20181 initalizers for a type, and no static constructor, then the programmer
20182 does not care when this initialization happens, so beforefieldinit
20185 This bug prevents the AOT compiler from being usable, since it
20186 generates so many calls to mono_runtime_class_init that the AOT code
20187 is much slower than the JITted code. The JITted code is faster,
20188 because it does not generate these calls if the vtable is type is
20189 already initialized, which is true in the majority of cases. But the
20190 AOT compiler can't do this."
20192 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20194 * class.cs (MethodData.Emit): Refactor the code so symbolic
20195 information is generated for destructors; For some reasons we
20196 were taking a code path that did not generate symbolic information
20199 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20201 * class.cs: Create a Constructor.CheckBase method that
20202 takes care of all validation type code. The method
20203 contains some code that was moved from Define.
20205 It also includes new code that checks for duplicate ctors.
20206 This fixes bug #55148.
20208 2004-03-09 Joshua Tauberer <tauberer@for.net>
20210 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20211 a { ... }-style array creation invokes EmitStaticInitializers
20212 which is not good for reference-type arrays. String, decimal
20213 and now null constants (NullCast) are not counted toward
20214 static initializers.
20216 2004-03-05 Martin Baulig <martin@ximian.com>
20218 * location.cs (SourceFile.HasLineDirective): New public field;
20219 specifies whether the file contains or is referenced by a "#line"
20221 (Location.DefineSymbolDocuments): Ignore source files which
20222 either contain or are referenced by a "#line" directive.
20224 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20226 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20227 direct access to our parent, so check the method inline there.
20229 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20231 * expression.cs (Invocation.EmitCall): Miguel's last commit
20232 caused a regression. If you had:
20237 In Foo the implict this would be null.
20239 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20241 * expression.cs (Invocation.EmitCall): If the method is not
20242 virtual, do not emit a CallVirt to it, use Call.
20244 * typemanager.cs (GetFullNameSignature): Improve the method to
20245 cope with ".ctor" and replace it with the type name.
20247 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20248 as an argument the ConstructorBuilder where it is being defined,
20249 to catch the recursive constructor invocations.
20251 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20253 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20254 routines to check if a type is an enumerable/enumerator allow
20255 classes that implement the IEnumerable or IEnumerator interfaces.
20257 * class.cs (Property, Operator): Implement IIteratorContainer, and
20258 implement SetYields.
20260 (Property.Define): Do the block swapping for get_methods in the
20261 context of iterators. We need to check if Properties also
20262 include indexers or not.
20264 (Operator): Assign the Block before invoking the
20265 OperatorMethod.Define, so we can trigger the Iterator code
20268 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20269 Property and Operator classes are not created when we parse the
20270 declarator but until we have the block completed, so we use a
20271 singleton SimpleIteratorContainer.Simple to flag whether the
20272 SetYields has been invoked.
20274 We propagate this setting then to the Property or the Operator to
20275 allow the `yield' to function.
20277 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20279 * codegen.cs: Implemented attribute support for modules.
20280 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20281 Assembly/Module functionality.
20283 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20284 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20285 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20287 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20289 * interface.cs (FindMembers): The operation is performed on all base
20290 interfaces and not only on the first. It is required for future CLS Compliance patch.
20292 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20294 * statement.cs, codegen.cs:
20295 This patch deals with patterns such as:
20297 public class List : IEnumerable {
20299 public MyEnumerator GetEnumerator () {
20300 return new MyEnumerator(this);
20303 IEnumerator IEnumerable.GetEnumerator () {
20307 public struct MyEnumerator : IEnumerator {
20312 Before, there were a few things we did wrong:
20313 1) we would emit callvirt on a struct, which is illegal
20314 2) we emited ldarg when we needed to emit ldarga
20315 3) we would mistakenly call the interface methods on an enumerator
20316 type that derived from IEnumerator and was in another assembly. For example:
20318 public class MyEnumerator : IEnumerator
20320 Would have the interface methods called, even if there were public impls of the
20321 method. In a struct, this lead to invalid IL code.
20323 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20325 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20328 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20330 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20332 * cs-parser.jay: Fix small regression: we were not testing V2
20333 compiler features correctly.
20335 * interface.cs: If the emit context is null, then create one
20337 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20339 * decl.cs (GetSignatureForError): New virtual method to get full name
20340 for error messages.
20342 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20343 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20345 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20346 Duplicated members and code in these classes has been removed.
20347 Better encapsulation in these classes.
20349 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20351 * assign.cs (Assign.DoResolve): When dealing with compound
20352 assignments, there is a new rule in ECMA C# 2.4 (might have been
20353 there before, but it is documented here) that states that in:
20357 If b is of type int, and the `op' is a shift-operator, then the
20358 above is evaluated as:
20362 * expression.cs (Binary.ResolveOperator): Instead of testing for
20363 int/uint/long/ulong, try to implicitly convert to any of those
20364 types and use that in pointer arithmetic.
20366 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20367 method to print information for from the type, not from the
20368 null-method we were given.
20370 2004-02-01 Duncan Mak <duncan@ximian.com>
20372 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20373 parsing for cmd, fixes bug #53694.
20375 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20377 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20378 in the member name duplication tests. Property and operator name duplication
20379 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20381 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20383 * interface.cs (PopulateMethod): Fixed crash when interface method
20384 returns not existing type (error test cs0246-3.cs).
20386 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20388 * cs-parser.jay (interface_accessors): Re-write actions to also
20389 store attributes attached to get and set methods. Fix spelling
20392 (inteface_property_declaration): Modify accordingly.
20394 (InterfaceAccessorInfo): New helper class to store information to pass
20395 around between rules that use interface_accessors.
20397 * interface.cs (Emit): Apply attributes on the get and set
20398 accessors of properties and indexers too.
20400 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20401 right MethodBuilder when applying attributes to the get and set accessors.
20403 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20405 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20407 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20409 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20411 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20413 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20414 changes that treat `yield' specially when present before `break'
20415 or `return' tokens.
20417 * cs-tokenizer.cs: yield is no longer a keyword.
20419 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20421 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20422 setting for default constructors.
20423 For default constructors are almost every time set wrong Modifier. The
20424 generated IL code has been alright. But inside mcs this values was
20425 wrong and this was reason why several of my CLS Compliance tests
20428 2004-01-22 Martin Baulig <martin@ximian.com>
20430 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20431 not a QualifiedIdentifier. This is what `type_name_expression'
20432 was previously doing.
20433 (type_name_expression): Removed; the code is now in
20434 `namespace_or_type_name'.
20435 (qualified_identifier): Removed, use `namespace_or_type_name'
20437 (QualifiedIdentifier): Removed this class.
20439 2004-01-22 Martin Baulig <martin@ximian.com>
20441 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20442 not a string as alias name.
20444 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20446 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20447 #52730 bug, and instead compute correctly the need to use a
20448 temporary variable when requesting an address based on the
20449 static/instace modified of the field and the constructor.
20451 2004-01-21 Martin Baulig <martin@ximian.com>
20453 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20454 class and namespace before looking up aliases. Fixes #52517.
20456 2004-01-21 Martin Baulig <martin@ximian.com>
20458 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20459 assinged in a 'try'; fixes exception4.cs.
20461 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20462 * class.cs : Implemented parameter-less constructor for TypeContainer
20464 * decl.cs: Attributes are now stored here. New property OptAttributes
20466 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20468 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20470 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20472 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20473 (CSharpSignature): New method for indexer and property signature.
20475 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20477 * pending.cs (IsVirtualFilter): Faster implementation.
20479 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20481 * typemanager.cs: Avoid inclusion of same assembly more than once.
20483 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20485 * cs-parser.jay: Fixed problem where the last assembly attribute
20486 has been applied also to following declaration (class, struct, etc.)
20488 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20490 * class.cs: Added error CS0538, CS0539 reporting.
20491 Fixed crash on Microsoft runtime when field type is void.
20493 * cs-parser.jay: Added error CS0537 reporting.
20495 * pending.cs: Added error CS0535 reporting.
20496 Improved error report for errors CS0536, CS0534.
20498 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20500 Merge a few bits from the Anonymous Method MCS tree.
20502 * statement.cs (ToplevelBlock): New class for toplevel methods,
20503 will hold anonymous methods, lifted variables.
20505 * cs-parser.jay: Create toplevel blocks for delegates and for
20506 regular blocks of code.
20508 2004-01-20 Martin Baulig <martin@ximian.com>
20510 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20511 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20512 and `NeedExplicitReturn'; added `IsLastStatement'.
20513 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20514 have a `ReturnLabel' or we're not unreachable.
20516 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20517 child's reachability; don't just override ours with it. Fixes
20518 #58058 (lluis's example).
20519 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20520 InFinally(), InLoop(), InSwitch() and
20521 BreakCrossesTryCatchBoundary() methods.
20523 * statement.cs (Return): Do all error checking in Resolve().
20524 Unless we are the last statement in a top-level block, always
20525 create a return label and jump to it.
20526 (Break, Continue): Do all error checking in Resolve(); also make
20527 sure we aren't leaving a `finally'.
20528 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20529 statement in a top-level block.
20530 (Block.Flags): Added `IsDestructor'.
20531 (Block.IsDestructor): New public property.
20533 2004-01-20 Martin Baulig <martin@ximian.com>
20535 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20537 2004-01-20 Martin Baulig <martin@ximian.com>
20539 * statement.cs (Statement.ResolveUnreachable): New public method.
20540 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20541 (Block.Resolve): Resolve unreachable statements.
20543 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20545 * expression.cs: We need to fix the case where we do
20546 not have a temp variable here.
20548 * assign.cs: Only expression compound assignments need
20549 temporary variables.
20551 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20553 * flowanalysis.cs: Reduce memory allocation in a few ways:
20554 - A block with no variables should not allocate a bit
20556 - A method with no out parameters does not need any tracking
20557 for assignment of the parameters, so we need not allocate
20560 public readonly Type[] VariableTypes;
20561 public readonly string[] VariableNames;
20562 Are redundant. The data is already stored in the variable
20563 map, so we need not allocate another array for it.
20564 - We need to add alot of checks for if (params | locals) == null
20565 due to the first two changes.
20567 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20569 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20570 implement IMemoryLocation, we store a copy on a local variable and
20571 take the address of it. Patch from Benjamin Jemlich
20573 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20574 to use a special "type_name_expression" rule which reduces the
20575 number of "QualifiedIdentifier" classes created, and instead
20576 directly creates MemberAccess expressions.
20578 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20580 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20581 that fixes #52853. Null literal assignment to ValueType
20583 * class.cs (MethodData.Emit): Instead of checking the name of the
20584 method to determine if its a destructor, create a new derived
20585 class from Method called Destructor, and test for that.
20587 * cs-parser.jay: Create a Destructor object instead of a Method.
20589 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20593 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20595 * expression.cs (Binary.ResolveOperator): Perform an implicit
20596 conversion from MethodGroups to their delegate types on the
20597 Addition operation.
20599 * delegate.cs: Introduce a new class DelegateCreation that is the
20600 base class for `NewDelegate' and `ImplicitDelegateCreation',
20601 factor some code in here.
20603 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20604 conversion from MethodGroups to compatible delegate types.
20606 * ecore.cs (Expression.Resolve): Do not flag error 654
20607 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20608 we allow conversions from MethodGroups to delegate types now.
20610 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20611 assignments in v2 either.
20613 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20615 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20616 static read-only fields in ctors.
20618 Applied patch from Benjamin Jemlich
20620 * expression.cs (UnaryMutator): Avoid leaking local variables.
20622 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20624 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20625 here to return true, as they can be used like this:
20627 (XXX) int.MEMBER ()
20629 Fixed 49836 and all the other dups
20631 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20633 * driver.cs: Implement /win32res and /win32icon.
20635 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20637 * cs-parser.jay: Add a rule to improve error handling for the
20638 common mistake of placing modifiers after the type.
20640 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20642 * cs-parser.jay (interface_event_declaration): Catch
20643 initialization of events on interfaces, and report cs0068
20645 * cs-parser.jay (interface_event_declaration): Catch
20646 initialization of events.
20648 * ecore.cs: Better report missing constructors.
20650 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20651 the error reporting done in the wrong place. Fix.
20653 * expression.cs (Binary.ResolveOperator): Catch the
20654 operator + (E x, E y) error earlier, and later allow for implicit
20655 conversions in operator +/- (E e, U x) from U to the underlying
20658 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20659 52596, if the container class is abstract, the default constructor
20660 is protected otherwise its public (before, we were always public).
20662 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20665 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20666 Jemlich that fixes bug #52597, MCS was generating invalid code for
20667 idisposable structs. Thanks to Ben for following up with this
20670 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20672 * driver.cs: Allow assemblies without code to be generated, fixes
20675 2004-01-07 Nick Drochak <ndrochak@gol.com>
20677 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20679 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20681 * cs-parser.jay: Add rules to improve error reporting if fields or
20682 methods are declared at the namespace level (error 116)
20684 * Add rules to catch event add/remove
20686 2004-01-04 David Sheldon <dave-mono@earth.li>
20688 * expression.cs: Added matching ")" to error message for
20691 2004-01-03 Todd Berman <tberman@gentoo.org>
20693 * ecore.cs, attribute.cs:
20694 Applying fix from #52429.
20696 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20698 * ecore.cs, expression.cs, statement.cs:
20699 Total rewrite of how we handle branching. We
20700 now handle complex boolean expressions with fewer
20701 jumps. As well if (x == 0) no longer emits a ceq.
20703 if (x is Foo) is much faster now, because we generate
20706 Overall, we get a pretty big improvement on our benchmark
20707 tests. The code we generate is smaller and more readable.
20709 I did a full two-stage bootstrap. The patch was reviewed
20710 by Martin and Miguel.
20712 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20714 * cs-parser.jay: Make primary_expression not take a QI.
20715 we dont need this because the member_access rule covers
20716 us here. So we replace the rule with just IDENTIFIER.
20718 This has two good effects. First, we remove a s/r conflict.
20719 Second, we allocate many fewer QualifiedIdentifier objects.
20721 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20723 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20724 set the correct information via SRE. This prevents
20725 hanging on the MS runtime. Fixes #29374.
20727 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20729 * convert.cs: correctly handle conversions to value types
20730 from Enum and ValueType as unboxing conversions.
20732 Fixes bug #52569. Patch by Benjamin Jemlich.
20734 2004-01-02 Ravi Pratap <ravi@ximian.com>
20736 * expression.cs (BetterConversion): Prefer int -> uint
20737 over int -> ulong (csc's behaviour). This fixed bug #52046.
20739 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20741 * decl.cs (MemberCache.FindMembers): now returns a
20744 * typemanager.cs: In general, go with with ^^.
20745 (CopyNewMethods): take an IList.
20746 (RealMemberLookup): Only allocate an arraylist
20747 if we copy from two sets of methods.
20749 This change basically does two things:
20750 1) Fewer array lists allocated due to CopyNewMethods.
20751 2) the explicit cast in MemberList costed ALOT.
20753 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20755 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20756 a hashtable to avoid needless string allocations when an identifier is
20757 used more than once (the common case).
20759 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20761 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20762 is broken, it will not return anything. So, we
20763 have to use the information we have in mcs to
20766 * typemanager.cs: Add a cache for GetInterfaces,
20767 since this will now be used more often (due to ^^)
20769 (GetExplicitInterfaces) New method that gets the
20770 declared, not effective, interfaces on a type
20771 builder (eg, if you have interface IFoo, interface
20772 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20775 This patch makes MCS able to bootstrap itself on
20778 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20780 * expression.cs: Remove the Nop's that Miguel put
20783 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20785 * report.cs, codegen.cs: Give the real stack trace to
20786 the error when an exception is thrown.
20788 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20790 * decl.cs: only allocate hashtables for ifaces if
20793 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20795 * expression.cs: fix the error from cs0121-2.cs
20796 (a parent interface has two child interfaces that
20797 have a function with the same name and 0 params
20798 and the function is called through the parent).
20800 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20802 * class.cs, rootcontext.cs, typmanager.cs: do not
20805 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20807 * codegen.cs: remove stack for the ec flow branching.
20808 It is already a linked list, so no need.
20810 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20812 * Makefile: Allow custom profiler here.
20814 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20816 * typemanager.cs (LookupType):
20817 - Use a static char [], because split takes
20818 a param array for args, so it was allocating
20820 - Do not store true in a hashtable, it boxes.
20822 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20824 * flowanalysis.cs: bytify common enums.
20826 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20828 * modifiers.cs: Add a new set of flags for the
20829 flags allowed on explicit interface impls.
20830 * cs-parser.jay: catch the use of modifiers in
20831 interfaces correctly.
20832 * class.cs: catch private void IFoo.Blah ().
20834 All related to bug #50572.
20836 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20838 * decl.cs: Rewrite the consistant accessability checking.
20839 Accessability is not linear, it must be implemented in
20840 a tableish way. Fixes #49704.
20842 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20844 * expression.cs: Handle negation in a checked context.
20845 We must use subtraction from zero. Fixes #38674.
20847 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20849 * class.cs: Ignore static void main in DLLs.
20850 * rootcontext.cs: Handle the target type here,
20851 since we are have to access it from class.cs
20852 * driver.cs: account for the above.
20854 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20856 * report.cs: Give line numbers and files if available.
20858 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20860 * driver.cs: Implement /addmodule.
20862 * typemanager.cs: Change 'modules' field so it now contains Modules not
20865 2003-12-20 Martin Baulig <martin@ximian.com>
20867 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20868 (FieldBase.IsAssigned): Removed this field.
20869 (FieldBase.SetAssigned): New public method.
20870 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20872 2003-12-20 Martin Baulig <martin@ximian.com>
20874 * expression.cs (LocalVariableReference.DoResolve): Don't set
20875 `vi.Used' if we're called from DoResolveLValue().
20877 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20878 returns the usage vector it just merged into the current one -
20879 pass this one to UsageWarning().
20880 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20881 of the `EmitContext', don't call this recursively on our children.
20883 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20885 * driver.cs: Implement /target:module.
20887 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20889 * support.cs (CharArrayHashtable): New helper class.
20891 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20892 char arrays, not strings, so we can avoid creating a string in
20893 consume_identifier if the identifier is a keyword.
20895 2003-12-16 Martin Baulig <martin@ximian.com>
20897 * statement.cs (LocalInfo.Assigned): Removed this property.
20898 (LocalInfo.Flags): Removed `Assigned'.
20899 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20900 and uses flow analysis.
20901 (Block.UsageWarning): Made this method private.
20902 (Block.Resolve): Call UsageWarning() if appropriate.
20904 * expression.cs (LocalVariableReference.DoResolve): Always set
20905 LocalInfo.Used here.
20907 2003-12-13 Martin Baulig <martin@ximian.com>
20909 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20910 any value here; we're now using flow analysis to figure out
20911 whether a statement/block returns a value.
20913 2003-12-13 Martin Baulig <martin@ximian.com>
20915 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20917 (FlowBranching.MergeFinally): Don't call
20918 `branching.CheckOutParameters()' here, this is called in
20920 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20921 when adding the `finally' vector.
20923 2003-12-13 Martin Baulig <martin@ximian.com>
20926 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20927 actually work and also fix #48962.
20929 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20931 * decl.cs: Do not check System.Object for nested types,
20932 since we know it does not have any. Big bang for buck:
20935 Run 1: 8.35 seconds
20936 Run 2: 8.32 seconds
20937 corlib: 17.99 seconds
20939 Run 1: 8.17 seconds
20940 Run 2: 8.17 seconds
20941 corlib: 17.39 seconds
20943 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20945 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20946 time we are returning 0 members, so we save alot here.
20948 2003-12-11 Martin Baulig <martin@ximian.com>
20950 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20951 `MergeChild()', also just take the `FlowBranching' as argument;
20952 call Merge() on it and return the result.
20953 (FlowBranching.Merge): We don't need to do anything if we just
20956 2003-12-11 Martin Baulig <martin@ximian.com>
20958 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20959 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20960 Maurer for this idea.
20962 2003-12-11 Martin Baulig <martin@ximian.com>
20964 * flowanalysis.cs (MergeResult): This class is now gone; we now
20965 use the `UsageVector' for this. The reason for this is that if a
20966 branching just has one sibling, we don't need to "merge" them at
20967 all - that's the next step to do.
20968 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20971 2003-12-11 Martin Baulig <martin@ximian.com>
20973 Reworked flow analyis and made it more precise and bug-free. The
20974 most important change is that we're now using a special `Reachability'
20975 class instead of having "magic" meanings of `FlowReturns'. I'll
20976 do some more cleanups and optimizations and also add some more
20977 documentation this week.
20979 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20980 largely reworked this class.
20981 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20982 the new `Reachability' class instead of having "magic" values here.
20983 (FlowBranching): We're now using an instance of `Reachability'
20984 instead of having separate `Returns', `Breaks' etc. fields.
20986 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20987 based on flow analysis; ignore the return value of block.Emit ().
20989 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20991 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20992 if they are private.
20994 2003-12-09 Martin Baulig <martin@ximian.com>
20996 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20997 call them directly on the UsageVector.
20999 2003-12-09 Martin Baulig <martin@ximian.com>
21001 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
21002 Changed return type from `FlowReturns' to `Reachability'.
21004 2003-12-09 Martin Baulig <martin@ximian.com>
21006 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
21007 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
21008 `Reachable' fields with a single `Reachability' one.
21010 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21012 * class.cs (FindMembers): Remove foreach's.
21017 Run 1: 8.74 seconds
21018 Run 2: 8.71 seconds
21021 Run 1: 8.64 seconds
21022 Run 2: 8.58 seconds
21025 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21030 This patch does a few things:
21031 1. EmptyStatement is now a singleton, so it is never reallocated.
21032 2. All blah is EmptyStatement constructs have been changed to
21033 blah == EmptyStatement.Value, which is much faster and valid
21034 now that EmptyStatement is a singleton.
21035 3. When resolving a block, rather than allocating a new array for
21036 the non-empty statements, empty statements are replaced with
21037 EmptyStatement.Value
21038 4. Some recursive functions have been made non-recursive.
21039 Mainly the performance impact is from (3), however (1) and (2) are needed for
21040 this to work. (4) does not make a big difference in normal situations, however
21041 it makes the profile look saner.
21046 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21047 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21048 Total memory allocated: 56397 KB
21051 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21052 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21053 Total memory allocated: 55666 KB
21055 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21057 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21058 than the hashtable in a hashtable version
21060 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21061 we always end up concating a string. This results in a huge perf
21062 loss, because many strings have to be tracked by the GC. In this
21063 patch, we first use a hashtable that works with two keys, so that
21064 the strings do not need to be concat'ed.
21068 Run 1: 8.74 seconds
21069 Run 2: 8.71 seconds
21072 Run 1: 8.65 seconds
21073 Run 2: 8.56 seconds
21075 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21077 * Makefile: Add a new target `do-time' that does a quick and simple
21078 profile, leaving easy to parse output.
21080 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21082 * codegen.cs (Init): Create the dynamic assembly with
21083 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21085 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21087 * support.cs: Make the PtrHashtable use only one
21088 instance of its comparer.
21090 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21092 * typemanager.cs: Fix lookup of GetNamespaces.
21094 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21096 * expression.cs: Removed redundant line.
21098 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21099 ArrayLists, use for loops with bounds.
21101 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21104 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21105 arraylists, use for loop with bounds.
21107 The above three changes give us a 0.071 second performance
21108 improvement out of 3.294 seconds down to 3.223. On my machine
21109 the above changes reduced the memory usage by 1,387 KB during
21110 compiler bootstrap.
21112 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21113 QualifiedIdentifiers. Before we created a new string through
21114 concatenation, and mostly later on, the result would be
21115 manipulated by DecomposeQI through string manipulation.
21117 This reduced the compiler memory usage for bootstrapping from
21118 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21119 compile times in 0.05 seconds.
21121 2003-11-28 Dick Porter <dick@ximian.com>
21123 * support.cs: Do string compares with the Invariant culture.
21131 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21132 the comparison is done with the Invariant culture.
21134 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21136 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21137 GetEnumerator method.
21139 (ProbeCollectionType): Iterate starting at the most specific type
21140 upwards looking for a GetEnumerator
21142 * expression.cs: Shift count can be up to 31 for int/uint and 63
21145 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21147 * statement.cs (Block.LookupLabel): Also look for the label on the
21148 children blocks. Use a hash table to keep track of visited
21151 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21152 we actually did transform the other operand, otherwise fall back
21153 to the common codepath that casts to long.
21155 * cs-tokenizer.cs: Use the same code pattern as the int case.
21156 Maybe I should do the parsing myself, and avoid depending on the
21157 Parse routines to get this done.
21159 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21161 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21162 which fixes bug 51347. This time test it.
21164 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21165 attributes for example can not tell the difference between these.
21166 The difference was only a syntax feature of the language.
21168 * attribute.cs: Apply attributes to delegates.
21170 * delegate.cs: Call the apply attributes method.
21172 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21174 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21175 comparing 0 vs Byte.MinValue, not the value
21177 (ImplicitConversionRequired): When reporting a conversion error,
21178 use error 31 to print out the constant error instead of the
21181 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21182 which fixes bug 51347.
21184 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21186 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21187 which fixes the -warnaserror command line option.
21189 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21191 * cfold.cs (DoNumericPromotions): During constant folding of
21192 additions on UIntConstant, special case intconstants with
21193 IntConstants like we do on the expression binary operator.
21195 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21197 * convert.cs (ImplicitReferenceConversion): We were missing a case
21198 (System.Enum are not value types or class types, so we need to
21199 classify them separatedly).
21201 * driver.cs: We do not support error 2007.
21203 2003-11-12 Jackson Harper <jackson@ximian.com>
21205 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21206 system directory. Also use the full file name so users can
21207 libraries names mscorlib-o-tron.dll in a non system dir.
21209 2003-11-10 Martin Baulig <martin@ximian.com>
21211 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21212 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21213 calling `ResolveType()' on them, directly assign their `Type'.
21215 2003-11-08 Martin Baulig <martin@ximian.com>
21217 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21218 return value and the `out parent' parameter.
21219 (TypeContainer.DefineType): Moved the CS0644 check into
21220 GetClassBases(). Don't pass the interface types to the
21221 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21222 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21224 * ecore.cs (TypeExpr.IsAttribute): New property.
21225 (TypeExpr.GetInterfaces): New method.
21227 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21228 TypeExpr instead of a Type.
21229 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21230 (Interface.DefineType): Don't pass the interface types to the
21231 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21232 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21234 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21235 instead of a `Type[]'.
21236 (TypeManager.RegisterBuilder): Likewise.
21237 (TypeManager.AddUserInterface): Likewise.
21238 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21239 `Type[]' and also return a `TypeExpr[]'.
21240 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21242 2003-11-08 Martin Baulig <martin@ximian.com>
21244 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21247 2003-11-08 Martin Baulig <martin@ximian.com>
21249 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21250 TypeManager.ResolveExpressionTypes().
21252 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21253 instead of an Expression.
21254 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21255 (TypeExpression): New public class; formerly known as `TypeExpr'.
21257 * expression.cs (ComposedCast): Derive from TypeExpr.
21259 * typemanager.cs (TypeManager.system_*_expr): These are now
21260 TypExpr's instead of Expression's.
21261 (TypeManager.ResolveExpressionTypes): New public static function;
21262 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21265 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21267 * expression.cs (New.DoResolve): Do not dereference value that
21268 might be a null return.
21270 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21271 sure that the constant value has the right type. Fixes an
21272 unreported bug, similar to 50425.
21274 * const.cs (Const.LookupConstantValue): Call
21275 ImplicitStandardConversionExists before doing a conversion to
21276 avoid havng the TypeManager.ChangeType do conversions.
21278 Reduced the number of casts used
21280 (Const.ChangeType): New routine to enable reuse of the constant
21281 type changing code from statement.
21283 * typemanager.cs (ChangeType): Move common initialization to
21284 static global variables.
21288 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21289 every value type to go through, even if it was void. Fix that.
21291 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21292 character of the define, and the is_identifier_part_character for
21293 the rest of the string.
21295 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21297 * expression.cs (UnaryMutator.EmitCode): When I updated
21298 LocalVariableReference.DoResolve, I overdid it, and dropped an
21299 optimization done on local variable references.
21301 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21303 * ecore.cs: Convert the return from Ldlen into an int.
21305 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21307 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21308 the accessibility, this is a special case for toplevel non-public
21309 classes (internal for instance).
21311 2003-10-20 Nick Drochak <ndrochak@gol.com>
21313 * ecore.cs: Fix typo and build. Needed another right paren.
21315 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21317 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21318 `internal' case regular and protected, but not allowing protected
21319 to be evaluated later. Bug 49840
21321 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21323 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21324 to kb.Nlast, and not the kb.nFirst to isolate the switch
21327 Extract the underlying type, so enumerations of long/ulong are
21328 treated like long/ulong.
21330 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21332 * expression.cs (New): Overload the meaning of RequestedType to
21333 track the possible creation of the NewDelegate type, since
21334 DoResolve is invoked more than once for new constructors on field
21337 See bugs: #48800 and #37014
21339 * cs-parser.jay (declare_local_constants): Take an arraylist
21340 instead of a single constant.
21342 (local_constant_declaration): It should take a
21343 constant_declarators, not a constant_declarator. Fixes 49487
21345 * convert.cs: Fix error report.
21347 2003-10-13 Jackson Harper <jackson@ximian.com>
21349 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21352 2003-10-09 Martin Baulig <martin@ximian.com>
21354 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21356 (MethodCore.DoDefineParameters): Removed the TypeContainer
21357 argument; use the DeclSpace which was passed to the .ctor instead.
21358 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21359 TypeContainer; we only need a DeclSpace here.
21361 2003-10-09 Martin Baulig <martin@ximian.com>
21363 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21365 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21366 EmitContext's .ctor.
21368 2003-10-09 Martin Baulig <martin@ximian.com>
21370 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21371 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21372 AsAccessible(), moved them as well.
21374 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21376 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21378 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21380 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21382 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21383 generation for >=, as spotted by Paolo, bug 48679.
21384 Patch from David Waite.
21386 * cs-tokenizer.cs: Add handling for #pragma.
21388 * cs-parser.jay: Allow for both yield and yield return in the
21389 syntax. The anti-cobolization of C# fight will go on!
21391 * class.cs (TypeBuilder.DefineType): Catch error condition here
21392 (Parent.DefineType erroring out and returning null).
21394 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21395 coping with enumerations variables, we were mistakenly processing
21396 them as a regular value type instead of built-in types. Fixes the
21399 * typemanager.cs (IsBuiltinOrEnum): New method.
21401 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21403 * cs-parser.jay: Upgrade: yield now needs the return clause.
21405 2003-09-19 Martin Baulig <martin@ximian.com>
21407 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21408 `MemberCache parent' argument. Normally, an interface doesn't
21409 have a parent type except System.Object, but we use this in gmcs
21410 for generic type parameters.
21412 2003-09-18 Martin Baulig <martin@ximian.com>
21414 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21415 on `type.IsInterface'; don't check whether the type has a parent
21416 to determine whether it's an interface.
21418 2003-09-15 Martin Baulig <martin@ximian.com>
21420 * class.cs (TypeContainer.DefineType): Added an error flag to
21421 avoid reporting duplicate CS0146's ("class definition is
21424 * driver.cs (Driver.MainDriver): Abort if
21425 RootContext.ResolveTree() reported any errors.
21427 2003-09-07 Martin Baulig <martin@ximian.com>
21429 * report.cs (Error, Warning): Added overloaded versions which take
21430 a `params object[] args' and call String.Format().
21432 2003-09-07 Martin Baulig <martin@ximian.com>
21434 * decl.cs (DeclSpace..ctor): Don't call
21435 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21436 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21437 (DeclSpace.RecordDecl): New method.
21439 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21441 2003-09-02 Ravi Pratap <ravi@ximian.com>
21443 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21444 value attributes to be applied to ParameterBuilders.
21446 * class.cs (MethodCore.LabelParameters): Make static and more
21447 generic so that it can be used from other places - like interface
21448 methods, for instance.
21450 * interface.cs (Interface.Emit): Call LabelParameters before
21451 emitting attributes on the InterfaceMethod.
21453 2003-08-26 Martin Baulig <martin@ximian.com>
21455 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21456 resolving aliases; fixes #47927.
21458 2003-08-26 Martin Baulig <martin@ximian.com>
21460 * statement.cs (Using.DoResolve): This is internally emitting a
21461 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21462 do not always return. Fixes #47681.
21464 2003-08-26 Martin Baulig <martin@ximian.com>
21466 * decl.cs (MemberCore): Moved WarningNotHiding(),
21467 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21469 (AdditionResult): Make this nested in DeclSpace.
21470 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21471 argument; call NamespaceEntry.Define() unless we're nested in a
21474 * namespace.cs (Namespace.DefineName): New public function. This
21475 is called from DeclSpace's .ctor to add
21476 (Namespace.Lookup): Include DeclSpaces in the lookup.
21478 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21480 * const.cs (Const): Derive from MemberBase, not MemberCore.
21482 2003-08-25 Martin Baulig <martin@ximian.com>
21484 * convert.cs (Convert.ExplicitReferenceConversion): When
21485 converting from an interface type to a class, unbox if the target
21486 type is a struct type. Fixes #47822.
21488 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21490 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21493 2003-08-22 Martin Baulig <martin@ximian.com>
21495 * class.cs (TypeManager.DefineType): When defining a nested type,
21496 call DefineType() on our parent; fixes #47801.
21498 2003-08-22 Martin Baulig <martin@ximian.com>
21500 * class.cs (MethodData.Define): While checking if a method is an
21501 interface implementation, improve the test a bit more to fix #47654.
21503 2003-08-22 Martin Baulig <martin@ximian.com>
21505 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21506 correctly; fixes #47722.
21508 2003-08-22 Martin Baulig <martin@ximian.com>
21510 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21511 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21513 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21515 2003-08-22 Martin Baulig <martin@ximian.com>
21517 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21518 can only be assigned in static constructors. Fixes #47161.
21520 2003-08-22 Martin Baulig <martin@ximian.com>
21522 Rewrote and improved the flow analysis code.
21524 * flowbranching.cs (FlowBranching): Make this class abstract.
21525 (FlowBranching.CreateBranching): New static function to create a
21526 new flow branching.
21527 (FlowBranchingBlock, FlowBranchingException): New classes.
21528 (FlowBranching.UsageVector.Type): New public readonly field.
21529 (FlowBranching.UsageVector.Breaks): Removed the setter.
21530 (FlowBranching.UsageVector.Returns): Removed the setter.
21531 (FlowBranching.UsageVector): Added Break(), Return(),
21532 NeverReachable() and Throw() methods to modify the reachability.
21533 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21534 done by FlowBranching.Merge().
21535 (FlowBranching.UsageVector.MergeChild): New method; merges the
21536 merge result into the current vector.
21537 (FlowBranching.Merge): New abstract method to merge a branching.
21539 2003-08-12 Martin Baulig <martin@ximian.com>
21541 * expression.cs (Indirection.CacheTemporaries): Create the
21542 LocalTemporary with the pointer type, not its element type.
21544 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21546 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21547 token was a keyword or not.
21549 Add `error' options where an IDENTIFIER was expected; Provide
21550 CheckToken and CheckIdentifierToken convenience error reporting
21553 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21555 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21556 NameSpaceEntry NameSpaceEntry.
21558 (LookupInterfaceOrClass): Avoid creating a full qualified name
21559 from namespace and name: avoid doing lookups when we know the
21560 namespace is non-existant. Use new Tree.LookupByNamespace which
21561 looks up DeclSpaces based on their namespace, name pair.
21563 * driver.cs: Provide a new `parser verbose' to display the
21564 exception thrown during parsing. This is turned off by default
21565 now, so the output of a failure from mcs is more graceful.
21567 * namespace.cs: Track all the namespaces defined in a hashtable
21570 (IsNamespace): New method
21572 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21574 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21575 we know that we need to concatenate (full typename can never be
21580 * statement.cs: Use a bitfield; Do not initialize to null things
21581 which are done by the constructor by default.
21583 * cs-parser.jay: bug fix, parameter was 4, not 3.
21585 * expression.cs: Just use the property;
21587 * statement.cs: No need for GetVariableInfo method.
21589 2003-08-08 Martin Baulig <martin@ximian.com>
21591 * flowanalysis.cs (FlowReturns): This is now nested in the
21592 `FlowBranching' class.
21593 (MyBitVector): Moved this here from statement.cs.
21594 (FlowBranching.SiblingType): New enum type.
21595 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21597 2003-08-07 Martin Baulig <martin@ximian.com>
21599 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21600 `FlowBranching' class and called `BranchingType'.
21602 2003-08-07 Martin Baulig <martin@ximian.com>
21604 * flowanalysis.cs: Moved all the control flow analysis code into
21607 2003-08-07 Martin Baulig <martin@ximian.com>
21609 * assign.cs (Assign.DoResolve): `target' must either be an
21610 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21613 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21615 * expression.cs (BinaryMethod): This kind of expression is created by the
21616 Binary class if it determines that the operator has to be handled
21619 (BinaryDelegate): This kind of expression is created if we are
21620 dealing with a + or - operator on delegates.
21622 (Binary): remove method, argumetns, and DelegateOperator: when
21623 dealing with methods,
21625 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21627 * statement.cs (Block): use bitfields for the three extra booleans
21628 we had in use. Remove unused topblock parameter.
21630 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21632 * assign.cs: Drop extra unneeded tests.
21634 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21636 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21638 * statement.cs (Foreach): Use VariableStorage instead of
21641 * codegen.cs (VariableStorage): New class used by clients that
21642 require a variable stored: locals or fields for variables that
21643 need to live across yield.
21645 Maybe provide a convenience api for EmitThis+EmitLoad?
21647 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21650 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21652 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21653 RemapParameterLValue): New methods that are used to turn a
21654 precomputed FieldInfo into an expression like this:
21658 The idea is to use this instead of making LocalVariableReference
21659 have more than one meaning.
21661 * cs-parser.jay: Add error production to BASE.
21663 * ecore.cs: Deal with TypeManager.GetField returning null, which
21664 is now a valid return value.
21666 (FieldExprNoAddress): New expression for Fields whose address can
21669 * expression.cs (LocalVariableReference): During the resolve
21670 phases, create new expressions if we are in a remapping context.
21671 Remove code that dealt with remapping here.
21673 (ParameterReference): same.
21675 (ProxyInstance): New expression, like the `This' expression, but
21676 it is born fully resolved. We know what we are doing, so remove
21677 the errors that are targeted to user-provided uses of `this'.
21679 * statement.cs (Foreach): our variable is now stored as an
21680 Expression; During resolution, follow the protocol, dont just
21681 assume it will return this.
21683 2003-08-06 Martin Baulig <martin@ximian.com>
21685 * support.cs (SeekableStreamReader.cs): New public class.
21687 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21688 SeekableStreamReader instead of the normal StreamReader.
21690 2003-08-04 Martin Baulig <martin@ximian.com>
21692 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21693 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21694 deambiguate casts and delegate invocations.
21695 (parenthesized_expression): Use the new tokens to ensure this is
21696 not a cast of method invocation.
21698 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21699 when reading a `)' and Deambiguate_CloseParens () was previously
21702 * expression.cs (ParenthesizedExpression): New class. This is
21703 just used for the CS0075 test.
21704 (Binary.DoResolve): Check for CS0075.
21706 2003-07-29 Ravi Pratap <ravi@ximian.com>
21708 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21709 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21710 reference comparison.
21712 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21713 examine the ReturnType for equality - this is necessary in the
21714 cases of implicit and explicit operators whose signature also
21715 includes the return type.
21717 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21719 * namespace.cs: Cache the result of the namespace computation,
21720 instead of computing it every time.
21722 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21724 * decl.cs: Use a global arraylist that we reuse over invocations
21725 to avoid excesive memory consumption. Reduces memory usage on an
21726 mcs compile by one meg (45 average).
21728 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21729 private, work around that.
21731 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21733 * literal.cs (IntLiteral): Define Zero and One static literals.
21735 * cs-parser.jay (integer_literal): use static literals to reduce
21736 memory usage for the most used literals (0, 1 and -1). 211kb
21737 reduced in memory usage.
21739 Replace all calls to `new ArrayList' with `new
21740 ArrayList(4)' which is a good average number for most allocations,
21741 and also requires only 16 bytes of memory for its buffer by
21744 This reduced MCS memory usage in seven megabytes for the RSS after
21747 2003-07-28 Ravi Pratap <ravi@ximian.com>
21749 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21750 handle params methods the correct way by forming only one
21751 applicable set with params and normal methods in them. Earlier we
21752 were looking at params methods only if we found no normal methods
21753 which was not the correct thing to do.
21755 (Invocation.BetterFunction): Take separate arguments indicating
21756 when candidate and the best method are params methods in their
21759 This fixes bugs #43367 and #46199.
21761 * attribute.cs: Documentation updates.
21763 (CheckAttribute): Rename to CheckAttributeTarget.
21764 (GetValidPlaces): Rename to GetValidTargets.
21766 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21767 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21771 2003-07-28 Martin Baulig <martin@ximian.com>
21773 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21774 name when looking up the base class of a nested class. Fixes #46977.
21776 2003-07-26 Martin Baulig <martin@ximian.com>
21778 * expression.cs (Indexers.Indexer): New nested struct; contains
21779 getter, setter and the indexer's type.
21780 (Indexers.Properties): This is now an ArrayList of
21781 Indexers.Indexer's.
21782 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21783 indexer doesn't have any getters.
21785 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21786 for embedded property and indexer assignments.
21788 2003-07-26 Martin Baulig <martin@ximian.com>
21790 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21791 preprocessor directive is not the first non-whitespace character
21794 2003-07-26 Martin Baulig <martin@ximian.com>
21796 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21797 namespace parsing, follow the spec more closely.
21799 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21800 NamespaceEntry.Lookup().
21802 2003-07-25 Martin Baulig <martin@ximian.com>
21804 * MethodCore.cs (OverridesSomething): New public field; it's set
21805 from TypeContainer.DefineMembers if this method overrides
21806 something (which doesn't need to be a method). Fix #39462.
21808 2003-07-25 Ravi Pratap <ravi@ximian.com>
21810 * typemanager.cs (GetMembers): Ensure that the list of members is
21811 reversed. This keeps things in sync.
21813 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21814 find an AttributeUsage attribute.
21816 * expression.cs (Invocation.OverloadResolve): Perform the check
21817 which disallows Invoke to be directly called on a Delegate.
21819 (Error_InvokeOnDelegate): Report error cs1533.
21821 2003-07-25 Martin Baulig <martin@ximian.com>
21823 * expression.cs (Indexers.GetIndexersForType): Only look in the
21824 interface hierarchy if the requested type is already an
21825 interface. Fixes #46788 while keeping #46502 fixed.
21827 2003-07-25 Martin Baulig <martin@ximian.com>
21829 * class.cs (TypeContainer.DefineMembers): Check whether all
21830 readonly fields have been assigned and report warning CS0649 if
21833 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21836 2003-07-24 Ravi Pratap <ravi@ximian.com>
21838 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21839 returned from GetMethods to make things consistent with the
21840 assumptions MCS makes about ordering of methods.
21842 This should comprehensively fix bug #45127 and it does :-)
21844 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21845 ordering is actually reverse.
21847 * Clean up some debug messages I left lying around.
21849 * interface.cs (Populate*): Get rid of code which emits attributes
21850 since the stage in which we emit attributes is the 'Emit' stage,
21851 not the define stage.
21853 (Emit): Move attribute emission for interface members here.
21855 2003-07-22 Ravi Pratap <ravi@ximian.com>
21857 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21858 closely: we eliminate methods in base types when we have an
21859 applicable method in a top-level type.
21861 Please see section 14.5.5.1 for an exact description of what goes
21864 This fixes bug #45127 and a host of other related to corlib compilation.
21866 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21867 array is the method corresponding to the top-level type (this is
21868 because of the changes made to icall.c) so we change this
21871 (MethodGroupExpr.Name): This too.
21873 * typemanager.cs (GetElementType): New method which does the right
21874 thing when compiling corlib.
21876 * everywhere: Make use of the above in the relevant places.
21878 2003-07-22 Martin Baulig <martin@ximian.com>
21880 * cs-parser.jay (invocation_expression): Moved
21881 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21882 `cast_expression', but create a InvocationOrCast which later
21883 resolves to either an Invocation or a Cast.
21885 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21886 method; call this before EmitStatement() to make sure that this
21887 expression can be used as a statement.
21889 * expression.cs (InvocationOrCast): New class; resolves to either
21890 an Invocation or a Cast.
21892 * statement.cs (StatementExpression): Call ResolveStatement() on
21893 the ExpressionStatement before emitting it.
21895 2003-07-21 Martin Baulig <martin@ximian.com>
21897 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21898 `ref' and `out' attributes match; fixes #46220.
21899 (MemberAccess.ResolveMemberAccess): You can't reference a type
21900 through an expression; fixes #33180.
21901 (Indexers.GetIndexersForType): Don't return the indexers from
21902 interfaces the class implements; fixes #46502.
21904 2003-07-21 Martin Baulig <martin@ximian.com>
21906 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21907 CS0661 checks; fixes bug #30442.
21909 2003-07-21 Martin Baulig <martin@ximian.com>
21911 * decl.cs (AdditionResult): Added `Error'.
21913 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21915 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21916 makes cs0031.cs actually work.
21918 2003-07-20 Martin Baulig <martin@ximian.com>
21920 * namespace.cs: Fixed that bug which caused a crash when compiling
21921 the debugger's GUI.
21923 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21925 * typemanager.cs (LookupTypeReflection): Never expose types which
21926 are NotPublic, NestedPrivate, NestedAssembly, or
21927 NestedFamANDAssem. We used to return these, and later do a check
21928 that would report a meaningful error, but the problem is that we
21929 would not get the real match, if there was a name override.
21931 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21933 * namespace.cs (Namespace, Name): Do not compute the namespace
21934 name dynamically, compute it in the constructor. This reduced
21935 memory usage by 1697 KB.
21937 * driver.cs: Use --pause to pause at the end.
21939 2003-07-17 Peter Williams <peter@newton.cx>
21941 * Makefile: Change the name of the test target so that it doesn't
21942 conflict with the recursive test target.
21944 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21946 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21947 AddressOf): Do not use EmitThis, that was wrong, use the actual
21950 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21952 * class.cs (MethodData.Define): While checking if a method is an
21953 interface implementation, improve the test: If we are not public
21954 (use new test here: use the computed MethodAttributes directly,
21955 instead of the parsed modifier flags) check if the `implementing'
21956 method comes from an interface or not.
21958 * pending.cs (VerifyPendingMethods): Slightly better error
21961 * makefile: add test target that does the mcs bootstrap.
21963 2003-07-16 Ravi Pratap <ravi@ximian.com>
21965 * interface.cs (Define): Do nothing here since there are no
21966 members to populate etc. Move the attribute emission out of here
21967 since this was just totally the wrong place to put it. Attribute
21968 application happens during the 'Emit' phase, not in the 'Define'
21971 (Emit): Add this method and move the attribute emission here
21973 * rootcontext.cs (EmitCode): Call the Emit method on interface
21976 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21978 * expression.cs (OverloadResolve): Report error only if Location
21979 is not 'Null' which means that there was a probe going on.
21981 2003-07-14 Martin Baulig <martin@ximian.com>
21983 * expression.cs (ConditionalLogicalOperator): New public class to
21984 implement user defined conditional logical operators.
21985 This is section 14.11.2 in the spec and bug #40505.
21987 2003-07-14 Martin Baulig <martin@ximian.com>
21989 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21991 2003-07-14 Martin Baulig <martin@ximian.com>
21993 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21995 * ecore.cs (IVariable.VerifyFixed): New interface method.
21997 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21998 operator, check whether the variable is actually fixed. Fixes bug
21999 #36055. Set a variable definitely assigned when taking its
22000 address as required by the spec.
22002 * statement.cs (LocalInfo.IsFixed): New field.
22003 (LocalInfo.MakePinned): Set `IsFixed' to true.
22005 2003-07-14 Ravi Pratap M <ravi@ximian.com>
22007 * attribute.cs (Attribute.Resolve): While doing a Member lookup
22008 for .ctors, ensure that we only ask for members declared in the
22009 attribute type (BindingFlags.DeclaredOnly).
22013 * expression.cs (Error_WrongNumArguments): Report error 1501
22014 correctly the way CSC does.
22016 2003-07-13 Martin Baulig <martin@ximian.com>
22018 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
22019 lookup on the fully qualified name, to make things like "X.X" work
22020 where "X.X" is a fully qualified type name, but we also have a
22021 namespace "X" in the using list. Fixes #41975.
22023 2003-07-13 Martin Baulig <martin@ximian.com>
22025 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
22026 function. If we're a CompoundAssign, we need to create an embedded
22027 CompoundAssign, not an embedded Assign.
22028 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
22031 2003-07-13 Martin Baulig <martin@ximian.com>
22033 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
22034 work to fix bug #46088.
22036 2003-07-13 Ravi Pratap <ravi@ximian.com>
22038 * class.cs (Operator.Emit): Do not emit attributes here - it is
22039 taken care of by the Method class that we delegate too. This takes
22040 care of bug #45876.
22042 2003-07-10 Martin Baulig <martin@ximian.com>
22044 * expression.cs (TypeOfVoid): New class.
22045 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
22047 2003-07-10 Martin Baulig <martin@ximian.com>
22049 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22052 2003-07-10 Martin Baulig <martin@ximian.com>
22054 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22055 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22057 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22059 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22061 2003-07-10 Martin Baulig <martin@ximian.com>
22063 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22064 of decimal. Fixes #42850.
22066 NOTE: I also fixed the created byte blob, but this doesn't work on
22067 the MS runtime and csc never produces any byte blobs for decimal
22070 2003-07-10 Martin Baulig <martin@ximian.com>
22072 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22073 structs; fixes #32068.
22074 (Block.AddChildVariableNames): Fixed #44302.
22076 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22078 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22080 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22082 * attribute.cs: And this test is onger needed.
22084 2003-07-08 Martin Baulig <martin@ximian.com>
22086 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22087 inaccessible types. Fixes #36313.
22089 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22091 * namespace.cs (NamespaceEntry): Create implicit entries for all
22092 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22093 implicit entries for N1.N2 and N1.
22095 2003-07-08 Martin Baulig <martin@ximian.com>
22097 Rewrote the handling of namespaces to fix a lot of the issues
22098 wrt. `using' aliases etc.
22100 * namespace.cs (Namespace): Splitted this class into a
22101 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22103 * typemanager.cs (TypeManager.IsNamespace): Removed.
22104 (TypeManager.ComputeNamespaces): Only compute namespaces from
22105 loaded assemblies here, not the namespaces from the assembly we're
22106 currently compiling.
22108 2003-07-08 Martin Baulig <martin@ximian.com>
22110 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22112 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22114 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22117 I thought about the memory savings here, but LookupTypeReflection
22118 is used under already very constrained scenarios. Compiling
22119 corlib or mcs only exposes one hit, so it would not really reduce
22120 any memory consumption.
22122 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22124 * typemanager.cs: fixes bug #45889 by only adding public types from
22125 other assemblies to the list of known types.
22127 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22129 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22130 on the type we resolved.
22132 2003-07-05 Martin Baulig <martin@ximian.com>
22134 * pending.cs (PendingImplementation.ParentImplements): Don't
22135 create the proxy if the parent is abstract.
22137 * class.cs (TypeContainer.DefineIndexers): Process explicit
22138 interface implementations first. Fixes #37714.
22140 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22142 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22143 defined recursively; but since we modify the input parameters
22144 (left is set to `this' temporarily), we reset this value if the
22145 left_is_explicit is false, which gives the original semantics to
22148 * literal.cs (NullPointer): new class used to represent a null
22149 literal in a pointer context.
22151 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22152 type is a pointer, use a NullPointer object instead of a
22153 NullLiteral. Closes 43687
22155 (ExplicitConversion): Convert pointer values using
22156 the conv opcode to the proper type.
22158 * ecore.cs (New): change ValueTypeVariable property into a method,
22159 that returns whether the valuetype is suitable for being used.
22161 * expression.cs (Binary.DoNumericPromotions): Only return if we
22162 the int constant was a valid uint, and we can return both left and
22163 right as uints. If not, we continue processing, to trigger the
22164 type conversion. This fixes 39018.
22166 * statement.cs (Block.EmitMeta): During constant resolution, set
22167 the CurrentBlock property on the emitcontext, so that we resolve
22168 constants propertly.
22170 2003-07-02 Martin Baulig <martin@ximian.com>
22172 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22173 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22175 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22176 than emitting it here.
22178 * statement.cs: Fixed some more flow analysis bugs.
22180 2003-07-02 Martin Baulig <martin@ximian.com>
22182 * class.cs (MethodData.Define): When implementing interface
22183 methods, set Final unless we're Virtual.
22185 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22186 check work for interface methods.
22188 2003-07-01 Martin Baulig <martin@ximian.com>
22190 * ecore.cs (EmitContext.This): Replaced this property with a
22191 GetThis() method which takes a Location argument. This ensures
22192 that we get the correct error location for a CS0188.
22194 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22196 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22197 ImplicitStandardConversion.
22199 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22201 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22203 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22206 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22208 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22211 (MethodData.Define): Turn off initlocals for unsafe methods.
22213 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22215 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22216 complete; Fixes #37521.
22218 * delegate.cs: Use Modifiers.TypeAttr to compute the
22219 TypeAttributes, instead of rolling our own. This makes the flags
22220 correct for the delegates.
22222 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22224 * class.cs (Constructor.Define): Set the private flag for static
22225 constructors as well.
22227 * cs-parser.jay (statement_expression): Set the return value to
22228 null, to avoid a crash when we catch an error.
22230 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22232 * cs-parser.jay: Applied patch from Jackson that adds support for
22233 extern and unsafe modifiers to destructor declarations.
22235 * expression.cs: Report error 21 if the user is trying to index a
22238 * driver.cs: Add an error message, suggested by the bug report.
22240 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22241 if we do not have a ": this ()" constructor initializer. Fixes 45149
22243 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22245 * namespace.cs: Add some information to reduce FAQs.
22247 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22249 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22250 underlying enumeration types. Fixes #43915.
22252 * expression.cs: Treat ushort/short as legal values to be used in
22253 bitwise operations.
22255 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22257 * delegate.cs: transfer custom attributes for paramenters from
22258 the delegate declaration to Invoke and BeginInvoke.
22260 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22262 * attribute.cs: handle custom marshalers and emit marshal info
22265 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22267 * makefile.gnu: Added anonymous.cs to the compiler sources.
22269 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22271 * iterators.cs: Change the name of the proxy class to include two
22274 * cs-parser.jay: Update grammar to include anonymous methods.
22276 * anonymous.cs: new file.
22278 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22280 * class.cs (Field.Define): Add missing test for pointers and
22283 2003-05-27 Ravi Pratap <ravi@ximian.com>
22285 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22286 we use the stobj opcode.
22288 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22289 since it wasn't the correct fix.
22291 It still is puzzling that we are required to use stobj for IntPtr
22292 which seems to be a ValueType.
22294 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22296 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22297 during regular simple name resolution. Now, the trick is that
22298 instead of returning for processing the simplename, we do a
22299 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22300 contextual lookup type). If a match is found, return that, if
22301 not, return for further composition.
22303 This fixes long-standing 30485.
22305 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22306 using the address to initialize an object, do an Stobj instead of
22307 using the regular Stelem.
22309 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22310 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22311 Because if we are a BaseIndexerAccess that value will be true.
22314 * statement.cs (GotoCase.Resolve): Return after reporting an
22315 error, do not attempt to continue.
22317 * expression.cs (PointerArithmetic.Emit): If our operand is a
22318 long, convert our constants to match the operand before
22319 multiplying. Convert to I type before adding. Fixes 43670.
22321 2003-05-14 Ravi Pratap <ravi@ximian.com>
22323 * enum.cs (ImplicitConversionExists) : Rename to
22324 ImplicitEnumConversionExists to remove ambiguity.
22326 * ecore.cs (NullCast): New type of cast expression class which
22327 basically is very similar to EmptyCast with the difference being
22328 it still is a constant since it is used only to cast a null to
22330 (eg. (string) null)
22332 * convert.cs (ImplicitReferenceConversion): When casting a null
22333 literal, we return a NullCast.
22335 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22336 should be around anymore.
22338 The renaming (reported was slightly wrong). Corrections:
22340 ConvertImplicitStandard -> ImplicitConversionStandard
22341 ConvertExplicitStandard -> ExplicitConversionStandard
22343 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22344 before passing them in !
22346 * convert.cs (ImplicitConversionStandard): When comparing for
22347 equal expr and target types, ensure that expr is not a
22350 In general, we must not be checking (expr_type ==
22351 target_type) in the top level conversion methods
22352 (ImplicitConversion, ExplicitConversion etc). This checking is
22353 done in the methods that they delegate to.
22355 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22357 * convert.cs: Move Error_CannotConvertType,
22358 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22359 ImplicitNumericConversion, ImplicitConversionExists,
22360 ImplicitUserConversionExists, StandardConversionExists,
22361 FindMostEncompassedType, FindMostSpecificSource,
22362 FindMostSpecificTarget, ImplicitUserConversion,
22363 ExplicitUserConversion, GetConversionOperators,
22364 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22365 TryImplicitIntConversion, Error_CannotConvertImplicit,
22366 ConvertImplicitRequired, ConvertNumericExplicit,
22367 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22368 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22371 Perform the following renames:
22373 StandardConversionExists -> ImplicitStandardConversionExists
22374 ConvertImplicit -> ImplicitConversion
22375 ConvertImplicitStandard -> ImplicitStandardConversion
22376 TryImplicitIntConversion -> ImplicitIntConversion
22377 ConvertImplicitRequired -> ImplicitConversionRequired
22378 ConvertNumericExplicit -> ExplicitNumericConversion
22379 ConvertReferenceExplicit -> ExplicitReferenceConversion
22380 ConvertExplicit -> ExplicitConversion
22381 ConvertExplicitStandard -> ExplicitStandardConversion
22383 2003-05-19 Martin Baulig <martin@ximian.com>
22385 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22386 (TypeInfo): Added support for structs having structs as fields.
22388 * ecore.cs (FieldExpr): Implement IVariable.
22389 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22390 VariableInfo for the field.
22392 2003-05-18 Martin Baulig <martin@ximian.com>
22394 * expression.cs (This.DoResolve): Report a CS0027 if we're
22395 emitting a field initializer.
22397 2003-05-18 Martin Baulig <martin@ximian.com>
22399 * expression.cs (This.ResolveBase): New public function.
22400 (This.DoResolve): Check for CS0188.
22402 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22405 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22406 `instance_expression' to null if we don't have any non-static
22409 2003-05-18 Martin Baulig <martin@ximian.com>
22411 Reworked the way how local variables and parameters are handled by
22412 the flow analysis code.
22414 * statement.cs (TypeInfo, VariableMap): New public classes.
22415 (VariableInfo): New public class. This is now responsible for
22416 checking whether a variable has been assigned. It is used for
22417 parameters and local variables.
22418 (Block.EmitMeta): Take the InternalParameters as argument; compute
22419 the layout of the flow vectors here.
22420 (Block.LocalMap, Block.ParameterMap): New public properties.
22421 (FlowBranching): The .ctor doesn't get the InternalParameters
22422 anymore since Block.EmitMeta() now computes the layout of the flow
22424 (MyStructInfo): This class is now known as `StructInfo' and nested
22425 in `TypeInfo'; we don't access this directly anymore.
22427 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22428 property and removed IsAssigned(), IsFieldAssigned(),
22429 SetAssigned() and SetFieldAssigned(); we now call them on the
22430 VariableInfo so we don't need to duplicate this code everywhere.
22432 * expression.cs (ParameterReference): Added `Block block' argument
22434 (LocalVariableReference, ParameterReference, This): The new
22435 VariableInfo class is now responsible for all the definite
22438 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22439 IsParameterAssigned, SetParameterAssigned): Removed.
22441 2003-05-18 Martin Baulig <martin@ximian.com>
22443 * typemanager.cs (InitCoreTypes): Try calling
22444 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22445 the 3-args-version. Corlib now also needs our `void_type'.
22446 (GetMethod): Added overloaded version which takes an optional
22447 `bool report_errors' to allow lookups of optional methods.
22449 2003-05-12 Martin Baulig <martin@ximian.com>
22451 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22452 only used for locals and not for parameters.
22454 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22456 * support.cs (InternalParameters.ParameterType): Return the
22457 ExternalType of the parameter.
22459 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22462 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22464 * class.cs (MethodData.Define): Do not set the `newslot' on
22465 interface members, if they are also flagged as "override".
22467 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22468 better code for ++i and i++. This only works for static fields
22469 and local variables.
22471 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22472 want to pull the DeclSpace out of the builder_to_declspace instead
22473 of the TypeBuilder (like in TypeContainer.FindMembers).
22475 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22476 instead of LookupTypeContainer. Fixes the crash on .NET for
22477 looking up interface members.
22479 * const.cs: Create our own emit context during the Definition
22480 stage, so that constants are evaluated in the proper context, when
22481 a recursive definition happens.
22483 2003-05-11 Martin Baulig <martin@ximian.com>
22485 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22486 new block for a switch section.
22487 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22488 the adding/lookup in the switch block. Fixes #39828.
22490 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22492 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22493 functionality: I needed to convert the data after I had performed
22494 the add/sub operation into the operands type size.
22496 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22497 pass the type for the box operation, otherwise the resulting
22498 object would have been of type object.
22500 (BoxedCast): Add constructor to specify the type to box as.
22502 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22504 * iterators.cs: I was reusing the `count' variable inadvertently,
22505 take steps to not allow this to happen.
22507 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22509 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22510 by creating an array at the point where the params starts and
22511 putting all those arguments there, then adjusting the size of the
22514 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22516 * expression.cs (New.AddressOf): Implement interface
22517 IMemoryLocation. This is used when the `new' operator is used in
22518 the context of an invocation to a method on a value type.
22520 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22523 * namespace.cs: Also check the using aliases here.
22525 * driver.cs: Move the test for using validity after the types have
22526 been entered, so we do a single pass that also includes the using
22529 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22530 in the regular case. CreateSiblingForFinally is doing extra
22533 * attribute.cs (GetAttributeArgumentExpression): Store the result
22534 on an out value, and use the return value to indicate failure
22535 instead of using null (which is a valid return for Constant.GetValue).
22537 * statement.cs: Perform the analysis flow for the increment
22538 portion after the statement, because this will be the real flow of
22539 execution. Fixes #42385
22541 * codegen.cs (EmitContext.EmitArgument,
22542 EmitContext.EmitStoreArgument): New helper functions when the
22543 RemapToProxy flag is set.
22545 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22548 Add support for remapping parameters.
22550 * iterators.cs: Propagate parameter values; Store parameter
22551 values in the proxy classes.
22553 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22555 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22556 need a proxy reference; I do not know what I was thinking
22558 * cs-parser.jay (constructor_initializer): catch another error,
22559 and display nice message.
22561 (field_declaration): catch void field declaration
22562 to flag a better error.
22564 * class.cs (MemberBase.CheckBase): Report an error instead of a
22565 warning if a new protected member is declared in a struct.
22566 (Field.Define): catch the error of readonly/volatile.
22568 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22570 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22571 volatile variable is taken
22573 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22575 * statement.cs (Fixed.Resolve): Report an error if we are not in
22578 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22580 * typemanager.cs: reuse the code that handles type clashes for
22581 delegates and enumerations.
22583 * class.cs (Report28): Always report.
22585 * expression.cs (EncodeAsAttribute): Allow nulls here.
22587 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22589 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22590 the functionality for testing whether an expression is valid for
22591 an attribute here. Also handle the case of arrays of elements
22594 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22595 encoding a linear array into an array of objects that are suitable
22596 to be passed to an CustomAttributeBuilder.
22598 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22600 * ecore.cs: (FieldExpr): Handle field remapping here.
22602 * iteratators.cs: Pass the instance variable (if the method is an
22603 instance method) to the constructors, so we can access the field
22604 variables on the class.
22606 TODO: Test this with structs. I think the THIS variable on
22607 structs might have to be a pointer, and not a refenrece
22609 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22611 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22612 local variables to fields in a proxy class.
22614 * iterators.cs (PopulateProxy): Rename our internal fields to
22616 Create a <THIS> field if we are an instance method, so we can
22617 reference our parent container variables.
22618 (MapVariable): Called back from the EmitContext code to enter a
22619 new variable to field mapping into the proxy class (we just create
22623 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22624 for using the remapped locals to fields.
22626 I placed the code here, because that gives the same semantics to
22627 local variables, and only changes the Emit code.
22629 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22630 statements inside iterators.
22631 (VariableInfo): Add a FieldBuilder for the cases when we are
22632 remapping local variables to fields in a proxy class
22634 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22635 current_block != null.
22637 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22638 not cope with strings, as it has been moved to the
22639 TableSwitchEmit. Fixed bug in switch generation.
22641 * expression.cs (New.DoResolve): Provide more context for the user
22642 when reporting an error.
22644 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22647 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22648 check the permissions for it. Note than in a type-resolution
22649 context the check was already present in DeclSpace.ResolveType,
22650 but was missing from the MemberAccess.
22652 (ArrayCreation.CheckIndices): warn if the user has
22653 more nested levels of expressions, but there are no more
22654 dimensions specified. Avoids crash on bug 41906.
22656 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22658 * statement.cs (Block): replace Implicit bool, for a generic
22660 New flag: `Unchecked'. This is used during the EmitMeta phase
22661 (which is out-of-line with the regular Resolve/Emit process for a
22662 statement, as this is done ahead of time, but still gets a chance
22663 to call constant resolve).
22665 (Block.Flags): new enum for adding a new flag.
22667 (Block.EmitMeta): track the state of unchecked.
22669 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22670 to enable constant resolution to work there as well.
22672 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22674 * typemanager.cs (ienumerable_type): Also look up
22675 System.Collections.IEnumerable.
22677 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22679 TODO: Test more than one conditional per method.
22681 * class.cs (Indexer.Define): Report the location where the user is
22682 referencing the unsupported feature.
22684 (MethodData): Overload the use of `conditionals' to
22685 minimize the creation of needless ArrayLists. This saves roughly
22686 212kb on my machine.
22688 (Method): Implement the new IIteratorContainer interface.
22689 (Method.SetYields): Implement the method by setting the ModFlags
22690 to contain METHOD_YIELDS.
22692 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22693 which just got set to null.
22695 * iterators.cs: New file.
22697 (Yield, YieldBreak): New statements.
22699 * statement.cs (Return.Resolve): Flag an error if we are used in
22700 an iterator method.
22702 * codegen.cs (InIterator): New flag set if the code is being
22703 compiled in an iterator method.
22705 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22706 internal modifier, and we just use it to avoid adding extra
22707 fields, as this is seldom used.
22709 * cs-parser.jay: Add yield_statement (yield and yield break).
22711 * driver.cs: New flag -v2 to turn on version 2 features.
22713 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22714 hashtable when v2 is enabled.
22716 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22718 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22719 there is already a namespace defined with this name.
22721 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22722 people upgraded their corlibs.
22724 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22725 always use fully qualified types, no need to use the compiler
22728 (TypeManager.IsNamespace): Use binarysearch.
22730 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22731 AddDelegate): I did not quite use the new IsValid API properly: I
22732 have to pass the short-name and the fullname. I was passing only
22733 the basename instead of the fullname sometimes.
22735 (TypeContainer.DefineType): call NamespaceClash.
22737 * interface.cs (Interface.DefineType): use NamespaceClash before
22740 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22743 * enum.cs: (Enum.DefineType): use NamespaceClash before
22746 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22747 speed increase. First, use the negative_hits cache when we get a
22748 negative. Second, add the type with its full original name
22749 instead of the new . and + encoded name (reflection uses + to
22750 separate type from a nested type). Use LookupTypeReflection
22751 directly which bypasses the type->name hashtable (that we already
22752 know does not contain the type.
22754 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22755 location/container type.
22757 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22759 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22761 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22763 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22764 method is being referenced in the method group from a static
22765 context, and report error 120 if so.
22767 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22770 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22771 is created, we create the A namespace).
22773 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22776 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22778 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22779 invocation to ModuleBuilder.GetType with the same values will
22780 return a new type instance, so we need to cache its return
22783 * expression.cs (Binary.ResolveOperator): Only allow the compare
22784 operators on enums if they are of the same type.
22786 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22787 types of ValueType on their own case. Before we were giving them
22788 the same treatment as objects.
22790 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22791 fullname. Short name is used to compare against container name.
22792 Fullname is used to check against defined namespace names.
22794 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22795 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22797 (Method.CheckBase): Call parent.
22798 (MemberBase.CheckBase): Check for protected members on sealed
22800 (PropertyBase.CheckBase): Call parent.
22801 (Field.Define): Call parent.
22803 * report.cs: Negative error codes are now mapped to 8000 - code,
22804 so that the display is render more nicely.
22806 * typemanager.cs: Do not use try/catch, instead report a regular
22809 (GetPointerType, GetReferenceType): These methods provide
22810 mechanisms to obtain the T* and T& from a T. We had the code
22811 previously scattered around the code base, and it also used
22812 TypeManager.LookupType that would go through plenty of caches.
22813 This one goes directly to the type source.
22815 In some places we did the Type.GetType followed by
22816 ModuleBuilder.GetType, but not in others, so this unifies the
22817 processing as well.
22819 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22820 statements now that we have namespace information.
22822 * typemanager.cs (IsNamespace): New method, returns whether the
22823 string presented is a namespace or not.
22825 (ComputeNamespaces): New public entry point, computes the list of
22826 available namespaces, using the GetNamespaces API call in Mono, or
22827 the slower version in MS.NET.
22829 Now before we start the semantic analysis phase, we have a
22830 complete list of namespaces including everything that the user has
22833 Deleted old code to cache namespaces in .nsc files.
22835 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22837 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22838 class/struct location definition Location for the implicit
22839 constructor location.
22841 (Operator.Define): Use the location of the operator for the
22842 implicit Method definition.
22844 (Constructor.Emit): use the constructor location for the implicit
22845 base initializer constructor.
22847 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22848 and the Expression class now contains two new methods:
22850 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22851 isolate type lookup from the rest of the resolution process.
22853 Since we use Expressions to hold type definitions due to the way
22854 we parse the input we have historically overloaded Resolve to
22855 perform the Type lookups if a special flag is passed. Now this is
22856 eliminated and two methods take their place.
22858 The differences in the two methods between xStep and xTerminal is
22859 that xStep is involved in our current lookup system that uses
22860 SimpleNames to compose a name, while xTerminal is used just to
22861 catch the case where the simplename lookup failed.
22863 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22865 * expression.cs (ResolveMemberAccess): Remove redundant code.
22866 TypeExpr expressions are always born fully resolved.
22868 * interface.cs (PopulateMethod): Do not lookup the types twice.
22869 We were doing it once during SemanticAnalysis and once during
22872 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22873 in local variable type definitions, were being returned as a
22874 SimpleName (we decomposed everything into a string), that is
22875 because primary_expression was being used instead of a type in the
22876 grammar (reduce/reduce conflicts).
22878 The part that was wrong is that we converted the expression into a
22879 string (an oversimplification in one hand, compounded with primary
22880 expressions doing string concatenation).
22886 Would return "A.B.C[]" as a SimpleName. This stopped things like
22887 using clauses from working on this particular context. And a type
22888 was being matched directly against "A.B.C[]".
22890 We now use the correct approach, and allow for ComposedCast to be
22891 part of the unary expression. So the "A.B.C []" become a composed
22892 cast of "A.B.C" (as a nested group of MemberAccess with a
22893 SimpleName at the end) plus the rank composition "[]".
22897 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22899 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22900 for the access level checking.
22902 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22903 `TypeContainer container', because I kept getting confused when I
22904 was debugging this code.
22906 * expression.cs (Indexers): Instead of tracking getters/setters,
22907 we now track them in parallel. We create one arraylist less, but
22908 most importantly it is possible now for the LValue code to find a
22909 matching get for a set.
22911 (IndexerAccess.DoResolveLValue): Update the code.
22912 GetIndexersForType has been modified already to extract all the
22913 indexers from a type. The code assumed it did not.
22915 Also make the code set the correct return type for the indexer.
22916 This was fixed a long time ago for properties, but was missing for
22917 indexers. It used to be void_type.
22919 (Binary.Emit): Test first for doubles instead of
22920 floats, as they are more common.
22922 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22923 when dealing with floats and the <=, >= operators. This fixes bug
22926 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22927 to load the array value by emitting a load on the foreach variable
22928 type. This was incorrect.
22930 We now emit the code to load an element using the the array
22931 variable type, and then we emit the conversion operator.
22935 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22937 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22939 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22941 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22942 test for protection before we test for signatures.
22944 (MethodSignature.ToString): implement.
22946 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22947 to the case where we reduced into a LongConstant.
22949 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22950 depend on whether the information is acurrate, because the
22951 Microsoft runtime will always claim that the array type is public,
22952 regardless of the real state.
22954 If the type is a pointer, another problem happens: the type is
22955 reported as non-public in Microsoft.
22957 In both cases we have to call CheckAccessLevel recursively with
22958 the underlying type as the argument to be tested.
22960 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22962 * assign.cs (Assign.Emit): If we are dealing with a compound
22963 assignment expression, we should use the code path that stores the
22964 intermediate result in a temporary value. This fixes #40903.
22966 *expression.cs (Indirection.ToString): Provide ToString method for
22969 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22971 * class.cs: Null out fields holding references to Block objects so
22972 they can be garbage collected.
22974 * expression.cs (OverloadResolve): Remove unused local.
22976 2003-04-07 Martin Baulig <martin@ximian.com>
22978 * codegen.cs (EmitContext.CurrentFile): New public field.
22979 (EmitContext.Mark): Use the CurrentFile to check whether the
22980 location is in the correct file.
22981 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22983 2003-04-07 Martin Baulig <martin@ximian.com>
22985 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22987 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22988 location. [FIXME: The location argument which gets passed to this
22989 method is sometimes wrong!]
22991 2003-04-07 Nick Drochak <ndrochak@gol.com>
22993 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22995 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22997 * expression.cs (Indirection.EmitAssign): We were using the
22998 temporary, but returning immediately instead of continuing the
23001 2003-04-06 Martin Baulig <martin@ximian.com>
23003 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
23004 if it's a nested child, but also deriving from the outer class.
23007 * typemanager.cs (IsNestedChildOf): Make this work if it's a
23008 nested child, but also deriving from the outer class. See
23010 (FilterWithClosure): We may access private members of the outer
23011 class if we're a nested child and deriving from the outer class.
23012 (RealMemberLookup): Only set `closure_private_ok' if the
23013 `original_bf' contained BindingFlags.NonPublic.
23015 2003-04-05 Martin Baulig <martin@ximian.com>
23017 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
23019 2003-04-02 Miguel de Icaza <miguel@ximian.com>
23021 * class.cs (Event.Define): Do not allow abstract events to have
23024 2003-04-01 Miguel de Icaza <miguel@ximian.com>
23026 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
23027 block in event declarations.
23029 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
23030 value type, get its address.
23032 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
23033 leaving a class on the stack instead of a boolean value (int
23034 0/1). Change the code so we compare against null, and then the
23035 result against zero.
23037 * class.cs (TypeContainer.GetClassBases): We were checking for the
23038 parent class being sealed too late.
23040 * expression.cs (Binary.Emit): For <= and >= when dealing with
23041 floating point values, use cgt.un and clt.un instead of cgt and
23044 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
23046 * statement.cs: Apply the same optimization as MS: skip the
23047 GetEnumerator returning an IEnumerator, and use the one returning a
23048 CharEnumerator instead. This allows us to avoid the try-finally block
23051 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23053 * cs-parser.jay: Attributes cannot be applied to
23054 namespaces. Fixes #40473
23056 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23059 (Add*): check if the name is valid using the full name for constants,
23060 fields, properties and events.
23062 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23064 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23065 char constants to be part of the enumeration.
23067 * expression.cs (Conditional.DoResolve): Add support for operator
23068 true. Implements the missing functionality from 14.12
23070 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23071 operator true/false as required by the spec.
23073 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23074 implicit conversion to boolean.
23076 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23077 also one where the type implements `operator true'.
23079 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23080 get an expression that will invoke operator true based on an
23083 (GetConversionOperators): Removed the hack that called op_True
23086 (Expression.ResolveBoolean): Move this from Statement.
23088 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23090 * ecore.cs (FieldExpr): do not allow initialization of initonly
23091 fields on derived classes
23093 2003-03-13 Martin Baulig <martin@ximian.com>
23095 * statement.cs (Block.Emit): Call ig.BeginScope() and
23096 ig.EndScope() when compiling with debugging info; call
23097 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23099 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23101 * expression.cs (Indexers): Do not construct immediately, allow
23102 for new members to be appended as we go. Fixes 38143
23104 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23106 * expression.cs: save/restore context when resolving an unchecked
23109 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23111 * cfold.cs: Catch division by zero in modulus operator during
23114 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23116 * interface.cs (Interface.DefineMembers): Avoid defining members
23119 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23121 * driver.cs: handle the +/- options for -noconfig
23123 * statement.cs (Unckeched.Resolve): Also track the state of
23124 unchecked in the Resolve phase.
23126 2003-02-27 Martin Baulig <martin@ximian.com>
23128 * ecore.cs (Expression.MemberLookup): Don't create a
23129 MethodGroupExpr for something which is not a method. Fixes #38291.
23131 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23133 * class.cs (MemberBase.CheckParameters): Also check that the type
23134 is unmanaged if it is a pointer.
23136 * expression.cs (SizeOf.Resolve): Add location information.
23138 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23139 a managed type is declared.
23141 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23142 parameter modifiers as well. Fixes bug 38606
23144 * class.cs: Very sad. Am backing out the speed up changes
23145 introduced by the ArrayList -> Array in the TypeContainer, as they
23146 were not actually that much faster, and introduced a bug (no error
23147 reports on duplicated methods).
23149 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23150 source first, this will guarantee that we have a valid expression
23151 before calling in lower levels functions that will require a
23152 resolved object. Then use this original_source in the
23153 target.ResolveLValue instead of the original source that was
23156 Another change. Use target.Resolve instead of LValueResolve.
23157 Although we are resolving for LValues, we will let the Assign code
23158 take care of that (it will be called again from Resolve). This
23159 basically allows code like this:
23161 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23162 class Y { void A (X x) { x [0] += o; }
23164 The problem was that the indexer was trying to resolve for
23165 set_Item (idx, object o) and never finding one. The real set_Item
23166 was set_Item (idx, X). By delaying the process we get the right
23171 2003-02-23 Martin Baulig <martin@ximian.com>
23173 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23174 while calling DoEmit ().
23176 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23177 source files; if you use the #line directive inside a method, the
23178 compiler stops emitting line numbers for the debugger until it
23179 reaches the end of the method or another #line directive which
23180 restores the original file.
23182 2003-02-23 Martin Baulig <martin@ximian.com>
23184 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23186 2003-02-23 Martin Baulig <martin@ximian.com>
23188 * statement.cs (Block.AddChildVariableNames): We need to call this
23189 recursively, not just for our immediate children.
23191 2003-02-23 Martin Baulig <martin@ximian.com>
23193 * class.cs (Event.Define): Always make the field private, like csc does.
23195 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23196 actually work, fixes bug #37521.
23198 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23200 * delegate.cs: When creating the various temporary "Parameters"
23201 classes, make sure that we call the ComputeAndDefineParameterTypes
23202 on those new parameters (just like we do with the formal ones), to
23203 allow them to be resolved in the context of the DeclSpace.
23205 This fixes the bug that Dick observed in Bugzilla #38530.
23207 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23209 * expression.cs (ResolveMemberAccess): When resolving a constant,
23210 do not attempt to pull a constant if the value was not able to
23211 generate a valid constant.
23213 * const.cs (LookupConstantValue): Do not report more errors than required.
23215 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23217 * expression.cs: fixes bug #38328.
23219 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23221 * class.cs: Changed all the various members that can be part of a
23222 class from being an ArrayList to be an Array of the right type.
23223 During the DefineType type_list, interface_list, delegate_list and
23224 enum_list are turned into types, interfaces, delegates and enums
23227 And during the member population, indexer_list, event_list,
23228 constant_list, field_list, instance_constructor_list, method_list,
23229 operator_list and property_list are turned into their real arrays.
23231 Although we could probably perform this operation earlier, for
23232 good error reporting we need to keep the lists and remove the
23233 lists for longer than required.
23235 This optimization was triggered by Paolo profiling the compiler
23236 speed on the output of `gen-sample-program.pl' perl script.
23238 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23239 not crash in methods like MemberLookupFailed that use this field.
23241 This problem arises when the compiler fails to resolve a type
23242 during interface type definition for example.
23244 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23246 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23247 inherit from System.Object, so we have to stop at null, not only
23248 when reaching System.Object.
23250 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23252 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23253 DeclaredOnly because the parent indexer might have had a different
23254 name, but did not loop until the top of the hierarchy was reached.
23256 The problem this one fixes is 35492: when a class implemented an
23257 indexer from an interface, we were getting the interface method
23258 (which was abstract) and we were flagging an error (can not invoke
23261 This also keeps bug 33089 functioning, and test-148 functioning.
23263 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23264 out if a method is special is to see if it is declared in a
23265 property or event, or whether it is one of the predefined operator
23266 names. This should fix correctly #36804.
23268 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23270 The goal here is to remove the dependency on EmptyCast.Peel ().
23271 Killing it completely.
23273 The problem is that currently in a number of places where
23274 constants are expected, we have to "probe" for an EmptyCast, and
23275 Peel, which is not the correct thing to do, as this will be
23276 repetitive and will likely lead to errors.
23278 The idea is to remove any EmptyCasts that are used in casts that
23279 can be reduced to constants, so we only have to cope with
23282 This bug hunt was triggered by Bug 37363 and the desire to remove
23283 the duplicate pattern where we were "peeling" emptycasts to check
23284 whether they were constants. Now constants will always be
23287 * ecore.cs: Use an enumconstant here instead of wrapping with
23290 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23291 throwing me off. By handling this we can get rid of a few hacks.
23293 * statement.cs (Switch): Removed Peel() code.
23295 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23297 * class.cs: Location information for error 508
23299 * expression.cs (New.DoResolve): Add a guard against double
23300 resolution of an expression.
23302 The New DoResolve might be called twice when initializing field
23303 expressions (see EmitFieldInitializers, the call to
23304 GetInitializerExpression will perform a resolve on the expression,
23305 and later the assign will trigger another resolution
23307 This leads to bugs (#37014)
23309 * delegate.cs: The signature for EndInvoke should contain any ref
23310 or out parameters as well. We were not doing this in the past.
23312 * class.cs (Field.Define): Do not overwrite the type definition
23313 inside the `volatile' group. Turns out that volatile enumerations
23314 were changing the type here to perform a validity test, which
23317 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23319 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23320 and structs, we do not want to load the instance variable
23322 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23323 enum_type has to be handled like an object reference (implicit
23324 conversions exists from this to object), but the regular IsClass
23325 and IsValueType tests will never return true for this one.
23327 Also we use TypeManager.IsValueType instead of type.IsValueType,
23328 just for consistency with the rest of the code (this is only
23329 needed if we ever use the construct exposed by test-180.cs inside
23330 corlib, which we dont today).
23332 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23334 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23337 2003-02-09 Martin Baulig <martin@ximian.com>
23339 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23340 (Namespace.DefineNamespaces): New static public method; this is
23341 called when we're compiling with debugging to add all namespaces
23342 to the symbol file.
23344 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23345 pass it to the Namespace's .ctor.
23347 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23348 and MethodBase arguments; pass the namespace ID to the symwriter;
23349 pass the MethodBase instead of the token to the symwriter.
23350 (SymbolWriter.DefineNamespace): New method to add a namespace to
23353 2003-02-09 Martin Baulig <martin@ximian.com>
23355 * symbolwriter.cs: New file. This is a wrapper around
23356 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23357 methods here in near future.
23359 2003-02-09 Martin Baulig <martin@ximian.com>
23361 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23362 ILGenerator.MarkSequencePoint() which are actually used by the
23365 2003-02-09 Martin Baulig <martin@ximian.com>
23367 * location.cs (SourceFile): New public sealed class. This
23368 contains the name and an index which is used in the location's token.
23369 (Location): Reserve an appropriate number of bits in the token for
23370 the source file instead of walking over that list, this gives us a
23371 really huge performance improvement when compiling with debugging.
23373 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23374 `SourceFile' argument instead of a string.
23375 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23376 but don't parse/tokenize here, we need to generate the list of all
23377 source files before we do that.
23378 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23381 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23382 instead of a string.
23384 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23387 2003-02-09 Martin Baulig <martin@ximian.com>
23389 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23390 filename on `#line default'.
23392 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23394 * statement.cs: don't clear the pinned var when the fixed statement
23395 returns from the method (fixes bug#37752).
23397 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23399 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23402 2003-02-07 Martin Baulig <martin@ximian.com>
23404 * driver.cs: Removed the `--debug-args' command line argument.
23406 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23407 automatically by the AsssemblyBuilder.
23408 (CodeGen.InitializeSymbolWriter): We don't need to call any
23409 initialization function on the symbol writer anymore. This method
23410 doesn't take any arguments.
23412 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23414 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23415 from referenced assemblies as well.
23417 2003-02-02 Martin Baulig <martin@ximian.com>
23419 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23421 2003-02-02 Martin Baulig <martin@ximian.com>
23423 * class.cs (Constructor.Emit): Open the symbol writer before
23424 emitting the constructor initializer.
23425 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23426 single-stepping through constructor initializers.
23428 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23430 * class.cs: Handle error 549: do not allow virtual methods in
23433 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23435 * decl.cs: Check access levels when resolving types
23437 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23439 * statement.cs: Add parameters and locals set in catch blocks that might
23440 return to set vector
23442 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23444 * class.cs (Operator): Set the SpecialName flags for operators.
23446 * expression.cs (Invocation.DoResolve): Only block calls to
23447 accessors and operators on SpecialName methods.
23449 (Cast.TryReduce): Handle conversions from char constants.
23452 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23454 * statement.cs: small memory and time optimization in FlowBranching.
23456 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23458 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23459 problem that the last fix but in the other sid (Set).
23461 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23462 access when there is no indexer in the hierarchy.
23464 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23466 * class.cs: Combine some if statements.
23468 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23470 * driver.cs: fixed bug #37187.
23472 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23474 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23475 any indexer, it's needed to build a list with all the indexers in the
23476 hierarchy (AllGetters), else we have problems. Fixes #35653.
23478 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23480 * class.cs (MethodData.Define): It is wrong for an interface
23481 implementation to be static in both cases: explicit and implicit.
23482 We were only handling this in one case.
23484 Improve the if situation there to not have negations.
23486 * class.cs (Field.Define): Turns out that we do not need to check
23487 the unsafe bit on field definition, only on usage. Remove the test.
23489 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23491 * driver.cs: use assembly.Location instead of Codebase (the latest
23492 patch made mcs fail when using MS assemblies).
23494 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23496 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23497 get the path to *corlib.dll.
23499 2003-01-21 Nick Drochak <ndrochak@gol.com>
23503 * typemanager.cs: Remove compiler warnings
23505 2003-01-20 Duncan Mak <duncan@ximian.com>
23507 * AssemblyInfo.cs: Bump the version number to 0.19.
23509 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23511 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23513 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23515 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23517 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23519 * cs-parser.jay: Small fix: we were not comparing the constructor
23520 name correctly. Thanks to Zoltan for the initial pointer.
23522 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23524 * cs-tokenizer.cs: Set file name when specified with #line
23526 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23528 * cs-parser.jay: Only perform the constructor checks here if we
23529 are named like the class; This will help provider a better
23530 error. The constructor path is taken when a type definition is
23531 not found, but most likely the user forgot to add the type, so
23532 report that rather than the constructor error.
23534 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23536 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23539 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23541 * cs-parser.jay: Add cleanup call.
23543 2003-01-13 Duncan Mak <duncan@ximian.com>
23545 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23546 consistent with other methods.
23548 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23550 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23552 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23554 * attribute.cs: only set GuidAttr to true when we have a
23557 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23561 * typemanager.cs: fixes to allow mcs compile corlib with the new
23562 Type.IsSubclassOf fix.
23564 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23566 * expression.cs (LocalVariableReference.DoResolve): Classify a
23567 constant as a value, not as a variable. Also, set the type for
23570 * cs-parser.jay (fixed_statement): take a type instead of a
23571 pointer_type, so we can produce a better error message later.
23573 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23576 (For.DoEmit): Make inifinite loops have a
23577 non-conditional branch back.
23579 (Fixed.DoEmit): First populate the pinned variables, then emit the
23580 statement, then clear the variables. Before I was emitting the
23581 code once for each fixed piece.
23584 2003-01-08 Martin Baulig <martin@ximian.com>
23586 * statement.cs (FlowBranching.MergeChild): A break in a
23587 SWITCH_SECTION does not leave a loop. Fixes #36155.
23589 2003-01-08 Martin Baulig <martin@ximian.com>
23591 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23592 lives in the same number space than `param_map'. Fixes #36154.
23594 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23596 * cs-parser.jay (constructor_declaration): Set the
23597 Constructor.ModFlags before probing for it. This makes the
23598 compiler report 514, 515 and 132 (the code was there, but got
23601 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23602 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23603 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23605 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23607 * enum.cs: create the enum static fields using the enum type.
23609 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23611 * class.cs: don't try to create the ParamBuilder for the return
23612 type if it's not needed (and handle it breaking for the ms runtime
23615 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23617 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23619 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23621 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23622 the command. This showed up while compiling the JANET source
23623 code, which used \r as its only newline separator.
23625 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23627 * class.cs (Method.Define): If we are an operator (because it
23628 reuses our code), then set the SpecialName and HideBySig. #36128
23630 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23632 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23633 exception, report error 120 `object reference required'.
23635 * driver.cs: Add --pause option, used during to measure the size
23636 of the process as it goes with --timestamp.
23638 * expression.cs (Invocation.DoResolve): Do not allow methods with
23639 SpecialName to be invoked.
23641 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23643 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23644 number before adding it.
23646 2002-12-21 Ravi Pratap <ravi@ximian.com>
23648 * ecore.cs (StandardImplicitConversion): When in an unsafe
23649 context, we allow conversion between void * to any other pointer
23650 type. This fixes bug #35973.
23652 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23654 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23655 is not thrown when extensionless outputs are used
23657 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23659 * rootcontext.cs: fixed compilation of corlib.
23661 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23663 * attribute.cs (Attributes.Contains): Add new method.
23665 * class.cs (MethodCore.LabelParameters): if the parameter is an
23666 `out' parameter, check that no attribute `[In]' has been passed.
23668 * enum.cs: Handle the `value__' name in an enumeration.
23670 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23672 * decl.cs: Added special case to allow overrides on "protected
23675 2002-12-18 Ravi Pratap <ravi@ximian.com>
23677 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23678 since it makes much more sense.
23680 (Attributes.ctor): Don't require a Location parameter.
23682 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23684 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23685 since we already have that information per attribute.
23687 * everywhere : make appropriate changes.
23689 * class.cs (LabelParameters): Write the code which actually
23690 applies attributes to the return type. We can't do this on the MS
23691 .NET runtime so we flag a warning in the case an exception is
23694 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23696 * const.cs: Handle implicit null conversions here too.
23698 2002-12-17 Ravi Pratap <ravi@ximian.com>
23700 * class.cs (MethodCore.LabelParameters): Remove the extra
23701 Type [] parameter since it is completely unnecessary. Instead
23702 pass in the method's attributes so that we can extract
23703 the "return" attribute.
23705 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23707 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23708 of ignoring it and letting the compile continue.
23710 * typemanager.cs (ChangeType): use an extra argument to return an
23711 error condition instead of throwing an exception.
23713 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23715 * expression.cs (Unary.TryReduce): mimic the code for the regular
23716 code path. Perform an implicit cast in the cases where we can
23717 implicitly convert to one of the integral types, and then reduce
23718 based on that constant. This fixes bug #35483.
23720 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23722 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23724 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23726 * namespace.cs: fixed bug #35489.
23728 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23730 * class.cs: Remove some dead code.
23732 * cs-parser.jay: Estimate the number of methods needed
23733 (RootContext.MethodCount);
23735 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23736 numbers instead of StringBuilders.
23738 * support.cs (PtrHashtable): Add constructor with initial size;
23739 We can now reduce reallocations of the method table.
23741 2002-12-10 Ravi Pratap <ravi@ximian.com>
23743 * attribute.cs (ApplyAttributes): Keep track of the emitted
23744 attributes on a per-target basis. This fixes bug #35413.
23746 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23748 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23749 default to the Windows 1252 encoding.
23751 (UnixParseOption): Support version, thanks to Alp for the missing
23754 * AssemblyInfo.cs: Add nice assembly information.
23756 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23759 * cs-parser.jay: Allow a trailing comma before the close bracked
23760 in the attribute_section production.
23762 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23763 address of the instance was being taken, I will take this out,
23764 because we take the address of the object immediately here.
23766 2002-12-09 Ravi Pratap <ravi@ximian.com>
23768 * typemanager.cs (AreMultipleAllowed): Take care of the most
23769 obvious case where attribute type is not in the current assembly -
23772 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23774 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23775 definitions, instead of doing that afterwards.
23777 Also we use a nice little hack, depending on the constructor, we
23778 know if we are a "composed" name or a simple name. Hence, we
23779 avoid the IndexOf test, and we avoid
23781 * codegen.cs: Add code to assist in a bug reporter to track down
23782 the source of a compiler crash.
23784 2002-12-07 Ravi Pratap <ravi@ximian.com>
23786 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23787 types have been emitted for a given element and flag an error
23788 if something which does not have AllowMultiple set is used more
23791 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23792 attribute types and their corresponding AllowMultiple properties
23794 (AreMultipleAllowed): Check the property for a given type.
23796 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23797 property in the case we have a TypeContainer.
23799 (Attributes.AddAttribute): Detect duplicates and just skip on
23800 adding them. This trivial fix catches a pretty gross error in our
23801 attribute emission - global attributes were being emitted twice!
23803 Bugzilla bug #33187 is now fixed.
23805 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23807 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23808 instead of pp_and).
23810 * expression.cs (Binary.ResolveOperator): I can only use the
23811 Concat (string, string, string) and Concat (string, string,
23812 string, string) if the child is actually a concatenation of
23815 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23817 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23818 context where we need a 2-character lookahead.
23820 * pending.cs (PendingImplementation): Rework so we can keep track
23821 of interface types all the time, and flag those which were
23822 implemented by parents as optional.
23824 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23826 * expression.cs (Binary.ResolveOperator): Use
23827 String.Concat(string,string,string) or
23828 String.Concat(string,string,string,string) when possible.
23830 * typemanager: More helper methods.
23833 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23835 * pending.cs: remove the bogus return from GetMissingInterfaces()
23836 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23838 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23840 * namespace.cs: avoid duplicated 'using xxx' being added to
23841 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23842 when we get more than one 'using' statement for the same namespace.
23843 Report a CS0105 warning for it.
23845 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23847 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23848 of calling getChar/putback, uses internal knowledge of it.
23850 (xtoken): Reorder tokenizer so most common patterns are checked
23851 first. This reduces the compilation time in another 5% (from 8.11s
23852 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23854 The parsing time is 22% of the compilation in mcs, and from that
23855 64% is spent on the tokenization process.
23857 I tried using a binary search for keywords, but this is slower
23858 than the hashtable. Another option would be to do a couple of
23861 * Not use a StringBuilder, instead use an array of chars,
23862 with a set value. Notice that this way we could catch
23863 the 645 error without having to do it *afterwards*.
23865 * We could write a hand-parser to avoid the hashtable
23866 compares altogether.
23868 The identifier consumption process takes 37% of the tokenization
23869 time. Another 15% is spent on is_number. 56% of the time spent
23870 on is_number is spent on Int64.Parse:
23872 * We could probably choose based on the string length to
23873 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23876 Another 3% is spend on wrapping `xtoken' in the `token' function.
23878 Handle 0xa0 as whitespace (#34752)
23880 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23882 * typemanager.cs (IsCLRType): New routine to tell whether a type
23883 is one of the builtin types.
23885 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23886 typecode in more places instead of doing pointer comparissions.
23887 We could leverage some knowledge about the way the typecodes are
23890 New code to cache namespaces in assemblies, it is currently not
23891 invoked, to be used soon.
23893 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23895 * expression.cs (Binary.ResolveOperator): specially handle
23896 strings, and do not perform user-defined operator overloading for
23899 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23901 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23902 internalcall as it is a pretty simple operation; Avoid whenever
23903 possible to call Char.IsLetter.
23905 (consume_identifier): Cut by half the number of
23906 hashtable calls by merging the is_keyword and GetKeyword behavior.
23908 Do not short-circuit, because if we do, we
23909 report errors (ie, #if false && true would produce an invalid
23913 2002-11-24 Martin Baulig <martin@ximian.com>
23915 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23916 check constant ranges and report a CS0221. Fixes #33186.
23918 2002-11-24 Martin Baulig <martin@ximian.com>
23920 * cs-parser.jay: Make this work for uninitialized variable
23921 declarations in the `for' initializer. Fixes #32416.
23923 2002-11-24 Martin Baulig <martin@ximian.com>
23925 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23926 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23928 2002-11-24 Martin Baulig <martin@ximian.com>
23930 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23931 argument; if true, we also check for user-defined conversions.
23932 This is only needed if both arguments are of a user-defined type.
23933 Fixes #30443, added test-175.cs.
23934 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23936 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23938 2002-11-24 Martin Baulig <martin@ximian.com>
23940 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23941 function to get the store opcode.
23942 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23943 only emit the Ldelema if the store opcode is Stobj. You must run
23944 both test-34 and test-167 to test this. Fixes #34529.
23946 2002-11-23 Martin Baulig <martin@ximian.com>
23948 * ecore.cs (Expression.MemberLookup): Added additional
23949 `qualifier_type' argument which is used when we're being called
23950 from MemberAccess.DoResolve() and null if we're called from a
23952 (Expression.MemberLookupFailed): New method to report errors; this
23953 does the CS1540 check and reports the correct error message.
23955 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23956 argument for the CS1540 check and redone the way how we're dealing
23957 with private members. See the comment in the source code for details.
23958 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23959 `closure_start_type' to `closure_qualifier_type' and check whether
23960 it's not null. It was not this filter being broken, it was just
23961 being called with the wrong arguments.
23963 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23964 and pass it the correct `qualifier_type'; this also does the error
23967 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23969 * expression.cs (Invocation.EmitParams): If the we are dealing
23970 with a non-built-in value type, load its address as well.
23972 (ArrayCreation): Use a a pretty constant instead
23973 of the hardcoded value 2. Use 6 instead of 2 for the number of
23974 static initializers.
23976 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23977 because they are not really value types, just glorified integers.
23979 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23981 * ecore.cs: Remove redundant code for enumerations, make them use
23982 the same code path as everything else, fixes the casting issue
23983 with enumerations in Windows.Forms.
23985 * attribute.cs: Do only cast to string if it is a string, the
23986 validation happens later.
23988 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23989 people upgrade their corlibs.
23991 * ecore.cs: Oops, enumerations were not following the entire code path
23993 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23995 * typemanager.cs (FilterWithClosure): Commented out the test for
23996 1540 in typemanager.cs, as it has problems when accessing
23997 protected methods from a parent class (see test-174.cs).
23999 * attribute.cs (Attribute.ValidateGuid): new method.
24000 (Attribute.Resolve): Use above.
24002 2002-11-19 Miguel de Icaza <miguel@ximian.com>
24004 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
24006 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
24007 handling for enumerations, as we only needed the TypeContainer
24008 functionality to begin with (this is required for the fix below to
24009 work for enums that reference constants in a container class for
24012 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
24014 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
24015 a valid TypeBuilder to perform lookups on.o
24017 * class.cs (InheritableMemberSignatureCompare): Use true in the
24018 call to GetGetMethod and GetSetMethod, because we are comparing
24019 the signature, and we need to get the methods *even* if they are
24022 (PropertyBase.CheckBase): ditto.
24024 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
24025 GotoCase.Resolve): Use Peel on EmpytCasts.
24027 * ecore.cs (EmptyCast): drop child, add Peel method.
24029 2002-11-17 Martin Baulig <martin@ximian.com>
24031 * ecore.cs (EmptyCast.Child): New public property.
24033 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
24034 label resolved to an EmptyCast. Fixes #34162.
24035 (GotoCase.Resolve): Likewise.
24036 (Block.EmitMeta): Likewise.
24038 2002-11-17 Martin Baulig <martin@ximian.com>
24040 * expression.cs (Invocation.BetterConversion): Prefer int over
24041 uint; short over ushort; long over ulong for integer literals.
24042 Use ImplicitConversionExists instead of StandardConversionExists
24043 since we also need to check for user-defined implicit conversions.
24044 Fixes #34165. Added test-173.cs.
24046 2002-11-16 Martin Baulig <martin@ximian.com>
24048 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
24049 with the `true' and `false' literals. Fixes #33151.
24051 2002-11-16 Martin Baulig <martin@ximian.com>
24053 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24054 October 22nd; don't do the cs1540 check for static members.
24056 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24057 now using our own filter here and doing the cs1540 check again.
24059 2002-11-16 Martin Baulig <martin@ximian.com>
24061 * support.cs (InternalParameters): Don't crash if we don't have
24062 any fixed parameters. Fixes #33532.
24064 2002-11-16 Martin Baulig <martin@ximian.com>
24066 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24067 when looking up static methods to make this work on Windows.
24070 2002-11-16 Martin Baulig <martin@ximian.com>
24072 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24073 a setter rather than using PropertyInfo.CanWrite.
24075 2002-11-15 Nick Drochak <ndrochak@gol.com>
24077 * class.cs: Allow acces to block member by subclasses. Fixes build
24080 2002-11-14 Martin Baulig <martin@ximian.com>
24082 * class.cs (Constructor.Emit): Added the extern/block check.
24085 2002-11-14 Martin Baulig <martin@ximian.com>
24087 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24088 iteration while looking for indexers, this is needed because the
24089 indexer may have a different name in our base classes. Fixed the
24090 error reporting (no indexers at all, not get accessor, no
24091 overloaded match). Fixes bug #33089.
24092 (IndexerAccess.DoResolveLValue): Likewise.
24094 2002-11-14 Martin Baulig <martin@ximian.com>
24096 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24097 indexers. Fixes the first part of bug #33089.
24098 (MethodSignature.InheritableMemberSignatureCompare): Added support
24101 2002-11-13 Ravi Pratap <ravi@ximian.com>
24103 * attribute.cs (Attribute.Resolve): Catch the
24104 NullReferenceException and report it since it isn't supposed to
24107 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24109 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24110 LogicalOr and LogicalAnd that can benefit from recursively
24111 handling EmitBranchable. The code now should be nice for Paolo.
24113 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24115 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24116 the Type lookups, as we perform quite a number of lookups on
24117 non-Types. This can be removed once we can deterministically tell
24118 whether we have a type or a namespace in advance.
24120 But this might require special hacks from our corlib.
24124 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24125 and double which avoids a conversion from an integer to a double.
24127 * expression.cs: tiny optimization, avoid calling IsConstant,
24128 because it effectively performs the lookup twice.
24130 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24132 But a bogus return here to keep the semantics of the old code
24133 until the Mono runtime is fixed.
24135 * pending.cs (GetMissingInterfaces): New method used to remove all
24136 the interfaces that are already implemented by our parent
24137 classes from the list of pending methods.
24139 * interface.cs: Add checks for calls after ResolveTypeExpr.
24141 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24143 * class.cs (Class.Emit): Report warning 67: event not used if the
24144 warning level is beyond 3.
24146 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24147 being a NullLiteral.
24149 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24152 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24153 path that might fail if a type can not be resolved.
24155 * expression.cs (Binary.Emit): Emit unsigned versions of the
24158 * driver.cs: use error 5.
24160 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24162 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24164 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24166 * cs-parser.jay (switch_section): A beautiful patch from Martin
24167 Baulig that fixed 33094.
24169 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24171 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24172 Check whether the base is abstract and report an error if so.
24174 * expression.cs (IndexerAccess.DoResolveLValue,
24175 IndexerAccess.DoResolve): ditto.
24177 (Invocation.DoResolve): ditto.
24179 (Invocation.FullMethodDesc): Improve the report string.
24181 * statement.cs (Block): Eliminate IsVariableDefined as it is
24182 basically just a wrapper for GetVariableInfo.
24184 * ecore.cs (SimpleName): Use new
24186 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24187 type, as we return the actual parameter ref/unref state on a
24190 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24192 * support.cs: Return proper flags REF/OUT fixing the previous
24195 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24196 not used to mean `ref' but `ref or out' in ParameterReference
24198 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24199 full type signature instead of calling TypeManger.CSharpName
24202 * support.cs (InternalParameters.ParameterDesc): Do not compare
24203 directly to the modflags, because REF/OUT will actually be bitsets
24206 * delegate.cs (VerifyMethod): Check also the modifiers.
24208 * cs-tokenizer.cs: Fix bug where floating point values with an
24209 exponent where a sign was missing was ignored.
24211 * driver.cs: Allow multiple assemblies to be specified in a single
24214 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24216 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24217 because identifiers after a parenthesis would end up in this kind
24218 of production, and we needed to desamiguate it for having casts
24221 (UserDefinedType *) xxx
24223 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24225 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24226 we should set on the Bindingflags.NonPublic, but not turn on
24227 private_ok. private_ok controls whether a Private member is
24228 returned (this is chekced on the filter routine), while the
24229 BindingFlags.NonPublic just controls whether private/protected
24230 will be allowed. This fixes the problem part of the problem of
24231 private properties being allowed to be used in derived classes.
24233 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24234 so we can call the children DoResolveLValue method (this will
24235 properly signal errors on lvalue assignments to base properties)
24237 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24238 getter are null, and we have a property info, we know that this
24239 happened because the lookup failed, so we report an error 122 for
24240 protection level violation.
24242 We also silently return if setter and getter are null in the
24243 resolve functions, this condition only happens if we have flagged
24244 the error before. This is the other half of the problem.
24246 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24247 not have accessibility information, that is why we were returning
24248 true in the filter function in typemanager.cs.
24250 To properly report 122 (property is inaccessible because of its
24251 protection level) correctly, we report this error in ResolveAccess
24252 by failing if both the setter and the getter are lacking (ie, the
24255 DoResolve and DoLResolve have been modified to check for both
24256 setter/getter being null and returning silently, the reason being
24257 that I did not want to put the knowledge about this error in upper
24260 int old = Report.Errors;
24261 x = new PropertyExpr (...);
24262 if (old != Report.Errors)
24267 So the property expr is returned, but it is invalid, so the error
24268 will be flagged during the resolve process.
24270 * class.cs: Remove InheritablePropertySignatureCompare from the
24271 class, as we no longer depend on the property signature to compute
24272 whether it is possible to implement a method or not.
24274 The reason is that calling PropertyInfo.GetGetMethod will return
24275 null (in .NET, in Mono it works, and we should change this), in
24276 cases where the Get Method does not exist in that particular
24281 class X { public virtual int A { get { return 1; } } }
24283 class Z : Y { public override int A { get { return 2; } } }
24285 Would fail in Z because the parent (Y) would not have the property
24286 defined. So we avoid this completely now (because the alternative
24287 fix was ugly and slow), and we now depend exclusively on the
24290 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24291 reference method, instead of using the property.
24293 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24294 routines are gone now.
24296 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24297 names, they were incorrectly named.
24299 * cs-tokenizer.cs: Return are more gentle token on failure.
24301 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24302 had an out-of-sync index variable, which caused it to remove from
24303 the list of pending methods the wrong method sometimes.
24305 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24307 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24308 CanWrite, because those refer to this particular instance of the
24309 property, and do not take into account the fact that we can
24310 override single members of a property.
24312 Constructor requires an EmitContext. The resolution process does
24313 not happen here, but we need to compute the accessors before,
24314 because the resolution does not always happen for properties.
24316 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24317 subclass, before we did not update this flag, but we did update
24320 (GetAccessors): Drop this routine, as it did not work in the
24321 presence of partially overwritten set/get methods.
24323 Notice that this broke the cs1540 detection, but that will require
24326 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24330 * driver.cs: issue a warning instead of an error if we don't support
24331 debugging for the platform. Also ignore a couple of errors that may
24332 arise when trying to write the symbols. Undo my previous patch.
24334 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24336 * driver.cs: ignore /debug switch except for Unix platforms.
24338 2002-10-23 Nick Drochak <ndrochak@gol.com>
24340 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24342 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24344 * driver.cs: Do not make mcs-debug conditional, so we do not break
24345 builds that use it.
24347 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24348 review this patch. But basically after all the children variables
24349 have been merged, the value of "Breaks" was not being set to
24350 new_breaks for Switch blocks. I think that it should be set after
24351 it has executed. Currently I set this to the value of new_breaks,
24352 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24353 conservative, but I do not understand this code very well.
24355 I did not break anything in the build, so that is good ;-)
24357 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24359 2002-10-20 Mark Crichton <crichton@gimp.org>
24361 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24363 2002-10-20 Nick Drochak <ndrochak@gol.com>
24365 * cfold.cs: Fixed compile blocker.
24367 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24369 * driver.cs: I was chekcing the key, not the file.
24371 2002-10-19 Ravi Pratap <ravi@ximian.com>
24373 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24374 message that we were generating - we just need to silently return
24377 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24379 * class.cs (Event.Define): Change my previous commit, as this
24380 breaks the debugger. This is a temporary hack, as it seems like
24381 the compiler is generating events incorrectly to begin with.
24383 * expression.cs (Binary.ResolveOperator): Added support for
24384 "U operator - (E x, E y)"
24386 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24389 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24390 init-only variables, but this path did not take into account that
24391 there might be also instance readonly variables. Correct this
24394 This fixes bug 32253
24396 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24399 * driver.cs: Change the extension for modules to `netmodule'
24401 * cs-parser.jay: Improved slightly the location tracking for
24402 the debugger symbols.
24404 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24405 modifiers that were specified instead of the hardcoded value
24406 (FamAndAssem). This was basically ignoring the static modifier,
24407 and others. Fixes 32429.
24409 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24410 fixed a bug in the process (32476)
24412 * expression.cs (ArrayAccess.EmitAssign): Patch from
24413 hwang_rob@yahoo.ca that fixes bug 31834.3
24415 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24417 * driver.cs: Make the module extension .netmodule.
24419 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24421 * driver.cs: Report an error if the resource file is not found
24422 instead of crashing.
24424 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24425 false, like Emit does.
24427 2002-10-16 Nick Drochak <ndrochak@gol.com>
24429 * typemanager.cs: Remove unused private member. Also reported mcs
24430 bug to report this as a warning like csc.
24432 2002-10-15 Martin Baulig <martin@gnome.org>
24434 * statement.cs (Statement.Emit): Made this a virtual method; emits
24435 the line number info and calls DoEmit().
24436 (Statement.DoEmit): New protected abstract method, formerly knows
24437 as Statement.Emit().
24439 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24441 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24443 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24444 have fixed a remaining problem: not every AddXXXX was adding a
24445 fully qualified name.
24447 Now everyone registers a fully qualified name in the DeclSpace as
24448 being defined instead of the partial name.
24450 Downsides: we are slower than we need to be due to the excess
24451 copies and the names being registered this way.
24453 The reason for this is that we currently depend (on the corlib
24454 bootstrap for instance) that types are fully qualified, because
24455 we dump all the types in the namespace, and we should really have
24456 types inserted into the proper namespace, so we can only store the
24457 basenames in the defined_names array.
24459 2002-10-10 Martin Baulig <martin@gnome.org>
24461 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24462 from bug #31834, see the bug report for a testcase which is
24465 2002-10-10 Martin Baulig <martin@gnome.org>
24467 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24468 flow analysis code for this.
24470 * statement.cs (Do, While, For): Tell the flow analysis code about
24472 (FlowBranching.UsageVector): Added support for infinite loops.
24473 (Block.Resolve): Moved the dead code elimination here and use flow
24476 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24478 * class.cs (Field.Define): Catch cycles on struct type
24481 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24482 fields if the fields are static. We only need to check instance
24485 * expression.cs (As.DoResolve): Test for reference type.
24487 * statement.cs (Using.ResolveExpression): Use
24488 ConvertImplicitRequired, not ConvertImplicit which reports an
24490 (Using.ResolveLocalVariableDecls): ditto.
24492 * expression.cs (Binary.ResolveOperator): Report errors in a few
24493 places where we had to.
24495 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24497 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24499 * expression.cs: Use StoreFromPtr instead of extracting the type
24500 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24502 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24503 an enumeration value to a System.Enum, but System.Enum is not a
24504 value type, but an class type, so we need to box.
24506 (Expression.ConvertExplicit): One codepath could return
24507 errors but not flag them. Fix this. Fixes #31853
24509 * parameter.cs (Resolve): Do not allow void as a parameter type.
24511 2002-10-06 Martin Baulig <martin@gnome.org>
24513 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24514 if it's a class type and not a struct. Fixes #31815.
24516 2002-10-06 Martin Baulig <martin@gnome.org>
24518 * statement.cs: Reworked the flow analysis code a bit to make it
24519 usable for dead code elimination.
24521 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24523 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24525 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24527 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24528 to fix the test 165, will investigate deeper.
24530 2002-10-04 Martin Baulig <martin@gnome.org>
24532 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24533 finally blocks actually work.
24534 (Try.Resolve): We don't need to create a sibling for `finally' if
24535 there is no finally block.
24537 2002-10-04 Martin Baulig <martin@gnome.org>
24539 * class.cs (Constructor.Define): The default accessibility for a
24540 non-default constructor is private, not public.
24542 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24544 * class.cs (Constructor): Make AllowedModifiers public, add
24547 * cs-parser.jay: Perform the modifiers test here, as the
24548 constructor for the Constructor class usually receives a zero
24549 because of the way we create it (first we create, later we
24550 customize, and we were never checking the modifiers).
24552 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24553 is a version of LookupTypeReflection that includes the type-name
24554 cache. This can be used as a fast path for functions that know
24555 the fully qualified name and are only calling into *.GetType() to
24556 obtain a composed type.
24558 This is also used by TypeManager.LookupType during its type
24561 (LookupType): We now also track the real type name, as sometimes
24562 we can get a quey for the real type name from things like
24563 ComposedCast. This fixes bug 31422.
24565 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24566 complete type fullname, it does not have to go through the type
24567 resolution system to obtain the composed version of the type (for
24568 obtaining arrays or pointers).
24570 (Conditional.Emit): Use the EmitBoolExpression to
24571 generate nicer code, as requested by Paolo.
24573 (ArrayCreation.CheckIndices): Use the patch from
24574 hwang_rob@yahoo.ca to validate the array initializers.
24576 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24578 * class.cs (ConstructorInitializer.Emit): simplify code by using
24579 Invocation.EmitCall, and at the same time, fix the bugs in calling
24580 parent constructors that took variable arguments.
24582 * ecore.cs (Expression.ConvertNumericExplicit,
24583 Expression.ImplicitNumericConversion): Remove the code that
24584 manually wrapped decimal (InternalTypeConstructor call is now gone
24587 * expression.cs (Cast.TryReduce): Also handle decimal types when
24588 trying to perform a constant fold on the type.
24590 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24592 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24593 that only turned off an error report, and did nothing else.
24595 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24597 * driver.cs: Handle and ignore /fullpaths
24599 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24601 * expression.cs (Binary.ResolveOperator): Catch the case where
24602 DoNumericPromotions returns true,
24604 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24606 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24608 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24611 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24613 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24614 conversion exists, but it is also required that the conversion be
24615 performed. This manifested in "(Type64Enum) 2".
24617 * class.cs (TypeManager.AddMethod): The fix is not to change
24618 AddEnum, because that one was using a fully qualified name (every
24619 DeclSpace derivative does), but to change the AddMethod routine
24620 that was using an un-namespaced name. This now correctly reports
24621 the duplicated name.
24623 Revert patch until I can properly fix it. The issue
24624 is that we have a shared Type space across all namespaces
24625 currently, which is wrong.
24627 Options include making the Namespace a DeclSpace, and merge
24628 current_namespace/current_container in the parser.
24630 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24632 * cs-parser.jay: Improve error reporting when we get a different
24633 kind of expression in local_variable_type and
24634 local_variable_pointer_type.
24636 Propagate this to avoid missleading errors being reported.
24638 * ecore.cs (ImplicitReferenceConversion): treat
24639 TypeManager.value_type as a target just like object_type. As
24644 Is valid, and needs to result in the int 1 being boxed before it
24645 is assigned to the value type v.
24647 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24648 to validate the enumeration name.
24650 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24651 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24652 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24654 * ecore.cs (TryImplicitIntConversion): When doing an
24655 implicit-enumeration-conversion, check if the type is 64-bits and
24656 perform a conversion before passing to EnumConstant.
24658 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24660 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24661 report ambiguous type references. Unlike the MS version, we
24662 report what the ambiguity is. Innovation at work ;-)
24664 (DeclSpace.FindType): Require a location argument to
24665 display when we display an ambiguous error.
24667 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24669 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24671 * expression.cs (EmitDynamicInitializers): Apply patch from
24672 hwang_rob@yahoo.ca that fixes the order in which we emit our
24675 2002-09-21 Martin Baulig <martin@gnome.org>
24677 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24678 delegate takes no arguments.
24680 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24682 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24685 * expression.cs: Extract the underlying type.
24687 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24689 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24691 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24693 * class.cs (TypeContainer.DefineType): We can not use the nice
24694 PackingSize with the size set to 1 DefineType method, because it
24695 will not allow us to define the interfaces that the struct
24698 This completes the fixing of bug 27287
24700 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24701 means also structs. This fixes part of the problem.
24702 (Expresion.ImplicitReferenceConversionExists): ditto.
24704 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24705 error if there were no errors reported during the type lookup
24706 process, to avoid duplicates or redundant errors. Without this
24707 you would get an ambiguous errors plus a type not found. We have
24708 beaten the user enough with the first error.
24710 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24713 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24714 during the resolution process, stop the lookup, this avoids
24715 repeated error reports (same error twice).
24717 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24719 * typemanager.cs (LookupType): Redo the type lookup code to match
24720 the needs of System.Reflection.
24722 The issue is that System.Reflection requires references to nested
24723 types to begin with a "+" sign instead of a dot. So toplevel
24724 types look like: "NameSpace.TopLevelClass", and nested ones look
24725 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24728 2002-09-19 Martin Baulig <martin@gnome.org>
24730 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24731 says that a method always returns or always throws an exception,
24732 don't report the CS0161.
24734 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24735 set `Returns = new_returns'.
24737 2002-09-19 Martin Baulig <martin@gnome.org>
24739 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24740 to an enum constant, check for a CS0176.
24742 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24744 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24745 for operators that must be in pairs and report errors.
24747 * ecore.cs (SimpleName.DoResolveType): During the initial type
24748 resolution process, when we define types recursively, we must
24749 check first for types in our current scope before we perform
24750 lookups in the enclosing scopes.
24752 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24754 (Invocation.VerifyArgumentsCompat): Call
24755 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24756 I thought we were supposed to always call this, but there are a
24757 few places in the code where we dont do it.
24759 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24761 * driver.cs: Add support in -linkres and -resource to specify the
24762 name of the identifier.
24764 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24766 * ecore.cs (StandardConversionExists): Sync with the conversion
24767 code: allow anything-* to void* conversions.
24769 (FindMostSpecificSource): Use an Expression argument
24770 instead of a Type, because we might be handed over a Literal which
24771 gets a few more implicit conversions that plain types do not. So
24772 this information was being lost.
24774 Also, we drop the temporary type-holder expression when not
24777 2002-09-17 Martin Baulig <martin@gnome.org>
24779 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24780 this is an explicit interface implementation.
24782 2002-09-17 Martin Baulig <martin@gnome.org>
24784 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24785 different `IndexerName' attributes.
24787 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24788 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24789 virtual CommonResolve().
24791 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24793 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24794 and convert that to the UnderlyingType.
24796 * statement.cs (Foreach.Resolve): Indexers are just like variables
24797 or PropertyAccesses.
24799 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24800 inside quoted strings, we were not doing this before.
24802 2002-09-16 Martin Baulig <martin@gnome.org>
24804 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24805 resolve it. This is needed for the definite assignment check of the
24806 instance expression, fixes bug #29846.
24807 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24809 2002-09-16 Nick Drochak <ndrochak@gol.com>
24811 * parameter.cs: Fix compile error. Cannot reference static member
24812 from an instance object. Is this an mcs bug?
24814 2002-09-14 Martin Baulig <martin@gnome.org>
24816 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24817 multiple times. Fixes bug #30295, added test-166.cs.
24819 2002-09-14 Martin Baulig <martin@gnome.org>
24821 * statement.cs (Block.Emit): Don't emit unreachable code.
24822 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24823 `break' statements.
24824 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24826 2002-09-14 Martin Baulig <martin@gnome.org>
24828 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24831 2002-09-14 Martin Baulig <martin@gnome.org>
24833 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24834 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24835 be false on the ms runtime.
24837 2002-09-13 Martin Baulig <martin@gnome.org>
24839 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24840 the CS0038 error message.
24842 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24844 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24845 constant inside, return it.
24847 2002-09-12 Martin Baulig <martin@gnome.org>
24849 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24850 implicit conversion can be done between enum types.
24852 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24853 check whether an implicit conversion to the current enum's UnderlyingType
24854 exists and report an error if not.
24856 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24857 without debugging support.
24859 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24860 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24862 2002-09-12 Martin Baulig <martin@gnome.org>
24864 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24866 * ecore.cs (IMemberExpr.DeclaringType): New property.
24867 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24868 nonstatic member of an outer type (CS0038).
24870 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24872 * driver.cs: Activate the using-error detector at warning level
24873 4 (at least for MS-compatible APIs).
24875 * namespace.cs (VerifyUsing): Small buglett fix.
24877 * pending.cs (PendingImplementation): pass the container pointer.
24879 * interface.cs (GetMethods): Allow for recursive definition. Long
24880 term, I would like to move every type to support recursive
24881 definitions, not the current ordering mechanism that we have right
24884 The situation is this: Attributes are handled before interfaces,
24885 so we can apply attributes to interfaces. But some attributes
24886 implement interfaces, we will now handle the simple cases
24887 (recursive definitions will just get an error).
24889 * parameter.cs: Only invalidate types at the end if we fail to
24892 2002-09-09 Martin Baulig <martin@gnome.org>
24894 * ecore.cs (PropertyExpr.Emit): Also check for
24895 TypeManager.system_int_array_get_length so this'll also work when
24896 compiling corlib. Fixes #30003.
24898 2002-09-09 Martin Baulig <martin@gnome.org>
24900 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24901 and throw an exception if we can't get the type's size. Fixed #30040,
24904 2002-09-09 Martin Baulig <martin@gnome.org>
24906 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24908 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24909 context. Fixes bug #30027.
24911 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24912 virtual functions. Fixes bug #30043, added test-164.cs.
24914 2002-09-08 Ravi Pratap <ravi@ximian.com>
24916 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24918 2002-09-08 Nick Drochak <ndrochak@gol.com>
24920 * driver.cs: Use an object to get the windows codepage since it's not a
24923 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24925 * statement.cs (For.Emit): for infinite loops (test == null)
24926 return whether there is a break inside, not always "true".
24928 * namespace.cs (UsingEntry): New struct to hold the name of the
24929 using definition, the location where it is defined, and whether it
24930 has been used in a successful type lookup.
24932 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24937 2002-09-06 Ravi Pratap <ravi@ximian.com>
24939 * attribute.cs : Fix incorrect code which relied on catching
24940 a NullReferenceException to detect a null being passed in
24941 where an object was expected.
24943 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24945 * statement.cs (Try): flag the catch variable as assigned
24947 * expression.cs (Cast): Simplified by using ResolveType instead of
24948 manually resolving.
24950 * statement.cs (Catch): Fix bug by using ResolveType.
24952 2002-09-06 Ravi Pratap <ravi@ximian.com>
24954 * expression.cs (BetterConversion): Special case for when we have
24955 a NullLiteral as the argument and we have to choose between string
24956 and object types - we choose string the way csc does.
24958 * attribute.cs (Attribute.Resolve): Catch the
24959 NullReferenceException and report error #182 since the Mono
24960 runtime no more has the bug and having this exception raised means
24961 we tried to select a constructor which takes an object and is
24964 2002-09-05 Ravi Pratap <ravi@ximian.com>
24966 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24967 message (1502, 1503) when we can't locate a method after overload
24968 resolution. This is much more informative and closes the bug
24971 * interface.cs (PopulateMethod): Return if there are no argument
24972 types. Fixes a NullReferenceException bug.
24974 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24975 expressions too. Previously we were checking only in one place for
24976 positional arguments leaving out named arguments.
24978 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24979 type to the enum type is not allowed. Remove code corresponding to
24982 (ConvertNumericExplicit): Allow explicit conversions from
24983 the underlying type to enum type. This precisely follows the spec
24984 and closes a bug filed by Gonzalo.
24986 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24989 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24991 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24993 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24994 it was important that we stored the right value after the
24995 reduction in `converted'.
24997 2002-09-04 Martin Baulig <martin@gnome.org>
24999 * location.cs (Location.SymbolDocument): Use full pathnames for the
25002 2002-08-30 Miguel de Icaza <miguel@ximian.com>
25004 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
25005 of the expression resolve mechanism, because that will catch the
25006 SimpleName error failures.
25008 (Conditional): If we can not resolve the
25009 expression, return, do not crash.
25011 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25014 (location): display token name instead of its number.
25016 2002-08-28 Martin Baulig <martin@gnome.org>
25018 * expression.cs (Binary.ResolveOperator): Don't silently return
25019 but return an error if an operator cannot be applied between two
25022 2002-08-28 Martin Baulig <martin@gnome.org>
25024 * class.cs (Constructor.Define): Set the permission attributes
25025 correctly instead of making all constructors public.
25027 2002-08-28 Martin Baulig <martin@gnome.org>
25029 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
25030 for private members before reporting a CS0103; if we find anything,
25033 2002-08-28 Martin Baulig <martin@gnome.org>
25035 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
25036 to check whether `closure_start_type == closure_invocation_type',
25037 we also need to check whether `m.DeclaringType == closure_invocation_type'
25038 before bypassing the permission checks. We might be accessing
25039 protected/private members from the base class.
25040 (TypeManager.RealMemberLookup): Only set private_ok if private
25041 members were requested via BindingFlags.NonPublic.
25043 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
25045 * expression.cs (MemberAccess.ResolveMemberAccess): Set
25046 MethodGroupExpr.IsExplicitImpl if appropriate.
25047 (Invocation.DoResolve): Don't report the CS0120 for explicit
25048 interface implementations.
25050 2002-08-27 Martin Baulig <martin@gnome.org>
25052 * expression.cs (Invocation.DoResolve): If this is a static
25053 method and we don't have an InstanceExpression, we must report
25056 2002-08-25 Martin Baulig <martin@gnome.org>
25058 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25059 `==' between a valuetype and an object.
25061 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25063 * ecore.cs (TypeExpr): Provide a ToString method.
25065 2002-08-24 Martin Baulig <martin@gnome.org>
25067 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25068 now called proggie.dbg and it's a binary file.
25070 2002-08-23 Martin Baulig <martin@gnome.org>
25072 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25074 2002-08-23 Martin Baulig <martin@gnome.org>
25076 * struct.cs (MyStructInfo.ctor): Make this work with empty
25077 structs; it's not allowed to use foreach() on null.
25079 2002-08-23 Martin Baulig <martin@gnome.org>
25081 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25082 writer the full pathname of the generated assembly.
25084 2002-08-23 Martin Baulig <martin@gnome.org>
25086 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25087 A `finally' block never returns or breaks; improved handling of
25090 2002-08-23 Martin Baulig <martin@gnome.org>
25092 * statement.cs (Throw.Resolve): Allow `throw null'.
25094 2002-08-23 Martin Baulig <martin@gnome.org>
25096 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25097 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25098 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25099 MemberLookup would return a wrong event if this is an explicit
25100 interface implementation and the class has an event with the same
25103 2002-08-23 Martin Baulig <martin@gnome.org>
25105 * statement.cs (Block.AddChildVariableNames): New public method.
25106 (Block.AddChildVariableName): Likewise.
25107 (Block.IsVariableNameUsedInChildBlock): Likewise.
25108 (Block.AddVariable): Check whether a variable name has already
25109 been used in a child block.
25111 * cs-parser.jay (declare_local_variables): Mark all variable names
25112 from the current block as being used in a child block in the
25115 2002-08-23 Martin Baulig <martin@gnome.org>
25117 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25118 find the symbol writer.
25120 * driver.cs: csc also allows the arguments to /define being
25121 separated by commas, not only by semicolons.
25123 2002-08-23 Martin Baulig <martin@gnome.org>
25125 * interface.cs (Interface.GetMembers): Added static check for events.
25127 2002-08-15 Martin Baulig <martin@gnome.org>
25129 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25130 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25132 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25133 why the MethodData.EmitDestructor() change was necessary.
25135 2002-08-20 Martin Baulig <martin@gnome.org>
25137 * class.cs (TypeContainer.FindMembers): Added static check for events.
25139 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25141 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25142 use Type.GetEvents(), not Type.FindMembers().
25144 2002-08-20 Martin Baulig <martin@gnome.org>
25146 * decl.cs (MemberCache): Added a special method cache which will
25147 be used for method-only searched. This ensures that a method
25148 search will return a MethodInfo with the correct ReflectedType for
25151 2002-08-20 Martin Baulig <martin@gnome.org>
25153 * decl.cs (DeclSpace.FindMembers): Made this public.
25155 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25157 * delegate.cs: fixed build on windows.
25158 [FIXME: Filed as bug #29150: MCS must report these errors.]
25160 2002-08-19 Ravi Pratap <ravi@ximian.com>
25162 * ecore.cs (StandardConversionExists): Return a false
25163 if we are trying to convert the void type to anything else
25164 since that is not allowed.
25166 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25167 we flag error 70 in the event an event is trying to be accessed
25168 directly from outside the declaring type.
25170 2002-08-20 Martin Baulig <martin@gnome.org>
25172 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25173 MemberCache from typemanager.cs to decl.cs.
25175 2002-08-19 Martin Baulig <martin@gnome.org>
25177 * class.cs (TypeContainer): Implement IMemberContainer.
25178 (TypeContainer.DefineMembers): Create the MemberCache.
25179 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25180 return public members if BindingFlags.Public was given, check
25181 whether members are static.
25183 2002-08-16 Martin Baulig <martin@gnome.org>
25185 * decl.cs (DeclSpace.Define): Splitted this in Define and
25186 DefineMembers. DefineMembers is called first and initializes the
25189 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25190 DefineMembers() on all our DeclSpaces.
25192 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25193 but call DefineMembers() on all nested interfaces. We call their
25194 Define() in our new Define() function.
25196 * interface.cs (Interface): Implement IMemberContainer.
25197 (Interface.Define): Moved all code except the attribute stuf to
25199 (Interface.DefineMembers): Initialize the member cache.
25201 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25202 need this anymore since we can use MemberCache.FindMembers directly.
25204 2002-08-19 Martin Baulig <martin@gnome.org>
25206 * typemanager.cs (MemberCache): When creating the cache for an
25207 interface type, add all inherited members.
25208 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25209 to `out bool used_cache' and documented it.
25210 (TypeManager.MemberLookup): If we already used the cache in the first
25211 iteration, we don't need to do the interfaces check.
25213 2002-08-19 Martin Baulig <martin@gnome.org>
25215 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25216 here from IMemberFinder and don't implement this interface anymore.
25217 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25219 * typemanager.cs (IMemberFinder): This interface is now only used by
25220 classes which actually support the member cache.
25221 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25222 since we only put DeclSpaces into this Hashtable.
25223 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25224 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25226 2002-08-16 Martin Baulig <martin@gnome.org>
25228 * typemanager.cs (ICachingMemberFinder): Removed.
25229 (IMemberFinder.MemberCache): New property.
25230 (TypeManager.FindMembers): Merged this with RealFindMembers().
25231 This function will never be called from TypeManager.MemberLookup()
25232 so we can't use the cache here, just the IMemberFinder.
25233 (TypeManager.MemberLookup_FindMembers): Check whether the
25234 IMemberFinder has a MemberCache and call the cache's FindMembers
25236 (MemberCache): Rewrote larger parts of this yet another time and
25237 cleaned it up a bit.
25239 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25241 * driver.cs (LoadArgs): Support quoting.
25243 (Usage): Show the CSC-like command line arguments.
25245 Improved a few error messages.
25247 2002-08-15 Martin Baulig <martin@gnome.org>
25249 * typemanager.cs (IMemberContainer.Type): New property.
25250 (IMemberContainer.IsInterface): New property.
25252 The following changes are conditional to BROKEN_RUNTIME, which is
25253 defined at the top of the file.
25255 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25256 class'es members, but add all members from TypeHandle.ObjectType
25257 if we're an interface.
25258 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25259 is the current type.
25260 (MemberCache.CacheEntry.Container): Removed this field.
25261 (TypeHandle.GetMembers): Include inherited members.
25263 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25265 * typemanager.cs: fixed compilation and added a comment on a field that
25268 2002-08-15 Martin Baulig <martin@gnome.org>
25270 * class.cs (ConstructorInitializer.Resolve): In the
25271 Expression.MemberLookup call, use the queried_type as
25274 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25275 declared' attribute, it's always true.
25276 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25277 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25278 temporary wrapper for FindMembers which tells MemberLookup whether
25279 members from the base classes are included in the return value.
25280 This will go away soon.
25281 (TypeManager.MemberLookup): Use this temporary hack here; once the
25282 new MemberCache is completed, we don't need to do the DeclaredOnly
25283 looping here anymore since the MemberCache will take care of this.
25284 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25285 (MemberCache): When creating the MemberCache for a class, get
25286 members from the current class and all its base classes.
25287 (MemberCache.CacheEntry.Container): New field. This is a
25288 temporary hack until the Mono runtime is fixed to distinguish
25289 between ReflectedType and DeclaringType. It allows us to use MCS
25290 with both the MS runtime and the unfixed Mono runtime without
25291 problems and without accecting performance.
25292 (MemberCache.SearchMembers): The DeclaredOnly looping from
25293 TypeManager.MemberLookup is now done here.
25295 2002-08-14 Martin Baulig <martin@gnome.org>
25297 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25298 Type.GetFields on dynamic types but get the fields from the
25299 corresponding TypeContainer.
25300 (MyStructInfo.GetStructInfo): Added check for enum types.
25302 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25303 (MemberList.SyncRoot): Implemented.
25304 (TypeManager.FilterWithClosure): No need to check permissions if
25305 closure_start_type == closure_invocation_type, don't crash if
25306 closure_invocation_type is null.
25308 2002-08-13 Martin Baulig <martin@gnome.org>
25310 Rewrote TypeContainer.FindMembers to use a member cache. This
25311 gives us a speed increase of about 35% for the self-hosting MCS
25312 build and of about 15-20% for the class libs (both on GNU/Linux).
25314 * report.cs (Timer): New class to get enhanced profiling. This
25315 whole class is "TIMER" conditional since it remarkably slows down
25318 * class.cs (MemberList): New class. This is an IList wrapper
25319 which we're now using instead of passing MemberInfo[]'s around to
25320 avoid copying this array unnecessarily.
25321 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25322 (ICachingMemberFinder, IMemberContainer): New interface.
25323 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25324 has already been checked, otherwise use it for the name comparision.
25325 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25326 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25327 if possible. Returns a MemberList, not a MemberInfo [].
25328 (TypeHandle): New class, implements IMemberContainer. We create
25329 one instance of this class per type, it contains a MemberCache
25330 which is used to do the member lookups.
25331 (MemberCache): New class. Each instance of this class contains
25332 all members of a type and a name-based hash table.
25333 (MemberCache.FindMembers): This is our new member lookup
25334 function. First, it looks up all members of the requested name in
25335 the hash table. Then, it walks this list and sorts out all
25336 applicable members and returns them.
25338 2002-08-13 Martin Baulig <martin@gnome.org>
25340 In addition to a nice code cleanup, this gives us a performance
25341 increase of about 1.4% on GNU/Linux - not much, but it's already
25342 half a second for the self-hosting MCS compilation.
25344 * typemanager.cs (IMemberFinder): New interface. It is used by
25345 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25346 Enum, Delegate or Interface.
25347 (TypeManager.finder_to_member_finder): New PtrHashtable.
25348 (TypeManager.finder_to_container): Removed.
25349 (TypeManager.finder_to_delegate): Removed.
25350 (TypeManager.finder_to_interface): Removed.
25351 (TypeManager.finder_to_enum): Removed.
25353 * interface.cs (Interface): Implement IMemberFinder.
25355 * delegate.cs (Delegate): Implement IMemberFinder.
25357 * enum.cs (Enum): Implement IMemberFinder.
25359 * class.cs (TypeContainer): Implement IMemberFinder.
25361 2002-08-12 Martin Baulig <martin@gnome.org>
25363 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25365 2002-08-12 Martin Baulig <martin@gnome.org>
25367 * ecore.cs (ITypeExpression): New interface for expressions which
25369 (TypeExpression): Renamed to TypeLookupExpression.
25370 (Expression.DoResolve): If we're doing a types-only lookup, the
25371 expression must implement the ITypeExpression interface and we
25372 call DoResolveType() on it.
25373 (SimpleName): Implement the new ITypeExpression interface.
25374 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25375 hack, the situation that we're only looking up types can't happen
25376 anymore when this method is called. Moved the type lookup code to
25377 DoResolveType() and call it.
25378 (SimpleName.DoResolveType): This ITypeExpression interface method
25379 is now doing the types-only lookup.
25380 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25381 (ResolveFlags): Added MaskExprClass.
25383 * expression.cs (MemberAccess): Implement the ITypeExpression
25385 (MemberAccess.DoResolve): Added support for a types-only lookup
25386 when we're called via ITypeExpression.DoResolveType().
25387 (ComposedCast): Implement the ITypeExpression interface.
25389 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25390 Expression.Resolve() with ResolveFlags.Type instead.
25392 2002-08-12 Martin Baulig <martin@gnome.org>
25394 * interface.cs (Interface.Define): Apply attributes.
25396 * attribute.cs (Attribute.ApplyAttributes): Added support for
25397 interface attributes.
25399 2002-08-11 Martin Baulig <martin@gnome.org>
25401 * statement.cs (Block.Emit): Only check the "this" variable if we
25402 do not always throw an exception.
25404 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25405 whether the property has a set accessor.
25407 2002-08-11 Martin Baulig <martin@gnome.org>
25409 Added control flow analysis support for structs.
25411 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25412 with control flow analysis turned off.
25413 (IVariable): New interface.
25414 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25415 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25416 (FieldExpr.DoResolve): Resolve the instance expression with flow
25417 analysis turned off and do the definite assignment check after the
25418 resolving when we know what the expression will resolve to.
25420 * expression.cs (LocalVariableReference, ParameterReference):
25421 Implement the new IVariable interface, only call the flow analysis
25422 code if ec.DoFlowAnalysis is true.
25423 (This): Added constructor which takes a Block argument. Implement
25424 the new IVariable interface.
25425 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25426 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25427 This does the definite assignment checks for struct members.
25429 * class.cs (Constructor.Emit): If this is a non-static `struct'
25430 constructor which doesn't have any initializer, call
25431 Block.AddThisVariable() to tell the flow analysis code that all
25432 struct elements must be initialized before control returns from
25435 * statement.cs (MyStructInfo): New public class.
25436 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25437 argument to this indexer. If non-zero, check an individual struct
25438 member, not the whole struct.
25439 (FlowBranching.CheckOutParameters): Check struct members.
25440 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25441 overloaded versions of these methods which take an additional
25442 `int field_idx' argument to check struct members.
25443 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25444 overloaded versions of these methods which take an additional
25445 `string field_name' argument to check struct member.s
25446 (VariableInfo): Implement the IVariable interface.
25447 (VariableInfo.StructInfo): New public property. Returns the
25448 MyStructInfo instance of the variable if it's a struct or null.
25449 (Block.AddThisVariable): New public method. This is called from
25450 Constructor.Emit() for non-static `struct' constructor which do
25451 not have any initializer. It creates a special variable for the
25452 "this" instance variable which will be checked by the flow
25453 analysis code to ensure that all of the struct's fields are
25454 initialized before control returns from the constructor.
25455 (UsageVector): Added support for struct members. If a
25456 variable/parameter is a struct with N members, we reserve a slot
25457 in the usage vector for each member. A struct is considered fully
25458 initialized if either the struct itself (slot 0) or all its
25459 members are initialized.
25461 2002-08-08 Martin Baulig <martin@gnome.org>
25463 * driver.cs (Driver.MainDriver): Only report an error CS5001
25464 if there were no compilation errors.
25466 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25467 `UnsafeContext' property to determine whether the parent is in
25468 unsafe context rather than checking the parent's ModFlags:
25469 classes nested in an unsafe class are unsafe as well.
25471 2002-08-08 Martin Baulig <martin@gnome.org>
25473 * statement.cs (UsageVector.MergeChildren): Distinguish between
25474 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25475 we return. Added test17() and test18() to test-154.cs.
25477 2002-08-08 Martin Baulig <martin@gnome.org>
25479 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25480 Family access, make sure the invoking type isn't a subclass of the
25481 queried type (that'd be a CS1540).
25483 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25484 this method which takes an additional `Type invocation_type'.
25486 * expression.cs (BaseAccess.DoResolve): Use the base type as
25487 invocation and query type.
25488 (MemberAccess.DoResolve): If the lookup failed and we're about to
25489 report a CS0122, try a lookup with the ec.ContainerType - if this
25490 succeeds, we must report a CS1540.
25492 2002-08-08 Martin Baulig <martin@gnome.org>
25494 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25495 (MethodGroupExpr): Implement the IMemberExpr interface.
25497 * expression (MemberAccess.ResolveMemberAccess): No need to have
25498 any special code for MethodGroupExprs anymore, they're now
25501 2002-08-08 Martin Baulig <martin@gnome.org>
25503 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25504 Family, FamANDAssem and FamORAssem permissions.
25505 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25507 2002-08-08 Martin Baulig <martin@gnome.org>
25509 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25510 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25513 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25515 * driver.cs: implemented /resource option to embed managed resources.
25517 2002-08-07 Martin Baulig <martin@gnome.org>
25519 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25520 (FieldBase.HasFieldInitializer): New public property.
25521 (FieldBase.GetInitializerExpression): New public method. Resolves and
25522 returns the field initializer and makes sure it is only resolved once.
25523 (TypeContainer.EmitFieldInitializers): Call
25524 FieldBase.GetInitializerExpression to get the initializer, this ensures
25525 that it isn't resolved multiple times.
25527 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25528 the resolving process (SimpleName/MemberLookup) that we're currently
25529 emitting a field initializer (which must not access any instance members,
25530 this is an error CS0236).
25532 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25533 argument, if the `IsFieldInitializer' flag is set, we must report and
25534 error CS0236 and not an error CS0120.
25536 2002-08-07 Martin Baulig <martin@gnome.org>
25538 * ecore.cs (IMemberExpr): New public interface.
25539 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25540 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25541 if the expression is an IMemberExpr.
25543 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25544 to be null, implicitly default to `this' if we're non-static in
25545 this case. Simplified the code a lot by using the new IMemberExpr
25546 interface. Also fixed bug #28176 here.
25548 2002-08-06 Martin Baulig <martin@gnome.org>
25550 * cs-parser.jay (SimpleLookup): Removed. We need to create
25551 ParameterReferences during semantic analysis so that we can do a
25552 type-only search when resolving Cast, TypeOf and SizeOf.
25553 (block): Pass the `current_local_parameters' to the Block's
25556 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25557 argument to the constructor.
25558 (ConstructorInitializer.Resolve): Create a temporary implicit
25559 block with the parameters.
25561 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25562 references here if we aren't doing a type-only search.
25564 * statement.cs (Block): Added constructor which takes a
25565 `Parameters parameters' argument.
25566 (Block.Parameters): New public property.
25568 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25569 to `Parameters' and made it public readonly.
25571 2002-08-06 Martin Baulig <martin@gnome.org>
25573 * ecore.cs (Expression.Warning): Made this public as well.
25575 * report.cs (Report.Debug): Print the contents of collections.
25577 2002-08-06 Martin Baulig <martin@gnome.org>
25579 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25580 used to tell Resolve() which kinds of expressions it may return.
25581 (Expression.Resolve): Added overloaded version of this method which
25582 takes a `ResolveFlags flags' argument. This can be used to tell
25583 Resolve() which kinds of expressions it may return. Reports a
25585 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25586 ResolveFlags.SimpleName.
25587 (Expression.Error118): Added overloaded version of this method which
25588 takes a `ResolveFlags flags' argument. It uses the flags to determine
25589 which kinds of expressions are allowed.
25591 * expression.cs (Argument.ResolveMethodGroup): New public method.
25592 Resolves an argument, but allows a MethodGroup to be returned.
25593 This is used when invoking a delegate.
25595 * TODO: Updated a bit.
25597 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25599 Fixed compilation with csc.
25601 * ecore.cs: Expression.Error made public. Is this correct? Should
25602 Warning be made public too?
25604 * expression.cs: use ea.Location instead of ea.loc.
25605 [FIXME: Filed as bug #28607: MCS must report these errors.]
25607 2002-08-06 Martin Baulig <martin@gnome.org>
25609 * ecore.cs (Expression.loc): Moved the location here instead of
25610 duplicating it in all derived classes.
25611 (Expression.Location): New public property.
25612 (Expression.Error, Expression.Warning): Made them non-static and
25613 removed the location argument.
25614 (Expression.Warning): Added overloaded version which takes an
25615 `int level' argument.
25616 (Expression.Error118): Make this non-static and removed the
25617 expression and location arguments.
25618 (TypeExpr): Added location argument to the constructor.
25620 * expression.cs (StaticCallExpr): Added location argument to
25622 (Indirection, PointerArithmetic): Likewise.
25623 (CheckedExpr, UnCheckedExpr): Likewise.
25624 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25625 (StringPtr): Likewise.
25628 2002-08-05 Martin Baulig <martin@gnome.org>
25630 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25632 * assign.cs (Assign.DoResolve): Check whether the source
25633 expression is a value or variable.
25635 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25636 while resolving the corresponding blocks.
25638 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25639 an error, don't silently return null.
25641 * statement.cs (Block.AddVariable): Do the error reporting here
25642 and distinguish between CS0128 and CS0136.
25643 (Block.DoResolve): Report all unused labels (warning CS0164).
25644 (LabeledStatement): Pass the location to the constructor.
25645 (LabeledStatement.HasBeenReferenced): New property.
25646 (LabeledStatement.Resolve): Set it to true here.
25648 * statement.cs (Return.Emit): Return success even after reporting
25649 a type mismatch error (CS0126 or CS0127), this is what csc does and
25650 it avoids confusing the users with any consecutive errors.
25652 2002-08-05 Martin Baulig <martin@gnome.org>
25654 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25656 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25658 * expression.cs (MemberAccess.DoResolve): Silently return if an
25659 error has already been reported.
25661 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25662 error has already been reported.
25664 2002-08-05 Martin Baulig <martin@gnome.org>
25666 * statement.cs (UsageVector): Only initialize the `parameters'
25667 vector if we actually have any "out" parameters.
25669 2002-08-05 Martin Baulig <martin@gnome.org>
25671 * expression.cs (Binary.ResolveOperator): When combining delegates,
25672 they must have the same type.
25674 2002-08-05 Martin Baulig <martin@gnome.org>
25676 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25677 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25678 work with the ms runtime and we also don't need it: if we're a
25679 PropertyBuilder and not in the `indexer_arguments' hash, then we
25680 are a property and not an indexer.
25682 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25683 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25684 since the latter one doesn't work with the ms runtime.
25686 2002-08-03 Martin Baulig <martin@gnome.org>
25688 Fixed bugs #27998 and #22735.
25690 * class.cs (Method.IsOperator): New public field.
25691 (Method.CheckBase): Report CS0111 if there's already a method
25692 with the same parameters in the current class. Report CS0508 when
25693 attempting to change the return type of an inherited method.
25694 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25695 and it's not marked abstract or extern.
25696 (PropertyBase): New abstract base class for Property and Indexer.
25697 (PropertyBase.CheckBase): Moved here from Property and made it work
25699 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25700 the same so we can reuse it there.
25701 (Property, Indexer): Derive from PropertyBase.
25702 (MethodSignature.inheritable_property_signature_filter): New delegate
25703 to find properties and indexers.
25705 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25706 argument and improved error reporting.
25708 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25709 EmptyReadOnlyParameters and made it a property.
25711 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25712 version of this method which takes a `PropertyInfo indexer'.
25713 (TypeManager.RegisterIndexer): New method.
25715 * class.cs: Added myself as author of this file :-)
25717 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25719 * class.cs: fixed compilation on windoze.
25721 2002-08-03 Martin Baulig <martin@gnome.org>
25723 * interface.cs (Interface.GetInterfaceBases): Check whether all
25724 base interfaces are at least as accessible than the current one.
25726 * class.cs (TypeContainer.GetClassBases): Check whether base types
25727 are at least as accessible than the current type.
25728 (TypeContainer.AsAccessible): Implemented and made non-static.
25729 (MemberBase.CheckParameters): Report errors if the accessibility
25732 * delegate.cs (Delegate.Delegate): The default visibility is
25733 internal for top-level types and private for nested types.
25734 (Delegate.Define): Report errors if the accessibility checks fail.
25736 * enum.cs (Enum.Enum): The default visibility is internal for
25737 top-level types and private for nested types.
25738 (Enum.DefineType): Compute the correct visibility.
25740 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25741 function which takes a `bool is_toplevel' instead of a TypeContainer.
25743 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25746 2002-08-02 Martin Baulig <martin@gnome.org>
25748 * expression.cs (LocalVariableReferenc): Added constructor which
25749 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25750 (LocalVariableReference.IsReadOnly): New property.
25751 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25752 variable is readonly, use our own readonly flag to do this; you can
25753 use the new constructor to get a writable reference to a read-only
25756 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25757 reference to the local variable.
25759 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25761 * rootcontext.cs (ResolveCore): Also include System.Exception
25763 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25764 we reach an EmptyStatement.
25766 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25769 * expression.cs (Binary.ResolveOperator): Check error result in
25772 use brtrue/brfalse directly and avoid compares to null.
25774 2002-08-02 Martin Baulig <martin@gnome.org>
25776 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25777 Fixes bug #28407, added test-155.cs.
25779 2002-08-01 Martin Baulig <martin@gnome.org>
25781 * class.cs (Event.EmitDefaultMethod): Make this work with static
25782 events. Fixes #28311, added verify-3.cs.
25784 2002-08-01 Martin Baulig <martin@gnome.org>
25786 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25787 `is_disposable' fields.
25788 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25789 `hm.is_disposable' if we're using the collection pattern.
25790 (Foreach.EmitCollectionForeach): Use the correct type for the
25791 enumerator's local variable, only emit the try/finally block if
25792 necessary (fixes #27713).
25794 2002-08-01 Martin Baulig <martin@gnome.org>
25796 * ecore.cs (Expression.report118): Renamed to Error118 and made
25799 * statement.cs (Throw.Resolve): Check whether the expression is of
25800 the correct type (CS0118) and whether the type derives from
25801 System.Exception (CS0155).
25802 (Catch.Resolve): New method. Do the type lookup here and check
25803 whether it derives from System.Exception (CS0155).
25804 (Catch.CatchType, Catch.IsGeneral): New public properties.
25806 * typemanager.cs (TypeManager.exception_type): Added.
25808 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25810 * driver.cs: Updated About function.
25812 2002-07-31 Martin Baulig <martin@gnome.org>
25814 Implemented Control Flow Analysis.
25816 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25817 (EmitContext.CurrentBranching): Added.
25818 (EmitContext.StartFlowBranching): Added.
25819 (EmitContext.EndFlowBranching): Added.
25820 (EmitContext.KillFlowBranching): Added.
25821 (EmitContext.IsVariableAssigned): Added.
25822 (EmitContext.SetVariableAssigned): Added.
25823 (EmitContext.IsParameterAssigned): Added.
25824 (EmitContext.SetParameterAssigned): Added.
25825 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25826 Added control flow analysis stuff here.
25828 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25829 resolve the expression as lvalue.
25830 (LocalVariableReference.DoResolve): Check whether the variable has
25831 already been assigned.
25832 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25833 the parameter as assigned here.
25834 (ParameterReference.DoResolve): Check whether the parameter has already
25836 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25837 expression as lvalue.
25839 * statement.cs (FlowBranching): New class for the flow analysis code.
25840 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25841 (LabeledStatement.IsDefined): New public property.
25842 (LabeledStatement.AddUsageVector): New public method to tell flow
25843 analyis that the label may be reached via a forward jump.
25844 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25846 (VariableInfo.Number): New public field. This is used by flow analysis
25847 to number all locals of a block.
25848 (Block.CountVariables): New public property. This is the number of
25849 local variables in this block (including the locals from all parent
25851 (Block.EmitMeta): Number all the variables.
25853 * statement.cs: Added flow analysis support to all classes.
25855 2002-07-31 Martin Baulig <martin@gnome.org>
25857 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25858 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25859 then use this argument.
25861 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25863 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25864 use this to specify /define options.
25866 2002-07-29 Martin Baulig <martin@gnome.org>
25868 * statement.cs (Fixed): Moved all code that does variable lookups
25869 and resolvings from Emit to Resolve.
25871 * statement.cs (For): Moved all code that does variable lookups
25872 and resolvings from Emit to Resolve.
25874 * statement.cs (Using): Moved all code that does variable lookups
25875 and resolvings from Emit to Resolve.
25877 2002-07-29 Martin Baulig <martin@gnome.org>
25879 * attribute.cs (Attribute.Resolve): Explicitly catch a
25880 System.NullReferenceException when creating the
25881 CustromAttributeBuilder and report a different warning message.
25883 2002-07-29 Martin Baulig <martin@gnome.org>
25885 * support.cs (ParameterData.ParameterName): Added method to
25886 get the name of a parameter.
25888 * typemanager.cs (TypeManager.IsValueType): New public method.
25890 2002-07-29 Martin Baulig <martin@gnome.org>
25892 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25893 is a flag which specifies that it's either ref or out.
25894 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25895 the out parameter to `out Parameter.Modifier mod', also set the
25896 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25898 * support.cs (InternalParameters.ParameterModifier): Distinguish
25899 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25900 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25902 * expression.cs (Argument.GetParameterModifier): Distinguish
25903 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25904 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25906 2002-07-29 Martin Baulig <martin@gnome.org>
25908 * expression.cs (ParameterReference.ParameterReference): Added
25909 `Location loc' argument to the constructor.
25911 * cs-parser.jay: Pass location to ParameterReference.
25913 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25915 * statement.cs (Try): Initialize the location.
25917 * cs-parser.jay: pass location to Try.
25919 * expression.cs (Unary.Reduce): Change the prototype to return
25920 whether a constant fold could be performed or not. The result is
25921 returned in an out parameters. In the case of Indirection and
25922 AddressOf, we want to perform the full tests.
25924 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25926 * statement.cs (Statement.Emit): Flag dead code.
25928 2002-07-27 Andrew Birkett <andy@nobugs.org>
25930 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25932 2002-07-27 Martin Baulig <martin@gnome.org>
25934 * class.cs (MethodData.Define): Put back call to
25935 TypeManager.AddMethod(), accidentally commented this out.
25937 * report.cs (Debug): New public method to print debugging information,
25938 this is `[Conditional ("DEBUG")]'.
25940 2002-07-26 Martin Baulig <martin@gnome.org>
25942 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25943 (switch_statement): Push the current_block to the switch_stack and
25944 pop it again when we're done with the switch.
25945 (switch_section): The new block is a child of the current_block.
25946 Fixes bug #24007, added test-152.cs.
25948 2002-07-27 Martin Baulig <martin@gnome.org>
25950 * expression.cs (Invocation.EmitArguments): When calling a varargs
25951 function with only its fixed arguments, we need to pass an empty
25954 2002-07-27 Martin Baulig <martin@gnome.org>
25956 Mono 0.13 has been released.
25958 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25960 * driver.cs: Rename --resource to --linkres, because that is what
25961 we do currently, we dont support --resource yet.
25963 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25965 2002-07-25 Martin Baulig <martin@gnome.org>
25967 * class.cs (MethodData): New public class. This is a `method builder'
25968 class for a method or one accessor of a Property/Indexer/Event.
25969 (MethodData.GetMethodFlags): Moved here from MemberBase.
25970 (MethodData.ApplyAttributes): Likewise.
25971 (MethodData.ApplyObsoleteAttribute): Likewise.
25972 (MethodData.ApplyConditionalAttribute): Likewise.
25973 (MethodData.ApplyDllImportAttribute): Likewise.
25974 (MethodData.CheckAbstractAndExternal): Likewise.
25975 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25976 (MethodData.Emit): Formerly known as Method.Emit().
25977 (MemberBase): Moved everything which was specific to a single
25978 accessor/method to MethodData.
25979 (Method): Create a new MethodData and call Define() and Emit() on it.
25980 (Property, Indexer, Event): Create a new MethodData objects for each
25981 accessor and call Define() and Emit() on them.
25983 2002-07-25 Martin Baulig <martin@gnome.org>
25985 Made MethodCore derive from MemberBase to reuse the code from there.
25986 MemberBase now also checks for attributes.
25988 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25989 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25991 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25992 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25993 (MemberBase.ApplyAttributes): New virtual method; applies the
25994 attributes to a method or accessor.
25995 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25996 (MemberBase.ApplyConditionalAttribute): Likewise.
25997 (MemberBase.ApplyDllImportAttribute): Likewise.
25998 (MemberBase.CheckAbstractAndExternal): Likewise.
25999 (MethodCore.ParameterTypes): This is now a property instead of a
26000 method, it's initialized from DoDefineParameters().
26001 (MethodCore.ParameterInfo): Removed the set accessor.
26002 (MethodCore.DoDefineParameters): New protected virtual method to
26003 initialize ParameterTypes and ParameterInfo.
26004 (Method.GetReturnType): We can now simply return the MemberType.
26005 (Method.GetMethodFlags): Override the MemberBase version and add
26006 the conditional flags.
26007 (Method.CheckBase): Moved some code from Define() here, call
26008 DoDefineParameters() here.
26009 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
26010 here to avoid some larger code duplication.
26011 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
26012 ensure that abstract and external accessors don't declare a body.
26014 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
26015 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
26016 lookup in the attribute's parent classes, so we need to abort as soon
26017 as we found the first match.
26018 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
26019 the attribute has no arguments.
26021 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
26024 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26026 * cs-parser.jay: reverted previous patch.
26028 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26030 * cs-parser.jay: fixed bug #22119.
26032 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26034 * attribute.cs: fixed compilation. The error was:
26035 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
26036 be assigned to before control leaves the current method."
26037 [FIXME: Filed as bug #28186: MCS must report this error.]
26039 2002-07-25 Martin Baulig <martin@gnome.org>
26041 * attribute.cs (Attribute.Conditional_GetConditionName): New static
26042 method to pull the condition name ouf of a Conditional attribute.
26043 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
26044 the obsolete message and error flag out of an Obsolete attribute.
26046 * class.cs (Method.GetMethodFlags): New public method to get the
26047 TypeManager.MethodFlags for this method.
26048 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26050 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26051 if we're overriding a virtual function, set the new private variable
26052 `parent_method'; call the new TypeManager.AddMethod().
26054 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26055 the MethodBuilder and the Method in a PtrHashtable.
26056 (TypeManager.builder_to_method): Added for this purpose.
26057 (TypeManager.MethodFlags): Added IsObsoleteError.
26058 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26059 Obsolete and Conditional arguments in MethodBuilders. If we discover
26060 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26061 the message from the attribute.
26063 2002-07-24 Martin Baulig <martin@gnome.org>
26065 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26066 preprocessor directives, ensure that the argument to #define/#undef is
26067 exactly one identifier and that it's actually an identifier.
26069 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26072 2002-07-24 Martin Baulig <martin@gnome.org>
26074 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26075 initialize it to TypeManager.object_type in the constructor.
26076 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26077 of the `hm.get_current' method if we're using the collection pattern.
26078 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26079 for the explicit conversion to make it work when we're using the collection
26080 pattern and the `Current' property has a different return type than `object'.
26083 2002-07-24 Martin Baulig <martin@gnome.org>
26085 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26086 does not match, but don't report any errors. This method is called in
26087 order for all methods in a MethodGroupExpr until a matching method is
26088 found, so we don't want to bail out if the first method doesn't match.
26089 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26090 matches, report the 123. Fixes #28070.
26092 2002-07-24 Martin Baulig <martin@gnome.org>
26094 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26095 TypeManager.TypeToCoreType() to the top of the method so the
26096 following equality checks will work. Fixes #28107.
26098 2002-07-24 Martin Baulig <martin@gnome.org>
26100 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26101 operand is of type uint, and the other operand is of type sbyte,
26102 short or int, the operands are converted to type long." -
26103 Actually do what this comment already told us. Fixes bug #28106,
26106 2002-07-24 Martin Baulig <martin@gnome.org>
26108 * class.cs (MethodBase): New abstract class. This is now a base
26109 class for Property, Indexer and Event to avoid some code duplication
26110 in their Define() and DefineMethods() methods.
26111 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26112 generic methods for Define() and DefineMethods().
26113 (FieldBase): Derive from MemberBase, not MemberCore.
26114 (Property): Derive from MemberBase, not MemberCore.
26115 (Property.DefineMethod): Moved all the code from this method to the
26116 new MethodBase.DefineAccessor(), just call it with appropriate
26118 (Property.Define): Call the new Property.DoDefine(), this does some
26119 sanity checks and we don't need to duplicate the code everywhere.
26120 (Event): Derive from MemberBase, not MemberCore.
26121 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26122 accessors, this will also make them work with interface events.
26123 (Indexer): Derive from MemberBase, not MemberCore.
26124 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26125 (Indexer.Define): Use the new MethodBase functions.
26127 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26128 argument to the constructor.
26129 (Interface.FindMembers): Added support for interface events.
26130 (Interface.PopluateEvent): Implemented.
26132 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26134 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26136 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26137 but this is required to check for a method name being the same as
26138 the containing class.
26142 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26144 * interface.cs: initialize variable.
26146 2002-07-23 Martin Baulig <martin@gnome.org>
26148 Implemented the IndexerName attribute in interfaces.
26150 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26151 name if this is an explicit interface implementation.
26152 (Indexer.InterfaceIndexerName): New public variable. If we're
26153 implementing an interface indexer, this is the IndexerName in that
26154 interface. Otherwise, it's the IndexerName.
26155 (Indexer.DefineMethod): If we're implementing interface indexer,
26156 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26157 and Pending.ImplementIndexer methods.
26158 (Indexer.Define): Also define the PropertyBuilder if we're
26159 implementing an interface indexer and this is neither an explicit
26160 interface implementation nor do the IndexerName match the one in
26163 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26164 If a method is defined here, then we always need to create a proxy
26165 for it. This is used when implementing interface indexers.
26166 (Pending.IsInterfaceIndexer): New public method.
26167 (Pending.ImplementIndexer): New public method.
26168 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26169 This is used when implementing interface indexers to define a proxy
26171 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26172 define a proxy if necessary.
26174 * interface.cs (Interface.IndexerName): New public variable.
26175 (Interface.PopulateIndexer): Set the IndexerName.
26176 (Interface.DefineIndexers): New private method. Populate all the
26177 indexers and make sure their IndexerNames match.
26179 * typemanager.cs (IndexerPropertyName): Added support for interface
26182 2002-07-22 Martin Baulig <martin@gnome.org>
26184 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26185 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26186 ret if HasReturnLabel.
26187 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26190 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26191 and set the ec.LoopBeginTryCatchLevel.
26192 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26193 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26194 the current ec.TryCatchLevel, the branch goes out of an exception
26195 block. In this case, we need to use Leave and not Br.
26197 2002-07-22 Martin Baulig <martin@gnome.org>
26199 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26200 block unless the block does not always return or it is contained in
26201 another try { ... } catch { ... } block. Fixes bug #26506.
26202 Added verify-1.cs to the test suite.
26204 2002-07-22 Martin Baulig <martin@gnome.org>
26206 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26207 then we do not always return. Fixes bug #24985.
26209 2002-07-22 Martin Baulig <martin@gnome.org>
26211 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26212 lookup on a per-class level; ie. walk up the class hierarchy until we
26213 found at least one applicable method, then choose the best among them.
26214 Fixes bug #24463 and test-29.cs.
26216 2002-07-22 Martin Baulig <martin@gnome.org>
26218 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26219 return types of the methods. The return type is not part of the
26220 signature and we must not check it to make the `new' modifier work.
26221 Fixes bug #27999, also added test-147.cs.
26222 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26224 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26225 on the method's return type.
26227 2002-07-21 Martin Baulig <martin@gnome.org>
26229 * assign.cs: Make this work if the rightmost source is a constant and
26230 we need to do an implicit type conversion. Also adding a few more tests
26231 to test-38.cs which should have caught this.
26233 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26234 target in the makefile for this. The makefile.gnu is primarily intended
26235 for end-users who don't want to debug the compiler.
26237 2002-07-21 Martin Baulig <martin@gnome.org>
26239 * assign.cs: Improved the Assign class so it can now handle embedded
26240 assignments (X = Y = Z = something). As a side-effect this'll now also
26241 consume less local variables. test-38.cs now passes with MCS, added
26242 a few new test cases to that test.
26244 2002-07-20 Martin Baulig <martin@gnome.org>
26246 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26247 instructions. Fixes bug #27977, also added test-146.cs.
26249 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26251 * cs-tokenizer.cs: fixed getHex ().
26253 2002-07-19 Martin Baulig <martin@gnome.org>
26255 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26256 not Type.GetType() to lookup the array type. This is needed when
26257 we're constructing an array of a user-defined type.
26258 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26259 single-dimensional arrays, but also for single-dimensial arrays of
26262 2002-07-19 Martin Baulig <martin@gnome.org>
26264 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26265 this function is called, it's not allowed to share LocalBuilders
26266 among ILGenerators.
26268 2002-07-19 Martin Baulig <martin@gnome.org>
26270 * expression.cs (Argument.Resolve): Report an error 118 when trying
26271 to pass a type as argument.
26273 2002-07-18 Martin Baulig <martin@gnome.org>
26275 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26276 Conv_R_Un for the signed `long' type.
26278 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26280 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26281 `expr' for the temporary result, as that will fail if we do
26282 multiple resolves on the same expression.
26284 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26286 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26287 ec.TypeContainer for looking up aliases.
26289 * class.cs (TypeContainer): Remove LookupAlias from here.
26291 * decl.cs (DeclSpace); Move here.
26293 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26295 * class.cs (FindMembers): Only call filter if the constructor
26296 bulider is not null.
26298 Also handle delegates in `NestedTypes' now. Now we will perform
26299 type lookups using the standard resolution process. This also
26302 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26303 This uses Expressions (the limited kind that can be parsed by the
26304 tree) instead of strings.
26306 * expression.cs (ComposedCast.ToString): Implement, used to flag
26307 errors since now we have to render expressions.
26309 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26312 * ecore.cs (SimpleName.ToString): ditto.
26314 * cs-parser.jay: Instead of using strings to assemble types, use
26315 Expressions to assemble the type (using SimpleName, ComposedCast,
26316 MemberAccess). This should fix the type lookups in declarations,
26317 because we were using a different code path for this.
26319 * statement.cs (Block.Resolve): Continue processing statements
26320 even when there is an error.
26322 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26324 * class.cs (Event.Define): Also remove the `remove' method from
26325 the list of pending items.
26327 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26328 generate more compact code.
26330 2002-07-17 Martin Baulig <martin@gnome.org>
26332 * const.cs (Const.LookupConstantValue): Add support for constant
26333 `unchecked' and `checked' expressions.
26334 Also adding test case test-140.cs for this.
26336 2002-07-17 Martin Baulig <martin@gnome.org>
26338 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26339 check whether mi.ReturnType implements the IEnumerator interface; the
26340 `==' and the IsAssignableFrom() will fail in this situation.
26342 2002-07-16 Ravi Pratap <ravi@ximian.com>
26344 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26347 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26349 * expression.cs: fixed bug #27811.
26351 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26353 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26354 Molaro: when we are a ref, the value already contains a pointer
26355 value, do not take the address of it.
26357 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26358 * removed mb-parser.jay and mb-tokenizer.cs
26360 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26362 * expression.cs: check against the building corlib void type.
26364 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26366 * ecore.cs: fix for valuetype static readonly fields: when
26367 initializing them, we need their address, not the address of a copy.
26369 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26371 * typemanager.cs: register also enum_type in corlib.
26373 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26375 * class.cs: allow calling this (but not base) initializers in structs.
26377 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26379 * ecore.cs: make sure we compare against the building base types
26382 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26384 * typemanager.cs: fix TypeToCoreType() to handle void and object
26385 (corlib gets no more typerefs after this change).
26387 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26389 * expression.cs (ArrayCreation.EmitArrayArguments): use
26390 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26392 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26393 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26394 array indexes, the runtime actually forbids them.
26396 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26397 for array arguments here.
26399 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26400 instead of the default for ValueTypes.
26402 (New.DoEmit): Use IsValueType instead of
26403 IsSubclassOf (value_type)
26404 (New.DoResolve): ditto.
26405 (Invocation.EmitCall): ditto.
26407 * assign.cs (Assign): ditto.
26409 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26410 Statements *are* currently doing part of their resolution during
26413 Expressions do always resolve during resolve, but statements are
26414 only required to propagate resolution to their children.
26416 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26418 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26420 (LoadAssembly): Do not add the dll if it is already specified
26422 (MainDriver): Add the System directory to the link path at the end,
26423 after all the other -L arguments.
26425 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26426 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26427 ldelem.u1) and using the opposite for sbytes.
26429 This fixes Digger, and we can finally run it.
26431 * driver.cs (UnixParseOption): Move the option parsing here.
26432 (CSCParseOption): Implement CSC-like parsing of options.
26434 We now support both modes of operation, the old Unix way, and the
26435 new CSC-like way. This should help those who wanted to make cross
26436 platform makefiles.
26438 The only thing broken is that /r:, /reference: and /lib: are not
26439 implemented, because I want to make those have the same semantics
26440 as the CSC compiler has, and kill once and for all the confussion
26441 around this. Will be doing this tomorrow.
26443 * statement.cs (Unsafe.Resolve): The state is checked during
26444 resolve, not emit, so we have to set the flags for IsUnsfe here.
26446 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26448 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26449 not catch the Error_ObjectRefRequired in SimpleName (as it is
26450 possible to have a class/instance variable name that later gets
26451 deambiguated), we have to check this here.
26453 2002-07-10 Ravi Pratap <ravi@ximian.com>
26455 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26456 make static and put into Expression.
26458 (Event.Define): Register the private field of the event with the
26459 TypeManager so that GetFieldFromEvent can get at it.
26461 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26462 keep track of the private field associated with an event which
26465 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26468 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26470 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26472 * expression.cs (Binary.EmitBranchable): this routine emits the
26473 Binary expression in a branchable context. This basically means:
26474 we need to branch somewhere, not just get the value on the stack.
26476 This works together with Statement.EmitBoolExpression.
26478 * statement.cs (Statement.EmitBoolExpression): Use
26481 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26483 * statement.cs (For): Reduce the number of jumps in loops.
26485 (For): Implement loop inversion for the For statement.
26487 (Break): We can be breaking out of a Try/Catch controlled section
26488 (foreach might have an implicit try/catch clause), so we need to
26489 use Leave instead of Br.
26491 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26492 now). If the instace expression supports IMemoryLocation, we use
26493 the AddressOf method from the IMemoryLocation to extract the
26494 address instead of emitting the instance.
26496 This showed up with `This', as we were emitting the instance
26497 always (Emit) instead of the Address of This. Particularly
26498 interesting when This is a value type, as we dont want the Emit
26499 effect (which was to load the object).
26501 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26503 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26505 * statement.cs (Checked): Set the CheckedState during the resolve
26506 process too, as the ConvCast operations track the checked state on
26507 the resolve process, and not emit.
26509 * cs-parser.jay (namespace_member_declaration): Flag that we have
26510 found a declaration when we do. This is used to flag error 1529
26512 * driver.cs: Report ok when we display the help only.
26514 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26516 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26518 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26520 * cs-tokenizer.cs (define): We also have to track locally the
26521 defines. AllDefines is just used for the Conditional Attribute,
26522 but we also need the local defines for the current source code.
26524 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26526 * statement.cs (While, For, Do): These loops can exit through a
26527 Break statement, use this information to tell whether the
26528 statement is the last piece of code.
26530 (Break): Flag that we break.
26532 * codegen.cs (EmitContexts): New `Breaks' state variable.
26534 2002-07-03 Martin Baulig <martin@gnome.org>
26536 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26537 modifiers in method declarations in structs. Otherwise, you won't
26538 be able to override things like Object.Equals().
26540 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26542 * class.cs (Method, Property, Indexer): Do not allow the public
26543 modifier to be used in explicit interface implementations.
26545 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26546 override modifiers in method declarations in structs
26548 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26550 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26551 integer or real overflow, report an error
26553 2002-07-02 Martin Baulig <martin@gnome.org>
26555 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26556 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26557 to tell the runtime about our newly created System.Object and
26558 System.ValueType types.
26560 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26562 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26563 struct instead of Ldarg/Starg.
26565 2002-07-02 Martin Baulig <martin@gnome.org>
26567 * expression.cs (Indirection.Indirection): Call
26568 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26570 2002-07-02 Martin Baulig <martin@gnome.org>
26572 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26573 ValueType, call TypeManager.TypeToCoreType() on it.
26574 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26575 the OpCodes.Newarr argument.
26577 2002-07-02 Martin Baulig <martin@gnome.org>
26579 * expression.cs (Invocation.EmitCall): When compiling corlib,
26580 replace all calls to the system's System.Array type to calls to
26581 the newly created one.
26583 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26584 System.Array methods.
26585 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26586 from the system's System.Array type which must be replaced.
26588 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26590 * typemanager.cs: load unverifiable_code_ctor so we can build
26591 corlib using the correct type. Avoid using GetTypeCode() with
26593 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26594 TypeManager.object_type to allow building corlib.
26596 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26598 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26600 2002-07-01 Martin Baulig <martin@gnome.org>
26602 * class.cs: Make the last change actually work, we need to check
26603 whether `ifaces != null' to avoid a crash.
26605 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26607 * class.cs: when we build structs without fields that implement
26608 interfaces, we need to add the interfaces separately, since there is
26609 no API to both set the size and add the interfaces at type creation
26612 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26614 * expression.cs: the dimension arguments to the array constructors
26615 need to be converted if they are a long.
26617 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26619 * class.cs: don't emit ldarg.0 if there is no parent constructor
26620 (fixes showstopper for corlib).
26622 2002-06-29 Martin Baulig <martin@gnome.org>
26624 MCS now compiles corlib on GNU/Linux :-)
26626 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26627 ie. check for MethodImplOptions.InternalCall.
26629 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26630 and TypeManager.attribute_type are null, so we must explicitly check
26631 whether parent is not null to find out whether it's an attribute type.
26632 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26633 and SetBuilder, not only if the property is neither abstract nor external.
26634 This is necessary to set the MethodImplOptions on the accessor methods.
26635 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26636 SetBuilder, see Property.Emit().
26638 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26639 populate "System.Object", "System.ValueType" and "System.Attribute" since
26640 they've already been populated from BootCorlib_PopulateCoreTypes().
26642 2002-06-29 Martin Baulig <martin@gnome.org>
26644 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26645 is the NullLiteral, we also need to make sure that target_type is not
26648 2002-06-29 Martin Baulig <martin@gnome.org>
26650 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26651 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26652 before calling BootstrapCorlib_ResolveDelegate ().
26654 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26656 * statement.cs: fixed build-breaker. All tests passed ok.
26658 2002-06-27 Martin Baulig <martin@gnome.org>
26660 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26661 for System.Decimal when compiling corlib.
26663 2002-06-27 Martin Baulig <martin@gnome.org>
26665 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26666 switch blocks which contain nothing but a default clause.
26668 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26670 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26672 2002-06-27 Martin Baulig <martin@gnome.org>
26674 * ecore.cs (PropertyExpr.PropertyExpr): Call
26675 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26677 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26678 is already a TypeBuilder.
26680 2002-06-27 Martin Baulig <martin@gnome.org>
26682 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26683 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26684 the "from an array-type to System.Array" case. This makes it work
26685 when compiling corlib.
26687 2002-06-27 Martin Baulig <martin@gnome.org>
26689 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26690 non-static PropertyExpr, set its InstanceExpression. This makes
26691 the `ICollection.Count' property work in System/Array.cs.
26693 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26695 * driver.cs: Made error handling more consistent. Errors now
26696 tracked by Report class, so many methods which used to return int
26697 now return void. Main() now prints success/failure and
26698 errors/warnings message.
26700 Renamed '--probe' compiler argument to '--expect-error'. Removed
26701 the magic number return values (123 and 124). Now, if the
26702 expected error occurs, the compiler exits with success (exit value
26703 0). If the compilation completes without seeing that particular
26704 error, the compiler exits with failure (exit value 1). The
26705 makefile in mcs/errors has been changed to handle the new behaviour.
26707 * report.cs: Made 'expected error' number a property and renamed
26708 it from 'Probe' to 'ExpectedError'.
26710 * genericparser.cs: Removed error handling support, since it is
26711 now all done by Report class.
26713 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26714 class, so parse() no longer returns an int.
26716 * namespace.cs: Use Report.Error instead of GenericParser.error
26718 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26720 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26721 TypeContainer.AddOperator): At the front of the list put the
26722 explicit implementations, so they get resolved/defined first.
26724 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26726 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26727 interface type is implemented by this TypeContainer. Used during
26728 explicit interface implementation.
26730 (Property.Define, Indexer.Define, Method.Define): Validate that
26731 the given interface in the explicit implementation is one of the
26732 base classes for the containing type.
26734 Also if we are explicitly implementing an interface, but there is
26735 no match in the pending implementation table, report an error.
26737 (Property.Define): Only define the property if we are
26738 not explicitly implementing a property from an interface. Use the
26739 correct name also for those properties (the same CSC uses,
26740 although that is really not needed).
26742 (Property.Emit): Do not emit attributes for explicitly implemented
26743 properties, as there is no TypeBuilder.
26745 (Indexer.Emit): ditto.
26747 Hiding then means that we do not really *implement* a pending
26748 implementation, which makes code fail.
26750 2002-06-22 Martin Baulig <martin@gnome.org>
26752 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26753 the return value of Object.GetType(). [FIXME: we need to do this whenever
26754 we get a type back from the reflection library].
26756 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26758 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26760 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26762 * attribute.cs: Return null if we can not look up the type.
26764 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26765 the interface types found.
26767 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26768 interface types found.
26770 * typemanager.cs (GetInterfaces): Make this routine returns alll
26771 the interfaces and work around the lame differences between
26772 System.Type and System.Reflection.Emit.TypeBuilder in the results
26773 result for GetInterfaces.
26775 (ExpandInterfaces): Given an array of interface types, expand and
26776 eliminate repeated ocurrences of an interface. This expands in
26777 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26780 2002-06-21 Martin Baulig <martin@gnome.org>
26782 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26785 2002-06-21 Martin Baulig <martin@gnome.org>
26787 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26788 and called with one of the core types, return the corresponding typebuilder for
26791 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26794 2002-06-21 Martin Baulig <martin@gnome.org>
26796 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26797 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26798 (Expression.ConvertReferenceExplicit): Likewise.
26800 * expression.cs (ElementAccess.DoResolve): Likewise.
26801 (ElementAccess.DoResolveLValue): Likewise.
26803 2002-06-10 Martin Baulig <martin@gnome.org>
26805 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26806 add the "value" parameter to the parameter list.
26808 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26811 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26813 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26814 the argument to an int, uint, long or ulong, per the spec. Also
26815 catch negative constants in array creation.
26817 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26819 * class.cs: do not allow the same interface to appear twice in
26820 the definition list.
26822 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26824 * ecore.cs: don't use ldlen with System.Array.
26826 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26828 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26830 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26832 * modifiers.cs: produce correct field attributes for protected
26833 internal. Easy fix so miguel can work on ther harder stuff:-)
26835 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26837 * pending.cs: New file. Move the code from class.cs here.
26838 Support clearning the pending flag for all methods (when not doing
26839 explicit interface implementation).
26841 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26843 * rootcontext.cs: added a couple more types needed to bootstrap.
26845 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26847 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26848 constructor in the type, instead of any constructor in the type
26849 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26850 a bug in the Mono runtime when applying the params attribute).
26852 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26853 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26855 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26857 * expression.cs (Unary.ResolveOperator): Use TypeManager
26858 to resolve the type.
26860 2002-06-13 Ravi Pratap <ravi@ximian.com>
26862 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26865 * enum.cs (AddEnumMember): Add support to store the attributes associated
26866 with each member too.
26868 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26869 field builders too - this takes care of the enum member case.
26871 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26873 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26874 address-of operator on both value types and pointers.
26876 2002-06-10 Martin Baulig <martin@gnome.org>
26878 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26879 PropertyBuilder to the `property_builders' list.
26881 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26882 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26883 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26884 find any indexers which are inherited from an interface.
26886 2002-06-09 Martin Baulig <martin@gnome.org>
26888 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26889 the same type as the constant if necessary. There's also a test-130.cs
26892 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26894 * typemanager.cs (TypeManager.ChangeType): Previously known as
26895 Enum.ChangeEnumType().
26897 2002-06-09 Martin Baulig <martin@gnome.org>
26899 * expression.cs (Cast.TryReduce): Added support for consts.
26901 2002-06-08 Ravi Pratap <ravi@ximian.com>
26903 * class.cs (Accessor): Hold attributes information so we can pass
26906 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26907 Modify to pass in attributes attached to the methods.
26909 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26911 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26912 to handle the Accessor kind :-)
26914 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26916 2002-06-08 Martin Baulig <martin@gnome.org>
26918 * expression.cs (Unary.TryReduceNegative): Added support for
26921 2002-06-08 Martin Baulig <martin@gnome.org>
26923 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26924 name can't be found in the `defined_names' - the caller will do a
26925 MemberLookup in this case and thus find methods in System.Enum
26926 such as Enum.IsDefined().
26928 2002-06-08 Martin Baulig <martin@gnome.org>
26930 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26931 Convert.ChangeType() which works with TypeBuilder created types.
26932 (Enum.LookupEnumValue, Enum.Define): Use it here.
26934 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26935 `TypeBuilder.BaseType != null' check.
26936 (TypeContainer.FindMembers): Only lookup parent members if we
26937 actually have a parent.
26938 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26939 (ConstructorInitializer.Resolve): Likewise.
26941 * interface.cs (Interface.FindMembers): Added
26942 `TypeBuilder.BaseType != null' check.
26944 * rootcontext.cs (RootContext.ResolveCore): Added
26945 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26946 classes_second_stage.
26948 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26949 debug_type and trace_type when compiling with --nostdlib.
26951 2002-06-07 Martin Baulig <martin@gnome.org>
26953 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26954 (AddField): Set it to true when adding a non-static field.
26955 (DefineType): Use `have_nonstatic_fields' to find out whether we
26956 have non-static fields, not `Fields != null'.
26958 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26960 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26961 dereferencing a null on the static-field code path)
26963 2002-05-30 Martin Baulig <martin@gnome.org>
26965 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26966 to take command line arguments. Use reflection to call the new
26967 custom `Initialize' function on the symbol writer and pass it the
26968 command line arguments.
26970 * driver.cs (--debug-args): New command line argument to pass command
26971 line arguments to the symbol writer.
26973 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26975 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26976 the target type for indexers and properties. Thanks to Joe for
26979 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26981 * typemanager.cs (MethodFlags): returns the method flags
26982 (Obsolete/ShouldIgnore) that control warning emission and whether
26983 the invocation should be made, or ignored.
26985 * expression.cs (Invocation.Emit): Remove previous hack, we should
26986 not do this on matching a base type, we should do this based on an attribute
26988 Only emit calls to System.Diagnostics.Debug and
26989 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26990 on the command line.
26992 * rootcontext.cs: Global settings for tracing and debugging.
26994 * cs-tokenizer.cs (define): New utility function to track
26995 defines. Set the global settings for TRACE and DEBUG if found.
26997 2002-05-25 Ravi Pratap <ravi@ximian.com>
26999 * interface.cs (Populate*): Pass in the TypeContainer as well as
27000 the DeclSpace as parameters so that we can create EmitContexts and
27001 then use that to apply attributes etc.
27003 (PopulateMethod, PopulateEvent, PopulateProperty)
27004 (PopulateIndexer): Apply attributes everywhere.
27006 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
27009 (ApplyAttributes): Update accordingly.
27011 We now apply interface attributes for all members too.
27013 2002-05-26 Miguel de Icaza <miguel@ximian.com>
27015 * class.cs (Indexer.Define); Correctly check if we are explicit
27016 implementation (instead of checking the Name for a ".", we
27017 directly look up if the InterfaceType was specified).
27019 Delay the creation of the PropertyBuilder.
27021 Only create the PropertyBuilder if we are not an explicit
27022 interface implementation. This means that explicit interface
27023 implementation members do not participate in regular function
27024 lookups, and hence fixes another major ambiguity problem in
27025 overload resolution (that was the visible effect).
27027 (DefineMethod): Return whether we are doing an interface
27030 * typemanager.cs: Temporary hack until we get attributes in
27031 interfaces (Ravi is working on that) and we get IndexerName
27032 support in interfaces.
27034 * interface.cs: Register the indexers as properties.
27036 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
27037 warning, I have verified that this is a bug in the .NET runtime
27038 (JavaScript suffers of the same problem).
27040 * typemanager.cs (MemberLookup): When looking up members for
27041 interfaces, the parent of an interface is the implicit
27042 System.Object (so we succeed in searches of Object methods in an
27043 interface method invocation. Example: IEnumerable x; x.ToString
27046 2002-05-25 Miguel de Icaza <miguel@ximian.com>
27048 * class.cs (Event): Events should also register if they do
27049 implement the methods that an interface requires.
27051 * typemanager.cs (MemberLookup); use the new GetInterfaces
27054 (GetInterfaces): The code used to lookup interfaces for a type is
27055 used in more than one place, factor it here.
27057 * driver.cs: Track the errors at the bottom of the file, we kept
27060 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27061 instance if the method we are calling is static!
27063 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27065 * attribute.cs (ApplyAttributes): Make this function filter out
27066 the IndexerName attribute (as that attribute in reality is never
27067 applied) and return the string constant for the IndexerName
27070 * class.cs (TypeContainer.Emit): Validate that all the indexers
27071 have the same IndexerName attribute, and if so, set the
27072 DefaultName attribute on the class.
27074 * typemanager.cs: The return value might contain other stuff (not
27075 only methods). For instance, consider a method with an "Item"
27076 property and an Item method.
27078 * class.cs: If there is a problem with the parameter types,
27081 2002-05-24 Ravi Pratap <ravi@ximian.com>
27083 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27084 looks at user defined conversion after making a call to
27085 StandardConversionExists - we need this for overload resolution.
27087 * expression.cs : Update accordingly the various method calls.
27089 This fixes 2 bugs filed against implicit user defined conversions
27091 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27093 * statement.cs: Track the result of the assignment.
27095 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27097 * expression.cs (MemberAccess): Improved error reporting for
27098 inaccessible members.
27100 2002-05-22 Martin Baulig <martin@gnome.org>
27102 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27103 itself with debugging support.
27105 2002-05-22 Martin Baulig <martin@gnome.org>
27107 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27108 Removed, this isn't needed anymore.
27110 2002-05-20 Martin Baulig <martin@gnome.org>
27112 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27113 be underlying type for an enum.
27115 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27117 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27118 that splits out the loading of just the core types.
27120 * rootcontext.cs (ResolveCore): Split the struct resolution in
27121 two, so we can load the enumeration underlying types before any
27124 * expression.cs (Is): Bandaid until we fix properly Switch (see
27125 bug #24985 for details).
27127 * typemanager.cs (ImplementsInterface): The hashtable will contain
27128 a null if there are no interfaces implemented.
27130 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27132 * cs-parser.jay (indexer_declarator): It is fine to have array
27135 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27137 * typemanager.cs: (RegisterBuilder): New function used to register
27138 TypeBuilders that implement interfaces. Since
27139 TypeBuilder.GetInterfaces (as usual) does not work with lame
27141 (AddUserType): register interfaces.
27143 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27144 dealing with TypeBuilder. Also, arrays are showing up as
27145 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27146 methods can not be invoked on them!
27148 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27149 (ImplicitReferenceConversionExists): Split out from
27150 StandardConversionExists.
27152 * expression.cs (As): We were only implementing one of the three
27153 cases for the as operator. We now implement them all.
27154 (Is): Implement the various other cases for Is as well.
27156 * typemanager.cs (CACHE): New define used to control if we want or
27157 not the FindMembers cache. Seems to have a negative impact on
27158 performance currently
27160 (MemberLookup): Nested types have full acess to
27161 enclosing type members
27163 Remove code that coped with instance/static returns for events, we
27164 now catch this in RealFindMembers.
27166 (RealFindMembers): only perform static lookup if the instance
27167 lookup did not return a type or an event.
27169 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27171 * assign.cs (CompoundAssign): We pass more semantic information
27172 now to Compound Assignments than we did before: now we have all
27173 the information at hand, and now we resolve the target *before* we
27174 do the expression expansion, which allows the "CacheValue" method
27175 to have the effect we intended (before, a [x] += 1 would generate
27176 two differen ArrayAccess expressions from the ElementAccess,
27177 during the resolution process).
27179 (CompoundAssign.DoResolve): Resolve target and original_source here.
27181 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27183 * expression.cs (ArrayAccess): dropped debugging information.
27185 * typemanager.cs: Small bug fix: I was always returning i_members,
27186 instead of one of i_members or s_members (depending on which had
27189 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27190 method is invoked before any code generation takes place, and it
27191 is a mechanism to inform that the expression will be invoked more
27192 than once, and that the method should use temporary values to
27193 avoid having side effects
27195 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27197 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27200 * expression.cs (Indirection, ArrayAccess): Add support for
27201 CacheTemporaries in these two bad boys.
27203 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27204 ldobj or ldind_ref.
27205 (StoreFromPtr): Handle stobj as well.
27207 * expression.cs (UnaryMutator): Share more code.
27209 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27210 down: I was not tracking the Filter function as well, which
27211 was affecting the results of the cache.
27213 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27215 * attribute.cs: Remove the hack to handle the CharSet property on
27218 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27220 * attribute.cs (DoResolve): More uglyness, we now only try to
27221 resolve the attribute partially, to extract the CharSet
27222 information (only if we are a StructLayout attribute). Otherwise
27224 (GetExtraTypeInfo): Add some code to conditionally kill in the
27225 future this. I am more and more convinced that the .NET
27226 framework has special code to handle the attribute setting on
27229 * expression.cs (IsParamsMethodApplicable): Revert my previous
27230 foreach change here, it was wrong.
27232 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27234 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27235 (pp_expr): do not abort on unknown input, just return.
27236 (eval): abort if there are pending chars.
27238 * attribute.cs (Attribute.Resolve): Positional parameters are
27239 optional. Deal with that case.
27241 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27242 the Ansi/Unicode/Auto information for the type.
27244 (TypeContainer.DefineType): instantiate the EmitContext here, as
27245 we will be using it during the type definition (to resolve
27246 attributes) and during the emit phase.
27248 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27249 to pull type information out of the attributes
27251 (Attribute.Resolve): track the constructor builder, and allow for
27252 multiple invocations (structs and classes will use this).
27254 * ecore.cs (MemberLookupFinal): new version with all the
27255 parameters customizable.
27257 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27258 constructors. Return if the result value is null (as the error
27259 would have been flagged already by MemberLookupFinal)
27261 Do not allow instances of abstract classes or interfaces to be
27264 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27265 We have to compare the assembly property here when dealing with
27266 FamANDAssem and Assembly access modifiers, because we might be
27267 creating an assembly from *modules* (that means that we are not
27268 getting TypeBuilders for types defined in other modules that are
27269 part of this assembly).
27271 (Method.Emit): If the method is marked abstract and has a body,
27274 (TypeContainer.DefineMembers): If both the defined member and the
27275 parent name match are methods, then do not emit any warnings: let
27276 the Method.Define routine take care of flagging warnings. But if
27277 there is a mismatch (method overrides something else, or method is
27278 overriwritten by something, then emit warning).
27280 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27281 set to null, this means `do not check for the return type on the
27284 (Method.Define): set the return type for the method signature to
27285 null, so that we get methods with the same name and parameters and
27286 different return types. This is used to flag warning 114 (you are
27287 hiding a method, and you probably want to use the new/override
27290 * typemanager.cs (MemberLookup): Implemented proper access
27291 control, closing a long standing set of bug reports. The problem
27292 was that the Framework only has two bits: Public and NonPublic,
27293 and NonPublic includes private and protected methods, but we need
27294 to enforce the FamANDAssem, FamOrAssem and Family.
27296 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27298 * statement.cs (GotoCase): Return true: Ammounts to giving up
27299 knowledge on whether we return or not, and letting the other case
27300 be responsible for it.
27302 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27304 * driver.cs: Do not load directories for each file processed, only
27305 do it if there is a pattern.
27307 * ecore.cs: Report readonly assigns here as well, as we might have
27308 been resolved only by MemberAccess.
27310 (SimpleName.SimpleNameResolve): Also be useful for LValue
27311 resolution. We need this to propagate assign to local readonly variables
27313 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27314 do not want to reuse potential criteria memory.
27316 * class.cs (MyEventBuilder): Set reflected_type;
27318 * ecore.cs (Constantify): Added support for constifying bools.
27320 (RootContext.LookupType): Added a cache for values looked up in
27321 the declaration space.
27323 * typemanager.cs (FindMembers): Now is a front-end to
27324 RealFindMembers, and provides a two-level hashtable-based cache to
27327 15% performance improvement: from 22.5 to 19.2 seconds.
27329 * expression.cs (IsParamsMethodApplicable): use foreach.
27330 (Invocation.DoResolve): ditto.
27331 (New.DoResolve): ditto.
27332 (ArrayCreation.DoResolve): ditto.
27334 * ecore.cs (FindMostEncompassingType): use foreach.
27336 * delegate.cs (NewDelegate.DoResolve): Use foreach
27338 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27339 (RemoveMethods): use foreach.
27341 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27342 nested foreach statements instead of for, and also break out of
27343 the inner loop once a match is found.
27345 (Invocation.OverloadResolve): Use foreach, simplify the code.
27347 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27349 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27350 we actually unwrap the expression to allow for extra information
27353 * expression.cs: Use Shr_Un on unsigned operations.
27355 2002-05-08 Ravi Pratap <ravi@ximian.com>
27357 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27358 applicable operators was not being considered correctly. This closes
27359 the bug Miguel reported.
27361 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27363 * attribute.cs: check that the type derives from System.Attribute
27364 and report the correct error in that case (moved the duplicate code to
27365 its own method, too).
27367 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27369 * attribute.cs: lookup attribute type name as the spec says: first the
27370 bare attribute name and then name + "Attribute" (nant compiles with
27371 mcs after this fix).
27373 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27375 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27376 Because of the way we parse things, we should try to see if a
27377 UIntConstant can fit in an integer.
27379 2002-05-07 Ravi Pratap <ravi@ximian.com>
27381 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27382 when we are in an explicit context.
27384 (ConvertReferenceExplicit): When converting from Iface type S to Class
27385 T make sure the rules are implemented as an OR.
27387 * parameter.cs (ParameterType): Make it a property for now although the
27388 purpose really isn't anything immediate.
27390 * expression.cs (Is*Applicable): Do better checking on the parameter type
27391 of a ref/out parameter. The ones from the system assemblies are already
27392 marked with the correct type so we don't need to do any correction.
27394 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27395 the object type is standard too so include that.
27397 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27399 * ecore.cs (StandardConversionExists): Augment with missing code:
27400 deal with IntConstant, LongConstants and Enumerations.
27402 * assign.cs: Report the error, instead of failing silently
27404 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27405 typecontainer that they are declared, because the
27406 typecontainer/namespace will have the list of using clauses that
27407 need to be applied.
27409 Assembly Attributes were escaping the normal registration
27412 (EmitCode): Apply attributes within an EmitContext that represents
27413 the container they were declared on.
27415 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27417 2002-05-06 Ravi Pratap <ravi@ximian.com>
27419 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27420 Revamp completely - make much cleaner as we now operate only
27423 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27424 to implement the logic detailed in the spec more correctly.
27426 (UserDefinedConversion): Update accordingly.
27428 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27430 * statement.cs: Return flow analysis information up.
27432 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27435 (token): Do not consume an extra character before calling
27438 2002-05-06 Piers Haken <piersh@friskit.com>
27440 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27442 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27444 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27445 EmitContext during the instance constructor initializer
27446 resolution, to stop access to instance variables.
27448 This is mandated by the spec, last paragraph of the `constructor
27449 initializers' section.
27451 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27453 * cs-parser.jay, class.cs (Accessor): new class used to represent
27454 an accessor (get or set). In the past we used `null' to represent
27455 a missing accessor. But this is ambiguous because there was no
27456 way to tell in abstract indexers/properties if one of them was
27459 Now there is a way of addressing that.
27461 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27462 instead of FindMembers.
27464 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27465 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27467 * attribute.cs: Treat indexers and properties as the same in terms
27468 of applying attributes
27470 * ecore.cs (FindMostEncompassedType): Use statically initialized
27471 EmptyExpressions()s like we do elsewhere to avoid creating useless
27472 objects (and we take this out of the tight loop).
27474 (GetConversionOperators): Move the code to extract the actual
27475 operators to a separate routine to clean things up.
27477 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27479 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27480 events are always registered FieldBuilders.
27482 * class.cs (FieldBase): New class shared by Fields
27484 * delegate.cs: If we are a toplevel delegate, use our full name.
27485 If we are a nested delegate, then only use our tail name.
27487 2002-05-02 Ravi Pratap <ravi@ximian.com>
27489 * expression.cs (IsApplicable): Ensure that we add the "&" to
27490 ref/out types before comparing it with the type of the argument.
27492 (IsParamsMethodApplicable): Ditto.
27494 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27497 * delegate.cs : Handle the case when we have more than one applicable
27498 method. Flag an error only when we finish checking all.
27500 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27502 * expression.cs: Add support for boolean static initializers.
27504 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27506 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27508 * parameter.cs (ComputeParameterTypes,
27509 ComputeAndDefineParameterTypes): Better error handling: now we
27510 clear the `types' cache if we fail during any of the type lookups.
27511 We also return the status code correctly to our caller
27513 * delegate.cs: If we fail to define a delegate, abort the extra
27516 * expression.cs (Binary.ResolveOperator): for
27517 operator==(object,object) and operator !=(object, object) we also
27518 have to verify that there is an implicit conversion from one to
27521 (ArrayAccess.DoResolve): Array Access can operate on
27524 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27526 * assign.cs (CompoundAssign): A new class used as a "flag" that
27527 the assignment actually is happening as part of a compound
27528 assignment operator.
27530 During compound assignment, a few new rules exist to enable things
27537 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27538 to the type of x) if y is implicitly convertible to the type of x,
27539 and the operator is a builtin operator and the return type of the
27540 operator is explicitly convertible to the type of x.
27542 * rootcontext.cs: Reset warning level to 2. 4 catches various
27543 "interesting" features in mcs, we must clean this up at some
27544 point, but currently am trying to kill other bugs ;-)
27546 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27547 in container classes as well.
27549 * expression.cs (Binary.ResolveOperator): Handle string case
27550 before anything else (as operator overloading does emit an error
27551 before doing anything else).
27553 This code could go away when we move to a table driven model, but
27554 i could not come up with a good plan last night.
27556 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27558 * typemanager.cs (CSharpName): reimplementation using regex.
27559 * class.cs: added null check for fields in Emit
27560 * rootcontext.cs: set warninglevel to 4
27562 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27564 * typemanager.cs (CSharpName): reimplemented with Lupus
27567 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27569 * statement.cs (If): correclty implement Resolve, because we were
27570 not catching sem errors in there. The same process is needed
27572 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27575 (Statement.Warning_DeadCodeFound): Factorize code.
27576 (While): Report dead code here too.
27578 (Statement): Added Resolve virtual method to allow
27579 for resolution split from the emit code.
27581 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27583 * statement.cs (EmitBoolExpression): No longer try to resolve the
27585 (MakeBoolean): New utility function that resolve, implicitly
27586 converts to boolean and tags the expression.
27589 (If, Do): Implement dead code elimination.
27590 (While): Implement loop inversion
27592 (Do, While, For, If): Resolve the expression prior to calling our
27595 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27598 - added method Report28 (warning: program has more than one entry point)
27599 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27600 - modified method Method.Define, the part at the end of the method
27602 * rootcontext.cs: added static public Location EntryPointLocation;
27604 * ../errors/cs0028.cs : Add test case for the above warning.
27607 - modified method CSharpName to allow arrays of primitive type to
27608 be printed nicely (e.g. instead of System.Int32[][] it now prints
27610 - added method CSharpSignature: returns the signature of a method
27611 in string format to be used in reporting errors, warnings, etc.
27613 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27616 2002-04-26 Ravi Pratap <ravi@ximian.com>
27618 * delegate.cs (Define): Fix extremely silly bug where I was
27619 setting the type of the 'object' parameter of the BeginInvoke
27620 method to System.IAsyncResult instead of System.Object ;-)
27622 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27624 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27627 (Constructor.Emit): return if we fail to initialize the
27628 constructor. Another door closed!
27630 * expression.cs (New.DoResolve): Improve error message (from -6 to
27631 1501). Use DeclaredOnly lookup to find the exact constructor.
27633 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27634 loop. This is useful.
27636 * cs-parser.jay: Adjust the default parameters so that destructors
27637 have the proper signature.
27639 2002-04-26 Martin Baulig <martin@gnome.org>
27641 * driver.cs (LoadAssembly): If `assembly' contains any characters
27642 which are only valid in path names and not in assembly names
27643 (currently slash, backslash and point), use Assembly.LoadFrom ()
27644 instead of Assembly.Load () on the `assembly' (before iteration
27645 over the link_paths).
27647 2002-04-26 Martin Baulig <martin@gnome.org>
27649 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27651 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27653 * class.cs (Property): use the new typemanager.MemberLookup
27655 (TypeContainer.MemberLookup): Implement using the
27656 TypeManager.MemberLookup now.
27658 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27659 and return MemberInfos, so that these can be used without an
27660 EmitContext (what we had before).
27662 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27664 * expression.cs: Fix the case where the argument to params if the
27665 type of the params. I omitted handling this before. Fixed
27667 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27669 * driver.cs: Call BootCorlib_PopulateCoreType
27671 * class.cs (Property.CheckBase): Check for properties only, not
27674 * interface.cs: Temporary hack: try/catch around the
27675 CustomAttributeBuilder, because I am getting an exception that I
27678 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27679 types whose definitions are required to be there (attributes are
27680 defined before standard types).
27682 Compute definitions as we boot the various types, as they are used
27683 immediately (value_type class will need object_type, but if we do
27684 not initialize object_type, we will pass a null, which will let
27685 the runtime pick the System.Object from the existing corlib, which
27686 is not what we want).
27688 2002-04-22 Patrik Torstensson <totte@labs2.com>
27690 * cs-tokenizer.cs: fixed a number of trim() issues.
27692 2002-04-22 Ravi Pratap <ravi@ximian.com>
27694 * expression.cs (Argument.Type): Ensure that we return the correct
27695 type when we have out or ref parameters [in which case we
27698 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27700 * class.cs (Property, Indexer): Allow extern modifier in there.
27702 * typemanager.cs (InitBaseTypes): Initializes object_type and
27703 value_type, since those will be used early on during the bootstrap
27704 process to compile corlib.
27706 (InitCoreTypes): Move code from here to InitBaseTypes.
27708 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27710 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27711 single-dimension arrays as using the ldlen opcode.
27713 Daniel Lewis discovered this optimization.
27715 * typemanager.cs: Add signature for System.Array::get_Length
27717 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27719 * statement.cs: report the error when the foreach does not apply to an
27720 array nor a collection.
27722 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27724 * expression.cs: Add implicit conversions to the operator ~.
27726 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27728 * typemanager.cs: Locate the decimal constructor.
27730 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27732 * attribute.cs: use the new property of TypeOf.
27733 * expression.cs: added 'get' property around typearg.
27735 These changes fix a build breaker reported by NickD. Is this the
27736 correct way to fix? If not, please, revert my changes and make it
27739 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27741 * attribute.cs: Add support for typeof in attribute invocations.
27742 I am not sure that this is right though.
27744 2002-04-14 Duncan Mak <duncan@ximian.com>
27746 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27747 Binary.Operator.Division case.
27749 2002-04-13 Ravi Pratap <ravi@ximian.com>
27751 * class.cs (DefineType): Ensure that we do a proper check on
27752 attribute types and also register it with the TypeManager.
27754 (TypeContainer.Targets): The default for attribute types is
27755 AttributeTargets.All.
27757 * attribute.cs (ApplyAttributes): Registering the attribute type
27758 is done elsewhere, not when we discover we have a Usage attribute.
27760 2002-04-12 Ravi Pratap <ravi@ximian.com>
27762 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27763 and get rid of is_delegate parameter.
27765 * everywhere : update.
27767 2002-04-12 Ravi Pratap <ravi@ximian.com>
27769 * cs-parser.jay (compilation_unit): Revamp completely to use
27770 some new ideas that I got from Rhys' grammar to solve the problems
27771 with assembly level attributes.
27773 (outer_declaration): New grammar production.
27775 (attribute_sections): Add.
27777 (opt_attributes): Base on attribute_sections
27779 (namespace_declaration): Allow opt_attributes to tackle the case
27780 when we have assembly level attributes - we are clever in this
27783 * attribute.cs (ApplyAttributes): Do not worry about assembly
27784 attributes in the non-global context.
27786 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27787 instead of SetGlobalAttributes.
27789 * class.cs, rootcontext.cs : Ensure we define and generate
27790 attribute types before anything else.
27792 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27793 and flag the new error -20 for the case when the attribute type
27794 does not have valid targets specified. csc does not catch this.
27796 * ../errors/errors.txt : update for error # -20
27798 2002-04-11 Ravi Pratap <ravi@ximian.com>
27800 * support.cs (InternalParameters.ParameterModifier): Do some null
27801 checking and return sane values.
27803 * class.cs (Method.Define): If we are a PInvoke method, ensure
27804 that we are static and extern. Report error # 601
27806 * ../errors/cs0601.cs : Add test case for the above error.
27808 2002-04-07 Ravi Pratap <ravi@ximian.com>
27810 * rootcontext.cs (attribute_types): We need to keep type of
27811 all attribute types separately and emit code for them first.
27813 (RegisterAttribute) : Implement.
27815 * class.cs (DefineType): Check if the current Type is a custom
27816 attribute type and register it accordingly.
27818 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27819 adding the first attribute twice and rename to
27821 (SetGlobalAttributes): this.
27823 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27826 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27827 if we are processing global arguments. Hmm, I am unsure of this.
27829 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27831 * expression.cs: added static array of strings to avoid calling
27832 Enum.ToString () for Operator in Binary. Significant recover of
27835 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27837 * class.cs (FindMembers): Allow the Builders of the various
27838 members to be null. If they are skip them. This only happens
27839 during the PInvoke declaration.
27841 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27843 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27844 failure, so we do not keep going afterwards.
27846 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27847 wanted to pass `false' as the `is_delegate' argument. If this is
27848 the case, why not use delegate_type == null to mean `is_delegate =
27849 false' and anything else as is_delegate = true.
27851 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27853 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27854 code for the section, not the beginning of the tests.
27856 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27858 * cfold.cs: Handle operator + (Enum x, Underlying x)
27860 * expression.cs (Binary): same. Warn about errors where we have
27861 Enum/Enum in operator + as well.
27863 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27866 - added support for switch(bool)
27867 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27868 - add TableSwitchEmit() to handle table-based switch statements
27870 2002-04-05 Ravi Pratap <ravi@ximian.com>
27872 * expression.cs (Invocation.OverloadResolve): Factor out code which
27873 does parameter compatibility checking with arguments so that we can
27874 re-use the code even from Delegate.VerifyApplicability
27876 (VerifyArgumentsCompat): Move above code here.
27878 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27879 and instead make a call to the above method.
27881 2002-03-31 Ravi Pratap <ravi@ximian.com>
27883 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27884 We use it to keep track of classes which are attribute types.
27886 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27888 * delegate.cs (Delegate.Define): Correctly define the types in the
27889 presence of fixed and array parameters.
27891 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27894 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27895 include NonPublic after the first iteration.
27897 * class.cs (Indexer.CheckBase): Only check if both parents are
27900 * cs-parser.jay (accessor_body): If empty, set to null.
27902 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27903 same code path here to resolve constants names that we did have in
27904 MemberAccess.DoResolve. There is too much code duplicated here.
27906 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27908 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27910 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27913 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27914 tokens, numbers and strings.
27916 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27919 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27920 asyncronous parameters and the regular parameters.
27922 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27923 specify the target directory.
27925 * expression.cs: (This.DoResolve): Simplify
27926 (As.Emit): Optimize, do not generate IsInst if the expression is
27927 always of the given type.
27929 (Is.DoResolve): Bug fix, we were reporting both always/never for
27932 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27933 creating too many unnecessary arrays.
27935 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27937 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27938 fields instead of rolling our own initializer. Takes care of all
27939 implicit conversions, and drops unnecessary static checks/argument.
27941 2002-03-31 Dick Porter <dick@ximian.com>
27943 * driver.cs: use the GetDirectories() return values properly, and
27944 use "/" as path separator.
27946 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27948 * expression.cs (Unary): Optimize - - expr into expr.
27949 (Binary): Optimize a + (-b) into a -b.
27951 * codegen.cs (CodeGen): Made all methods static.
27953 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27957 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27958 TypeBuilder property.
27960 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27963 * tree.cs: Removed the various RecordXXXX, and replaced with a
27964 single RecordDecl. Removed all the accessor methods, and just
27965 left a single access point Type
27967 * enum.cs: Rename DefineEnum to DefineType.
27969 * decl.cs: New abstract method `DefineType' used to unify the
27970 Defines for Enumerations, Interfaces, TypeContainers and
27973 (FindType): Moved LookupInterfaceOrClass here. Moved the
27974 LookupBaseClasses method that used to live in class.cs and
27975 interface.cs here, and renamed to FindType.
27977 * delegate.cs: Implement DefineType. Take advantage of the
27978 refactored pattern for locating the parent builder without taking
27979 the parent_builder argument (which we know does not work if we are
27980 nested, and triggering a toplevel definition).
27982 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27984 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27985 accessibility of a member has changed during override and report
27988 * class.cs (Method.Define, Property.Define): Only complain on
27989 overrides if the method is private, any other accessibility is
27990 fine (and since we just checked the permission is the same, we are
27993 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27994 and elif are processed always. The other pre-processing
27995 directives are only processed if we are "taking" the path
27997 2002-03-29 Martin Baulig <martin@gnome.org>
27999 * class.cs (Method.Emit): Only emit symbolic debugging info if the
28000 current location is not Null.
28002 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
28003 a separate method so we can profile it.
28005 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
28006 `span.Seconds' are just seconds, but no minutes or hours.
28007 (MainDriver): Profile the CodeGen.SaveSymbols calls.
28009 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28011 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
28012 Remove the gratuitous set of Final:
28014 // If an interface implementation, then we can set Final.
28015 if (((flags & MethodAttributes.Abstract) == 0) &&
28016 implementing.DeclaringType.IsInterface)
28017 flags |= MethodAttributes.Final;
28019 I do not know what I was smoking when I used that.
28022 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
28023 step into fixing the name resolution issues for delegates and
28024 unifying the toplevel name resolution.
28026 2002-03-28 Martin Baulig <martin@gnome.org>
28028 * class.cs (Method.Emit): If we have a symbol writer, call its
28029 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
28030 tell it about the current method.
28032 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
28033 writer that we're going to emit the first byte of IL code for a new
28034 statement (a new source line).
28035 (EmitContext.EmitTopBlock): If we have a symbol writer, call
28036 EmitContext.Mark() before emitting any code.
28038 * location.cs (SymbolDocument): Return null when we're Null.
28040 * statement.cs (Statement): Moved the `Location loc' variable here.
28041 (Statement.EmitBoolExpression): If we have a symbol writer, call
28042 ec.Mark() before emitting any code to tell it that we're at the
28043 beginning of a new statement.
28044 (StatementExpression): Added `Location' argument to the constructor.
28045 (Block): Added public readonly variable `StartLocation' and public
28046 variable `EndLocation'. The latter is to be set using SetEndLocation().
28047 (Block): Added constructor which takes a start and end location.
28048 (Block.SetEndLocation): New method. This sets the end location.
28049 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28050 local variables we create.
28051 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28052 each statement and do also mark the begin and end of the block.
28054 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28055 tell it the current lexer.Location, use Location.Null for the end of the
28057 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28058 current block, set its end location using SetEndLocation().
28059 (statement_expression): StatementExpression constructor now takes the
28060 lexer.Location as additional argument.
28061 (for_statement, declare_local_variables): Likewise.
28062 (declare_local_variables): When creating a new implicit block, use the
28063 new Block constructor and pass it the lexer.Location.
28065 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28067 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28068 members also on the parent interfaces recursively.
28070 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28072 * report.cs: Use new formats, since Gonzalo finished the missing
28075 * expression.cs (Binary.ResolveOperator): added missing operator|
28076 operator& and operator^ for bool/bool.
28078 * cs-parser.jay: CheckDef now takes a Location argument that is
28079 used to report errors more precisly (instead of reporting the end
28080 of a definition, we try to track something which is a lot closer
28081 to the source of the problem).
28083 * cs-tokenizer.cs: Track global token use, so we can properly flag
28084 the use of #define/#undef after the first token has been seen.
28086 Also, rename the reportXXXX to Error_DescriptiveName
28088 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28089 TypeContainer, so that Enum and Interface can use this too.
28091 * class.cs (TypeContainer.LookupInterfaceOrClass,
28092 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28093 `builder' argument. Typically this was used to pass the parent
28094 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28097 The problem is that a nested class could trigger the definition of
28098 a toplevel class, and the builder would be obviously wrong in that
28101 So we drop this argument, and we compute dynamically the
28102 TypeBuilder/ModuleBuilder (the correct information was available
28103 to us anyways from DeclSpace.Parent)
28105 * interface.cs (Interface.DefineInterface): Drop builder
28106 parameter cleanup like class.cs
28108 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28111 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28114 (Try.Emit): Propagate the returns value from the statement.
28116 (Return.Emit): Even if we are leavning
28118 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28120 * modifiers.cs: Fix the computation of MethodAttributes flags.
28122 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28124 * driver.cs: allow compilation of files that start with '/'.
28125 Add a default case when checking the argument of --target.
28127 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28129 * interface.cs: Implement the same search algorithm for types in
28130 the interface code.
28132 * delegate.cs: Do not allow multiple definition.
28134 * Recovered ChangeLog that got accidentally amputated
28136 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28138 * rootcontext.cs: Load manually enum to allow core classes to
28139 contain enumerations.
28141 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28142 Update to new static methods in TypeManager.
28144 * typemanager.cs (GetMethod, GetConstructor): Use our
28145 implementation of FindMembers to find the members, since during
28146 corlib compilation, the types are TypeBuilders and GetMethod and
28147 GetConstructor do not work.
28149 Make all methods in TypeManager static.
28151 (InitCodeHelpers): Split the functionality from
28152 the InitCodeTypes function.
28154 * driver.cs: Call InitCodeHelpers after we have populated the
28157 * cs-parser.jay (delegate_declaration): we did not used to compute
28158 the delegate name correctly for void delegates.
28160 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28162 * rootcontext.cs (RootContext): Init the interface_resolve_order
28163 and type_container_resolve_order always.
28165 (ResolveCore, BootstrapCorlib_ResolveClass,
28166 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28167 compiler when compiling with --nostdlib
28169 * class.cs (TypeContainer.DefineType): Check that our parent is
28170 not null. This test is most important when we are bootstraping
28173 * codegen.cs: Split out the symbol writing code.
28175 2002-03-25 Martin Baulig <martin@gnome.org>
28177 * driver.cs (-g): Made -g an alias for --debug.
28179 2002-03-24 Martin Baulig <martin@gnome.org>
28181 * codegen.cs (SymbolWriter): New public variable. Returns the
28182 current symbol writer.
28183 (CodeGen): Added `bool want_debugging_support' argument to the
28184 constructor. If true, tell the ModuleBuild that we want debugging
28185 support and ask it for the ISymbolWriter.
28186 (Save): If we have a symbol writer, call it's Close() method after
28187 saving the assembly.
28189 * driver.c (--debug): New command line argument to create a
28190 debugger information file.
28192 * location.cs (SymbolDocument): New public property. Returns an
28193 ISymbolDocumentWriter object for the current source file or null
28194 if we don't have a symbol writer.
28196 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28198 * driver.cs (LoadAssembly): Correctly return when all the paths
28199 have been tried and not before.
28201 * statement.cs (Switch.Emit): return the actual coverage for this
28202 statement (returns/not-returns)
28204 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28205 switch of the statement if we are the last switch section. That
28206 kills two problems: try/catch problems (we used to emit an empty
28207 nop at the end) and switch statements where all branches would
28210 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28212 * driver.cs: Add default assemblies (the equivalent to the
28213 Microsoft CSC.RSP file)
28215 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28216 also update tokens_seen and set it to false.
28218 * driver.cs: Implement --recurse for Mike.
28220 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28221 correctly splitting out the paths.
28223 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28225 * interface.cs (Interface.PopulateProperty): Instead of using
28226 `parent' as the declaration space for the set parameters, use
28229 * support.cs (InternalParameters): InternalParameters constructor
28230 takes a DeclSpace instead of a TypeContainer.
28232 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28233 types are being initialized, load the address of it before calling
28236 (New): Provide a mechanism to disable the generation of local
28237 value type temporaries when the caller will be providing us with
28238 an address to store it.
28240 (ArrayCreation.EmitDynamicInitializers): Use it.
28242 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28244 * expression.cs (Invocation.EmitArguments): Only probe for array
28245 property if there is more than one argument. Sorry about that.
28247 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28248 empty param arrays.
28250 * class.cs (Method.LabelParameters): Fix incorrect code path that
28251 prevented the `ParamArrayAttribute' from being applied to the
28254 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28256 * support.cs (ReflectionParameters): Correctly compute whether the
28257 last argument is a params array. Fixes the problem with
28260 * typemanager.cs: Make the assemblies array always be non-null
28261 (empty, but non-null)
28263 * tree.cs (RecordDecl): New function that abstracts the recording
28264 of names. This reports error 101, and provides a pointer to the
28265 previous declaration. Fixes a crash in the compiler.
28267 * cs-parser.jay (constructor_declaration): Update to new grammar,
28268 and provide a constructor_body that can be empty.
28270 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28272 * driver.cs: Add support for --resources.
28274 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28275 Make all types for the various array helper methods be integer.
28277 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28278 CheckState to ConvCast.
28280 (ConvCast): Now it takes a `checked' state argument, to avoid
28281 depending on the emit context for the conversion, and just using
28282 the resolve time setting.
28284 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28285 instead of Invocation.EmitArguments. We do not emit the original
28286 arguments, instead we emit those which have been converted to
28287 unsigned int expressions.
28289 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28291 * codegen.cs: ditto.
28293 * expression.cs (LocalVariableReference): Drop the use of the
28294 Store function that depended on the variable index.
28296 * statement.cs (VariableInfo): Drop the `Idx' property from this
28297 class, as this is not taking into account the indexes for
28298 temporaries tat we generate during the execution, getting the
28301 * class.cs: First emit class initializers, then call the parent
28304 * expression.cs (Binary): Fix opcode emision.
28305 (UnaryMutator.EmitCode): Support checked code generation
28307 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28308 matches for events for both the Static and Instance scans,
28309 pointing to the same element. Fix that.
28311 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28313 * rootcontext.cs (ResolveTree): Always set the
28314 interface_resolve_order, because nested interfaces will be calling
28317 * class.cs (GetInterfaceOrClass): Track the same resolution
28318 process used by TypeManager.LookupType. This fixes the nested
28319 type lookups in class declarations (separate path from
28322 (TypeContainer.DefineType): Also define nested interfaces.
28323 (TypeContainer.RegisterOrder): New public function used to
28324 register the order in which child interfaces need to be closed.
28326 Nested interfaces need to be closed after their parents have been
28329 * interface.cs (InterfaceAttr): Put all the logic for computing
28330 the interface attribute here.
28332 (DefineInterface): Register our interface order with the
28333 RootContext or with the TypeContainer depending on the case.
28335 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28337 * cs-parser.jay: rework foreach statement to work with the new
28338 changes to the policy on SimpleNames.
28340 * report.cs: support Stacktrace on warnings as well.
28342 * makefile: drop --unsafe and /unsafe from the compile.
28344 2002-03-13 Ravi Pratap <ravi@ximian.com>
28346 * ecore.cs (StandardConversionExists): Modify to take an Expression
28347 as the first parameter. Ensure we do null -> reference type conversion
28350 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28351 temporary Expression objects.
28353 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28355 * interface.cs: workaround bug in method overloading resolution
28356 (there is already a bugzilla bug for it).
28358 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28360 We could also solve this problem by having a separate path for
28361 performing type lookups, instead of DoResolve, we could have a
28362 ResolveType entry point, and only participating pieces of the
28363 production (simplename, deref, array) would implement this.
28365 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28366 signal SimpleName to only resolve type names and not attempt to
28367 resolve anything else.
28369 * expression.cs (Cast): Set the flag.
28371 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28373 * class.cs: Only report 108 if there is no `new' modifier.
28375 * cs-parser.jay: rework foreach statement to work with the new
28376 changes to the policy on SimpleNames.
28378 * report.cs: support Stacktrace on warnings as well.
28380 * makefile: drop --unsafe and /unsafe from the compile.
28382 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28384 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28385 lookups here, instead of doing that at parse time. This means
28386 that our grammar will not introduce `LocalVariableReferences' as
28387 expressions at this point. That solves the problem of code like
28391 static void Main ()
28395 This is only half the fix. The full fix requires parameters to
28396 also be handled in this way.
28398 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28399 makes the use more obvious of the DeclSpace. The
28400 ec.TypeContainer.TypeBuilder is now only used to pull the
28401 TypeBuilder for it.
28403 My theory is that I can get rid of the TypeBuilder completely from
28404 the EmitContext, and have typecasts where it is used (from
28405 DeclSpace to where it matters).
28407 The only pending problem is that the code that implements Aliases
28408 is on TypeContainer, and probably should go in DeclSpace.
28410 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28411 lookups here, instead of doing that at parse time. This means
28412 that our grammar will not introduce `LocalVariableReferences' as
28413 expressions at this point. That solves the problem of code like
28417 static void Main ()
28421 This is only half the fix. The full fix requires parameters to
28422 also be handled in this way.
28424 * class.cs (Property.DefineMethod): When implementing an interface
28425 method, set newslot, when implementing an abstract method, do not
28426 set the flag (before we tried never setting it, or always setting
28427 it, which is the difference).
28428 (Indexer.DefineMethod): same.
28429 (Method.DefineMethod): same.
28431 * ecore.cs: Only set the status used flag if we get back a Field.
28433 * attribute.cs: Temporary hack, so Paolo can keep working.
28435 2002-03-08 Ravi Pratap <ravi@ximian.com>
28437 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28438 the unmanaged type in the case we have a MarshalAs attribute.
28440 (Resolve): Handle the case when we are parsing the special MarshalAs
28441 attribute [we need to store the unmanaged type to use later]
28443 * typemanager.cs (marshal_as_attr_type): Built in type for the
28444 MarshalAs Attribute.
28446 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28447 on parameters and accordingly set the marshalling info.
28449 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28451 * class.cs: Optimizing slightly by removing redundant code after
28452 we switched to the `NoTypes' return value.
28453 (Property.DefineMethod): use NoTypes here too.
28455 This fixes the bug I introduced in my last batch of changes.
28457 2002-03-05 Ravi Pratap <ravi@ximian.com>
28459 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28461 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28462 Enums since those are types too.
28464 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28466 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28467 thanks to a call during the lookup process.
28469 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28471 * statement.cs (Foreach): Lots of work to accomodate a particular
28472 kind of foreach statement that I had not kept in mind. It is
28473 possible to have foreachs on classes that provide a GetEnumerator
28474 method that return objects that implement the "pattern" for using
28475 a foreach, there is no need to support GetEnumerator
28478 This is needed to compile nant.
28480 * decl.cs: Only report 114 if the member is not `Finalize' and if
28481 the warning level is at least 2.
28483 * class.cs: Moved the compare function from Method to
28486 (MethodSignature.InheritableMemberSignatureCompare): Add new
28487 filter function that is used to extract inheritable methods from a
28490 (Method.Define): Use the new `inheritable_method_signature_filter'
28493 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28496 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28498 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28500 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28502 * expression.cs: Pass location information to
28503 ConvertImplicitStandard.
28505 * class.cs: Added debugging code to track return values from
28508 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28510 * expression.cs (Is.DoResolve): If either side of the `is' is an
28511 interface, do not flag the warning.
28513 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28516 * report.cs: Allow for --fatal to be used with --probe.
28518 * typemanager.cs (NoTypes): Move the definition for the empty Type
28521 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28523 (TypeContainer.DefineProxy): New function used to proxy to parent
28524 implementations when implementing interfaces.
28525 (TypeContainer.ParentImplements): used to lookup if our parent
28526 implements a public function that is required by an interface.
28527 (TypeContainer.VerifyPendingMethods): Hook this up.
28529 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28530 `modules' and `assemblies' arraylists into arrays. We only grow
28531 these are the very early start up of the program, so this improves
28532 the speedof LookupType (nicely measured).
28534 * expression.cs (MakeByteBlob): Replaced unsafe code with
28535 BitConverter, as suggested by Paolo.
28537 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28538 folding of string concatenation, but if either side is a string,
28539 and the other is not, then return null, and let the runtime use
28540 the concatenation on the string plus the object (using
28541 `Object.ToString').
28543 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28545 Constant Folding has been implemented now.
28547 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28548 the error instead on types that are not supported in one's
28551 * constant.cs (Constant and all children): New set of functions to
28552 perform implict and explicit conversions.
28554 * ecore.cs (EnumConstant): Implement the new functions to perform
28555 conversion by proxying to the child expression.
28557 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28558 own separate setting that can not be turned off from the command
28559 line using --unchecked or --checked and is only controlled using
28560 the checked/unchecked statements and expressions. This setting is
28561 used by the constant folder to flag errors.
28563 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28564 ConstantCheckState as well.
28566 During Resolve, they also have to flag the state, because the
28567 constant folder runs completely in the Resolve phase.
28569 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28572 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28574 * cfold.cs: New file, this file contains the constant folder.
28576 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28577 argument to track whether we are using the resulting address to
28578 load or store a value and provide better error messages.
28580 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28581 new AddressOf arguments.
28583 * statement.cs (Foreach.EmitCollectionForeach): Update
28585 * expression.cs (Argument.Emit): Call AddressOf with proper
28586 arguments to track usage.
28588 (New.DoEmit): Call AddressOf with new arguments.
28590 (Unary.Emit): Adjust AddressOf call.
28592 2002-03-01 Ravi Pratap <ravi@ximian.com>
28594 * cs-parser.jay (member_access): Change the case for pre-defined types
28595 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28598 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28601 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28602 essentially like methods and apply attributes like MethodImplOptions to them too.
28604 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28607 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28608 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28611 * Update code everywhere accordingly.
28613 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28615 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28617 2002-02-28 Ravi Pratap <ravi@ximian.com>
28619 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28620 try performing lookups against those instead of jumping straight into using
28621 the 'using' clauses.
28623 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28625 (LookupType): Perform lookups in implicit parents too.
28627 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28628 sequence as RootContext.LookupType.
28630 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28631 the various cases of namespace lookups into this method.
28633 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28635 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28636 in positional arguments)
28638 * class.cs (Operator): Update the AllowedModifiers to contain
28641 * cs-parser.jay: Update operator declaration to allow for the
28642 operator body to be empty.
28644 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28647 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28649 * class.cs (Method.Emit): Label parameters.
28651 * driver.cs: Return 1 or 0 as the program exit code.
28653 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28655 * expression.cs: Special case the `null' object when trying to
28656 auto-compute the type, as anything can be explicitly converted to
28659 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28660 spotting this Paolo.
28662 (Expression.ImplicitNumericConversion): Perform comparissions of
28663 the type using the underlying type in the case of an enumeration
28664 rather than using the enumeration type for the compare.
28666 Cope with the underlying == type case, which is not possible to
28669 (Expression.ConvertNumericExplicit): Perform comparissions of
28670 the type using the underlying type in the case of an enumeration
28671 rather than using the enumeration type for the compare.
28673 * driver.cs: If the user does not supply an extension, assume .exe
28675 * cs-parser.jay (if_statement): Rewrote so that we can track the
28676 location for the if statement.
28678 * expression.cs (Binary.ConstantFold): Only concat strings when
28679 the operation is "+", not everything ;-)
28681 * statement.cs (Statement.EmitBoolExpression): Take a location
28683 (If, While, Do): Track location.
28685 * expression.cs (Binary.ResolveOperator): In the object + string
28686 case, I was missing a call to ConvertImplicit
28688 2002-02-25 Ravi Pratap <ravi@ximian.com>
28690 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28691 Location arguments. Ensure we use RootContext.LookupType to do our work
28692 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28694 * interface.cs (PopulateMethod): Handle the type of the parameter being
28697 * expression.cs (Invocation.BetterFunction): Handle the case when we
28698 have a params method with no fixed arguments and a call is made with no
28701 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28703 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28704 the verbatim-string-literal
28706 * support.cs (InternalParameters.ParameterModifier): handle null
28708 (InternalParameters.ParameterType): ditto.
28710 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28711 duplicating the name of the variable parameter.
28712 (GetParameterByName): Fix bug where we were not looking up array
28713 paramters if they were the only present (thanks Paolo!).
28714 (GetParameterInfo): We only have an empty set of types if both
28715 fixed and array are set to null.
28716 (GetParameterInfo-idx): Handle FixedParameter == null
28718 * cs-parser.jay: Handle the case where there is no catch
28719 statements (missing null test).
28721 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28723 * driver.cs (MainDriver): Be conservative on our command line
28726 Catch DirectoryNotFoundException when calling GetFiles.
28728 (SplitPathAndPattern): Used to split the input specification into
28729 a path and a pattern that we can feed to Directory.GetFiles.
28731 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28733 * statement.cs (Fixed): Implement the last case of the Fixed
28734 statement (string handling).
28736 * expression.cs (StringPtr): New class used to return a char * to
28737 a string; Used by the Fixed statement.
28739 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28741 * expression.cs (Binary.ResolveOperator): Remove redundant
28742 MemberLookup pn parent type.
28743 Optimize union call, we do not need a union if the types are the same.
28744 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28747 Specialize the use of MemberLookup everywhere, instead of using
28748 the default settings.
28750 (StackAlloc): Implement stackalloc keyword.
28752 * cs-parser.jay: Add rule to parse stackalloc.
28754 * driver.cs: Handle /h, /help, /?
28756 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28757 before we supported unsafe code.
28759 * makefile: add --unsafe to the self compilation of mcs.
28761 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28763 * expression.cs (PointerArithmetic): New class that is used to
28764 perform pointer arithmetic.
28765 (Binary.Resolve): Handle pointer arithmetic
28766 Handle pointer comparission.
28767 (ArrayPtr): Utility expression class that is used to take the
28768 address of an array.
28770 (ElementAccess): Implement array access for pointers
28772 * statement.cs (Fixed): Implement fixed statement for arrays, we
28773 are missing one more case before we are done.
28775 * expression.cs (Indirection): Implement EmitAssign and set the
28776 ExprClass to Variable. This allows pointer dereferences to be
28777 treated as variables, and to have values assigned to them.
28779 * ecore.cs (Expression.StoreFromPtr): New utility function to
28780 store values dereferencing.
28782 2002-02-20 Ravi Pratap <ravi@ximian.com>
28784 * expression.cs (Binary.ResolveOperator): Ensure that we are
28785 not trying to operate on a void type - this fixes the reported
28788 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28789 the parent implementation is sealed.
28791 * ../errors/cs0239.cs : Add.
28793 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28795 * typemanager.cs (unverifiable_code_type): Corresponds to
28796 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28797 which have unsafe code in them.
28799 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28802 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28804 * cs-tokenizer.cs: Add support for @"litreal strings"
28806 Make tokenizer accept pre-processor directives
28807 on any column (remove the old C-like limitation).
28809 * rootcontext.cs (EmitCode): Emit any global attributes.
28810 (AddGlobalAttributes): Used to keep track of assembly attributes.
28812 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28814 * cs-parser.jay: Add support for global attributes.
28816 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28818 * expression.cs (Indirection): New helper class. Unary will
28819 create Indirection classes to be able to implement the
28820 IMemoryLocation interface on it.
28822 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28824 * cs-parser.jay (fixed_statement): reference the right statement.
28826 * statement.cs (Fixed.Emit): Finish implementing the fixed
28827 statement for the &x case.
28829 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28831 * class.cs (Property.Define, Method.Define): Remove newslot when
28834 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28835 wrong. NewSlot should only be used if the `new' keyword is present.
28837 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28838 locating our system dir. Sorry about this.
28840 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28842 * driver.cs (GetSystemDir): Compute correctly the location of our
28843 system assemblies. I was using the compiler directory instead of
28844 the library directory.
28846 2002-02-13 Ravi Pratap <ravi@ximian.com>
28848 * expression.cs (BetterFunction): Put back in what Miguel commented out
28849 since it is the correct fix. The problem is elsewhere ;-)
28851 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28852 parameters of the parms method are themselves compatible or not !
28854 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28855 to check that a class implements an interface before saying that an implicit
28856 conversion was allowed. Use ImplementsInterface to do the checking.
28858 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28860 * class.cs (Method.Define): Track whether we are an explicit
28861 implementation or not. And only call DefineMethodOverride if we
28862 are an explicit implementation.
28864 (Property.DefineMethod): Ditto.
28866 2002-02-11 Ravi Pratap <ravi@ximian.com>
28868 * expression.cs (BetterFunction): Catch hideous bug which was
28869 preventing us from detecting ambiguous calls due to implicit casts i.e
28872 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28874 * support.cs (Pair): Remove un-needed method. I figured why I was
28875 getting the error in cs-parser.jay, the variable in a foreach loop
28876 is readonly, and the compiler does not really treat this as a variable.
28878 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28879 instead of EQUALS in grammar.
28881 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28883 * expression.cs (Unary.DoResolve): Check whether the argument is
28886 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28888 * support.cs: Api for Pair to set a value. Despite the fact that
28889 the variables are public the MS C# compiler refuses to compile
28890 code that accesses the field if the variable is part of a foreach
28893 * statement.cs (Fixed): Begin implementation of the fixed
28896 (Block.AddVariable): Return the VariableInfo on success and null
28897 on failure instead of true/false.
28899 * cs-parser.jay (foreach): Catch errors on variables already
28900 defined (we were ignoring this value before) and properly unwind
28901 the block hierarchy
28903 (fixed_statement): grammar for the fixed statement.
28905 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28907 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28908 pointer types to be incretemented.
28910 (SizeOf): Implement.
28912 * cs-parser.jay (pointer_member_access): Implement
28913 expr->IDENTIFIER production.
28915 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28916 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28919 (Unary): Implement indirection.
28921 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28922 use in non-unsafe context).
28924 (SimpleName.DoResolve): Check for pointers in field access on safe
28927 (Expression.LoadFromPtr): Factor the load-indirect code in this
28928 function. This was duplicated in UnboxCast and ParameterReference
28930 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28932 * expression.cs (ComposedCast): report an error if a pointer cast
28933 is used in a safe region.
28935 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28936 pointer type casts in unsafe context.
28938 * codegen.cs (EmitContext): Set up IsUnsafe.
28940 * cs-parser.jay (non_expression_type): Add productions for pointer
28943 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28944 code. We should not use force into static mode if the method is
28945 not virtual. Fixes bug in MIS
28947 * statement.cs (Do.Emit, While.Emit, For.Emit,
28948 Statement.EmitBoolExpression): Add support to Do and While to
28949 propagate infinite loop as `I do return' semantics.
28951 Improve the For case to also test for boolean constants.
28953 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28954 to the list of attributes we can add.
28956 Remove `EmitContext' argument.
28958 * class.cs (Method.Define): Apply parameter attributes.
28959 (Constructor.Define): Apply parameter attributes.
28960 (MethodCore.LabelParameters): Move here the core of labeling
28963 * support.cs (ReflectionParameters.ParameterModifier,
28964 InternalParameters.ParameterModifier): Use IsByRef on the type and
28965 only return the OUT bit for these parameters instead of in/out/ref
28968 This is because I miss-understood things. The ParameterInfo.IsIn
28969 and IsOut represent whether the parameter has the [In] and [Out]
28972 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28974 * ecore.cs (FieldExpr.Emit): Release temporaries.
28976 * assign.cs (LocalTemporary.Release): new function.
28978 * codegen.cs (EmitContext.GetTemporaryStorage,
28979 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28980 temporary storage. Now we can "put back" localbuilders when we
28983 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28985 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28986 need to make a copy of the variable to generate verifiable code.
28988 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28990 * driver.cs: Compute dynamically the system directory.
28992 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28993 Slower, but more generally useful. Used by the abstract
28994 registering implementation.
28996 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28997 the rules for the special rule on Type/instances. First check if
28998 we have the same name, and if so, try that special static path
28999 rather than the instance path.
29001 2002-01-18 Miguel de Icaza <miguel@ximian.com>
29003 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
29006 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
29007 Enum, ValueType, Delegate or Array for non-corlib compiles.
29009 * cs-tokenizer.cs: Catch long identifiers (645)
29011 * typemanager.cs (IndexerPropetyName): Ravi never tested this
29014 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
29015 fix, we were returning too early, so we were not registering
29016 pending methods from abstract classes.
29018 Do not register pending methods if the class is abstract.
29020 * expression.cs (Conditional.DoResolve): Report circular implicit
29021 conversions when we neecd to compute it for conditional
29024 (Is.DoResolve): If the expression is always of the provided type,
29025 flag warning 183. If the expression can not ever be of the
29026 provided type flag warning 184.
29028 * class.cs: Catch 169 as well.
29030 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
29033 2002-01-18 Nick Drochak <ndrochak@gol.com>
29035 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
29037 2002-01-17 Miguel de Icaza <miguel@ximian.com>
29039 * interface.cs: (PopulateMethod): Check for pointers being defined
29040 only if the unsafe context is active.
29041 (PopulateProperty): ditto.
29042 (PopulateIndexer): ditto.
29044 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
29045 specified. If pointers are present, make sure that they are
29046 present in an unsafe context.
29047 (Constructor, Constructor.Define): ditto.
29048 (Field, Field.Define): ditto.
29049 (Property, Property.Define): ditto.
29050 (Event, Event.Define): ditto.
29052 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29053 hashtable if there are classes or structs defined.
29055 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29056 code, as the constant resolution moved.
29058 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29059 the metadata, so we can flag error 133.
29061 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29062 pointer is being declared in an unsafe context.
29064 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29066 * modifiers.cs (Modifiers.Check): Require a Location argument.
29067 Report error 227 for Unsafe use.
29069 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29071 * statement.cs (For.Emit): If the test is null, then report that
29072 we do `return', as we wont reach anything afterwards.
29074 (Switch.SwitchGoverningType): Track the expression that matched
29077 * driver.cs: Allow negative numbers as an error code to flag.
29079 * cs-parser.jay: Handle 1551.
29081 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29083 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29085 * cs-parser.jay: Report 1518 (type declaration can only contain
29086 class, struct, interface, enum or delegate)
29088 (switch_label): Report 1523 (keywords `case' or `default' must
29091 (opt_switch_sections): Report 1522 (empty switch)
29093 * driver.cs: Report 1515 (response file specified multiple times)
29094 Report 1516 (Source file specified multiple times).
29096 * expression.cs (Argument.Resolve): Signal 1510
29098 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29099 access not allowed in static code)
29101 2002-01-11 Ravi Pratap <ravi@ximian.com>
29103 * typemanager.cs (IsPointerType): Utility method which we are going
29106 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29107 the object type, so we take care of that.
29109 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29111 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29112 added to non-params parameters :-)
29114 * typemanager.cs (CSharpName): Include 'void' type too.
29116 (void_ptr_type): Include in the set of core types.
29118 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29121 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29124 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29125 completely forgotten about it.
29127 2002-01-10 Ravi Pratap <ravi@ximian.com>
29129 * cs-parser.jay (pointer_type): Add. This begins our implementation
29130 of parsing rules for unsafe code.
29132 (unsafe_statement): Implement.
29134 (embedded_statement): Modify to include the above.
29136 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29138 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29139 if the current context is an unsafe one.
29141 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29142 are handled differently, we need separate rules for them.
29144 (local_variable_declaration): Update to use local_variable_pointer_type
29145 to allow variable declarations of unmanaged pointer types.
29147 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29148 in unsafe contexts.
29150 * ../errors/cs0214.cs : Add.
29152 2002-01-16 Nick Drochak <ndrochak@gol.com>
29154 * makefile: remove 'response' file when cleaning.
29156 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29158 * cs-parser.jay: Report 1524.
29160 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29162 * typemanager.cs (RegisterMethod): drop checking if we have
29163 registered this from here
29165 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29167 * class.cs (Method.EmitDestructor): Implement calling our base
29170 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29171 value of InFinally.
29173 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29174 this routine and will wrap the call in a try/catch block. Deal
29177 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29179 * ecore.cs (Expression.MemberLookup): instead of taking a
29180 parameter `same_type' that was used to tell whether we could
29181 access private members we compute our containing type from the
29184 (FieldExpr): Added partial support for volatile fields. This does
29185 not work for volatile fields exposed from assemblies, as I can not
29186 figure out how to extract the modreq from it.
29188 Updated all the source files to use this.
29190 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29191 because it is referenced by MemberLookup very often.
29193 2002-01-09 Ravi Pratap <ravi@ximian.com>
29195 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29196 TypeBuilder.GetCustomAttributes to retrieve what we need.
29198 Get rid of redundant default_member_attr_type as this is the same as
29199 default_member_type which already exists.
29201 * interface.cs, attribute.cs : Update accordingly.
29203 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29205 * typemanager.cs: Enable IndexerPropertyName again. It does not
29206 work for TYpeBuilders though. Ravi, can you please fix this?
29208 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29210 * expression.cs (Argument.Emit): Handle the case of ref objects
29211 being passed to ref functions;
29213 (ParameterReference.EmitLoad): Loads the content of the pointer
29214 without dereferencing.
29216 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29218 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29220 2002-01-08 Ravi Pratap <ravi@ximian.com>
29222 * class.cs (Indexer.DefineMethod): Incorporate the interface
29223 type in the name of the method if we are doing explicit interface
29226 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29228 (BetterConversion): Fix extremely trivial bug where we were referring to
29229 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29232 * ../errors/bug16.cs : Add although we have fixed it.
29234 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29236 * expression.cs (BaseIndexer): Begin implementation.
29238 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29240 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29241 production directly to remove a shift/reduce, and implement
29242 explicit interface implementation.
29244 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29245 after a floating point suffix.
29247 * expression.cs (DoNumericPromotions): Improved the conversion for
29248 uint/uint. If we have a constant, we avoid doing a typecast to a
29251 * class.cs (Indexer): Implement explicit interface implementation
29254 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29256 * class.cs: make the default instance constructor public and hidebysig.
29258 2001-01-03 Ravi Pratap <ravi@ximian.com>
29260 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29261 so we can call it from elsewhere.
29263 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29264 we emit it internally if the class has a defined indexer; otherwise the user
29265 emits it by decorating the class definition with the DefaultMemberAttribute.
29267 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29268 attribute is not used on a type which defines an indexer.
29270 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29271 character when we skip whitespace.
29273 * ../errors/cs0646.cs : Add.
29275 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29277 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29280 * makefile: Add practical target `mcs3.exe' which builds the third
29281 generation compiler.
29283 * expression.cs (New): Fix structures constructor calling.
29285 * class.cs (Property, Method, Indexer): Emit Final flag on the
29286 method if we are an interface implementation and we are not
29289 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29290 whether this property is referencing a `base' method.
29292 * expression.cs (Invocation.EmitCall): take an extra argument:
29293 is_base, this is used to determine whether the `call' or
29294 `callvirt' opcode should be used.
29297 * delegate.cs: update EmitCall.
29299 * class.cs (Method.Define): Set NewSlot for the cases where we are
29300 not implementing an interface method.
29302 (Property.Define): ditto.
29304 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29306 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29307 'r'. Allows mcs to parse itself fully.
29309 2002-01-02 Ravi Pratap <ravi@ximian.com>
29311 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29312 of the number of initializers that require the InitializeArray method.
29314 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29315 update the above field where necessary.
29317 (MakeByteBlob): Update accordingly.
29319 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29322 (EmitDynamicInitializers): Update in accordance with the new optimization.
29324 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29325 same OpCode applies.
29327 * cs-parser.jay : Fix some glaring errors I introduced.
29329 2002-01-01 Ravi Pratap <ravi@ximian.com>
29331 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29332 so that we can check for name clashes there too.
29334 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29335 for interface indexers.
29337 * interfaces.cs (Define): Emit the default member attribute.
29339 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29340 variable was being referred to while setting the value ;-)
29342 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29344 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29345 byte-by-byte information when we know the data is zero.
29347 Make the block always a multiple of 4, because
29348 DefineInitializedData has a bug.
29350 * assign.cs: Fix, we should assign from the temporary, not from
29353 * expression.cs (MakeByteBlob): Fix my incorrect code.
29355 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29357 * typemanager.cs (EnumToUnderlying): This function is used to get
29358 the underlying type from an enumeration, because it does not
29361 * constant.cs: Use the I4_S form for values between -128 and 127.
29363 * statement.cs (Block.LookupLabel): Looks up a label.
29364 (Block): Drop support for labeled blocks.
29366 (LabeledStatement): New kind of statement that represents a label
29369 (Goto): Finally implement this bad boy.
29371 * cs-parser.jay: Update to reflect new mechanism to implement
29374 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29376 * codegen.cs (EmitContext.This): a codegen property that keeps the
29377 a single instance of this instead of creating many different this
29380 * delegate.cs (Delegate.DoResolve): Update to use the property;
29382 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29384 * expression.cs (BaseAccess.DoResolve): Ditto.
29386 2001-12-29 Ravi Pratap <ravi@ximian.com>
29388 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29389 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29391 (InitCoreTypes): Update accordingly.
29393 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29394 so we can quickly store the state.
29396 (ApplyAttributes): Set the correct implementation flags
29397 for InternalCall methods.
29399 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29401 * expression.cs (EmitCall): if a method is not virtual, then do
29402 not use callvirt on it.
29404 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29405 user defined stuff) requires the use of stobj, which takes an
29406 address on the stack instead of an array and an index. So emit
29407 the Ldelema operation for it.
29409 (EmitStoreOpcode): Use stobj for valuetypes.
29411 (UnaryMutator.EmitCode): Use the right 1 value depending on
29412 whether we are dealing with int64/uint64, float or doubles.
29414 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29415 constructors that I implemented last night.
29417 (Constructor.IsDefault): Fix to work properly for static
29420 * cs-parser.jay (CheckDef): report method signature errors.
29421 Update error number 103 to be 132.
29423 * decl.cs: New AdditionResult enumeration value: MethodExists.
29424 Although we do this check for methods later on in the semantic
29425 analysis, catching repeated default constructors is so easy that
29426 we catch these here.
29428 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29431 (ParameterReference.EmitAssign, Emit): handle
29434 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29435 (ArrayAccess.EmitStoreOpcode): ditto.
29437 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29439 * expression.cs (MakeByteBlob): Complete all the missing types
29440 (uint, short, ushort, byte, sbyte)
29442 * class.cs: Only init instance field initializers on instance
29445 Rename `constructors' to instance_constructors.
29447 (TypeContainer.AddConstructor): Only add constructors to the list
29448 if it is not static.
29450 Make sure that we handle default_static_constructor independently
29451 everywhere where we handle instance_constructors
29453 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29455 * class.cs: Do not lookup or create a base initializer for a
29456 static constructor.
29458 (ConstructorInitializer.Resolve): use the proper type to lookup
29461 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29463 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29466 * decl.cs: CloseType is now an virtual method, the default
29467 implementation just closes this type.
29469 2001-12-28 Ravi Pratap <ravi@ximian.com>
29471 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29472 to PreserveSig by default. Also emit HideBySig on such methods.
29474 Basically, set the defaults to standard values.
29476 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29477 argument, if candidate is better, it can't be worse than the best !
29479 (Invocation): Re-write bits to differentiate between methods being
29480 applicable in their expanded form and their normal form - for params
29483 Get rid of use_standard everywhere as only standard conversions are allowed
29484 in overload resolution.
29486 More spec conformance.
29488 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29490 * driver.cs: Add --timestamp, to see where the compiler spends
29493 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29494 `this' in static code.
29496 (SimpleName.DoResolve): Implement in terms of a helper function
29497 that allows static-references to be passed upstream to
29500 (Expression.ResolveWithSimpleName): Resolve specially simple
29501 names when called by MemberAccess to implement the special
29504 (Expression.ImplicitReferenceConversion): Handle conversions from
29505 Null to reference types before others, as Null's type is
29508 * expression.cs (Invocation.EmitCall): Handle the special case of
29509 calling methods declared on a reference type from a ValueType
29510 (Base classes System.Object and System.Enum)
29512 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29513 the left hand side is a TypeExpr, not on every enumeration.
29515 (Binary.Resolve): If types are reference types, then do a cast to
29516 object on operators != and == of both arguments.
29518 * typemanager.cs (FindMembers): Extract instance and static
29519 members if requested.
29521 * interface.cs (PopulateProperty): Use void_type instead of null
29522 as the return type for the setter method.
29524 (PopulateIndexer): ditto.
29526 2001-12-27 Ravi Pratap <ravi@ximian.com>
29528 * support.cs (ReflectionParameters): Fix minor bug where we
29529 were examining the wrong parameter for the ParamArray attribute.
29531 Cope with requests for the type of the parameter at position
29532 greater than the params parameter's. We now return the element
29533 type of the params array as that makes more sense.
29535 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29536 accordingly as we no longer have to extract the element type
29539 (Invocation.OverloadResolve): Update.
29541 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29543 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29544 against IEnumerator, test whether the return value is a descendant
29545 of the IEnumerator interface.
29547 * class.cs (Indexer.Define): Use an auxiliary method to implement
29548 the other bits of the method definition. Begin support for
29549 explicit interface implementation.
29551 (Property.DefineMethod): Use TypeManager.void_type instead of null
29552 for an empty return value.
29554 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29556 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29557 dealing with a FieldExpr which is composed of a FieldBuilder, in
29558 the code path we did extract the constant, but we should have
29559 obtained the underlying value to be able to cast it (otherwise we
29560 end up in an infinite loop, this is what Ravi was running into).
29562 (ArrayCreation.UpdateIndices): Arrays might be empty.
29564 (MemberAccess.ResolveMemberAccess): Add support for section
29565 14.5.4.1 that deals with the special case of E.I when E is a type
29566 and something else, that I can be a reference to a static member.
29568 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29569 handle a particular array type to create byte blobs, it is just
29570 something we dont generate byteblobs for.
29572 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29575 * location.cs (Push): remove the key from the hashtable that we
29576 are about to add. This happens for empty files.
29578 * driver.cs: Dispose files after we have parsed them.
29580 (tokenize): new function that only runs the tokenizer on its
29581 input, for speed testing.
29583 2001-12-26 Ravi Pratap <ravi@ximian.com>
29585 * class.cs (Event.Define): Define the private field only if there
29586 are no accessors defined.
29588 * expression.cs (ResolveMemberAccess): If there is no associated
29589 field with the event, that means we have an event defined with its
29590 own accessors and we should flag error cs0070 since transforming
29591 ourselves into a field is not valid in that case.
29593 * ecore.cs (SimpleName.DoResolve): Same as above.
29595 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29596 and charset to sane values.
29598 2001-12-25 Ravi Pratap <ravi@ximian.com>
29600 * assign.cs (DoResolve): Perform check on events only if they
29601 are being accessed outside the declaring type.
29603 * cs-parser.jay (event_declarations): Update rules to correctly
29604 set the type of the implicit parameter etc.
29606 (add_accessor, remove_accessor): Set current local parameters.
29608 * expression.cs (Binary): For delegate addition and subtraction,
29609 cast the return value from the method into the appropriate delegate
29612 2001-12-24 Ravi Pratap <ravi@ximian.com>
29614 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29615 of these as the workaround is unnecessary.
29617 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29618 delegate data - none of that is needed at all.
29620 Re-write bits to extract the instance expression and the delegate method
29623 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29626 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29627 of attaching attributes instead of duplicating code everywhere.
29629 * everywhere : Update code to do attribute emission using the above method.
29631 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29633 * expression.cs (IsParamsMethodApplicable): if there are not
29634 parameters, return immediately.
29636 * ecore.cs: The 0 literal can be implicity converted to an enum
29639 (SimpleName.DoResolve): First lookup the type, then lookup the
29642 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29643 want to get its address. If the InstanceExpression is not
29644 addressable, store the result in a temporary variable, then get
29647 * codegen.cs: Only display 219 errors on warning level or above.
29649 * expression.cs (ArrayAccess): Make it implement the
29650 IMemoryLocation interface.
29652 (Binary.DoResolve): handle the operator == (object a, object b)
29653 and operator != (object a, object b) without incurring into a
29654 BoxedCast (because 5 != o should never be performed).
29656 Handle binary enumerator operators.
29658 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29659 value type, otherwise use Ldelem_ref.
29661 Use precomputed names;
29663 (AddressOf): Implement address of
29665 * cs-parser.jay (labeled_statement): Fix recursive block
29666 addition by reworking the production.
29668 * expression.cs (New.DoEmit): New has a special case:
29670 If we are dealing with a ValueType, we have a few
29671 situations to deal with:
29673 * The target of New is a ValueType variable, that is
29674 easy, we just pass this as the variable reference
29676 * The target of New is being passed as an argument,
29677 to a boxing operation or a function that takes a
29680 In this case, we need to create a temporary variable
29681 that is the argument of New.
29684 2001-12-23 Ravi Pratap <ravi@ximian.com>
29686 * rootcontext.cs (LookupType): Check that current_type is not null before
29687 going about looking at nested types.
29689 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29690 not implement the IAssignMethod interface any more.
29692 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29693 where we tranform them into FieldExprs if they are being resolved from within
29694 the declaring type.
29696 * ecore.cs (SimpleName.DoResolve): Do the same here.
29698 * assign.cs (DoResolve, Emit): Clean up code considerably.
29700 * ../errors/bug10.cs : Add.
29702 * ../errors/cs0070.cs : Add.
29704 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29706 * assign.cs : Get rid of EventIsLocal everywhere.
29708 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29710 * ecore.cs (ConvertIntLiteral): finished the implementation.
29712 * statement.cs (SwitchLabel): Convert the value we are using as a
29713 key before looking up the table.
29715 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29717 * codegen.cs (EmitTopBlock): Require a Location argument now.
29719 * cs-parser.jay (constructor_declarator): We need to setup
29720 current_local_parameters before we parse the
29721 opt_constructor_initializer, to allow the variables to be bound
29722 to the constructor arguments.
29724 * rootcontext.cs (LookupType): First lookup nested classes in our
29725 class and our parents before we go looking outside our class.
29727 * expression.cs (ConstantFold): Extract/debox the values at the
29730 * rootcontext.cs (EmitCode): Resolve the constants first before we
29731 resolve the types. This is not really needed, but it helps debugging.
29733 * statement.cs: report location.
29735 * cs-parser.jay: pass location to throw statement.
29737 * driver.cs: Small bug fix.
29739 * report.cs: Updated format to be 4-zero filled digits.
29741 2001-12-22 Ravi Pratap <ravi@ximian.com>
29743 * expression.cs (CheckIndices): Fix minor bug where the wrong
29744 variable was being referred to ;-)
29746 (DoEmit): Do not call EmitStaticInitializers when the
29747 underlying type is System.Object.
29749 2001-12-21 Ravi Pratap <ravi@ximian.com>
29751 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29752 and do the usual workaround for SRE.
29754 * class.cs (MyEventBuilder.EventType): New member to get at the type
29755 of the event, quickly.
29757 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29759 * assign.cs (Assign.DoResolve): Handle the case when the target
29760 is an EventExpr and perform the necessary checks.
29762 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29765 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29767 (EventExpr): Set the type in the constructor itself since we
29768 are meant to be born fully resolved.
29770 (EventExpr.Define): Revert code I wrote earlier.
29772 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29773 instance expression is null. The instance expression is a This in that case
29774 or a null, depending on whether it is a static method or not.
29776 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29777 refers to more than one method.
29779 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29780 and accordingly flag errors.
29782 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29784 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29786 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29788 * location.cs (ToString): Provide useful rutine.
29790 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29792 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29793 objects, return the actual integral boxed.
29795 * statement.cs (SwitchLabel): define an ILLabel for each
29798 (Switch.CheckSwitch): If the value is a Literal, extract
29799 the underlying literal.
29801 Also in the unused hashtable we had, add the SwitchLabel so we can
29802 quickly look this value up.
29804 * constant.cs: Implement a bunch of new constants. Rewrite
29805 Literal based on this. Made changes everywhere to adapt to this.
29807 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29808 dereferencing array only once, and also copes with enumrations.
29810 bytes are two bytes wide, not one.
29812 (Cast): Perform constant conversions.
29814 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29815 wrappers to the literals here.
29817 * expression.cs (DoNumericPromotions): long literals can converted
29818 to ulong implicity (this is taken care of elsewhere, but I was
29819 missing this spot).
29821 * ecore.cs (Expression.Literalize): Make the return type Literal,
29822 to improve type checking.
29824 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29826 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29828 * literal.cs: Revert code from ravi that checked the bounds. The
29829 bounds are sane by the definition of the type itself.
29831 * typemanager.cs: Fix implementation of ImplementsInterface. We
29832 need to actually look up in our parent hierarchy for interfaces
29835 * const.cs: Use the underlying type for enumerations
29837 * delegate.cs: Compute the basename for the delegate creation,
29838 that should fix the delegate test case, and restore the correct
29839 Type Lookup semantics in rootcontext
29841 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29842 referencing a nested type with the Reflection API is using the "+"
29845 * cs-parser.jay: Do not require EOF token at the end.
29847 2001-12-20 Ravi Pratap <ravi@ximian.com>
29849 * rootcontext.cs (LookupType): Concatenate type names with
29850 a '.' instead of a '+' The test suite passes again.
29852 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29853 field of the enumeration.
29855 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29856 the case when the member is an EventExpr.
29858 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29859 static has an associated instance expression.
29861 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29863 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29865 * class.cs (Event.Define): Register event and perform appropriate checks
29868 We define the Add and Remove methods even if the use provides none because
29869 in that case, we provide default implementations ourselves.
29871 Define a private field of the type of the event. This is done by the CSC compiler
29872 and we should be doing it too ;-)
29874 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29875 More methods we use in code we generate.
29877 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29880 (InitCoreTypes): Update accordingly for the above.
29882 * class.cs (Event.Emit): Generate code for default accessors that we provide
29884 (EmitDefaultMethod): Do the job in the above.
29886 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29889 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29891 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29892 builders even if we were missing one.
29894 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29895 pass the Basename as our class name instead of the Name. The
29896 basename will be correctly composed for us.
29898 * parameter.cs (Paramters): Now takes a Location argument.
29900 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29901 make all the code call directly LookupType in RootContext and take
29902 this chance to pass the Location information everywhere.
29904 * Everywhere: pass Location information.
29906 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29908 * class.cs (Constructor.Define): Updated way of detecting the
29909 length of the parameters.
29911 (TypeContainer.DefineType): Use basename as the type name for
29914 (TypeContainer.Define): Do not recursively define types here, as
29915 definition is taken care in order by the RootContext.
29917 * tree.cs: Keep track of namespaces in a per-file basis.
29919 * parameter.cs (Parameter.ComputeSignature): Update to use
29922 (Parameters.GetSignature): ditto.
29924 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29925 instead of a TypeContainer.
29927 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29928 resolve names. Because we need to be resolve in our context, not
29931 * driver.cs: Implement response files.
29933 * class.cs (TypeContainer.DefineType): If we are defined, do not
29934 redefine ourselves.
29936 (Event.Emit): Emit the code for add/remove handlers.
29937 (Event.Define): Save the MethodBuilders for add/remove.
29939 * typemanager.cs: Use pair here too.
29941 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29942 DictionaryEntry requires the first argument to be non-null.
29944 (enum_declaration): Compute full name for registering the
29947 (delegate_declaration): Instead of using
29948 formal_parameter_list, use opt_formal_parameter_list as the list
29951 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29952 (EventParsing): New property that controls whether `add' and
29953 `remove' are returned as tokens or identifiers (for events);
29955 2001-12-19 Ravi Pratap <ravi@ximian.com>
29957 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29958 use MyEventBuilder only and let it wrap the real builder for us.
29960 (MyEventBuilder): Revamp constructor etc.
29962 Implement all operations that we perform on EventBuilder in precisely the same
29965 (FindMembers): Update to use the EventBuilder member.
29967 (Event.Emit): Update accordingly.
29969 2001-12-18 Ravi Pratap <ravi@ximian.com>
29971 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29972 by calling the appropriate methods.
29974 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29977 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29979 2001-12-17 Ravi Pratap <ravi@ximian.com>
29981 * delegate.cs (Delegate.Populate): Check that the return type
29982 and various parameters types are indeed accessible.
29984 * class.cs (Constructor.Define): Same here.
29986 (Field.Define): Ditto.
29988 (Event.Define): Ditto.
29990 (Operator.Define): Check that the underlying Method defined itself
29991 correctly - so it's MethodBuilder should not be null.
29993 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29994 expression happens to be null.
29996 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29997 members but as of now we don't seem to be able to do anything really useful with it.
29999 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
30000 not the EventBuilder.
30002 2001-12-18 Miguel de Icaza <miguel@ximian.com>
30004 * cs-tokenizer.cs: Add support for defines.
30005 Add support for #if, #elif, #else, #endif
30007 (eval_var): evaluates a variable.
30008 (eval): stubbed for evaluating functions.
30010 * cs-parser.jay: Pass the defines information
30012 * driver.cs: Add --define command line option.
30014 * decl.cs: Move MemberCore here.
30016 Make it the base class for DeclSpace. This allows us to catch and
30017 report 108 and 109 for everything now.
30019 * class.cs (TypeContainer.Define): Extract all the members
30020 before populating and emit the warning 108 (new keyword required
30021 to override) instead of having each member implement this.
30023 (MemberCore.Define): New abstract method, we will be using this in
30024 the warning reporting engine in Populate.
30026 (Operator.Define): Adjust to new MemberCore protocol.
30028 * const.cs (Const): This does not derive from Expression, it is a
30029 temporary object we use to create fields, it is a MemberCore.
30031 * class.cs (Method.Define): Allow the entry point to be in a
30034 * driver.cs: Rewrite the argument handler to clean it up a bit.
30036 * rootcontext.cs: Made it just an auxiliary namespace feature by
30037 making everything static.
30039 * driver.cs: Adapt code to use RootContext type name instead of
30042 * delegate.cs: Remove RootContext argument.
30044 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
30047 * class.cs (Event.Define): The lookup can fail.
30049 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30051 * expression.cs: Resolve the this instance before invoking the code.
30053 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30055 * cs-parser.jay: Add a production in element_access that allows
30056 the thing to become a "type" reference. This way we can parse
30057 things like "(string [])" as a type.
30059 Note that this still does not handle the more complex rules of
30063 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30065 * ecore.cs: (CopyNewMethods): new utility function used to
30066 assemble the list of methods from running FindMembers.
30068 (MemberLookup): Rework FindMembers so that
30070 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30072 * class.cs (TypeContainer): Remove Delegates who fail to be
30075 * delegate.cs (Populate): Verify that we dont get null return
30076 values. TODO: Check for AsAccessible.
30078 * cs-parser.jay: Use basename to emit error 574 (destructor should
30079 have the same name as container class), not the full name.
30081 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30082 possible representation.
30084 Also implements integer type suffixes U and L.
30086 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30088 * expression.cs (ArrayCreation.DoResolve): We need to do the
30089 argument resolution *always*.
30091 * decl.cs: Make this hold the namespace. Hold the root context as
30093 (LookupType): Move here.
30095 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30097 * location.cs (Row, Name): Fixed the code, it was always returning
30098 references to the first file.
30100 * interface.cs: Register properties defined through interfaces.
30102 * driver.cs: Add support for globbing on the command line
30104 * class.cs (Field): Make it derive from MemberCore as well.
30107 2001-12-15 Ravi Pratap <ravi@ximian.com>
30109 * class.cs (Event::Define): Check that the type of the event is a delegate
30110 type else flag error #66.
30112 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30115 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30116 values of EntryPoint, CharSet etc etc.
30118 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30120 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30121 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30122 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30123 which needs this to do its work.
30125 * ../errors/cs0066.cs : Add.
30127 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30129 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30132 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30133 clears out the parameters field.
30134 (MemberSignatureCompare): Cleanup
30136 (MemberCore): New base class used to share code between MethodCore
30139 (RegisterRequiredImplementations) BindingFlags.Public requires
30140 either BindingFlags.Instace or Static. Use instance here.
30142 (Property): Refactored code to cope better with the full spec.
30144 * parameter.cs (GetParameterInfo): Return an empty array instead
30147 * class.cs (Property): Abstract or extern properties have no bodies.
30149 * parameter.cs (GetParameterInfo): return a zero-sized array.
30151 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30152 method modifier validation to the typecontainer so we can reuse
30153 this on properties.
30155 (MethodCore.ParameterTypes): return an empty sized array of types.
30157 (Property.Define): Test property modifier validity.
30159 Add tests for sealed/override too.
30161 (Method.Emit): abstract or extern methods have no bodies.
30163 2001-12-14 Ravi Pratap <ravi@ximian.com>
30165 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30168 (Method::Define, ::Emit): Modify accordingly.
30170 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30172 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30174 * makefile: Pass in /unsafe.
30176 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30178 * class.cs (MakeKey): Kill routine.
30180 * class.cs (TypeContainer.Define): Correctly define explicit
30181 method implementations (they require the full interface name plus
30184 * typemanager.cs: Deply the PtrHashtable here and stop using the
30185 lame keys. Things work so much better.
30187 This of course broke everyone who depended on `RegisterMethod' to
30188 do the `test for existance' test. This has to be done elsewhere.
30190 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30191 the object stupid Equals method (because, that like fails all over
30192 the place). We still do not use it.
30194 * class.cs (TypeContainer.SetRequiredInterface,
30195 TypeContainer.RequireMethods): Killed these two routines and moved
30196 all the functionality to RegisterRequiredImplementations.
30198 (TypeContainer.RegisterRequiredImplementations): This routine now
30199 registers all the implementations required in an array for the
30200 interfaces and abstract methods. We use an array of structures
30201 which can be computed ahead of time to reduce memory usage and we
30202 also assume that lookups are cheap as most classes will not
30203 implement too many interfaces.
30205 We also avoid creating too many MethodSignatures.
30207 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30208 clear the "pending" bit if we find that there are problems with
30211 (TypeContainer.VerifyPendingMethods): Update to report errors of
30212 methods that look like implementations but are not.
30214 (TypeContainer.Define): Add support for explicit interface method
30217 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30219 * typemanager.cs: Keep track of the parameters here instead of
30220 being a feature of the TypeContainer.
30222 * class.cs: Drop the registration of parameters here, as
30223 InterfaceMethods are also interface declarations.
30225 * delegate.cs: Register methods with the TypeManager not only with
30226 the TypeContainer. This code was buggy.
30228 * interface.cs: Full registation here.
30230 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30232 * expression.cs: Remove reducer for binary expressions, it can not
30235 * const.cs: Put here the code that used to go into constant.cs
30237 * constant.cs: Put here the code for constants, this is a new base
30238 class for Literals.
30240 * literal.cs: Make Literal derive from Constant.
30242 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30244 * statement.cs (Return.Emit): Report error 157 if the user
30245 attempts to return from a finally block.
30247 (Return.Emit): Instead of emitting a return, jump to the end of
30250 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30251 LocalBuilder to store the result of the function. ReturnLabel is
30252 the target where we jump.
30255 2001-12-09 Radek Doulik <rodo@ximian.com>
30257 * cs-parser.jay: remember alias in current namespace
30259 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30262 * class.cs (LookupAlias): lookup alias in my_namespace
30264 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30266 (LookupAlias): lookup alias in this and if needed in parent
30269 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30273 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30274 making things static. I need this to avoid passing the
30275 TypeContainer when calling ParameterType.
30277 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30278 that did string manipulation to compute the type and then call
30279 GetType. Use Parameter.ParameterType instead.
30281 * cs-tokenizer.cs: Consume the suffix for floating values.
30283 * expression.cs (ParameterReference): figure out whether this is a
30284 reference parameter or not. Kill an extra variable by computing
30285 the arg_idx during emission.
30287 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30288 function that returns whether a parameter is an out/ref value or not.
30290 (Parameter.ParameterType): The type of the parameter (base,
30291 without ref/out applied).
30293 (Parameter.Resolve): Perform resolution here.
30294 (Parameter.ExternalType): The full type (with ref/out applied).
30296 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30297 support for expressions on the using statement.
30299 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30301 * statement.cs (Using.EmitLocalVariableDecls): Split the
30302 localvariable handling of the using statement.
30304 (Block.EmitMeta): Keep track of variable count across blocks. We
30305 were reusing slots on separate branches of blocks.
30307 (Try.Emit): Emit the general code block, we were not emitting it.
30309 Check the type of the declaration to be an IDisposable or
30310 something that can be implicity converted to it.
30312 Emit conversions if required.
30314 * ecore.cs (EmptyExpression): New utility class.
30315 (Expression.ImplicitConversionExists): New utility function.
30317 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30319 * statement.cs (Using): Implement.
30321 * expression.cs (LocalVariableReference): Support read only variables.
30323 * statement.cs: Remove the explicit emit for the Leave opcode.
30324 (VariableInfo): Add a readonly field.
30326 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30328 * ecore.cs (ConvCast): new class used to encapsulate the various
30329 explicit integer conversions that works in both checked and
30330 unchecked contexts.
30332 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30333 properly generate the overflow opcodes.
30335 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30337 * statement.cs: The correct type for the EmptyExpression is the
30338 element_type, not the variable type. Ravi pointed this out.
30340 2001-12-04 Ravi Pratap <ravi@ximian.com>
30342 * class.cs (Method::Define): Handle PInvoke methods specially
30343 by using DefinePInvokeMethod instead of the usual one.
30345 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30346 above to do the task of extracting information and defining the method.
30348 2001-12-04 Ravi Pratap <ravi@ximian.com>
30350 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30351 of the condition for string type.
30353 (Emit): Move that here.
30355 (ArrayCreation::CheckIndices): Keep string literals in their expression
30358 (EmitDynamicInitializers): Handle strings appropriately.
30360 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30362 * codegen.cs (EmitContext): Replace multiple variables with a
30363 single pointer to the current Switch statement.
30365 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30368 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30372 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30375 (Foreach.Emit): Foreach on arrays was not setting
30376 up the loop variables (for break/continue).
30378 (GotoCase): Semi-implented.
30380 2001-12-03 Ravi Pratap <ravi@ximian.com>
30382 * attribute.cs (CheckAttribute): Handle system attributes by using
30383 Attribute.GetAttributes to examine information we need.
30385 (GetValidPlaces): Same here.
30387 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30389 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30391 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30393 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30395 (Method::Emit): Handle the case when we are a PInvoke method.
30397 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30399 * expression.cs: Use ResolveWithSimpleName on compound names.
30401 2001-12-02 Ravi Pratap <ravi@ximian.com>
30403 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30404 before trying to reduce it.
30406 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30408 * constant.cs (LookupConstantValue): Implement.
30410 (EmitConstant): Use the above in emitting the constant.
30412 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30413 that are user-defined by doing a LookupConstantValue on them.
30415 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30418 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30420 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30422 (BaseAccess.DoResolve): Implement.
30424 (MemberAccess.DoResolve): Split this routine into a
30425 ResolveMemberAccess routine that can be used independently
30427 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30429 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30430 As that share bits of the implementation. Is returns a boolean,
30431 while As returns the Type that is being probed.
30433 2001-12-01 Ravi Pratap <ravi@ximian.com>
30435 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30436 instead of a Literal - much easier.
30438 (EnumInTransit): Remove - utterly useless :-)
30440 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30442 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30444 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30445 chain when we have no associated expression.
30447 2001-11-30 Ravi Pratap <ravi@ximian.com>
30449 * constant.cs (Define): Use Location while reporting the errror.
30451 Also emit a warning when 'new' is used and there is no inherited
30454 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30457 (LookupEnumValue): Implement to lookup an enum member's value and define it
30460 (Populate): Re-write accordingly to use the above routine.
30462 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30464 * expression.cs (This): Fix prototype for DoResolveLValue to
30465 override the base class DoResolveLValue.
30467 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30470 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30471 (we need to load the address of the field here). This fixes
30474 (FieldExpr.DoResolveLValue): Call the DoResolve
30475 function to initialize the Instance expression.
30477 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30478 correctly the GetEnumerator operation on a value type.
30480 * cs-parser.jay: Add more simple parsing error catches.
30482 * statement.cs (Switch): Add support for string switches.
30483 Handle null specially.
30485 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30487 2001-11-28 Ravi Pratap <ravi@ximian.com>
30489 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30491 (declare_local_constant): New helper function.
30493 * statement.cs (AddConstant): Keep a separate record of constants
30495 (IsConstant): Implement to determine if a variable is a constant.
30497 (GetConstantExpression): Implement.
30499 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30501 * statement.cs (IsVariableDefined): Re-write.
30503 2001-11-27 Ravi Pratap <ravi@ximian.com>
30505 * class.cs (TypeContainer::FindMembers): Look for constants
30506 in the case when we are looking for MemberTypes.Field
30508 * expression.cs (MemberAccess::DoResolve): Check that in the
30509 case we are a FieldExpr and a Literal, we are not being accessed
30510 by an instance reference.
30512 * cs-parser.jay (local_constant_declaration): Implement.
30514 (declaration_statement): Implement for constant declarations.
30516 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30518 * statement.cs (Switch): Catch double defaults.
30520 (Switch): More work on the switch() statement
30521 implementation. It works for integral values now, need to finish
30525 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30527 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30528 integer literals into other integer literals. To be used by
30531 2001-11-24 Ravi Pratap <ravi@ximian.com>
30533 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30536 (EmitDynamicInitializers): Cope with the above since we extract data
30537 directly from ArrayData now.
30539 (ExpectInitializers): Keep track of whether initializers are mandatory
30542 (Bounds): Make it a hashtable to prevent the same dimension being
30543 recorded for every element in that dimension.
30545 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30548 Also fix bug which was causing the indices to be emitted in the reverse
30551 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30553 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30554 unfinished. They do not work, because the underlying code is
30557 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30559 * cs-parser.jay: Remove bogus fixme.
30561 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30562 on Switch statement.
30564 2001-11-23 Ravi Pratap <ravi@ximian.com>
30566 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30569 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30570 parameter. Apparently, any expression is allowed.
30572 (ValidateInitializers): Update accordingly.
30574 (CheckIndices): Fix some tricky bugs thanks to recursion.
30576 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30577 I was being completely brain-dead.
30579 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30580 and re-write acordingly.
30582 (DelegateInvocation): Re-write accordingly.
30584 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30586 (MakeByteBlob): Handle types more correctly.
30588 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30589 initialization from expressions but it is incomplete because I am a complete
30592 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30594 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30595 on If. Basically, we have to return `true' (ie, we do return to
30596 our caller) only if both branches of the if return.
30598 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30599 short-circuit operators, handle them as short circuit operators.
30601 (Cast.DoResolve): Resolve type.
30602 (Cast.Cast): Take an expression as the target type.
30604 * cs-parser.jay (cast_expression): Remove old hack that only
30605 allowed a limited set of types to be handled. Now we take a
30606 unary_expression and we resolve to a type during semantic
30609 Use the grammar productions from Rhys to handle casts (this is
30610 not complete like Rhys syntax yet, we fail to handle that corner
30611 case that C# has regarding (-x), but we will get there.
30613 2001-11-22 Ravi Pratap <ravi@ximian.com>
30615 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30616 field which is an array type.
30618 * cs-parser.jay (declare_local_variables): Support array initialization too.
30620 * typemanager.cs (MakeKey): Implement.
30622 (everywhere): Use the above appropriately.
30624 * cs-parser.jay (for_statement): Update for array initialization while
30625 declaring variables.
30627 * ecore.cs : The error message was correct, it's the variable's names that
30628 were misleading ;-) Make the code more readable.
30630 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30631 the correct type etc.
30633 (ConvertExplicit): Handle Enum types by examining the underlying type.
30635 2001-11-21 Ravi Pratap <ravi@ximian.com>
30637 * parameter.cs (GetCallingConvention): Always return
30638 CallingConventions.Standard for now.
30640 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30642 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30643 and `r' after calling DoNumericPromotions.
30645 * ecore.cs: Fix error message (the types were in the wrong order).
30647 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30648 BindingFlags.Instance as well
30650 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30651 implicit int literal conversion in an empty cast so that we
30652 propagate the right type upstream.
30654 (UnboxCast): new class used to unbox value types.
30655 (Expression.ConvertExplicit): Add explicit type conversions done
30658 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30659 the target type before applying the implicit LongLiterals to ULong
30662 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30664 * cs-parser.jay (for_statement): Reworked the way For works: now
30665 we declare manually any variables that are introduced in
30666 for_initializer to solve the problem of having out-of-band code
30667 emition (that is what got for broken).
30669 (declaration_statement): Perform the actual variable declaration
30670 that used to be done in local_variable_declaration here.
30672 (local_variable_declaration): Do not declare anything, just pass
30673 the information on a DictionaryEntry
30675 2001-11-20 Ravi Pratap <ravi@ximian.com>
30677 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30678 re-write of the logic to now make it recursive.
30680 (UpdateIndices): Re-write accordingly.
30682 Store element data in a separate ArrayData list in the above methods.
30684 (MakeByteBlob): Implement to dump the array data into a byte array.
30686 2001-11-19 Ravi Pratap <ravi@ximian.com>
30688 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30691 * constant.cs (Define): Implement.
30693 (EmitConstant): Re-write fully.
30695 Pass in location info.
30697 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30700 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30701 DictionaryEntry since we need location info too.
30703 (constant_declaration): Update accordingly.
30705 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30706 code into another method : UpdateIndices.
30708 2001-11-18 Ravi Pratap <ravi@ximian.com>
30710 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30711 some type checking etc.
30713 2001-11-17 Ravi Pratap <ravi@ximian.com>
30715 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30716 bits to provide dimension info if the user skips doing that.
30718 Update second constructor to store the rank correctly.
30720 2001-11-16 Ravi Pratap <ravi@ximian.com>
30722 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30723 and try to implement.
30725 * ../errors/cs0150.cs : Add.
30727 * ../errors/cs0178.cs : Add.
30729 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30731 * statement.cs: Implement foreach on multi-dimensional arrays.
30733 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30734 name of the params argument.
30736 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30737 initializing the array.
30739 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30740 we can use this elsewhere.
30742 * statement.cs: Finish implementation of foreach for single
30745 * cs-parser.jay: Use an out-of-band stack to pass information
30746 around, I wonder why I need this.
30748 foreach_block: Make the new foreach_block the current_block.
30750 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30751 function used to return a static Parameters structure. Used for
30752 empty parameters, as those are created very frequently.
30754 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30756 2001-11-15 Ravi Pratap <ravi@ximian.com>
30758 * interface.cs : Default modifier is private, not public. The
30759 make verify test passes again.
30761 2001-11-15 Ravi Pratap <ravi@ximian.com>
30763 * support.cs (ReflectionParameters): Fix logic to determine
30764 whether the last parameter is a params one. Test 9 passes again.
30766 * delegate.cs (Populate): Register the builders we define with
30767 RegisterParameterForBuilder. Test 19 passes again.
30769 * cs-parser.jay (property_declaration): Reference $6 instead
30770 of $$ to get at the location.
30772 (indexer_declaration): Similar stuff.
30774 (attribute): Ditto.
30776 * class.cs (Property): Register parameters for the Get and Set methods
30777 if they exist. Test 23 passes again.
30779 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30780 call to EmitArguments as we are sure there aren't any params arguments.
30781 Test 32 passes again.
30783 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30784 IndexOutOfRangeException.
30786 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30787 Test 33 now passes again.
30789 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30791 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30792 broke a bunch of things. Will have to come up with a better way
30793 of tracking locations.
30795 * statement.cs: Implemented foreach for single dimension arrays.
30797 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30799 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30800 an error. This removes the lookup from the critical path.
30802 * cs-parser.jay: Removed use of temporary_loc, which is completely
30805 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30807 * support.cs (ReflectionParameters.ParameterModifier): Report
30808 whether the argument is a PARAMS argument or not.
30810 * class.cs: Set the attribute `ParamArrayAttribute' on the
30811 parameter argument.
30813 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30814 and cons_param_array_attribute (ConstructorInfo for
30815 ParamArrayAttribute).,
30817 * codegen.cs: Emit the return using the `Return' statement, that
30818 way we can report the error correctly for missing return values.
30820 * class.cs (Method.Emit): Clean up.
30822 * expression.cs (Argument.Resolve): Take another argument: the
30823 location where this argument is used. Notice that this is not
30824 part of the "Argument" class as to reduce the size of the
30825 structure (we know the approximate location anyways).
30827 Test if the argument is a variable-reference, if not, then
30828 complain with a 206.
30830 (Argument.Emit): Emit addresses of variables.
30832 (Argument.FullDesc): Simplify.
30834 (Invocation.DoResolve): Update for Argument.Resolve.
30836 (ElementAccess.DoResolve): ditto.
30838 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30839 method should be virtual, as this method is always virtual.
30841 (NewDelegate.DoResolve): Update for Argument.Resolve.
30843 * class.cs (ConstructorInitializer.DoResolve): ditto.
30845 * attribute.cs (Attribute.Resolve): ditto.
30847 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30849 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30851 * expression.cs (ParameterReference): Drop IStackStorage and implement
30852 IAssignMethod instead.
30854 (LocalVariableReference): ditto.
30856 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30857 IAssignMethod instead.
30859 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30861 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30862 enumerations that are used in heavily used structures derive from
30863 byte in a laughable and pathetic attempt to reduce memory usage.
30864 This is the kind of pre-optimzations that you should not do at
30865 home without adult supervision.
30867 * expression.cs (UnaryMutator): New class, used to handle ++ and
30868 -- separatedly from the other unary operators. Cleans up the
30869 code, and kills the ExpressionStatement dependency in Unary.
30871 (Unary): Removed `method' and `Arguments' from this class, making
30872 it smaller, and moving it all to SimpleCall, so I can reuse this
30873 code in other locations and avoid creating a lot of transient data
30874 strucutres when not required.
30876 * cs-parser.jay: Adjust for new changes.
30878 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30880 * enum.cs (Enum.Populate): If there is a failure during
30883 * cs-parser.jay (opt_enum_base): we used to catch type errors
30884 here, but this is really incorrect. The type error should be
30885 catched during semantic analysis.
30887 2001-12-11 Ravi Pratap <ravi@ximian.com>
30889 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30890 current_local_parameters as expected since I, in my stupidity, had forgotten
30893 * attribute.cs (GetValidPlaces): Fix stupid bug.
30895 * class.cs (Method::Emit): Perform check on applicability of attributes.
30897 (Constructor::Emit): Ditto.
30899 (Field::Emit): Ditto.
30901 (Field.Location): Store location information.
30903 (Property, Event, Indexer, Operator): Ditto.
30905 * cs-parser.jay (field_declaration): Pass in location for each field.
30907 * ../errors/cs0592.cs : Add.
30909 2001-11-12 Ravi Pratap <ravi@ximian.com>
30911 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30913 (InitCoreTypes): Update accordingly.
30915 (RegisterAttrType, LookupAttr): Implement.
30917 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30918 info about the same.
30920 (Resolve): Update to populate the above as necessary.
30922 (Error592): Helper.
30924 (GetValidPlaces): Helper to the above.
30926 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30928 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30930 2001-11-12 Ravi Pratap <ravi@ximian.com>
30932 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30934 * ../errors/cs0617.cs : Add.
30936 2001-11-11 Ravi Pratap <ravi@ximian.com>
30938 * enum.cs (Emit): Rename to Populate to be more consistent with what
30939 we expect it to do and when exactly it is called.
30941 * class.cs, rootcontext.cs : Update accordingly.
30943 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30944 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30946 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30948 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30949 of a fieldinfo using the above, when dealing with a FieldBuilder.
30951 2001-11-10 Ravi Pratap <ravi@ximian.com>
30953 * ../errors/cs0031.cs : Add.
30955 * ../errors/cs1008.cs : Add.
30957 * ../errrors/cs0543.cs : Add.
30959 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30962 (FindMembers): Implement.
30964 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30965 enums and delegates too.
30967 (enum_types): Rename to builder_to_enum.
30969 (delegate_types): Rename to builder_to_delegate.
30971 * delegate.cs (FindMembers): Implement.
30973 2001-11-09 Ravi Pratap <ravi@ximian.com>
30975 * typemanager.cs (IsEnumType): Implement.
30977 * enum.cs (Emit): Re-write parts to account for the underlying type
30978 better and perform checking etc.
30980 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30981 of the underlying type.
30983 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30986 * enum.cs (error31): Helper to report error #31.
30988 * cs-parser.jay (enum_declaration): Store location of each member too.
30990 * enum.cs (member_to_location): New hashtable.
30992 (AddEnumMember): Update location hashtable.
30994 (Emit): Use the location of each member while reporting errors.
30996 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30998 * cs-parser.jay: A for_initializer if is a
30999 local_variable_declaration really ammount to have an implicit
31000 block with the variable declaration and no initializer for for.
31002 * statement.cs (For.Emit): Cope with null initializers.
31004 This fixes the infinite loop on for initializers.
31006 2001-11-08 Miguel de Icaza <miguel@ximian.com>
31008 * enum.cs: More cleanup.
31010 * ecore.cs: Remove dead code.
31012 * class.cs (Property.Emit): More simplification.
31013 (Event.Emit): ditto.
31015 Reworked to have less levels of indentation.
31017 2001-11-08 Ravi Pratap <ravi@ximian.com>
31019 * class.cs (Property): Emit attributes.
31029 * enum.cs (Emit): Ditto.
31031 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
31034 * class.cs (Field, Event, etc.): Move attribute generation into the
31035 Emit method everywhere.
31037 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
31038 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
31039 as we had no way of defining nested enums !
31041 * rootcontext.cs : Adjust code accordingly.
31043 * typemanager.cs (AddEnumType): To keep track of enum types separately.
31045 2001-11-07 Ravi Pratap <ravi@ximian.com>
31047 * expression.cs (EvalConstantExpression): Move into ecore.cs
31049 * enum.cs (Enum): Rename some members and make them public and readonly
31050 according to our convention.
31052 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31055 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31057 (Enum::Emit): Write a simple version for now which doesn't try to compute
31058 expressions. I shall modify this to be more robust in just a while.
31060 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31062 (TypeContainer::CloseType): Create the Enum types too.
31064 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31066 * expression.cs (EvalConstantExpression): Get rid of completely.
31068 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31069 user-defined values and other cases.
31071 (IsValidEnumLiteral): Helper function.
31073 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31074 out there in the case we had a literal FieldExpr.
31076 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31078 (Literalize): Revamp a bit to take two arguments.
31080 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31082 2001-11-06 Ravi Pratap <ravi@ximian.com>
31084 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31086 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31088 (Resolve): Use the above to ensure we have proper initializers.
31090 2001-11-05 Ravi Pratap <ravi@ximian.com>
31092 * expression.cs (Expression::EvalConstantExpression): New method to
31093 evaluate constant expressions.
31095 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31097 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31099 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31102 (Binary.ResolveOperator): Handle operator != (object a, object b)
31103 and operator == (object a, object b);
31105 (Binary.DoNumericPromotions): Indicate whether the numeric
31106 promotion was possible.
31108 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31111 Made the ArrayAccess implement interface IAssignMethod instead of
31112 IStackStore as the order in which arguments are passed reflects
31115 * assign.cs: Instead of using expr.ExprClass to select the way of
31116 assinging, probe for the IStackStore/IAssignMethod interfaces.
31118 * typemanager.cs: Load InitializeArray definition.
31120 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31121 static data that can be used to initialize arrays.
31123 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31125 * expression.cs: Handle operator== and operator!= for booleans.
31127 (Conditioal.Reduce): Implement reducer for the ?: operator.
31129 (Conditional.Resolve): Implement dead code elimination.
31131 (Binary.Resolve): Catch string literals and return a new
31132 concatenated string.
31134 (Unary.Reduce): Implement reduction of unary expressions.
31136 * ecore.cs: Split out the expression core handling here.
31138 (Expression.Reduce): New method used to perform constant folding
31139 and CSE. This is needed to support constant-expressions.
31141 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31142 targets, and optimize for !x.
31144 2001-11-04 Ravi Pratap <ravi@ximian.com>
31146 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31147 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31148 set custom atttributes.
31150 * literal.cs (Literal::GetValue): New abstract method to return the actual
31151 value of the literal, cast as an object.
31153 (*Literal): Implement GetValue method.
31155 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31156 expressions to the arraylist but objects of type Argument.
31158 * class.cs (TypeContainer::Emit): Emit our attributes too.
31160 (Method::Emit, Constructor::Emit): Ditto.
31162 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31163 to be ignoring earlier.
31165 2001-11-03 Ravi Pratap <ravi@ximian.com>
31167 * attribute.cs (AttributeSection::Define): Implement to do the business
31168 of constructing a CustomAttributeBuilder.
31170 (Attribute): New trivial class. Increases readability of code.
31172 * cs-parser.jay : Update accordingly.
31174 (positional_argument_list, named_argument_list, named_argument): New rules
31176 (attribute_arguments): Use the above so that we are more correct.
31178 2001-11-02 Ravi Pratap <ravi@ximian.com>
31180 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31181 to perform all checks for a method with a params parameter.
31183 (Invocation::OverloadResolve): Update to use the above method and therefore
31184 cope correctly with params method invocations.
31186 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31189 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31190 constructors in our parent too because we can't afford to miss out on
31193 * attribute.cs (AttributeSection): New name for the class Attribute
31195 Other trivial changes to improve readability.
31197 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31198 use the new class names.
31200 2001-11-01 Ravi Pratap <ravi@ximian.com>
31202 * class.cs (Method::Define): Complete definition for params types too
31204 (Indexer::Define): Ditto.
31206 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31207 Cope everywhere with a request for info about the array parameter.
31209 2001-11-01 Ravi Pratap <ravi@ximian.com>
31211 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31213 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31214 local_variable_type to extract the string corresponding to the type.
31216 (local_variable_type): Fixup the action to use the new helper method.
31218 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31221 * expression.cs : Clean out code which uses the above.
31223 2001-10-31 Ravi Pratap <ravi@ximian.com>
31225 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31226 and bale out if necessary by returning a false.
31228 (RegisterProperty): Ditto.
31230 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31231 and print out appropriate error messages.
31233 * interface.cs (everywhere): Ditto.
31235 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31236 location to constructor.
31238 * class.cs (Property, Event, Indexer): Update accordingly.
31240 * ../errors/cs111.cs : Added.
31242 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31243 of a method, as laid down by the spec.
31245 (Invocation::OverloadResolve): Use the above method.
31247 2001-10-31 Ravi Pratap <ravi@ximian.com>
31249 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31250 now take a TypeContainer and a Parameters object.
31252 (ParameterData): Modify return type of ParameterModifier method to be
31253 Parameter.Modifier and not a string.
31255 (ReflectionParameters, InternalParameters): Update accordingly.
31257 * expression.cs (Argument::GetParameterModifier): Same here.
31259 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31260 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31261 symbol in it at all so maybe this is only for now.
31263 2001-10-30 Ravi Pratap <ravi@ximian.com>
31265 * support.cs (InternalParameters): Constructor now takes an extra argument
31266 which is the actual Parameters class.
31268 (ParameterDesc): Update to provide info on ref/out modifiers.
31270 * class.cs (everywhere): Update call to InternalParameters to pass in
31271 the second argument too.
31273 * support.cs (ParameterData): Add ParameterModifier, which is a method
31274 to return the modifier info [ref/out etc]
31276 (InternalParameters, ReflectionParameters): Implement the above.
31278 * expression.cs (Argument::ParameterModifier): Similar function to return
31279 info about the argument's modifiers.
31281 (Invocation::OverloadResolve): Update to take into account matching modifiers
31284 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31285 a new SetFormalParameters object which we pass to InternalParameters.
31287 2001-10-30 Ravi Pratap <ravi@ximian.com>
31289 * expression.cs (NewArray): Merge into the ArrayCreation class.
31291 2001-10-29 Ravi Pratap <ravi@ximian.com>
31293 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31294 NewUserdefinedArray into one as there wasn't much of a use in having
31297 * expression.cs (Argument): Change field's name to ArgType from Type.
31299 (Type): New readonly property which returns the proper type, taking into
31300 account ref/out modifiers.
31302 (everywhere): Adjust code accordingly for the above.
31304 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31305 whether we are emitting for a ref or out parameter.
31307 * expression.cs (Argument::Emit): Use the above field to set the state.
31309 (LocalVariableReference::Emit): Update to honour the flag and emit the
31312 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31314 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31316 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31318 (ReflectionParameters, InternalParameters): Implement the above method.
31320 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31323 (Invocation::FullMethodDesc): Ditto.
31325 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31327 * cs-parser.jay: Add extra production for the second form of array
31330 * expression.cs (ArrayCreation): Update to reflect the above
31333 * Small changes to prepare for Array initialization.
31335 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31337 * typemanager.cs (ImplementsInterface): interface might be null;
31338 Deal with this problem;
31340 Also, we do store negative hits on the cache (null values), so use
31341 this instead of calling t.GetInterfaces on the type everytime.
31343 2001-10-28 Ravi Pratap <ravi@ximian.com>
31345 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31347 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31348 split functionality out into different classes.
31350 (New::FormArrayType): Move into NewBuiltinArray.
31352 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31355 (NewBuiltinArray): New class to handle creation of built-in arrays.
31357 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31358 account creation of one-dimensional arrays.
31360 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31362 (NewUserdefinedArray::DoResolve): Implement.
31364 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31366 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31367 we maintain inside the TypeManager. This is necessary to perform lookups on the
31370 (LookupType): Update to perform GetType on the module builders too.
31372 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31374 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31376 2001-10-23 Ravi Pratap <ravi@ximian.com>
31378 * expression.cs (New::DoResolve): Implement guts of array creation.
31380 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31382 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31384 * expression.cs: Fix bug I introduced lsat night that broke
31387 (Expression.Resolve): Report a 246 error (can not resolve name)
31388 if we find a SimpleName in the stream.
31390 (Expression.ResolveLValue): Ditto.
31392 (Expression.ResolveWithSimpleName): This function is a variant of
31393 ResolveName, this one allows SimpleNames to be returned without a
31394 warning. The only consumer of SimpleNames is MemberAccess
31396 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31398 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31399 might arrive here. I have my doubts that this is correct.
31401 * statement.cs (Lock): Implement lock statement.
31403 * cs-parser.jay: Small fixes to support `lock' and `using'
31405 * cs-tokenizer.cs: Remove extra space
31407 * driver.cs: New flag --checked, allows to turn on integer math
31410 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31411 Threading.Monitor.Exit
31413 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31415 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31416 Expression Class to be IndexerAccess.
31418 Notice that Indexer::DoResolve sets the eclass to Value.
31420 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31422 * class.cs (TypeContainer::Emit): Emit code for indexers.
31424 * assign.cs (IAssignMethod): New interface implemented by Indexers
31425 and Properties for handling assignment.
31427 (Assign::Emit): Simplify and reuse code.
31429 * expression.cs (IndexerAccess, PropertyExpr): Implement
31430 IAssignMethod, clean up old code.
31432 2001-10-22 Ravi Pratap <ravi@ximian.com>
31434 * typemanager.cs (ImplementsInterface): New method to determine if a type
31435 implements a given interface. Provides a nice cache too.
31437 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31440 (ConvertReferenceExplicit): Ditto.
31442 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31443 various methods, with correct names etc.
31445 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31446 Operator.UnaryNegation.
31448 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31449 we have a unary plus or minus operator.
31451 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31454 * everywhere : update accordingly.
31456 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31459 * class.cs (Method::Define): For the case where we are implementing a method
31460 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31461 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31463 2001-10-21 Ravi Pratap <ravi@ximian.com>
31465 * interface.cs (FindMembers): Implement to work around S.R.E
31468 * typemanager.cs (IsInterfaceType): Implement.
31470 (FindMembers): Update to handle interface types too.
31472 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31473 use IsAssignableFrom as that is not correct - it doesn't work.
31475 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31476 and accordingly override EmitStatement.
31478 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31479 using the correct logic :-)
31481 2001-10-19 Ravi Pratap <ravi@ximian.com>
31483 * ../errors/cs-11.cs : Add to demonstrate error -11
31485 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31487 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31488 then pass this as a hint to ResolveLValue.
31490 * expression.cs (FieldExpr): Add Location information
31492 (FieldExpr::LValueResolve): Report assignment to readonly
31495 (Expression::ExprClassFromMemberInfo): Pass location information.
31497 (Expression::ResolveLValue): Add new method that resolves an
31500 (Expression::DoResolveLValue): Default invocation calls
31503 (Indexers): New class used to keep track of indexers in a given
31506 (IStackStore): Renamed from LValue, as it did not really describe
31507 what this did. Also ResolveLValue is gone from this interface and
31508 now is part of Expression.
31510 (ElementAccess): Depending on the element access type
31512 * typemanager.cs: Add `indexer_name_type' as a Core type
31513 (System.Runtime.CompilerServices.IndexerNameAttribute)
31515 * statement.cs (Goto): Take a location.
31517 2001-10-18 Ravi Pratap <ravi@ximian.com>
31519 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31520 if two delegates are compatible.
31522 (NewDelegate::DoResolve): Update to take care of the case when
31523 we instantiate a delegate from another delegate.
31525 * typemanager.cs (FindMembers): Don't even try to look up members
31526 of Delegate types for now.
31528 2001-10-18 Ravi Pratap <ravi@ximian.com>
31530 * delegate.cs (NewDelegate): New class to take care of delegate
31533 * expression.cs (New): Split the delegate related code out into
31534 the NewDelegate class.
31536 * delegate.cs (DelegateInvocation): New class to handle delegate
31539 * expression.cs (Invocation): Split out delegate related code into
31540 the DelegateInvocation class.
31542 2001-10-17 Ravi Pratap <ravi@ximian.com>
31544 * expression.cs (New::DoResolve): Implement delegate creation fully
31545 and according to the spec.
31547 (New::DoEmit): Update to handle delegates differently.
31549 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31550 because of which we were printing out arguments in reverse order !
31552 * delegate.cs (VerifyMethod): Implement to check if the given method
31553 matches the delegate.
31555 (FullDelegateDesc): Implement.
31557 (VerifyApplicability): Implement.
31559 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31560 delegate invocations too.
31562 (Invocation::Emit): Ditto.
31564 * ../errors/cs1593.cs : Added.
31566 * ../errors/cs1594.cs : Added.
31568 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31570 2001-10-16 Ravi Pratap <ravi@ximian.com>
31572 * typemanager.cs (intptr_type): Core type for System.IntPtr
31574 (InitCoreTypes): Update for the same.
31576 (iasyncresult_type, asynccallback_type): Ditto.
31578 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31581 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31584 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31585 the builders for the 4 members of a delegate type :-)
31587 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31590 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31592 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31594 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31596 * statement.cs (Break::Emit): Implement.
31597 (Continue::Emit): Implement.
31599 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31600 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31601 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31602 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31605 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31606 properties that track the label for the current loop (begin of the
31607 loop and end of the loop).
31609 2001-10-15 Ravi Pratap <ravi@ximian.com>
31611 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31612 use of emitting anything at all.
31614 * class.cs, rootcontext.cs : Get rid of calls to the same.
31616 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31618 (Populate): Define the constructor correctly and set the implementation
31621 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31624 (AddDelegateType): Implement.
31626 (IsDelegateType): Implement helper method.
31628 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31630 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31631 and accordingly handle it.
31633 * delegate.cs (Populate): Take TypeContainer argument.
31634 Implement bits to define the Invoke method. However, I still haven't figured out
31635 how to take care of the native int bit :-(
31637 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31638 Qualify the name of the delegate, not its return type !
31640 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31643 (StandardConversionExists): Checking for array types turns out to be recursive.
31645 (ConvertReferenceExplicit): Implement array conversion.
31647 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31649 2001-10-12 Ravi Pratap <ravi@ximian.com>
31651 * cs-parser.jay (delegate_declaration): Store the fully qualified
31652 name as it is a type declaration.
31654 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31657 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31658 as TypeContainer::DefineType.
31660 (Populate): Method in which all the definition of the various methods (Invoke)
31663 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31666 (CloseDelegate): Finally creates the delegate.
31668 * class.cs (TypeContainer::DefineType): Update to define delegates.
31669 (Populate, Emit and CloseType): Do the same thing here too.
31671 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31672 delegates in all these operations.
31674 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31676 * expression.cs: LocalTemporary: a new expression used to
31677 reference a temporary that has been created.
31679 * assign.cs: Handle PropertyAccess back here, so that we can
31680 provide the proper semantic access to properties.
31682 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31683 a few more explicit conversions.
31685 * modifiers.cs: `NEW' modifier maps to HideBySig.
31687 * expression.cs (PropertyExpr): Make this into an
31688 ExpressionStatement, and support the EmitStatement code path.
31690 Perform get/set error checking, clean up the interface.
31692 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31693 them into toplevel access objects.
31695 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31697 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31700 * typemanager.cs: Keep track here of our PropertyBuilders again to
31701 work around lameness in SRE.
31703 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31705 * expression.cs (LValue::LValueResolve): New method in the
31706 interface, used to perform a second resolution pass for LValues.
31708 (This::DoResolve): Catch the use of this in static methods.
31710 (This::LValueResolve): Implement.
31712 (This::Store): Remove warning, assigning to `this' in structures
31715 (Invocation::Emit): Deal with invocation of
31716 methods on value types. We need to pass the address to structure
31717 methods rather than the object itself. (The equivalent code to
31718 emit "this" for structures leaves the entire structure on the
31719 stack instead of a pointer to it).
31721 (ParameterReference::DoResolve): Compute the real index for the
31722 argument based on whether the method takes or not a `this' pointer
31723 (ie, the method is static).
31725 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31726 value types returned from functions when we need to invoke a
31727 method on the sturcture.
31730 2001-10-11 Ravi Pratap <ravi@ximian.com>
31732 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31733 defining the type in the Modulebuilder or Typebuilder. This is to take
31734 care of nested types which need to be defined on the TypeBuilder using
31735 DefineNestedMethod.
31737 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31738 methods in RootContext, only ported to be part of TypeContainer.
31740 (TypeContainer::GetInterfaceOrClass): Ditto.
31742 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31744 * interface.cs (Interface::DefineInterface): New method. Does exactly
31745 what RootContext.CreateInterface did earlier, only it takes care of nested types
31748 (Interface::GetInterfaces): Move from RootContext here and port.
31750 (Interface::GetInterfaceByName): Same here.
31752 * rootcontext.cs (ResolveTree): Re-write.
31754 (PopulateTypes): Re-write.
31756 * class.cs (TypeContainer::Populate): Populate nested types too.
31757 (TypeContainer::Emit): Emit nested members too.
31759 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31760 instead just use the name argument passed in as it is already fully
31763 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31764 to TypeContainer mapping to see if a type is user-defined.
31766 * class.cs (TypeContainer::CloseType): Implement.
31768 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31769 the default constructor.
31771 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31774 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31776 * interface.cs (CloseType): Create the type here.
31778 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31781 Remove all the methods which are now in TypeContainer.
31783 2001-10-10 Ravi Pratap <ravi@ximian.com>
31785 * delegate.cs (Define): Re-write bits to define the delegate
31788 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31790 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31792 * expression.cs (ImplicitReferenceConversion): handle null as well
31793 as a source to convert to any reference type.
31795 * statement.cs (Return): Perform any implicit conversions to
31796 expected return type.
31798 Validate use of return statement.
31800 * codegen.cs (EmitContext): Pass the expected return type here.
31802 * class.cs (Method, Constructor, Property): Pass expected return
31803 type to EmitContext.
31805 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31807 * expression.cs: Make DoResolve take an EmitContext instead of a
31810 Replaced `l' and `location' for `loc', for consistency.
31812 (Error, Warning): Remove unneeded Tc argument.
31814 * assign.cs, literal.cs, constant.cs: Update to new calling
31817 * codegen.cs: EmitContext now contains a flag indicating whether
31818 code is being generated in a static method or not.
31820 * cs-parser.jay: DecomposeQI, new function that replaces the old
31821 QualifiedIdentifier. Now we always decompose the assembled
31822 strings from qualified_identifier productions into a group of
31825 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31827 * rootcontext.cs: Deal with field-less struct types correctly now
31828 by passing the size option to Define Type.
31830 * class.cs: Removed hack that created one static field.
31832 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31834 * statement.cs: Moved most of the code generation here.
31836 2001-10-09 Ravi Pratap <ravi@ximian.com>
31838 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31841 (ElementAccess): Remove useless bits for now - keep checks as the spec
31844 2001-10-08 Ravi Pratap <ravi@ximian.com>
31846 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31847 and start performing checks according to the spec.
31849 2001-10-07 Ravi Pratap <ravi@ximian.com>
31851 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31852 rank_specifiers instead.
31854 (rank_specifiers): Change the order in which the rank specifiers are stored
31856 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31858 * expression.cs (ElementAccess): Implement the LValue interface too.
31860 2001-10-06 Ravi Pratap <ravi@ximian.com>
31862 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31863 except that user defined conversions are not included.
31865 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31866 perform the conversion of the return type, if necessary.
31868 (New::DoResolve): Check whether we are creating an array or an object
31869 and accordingly do the needful.
31871 (New::Emit): Same here.
31873 (New::DoResolve): Implement guts of array creation.
31875 (New::FormLookupType): Helper function.
31877 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31879 * codegen.cs: Removed most of the code generation here, and move the
31880 corresponding code generation bits to the statement classes.
31882 Added support for try/catch/finalize and throw.
31884 * cs-parser.jay: Added support for try/catch/finalize.
31886 * class.cs: Catch static methods having the flags override,
31887 virtual or abstract.
31889 * expression.cs (UserCast): This user cast was not really doing
31890 what it was supposed to do. Which is to be born in fully resolved
31891 state. Parts of the resolution were being performed at Emit time!
31895 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31897 * expression.cs: Implicity convert the result from UserCast.
31899 2001-10-05 Ravi Pratap <ravi@ximian.com>
31901 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31902 prevented it from working correctly.
31904 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31905 merely ConvertImplicit.
31907 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31909 * typemanager.cs: Make the LookupTypeContainer function static,
31910 and not per-instance.
31912 * class.cs: Make static FindMembers (the one that takes a Type
31915 * codegen.cs: Add EmitForeach here.
31917 * cs-parser.jay: Make foreach a toplevel object instead of the
31918 inline expansion, as we need to perform semantic analysis on it.
31920 2001-10-05 Ravi Pratap <ravi@ximian.com>
31922 * expression.cs (Expression::ImplicitUserConversion): Rename to
31923 UserDefinedConversion.
31925 (Expression::UserDefinedConversion): Take an extra argument specifying
31926 whether we look for explicit user conversions too.
31928 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31930 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31932 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31933 with the appropriate arguments.
31935 * cs-parser.jay (cast_expression): Record location too.
31937 * expression.cs (Cast): Record location info.
31939 (Expression::ConvertExplicit): Take location argument.
31941 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31942 to determine if we are doing explicit conversions.
31944 (UserCast::Emit): Update accordingly.
31946 (Expression::ConvertExplicit): Report an error if everything fails.
31948 * ../errors/cs0030.cs : Add.
31950 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31952 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31953 virtual and newslot bits.
31955 * class.cs (TypeContainer::RegisterRequiredImplementations):
31956 Record methods we need.
31958 (TypeContainer::MakeKey): Helper function to make keys for
31959 MethodBases, since the Methodbase key is useless.
31961 (TypeContainer::Populate): Call RegisterRequiredImplementations
31962 before defining the methods.
31964 Create a mapping for method_builders_to_methods ahead of time
31965 instead of inside a tight loop.
31967 (::RequireMethods): Accept an object as the data to set into the
31968 hashtable so we can report interface vs abstract method mismatch.
31970 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31972 * report.cs: Make all of it static.
31974 * rootcontext.cs: Drop object_type and value_type computations, as
31975 we have those in the TypeManager anyways.
31977 Drop report instance variable too, now it is a global.
31979 * driver.cs: Use try/catch on command line handling.
31981 Add --probe option to debug the error reporting system with a test
31984 * report.cs: Add support for exiting program when a probe
31985 condition is reached.
31987 2001-10-03 Ravi Pratap <ravi@ximian.com>
31989 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31990 we do a forcible conversion regardless of type, to check if
31991 ForceConversion returns a null.
31993 (Binary::error19): Use location to report error.
31995 (Unary::error23): Use location here too.
31997 * ../errors/cs0019.cs : Check in.
31999 * ../errors/cs0023.cs : Check in.
32001 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
32002 case of a non-null MethodInfo object with a length of 0 !
32004 (Binary::ResolveOperator): Flag error if overload resolution fails to find
32005 an applicable member - according to the spec :-)
32006 Also fix logic to find members in base types.
32008 (Unary::ResolveOperator): Same here.
32010 (Unary::report23): Change name to error23 and make first argument a TypeContainer
32011 as I was getting thoroughly confused between this and error19 :-)
32013 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
32014 (::FindMostEncompassedType): Implement.
32015 (::FindMostEncompassingType): Implement.
32016 (::StandardConversionExists): Implement.
32018 (UserImplicitCast): Re-vamp. We now need info about most specific
32019 source and target types so that we can do the necessary conversions.
32021 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
32022 mathematical union with no duplicates.
32024 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32026 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
32027 in order from base classes to child classes, so that we can in
32028 child classes look up in our parent for method names and
32029 attributes (required for handling abstract, virtual, new, override
32030 constructs: we need to instrospect our base class, and if we dont
32031 populate the classes in order, the introspection might be
32032 incorrect. For example, a method could query its parent before
32033 the parent has any methods and would determine that the parent has
32034 no abstract methods (while it could have had them)).
32036 (RootContext::CreateType): Record the order in which we define the
32039 2001-10-02 Miguel de Icaza <miguel@ximian.com>
32041 * class.cs (TypeContainer::Populate): Also method definitions can
32042 fail now, keep track of this.
32044 (TypeContainer::FindMembers): Implement support for
32045 DeclaredOnly/noDeclaredOnly flag.
32047 (Constructor::Emit) Return the ConstructorBuilder.
32049 (Method::Emit) Return the MethodBuilder.
32050 Check for abstract or virtual methods to be public.
32052 * rootcontext.cs (RootContext::CreateType): Register all the
32053 abstract methods required for the class to be complete and the
32054 interface methods that must be implemented.
32056 * cs-parser.jay: Report error 501 (method requires body if it is
32057 not marked abstract or extern).
32059 * expression.cs (TypeOf::Emit): Implement.
32061 * typemanager.cs: runtime_handle_type, new global type.
32063 * class.cs (Property::Emit): Generate code for properties.
32065 2001-10-02 Ravi Pratap <ravi@ximian.com>
32067 * expression.cs (Unary::ResolveOperator): Find operators on base type
32068 too - we now conform exactly to the spec.
32070 (Binary::ResolveOperator): Same here.
32072 * class.cs (Operator::Define): Fix minor quirk in the tests.
32074 * ../errors/cs0215.cs : Added.
32076 * ../errors/cs0556.cs : Added.
32078 * ../errors/cs0555.cs : Added.
32080 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32082 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32083 single integer which is really efficient
32085 2001-10-01 Ravi Pratap <ravi@ximian.com>
32087 * expression.cs (Expression::ImplicitUserConversion): Use location
32088 even in the case when we are examining True operators.
32090 * class.cs (Operator::Define): Perform extensive checks to conform
32091 with the rules for operator overloading in the spec.
32093 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32094 some of the other conversions mentioned in the spec.
32096 * typemanager.cs (array_type): New static member for the System.Array built-in
32099 (cloneable_interface): For System.ICloneable interface.
32101 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32102 we start resolving the tree and populating types.
32104 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32106 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32108 * expression.cs (Expression::ExprClassFromMemberInfo,
32109 Expression::Literalize): Create literal expressions from
32110 FieldInfos which are literals.
32112 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32113 type casts, because they were wrong. The test suite in tests
32116 (ImplicitNumericConversion): ushort to ulong requires a widening
32119 Int32 constant to long requires widening cast as well.
32121 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32122 for integers because the type on the stack is not i4.
32124 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32126 * expression.cs (report118): require location argument.
32128 * parameter.cs: Do not dereference potential null value.
32130 * class.cs: Catch methods that lack the `new' keyword when
32131 overriding a name. Report warnings when `new' is used without
32132 anything being there to override.
32134 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32136 * class.cs: Only add constructor to hashtable if it is non-null
32137 (as now constructors can fail on define).
32139 (TypeManager, Class, Struct): Take location arguments.
32141 Catch field instance initialization in structs as errors.
32143 accepting_filter: a new filter for FindMembers that is static so
32144 that we dont create an instance per invocation.
32146 (Constructor::Define): Catch errors where a struct constructor is
32149 * cs-parser.jay: Pass location information for various new
32152 * delegate.cs (Delegate): take a location argument.
32154 * driver.cs: Do not call EmitCode if there were problesm in the
32155 Definition of the types, as many Builders wont be there.
32157 * decl.cs (Decl::Decl): Require a location argument.
32159 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32160 into integers, and find the most appropiate integer for it.
32162 * literal.cs: Implement ULongLiteral.
32164 * rootcontext.cs: Provide better information about the location of
32165 failure when CreateType fails.
32167 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32169 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32172 * expression.cs (Binary::CheckShiftArguments): Add missing type
32174 (Binary::ResolveOperator): Add type to the logical and and logical
32175 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32178 (Binary::DoNumericPromotions): In the case where either argument
32179 is ulong (and most signed types combined with ulong cause an
32180 error) perform implicit integer constant conversions as well.
32182 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32184 * expression.cs (UserImplicitCast): Method should always be
32186 (Invocation::BetterConversion): Simplified test for IntLiteral.
32188 (Expression::ImplicitNumericConversion): Split this routine out.
32189 Put the code that performs implicit constant integer conversions
32192 (Expression::Resolve): Become a wrapper around DoResolve so we can
32193 check eclass and type being set after resolve.
32195 (Invocation::Badness): Remove this dead function
32197 (Binary::ResolveOperator): Do not compute the expensive argumnets
32198 unless we have a union for it.
32200 (Probe::Emit): Is needs to do an isinst and then
32201 compare against null.
32203 (::CanConvert): Added Location argument. If the Location argument
32204 is null (Location.Null), then we do not report errors. This is
32205 used by the `probe' mechanism of the Explicit conversion. We do
32206 not want to generate an error for something that the user
32207 explicitly requested to be casted. But the pipeline for an
32208 explicit cast first tests for potential implicit casts.
32210 So for now, if the Location is null, it means `Probe only' to
32211 avoid adding another argument. Might have to revise this
32214 (ClassCast): New class used to type cast objects into arbitrary
32215 classes (used in Explicit Reference Conversions).
32217 Implement `as' as well.
32219 Reverted all the patches from Ravi below: they were broken:
32221 * The use of `level' as a mechanism to stop recursive
32222 invocations is wrong. That was there just to catch the
32223 bug with a strack trace but not as a way of addressing
32226 To fix the problem we have to *understand* what is going
32227 on and the interactions and come up with a plan, not
32228 just get things going.
32230 * The use of the type conversion cache that I proposed
32231 last night had an open topic: How does this work across
32232 protection domains. A user defined conversion might not
32233 be public in the location where we are applying the
32234 conversion, a different conversion might be selected
32235 (ie, private A->B (better) but public B->A (worse),
32236 inside A, A->B applies, but outside it, B->A will
32239 * On top of that (ie, even if the above is solved),
32240 conversions in a cache need to be abstract. Ie, `To
32241 convert from an Int to a Short use an OpcodeCast', not
32242 `To convert from an Int to a Short use the OpcodeCast on
32243 the variable 5' (which is what this patch was doing).
32245 2001-09-28 Ravi Pratap <ravi@ximian.com>
32247 * expression.cs (Invocation::ConversionExists): Re-write to use
32248 the conversion cache
32250 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32251 cache all conversions done, not just user-defined ones.
32253 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32254 to determine if a conversion exists instead of acutually trying to
32255 perform the conversion. It's faster too.
32257 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32258 and only then attempt the implicit conversion.
32260 2001-09-28 Ravi Pratap <ravi@ximian.com>
32262 * expression.cs (ConvertImplicit): Use a cache for conversions
32263 already found. Check level of recursion and bail out if necessary.
32265 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32267 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32268 Export standard methods that we expect for string operations.
32270 * statement.cs (Block::UsageWarning): Track usage of variables and
32271 report the errors for not used variables.
32273 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32276 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32278 * codegen.cs: remove unnneded code
32280 * expression.cs: Removed BuiltinTypeAccess class
32282 Fix the order in which implicit conversions are
32285 The previous fixed dropped support for boxed conversions (adding a
32286 test to the test suite now)
32288 (UserImplicitCast::CanConvert): Remove test for source being null,
32289 that code is broken. We should not feed a null to begin with, if
32290 we do, then we should track the bug where the problem originates
32291 and not try to cover it up here.
32293 Return a resolved expression of type UserImplicitCast on success
32294 rather than true/false. Ravi: this is what I was talking about,
32295 the pattern is to use a static method as a "constructor" for
32298 Also, do not create arguments until the very last minute,
32299 otherwise we always create the arguments even for lookups that
32300 will never be performed.
32302 (UserImplicitCast::Resolve): Eliminate, objects of type
32303 UserImplicitCast are born in a fully resolved state.
32305 * typemanager.cs (InitCoreTypes): Init also value_type
32306 (System.ValueType).
32308 * expression.cs (Cast::Resolve): First resolve the child expression.
32310 (LValue): Add new method AddressOf to be used by
32313 Change the argument of Store to take an EmitContext instead of an
32314 ILGenerator, because things like FieldExpr need to be able to call
32315 their children expression to generate the instance code.
32317 (Expression::Error, Expression::Warning): Sugar functions for
32320 (Expression::MemberLookup): Accept a TypeContainer instead of a
32321 Report as the first argument.
32323 (Expression::ResolvePrimary): Killed. I still want to improve
32324 this as currently the code is just not right.
32326 (Expression::ResolveMemberAccess): Simplify, but it is still
32329 (Unary::Resolve): Catch errors in AddressOf operators.
32331 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32332 index to a byte for the short-version, or the compiler will choose
32333 the wrong Emit call, which generates the wrong data.
32335 (ParameterReference::Emit, ::Store): same.
32337 (FieldExpr::AddressOf): Implement.
32339 * typemanager.cs: TypeManager: made public variable instead of
32342 * driver.cs: document --fatal.
32344 * report.cs (ErrorMessage, WarningMessage): new names for the old
32345 Error and Warning classes.
32347 * cs-parser.jay (member_access): Turn built-in access to types
32348 into a normal simplename
32350 2001-09-27 Ravi Pratap <ravi@ximian.com>
32352 * expression.cs (Invocation::BetterConversion): Fix to cope
32353 with q being null, since this was introducing a bug.
32355 * expression.cs (ConvertImplicit): Do built-in conversions first.
32357 2001-09-27 Ravi Pratap <ravi@ximian.com>
32359 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32361 2001-09-27 Ravi Pratap <ravi@ximian.com>
32363 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32364 I had introduced long ago (what's new ?).
32366 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32367 the work of all the checking.
32368 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32369 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32371 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32372 that is the right way.
32374 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32375 overloading resolution. Use everywhere instead of cutting and pasting code.
32377 (Binary::ResolveOperator): Use MakeUnionSet.
32379 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32380 we have to convert to bool types. Not complete yet.
32382 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32384 * typemanager.cs (TypeManager::CSharpName): support ushort.
32386 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32387 to provide an expression that performsn an implicit constant int
32388 conversion (section 6.1.6).
32389 (Expression::ConvertImplicitRequired): Reworked to include
32390 implicit constant expression conversions.
32392 (Expression::ConvertNumericExplicit): Finished.
32394 (Invocation::Emit): If InstanceExpression is null, then it means
32395 that we perform a call on this.
32397 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32399 * expression.cs (Unary::Emit): Remove some dead code.
32400 (Probe): Implement Resolve and Emit for `is'.
32401 (Expression::ConvertImplicitRequired): Attempt to do constant
32402 expression conversions here. Maybe should be moved to
32403 ConvertImplicit, but I am not sure.
32404 (Expression::ImplicitLongConstantConversionPossible,
32405 Expression::ImplicitIntConstantConversionPossible): New functions
32406 that tell whether is it possible to apply an implicit constant
32407 expression conversion.
32409 (ConvertNumericExplicit): Started work on explicit numeric
32412 * cs-parser.jay: Update operator constants.
32414 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32415 (Parameters::GetSignature): Hook up VerifyArgs here.
32416 (Parameters::VerifyArgs): Verifies that no two arguments have the
32419 * class.cs (Operator): Update the operator names to reflect the
32420 ones that the spec expects (as we are just stringizing the
32423 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32424 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32425 previous usage did only work for our methods.
32426 (Expression::ConvertImplicit): Handle decimal implicit numeric
32427 conversions as well.
32428 (Expression::InternalTypeConstructor): Used to invoke constructors
32429 on internal types for default promotions.
32431 (Unary::Emit): Implement special handling for the pre/post
32432 increment/decrement for overloaded operators, as they need to have
32433 the same semantics as the other operators.
32435 (Binary::ResolveOperator): ditto.
32436 (Invocation::ConversionExists): ditto.
32437 (UserImplicitCast::Resolve): ditto.
32439 2001-09-26 Ravi Pratap <ravi@ximian.com>
32441 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32442 operator, return after emitting body. Regression tests pass again !
32444 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32445 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32446 (Invocation::OverloadResolve): Ditto.
32447 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32449 * everywhere : update calls to the above methods accordingly.
32451 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32453 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32455 * expression.cs (ExpressionStatement): New base class used for
32456 expressions that can appear in statements, so that we can provide
32457 an alternate path to generate expression that do not leave a value
32460 (Expression::Emit, and all the derivatives): We no longer return
32461 whether a value is left on the stack or not. Every expression
32462 after being emitted leaves a single value on the stack.
32464 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32465 facilties of ExpressionStatement if possible.
32467 * cs-parser.jay: Update statement_expression.
32469 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32471 * driver.cs: Change the wording of message
32473 2001-09-25 Ravi Pratap <ravi@ximian.com>
32475 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32476 the type of the expression to the return type of the method if
32477 we have an overloaded operator match ! The regression tests pass again !
32478 (Unary::ResolveOperator): Ditto.
32480 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32481 to find "op_Implicit", not "implicit" ;-)
32482 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32483 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32485 * everywhere : Correct calls to the above accordingly.
32487 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32488 (ConvertImplicit): Do user-defined conversion if it exists.
32490 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32492 * assign.cs: track location.
32493 (Resolve): Use implicit conversions on assignment.
32495 * literal.cs: Oops. Not good, Emit of short access values should
32496 pass (Bytes) or the wrong argument will be selected.
32498 * expression.cs (Unary::Emit): Emit code for -expr.
32500 (Unary::ResolveOperator): Handle `Substract' for non-constants
32501 (substract from zero from the non-constants).
32502 Deal with Doubles as well.
32504 (Expression::ConvertImplicitRequired): New routine that reports an
32505 error if no implicit conversion exists.
32507 (Invocation::OverloadResolve): Store the converted implicit
32508 expressions if we make them
32510 2001-09-24 Ravi Pratap <ravi@ximian.com>
32512 * class.cs (ConstructorInitializer): Take a Location argument.
32513 (ConstructorBaseInitializer): Same here.
32514 (ConstructorThisInitializer): Same here.
32516 * cs-parser.jay : Update all calls accordingly.
32518 * expression.cs (Unary, Binary, New): Take location argument.
32519 Update accordingly everywhere.
32521 * cs-parser.jay : Update all calls to the above to take a location
32524 * class.cs : Ditto.
32526 2001-09-24 Ravi Pratap <ravi@ximian.com>
32528 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32529 (Invocation::BetterConversion): Same here
32530 (Invocation::ConversionExists): Ditto.
32532 (Invocation::ConversionExists): Implement.
32534 2001-09-22 Ravi Pratap <ravi@ximian.com>
32536 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32537 Also take an additional TypeContainer argument.
32539 * All over : Pass in TypeContainer as argument to OverloadResolve.
32541 * typemanager.cs (CSharpName): Update to check for the string type and return
32544 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32547 2001-09-21 Ravi Pratap <ravi@ximian.com>
32549 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32550 (Invocation::BetterFunction): Implement.
32551 (Invocation::BetterConversion): Implement.
32552 (Invocation::ConversionExists): Skeleton, no implementation yet.
32554 Okay, things work fine !
32556 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32558 * typemanager.cs: declare and load enum_type, delegate_type and
32561 * expression.cs (Expression::Emit): Now emit returns a value that
32562 tells whether a value is left on the stack or not. This strategy
32563 might be reveted tomorrow with a mechanism that would address
32564 multiple assignments.
32565 (Expression::report118): Utility routine to report mismatches on
32568 (Unary::Report23): Report impossible type/operator combination
32571 (Unary::IsIncrementableNumber): Whether the type can be
32572 incremented or decremented with add.
32573 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32575 (Unary::ResolveOperator): Implement ++, !, ~,
32577 (Invocation::Emit): Deal with new Emit convetion.
32579 * All Expression derivatives: Updated their Emit method to return
32580 whether they leave values on the stack or not.
32582 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32583 stack for expressions that are statements.
32585 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32587 * expression.cs (LValue): New interface. Must be implemented by
32589 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32592 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32593 interface for generating code, simplifies the code.
32595 2001-09-20 Ravi Pratap <ravi@ximian.com>
32597 * expression.cs (everywhere): Comment out return statements in ::Resolve
32598 methods to avoid the warnings.
32600 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32602 * driver.cs (parse): Report error 2001 if we can not open the
32605 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32608 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32611 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32612 otherwise nested blocks end up with the same index.
32614 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32616 * expression.cs: Instead of having FIXMEs in the Resolve
32617 functions, throw exceptions so it is obvious that we are facing a
32620 * cs-parser.jay (invocation_expression): Pass Location information.
32622 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32623 Use a basename for those routines because .NET does not like paths
32626 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32629 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32631 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32632 are loading the correct data types (throws an exception if not).
32633 (TypeManager::InitCoreTypes): Use CoreLookupType
32635 * expression.cs (Unary::ResolveOperator): return the child
32636 expression for expressions which are just +expr.
32637 (Unary::ResolveOperator): Return negative literals for -LITERAL
32638 expressions (otherwise they are Unary {Literal}).
32639 (Invocation::Badness): Take into account `Implicit constant
32640 expression conversions'.
32642 * literal.cs (LongLiteral): Implement long literal class.
32643 (IntLiteral): export the `Value' of the intliteral.
32645 2001-09-19 Ravi Pratap <ravi@ximian.com>
32647 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32649 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32650 instead of 'Operator'
32652 * expression.cs (Binary::ResolveOperator): Update accordingly.
32653 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32656 * cs-parser.jay (unary_expression): Update to use the new names.
32658 * gen-treedump.cs (GetUnary): Same here.
32660 * expression.cs (Unary::Resolve): Implement.
32661 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32662 operators are found instead of making noise ;-)
32663 (Unary::ResolveOperator): New method to do precisely the same thing which
32664 Binary::ResolveOperator does for Binary expressions.
32665 (Unary.method, .Arguments): Add.
32666 (Unary::OperName): Implement.
32667 (Unary::ForceConversion): Copy and Paste !
32669 * class.cs (Operator::Define): Fix a small bug for the case when we have
32672 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32673 for the inbuilt operators. Only overloading works for now ;-)
32675 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32677 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32678 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32680 * expression.cs (This::Emit): Implement.
32681 (This::Resolve): Implement.
32682 (TypeOf:Resolve): Implement.
32683 (Expression::ResolveSimpleName): Add an implicit this to instance
32685 (MemberAccess::Resolve): Deal with Parameters and Fields.
32686 Bind instance variable to Field expressions.
32687 (FieldExpr::Instance): New field used to track the expression that
32688 represents the object instance.
32689 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32691 (FieldExpr::Emit): Implement.
32693 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32694 the last instruction contains a return opcode to avoid generating
32695 the last `ret' instruction (this generates correct code, and it is
32696 nice to pass the peverify output).
32698 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32699 initializer for static and instance variables.
32700 (Constructor::Emit): Allow initializer to be null in the case of
32701 static constructors. Only emit initializer for instance
32704 (TypeContainer::FindMembers): Return a null array if there are no
32707 Also fix the code for the MemberTypes.Method branch, as it was not
32708 scanning that for operators (or tried to access null variables before).
32710 * assign.cs (Assign::Emit): Handle instance and static fields.
32714 * driver.cs: Stop compilation if there are parse errors.
32716 * cs-parser.jay (constructor_declaration): Provide default base
32717 initializer for non-static constructors.
32718 (constructor_declarator): Do not provide a default base
32719 initializers if none was specified.
32720 Catch the fact that constructors should not have parameters.
32722 * class.cs: Do not emit parent class initializers for static
32723 constructors, that should be flagged as an error.
32725 2001-09-18 Ravi Pratap <ravi@ximian.com>
32727 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32728 Move back code into TypeContainer::Populate.
32730 2001-09-18 Ravi Pratap <ravi@ximian.com>
32732 * class.cs (TypeContainer::AddConstructor): Fix the check to
32733 compare against Name, not Basename.
32734 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32736 * cs-parser.jay : Update accordingly.
32738 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32739 for methods, don't forget to look into the operators too.
32740 (RegisterMethodBuilder): Helper method to take care of this for
32741 methods, constructors and operators.
32742 (Operator::Define): Completely revamp.
32743 (Operator.OperatorMethod, MethodName): New fields.
32744 (TypeContainer::Populate): Move the registering of builders into
32745 RegisterMethodBuilder.
32746 (Operator::Emit): Re-write.
32748 * expression.cs (Binary::Emit): Comment out code path to emit method
32749 invocation stuff for the case when we have a user defined operator. I am
32750 just not able to get it right !
32752 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32754 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32757 (Expression::MemberLookup): Provide a version that allows to
32758 specify the MemberTypes and BindingFlags.
32760 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32761 so it was not fetching variable information from outer blocks.
32763 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32764 Beforefieldinit as it was buggy.
32766 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32767 that Ravi put here.
32769 * class.cs (Constructor::Emit): Only emit if block is not null.
32770 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32771 deal with this by semantically definining it as if the user had
32774 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32775 constructors as we now "emit" them at a higher level.
32777 (TypeContainer::DefineDefaultConstructor): Used to define the
32778 default constructors if none was provided.
32780 (ConstructorInitializer): Add methods Resolve and Emit.
32782 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32784 2001-09-17 Ravi Pratap <ravi@ximian.com>
32786 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32787 the default constructor builder with our hashtable for methodbuilders
32790 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32791 and argument_count is 0 in which case we have a match.
32792 (Binary::ResolveOperator): More null checking and miscellaneous coding
32795 2001-09-17 Ravi Pratap <ravi@ximian.com>
32797 * rootcontext.cs (IsNameSpace): Compare against null.
32799 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32801 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32802 and Unary::Operator.
32804 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32807 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32808 we have overloaded operators.
32809 (Binary::ResolveOperator): Implement the part which does the operator overload
32812 * class.cs (Operator::Emit): Implement.
32813 (TypeContainer::Emit): Emit the operators we have too.
32815 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32816 the case when we have a user-defined operator.
32818 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32820 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32822 2001-09-16 Ravi Pratap <ravi@ximian.com>
32824 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32825 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32826 (Constructor::Emit): Implement.
32827 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32828 if we have no work to do.
32829 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32832 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32833 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32835 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32838 2001-09-15 Ravi Pratap <ravi@ximian.com>
32840 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32842 (Tree::RecordNamespace): Method to do what the name says ;-)
32843 (Tree::Namespaces): Property to get at the namespaces hashtable.
32845 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32848 * rootcontext.cs (IsNamespace): Fixed it :-)
32850 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32852 * class.cs (TypeContainer::FindMembers): Add support for
32854 (MethodCore): New class that encapsulates both the shared aspects
32855 of a Constructor and a Method.
32856 (Method, Constructor): Factored pieces into MethodCore.
32858 * driver.cs: Added --fatal which makes errors throw exceptions.
32859 Load System assembly as well as part of the standard library.
32861 * report.cs: Allow throwing exceptions on errors for debugging.
32863 * modifiers.cs: Do not use `parent', instead use the real type
32864 container to evaluate permission settings.
32866 * class.cs: Put Ravi's patch back in. He is right, and we will
32867 have to cope with the
32869 2001-09-14 Ravi Pratap <ravi@ximian.com>
32871 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32872 FamORAssem, not FamANDAssem.
32874 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32876 * driver.cs: Added --parse option that only parses its input files
32879 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32880 incorrect. IsTopLevel is not used to tell whether an object is
32881 root_types or not (that can be achieved by testing this ==
32882 root_types). But to see if this is a top-level *class* (not
32883 necessarly our "toplevel" container).
32885 2001-09-14 Ravi Pratap <ravi@ximian.com>
32887 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32888 parent instead of a direct call to GetType.
32890 2001-09-14 Ravi Pratap <ravi@ximian.com>
32892 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32893 Modifiers.TypeAttr. This should just be a call to that method.
32895 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32896 object so that we can determine if we are top-level or not.
32898 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32901 * enum.cs (Enum::Define): Ditto.
32903 * modifiers.cs (FieldAttr): Re-write.
32905 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32906 (TypeContainer::HaveStaticConstructor): New property to provide access
32907 to precisely that info.
32909 * modifiers.cs (MethodAttr): Re-write.
32910 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32912 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32913 of top-level types as claimed.
32915 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32917 * expression.cs (MemberLookup): Fruitless attempt to lookup
32918 constructors. Maybe I need to emit default constructors? That
32919 might be it (currently .NET emits this for me automatically).
32920 (Invocation::OverloadResolve): Cope with Arguments == null.
32921 (Invocation::EmitArguments): new function, shared by the new
32922 constructor and us.
32923 (Invocation::Emit): Handle static and instance methods. Emit
32924 proper call instruction for virtual or non-virtual invocations.
32925 (New::Emit): Implement.
32926 (New::Resolve): Implement.
32927 (MemberAccess:Resolve): Implement.
32928 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32929 to track instances.
32930 (FieldExpr::Resolve): Set type.
32932 * support.cs: Handle empty arguments.
32934 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32935 SimpleLookup): Auxiliary routines to help parse a qualifier
32938 Update qualifier_identifier rule.
32940 * codegen.cs: Removed debugging messages.
32942 * class.cs: Make this a global thing, this acts just as a "key" to
32943 objects that we might have around.
32945 (Populate): Only initialize method_builders_to_methods once.
32947 * expression.cs (PropertyExpr): Initialize type from the
32950 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32951 Resolve pattern. Attempt to implicitly convert value to boolean.
32954 * expression.cs: Set the type for the int32/int32 argument case.
32955 (Binary::ResolveOperator): Set the return type to boolean for
32956 comparission operators
32958 * typemanager.cs: Remove debugging print code.
32960 (Invocation::Resolve): resolve type.
32962 * class.cs: Allocate a MemberInfo of the correct size, as the code
32963 elsewhere depends on the test to reflect the correct contents.
32965 (Method::) Keep track of parameters, due to System.Reflection holes
32967 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32970 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32971 of the exact size and return that.
32973 (Class::LookupMethodByBuilder): New function that maps
32974 MethodBuilders to its methods. Required to locate the information
32975 on methods because System.Reflection bit us again.
32977 * support.cs: New file, contains an interface ParameterData and
32978 two implementations: ReflectionParameters and InternalParameters
32979 used to access Parameter information. We will need to grow this
32982 * expression.cs (Invocation::GetParameterData): implement a cache
32983 and a wrapper around the ParameterData creation for methods.
32984 (Invocation::OverloadResolve): Use new code.
32986 2001-09-13 Ravi Pratap <ravi@ximian.com>
32988 * class.cs (TypeContainer::EmitField): Remove and move into
32989 (Field::Define): here and modify accordingly.
32990 (Field.FieldBuilder): New member.
32991 (TypeContainer::Populate): Update accordingly.
32992 (TypeContainer::FindMembers): Implement.
32994 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32996 * statement.cs: (VariableInfo::VariableType): New field to be
32997 initialized with the full type once it is resolved.
32999 2001-09-12 Miguel de Icaza <miguel@ximian.com>
33001 * parameter.cs (GetParameterInfo): Use a type cache to compute
33002 things only once, and to reuse this information
33004 * expression.cs (LocalVariableReference::Emit): Implement.
33005 (OpcodeCast::Emit): fix.
33007 (ParameterReference::Resolve): Implement.
33008 (ParameterReference::Emit): Implement.
33010 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
33011 that are expressions need to stay as Expressions.
33013 * typemanager.cs (CSharpName): Returns the C# name of a type if
33016 * expression.cs (Expression::ConvertImplicit): New function that
33017 implements implicit type conversions.
33019 (Expression::ImplicitReferenceConversion): Implements implicit
33020 reference conversions.
33022 (EmptyCast): New type for transparent casts.
33024 (OpcodeCast): New type for casts of types that are performed with
33025 a sequence of bytecodes.
33027 (BoxedCast): New type used for casting value types into reference
33028 types. Emits a box opcode.
33030 (Binary::DoNumericPromotions): Implements numeric promotions of
33031 and computation of the Binary::Type.
33033 (Binary::EmitBranchable): Optimization.
33035 (Binary::Emit): Implement code emission for expressions.
33037 * typemanager.cs (TypeManager): Added two new core types: sbyte
33040 2001-09-12 Ravi Pratap <ravi@ximian.com>
33042 * class.cs (TypeContainer::FindMembers): Method which does exactly
33043 what Type.FindMembers does, only we don't have to use reflection. No
33044 implementation yet.
33046 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
33047 typecontainer objects as we need to get at them.
33048 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33050 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33051 typecontainer object.
33053 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33054 of just a Report object.
33056 2001-09-11 Ravi Pratap <ravi@ximian.com>
33058 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33060 (TypeContainer::Populate): Now define the delegates of the type too.
33061 (TypeContainer.Delegates): Property to access the list of delegates defined
33064 * delegates.cs (Delegate::Define): Implement partially.
33066 * modifiers.cs (TypeAttr): Handle more flags.
33068 2001-09-11 Ravi Pratap <ravi@ximian.com>
33070 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33072 (Operator::Define): Re-write logic to get types by using the LookupType method
33073 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33074 (Indexer::Define): Ditto.
33075 (Event::Define): Ditto.
33076 (Property::Define): Ditto.
33078 2001-09-10 Ravi Pratap <ravi@ximian.com>
33080 * class.cs (TypeContainer::Populate): Now define operators too.
33081 (TypeContainer.Operators): New property to access the list of operators
33083 (Operator.OperatorMethodBuilder): New member to hold the method builder
33084 for the operator we are defining.
33085 (Operator::Define): Implement.
33087 2001-09-10 Ravi Pratap <ravi@ximian.com>
33089 * class.cs (Event::Define): Make the prefixes of the accessor methods
33090 addOn_ and removeOn_
33092 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33093 of the location being passed in too. Ideally, this should go later since all
33094 error reporting should be done through the Report object.
33096 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33097 (Populate): Iterate thru the indexers we have and define them too.
33098 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33099 for the get and set accessors.
33100 (Indexer::Define): Implement.
33102 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33104 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33105 my previous implementation, did not work.
33107 * typemanager.cs: Add a couple of missing types (the longs).
33109 * literal.cs: Use TypeManager.bool_type instead of getting it.
33111 * expression.cs (EventExpr): New kind of expressions.
33112 (Expressio::ExprClassFromMemberInfo): finish
33114 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33116 * assign.cs: Emit stores to static fields differently.
33118 2001-09-08 Ravi Pratap <ravi@ximian.com>
33120 * Merge in changes and adjust code to tackle conflicts. Backed out my
33121 code in Assign::Resolve ;-)
33123 2001-09-08 Ravi Pratap <ravi@ximian.com>
33125 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33126 instead Report.Error and also pass in the location.
33127 (CSharpParser::Lexer): New readonly property to return the reference
33128 to the Tokenizer object.
33129 (declare_local_variables): Use Report.Error with location instead of plain
33133 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33134 (Operator.CheckBinaryOperator): Ditto.
33136 * cs-parser.jay (operator_declarator): Update accordingly.
33138 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33139 (CheckBinaryOperator): Same here.
33141 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33142 on the name without any prefixes of namespace names etc. This is because we
33143 already might have something already fully qualified like
33144 'System.Console.WriteLine'
33146 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33148 2001-09-07 Ravi Pratap <ravi@ximian.com>
33150 * cs-tokenizer.cs (location): Return a string which also contains
33153 * expression.cs (ElementAccess): New class for expressions of the
33154 type 'element access.'
33155 (BaseAccess): New class for expressions of the type 'base access.'
33156 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33159 * cs-parser.jay (element_access): Implement action.
33160 (base_access): Implement actions.
33161 (checked_expression, unchecked_expression): Implement.
33163 * cs-parser.jay (local_variable_type): Correct and implement.
33164 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33166 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33168 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33169 name and the specifiers.
33171 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33173 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33174 making them all public ;-)
33176 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33179 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33181 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33183 (FieldExpr, PropertyExprs): New resolved expressions.
33184 (SimpleName::MemberStaticCheck): Perform static checks for access
33185 to non-static fields on static methods. Maybe this should be
33186 generalized for MemberAccesses.
33187 (SimpleName::ResolveSimpleName): More work on simple name
33190 * cs-parser.jay (primary_expression/qualified_identifier): track
33191 the parameter index.
33193 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33194 (EmitContext::EmitBoolExpression): Chain to expression generation
33195 instead of temporary hack.
33196 (::EmitStatementExpression): Put generic expression code generation.
33198 * assign.cs (Assign::Emit): Implement variable assignments to
33199 local variables, parameters and fields.
33201 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33203 * statement.cs (Block::GetVariableInfo): New method, returns the
33204 VariableInfo for a variable name in a block.
33205 (Block::GetVariableType): Implement in terms of GetVariableInfo
33207 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33208 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33210 2001-09-06 Ravi Pratap <ravi@ximian.com>
33212 * cs-parser.jay (operator_declaration): Continue on my quest : update
33213 to take attributes argument.
33214 (event_declaration): Ditto.
33215 (enum_declaration): Ditto.
33216 (indexer_declaration): Ditto.
33218 * class.cs (Operator::Operator): Update constructor accordingly.
33219 (Event::Event): Ditto.
33221 * delegate.cs (Delegate::Delegate): Same here.
33223 * enum.cs (Enum::Enum): Same here.
33225 2001-09-05 Ravi Pratap <ravi@ximian.com>
33227 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33229 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33231 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33232 being passed around as an arraylist.
33233 (Attributes::AddAttribute): Method to add attribute sections.
33235 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33236 (struct_declaration): Update accordingly.
33237 (constant_declaration): Update.
33238 (field_declaration): Update.
33239 (method_header): Update.
33240 (fixed_parameter): Update.
33241 (parameter_array): Ditto.
33242 (property_declaration): Ditto.
33243 (destructor_declaration): Ditto.
33245 * class.cs (Struct::Struct): Update constructors accordingly.
33246 (Class::Class): Ditto.
33247 (Field::Field): Ditto.
33248 (Method::Method): Ditto.
33249 (Property::Property): Ditto.
33250 (TypeContainer::OptAttribute): update property's return type.
33252 * interface.cs (Interface.opt_attributes): New member.
33253 (Interface::Interface): Update to take the extra Attributes argument.
33255 * parameter.cs (Parameter::Parameter): Ditto.
33257 * constant.cs (Constant::Constant): Ditto.
33259 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33260 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33261 the attributes as a parameter.
33262 (InterfaceProperty): Update constructor call.
33263 (InterfaceEvent): Ditto.
33264 (InterfaceMethod): Ditto.
33265 (InterfaceIndexer): Ditto.
33267 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33268 pass the attributes too.
33269 (interface_event_declaration): Ditto.
33270 (interface_property_declaration): Ditto.
33271 (interface_method_declaration): Ditto.
33272 (interface_declaration): Ditto.
33274 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33276 * class.cs (Method::Define): Track the "static Main" definition to
33277 create an entry point.
33279 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33280 EntryPoint if we find it.
33282 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33283 (EmitContext::ig): Make this variable public.
33285 * driver.cs: Make the default output file be the first file name
33286 with the .exe extension.
33288 Detect empty compilations
33290 Handle various kinds of output targets. Handle --target and
33291 rename -t to --dumper.
33293 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33294 methods inherited from Expression return now an Expression. This
33295 will is used during the tree rewriting as we resolve them during
33298 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33299 the spec. Missing entirely is the information about
33300 accessability of elements of it.
33302 (Expression::ExprClassFromMemberInfo): New constructor for
33303 Expressions that creates a fully initialized Expression based on
33304 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33307 (Invocation::Resolve): Begin implementing resolution of invocations.
33309 * literal.cs (StringLiteral): Implement Emit.
33311 2001-09-05 Ravi Pratap <ravi@ximian.com>
33313 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33316 2001-09-04 Ravi Pratap <ravi@ximian.com>
33318 * cs-parser.jay (attribute_arguments): Implement actions.
33319 (attribute): Fix bug in production. Implement action.
33320 (attribute_list): Implement.
33321 (attribute_target): Implement.
33322 (attribute_target_specifier, opt_target_specifier): Implement
33323 (CheckAttributeTarget): New method to check if the attribute target
33325 (attribute_section): Implement.
33326 (opt_attributes): Implement.
33328 * attribute.cs : New file to handle attributes.
33329 (Attribute): Class to hold attribute info.
33331 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33332 (attribute_section): Modify production to use 2 different rules to
33333 achieve the same thing. 1 s/r conflict down !
33334 Clean out commented, useless, non-reducing dimension_separator rules.
33336 * class.cs (TypeContainer.attributes): New member to hold list
33337 of attributes for a type.
33338 (Struct::Struct): Modify to take one more argument, the attribute list.
33339 (Class::Class): Ditto.
33340 (Field::Field): Ditto.
33341 (Method::Method): Ditto.
33342 (Property::Property): Ditto.
33344 * cs-parser.jay (struct_declaration): Update constructor call to
33345 pass in the attributes too.
33346 (class_declaration): Ditto.
33347 (constant_declaration): Ditto.
33348 (field_declaration): Ditto.
33349 (method_header): Ditto.
33350 (fixed_parameter): Ditto.
33351 (parameter_array): Ditto.
33352 (property_declaration): Ditto.
33354 * constant.cs (Constant::Constant): Update constructor similarly.
33355 Use System.Collections.
33357 * parameter.cs (Parameter::Parameter): Update as above.
33359 2001-09-02 Ravi Pratap <ravi@ximian.com>
33361 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33362 (TypeContainer.delegates): New member to hold list of delegates.
33364 * cs-parser.jay (delegate_declaration): Implement the action correctly
33365 this time as I seem to be on crack ;-)
33367 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33369 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33370 tell whether an identifier represents a namespace.
33372 * expression.cs (NamespaceExpr): A namespace expression, used only
33373 temporarly during expression resolution.
33374 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33375 utility functions to resolve names on expressions.
33377 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33379 * codegen.cs: Add hook for StatementExpressions.
33381 * class.cs: Fix inverted test for static flag in methods.
33383 2001-09-02 Ravi Pratap <ravi@ximian.com>
33385 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33386 to make it coincide with MS' number.
33387 (Operator::CheckBinaryOperator): Ditto.
33389 * ../errors/errors.txt : Remove error numbers added earlier.
33391 * ../errors/cs1019.cs : Test case for error # 1019
33393 * ../errros/cs1020.cs : Test case for error # 1020
33395 * cs-parser.jay : Clean out commented cruft.
33396 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33397 used anywhere - non-reducing rule.
33398 (namespace_declarations): Non-reducing rule - comment out.
33400 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33401 with TypeContainer::AddEnum.
33403 * delegate.cs : New file for delegate handling classes.
33404 (Delegate): Class for declaring delegates.
33406 * makefile : Update.
33408 * cs-parser.jay (delegate_declaration): Implement.
33410 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33412 * class.cs (Event::Define): Implement.
33413 (Event.EventBuilder): New member.
33415 * class.cs (TypeContainer::Populate): Update to define all enums and events
33417 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33418 readonly fields for all these cases ?
33420 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33422 * class.cs (Property): Revamp to use the convention of making fields readonly.
33423 Accordingly modify code elsewhere.
33425 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33426 the Define method of the Property class.
33428 * class.cs : Clean up applied patch and update references to variables etc. Fix
33430 (TypeContainer::Populate): Update to define all the properties we have. Also
33431 define all enumerations.
33433 * enum.cs (Define): Implement.
33435 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33437 * cs-parser.jay (overloadable_operator): The semantic value is an
33438 enum of the Operator class.
33439 (operator_declarator): Implement actions.
33440 (operator_declaration): Implement.
33442 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33443 validity of definitions.
33444 (Operator::CheckBinaryOperator): Static method to check for binary operators
33445 (TypeContainer::AddOperator): New method to add an operator to a type.
33447 * cs-parser.jay (indexer_declaration): Added line to actually call the
33448 AddIndexer method so it gets added ;-)
33450 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33451 already taken care of by the MS compiler ?
33453 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33455 * class.cs (Operator): New class for operator declarations.
33456 (Operator::OpType): Enum for the various operators.
33458 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33460 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33461 ostensibly handle this in semantic analysis.
33463 * cs-parser.jay (general_catch_clause): Comment out
33464 (specific_catch_clauses, specific_catch_clause): Ditto.
33465 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33466 (catch_args, opt_catch_args): New productions.
33467 (catch_clause): Rewrite to use the new productions above
33468 (catch_clauses): Modify accordingly.
33469 (opt_catch_clauses): New production to use in try_statement
33470 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33471 and re-write the code in the actions to extract the specific and
33472 general catch clauses by being a little smart ;-)
33474 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33475 Hooray, try and catch statements parse fine !
33477 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33479 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33480 string from the hashtable of variables.
33482 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33483 I end up making that mistake ;-)
33484 (catch_clauses): Fixed gross error which made Key and Value of the
33485 DictionaryEntry the same : $1 !!
33487 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33489 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33491 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33492 when the add and remove accessors are specified.
33494 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33496 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33497 information about indexer_declarator.
33498 (indexer_declarator): Implement actions.
33499 (parsing_indexer): New local boolean used to keep track of whether
33500 we are parsing indexers or properties. This is necessary because
33501 implicit_parameters come into picture even for the get accessor in the
33502 case of an indexer.
33503 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33505 * class.cs (Indexer): New class for indexer declarations.
33506 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33507 (TypeContainer::indexers): New member to hold list of indexers for the
33510 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33512 * cs-parser.jay (add_accessor_declaration): Implement action.
33513 (remove_accessor_declaration): Implement action.
33514 (event_accessors_declaration): Implement
33515 (variable_declarators): swap statements for first rule - trivial.
33517 * class.cs (Event): New class to hold information about event
33519 (TypeContainer::AddEvent): New method to add an event to a type
33520 (TypeContainer::events): New member to hold list of events.
33522 * cs-parser.jay (event_declaration): Implement actions.
33524 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33526 * cs-parser.jay (dim_separators): Implement. Make it a string
33527 concatenating all the commas together, just as they appear.
33528 (opt_dim_separators): Modify accordingly
33529 (rank_specifiers): Update accordingly. Basically do the same
33530 thing - instead, collect the brackets here.
33531 (opt_rank_sepcifiers): Modify accordingly.
33532 (array_type): Modify to actually return the complete type string
33533 instead of ignoring the rank_specifiers.
33534 (expression_list): Implement to collect the expressions
33535 (variable_initializer): Implement. We make it a list of expressions
33536 essentially so that we can handle the array_initializer case neatly too.
33537 (variable_initializer_list): Implement.
33538 (array_initializer): Make it a list of variable_initializers
33539 (opt_array_initializer): Modify accordingly.
33541 * expression.cs (New::NType): Add enumeration to help us
33542 keep track of whether we have an object/delegate creation
33543 or an array creation.
33544 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33545 members to hold data about array creation.
33546 (New:New): Modify to update NewType
33547 (New:New): New Overloaded contructor for the array creation
33550 * cs-parser.jay (array_creation_expression): Implement to call
33551 the overloaded New constructor.
33553 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33555 * class.cs (TypeContainer::Constructors): Return member
33556 constructors instead of returning null.
33558 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33560 * typemanager.cs (InitCoreTypes): Initialize the various core
33561 types after we have populated the type manager with the user
33562 defined types (this distinction will be important later while
33563 compiling corlib.dll)
33565 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33566 on Expression Classification. Now all expressions have a method
33567 `Resolve' and a method `Emit'.
33569 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33570 generation from working. Also add some temporary debugging
33573 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33575 * codegen.cs: Lots of code generation pieces. This is only the
33576 beginning, will continue tomorrow with more touches of polish. We
33577 handle the fundamentals of if, while, do, for, return. Others are
33578 trickier and I need to start working on invocations soon.
33580 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33583 * codegen.cs (EmitContext): New struct, used during code
33584 emission to keep a context. Most of the code generation will be
33587 * cs-parser.jay: Add embedded blocks to the list of statements of
33588 this block. So code generation proceeds in a top down fashion.
33590 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33592 * statement.cs: Add support for multiple child blocks.
33594 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33596 * codegen.cs (EmitCode): New function, will emit the code for a
33597 Block of code given a TypeContainer and its ILGenerator.
33599 * statement.cs (Block): Standard public readonly optimization.
33600 (Block::Block constructors): Link children.
33601 (Block::Child): Child Linker.
33602 (Block::EmitVariables): Emits IL variable declarations.
33604 * class.cs: Drop support for MethodGroups here, delay until
33606 (Method::): Applied the same simplification that I did before, and
33607 move from Properties to public readonly fields.
33608 (Method::ParameterTypes): Returns the parameter types for the
33609 function, and implements a cache that will be useful later when I
33610 do error checking and the semantic analysis on the methods is
33612 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33613 and made a method, optional argument tells whether this is a class
33614 or a structure to apply the `has-this' bit.
33615 (Method::GetCallingConvention): Implement, returns the calling
33617 (Method::Define): Defines the type, a second pass is performed
33618 later to populate the methods.
33620 (Constructor::ParameterTypes): implement a cache similar to the
33621 one on Method::ParameterTypes, useful later when we do semantic
33624 (TypeContainer::EmitMethod): New method. Emits methods.
33626 * expression.cs: Removed MethodGroup class from here.
33628 * parameter.cs (Parameters::GetCallingConvention): new method.
33630 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33632 * class.cs (TypeContainer::Populate): Drop RootContext from the
33635 (Constructor::CallingConvention): Returns the calling convention.
33636 (Constructor::ParameterTypes): Returns the constructor parameter
33639 (TypeContainer::AddConstructor): Keep track of default constructor
33640 and the default static constructor.
33642 (Constructor::) Another class that starts using `public readonly'
33643 instead of properties.
33645 (Constructor::IsDefault): Whether this is a default constructor.
33647 (Field::) use readonly public fields instead of properties also.
33649 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33650 track of static constructors; If none is used, turn on
33651 BeforeFieldInit in the TypeAttributes.
33653 * cs-parser.jay (opt_argument_list): now the return can be null
33654 for the cases where there are no arguments.
33656 (constructor_declarator): If there is no implicit `base' or
33657 `this', then invoke the default parent constructor.
33659 * modifiers.cs (MethodAttr): New static function maps a set of
33660 modifiers flags into a MethodAttributes enum
33661 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33662 MethodAttr, TypeAttr to represent the various mappings where the
33663 modifiers are used.
33664 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33666 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33668 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33671 * interface.cs (PopulateIndexer): Implemented the code generator
33672 for interface indexers.
33674 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33676 * interface.cs (InterfaceMemberBase): Now we track the new status
33679 (PopulateProperty): Implement property population. Woohoo! Got
33680 Methods and Properties going today.
33682 Removed all the properties for interfaces, and replaced them with
33683 `public readonly' fields.
33685 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33687 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33688 initialize their hashtables/arraylists only when they are needed
33689 instead of doing this always.
33691 * parameter.cs: Handle refs and out parameters.
33693 * cs-parser.jay: Use an ArrayList to construct the arguments
33694 instead of the ParameterCollection, and then cast that to a
33697 * parameter.cs: Drop the use of ParameterCollection and use
33698 instead arrays of Parameters.
33700 (GetParameterInfo): Use the Type, not the Name when resolving
33703 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33705 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33706 and instead use public readonly fields.
33708 * class.cs: Put back walking code for type containers.
33710 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33712 * class.cs (MakeConstant): Code to define constants.
33714 * rootcontext.cs (LookupType): New function. Used to locate types
33717 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33719 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33720 this System.Reflection code is. Kudos to Microsoft
33722 * typemanager.cs: Implement a type cache and avoid loading all
33723 types at boot time. Wrap in LookupType the internals. This made
33724 the compiler so much faster. Wow. I rule!
33726 * driver.cs: Make sure we always load mscorlib first (for
33727 debugging purposes, nothing really important).
33729 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33730 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33732 * rootcontext.cs: Lookup types on their namespace; Lookup types
33733 on namespaces that have been imported using the `using' keyword.
33735 * class.cs (TypeContainer::TypeAttr): Virtualize.
33736 (Class::TypeAttr): Return attributes suitable for this bad boy.
33737 (Struct::TypeAttr): ditto.
33738 Handle nested classes.
33739 (TypeContainer::) Remove all the type visiting code, it is now
33740 replaced with the rootcontext.cs code
33742 * rootcontext.cs (GetClassBases): Added support for structs.
33744 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33746 * interface.cs, statement.cs, class.cs, parameter.cs,
33747 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33748 Drop use of TypeRefs, and use strings instead.
33750 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33754 * class.cs (Struct::Struct): set the SEALED flags after
33755 checking the modifiers.
33756 (TypeContainer::TypeAttr): new property, returns the
33757 TypeAttributes for a class.
33759 * cs-parser.jay (type_list): Oops, list production was creating a
33760 new list of base types.
33762 * rootcontext.cs (StdLib): New property.
33763 (GetInterfaceTypeByName): returns an interface by type name, and
33764 encapsulates error handling here.
33765 (GetInterfaces): simplified.
33766 (ResolveTree): Encapsulated all the tree resolution here.
33767 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33770 * driver.cs: Add support for --nostdlib, to avoid loading the
33771 default assemblies.
33772 (Main): Do not put tree resolution here.
33774 * rootcontext.cs: Beginning of the class resolution.
33776 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33778 * rootcontext.cs: Provide better error reporting.
33780 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33782 * rootcontext.cs (CreateInterface): Handle the case where there
33783 are no parent interfaces.
33785 (CloseTypes): Routine to flush types at the end.
33786 (CreateInterface): Track types.
33787 (GetInterfaces): Returns an array of Types from the list of
33788 defined interfaces.
33790 * typemanager.c (AddUserType): Mechanism to track user types (puts
33791 the type on the global type hash, and allows us to close it at the
33794 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33796 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33797 RecordInterface instead.
33799 * cs-parser.jay: Updated to reflect changes above.
33801 * decl.cs (Definition): Keep track of the TypeBuilder type that
33802 represents this type here. Not sure we will use it in the long
33803 run, but wont hurt for now.
33805 * driver.cs: Smaller changes to accomodate the new code.
33807 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33810 * rootcontext.cs (CreateInterface): New method, used to create
33811 the System.TypeBuilder type for interfaces.
33812 (ResolveInterfaces): new entry point to resolve the interface
33814 (CodeGen): Property, used to keep track of the code generator.
33816 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33818 * cs-parser.jay: Add a second production for delegate_declaration
33821 (enum_body): Put an opt_comma here instead of putting it on
33822 enum_body or enum_member_declarations so we can handle trailing
33823 commas on enumeration members. Gets rid of a shift/reduce.
33825 (type_list): Need a COMMA in the middle.
33827 (indexer_declaration): Tell tokenizer to recognize get/set
33829 * Remove old targets.
33831 * Re-add the parser target.
33833 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33835 * cs-parser.jay: Add precendence rules for a number of operators
33836 ot reduce the number of shift/reduce conflicts in the grammar.
33838 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33840 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33843 Get rid of old crufty code.
33845 * rootcontext.cs: Use this to keep track of the parsed
33846 representation and the defined types available to the program.
33848 * gen-treedump.cs: adjust for new convention.
33850 * type.cs: Split out the type manager, and the assembly builder
33853 * typemanager.cs: the type manager will live here now.
33855 * cil-codegen.cs: And the code generator here.
33857 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33859 * makefile: Fixed up for easy making.
33861 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33863 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33866 (unary_expression): Expand pre_increment_expression and
33867 post_decrement_expression to reduce a shift/reduce.
33869 2001-07-11 Simon Cozens
33871 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33873 Improve allow_keyword_as_indent name.
33875 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33877 * Adjustments for Beta2.
33879 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33881 * decl.cs: Added `Define' abstract method.
33882 (InTransit): new property, used to catch recursive definitions.
33884 * interface.cs: Implement `Define'.
33886 * modifiers.cs: Map Modifiers.constants to
33887 System.Reflection.TypeAttribute flags.
33889 * class.cs: Keep track of types and user-defined types.
33890 (BuilderInit): New method for creating an assembly
33891 (ResolveType): New function to launch the resolution process, only
33892 used by interfaces for now.
33894 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33895 that are inserted into the name space.
33897 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33899 * ARGH. I have screwed up my tree so many times due to the use of
33900 rsync rather than using CVS. Going to fix this at once.
33902 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33905 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33907 * Experiment successful: Use System.Type rather that our own
33910 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33912 * cs-parser.jay: Removed nsAliases from here.
33914 Use new namespaces, handle `using XXX;'
33916 * namespace.cs: Reimplemented namespace handling, use a recursive
33917 definition of the class. Now we can keep track of using clauses
33918 and catch invalid using clauses.
33920 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33922 * gen-treedump.cs: Adapted for all the renaming.
33924 * expression.cs (Expression): this class now has a Type property
33925 which returns an expression Type.
33927 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33928 `Type', as this has a different meaning now in the base
33930 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33932 * interface.cs, class.cs: Removed from all the sources the
33933 references to signature computation, as we can not do method
33934 signature computation during the parsing time, as we are not
33935 trying to solve at that point distinguishing:
33939 void a (NS.Blah x) {}
33942 Which depending on the context might be valid or not, as we do not
33943 know if Blah is the same thing as NS.Blah at that point.
33945 * Redid everything so the code uses TypeRefs now instead of
33946 Types. TypeRefs are just temporary type placeholders, that need
33947 to be resolved. They initially have a pointer to a string and the
33948 current scope in which they are used. This is used later by the
33949 compiler to resolve the reference to an actual Type.
33951 * DeclSpace is no longer a CIR.Type, and neither are
33952 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33953 are all DeclSpaces, but no Types.
33955 * type.cs (TypeRefManager): This implements the TypeRef manager,
33956 which keeps track of all the types that need to be resolved after
33957 the parsing has finished.
33959 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33961 * ARGH. We are going to have to store `foreach' as a class rather
33962 than resolving it, as we need to verify error 1579 after name
33963 resolution. *OR* we could keep a flag that says `This request to
33964 IEnumerator comes from a foreach statement' which we can then use
33965 to generate the error.
33967 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33969 * class.cs (TypeContainer.AddMethod): we now add methods to the
33970 MethodGroup instead of the method hashtable.
33972 * expression.cs: Add MethodGroup abstraction, which gets us one
33973 step closer to the specification in the way we handle method
33976 * cs-parser.jay (primary_expression): qualified_identifier now
33977 tried to match up an identifier to a local variable reference or
33978 to a parameter reference.
33980 current_local_parameters is now a parser global variable that
33981 points to the current parameters for the block, used during name
33984 (property_declaration): Now creates an implicit `value' argument to
33987 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33989 * parameter.cs: Do not use `param' arguments as part of the
33990 signature, per the spec.
33992 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33994 * decl.cs: Base class for classes, structs and interfaces. This
33995 is the "Declaration Space"
33997 * cs-parser.jay: Use CheckDef for checking declaration errors
33998 instead of having one on each function.
34000 * class.cs: Factor out some code for handling error handling in
34001 accordance to the "Declarations" section in the "Basic Concepts"
34002 chapter in the ECMA C# spec.
34004 * interface.cs: Make all interface member classes derive from
34005 InterfaceMemberBase.
34007 2001-05-07 Miguel de Icaza <miguel@ximian.com>
34009 * Many things: all interfaces are parsed and generated in
34010 gen-treedump. Support for member variables, constructors,
34011 destructors, properties, constants is there.
34013 Beginning of the IL backend, but very little done, just there for
34016 2001-04-29 Miguel de Icaza <miguel@ximian.com>
34018 * cs-parser.jay: Fix labeled statement.
34020 * cs-tokenizer.cs (escape): Escape " and ' always.
34021 ref_line, ref_name: keep track of the line/filename as instructed
34022 by #line by the compiler.
34025 2001-04-27 Miguel de Icaza <miguel@ximian.com>
34027 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
34028 to match the values in System.CodeDOM.
34030 Divid renamed to Divide.
34032 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
34034 (Statements.set): remove.
34036 * System.CodeDOM/CodeCatchClause.cs: always have a valid
34039 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
34040 falseStatements always have valid values.
34042 * cs-parser.jay: Use System.CodeDOM now.