1 2004-09-15 Marek Safar <marek.safar@seznam.cz>
3 Fixed bug #59980, #64224
4 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
6 * typemanager.cs (IsSpecialMethod): Simplified
8 2004-09-14 Marek Safar <marek.safar@seznam.cz>
10 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11 condition with better params.
13 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16 * attribute.cs (Resolve): Property has to have both
19 2004-09-14 Martin Baulig <martin@ximian.com>
21 Merged latest changes into gmcs. Please keep this comment in
22 here, it makes it easier for me to see what changed in MCS since
23 the last time I merged.
25 2004-09-14 Martin Baulig <martin@ximian.com>
27 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
29 2004-09-14 Marek Safar <marek.safar@seznam.cz>
32 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
33 called and is obsolete then this member suppress message
34 when call is inside next [Obsolete] method or type.
36 * expression.cs: Use TestObsoleteMethodUsage member.
38 2004-09-14 Martin Baulig <martin@ximian.com>
40 * cs-parser.jay: Sync a bit with the GMCS version.
42 2004-09-14 Martin Baulig <martin@ximian.com>
44 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
45 (CSharpParser.yacc_verbose_flag): New public field.
47 * genericparser.cs: Removed.
49 2004-09-14 Raja R Harinath <rharinath@novell.com>
51 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
53 2004-09-13 Marek Safar <marek.safar@seznam.cz>
55 * class.cs (MethodCore.CheckBase): Fix bug #65757.
57 2004-09-10 Martin Baulig <martin@ximian.com>
59 Backported my MemberName changes from GMCS into MCS.
61 - we are now using a special `MemberName' class instead of using
62 strings; in GMCS, the `MemberName' also contains the type
65 - changed the grammar rules a bit:
66 * the old `member_name' is now a `namespace_or_type_name':
67 The rule is that we use `namespace_or_type_name' everywhere
68 where we expect either a "member name" (GetEnumerator) or a
69 "member name" with an explicit interface name
70 (IEnumerable.GetEnumerator).
71 In GMCS, the explicit interface name may include type arguments
72 (IEnumerable<T>.GetEnumerator).
73 * we use `member_name' instead of just `IDENTIFIER' for
75 The rule is that we use `member_name' wherever a member may
76 have type parameters in GMCS.
78 * decl.cs (MemberName): New public class.
79 (MemberCore.MemberName): New public readonly field.
80 (MemberCore.ctor): Take a `MemberName' argument, not a string.
81 (DeclSpace): Likewise.
83 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
84 * enum.cs (Enum.ctor): Likewise.
86 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
88 (AliasEntry.ctor): Take a MemberName, not an Expression.
89 (AliasEntry.UsingAlias): Likewise.
91 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
92 (IMethodData.MemberName): Changed type from string to MemberName.
93 (MemberBase.ExplicitInterfaceName): Likewise.
94 (AbstractPropertyEventMethod.SetupName): Make this private.
95 (AbstractPropertyEventMethod.ctor): Added `string prefix'
96 argument; compute the member name here.
97 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
98 on the `member.MemberName' and the `prefix'.
100 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
102 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
103 thus, we get a `MemberName' instead of a `string'. These
104 declarations may have type parameters in GMCS.
105 (interface_method_declaration, delegate_declaration): Likewise.
106 (class_declaration, interface_declaration): Likewise.
107 (method_header): Use `namespace_or_type_name' instead of
108 `member_name'. We may be an explicit interface implementation.
109 (property_declaration, event_declaration): Likewise.
110 (member_name): This is now just an `IDENTIFIER', not a
111 `namespace_or_type_name'.
112 (type_name, interface_type): Removed.
113 (namespace_or_type_name): Return a MemberName, not an Expression.
114 (primary_expression): Use `member_name' instead of `IDENTIFIER';
115 call GetTypeExpression() on the MemberName to get an expression.
116 (IndexerDeclaration.interface_type): Changed type from string to
118 (MakeName): Operate on MemberName's instead of string's.
120 2004-09-13 Raja R Harinath <rharinath@novell.com>
123 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
124 (NamespaceEntry.Lookup): Add new argument to flag if we want the
125 lookup to avoid symbols introduced by 'using'.
126 * rootcontext.cs (NamespaceLookup): Update.
128 2004-09-12 Marek Safar <marek.safar@seznam.cz>
130 * class.cs (TypeContainer.DoDefineMembers): Do not call
131 DefineDefaultConstructor for static classes.
133 2004-09-12 Marek Safar <marek.safar@seznam.cz>
135 * attribute.cs (Attribute.Resolve): Add error 653 report.
137 * class.cs (Class.ApplyAttributeBuilder): Add error 641
139 (Method.ApplyAttributeBuilder): Add error 685 report.
140 (Operator.Define): Add error 564 report.
142 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
144 * expression.cs (Invocation.DoResolve): Add error
147 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
150 2004-09-11 Marek Safar <marek.safar@seznam.cz>
152 * class.cs (ConstructorInitializer.Resolve):
153 Wrong error number (515->516).
155 2004-09-11 Marek Safar <marek.safar@seznam.cz>
157 * class.cs (Indexer.Define): Add error 631 report.
159 2004-09-11 Marek Safar <marek.safar@seznam.cz>
161 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
163 2004-09-11 Marek Safar <marek.safar@seznam.cz>
165 * expression.cs (Probe.DoResolve): Add error CS0241 report.
167 2004-09-10 Marek Safar <marek.safar@seznam.cz>
169 * cs-parser.jay: Added error CS0241 report.
171 2004-09-10 Raja R Harinath <rharinath@novell.com>
173 * cs-parser.jay (fixed_statement): Introduce a scope for the
174 declaration in the 'fixed' statement.
176 2004-09-09 Marek Safar <marek.safar@seznam.cz>
178 * cs-parser.jay: Added CS0230 error report.
180 2004-09-09 Marek Safar <marek.safar@seznam.cz>
182 * cs-parser.jay: Added errors CS0231 and CS0257 report.
184 2004-09-09 Marek Safar <marek.safar@seznam.cz>
186 * expression.cs (Argument.Resolve): Added error CS0192 and
189 2004-09-09 Marek Safar <marek.safar@seznam.cz>
191 C# 2.0 #pragma warning feature
193 * cs-tokenizer.cs (PreProcessPragma): New method;
194 Handles #pragma directive.
196 * report.cs (WarningRegions): New class; Support
197 class for #pragma warning directive. It tests whether
198 warning is enabled for a given line.
200 2004-09-08 Miguel de Icaza <miguel@ximian.com>
202 * const.cs: Add more descriptive error report, tahnks to
205 2004-09-08 Marek Safar <marek.safar@seznam.cz>
207 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
209 2004-09-07 Miguel de Icaza <miguel@ximian.com>
211 * expression.cs: Apply patch from Ben: Remove dead code from
212 ArrayCreation, and remove the TurnintoConstant call in const.cs,
213 as that code just threw an exception anwyays.
215 * const.cs: Remove the call to the turnintoconstant, for details
218 * literal.cs: The type of the null-literal is the null type; So
219 we use a placeholder type (literal.cs:System.Null, defined here)
222 * expression.cs (Conditional.DoResolve): Remove some old code that
223 is no longer needed, conversions have been fixed.
225 (ArrayCreationExpression.DoResolve): Return false if we fail to
226 resolve the inner expression.
228 2004-09-07 Raja R Harinath <rharinath@novell.com>
231 * cs-parser.jay (delegate_declaration): Record a delegate
232 declaration as a type declaration.
233 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
235 2004-09-06 Miguel de Icaza <miguel@ximian.com>
237 * parameter.cs: Do not crash if the type can not be resolved.
239 * expression.cs: Report errors with unsafe pointers, fixes #64896
241 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
243 * expression.cs: Pointer arith always needs to do a conv.i
244 if the operand is a long. fix 65320
246 2004-09-04 Marek Safar <marek.safar@seznam.cz>
248 Fixed cs0619-37.cs, cs0619-38.cs
250 * enum.cs (GetObsoleteAttribute): Removed.
252 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
253 on Enum member is double staged. The first is tested member
256 2004-09-04 Marek Safar <marek.safar@seznam.cz>
258 Fixed #56986, #63631, #65231
260 * class.cs: (TypeContainer.AddToMemberContainer): New method,
261 adds member to name container.
262 (TypeContainer.AddToTypeContainer): New method, adds type to
264 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
265 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
266 AddOperator): Simplified by reusing AddToMemberContainer.
267 (TypeContainer.UserDefinedStaticConstructor): Changed to property
269 (Method.CheckForDuplications): Fixed implementation to test all
271 (MemberBase): Detection whether member is explicit interface
272 implementation is now in constructor.
273 (MemberBase.UpdateMemberName): Handles IndexerName.
274 (Accessor): Changed to keep also location information.
275 (AbstractPropertyEventMethod): Is derived from MemberCore.
276 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
277 will be emited or not.
278 (PropertyBase.AreAccessorsDuplicateImplementation):
279 Tests whether accessors are not in collision with some method.
280 (Operator): Is derived from MethodCore to simplify common
283 * decl.cs (Flags.TestMethodDuplication): Test for duplication
285 (DeclSpace.AddToContainer): Adds the member to defined_names
286 table. It tests for duplications and enclosing name conflicts.
288 * enum.cs (EnumMember): Clean up to reuse the base structures
290 2004-09-03 Martin Baulig <martin@ximian.com>
292 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
293 into TypeContainer, to make partial classes work again.
295 2004-09-03 Martin Baulig <martin@ximian.com>
297 * rootcontext.cs (RootContext.V2): Removed.
299 2004-03-23 Martin Baulig <martin@ximian.com>
301 * expression.cs (Invocation.OverloadResolve): Added `bool
302 may_fail' argument and use it instead of the Location.IsNull() hack.
304 2004-09-03 Martin Baulig <martin@ximian.com>
306 Merged latest changes into gmcs. Please keep this comment in
307 here, it makes it easier for me to see what changed in MCS since
308 the last time I merged.
310 2004-09-03 Raja R Harinath <rharinath@novell.com>
313 * expression.cs (BetterConversion): Don't allow either conversion
314 to be null. Remove redundant implicit conversion test when 'q ==
315 null' -- when this function is invoked, we already know that the
316 implicit conversion exists.
317 (BetterFunction): Assume that 'best' is non-null. Remove
318 redundant reimplementation of IsApplicable when 'best' is null.
319 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
321 (IsAncestralType): Extract from OverloadResolve.
322 (OverloadResolve): Make robust to the MethodGroupExpr being
323 unsorted. Implement all the logic of Section 14.5.5.1, and
324 support overloading of methods from multiple applicable types.
325 Clean up logic somewhat. Don't pass null methods to BetterFunction.
327 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
328 (RealError, Warning): Append type of report to related symbol.
330 2004-09-03 Marek Safar <marek.safar@seznam.cz>
332 * enum.cs: Fixed CLS-Compliance checks for enum members.
333 Error tests cs3008-8.cs, cs3014-8.cs
335 2004-09-02 Marek Safar <marek.safar@seznam.cz>
337 Fixed bug #62342, #63102
338 * class.cs: ImplementIndexer uses member.IsExplicitImpl
339 like ImplementMethod.
341 2004-09-02 Marek Safar <marek.safar@seznam.cz>
343 * attribute.cs (Attribute.GetAttributeArgumentExpression):
346 2004-09-02 Martin Baulig <martin@ximian.com>
348 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
349 TypeManager.GetArgumentTypes() rather than calling GetParameters()
352 2004-09-01 Marek Safar <marek.safar@seznam.cz>
354 C# 2.0 Static classes implemented
356 * class.cs (TypeContainer): instance_constructors,
357 initialized_fields, initialized_static_fields,
358 default_constructor, base_inteface_types are protected to be
359 accessible from StaticClass.
360 (TypeContainer.DefineDefaultConstructor): New virtual method
361 for custom default constructor generating
362 (StaticClass): New class to handle "Static classes" feature.
364 * cs-parser.jay: Handle static keyword on class like instance
367 * driver.cs: Added "/langversion" command line switch with two
368 options (iso-1, default).
370 2004-08-31 Marek Safar <marek.safar@seznam.cz>
372 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
374 2004-08-31 Miguel de Icaza <miguel@ximian.com>
376 * delegate.cs: Style.
378 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
380 * delegate.cs: Add seperate instance expr field for miguel.
382 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
384 * PointerArithmetic (Resolve): make sure we are not doing
385 pointer arith on void*. Also, make sure we are resolved
386 by not setting eclass until resolve.
388 All callers: Make sure that PointerArithmetic gets resolved.
390 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
392 * ArrayCreation (LookupType): If the type does not resolve
393 to an array, give an error.
395 2004-08-27 Marek Safar <marek.safar@seznam.cz>
397 * statement.cs (Try.Resolve): Fixed bug #64222
399 2004-08-27 Martin Baulig <martin@ximian.com>
402 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
405 2004-08-26 Marek Safar <marek.safar@seznam.cz>
407 * ecore.cs (Constantify): Get underlying type via
408 System.Enum.GetUnderlyingType to avoid StackOverflow on the
409 Windows in special cases.
411 2004-08-26 Marek Safar <marek.safar@seznam.cz>
413 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
414 for obtaining also private methods.
415 (GetRemoveMethod): Used GetRemoveMethod (true)
416 for obtaining also private methods.
418 2004-08-24 Martin Baulig <martin@ximian.com>
420 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
421 MethodAttributes.HideBySig for operators.
423 2004-08-23 Martin Baulig <martin@ximian.com>
425 Back to the old error reporting system :-)
427 * report.cs (Message): Removed.
428 (Report.MessageData, ErrorData, WarningData): Removed.
429 (Report.Error, Warning): Back to the old system.
431 2004-08-23 Martin Baulig <martin@ximian.com>
433 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
435 * class.cs (TypeContainer.ParentContainer): New public virtual
436 method; replaces the explicit interface implementation.
437 (ClassPart.ParentContainer): Override.
439 2004-08-23 Martin Baulig <martin@ximian.com>
441 * statement.cs (Switch): Added support for constant switches; see
442 #59428 or test-285.cs.
444 2004-08-22 Marek Safar <marek.safar@seznam.cz>
447 * statement.cs (GetEnumeratorFilter): Removed useless
448 logic because C# specs is strict. GetEnumerator must be
451 2004-08-22 Martin Baulig <martin@ximian.com>
453 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
454 a switch and may break, reset the barrier. Fixes #59867.
456 2004-08-22 Marek Safar <marek.safar@seznam.cz>
458 CLS-Compliance speed up (~5% for corlib)
460 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
461 New method. Tests container for CLS-Compliant names
463 * class.cs (TypeContainer.VerifyClsName): New method.
464 Checks whether container name is CLS Compliant.
465 (Constructor): Implements IMethodData.
467 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
468 low-case table for CLS Compliance test.
469 (MemberCache.VerifyClsParameterConflict): New method.
470 Checks method parameters for CS3006 error.
472 * enum.cs (EnumMember): Is derived from MemberCore.
473 (Enum.VerifyClsName): Optimized for better performance.
475 2004-08-06 Marek Safar <marek.safar@seznam.cz>
477 * report.cs: Renamed Error_T to Error and changed all
480 2004-08-06 Marek Safar <marek.safar@seznam.cz>
482 * class.cs (TypeContainer.IndexerArrayList): New inner class
483 container for indexers.
484 (TypeContainer.DefaultIndexerName): New constant for default
485 indexer name. Replaced all "Item" with this constant.
486 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
488 * typemanager.cs (TypeManager.default_member_ctor): Cache here
489 DefaultMemberAttribute constructor.
491 2004-08-05 Martin Baulig <martin@ximian.com>
493 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
496 2004-08-05 Marek Safar <marek.safar@seznam.cz>
498 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
499 multi platforms problem.
501 * compiler.csproj: Included shared files.
503 2004-08-04 Marek Safar <marek.safar@seznam.cz>
505 Fix bug 60333, 55971 in the more general way
506 * attribute.cs (Attribute.GetAttributeArgumentExpression):
507 Added arg_type argument for constant conversion.
508 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
510 2004-08-04 Marek Safar <marek.safar@seznam.cz>
513 * class.cs (TypeContainer ): New inner classes MethodArrayList,
514 OperatorArrayList, MethodCoreArrayList for typecontainer
515 containers. Changed class member types to these new types.
516 (MethodArrayList.DefineMembers): Added test for CS0659.
518 2004-08-04 Miguel de Icaza <miguel@ximian.com>
520 * cfold.cs: Synchronize the folding with the code in expression.cs
521 Binary.DoNumericPromotions for uint operands.
523 * attribute.cs: Revert patch from Raja, it introduced a regression
524 while building Blam-1.2.1 (hard to isolate a test case).
526 2004-08-04 Marek Safar <marek.safar@seznam.cz>
530 (TypeContainer.Define): Renamed to DefineContainerMembers because of
532 (MethodCore.parent_method): New member. The method we're overriding
533 if this is an override method.
534 (MethodCore.CheckBase): Moved from Method class and made common.
535 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
537 (MethodCore.CheckForDuplications): New abstract method. For custom
538 member duplication search in a container
539 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
540 method and its return type.
541 (Event.conflict_symbol): New member. Symbol with same name in the
545 (MemberCache.FindMemberWithSameName): New method. The method
546 is looking for conflict with inherited symbols.
548 2004-08-04 Martin Baulig <martin@ximian.com>
550 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
552 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
554 2004-08-03 Marek Safar <marek.safar@seznam.cz>
556 * report.cs (Message): New enum for better error, warning reference in
558 (MessageData): New inner abstract class. It generally handles printing of
559 error and warning messages.
560 Removed unused Error, Warning, Message methods.
562 2004-08-03 Marek Safar <marek.safar@seznam.cz>
564 Fix for cs0592-8.cs test
566 (Attributable.ValidAttributeTargets): Made public.
567 (Attribute.ExplicitTarget): New member for explicit target value.
568 (Attribute.CheckTargets): Now we translate explicit attribute
569 target to Target here.
571 2004-08-03 Ben Maurer <bmaurer@ximian.com>
573 * ecore.cs (MethodGroupExpr): new IsBase property.
575 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
577 * delegate.cs (DelegateCreation): store a MethodGroupExpr
578 rather than an instance expr.
580 (DelegateCreation.Emit): Use the method group rather than
581 the instance expression. Also, if you have base.Foo as the
582 method for a delegate, make sure to emit ldftn, not ldftnvirt.
584 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
586 (NewDelegate.DoResolve): Only check for the existance of Invoke
587 if the method is going to be needed. Use MethodGroupExpr.
589 (NewDelegate.Emit): Remove, DelegateCreation implements this.
591 * expression.cs: For pointer arith., make sure to use
592 the size of the type, not the size of the pointer to
595 2004-08-03 Marek Safar <marek.safar@seznam.cz>
598 * class.cs (Class): Added error CS0502 test.
600 2004-08-03 John Luke <jluke@cfl.rr.com>
601 Raja R Harinath <rharinath@novell.com>
604 * attribute.cs (Attribute.complained_before): New flag.
605 (Attribute.ResolveType, Attribute.Resolve),
606 (Attribute.DefinePInvokeMethod): Set it.
607 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
609 2004-08-03 Martin Baulig <martin@ximian.com>
611 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
612 use a user-defined operator; we still need to do numeric
613 promotions in case one argument is a builtin type and the other
614 one has an implicit conversion to that type. Fixes #62322.
616 2004-08-02 Martin Baulig <martin@ximian.com>
618 * statement.cs (LocalInfo.Flags): Added `IsThis'.
619 (LocalInfo.IsThis): New public property.
620 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
622 2004-08-01 Martin Baulig <martin@ximian.com>
624 * class.cs (TypeContainer.GetClassBases): Don't set the default
625 here since we may get called from GetPartialBases().
626 (TypeContainer.DefineType): If GetClassBases() didn't return a
627 parent, use the default one.
629 2004-07-30 Duncan Mak <duncan@ximian.com>
631 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
633 2004-07-30 Martin Baulig <martin@ximian.com>
635 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
637 * class.cs (SourceMethod): New public class, derive from the
638 symbol writer's ISourceMethod.
639 (Method): Use the new symbol writer API.
641 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
642 as argument and use the new symbol writer.
645 (SourceFile): Implement the symbol writer's ISourceFile.
646 (Location.SymbolDocument): Removed.
647 (Location.SourceFile): New public property.
649 * symbolwriter.cs: Use the new symbol writer API.
651 2004-07-30 Raja R Harinath <rharinath@novell.com>
653 * Makefile (install-local): Remove. Functionality moved to
656 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
658 * Makefile: Install mcs.exe.config file together with mcs.exe.
659 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
660 correct runtime version.
662 2004-07-25 Martin Baulig <martin@ximian.com>
665 (TypeContainer.RegisterOrder): Removed, this was unused.
666 (TypeContainer, interface_order): Removed.
667 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
668 TypeContainer as argument since we can also be called with a
669 `PartialContainer' for a partial class/struct/interface.
670 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
671 of checking whether we're an `Interface' - we could be a
673 (PartialContainer.Register): Override; call
674 AddClass()/AddStruct()/AddInterface() on our parent.
676 * cs-parser.jay (interface_member_declaration): Add things to the
677 `current_container', not the `current_class'.
679 * rootcontext.cs (RegisterOrder): The overloaded version which
680 takes an `Interface' was unused, removed.
682 * typemanager.cs (TypeManager.LookupInterface): Return a
683 `TypeContainer', not an `Interface'.
684 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
685 contain a `PartialContainer' for an interface, so check it's
686 `Kind' to figure out what it is.
688 2004-07-25 Martin Baulig <martin@ximian.com>
690 * class.cs (Class.DefaultTypeAttributes): New public constant.
691 (Struct.DefaultTypeAttributes): Likewise.
692 (Interface.DefaultTypeAttributes): Likewise.
693 (PartialContainer.TypeAttr): Override this and add the
694 DefaultTypeAttributes.
696 2004-07-25 Martin Baulig <martin@ximian.com>
698 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
699 we can just use the `Parent' field instead.
701 2004-07-25 Martin Baulig <martin@ximian.com>
703 * class.cs (TypeContainer.Emit): Renamed to EmitType().
705 2004-07-25 Martin Baulig <martin@ximian.com>
707 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
708 our parts before defining any methods.
709 (TypeContainer.VerifyImplements): Make this virtual.
710 (ClassPart.VerifyImplements): Override and call VerifyImplements()
711 on our PartialContainer.
713 2004-07-25 Martin Baulig <martin@ximian.com>
715 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
717 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
718 argument, we can just use the `Parent' field instead.
721 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
722 (MemberBase.DoDefine): Likewise.
724 2004-07-24 Martin Baulig <martin@ximian.com>
726 * decl.cs (MemberCore.Parent): New public field.
727 (DeclSpace.Parent): Moved to MemberCore.
729 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
730 (MemberBase.ctor): Added TypeContainer argument, pass it to our
732 (FieldBase, Field, Operator): Likewise.
733 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
734 (EventField, Event): Likewise.
736 2004-07-23 Martin Baulig <martin@ximian.com>
738 * class.cs (PartialContainer): New public class.
739 (ClassPart): New public class.
740 (TypeContainer): Added support for partial classes.
741 (TypeContainer.GetClassBases): Splitted some of the functionality
742 out into GetNormalBases() and GetPartialBases().
744 * cs-tokenizer.cs (Token.PARTIAL): New token.
745 (Tokenizer.consume_identifier): Added some hacks to recognize
746 `partial', but only if it's immediately followed by `class',
747 `struct' or `interface'.
749 * cs-parser.jay: Added support for partial clases.
751 2004-07-23 Martin Baulig <martin@ximian.com>
753 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
754 a `DeclSpace' and also made it readonly.
755 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
756 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
757 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
759 * cs-parser.jay: Pass the `current_class', not the
760 `current_container' (at the moment, this is still the same thing)
761 to a new Method, Property, Event, Indexer or Constructor.
763 2004-07-23 Martin Baulig <martin@ximian.com>
765 * cs-parser.jay (CSharpParser): Added a new `current_class' field
766 and removed the `current_interface' one.
767 (struct_declaration, class_declaration, interface_declaration):
768 Set `current_class' to the newly created class/struct/interface;
769 set their `Bases' and call Register() before parsing their body.
771 2004-07-23 Martin Baulig <martin@ximian.com>
773 * class.cs (Kind): New public enum.
774 (TypeContainer): Made this class abstract.
775 (TypeContainer.Kind): New public readonly field.
776 (TypeContainer.CheckDef): New public method; moved here from
778 (TypeContainer.Register): New public abstract method.
779 (TypeContainer.GetPendingImplementations): New public abstract
781 (TypeContainer.GetClassBases): Removed the `is_class' and
782 `is_iface' parameters.
783 (TypeContainer.DefineNestedTypes): Formerly known as
785 (ClassOrStruct): Made this class abstract.
787 * tree.cs (RootTypes): New public type.
789 2004-07-20 Martin Baulig <martin@ximian.com>
791 * tree.cs (Tree.RecordNamespace): Removed.
792 (Tree.Namespaces): Removed.
794 * rootcontext.cs (RootContext.IsNamespace): Removed.
796 * cs-parser.jay (namespace_declaration): Just create a new
799 2004-07-20 Martin Baulig <martin@ximian.com>
801 * statement.cs (ExceptionStatement): New abstract class. This is
802 now used as a base class for everyone who's using `finally'.
803 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
804 our local variables before using them.
806 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
807 virtual method. This is used by Yield.Resolve() to "steal" an
808 outer block's `finally' clauses.
809 (FlowBranchingException): The .ctor now takes an ExceptionStatement
812 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
813 version which takes an ExceptionStatement. This version must be
814 used to create exception branchings.
817 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
818 (Iterator.EmitMoveNext): Added exception support; protect the
819 block with a `fault' clause, properly handle 'finally' clauses.
820 (Iterator.EmitDispose): Run all the `finally' clauses here.
822 2004-07-20 Martin Baulig <martin@ximian.com>
824 * iterator.cs: This is the first of a set of changes in the
825 iterator code. Match the spec more closely: if we're an
826 IEnumerable, then GetEnumerator() must be called. The first time
827 GetEnumerator() is called, it returns the current instance; all
828 subsequent invocations (if any) must create a copy.
830 2004-07-19 Miguel de Icaza <miguel@ximian.com>
832 * expression.cs: Resolve the constant expression before returning
835 2004-07-19 Martin Baulig <martin@ximian.com>
837 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
838 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
839 the return type of the new EmitContext.
841 2004-07-18 Martin Baulig <martin@ximian.com>
843 * class.cs (Property.Define): Fix iterators.
845 * iterators.cs (Iterator.Define): Moved the
846 `container.AddInterator (this)' call here from the .ctor; only do
847 it if we resolved successfully.
849 2004-07-17 Miguel de Icaza <miguel@ximian.com>
851 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
852 `true' for preprocessing directives that we parse. The return
853 value indicates whether we should return to regular tokenizing or
854 not, not whether it was parsed successfully.
856 In the past if we were in: #if false ... #line #endif, we would
857 resume parsing after `#line'. See bug 61604.
859 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
860 building: IsEnumType should return true only for enums, not for
861 enums or System.Enum itself. This fixes #61593.
863 Likely what happened is that corlib was wrong: mcs depended on
864 this bug in some places. The bug got fixed, we had to add the
865 hack, which caused bug 61593.
867 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
868 that was a workaround for the older conditions.
870 2004-07-16 Ben Maurer <bmaurer@ximian.com>
872 * assign.cs: IAssignMethod has a new interface, as documented
873 inline. All assignment code now uses this new api.
875 * ecore.cs, expression.cs: All classes which implement
876 IAssignMethod now use the new interface.
878 * expression.cs (Invocation): add a hack to EmitCall so that
879 IndexerAccess can be the target of a compound assignment without
880 evaluating its arguments twice.
882 * statement.cs: Handle changes in Invocation api.
884 2004-07-16 Martin Baulig <martin@ximian.com>
886 * iterators.cs: Rewrote this. We're now using one single Proxy
887 class for both the IEnumerable and the IEnumerator interface and
888 `Iterator' derives from Class so we can use the high-level API.
890 * class.cs (TypeContainer.AddIterator): New method.
891 (TypeContainer.DoDefineType): New protected virtual method, which
892 is called from DefineType().
893 (TypeContainer.DoDefineMembers): Call DefineType() and
894 DefineMembers() on all our iterators.
895 (TypeContainer.Emit): Call Emit() on all our iterators.
896 (TypeContainer.CloseType): Call CloseType() on all our iterators.
898 * codegen.cs (EmitContext.CurrentIterator): New public field.
900 2004-07-15 Martin Baulig <martin@ximian.com>
903 (TypeManager.not_supported_exception_type): New type.
905 2004-07-14 Martin Baulig <martin@ximian.com>
907 * iterators.cs: Use real error numbers.
909 2004-07-14 Martin Baulig <martin@ximian.com>
911 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
912 requires this to be a System.Collection.IEnumerable and not a
913 class implementing that interface.
914 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
916 2004-07-13 Marek Safar <marek.safar@seznam.cz>
918 * class.cs: Fixed previous fix, it broke some error tests.
920 2004-07-12 Martin Baulig <martin@ximian.com>
922 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
925 2004-07-09 Miguel de Icaza <miguel@ximian.com>
927 * assign.cs (LocalTemporary): Add new argument: is_address,If
928 `is_address' is true, then the value that we store is the address
929 to the real value, and not the value itself.
931 * ecore.cs (PropertyExpr): use the new local temporary
932 stuff to allow us to handle X.Y += z (where X is a struct)
934 2004-07-08 Martin Baulig <martin@ximian.com>
936 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
937 not always return, just like we're doing in Using.Resolve().
939 2004-07-07 Miguel de Icaza <miguel@ximian.com>
941 * cs-parser.jay (fixed_statement): flag this as Pinned.
943 2004-07-06 Miguel de Icaza <miguel@ximian.com>
945 * typemanager.cs (TypeManager): Removed MakePinned method, this
946 mechanism is replaced with the .NET 2.x compatible mechanism of
947 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
949 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
950 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
951 `IsFixed' property which has a different meaning.
953 2004-07-02 Raja R Harinath <rharinath@novell.com>
955 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
956 visible from inside a nested class, not just the names of the
957 immediately enclosing class.
960 2004-06-24 Raja R Harinath <rharinath@novell.com>
962 * expression.cs (BetterConversion): Remove buggy special-case
963 handling of "implicit constant expression conversions". At this
964 point, we already know that the conversion is possible -- we're
965 only checking to see which is better.
967 2004-06-24 Marek Safar <marek.safar@seznam.cz>
969 * cs-parser.jay: Added error CS0210 test.
971 2004-06-24 Marek Safar <marek.safar@seznam.cz>
973 * cs-parser.jay: Added error CS0134 test.
975 2004-06-24 Marek Safar <marek.safar@seznam.cz>
978 * cs-parser.jay: Added error CS0145 test.
980 2004-06-24 Marek Safar <marek.safar@seznam.cz>
982 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
984 2004-06-23 Ben Maurer <bmaurer@ximian.com>
986 * expression.cs (StackAlloc.Resolve): The argument may not
987 be a constant; deal with this case.
989 2004-06-23 Marek Safar <marek.safar@seznam.cz>
991 * attribute.cs (IndexerName_GetIndexerName): Renamed to
992 GetIndexerAttributeValue.
993 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
995 * class.cs (Indexer.Define): Added error tests for CS0415,
998 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1000 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1003 2004-06-23 Martin Baulig <martin@ximian.com>
1005 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1006 neither return nor throw, reset the barrier as well. Fixes #60457.
1008 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1010 * class.cs : EventAttributes is now set to None by default.
1011 This fixes bug #60459.
1013 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1016 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1017 Don't throw exception but return null (it's sufficient now).
1019 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1021 * typemanager.cs (GetArgumentTypes): Faster implementation.
1023 2004-06-18 Martin Baulig <martin@ximian.com>
1025 * attribute.cs (Attribute.Resolve): Check whether we're an
1026 EmptyCast which a Constant child. Fixes #60333.
1028 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1030 * statement.cs (EmitCollectionForeach): Account for the fact that
1031 not all valuetypes are in areas which we can take the address of.
1032 For these variables, we store to a temporary variable. Also, make
1033 sure that we dont emit a `callvirt' on a valuetype method.
1035 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1037 * expression.cs (StackAlloc.DoReSolve): Added test for
1038 negative parameter (CS0247).
1040 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1043 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1045 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1048 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1051 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1053 Fix bug #58254 & cs1555.cs, cs1556.cs
1054 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1056 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1058 * cs-parser.jay: Added error CS1669 test for indexers.
1060 2004-06-11 Martin Baulig <martin@ximian.com>
1062 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1063 call this twice: for params and varargs methods.
1065 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1068 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1070 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1072 * attribute.cs (Attribute.GetValidTargets): Made public.
1075 (AbstractPropertyEventMethod): New class for better code sharing.
1076 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1078 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1080 2004-06-11 Raja R Harinath <rharinath@novell.com>
1083 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
1084 that the call to Resolve is part of a MemberAccess.
1085 (Expression.Resolve): Use it for SimpleName resolution.
1086 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
1087 Add 'intermediate' boolean argument.
1088 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
1089 error message when the SimpleName can be resolved ambiguously
1090 between an expression and a type.
1091 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
1093 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
1094 call on the left-side.
1096 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1099 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
1101 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1103 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
1105 2004-06-11 Martin Baulig <martin@ximian.com>
1107 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
1108 varargs methods if applicable.
1110 2004-06-11 Martin Baulig <martin@ximian.com>
1112 * expression.cs (Invocation.EmitCall): Don't use
1113 `method.CallingConvention == CallingConventions.VarArgs' since the
1114 method could also have `CallingConventions.HasThis'.
1116 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1118 * class.cs (Event.GetSignatureForError): Implemented.
1119 Fixed crash in error test cs3010.cs
1121 2004-06-10 Miguel de Icaza <miguel@ximian.com>
1123 * cs-tokenizer.cs: Change the way we track __arglist to be
1124 consistent with the other keywords.
1126 2004-06-09 Miguel de Icaza <miguel@ximian.com>
1128 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
1131 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
1133 * codegen.cs: Check that all referenced assemblies have a strongname
1134 before strongnaming the compiled assembly. If not report error CS1577.
1135 Fix bug #56563. Patch by Jackson Harper.
1136 * typemanager.cs: Added a method to return all referenced assemblies.
1137 Fix bug #56563. Patch by Jackson Harper.
1139 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1142 (Method.ApplyAttributeBuilder): Moved and added conditional
1143 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
1146 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
1148 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1151 * class.cs: (EventField.attribute_targets): Changed default target.
1153 2004-06-08 Martin Baulig <martin@ximian.com>
1155 * expression.cs (Invocation.EmitCall): Enable varargs methods.
1157 2004-06-08 Martin Baulig <martin@ximian.com>
1159 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
1161 2004-06-07 Martin Baulig <martin@ximian.com>
1163 Added support for varargs methods.
1165 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
1168 * cs-parser.jay: Added support for `__arglist'.
1170 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
1172 * expression.cs (Argument.AType): Added `ArgList'.
1173 (Invocation): Added support for varargs methods.
1174 (ArglistAccess): New public class.
1175 (Arglist): New public class.
1177 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
1179 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
1180 a method's top-level block if the method has varargs.
1182 * support.cs (ReflectionParameters, InternalParameters): Added
1183 support for varargs methods.
1185 2004-06-07 Miguel de Icaza <miguel@ximian.com>
1187 * class.cs: Provide location in indexer error report.
1189 * driver.cs: Use standard names.
1191 * namespace.cs: Catch the use of using after a namespace has been
1192 declared also on using aliases.
1194 2004-06-03 Raja R Harinath <rharinath@novell.com>
1197 * typemanager.cs (closure_private_ok, closure_invocation_type)
1198 (closure_qualifier_type, closure_invocation_assembly)
1199 (FilterWithClosure): Move to ...
1200 (Closure): New internal nested class.
1201 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
1202 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
1203 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
1204 (MemberLookup, MemberLookupFailed): Use it.
1205 * expression.cs (New.DoResolve): Treat the lookup for the
1206 constructor as being qualified by the 'new'ed type.
1207 (Indexers.GetIndexersForTypeOrInterface): Update.
1209 2004-06-03 Marek Safar <marek.safar@seznam.cz>
1212 (GetConditionalAttributeValue): New method. Returns
1213 condition of ConditionalAttribute.
1214 (SearchMulti): New method. Returns all attributes of type 't'.
1215 Use it when attribute is AllowMultiple = true.
1216 (IsConditionalMethodExcluded): New method.
1219 (Method.IsExcluded): Implemented. Returns true if method has conditional
1220 attribute and the conditions is not defined (method is excluded).
1221 (IMethodData): Extended interface for ConditionalAttribute support.
1222 (PropertyMethod.IsExcluded): Implemented.
1225 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
1228 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
1231 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
1233 * expression.cs (ArrayCreationExpression): Make this just an
1234 `expression'. It can't be a statement, so the code here was
1237 2004-06-02 Marek Safar <marek.safar@seznam.cz>
1240 * typemanager.cs (GetFullNameSignature): New method for
1243 2004-06-02 Marek Safar <marek.safar@seznam.cz>
1246 * class.cs (MemberBase.GetSignatureForError): New virtual method.
1247 Use this method when MethodBuilder is null.
1248 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
1249 Added test for error CS0626 (MONO reports error for this situation).
1250 (IMethodData.GetSignatureForError): Extended interface.
1252 2004-06-01 Marek Safar <marek.safar@seznam.cz>
1255 (AttributeTester.GetObsoleteAttribute): Returns instance of
1256 ObsoleteAttribute when type is obsolete.
1259 (TypeContainer.VerifyObsoleteAttribute): Override.
1260 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
1261 (MethodCode.VerifyObsoleteAttribute): Override.
1262 (MemberBase.VerifyObsoleteAttribute): Override.
1265 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
1266 and report proper error.
1269 Delegate.VerifyObsoleteAttribute): Override.
1272 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
1273 and report proper error.
1274 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
1277 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
1281 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
1282 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
1283 Added test for ObsoleteAttribute.
1286 (Catch): Derived from Statement.
1288 2004-06-01 Marek Safar <marek.safar@seznam.cz>
1290 Fixed bug #59071 & cs0160.cs
1292 * statement.cs (Try.Resolve): Check here whether order of catch
1293 clauses matches their dependencies.
1295 2004-05-31 Miguel de Icaza <miguel@ximian.com>
1297 * Reverted patch to namespace.cs (Use lookuptypedirect). This
1298 caused a regression: #59343. Referencing nested classes from an
1299 assembly stopped working.
1301 2004-05-31 Martin Baulig <martin@ximian.com>
1303 MCS is now frozen for beta 2.
1305 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1307 * convert.cs: add a trivial cache for overload operator resolution.
1309 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1311 * decl.cs: If possible, use lookuptypedirect here. We can only do
1312 this if there is no `.' after the namespace. Avoids using
1313 LookupType, which does lots of slow processing.
1314 (FindNestedType) New method, does what it says :-).
1315 * namespace.cs: use LookupTypeDirect.
1316 * rootcontext.cs: use membercache, if possible.
1317 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1319 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1322 According to the spec,
1324 In a member access of the form E.I, if E is a single identifier,
1325 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1326 field, property, localvariable, or parameter with the same type as
1327 the meaning of E as a type-name (§3.8), then both possible
1328 meanings of E are permitted.
1330 We did not check that E as a simple-name had the same type as E as
1333 This trivial check gives us 5-7% on bootstrap time.
1335 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1337 * expression.cs (Invocation.OverloadResolve): Avoid the
1338 use of hashtables and boxing here by allocating on demand.
1340 2004-05-30 Martin Baulig <martin@ximian.com>
1342 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1343 we're doing a silent lookup. Don't try to lookup nested types in
1344 TypeManager.object_type (thanks to Ben Maurer).
1346 2004-05-30 Martin Baulig <martin@ximian.com>
1348 Committing a patch from Ben Maurer.
1350 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1352 2004-05-29 Martin Baulig <martin@ximian.com>
1354 * class.cs (IMethodData.ShouldIgnore): New method.
1356 * typemanager.cs (TypeManager.MethodFlags): Don't take a
1357 `Location' argument, we don't need it anywhere. Use
1358 `IMethodData.ShouldIgnore ()' instead of
1359 `MethodData.GetMethodFlags ()'.
1360 (TypeManager.AddMethod): Removed.
1361 (TypeManager.AddMethod2): Renamed to AddMethod.
1363 2004-05-29 Martin Baulig <martin@ximian.com>
1365 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
1367 * convert.cs (Convert.ImplicitReferenceConversion): If we're
1368 converting from a class type S to an interface type and we already
1369 have an object on the stack, don't box it again. Fixes #52578.
1371 2004-05-29 Martin Baulig <martin@ximian.com>
1373 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1374 Added support for `params' parameters. Fixes #59267.
1376 2004-05-29 Martin Baulig <martin@ximian.com>
1378 * literal.cs (NullPointer): Provide a private .ctor which sets
1379 `type' to TypeManager.object_type. Fixes #59048.
1381 2004-05-29 Martin Baulig <martin@ximian.com>
1383 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
1384 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
1386 * ecore.cs (EventExpr.instance_expr): Make the field private.
1388 2004-05-26 Marek Safar <marek.safar@seznam.cz>
1390 Fixed bug #50080 & cs0214-2.cs
1391 * expression.cs (Cast.DoResolve): Check unsafe context here.
1393 * statement.cs (Resolve.DoResolve): Likewise.
1395 2004-05-26 Martin Baulig <martin@ximian.com>
1397 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
1399 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
1400 (RootContext.LookupType): Pass down the `silent' flag.
1402 2004-05-25 Martin Baulig <martin@ximian.com>
1405 (MethodGroupExpr.IdenticalTypeName): New public property.
1406 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
1407 expression actually refers to a type.
1409 2004-05-25 Martin Baulig <martin@ximian.com>
1411 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
1412 for #56176 and made it actually work.
1414 2004-05-25 Martin Baulig <martin@ximian.com>
1416 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
1417 (FieldExpr, PropertyExpr): Override and implement
1418 CacheTemporaries. Fixes #52279.
1420 2004-05-25 Miguel de Icaza <miguel@ximian.com>
1422 * location.cs: In the new compiler listing a file twice is a
1423 warning, not an error.
1425 2004-05-24 Martin Baulig <martin@ximian.com>
1427 * enum.cs (Enum.DefineType): For the `BaseType' to be a
1428 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
1430 2004-05-24 Martin Baulig <martin@ximian.com>
1432 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
1433 walking the `using' list. Fixes #53921.
1435 2004-05-24 Martin Baulig <martin@ximian.com>
1437 * const.cs (Const.LookupConstantValue): Added support for
1438 EmptyCast's; fixes #55251.
1440 2004-05-24 Martin Baulig <martin@ximian.com>
1442 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
1443 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
1444 which does the CS0135 check. The reason is that we first need to
1445 check whether the variable actually exists.
1447 2004-05-24 Martin Baulig <martin@ximian.com>
1449 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
1450 than RootContext.LookupType() to find the explicit interface
1453 2004-05-24 Raja R Harinath <rharinath@novell.com>
1455 * Makefile: Simplify. Use executable.make.
1456 * mcs.exe.sources: New file. List of sources of mcs.exe.
1458 2004-05-24 Anders Carlsson <andersca@gnome.org>
1462 Use the invariant culture when doing String.Compare for CLS case
1465 2004-05-23 Martin Baulig <martin@ximian.com>
1467 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
1468 don't have any dots. Fixes #52622, added cs0246-8.cs.
1470 * namespace.cs (NamespaceEntry.Lookup): Likewise.
1472 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1474 * class.cs (MemberBase.Define): Reuse MemberType member for
1475 resolved type. Other methods can use it too.
1477 2004-05-23 Martin Baulig <martin@ximian.com>
1479 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
1480 the variable also exists in the current block (otherwise, we need
1481 to report a CS0103). Fixes #58670.
1483 2004-05-23 Martin Baulig <martin@ximian.com>
1485 * flowanalysis.cs (Reachability.Reachable): Compute this
1486 on-the-fly rather than storing it as a field.
1488 2004-05-23 Martin Baulig <martin@ximian.com>
1490 * flowanalysis.cs (Reachability.And): Manually compute the
1491 resulting `barrier' from the reachability.
1493 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1496 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
1497 instance of ObsoleteAttribute when symbol is obsolete.
1500 (IMethodData): Extended interface for ObsoleteAttribute support.
1502 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1504 * attribute.cs: Fix bug #55970
1506 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1510 (GetObsoleteAttribute): New method. Creates the instance of
1512 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
1513 ObsoleteAttribute when member is obsolete.
1514 (AttributeTester.Report_ObsoleteMessage): Common method for
1515 Obsolete error/warning reporting.
1518 (TypeContainer.base_classs_type): New member for storing parent type.
1521 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
1522 for this MemberCore.
1524 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1526 * attribute.cs, const.cs: Fix bug #58590
1528 2004-05-21 Martin Baulig <martin@ximian.com>
1530 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
1531 out parameters if the end of the method is unreachable. Fixes
1534 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1536 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
1537 Hari was right, why extra method.
1539 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1541 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
1543 2004-05-20 Martin Baulig <martin@ximian.com>
1545 Merged this back from gmcs to keep the differences to a minumum.
1547 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
1548 instead of a Declspace.
1549 (Attribute.ResolveType): Likewise.
1550 (Attributes.Search): Likewise.
1551 (Attributes.Contains): Likewise.
1552 (Attributes.GetClsCompliantAttribute): Likewise.
1554 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
1556 (MethodData.ApplyAttributes): Take an EmitContext instead of a
1559 2004-05-19 Marek Safar <marek.safar@seznam.cz>
1561 Fix bug #58688 (MCS does not report error when the same attribute
1564 * attribute.cs (Attribute.Emit): Distinction between null and default.
1566 2004-05-19 Raja R Harinath <rharinath@novell.com>
1568 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
1569 of a top-level attribute without an attribute target.
1570 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
1572 (Attribute.Conditional_GetConditionName),
1573 (Attribute.Obsolete_GetObsoleteMessage): Update.
1574 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
1575 part of ScanForIndexerName.
1576 (Attribute.CanIgnoreInvalidAttribute): New function.
1577 (Attribute.ScanForIndexerName): Move to ...
1578 (Attributes.ScanForIndexerName): ... here.
1579 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
1580 (Attributes.Search): New internal variant that can choose not to
1581 complain if types aren't resolved. The original signature now
1583 (Attributes.GetClsCompliantAttribute): Use internal variant, with
1584 complaints suppressed.
1585 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
1586 only if it not useful.
1587 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
1588 top-level for attributes that are shared between the assembly
1589 and a top-level class.
1590 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
1591 * class.cs: Update to reflect changes.
1592 (DefineIndexers): Fuse loops.
1593 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
1594 a couple more variants of attribute names.
1596 2004-05-18 Marek Safar <marek.safar@seznam.cz>
1598 Fix bug #52585 (Implemented explicit attribute declaration)
1601 (Attributable.ValidAttributeTargets): New abstract method. It gets
1602 list of valid attribute targets for explicit target declaration.
1603 (Attribute.Target): It holds target itself.
1604 (AttributeSection): Removed.
1605 (Attribute.CheckTargets): New method. It checks whether attribute
1606 target is valid for the current element.
1609 (EventProperty): New class. For events that are declared like
1610 property (with add and remove accessors).
1611 (EventField): New class. For events that are declared like field.
1614 * cs-parser.jay: Implemented explicit attribute target declaration.
1616 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
1617 Override ValidAttributeTargets.
1620 (ReturnParameter): Class for applying custom attributes on
1622 (ParameterAtribute): New class. Class for applying custom
1623 attributes on the parameter type.
1625 2004-05-17 Miguel de Icaza <miguel@ximian.com>
1627 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
1630 (Method): Allow UNSAFE here.
1632 * modifiers.cs: Support unsafe reporting.
1634 2004-05-17 Marek Safar <marek.safar@seznam.cz>
1636 * decl.cs: Fix bug #58478.
1638 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1640 * statement.cs: When checking for unreachable code on an EmptyStatement,
1641 set the location. Fixes bug #58488.
1643 2004-05-13 Miguel de Icaza <miguel@ximian.com>
1645 * driver.cs: Add -pkg handling.
1647 From Gonzalo: UseShelLExecute=false
1649 2004-05-12 Marek Safar <marek.safar@seznam.cz>
1652 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
1654 (Attribute.IsClsCompliaceRequired): Moved to base for better
1656 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
1657 when attribute is AttributeUsageAttribute.
1658 (Attribute.GetValidTargets): Simplified.
1659 (Attribute.GetAttributeUsage): New method returns AttributeUsage
1660 attribute for this type.
1661 (Attribute.ApplyAttributes): Method renamed to Emit and make
1663 (GlobalAttributeSection): New class for special handling of global
1664 attributes (assembly, module).
1665 (AttributeSection.Emit): New method.
1667 * class.cs: Implemented Attributable abstract methods.
1668 (MethodCore.LabelParameters): Moved to Parameter class.
1669 (Accessor): Is back simple class.
1670 (PropertyMethod): Implemented Attributable abstract class.
1671 (DelegateMethod): Implemented Attributable abstract class.
1672 (Event): New constructor for disctintion between normal Event
1673 and Event with accessors.
1675 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
1677 * codegen.cs, const.cs, decl.cs, delegate.cs:
1678 (CommonAssemblyModulClass): Implemented Attributable abstract class
1681 * enum.cs: Implement IAttributeSupport interface.
1682 (EnumMember): New class for emum members. Implemented Attributable
1686 (ParameterBase): Is abstract.
1687 (ReturnParameter): New class for easier [return:] attribute handling.
1689 * typemanager.cs: Removed builder_to_attr.
1691 2004-05-11 Raja R Harinath <rharinath@novell.com>
1694 * attribute.cs (Attribute.GetPositionalValue): New function.
1695 * class.cs (TypeContainer.VerifyMembers): New function.
1696 (TypeContainer.Emit): Use it.
1697 (ClassOrStruct): New base class for Class and Struct.
1698 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
1699 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
1701 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
1702 then each non-static field should have a FieldOffset attribute.
1703 Otherwise, none of the fields should have a FieldOffset attribute.
1704 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
1705 and FieldOffset attributes.
1706 * typemanager.cs (TypeManager.struct_layout_attribute_type)
1707 (TypeManager.field_offset_attribute_type): New core types.
1708 (TypeManager.InitCoreTypes): Initialize them.
1710 2004-05-11 Michal Moskal <malekith@pld-linux.org>
1712 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
1713 Return correct type.
1716 2004-05-09 Miguel de Icaza <miguel@ximian.com>
1718 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
1719 be implicitly converted to ulong.
1721 * expression.cs: The logic for allowing operator &, | and ^ worked
1722 was wrong, it worked before because we did not report an error in
1723 an else branch. Fixes 57895.
1725 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
1726 allow volatile fields to be reference types.
1728 2004-05-07 Miguel de Icaza <miguel@ximian.com>
1730 * driver.cs: Add support for /debug-
1732 2004-05-07 Raja R Harinath <rharinath@novell.com>
1734 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
1735 Add a 'complain' parameter to silence errors.
1736 (Attribute.Resolve): Update to changes. Put in sanity check to catch
1737 silently overlooked type-resolutions.
1738 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
1740 (Attributes.Search): New function.
1741 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
1742 (Attributes.GetAttributeFullName): Remove hack.
1743 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
1744 Update to reflect changes.
1745 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1746 Use Attributes.Search instead of nested loops.
1748 2004-05-07 Marek Safar <marek.safar@seznam.cz>
1751 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
1752 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
1753 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
1755 * report.cs: (Report.Warning): Renamed to Warning_T because of
1756 parameter collision.
1758 2004-05-05 Raja R Harinath <rharinath@novell.com>
1760 * expression.cs (MemberAccess.ResolveMemberAccess):
1761 Exit with non-zero status after Report.Error.
1762 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
1764 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
1766 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1768 * support.cs: Don't hang when the file is empty.
1770 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1772 * support.cs: In SeekableStreamReader, compute the preamble size of the
1773 underlying stream. Position changes should take into account that initial
1776 2004-05-03 Todd Berman <tberman@sevenl.net>
1778 * driver.cs: remove unused GetSysVersion function.
1780 2004-05-03 Todd Berman <tberman@sevenl.net>
1782 * driver.cs: Remove the hack from saturday, as well as the hack
1783 from jackson (LoadAssemblyFromGac), also adds the CWD to the
1784 link_paths to get that bit proper.
1786 2004-05-01 Todd Berman <tberman@sevenl.net>
1788 * driver.cs: Try a LoadFrom before a Load, this checks the current
1789 path. This is currently a bug in mono that is be fixed, however, this
1790 provides a workaround for now. This will be removed when the bug
1793 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
1795 * CryptoConvert.cs: Updated to latest version. Fix issue with
1796 incomplete key pairs (#57941).
1798 2004-05-01 Todd Berman <tberman@sevenl.net>
1800 * driver.cs: Remove '.' from path_chars, now System.* loads properly
1803 2004-04-30 Jackson Harper <jackson@ximian.com>
1805 * codegen.cs: Open keys readonly.
1807 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1809 * typemanager.cs: don't report cyclic struct layout when a struct
1810 contains 2 or more fields of the same type. Failed for Pango.AttrShape
1811 which has 2 Pango.Rectangle fields.
1813 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
1815 * expression.cs: Handle IntPtr comparisons with IL code
1816 rather than a method call.
1818 2004-04-29 Martin Baulig <martin@ximian.com>
1820 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
1821 the list of PropertyInfo's in class hierarchy and find the
1822 accessor. Fixes #56013.
1824 2004-04-29 Martin Baulig <martin@ximian.com>
1826 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
1828 2004-04-29 Martin Baulig <martin@ximian.com>
1830 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1832 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
1834 2004-04-29 Martin Baulig <martin@ximian.com>
1836 * class.cs (ConstructorInitializer.Resolve): Check whether the
1837 parent .ctor is accessible. Fixes #52146.
1839 2004-04-29 Martin Baulig <martin@ximian.com>
1841 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1843 * statement.cs (Using.EmitLocalVariableDecls): Use
1844 TypeManager.idisposable_type, not typeof (IDisposable).
1845 (Foreach.EmitCollectionForeach): Added support for valuetypes.
1847 2004-04-29 Martin Baulig <martin@ximian.com>
1849 * class.cs (Event.Define): Don't emit the field and don't set
1850 RTSpecialName and SpecialName for events on interfaces. Fixes
1853 2004-04-29 Raja R Harinath <rharinath@novell.com>
1855 Refactor Attribute.ApplyAttributes.
1856 * attribute.cs (Attributable): New base class for objects that can
1857 have Attributes applied on them.
1858 (Attribute): Make AttributeUsage fields public.
1859 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
1860 (Attribute.IsInternalCall): New property.
1861 (Attribute.UsageAttr): Convert to a public read-only property.
1862 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
1863 (Attribute.ResolveType, Attribute.Resolve)
1864 (Attribute.ScanForIndexerName): Update to reflect changes.
1865 (Attribute.CheckAttributeTarget): Re-format.
1866 (Attribute.ApplyAttributes): Refactor, to various
1867 Attributable.ApplyAttributeBuilder methods.
1868 * decl.cs (MemberCore): Make Attributable.
1869 * class.cs (Accessor): Make Attributable.
1870 (MethodData.ApplyAttributes): Use proper attribute types, not
1872 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
1873 (TypeContainer.ApplyAttributeBuilder)
1874 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
1875 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
1876 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
1877 (Operator.ApplyAttributeBuilder): New factored-out methods.
1878 * const.cs (Const.ApplyAttributeBuilder): Likewise.
1879 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
1880 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
1881 * parameter.cs (ParameterBase): New Attributable base class
1882 that can also represent Return types.
1883 (Parameter): Update to the changes.
1885 2004-04-29 Jackson Harper <jackson@ximian.com>
1887 * driver.cs: Prefer the corlib system version when looking for
1888 assemblies in the GAC. This is still a hack, but its a better hack
1891 2004-04-29 Marek Safar <marek.safar@seznam.cz>
1893 * decl.cs, enum.cs: Improved error 3005 reporting.
1895 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
1896 (related_symbols): New private member for list of symbols
1897 related to reported error/warning.
1899 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
1901 2004-04-29 Martin Baulig <martin@ximian.com>
1903 * ecore.cs (Expression.Constantify): If we're an enum and
1904 TypeManager.TypeToCoreType() doesn't give us another type, use
1905 t.UnderlyingSystemType. Fixes #56178.
1907 2004-04-29 Martin Baulig <martin@ximian.com>
1909 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
1910 interfaces and for each interface, only add members directly
1911 declared in that interface. Fixes #53255.
1913 2004-04-28 Martin Baulig <martin@ximian.com>
1915 * expression.cs (ConditionalLogicalOperator): Use a temporary
1916 variable for `left' to avoid that we evaluate it more than once;
1919 2004-04-28 Martin Baulig <martin@ximian.com>
1921 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
1924 2004-04-28 Martin Baulig <martin@ximian.com>
1926 * statement.cs (LocalInfo.Resolve): Check whether the type is not
1929 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
1930 whether the type is not void (CS1547).
1932 2004-04-28 Martin Baulig <martin@ximian.com>
1934 * expression.cs (Unary.DoResolveLValue): Override this and report
1935 CS0131 for anything but Operator.Indirection.
1937 2004-04-28 Martin Baulig <martin@ximian.com>
1939 Committing a patch from Ben Maurer; see bug #50820.
1941 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1944 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1947 2004-04-28 Martin Baulig <martin@ximian.com>
1949 Committing a patch from Ben Maurer; see bug #50820.
1951 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1954 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1957 2004-04-28 Martin Baulig <martin@ximian.com>
1959 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
1960 (Block.AddLabel): Call DoLookupLabel() to only search in the
1963 2004-04-28 Martin Baulig <martin@ximian.com>
1965 * cfold.cs (ConstantFold.BinaryFold): Added special support for
1966 comparing StringConstants and NullLiterals in Equality and Inequality.
1968 2004-04-28 Jackson Harper <jackson@ximian.com>
1970 * driver.cs: Attempt to load referenced assemblies from the
1971 GAC. This is the quick and dirty version of this method that
1972 doesnt take into account versions and just takes the first
1973 canidate found. Will be good enough for now as we will not have more
1974 then one version installed into the GAC until I update this method.
1976 2004-04-28 Martin Baulig <martin@ximian.com>
1978 * typemanager.cs (TypeManager.CheckStructCycles): New public
1979 static method to check for cycles in the struct layout.
1981 * rootcontext.cs (RootContext.PopulateTypes): Call
1982 TypeManager.CheckStructCycles() for each TypeContainer.
1983 [Note: We only need to visit each type once.]
1985 2004-04-28 Martin Baulig <martin@ximian.com>
1987 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
1989 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
1990 success and added `out object value'. Use a `bool resolved' field
1991 to check whether we've already been called rather than
1992 `ConstantValue != null' since this breaks for NullLiterals.
1994 2004-04-28 Raja R Harinath <rharinath@novell.com>
1996 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
1997 setting of this flag, since the 'set' method may be non-public.
1999 2004-04-28 Raja R Harinath <rharinath@novell.com>
2001 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2002 check on current_vector.Block.
2004 2004-04-27 Martin Baulig <martin@ximian.com>
2006 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2007 a field initializer. Fixes #56459.
2009 2004-04-27 Martin Baulig <martin@ximian.com>
2011 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2012 we're not attempting to use an indexer. Fixes #52154.
2014 2004-04-27 Martin Baulig <martin@ximian.com>
2016 * statement.cs (Return): Don't create a return label if we don't
2017 need it; reverts my change from January 20th. Thanks to Ben
2020 2004-04-27 Martin Baulig <martin@ximian.com>
2022 According to the spec, `goto' can only leave a nested scope, but
2025 * statement.cs (Block.LookupLabel): Only lookup in the current
2026 block, don't recurse into parent or child blocks.
2027 (Block.AddLabel): Check in parent and child blocks, report
2028 CS0140/CS0158 if we find a duplicate.
2029 (Block): Removed this indexer for label lookups.
2030 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2031 this already does the error reporting for us.
2034 (FlowBranching.UsageVector.Block): New public variable; may be null.
2035 (FlowBranching.CreateSibling): Added `Block' argument.
2036 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2037 label for the target of a `goto' and check whether we're not
2038 leaving a `finally'.
2040 2004-04-27 Martin Baulig <martin@ximian.com>
2042 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2043 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2046 2004-04-27 Martin Baulig <martin@ximian.com>
2048 * statement.cs (Block.AddLabel): Also check for implicit blocks
2049 and added a CS0158 check.
2051 2004-04-27 Martin Baulig <martin@ximian.com>
2053 * flowanalysis.cs (FlowBranchingLoop): New class.
2054 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2055 UsageVector's instead of an ArrayList.
2056 (FlowBranching.Label): Likewise.
2057 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2058 (FlowBranching.AddBreakVector): New method.
2060 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2062 * attribute.cs: Small regression fix: only convert the type if we
2063 the type is different, fixes System.Drawing build.
2065 2004-04-27 Martin Baulig <martin@ximian.com>
2067 * attribute.cs (Attribute.Resolve): If we have a constant value
2068 for a named field or property, implicity convert it to the correct
2071 2004-04-27 Raja R Harinath <rharinath@novell.com>
2073 * statement.cs (Block.Block): Implicit blocks share
2074 'child_variable_names' fields with parent blocks.
2075 (Block.AddChildVariableNames): Remove.
2076 (Block.AddVariable): Mark variable as "used by a child block" in
2077 every surrounding block.
2078 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2079 been used in a child block, complain about violation of "Invariant
2080 meaning in blocks" rule.
2081 * cs-parser.jay (declare_local_variables): Don't use
2082 AddChildVariableNames.
2083 (foreach_statement): Don't create an implicit block: 'foreach'
2086 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2088 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2089 converting from 0L to ulong. Fixes 57522.
2091 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2093 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
2094 derived class hides via 'new' keyword field from base class (test-242.cs).
2095 TODO: Handle this in the more general way.
2097 * class.cs (CheckBase): Ditto.
2099 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2101 * decl.cs (caching_flags): New member for storing cached values
2103 (MemberCore.Flags): New enum where bit flags for caching_flags
2105 (MemberCore.cls_compliance): Moved to caching_flags.
2106 (DeclSpace.Created): Moved to caching_flags.
2108 * class.cs: Use caching_flags instead of DeclSpace.Created
2110 2004-04-21 Miguel de Icaza <miguel@ximian.com>
2112 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
2113 if we are only a derived class, not a nested class.
2115 * typemanager.cs: Same as above, but do this at the MemberLookup
2116 level (used by field and methods, properties are handled in
2117 PropertyExpr). Allow for the qualified access if we are a nested
2120 2004-04-21 Marek Safar <marek.safar@seznam.cz>
2122 * class.cs: Refactoring.
2123 (IMethodData): New inteface; Holds links to parent members
2124 to avoid member duplication (reduced memory allocation).
2125 (Method): Implemented IMethodData interface.
2126 (PropertyBase): New inner classes for get/set methods.
2127 (PropertyBase.PropertyMethod): Implemented IMethodData interface
2128 (Event): New inner classes for add/remove methods.
2129 (Event.DelegateMethod): Implemented IMethodData interface.
2131 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
2132 EmitContext (related to class.cs refactoring).
2134 2004-04-21 Raja R Harinath <rharinath@novell.com>
2136 * delegate.cs (Delegate.VerifyApplicability): If the number of
2137 arguments are the same as the number of parameters, first try to
2138 verify applicability ignoring any 'params' modifier on the last
2142 2004-04-16 Raja R Harinath <rharinath@novell.com>
2144 * class.cs (TypeContainer.AddIndexer): Use
2145 'ExplicitInterfaceName' to determine if interface name was
2146 explicitly specified. 'InterfaceType' is not initialized at this time.
2147 (TypeContainer.DefineIndexers): Remove use of temporary list. The
2148 Indexers array is already in the required order. Initialize
2149 'IndexerName' only if there are normal indexers.
2150 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
2151 (TypeContainer.Emit): Emit DefaultMember attribute only if
2152 IndexerName is initialized.
2155 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
2157 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
2160 2004-04-15 Raja R Harinath <rharinath@novell.com>
2162 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
2166 * attribute.cs (Attribute.Resolve): Check for duplicate named
2170 2004-04-15 Miguel de Icaza <miguel@ximian.com>
2172 * iterators.cs (MarkYield): track whether we are in an exception,
2173 and generate code accordingly. Use a temporary value to store the
2174 result for our state.
2176 I had ignored a bit the interaction of try/catch with iterators
2177 since their behavior was not entirely obvious, but now it is
2178 possible to verify that our behavior is the same as MS .NET 2.0
2182 2004-04-14 Miguel de Icaza <miguel@ximian.com>
2184 * iterators.cs: Avoid creating temporaries if there is no work to
2187 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
2188 Enumerations, use TypeManager.EnumToUnderlying and call
2191 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
2194 (This.Emit): Use EmitContext.EmitThis to emit our
2197 (This.EmitAssign): Ditto.
2199 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
2200 codepaths, we will move all the functionality into
2203 (FieldExpr.EmitAssign): Ditto.
2205 This fixes several hidden bugs that I uncovered while doing a code
2206 review of this today.
2208 * codegen.cs (EmitThis): reworked so the semantics are more clear
2209 and also support value types "this" instances.
2211 * iterators.cs: Changed so that for iterators in value types, we
2212 do not pass the value type as a parameter.
2214 Initialization of the enumerator helpers is now done in the caller
2215 instead of passing the parameters to the constructors and having
2216 the constructor set the fields.
2218 The fields have now `assembly' visibility instead of private.
2220 2004-04-11 Miguel de Icaza <miguel@ximian.com>
2222 * expression.cs (Argument.Resolve): Check if fields passed as ref
2223 or out are contained in a MarshalByRefObject.
2225 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
2226 another compiler type.
2228 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
2230 * class.cs (Indexer.Define): use the new name checking method.
2231 Also, return false on an error.
2232 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
2233 (is_identifier_[start/part]_character): make static.
2235 2004-04-10 Miguel de Icaza <miguel@ximian.com>
2237 * expression.cs (Binary.ResolveOperator): Do no append strings
2238 twice: since we can be invoked more than once (array evaluation)
2239 on the same concatenation, take care of this here. Based on a fix
2240 from Ben (bug #56454)
2242 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2244 * codegen.cs: Fix another case where CS1548 must be reported (when
2245 delay-sign isn't specified and no private is available #56564). Fix
2246 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2247 error when MCS is used on the MS runtime and we need to delay-sign
2248 (which seems unsupported by AssemblyBuilder - see #56621).
2250 2004-04-08 Marek Safar <marek.safar@seznam.cz>
2252 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
2253 (TypeManager.ComputeNamespaces): Faster implementation for
2256 * compiler.csproj: Updated AssemblyName to mcs.
2258 2004-04-07 Miguel de Icaza <miguel@ximian.com>
2260 * rootcontext.cs: Add new types to the boot resolution.
2262 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
2263 MulticastDelegate is not allowed.
2265 * typemanager.cs: Add new types to lookup: System.TypedReference
2268 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
2269 check for TypedReference or ArgIterator, they are not allowed.
2271 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
2272 makes us properly catch 1510 in some conditions (see bug 56016 for
2275 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
2277 * CryptoConvert.cs: update from corlib version
2280 2004-04-05 Miguel de Icaza <miguel@ximian.com>
2282 * class.cs (Indexer.Define): Check indexername declaration
2284 2004-04-05 Marek Safar <marek.safar@seznam.cz>
2286 * attribute.cs (IsClsCompliant): Fixed problem with handling
2287 all three states (compliant, not-compliant, undetected).
2289 2004-03-30 Marek Safar <marek.safar@seznam.cz>
2291 * attribute.cs (Attribute): Location is now public.
2292 (Resolve): Store resolved arguments (pos_values) in attribute class.
2293 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
2294 (GetClsCompliantAttributeValue): New method that gets
2295 CLSCompliantAttribute value.
2296 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
2297 if exists else null.
2298 (AttributeTester): New class for CLS-Compliant verification routines.
2300 * class.cs (Emit): Add CLS-Compliant verification.
2301 (Method.GetSignatureForError): Implemented.
2302 (Constructor.GetSignatureForError): Implemented
2303 (Constructor.HasCompliantArgs): Returns if constructor has
2304 CLS-Compliant arguments.
2305 (Constructor.Emit): Override.
2306 (Construcor.IsIdentifierClsCompliant): New method; For constructors
2307 is needed to test only parameters.
2308 (FieldBase.GetSignatureForError): Implemented.
2309 (TypeContainer): New member for storing base interfaces.
2310 (TypeContainer.FindMembers): Search in base interfaces too.
2312 * codegen.cs (GetClsComplianceAttribute): New method that gets
2313 assembly or module CLSCompliantAttribute value.
2314 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
2316 (ModuleClass.Emit): Add error 3012 test.
2318 * const.cs (Emit): Override and call base for CLS-Compliant tests.
2320 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
2321 state for all decl types.
2322 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
2323 if CLS-Compliant tests are required.
2324 (IsClsCompliaceRequired): New method. Analyze whether code
2325 must be CLS-Compliant.
2326 (IsExposedFromAssembly): New method. Returns true when MemberCore
2327 is exposed from assembly.
2328 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
2329 value or gets cached value.
2330 (HasClsCompliantAttribute): New method. Returns true if MemberCore
2331 is explicitly marked with CLSCompliantAttribute.
2332 (IsIdentifierClsCompliant): New abstract method. This method is
2333 used to testing error 3005.
2334 (IsIdentifierAndParamClsCompliant): New method. Common helper method
2335 for identifier and parameters CLS-Compliant testing.
2336 (VerifyClsCompliance): New method. The main virtual method for
2337 CLS-Compliant verifications.
2338 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
2339 null. I don't know why is null (too many public members !).
2340 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
2341 and get value of first CLSCompliantAttribute that found.
2343 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
2344 (VerifyClsCompliance): Override and add extra tests.
2346 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
2347 clscheck- disable CLS-Compliant verification event if assembly is has
2348 CLSCompliantAttribute(true).
2350 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
2351 ApllyAttribute is now called in emit section as in the other cases.
2352 Possible future Emit integration.
2353 (IsIdentifierClsCompliant): New override.
2354 (VerifyClsCompliance): New override.
2355 (GetEnumeratorName): Returns full enum name.
2357 * parameter.cs (GetSignatureForError): Implemented.
2359 * report.cs (WarningData): New struct for Warning message information.
2360 (LocationOfPreviousError): New method.
2361 (Warning): New method. Reports warning based on the warning table.
2362 (Error_T): New method. Reports error based on the error table.
2364 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
2365 verifications are done here.
2367 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
2369 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
2370 CLSCompliantAttribute.
2371 (all_imported_types): New member holds all imported types from other
2373 (LoadAllImportedTypes): New method fills static table with exported types
2374 from all referenced assemblies.
2375 (Modules): New property returns all assembly modules.
2377 2004-03-30 Miguel de Icaza <miguel@ximian.com>
2379 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
2380 throwing a parser error.
2382 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
2383 which removes the hardcoded get_/set_ prefixes for properties, as
2384 IL allows for the properties to be named something else.
2388 * expression.cs: Do not override operand before we know if it is
2391 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2393 * typemanager.cs: support for pinned variables.
2395 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2397 * decl.cs, typemanager.cs: Avoid using an arraylist
2398 as a buffer if there is only one result set.
2400 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2402 * expression.cs: Make sure you cant call a static method
2403 with an instance expression, bug #56174.
2405 2004-03-29 Miguel de Icaza <miguel@ximian.com>
2407 * class.cs (IsDuplicateImplementation): Improve error reporting to
2408 flag 663 (method only differs in parameter modifier).
2410 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
2411 in preprocessor directives.
2413 * location.cs (LookupFile): Allow for the empty path.
2415 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
2416 better approach for some of that patch, but its failing with the
2417 CharSet enumeration. For now try/catch will do.
2419 * typemanager.cs: Do not crash if a struct does not have fields.
2422 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2424 * expression.cs: cs0213, cant fix a fixed expression.
2427 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2429 * cs-parser.jay: detect invalid embeded statements gracefully.
2432 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2434 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
2437 the invocation type may not be a subclass of the tye of the item/
2438 The type of the item must be a subclass of the invocation item.
2443 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
2445 * attribute.cs: Added methods to get a string and a bool from an
2446 attribute. Required to information from AssemblyKeyFileAttribute,
2447 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
2448 * codegen.cs: Modified AssemblyName creation to include support for
2449 strongnames. Catch additional exceptions to report them as CS1548.
2450 * compiler.csproj: Updated include CryptoConvert.cs.
2451 * compiler.csproj.user: Removed file - user specific configuration.
2452 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
2453 Mono.Security assembly. The original class is maintained and tested in
2454 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
2455 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
2456 like CSC 8.0 (C# v2) supports.
2457 * Makefile: Added CryptoConvert.cs to mcs sources.
2458 * rootcontext.cs: Added new options for strongnames.
2460 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
2462 * driver.cs: For --expect-error, report error code `2'
2463 if the program compiled with no errors, error code `1' if
2464 it compiled with an error other than the one expected.
2466 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
2468 * compiler.csproj: Updated for Visual Studio .NET 2003.
2469 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
2470 * compiler.sln: Updated for Visual Studio .NET 2003.
2472 2004-03-24 Ravi Pratap M <ravi@ximian.com>
2474 * expression.cs: Fix bug #47234. We basically need to apply the
2475 rule that we prefer the conversion of null to a reference type
2476 when faced with a conversion to 'object' (csc behaviour).
2478 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2480 * statement.cs: Shorter form for foreach, eliminates
2481 a local variable. r=Martin.
2483 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2485 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
2486 checks if we can use brtrue/brfalse to test for 0.
2487 * expression.cs: use the above in the test for using brtrue/brfalse.
2490 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2492 * expression.cs: Rewrite string concat stuff. Benefits:
2494 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
2495 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
2496 rather than a concat chain.
2498 * typemanager.cs: Add lookups for more concat overloads.
2500 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2502 * expression.cs: Emit shorter il code for array init.
2519 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
2521 * statement.cs: Before, two switch blocks would be merged if the
2522 total size of the blocks (end_item - begin_item + 1) was less than
2523 two times the combined sizes of the blocks.
2525 Now, it will only merge if after the merge at least half of the
2530 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
2532 * class.cs : csc build fix for GetMethods(). See bug #52503.
2534 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
2536 * expression.cs: Make sure fp comparisons work with NaN.
2537 This fixes bug #54303. Mig approved this patch a long
2538 time ago, but we were not able to test b/c the runtime
2541 2004-03-19 Miguel de Icaza <miguel@ximian.com>
2543 * ecore.cs (TypExpr.GetHashCode): implement this overload.
2545 2004-03-19 Martin Baulig <martin@ximian.com>
2547 * class.cs (MemberCore.IsDuplicateImplementation): Report the
2548 error here and not in our caller.
2550 2004-03-19 Martin Baulig <martin@ximian.com>
2552 * interface.cs: Completely killed this file.
2553 (Interface): We're now a TypeContainer and live in class.cs.
2555 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
2556 argument; we're now also called for interfaces.
2557 (TypeContainer.DefineMembers): Allow this method being called
2559 (TypeContainer.GetMethods): New public method; formerly known as
2560 Interface.GetMethod(). This is used by PendingImplementation.
2561 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
2562 it's now private and non-static.
2563 (Interface): Moved this here; it's now implemented similar to
2565 (Method, Property, Event, Indexer): Added `bool is_interface'
2566 argument to their .ctor's.
2567 (MemberBase.IsInterface): New public field.
2569 * cs-parser.jay: Create normal Method, Property, Event, Indexer
2570 instances instead of InterfaceMethod, InterfaceProperty, etc.
2571 (opt_interface_base): Removed; we now use `opt_class_base' instead.
2572 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
2574 2004-03-19 Martin Baulig <martin@ximian.com>
2576 * class.cs (MethodCore.IsDuplicateImplementation): New private
2577 method which does the CS0111 checking.
2578 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
2579 Use IsDuplicateImplementation().
2581 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
2583 * decl.cs (FindMemberToOverride): New method to find the correct
2584 method or property to override in the base class.
2586 - Make Method/Property use the above method to find the
2587 version in the base class.
2588 - Remove the InheritableMemberSignatureCompare as it is now
2591 This patch makes large code bases much faster to compile, as it is
2592 O(n) rather than O(n^2) to do this validation.
2594 Also, it fixes bug 52458 which is that nested classes are not
2595 taken into account when finding the base class member.
2597 Reviewed/Approved by Martin.
2599 2004-03-17 Marek Safar <marek.safar@seznam.cz>
2601 * interface.cs: In all interface classes removed redundant
2602 member initialization.
2604 2004-03-16 Martin Baulig <martin@ximian.com>
2606 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
2608 2004-03-15 Miguel de Icaza <miguel@ximian.com>
2610 * decl.cs (DefineTypeAndParents): New helper method to define a
2611 type's containers before the type itself is defined; This is a
2612 bug exposed by the recent changes to Windows.Forms when an
2613 implemented interface was defined inside a class that had not been
2616 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
2618 (Check): Loop correctly to report errors modifiers
2619 (UNSAFE was not in the loop, since it was the same as TOP).
2621 * interface.cs: Every interface member now takes a ModFlags,
2622 instead of a "is_new" bool, which we set on the base MemberCore.
2624 Every place where we called "UnsafeOk" in the interface, now we
2625 call the proper member (InterfaceMethod.UnsafeOK) instead to get
2626 the unsafe settings from the member declaration instead of the
2627 container interface.
2629 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
2631 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
2632 `set_indexer_name' to the pending bits (one per type).
2634 We fixed a bug today that was picking the wrong method to
2635 override, since for properties the existing InterfaceMethod code
2636 basically ignored the method name. Now we make sure that the
2637 method name is one of the valid indexer names.
2639 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
2641 * support.cs (SeekableStreamReader): Keep track of stream byte
2642 positions and don't mix them with character offsets to the buffer.
2644 Patch from Gustavo Giráldez
2646 2004-03-15 Marek Safar <marek.safar@seznam.cz>
2648 * interface.cs (InterfaceSetGetBase): Removed double member
2649 initialization, base class does it as well.
2651 2004-03-13 Martin Baulig <martin@ximian.com>
2653 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
2654 when compiling corlib.
2656 2004-03-13 Miguel de Icaza <miguel@ximian.com>
2658 * convert.cs (ExplicitConversion): We were reporting an error on
2659 certain conversions (object_type source to a value type, when the
2660 expression was `null') before we had a chance to pass it through
2661 the user defined conversions.
2663 * driver.cs: Replace / and \ in resource specifications to dots.
2666 * class.cs: Add check for duplicate operators. Fixes 52477
2668 2004-03-11 Miguel de Icaza <miguel@ximian.com>
2670 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
2671 that are in the middle of the statements, not only at the end.
2674 * class.cs (TypeContainer.AddField): No longer set the
2675 `HaveStaticConstructor' flag, now we call it
2676 `UserDefineStaticConstructor' to diferentiate the slightly
2677 semantic difference.
2679 The situation is that we were not adding BeforeFieldInit (from
2680 Modifiers.TypeAttr) to classes that could have it.
2681 BeforeFieldInit should be set to classes that have no static
2686 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
2688 And most importantly Zoltan's comment:
2690 http://bugzilla.ximian.com/show_bug.cgi?id=44229
2692 "I think beforefieldinit means 'it's ok to initialize the type sometime
2693 before its static fields are used', i.e. initialization does not need
2694 to be triggered by the first access to the type. Setting this flag
2695 helps the JIT to compile better code, since it can run the static
2696 constructor at JIT time, and does not need to generate code to call it
2697 (possibly lots of times) at runtime. Unfortunately, mcs does not set
2698 this flag for lots of classes like String.
2700 csc sets this flag if the type does not have an explicit static
2701 constructor. The reasoning seems to be that if there are only static
2702 initalizers for a type, and no static constructor, then the programmer
2703 does not care when this initialization happens, so beforefieldinit
2706 This bug prevents the AOT compiler from being usable, since it
2707 generates so many calls to mono_runtime_class_init that the AOT code
2708 is much slower than the JITted code. The JITted code is faster,
2709 because it does not generate these calls if the vtable is type is
2710 already initialized, which is true in the majority of cases. But the
2711 AOT compiler can't do this."
2713 2004-03-10 Miguel de Icaza <miguel@ximian.com>
2715 * class.cs (MethodData.Emit): Refactor the code so symbolic
2716 information is generated for destructors; For some reasons we
2717 were taking a code path that did not generate symbolic information
2720 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
2722 * class.cs: Create a Constructor.CheckBase method that
2723 takes care of all validation type code. The method
2724 contains some code that was moved from Define.
2726 It also includes new code that checks for duplicate ctors.
2727 This fixes bug #55148.
2729 2004-03-09 Joshua Tauberer <tauberer@for.net>
2731 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
2732 a { ... }-style array creation invokes EmitStaticInitializers
2733 which is not good for reference-type arrays. String, decimal
2734 and now null constants (NullCast) are not counted toward
2735 static initializers.
2737 2004-03-05 Martin Baulig <martin@ximian.com>
2739 * location.cs (SourceFile.HasLineDirective): New public field;
2740 specifies whether the file contains or is referenced by a "#line"
2742 (Location.DefineSymbolDocuments): Ignore source files which
2743 either contain or are referenced by a "#line" directive.
2745 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
2747 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
2748 direct access to our parent, so check the method inline there.
2750 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
2752 * expression.cs (Invocation.EmitCall): Miguel's last commit
2753 caused a regression. If you had:
2758 In Foo the implict this would be null.
2760 2004-02-27 Miguel de Icaza <miguel@ximian.com>
2762 * expression.cs (Invocation.EmitCall): If the method is not
2763 virtual, do not emit a CallVirt to it, use Call.
2765 * typemanager.cs (GetFullNameSignature): Improve the method to
2766 cope with ".ctor" and replace it with the type name.
2768 * class.cs (ConstructorInitializer.Resolve): Now the method takes
2769 as an argument the ConstructorBuilder where it is being defined,
2770 to catch the recursive constructor invocations.
2772 2004-02-26 Miguel de Icaza <miguel@ximian.com>
2774 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
2775 routines to check if a type is an enumerable/enumerator allow
2776 classes that implement the IEnumerable or IEnumerator interfaces.
2778 * class.cs (Property, Operator): Implement IIteratorContainer, and
2779 implement SetYields.
2781 (Property.Define): Do the block swapping for get_methods in the
2782 context of iterators. We need to check if Properties also
2783 include indexers or not.
2785 (Operator): Assign the Block before invoking the
2786 OperatorMethod.Define, so we can trigger the Iterator code
2789 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
2790 Property and Operator classes are not created when we parse the
2791 declarator but until we have the block completed, so we use a
2792 singleton SimpleIteratorContainer.Simple to flag whether the
2793 SetYields has been invoked.
2795 We propagate this setting then to the Property or the Operator to
2796 allow the `yield' to function.
2798 2004-02-25 Marek Safar <marek.safar@seznam.cz>
2800 * codegen.cs: Implemented attribute support for modules.
2801 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
2802 Assembly/Module functionality.
2804 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
2805 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
2806 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
2808 2004-02-16 Marek Safar <marek.safar@seznam.cz>
2810 * interface.cs (FindMembers): The operation is performed on all base
2811 interfaces and not only on the first. It is required for future CLS Compliance patch.
2813 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
2815 * statement.cs, codegen.cs:
2816 This patch deals with patterns such as:
2818 public class List : IEnumerable {
2820 public MyEnumerator GetEnumerator () {
2821 return new MyEnumerator(this);
2824 IEnumerator IEnumerable.GetEnumerator () {
2828 public struct MyEnumerator : IEnumerator {
2833 Before, there were a few things we did wrong:
2834 1) we would emit callvirt on a struct, which is illegal
2835 2) we emited ldarg when we needed to emit ldarga
2836 3) we would mistakenly call the interface methods on an enumerator
2837 type that derived from IEnumerator and was in another assembly. For example:
2839 public class MyEnumerator : IEnumerator
2841 Would have the interface methods called, even if there were public impls of the
2842 method. In a struct, this lead to invalid IL code.
2844 2004-02-11 Marek Safar <marek.safar@seznam.cz>
2846 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
2849 * delegate.cs (Define): Fixed crash when delegate type is undefined.
2851 2004-02-11 Miguel de Icaza <miguel@ximian.com>
2853 * cs-parser.jay: Fix small regression: we were not testing V2
2854 compiler features correctly.
2856 * interface.cs: If the emit context is null, then create one
2858 2004-02-09 Marek Safar <marek.safar@seznam.cz>
2860 * decl.cs (GetSignatureForError): New virtual method to get full name
2863 * attribute.cs (IAttributeSupport): New interface for attribute setting.
2864 Now it is possible to rewrite ApplyAttributes method to be less if/else.
2866 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
2867 Duplicated members and code in these classes has been removed.
2868 Better encapsulation in these classes.
2870 2004-02-07 Miguel de Icaza <miguel@ximian.com>
2872 * assign.cs (Assign.DoResolve): When dealing with compound
2873 assignments, there is a new rule in ECMA C# 2.4 (might have been
2874 there before, but it is documented here) that states that in:
2878 If b is of type int, and the `op' is a shift-operator, then the
2879 above is evaluated as:
2883 * expression.cs (Binary.ResolveOperator): Instead of testing for
2884 int/uint/long/ulong, try to implicitly convert to any of those
2885 types and use that in pointer arithmetic.
2887 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
2888 method to print information for from the type, not from the
2889 null-method we were given.
2891 2004-02-01 Duncan Mak <duncan@ximian.com>
2893 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
2894 parsing for cmd, fixes bug #53694.
2896 2004-02-04 Marek Safar <marek.safar@seznam.cz>
2898 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
2899 in the member name duplication tests. Property and operator name duplication
2900 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
2902 2004-02-03 Marek Safar <marek.safar@seznam.cz>
2904 * interface.cs (PopulateMethod): Fixed crash when interface method
2905 returns not existing type (error test cs0246-3.cs).
2907 2004-02-02 Ravi Pratap M <ravi@ximian.com>
2909 * cs-parser.jay (interface_accessors): Re-write actions to also
2910 store attributes attached to get and set methods. Fix spelling
2913 (inteface_property_declaration): Modify accordingly.
2915 (InterfaceAccessorInfo): New helper class to store information to pass
2916 around between rules that use interface_accessors.
2918 * interface.cs (Emit): Apply attributes on the get and set
2919 accessors of properties and indexers too.
2921 * attribute.cs (ApplyAttributes): Modify accordingly to use the
2922 right MethodBuilder when applying attributes to the get and set accessors.
2924 2004-01-31 Miguel de Icaza <miguel@ximian.com>
2926 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
2928 2004-01-26 Miguel de Icaza <miguel@ximian.com>
2930 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
2932 2004-01-25 Miguel de Icaza <miguel@ximian.com>
2934 * cs-parser.jay: Remove YIELD token, instead use the new grammar
2935 changes that treat `yield' specially when present before `break'
2938 * cs-tokenizer.cs: yield is no longer a keyword.
2940 2004-01-23 Marek Safar <marek.safar@seznam.cz>
2942 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
2943 setting for default constructors.
2944 For default constructors are almost every time set wrong Modifier. The
2945 generated IL code has been alright. But inside mcs this values was
2946 wrong and this was reason why several of my CLS Compliance tests
2949 2004-01-22 Martin Baulig <martin@ximian.com>
2951 * cs-parser.jay (namespace_or_type_name): Return an Expression,
2952 not a QualifiedIdentifier. This is what `type_name_expression'
2953 was previously doing.
2954 (type_name_expression): Removed; the code is now in
2955 `namespace_or_type_name'.
2956 (qualified_identifier): Removed, use `namespace_or_type_name'
2958 (QualifiedIdentifier): Removed this class.
2960 2004-01-22 Martin Baulig <martin@ximian.com>
2962 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
2963 not a string as alias name.
2965 2004-01-21 Miguel de Icaza <miguel@ximian.com>
2967 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
2968 #52730 bug, and instead compute correctly the need to use a
2969 temporary variable when requesting an address based on the
2970 static/instace modified of the field and the constructor.
2972 2004-01-21 Martin Baulig <martin@ximian.com>
2974 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
2975 class and namespace before looking up aliases. Fixes #52517.
2977 2004-01-21 Martin Baulig <martin@ximian.com>
2979 * flowanalysis.cs (UsageVector.Merge): Allow variables being
2980 assinged in a 'try'; fixes exception4.cs.
2982 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2983 * class.cs : Implemented parameter-less constructor for TypeContainer
2985 * decl.cs: Attributes are now stored here. New property OptAttributes
2987 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
2989 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
2991 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2993 * typemanager.cs (CSharpSignature): Now reports also inner class name.
2994 (CSharpSignature): New method for indexer and property signature.
2996 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2998 * pending.cs (IsVirtualFilter): Faster implementation.
3000 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3002 * typemanager.cs: Avoid inclusion of same assembly more than once.
3004 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3006 * cs-parser.jay: Fixed problem where the last assembly attribute
3007 has been applied also to following declaration (class, struct, etc.)
3009 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3011 * class.cs: Added error CS0538, CS0539 reporting.
3012 Fixed crash on Microsoft runtime when field type is void.
3014 * cs-parser.jay: Added error CS0537 reporting.
3016 * pending.cs: Added error CS0535 reporting.
3017 Improved error report for errors CS0536, CS0534.
3019 2004-01-20 Miguel de Icaza <miguel@ximian.com>
3021 Merge a few bits from the Anonymous Method MCS tree.
3023 * statement.cs (ToplevelBlock): New class for toplevel methods,
3024 will hold anonymous methods, lifted variables.
3026 * cs-parser.jay: Create toplevel blocks for delegates and for
3027 regular blocks of code.
3029 2004-01-20 Martin Baulig <martin@ximian.com>
3031 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
3032 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
3033 and `NeedExplicitReturn'; added `IsLastStatement'.
3034 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
3035 have a `ReturnLabel' or we're not unreachable.
3037 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
3038 child's reachability; don't just override ours with it. Fixes
3039 #58058 (lluis's example).
3040 (FlowBranching): Added public InTryOrCatch(), InCatch(),
3041 InFinally(), InLoop(), InSwitch() and
3042 BreakCrossesTryCatchBoundary() methods.
3044 * statement.cs (Return): Do all error checking in Resolve().
3045 Unless we are the last statement in a top-level block, always
3046 create a return label and jump to it.
3047 (Break, Continue): Do all error checking in Resolve(); also make
3048 sure we aren't leaving a `finally'.
3049 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
3050 statement in a top-level block.
3051 (Block.Flags): Added `IsDestructor'.
3052 (Block.IsDestructor): New public property.
3054 2004-01-20 Martin Baulig <martin@ximian.com>
3056 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
3058 2004-01-20 Martin Baulig <martin@ximian.com>
3060 * statement.cs (Statement.ResolveUnreachable): New public method.
3061 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
3062 (Block.Resolve): Resolve unreachable statements.
3064 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3066 * expression.cs: We need to fix the case where we do
3067 not have a temp variable here.
3069 * assign.cs: Only expression compound assignments need
3070 temporary variables.
3072 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3074 * flowanalysis.cs: Reduce memory allocation in a few ways:
3075 - A block with no variables should not allocate a bit
3077 - A method with no out parameters does not need any tracking
3078 for assignment of the parameters, so we need not allocate
3081 public readonly Type[] VariableTypes;
3082 public readonly string[] VariableNames;
3083 Are redundant. The data is already stored in the variable
3084 map, so we need not allocate another array for it.
3085 - We need to add alot of checks for if (params | locals) == null
3086 due to the first two changes.
3088 2004-01-18 Miguel de Icaza <miguel@ximian.com>
3090 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
3091 implement IMemoryLocation, we store a copy on a local variable and
3092 take the address of it. Patch from Benjamin Jemlich
3094 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
3095 to use a special "type_name_expression" rule which reduces the
3096 number of "QualifiedIdentifier" classes created, and instead
3097 directly creates MemberAccess expressions.
3099 2004-01-17 Miguel de Icaza <miguel@ximian.com>
3101 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
3102 that fixes #52853. Null literal assignment to ValueType
3104 * class.cs (MethodData.Emit): Instead of checking the name of the
3105 method to determine if its a destructor, create a new derived
3106 class from Method called Destructor, and test for that.
3108 * cs-parser.jay: Create a Destructor object instead of a Method.
3110 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
3114 2004-01-16 Miguel de Icaza <miguel@ximian.com>
3116 * expression.cs (Binary.ResolveOperator): Perform an implicit
3117 conversion from MethodGroups to their delegate types on the
3120 * delegate.cs: Introduce a new class DelegateCreation that is the
3121 base class for `NewDelegate' and `ImplicitDelegateCreation',
3122 factor some code in here.
3124 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
3125 conversion from MethodGroups to compatible delegate types.
3127 * ecore.cs (Expression.Resolve): Do not flag error 654
3128 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
3129 we allow conversions from MethodGroups to delegate types now.
3131 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
3132 assignments in v2 either.
3134 2004-01-10 Miguel de Icaza <miguel@ximian.com>
3136 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
3137 static read-only fields in ctors.
3139 Applied patch from Benjamin Jemlich
3141 * expression.cs (UnaryMutator): Avoid leaking local variables.
3143 2004-01-09 Miguel de Icaza <miguel@ximian.com>
3145 * cs-tokenizer.cs (IsCastToken): Allow the various native types
3146 here to return true, as they can be used like this:
3150 Fixed 49836 and all the other dups
3152 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
3154 * driver.cs: Implement /win32res and /win32icon.
3156 2004-01-08 Miguel de Icaza <miguel@ximian.com>
3158 * cs-parser.jay: Add a rule to improve error handling for the
3159 common mistake of placing modifiers after the type.
3161 2004-01-07 Miguel de Icaza <miguel@ximian.com>
3163 * cs-parser.jay (interface_event_declaration): Catch
3164 initialization of events on interfaces, and report cs0068
3166 * cs-parser.jay (interface_event_declaration): Catch
3167 initialization of events.
3169 * ecore.cs: Better report missing constructors.
3171 * expression.cs (Binary.ResolveOperator): My previous bug fix had
3172 the error reporting done in the wrong place. Fix.
3174 * expression.cs (Binary.ResolveOperator): Catch the
3175 operator + (E x, E y) error earlier, and later allow for implicit
3176 conversions in operator +/- (E e, U x) from U to the underlying
3179 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
3180 52596, if the container class is abstract, the default constructor
3181 is protected otherwise its public (before, we were always public).
3183 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
3186 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
3187 Jemlich that fixes bug #52597, MCS was generating invalid code for
3188 idisposable structs. Thanks to Ben for following up with this
3191 2004-01-06 Miguel de Icaza <miguel@ximian.com>
3193 * driver.cs: Allow assemblies without code to be generated, fixes
3196 2004-01-07 Nick Drochak <ndrochak@gol.com>
3198 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
3200 2004-01-05 Miguel de Icaza <miguel@ximian.com>
3202 * cs-parser.jay: Add rules to improve error reporting if fields or
3203 methods are declared at the namespace level (error 116)
3205 * Add rules to catch event add/remove
3207 2004-01-04 David Sheldon <dave-mono@earth.li>
3209 * expression.cs: Added matching ")" to error message for
3212 2004-01-03 Todd Berman <tberman@gentoo.org>
3214 * ecore.cs, attribute.cs:
3215 Applying fix from #52429.
3217 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3219 * ecore.cs, expression.cs, statement.cs:
3220 Total rewrite of how we handle branching. We
3221 now handle complex boolean expressions with fewer
3222 jumps. As well if (x == 0) no longer emits a ceq.
3224 if (x is Foo) is much faster now, because we generate
3227 Overall, we get a pretty big improvement on our benchmark
3228 tests. The code we generate is smaller and more readable.
3230 I did a full two-stage bootstrap. The patch was reviewed
3231 by Martin and Miguel.
3233 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3235 * cs-parser.jay: Make primary_expression not take a QI.
3236 we dont need this because the member_access rule covers
3237 us here. So we replace the rule with just IDENTIFIER.
3239 This has two good effects. First, we remove a s/r conflict.
3240 Second, we allocate many fewer QualifiedIdentifier objects.
3242 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3244 * attribute.cs: Handle MarshalAs attributes as pseudo, and
3245 set the correct information via SRE. This prevents
3246 hanging on the MS runtime. Fixes #29374.
3248 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3250 * convert.cs: correctly handle conversions to value types
3251 from Enum and ValueType as unboxing conversions.
3253 Fixes bug #52569. Patch by Benjamin Jemlich.
3255 2004-01-02 Ravi Pratap <ravi@ximian.com>
3257 * expression.cs (BetterConversion): Prefer int -> uint
3258 over int -> ulong (csc's behaviour). This fixed bug #52046.
3260 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
3262 * decl.cs (MemberCache.FindMembers): now returns a
3265 * typemanager.cs: In general, go with with ^^.
3266 (CopyNewMethods): take an IList.
3267 (RealMemberLookup): Only allocate an arraylist
3268 if we copy from two sets of methods.
3270 This change basically does two things:
3271 1) Fewer array lists allocated due to CopyNewMethods.
3272 2) the explicit cast in MemberList costed ALOT.
3274 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
3276 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
3277 a hashtable to avoid needless string allocations when an identifier is
3278 used more than once (the common case).
3280 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
3282 * pending.cs: MS's TypeBuilder.GetInterfaces ()
3283 is broken, it will not return anything. So, we
3284 have to use the information we have in mcs to
3287 * typemanager.cs: Add a cache for GetInterfaces,
3288 since this will now be used more often (due to ^^)
3290 (GetExplicitInterfaces) New method that gets the
3291 declared, not effective, interfaces on a type
3292 builder (eg, if you have interface IFoo, interface
3293 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
3296 This patch makes MCS able to bootstrap itself on
3299 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
3301 * expression.cs: Remove the Nop's that Miguel put
3304 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3306 * report.cs, codegen.cs: Give the real stack trace to
3307 the error when an exception is thrown.
3309 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3311 * decl.cs: only allocate hashtables for ifaces if
3314 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3316 * expression.cs: fix the error from cs0121-2.cs
3317 (a parent interface has two child interfaces that
3318 have a function with the same name and 0 params
3319 and the function is called through the parent).
3321 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
3323 * class.cs, rootcontext.cs, typmanager.cs: do not
3326 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
3328 * codegen.cs: remove stack for the ec flow branching.
3329 It is already a linked list, so no need.
3331 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
3333 * Makefile: Allow custom profiler here.
3335 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
3337 * typemanager.cs (LookupType):
3338 - Use a static char [], because split takes
3339 a param array for args, so it was allocating
3341 - Do not store true in a hashtable, it boxes.
3343 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
3345 * flowanalysis.cs: bytify common enums.
3347 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3349 * modifiers.cs: Add a new set of flags for the
3350 flags allowed on explicit interface impls.
3351 * cs-parser.jay: catch the use of modifiers in
3352 interfaces correctly.
3353 * class.cs: catch private void IFoo.Blah ().
3355 All related to bug #50572.
3357 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3359 * decl.cs: Rewrite the consistant accessability checking.
3360 Accessability is not linear, it must be implemented in
3361 a tableish way. Fixes #49704.
3363 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3365 * expression.cs: Handle negation in a checked context.
3366 We must use subtraction from zero. Fixes #38674.
3368 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
3370 * class.cs: Ignore static void main in DLLs.
3371 * rootcontext.cs: Handle the target type here,
3372 since we are have to access it from class.cs
3373 * driver.cs: account for the above.
3375 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
3377 * report.cs: Give line numbers and files if available.
3379 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
3381 * driver.cs: Implement /addmodule.
3383 * typemanager.cs: Change 'modules' field so it now contains Modules not
3386 2003-12-20 Martin Baulig <martin@ximian.com>
3388 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
3389 (FieldBase.IsAssigned): Removed this field.
3390 (FieldBase.SetAssigned): New public method.
3391 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
3393 2003-12-20 Martin Baulig <martin@ximian.com>
3395 * expression.cs (LocalVariableReference.DoResolve): Don't set
3396 `vi.Used' if we're called from DoResolveLValue().
3398 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
3399 returns the usage vector it just merged into the current one -
3400 pass this one to UsageWarning().
3401 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
3402 of the `EmitContext', don't call this recursively on our children.
3404 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
3406 * driver.cs: Implement /target:module.
3408 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
3410 * support.cs (CharArrayHashtable): New helper class.
3412 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
3413 char arrays, not strings, so we can avoid creating a string in
3414 consume_identifier if the identifier is a keyword.
3416 2003-12-16 Martin Baulig <martin@ximian.com>
3418 * statement.cs (LocalInfo.Assigned): Removed this property.
3419 (LocalInfo.Flags): Removed `Assigned'.
3420 (LocalInfo.IsAssigned): New public method; takes the EmitContext
3421 and uses flow analysis.
3422 (Block.UsageWarning): Made this method private.
3423 (Block.Resolve): Call UsageWarning() if appropriate.
3425 * expression.cs (LocalVariableReference.DoResolve): Always set
3426 LocalInfo.Used here.
3428 2003-12-13 Martin Baulig <martin@ximian.com>
3430 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
3431 any value here; we're now using flow analysis to figure out
3432 whether a statement/block returns a value.
3434 2003-12-13 Martin Baulig <martin@ximian.com>
3436 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
3438 (FlowBranching.MergeFinally): Don't call
3439 `branching.CheckOutParameters()' here, this is called in
3441 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
3442 when adding the `finally' vector.
3444 2003-12-13 Martin Baulig <martin@ximian.com>
3447 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
3448 actually work and also fix #48962.
3450 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
3452 * decl.cs: Do not check System.Object for nested types,
3453 since we know it does not have any. Big bang for buck:
3458 corlib: 17.99 seconds
3462 corlib: 17.39 seconds
3464 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
3466 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
3467 time we are returning 0 members, so we save alot here.
3469 2003-12-11 Martin Baulig <martin@ximian.com>
3471 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
3472 `MergeChild()', also just take the `FlowBranching' as argument;
3473 call Merge() on it and return the result.
3474 (FlowBranching.Merge): We don't need to do anything if we just
3477 2003-12-11 Martin Baulig <martin@ximian.com>
3479 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
3480 them in an `ArrayList' to reduce memory usage. Thanks to Ben
3481 Maurer for this idea.
3483 2003-12-11 Martin Baulig <martin@ximian.com>
3485 * flowanalysis.cs (MergeResult): This class is now gone; we now
3486 use the `UsageVector' for this. The reason for this is that if a
3487 branching just has one sibling, we don't need to "merge" them at
3488 all - that's the next step to do.
3489 (FlowBranching.Merge): We now return a `UsageVector' instead of a
3492 2003-12-11 Martin Baulig <martin@ximian.com>
3494 Reworked flow analyis and made it more precise and bug-free. The
3495 most important change is that we're now using a special `Reachability'
3496 class instead of having "magic" meanings of `FlowReturns'. I'll
3497 do some more cleanups and optimizations and also add some more
3498 documentation this week.
3500 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
3501 largely reworked this class.
3502 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
3503 the new `Reachability' class instead of having "magic" values here.
3504 (FlowBranching): We're now using an instance of `Reachability'
3505 instead of having separate `Returns', `Breaks' etc. fields.
3507 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
3508 based on flow analysis; ignore the return value of block.Emit ().
3510 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
3512 * driver.cs typemanager.cs: Find the mono extensions to corlib even
3513 if they are private.
3515 2003-12-09 Martin Baulig <martin@ximian.com>
3517 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
3518 call them directly on the UsageVector.
3520 2003-12-09 Martin Baulig <martin@ximian.com>
3522 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
3523 Changed return type from `FlowReturns' to `Reachability'.
3525 2003-12-09 Martin Baulig <martin@ximian.com>
3527 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
3528 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
3529 `Reachable' fields with a single `Reachability' one.
3531 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3533 * class.cs (FindMembers): Remove foreach's.
3546 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3551 This patch does a few things:
3552 1. EmptyStatement is now a singleton, so it is never reallocated.
3553 2. All blah is EmptyStatement constructs have been changed to
3554 blah == EmptyStatement.Value, which is much faster and valid
3555 now that EmptyStatement is a singleton.
3556 3. When resolving a block, rather than allocating a new array for
3557 the non-empty statements, empty statements are replaced with
3558 EmptyStatement.Value
3559 4. Some recursive functions have been made non-recursive.
3560 Mainly the performance impact is from (3), however (1) and (2) are needed for
3561 this to work. (4) does not make a big difference in normal situations, however
3562 it makes the profile look saner.
3567 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
3568 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
3569 Total memory allocated: 56397 KB
3572 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
3573 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
3574 Total memory allocated: 55666 KB
3576 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3578 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
3579 than the hashtable in a hashtable version
3581 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
3582 we always end up concating a string. This results in a huge perf
3583 loss, because many strings have to be tracked by the GC. In this
3584 patch, we first use a hashtable that works with two keys, so that
3585 the strings do not need to be concat'ed.
3596 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3598 * Makefile: Add a new target `do-time' that does a quick and simple
3599 profile, leaving easy to parse output.
3601 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
3603 * codegen.cs (Init): Create the dynamic assembly with
3604 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
3606 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
3608 * support.cs: Make the PtrHashtable use only one
3609 instance of its comparer.
3611 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
3613 * typemanager.cs: Fix lookup of GetNamespaces.
3615 2003-11-29 Miguel de Icaza <miguel@ximian.com>
3617 * expression.cs: Removed redundant line.
3619 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
3620 ArrayLists, use for loops with bounds.
3622 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
3625 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
3626 arraylists, use for loop with bounds.
3628 The above three changes give us a 0.071 second performance
3629 improvement out of 3.294 seconds down to 3.223. On my machine
3630 the above changes reduced the memory usage by 1,387 KB during
3633 * cs-parser.jay (QualifiedIdentifier): New class used to represent
3634 QualifiedIdentifiers. Before we created a new string through
3635 concatenation, and mostly later on, the result would be
3636 manipulated by DecomposeQI through string manipulation.
3638 This reduced the compiler memory usage for bootstrapping from
3639 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
3640 compile times in 0.05 seconds.
3642 2003-11-28 Dick Porter <dick@ximian.com>
3644 * support.cs: Do string compares with the Invariant culture.
3652 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
3653 the comparison is done with the Invariant culture.
3655 2003-11-27 Miguel de Icaza <miguel@ximian.com>
3657 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
3658 GetEnumerator method.
3660 (ProbeCollectionType): Iterate starting at the most specific type
3661 upwards looking for a GetEnumerator
3663 * expression.cs: Shift count can be up to 31 for int/uint and 63
3666 2003-11-26 Miguel de Icaza <miguel@ximian.com>
3668 * statement.cs (Block.LookupLabel): Also look for the label on the
3669 children blocks. Use a hash table to keep track of visited
3672 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
3673 we actually did transform the other operand, otherwise fall back
3674 to the common codepath that casts to long.
3676 * cs-tokenizer.cs: Use the same code pattern as the int case.
3677 Maybe I should do the parsing myself, and avoid depending on the
3678 Parse routines to get this done.
3680 2003-11-25 Miguel de Icaza <miguel@ximian.com>
3682 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3683 which fixes bug 51347. This time test it.
3685 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
3686 attributes for example can not tell the difference between these.
3687 The difference was only a syntax feature of the language.
3689 * attribute.cs: Apply attributes to delegates.
3691 * delegate.cs: Call the apply attributes method.
3693 2003-11-24 Miguel de Icaza <miguel@ximian.com>
3695 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
3696 comparing 0 vs Byte.MinValue, not the value
3698 (ImplicitConversionRequired): When reporting a conversion error,
3699 use error 31 to print out the constant error instead of the
3702 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3703 which fixes bug 51347.
3705 2003-11-22 Miguel de Icaza <miguel@ximian.com>
3707 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
3708 which fixes the -warnaserror command line option.
3710 2003-11-21 Miguel de Icaza <miguel@ximian.com>
3712 * cfold.cs (DoNumericPromotions): During constant folding of
3713 additions on UIntConstant, special case intconstants with
3714 IntConstants like we do on the expression binary operator.
3716 2003-11-12 Miguel de Icaza <miguel@ximian.com>
3718 * convert.cs (ImplicitReferenceConversion): We were missing a case
3719 (System.Enum are not value types or class types, so we need to
3720 classify them separatedly).
3722 * driver.cs: We do not support error 2007.
3724 2003-11-12 Jackson Harper <jackson@ximian.com>
3726 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
3727 system directory. Also use the full file name so users can
3728 libraries names mscorlib-o-tron.dll in a non system dir.
3730 2003-11-10 Martin Baulig <martin@ximian.com>
3732 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
3733 (TypeManager.InitCoreTypes): Initialize them here, but instead of
3734 calling `ResolveType()' on them, directly assign their `Type'.
3736 2003-11-08 Martin Baulig <martin@ximian.com>
3738 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
3739 return value and the `out parent' parameter.
3740 (TypeContainer.DefineType): Moved the CS0644 check into
3741 GetClassBases(). Don't pass the interface types to the
3742 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
3743 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
3745 * ecore.cs (TypeExpr.IsAttribute): New property.
3746 (TypeExpr.GetInterfaces): New method.
3748 * interface.cs (Interface.GetInterfaceTypeByName): Return a
3749 TypeExpr instead of a Type.
3750 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
3751 (Interface.DefineType): Don't pass the interface types to the
3752 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
3753 them later and then call `TypeBulider.AddInterfaceImplementation()'.
3755 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
3756 instead of a `Type[]'.
3757 (TypeManager.RegisterBuilder): Likewise.
3758 (TypeManager.AddUserInterface): Likewise.
3759 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
3760 `Type[]' and also return a `TypeExpr[]'.
3761 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
3763 2003-11-08 Martin Baulig <martin@ximian.com>
3765 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
3768 2003-11-08 Martin Baulig <martin@ximian.com>
3770 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
3771 TypeManager.ResolveExpressionTypes().
3773 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
3774 instead of an Expression.
3775 (TypeExpr): This is now an abstract base class for `TypeExpression'.
3776 (TypeExpression): New public class; formerly known as `TypeExpr'.
3778 * expression.cs (ComposedCast): Derive from TypeExpr.
3780 * typemanager.cs (TypeManager.system_*_expr): These are now
3781 TypExpr's instead of Expression's.
3782 (TypeManager.ResolveExpressionTypes): New public static function;
3783 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
3786 2003-11-06 Miguel de Icaza <miguel@ximian.com>
3788 * expression.cs (New.DoResolve): Do not dereference value that
3789 might be a null return.
3791 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
3792 sure that the constant value has the right type. Fixes an
3793 unreported bug, similar to 50425.
3795 * const.cs (Const.LookupConstantValue): Call
3796 ImplicitStandardConversionExists before doing a conversion to
3797 avoid havng the TypeManager.ChangeType do conversions.
3799 Reduced the number of casts used
3801 (Const.ChangeType): New routine to enable reuse of the constant
3802 type changing code from statement.
3804 * typemanager.cs (ChangeType): Move common initialization to
3805 static global variables.
3809 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
3810 every value type to go through, even if it was void. Fix that.
3812 * cs-tokenizer.cs: Use is_identifier_start_character on the start
3813 character of the define, and the is_identifier_part_character for
3814 the rest of the string.
3816 2003-11-05 Miguel de Icaza <miguel@ximian.com>
3818 * expression.cs (UnaryMutator.EmitCode): When I updated
3819 LocalVariableReference.DoResolve, I overdid it, and dropped an
3820 optimization done on local variable references.
3822 2003-11-04 Miguel de Icaza <miguel@ximian.com>
3824 * ecore.cs: Convert the return from Ldlen into an int.
3826 2003-10-20 Miguel de Icaza <miguel@ximian.com>
3828 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
3829 the accessibility, this is a special case for toplevel non-public
3830 classes (internal for instance).
3832 2003-10-20 Nick Drochak <ndrochak@gol.com>
3834 * ecore.cs: Fix typo and build. Needed another right paren.
3836 2003-10-19 Miguel de Icaza <miguel@ximian.com>
3838 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
3839 `internal' case regular and protected, but not allowing protected
3840 to be evaluated later. Bug 49840
3842 2003-10-15 Miguel de Icaza <miguel@ximian.com>
3844 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
3845 to kb.Nlast, and not the kb.nFirst to isolate the switch
3848 Extract the underlying type, so enumerations of long/ulong are
3849 treated like long/ulong.
3851 2003-10-14 Miguel de Icaza <miguel@ximian.com>
3853 * expression.cs (New): Overload the meaning of RequestedType to
3854 track the possible creation of the NewDelegate type, since
3855 DoResolve is invoked more than once for new constructors on field
3858 See bugs: #48800 and #37014
3860 * cs-parser.jay (declare_local_constants): Take an arraylist
3861 instead of a single constant.
3863 (local_constant_declaration): It should take a
3864 constant_declarators, not a constant_declarator. Fixes 49487
3866 * convert.cs: Fix error report.
3868 2003-10-13 Jackson Harper <jackson@ximian.com>
3870 * typemanager.cs (TypeToCoreType): Add float and double this fixes
3873 2003-10-09 Martin Baulig <martin@ximian.com>
3875 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
3877 (MethodCore.DoDefineParameters): Removed the TypeContainer
3878 argument; use the DeclSpace which was passed to the .ctor instead.
3879 (MethodCore.CheckParameter): Take a DeclSpace instead of a
3880 TypeContainer; we only need a DeclSpace here.
3882 2003-10-09 Martin Baulig <martin@ximian.com>
3884 * class.cs (MethodData): Added additional `DeclSpace ds' argument
3886 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
3887 EmitContext's .ctor.
3889 2003-10-09 Martin Baulig <martin@ximian.com>
3891 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
3892 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
3893 AsAccessible(), moved them as well.
3895 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
3897 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
3899 * cs-parser.jay : Renamed yyName to yyNames related to jay.
3901 2003-10-07 Miguel de Icaza <miguel@ximian.com>
3903 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
3904 generation for >=, as spotted by Paolo, bug 48679.
3905 Patch from David Waite.
3907 * cs-tokenizer.cs: Add handling for #pragma.
3909 * cs-parser.jay: Allow for both yield and yield return in the
3910 syntax. The anti-cobolization of C# fight will go on!
3912 * class.cs (TypeBuilder.DefineType): Catch error condition here
3913 (Parent.DefineType erroring out and returning null).
3915 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
3916 coping with enumerations variables, we were mistakenly processing
3917 them as a regular value type instead of built-in types. Fixes the
3920 * typemanager.cs (IsBuiltinOrEnum): New method.
3922 2003-09-30 Miguel de Icaza <miguel@ximian.com>
3924 * cs-parser.jay: Upgrade: yield now needs the return clause.
3926 2003-09-19 Martin Baulig <martin@ximian.com>
3928 * decl.cs (MemberCache.SetupCacheForInterface): Take a
3929 `MemberCache parent' argument. Normally, an interface doesn't
3930 have a parent type except System.Object, but we use this in gmcs
3931 for generic type parameters.
3933 2003-09-18 Martin Baulig <martin@ximian.com>
3935 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
3936 on `type.IsInterface'; don't check whether the type has a parent
3937 to determine whether it's an interface.
3939 2003-09-15 Martin Baulig <martin@ximian.com>
3941 * class.cs (TypeContainer.DefineType): Added an error flag to
3942 avoid reporting duplicate CS0146's ("class definition is
3945 * driver.cs (Driver.MainDriver): Abort if
3946 RootContext.ResolveTree() reported any errors.
3948 2003-09-07 Martin Baulig <martin@ximian.com>
3950 * report.cs (Error, Warning): Added overloaded versions which take
3951 a `params object[] args' and call String.Format().
3953 2003-09-07 Martin Baulig <martin@ximian.com>
3955 * decl.cs (DeclSpace..ctor): Don't call
3956 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
3957 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
3958 (DeclSpace.RecordDecl): New method.
3960 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
3962 2003-09-02 Ravi Pratap <ravi@ximian.com>
3964 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
3965 value attributes to be applied to ParameterBuilders.
3967 * class.cs (MethodCore.LabelParameters): Make static and more
3968 generic so that it can be used from other places - like interface
3969 methods, for instance.
3971 * interface.cs (Interface.Emit): Call LabelParameters before
3972 emitting attributes on the InterfaceMethod.
3974 2003-08-26 Martin Baulig <martin@ximian.com>
3976 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
3977 resolving aliases; fixes #47927.
3979 2003-08-26 Martin Baulig <martin@ximian.com>
3981 * statement.cs (Using.DoResolve): This is internally emitting a
3982 try/finally clause, so we need to set ec.NeedExplicitReturn if we
3983 do not always return. Fixes #47681.
3985 2003-08-26 Martin Baulig <martin@ximian.com>
3987 * decl.cs (MemberCore): Moved WarningNotHiding(),
3988 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
3990 (AdditionResult): Make this nested in DeclSpace.
3991 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
3992 argument; call NamespaceEntry.Define() unless we're nested in a
3995 * namespace.cs (Namespace.DefineName): New public function. This
3996 is called from DeclSpace's .ctor to add
3997 (Namespace.Lookup): Include DeclSpaces in the lookup.
3999 * class.cs (Operator): Derive from MemberBase, not MemberCore.
4001 * const.cs (Const): Derive from MemberBase, not MemberCore.
4003 2003-08-25 Martin Baulig <martin@ximian.com>
4005 * convert.cs (Convert.ExplicitReferenceConversion): When
4006 converting from an interface type to a class, unbox if the target
4007 type is a struct type. Fixes #47822.
4009 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4011 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
4014 2003-08-22 Martin Baulig <martin@ximian.com>
4016 * class.cs (TypeManager.DefineType): When defining a nested type,
4017 call DefineType() on our parent; fixes #47801.
4019 2003-08-22 Martin Baulig <martin@ximian.com>
4021 * class.cs (MethodData.Define): While checking if a method is an
4022 interface implementation, improve the test a bit more to fix #47654.
4024 2003-08-22 Martin Baulig <martin@ximian.com>
4026 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
4027 correctly; fixes #47722.
4029 2003-08-22 Martin Baulig <martin@ximian.com>
4031 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
4032 LocalVariableReference, ensure it's not read-only. Fixes #47536.
4034 * statement.cs (Fixed.DoResolve): Make all variables read-only.
4036 2003-08-22 Martin Baulig <martin@ximian.com>
4038 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
4039 can only be assigned in static constructors. Fixes #47161.
4041 2003-08-22 Martin Baulig <martin@ximian.com>
4043 Rewrote and improved the flow analysis code.
4045 * flowbranching.cs (FlowBranching): Make this class abstract.
4046 (FlowBranching.CreateBranching): New static function to create a
4048 (FlowBranchingBlock, FlowBranchingException): New classes.
4049 (FlowBranching.UsageVector.Type): New public readonly field.
4050 (FlowBranching.UsageVector.Breaks): Removed the setter.
4051 (FlowBranching.UsageVector.Returns): Removed the setter.
4052 (FlowBranching.UsageVector): Added Break(), Return(),
4053 NeverReachable() and Throw() methods to modify the reachability.
4054 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
4055 done by FlowBranching.Merge().
4056 (FlowBranching.UsageVector.MergeChild): New method; merges the
4057 merge result into the current vector.
4058 (FlowBranching.Merge): New abstract method to merge a branching.
4060 2003-08-12 Martin Baulig <martin@ximian.com>
4062 * expression.cs (Indirection.CacheTemporaries): Create the
4063 LocalTemporary with the pointer type, not its element type.
4065 2003-08-10 Miguel de Icaza <miguel@ximian.com>
4067 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
4068 token was a keyword or not.
4070 Add `error' options where an IDENTIFIER was expected; Provide
4071 CheckToken and CheckIdentifierToken convenience error reporting
4074 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
4076 * decl.cs: Rename `NamespaceEntry Namespace' public field into
4077 NameSpaceEntry NameSpaceEntry.
4079 (LookupInterfaceOrClass): Avoid creating a full qualified name
4080 from namespace and name: avoid doing lookups when we know the
4081 namespace is non-existant. Use new Tree.LookupByNamespace which
4082 looks up DeclSpaces based on their namespace, name pair.
4084 * driver.cs: Provide a new `parser verbose' to display the
4085 exception thrown during parsing. This is turned off by default
4086 now, so the output of a failure from mcs is more graceful.
4088 * namespace.cs: Track all the namespaces defined in a hashtable
4091 (IsNamespace): New method
4093 2003-08-09 Miguel de Icaza <miguel@ximian.com>
4095 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
4096 we know that we need to concatenate (full typename can never be
4101 * statement.cs: Use a bitfield; Do not initialize to null things
4102 which are done by the constructor by default.
4104 * cs-parser.jay: bug fix, parameter was 4, not 3.
4106 * expression.cs: Just use the property;
4108 * statement.cs: No need for GetVariableInfo method.
4110 2003-08-08 Martin Baulig <martin@ximian.com>
4112 * flowanalysis.cs (FlowReturns): This is now nested in the
4113 `FlowBranching' class.
4114 (MyBitVector): Moved this here from statement.cs.
4115 (FlowBranching.SiblingType): New enum type.
4116 (FlowBranching.CreateSibling): Added `SiblingType' argument.
4118 2003-08-07 Martin Baulig <martin@ximian.com>
4120 * flowanalysis.cs (FlowBranchingType): This is now nested in the
4121 `FlowBranching' class and called `BranchingType'.
4123 2003-08-07 Martin Baulig <martin@ximian.com>
4125 * flowanalysis.cs: Moved all the control flow analysis code into
4128 2003-08-07 Martin Baulig <martin@ximian.com>
4130 * assign.cs (Assign.DoResolve): `target' must either be an
4131 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
4134 2003-08-07 Miguel de Icaza <miguel@ximian.com>
4136 * expression.cs (BinaryMethod): This kind of expression is created by the
4137 Binary class if it determines that the operator has to be handled
4140 (BinaryDelegate): This kind of expression is created if we are
4141 dealing with a + or - operator on delegates.
4143 (Binary): remove method, argumetns, and DelegateOperator: when
4144 dealing with methods,
4146 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
4148 * statement.cs (Block): use bitfields for the three extra booleans
4149 we had in use. Remove unused topblock parameter.
4151 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
4153 * assign.cs: Drop extra unneeded tests.
4155 2003-08-06 Miguel de Icaza <miguel@ximian.com>
4157 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
4159 * statement.cs (Foreach): Use VariableStorage instead of
4162 * codegen.cs (VariableStorage): New class used by clients that
4163 require a variable stored: locals or fields for variables that
4164 need to live across yield.
4166 Maybe provide a convenience api for EmitThis+EmitLoad?
4168 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
4171 2003-08-05 Miguel de Icaza <miguel@ximian.com>
4173 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
4174 RemapParameterLValue): New methods that are used to turn a
4175 precomputed FieldInfo into an expression like this:
4179 The idea is to use this instead of making LocalVariableReference
4180 have more than one meaning.
4182 * cs-parser.jay: Add error production to BASE.
4184 * ecore.cs: Deal with TypeManager.GetField returning null, which
4185 is now a valid return value.
4187 (FieldExprNoAddress): New expression for Fields whose address can
4190 * expression.cs (LocalVariableReference): During the resolve
4191 phases, create new expressions if we are in a remapping context.
4192 Remove code that dealt with remapping here.
4194 (ParameterReference): same.
4196 (ProxyInstance): New expression, like the `This' expression, but
4197 it is born fully resolved. We know what we are doing, so remove
4198 the errors that are targeted to user-provided uses of `this'.
4200 * statement.cs (Foreach): our variable is now stored as an
4201 Expression; During resolution, follow the protocol, dont just
4202 assume it will return this.
4204 2003-08-06 Martin Baulig <martin@ximian.com>
4206 * support.cs (SeekableStreamReader.cs): New public class.
4208 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
4209 SeekableStreamReader instead of the normal StreamReader.
4211 2003-08-04 Martin Baulig <martin@ximian.com>
4213 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
4214 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
4215 deambiguate casts and delegate invocations.
4216 (parenthesized_expression): Use the new tokens to ensure this is
4217 not a cast of method invocation.
4219 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
4220 when reading a `)' and Deambiguate_CloseParens () was previously
4223 * expression.cs (ParenthesizedExpression): New class. This is
4224 just used for the CS0075 test.
4225 (Binary.DoResolve): Check for CS0075.
4227 2003-07-29 Ravi Pratap <ravi@ximian.com>
4229 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
4230 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
4231 reference comparison.
4233 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
4234 examine the ReturnType for equality - this is necessary in the
4235 cases of implicit and explicit operators whose signature also
4236 includes the return type.
4238 2003-07-26 Miguel de Icaza <miguel@ximian.com>
4240 * namespace.cs: Cache the result of the namespace computation,
4241 instead of computing it every time.
4243 2003-07-24 Miguel de Icaza <miguel@ximian.com>
4245 * decl.cs: Use a global arraylist that we reuse over invocations
4246 to avoid excesive memory consumption. Reduces memory usage on an
4247 mcs compile by one meg (45 average).
4249 * typemanager.cs (LookupTypeReflection): In .NET pointers are
4250 private, work around that.
4252 2003-07-23 Miguel de Icaza <miguel@ximian.com>
4254 * literal.cs (IntLiteral): Define Zero and One static literals.
4256 * cs-parser.jay (integer_literal): use static literals to reduce
4257 memory usage for the most used literals (0, 1 and -1). 211kb
4258 reduced in memory usage.
4260 Replace all calls to `new ArrayList' with `new
4261 ArrayList(4)' which is a good average number for most allocations,
4262 and also requires only 16 bytes of memory for its buffer by
4265 This reduced MCS memory usage in seven megabytes for the RSS after
4268 2003-07-28 Ravi Pratap <ravi@ximian.com>
4270 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
4271 handle params methods the correct way by forming only one
4272 applicable set with params and normal methods in them. Earlier we
4273 were looking at params methods only if we found no normal methods
4274 which was not the correct thing to do.
4276 (Invocation.BetterFunction): Take separate arguments indicating
4277 when candidate and the best method are params methods in their
4280 This fixes bugs #43367 and #46199.
4282 * attribute.cs: Documentation updates.
4284 (CheckAttribute): Rename to CheckAttributeTarget.
4285 (GetValidPlaces): Rename to GetValidTargets.
4287 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
4288 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
4292 2003-07-28 Martin Baulig <martin@ximian.com>
4294 * class.cs (TypeContainer.DefineMembers): Use the base type's full
4295 name when looking up the base class of a nested class. Fixes #46977.
4297 2003-07-26 Martin Baulig <martin@ximian.com>
4299 * expression.cs (Indexers.Indexer): New nested struct; contains
4300 getter, setter and the indexer's type.
4301 (Indexers.Properties): This is now an ArrayList of
4303 (IndexerAccess.DoResolveLValue): Correctly set the type if the
4304 indexer doesn't have any getters.
4306 * assign.cs (Assign.DoResolve): Also do the implicit conversions
4307 for embedded property and indexer assignments.
4309 2003-07-26 Martin Baulig <martin@ximian.com>
4311 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
4312 preprocessor directive is not the first non-whitespace character
4315 2003-07-26 Martin Baulig <martin@ximian.com>
4317 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
4318 namespace parsing, follow the spec more closely.
4320 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
4321 NamespaceEntry.Lookup().
4323 2003-07-25 Martin Baulig <martin@ximian.com>
4325 * MethodCore.cs (OverridesSomething): New public field; it's set
4326 from TypeContainer.DefineMembers if this method overrides
4327 something (which doesn't need to be a method). Fix #39462.
4329 2003-07-25 Ravi Pratap <ravi@ximian.com>
4331 * typemanager.cs (GetMembers): Ensure that the list of members is
4332 reversed. This keeps things in sync.
4334 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
4335 find an AttributeUsage attribute.
4337 * expression.cs (Invocation.OverloadResolve): Perform the check
4338 which disallows Invoke to be directly called on a Delegate.
4340 (Error_InvokeOnDelegate): Report error cs1533.
4342 2003-07-25 Martin Baulig <martin@ximian.com>
4344 * expression.cs (Indexers.GetIndexersForType): Only look in the
4345 interface hierarchy if the requested type is already an
4346 interface. Fixes #46788 while keeping #46502 fixed.
4348 2003-07-25 Martin Baulig <martin@ximian.com>
4350 * class.cs (TypeContainer.DefineMembers): Check whether all
4351 readonly fields have been assigned and report warning CS0649 if
4354 * statement.cs (LocalInfo.IsFixed): Always return true if this is
4357 2003-07-24 Ravi Pratap <ravi@ximian.com>
4359 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
4360 returned from GetMethods to make things consistent with the
4361 assumptions MCS makes about ordering of methods.
4363 This should comprehensively fix bug #45127 and it does :-)
4365 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
4366 ordering is actually reverse.
4368 * Clean up some debug messages I left lying around.
4370 * interface.cs (Populate*): Get rid of code which emits attributes
4371 since the stage in which we emit attributes is the 'Emit' stage,
4372 not the define stage.
4374 (Emit): Move attribute emission for interface members here.
4376 2003-07-22 Ravi Pratap <ravi@ximian.com>
4378 * expression.cs (Invocation.OverloadResolve): Follow the spec more
4379 closely: we eliminate methods in base types when we have an
4380 applicable method in a top-level type.
4382 Please see section 14.5.5.1 for an exact description of what goes
4385 This fixes bug #45127 and a host of other related to corlib compilation.
4387 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
4388 array is the method corresponding to the top-level type (this is
4389 because of the changes made to icall.c) so we change this
4392 (MethodGroupExpr.Name): This too.
4394 * typemanager.cs (GetElementType): New method which does the right
4395 thing when compiling corlib.
4397 * everywhere: Make use of the above in the relevant places.
4399 2003-07-22 Martin Baulig <martin@ximian.com>
4401 * cs-parser.jay (invocation_expression): Moved
4402 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
4403 `cast_expression', but create a InvocationOrCast which later
4404 resolves to either an Invocation or a Cast.
4406 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
4407 method; call this before EmitStatement() to make sure that this
4408 expression can be used as a statement.
4410 * expression.cs (InvocationOrCast): New class; resolves to either
4411 an Invocation or a Cast.
4413 * statement.cs (StatementExpression): Call ResolveStatement() on
4414 the ExpressionStatement before emitting it.
4416 2003-07-21 Martin Baulig <martin@ximian.com>
4418 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
4419 `ref' and `out' attributes match; fixes #46220.
4420 (MemberAccess.ResolveMemberAccess): You can't reference a type
4421 through an expression; fixes #33180.
4422 (Indexers.GetIndexersForType): Don't return the indexers from
4423 interfaces the class implements; fixes #46502.
4425 2003-07-21 Martin Baulig <martin@ximian.com>
4427 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
4428 CS0661 checks; fixes bug #30442.
4430 2003-07-21 Martin Baulig <martin@ximian.com>
4432 * decl.cs (AdditionResult): Added `Error'.
4434 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
4436 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
4437 makes cs0031.cs actually work.
4439 2003-07-20 Martin Baulig <martin@ximian.com>
4441 * namespace.cs: Fixed that bug which caused a crash when compiling
4444 2003-07-20 Miguel de Icaza <miguel@ximian.com>
4446 * typemanager.cs (LookupTypeReflection): Never expose types which
4447 are NotPublic, NestedPrivate, NestedAssembly, or
4448 NestedFamANDAssem. We used to return these, and later do a check
4449 that would report a meaningful error, but the problem is that we
4450 would not get the real match, if there was a name override.
4452 2003-07-18 Miguel de Icaza <miguel@ximian.com>
4454 * namespace.cs (Namespace, Name): Do not compute the namespace
4455 name dynamically, compute it in the constructor. This reduced
4456 memory usage by 1697 KB.
4458 * driver.cs: Use --pause to pause at the end.
4460 2003-07-17 Peter Williams <peter@newton.cx>
4462 * Makefile: Change the name of the test target so that it doesn't
4463 conflict with the recursive test target.
4465 2003-07-17 Miguel de Icaza <miguel@ximian.com>
4467 * expression.cs (LocalVariableReference.Emit, EmitAssign,
4468 AddressOf): Do not use EmitThis, that was wrong, use the actual
4471 2003-07-15 Miguel de Icaza <miguel@ximian.com>
4473 * class.cs (MethodData.Define): While checking if a method is an
4474 interface implementation, improve the test: If we are not public
4475 (use new test here: use the computed MethodAttributes directly,
4476 instead of the parsed modifier flags) check if the `implementing'
4477 method comes from an interface or not.
4479 * pending.cs (VerifyPendingMethods): Slightly better error
4482 * makefile: add test target that does the mcs bootstrap.
4484 2003-07-16 Ravi Pratap <ravi@ximian.com>
4486 * interface.cs (Define): Do nothing here since there are no
4487 members to populate etc. Move the attribute emission out of here
4488 since this was just totally the wrong place to put it. Attribute
4489 application happens during the 'Emit' phase, not in the 'Define'
4492 (Emit): Add this method and move the attribute emission here
4494 * rootcontext.cs (EmitCode): Call the Emit method on interface
4497 2003-07-14 Ravi Pratap M <ravi@ximian.com>
4499 * expression.cs (OverloadResolve): Report error only if Location
4500 is not 'Null' which means that there was a probe going on.
4502 2003-07-14 Martin Baulig <martin@ximian.com>
4504 * expression.cs (ConditionalLogicalOperator): New public class to
4505 implement user defined conditional logical operators.
4506 This is section 14.11.2 in the spec and bug #40505.
4508 2003-07-14 Martin Baulig <martin@ximian.com>
4510 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
4512 2003-07-14 Martin Baulig <martin@ximian.com>
4514 * codegen.cs (EmitContext.InFixedInitializer): New public field.
4516 * ecore.cs (IVariable.VerifyFixed): New interface method.
4518 * expression.cs (Unary.ResolveOperator): When resolving the `&'
4519 operator, check whether the variable is actually fixed. Fixes bug
4520 #36055. Set a variable definitely assigned when taking its
4521 address as required by the spec.
4523 * statement.cs (LocalInfo.IsFixed): New field.
4524 (LocalInfo.MakePinned): Set `IsFixed' to true.
4526 2003-07-14 Ravi Pratap M <ravi@ximian.com>
4528 * attribute.cs (Attribute.Resolve): While doing a Member lookup
4529 for .ctors, ensure that we only ask for members declared in the
4530 attribute type (BindingFlags.DeclaredOnly).
4534 * expression.cs (Error_WrongNumArguments): Report error 1501
4535 correctly the way CSC does.
4537 2003-07-13 Martin Baulig <martin@ximian.com>
4539 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
4540 lookup on the fully qualified name, to make things like "X.X" work
4541 where "X.X" is a fully qualified type name, but we also have a
4542 namespace "X" in the using list. Fixes #41975.
4544 2003-07-13 Martin Baulig <martin@ximian.com>
4546 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
4547 function. If we're a CompoundAssign, we need to create an embedded
4548 CompoundAssign, not an embedded Assign.
4549 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
4552 2003-07-13 Martin Baulig <martin@ximian.com>
4554 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
4555 work to fix bug #46088.
4557 2003-07-13 Ravi Pratap <ravi@ximian.com>
4559 * class.cs (Operator.Emit): Do not emit attributes here - it is
4560 taken care of by the Method class that we delegate too. This takes
4563 2003-07-10 Martin Baulig <martin@ximian.com>
4565 * expression.cs (TypeOfVoid): New class.
4566 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
4568 2003-07-10 Martin Baulig <martin@ximian.com>
4570 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
4573 2003-07-10 Martin Baulig <martin@ximian.com>
4575 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
4576 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
4578 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
4580 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
4582 2003-07-10 Martin Baulig <martin@ximian.com>
4584 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
4585 of decimal. Fixes #42850.
4587 NOTE: I also fixed the created byte blob, but this doesn't work on
4588 the MS runtime and csc never produces any byte blobs for decimal
4591 2003-07-10 Martin Baulig <martin@ximian.com>
4593 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
4594 structs; fixes #32068.
4595 (Block.AddChildVariableNames): Fixed #44302.
4597 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4599 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
4601 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4603 * attribute.cs: And this test is onger needed.
4605 2003-07-08 Martin Baulig <martin@ximian.com>
4607 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
4608 inaccessible types. Fixes #36313.
4610 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
4612 * namespace.cs (NamespaceEntry): Create implicit entries for all
4613 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
4614 implicit entries for N1.N2 and N1.
4616 2003-07-08 Martin Baulig <martin@ximian.com>
4618 Rewrote the handling of namespaces to fix a lot of the issues
4619 wrt. `using' aliases etc.
4621 * namespace.cs (Namespace): Splitted this class into a
4622 per-assembly `Namespace' and a per-file `NamespaceEntry'.
4624 * typemanager.cs (TypeManager.IsNamespace): Removed.
4625 (TypeManager.ComputeNamespaces): Only compute namespaces from
4626 loaded assemblies here, not the namespaces from the assembly we're
4627 currently compiling.
4629 2003-07-08 Martin Baulig <martin@ximian.com>
4631 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
4633 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4635 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
4638 I thought about the memory savings here, but LookupTypeReflection
4639 is used under already very constrained scenarios. Compiling
4640 corlib or mcs only exposes one hit, so it would not really reduce
4641 any memory consumption.
4643 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4645 * typemanager.cs: fixes bug #45889 by only adding public types from
4646 other assemblies to the list of known types.
4648 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4650 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
4651 on the type we resolved.
4653 2003-07-05 Martin Baulig <martin@ximian.com>
4655 * pending.cs (PendingImplementation.ParentImplements): Don't
4656 create the proxy if the parent is abstract.
4658 * class.cs (TypeContainer.DefineIndexers): Process explicit
4659 interface implementations first. Fixes #37714.
4661 2003-07-04 Miguel de Icaza <miguel@ximian.com>
4663 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
4664 defined recursively; but since we modify the input parameters
4665 (left is set to `this' temporarily), we reset this value if the
4666 left_is_explicit is false, which gives the original semantics to
4669 * literal.cs (NullPointer): new class used to represent a null
4670 literal in a pointer context.
4672 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
4673 type is a pointer, use a NullPointer object instead of a
4674 NullLiteral. Closes 43687
4676 (ExplicitConversion): Convert pointer values using
4677 the conv opcode to the proper type.
4679 * ecore.cs (New): change ValueTypeVariable property into a method,
4680 that returns whether the valuetype is suitable for being used.
4682 * expression.cs (Binary.DoNumericPromotions): Only return if we
4683 the int constant was a valid uint, and we can return both left and
4684 right as uints. If not, we continue processing, to trigger the
4685 type conversion. This fixes 39018.
4687 * statement.cs (Block.EmitMeta): During constant resolution, set
4688 the CurrentBlock property on the emitcontext, so that we resolve
4689 constants propertly.
4691 2003-07-02 Martin Baulig <martin@ximian.com>
4693 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
4694 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
4696 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
4697 than emitting it here.
4699 * statement.cs: Fixed some more flow analysis bugs.
4701 2003-07-02 Martin Baulig <martin@ximian.com>
4703 * class.cs (MethodData.Define): When implementing interface
4704 methods, set Final unless we're Virtual.
4706 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
4707 check work for interface methods.
4709 2003-07-01 Martin Baulig <martin@ximian.com>
4711 * ecore.cs (EmitContext.This): Replaced this property with a
4712 GetThis() method which takes a Location argument. This ensures
4713 that we get the correct error location for a CS0188.
4715 2003-07-01 Miguel de Icaza <miguel@ximian.com>
4717 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
4718 ImplicitStandardConversion.
4720 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
4722 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
4724 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
4727 2003-06-30 Miguel de Icaza <miguel@ximian.com>
4729 * class.cs (Constructor.Define): Turn off initlocals for unsafe
4732 (MethodData.Define): Turn off initlocals for unsafe methods.
4734 2003-06-29 Miguel de Icaza <miguel@ximian.com>
4736 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
4737 complete; Fixes #37521.
4739 * delegate.cs: Use Modifiers.TypeAttr to compute the
4740 TypeAttributes, instead of rolling our own. This makes the flags
4741 correct for the delegates.
4743 2003-06-28 Miguel de Icaza <miguel@ximian.com>
4745 * class.cs (Constructor.Define): Set the private flag for static
4746 constructors as well.
4748 * cs-parser.jay (statement_expression): Set the return value to
4749 null, to avoid a crash when we catch an error.
4751 2003-06-24 Miguel de Icaza <miguel@ximian.com>
4753 * cs-parser.jay: Applied patch from Jackson that adds support for
4754 extern and unsafe modifiers to destructor declarations.
4756 * expression.cs: Report error 21 if the user is trying to index a
4759 * driver.cs: Add an error message, suggested by the bug report.
4761 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
4762 if we do not have a ": this ()" constructor initializer. Fixes 45149
4764 2003-06-14 Miguel de Icaza <miguel@ximian.com>
4766 * namespace.cs: Add some information to reduce FAQs.
4768 2003-06-13 Miguel de Icaza <miguel@ximian.com>
4770 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
4771 underlying enumeration types. Fixes #43915.
4773 * expression.cs: Treat ushort/short as legal values to be used in
4776 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
4778 * delegate.cs: transfer custom attributes for paramenters from
4779 the delegate declaration to Invoke and BeginInvoke.
4781 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
4783 * attribute.cs: handle custom marshalers and emit marshal info
4786 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
4788 * makefile.gnu: Added anonymous.cs to the compiler sources.
4790 2003-05-28 Miguel de Icaza <miguel@ximian.com>
4792 * iterators.cs: Change the name of the proxy class to include two
4795 * cs-parser.jay: Update grammar to include anonymous methods.
4797 * anonymous.cs: new file.
4799 2003-05-27 Miguel de Icaza <miguel@ximian.com>
4801 * class.cs (Field.Define): Add missing test for pointers and
4804 2003-05-27 Ravi Pratap <ravi@ximian.com>
4806 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
4807 we use the stobj opcode.
4809 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
4810 since it wasn't the correct fix.
4812 It still is puzzling that we are required to use stobj for IntPtr
4813 which seems to be a ValueType.
4815 2003-05-26 Miguel de Icaza <miguel@ximian.com>
4817 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
4818 during regular simple name resolution. Now, the trick is that
4819 instead of returning for processing the simplename, we do a
4820 TypeManager.LookupType (ie, a rooted lookup as opposed to a
4821 contextual lookup type). If a match is found, return that, if
4822 not, return for further composition.
4824 This fixes long-standing 30485.
4826 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
4827 using the address to initialize an object, do an Stobj instead of
4828 using the regular Stelem.
4830 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
4831 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
4832 Because if we are a BaseIndexerAccess that value will be true.
4835 * statement.cs (GotoCase.Resolve): Return after reporting an
4836 error, do not attempt to continue.
4838 * expression.cs (PointerArithmetic.Emit): If our operand is a
4839 long, convert our constants to match the operand before
4840 multiplying. Convert to I type before adding. Fixes 43670.
4842 2003-05-14 Ravi Pratap <ravi@ximian.com>
4844 * enum.cs (ImplicitConversionExists) : Rename to
4845 ImplicitEnumConversionExists to remove ambiguity.
4847 * ecore.cs (NullCast): New type of cast expression class which
4848 basically is very similar to EmptyCast with the difference being
4849 it still is a constant since it is used only to cast a null to
4853 * convert.cs (ImplicitReferenceConversion): When casting a null
4854 literal, we return a NullCast.
4856 * literal.cs (NullLiteralTyped): Remove - I don't see why this
4857 should be around anymore.
4859 The renaming (reported was slightly wrong). Corrections:
4861 ConvertImplicitStandard -> ImplicitConversionStandard
4862 ConvertExplicitStandard -> ExplicitConversionStandard
4864 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
4865 before passing them in !
4867 * convert.cs (ImplicitConversionStandard): When comparing for
4868 equal expr and target types, ensure that expr is not a
4871 In general, we must not be checking (expr_type ==
4872 target_type) in the top level conversion methods
4873 (ImplicitConversion, ExplicitConversion etc). This checking is
4874 done in the methods that they delegate to.
4876 2003-05-20 Miguel de Icaza <miguel@ximian.com>
4878 * convert.cs: Move Error_CannotConvertType,
4879 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
4880 ImplicitNumericConversion, ImplicitConversionExists,
4881 ImplicitUserConversionExists, StandardConversionExists,
4882 FindMostEncompassedType, FindMostSpecificSource,
4883 FindMostSpecificTarget, ImplicitUserConversion,
4884 ExplicitUserConversion, GetConversionOperators,
4885 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
4886 TryImplicitIntConversion, Error_CannotConvertImplicit,
4887 ConvertImplicitRequired, ConvertNumericExplicit,
4888 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
4889 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
4892 Perform the following renames:
4894 StandardConversionExists -> ImplicitStandardConversionExists
4895 ConvertImplicit -> ImplicitConversion
4896 ConvertImplicitStandard -> ImplicitStandardConversion
4897 TryImplicitIntConversion -> ImplicitIntConversion
4898 ConvertImplicitRequired -> ImplicitConversionRequired
4899 ConvertNumericExplicit -> ExplicitNumericConversion
4900 ConvertReferenceExplicit -> ExplicitReferenceConversion
4901 ConvertExplicit -> ExplicitConversion
4902 ConvertExplicitStandard -> ExplicitStandardConversion
4904 2003-05-19 Martin Baulig <martin@ximian.com>
4906 * statement.cs (TypeInfo.StructInfo): Made this type protected.
4907 (TypeInfo): Added support for structs having structs as fields.
4909 * ecore.cs (FieldExpr): Implement IVariable.
4910 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
4911 VariableInfo for the field.
4913 2003-05-18 Martin Baulig <martin@ximian.com>
4915 * expression.cs (This.DoResolve): Report a CS0027 if we're
4916 emitting a field initializer.
4918 2003-05-18 Martin Baulig <martin@ximian.com>
4920 * expression.cs (This.ResolveBase): New public function.
4921 (This.DoResolve): Check for CS0188.
4923 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
4926 * ecore.cs (MethodGroupExpr.DoResolve): Set the
4927 `instance_expression' to null if we don't have any non-static
4930 2003-05-18 Martin Baulig <martin@ximian.com>
4932 Reworked the way how local variables and parameters are handled by
4933 the flow analysis code.
4935 * statement.cs (TypeInfo, VariableMap): New public classes.
4936 (VariableInfo): New public class. This is now responsible for
4937 checking whether a variable has been assigned. It is used for
4938 parameters and local variables.
4939 (Block.EmitMeta): Take the InternalParameters as argument; compute
4940 the layout of the flow vectors here.
4941 (Block.LocalMap, Block.ParameterMap): New public properties.
4942 (FlowBranching): The .ctor doesn't get the InternalParameters
4943 anymore since Block.EmitMeta() now computes the layout of the flow
4945 (MyStructInfo): This class is now known as `StructInfo' and nested
4946 in `TypeInfo'; we don't access this directly anymore.
4948 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
4949 property and removed IsAssigned(), IsFieldAssigned(),
4950 SetAssigned() and SetFieldAssigned(); we now call them on the
4951 VariableInfo so we don't need to duplicate this code everywhere.
4953 * expression.cs (ParameterReference): Added `Block block' argument
4955 (LocalVariableReference, ParameterReference, This): The new
4956 VariableInfo class is now responsible for all the definite
4959 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
4960 IsParameterAssigned, SetParameterAssigned): Removed.
4962 2003-05-18 Martin Baulig <martin@ximian.com>
4964 * typemanager.cs (InitCoreTypes): Try calling
4965 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
4966 the 3-args-version. Corlib now also needs our `void_type'.
4967 (GetMethod): Added overloaded version which takes an optional
4968 `bool report_errors' to allow lookups of optional methods.
4970 2003-05-12 Martin Baulig <martin@ximian.com>
4972 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
4973 only used for locals and not for parameters.
4975 2003-05-12 Miguel de Icaza <miguel@ximian.com>
4977 * support.cs (InternalParameters.ParameterType): Return the
4978 ExternalType of the parameter.
4980 * parameter.cs (Parameter.ExternalType): drop the two arguments,
4983 2003-05-11 Miguel de Icaza <miguel@ximian.com>
4985 * class.cs (MethodData.Define): Do not set the `newslot' on
4986 interface members, if they are also flagged as "override".
4988 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
4989 better code for ++i and i++. This only works for static fields
4990 and local variables.
4992 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
4993 want to pull the DeclSpace out of the builder_to_declspace instead
4994 of the TypeBuilder (like in TypeContainer.FindMembers).
4996 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
4997 instead of LookupTypeContainer. Fixes the crash on .NET for
4998 looking up interface members.
5000 * const.cs: Create our own emit context during the Definition
5001 stage, so that constants are evaluated in the proper context, when
5002 a recursive definition happens.
5004 2003-05-11 Martin Baulig <martin@ximian.com>
5006 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
5007 new block for a switch section.
5008 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
5009 the adding/lookup in the switch block. Fixes #39828.
5011 2003-05-09 Miguel de Icaza <miguel@ximian.com>
5013 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
5014 functionality: I needed to convert the data after I had performed
5015 the add/sub operation into the operands type size.
5017 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
5018 pass the type for the box operation, otherwise the resulting
5019 object would have been of type object.
5021 (BoxedCast): Add constructor to specify the type to box as.
5023 2003-05-07 Miguel de Icaza <miguel@ximian.com>
5025 * iterators.cs: I was reusing the `count' variable inadvertently,
5026 take steps to not allow this to happen.
5028 2003-05-06 Miguel de Icaza <miguel@ximian.com>
5030 * attribute.cs (Attribute.Resolve): Params attributes are encoded
5031 by creating an array at the point where the params starts and
5032 putting all those arguments there, then adjusting the size of the
5035 2003-05-05 Miguel de Icaza <miguel@ximian.com>
5037 * expression.cs (New.AddressOf): Implement interface
5038 IMemoryLocation. This is used when the `new' operator is used in
5039 the context of an invocation to a method on a value type.
5041 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
5044 * namespace.cs: Also check the using aliases here.
5046 * driver.cs: Move the test for using validity after the types have
5047 been entered, so we do a single pass that also includes the using
5050 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
5051 in the regular case. CreateSiblingForFinally is doing extra
5054 * attribute.cs (GetAttributeArgumentExpression): Store the result
5055 on an out value, and use the return value to indicate failure
5056 instead of using null (which is a valid return for Constant.GetValue).
5058 * statement.cs: Perform the analysis flow for the increment
5059 portion after the statement, because this will be the real flow of
5060 execution. Fixes #42385
5062 * codegen.cs (EmitContext.EmitArgument,
5063 EmitContext.EmitStoreArgument): New helper functions when the
5064 RemapToProxy flag is set.
5066 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
5069 Add support for remapping parameters.
5071 * iterators.cs: Propagate parameter values; Store parameter
5072 values in the proxy classes.
5074 2003-05-04 Miguel de Icaza <miguel@ximian.com>
5076 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
5077 need a proxy reference; I do not know what I was thinking
5079 * cs-parser.jay (constructor_initializer): catch another error,
5080 and display nice message.
5082 (field_declaration): catch void field declaration
5083 to flag a better error.
5085 * class.cs (MemberBase.CheckBase): Report an error instead of a
5086 warning if a new protected member is declared in a struct.
5087 (Field.Define): catch the error of readonly/volatile.
5089 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
5091 (FieldExpr.AddressOf): ditto. Catch error where the address of a
5092 volatile variable is taken
5094 2003-05-02 Miguel de Icaza <miguel@ximian.com>
5096 * statement.cs (Fixed.Resolve): Report an error if we are not in
5099 2003-05-01 Miguel de Icaza <miguel@ximian.com>
5101 * typemanager.cs: reuse the code that handles type clashes for
5102 delegates and enumerations.
5104 * class.cs (Report28): Always report.
5106 * expression.cs (EncodeAsAttribute): Allow nulls here.
5108 2003-04-28 Miguel de Icaza <miguel@ximian.com>
5110 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
5111 the functionality for testing whether an expression is valid for
5112 an attribute here. Also handle the case of arrays of elements
5115 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
5116 encoding a linear array into an array of objects that are suitable
5117 to be passed to an CustomAttributeBuilder.
5119 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
5121 * ecore.cs: (FieldExpr): Handle field remapping here.
5123 * iteratators.cs: Pass the instance variable (if the method is an
5124 instance method) to the constructors, so we can access the field
5125 variables on the class.
5127 TODO: Test this with structs. I think the THIS variable on
5128 structs might have to be a pointer, and not a refenrece
5130 2003-04-27 Miguel de Icaza <miguel@ximian.com>
5132 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
5133 local variables to fields in a proxy class.
5135 * iterators.cs (PopulateProxy): Rename our internal fields to
5137 Create a <THIS> field if we are an instance method, so we can
5138 reference our parent container variables.
5139 (MapVariable): Called back from the EmitContext code to enter a
5140 new variable to field mapping into the proxy class (we just create
5144 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
5145 for using the remapped locals to fields.
5147 I placed the code here, because that gives the same semantics to
5148 local variables, and only changes the Emit code.
5150 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
5151 statements inside iterators.
5152 (VariableInfo): Add a FieldBuilder for the cases when we are
5153 remapping local variables to fields in a proxy class
5155 * ecore.cs (SimpleNameResolve): Avoid testing two times for
5156 current_block != null.
5158 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
5159 not cope with strings, as it has been moved to the
5160 TableSwitchEmit. Fixed bug in switch generation.
5162 * expression.cs (New.DoResolve): Provide more context for the user
5163 when reporting an error.
5165 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
5168 * expression.cs (MemberAccess.DoResolve): When we get a type back,
5169 check the permissions for it. Note than in a type-resolution
5170 context the check was already present in DeclSpace.ResolveType,
5171 but was missing from the MemberAccess.
5173 (ArrayCreation.CheckIndices): warn if the user has
5174 more nested levels of expressions, but there are no more
5175 dimensions specified. Avoids crash on bug 41906.
5177 2003-04-26 Miguel de Icaza <miguel@ximian.com>
5179 * statement.cs (Block): replace Implicit bool, for a generic
5181 New flag: `Unchecked'. This is used during the EmitMeta phase
5182 (which is out-of-line with the regular Resolve/Emit process for a
5183 statement, as this is done ahead of time, but still gets a chance
5184 to call constant resolve).
5186 (Block.Flags): new enum for adding a new flag.
5188 (Block.EmitMeta): track the state of unchecked.
5190 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
5191 to enable constant resolution to work there as well.
5193 2003-04-22 Miguel de Icaza <miguel@ximian.com>
5195 * typemanager.cs (ienumerable_type): Also look up
5196 System.Collections.IEnumerable.
5198 2003-04-21 Miguel de Icaza <miguel@ximian.com>
5200 TODO: Test more than one conditional per method.
5202 * class.cs (Indexer.Define): Report the location where the user is
5203 referencing the unsupported feature.
5205 (MethodData): Overload the use of `conditionals' to
5206 minimize the creation of needless ArrayLists. This saves roughly
5207 212kb on my machine.
5209 (Method): Implement the new IIteratorContainer interface.
5210 (Method.SetYields): Implement the method by setting the ModFlags
5211 to contain METHOD_YIELDS.
5213 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
5214 which just got set to null.
5216 * iterators.cs: New file.
5218 (Yield, YieldBreak): New statements.
5220 * statement.cs (Return.Resolve): Flag an error if we are used in
5223 * codegen.cs (InIterator): New flag set if the code is being
5224 compiled in an iterator method.
5226 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
5227 internal modifier, and we just use it to avoid adding extra
5228 fields, as this is seldom used.
5230 * cs-parser.jay: Add yield_statement (yield and yield break).
5232 * driver.cs: New flag -v2 to turn on version 2 features.
5234 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
5235 hashtable when v2 is enabled.
5237 2003-04-20 Miguel de Icaza <miguel@ximian.com>
5239 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
5240 there is already a namespace defined with this name.
5242 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
5243 people upgraded their corlibs.
5245 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
5246 always use fully qualified types, no need to use the compiler
5249 (TypeManager.IsNamespace): Use binarysearch.
5251 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
5252 AddDelegate): I did not quite use the new IsValid API properly: I
5253 have to pass the short-name and the fullname. I was passing only
5254 the basename instead of the fullname sometimes.
5256 (TypeContainer.DefineType): call NamespaceClash.
5258 * interface.cs (Interface.DefineType): use NamespaceClash before
5261 * delegate.cs (Delegate.DefineType): use NamespaceClash before
5264 * enum.cs: (Enum.DefineType): use NamespaceClash before
5267 * typemanager.cs (: 3-line patch that gives us some tasty 11%
5268 speed increase. First, use the negative_hits cache when we get a
5269 negative. Second, add the type with its full original name
5270 instead of the new . and + encoded name (reflection uses + to
5271 separate type from a nested type). Use LookupTypeReflection
5272 directly which bypasses the type->name hashtable (that we already
5273 know does not contain the type.
5275 * decl.cs (DeclSpace.ResolveTypeExpr): track the
5276 location/container type.
5278 * driver.cs: When passing utf8, use directly the UTF8Encoding.
5280 2003-04-19 Miguel de Icaza <miguel@ximian.com>
5282 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
5284 * delegate.cs (NewDelegate.Resolve): Test whether an instance
5285 method is being referenced in the method group from a static
5286 context, and report error 120 if so.
5288 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
5291 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
5292 is created, we create the A namespace).
5294 * cs-parser.jay: A namespace also introduces a DeclarationFound.
5297 2003-04-18 Miguel de Icaza <miguel@ximian.com>
5299 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
5300 invocation to ModuleBuilder.GetType with the same values will
5301 return a new type instance, so we need to cache its return
5304 * expression.cs (Binary.ResolveOperator): Only allow the compare
5305 operators on enums if they are of the same type.
5307 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
5308 types of ValueType on their own case. Before we were giving them
5309 the same treatment as objects.
5311 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
5312 fullname. Short name is used to compare against container name.
5313 Fullname is used to check against defined namespace names.
5315 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
5316 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
5318 (Method.CheckBase): Call parent.
5319 (MemberBase.CheckBase): Check for protected members on sealed
5321 (PropertyBase.CheckBase): Call parent.
5322 (Field.Define): Call parent.
5324 * report.cs: Negative error codes are now mapped to 8000 - code,
5325 so that the display is render more nicely.
5327 * typemanager.cs: Do not use try/catch, instead report a regular
5330 (GetPointerType, GetReferenceType): These methods provide
5331 mechanisms to obtain the T* and T& from a T. We had the code
5332 previously scattered around the code base, and it also used
5333 TypeManager.LookupType that would go through plenty of caches.
5334 This one goes directly to the type source.
5336 In some places we did the Type.GetType followed by
5337 ModuleBuilder.GetType, but not in others, so this unifies the
5340 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
5341 statements now that we have namespace information.
5343 * typemanager.cs (IsNamespace): New method, returns whether the
5344 string presented is a namespace or not.
5346 (ComputeNamespaces): New public entry point, computes the list of
5347 available namespaces, using the GetNamespaces API call in Mono, or
5348 the slower version in MS.NET.
5350 Now before we start the semantic analysis phase, we have a
5351 complete list of namespaces including everything that the user has
5354 Deleted old code to cache namespaces in .nsc files.
5356 2003-04-17 Miguel de Icaza <miguel@ximian.com>
5358 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
5359 class/struct location definition Location for the implicit
5360 constructor location.
5362 (Operator.Define): Use the location of the operator for the
5363 implicit Method definition.
5365 (Constructor.Emit): use the constructor location for the implicit
5366 base initializer constructor.
5368 * ecore.cs: Remove ITypeExpression. This interface is now gone,
5369 and the Expression class now contains two new methods:
5371 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
5372 isolate type lookup from the rest of the resolution process.
5374 Since we use Expressions to hold type definitions due to the way
5375 we parse the input we have historically overloaded Resolve to
5376 perform the Type lookups if a special flag is passed. Now this is
5377 eliminated and two methods take their place.
5379 The differences in the two methods between xStep and xTerminal is
5380 that xStep is involved in our current lookup system that uses
5381 SimpleNames to compose a name, while xTerminal is used just to
5382 catch the case where the simplename lookup failed.
5384 2003-04-16 Miguel de Icaza <miguel@ximian.com>
5386 * expression.cs (ResolveMemberAccess): Remove redundant code.
5387 TypeExpr expressions are always born fully resolved.
5389 * interface.cs (PopulateMethod): Do not lookup the types twice.
5390 We were doing it once during SemanticAnalysis and once during
5393 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
5394 in local variable type definitions, were being returned as a
5395 SimpleName (we decomposed everything into a string), that is
5396 because primary_expression was being used instead of a type in the
5397 grammar (reduce/reduce conflicts).
5399 The part that was wrong is that we converted the expression into a
5400 string (an oversimplification in one hand, compounded with primary
5401 expressions doing string concatenation).
5407 Would return "A.B.C[]" as a SimpleName. This stopped things like
5408 using clauses from working on this particular context. And a type
5409 was being matched directly against "A.B.C[]".
5411 We now use the correct approach, and allow for ComposedCast to be
5412 part of the unary expression. So the "A.B.C []" become a composed
5413 cast of "A.B.C" (as a nested group of MemberAccess with a
5414 SimpleName at the end) plus the rank composition "[]".
5418 2003-04-10 Miguel de Icaza <miguel@ximian.com>
5420 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
5421 for the access level checking.
5423 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
5424 `TypeContainer container', because I kept getting confused when I
5425 was debugging this code.
5427 * expression.cs (Indexers): Instead of tracking getters/setters,
5428 we now track them in parallel. We create one arraylist less, but
5429 most importantly it is possible now for the LValue code to find a
5430 matching get for a set.
5432 (IndexerAccess.DoResolveLValue): Update the code.
5433 GetIndexersForType has been modified already to extract all the
5434 indexers from a type. The code assumed it did not.
5436 Also make the code set the correct return type for the indexer.
5437 This was fixed a long time ago for properties, but was missing for
5438 indexers. It used to be void_type.
5440 (Binary.Emit): Test first for doubles instead of
5441 floats, as they are more common.
5443 (Binary.EmitBranchable): Use the .un version of the branch opcodes
5444 when dealing with floats and the <=, >= operators. This fixes bug
5447 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
5448 to load the array value by emitting a load on the foreach variable
5449 type. This was incorrect.
5451 We now emit the code to load an element using the the array
5452 variable type, and then we emit the conversion operator.
5456 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
5458 * attribute.cs: Avoid allocation of ArrayLists in the common case.
5460 2003-04-09 Miguel de Icaza <miguel@ximian.com>
5462 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
5463 test for protection before we test for signatures.
5465 (MethodSignature.ToString): implement.
5467 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
5468 to the case where we reduced into a LongConstant.
5470 * decl.cs (CheckAccessLevel): If the type is an array, we can not
5471 depend on whether the information is acurrate, because the
5472 Microsoft runtime will always claim that the array type is public,
5473 regardless of the real state.
5475 If the type is a pointer, another problem happens: the type is
5476 reported as non-public in Microsoft.
5478 In both cases we have to call CheckAccessLevel recursively with
5479 the underlying type as the argument to be tested.
5481 2003-04-08 Miguel de Icaza <miguel@ximian.com>
5483 * assign.cs (Assign.Emit): If we are dealing with a compound
5484 assignment expression, we should use the code path that stores the
5485 intermediate result in a temporary value. This fixes #40903.
5487 *expression.cs (Indirection.ToString): Provide ToString method for
5490 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
5492 * class.cs: Null out fields holding references to Block objects so
5493 they can be garbage collected.
5495 * expression.cs (OverloadResolve): Remove unused local.
5497 2003-04-07 Martin Baulig <martin@ximian.com>
5499 * codegen.cs (EmitContext.CurrentFile): New public field.
5500 (EmitContext.Mark): Use the CurrentFile to check whether the
5501 location is in the correct file.
5502 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
5504 2003-04-07 Martin Baulig <martin@ximian.com>
5506 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
5508 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
5509 location. [FIXME: The location argument which gets passed to this
5510 method is sometimes wrong!]
5512 2003-04-07 Nick Drochak <ndrochak@gol.com>
5514 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
5516 2003-04-07 Miguel de Icaza <miguel@ximian.com>
5518 * expression.cs (Indirection.EmitAssign): We were using the
5519 temporary, but returning immediately instead of continuing the
5522 2003-04-06 Martin Baulig <martin@ximian.com>
5524 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
5525 if it's a nested child, but also deriving from the outer class.
5528 * typemanager.cs (IsNestedChildOf): Make this work if it's a
5529 nested child, but also deriving from the outer class. See
5531 (FilterWithClosure): We may access private members of the outer
5532 class if we're a nested child and deriving from the outer class.
5533 (RealMemberLookup): Only set `closure_private_ok' if the
5534 `original_bf' contained BindingFlags.NonPublic.
5536 2003-04-05 Martin Baulig <martin@ximian.com>
5538 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
5540 2003-04-02 Miguel de Icaza <miguel@ximian.com>
5542 * class.cs (Event.Define): Do not allow abstract events to have
5545 2003-04-01 Miguel de Icaza <miguel@ximian.com>
5547 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
5548 block in event declarations.
5550 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
5551 value type, get its address.
5553 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
5554 leaving a class on the stack instead of a boolean value (int
5555 0/1). Change the code so we compare against null, and then the
5556 result against zero.
5558 * class.cs (TypeContainer.GetClassBases): We were checking for the
5559 parent class being sealed too late.
5561 * expression.cs (Binary.Emit): For <= and >= when dealing with
5562 floating point values, use cgt.un and clt.un instead of cgt and
5565 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
5567 * statement.cs: Apply the same optimization as MS: skip the
5568 GetEnumerator returning an IEnumerator, and use the one returning a
5569 CharEnumerator instead. This allows us to avoid the try-finally block
5572 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
5574 * cs-parser.jay: Attributes cannot be applied to
5575 namespaces. Fixes #40473
5577 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5580 (Add*): check if the name is valid using the full name for constants,
5581 fields, properties and events.
5583 2003-03-28 Miguel de Icaza <miguel@ximian.com>
5585 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
5586 char constants to be part of the enumeration.
5588 * expression.cs (Conditional.DoResolve): Add support for operator
5589 true. Implements the missing functionality from 14.12
5591 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
5592 operator true/false as required by the spec.
5594 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
5595 implicit conversion to boolean.
5597 * statement.cs (Statement.ResolveBoolean): A boolean expression is
5598 also one where the type implements `operator true'.
5600 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
5601 get an expression that will invoke operator true based on an
5604 (GetConversionOperators): Removed the hack that called op_True
5607 (Expression.ResolveBoolean): Move this from Statement.
5609 2003-03-17 Miguel de Icaza <miguel@ximian.com>
5611 * ecore.cs (FieldExpr): do not allow initialization of initonly
5612 fields on derived classes
5614 2003-03-13 Martin Baulig <martin@ximian.com>
5616 * statement.cs (Block.Emit): Call ig.BeginScope() and
5617 ig.EndScope() when compiling with debugging info; call
5618 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
5620 2003-03-08 Miguel de Icaza <miguel@ximian.com>
5622 * expression.cs (Indexers): Do not construct immediately, allow
5623 for new members to be appended as we go. Fixes 38143
5625 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5627 * expression.cs: save/restore context when resolving an unchecked
5630 2003-03-05 Miguel de Icaza <miguel@ximian.com>
5632 * cfold.cs: Catch division by zero in modulus operator during
5635 2003-03-03 Miguel de Icaza <miguel@ximian.com>
5637 * interface.cs (Interface.DefineMembers): Avoid defining members
5640 2003-02-27 Miguel de Icaza <miguel@ximian.com>
5642 * driver.cs: handle the +/- options for -noconfig
5644 * statement.cs (Unckeched.Resolve): Also track the state of
5645 unchecked in the Resolve phase.
5647 2003-02-27 Martin Baulig <martin@ximian.com>
5649 * ecore.cs (Expression.MemberLookup): Don't create a
5650 MethodGroupExpr for something which is not a method. Fixes #38291.
5652 2003-02-25 Miguel de Icaza <miguel@ximian.com>
5654 * class.cs (MemberBase.CheckParameters): Also check that the type
5655 is unmanaged if it is a pointer.
5657 * expression.cs (SizeOf.Resolve): Add location information.
5659 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
5660 a managed type is declared.
5662 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
5663 parameter modifiers as well. Fixes bug 38606
5665 * class.cs: Very sad. Am backing out the speed up changes
5666 introduced by the ArrayList -> Array in the TypeContainer, as they
5667 were not actually that much faster, and introduced a bug (no error
5668 reports on duplicated methods).
5670 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
5671 source first, this will guarantee that we have a valid expression
5672 before calling in lower levels functions that will require a
5673 resolved object. Then use this original_source in the
5674 target.ResolveLValue instead of the original source that was
5677 Another change. Use target.Resolve instead of LValueResolve.
5678 Although we are resolving for LValues, we will let the Assign code
5679 take care of that (it will be called again from Resolve). This
5680 basically allows code like this:
5682 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
5683 class Y { void A (X x) { x [0] += o; }
5685 The problem was that the indexer was trying to resolve for
5686 set_Item (idx, object o) and never finding one. The real set_Item
5687 was set_Item (idx, X). By delaying the process we get the right
5692 2003-02-23 Martin Baulig <martin@ximian.com>
5694 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
5695 while calling DoEmit ().
5697 * codegen.cs (EmitContext.Mark): Don't mark locations in other
5698 source files; if you use the #line directive inside a method, the
5699 compiler stops emitting line numbers for the debugger until it
5700 reaches the end of the method or another #line directive which
5701 restores the original file.
5703 2003-02-23 Martin Baulig <martin@ximian.com>
5705 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
5707 2003-02-23 Martin Baulig <martin@ximian.com>
5709 * statement.cs (Block.AddChildVariableNames): We need to call this
5710 recursively, not just for our immediate children.
5712 2003-02-23 Martin Baulig <martin@ximian.com>
5714 * class.cs (Event.Define): Always make the field private, like csc does.
5716 * typemanager.cs (TypeManager.RealMemberLookup): Make events
5717 actually work, fixes bug #37521.
5719 2003-02-23 Miguel de Icaza <miguel@ximian.com>
5721 * delegate.cs: When creating the various temporary "Parameters"
5722 classes, make sure that we call the ComputeAndDefineParameterTypes
5723 on those new parameters (just like we do with the formal ones), to
5724 allow them to be resolved in the context of the DeclSpace.
5726 This fixes the bug that Dick observed in Bugzilla #38530.
5728 2003-02-22 Miguel de Icaza <miguel@ximian.com>
5730 * expression.cs (ResolveMemberAccess): When resolving a constant,
5731 do not attempt to pull a constant if the value was not able to
5732 generate a valid constant.
5734 * const.cs (LookupConstantValue): Do not report more errors than required.
5736 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5738 * expression.cs: fixes bug #38328.
5740 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5742 * class.cs: Changed all the various members that can be part of a
5743 class from being an ArrayList to be an Array of the right type.
5744 During the DefineType type_list, interface_list, delegate_list and
5745 enum_list are turned into types, interfaces, delegates and enums
5748 And during the member population, indexer_list, event_list,
5749 constant_list, field_list, instance_constructor_list, method_list,
5750 operator_list and property_list are turned into their real arrays.
5752 Although we could probably perform this operation earlier, for
5753 good error reporting we need to keep the lists and remove the
5754 lists for longer than required.
5756 This optimization was triggered by Paolo profiling the compiler
5757 speed on the output of `gen-sample-program.pl' perl script.
5759 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
5760 not crash in methods like MemberLookupFailed that use this field.
5762 This problem arises when the compiler fails to resolve a type
5763 during interface type definition for example.
5765 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5767 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
5768 inherit from System.Object, so we have to stop at null, not only
5769 when reaching System.Object.
5771 2003-02-17 Miguel de Icaza <miguel@ximian.com>
5773 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
5774 DeclaredOnly because the parent indexer might have had a different
5775 name, but did not loop until the top of the hierarchy was reached.
5777 The problem this one fixes is 35492: when a class implemented an
5778 indexer from an interface, we were getting the interface method
5779 (which was abstract) and we were flagging an error (can not invoke
5782 This also keeps bug 33089 functioning, and test-148 functioning.
5784 * typemanager.cs (IsSpecialMethod): The correct way of figuring
5785 out if a method is special is to see if it is declared in a
5786 property or event, or whether it is one of the predefined operator
5787 names. This should fix correctly #36804.
5789 2003-02-15 Miguel de Icaza <miguel@ximian.com>
5791 The goal here is to remove the dependency on EmptyCast.Peel ().
5792 Killing it completely.
5794 The problem is that currently in a number of places where
5795 constants are expected, we have to "probe" for an EmptyCast, and
5796 Peel, which is not the correct thing to do, as this will be
5797 repetitive and will likely lead to errors.
5799 The idea is to remove any EmptyCasts that are used in casts that
5800 can be reduced to constants, so we only have to cope with
5803 This bug hunt was triggered by Bug 37363 and the desire to remove
5804 the duplicate pattern where we were "peeling" emptycasts to check
5805 whether they were constants. Now constants will always be
5808 * ecore.cs: Use an enumconstant here instead of wrapping with
5811 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
5812 throwing me off. By handling this we can get rid of a few hacks.
5814 * statement.cs (Switch): Removed Peel() code.
5816 2003-02-14 Miguel de Icaza <miguel@ximian.com>
5818 * class.cs: Location information for error 508
5820 * expression.cs (New.DoResolve): Add a guard against double
5821 resolution of an expression.
5823 The New DoResolve might be called twice when initializing field
5824 expressions (see EmitFieldInitializers, the call to
5825 GetInitializerExpression will perform a resolve on the expression,
5826 and later the assign will trigger another resolution
5828 This leads to bugs (#37014)
5830 * delegate.cs: The signature for EndInvoke should contain any ref
5831 or out parameters as well. We were not doing this in the past.
5833 * class.cs (Field.Define): Do not overwrite the type definition
5834 inside the `volatile' group. Turns out that volatile enumerations
5835 were changing the type here to perform a validity test, which
5838 2003-02-12 Miguel de Icaza <miguel@ximian.com>
5840 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
5841 and structs, we do not want to load the instance variable
5843 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
5844 enum_type has to be handled like an object reference (implicit
5845 conversions exists from this to object), but the regular IsClass
5846 and IsValueType tests will never return true for this one.
5848 Also we use TypeManager.IsValueType instead of type.IsValueType,
5849 just for consistency with the rest of the code (this is only
5850 needed if we ever use the construct exposed by test-180.cs inside
5851 corlib, which we dont today).
5853 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
5855 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
5858 2003-02-09 Martin Baulig <martin@ximian.com>
5860 * namespace.cs (Namespace..ctor): Added SourceFile argument.
5861 (Namespace.DefineNamespaces): New static public method; this is
5862 called when we're compiling with debugging to add all namespaces
5865 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
5866 pass it to the Namespace's .ctor.
5868 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
5869 and MethodBase arguments; pass the namespace ID to the symwriter;
5870 pass the MethodBase instead of the token to the symwriter.
5871 (SymbolWriter.DefineNamespace): New method to add a namespace to
5874 2003-02-09 Martin Baulig <martin@ximian.com>
5876 * symbolwriter.cs: New file. This is a wrapper around
5877 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
5878 methods here in near future.
5880 2003-02-09 Martin Baulig <martin@ximian.com>
5882 * codegen.cs (EmitContext.Mark): Just pass the arguments to
5883 ILGenerator.MarkSequencePoint() which are actually used by the
5886 2003-02-09 Martin Baulig <martin@ximian.com>
5888 * location.cs (SourceFile): New public sealed class. This
5889 contains the name and an index which is used in the location's token.
5890 (Location): Reserve an appropriate number of bits in the token for
5891 the source file instead of walking over that list, this gives us a
5892 really huge performance improvement when compiling with debugging.
5894 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
5895 `SourceFile' argument instead of a string.
5896 (Driver.ProcessFile): Add all the files via Location.AddFile(),
5897 but don't parse/tokenize here, we need to generate the list of all
5898 source files before we do that.
5899 (Driver.ProcessFiles): New static function. Parses/tokenizes all
5902 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
5903 instead of a string.
5905 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
5908 2003-02-09 Martin Baulig <martin@ximian.com>
5910 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
5911 filename on `#line default'.
5913 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
5915 * statement.cs: don't clear the pinned var when the fixed statement
5916 returns from the method (fixes bug#37752).
5918 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
5920 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
5923 2003-02-07 Martin Baulig <martin@ximian.com>
5925 * driver.cs: Removed the `--debug-args' command line argument.
5927 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
5928 automatically by the AsssemblyBuilder.
5929 (CodeGen.InitializeSymbolWriter): We don't need to call any
5930 initialization function on the symbol writer anymore. This method
5931 doesn't take any arguments.
5933 2003-02-03 Miguel de Icaza <miguel@ximian.com>
5935 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
5936 from referenced assemblies as well.
5938 2003-02-02 Martin Baulig <martin@ximian.com>
5940 * class.cs (MethodData.Emit): Generate debugging info for external methods.
5942 2003-02-02 Martin Baulig <martin@ximian.com>
5944 * class.cs (Constructor.Emit): Open the symbol writer before
5945 emitting the constructor initializer.
5946 (ConstructorInitializer.Emit): Call ec.Mark() to allow
5947 single-stepping through constructor initializers.
5949 2003-01-30 Miguel de Icaza <miguel@ximian.com>
5951 * class.cs: Handle error 549: do not allow virtual methods in
5954 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
5956 * decl.cs: Check access levels when resolving types
5958 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
5960 * statement.cs: Add parameters and locals set in catch blocks that might
5961 return to set vector
5963 2003-01-29 Miguel de Icaza <miguel@ximian.com>
5965 * class.cs (Operator): Set the SpecialName flags for operators.
5967 * expression.cs (Invocation.DoResolve): Only block calls to
5968 accessors and operators on SpecialName methods.
5970 (Cast.TryReduce): Handle conversions from char constants.
5973 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
5975 * statement.cs: small memory and time optimization in FlowBranching.
5977 2003-01-28 Pedro Mart <yoros@wanadoo.es>
5979 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
5980 problem that the last fix but in the other sid (Set).
5982 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
5983 access when there is no indexer in the hierarchy.
5985 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
5987 * class.cs: Combine some if statements.
5989 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5991 * driver.cs: fixed bug #37187.
5993 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
5995 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
5996 any indexer, it's needed to build a list with all the indexers in the
5997 hierarchy (AllGetters), else we have problems. Fixes #35653.
5999 2003-01-23 Miguel de Icaza <miguel@ximian.com>
6001 * class.cs (MethodData.Define): It is wrong for an interface
6002 implementation to be static in both cases: explicit and implicit.
6003 We were only handling this in one case.
6005 Improve the if situation there to not have negations.
6007 * class.cs (Field.Define): Turns out that we do not need to check
6008 the unsafe bit on field definition, only on usage. Remove the test.
6010 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6012 * driver.cs: use assembly.Location instead of Codebase (the latest
6013 patch made mcs fail when using MS assemblies).
6015 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
6017 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
6018 get the path to *corlib.dll.
6020 2003-01-21 Nick Drochak <ndrochak@gol.com>
6024 * typemanager.cs: Remove compiler warnings
6026 2003-01-20 Duncan Mak <duncan@ximian.com>
6028 * AssemblyInfo.cs: Bump the version number to 0.19.
6030 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6032 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
6034 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
6036 * class.cs (Constructor::Emit): Emit debugging info for constructors.
6038 2003-01-17 Miguel de Icaza <miguel@ximian.com>
6040 * cs-parser.jay: Small fix: we were not comparing the constructor
6041 name correctly. Thanks to Zoltan for the initial pointer.
6043 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
6045 * cs-tokenizer.cs: Set file name when specified with #line
6047 2003-01-15 Miguel de Icaza <miguel@ximian.com>
6049 * cs-parser.jay: Only perform the constructor checks here if we
6050 are named like the class; This will help provider a better
6051 error. The constructor path is taken when a type definition is
6052 not found, but most likely the user forgot to add the type, so
6053 report that rather than the constructor error.
6055 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
6057 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
6060 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6062 * cs-parser.jay: Add cleanup call.
6064 2003-01-13 Duncan Mak <duncan@ximian.com>
6066 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
6067 consistent with other methods.
6069 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6071 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
6073 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
6075 * attribute.cs: only set GuidAttr to true when we have a
6078 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6082 * typemanager.cs: fixes to allow mcs compile corlib with the new
6083 Type.IsSubclassOf fix.
6085 2003-01-08 Miguel de Icaza <miguel@ximian.com>
6087 * expression.cs (LocalVariableReference.DoResolve): Classify a
6088 constant as a value, not as a variable. Also, set the type for
6091 * cs-parser.jay (fixed_statement): take a type instead of a
6092 pointer_type, so we can produce a better error message later.
6094 * statement.cs (Fixed.Resolve): Flag types that are not pointers
6097 (For.DoEmit): Make inifinite loops have a
6098 non-conditional branch back.
6100 (Fixed.DoEmit): First populate the pinned variables, then emit the
6101 statement, then clear the variables. Before I was emitting the
6102 code once for each fixed piece.
6105 2003-01-08 Martin Baulig <martin@ximian.com>
6107 * statement.cs (FlowBranching.MergeChild): A break in a
6108 SWITCH_SECTION does not leave a loop. Fixes #36155.
6110 2003-01-08 Martin Baulig <martin@ximian.com>
6112 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
6113 lives in the same number space than `param_map'. Fixes #36154.
6115 2003-01-07 Miguel de Icaza <miguel@ximian.com>
6117 * cs-parser.jay (constructor_declaration): Set the
6118 Constructor.ModFlags before probing for it. This makes the
6119 compiler report 514, 515 and 132 (the code was there, but got
6122 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
6123 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
6124 (GotoCase.Resolve): Set `Returns' to ALWAYS.
6126 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
6128 * enum.cs: create the enum static fields using the enum type.
6130 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
6132 * class.cs: don't try to create the ParamBuilder for the return
6133 type if it's not needed (and handle it breaking for the ms runtime
6136 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
6138 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
6140 2002-12-29 Miguel de Icaza <miguel@ximian.com>
6142 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
6143 the command. This showed up while compiling the JANET source
6144 code, which used \r as its only newline separator.
6146 2002-12-28 Miguel de Icaza <miguel@ximian.com>
6148 * class.cs (Method.Define): If we are an operator (because it
6149 reuses our code), then set the SpecialName and HideBySig. #36128
6151 2002-12-22 Miguel de Icaza <miguel@ximian.com>
6153 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
6154 exception, report error 120 `object reference required'.
6156 * driver.cs: Add --pause option, used during to measure the size
6157 of the process as it goes with --timestamp.
6159 * expression.cs (Invocation.DoResolve): Do not allow methods with
6160 SpecialName to be invoked.
6162 2002-12-21 Miguel de Icaza <miguel@ximian.com>
6164 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
6165 number before adding it.
6167 2002-12-21 Ravi Pratap <ravi@ximian.com>
6169 * ecore.cs (StandardImplicitConversion): When in an unsafe
6170 context, we allow conversion between void * to any other pointer
6171 type. This fixes bug #35973.
6173 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
6175 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
6176 is not thrown when extensionless outputs are used
6178 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6180 * rootcontext.cs: fixed compilation of corlib.
6182 2002-12-19 Miguel de Icaza <miguel@ximian.com>
6184 * attribute.cs (Attributes.Contains): Add new method.
6186 * class.cs (MethodCore.LabelParameters): if the parameter is an
6187 `out' parameter, check that no attribute `[In]' has been passed.
6189 * enum.cs: Handle the `value__' name in an enumeration.
6191 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
6193 * decl.cs: Added special case to allow overrides on "protected
6196 2002-12-18 Ravi Pratap <ravi@ximian.com>
6198 * attribute.cs (Attributes.AddAttributeSection): Rename to this
6199 since it makes much more sense.
6201 (Attributes.ctor): Don't require a Location parameter.
6203 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
6205 * attribute.cs (ApplyAttributes): Remove extra Location parameters
6206 since we already have that information per attribute.
6208 * everywhere : make appropriate changes.
6210 * class.cs (LabelParameters): Write the code which actually
6211 applies attributes to the return type. We can't do this on the MS
6212 .NET runtime so we flag a warning in the case an exception is
6215 2002-12-18 Miguel de Icaza <miguel@ximian.com>
6217 * const.cs: Handle implicit null conversions here too.
6219 2002-12-17 Ravi Pratap <ravi@ximian.com>
6221 * class.cs (MethodCore.LabelParameters): Remove the extra
6222 Type [] parameter since it is completely unnecessary. Instead
6223 pass in the method's attributes so that we can extract
6224 the "return" attribute.
6226 2002-12-17 Miguel de Icaza <miguel@ximian.com>
6228 * cs-parser.jay (parse): Use Report.Error to flag errors instead
6229 of ignoring it and letting the compile continue.
6231 * typemanager.cs (ChangeType): use an extra argument to return an
6232 error condition instead of throwing an exception.
6234 2002-12-15 Miguel de Icaza <miguel@ximian.com>
6236 * expression.cs (Unary.TryReduce): mimic the code for the regular
6237 code path. Perform an implicit cast in the cases where we can
6238 implicitly convert to one of the integral types, and then reduce
6239 based on that constant. This fixes bug #35483.
6241 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6243 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
6245 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6247 * namespace.cs: fixed bug #35489.
6249 2002-12-12 Miguel de Icaza <miguel@ximian.com>
6251 * class.cs: Remove some dead code.
6253 * cs-parser.jay: Estimate the number of methods needed
6254 (RootContext.MethodCount);
6256 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
6257 numbers instead of StringBuilders.
6259 * support.cs (PtrHashtable): Add constructor with initial size;
6260 We can now reduce reallocations of the method table.
6262 2002-12-10 Ravi Pratap <ravi@ximian.com>
6264 * attribute.cs (ApplyAttributes): Keep track of the emitted
6265 attributes on a per-target basis. This fixes bug #35413.
6267 2002-12-10 Miguel de Icaza <miguel@ximian.com>
6269 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
6270 default to the Windows 1252 encoding.
6272 (UnixParseOption): Support version, thanks to Alp for the missing
6275 * AssemblyInfo.cs: Add nice assembly information.
6277 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
6280 * cs-parser.jay: Allow a trailing comma before the close bracked
6281 in the attribute_section production.
6283 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
6284 address of the instance was being taken, I will take this out,
6285 because we take the address of the object immediately here.
6287 2002-12-09 Ravi Pratap <ravi@ximian.com>
6289 * typemanager.cs (AreMultipleAllowed): Take care of the most
6290 obvious case where attribute type is not in the current assembly -
6293 2002-12-08 Miguel de Icaza <miguel@ximian.com>
6295 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
6296 definitions, instead of doing that afterwards.
6298 Also we use a nice little hack, depending on the constructor, we
6299 know if we are a "composed" name or a simple name. Hence, we
6300 avoid the IndexOf test, and we avoid
6302 * codegen.cs: Add code to assist in a bug reporter to track down
6303 the source of a compiler crash.
6305 2002-12-07 Ravi Pratap <ravi@ximian.com>
6307 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
6308 types have been emitted for a given element and flag an error
6309 if something which does not have AllowMultiple set is used more
6312 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
6313 attribute types and their corresponding AllowMultiple properties
6315 (AreMultipleAllowed): Check the property for a given type.
6317 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
6318 property in the case we have a TypeContainer.
6320 (Attributes.AddAttribute): Detect duplicates and just skip on
6321 adding them. This trivial fix catches a pretty gross error in our
6322 attribute emission - global attributes were being emitted twice!
6324 Bugzilla bug #33187 is now fixed.
6326 2002-12-06 Miguel de Icaza <miguel@ximian.com>
6328 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
6331 * expression.cs (Binary.ResolveOperator): I can only use the
6332 Concat (string, string, string) and Concat (string, string,
6333 string, string) if the child is actually a concatenation of
6336 2002-12-04 Miguel de Icaza <miguel@ximian.com>
6338 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
6339 context where we need a 2-character lookahead.
6341 * pending.cs (PendingImplementation): Rework so we can keep track
6342 of interface types all the time, and flag those which were
6343 implemented by parents as optional.
6345 2002-12-03 Miguel de Icaza <miguel@ximian.com>
6347 * expression.cs (Binary.ResolveOperator): Use
6348 String.Concat(string,string,string) or
6349 String.Concat(string,string,string,string) when possible.
6351 * typemanager: More helper methods.
6354 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
6356 * pending.cs: remove the bogus return from GetMissingInterfaces()
6357 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
6359 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6361 * namespace.cs: avoid duplicated 'using xxx' being added to
6362 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
6363 when we get more than one 'using' statement for the same namespace.
6364 Report a CS0105 warning for it.
6366 2002-11-30 Miguel de Icaza <miguel@ximian.com>
6368 * cs-tokenizer.cs (consume_identifier): use read directly, instead
6369 of calling getChar/putback, uses internal knowledge of it.
6371 (xtoken): Reorder tokenizer so most common patterns are checked
6372 first. This reduces the compilation time in another 5% (from 8.11s
6373 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
6375 The parsing time is 22% of the compilation in mcs, and from that
6376 64% is spent on the tokenization process.
6378 I tried using a binary search for keywords, but this is slower
6379 than the hashtable. Another option would be to do a couple of
6382 * Not use a StringBuilder, instead use an array of chars,
6383 with a set value. Notice that this way we could catch
6384 the 645 error without having to do it *afterwards*.
6386 * We could write a hand-parser to avoid the hashtable
6387 compares altogether.
6389 The identifier consumption process takes 37% of the tokenization
6390 time. Another 15% is spent on is_number. 56% of the time spent
6391 on is_number is spent on Int64.Parse:
6393 * We could probably choose based on the string length to
6394 use Int32.Parse or Int64.Parse and avoid all the 64-bit
6397 Another 3% is spend on wrapping `xtoken' in the `token' function.
6399 Handle 0xa0 as whitespace (#34752)
6401 2002-11-26 Miguel de Icaza <miguel@ximian.com>
6403 * typemanager.cs (IsCLRType): New routine to tell whether a type
6404 is one of the builtin types.
6406 Maybe it needs to use TypeCodes to be faster. Maybe we could use
6407 typecode in more places instead of doing pointer comparissions.
6408 We could leverage some knowledge about the way the typecodes are
6411 New code to cache namespaces in assemblies, it is currently not
6412 invoked, to be used soon.
6414 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
6416 * expression.cs (Binary.ResolveOperator): specially handle
6417 strings, and do not perform user-defined operator overloading for
6420 2002-11-24 Miguel de Icaza <miguel@ximian.com>
6422 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
6423 internalcall as it is a pretty simple operation; Avoid whenever
6424 possible to call Char.IsLetter.
6426 (consume_identifier): Cut by half the number of
6427 hashtable calls by merging the is_keyword and GetKeyword behavior.
6429 Do not short-circuit, because if we do, we
6430 report errors (ie, #if false && true would produce an invalid
6434 2002-11-24 Martin Baulig <martin@ximian.com>
6436 * expression.cs (Cast.TryReduce): If we're in checked syntax,
6437 check constant ranges and report a CS0221. Fixes #33186.
6439 2002-11-24 Martin Baulig <martin@ximian.com>
6441 * cs-parser.jay: Make this work for uninitialized variable
6442 declarations in the `for' initializer. Fixes #32416.
6444 2002-11-24 Martin Baulig <martin@ximian.com>
6446 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
6447 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
6449 2002-11-24 Martin Baulig <martin@ximian.com>
6451 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
6452 argument; if true, we also check for user-defined conversions.
6453 This is only needed if both arguments are of a user-defined type.
6454 Fixes #30443, added test-175.cs.
6455 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
6457 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
6459 2002-11-24 Martin Baulig <martin@ximian.com>
6461 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
6462 function to get the store opcode.
6463 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
6464 only emit the Ldelema if the store opcode is Stobj. You must run
6465 both test-34 and test-167 to test this. Fixes #34529.
6467 2002-11-23 Martin Baulig <martin@ximian.com>
6469 * ecore.cs (Expression.MemberLookup): Added additional
6470 `qualifier_type' argument which is used when we're being called
6471 from MemberAccess.DoResolve() and null if we're called from a
6473 (Expression.MemberLookupFailed): New method to report errors; this
6474 does the CS1540 check and reports the correct error message.
6476 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
6477 argument for the CS1540 check and redone the way how we're dealing
6478 with private members. See the comment in the source code for details.
6479 (FilterWithClosure): Reverted this back to revision 1.197; renamed
6480 `closure_start_type' to `closure_qualifier_type' and check whether
6481 it's not null. It was not this filter being broken, it was just
6482 being called with the wrong arguments.
6484 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
6485 and pass it the correct `qualifier_type'; this also does the error
6488 2002-11-22 Miguel de Icaza <miguel@ximian.com>
6490 * expression.cs (Invocation.EmitParams): If the we are dealing
6491 with a non-built-in value type, load its address as well.
6493 (ArrayCreation): Use a a pretty constant instead
6494 of the hardcoded value 2. Use 6 instead of 2 for the number of
6495 static initializers.
6497 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
6498 because they are not really value types, just glorified integers.
6500 * driver.cs: Do not append .exe, the CSC compiler does not do it.
6502 * ecore.cs: Remove redundant code for enumerations, make them use
6503 the same code path as everything else, fixes the casting issue
6504 with enumerations in Windows.Forms.
6506 * attribute.cs: Do only cast to string if it is a string, the
6507 validation happens later.
6509 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
6510 people upgrade their corlibs.
6512 * ecore.cs: Oops, enumerations were not following the entire code path
6514 2002-11-21 Miguel de Icaza <miguel@ximian.com>
6516 * typemanager.cs (FilterWithClosure): Commented out the test for
6517 1540 in typemanager.cs, as it has problems when accessing
6518 protected methods from a parent class (see test-174.cs).
6520 * attribute.cs (Attribute.ValidateGuid): new method.
6521 (Attribute.Resolve): Use above.
6523 2002-11-19 Miguel de Icaza <miguel@ximian.com>
6525 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
6527 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
6528 handling for enumerations, as we only needed the TypeContainer
6529 functionality to begin with (this is required for the fix below to
6530 work for enums that reference constants in a container class for
6533 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
6535 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
6536 a valid TypeBuilder to perform lookups on.o
6538 * class.cs (InheritableMemberSignatureCompare): Use true in the
6539 call to GetGetMethod and GetSetMethod, because we are comparing
6540 the signature, and we need to get the methods *even* if they are
6543 (PropertyBase.CheckBase): ditto.
6545 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
6546 GotoCase.Resolve): Use Peel on EmpytCasts.
6548 * ecore.cs (EmptyCast): drop child, add Peel method.
6550 2002-11-17 Martin Baulig <martin@ximian.com>
6552 * ecore.cs (EmptyCast.Child): New public property.
6554 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
6555 label resolved to an EmptyCast. Fixes #34162.
6556 (GotoCase.Resolve): Likewise.
6557 (Block.EmitMeta): Likewise.
6559 2002-11-17 Martin Baulig <martin@ximian.com>
6561 * expression.cs (Invocation.BetterConversion): Prefer int over
6562 uint; short over ushort; long over ulong for integer literals.
6563 Use ImplicitConversionExists instead of StandardConversionExists
6564 since we also need to check for user-defined implicit conversions.
6565 Fixes #34165. Added test-173.cs.
6567 2002-11-16 Martin Baulig <martin@ximian.com>
6569 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
6570 with the `true' and `false' literals. Fixes #33151.
6572 2002-11-16 Martin Baulig <martin@ximian.com>
6574 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
6575 October 22nd; don't do the cs1540 check for static members.
6577 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
6578 now using our own filter here and doing the cs1540 check again.
6580 2002-11-16 Martin Baulig <martin@ximian.com>
6582 * support.cs (InternalParameters): Don't crash if we don't have
6583 any fixed parameters. Fixes #33532.
6585 2002-11-16 Martin Baulig <martin@ximian.com>
6587 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
6588 when looking up static methods to make this work on Windows.
6591 2002-11-16 Martin Baulig <martin@ximian.com>
6593 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
6594 a setter rather than using PropertyInfo.CanWrite.
6596 2002-11-15 Nick Drochak <ndrochak@gol.com>
6598 * class.cs: Allow acces to block member by subclasses. Fixes build
6601 2002-11-14 Martin Baulig <martin@ximian.com>
6603 * class.cs (Constructor.Emit): Added the extern/block check.
6606 2002-11-14 Martin Baulig <martin@ximian.com>
6608 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
6609 iteration while looking for indexers, this is needed because the
6610 indexer may have a different name in our base classes. Fixed the
6611 error reporting (no indexers at all, not get accessor, no
6612 overloaded match). Fixes bug #33089.
6613 (IndexerAccess.DoResolveLValue): Likewise.
6615 2002-11-14 Martin Baulig <martin@ximian.com>
6617 * class.cs (PropertyBase.CheckBase): Make this work for multiple
6618 indexers. Fixes the first part of bug #33089.
6619 (MethodSignature.InheritableMemberSignatureCompare): Added support
6622 2002-11-13 Ravi Pratap <ravi@ximian.com>
6624 * attribute.cs (Attribute.Resolve): Catch the
6625 NullReferenceException and report it since it isn't supposed to
6628 2002-11-12 Miguel de Icaza <miguel@ximian.com>
6630 * expression.cs (Binary.EmitBranchable): Also handle the cases for
6631 LogicalOr and LogicalAnd that can benefit from recursively
6632 handling EmitBranchable. The code now should be nice for Paolo.
6634 2002-11-08 Miguel de Icaza <miguel@ximian.com>
6636 * typemanager.cs (LookupType): Added a negative-hit hashtable for
6637 the Type lookups, as we perform quite a number of lookups on
6638 non-Types. This can be removed once we can deterministically tell
6639 whether we have a type or a namespace in advance.
6641 But this might require special hacks from our corlib.
6645 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
6646 and double which avoids a conversion from an integer to a double.
6648 * expression.cs: tiny optimization, avoid calling IsConstant,
6649 because it effectively performs the lookup twice.
6651 2002-11-06 Miguel de Icaza <miguel@ximian.com>
6653 But a bogus return here to keep the semantics of the old code
6654 until the Mono runtime is fixed.
6656 * pending.cs (GetMissingInterfaces): New method used to remove all
6657 the interfaces that are already implemented by our parent
6658 classes from the list of pending methods.
6660 * interface.cs: Add checks for calls after ResolveTypeExpr.
6662 2002-11-05 Miguel de Icaza <miguel@ximian.com>
6664 * class.cs (Class.Emit): Report warning 67: event not used if the
6665 warning level is beyond 3.
6667 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
6668 being a NullLiteral.
6670 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
6673 * class.cs (TypeContainer.GetClassBases): Cover a missing code
6674 path that might fail if a type can not be resolved.
6676 * expression.cs (Binary.Emit): Emit unsigned versions of the
6679 * driver.cs: use error 5.
6681 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
6683 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
6685 2002-11-01 Miguel de Icaza <miguel@ximian.com>
6687 * cs-parser.jay (switch_section): A beautiful patch from Martin
6688 Baulig that fixed 33094.
6690 2002-10-31 Miguel de Icaza <miguel@ximian.com>
6692 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
6693 Check whether the base is abstract and report an error if so.
6695 * expression.cs (IndexerAccess.DoResolveLValue,
6696 IndexerAccess.DoResolve): ditto.
6698 (Invocation.DoResolve): ditto.
6700 (Invocation.FullMethodDesc): Improve the report string.
6702 * statement.cs (Block): Eliminate IsVariableDefined as it is
6703 basically just a wrapper for GetVariableInfo.
6705 * ecore.cs (SimpleName): Use new
6707 * support.cs (ReflectionParamter.ParameterType): We unwrap the
6708 type, as we return the actual parameter ref/unref state on a
6711 2002-10-30 Miguel de Icaza <miguel@ximian.com>
6713 * support.cs: Return proper flags REF/OUT fixing the previous
6716 * expression.cs: Reverted last patch, that was wrong. Is_ref is
6717 not used to mean `ref' but `ref or out' in ParameterReference
6719 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
6720 full type signature instead of calling TypeManger.CSharpName
6723 * support.cs (InternalParameters.ParameterDesc): Do not compare
6724 directly to the modflags, because REF/OUT will actually be bitsets
6727 * delegate.cs (VerifyMethod): Check also the modifiers.
6729 * cs-tokenizer.cs: Fix bug where floating point values with an
6730 exponent where a sign was missing was ignored.
6732 * driver.cs: Allow multiple assemblies to be specified in a single
6735 2002-10-28 Miguel de Icaza <miguel@ximian.com>
6737 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
6738 because identifiers after a parenthesis would end up in this kind
6739 of production, and we needed to desamiguate it for having casts
6742 (UserDefinedType *) xxx
6744 2002-10-24 Miguel de Icaza <miguel@ximian.com>
6746 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
6747 we should set on the Bindingflags.NonPublic, but not turn on
6748 private_ok. private_ok controls whether a Private member is
6749 returned (this is chekced on the filter routine), while the
6750 BindingFlags.NonPublic just controls whether private/protected
6751 will be allowed. This fixes the problem part of the problem of
6752 private properties being allowed to be used in derived classes.
6754 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
6755 so we can call the children DoResolveLValue method (this will
6756 properly signal errors on lvalue assignments to base properties)
6758 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
6759 getter are null, and we have a property info, we know that this
6760 happened because the lookup failed, so we report an error 122 for
6761 protection level violation.
6763 We also silently return if setter and getter are null in the
6764 resolve functions, this condition only happens if we have flagged
6765 the error before. This is the other half of the problem.
6767 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
6768 not have accessibility information, that is why we were returning
6769 true in the filter function in typemanager.cs.
6771 To properly report 122 (property is inaccessible because of its
6772 protection level) correctly, we report this error in ResolveAccess
6773 by failing if both the setter and the getter are lacking (ie, the
6776 DoResolve and DoLResolve have been modified to check for both
6777 setter/getter being null and returning silently, the reason being
6778 that I did not want to put the knowledge about this error in upper
6781 int old = Report.Errors;
6782 x = new PropertyExpr (...);
6783 if (old != Report.Errors)
6788 So the property expr is returned, but it is invalid, so the error
6789 will be flagged during the resolve process.
6791 * class.cs: Remove InheritablePropertySignatureCompare from the
6792 class, as we no longer depend on the property signature to compute
6793 whether it is possible to implement a method or not.
6795 The reason is that calling PropertyInfo.GetGetMethod will return
6796 null (in .NET, in Mono it works, and we should change this), in
6797 cases where the Get Method does not exist in that particular
6802 class X { public virtual int A { get { return 1; } } }
6804 class Z : Y { public override int A { get { return 2; } } }
6806 Would fail in Z because the parent (Y) would not have the property
6807 defined. So we avoid this completely now (because the alternative
6808 fix was ugly and slow), and we now depend exclusively on the
6811 (PropertyBase.CheckBase): Use a method-base mechanism to find our
6812 reference method, instead of using the property.
6814 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
6815 routines are gone now.
6817 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
6818 names, they were incorrectly named.
6820 * cs-tokenizer.cs: Return are more gentle token on failure.
6822 * pending.cs (PendingImplementation.InterfaceMethod): This routine
6823 had an out-of-sync index variable, which caused it to remove from
6824 the list of pending methods the wrong method sometimes.
6826 2002-10-22 Miguel de Icaza <miguel@ximian.com>
6828 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
6829 CanWrite, because those refer to this particular instance of the
6830 property, and do not take into account the fact that we can
6831 override single members of a property.
6833 Constructor requires an EmitContext. The resolution process does
6834 not happen here, but we need to compute the accessors before,
6835 because the resolution does not always happen for properties.
6837 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
6838 subclass, before we did not update this flag, but we did update
6841 (GetAccessors): Drop this routine, as it did not work in the
6842 presence of partially overwritten set/get methods.
6844 Notice that this broke the cs1540 detection, but that will require
6847 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6851 * driver.cs: issue a warning instead of an error if we don't support
6852 debugging for the platform. Also ignore a couple of errors that may
6853 arise when trying to write the symbols. Undo my previous patch.
6855 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6857 * driver.cs: ignore /debug switch except for Unix platforms.
6859 2002-10-23 Nick Drochak <ndrochak@gol.com>
6861 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
6863 2002-10-21 Miguel de Icaza <miguel@ximian.com>
6865 * driver.cs: Do not make mcs-debug conditional, so we do not break
6868 * statement.cs (UsageVector.MergeChildren): I would like Martin to
6869 review this patch. But basically after all the children variables
6870 have been merged, the value of "Breaks" was not being set to
6871 new_breaks for Switch blocks. I think that it should be set after
6872 it has executed. Currently I set this to the value of new_breaks,
6873 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
6874 conservative, but I do not understand this code very well.
6876 I did not break anything in the build, so that is good ;-)
6878 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
6880 2002-10-20 Mark Crichton <crichton@gimp.org>
6882 * cfold.cs: Fixed compile blocker. Really fixed it this time.
6884 2002-10-20 Nick Drochak <ndrochak@gol.com>
6886 * cfold.cs: Fixed compile blocker.
6888 2002-10-20 Miguel de Icaza <miguel@ximian.com>
6890 * driver.cs: I was chekcing the key, not the file.
6892 2002-10-19 Ravi Pratap <ravi@ximian.com>
6894 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
6895 message that we were generating - we just need to silently return
6898 2002-10-19 Miguel de Icaza <miguel@ximian.com>
6900 * class.cs (Event.Define): Change my previous commit, as this
6901 breaks the debugger. This is a temporary hack, as it seems like
6902 the compiler is generating events incorrectly to begin with.
6904 * expression.cs (Binary.ResolveOperator): Added support for
6905 "U operator - (E x, E y)"
6907 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
6910 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
6911 init-only variables, but this path did not take into account that
6912 there might be also instance readonly variables. Correct this
6915 This fixes bug 32253
6917 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
6920 * driver.cs: Change the extension for modules to `netmodule'
6922 * cs-parser.jay: Improved slightly the location tracking for
6923 the debugger symbols.
6925 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
6926 modifiers that were specified instead of the hardcoded value
6927 (FamAndAssem). This was basically ignoring the static modifier,
6928 and others. Fixes 32429.
6930 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
6931 fixed a bug in the process (32476)
6933 * expression.cs (ArrayAccess.EmitAssign): Patch from
6934 hwang_rob@yahoo.ca that fixes bug 31834.3
6936 2002-10-18 Miguel de Icaza <miguel@ximian.com>
6938 * driver.cs: Make the module extension .netmodule.
6940 2002-10-16 Miguel de Icaza <miguel@ximian.com>
6942 * driver.cs: Report an error if the resource file is not found
6943 instead of crashing.
6945 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
6946 false, like Emit does.
6948 2002-10-16 Nick Drochak <ndrochak@gol.com>
6950 * typemanager.cs: Remove unused private member. Also reported mcs
6951 bug to report this as a warning like csc.
6953 2002-10-15 Martin Baulig <martin@gnome.org>
6955 * statement.cs (Statement.Emit): Made this a virtual method; emits
6956 the line number info and calls DoEmit().
6957 (Statement.DoEmit): New protected abstract method, formerly knows
6958 as Statement.Emit().
6960 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
6962 2002-10-11 Miguel de Icaza <miguel@ximian.com>
6964 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
6965 have fixed a remaining problem: not every AddXXXX was adding a
6966 fully qualified name.
6968 Now everyone registers a fully qualified name in the DeclSpace as
6969 being defined instead of the partial name.
6971 Downsides: we are slower than we need to be due to the excess
6972 copies and the names being registered this way.
6974 The reason for this is that we currently depend (on the corlib
6975 bootstrap for instance) that types are fully qualified, because
6976 we dump all the types in the namespace, and we should really have
6977 types inserted into the proper namespace, so we can only store the
6978 basenames in the defined_names array.
6980 2002-10-10 Martin Baulig <martin@gnome.org>
6982 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
6983 from bug #31834, see the bug report for a testcase which is
6986 2002-10-10 Martin Baulig <martin@gnome.org>
6988 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
6989 flow analysis code for this.
6991 * statement.cs (Do, While, For): Tell the flow analysis code about
6993 (FlowBranching.UsageVector): Added support for infinite loops.
6994 (Block.Resolve): Moved the dead code elimination here and use flow
6997 2002-10-09 Miguel de Icaza <miguel@ximian.com>
6999 * class.cs (Field.Define): Catch cycles on struct type
7002 * typemanager.cs (IsUnmanagedtype): Do not recursively check
7003 fields if the fields are static. We only need to check instance
7006 * expression.cs (As.DoResolve): Test for reference type.
7008 * statement.cs (Using.ResolveExpression): Use
7009 ConvertImplicitRequired, not ConvertImplicit which reports an
7011 (Using.ResolveLocalVariableDecls): ditto.
7013 * expression.cs (Binary.ResolveOperator): Report errors in a few
7014 places where we had to.
7016 * typemanager.cs (IsUnmanagedtype): Finish implementation.
7018 2002-10-08 Miguel de Icaza <miguel@ximian.com>
7020 * expression.cs: Use StoreFromPtr instead of extracting the type
7021 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
7023 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
7024 an enumeration value to a System.Enum, but System.Enum is not a
7025 value type, but an class type, so we need to box.
7027 (Expression.ConvertExplicit): One codepath could return
7028 errors but not flag them. Fix this. Fixes #31853
7030 * parameter.cs (Resolve): Do not allow void as a parameter type.
7032 2002-10-06 Martin Baulig <martin@gnome.org>
7034 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
7035 if it's a class type and not a struct. Fixes #31815.
7037 2002-10-06 Martin Baulig <martin@gnome.org>
7039 * statement.cs: Reworked the flow analysis code a bit to make it
7040 usable for dead code elimination.
7042 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7044 * cs-parser.jay: allow empty source files. Fixes bug #31781.
7046 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7048 * expression.cs (ComposedCast.DoResolveType): A quick workaround
7049 to fix the test 165, will investigate deeper.
7051 2002-10-04 Martin Baulig <martin@gnome.org>
7053 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
7054 finally blocks actually work.
7055 (Try.Resolve): We don't need to create a sibling for `finally' if
7056 there is no finally block.
7058 2002-10-04 Martin Baulig <martin@gnome.org>
7060 * class.cs (Constructor.Define): The default accessibility for a
7061 non-default constructor is private, not public.
7063 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7065 * class.cs (Constructor): Make AllowedModifiers public, add
7068 * cs-parser.jay: Perform the modifiers test here, as the
7069 constructor for the Constructor class usually receives a zero
7070 because of the way we create it (first we create, later we
7071 customize, and we were never checking the modifiers).
7073 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
7074 is a version of LookupTypeReflection that includes the type-name
7075 cache. This can be used as a fast path for functions that know
7076 the fully qualified name and are only calling into *.GetType() to
7077 obtain a composed type.
7079 This is also used by TypeManager.LookupType during its type
7082 (LookupType): We now also track the real type name, as sometimes
7083 we can get a quey for the real type name from things like
7084 ComposedCast. This fixes bug 31422.
7086 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
7087 complete type fullname, it does not have to go through the type
7088 resolution system to obtain the composed version of the type (for
7089 obtaining arrays or pointers).
7091 (Conditional.Emit): Use the EmitBoolExpression to
7092 generate nicer code, as requested by Paolo.
7094 (ArrayCreation.CheckIndices): Use the patch from
7095 hwang_rob@yahoo.ca to validate the array initializers.
7097 2002-10-03 Miguel de Icaza <miguel@ximian.com>
7099 * class.cs (ConstructorInitializer.Emit): simplify code by using
7100 Invocation.EmitCall, and at the same time, fix the bugs in calling
7101 parent constructors that took variable arguments.
7103 * ecore.cs (Expression.ConvertNumericExplicit,
7104 Expression.ImplicitNumericConversion): Remove the code that
7105 manually wrapped decimal (InternalTypeConstructor call is now gone
7108 * expression.cs (Cast.TryReduce): Also handle decimal types when
7109 trying to perform a constant fold on the type.
7111 * typemanager.cs (IsUnmanagedtype): Partially implemented.
7113 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
7114 that only turned off an error report, and did nothing else.
7116 2002-10-02 Miguel de Icaza <miguel@ximian.com>
7118 * driver.cs: Handle and ignore /fullpaths
7120 2002-10-01 Miguel de Icaza <miguel@ximian.com>
7122 * expression.cs (Binary.ResolveOperator): Catch the case where
7123 DoNumericPromotions returns true,
7125 (Binary.DoNumericPromotions): Simplify the code, and the tests.
7127 2002-09-27 Miguel de Icaza <miguel@ximian.com>
7129 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
7132 2002-09-26 Miguel de Icaza <miguel@ximian.com>
7134 * ecore.cs (ConvertNumericExplicit): It is not enough that the
7135 conversion exists, but it is also required that the conversion be
7136 performed. This manifested in "(Type64Enum) 2".
7138 * class.cs (TypeManager.AddMethod): The fix is not to change
7139 AddEnum, because that one was using a fully qualified name (every
7140 DeclSpace derivative does), but to change the AddMethod routine
7141 that was using an un-namespaced name. This now correctly reports
7142 the duplicated name.
7144 Revert patch until I can properly fix it. The issue
7145 is that we have a shared Type space across all namespaces
7146 currently, which is wrong.
7148 Options include making the Namespace a DeclSpace, and merge
7149 current_namespace/current_container in the parser.
7151 2002-09-25 Miguel de Icaza <miguel@ximian.com>
7153 * cs-parser.jay: Improve error reporting when we get a different
7154 kind of expression in local_variable_type and
7155 local_variable_pointer_type.
7157 Propagate this to avoid missleading errors being reported.
7159 * ecore.cs (ImplicitReferenceConversion): treat
7160 TypeManager.value_type as a target just like object_type. As
7165 Is valid, and needs to result in the int 1 being boxed before it
7166 is assigned to the value type v.
7168 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
7169 to validate the enumeration name.
7171 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
7172 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
7173 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
7175 * ecore.cs (TryImplicitIntConversion): When doing an
7176 implicit-enumeration-conversion, check if the type is 64-bits and
7177 perform a conversion before passing to EnumConstant.
7179 2002-09-23 Miguel de Icaza <miguel@ximian.com>
7181 * decl.cs (Error_AmbiguousTypeReference); New routine used to
7182 report ambiguous type references. Unlike the MS version, we
7183 report what the ambiguity is. Innovation at work ;-)
7185 (DeclSpace.FindType): Require a location argument to
7186 display when we display an ambiguous error.
7188 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
7190 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
7192 * expression.cs (EmitDynamicInitializers): Apply patch from
7193 hwang_rob@yahoo.ca that fixes the order in which we emit our
7196 2002-09-21 Martin Baulig <martin@gnome.org>
7198 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
7199 delegate takes no arguments.
7201 2002-09-20 Miguel de Icaza <miguel@ximian.com>
7203 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
7206 * expression.cs: Extract the underlying type.
7208 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
7210 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
7212 2002-09-19 Miguel de Icaza <miguel@ximian.com>
7214 * class.cs (TypeContainer.DefineType): We can not use the nice
7215 PackingSize with the size set to 1 DefineType method, because it
7216 will not allow us to define the interfaces that the struct
7219 This completes the fixing of bug 27287
7221 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
7222 means also structs. This fixes part of the problem.
7223 (Expresion.ImplicitReferenceConversionExists): ditto.
7225 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
7226 error if there were no errors reported during the type lookup
7227 process, to avoid duplicates or redundant errors. Without this
7228 you would get an ambiguous errors plus a type not found. We have
7229 beaten the user enough with the first error.
7231 (DeclSparce.FindType): Emit a warning if we have an ambiguous
7234 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
7235 during the resolution process, stop the lookup, this avoids
7236 repeated error reports (same error twice).
7238 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
7240 * typemanager.cs (LookupType): Redo the type lookup code to match
7241 the needs of System.Reflection.
7243 The issue is that System.Reflection requires references to nested
7244 types to begin with a "+" sign instead of a dot. So toplevel
7245 types look like: "NameSpace.TopLevelClass", and nested ones look
7246 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
7249 2002-09-19 Martin Baulig <martin@gnome.org>
7251 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
7252 says that a method always returns or always throws an exception,
7253 don't report the CS0161.
7255 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
7256 set `Returns = new_returns'.
7258 2002-09-19 Martin Baulig <martin@gnome.org>
7260 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
7261 to an enum constant, check for a CS0176.
7263 2002-09-18 Miguel de Icaza <miguel@ximian.com>
7265 * class.cs (TypeContainer.CheckPairedOperators): Now we check
7266 for operators that must be in pairs and report errors.
7268 * ecore.cs (SimpleName.DoResolveType): During the initial type
7269 resolution process, when we define types recursively, we must
7270 check first for types in our current scope before we perform
7271 lookups in the enclosing scopes.
7273 * expression.cs (MakeByteBlob): Handle Decimal blobs.
7275 (Invocation.VerifyArgumentsCompat): Call
7276 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
7277 I thought we were supposed to always call this, but there are a
7278 few places in the code where we dont do it.
7280 2002-09-17 Miguel de Icaza <miguel@ximian.com>
7282 * driver.cs: Add support in -linkres and -resource to specify the
7283 name of the identifier.
7285 2002-09-16 Miguel de Icaza <miguel@ximian.com>
7287 * ecore.cs (StandardConversionExists): Sync with the conversion
7288 code: allow anything-* to void* conversions.
7290 (FindMostSpecificSource): Use an Expression argument
7291 instead of a Type, because we might be handed over a Literal which
7292 gets a few more implicit conversions that plain types do not. So
7293 this information was being lost.
7295 Also, we drop the temporary type-holder expression when not
7298 2002-09-17 Martin Baulig <martin@gnome.org>
7300 * class.cs (PropertyBase.CheckBase): Don't check the base class if
7301 this is an explicit interface implementation.
7303 2002-09-17 Martin Baulig <martin@gnome.org>
7305 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
7306 different `IndexerName' attributes.
7308 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
7309 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
7310 virtual CommonResolve().
7312 2002-09-16 Miguel de Icaza <miguel@ximian.com>
7314 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
7315 and convert that to the UnderlyingType.
7317 * statement.cs (Foreach.Resolve): Indexers are just like variables
7318 or PropertyAccesses.
7320 * cs-tokenizer.cs (consume_string): Track line numbers and columns
7321 inside quoted strings, we were not doing this before.
7323 2002-09-16 Martin Baulig <martin@gnome.org>
7325 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
7326 resolve it. This is needed for the definite assignment check of the
7327 instance expression, fixes bug #29846.
7328 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
7330 2002-09-16 Nick Drochak <ndrochak@gol.com>
7332 * parameter.cs: Fix compile error. Cannot reference static member
7333 from an instance object. Is this an mcs bug?
7335 2002-09-14 Martin Baulig <martin@gnome.org>
7337 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
7338 multiple times. Fixes bug #30295, added test-166.cs.
7340 2002-09-14 Martin Baulig <martin@gnome.org>
7342 * statement.cs (Block.Emit): Don't emit unreachable code.
7343 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
7345 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
7347 2002-09-14 Martin Baulig <martin@gnome.org>
7349 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
7352 2002-09-14 Martin Baulig <martin@gnome.org>
7354 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
7355 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
7356 be false on the ms runtime.
7358 2002-09-13 Martin Baulig <martin@gnome.org>
7360 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
7361 the CS0038 error message.
7363 2002-09-12 Miguel de Icaza <miguel@ximian.com>
7365 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
7366 constant inside, return it.
7368 2002-09-12 Martin Baulig <martin@gnome.org>
7370 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
7371 implicit conversion can be done between enum types.
7373 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
7374 check whether an implicit conversion to the current enum's UnderlyingType
7375 exists and report an error if not.
7377 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
7378 without debugging support.
7380 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
7381 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
7383 2002-09-12 Martin Baulig <martin@gnome.org>
7385 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
7387 * ecore.cs (IMemberExpr.DeclaringType): New property.
7388 (SimpleName.SimpleNameResolve): Check whether we're accessing a
7389 nonstatic member of an outer type (CS0038).
7391 2002-09-11 Miguel de Icaza <miguel@ximian.com>
7393 * driver.cs: Activate the using-error detector at warning level
7394 4 (at least for MS-compatible APIs).
7396 * namespace.cs (VerifyUsing): Small buglett fix.
7398 * pending.cs (PendingImplementation): pass the container pointer.
7400 * interface.cs (GetMethods): Allow for recursive definition. Long
7401 term, I would like to move every type to support recursive
7402 definitions, not the current ordering mechanism that we have right
7405 The situation is this: Attributes are handled before interfaces,
7406 so we can apply attributes to interfaces. But some attributes
7407 implement interfaces, we will now handle the simple cases
7408 (recursive definitions will just get an error).
7410 * parameter.cs: Only invalidate types at the end if we fail to
7413 2002-09-09 Martin Baulig <martin@gnome.org>
7415 * ecore.cs (PropertyExpr.Emit): Also check for
7416 TypeManager.system_int_array_get_length so this'll also work when
7417 compiling corlib. Fixes #30003.
7419 2002-09-09 Martin Baulig <martin@gnome.org>
7421 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
7422 and throw an exception if we can't get the type's size. Fixed #30040,
7425 2002-09-09 Martin Baulig <martin@gnome.org>
7427 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
7429 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
7430 context. Fixes bug #30027.
7432 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
7433 virtual functions. Fixes bug #30043, added test-164.cs.
7435 2002-09-08 Ravi Pratap <ravi@ximian.com>
7437 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
7439 2002-09-08 Nick Drochak <ndrochak@gol.com>
7441 * driver.cs: Use an object to get the windows codepage since it's not a
7444 2002-09-08 Miguel de Icaza <miguel@ximian.com>
7446 * statement.cs (For.Emit): for infinite loops (test == null)
7447 return whether there is a break inside, not always "true".
7449 * namespace.cs (UsingEntry): New struct to hold the name of the
7450 using definition, the location where it is defined, and whether it
7451 has been used in a successful type lookup.
7453 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
7458 2002-09-06 Ravi Pratap <ravi@ximian.com>
7460 * attribute.cs : Fix incorrect code which relied on catching
7461 a NullReferenceException to detect a null being passed in
7462 where an object was expected.
7464 2002-09-06 Miguel de Icaza <miguel@ximian.com>
7466 * statement.cs (Try): flag the catch variable as assigned
7468 * expression.cs (Cast): Simplified by using ResolveType instead of
7471 * statement.cs (Catch): Fix bug by using ResolveType.
7473 2002-09-06 Ravi Pratap <ravi@ximian.com>
7475 * expression.cs (BetterConversion): Special case for when we have
7476 a NullLiteral as the argument and we have to choose between string
7477 and object types - we choose string the way csc does.
7479 * attribute.cs (Attribute.Resolve): Catch the
7480 NullReferenceException and report error #182 since the Mono
7481 runtime no more has the bug and having this exception raised means
7482 we tried to select a constructor which takes an object and is
7485 2002-09-05 Ravi Pratap <ravi@ximian.com>
7487 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
7488 message (1502, 1503) when we can't locate a method after overload
7489 resolution. This is much more informative and closes the bug
7492 * interface.cs (PopulateMethod): Return if there are no argument
7493 types. Fixes a NullReferenceException bug.
7495 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
7496 expressions too. Previously we were checking only in one place for
7497 positional arguments leaving out named arguments.
7499 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
7500 type to the enum type is not allowed. Remove code corresponding to
7503 (ConvertNumericExplicit): Allow explicit conversions from
7504 the underlying type to enum type. This precisely follows the spec
7505 and closes a bug filed by Gonzalo.
7507 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7510 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
7512 2002-09-03 Miguel de Icaza <miguel@ximian.com>
7514 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
7515 it was important that we stored the right value after the
7516 reduction in `converted'.
7518 2002-09-04 Martin Baulig <martin@gnome.org>
7520 * location.cs (Location.SymbolDocument): Use full pathnames for the
7523 2002-08-30 Miguel de Icaza <miguel@ximian.com>
7525 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
7526 of the expression resolve mechanism, because that will catch the
7527 SimpleName error failures.
7529 (Conditional): If we can not resolve the
7530 expression, return, do not crash.
7532 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7535 (location): display token name instead of its number.
7537 2002-08-28 Martin Baulig <martin@gnome.org>
7539 * expression.cs (Binary.ResolveOperator): Don't silently return
7540 but return an error if an operator cannot be applied between two
7543 2002-08-28 Martin Baulig <martin@gnome.org>
7545 * class.cs (Constructor.Define): Set the permission attributes
7546 correctly instead of making all constructors public.
7548 2002-08-28 Martin Baulig <martin@gnome.org>
7550 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
7551 for private members before reporting a CS0103; if we find anything,
7554 2002-08-28 Martin Baulig <martin@gnome.org>
7556 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
7557 to check whether `closure_start_type == closure_invocation_type',
7558 we also need to check whether `m.DeclaringType == closure_invocation_type'
7559 before bypassing the permission checks. We might be accessing
7560 protected/private members from the base class.
7561 (TypeManager.RealMemberLookup): Only set private_ok if private
7562 members were requested via BindingFlags.NonPublic.
7564 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
7566 * expression.cs (MemberAccess.ResolveMemberAccess): Set
7567 MethodGroupExpr.IsExplicitImpl if appropriate.
7568 (Invocation.DoResolve): Don't report the CS0120 for explicit
7569 interface implementations.
7571 2002-08-27 Martin Baulig <martin@gnome.org>
7573 * expression.cs (Invocation.DoResolve): If this is a static
7574 method and we don't have an InstanceExpression, we must report
7577 2002-08-25 Martin Baulig <martin@gnome.org>
7579 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
7580 `==' between a valuetype and an object.
7582 2002-08-25 Miguel de Icaza <miguel@ximian.com>
7584 * ecore.cs (TypeExpr): Provide a ToString method.
7586 2002-08-24 Martin Baulig <martin@gnome.org>
7588 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
7589 now called proggie.dbg and it's a binary file.
7591 2002-08-23 Martin Baulig <martin@gnome.org>
7593 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
7595 2002-08-23 Martin Baulig <martin@gnome.org>
7597 * struct.cs (MyStructInfo.ctor): Make this work with empty
7598 structs; it's not allowed to use foreach() on null.
7600 2002-08-23 Martin Baulig <martin@gnome.org>
7602 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
7603 writer the full pathname of the generated assembly.
7605 2002-08-23 Martin Baulig <martin@gnome.org>
7607 * statements.cs (FlowBranching.UsageVector.MergeChildren):
7608 A `finally' block never returns or breaks; improved handling of
7611 2002-08-23 Martin Baulig <martin@gnome.org>
7613 * statement.cs (Throw.Resolve): Allow `throw null'.
7615 2002-08-23 Martin Baulig <martin@gnome.org>
7617 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
7618 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
7619 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
7620 MemberLookup would return a wrong event if this is an explicit
7621 interface implementation and the class has an event with the same
7624 2002-08-23 Martin Baulig <martin@gnome.org>
7626 * statement.cs (Block.AddChildVariableNames): New public method.
7627 (Block.AddChildVariableName): Likewise.
7628 (Block.IsVariableNameUsedInChildBlock): Likewise.
7629 (Block.AddVariable): Check whether a variable name has already
7630 been used in a child block.
7632 * cs-parser.jay (declare_local_variables): Mark all variable names
7633 from the current block as being used in a child block in the
7636 2002-08-23 Martin Baulig <martin@gnome.org>
7638 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
7639 find the symbol writer.
7641 * driver.cs: csc also allows the arguments to /define being
7642 separated by commas, not only by semicolons.
7644 2002-08-23 Martin Baulig <martin@gnome.org>
7646 * interface.cs (Interface.GetMembers): Added static check for events.
7648 2002-08-15 Martin Baulig <martin@gnome.org>
7650 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
7651 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
7653 * ecore.cs (Expression.MemberLookup): Added documentation and explained
7654 why the MethodData.EmitDestructor() change was necessary.
7656 2002-08-20 Martin Baulig <martin@gnome.org>
7658 * class.cs (TypeContainer.FindMembers): Added static check for events.
7660 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
7662 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
7663 use Type.GetEvents(), not Type.FindMembers().
7665 2002-08-20 Martin Baulig <martin@gnome.org>
7667 * decl.cs (MemberCache): Added a special method cache which will
7668 be used for method-only searched. This ensures that a method
7669 search will return a MethodInfo with the correct ReflectedType for
7672 2002-08-20 Martin Baulig <martin@gnome.org>
7674 * decl.cs (DeclSpace.FindMembers): Made this public.
7676 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7678 * delegate.cs: fixed build on windows.
7679 [FIXME: Filed as bug #29150: MCS must report these errors.]
7681 2002-08-19 Ravi Pratap <ravi@ximian.com>
7683 * ecore.cs (StandardConversionExists): Return a false
7684 if we are trying to convert the void type to anything else
7685 since that is not allowed.
7687 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
7688 we flag error 70 in the event an event is trying to be accessed
7689 directly from outside the declaring type.
7691 2002-08-20 Martin Baulig <martin@gnome.org>
7693 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
7694 MemberCache from typemanager.cs to decl.cs.
7696 2002-08-19 Martin Baulig <martin@gnome.org>
7698 * class.cs (TypeContainer): Implement IMemberContainer.
7699 (TypeContainer.DefineMembers): Create the MemberCache.
7700 (TypeContainer.FindMembers): Do better BindingFlags checking; only
7701 return public members if BindingFlags.Public was given, check
7702 whether members are static.
7704 2002-08-16 Martin Baulig <martin@gnome.org>
7706 * decl.cs (DeclSpace.Define): Splitted this in Define and
7707 DefineMembers. DefineMembers is called first and initializes the
7710 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
7711 DefineMembers() on all our DeclSpaces.
7713 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
7714 but call DefineMembers() on all nested interfaces. We call their
7715 Define() in our new Define() function.
7717 * interface.cs (Interface): Implement IMemberContainer.
7718 (Interface.Define): Moved all code except the attribute stuf to
7720 (Interface.DefineMembers): Initialize the member cache.
7722 * typemanager.cs (IMemberFinder): Removed this interface, we don't
7723 need this anymore since we can use MemberCache.FindMembers directly.
7725 2002-08-19 Martin Baulig <martin@gnome.org>
7727 * typemanager.cs (MemberCache): When creating the cache for an
7728 interface type, add all inherited members.
7729 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
7730 to `out bool used_cache' and documented it.
7731 (TypeManager.MemberLookup): If we already used the cache in the first
7732 iteration, we don't need to do the interfaces check.
7734 2002-08-19 Martin Baulig <martin@gnome.org>
7736 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
7737 here from IMemberFinder and don't implement this interface anymore.
7738 (DeclSpace.MemberCache): Moved here from IMemberFinder.
7740 * typemanager.cs (IMemberFinder): This interface is now only used by
7741 classes which actually support the member cache.
7742 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
7743 since we only put DeclSpaces into this Hashtable.
7744 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
7745 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
7747 2002-08-16 Martin Baulig <martin@gnome.org>
7749 * typemanager.cs (ICachingMemberFinder): Removed.
7750 (IMemberFinder.MemberCache): New property.
7751 (TypeManager.FindMembers): Merged this with RealFindMembers().
7752 This function will never be called from TypeManager.MemberLookup()
7753 so we can't use the cache here, just the IMemberFinder.
7754 (TypeManager.MemberLookup_FindMembers): Check whether the
7755 IMemberFinder has a MemberCache and call the cache's FindMembers
7757 (MemberCache): Rewrote larger parts of this yet another time and
7758 cleaned it up a bit.
7760 2002-08-15 Miguel de Icaza <miguel@ximian.com>
7762 * driver.cs (LoadArgs): Support quoting.
7764 (Usage): Show the CSC-like command line arguments.
7766 Improved a few error messages.
7768 2002-08-15 Martin Baulig <martin@gnome.org>
7770 * typemanager.cs (IMemberContainer.Type): New property.
7771 (IMemberContainer.IsInterface): New property.
7773 The following changes are conditional to BROKEN_RUNTIME, which is
7774 defined at the top of the file.
7776 * typemanager.cs (MemberCache.MemberCache): Don't add the base
7777 class'es members, but add all members from TypeHandle.ObjectType
7778 if we're an interface.
7779 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
7780 is the current type.
7781 (MemberCache.CacheEntry.Container): Removed this field.
7782 (TypeHandle.GetMembers): Include inherited members.
7784 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7786 * typemanager.cs: fixed compilation and added a comment on a field that
7789 2002-08-15 Martin Baulig <martin@gnome.org>
7791 * class.cs (ConstructorInitializer.Resolve): In the
7792 Expression.MemberLookup call, use the queried_type as
7795 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
7796 declared' attribute, it's always true.
7797 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
7798 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
7799 temporary wrapper for FindMembers which tells MemberLookup whether
7800 members from the base classes are included in the return value.
7801 This will go away soon.
7802 (TypeManager.MemberLookup): Use this temporary hack here; once the
7803 new MemberCache is completed, we don't need to do the DeclaredOnly
7804 looping here anymore since the MemberCache will take care of this.
7805 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
7806 (MemberCache): When creating the MemberCache for a class, get
7807 members from the current class and all its base classes.
7808 (MemberCache.CacheEntry.Container): New field. This is a
7809 temporary hack until the Mono runtime is fixed to distinguish
7810 between ReflectedType and DeclaringType. It allows us to use MCS
7811 with both the MS runtime and the unfixed Mono runtime without
7812 problems and without accecting performance.
7813 (MemberCache.SearchMembers): The DeclaredOnly looping from
7814 TypeManager.MemberLookup is now done here.
7816 2002-08-14 Martin Baulig <martin@gnome.org>
7818 * statement.cs (MyStructInfo.MyStructInfo): Don't call
7819 Type.GetFields on dynamic types but get the fields from the
7820 corresponding TypeContainer.
7821 (MyStructInfo.GetStructInfo): Added check for enum types.
7823 * typemanager.cs (MemberList.IsSynchronized): Implemented.
7824 (MemberList.SyncRoot): Implemented.
7825 (TypeManager.FilterWithClosure): No need to check permissions if
7826 closure_start_type == closure_invocation_type, don't crash if
7827 closure_invocation_type is null.
7829 2002-08-13 Martin Baulig <martin@gnome.org>
7831 Rewrote TypeContainer.FindMembers to use a member cache. This
7832 gives us a speed increase of about 35% for the self-hosting MCS
7833 build and of about 15-20% for the class libs (both on GNU/Linux).
7835 * report.cs (Timer): New class to get enhanced profiling. This
7836 whole class is "TIMER" conditional since it remarkably slows down
7839 * class.cs (MemberList): New class. This is an IList wrapper
7840 which we're now using instead of passing MemberInfo[]'s around to
7841 avoid copying this array unnecessarily.
7842 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
7843 (ICachingMemberFinder, IMemberContainer): New interface.
7844 (TypeManager.FilterWithClosure): If `criteria' is null, the name
7845 has already been checked, otherwise use it for the name comparision.
7846 (TypeManager.FindMembers): Renamed to RealMemberFinder and
7847 provided wrapper which tries to use ICachingMemberFinder.FindMembers
7848 if possible. Returns a MemberList, not a MemberInfo [].
7849 (TypeHandle): New class, implements IMemberContainer. We create
7850 one instance of this class per type, it contains a MemberCache
7851 which is used to do the member lookups.
7852 (MemberCache): New class. Each instance of this class contains
7853 all members of a type and a name-based hash table.
7854 (MemberCache.FindMembers): This is our new member lookup
7855 function. First, it looks up all members of the requested name in
7856 the hash table. Then, it walks this list and sorts out all
7857 applicable members and returns them.
7859 2002-08-13 Martin Baulig <martin@gnome.org>
7861 In addition to a nice code cleanup, this gives us a performance
7862 increase of about 1.4% on GNU/Linux - not much, but it's already
7863 half a second for the self-hosting MCS compilation.
7865 * typemanager.cs (IMemberFinder): New interface. It is used by
7866 TypeManager.FindMembers to call FindMembers on a TypeContainer,
7867 Enum, Delegate or Interface.
7868 (TypeManager.finder_to_member_finder): New PtrHashtable.
7869 (TypeManager.finder_to_container): Removed.
7870 (TypeManager.finder_to_delegate): Removed.
7871 (TypeManager.finder_to_interface): Removed.
7872 (TypeManager.finder_to_enum): Removed.
7874 * interface.cs (Interface): Implement IMemberFinder.
7876 * delegate.cs (Delegate): Implement IMemberFinder.
7878 * enum.cs (Enum): Implement IMemberFinder.
7880 * class.cs (TypeContainer): Implement IMemberFinder.
7882 2002-08-12 Martin Baulig <martin@gnome.org>
7884 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
7886 2002-08-12 Martin Baulig <martin@gnome.org>
7888 * ecore.cs (ITypeExpression): New interface for expressions which
7890 (TypeExpression): Renamed to TypeLookupExpression.
7891 (Expression.DoResolve): If we're doing a types-only lookup, the
7892 expression must implement the ITypeExpression interface and we
7893 call DoResolveType() on it.
7894 (SimpleName): Implement the new ITypeExpression interface.
7895 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
7896 hack, the situation that we're only looking up types can't happen
7897 anymore when this method is called. Moved the type lookup code to
7898 DoResolveType() and call it.
7899 (SimpleName.DoResolveType): This ITypeExpression interface method
7900 is now doing the types-only lookup.
7901 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
7902 (ResolveFlags): Added MaskExprClass.
7904 * expression.cs (MemberAccess): Implement the ITypeExpression
7906 (MemberAccess.DoResolve): Added support for a types-only lookup
7907 when we're called via ITypeExpression.DoResolveType().
7908 (ComposedCast): Implement the ITypeExpression interface.
7910 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
7911 Expression.Resolve() with ResolveFlags.Type instead.
7913 2002-08-12 Martin Baulig <martin@gnome.org>
7915 * interface.cs (Interface.Define): Apply attributes.
7917 * attribute.cs (Attribute.ApplyAttributes): Added support for
7918 interface attributes.
7920 2002-08-11 Martin Baulig <martin@gnome.org>
7922 * statement.cs (Block.Emit): Only check the "this" variable if we
7923 do not always throw an exception.
7925 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
7926 whether the property has a set accessor.
7928 2002-08-11 Martin Baulig <martin@gnome.org>
7930 Added control flow analysis support for structs.
7932 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
7933 with control flow analysis turned off.
7934 (IVariable): New interface.
7935 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
7936 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
7937 (FieldExpr.DoResolve): Resolve the instance expression with flow
7938 analysis turned off and do the definite assignment check after the
7939 resolving when we know what the expression will resolve to.
7941 * expression.cs (LocalVariableReference, ParameterReference):
7942 Implement the new IVariable interface, only call the flow analysis
7943 code if ec.DoFlowAnalysis is true.
7944 (This): Added constructor which takes a Block argument. Implement
7945 the new IVariable interface.
7946 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
7947 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
7948 This does the definite assignment checks for struct members.
7950 * class.cs (Constructor.Emit): If this is a non-static `struct'
7951 constructor which doesn't have any initializer, call
7952 Block.AddThisVariable() to tell the flow analysis code that all
7953 struct elements must be initialized before control returns from
7956 * statement.cs (MyStructInfo): New public class.
7957 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
7958 argument to this indexer. If non-zero, check an individual struct
7959 member, not the whole struct.
7960 (FlowBranching.CheckOutParameters): Check struct members.
7961 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
7962 overloaded versions of these methods which take an additional
7963 `int field_idx' argument to check struct members.
7964 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
7965 overloaded versions of these methods which take an additional
7966 `string field_name' argument to check struct member.s
7967 (VariableInfo): Implement the IVariable interface.
7968 (VariableInfo.StructInfo): New public property. Returns the
7969 MyStructInfo instance of the variable if it's a struct or null.
7970 (Block.AddThisVariable): New public method. This is called from
7971 Constructor.Emit() for non-static `struct' constructor which do
7972 not have any initializer. It creates a special variable for the
7973 "this" instance variable which will be checked by the flow
7974 analysis code to ensure that all of the struct's fields are
7975 initialized before control returns from the constructor.
7976 (UsageVector): Added support for struct members. If a
7977 variable/parameter is a struct with N members, we reserve a slot
7978 in the usage vector for each member. A struct is considered fully
7979 initialized if either the struct itself (slot 0) or all its
7980 members are initialized.
7982 2002-08-08 Martin Baulig <martin@gnome.org>
7984 * driver.cs (Driver.MainDriver): Only report an error CS5001
7985 if there were no compilation errors.
7987 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
7988 `UnsafeContext' property to determine whether the parent is in
7989 unsafe context rather than checking the parent's ModFlags:
7990 classes nested in an unsafe class are unsafe as well.
7992 2002-08-08 Martin Baulig <martin@gnome.org>
7994 * statement.cs (UsageVector.MergeChildren): Distinguish between
7995 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
7996 we return. Added test17() and test18() to test-154.cs.
7998 2002-08-08 Martin Baulig <martin@gnome.org>
8000 * typemanager.cs (TypeManager.FilterWithClosure): If we have
8001 Family access, make sure the invoking type isn't a subclass of the
8002 queried type (that'd be a CS1540).
8004 * ecore.cs (Expression.MemberLookup): Added overloaded version of
8005 this method which takes an additional `Type invocation_type'.
8007 * expression.cs (BaseAccess.DoResolve): Use the base type as
8008 invocation and query type.
8009 (MemberAccess.DoResolve): If the lookup failed and we're about to
8010 report a CS0122, try a lookup with the ec.ContainerType - if this
8011 succeeds, we must report a CS1540.
8013 2002-08-08 Martin Baulig <martin@gnome.org>
8015 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
8016 (MethodGroupExpr): Implement the IMemberExpr interface.
8018 * expression (MemberAccess.ResolveMemberAccess): No need to have
8019 any special code for MethodGroupExprs anymore, they're now
8022 2002-08-08 Martin Baulig <martin@gnome.org>
8024 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
8025 Family, FamANDAssem and FamORAssem permissions.
8026 (TypeManager.IsSubclassOrNestedChildOf): New public method.
8028 2002-08-08 Martin Baulig <martin@gnome.org>
8030 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
8031 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
8034 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
8036 * driver.cs: implemented /resource option to embed managed resources.
8038 2002-08-07 Martin Baulig <martin@gnome.org>
8040 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
8041 (FieldBase.HasFieldInitializer): New public property.
8042 (FieldBase.GetInitializerExpression): New public method. Resolves and
8043 returns the field initializer and makes sure it is only resolved once.
8044 (TypeContainer.EmitFieldInitializers): Call
8045 FieldBase.GetInitializerExpression to get the initializer, this ensures
8046 that it isn't resolved multiple times.
8048 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
8049 the resolving process (SimpleName/MemberLookup) that we're currently
8050 emitting a field initializer (which must not access any instance members,
8051 this is an error CS0236).
8053 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
8054 argument, if the `IsFieldInitializer' flag is set, we must report and
8055 error CS0236 and not an error CS0120.
8057 2002-08-07 Martin Baulig <martin@gnome.org>
8059 * ecore.cs (IMemberExpr): New public interface.
8060 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
8061 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
8062 if the expression is an IMemberExpr.
8064 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
8065 to be null, implicitly default to `this' if we're non-static in
8066 this case. Simplified the code a lot by using the new IMemberExpr
8067 interface. Also fixed bug #28176 here.
8069 2002-08-06 Martin Baulig <martin@gnome.org>
8071 * cs-parser.jay (SimpleLookup): Removed. We need to create
8072 ParameterReferences during semantic analysis so that we can do a
8073 type-only search when resolving Cast, TypeOf and SizeOf.
8074 (block): Pass the `current_local_parameters' to the Block's
8077 * class.cs (ConstructorInitializer): Added `Parameters parameters'
8078 argument to the constructor.
8079 (ConstructorInitializer.Resolve): Create a temporary implicit
8080 block with the parameters.
8082 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
8083 references here if we aren't doing a type-only search.
8085 * statement.cs (Block): Added constructor which takes a
8086 `Parameters parameters' argument.
8087 (Block.Parameters): New public property.
8089 * support.cs (InternalParameters.Parameters): Renamed `parameters'
8090 to `Parameters' and made it public readonly.
8092 2002-08-06 Martin Baulig <martin@gnome.org>
8094 * ecore.cs (Expression.Warning): Made this public as well.
8096 * report.cs (Report.Debug): Print the contents of collections.
8098 2002-08-06 Martin Baulig <martin@gnome.org>
8100 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
8101 used to tell Resolve() which kinds of expressions it may return.
8102 (Expression.Resolve): Added overloaded version of this method which
8103 takes a `ResolveFlags flags' argument. This can be used to tell
8104 Resolve() which kinds of expressions it may return. Reports a
8106 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
8107 ResolveFlags.SimpleName.
8108 (Expression.Error118): Added overloaded version of this method which
8109 takes a `ResolveFlags flags' argument. It uses the flags to determine
8110 which kinds of expressions are allowed.
8112 * expression.cs (Argument.ResolveMethodGroup): New public method.
8113 Resolves an argument, but allows a MethodGroup to be returned.
8114 This is used when invoking a delegate.
8116 * TODO: Updated a bit.
8118 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8120 Fixed compilation with csc.
8122 * ecore.cs: Expression.Error made public. Is this correct? Should
8123 Warning be made public too?
8125 * expression.cs: use ea.Location instead of ea.loc.
8126 [FIXME: Filed as bug #28607: MCS must report these errors.]
8128 2002-08-06 Martin Baulig <martin@gnome.org>
8130 * ecore.cs (Expression.loc): Moved the location here instead of
8131 duplicating it in all derived classes.
8132 (Expression.Location): New public property.
8133 (Expression.Error, Expression.Warning): Made them non-static and
8134 removed the location argument.
8135 (Expression.Warning): Added overloaded version which takes an
8136 `int level' argument.
8137 (Expression.Error118): Make this non-static and removed the
8138 expression and location arguments.
8139 (TypeExpr): Added location argument to the constructor.
8141 * expression.cs (StaticCallExpr): Added location argument to
8143 (Indirection, PointerArithmetic): Likewise.
8144 (CheckedExpr, UnCheckedExpr): Likewise.
8145 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
8146 (StringPtr): Likewise.
8149 2002-08-05 Martin Baulig <martin@gnome.org>
8151 * expression.cs (BaseAccess.DoResolve): Actually report errors.
8153 * assign.cs (Assign.DoResolve): Check whether the source
8154 expression is a value or variable.
8156 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
8157 while resolving the corresponding blocks.
8159 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
8160 an error, don't silently return null.
8162 * statement.cs (Block.AddVariable): Do the error reporting here
8163 and distinguish between CS0128 and CS0136.
8164 (Block.DoResolve): Report all unused labels (warning CS0164).
8165 (LabeledStatement): Pass the location to the constructor.
8166 (LabeledStatement.HasBeenReferenced): New property.
8167 (LabeledStatement.Resolve): Set it to true here.
8169 * statement.cs (Return.Emit): Return success even after reporting
8170 a type mismatch error (CS0126 or CS0127), this is what csc does and
8171 it avoids confusing the users with any consecutive errors.
8173 2002-08-05 Martin Baulig <martin@gnome.org>
8175 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
8177 * const.cs (Const.LookupConstantValue): Catch circular definitions.
8179 * expression.cs (MemberAccess.DoResolve): Silently return if an
8180 error has already been reported.
8182 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
8183 error has already been reported.
8185 2002-08-05 Martin Baulig <martin@gnome.org>
8187 * statement.cs (UsageVector): Only initialize the `parameters'
8188 vector if we actually have any "out" parameters.
8190 2002-08-05 Martin Baulig <martin@gnome.org>
8192 * expression.cs (Binary.ResolveOperator): When combining delegates,
8193 they must have the same type.
8195 2002-08-05 Martin Baulig <martin@gnome.org>
8197 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
8198 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
8199 work with the ms runtime and we also don't need it: if we're a
8200 PropertyBuilder and not in the `indexer_arguments' hash, then we
8201 are a property and not an indexer.
8203 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
8204 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
8205 since the latter one doesn't work with the ms runtime.
8207 2002-08-03 Martin Baulig <martin@gnome.org>
8209 Fixed bugs #27998 and #22735.
8211 * class.cs (Method.IsOperator): New public field.
8212 (Method.CheckBase): Report CS0111 if there's already a method
8213 with the same parameters in the current class. Report CS0508 when
8214 attempting to change the return type of an inherited method.
8215 (MethodData.Emit): Report CS0179 if a method doesn't have a body
8216 and it's not marked abstract or extern.
8217 (PropertyBase): New abstract base class for Property and Indexer.
8218 (PropertyBase.CheckBase): Moved here from Property and made it work
8220 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
8221 the same so we can reuse it there.
8222 (Property, Indexer): Derive from PropertyBase.
8223 (MethodSignature.inheritable_property_signature_filter): New delegate
8224 to find properties and indexers.
8226 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
8227 argument and improved error reporting.
8229 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
8230 EmptyReadOnlyParameters and made it a property.
8232 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
8233 version of this method which takes a `PropertyInfo indexer'.
8234 (TypeManager.RegisterIndexer): New method.
8236 * class.cs: Added myself as author of this file :-)
8238 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8240 * class.cs: fixed compilation on windoze.
8242 2002-08-03 Martin Baulig <martin@gnome.org>
8244 * interface.cs (Interface.GetInterfaceBases): Check whether all
8245 base interfaces are at least as accessible than the current one.
8247 * class.cs (TypeContainer.GetClassBases): Check whether base types
8248 are at least as accessible than the current type.
8249 (TypeContainer.AsAccessible): Implemented and made non-static.
8250 (MemberBase.CheckParameters): Report errors if the accessibility
8253 * delegate.cs (Delegate.Delegate): The default visibility is
8254 internal for top-level types and private for nested types.
8255 (Delegate.Define): Report errors if the accessibility checks fail.
8257 * enum.cs (Enum.Enum): The default visibility is internal for
8258 top-level types and private for nested types.
8259 (Enum.DefineType): Compute the correct visibility.
8261 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
8262 function which takes a `bool is_toplevel' instead of a TypeContainer.
8264 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
8267 2002-08-02 Martin Baulig <martin@gnome.org>
8269 * expression.cs (LocalVariableReferenc): Added constructor which
8270 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
8271 (LocalVariableReference.IsReadOnly): New property.
8272 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
8273 variable is readonly, use our own readonly flag to do this; you can
8274 use the new constructor to get a writable reference to a read-only
8277 * cs-parser.jay (foreach_statement, using_statement): Get a writable
8278 reference to the local variable.
8280 2002-08-01 Miguel de Icaza <miguel@ximian.com>
8282 * rootcontext.cs (ResolveCore): Also include System.Exception
8284 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
8285 we reach an EmptyStatement.
8287 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
8290 * expression.cs (Binary.ResolveOperator): Check error result in
8293 use brtrue/brfalse directly and avoid compares to null.
8295 2002-08-02 Martin Baulig <martin@gnome.org>
8297 * class.cs (TypeContainer.Define): Define all nested interfaces here.
8298 Fixes bug #28407, added test-155.cs.
8300 2002-08-01 Martin Baulig <martin@gnome.org>
8302 * class.cs (Event.EmitDefaultMethod): Make this work with static
8303 events. Fixes #28311, added verify-3.cs.
8305 2002-08-01 Martin Baulig <martin@gnome.org>
8307 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
8308 `is_disposable' fields.
8309 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
8310 `hm.is_disposable' if we're using the collection pattern.
8311 (Foreach.EmitCollectionForeach): Use the correct type for the
8312 enumerator's local variable, only emit the try/finally block if
8313 necessary (fixes #27713).
8315 2002-08-01 Martin Baulig <martin@gnome.org>
8317 * ecore.cs (Expression.report118): Renamed to Error118 and made
8320 * statement.cs (Throw.Resolve): Check whether the expression is of
8321 the correct type (CS0118) and whether the type derives from
8322 System.Exception (CS0155).
8323 (Catch.Resolve): New method. Do the type lookup here and check
8324 whether it derives from System.Exception (CS0155).
8325 (Catch.CatchType, Catch.IsGeneral): New public properties.
8327 * typemanager.cs (TypeManager.exception_type): Added.
8329 2002-07-31 Miguel de Icaza <miguel@ximian.com>
8331 * driver.cs: Updated About function.
8333 2002-07-31 Martin Baulig <martin@gnome.org>
8335 Implemented Control Flow Analysis.
8337 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
8338 (EmitContext.CurrentBranching): Added.
8339 (EmitContext.StartFlowBranching): Added.
8340 (EmitContext.EndFlowBranching): Added.
8341 (EmitContext.KillFlowBranching): Added.
8342 (EmitContext.IsVariableAssigned): Added.
8343 (EmitContext.SetVariableAssigned): Added.
8344 (EmitContext.IsParameterAssigned): Added.
8345 (EmitContext.SetParameterAssigned): Added.
8346 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
8347 Added control flow analysis stuff here.
8349 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
8350 resolve the expression as lvalue.
8351 (LocalVariableReference.DoResolve): Check whether the variable has
8352 already been assigned.
8353 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
8354 the parameter as assigned here.
8355 (ParameterReference.DoResolve): Check whether the parameter has already
8357 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
8358 expression as lvalue.
8360 * statement.cs (FlowBranching): New class for the flow analysis code.
8361 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
8362 (LabeledStatement.IsDefined): New public property.
8363 (LabeledStatement.AddUsageVector): New public method to tell flow
8364 analyis that the label may be reached via a forward jump.
8365 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
8367 (VariableInfo.Number): New public field. This is used by flow analysis
8368 to number all locals of a block.
8369 (Block.CountVariables): New public property. This is the number of
8370 local variables in this block (including the locals from all parent
8372 (Block.EmitMeta): Number all the variables.
8374 * statement.cs: Added flow analysis support to all classes.
8376 2002-07-31 Martin Baulig <martin@gnome.org>
8378 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
8379 To get debugging messages, compile mcs with /define:MCS_DEBUG and
8380 then use this argument.
8382 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
8384 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
8385 use this to specify /define options.
8387 2002-07-29 Martin Baulig <martin@gnome.org>
8389 * statement.cs (Fixed): Moved all code that does variable lookups
8390 and resolvings from Emit to Resolve.
8392 * statement.cs (For): Moved all code that does variable lookups
8393 and resolvings from Emit to Resolve.
8395 * statement.cs (Using): Moved all code that does variable lookups
8396 and resolvings from Emit to Resolve.
8398 2002-07-29 Martin Baulig <martin@gnome.org>
8400 * attribute.cs (Attribute.Resolve): Explicitly catch a
8401 System.NullReferenceException when creating the
8402 CustromAttributeBuilder and report a different warning message.
8404 2002-07-29 Martin Baulig <martin@gnome.org>
8406 * support.cs (ParameterData.ParameterName): Added method to
8407 get the name of a parameter.
8409 * typemanager.cs (TypeManager.IsValueType): New public method.
8411 2002-07-29 Martin Baulig <martin@gnome.org>
8413 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
8414 is a flag which specifies that it's either ref or out.
8415 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
8416 the out parameter to `out Parameter.Modifier mod', also set the
8417 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
8419 * support.cs (InternalParameters.ParameterModifier): Distinguish
8420 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
8421 Parameter.Modifier.ISBYREF flag if it's either ref or out.
8423 * expression.cs (Argument.GetParameterModifier): Distinguish
8424 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
8425 Parameter.Modifier.ISBYREF flag if it's either ref or out.
8427 2002-07-29 Martin Baulig <martin@gnome.org>
8429 * expression.cs (ParameterReference.ParameterReference): Added
8430 `Location loc' argument to the constructor.
8432 * cs-parser.jay: Pass location to ParameterReference.
8434 2002-07-28 Miguel de Icaza <miguel@ximian.com>
8436 * statement.cs (Try): Initialize the location.
8438 * cs-parser.jay: pass location to Try.
8440 * expression.cs (Unary.Reduce): Change the prototype to return
8441 whether a constant fold could be performed or not. The result is
8442 returned in an out parameters. In the case of Indirection and
8443 AddressOf, we want to perform the full tests.
8445 2002-07-26 Miguel de Icaza <miguel@ximian.com>
8447 * statement.cs (Statement.Emit): Flag dead code.
8449 2002-07-27 Andrew Birkett <andy@nobugs.org>
8451 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
8453 2002-07-27 Martin Baulig <martin@gnome.org>
8455 * class.cs (MethodData.Define): Put back call to
8456 TypeManager.AddMethod(), accidentally commented this out.
8458 * report.cs (Debug): New public method to print debugging information,
8459 this is `[Conditional ("DEBUG")]'.
8461 2002-07-26 Martin Baulig <martin@gnome.org>
8463 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
8464 (switch_statement): Push the current_block to the switch_stack and
8465 pop it again when we're done with the switch.
8466 (switch_section): The new block is a child of the current_block.
8467 Fixes bug #24007, added test-152.cs.
8469 2002-07-27 Martin Baulig <martin@gnome.org>
8471 * expression.cs (Invocation.EmitArguments): When calling a varargs
8472 function with only its fixed arguments, we need to pass an empty
8475 2002-07-27 Martin Baulig <martin@gnome.org>
8477 Mono 0.13 has been released.
8479 2002-07-25 Miguel de Icaza <miguel@ximian.com>
8481 * driver.cs: Rename --resource to --linkres, because that is what
8482 we do currently, we dont support --resource yet.
8484 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
8486 2002-07-25 Martin Baulig <martin@gnome.org>
8488 * class.cs (MethodData): New public class. This is a `method builder'
8489 class for a method or one accessor of a Property/Indexer/Event.
8490 (MethodData.GetMethodFlags): Moved here from MemberBase.
8491 (MethodData.ApplyAttributes): Likewise.
8492 (MethodData.ApplyObsoleteAttribute): Likewise.
8493 (MethodData.ApplyConditionalAttribute): Likewise.
8494 (MethodData.ApplyDllImportAttribute): Likewise.
8495 (MethodData.CheckAbstractAndExternal): Likewise.
8496 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
8497 (MethodData.Emit): Formerly known as Method.Emit().
8498 (MemberBase): Moved everything which was specific to a single
8499 accessor/method to MethodData.
8500 (Method): Create a new MethodData and call Define() and Emit() on it.
8501 (Property, Indexer, Event): Create a new MethodData objects for each
8502 accessor and call Define() and Emit() on them.
8504 2002-07-25 Martin Baulig <martin@gnome.org>
8506 Made MethodCore derive from MemberBase to reuse the code from there.
8507 MemberBase now also checks for attributes.
8509 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
8510 (MemberBase.GetMethodFlags): Moved here from class Method and marked
8512 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
8513 `CallingConventions cc' and `Attributes opt_attrs' arguments.
8514 (MemberBase.ApplyAttributes): New virtual method; applies the
8515 attributes to a method or accessor.
8516 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
8517 (MemberBase.ApplyConditionalAttribute): Likewise.
8518 (MemberBase.ApplyDllImportAttribute): Likewise.
8519 (MemberBase.CheckAbstractAndExternal): Likewise.
8520 (MethodCore.ParameterTypes): This is now a property instead of a
8521 method, it's initialized from DoDefineParameters().
8522 (MethodCore.ParameterInfo): Removed the set accessor.
8523 (MethodCore.DoDefineParameters): New protected virtual method to
8524 initialize ParameterTypes and ParameterInfo.
8525 (Method.GetReturnType): We can now simply return the MemberType.
8526 (Method.GetMethodFlags): Override the MemberBase version and add
8527 the conditional flags.
8528 (Method.CheckBase): Moved some code from Define() here, call
8529 DoDefineParameters() here.
8530 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
8531 here to avoid some larger code duplication.
8532 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
8533 ensure that abstract and external accessors don't declare a body.
8535 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
8536 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
8537 lookup in the attribute's parent classes, so we need to abort as soon
8538 as we found the first match.
8539 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
8540 the attribute has no arguments.
8542 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
8545 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8547 * cs-parser.jay: reverted previous patch.
8549 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8551 * cs-parser.jay: fixed bug #22119.
8553 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8555 * attribute.cs: fixed compilation. The error was:
8556 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
8557 be assigned to before control leaves the current method."
8558 [FIXME: Filed as bug #28186: MCS must report this error.]
8560 2002-07-25 Martin Baulig <martin@gnome.org>
8562 * attribute.cs (Attribute.Conditional_GetConditionName): New static
8563 method to pull the condition name ouf of a Conditional attribute.
8564 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
8565 the obsolete message and error flag out of an Obsolete attribute.
8567 * class.cs (Method.GetMethodFlags): New public method to get the
8568 TypeManager.MethodFlags for this method.
8569 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
8571 (Method.Define): Get and apply the Obsolete and Conditional attributes;
8572 if we're overriding a virtual function, set the new private variable
8573 `parent_method'; call the new TypeManager.AddMethod().
8575 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
8576 the MethodBuilder and the Method in a PtrHashtable.
8577 (TypeManager.builder_to_method): Added for this purpose.
8578 (TypeManager.MethodFlags): Added IsObsoleteError.
8579 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
8580 Obsolete and Conditional arguments in MethodBuilders. If we discover
8581 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
8582 the message from the attribute.
8584 2002-07-24 Martin Baulig <martin@gnome.org>
8586 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
8587 preprocessor directives, ensure that the argument to #define/#undef is
8588 exactly one identifier and that it's actually an identifier.
8590 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
8593 2002-07-24 Martin Baulig <martin@gnome.org>
8595 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
8596 initialize it to TypeManager.object_type in the constructor.
8597 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
8598 of the `hm.get_current' method if we're using the collection pattern.
8599 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
8600 for the explicit conversion to make it work when we're using the collection
8601 pattern and the `Current' property has a different return type than `object'.
8604 2002-07-24 Martin Baulig <martin@gnome.org>
8606 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
8607 does not match, but don't report any errors. This method is called in
8608 order for all methods in a MethodGroupExpr until a matching method is
8609 found, so we don't want to bail out if the first method doesn't match.
8610 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
8611 matches, report the 123. Fixes #28070.
8613 2002-07-24 Martin Baulig <martin@gnome.org>
8615 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
8616 TypeManager.TypeToCoreType() to the top of the method so the
8617 following equality checks will work. Fixes #28107.
8619 2002-07-24 Martin Baulig <martin@gnome.org>
8621 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
8622 operand is of type uint, and the other operand is of type sbyte,
8623 short or int, the operands are converted to type long." -
8624 Actually do what this comment already told us. Fixes bug #28106,
8627 2002-07-24 Martin Baulig <martin@gnome.org>
8629 * class.cs (MethodBase): New abstract class. This is now a base
8630 class for Property, Indexer and Event to avoid some code duplication
8631 in their Define() and DefineMethods() methods.
8632 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
8633 generic methods for Define() and DefineMethods().
8634 (FieldBase): Derive from MemberBase, not MemberCore.
8635 (Property): Derive from MemberBase, not MemberCore.
8636 (Property.DefineMethod): Moved all the code from this method to the
8637 new MethodBase.DefineAccessor(), just call it with appropriate
8639 (Property.Define): Call the new Property.DoDefine(), this does some
8640 sanity checks and we don't need to duplicate the code everywhere.
8641 (Event): Derive from MemberBase, not MemberCore.
8642 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
8643 accessors, this will also make them work with interface events.
8644 (Indexer): Derive from MemberBase, not MemberCore.
8645 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
8646 (Indexer.Define): Use the new MethodBase functions.
8648 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
8649 argument to the constructor.
8650 (Interface.FindMembers): Added support for interface events.
8651 (Interface.PopluateEvent): Implemented.
8653 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
8655 2002-07-22 Miguel de Icaza <miguel@ximian.com>
8657 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
8658 but this is required to check for a method name being the same as
8659 the containing class.
8663 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8665 * interface.cs: initialize variable.
8667 2002-07-23 Martin Baulig <martin@gnome.org>
8669 Implemented the IndexerName attribute in interfaces.
8671 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
8672 name if this is an explicit interface implementation.
8673 (Indexer.InterfaceIndexerName): New public variable. If we're
8674 implementing an interface indexer, this is the IndexerName in that
8675 interface. Otherwise, it's the IndexerName.
8676 (Indexer.DefineMethod): If we're implementing interface indexer,
8677 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
8678 and Pending.ImplementIndexer methods.
8679 (Indexer.Define): Also define the PropertyBuilder if we're
8680 implementing an interface indexer and this is neither an explicit
8681 interface implementation nor do the IndexerName match the one in
8684 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
8685 If a method is defined here, then we always need to create a proxy
8686 for it. This is used when implementing interface indexers.
8687 (Pending.IsInterfaceIndexer): New public method.
8688 (Pending.ImplementIndexer): New public method.
8689 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
8690 This is used when implementing interface indexers to define a proxy
8692 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
8693 define a proxy if necessary.
8695 * interface.cs (Interface.IndexerName): New public variable.
8696 (Interface.PopulateIndexer): Set the IndexerName.
8697 (Interface.DefineIndexers): New private method. Populate all the
8698 indexers and make sure their IndexerNames match.
8700 * typemanager.cs (IndexerPropertyName): Added support for interface
8703 2002-07-22 Martin Baulig <martin@gnome.org>
8705 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
8706 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
8707 ret if HasReturnLabel.
8708 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
8711 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
8712 and set the ec.LoopBeginTryCatchLevel.
8713 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
8714 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
8715 the current ec.TryCatchLevel, the branch goes out of an exception
8716 block. In this case, we need to use Leave and not Br.
8718 2002-07-22 Martin Baulig <martin@gnome.org>
8720 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
8721 block unless the block does not always return or it is contained in
8722 another try { ... } catch { ... } block. Fixes bug #26506.
8723 Added verify-1.cs to the test suite.
8725 2002-07-22 Martin Baulig <martin@gnome.org>
8727 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
8728 then we do not always return. Fixes bug #24985.
8730 2002-07-22 Martin Baulig <martin@gnome.org>
8732 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
8733 lookup on a per-class level; ie. walk up the class hierarchy until we
8734 found at least one applicable method, then choose the best among them.
8735 Fixes bug #24463 and test-29.cs.
8737 2002-07-22 Martin Baulig <martin@gnome.org>
8739 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
8740 return types of the methods. The return type is not part of the
8741 signature and we must not check it to make the `new' modifier work.
8742 Fixes bug #27999, also added test-147.cs.
8743 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
8745 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
8746 on the method's return type.
8748 2002-07-21 Martin Baulig <martin@gnome.org>
8750 * assign.cs: Make this work if the rightmost source is a constant and
8751 we need to do an implicit type conversion. Also adding a few more tests
8752 to test-38.cs which should have caught this.
8754 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
8755 target in the makefile for this. The makefile.gnu is primarily intended
8756 for end-users who don't want to debug the compiler.
8758 2002-07-21 Martin Baulig <martin@gnome.org>
8760 * assign.cs: Improved the Assign class so it can now handle embedded
8761 assignments (X = Y = Z = something). As a side-effect this'll now also
8762 consume less local variables. test-38.cs now passes with MCS, added
8763 a few new test cases to that test.
8765 2002-07-20 Martin Baulig <martin@gnome.org>
8767 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
8768 instructions. Fixes bug #27977, also added test-146.cs.
8770 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8772 * cs-tokenizer.cs: fixed getHex ().
8774 2002-07-19 Martin Baulig <martin@gnome.org>
8776 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
8777 not Type.GetType() to lookup the array type. This is needed when
8778 we're constructing an array of a user-defined type.
8779 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
8780 single-dimensional arrays, but also for single-dimensial arrays of
8783 2002-07-19 Martin Baulig <martin@gnome.org>
8785 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
8786 this function is called, it's not allowed to share LocalBuilders
8789 2002-07-19 Martin Baulig <martin@gnome.org>
8791 * expression.cs (Argument.Resolve): Report an error 118 when trying
8792 to pass a type as argument.
8794 2002-07-18 Martin Baulig <martin@gnome.org>
8796 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
8797 Conv_R_Un for the signed `long' type.
8799 2002-07-15 Miguel de Icaza <miguel@ximian.com>
8801 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
8802 `expr' for the temporary result, as that will fail if we do
8803 multiple resolves on the same expression.
8805 2002-07-05 Miguel de Icaza <miguel@ximian.com>
8807 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
8808 ec.TypeContainer for looking up aliases.
8810 * class.cs (TypeContainer): Remove LookupAlias from here.
8812 * decl.cs (DeclSpace); Move here.
8814 2002-07-01 Miguel de Icaza <miguel@ximian.com>
8816 * class.cs (FindMembers): Only call filter if the constructor
8817 bulider is not null.
8819 Also handle delegates in `NestedTypes' now. Now we will perform
8820 type lookups using the standard resolution process. This also
8823 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
8824 This uses Expressions (the limited kind that can be parsed by the
8825 tree) instead of strings.
8827 * expression.cs (ComposedCast.ToString): Implement, used to flag
8828 errors since now we have to render expressions.
8830 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
8833 * ecore.cs (SimpleName.ToString): ditto.
8835 * cs-parser.jay: Instead of using strings to assemble types, use
8836 Expressions to assemble the type (using SimpleName, ComposedCast,
8837 MemberAccess). This should fix the type lookups in declarations,
8838 because we were using a different code path for this.
8840 * statement.cs (Block.Resolve): Continue processing statements
8841 even when there is an error.
8843 2002-07-17 Miguel de Icaza <miguel@ximian.com>
8845 * class.cs (Event.Define): Also remove the `remove' method from
8846 the list of pending items.
8848 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
8849 generate more compact code.
8851 2002-07-17 Martin Baulig <martin@gnome.org>
8853 * const.cs (Const.LookupConstantValue): Add support for constant
8854 `unchecked' and `checked' expressions.
8855 Also adding test case test-140.cs for this.
8857 2002-07-17 Martin Baulig <martin@gnome.org>
8859 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
8860 check whether mi.ReturnType implements the IEnumerator interface; the
8861 `==' and the IsAssignableFrom() will fail in this situation.
8863 2002-07-16 Ravi Pratap <ravi@ximian.com>
8865 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
8868 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8870 * expression.cs: fixed bug #27811.
8872 2002-07-14 Miguel de Icaza <miguel@ximian.com>
8874 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
8875 Molaro: when we are a ref, the value already contains a pointer
8876 value, do not take the address of it.
8878 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
8879 * removed mb-parser.jay and mb-tokenizer.cs
8881 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
8883 * expression.cs: check against the building corlib void type.
8885 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
8887 * ecore.cs: fix for valuetype static readonly fields: when
8888 initializing them, we need their address, not the address of a copy.
8890 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
8892 * typemanager.cs: register also enum_type in corlib.
8894 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
8896 * class.cs: allow calling this (but not base) initializers in structs.
8898 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
8900 * ecore.cs: make sure we compare against the building base types
8903 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
8905 * typemanager.cs: fix TypeToCoreType() to handle void and object
8906 (corlib gets no more typerefs after this change).
8908 2002-07-12 Miguel de Icaza <miguel@ximian.com>
8910 * expression.cs (ArrayCreation.EmitArrayArguments): use
8911 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
8913 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
8914 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
8915 array indexes, the runtime actually forbids them.
8917 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
8918 for array arguments here.
8920 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
8921 instead of the default for ValueTypes.
8923 (New.DoEmit): Use IsValueType instead of
8924 IsSubclassOf (value_type)
8925 (New.DoResolve): ditto.
8926 (Invocation.EmitCall): ditto.
8928 * assign.cs (Assign): ditto.
8930 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
8931 Statements *are* currently doing part of their resolution during
8934 Expressions do always resolve during resolve, but statements are
8935 only required to propagate resolution to their children.
8937 2002-07-11 Miguel de Icaza <miguel@ximian.com>
8939 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
8941 (LoadAssembly): Do not add the dll if it is already specified
8943 (MainDriver): Add the System directory to the link path at the end,
8944 after all the other -L arguments.
8946 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
8947 wrong opcode for loading bytes and bools (ldelem.i1 instead of
8948 ldelem.u1) and using the opposite for sbytes.
8950 This fixes Digger, and we can finally run it.
8952 * driver.cs (UnixParseOption): Move the option parsing here.
8953 (CSCParseOption): Implement CSC-like parsing of options.
8955 We now support both modes of operation, the old Unix way, and the
8956 new CSC-like way. This should help those who wanted to make cross
8959 The only thing broken is that /r:, /reference: and /lib: are not
8960 implemented, because I want to make those have the same semantics
8961 as the CSC compiler has, and kill once and for all the confussion
8962 around this. Will be doing this tomorrow.
8964 * statement.cs (Unsafe.Resolve): The state is checked during
8965 resolve, not emit, so we have to set the flags for IsUnsfe here.
8967 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8969 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
8970 not catch the Error_ObjectRefRequired in SimpleName (as it is
8971 possible to have a class/instance variable name that later gets
8972 deambiguated), we have to check this here.
8974 2002-07-10 Ravi Pratap <ravi@ximian.com>
8976 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
8977 make static and put into Expression.
8979 (Event.Define): Register the private field of the event with the
8980 TypeManager so that GetFieldFromEvent can get at it.
8982 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
8983 keep track of the private field associated with an event which
8986 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
8989 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
8991 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8993 * expression.cs (Binary.EmitBranchable): this routine emits the
8994 Binary expression in a branchable context. This basically means:
8995 we need to branch somewhere, not just get the value on the stack.
8997 This works together with Statement.EmitBoolExpression.
8999 * statement.cs (Statement.EmitBoolExpression): Use
9002 2002-07-09 Miguel de Icaza <miguel@ximian.com>
9004 * statement.cs (For): Reduce the number of jumps in loops.
9006 (For): Implement loop inversion for the For statement.
9008 (Break): We can be breaking out of a Try/Catch controlled section
9009 (foreach might have an implicit try/catch clause), so we need to
9010 use Leave instead of Br.
9012 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
9013 now). If the instace expression supports IMemoryLocation, we use
9014 the AddressOf method from the IMemoryLocation to extract the
9015 address instead of emitting the instance.
9017 This showed up with `This', as we were emitting the instance
9018 always (Emit) instead of the Address of This. Particularly
9019 interesting when This is a value type, as we dont want the Emit
9020 effect (which was to load the object).
9022 2002-07-08 Miguel de Icaza <miguel@ximian.com>
9024 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
9026 * statement.cs (Checked): Set the CheckedState during the resolve
9027 process too, as the ConvCast operations track the checked state on
9028 the resolve process, and not emit.
9030 * cs-parser.jay (namespace_member_declaration): Flag that we have
9031 found a declaration when we do. This is used to flag error 1529
9033 * driver.cs: Report ok when we display the help only.
9035 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
9037 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
9039 2002-07-04 Miguel de Icaza <miguel@ximian.com>
9041 * cs-tokenizer.cs (define): We also have to track locally the
9042 defines. AllDefines is just used for the Conditional Attribute,
9043 but we also need the local defines for the current source code.
9045 2002-07-03 Miguel de Icaza <miguel@ximian.com>
9047 * statement.cs (While, For, Do): These loops can exit through a
9048 Break statement, use this information to tell whether the
9049 statement is the last piece of code.
9051 (Break): Flag that we break.
9053 * codegen.cs (EmitContexts): New `Breaks' state variable.
9055 2002-07-03 Martin Baulig <martin@gnome.org>
9057 * class.cs (TypeContainer.MethodModifiersValid): Allow override
9058 modifiers in method declarations in structs. Otherwise, you won't
9059 be able to override things like Object.Equals().
9061 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9063 * class.cs (Method, Property, Indexer): Do not allow the public
9064 modifier to be used in explicit interface implementations.
9066 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
9067 override modifiers in method declarations in structs
9069 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
9071 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
9072 integer or real overflow, report an error
9074 2002-07-02 Martin Baulig <martin@gnome.org>
9076 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
9077 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
9078 to tell the runtime about our newly created System.Object and
9079 System.ValueType types.
9081 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9083 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
9084 struct instead of Ldarg/Starg.
9086 2002-07-02 Martin Baulig <martin@gnome.org>
9088 * expression.cs (Indirection.Indirection): Call
9089 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
9091 2002-07-02 Martin Baulig <martin@gnome.org>
9093 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
9094 ValueType, call TypeManager.TypeToCoreType() on it.
9095 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
9096 the OpCodes.Newarr argument.
9098 2002-07-02 Martin Baulig <martin@gnome.org>
9100 * expression.cs (Invocation.EmitCall): When compiling corlib,
9101 replace all calls to the system's System.Array type to calls to
9102 the newly created one.
9104 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
9105 System.Array methods.
9106 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
9107 from the system's System.Array type which must be replaced.
9109 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
9111 * typemanager.cs: load unverifiable_code_ctor so we can build
9112 corlib using the correct type. Avoid using GetTypeCode() with
9114 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
9115 TypeManager.object_type to allow building corlib.
9117 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
9119 * ecore.cs: handle System.Enum separately in LoadFromPtr().
9121 2002-07-01 Martin Baulig <martin@gnome.org>
9123 * class.cs: Make the last change actually work, we need to check
9124 whether `ifaces != null' to avoid a crash.
9126 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
9128 * class.cs: when we build structs without fields that implement
9129 interfaces, we need to add the interfaces separately, since there is
9130 no API to both set the size and add the interfaces at type creation
9133 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
9135 * expression.cs: the dimension arguments to the array constructors
9136 need to be converted if they are a long.
9138 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
9140 * class.cs: don't emit ldarg.0 if there is no parent constructor
9141 (fixes showstopper for corlib).
9143 2002-06-29 Martin Baulig <martin@gnome.org>
9145 MCS now compiles corlib on GNU/Linux :-)
9147 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
9148 ie. check for MethodImplOptions.InternalCall.
9150 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
9151 and TypeManager.attribute_type are null, so we must explicitly check
9152 whether parent is not null to find out whether it's an attribute type.
9153 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
9154 and SetBuilder, not only if the property is neither abstract nor external.
9155 This is necessary to set the MethodImplOptions on the accessor methods.
9156 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
9157 SetBuilder, see Property.Emit().
9159 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
9160 populate "System.Object", "System.ValueType" and "System.Attribute" since
9161 they've already been populated from BootCorlib_PopulateCoreTypes().
9163 2002-06-29 Martin Baulig <martin@gnome.org>
9165 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
9166 is the NullLiteral, we also need to make sure that target_type is not
9169 2002-06-29 Martin Baulig <martin@gnome.org>
9171 * rootcontext.cs (RootContext.ResolveCore): We must initialize
9172 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
9173 before calling BootstrapCorlib_ResolveDelegate ().
9175 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9177 * statement.cs: fixed build-breaker. All tests passed ok.
9179 2002-06-27 Martin Baulig <martin@gnome.org>
9181 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
9182 for System.Decimal when compiling corlib.
9184 2002-06-27 Martin Baulig <martin@gnome.org>
9186 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
9187 switch blocks which contain nothing but a default clause.
9189 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
9191 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
9193 2002-06-27 Martin Baulig <martin@gnome.org>
9195 * ecore.cs (PropertyExpr.PropertyExpr): Call
9196 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
9198 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
9199 is already a TypeBuilder.
9201 2002-06-27 Martin Baulig <martin@gnome.org>
9203 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
9204 `target_type == TypeManager.array_type', not IsAssignableFrom() in
9205 the "from an array-type to System.Array" case. This makes it work
9206 when compiling corlib.
9208 2002-06-27 Martin Baulig <martin@gnome.org>
9210 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
9211 non-static PropertyExpr, set its InstanceExpression. This makes
9212 the `ICollection.Count' property work in System/Array.cs.
9214 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
9216 * driver.cs: Made error handling more consistent. Errors now
9217 tracked by Report class, so many methods which used to return int
9218 now return void. Main() now prints success/failure and
9219 errors/warnings message.
9221 Renamed '--probe' compiler argument to '--expect-error'. Removed
9222 the magic number return values (123 and 124). Now, if the
9223 expected error occurs, the compiler exits with success (exit value
9224 0). If the compilation completes without seeing that particular
9225 error, the compiler exits with failure (exit value 1). The
9226 makefile in mcs/errors has been changed to handle the new behaviour.
9228 * report.cs: Made 'expected error' number a property and renamed
9229 it from 'Probe' to 'ExpectedError'.
9231 * genericparser.cs: Removed error handling support, since it is
9232 now all done by Report class.
9234 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
9235 class, so parse() no longer returns an int.
9237 * namespace.cs: Use Report.Error instead of GenericParser.error
9239 2002-06-22 Miguel de Icaza <miguel@ximian.com>
9241 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
9242 TypeContainer.AddOperator): At the front of the list put the
9243 explicit implementations, so they get resolved/defined first.
9245 2002-06-21 Miguel de Icaza <miguel@ximian.com>
9247 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
9248 interface type is implemented by this TypeContainer. Used during
9249 explicit interface implementation.
9251 (Property.Define, Indexer.Define, Method.Define): Validate that
9252 the given interface in the explicit implementation is one of the
9253 base classes for the containing type.
9255 Also if we are explicitly implementing an interface, but there is
9256 no match in the pending implementation table, report an error.
9258 (Property.Define): Only define the property if we are
9259 not explicitly implementing a property from an interface. Use the
9260 correct name also for those properties (the same CSC uses,
9261 although that is really not needed).
9263 (Property.Emit): Do not emit attributes for explicitly implemented
9264 properties, as there is no TypeBuilder.
9266 (Indexer.Emit): ditto.
9268 Hiding then means that we do not really *implement* a pending
9269 implementation, which makes code fail.
9271 2002-06-22 Martin Baulig <martin@gnome.org>
9273 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
9274 the return value of Object.GetType(). [FIXME: we need to do this whenever
9275 we get a type back from the reflection library].
9277 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
9279 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
9281 2002-06-20 Miguel de Icaza <miguel@ximian.com>
9283 * attribute.cs: Return null if we can not look up the type.
9285 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
9286 the interface types found.
9288 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
9289 interface types found.
9291 * typemanager.cs (GetInterfaces): Make this routine returns alll
9292 the interfaces and work around the lame differences between
9293 System.Type and System.Reflection.Emit.TypeBuilder in the results
9294 result for GetInterfaces.
9296 (ExpandInterfaces): Given an array of interface types, expand and
9297 eliminate repeated ocurrences of an interface. This expands in
9298 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
9301 2002-06-21 Martin Baulig <martin@gnome.org>
9303 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
9306 2002-06-21 Martin Baulig <martin@gnome.org>
9308 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
9309 and called with one of the core types, return the corresponding typebuilder for
9312 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
9315 2002-06-21 Martin Baulig <martin@gnome.org>
9317 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
9318 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
9319 (Expression.ConvertReferenceExplicit): Likewise.
9321 * expression.cs (ElementAccess.DoResolve): Likewise.
9322 (ElementAccess.DoResolveLValue): Likewise.
9324 2002-06-10 Martin Baulig <martin@gnome.org>
9326 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
9327 add the "value" parameter to the parameter list.
9329 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
9332 2002-06-19 Miguel de Icaza <miguel@ximian.com>
9334 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
9335 the argument to an int, uint, long or ulong, per the spec. Also
9336 catch negative constants in array creation.
9338 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
9340 * class.cs: do not allow the same interface to appear twice in
9341 the definition list.
9343 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
9345 * ecore.cs: don't use ldlen with System.Array.
9347 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
9349 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
9351 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
9353 * modifiers.cs: produce correct field attributes for protected
9354 internal. Easy fix so miguel can work on ther harder stuff:-)
9356 2002-06-18 Miguel de Icaza <miguel@ximian.com>
9358 * pending.cs: New file. Move the code from class.cs here.
9359 Support clearning the pending flag for all methods (when not doing
9360 explicit interface implementation).
9362 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
9364 * rootcontext.cs: added a couple more types needed to bootstrap.
9366 2002-06-17 Miguel de Icaza <miguel@ximian.com>
9368 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
9369 constructor in the type, instead of any constructor in the type
9370 hierarchy. Thanks to Paolo for finding this bug (it showed up as
9371 a bug in the Mono runtime when applying the params attribute).
9373 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
9374 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
9376 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
9378 * expression.cs (Unary.ResolveOperator): Use TypeManager
9379 to resolve the type.
9381 2002-06-13 Ravi Pratap <ravi@ximian.com>
9383 * cs-parser.jay (enum_member_declaration): Pass in the attributes
9386 * enum.cs (AddEnumMember): Add support to store the attributes associated
9387 with each member too.
9389 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
9390 field builders too - this takes care of the enum member case.
9392 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
9394 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
9395 address-of operator on both value types and pointers.
9397 2002-06-10 Martin Baulig <martin@gnome.org>
9399 * interface.cs (Interface.PopulateIndexer): Add the indexer's
9400 PropertyBuilder to the `property_builders' list.
9402 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
9403 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
9404 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
9405 find any indexers which are inherited from an interface.
9407 2002-06-09 Martin Baulig <martin@gnome.org>
9409 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
9410 the same type as the constant if necessary. There's also a test-130.cs
9413 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
9415 * typemanager.cs (TypeManager.ChangeType): Previously known as
9416 Enum.ChangeEnumType().
9418 2002-06-09 Martin Baulig <martin@gnome.org>
9420 * expression.cs (Cast.TryReduce): Added support for consts.
9422 2002-06-08 Ravi Pratap <ravi@ximian.com>
9424 * class.cs (Accessor): Hold attributes information so we can pass
9427 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
9428 Modify to pass in attributes attached to the methods.
9430 (add_accessor_declaration, remove_accessor_declaration): Ditto.
9432 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
9433 to handle the Accessor kind :-)
9435 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
9437 2002-06-08 Martin Baulig <martin@gnome.org>
9439 * expression.cs (Unary.TryReduceNegative): Added support for
9442 2002-06-08 Martin Baulig <martin@gnome.org>
9444 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
9445 name can't be found in the `defined_names' - the caller will do a
9446 MemberLookup in this case and thus find methods in System.Enum
9447 such as Enum.IsDefined().
9449 2002-06-08 Martin Baulig <martin@gnome.org>
9451 * enum.cs (Enum.ChangeEnumType): This is a custom version of
9452 Convert.ChangeType() which works with TypeBuilder created types.
9453 (Enum.LookupEnumValue, Enum.Define): Use it here.
9455 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
9456 `TypeBuilder.BaseType != null' check.
9457 (TypeContainer.FindMembers): Only lookup parent members if we
9458 actually have a parent.
9459 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
9460 (ConstructorInitializer.Resolve): Likewise.
9462 * interface.cs (Interface.FindMembers): Added
9463 `TypeBuilder.BaseType != null' check.
9465 * rootcontext.cs (RootContext.ResolveCore): Added
9466 "System.Runtime.CompilerServices.IndexerNameAttribute" to
9467 classes_second_stage.
9469 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
9470 debug_type and trace_type when compiling with --nostdlib.
9472 2002-06-07 Martin Baulig <martin@gnome.org>
9474 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
9475 (AddField): Set it to true when adding a non-static field.
9476 (DefineType): Use `have_nonstatic_fields' to find out whether we
9477 have non-static fields, not `Fields != null'.
9479 2002-06-02 Miguel de Icaza <miguel@ximian.com>
9481 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
9482 dereferencing a null on the static-field code path)
9484 2002-05-30 Martin Baulig <martin@gnome.org>
9486 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
9487 to take command line arguments. Use reflection to call the new
9488 custom `Initialize' function on the symbol writer and pass it the
9489 command line arguments.
9491 * driver.cs (--debug-args): New command line argument to pass command
9492 line arguments to the symbol writer.
9494 2002-05-28 Miguel de Icaza <miguel@ximian.com>
9496 * assign.cs (DoResolve): Forgot to do the implicit conversion to
9497 the target type for indexers and properties. Thanks to Joe for
9500 2002-05-27 Miguel de Icaza <miguel@ximian.com>
9502 * typemanager.cs (MethodFlags): returns the method flags
9503 (Obsolete/ShouldIgnore) that control warning emission and whether
9504 the invocation should be made, or ignored.
9506 * expression.cs (Invocation.Emit): Remove previous hack, we should
9507 not do this on matching a base type, we should do this based on an attribute
9509 Only emit calls to System.Diagnostics.Debug and
9510 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
9511 on the command line.
9513 * rootcontext.cs: Global settings for tracing and debugging.
9515 * cs-tokenizer.cs (define): New utility function to track
9516 defines. Set the global settings for TRACE and DEBUG if found.
9518 2002-05-25 Ravi Pratap <ravi@ximian.com>
9520 * interface.cs (Populate*): Pass in the TypeContainer as well as
9521 the DeclSpace as parameters so that we can create EmitContexts and
9522 then use that to apply attributes etc.
9524 (PopulateMethod, PopulateEvent, PopulateProperty)
9525 (PopulateIndexer): Apply attributes everywhere.
9527 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
9530 (ApplyAttributes): Update accordingly.
9532 We now apply interface attributes for all members too.
9534 2002-05-26 Miguel de Icaza <miguel@ximian.com>
9536 * class.cs (Indexer.Define); Correctly check if we are explicit
9537 implementation (instead of checking the Name for a ".", we
9538 directly look up if the InterfaceType was specified).
9540 Delay the creation of the PropertyBuilder.
9542 Only create the PropertyBuilder if we are not an explicit
9543 interface implementation. This means that explicit interface
9544 implementation members do not participate in regular function
9545 lookups, and hence fixes another major ambiguity problem in
9546 overload resolution (that was the visible effect).
9548 (DefineMethod): Return whether we are doing an interface
9551 * typemanager.cs: Temporary hack until we get attributes in
9552 interfaces (Ravi is working on that) and we get IndexerName
9553 support in interfaces.
9555 * interface.cs: Register the indexers as properties.
9557 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
9558 warning, I have verified that this is a bug in the .NET runtime
9559 (JavaScript suffers of the same problem).
9561 * typemanager.cs (MemberLookup): When looking up members for
9562 interfaces, the parent of an interface is the implicit
9563 System.Object (so we succeed in searches of Object methods in an
9564 interface method invocation. Example: IEnumerable x; x.ToString
9567 2002-05-25 Miguel de Icaza <miguel@ximian.com>
9569 * class.cs (Event): Events should also register if they do
9570 implement the methods that an interface requires.
9572 * typemanager.cs (MemberLookup); use the new GetInterfaces
9575 (GetInterfaces): The code used to lookup interfaces for a type is
9576 used in more than one place, factor it here.
9578 * driver.cs: Track the errors at the bottom of the file, we kept
9581 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
9582 instance if the method we are calling is static!
9584 2002-05-24 Miguel de Icaza <miguel@ximian.com>
9586 * attribute.cs (ApplyAttributes): Make this function filter out
9587 the IndexerName attribute (as that attribute in reality is never
9588 applied) and return the string constant for the IndexerName
9591 * class.cs (TypeContainer.Emit): Validate that all the indexers
9592 have the same IndexerName attribute, and if so, set the
9593 DefaultName attribute on the class.
9595 * typemanager.cs: The return value might contain other stuff (not
9596 only methods). For instance, consider a method with an "Item"
9597 property and an Item method.
9599 * class.cs: If there is a problem with the parameter types,
9602 2002-05-24 Ravi Pratap <ravi@ximian.com>
9604 * ecore.cs (ImplicitConversionExists): Wrapper function which also
9605 looks at user defined conversion after making a call to
9606 StandardConversionExists - we need this for overload resolution.
9608 * expression.cs : Update accordingly the various method calls.
9610 This fixes 2 bugs filed against implicit user defined conversions
9612 2002-05-22 Miguel de Icaza <miguel@ximian.com>
9614 * statement.cs: Track the result of the assignment.
9616 2002-05-21 Miguel de Icaza <miguel@ximian.com>
9618 * expression.cs (MemberAccess): Improved error reporting for
9619 inaccessible members.
9621 2002-05-22 Martin Baulig <martin@gnome.org>
9623 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
9624 itself with debugging support.
9626 2002-05-22 Martin Baulig <martin@gnome.org>
9628 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
9629 Removed, this isn't needed anymore.
9631 2002-05-20 Martin Baulig <martin@gnome.org>
9633 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
9634 be underlying type for an enum.
9636 2002-05-20 Miguel de Icaza <miguel@ximian.com>
9638 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
9639 that splits out the loading of just the core types.
9641 * rootcontext.cs (ResolveCore): Split the struct resolution in
9642 two, so we can load the enumeration underlying types before any
9645 * expression.cs (Is): Bandaid until we fix properly Switch (see
9646 bug #24985 for details).
9648 * typemanager.cs (ImplementsInterface): The hashtable will contain
9649 a null if there are no interfaces implemented.
9651 2002-05-18 Miguel de Icaza <miguel@ximian.com>
9653 * cs-parser.jay (indexer_declarator): It is fine to have array
9656 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9658 * typemanager.cs: (RegisterBuilder): New function used to register
9659 TypeBuilders that implement interfaces. Since
9660 TypeBuilder.GetInterfaces (as usual) does not work with lame
9662 (AddUserType): register interfaces.
9664 (ImplementsInterface): Use the builder_to_ifaces hash if we are
9665 dealing with TypeBuilder. Also, arrays are showing up as
9666 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
9667 methods can not be invoked on them!
9669 * ecore.cs (ExplicitReferenceConversionExists): Made public.
9670 (ImplicitReferenceConversionExists): Split out from
9671 StandardConversionExists.
9673 * expression.cs (As): We were only implementing one of the three
9674 cases for the as operator. We now implement them all.
9675 (Is): Implement the various other cases for Is as well.
9677 * typemanager.cs (CACHE): New define used to control if we want or
9678 not the FindMembers cache. Seems to have a negative impact on
9679 performance currently
9681 (MemberLookup): Nested types have full acess to
9682 enclosing type members
9684 Remove code that coped with instance/static returns for events, we
9685 now catch this in RealFindMembers.
9687 (RealFindMembers): only perform static lookup if the instance
9688 lookup did not return a type or an event.
9690 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9692 * assign.cs (CompoundAssign): We pass more semantic information
9693 now to Compound Assignments than we did before: now we have all
9694 the information at hand, and now we resolve the target *before* we
9695 do the expression expansion, which allows the "CacheValue" method
9696 to have the effect we intended (before, a [x] += 1 would generate
9697 two differen ArrayAccess expressions from the ElementAccess,
9698 during the resolution process).
9700 (CompoundAssign.DoResolve): Resolve target and original_source here.
9702 2002-05-16 Miguel de Icaza <miguel@ximian.com>
9704 * expression.cs (ArrayAccess): dropped debugging information.
9706 * typemanager.cs: Small bug fix: I was always returning i_members,
9707 instead of one of i_members or s_members (depending on which had
9710 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
9711 method is invoked before any code generation takes place, and it
9712 is a mechanism to inform that the expression will be invoked more
9713 than once, and that the method should use temporary values to
9714 avoid having side effects
9716 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
9718 * ecore.cs (Expression.CacheTemporaries): Provide empty default
9721 * expression.cs (Indirection, ArrayAccess): Add support for
9722 CacheTemporaries in these two bad boys.
9724 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
9726 (StoreFromPtr): Handle stobj as well.
9728 * expression.cs (UnaryMutator): Share more code.
9730 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
9731 down: I was not tracking the Filter function as well, which
9732 was affecting the results of the cache.
9734 2002-05-15 Miguel de Icaza <miguel@ximian.com>
9736 * attribute.cs: Remove the hack to handle the CharSet property on
9739 2002-05-14 Miguel de Icaza <miguel@ximian.com>
9741 * attribute.cs (DoResolve): More uglyness, we now only try to
9742 resolve the attribute partially, to extract the CharSet
9743 information (only if we are a StructLayout attribute). Otherwise
9745 (GetExtraTypeInfo): Add some code to conditionally kill in the
9746 future this. I am more and more convinced that the .NET
9747 framework has special code to handle the attribute setting on
9750 * expression.cs (IsParamsMethodApplicable): Revert my previous
9751 foreach change here, it was wrong.
9753 2002-05-13 Miguel de Icaza <miguel@ximian.com>
9755 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
9756 (pp_expr): do not abort on unknown input, just return.
9757 (eval): abort if there are pending chars.
9759 * attribute.cs (Attribute.Resolve): Positional parameters are
9760 optional. Deal with that case.
9762 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
9763 the Ansi/Unicode/Auto information for the type.
9765 (TypeContainer.DefineType): instantiate the EmitContext here, as
9766 we will be using it during the type definition (to resolve
9767 attributes) and during the emit phase.
9769 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
9770 to pull type information out of the attributes
9772 (Attribute.Resolve): track the constructor builder, and allow for
9773 multiple invocations (structs and classes will use this).
9775 * ecore.cs (MemberLookupFinal): new version with all the
9776 parameters customizable.
9778 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
9779 constructors. Return if the result value is null (as the error
9780 would have been flagged already by MemberLookupFinal)
9782 Do not allow instances of abstract classes or interfaces to be
9785 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
9786 We have to compare the assembly property here when dealing with
9787 FamANDAssem and Assembly access modifiers, because we might be
9788 creating an assembly from *modules* (that means that we are not
9789 getting TypeBuilders for types defined in other modules that are
9790 part of this assembly).
9792 (Method.Emit): If the method is marked abstract and has a body,
9795 (TypeContainer.DefineMembers): If both the defined member and the
9796 parent name match are methods, then do not emit any warnings: let
9797 the Method.Define routine take care of flagging warnings. But if
9798 there is a mismatch (method overrides something else, or method is
9799 overriwritten by something, then emit warning).
9801 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
9802 set to null, this means `do not check for the return type on the
9805 (Method.Define): set the return type for the method signature to
9806 null, so that we get methods with the same name and parameters and
9807 different return types. This is used to flag warning 114 (you are
9808 hiding a method, and you probably want to use the new/override
9811 * typemanager.cs (MemberLookup): Implemented proper access
9812 control, closing a long standing set of bug reports. The problem
9813 was that the Framework only has two bits: Public and NonPublic,
9814 and NonPublic includes private and protected methods, but we need
9815 to enforce the FamANDAssem, FamOrAssem and Family.
9817 2002-05-11 Miguel de Icaza <miguel@ximian.com>
9819 * statement.cs (GotoCase): Return true: Ammounts to giving up
9820 knowledge on whether we return or not, and letting the other case
9821 be responsible for it.
9823 2002-05-10 Miguel de Icaza <miguel@ximian.com>
9825 * driver.cs: Do not load directories for each file processed, only
9826 do it if there is a pattern.
9828 * ecore.cs: Report readonly assigns here as well, as we might have
9829 been resolved only by MemberAccess.
9831 (SimpleName.SimpleNameResolve): Also be useful for LValue
9832 resolution. We need this to propagate assign to local readonly variables
9834 * typemanager.cs: Use a ptrhashtable for the criteria, because we
9835 do not want to reuse potential criteria memory.
9837 * class.cs (MyEventBuilder): Set reflected_type;
9839 * ecore.cs (Constantify): Added support for constifying bools.
9841 (RootContext.LookupType): Added a cache for values looked up in
9842 the declaration space.
9844 * typemanager.cs (FindMembers): Now is a front-end to
9845 RealFindMembers, and provides a two-level hashtable-based cache to
9848 15% performance improvement: from 22.5 to 19.2 seconds.
9850 * expression.cs (IsParamsMethodApplicable): use foreach.
9851 (Invocation.DoResolve): ditto.
9852 (New.DoResolve): ditto.
9853 (ArrayCreation.DoResolve): ditto.
9855 * ecore.cs (FindMostEncompassingType): use foreach.
9857 * delegate.cs (NewDelegate.DoResolve): Use foreach
9859 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
9860 (RemoveMethods): use foreach.
9862 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
9863 nested foreach statements instead of for, and also break out of
9864 the inner loop once a match is found.
9866 (Invocation.OverloadResolve): Use foreach, simplify the code.
9868 2002-05-08 Miguel de Icaza <miguel@ximian.com>
9870 * cfold.cs (BinaryFold): During an enumeration evaluation context,
9871 we actually unwrap the expression to allow for extra information
9874 * expression.cs: Use Shr_Un on unsigned operations.
9876 2002-05-08 Ravi Pratap <ravi@ximian.com>
9878 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
9879 applicable operators was not being considered correctly. This closes
9880 the bug Miguel reported.
9882 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
9884 * attribute.cs: check that the type derives from System.Attribute
9885 and report the correct error in that case (moved the duplicate code to
9886 its own method, too).
9888 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
9890 * attribute.cs: lookup attribute type name as the spec says: first the
9891 bare attribute name and then name + "Attribute" (nant compiles with
9892 mcs after this fix).
9894 2002-05-07 Miguel de Icaza <miguel@ximian.com>
9896 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
9897 Because of the way we parse things, we should try to see if a
9898 UIntConstant can fit in an integer.
9900 2002-05-07 Ravi Pratap <ravi@ximian.com>
9902 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
9903 when we are in an explicit context.
9905 (ConvertReferenceExplicit): When converting from Iface type S to Class
9906 T make sure the rules are implemented as an OR.
9908 * parameter.cs (ParameterType): Make it a property for now although the
9909 purpose really isn't anything immediate.
9911 * expression.cs (Is*Applicable): Do better checking on the parameter type
9912 of a ref/out parameter. The ones from the system assemblies are already
9913 marked with the correct type so we don't need to do any correction.
9915 * ecore.cs (StandardConversionExists): Conversion from Interface types to
9916 the object type is standard too so include that.
9918 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9920 * ecore.cs (StandardConversionExists): Augment with missing code:
9921 deal with IntConstant, LongConstants and Enumerations.
9923 * assign.cs: Report the error, instead of failing silently
9925 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
9926 typecontainer that they are declared, because the
9927 typecontainer/namespace will have the list of using clauses that
9930 Assembly Attributes were escaping the normal registration
9933 (EmitCode): Apply attributes within an EmitContext that represents
9934 the container they were declared on.
9936 * cs-parser.jay: Track bases for structs. How did I get this wrong?
9938 2002-05-06 Ravi Pratap <ravi@ximian.com>
9940 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
9941 Revamp completely - make much cleaner as we now operate only
9944 (FindMostSpecificSource, FindMostSpecificTarget): New methods
9945 to implement the logic detailed in the spec more correctly.
9947 (UserDefinedConversion): Update accordingly.
9949 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9951 * statement.cs: Return flow analysis information up.
9953 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
9956 (token): Do not consume an extra character before calling
9959 2002-05-06 Piers Haken <piersh@friskit.com>
9961 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
9963 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9965 * class.cs (Constructor.Emit): Set the IsStatic flag in the
9966 EmitContext during the instance constructor initializer
9967 resolution, to stop access to instance variables.
9969 This is mandated by the spec, last paragraph of the `constructor
9970 initializers' section.
9972 2002-05-05 Miguel de Icaza <miguel@ximian.com>
9974 * cs-parser.jay, class.cs (Accessor): new class used to represent
9975 an accessor (get or set). In the past we used `null' to represent
9976 a missing accessor. But this is ambiguous because there was no
9977 way to tell in abstract indexers/properties if one of them was
9980 Now there is a way of addressing that.
9982 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
9983 instead of FindMembers.
9985 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
9986 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
9988 * attribute.cs: Treat indexers and properties as the same in terms
9989 of applying attributes
9991 * ecore.cs (FindMostEncompassedType): Use statically initialized
9992 EmptyExpressions()s like we do elsewhere to avoid creating useless
9993 objects (and we take this out of the tight loop).
9995 (GetConversionOperators): Move the code to extract the actual
9996 operators to a separate routine to clean things up.
9998 2002-05-04 Miguel de Icaza <miguel@ximian.com>
10000 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
10001 events are always registered FieldBuilders.
10003 * class.cs (FieldBase): New class shared by Fields
10005 * delegate.cs: If we are a toplevel delegate, use our full name.
10006 If we are a nested delegate, then only use our tail name.
10008 2002-05-02 Ravi Pratap <ravi@ximian.com>
10010 * expression.cs (IsApplicable): Ensure that we add the "&" to
10011 ref/out types before comparing it with the type of the argument.
10013 (IsParamsMethodApplicable): Ditto.
10015 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
10018 * delegate.cs : Handle the case when we have more than one applicable
10019 method. Flag an error only when we finish checking all.
10021 2002-05-02 Miguel de Icaza <miguel@ximian.com>
10023 * expression.cs: Add support for boolean static initializers.
10025 2002-05-01 Miguel de Icaza <miguel@ximian.com>
10027 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
10029 * parameter.cs (ComputeParameterTypes,
10030 ComputeAndDefineParameterTypes): Better error handling: now we
10031 clear the `types' cache if we fail during any of the type lookups.
10032 We also return the status code correctly to our caller
10034 * delegate.cs: If we fail to define a delegate, abort the extra
10037 * expression.cs (Binary.ResolveOperator): for
10038 operator==(object,object) and operator !=(object, object) we also
10039 have to verify that there is an implicit conversion from one to
10042 (ArrayAccess.DoResolve): Array Access can operate on
10045 2002-04-30 Miguel de Icaza <miguel@ximian.com>
10047 * assign.cs (CompoundAssign): A new class used as a "flag" that
10048 the assignment actually is happening as part of a compound
10049 assignment operator.
10051 During compound assignment, a few new rules exist to enable things
10058 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
10059 to the type of x) if y is implicitly convertible to the type of x,
10060 and the operator is a builtin operator and the return type of the
10061 operator is explicitly convertible to the type of x.
10063 * rootcontext.cs: Reset warning level to 2. 4 catches various
10064 "interesting" features in mcs, we must clean this up at some
10065 point, but currently am trying to kill other bugs ;-)
10067 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
10068 in container classes as well.
10070 * expression.cs (Binary.ResolveOperator): Handle string case
10071 before anything else (as operator overloading does emit an error
10072 before doing anything else).
10074 This code could go away when we move to a table driven model, but
10075 i could not come up with a good plan last night.
10077 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
10079 * typemanager.cs (CSharpName): reimplementation using regex.
10080 * class.cs: added null check for fields in Emit
10081 * rootcontext.cs: set warninglevel to 4
10083 2002-04-29 Miguel de Icaza <miguel@ximian.com>
10085 * typemanager.cs (CSharpName): reimplemented with Lupus
10088 2002-04-28 Miguel de Icaza <miguel@ximian.com>
10090 * statement.cs (If): correclty implement Resolve, because we were
10091 not catching sem errors in there. The same process is needed
10093 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
10096 (Statement.Warning_DeadCodeFound): Factorize code.
10097 (While): Report dead code here too.
10099 (Statement): Added Resolve virtual method to allow
10100 for resolution split from the emit code.
10102 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10104 * statement.cs (EmitBoolExpression): No longer try to resolve the
10106 (MakeBoolean): New utility function that resolve, implicitly
10107 converts to boolean and tags the expression.
10110 (If, Do): Implement dead code elimination.
10111 (While): Implement loop inversion
10113 (Do, While, For, If): Resolve the expression prior to calling our
10116 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
10119 - added method Report28 (warning: program has more than one entry point)
10120 - added method IsEntryPoint, implements paragraph 10.1 of the spec
10121 - modified method Method.Define, the part at the end of the method
10123 * rootcontext.cs: added static public Location EntryPointLocation;
10125 * ../errors/cs0028.cs : Add test case for the above warning.
10128 - modified method CSharpName to allow arrays of primitive type to
10129 be printed nicely (e.g. instead of System.Int32[][] it now prints
10131 - added method CSharpSignature: returns the signature of a method
10132 in string format to be used in reporting errors, warnings, etc.
10134 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
10137 2002-04-26 Ravi Pratap <ravi@ximian.com>
10139 * delegate.cs (Define): Fix extremely silly bug where I was
10140 setting the type of the 'object' parameter of the BeginInvoke
10141 method to System.IAsyncResult instead of System.Object ;-)
10143 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10145 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
10148 (Constructor.Emit): return if we fail to initialize the
10149 constructor. Another door closed!
10151 * expression.cs (New.DoResolve): Improve error message (from -6 to
10152 1501). Use DeclaredOnly lookup to find the exact constructor.
10154 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
10155 loop. This is useful.
10157 * cs-parser.jay: Adjust the default parameters so that destructors
10158 have the proper signature.
10160 2002-04-26 Martin Baulig <martin@gnome.org>
10162 * driver.cs (LoadAssembly): If `assembly' contains any characters
10163 which are only valid in path names and not in assembly names
10164 (currently slash, backslash and point), use Assembly.LoadFrom ()
10165 instead of Assembly.Load () on the `assembly' (before iteration
10166 over the link_paths).
10168 2002-04-26 Martin Baulig <martin@gnome.org>
10170 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
10172 2002-04-25 Miguel de Icaza <miguel@ximian.com>
10174 * class.cs (Property): use the new typemanager.MemberLookup
10176 (TypeContainer.MemberLookup): Implement using the
10177 TypeManager.MemberLookup now.
10179 * typemanager.cs: Make MemberLookup a function of the TypeManager,
10180 and return MemberInfos, so that these can be used without an
10181 EmitContext (what we had before).
10183 2002-04-24 Miguel de Icaza <miguel@ximian.com>
10185 * expression.cs: Fix the case where the argument to params if the
10186 type of the params. I omitted handling this before. Fixed
10188 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10190 * driver.cs: Call BootCorlib_PopulateCoreType
10192 * class.cs (Property.CheckBase): Check for properties only, not
10195 * interface.cs: Temporary hack: try/catch around the
10196 CustomAttributeBuilder, because I am getting an exception that I
10199 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
10200 types whose definitions are required to be there (attributes are
10201 defined before standard types).
10203 Compute definitions as we boot the various types, as they are used
10204 immediately (value_type class will need object_type, but if we do
10205 not initialize object_type, we will pass a null, which will let
10206 the runtime pick the System.Object from the existing corlib, which
10207 is not what we want).
10209 2002-04-22 Patrik Torstensson <totte@labs2.com>
10211 * cs-tokenizer.cs: fixed a number of trim() issues.
10213 2002-04-22 Ravi Pratap <ravi@ximian.com>
10215 * expression.cs (Argument.Type): Ensure that we return the correct
10216 type when we have out or ref parameters [in which case we
10219 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10221 * class.cs (Property, Indexer): Allow extern modifier in there.
10223 * typemanager.cs (InitBaseTypes): Initializes object_type and
10224 value_type, since those will be used early on during the bootstrap
10225 process to compile corlib.
10227 (InitCoreTypes): Move code from here to InitBaseTypes.
10229 2002-04-21 Miguel de Icaza <miguel@ximian.com>
10231 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
10232 single-dimension arrays as using the ldlen opcode.
10234 Daniel Lewis discovered this optimization.
10236 * typemanager.cs: Add signature for System.Array::get_Length
10238 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10240 * statement.cs: report the error when the foreach does not apply to an
10241 array nor a collection.
10243 2002-04-19 Miguel de Icaza <miguel@ximian.com>
10245 * expression.cs: Add implicit conversions to the operator ~.
10247 * constant.cs (DecimalConstant.Emit): Emit decimal value.
10249 * typemanager.cs: Locate the decimal constructor.
10251 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10253 * attribute.cs: use the new property of TypeOf.
10254 * expression.cs: added 'get' property around typearg.
10256 These changes fix a build breaker reported by NickD. Is this the
10257 correct way to fix? If not, please, revert my changes and make it
10260 2002-04-17 Miguel de Icaza <miguel@ximian.com>
10262 * attribute.cs: Add support for typeof in attribute invocations.
10263 I am not sure that this is right though.
10265 2002-04-14 Duncan Mak <duncan@ximian.com>
10267 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
10268 Binary.Operator.Division case.
10270 2002-04-13 Ravi Pratap <ravi@ximian.com>
10272 * class.cs (DefineType): Ensure that we do a proper check on
10273 attribute types and also register it with the TypeManager.
10275 (TypeContainer.Targets): The default for attribute types is
10276 AttributeTargets.All.
10278 * attribute.cs (ApplyAttributes): Registering the attribute type
10279 is done elsewhere, not when we discover we have a Usage attribute.
10281 2002-04-12 Ravi Pratap <ravi@ximian.com>
10283 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
10284 and get rid of is_delegate parameter.
10286 * everywhere : update.
10288 2002-04-12 Ravi Pratap <ravi@ximian.com>
10290 * cs-parser.jay (compilation_unit): Revamp completely to use
10291 some new ideas that I got from Rhys' grammar to solve the problems
10292 with assembly level attributes.
10294 (outer_declaration): New grammar production.
10296 (attribute_sections): Add.
10298 (opt_attributes): Base on attribute_sections
10300 (namespace_declaration): Allow opt_attributes to tackle the case
10301 when we have assembly level attributes - we are clever in this
10304 * attribute.cs (ApplyAttributes): Do not worry about assembly
10305 attributes in the non-global context.
10307 * rootcontext.cs (AddGlobalAttributes): Go back to using this
10308 instead of SetGlobalAttributes.
10310 * class.cs, rootcontext.cs : Ensure we define and generate
10311 attribute types before anything else.
10313 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
10314 and flag the new error -20 for the case when the attribute type
10315 does not have valid targets specified. csc does not catch this.
10317 * ../errors/errors.txt : update for error # -20
10319 2002-04-11 Ravi Pratap <ravi@ximian.com>
10321 * support.cs (InternalParameters.ParameterModifier): Do some null
10322 checking and return sane values.
10324 * class.cs (Method.Define): If we are a PInvoke method, ensure
10325 that we are static and extern. Report error # 601
10327 * ../errors/cs0601.cs : Add test case for the above error.
10329 2002-04-07 Ravi Pratap <ravi@ximian.com>
10331 * rootcontext.cs (attribute_types): We need to keep type of
10332 all attribute types separately and emit code for them first.
10334 (RegisterAttribute) : Implement.
10336 * class.cs (DefineType): Check if the current Type is a custom
10337 attribute type and register it accordingly.
10339 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
10340 adding the first attribute twice and rename to
10342 (SetGlobalAttributes): this.
10344 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
10347 * attribute.cs (ApplyAttributes): Take an additional argument telling us
10348 if we are processing global arguments. Hmm, I am unsure of this.
10350 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10352 * expression.cs: added static array of strings to avoid calling
10353 Enum.ToString () for Operator in Binary. Significant recover of
10356 2002-04-10 Miguel de Icaza <miguel@ximian.com>
10358 * class.cs (FindMembers): Allow the Builders of the various
10359 members to be null. If they are skip them. This only happens
10360 during the PInvoke declaration.
10362 2002-04-09 Miguel de Icaza <miguel@ximian.com>
10364 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
10365 failure, so we do not keep going afterwards.
10367 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
10368 wanted to pass `false' as the `is_delegate' argument. If this is
10369 the case, why not use delegate_type == null to mean `is_delegate =
10370 false' and anything else as is_delegate = true.
10372 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
10374 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
10375 code for the section, not the beginning of the tests.
10377 2002-04-08 Miguel de Icaza <miguel@ximian.com>
10379 * cfold.cs: Handle operator + (Enum x, Underlying x)
10381 * expression.cs (Binary): same. Warn about errors where we have
10382 Enum/Enum in operator + as well.
10384 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
10387 - added support for switch(bool)
10388 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
10389 - add TableSwitchEmit() to handle table-based switch statements
10391 2002-04-05 Ravi Pratap <ravi@ximian.com>
10393 * expression.cs (Invocation.OverloadResolve): Factor out code which
10394 does parameter compatibility checking with arguments so that we can
10395 re-use the code even from Delegate.VerifyApplicability
10397 (VerifyArgumentsCompat): Move above code here.
10399 * delegate.cs (VerifyApplicability): Get rid of duplicate code
10400 and instead make a call to the above method.
10402 2002-03-31 Ravi Pratap <ravi@ximian.com>
10404 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
10405 We use it to keep track of classes which are attribute types.
10407 2002-04-02 Miguel de Icaza <miguel@ximian.com>
10409 * delegate.cs (Delegate.Define): Correctly define the types in the
10410 presence of fixed and array parameters.
10412 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
10415 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
10416 include NonPublic after the first iteration.
10418 * class.cs (Indexer.CheckBase): Only check if both parents are
10421 * cs-parser.jay (accessor_body): If empty, set to null.
10423 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
10424 same code path here to resolve constants names that we did have in
10425 MemberAccess.DoResolve. There is too much code duplicated here.
10427 2002-04-01 Miguel de Icaza <miguel@ximian.com>
10429 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
10431 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
10434 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
10435 tokens, numbers and strings.
10437 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
10440 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
10441 asyncronous parameters and the regular parameters.
10443 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
10444 specify the target directory.
10446 * expression.cs: (This.DoResolve): Simplify
10447 (As.Emit): Optimize, do not generate IsInst if the expression is
10448 always of the given type.
10450 (Is.DoResolve): Bug fix, we were reporting both always/never for
10453 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
10454 creating too many unnecessary arrays.
10456 2002-03-31 Miguel de Icaza <miguel@ximian.com>
10458 * class.cs (EmitFieldInitializer): Use Assign expression to assign
10459 fields instead of rolling our own initializer. Takes care of all
10460 implicit conversions, and drops unnecessary static checks/argument.
10462 2002-03-31 Dick Porter <dick@ximian.com>
10464 * driver.cs: use the GetDirectories() return values properly, and
10465 use "/" as path separator.
10467 2002-03-30 Miguel de Icaza <miguel@ximian.com>
10469 * expression.cs (Unary): Optimize - - expr into expr.
10470 (Binary): Optimize a + (-b) into a -b.
10472 * codegen.cs (CodeGen): Made all methods static.
10474 2002-03-29 Miguel de Icaza <miguel@ximian.com>
10478 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
10479 TypeBuilder property.
10481 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
10484 * tree.cs: Removed the various RecordXXXX, and replaced with a
10485 single RecordDecl. Removed all the accessor methods, and just
10486 left a single access point Type
10488 * enum.cs: Rename DefineEnum to DefineType.
10490 * decl.cs: New abstract method `DefineType' used to unify the
10491 Defines for Enumerations, Interfaces, TypeContainers and
10494 (FindType): Moved LookupInterfaceOrClass here. Moved the
10495 LookupBaseClasses method that used to live in class.cs and
10496 interface.cs here, and renamed to FindType.
10498 * delegate.cs: Implement DefineType. Take advantage of the
10499 refactored pattern for locating the parent builder without taking
10500 the parent_builder argument (which we know does not work if we are
10501 nested, and triggering a toplevel definition).
10503 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10505 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
10506 accessibility of a member has changed during override and report
10509 * class.cs (Method.Define, Property.Define): Only complain on
10510 overrides if the method is private, any other accessibility is
10511 fine (and since we just checked the permission is the same, we are
10514 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
10515 and elif are processed always. The other pre-processing
10516 directives are only processed if we are "taking" the path
10518 2002-03-29 Martin Baulig <martin@gnome.org>
10520 * class.cs (Method.Emit): Only emit symbolic debugging info if the
10521 current location is not Null.
10523 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
10524 a separate method so we can profile it.
10526 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
10527 `span.Seconds' are just seconds, but no minutes or hours.
10528 (MainDriver): Profile the CodeGen.SaveSymbols calls.
10530 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10532 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
10533 Remove the gratuitous set of Final:
10535 // If an interface implementation, then we can set Final.
10536 if (((flags & MethodAttributes.Abstract) == 0) &&
10537 implementing.DeclaringType.IsInterface)
10538 flags |= MethodAttributes.Final;
10540 I do not know what I was smoking when I used that.
10543 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
10544 step into fixing the name resolution issues for delegates and
10545 unifying the toplevel name resolution.
10547 2002-03-28 Martin Baulig <martin@gnome.org>
10549 * class.cs (Method.Emit): If we have a symbol writer, call its
10550 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
10551 tell it about the current method.
10553 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
10554 writer that we're going to emit the first byte of IL code for a new
10555 statement (a new source line).
10556 (EmitContext.EmitTopBlock): If we have a symbol writer, call
10557 EmitContext.Mark() before emitting any code.
10559 * location.cs (SymbolDocument): Return null when we're Null.
10561 * statement.cs (Statement): Moved the `Location loc' variable here.
10562 (Statement.EmitBoolExpression): If we have a symbol writer, call
10563 ec.Mark() before emitting any code to tell it that we're at the
10564 beginning of a new statement.
10565 (StatementExpression): Added `Location' argument to the constructor.
10566 (Block): Added public readonly variable `StartLocation' and public
10567 variable `EndLocation'. The latter is to be set using SetEndLocation().
10568 (Block): Added constructor which takes a start and end location.
10569 (Block.SetEndLocation): New method. This sets the end location.
10570 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
10571 local variables we create.
10572 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
10573 each statement and do also mark the begin and end of the block.
10575 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
10576 tell it the current lexer.Location, use Location.Null for the end of the
10578 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
10579 current block, set its end location using SetEndLocation().
10580 (statement_expression): StatementExpression constructor now takes the
10581 lexer.Location as additional argument.
10582 (for_statement, declare_local_variables): Likewise.
10583 (declare_local_variables): When creating a new implicit block, use the
10584 new Block constructor and pass it the lexer.Location.
10586 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10588 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
10589 members also on the parent interfaces recursively.
10591 2002-03-27 Miguel de Icaza <miguel@ximian.com>
10593 * report.cs: Use new formats, since Gonzalo finished the missing
10596 * expression.cs (Binary.ResolveOperator): added missing operator|
10597 operator& and operator^ for bool/bool.
10599 * cs-parser.jay: CheckDef now takes a Location argument that is
10600 used to report errors more precisly (instead of reporting the end
10601 of a definition, we try to track something which is a lot closer
10602 to the source of the problem).
10604 * cs-tokenizer.cs: Track global token use, so we can properly flag
10605 the use of #define/#undef after the first token has been seen.
10607 Also, rename the reportXXXX to Error_DescriptiveName
10609 * decl.cs (DeclSpace.IsTopLevel): Move property here from
10610 TypeContainer, so that Enum and Interface can use this too.
10612 * class.cs (TypeContainer.LookupInterfaceOrClass,
10613 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
10614 `builder' argument. Typically this was used to pass the parent
10615 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
10618 The problem is that a nested class could trigger the definition of
10619 a toplevel class, and the builder would be obviously wrong in that
10622 So we drop this argument, and we compute dynamically the
10623 TypeBuilder/ModuleBuilder (the correct information was available
10624 to us anyways from DeclSpace.Parent)
10626 * interface.cs (Interface.DefineInterface): Drop builder
10627 parameter cleanup like class.cs
10629 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
10632 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
10635 (Try.Emit): Propagate the returns value from the statement.
10637 (Return.Emit): Even if we are leavning
10639 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
10641 * modifiers.cs: Fix the computation of MethodAttributes flags.
10643 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
10645 * driver.cs: allow compilation of files that start with '/'.
10646 Add a default case when checking the argument of --target.
10648 2002-03-25 Miguel de Icaza <miguel@ximian.com>
10650 * interface.cs: Implement the same search algorithm for types in
10651 the interface code.
10653 * delegate.cs: Do not allow multiple definition.
10655 * Recovered ChangeLog that got accidentally amputated
10657 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
10659 * rootcontext.cs: Load manually enum to allow core classes to
10660 contain enumerations.
10662 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
10663 Update to new static methods in TypeManager.
10665 * typemanager.cs (GetMethod, GetConstructor): Use our
10666 implementation of FindMembers to find the members, since during
10667 corlib compilation, the types are TypeBuilders and GetMethod and
10668 GetConstructor do not work.
10670 Make all methods in TypeManager static.
10672 (InitCodeHelpers): Split the functionality from
10673 the InitCodeTypes function.
10675 * driver.cs: Call InitCodeHelpers after we have populated the
10678 * cs-parser.jay (delegate_declaration): we did not used to compute
10679 the delegate name correctly for void delegates.
10681 2002-03-24 Miguel de Icaza <miguel@ximian.com>
10683 * rootcontext.cs (RootContext): Init the interface_resolve_order
10684 and type_container_resolve_order always.
10686 (ResolveCore, BootstrapCorlib_ResolveClass,
10687 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
10688 compiler when compiling with --nostdlib
10690 * class.cs (TypeContainer.DefineType): Check that our parent is
10691 not null. This test is most important when we are bootstraping
10694 * codegen.cs: Split out the symbol writing code.
10696 2002-03-25 Martin Baulig <martin@gnome.org>
10698 * driver.cs (-g): Made -g an alias for --debug.
10700 2002-03-24 Martin Baulig <martin@gnome.org>
10702 * codegen.cs (SymbolWriter): New public variable. Returns the
10703 current symbol writer.
10704 (CodeGen): Added `bool want_debugging_support' argument to the
10705 constructor. If true, tell the ModuleBuild that we want debugging
10706 support and ask it for the ISymbolWriter.
10707 (Save): If we have a symbol writer, call it's Close() method after
10708 saving the assembly.
10710 * driver.c (--debug): New command line argument to create a
10711 debugger information file.
10713 * location.cs (SymbolDocument): New public property. Returns an
10714 ISymbolDocumentWriter object for the current source file or null
10715 if we don't have a symbol writer.
10717 2002-03-21 Miguel de Icaza <miguel@ximian.com>
10719 * driver.cs (LoadAssembly): Correctly return when all the paths
10720 have been tried and not before.
10722 * statement.cs (Switch.Emit): return the actual coverage for this
10723 statement (returns/not-returns)
10725 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
10726 switch of the statement if we are the last switch section. That
10727 kills two problems: try/catch problems (we used to emit an empty
10728 nop at the end) and switch statements where all branches would
10731 2002-03-19 Miguel de Icaza <miguel@ximian.com>
10733 * driver.cs: Add default assemblies (the equivalent to the
10734 Microsoft CSC.RSP file)
10736 * cs-tokenizer.cs: When updating `cols and setting it to zero,
10737 also update tokens_seen and set it to false.
10739 * driver.cs: Implement --recurse for Mike.
10741 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
10742 correctly splitting out the paths.
10744 2002-03-18 Miguel de Icaza <miguel@ximian.com>
10746 * interface.cs (Interface.PopulateProperty): Instead of using
10747 `parent' as the declaration space for the set parameters, use
10750 * support.cs (InternalParameters): InternalParameters constructor
10751 takes a DeclSpace instead of a TypeContainer.
10753 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
10754 types are being initialized, load the address of it before calling
10757 (New): Provide a mechanism to disable the generation of local
10758 value type temporaries when the caller will be providing us with
10759 an address to store it.
10761 (ArrayCreation.EmitDynamicInitializers): Use it.
10763 2002-03-17 Miguel de Icaza <miguel@ximian.com>
10765 * expression.cs (Invocation.EmitArguments): Only probe for array
10766 property if there is more than one argument. Sorry about that.
10768 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
10769 empty param arrays.
10771 * class.cs (Method.LabelParameters): Fix incorrect code path that
10772 prevented the `ParamArrayAttribute' from being applied to the
10775 2002-03-16 Miguel de Icaza <miguel@ximian.com>
10777 * support.cs (ReflectionParameters): Correctly compute whether the
10778 last argument is a params array. Fixes the problem with
10781 * typemanager.cs: Make the assemblies array always be non-null
10782 (empty, but non-null)
10784 * tree.cs (RecordDecl): New function that abstracts the recording
10785 of names. This reports error 101, and provides a pointer to the
10786 previous declaration. Fixes a crash in the compiler.
10788 * cs-parser.jay (constructor_declaration): Update to new grammar,
10789 and provide a constructor_body that can be empty.
10791 2002-03-15 Miguel de Icaza <miguel@ximian.com>
10793 * driver.cs: Add support for --resources.
10795 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
10796 Make all types for the various array helper methods be integer.
10798 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
10799 CheckState to ConvCast.
10801 (ConvCast): Now it takes a `checked' state argument, to avoid
10802 depending on the emit context for the conversion, and just using
10803 the resolve time setting.
10805 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
10806 instead of Invocation.EmitArguments. We do not emit the original
10807 arguments, instead we emit those which have been converted to
10808 unsigned int expressions.
10810 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
10812 * codegen.cs: ditto.
10814 * expression.cs (LocalVariableReference): Drop the use of the
10815 Store function that depended on the variable index.
10817 * statement.cs (VariableInfo): Drop the `Idx' property from this
10818 class, as this is not taking into account the indexes for
10819 temporaries tat we generate during the execution, getting the
10822 * class.cs: First emit class initializers, then call the parent
10825 * expression.cs (Binary): Fix opcode emision.
10826 (UnaryMutator.EmitCode): Support checked code generation
10828 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
10829 matches for events for both the Static and Instance scans,
10830 pointing to the same element. Fix that.
10832 2002-03-14 Miguel de Icaza <miguel@ximian.com>
10834 * rootcontext.cs (ResolveTree): Always set the
10835 interface_resolve_order, because nested interfaces will be calling
10838 * class.cs (GetInterfaceOrClass): Track the same resolution
10839 process used by TypeManager.LookupType. This fixes the nested
10840 type lookups in class declarations (separate path from
10843 (TypeContainer.DefineType): Also define nested interfaces.
10844 (TypeContainer.RegisterOrder): New public function used to
10845 register the order in which child interfaces need to be closed.
10847 Nested interfaces need to be closed after their parents have been
10850 * interface.cs (InterfaceAttr): Put all the logic for computing
10851 the interface attribute here.
10853 (DefineInterface): Register our interface order with the
10854 RootContext or with the TypeContainer depending on the case.
10856 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10858 * cs-parser.jay: rework foreach statement to work with the new
10859 changes to the policy on SimpleNames.
10861 * report.cs: support Stacktrace on warnings as well.
10863 * makefile: drop --unsafe and /unsafe from the compile.
10865 2002-03-13 Ravi Pratap <ravi@ximian.com>
10867 * ecore.cs (StandardConversionExists): Modify to take an Expression
10868 as the first parameter. Ensure we do null -> reference type conversion
10871 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
10872 temporary Expression objects.
10874 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
10876 * interface.cs: workaround bug in method overloading resolution
10877 (there is already a bugzilla bug for it).
10879 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10881 We could also solve this problem by having a separate path for
10882 performing type lookups, instead of DoResolve, we could have a
10883 ResolveType entry point, and only participating pieces of the
10884 production (simplename, deref, array) would implement this.
10886 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
10887 signal SimpleName to only resolve type names and not attempt to
10888 resolve anything else.
10890 * expression.cs (Cast): Set the flag.
10892 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
10894 * class.cs: Only report 108 if there is no `new' modifier.
10896 * cs-parser.jay: rework foreach statement to work with the new
10897 changes to the policy on SimpleNames.
10899 * report.cs: support Stacktrace on warnings as well.
10901 * makefile: drop --unsafe and /unsafe from the compile.
10903 2002-03-11 Miguel de Icaza <miguel@ximian.com>
10905 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10906 lookups here, instead of doing that at parse time. This means
10907 that our grammar will not introduce `LocalVariableReferences' as
10908 expressions at this point. That solves the problem of code like
10912 static void Main ()
10916 This is only half the fix. The full fix requires parameters to
10917 also be handled in this way.
10919 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
10920 makes the use more obvious of the DeclSpace. The
10921 ec.TypeContainer.TypeBuilder is now only used to pull the
10922 TypeBuilder for it.
10924 My theory is that I can get rid of the TypeBuilder completely from
10925 the EmitContext, and have typecasts where it is used (from
10926 DeclSpace to where it matters).
10928 The only pending problem is that the code that implements Aliases
10929 is on TypeContainer, and probably should go in DeclSpace.
10931 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10932 lookups here, instead of doing that at parse time. This means
10933 that our grammar will not introduce `LocalVariableReferences' as
10934 expressions at this point. That solves the problem of code like
10938 static void Main ()
10942 This is only half the fix. The full fix requires parameters to
10943 also be handled in this way.
10945 * class.cs (Property.DefineMethod): When implementing an interface
10946 method, set newslot, when implementing an abstract method, do not
10947 set the flag (before we tried never setting it, or always setting
10948 it, which is the difference).
10949 (Indexer.DefineMethod): same.
10950 (Method.DefineMethod): same.
10952 * ecore.cs: Only set the status used flag if we get back a Field.
10954 * attribute.cs: Temporary hack, so Paolo can keep working.
10956 2002-03-08 Ravi Pratap <ravi@ximian.com>
10958 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
10959 the unmanaged type in the case we have a MarshalAs attribute.
10961 (Resolve): Handle the case when we are parsing the special MarshalAs
10962 attribute [we need to store the unmanaged type to use later]
10964 * typemanager.cs (marshal_as_attr_type): Built in type for the
10965 MarshalAs Attribute.
10967 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
10968 on parameters and accordingly set the marshalling info.
10970 2002-03-09 Miguel de Icaza <miguel@ximian.com>
10972 * class.cs: Optimizing slightly by removing redundant code after
10973 we switched to the `NoTypes' return value.
10974 (Property.DefineMethod): use NoTypes here too.
10976 This fixes the bug I introduced in my last batch of changes.
10978 2002-03-05 Ravi Pratap <ravi@ximian.com>
10980 * tree.cs (RecordEnum): Add. We now keep track of enums too.
10982 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
10983 Enums since those are types too.
10985 * cs-parser.jay (enum_declaration): Record enums as we parse them.
10987 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
10988 thanks to a call during the lookup process.
10990 2002-03-07 Miguel de Icaza <miguel@ximian.com>
10992 * statement.cs (Foreach): Lots of work to accomodate a particular
10993 kind of foreach statement that I had not kept in mind. It is
10994 possible to have foreachs on classes that provide a GetEnumerator
10995 method that return objects that implement the "pattern" for using
10996 a foreach, there is no need to support GetEnumerator
10999 This is needed to compile nant.
11001 * decl.cs: Only report 114 if the member is not `Finalize' and if
11002 the warning level is at least 2.
11004 * class.cs: Moved the compare function from Method to
11007 (MethodSignature.InheritableMemberSignatureCompare): Add new
11008 filter function that is used to extract inheritable methods from a
11011 (Method.Define): Use the new `inheritable_method_signature_filter'
11014 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
11017 2002-03-06 Miguel de Icaza <miguel@ximian.com>
11019 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
11021 * cs-parser.jay: Add opt_semicolon to the interface declaration.
11023 * expression.cs: Pass location information to
11024 ConvertImplicitStandard.
11026 * class.cs: Added debugging code to track return values from
11029 2002-03-05 Miguel de Icaza <miguel@ximian.com>
11031 * expression.cs (Is.DoResolve): If either side of the `is' is an
11032 interface, do not flag the warning.
11034 * ecore.cs (ImplicitReferenceConversion): We need a separate test
11037 * report.cs: Allow for --fatal to be used with --probe.
11039 * typemanager.cs (NoTypes): Move the definition for the empty Type
11042 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
11044 (TypeContainer.DefineProxy): New function used to proxy to parent
11045 implementations when implementing interfaces.
11046 (TypeContainer.ParentImplements): used to lookup if our parent
11047 implements a public function that is required by an interface.
11048 (TypeContainer.VerifyPendingMethods): Hook this up.
11050 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
11051 `modules' and `assemblies' arraylists into arrays. We only grow
11052 these are the very early start up of the program, so this improves
11053 the speedof LookupType (nicely measured).
11055 * expression.cs (MakeByteBlob): Replaced unsafe code with
11056 BitConverter, as suggested by Paolo.
11058 * cfold.cs (ConstantFold.Binary): Special case: perform constant
11059 folding of string concatenation, but if either side is a string,
11060 and the other is not, then return null, and let the runtime use
11061 the concatenation on the string plus the object (using
11062 `Object.ToString').
11064 2002-03-04 Miguel de Icaza <miguel@ximian.com>
11066 Constant Folding has been implemented now.
11068 * expression.cs (Unary.Reduce): Do not throw an exception, catch
11069 the error instead on types that are not supported in one's
11072 * constant.cs (Constant and all children): New set of functions to
11073 perform implict and explicit conversions.
11075 * ecore.cs (EnumConstant): Implement the new functions to perform
11076 conversion by proxying to the child expression.
11078 * codegen.cs: (ConstantCheckState): Constant evaluation has its
11079 own separate setting that can not be turned off from the command
11080 line using --unchecked or --checked and is only controlled using
11081 the checked/unchecked statements and expressions. This setting is
11082 used by the constant folder to flag errors.
11084 * expression.cs (CheckedExpr, UncheckedExpr): Set the
11085 ConstantCheckState as well.
11087 During Resolve, they also have to flag the state, because the
11088 constant folder runs completely in the Resolve phase.
11090 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
11093 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11095 * cfold.cs: New file, this file contains the constant folder.
11097 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
11098 argument to track whether we are using the resulting address to
11099 load or store a value and provide better error messages.
11101 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
11102 new AddressOf arguments.
11104 * statement.cs (Foreach.EmitCollectionForeach): Update
11106 * expression.cs (Argument.Emit): Call AddressOf with proper
11107 arguments to track usage.
11109 (New.DoEmit): Call AddressOf with new arguments.
11111 (Unary.Emit): Adjust AddressOf call.
11113 2002-03-01 Ravi Pratap <ravi@ximian.com>
11115 * cs-parser.jay (member_access): Change the case for pre-defined types
11116 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
11119 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
11122 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
11123 essentially like methods and apply attributes like MethodImplOptions to them too.
11125 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
11128 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
11129 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
11132 * Update code everywhere accordingly.
11134 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
11136 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
11138 2002-02-28 Ravi Pratap <ravi@ximian.com>
11140 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
11141 try performing lookups against those instead of jumping straight into using
11142 the 'using' clauses.
11144 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
11146 (LookupType): Perform lookups in implicit parents too.
11148 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
11149 sequence as RootContext.LookupType.
11151 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
11152 the various cases of namespace lookups into this method.
11154 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11156 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
11157 in positional arguments)
11159 * class.cs (Operator): Update the AllowedModifiers to contain
11162 * cs-parser.jay: Update operator declaration to allow for the
11163 operator body to be empty.
11165 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
11168 2002-02-27 Miguel de Icaza <miguel@ximian.com>
11170 * class.cs (Method.Emit): Label parameters.
11172 * driver.cs: Return 1 or 0 as the program exit code.
11174 2002-02-26 Miguel de Icaza <miguel@ximian.com>
11176 * expression.cs: Special case the `null' object when trying to
11177 auto-compute the type, as anything can be explicitly converted to
11180 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
11181 spotting this Paolo.
11183 (Expression.ImplicitNumericConversion): Perform comparissions of
11184 the type using the underlying type in the case of an enumeration
11185 rather than using the enumeration type for the compare.
11187 Cope with the underlying == type case, which is not possible to
11190 (Expression.ConvertNumericExplicit): Perform comparissions of
11191 the type using the underlying type in the case of an enumeration
11192 rather than using the enumeration type for the compare.
11194 * driver.cs: If the user does not supply an extension, assume .exe
11196 * cs-parser.jay (if_statement): Rewrote so that we can track the
11197 location for the if statement.
11199 * expression.cs (Binary.ConstantFold): Only concat strings when
11200 the operation is "+", not everything ;-)
11202 * statement.cs (Statement.EmitBoolExpression): Take a location
11204 (If, While, Do): Track location.
11206 * expression.cs (Binary.ResolveOperator): In the object + string
11207 case, I was missing a call to ConvertImplicit
11209 2002-02-25 Ravi Pratap <ravi@ximian.com>
11211 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
11212 Location arguments. Ensure we use RootContext.LookupType to do our work
11213 and not try to do a direct Type.GetType and ModuleBuilder.GetType
11215 * interface.cs (PopulateMethod): Handle the type of the parameter being
11218 * expression.cs (Invocation.BetterFunction): Handle the case when we
11219 have a params method with no fixed arguments and a call is made with no
11222 2002-02-25 Miguel de Icaza <miguel@ximian.com>
11224 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
11225 the verbatim-string-literal
11227 * support.cs (InternalParameters.ParameterModifier): handle null
11229 (InternalParameters.ParameterType): ditto.
11231 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
11232 duplicating the name of the variable parameter.
11233 (GetParameterByName): Fix bug where we were not looking up array
11234 paramters if they were the only present (thanks Paolo!).
11235 (GetParameterInfo): We only have an empty set of types if both
11236 fixed and array are set to null.
11237 (GetParameterInfo-idx): Handle FixedParameter == null
11239 * cs-parser.jay: Handle the case where there is no catch
11240 statements (missing null test).
11242 2002-02-22 Miguel de Icaza <miguel@ximian.com>
11244 * driver.cs (MainDriver): Be conservative on our command line
11247 Catch DirectoryNotFoundException when calling GetFiles.
11249 (SplitPathAndPattern): Used to split the input specification into
11250 a path and a pattern that we can feed to Directory.GetFiles.
11252 2002-02-21 Miguel de Icaza <miguel@ximian.com>
11254 * statement.cs (Fixed): Implement the last case of the Fixed
11255 statement (string handling).
11257 * expression.cs (StringPtr): New class used to return a char * to
11258 a string; Used by the Fixed statement.
11260 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
11262 * expression.cs (Binary.ResolveOperator): Remove redundant
11263 MemberLookup pn parent type.
11264 Optimize union call, we do not need a union if the types are the same.
11265 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
11268 Specialize the use of MemberLookup everywhere, instead of using
11269 the default settings.
11271 (StackAlloc): Implement stackalloc keyword.
11273 * cs-parser.jay: Add rule to parse stackalloc.
11275 * driver.cs: Handle /h, /help, /?
11277 * expression.cs (MakeByteBlob): Removed the hacks we had in place
11278 before we supported unsafe code.
11280 * makefile: add --unsafe to the self compilation of mcs.
11282 2002-02-20 Miguel de Icaza <miguel@ximian.com>
11284 * expression.cs (PointerArithmetic): New class that is used to
11285 perform pointer arithmetic.
11286 (Binary.Resolve): Handle pointer arithmetic
11287 Handle pointer comparission.
11288 (ArrayPtr): Utility expression class that is used to take the
11289 address of an array.
11291 (ElementAccess): Implement array access for pointers
11293 * statement.cs (Fixed): Implement fixed statement for arrays, we
11294 are missing one more case before we are done.
11296 * expression.cs (Indirection): Implement EmitAssign and set the
11297 ExprClass to Variable. This allows pointer dereferences to be
11298 treated as variables, and to have values assigned to them.
11300 * ecore.cs (Expression.StoreFromPtr): New utility function to
11301 store values dereferencing.
11303 2002-02-20 Ravi Pratap <ravi@ximian.com>
11305 * expression.cs (Binary.ResolveOperator): Ensure that we are
11306 not trying to operate on a void type - this fixes the reported
11309 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
11310 the parent implementation is sealed.
11312 * ../errors/cs0239.cs : Add.
11314 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
11316 * typemanager.cs (unverifiable_code_type): Corresponds to
11317 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
11318 which have unsafe code in them.
11320 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
11323 2002-02-19 Miguel de Icaza <miguel@ximian.com>
11325 * cs-tokenizer.cs: Add support for @"litreal strings"
11327 Make tokenizer accept pre-processor directives
11328 on any column (remove the old C-like limitation).
11330 * rootcontext.cs (EmitCode): Emit any global attributes.
11331 (AddGlobalAttributes): Used to keep track of assembly attributes.
11333 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
11335 * cs-parser.jay: Add support for global attributes.
11337 2002-02-17 Miguel de Icaza <miguel@ximian.com>
11339 * expression.cs (Indirection): New helper class. Unary will
11340 create Indirection classes to be able to implement the
11341 IMemoryLocation interface on it.
11343 2002-02-16 Miguel de Icaza <miguel@ximian.com>
11345 * cs-parser.jay (fixed_statement): reference the right statement.
11347 * statement.cs (Fixed.Emit): Finish implementing the fixed
11348 statement for the &x case.
11350 2002-02-14 Miguel de Icaza <miguel@ximian.com>
11352 * class.cs (Property.Define, Method.Define): Remove newslot when
11355 * modifiers.cs: My use of NewSlot when `Abstract' was set was
11356 wrong. NewSlot should only be used if the `new' keyword is present.
11358 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
11359 locating our system dir. Sorry about this.
11361 2002-02-13 Miguel de Icaza <miguel@ximian.com>
11363 * driver.cs (GetSystemDir): Compute correctly the location of our
11364 system assemblies. I was using the compiler directory instead of
11365 the library directory.
11367 2002-02-13 Ravi Pratap <ravi@ximian.com>
11369 * expression.cs (BetterFunction): Put back in what Miguel commented out
11370 since it is the correct fix. The problem is elsewhere ;-)
11372 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
11373 parameters of the parms method are themselves compatible or not !
11375 (StandardConversionExists): Fix very dangerous bug where we were forgetting
11376 to check that a class implements an interface before saying that an implicit
11377 conversion was allowed. Use ImplementsInterface to do the checking.
11379 2002-02-13 Miguel de Icaza <miguel@ximian.com>
11381 * class.cs (Method.Define): Track whether we are an explicit
11382 implementation or not. And only call DefineMethodOverride if we
11383 are an explicit implementation.
11385 (Property.DefineMethod): Ditto.
11387 2002-02-11 Ravi Pratap <ravi@ximian.com>
11389 * expression.cs (BetterFunction): Catch hideous bug which was
11390 preventing us from detecting ambiguous calls due to implicit casts i.e
11393 2002-01-29 Miguel de Icaza <miguel@ximian.com>
11395 * support.cs (Pair): Remove un-needed method. I figured why I was
11396 getting the error in cs-parser.jay, the variable in a foreach loop
11397 is readonly, and the compiler does not really treat this as a variable.
11399 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
11400 instead of EQUALS in grammar.
11402 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
11404 * expression.cs (Unary.DoResolve): Check whether the argument is
11407 2002-01-28 Miguel de Icaza <miguel@ximian.com>
11409 * support.cs: Api for Pair to set a value. Despite the fact that
11410 the variables are public the MS C# compiler refuses to compile
11411 code that accesses the field if the variable is part of a foreach
11414 * statement.cs (Fixed): Begin implementation of the fixed
11417 (Block.AddVariable): Return the VariableInfo on success and null
11418 on failure instead of true/false.
11420 * cs-parser.jay (foreach): Catch errors on variables already
11421 defined (we were ignoring this value before) and properly unwind
11422 the block hierarchy
11424 (fixed_statement): grammar for the fixed statement.
11426 2002-01-25 Miguel de Icaza <miguel@ximian.com>
11428 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
11429 pointer types to be incretemented.
11431 (SizeOf): Implement.
11433 * cs-parser.jay (pointer_member_access): Implement
11434 expr->IDENTIFIER production.
11436 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
11437 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
11440 (Unary): Implement indirection.
11442 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
11443 use in non-unsafe context).
11445 (SimpleName.DoResolve): Check for pointers in field access on safe
11448 (Expression.LoadFromPtr): Factor the load-indirect code in this
11449 function. This was duplicated in UnboxCast and ParameterReference
11451 2002-01-24 Miguel de Icaza <miguel@ximian.com>
11453 * expression.cs (ComposedCast): report an error if a pointer cast
11454 is used in a safe region.
11456 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
11457 pointer type casts in unsafe context.
11459 * codegen.cs (EmitContext): Set up IsUnsafe.
11461 * cs-parser.jay (non_expression_type): Add productions for pointer
11464 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
11465 code. We should not use force into static mode if the method is
11466 not virtual. Fixes bug in MIS
11468 * statement.cs (Do.Emit, While.Emit, For.Emit,
11469 Statement.EmitBoolExpression): Add support to Do and While to
11470 propagate infinite loop as `I do return' semantics.
11472 Improve the For case to also test for boolean constants.
11474 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
11475 to the list of attributes we can add.
11477 Remove `EmitContext' argument.
11479 * class.cs (Method.Define): Apply parameter attributes.
11480 (Constructor.Define): Apply parameter attributes.
11481 (MethodCore.LabelParameters): Move here the core of labeling
11484 * support.cs (ReflectionParameters.ParameterModifier,
11485 InternalParameters.ParameterModifier): Use IsByRef on the type and
11486 only return the OUT bit for these parameters instead of in/out/ref
11489 This is because I miss-understood things. The ParameterInfo.IsIn
11490 and IsOut represent whether the parameter has the [In] and [Out]
11493 2002-01-22 Miguel de Icaza <miguel@ximian.com>
11495 * ecore.cs (FieldExpr.Emit): Release temporaries.
11497 * assign.cs (LocalTemporary.Release): new function.
11499 * codegen.cs (EmitContext.GetTemporaryStorage,
11500 EmitContext.FreeTemporaryStorage): Rework the way we deal with
11501 temporary storage. Now we can "put back" localbuilders when we
11504 2002-01-21 Miguel de Icaza <miguel@ximian.com>
11506 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
11507 need to make a copy of the variable to generate verifiable code.
11509 2002-01-19 Miguel de Icaza <miguel@ximian.com>
11511 * driver.cs: Compute dynamically the system directory.
11513 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
11514 Slower, but more generally useful. Used by the abstract
11515 registering implementation.
11517 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
11518 the rules for the special rule on Type/instances. First check if
11519 we have the same name, and if so, try that special static path
11520 rather than the instance path.
11522 2002-01-18 Miguel de Icaza <miguel@ximian.com>
11524 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
11527 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
11528 Enum, ValueType, Delegate or Array for non-corlib compiles.
11530 * cs-tokenizer.cs: Catch long identifiers (645)
11532 * typemanager.cs (IndexerPropetyName): Ravi never tested this
11535 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
11536 fix, we were returning too early, so we were not registering
11537 pending methods from abstract classes.
11539 Do not register pending methods if the class is abstract.
11541 * expression.cs (Conditional.DoResolve): Report circular implicit
11542 conversions when we neecd to compute it for conditional
11545 (Is.DoResolve): If the expression is always of the provided type,
11546 flag warning 183. If the expression can not ever be of the
11547 provided type flag warning 184.
11549 * class.cs: Catch 169 as well.
11551 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
11554 2002-01-18 Nick Drochak <ndrochak@gol.com>
11556 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
11558 2002-01-17 Miguel de Icaza <miguel@ximian.com>
11560 * interface.cs: (PopulateMethod): Check for pointers being defined
11561 only if the unsafe context is active.
11562 (PopulateProperty): ditto.
11563 (PopulateIndexer): ditto.
11565 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
11566 specified. If pointers are present, make sure that they are
11567 present in an unsafe context.
11568 (Constructor, Constructor.Define): ditto.
11569 (Field, Field.Define): ditto.
11570 (Property, Property.Define): ditto.
11571 (Event, Event.Define): ditto.
11573 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
11574 hashtable if there are classes or structs defined.
11576 * expression.cs (LocalVariableReference.DoResolve): Simplify this
11577 code, as the constant resolution moved.
11579 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
11580 the metadata, so we can flag error 133.
11582 * decl.cs (MemberCore.UnsafeOK): New function to test that a
11583 pointer is being declared in an unsafe context.
11585 2002-01-16 Miguel de Icaza <miguel@ximian.com>
11587 * modifiers.cs (Modifiers.Check): Require a Location argument.
11588 Report error 227 for Unsafe use.
11590 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
11592 * statement.cs (For.Emit): If the test is null, then report that
11593 we do `return', as we wont reach anything afterwards.
11595 (Switch.SwitchGoverningType): Track the expression that matched
11598 * driver.cs: Allow negative numbers as an error code to flag.
11600 * cs-parser.jay: Handle 1551.
11602 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
11604 2002-01-15 Miguel de Icaza <miguel@ximian.com>
11606 * cs-parser.jay: Report 1518 (type declaration can only contain
11607 class, struct, interface, enum or delegate)
11609 (switch_label): Report 1523 (keywords `case' or `default' must
11612 (opt_switch_sections): Report 1522 (empty switch)
11614 * driver.cs: Report 1515 (response file specified multiple times)
11615 Report 1516 (Source file specified multiple times).
11617 * expression.cs (Argument.Resolve): Signal 1510
11619 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
11620 access not allowed in static code)
11622 2002-01-11 Ravi Pratap <ravi@ximian.com>
11624 * typemanager.cs (IsPointerType): Utility method which we are going
11627 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
11628 the object type, so we take care of that.
11630 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
11632 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
11633 added to non-params parameters :-)
11635 * typemanager.cs (CSharpName): Include 'void' type too.
11637 (void_ptr_type): Include in the set of core types.
11639 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
11642 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
11645 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
11646 completely forgotten about it.
11648 2002-01-10 Ravi Pratap <ravi@ximian.com>
11650 * cs-parser.jay (pointer_type): Add. This begins our implementation
11651 of parsing rules for unsafe code.
11653 (unsafe_statement): Implement.
11655 (embedded_statement): Modify to include the above.
11657 * statement.cs (Unsafe): Implement new class for unsafe blocks.
11659 * codegen.cs (EmitContext.InUnsafe): Add. This determines
11660 if the current context is an unsafe one.
11662 * cs-parser.jay (local_variable_pointer_type): Since local variable types
11663 are handled differently, we need separate rules for them.
11665 (local_variable_declaration): Update to use local_variable_pointer_type
11666 to allow variable declarations of unmanaged pointer types.
11668 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
11669 in unsafe contexts.
11671 * ../errors/cs0214.cs : Add.
11673 2002-01-16 Nick Drochak <ndrochak@gol.com>
11675 * makefile: remove 'response' file when cleaning.
11677 2002-01-15 Miguel de Icaza <miguel@ximian.com>
11679 * cs-parser.jay: Report 1524.
11681 2002-01-14 Miguel de Icaza <miguel@ximian.com>
11683 * typemanager.cs (RegisterMethod): drop checking if we have
11684 registered this from here
11686 2002-01-12 Miguel de Icaza <miguel@ximian.com>
11688 * class.cs (Method.EmitDestructor): Implement calling our base
11691 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
11692 value of InFinally.
11694 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
11695 this routine and will wrap the call in a try/catch block. Deal
11698 2002-01-11 Miguel de Icaza <miguel@ximian.com>
11700 * ecore.cs (Expression.MemberLookup): instead of taking a
11701 parameter `same_type' that was used to tell whether we could
11702 access private members we compute our containing type from the
11705 (FieldExpr): Added partial support for volatile fields. This does
11706 not work for volatile fields exposed from assemblies, as I can not
11707 figure out how to extract the modreq from it.
11709 Updated all the source files to use this.
11711 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
11712 because it is referenced by MemberLookup very often.
11714 2002-01-09 Ravi Pratap <ravi@ximian.com>
11716 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
11717 TypeBuilder.GetCustomAttributes to retrieve what we need.
11719 Get rid of redundant default_member_attr_type as this is the same as
11720 default_member_type which already exists.
11722 * interface.cs, attribute.cs : Update accordingly.
11724 2002-01-08 Miguel de Icaza <miguel@ximian.com>
11726 * typemanager.cs: Enable IndexerPropertyName again. It does not
11727 work for TYpeBuilders though. Ravi, can you please fix this?
11729 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
11731 * expression.cs (Argument.Emit): Handle the case of ref objects
11732 being passed to ref functions;
11734 (ParameterReference.EmitLoad): Loads the content of the pointer
11735 without dereferencing.
11737 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11739 * cs-tokenizer.cs: Implemented the pre-processing expressions.
11741 2002-01-08 Ravi Pratap <ravi@ximian.com>
11743 * class.cs (Indexer.DefineMethod): Incorporate the interface
11744 type in the name of the method if we are doing explicit interface
11747 * expression.cs (ConversionExists): Remove as it is completely obsolete.
11749 (BetterConversion): Fix extremely trivial bug where we were referring to
11750 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
11753 * ../errors/bug16.cs : Add although we have fixed it.
11755 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11757 * expression.cs (BaseIndexer): Begin implementation.
11759 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
11761 * cs-parser.jay (indexer_declarator): Use qualified_identifier
11762 production directly to remove a shift/reduce, and implement
11763 explicit interface implementation.
11765 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
11766 after a floating point suffix.
11768 * expression.cs (DoNumericPromotions): Improved the conversion for
11769 uint/uint. If we have a constant, we avoid doing a typecast to a
11772 * class.cs (Indexer): Implement explicit interface implementation
11775 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
11777 * class.cs: make the default instance constructor public and hidebysig.
11779 2001-01-03 Ravi Pratap <ravi@ximian.com>
11781 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
11782 so we can call it from elsewhere.
11784 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
11785 we emit it internally if the class has a defined indexer; otherwise the user
11786 emits it by decorating the class definition with the DefaultMemberAttribute.
11788 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
11789 attribute is not used on a type which defines an indexer.
11791 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
11792 character when we skip whitespace.
11794 * ../errors/cs0646.cs : Add.
11796 2002-01-03 Miguel de Icaza <miguel@ximian.com>
11798 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
11801 * makefile: Add practical target `mcs3.exe' which builds the third
11802 generation compiler.
11804 * expression.cs (New): Fix structures constructor calling.
11806 * class.cs (Property, Method, Indexer): Emit Final flag on the
11807 method if we are an interface implementation and we are not
11810 * ecore.cs (PropertyExpr): New public field `IsBase', tells
11811 whether this property is referencing a `base' method.
11813 * expression.cs (Invocation.EmitCall): take an extra argument:
11814 is_base, this is used to determine whether the `call' or
11815 `callvirt' opcode should be used.
11818 * delegate.cs: update EmitCall.
11820 * class.cs (Method.Define): Set NewSlot for the cases where we are
11821 not implementing an interface method.
11823 (Property.Define): ditto.
11825 2002-01-02 Miguel de Icaza <miguel@ximian.com>
11827 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
11828 'r'. Allows mcs to parse itself fully.
11830 2002-01-02 Ravi Pratap <ravi@ximian.com>
11832 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
11833 of the number of initializers that require the InitializeArray method.
11835 (CheckIndices): Store the Expression in all cases - not the plain value. Also
11836 update the above field where necessary.
11838 (MakeByteBlob): Update accordingly.
11840 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
11843 (EmitDynamicInitializers): Update in accordance with the new optimization.
11845 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
11846 same OpCode applies.
11848 * cs-parser.jay : Fix some glaring errors I introduced.
11850 2002-01-01 Ravi Pratap <ravi@ximian.com>
11852 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
11853 so that we can check for name clashes there too.
11855 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
11856 for interface indexers.
11858 * interfaces.cs (Define): Emit the default member attribute.
11860 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
11861 variable was being referred to while setting the value ;-)
11863 2002-01-01 Miguel de Icaza <miguel@ximian.com>
11865 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
11866 byte-by-byte information when we know the data is zero.
11868 Make the block always a multiple of 4, because
11869 DefineInitializedData has a bug.
11871 * assign.cs: Fix, we should assign from the temporary, not from
11874 * expression.cs (MakeByteBlob): Fix my incorrect code.
11876 2001-12-31 Miguel de Icaza <miguel@ximian.com>
11878 * typemanager.cs (EnumToUnderlying): This function is used to get
11879 the underlying type from an enumeration, because it does not
11882 * constant.cs: Use the I4_S form for values between -128 and 127.
11884 * statement.cs (Block.LookupLabel): Looks up a label.
11885 (Block): Drop support for labeled blocks.
11887 (LabeledStatement): New kind of statement that represents a label
11890 (Goto): Finally implement this bad boy.
11892 * cs-parser.jay: Update to reflect new mechanism to implement
11895 2001-12-30 Miguel de Icaza <miguel@ximian.com>
11897 * codegen.cs (EmitContext.This): a codegen property that keeps the
11898 a single instance of this instead of creating many different this
11901 * delegate.cs (Delegate.DoResolve): Update to use the property;
11903 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
11905 * expression.cs (BaseAccess.DoResolve): Ditto.
11907 2001-12-29 Ravi Pratap <ravi@ximian.com>
11909 * typemanager.cs (methodimpl_attr_type): Add to hold the type
11910 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
11912 (InitCoreTypes): Update accordingly.
11914 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
11915 so we can quickly store the state.
11917 (ApplyAttributes): Set the correct implementation flags
11918 for InternalCall methods.
11920 2001-12-29 Miguel de Icaza <miguel@ximian.com>
11922 * expression.cs (EmitCall): if a method is not virtual, then do
11923 not use callvirt on it.
11925 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
11926 user defined stuff) requires the use of stobj, which takes an
11927 address on the stack instead of an array and an index. So emit
11928 the Ldelema operation for it.
11930 (EmitStoreOpcode): Use stobj for valuetypes.
11932 (UnaryMutator.EmitCode): Use the right 1 value depending on
11933 whether we are dealing with int64/uint64, float or doubles.
11935 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
11936 constructors that I implemented last night.
11938 (Constructor.IsDefault): Fix to work properly for static
11941 * cs-parser.jay (CheckDef): report method signature errors.
11942 Update error number 103 to be 132.
11944 * decl.cs: New AdditionResult enumeration value: MethodExists.
11945 Although we do this check for methods later on in the semantic
11946 analysis, catching repeated default constructors is so easy that
11947 we catch these here.
11949 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
11952 (ParameterReference.EmitAssign, Emit): handle
11955 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
11956 (ArrayAccess.EmitStoreOpcode): ditto.
11958 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
11960 * expression.cs (MakeByteBlob): Complete all the missing types
11961 (uint, short, ushort, byte, sbyte)
11963 * class.cs: Only init instance field initializers on instance
11966 Rename `constructors' to instance_constructors.
11968 (TypeContainer.AddConstructor): Only add constructors to the list
11969 if it is not static.
11971 Make sure that we handle default_static_constructor independently
11972 everywhere where we handle instance_constructors
11974 2001-12-28 Miguel de Icaza <miguel@ximian.com>
11976 * class.cs: Do not lookup or create a base initializer for a
11977 static constructor.
11979 (ConstructorInitializer.Resolve): use the proper type to lookup
11982 * cs-parser.jay: Report error 1585 (modifiers between type and name).
11984 * enum.cs, interface.cs: Remove CloseType, this is taken care by
11987 * decl.cs: CloseType is now an virtual method, the default
11988 implementation just closes this type.
11990 2001-12-28 Ravi Pratap <ravi@ximian.com>
11992 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
11993 to PreserveSig by default. Also emit HideBySig on such methods.
11995 Basically, set the defaults to standard values.
11997 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
11998 argument, if candidate is better, it can't be worse than the best !
12000 (Invocation): Re-write bits to differentiate between methods being
12001 applicable in their expanded form and their normal form - for params
12004 Get rid of use_standard everywhere as only standard conversions are allowed
12005 in overload resolution.
12007 More spec conformance.
12009 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12011 * driver.cs: Add --timestamp, to see where the compiler spends
12014 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
12015 `this' in static code.
12017 (SimpleName.DoResolve): Implement in terms of a helper function
12018 that allows static-references to be passed upstream to
12021 (Expression.ResolveWithSimpleName): Resolve specially simple
12022 names when called by MemberAccess to implement the special
12025 (Expression.ImplicitReferenceConversion): Handle conversions from
12026 Null to reference types before others, as Null's type is
12029 * expression.cs (Invocation.EmitCall): Handle the special case of
12030 calling methods declared on a reference type from a ValueType
12031 (Base classes System.Object and System.Enum)
12033 (MemberAccess.Resolve): Only perform lookups on Enumerations if
12034 the left hand side is a TypeExpr, not on every enumeration.
12036 (Binary.Resolve): If types are reference types, then do a cast to
12037 object on operators != and == of both arguments.
12039 * typemanager.cs (FindMembers): Extract instance and static
12040 members if requested.
12042 * interface.cs (PopulateProperty): Use void_type instead of null
12043 as the return type for the setter method.
12045 (PopulateIndexer): ditto.
12047 2001-12-27 Ravi Pratap <ravi@ximian.com>
12049 * support.cs (ReflectionParameters): Fix minor bug where we
12050 were examining the wrong parameter for the ParamArray attribute.
12052 Cope with requests for the type of the parameter at position
12053 greater than the params parameter's. We now return the element
12054 type of the params array as that makes more sense.
12056 * expression.cs (Invocation.IsParamsMethodApplicable): Update
12057 accordingly as we no longer have to extract the element type
12060 (Invocation.OverloadResolve): Update.
12062 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12064 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
12065 against IEnumerator, test whether the return value is a descendant
12066 of the IEnumerator interface.
12068 * class.cs (Indexer.Define): Use an auxiliary method to implement
12069 the other bits of the method definition. Begin support for
12070 explicit interface implementation.
12072 (Property.DefineMethod): Use TypeManager.void_type instead of null
12073 for an empty return value.
12075 2001-12-26 Miguel de Icaza <miguel@ximian.com>
12077 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
12078 dealing with a FieldExpr which is composed of a FieldBuilder, in
12079 the code path we did extract the constant, but we should have
12080 obtained the underlying value to be able to cast it (otherwise we
12081 end up in an infinite loop, this is what Ravi was running into).
12083 (ArrayCreation.UpdateIndices): Arrays might be empty.
12085 (MemberAccess.ResolveMemberAccess): Add support for section
12086 14.5.4.1 that deals with the special case of E.I when E is a type
12087 and something else, that I can be a reference to a static member.
12089 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
12090 handle a particular array type to create byte blobs, it is just
12091 something we dont generate byteblobs for.
12093 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
12096 * location.cs (Push): remove the key from the hashtable that we
12097 are about to add. This happens for empty files.
12099 * driver.cs: Dispose files after we have parsed them.
12101 (tokenize): new function that only runs the tokenizer on its
12102 input, for speed testing.
12104 2001-12-26 Ravi Pratap <ravi@ximian.com>
12106 * class.cs (Event.Define): Define the private field only if there
12107 are no accessors defined.
12109 * expression.cs (ResolveMemberAccess): If there is no associated
12110 field with the event, that means we have an event defined with its
12111 own accessors and we should flag error cs0070 since transforming
12112 ourselves into a field is not valid in that case.
12114 * ecore.cs (SimpleName.DoResolve): Same as above.
12116 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
12117 and charset to sane values.
12119 2001-12-25 Ravi Pratap <ravi@ximian.com>
12121 * assign.cs (DoResolve): Perform check on events only if they
12122 are being accessed outside the declaring type.
12124 * cs-parser.jay (event_declarations): Update rules to correctly
12125 set the type of the implicit parameter etc.
12127 (add_accessor, remove_accessor): Set current local parameters.
12129 * expression.cs (Binary): For delegate addition and subtraction,
12130 cast the return value from the method into the appropriate delegate
12133 2001-12-24 Ravi Pratap <ravi@ximian.com>
12135 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
12136 of these as the workaround is unnecessary.
12138 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
12139 delegate data - none of that is needed at all.
12141 Re-write bits to extract the instance expression and the delegate method
12144 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
12147 * attribute.cs (ApplyAttributes): New method to take care of common tasks
12148 of attaching attributes instead of duplicating code everywhere.
12150 * everywhere : Update code to do attribute emission using the above method.
12152 2001-12-23 Miguel de Icaza <miguel@ximian.com>
12154 * expression.cs (IsParamsMethodApplicable): if there are not
12155 parameters, return immediately.
12157 * ecore.cs: The 0 literal can be implicity converted to an enum
12160 (SimpleName.DoResolve): First lookup the type, then lookup the
12163 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
12164 want to get its address. If the InstanceExpression is not
12165 addressable, store the result in a temporary variable, then get
12168 * codegen.cs: Only display 219 errors on warning level or above.
12170 * expression.cs (ArrayAccess): Make it implement the
12171 IMemoryLocation interface.
12173 (Binary.DoResolve): handle the operator == (object a, object b)
12174 and operator != (object a, object b) without incurring into a
12175 BoxedCast (because 5 != o should never be performed).
12177 Handle binary enumerator operators.
12179 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
12180 value type, otherwise use Ldelem_ref.
12182 Use precomputed names;
12184 (AddressOf): Implement address of
12186 * cs-parser.jay (labeled_statement): Fix recursive block
12187 addition by reworking the production.
12189 * expression.cs (New.DoEmit): New has a special case:
12191 If we are dealing with a ValueType, we have a few
12192 situations to deal with:
12194 * The target of New is a ValueType variable, that is
12195 easy, we just pass this as the variable reference
12197 * The target of New is being passed as an argument,
12198 to a boxing operation or a function that takes a
12201 In this case, we need to create a temporary variable
12202 that is the argument of New.
12205 2001-12-23 Ravi Pratap <ravi@ximian.com>
12207 * rootcontext.cs (LookupType): Check that current_type is not null before
12208 going about looking at nested types.
12210 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
12211 not implement the IAssignMethod interface any more.
12213 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
12214 where we tranform them into FieldExprs if they are being resolved from within
12215 the declaring type.
12217 * ecore.cs (SimpleName.DoResolve): Do the same here.
12219 * assign.cs (DoResolve, Emit): Clean up code considerably.
12221 * ../errors/bug10.cs : Add.
12223 * ../errors/cs0070.cs : Add.
12225 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
12227 * assign.cs : Get rid of EventIsLocal everywhere.
12229 2001-12-23 Miguel de Icaza <miguel@ximian.com>
12231 * ecore.cs (ConvertIntLiteral): finished the implementation.
12233 * statement.cs (SwitchLabel): Convert the value we are using as a
12234 key before looking up the table.
12236 2001-12-22 Miguel de Icaza <miguel@ximian.com>
12238 * codegen.cs (EmitTopBlock): Require a Location argument now.
12240 * cs-parser.jay (constructor_declarator): We need to setup
12241 current_local_parameters before we parse the
12242 opt_constructor_initializer, to allow the variables to be bound
12243 to the constructor arguments.
12245 * rootcontext.cs (LookupType): First lookup nested classes in our
12246 class and our parents before we go looking outside our class.
12248 * expression.cs (ConstantFold): Extract/debox the values at the
12251 * rootcontext.cs (EmitCode): Resolve the constants first before we
12252 resolve the types. This is not really needed, but it helps debugging.
12254 * statement.cs: report location.
12256 * cs-parser.jay: pass location to throw statement.
12258 * driver.cs: Small bug fix.
12260 * report.cs: Updated format to be 4-zero filled digits.
12262 2001-12-22 Ravi Pratap <ravi@ximian.com>
12264 * expression.cs (CheckIndices): Fix minor bug where the wrong
12265 variable was being referred to ;-)
12267 (DoEmit): Do not call EmitStaticInitializers when the
12268 underlying type is System.Object.
12270 2001-12-21 Ravi Pratap <ravi@ximian.com>
12272 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
12273 and do the usual workaround for SRE.
12275 * class.cs (MyEventBuilder.EventType): New member to get at the type
12276 of the event, quickly.
12278 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
12280 * assign.cs (Assign.DoResolve): Handle the case when the target
12281 is an EventExpr and perform the necessary checks.
12283 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
12286 (SimpleName.MemberStaticCheck): Include check for EventExpr.
12288 (EventExpr): Set the type in the constructor itself since we
12289 are meant to be born fully resolved.
12291 (EventExpr.Define): Revert code I wrote earlier.
12293 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
12294 instance expression is null. The instance expression is a This in that case
12295 or a null, depending on whether it is a static method or not.
12297 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
12298 refers to more than one method.
12300 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
12301 and accordingly flag errors.
12303 2001-12-21 Miguel de Icaza <miguel@ximian.com>
12305 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
12307 2001-12-22 Miguel de Icaza <miguel@ximian.com>
12309 * location.cs (ToString): Provide useful rutine.
12311 2001-12-21 Miguel de Icaza <miguel@ximian.com>
12313 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
12314 objects, return the actual integral boxed.
12316 * statement.cs (SwitchLabel): define an ILLabel for each
12319 (Switch.CheckSwitch): If the value is a Literal, extract
12320 the underlying literal.
12322 Also in the unused hashtable we had, add the SwitchLabel so we can
12323 quickly look this value up.
12325 * constant.cs: Implement a bunch of new constants. Rewrite
12326 Literal based on this. Made changes everywhere to adapt to this.
12328 * expression.cs (Expression.MakeByteBlob): Optimize routine by
12329 dereferencing array only once, and also copes with enumrations.
12331 bytes are two bytes wide, not one.
12333 (Cast): Perform constant conversions.
12335 * ecore.cs (TryImplicitIntConversion): Return literals instead of
12336 wrappers to the literals here.
12338 * expression.cs (DoNumericPromotions): long literals can converted
12339 to ulong implicity (this is taken care of elsewhere, but I was
12340 missing this spot).
12342 * ecore.cs (Expression.Literalize): Make the return type Literal,
12343 to improve type checking.
12345 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
12347 2001-12-20 Miguel de Icaza <miguel@ximian.com>
12349 * literal.cs: Revert code from ravi that checked the bounds. The
12350 bounds are sane by the definition of the type itself.
12352 * typemanager.cs: Fix implementation of ImplementsInterface. We
12353 need to actually look up in our parent hierarchy for interfaces
12356 * const.cs: Use the underlying type for enumerations
12358 * delegate.cs: Compute the basename for the delegate creation,
12359 that should fix the delegate test case, and restore the correct
12360 Type Lookup semantics in rootcontext
12362 * rootcontext.cs: Revert Ravi's last patch. The correct way of
12363 referencing a nested type with the Reflection API is using the "+"
12366 * cs-parser.jay: Do not require EOF token at the end.
12368 2001-12-20 Ravi Pratap <ravi@ximian.com>
12370 * rootcontext.cs (LookupType): Concatenate type names with
12371 a '.' instead of a '+' The test suite passes again.
12373 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
12374 field of the enumeration.
12376 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
12377 the case when the member is an EventExpr.
12379 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
12380 static has an associated instance expression.
12382 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
12384 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
12386 * class.cs (Event.Define): Register event and perform appropriate checks
12389 We define the Add and Remove methods even if the use provides none because
12390 in that case, we provide default implementations ourselves.
12392 Define a private field of the type of the event. This is done by the CSC compiler
12393 and we should be doing it too ;-)
12395 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
12396 More methods we use in code we generate.
12398 (multicast_delegate_type, delegate_type): Two separate types since the distinction
12401 (InitCoreTypes): Update accordingly for the above.
12403 * class.cs (Event.Emit): Generate code for default accessors that we provide
12405 (EmitDefaultMethod): Do the job in the above.
12407 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
12410 2001-12-20 Miguel de Icaza <miguel@ximian.com>
12412 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
12413 builders even if we were missing one.
12415 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
12416 pass the Basename as our class name instead of the Name. The
12417 basename will be correctly composed for us.
12419 * parameter.cs (Paramters): Now takes a Location argument.
12421 * decl.cs (DeclSpace.LookupType): Removed convenience function and
12422 make all the code call directly LookupType in RootContext and take
12423 this chance to pass the Location information everywhere.
12425 * Everywhere: pass Location information.
12427 2001-12-19 Miguel de Icaza <miguel@ximian.com>
12429 * class.cs (Constructor.Define): Updated way of detecting the
12430 length of the parameters.
12432 (TypeContainer.DefineType): Use basename as the type name for
12435 (TypeContainer.Define): Do not recursively define types here, as
12436 definition is taken care in order by the RootContext.
12438 * tree.cs: Keep track of namespaces in a per-file basis.
12440 * parameter.cs (Parameter.ComputeSignature): Update to use
12443 (Parameters.GetSignature): ditto.
12445 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
12446 instead of a TypeContainer.
12448 (Interface.SemanticAnalysis): Use `this' instead of our parent to
12449 resolve names. Because we need to be resolve in our context, not
12452 * driver.cs: Implement response files.
12454 * class.cs (TypeContainer.DefineType): If we are defined, do not
12455 redefine ourselves.
12457 (Event.Emit): Emit the code for add/remove handlers.
12458 (Event.Define): Save the MethodBuilders for add/remove.
12460 * typemanager.cs: Use pair here too.
12462 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
12463 DictionaryEntry requires the first argument to be non-null.
12465 (enum_declaration): Compute full name for registering the
12468 (delegate_declaration): Instead of using
12469 formal_parameter_list, use opt_formal_parameter_list as the list
12472 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
12473 (EventParsing): New property that controls whether `add' and
12474 `remove' are returned as tokens or identifiers (for events);
12476 2001-12-19 Ravi Pratap <ravi@ximian.com>
12478 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
12479 use MyEventBuilder only and let it wrap the real builder for us.
12481 (MyEventBuilder): Revamp constructor etc.
12483 Implement all operations that we perform on EventBuilder in precisely the same
12486 (FindMembers): Update to use the EventBuilder member.
12488 (Event.Emit): Update accordingly.
12490 2001-12-18 Ravi Pratap <ravi@ximian.com>
12492 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
12493 by calling the appropriate methods.
12495 (GetCustomAttributes): Make stubs as they cannot possibly do anything
12498 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
12500 2001-12-17 Ravi Pratap <ravi@ximian.com>
12502 * delegate.cs (Delegate.Populate): Check that the return type
12503 and various parameters types are indeed accessible.
12505 * class.cs (Constructor.Define): Same here.
12507 (Field.Define): Ditto.
12509 (Event.Define): Ditto.
12511 (Operator.Define): Check that the underlying Method defined itself
12512 correctly - so it's MethodBuilder should not be null.
12514 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
12515 expression happens to be null.
12517 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
12518 members but as of now we don't seem to be able to do anything really useful with it.
12520 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
12521 not the EventBuilder.
12523 2001-12-18 Miguel de Icaza <miguel@ximian.com>
12525 * cs-tokenizer.cs: Add support for defines.
12526 Add support for #if, #elif, #else, #endif
12528 (eval_var): evaluates a variable.
12529 (eval): stubbed for evaluating functions.
12531 * cs-parser.jay: Pass the defines information
12533 * driver.cs: Add --define command line option.
12535 * decl.cs: Move MemberCore here.
12537 Make it the base class for DeclSpace. This allows us to catch and
12538 report 108 and 109 for everything now.
12540 * class.cs (TypeContainer.Define): Extract all the members
12541 before populating and emit the warning 108 (new keyword required
12542 to override) instead of having each member implement this.
12544 (MemberCore.Define): New abstract method, we will be using this in
12545 the warning reporting engine in Populate.
12547 (Operator.Define): Adjust to new MemberCore protocol.
12549 * const.cs (Const): This does not derive from Expression, it is a
12550 temporary object we use to create fields, it is a MemberCore.
12552 * class.cs (Method.Define): Allow the entry point to be in a
12555 * driver.cs: Rewrite the argument handler to clean it up a bit.
12557 * rootcontext.cs: Made it just an auxiliary namespace feature by
12558 making everything static.
12560 * driver.cs: Adapt code to use RootContext type name instead of
12563 * delegate.cs: Remove RootContext argument.
12565 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
12568 * class.cs (Event.Define): The lookup can fail.
12570 * cs-tokenizer.cs: Begin implementation of pre-procesor.
12572 * expression.cs: Resolve the this instance before invoking the code.
12574 2001-12-17 Miguel de Icaza <miguel@ximian.com>
12576 * cs-parser.jay: Add a production in element_access that allows
12577 the thing to become a "type" reference. This way we can parse
12578 things like "(string [])" as a type.
12580 Note that this still does not handle the more complex rules of
12584 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
12586 * ecore.cs: (CopyNewMethods): new utility function used to
12587 assemble the list of methods from running FindMembers.
12589 (MemberLookup): Rework FindMembers so that
12591 2001-12-16 Miguel de Icaza <miguel@ximian.com>
12593 * class.cs (TypeContainer): Remove Delegates who fail to be
12596 * delegate.cs (Populate): Verify that we dont get null return
12597 values. TODO: Check for AsAccessible.
12599 * cs-parser.jay: Use basename to emit error 574 (destructor should
12600 have the same name as container class), not the full name.
12602 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
12603 possible representation.
12605 Also implements integer type suffixes U and L.
12607 2001-12-15 Miguel de Icaza <miguel@ximian.com>
12609 * expression.cs (ArrayCreation.DoResolve): We need to do the
12610 argument resolution *always*.
12612 * decl.cs: Make this hold the namespace. Hold the root context as
12614 (LookupType): Move here.
12616 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
12618 * location.cs (Row, Name): Fixed the code, it was always returning
12619 references to the first file.
12621 * interface.cs: Register properties defined through interfaces.
12623 * driver.cs: Add support for globbing on the command line
12625 * class.cs (Field): Make it derive from MemberCore as well.
12628 2001-12-15 Ravi Pratap <ravi@ximian.com>
12630 * class.cs (Event::Define): Check that the type of the event is a delegate
12631 type else flag error #66.
12633 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
12636 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
12637 values of EntryPoint, CharSet etc etc.
12639 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
12641 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
12642 be null and we should ignore this. I am not sure if this is really clean. Apparently,
12643 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
12644 which needs this to do its work.
12646 * ../errors/cs0066.cs : Add.
12648 2001-12-14 Miguel de Icaza <miguel@ximian.com>
12650 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
12653 * class.cs: (MethodSignature.MethodSignature): Removed hack that
12654 clears out the parameters field.
12655 (MemberSignatureCompare): Cleanup
12657 (MemberCore): New base class used to share code between MethodCore
12660 (RegisterRequiredImplementations) BindingFlags.Public requires
12661 either BindingFlags.Instace or Static. Use instance here.
12663 (Property): Refactored code to cope better with the full spec.
12665 * parameter.cs (GetParameterInfo): Return an empty array instead
12668 * class.cs (Property): Abstract or extern properties have no bodies.
12670 * parameter.cs (GetParameterInfo): return a zero-sized array.
12672 * class.cs (TypeContainer.MethodModifiersValid): Move all the
12673 method modifier validation to the typecontainer so we can reuse
12674 this on properties.
12676 (MethodCore.ParameterTypes): return an empty sized array of types.
12678 (Property.Define): Test property modifier validity.
12680 Add tests for sealed/override too.
12682 (Method.Emit): abstract or extern methods have no bodies.
12684 2001-12-14 Ravi Pratap <ravi@ximian.com>
12686 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
12689 (Method::Define, ::Emit): Modify accordingly.
12691 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
12693 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
12695 * makefile: Pass in /unsafe.
12697 2001-12-13 Miguel de Icaza <miguel@ximian.com>
12699 * class.cs (MakeKey): Kill routine.
12701 * class.cs (TypeContainer.Define): Correctly define explicit
12702 method implementations (they require the full interface name plus
12705 * typemanager.cs: Deply the PtrHashtable here and stop using the
12706 lame keys. Things work so much better.
12708 This of course broke everyone who depended on `RegisterMethod' to
12709 do the `test for existance' test. This has to be done elsewhere.
12711 * support.cs (PtrHashtable): A hashtable that avoid comparing with
12712 the object stupid Equals method (because, that like fails all over
12713 the place). We still do not use it.
12715 * class.cs (TypeContainer.SetRequiredInterface,
12716 TypeContainer.RequireMethods): Killed these two routines and moved
12717 all the functionality to RegisterRequiredImplementations.
12719 (TypeContainer.RegisterRequiredImplementations): This routine now
12720 registers all the implementations required in an array for the
12721 interfaces and abstract methods. We use an array of structures
12722 which can be computed ahead of time to reduce memory usage and we
12723 also assume that lookups are cheap as most classes will not
12724 implement too many interfaces.
12726 We also avoid creating too many MethodSignatures.
12728 (TypeContainer.IsInterfaceMethod): Update and optionally does not
12729 clear the "pending" bit if we find that there are problems with
12732 (TypeContainer.VerifyPendingMethods): Update to report errors of
12733 methods that look like implementations but are not.
12735 (TypeContainer.Define): Add support for explicit interface method
12738 2001-12-12 Miguel de Icaza <miguel@ximian.com>
12740 * typemanager.cs: Keep track of the parameters here instead of
12741 being a feature of the TypeContainer.
12743 * class.cs: Drop the registration of parameters here, as
12744 InterfaceMethods are also interface declarations.
12746 * delegate.cs: Register methods with the TypeManager not only with
12747 the TypeContainer. This code was buggy.
12749 * interface.cs: Full registation here.
12751 2001-12-11 Miguel de Icaza <miguel@ximian.com>
12753 * expression.cs: Remove reducer for binary expressions, it can not
12756 * const.cs: Put here the code that used to go into constant.cs
12758 * constant.cs: Put here the code for constants, this is a new base
12759 class for Literals.
12761 * literal.cs: Make Literal derive from Constant.
12763 2001-12-09 Miguel de Icaza <miguel@ximian.com>
12765 * statement.cs (Return.Emit): Report error 157 if the user
12766 attempts to return from a finally block.
12768 (Return.Emit): Instead of emitting a return, jump to the end of
12771 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
12772 LocalBuilder to store the result of the function. ReturnLabel is
12773 the target where we jump.
12776 2001-12-09 Radek Doulik <rodo@ximian.com>
12778 * cs-parser.jay: remember alias in current namespace
12780 * ecore.cs (SimpleName::DoResolve): use aliases for types or
12783 * class.cs (LookupAlias): lookup alias in my_namespace
12785 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
12787 (LookupAlias): lookup alias in this and if needed in parent
12790 2001-12-08 Miguel de Icaza <miguel@ximian.com>
12794 * rootcontext.cs: (ModuleBuilder) Made static, first step into
12795 making things static. I need this to avoid passing the
12796 TypeContainer when calling ParameterType.
12798 * support.cs (InternalParameters.ParameterType): Remove ugly hack
12799 that did string manipulation to compute the type and then call
12800 GetType. Use Parameter.ParameterType instead.
12802 * cs-tokenizer.cs: Consume the suffix for floating values.
12804 * expression.cs (ParameterReference): figure out whether this is a
12805 reference parameter or not. Kill an extra variable by computing
12806 the arg_idx during emission.
12808 * parameter.cs (Parameters.GetParameterInfo): New overloaded
12809 function that returns whether a parameter is an out/ref value or not.
12811 (Parameter.ParameterType): The type of the parameter (base,
12812 without ref/out applied).
12814 (Parameter.Resolve): Perform resolution here.
12815 (Parameter.ExternalType): The full type (with ref/out applied).
12817 * statement.cs (Using.Emit, Using.EmitExpression): Implement
12818 support for expressions on the using statement.
12820 2001-12-07 Miguel de Icaza <miguel@ximian.com>
12822 * statement.cs (Using.EmitLocalVariableDecls): Split the
12823 localvariable handling of the using statement.
12825 (Block.EmitMeta): Keep track of variable count across blocks. We
12826 were reusing slots on separate branches of blocks.
12828 (Try.Emit): Emit the general code block, we were not emitting it.
12830 Check the type of the declaration to be an IDisposable or
12831 something that can be implicity converted to it.
12833 Emit conversions if required.
12835 * ecore.cs (EmptyExpression): New utility class.
12836 (Expression.ImplicitConversionExists): New utility function.
12838 2001-12-06 Miguel de Icaza <miguel@ximian.com>
12840 * statement.cs (Using): Implement.
12842 * expression.cs (LocalVariableReference): Support read only variables.
12844 * statement.cs: Remove the explicit emit for the Leave opcode.
12845 (VariableInfo): Add a readonly field.
12847 2001-12-05 Miguel de Icaza <miguel@ximian.com>
12849 * ecore.cs (ConvCast): new class used to encapsulate the various
12850 explicit integer conversions that works in both checked and
12851 unchecked contexts.
12853 (Expression.ConvertNumericExplicit): Use new ConvCast class to
12854 properly generate the overflow opcodes.
12856 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12858 * statement.cs: The correct type for the EmptyExpression is the
12859 element_type, not the variable type. Ravi pointed this out.
12861 2001-12-04 Ravi Pratap <ravi@ximian.com>
12863 * class.cs (Method::Define): Handle PInvoke methods specially
12864 by using DefinePInvokeMethod instead of the usual one.
12866 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
12867 above to do the task of extracting information and defining the method.
12869 2001-12-04 Ravi Pratap <ravi@ximian.com>
12871 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
12872 of the condition for string type.
12874 (Emit): Move that here.
12876 (ArrayCreation::CheckIndices): Keep string literals in their expression
12879 (EmitDynamicInitializers): Handle strings appropriately.
12881 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12883 * codegen.cs (EmitContext): Replace multiple variables with a
12884 single pointer to the current Switch statement.
12886 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
12889 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12893 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
12896 (Foreach.Emit): Foreach on arrays was not setting
12897 up the loop variables (for break/continue).
12899 (GotoCase): Semi-implented.
12901 2001-12-03 Ravi Pratap <ravi@ximian.com>
12903 * attribute.cs (CheckAttribute): Handle system attributes by using
12904 Attribute.GetAttributes to examine information we need.
12906 (GetValidPlaces): Same here.
12908 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
12910 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
12912 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
12914 (Method::Define): Set appropriate flags if we have a DllImport attribute.
12916 (Method::Emit): Handle the case when we are a PInvoke method.
12918 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12920 * expression.cs: Use ResolveWithSimpleName on compound names.
12922 2001-12-02 Ravi Pratap <ravi@ximian.com>
12924 * constant.cs (EmitConstant): Make sure we resolve the associated expression
12925 before trying to reduce it.
12927 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
12929 * constant.cs (LookupConstantValue): Implement.
12931 (EmitConstant): Use the above in emitting the constant.
12933 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
12934 that are user-defined by doing a LookupConstantValue on them.
12936 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
12939 2001-11-29 Miguel de Icaza <miguel@ximian.com>
12941 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
12943 (BaseAccess.DoResolve): Implement.
12945 (MemberAccess.DoResolve): Split this routine into a
12946 ResolveMemberAccess routine that can be used independently
12948 2001-11-28 Miguel de Icaza <miguel@ximian.com>
12950 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
12951 As that share bits of the implementation. Is returns a boolean,
12952 while As returns the Type that is being probed.
12954 2001-12-01 Ravi Pratap <ravi@ximian.com>
12956 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
12957 instead of a Literal - much easier.
12959 (EnumInTransit): Remove - utterly useless :-)
12961 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
12963 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
12965 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
12966 chain when we have no associated expression.
12968 2001-11-30 Ravi Pratap <ravi@ximian.com>
12970 * constant.cs (Define): Use Location while reporting the errror.
12972 Also emit a warning when 'new' is used and there is no inherited
12975 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
12978 (LookupEnumValue): Implement to lookup an enum member's value and define it
12981 (Populate): Re-write accordingly to use the above routine.
12983 2001-11-27 Miguel de Icaza <miguel@ximian.com>
12985 * expression.cs (This): Fix prototype for DoResolveLValue to
12986 override the base class DoResolveLValue.
12988 * cs-parser.cs: Report errors cs574 and cs575 (destructor
12991 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
12992 (we need to load the address of the field here). This fixes
12995 (FieldExpr.DoResolveLValue): Call the DoResolve
12996 function to initialize the Instance expression.
12998 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
12999 correctly the GetEnumerator operation on a value type.
13001 * cs-parser.jay: Add more simple parsing error catches.
13003 * statement.cs (Switch): Add support for string switches.
13004 Handle null specially.
13006 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
13008 2001-11-28 Ravi Pratap <ravi@ximian.com>
13010 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
13012 (declare_local_constant): New helper function.
13014 * statement.cs (AddConstant): Keep a separate record of constants
13016 (IsConstant): Implement to determine if a variable is a constant.
13018 (GetConstantExpression): Implement.
13020 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
13022 * statement.cs (IsVariableDefined): Re-write.
13024 2001-11-27 Ravi Pratap <ravi@ximian.com>
13026 * class.cs (TypeContainer::FindMembers): Look for constants
13027 in the case when we are looking for MemberTypes.Field
13029 * expression.cs (MemberAccess::DoResolve): Check that in the
13030 case we are a FieldExpr and a Literal, we are not being accessed
13031 by an instance reference.
13033 * cs-parser.jay (local_constant_declaration): Implement.
13035 (declaration_statement): Implement for constant declarations.
13037 2001-11-26 Miguel de Icaza <miguel@ximian.com>
13039 * statement.cs (Switch): Catch double defaults.
13041 (Switch): More work on the switch() statement
13042 implementation. It works for integral values now, need to finish
13046 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13048 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
13049 integer literals into other integer literals. To be used by
13052 2001-11-24 Ravi Pratap <ravi@ximian.com>
13054 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
13057 (EmitDynamicInitializers): Cope with the above since we extract data
13058 directly from ArrayData now.
13060 (ExpectInitializers): Keep track of whether initializers are mandatory
13063 (Bounds): Make it a hashtable to prevent the same dimension being
13064 recorded for every element in that dimension.
13066 (EmitDynamicInitializers): Fix bug which prevented the Set array method
13069 Also fix bug which was causing the indices to be emitted in the reverse
13072 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13074 * expression.cs (ArrayCreation): Implement the bits that Ravi left
13075 unfinished. They do not work, because the underlying code is
13078 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13080 * cs-parser.jay: Remove bogus fixme.
13082 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
13083 on Switch statement.
13085 2001-11-23 Ravi Pratap <ravi@ximian.com>
13087 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
13090 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
13091 parameter. Apparently, any expression is allowed.
13093 (ValidateInitializers): Update accordingly.
13095 (CheckIndices): Fix some tricky bugs thanks to recursion.
13097 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
13098 I was being completely brain-dead.
13100 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
13101 and re-write acordingly.
13103 (DelegateInvocation): Re-write accordingly.
13105 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
13107 (MakeByteBlob): Handle types more correctly.
13109 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
13110 initialization from expressions but it is incomplete because I am a complete
13113 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13115 * statement.cs (If.Emit): Fix a bug that generated incorrect code
13116 on If. Basically, we have to return `true' (ie, we do return to
13117 our caller) only if both branches of the if return.
13119 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
13120 short-circuit operators, handle them as short circuit operators.
13122 (Cast.DoResolve): Resolve type.
13123 (Cast.Cast): Take an expression as the target type.
13125 * cs-parser.jay (cast_expression): Remove old hack that only
13126 allowed a limited set of types to be handled. Now we take a
13127 unary_expression and we resolve to a type during semantic
13130 Use the grammar productions from Rhys to handle casts (this is
13131 not complete like Rhys syntax yet, we fail to handle that corner
13132 case that C# has regarding (-x), but we will get there.
13134 2001-11-22 Ravi Pratap <ravi@ximian.com>
13136 * class.cs (EmitFieldInitializer): Take care of the case when we have a
13137 field which is an array type.
13139 * cs-parser.jay (declare_local_variables): Support array initialization too.
13141 * typemanager.cs (MakeKey): Implement.
13143 (everywhere): Use the above appropriately.
13145 * cs-parser.jay (for_statement): Update for array initialization while
13146 declaring variables.
13148 * ecore.cs : The error message was correct, it's the variable's names that
13149 were misleading ;-) Make the code more readable.
13151 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
13152 the correct type etc.
13154 (ConvertExplicit): Handle Enum types by examining the underlying type.
13156 2001-11-21 Ravi Pratap <ravi@ximian.com>
13158 * parameter.cs (GetCallingConvention): Always return
13159 CallingConventions.Standard for now.
13161 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13163 * expression.cs (Binary.ResolveOperator): Update the values of `l'
13164 and `r' after calling DoNumericPromotions.
13166 * ecore.cs: Fix error message (the types were in the wrong order).
13168 * statement.cs (Foreach.ProbeCollectionType): Need to pass
13169 BindingFlags.Instance as well
13171 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
13172 implicit int literal conversion in an empty cast so that we
13173 propagate the right type upstream.
13175 (UnboxCast): new class used to unbox value types.
13176 (Expression.ConvertExplicit): Add explicit type conversions done
13179 (Expression.ImplicitNumericConversion): Oops, forgot to test for
13180 the target type before applying the implicit LongLiterals to ULong
13183 2001-11-21 Miguel de Icaza <miguel@ximian.com>
13185 * cs-parser.jay (for_statement): Reworked the way For works: now
13186 we declare manually any variables that are introduced in
13187 for_initializer to solve the problem of having out-of-band code
13188 emition (that is what got for broken).
13190 (declaration_statement): Perform the actual variable declaration
13191 that used to be done in local_variable_declaration here.
13193 (local_variable_declaration): Do not declare anything, just pass
13194 the information on a DictionaryEntry
13196 2001-11-20 Ravi Pratap <ravi@ximian.com>
13198 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
13199 re-write of the logic to now make it recursive.
13201 (UpdateIndices): Re-write accordingly.
13203 Store element data in a separate ArrayData list in the above methods.
13205 (MakeByteBlob): Implement to dump the array data into a byte array.
13207 2001-11-19 Ravi Pratap <ravi@ximian.com>
13209 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
13212 * constant.cs (Define): Implement.
13214 (EmitConstant): Re-write fully.
13216 Pass in location info.
13218 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
13221 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
13222 DictionaryEntry since we need location info too.
13224 (constant_declaration): Update accordingly.
13226 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
13227 code into another method : UpdateIndices.
13229 2001-11-18 Ravi Pratap <ravi@ximian.com>
13231 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
13232 some type checking etc.
13234 2001-11-17 Ravi Pratap <ravi@ximian.com>
13236 * expression.cs (ArrayCreation::ValidateInitializers): Implement
13237 bits to provide dimension info if the user skips doing that.
13239 Update second constructor to store the rank correctly.
13241 2001-11-16 Ravi Pratap <ravi@ximian.com>
13243 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
13244 and try to implement.
13246 * ../errors/cs0150.cs : Add.
13248 * ../errors/cs0178.cs : Add.
13250 2001-11-16 Miguel de Icaza <miguel@ximian.com>
13252 * statement.cs: Implement foreach on multi-dimensional arrays.
13254 * parameter.cs (Parameters.GetParameterByName): Also lookup the
13255 name of the params argument.
13257 * expression.cs: Use EmitStoreOpcode to get the right opcode while
13258 initializing the array.
13260 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
13261 we can use this elsewhere.
13263 * statement.cs: Finish implementation of foreach for single
13266 * cs-parser.jay: Use an out-of-band stack to pass information
13267 around, I wonder why I need this.
13269 foreach_block: Make the new foreach_block the current_block.
13271 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
13272 function used to return a static Parameters structure. Used for
13273 empty parameters, as those are created very frequently.
13275 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
13277 2001-11-15 Ravi Pratap <ravi@ximian.com>
13279 * interface.cs : Default modifier is private, not public. The
13280 make verify test passes again.
13282 2001-11-15 Ravi Pratap <ravi@ximian.com>
13284 * support.cs (ReflectionParameters): Fix logic to determine
13285 whether the last parameter is a params one. Test 9 passes again.
13287 * delegate.cs (Populate): Register the builders we define with
13288 RegisterParameterForBuilder. Test 19 passes again.
13290 * cs-parser.jay (property_declaration): Reference $6 instead
13291 of $$ to get at the location.
13293 (indexer_declaration): Similar stuff.
13295 (attribute): Ditto.
13297 * class.cs (Property): Register parameters for the Get and Set methods
13298 if they exist. Test 23 passes again.
13300 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
13301 call to EmitArguments as we are sure there aren't any params arguments.
13302 Test 32 passes again.
13304 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
13305 IndexOutOfRangeException.
13307 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
13308 Test 33 now passes again.
13310 2001-11-15 Miguel de Icaza <miguel@ximian.com>
13312 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
13313 broke a bunch of things. Will have to come up with a better way
13314 of tracking locations.
13316 * statement.cs: Implemented foreach for single dimension arrays.
13318 2001-11-09 Miguel de Icaza <miguel@ximian.com>
13320 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
13321 an error. This removes the lookup from the critical path.
13323 * cs-parser.jay: Removed use of temporary_loc, which is completely
13326 2001-11-14 Miguel de Icaza <miguel@ximian.com>
13328 * support.cs (ReflectionParameters.ParameterModifier): Report
13329 whether the argument is a PARAMS argument or not.
13331 * class.cs: Set the attribute `ParamArrayAttribute' on the
13332 parameter argument.
13334 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
13335 and cons_param_array_attribute (ConstructorInfo for
13336 ParamArrayAttribute).,
13338 * codegen.cs: Emit the return using the `Return' statement, that
13339 way we can report the error correctly for missing return values.
13341 * class.cs (Method.Emit): Clean up.
13343 * expression.cs (Argument.Resolve): Take another argument: the
13344 location where this argument is used. Notice that this is not
13345 part of the "Argument" class as to reduce the size of the
13346 structure (we know the approximate location anyways).
13348 Test if the argument is a variable-reference, if not, then
13349 complain with a 206.
13351 (Argument.Emit): Emit addresses of variables.
13353 (Argument.FullDesc): Simplify.
13355 (Invocation.DoResolve): Update for Argument.Resolve.
13357 (ElementAccess.DoResolve): ditto.
13359 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
13360 method should be virtual, as this method is always virtual.
13362 (NewDelegate.DoResolve): Update for Argument.Resolve.
13364 * class.cs (ConstructorInitializer.DoResolve): ditto.
13366 * attribute.cs (Attribute.Resolve): ditto.
13368 2001-11-13 Miguel de Icaza <miguel@ximian.com>
13370 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
13372 * expression.cs (ParameterReference): Drop IStackStorage and implement
13373 IAssignMethod instead.
13375 (LocalVariableReference): ditto.
13377 * ecore.cs (FieldExpr): Drop IStackStorage and implement
13378 IAssignMethod instead.
13380 2001-11-13 Miguel de Icaza <miguel@ximian.com>
13382 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
13383 enumerations that are used in heavily used structures derive from
13384 byte in a laughable and pathetic attempt to reduce memory usage.
13385 This is the kind of pre-optimzations that you should not do at
13386 home without adult supervision.
13388 * expression.cs (UnaryMutator): New class, used to handle ++ and
13389 -- separatedly from the other unary operators. Cleans up the
13390 code, and kills the ExpressionStatement dependency in Unary.
13392 (Unary): Removed `method' and `Arguments' from this class, making
13393 it smaller, and moving it all to SimpleCall, so I can reuse this
13394 code in other locations and avoid creating a lot of transient data
13395 strucutres when not required.
13397 * cs-parser.jay: Adjust for new changes.
13399 2001-11-11 Miguel de Icaza <miguel@ximian.com>
13401 * enum.cs (Enum.Populate): If there is a failure during
13404 * cs-parser.jay (opt_enum_base): we used to catch type errors
13405 here, but this is really incorrect. The type error should be
13406 catched during semantic analysis.
13408 2001-12-11 Ravi Pratap <ravi@ximian.com>
13410 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
13411 current_local_parameters as expected since I, in my stupidity, had forgotten
13414 * attribute.cs (GetValidPlaces): Fix stupid bug.
13416 * class.cs (Method::Emit): Perform check on applicability of attributes.
13418 (Constructor::Emit): Ditto.
13420 (Field::Emit): Ditto.
13422 (Field.Location): Store location information.
13424 (Property, Event, Indexer, Operator): Ditto.
13426 * cs-parser.jay (field_declaration): Pass in location for each field.
13428 * ../errors/cs0592.cs : Add.
13430 2001-11-12 Ravi Pratap <ravi@ximian.com>
13432 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
13434 (InitCoreTypes): Update accordingly.
13436 (RegisterAttrType, LookupAttr): Implement.
13438 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
13439 info about the same.
13441 (Resolve): Update to populate the above as necessary.
13443 (Error592): Helper.
13445 (GetValidPlaces): Helper to the above.
13447 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
13449 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
13451 2001-11-12 Ravi Pratap <ravi@ximian.com>
13453 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
13455 * ../errors/cs0617.cs : Add.
13457 2001-11-11 Ravi Pratap <ravi@ximian.com>
13459 * enum.cs (Emit): Rename to Populate to be more consistent with what
13460 we expect it to do and when exactly it is called.
13462 * class.cs, rootcontext.cs : Update accordingly.
13464 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
13465 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
13467 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
13469 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
13470 of a fieldinfo using the above, when dealing with a FieldBuilder.
13472 2001-11-10 Ravi Pratap <ravi@ximian.com>
13474 * ../errors/cs0031.cs : Add.
13476 * ../errors/cs1008.cs : Add.
13478 * ../errrors/cs0543.cs : Add.
13480 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
13483 (FindMembers): Implement.
13485 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
13486 enums and delegates too.
13488 (enum_types): Rename to builder_to_enum.
13490 (delegate_types): Rename to builder_to_delegate.
13492 * delegate.cs (FindMembers): Implement.
13494 2001-11-09 Ravi Pratap <ravi@ximian.com>
13496 * typemanager.cs (IsEnumType): Implement.
13498 * enum.cs (Emit): Re-write parts to account for the underlying type
13499 better and perform checking etc.
13501 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
13502 of the underlying type.
13504 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
13507 * enum.cs (error31): Helper to report error #31.
13509 * cs-parser.jay (enum_declaration): Store location of each member too.
13511 * enum.cs (member_to_location): New hashtable.
13513 (AddEnumMember): Update location hashtable.
13515 (Emit): Use the location of each member while reporting errors.
13517 2001-11-09 Miguel de Icaza <miguel@ximian.com>
13519 * cs-parser.jay: A for_initializer if is a
13520 local_variable_declaration really ammount to have an implicit
13521 block with the variable declaration and no initializer for for.
13523 * statement.cs (For.Emit): Cope with null initializers.
13525 This fixes the infinite loop on for initializers.
13527 2001-11-08 Miguel de Icaza <miguel@ximian.com>
13529 * enum.cs: More cleanup.
13531 * ecore.cs: Remove dead code.
13533 * class.cs (Property.Emit): More simplification.
13534 (Event.Emit): ditto.
13536 Reworked to have less levels of indentation.
13538 2001-11-08 Ravi Pratap <ravi@ximian.com>
13540 * class.cs (Property): Emit attributes.
13550 * enum.cs (Emit): Ditto.
13552 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
13555 * class.cs (Field, Event, etc.): Move attribute generation into the
13556 Emit method everywhere.
13558 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
13559 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
13560 as we had no way of defining nested enums !
13562 * rootcontext.cs : Adjust code accordingly.
13564 * typemanager.cs (AddEnumType): To keep track of enum types separately.
13566 2001-11-07 Ravi Pratap <ravi@ximian.com>
13568 * expression.cs (EvalConstantExpression): Move into ecore.cs
13570 * enum.cs (Enum): Rename some members and make them public and readonly
13571 according to our convention.
13573 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
13576 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
13578 (Enum::Emit): Write a simple version for now which doesn't try to compute
13579 expressions. I shall modify this to be more robust in just a while.
13581 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
13583 (TypeContainer::CloseType): Create the Enum types too.
13585 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
13587 * expression.cs (EvalConstantExpression): Get rid of completely.
13589 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
13590 user-defined values and other cases.
13592 (IsValidEnumLiteral): Helper function.
13594 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
13595 out there in the case we had a literal FieldExpr.
13597 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
13599 (Literalize): Revamp a bit to take two arguments.
13601 (EnumLiteral): New class which derives from Literal to wrap enum literals.
13603 2001-11-06 Ravi Pratap <ravi@ximian.com>
13605 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
13607 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
13609 (Resolve): Use the above to ensure we have proper initializers.
13611 2001-11-05 Ravi Pratap <ravi@ximian.com>
13613 * expression.cs (Expression::EvalConstantExpression): New method to
13614 evaluate constant expressions.
13616 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
13618 2001-11-07 Miguel de Icaza <miguel@ximian.com>
13620 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
13623 (Binary.ResolveOperator): Handle operator != (object a, object b)
13624 and operator == (object a, object b);
13626 (Binary.DoNumericPromotions): Indicate whether the numeric
13627 promotion was possible.
13629 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
13632 Made the ArrayAccess implement interface IAssignMethod instead of
13633 IStackStore as the order in which arguments are passed reflects
13636 * assign.cs: Instead of using expr.ExprClass to select the way of
13637 assinging, probe for the IStackStore/IAssignMethod interfaces.
13639 * typemanager.cs: Load InitializeArray definition.
13641 * rootcontext.cs (RootContext.MakeStaticData): Used to define
13642 static data that can be used to initialize arrays.
13644 2001-11-05 Miguel de Icaza <miguel@ximian.com>
13646 * expression.cs: Handle operator== and operator!= for booleans.
13648 (Conditioal.Reduce): Implement reducer for the ?: operator.
13650 (Conditional.Resolve): Implement dead code elimination.
13652 (Binary.Resolve): Catch string literals and return a new
13653 concatenated string.
13655 (Unary.Reduce): Implement reduction of unary expressions.
13657 * ecore.cs: Split out the expression core handling here.
13659 (Expression.Reduce): New method used to perform constant folding
13660 and CSE. This is needed to support constant-expressions.
13662 * statement.cs (Statement.EmitBoolExpression): Pass true and false
13663 targets, and optimize for !x.
13665 2001-11-04 Ravi Pratap <ravi@ximian.com>
13667 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
13668 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
13669 set custom atttributes.
13671 * literal.cs (Literal::GetValue): New abstract method to return the actual
13672 value of the literal, cast as an object.
13674 (*Literal): Implement GetValue method.
13676 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
13677 expressions to the arraylist but objects of type Argument.
13679 * class.cs (TypeContainer::Emit): Emit our attributes too.
13681 (Method::Emit, Constructor::Emit): Ditto.
13683 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
13684 to be ignoring earlier.
13686 2001-11-03 Ravi Pratap <ravi@ximian.com>
13688 * attribute.cs (AttributeSection::Define): Implement to do the business
13689 of constructing a CustomAttributeBuilder.
13691 (Attribute): New trivial class. Increases readability of code.
13693 * cs-parser.jay : Update accordingly.
13695 (positional_argument_list, named_argument_list, named_argument): New rules
13697 (attribute_arguments): Use the above so that we are more correct.
13699 2001-11-02 Ravi Pratap <ravi@ximian.com>
13701 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
13702 to perform all checks for a method with a params parameter.
13704 (Invocation::OverloadResolve): Update to use the above method and therefore
13705 cope correctly with params method invocations.
13707 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
13710 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
13711 constructors in our parent too because we can't afford to miss out on
13714 * attribute.cs (AttributeSection): New name for the class Attribute
13716 Other trivial changes to improve readability.
13718 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
13719 use the new class names.
13721 2001-11-01 Ravi Pratap <ravi@ximian.com>
13723 * class.cs (Method::Define): Complete definition for params types too
13725 (Indexer::Define): Ditto.
13727 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
13728 Cope everywhere with a request for info about the array parameter.
13730 2001-11-01 Ravi Pratap <ravi@ximian.com>
13732 * tree.cs (RecordNamespace): Fix up to check for the correct key.
13734 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
13735 local_variable_type to extract the string corresponding to the type.
13737 (local_variable_type): Fixup the action to use the new helper method.
13739 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
13742 * expression.cs : Clean out code which uses the above.
13744 2001-10-31 Ravi Pratap <ravi@ximian.com>
13746 * typemanager.cs (RegisterMethod): Check if we already have an existing key
13747 and bale out if necessary by returning a false.
13749 (RegisterProperty): Ditto.
13751 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
13752 and print out appropriate error messages.
13754 * interface.cs (everywhere): Ditto.
13756 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
13757 location to constructor.
13759 * class.cs (Property, Event, Indexer): Update accordingly.
13761 * ../errors/cs111.cs : Added.
13763 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
13764 of a method, as laid down by the spec.
13766 (Invocation::OverloadResolve): Use the above method.
13768 2001-10-31 Ravi Pratap <ravi@ximian.com>
13770 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
13771 now take a TypeContainer and a Parameters object.
13773 (ParameterData): Modify return type of ParameterModifier method to be
13774 Parameter.Modifier and not a string.
13776 (ReflectionParameters, InternalParameters): Update accordingly.
13778 * expression.cs (Argument::GetParameterModifier): Same here.
13780 * support.cs (InternalParameters::ParameterType): Find a better way of determining
13781 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
13782 symbol in it at all so maybe this is only for now.
13784 2001-10-30 Ravi Pratap <ravi@ximian.com>
13786 * support.cs (InternalParameters): Constructor now takes an extra argument
13787 which is the actual Parameters class.
13789 (ParameterDesc): Update to provide info on ref/out modifiers.
13791 * class.cs (everywhere): Update call to InternalParameters to pass in
13792 the second argument too.
13794 * support.cs (ParameterData): Add ParameterModifier, which is a method
13795 to return the modifier info [ref/out etc]
13797 (InternalParameters, ReflectionParameters): Implement the above.
13799 * expression.cs (Argument::ParameterModifier): Similar function to return
13800 info about the argument's modifiers.
13802 (Invocation::OverloadResolve): Update to take into account matching modifiers
13805 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
13806 a new SetFormalParameters object which we pass to InternalParameters.
13808 2001-10-30 Ravi Pratap <ravi@ximian.com>
13810 * expression.cs (NewArray): Merge into the ArrayCreation class.
13812 2001-10-29 Ravi Pratap <ravi@ximian.com>
13814 * expression.cs (NewArray): Merge classes NewBuiltinArray and
13815 NewUserdefinedArray into one as there wasn't much of a use in having
13818 * expression.cs (Argument): Change field's name to ArgType from Type.
13820 (Type): New readonly property which returns the proper type, taking into
13821 account ref/out modifiers.
13823 (everywhere): Adjust code accordingly for the above.
13825 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
13826 whether we are emitting for a ref or out parameter.
13828 * expression.cs (Argument::Emit): Use the above field to set the state.
13830 (LocalVariableReference::Emit): Update to honour the flag and emit the
13833 * parameter.cs (Attributes): Set the correct flags for ref parameters.
13835 * expression.cs (Argument::FullDesc): New function to provide a full desc.
13837 * support.cs (ParameterData): Add method ParameterDesc to the interface.
13839 (ReflectionParameters, InternalParameters): Implement the above method.
13841 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
13844 (Invocation::FullMethodDesc): Ditto.
13846 2001-10-29 Miguel de Icaza <miguel@ximian.com>
13848 * cs-parser.jay: Add extra production for the second form of array
13851 * expression.cs (ArrayCreation): Update to reflect the above
13854 * Small changes to prepare for Array initialization.
13856 2001-10-28 Miguel de Icaza <miguel@ximian.com>
13858 * typemanager.cs (ImplementsInterface): interface might be null;
13859 Deal with this problem;
13861 Also, we do store negative hits on the cache (null values), so use
13862 this instead of calling t.GetInterfaces on the type everytime.
13864 2001-10-28 Ravi Pratap <ravi@ximian.com>
13866 * typemanager.cs (IsBuiltinType): New method to help determine the same.
13868 * expression.cs (New::DoResolve): Get rid of array creation code and instead
13869 split functionality out into different classes.
13871 (New::FormArrayType): Move into NewBuiltinArray.
13873 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
13876 (NewBuiltinArray): New class to handle creation of built-in arrays.
13878 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
13879 account creation of one-dimensional arrays.
13881 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
13883 (NewUserdefinedArray::DoResolve): Implement.
13885 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
13887 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
13888 we maintain inside the TypeManager. This is necessary to perform lookups on the
13891 (LookupType): Update to perform GetType on the module builders too.
13893 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
13895 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
13897 2001-10-23 Ravi Pratap <ravi@ximian.com>
13899 * expression.cs (New::DoResolve): Implement guts of array creation.
13901 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
13903 2001-10-27 Miguel de Icaza <miguel@ximian.com>
13905 * expression.cs: Fix bug I introduced lsat night that broke
13908 (Expression.Resolve): Report a 246 error (can not resolve name)
13909 if we find a SimpleName in the stream.
13911 (Expression.ResolveLValue): Ditto.
13913 (Expression.ResolveWithSimpleName): This function is a variant of
13914 ResolveName, this one allows SimpleNames to be returned without a
13915 warning. The only consumer of SimpleNames is MemberAccess
13917 2001-10-26 Miguel de Icaza <miguel@ximian.com>
13919 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
13920 might arrive here. I have my doubts that this is correct.
13922 * statement.cs (Lock): Implement lock statement.
13924 * cs-parser.jay: Small fixes to support `lock' and `using'
13926 * cs-tokenizer.cs: Remove extra space
13928 * driver.cs: New flag --checked, allows to turn on integer math
13931 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
13932 Threading.Monitor.Exit
13934 2001-10-23 Miguel de Icaza <miguel@ximian.com>
13936 * expression.cs (IndexerAccess::DoResolveLValue): Set the
13937 Expression Class to be IndexerAccess.
13939 Notice that Indexer::DoResolve sets the eclass to Value.
13941 2001-10-22 Miguel de Icaza <miguel@ximian.com>
13943 * class.cs (TypeContainer::Emit): Emit code for indexers.
13945 * assign.cs (IAssignMethod): New interface implemented by Indexers
13946 and Properties for handling assignment.
13948 (Assign::Emit): Simplify and reuse code.
13950 * expression.cs (IndexerAccess, PropertyExpr): Implement
13951 IAssignMethod, clean up old code.
13953 2001-10-22 Ravi Pratap <ravi@ximian.com>
13955 * typemanager.cs (ImplementsInterface): New method to determine if a type
13956 implements a given interface. Provides a nice cache too.
13958 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
13961 (ConvertReferenceExplicit): Ditto.
13963 * delegate.cs (Delegate::Populate): Update to define the parameters on the
13964 various methods, with correct names etc.
13966 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
13967 Operator.UnaryNegation.
13969 * cs-parser.jay (operator_declarator): Be a little clever in the case where
13970 we have a unary plus or minus operator.
13972 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
13975 * everywhere : update accordingly.
13977 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
13980 * class.cs (Method::Define): For the case where we are implementing a method
13981 inherited from an interface, we need to set the MethodAttributes.Final flag too.
13982 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
13984 2001-10-21 Ravi Pratap <ravi@ximian.com>
13986 * interface.cs (FindMembers): Implement to work around S.R.E
13989 * typemanager.cs (IsInterfaceType): Implement.
13991 (FindMembers): Update to handle interface types too.
13993 * expression.cs (ImplicitReferenceConversion): Re-write bits which
13994 use IsAssignableFrom as that is not correct - it doesn't work.
13996 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
13997 and accordingly override EmitStatement.
13999 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
14000 using the correct logic :-)
14002 2001-10-19 Ravi Pratap <ravi@ximian.com>
14004 * ../errors/cs-11.cs : Add to demonstrate error -11
14006 2001-10-17 Miguel de Icaza <miguel@ximian.com>
14008 * assign.cs (Assign::Resolve): Resolve right hand side first, and
14009 then pass this as a hint to ResolveLValue.
14011 * expression.cs (FieldExpr): Add Location information
14013 (FieldExpr::LValueResolve): Report assignment to readonly
14016 (Expression::ExprClassFromMemberInfo): Pass location information.
14018 (Expression::ResolveLValue): Add new method that resolves an
14021 (Expression::DoResolveLValue): Default invocation calls
14024 (Indexers): New class used to keep track of indexers in a given
14027 (IStackStore): Renamed from LValue, as it did not really describe
14028 what this did. Also ResolveLValue is gone from this interface and
14029 now is part of Expression.
14031 (ElementAccess): Depending on the element access type
14033 * typemanager.cs: Add `indexer_name_type' as a Core type
14034 (System.Runtime.CompilerServices.IndexerNameAttribute)
14036 * statement.cs (Goto): Take a location.
14038 2001-10-18 Ravi Pratap <ravi@ximian.com>
14040 * delegate.cs (Delegate::VerifyDelegate): New method to verify
14041 if two delegates are compatible.
14043 (NewDelegate::DoResolve): Update to take care of the case when
14044 we instantiate a delegate from another delegate.
14046 * typemanager.cs (FindMembers): Don't even try to look up members
14047 of Delegate types for now.
14049 2001-10-18 Ravi Pratap <ravi@ximian.com>
14051 * delegate.cs (NewDelegate): New class to take care of delegate
14054 * expression.cs (New): Split the delegate related code out into
14055 the NewDelegate class.
14057 * delegate.cs (DelegateInvocation): New class to handle delegate
14060 * expression.cs (Invocation): Split out delegate related code into
14061 the DelegateInvocation class.
14063 2001-10-17 Ravi Pratap <ravi@ximian.com>
14065 * expression.cs (New::DoResolve): Implement delegate creation fully
14066 and according to the spec.
14068 (New::DoEmit): Update to handle delegates differently.
14070 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
14071 because of which we were printing out arguments in reverse order !
14073 * delegate.cs (VerifyMethod): Implement to check if the given method
14074 matches the delegate.
14076 (FullDelegateDesc): Implement.
14078 (VerifyApplicability): Implement.
14080 * expression.cs (Invocation::DoResolve): Update to accordingly handle
14081 delegate invocations too.
14083 (Invocation::Emit): Ditto.
14085 * ../errors/cs1593.cs : Added.
14087 * ../errors/cs1594.cs : Added.
14089 * delegate.cs (InstanceExpression, TargetMethod): New properties.
14091 2001-10-16 Ravi Pratap <ravi@ximian.com>
14093 * typemanager.cs (intptr_type): Core type for System.IntPtr
14095 (InitCoreTypes): Update for the same.
14097 (iasyncresult_type, asynccallback_type): Ditto.
14099 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
14102 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
14105 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
14106 the builders for the 4 members of a delegate type :-)
14108 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
14111 * expression.cs (New::DoResolve): Implement guts for delegate creation.
14113 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
14115 2001-10-15 Miguel de Icaza <miguel@ximian.com>
14117 * statement.cs (Break::Emit): Implement.
14118 (Continue::Emit): Implement.
14120 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
14121 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
14122 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
14123 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
14126 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
14127 properties that track the label for the current loop (begin of the
14128 loop and end of the loop).
14130 2001-10-15 Ravi Pratap <ravi@ximian.com>
14132 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
14133 use of emitting anything at all.
14135 * class.cs, rootcontext.cs : Get rid of calls to the same.
14137 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
14139 (Populate): Define the constructor correctly and set the implementation
14142 * typemanager.cs (delegate_types): New hashtable to hold delegates that
14145 (AddDelegateType): Implement.
14147 (IsDelegateType): Implement helper method.
14149 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
14151 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
14152 and accordingly handle it.
14154 * delegate.cs (Populate): Take TypeContainer argument.
14155 Implement bits to define the Invoke method. However, I still haven't figured out
14156 how to take care of the native int bit :-(
14158 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
14159 Qualify the name of the delegate, not its return type !
14161 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
14164 (StandardConversionExists): Checking for array types turns out to be recursive.
14166 (ConvertReferenceExplicit): Implement array conversion.
14168 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
14170 2001-10-12 Ravi Pratap <ravi@ximian.com>
14172 * cs-parser.jay (delegate_declaration): Store the fully qualified
14173 name as it is a type declaration.
14175 * delegate.cs (ReturnType, Name): Rename members to these. Make them
14178 (DefineDelegate): Renamed from Define. Does the same thing essentially,
14179 as TypeContainer::DefineType.
14181 (Populate): Method in which all the definition of the various methods (Invoke)
14184 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
14187 (CloseDelegate): Finally creates the delegate.
14189 * class.cs (TypeContainer::DefineType): Update to define delegates.
14190 (Populate, Emit and CloseType): Do the same thing here too.
14192 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
14193 delegates in all these operations.
14195 2001-10-14 Miguel de Icaza <miguel@ximian.com>
14197 * expression.cs: LocalTemporary: a new expression used to
14198 reference a temporary that has been created.
14200 * assign.cs: Handle PropertyAccess back here, so that we can
14201 provide the proper semantic access to properties.
14203 * expression.cs (Expression::ConvertReferenceExplicit): Implement
14204 a few more explicit conversions.
14206 * modifiers.cs: `NEW' modifier maps to HideBySig.
14208 * expression.cs (PropertyExpr): Make this into an
14209 ExpressionStatement, and support the EmitStatement code path.
14211 Perform get/set error checking, clean up the interface.
14213 * assign.cs: recognize PropertyExprs as targets, and if so, turn
14214 them into toplevel access objects.
14216 2001-10-12 Miguel de Icaza <miguel@ximian.com>
14218 * expression.cs: PropertyExpr::PropertyExpr: use work around the
14221 * typemanager.cs: Keep track here of our PropertyBuilders again to
14222 work around lameness in SRE.
14224 2001-10-11 Miguel de Icaza <miguel@ximian.com>
14226 * expression.cs (LValue::LValueResolve): New method in the
14227 interface, used to perform a second resolution pass for LValues.
14229 (This::DoResolve): Catch the use of this in static methods.
14231 (This::LValueResolve): Implement.
14233 (This::Store): Remove warning, assigning to `this' in structures
14236 (Invocation::Emit): Deal with invocation of
14237 methods on value types. We need to pass the address to structure
14238 methods rather than the object itself. (The equivalent code to
14239 emit "this" for structures leaves the entire structure on the
14240 stack instead of a pointer to it).
14242 (ParameterReference::DoResolve): Compute the real index for the
14243 argument based on whether the method takes or not a `this' pointer
14244 (ie, the method is static).
14246 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
14247 value types returned from functions when we need to invoke a
14248 method on the sturcture.
14251 2001-10-11 Ravi Pratap <ravi@ximian.com>
14253 * class.cs (TypeContainer::DefineType): Method to actually do the business of
14254 defining the type in the Modulebuilder or Typebuilder. This is to take
14255 care of nested types which need to be defined on the TypeBuilder using
14256 DefineNestedMethod.
14258 (TypeContainer::GetClassBases): Implement. Essentially the code from the
14259 methods in RootContext, only ported to be part of TypeContainer.
14261 (TypeContainer::GetInterfaceOrClass): Ditto.
14263 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
14265 * interface.cs (Interface::DefineInterface): New method. Does exactly
14266 what RootContext.CreateInterface did earlier, only it takes care of nested types
14269 (Interface::GetInterfaces): Move from RootContext here and port.
14271 (Interface::GetInterfaceByName): Same here.
14273 * rootcontext.cs (ResolveTree): Re-write.
14275 (PopulateTypes): Re-write.
14277 * class.cs (TypeContainer::Populate): Populate nested types too.
14278 (TypeContainer::Emit): Emit nested members too.
14280 * typemanager.cs (AddUserType): Do not make use of the FullName property,
14281 instead just use the name argument passed in as it is already fully
14284 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
14285 to TypeContainer mapping to see if a type is user-defined.
14287 * class.cs (TypeContainer::CloseType): Implement.
14289 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
14290 the default constructor.
14292 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
14295 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
14297 * interface.cs (CloseType): Create the type here.
14299 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
14302 Remove all the methods which are now in TypeContainer.
14304 2001-10-10 Ravi Pratap <ravi@ximian.com>
14306 * delegate.cs (Define): Re-write bits to define the delegate
14309 2001-10-10 Miguel de Icaza <miguel@ximian.com>
14311 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
14313 * expression.cs (ImplicitReferenceConversion): handle null as well
14314 as a source to convert to any reference type.
14316 * statement.cs (Return): Perform any implicit conversions to
14317 expected return type.
14319 Validate use of return statement.
14321 * codegen.cs (EmitContext): Pass the expected return type here.
14323 * class.cs (Method, Constructor, Property): Pass expected return
14324 type to EmitContext.
14326 2001-10-09 Miguel de Icaza <miguel@ximian.com>
14328 * expression.cs: Make DoResolve take an EmitContext instead of a
14331 Replaced `l' and `location' for `loc', for consistency.
14333 (Error, Warning): Remove unneeded Tc argument.
14335 * assign.cs, literal.cs, constant.cs: Update to new calling
14338 * codegen.cs: EmitContext now contains a flag indicating whether
14339 code is being generated in a static method or not.
14341 * cs-parser.jay: DecomposeQI, new function that replaces the old
14342 QualifiedIdentifier. Now we always decompose the assembled
14343 strings from qualified_identifier productions into a group of
14346 2001-10-08 Miguel de Icaza <miguel@ximian.com>
14348 * rootcontext.cs: Deal with field-less struct types correctly now
14349 by passing the size option to Define Type.
14351 * class.cs: Removed hack that created one static field.
14353 2001-10-07 Miguel de Icaza <miguel@ximian.com>
14355 * statement.cs: Moved most of the code generation here.
14357 2001-10-09 Ravi Pratap <ravi@ximian.com>
14359 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
14362 (ElementAccess): Remove useless bits for now - keep checks as the spec
14365 2001-10-08 Ravi Pratap <ravi@ximian.com>
14367 * expression.cs (ElementAccess::DoResolve): Remove my crap code
14368 and start performing checks according to the spec.
14370 2001-10-07 Ravi Pratap <ravi@ximian.com>
14372 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
14373 rank_specifiers instead.
14375 (rank_specifiers): Change the order in which the rank specifiers are stored
14377 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
14379 * expression.cs (ElementAccess): Implement the LValue interface too.
14381 2001-10-06 Ravi Pratap <ravi@ximian.com>
14383 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
14384 except that user defined conversions are not included.
14386 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
14387 perform the conversion of the return type, if necessary.
14389 (New::DoResolve): Check whether we are creating an array or an object
14390 and accordingly do the needful.
14392 (New::Emit): Same here.
14394 (New::DoResolve): Implement guts of array creation.
14396 (New::FormLookupType): Helper function.
14398 2001-10-07 Miguel de Icaza <miguel@ximian.com>
14400 * codegen.cs: Removed most of the code generation here, and move the
14401 corresponding code generation bits to the statement classes.
14403 Added support for try/catch/finalize and throw.
14405 * cs-parser.jay: Added support for try/catch/finalize.
14407 * class.cs: Catch static methods having the flags override,
14408 virtual or abstract.
14410 * expression.cs (UserCast): This user cast was not really doing
14411 what it was supposed to do. Which is to be born in fully resolved
14412 state. Parts of the resolution were being performed at Emit time!
14416 2001-10-05 Miguel de Icaza <miguel@ximian.com>
14418 * expression.cs: Implicity convert the result from UserCast.
14420 2001-10-05 Ravi Pratap <ravi@ximian.com>
14422 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
14423 prevented it from working correctly.
14425 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
14426 merely ConvertImplicit.
14428 2001-10-05 Miguel de Icaza <miguel@ximian.com>
14430 * typemanager.cs: Make the LookupTypeContainer function static,
14431 and not per-instance.
14433 * class.cs: Make static FindMembers (the one that takes a Type
14436 * codegen.cs: Add EmitForeach here.
14438 * cs-parser.jay: Make foreach a toplevel object instead of the
14439 inline expansion, as we need to perform semantic analysis on it.
14441 2001-10-05 Ravi Pratap <ravi@ximian.com>
14443 * expression.cs (Expression::ImplicitUserConversion): Rename to
14444 UserDefinedConversion.
14446 (Expression::UserDefinedConversion): Take an extra argument specifying
14447 whether we look for explicit user conversions too.
14449 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
14451 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
14453 (ExplicitUserConversion): Make it a call to UserDefinedConversion
14454 with the appropriate arguments.
14456 * cs-parser.jay (cast_expression): Record location too.
14458 * expression.cs (Cast): Record location info.
14460 (Expression::ConvertExplicit): Take location argument.
14462 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
14463 to determine if we are doing explicit conversions.
14465 (UserCast::Emit): Update accordingly.
14467 (Expression::ConvertExplicit): Report an error if everything fails.
14469 * ../errors/cs0030.cs : Add.
14471 2001-10-04 Miguel de Icaza <miguel@ximian.com>
14473 * modifiers.cs: If the ABSTRACT keyword is present, also set the
14474 virtual and newslot bits.
14476 * class.cs (TypeContainer::RegisterRequiredImplementations):
14477 Record methods we need.
14479 (TypeContainer::MakeKey): Helper function to make keys for
14480 MethodBases, since the Methodbase key is useless.
14482 (TypeContainer::Populate): Call RegisterRequiredImplementations
14483 before defining the methods.
14485 Create a mapping for method_builders_to_methods ahead of time
14486 instead of inside a tight loop.
14488 (::RequireMethods): Accept an object as the data to set into the
14489 hashtable so we can report interface vs abstract method mismatch.
14491 2001-10-03 Miguel de Icaza <miguel@ximian.com>
14493 * report.cs: Make all of it static.
14495 * rootcontext.cs: Drop object_type and value_type computations, as
14496 we have those in the TypeManager anyways.
14498 Drop report instance variable too, now it is a global.
14500 * driver.cs: Use try/catch on command line handling.
14502 Add --probe option to debug the error reporting system with a test
14505 * report.cs: Add support for exiting program when a probe
14506 condition is reached.
14508 2001-10-03 Ravi Pratap <ravi@ximian.com>
14510 * expression.cs (Binary::DoNumericPromotions): Fix the case when
14511 we do a forcible conversion regardless of type, to check if
14512 ForceConversion returns a null.
14514 (Binary::error19): Use location to report error.
14516 (Unary::error23): Use location here too.
14518 * ../errors/cs0019.cs : Check in.
14520 * ../errors/cs0023.cs : Check in.
14522 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
14523 case of a non-null MethodInfo object with a length of 0 !
14525 (Binary::ResolveOperator): Flag error if overload resolution fails to find
14526 an applicable member - according to the spec :-)
14527 Also fix logic to find members in base types.
14529 (Unary::ResolveOperator): Same here.
14531 (Unary::report23): Change name to error23 and make first argument a TypeContainer
14532 as I was getting thoroughly confused between this and error19 :-)
14534 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
14535 (::FindMostEncompassedType): Implement.
14536 (::FindMostEncompassingType): Implement.
14537 (::StandardConversionExists): Implement.
14539 (UserImplicitCast): Re-vamp. We now need info about most specific
14540 source and target types so that we can do the necessary conversions.
14542 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
14543 mathematical union with no duplicates.
14545 2001-10-03 Miguel de Icaza <miguel@ximian.com>
14547 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
14548 in order from base classes to child classes, so that we can in
14549 child classes look up in our parent for method names and
14550 attributes (required for handling abstract, virtual, new, override
14551 constructs: we need to instrospect our base class, and if we dont
14552 populate the classes in order, the introspection might be
14553 incorrect. For example, a method could query its parent before
14554 the parent has any methods and would determine that the parent has
14555 no abstract methods (while it could have had them)).
14557 (RootContext::CreateType): Record the order in which we define the
14560 2001-10-02 Miguel de Icaza <miguel@ximian.com>
14562 * class.cs (TypeContainer::Populate): Also method definitions can
14563 fail now, keep track of this.
14565 (TypeContainer::FindMembers): Implement support for
14566 DeclaredOnly/noDeclaredOnly flag.
14568 (Constructor::Emit) Return the ConstructorBuilder.
14570 (Method::Emit) Return the MethodBuilder.
14571 Check for abstract or virtual methods to be public.
14573 * rootcontext.cs (RootContext::CreateType): Register all the
14574 abstract methods required for the class to be complete and the
14575 interface methods that must be implemented.
14577 * cs-parser.jay: Report error 501 (method requires body if it is
14578 not marked abstract or extern).
14580 * expression.cs (TypeOf::Emit): Implement.
14582 * typemanager.cs: runtime_handle_type, new global type.
14584 * class.cs (Property::Emit): Generate code for properties.
14586 2001-10-02 Ravi Pratap <ravi@ximian.com>
14588 * expression.cs (Unary::ResolveOperator): Find operators on base type
14589 too - we now conform exactly to the spec.
14591 (Binary::ResolveOperator): Same here.
14593 * class.cs (Operator::Define): Fix minor quirk in the tests.
14595 * ../errors/cs0215.cs : Added.
14597 * ../errors/cs0556.cs : Added.
14599 * ../errors/cs0555.cs : Added.
14601 2001-10-01 Miguel de Icaza <miguel@ximian.com>
14603 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
14604 single integer which is really efficient
14606 2001-10-01 Ravi Pratap <ravi@ximian.com>
14608 * expression.cs (Expression::ImplicitUserConversion): Use location
14609 even in the case when we are examining True operators.
14611 * class.cs (Operator::Define): Perform extensive checks to conform
14612 with the rules for operator overloading in the spec.
14614 * expression.cs (Expression::ImplicitReferenceConversion): Implement
14615 some of the other conversions mentioned in the spec.
14617 * typemanager.cs (array_type): New static member for the System.Array built-in
14620 (cloneable_interface): For System.ICloneable interface.
14622 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
14623 we start resolving the tree and populating types.
14625 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
14627 2001-10-01 Miguel de Icaza <miguel@ximian.com>
14629 * expression.cs (Expression::ExprClassFromMemberInfo,
14630 Expression::Literalize): Create literal expressions from
14631 FieldInfos which are literals.
14633 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
14634 type casts, because they were wrong. The test suite in tests
14637 (ImplicitNumericConversion): ushort to ulong requires a widening
14640 Int32 constant to long requires widening cast as well.
14642 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
14643 for integers because the type on the stack is not i4.
14645 2001-09-30 Miguel de Icaza <miguel@ximian.com>
14647 * expression.cs (report118): require location argument.
14649 * parameter.cs: Do not dereference potential null value.
14651 * class.cs: Catch methods that lack the `new' keyword when
14652 overriding a name. Report warnings when `new' is used without
14653 anything being there to override.
14655 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
14657 * class.cs: Only add constructor to hashtable if it is non-null
14658 (as now constructors can fail on define).
14660 (TypeManager, Class, Struct): Take location arguments.
14662 Catch field instance initialization in structs as errors.
14664 accepting_filter: a new filter for FindMembers that is static so
14665 that we dont create an instance per invocation.
14667 (Constructor::Define): Catch errors where a struct constructor is
14670 * cs-parser.jay: Pass location information for various new
14673 * delegate.cs (Delegate): take a location argument.
14675 * driver.cs: Do not call EmitCode if there were problesm in the
14676 Definition of the types, as many Builders wont be there.
14678 * decl.cs (Decl::Decl): Require a location argument.
14680 * cs-tokenizer.cs: Handle properly hex constants that can not fit
14681 into integers, and find the most appropiate integer for it.
14683 * literal.cs: Implement ULongLiteral.
14685 * rootcontext.cs: Provide better information about the location of
14686 failure when CreateType fails.
14688 2001-09-29 Miguel de Icaza <miguel@ximian.com>
14690 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
14693 * expression.cs (Binary::CheckShiftArguments): Add missing type
14695 (Binary::ResolveOperator): Add type to the logical and and logical
14696 or, Bitwise And/Or and Exclusive Or code paths, it was missing
14699 (Binary::DoNumericPromotions): In the case where either argument
14700 is ulong (and most signed types combined with ulong cause an
14701 error) perform implicit integer constant conversions as well.
14703 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14705 * expression.cs (UserImplicitCast): Method should always be
14707 (Invocation::BetterConversion): Simplified test for IntLiteral.
14709 (Expression::ImplicitNumericConversion): Split this routine out.
14710 Put the code that performs implicit constant integer conversions
14713 (Expression::Resolve): Become a wrapper around DoResolve so we can
14714 check eclass and type being set after resolve.
14716 (Invocation::Badness): Remove this dead function
14718 (Binary::ResolveOperator): Do not compute the expensive argumnets
14719 unless we have a union for it.
14721 (Probe::Emit): Is needs to do an isinst and then
14722 compare against null.
14724 (::CanConvert): Added Location argument. If the Location argument
14725 is null (Location.Null), then we do not report errors. This is
14726 used by the `probe' mechanism of the Explicit conversion. We do
14727 not want to generate an error for something that the user
14728 explicitly requested to be casted. But the pipeline for an
14729 explicit cast first tests for potential implicit casts.
14731 So for now, if the Location is null, it means `Probe only' to
14732 avoid adding another argument. Might have to revise this
14735 (ClassCast): New class used to type cast objects into arbitrary
14736 classes (used in Explicit Reference Conversions).
14738 Implement `as' as well.
14740 Reverted all the patches from Ravi below: they were broken:
14742 * The use of `level' as a mechanism to stop recursive
14743 invocations is wrong. That was there just to catch the
14744 bug with a strack trace but not as a way of addressing
14747 To fix the problem we have to *understand* what is going
14748 on and the interactions and come up with a plan, not
14749 just get things going.
14751 * The use of the type conversion cache that I proposed
14752 last night had an open topic: How does this work across
14753 protection domains. A user defined conversion might not
14754 be public in the location where we are applying the
14755 conversion, a different conversion might be selected
14756 (ie, private A->B (better) but public B->A (worse),
14757 inside A, A->B applies, but outside it, B->A will
14760 * On top of that (ie, even if the above is solved),
14761 conversions in a cache need to be abstract. Ie, `To
14762 convert from an Int to a Short use an OpcodeCast', not
14763 `To convert from an Int to a Short use the OpcodeCast on
14764 the variable 5' (which is what this patch was doing).
14766 2001-09-28 Ravi Pratap <ravi@ximian.com>
14768 * expression.cs (Invocation::ConversionExists): Re-write to use
14769 the conversion cache
14771 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
14772 cache all conversions done, not just user-defined ones.
14774 (Invocation::BetterConversion): The real culprit. Use ConversionExists
14775 to determine if a conversion exists instead of acutually trying to
14776 perform the conversion. It's faster too.
14778 (Expression::ConvertExplicit): Modify to use ConversionExists to check
14779 and only then attempt the implicit conversion.
14781 2001-09-28 Ravi Pratap <ravi@ximian.com>
14783 * expression.cs (ConvertImplicit): Use a cache for conversions
14784 already found. Check level of recursion and bail out if necessary.
14786 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14788 * typemanager.cs (string_concat_string_string, string_concat_object_object):
14789 Export standard methods that we expect for string operations.
14791 * statement.cs (Block::UsageWarning): Track usage of variables and
14792 report the errors for not used variables.
14794 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
14797 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14799 * codegen.cs: remove unnneded code
14801 * expression.cs: Removed BuiltinTypeAccess class
14803 Fix the order in which implicit conversions are
14806 The previous fixed dropped support for boxed conversions (adding a
14807 test to the test suite now)
14809 (UserImplicitCast::CanConvert): Remove test for source being null,
14810 that code is broken. We should not feed a null to begin with, if
14811 we do, then we should track the bug where the problem originates
14812 and not try to cover it up here.
14814 Return a resolved expression of type UserImplicitCast on success
14815 rather than true/false. Ravi: this is what I was talking about,
14816 the pattern is to use a static method as a "constructor" for
14819 Also, do not create arguments until the very last minute,
14820 otherwise we always create the arguments even for lookups that
14821 will never be performed.
14823 (UserImplicitCast::Resolve): Eliminate, objects of type
14824 UserImplicitCast are born in a fully resolved state.
14826 * typemanager.cs (InitCoreTypes): Init also value_type
14827 (System.ValueType).
14829 * expression.cs (Cast::Resolve): First resolve the child expression.
14831 (LValue): Add new method AddressOf to be used by
14834 Change the argument of Store to take an EmitContext instead of an
14835 ILGenerator, because things like FieldExpr need to be able to call
14836 their children expression to generate the instance code.
14838 (Expression::Error, Expression::Warning): Sugar functions for
14841 (Expression::MemberLookup): Accept a TypeContainer instead of a
14842 Report as the first argument.
14844 (Expression::ResolvePrimary): Killed. I still want to improve
14845 this as currently the code is just not right.
14847 (Expression::ResolveMemberAccess): Simplify, but it is still
14850 (Unary::Resolve): Catch errors in AddressOf operators.
14852 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
14853 index to a byte for the short-version, or the compiler will choose
14854 the wrong Emit call, which generates the wrong data.
14856 (ParameterReference::Emit, ::Store): same.
14858 (FieldExpr::AddressOf): Implement.
14860 * typemanager.cs: TypeManager: made public variable instead of
14863 * driver.cs: document --fatal.
14865 * report.cs (ErrorMessage, WarningMessage): new names for the old
14866 Error and Warning classes.
14868 * cs-parser.jay (member_access): Turn built-in access to types
14869 into a normal simplename
14871 2001-09-27 Ravi Pratap <ravi@ximian.com>
14873 * expression.cs (Invocation::BetterConversion): Fix to cope
14874 with q being null, since this was introducing a bug.
14876 * expression.cs (ConvertImplicit): Do built-in conversions first.
14878 2001-09-27 Ravi Pratap <ravi@ximian.com>
14880 * expression.cs (UserImplicitCast::Resolve): Fix bug.
14882 2001-09-27 Ravi Pratap <ravi@ximian.com>
14884 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
14885 I had introduced long ago (what's new ?).
14887 * expression.cs (UserImplicitCast::CanConvert): Static method to do
14888 the work of all the checking.
14889 (ConvertImplicit): Call CanConvert and only then create object if necessary.
14890 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
14892 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
14893 that is the right way.
14895 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
14896 overloading resolution. Use everywhere instead of cutting and pasting code.
14898 (Binary::ResolveOperator): Use MakeUnionSet.
14900 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
14901 we have to convert to bool types. Not complete yet.
14903 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14905 * typemanager.cs (TypeManager::CSharpName): support ushort.
14907 * expression.cs (Expression::TryImplicitIntConversion): Attempts
14908 to provide an expression that performsn an implicit constant int
14909 conversion (section 6.1.6).
14910 (Expression::ConvertImplicitRequired): Reworked to include
14911 implicit constant expression conversions.
14913 (Expression::ConvertNumericExplicit): Finished.
14915 (Invocation::Emit): If InstanceExpression is null, then it means
14916 that we perform a call on this.
14918 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14920 * expression.cs (Unary::Emit): Remove some dead code.
14921 (Probe): Implement Resolve and Emit for `is'.
14922 (Expression::ConvertImplicitRequired): Attempt to do constant
14923 expression conversions here. Maybe should be moved to
14924 ConvertImplicit, but I am not sure.
14925 (Expression::ImplicitLongConstantConversionPossible,
14926 Expression::ImplicitIntConstantConversionPossible): New functions
14927 that tell whether is it possible to apply an implicit constant
14928 expression conversion.
14930 (ConvertNumericExplicit): Started work on explicit numeric
14933 * cs-parser.jay: Update operator constants.
14935 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
14936 (Parameters::GetSignature): Hook up VerifyArgs here.
14937 (Parameters::VerifyArgs): Verifies that no two arguments have the
14940 * class.cs (Operator): Update the operator names to reflect the
14941 ones that the spec expects (as we are just stringizing the
14944 * expression.cs (Unary::ResolveOperator): Fix bug: Use
14945 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
14946 previous usage did only work for our methods.
14947 (Expression::ConvertImplicit): Handle decimal implicit numeric
14948 conversions as well.
14949 (Expression::InternalTypeConstructor): Used to invoke constructors
14950 on internal types for default promotions.
14952 (Unary::Emit): Implement special handling for the pre/post
14953 increment/decrement for overloaded operators, as they need to have
14954 the same semantics as the other operators.
14956 (Binary::ResolveOperator): ditto.
14957 (Invocation::ConversionExists): ditto.
14958 (UserImplicitCast::Resolve): ditto.
14960 2001-09-26 Ravi Pratap <ravi@ximian.com>
14962 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
14963 operator, return after emitting body. Regression tests pass again !
14965 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
14966 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
14967 (Invocation::OverloadResolve): Ditto.
14968 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
14970 * everywhere : update calls to the above methods accordingly.
14972 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14974 * assign.cs (Assign): Make it inherit from ExpressionStatement.
14976 * expression.cs (ExpressionStatement): New base class used for
14977 expressions that can appear in statements, so that we can provide
14978 an alternate path to generate expression that do not leave a value
14981 (Expression::Emit, and all the derivatives): We no longer return
14982 whether a value is left on the stack or not. Every expression
14983 after being emitted leaves a single value on the stack.
14985 * codegen.cs (EmitContext::EmitStatementExpression): Use the
14986 facilties of ExpressionStatement if possible.
14988 * cs-parser.jay: Update statement_expression.
14990 2001-09-25 Miguel de Icaza <miguel@ximian.com>
14992 * driver.cs: Change the wording of message
14994 2001-09-25 Ravi Pratap <ravi@ximian.com>
14996 * expression.cs (Binary::ResolveOperator): Had forgottten to set
14997 the type of the expression to the return type of the method if
14998 we have an overloaded operator match ! The regression tests pass again !
14999 (Unary::ResolveOperator): Ditto.
15001 * expression.cs (Invocation::ConversionExists): Correct the member lookup
15002 to find "op_Implicit", not "implicit" ;-)
15003 (UserImplicitCast): New class to take care of user-defined implicit conversions.
15004 (ConvertImplicit, ForceConversion): Take TypeContainer argument
15006 * everywhere : Correct calls to the above accordingly.
15008 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
15009 (ConvertImplicit): Do user-defined conversion if it exists.
15011 2001-09-24 Miguel de Icaza <miguel@ximian.com>
15013 * assign.cs: track location.
15014 (Resolve): Use implicit conversions on assignment.
15016 * literal.cs: Oops. Not good, Emit of short access values should
15017 pass (Bytes) or the wrong argument will be selected.
15019 * expression.cs (Unary::Emit): Emit code for -expr.
15021 (Unary::ResolveOperator): Handle `Substract' for non-constants
15022 (substract from zero from the non-constants).
15023 Deal with Doubles as well.
15025 (Expression::ConvertImplicitRequired): New routine that reports an
15026 error if no implicit conversion exists.
15028 (Invocation::OverloadResolve): Store the converted implicit
15029 expressions if we make them
15031 2001-09-24 Ravi Pratap <ravi@ximian.com>
15033 * class.cs (ConstructorInitializer): Take a Location argument.
15034 (ConstructorBaseInitializer): Same here.
15035 (ConstructorThisInitializer): Same here.
15037 * cs-parser.jay : Update all calls accordingly.
15039 * expression.cs (Unary, Binary, New): Take location argument.
15040 Update accordingly everywhere.
15042 * cs-parser.jay : Update all calls to the above to take a location
15045 * class.cs : Ditto.
15047 2001-09-24 Ravi Pratap <ravi@ximian.com>
15049 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
15050 (Invocation::BetterConversion): Same here
15051 (Invocation::ConversionExists): Ditto.
15053 (Invocation::ConversionExists): Implement.
15055 2001-09-22 Ravi Pratap <ravi@ximian.com>
15057 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
15058 Also take an additional TypeContainer argument.
15060 * All over : Pass in TypeContainer as argument to OverloadResolve.
15062 * typemanager.cs (CSharpName): Update to check for the string type and return
15065 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
15068 2001-09-21 Ravi Pratap <ravi@ximian.com>
15070 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
15071 (Invocation::BetterFunction): Implement.
15072 (Invocation::BetterConversion): Implement.
15073 (Invocation::ConversionExists): Skeleton, no implementation yet.
15075 Okay, things work fine !
15077 2001-09-21 Miguel de Icaza <miguel@ximian.com>
15079 * typemanager.cs: declare and load enum_type, delegate_type and
15082 * expression.cs (Expression::Emit): Now emit returns a value that
15083 tells whether a value is left on the stack or not. This strategy
15084 might be reveted tomorrow with a mechanism that would address
15085 multiple assignments.
15086 (Expression::report118): Utility routine to report mismatches on
15089 (Unary::Report23): Report impossible type/operator combination
15092 (Unary::IsIncrementableNumber): Whether the type can be
15093 incremented or decremented with add.
15094 (Unary::ResolveOperator): Also allow enumerations to be bitwise
15096 (Unary::ResolveOperator): Implement ++, !, ~,
15098 (Invocation::Emit): Deal with new Emit convetion.
15100 * All Expression derivatives: Updated their Emit method to return
15101 whether they leave values on the stack or not.
15103 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
15104 stack for expressions that are statements.
15106 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15108 * expression.cs (LValue): New interface. Must be implemented by
15110 (LocalVariableReference, ParameterReference, FieldExpr): Implement
15113 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
15114 interface for generating code, simplifies the code.
15116 2001-09-20 Ravi Pratap <ravi@ximian.com>
15118 * expression.cs (everywhere): Comment out return statements in ::Resolve
15119 methods to avoid the warnings.
15121 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15123 * driver.cs (parse): Report error 2001 if we can not open the
15126 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
15129 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
15132 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
15133 otherwise nested blocks end up with the same index.
15135 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
15137 * expression.cs: Instead of having FIXMEs in the Resolve
15138 functions, throw exceptions so it is obvious that we are facing a
15141 * cs-parser.jay (invocation_expression): Pass Location information.
15143 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
15144 Use a basename for those routines because .NET does not like paths
15147 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
15150 2001-09-19 Miguel de Icaza <miguel@ximian.com>
15152 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
15153 are loading the correct data types (throws an exception if not).
15154 (TypeManager::InitCoreTypes): Use CoreLookupType
15156 * expression.cs (Unary::ResolveOperator): return the child
15157 expression for expressions which are just +expr.
15158 (Unary::ResolveOperator): Return negative literals for -LITERAL
15159 expressions (otherwise they are Unary {Literal}).
15160 (Invocation::Badness): Take into account `Implicit constant
15161 expression conversions'.
15163 * literal.cs (LongLiteral): Implement long literal class.
15164 (IntLiteral): export the `Value' of the intliteral.
15166 2001-09-19 Ravi Pratap <ravi@ximian.com>
15168 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
15170 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
15171 instead of 'Operator'
15173 * expression.cs (Binary::ResolveOperator): Update accordingly.
15174 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
15177 * cs-parser.jay (unary_expression): Update to use the new names.
15179 * gen-treedump.cs (GetUnary): Same here.
15181 * expression.cs (Unary::Resolve): Implement.
15182 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
15183 operators are found instead of making noise ;-)
15184 (Unary::ResolveOperator): New method to do precisely the same thing which
15185 Binary::ResolveOperator does for Binary expressions.
15186 (Unary.method, .Arguments): Add.
15187 (Unary::OperName): Implement.
15188 (Unary::ForceConversion): Copy and Paste !
15190 * class.cs (Operator::Define): Fix a small bug for the case when we have
15193 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
15194 for the inbuilt operators. Only overloading works for now ;-)
15196 2001-09-18 Miguel de Icaza <miguel@ximian.com>
15198 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
15199 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
15201 * expression.cs (This::Emit): Implement.
15202 (This::Resolve): Implement.
15203 (TypeOf:Resolve): Implement.
15204 (Expression::ResolveSimpleName): Add an implicit this to instance
15206 (MemberAccess::Resolve): Deal with Parameters and Fields.
15207 Bind instance variable to Field expressions.
15208 (FieldExpr::Instance): New field used to track the expression that
15209 represents the object instance.
15210 (FieldExpr::Resolve): Track potential errors from MemberLookup not
15212 (FieldExpr::Emit): Implement.
15214 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
15215 the last instruction contains a return opcode to avoid generating
15216 the last `ret' instruction (this generates correct code, and it is
15217 nice to pass the peverify output).
15219 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
15220 initializer for static and instance variables.
15221 (Constructor::Emit): Allow initializer to be null in the case of
15222 static constructors. Only emit initializer for instance
15225 (TypeContainer::FindMembers): Return a null array if there are no
15228 Also fix the code for the MemberTypes.Method branch, as it was not
15229 scanning that for operators (or tried to access null variables before).
15231 * assign.cs (Assign::Emit): Handle instance and static fields.
15235 * driver.cs: Stop compilation if there are parse errors.
15237 * cs-parser.jay (constructor_declaration): Provide default base
15238 initializer for non-static constructors.
15239 (constructor_declarator): Do not provide a default base
15240 initializers if none was specified.
15241 Catch the fact that constructors should not have parameters.
15243 * class.cs: Do not emit parent class initializers for static
15244 constructors, that should be flagged as an error.
15246 2001-09-18 Ravi Pratap <ravi@ximian.com>
15248 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
15249 Move back code into TypeContainer::Populate.
15251 2001-09-18 Ravi Pratap <ravi@ximian.com>
15253 * class.cs (TypeContainer::AddConstructor): Fix the check to
15254 compare against Name, not Basename.
15255 (Operator::OpType): Change Plus and Minus to Add and Subtract.
15257 * cs-parser.jay : Update accordingly.
15259 * class.cs (TypeContainer::FindMembers): For the case where we are searching
15260 for methods, don't forget to look into the operators too.
15261 (RegisterMethodBuilder): Helper method to take care of this for
15262 methods, constructors and operators.
15263 (Operator::Define): Completely revamp.
15264 (Operator.OperatorMethod, MethodName): New fields.
15265 (TypeContainer::Populate): Move the registering of builders into
15266 RegisterMethodBuilder.
15267 (Operator::Emit): Re-write.
15269 * expression.cs (Binary::Emit): Comment out code path to emit method
15270 invocation stuff for the case when we have a user defined operator. I am
15271 just not able to get it right !
15273 2001-09-17 Miguel de Icaza <miguel@ximian.com>
15275 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
15278 (Expression::MemberLookup): Provide a version that allows to
15279 specify the MemberTypes and BindingFlags.
15281 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
15282 so it was not fetching variable information from outer blocks.
15284 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
15285 Beforefieldinit as it was buggy.
15287 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
15288 that Ravi put here.
15290 * class.cs (Constructor::Emit): Only emit if block is not null.
15291 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
15292 deal with this by semantically definining it as if the user had
15295 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
15296 constructors as we now "emit" them at a higher level.
15298 (TypeContainer::DefineDefaultConstructor): Used to define the
15299 default constructors if none was provided.
15301 (ConstructorInitializer): Add methods Resolve and Emit.
15303 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
15305 2001-09-17 Ravi Pratap <ravi@ximian.com>
15307 * class.cs (TypeContainer::EmitDefaultConstructor): Register
15308 the default constructor builder with our hashtable for methodbuilders
15311 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
15312 and argument_count is 0 in which case we have a match.
15313 (Binary::ResolveOperator): More null checking and miscellaneous coding
15316 2001-09-17 Ravi Pratap <ravi@ximian.com>
15318 * rootcontext.cs (IsNameSpace): Compare against null.
15320 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
15322 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
15323 and Unary::Operator.
15325 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
15328 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
15329 we have overloaded operators.
15330 (Binary::ResolveOperator): Implement the part which does the operator overload
15333 * class.cs (Operator::Emit): Implement.
15334 (TypeContainer::Emit): Emit the operators we have too.
15336 * expression.cs (Binary::Emit): Update to emit the appropriate code for
15337 the case when we have a user-defined operator.
15339 2001-09-17 Miguel de Icaza <miguel@ximian.com>
15341 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
15343 2001-09-16 Ravi Pratap <ravi@ximian.com>
15345 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
15346 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
15347 (Constructor::Emit): Implement.
15348 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
15349 if we have no work to do.
15350 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
15353 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
15354 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
15356 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
15359 2001-09-15 Ravi Pratap <ravi@ximian.com>
15361 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
15363 (Tree::RecordNamespace): Method to do what the name says ;-)
15364 (Tree::Namespaces): Property to get at the namespaces hashtable.
15366 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
15369 * rootcontext.cs (IsNamespace): Fixed it :-)
15371 2001-09-14 Miguel de Icaza <miguel@ximian.com>
15373 * class.cs (TypeContainer::FindMembers): Add support for
15375 (MethodCore): New class that encapsulates both the shared aspects
15376 of a Constructor and a Method.
15377 (Method, Constructor): Factored pieces into MethodCore.
15379 * driver.cs: Added --fatal which makes errors throw exceptions.
15380 Load System assembly as well as part of the standard library.
15382 * report.cs: Allow throwing exceptions on errors for debugging.
15384 * modifiers.cs: Do not use `parent', instead use the real type
15385 container to evaluate permission settings.
15387 * class.cs: Put Ravi's patch back in. He is right, and we will
15388 have to cope with the
15390 2001-09-14 Ravi Pratap <ravi@ximian.com>
15392 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
15393 FamORAssem, not FamANDAssem.
15395 2001-09-14 Miguel de Icaza <miguel@ximian.com>
15397 * driver.cs: Added --parse option that only parses its input files
15400 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
15401 incorrect. IsTopLevel is not used to tell whether an object is
15402 root_types or not (that can be achieved by testing this ==
15403 root_types). But to see if this is a top-level *class* (not
15404 necessarly our "toplevel" container).
15406 2001-09-14 Ravi Pratap <ravi@ximian.com>
15408 * enum.cs (Enum::Define): Modify to call the Lookup method on the
15409 parent instead of a direct call to GetType.
15411 2001-09-14 Ravi Pratap <ravi@ximian.com>
15413 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
15414 Modifiers.TypeAttr. This should just be a call to that method.
15416 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
15417 object so that we can determine if we are top-level or not.
15419 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
15422 * enum.cs (Enum::Define): Ditto.
15424 * modifiers.cs (FieldAttr): Re-write.
15426 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
15427 (TypeContainer::HaveStaticConstructor): New property to provide access
15428 to precisely that info.
15430 * modifiers.cs (MethodAttr): Re-write.
15431 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
15433 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
15434 of top-level types as claimed.
15436 2001-09-13 Miguel de Icaza <miguel@ximian.com>
15438 * expression.cs (MemberLookup): Fruitless attempt to lookup
15439 constructors. Maybe I need to emit default constructors? That
15440 might be it (currently .NET emits this for me automatically).
15441 (Invocation::OverloadResolve): Cope with Arguments == null.
15442 (Invocation::EmitArguments): new function, shared by the new
15443 constructor and us.
15444 (Invocation::Emit): Handle static and instance methods. Emit
15445 proper call instruction for virtual or non-virtual invocations.
15446 (New::Emit): Implement.
15447 (New::Resolve): Implement.
15448 (MemberAccess:Resolve): Implement.
15449 (MethodGroupExpr::InstanceExpression): used conforming to the spec
15450 to track instances.
15451 (FieldExpr::Resolve): Set type.
15453 * support.cs: Handle empty arguments.
15455 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
15456 SimpleLookup): Auxiliary routines to help parse a qualifier
15459 Update qualifier_identifier rule.
15461 * codegen.cs: Removed debugging messages.
15463 * class.cs: Make this a global thing, this acts just as a "key" to
15464 objects that we might have around.
15466 (Populate): Only initialize method_builders_to_methods once.
15468 * expression.cs (PropertyExpr): Initialize type from the
15471 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
15472 Resolve pattern. Attempt to implicitly convert value to boolean.
15475 * expression.cs: Set the type for the int32/int32 argument case.
15476 (Binary::ResolveOperator): Set the return type to boolean for
15477 comparission operators
15479 * typemanager.cs: Remove debugging print code.
15481 (Invocation::Resolve): resolve type.
15483 * class.cs: Allocate a MemberInfo of the correct size, as the code
15484 elsewhere depends on the test to reflect the correct contents.
15486 (Method::) Keep track of parameters, due to System.Reflection holes
15488 (TypeContainer::Populate): Keep track of MethodBuilders to Method
15491 (TypeContainer::FindMembers): Use ArrayList and then copy an array
15492 of the exact size and return that.
15494 (Class::LookupMethodByBuilder): New function that maps
15495 MethodBuilders to its methods. Required to locate the information
15496 on methods because System.Reflection bit us again.
15498 * support.cs: New file, contains an interface ParameterData and
15499 two implementations: ReflectionParameters and InternalParameters
15500 used to access Parameter information. We will need to grow this
15503 * expression.cs (Invocation::GetParameterData): implement a cache
15504 and a wrapper around the ParameterData creation for methods.
15505 (Invocation::OverloadResolve): Use new code.
15507 2001-09-13 Ravi Pratap <ravi@ximian.com>
15509 * class.cs (TypeContainer::EmitField): Remove and move into
15510 (Field::Define): here and modify accordingly.
15511 (Field.FieldBuilder): New member.
15512 (TypeContainer::Populate): Update accordingly.
15513 (TypeContainer::FindMembers): Implement.
15515 2001-09-13 Miguel de Icaza <miguel@ximian.com>
15517 * statement.cs: (VariableInfo::VariableType): New field to be
15518 initialized with the full type once it is resolved.
15520 2001-09-12 Miguel de Icaza <miguel@ximian.com>
15522 * parameter.cs (GetParameterInfo): Use a type cache to compute
15523 things only once, and to reuse this information
15525 * expression.cs (LocalVariableReference::Emit): Implement.
15526 (OpcodeCast::Emit): fix.
15528 (ParameterReference::Resolve): Implement.
15529 (ParameterReference::Emit): Implement.
15531 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
15532 that are expressions need to stay as Expressions.
15534 * typemanager.cs (CSharpName): Returns the C# name of a type if
15537 * expression.cs (Expression::ConvertImplicit): New function that
15538 implements implicit type conversions.
15540 (Expression::ImplicitReferenceConversion): Implements implicit
15541 reference conversions.
15543 (EmptyCast): New type for transparent casts.
15545 (OpcodeCast): New type for casts of types that are performed with
15546 a sequence of bytecodes.
15548 (BoxedCast): New type used for casting value types into reference
15549 types. Emits a box opcode.
15551 (Binary::DoNumericPromotions): Implements numeric promotions of
15552 and computation of the Binary::Type.
15554 (Binary::EmitBranchable): Optimization.
15556 (Binary::Emit): Implement code emission for expressions.
15558 * typemanager.cs (TypeManager): Added two new core types: sbyte
15561 2001-09-12 Ravi Pratap <ravi@ximian.com>
15563 * class.cs (TypeContainer::FindMembers): Method which does exactly
15564 what Type.FindMembers does, only we don't have to use reflection. No
15565 implementation yet.
15567 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
15568 typecontainer objects as we need to get at them.
15569 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
15571 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
15572 typecontainer object.
15574 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
15575 of just a Report object.
15577 2001-09-11 Ravi Pratap <ravi@ximian.com>
15579 * class.cs (Event::Define): Go back to using the prefixes "add_" and
15581 (TypeContainer::Populate): Now define the delegates of the type too.
15582 (TypeContainer.Delegates): Property to access the list of delegates defined
15585 * delegates.cs (Delegate::Define): Implement partially.
15587 * modifiers.cs (TypeAttr): Handle more flags.
15589 2001-09-11 Ravi Pratap <ravi@ximian.com>
15591 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
15593 (Operator::Define): Re-write logic to get types by using the LookupType method
15594 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
15595 (Indexer::Define): Ditto.
15596 (Event::Define): Ditto.
15597 (Property::Define): Ditto.
15599 2001-09-10 Ravi Pratap <ravi@ximian.com>
15601 * class.cs (TypeContainer::Populate): Now define operators too.
15602 (TypeContainer.Operators): New property to access the list of operators
15604 (Operator.OperatorMethodBuilder): New member to hold the method builder
15605 for the operator we are defining.
15606 (Operator::Define): Implement.
15608 2001-09-10 Ravi Pratap <ravi@ximian.com>
15610 * class.cs (Event::Define): Make the prefixes of the accessor methods
15611 addOn_ and removeOn_
15613 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
15614 of the location being passed in too. Ideally, this should go later since all
15615 error reporting should be done through the Report object.
15617 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
15618 (Populate): Iterate thru the indexers we have and define them too.
15619 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
15620 for the get and set accessors.
15621 (Indexer::Define): Implement.
15623 2001-09-09 Miguel de Icaza <miguel@ximian.com>
15625 * expression.cs (Binary::Resolve): Beginning of it. I scratched
15626 my previous implementation, did not work.
15628 * typemanager.cs: Add a couple of missing types (the longs).
15630 * literal.cs: Use TypeManager.bool_type instead of getting it.
15632 * expression.cs (EventExpr): New kind of expressions.
15633 (Expressio::ExprClassFromMemberInfo): finish
15635 2001-09-08 Miguel de Icaza <miguel@ximian.com>
15637 * assign.cs: Emit stores to static fields differently.
15639 2001-09-08 Ravi Pratap <ravi@ximian.com>
15641 * Merge in changes and adjust code to tackle conflicts. Backed out my
15642 code in Assign::Resolve ;-)
15644 2001-09-08 Ravi Pratap <ravi@ximian.com>
15646 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
15647 instead Report.Error and also pass in the location.
15648 (CSharpParser::Lexer): New readonly property to return the reference
15649 to the Tokenizer object.
15650 (declare_local_variables): Use Report.Error with location instead of plain
15654 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
15655 (Operator.CheckBinaryOperator): Ditto.
15657 * cs-parser.jay (operator_declarator): Update accordingly.
15659 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
15660 (CheckBinaryOperator): Same here.
15662 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
15663 on the name without any prefixes of namespace names etc. This is because we
15664 already might have something already fully qualified like
15665 'System.Console.WriteLine'
15667 * assign.cs (Resolve): Begin implementation. Stuck ;-)
15669 2001-09-07 Ravi Pratap <ravi@ximian.com>
15671 * cs-tokenizer.cs (location): Return a string which also contains
15674 * expression.cs (ElementAccess): New class for expressions of the
15675 type 'element access.'
15676 (BaseAccess): New class for expressions of the type 'base access.'
15677 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
15680 * cs-parser.jay (element_access): Implement action.
15681 (base_access): Implement actions.
15682 (checked_expression, unchecked_expression): Implement.
15684 * cs-parser.jay (local_variable_type): Correct and implement.
15685 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
15687 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
15689 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
15690 name and the specifiers.
15692 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
15694 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
15695 making them all public ;-)
15697 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
15700 2001-09-07 Miguel de Icaza <miguel@ximian.com>
15702 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
15704 (FieldExpr, PropertyExprs): New resolved expressions.
15705 (SimpleName::MemberStaticCheck): Perform static checks for access
15706 to non-static fields on static methods. Maybe this should be
15707 generalized for MemberAccesses.
15708 (SimpleName::ResolveSimpleName): More work on simple name
15711 * cs-parser.jay (primary_expression/qualified_identifier): track
15712 the parameter index.
15714 * codegen.cs (CodeGen::Save): Catch save exception, report error.
15715 (EmitContext::EmitBoolExpression): Chain to expression generation
15716 instead of temporary hack.
15717 (::EmitStatementExpression): Put generic expression code generation.
15719 * assign.cs (Assign::Emit): Implement variable assignments to
15720 local variables, parameters and fields.
15722 2001-09-06 Miguel de Icaza <miguel@ximian.com>
15724 * statement.cs (Block::GetVariableInfo): New method, returns the
15725 VariableInfo for a variable name in a block.
15726 (Block::GetVariableType): Implement in terms of GetVariableInfo
15728 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
15729 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
15731 2001-09-06 Ravi Pratap <ravi@ximian.com>
15733 * cs-parser.jay (operator_declaration): Continue on my quest : update
15734 to take attributes argument.
15735 (event_declaration): Ditto.
15736 (enum_declaration): Ditto.
15737 (indexer_declaration): Ditto.
15739 * class.cs (Operator::Operator): Update constructor accordingly.
15740 (Event::Event): Ditto.
15742 * delegate.cs (Delegate::Delegate): Same here.
15744 * enum.cs (Enum::Enum): Same here.
15746 2001-09-05 Ravi Pratap <ravi@ximian.com>
15748 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
15750 * ../tests/cs0658.cs : New file to demonstrate error 0658.
15752 * attribute.cs (Attributes): New class to encapsulate all attributes which were
15753 being passed around as an arraylist.
15754 (Attributes::AddAttribute): Method to add attribute sections.
15756 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
15757 (struct_declaration): Update accordingly.
15758 (constant_declaration): Update.
15759 (field_declaration): Update.
15760 (method_header): Update.
15761 (fixed_parameter): Update.
15762 (parameter_array): Ditto.
15763 (property_declaration): Ditto.
15764 (destructor_declaration): Ditto.
15766 * class.cs (Struct::Struct): Update constructors accordingly.
15767 (Class::Class): Ditto.
15768 (Field::Field): Ditto.
15769 (Method::Method): Ditto.
15770 (Property::Property): Ditto.
15771 (TypeContainer::OptAttribute): update property's return type.
15773 * interface.cs (Interface.opt_attributes): New member.
15774 (Interface::Interface): Update to take the extra Attributes argument.
15776 * parameter.cs (Parameter::Parameter): Ditto.
15778 * constant.cs (Constant::Constant): Ditto.
15780 * interface.cs (InterfaceMemberBase): New OptAttributes field.
15781 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
15782 the attributes as a parameter.
15783 (InterfaceProperty): Update constructor call.
15784 (InterfaceEvent): Ditto.
15785 (InterfaceMethod): Ditto.
15786 (InterfaceIndexer): Ditto.
15788 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
15789 pass the attributes too.
15790 (interface_event_declaration): Ditto.
15791 (interface_property_declaration): Ditto.
15792 (interface_method_declaration): Ditto.
15793 (interface_declaration): Ditto.
15795 2001-09-05 Miguel de Icaza <miguel@ximian.com>
15797 * class.cs (Method::Define): Track the "static Main" definition to
15798 create an entry point.
15800 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
15801 EntryPoint if we find it.
15803 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
15804 (EmitContext::ig): Make this variable public.
15806 * driver.cs: Make the default output file be the first file name
15807 with the .exe extension.
15809 Detect empty compilations
15811 Handle various kinds of output targets. Handle --target and
15812 rename -t to --dumper.
15814 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
15815 methods inherited from Expression return now an Expression. This
15816 will is used during the tree rewriting as we resolve them during
15819 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
15820 the spec. Missing entirely is the information about
15821 accessability of elements of it.
15823 (Expression::ExprClassFromMemberInfo): New constructor for
15824 Expressions that creates a fully initialized Expression based on
15825 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
15828 (Invocation::Resolve): Begin implementing resolution of invocations.
15830 * literal.cs (StringLiteral): Implement Emit.
15832 2001-09-05 Ravi Pratap <ravi@ximian.com>
15834 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
15837 2001-09-04 Ravi Pratap <ravi@ximian.com>
15839 * cs-parser.jay (attribute_arguments): Implement actions.
15840 (attribute): Fix bug in production. Implement action.
15841 (attribute_list): Implement.
15842 (attribute_target): Implement.
15843 (attribute_target_specifier, opt_target_specifier): Implement
15844 (CheckAttributeTarget): New method to check if the attribute target
15846 (attribute_section): Implement.
15847 (opt_attributes): Implement.
15849 * attribute.cs : New file to handle attributes.
15850 (Attribute): Class to hold attribute info.
15852 * cs-parser.jay (opt_attribute_target_specifier): Remove production
15853 (attribute_section): Modify production to use 2 different rules to
15854 achieve the same thing. 1 s/r conflict down !
15855 Clean out commented, useless, non-reducing dimension_separator rules.
15857 * class.cs (TypeContainer.attributes): New member to hold list
15858 of attributes for a type.
15859 (Struct::Struct): Modify to take one more argument, the attribute list.
15860 (Class::Class): Ditto.
15861 (Field::Field): Ditto.
15862 (Method::Method): Ditto.
15863 (Property::Property): Ditto.
15865 * cs-parser.jay (struct_declaration): Update constructor call to
15866 pass in the attributes too.
15867 (class_declaration): Ditto.
15868 (constant_declaration): Ditto.
15869 (field_declaration): Ditto.
15870 (method_header): Ditto.
15871 (fixed_parameter): Ditto.
15872 (parameter_array): Ditto.
15873 (property_declaration): Ditto.
15875 * constant.cs (Constant::Constant): Update constructor similarly.
15876 Use System.Collections.
15878 * parameter.cs (Parameter::Parameter): Update as above.
15880 2001-09-02 Ravi Pratap <ravi@ximian.com>
15882 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
15883 (TypeContainer.delegates): New member to hold list of delegates.
15885 * cs-parser.jay (delegate_declaration): Implement the action correctly
15886 this time as I seem to be on crack ;-)
15888 2001-09-02 Miguel de Icaza <miguel@ximian.com>
15890 * rootcontext.cs (RootContext::IsNamespace): new function, used to
15891 tell whether an identifier represents a namespace.
15893 * expression.cs (NamespaceExpr): A namespace expression, used only
15894 temporarly during expression resolution.
15895 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
15896 utility functions to resolve names on expressions.
15898 2001-09-01 Miguel de Icaza <miguel@ximian.com>
15900 * codegen.cs: Add hook for StatementExpressions.
15902 * class.cs: Fix inverted test for static flag in methods.
15904 2001-09-02 Ravi Pratap <ravi@ximian.com>
15906 * class.cs (Operator::CheckUnaryOperator): Correct error number used
15907 to make it coincide with MS' number.
15908 (Operator::CheckBinaryOperator): Ditto.
15910 * ../errors/errors.txt : Remove error numbers added earlier.
15912 * ../errors/cs1019.cs : Test case for error # 1019
15914 * ../errros/cs1020.cs : Test case for error # 1020
15916 * cs-parser.jay : Clean out commented cruft.
15917 (dimension_separators, dimension_separator): Comment out. Ostensibly not
15918 used anywhere - non-reducing rule.
15919 (namespace_declarations): Non-reducing rule - comment out.
15921 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
15922 with TypeContainer::AddEnum.
15924 * delegate.cs : New file for delegate handling classes.
15925 (Delegate): Class for declaring delegates.
15927 * makefile : Update.
15929 * cs-parser.jay (delegate_declaration): Implement.
15931 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
15933 * class.cs (Event::Define): Implement.
15934 (Event.EventBuilder): New member.
15936 * class.cs (TypeContainer::Populate): Update to define all enums and events
15938 (Events): New property for the events arraylist we hold. Shouldn't we move to using
15939 readonly fields for all these cases ?
15941 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15943 * class.cs (Property): Revamp to use the convention of making fields readonly.
15944 Accordingly modify code elsewhere.
15946 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
15947 the Define method of the Property class.
15949 * class.cs : Clean up applied patch and update references to variables etc. Fix
15951 (TypeContainer::Populate): Update to define all the properties we have. Also
15952 define all enumerations.
15954 * enum.cs (Define): Implement.
15956 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15958 * cs-parser.jay (overloadable_operator): The semantic value is an
15959 enum of the Operator class.
15960 (operator_declarator): Implement actions.
15961 (operator_declaration): Implement.
15963 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
15964 validity of definitions.
15965 (Operator::CheckBinaryOperator): Static method to check for binary operators
15966 (TypeContainer::AddOperator): New method to add an operator to a type.
15968 * cs-parser.jay (indexer_declaration): Added line to actually call the
15969 AddIndexer method so it gets added ;-)
15971 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
15972 already taken care of by the MS compiler ?
15974 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15976 * class.cs (Operator): New class for operator declarations.
15977 (Operator::OpType): Enum for the various operators.
15979 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15981 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
15982 ostensibly handle this in semantic analysis.
15984 * cs-parser.jay (general_catch_clause): Comment out
15985 (specific_catch_clauses, specific_catch_clause): Ditto.
15986 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
15987 (catch_args, opt_catch_args): New productions.
15988 (catch_clause): Rewrite to use the new productions above
15989 (catch_clauses): Modify accordingly.
15990 (opt_catch_clauses): New production to use in try_statement
15991 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
15992 and re-write the code in the actions to extract the specific and
15993 general catch clauses by being a little smart ;-)
15995 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
15996 Hooray, try and catch statements parse fine !
15998 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16000 * statement.cs (Block::GetVariableType): Fix logic to extract the type
16001 string from the hashtable of variables.
16003 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
16004 I end up making that mistake ;-)
16005 (catch_clauses): Fixed gross error which made Key and Value of the
16006 DictionaryEntry the same : $1 !!
16008 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16010 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
16012 * cs-parser.jay (event_declaration): Correct to remove the semicolon
16013 when the add and remove accessors are specified.
16015 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16017 * cs-parser.jay (IndexerDeclaration): New helper class to hold
16018 information about indexer_declarator.
16019 (indexer_declarator): Implement actions.
16020 (parsing_indexer): New local boolean used to keep track of whether
16021 we are parsing indexers or properties. This is necessary because
16022 implicit_parameters come into picture even for the get accessor in the
16023 case of an indexer.
16024 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
16026 * class.cs (Indexer): New class for indexer declarations.
16027 (TypeContainer::AddIndexer): New method to add an indexer to a type.
16028 (TypeContainer::indexers): New member to hold list of indexers for the
16031 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16033 * cs-parser.jay (add_accessor_declaration): Implement action.
16034 (remove_accessor_declaration): Implement action.
16035 (event_accessors_declaration): Implement
16036 (variable_declarators): swap statements for first rule - trivial.
16038 * class.cs (Event): New class to hold information about event
16040 (TypeContainer::AddEvent): New method to add an event to a type
16041 (TypeContainer::events): New member to hold list of events.
16043 * cs-parser.jay (event_declaration): Implement actions.
16045 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16047 * cs-parser.jay (dim_separators): Implement. Make it a string
16048 concatenating all the commas together, just as they appear.
16049 (opt_dim_separators): Modify accordingly
16050 (rank_specifiers): Update accordingly. Basically do the same
16051 thing - instead, collect the brackets here.
16052 (opt_rank_sepcifiers): Modify accordingly.
16053 (array_type): Modify to actually return the complete type string
16054 instead of ignoring the rank_specifiers.
16055 (expression_list): Implement to collect the expressions
16056 (variable_initializer): Implement. We make it a list of expressions
16057 essentially so that we can handle the array_initializer case neatly too.
16058 (variable_initializer_list): Implement.
16059 (array_initializer): Make it a list of variable_initializers
16060 (opt_array_initializer): Modify accordingly.
16062 * expression.cs (New::NType): Add enumeration to help us
16063 keep track of whether we have an object/delegate creation
16064 or an array creation.
16065 (New:NewType, New::Rank, New::Indices, New::Initializers): New
16066 members to hold data about array creation.
16067 (New:New): Modify to update NewType
16068 (New:New): New Overloaded contructor for the array creation
16071 * cs-parser.jay (array_creation_expression): Implement to call
16072 the overloaded New constructor.
16074 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
16076 * class.cs (TypeContainer::Constructors): Return member
16077 constructors instead of returning null.
16079 2001-08-26 Miguel de Icaza <miguel@ximian.com>
16081 * typemanager.cs (InitCoreTypes): Initialize the various core
16082 types after we have populated the type manager with the user
16083 defined types (this distinction will be important later while
16084 compiling corlib.dll)
16086 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
16087 on Expression Classification. Now all expressions have a method
16088 `Resolve' and a method `Emit'.
16090 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
16091 generation from working. Also add some temporary debugging
16094 2001-08-24 Miguel de Icaza <miguel@ximian.com>
16096 * codegen.cs: Lots of code generation pieces. This is only the
16097 beginning, will continue tomorrow with more touches of polish. We
16098 handle the fundamentals of if, while, do, for, return. Others are
16099 trickier and I need to start working on invocations soon.
16101 * gen-treedump.cs: Bug fix, use s.Increment here instead of
16104 * codegen.cs (EmitContext): New struct, used during code
16105 emission to keep a context. Most of the code generation will be
16108 * cs-parser.jay: Add embedded blocks to the list of statements of
16109 this block. So code generation proceeds in a top down fashion.
16111 2001-08-23 Miguel de Icaza <miguel@ximian.com>
16113 * statement.cs: Add support for multiple child blocks.
16115 2001-08-22 Miguel de Icaza <miguel@ximian.com>
16117 * codegen.cs (EmitCode): New function, will emit the code for a
16118 Block of code given a TypeContainer and its ILGenerator.
16120 * statement.cs (Block): Standard public readonly optimization.
16121 (Block::Block constructors): Link children.
16122 (Block::Child): Child Linker.
16123 (Block::EmitVariables): Emits IL variable declarations.
16125 * class.cs: Drop support for MethodGroups here, delay until
16127 (Method::): Applied the same simplification that I did before, and
16128 move from Properties to public readonly fields.
16129 (Method::ParameterTypes): Returns the parameter types for the
16130 function, and implements a cache that will be useful later when I
16131 do error checking and the semantic analysis on the methods is
16133 (Constructor::GetCallingConvention): Renamed from CallingConvetion
16134 and made a method, optional argument tells whether this is a class
16135 or a structure to apply the `has-this' bit.
16136 (Method::GetCallingConvention): Implement, returns the calling
16138 (Method::Define): Defines the type, a second pass is performed
16139 later to populate the methods.
16141 (Constructor::ParameterTypes): implement a cache similar to the
16142 one on Method::ParameterTypes, useful later when we do semantic
16145 (TypeContainer::EmitMethod): New method. Emits methods.
16147 * expression.cs: Removed MethodGroup class from here.
16149 * parameter.cs (Parameters::GetCallingConvention): new method.
16151 2001-08-21 Miguel de Icaza <miguel@ximian.com>
16153 * class.cs (TypeContainer::Populate): Drop RootContext from the
16156 (Constructor::CallingConvention): Returns the calling convention.
16157 (Constructor::ParameterTypes): Returns the constructor parameter
16160 (TypeContainer::AddConstructor): Keep track of default constructor
16161 and the default static constructor.
16163 (Constructor::) Another class that starts using `public readonly'
16164 instead of properties.
16166 (Constructor::IsDefault): Whether this is a default constructor.
16168 (Field::) use readonly public fields instead of properties also.
16170 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
16171 track of static constructors; If none is used, turn on
16172 BeforeFieldInit in the TypeAttributes.
16174 * cs-parser.jay (opt_argument_list): now the return can be null
16175 for the cases where there are no arguments.
16177 (constructor_declarator): If there is no implicit `base' or
16178 `this', then invoke the default parent constructor.
16180 * modifiers.cs (MethodAttr): New static function maps a set of
16181 modifiers flags into a MethodAttributes enum
16182 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
16183 MethodAttr, TypeAttr to represent the various mappings where the
16184 modifiers are used.
16185 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
16187 2001-08-19 Miguel de Icaza <miguel@ximian.com>
16189 * parameter.cs (GetParameterInfo): Fix bug where there would be no
16192 * interface.cs (PopulateIndexer): Implemented the code generator
16193 for interface indexers.
16195 2001-08-17 Miguel de Icaza <miguel@ximian.com>
16197 * interface.cs (InterfaceMemberBase): Now we track the new status
16200 (PopulateProperty): Implement property population. Woohoo! Got
16201 Methods and Properties going today.
16203 Removed all the properties for interfaces, and replaced them with
16204 `public readonly' fields.
16206 2001-08-16 Miguel de Icaza <miguel@ximian.com>
16208 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
16209 initialize their hashtables/arraylists only when they are needed
16210 instead of doing this always.
16212 * parameter.cs: Handle refs and out parameters.
16214 * cs-parser.jay: Use an ArrayList to construct the arguments
16215 instead of the ParameterCollection, and then cast that to a
16218 * parameter.cs: Drop the use of ParameterCollection and use
16219 instead arrays of Parameters.
16221 (GetParameterInfo): Use the Type, not the Name when resolving
16224 2001-08-13 Miguel de Icaza <miguel@ximian.com>
16226 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
16227 and instead use public readonly fields.
16229 * class.cs: Put back walking code for type containers.
16231 2001-08-11 Miguel de Icaza <miguel@ximian.com>
16233 * class.cs (MakeConstant): Code to define constants.
16235 * rootcontext.cs (LookupType): New function. Used to locate types
16238 2001-08-08 Miguel de Icaza <miguel@ximian.com>
16240 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
16241 this System.Reflection code is. Kudos to Microsoft
16243 * typemanager.cs: Implement a type cache and avoid loading all
16244 types at boot time. Wrap in LookupType the internals. This made
16245 the compiler so much faster. Wow. I rule!
16247 * driver.cs: Make sure we always load mscorlib first (for
16248 debugging purposes, nothing really important).
16250 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
16251 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
16253 * rootcontext.cs: Lookup types on their namespace; Lookup types
16254 on namespaces that have been imported using the `using' keyword.
16256 * class.cs (TypeContainer::TypeAttr): Virtualize.
16257 (Class::TypeAttr): Return attributes suitable for this bad boy.
16258 (Struct::TypeAttr): ditto.
16259 Handle nested classes.
16260 (TypeContainer::) Remove all the type visiting code, it is now
16261 replaced with the rootcontext.cs code
16263 * rootcontext.cs (GetClassBases): Added support for structs.
16265 2001-08-06 Miguel de Icaza <miguel@ximian.com>
16267 * interface.cs, statement.cs, class.cs, parameter.cs,
16268 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
16269 Drop use of TypeRefs, and use strings instead.
16271 2001-08-04 Miguel de Icaza <miguel@ximian.com>
16275 * class.cs (Struct::Struct): set the SEALED flags after
16276 checking the modifiers.
16277 (TypeContainer::TypeAttr): new property, returns the
16278 TypeAttributes for a class.
16280 * cs-parser.jay (type_list): Oops, list production was creating a
16281 new list of base types.
16283 * rootcontext.cs (StdLib): New property.
16284 (GetInterfaceTypeByName): returns an interface by type name, and
16285 encapsulates error handling here.
16286 (GetInterfaces): simplified.
16287 (ResolveTree): Encapsulated all the tree resolution here.
16288 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
16291 * driver.cs: Add support for --nostdlib, to avoid loading the
16292 default assemblies.
16293 (Main): Do not put tree resolution here.
16295 * rootcontext.cs: Beginning of the class resolution.
16297 2001-08-03 Miguel de Icaza <miguel@ximian.com>
16299 * rootcontext.cs: Provide better error reporting.
16301 * cs-parser.jay (interface_base): set our $$ to be interfaces.
16303 * rootcontext.cs (CreateInterface): Handle the case where there
16304 are no parent interfaces.
16306 (CloseTypes): Routine to flush types at the end.
16307 (CreateInterface): Track types.
16308 (GetInterfaces): Returns an array of Types from the list of
16309 defined interfaces.
16311 * typemanager.c (AddUserType): Mechanism to track user types (puts
16312 the type on the global type hash, and allows us to close it at the
16315 2001-08-02 Miguel de Icaza <miguel@ximian.com>
16317 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
16318 RecordInterface instead.
16320 * cs-parser.jay: Updated to reflect changes above.
16322 * decl.cs (Definition): Keep track of the TypeBuilder type that
16323 represents this type here. Not sure we will use it in the long
16324 run, but wont hurt for now.
16326 * driver.cs: Smaller changes to accomodate the new code.
16328 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
16331 * rootcontext.cs (CreateInterface): New method, used to create
16332 the System.TypeBuilder type for interfaces.
16333 (ResolveInterfaces): new entry point to resolve the interface
16335 (CodeGen): Property, used to keep track of the code generator.
16337 2001-07-26 Miguel de Icaza <miguel@ximian.com>
16339 * cs-parser.jay: Add a second production for delegate_declaration
16342 (enum_body): Put an opt_comma here instead of putting it on
16343 enum_body or enum_member_declarations so we can handle trailing
16344 commas on enumeration members. Gets rid of a shift/reduce.
16346 (type_list): Need a COMMA in the middle.
16348 (indexer_declaration): Tell tokenizer to recognize get/set
16350 * Remove old targets.
16352 * Re-add the parser target.
16354 2001-07-13 Simon Cozens <simon@simon-cozens.org>
16356 * cs-parser.jay: Add precendence rules for a number of operators
16357 ot reduce the number of shift/reduce conflicts in the grammar.
16359 2001-07-17 Miguel de Icaza <miguel@ximian.com>
16361 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
16364 Get rid of old crufty code.
16366 * rootcontext.cs: Use this to keep track of the parsed
16367 representation and the defined types available to the program.
16369 * gen-treedump.cs: adjust for new convention.
16371 * type.cs: Split out the type manager, and the assembly builder
16374 * typemanager.cs: the type manager will live here now.
16376 * cil-codegen.cs: And the code generator here.
16378 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
16380 * makefile: Fixed up for easy making.
16382 2001-07-13 Simon Cozens <simon@simon-cozens.org>
16384 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
16387 (unary_expression): Expand pre_increment_expression and
16388 post_decrement_expression to reduce a shift/reduce.
16390 2001-07-11 Simon Cozens
16392 * cs-tokenizer.cs: Hex numbers should begin with a 0.
16394 Improve allow_keyword_as_indent name.
16396 2001-06-19 Miguel de Icaza <miguel@ximian.com>
16398 * Adjustments for Beta2.
16400 2001-06-13 Miguel de Icaza <miguel@ximian.com>
16402 * decl.cs: Added `Define' abstract method.
16403 (InTransit): new property, used to catch recursive definitions.
16405 * interface.cs: Implement `Define'.
16407 * modifiers.cs: Map Modifiers.constants to
16408 System.Reflection.TypeAttribute flags.
16410 * class.cs: Keep track of types and user-defined types.
16411 (BuilderInit): New method for creating an assembly
16412 (ResolveType): New function to launch the resolution process, only
16413 used by interfaces for now.
16415 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
16416 that are inserted into the name space.
16418 2001-06-08 Miguel de Icaza <miguel@ximian.com>
16420 * ARGH. I have screwed up my tree so many times due to the use of
16421 rsync rather than using CVS. Going to fix this at once.
16423 * driver.cs: Objetify driver. Load assemblies, use assemblies to
16426 2001-06-07 Miguel de Icaza <miguel@ximian.com>
16428 * Experiment successful: Use System.Type rather that our own
16431 2001-05-25 Miguel de Icaza <miguel@ximian.com>
16433 * cs-parser.jay: Removed nsAliases from here.
16435 Use new namespaces, handle `using XXX;'
16437 * namespace.cs: Reimplemented namespace handling, use a recursive
16438 definition of the class. Now we can keep track of using clauses
16439 and catch invalid using clauses.
16441 2001-05-24 Miguel de Icaza <miguel@ximian.com>
16443 * gen-treedump.cs: Adapted for all the renaming.
16445 * expression.cs (Expression): this class now has a Type property
16446 which returns an expression Type.
16448 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
16449 `Type', as this has a different meaning now in the base
16451 2001-05-22 Miguel de Icaza <miguel@ximian.com>
16453 * interface.cs, class.cs: Removed from all the sources the
16454 references to signature computation, as we can not do method
16455 signature computation during the parsing time, as we are not
16456 trying to solve at that point distinguishing:
16460 void a (NS.Blah x) {}
16463 Which depending on the context might be valid or not, as we do not
16464 know if Blah is the same thing as NS.Blah at that point.
16466 * Redid everything so the code uses TypeRefs now instead of
16467 Types. TypeRefs are just temporary type placeholders, that need
16468 to be resolved. They initially have a pointer to a string and the
16469 current scope in which they are used. This is used later by the
16470 compiler to resolve the reference to an actual Type.
16472 * DeclSpace is no longer a CIR.Type, and neither are
16473 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
16474 are all DeclSpaces, but no Types.
16476 * type.cs (TypeRefManager): This implements the TypeRef manager,
16477 which keeps track of all the types that need to be resolved after
16478 the parsing has finished.
16480 2001-05-13 Miguel de Icaza <miguel@ximian.com>
16482 * ARGH. We are going to have to store `foreach' as a class rather
16483 than resolving it, as we need to verify error 1579 after name
16484 resolution. *OR* we could keep a flag that says `This request to
16485 IEnumerator comes from a foreach statement' which we can then use
16486 to generate the error.
16488 2001-05-10 Miguel de Icaza <miguel@ximian.com>
16490 * class.cs (TypeContainer.AddMethod): we now add methods to the
16491 MethodGroup instead of the method hashtable.
16493 * expression.cs: Add MethodGroup abstraction, which gets us one
16494 step closer to the specification in the way we handle method
16497 * cs-parser.jay (primary_expression): qualified_identifier now
16498 tried to match up an identifier to a local variable reference or
16499 to a parameter reference.
16501 current_local_parameters is now a parser global variable that
16502 points to the current parameters for the block, used during name
16505 (property_declaration): Now creates an implicit `value' argument to
16508 2001-05-09 Miguel de Icaza <miguel@ximian.com>
16510 * parameter.cs: Do not use `param' arguments as part of the
16511 signature, per the spec.
16513 2001-05-08 Miguel de Icaza <miguel@ximian.com>
16515 * decl.cs: Base class for classes, structs and interfaces. This
16516 is the "Declaration Space"
16518 * cs-parser.jay: Use CheckDef for checking declaration errors
16519 instead of having one on each function.
16521 * class.cs: Factor out some code for handling error handling in
16522 accordance to the "Declarations" section in the "Basic Concepts"
16523 chapter in the ECMA C# spec.
16525 * interface.cs: Make all interface member classes derive from
16526 InterfaceMemberBase.
16528 2001-05-07 Miguel de Icaza <miguel@ximian.com>
16530 * Many things: all interfaces are parsed and generated in
16531 gen-treedump. Support for member variables, constructors,
16532 destructors, properties, constants is there.
16534 Beginning of the IL backend, but very little done, just there for
16537 2001-04-29 Miguel de Icaza <miguel@ximian.com>
16539 * cs-parser.jay: Fix labeled statement.
16541 * cs-tokenizer.cs (escape): Escape " and ' always.
16542 ref_line, ref_name: keep track of the line/filename as instructed
16543 by #line by the compiler.
16546 2001-04-27 Miguel de Icaza <miguel@ximian.com>
16548 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
16549 to match the values in System.CodeDOM.
16551 Divid renamed to Divide.
16553 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
16555 (Statements.set): remove.
16557 * System.CodeDOM/CodeCatchClause.cs: always have a valid
16560 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
16561 falseStatements always have valid values.
16563 * cs-parser.jay: Use System.CodeDOM now.