1 2010-01-07 Marek Safar <marek.safar@gmail.com>
3 * *.cs: Extract field specification.
5 2009-12-17 Marek Safar <marek.safar@gmail.com>
7 * field.cs: Extracted from class.cs
9 2009-12-15 Marek Safar <marek.safar@gmail.com>
11 * attribute.cs (GetFixedBuffer): Work on field definition only.
13 2009-12-15 Marek Safar <marek.safar@gmail.com>
15 * *.cs: Clean up NET_4_0 conditional where possible.
17 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
19 support.cs (DynamicType): Assembly property returns the assembly builder.
20 This is required due to how compiler context works in corlib.
22 2009-12-14 Marek Safar <marek.safar@gmail.com>
25 * assign.cs (LocalTemporary): Removed no longer needed special
28 2009-12-11 Marek Safar <marek.safar@gmail.com>
30 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
31 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
32 enum for easier debugging.
34 2009-12-10 Marek Safar <marek.safar@gmail.com>
36 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
39 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
42 2009-12-10 Marek Safar <marek.safar@gmail.com>
44 * cs-parser.jay, statement.cs: Handle parser error in code
47 2009-12-10 Marek Safar <marek.safar@gmail.com>
49 * ecore.cs: Ignore base imported methods when they are already
52 * eval.cs: Handle non-existent keys.
54 * report.cs, driver.cs: Make fatal work with console printer only.
56 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
58 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
60 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
62 * typemanager.cs: Add MakeGenericMethod that checks if the method
63 is really the generic method definition.
65 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
66 to inflate generic methods.
68 2009-12-08 Marek Safar <marek.safar@gmail.com>
71 * anonymous.cs: Use actual type parameters when checking for generic
74 2009-12-08 Marek Safar <marek.safar@gmail.com>
77 * expression.cs (DoNumericPromotion): Fixed typo.
79 2009-12-08 Marek Safar <marek.safar@gmail.com>
81 *.cs: Moving to generics world.
83 cs-parser.jay: Removed current_array_type.
85 2009-12-07 Marek Safar <marek.safar@gmail.com>
87 *.cs: Moving to generics world.
89 2009-12-04 Marek Safar <marek.safar@gmail.com>
91 *.cs: Moving to generics world (day 2).
93 2009-12-03 Marek Safar <marek.safar@gmail.com>
95 *.cs: Moving to generics world.
97 2009-12-02 Marek Safar <marek.safar@gmail.com>
99 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
100 Encode dynamic type attribute for elements where attributes cannot
103 2009-12-01 Marek Safar <marek.safar@gmail.com>
105 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
108 2009-12-01 Marek Safar <marek.safar@gmail.com>
110 A fix for bug #360455
111 * class.cs: Never report a unused warning for generic events to
112 workaround wrong expression type.
114 2009-11-30 Marek Safar <marek.safar@gmail.com>
116 A fix for bug #558305
117 * decl.cs, class.cs: Check partial method definitions using correct
120 2009-11-30 Marek Safar <marek.safar@gmail.com>
122 * argument.cs: Don't cache rarely used dynamic flag.
124 2009-11-27 Marek Safar <marek.safar@gmail.com>
126 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
128 2009-11-27 Marek Safar <marek.safar@gmail.com>
130 * ecore.cs (SimpleName): Removed no longer needed in_transit as
131 Resolve is now non-reentrant (saves ~0.6MB for corlib).
133 2009-11-26 Marek Safar <marek.safar@gmail.com>
135 A fix for bug #545081
136 * decl.cs: Check private nested types of nested types recursively.
138 2009-11-26 Marek Safar <marek.safar@gmail.com>
140 A fix for bug #558305
141 * location.cs: Ignore self referencing #line directive
143 2009-11-26 Marek Safar <marek.safar@gmail.com>
145 A fix for bug #558292
146 * class.cs: Allow single unsafe fixed buffer fields.
148 2009-11-26 Marek Safar <marek.safar@gmail.com>
150 * expression: Optimize few more zero-based operations.
152 2009-11-26 Marek Safar <marek.safar@gmail.com>
154 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
155 avoids boxing of literal values.
157 2009-11-26 Marek Safar <marek.safar@gmail.com>
159 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
160 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
161 codegen.cs: LocatedToken redesing to avoid excessive allocation and
162 boxing (saves ~7MB for corlib). Also fixes presise token location.
164 2009-11-25 Marek Safar <marek.safar@gmail.com>
166 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
169 2009-11-24 Marek Safar <marek.safar@gmail.com>
171 * expression.cs: Lower static array initializer barrier.
173 * support.cs, driver.cs: Share reader buffer.
175 2009-11-23 Marek Safar <marek.safar@gmail.com>
177 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
179 2009-11-23 Marek Safar <marek.safar@gmail.com>
181 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
182 cleanup some obsolete code.
184 2009-11-20 Marek Safar <marek.safar@gmail.com>
186 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
189 2009-11-20 Marek Safar <marek.safar@gmail.com>
191 * *.cs: Resolved expressions are never resolved again, this helps to
192 uncover some not easy to find bugs and improve the performance.
194 2009-11-19 Marek Safar <marek.safar@gmail.com>
196 * *.cs: Made constant expressions fully compatible with any other
199 2009-11-19 Marek Safar <marek.safar@gmail.com>
201 * *.cs: DoResolve is a worker method and has to be protected.
203 2009-11-18 Marek Safar <marek.safar@gmail.com>
205 * *.cs: More context specific handling.
207 2009-11-17 Marek Safar <marek.safar@gmail.com>
209 * *.cs: More context specific handling.
211 2009-11-16 Marek Safar <marek.safar@gmail.com>
213 * dynamic.cs, class.cs: Removed few fixed user types conversions.
215 * symbolwriter.cs: Uses public ILOffset.
217 2009-11-13 Marek Safar <marek.safar@gmail.com>
219 A fix for bug #553650
220 * generic.cs: Another missing TypeToCoreType, still too many to fix.
222 2009-11-13 Marek Safar <marek.safar@gmail.com>
224 A fix for bug #555170
226 * class.cs, delegate.cs, enum.cs: Constants have to be available
227 for parameters resolve.
229 2009-11-12 Marek Safar <marek.safar@gmail.com>
231 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
234 2009-11-12 Marek Safar <marek.safar@gmail.com>
236 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
237 with a statically known candidate set.
239 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
241 * generic.cs: Made type inflation for generic constraint checks
242 recursive. This fixes BGO #553655.
244 2009-11-11 Marek Safar <marek.safar@gmail.com>
246 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
249 2009-11-10 Marek Safar <marek.safar@gmail.com>
251 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
252 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
253 attribute.cs: Add some dynamic error checking.
255 2009-11-07 Marek Safar <marek.safar@gmail.com>
257 A fix for bug #553465
259 * expression.cs: Fixed mixed version of expression tree anonymous
262 2009-11-06 Marek Safar <marek.safar@gmail.com>
264 A fix for bug #553031
266 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
267 expression tree version of anonymous type with members declaration.
269 2009-11-05 Marek Safar <marek.safar@gmail.com>
271 * parameter.cs: Handle nullable parameter default expression.
273 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
274 class.cs, attribute.cs: Check for wrong dynamic arguments.
276 2009-11-05 Marek Safar <marek.safar@gmail.com>
278 * statement.cs: Dynamic statements.
280 2009-11-04 Marek Safar <marek.safar@gmail.com>
282 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
283 Compound assignments over dynamic type.
285 2009-11-03 Marek Safar <marek.safar@gmail.com>
287 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
288 constructor arguments.
290 2009-10-30 Marek Safar <marek.safar@gmail.com>
292 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
293 codegen.cs: Unary mutator on dynamic member access expression.
295 2009-10-29 Marek Safar <marek.safar@gmail.com>
297 A fix for bug #550580
298 * convert.cs: Don't eliminate explicit precission casts.
300 2009-10-28 Marek Safar <marek.safar@gmail.com>
302 A fix for bug #550404
304 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
305 expression.cs, statement.cs, ecore.cs: Quote any nested expression
308 2009-10-27 Marek Safar <marek.safar@gmail.com>
310 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
313 * class.cs: Allow nullable binary user operators.
315 2009-10-26 Marek Safar <marek.safar@gmail.com>
317 * expression.cs: Move binary expression optimization at the end of
320 2009-10-23 Marek Safar <marek.safar@gmail.com>
322 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
323 Separate NullConstant from NullLiteral.
325 2009-10-23 Marek Safar <marek.safar@gmail.com>
327 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
328 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
329 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
330 ModuleContainer. Add common unclosed member check routine.
332 2009-10-22 Marek Safar <marek.safar@gmail.com>
334 * argument.cs: Use literal flag for real literals only.
336 * dynamic.cs: Use correct return type for custom delegates.
338 2009-10-22 Marek Safar <marek.safar@gmail.com>
340 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
343 2009-10-22 Marek Safar <marek.safar@gmail.com>
345 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
347 2009-10-21 Marek Safar <marek.safar@gmail.com>
349 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
352 2009-10-21 Marek Safar <marek.safar@gmail.com>
354 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
357 2009-10-20 Marek Safar <marek.safar@gmail.com>
359 * argument.cs, dynamic.cs, expression.cs: Latest API update.
361 2009-10-19 Marek Safar <marek.safar@gmail.com>
363 * typemanager.cs, expression.cs: Dynamic array initializer.
365 2009-10-16 Marek Safar <marek.safar@gmail.com>
367 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
370 2009-10-16 Marek Safar <marek.safar@gmail.com>
372 A fix for bug #493523, #507067
373 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
374 standard nullable conversion using underlying standard conversion
375 and not full conversion.
377 2009-10-15 Marek Safar <marek.safar@gmail.com>
379 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
380 type in VerifyArgumentsCompat.
382 2009-10-15 Marek Safar <marek.safar@gmail.com>
384 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
385 Reject variable used with type arguments.
387 2009-10-14 Marek Safar <marek.safar@gmail.com>
389 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
390 Implement dynamic expressions assignment.
392 2009-10-14 Marek Safar <marek.safar@gmail.com>
394 * expression.cs: Build underlying expression when resolving unary
397 2009-10-14 Marek Safar <marek.safar@gmail.com>
399 * expression.cs: Emit enum array initializer using binary blob.
401 2009-10-08 Marek Safar <marek.safar@gmail.com>
403 * typemanager.cs, constant.cs: Optimize decimal constants which fit
406 2009-10-07 Marek Safar <marek.safar@gmail.com>
408 * typemanager.cs: Reset object_type.
410 * assign: Made SimpleAssign public.
412 2009-10-06 Marek Safar <marek.safar@gmail.com>
414 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
415 invocation assembly to IsThisOrFriendAssembly.
417 2009-10-05 Marek Safar <marek.safar@gmail.com>
419 * expression.cs: Equality comparison of generic parameter with
422 2009-10-05 Marek Safar <marek.safar@gmail.com>
424 A fix for bug #543570
425 * generic.cs: Import predefined constraints correctly.
427 2009-10-02 Marek Safar <marek.safar@gmail.com>
429 * ecore.cs: Don't crash on overloads with optional paremeters where
430 arguments count overflows.
432 * parameter.cs: Import optional parameter constants using optional
435 2009-10-01 Marek Safar <marek.safar@gmail.com>
437 * Makefile: Default is gmcs compiler.
439 2009-10-01 Marek Safar <marek.safar@gmail.com>
441 * cs-parser.jay: Fixed few NRE.
443 2009-10-01 Marek Safar <marek.safar@gmail.com>
445 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
447 2009-09-30 Marek Safar <marek.safar@gmail.com>
449 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
450 ShimExpression, ImplicitCast.
452 2009-09-30 Marek Safar <marek.safar@gmail.com>
454 A fix for bug #542959
455 * delegate.cs: Emit correct delegate instance variable when there
456 are static and non-static overloads.
458 2009-09-29 Marek Safar <marek.safar@gmail.com>
460 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
461 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
463 2009-09-28 Marek Safar <marek.safar@gmail.com>
465 A fix for bug #542487
466 * ecore.cs: Resolve extension methods hidden by properties.
468 2009-09-25 Marek Safar <marek.safar@gmail.com>
470 * expression.cs, ecore.cs: More dynamic binary expressions.
472 2009-09-22 Marek Safar <marek.safar@gmail.com>
474 * nullable.cs, expression.cs: Fixed null lifted conversion for
475 bitwise enum operations.
477 2009-09-22 Marek Safar <marek.safar@gmail.com>
479 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
480 values in checked context.
482 2009-09-22 Marek Safar <marek.safar@gmail.com>
484 * expression.cs, ecore.cs: Fixed array index constant conversion.
486 2009-09-20 Miguel de Icaza <miguel@novell.com>
488 * expression.cs: Do not crash when MemberLookup returns something
489 that is not a MemberExpr here. Report error 582 instead.
493 2009-09-18 Marek Safar <marek.safar@gmail.com>
495 * decl.cs, class.cs: Check protected property accessors.
497 2009-09-18 Marek Safar <marek.safar@gmail.com>
499 * dynamic.cs, assign.cs: Dynamic compound assignment.
501 2009-09-17 Marek Safar <marek.safar@gmail.com>
503 * expression.cs: Fixed compound assignment explicit conversion.
505 2009-09-17 Marek Safar <marek.safar@gmail.com>
507 * expression.cs, ecore.cs: Cannot infer variables from method group.
509 2009-09-16 Marek Safar <marek.safar@gmail.com>
511 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
512 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
513 codegen.cs: Dynamic binary operations scaffolding.
515 2009-09-15 Marek Safar <marek.safar@gmail.com>
517 * expression.cs: Fixes nullable promotion for enum type variables.
519 2009-09-11 Marek Safar <marek.safar@gmail.com>
521 * driver.cs, dynamic.cs: Reset more static variables.
523 2009-09-11 Marek Safar <marek.safar@gmail.com>
525 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
526 driver.cs: Introduced Expression::MakeExpression.
528 2009-09-11 Marek Safar <marek.safar@gmail.com>
530 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
532 2009-09-09 Marek Safar <marek.safar@gmail.com>
534 * eval.cs, report.cs: Use Console.Out for all eval error or warning
537 2009-09-09 Marek Safar <marek.safar@gmail.com>
539 A fix for bug #518707
540 * expression.cs (Is): Optimize only generic parameter type
541 expression probing value type generic parameter.
543 2009-09-09 Marek Safar <marek.safar@gmail.com>
545 A fix for bug #532571
546 * ecore.cs: Check for simple name type arguments used with
549 2009-09-08 Marek Safar <marek.safar@gmail.com>
551 A fix for bug #497421
552 * generic.cs (CheckConstraint): Don't use buildin types to check for
553 parameterless constructor.
555 2009-09-08 Marek Safar <marek.safar@gmail.com>
557 A fix for bug #537402
558 * generic.cs (CheckConstraint): Correctly inflate generic type
559 arguments when checking generic method.
561 2009-09-08 Marek Safar <marek.safar@gmail.com>
563 A fix for bug #536463
564 * decl.cs (AddToContainer): Don't report collision between explicit
565 and parameterless non-explicit members.
567 2009-09-08 Marek Safar <marek.safar@gmail.com>
569 * eval.cs: Reset more static stuff.
571 2009-09-07 Marek Safar <marek.safar@gmail.com>
573 A fix for bug #324625
574 * expression.cs, ecore.cs: Create nested generic type expression
575 using declaring and not current type.
577 2009-09-07 Marek Safar <marek.safar@gmail.com>
579 * *.cs: Changed Report class to accept various output printers and
580 be an instance class. An expression resolver can now use different
581 message reporter for each call and Report.Error can safely throw
582 an exception. Part of ongoing work to turn mcs into proper library.
584 2009-09-04 Marek Safar <marek.safar@gmail.com>
586 * statement.cs, ecore.cs: Removed error reporting from emit code.
588 2009-09-04 Marek Safar <marek.safar@gmail.com>
590 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
592 2009-09-03 Marek Safar <marek.safar@gmail.com>
594 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
595 parser checks out of constructors.
597 2009-09-02 Marek Safar <marek.safar@gmail.com>
599 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
601 2009-09-02 Marek Safar <marek.safar@gmail.com>
603 A fix for bug #535448
604 * anonymous.cs, class.cs: Copy return label between all contexts.
606 2009-09-02 Marek Safar <marek.safar@gmail.com>
608 A fix for bug #535395
609 * namespace.cs: Resolve context can be null.
611 2009-08-25 Marek Safar <marek.safar@gmail.com>
613 A fix for bug #533912
614 * generic.cs: Use correct context for constraints resolving.
616 2009-08-25 Marek Safar <marek.safar@gmail.com>
618 A fix for bug #532630
619 * driver.cs: Trim conditional symbols.
621 2009-08-25 Marek Safar <marek.safar@gmail.com>
623 * context.cs: New file.
625 * *.exe.sources, *.csproj: Updated.
627 2009-08-25 Marek Safar <marek.safar@gmail.com>
629 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
630 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
631 IMembercontext, some small cleanups.
633 2009-08-24 Marek Safar <marek.safar@gmail.com>
635 * *.cs: Split ResolveContext and EmitContext.
637 2009-08-24 Marek Safar <marek.safar@gmail.com>
639 * *.cs: Only ResolveContext implements IMemberContext.
641 2009-08-21 Marek Safar <marek.safar@gmail.com>
643 * *.cs: Renamed IResolveContext to IMemberContext.
645 2009-08-21 Marek Safar <marek.safar@gmail.com>
647 * *.cs: Detached ResolveContext from EmitContext.
649 2009-08-21 Marek Safar <marek.safar@gmail.com>
651 * codegen.cs: Moved flow-analysis to BlockContext.
653 2009-08-21 Marek Safar <marek.safar@gmail.com>
655 * *.cs: Detached BlockContext from EmitContext.
657 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
659 * statement.cs: avoid nullref when the return value of GetEnumerator()
660 does not contain any MoveNext() method.
662 2009-08-19 Marek Safar <marek.safar@gmail.com>
664 * *.cs: Removed IResolveContext::GenericDeclContainer.
666 2009-08-19 Marek Safar <marek.safar@gmail.com>
668 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
670 2009-08-19 Marek Safar <marek.safar@gmail.com>
672 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
673 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
675 2009-08-18 Marek Safar <marek.safar@gmail.com>
677 * *.cs: Removed boolean fields from EmitContext.
679 2009-08-18 Marek Safar <marek.safar@gmail.com>
681 * *.cs: Add IResolveContext::IsStatic.
683 2009-08-18 Marek Safar <marek.safar@gmail.com>
685 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
687 2009-08-17 Marek Safar <marek.safar@gmail.com>
689 * *.cs: Removed DeclContainer from EmitContext.
691 2009-08-17 Marek Safar <marek.safar@gmail.com>
693 * *.cs: Add IResolveContext::CurrentTypeParameters.
695 2009-08-14 Marek Safar <marek.safar@gmail.com>
697 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
699 2009-08-14 Marek Safar <marek.safar@gmail.com>
701 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
702 codegen.cs: Add IResolveContext::LookupExtensionMethod.
704 2009-08-13 Marek Safar <marek.safar@gmail.com>
706 * decl.cs: Look in PartialContainer for parent type parameters.
708 2009-08-13 Marek Safar <marek.safar@gmail.com>
710 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
711 codegen.cs: Add IResolveContext::LookupTypeParameter.
713 2009-08-13 Marek Safar <marek.safar@gmail.com>
715 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
716 Moved resolved logic from Emit to Resolve.
718 2009-08-13 Marek Safar <marek.safar@gmail.com>
720 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
721 codegen.cs: Reworked atttributes handling of ResolveContext.
723 2009-08-12 Marek Safar <marek.safar@gmail.com>
725 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
726 LookupNamespaceOrType to ResolveContext.
728 2009-08-12 Marek Safar <marek.safar@gmail.com>
730 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
731 class.cs: Removed unused parameters and methods.
733 2009-08-11 Marek Safar <marek.safar@gmail.com>
735 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
736 codegen.cs: Finding the best common type of a set of expressions for
739 2009-08-07 Marek Safar <marek.safar@gmail.com>
741 * dynamic.cs, expression.cs: More dynamic conversions.
743 2009-08-06 Miguel de Icaza <miguel@novell.com>
745 * generic.cs: This loop was incorrect, it was increment ii, but
746 checking for `i'. This was a change introduced to fix #327497,
749 * class.cs: Catch another case for cs0533 error, fixes #324782.
751 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
753 * typemanager.cs (GetGenericArguments): SRE returns null for
754 generic methods on type builder instances if they are not generic
755 themselves. For example, for Foo<int>::Bar() it returns null, but
756 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
758 2009-08-05 Marek Safar <marek.safar@gmail.com>
760 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
761 delegate.cs: Work on dynamic binding.
763 2009-08-04 Marek Safar <marek.safar@gmail.com>
765 A second fix for bug #525342
766 * class.cs: Attach partial method attributes to method
769 2009-08-03 Marek Safar <marek.safar@gmail.com>
771 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
774 * rootcontext.cs: Default to langversion v4.
776 2009-08-03 Marek Safar <marek.safar@gmail.com>
778 * pending.cs: Check return type before member info is set.
780 2009-08-03 Marek Safar <marek.safar@gmail.com>
782 * anonymous.cs: Fully initialize generic hoisted field expression.
784 2009-08-02 Miguel de Icaza <miguel@novell.com>
786 * cs-parser.jay: Flag variables declared on the interactive shell
787 as used to prevent the 168 warning about local variable not being
790 2009-07-31 Marek Safar <marek.safar@gmail.com>
792 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
793 attribute.cs: Emit dynamic export attribute.
795 2009-07-30 Marek Safar <marek.safar@gmail.com>
797 * expression.cs: More verifier work.
799 2009-07-29 Marek Safar <marek.safar@gmail.com>
801 * nullable.cs: Fixed SRE crash during corlib compilation.
803 2009-07-29 Marek Safar <marek.safar@gmail.com>
805 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
806 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
807 More TypeManager.TypeToCoreType needed.
809 2009-07-29 Marek Safar <marek.safar@gmail.com>
811 * anonymous.cs: Update after recent SRE fixes.
813 2009-07-28 Marek Safar <marek.safar@gmail.com>
815 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
816 version of GetFieldHandle for fields of generic types.
818 2009-07-27 Marek Safar <marek.safar@gmail.com>
820 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
821 ecore.cs: Add TypeManager.IsDynamicType,
822 PredefinedAttributes.Dynamic.
824 2009-07-27 Marek Safar <marek.safar@gmail.com>
826 A fix for bug #415375
827 * expression.cs: Fixed object and reference type parameter
830 2009-07-27 Marek Safar <marek.safar@gmail.com>
832 A fix for bug #525342
833 * class.cs: Attach partial method attributes to method
836 2009-07-24 Marek Safar <marek.safar@gmail.com>
838 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
841 2009-07-24 Marek Safar <marek.safar@gmail.com>
843 * anonymous.cs (MutateField): Add imported types handling.
845 2009-07-23 Marek Safar <marek.safar@gmail.com>
847 * expression.cs, delegate.cs: Moved arguments resolve into their
848 counterparts expressions. Removed argument resolve from
849 CollectionElementInitializer.
851 2009-07-23 Marek Safar <marek.safar@gmail.com>
853 A fix for bug #523683
854 * convert.cs, delegate.cs: Use common overload mechanism for method
855 group conversion check.
857 2009-07-22 Marek Safar <marek.safar@gmail.com>
859 A fix for bug #523899
860 * generics.cs: Exact type inference with other bound types.
862 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
864 Don't complain when the same type is implemented by the output
865 assembly as well as multiple referenced assemblies
866 * namespace.cs (RootNamespace.LookupTypeReflection): Add
867 'must_be_unique' flag.
868 (GlobalRootNamespace): Update to changes.
869 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
870 already have a type in hand.
872 2009-07-22 Marek Safar <marek.safar@gmail.com>
874 * expression.cs: More verifier instrumentation.
876 * statement.cs: Do proper throw expression conversion.
878 2009-07-22 Marek Safar <marek.safar@gmail.com>
880 A fix for bug #522789
881 * expression.cs: Mutate invocation return type.
883 2009-07-16 Marek Safar <marek.safar@gmail.com>
885 * anonymous.cs: Split assignable and readonly generated variable
888 2009-07-16 Marek Safar <marek.safar@gmail.com>
890 A fix for bug #521671
891 * statement.cs: Fixed crash when checking missing type.
893 2009-07-16 Marek Safar <marek.safar@gmail.com>
895 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
896 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
897 class.cs, driver.cs: Work on dynamic binding.
899 * dynamic.cs: New file.
901 * *.sources, *.proj: Updated.
903 2009-07-15 Marek Safar <marek.safar@gmail.com>
905 * expression.cs (Conditional): Avoid double Resolve.
907 2009-07-13 Marcus Griep <marcus@griep.us>
909 * ecore.cs: Fix obscure bug with resolving members of interfaces
910 that hide parent interface members. Fixes bug #444388 and corrects
913 2009-07-13 Marek Safar <marek.safar@gmail.com>
915 * expression.cs (LocalVariableReference): Bounce resolve.
917 2009-07-10 Marek Safar <marek.safar@gmail.com>
919 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
920 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
923 * support.cs: New dynamic type wrapper.
925 2009-07-08 Marek Safar <marek.safar@gmail.com>
927 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
928 typed local variable.
930 2009-07-06 Marek Safar <marek.safar@gmail.com>
932 A fix for bug #519005
933 * anonymous.cs: Use null_type as no return type placeholder.
935 2009-07-02 Marek Safar <marek.safar@gmail.com>
937 * generic.cs: Handle type inference of identical type parameters
938 with different bounds.
940 2009-07-01 Marek Safar <marek.safar@gmail.com>
942 * expression.cs, class.cs: Events variance.
944 * cs-parser.jay: Interface events error messages.
946 2009-07-01 Marek Safar <marek.safar@gmail.com>
948 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
950 2009-06-29 Marek Safar <marek.safar@gmail.com>
952 * parameter.cs, convert.cs, expression.cs, class.cs: Default
953 parameter expression can be value-type New.
955 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
957 2009-06-26 Marek Safar <marek.safar@gmail.com>
959 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
960 Implemented C# 4.0 named arguments.
962 2009-06-24 Marek Safar <marek.safar@gmail.com>
964 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
965 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
966 parameter modifier. Also fixes bug #515497.
968 2009-06-24 Marek Safar <marek.safar@gmail.com>
970 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
971 arguments expression to be implemented.
973 *.sources: Add argument.cs
975 2009-06-23 Marek Safar <marek.safar@gmail.com>
977 * parameter.cs: Moved GetParameterIndexByName to base class.
979 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
980 unused AType. Use argument's version of GetExpressionTree.
982 2009-06-22 Marek Safar <marek.safar@gmail.com>
984 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
987 2009-06-17 Marek Safar <marek.safar@gmail.com>
989 A fix for bug #514096
990 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
992 2009-06-17 Marek Safar <marek.safar@gmail.com>
994 * expression.cs: The first multi-dimensional array nested array
995 initializers was not checked.
997 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
999 2009-06-17 Marek Safar <marek.safar@gmail.com>
1001 A fix for bug #513400
1002 * nullable.cs (EmitEquality): Operands emit could be simplified for
1003 built-in types when we now emit user operators differently.
1005 2009-06-16 Marek Safar <marek.safar@gmail.com>
1007 * ecore.cs: Report inaccessible delegate methods correctly.
1009 2009-06-16 Marek Safar <marek.safar@gmail.com>
1011 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1012 cs-parser.jay: Implemented C# 4.0 optional parameters.
1014 2009-06-16 Marek Safar <marek.safar@gmail.com>
1016 * driver.cs: Removed broken DefineManifestResource.
1018 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1020 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1021 Use $(BOOTSTRAP_PROFILE) instead.
1023 2009-06-12 Jb Evain <jbevain@novell.com>
1025 * rootcontext.cs: add a Platform field.
1026 * driver.cs: handle /platform.
1027 * codegen.cs: pass the proper flags according to
1028 the platform when saving the assembly.
1030 2009-06-11 Marek Safar <marek.safar@gmail.com>
1032 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1033 Add optional parameters grammar.
1035 2009-06-10 Marek Safar <marek.safar@gmail.com>
1037 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1038 driver.cs: Split lang version and metadata version.
1040 2009-06-10 Marek Safar <marek.safar@gmail.com>
1042 * decl.cs: Better overload ctor collision error message.
1044 2009-06-05 Jb Evain <jbevain@novell.com>
1046 * driver.cs (EmbededResource): avoid using an internal method
1047 in gmcs to embed manifest resources.
1049 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1051 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1052 the compiler from older mono versions (like moon's bots)
1054 2009-06-04 Marek Safar <marek.safar@gmail.com>
1056 * namespace.cs (LookupTypeReflection): Ignore collisions between
1059 2009-06-04 Marek Safar <marek.safar@gmail.com>
1061 * codegen.cs: Enabled generic type forwarders.
1063 2009-06-04 Marek Safar <marek.safar@gmail.com>
1065 * dmcs.*: Add another version of SRE compiler.
1067 2009-06-03 Marek Safar <marek.safar@gmail.com>
1069 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1070 generic-mcs.cs: Fixed variant type conversions.
1072 2009-06-02 Marek Safar <marek.safar@gmail.com>
1074 A fix for bug #507863
1075 * codegen.cs: Fixes a crash on invalid string value attribute.
1077 2009-06-01 Marek Safar <marek.safar@gmail.com>
1079 A fix for bug #508334
1080 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1081 cs-parser.jay: Fully import __arglist modifier.
1083 2009-05-29 Marek Safar <marek.safar@gmail.com>
1085 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1086 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1087 actually work with closed generic types.
1089 2009-05-27 Alan McGovern <amcgovern@novell.com>
1091 * class.cs, decl.cs, delegate.cs, parameter.cs:
1092 Fix the build by replacing the use of 'var' with the actual type.
1094 2009-05-27 Marek Safar <marek.safar@gmail.com>
1096 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1097 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1100 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1103 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1104 Marek Safar <marek.safar@gmail.com>
1106 A fix for bug #377509
1107 * parameter.cs: Use predefined and not empty name for implicit
1110 2009-05-21 Marek Safar <marek.safar@gmail.com>
1112 * class.cs: Don't report wrong warnings for event fields.
1114 2009-05-21 Marek Safar <marek.safar@gmail.com>
1116 A fix for bug #504667
1117 * class.cs: Check for static class using parent container instead of
1120 2009-05-08 Marek Safar <marek.safar@gmail.com>
1122 A fix for bug #496922
1123 * expression.cs: Always use temporary variable when using object
1126 2009-04-28 Marek Safar <marek.safar@gmail.com>
1128 A fix for bug #495112
1129 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1132 2009-04-27 Miguel de Icaza <miguel@novell.com>
1134 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1136 2009-04-24 Miguel de Icaza <miguel@novell.com>
1138 * complete.cs: No idea how gonzalo got a null in the list, but
1141 2009-04-24 Miguel de Icaza <miguel@novell.com>
1143 * complete.cs (CompletionElementInitializer): New completion class
1144 to support completing inside a C# 3 element initializer, so this
1145 allows completion for Silverlight situations where it is very
1148 new TextBlock () { Fo<TAB>
1150 (CompletionSimpleName): Expose the prefix that was
1151 passed to the simple name.
1153 * cs-parser.jay (object_or_collection_initializer): Add support
1154 for element_initializers.
1156 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1157 special case completion expressions as this method aggressively
1158 collects data before it operates, and errors were being thrown
1159 earlier than we were able to complete.
1161 2009-04-23 Miguel de Icaza <miguel@novell.com>
1163 * eval.cs: Make getcompletions silent and enable debugging output
1164 if the -v option is passed.
1166 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1167 Consider looking up the namespace that matches the prefix being
1170 This is part of the support for allowing completions like:
1171 `System.Co<TAB>' to complete to System.Console.
1173 * complete.cs (CompletionSimpleName.AppendResults): Make this
1176 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1178 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1179 COMPLETE_COMPLETION as internal.
1181 2009-04-17 Miguel de Icaza <miguel@novell.com>
1183 * complete.cs: Include namespace resolution in simple names as
1184 well as global types and types in the using scope in the
1187 * namespace.cs: Supporting infrastrcture to provide completions
1188 based on the current using scope.
1190 * eval.cs: Introduce an entry point that allows for initialization
1191 to return a list of the files passed on the command line.
1193 2009-04-14 Marek Safar <marek.safar@gmail.com>
1195 A fix for bug #494243
1196 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1198 2009-04-13 Marek Safar <marek.safar@gmail.com>
1200 A fix for bug #493887
1201 * statement.cs: Don't skip string multi-section with default or
1202 null label when populating string hashtable.
1204 2009-04-06 Marek Safar <marek.safar@gmail.com>
1206 A fix for bug #492329
1207 * expression.cs (New): Load variable when assigning type parameter
1210 2009-04-06 Marek Safar <marek.safar@gmail.com>
1212 A fix for bug #488960
1213 * decl.cs: Compare MVAR types using non-null values.
1215 2009-03-27 Marek Safar <marek.safar@gmail.com>
1217 * typemanager.cs, expression.cs: Removed unused nullable checks.
1219 2009-03-27 Marek Safar <marek.safar@gmail.com>
1221 * *.cs: Removed some gmcs conditionals.
1223 2009-03-26 Marek Safar <marek.safar@gmail.com>
1225 * generic.cs, support.cs: Moved generics stuff out of support.cs
1227 2009-03-24 Marek Safar <marek.safar@gmail.com>
1229 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1232 2009-03-23 Marek Safar <marek.safar@gmail.com>
1234 * attribute.cs: Consider all members for error reporting when
1235 checking named arguments.
1237 2009-03-23 Marek Safar <marek.safar@gmail.com>
1239 A fix for bug #487625
1240 * namespace.cs: Use a warning for all predefined type conflicts.
1242 2009-03-23 Marek Safar <marek.safar@gmail.com>
1244 A fix for bug #485706
1245 * statement.cs: Explicitly type catch type argument to pass verifier
1248 2009-03-22 Miguel de Icaza <miguel@novell.com>
1250 Initial support to provide code completion facilities to consumers
1251 of the evaluator API.
1253 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1254 support the completion engine. When we reach the end of the
1255 input stream instead of returning EOF, when this flag is true the
1256 tokenizer instead produces:
1258 One GENERATE_COMPLETION token: this token then must be
1259 handled in the grammar at every point where the user
1260 would likely request a completion.
1262 As many COMPLETE_COMPLETION tokens as necessary. These
1263 tokens are generated to assist the parser in unwinding and
1264 producing a valid parse tree.
1266 The parser rules do not have to be perfect, the parser needs to be
1267 augmented with judicious use of GENERATE_COMPLETION tokens to
1268 improve the areas where we can provide completion and the parser
1269 needs to add support for COMPLETE_COMPLETION tokens in productions
1272 It is common to not have enough support for COMPLETE_COMPLETION
1273 under certain rules and that even if we generated the
1274 GENERATE_COMPLETION token that the resulting tree will be invalid
1275 due to the missing rules that support COMPLETE_COMPLETION.
1277 The final EOF token is produced by having the parser notify the
1278 tokenizer when it reaches the root production that the next token
1281 * support.cs (CompletionResult): New Exception. This exception
1282 is thrown to return the completion results when one of the special
1283 completion expressions is reached.
1285 This exception is thrown by the completing ExpressionStatements
1286 classes that live in complete.cs
1288 * complete.cs (CompletingExpression): a new base class for
1289 completing expressions. This derives from the
1290 ExpressionStatement class and not from Expression as it allows
1291 completion to happen not only where expressions are expected in
1292 the grammar, but also where statements are expected.
1294 (CompletionSimpleName): A new class used to provide completions
1295 for SimpleNames. This currently only resolves to local
1296 variables from the evaluator context (GetVars call).
1298 (CompletionMemberAccess): Implements support for completing member
1301 * cs-parser.jay: Add support for completion in a few places.
1303 * eval.cs (GetCompletions): New public API for the evaluator that
1304 returns a list of possible completions given the input. The
1305 return value is an array of completions
1307 * anonymous.cs (Compatible): If the exception thrown from the
1308 resolved expression is a CompletionResult exception let that one
1309 through instead of printing a diagnostic error in the try/catch.
1311 2009-03-22 Miguel de Icaza <miguel@novell.com>
1315 * driver.cs (Main): Use Environment.Exit to quit quickly and
1316 prevent the compiler from doing the usual wait for helper thread
1319 This is to prevent a slowdown that was reported by Gonzalo on
1322 2009-03-19 Marek Safar <marek.safar@gmail.com>
1324 * ecore.cs: Load build-in types directly instead of accessing
1327 2009-03-18 Marek Safar <marek.safar@gmail.com>
1329 * ecore.cs: Always use unbox.any when available.
1331 2009-03-18 Marek Safar <marek.safar@gmail.com>
1333 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1335 2009-03-17 Marek Safar <marek.safar@gmail.com>
1337 * generic.cs: Removed obsolete version of type inference.
1339 2009-03-16 Marek Safar <marek.safar@gmail.com>
1341 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1342 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1343 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1344 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1346 2009-03-11 Marek Safar <marek.safar@gmail.com>
1348 A fix for bug #482996
1349 * anonymous.cs: Make sure we are not infering return type when
1350 checking type compatibility.
1352 2009-03-11 Marek Safar <marek.safar@gmail.com>
1354 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1355 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1356 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1357 attributes in their own structure. Needed when accessing their
1358 properties before they are resolved.
1360 2009-03-09 Marek Safar <marek.safar@gmail.com>
1362 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1363 hashtable (~10x faster).
1365 * driver.cs: Removed wrong Reset.
1367 2009-03-08 Marek Safar <marek.safar@gmail.com>
1369 * class.cs: Use correct common base type for unmanaged delayed
1372 * rootcontext.cs: Wrap unhandled exception.
1374 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1376 Make SeekableStreamReader self-tuning and arbitrarily seekable
1377 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1379 (SeekableStreamReader.Position.set): Use it. Simplify logic
1380 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1381 buffer size when the stream needs to be re-read from the beginning.
1383 2009-03-05 Marek Safar <marek.safar@gmail.com>
1385 A fix for bug #480100
1386 * parameter.cs: A parameter is not hoisted when used directly as ET.
1388 2009-03-04 Marek Safar <marek.safar@gmail.com>
1390 * statement.cs: Fixed an issue when using variable is of interface
1393 2009-03-03 Marek Safar <marek.safar@gmail.com>
1395 A fix for bug #480319
1396 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1398 2009-03-03 Marek Safar <marek.safar@gmail.com>
1400 A fix for bug #480867
1401 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1402 expression to have no valid type.
1404 2009-03-03 Marek Safar <marek.safar@gmail.com>
1406 A fix for bug #481258
1407 * class.cs: Set extension method flag in partial container.
1409 2009-03-03 Marek Safar <marek.safar@gmail.com>
1411 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1413 * attribute.cs: Add sanity check.
1415 2009-02-27 Marek Safar <marek.safar@gmail.com>
1417 * class.cs: Add external constructor error.
1419 2009-02-26 Marek Safar <marek.safar@gmail.com>
1421 A fix for bug #475354
1422 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1423 correctly user defined nullable equality operators.
1425 2009-02-25 Marek Safar <marek.safar@gmail.com>
1427 A fix for bug #479532
1428 * expression.cs: Implement NewInitialize::AddressOf.
1430 2009-02-25 Marek Safar <marek.safar@gmail.com>
1432 A fix for bug #413633
1433 * expression.cs: Iterate all base class-constraint types.
1435 2009-02-24 Marek Safar <marek.safar@gmail.com>
1437 A fix for bug #479209
1438 * literal.cs: Mutate null underlying type.
1440 2009-02-24 Marek Safar <marek.safar@gmail.com>
1442 A fix for bug #476295
1443 * convert.cs: Avoid wrapping implicitly convertible reference type.
1445 2009-02-23 Marek Safar <marek.safar@gmail.com>
1447 * iterators.cs: Create MemberName correctly.
1449 2009-02-23 Marek Safar <marek.safar@gmail.com>
1451 A fix for bug #478655
1452 * literal.cs: Check also underlying null type conversion.
1454 2009-02-21 Marek Safar <marek.safar@gmail.com>
1456 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1458 2009-02-20 Marek Safar <marek.safar@gmail.com>
1460 A fix for bug #477447
1461 * statement.cs: Add reference to correct parent storey when this
1462 is accessible from deep children storey (more than 1 level).
1464 2009-02-19 Marek Safar <marek.safar@gmail.com>
1466 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1467 * class.cs: Define base type members before setting up member cache.
1469 2009-02-18 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #477378
1472 * nullable.cs, expression.cs, statement.cs: More precise null type
1475 2009-02-18 Marek Safar <marek.safar@gmail.com>
1477 A fix for bug #472805
1478 * typemanager.cs, namespace.cs: Import only visible extension method
1481 2009-02-18 Marek Safar <marek.safar@gmail.com>
1483 A fix for bug #476895
1484 * attribute.cs: Use correct resolve context for attribute type.
1486 2009-02-18 Marek Safar <marek.safar@gmail.com>
1488 A fix for bug #476266
1489 * anonymous.cs: Mutate multi-dimensional arrays.
1491 2009-02-18 Marek Safar <marek.safar@gmail.com>
1493 A fix for bug #476400
1494 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1496 2009-02-18 Marek Safar <marek.safar@gmail.com>
1498 A fix for bug #476811
1499 * generics.cs: Fixed null-literal check.
1501 2009-02-17 Marek Safar <marek.safar@gmail.com>
1503 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1504 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1505 messing with static variables.
1507 2009-02-16 Marek Safar <marek.safar@gmail.com>
1509 A fix for bug #475965
1510 * generics.cs: Check generic parameter type after extracting from
1513 2009-02-16 Marek Safar <marek.safar@gmail.com>
1515 A fix for bug #475823
1516 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1519 2009-02-14 Marek Safar <marek.safar@gmail.com>
1521 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1522 Simplified event field definition using backing field and not
1523 field builder directly.
1525 * expression.cs (EmitLdArg): Optimize fast paths.
1527 2009-02-13 Marek Safar <marek.safar@gmail.com>
1529 A fix for bug #475327
1530 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1532 2009-02-13 Marek Safar <marek.safar@gmail.com>
1534 A fix for bug #475342
1535 * cs-parser.jay: Using 'super' instead of 'base' to call base
1536 constructor crashes compiler.
1538 2009-02-13 Marek Safar <marek.safar@gmail.com>
1540 A fix for bug #475354
1541 * expression.cs (Constantify): Add nullable types.
1543 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1545 2009-02-12 Marek Safar <marek.safar@gmail.com>
1547 A fix for bug #475246
1548 * expression.cs: More broken flowanalysis hacking needed.
1550 2009-02-12 Marek Safar <marek.safar@gmail.com>
1552 * attribute.cs: Compare only ref/out array modifiers.
1554 2009-02-11 Marek Safar <marek.safar@gmail.com>
1556 * statement.cs: Use member cache when looking for foreach members.
1558 2009-02-11 Marek Safar <marek.safar@gmail.com>
1560 * expression.cs: Don't expose internal initializer types.
1562 * statement.cs: Check also explicit conversions for goto case.
1564 2009-02-11 Marek Safar <marek.safar@gmail.com>
1566 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1568 2009-02-10 Marek Safar <marek.safar@gmail.com>
1570 * *.cs: Replace null-type with NullLiteral where appropriate.
1572 2009-02-09 Marek Safar <marek.safar@gmail.com>
1574 * expression.cs: Initializer of reference argument use temporary
1575 variable to be verifiable.
1577 * parameter.cs: Share EmitLdArg.
1579 2009-02-09 Marek Safar <marek.safar@gmail.com>
1581 A fix for bug #473559
1582 * class.cs: Fixed: Not reporting error about nested class with the
1585 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1587 Contributed under the MIT/X11 license.
1589 * generic.cs: Added VerifyVariantTypeParameters which performs new
1590 variance verification logic. The old logic, based on the spec, was
1591 wrong because the spec is full of LIES!
1593 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1595 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1598 * ecore.cs: Added calls to the new variance verification logic.
1601 * delegate.cs: Removed calls to the old variance verification logic.
1603 2009-02-06 Marek Safar <marek.safar@gmail.com>
1605 * delegate.cs: Use cached Invoke method directly.
1607 2009-02-06 Marek Safar <marek.safar@gmail.com>
1609 * expression.cs: Emit expression tree for hoisted variable access.
1611 2009-02-04 Marek Safar <marek.safar@gmail.com>
1613 * namespace.cs: Add better extension class check.
1615 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1617 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1619 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1621 This patch adds initial generic variance support to the compiler.
1622 It is contributed under the MIT/X11 license.
1624 * typemanager.cs: Modified ImplementsInterface to check variance.
1625 Added VerifyVariantTypeParameters which checks the specified type to see
1626 if it uses a variant type parameter as a type argument (which is not
1627 allowed). Added IsVariantOf which determins if the first type is a
1628 variant of the second. NOTE: This only supports reference types at
1629 the moment to conform with the current level of VM support. When the
1630 VM supports value types, this will follow step.
1632 * generic.cs: Added the Variance enum. Added a Variance property to
1633 TypeParameter and added variance support to definition phase. Added a
1634 Variance property to TypeParameterName. Also check to make sure that
1635 no variant types appear in generic method parameters.
1637 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1638 keywords if the langversion supports it.
1640 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1641 that variant types are only used in legal positions. Also added
1642 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1645 * decl.cs: Construct TypeParameter with the variance information.
1647 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1648 and ImplicitConversionStandard.
1650 * rootcontext.cs: Added new "Future" language version.
1652 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1653 type parameters are not used as type arguments in interface inheritance.
1654 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1655 parameters are not used as method return types. In MemberBase.
1656 ResolveMemberType, ensure that variant type parameters are not used
1657 as type arguments. Also call VerifyNoVariantTypeParameters on every
1658 set of parameters which are resolved.
1660 * delegate.cs: Modified Delegate.Define to ensure that variant
1661 parameters are not used as type arguments and that a contravariant
1662 parameter is not used as the return type. Also call
1663 VerifyNoVariantTypeParameters on the delegate parameters.
1665 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1666 to specify generic variance.
1668 * driver.cs: Added support for LanguageVersion.Future in the form of
1669 "-langversion:future".
1671 * generic-mcs.cs: Stubbed out new members in generic.cs.
1673 2009-02-03 Marek Safar <marek.safar@gmail.com>
1675 * class.cs, generic.cs: Emit type parameter constraints for nested
1678 2009-02-02 Marek Safar <marek.safar@gmail.com>
1680 A fix for bug #471213
1681 * class.cs: Avoid emitting backing field for abstract event fields.
1683 2009-02-01 Marek Safar <marek.safar@gmail.com>
1685 A fix for bug #359731
1686 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1689 2009-01-30 Marek Safar <marek.safar@gmail.com>
1691 A fix for bug #470767
1692 * statement.cs: Introduced BlockScopeExpression, needed when
1693 expression tree conversion has to emit scope variables.
1695 2009-01-29 Marek Safar <marek.safar@gmail.com>
1697 * class.cs: Remove duplicate CallingConvention.
1699 2009-01-29 Marek Safar <marek.safar@gmail.com>
1701 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1702 when I finally found the right naming convention.
1704 2009-01-29 Marek Safar <marek.safar@gmail.com>
1706 * cs-tokenizer.cs: Put back different open parens optimization.
1708 2009-01-28 Marek Safar <marek.safar@gmail.com>
1710 A fix for bug #470227
1711 * cs-tokenizer.cs: Remove too agressive parser optimization.
1713 2009-01-28 Marek Safar <marek.safar@gmail.com>
1715 A fix for bug #324319
1716 * class.cs: Remove too early base type resolve.
1718 2009-01-27 Marek Safar <marek.safar@gmail.com>
1720 A fix for bug #324319
1721 * ecore.cs: Explicitly type null when assigning to type argument to
1722 make pass verifier check.
1724 2009-01-27 Marek Safar <marek.safar@gmail.com>
1726 * anonymous.cs: Fixed recent regression when initializing captured
1729 2009-01-26 Marek Safar <marek.safar@gmail.com>
1731 A fix for bug #469019
1732 * anonymous.cs: Use all parent type parameters when instantiating
1733 nested generic storey.
1735 2009-01-26 Marek Safar <marek.safar@gmail.com>
1737 * expression.cs: Check for null instance methodgroup expression.
1739 2009-01-26 Marek Safar <marek.safar@gmail.com>
1741 A fix for bug #469244
1742 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1743 instance inside a conditional expression.
1745 2009-01-23 Marek Safar <marek.safar@gmail.com>
1747 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1748 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1749 GetElementType and HasElementType. IsValueType clean up.
1751 2009-01-23 Marek Safar <marek.safar@gmail.com>
1753 * nullable.cs: Use common EmitCall.
1755 * expression.cs: Emit constraint. for virtual calls only.
1757 2009-01-23 Marek Safar <marek.safar@gmail.com>
1759 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1760 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1761 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1764 2009-01-22 Jb Evain <jbevain@novell.com>
1766 * anonymous.cs: make anonymous types' ToString implementation
1767 match what csc outputs.
1769 2009-01-21 Marek Safar <marek.safar@gmail.com>
1771 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1774 2009-01-17 Marek Safar <marek.safar@gmail.com>
1776 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1779 2009-01-16 Marek Safar <marek.safar@gmail.com>
1781 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1784 2009-01-15 Marek Safar <marek.safar@gmail.com>
1786 A fix for bug #466634
1787 * statement.cs: Add reference for nested storey when only this
1790 2009-01-15 Marek Safar <marek.safar@gmail.com>
1792 A fix for bug #466474
1793 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1796 2009-01-15 Marek Safar <marek.safar@gmail.com>
1798 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1799 Fixed nested stories parent referencing process. Also fixes #463985.
1801 2009-01-06 Marek Safar <marek.safar@gmail.com>
1803 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1804 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1805 implementation. Also fixes #463108.
1807 2009-01-05 Marek Safar <marek.safar@gmail.com>
1809 A fix for bug #416109
1810 * decl.cs: Issue correct CLSAttribute warning location.
1812 2009-01-05 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #456775
1815 * attribute.cs: Use attribute owner scope when resolving attribute
1818 2009-01-05 Marek Safar <marek.safar@gmail.com>
1820 A fix for bug #457257
1821 * decl.cs: Fixed incorrect member declaring type comparison.
1823 2009-01-05 Marek Safar <marek.safar@gmail.com>
1825 A fix for bug #460896
1826 * driver.cs: Handle /RES resources as embeddable.
1828 2009-01-05 Marek Safar <marek.safar@gmail.com>
1830 A fix for bug #462515
1831 * ecore.cs: Report inacessible members upwards.
1833 2009-01-05 Marek Safar <marek.safar@gmail.com>
1835 A fix for bug #463190, #463192
1836 * decl.cs, namespace.cs: Also import internal extension classes.
1838 2009-01-04 Marek Safar <marek.safar@gmail.com>
1840 A fix for bug #463415
1841 * generic.cs: Use right index for RemoveDependentTypes.
1843 2009-01-02 Marek Safar <marek.safar@gmail.com>
1845 A fix for bug #463196
1846 * expression.cs: Fixed enum to null comparison.
1848 2009-01-02 Marek Safar <marek.safar@gmail.com>
1850 A fix for bug #463121
1851 * nullable.cs: Fixed nullable user equality operator comparison.
1853 2009-01-02 Marek Safar <marek.safar@gmail.com>
1855 A fix for bug #462950
1856 * class.cs, decl.cs: Use full explicit name when defining automatic
1857 property backing field.
1859 2009-01-02 Marek Safar <marek.safar@gmail.com>
1861 A fix for bug #462592
1862 * pending.cs: Emit type arguments for generic proxy method.
1864 2008-12-30 Marek Safar <marek.safar@gmail.com>
1866 * expression.cs (As): Mutate all type arguments.
1868 2008-12-29 Marek Safar <marek.safar@gmail.com>
1870 A fix for bug #462622
1871 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1874 2008-12-29 Marek Safar <marek.safar@gmail.com>
1876 A fix for bug #450782
1877 * ecore.cs: Consider more variables of form V.I to be fixed.
1879 2008-12-29 Marek Safar <marek.safar@gmail.com>
1881 A fix for bug #460712
1882 * typemanager.cs: Core types could be imported.
1884 2008-12-28 Marek Safar <marek.safar@gmail.com>
1886 A fix for bugs #460847, #460772, #458049, #457339, #447807
1887 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1888 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1889 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1890 user lambdas used inside query clauses.
1892 2008-12-18 Marek Safar <marek.safar@gmail.com>
1894 A fix for bug #460229
1895 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1897 2008-12-18 Marek Safar <marek.safar@gmail.com>
1899 A fix for bug #459952
1900 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1902 2008-12-18 Marek Safar <marek.safar@gmail.com>
1904 A fix for bug #459630
1905 * convert.cs: Enum to valuetype conversion is not allowed.
1907 2008-12-18 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #457087
1910 * generic.cs: Don't crash when constraint comes from type
1913 2008-12-16 Marek Safar <marek.safar@gmail.com>
1915 A fix for bug #459221
1916 * anonymous.cs, statement.cs: Delay only captured this
1919 2008-12-12 Marek Safar <marek.safar@gmail.com>
1921 A fix for bug #457489
1922 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1923 and initialization to capture scope initializers correctly.
1925 2008-12-11 Marek Safar <marek.safar@gmail.com>
1927 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1928 ParameterReference refactoring.
1930 2008-12-03 Marek Safar <marek.safar@gmail.com>
1932 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1933 to be imported from any assembly.
1935 2008-12-03 Marek Safar <marek.safar@gmail.com>
1937 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1938 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1939 from anonymous method and lambda expression.
1941 2008-12-01 Marek Safar <marek.safar@gmail.com>
1943 A fix for bug #448560
1944 * expression.cs (As): Box any generic type arguments to be
1947 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1949 Add tripwire for implicit conversion bugs
1950 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1952 (MethodGroupExpr.OverloadResolve): Add sanity check between
1953 IsApplicable and VerifyArgumentsCompat.
1954 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1956 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1958 Fix build break in System.Data_test
1959 * convert.cs (ImplicitConversionExists): Move NullLiteral
1961 (ImplicitStandardConversionExists): ... here.
1963 2008-11-28 Marek Safar <marek.safar@gmail.com>
1965 * literal.cs: Emit correctly explicit null to nullable cast.
1967 2008-11-28 Marek Safar <marek.safar@gmail.com>
1969 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1972 2008-11-28 Marek Safar <marek.safar@gmail.com>
1974 A fix for bug #449005
1975 * convert.cs, nullable.cs: Use only one implicit nullable
1978 2008-11-27 Marek Safar <marek.safar@gmail.com>
1980 * convert.cs, literal.cs: More Convert cleanup is needed.
1982 2008-11-27 Marek Safar <marek.safar@gmail.com>
1984 * decl.cs, class.cs: Fixed misleading error message.
1986 2008-11-26 Marek Safar <marek.safar@gmail.com>
1988 A fix for bug #449005
1989 * nullable.cs (EmitEquality): Disable optimization for user operator
1992 2008-11-25 Marek Safar <marek.safar@gmail.com>
1994 A fix for bug #447027
1995 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1996 with context variables stored as expression instances.
1998 2008-11-25 Marek Safar <marek.safar@gmail.com>
2000 A fix for bug #447027
2001 * delegate.cs: Fixed delegate VerifyMethod logic.
2003 2008-11-24 Marek Safar <marek.safar@gmail.com>
2005 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2008 2008-11-21 Marek Safar <marek.safar@gmail.com>
2010 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2011 member type resolve to follow normal flow, instead of random
2014 2008-11-21 Marek Safar <marek.safar@gmail.com>
2016 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2019 2008-11-21 Marek Safar <marek.safar@gmail.com>
2021 * const.cs: Emit decimal array constant as literal.
2023 2008-11-20 Marek Safar <marek.safar@gmail.com>
2025 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2027 2008-11-19 Marek Safar <marek.safar@gmail.com>
2029 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2030 into real property (saves 8 MB for corlib compilation).
2032 2008-11-19 Marek Safar <marek.safar@gmail.com>
2034 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2035 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2036 generic-mcs.cs: Small cleanup of TypeArguments.
2038 2008-11-18 Marek Safar <marek.safar@gmail.com>
2040 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2041 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2042 of ConstructedType expression, renamed to GenericTypeExpr.
2044 2008-11-17 Marek Safar <marek.safar@gmail.com>
2046 A fix for bug #445303
2047 * location.cs (IsConditionalDefined): Handle undefined global
2050 2008-11-17 Marek Safar <marek.safar@gmail.com>
2052 A fix for bug #444678
2053 * expression.cs (TryReduceConstant): Always create new constant
2056 2008-11-17 Marek Safar <marek.safar@gmail.com>
2058 A fix for bug #444673
2059 * ecore.cs: Ignore open generic types when used as generic type
2062 2008-11-17 Marek Safar <marek.safar@gmail.com>
2064 A fix for bug #445458
2065 * expression.cs, cs-parser.jay: Don't crash when an expression
2068 2008-11-17 Marek Safar <marek.safar@gmail.com>
2070 A fix for bug #445464
2071 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2072 inside unbound type.
2074 2008-11-14 Jb Evain <jbevain@novell.com>
2076 * driver.cs: ignore empty -nowarn argument such as
2077 the one in -nowarn:12,13,,.
2079 2008-11-13 Marek Safar <marek.safar@gmail.com>
2081 A fix for bug #444271
2082 * anonymous.cs: Rescan parent storeys when best candidate was
2085 2008-11-13 Marek Safar <marek.safar@gmail.com>
2087 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2088 useless UnboundTypeExpression.
2090 * attribute.cs: Do check obsolete attribute on generic types.
2092 2008-11-12 Marek Safar <marek.safar@gmail.com>
2094 A fix for bugs #425680, #400139
2095 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2098 2008-11-11 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #435747
2101 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2102 compound value types assignment. Few micro optimizations added.
2104 2008-11-10 Marek Safar <marek.safar@gmail.com>
2106 A fix for bug #442610
2107 * anonymous.cs (MutateConstructor): More SRE hacking.
2109 2008-11-10 Marek Safar <marek.safar@gmail.com>
2111 A fix for bug #442579
2112 * ecore.cs: Also initialize expanded form of a method with 1 params
2115 2008-11-06 Marek Safar <marek.safar@gmail.com>
2117 * expression.cs (UnaryMutator): Do early l-side check.
2119 2008-11-05 Miguel de Icaza <miguel@novell.com>
2121 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2122 Init, otherwise we would crash later on when checking for friend
2125 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2126 Otherwise we never get any meaningful information as to what
2129 2008-11-05 Marek Safar <marek.safar@gmail.com>
2131 A fix for bug #436318
2132 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2134 2008-11-05 Miguel de Icaza <miguel@novell.com>
2136 * namespace.cs: Turns out that it was a really bad idea to hide
2137 the errors for namespaces not found here in eval mode.
2139 * eval.cs: When we process using clauses, only enter those into
2140 the list of valid using clauses after they have been validated.
2142 The above change gives the proper semantics: it does not
2143 senselessly report the same errors with broken using statements by
2144 never storing them in the first place when they are invalid.
2146 2008-11-05 Marek Safar <marek.safar@gmail.com>
2148 A fix for bug #421839
2149 * cs-parser.jay: Remove expression from coalesce rule to force lower
2150 priority than the assignment operator.
2152 2008-11-05 Marek Safar <marek.safar@gmail.com>
2154 A fix for bug #437875
2155 * nullable.cs: Compile correctly method group operand used with null
2156 coalescing operator.
2158 2008-11-04 Marek Safar <marek.safar@gmail.com>
2160 A fix for bug #434589
2161 * expression.cs (Binary): Ignore lifted conversions when at least
2162 one operand is of reference type.
2164 2008-11-04 Marek Safar <marek.safar@gmail.com>
2166 * cs-parser.jay: Better syntax error report.
2168 2008-11-03 Marek Safar <marek.safar@gmail.com>
2170 A fix for bug #436792
2171 * cs-parser.jay: Use GetLocation to access location.
2173 2008-11-03 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #440774
2176 * cs-parser.jay: Also set current_array_type when parsing local
2179 2008-11-03 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #440785
2182 * expression.cs (As): Don't resolve self modifing expression
2185 2008-11-03 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #439447
2188 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2190 2008-11-03 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #437571
2193 * cs-parser.jay: Fixes internal error for invalid expression
2196 2008-10-17 Marek Safar <marek.safar@gmail.com>
2198 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2200 2008-10-17 Marek Safar <marek.safar@gmail.com>
2202 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2204 2008-10-17 Marek Safar <marek.safar@gmail.com>
2206 * cs-tokenizer.cs: More precise cast parsing.
2208 2008-10-16 Martin Baulig <martin@ximian.com>
2210 * anonymous.cs (AnonymousMethodStorey): Put back the
2211 `hoisted_locals' hashtable and use it in EmitType().
2213 2008-10-15 Marek Safar <marek.safar@gmail.com>
2215 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2216 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2219 2008-10-14 Marek Safar <marek.safar@gmail.com>
2221 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2223 2008-10-14 Marek Safar <marek.safar@gmail.com>
2225 * statement.cs: Mutate scope initializers.
2227 2008-10-14 Marek Safar <marek.safar@gmail.com>
2229 * expression.cs: Use typeless value for This constant.
2231 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2233 2008-10-14 Marek Safar <marek.safar@gmail.com>
2235 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2238 2008-10-13 Marek Safar <marek.safar@gmail.com>
2240 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2243 2008-10-13 Marek Safar <marek.safar@gmail.com>
2245 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2246 parser and tokenizer. Fixes many ambiguities including #433258.
2248 2008-10-10 Marek Safar <marek.safar@gmail.com>
2250 * cs-parser.jay: Fixed missing accessor recovery.
2252 2008-10-10 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #433701
2255 * expression.cs: Better error message.
2257 2008-10-10 Marek Safar <marek.safar@gmail.com>
2259 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2261 * Makefile: Disabled unused debug symbols.
2263 Also fixes: #320556, #321097, #321656, #321876, #351316
2265 2008-10-09 Miguel de Icaza <miguel@novell.com>
2267 * eval.cs: rename "<interactive>" to "{interactive}", to work
2268 around a requirement in the compiler that this be a valid
2269 filename, and in Windows it is not (433886).
2271 2008-10-09 Marek Safar <marek.safar@gmail.com>
2273 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2275 2008-10-08 Marek Safar <marek.safar@gmail.com>
2277 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2278 cs-parser.jay: Generic type declaration and type arguments cleanup.
2280 2008-10-05 Marek Safar <marek.safar@gmail.com>
2282 * cs-parser.jay: Allow parsing weird array creation construct.
2284 2008-10-05 Marek Safar <marek.safar@gmail.com>
2286 * cs-parser.jay: Conflicts reduction.
2288 2008-10-04 Marek Safar <marek.safar@gmail.com>
2290 * cs-parser.jay: Conflicts reduction.
2292 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2295 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2296 property. Add a 'count' hint about the use of the shared vector.
2297 Ensure that we don't leak out dirty bits.
2298 (UsageVector.MergeChild): Throw away information about variables
2300 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2302 2008-10-03 Marek Safar <marek.safar@gmail.com>
2304 A fix for bug #431746
2305 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2306 parameters when iterator is created.
2308 2008-10-03 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #431827
2311 * expression.cs: Fixed right based pointer arithmetic operations
2314 2008-10-03 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #353779
2317 * assign.cs, expression.cs: Fixed compound assignment conversions.
2319 2008-10-02 Marek Safar <marek.safar@gmail.com>
2321 A fix for bug #375262
2322 * statement.cs: Refactor ArrayForeach to be usable with string
2323 indexer. Optimized single dimentional arrays foreach.
2325 2008-10-02 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #431255
2328 * anonymous.cs, expression.cs: Removed broken optimization.
2330 2008-10-01 Marek Safar <marek.safar@gmail.com>
2332 * anonymous.cs: Use full type parameters of parent generic
2333 containers. Removed unnecessary AddParentStoreyReference call.
2335 2008-10-01 Marek Safar <marek.safar@gmail.com>
2337 A fix for bug #324702
2338 * class.cs: Use better shorter names for explicit interface member
2341 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2343 2008-10-01 Marek Safar <marek.safar@gmail.com>
2345 * expression.cs: Use new interface to check fixed expression.
2347 2008-10-01 Marek Safar <marek.safar@gmail.com>
2349 A fix for bug #421101
2350 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2351 interface to check for fixed fixed-buffers.
2353 2008-10-01 Marek Safar <marek.safar@gmail.com>
2355 A fix for bug #429264
2356 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2358 * delegate.cs: Removed unnecessary casts.
2360 2008-09-30 Marek Safar <marek.safar@gmail.com>
2362 A fix for bug #352151
2363 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2364 class.cs: Fixed already defined explicit interface members check.
2366 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2368 cs-tokenizer.cs: Fix typo.
2370 2008-09-28 Miguel de Icaza <miguel@novell.com>
2372 * eval.cs (InteractiveBase): The quit command now just sets a
2373 flag, instead of calling Environment.Exit(), it is milder on
2376 CompiledMethod is now in Mono.CSharp, not nested inside
2377 the Evaluator, it was inconvenient to use.
2379 2008-09-27 Miguel de Icaza <miguel@novell.com>
2381 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2382 code to be invoked without having to reparse.
2384 2008-09-27 Miguel de Icaza <miguel@novell.com>
2386 * ecore.cs: The recent changes to FieldExpr broke this as well.
2387 Fixes LINQ queries in the interactive shell.
2389 * Multiple files: indentation fixing for the Mono coding
2390 guidelines for the switch statement.
2392 * eval.cs: Make the Evaluator API thread safe.
2394 2008-09-26 Marek Safar <marek.safar@gmail.com>
2396 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2397 constructor parsing.
2399 2008-09-26 Marek Safar <marek.safar@gmail.com>
2401 A fix for bug #325326
2402 * statement.cs: Check possible mistaken empty statement using
2403 explicit blocks only.
2405 2008-09-25 Miguel de Icaza <miguel@novell.com>
2407 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2408 RootNamespace.ComputeNamespaces to update the internal list of
2409 namespaces, this is no longer done for us.
2411 (InteractiveBase): Use the Evaluator APIs instead of calling into
2414 2008-09-25 Marek Safar <marek.safar@gmail.com>
2416 A fix for bug #429264
2417 * expression.cs: Missing mutator for access to multidimensional
2420 2008-09-25 Marek Safar <marek.safar@gmail.com>
2422 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2425 * driver.cs: Missing input argument check.
2427 2008-09-25 Marek Safar <marek.safar@gmail.com>
2429 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2430 expression.cs, statement.cs, rootcontext.cs, class.cs,
2431 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2434 2008-09-24 Miguel de Icaza <miguel@novell.com>
2436 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2437 fully constructed FieldExpr, fixes the regression introduced in
2440 * ecore.cs, expression.cs: Plug back the eclass initialization as
2441 otherwise it regresses `csharp'.
2443 2008-09-24 Marek Safar <marek.safar@gmail.com>
2445 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2446 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2447 phase to resolve phase. It resolves problems with expression trees
2448 and fixes bugs #323796, #325156.
2450 2008-09-23 Marek Safar <marek.safar@gmail.com>
2452 * codegen.cs: Report better error when symbol writer is missing.
2454 2008-09-23 Marek Safar <marek.safar@gmail.com>
2456 * codegen.cs: Set .NET symbol writer.
2458 * decl.cs: Guard against null generic arguments.
2460 * report.cs: Don't report exactly same additional details.
2462 2008-09-22 Marek Safar <marek.safar@gmail.com>
2464 A fix for bug #324917
2465 * cs-parser.jay: Add missing multidimensional non-expression type
2468 2008-09-22 Marek Safar <marek.safar@gmail.com>
2470 A fix for bug #428191
2471 * anonymous.cs: Create an outer generic fields also for non-storey
2474 2008-09-22 Marek Safar <marek.safar@gmail.com>
2476 A fix for bug #378294
2477 * class.cs: Make fixed size buffers gmcs feature only.
2479 2008-09-22 Marek Safar <marek.safar@gmail.com>
2481 A fix for bug #355622, #324993
2482 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2485 2008-09-19 Marek Safar <marek.safar@gmail.com>
2487 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2490 2008-09-19 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #416110
2493 * generic.cs: Struct constraint results in default ctor and
2494 ValueType base type constraint to be set.
2496 2008-09-19 Marek Safar <marek.safar@gmail.com>
2498 A fix for bug #423791
2499 * generic.cs: Fixed params output type type-inference.
2501 2008-09-19 Marek Safar <marek.safar@gmail.com>
2503 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2505 2008-09-19 Marek Safar <marek.safar@gmail.com>
2507 * cs-tokenizer.cs: Don't break on extra partial modifier.
2509 2008-09-19 Marek Safar <marek.safar@gmail.com>
2511 A fix for bug #427592
2512 * generic.cs: Use common parameter resolve method.
2514 2008-09-18 Marek Safar <marek.safar@gmail.com>
2516 A fix for bug #414758
2517 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2520 2008-09-18 Marek Safar <marek.safar@gmail.com>
2522 * driver.cs, namespace.cs: Read types and namespaces after all
2523 requested assemblies are loaded, fixes issues with System.Core
2524 auto-reference, and #419888.
2526 2008-09-18 Marek Safar <marek.safar@gmail.com>
2528 A fix for bug #417705
2529 * cs-parser.jay: Fixed as/is operator expression split.
2531 2008-09-18 Marek Safar <marek.safar@gmail.com>
2533 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2534 Fixed expression tree representation of empty new expression and
2535 new initializer expression.
2537 2008-09-18 Miguel de Icaza <miguel@novell.com>
2539 * eval.cs: Remove warning, keep reference to driver around.
2541 * Hide fields that do not need to be public.
2543 2008-09-17 Marek Safar <marek.safar@gmail.com>
2545 A fix for bug #426385
2546 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2547 conversion for array elements.
2549 2008-09-17 Marek Safar <marek.safar@gmail.com>
2551 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2552 void parsing conflicts.
2554 2008-09-15 Marek Safar <marek.safar@gmail.com>
2556 A fix for bug #425601
2557 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2558 System.Core only when there is no custom ExtensionAttribute
2561 2008-09-15 Miguel de Icaza <miguel@novell.com>
2563 * namespace.cs: Do not report CS0246 (name
2565 2008-09-12 Marek Safar <marek.safar@gmail.com>
2567 A fix for bug #425669
2568 * generic.cs: Don't cache generic static anonymous method
2571 2008-09-12 Marek Safar <marek.safar@gmail.com>
2573 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2574 conflicting constraints.
2576 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2578 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2581 2008-09-12 Marek Safar <marek.safar@gmail.com>
2583 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2584 to null pointer conversion fixes.
2586 2008-09-11 Marek Safar <marek.safar@gmail.com>
2588 * cs-parser.jay, expression.cs: An implicitly typed local variable
2589 declarator cannot use an array initializer.
2591 2008-09-11 Marek Safar <marek.safar@gmail.com>
2593 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2595 2008-09-11 Marek Safar <marek.safar@gmail.com>
2597 * generic.cs (InflatedConstraints): Don't crash when constraints
2600 * cs-parser.jay: const_declarator is a block.
2602 * constant.cs: Check for not allowed NaN conversions.
2604 2008-09-10 Miguel de Icaza <miguel@novell.com>
2606 * driver.cs: Drop --shell argument, the compiler is no longer a
2609 * eval.cs: Move most of the code that deals with evaluation into
2610 this file and document the public API from repl.cs
2612 * repl.cs: Remove from here.
2614 2008-09-10 Marek Safar <marek.safar@gmail.com>
2616 A fix for bug #424684
2617 * generic.cs: Generic class constraints must come first.
2619 2008-09-09 Miguel de Icaza <miguel@novell.com>
2621 * cs-parser.jay: Improve error reporting for syntax errors in
2622 statements and expressions, we now report the expected tokens
2623 instead of reporting the useless "; expected".
2625 Drop the strings from the token declaration, it turns out that
2626 they did not do what I thought they did. Instead they were adding
2627 two sets of tokens to the tables.
2629 2008-09-09 Marek Safar <marek.safar@gmail.com>
2631 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2632 delegate.cs: Share special type check.
2634 2008-09-09 Marek Safar <marek.safar@gmail.com>
2636 A fix for bug #423981
2637 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2639 2008-09-09 Marek Safar <marek.safar@gmail.com>
2641 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2644 2008-09-09 Marek Safar <marek.safar@gmail.com>
2646 A fix for bugs: #324750, #335946
2647 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2648 lookup rule to determine ?-based tokens.
2650 2008-09-08 Miguel de Icaza <miguel@novell.com>
2652 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2653 expressions (like event adding or removing) end up here, so we
2654 need to treat those as statements.
2656 Add LoadAssembly method.
2658 2008-09-04 Miguel de Icaza <miguel@novell.com>
2660 * repl.cs: Add Time method.
2662 2008-09-05 Marek Safar <marek.safar@gmail.com>
2664 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2666 2008-09-05 Miguel de Icaza <miguel@novell.com>
2668 * repl.cs: Add workaround for old compilers.
2670 2008-09-04 Jb Evain <jbevain@novell.com>
2672 * repl.cs (PrettyPrint): pretty print everything that
2673 implements IDictionary, as well as IEnumerables. Also,
2674 add a quit helper property.
2676 2008-09-04 Marek Safar <marek.safar@gmail.com>
2678 * constant.cs: Better error reporting for decimal literals.
2680 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2683 2008-09-04 Marek Safar <marek.safar@gmail.com>
2684 Miguel de Icaza <miguel@novell.com>
2686 A fix for bug #422951
2687 * assign.cs (Assign.DoResolve): Perform the type conversions
2688 checks before we attempt to initialize `New' initializers.
2690 2008-09-04 Marek Safar <marek.safar@gmail.com>
2692 A fix for bug #422853
2693 * delegate.cs (DelegateCreation): Add special handling for
2694 EmptyExpression.Null instance expression which is just another
2695 hack for undecided member instance exression.
2697 2008-09-04 Marek Safar <marek.safar@gmail.com>
2699 * expression.cs, ecore.cs: Emit full expression tree for reduced
2702 2008-09-04 Marek Safar <marek.safar@gmail.com>
2704 * expression.cs (This): Guard against multi-resolving.
2706 * ecore.cs, statement.cs (Throw): Simplified.
2708 * flowanalysis.cs: Also verify event fields.
2710 2008-09-04 Miguel de Icaza <miguel@novell.com>
2712 * assign.cs (Assign.DoResolve): Perform the type conversions
2713 checks before we attempt to initialize `New' initializers.
2715 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2717 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2720 * repl.cs: Update help.
2722 2008-09-03 Miguel de Icaza <miguel@novell.com>
2724 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2725 handling of the default config handling, including the special
2726 treatment of System.Core assembly.
2728 Fixes the REPL processing for LINQ.
2730 2008-09-03 Marek Safar <marek.safar@gmail.com>
2732 A fix for bug #422507
2733 * expression.cs (UnboxCast): Add missing child expression mutator.
2735 2008-09-03 Marek Safar <marek.safar@gmail.com>
2737 * driver.cs: Don't self reference System.Core assembly.
2739 2008-09-03 Marek Safar <marek.safar@gmail.com>
2741 A fix for bug #422507
2742 * expression.cs (StringConcat): Add missing type mutator.
2744 2008-09-03 Marek Safar <marek.safar@gmail.com>
2746 * generic.cs (TypeInferenceContext): Follow equality rule for
2747 constructed type lower bound type inference.
2749 2008-09-02 Miguel de Icaza <miguel@novell.com>
2751 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2752 <dblank@cs.brynmawr.edu> which updates the cursor position on
2755 2008-09-02 Marek Safar <marek.safar@gmail.com>
2757 A fix for bug #367145
2758 * driver.cs: Fixed import of extension methods when using -noconfig
2761 2008-09-02 Marek Safar <marek.safar@gmail.com>
2763 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2764 version from non-generic implementation instead.
2766 2008-09-01 Marek Safar <marek.safar@gmail.com>
2768 A fix for bug #418908
2769 * class.cs: Use AddScopeStatement for field initializers.
2771 2008-09-01 Marek Safar <marek.safar@gmail.com>
2773 A fix for bug #415385
2774 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2776 2008-09-01 Marek Safar <marek.safar@gmail.com>
2778 A fix for bug #421736
2779 * iterators.cs: Don't crash on unreachable iterators.
2781 2008-09-01 Marek Safar <marek.safar@gmail.com>
2783 A fix for bug #421628
2784 * parameter.cs, attribute.cs: Clone also parameter attributes.
2786 2008-08-30 Miguel de Icaza <miguel@novell.com>
2788 * namespace.cs (LookupType): In EvalMode, try to replace
2789 the TypeBuilder from our cache with a Type as Reflection.Emit does
2790 not like to mix code from older assemblies emitted and new
2793 This sounds like a serious Mono bug that prevents multiple
2794 assemblies to be generated and consumed at the same time.
2796 * cs-parser.jay (push_current_class): Do not make interactive
2797 classes internal or private, make them public as we currently
2798 generate each new class in a new assembly.
2800 2008-08-29 Miguel de Icaza <miguel@novell.com>
2802 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2803 remove types that are entered into the global namespace during
2804 parsing so that we can remove them on failure.
2806 * cs-parser.jay: Parsing: we now keep track of types that are
2807 entered into global variables and queue those in case the parsing
2810 This happens in a few situations: during partial-input, we invoke
2811 the parser repeatedly for example with the string "class X", this
2812 would cause X to be registed, and we need to remove this
2813 registration so that another parse attempt later with say "class X {"
2814 would actually work.
2816 Additionally, if there is an error in the resolution phase, for
2817 example: "class X : NonExistant {}" th
2819 * cs-parser.jay: Be more precise with the errors being raised,
2820 instead of flagging all exceptions during parsing to be attributed
2821 to the parsing process, distinguish those from errors happening in
2822 the actions and hint that using -v would produce the actual
2825 * repl.cs: Do not load all compiler references on each reset,
2826 doing the partial reset takes care of this.
2828 2008-08-28 Miguel de Icaza <miguel@novell.com>
2830 * repl.cs: Add support for loading all the files from
2831 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2834 Introduce a micro-parser that is able to deambiguate on its input
2835 whether we are dealing with a compilation unit (namespace, class,
2836 interface, struct, delegate) declaration or a statement. This
2837 allows both declarations and statements to be entered.
2839 Set history size by default to 300 lines.
2841 Instead of distinguishing based on the parser.InteractiveResult,
2842 have only two cases: statements were parsed, or a compilation unit
2843 was. Always pull the Using statement additions from the
2844 compilation unit parse.
2846 * cs-tokenizer.cs: Rename tokens to better describe their intent
2847 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2849 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2850 EvalMode is used to trigger the lookup of global variables while
2851 StatementMode is used turn variable declarations into static
2854 * getline.cs: Allow history size to be set.
2856 2008-08-29 Marek Safar <marek.safar@gmail.com>
2858 A fix for bug #360755
2859 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2861 2008-08-29 Marek Safar <marek.safar@gmail.com>
2863 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2865 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2866 member name, it is too confusing
2868 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2870 * rootcontext.cs: Finally default to warning level 4.
2872 2008-08-28 Marek Safar <marek.safar@gmail.com>
2874 * class.cs (CheckBase): Ignore overloaded operators.
2876 2008-08-28 Marek Safar <marek.safar@gmail.com>
2878 A fix for bug #420830
2879 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2881 2008-08-28 Marek Safar <marek.safar@gmail.com>
2883 A fix for bug #420832
2884 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2886 2008-08-28 Marek Safar <marek.safar@gmail.com>
2888 A fix for bug #420386
2889 * nullables.cs: Fixed logic of nullable user comparison operators involving
2892 2008-08-28 Marek Safar <marek.safar@gmail.com>
2894 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2896 2008-08-27 Miguel de Icaza <miguel@novell.com>
2898 * repl.cs: Add support for aborting the running code with C-c.
2900 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2902 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2904 2008-08-27 Miguel de Icaza <miguel@novell.com>
2906 * cs-parser.jay (interactive_statement_list): A new set of rules
2907 for hosting statements that uses the "interactive_" prefix.
2909 * repl.cs: Add support for parsing `using' as a statement or as a
2910 directive. Deambiguating before passing this to the parser.
2912 We need to distinguish statement_expressions that occur at the
2913 toplevel vs those that occur embedded into expressions.
2915 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2916 that fixes the cursor key handling, and a history bug.
2918 2008-08-26 Miguel de Icaza <miguel@novell.com>
2920 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2921 limitations in Console, instead the 2.0 bootstrap libraries now
2922 include the Console bits.
2924 Also, remove the use of Nullables from getline.cs
2928 Interactive support for the C# compiler. Use gmcs --shell to
2929 enter a read-eval-print loop shell.
2931 Docs: http://www.mono-project.com/CsharpRepl
2933 * sources: include repl.cs here and getline.cs for gmcs.exe,
2934 everything else is getline.cs impaired.
2936 * Makefile: when bootstrapping pass a special flag
2937 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2938 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2939 This distinguishes those two cases.
2941 * repl.cs: Support for a read-eval-print loop. Will be soon
2942 refactored into eval support and then REPL on top of it.
2944 * ecore.cs: If a simplename lookup fails, before erroring out,
2945 if we are in EvalMode to resolve the name to a declaration in the
2948 This means that variable declarations that happened in previous
2949 classes (as repl puts every statement in a separate class) are
2950 made visible in this way.
2952 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2953 triggered an error due to the end of file being reached. This is
2954 used to do multi-line input, and notify the caller that the user
2955 needs to provide more text before a successful parse.
2957 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2958 to drive the evaluation with a custom wrapper.
2960 * driver.cs: Add support for --shell, and refactor some code to be
2963 * namespace.cs: Add support for serializing the contents of the
2964 namespaces and reloading them.
2966 * getline.cs: A managed implementation of ReadLine under
2967 X11/Apache2 license terms. Easy to embed in other applications as
2970 * namespace.cs: Add some functions to save and restore the
2973 * rootcontext.cs: New public field.
2975 * cs-tokenizer.cs: Add support for one of the possible characters
2976 we introduce into the token stream.
2978 This patch does not affect the regular tokenization process, the
2979 only performance hit would happen if there is an invalid character
2980 on the input string.
2982 * support.cs: Move isatty helper routine here.
2984 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2985 code generator for in-memory assemblies.
2987 2008-08-26 Marek Safar <marek.safar@gmail.com>
2989 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2990 parameter cannot be always used as a type.
2992 2008-08-21 Marek Safar <marek.safar@gmail.com>
2994 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2996 2008-08-21 Marek Safar <marek.safar@gmail.com>
2998 * convert.cs: Implement explicit array to IList<T> conversion.
3000 2008-08-20 Marek Safar <marek.safar@gmail.com>
3002 A fix for bug #362740
3003 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3005 2008-08-20 Marek Safar <marek.safar@gmail.com>
3007 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3008 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3009 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3010 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3011 handling to use just one type of infrastructure and deal with generics
3014 2008-07-23 Martin Baulig <martin@ximian.com>
3016 *** Merged this from trunk revision 108527 ***
3019 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3020 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3023 2008-08-15 Marek Safar <marek.safar@gmail.com>
3025 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3028 2008-08-15 Marek Safar <marek.safar@gmail.com>
3030 * delegate.cs: Fixed compiler crash when creating delegate using partial
3033 * typemanager.cs: MulticastDelegate is not a delegate.
3035 2008-08-14 Marek Safar <marek.safar@gmail.com>
3037 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3040 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3042 * cs-parser.jay (type): Allow 'var' in mcs too.
3043 (local_variable_type): Likewise.
3045 2008-08-14 Marek Safar <marek.safar@gmail.com>
3047 * driver.cs: Removed broken -noconfig variants.
3049 2008-08-14 Marek Safar <marek.safar@gmail.com>
3051 A fix for bug #417078
3052 * expression.cs: Emit correctly left side pointer operators.
3054 2008-08-13 Marek Safar <marek.safar@gmail.com>
3056 * generic.cs, lambda.cs: Inflate method generic arguments only.
3058 2008-08-12 Marek Safar <marek.safar@gmail.com>
3060 * class.cs: Fixed struct layout check regression.
3062 2008-08-12 Marek Safar <marek.safar@gmail.com>
3064 * cs-parser.jay, enum.cs: Simplified enum parsing.
3066 * decl.cs: Check all type parameters conflicts.
3068 * expression.cs, statement.cs, attribute.cs: More expression checks.
3070 2008-08-11 Marek Safar <marek.safar@gmail.com>
3072 * generic.cs: Add type inference types restriction.
3074 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3075 anonymous.cs, expression.cs: Allocate less accessor parameters.
3077 2008-08-08 Marek Safar <marek.safar@gmail.com>
3079 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3082 2008-08-08 Marek Safar <marek.safar@gmail.com>
3084 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3086 2008-08-07 Marek Safar <marek.safar@gmail.com>
3088 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3089 Also fixes #362146 and #381592.
3091 2008-08-07 Marek Safar <marek.safar@gmail.com>
3093 * ecore.cs: Reduced constant cannot be used as an attribute value.
3095 * cs-parser.jay: Base expression has to be a type.
3097 * expression.cs (Conditional): Uses ReducedExpression.
3099 2008-08-06 Marek Safar <marek.safar@gmail.com>
3101 A fix for bug #376826
3102 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3103 address of hoisted local variable or parameter cannot be taken.
3105 2008-08-05 Marek Safar <marek.safar@gmail.com>
3107 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3108 anonymous method inside checked/unchecked expression.
3110 2008-08-05 Marek Safar <marek.safar@gmail.com>
3112 * typemanager.cs (IsEqual): Guard against null.
3114 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3115 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3116 routine. Fixed few misleading conversion errors.
3118 2008-08-04 Marek Safar <marek.safar@gmail.com>
3120 * class.cs: Consider generics when checking cycles in struct layout.
3122 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3124 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3126 2008-08-04 Marek Safar <marek.safar@gmail.com>
3128 A fix for bug #414165
3129 * anonymous.cs: Use same anonymous implementation method for all anonymous
3132 2008-08-04 Marek Safar <marek.safar@gmail.com>
3134 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3137 2008-08-04 Marek Safar <marek.safar@gmail.com>
3139 * cs-parser.jay: Typeof argument has to be a type expression.
3141 * namespace.cs: Check alias and namespace definitions collisions.
3143 * class.cs, pending.cs: Moved explicit interface accessor implementation
3146 * delegate.cs, expression.cs: Verify special name invocations.
3148 2008-08-01 Marek Safar <marek.safar@gmail.com>
3150 * cs-parser.jay: Don't choke on empty generic type arguments.
3152 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3154 * expression.cs, ecore.cs: Minor expressions bugs.
3156 2008-08-01 Marek Safar <marek.safar@gmail.com>
3158 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3159 and added more error handling.
3161 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3163 * modifiers.cs, enum.cs: Fixed.
3165 2008-07-31 Jb Evain <jbevain@novell.com>
3167 * driver.cs: remove -pkg ability of smcs.
3169 2008-07-30 Marek Safar <marek.safar@gmail.com>
3171 * statement.cs (Switch): Correctly set empty default target for single
3174 2008-07-30 Marek Safar <marek.safar@gmail.com>
3176 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3177 string switch statement implementation to use string dictionary which
3178 significantly (2-8x) improves performance of generated code.
3180 2008-07-29 Marek Safar <marek.safar@gmail.com>
3182 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3183 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3185 2008-07-29 Marek Safar <marek.safar@gmail.com>
3187 A fix for bug #412595
3188 * typemanager.cs, convert.cs, expression.cs: Some types are never
3189 convertible to each other.
3191 2008-07-29 Marek Safar <marek.safar@gmail.com>
3193 * nullable.cs (CreateNullConstant): An error messages update.
3195 2008-07-29 Marek Safar <marek.safar@gmail.com>
3197 A fix for bug #412595
3198 * cfold.cs: Don't cast undefined bool constant.
3200 2008-07-29 Martin Baulig <martin@ximian.com>
3203 (SymbolWriter.Reset): New public static method.
3206 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3208 2008-07-28 Marek Safar <marek.safar@gmail.com>
3210 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3212 * expression.cs (ElementAccess): Exact size allocation.
3214 2008-07-26 Marek Safar <marek.safar@gmail.com>
3216 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3218 2008-07-25 Marek Safar <marek.safar@gmail.com>
3220 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3222 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3225 2008-07-25 Marek Safar <marek.safar@gmail.com>
3227 A fix for bug #412217
3228 * assign.cs: Mutate also assignment type.
3230 2008-07-25 Marek Safar <marek.safar@gmail.com>
3232 A fix for bug #323644
3233 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3236 2008-07-25 Marek Safar <marek.safar@gmail.com>
3238 A fix for bug #412134
3239 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3240 non-enumerable operands when overloading equality or bitwise operators.
3242 2008-07-25 Marek Safar <marek.safar@gmail.com>
3244 * anonymous.cs: Cache closed generic anonymous method delegates.
3246 2008-07-24 Marek Safar <marek.safar@gmail.com>
3248 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3249 anonymous.cs, statement.cs: Always emit anonymous method as static method
3250 when is instance free. Use nesting for nested anynomous methods blocks.
3252 2008-07-23 Marek Safar <marek.safar@gmail.com>
3254 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3257 2008-07-23 Marek Safar <marek.safar@gmail.com>
3259 * expression.cs: Removed MakeSimpleCall.
3261 2008-07-23 Marek Safar <marek.safar@gmail.com>
3263 A fix for bug #323012
3264 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3265 Base method implementing interface has to be public.
3267 2008-07-23 Marek Safar <marek.safar@gmail.com>
3269 * cs-parser.jay: Don't break on missing argument.
3271 2008-07-22 Marek Safar <marek.safar@gmail.com>
3273 A fix for bug #320993
3274 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3275 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3277 2008-07-22 Marek Safar <marek.safar@gmail.com>
3279 A fix for bug #320748
3280 * convert.cs: Implicit user operators cannot convert to interfaces
3282 2008-07-22 Marek Safar <marek.safar@gmail.com>
3284 A fix for bug #312686
3285 * driver.cs: Ignore empty assembly references.
3287 2008-07-22 Marek Safar <marek.safar@gmail.com>
3289 A fix for bug #387040
3290 * ecore.cs: Skip constrains check for an explicit implementation.
3292 2008-07-21 Marek Safar <marek.safar@gmail.com>
3294 A fix for bug #409045
3295 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3296 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3297 identifiers are file specific unless passed as input arguments.
3299 2008-07-21 Marek Safar <marek.safar@gmail.com>
3301 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3302 to emit UnmanagedMarshal data under 2.0 profile.
3304 2008-07-21 Marek Safar <marek.safar@gmail.com>
3306 A fix for bug #410369
3307 * parameter.cs: Clone correctly ParamsParameter.
3309 2008-07-21 Marek Safar <marek.safar@gmail.com>
3311 * expression.cs (Argument): Always report type for type based expressions
3314 2008-07-18 Marek Safar <marek.safar@gmail.com>
3316 A fix for bug #410666
3317 * anonymous.cs: Correctly initialize generic storey reference.
3319 2008-07-18 Marek Safar <marek.safar@gmail.com>
3321 * convert.cs: Don't box same type arguments.
3323 2008-07-18 Marek Safar <marek.safar@gmail.com>
3325 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3326 Finished missing generic type mutators.
3328 2008-07-18 Marek Safar <marek.safar@gmail.com>
3330 * iterators.cs, statement.cs: Finished statements CloneTo.
3332 2008-07-18 Marek Safar <marek.safar@gmail.com>
3334 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3336 * expression.cs: Emit optimized default value expressions in expression tree
3339 2008-07-18 Marek Safar <marek.safar@gmail.com>
3341 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3343 2008-07-17 Marek Safar <marek.safar@gmail.com>
3345 A fix for bug #367536
3346 * cs-parser.jay: Check static constructor of generic types for an access
3349 2008-07-17 Marek Safar <marek.safar@gmail.com>
3351 A fix for bug #353800
3352 * lambda.cs: Emit ret for contextual statements.
3354 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3355 up emitting redundant ret for all anonymous methods with return.
3357 2008-07-17 Marek Safar <marek.safar@gmail.com>
3359 A fix for bug #365188
3360 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3361 create anonymous method storey in unreachable block.
3363 2008-07-17 Marek Safar <marek.safar@gmail.com>
3365 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3366 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3367 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3368 statement.cs: Fixed relevant defects found by Gendarme.
3370 2008-07-17 Marek Safar <marek.safar@gmail.com>
3372 A fix for bug #325291
3373 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3374 statement.cs: Replaced IAnonymousHost with top level block flag.
3376 2008-07-17 Marek Safar <marek.safar@gmail.com>
3378 * cs-parser.jay: Clean up unused open_parens.
3380 2008-07-17 Marek Safar <marek.safar@gmail.com>
3382 * ecore.cs: Custom error message for a range variable assignment.
3384 2008-07-16 Marek Safar <marek.safar@gmail.com>
3386 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3389 2008-07-16 Marek Safar <marek.safar@gmail.com>
3391 * literal.cs: Null literal is of object type.
3393 2008-07-16 Marek Safar <marek.safar@gmail.com>
3395 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3396 expression of nullable equality comparison.
3398 2008-07-15 Marek Safar <marek.safar@gmail.com>
3400 * expression.cs(PointerArithmetic): Removed redundant assignment.
3402 2008-07-15 Marek Safar <marek.safar@gmail.com>
3404 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3406 2008-07-14 Marek Safar <marek.safar@gmail.com>
3408 A fix for bug #408361
3409 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3410 they are replaced by GetMethod.
3412 2008-07-14 Marek Safar <marek.safar@gmail.com>
3414 A fix for bug #408721 by jeremie.laval@gmail.com
3415 * expression.cs (Indirection): Implemented CloneTo.
3417 2008-07-14 Marek Safar <marek.safar@gmail.com>
3419 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3422 2008-07-14 Marek Safar <marek.safar@gmail.com>
3424 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3426 2008-07-11 Marek Safar <marek.safar@gmail.com>
3428 * linq.cs: Reset tranparent parameter counter in probing mode.
3430 2008-07-11 Marek Safar <marek.safar@gmail.com>
3432 * anonymous.cs: Mutate anonymous method type.
3434 2008-07-11 Marek Safar <marek.safar@gmail.com>
3436 * ecore.cs, anonymous.cs: Mutate field expressions.
3438 2008-07-10 Marek Safar <marek.safar@gmail.com>
3440 A fix for bug #369670
3441 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3443 2008-07-10 Marek Safar <marek.safar@gmail.com>
3445 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3447 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3450 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3451 only one '>', and finds a '>>', abort the generic lookahead.
3453 2008-07-10 Marek Safar <marek.safar@gmail.com>
3455 A fix for bug #319902
3456 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3458 2008-07-10 Marek Safar <marek.safar@gmail.com>
3460 A fix for bug #406371
3461 * statement.cs: Moved EmitSymbolInfo to Block.
3463 2008-07-09 Marek Safar <marek.safar@gmail.com>
3465 * ecore.cs: Report better error for extension method overload failures.
3467 2008-07-09 Marek Safar <marek.safar@gmail.com>
3469 * expression.cs (Is): No need to box reference values.
3471 2008-07-09 Marek Safar <marek.safar@gmail.com>
3473 * class.cs: Use event resolve context when initializing CreateEmitContext.
3475 2008-07-09 Marek Safar <marek.safar@gmail.com>
3477 A fix for bug #394436
3478 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3479 method used inside expression trees. Added more LINQ to expression tree
3482 2008-07-08 Marek Safar <marek.safar@gmail.com>
3484 A fix for bug #378189, #370577
3485 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3488 2008-07-08 Marek Safar <marek.safar@gmail.com>
3490 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3493 2008-07-08 Marek Safar <marek.safar@gmail.com>
3495 A fix for bug #406702
3496 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3498 2008-07-07 Marek Safar <marek.safar@gmail.com>
3500 A fix for bug #406648
3501 * cs-parser.jay: Report nullable use in mcs for some cases.
3503 2008-07-07 Marek Safar <marek.safar@gmail.com>
3505 * ecore.cs: Improved argument mismatch error messages.
3507 2008-07-07 Marek Safar <marek.safar@gmail.com>
3509 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3511 2008-07-07 Marek Safar <marek.safar@gmail.com>
3513 * expression.cs (TypeOf): Mutate type argument.
3515 2008-07-04 Marek Safar <marek.safar@gmail.com>
3517 * class.cs: Report missing partial modifier for correct type.
3519 2008-07-04 Marek Safar <marek.safar@gmail.com>
3521 * ecore.cs, expression.cs (VariableReference): Variable property is
3524 2008-07-04 Marek Safar <marek.safar@gmail.com>
3526 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3528 2008-07-04 Marek Safar <marek.safar@gmail.com>
3530 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3533 2008-07-04 Marek Safar <marek.safar@gmail.com>
3535 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3536 anonymous method storey to an instance method when only "this" is hoisted.
3538 2008-07-03 Marek Safar <marek.safar@gmail.com>
3540 A fix for bug #321615
3541 * expression.cs: Pointer comparisons use unsigned operator.
3543 2008-07-03 Marek Safar <marek.safar@gmail.com>
3545 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3547 2008-07-02 Marek Safar <marek.safar@gmail.com>
3549 A fix for bug #404905
3550 * class.cs: Always initialize local unsafe variables.
3552 2008-06-30 Marek Safar <marek.safar@gmail.com>
3554 A fix for bug #396987
3555 * expression.cs (NewInitialize): Clear local temporary variable for next run
3557 2008-06-27 Marek Safar <marek.safar@gmail.com>
3559 A fix for bug #401020
3560 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3562 2008-06-27 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #398319
3565 * cs-parser.jay: Implemented undocumented base access expression inside
3568 2008-06-26 Marek Safar <marek.safar@gmail.com>
3570 A fix for bug #404227
3571 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3573 2008-06-26 Marek Safar <marek.safar@gmail.com>
3575 A fix for bug #404227
3576 * convert.cs: Fixed explicit array to interface cast.
3578 2008-06-26 Marek Safar <marek.safar@gmail.com>
3580 A fix for bug #403894
3581 * delegate.cs: Mutate DelegateInvocation type.
3583 2008-06-26 Marek Safar <marek.safar@gmail.com>
3585 A fix for bug #379348
3586 * delegate.cs: Box a load of generic parameters.
3588 2008-06-26 Marek Safar <marek.safar@gmail.com>
3590 * expression.cs: Add an array creation arguments mutate.
3592 2008-06-26 Marek Safar <marek.safar@gmail.com>
3594 A fix for bug #386068
3595 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3598 2008-06-25 Marek Safar <marek.safar@gmail.com>
3600 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3603 2008-06-25 Marek Safar <marek.safar@gmail.com>
3605 A fix for bug #403518
3606 * delegate.cs: Type correctly anonymous method new invocation.
3608 2008-06-24 Marek Safar <marek.safar@gmail.com>
3610 A fix for bug #394826
3611 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3614 2008-06-24 Marek Safar <marek.safar@gmail.com>
3616 A fix for bug #394826
3617 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3620 2008-06-24 Marek Safar <marek.safar@gmail.com>
3622 * class.cs: Clone indexer parameters for localized capturing.
3624 2008-06-24 Marek Safar <marek.safar@gmail.com>
3626 A fix for bug #402379
3627 * expression.cs: Don't crash when an object initializer resolve fails.
3629 2008-06-24 Marek Safar <marek.safar@gmail.com>
3631 A fix for bug #402888
3632 * expression.cs: Mutate conditional expression.
3634 2008-06-24 Marek Safar <marek.safar@gmail.com>
3636 A fix for bug #401012
3637 * class.cs: Keep StructLayout in shared container.
3639 2008-06-24 Marek Safar <marek.safar@gmail.com>
3641 A fix for bug #400438
3642 * decl.cs, class.cs: Only properties can be automatically implemented.
3644 2008-06-24 Marek Safar <marek.safar@gmail.com>
3646 * statement.cs (ChangeToIterator): Copy also labels.
3648 2008-06-23 Marek Safar <marek.safar@gmail.com>
3650 * ecore.cs: Pass type argument details to parent extension method.
3652 2008-06-23 Marek Safar <marek.safar@gmail.com>
3654 A fix for bug #375966
3655 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3657 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3659 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3661 2008-06-22 Marek Safar <marek.safar@gmail.com>
3663 A fix for bug #394347
3664 * anonymous.cs: Cache compatible delegates as compatibility check produces
3665 a new method every time.
3667 2008-06-20 Marek Safar <marek.safar@gmail.com>
3669 * anonymous.cs: Propagate storey reference for single references.
3671 2008-06-20 Marek Safar <marek.safar@gmail.com>
3673 A fix for bug #387615
3674 * assign.cs, expression.cs: Correctly clone compound assignment.
3676 2008-06-19 Marek Safar <marek.safar@gmail.com>
3678 A fix for bug #359611, #359604
3679 * anonymous.cs: Mutate all types of hoisted parameters.
3681 2008-06-19 Marek Safar <marek.safar@gmail.com>
3683 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3684 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3685 expression.cs, codegen.cs, statement.cs
3687 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3688 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3690 ** Anonymous methods, lambda expressions rewrite **
3692 Anonymous expressions are now resolved when an explicit block is resolved
3693 and they don't require any registration procedure anymore. Further,
3694 anonymous methods are defined when explicit block is emitted which allows
3695 better control of whole process and opens possibilities for more
3696 optimizations as well as alternative to reverse whole process.
3698 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3699 process consistent and to correctly emit hoisted generic methods when they
3700 have at least 1 hoisted variable.
3702 2008-06-17 Martin Baulig <martin@ximian.com>
3704 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3706 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3707 virtual property; check it in Emit().
3708 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3710 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3712 (Indexer.Define): Likewise.
3714 2008-06-17 Marek Safar <marek.safar@gmail.com>
3716 * convert.cs: Don't use IsInterface on type arguments.
3718 * delegate.cs: DelegateInvocation uses MethodInfo.
3720 * parameter.cs: Removed IsTypeParameter.
3722 * generic-mcs.cs: More missing stuff.
3724 2008-06-16 Martin Baulig <martin@ximian.com>
3727 (Modifiers.DEBUGGER_HIDDEN): New public const.
3730 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3733 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3734 (AbstractPropertyEventMethod): Likewise.
3735 (Constructor.Emit): Likewise.
3736 (SourceMethod.SetCompilerGenerated): Removed.
3738 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3742 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3743 if we're an `IteratorHost'.
3744 (AnonymousMethodMethod..ctor): Don't set
3745 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3748 2008-06-16 Marek Safar <marek.safar@gmail.com>
3750 * statement.cs: Clean-up foreach statements.
3752 2008-06-12 Marek Safar <marek.safar@gmail.com>
3754 * class.cs: Stop using public method which should not exist
3755 (MethodBuilder.SetGenericMethodSignature).
3757 2008-06-11 Martin Baulig <martin@ximian.com>
3760 (Location.LookupFile): Add `CompilationUnit' argument; when given
3761 a relative file name, make it relative to the directory the .cs
3762 file is located in instead of using the current directory.
3764 2008-06-11 Martin Baulig <martin@ximian.com>
3767 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3768 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3769 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3770 (SourceMethod.SetCompilerGenerated): Likewise.
3772 2008-06-11 Marek Safar <marek.safar@gmail.com>
3774 * codegen.cs, driver: Only write symbol file when it's asked for.
3776 2008-06-11 Marek Safar <marek.safar@gmail.com>
3778 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3780 2008-06-10 Martin Baulig <martin@ximian.com>
3782 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3784 2008-06-09 Marek Safar <marek.safar@gmail.com>
3786 A fix for bug #316290
3787 * expression.cs: Include decimal operators in predefined table.
3789 * parameters.cs: More readonlyness.
3791 2008-06-09 Marek Safar <marek.safar@gmail.com>
3793 A fix for bug #397213
3794 * cs-parser.jay: One more missing current_local_parameters reset.
3796 2008-06-09 Marek Safar <marek.safar@gmail.com>
3798 A fix for bug #396633
3799 * class.cs: Host backing field in partial container.
3801 2008-06-09 Marek Safar <marek.safar@gmail.com>
3803 A fix for bug #397068
3804 * expression.cs: Check both operand types when predefined operator is used.
3806 2008-06-05 Martin Baulig <martin@ximian.com>
3808 Merged the `debugger-kahalo' branch.
3811 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3812 we're an iterator method.
3813 (SourceMethod): Reflect latest symbol writer changes;
3814 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3815 now `start_row' and `end_row'.
3816 (Constructor.Emit): Fix the logic whether to emit symbol information.
3818 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3822 (CompilationUnit): New public class; derives from `SourceFile'.
3823 (SourceFileEntry.DefineSymbolInfo): New public method.
3824 (SourceFileEntry.SetChecksum): New public method.
3825 (Location): Encode hidden line numbers by using `column == 255';
3826 the .ctor now accepts `column == -1' to mark a hidden line number.
3827 (Location.Hidden): New public property.
3828 (Location.CheckPoint): Add `CompilationUnit'.
3829 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3830 (Location.Push): Add `CompilationUnit compile_unit' argument.
3831 (Location.CompilationUnit): New public property.
3834 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3836 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3838 * driver.cs: `SourceFile' -> `CompilationUnit'.
3840 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3842 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3844 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3848 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3849 new symbol writer API to also pass the file.
3851 2008-06-05 Marek Safar <marek.safar@gmail.com>
3853 * statement.cs: Emit catch variable assignment using variable expression.
3855 2008-06-05 Marek Safar <marek.safar@gmail.com>
3857 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3858 with other variable types.
3860 2008-06-04 Marek Safar <marek.safar@gmail.com>
3862 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3863 GetLength method emit, it breaks resolve rules.
3865 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3866 Marek Safar <marek.safar@gmail.com>
3868 A fix for bug #395542
3869 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3872 2008-06-02 Marek Safar <marek.safar@gmail.com>
3874 A fix for bug #395287
3875 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3877 2008-05-31 Marek Safar <marek.safar@gmail.com>
3879 A fix for bug #395845
3880 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3881 non-nullable parameter type.
3883 2008-05-31 Marek Safar <marek.safar@gmail.com>
3885 * class.cs: Handle contructor initializer as a statement in top-level block.
3887 2008-05-30 Marek Safar <marek.safar@gmail.com>
3889 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3890 security attributes.
3892 2008-05-24 Marek Safar <marek.safar@gmail.com>
3894 * ecore.cs, expression.cs: Small IVariable refactoring.
3896 2008-05-22 Marek Safar <marek.safar@gmail.com>
3898 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3900 2008-05-21 Marek Safar <marek.safar@gmail.com>
3902 * cs-parser.jay: Removed redundant catch type check.
3904 2008-05-21 Marek Safar <marek.safar@gmail.com>
3906 A fix for bug #390372
3907 * nullable.cs: Set correct return type.
3909 2008-05-21 Marek Safar <marek.safar@gmail.com>
3911 A fix for bug #391062
3912 * typemanager.cs: Fixed crash when comparing null types.
3914 2008-05-21 Marek Safar <marek.safar@gmail.com>
3916 A fix for bug #391871
3917 * cs-parser.jay: Better error handling for invalid catch type.
3919 2008-05-20 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #392155
3922 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3924 2008-05-15 Marek Safar <marek.safar@gmail.com>
3926 A fix for bug #390666
3927 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3930 2008-05-15 Marek Safar <marek.safar@gmail.com>
3932 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3935 2008-05-13 Marek Safar <marek.safar@gmail.com>
3937 A fix for bug #389625
3938 * delegate.cs, generic.cs: Some progress on method group return type
3941 2008-05-13 Marek Safar <marek.safar@gmail.com>
3943 A fix for bug #378419
3944 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3946 2008-05-12 Marek Safar <marek.safar@gmail.com>
3948 * class.cs (Constructor): Added IsCompilerGenerated.
3950 2008-05-12 Marek Safar <marek.safar@gmail.com>
3952 * expression.cs: Enum binary operators can accept non-enum operand only when
3953 is implicitly convertible to underlying type.
3955 2008-05-12 Marek Safar <marek.safar@gmail.com>
3957 A fix for bug #389272
3958 * support.cs: Workaround System.InvalidOperationException for enums.
3960 2008-05-12 Marek Safar <marek.safar@gmail.com>
3962 A fix for bug #389073
3963 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3965 2008-05-10 Marek Safar <marek.safar@gmail.com>
3967 * driver.cs: Split Parse.
3969 * location.cs (LookupFile): Uses string.Empty.
3971 2008-05-07 Marek Safar <marek.safar@gmail.com>
3973 * expression.cs, parameter.cs: Small ParameterReference clean up.
3975 2008-05-07 Marek Safar <marek.safar@gmail.com>
3977 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3978 hack. Fixes #387502.
3980 2008-05-06 Martin Baulig <martin@ximian.com>
3982 * class.cs (Constructor.Emit): Fix the logic whether to emit
3985 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3988 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3989 InvalidOperationException when the iterator is before the start or
3992 2008-05-06 Marek Safar <marek.safar@gmail.com>
3994 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3995 when left is nullable type.
3997 2008-05-06 Marek Safar <marek.safar@gmail.com>
3999 A fix for bug #386628
4000 * expression.cs (LocalVariableReference): Continue in resolving when
4001 variable is not assigned.
4003 2008-05-05 Marek Safar <marek.safar@gmail.com>
4005 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4006 nullable operations.
4008 2008-05-04 Marek Safar <marek.safar@gmail.com>
4010 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4011 it saves many redundant temporary variables for nullable operations.
4013 2008-05-03 Marek Safar <marek.safar@gmail.com>
4015 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4017 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4020 * nullable.cs: Constant coalescing operator optimizations.
4022 2008-05-03 Marek Safar <marek.safar@gmail.com>
4024 * constant.cs: Use unsigned conversion for values which are unsigned only.
4026 2008-05-03 Marek Safar <marek.safar@gmail.com>
4028 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4029 coalescing operator as it should be.
4031 2008-05-02 Marek Safar <marek.safar@gmail.com>
4033 A fix for bug #371016
4034 * expression.cs: All predefined delegate operators require implicit method
4037 2008-05-02 Marek Safar <marek.safar@gmail.com>
4039 * constant.cs: Emit long constant as uint when fits the range.
4041 * convert.cs, expression.cs: Fixed few unsafe conversions.
4043 2008-05-02 Marek Safar <marek.safar@gmail.com>
4045 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4047 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4050 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4052 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4054 2008-05-01 Marek Safar <marek.safar@gmail.com>
4056 * constant.cs, literal.cs: IsLiteral property for error reporting.
4058 * ecore.cs, expression.cs: Implemented Property expression.
4060 2008-05-01 Marek Safar <marek.safar@gmail.com>
4062 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4064 * nullable.cs: Implemented nullable coalescing null operator.
4066 * ecore.cs, expression.cs: Expression trees work.
4068 2008-05-01 Marek Safar <marek.safar@gmail.com>
4070 * ecore.cs: CreateExpressionTree is finally abstract.
4072 * expression.cs, linq.cs: Updated.
4074 2008-05-01 Marek Safar <marek.safar@gmail.com>
4076 * expression.cs, ecore.cs: Block base access expression inside expression
4079 2008-05-01 Marek Safar <marek.safar@gmail.com>
4081 A fix for bug #385058
4082 * expression.cs: User-defined operator implementations always take
4083 precedence over predefined operator implementations.
4085 2008-04-30 Marek Safar <marek.safar@gmail.com>
4087 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4088 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4089 expression tree conversions.
4091 2008-04-30 Marek Safar <marek.safar@gmail.com>
4093 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4094 operators method details to Operator class.
4096 2008-04-30 Marek Safar <marek.safar@gmail.com>
4098 * anonymous.cs: Pass unsafe flags to anonymous container.
4100 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4101 inside expression tree.
4103 2008-04-29 Martin Baulig <martin@ximian.com>
4105 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4106 (Tokenizer.PopPosition): Also restore the `line'.
4108 2008-04-29 Marek Safar <marek.safar@gmail.com>
4110 * delegate.cs: Implemented Invoke expression.
4112 2008-04-29 Marek Safar <marek.safar@gmail.com>
4114 * expression.cs: Fixed equality reference comparison regression.
4116 2008-04-29 Marek Safar <marek.safar@gmail.com>
4118 * ecore.cs: Clean up EmptyCast hack.
4120 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4121 using correct conversion rules. Also fixes #383993.
4123 2008-04-28 Martin Baulig <martin@ximian.com>
4125 * class.cs (Constructor.Emit): Don't emit debugging information
4126 for generated default .ctor's.
4128 2008-04-28 Marek Safar <marek.safar@gmail.com>
4130 * convert.cs: Empty-cast ushort to int conversion.
4132 2008-04-28 Marek Safar <marek.safar@gmail.com>
4134 A fix for bug #384191
4135 * ecore.cs, expression.cs: Fixed expression cloning.
4137 2008-04-28 Marek Safar <marek.safar@gmail.com>
4139 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4141 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4143 Fix #381559, test-638.cs, test-639.cs
4144 * assign.cs (CompoundAssign.Helper): New wrapper.
4145 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4147 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4148 Pass unconverted expressions to the params array creation expression.
4149 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4150 (PropertyExpr.EmitAssign): Likewise.
4151 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4152 element if it is of kind CompoundAssign.Helper.
4153 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4154 first before anything else.
4155 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4156 (ArrayAccess.LoadArrayAndArguments): Simplify.
4158 2008-04-27 Marek Safar <marek.safar@gmail.com>
4160 * expression.cs: Fixed cloning of typeof(void).
4162 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4164 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4165 (Assign.Emit): Likewise. Move it to ...
4166 (CompoundAssign.DoResolve): ... here and ...
4167 (CompoundAssign.Emit): ... here.
4168 (EventAddOrRemove): New helper to handle += and -= on events, and
4169 avoid the use of BinaryDelegates.
4170 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4171 (EventExpr.EmitAddOrRemove): Improve.
4172 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4174 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4175 create VarExprs for 'foo.bar.var'.
4176 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4177 is a highly inappropriate name for its functionality.
4179 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4181 Simplify handling of multiple assignments
4182 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4184 (SimpleAssign): New. Class to be used for normal assignments.
4185 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4186 * expression.cs, parameter.cs, statement.cs: Likewise.
4188 2008-04-25 Marek Safar <marek.safar@gmail.com>
4190 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4191 for incompatible underlying types, more to come, uff.
4193 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4196 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4197 Handle 'leave_copy'.
4199 2008-04-25 Marek Safar <marek.safar@gmail.com>
4201 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4203 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4205 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4206 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4207 * statement.cs (While, Do, For): Allow test to have side effects.
4208 (For.DoEmit): Always emit InitStatement.
4211 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4212 Always create SideEffectConstant.
4213 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4214 of type EnumConstant.
4216 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4217 Handle 'right' being SideEffectConstant of type 'bool'.
4219 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4220 Use left.EmitBranchable instead of open coding it, so as to
4221 improve optimization opportunities.
4223 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4225 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4227 (Expression.EmitSideEffect): Document.
4229 2008-04-23 Marek Safar <marek.safar@gmail.com>
4231 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4233 2008-04-23 Marek Safar <marek.safar@gmail.com>
4235 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4237 2008-04-23 Marek Safar <marek.safar@gmail.com>
4239 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4240 conversion to expression tree.
4242 2008-04-23 Marek Safar <marek.safar@gmail.com>
4244 * ecore.cs: Removed unused expression.
4246 2008-04-22 Marek Safar <marek.safar@gmail.com>
4248 * expression.cs: Implemented NegateChecked and New expressions.
4250 2008-04-22 Marek Safar <marek.safar@gmail.com>
4252 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4254 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4257 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4258 needing final 'ret' instruction.
4260 2008-04-22 Marek Safar <marek.safar@gmail.com>
4262 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4264 2008-04-21 Marek Safar <marek.safar@gmail.com>
4266 * expression.cs: Emit ldnull and not null expression as an instance argument
4267 of static method expression calls.
4269 2008-04-21 Marek Safar <marek.safar@gmail.com>
4271 A fix for bug #378200
4272 * expression.cs: Fixed crash when creating parameterless expression tree
4275 2008-04-21 Marek Safar <marek.safar@gmail.com>
4277 A fix for bug #375297
4278 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4281 2008-04-21 Marek Safar <marek.safar@gmail.com>
4283 A fix for bug #377596
4284 * decl.cs, class.cs: Emit delegate type argument attributes.
4286 2008-04-21 Marek Safar <marek.safar@gmail.com>
4288 A fix for bug #365314
4289 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4291 2008-04-21 Marek Safar <marek.safar@gmail.com>
4293 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4296 2008-04-21 Marek Safar <marek.safar@gmail.com>
4298 * generic.cs (TypeParameter): Removed redundant location.
4300 2008-04-19 Marek Safar <marek.safar@gmail.com>
4302 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4303 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4304 FullNamedExpression in all declaration type expression, statements will come
4307 2008-04-18 Marek Safar <marek.safar@gmail.com>
4309 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4310 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4312 2008-04-18 Marek Safar <marek.safar@gmail.com>
4314 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4317 2008-04-17 Marek Safar <marek.safar@gmail.com>
4319 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4322 2008-04-17 Marek Safar <marek.safar@gmail.com>
4324 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4328 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4330 Hook up 'EmitSideEffect'
4331 * constant.cs (Constant.EmitSideEffect): New.
4332 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4333 (SideEffectConstant.EmitSideEffect): New.
4334 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4335 unconditional branch in EmitBranchable.
4336 (FieldExpr.EmitBranchable): New.
4337 * expression.cs (Unary.EmitSideEffect): New.
4338 (Binary.EmitSideEffect): New.
4339 (VariableReference.EmitSideEffect): New. Do nothing.
4341 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4343 Introduce 'EmitSideEffect'
4344 * ecore.cs (Expression.EmitSideEffect): New.
4345 (TypeCast): Rename from EmptyCast.
4347 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4348 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4349 * convert.cs, nullable.cs: Update to changes.
4351 2008-04-16 Marek Safar <marek.safar@gmail.com>
4353 * class.cs, cs-parser.jay: Early check for base types expression.
4355 2008-04-16 Marek Safar <marek.safar@gmail.com>
4357 * decl.cs (MemberName): Declare PrettyName as obsolete.
4359 2008-04-16 Marek Safar <marek.safar@gmail.com>
4361 * namespace.cs: Use MemberName comparison.
4363 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4366 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4368 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4369 (MemberName.FullyQualifiedName): New. Provides the functionality
4370 that users assume FullName would have.
4371 * ecore.cs, namespace.cs: Update to changes.
4373 * statement.cs (Using.assign): Make into ExpressionStatement.
4374 (Using.EmitPreTryBody): Simplify.
4376 2008-04-16 Marek Safar <marek.safar@gmail.com>
4378 * report.cs: ColorFormat is protected.
4380 * rootcontext.cs: Unused fields clean-up.
4382 * namespace.cs: Made UsingEntry name private.
4384 2008-04-16 Marek Safar <marek.safar@gmail.com>
4386 * cs-tokenizer.cs, location.cs: Removed unused field.
4388 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4389 Raja R Harinath <harinath@hurrynot.org>
4392 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4393 (SideEffectConstant.side_effect): Rename from 'right'.
4394 (SideEffectConstant..ctor): Normalize 'side_effect'.
4395 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4396 value of this constant.
4397 * cfold.cs: Update to changes.
4399 2008-04-15 Marek Safar <marek.safar@gmail.com>
4401 * cs-paser.jay: Removed unused variable.
4403 * driver.cs: Made Compile instance method.
4405 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4407 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4409 2008-04-15 Marek Safar <marek.safar@gmail.com>
4411 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4413 2008-04-13 Jb Evain <jbevain@novell.com>
4415 * namespace.cs: update the System.Core fullname for 2.1
4416 * driver.cs: update the list of required assemblies for 2.1.
4417 Merged from the Moonlight 2 branch.
4419 2008-04-11 Marek Safar <marek.safar@gmail.com>
4421 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4422 types and user defined operators. User operators arguments has to be checked
4423 for null value before invocation, which also means no operator is called
4424 when any argument is not convertible to unwrapped nullable type.
4426 2008-04-09 Marek Safar <marek.safar@gmail.com>
4428 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4429 of Unary expressions to follow operator overloading rules precisely.
4430 Also fixes #321794, #323794
4432 2008-04-08 Marek Safar <marek.safar@gmail.com>
4434 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4437 2008-04-08 Marek Safar <marek.safar@gmail.com>
4439 * expression.cs, ecore.cs: Implemented MemberInit expression.
4441 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4443 Fix mono/tests/exception4.cs
4444 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4445 ec.NeedReturnLabel () rather emitting a 'nop'.
4447 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4449 (TryCatch.SomeCodeFollows): Likewise.
4450 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4451 for 'break', 'continue' and 'return' statements inside a try.
4452 We're fairly sure that the generated IL stream will have more
4453 instructions textually following the try.
4454 (FlowBranchingTryCatch): Likewise.
4456 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4457 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4460 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4461 wrapper -- forward everything to CollectionForeach.
4462 (CollectionForeach.NonDisposableWrapper): New.
4463 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4464 instead of a pop + branch to end.
4466 2008-04-07 Marek Safar <marek.safar@gmail.com>
4468 A fix for bug #377485
4469 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4470 Propagate location for extension method groups. Report conversion failure at
4473 2008-04-07 Marek Safar <marek.safar@gmail.com>
4475 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4476 ListInit and Field expressions.
4478 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4480 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4481 Since $PC is always -1 inside the body of MoveNext, the fault
4483 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4484 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4485 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4487 The denouement! Fix #324708
4488 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4489 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4490 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4491 'finally' inside the finally clause.
4493 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4494 inside an iterator. Don't emit the body of the 'finally' inside
4495 the finally clause yet.
4497 Use the ResumableStatement infrastructure for MoveNext ()
4498 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4499 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4500 'old_resume_points'. Move dispatcher upfront.
4501 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4502 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4503 in an enumerator. This encodes the main fix in this patch series
4504 -- we can only jump into the first instruction of a try from the
4505 outside, but we want to emit try/finally regions in iterators and
4506 resume in the middle of them.
4508 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4510 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4511 of NeedReturnLabel here.
4513 Introduce a common point for emitting try/finally to IL
4514 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4515 features of the various subclasses, which are now driven by ...
4516 (ExceptionStatement.EmitPreTryBody): ... this and ...
4517 (ExceptionStatement.EmitTryBody): ... this and the original
4519 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4520 Remove DoEmit and update to follow above protocol.
4522 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4523 of the dispatcher are the same, skip emitting the 'switch'.
4524 * iterator.cs (Iterator.EmitDispose): Update to changes.
4526 Clean up handling of 'using' statement
4527 * statement.cs (UsingTemporary): New. Carved out of ...
4528 (Using): ... this. Simplify drastically. Handle exactly
4530 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4531 or Using as appropriate. If there are multiple variable declared,
4532 create nested Using statements.
4533 (resource_acquisition): Kill.
4535 * statement.cs (ExceptionStatement.EmitForDispose): Use
4536 EmitFinallyBody, not EmitFinally.
4538 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4539 * iterator.cs: Update to changes.
4541 Start using the ResumableStatement infrastructure
4542 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4543 (ResumableStatement.EmitForDispose): New.
4544 (ExceptionStatement): Override them.
4545 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4546 EmitForDispose to create the body of the Dispose method. Don't
4549 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4550 * statement.cs (Toplevel.AddResumePoint): ... here.
4551 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4552 * flowanalysis.cs (FlowBranchingIterator): New.
4553 * codegen.cs (EmitContext): Update to changes.
4555 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4556 (Iterator.old_resume_points): Rename from 'resume_points'.
4557 (Iterator.MoveNextStatement): Remove unused class.
4559 New infrastructure for try/finally in iterators (still unused)
4560 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4561 (FlowBranchingToplevel.AddResumePoint): Hook into
4562 ToplevelBlock.AddResumePoint.
4563 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4564 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4565 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4566 resume points and assign program-counter values.
4567 (ExceptionBlock.AddResumePoint): Collect resume points for
4568 de-muxer at the top of try block.
4569 * iterators.cs (Yield.CheckContext): Simplify.
4570 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4572 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4574 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4575 argument to an ExitStatement.
4576 (FlowBranchingException): Refactor saved origins code.
4577 * statement.cs (ExitStatement): Update to cahges.
4578 * iterator.cs (YieldBreak): Likewise.
4580 * statement.cs (ResumableStatement): New. Common base class for
4581 YieldReturn and ExceptionStatement.
4582 (ExitStatement): New. Common base class for Return and YieldBreak.
4583 (Return): Update to changes.
4584 * iterator.cs (YieldBreak): Likewise.
4585 * lambda.cs (ContextualReturn): Likewise.
4588 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4589 emit a meaningful error message.
4591 Fix #324765, #319508
4592 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4593 (VariableInfo.SetAssigned): Set it.
4594 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4595 determine if CS0219 or CS0168 is appropriate. Don't use
4596 flow-analysis information.
4597 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4598 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4599 (EmitContext.EndFlowBranching): ... this.
4601 2008-04-03 Marek Safar <marek.safar@gmail.com>
4603 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4605 2008-04-03 Marek Safar <marek.safar@gmail.com>
4607 A fix for bug #376508
4608 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4609 ImplicitConversionExists.
4611 2008-04-03 Marek Safar <marek.safar@gmail.com>
4613 * expression.cs (Binary): Added remaining binary operators to expression
4616 * nullable.cs: Optimize shift with null argument.
4618 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4620 Fix minor IL regression
4621 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4622 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4623 * cs-parser.jay (try_statement): Update to changes.
4625 * statement.cs (TryFinally.need_exc_block): Delete.
4626 (TryFinally): Update to changes.
4628 Now all ExceptionStatements are unconditional
4629 * statement.cs (CollectionForeach.DisposableWrapper): New.
4630 Extract out the try/finally code into a new wrapper.
4631 (CollectionForeach.Resolve): Use it to simplify the code.
4633 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4635 Start at simplifying ExceptionStatement semantics a bit
4636 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4637 * cs-parser.jay (try_statement): Update to changes.
4638 (opt_catch_clauses): Remove.
4639 * flowanalysis.cs: Update to changes.
4640 (FlowBranching.BranchingType.TryCatch): New.
4641 (FlowBranchingTryCatch): New.
4643 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4644 (FlowBranching.CreateBranching): Update to changes.
4645 (FlowBranchingBlock.AddSibling): Add sanity check.
4646 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4649 * iterators.cs (Iterator.MarkFinally): Remove.
4650 * statement.cs (ExceptionStatement): Update to changes.
4652 Add support for skipping over finally blocks at runtime. First
4653 in a series to fix #324708
4654 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4655 (Iterator.EmitMoveNext): Initialize it.
4656 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4657 branch over the body of the 'finally' clause.
4659 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4661 Avoid lopsided use of Foo/DoFoo names
4662 * statement.cs (ExpressionStatement.EmitFinallyBody):
4663 Rename from EmitFinally.
4664 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4665 * iterator.cs: Update to changes.
4667 2008-04-02 Marek Safar <marek.safar@gmail.com>
4669 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4670 based on UserOperatorCall. More binary nullable operators clean up.
4672 2008-04-02 Martin Baulig <martin@ximian.com>
4674 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4676 2008-04-02 Marek Safar <marek.safar@gmail.com>
4678 * nullable.cs: Merge user and empty conversions when lifting expression
4681 * expression.cs (StringConcat): Implemented expression tree representation.
4683 2008-04-01 Marek Safar <marek.safar@gmail.com>
4685 * nullable.cs: When lifting null literal and a user operator exists, no call
4688 2008-04-01 Marek Safar <marek.safar@gmail.com>
4690 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4693 2008-04-01 Marek Safar <marek.safar@gmail.com>
4695 * nullable.cs, expression.cs: Use namespace instead heavily nested
4696 monster abstract class.
4698 2008-04-01 Marek Safar <marek.safar@gmail.com>
4700 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4701 lifting of null literal and user operators. Clean up of some temporary
4704 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4706 Fix #368224, test-629.cs
4707 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4708 if it crossed an unwind-protect boundary.
4709 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4710 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4711 inside an unwind-protected region.
4712 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4713 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4714 'leave' instead of a 'br' if unwind-protected.
4715 (Iterator.EmitYieldBreak): Likewise.
4717 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4719 * driver.cs: Only define versioninfo resources if no win32 resource
4722 2008-03-28 Marek Safar <marek.safar@gmail.com>
4724 A fix for bug #372375
4725 * convert.cs: Fixed boxing of nullable types.
4727 2008-03-28 Marek Safar <marek.safar@gmail.com>
4729 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4732 2008-03-28 Marek Safar <marek.safar@gmail.com>
4734 A fix for bug #374619
4735 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4737 2008-03-27 Marek Safar <marek.safar@gmail.com>
4739 * lambda.cs: Check return type only for invocation.
4741 2008-03-27 Marek Safar <marek.safar@gmail.com>
4743 A fix for bug #374214
4744 * ecore.cs: Correctly report argument type mismatch.
4746 2008-03-27 Marek Safar <marek.safar@gmail.com>
4748 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4749 and not rely on broken IsEnum.
4751 2008-03-27 Marek Safar <marek.safar@gmail.com>
4753 * nullable.cs: New file, extracted from generic.cs.
4755 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4757 2008-03-27 Marek Safar <marek.safar@gmail.com>
4759 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4760 predefined comparison operators and null literals.
4762 * report.cs: New warning ID.
4764 2008-03-25 Marek Safar <marek.safar@gmail.com>
4766 A fix for bug #370577
4767 * lambda.cs: Check return type too.
4769 2008-03-25 Marek Safar <marek.safar@gmail.com>
4771 A fix for bug #372846
4772 * class.cs: Automatic properties can be declared as unsafe.
4774 2008-03-20 Marek Safar <marek.safar@gmail.com>
4776 * location.cs: Use string based concatenation.
4778 * expression.cs: LiftedBinaryOperator is gmcs only.
4780 2008-03-20 Marek Safar <marek.safar@gmail.com>
4782 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4783 conversions rules and expression trees.
4785 2008-03-19 Marek Safar <marek.safar@gmail.com>
4787 * delegate.cs: Use extension method source as delegate target.
4789 2008-03-19 Marek Safar <marek.safar@gmail.com>
4791 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4792 binary operations to be purely based on binary operations and optimized
4793 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4794 and other ET refactoring.
4796 * typemanager.cs: Fixed warning.
4798 2008-03-17 Marek Safar <marek.safar@gmail.com>
4800 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4802 * symbolwriter.cs: Fixed.
4804 2008-03-17 Marek Safar <marek.safar@gmail.com>
4806 * anonymous.cs, driver.cs: Reset anonymous types counters.
4808 2008-03-17 Marek Safar <marek.safar@gmail.com>
4810 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4812 * class.cs: Use fullname for all type member definitions.
4814 2008-02-19 Martin Baulig <martin@ximian.com>
4817 (IMethodData.EmitExtraSymbolInfo): New interface method.
4818 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4819 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4820 interface method here as an empty public virtual method.
4823 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4824 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4825 CodeGen.SymbolWriter.SetRealMethodName().
4827 2008-02-18 Martin Baulig <martin@ximian.com>
4830 (ScopeInfo.EmitType): Override this and emit debugging
4831 information for captured variables.
4832 (RootScopeInfo.EmitType): Override this and emit symbol
4833 information for a captured `this'.
4835 2008-02-15 Martin Baulig <martin@ximian.com>
4837 * iterators.cs: Emit debugging info.
4840 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4841 (EmitContext.OmitDebuggingInfo): New public property.
4844 (While): Override Emit() and don't emit symbol info there; do it
4845 inside DoEmit() instead.
4846 (Block.Emit): Omit symbol information while emitting the scope
4847 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4849 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4850 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4851 .ctor to make `IsIterator' work.
4853 2008-03-14 Martin Baulig <martin@ximian.com>
4855 * symbolwriter.cs: Added the new symbol writer function from the
4856 debugger's `terrania' branch; temporarily enclose them inside
4857 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4860 2008-03-14 Martin Baulig <martin@ximian.com>
4863 (SymbolWriter): Make this a public static class.
4866 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4867 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4869 2008-03-14 Marek Safar <marek.safar@gmail.com>
4871 A fix for bug #370577
4872 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4875 2008-03-14 Marek Safar <marek.safar@gmail.com>
4877 * typemanager.cs (CSharpName): Made 250 times faster.
4879 2008-03-13 Marek Safar <marek.safar@gmail.com>
4881 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4883 2008-03-12 Marek Safar <marek.safar@gmail.com>
4885 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4886 crash when predefined field does not exist.
4888 2008-03-12 Marek Safar <marek.safar@gmail.com>
4890 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4892 2008-03-12 Marek Safar <marek.safar@gmail.com>
4894 * class.cs (FixedField): Don't crash when contructors are missing.
4896 2008-03-11 Marek Safar <marek.safar@gmail.com>
4898 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4899 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4900 check internal types accessibility for internal and external types.
4901 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4903 2008-03-11 Marek Safar <marek.safar@gmail.com>
4905 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4906 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4907 attribute.cs, statement: Use corect instance of predefined types (work
4908 related to #364674).
4910 2008-03-07 Marek Safar <marek.safar@gmail.com>
4912 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4914 2008-03-07 Marek Safar <marek.safar@gmail.com>
4916 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4917 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4918 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4919 predefined types clean up, delayed predefined types members initialization
4920 (work related to #364674).
4922 2008-03-05 Marek Safar <marek.safar@gmail.com>
4924 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4926 2008-03-05 Marek Safar <marek.safar@gmail.com>
4928 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4929 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4930 predefined types clean up (work related to #364674).
4932 2008-03-04 Marek Safar <marek.safar@gmail.com>
4934 * ecore.cs: Print an error message instead of throwing exception.
4936 2008-03-04 Marek Safar <marek.safar@gmail.com>
4938 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4939 expression.cs, statement.cs: Unififed null literal representation.
4941 2008-03-03 Marek Safar <marek.safar@gmail.com>
4943 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4944 expression.cs: Refactored binary operators resolve phase and improved speed.
4945 The nullable code is still missing and won't work correctly, more fixes
4948 It also fixes #323726, #324312, #324248, and many other unreported issues.
4950 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4952 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4955 2008-02-27 Marek Safar <marek.safar@gmail.com>
4957 * ecore.cs: Clean-up and split BetterConversion.
4959 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4962 * enum.cs (EnumMember.Value): Only access 'value' if
4963 ResolveValue says it's ok.
4964 (EnumMember.DoResolveValue): Don't set prev_member.value.
4965 (Enum.GetDefinition): Reverse arguments of Equals --
4966 EnumMember.Value can return 'null'.
4968 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4970 2008-02-22 Marek Safar <marek.safar@gmail.com>
4972 * generic.cs, expression.cs: More ongoing work on expression trees.
4974 2008-02-21 Marek Safar <marek.safar@gmail.com>
4976 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4977 handle missing matches when mutiple operators exist.
4979 2008-02-20 Marek Safar <marek.safar@gmail.com>
4981 A fix for bug #363218
4982 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4985 2008-02-20 Marek Safar <marek.safar@gmail.com>
4987 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4988 update. This time to deal correctly with SideEffectConstant expression used
4989 as an argument for another constant folding.
4991 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4993 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4996 2008-02-19 Marek Safar <marek.safar@gmail.com>
4998 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5000 2008-02-19 Marek Safar <marek.safar@gmail.com>
5002 A fix for bug #328136
5003 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5004 side is a false constant, because we still need to evaluate the right-hand
5007 * statement.cs (If): Emit two types of boolean constants (simple constant,
5008 side-effect constant).
5010 2008-02-19 Marek Safar <marek.safar@gmail.com>
5012 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5014 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5017 2008-02-18 Marek Safar <marek.safar@gmail.com>
5019 A fix for bug #361457
5020 * ecore.cs (IsApplicable): Params methods have lower priority.
5022 * support.cs: Return correct parameter modifier for params types.
5024 2008-02-18 Marek Safar <marek.safar@gmail.com>
5026 * generic.cs (TypeParameter): Cache attribute target name.
5028 * support.cs: Removed unused variable.
5030 * typemanager.cs: Removed debugging leftover.
5032 * ecore.cs: Use local type instead of a property;
5034 * class.cs (VerifyMembers): Consider also parent to test whether type member
5037 * expression.cs (FullMethodDesc): Removed.
5039 * attribute.cs (IsValidArgumentType): Made static.
5041 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5043 Cleanup to be more readable.
5044 * Makefile (GMCS_PROFILE): Remove.
5045 (COMPILER_NAME): New helper.
5047 2008-02-15 Miguel de Icaza <miguel@novell.com>
5049 * cs-tokenizer.cs: if a conditional expression happens inside a
5050 (...) this also means that we do not need to de-ambiguate between
5051 an parenthesized expression and a cast.
5055 * constant.cs (SideEffectConstant): a constant value that happens
5056 to have a side effect.
5058 Fixes the build regressions introduced by the fix for #359789
5060 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5062 * expression.cs (Conditional.Emit): when emitting the ternary
5063 operator, use local variables to generate code verifiable code.
5065 The verifier cannot infer that the type on stack before the
5066 stloc.0 is executed is of type ParentB. This happens because the
5067 stack merge algorithm uses only parent types when deciding which
5068 is the common type. This is described in Part III 1.8.1.3 of ECMA
5071 This code compiled with mcs is not verifiable under MS. The MS
5072 verifier picks the first common interface of Foo and Bar, which is
5073 wrong, but doesn't use a full join type of the 2 interfaces.
5075 CSC uses a clever hack to compile such code in a verifiable
5076 way. It stores the intermediate values in a local variable with
5081 2008-02-14 Miguel de Icaza <miguel@novell.com>
5083 * expression.cs: Do not fold BitwiseAnd operators when the left
5084 side is a false constant, because we still need to evaluate the
5089 * support.cs: Instead of throwing an InternalErrorException when
5090 the position of the stream is outside the boundary of our buffer,
5091 reset the state of the reader, and restart the reading from the
5092 beginning of the file.
5094 2008-02-14 Marek Safar <marek.safar@gmail.com>
5096 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5098 2008-02-14 Marek Safar <marek.safar@gmail.com>
5100 A fix for bug #361686
5101 * decl.cs: A protected types used inside a private class which parents
5102 derives from the protected class are accessible.
5104 2008-02-13 Marek Safar <marek.safar@gmail.com>
5106 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5107 the parameterless constructor.
5109 2008-02-13 Marek Safar <marek.safar@gmail.com>
5111 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5112 lookup methods to use standard member cache when doing member lookup.
5114 2008-02-12 Marek Safar <marek.safar@gmail.com>
5116 * driver.cs: Don't report full path for referenced module as assembly error.
5118 2008-02-12 Marek Safar <marek.safar@gmail.com>
5120 * Makefile: Fixed `qh' target to work on all machines.
5122 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5123 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5124 and HasElementType with TypeManager implementation.
5126 2008-02-08 Marek Safar <marek.safar@gmail.com>
5128 A fix for bugs #325134, #359749
5129 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5130 first binds point to non-method member expression.
5132 2008-02-08 Marek Safar <marek.safar@gmail.com>
5134 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5136 2008-02-08 Marek Safar <marek.safar@gmail.com>
5138 A fix for bugs #321394, #323028
5139 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5140 Reworked naive IsAccessibleAs implementation to handle nested types.
5142 2008-02-05 Jb Evain <jbevain@novell.com>
5144 * class.cs: use generic type comparison for parameters
5147 2008-02-05 Marek Safar <marek.safar@gmail.com>
5149 A fix for bug #325372
5150 * class.cs: Use generic type comparison when testing method signatures.
5152 2008-02-05 Marek Safar <marek.safar@gmail.com>
5154 A fix for bug #357047
5155 * ecore.cs: Applied C# 3.0 changes to better conversion.
5157 2008-02-05 Marek Safar <marek.safar@gmail.com>
5159 A fix for bug #358374
5160 * cs-parser.jay: Correctly set modifiers for all constructor types.
5162 2008-02-04 Marek Safar <marek.safar@gmail.com>
5164 A fix for bug #355251
5165 * generic.cs: Added base class constraint based type inference.
5167 2008-02-01 Marek Safar <marek.safar@gmail.com>
5169 A fix for bug #357255
5170 * decl.cs: One more missing visibility check.
5172 2008-02-01 Marek Safar <marek.safar@gmail.com>
5174 * support.cs: Fixed broken return.
5176 2008-01-25 Marek Safar <marek.safar@gmail.com>
5178 * report.cs: Correctly reset warnings count after probing.
5180 2008-01-25 Martin Baulig <martin@ximian.com>
5183 (NamespaceEntry.SymbolFileID): Make this work again after
5184 MemberName.ToString() is gone.
5186 2008-01-25 Marek Safar <marek.safar@gmail.com>
5188 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5191 2008-01-25 Marek Safar <marek.safar@gmail.com>
5193 * generic.cs: Use full implicit conversion for type inference fixing.
5195 2008-01-24 Marek Safar <marek.safar@gmail.com>
5197 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5198 Fixed user operator conversions.
5200 2008-01-24 Marek Safar <marek.safar@gmail.com>
5202 * generic.cs: Do nullable type to null comparison optimization during
5205 2008-01-24 Marek Safar <marek.safar@gmail.com>
5207 A fix for bug #355163
5208 * generic.cs: Enabled l-value resolve on nullable expressions.
5210 2008-01-24 Marek Safar <marek.safar@gmail.com>
5212 A fix for bug #353986
5213 * class.cs: Ingore static ctors with parameters for any further checks.
5215 2008-01-24 Marek Safar <marek.safar@gmail.com>
5217 A fix for bug #354310
5218 * namespace.cs: Removed redundant check.
5220 2008-01-24 Marek Safar <marek.safar@gmail.com>
5222 A fix for bug #354928
5223 * expression.cs: ElementInitializers can be resolved only once.
5225 2008-01-24 Marek Safar <marek.safar@gmail.com>
5227 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5228 Condition expressions.
5230 2008-01-23 Marek Safar <marek.safar@gmail.com>
5232 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5234 2008-01-22 Marek Safar <marek.safar@gmail.com>
5236 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5239 * generic.cs: Implemented coalesce expression.
5241 2008-01-22 Marek Safar <marek.safar@gmail.com>
5243 A fix for bug #355145
5244 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5245 expression tree type inference.
5247 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5250 * expression.cs (Binary.IsUnsignedType): Fix typo.
5252 2008-01-22 Marek Safar <marek.safar@gmail.com>
5254 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5256 2008-01-22 Marek Safar <marek.safar@gmail.com>
5258 A fix for bug #355161
5259 * ecore.cs, expression.cs: Wider range of extension method supported
5262 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5264 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5265 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5268 2008-01-22 Marek Safar <marek.safar@gmail.com>
5270 A fix for bug #355148
5271 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5273 2008-01-22 Miguel de Icaza <miguel@novell.com>
5275 * expression.cs (CreateExpressionTree): Add support for or and
5276 logical or, and indent following the coding conventions.
5278 * typemanager.cs (LinqExpression): renamed from
5279 ExpressionTreeManager, for a shorter name.
5281 Use TypeManager.CoreLookupType to lookup types from our core
5282 assemblies and turn those into "Type" variables.
5284 Consumers that previously used "Namespace" and "Type" from this
5285 class should instead use the TypeExpression which is a type that
5286 is fully resolved (without involving the regular C# resolution
5289 This typically looks like this:
5291 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5292 new MemberAccess (texpr, name, type_arguments, loc)
5294 This avoids the problem in: #355178
5296 2008-01-21 Marek Safar <marek.safar@gmail.com>
5298 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5299 feature in parser only as we do in other cases.
5301 2008-01-21 Marek Safar <marek.safar@gmail.com>
5303 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5304 typemanager.cs: A refactoring of params arguments to reuse existing
5305 expressions (params -> array initializer) to emit params argument instead
5306 of specialized handling.
5307 It was required by expression tree implementation and it has other benefits
5308 as well, we now apply same optimization for params arguments as we do for
5311 2008-01-18 Marek Safar <marek.safar@gmail.com>
5313 A fix for bug #353526
5314 * generic.cs: A type inference of params arguments may not required any
5315 temporary array creation.
5317 2008-01-18 Marek Safar <marek.safar@gmail.com>
5319 A fix for bug #353534
5320 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5321 supported for delegates only.
5323 2008-01-18 Marek Safar <marek.safar@gmail.com>
5325 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5326 type for more than 1 candidates.
5328 2008-01-18 Marek Safar <marek.safar@gmail.com>
5330 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5333 2008-01-16 Marek Safar <marek.safar@gmail.com>
5335 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5336 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5337 operator) expressions.
5339 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5341 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5342 not accessed from the generated IL.
5344 2008-01-14 Marek Safar <marek.safar@gmail.com>
5346 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5347 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5348 statement.cs: The first expression tree implementation drop, mostly
5349 infrastructure work.
5351 2008-01-14 Marek Safar <marek.safar@gmail.com>
5353 * ecore.cs (IsNestedChild): Refactored.
5355 2008-01-11 Marek Safar <marek.safar@gmail.com>
5357 * lambda.cs: Don't use a cast on unknown expression statement.
5359 2008-01-10 Geoff Norton <gnorton@novell.com>
5361 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5364 2008-01-09 Marek Safar <marek.safar@gmail.com>
5366 * doc.cs: Report better /doc crash details.
5368 2008-01-09 Marek Safar <marek.safar@gmail.com>
5370 A fix for bug #352536
5371 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5373 2008-01-08 Marek Safar <marek.safar@gmail.com>
5375 A fix for bug #352287
5376 * ecore.cs, expression.cs: Do `this' access checking in all member access
5379 2008-01-08 Marek Safar <marek.safar@gmail.com>
5381 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5383 * report.cs: Reset message stacks.
5385 2008-01-08 Marek Safar <marek.safar@gmail.com>
5387 * generic.cs (InferInPhases): Correctly calculate params position.
5389 2008-01-08 Marek Safar <marek.safar@gmail.com>
5391 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5394 2008-01-07 Marek Safar <marek.safar@gmail.com>
5396 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5398 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5400 * driver.cs: Updated --help option.
5402 2008-01-07 Marek Safar <marek.safar@gmail.com>
5404 * generic.cs (InferParamsTypeArguments): Removed.
5405 (InferInPhases): Add params type inference.
5406 (LowerBoundInference): Fixed scoring mechanism.
5408 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5410 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5412 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5413 byte array for unsigned "baked" assemblies.
5415 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5417 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5418 array for assemblies that are not strongnamed.
5420 2008-01-04 Marek Safar <marek.safar@gmail.com>
5422 A fix for bug #351481
5423 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5424 declaring type for nested generic types.
5426 2008-01-04 Marek Safar <marek.safar@gmail.com>
5428 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5429 instead of ToString.
5431 2008-01-03 Marek Safar <marek.safar@gmail.com>
5433 A fix for bug #351047
5434 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5435 null and structs only when equality and inequality operators are defined
5436 either as an user-operators or predefined operators.
5438 2008-01-03 Marek Safar <marek.safar@gmail.com>
5440 A fix for bug #351047
5441 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5443 2008-01-03 Marek Safar <marek.safar@gmail.com>
5445 A fix for bug #351257
5446 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5448 2008-01-03 Marek Safar <marek.safar@gmail.com>
5450 A fix for bug #351157
5451 * class.cs (Using): Fixed yet another broken cloning.
5453 (Block): Put back more sensible default value for statements.
5455 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5457 * codegen.cs: Allow AssemblyVersion with only major version component.
5460 2007-12-29 Marek Safar <marek.safar@gmail.com>
5462 A fix for bug #324654
5463 * class.cs: Use FullName property as member name.
5465 2007-12-28 Marek Safar <marek.safar@gmail.com>
5467 A fix for bug #342117
5468 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5469 constructor constraint.
5471 2007-12-28 Marek Safar <marek.safar@gmail.com>
5473 A fix for bug #338273
5474 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5477 2007-12-28 Marek Safar <marek.safar@gmail.com>
5479 A fix for bug #350839
5480 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5482 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5484 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5487 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5489 * statement.cs: Changed some Hashtables to use HybridDictionaries
5490 instead. It was observed that some HashTables only contained a few
5491 items in the vast majority of cases. Since HybridDictionary is
5492 more efficient on small sets (<10 elements), "known_variables"
5493 from class ExplicitBlock as well as "labels" and "constants " from
5494 class Block were changed to HybridDictionaries.
5496 Atsai results: (56216kb->54987kb)
5498 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5501 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5503 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5506 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5508 * expression.cs: foreach loop to for loop, saved on allocation of
5509 enumerator (59333kb->59141kb)
5511 * statement.cs. Changed foreach loops to for loops, saved on
5512 allocation of enumerator (59141kb->59006kb)
5514 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5515 when constructed with no specified capacity. This was causing a
5516 few ArrayLists to allocate more memory than they would potentially
5517 need in the Block class and MemberCache class. Setting the
5518 ArrayLists to construct with a capacity of 1 saves some
5519 memory. (56216kb->55585kb)
5521 2007-12-27 Marek Safar <marek.safar@gmail.com>
5523 A fix for bug #347189 (2nd issue)
5524 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5527 2007-12-27 Miguel de Icaza <miguel@novell.com>
5529 * report.cs: Do not use colors if stdout and stderr are not a
5532 2007-12-27 Marek Safar <marek.safar@gmail.com>
5534 A fix for bug #346998
5535 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5538 2007-12-27 Marek Safar <marek.safar@gmail.com>
5540 A fix for bug #343465
5541 * class.cs: Explicit method name for nested types uses dots only.
5543 2007-12-27 Marek Safar <marek.safar@gmail.com>
5545 A fix for bug #343707
5546 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5548 2007-12-27 Marek Safar <marek.safar@gmail.com>
5550 * ecore.cs: Report type inference errors only when arguments count matches
5553 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5555 * expression.cs, report.cs: New warning.
5557 * typemanager.cs: Catch anonymous method type too.
5559 2007-12-23 Marek Safar <marek.safar@gmail.com>
5561 A fix for bug #346379
5562 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5564 2007-12-23 Marek Safar <marek.safar@gmail.com>
5566 A fix for bug #347359
5567 * expression.cs (Invocation): Don't resolve already resolved expression.
5569 2007-12-23 Marek Safar <marek.safar@gmail.com>
5571 A fix for bug #347189
5572 * class.cs (FixedField): Use non-dependent code only in the define phase.
5574 2007-12-23 Marek Safar <marek.safar@gmail.com>
5576 A fix for bug #348076
5577 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5579 2007-12-22 Marek Safar <marek.safar@gmail.com>
5581 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5582 discovered extension methods.
5584 2007-12-22 Marek Safar <marek.safar@gmail.com>
5586 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5589 2007-12-21 Miguel de Icaza <miguel@novell.com>
5591 * report.cs (ErrorMessage): Add support for using colors on
5592 terminals that support it.
5594 2007-12-21 Marek Safar <marek.safar@gmail.com>
5596 * ecore.cs: Use information about expanded params for error reporting.
5598 2007-12-21 Marek Safar <marek.safar@gmail.com>
5600 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5601 and logic for params overloads.
5603 2007-12-15 Miguel de Icaza <miguel@novell.com>
5605 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5606 as this is also created from the parser. Fixes #349034
5608 2007-12-12 Miguel de Icaza <miguel@novell.com>
5610 * statement.cs (Throw.CloneTo): it is valid to have empty
5611 expressions for throw.
5613 2007-12-03 Marek Safar <marek.safar@gmail.com>
5615 * cs-parser.jay: Set delegate constraint parsing region correctly.
5617 2007-12-03 Marek Safar <marek.safar@gmail.com>
5619 A fix for bug #345467
5620 * typemanager.cs (IsEqual): Compare generic parameters position only.
5622 2007-11-28 Marek Safar <marek.safar@gmail.com>
5624 * expression.cs (BaseAccess): Type arguments can be null.
5626 2007-11-27 Raja R Harinath <harinath@gmail.com>
5628 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5629 consistent even when an error has occured.
5630 (Switch.Resolve): Likewise.
5632 2007-11-22 Marek Safar <marek.safar@gmail.com>
5634 A fix for bug #334505
5635 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5638 2007-11-22 Marek Safar <marek.safar@gmail.com>
5640 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5641 refactorings required to resolve extension methods correctly when mixing
5642 generics and non-generics members.
5644 2007-11-20 Marek Safar <marek.safar@gmail.com>
5646 A fix for bug #342584
5647 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5650 2007-11-19 Marek Safar <marek.safar@gmail.com>
5652 A fix for bug #342512
5653 * delegate.cs: Use delegate argument expression when is available. Don't
5654 emit virtual call when class is sealed.
5656 2007-11-16 Marek Safar <marek.safar@gmail.com>
5658 A fix for bug #325423
5659 * assign.cs (FieldInitializer): Use resolved expression for emit.
5661 * class.cs: Print less confusing error message.
5663 2007-11-16 Marek Safar <marek.safar@gmail.com>
5665 * cs-tokenizer.cs: Removed GMCS ifdefs.
5667 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5670 * cs-parser.jay: Disabled nullable check.
5672 * generic-mcs: Copied more generic stuff.
5674 2007-11-16 Marek Safar <marek.safar@gmail.com>
5676 * gcs-parser.jay: Merged to cs-parser.jay.
5678 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5679 * *.csproj, *.sources: Updated to use only jay parser file.
5681 2007-11-16 Marek Safar <marek.safar@gmail.com>
5683 * gcs-parser.jay: Added nullable and default expression feature checks.
5685 2007-11-16 Marek Safar <marek.safar@gmail.com>
5687 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5688 it fixes many TODOs and hidden bugs.
5690 * expression: Removed duplicate error check.
5692 2007-11-15 Marek Safar <marek.safar@gmail.com>
5694 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5695 implicitly type local variable only when it is used in a declaration.
5697 2007-11-15 Marek Safar <marek.safar@gmail.com>
5699 * attribute.cs: Use CS0612 for empty strings.
5701 2007-11-14 Marek Safar <marek.safar@gmail.com>
5703 * lambda.cs, statement.cs: Contextual return may act as a statement.
5705 2007-11-14 Marek Safar <marek.safar@gmail.com>
5707 A fix for a regression cause by #324222
5708 * class.cs: Don't report unused even when it implements an interface.
5710 2007-11-13 Marek Safar <marek.safar@gmail.com>
5712 A fix for bug #341205
5713 * ecore.cs, expression.cs: Method group expression cannot do static
5714 method access with an instance reference check before overloading takes
5717 2007-11-13 Marek Safar <marek.safar@gmail.com>
5719 A fix for bug #325359
5720 * class.cs: Use predictable name for automatically generated property.
5722 2007-11-12 Marek Safar <marek.safar@gmail.com>
5724 A fix for bug #324996
5725 * expression.cs (Is): Handle case where D is nullable and T is not
5728 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5730 2007-11-12 Marek Safar <marek.safar@gmail.com>
5732 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5733 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5734 Flush small error reporting changes.
5736 2007-11-09 Marek Safar <marek.safar@gmail.com>
5738 A fix for bug #324996
5739 * expression.cs: Rewrote Is expression implementation to work with
5740 generics, nullable types, anonymous method. A const result expression
5741 uses existing infrastructure instead of custom not fully-featured one.
5743 2007-11-08 Marek Safar <marek.safar@gmail.com>
5745 A fix for bug #340202
5746 * class.cs: Consider generics for volatile field.
5748 2007-11-08 Marek Safar <marek.safar@gmail.com>
5750 A fix for bug #335594
5751 * expression.cs: Use conversion rules when handling string addition.
5753 2007-11-07 Marek Safar <marek.safar@gmail.com>
5755 A fix for bug #336651
5756 * expression.cs: Fixed a crash when probing is on.
5758 2007-11-07 Marek Safar <marek.safar@gmail.com>
5760 A fix for bug #324242
5761 * covert.cs: Added a conversion from any nullable-type with an
5762 underlying enum-type to the type System.Enum.
5764 2007-11-07 Marek Safar <marek.safar@gmail.com>
5766 A fix for bug #324222
5767 * class.cs: Report all non-used event fields.
5769 2007-11-07 Marek Safar <marek.safar@gmail.com>
5771 A fix for bug #325161
5772 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5773 qualifier for generic types.
5775 2007-11-07 Marek Safar <marek.safar@gmail.com>
5777 A fix for bug #322971
5778 * expression.cs, ecore.cs: Added intermediate result value check for
5781 2007-11-07 Marek Safar <marek.safar@gmail.com>
5783 A fix for bug #324754
5784 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5785 when it was requested.
5787 2007-11-07 Marek Safar <marek.safar@gmail.com>
5789 A fix for bug #325101
5790 * expression.cs: Do type not value comparison for `is' expression.
5792 2007-11-07 Marek Safar <marek.safar@gmail.com>
5794 A fix for bug #320236
5795 * convert.cs: Don't apply user conversion on underlying target type.
5797 2007-11-06 Marek Safar <marek.safar@gmail.com>
5799 * expression.cs: Don't use unresolved expression for error reporting.
5801 2007-11-06 Marek Safar <marek.safar@gmail.com>
5803 A fix for bugs #337712, #324490
5804 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5805 overloading resolution too.
5807 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5808 the process consistent and more robust.
5810 * expression.cs, linq.cs, report.cs: Update.
5812 2007-11-02 Marek Safar <marek.safar@gmail.com>
5814 A fix for bug #332909
5815 * attribute.cs: Resolve attributes in correct context using error
5818 * rootcontext.cs: Define Obsolete attribute members as core members.
5820 2007-11-02 Marek Safar <marek.safar@gmail.com>
5822 * statement.cs: Removed unused methods.
5824 2007-10-31 Wade Berrier <wberrier@novell.com>
5826 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5827 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5830 2007-10-31 Marek Safar <marek.safar@gmail.com>
5832 A fix for bug #338102
5833 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5834 methods registered as non-generics.
5836 2007-10-31 Marek Safar <marek.safar@gmail.com>
5838 A fix for bugs #337712, #324490
5839 * delegate.cs: Delegate covariance and contravariance is not allowed for
5842 2007-10-31 Marek Safar <marek.safar@gmail.com>
5844 A fix for bug #337719
5845 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5848 2007-10-30 Marek Safar <marek.safar@gmail.com>
5850 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5852 2007-10-29 Marek Safar <marek.safar@gmail.com>
5854 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5857 2007-10-29 Raja R Harinath <rharinath@novell.com>
5859 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5861 2007-10-29 Marek Safar <marek.safar@gmail.com>
5863 A fix for bug #334652
5864 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5865 extension methods when we have not found the best candidate in normal
5868 2007-10-27 Marek Safar <marek.safar@gmail.com>
5870 * AssemblyInfo.cs: Keep up-to-date.
5872 2007-10-27 Marek Safar <marek.safar@gmail.com>
5874 * Makefile: Fixed generics compiler name.
5876 2007-10-27 Marek Safar <marek.safar@gmail.com>
5878 * lambda.test: removed, lambda parsing is done differently.
5880 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5882 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5884 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5886 2007-10-27 Marek Safar <marek.safar@gmail.com>
5888 * Makefile, *.sources : All C# compilers are in mcs folder.
5890 * *.cs: Use existing 2_1 define for smcs.
5892 2007-10-26 Marek Safar <marek.safar@gmail.com>
5894 A fix for bug #335847
5895 * assign.cs, expression.cs: Couple of changes to avoid creating a
5896 temporary variable for each object initializer assignment statement. It
5897 simplifies struct initialization too, otherwise two temporary variables
5899 Implemented optimization of redundant default element initializers.
5901 2007-10-25 Marek Safar <marek.safar@gmail.com>
5903 A fix for bug #336766
5904 * expression.cs (Class.CheckBase): Use generic name when method is
5907 2007-10-25 Marek Safar <marek.safar@gmail.com>
5909 A fix for bug #334737
5910 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5911 variable and not variable argument for prepared copies.
5913 2007-10-24 Marek Safar <marek.safar@gmail.com>
5915 A fix for bug #325110
5916 * class.cs, expression.cs, attribute.cs: Use open generic method when
5917 checking conditional attribute.
5919 2007-10-24 Marek Safar <marek.safar@gmail.com>
5921 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5922 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5923 FeatureIsNotAvailable.
5925 2007-10-24 Marek Safar <marek.safar@gmail.com>
5927 ** C# 3.0 Partial methods
5929 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5930 methods support. Because of member cache issue with generics only
5931 non-generics partial methods are fully supported.
5933 2007-10-23 Marek Safar <marek.safar@gmail.com>
5935 * class.cs, decl.cs: Rewrote member overloads check to cope with
5936 generics and to use member cache for member checking. It also improves
5937 performance and fixes remaining overloads issues.
5939 2007-10-20 Marek Safar <marek.safar@gmail.com>
5941 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5942 roottypes.cs, typemanager.cs:
5944 A member cache creation logic changed to add members immediately and
5945 not rely on fallback. The member cache is now only prefered way
5946 how to access and find type declaration members. It saves 5 MB of memory
5947 during MWF compilation and makes code ready for more optimizations and
5948 clean-ups, it's also a pre-requirement for partial methods.
5950 2007-10-18 Raja R Harinath <harinath@gmail.com>
5952 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5953 handling for generic parameters.
5955 2007-10-15 Marek Safar <marek.safar@gmail.com>
5957 * class.cs (FixedField): Removed redundant volatile check.
5959 2007-10-15 Marek Safar <marek.safar@gmail.com>
5961 * class.cs, decl.cs: Fixed overload members verification to do only one
5962 check per possible collision.
5964 2007-10-13 Marek Safar <marek.safar@gmail.com>
5966 A fix for bug #325478
5967 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5968 and create only one disposable flags container.
5970 2007-10-12 Marek Safar <marek.safar@gmail.com>
5972 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5973 * statement.cs (Fixed): Fixed variables cloning.
5975 2007-10-12 Marek Safar <marek.safar@gmail.com>
5977 A fix for bug #333342
5978 * class.cs (EventField): Don't mark value type event as synchronized.
5980 2007-10-12 Marek Safar <marek.safar@gmail.com>
5982 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5983 inference to identify best candidate method correctly.
5984 (ProperyExpr): A range variable is read only and cannot be modified.
5986 2007-10-11 Marek Safar <marek.safar@gmail.com>
5988 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5989 logic to identify best candidate method correctly.
5991 2007-10-11 Marek Safar <marek.safar@gmail.com>
5993 * location.cs (Equals, GetHashCode): Removed.
5995 2007-10-11 Marek Safar <marek.safar@gmail.com>
5997 * report.cs: Implemented message recorder. It is used mainly for lambda
5998 expressions to capture otherwise swallowed error messages.
6000 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6002 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6004 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6006 * expression.cs (MemberAccess): Always report lookup failure.
6008 * location.cs: Implemented Equals, GetHashCode.
6010 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6012 2007-10-10 Jb Evain <jbevain@novell.com>
6014 * codegen.cs: re-enable assembly version check.
6016 2007-10-09 Marek Safar <marek.safar@gmail.com>
6018 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6021 * namespace.cs (UsingAlias): Do correct version check.
6023 2007-10-08 Marek Safar <marek.safar@gmail.com>
6025 * expresison.cs, ecore.cs: Issue extension method error message when
6028 * rootcontext.cs: Added ISO_2 compiler mode option.
6030 2007-10-08 Marek Safar <marek.safar@gmail.com>
6032 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6035 2007-10-08 Marek Safar <marek.safar@gmail.com>
6037 * attribute.cs (GetString, GetBoolean): Work with both literal and
6040 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6041 Moved method overload specific methods to MethodGroupExpr.
6043 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6044 it should be less memory consuming.
6046 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6048 * codegen.cs: remove the assembly version check until the buildbot is
6051 2007-10-07 Jb Evain <jbevain@novell.com>
6053 * attribute.cs (Attribute.GetString): if the value
6054 expression is a StringConstant, return its string value.
6056 2007-10-07 Jb Evain <jbevain@novell.com>
6058 * typemanager.cs: add `assembly_version_attribute_type`.
6059 * codegen.cs: on attribute emission, check that the
6060 AssemblyVersionAttribute doesn't overflow.
6062 2007-10-05 Marek Safar <marek.safar@gmail.com>
6064 A fix for bug #324677
6065 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6066 parent container of a scope container with currently resolved one.
6068 2007-10-05 Marek Safar <marek.safar@gmail.com>
6070 A fix for bug #325534
6071 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6074 2007-10-05 Marek Safar <marek.safar@gmail.com>
6076 A fix for bug #327504
6077 * class.cs (Operator.Define): Refactored implicit and explicit user
6078 operator conversion rules.
6080 2007-10-05 Marek Safar <marek.safar@gmail.com>
6082 A fix for bug #327520
6083 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6085 2007-10-04 Marek Safar <marek.safar@gmail.com>
6087 A fix for bug #328022
6088 * class.cs (MethodData.Define): Use correct method to check whether
6089 a method implementents an accessor.
6091 2007-10-04 Marek Safar <marek.safar@gmail.com>
6093 A fix for bug #330069
6094 * statement.cs (Fixed.Resolve): Read the first array element only when
6095 an array is instantiated.
6097 2007-10-04 Marek Safar <marek.safar@gmail.com>
6099 * expression.cs, assign.cs, generics.cs: Print correct operator when
6100 compound assignment is used.
6102 2007-10-04 Marek Safar <marek.safar@gmail.com>
6104 A fix for bug #325841
6105 * expression.cs (ArrayAccess): Use full argument cloning only for
6106 string compound concatenation.
6108 2007-10-03 Marek Safar <marek.safar@gmail.com>
6110 A fix for bug #328774
6111 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6113 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6116 2007-10-03 Raja R Harinath <rharinath@novell.com>
6119 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6120 Event accessibility checks here. Remove some bogus code that
6121 accidently made GenericMethods work.
6122 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6124 2007-09-25 Marek Safar <marek.safar@gmail.com>
6126 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6128 * statement.cs (Block): Refactored AddVariable to allow error handling
6131 * generic.cs: New stub.
6133 2007-09-23 Marek Safar <marek.safar@gmail.com>
6135 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6138 2007-09-17 Marek Safar <marek.safar@gmail.com>
6140 * class.cs: Use partial container to record whether any partial part
6141 contains static field initializer and therefore default contructor has
6144 2007-09-14 Marek Safar <marek.safar@gmail.com>
6146 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6147 mono-list when only one of two partial parts has defined accessibility
6150 2007-09-14 Marek Safar <marek.safar@gmail.com>
6152 A fix for bug #82845
6154 * class.cs (TypeContainer): Set correct resolve context for all field
6157 2007-09-13 Marek Safar <marek.safar@gmail.com>
6159 * assign.cs: Fixed a crash when field is resolved twice with an error.
6161 * codegen.cs: Changed InFieldInitializer to be flag.
6163 * anonymous.cs, ecore.cs, expression.cs: Update after
6164 IsInFieldInitializer rename.
6166 * const.cs: Removed unused parameter.
6168 * class.cs: Changed the way how we resolve and emit field initializers.
6169 The field initilizers have to have access to contructor block to emit
6170 compiler generated code.
6172 2007-09-13 Marek Safar <marek.safar@gmail.com>
6174 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6175 generics use TypeContainer instead.
6177 2007-09-12 Marek Safar <marek.safar@gmail.com>
6179 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6181 * lambda.cs (ResolveParameters): Use more powerful
6182 InflateGenericArgument.
6184 * parameters.cs: Better exception message.
6186 2007-09-10 Marek Safar <marek.safar@gmail.com>
6188 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6189 correct expression block type.
6191 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6193 * expression.cs (Invocation): Extracted method group resolve to
6196 2007-09-07 Marek Safar <marek.safar@gmail.com>
6198 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6199 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6201 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6202 generic extension methods.
6204 2007-09-06 Marek Safar <marek.safar@gmail.com>
6206 A fix for bug #82676 (Do I get it right now?)
6207 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6208 object before a standard conversion is applied.
6210 2007-09-06 Marek Safar <marek.safar@gmail.com>
6212 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6215 2007-09-05 Marek Safar <marek.safar@gmail.com>
6217 A fix for bug #82676
6218 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6219 non-generic interface types.
6221 2007-09-05 Marek Safar <marek.safar@gmail.com>
6223 A fix for bug #82690
6224 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6226 2007-09-05 Marek Safar <marek.safar@gmail.com>
6228 A fix for bug #82571
6229 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6230 modifier for container based methods.
6232 2007-09-05 Marek Safar <marek.safar@gmail.com>
6234 A fix for bug #82676
6235 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6236 any interface-type T means to any of interface type T.
6238 2007-09-04 Marek Safar <marek.safar@gmail.com>
6240 * namespace.cs: We have 2 versions of System.Core assembly.
6242 2007-09-04 Marek Safar <marek.safar@gmail.com>
6244 A fix for bug #82652
6245 * class.cs (Class.GetClassBases): Compare types and not expressions.
6247 2007-09-04 Marek Safar <marek.safar@gmail.com>
6249 A fix for bug #82620
6250 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6251 actually never worked before.
6252 (IndexerAccess): Emit prepared arguments before they are modified.
6254 2007-09-04 Marek Safar <marek.safar@gmail.com>
6256 A fix for bug #82563
6257 * assign.cs: Revert wrong fix.
6259 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6261 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6262 Instead of ldelema/stdind we have to use temporary variables to handle
6263 cases like String.Concat (params string[]).
6265 2007-08-31 Marek Safar <marek.safar@gmail.com>
6267 * class.cs: EmitAttributes to Emit rename.
6269 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6271 (MemberCore.HasClsCompliantAttribute): Don't depend on
6272 GetClsCompliantAttributeValue execution.
6274 2007-08-31 Marek Safar <marek.safar@gmail.com>
6276 * anonymous.cs: Use shorter type prefix.
6278 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6281 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6282 variables when probing is on.
6284 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6285 unresolved variables.
6286 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6287 handle transparent identifiers.
6289 2007-08-26 Marek Safar <marek.safar@gmail.com>
6291 * attribute.cs (IsClsCompliant): Add nullable types test.
6293 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6295 * doc.cs : catch other types of exception than XmlException to
6296 report CS1570. Fixed bug #82565.
6298 2007-08-23 Marek Safar <marek.safar@gmail.com>
6300 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6301 The number of delegate parameters has to match.
6302 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6305 2007-08-21 Marek Safar <marek.safar@gmail.com>
6307 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6308 to fix problem with private arguments.
6310 2007-08-20 Marek Safar <marek.safar@gmail.com>
6312 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6314 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6316 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6317 empty. Add cloning suport.
6319 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6321 2007-08-20 Marek Safar <marek.safar@gmail.com>
6323 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6324 to create EmptyCast. It handles EmptyConstantCast specialization for
6327 2007-08-18 Marek Safar <marek.safar@gmail.com>
6329 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6330 (EmitArrayArgument): One routine for array arguments.
6331 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6333 2007-08-17 Marek Safar <marek.safar@gmail.com>
6335 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6337 2007-08-17 Marek Safar <marek.safar@gmail.com>
6339 * anonymous.cs: MemberLookupFinal update.
6341 * class.cs (ConstructorInitializer): Is expression based.
6343 * delegate.cs: MethodGroupExpr update.
6345 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6347 (Error_MemberLookupFailed): Customizable error override.
6348 (MethodGroupExpr): Keep queried type for later usage.
6349 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6352 * expression.cs: Error_MemberLookupFailed refactoring.
6353 (New.DoResolve): Resolve as much as possible.
6354 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6355 customization for invalid member types.
6357 * statement.cs: MethodGroupExpr update.
6359 2007-08-16 Marek Safar <marek.safar@gmail.com>
6361 * modifier.cs (Check): Check all modifiers and not only accessibility
6364 2007-08-16 Marek Safar <marek.safar@gmail.com>
6366 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6367 type and not an expression.
6369 2007-08-16 Marek Safar <marek.safar@gmail.com>
6371 * statement.cs (Catch.Clone): Type and variable can be null.
6373 2007-08-16 Marek Safar <marek.safar@gmail.com>
6375 A fix for bug #81979
6376 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6377 I am really not sure whether this is the best fix.
6379 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6382 2007-08-14 Marek Safar <marek.safar@gmail.com>
6384 ** C# 3.0 Object and collection initializers (major re-write)
6386 * assign.cs (DoResolve): Initializers are not assign related.
6388 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6389 used during collection or object initialization.
6391 * expression.cs (Error_InvalidArguments): Add initializers specific
6392 messages. More will come later because it requires some general
6394 (New.DoResolve): Better error handling for unsafe types.
6395 (EmptyExpressionStatement): New class.
6396 (ElementInitializer): An object initializer expression.
6397 (CollectionElementInitializer): A collection initializer expression.
6398 (CollectionOrObjectInitializers): A block of object or collection
6400 (NewInitialize): New expression with element/object initializers.
6402 * statement.cs: Reverted object/collection initializer hacks.
6404 * typemanager.cs (CSharpName): Filter __arglist type.
6406 2007-08-09 Marek Safar <marek.safar@gmail.com>
6408 ** C# 3.0 Anonymous Types (update to the latest standard)
6410 * expression.cs (Binary.ResolveOperator): Threat all null based types
6412 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6413 (AnonymousTypeParameter): Updated.
6415 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6416 (AnonymousTypeClass): New anonymous type container.
6418 * class.cs (AddField): Return operation result.
6420 * generic.cs: Another empty TypeArguments overload.
6422 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6423 are stored at top of normal hierarchy.
6425 * typemanager.cs (CSharpName): Filter anonymous types.
6427 2007-08-09 Marek Safar <marek.safar@gmail.com>
6429 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6430 as single Concat call. How could we miss that :-(
6432 2007-08-08 Marek Safar <marek.safar@gmail.com>
6434 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6436 2007-08-07 Miguel de Icaza <miguel@novell.com>
6438 * expression.cs: Fix the previous commit, the creation of the
6439 arguments array list needs also to be conditional on the arguments
6442 * class.cs: Add a little bit of help to help narrow down problems.
6444 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6445 not try to copy in that case.
6447 * driver.cs: When building SMCS, include a new different set of
6448 default assemblies here. Do this here so we can control whether
6449 to include the default assemblies with /noconfig.
6451 2007-08-03 Marek Safar <marek.safar@gmail.com>
6453 A fix for bug #81979
6454 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6457 2007-08-03 Marek Safar <marek.safar@gmail.com>
6459 A fix for bug #82300
6461 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6462 we are in probing scope.
6464 2007-08-03 Marek Safar <marek.safar@gmail.com>
6466 A fix for bug #82301
6468 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6469 (Statement.CloneTo): Clone and not map children blocks.
6471 2007-08-03 Marek Safar <marek.safar@gmail.com>
6473 A fix for bug #82299
6475 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6478 * statement.cs (Statement.CloneTo): Clone variables before statements
6479 to allow remaping of local variables.
6481 2007-08-03 Marek Safar <marek.safar@gmail.com>
6483 A fix for bug #82296
6486 * report.cs: Log crash details for future clone problems.
6488 * statement.cs (Return.Clone): Don't clone non-existent expression.
6490 2007-08-03 Raja R Harinath <harinath@gmail.com>
6492 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6493 (Class.AddBasesForPart): Move CS0537 check here from ...
6494 * cs-parser.jay (class_declaration): ... here. Move calling of
6495 'AddBasesForPart' to ...
6496 (class_bases): ... here.
6497 (struct_declaration, interface_declaration): Update to changes.
6499 2007-08-02 Marek Safar <marek.safar@gmail.com>
6501 A fix for bug #81923
6503 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6504 conversion is allowed.
6506 2007-08-02 Marek Safar <marek.safar@gmail.com>
6508 A fix for bug #81564
6510 * ecore.cs (EventExpr): Add IsBase handling.
6512 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6515 2007-08-02 Raja R Harinath <harinath@gmail.com>
6517 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6518 * cs-parser.jay: Some whitespace cleanups.
6519 (current_delegate): New.
6521 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6522 a dummy code block, and use 'type_name' instead of 'member_name'.
6523 (interface_declaration, class_declaration): Likewise.
6524 (delegate_declaration): Likewise. Rearrange slightly and use
6526 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6527 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6529 2007-08-02 Marek Safar <marek.safar@gmail.com>
6531 A fix for bug #82039
6533 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6536 * typemanager.cs (CSharpName): Split to string overload.
6538 2007-08-02 Marek Safar <marek.safar@gmail.com>
6541 * report.cs: Updated warning CS0472.
6543 2007-08-01 Marek Safar <marek.safar@gmail.com>
6545 A fix for bug #82181
6547 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6549 2007-08-01 Marek Safar <marek.safar@gmail.com>
6551 A fix for bug #82277
6552 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6554 2007-08-01 Marek Safar <marek.safar@gmail.com>
6556 ** C# 3.0 Type Inference (major bits are working)
6558 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6559 (.ImplicitStandardConversionExists): Uses compatible.
6560 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6561 (.InferReturnType): New method.
6562 (.Compatible): Refactored.
6563 (.ResolveParameters): Uses factory to create resolved parameters.
6564 (.CompatibleMethod): Add probing mode support.
6565 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6566 clearly distinguish between 2 different operations.
6567 (LambdaMethod): Moved to lambda.cs.
6568 (AnonymousMethod): Removed unused fields and methods.
6569 (AnonymousDelegate): Simplified.
6571 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6573 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6575 * delegate.cs (Delegate): New mehods to reduce code duplication.
6576 (.GetConstructor): New method.
6577 (.GetInvokeMethod): New method.
6578 (DelegateCreation): Updated.
6580 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6582 (OverloadResolve): Made probing little bit faster.
6584 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6587 * generic.cs (TypeInferenceContext): Dummy implementation.
6589 * iterators.cs: Updated after Resolve/Define rename.
6591 * lambda.cs (LambdaExpression)
6592 (.ResolveParameters): Handles both type of arguments and type inference too.
6594 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6595 (InflateTypes): Updated.
6597 * support.cs (InflateTypes): Changed signature and updated.
6599 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6600 (MemberLookup_FindMembers): More MS tricks.
6601 (GetParameterData): Ditto.
6602 (GetDelegateParameters): Uses quick path for dynamic types.
6604 2007-08-01 Marek Safar <marek.safar@gmail.com>
6606 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6609 2007-07-31 Marek Safar <marek.safar@gmail.com>
6611 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6614 2007-07-26 Jb Evain <jbevain@novell.com>
6616 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6617 which takes a boolean 'report_errors', similar to the GetMethod.
6618 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6619 in .net 2.1, do not report errors here.
6621 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6622 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6623 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6626 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6627 of the type InternalsVisibleToAttribute before the first call
6628 to CoreLookupType which is allowed to fail (third boolean parameter
6629 to true). Because, during the resolution for a type that is not
6630 immediately found, we try to check if the type is not defined in
6631 a friend assembly, and to do so, we need the
6632 InternalVisibleToAttribute.
6634 2007-07-23 Miguel de Icaza <miguel@novell.com>
6636 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6637 feature that allows structs to be compared against null and inline
6638 the result as true or false.
6640 Notice that the same code is not permitted inside a generic block
6641 of code that would do:
6643 class Foo<T> where T : struct {
6650 It is only allowed if the type of T is not bound (no where
6651 clause). In my opinion, this CSC 2 behavior is broken but people
6652 seem to be using it (IronRuby does, a few bug reports on bugzilla
6653 have it and some people have complained about it).
6655 All of the users that depend on this behavior have code that is
6658 * report.cs (Warning, Error): make these take object arguments,
6659 not strings, as that allows us to take advantage of Format.
6661 2007-07-20 William Holmes <billholmes54@gmail.com>
6663 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6664 Left member variable for the Count.
6665 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6666 MemberName.CountTypeArguments to avoid a NRE.
6668 This code is contributed under the MIT X11 license
6670 2007-07-18 Marek Safar <marek.safar@gmail.com>
6672 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6674 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6676 * doc.cs : generic method arguments are written as ``x while generic
6677 type arguments are `x. Combined with the previous change, fixed bug
6680 2007-07-18 Raja R Harinath <rharinath@novell.com>
6683 * expression.cs (Binary.ResolveOperator): When converting
6684 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6686 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6688 * doc.cs : when T: or whatever x: is specified, it does not really
6689 check the doc comment's syntax correctness. Fixed bug #82006.
6691 2007-07-18 Marek Safar <marek.safar@gmail.com>
6693 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6694 LambdaExpression better.
6696 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6698 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6700 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6701 as it can be generated.
6703 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6706 * lambda.cs (LambdaExpression): Refactored to share same code with
6707 AnonymousMethodExpression.
6709 2007-07-17 Marek Safar <marek.safar@gmail.com>
6711 * anonymous.cs (MakeName): Include host name for easier debugging.
6712 (LambdaMethod): New class for lambda spcecific stuff.
6714 * attribute.cs: Set EmitContext return type.
6716 * class.cs: Set EmitContext return type.
6718 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6719 with null/void meaning.
6721 * iterators.cs (ContainerType): Implemented.
6723 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6725 * statement.cs (Return): Updated to lambda expressions.
6726 (Block.CloneTo): Parent can be null.
6728 2007-07-13 Marek Safar <marek.safar@gmail.com>
6730 A fix for bug #81917
6731 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6733 * class.cs (FixedField): Check whether field is in unsafe scope.
6735 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6736 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6738 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6741 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6743 2007-07-13 Marek Safar <marek.safar@gmail.com>
6745 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6746 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6749 2007-07-13 Marek Safar <marek.safar@gmail.com>
6751 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6753 2007-07-13 Marek Safar <marek.safar@gmail.com>
6755 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6756 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6758 * codegen.cs(EmitContext): Add ProbingMode flag.
6760 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6762 * driver.cs: For now set both warning values.
6764 * ecore.cs (SimpleName): Name is readonly.
6765 (MethodGroup.OverloadResolve): One quick path for probing.
6767 * expression.cs (Unary): Set Oper r/o.
6768 (Binary): Set Oper r/o.
6769 (ParameterReference): Set few instance variables as r/o.
6770 (ParameterReference.DoResolveBase): Don't capture aruments when
6772 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6773 (Arglist): arguments are private.
6774 (SizeOf): type is private and r/o.
6775 (MemberAccess): arguments are private.
6777 * report.cs: Enhanced reporting on/off capabilities.
6779 * lambda.cs: Uses ec.IsInProbingMode.
6780 (ContextualReturn): Derives from return.
6782 * rootcontext.cs: For now set both warning values.
6784 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6786 (Return.Resolve): Don't die immediately.
6787 (Block.Resolve): Speed-up probing.
6788 (Block.CloneTo): Clone only child blocks.
6790 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6792 * iterators.cs: reverted Miguel's latest change (r81925) as it
6793 breaks the build in System.
6795 2007-07-13 Miguel de Icaza <miguel@novell.com>
6797 * iterators.cs (Yield.CheckContext): Check for the iterator type
6798 also here as we can call into Yield even in codepaths that are not
6800 (MethodOrOperator is the only path that was checked).
6802 In addition to the standard check, use a more specific check for
6803 constructors to report a more verbose error.
6805 2007-07-12 Miguel de Icaza <miguel@novell.com>
6807 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6808 report the warning and continue
6810 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6811 values on the stack on the call to Emit. Use EmitStatement if
6812 possible, or using Emit + Pop if not possible. Fixes #82064
6814 2007-07-12 Raja R Harinath <rharinath@novell.com>
6816 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6817 avoid try...finally in some cases.
6819 2007-07-10 Marek Safar <marek.safar@gmail.com>
6821 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6823 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6824 instead of method. Re-use standard error handling.
6825 (ConstructorInitializer.Emit): Simplified.
6827 * delegate.cs: Updated after Invocation.EmitCall change.
6829 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6830 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6831 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6832 method and don't permanently changing input arguments.
6833 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6834 is resolved it has one of the candidates is the best one which is later
6835 used to emit. Removed a few unused method.
6836 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6838 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6839 (Binary.ResolveOperator): Ditto.
6840 (ConditionalLogicalOperator.DoResolve): Ditto.
6841 (Invocation): Uses method group.
6842 (Invocation.DoResolve): Simplified.
6843 (Invocation.EmitCall): Removed useless is_static.
6844 (Invocation.Emit): Delegate to method group.
6845 (Invocation.EmitStatement): Simplified.
6846 (New): Uses method group.
6847 (MemberAccess.DoResolve): Don't destroy original expression.
6849 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6851 2007-07-04 Marek Safar <marek.safar@gmail.com>
6853 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6856 * lambda.cs: Add custom error message type.
6858 2007-07-03 Marek Safar <marek.safar@gmail.com>
6860 * lambda.cs: Simplified little bit.
6862 * parameter.cs: Introduced ImplicitLambdaParameter.
6863 (Parameters.CreateFullyResolved): New factory instead of ctor.
6867 * delegate.cs: Updated parameter creation.
6869 2007-07-03 Marek Safar <marek.safar@gmail.com>
6871 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6874 * generic.cs: Synchronized with gmcs.
6876 2007-07-03 Marek Safar <marek.safar@gmail.com>
6878 * class.cs (Indexer): Check return type as soon as possible.
6880 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6883 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6885 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6887 * parameter.cs (Parameter): Use expression type when it is available.
6889 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6890 method modifier for the first parameter only.
6892 2007-06-24 Marek Safar <marek.safar@gmail.com>
6894 A fix for bug #81938
6895 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6897 * constant.cs: Tide up an exception message.
6899 2007-06-22 Marek Safar <marek.safar@gmail.com>
6901 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6902 an uninitialized variable is used.
6904 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6906 2007-06-22 Marek Safar <marek.safar@gmail.com>
6908 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6909 not found error handling.
6911 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6913 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6914 (ArrayCreation.DoResolve): Simplified.
6915 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6916 its own resolve process.
6917 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6919 2007-06-20 Marek Safar <marek.safar@gmail.com>
6921 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6924 2007-06-20 Marek Safar <marek.safar@gmail.com>
6926 * cs-tokenizer.cs: Removed var related stuff.
6928 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6929 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6930 a type and a keyword at same time.
6932 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6935 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6936 implicitly typed arrays, more changes will follow.
6938 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6940 2007-06-19 Marek Safar <marek.safar@gmail.com>
6942 * ecore.cs (VarExpr): Removed Handled field.
6944 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6945 build-in assign functionality.
6946 (ForEach.Resolve): Removed all implicitly typed local variable code and
6948 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6949 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6951 2007-06-18 Marek Safar <marek.safar@gmail.com>
6953 * assign.cs: Removed implicitly typed local variable check.
6955 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6956 referencing implicitly typed local variable.
6957 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6960 * statement.cs (Fixed): Removed unsupported implicitly typed local
6963 2007-06-15 Marek Safar <marek.safar@gmail.com>
6965 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6967 2007-06-14 Marek Safar <marek.safar@gmail.com>
6969 A fix for bugs #81855 and #76274
6970 * attribute.cs (AttachTo): Always set owner for global attributes to
6973 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6976 * cs-parser.jay: Assembly and module attributes must precede all other
6977 elements except using clauses and extern alias declarations.
6979 2007-06-13 Marek Safar <marek.safar@gmail.com>
6981 A fix for bug #81748
6983 * expression.cs: More checks for non ISO-1 features.
6985 2007-06-12 Marek Safar <marek.safar@gmail.com>
6987 A fix for bug #81807
6988 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6989 present inside switch statement and it is required by nullable check.
6991 2007-06-12 Marek Safar <marek.safar@gmail.com>
6993 A fix for bug #81840
6994 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6995 when type matching fails.
6997 * namespace.cs: Tiny error message change.
6999 2007-06-12 Marek Safar <marek.safar@gmail.com>
7001 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7002 reporting. Added automatic property check.
7004 * class.cs: Updated after CheckAbstractAndExtern relocation.
7005 (AEventPropertyAccessor.GetSignatureForError): Customized.
7007 2007-06-11 Marek Safar <marek.safar@gmail.com>
7009 * class.cs (DefineBaseTypes): Base type can be undefined.
7011 * ecore.cs (TypeLookup): Minor refactoring.
7012 (DoResolveAsTypeStep): Removed redundant check.
7014 * namespace.cs (Lookup): Removed redundant check.
7016 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7017 ResolveAsTypeTerminal step.
7018 (BootstrapCorlib_*): Simplified.
7019 (PopulateCoreType): Core types can be now external.
7021 2007-06-07 Marek Safar <marek.safar@gmail.com>
7023 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7025 (InferTypeArguments): Infers anonymous expression type arguments.
7026 (Compatible): Split to Compatible and InferTypeArguments.
7028 * lambda.cs: Updated.
7030 2007-06-08 Marek Safar <marek.safar@gmail.com>
7032 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7034 2007-06-07 Raja R Harinath <harinath@gmail.com>
7036 Fix #80477, cs0135-2.cs, cs0135-3.cs
7037 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7038 names to the "known" variables list.
7039 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7040 parameter names are also "known".
7041 (Block.CheckError136): Remove.
7042 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7045 2007-06-07 Marek Safar <marek.safar@gmail.com>
7047 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7049 2007-06-06 Marek Safar <marek.safar@gmail.com>
7051 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7052 internal error not an user error.
7054 * expression.cs (IsApplicable): Refactored to make debugging easier.
7056 * support.cs: More tricks for non-mono runtimes.
7058 * typemanager.cs (CoreLookupType): Made public.
7059 (InitSystemCore): All linq specific stuff moved to linq.cs
7061 2007-06-05 Marek Safar <marek.safar@gmail.com>
7063 * typemanager.cs (CSharpSignature): One more missing build-in types
7065 More tricks for non-mono runtime.
7067 2007-06-05 Raja R Harinath <harinath@gmail.com>
7069 * statement.cs (Block.CheckError136_InParents): Remove.
7070 (Block.AddVariable): Use GetParameterInfo instead.
7071 (ToplevelBlock.ProcessArguments): Likewise.
7073 2007-06-04 Raja R Harinath <rharinath@novell.com>
7075 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7077 (ToplevelBlock.GetParameterInfo): Split out of ...
7078 (ToplevelBlock.GetParameterRefernce): ... this.
7079 (ToplevelBlock.ParameterMap): Remove.
7080 * expression.cs (ParameterReference): Update to use
7081 ToplevelParameterInfo.
7083 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7086 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7087 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7089 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7090 (ToplevelBlock.ProcessParameters) ... here.
7091 (ToplevelBlock..ctor): Invoke it.
7093 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7096 * statement.cs (IKnownVariable): New interface.
7097 (LocalInfo): Implement it.
7098 (ToplevelParameterInfo): New class.
7099 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7100 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7101 GetKnownVariableInfo.
7103 2007-06-03 Raja R Harinath <harinath@gmail.com>
7105 Partly speed up CS0136 error checks.
7106 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7107 'recurse' parameter.
7108 (Block.DoCheckError136): Only check errors in parameters. Move
7109 local variable checks ...
7110 (Block.AddVariable): ... here, and ...
7111 (ToplevelBlock.ResolveMeta): ... here.
7113 2007-06-02 Raja R Harinath <harinath@gmail.com>
7115 * statement.cs (Block.IsChildOf): Remove.
7117 * statement.cs (Statement.Clone): Move special case code ...
7118 (Block.CloneTo): ... here.
7120 2007-05-29 Raja R Harinath <rharinath@novell.com>
7122 * statement.cs (ToplevelBlock.container): Remove field. It's
7123 redundant with 'Parent'.
7124 (ToplevelBlock.ContainerBlock): Remove accessor.
7125 (ToplevelBlock..ctor): Update to changes. Register anonymous
7126 child with parent here, ...
7127 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7129 (start_anonymous): Don't save current_block.
7130 (top_current_block): Remove.
7132 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7133 (Block.Resolve): Update to changes.
7134 (Block..ctor): Move setting of "correct" 'Toplevel'
7135 and 'Explicit' fields to ...
7136 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7138 2007-05-27 Raja R Harinath <harinath@gmail.com>
7141 * statement.cs (Block.Implicit): Remove.
7142 (Block): Update to changes.
7143 * flowanalysis.cs: Likewise.
7145 Mildly speed up CheckInvariantMeaningInBlock
7146 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7147 Recursively call AddKnownVariable to all enclosing blocks.
7148 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7149 Remove recursive calls.
7150 (Block): Update to changes.
7152 New ExplicitBlock invariants
7153 * statement.cs (Block.Explicit): New field. It points to the
7154 immediately enclosing non-implicit block.
7155 (Block..ctor): Maintain the invariant.
7156 * cs-parser.jay: Take advantage of invariant.
7158 Introduce ExplicitBlock
7159 * statement.cs (ExplicitBlock): New.
7160 (ToplevelBlock): Derive from it.
7161 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7163 (Block.Implicit): Update to changes.
7164 * cs-parser.jay: Update to changes.
7167 * codegen.cs (EmitContext.IsLastStatement): Remove.
7168 * statement.cs (Block.DoEmit): Update to changes.
7170 2007-05-25 Raja R Harinath <rharinath@novell.com>
7172 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7173 modifying current_block directly.
7175 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7177 * class.cs: Implemented automatic properties (C# 3.0)
7178 Thanks to Marek for the help.
7180 2007-05-23 Raja R Harinath <rharinath@novell.com>
7182 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7183 variable as assigned, note also that all its components are
7185 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7187 2007-05-19 Marek Safar <marek.safar@gmail.com>
7189 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7190 member is marked as compiler generated.
7192 * decl.cs (MemberCore): Refactored ModFlags into property.
7194 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7195 (Check): Check only accessibility modifiers.
7197 2007-05-18 Raja R Harinath <rharinath@novell.com>
7199 Track all assignable slots in one bit array
7200 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7201 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7202 logic from VariableMap constructor here. Use the same 'offset'
7203 variable that's later used for computing offsets of local
7205 * flowanalysis.cs (UsageVector.parameters): Remove.
7206 (UsageVector): Update to changes.
7207 (VariableMap): Remove.
7209 Avoid creating ParameterMap in every block
7210 * statement.cs (Block.ParameterMap): Move ...
7211 (ToplevelBlock.ParameterMap): ... here.
7212 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7214 * flowanalysis.cs (FlowBranching.param_map): Remove.
7215 (FlowBranching.UsageVector): Update to changes.
7216 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7218 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7220 * expression.cs (ParameterReference): Distinguish between block
7221 where parameter was referenced and declared.
7223 2007-05-18 Marek Safar <marek.safar@gmail.com>
7225 * flowanalysis.cs, statement.cs: Put back improved error handling.
7227 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7231 Imporved object and collection initialization (C# 3.0).
7233 2007-05-15 Marek Safar <marek.safar@gmail.com>
7235 A fix for bug #81380
7236 * expression.cs (Is.DoResolve): Only value types have constant `is'
7239 2007-05-15 Raja R Harinath <rharinath@novell.com>
7241 * statement.cs (ToplevelBlock.child): Remove.
7243 2007-05-15 Raja R Harinath <harinath@gmail.com>
7245 Rationalize ResolveMeta: refactoring
7246 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7247 out constant handling code into ...
7248 (Block.DoResolveConstants): ... this.
7250 Rationalize ResolveMeta: kill local_map
7251 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7252 (Block.AssignableSlots): New.
7253 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7254 for locals -- move code from VariableMap here. Avoid unnecessary
7256 * flowanalysis.cs (FlowBranching.local_map): Remove.
7257 (FlowBranching..ctor): Use Block.AssignableSlots.
7258 (VariableMap): Remove unused constructors.
7260 2007-05-11 Raja R Harinath <rharinath@novell.com>
7262 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7264 2007-05-11 Marek Safar <marek.safar@gmail.com>
7266 * typemanager.cs (IsFriendAssembly): Should not be called for building
7269 2007-05-09 Marek Safar <marek.safar@gmail.com>
7271 * literal.cs (NullConstant): Print null in all cases.
7273 * expression.cs (Binary.ResolveOperator): Implemented delegate
7274 comparison based on C# 2.0 changes.
7276 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7278 This code is contributed under the MIT X11 license
7280 The following enables support for several C# 3.0 language features:
7282 * cs-tokenizer.cs: Added support for the "var" keyword.
7284 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7285 Added VarExpr class to facilitate type inferencing.
7287 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7288 to support anonymous types.
7290 * assign.cs: Added support for type inferencing and initialization.
7292 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7294 * expression.cs: Added implicit array support to ArrayCreation.
7295 Added 5 types and 1 interface:
7297 IInitializable Implementing classes can inject initializing
7298 statements after object instantiation.
7300 Initializer Stores data for object initialization.
7302 AnonymousType An expression for anonymous types.
7304 AnonymousTypeParameter Stores data about an anonymous type's field.
7306 NewInitialize An expression for object initialization.
7308 CollectionInitialize An expression for collection initialization.
7310 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7313 2007-05-06 Marek Safar <marek.safar@gmail.com>
7315 A fix for bug #81500
7316 * cs-tokenizer.cs: Add special handling for coalescing operator.
7318 2007-05-06 Marek Safar <marek.safar@gmail.com>
7320 A fix for bug #81529
7321 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7322 its value from base class until it is redefined.
7324 2007-05-02 Raja R Harinath <rharinath@novell.com>
7326 Fix regression in cs0631-3.cs
7327 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7328 fallback. Make error fallback catch more cases.
7330 2007-05-01 Miguel de Icaza <miguel@novell.com>
7332 * cs-parser.jay: Allow parameters in operator declarations to have
7335 2007-04-27 Miguel de Icaza <miguel@novell.com>
7337 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7340 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7341 inside the ContextualReturn, it does not have to be an
7342 ExpressionStatement.
7344 2007-04-24 Miguel de Icaza <miguel@novell.com>
7346 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7349 2007-04-23 Miguel de Icaza <miguel@novell.com>
7351 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7352 method in two methods: ResolveNoDefine and Resolve.
7354 ResolveNoDefine will stop just after ResolveTopBlock has been
7357 Resolve will then continue by creating a method and issuing the
7358 call to method.Define ().
7360 (AnonymousMethod): Split and implement the new Resolve and
7361 ResolveNoDefine as well.
7363 * lambda.cs (LambdaExpression): Split the anonymous method
7364 resolution code into a separate routine (CoreCompatibilityTest)
7365 from DoCompatibleTest.
7367 (LambdaExpression.TryBuild): New method, this method tries to
7368 build the LambdaExpression with the given set of types to be used
7369 as the types for the various parameters of the lambda expression.
7371 If the compilation succeed with the given types, the infered type
7372 of the Anonymous method is returned, otherwise null is returned.
7374 2007-04-23 Marek Safar <marek.safar@gmail.com>
7376 A fix for bug #81414
7377 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7379 2007-04-22 Miguel de Icaza <miguel@novell.com>
7381 * cs-tokenizer.cs: Change various identifiers here from the
7382 camelCasing to the recommended Linux-like style for instance
7383 variables from the Coding Guidelines.
7385 2007-04-19 Martin Baulig <martin@ximian.com>
7388 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7389 System.Enum to System.ValueType.
7391 2007-04-13 Martin Baulig <martin@ximian.com>
7393 Rewrote implicit reference conversions. We need to distinguish
7394 between implicit reference conversions (13.1.4) and implicit
7395 boxing conversions (13.1.5).
7397 According to the spec, there's an an implicit conversion
7398 "From a one-dimensional array-type S[] to IList<T> and base
7399 interfaces of this interface, provided there is an implicit
7400 reference conversion from S to T." Note that this does not
7401 include boxing conversions.
7404 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7405 (Convert.ImplicitReferenceConversion): Split into
7406 ImplicitReferenceConversionCore() and
7407 ImplicitBoxingConversionExist().
7408 (Convert.ImplicitReferenceConversionExists): Use the new
7409 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7411 2007-04-12 Martin Baulig <martin@ximian.com>
7413 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7414 `TypeManager.null_type' checks up to the top of the method.
7416 2007-04-11 Marek Safar <marek.safar@gmail.com>
7418 A fix for bug #81350
7419 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7422 2007-04-11 Martin Baulig <martin@ximian.com>
7424 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7425 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7426 to make this work for generic classes; fixes #79561.
7428 2007-04-11 Martin Baulig <martin@ximian.com>
7430 * expression.cs (As): Add support for nullable types; fixes #79371.
7432 2007-04-11 Martin Baulig <martin@ximian.com>
7434 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7435 `type.FullName' is null; fixes #80243.
7437 2007-04-11 Martin Baulig <martin@ximian.com>
7439 * expression.cs (Invocation.IsApplicable): Don't modify the method
7440 if type inference succeeded, but the method was not applicable.
7443 2007-04-10 Marek Safar <marek.safar@gmail.com>
7445 A fix for bug #81324
7446 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7447 internal and external namespaces containers.
7449 2007-04-10 Martin Baulig <martin@ximian.com>
7451 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7452 TypeManager.DropGenericMethodArguments() so we also call
7453 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7455 2007-04-10 Martin Baulig <martin@ximian.com>
7457 * iterators.cs (Iterator.CreateIterator): Don't crash if
7458 `method.ReturnType' is null. This happens if something went wrong
7459 while resolving that typ (we already reported an error in this case).
7461 2007-04-10 Martin Baulig <martin@ximian.com>
7463 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7464 generic interfaces; report the CS0144 directly.
7466 2007-04-10 Martin Baulig <martin@ximian.com>
7468 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7469 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7471 2007-04-10 Martin Baulig <martin@ximian.com>
7473 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7475 2007-04-09 Raja R Harinath <rharinath@novell.com>
7478 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7479 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7482 * statement.cs (For.Resolve): If resolution fails, use
7485 2007-04-08 Marek Safar <marek.safar@gmail.com>
7487 * anonymous.cs (MakeName): Make faster and zero-based.
7488 (VerifyExplicitParameterCompatibility): Back to mode where generic
7489 parameter is ignored.
7490 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7492 * class.cs (EmitType): Method can emit another new method.
7494 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7496 * driver.cs: Updated.
7498 * lambda.cs: Reuse predefined empty parameters.
7500 * parameter.cs: Updated
7502 * support.cs: Implemented InflateTypes.
7504 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7505 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7507 2007-04-03 Martin Baulig <martin@ximian.com>
7511 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7512 version of TypeManager.IsOverride() which also works with generic
7515 2007-04-03 Martin Baulig <martin@ximian.com>
7520 (Convert.ExplicitReferenceConversion): We need to cast when
7521 converting from IList<T> to S[].
7523 2007-04-01 Marek Safar <marek.safar@gmail.com>
7525 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7528 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7530 2007-03-31 Marek Safar <marek.safar@gmail.com>
7532 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7533 argument and return type inferring.
7535 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7536 (ReturnType): Turned to property.
7538 * statement.cs (Return): Implemented return type inferring.
7540 * support.cs (ReflectionParameters): Use local types if possible.
7542 2007-03-30 Raja R Harinath <rharinath@novell.com>
7544 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7545 (FlowBranching.UsageVector): Update to changes.
7547 Prepare to kill 'Reachability'
7548 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7549 argument of constructor.
7551 2007-03-29 Raja R Harinath <rharinath@novell.com>
7553 Prepare to kill 'Reachability'
7554 * flowanalysis.cs (UsageVector.is_unreachable): New.
7555 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7556 'reachability', and verify they're consistent.
7559 * expression.cs (New.EmitStatement): Handle type parameters here too.
7561 2007-03-29 Martin Baulig <martin@ximian.com>
7566 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7567 CompilerGeneratedClass.
7568 (ScopeInfo.EmitScopeInstance): Make this protected.
7569 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7570 `ec.CurrentAnonymousMethod.Scope == Scope'.
7572 * statement.cs (Block.ScopeInfo): Make this a property.
7574 2007-03-27 Raja R Harinath <harinath@gmail.com>
7576 Prepare to kill 'Reachability'
7577 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7578 (FlowBranching.UsageVector.Reachability): Remove property.
7579 (FlowBranching.UsageVector.IsUnreachable): New property.
7580 (FlowBranching.UsageVector.ResetBarrier): New.
7581 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7582 * codegen.cs, statement.cs: Update to changes.
7584 2007-03-27 Martin Baulig <martin@ximian.com>
7589 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7592 2007-03-26 Raja R Harinath <rharinath@novell.com>
7594 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7595 instead of TriState. Remove all mention of TriState.
7597 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7598 replaced by a boolean. Add boolean 'is_unreachable' field, check
7599 and maintain invariants.
7601 2007-03-25 Marek Safar <marek.safar@gmail.com>
7603 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7605 2007-03-25 Marek Safar <marek.safar@gmail.com>
7607 * expression.cs: Stop using obsolete 2.0 opcodes.
7609 2007-03-25 Marek Safar <marek.safar@gmail.com>
7611 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7612 one of the latests Martin's fixes.
7614 2007-03-23 Miguel de Icaza <miguel@novell.com>
7616 * expression.cs: On BigEndian systems, swap the bytes, temporary
7617 solution until we get a new bitconverter class.
7619 2007-03-23 Martin Baulig <martin@ximian.com>
7623 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7624 "Method" and "Method`1". Normally, a cache lookup is done on the
7625 "Method" form (ie. without the generic arity), but this one makes
7626 lookups on the full form work as well.
7628 2007-03-22 Raja R Harinath <rharinath@novell.com>
7630 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7633 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7635 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7636 ordered_member_list, to TypeBuilder to store members to be defined
7637 in the order they were parsed in.
7638 - ordered_explicit_member_list contains all properties indexers
7639 and methods that are defined as explicit implementation of an
7640 interface or base class.
7641 - ordered_member_list contains all properties indexers and methods
7642 that are not defined as explicit implementation of an interface
7645 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7646 functionality in these removed classes has been replaced with
7647 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7648 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7650 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7651 to CheckForDuplications inside GetMethod and SetMethod Define Method
7652 to handle method property and indexer name conflicts.
7656 All code is contributed under the MIT/X11 license.
7658 2007-03-20 Martin Baulig <martin@ximian.com>
7660 * class.cs (TypeContainer.Interfaces): Removed; they're now
7661 included in `TypeContainer.Types'.
7663 2007-03-20 Martin Baulig <martin@ximian.com>
7665 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7667 * class.cs (TypeContainer.CreateType): New public method. This is
7668 now called before DefineType() to create the TypeBuilders.
7669 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7670 has already been created by CreateType().
7671 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7672 don't resolve our base classes here; this has been moved into
7673 DefineBaseTypes(). We're now called from CreateType().
7674 (TypeContainer.DefineBaseTypes): New private method; resolve our
7675 base classes here. We're now called from DefineType().
7678 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7679 our types first to create all the TypeBuilders. After that, call
7680 TypeContainer.DefineType() on all the types which'll resolve their
7681 base classes and setup the resolve order.
7683 2007-03-20 Martin Baulig <martin@ximian.com>
7685 * class.cs (TypeContainer.Enums): Removed; they're now included in
7686 `TypeContainer.Types'.
7688 2007-03-20 Martin Baulig <martin@ximian.com>
7691 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7692 (TypeContainer.DoResolveMembers): Call DefineType() on our
7693 `compiler_generated' classes; moved here from DefineNestedTypes().
7696 (RootContext.ResolveTree): Call ResolveMembers() on all
7697 TypeContainer's in the `type_container_resolve_order'.
7699 2007-03-19 Marek Safar <marek.safar@gmail.com>
7701 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7703 2007-03-17 Marek Safar <marek.safar@gmail.com>
7705 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7706 implementation flags.
7708 2007-03-17 Marek Safar <marek.safar@gmail.com>
7710 * class.cs: More optimizations for type parameters.
7712 2007-03-15 Marek Safar <marek.safar@gmail.com>
7714 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7716 * ecore.cs, parameter.cs: More common code for both corlibs.
7718 * typemanager.cs (IsGenericMethod): Simplified.
7720 2007-03-15 Raja R Harinath <rharinath@novell.com>
7722 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7724 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7726 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7727 unconditionally. Simplify explanation.
7728 (Try.Resolve, Using.Resolve): Likewise.
7730 2007-03-15 Martin Baulig <martin@ximian.com>
7734 * decl.cs (DeclSpace): If we're a partial class, use our
7735 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7737 2007-03-15 Raja R Harinath <rharinath@novell.com>
7739 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7741 (FlowBranching.UsageVector): Update to changes.
7742 (FlowBranching.MergeSiblings): Likewise.
7743 * statement.cs: Likewise.
7745 2007-03-15 Martin Baulig <martin@ximian.com>
7750 (MemberCache): Added a special .ctor for type parameters.
7753 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7756 2007-03-09 Martin Baulig <martin@ximian.com>
7758 * enum.cs (Enum): Make this a TypeContainer.
7759 (EnumMember): Derive from `Const'.
7762 (Const.DoResolveValue): New protected virtual method; move most of
7763 the functionality of ResolveValue() here so we can override it in
7765 (Const.CreateConstantReference): Make this virtual.
7767 * class.cs (Kind): Add `Kind.Enum'.
7768 (TypeContainer.Emit): Don't emit the enums here; they're already
7769 in the `RootContext.typecontainer_resolve_order'.
7771 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7772 here; they're already in the `typecontainer_resolve_order'.
7774 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7775 TypeManager.DropGenericTypeArguments().
7778 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7779 (TypeManager.IsEnumType): Likewise.
7780 (TypeManager.EnumToUnderlying): Likewise.
7781 (TypeManager.IsEqual): Add support for enums.
7783 2007-03-12 Raja R Harinath <rharinath@novell.com>
7785 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7786 DefaultParameterValueAttribute to be undefined, say if System.dll
7789 2007-03-11 Marek Safar <marek.safar@gmail.com>
7791 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7794 2007-03-10 Marek Safar <marek.safar@gmail.com>
7796 * class.cs, parameter.cs: Unified parameters verification.
7798 2007-03-08 Martin Baulig <martin@ximian.com>
7800 * cs-parser.jay (constructor_header): Pass the location to the
7801 newly created TopLevelBlock.
7803 2007-03-07 Martin Baulig <martin@ximian.com>
7805 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7807 2007-03-06 Miguel de Icaza <miguel@novell.com>
7809 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7810 with the changes from David, fixes the build.
7812 2007-03-05 David Mitchell <dmitchell@logos.com>
7814 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7815 and its base interfaces to a one-dimensional array type S[],
7816 provided there is an implicit or explicit reference conversion
7819 2007-03-03 Marek Safar <marek.safar@gmail.com>
7821 * cs-tokenizer.cs: Implemented basic linq grammar.
7823 * driver.cs: Set linq lang version on demand.
7825 2007-02-26 Marek Safar <marek.safar@gmail.com>
7827 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7829 2007-02-25 Marek Safar <marek.safar@gmail.com>
7831 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7834 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7836 Check property and event extern attributes.
7838 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7841 2007-02-24 Marek Safar <marek.safar@gmail.com>
7843 A fix for bug #80407
7844 * ecore.cs: Don't report ambiguity error when methods have same parent.
7846 2007-02-23 Marek Safar <marek.safar@gmail.com>
7848 A fix for bug #80878
7849 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7851 2007-02-22 Marek Safar <marek.safar@gmail.com>
7853 * attribute.cs: Enable ExtensionAttribute presence test.
7855 2007-02-22 Marek Safar <marek.safar@gmail.com>
7857 * class.cs: Warn about missing GetHashCode only when Equals is override.
7859 * decl.cs: Check accessibility of type arguments.
7861 * typemanager.cs: Correctly report nullable array.
7863 2007-02-20 Marek Safar <marek.safar@gmail.com>
7865 * class.cs, report.cs: Capture more details when things go wrong.
7867 2007-02-20 Marek Safar <marek.safar@gmail.com>
7869 A fix for bug #80650
7870 * cs-parser.jay: Anonymous container starts at constructor declaration
7871 and not at block beginning because it has to be usable in constructor
7874 * statement.cs: Use context location and not block one for error reporting.
7876 2007-02-18 Marek Safar <marek.safar@gmail.com>
7878 A fix for bug #78712
7879 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7882 2007-02-18 Marek Safar <marek.safar@gmail.com>
7884 A fix for bug #80493 by Atsushi Enomoto
7885 * cs-parser.jay: Ignore invalid attribute target.
7887 2007-02-18 Marek Safar <marek.safar@gmail.com>
7889 * cs-tokenizer.cs: Ignore '\0' as white space character.
7891 2007-02-17 Miguel de Icaza <miguel@novell.com>
7893 * cs-parser.jay: Add support for lambda expressions to the mcs
7896 * lambda.cs: Only clone when we are probing, not on the final call
7897 (Compatible is the final call).
7899 * statement.cs (CloneContext): Introduce class to provide block
7900 remapping during clone.
7902 All statements Clone themselves now.
7904 (Clone): special handling for blocks, when we clone a block, we
7905 register the block inside this routine, as children of the block
7906 might trigger a lookup.
7908 * expression.cs: Add support for CloneContext in all expressions.
7910 2007-02-17 Marek Safar <marek.safar@gmail.com>
7912 A fix for bug #80493
7913 * statement.cs: Report ambiguous warning when interfaces are not related.
7915 2007-02-15 Marek Safar <marek.safar@gmail.com>
7917 C# 3.0 extension methods.
7919 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7920 cannot be used directly.
7922 * class.cs (Class.Emit): Emit extension attribute if any class method
7923 is extension method.
7924 (Method.Define): Add basic extension method validation conditions.
7925 (Method.Emit): Emit extension attribute for method.
7927 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7928 extension method exists. Currently we follow same approach as Microsoft
7929 does, emit even if a method or a class are private but this can change
7932 * cs-parser.jay: Add handling of `this' keyword in method parameters
7935 * decl.cs (DeclSpace.IsStaticClass): New property.
7936 (MemberCache.FindExtensionMethods): Looks for extension methods with
7937 defined name and extension type.
7939 * doc.cs: Updated after OverloadResolve changes.
7941 * driver.cs: Add new soft reference to System.Core.dll.
7943 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7944 (ExtensionMethodGroupExpr): Represents group of extension methods.
7946 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7947 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7948 to MethodGroupExpr and made non-static for easier customization.
7949 (Invocation.DoResolve): Add extension method lookup when no standard
7951 (MemberAccess.DoResolve): Try extension methods if no member exists.
7953 * modifiers.cs: Add METHOD_EXTENSION modifier.
7955 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7956 as well as candidate extension type.
7957 (ComputeNamespaces): When assembly constains extension methods registers
7959 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7960 extension method lookup.
7961 (Namespace.LookupExtensionMethod): Looks for extension method in this
7963 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7964 find a method which matches name and extensionType.
7966 * parameter.cs (Parameter): Add This modifer.
7967 (HasExtensionMethodModifier): New property.
7968 (Resolve): Add extension parameter check.
7969 (ModFlags): turned to property to exclude this modifier as it is not real
7971 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7973 * support.cs (ParameterData): Add ExtensionMethodType.
7974 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7976 * typemanager.cs: Add type and ctor extension attribute type.
7978 2007-02-15 Miguel de Icaza <miguel@novell.com>
7980 * report.cs (DisableErrors, EnableErrors): used to prevent error
7981 output when we are "trying" to compile various methods with
7984 * ecore.cs (Expression): Add Clone method that calls the virtual
7985 CloneTo method. The current CloneTo method in Expression throws
7986 an exception so we can track down all the places where this must
7987 be implemented (not using abstract, because that would be a lot of
7988 up-front-work before we can start testing the implementation
7991 Important: we only need Clone capabilities for expressions created
7992 by the parser, as the expressions we will be cloning are
7993 expressions in the pre-resolved state. This vastly simplifies
7996 (SimpleName): Add CloneTo that does nothing.
7997 (EmptyCast): Add CloneTo.
7999 * expression.cs (Binary): Implement CloneTo.
8000 (Invocation.IsApplicable): Store the current ec in
8001 EmitContext.TempEc and restore it on return. This is used so we
8002 do not have to sprinkle hundres of methods with an extra
8003 EmitContext, we know that the only user is the lambda expression
8004 ImplicitConversionExists code.
8006 (Argument): Add Cloning capabilities.
8007 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8008 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8009 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8010 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8011 IndexerAccess): Add Clone capability.
8013 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8015 (Argument): Add cloning capability.
8017 * assign.cs (Assign): Implement CloneTo.
8019 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8021 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8022 version by calling Convert with the EmitContext (that we are
8023 currently storing in ec, this is not great, but will do for now,
8024 to avoid passing EmitContext parameters to hundreds of functions
8025 that do not need them now).
8027 (SetExpression): Remove, it is not needed.
8029 (ContextualReturn): Implement CloneTo.
8031 * statement.cs (Statement): Implement cloning infrastructure,
8032 similar to expressions.
8034 (Block): Partial implementation of Clone for statements.
8036 (Return): Implement clone.
8038 * constant.cs (Constant.CloneTo): New method, does nothing.
8040 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8041 solution, until we decide how to exactly do this.
8043 2007-02-14 Marek Safar <marek.safar@gmail.com>
8045 A fix for bug #80493
8046 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8047 a property is override we need to use second accessor.
8049 2007-02-13 Marek Safar <marek.safar@gmail.com>
8051 A fix for bug #80418
8052 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8055 2007-02-13 Marek Safar <marek.safar@gmail.com>
8057 Another fix for bug #80749
8058 * pending.cs: Abstract class has priority over interfaces.
8060 2007-02-13 Marek Safar <marek.safar@gmail.com>
8062 Another fix for bug #80749
8063 * pending.cs: Abstract class has priority over interfaces.
8065 2007-02-13 Marek Safar <marek.safar@gmail.com>
8067 Another fix for bug #80749
8068 * pending.cs: Abstract class has priority over interfaces.
8070 2007-02-13 Marek Safar <marek.safar@gmail.com>
8072 Another fix for bug #80749
8073 * pending.cs: Abstract class has priority over interfaces.
8075 2007-02-13 Marek Safar <marek.safar@gmail.com>
8077 * class.cs Better error message.
8079 * driver.cs: Add shorter versions of -optimize option.
8081 2007-02-13 Martin Baulig <martin@ximian.com>
8083 * class.cs (Constructor.Emit): Check the return value of
8084 ec.ResolveTopBlock() and return on error.
8086 2007-02-13 Raja R Harinath <rharinath@novell.com>
8088 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8089 message to fix error message regression.
8091 2007-02-12 Marek Safar <marek.safar@gmail.com>
8093 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8095 2007-02-12 Marek Safar <marek.safar@gmail.com>
8097 A fix for bug #80749
8098 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8099 its parent container.
8101 * class.cs (DefineFieldInitializers): Each initializer can has different
8104 * const.cs: Updated.
8106 2007-02-11 Miguel de Icaza <miguel@novell.com>
8108 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8109 now all the heavy lifting to check that embedded statements or
8110 expressions have the right form is done in the ContextualReturn.
8112 (ContextualReturn): New class.
8114 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8115 method that can be invoked to report 201, so we do not replicate
8118 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8120 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8121 treating tabs as spaces.
8123 2007-02-09 Marek Safar <marek.safar@gmail.com>
8125 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8126 * assign.cs: Use full implicit conversion for right side check.
8128 2007-02-09 Marek Safar <marek.safar@gmail.com>
8130 * statement.cs (Switch): Switch over boolean type is not standardized.
8132 2007-02-08 Marek Safar <marek.safar@gmail.com>
8134 A fix for bug #80755
8135 * decl.cs (FindBaseEvent): Don't use method cache for events.
8137 2007-02-07 Marek Safar <marek.safar@gmail.com>
8139 * cs-parser.jay: Better syntax error handling.
8141 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8142 instead of underlying type value.
8144 2007-02-06 Marek Safar <marek.safar@gmail.com>
8146 * driver.cs: Check define identifier before is registered.
8148 * namespace.cs: Use existing error message.
8150 * report.cs: New warning.
8152 2007-02-06 Marek Safar <marek.safar@gmail.com>
8154 A fix for bug #80742
8155 * expression.cs: Delegate Invoke method can be called directly.
8157 2007-02-06 Marek Safar <marek.safar@gmail.com>
8159 A fix for bug #80676
8160 * class.cs (IsEntryPoint): The Main method can have params modifier.
8162 2007-02-04 Miguel de Icaza <miguel@novell.com>
8164 * parameter.cs (Parameter, Parameters): Add Clone method.
8166 * anonymous.cs (Compatible): Turn method into virtual method, so
8167 LambdaExpression can implement a different behavior.
8169 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8170 out the basic checking here, so it can be used by
8173 * lambda.cs: Introduce "Compatible" function that will do the
8176 2007-02-02 Marek Safar <marek.safar@gmail.com>
8178 * attribute.cs: Unified one error message.
8180 * class.cs (Class): Use type attributes and not properties to test static
8182 (IsEntryPoint): Don's pass local variable.
8184 * convert.cs: Removed duplicate check.
8186 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8188 * driver.cs: Don't crash when soft reference does not exist.
8190 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8191 (UsingEntry): Removed redundant allocation.
8193 * parameter.cs: Add fast path for type parameters.
8195 * support.cs: Don't allocate attribute when it's not used.
8197 2007-01-30 Miguel de Icaza <miguel@novell.com>
8200 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8201 this into a virtual method, so we can override it in LambdaExpression.
8203 * driver.cs: Improve diagnostics in case of failure.
8205 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8206 write a function that is slightly more complex and that parses:
8208 type identifier [, type identifier]* )
8210 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8213 (canEmpty ? i >= 0 : i > 0)
8215 2007-01-30 Raja R Harinath <rharinath@novell.com>
8217 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8218 exception on possibly valid code.
8220 2007-01-29 Raja R Harinath <rharinath@novell.com>
8222 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8224 (parse_opt_type_arguments): Remove. It's almost the same as
8226 (parse_namespace_or_typename): Use parse_less_than.
8228 2007-01-28 Miguel de Icaza <miguel@novell.com>
8230 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8231 this bug took a few hours to find, because the state saved and
8232 restored by PushPosition and PopPosition was ignoring the state of
8233 parse_generic_less_than.
8235 I can also now remove the handling of OP_LT and OP_GT, this solves
8238 * cs-tokenizer.cs: store the location for the ARROW token, we use
8241 (PushPosition, PopPosition): save/restore also `current_token',
8242 restore `parse_generic_less_than' (was missing).
8244 (parse_opt_type_arguments): use parse_type, not
8245 parse_namespace_or_typename to parse types.
8247 * lambda.cs: Empty new file, will eventually have the lambda
8248 expression implementation.
8250 * lambda.test: used to test the internal tokenizer.
8252 * report.cs (FeatureIsNotISO1): Rename from
8253 FeatureIsNotStandardized, because it was about the language level
8254 (1 vs 2) it was not about standarization.
8256 (FeatureRequiresLINQ): New.
8258 * support.cs (SeekableStreamReader): Only require that the reader
8259 is a TextReader, not a StreamReader, so we can plug StringReader.
8261 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8262 given position in the input stream the following tokens can be
8263 parsed as a type followed by an identifier.
8265 (is_punct): after a '(' if parse_type_and_parameter returns true,
8266 then return a special token OPEN_PARENS_LAMBDA which is used to
8267 avoid reduce/reduce errors in the grammar for the
8268 lambda_expression rules.
8270 (parse_type): implement a type parser inside the
8271 tokenizer, the parser only returns true or false depending on
8272 whether the input at a given position can be parsed as a type.
8274 (peek_token): new method used during type parsing.
8276 2007-01-28 Raja R Harinath <rharinath@novell.com>
8279 * anonymous.cs (ScopeInfo.InflateParameters): New.
8280 (AnonymousContainer.Resolve): Use it to redirect types of
8281 delegate parameters.
8283 2007-01-27 Raja R Harinath <rharinath@novell.com>
8286 * expression.cs (Error_InvalidArguments): Don't use two different
8287 messages for CS1503. Use ExtraInformation and
8288 SymbolRelatedToPreviousError instead.
8291 * decl.cs (DeclSpace.initialize_type_params): Don't access
8292 'type_params' of a partial class directly.
8294 2007-01-26 Miguel de Icaza <miguel@novell.com>
8296 * constant.cs: Removed a handful of out-of-range checks that were
8299 2007-01-25 Marek Safar <marek.safar@gmail.com>
8301 * expression.cs (CheckUselessComparison): Add additional check for char
8304 * namespace.cs: Fixed typo.
8306 2007-01-23 Miguel de Icaza <miguel@novell.com>
8308 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8309 gone, instead we inline the test, preventing the needless casts to
8310 longs, ulongs and doubles for the parameters, avoiding calls to
8311 methods that overchecked stuff, and instead inlined things
8314 2007-01-20 Marek Safar <marek.safar@gmail.com>
8316 * cs-parser.jay: Better parameter error handling.
8318 2007-01-17 Marek Safar <marek.safar@gmail.com>
8320 A fix for bug #80368, #80522
8321 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8322 whether array initializer contains constants only.
8323 (ArrayCreation.Emit): Use better formula to decide when
8324 are array initializers for static initialization.
8325 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8326 have to emit even constants otherwise they are pre-initialized.
8328 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8329 Raja R Harinath <rharinath@novell.com>
8331 Fix emit order of 'get' vs. 'set'.
8332 * support.cs (Accessors): New.
8333 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8334 Note the order in which accessors are declared in the source.
8335 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8336 Refactored from Property.Define and Indexer.Define.
8337 (PropertyBase.DefineAccessors): New helper that calls the above in
8338 appropriate order as noted by the parser.
8339 (Property.Define, Indexer.Define): Update to changes.
8340 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8342 2007-01-17 Raja R Harinath <rharinath@novell.com>
8344 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8345 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8346 there's an implicit conversion from the current type to the target
8347 type before converting the underlying constant.
8349 2007-01-16 Marek Safar <marek.safar@gmail.com>
8351 * const.cs (ResolveValue): Updated after constant conversion was made more
8354 * constant.cs (GetAttributableValue): constant to object conversion is
8355 used for attributes only.
8356 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8357 constant conversions.
8358 (LongConstant.ConvertImplicitly): Ditto.
8360 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8361 (ImplicitConversionStandard): Handle constant conversion as extra step.
8362 It solves the issue when constant conversion was called indirectly like
8363 inside array initializer and constant folding was skipped.
8365 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8368 * statement.cs(ImplicitConversionStandard): Updated after constant
8369 conversion was made more generic.
8371 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8373 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8374 Constraints, solves the problem where the compiler incorrectly
8375 reported that a type parameter was not constrained to a class (Bug
8378 2007-01-14 Marek Habersack <grendello@gmail.com>
8380 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8382 2007-01-14 Marek Safar <marek.safar@gmail.com>
8384 A fix for bug #80368
8385 * assign.cs (FieldInitializer): New class implements field
8386 initializer statement.
8388 * attribute.cs: Update after FieldMember rename.
8390 * class.cs (PropertyBasedMember): New common class for property based
8392 (InterfaceMemberBase): New base class for all members which can be used as
8393 an interface members.
8394 (MethodCore): Moved really common code to InterfaceMemberBase.
8395 (Method.Define): Equal and GetHasCode detection is relevant for methods
8397 (MethodData.Define): Don't assume that public event implements an
8398 interface automatically.
8399 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8401 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8402 (FieldMember): Merged with FieldBase.
8403 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8404 event extern modifier can be used.
8405 (EventField.EventFieldAccessor): Moved event field specific code here.
8406 (Event.AllowedModifiers): Even event can be extern.
8407 (Event.FindOutBaseMethod): New override specific to events.
8408 (Indexer.parameters): Reintroduce parameters because base class holds
8409 only properties common data.
8410 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8411 need do extra parameters check.
8413 * const.cs: Update after FieldMember rename.
8415 * decl.cs (MemberCache.FindBaseEvent): New method.
8417 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8418 to reflect that indexer is now derived from PropertyBased.
8420 * ecore.cs (GetMemberType): Made public.
8421 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8424 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8426 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8427 (RegisterEvent): Removed.
8428 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8429 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8431 2007-01-11 Raja R Harinath <rharinath@novell.com>
8434 * statement.cs (CollectionForeach.TryType): Prefer generic
8435 GetEnumerator over non-generic variant. Fix code to follow comments.
8437 2007-01-09 Raja R Harinath <rharinath@novell.com>
8440 * support.cs (ReflectionParameter): Don't use an invalid index on
8441 the generic parameter data.
8443 2007-01-08 Miguel de Icaza <miguel@novell.com>
8445 * driver.cs: Just add a tiny bit of infrastructure.
8447 2007-01-02 Marek Safar <marek.safar@gmail.com>
8449 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8450 where field type is struct from current assembly.
8452 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8455 2007-01-02 Marek Safar <marek.safar@gmail.com>
8457 A fix for bug #80381
8458 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8461 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8463 (Namespace.LookupType): Always use core types from corlib when speficied.
8465 * report.cs: A new warning.
8467 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8468 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8469 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8471 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8472 (InitCoreTypes): Set expression type of object_type and value_type
8473 immediately after lookup.
8475 2007-01-01 Miguel de Icaza <miguel@novell.com>
8477 * cs-tokenizer.cs: Accept Pc class characters (Connector
8478 Punctuation) as valid identifiers. Fixes #78259
8480 * expression.cs (Invocation.DoResolve): Moved the check for the
8481 use of `this' for doing method calls to the Invocation resolution
8482 step, after overload resolution has taken place instead of doing
8483 the check at the low-level `This.DoResolve' level.
8485 The `This.DoResolve'(appens before overload resolution, so it has
8486 no way of knowing if the method that will be called will be
8487 instace or static, triggering an erroneous report for cs0188 (Bug
8490 We now do the check for instance method invocations after we know
8491 what method will be called.
8493 (This.CheckThisUsage): Move the actual use of this structure
8494 checking into its own method and expose it.
8496 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8499 Exceptions: Null.ConvertImplicitly,
8500 Constant.ImplicitConversionRequired as there are too many call
8501 sites for passing the ec.
8503 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8504 EmitContext, if the value is null, then we do not try to provide
8505 the extra information from the error (If a userdefined conversion
8506 exists, as UserDefinedConversion requires a non null-EmitContext).
8510 2006-12-30 Raja R Harinath <rharinath@novell.com>
8512 * flowanalysis.cs (MyBitVector): Document some invariants.
8513 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8514 introduced below, and add a couple of others,
8516 2006-12-30 Marek Safar <marek.safar@gmail.com>
8518 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8519 GetPropertyFromAccessor and GetEventFromAccessor.
8521 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8522 overrides non-obsolete one.
8523 (Indexer.Define): Error message has been moved to the parser.
8525 * cs-parser.jay: Better syntax errors handling.
8527 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8528 when an invocation has no arguments.
8530 * ecore.cs: Removed not used caching.
8532 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8535 * report.cs: Add a new warning.
8537 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8539 * typemanager.cs (enumeration_type): Removed.
8540 (CSharpSignature): Reuses IsSpecialMethod.
8541 (IsEqual): Hack for MS BCL.
8542 (GetPropertyFromAccessor): New method.
8543 (GetEventFromAccessor): New method.
8544 (IsSpecialMethod): Fixed to handle more cases.
8546 2006-12-30 Marek Safar <marek.safar@gmail.com>
8548 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8549 Made white spaces array static.
8551 * ecore.cs (RemoveGenericArity): Optimized.
8553 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8555 (MyBitVector.initialize_vector): Simplified.
8557 2006-12-22 Miguel de Icaza <miguel@novell.com>
8559 * ecore.cs: Am not entirely happy with this hack, but it seems to
8560 address the issue in 80257 (a small test case for
8563 I set the MethodGroupExpr.Type to an internal compiler type
8564 (itself in this case) to force the resolution to take place. Why
8565 it does not take place with a null is beyond me.
8567 2006-12-20 Marek Safar <marek.safar@gmail.com>
8569 A fix for bug #80288
8570 * expression.cs (ResolveOperator): Consider user defined conversion for
8571 logical and operator too.
8572 (EmitBranchable): Optimization for logical and when full constant folding
8573 could not be applied but one operand is constant.
8575 2006-12-19 Marek Safar <marek.safar@gmail.com>
8577 * class.cs (GetClassBases): Write 5 times every day, will never use
8578 FullName for error reporting.
8580 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8582 2006-12-19 Martin Baulig <martin@ximian.com>
8584 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8585 the symbol file info here.
8587 2006-12-18 Marek Safar <marek.safar@gmail.com>
8589 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8590 of `elseif' is taking then following sections are not taking.
8591 Fixes an issue reported on mono mailing list.
8593 2006-12-18 Marek Safar <marek.safar@gmail.com>
8595 A fix for bug #80300
8596 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8597 a caller is not taking.
8599 2006-12-18 Raja R Harinath <rharinath@novell.com>
8601 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8602 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8603 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8604 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8605 * class.cs: Update to changes.
8607 2006-12-17 Marek Safar <marek.safar@gmail.com>
8609 A fix for bug #79934
8610 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8613 * class.cs (ResolveMembers): Register an iterator in current container and
8616 2006-12-16 Raja R Harinath <rharinath@novell.com>
8619 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8620 satisfy a params annotated parameter.
8622 2006-12-16 Marek Safar <marek.safar@gmail.com>
8624 A fix for bug #77014
8625 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8626 paramters correctly and not rely on hacks in Parameters class.
8627 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8629 (Invocation.VerifyArgumentsCompat): Ditto.
8630 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8633 * parameter.cs (HasParams): Don't assume that params is the last one.
8635 * support.cs (ReflectionParameters.ctor): Look for params attribute
8637 (ReflectionParameters.ParameterType): Removed hack when we returned last
8638 parameter for out of range parameters.
8639 (ParameterName, ParameterModifier): Ditto.
8641 2006-12-14 Marek Safar <marek.safar@gmail.com>
8643 A fix for bug #79987
8644 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8645 when assembly is not CLS compliant but type is. I have no idea why is this
8648 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8650 2006-12-13 Miguel de Icaza <miguel@novell.com>
8652 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8653 in struct constructors, they are basically no-ops.
8655 2006-12-12 Marek Safar <marek.safar@gmail.com>
8657 * cs-tokenizer.cs (Position): Save preprocessor status too.
8659 2006-12-12 Marek Safar <marek.safar@gmail.com>
8661 A fix for bug #77794
8662 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8664 2006-12-12 Marek Safar <marek.safar@gmail.com>
8666 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8668 (pp_expr): Report error for an invalid expression.
8669 (handle_preprocessing_directive): Simplified; add more error checking.
8671 2006-12-11 Marek Safar <marek.safar@gmail.com>
8673 A fix for bug #74939
8674 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8675 directives handling.
8677 2006-12-10 Marek Safar <marek.safar@gmail.com>
8679 A fix for bugs #80093, and #75984
8680 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8681 logic, it seems to me as it worked before "by coincidence".
8682 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8683 (cleanup): Enabled endif check.
8685 2006-12-09 Marek Safar <marek.safar@gmail.com>
8687 A fix for bug #80162
8688 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8689 enumerators are never ambiguous.
8691 2006-12-08 Raja R Harinath <rharinath@novell.com>
8694 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8696 2006-12-06 Marek Safar <marek.safar@gmail.com>
8698 A fix for bug #80144
8699 * class.cs (EventProperty.Define): Explicit implementation means
8700 that an even is used.
8702 2006-12-06 Marek Safar <marek.safar@gmail.com>
8704 Fixes the operators implementation (part II)
8706 * cfold.cs (DoConstantNumericPromotions): Renamed to
8707 DoBinaryNumericPromotions and simplified.
8708 (BinaryFold): Couple of conversion fixes; simplified.
8710 * constant.cs, ecore.cs, literal.cs
8711 (ToType): Renamed to ConvertImplicitly.
8712 (Reduce): Renamed to ConvertExplicitly.
8714 * class.cs, convert.cs: Updated.
8716 * expression.cs: TryReduce doesn't throw an exception.
8718 2006-12-01 Marek Safar <marek.safar@gmail.com>
8720 A fix for bug #80108
8721 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8724 2006-11-30 Marek Safar <marek.safar@gmail.com>
8726 Fixes unary operators implementation (part I)
8729 * cfold.cs (Error_CompileTimeOverflow): Made internal
8731 * const.cs (IConstant): Changed to use reference to constant and
8732 not constant itself.
8733 Updated IConstant implementations.
8735 * constant.cs (CreateConstant): New factory method.
8736 Updated IConstant implementation.
8738 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8740 * ecore.cs: Updated to use CreateConstantReference.
8742 * enum.cs: Reflects IConstant changes.
8744 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8746 * literal.cs (NullConstant): Change to be independently usable.
8748 2006-11-29 Martin Baulig <martin@ximian.com>
8750 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8751 we need to emit the scope initializer before calling the base .ctor.
8753 * anonymous.cs: Merged back from the new anonymous methods branch.
8754 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8756 * expression.cs (ParameterReference.DoResolveBase): Create a
8757 "normal" ScopeInfo when capturing parameters rather than using the
8758 root scope; this makes things work with anonymous methods having
8762 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8764 2006-11-22 Marek Safar <marek.safar@gmail.com>
8766 A fix for bug #79987
8767 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8768 check to a base class.
8769 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8770 only when assembly has missing attribute.
8771 * report.cs: Update.
8773 2006-11-21 Marek Safar <marek.safar@gmail.com>
8775 * cs-tokenizer.cs: Merged with gmcs version.
8777 2006-11-20 Marek Safar <marek.safar@gmail.com>
8780 * cs-parser.jay: Better error message when partial keyword is misplaced.
8782 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8784 A fix for bug #79810
8785 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8786 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8787 a RuntimeWrappedException by default.
8789 2006-11-18 Marek Safar <marek.safar@gmail.com>
8791 A fix for bug #79843
8792 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8794 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8796 2006-11-18 Marek Safar <marek.safar@gmail.com>
8798 * driver.cs, namespace.cs: Uses faster IndexOf version.
8800 2006-11-17 Marek Safar <marek.safar@gmail.com>
8802 A fix for bug #79941
8803 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8805 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8806 even if internal name is different.
8807 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8808 (UserDefinedConversion): Simplified as the operators cannot be internal.
8809 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8811 (MethodLookup): Replaced EmitContext with parentType.
8812 * expression.cs: Updated.
8814 2006-11-09 Raja R Harinath <rharinath@novell.com>
8816 * driver.cs (BadAssembly): Handle all the ugliness of
8817 DefineDynamicAssembly.
8819 2006-11-08 Raja R Harinath <rharinath@novell.com>
8821 Address parts of #58244 -- most of what's left is in the runtime
8822 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8823 CS1509 error checks, and handle them for all assembly loads, not
8824 just the first invocation.
8825 (LoadModule): Likewise. Move handling of 'adder_method' ...
8826 * codegen.cs (AssemblyClass.AddModule): ... here.
8828 2006-11-02 Marek Safar <marek.safar@gmail.com>
8830 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8831 IEnumerable<T> is ambiguous.
8833 2006-10-31 Marek Safar <marek.safar@gmail.com>
8835 A fix for bug #67689
8836 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8837 GetEnumerator is ambiguous.
8839 * report.cs: Add new warning.
8841 2006-10-29 Marek Safar <marek.safar@gmail.com>
8843 A fix for bug #78602
8844 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8845 to protected member can be nested type.
8847 2006-10-28 Marek Safar <marek.safar@gmail.com>
8849 A fix for bug #78965
8850 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8851 to protected member must derive from current type.
8853 2006-10-27 Marek Safar <marek.safar@gmail.com>
8855 assign.cs: Reuses error method.
8857 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8858 instead of type for constants.
8859 (Expression.Error_ValueAssignment): Common error method.
8861 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8864 2006-10-27 Marek Safar <marek.safar@gmail.com>
8866 A fix for bug #79081
8867 * expression.cs (MemberAccess.DoResolve): Check nested type
8870 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8872 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8874 2006-10-26 Marek Safar <marek.safar@gmail.com>
8876 A fix for bug #76591
8877 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8879 2006-10-26 Marek Safar <marek.safar@gmail.com>
8881 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8882 type forwarder of the same type multiple times.
8884 2006-10-26 Raja R Harinath <rharinath@novell.com>
8887 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8888 instance as an rvalue, even when we later resolve as an lvalue.
8890 2006-10-25 Martin Baulig <martin@ximian.com>
8892 * anonymous.cs: Fix #79673.
8894 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8896 A fix for bug #79666
8897 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8898 ignored when is optimized (= default value) as its value is already set.
8900 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8902 A fix for bug #79724
8903 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8904 TypeContainer for type lookup.
8906 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8908 A fix for bug #79231
8909 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8910 * expression.cs (OverloadResolve): Always convert type name for
8912 (ResolveNamespaceOrType): Don't confuse a nested type with any
8915 2006-10-18 Martin Baulig <martin@ximian.com>
8917 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8919 2006-10-17 Miguel de Icaza <miguel@novell.com>
8921 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8922 an int32, but requesting an int64 from the conversion
8924 2006-10-12 Martin Baulig <martin@ximian.com>
8927 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8929 2006-10-12 Martin Baulig <martin@ximian.com>
8932 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8934 2006-10-11 Miguel de Icaza <miguel@novell.com>
8936 * convert.cs: Remove broken code: I was doing the "Existance"
8937 tests for Implicit conversions.
8939 2006-10-10 Miguel de Icaza <miguel@novell.com>
8941 * convert.cs: Added one missing case in
8942 ImplicitStandardConversionExists uint64 to intptr.
8946 * typemanager.cs (uintptr_type): another core known type.
8948 * ecore.cs (OperatorCast): routine used to do cast operations that
8949 depend on op_Explicit. We could change some of the Decimal
8950 conversions to use this.
8952 This one has a probe mechanism that checks both types for an op_
8953 which it coudl be used to eliminate two classes: CastToDecimal
8954 and CastFromDecimal.
8956 * convert.cs: Implement the conversions documented in #59800
8958 2006-10-10 Martin Baulig <martin@ximian.com>
8960 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8961 before RootScope.ResolveMembers().
8963 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8964 `CurrentType' if appropriate.
8966 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8968 A fix for bug #78568
8969 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8970 when contains binary operators.
8971 * cs-parser.jay: Updated.
8973 2006-10-09 Martin Baulig <martin@ximian.com>
8976 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8977 moved that into Define() and also do the other type parameter
8978 checks there. Fixes #79094. Added gtest-292.cs.
8981 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8982 since that doesn't include type parameters; don't use `Ldelema'
8983 for type parameters. Fixes #78980. Added gtest-293.cs.
8985 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8988 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8989 conversion is allowed.
8991 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8993 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8994 error reporting when no error occurs.
8996 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8998 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9001 2006-10-06 Raja R Harinath <rharinath@novell.com>
9004 * class.cs (DefineTypeBuilder): Check circular dependencies before
9005 setting the parent of the TypeBuilder.
9006 (CheckRecursiveDefinition): Don't use 'BaseType', since
9007 it may not be valid until after DefineTypeBuilder. Use
9008 'base_type' instead.
9010 2006-10-04 Martin Baulig <martin@ximian.com>
9012 Merged the Anonymous Methods patch.
9014 * anonymous.cs, iterators.cs: The new anonymous methods code.
9016 * statement.cs (Variable): New public abstract class.
9017 (LocalInfo.Variable): New public property.
9018 (LocalInfo.ResolveVariable): New public method.
9019 (Block.Flags): Add `IsIterator'.
9020 (Block.AddVariable): Improved the CS0136 check.
9021 (Block.AnonymousChildren): New public property.
9022 (Block.AddAnonymousChild): New public method.
9023 (ToplevelBlock): Update to use the new anonymous method framework.
9024 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9025 `ToplevelBlock'; this is required to correctly implement the
9027 (Fixed, Using): Use `TemporaryVariable' instead of directly
9028 creating the `LocalBuilder'.
9030 * parameter.cs (Parameter.ResolveVariable): New public method.
9031 (Parameters.ResolveVariable): Likewise.
9033 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9035 * class.cs (TypeContainer): Replaced the `iterators' list and
9036 corresponding methods with a list of `CompilerGeneratedClass'es.
9037 (TypeContainer.ResolveMembers): New public method.
9038 (Method): `IIteratorContainer' has been replaced by
9041 * expression.cs (VariableReference): New public abstract base
9042 class for `LocalVariableReference', `ParameterReference' and
9045 * codegen.cs (EmitContext): Removed `capture_context',
9046 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9047 (EmitContext.EmitThis): Removed.
9049 * cs-parser.jay: Replace `iterator_container' with
9052 2006-10-04 Martin Baulig <martin@ximian.com>
9054 * generic.cs (GenericMethod): Don't make this abstract.
9055 (Constraints.Clone): Added dummy implementation.
9057 2006-10-04 Raja R Harinath <harinath@gmail.com>
9060 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9061 'declspaces'. Avoid allocating arrays willy-nilly.
9064 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9065 cases out of the switch.
9067 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9069 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9070 message when non-generic type is used with the type arguments.
9071 * expression.cs: Updated.
9073 2006-09-28 Raja R Harinath <rharinath@novell.com>
9076 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9077 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9078 Change semantics slightly. Don't insist on having only one
9079 temporary EmptyExpression -- just throttle the creation of new ones.
9082 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9083 non-interfaces too. If no methods are found, don't try to create
9086 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9088 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9091 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9092 us produce better error message.
9094 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9096 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9097 of the `|' operator.
9099 * report.cs: A new warning added.
9101 2006-09-27 Martin Baulig <martin@ximian.com>
9103 * generic.cs (GenericMethod): Don't make this abstract.
9105 2006-09-27 Martin Baulig <martin@ximian.com>
9108 (InternalErrorException): Added overloaded ctor taking a params array.
9110 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9112 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9113 Fixed the cases when same error was reported twice.
9115 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9116 now report symbol information.
9118 2006-09-25 Martin Baulig <martin@ximian.com>
9120 * class.cs: Completely unified with the gmcs version.
9122 2006-09-25 Martin Baulig <martin@ximian.com>
9124 * typemanager.cs (TypeManager.IsNullableType): New public function.
9125 (TypeManager.IsNullableTypeOf): Likewise.
9126 (TypeManager.IsNullableValueType): Likewise.
9128 * class.cs (MethodCore): Added the `GenericMethod' argument from
9129 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9131 2006-09-24 Raja R Harinath <harinath@gmail.com>
9133 * convert.cs: Unify with gmcs version.
9135 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9137 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9138 verify them as well.
9140 * report.cs: New warning.
9142 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9144 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9145 for anonymous block with out argument.
9147 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9149 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9150 not used private events only.
9152 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9154 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9156 * const.cs (Const.Define): Check for constant type.
9157 (Const.IsConstantTypeValid): Looks for valid constant types.
9159 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9161 * ecore.cs (EmptyConstantCast): New common class for all constant based
9164 * expression.cs (Is.DoResolve): Handle null constant especially.
9165 (New.DoResolve): Check for new void().
9166 (MemberAccess.DoResolve): Cope with all kind of nulls.
9168 * literal.cs (NullConstant): Uses EmptyConstantCast.
9169 (NullDefault): Based on EmptyConstantCast.
9170 (NullLiteral): Uses EmptyConstantCast.
9172 * statement.cs (Block.ResolveMeta): Check for constant type.
9174 2006-09-22 Martin Baulig <martin@ximian.com>
9176 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9178 2006-09-22 Raja R Harinath <rharinath@novell.com>
9180 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9184 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9185 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9188 2006-09-22 Martin Baulig <martin@ximian.com>
9190 * ecore.cs: Merged with the gmcs version.
9192 * generic.cs (ConstructedType): New dummy class.
9193 (TypeArguments): Don't make this abstract.
9196 (TypeManager.IsGenericTypeDefinition): New method.
9197 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9199 2006-09-22 Raja R Harinath <rharinath@novell.com>
9201 * expression.cs (ComposedCast): Check for arrays of TypedReference
9202 before creating the type, not after.
9204 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9206 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9207 after ToType change.
9209 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9210 when constant must be implicitly convertible.
9212 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9214 * ecore.cs (NullCast): Derives from NullConstant.
9216 * expression.cs (Is.DoResolve): Removed useless variables.
9217 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9218 (New.Constantify): Add enum support.
9219 (MemberAccess.DoResolve): Add warning when accessing null constant or
9222 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9225 * literal.cs (NullConstant): New abstract class with common
9226 functionality for all null specializations.
9227 (NullDefault): Represents default(X) when result can be
9229 (NullLiteral): Updated.
9231 * report.cs: Add new warning.
9233 2006-09-21 Martin Baulig <martin@ximian.com>
9235 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9237 2006-09-21 Martin Baulig <martin@ximian.com>
9239 * generic.cs (GenericConstraints): New dummy class.
9240 (Constraints): Likewise.
9241 (TypeParameter): Likewise.
9242 (TypeParameterName): Likewise.
9243 (GenericMethod): Likewise.
9245 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9247 * decl.cs: Merged with the gmcs version.
9249 2006-09-21 Raja R Harinath <rharinath@novell.com>
9251 * generic.cs (TypeParameter): Implement IMemberContainer.
9252 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9254 * rootcontext.cs: Unify with gmcs version.
9256 * report.cs: Unify with gmcs version.
9257 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9258 from gmcs/generics.cs.
9259 * generics.cs (TypeParameter): New dummy class.
9261 * support.cs: Unify with gmcs version.
9263 2006-09-20 Raja R Harinath <rharinath@novell.com>
9265 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9266 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9268 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9269 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9270 * mcs.exe.sources: Add generic.cs.
9272 * codegen.cs: Unify with gmcs version.
9274 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9275 (EmitContext): Add GenericDeclContainer implementation.
9276 * decl.cs (MemberCore, DeclSpace): Likewise.
9277 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9279 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9280 MCS TypeManager has a corresponding dummy method.
9282 2006-09-19 Martin Baulig <martin@ximian.com>
9284 * expression.cs: Completely merged with the gmcs version.
9286 2006-09-19 Martin Baulig <martin@ximian.com>
9288 * expression.cs (Invocation): Merged with the gmcs version.
9289 (ArrayAccess.GetStoreOpcode): Likewise.
9291 2006-09-19 Martin Baulig <martin@ximian.com>
9294 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9295 (TypeManager.IsGenericMethodDefinition): Likewise.
9297 2006-09-19 Martin Baulig <martin@ximian.com>
9300 (TypeManager.IsEqual): Moved the gmcs implementation here.
9301 (TypeManager.DropGenericTypeArguments): Likewise.
9302 (TypeManager.DropGenericMethodArguments): Likewise.
9303 (TypeManager.GetTypeArguments): Moved here from gmcs.
9304 (TypeManager.HasGenericArguments): Likewise.
9306 2006-09-19 Martin Baulig <martin@ximian.com>
9308 * expression.cs (Binary): Merged with the gmcs version.
9310 2006-09-19 Martin Baulig <martin@ximian.com>
9312 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9314 2006-09-19 Martin Baulig <martin@ximian.com>
9316 * typemanager.cs: Merged with the gmcs version.
9318 2006-09-16 Raja R Harinath <rharinath@novell.com>
9320 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9321 * driver.cs: Likewise.
9323 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9326 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9327 only if parent type is class.
9328 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9331 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9334 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9336 * typemanager.cs(CSharpName): Converts NullType to null.
9338 2006-09-15 Martin Baulig <martin@ximian.com>
9341 (TypeManager.GetMethodName): Added mcs implementation.
9342 (TypeManager.IsEqual): Likewise.
9345 (SimpleName.RemoveGenericArity): Added dummy implementation.
9347 * pending.cs: Merged with the gmcs version.
9349 2006-09-15 Martin Baulig <martin@ximian.com>
9351 * statement.cs: Merge with the gmcs version.
9353 2006-09-15 Martin Baulig <martin@ximian.com>
9355 * statement.cs (Switch): Merge with the gmcs implementation
9356 (without nullables), which is newer.
9358 2006-09-15 Martin Baulig <martin@ximian.com>
9360 * statement.cs (Block.Variables): Make this public.
9361 (ToplevelBlock.Parameters): Make this a property.
9362 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9364 2006-09-15 Martin Baulig <martin@ximian.com>
9366 * namespace.cs: Merge with the gmcs version.
9368 2006-09-15 Martin Baulig <martin@ximian.com>
9370 * decl.cs (MemberName): Minor code cleanups.
9372 2006-09-15 Martin Baulig <martin@ximian.com>
9374 * parameter.cs: Merge with the gmcs version.
9376 2006-09-15 Martin Baulig <martin@ximian.com>
9378 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9379 and an error in mcs.
9381 2006-09-15 Martin Baulig <martin@ximian.com>
9383 * flowanalysis.cs: Merged from GMCS; added the generics code into
9384 a `GMCS_SOURCE' conditional so we can share this file.
9386 2006-09-08 Martin Baulig <martin@ximian.com>
9388 * typemanager.cs (TypeManager.interlocked_type): New public field.
9389 (TypeManager.int_interlocked_compare-exchange): New public field.
9390 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9391 enumerator types here and call InitGenericCoreTypes().
9392 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9393 after calling InitEnumUnderlyingTypes().
9396 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9397 `classes_second_stage'.
9399 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9401 * assign.cs, ecore.cs, expression.cs: Share error message text.
9402 * class.cs (FieldMember.Define): Check for varible of static type.
9403 * driver.cs (LoadAssembly): Uses error output for errors.
9404 * statement.cs: Updated.
9406 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9408 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9411 2006-09-07 Martin Baulig <martin@ximian.com>
9414 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9416 2006-08-29 Miguel de Icaza <miguel@novell.com>
9418 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9420 2006-08-17 Miguel de Icaza <miguel@novell.com>
9422 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9423 #52019 and #79064, the use of the \uXXXX sequence in source code
9424 to represent unicode characters.
9426 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9428 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9430 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9432 2006-08-13 Miguel de Icaza <miguel@novell.com>
9434 * assign.cs: Catch attempts to assign to a method groups in += and
9437 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9440 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9442 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9444 * class.cs (Method.Define): Issue a warning when generic method looks like
9446 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9449 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9451 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9453 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9454 search all base interfaces as a member can be ambiguous.
9455 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9456 Constructor member type filter.
9457 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9458 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9459 reporting for returned memberinfos.
9460 * report.cs: Updated.
9461 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9462 version to work on all runtimes.
9463 (TypeManager.RealMemberLookup): Removed members filtering.
9465 2006-08-08 Raja R Harinath <rharinath@novell.com>
9467 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9468 (PropertyExpr.EmitAssign): Likewise.
9469 * expression.cs (Indirection.EmitAssign): Likewise.
9470 (LocalVariableReference.EmitAssign): Likewise.
9471 (ParameterReference.EmitAssign): Likewise.
9472 (Invocation.EmitArguments): Likewise.
9473 (ArrayAccess.EmitAssign): Likewise.
9474 (IndexerAccess.EmitAssign): Likewise.
9475 (This.EmitAssign): Likewise.
9476 (ConditionalLogicalOperator.Emit): Likewise.
9479 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9480 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9481 leave it in after returning it.
9482 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9484 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9486 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9489 2006-08-03 Raja R Harinath <rharinath@novell.com>
9491 Fix cs0146-3.cs and cs0146-4.cs.
9492 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9493 enclosing types don't depend on the current type.
9495 2006-08-02 Raja R Harinath <rharinath@novell.com>
9498 * class.cs (TypeContainer.DoDefineMembers): Use
9499 FindBaseMemberWithSameName on Parent, since we're interested in
9500 whether we hide inherited members or not.
9501 (FindBaseMemberWithSameName): Make slightly more robust.
9503 Fix the non-generic testcase from #77396
9504 * decl.cs (DeclSpace.DeclContainer): Remove override.
9506 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9507 declspaces for doppelgangers too.
9508 (UsingEntry): Implement IResolveContext.
9509 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9510 'this' as the resolve context.
9511 (LocalAliasEntry): Likewise.
9513 Implement parts of #77403
9514 * roottypes.cs (RootDeclSpace): New. Used to represent the
9515 toplevel declaration space. Each namespace declaration introduces
9516 a "partial" root declaretion space.
9517 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9518 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9519 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9520 from 'current_namespace.SlaveDeclSpace'.
9521 (namespace_declaration): Likewise.
9522 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9523 check. It can't happen now.
9524 * decl.cs (DeclSpace.LookupType): Likewise.
9525 * driver.cs (MainDriver): Sanity check.
9527 2006-08-01 Raja R Harinath <rharinath@novell.com>
9529 * decl.cs (DeclSpace.FindNestedType): Remove.
9530 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9531 LookupTypeContainer to get the container of the nested type.
9532 * class.cs (TypeContainer.FindNestedType): Make non-override.
9534 2006-07-31 Raja R Harinath <rharinath@novell.com>
9536 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9537 * class.cs (TypeContainer.PartialContainer): ... here.
9538 (TypeContainer.AddBasesForPart): New helper.
9539 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9541 * cs-parser.jay (current_class): Convert to DeclSpace.
9542 (struct_declaration, interface_declaration, class_declaration):
9543 Use AddBasesForPart instead of .Bases directly.
9544 * const.cs, iterators.cs: Update to changes.
9546 2006-07-28 Raja R Harinath <rharinath@novell.com>
9548 * class.cs (TypeContainer.AddMemberType): Rename from
9550 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9551 (AddTypeContainer): New. Combine AddClassOrStruct and
9553 (AddPartial): Update. Add 'is_partial' argument.
9554 * roottypes.cs: Update to changes.
9555 * cs-parser.jay (push_current_class): New helper for handling
9556 current_container and current_class.
9557 (struct_declaration, interface_declaration, class_declaration):
9560 2006-07-26 Raja R Harinath <rharinath@novell.com>
9562 * roottypes.cs: Rename from tree.cs.
9564 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9565 * tree.cs (Tree, ITreeDump): Remove types.
9566 * rootcontext.cs (tree, Tree): Remove fields.
9567 (root, ToplevelTypes): New.
9568 * *.cs: Update to rename.
9570 * tree.cs (Tree.RecordDecl): Remove.
9571 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9573 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9575 2006-07-23 Raja R Harinath <harinath@gmail.com>
9577 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9578 DoFlowAnalysis and OmitStructFlowAnalysis here.
9579 (ec.With): Rename from WithUnsafe and generalize.
9580 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9581 (ec.WithFlowAnalyis): New.
9582 * ecore.cs, expression.cs, statement.cs: Update.
9584 2006-07-22 Raja R Harinath <harinath@gmail.com>
9586 * statement.cs (Block.ResolveMeta): Simplify slightly.
9588 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9589 multiple boolean fields. Convert InUnsafe, constant_check_state,
9590 check_state to flags.
9591 (CheckState, ConstantCheckState): Update.
9592 (InUnsafe): New read-only property.
9593 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9595 (WithUnsafe): New helper similar to WithCheckState.
9596 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9597 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9599 2006-07-21 Raja R Harinath <rharinath@novell.com>
9601 Make comparisons use the same IL irrespective of whether they're
9602 in a 'checked' or 'unchecked' context: one of the issues in #78899
9603 * codegen.cs (EmitContext.CheckState): Make read-only property.
9604 (EmitContext.ConstantCheckState): Likewise.
9605 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9606 helper that implement a save/restore stack for CheckState
9607 values. This is the only way to change check-state.
9608 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9609 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9610 (CheckedExpr.EmitBranchable): New forwarding method.
9611 (UnCheckedExpr): Likewise.
9612 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9613 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9614 (Checked.Resolve, checked.DoEmit): Likewise.
9616 2006-07-20 Miguel de Icaza <miguel@novell.com>
9618 * anonymous.cs: Cache the resolved anonymous delegate, and return
9619 this so that the ResolveTopBlock is only triggered once, not
9622 Currently we trigger ResolvetopBlock twice due to a first pass of
9623 argument check compatibility, and a second pass that does the
9626 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9628 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9630 * rootcontext.cs (Reset): Add helper_classes.
9632 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9635 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9638 2006-07-13 Miguel de Icaza <miguel@novell.com>
9640 * statement.cs (Lock): Handle expressions of type
9641 TypeManager.null_type specially. Fixes #78770
9643 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9645 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9648 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9650 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9651 for accessors as well.
9652 * ecore.cs (EventExpr): Add AccessorTable.
9654 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9657 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9658 for CS0122 where appropriate.
9659 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9661 (Filter): Assembly can be null in the case of top level attributes.
9663 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9667 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9668 is done at global level.
9670 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9672 A fix for #77002, Implemented TypeForwarder support.
9674 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9675 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9676 * typemanager.cs (): Add type_forwarder_attr_type.
9678 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9680 * report.cs: Add CS0469 warning.
9682 2006-06-21 Martin Baulig <martin@ximian.com>
9684 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9685 the `try'-block, so we also report CS0016 etc. there.
9687 2006-06-21 Martin Baulig <martin@ximian.com>
9690 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9692 2006-06-21 Martin Baulig <martin@ximian.com>
9694 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9695 also report CS1686 for parameters.
9697 2006-06-21 Martin Baulig <martin@ximian.com>
9699 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9700 instead of an error if the value is not implicitly convertible to
9701 the switch types; fixes #77964.
9703 2006-06-21 Raja R Harinath <rharinath@novell.com>
9706 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9707 FieldBuilder is null.
9710 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9711 'left' and 'right' before error-checking.
9713 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9715 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9717 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9718 (FieldExpr.DoResolve): likewise.
9719 (PropertyExpr.InstanceResolve): likewise.
9720 (EventExpr.InstanceResolve): likewise.
9722 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9724 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9725 attribute applicable tests for attribute argument.
9727 2006-06-02 Raja R Harinath <rharinath@novell.com>
9730 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9731 (Binary.OverloadResolve_PredefinedIntegral): New.
9732 (Binary.OverloadResolve_PredefinedFloating): New.
9733 (Binary.OverloadResolve_PredefinedString): New.
9734 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9735 Follow the standard more closely, and treat numeric promotions in
9736 terms of overload resolution.
9737 (Binary.CheckShiftArguments): Simplify.
9739 2006-06-01 Raja R Harinath <rharinath@novell.com>
9741 * flowanalysis.cs (MyBitVector): Simplify representation.
9742 (MyBitVector.Clone): Avoid allocating BitArray.
9743 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9744 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9745 (*): Update. Change all references to MyBitVector.And and
9746 MyBitVector.Or to &= and |=.
9748 2006-05-29 Raja R Harinath <rharinath@novell.com>
9751 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9752 to param arguments too.
9754 2006-05-26 Miguel de Icaza <miguel@novell.com>
9756 * cs-parser.jay: Catch another parsing form for arglist being
9757 followed by other arguments. Fixes #78313.
9759 2006-05-24 Raja R Harinath <rharinath@novell.com>
9761 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9762 checking of out parameters to ...
9763 (FlowBranchingToplevel.Merge): ... here.
9764 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9765 set, propagate the origin upward, and only complain if there was
9767 (FlowBranchingException.AddContinueOrigin): Likewise.
9768 (FlowBranchingException.AddReturnOrigin): Likewise.
9769 (FlowBranchingException.AddGotoOrigin): Likewise.
9771 2006-05-23 Raja R Harinath <rharinath@novell.com>
9773 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9774 unreachable, skip it.
9775 (FlowBranchingException.Merge): Always propagate jumps, even if
9776 the finally block renders subsequent code unreachable.
9778 2006-05-18 Raja R Harinath <rharinath@novell.com>
9781 * statement.cs (Goto.Resolve): Move responsibility for resolving
9782 'goto' to FlowBranching.AddGotoOrigin.
9783 (Goto.SetResolvedTarget): New. Callback to set the
9784 LabeledStatement that's the target of the goto.
9785 (Goto.DoEmit): Use Leave instead of Br when crossing an
9786 unwind-protect boundary.
9787 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9788 LookupLabel and adjust to new semantics.
9789 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9790 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9791 Goto.SetResolvedTarget to update target.
9792 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9793 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9794 AddBreakOrigin & co. Delay propagation until ...
9795 (FlowBranchingException.Merge): ... this.
9797 * statement.cs (Block.Resolve): Always depend on flow-branching to
9798 determine unreachability. Kill workaround that originally emitted
9799 only one statement after an "unreachable" label (see infloop in
9802 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9803 This is still "wrong", but anything better would probably need a
9804 multi-pass algorithm.
9805 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9806 usage vector. Force current usage vector to be reachable, to
9807 optimistically signify backward jumps.
9808 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9810 (FlowBranchingLabeled.Merge): New. If no backward jump was
9811 detected, return the original salted-away usage vector instead,
9812 updated with appropriate changes. Print unreachable warning if
9814 * statement.cs (Block.Resolve): Don't print unreachable warning on
9815 a labeled statement.
9817 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9819 * driver.cs: Pass filename without path to AssemblyBuilder's
9820 AddResourceFile. Fixes bug #78407.
9822 2006-05-17 Raja R Harinath <rharinath@novell.com>
9824 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9825 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9826 (FlowBranching.MergeChild): Overwrite
9827 reachability information from Labeled branchings too.
9829 2006-05-16 Raja R Harinath <rharinath@novell.com>
9831 * statement.cs (Goto.Resolve): Merge jump origins here ...
9832 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9834 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9835 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9836 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9837 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9839 * statement.cs (Goto.Resolve): ... not here.
9840 (Goto.Emit): Remove CS1632 check.
9842 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9844 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9847 2006-05-11 Raja R Harinath <rharinath@novell.com>
9849 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9850 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9851 (FlowBranchingException.Label): Likewise.
9853 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9855 (MyBitVector.Or): Use it to avoid losing information (Count).
9856 (FlowBranching.MergeOrigins): Likewise.
9858 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9859 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9860 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9861 (UsageVector.ToString): Simplify.
9862 (UsageVector.MergeSiblings): Move here from ...
9863 (FlowBranching.Merge): ... here.
9864 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9867 2006-05-10 Raja R Harinath <rharinath@novell.com>
9869 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9870 null bitvector is treated as all-true.
9872 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9873 (MyBitVector): Rationalize invariants. 'vector != null' implies
9874 that we have our own copy of the bitvector. Otherwise,
9875 'InheritsFrom == null' implies all inherited bits are true.
9877 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9879 * statement.cs (LocalInfo): Add IsConstant.
9880 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9881 local variable for constants.
9883 2006-05-09 Raja R Harinath <rharinath@novell.com>
9885 * flowanalysis.cs (MyBitVector.Empty): New.
9886 (MyBitVector): Don't allow InheritedFrom to be null.
9887 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9888 (UsageVector, FlowBranching): Update to changes.
9890 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9891 recursion. The 'Parent == null' condition isn't sufficient for
9893 (FlowBranching.AddBreakOrigin): Likewise.
9894 (FlowBranching.AddContinueOrigin): Likewise.
9895 (FlowBranching.AddReturnOrigin): Likewise.
9896 (FlowBranching.StealFinallyClauses): Likewise.
9897 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9898 (FlowBranching.CheckOutParameters): Likewise.
9899 (FlowBranchingToplevel): Terminate all the above recursions here.
9900 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9901 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9903 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9905 (FlowBranchingToplevel): New. Empty for now.
9906 (FlowBranching.MergeTopBlock): Update.
9907 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9908 branching for the anonymous delegate.
9909 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9911 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9912 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9913 information at the start of the merge. Reorganize.
9915 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9917 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9919 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9921 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9922 to newly introduced ctor.
9924 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9925 message to one place.
9926 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9929 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9931 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9933 * ecore.cs (Expression.ResolveAsConstant): Updated.
9935 * statement.cs (ResolveMeta): Updated.
9937 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9939 * cs-parser.jay: __arglist cannot be used in initializer.
9941 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9944 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9947 2006-05-05 Raja R Harinath <rharinath@novell.com>
9949 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9950 (LabeledStatement): Add 'name' parameter.
9951 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9952 (Block.AddLabel): Update to changes.
9953 * cs-parser.jay (labeled_statement): Likewise.
9955 * flowanalysis.cs (BranchingType.Labeled): New.
9956 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9957 (FlowBranchingLabeled): New. Does nothing for now, but will
9958 eventually handle 'goto' flows.
9959 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9960 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9961 that's terminated ...
9962 (Block.Resolve): ... here.
9964 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9965 (UsageVector.MergeFinallyOrigins): Likewise.
9966 (FlowBranching.InTryOrCatch): Likewise.
9967 (FlowBranching.AddFinallyVector): Likewise.
9968 (FlowBranchingException): Update to changes.
9971 * statement.cs (Return.Resolve): Move error checking to ...
9972 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9973 (FlowBranchingException): Handle return origins like break and
9975 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9977 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9980 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9983 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9986 * class.cs (MethodData.Define): Do public accessor check only when method
9987 implements an interface.
9989 2006-05-04 Raja R Harinath <rharinath@novell.com>
9991 Remove special handling of 'break'
9992 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9993 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9994 (UsageVector.Break): Remove.
9995 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9997 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9999 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10000 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10002 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10005 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10006 be the interface member.
10008 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10011 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10012 for emitting small (int) values.
10014 2006-05-03 Raja R Harinath <rharinath@novell.com>
10017 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10018 control-flow passes through the 'finally' after merging-in all the
10019 control-flows from 'try' and the 'catch' clauses.
10021 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10022 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10023 always true at the only non-recursive entry point.
10024 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10025 FlowBranchingBreakable.
10026 (FlowBranchingLoop): Remove.
10027 * statement.cs (Return.DoResolve): Update to changes.
10030 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10031 (FlowBranching.CreateBranching): Handle it: create a
10032 FlowBranchingContinuable.
10033 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10034 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10035 except that it handles the 'continue' command.
10036 (FlowBranching.UsageVector.MergeOrigins): Rename from
10038 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10039 except that it overrides AddContinueOrigin.
10040 (FlowBranchingException): Override AddContinueOrigin, similar to
10042 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10043 Create a new branching around the embedded statement.
10044 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10045 control flow after the embedded statement.
10046 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10048 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10049 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10050 FlowBranchingBreakable.
10051 (FlowBranchingSwitch): Remove.
10054 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10055 error reporting to ...
10056 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10057 Rename from 'AddBreakVector'. Add new location argument. Return
10058 a bool indicating whether the 'break' crosses an unwind-protect.
10059 (FlowBranchingException.AddBreakOrigin): Add.
10060 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10061 flowbranching after updating with the effects of the 'finally'
10063 (FlowBranchingBreakable): New common base class for
10064 FlowBranchingLoop and FlowBranchingSwitch.
10066 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10067 embedded statement.
10068 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10070 2006-05-02 Raja R Harinath <rharinath@novell.com>
10072 * statement.cs (Do.Resolve): If the loop is infinite, set the
10074 (While.Resolve, For.Resolve): Set a barrier after the embedded
10075 statement. There's no direct control flow that goes from the end
10076 of the embedded statement to the end of the loop.
10077 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10078 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10079 above ensure that the reachability is correctly computed.
10081 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10082 (UsageVector.MergeBreakOrigins): If the current path is
10083 unreachable, treat it as if all parameters/locals are initialized.
10084 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10085 infinite loops before merging-in break origins.
10087 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10088 (Reachability.Reachable): Split part into ...
10089 (Reachability.Unreachable): ... this. Simplify.
10090 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10092 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10093 (Reachability.SetThrowsSometimes): Likewise.
10094 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10095 TriState.Always, use corresponding property.
10096 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10097 (Block.Resolve): Likewise. Remove some redundant checks.
10099 2006-05-02 Raja R Harinath <harinath@gmail.com>
10101 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10102 (Reachability.Meet): Don't bother checking AlwaysThrows --
10103 barrier is always set.
10104 (FlowBranchingBlock.Merge): Likewise.
10106 2006-05-01 Raja R Harinath <harinath@gmail.com>
10108 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10109 checks for unreachable.
10111 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10114 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10116 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10117 whether field is really assigned.
10119 2006-04-30 Raja R Harinath <harinath@gmail.com>
10121 * flowanalysis.cs (Reachability): Make 4-argument constructor
10123 (Reachability.Meet): Rename from 'And'. Remove static variant.
10124 (Reachability.Always): Rename from the highly misleading
10125 'Reachability.Never'.
10126 (FlowBranching.Merge): Update to changes. Mark an impossible
10127 situation with a 'throw'.
10128 (*): Update to changes.
10130 2006-04-29 Raja R Harinath <harinath@gmail.com>
10132 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10133 Remove 'Undefined'.
10134 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10135 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10136 (*): Update to changes.
10137 * statement.cs: Update to changes.
10139 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10142 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10144 2006-04-28 Raja R Harinath <harinath@gmail.com>
10146 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10149 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10150 argument to two arguments: an usage-vector and a bool. Move call
10151 to FlowBranching.Merge () ...
10152 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10154 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10155 handling of loop and switch reachability to ...
10156 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10158 2006-04-27 Raja R Harinath <harinath@gmail.com>
10160 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10161 handling to FlowBranchingLoop.InLoop.
10162 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10164 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10167 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10168 anonymous method is allowed from AnonymousContainer here.
10170 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10172 2006-04-24 Raja R Harinath <rharinath@novell.com>
10175 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10177 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10180 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10181 (DoubleConstant.Reduce): Ditto.
10183 2006-04-23 Raja R Harinath <rharinath@novell.com>
10185 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10186 Remove 'lvalue_right_side' argument. Move parts to ...
10187 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10188 (LocalVariable.DoResolveLValue): ... these.
10190 2006-04-21 Raja R Harinath <rharinath@novell.com>
10193 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10194 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10195 (LocalVariableReference.DoResolveBase): Use it to implement new
10197 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10198 (Argument.Resolve): Simplify. Move CS1510 check ...
10199 * ecore.cs (Expression.ResolveLValue): ... here.
10200 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10201 (PropertyExpr.DoResolveLValue): Likewise.
10202 (FieldExpr.Report_AssignToReadonly): Likewise.
10203 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10204 LValueMemberAccess or LValueMemberOutAccess on instance depending
10206 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10207 DoResolve as appropriate.
10209 2006-04-20 Raja R Harinath <rharinath@novell.com>
10212 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10213 implicit conversions on 'out' and 'ref' arguments.
10215 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10216 improve clarity. Remove dead code.
10219 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10220 (Catch.Resolve): Resolve VarBlock if it exists.
10222 2006-04-19 Miguel de Icaza <miguel@novell.com>
10224 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10225 twice, this was some residual code, the enumerator was emitted
10226 properly in the two branche of if later.
10228 2006-04-19 Raja R Harinath <rharinath@novell.com>
10230 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10231 cast is never an lvalue.
10232 (Cast.DoResolve, Cast.ResolveRest): Combine.
10233 (Argument.Emit): Simplify slightly. Move 'Expr is
10234 IMemoryLocation' check ...
10235 (Argument.Resolve): ... here.
10236 (Argument.Error_LValueRequired): Remove. Inline into only user.
10238 Simplifications. Fix cs0191-2.cs
10239 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10240 CS1649 and CS1651 to ...
10241 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10242 the actual selection of the error code and message to a lookup
10243 table. Add a dummy return value to simplify callsites.
10244 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10245 readonly fields of other instances of the same type. Move CS0197
10247 * expression.cs (Argument.Resolve): ... here. Simplify code.
10248 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10249 resolution of an out or ref argument. The code simplification
10250 above uses this invariant.
10252 2006-04-18 Raja R Harinath <rharinath@novell.com>
10254 Possibly fix #77752. Fix cs1690-[4-7].cs.
10255 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10256 CheckMarshallByRefAccess. Drop parameter.
10257 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10259 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10260 InstanceExpression.
10261 * report.cs (AllWarnings): Add CS1690.
10262 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10263 for ref access too.
10264 (LocalVariableReference.DoResolveBase): Update.
10266 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10268 * class.cs (MethodOrOperator): Moved common parts from method class.
10269 detect obsolete attributes.
10270 (Method.Define): Simplified as it reuses code from base.
10271 (Constructor.ValidAttributeTargets): Fixed issue found during
10273 (Destructor.ValidAttributeTargets): Fixed issue found during
10275 (Operator): Finished refactoring set off by #78020. Operator class is now
10276 ordinary method class.
10278 * anonymous.cs: Updated.
10280 * decl.cs (DeclSpace): Add IsGeneric
10282 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10284 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10286 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10288 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10289 detect obsolete attributes.
10290 (Method.CreateEmitContext): Moved to MethodOrOperator.
10292 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10295 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10296 customized exception to make crash detection easier.
10297 (MethodOrOperator): Started to work on new base class for methods and
10299 (Method): Derives from MethodOrOperator.
10300 (Constructor.Emit): Emits its own attributes.
10301 (AbstractPropertyEventMethod.Emit): Ditto.
10302 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10304 (Operator.Emit): It's temporary more tricky than should be.
10306 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10308 * report.cs (InternalErrorException): Add ctor with inner exception.
10310 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10313 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10316 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10319 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10322 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10324 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10325 attribute is present and Guid not.
10326 (Interface.ApplyAttributeBuilder): Ditto.
10328 * attribute.cs: Add error message.
10330 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10334 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10335 sources (it's composite) so hold them in extra array as they are used in
10336 Emit phase only. It worked in the previous versions by mistake.
10337 (Attribute.Emit): Emit attribute for more owners when exist.
10339 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10340 it has now different behaviour.
10342 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10344 * constant.cs (Constant.IsDefaultInitializer): New method.
10346 * class.cs: Updated.
10348 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10349 re-initialize default values. It saves KBs almost for every assembly.
10350 Thanks Zoltan for the idea.
10351 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10352 (ArrayCreation.DoResolve): Resolve only once.
10353 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10354 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10356 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10358 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10361 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10363 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10364 in an embedded statement too.
10366 2006-04-01 Raja R Harinath <rharinath@novell.com>
10369 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10371 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10375 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10378 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10380 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10382 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10385 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10386 LocalTemporary change.
10388 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10390 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10391 initializers optimization.
10392 (ClassOrStruct.TypeAttr): Moved from modifiers.
10393 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10394 (FieldBase.ResolveInitializer): Resolves initializer.
10395 (FieldBase.HasDefaultInitializer): New property.
10397 * cs-parser.jay: Removed message.
10399 * expression.cs (CompilerGeneratedThis): New specialization.
10401 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10403 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10405 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10407 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10409 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10410 be now EnumConstants only.
10412 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10414 * attribute.cs, driver.cs: Reset more caches.
10416 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10418 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10420 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10422 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10423 for easier reuse. Updated all overrides.
10424 (IntegralConstant): New base class for all integral constants.
10425 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10426 of the constant range, report custom error.
10427 (UIntConstant.Reduce): Fixed uint conversion.
10429 * ecore.cs, literal.cs: Reduce updates.
10431 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10435 * class.cs (Constructor.Define): Removed extra if for default ctors.
10436 A patch from Atsushi Enomoto.
10438 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10440 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10441 GetAttributableValue.
10443 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10446 * convert.cs (ImplicitConversionRequired): Error message moved to
10449 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10450 automatic implicit conversion of an output value.
10451 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10453 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10455 (TypeOf.GetAttributableValue): Add extra handling for object type.
10457 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10458 special error message.
10460 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10462 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10464 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10465 compatible with MS runtime.
10467 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10469 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10470 attribute arguments here.
10472 * class.cs (Indexer.Define): The check was moved to attribute class.
10474 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10476 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10477 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10480 2006-03-22 Raja R Harinath <rharinath@novell.com>
10482 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10483 mcs to keep code differences small.
10484 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10485 * typemanager.cs (parameter_default_value_attribute_type): New.
10486 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10489 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10491 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10493 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10495 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10497 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10500 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10502 * doc-bootstrap.cs : fix build.
10504 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10506 * expression.cs (StringConcat.Append): Issue a warning when empty string
10507 is going to append.
10509 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10511 * assign.cs (CompoundAssign.ResolveSource): Removed.
10513 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10516 * class.cs (TypeContainer.FindMethods): Removed.
10517 (TypeContainer.CheckMemberUsage): Made static.
10519 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10521 * constant.cs (CheckRange): Removed unused type argument.
10522 (CheckUnsigned): Removed unused type argument.
10524 * cs-parser.jay: Updated after MemberAccess clean up.
10525 Uses Length for empty string test.
10527 * cs-tokenizer.cs: Uses Length for empty string test.
10528 (IsCastToken): Made static.
10529 (is_hex): Made static.
10530 (real_type_suffix): Made static.
10532 * decl.cs (SetupCache): Made static.
10533 (OnGenerateDocComment): Removed unused ds argument.
10535 * delegate.cs (VerifyDelegate): Removed unused argument.
10537 * doc.cs: Uses Length for empty string test.
10539 * driver.cs: Uses Length for empty string test.
10541 * enum.cs (IsValidEnumType): Made static
10543 * expression.cs (EnumLiftUp): Removed unused argument.
10544 (ResolveMethodGroup): Ditto.
10545 (BetterConversion): Ditto.
10546 (GetVarargsTypes): Ditto.
10547 (UpdateIndices): Ditto.
10548 (ValidateInitializers): Ditto.
10549 (MemberAccess.ctor): Ditto.
10550 (GetIndexersForType): Ditto.
10552 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10554 * iterators.cs: Updated after MemberAccess clean up.
10556 * location.cs: Uses Length for empty string test.
10558 * namespace.cs: Uses Length for empty string test.
10560 * report.cs (CheckWarningCode): Made static.
10562 * statement.cs (LabeledStatement): Removed unused argument.
10564 * typemanager.cs (FilterNone): Removed.
10566 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10568 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10571 * class.cs: Updated.
10573 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10575 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10577 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10581 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10582 reporting, it's more tricky than I thought.
10584 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10588 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10590 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10591 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10592 Add more error reporting; Fixed issue with params.
10594 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10596 * cs-parser.jay: AnonymousMethod requires host container.
10598 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10600 2006-03-18 Raja R Harinath <harinath@gmail.com>
10602 * class.cs: Change 'TypeContainer ds' constructor argument to
10603 'DeclSpace parent'. Some classes were missed below due to
10604 different naming convention.
10606 * class.cs (MemberCore.Parent): Delete. This makes the
10607 ParentContainer changes below enforceable by the compiler.
10609 Treat pointers to enclosing declaration space as 'DeclSpace', not
10611 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10612 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10614 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10616 (Block.AddThisVariable): Likewise.
10617 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10618 (AbstractPropertyEventMethod.Emit): Likewise.
10619 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10620 (GetMethod.Define, SetMethod.Define): Likewise.
10621 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10622 (DelegateMethod.EmitMethod): Likewise.
10624 Fix regression test-partial-13.cs.
10625 Rationalize use of PartialContainer. Ensure that the partial
10626 class semantics can be tied to type-correctness, i.e., any
10627 violation will cause a compile error.
10628 * class.cs, const.cs: Access all fields that belong to class
10629 TypeContainer via ParentContainer. Arguments of EmitContexts and
10630 Resolve()-like functions still use 'Parent'.
10632 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10633 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10634 (PropertyMethod.CheckModifiers): Remove unused argument.
10635 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10638 2006-03-17 Raja R Harinath <harinath@gmail.com>
10640 Make semantics of PartialContainer simpler.
10641 * decl.cs (DeclSpace.IsPartial): Remove.
10642 * class.cs (TypeContainer.IsPartial): Likewise.
10643 (TypeContainer..ctor): Set PartialContainer to point to self.
10644 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10645 (TypeContainer.FindNestedType): Likewise.
10646 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10648 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10650 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10652 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10654 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10657 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10659 * class.cs (Operator.Define): An error for base conversion was not
10660 reported correctly.
10662 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10664 * iterator.cs : yield break is allowed in try statement which has
10665 catch clauses. Fixed bug #77767.
10667 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10669 A fix for #77593, #77574.
10671 * class.cs (MethodCore.CheckBase): Another if for operator.
10673 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10675 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10678 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10679 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10682 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10685 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10686 Updated after another emitcontext usage was clean up. It should help us to
10687 synchronize with gmcs easier.
10689 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10693 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10694 (Event.Define): ditto
10695 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10697 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10698 Removed redundant code and set NewSlot for Invoke method too.
10700 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10701 (Parameters.MergeGenerated): New method. Use this method when you merge
10702 compiler generated argument with user arguments.
10704 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10706 * attribute.cs (ResolveAsTypeTerminal): Removed.
10708 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10709 specialization for predefined types; 30% speed up.
10710 Finally placed obsolete check to right place.
10711 (Expression.ResolveType): Removed.
10713 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10714 Updated after ResolveType was removed.
10716 * expression.cs (Cast.ctor): Check void cast.
10717 (Binary.ResolveAsTypeTerminal): Is never type.
10718 (Conditional.ResolveAsTypeTerminal): Is never type.
10720 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10722 2006-03-01 Raja R Harinath <rharinath@novell.com>
10725 * expression.cs (ParameterReference.DoResolveBase): Change return
10727 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10731 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10734 * typemanager.cs (GetFullNameSignature): Don't nullref on
10735 protected accessors.
10737 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10739 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10740 these two separated members to simplify the code.
10741 (Attribute.Resolve): Refactored to use new fields and methods.
10742 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10743 implemented obsolete attribute checking.
10744 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10745 implemented obsolete checking again. It look line never ending quest ;-)
10746 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10748 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10750 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10752 *class.cs (Property.Define): Add RegisterProperty call.
10754 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10755 argument groups (only 2).
10757 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10758 encoding expression to arguments.
10759 (Expression.ExprClassToResolveFlags): Just turned to property.
10761 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10762 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10763 optimized as well as implemented support for zero-length attributes.
10765 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10766 Add caching of PropertyInfo's.
10768 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10770 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10771 error multiple times.
10773 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10775 New partial class implementation.
10776 A fix for #77027, #77029, #77403
10778 * attribute.cs (Attributable): Made attributes protected.
10780 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10781 the replacements of ClassPart and PartialContainer.
10782 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10783 (TypeContainer.AddInterface): Ditto.
10784 (TypeContainer.AddPartial): The main method for partial classes. It checks
10785 for errors and merges ModFlags and attributes. At the end class is added to
10786 partial_parts list.
10787 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10789 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10790 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10791 from the rest of partial classes.
10792 (TypeContainer.GetClassBases): Simplified.
10793 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10795 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10796 (TypeContainer.HasExplicitLayout): Uses Flags now.
10797 (PartialContainer): Removed.
10798 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10799 (StaticClass): Was merged with Class.
10800 (Class.GetClassBases): class and static class bases are verified here.
10801 (Class.TypeAttr): Added static attributes when class is static.
10802 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10803 (MemberBase): In some cases we need to call parent container for partial
10804 class. It should be eliminated but it's not easy now.
10806 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10808 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10809 partial classed to accumulate class comments.
10810 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10812 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10814 * driver.cs (MainDriver): Tree.GetDecl was removed.
10816 * modifiers.cs (Modifiers): Add partial modifier.
10818 * tree.cs (Tree.decl): Removed.
10819 (RootTypes): Started to use this class more often for root types
10822 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10826 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10827 external interface does not have an attribute.
10829 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10831 Another prerequisites for new partial classs implementation.
10833 * attribute.cs (Attribute.Equal): Implemented.
10834 (Attribute.Emit): Changed as attributes can be applied more than twice.
10835 (Attributes.Emit): Check for duplicate attributes here.
10837 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10838 as a parameter, clean-up.
10840 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10844 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10845 contains obsolete attribute check which can in some cases look for base
10846 type of current class which is not initialized yet.
10847 (TypeContainer.BaseType): Replacement of ptype.
10849 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10851 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10853 First of prerequisites for new partial classs implemention.
10855 * attribute.cs (Attributable): Extended by ResolveContext;
10856 Attributes finally have correct context for resolving in all cases.
10857 (AttachTo): Attribute owner is assigned here.
10859 * codegen.cs (IResolveContext): Introduce new interface to hold
10860 all information needed in resolving phase.
10861 (EmitContext): Implements IResolveContext; more clean-up needed here.
10863 * decl.cs (MemberCore): Implemented IResolveContext.
10865 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10866 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10867 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10868 Refactored to use new IResolveContext instead of EmitContext; cleanup
10870 2006-02-06 Miguel de Icaza <miguel@novell.com>
10872 * codegen.cs (EmitScopeInitFromBlock): check here the
10873 capture_context, there is no need to make two calls to the
10876 * anonymous.cs: Add some debugging messages that might help me
10877 track other instances of this problem in the future (the
10878 regression of test 467).
10880 * cs-parser.jay: track the variable block, as we need to initalize
10881 any captured variables declared in this block for the "catch"
10882 portion of the "Try" statement.
10884 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10885 scope initialization for captured variables.
10887 Also, move the emit for the variables after the block location has
10890 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10892 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10894 2006-02-02 Miguel de Icaza <miguel@novell.com>
10896 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10897 commit yesterday, the initialization for the roots is necessary.
10898 What is not necessary is the scope activation.
10900 2006-02-02 Raja R Harinath <rharinath@novell.com>
10902 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10903 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10905 (Argument.Resolve): Remove CS0206 checks.
10907 2006-02-01 Miguel de Icaza <miguel@novell.com>
10909 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10910 scopes for all the roots, the scopes will now be emitted when the
10911 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10913 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10914 code. This reduces a lot of existing cruft.
10916 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10917 that the ScopeInfo is generated as we enter the scope, not at the
10918 time of use, which is what we used to do before.
10920 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10921 every time a Block is about to be emitted if we have a
10924 2006-02-01 Raja R Harinath <rharinath@novell.com>
10926 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10928 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10930 * typemanager.cs (cons_param_array_attribute): Make private.
10931 (Reset): Set it to null.
10932 (InitCoreHelpers): Don't initialize it.
10933 (ConsParamArrayAttribute): New. Initialize it as needed.
10934 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10936 2006-01-31 Miguel de Icaza <miguel@novell.com>
10938 * expression.cs: There might be errors reported during the
10939 selection of applicable methods. If there are errors, do not
10940 continue execution as it will lead the compiler to crash.
10942 2006-01-30 Miguel de Icaza <miguel@novell.com>
10944 * expression.cs: Member access is not allowed on anonymous
10945 methods. Fixes #77402.
10947 2006-01-30 Raja R Harinath <rharinath@novell.com>
10950 * cs-parser.jay (VariableDeclaration): Don't set
10951 current_array_type to null.
10952 (field_declaration, event_declaration, declaration_statement):
10953 Set it to null here.
10955 2006-01-28 Raja R Harinath <harinath@gmail.com>
10957 * typemanager.cs (GenericParameterPosition): New.
10960 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10962 * doc.cs : To process "include" elements, first we should create
10963 another list than XmlNodeList, because it could result in node
10964 removal, which could result in that the XmlNodeList gives up
10965 yielding next node.
10967 (Also made code identical to gmcs again.)
10969 2006-01-25 Miguel de Icaza <miguel@novell.com>
10971 * ecore.cs: Introduce an error report that we were not catching
10972 before, if not silent, we must report the error. Gonzalo ran into
10975 2006-01-23 Miguel de Icaza <miguel@novell.com>
10977 A fix for bug: #76957
10979 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10980 ComputeMethodHost before creating the method, this is a new
10983 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10984 that this method references (RegisterScope). The actual scope
10985 where the method is hosted is computed with the ComputeMethodHost
10986 before we create the method.
10988 Moved the Deepest routine here.
10990 (AnonymousContainer.ComputeMethodHost): New routine used to
10991 compute the proper ScopeInfo that will host the anonymous method.
10993 (ScopeInfo): Deal with multiple roots. The problem was that we
10994 did not have a unique root where all ScopeInfos could be hanged
10995 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10998 Remove AdjustMethodScope which is now computed at the end. Remove
10999 LinkScope which did a partial link, instead link all ScopeInfos
11000 before code generation from the new "LinkScopes" routine.
11002 Simplify all the Add* routines as they no longer need to maintain
11003 the tree, they just need to record that they are using variables
11006 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11007 routines to produce the forest of ScopeInfo trees.
11009 * class.cs (TypeContainer.AppendMethod): This is just like
11010 AddMethod, but ensures that an interface implementation method
11011 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11012 methods, but at the end.
11014 We use this functionality to ensure that the generated MoveNext
11015 method in the iterator class is resolved/emitted before the
11016 enumerator methods created.
11018 This is required because the MoveNext method computes the right
11019 ScopeInfo for the method. And the other methods will eventually
11020 need to resolve and fetch information computed from the anonymous
11023 2006-01-21 Raja R Harinath <harinath@gmail.com>
11024 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11026 Fix rest of #76995.
11027 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11028 the 'aliases' hash.
11029 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11030 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11032 2006-01-18 Raja R Harinath <rharinath@novell.com>
11034 Fix #76656, cs0231-2.cs.
11035 * cs-parser.jay (formal_parameter_list): Make error case catch
11037 (parenthesized_expression_0): Add CS1026 check.
11038 (invocation_expression): Remove unused { $$ = lexer.Location }.
11040 2006-01-17 Raja R Harinath <rharinath@novell.com>
11043 * cs-parser.jay (statement_expression): Don't list out the
11044 individual statement-expressions. Convert syntax error into
11047 2006-01-16 Raja R Harinath <rharinath@novell.com>
11050 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11051 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11052 CheckIntermediateModification.
11053 (FieldExpr.DoResolve): Add new two-argument version that
11054 allows us to resolve the InstanceExpression as an lvalue.
11055 The one-argument variant is now just a wrapper.
11056 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11057 Resolve the lhs as an lvalue if the it has a value type.
11058 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11059 from Assign.DoResolve.
11060 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11061 resolved as an lvalue.
11062 (PropertyExpr.DoResolve): Update.
11063 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11064 has a value type. Move CS1612 check here from
11065 CheckIntermediateModification.
11066 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11067 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11068 'right_side' of a ResolveLValue on an 'out' argument.
11069 (EmptyExpression.LValueMemberAccess): New. Used as the
11070 'right_side' of a propagated ResolveLValue on a value type.
11071 (LocalVariableReference.DoResolveBase): Recognize
11072 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11074 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11075 EmptyExpression.Null.
11077 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11079 * typemanager.cs : added IsGenericParameter(). In mcs it always
11081 * doc.cs : for generic parameters, use GenericParameterPosition,
11084 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11086 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11088 2006-01-12 Miguel de Icaza <miguel@novell.com>
11090 This fixes the problem where we used ldfld instead of ldflda to
11091 load the "THIS" pointer on captured parameters, when THIS is a
11092 value type. See bug #77205.
11094 * iterators.cs (CapturedThisReference.Emit): Pass false to
11095 EmitThis (we do not need the address).
11097 * codegen.cs (EmitThis): it needs to know whether we need the
11098 address of `this' or not. This is used by value types.
11100 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11101 every other call passes false.
11103 2006-01-12 Raja R Harinath <rharinath@novell.com>
11106 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11108 * expression.cs (Invocation.OverloadResolve): Update.
11109 (Invocation.DoResolve): Avoid double resolution of invocation.
11111 2006-01-11 Raja R Harinath <rharinath@novell.com>
11114 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11115 unary negation of floating point types as 0-expr; negation cannot
11116 overflow in floating point types.
11119 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11120 on operands of 'void' type.
11123 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11124 and ExclusiveOr for boolean constants too.
11126 2006-01-09 Raja R Harinath <rharinath@novell.com>
11129 * expression.cs (Invocation.OverloadResolve): Replace reflected
11130 override methods with their base virtual methods, rather than
11131 skipping over them.
11132 * typemanager.cs (TypeManager.GetOverride): New.
11134 2006-01-05 Jb Evain <jbevain@gmail.com>
11136 * class.cs (Property.Define, Indexer.Define): do not tag the
11137 properties as SpecialName | RTSpecialName.
11139 2006-01-04 Miguel de Icaza <miguel@novell.com>
11141 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11142 doing a low-level comparission of parameter types. It was lacking
11143 a check for __argslist.
11145 2005-12-30 Miguel de Icaza <miguel@novell.com>
11147 * expression.cs (ParameterReference.DoResolveBase): Allow
11148 reference parameters if they are local to this block.
11150 This allows the ref and out parameters of a delegate to be used in
11151 an anonymous method, for example:
11153 delegate void set (out int x);
11155 set s = delegate (out int x){
11159 This is used by functionality introduced late in the C# language.
11161 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11162 method that take ref and out parameters.
11164 Fixes #77119 which was a late change in the spec.
11166 2005-12-23 Miguel de Icaza <miguel@novell.com>
11168 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11169 parent if its the same scope. Fixes #77060.
11171 2005-12-21 Miguel de Icaza <miguel@novell.com>
11173 * driver.cs: Report the case of no source files and no -out:
11176 2005-12-20 Raja R Harinath <rharinath@novell.com>
11179 * expression.cs (ComposedCast.GetSignatureForError): Define.
11181 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11185 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11186 ListDictionary, to contain the ExternAliasEntry entries (in
11187 addition to the NamespaceEntry.aliases hashtable). This field is
11188 shared between the original entry and its doppelganger (bodyless
11190 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11191 extern_aliases field.
11192 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11193 lookup in extern_aliases.
11195 2005-12-16 Raja R Harinath <rharinath@novell.com>
11198 * class.cs (TypeContainer.Mark_HasEquals): New.
11199 (TypeContainer.Mark_HasGetHashCode): New.
11200 (ClassPart): Override them.
11201 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11204 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11205 'parent' argument to the base constructor.
11207 Remove all mention of TypeContainer from decl.cs.
11208 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11209 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11210 (DeclSpace.DeclSpace): Likewise.
11211 (DeclSpace.DefineMembers): Remove unused argument.
11212 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11213 debugging check -- we don't care if the debug code throws an
11214 InvalidCastException instead of an InternalErrorException.
11215 * class.cs (TypeContainer.DefineMembers): Update to changes.
11216 (TypeContainer.DoDefineMembers): Likewise.
11217 (TypeContainer.GetMethods): Likewise.
11218 (PropertyMember.Define): Likewise.
11219 (MemberBase.Parent): New property that forwards to
11220 MemberCore.Parent, but ensures that we get a TypeContainer.
11221 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11222 (RootContext.PopulateTypes): Likewise. Remove special case code
11223 for !RootContext.StdLib: DefineMembers is idempotent.
11225 2005-12-14 Miguel de Icaza <miguel@novell.com>
11227 * convert.cs (ExplicitConversionCore): Check the return value from
11228 ExplicitConversionCore which can return null on failure. Fixes #76914
11230 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11232 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11234 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11236 * doc.cs : The search for referenced namespace was insufficient to
11237 get global one as it used to do. Fixed bug #76965.
11239 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11241 * doc.cs : check name in cref in the last phase that whether it is
11244 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11246 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11249 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11251 * doc.cs : so it turned out that we cannot skip override check for
11252 interface members. Fixed bug #76954.
11254 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11256 * cs-tokenizer.cs : fixed bug #75984:
11257 - #warning and #error should not be handled when the source line
11259 - #line is not checked strictly when the source line is disabled.
11260 - #define and #undef is on the other hand checked strictly at any
11263 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11265 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11268 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11270 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11272 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11273 event initializers.
11274 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11275 (FieldBase.Initializer): Initializer is now optional.
11276 (EventField.Define): Only event field can have initializer.
11278 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11280 * const.cs (Const): Reuse initializer.
11282 * cs-parser.jay: Updated after FieldBase changes.
11283 Added current_array_type to simplify array initializers.
11285 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11287 * expression.cs, iterators.cs: Updated.
11289 * namespace.cs (NamespaceEntry): Made UsingFound private.
11291 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11293 * parameterCollection.cs: Obsolete, removed.
11294 * parser.cs: Obsolete, removed.
11296 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11299 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11301 * enum.cs (Enum.Define): Set obsolete context here.
11303 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11306 - FindDocumentedMember() now expects 1) paramList as null
11307 when "we don't have to check the number of parameters" and
11308 2) Type.EmptyTypes when "there is no arguments".
11309 - Introduced FoundMember struct to hold the exact type which was
11310 used to find the documented member (the above change broke
11311 test-xml-044; it might be better just to use DeclaringType than
11312 what MS does, like this change does, but it depends on usage.)
11314 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11316 * doc.cs : documented member might be from DeclaringType for nested
11317 types. Fixed bug #76782.
11319 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11321 * anonymous.cs: Have the param code handle leaving copies on the
11322 stack etc. Allows anonymous params to take part in the assignment
11323 code (++, +=, etc). Fixes bug #76550
11325 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11326 it down to the anon code.
11328 * iterators.cs: Use dummy var here
11330 * codegen.cs: Handle new vars
11332 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11335 * class.cs (MethodData.Define): Set proper Obsolete context.
11337 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11339 (FieldExpr.DoResolve): Ditto.
11341 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11344 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11345 parent is not obsolete.
11347 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11349 * doc.cs : (FindDocumentedMember) find parameterless members first
11350 and get CS0419 in the early stage. Fixed first case of bug #76727.
11352 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11355 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11356 no error was reported.
11358 *expression.cs (Binary.DoResolve): left can be null.
11360 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11363 * class.cs (MethodData.Emit): Parameters should be labeled first.
11365 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11368 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11370 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11372 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11374 * class.cs (MethodCore): Parameter clean up.
11375 (IMethodData): Added ParameterInfo.
11376 (MethodData): Parameter clean up.
11377 (Indexer.Define): Parameter clean up.
11389 * typemanager.cs: Parameter clean up.
11391 * delegate.cs (Define): Get rid of duplicated code.
11393 * expression.cs (ParameterReference): Removed useless parameters
11395 (Invocation): Ditto.
11397 * parameter.cs (ParamsParameter): New class, params specialization.
11398 (ArglistParameter): Attemp to separate arglist.
11399 (Parameter): Refactored to be reusable and faster.
11400 (Parameter.Modifier): Made understandable.
11401 (Parameters): Changed to be used as a class for `this' assembly
11402 parameters. Refactored to use new specialized classes.
11404 * support.cs (ParameterData): Added Types property.
11405 (InternalParameters): Deleted.
11407 2005-08-20 Martin Baulig <martin@ximian.com>
11409 Merging this patch from GMCS to fix #75867.
11411 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11412 scope if we don't already have it.
11414 2005-11-17 Martin Baulig <martin@ximian.com>
11417 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11418 inherit the scope from our parent. Fixes #76653.
11420 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11422 * doc.cs : the previous patch does not actually fix the bug.
11423 PropertyInfo override check is now implemented and really fixed it.
11424 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11426 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11428 * doc.cs : apply "override filter" also to properties.
11431 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11433 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11434 no need to check overrides. For classes, omit those results from
11435 interfaces since they must exist in the class. Fixed bug #76726.
11437 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11439 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11440 with different parameters. Fixed the second problem in #76685.
11442 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11444 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11445 get expected 'protected' access in CheckValidFamilyAccess()).
11448 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11450 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11451 Fixed bug #76705. CS1569 was incorrectly commented out.
11453 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11455 * doc.cs : use Invocation.IsOverride() to do real override check.
11456 * expression.cs : made Invocation.IsOverride() internal.
11458 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11460 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11461 TypeBuilder.FindMembers() and filter overriden base members out.
11464 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11466 * doc.cs : ref/out parameters are represented as '@' (instead of
11467 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11469 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11471 * doc.cs : when there was no '.' in cref to methods in doc comment,
11472 then parameters were missing in the output. Fixed bug #76691.
11474 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11476 * driver.cs : don't output docs when there is an error.
11479 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11482 Now it should detect indexers. Fixed primary concern in bug #76685.
11483 Fixed CS0419 message to not show the identical member signature in
11486 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11488 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11489 instead of Type.FindMembers() since it does not handle events.
11492 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11494 * codegen.cs: Fixed typo (speficied -> specified).
11496 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11499 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11501 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11503 * attribute.cs: Changed error message.
11505 * cs-tokenizer.cs: One more check.
11507 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11509 * statement.cs (Block.Resolve): Ignore empty statement.
11511 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11513 * report.cs: Made error/warning methods more strict to avoid
11516 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11517 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11518 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11519 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11521 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11523 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11524 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11526 * class.cs (TypeContainer.IsComImport): New property.
11527 (Constructor.Define): Create proper ctor for ComImport types.
11529 * expression.cs (New.CheckComImport): Fixed.
11531 2005-11-07 Miguel de Icaza <miguel@novell.com>
11533 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11534 that a parameter has been captured does not mean that we do not
11535 have to do the rest of the processing. This fixes the second part
11536 of #76592. If there was another anonymous method capturing
11537 values in the past, the Scope would never be set for the second
11538 method that captured the same parameter.
11540 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11541 properly manipulate the stack. Second part of fix for #76592.
11543 * expression.cs (New): Add support for invoking "new" on
11544 interfaces that have been flagged with the ComImport attribute and
11545 the CoClass. Fixes #76637
11547 * statement.cs (Try.DoEmit): When a variable is captured, do not
11548 try to emit the vi.LocalBuilder variable as it has been captured.
11549 Create a temporary variable and store the results on the
11550 FieldBuilder. Fixes #76642
11552 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11554 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11556 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11558 * expression.cs (Binary.DoResolve): Added && optimalization.
11560 * typemanager.cs (AddUserType): Removed useless argument.
11562 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11564 * statement.cs (Block.variables): Uses ListDictionary.
11566 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11569 * class.cs (PartialContainer.EmitType): Customized to emit
11570 security attributes.
11571 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11572 for partial classes.
11574 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11577 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11578 access has to be fixed.
11580 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11582 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11585 * ecore.cs (NullCast.Reduce): Implemented.
11587 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11590 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11592 (Foreach.Resolve): Catch null properly.
11594 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11596 * cs-tokenizer.cs: Warning text fix.
11598 * driver.cs: AllWarningNumbers exposed on public interface.
11600 * report.cs (): Reviewed warning numbers.
11601 (IsValidWarning): Use binary search.
11603 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11605 * driver.cs: Implemeted resource visibility.
11606 (Resources): New class for code sharing between /res: and
11609 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11612 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11615 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11618 * ecore.cs (NullCast): Child is contant only.
11620 * literal.cs (NullLiteral.Reduce): null can be converted to any
11623 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11625 * driver.cs: Use Encoding.Default as default code page instead
11628 2005-10-27 Raja R Harinath <rharinath@novell.com>
11631 * expression.cs (Invocation.Error_InvalidArguments): Handle
11632 __arglist parameters.
11633 (Invocation.VerifyArgumentsCompat): Likewise.
11634 * support.cs (ReflectionParameters.GetSignatureForError): Print
11635 __arglist parameters.
11636 (InternalParamters.GetSignatureForError): Likewise.
11637 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11639 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11641 * attribute.cs (GetPropertyValue): Made public.
11643 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11645 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11647 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11650 * driver.cs: Reflect method name change.
11652 * statement.cs (Try.Resolve): Warn when try has both general
11653 exception handlers.
11655 * typemanager.cs: runtime_compatibility_attr_type new predefined
11658 2005-10-26 Raja R Harinath <harinath@gmail.com>
11661 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11662 treat it as an empty parameter list.
11664 2005-10-26 Raja R Harinath <rharinath@novell.com>
11667 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11668 ResolveAsTypeStep silent.
11669 * statement.cs (Block.AddConstant): Mark block as used.
11670 (Block.ResolveMeta): Avoid piling on error messages
11671 if a constant initializer resolution fails.
11673 2005-10-25 Raja R Harinath <rharinath@novell.com>
11675 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11677 (NamespaceEntry.VerifyAllUsing): New.
11678 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11679 behaviour. Delegates actual resolution of alias to ...
11680 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11681 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11683 * driver.cs (Driver.MainDriver): Update.
11685 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11686 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11688 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11690 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11691 RootNamespace.DefineNamespacesForAll.
11693 2005-10-24 Raja R Harinath <harinath@gmail.com>
11695 * typemanager.cs (assemblies, external_aliases, modules)
11696 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11697 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11698 overhead. Move resposibility ...
11699 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11700 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11702 2005-10-23 Raja R Harinath <harinath@gmail.com>
11704 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11705 cached_namespaces. Improve usage.
11706 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11707 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11708 Move from GlobalRootNamespace and simplify.
11709 (RootNamespace.Global): Make instance variable.
11710 (RootNamespace.RootNamespace): Add "alias name" parameter.
11711 (GlobalRootNamespace): Simplify drastically.
11712 (Namespace.Lookup): Don't use GetNamespace.
11713 * typemanager.cs (GetRootNamespace): Rename from
11714 ComputeNamespaceForAlias.
11715 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11717 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11719 * anonymous.cs (AnonymousContainer): Don't crash when container
11722 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11724 * expression.cs (Binary.DoResolve): Warn when comparing same
11727 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11730 * expression.cs (Binary.DoResolve): It looks like there are no
11731 convetsion rules in enum context.
11733 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11735 Add support for extern alias qualifiers.
11736 * typemanager.cs: Move some LookupTypeReflection code
11737 to namespace.cs, to have cleaner code. Added some methods
11738 to help us keep track of the extern aliased references.
11739 * driver.cs: Add suport for extern alias assemblies on command
11740 line and check for their warnings/errors. Also keep track of the
11741 extern aliased assemblies.
11742 * namespace.cs: Move the global functionality of Namespace
11743 to GlobalRootNamespace/RootNamespace. Now the global namespace
11744 is GlobalRootNamespace.Globa. Also the code moved from
11745 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11746 Finally added LocalAliasEntry (AliasEntry before) and
11747 ExternAliasEntry, to handle alias statements.
11748 * cs-parser.jay: Add support in the grammar for extern alias
11750 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11751 Update callings to Namespace (now in GlobalRootNamespace).
11753 2005-10-18 Raja R Harinath <rharinath@novell.com>
11756 * class.cs (TypeContainer.DefineType): Move updating of
11757 topological sort earlier in the code.
11758 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11760 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11763 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11765 * constant.cs (Constant.TryReduce): Moved from Cast class.
11766 (Reduce): Made little bit more OO and fixed missing conversions.
11768 * ecore.cs (Reduce): Implemented.
11769 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11771 * literal.cs (Reduce): Implemented.
11773 * class.cs: Reverted Miguel's wrong commit.
11775 2005-10-14 Miguel de Icaza <miguel@novell.com>
11777 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11779 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11781 * cs-parser.jay, expression.cs : CS0214 was missing error location
11782 for constants. Fixed bug #76404.
11784 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11787 * convert.cs (ExplicitConversionCore): Fixed object->enum
11790 2005-10-10 Raja R Harinath <rharinath@novell.com>
11792 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11793 InstanceExpression.
11794 (PropertyExpr.EmitCall): Likewise.
11795 * expression.cs (Invocation.EmitArguments): Handle case where
11797 (Invocation.EmitCall): Avoid allocating temporary variable if
11798 there are no arguments.
11800 2005-10-07 Raja R Harinath <rharinath@novell.com>
11803 * convert.cs (ImplicitConversionStandard): Move conversion of
11804 void* to arbitrary pointer types ...
11805 (ExplicitConversionStandard): .. here.
11806 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11807 error to always print typenames.
11809 2005-10-07 Raja R Harinath <rharinath@novell.com>
11811 * convert.cs (GetConversionOperator): Rename from
11812 GetConversionOperators. Move operator selection code from ...
11813 (UserDefinedConversion): ... here.
11815 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11817 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11820 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11822 * assign.cs (Assign.DoResolve): Error method changed.
11824 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11826 * const.cs (ResolveValue): Reset in_transit immediately.
11828 * constant.cs: Error method changed.
11830 * convert.cs: Removed useless location parameter.
11831 (ExplicitNumericConversion): Don't do double enum check.
11832 (ExplicitConversionCore): Renamed from ExplicitConversion.
11833 (ExplicitUnsafe): Extracted from ExplicitConversion.
11834 (ExplicitConversion): Uses for error reporting.
11836 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11838 (ResolveBoolean): Uses common error method.
11839 (CastToDecimal): Get rid of ec.
11840 (CastFromDecimal): Optimized.
11841 (ConvCast): Get rid of ec.
11843 * enum.cs (ResolveValue): Reset in_transit immediately.
11844 (Emit): Return after first error.
11846 * expression.cs: Convert changes.
11848 * literal.cs: Error method changed.
11850 * statement.cs: Error method changed.
11852 2005-10-03 Raja R Harinath <rharinath@novell.com>
11854 * support.cs (SeekableStreamReader.Position): Don't error out when
11855 the requested position is just beyond the end of the current
11858 2005-09-28 Raja R Harinath <rharinath@novell.com>
11860 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11861 try to keep in sync with the byte count of the underlying Stream.
11862 However, this limits us to a window size of 2048 characters: i.e.,
11863 the maximum lookahead of our lexer/parser can be 2048 characters.
11865 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11868 * driver.cs: Fix compilation files with full root path.
11870 2005-09-25 Miguel de Icaza <miguel@novell.com>
11872 * report.cs (SymbolRelatedToPreviousError): Format the output so
11873 it does not use an open parenthesis that is never closed.
11875 * driver.cs: Follow coding guidelines
11877 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11880 * const.cs (Const.ResolveValue): Check for assigning non-null
11881 value to reference type.
11883 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11885 * anonymous.cs: Implemented ExprClassName.
11887 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11890 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11893 * class.cs (StaticClass.DefineContainerMembers): Report protected
11896 * codegen.cs: if(ed) PRODUCTION.
11898 * convert.cs (Error_CannotImplicitConversion): Better error
11901 * cs-parser.jay: More error checks.
11903 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11905 * driver.cs (CSCParseOption): Enabled wrong option check.
11907 * ecore.cs (Expression.ExprClassName): Turned to property.
11908 (MemberExpr.CheckIntermediateModification): For checking boxed
11909 value types modification.
11911 * statement.cs (Fixed.Resolve): Expression type must be
11912 convertible to fixed type.
11913 (CollectionForeach.GetEnumeratorFilter,TryType):
11914 Small refactoring for easier error checking.
11916 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11918 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11921 * class.cs (GeneratedBaseInitializer): New class for customization
11922 compiler generated initializers.
11923 (MemberBase.DoDefine): Check Obsolete attribute here.
11924 (FieldMember.DoDefine): Ditto.
11926 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11929 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11930 (MemberCore.GetObsoleteAttribute): Removed argument.
11931 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11932 (MemberCore.CheckObsoleteType): New helper.
11936 * statement.cs: Updates after MemberCore changes.
11938 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11939 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11941 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11942 obsolete attribute for compiler construct.
11943 (As.DoResolve): Cache result.
11945 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11947 2005-09-26 Raja R Harinath <rharinath@novell.com>
11950 * expression.cs (This.VerifyFixed): In a value type T, the type of
11951 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11952 value type R, 'this' is treated as a value parameter.
11954 2005-09-22 Miguel de Icaza <miguel@novell.com>
11956 * statement.cs (Lock): Use the TemporaryVariable class instead of
11957 manually using local variables as those do not work when variables
11960 * ecore.cs: Moved the TemporaryVariable class from being a nested
11961 class inside Foreach to be a public class that can be employed in
11964 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11966 * cs-parser.jay: interface_accessors replaced by
11967 accessor_declarations.
11969 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11972 * statement.cs (GotoCase.Resolve): Convert null constant to
11974 (SwitchLabel.ResolveAndReduce): Ditto.
11975 (SwitchLabel.NullStringCase): Custom null stamp.
11976 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11978 typemanager.cs (CSharpSignature): Don't skip first argument
11981 2005-09-18 Miguel de Icaza <miguel@novell.com>
11983 * driver.cs: Set InEmacs based on the environment variable EMACS.
11985 * location.cs (InEmacs): in this mode, do not report column
11986 location as it confuses Emacs.
11988 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11990 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11991 expression.cs, iterators.cs, literal.cs: Store constants and
11994 * class.cs (MemberBase.ShortName): Pass location.
11996 * cs-parser.jay: Some location fixes.
11998 * ecore.cs (Expression.Location): Made virtual.
12000 2005-09-05 Miguel de Icaza <miguel@novell.com>
12002 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12003 if the underlying types are the same, otherwise we need to produce
12004 code that will do the proper cast.
12006 This was exposed by Marek's constant rewrite which produced
12007 invalid code for the call site:
12009 enum X : long { a }
12010 void Method (X v) {}
12014 This fixes test-49.cs
12016 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12018 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12019 Type/Object should be allowed as well. Fixed bug #75968.
12021 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12023 * expression.cs : (Binary.DoResolve): when one is enum constant and
12024 another is constant 0, then return enum one *as enum type*.
12027 2005-09-02 Raja R Harinath <rharinath@novell.com>
12029 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12033 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12034 flow-branching for LocalVariableReferences in case we were invoked
12035 from a MemberAccess.
12036 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12038 (LocalVariableReference.DoResolveBase): ... this.
12039 (MemberAccess.Resolve): Do the check that was disabled during
12042 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12045 (PartialContainer.Create): check abstract/sealed/static strictly
12046 but abstract/sealed can exist only at one side. Fixed bug #75883.
12048 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12051 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12052 specified, don't default to UnmanagedType.I4.
12054 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12056 * expression.cs : conditional operator should check possibly
12057 incorrect assign expression. Fixed bug #75946.
12059 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12061 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12062 Reverting the change. gmcs is much complex than mcs on this matter.
12064 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12066 * cs-tokenizer.cs : To read another token ahead of the actual
12067 consumption, use new SavedToken and cache token instead of moving
12068 back the stream with SeekableStreamReader (it seemed problematic).
12070 driver.cs : Thus use StreamReader directly.
12071 * support.cs : Thus removed SeekableStreamReader.
12073 2005-08-30 Raja R Harinath <rharinath@novell.com>
12076 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12077 (ScopeInfo.EmitScopeType): Use it to construct field names from
12078 names of captured locals.
12081 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12082 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12083 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12084 (ExplicitConversion): Remove enum cases already handled by
12085 implicit conversion. Move implicit conversion check to the beginning.
12086 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12087 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12088 Don't treat System.Enum as a struct.
12090 2005-08-30 Jb Evain <jbevain@gmail.com>
12092 * attribute.cs: handles as expression in parameters.
12094 2005-08-30 Raja R Harinath <rharinath@novell.com>
12097 * class.cs (TypeContainer.VerifyClsName): Don't use a
12098 PartialContainer when verifying CLS compliance.
12099 (AbstractPropertyEventMethod): Set Parent here, ...
12100 (PropertyMethod): ... not here.
12102 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12104 * attribute.cs : escaped attribute name should not be allowed to be
12105 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12107 2005-08-29 Raja R Harinath <rharinath@novell.com>
12110 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12111 when converting a long constant to unsigned long.
12112 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12113 detect where IsApplicable and VerifyArgumentsCompat disagree.
12115 2005-08-29 Raja R Harinath <rharinath@novell.com>
12116 and Carlos Alberto Cortez <carlos@unixmexico.org>
12119 * class.cs (TypeContainer.CanElideInitializer): New helper.
12120 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12121 can safely emitting the initializer of a field.
12123 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12125 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12126 allowed inside a switch (without loop). Fixed bug #75433.
12128 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12130 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12131 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12133 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12135 * driver.cs : kinda reverting the default encoding changes (not exact
12136 revert since I noticed that "codepage:reset" might not work fine).
12138 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12140 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12141 Location. Now getter and setter store location correctly.
12142 (errors/cs0111-12.cs now reports the expected location.)
12144 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12146 * driver.cs : Use default encoding on the environment.
12147 Removed (now that) extra parameter for SeekableStreamReader.
12148 * support.cs : (SeekableStreamReader) third .ctor() argument for
12149 StreamReader is not required (always true). preamble size could
12150 be acquired in simpler and safe way.
12152 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12154 * cs-parser.jay: report CS0642 at warning level 3
12155 and report CS0642 for an if else statement also
12156 fixes bug #74745. Patch by John Luke (and a bit
12158 Removed extra CS0642 warning check for "while",
12160 * statement.cs: In Block.Resolve(), CS0642 check
12161 is reimplemented to check a sequence of an empty
12162 statement and a block.
12164 Both fix bug #66777.
12166 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12168 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12169 detection until I fix it.
12171 * cs-tokenizer.cs: Changed error message.
12173 * cs-parser.jay: Fixed 2 error locations.
12175 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12176 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12179 * enum.cs (GetSignatureForError): Fixed.
12181 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12185 * typemanager.cs (RegisterProperty): Removed.
12187 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12189 2005-08-24 Raja R Harinath <rharinath@novell.com>
12192 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12193 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12195 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12197 * expression.cs : tiny fix is required for not warning positive ulong.
12200 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12202 * expression.cs : add CS0652 check for constant and integral
12203 expression. Fixed bug #53974.
12205 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12207 * expression.cs : in DoNumericPromotions(), check if there is implicit
12208 conversion overload for string (to check CS0034). Fixed bug #52492.
12210 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12212 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12214 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12216 * ecore.cs : report location when it is *not* Null.
12218 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12224 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12225 correctly. Fixed bug #75721.
12227 2005-08-23 Raja R Harinath <rharinath@novell.com>
12229 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12230 loop that performs 'min (pos, char_count)'.
12233 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12234 converted value in Operator.OnesComplement.
12236 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12238 * anonymous.cs: If the anon method is pulled into a helper class,
12239 it needs to be `internal' not `private'. Fixes runtime behavior on
12242 2005-08-20 Martin Baulig <martin@ximian.com>
12244 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12245 scope if we don't already have it.
12247 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12248 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12251 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12254 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12255 is a partial class.
12257 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12259 The big constants rewrite
12260 Fix #75746, #75685 and more
12261 As a side effect saved 1MB for MWF ;-)
12263 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12264 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12265 enum based for corlib compilation.
12267 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12270 * class.cs (FixedField.Define): Use ResolveAsConstant.
12272 * const.cs (IConstant): Interface constants and enums.
12273 (Const.ResolveValue): New method for constant resolvning.
12274 (ExternalConstant): Constants from imported assemblies.
12276 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12277 conversion; like enums.
12278 (Constant.ToType): Converts this constant to different type.
12279 (Constant.Increment): Adds 1.
12281 * convert.cs (ImplicitConversionRequired): Simplified.
12283 * cs-parser.jay: Create EnumMember directly.
12285 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12287 * doc.cs (GenerateEnumDocComment): Removed.
12289 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12290 (ConvertIntLiteral): Removed.
12291 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12293 * enum.cs (EnumMember): Implement IConstant.
12294 (Enum.IsValidEnumConstant): Removed.
12295 (Enum.GetNextDefaultValue): Removed.
12296 (Enum.FindMembers): Updated.
12297 (Enum.GenerateDocComment): Iterate enum members.
12299 * expression.cs (Cast.TryReduce): Handle enums correctly.
12300 (New.Constantify): Made public.
12301 (MemberAccess.DoResolve): Removed contant specific if(s).
12303 * literal.cs (NullLiteral): Implement new abstract methods.
12305 * statement.cs (GotoCase.Resolve): Use new constant methods.
12306 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12308 * typemanager.cs (LookupEnum): Removed.
12309 (IsEnumType): Fixed to work with corlib.
12310 (RegisterConstant): Removed.
12311 (LookupConstant): Removed.
12312 (GetConstant): Changed to work with IConstant.
12314 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12316 * location.cs : Fixed overflown (>255) column number.
12318 2005-08-03 Raja R Harinath <rharinath@novell.com>
12320 First cut of the qualified-alias-member feature.
12321 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12323 * cs-parser.jay (DOUBLE_COLON): New token.
12324 (namespace_or_type_name): Add rule for recognizing
12325 qualified-alias-members.
12326 (primary_expression): Likewise.
12327 (element_access): Allow QualifiedAliasMember as a possible
12328 type-bearing expression.
12329 (local_variable_type, local_variable_pointer_type): Likewise.
12330 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12331 aliases in the current and enclosing namespace declarations.
12332 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12333 * decl.cs (MemberName.is_double_colon): New.
12334 (MemberName.MemberName): Add new constructor for alias-member.
12335 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12336 * expression.cs (QualifiedAliasMember): New expression type.
12338 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12340 * location.cs : it borked when no argument was specified.
12342 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12344 * location.cs : tiny ToString() format fix.
12346 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12348 * statement.cs : oops, it was missing.
12350 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12352 A set of fixes for precise line/column location.
12355 "token" field now holds a file/line "delta", a line number offset
12356 from the segment, and a column number. See also:
12357 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12358 December/009508.html
12359 Removed static IsNull. Use instance IsNull property instead.
12360 * cs-tokenizer.cs :
12361 For some tokens it stores Location. For Identifier it stores
12362 LocatedToken which is a pair of string name and location.
12363 Column numbers are adjusted only at getChar().
12365 Use Location.ToString() for reporting (it now contains column).
12367 Largely modified to use LocatedToken instead of
12368 string (IDENTIFIER), and to acquire Location from some tokens.
12369 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12370 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12372 Now MemberName holds Location. DeclSpace.ctor() receives Location
12373 as a parameter. Removed extra parameters to all derived classes.
12374 Replaced Location.IsNull() with instance property.
12375 * assign.cs, expression.cs :
12376 Added .ctor() overload that omits Location.
12378 Added "nameEscaped" flag that indicates the identifier was escaped
12379 in the source file. This fixes bug #57047.
12381 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12383 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12384 New method, looking for lo-case imported cls type.
12386 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12389 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12391 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12393 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12394 all_imported_types.
12395 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12397 Optimized to save 3.5 MB for SWF compilation.
12399 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12401 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12402 (PartialContainer.Create): Moved logic AddToContainer.
12403 (PartialContainer.MarkForDuplicationCheck): Shares name.
12405 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12408 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12410 (Namespace.GetSignatureForError): New method.
12412 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12413 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12415 2005-08-01 Raja R Harinath <rharinath@novell.com>
12418 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12419 member lookup rather than qualifier_type, since qualifier_type can
12422 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12424 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12427 2005-07-31 Miguel de Icaza <miguel@novell.com>
12429 * statement.cs: Copy the local exception into the exception
12430 captured local. Fixes 75674
12432 2005-07-31 Raja R Harinath <harinath@gmail.com>
12435 * expression.cs (Invocation.OverloadResolve): Don't report error
12436 CS1501 if error CS1502 has been reported.
12437 (New.DoResolve): Delegate CS1501 reporting to
12438 Invocation.OverloadResolve.
12441 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12442 invariant-meaning-in-block property in an enclosing block if
12445 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12447 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12448 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12449 (Switch.CheckSwitch): Just save 50kb for SWF.
12451 2005-07-27 Martin Baulig <martin@ximian.com>
12453 * anonymous.cs (CaptureContext.AddField): Added
12454 `AnonymousContainer am' argument; compute its toplevel scope if
12455 it's not already computed. Fixes #75649.
12457 2005-07-26 Raja R Harinath <rharinath@novell.com>
12460 * class.cs (Constructor.Emit): Reset block to null if the block
12463 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12465 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12467 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12469 * class.cs (MethodData.Define): Check whether accessor implementing
12470 interface is public.
12472 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12474 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12477 * namespace.cs (LookupType): Moved same type check to...
12479 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12480 with the same name.
12482 2005-07-21 Raja R Harinath <rharinath@novell.com>
12484 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12485 already found a typebuilder.
12486 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12487 MemberNames, not strings.
12489 * const.cs (Error_ExpressionMustBeConst):
12490 Rename from Error_EpressionMustBeConst.
12491 * const.cs, class.cs, statement.cd: Update.
12493 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12497 * const.cs (Const.LookupConstantValue): Report missing contant expression
12499 (Error_EpressionMustBeConstant): Only one error method.
12501 * class.cs, statement.c: Updated.
12503 2005-07-20 Raja R Harinath <rharinath@novell.com>
12505 * statement.cs (Block.Flags): Add back HasVarargs.
12506 (Block.flags): Make protected.
12507 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12509 * typemanager.cs (types, typecontainers, user_types): Remove.
12510 (UserTypes, TypeContainers): Likewise.
12511 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12512 (CleanUp, Reset): Update.
12513 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12514 (GetNestedType): Use Type.GetNestedType.
12515 (CoreLookupType): Take two arguments, the namespace and the
12516 basename of the type. Update to use the Namespace.Lookup
12518 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12519 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12520 string concatenation and substring matches.
12521 * class.cs, enum.cs, delegate.cs: Update to changes.
12523 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12525 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12526 Expression and made virtual.
12528 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12529 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12531 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12533 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12536 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12539 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12542 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12543 AssemblyCultureAttribute is not used on executable.
12546 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12548 2005-07-16 Raja R Harinath <rharinath@novell.com>
12551 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12552 New. Reports CS0252/CS0253.
12553 Mostly taken from preliminary patch by Duncak Mak.
12554 (Binary.DoResolveOperator): Store results of operator lookup.
12555 Use them to detect if we need to warn about unintended reference
12558 2005-07-15 Raja R Harinath <rharinath@novell.com>
12561 * namespace.cs (Namespace.Lookup): Add back location parameter.
12562 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12563 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12565 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12566 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12567 (Namespace.LookupType): ... this.
12568 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12570 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12571 purported to handle pointers.
12572 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12575 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12577 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12580 2005-07-15 Raja R Harinath <rharinath@novell.com>
12582 * namespace.cs (Namespace.Lookup): Drop location parameter.
12583 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12584 (NamespaceEntry.Lookup): ... this.
12585 (NamespaceEntry.Error_AmbiguousTypeReference):
12586 Move here from DeclSpace.
12587 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12589 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12590 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12591 Move to NamespaceEntry.
12592 * delegate.cs, expression.cs: Update to changes.
12594 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12596 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12597 CheckAttributeType and refactored.
12598 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12599 ResolveAsTypeTerminal error handling.
12600 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12602 (GetSignatureForError): Print errors in same way.
12605 * codegen.cs: Reflect attribute GetSignatureForError change.
12608 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12610 * namespace.cs (UsingEntry): Refactored to make fields private.
12613 statement.cs: Error_UnexpectedKind has extra parameter.
12615 2005-07-14 Raja R Harinath <rharinath@novell.com>
12617 * ecore.cs (IAlias): Remove.
12618 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12619 that implement the interface.
12620 * namespace.cs (Namespace): Likewise.
12621 (Namespace.declspaces): Renamed from 'defined_names'.
12622 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12623 DeclSpace instead of an IAlias.
12624 * tree.cs (Tree.AddDecl): Update.
12626 2005-07-12 Raja R Harinath <rharinath@novell.com>
12628 * statement.cs (Block.Flags); Remove HasVarargs.
12629 (Block.HasVarargs): Move to ToplevelBlock.
12630 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12631 (Block.Variables): Make protected. Initialize variable hashtable
12633 (Block.AddVariable): Update.
12634 (Block.Resolve): Update to changes.
12635 (ToplevelBlock.HasVarargs): New boolean.
12636 (ToplevelBlock.ThisVariable): Move here from Block.
12637 (ToplevelBlock.AddThisVariable): Likewise.
12638 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12639 * expression.cs (This.ResolveBase): Update to changes.
12640 (ArglistAccess.DoResolve): Likewise.
12642 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12645 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12647 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12648 not used and not used & assigned.
12649 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12651 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12654 * expression.cs (Is.DoResolve): null is never provided type.
12656 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12659 * cs-parser.jay: Less strict event error rule to catch more errors.
12661 2005-07-08 Martin Baulig <martin@ximian.com>
12663 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12664 gettter (allowed) or setter (not allowed).
12666 * class.cs (Accessor): Implement IIteratorContainer.
12667 (Accessor.Yields): New public field.
12668 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12669 per-accessor basis.
12672 (get_accessor_declaration, set_accessor_declaration): Set the
12673 `yields' flag on the accessor, not the property.
12674 (property_declaration): Do the iterators check on a per-accessor
12675 basis and not for the whole property.
12677 2005-07-08 Martin Baulig <martin@ximian.com>
12679 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12680 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12682 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12685 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12686 (ExtractSecurityPermissionSet): Cope with self referencing security
12687 attributes properly.
12689 * driver.cs (SetOutputFile): Made public property OutputFile.
12691 2005-07-07 Raja R Harinath <rharinath@novell.com>
12694 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12695 has_nonstatic_fields. Make into a FieldBase pointer.
12696 (TypeContainer.AddField): Add CS0282 check.
12697 (TypeContainer.EmitType): Update.
12699 2005-07-06 Miguel de Icaza <miguel@novell.com>
12701 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12702 compare if they start with __.
12704 2005-07-06 Raja R Harinath <rharinath@novell.com>
12706 * statement.cs (Switch.SwitchGoverningType): Only look at
12707 UserCasts that don't need implicit standard conversions to one of
12708 the allowed switch types (Fixes test-322.cs).
12709 (LocalInfo.Resolve): Re-enable sanity-test.
12711 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12713 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12715 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12717 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12719 2005-07-06 Raja R Harinath <rharinath@novell.com>
12722 * ecore.cs (SimpleName.GetSignatureForError): Add.
12723 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12724 (MemberAccess.GetSignatureForError): Add.
12726 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12728 The big error and warning messages review.
12758 * typemanager.cs: Updated.
12760 * class.cs: (MethodCore.SetYields): Moved here to share.
12761 (PropertyMethod.Define): Moved iterator setup here.
12763 * iterators.cs: Add orig_method to have full access to parent
12766 2005-07-05 Raja R Harinath <rharinath@novell.com>
12768 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12769 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12770 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12771 variable of struct type.
12772 * expression.cs (Unary.ResolveOperator): Update to change.
12773 (Indirection.VerifyFixed): Likewise.
12774 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12775 (ParameterReference.VerifyFixed): Value parameters are fixed.
12776 (This.VerifyFixed): Treat 'this' as a value parameter.
12777 * statement.cs (LocalInfo.IsFixed): Remove.
12779 2005-07-01 Martin Baulig <martin@ximian.com>
12781 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12782 `ec.EmitThis ()' to get the correct scope.
12784 2005-07-01 Martin Baulig <martin@ximian.com>
12786 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12787 instance is a ParameterReference; fixes #75299.
12789 2005-07-01 Martin Baulig <martin@ximian.com>
12791 Reverted Marek's latest patch (r46725):
12792 - it contains structural changes which are neither mentioned in
12793 the ChangeLog nor explained anywhere; for example the additional
12794 argument of EmitContext's and Iterator's .ctor's and the
12795 TypeContainer.DefineMembers() change.
12796 - structural changes like this should go in in seperate patches
12797 and not be hidden in a huge patch which just seems to affect
12798 warnings and errors.
12799 a big and hard to understand patch.
12800 - it breaks iterators and causes regressions, for instance in
12803 2005-06-30 Raja R Harinath <rharinath@novell.com>
12806 * expression.cs (Indexers.map): Remove.
12807 (Indexers.Append): Filter out inaccessible setters and getters.
12808 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12811 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12812 Refactored from ...
12813 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12814 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12815 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12816 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12818 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12821 * class.cs (FieldBase.GetInitializerExpression): One more field
12824 2005-06-28 Miguel de Icaza <miguel@novell.com>
12826 * pending.cs: Do not define a proxy if the base method is virtual,
12827 it will be picked up by the runtime (bug 75270).
12829 2005-06-08 Martin Baulig <martin@ximian.com>
12831 The big Iterators rewrite :-)
12833 * iterators.cs: Rewrite this to use the anonymous methods framework.
12835 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12836 before the TypeContainers; see 2test-21.cs.
12839 (TypeContainer.DefineType): Don't create a new EmitContext if we
12840 already have one (this only happens if we're an Iterator).
12841 (TypeContainer.Define): Also call Define() on all our iterators.
12842 (Method.CreateEmitContext): Added support for iterators.
12845 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12846 (AnonymousContainer.CreateMethodHost): Moved here from
12847 AnonymousMethod and made abstract.
12848 (AnonymousContainer.CreateScopeType): New abstract method.
12849 (AnonymousContainer.IsIterator): New public property.
12850 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12851 get the ScopeTypeBuilder rather than manually defining it here.
12852 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12855 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12856 before RootContext.DefineTypes().
12858 * codegen.cs (EmitContext.RemapToProxy): Removed.
12859 (EmitContext.CurrentAnonymousMethod): Changed type from
12860 AnonymousMethod -> AnonymousContainer.
12861 (EmitContext.ResolveTopBlock): Protect from being called twice.
12862 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12863 (EmitContext.EmitThis): Removed the iterators hacks; use the
12864 anonymous methods framework for that.
12867 (ToplevelBlock.Container): Make this a property, not a field.
12868 (ToplevelBlock.ReParent): New public method; move the
12869 ToplevelBlock into a new container.
12870 (Foreach.TemporaryVariable): Simplify.
12872 2005-06-05 Martin Baulig <martin@ximian.com>
12874 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12875 (Block.AddTemporaryVariable): New public method; creates a new
12876 `LocalInfo' for a temporary variable.
12877 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12879 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12880 non-iterator variables.
12882 2005-06-05 Martin Baulig <martin@ximian.com>
12884 * statement.cs (Foreach.TemporaryVariable): Create the
12885 LocalBuilder in the Emit phase and not in Resolve since in some
12886 situations, we don't have an ILGenerator during Resolve; see
12887 2test-19.cs for an example.
12889 2005-06-04 Martin Baulig <martin@ximian.com>
12891 **** Merged r45395 from GCS ****
12893 The big Foreach rewrite - Part II.
12895 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12896 with `PropertyInfo ienumerator_getcurrent'.
12898 * codegen.cs (VariableStorage): Removed.
12901 (Foreach): Derive from Statement, not ExceptionStatement.
12902 (Foreach.CollectionForeach): New nested class. Moved all the code
12903 dealing with collection foreach here.
12904 (Foreach.ForeachHelperMethods): Removed.
12905 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12907 2005-05-23 Martin Baulig <martin@ximian.com>
12909 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12910 don't need to. Fix #75014.
12912 2005-05-20 Martin Baulig <martin@ximian.com>
12914 Merged r44808 from GMCS.
12916 * class.cs (TypeContainer.CircularDepException): Removed.
12917 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12918 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12919 (CS0146) and interface (CS0529) dependencies here.
12921 2005-06-21 Raja R Harinath <rharinath@novell.com>
12923 * expression.cs (Invocation.EmitCall): Fix initialization
12924 'this_call' to reflect current behaviour. Fix indentation.
12926 * convert.cs (FindMostEncompassedType): Add two trivial special
12927 cases (number_of_types == 0 || number_of_types == 1).
12928 (FindMostEncompasingType): Likewise.
12930 2005-06-17 Raja R Harinath <rharinath@novell.com>
12932 Some cleanups preparing for the fix of #75283.
12933 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12935 (EventExpr.InstanceResolve): Likewise.
12936 (EventExpr.DoResolve): Remove redundant checks.
12938 2005-06-10 Duncan Mak <duncan@novell.com>
12940 * cs-tokenizer.cs (process_directives): New flag for controlling
12941 the processing of preprocessor directives.
12942 (x_token): After seeing a '#', return Token.NONE instead of going
12943 to handle_preprocessing_directive() when not processing
12944 directives. This avoids unnecessary processing during the token peek in
12949 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12950 the existing error reporting methods instead of Report.Error.
12952 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12953 after Raja's rewrite.
12955 2005-06-08 Miguel de Icaza <miguel@novell.com>
12957 * class.cs: Small fix.
12959 2005-06-08 Raja R Harinath <rharinath@novell.com>
12962 * class.cs (GetPartialBases): Fix return value check of
12963 part.GetClassBases.
12965 2005-06-07 Raja R Harinath <rharinath@novell.com>
12967 Ensure that partial classes are registered in their enclosing
12968 namespace. Initial part of fix of #75160.
12969 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12970 Register declspace with namespace here, not in
12971 DeclSpace.RecordDecl.
12972 * cs-parser.jay: Pass namespace to RecordDecl.
12973 * class.cs (PartialContainer.Create): Likewise.
12974 (ClassPart.DefineType): New sanity-check. Throws an exception if
12976 * decl.cs (Declspace.RecordDecl): Remove.
12977 * namespace.cs (NamespaceEntry.DefineName): Remove.
12979 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12981 * rootcontext.cs: Reset TargetExt as well.
12983 2005-06-03 Raja R Harinath <rharinath@novell.com>
12985 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12986 -langversion:ISO-1.
12988 2005-06-02 Raja R Harinath <rharinath@novell.com>
12990 Fix #75080, cs0119.cs.
12991 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12993 (Expression.Resolve): ... this. Use it. Remove bogus code
12994 allowing ExprClass.Type and ExprClass.Namespace for
12995 ResolveFlags.VariableOrValue.
12996 (Expression.Resolve) [1-argument variant]: Change default resolve
12997 flags based on language version.
12998 (Expression.Error_UnexpectedKind): Use a simple string array
12999 rather than an ArrayList.
13000 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13001 not ExprClass.Type.
13002 (TypeOfVoid.DoResolve): Likewise.
13003 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13004 flags argument -- it always has the same value.
13006 2005-05-31 Raja R Harinath <rharinath@novell.com>
13009 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13010 Use it in the error message.
13011 * assign.cs, expression.cs, statement.cs: Update.
13013 2005-05-30 Raja R Harinath <rharinath@novell.com>
13016 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13017 the "almostMatchedMember" case too.
13018 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13019 that failed the accessibility checks to 'almost_match'.
13021 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13023 * attribute.cs: Use internal MethodBuilder methods to set
13024 ExactSpelling and SetLastError on PInvoke methods, instead
13025 of passing them via charset. Fixes #75060.
13027 2005-05-27 Raja R Harinath <rharinath@novell.com>
13029 * parameter.cs (Parameter): Remove TODO comment.
13030 (Parameter.DefineParameter): Remove Location parameter.
13031 (Parameters.LabelParameters): Likewise.
13032 * class.cs (Constructor.Emit): Update to change.
13033 (MethodData.Emit): Likewise.
13034 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13035 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13037 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13040 Removed Parameters.Location and added Parameter.Location instead.
13041 Removed Location parameter from Emit() and GetSignature().
13048 Modified all related calls.
13050 2005-05-26 Raja R Harinath <rharinath@novell.com>
13052 Improve user-defined conversion handling.
13053 * convert.cs (GetConversionOperators): Rewrite. Return only the
13054 applicable operators.
13055 (AddConversionOperators): New. Helper for GetConversionOperators.
13056 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13057 there is only one most encompassed/encompassing type.
13058 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13059 "applicable operator" handling.
13060 (UserConversion): Move cache here from GetConversionOperators.
13061 Directly cache the chosen operator, rather than the whole
13063 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13064 case. Allow conversion of decimal to sbyte and byte too.
13065 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13066 New static methods. Used to avoid allocating EmptyExpressions in
13069 2005-05-24 Duncan Mak <duncan@novell.com>
13071 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13072 another class, used in Convert.ExplicitNumericConversion.
13073 (CastToDecimal): New class, similar to above, but casts to
13074 System.Decimal, used in Convert.ImplicitNumericConversion and also
13075 in explicit convesion from double/float to decimal.
13077 * convert.cs (ImplicitNumericConversion): Handle implicit
13078 conversions to System.Decimal.
13079 (ExplicitNumericConversion): handle explicit conversions to
13084 2005-05-20 Miguel de Icaza <miguel@novell.com>
13086 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13087 know the type at this stage, just break through. Fixes #75008
13089 2005-05-19 Martin Baulig <martin@ximian.com>
13092 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13093 to disable error reporting.
13095 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13096 here since we don't want to report an error; see the new test-336.cs.
13098 2005-05-19 Raja R Harinath <rharinath@novell.com>
13100 * statement.cs (ToplevelBlock.GetParameterReference)
13101 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13102 Move here from class Block.
13103 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13104 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13106 2005-05-18 Martin Baulig <martin@ximian.com>
13111 (FlowBranching.Reachability): Add non-static public And() and Or()
13113 (FlowBranchingSwitch): New class; do the `break_origins' thing
13114 like in FlowBranchingLoop.
13115 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13116 reachability, not just locals and parameters.
13117 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13118 switch; MergeBreakOrigins() now takes care of that.
13120 2005-05-18 Martin Baulig <martin@ximian.com>
13122 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13123 a loop and may leave it, reset the barrier; fixes #74974.
13125 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13127 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13130 * cs-parser.jay: Catch more lexical errors.
13132 * report.cs: Add one more Error method.
13135 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13137 2005-05-17 Martin Baulig <martin@ximian.com>
13139 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13142 2005-05-16 Raja R Harinath <rharinath@novell.com>
13144 Fix test-382.cs. Emit values of decimal constants.
13145 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13147 (TypeContainer.AddField): ... this.
13148 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13149 with initializers to include 'Const's.
13150 (ClassPart.RegisterFieldForInitialization): Forward to
13152 * const.cs (Const.Const): Pass initializer to base class.
13153 (Const.Define): In case of decimal constants, register them for
13154 initialization in a static constructor.
13156 2005-05-14 Martin Baulig <martin@ximian.com>
13158 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13159 do not call ResolveUnreachable() on unreachable statements in
13160 here, see the comment in the source code.
13162 2005-05-13 Raja R Harinath <rharinath@novell.com>
13165 * expression.cs (BinaryResolveOperator): If one of the operands of
13166 an equality comparison is 'null' and the other is a pointer type,
13167 convert the null to a NullPointer.
13168 * convert.cs (ImplicitReferenceConversion): If the expression is a
13169 NullLiteral and the target type is a pointer type, return a
13170 NullPointer instead.
13171 (ImplicitConversionStandard): Likewise.
13173 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13175 * cs-parser.jay: Set readonly context based on special constructs.
13177 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13178 readonly variable error handling.
13180 * rootcontext.cs (EmitCode): Don't verify members when error
13183 * statement.cs (LocalInfo): Add reaodnly context information.
13184 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13186 2005-05-13 Raja R Harinath <rharinath@novell.com>
13188 * statement.cs (Block.Resolve): Revert change below. Modify fix
13189 for #74041 to initialize 'resolved' to false only for explicit
13190 blocks. Fixes #74873.
13192 2005-05-12 Raja R Harinath <harinath@gmail.com>
13195 * typemanager.cs (unmanaged_enclosing_types): New.
13196 (IsUnmanagedType): Avoid infloops by using
13197 'unmanaged_enclosing_types' to talk with recursive invocations.
13199 2005-05-13 Martin Baulig <martin@ximian.com>
13201 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13202 instance variable, not a local. Fix #74873.
13203 (Block.ResolveUnreachable): Set it to true here.
13205 2005-05-11 Duncan Mak <duncan@novell.com>
13207 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13208 continuing to process for 'arg'.
13209 (handle_preprocessing_directive): Check the argument of the #endif
13210 directive and report error CS1025 if there are any trailing
13213 According to the C# spec, having even whitespace after the #endif
13214 directive is illegal; however, because we call arg.TrimEnd ()
13215 beforehand, we have the same behavior as csc, allowing whitespace
13216 after the directive.
13220 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13224 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13225 (Constructor.GetObsoleteAttribute): Implemented correctly.
13227 2005-05-10 Martin Baulig <martin@ximian.com>
13229 * support.cs (ReflectionParameters.ParameterModifier): Use
13230 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13231 and `ParameterAttributes.In'. Fixes #74884.
13233 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13235 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13237 * expression.cs (Argument.GetParameterModifier): Turned to property.
13238 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13240 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13243 2005-05-09 Raja R Harinath <rharinath@novell.com>
13246 * decl.cs (MemberCache.AddMethods): Register override methods,
13247 rather than non-override methods.
13248 * typemanager.cs (RegisterOverride): New.
13249 (IsOverride): Update.
13251 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13255 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13256 recursive declaration.
13258 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13260 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13262 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13264 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13266 2005-05-05 Raja R Harinath <rharinath@novell.com>
13269 * decl.cs (DeclSpace.FamilyAccessible):
13270 Use TypeManager.IsNestedFamilyAccessible.
13272 Fix reopened #64812.
13273 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13276 2005-05-04 Raja R Harinath <rharinath@novell.com>
13277 Abin Thomas <projectmonokochi@rediffmail.com>
13278 Anoob V E <projectmonokochi@rediffmail.com>
13279 Harilal P R <projectmonokochi@rediffmail.com>
13282 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13283 allow access to all static members.
13285 2005-05-04 Martin Baulig <martin@ximian.com>
13287 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13289 2005-05-04 Martin Baulig <martin@ximian.com>
13293 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13294 section at the end; make things work if `default' is not the last
13297 2005-05-04 Martin Baulig <martin@ximian.com>
13301 * statement.cs (Switch): Replaced the `got_default' field with a
13302 `default_section' one.
13303 (Switch.CheckSwitch): Set `default_section' here.
13304 (Switch.Resolve): If we're a constant switch and the constant is
13305 not found, use the default section.
13307 2005-05-03 Martin Baulig <martin@ximian.com>
13309 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13311 * statement.cs (Foreach.ArrayForeach): New nested class.
13312 (Foreach.TemporaryVariable): New nested class.
13313 (Foreach.EmitArrayForeach): Removed; this is now in the new
13314 ArrayForeach class.
13316 2005-05-03 Raja R Harinath <rharinath@novell.com>
13318 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13320 (VerifyPendingMethods): Revert change below.
13322 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13323 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13324 that used to trigger warning -28. Remove warning -28.
13325 * expression.cs (Invocation.OverloadResolve): Use
13326 TypeManager.IsOverride to distinguish override methods.
13329 * pending.cs (VerifyPendingMethods): If a base type implements the
13330 requested interface, don't bother checking individual methods of
13331 the base type. As a side-effect, this prevents the creation of
13332 unnecessary proxies.
13334 2005-05-02 Martin Baulig <martin@ximian.com>
13338 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13339 Also `And' the locals if the old vector is null.
13340 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13341 null; in this case we basically reset all the variables.
13343 2005-05-02 Martin Baulig <martin@ximian.com>
13347 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13348 Added `FlowBranching branching' argument; always `and' the
13349 variables instead of `or'ing them unless we're an infinite loop.
13351 * statement.cs (While.Resolve): Create a new sibling unless we're
13354 2005-05-02 Martin Baulig <martin@ximian.com>
13358 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13359 arguments; use it instead of creating a new TopLevelBlock.
13360 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13361 our ConstructorInitializer.
13364 (TopLevelBlock.TopLevelBranching): New public property.
13365 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13366 and create our `TopLevelBranching'.
13368 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13369 anonymous method host, use `block.TopLevelBranching' rather than
13370 creating a new branching.
13372 2005-04-20 Miguel de Icaza <miguel@novell.com>
13374 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13375 a ScopeInfo, if any of the current children is a child of the new
13376 entry, move those children there.
13378 2005-04-30 Martin Baulig <martin@ximian.com>
13380 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13381 at the beginning of a SwitchSection. Fix #73335.
13383 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13386 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13388 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13389 (FieldExpr.DoResolve): Obsolete members are ignored for field
13392 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13394 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13395 of arrays detection.
13397 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13399 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13401 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13404 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13406 * cs-parser.jay: Use the prefered version of -unsafe in error
13409 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13411 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13414 2005-04-20 John Luke <john.luke@gmail.com>
13416 * driver.cs: fix typo in error message, --outout to --output
13418 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13420 * codegen.cs (InRefOutArgumentResolving): New field.
13422 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13423 fields outside contructor.
13425 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13427 2005-04-19 Miguel de Icaza <miguel@novell.com>
13429 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13430 parameter code was not completed ever, so it was not as up-to-date
13431 as local variables. Must finish it.
13433 The bug fix was to compare the Toplevel of the block, not the
13434 current block. Thanks for Ben for pointing this out.
13436 2005-04-19 Raja R Harinath <rharinath@novell.com>
13438 * decl.cs (AddMethods): Use the declaring type of the problem
13439 method to determine if we want to squash a warning.
13441 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13443 * attribute.cs: Removed debug output.
13445 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13447 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13450 2005-04-18 Raja R Harinath <rharinath@novell.com>
13453 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13454 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13455 all null comparisons against reference types.
13457 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13460 * class.cs (TypeContainer.CircularDepException) New nested
13462 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13463 (TypeContainer.DefineType): Removed error, reset InTransit before
13465 (Class.DefineType): Throw exception when is in Transit.
13466 Catch exception and report error.
13467 (Struct.DefineType): Throw exception when is in Transit.
13468 Catch exception and report error.
13469 (Interface.DefineType): Throw exception when is in Transit.
13470 Catch exception and report error.
13472 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13473 handle nested exception handlers.
13475 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13478 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13479 InFinally and InCatch storage.
13481 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13482 (Catch.Resolve): Set and Restore ec.InCatch.
13483 (Try.Resolve): Set and Restore ec.InFinally.
13484 (Try.HasCatch): True when try has catch.
13486 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13488 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13489 for the same event member, so exclude such cases from warning 419.
13492 2005-04-16 Miguel de Icaza <miguel@novell.com>
13494 * expression.cs (Binary.ResolveOperator): Apply patch from John
13495 Luke to fix bug 59864: operators &, | and ^ on enumerations
13496 require that the same enum type on both sides.
13498 * driver.cs: Add warnings to old flag usage, this is to assist
13499 people who produce Makefiles and hope that the Makefiles will be
13502 * class.cs (TypeContainer.EmitType): Moved the definition of the
13503 special $PRIVATE$ field from the resolve phase to the Emit phase.
13504 During resolve we do not know if we are a struct with
13505 HasExplicitLayout, we know this only after the attributes for the
13508 Set the FieldOffset to zero on the dummy field that we create for
13509 the class. Fixes 74590.
13511 2005-04-16 Raja R Harinath <rharinath@novell.com>
13514 * ecore.cs (PropertyExpr.resolved): New.
13515 (DoResolve): Use it to handle a case of double resolution here.
13516 Handle a case of identical-name-and-type-name.
13517 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13518 resolution by storing the results of expression resolution back
13519 into the "probes" array.
13521 2005-04-15 Raja R Harinath <rharinath@novell.com>
13523 Fix cs0208-7.cs and cs0208-8.cs.
13524 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13525 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13526 error reporting to point out the reason a struct is not unmanaged.
13528 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13530 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13531 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13533 2005-04-13 Raja R Harinath <rharinath@novell.com>
13536 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13537 IdenticalNameAndTypeName here.
13538 (EventExpr.InstanceResolve): Likewise.
13540 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13542 C# 2.0 DefaultCharSetAttribute implementation
13544 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13545 which allows us to set GlobalNamespace for every resolve.
13546 (Attribute.ResolveArguments): Cut from Resolve.
13547 (Attribute.GetCharSetValue): Returns CharSet named argument.
13548 (Attribute.DefinePInvokeMethod): Gets default charset from
13550 (GlobalAttribute.ResolveAsTypeStep): Override.
13551 (GlobalAttribute.ResolveArguments): Override.
13553 * class.cs (TypeAttr): Is protected.
13555 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13556 (ModuleClass.DefaultCharSetType): New memeber.
13557 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13559 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13560 charset from module.
13562 * delegate.cs (TypeAttr): Override.
13563 (Delegate.DefineType): Use this TypeAttr.
13565 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13566 at very early stage (before types are defined) to resolve model
13567 module attributes. It will probably not work with corlib but it
13570 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13571 charset from module.
13573 * typemanager.cs (default_charset_type): New type.
13575 2005-04-13 Raja R Harinath <rharinath@novell.com>
13577 * decl.cs (MemberCache.AddMethods): Don't warn if
13578 System.Object.Finalize has buggy MethodAttributes.
13580 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13583 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13585 * doc.cs : detect ambiguous reference to overloaded members.
13586 Fixed bug #71603. MS 1.1 csc does not detect it.
13588 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13590 * doc.cs : delegates must not be referenced with parameters.
13593 2005-04-12 Miguel de Icaza <miguel@novell.com>
13595 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13597 2005-04-10 Miguel de Icaza <miguel@novell.com>
13599 * driver.cs (MainDriver): Stop processing if the CLS stage found
13602 (CompilerCallableEntryPoint.InvokeCompiler): Always
13603 reset after execution; Take a TextWriter argument for the
13606 * report.cs: Use the error stream instead of hardcoding stderr.
13608 2005-04-09 Miguel de Icaza <miguel@novell.com>
13610 * class.cs: Reduce code paths to test, too small of an
13611 optimization to make it worth the extra testing. Always perform
13614 2005-04-08 Raja R Harinath <rharinath@novell.com>
13617 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13618 operators that had errors reported on them.
13620 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13622 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13624 (Attribute.Resolve): Add named argument type checking.
13626 * class.cs (FixedField.Define): Use IsPrimitiveType
13628 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13630 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13631 unsafe parameter types.
13633 * statement.cs (Using.ResolveExpression): Add better error description.
13635 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13637 2005-04-08 Raja R Harinath <rharinath@novell.com>
13640 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13641 AttributeUsageAttribute in the emitcontext of the attribute class,
13642 not in the emitcontext of the attributable entity it was attached to.
13643 * cs-parser.jay: Use 'current_class', not 'current_container',
13644 when creating a GlobalAttribute.
13646 2005-04-08 Alp Toker <alp@atoker.com>
13648 * pending.cs: The fix to #58413 failed to compile methods implementing
13649 interfaces with/without params modifiers and vice versa, even though
13650 params modifiers aren't part of the signature. Make the modifier check
13651 less strict as in csc.
13653 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13654 Anoob V E <projectmonokochi@rediffmail.com>
13655 Harilal P R <projectmonokochi@rediffmail.com>
13658 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13659 modifiers of pending methods.
13660 (PendingImplementation.PendingImplementation): Initialize it.
13661 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13662 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13663 with ParameterData. Add check for modifiers.
13664 * class.cs (MethodData.Define): Update to changes.
13666 2005-04-07 Raja R Harinath <rharinath@novell.com>
13668 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13670 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13672 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13675 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13678 * typemanager.cs: Registered RequiredAttributeAttribute.
13680 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13682 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13683 Warning CS0169 is back at level 3.
13684 (IMethodData.SetMemberIsUsed): New method.
13686 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13687 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13689 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13691 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13693 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13696 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13699 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13700 to avoid the problems with nested types.
13702 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13703 Anoob V.E <projectmonokochi@rediffmail.com>
13704 Harilal P.R <projectmonokochi@rediffmail.com>
13705 Raja R Harinath <rharinath@novell.com>
13708 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13710 * typemanager (GetConstructor): Make public.
13712 2005-04-05 John Luke <john.luke@gmail.com>
13713 Raja R Harinath <rharinath@novell.com>
13716 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13717 struct too. Return false quicker in a few cases.
13718 (VerifyUnManaged): Use it.
13720 2005-04-05 Raja R Harinath <rharinath@novell.com>
13723 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13724 not 'unreachable_seen'.
13726 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13728 * attribute.cs (Attribute.GetValue): Removed unused.
13730 * codegen.cs (CodeGen.TrimExt): Removed unused.
13732 * cs-parser.jay (output): Removed unused.
13734 * cs-tokenizer.cs (hex_digits): Removed unused.
13736 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13738 * expression.cs (Indirection.LoadExprValue): Removed unused.
13739 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13741 * iterators.cs (Iterator.param_types): Removed unused.
13743 * statement.cs (Goto.block): Removed unused.
13744 (ToplevelBlock.did): Removed unused.
13745 (Switch.ResolveConstantSwitch): Removed unused.
13747 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13749 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13752 2005-04-01 Raja R Harinath <rharinath@novell.com>
13754 Fix #74232 and cs0208-3.cs.
13755 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13756 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13757 unmanaged type. Don't use FieldBuilders when 't' is a
13758 TypeBuilder. Use ModFlags and MemberType fields.
13759 * class.cs (MemberBase.member_type): Rename from MemberType.
13760 (MemberBase.MemberType): New property. Determines member_type on
13762 (MemberBase.DoDefine): Don't initialize MemberType here.
13763 (FieldMember.Define): Likewise.
13765 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13768 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13769 Attributes are emitted there.
13771 2005-04-01 Raja R Harinath <rharinath@novell.com>
13773 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13774 keyword in 'partial enum' too.
13775 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13777 Report from Kamil Skalski <nazgul@omega.pl>.
13780 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13781 have partial containers too.
13783 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13784 in block' checks to Block.CheckInvariantMeaningInBlock.
13785 * statement.cs (Block.GetKnownVariableInfo): Make private.
13786 (Block.IsVariableUsedInChildBlock): Remove.
13787 (Block.IsVariableUsedInBlock): Likewise.
13788 (Block.CheckInvariantMeaningInBlock): New. Show location of
13789 conflicting declaration.
13790 (Block.AddVariable): Make error messages less long-winded and more
13791 specific. Show location of conflicting declaration.
13792 * parameter.cs (Parameters.Location): New readonly property.
13794 2005-03-31 Raja R Harinath <rharinath@novell.com>
13796 Clean up semantics of invoking ResolveMemberAccess.
13797 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13798 can have an instance, ensure that we pass in a non-TypeExpression
13799 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13800 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13801 argument. Update to changes and simplify.
13802 (FieldExpr.Emitinstance): Remove CS0120 check.
13803 (PropertyExpr.EmitInstance): Likewise.
13804 * expression.cs (Argument.Resolve): Likewise.
13805 (Invocation.DoResolve): Update to changes in semantics of
13806 InstanceExpression.
13808 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13811 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13814 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13816 2005-03-31 Raja R Harinath <rharinath@novell.com>
13818 Fix difference in behaviour with commandline invocation.
13819 * driver.cs (Driver.Reset): New.
13820 (CompilerCallableEntryPoint): Call it.
13822 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13823 variable" warnings if the boolean expression failed to resolve.
13825 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13827 * attribute.cs: Fix the union of several permissions when some of them
13828 are unrestricted (so the result isn't an unrestricted permission set).
13831 2005-03-30 Raja R Harinath <rharinath@novell.com>
13833 * ecore.cs (MemberExpr): New class. Convert from interface
13835 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13836 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13838 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13839 (MethodGroupExpr.IsExplicitImpl): Remove.
13840 (Expression.GetFieldFromEvent): Remove.
13841 (SimpleName.MemberStaticCheck): Remove.
13842 (SimpleName.DoSimpleNameResolve): Update to changes.
13843 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13844 (MemberAccess.IdenticalNameAndTypeName): Remove.
13845 (MemberAccess.error176): Move to MemberExpr.
13846 (MemberAccess.DoResolve): Update to changes.
13847 (BaseAccess.DoResolve): Likewise.
13849 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13851 C# 2.0 Conditional attribute class implementation
13853 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13854 Analyzes class whether it has attribute which has ConditionalAttribute
13855 and its condition is not defined.
13857 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13858 (Class.IsExcluded): New method. Search for at least one defined
13859 condition in ConditionalAttribute of attribute class.
13861 2005-03-30 Raja R Harinath <rharinath@novell.com>
13863 * ecore.cs (PropertyExpr): Derive from Expression, not
13864 ExpressionStatement.
13865 (PropertyExpr.EmitStatement): Remove.
13867 2005-03-29 Raja R Harinath <rharinath@novell.com>
13870 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13871 internal field "value__" of an enum be private. The examples for
13872 "value__" that I found on MSDN all used FieldAttributes.Private.
13874 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13875 Don't mention IL method attribute names.
13877 Fix #47991. Remove a TODO.
13878 * statement.cs (Block.Toplevel): Make into a field.
13879 (Block.Parameters): Move into ToplevelBlock.
13880 (Block.known_variables): Rename from child_variable_names.
13881 (Block.Block): Remove variants that take Parameters. Initialize
13882 'Toplevel' with the immediately surrounding toplevel block.
13883 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13884 LocalInfo parameter.
13885 (Block.GetKnownVariableInfo): New.
13886 (Block.IsVariableNameUsedInChildBlock): Update.
13887 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13888 the block, even though it may not be in scope.
13889 (Block.AddVariable): Remove Parameters parameter. Use
13890 Toplevel.Parameters instead.
13891 (Block.AddConstant): Remove Parameters parameter.
13892 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13893 (Block.IsParamaterReference): Likewise.
13894 (Block.IsLocalParameter): Likewise. Simplify a lot.
13895 (ToplevelBlock.Parameters): New. Moved from Block.
13896 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13897 initialize Parameters to a non-null value.
13898 * cs-parser.jay: Update to changes.
13899 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13900 simple names that mean different things in the same block. Use
13901 Block.IsVariableNameUsedInBlock.
13903 2005-03-28 Raja R Harinath <rharinath@novell.com>
13905 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13906 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13907 GetTypeHandle. It is possible for a reflected type to derive from
13908 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13909 System.Array during mscorlib compilation).
13910 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13911 contain a method_hash, don't create one either. Don't create a
13912 deep copy of the base cache's method_hash.
13913 (MemberCache.SetupCache): Rename back from DeepCopy.
13914 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13915 already initialized. If we see an override function, add its
13916 underlying base virtual function to the member_hash too.
13918 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13920 2005-03-26 Raja R Harinath <harinath@acm.org>
13923 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13924 fails to resolve, ensure that the LHS is still resolved as an
13927 2005-03-25 Raja R Harinath <harinath@acm.org>
13929 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13931 (Enum.current_ec): Remove.
13932 (Enum.LookupEnumValue): Remove EmitContext argument.
13933 Just uses the one created during DefineType.
13934 (Enum.FindMembers): Update.
13935 * expression.cs (MemberAccess.DoResolve): Update.
13937 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13939 * assign.cs (Assign.DoResolve): Check for CS1717 when
13940 source and target are same (uses Equals).
13942 * expression.cs (LocalVariableReference, ParameterReference,
13943 This): Implemented Equals, GetHashCode.
13945 * statement.cs (Block.GetParameterReference): Removed useless
13948 2005-03-22 Raja R Harinath <rharinath@novell.com>
13951 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13952 blocks before deciding whether the error is cs0136 or cs0128.
13954 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13955 (using_alias_directive, using_namespace_directive): Pass
13956 MemberName, not an expression to Namespace.UsingAlias and
13958 (MakeName): Use the MemberName of the namespace.
13959 * namespace.cs (Namespace.MemberName): New.
13960 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13961 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13963 * decl.cs (MemberName.Name): Make readonly.
13964 (MemberName.FromDotted): New "constructor".
13965 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13966 (MemberCore.Name): Compute from MemberName on demand.
13967 (MemberCore.SetMemberName): Provide a way to change the
13969 (MemberCore.AddToContainer): Don't take a fullname parameter.
13970 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13971 fully qualified name of the container to the member name.
13972 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13973 only if the type is a member of the root container.
13974 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13975 MemberName.Left rather than searching for an embedded ".".
13976 (PartialContainer.CreatePart): Update to changes in RootContext.
13977 (MemberBase.ShortName): Turn into a property. Use
13978 MemberCore.SetMemberName.
13979 (MemberBase.ExplicitInterfaceName): Remove.
13980 (MemberBase.UpdateMemberName): Remove.
13981 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13982 (PropertyBase.SetMemberName): New override.
13983 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13984 (Tree.GetDecl): New.
13985 (Tree.AllDecls): Rename from Decls.
13986 * attribute.cs, enum.cs, report.cs: Update to changes.
13987 * driver.cs (MainDriver): Use MemberName.FromDotted on
13988 RootContext.MainClass.
13990 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13992 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13995 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13997 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13999 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14000 property accessor modifiers.
14002 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14003 fixed buffer attribute (CS1716).
14004 (PropertyMethod.HasCustomAccessModifier): When property accessor
14005 has custom modifier.
14007 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14009 (PropertyExpr.DoResolveLValue): Add CS0272.
14011 2005-03-17 Miguel de Icaza <miguel@novell.com>
14013 * convert.cs: When converting to a pointer, use the proper Conv.U
14014 or Conv.I depending on the source data type.
14016 * cs-tokenizer.cs: Make the size for large decimal constants,
14019 2005-03-17 Martin Baulig <martin@ximian.com>
14021 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14022 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14024 2005-03-17 Martin Baulig <martin@ximian.com>
14026 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14027 to bool so we can return an error condition.
14028 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14031 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14033 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14036 2005-03-16 Raja R Harinath <rharinath@novell.com>
14038 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14039 Refactor to avoid traversing the list of assemblies, and to avoid
14040 string concatenation.
14041 * typemanager.cs (guid_attr_type): Remove.
14042 (negative_hits, pointers, references): Remove hashes.
14044 (GetConstructedType): New. Uses type_hash to handle constructed
14045 types (arrays, references, pointers).
14046 (GetReferenceType, GetPointerType): Use it.
14047 (GetNestedType): New. Uses type_hash to handle nested types of
14049 (LookupType, LookupTypeDirect): Remove.
14050 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14051 'types' hash and LookupTypeReflection directly.
14052 (params_string, params_object): Use GetConstructedType.
14053 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14055 (Namespace.Lookup): Use cached_types.
14056 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14057 provided by old TypeManager.LookupType.
14058 * rootcontext.cs (MakeFQN): Remove.
14059 * decl.cs (DeclSpace.MakeFQN): Likewise.
14060 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14061 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14062 TypeManager.GetConstructedType.
14063 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14065 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14067 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14070 * cs-parser.jay: Reports CS1527 for any namespace element.
14072 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14075 * expression.cs (ParameterReference.IsAssigned): Changed error to
14077 (Error_WrongNumArguments): Moved CS0245 detection here.
14079 * statement.cs (Return.Resolve): Add CS1622 report.
14081 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14083 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14085 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14087 * attribute.cs expression.cs: Get rid of some allocations.
14089 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14091 * doc.cs : just eliminate the latest change.
14093 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14095 * doc.cs : commented out the latest change. It breaks xml-030.cs
14097 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14099 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14100 fail. So invoke CreateType() in FindDocumentedType().
14102 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14104 * cs-tokenizer.cs : added IsKeyword().
14105 * doc.cs : Detect keyword incorrectly used as identifier.
14106 Allow identifiers prefixed by @.
14108 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14110 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14111 It caused exception in namespace resolving (again!).
14113 * class.cs (Class.ctor): Removed exit.
14114 (PropertyMethod.ctor): ditto.
14116 * codegen.cs (Codegen.Reset): Reset static data.
14117 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14119 * cs-tokenizer.cs (Cleanup): Removed.
14121 * driver.cs (GetSystemDir): Rewrote to one line command.
14122 It caused problem with unloaded dynamic modules.
14123 (UnixParseOption): Removed Exit.
14124 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14125 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14126 Now can be mcs used as library.
14128 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14131 * location.cs (Reset): Reset static data.
14133 * namespace.cs (Reset): Reset static data.
14135 * report.cs (Report.Reset): Reset static data.
14137 * rootcontext.cs (RootContext.Reset): Reset static data.
14139 * tree.cs (RootTypes.ctor): Use Location.Null
14141 * typemanager.cs (TypeManager.Reset): Reset static data.
14142 (CoreLookupType): Removed Exit.
14143 (TypeHandle.Reset): Reset static data.
14145 2005-03-10 Raja R Harinath <rharinath@novell.com>
14148 * typemanager.cs (ComputeNamespaces): Import namespaces from
14149 referenced modules too.
14151 2005-03-09 Raja R Harinath <rharinath@novell.com>
14153 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14156 2005-03-09 Raja R Harinath <rharinath@novell.com>
14158 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14159 enclosing DeclSpace. This ensures that a name-lookup populates
14160 more caches and there are fewer 'TypeExpression's. Carve out
14161 nested type lookup into ...
14162 (LookupNestedTypeInHierarchy): ... this.
14164 2005-03-09 Raja R Harinath <rharinath@novell.com>
14166 Clean up a few partial-class semantics.
14167 Fixes test-357.cs and cs1618-2.cs.
14168 * cs-parser.jay (struct_declaration): Use 'current_class' as
14169 parent of newly-created struct. Remove call to Register ().
14170 Use 'pop_current_class' to complete handing the current struct.
14171 (interface_declaration): Likewise.
14172 (class_declaration): Likewise.
14173 (enum_declaration): Use 'current_class' as parent of newly created
14175 (delegate_declaration): Likewise.
14176 (pop_current_class): New function. This is used to handle closing
14177 up the 'current_class' and 'current_container', and pointing them
14178 to the enclosing class/container.
14179 (CSharpParser): Initialize 'current_class' too.
14180 * decl.cs (MemberCore): Add check for invariant: a partial
14181 container is not a parsed entity, and thus does not enclose any
14183 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14184 (DeclSpace.BaseTypeExpr): Use it.
14185 (DeclSpace.LookupType): Add check for invariant.
14186 * class.cs (TypeContainer): Add check for invariant: a nested
14187 class should have the same NamespaceEntry as its enclosing class.
14188 (TypeContainer.EmitFieldInitializers): Make virtual.
14189 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14191 (TypeContainer.Register): Remove.
14192 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14193 null. Use TypeResolveEmitContext for resolving base types and
14194 interfaces. Move initialization of Parts.TypeBuilder here from
14196 (TypeContainer.DefineNestedTypes): ... here.
14197 (PartialContainer): Take a Namespace not a NamespaceEntry.
14198 (PartialContainer.Create): Don't use Register. Call the
14199 appropriate Add... function directly.
14200 (ClassPart): Take both the PartialContainer and the enclosing
14201 class as constructor arguments.
14202 (ClassPart.EmitFieldInitializers): Override.
14203 (ClassPart.PartFindNestedTypes): Remove.
14204 (FieldBase.GetInitializerExpression): Resolve the initializer
14205 expression in the emit context of the enclosing class.
14206 * tree.cs (RootTypes): Remove Register ().
14208 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14210 * cs-parser.jay: Removed CS0134.
14212 * driver.cs: Removed CS1901.
14214 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14215 for predefined types.
14217 2005-03-07 Duncan Mak <duncan@novell.com>
14219 * codegen.cs (Save): Catch UnauthorizedAccessException as
14220 well. Fixes bug #73454.
14222 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14224 * cs-tokenizer.cs (xtoken): Add CS1035.
14226 * class.cs (MethodData.Define): Add CS0683.
14227 (FieldMember.ctor): Add CS0681.
14229 2005-03-07 Raja R Harinath <rharinath@novell.com>
14231 * ecore.cs (SimpleName.DoResolve): Rename from
14232 SimpleName.DoResolveAllowStatic.
14233 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14234 Pass 'intermediate' flag to MemberStaticCheck.
14235 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14236 of "intermediate" lookups via MemberAccess.
14237 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14238 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14240 2005-03-07 Raja R Harinath <rharinath@novell.com>
14243 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14244 slipped in because of variable names that are identical to a
14245 builtin type's BCL equivalent ('string String;', 'int Int32;').
14246 (PropertyExpr.EmitInstance): Likewise.
14248 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14250 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14252 * report.cs (warning_ignore_table): Made public.
14254 2005-03-04 Raja R Harinath <rharinath@novell.com>
14257 * class.cs (MethodData.Emit): Pass 'container' to
14258 container.GetObsoleteAttribute instead of 'container.Parent'.
14260 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14262 * cs-parser.jay: Add 1534 error test.
14264 * iterators.cs (Yield.CheckContext): Add error 1629.
14265 (Iterator.ctor): Save unsafe modifier.
14266 (MoveNextMethod.DoEmit): Restore unsafe context.
14268 * namespace.cs (UsingAlias): Better error message.
14270 2005-03-03 Dan Winship <danw@novell.com>
14272 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14273 the warning message [#73219]
14275 2005-03-03 Raja R Harinath <rharinath@novell.com>
14277 Fix compile with MCS 1.0.0.0.
14278 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14279 w_restore to not depend on string constant folding.
14281 2005-03-03 Raja R Harinath <rharinath@novell.com>
14283 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14284 CS0246 check to users who passed 'silent = false'.
14285 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14287 (SimpleName.SimpleNameResolve): Update.
14288 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14289 (MemberAccess.IdenticalNameAndTypeName): Update.
14290 * doc.cs (FindDocumentedTypeNonArray): Update.
14292 2005-03-03 Raja R Harinath <rharinath@novell.com>
14294 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14295 * parameters.cs (ComputeAndDefineParameters): Remove.
14296 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14297 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14298 Use GetParameterInfo.
14300 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14302 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14304 2005-03-02 Raja R Harinath <rharinath@novell.com>
14306 Unify DeclSpace.LookupType and DeclSpace.FindType.
14307 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14308 is in charge of defining nested types on demand.
14309 (DeclSpace.LookupType): Use it when the current_type is a
14310 TypeBuilder. Use LookupTypeDirect for reflected types.
14311 (DeclSpace.FindType): Remove.
14312 (DeclSpace.LookupInterfaceOrClass): Likewise.
14313 (DeclSpace.DefineTypeAndParents): Likewise.
14314 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14315 DeclSpace.LookupType.
14316 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14317 * typemanager.cs (LookupType): Simplify.
14318 (AddUserType): Remove type from negative_hits.
14319 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14320 * class.cs (TypeContainer.FindMembers): Move handling of nested
14322 (TypeContainer.FindMembers_NestedTypes): ... here.
14323 (TypeContainer.FindNestedType): Implement override.
14324 (ClassPart.FindNestedType): Delegate to PartialContainer.
14325 (ClassPart.PartFindNestedType): Looks up the nested types of the
14328 2005-03-02 Martin Baulig <martin@ximian.com>
14330 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14331 static constructor in static classes.
14333 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14335 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14336 sizeParamIndex is not specified.
14338 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14341 * report.cs (WarningMessage.IsEnabled): Missing null check.
14343 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14345 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14346 in the fields and not in the properties.
14348 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14350 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14353 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14355 * attribute.cs: Small refactoring (improved robustness).
14356 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14357 (ValidateGuid): Removed.
14358 (Resolve): Removed referenced to above mentioned.
14359 (GetAttributeUsage): Made private and changed to work without
14361 (GetIndexerAttributeValue): Don't crash.
14362 (GetConditionalAttributeValue): Ditto.
14363 (GetClsCompliantAttributeValue): Ditto.
14364 (ExtractSecurityPermissionSet): All attributes exceptions are
14366 (GetPropertyValue): New helper.
14367 (GetMethodImplOptions): New method.
14368 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14369 some missing properties.
14371 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14372 (Method.ApplyAttributeBuilder): Updated.
14374 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14377 2005-02-28 Raja R Harinath <rharinath@novell.com>
14380 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14381 non-simple types (array, pointer, reference).
14383 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14385 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14387 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14389 (Method.CheckBase): Catch wrong destructor here.
14390 (MethodData.Define): Add errors 550, 668.
14392 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14394 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14396 * pending.cs (VerifyPendingMethods): Add error 551.
14398 * typemanager.cs (CSharpName): Next error report helper.
14400 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14402 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14403 attributes. Removed useless attribute double check.
14404 It saves almost 2MBs for corlib.
14406 2005-02-25 Raja R Harinath <rharinath@novell.com>
14409 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14410 called twice in case of error.
14412 2005-02-23 Chris Toshok <toshok@ximian.com>
14414 Fix compiler portions of #72827.
14415 * statement.cs (Block.Emit): call Begin/EndScope on the
14416 EmitContext instead of the ILGenerator.
14418 * codegen.cs (EmitContext.BeginScope): new method, call
14419 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14421 (EmitContext.BeginScope): same, but EndScope and CloseScope
14423 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14424 offset and call the superclass's OpenScope(int) with it.
14425 (SymbolWriter.CloseScope): get the current il
14426 offset and call superclass's CloseScope(int) with it.
14428 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14430 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14431 CS1677 for out and ref as well.
14433 * class.cs (Method.Define): Add error CS1599 detection.
14435 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14437 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14439 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14441 * support.cs.cs (ModifierDesc): New helper method.
14443 2005-02-23 Raja R Harinath <rharinath@novell.com>
14444 Abin Thomas <projectmonokochi@rediffmail.com>
14445 Anoob V E <projectmonokochi@rediffmail.com>
14446 Harilal P R <projectmonokochi@rediffmail.com>
14448 Fix #57851, #72718.
14449 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14450 MemberLookup (used for error reporting) actually returns a result.
14451 Fix error report number (122, not 112).
14453 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14454 Anoob V E <projectmonokochi@rediffmail.com>
14455 Harilal P R <projectmonokochi@rediffmail.com>
14458 * pending.cs (PendingImplementation.GetAbstractMethods):
14459 Find NonPublic members too.
14461 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14463 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14466 * class.cs (MethodCore.CheckMethodAgainstBase):
14467 Add error 239 report.
14469 2005-02-21 Raja R Harinath <rharinath@novell.com>
14472 * expression.cs (Invocation.IsApplicable): Make public.
14473 (Invocation.IsParamsMethodApplicable): Likewise.
14474 * delegate.cs (Delegate.VerifyApplicability): Don't use
14475 Invocation.VerifyArgumentCompat for parameter applicability
14476 testing. Use Invocation.IsApplicable and
14477 Invocation.IsParamsMethodApplicable.
14479 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14481 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14483 * class.cs (Operator.Define): Add error 217 report.
14485 2005-02-21 Raja R Harinath <rharinath@novell.com>
14487 * namespace.cs (UsingEntry.Resolve): Undo change below.
14489 2005-02-21 Raja R Harinath <rharinath@novell.com>
14492 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14493 disable the error message when the extended MemberLookup also
14495 (Expression.MemberLookupFinal): Update.
14496 (SimpleName.DoSimpleNameResolve): Update.
14497 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14498 Don't use MemberLookupFinal.
14499 (New.DoResolve): Update.
14500 (BaseAccess.CommonResolve): Update.
14502 2005-02-21 Raja R Harinath <rharinath@novell.com>
14505 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14506 occured previously, don't resolve again.
14508 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14511 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14512 argument. Call ResolveAttributeUsage for unresolved.
14513 when types doesn't match ctor arguments.
14515 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14516 for nested attribute classes.
14517 (Class.attribute_usage): Removed.
14518 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14519 for attribute class.
14521 * ecore.cs (IsAttribute): Removed.
14523 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14525 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14527 (attribute_types): Removed.
14528 (EmitCode): Global attributes are emited as the latest.
14530 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14532 * class.cs (EmitFieldInitializers): Don't emit field initializer
14533 for default values when optimilization is on.
14535 * constant.cs (Constant.IsDefaultValue): New property.
14537 * driver.cs: Add /optimize handling.
14541 * literal.cs: Implement new IsDefaultValue property.
14543 * rootcontext.cs (Optimize): New field, holds /optimize option.
14545 2005-02-18 Raja R Harinath <rharinath@novell.com>
14547 Fix crasher in re-opened #72347.
14548 * namespace.cs (Namespace.Lookup): Return null if
14549 DeclSpace.DefineType returns null.
14552 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14554 2005-02-18 Raja R Harinath <rharinath@novell.com>
14556 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14557 now returns null if it cannot resolve to an lvalue.
14558 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14559 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14560 returned null. Remove check for SimpleName.
14561 (EventExpr.DoResolveLValue): New.
14562 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14563 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14565 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14566 avoid CS0131 error.
14567 (Unary.ResolveOperator): Move CS0211 check ...
14568 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14570 (Unary.DoResolveLValue): Simplify.
14571 (AddressOf.DoResolveLValue): New.
14572 (ArrayAccess.DoResolveLValue): New.
14574 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14576 * attribute.cs (Attribute.Resolve): Add arguments casting for
14577 when types doesn't match ctor arguments.
14579 2005-02-16 Raja R Harinath <rharinath@novell.com>
14581 Fix parts of #63202.
14582 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14583 lookup of operator in base type. Ensure that all checks happen
14584 when the operator resolves to an "op_..." method.
14586 2005-02-15 Raja R Harinath <rharinath@novell.com>
14589 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14590 'ignore_cs0104' parameter. Pass it to ...
14591 (NamespaceEntry.Lookup): ... this.
14592 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14593 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14594 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14595 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14596 Update. Request that cs0104 errors be ignored.
14597 (ComposedCast.ResolveAsTypeStep): Update.
14599 2005-02-14 Raja R Harinath <rharinath@novell.com>
14602 * expression.cs (Invocation.BetterFunction): Remove support for
14603 comparing virtual functions and their overrides.
14604 (Invocation.IsOverride): New.
14605 (Invocation.OverloadResolve): Don't consider 'override' functions
14606 during candidate selection. Store them in a lookaside list.
14607 If the selected method is a 'virtual' function, use the list to
14608 find any overrides that are closer to the LHS type.
14610 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14612 * expression.cs (New.DoResolve): Add complex core type reduction.
14613 (New.Constantify): Converts complex core type syntax like 'new int ()'
14614 to simple constant.
14616 2005-02-14 Raja R Harinath <rharinath@novell.com>
14618 * decl.cs (EntryType.EntryType): New constructor to create an
14619 updated copy of a cache entry.
14620 (MemberCache.AddMethods): Use it.
14621 (MemberCache.ClearDeclaredOnly): Remove.
14622 (MemberCache.MemberCache): Update.
14624 2005-02-11 Miguel de Icaza <miguel@novell.com>
14626 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14627 variable. This one is represents the actual low-level declaration
14628 of the method, as opposed to the semantic level `IsStatic'.
14630 An anonymous method which is hosted into a static method might be
14631 actually an instance method. IsStatic would reflect the
14632 container, while MethodIsStatic represents the actual code
14635 * expression.cs (ParameterReference): Use the new MethodIsStatic
14636 instead of IsStatic.
14638 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14639 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14640 set on the current EmitContext.
14642 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14643 resolve our casted expression as an LValue. This triggers the
14644 proper LValue processing that is later required by Assign.
14648 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14650 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14652 C# 2.0 Fixed buffer implementation
14654 * anonymous.cs: Update after RegisterHelperClass renaming.
14656 * attribute.cs (AttributeTester.fixed_buffer_cache):
14657 Cache of external fixed buffers.
14658 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14659 implementation if field is fixed buffer else null.
14662 (TypeContainer.AddField): Accept FieldMember instead of Field.
14663 (FieldBase.IsFieldClsCompliant): Extracted code from
14664 VerifyClsCompliance descendant customization.
14665 (FixedField): New class handles fixed buffer fields.
14666 (FixedFieldExternal): Keeps information about imported fixed
14668 (IFixedField): Make access to internal or external fixed buffer
14671 * cs-parser.jay: Add fixed buffer parsing.
14673 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14676 * expression.cs (Indirection): Extended implementation to accept
14677 fixed buffer field.
14678 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14679 (ElementAccess.MakePointerAccess): Get type as parameter.
14680 (DoResolve): Add fixed buffer field expression conversion.
14681 (DoResolveLValue): Ditto.
14682 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14683 (ArrayPtr): Derives from FixedBufferPtr.
14684 (ArrayPtr.Emit): Add extra emit for array elements.
14686 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14688 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14689 for compiler generated types.
14690 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14692 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14693 and consume less memory.
14694 (Fixed.Resolve): Add fixed buffer case.
14696 * typemanager.cs (compiler_generated_attr_ctor,
14697 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14698 (HasElementType): Add our own implementation to work on every
14701 2005-02-11 Miguel de Icaza <miguel@novell.com>
14703 * anonymous.cs (CaptureContext): Track whether `this' has been
14706 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14707 only captured `this' if it was implicitly done (instance
14708 methods/variables were used).
14710 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14711 `this' must be captured.
14713 2005-01-30 Miguel de Icaza <miguel@novell.com>
14715 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14716 is null it means that there has been no need to capture anything,
14717 so we just create a sibling.
14719 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14721 Just a partial fix. The other half is fairly elusive.
14723 2005-02-10 Raja R Harinath <rharinath@novell.com>
14725 Fix #52586, cs0121-4.cs.
14726 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14727 and return a hashtable.
14728 (MemberCache.ClearDeclaredOnly): New.
14729 (MemberCache.MemberCache): Update to change. Make a deep copy of
14730 the method_hash of a base type too.
14731 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14732 type methods. Overwrite entries with the same MethodHandle so
14733 that the ReflectedType is correct. The process leaves in base
14734 virtual functions and their overrides as distinct entries.
14735 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14736 matters since it was boxed in a ArrayList before.
14737 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14739 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14740 case of a virtual function and its override (choose the overload
14742 (Invocation.OverloadResolve): Avoid 'override' members during
14743 'applicable_type' calculation.
14745 2005-02-09 Raja R Harinath <rharinath@novell.com>
14747 Combine two near-redundant caches.
14748 * typemanager.cs (method_params): Rename from method_internal_params.
14749 (TypeManager.GetParameterData): New. Replace
14750 Invocation.GetParameterData.
14751 (TypeManager.LookupParametersByBuilder): Remove.
14752 * expression.cs (Invocation.method_parameter_cache): Remove.
14753 (Invocation.GetParameterData): Remove.
14755 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14758 2005-02-08 Raja R Harinath <rharinath@novell.com>
14761 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14762 TypeManager.multicast_delegate_type is null, resolve it by looking
14763 up "System.MulticastDelegate".
14764 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14766 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14767 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14768 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14771 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14772 (LabeledStatement.AddReference): New. Set 'referenced'.
14773 (Goto.Resolve): Use it.
14775 2005-02-05 John Luke <john.luke@gmail.com>
14777 * driver.cs: remove duplicate -doc line in Usage ()
14779 2005-02-04 Raja R Harinath <rharinath@novell.com>
14781 * location.cs (Location.AddFile): Fix CS2002 error report.
14783 2005-02-02 Martin Baulig <martin@ximian.com>
14785 * delegate.cs (Delegate.DefineType): Report an internal error if
14786 TypeManager.multicast_delegate_type is null. See bug #72015 for
14789 2005-02-02 Raja R Harinath <rharinath@novell.com>
14791 Fix a crasher in a variant of #31984.
14792 * const.cs (Constant.CheckBase): New override that defers the
14793 new-or-override check in case the base type hasn't been populated
14795 (Constant.Define): Ensure the new-or-override check is performed.
14797 2005-02-01 Duncan Mak <duncan@ximian.com>
14799 * const.cs (LookupConstantValue): Check that `ce' is not null
14800 before calling GetValue ().
14802 2005-02-01 Raja R Harinath <rharinath@novell.com>
14804 Fix test-334.cs (#69519).
14805 * cs-parser.jay (using_alias_directive): Pass in an expression to
14806 NamespaceEntry.UsingAlias.
14807 (using_namespace_directive): Pass in an expression to
14808 NamespaceEntry.Using.
14809 (namespace_name): Don't flatten to a string.
14810 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14811 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14813 (NamespaceEntry.UsingEntry): Likewise.
14814 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14816 (NamespaceEntry.LookupForUsing): Remove.
14817 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14819 (NamespaceEntry.Lookup): Remove support for dotted names.
14821 2005-02-01 Raja R Harinath <rharinath@novell.com>
14823 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14825 (NamespaceEntry.ImplicitParent): Compute on demand.
14826 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14827 parallels the current.
14828 (NamespaceEntry.LookupForUsing): Use it.
14829 (NamespaceEntry.Lookup): If the current namespace-entry is
14830 implicit, don't search aliases and using tables.
14832 2005-02-01 Raja R Harinath <rharinath@novell.com>
14835 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14837 (TypeContainer.BaseCache): Compute on demand.
14838 (TypeContainer.FindMembers): Define constants and types if they're
14839 not already created.
14840 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14842 * const.cs (Constant.Define): Make idempotent.
14844 2005-01-29 Miguel de Icaza <miguel@novell.com>
14846 * pending.cs: Produce better code (no nops produced by using Ldarg
14849 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14850 i - 1' it should be arg + 1.
14854 2005-01-28 Raja R Harinath <rharinath@novell.com>
14856 * attribute.cs (Attribute.CheckAttributeType): Make private
14858 (Attribute.ResolveType): Make virtual.
14859 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14860 handling of RootContext.Tree.Types.
14862 2005-01-27 Raja R Harinath <rharinath@novell.com>
14864 Update attribute-handling to use the SimpleName/MemberAccess
14866 * cs-parser.jay (attribute): Pass in an expression to the
14867 constructors of Attribute and GlobalAttribute.
14868 * attribute.cs (Attribute): Take an expression for the name.
14869 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14870 passed in attribute name expression.
14871 (Attribute.CheckAttributeType): Use it.
14872 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14873 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14874 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14875 argument to prevent error messages if the lookup fails.
14877 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14879 * expression.cs (Indirection): Implemented IVariable interface
14880 to support indirection in AddressOf operator.
14881 (PointerArithmetic.Emit): Add optimalization for case where
14882 result can be precomputed.
14884 2005-01-26 Martin Baulig <martin@ximian.com>
14886 * class.cs (TypeContainer.AttributeTargets): Return the correct
14887 AttributeTargets depending on our `Kind' instead of throwing an
14888 exception; fixes #71632.
14890 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14893 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14896 2005-01-25 Raja R Harinath <rharinath@novell.com>
14899 * expression.cs (MemberAccess.DoResolve): Don't complain with
14900 cs0572 when the LHS of a member access has identical name and type
14903 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14906 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14908 Create custom PermissionSet only for PermissionSetAttribute.
14910 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14913 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14914 delegates in static class.
14916 2005-01-24 Martin Baulig <martin@ximian.com>
14918 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14919 merging an implicit block, just use its reachability.
14921 * statement.cs (Block.Resolve): Make the unreachable code check
14922 work wrt. implicit blocks; see test-337 from #63842.
14924 2005-01-21 Alp Toker <alp@atoker.com>
14926 * cs-parser.jay: destructor_declaration's container is PartialContainer
14927 not Class when partial types are used, so use Kind prop instead of
14930 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14932 * cs-parser.jay: Improve error reporting when an interface
14933 declares new types.
14935 2005-01-20 Dick Porter <dick@ximian.com>
14937 * support.cs: SeekableStreamReader fix from Sandor Dobos
14938 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14939 chars are read. Fixes bug 70369.
14941 2005-01-20 Raja R Harinath <rharinath@novell.com>
14943 * cs-parser.jay (catch_clause): Simplify current_block handling
14946 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14948 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14949 code with ImplicitStandardConversion to handle the implicit
14950 conversion of method groups into valid delegate invocations.
14952 The problem is that in parameter handling we were using this code
14953 path. Fixes bug #64698
14955 2005-01-19 Raja R Harinath <rharinath@novell.com>
14957 * cs-parser.jay: Fix several infelicities.
14958 - Avoid assigning to the parser value stack. Code like
14959 '$3 = null' is unclean. Synthesize a value for the code block
14961 - Avoid using oob_stack for storing location information. Use ...
14962 (_mark_): ... this. New (empty) rule. Saves the current location
14964 (foreach_statement): Avoid using oob_stack for current_block
14965 handling. Use technique used in for_statement and
14966 using_statement. Synthesize a value for the code block to store
14967 additional intermediate information.
14969 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14971 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14972 of a different type is only allowed to private fields of a
14973 containing type, not on fields of a base class.
14975 See test-174.cs and error cs0122-9.cs
14977 2005-01-13 Raja R Harinath <rharinath@novell.com>
14979 Fix test-335.cs (bug #58126).
14980 * cs-parser.jay (argument): Split out non-expression parts of the
14981 rule into 'non_simple_argument'.
14982 (invocation_expression): Support parenthesized invocations with
14983 multiple arguments, and with single non-simple arguments.
14985 2005-01-13 Raja R Harinath <rharinath@novell.com>
14987 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14990 2005-01-12 Raja R Harinath <rharinath@novell.com>
14992 Fix cs0038-1.cs, cs1640-6.cs.
14993 * ecore.cs (Expression.Resolve): Remove special-case for
14994 SimpleName in error-handling.
14995 (Expression.almostMatchedMembers): Relax access permission to
14997 (Expression.MemberLookupFailed): Handle duplicates in
14998 almostMatchedMembers list.
14999 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15000 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15001 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15002 overload if the passed in MemberInfo is a MethodBase.
15004 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15007 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15008 for non-CAS & merge permission sets properly.
15010 2005-01-11 Raja R Harinath <rharinath@novell.com>
15012 Improve standard-compliance of simple name and member access
15013 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15014 * ecore.cs (FullNamedExpression): New abstract base class
15015 for Namespaces and TypeExpressions.
15016 (ResolveFlags.SimpleName): Remove.
15017 (SimpleName): Remove support for dotted names.
15018 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15019 DeclSpace.FindType and DeclSpace.LookupType.
15020 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15021 (Expression.ExprClassName): Make member function.
15022 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15023 a namespace. Remove creation of dotted "SimpleName"s.
15024 (MemberAccess.DoResolve): Likewise.
15025 * decl.cs (DeclSpace.Cache): Make private.
15026 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15027 (DeclSpace.FindType): Update.
15028 (DeclSpace.LookupType): Move here from RootContext. Return a
15029 FullNamedExpression.
15030 * namespace.cs (Namespace): Derive from FullNamedExpression
15031 so that it can be part of expression resolution.
15032 (Namespace.Lookup): Return an FullNamedExpression.
15033 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15035 * rootcontext.cs (NamespaceLookup): Remove.
15036 (LookupType): Move to DeclSpace.
15037 * attribute.cs (CheckAttributeType): Update.
15038 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15039 (FindDocumentedTypeNonArray): Likewise.
15041 2005-01-11 Raja R Harinath <rharinath@novell.com>
15043 Fix cs0509.cs, cs1632.cs.
15044 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15045 is the same as IsInterface.
15046 (TypeContainer.GetClassBases): Likewise.
15047 * statement.cs (LabeledStatement.ig): New field.
15048 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15050 (LabeledStatement.DoEmit): Check that the label was created with
15051 the same ILGenerator.
15053 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15056 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15057 accessors to its properties.
15059 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15060 from accessors to property.
15062 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15065 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15066 only for overrides.
15068 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15070 * attribute.cs: Check for null and empty strings.
15072 I have lost another battle to Paolo.
15074 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15077 * class.cs (PropertyMethod): Set Parent field in ctors.
15078 (SetMethod.InternalParameters): Add unsafe switch hack.
15079 Override MarkForDuplicationCheck where it is appropriate.
15081 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15082 It says whether container allows members with the same name.
15083 Base default is no.
15084 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15085 Removed is_method parameter.
15087 2005-01-06 Duncan Mak <duncan@ximian.com>
15089 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15090 because the previous change led to incorrect reporting of CS1032
15091 ("Cannot define/undefine preprocessor symbols after first token in
15092 file"). Instead of using `tokens_seen' as the only flag that
15093 triggers CS1040, introduce `comments_seen'. This new flag is used
15094 to signify having seen comments on the current line, so it is
15095 unset after a newline.
15097 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15099 * doc.cs : When searching for a type, find nested type too.
15100 This fixes bug #71040.
15102 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15105 - Warn missing member comment on those classes which also does not
15106 have doc comments. Fixed bug #71041.
15107 - Don't warn missing doc comment on default constructor.
15110 2005-01-06 Duncan Mak <duncan@ximian.com>
15112 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15113 comments, set `tokens_seen' to true. This allows us to detect
15114 misplaced preprocessor directives (i.e. not at the beginning of
15115 the a line, nor after whitespaces). In that case, report error
15116 CS1040. This fixes bug #56460.
15118 * cs-parser.jay (interface_member_declaration): Add checks for
15119 IsExplicitImpl, and report CS0541 error if an interface member is
15120 defined as an explicit interface declaration.
15122 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15125 * class.cs (PropertyMethod): Set Parent field in ctors.
15126 (SetMethod.InternalParameters): Add unsafe switch hack.
15128 * decl.cs (MemberCore.Parent): Cannot be readonly.
15130 2005-01-06 Raja R Harinath <rharinath@novell.com>
15132 * decl.cs (DeclSpace.ResolveType): Remove.
15133 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15134 Merge in code from ...
15135 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15136 * class.cs, enum.cs: Update to changes.
15138 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15140 * anonymous.cs: Ensure that we init the scope of our parent if it
15141 has not been initialized yet.
15143 2004-12-30 Duncan Mak <duncan@ximian.com>
15145 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15146 if field.FieldBuilder is null. Fixes #70758.
15148 * convert.cs: Fixed some typos and updated some of the comments.
15149 (ImplicitStandardConversionExists):
15150 (TryImplicitIntConversion): If `target_type' is an interface and
15151 the type of `ic' implements this interface, return true or a new
15152 BoxedCast instead of null. This fixes #70468.
15154 2004-12-29 Duncan Mak <duncan@ximian.com>
15156 * expression.cs (Argument.Emit): Check that Expr is
15157 IMemoryLocation before casting to it, and report CS1510 otherwise.
15161 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15163 * statement.cs (Block.ThisVariable): remove the recursion here, to
15164 make the --profile more sane.
15166 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15168 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15169 assembly, by JB Evain.
15171 2004-12-17 Raja R Harinath <rharinath@novell.com>
15173 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15174 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15175 "parent" refers to enclosing type/class. "base" refers to superclass.
15177 2004-12-17 Raja R Harinath <rharinath@novell.com>
15179 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15180 Ensure that we only have GlobalAttributes.
15181 * attribute.cs (Attribute.Emit): Make non-virtual.
15182 (GlobalAttribute.Emit): Remove.
15183 (Attribute.Resolve): Make virtual.
15184 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15185 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15186 the argument. Don't create one.
15187 (Attribute.GetObsoleteAttribute): Likewise.
15188 (Attribute.GetClsCompliantAttributeValue): Likewise.
15189 * class.cs, decl.cs: Update to changes.
15191 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15193 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15195 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15197 * statement.cs (Foreach.Resolve): Add error 186 report.
15199 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15201 * expression.cs (Conditional.DoResolve): Add warning 429.
15203 * statement.cs (If.Resolve): Add warning 665.
15205 2004-12-16 Raja R Harinath <rharinath@novell.com>
15207 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15208 except when in the parser, and in GlobalAttribute.
15209 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15210 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15211 RootContext.Tree.Types.NamespaceEntry once work is done.
15212 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15213 and resets RootContext.Tree.Types.NamespaceEntry.
15215 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15217 * cs-parser.jay: Don't create a block for every variable.
15219 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15221 * location.cs: Provide extra information.
15223 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15224 variables from the captured environment, it is the ldarg_0.
15226 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15228 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15231 * class.cs: Changed warning level for 169 to avoid developer
15232 displeasure from warning flooding. It will be changed back when they
15233 fix most of current BCL warnings.
15235 * RootContext.cs: Pushed default WarningLevel to 3.
15237 * statement.cs: Removed unused variable.
15239 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15241 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15242 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15243 Add error 502 report.
15244 (StaticClass.DefineType): Add error 441 report.
15245 (Class.AllowedModifiersProp): New virtual property as temporary
15246 extension to AllowedModifiers.
15247 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15248 to share implementation with StaticClass and don't call virtual
15251 * driver.cs (MainDriver): Add error 1558 test.
15253 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15254 report. Moved error 36 test here.
15256 * statement.cs (Throw.Resolve): Add error 724 report.
15258 * typemanager.cs: Add out_attribute_type core type.
15260 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15262 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15264 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15266 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15269 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15271 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15272 Add error 3023 report.
15273 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15275 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15278 2004-12-12 John Luke <john.luke@gmail.com>
15280 * driver.cs (AddArgs): take -- into account when
15281 adding arguments, fixes bug 65710
15283 2004-12-12 Martin Baulig <martin@ximian.com>
15285 * expression.cs (Unary.TryReduceNegative): Added support for
15286 SByteConstant and ByteConstant.
15287 (Unary.Reduce): Check error values from TryReduceNegative().
15289 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15291 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15292 and report exception as error 182.
15294 2004-12-10 Raja R Harinath <rharinath@novell.com>
15296 * driver.cs (Main): Fix message when there are warnings.
15298 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15300 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15302 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15304 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15305 Reduced number of warnings.
15307 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15309 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15311 * driver.cs: Removed message.
15313 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15315 2004-12-08 <vargaz@freemail.hu>
15317 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15319 2004-12-08 Martin Baulig <martin@ximian.com>
15321 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15322 instead of a CS3002 for properties and indexer.
15324 2004-12-08 Martin Baulig <martin@ximian.com>
15326 * decl.cs (MemberName.ToString): Make this work again.
15328 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15330 * attribute.cs (Resolve): Add error 591 detection.
15332 * class.cs (FieldMember.Define): Add error 1547 detection.
15333 (Indexer.Define): Add error 620 detection.
15334 (Operator.Define): Add error 590 detection.
15336 * ecore.cs: Missing argument for error 79.
15338 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15341 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15344 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15347 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15349 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15350 Some operator comments were suppressed.
15351 * doc.cs : Implicit/explicit operator name in doc comments are like
15352 "op_Explicit(type)~returnType", so added suffix handling.
15354 2004-12-07 Martin Baulig <martin@ximian.com>
15357 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15358 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15359 (DeclSpace.ec): New protected field; store the EmitContext here.
15360 (DeclSpace.EmitContext): New public property; moved here from
15362 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15365 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15366 (Enum.Emit): Don't create a new EmitContext.
15368 * delegate.cs (Delegate.DefineType): Always create the
15371 * iterators.cs (Iterators.DefineIterator): Create a new
15372 EmitContext and store it in `ec'.
15374 2004-08-24 Martin Baulig <martin@ximian.com>
15377 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15378 this for accessibility checks.
15379 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15380 IsNestedFamilyAccessible.
15381 (TypeManager.IsSubclassOf): New method, do what the name actually
15384 2004-12-06 Raja R Harinath <rharinath@novell.com>
15386 Fix crash on cs0657-17.cs.
15387 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15388 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15389 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15390 the case where the NamespaceEntry gets overwritten.
15392 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15394 Fixed #69195, #56821
15395 * ecore.cs (ResolveBoolean): Tiny refactoring.
15397 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15398 of right expression resolving when left is false constant and
15399 operator is LogicalAnd OR true constant and operator is LogicalOr.
15401 * statement.cs (ResolveUnreachable): Always reports warning.
15403 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15405 * class.cs: Distinguish between 1721 and 1722 (just a little help
15406 for the programmer).
15408 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15410 * delegate.cs: Only allow this on new versions of the language.
15412 2004-12-02 Duncan Mak <duncan@ximian.com>
15414 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15416 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15417 here as a static method. Take an additional bool out parameter
15418 `must_do_cs1540_check' for signaling to InstanceResolve.
15419 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15420 member field from PropertyExpr class and made it an argument of
15421 the method instead.
15422 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15423 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15424 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15425 and `remove_accessor' as well as InstanceResolve: report CS0122
15430 2004-12-03 Raja R Harinath <rharinath@novell.com>
15432 Fix test-327.cs, test-328.cs, and put in early infrastructure
15433 for eventually fixing #52697.
15434 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15435 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15436 from other methods.
15437 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15438 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15439 (VerifyUsing, error246): Update.
15440 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15441 'NamespaceEntry.LookupNamespaceOrType'.
15443 2004-12-03 Martin Baulig <martin@ximian.com>
15445 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15446 method as our child, call AnonymousMethod.Compatible() on it.
15448 2004-12-03 Raja R Harinath <rharinath@novell.com>
15450 Disable XML documentation support in 'basic' profile.
15451 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15452 Redirect XmlElement to System.Object.
15453 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15454 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15455 * mcs.exe.sources: Add doc-bootstrap.cs.
15456 * doc-bootstrap.cs: New file. Contains empty stub implementation
15459 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15461 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15462 comments are allowed.
15464 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15466 * delegate.cs: Add checks for subtypes in paramaters and return values
15467 in VerifyMethod () to add support for Covariance/Contravariance
15470 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15472 * report.cs: Remove extra closing parenthesis.
15474 * convert.cs (Error_CannotImplicitConversion): If the name of the
15475 types are the same, provide some extra information.
15477 * class.cs (FieldBase): Use an unused bit field from the field to
15478 encode the `has_offset' property from the FieldMember. This saves
15479 a couple of Ks on bootstrap compilation.
15481 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15482 method as our child, return the AnonymousMethod resolved
15485 * expression.cs (New.DoResolve): Allow return values from
15486 NewDelegate to also include AnonymousMethods.
15490 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15493 * attribute.cs (Resolve): Improved implementation of params
15494 attribute arguments.
15496 * support.cs (ParameterData): Add HasParams to be faster.
15498 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15500 all things are for /doc support:
15502 * doc.cs: new file that supports XML documentation generation.
15503 * mcs.exe.sources: added doc.cs.
15505 Handle /doc command line option.
15506 Report error 2006 instead of 5 for missing file name for /doc.
15507 Generate XML documentation when required, after type resolution.
15509 Added support for picking up documentation (/// and /** ... */),
15510 including a new XmlCommentState enumeration.
15512 Added lines to fill Documentation element for field, constant,
15513 property, indexer, method, constructor, destructor, operator, event
15514 and class, struct, interface, delegate, enum.
15515 Added lines to warn incorrect comment.
15517 Added Documentation field (passed only when /doc was specified).
15519 Added DocComment, DocCommentHeader, GenerateDocComment() and
15520 OnGenerateDocComment() and some supporting private members for
15521 /doc feature to MemberCore.
15523 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15525 Added overriden DocCommentHeader.
15527 Added overriden DocCommentHeader and GenerateDocComment().
15529 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15531 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15532 unwrapping the enumeration values, chain to
15533 DoConstantNumericPromotions again, so we can promote things to the
15534 fundamental types (takes care of enums that are bytes, sbytes).
15538 2004-12-01 Raja R Harinath <rharinath@novell.com>
15540 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15541 Fix long-standing bug in type-lookup. Use FindType instead of
15542 LookupType when ec.ResolvingTypeTree.
15543 (Attribute.ResolveType, Attribute.Resolve)
15544 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15546 (Attributes.Search): Remove internal version. Update.
15547 (Attributes.SearchMulti): Update.
15548 (Attributes.GetClsCompliantAttribute): Remove.
15549 (Attributes.GetIndexerNameAttribute): Remove.
15550 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15551 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15552 * class.cs (Indexer.Define): Likewise.
15554 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15557 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15558 MarshallByReference members access.
15560 * expression.cs: Use CheckMarshallByRefAccess;
15561 Better error CS0197 message.
15563 * report.cs: Print whole related error message.
15565 2004-11-30 Raja R Harinath <rharinath@novell.com>
15567 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15568 the current directory to help debugging.
15570 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15572 * class (GetClassBases): Better error 60 report.
15573 (EventProperty): Disabled warning 67 detection.
15575 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15578 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15580 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15583 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15586 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15588 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15590 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15592 * attribute.cs (Attribute.Resolve): Refine error reporting and
15593 report a cs0117 if the identifier does not exist, to distinguish
15594 from 0617 which is a miss-use of the actual identifier.
15596 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15597 between cs0070 and cs0079.
15599 * class.cs (MemberBase.DoDefine): When reporting a wrong
15600 accessibility level, we use MethodCore to compare instead of
15601 Method (this was a regression in some refactoring effort).
15603 So now we correctly report cs0056 again.
15605 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15606 testing the target_type (which was known to be object_type) and
15607 not the source type (which is anonymous_method).
15609 Fixed reporting of error cs1660.
15611 * expression.cs (UserCast.Source): Expose the underlying cast.
15613 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15614 allowed types to find a match to int32 first (most common).
15616 In addition, it ignores any ImplicitUserConversions that did an
15617 internal implicit conversion (as the switch statement allows only
15618 one integral conversion to exist).
15620 * class.cs (PartialContainer.Create): rename `name' to
15621 `member_name' for clarity. Then replace the string calls with a
15622 call to MemberName.GetPartialName, as now using
15623 MemberName.ToString is an error (this is due to the side effects
15624 it had, that were fixed in the past).
15626 This will restore the error reporting on a number of partial class
15627 errors that were missusing this (and getting an exception as a
15628 results, which is now just a plain textual warning, because
15629 yyparse debug output would crash otherwise).
15631 2004-11-26 Raja R Harinath <rharinath@novell.com>
15633 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15635 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15637 * rootcontext.cs (LookupType): Make sure to cache lookups that
15638 don't give us a negative result. This saves about 5% of corlib
15641 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15643 * report.cs (AbstractMessage.Print): messages are sent to stderr
15645 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15646 non-interface in the list of interfaces (at this point, either
15647 parent was properly set, or a base class is being listed in the
15648 interfaces section).
15650 This flags error 1722, and resolves the crash from bug 69259.
15652 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15654 * statement.cs (Using.EmitExpressionFinally): make this work right
15655 for valuetypes. Fixes 69926.
15657 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15659 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15660 converted to an enum" here, before we try to change the underlying
15661 type. This code exists, but it is a different code path than the
15662 one used while encoding constants.
15664 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15665 old bug: when converting from the null literal to a pointer,
15666 return an EmptyCast, not the NullLiteral.
15668 This fixes #69921, the recent null_type changes probably made this
15669 bug more prominent.
15671 (ImplicitReferenceConversionExists): In addition, resynchronized
15672 the code here, so it matches the same code in
15673 ImplicitReferenceConversionExists for the `from any class-type S
15674 to any interface-type T'.
15677 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15679 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15681 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15683 * cs-parser.jay: Use verbosity accordingly.
15685 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15687 * expression.cs (Unary.ResolveOperator): Do not report warning;
15688 AddressOf reads from variable.
15690 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15692 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15696 * attribute.cs (Attributable): Removed CheckTargets.
15697 (Attributes.Emit): Explicit attribute targets are tested here.
15699 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15700 not enabled for interfaces.
15702 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15703 (GetAssemblyName): Ouch next bug there.
15705 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15707 * expression.cs: Error 275 added.
15709 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15711 Fix bug #69177 (Implemented decimal constant support)
15713 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15714 (BinaryFold): Add DecimalConstant.
15716 * const.cs (Define): Decimal constant
15718 (ChangeType): Add decimal type handling.
15719 (LookupConstantValue): Don't set value for decimal type but
15720 emit DecimalConstantAttribute. Needed for constant optimization.
15722 * constant.cs (ToDecimal): New method.
15723 (ConvertToDecimal): New method.
15724 (IntConstant): Implemented ConvertToDecimal.
15725 (DecimalConstant.Emit): Emit optimized version for decimals in
15728 * expression.cs (ResolveOperator): Changed order of constant
15729 reduction to work correctly with native types which have
15730 overloaded operators.
15731 (ResolveMemberAccess): Extract constant value from attribute
15734 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15736 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15737 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15738 (ChangeType): Decimal is special.
15739 (TypeToCoreType): Add decimal type.
15741 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15743 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15746 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15748 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15751 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15753 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15755 * pending.cs (PendingImplementation): Grab only interfaces.
15757 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15759 * statement.cs (ForeachHelperMethods): Add location member and
15760 error 202 detection.
15762 2004-11-19 Raja R Harinath <rharinath@novell.com>
15764 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15765 automatically handled by executable.make.
15766 (PROGRAM): Make profile-specific.
15768 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15770 * expression.cs (DoResolveBase): Fixed wrong warning for out
15773 2004-11-18 Martin Baulig <martin@ximian.com>
15775 Merged latest changes into gmcs. Please keep this comment in
15776 here, it makes it easier for me to see what changed in MCS since
15777 the last time I merged.
15779 2004-11-17 Raja R Harinath <rharinath@novell.com>
15781 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15782 (TypeHandle.GetMemberCache): New.
15783 (TypeHandle.TypeHandle): Update.
15784 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15785 (TypeManager.LookupParentInterfacesCache):
15786 Rename from LookupInterfaceCache. Optimize slightly.
15787 (TypeManager.MemberLookup_FindMembers): Update.
15788 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15789 multi-type variant.
15790 (AddCacheContents): Rename from AddHashtable.
15791 * class.cs (TypeContainer.parent_container): Remove.
15792 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15793 (TypeContainer.DoDefineMembers): Don't initialize it.
15794 Update to name changes.
15796 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15798 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15799 that factors the code to check access modifiers on override.
15801 (PropertyBase): Use the code here.
15803 Patch from Lluis S'anchez, fixes bug #69361.
15805 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15807 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15808 routine that is used to report the use of a captured variable
15809 whose address has been taken.
15811 There are two checks: one when variables are being captured and
15812 the other check is when the address of a variable is taken.
15814 (because an anonymous methods might be resolved before *or* after
15815 the address has been taken) and
15817 * expression.cs (Conditional.DoResolve): Remove the special
15818 casing that Martin added to trueExpr and falseExpr being both
15819 NullLiteral. We get the right behavior now just by introducing
15820 the null_type into the compiler.
15822 * convert.cs (ExplicitConversion): Change the code to use
15823 null_type instead of testing `expr is NullLiteral'.
15824 (ImplicitConversionStandard): use null_type too.
15825 (ImplicitReferenceConversionExists): use null_type too.
15826 (ImplicitReferenceConversion): use null_type too.
15828 * literal.cs: The type of `NullLiteral' is now null_type instead
15830 (Resolve): Set the type here.
15832 * typemanager.cs: Introduce null_type.
15834 2004-11-17 Martin Baulig <martin@ximian.com>
15836 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15837 direction, like FindMembers() does. Fixes #69546, testcase is in
15840 2004-11-16 Martin Baulig <martin@ximian.com>
15842 This is based on a patch from Marek Safar, see bug #69082.
15843 Fixes bugs #63705 and #67130.
15845 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15846 method; create a MemberCache for an interface type and cache the
15849 * decl.cs (IMemberContainer.ParentContainer): Removed.
15850 (IMemberContainer.ParentCache): New property.
15851 (MemberCache.SetupCacheForInterface): Removed.
15852 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15853 to create a cache for an interface's "parent".
15855 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15858 2004-11-16 Martin Baulig <martin@ximian.com>
15860 Merged back from gmcs; these changes already went into gmcs a
15861 couple of weeks ago.
15864 (TypeManager.AddUserType): Removed the `ifaces' argument.
15865 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15867 (TypeManager.AddUserInterface): Removed.
15868 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15870 (TypeManager.GetInterfaces): Likewise.
15871 (TypeManager.GetExplicitInterfaces): Likewise.
15873 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15875 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15876 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15878 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15880 * statement.cs: Avoid adding bools to a hashtable.
15882 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15884 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15885 calling an unsafe method from a safe location.
15887 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15890 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15892 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15894 * namespace.cs (VerifyUsing): use GetPartialName instead of
15897 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15899 * statement.cs (Return.Resolve): Fix regression in typo: if
15900 `in_exc', we have to request a NeedReturnLabel, this was a typo
15901 introduced in the anonymous method check-in. Fixes #69131.
15903 * Indexers were using the ShortName when defining themselves,
15904 causing a regression in the compiler bootstrap when applying the
15905 patch from 2004-11-02 (first part), now they use their full name
15906 and the bug is gone.
15908 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15910 * driver.cs: Strip the path from the names of embedded resources. Fixes
15913 2004-11-04 Raja R Harinath <rharinath@novell.com>
15915 Fix error message regression: cs0104-2.cs.
15916 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15917 (AliasEntry.Resolve): Update.
15918 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15920 (RootContext.LookupType): Update.
15922 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15924 * cs-parser.jay: Add support for handling accessor modifiers
15925 * class: Add support port accessor modifiers and error checking,
15926 define PropertyMethod.Define as virtual (not abstract anymore)
15927 * ecore.cs: Add checking for proeprties access with access modifiers
15928 * iterators.cs: Modify Accessor constructor call based in the modified
15930 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15932 * expression.cs (StringConcat): Handle being called twice,
15933 as when we have a concat in a field init with more than two
15936 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15938 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15939 special case explicit implementations, we should always produce
15940 the .property or .event declaration.
15942 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15943 since it will not return correct data if people use this
15944 unresolved in the presence of using statements (see test-313).
15946 * class.cs (MethodData.Define): If we are an explicit interface
15947 implementation, set the method name to the full name of the
15948 interface plus the name of the method.
15950 Notice that using the method.MethodName.GetFullName() does not
15951 work, as it will only contain the name as declared on the source
15952 file (it can be a shorthand in the presence of using statements)
15953 and not the fully qualifed type name, for example:
15957 class D : ICloneable {
15958 object ICloneable.Clone () {
15962 Would produce a method called `ICloneable.Clone' instead of
15963 `System.ICloneable.Clone'.
15965 * namespace.cs (Alias.Resolve): Use GetPartialName.
15967 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15969 * cs-parser.jay: Add error 1055 report.
15971 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15973 * assign.cs (Assign.DoResolve): Only do the transform of
15974 assignment into a New if the types are compatible, if not, fall
15975 through and let the implicit code deal with the errors and with
15976 the necessary conversions.
15978 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15980 * cs-parser.jay: Add error 1031 report.
15982 * cs-tokenizer.cs: Add location for error 1038.
15984 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15986 * cs-parser.jay: Add error 1016 report.
15988 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15990 * cs-parser.jay: Add errors 1575,1611 report.
15992 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15994 * cs-parser.jay: Add error 1001 report.
15996 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15999 * attribute.cs (GetMarshal): Add method argument for
16000 caller identification.
16002 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16003 agument for GetMarshal and RuntimeMissingSupport.
16005 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16007 * attribute.cs (ExtractSecurityPermissionSet): Removed
16008 TypeManager.code_access_permission_type.
16010 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16012 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16014 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16015 for obsolete use of a variable here. Fixes regression on errors
16016 cs0619-25 and cs0619-26.
16018 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16020 Fix #62358, implemented security attribute encoding.
16022 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16023 Tests permitted SecurityAction for assembly or other types.
16024 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16025 data from SecurityPermissionAttribute to PermisionSet class.
16027 * class.cs (ApplyAttributeBuilder): Added special handling
16028 for System.Security.Permissions.SecurityAttribute based types.
16030 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16031 special handling for System.Security.Permissions.SecurityAttribute
16034 * enum.cs (ApplyAttributeBuilder): Added special handling
16035 for System.Security.Permissions.SecurityAttribute based types.
16037 * parameter.cs (ApplyAttributeBuilder): Added special handling
16038 for System.Security.Permissions.SecurityAttribute based types.
16040 * rootcontext.cs: Next 2 core types.
16042 * typemanager.cs (TypeManager.security_permission_attr_type):
16043 Built in type for the SecurityPermission Attribute.
16044 (code_access_permission_type): Build in type.
16046 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16048 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16049 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16050 all of this information into
16051 EmitContext.EmitCapturedVariableInstance.
16053 * codegen.cs (EmitCapturedVariableInstance): move here the
16054 funcionality of emitting an ldarg.0 in the presence of a
16055 remapping. This centralizes the instance emit code.
16057 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16058 then emit a load of this: it means that we have reached the
16059 topmost ScopeInfo: the one that contains the pointer to the
16060 instance of the class hosting the anonymous method.
16062 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16063 captures to the topmost CaptureContext.
16065 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16067 * expression.cs (LocalVariableReference): Move the knowledge about
16068 the iterators into codegen's EmitCapturedVariableInstance.
16070 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16072 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16073 all code paths return a value from an anonymous method (it is the
16074 same as the 161 error, but for anonymous methods).
16076 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16078 The introduction of anonymous methods in the compiler changed
16079 various ways of doing things in the compiler. The most
16080 significant one is the hard split between the resolution phase
16081 and the emission phases of the compiler.
16083 For instance, routines that referenced local variables no
16084 longer can safely create temporary variables during the
16085 resolution phase: they must do so from the emission phase,
16086 since the variable might have been "captured", hence access to
16087 it can not be done with the local-variable operations from the runtime.
16091 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16092 is a toplevel block.
16094 (ToplevelBlock): A new kind of Block, these are the blocks that
16095 are created by the parser for all toplevel method bodies. These
16096 include methods, accessors and anonymous methods.
16098 These contain some extra information not found in regular blocks:
16099 A pointer to an optional CaptureContext (for tracking captured
16100 local variables and parameters). A pointer to the parent
16103 (Return.Resolve): Catch missmatches when returning a value from an
16104 anonymous method (error 1662).
16105 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16108 (Break.Resolve): ditto.
16110 (SwitchLabel): instead of defining the labels during the
16111 resolution phase, we now turned the public ILLabel and ILLabelCode
16112 labels into methods called GetILLabelCode() and GetILLabel() that
16113 only define the label during the Emit phase.
16115 (GotoCase): Track the SwitchLabel instead of the computed label
16116 (its contained therein). Emit the code by using
16117 SwitchLabel.GetILLabelCode ().
16119 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16120 whether the Local has been captured or not.
16122 (LocalInfo.IsCaptured): New property, used to tell whether the
16123 local has been captured.
16125 * anonymous.cs: Vastly updated to contain the anonymous method
16128 The main classes here are: CaptureContext which tracks any
16129 captured information for a toplevel block and ScopeInfo used to
16130 track the activation frames for various local variables.
16132 Each toplevel block has an optional capture context associated
16133 with it. When a method contains an anonymous method both the
16134 toplevel method and the anonymous method will create a capture
16135 context. When variables or parameters are captured, they are
16136 recorded on the CaptureContext that owns them, for example:
16140 MyDelegate d = delegate {
16145 Here `a' will be recorded as captured on the toplevel
16146 CapturedContext, the inner captured context will not have anything
16147 (it will only have data if local variables or parameters from it
16148 are captured in a nested anonymous method.
16150 The ScopeInfo is used to track the activation frames for local
16151 variables, for example:
16153 for (int i = 0; i < 10; i++)
16154 for (int j = 0; j < 10; j++){
16155 MyDelegate d = delegate {
16160 At runtime this captures a single captured variable `i', but it
16161 captures 10 different versions of the variable `j'. The variable
16162 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16163 recorded on a child.
16165 The toplevel ScopeInfo will also track information like the `this'
16166 pointer if instance variables were referenced (this is necessary
16167 as the anonymous method lives inside a nested class in the host
16168 type of the method).
16170 (AnonymousMethod): Expanded to track the Toplevel, implement
16171 `AnonymousMethod.Compatible' to tell whether an anonymous method
16172 can be converted to a target delegate type.
16174 The routine now also produces the anonymous method content
16176 (AnonymousDelegate): A helper class that derives from
16177 DelegateCreation, this is used to generate the code necessary to
16178 produce the delegate for the anonymous method that was created.
16180 * assign.cs: API adjustments for new changes in
16181 Convert.ImplicitStandardConversionExists.
16183 * class.cs: Adjustments to cope with the fact that now toplevel
16184 blocks are of type `ToplevelBlock'.
16186 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16187 insteda of standard blocks.
16189 Flag errors if params arguments are passed to anonymous methods.
16191 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16192 `CurrentAnonymousMethod' which points to the current Anonymous
16193 Method. The variable points to the AnonymousMethod class that
16194 holds the code being compiled. It is set in the new EmitContext
16195 created for the anonymous method.
16197 (EmitContext.Phase): Introduce a variable and an enumeration to
16198 assist in enforcing some rules about when and where we are allowed
16199 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16200 only one that enfonces this right now).
16202 (EmitContext.HaveCaptureInfo): new helper method that returns
16203 whether we have a CapturedContext initialized.
16205 (EmitContext.CaptureVariable): New method used to register that a
16206 LocalInfo must be flagged for capturing.
16208 (EmitContext.CapturedParameter): New method used to register that a
16209 parameters must be flagged for capturing.
16211 (EmitContext.CapturedField): New method used to register that a
16212 field must be flagged for capturing.
16214 (EmitContext.HaveCapturedVariables,
16215 EmitContext.HaveCapturedFields): Return whether there are captured
16216 variables or fields.
16218 (EmitContext.EmitMethodHostInstance): This is used to emit the
16219 instance for the anonymous method. The instance might be null
16220 (static methods), this (for anonymous methods that capture nothing
16221 and happen to live side-by-side with the current method body) or a
16222 more complicated expression if the method has a CaptureContext.
16224 (EmitContext.EmitTopBlock): Routine that drives the emission of
16225 code: it will first resolve the top block, then emit any metadata
16226 and then emit the code. The split is done so that we can extract
16227 any anonymous methods and flag any captured variables/parameters.
16229 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16230 during this phase, the ILGenerator should not be used as labels
16231 and local variables declared here might not be accessible to any
16232 code that is part of an anonymous method.
16234 Exceptions to this include the temporary variables that are
16235 created by some statements internally for holding temporary
16238 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16241 (EmitContext.TemporaryReturn): This method is typically called
16242 from the Emit phase, and its the only place where we allow the
16243 ReturnLabel to be defined other than the EmitMeta. The reason is
16244 that otherwise we would have to duplicate a lot of logic in the
16245 Resolve phases of various methods that today is on the Emit
16248 (EmitContext.NeedReturnLabel): This no longer creates the label,
16249 as the ILGenerator is not valid during the resolve phase.
16251 (EmitContext.EmitThis): Extended the knowledge in this class to
16252 work in anonymous methods in addition to iterators.
16254 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16255 code is necessary on the stack to access the instance to a local
16256 variable (the variable will be accessed as a field).
16258 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16259 EmitContext.EmitAddressOfParameter): Routines to support
16260 parameters (not completed at this point).
16262 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16263 will also remove the parameters.
16265 * convert.cs (Convert): Define a `ConstantEC' which points to a
16266 null. This is just to prefity some code that uses
16267 ImplicitStandardConversion code and do not have an EmitContext
16270 The idea is to flag explicitly that at that point in time, it is
16271 known that the conversion will not trigger the delegate checking
16272 code in implicit conversions (which requires a valid
16275 Everywhere: pass new EmitContext parameter since
16276 ImplicitStandardConversionExists now requires it to check for
16277 anonymous method conversions.
16279 (Convert.ImplicitStandardConversionExists): If the type of an
16280 expression is the anonymous_method_type, and the type is a
16281 delegate, we invoke the AnonymousMethod.Compatible method to check
16282 whether an implicit conversion is possible.
16284 (Convert.ImplicitConversionStandard): Only do implicit method
16285 group conversions if the language level is not ISO_1.
16287 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16288 MethodInfo for the Invoke method. used by Delegate and
16291 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16292 method conversions if the target type is a delegate.
16294 Removed extra debugging nops.
16296 (LocalVariableReference): Turn the `local_info' into a public
16299 Add `prepared' field, the same hack used for FieldExprs to cope
16300 with composed assignments, as Local variables do not necessarily
16301 operate purely on the stack as they used to: they can be captured
16304 Add `temp' for a temporary result, like fields.
16306 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16308 It now copes with Local variables that are captured and emits the
16309 proper instance variable to load it from a field in the captured
16312 (ParameterReference.DoResolveBase): During the resolve phase,
16313 capture parameters if we are in an anonymous method.
16315 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16316 anonymous method, use the EmitContext helper routines to emit the
16317 parameter reference.
16319 * iterators.cs: Set RemapToProxy to true/false during the
16322 * parameters.cs (GetParameterByName): New helper method.
16324 * typemanager.cs (anonymous_method_type) a new type that
16325 represents an anonyous method. This is always an internal type,
16326 used as a fencepost to test against the anonymous-methodness of an
16329 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16331 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16333 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16335 2004-10-18 Martin Baulig <martin@ximian.com>
16337 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16338 `Type' directly, but call ResolveType() on it.
16339 (Catch.Resolve): Likewise.
16340 (Foreach.Resolve): Likewise.
16342 2004-10-18 Martin Baulig <martin@ximian.com>
16344 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16345 `Type' directly, but call ResolveType() on it.
16346 (Probe.DoResolve): Likewise.
16347 (ArrayCreation.LookupType): Likewise.
16348 (TypeOf.DoResolve): Likewise.
16349 (SizeOf.DoResolve): Likewise.
16351 2004-10-18 Martin Baulig <martin@ximian.com>
16353 * expression.cs (Invocation.BetterFunction): Put back
16354 TypeManager.TypeToCoreType().
16356 2004-10-18 Raja R Harinath <rharinath@novell.com>
16358 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16361 2004-10-18 Martin Baulig <martin@ximian.com>
16363 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16364 `Type' directly, but call ResolveType() on it.
16366 2004-10-18 Martin Baulig <martin@ximian.com>
16368 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16369 `Type' directly, but call ResolveType() on it.
16370 (MemberBase.DoDefine): Likewise.
16372 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16373 `Type' directly, but call ResolveType() on it.
16374 (ComposedCast.DoResolveAsTypeStep): Likewise.
16376 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16377 `Type' directly, but call ResolveType() on it.
16379 2004-10-17 John Luke <john.luke@gmail.com>
16381 * class.cs (Operator.GetSignatureForError): use CSharpName
16383 * parameter.cs (Parameter.GetSignatureForError): Returns
16384 correct name even if was not defined.
16386 2004-10-13 Raja R Harinath <rharinath@novell.com>
16389 * class.cs (TypeContainer.EmitContext): New property.
16390 (DefineNestedTypes): Create an emitcontext for each part.
16391 (MethodCore.DoDefineParameters): Use container's emitcontext.
16392 Pass type array to InternalParameters.
16393 (MemberBase.DoDefine): Use container's emitcontext.
16394 (FieldMember.Define): Likewise.
16395 (Event.Define): Likewise.
16396 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16397 Pass type array to InternalParameters.
16398 (SetIndexerMethod.GetParameterInfo): Likewise.
16399 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16400 * delegate.cs (Define): Pass emitcontext to
16401 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16402 array to InternalParameters.
16403 * expression.cs (ParameterReference.DoResolveBase): Pass
16404 emitcontext to GetParameterInfo.
16405 (ComposedCast.DoResolveAsTypeStep): Remove check on
16406 ec.ResolvingTypeTree.
16407 * parameter.cs (Parameter.Resolve): Change argument to
16408 EmitContext. Use ResolveAsTypeTerminal.
16409 (Parameter.GetSignature): Change argument to EmitContext.
16410 (Parameters.ComputeSignature): Likewise.
16411 (Parameters.ComputeParameterTypes): Likewise.
16412 (Parameters.GetParameterInfo): Likewise.
16413 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16414 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16415 * support.cs (InternalParameters..ctor): Remove variant that takes
16417 * typemanager.cs (system_intptr_expr): New.
16418 (InitExpressionTypes): Initialize it.
16420 2004-10-12 Chris Toshok <toshok@ximian.com>
16422 * cs-parser.jay: fix location for try_statement and catch_clause.
16424 2004-10-11 Martin Baulig <martin@ximian.com>
16426 * report.cs: Don't make --fatal abort on warnings, we have
16427 -warnaserror for that.
16429 2004-10-07 Raja R Harinath <rharinath@novell.com>
16431 More DeclSpace.ResolveType avoidance.
16432 * decl.cs (MemberCore.InUnsafe): New property.
16433 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16434 with newly created EmitContext.
16435 (FieldMember.Define): Likewise.
16436 * delegate.cs (Delegate.Define): Likewise.
16437 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16438 only if normal name-lookup fails.
16439 (TypeExpr.DoResolve): Enable error-checking.
16440 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16441 (SizeOf.DoResolve): Likewise.
16442 (ComposedCast.DoResolveAsTypeStep): Likewise.
16443 (StackAlloc.DoResolve): Likewise.
16444 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16445 (Block.Unsafe): New property.
16446 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16447 (Unsafe): Set 'unsafe' flag of contained block.
16448 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16449 (Fixed.Resolve): Likewise.
16450 (Catch.Resolve): Likewise.
16451 (Using.ResolveLocalVariableDecls): Likewise.
16452 (Foreach.Resolve): Likewise.
16454 2004-10-05 John Luke <john.luke@gmail.com>
16456 * cs-parser.jay: add location to error CS0175
16458 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16460 * ecore.cs (Expression.Constantity): Add support for turning null
16463 * const.cs (Const.Define): Allow constants to be reference types
16464 as long as the value is Null.
16466 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16468 * namespace.cs (NamespaceEntry.Using): No matter which warning
16469 level is set, check if this namespace name has already been added.
16471 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16473 * expression.cs: reftype [!=]= null should always use br[true,false].
16476 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16479 * attribute.cs: Enum conversion moved to
16480 GetAttributeArgumentExpression to be applied to the all
16483 2004-10-01 Raja R Harinath <rharinath@novell.com>
16485 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16486 * class.c (TypeContainer.DefineType): Flag error if
16487 base types aren't accessible due to access permissions.
16488 * decl.cs (DeclSpace.ResolveType): Move logic to
16489 Expression.ResolveAsTypeTerminal.
16490 (DeclSpace.ResolveTypeExpr): Thin layer over
16491 Expression.ResolveAsTypeTerminal.
16492 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16493 Refactor code into NestedAccess. Use it.
16494 (DeclSpace.NestedAccess): New.
16495 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16496 argument to silence errors. Check access permissions.
16497 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16498 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16499 (Cast.DoResolve): Likewise.
16500 (New.DoResolve): Likewise.
16501 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16502 (TypeOf.DoResolve): Likewise.
16504 * expression.cs (Invocation.BetterConversion): Return the Type of
16505 the better conversion. Implement section 14.4.2.3 more faithfully.
16506 (Invocation.BetterFunction): Make boolean. Make correspondence to
16507 section 14.4.2.2 explicit.
16508 (Invocation.OverloadResolve): Update.
16509 (Invocation): Remove is_base field.
16510 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16511 (Invocation.Emit): Likewise.
16513 2004-09-27 Raja R Harinath <rharinath@novell.com>
16515 * README: Update to changes.
16517 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16519 * cs-parser.jay: Reverted 642 warning fix.
16521 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16524 * decl.cs (FindMemberWithSameName): Indexer can have more than
16527 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16529 * expression.cs (LocalVariableReference.DoResolveLValue):
16530 Do not report warning 219 for out values.
16531 (EmptyExpression.Null): New member to avoid extra allocations.
16533 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16535 * cs-parser.jay: Fix wrong warning 642 report.
16537 * cs-tokenizer.cs (CheckNextToken): New helper;
16538 Inspect next character if is same as expected.
16540 2004-09-23 Martin Baulig <martin@ximian.com>
16542 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16543 (Convert.ImplicitReferenceConversionExists): Likewise.
16545 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16547 * class.cs (Operator.Define): Add error 448 and 559 report.
16549 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16551 * class.cs (MemberBase.IsTypePermitted): New protected
16552 method for checking error CS0610.
16554 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16556 * class.cs (TypeContainer.HasExplicitLayout): New property
16557 Returns whether container has StructLayout attribute set Explicit.
16558 (FieldMember): New abstract class for consts and fields.
16559 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16560 (Field): Reuse FieldMember.
16562 * const.cs (Const): Reuse FieldMember.
16564 * rootcontext.cs: EmitConstants call moved to class.
16566 2004-09-22 Martin Baulig <martin@ximian.com>
16568 Thanks to Peter Sestoft for this bug report.
16570 * expression.cs (Conditional): If both the `trueExpr' and the
16571 `falseExpr' is a NullLiteral, return a NullLiteral.
16573 2004-09-22 Martin Baulig <martin@ximian.com>
16575 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16576 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16577 for the "get_Current" call.
16579 2004-09-22 Martin Baulig <martin@ximian.com>
16581 Marek and me just fixed one of our oldest bugs: #28562 :-)
16583 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16585 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16586 we're an EnumConstant, just return that.
16587 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16588 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16589 to get the value which'll actually be written into the attribute.
16590 However, we have to use GetValue() to access the attribute's value
16593 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16595 * constant.cs (Constant.IsNegative): New abstract property
16598 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16599 (StackAlloc.DoResolve): Reused IsNegative.
16601 2004-09-21 Martin Baulig <martin@ximian.com>
16603 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16604 if we're used in an iterator, we may be called from different
16607 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16608 we actually have an exception block.
16610 2004-09-20 John Luke <jluke@cfl.rr.com>
16612 * class.cs, cs-parser.jay: Improve the error report for 1520:
16613 report the actual line where the error happens, not where the
16614 class was declared.
16616 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16617 Pass location information that was available elsewhere.
16619 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16621 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16622 runtime to delay sign assemblies.
16624 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16626 * cs-parser.jay: Do not report the stack trace, this is barely
16629 2004-08-22 John Luke <john.luke@gmail.com>
16631 * driver.cs : check that a resource id is not already used
16632 before adding it, report CS1508 if it is, bug #63637
16634 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16636 * ecore.cs: Removed dead code.
16638 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16640 * class.cs: Do not report warning CS0067 on the interfaces.
16642 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16644 * cs-parser.jay: Add error 504 report.
16646 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16648 * rootcontext.cs: WarningLevel is 4 by default now.
16650 * statement.cs (Fixed.Resolve): Do not null
16653 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16656 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16657 deep search when property is not virtual.
16658 (PropertyExpr.ResolveAccessors): Make one call for both
16661 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16664 * statement.cs: Error 152 report constains also location.
16666 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16669 * const.cs: Explicitly set constant as static.
16671 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16674 * cs-parser.jay: Add error 1017 report.
16676 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16678 Fixed bug #59980, #64224
16679 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16681 * typemanager.cs (IsSpecialMethod): Simplified
16683 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16685 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16686 condition with better params.
16688 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16691 * attribute.cs (Resolve): Property has to have both
16694 2004-09-14 Martin Baulig <martin@ximian.com>
16696 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16698 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16701 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16702 called and is obsolete then this member suppress message
16703 when call is inside next [Obsolete] method or type.
16705 * expression.cs: Use TestObsoleteMethodUsage member.
16707 2004-09-14 Martin Baulig <martin@ximian.com>
16709 * cs-parser.jay: Sync a bit with the GMCS version.
16711 2004-09-14 Martin Baulig <martin@ximian.com>
16713 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16714 (CSharpParser.yacc_verbose_flag): New public field.
16716 * genericparser.cs: Removed.
16718 2004-09-14 Raja R Harinath <rharinath@novell.com>
16720 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16722 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16724 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16726 2004-09-10 Martin Baulig <martin@ximian.com>
16728 Backported my MemberName changes from GMCS into MCS.
16730 - we are now using a special `MemberName' class instead of using
16731 strings; in GMCS, the `MemberName' also contains the type
16734 - changed the grammar rules a bit:
16735 * the old `member_name' is now a `namespace_or_type_name':
16736 The rule is that we use `namespace_or_type_name' everywhere
16737 where we expect either a "member name" (GetEnumerator) or a
16738 "member name" with an explicit interface name
16739 (IEnumerable.GetEnumerator).
16740 In GMCS, the explicit interface name may include type arguments
16741 (IEnumerable<T>.GetEnumerator).
16742 * we use `member_name' instead of just `IDENTIFIER' for
16744 The rule is that we use `member_name' wherever a member may
16745 have type parameters in GMCS.
16747 * decl.cs (MemberName): New public class.
16748 (MemberCore.MemberName): New public readonly field.
16749 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16750 (DeclSpace): Likewise.
16752 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16753 * enum.cs (Enum.ctor): Likewise.
16755 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16757 (AliasEntry.ctor): Take a MemberName, not an Expression.
16758 (AliasEntry.UsingAlias): Likewise.
16760 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16761 (IMethodData.MemberName): Changed type from string to MemberName.
16762 (MemberBase.ExplicitInterfaceName): Likewise.
16763 (AbstractPropertyEventMethod.SetupName): Make this private.
16764 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16765 argument; compute the member name here.
16766 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16767 on the `member.MemberName' and the `prefix'.
16769 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16771 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16772 thus, we get a `MemberName' instead of a `string'. These
16773 declarations may have type parameters in GMCS.
16774 (interface_method_declaration, delegate_declaration): Likewise.
16775 (class_declaration, interface_declaration): Likewise.
16776 (method_header): Use `namespace_or_type_name' instead of
16777 `member_name'. We may be an explicit interface implementation.
16778 (property_declaration, event_declaration): Likewise.
16779 (member_name): This is now just an `IDENTIFIER', not a
16780 `namespace_or_type_name'.
16781 (type_name, interface_type): Removed.
16782 (namespace_or_type_name): Return a MemberName, not an Expression.
16783 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16784 call GetTypeExpression() on the MemberName to get an expression.
16785 (IndexerDeclaration.interface_type): Changed type from string to
16787 (MakeName): Operate on MemberName's instead of string's.
16789 2004-09-13 Raja R Harinath <rharinath@novell.com>
16792 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16793 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16794 lookup to avoid symbols introduced by 'using'.
16795 * rootcontext.cs (NamespaceLookup): Update.
16797 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16799 * class.cs (TypeContainer.DoDefineMembers): Do not call
16800 DefineDefaultConstructor for static classes.
16802 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16804 * attribute.cs (Attribute.Resolve): Add error 653 report.
16806 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16808 (Method.ApplyAttributeBuilder): Add error 685 report.
16809 (Operator.Define): Add error 564 report.
16811 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16813 * expression.cs (Invocation.DoResolve): Add error
16814 245 and 250 report.
16816 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16819 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16821 * class.cs (ConstructorInitializer.Resolve):
16822 Wrong error number (515->516).
16824 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16826 * class.cs (Indexer.Define): Add error 631 report.
16828 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16830 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16832 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16834 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16836 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16838 * cs-parser.jay: Added error CS0241 report.
16840 2004-09-10 Raja R Harinath <rharinath@novell.com>
16842 * cs-parser.jay (fixed_statement): Introduce a scope for the
16843 declaration in the 'fixed' statement.
16845 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16847 * cs-parser.jay: Added CS0230 error report.
16849 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16851 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16853 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16855 * expression.cs (Argument.Resolve): Added error CS0192 and
16858 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16860 C# 2.0 #pragma warning feature
16862 * cs-tokenizer.cs (PreProcessPragma): New method;
16863 Handles #pragma directive.
16865 * report.cs (WarningRegions): New class; Support
16866 class for #pragma warning directive. It tests whether
16867 warning is enabled for a given line.
16869 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16871 * const.cs: Add more descriptive error report, tahnks to
16874 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16876 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16878 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16880 * expression.cs: Apply patch from Ben: Remove dead code from
16881 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16882 as that code just threw an exception anwyays.
16884 * const.cs: Remove the call to the turnintoconstant, for details
16887 * literal.cs: The type of the null-literal is the null type; So
16888 we use a placeholder type (literal.cs:System.Null, defined here)
16891 * expression.cs (Conditional.DoResolve): Remove some old code that
16892 is no longer needed, conversions have been fixed.
16894 (ArrayCreationExpression.DoResolve): Return false if we fail to
16895 resolve the inner expression.
16897 2004-09-07 Raja R Harinath <rharinath@novell.com>
16900 * cs-parser.jay (delegate_declaration): Record a delegate
16901 declaration as a type declaration.
16902 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16904 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16906 * parameter.cs: Do not crash if the type can not be resolved.
16908 * expression.cs: Report errors with unsafe pointers, fixes #64896
16910 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16912 * expression.cs: Pointer arith always needs to do a conv.i
16913 if the operand is a long. fix 65320
16915 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16917 Fixed cs0619-37.cs, cs0619-38.cs
16919 * enum.cs (GetObsoleteAttribute): Removed.
16921 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16922 on Enum member is double staged. The first is tested member
16925 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16927 Fixed #56986, #63631, #65231
16929 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16930 adds member to name container.
16931 (TypeContainer.AddToTypeContainer): New method, adds type to
16933 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16934 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16935 AddOperator): Simplified by reusing AddToMemberContainer.
16936 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16938 (Method.CheckForDuplications): Fixed implementation to test all
16940 (MemberBase): Detection whether member is explicit interface
16941 implementation is now in constructor.
16942 (MemberBase.UpdateMemberName): Handles IndexerName.
16943 (Accessor): Changed to keep also location information.
16944 (AbstractPropertyEventMethod): Is derived from MemberCore.
16945 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16946 will be emited or not.
16947 (PropertyBase.AreAccessorsDuplicateImplementation):
16948 Tests whether accessors are not in collision with some method.
16949 (Operator): Is derived from MethodCore to simplify common
16952 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16954 (DeclSpace.AddToContainer): Adds the member to defined_names
16955 table. It tests for duplications and enclosing name conflicts.
16957 * enum.cs (EnumMember): Clean up to reuse the base structures
16959 2004-09-03 Martin Baulig <martin@ximian.com>
16961 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16962 into TypeContainer, to make partial classes work again.
16964 2004-09-03 Martin Baulig <martin@ximian.com>
16966 * rootcontext.cs (RootContext.V2): Removed.
16968 2004-03-23 Martin Baulig <martin@ximian.com>
16970 * expression.cs (Invocation.OverloadResolve): Added `bool
16971 may_fail' argument and use it instead of the Location.IsNull() hack.
16973 2004-09-03 Martin Baulig <martin@ximian.com>
16975 Merged latest changes into gmcs. Please keep this comment in
16976 here, it makes it easier for me to see what changed in MCS since
16977 the last time I merged.
16979 2004-09-03 Raja R Harinath <rharinath@novell.com>
16982 * expression.cs (BetterConversion): Don't allow either conversion
16983 to be null. Remove redundant implicit conversion test when 'q ==
16984 null' -- when this function is invoked, we already know that the
16985 implicit conversion exists.
16986 (BetterFunction): Assume that 'best' is non-null. Remove
16987 redundant reimplementation of IsApplicable when 'best' is null.
16988 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16989 number of arguments.
16990 (IsAncestralType): Extract from OverloadResolve.
16991 (OverloadResolve): Make robust to the MethodGroupExpr being
16992 unsorted. Implement all the logic of Section 14.5.5.1, and
16993 support overloading of methods from multiple applicable types.
16994 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16996 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16997 (RealError, Warning): Append type of report to related symbol.
16999 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17001 * enum.cs: Fixed CLS-Compliance checks for enum members.
17002 Error tests cs3008-8.cs, cs3014-8.cs
17004 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17006 Fixed bug #62342, #63102
17007 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17008 like ImplementMethod.
17010 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17012 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17015 2004-09-02 Martin Baulig <martin@ximian.com>
17017 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17018 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17021 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17023 C# 2.0 Static classes implemented
17025 * class.cs (TypeContainer): instance_constructors,
17026 initialized_fields, initialized_static_fields,
17027 default_constructor, base_inteface_types are protected to be
17028 accessible from StaticClass.
17029 (TypeContainer.DefineDefaultConstructor): New virtual method
17030 for custom default constructor generating
17031 (StaticClass): New class to handle "Static classes" feature.
17033 * cs-parser.jay: Handle static keyword on class like instance
17036 * driver.cs: Added "/langversion" command line switch with two
17037 options (iso-1, default).
17039 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17041 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17043 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17045 * delegate.cs: Style.
17047 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17049 * delegate.cs: Add seperate instance expr field for miguel.
17051 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17053 * PointerArithmetic (Resolve): make sure we are not doing
17054 pointer arith on void*. Also, make sure we are resolved
17055 by not setting eclass until resolve.
17057 All callers: Make sure that PointerArithmetic gets resolved.
17059 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17061 * ArrayCreation (LookupType): If the type does not resolve
17062 to an array, give an error.
17064 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17066 * statement.cs (Try.Resolve): Fixed bug #64222
17068 2004-08-27 Martin Baulig <martin@ximian.com>
17071 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17074 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17076 * ecore.cs (Constantify): Get underlying type via
17077 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17078 Windows in special cases.
17080 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17082 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17083 for obtaining also private methods.
17084 (GetRemoveMethod): Used GetRemoveMethod (true)
17085 for obtaining also private methods.
17087 2004-08-24 Martin Baulig <martin@ximian.com>
17089 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17090 MethodAttributes.HideBySig for operators.
17092 2004-08-23 Martin Baulig <martin@ximian.com>
17094 Back to the old error reporting system :-)
17096 * report.cs (Message): Removed.
17097 (Report.MessageData, ErrorData, WarningData): Removed.
17098 (Report.Error, Warning): Back to the old system.
17100 2004-08-23 Martin Baulig <martin@ximian.com>
17102 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17104 * class.cs (TypeContainer.ParentContainer): New public virtual
17105 method; replaces the explicit interface implementation.
17106 (ClassPart.ParentContainer): Override.
17108 2004-08-23 Martin Baulig <martin@ximian.com>
17110 * statement.cs (Switch): Added support for constant switches; see
17111 #59428 or test-285.cs.
17113 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17116 * statement.cs (GetEnumeratorFilter): Removed useless
17117 logic because C# specs is strict. GetEnumerator must be
17120 2004-08-22 Martin Baulig <martin@ximian.com>
17122 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17123 a switch and may break, reset the barrier. Fixes #59867.
17125 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17127 CLS-Compliance speed up (~5% for corlib)
17129 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17130 New method. Tests container for CLS-Compliant names
17132 * class.cs (TypeContainer.VerifyClsName): New method.
17133 Checks whether container name is CLS Compliant.
17134 (Constructor): Implements IMethodData.
17136 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17137 low-case table for CLS Compliance test.
17138 (MemberCache.VerifyClsParameterConflict): New method.
17139 Checks method parameters for CS3006 error.
17141 * enum.cs (EnumMember): Is derived from MemberCore.
17142 (Enum.VerifyClsName): Optimized for better performance.
17144 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17146 * report.cs: Renamed Error_T to Error and changed all
17149 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17151 * class.cs (TypeContainer.IndexerArrayList): New inner class
17152 container for indexers.
17153 (TypeContainer.DefaultIndexerName): New constant for default
17154 indexer name. Replaced all "Item" with this constant.
17155 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17157 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17158 DefaultMemberAttribute constructor.
17160 2004-08-05 Martin Baulig <martin@ximian.com>
17162 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17165 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17167 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17168 multi platforms problem.
17170 * compiler.csproj: Included shared files.
17172 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17174 Fix bug 60333, 55971 in the more general way
17175 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17176 Added arg_type argument for constant conversion.
17177 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17179 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17182 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17183 OperatorArrayList, MethodCoreArrayList for typecontainer
17184 containers. Changed class member types to these new types.
17185 (MethodArrayList.DefineMembers): Added test for CS0659.
17187 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17189 * cfold.cs: Synchronize the folding with the code in expression.cs
17190 Binary.DoNumericPromotions for uint operands.
17192 * attribute.cs: Revert patch from Raja, it introduced a regression
17193 while building Blam-1.2.1 (hard to isolate a test case).
17195 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17199 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17201 (MethodCore.parent_method): New member. The method we're overriding
17202 if this is an override method.
17203 (MethodCore.CheckBase): Moved from Method class and made common.
17204 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17206 (MethodCore.CheckForDuplications): New abstract method. For custom
17207 member duplication search in a container
17208 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17209 method and its return type.
17210 (Event.conflict_symbol): New member. Symbol with same name in the
17214 (MemberCache.FindMemberWithSameName): New method. The method
17215 is looking for conflict with inherited symbols.
17217 2004-08-04 Martin Baulig <martin@ximian.com>
17219 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17221 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17223 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17225 * report.cs (Message): New enum for better error, warning reference in
17227 (MessageData): New inner abstract class. It generally handles printing of
17228 error and warning messages.
17229 Removed unused Error, Warning, Message methods.
17231 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17233 Fix for cs0592-8.cs test
17235 (Attributable.ValidAttributeTargets): Made public.
17236 (Attribute.ExplicitTarget): New member for explicit target value.
17237 (Attribute.CheckTargets): Now we translate explicit attribute
17238 target to Target here.
17240 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17242 * ecore.cs (MethodGroupExpr): new IsBase property.
17244 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17246 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17247 rather than an instance expr.
17249 (DelegateCreation.Emit): Use the method group rather than
17250 the instance expression. Also, if you have base.Foo as the
17251 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17253 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17255 (NewDelegate.DoResolve): Only check for the existance of Invoke
17256 if the method is going to be needed. Use MethodGroupExpr.
17258 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17260 * expression.cs: For pointer arith., make sure to use
17261 the size of the type, not the size of the pointer to
17264 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17267 * class.cs (Class): Added error CS0502 test.
17269 2004-08-03 John Luke <jluke@cfl.rr.com>
17270 Raja R Harinath <rharinath@novell.com>
17273 * attribute.cs (Attribute.complained_before): New flag.
17274 (Attribute.ResolveType, Attribute.Resolve),
17275 (Attribute.DefinePInvokeMethod): Set it.
17276 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17278 2004-08-03 Martin Baulig <martin@ximian.com>
17280 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17281 use a user-defined operator; we still need to do numeric
17282 promotions in case one argument is a builtin type and the other
17283 one has an implicit conversion to that type. Fixes #62322.
17285 2004-08-02 Martin Baulig <martin@ximian.com>
17287 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17288 (LocalInfo.IsThis): New public property.
17289 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17291 2004-08-01 Martin Baulig <martin@ximian.com>
17293 * class.cs (TypeContainer.GetClassBases): Don't set the default
17294 here since we may get called from GetPartialBases().
17295 (TypeContainer.DefineType): If GetClassBases() didn't return a
17296 parent, use the default one.
17298 2004-07-30 Duncan Mak <duncan@ximian.com>
17300 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17302 2004-07-30 Martin Baulig <martin@ximian.com>
17304 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17306 * class.cs (SourceMethod): New public class, derive from the
17307 symbol writer's ISourceMethod.
17308 (Method): Use the new symbol writer API.
17310 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17311 as argument and use the new symbol writer.
17314 (SourceFile): Implement the symbol writer's ISourceFile.
17315 (Location.SymbolDocument): Removed.
17316 (Location.SourceFile): New public property.
17318 * symbolwriter.cs: Use the new symbol writer API.
17320 2004-07-30 Raja R Harinath <rharinath@novell.com>
17322 * Makefile (install-local): Remove. Functionality moved to
17325 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17327 * Makefile: Install mcs.exe.config file together with mcs.exe.
17328 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17329 correct runtime version.
17331 2004-07-25 Martin Baulig <martin@ximian.com>
17334 (TypeContainer.RegisterOrder): Removed, this was unused.
17335 (TypeContainer, interface_order): Removed.
17336 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17337 TypeContainer as argument since we can also be called with a
17338 `PartialContainer' for a partial class/struct/interface.
17339 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17340 of checking whether we're an `Interface' - we could be a
17341 `PartialContainer'.
17342 (PartialContainer.Register): Override; call
17343 AddClass()/AddStruct()/AddInterface() on our parent.
17345 * cs-parser.jay (interface_member_declaration): Add things to the
17346 `current_container', not the `current_class'.
17348 * rootcontext.cs (RegisterOrder): The overloaded version which
17349 takes an `Interface' was unused, removed.
17351 * typemanager.cs (TypeManager.LookupInterface): Return a
17352 `TypeContainer', not an `Interface'.
17353 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17354 contain a `PartialContainer' for an interface, so check it's
17355 `Kind' to figure out what it is.
17357 2004-07-25 Martin Baulig <martin@ximian.com>
17359 * class.cs (Class.DefaultTypeAttributes): New public constant.
17360 (Struct.DefaultTypeAttributes): Likewise.
17361 (Interface.DefaultTypeAttributes): Likewise.
17362 (PartialContainer.TypeAttr): Override this and add the
17363 DefaultTypeAttributes.
17365 2004-07-25 Martin Baulig <martin@ximian.com>
17367 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17368 we can just use the `Parent' field instead.
17370 2004-07-25 Martin Baulig <martin@ximian.com>
17372 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17374 2004-07-25 Martin Baulig <martin@ximian.com>
17376 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17377 our parts before defining any methods.
17378 (TypeContainer.VerifyImplements): Make this virtual.
17379 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17380 on our PartialContainer.
17382 2004-07-25 Martin Baulig <martin@ximian.com>
17384 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17386 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17387 argument, we can just use the `Parent' field instead.
17390 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17391 (MemberBase.DoDefine): Likewise.
17393 2004-07-24 Martin Baulig <martin@ximian.com>
17395 * decl.cs (MemberCore.Parent): New public field.
17396 (DeclSpace.Parent): Moved to MemberCore.
17398 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17399 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17401 (FieldBase, Field, Operator): Likewise.
17402 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17403 (EventField, Event): Likewise.
17405 2004-07-23 Martin Baulig <martin@ximian.com>
17407 * class.cs (PartialContainer): New public class.
17408 (ClassPart): New public class.
17409 (TypeContainer): Added support for partial classes.
17410 (TypeContainer.GetClassBases): Splitted some of the functionality
17411 out into GetNormalBases() and GetPartialBases().
17413 * cs-tokenizer.cs (Token.PARTIAL): New token.
17414 (Tokenizer.consume_identifier): Added some hacks to recognize
17415 `partial', but only if it's immediately followed by `class',
17416 `struct' or `interface'.
17418 * cs-parser.jay: Added support for partial clases.
17420 2004-07-23 Martin Baulig <martin@ximian.com>
17422 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17423 a `DeclSpace' and also made it readonly.
17424 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17425 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17426 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17428 * cs-parser.jay: Pass the `current_class', not the
17429 `current_container' (at the moment, this is still the same thing)
17430 to a new Method, Property, Event, Indexer or Constructor.
17432 2004-07-23 Martin Baulig <martin@ximian.com>
17434 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17435 and removed the `current_interface' one.
17436 (struct_declaration, class_declaration, interface_declaration):
17437 Set `current_class' to the newly created class/struct/interface;
17438 set their `Bases' and call Register() before parsing their body.
17440 2004-07-23 Martin Baulig <martin@ximian.com>
17442 * class.cs (Kind): New public enum.
17443 (TypeContainer): Made this class abstract.
17444 (TypeContainer.Kind): New public readonly field.
17445 (TypeContainer.CheckDef): New public method; moved here from
17447 (TypeContainer.Register): New public abstract method.
17448 (TypeContainer.GetPendingImplementations): New public abstract
17450 (TypeContainer.GetClassBases): Removed the `is_class' and
17451 `is_iface' parameters.
17452 (TypeContainer.DefineNestedTypes): Formerly known as
17454 (ClassOrStruct): Made this class abstract.
17456 * tree.cs (RootTypes): New public type.
17458 2004-07-20 Martin Baulig <martin@ximian.com>
17460 * tree.cs (Tree.RecordNamespace): Removed.
17461 (Tree.Namespaces): Removed.
17463 * rootcontext.cs (RootContext.IsNamespace): Removed.
17465 * cs-parser.jay (namespace_declaration): Just create a new
17466 NamespaceEntry here.
17468 2004-07-20 Martin Baulig <martin@ximian.com>
17470 * statement.cs (ExceptionStatement): New abstract class. This is
17471 now used as a base class for everyone who's using `finally'.
17472 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17473 our local variables before using them.
17475 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17476 virtual method. This is used by Yield.Resolve() to "steal" an
17477 outer block's `finally' clauses.
17478 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17481 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17482 version which takes an ExceptionStatement. This version must be
17483 used to create exception branchings.
17486 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17487 (Iterator.EmitMoveNext): Added exception support; protect the
17488 block with a `fault' clause, properly handle 'finally' clauses.
17489 (Iterator.EmitDispose): Run all the `finally' clauses here.
17491 2004-07-20 Martin Baulig <martin@ximian.com>
17493 * iterator.cs: This is the first of a set of changes in the
17494 iterator code. Match the spec more closely: if we're an
17495 IEnumerable, then GetEnumerator() must be called. The first time
17496 GetEnumerator() is called, it returns the current instance; all
17497 subsequent invocations (if any) must create a copy.
17499 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17501 * expression.cs: Resolve the constant expression before returning
17504 2004-07-19 Martin Baulig <martin@ximian.com>
17506 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17507 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17508 the return type of the new EmitContext.
17510 2004-07-18 Martin Baulig <martin@ximian.com>
17512 * class.cs (Property.Define): Fix iterators.
17514 * iterators.cs (Iterator.Define): Moved the
17515 `container.AddInterator (this)' call here from the .ctor; only do
17516 it if we resolved successfully.
17518 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17520 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17521 `true' for preprocessing directives that we parse. The return
17522 value indicates whether we should return to regular tokenizing or
17523 not, not whether it was parsed successfully.
17525 In the past if we were in: #if false ... #line #endif, we would
17526 resume parsing after `#line'. See bug 61604.
17528 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17529 building: IsEnumType should return true only for enums, not for
17530 enums or System.Enum itself. This fixes #61593.
17532 Likely what happened is that corlib was wrong: mcs depended on
17533 this bug in some places. The bug got fixed, we had to add the
17534 hack, which caused bug 61593.
17536 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17537 that was a workaround for the older conditions.
17539 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17541 * assign.cs: IAssignMethod has a new interface, as documented
17542 inline. All assignment code now uses this new api.
17544 * ecore.cs, expression.cs: All classes which implement
17545 IAssignMethod now use the new interface.
17547 * expression.cs (Invocation): add a hack to EmitCall so that
17548 IndexerAccess can be the target of a compound assignment without
17549 evaluating its arguments twice.
17551 * statement.cs: Handle changes in Invocation api.
17553 2004-07-16 Martin Baulig <martin@ximian.com>
17555 * iterators.cs: Rewrote this. We're now using one single Proxy
17556 class for both the IEnumerable and the IEnumerator interface and
17557 `Iterator' derives from Class so we can use the high-level API.
17559 * class.cs (TypeContainer.AddIterator): New method.
17560 (TypeContainer.DoDefineType): New protected virtual method, which
17561 is called from DefineType().
17562 (TypeContainer.DoDefineMembers): Call DefineType() and
17563 DefineMembers() on all our iterators.
17564 (TypeContainer.Emit): Call Emit() on all our iterators.
17565 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17567 * codegen.cs (EmitContext.CurrentIterator): New public field.
17569 2004-07-15 Martin Baulig <martin@ximian.com>
17572 (TypeManager.not_supported_exception_type): New type.
17574 2004-07-14 Martin Baulig <martin@ximian.com>
17576 * iterators.cs: Use real error numbers.
17578 2004-07-14 Martin Baulig <martin@ximian.com>
17580 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17581 requires this to be a System.Collection.IEnumerable and not a
17582 class implementing that interface.
17583 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17585 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17587 * class.cs: Fixed previous fix, it broke some error tests.
17589 2004-07-12 Martin Baulig <martin@ximian.com>
17591 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17594 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17596 * assign.cs (LocalTemporary): Add new argument: is_address,If
17597 `is_address' is true, then the value that we store is the address
17598 to the real value, and not the value itself.
17600 * ecore.cs (PropertyExpr): use the new local temporary
17601 stuff to allow us to handle X.Y += z (where X is a struct)
17603 2004-07-08 Martin Baulig <martin@ximian.com>
17605 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17606 not always return, just like we're doing in Using.Resolve().
17608 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17610 * cs-parser.jay (fixed_statement): flag this as Pinned.
17612 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17614 * typemanager.cs (TypeManager): Removed MakePinned method, this
17615 mechanism is replaced with the .NET 2.x compatible mechanism of
17616 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17618 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17619 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17620 `IsFixed' property which has a different meaning.
17622 2004-07-02 Raja R Harinath <rharinath@novell.com>
17624 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17625 visible from inside a nested class, not just the names of the
17626 immediately enclosing class.
17627 Fix for bug #60730.
17629 2004-06-24 Raja R Harinath <rharinath@novell.com>
17631 * expression.cs (BetterConversion): Remove buggy special-case
17632 handling of "implicit constant expression conversions". At this
17633 point, we already know that the conversion is possible -- we're
17634 only checking to see which is better.
17636 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17638 * cs-parser.jay: Added error CS0210 test.
17640 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17642 * cs-parser.jay: Added error CS0134 test.
17644 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17647 * cs-parser.jay: Added error CS0145 test.
17649 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17651 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17653 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17655 * expression.cs (StackAlloc.Resolve): The argument may not
17656 be a constant; deal with this case.
17658 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17660 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17661 GetIndexerAttributeValue.
17662 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17664 * class.cs (Indexer.Define): Added error tests for CS0415,
17667 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17669 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17672 2004-06-23 Martin Baulig <martin@ximian.com>
17674 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17675 neither return nor throw, reset the barrier as well. Fixes #60457.
17677 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17679 * class.cs : EventAttributes is now set to None by default.
17680 This fixes bug #60459.
17682 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17685 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17686 Don't throw exception but return null (it's sufficient now).
17688 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17690 * typemanager.cs (GetArgumentTypes): Faster implementation.
17692 2004-06-18 Martin Baulig <martin@ximian.com>
17694 * attribute.cs (Attribute.Resolve): Check whether we're an
17695 EmptyCast which a Constant child. Fixes #60333.
17697 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17699 * statement.cs (EmitCollectionForeach): Account for the fact that
17700 not all valuetypes are in areas which we can take the address of.
17701 For these variables, we store to a temporary variable. Also, make
17702 sure that we dont emit a `callvirt' on a valuetype method.
17704 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17706 * expression.cs (StackAlloc.DoReSolve): Added test for
17707 negative parameter (CS0247).
17709 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17712 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17714 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17717 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17720 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17722 Fix bug #58254 & cs1555.cs, cs1556.cs
17723 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17725 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17727 * cs-parser.jay: Added error CS1669 test for indexers.
17729 2004-06-11 Martin Baulig <martin@ximian.com>
17731 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17732 call this twice: for params and varargs methods.
17734 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17737 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17739 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17741 * attribute.cs (Attribute.GetValidTargets): Made public.
17744 (AbstractPropertyEventMethod): New class for better code sharing.
17745 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17747 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17749 2004-06-11 Raja R Harinath <rharinath@novell.com>
17752 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17753 that the call to Resolve is part of a MemberAccess.
17754 (Expression.Resolve): Use it for SimpleName resolution.
17755 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17756 Add 'intermediate' boolean argument.
17757 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17758 error message when the SimpleName can be resolved ambiguously
17759 between an expression and a type.
17760 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17762 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17763 call on the left-side.
17765 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17768 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17770 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17772 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17774 2004-06-11 Martin Baulig <martin@ximian.com>
17776 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17777 varargs methods if applicable.
17779 2004-06-11 Martin Baulig <martin@ximian.com>
17781 * expression.cs (Invocation.EmitCall): Don't use
17782 `method.CallingConvention == CallingConventions.VarArgs' since the
17783 method could also have `CallingConventions.HasThis'.
17785 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17787 * class.cs (Event.GetSignatureForError): Implemented.
17788 Fixed crash in error test cs3010.cs
17790 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17792 * cs-tokenizer.cs: Change the way we track __arglist to be
17793 consistent with the other keywords.
17795 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17797 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17800 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17802 * codegen.cs: Check that all referenced assemblies have a strongname
17803 before strongnaming the compiled assembly. If not report error CS1577.
17804 Fix bug #56563. Patch by Jackson Harper.
17805 * typemanager.cs: Added a method to return all referenced assemblies.
17806 Fix bug #56563. Patch by Jackson Harper.
17808 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17811 (Method.ApplyAttributeBuilder): Moved and added conditional
17812 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17815 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17817 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17820 * class.cs: (EventField.attribute_targets): Changed default target.
17822 2004-06-08 Martin Baulig <martin@ximian.com>
17824 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17826 2004-06-08 Martin Baulig <martin@ximian.com>
17828 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17830 2004-06-07 Martin Baulig <martin@ximian.com>
17832 Added support for varargs methods.
17834 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17837 * cs-parser.jay: Added support for `__arglist'.
17839 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17841 * expression.cs (Argument.AType): Added `ArgList'.
17842 (Invocation): Added support for varargs methods.
17843 (ArglistAccess): New public class.
17844 (Arglist): New public class.
17846 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17848 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17849 a method's top-level block if the method has varargs.
17851 * support.cs (ReflectionParameters, InternalParameters): Added
17852 support for varargs methods.
17854 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17856 * class.cs: Provide location in indexer error report.
17858 * driver.cs: Use standard names.
17860 * namespace.cs: Catch the use of using after a namespace has been
17861 declared also on using aliases.
17863 2004-06-03 Raja R Harinath <rharinath@novell.com>
17866 * typemanager.cs (closure_private_ok, closure_invocation_type)
17867 (closure_qualifier_type, closure_invocation_assembly)
17868 (FilterWithClosure): Move to ...
17869 (Closure): New internal nested class.
17870 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17871 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17872 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17873 (MemberLookup, MemberLookupFailed): Use it.
17874 * expression.cs (New.DoResolve): Treat the lookup for the
17875 constructor as being qualified by the 'new'ed type.
17876 (Indexers.GetIndexersForTypeOrInterface): Update.
17878 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17881 (GetConditionalAttributeValue): New method. Returns
17882 condition of ConditionalAttribute.
17883 (SearchMulti): New method. Returns all attributes of type 't'.
17884 Use it when attribute is AllowMultiple = true.
17885 (IsConditionalMethodExcluded): New method.
17888 (Method.IsExcluded): Implemented. Returns true if method has conditional
17889 attribute and the conditions is not defined (method is excluded).
17890 (IMethodData): Extended interface for ConditionalAttribute support.
17891 (PropertyMethod.IsExcluded): Implemented.
17894 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17897 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17900 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17902 * expression.cs (ArrayCreationExpression): Make this just an
17903 `expression'. It can't be a statement, so the code here was
17906 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17909 * typemanager.cs (GetFullNameSignature): New method for
17912 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17915 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17916 Use this method when MethodBuilder is null.
17917 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17918 Added test for error CS0626 (MONO reports error for this situation).
17919 (IMethodData.GetSignatureForError): Extended interface.
17921 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17924 (AttributeTester.GetObsoleteAttribute): Returns instance of
17925 ObsoleteAttribute when type is obsolete.
17928 (TypeContainer.VerifyObsoleteAttribute): Override.
17929 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17930 (MethodCode.VerifyObsoleteAttribute): Override.
17931 (MemberBase.VerifyObsoleteAttribute): Override.
17934 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17935 and report proper error.
17938 Delegate.VerifyObsoleteAttribute): Override.
17941 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17942 and report proper error.
17943 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17946 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17950 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17951 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17952 Added test for ObsoleteAttribute.
17955 (Catch): Derived from Statement.
17957 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17959 Fixed bug #59071 & cs0160.cs
17961 * statement.cs (Try.Resolve): Check here whether order of catch
17962 clauses matches their dependencies.
17964 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17966 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17967 caused a regression: #59343. Referencing nested classes from an
17968 assembly stopped working.
17970 2004-05-31 Martin Baulig <martin@ximian.com>
17972 MCS is now frozen for beta 2.
17974 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17976 * convert.cs: add a trivial cache for overload operator resolution.
17978 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17980 * decl.cs: If possible, use lookuptypedirect here. We can only do
17981 this if there is no `.' after the namespace. Avoids using
17982 LookupType, which does lots of slow processing.
17983 (FindNestedType) New method, does what it says :-).
17984 * namespace.cs: use LookupTypeDirect.
17985 * rootcontext.cs: use membercache, if possible.
17986 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17988 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17991 According to the spec,
17993 In a member access of the form E.I, if E is a single identifier,
17994 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17995 field, property, localvariable, or parameter with the same type as
17996 the meaning of E as a type-name (§3.8), then both possible
17997 meanings of E are permitted.
17999 We did not check that E as a simple-name had the same type as E as
18002 This trivial check gives us 5-7% on bootstrap time.
18004 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18006 * expression.cs (Invocation.OverloadResolve): Avoid the
18007 use of hashtables and boxing here by allocating on demand.
18009 2004-05-30 Martin Baulig <martin@ximian.com>
18011 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18012 we're doing a silent lookup. Don't try to lookup nested types in
18013 TypeManager.object_type (thanks to Ben Maurer).
18015 2004-05-30 Martin Baulig <martin@ximian.com>
18017 Committing a patch from Ben Maurer.
18019 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18021 2004-05-29 Martin Baulig <martin@ximian.com>
18023 * class.cs (IMethodData.ShouldIgnore): New method.
18025 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18026 `Location' argument, we don't need it anywhere. Use
18027 `IMethodData.ShouldIgnore ()' instead of
18028 `MethodData.GetMethodFlags ()'.
18029 (TypeManager.AddMethod): Removed.
18030 (TypeManager.AddMethod2): Renamed to AddMethod.
18032 2004-05-29 Martin Baulig <martin@ximian.com>
18034 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18036 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18037 converting from a class type S to an interface type and we already
18038 have an object on the stack, don't box it again. Fixes #52578.
18040 2004-05-29 Martin Baulig <martin@ximian.com>
18042 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18043 Added support for `params' parameters. Fixes #59267.
18045 2004-05-29 Martin Baulig <martin@ximian.com>
18047 * literal.cs (NullPointer): Provide a private .ctor which sets
18048 `type' to TypeManager.object_type. Fixes #59048.
18050 2004-05-29 Martin Baulig <martin@ximian.com>
18052 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18053 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18055 * ecore.cs (EventExpr.instance_expr): Make the field private.
18057 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18059 Fixed bug #50080 & cs0214-2.cs
18060 * expression.cs (Cast.DoResolve): Check unsafe context here.
18062 * statement.cs (Resolve.DoResolve): Likewise.
18064 2004-05-26 Martin Baulig <martin@ximian.com>
18066 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18068 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18069 (RootContext.LookupType): Pass down the `silent' flag.
18071 2004-05-25 Martin Baulig <martin@ximian.com>
18074 (MethodGroupExpr.IdenticalTypeName): New public property.
18075 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18076 expression actually refers to a type.
18078 2004-05-25 Martin Baulig <martin@ximian.com>
18080 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18081 for #56176 and made it actually work.
18083 2004-05-25 Martin Baulig <martin@ximian.com>
18085 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18086 (FieldExpr, PropertyExpr): Override and implement
18087 CacheTemporaries. Fixes #52279.
18089 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18091 * location.cs: In the new compiler listing a file twice is a
18092 warning, not an error.
18094 2004-05-24 Martin Baulig <martin@ximian.com>
18096 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18097 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18099 2004-05-24 Martin Baulig <martin@ximian.com>
18101 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18102 walking the `using' list. Fixes #53921.
18104 2004-05-24 Martin Baulig <martin@ximian.com>
18106 * const.cs (Const.LookupConstantValue): Added support for
18107 EmptyCast's; fixes #55251.
18109 2004-05-24 Martin Baulig <martin@ximian.com>
18111 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18112 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18113 which does the CS0135 check. The reason is that we first need to
18114 check whether the variable actually exists.
18116 2004-05-24 Martin Baulig <martin@ximian.com>
18118 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18119 than RootContext.LookupType() to find the explicit interface
18120 type. Fixes #58584.
18122 2004-05-24 Raja R Harinath <rharinath@novell.com>
18124 * Makefile: Simplify. Use executable.make.
18125 * mcs.exe.sources: New file. List of sources of mcs.exe.
18127 2004-05-24 Anders Carlsson <andersca@gnome.org>
18131 Use the invariant culture when doing String.Compare for CLS case
18134 2004-05-23 Martin Baulig <martin@ximian.com>
18136 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18137 don't have any dots. Fixes #52622, added cs0246-8.cs.
18139 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18141 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18143 * class.cs (MemberBase.Define): Reuse MemberType member for
18144 resolved type. Other methods can use it too.
18146 2004-05-23 Martin Baulig <martin@ximian.com>
18148 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18149 the variable also exists in the current block (otherwise, we need
18150 to report a CS0103). Fixes #58670.
18152 2004-05-23 Martin Baulig <martin@ximian.com>
18154 * flowanalysis.cs (Reachability.Reachable): Compute this
18155 on-the-fly rather than storing it as a field.
18157 2004-05-23 Martin Baulig <martin@ximian.com>
18159 * flowanalysis.cs (Reachability.And): Manually compute the
18160 resulting `barrier' from the reachability.
18162 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18165 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18166 instance of ObsoleteAttribute when symbol is obsolete.
18169 (IMethodData): Extended interface for ObsoleteAttribute support.
18171 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18173 * attribute.cs: Fix bug #55970
18175 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18179 (GetObsoleteAttribute): New method. Creates the instance of
18181 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18182 ObsoleteAttribute when member is obsolete.
18183 (AttributeTester.Report_ObsoleteMessage): Common method for
18184 Obsolete error/warning reporting.
18187 (TypeContainer.base_classs_type): New member for storing parent type.
18190 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18191 for this MemberCore.
18193 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18195 * attribute.cs, const.cs: Fix bug #58590
18197 2004-05-21 Martin Baulig <martin@ximian.com>
18199 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18200 out parameters if the end of the method is unreachable. Fixes
18203 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18205 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18206 Hari was right, why extra method.
18208 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18210 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18212 2004-05-20 Martin Baulig <martin@ximian.com>
18214 Merged this back from gmcs to keep the differences to a minumum.
18216 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18217 instead of a Declspace.
18218 (Attribute.ResolveType): Likewise.
18219 (Attributes.Search): Likewise.
18220 (Attributes.Contains): Likewise.
18221 (Attributes.GetClsCompliantAttribute): Likewise.
18223 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18225 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18228 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18230 Fix bug #58688 (MCS does not report error when the same attribute
18233 * attribute.cs (Attribute.Emit): Distinction between null and default.
18235 2004-05-19 Raja R Harinath <rharinath@novell.com>
18237 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18238 of a top-level attribute without an attribute target.
18239 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18241 (Attribute.Conditional_GetConditionName),
18242 (Attribute.Obsolete_GetObsoleteMessage): Update.
18243 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18244 part of ScanForIndexerName.
18245 (Attribute.CanIgnoreInvalidAttribute): New function.
18246 (Attribute.ScanForIndexerName): Move to ...
18247 (Attributes.ScanForIndexerName): ... here.
18248 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18249 (Attributes.Search): New internal variant that can choose not to
18250 complain if types aren't resolved. The original signature now
18252 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18253 complaints suppressed.
18254 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18255 only if it not useful.
18256 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18257 top-level for attributes that are shared between the assembly
18258 and a top-level class.
18259 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18260 * class.cs: Update to reflect changes.
18261 (DefineIndexers): Fuse loops.
18262 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18263 a couple more variants of attribute names.
18265 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18267 Fix bug #52585 (Implemented explicit attribute declaration)
18270 (Attributable.ValidAttributeTargets): New abstract method. It gets
18271 list of valid attribute targets for explicit target declaration.
18272 (Attribute.Target): It holds target itself.
18273 (AttributeSection): Removed.
18274 (Attribute.CheckTargets): New method. It checks whether attribute
18275 target is valid for the current element.
18278 (EventProperty): New class. For events that are declared like
18279 property (with add and remove accessors).
18280 (EventField): New class. For events that are declared like field.
18283 * cs-parser.jay: Implemented explicit attribute target declaration.
18285 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18286 Override ValidAttributeTargets.
18289 (ReturnParameter): Class for applying custom attributes on
18291 (ParameterAtribute): New class. Class for applying custom
18292 attributes on the parameter type.
18294 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18296 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18299 (Method): Allow UNSAFE here.
18301 * modifiers.cs: Support unsafe reporting.
18303 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18305 * decl.cs: Fix bug #58478.
18307 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18309 * statement.cs: When checking for unreachable code on an EmptyStatement,
18310 set the location. Fixes bug #58488.
18312 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18314 * driver.cs: Add -pkg handling.
18316 From Gonzalo: UseShelLExecute=false
18318 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18321 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18323 (Attribute.IsClsCompliaceRequired): Moved to base for better
18325 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18326 when attribute is AttributeUsageAttribute.
18327 (Attribute.GetValidTargets): Simplified.
18328 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18329 attribute for this type.
18330 (Attribute.ApplyAttributes): Method renamed to Emit and make
18332 (GlobalAttributeSection): New class for special handling of global
18333 attributes (assembly, module).
18334 (AttributeSection.Emit): New method.
18336 * class.cs: Implemented Attributable abstract methods.
18337 (MethodCore.LabelParameters): Moved to Parameter class.
18338 (Accessor): Is back simple class.
18339 (PropertyMethod): Implemented Attributable abstract class.
18340 (DelegateMethod): Implemented Attributable abstract class.
18341 (Event): New constructor for disctintion between normal Event
18342 and Event with accessors.
18344 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18346 * codegen.cs, const.cs, decl.cs, delegate.cs:
18347 (CommonAssemblyModulClass): Implemented Attributable abstract class
18350 * enum.cs: Implement IAttributeSupport interface.
18351 (EnumMember): New class for emum members. Implemented Attributable
18355 (ParameterBase): Is abstract.
18356 (ReturnParameter): New class for easier [return:] attribute handling.
18358 * typemanager.cs: Removed builder_to_attr.
18360 2004-05-11 Raja R Harinath <rharinath@novell.com>
18363 * attribute.cs (Attribute.GetPositionalValue): New function.
18364 * class.cs (TypeContainer.VerifyMembers): New function.
18365 (TypeContainer.Emit): Use it.
18366 (ClassOrStruct): New base class for Class and Struct.
18367 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18368 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18370 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18371 then each non-static field should have a FieldOffset attribute.
18372 Otherwise, none of the fields should have a FieldOffset attribute.
18373 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18374 and FieldOffset attributes.
18375 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18376 (TypeManager.field_offset_attribute_type): New core types.
18377 (TypeManager.InitCoreTypes): Initialize them.
18379 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18381 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18382 Return correct type.
18385 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18387 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18388 be implicitly converted to ulong.
18390 * expression.cs: The logic for allowing operator &, | and ^ worked
18391 was wrong, it worked before because we did not report an error in
18392 an else branch. Fixes 57895.
18394 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18395 allow volatile fields to be reference types.
18397 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18399 * driver.cs: Add support for /debug-
18401 2004-05-07 Raja R Harinath <rharinath@novell.com>
18403 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18404 Add a 'complain' parameter to silence errors.
18405 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18406 silently overlooked type-resolutions.
18407 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18408 to reflect changes.
18409 (Attributes.Search): New function.
18410 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18411 (Attributes.GetAttributeFullName): Remove hack.
18412 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18413 Update to reflect changes.
18414 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18415 Use Attributes.Search instead of nested loops.
18417 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18420 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18421 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18422 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18424 * report.cs: (Report.Warning): Renamed to Warning_T because of
18425 parameter collision.
18427 2004-05-05 Raja R Harinath <rharinath@novell.com>
18429 * expression.cs (MemberAccess.ResolveMemberAccess):
18430 Exit with non-zero status after Report.Error.
18431 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18433 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18435 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18437 * support.cs: Don't hang when the file is empty.
18439 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18441 * support.cs: In SeekableStreamReader, compute the preamble size of the
18442 underlying stream. Position changes should take into account that initial
18445 2004-05-03 Todd Berman <tberman@sevenl.net>
18447 * driver.cs: remove unused GetSysVersion function.
18449 2004-05-03 Todd Berman <tberman@sevenl.net>
18451 * driver.cs: Remove the hack from saturday, as well as the hack
18452 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18453 link_paths to get that bit proper.
18455 2004-05-01 Todd Berman <tberman@sevenl.net>
18457 * driver.cs: Try a LoadFrom before a Load, this checks the current
18458 path. This is currently a bug in mono that is be fixed, however, this
18459 provides a workaround for now. This will be removed when the bug
18462 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18464 * CryptoConvert.cs: Updated to latest version. Fix issue with
18465 incomplete key pairs (#57941).
18467 2004-05-01 Todd Berman <tberman@sevenl.net>
18469 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18472 2004-04-30 Jackson Harper <jackson@ximian.com>
18474 * codegen.cs: Open keys readonly.
18476 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18478 * typemanager.cs: don't report cyclic struct layout when a struct
18479 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18480 which has 2 Pango.Rectangle fields.
18482 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18484 * expression.cs: Handle IntPtr comparisons with IL code
18485 rather than a method call.
18487 2004-04-29 Martin Baulig <martin@ximian.com>
18489 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18490 the list of PropertyInfo's in class hierarchy and find the
18491 accessor. Fixes #56013.
18493 2004-04-29 Martin Baulig <martin@ximian.com>
18495 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18497 2004-04-29 Martin Baulig <martin@ximian.com>
18499 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18501 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18503 2004-04-29 Martin Baulig <martin@ximian.com>
18505 * class.cs (ConstructorInitializer.Resolve): Check whether the
18506 parent .ctor is accessible. Fixes #52146.
18508 2004-04-29 Martin Baulig <martin@ximian.com>
18510 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18512 * statement.cs (Using.EmitLocalVariableDecls): Use
18513 TypeManager.idisposable_type, not typeof (IDisposable).
18514 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18516 2004-04-29 Martin Baulig <martin@ximian.com>
18518 * class.cs (Event.Define): Don't emit the field and don't set
18519 RTSpecialName and SpecialName for events on interfaces. Fixes
18522 2004-04-29 Raja R Harinath <rharinath@novell.com>
18524 Refactor Attribute.ApplyAttributes.
18525 * attribute.cs (Attributable): New base class for objects that can
18526 have Attributes applied on them.
18527 (Attribute): Make AttributeUsage fields public.
18528 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18529 (Attribute.IsInternalCall): New property.
18530 (Attribute.UsageAttr): Convert to a public read-only property.
18531 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18532 (Attribute.ResolveType, Attribute.Resolve)
18533 (Attribute.ScanForIndexerName): Update to reflect changes.
18534 (Attribute.CheckAttributeTarget): Re-format.
18535 (Attribute.ApplyAttributes): Refactor, to various
18536 Attributable.ApplyAttributeBuilder methods.
18537 * decl.cs (MemberCore): Make Attributable.
18538 * class.cs (Accessor): Make Attributable.
18539 (MethodData.ApplyAttributes): Use proper attribute types, not
18541 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18542 (TypeContainer.ApplyAttributeBuilder)
18543 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18544 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18545 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18546 (Operator.ApplyAttributeBuilder): New factored-out methods.
18547 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18548 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18549 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18550 * parameter.cs (ParameterBase): New Attributable base class
18551 that can also represent Return types.
18552 (Parameter): Update to the changes.
18554 2004-04-29 Jackson Harper <jackson@ximian.com>
18556 * driver.cs: Prefer the corlib system version when looking for
18557 assemblies in the GAC. This is still a hack, but its a better hack
18560 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18562 * decl.cs, enum.cs: Improved error 3005 reporting.
18564 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18565 (related_symbols): New private member for list of symbols
18566 related to reported error/warning.
18568 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18570 2004-04-29 Martin Baulig <martin@ximian.com>
18572 * ecore.cs (Expression.Constantify): If we're an enum and
18573 TypeManager.TypeToCoreType() doesn't give us another type, use
18574 t.UnderlyingSystemType. Fixes #56178.
18576 2004-04-29 Martin Baulig <martin@ximian.com>
18578 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18579 interfaces and for each interface, only add members directly
18580 declared in that interface. Fixes #53255.
18582 2004-04-28 Martin Baulig <martin@ximian.com>
18584 * expression.cs (ConditionalLogicalOperator): Use a temporary
18585 variable for `left' to avoid that we evaluate it more than once;
18588 2004-04-28 Martin Baulig <martin@ximian.com>
18590 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18593 2004-04-28 Martin Baulig <martin@ximian.com>
18595 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18598 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18599 whether the type is not void (CS1547).
18601 2004-04-28 Martin Baulig <martin@ximian.com>
18603 * expression.cs (Unary.DoResolveLValue): Override this and report
18604 CS0131 for anything but Operator.Indirection.
18606 2004-04-28 Martin Baulig <martin@ximian.com>
18608 Committing a patch from Ben Maurer; see bug #50820.
18610 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18613 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18616 2004-04-28 Martin Baulig <martin@ximian.com>
18618 Committing a patch from Ben Maurer; see bug #50820.
18620 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18623 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18626 2004-04-28 Martin Baulig <martin@ximian.com>
18628 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18629 (Block.AddLabel): Call DoLookupLabel() to only search in the
18632 2004-04-28 Martin Baulig <martin@ximian.com>
18634 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18635 comparing StringConstants and NullLiterals in Equality and Inequality.
18637 2004-04-28 Jackson Harper <jackson@ximian.com>
18639 * driver.cs: Attempt to load referenced assemblies from the
18640 GAC. This is the quick and dirty version of this method that
18641 doesnt take into account versions and just takes the first
18642 canidate found. Will be good enough for now as we will not have more
18643 then one version installed into the GAC until I update this method.
18645 2004-04-28 Martin Baulig <martin@ximian.com>
18647 * typemanager.cs (TypeManager.CheckStructCycles): New public
18648 static method to check for cycles in the struct layout.
18650 * rootcontext.cs (RootContext.PopulateTypes): Call
18651 TypeManager.CheckStructCycles() for each TypeContainer.
18652 [Note: We only need to visit each type once.]
18654 2004-04-28 Martin Baulig <martin@ximian.com>
18656 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18658 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18659 success and added `out object value'. Use a `bool resolved' field
18660 to check whether we've already been called rather than
18661 `ConstantValue != null' since this breaks for NullLiterals.
18663 2004-04-28 Raja R Harinath <rharinath@novell.com>
18665 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18666 setting of this flag, since the 'set' method may be non-public.
18668 2004-04-28 Raja R Harinath <rharinath@novell.com>
18670 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18671 check on current_vector.Block.
18673 2004-04-27 Martin Baulig <martin@ximian.com>
18675 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18676 a field initializer. Fixes #56459.
18678 2004-04-27 Martin Baulig <martin@ximian.com>
18680 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18681 we're not attempting to use an indexer. Fixes #52154.
18683 2004-04-27 Martin Baulig <martin@ximian.com>
18685 * statement.cs (Return): Don't create a return label if we don't
18686 need it; reverts my change from January 20th. Thanks to Ben
18689 2004-04-27 Martin Baulig <martin@ximian.com>
18691 According to the spec, `goto' can only leave a nested scope, but
18694 * statement.cs (Block.LookupLabel): Only lookup in the current
18695 block, don't recurse into parent or child blocks.
18696 (Block.AddLabel): Check in parent and child blocks, report
18697 CS0140/CS0158 if we find a duplicate.
18698 (Block): Removed this indexer for label lookups.
18699 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18700 this already does the error reporting for us.
18703 (FlowBranching.UsageVector.Block): New public variable; may be null.
18704 (FlowBranching.CreateSibling): Added `Block' argument.
18705 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18706 label for the target of a `goto' and check whether we're not
18707 leaving a `finally'.
18709 2004-04-27 Martin Baulig <martin@ximian.com>
18711 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18712 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18715 2004-04-27 Martin Baulig <martin@ximian.com>
18717 * statement.cs (Block.AddLabel): Also check for implicit blocks
18718 and added a CS0158 check.
18720 2004-04-27 Martin Baulig <martin@ximian.com>
18722 * flowanalysis.cs (FlowBranchingLoop): New class.
18723 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18724 UsageVector's instead of an ArrayList.
18725 (FlowBranching.Label): Likewise.
18726 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18727 (FlowBranching.AddBreakVector): New method.
18729 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18731 * attribute.cs: Small regression fix: only convert the type if we
18732 the type is different, fixes System.Drawing build.
18734 2004-04-27 Martin Baulig <martin@ximian.com>
18736 * attribute.cs (Attribute.Resolve): If we have a constant value
18737 for a named field or property, implicity convert it to the correct
18740 2004-04-27 Raja R Harinath <rharinath@novell.com>
18742 * statement.cs (Block.Block): Implicit blocks share
18743 'child_variable_names' fields with parent blocks.
18744 (Block.AddChildVariableNames): Remove.
18745 (Block.AddVariable): Mark variable as "used by a child block" in
18746 every surrounding block.
18747 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18748 been used in a child block, complain about violation of "Invariant
18749 meaning in blocks" rule.
18750 * cs-parser.jay (declare_local_variables): Don't use
18751 AddChildVariableNames.
18752 (foreach_statement): Don't create an implicit block: 'foreach'
18753 introduces a scope.
18755 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18757 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18758 converting from 0L to ulong. Fixes 57522.
18760 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18762 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18763 derived class hides via 'new' keyword field from base class (test-242.cs).
18764 TODO: Handle this in the more general way.
18766 * class.cs (CheckBase): Ditto.
18768 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18770 * decl.cs (caching_flags): New member for storing cached values
18772 (MemberCore.Flags): New enum where bit flags for caching_flags
18774 (MemberCore.cls_compliance): Moved to caching_flags.
18775 (DeclSpace.Created): Moved to caching_flags.
18777 * class.cs: Use caching_flags instead of DeclSpace.Created
18779 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18781 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18782 if we are only a derived class, not a nested class.
18784 * typemanager.cs: Same as above, but do this at the MemberLookup
18785 level (used by field and methods, properties are handled in
18786 PropertyExpr). Allow for the qualified access if we are a nested
18789 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18791 * class.cs: Refactoring.
18792 (IMethodData): New inteface; Holds links to parent members
18793 to avoid member duplication (reduced memory allocation).
18794 (Method): Implemented IMethodData interface.
18795 (PropertyBase): New inner classes for get/set methods.
18796 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18797 (Event): New inner classes for add/remove methods.
18798 (Event.DelegateMethod): Implemented IMethodData interface.
18800 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18801 EmitContext (related to class.cs refactoring).
18803 2004-04-21 Raja R Harinath <rharinath@novell.com>
18805 * delegate.cs (Delegate.VerifyApplicability): If the number of
18806 arguments are the same as the number of parameters, first try to
18807 verify applicability ignoring any 'params' modifier on the last
18811 2004-04-16 Raja R Harinath <rharinath@novell.com>
18813 * class.cs (TypeContainer.AddIndexer): Use
18814 'ExplicitInterfaceName' to determine if interface name was
18815 explicitly specified. 'InterfaceType' is not initialized at this time.
18816 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18817 Indexers array is already in the required order. Initialize
18818 'IndexerName' only if there are normal indexers.
18819 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18820 (TypeContainer.Emit): Emit DefaultMember attribute only if
18821 IndexerName is initialized.
18824 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18826 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18829 2004-04-15 Raja R Harinath <rharinath@novell.com>
18831 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18835 * attribute.cs (Attribute.Resolve): Check for duplicate named
18839 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18841 * iterators.cs (MarkYield): track whether we are in an exception,
18842 and generate code accordingly. Use a temporary value to store the
18843 result for our state.
18845 I had ignored a bit the interaction of try/catch with iterators
18846 since their behavior was not entirely obvious, but now it is
18847 possible to verify that our behavior is the same as MS .NET 2.0
18851 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18853 * iterators.cs: Avoid creating temporaries if there is no work to
18856 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18857 Enumerations, use TypeManager.EnumToUnderlying and call
18860 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18863 (This.Emit): Use EmitContext.EmitThis to emit our
18866 (This.EmitAssign): Ditto.
18868 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18869 codepaths, we will move all the functionality into
18872 (FieldExpr.EmitAssign): Ditto.
18874 This fixes several hidden bugs that I uncovered while doing a code
18875 review of this today.
18877 * codegen.cs (EmitThis): reworked so the semantics are more clear
18878 and also support value types "this" instances.
18880 * iterators.cs: Changed so that for iterators in value types, we
18881 do not pass the value type as a parameter.
18883 Initialization of the enumerator helpers is now done in the caller
18884 instead of passing the parameters to the constructors and having
18885 the constructor set the fields.
18887 The fields have now `assembly' visibility instead of private.
18889 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18891 * expression.cs (Argument.Resolve): Check if fields passed as ref
18892 or out are contained in a MarshalByRefObject.
18894 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18895 another compiler type.
18897 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18899 * class.cs (Indexer.Define): use the new name checking method.
18900 Also, return false on an error.
18901 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18902 (is_identifier_[start/part]_character): make static.
18904 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18906 * expression.cs (Binary.ResolveOperator): Do no append strings
18907 twice: since we can be invoked more than once (array evaluation)
18908 on the same concatenation, take care of this here. Based on a fix
18909 from Ben (bug #56454)
18911 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18913 * codegen.cs: Fix another case where CS1548 must be reported (when
18914 delay-sign isn't specified and no private is available #56564). Fix
18915 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18916 error when MCS is used on the MS runtime and we need to delay-sign
18917 (which seems unsupported by AssemblyBuilder - see #56621).
18919 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18921 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18922 (TypeManager.ComputeNamespaces): Faster implementation for
18925 * compiler.csproj: Updated AssemblyName to mcs.
18927 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18929 * rootcontext.cs: Add new types to the boot resolution.
18931 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18932 MulticastDelegate is not allowed.
18934 * typemanager.cs: Add new types to lookup: System.TypedReference
18937 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18938 check for TypedReference or ArgIterator, they are not allowed.
18940 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18941 makes us properly catch 1510 in some conditions (see bug 56016 for
18944 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18946 * CryptoConvert.cs: update from corlib version
18949 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18951 * class.cs (Indexer.Define): Check indexername declaration
18953 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18955 * attribute.cs (IsClsCompliant): Fixed problem with handling
18956 all three states (compliant, not-compliant, undetected).
18958 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18960 * attribute.cs (Attribute): Location is now public.
18961 (Resolve): Store resolved arguments (pos_values) in attribute class.
18962 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18963 (GetClsCompliantAttributeValue): New method that gets
18964 CLSCompliantAttribute value.
18965 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18966 if exists else null.
18967 (AttributeTester): New class for CLS-Compliant verification routines.
18969 * class.cs (Emit): Add CLS-Compliant verification.
18970 (Method.GetSignatureForError): Implemented.
18971 (Constructor.GetSignatureForError): Implemented
18972 (Constructor.HasCompliantArgs): Returns if constructor has
18973 CLS-Compliant arguments.
18974 (Constructor.Emit): Override.
18975 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18976 is needed to test only parameters.
18977 (FieldBase.GetSignatureForError): Implemented.
18978 (TypeContainer): New member for storing base interfaces.
18979 (TypeContainer.FindMembers): Search in base interfaces too.
18981 * codegen.cs (GetClsComplianceAttribute): New method that gets
18982 assembly or module CLSCompliantAttribute value.
18983 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18985 (ModuleClass.Emit): Add error 3012 test.
18987 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18989 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18990 state for all decl types.
18991 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18992 if CLS-Compliant tests are required.
18993 (IsClsCompliaceRequired): New method. Analyze whether code
18994 must be CLS-Compliant.
18995 (IsExposedFromAssembly): New method. Returns true when MemberCore
18996 is exposed from assembly.
18997 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18998 value or gets cached value.
18999 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19000 is explicitly marked with CLSCompliantAttribute.
19001 (IsIdentifierClsCompliant): New abstract method. This method is
19002 used to testing error 3005.
19003 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19004 for identifier and parameters CLS-Compliant testing.
19005 (VerifyClsCompliance): New method. The main virtual method for
19006 CLS-Compliant verifications.
19007 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19008 null. I don't know why is null (too many public members !).
19009 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19010 and get value of first CLSCompliantAttribute that found.
19012 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19013 (VerifyClsCompliance): Override and add extra tests.
19015 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19016 clscheck- disable CLS-Compliant verification event if assembly is has
19017 CLSCompliantAttribute(true).
19019 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19020 ApllyAttribute is now called in emit section as in the other cases.
19021 Possible future Emit integration.
19022 (IsIdentifierClsCompliant): New override.
19023 (VerifyClsCompliance): New override.
19024 (GetEnumeratorName): Returns full enum name.
19026 * parameter.cs (GetSignatureForError): Implemented.
19028 * report.cs (WarningData): New struct for Warning message information.
19029 (LocationOfPreviousError): New method.
19030 (Warning): New method. Reports warning based on the warning table.
19031 (Error_T): New method. Reports error based on the error table.
19033 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19034 verifications are done here.
19036 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19038 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19039 CLSCompliantAttribute.
19040 (all_imported_types): New member holds all imported types from other
19042 (LoadAllImportedTypes): New method fills static table with exported types
19043 from all referenced assemblies.
19044 (Modules): New property returns all assembly modules.
19046 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19048 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19049 throwing a parser error.
19051 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19052 which removes the hardcoded get_/set_ prefixes for properties, as
19053 IL allows for the properties to be named something else.
19057 * expression.cs: Do not override operand before we know if it is
19058 non-null. Fix 56207
19060 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19062 * typemanager.cs: support for pinned variables.
19064 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19066 * decl.cs, typemanager.cs: Avoid using an arraylist
19067 as a buffer if there is only one result set.
19069 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19071 * expression.cs: Make sure you cant call a static method
19072 with an instance expression, bug #56174.
19074 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19076 * class.cs (IsDuplicateImplementation): Improve error reporting to
19077 flag 663 (method only differs in parameter modifier).
19079 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19080 in preprocessor directives.
19082 * location.cs (LookupFile): Allow for the empty path.
19084 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19085 better approach for some of that patch, but its failing with the
19086 CharSet enumeration. For now try/catch will do.
19088 * typemanager.cs: Do not crash if a struct does not have fields.
19091 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19093 * expression.cs: cs0213, cant fix a fixed expression.
19096 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19098 * cs-parser.jay: detect invalid embeded statements gracefully.
19101 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19103 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19106 the invocation type may not be a subclass of the tye of the item/
19107 The type of the item must be a subclass of the invocation item.
19112 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19114 * attribute.cs: Added methods to get a string and a bool from an
19115 attribute. Required to information from AssemblyKeyFileAttribute,
19116 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19117 * codegen.cs: Modified AssemblyName creation to include support for
19118 strongnames. Catch additional exceptions to report them as CS1548.
19119 * compiler.csproj: Updated include CryptoConvert.cs.
19120 * compiler.csproj.user: Removed file - user specific configuration.
19121 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19122 Mono.Security assembly. The original class is maintained and tested in
19123 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19124 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19125 like CSC 8.0 (C# v2) supports.
19126 * Makefile: Added CryptoConvert.cs to mcs sources.
19127 * rootcontext.cs: Added new options for strongnames.
19129 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19131 * driver.cs: For --expect-error, report error code `2'
19132 if the program compiled with no errors, error code `1' if
19133 it compiled with an error other than the one expected.
19135 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19137 * compiler.csproj: Updated for Visual Studio .NET 2003.
19138 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19139 * compiler.sln: Updated for Visual Studio .NET 2003.
19141 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19143 * expression.cs: Fix bug #47234. We basically need to apply the
19144 rule that we prefer the conversion of null to a reference type
19145 when faced with a conversion to 'object' (csc behaviour).
19147 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19149 * statement.cs: Shorter form for foreach, eliminates
19150 a local variable. r=Martin.
19152 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19154 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19155 checks if we can use brtrue/brfalse to test for 0.
19156 * expression.cs: use the above in the test for using brtrue/brfalse.
19157 cleanup code a bit.
19159 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19161 * expression.cs: Rewrite string concat stuff. Benefits:
19163 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19164 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19165 rather than a concat chain.
19167 * typemanager.cs: Add lookups for more concat overloads.
19169 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19171 * expression.cs: Emit shorter il code for array init.
19188 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19190 * statement.cs: Before, two switch blocks would be merged if the
19191 total size of the blocks (end_item - begin_item + 1) was less than
19192 two times the combined sizes of the blocks.
19194 Now, it will only merge if after the merge at least half of the
19199 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19201 * class.cs : csc build fix for GetMethods(). See bug #52503.
19203 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19205 * expression.cs: Make sure fp comparisons work with NaN.
19206 This fixes bug #54303. Mig approved this patch a long
19207 time ago, but we were not able to test b/c the runtime
19210 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19212 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19214 2004-03-19 Martin Baulig <martin@ximian.com>
19216 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19217 error here and not in our caller.
19219 2004-03-19 Martin Baulig <martin@ximian.com>
19221 * interface.cs: Completely killed this file.
19222 (Interface): We're now a TypeContainer and live in class.cs.
19224 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19225 argument; we're now also called for interfaces.
19226 (TypeContainer.DefineMembers): Allow this method being called
19228 (TypeContainer.GetMethods): New public method; formerly known as
19229 Interface.GetMethod(). This is used by PendingImplementation.
19230 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19231 it's now private and non-static.
19232 (Interface): Moved this here; it's now implemented similar to
19234 (Method, Property, Event, Indexer): Added `bool is_interface'
19235 argument to their .ctor's.
19236 (MemberBase.IsInterface): New public field.
19238 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19239 instances instead of InterfaceMethod, InterfaceProperty, etc.
19240 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19241 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19243 2004-03-19 Martin Baulig <martin@ximian.com>
19245 * class.cs (MethodCore.IsDuplicateImplementation): New private
19246 method which does the CS0111 checking.
19247 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19248 Use IsDuplicateImplementation().
19250 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19252 * decl.cs (FindMemberToOverride): New method to find the correct
19253 method or property to override in the base class.
19255 - Make Method/Property use the above method to find the
19256 version in the base class.
19257 - Remove the InheritableMemberSignatureCompare as it is now
19260 This patch makes large code bases much faster to compile, as it is
19261 O(n) rather than O(n^2) to do this validation.
19263 Also, it fixes bug 52458 which is that nested classes are not
19264 taken into account when finding the base class member.
19266 Reviewed/Approved by Martin.
19268 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19270 * interface.cs: In all interface classes removed redundant
19271 member initialization.
19273 2004-03-16 Martin Baulig <martin@ximian.com>
19275 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19277 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19279 * decl.cs (DefineTypeAndParents): New helper method to define a
19280 type's containers before the type itself is defined; This is a
19281 bug exposed by the recent changes to Windows.Forms when an
19282 implemented interface was defined inside a class that had not been
19285 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19287 (Check): Loop correctly to report errors modifiers
19288 (UNSAFE was not in the loop, since it was the same as TOP).
19290 * interface.cs: Every interface member now takes a ModFlags,
19291 instead of a "is_new" bool, which we set on the base MemberCore.
19293 Every place where we called "UnsafeOk" in the interface, now we
19294 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19295 the unsafe settings from the member declaration instead of the
19296 container interface.
19298 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19300 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19301 `set_indexer_name' to the pending bits (one per type).
19303 We fixed a bug today that was picking the wrong method to
19304 override, since for properties the existing InterfaceMethod code
19305 basically ignored the method name. Now we make sure that the
19306 method name is one of the valid indexer names.
19308 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19310 * support.cs (SeekableStreamReader): Keep track of stream byte
19311 positions and don't mix them with character offsets to the buffer.
19313 Patch from Gustavo Giráldez
19315 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19317 * interface.cs (InterfaceSetGetBase): Removed double member
19318 initialization, base class does it as well.
19320 2004-03-13 Martin Baulig <martin@ximian.com>
19322 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19323 when compiling corlib.
19325 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19327 * convert.cs (ExplicitConversion): We were reporting an error on
19328 certain conversions (object_type source to a value type, when the
19329 expression was `null') before we had a chance to pass it through
19330 the user defined conversions.
19332 * driver.cs: Replace / and \ in resource specifications to dots.
19335 * class.cs: Add check for duplicate operators. Fixes 52477
19337 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19339 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19340 that are in the middle of the statements, not only at the end.
19343 * class.cs (TypeContainer.AddField): No longer set the
19344 `HaveStaticConstructor' flag, now we call it
19345 `UserDefineStaticConstructor' to diferentiate the slightly
19346 semantic difference.
19348 The situation is that we were not adding BeforeFieldInit (from
19349 Modifiers.TypeAttr) to classes that could have it.
19350 BeforeFieldInit should be set to classes that have no static
19355 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19357 And most importantly Zoltan's comment:
19359 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19361 "I think beforefieldinit means 'it's ok to initialize the type sometime
19362 before its static fields are used', i.e. initialization does not need
19363 to be triggered by the first access to the type. Setting this flag
19364 helps the JIT to compile better code, since it can run the static
19365 constructor at JIT time, and does not need to generate code to call it
19366 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19367 this flag for lots of classes like String.
19369 csc sets this flag if the type does not have an explicit static
19370 constructor. The reasoning seems to be that if there are only static
19371 initalizers for a type, and no static constructor, then the programmer
19372 does not care when this initialization happens, so beforefieldinit
19375 This bug prevents the AOT compiler from being usable, since it
19376 generates so many calls to mono_runtime_class_init that the AOT code
19377 is much slower than the JITted code. The JITted code is faster,
19378 because it does not generate these calls if the vtable is type is
19379 already initialized, which is true in the majority of cases. But the
19380 AOT compiler can't do this."
19382 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19384 * class.cs (MethodData.Emit): Refactor the code so symbolic
19385 information is generated for destructors; For some reasons we
19386 were taking a code path that did not generate symbolic information
19389 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19391 * class.cs: Create a Constructor.CheckBase method that
19392 takes care of all validation type code. The method
19393 contains some code that was moved from Define.
19395 It also includes new code that checks for duplicate ctors.
19396 This fixes bug #55148.
19398 2004-03-09 Joshua Tauberer <tauberer@for.net>
19400 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19401 a { ... }-style array creation invokes EmitStaticInitializers
19402 which is not good for reference-type arrays. String, decimal
19403 and now null constants (NullCast) are not counted toward
19404 static initializers.
19406 2004-03-05 Martin Baulig <martin@ximian.com>
19408 * location.cs (SourceFile.HasLineDirective): New public field;
19409 specifies whether the file contains or is referenced by a "#line"
19411 (Location.DefineSymbolDocuments): Ignore source files which
19412 either contain or are referenced by a "#line" directive.
19414 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19416 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19417 direct access to our parent, so check the method inline there.
19419 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19421 * expression.cs (Invocation.EmitCall): Miguel's last commit
19422 caused a regression. If you had:
19427 In Foo the implict this would be null.
19429 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19431 * expression.cs (Invocation.EmitCall): If the method is not
19432 virtual, do not emit a CallVirt to it, use Call.
19434 * typemanager.cs (GetFullNameSignature): Improve the method to
19435 cope with ".ctor" and replace it with the type name.
19437 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19438 as an argument the ConstructorBuilder where it is being defined,
19439 to catch the recursive constructor invocations.
19441 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19443 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19444 routines to check if a type is an enumerable/enumerator allow
19445 classes that implement the IEnumerable or IEnumerator interfaces.
19447 * class.cs (Property, Operator): Implement IIteratorContainer, and
19448 implement SetYields.
19450 (Property.Define): Do the block swapping for get_methods in the
19451 context of iterators. We need to check if Properties also
19452 include indexers or not.
19454 (Operator): Assign the Block before invoking the
19455 OperatorMethod.Define, so we can trigger the Iterator code
19458 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19459 Property and Operator classes are not created when we parse the
19460 declarator but until we have the block completed, so we use a
19461 singleton SimpleIteratorContainer.Simple to flag whether the
19462 SetYields has been invoked.
19464 We propagate this setting then to the Property or the Operator to
19465 allow the `yield' to function.
19467 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19469 * codegen.cs: Implemented attribute support for modules.
19470 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19471 Assembly/Module functionality.
19473 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19474 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19475 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19477 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19479 * interface.cs (FindMembers): The operation is performed on all base
19480 interfaces and not only on the first. It is required for future CLS Compliance patch.
19482 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19484 * statement.cs, codegen.cs:
19485 This patch deals with patterns such as:
19487 public class List : IEnumerable {
19489 public MyEnumerator GetEnumerator () {
19490 return new MyEnumerator(this);
19493 IEnumerator IEnumerable.GetEnumerator () {
19497 public struct MyEnumerator : IEnumerator {
19502 Before, there were a few things we did wrong:
19503 1) we would emit callvirt on a struct, which is illegal
19504 2) we emited ldarg when we needed to emit ldarga
19505 3) we would mistakenly call the interface methods on an enumerator
19506 type that derived from IEnumerator and was in another assembly. For example:
19508 public class MyEnumerator : IEnumerator
19510 Would have the interface methods called, even if there were public impls of the
19511 method. In a struct, this lead to invalid IL code.
19513 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19515 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19518 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19520 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19522 * cs-parser.jay: Fix small regression: we were not testing V2
19523 compiler features correctly.
19525 * interface.cs: If the emit context is null, then create one
19527 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19529 * decl.cs (GetSignatureForError): New virtual method to get full name
19530 for error messages.
19532 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19533 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19535 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19536 Duplicated members and code in these classes has been removed.
19537 Better encapsulation in these classes.
19539 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19541 * assign.cs (Assign.DoResolve): When dealing with compound
19542 assignments, there is a new rule in ECMA C# 2.4 (might have been
19543 there before, but it is documented here) that states that in:
19547 If b is of type int, and the `op' is a shift-operator, then the
19548 above is evaluated as:
19552 * expression.cs (Binary.ResolveOperator): Instead of testing for
19553 int/uint/long/ulong, try to implicitly convert to any of those
19554 types and use that in pointer arithmetic.
19556 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19557 method to print information for from the type, not from the
19558 null-method we were given.
19560 2004-02-01 Duncan Mak <duncan@ximian.com>
19562 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19563 parsing for cmd, fixes bug #53694.
19565 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19567 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19568 in the member name duplication tests. Property and operator name duplication
19569 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19571 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19573 * interface.cs (PopulateMethod): Fixed crash when interface method
19574 returns not existing type (error test cs0246-3.cs).
19576 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19578 * cs-parser.jay (interface_accessors): Re-write actions to also
19579 store attributes attached to get and set methods. Fix spelling
19582 (inteface_property_declaration): Modify accordingly.
19584 (InterfaceAccessorInfo): New helper class to store information to pass
19585 around between rules that use interface_accessors.
19587 * interface.cs (Emit): Apply attributes on the get and set
19588 accessors of properties and indexers too.
19590 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19591 right MethodBuilder when applying attributes to the get and set accessors.
19593 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19595 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19597 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19599 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19601 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19603 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19604 changes that treat `yield' specially when present before `break'
19605 or `return' tokens.
19607 * cs-tokenizer.cs: yield is no longer a keyword.
19609 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19611 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19612 setting for default constructors.
19613 For default constructors are almost every time set wrong Modifier. The
19614 generated IL code has been alright. But inside mcs this values was
19615 wrong and this was reason why several of my CLS Compliance tests
19618 2004-01-22 Martin Baulig <martin@ximian.com>
19620 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19621 not a QualifiedIdentifier. This is what `type_name_expression'
19622 was previously doing.
19623 (type_name_expression): Removed; the code is now in
19624 `namespace_or_type_name'.
19625 (qualified_identifier): Removed, use `namespace_or_type_name'
19627 (QualifiedIdentifier): Removed this class.
19629 2004-01-22 Martin Baulig <martin@ximian.com>
19631 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19632 not a string as alias name.
19634 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19636 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19637 #52730 bug, and instead compute correctly the need to use a
19638 temporary variable when requesting an address based on the
19639 static/instace modified of the field and the constructor.
19641 2004-01-21 Martin Baulig <martin@ximian.com>
19643 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19644 class and namespace before looking up aliases. Fixes #52517.
19646 2004-01-21 Martin Baulig <martin@ximian.com>
19648 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19649 assinged in a 'try'; fixes exception4.cs.
19651 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19652 * class.cs : Implemented parameter-less constructor for TypeContainer
19654 * decl.cs: Attributes are now stored here. New property OptAttributes
19656 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19658 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19660 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19662 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19663 (CSharpSignature): New method for indexer and property signature.
19665 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19667 * pending.cs (IsVirtualFilter): Faster implementation.
19669 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19671 * typemanager.cs: Avoid inclusion of same assembly more than once.
19673 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19675 * cs-parser.jay: Fixed problem where the last assembly attribute
19676 has been applied also to following declaration (class, struct, etc.)
19678 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19680 * class.cs: Added error CS0538, CS0539 reporting.
19681 Fixed crash on Microsoft runtime when field type is void.
19683 * cs-parser.jay: Added error CS0537 reporting.
19685 * pending.cs: Added error CS0535 reporting.
19686 Improved error report for errors CS0536, CS0534.
19688 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19690 Merge a few bits from the Anonymous Method MCS tree.
19692 * statement.cs (ToplevelBlock): New class for toplevel methods,
19693 will hold anonymous methods, lifted variables.
19695 * cs-parser.jay: Create toplevel blocks for delegates and for
19696 regular blocks of code.
19698 2004-01-20 Martin Baulig <martin@ximian.com>
19700 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19701 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19702 and `NeedExplicitReturn'; added `IsLastStatement'.
19703 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19704 have a `ReturnLabel' or we're not unreachable.
19706 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19707 child's reachability; don't just override ours with it. Fixes
19708 #58058 (lluis's example).
19709 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19710 InFinally(), InLoop(), InSwitch() and
19711 BreakCrossesTryCatchBoundary() methods.
19713 * statement.cs (Return): Do all error checking in Resolve().
19714 Unless we are the last statement in a top-level block, always
19715 create a return label and jump to it.
19716 (Break, Continue): Do all error checking in Resolve(); also make
19717 sure we aren't leaving a `finally'.
19718 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19719 statement in a top-level block.
19720 (Block.Flags): Added `IsDestructor'.
19721 (Block.IsDestructor): New public property.
19723 2004-01-20 Martin Baulig <martin@ximian.com>
19725 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19727 2004-01-20 Martin Baulig <martin@ximian.com>
19729 * statement.cs (Statement.ResolveUnreachable): New public method.
19730 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19731 (Block.Resolve): Resolve unreachable statements.
19733 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19735 * expression.cs: We need to fix the case where we do
19736 not have a temp variable here.
19738 * assign.cs: Only expression compound assignments need
19739 temporary variables.
19741 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19743 * flowanalysis.cs: Reduce memory allocation in a few ways:
19744 - A block with no variables should not allocate a bit
19746 - A method with no out parameters does not need any tracking
19747 for assignment of the parameters, so we need not allocate
19750 public readonly Type[] VariableTypes;
19751 public readonly string[] VariableNames;
19752 Are redundant. The data is already stored in the variable
19753 map, so we need not allocate another array for it.
19754 - We need to add alot of checks for if (params | locals) == null
19755 due to the first two changes.
19757 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19759 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19760 implement IMemoryLocation, we store a copy on a local variable and
19761 take the address of it. Patch from Benjamin Jemlich
19763 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19764 to use a special "type_name_expression" rule which reduces the
19765 number of "QualifiedIdentifier" classes created, and instead
19766 directly creates MemberAccess expressions.
19768 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19770 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19771 that fixes #52853. Null literal assignment to ValueType
19773 * class.cs (MethodData.Emit): Instead of checking the name of the
19774 method to determine if its a destructor, create a new derived
19775 class from Method called Destructor, and test for that.
19777 * cs-parser.jay: Create a Destructor object instead of a Method.
19779 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19783 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19785 * expression.cs (Binary.ResolveOperator): Perform an implicit
19786 conversion from MethodGroups to their delegate types on the
19787 Addition operation.
19789 * delegate.cs: Introduce a new class DelegateCreation that is the
19790 base class for `NewDelegate' and `ImplicitDelegateCreation',
19791 factor some code in here.
19793 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19794 conversion from MethodGroups to compatible delegate types.
19796 * ecore.cs (Expression.Resolve): Do not flag error 654
19797 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19798 we allow conversions from MethodGroups to delegate types now.
19800 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19801 assignments in v2 either.
19803 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19805 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19806 static read-only fields in ctors.
19808 Applied patch from Benjamin Jemlich
19810 * expression.cs (UnaryMutator): Avoid leaking local variables.
19812 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19814 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19815 here to return true, as they can be used like this:
19817 (XXX) int.MEMBER ()
19819 Fixed 49836 and all the other dups
19821 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19823 * driver.cs: Implement /win32res and /win32icon.
19825 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19827 * cs-parser.jay: Add a rule to improve error handling for the
19828 common mistake of placing modifiers after the type.
19830 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19832 * cs-parser.jay (interface_event_declaration): Catch
19833 initialization of events on interfaces, and report cs0068
19835 * cs-parser.jay (interface_event_declaration): Catch
19836 initialization of events.
19838 * ecore.cs: Better report missing constructors.
19840 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19841 the error reporting done in the wrong place. Fix.
19843 * expression.cs (Binary.ResolveOperator): Catch the
19844 operator + (E x, E y) error earlier, and later allow for implicit
19845 conversions in operator +/- (E e, U x) from U to the underlying
19848 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19849 52596, if the container class is abstract, the default constructor
19850 is protected otherwise its public (before, we were always public).
19852 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19855 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19856 Jemlich that fixes bug #52597, MCS was generating invalid code for
19857 idisposable structs. Thanks to Ben for following up with this
19860 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19862 * driver.cs: Allow assemblies without code to be generated, fixes
19865 2004-01-07 Nick Drochak <ndrochak@gol.com>
19867 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19869 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19871 * cs-parser.jay: Add rules to improve error reporting if fields or
19872 methods are declared at the namespace level (error 116)
19874 * Add rules to catch event add/remove
19876 2004-01-04 David Sheldon <dave-mono@earth.li>
19878 * expression.cs: Added matching ")" to error message for
19881 2004-01-03 Todd Berman <tberman@gentoo.org>
19883 * ecore.cs, attribute.cs:
19884 Applying fix from #52429.
19886 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19888 * ecore.cs, expression.cs, statement.cs:
19889 Total rewrite of how we handle branching. We
19890 now handle complex boolean expressions with fewer
19891 jumps. As well if (x == 0) no longer emits a ceq.
19893 if (x is Foo) is much faster now, because we generate
19896 Overall, we get a pretty big improvement on our benchmark
19897 tests. The code we generate is smaller and more readable.
19899 I did a full two-stage bootstrap. The patch was reviewed
19900 by Martin and Miguel.
19902 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19904 * cs-parser.jay: Make primary_expression not take a QI.
19905 we dont need this because the member_access rule covers
19906 us here. So we replace the rule with just IDENTIFIER.
19908 This has two good effects. First, we remove a s/r conflict.
19909 Second, we allocate many fewer QualifiedIdentifier objects.
19911 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19913 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19914 set the correct information via SRE. This prevents
19915 hanging on the MS runtime. Fixes #29374.
19917 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19919 * convert.cs: correctly handle conversions to value types
19920 from Enum and ValueType as unboxing conversions.
19922 Fixes bug #52569. Patch by Benjamin Jemlich.
19924 2004-01-02 Ravi Pratap <ravi@ximian.com>
19926 * expression.cs (BetterConversion): Prefer int -> uint
19927 over int -> ulong (csc's behaviour). This fixed bug #52046.
19929 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19931 * decl.cs (MemberCache.FindMembers): now returns a
19934 * typemanager.cs: In general, go with with ^^.
19935 (CopyNewMethods): take an IList.
19936 (RealMemberLookup): Only allocate an arraylist
19937 if we copy from two sets of methods.
19939 This change basically does two things:
19940 1) Fewer array lists allocated due to CopyNewMethods.
19941 2) the explicit cast in MemberList costed ALOT.
19943 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19945 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19946 a hashtable to avoid needless string allocations when an identifier is
19947 used more than once (the common case).
19949 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19951 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19952 is broken, it will not return anything. So, we
19953 have to use the information we have in mcs to
19956 * typemanager.cs: Add a cache for GetInterfaces,
19957 since this will now be used more often (due to ^^)
19959 (GetExplicitInterfaces) New method that gets the
19960 declared, not effective, interfaces on a type
19961 builder (eg, if you have interface IFoo, interface
19962 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19965 This patch makes MCS able to bootstrap itself on
19968 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19970 * expression.cs: Remove the Nop's that Miguel put
19973 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19975 * report.cs, codegen.cs: Give the real stack trace to
19976 the error when an exception is thrown.
19978 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19980 * decl.cs: only allocate hashtables for ifaces if
19983 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19985 * expression.cs: fix the error from cs0121-2.cs
19986 (a parent interface has two child interfaces that
19987 have a function with the same name and 0 params
19988 and the function is called through the parent).
19990 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19992 * class.cs, rootcontext.cs, typmanager.cs: do not
19995 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19997 * codegen.cs: remove stack for the ec flow branching.
19998 It is already a linked list, so no need.
20000 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20002 * Makefile: Allow custom profiler here.
20004 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20006 * typemanager.cs (LookupType):
20007 - Use a static char [], because split takes
20008 a param array for args, so it was allocating
20010 - Do not store true in a hashtable, it boxes.
20012 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20014 * flowanalysis.cs: bytify common enums.
20016 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20018 * modifiers.cs: Add a new set of flags for the
20019 flags allowed on explicit interface impls.
20020 * cs-parser.jay: catch the use of modifiers in
20021 interfaces correctly.
20022 * class.cs: catch private void IFoo.Blah ().
20024 All related to bug #50572.
20026 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20028 * decl.cs: Rewrite the consistant accessability checking.
20029 Accessability is not linear, it must be implemented in
20030 a tableish way. Fixes #49704.
20032 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20034 * expression.cs: Handle negation in a checked context.
20035 We must use subtraction from zero. Fixes #38674.
20037 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20039 * class.cs: Ignore static void main in DLLs.
20040 * rootcontext.cs: Handle the target type here,
20041 since we are have to access it from class.cs
20042 * driver.cs: account for the above.
20044 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20046 * report.cs: Give line numbers and files if available.
20048 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20050 * driver.cs: Implement /addmodule.
20052 * typemanager.cs: Change 'modules' field so it now contains Modules not
20055 2003-12-20 Martin Baulig <martin@ximian.com>
20057 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20058 (FieldBase.IsAssigned): Removed this field.
20059 (FieldBase.SetAssigned): New public method.
20060 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20062 2003-12-20 Martin Baulig <martin@ximian.com>
20064 * expression.cs (LocalVariableReference.DoResolve): Don't set
20065 `vi.Used' if we're called from DoResolveLValue().
20067 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20068 returns the usage vector it just merged into the current one -
20069 pass this one to UsageWarning().
20070 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20071 of the `EmitContext', don't call this recursively on our children.
20073 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20075 * driver.cs: Implement /target:module.
20077 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20079 * support.cs (CharArrayHashtable): New helper class.
20081 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20082 char arrays, not strings, so we can avoid creating a string in
20083 consume_identifier if the identifier is a keyword.
20085 2003-12-16 Martin Baulig <martin@ximian.com>
20087 * statement.cs (LocalInfo.Assigned): Removed this property.
20088 (LocalInfo.Flags): Removed `Assigned'.
20089 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20090 and uses flow analysis.
20091 (Block.UsageWarning): Made this method private.
20092 (Block.Resolve): Call UsageWarning() if appropriate.
20094 * expression.cs (LocalVariableReference.DoResolve): Always set
20095 LocalInfo.Used here.
20097 2003-12-13 Martin Baulig <martin@ximian.com>
20099 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20100 any value here; we're now using flow analysis to figure out
20101 whether a statement/block returns a value.
20103 2003-12-13 Martin Baulig <martin@ximian.com>
20105 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20107 (FlowBranching.MergeFinally): Don't call
20108 `branching.CheckOutParameters()' here, this is called in
20110 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20111 when adding the `finally' vector.
20113 2003-12-13 Martin Baulig <martin@ximian.com>
20116 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20117 actually work and also fix #48962.
20119 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20121 * decl.cs: Do not check System.Object for nested types,
20122 since we know it does not have any. Big bang for buck:
20125 Run 1: 8.35 seconds
20126 Run 2: 8.32 seconds
20127 corlib: 17.99 seconds
20129 Run 1: 8.17 seconds
20130 Run 2: 8.17 seconds
20131 corlib: 17.39 seconds
20133 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20135 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20136 time we are returning 0 members, so we save alot here.
20138 2003-12-11 Martin Baulig <martin@ximian.com>
20140 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20141 `MergeChild()', also just take the `FlowBranching' as argument;
20142 call Merge() on it and return the result.
20143 (FlowBranching.Merge): We don't need to do anything if we just
20146 2003-12-11 Martin Baulig <martin@ximian.com>
20148 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20149 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20150 Maurer for this idea.
20152 2003-12-11 Martin Baulig <martin@ximian.com>
20154 * flowanalysis.cs (MergeResult): This class is now gone; we now
20155 use the `UsageVector' for this. The reason for this is that if a
20156 branching just has one sibling, we don't need to "merge" them at
20157 all - that's the next step to do.
20158 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20161 2003-12-11 Martin Baulig <martin@ximian.com>
20163 Reworked flow analyis and made it more precise and bug-free. The
20164 most important change is that we're now using a special `Reachability'
20165 class instead of having "magic" meanings of `FlowReturns'. I'll
20166 do some more cleanups and optimizations and also add some more
20167 documentation this week.
20169 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20170 largely reworked this class.
20171 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20172 the new `Reachability' class instead of having "magic" values here.
20173 (FlowBranching): We're now using an instance of `Reachability'
20174 instead of having separate `Returns', `Breaks' etc. fields.
20176 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20177 based on flow analysis; ignore the return value of block.Emit ().
20179 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20181 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20182 if they are private.
20184 2003-12-09 Martin Baulig <martin@ximian.com>
20186 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20187 call them directly on the UsageVector.
20189 2003-12-09 Martin Baulig <martin@ximian.com>
20191 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20192 Changed return type from `FlowReturns' to `Reachability'.
20194 2003-12-09 Martin Baulig <martin@ximian.com>
20196 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20197 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20198 `Reachable' fields with a single `Reachability' one.
20200 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20202 * class.cs (FindMembers): Remove foreach's.
20207 Run 1: 8.74 seconds
20208 Run 2: 8.71 seconds
20211 Run 1: 8.64 seconds
20212 Run 2: 8.58 seconds
20215 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20220 This patch does a few things:
20221 1. EmptyStatement is now a singleton, so it is never reallocated.
20222 2. All blah is EmptyStatement constructs have been changed to
20223 blah == EmptyStatement.Value, which is much faster and valid
20224 now that EmptyStatement is a singleton.
20225 3. When resolving a block, rather than allocating a new array for
20226 the non-empty statements, empty statements are replaced with
20227 EmptyStatement.Value
20228 4. Some recursive functions have been made non-recursive.
20229 Mainly the performance impact is from (3), however (1) and (2) are needed for
20230 this to work. (4) does not make a big difference in normal situations, however
20231 it makes the profile look saner.
20236 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20237 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20238 Total memory allocated: 56397 KB
20241 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20242 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20243 Total memory allocated: 55666 KB
20245 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20247 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20248 than the hashtable in a hashtable version
20250 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20251 we always end up concating a string. This results in a huge perf
20252 loss, because many strings have to be tracked by the GC. In this
20253 patch, we first use a hashtable that works with two keys, so that
20254 the strings do not need to be concat'ed.
20258 Run 1: 8.74 seconds
20259 Run 2: 8.71 seconds
20262 Run 1: 8.65 seconds
20263 Run 2: 8.56 seconds
20265 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20267 * Makefile: Add a new target `do-time' that does a quick and simple
20268 profile, leaving easy to parse output.
20270 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20272 * codegen.cs (Init): Create the dynamic assembly with
20273 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20275 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20277 * support.cs: Make the PtrHashtable use only one
20278 instance of its comparer.
20280 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20282 * typemanager.cs: Fix lookup of GetNamespaces.
20284 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20286 * expression.cs: Removed redundant line.
20288 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20289 ArrayLists, use for loops with bounds.
20291 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20294 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20295 arraylists, use for loop with bounds.
20297 The above three changes give us a 0.071 second performance
20298 improvement out of 3.294 seconds down to 3.223. On my machine
20299 the above changes reduced the memory usage by 1,387 KB during
20300 compiler bootstrap.
20302 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20303 QualifiedIdentifiers. Before we created a new string through
20304 concatenation, and mostly later on, the result would be
20305 manipulated by DecomposeQI through string manipulation.
20307 This reduced the compiler memory usage for bootstrapping from
20308 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20309 compile times in 0.05 seconds.
20311 2003-11-28 Dick Porter <dick@ximian.com>
20313 * support.cs: Do string compares with the Invariant culture.
20321 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20322 the comparison is done with the Invariant culture.
20324 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20326 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20327 GetEnumerator method.
20329 (ProbeCollectionType): Iterate starting at the most specific type
20330 upwards looking for a GetEnumerator
20332 * expression.cs: Shift count can be up to 31 for int/uint and 63
20335 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20337 * statement.cs (Block.LookupLabel): Also look for the label on the
20338 children blocks. Use a hash table to keep track of visited
20341 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20342 we actually did transform the other operand, otherwise fall back
20343 to the common codepath that casts to long.
20345 * cs-tokenizer.cs: Use the same code pattern as the int case.
20346 Maybe I should do the parsing myself, and avoid depending on the
20347 Parse routines to get this done.
20349 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20351 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20352 which fixes bug 51347. This time test it.
20354 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20355 attributes for example can not tell the difference between these.
20356 The difference was only a syntax feature of the language.
20358 * attribute.cs: Apply attributes to delegates.
20360 * delegate.cs: Call the apply attributes method.
20362 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20364 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20365 comparing 0 vs Byte.MinValue, not the value
20367 (ImplicitConversionRequired): When reporting a conversion error,
20368 use error 31 to print out the constant error instead of the
20371 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20372 which fixes bug 51347.
20374 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20376 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20377 which fixes the -warnaserror command line option.
20379 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20381 * cfold.cs (DoNumericPromotions): During constant folding of
20382 additions on UIntConstant, special case intconstants with
20383 IntConstants like we do on the expression binary operator.
20385 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20387 * convert.cs (ImplicitReferenceConversion): We were missing a case
20388 (System.Enum are not value types or class types, so we need to
20389 classify them separatedly).
20391 * driver.cs: We do not support error 2007.
20393 2003-11-12 Jackson Harper <jackson@ximian.com>
20395 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20396 system directory. Also use the full file name so users can
20397 libraries names mscorlib-o-tron.dll in a non system dir.
20399 2003-11-10 Martin Baulig <martin@ximian.com>
20401 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20402 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20403 calling `ResolveType()' on them, directly assign their `Type'.
20405 2003-11-08 Martin Baulig <martin@ximian.com>
20407 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20408 return value and the `out parent' parameter.
20409 (TypeContainer.DefineType): Moved the CS0644 check into
20410 GetClassBases(). Don't pass the interface types to the
20411 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20412 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20414 * ecore.cs (TypeExpr.IsAttribute): New property.
20415 (TypeExpr.GetInterfaces): New method.
20417 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20418 TypeExpr instead of a Type.
20419 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20420 (Interface.DefineType): Don't pass the interface types to the
20421 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20422 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20424 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20425 instead of a `Type[]'.
20426 (TypeManager.RegisterBuilder): Likewise.
20427 (TypeManager.AddUserInterface): Likewise.
20428 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20429 `Type[]' and also return a `TypeExpr[]'.
20430 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20432 2003-11-08 Martin Baulig <martin@ximian.com>
20434 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20437 2003-11-08 Martin Baulig <martin@ximian.com>
20439 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20440 TypeManager.ResolveExpressionTypes().
20442 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20443 instead of an Expression.
20444 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20445 (TypeExpression): New public class; formerly known as `TypeExpr'.
20447 * expression.cs (ComposedCast): Derive from TypeExpr.
20449 * typemanager.cs (TypeManager.system_*_expr): These are now
20450 TypExpr's instead of Expression's.
20451 (TypeManager.ResolveExpressionTypes): New public static function;
20452 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20455 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20457 * expression.cs (New.DoResolve): Do not dereference value that
20458 might be a null return.
20460 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20461 sure that the constant value has the right type. Fixes an
20462 unreported bug, similar to 50425.
20464 * const.cs (Const.LookupConstantValue): Call
20465 ImplicitStandardConversionExists before doing a conversion to
20466 avoid havng the TypeManager.ChangeType do conversions.
20468 Reduced the number of casts used
20470 (Const.ChangeType): New routine to enable reuse of the constant
20471 type changing code from statement.
20473 * typemanager.cs (ChangeType): Move common initialization to
20474 static global variables.
20478 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20479 every value type to go through, even if it was void. Fix that.
20481 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20482 character of the define, and the is_identifier_part_character for
20483 the rest of the string.
20485 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20487 * expression.cs (UnaryMutator.EmitCode): When I updated
20488 LocalVariableReference.DoResolve, I overdid it, and dropped an
20489 optimization done on local variable references.
20491 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20493 * ecore.cs: Convert the return from Ldlen into an int.
20495 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20497 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20498 the accessibility, this is a special case for toplevel non-public
20499 classes (internal for instance).
20501 2003-10-20 Nick Drochak <ndrochak@gol.com>
20503 * ecore.cs: Fix typo and build. Needed another right paren.
20505 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20507 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20508 `internal' case regular and protected, but not allowing protected
20509 to be evaluated later. Bug 49840
20511 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20513 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20514 to kb.Nlast, and not the kb.nFirst to isolate the switch
20517 Extract the underlying type, so enumerations of long/ulong are
20518 treated like long/ulong.
20520 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20522 * expression.cs (New): Overload the meaning of RequestedType to
20523 track the possible creation of the NewDelegate type, since
20524 DoResolve is invoked more than once for new constructors on field
20527 See bugs: #48800 and #37014
20529 * cs-parser.jay (declare_local_constants): Take an arraylist
20530 instead of a single constant.
20532 (local_constant_declaration): It should take a
20533 constant_declarators, not a constant_declarator. Fixes 49487
20535 * convert.cs: Fix error report.
20537 2003-10-13 Jackson Harper <jackson@ximian.com>
20539 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20542 2003-10-09 Martin Baulig <martin@ximian.com>
20544 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20546 (MethodCore.DoDefineParameters): Removed the TypeContainer
20547 argument; use the DeclSpace which was passed to the .ctor instead.
20548 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20549 TypeContainer; we only need a DeclSpace here.
20551 2003-10-09 Martin Baulig <martin@ximian.com>
20553 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20555 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20556 EmitContext's .ctor.
20558 2003-10-09 Martin Baulig <martin@ximian.com>
20560 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20561 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20562 AsAccessible(), moved them as well.
20564 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20566 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20568 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20570 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20572 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20573 generation for >=, as spotted by Paolo, bug 48679.
20574 Patch from David Waite.
20576 * cs-tokenizer.cs: Add handling for #pragma.
20578 * cs-parser.jay: Allow for both yield and yield return in the
20579 syntax. The anti-cobolization of C# fight will go on!
20581 * class.cs (TypeBuilder.DefineType): Catch error condition here
20582 (Parent.DefineType erroring out and returning null).
20584 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20585 coping with enumerations variables, we were mistakenly processing
20586 them as a regular value type instead of built-in types. Fixes the
20589 * typemanager.cs (IsBuiltinOrEnum): New method.
20591 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20593 * cs-parser.jay: Upgrade: yield now needs the return clause.
20595 2003-09-19 Martin Baulig <martin@ximian.com>
20597 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20598 `MemberCache parent' argument. Normally, an interface doesn't
20599 have a parent type except System.Object, but we use this in gmcs
20600 for generic type parameters.
20602 2003-09-18 Martin Baulig <martin@ximian.com>
20604 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20605 on `type.IsInterface'; don't check whether the type has a parent
20606 to determine whether it's an interface.
20608 2003-09-15 Martin Baulig <martin@ximian.com>
20610 * class.cs (TypeContainer.DefineType): Added an error flag to
20611 avoid reporting duplicate CS0146's ("class definition is
20614 * driver.cs (Driver.MainDriver): Abort if
20615 RootContext.ResolveTree() reported any errors.
20617 2003-09-07 Martin Baulig <martin@ximian.com>
20619 * report.cs (Error, Warning): Added overloaded versions which take
20620 a `params object[] args' and call String.Format().
20622 2003-09-07 Martin Baulig <martin@ximian.com>
20624 * decl.cs (DeclSpace..ctor): Don't call
20625 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20626 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20627 (DeclSpace.RecordDecl): New method.
20629 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20631 2003-09-02 Ravi Pratap <ravi@ximian.com>
20633 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20634 value attributes to be applied to ParameterBuilders.
20636 * class.cs (MethodCore.LabelParameters): Make static and more
20637 generic so that it can be used from other places - like interface
20638 methods, for instance.
20640 * interface.cs (Interface.Emit): Call LabelParameters before
20641 emitting attributes on the InterfaceMethod.
20643 2003-08-26 Martin Baulig <martin@ximian.com>
20645 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20646 resolving aliases; fixes #47927.
20648 2003-08-26 Martin Baulig <martin@ximian.com>
20650 * statement.cs (Using.DoResolve): This is internally emitting a
20651 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20652 do not always return. Fixes #47681.
20654 2003-08-26 Martin Baulig <martin@ximian.com>
20656 * decl.cs (MemberCore): Moved WarningNotHiding(),
20657 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20659 (AdditionResult): Make this nested in DeclSpace.
20660 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20661 argument; call NamespaceEntry.Define() unless we're nested in a
20664 * namespace.cs (Namespace.DefineName): New public function. This
20665 is called from DeclSpace's .ctor to add
20666 (Namespace.Lookup): Include DeclSpaces in the lookup.
20668 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20670 * const.cs (Const): Derive from MemberBase, not MemberCore.
20672 2003-08-25 Martin Baulig <martin@ximian.com>
20674 * convert.cs (Convert.ExplicitReferenceConversion): When
20675 converting from an interface type to a class, unbox if the target
20676 type is a struct type. Fixes #47822.
20678 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20680 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20683 2003-08-22 Martin Baulig <martin@ximian.com>
20685 * class.cs (TypeManager.DefineType): When defining a nested type,
20686 call DefineType() on our parent; fixes #47801.
20688 2003-08-22 Martin Baulig <martin@ximian.com>
20690 * class.cs (MethodData.Define): While checking if a method is an
20691 interface implementation, improve the test a bit more to fix #47654.
20693 2003-08-22 Martin Baulig <martin@ximian.com>
20695 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20696 correctly; fixes #47722.
20698 2003-08-22 Martin Baulig <martin@ximian.com>
20700 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20701 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20703 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20705 2003-08-22 Martin Baulig <martin@ximian.com>
20707 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20708 can only be assigned in static constructors. Fixes #47161.
20710 2003-08-22 Martin Baulig <martin@ximian.com>
20712 Rewrote and improved the flow analysis code.
20714 * flowbranching.cs (FlowBranching): Make this class abstract.
20715 (FlowBranching.CreateBranching): New static function to create a
20716 new flow branching.
20717 (FlowBranchingBlock, FlowBranchingException): New classes.
20718 (FlowBranching.UsageVector.Type): New public readonly field.
20719 (FlowBranching.UsageVector.Breaks): Removed the setter.
20720 (FlowBranching.UsageVector.Returns): Removed the setter.
20721 (FlowBranching.UsageVector): Added Break(), Return(),
20722 NeverReachable() and Throw() methods to modify the reachability.
20723 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20724 done by FlowBranching.Merge().
20725 (FlowBranching.UsageVector.MergeChild): New method; merges the
20726 merge result into the current vector.
20727 (FlowBranching.Merge): New abstract method to merge a branching.
20729 2003-08-12 Martin Baulig <martin@ximian.com>
20731 * expression.cs (Indirection.CacheTemporaries): Create the
20732 LocalTemporary with the pointer type, not its element type.
20734 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20736 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20737 token was a keyword or not.
20739 Add `error' options where an IDENTIFIER was expected; Provide
20740 CheckToken and CheckIdentifierToken convenience error reporting
20743 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20745 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20746 NameSpaceEntry NameSpaceEntry.
20748 (LookupInterfaceOrClass): Avoid creating a full qualified name
20749 from namespace and name: avoid doing lookups when we know the
20750 namespace is non-existant. Use new Tree.LookupByNamespace which
20751 looks up DeclSpaces based on their namespace, name pair.
20753 * driver.cs: Provide a new `parser verbose' to display the
20754 exception thrown during parsing. This is turned off by default
20755 now, so the output of a failure from mcs is more graceful.
20757 * namespace.cs: Track all the namespaces defined in a hashtable
20760 (IsNamespace): New method
20762 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20764 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20765 we know that we need to concatenate (full typename can never be
20770 * statement.cs: Use a bitfield; Do not initialize to null things
20771 which are done by the constructor by default.
20773 * cs-parser.jay: bug fix, parameter was 4, not 3.
20775 * expression.cs: Just use the property;
20777 * statement.cs: No need for GetVariableInfo method.
20779 2003-08-08 Martin Baulig <martin@ximian.com>
20781 * flowanalysis.cs (FlowReturns): This is now nested in the
20782 `FlowBranching' class.
20783 (MyBitVector): Moved this here from statement.cs.
20784 (FlowBranching.SiblingType): New enum type.
20785 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20787 2003-08-07 Martin Baulig <martin@ximian.com>
20789 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20790 `FlowBranching' class and called `BranchingType'.
20792 2003-08-07 Martin Baulig <martin@ximian.com>
20794 * flowanalysis.cs: Moved all the control flow analysis code into
20797 2003-08-07 Martin Baulig <martin@ximian.com>
20799 * assign.cs (Assign.DoResolve): `target' must either be an
20800 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20803 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20805 * expression.cs (BinaryMethod): This kind of expression is created by the
20806 Binary class if it determines that the operator has to be handled
20809 (BinaryDelegate): This kind of expression is created if we are
20810 dealing with a + or - operator on delegates.
20812 (Binary): remove method, argumetns, and DelegateOperator: when
20813 dealing with methods,
20815 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20817 * statement.cs (Block): use bitfields for the three extra booleans
20818 we had in use. Remove unused topblock parameter.
20820 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20822 * assign.cs: Drop extra unneeded tests.
20824 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20826 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20828 * statement.cs (Foreach): Use VariableStorage instead of
20831 * codegen.cs (VariableStorage): New class used by clients that
20832 require a variable stored: locals or fields for variables that
20833 need to live across yield.
20835 Maybe provide a convenience api for EmitThis+EmitLoad?
20837 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20840 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20842 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20843 RemapParameterLValue): New methods that are used to turn a
20844 precomputed FieldInfo into an expression like this:
20848 The idea is to use this instead of making LocalVariableReference
20849 have more than one meaning.
20851 * cs-parser.jay: Add error production to BASE.
20853 * ecore.cs: Deal with TypeManager.GetField returning null, which
20854 is now a valid return value.
20856 (FieldExprNoAddress): New expression for Fields whose address can
20859 * expression.cs (LocalVariableReference): During the resolve
20860 phases, create new expressions if we are in a remapping context.
20861 Remove code that dealt with remapping here.
20863 (ParameterReference): same.
20865 (ProxyInstance): New expression, like the `This' expression, but
20866 it is born fully resolved. We know what we are doing, so remove
20867 the errors that are targeted to user-provided uses of `this'.
20869 * statement.cs (Foreach): our variable is now stored as an
20870 Expression; During resolution, follow the protocol, dont just
20871 assume it will return this.
20873 2003-08-06 Martin Baulig <martin@ximian.com>
20875 * support.cs (SeekableStreamReader.cs): New public class.
20877 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20878 SeekableStreamReader instead of the normal StreamReader.
20880 2003-08-04 Martin Baulig <martin@ximian.com>
20882 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20883 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20884 deambiguate casts and delegate invocations.
20885 (parenthesized_expression): Use the new tokens to ensure this is
20886 not a cast of method invocation.
20888 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20889 when reading a `)' and Deambiguate_CloseParens () was previously
20892 * expression.cs (ParenthesizedExpression): New class. This is
20893 just used for the CS0075 test.
20894 (Binary.DoResolve): Check for CS0075.
20896 2003-07-29 Ravi Pratap <ravi@ximian.com>
20898 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20899 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20900 reference comparison.
20902 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20903 examine the ReturnType for equality - this is necessary in the
20904 cases of implicit and explicit operators whose signature also
20905 includes the return type.
20907 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20909 * namespace.cs: Cache the result of the namespace computation,
20910 instead of computing it every time.
20912 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20914 * decl.cs: Use a global arraylist that we reuse over invocations
20915 to avoid excesive memory consumption. Reduces memory usage on an
20916 mcs compile by one meg (45 average).
20918 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20919 private, work around that.
20921 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20923 * literal.cs (IntLiteral): Define Zero and One static literals.
20925 * cs-parser.jay (integer_literal): use static literals to reduce
20926 memory usage for the most used literals (0, 1 and -1). 211kb
20927 reduced in memory usage.
20929 Replace all calls to `new ArrayList' with `new
20930 ArrayList(4)' which is a good average number for most allocations,
20931 and also requires only 16 bytes of memory for its buffer by
20934 This reduced MCS memory usage in seven megabytes for the RSS after
20937 2003-07-28 Ravi Pratap <ravi@ximian.com>
20939 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20940 handle params methods the correct way by forming only one
20941 applicable set with params and normal methods in them. Earlier we
20942 were looking at params methods only if we found no normal methods
20943 which was not the correct thing to do.
20945 (Invocation.BetterFunction): Take separate arguments indicating
20946 when candidate and the best method are params methods in their
20949 This fixes bugs #43367 and #46199.
20951 * attribute.cs: Documentation updates.
20953 (CheckAttribute): Rename to CheckAttributeTarget.
20954 (GetValidPlaces): Rename to GetValidTargets.
20956 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20957 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20961 2003-07-28 Martin Baulig <martin@ximian.com>
20963 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20964 name when looking up the base class of a nested class. Fixes #46977.
20966 2003-07-26 Martin Baulig <martin@ximian.com>
20968 * expression.cs (Indexers.Indexer): New nested struct; contains
20969 getter, setter and the indexer's type.
20970 (Indexers.Properties): This is now an ArrayList of
20971 Indexers.Indexer's.
20972 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20973 indexer doesn't have any getters.
20975 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20976 for embedded property and indexer assignments.
20978 2003-07-26 Martin Baulig <martin@ximian.com>
20980 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20981 preprocessor directive is not the first non-whitespace character
20984 2003-07-26 Martin Baulig <martin@ximian.com>
20986 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20987 namespace parsing, follow the spec more closely.
20989 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20990 NamespaceEntry.Lookup().
20992 2003-07-25 Martin Baulig <martin@ximian.com>
20994 * MethodCore.cs (OverridesSomething): New public field; it's set
20995 from TypeContainer.DefineMembers if this method overrides
20996 something (which doesn't need to be a method). Fix #39462.
20998 2003-07-25 Ravi Pratap <ravi@ximian.com>
21000 * typemanager.cs (GetMembers): Ensure that the list of members is
21001 reversed. This keeps things in sync.
21003 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21004 find an AttributeUsage attribute.
21006 * expression.cs (Invocation.OverloadResolve): Perform the check
21007 which disallows Invoke to be directly called on a Delegate.
21009 (Error_InvokeOnDelegate): Report error cs1533.
21011 2003-07-25 Martin Baulig <martin@ximian.com>
21013 * expression.cs (Indexers.GetIndexersForType): Only look in the
21014 interface hierarchy if the requested type is already an
21015 interface. Fixes #46788 while keeping #46502 fixed.
21017 2003-07-25 Martin Baulig <martin@ximian.com>
21019 * class.cs (TypeContainer.DefineMembers): Check whether all
21020 readonly fields have been assigned and report warning CS0649 if
21023 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21026 2003-07-24 Ravi Pratap <ravi@ximian.com>
21028 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21029 returned from GetMethods to make things consistent with the
21030 assumptions MCS makes about ordering of methods.
21032 This should comprehensively fix bug #45127 and it does :-)
21034 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21035 ordering is actually reverse.
21037 * Clean up some debug messages I left lying around.
21039 * interface.cs (Populate*): Get rid of code which emits attributes
21040 since the stage in which we emit attributes is the 'Emit' stage,
21041 not the define stage.
21043 (Emit): Move attribute emission for interface members here.
21045 2003-07-22 Ravi Pratap <ravi@ximian.com>
21047 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21048 closely: we eliminate methods in base types when we have an
21049 applicable method in a top-level type.
21051 Please see section 14.5.5.1 for an exact description of what goes
21054 This fixes bug #45127 and a host of other related to corlib compilation.
21056 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21057 array is the method corresponding to the top-level type (this is
21058 because of the changes made to icall.c) so we change this
21061 (MethodGroupExpr.Name): This too.
21063 * typemanager.cs (GetElementType): New method which does the right
21064 thing when compiling corlib.
21066 * everywhere: Make use of the above in the relevant places.
21068 2003-07-22 Martin Baulig <martin@ximian.com>
21070 * cs-parser.jay (invocation_expression): Moved
21071 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21072 `cast_expression', but create a InvocationOrCast which later
21073 resolves to either an Invocation or a Cast.
21075 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21076 method; call this before EmitStatement() to make sure that this
21077 expression can be used as a statement.
21079 * expression.cs (InvocationOrCast): New class; resolves to either
21080 an Invocation or a Cast.
21082 * statement.cs (StatementExpression): Call ResolveStatement() on
21083 the ExpressionStatement before emitting it.
21085 2003-07-21 Martin Baulig <martin@ximian.com>
21087 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21088 `ref' and `out' attributes match; fixes #46220.
21089 (MemberAccess.ResolveMemberAccess): You can't reference a type
21090 through an expression; fixes #33180.
21091 (Indexers.GetIndexersForType): Don't return the indexers from
21092 interfaces the class implements; fixes #46502.
21094 2003-07-21 Martin Baulig <martin@ximian.com>
21096 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21097 CS0661 checks; fixes bug #30442.
21099 2003-07-21 Martin Baulig <martin@ximian.com>
21101 * decl.cs (AdditionResult): Added `Error'.
21103 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21105 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21106 makes cs0031.cs actually work.
21108 2003-07-20 Martin Baulig <martin@ximian.com>
21110 * namespace.cs: Fixed that bug which caused a crash when compiling
21111 the debugger's GUI.
21113 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21115 * typemanager.cs (LookupTypeReflection): Never expose types which
21116 are NotPublic, NestedPrivate, NestedAssembly, or
21117 NestedFamANDAssem. We used to return these, and later do a check
21118 that would report a meaningful error, but the problem is that we
21119 would not get the real match, if there was a name override.
21121 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21123 * namespace.cs (Namespace, Name): Do not compute the namespace
21124 name dynamically, compute it in the constructor. This reduced
21125 memory usage by 1697 KB.
21127 * driver.cs: Use --pause to pause at the end.
21129 2003-07-17 Peter Williams <peter@newton.cx>
21131 * Makefile: Change the name of the test target so that it doesn't
21132 conflict with the recursive test target.
21134 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21136 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21137 AddressOf): Do not use EmitThis, that was wrong, use the actual
21140 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21142 * class.cs (MethodData.Define): While checking if a method is an
21143 interface implementation, improve the test: If we are not public
21144 (use new test here: use the computed MethodAttributes directly,
21145 instead of the parsed modifier flags) check if the `implementing'
21146 method comes from an interface or not.
21148 * pending.cs (VerifyPendingMethods): Slightly better error
21151 * makefile: add test target that does the mcs bootstrap.
21153 2003-07-16 Ravi Pratap <ravi@ximian.com>
21155 * interface.cs (Define): Do nothing here since there are no
21156 members to populate etc. Move the attribute emission out of here
21157 since this was just totally the wrong place to put it. Attribute
21158 application happens during the 'Emit' phase, not in the 'Define'
21161 (Emit): Add this method and move the attribute emission here
21163 * rootcontext.cs (EmitCode): Call the Emit method on interface
21166 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21168 * expression.cs (OverloadResolve): Report error only if Location
21169 is not 'Null' which means that there was a probe going on.
21171 2003-07-14 Martin Baulig <martin@ximian.com>
21173 * expression.cs (ConditionalLogicalOperator): New public class to
21174 implement user defined conditional logical operators.
21175 This is section 14.11.2 in the spec and bug #40505.
21177 2003-07-14 Martin Baulig <martin@ximian.com>
21179 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21181 2003-07-14 Martin Baulig <martin@ximian.com>
21183 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21185 * ecore.cs (IVariable.VerifyFixed): New interface method.
21187 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21188 operator, check whether the variable is actually fixed. Fixes bug
21189 #36055. Set a variable definitely assigned when taking its
21190 address as required by the spec.
21192 * statement.cs (LocalInfo.IsFixed): New field.
21193 (LocalInfo.MakePinned): Set `IsFixed' to true.
21195 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21197 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21198 for .ctors, ensure that we only ask for members declared in the
21199 attribute type (BindingFlags.DeclaredOnly).
21203 * expression.cs (Error_WrongNumArguments): Report error 1501
21204 correctly the way CSC does.
21206 2003-07-13 Martin Baulig <martin@ximian.com>
21208 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21209 lookup on the fully qualified name, to make things like "X.X" work
21210 where "X.X" is a fully qualified type name, but we also have a
21211 namespace "X" in the using list. Fixes #41975.
21213 2003-07-13 Martin Baulig <martin@ximian.com>
21215 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21216 function. If we're a CompoundAssign, we need to create an embedded
21217 CompoundAssign, not an embedded Assign.
21218 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21221 2003-07-13 Martin Baulig <martin@ximian.com>
21223 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21224 work to fix bug #46088.
21226 2003-07-13 Ravi Pratap <ravi@ximian.com>
21228 * class.cs (Operator.Emit): Do not emit attributes here - it is
21229 taken care of by the Method class that we delegate too. This takes
21230 care of bug #45876.
21232 2003-07-10 Martin Baulig <martin@ximian.com>
21234 * expression.cs (TypeOfVoid): New class.
21235 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21237 2003-07-10 Martin Baulig <martin@ximian.com>
21239 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21242 2003-07-10 Martin Baulig <martin@ximian.com>
21244 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21245 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21247 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21249 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21251 2003-07-10 Martin Baulig <martin@ximian.com>
21253 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21254 of decimal. Fixes #42850.
21256 NOTE: I also fixed the created byte blob, but this doesn't work on
21257 the MS runtime and csc never produces any byte blobs for decimal
21260 2003-07-10 Martin Baulig <martin@ximian.com>
21262 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21263 structs; fixes #32068.
21264 (Block.AddChildVariableNames): Fixed #44302.
21266 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21268 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21270 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21272 * attribute.cs: And this test is onger needed.
21274 2003-07-08 Martin Baulig <martin@ximian.com>
21276 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21277 inaccessible types. Fixes #36313.
21279 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21281 * namespace.cs (NamespaceEntry): Create implicit entries for all
21282 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21283 implicit entries for N1.N2 and N1.
21285 2003-07-08 Martin Baulig <martin@ximian.com>
21287 Rewrote the handling of namespaces to fix a lot of the issues
21288 wrt. `using' aliases etc.
21290 * namespace.cs (Namespace): Splitted this class into a
21291 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21293 * typemanager.cs (TypeManager.IsNamespace): Removed.
21294 (TypeManager.ComputeNamespaces): Only compute namespaces from
21295 loaded assemblies here, not the namespaces from the assembly we're
21296 currently compiling.
21298 2003-07-08 Martin Baulig <martin@ximian.com>
21300 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21302 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21304 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21307 I thought about the memory savings here, but LookupTypeReflection
21308 is used under already very constrained scenarios. Compiling
21309 corlib or mcs only exposes one hit, so it would not really reduce
21310 any memory consumption.
21312 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21314 * typemanager.cs: fixes bug #45889 by only adding public types from
21315 other assemblies to the list of known types.
21317 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21319 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21320 on the type we resolved.
21322 2003-07-05 Martin Baulig <martin@ximian.com>
21324 * pending.cs (PendingImplementation.ParentImplements): Don't
21325 create the proxy if the parent is abstract.
21327 * class.cs (TypeContainer.DefineIndexers): Process explicit
21328 interface implementations first. Fixes #37714.
21330 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21332 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21333 defined recursively; but since we modify the input parameters
21334 (left is set to `this' temporarily), we reset this value if the
21335 left_is_explicit is false, which gives the original semantics to
21338 * literal.cs (NullPointer): new class used to represent a null
21339 literal in a pointer context.
21341 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21342 type is a pointer, use a NullPointer object instead of a
21343 NullLiteral. Closes 43687
21345 (ExplicitConversion): Convert pointer values using
21346 the conv opcode to the proper type.
21348 * ecore.cs (New): change ValueTypeVariable property into a method,
21349 that returns whether the valuetype is suitable for being used.
21351 * expression.cs (Binary.DoNumericPromotions): Only return if we
21352 the int constant was a valid uint, and we can return both left and
21353 right as uints. If not, we continue processing, to trigger the
21354 type conversion. This fixes 39018.
21356 * statement.cs (Block.EmitMeta): During constant resolution, set
21357 the CurrentBlock property on the emitcontext, so that we resolve
21358 constants propertly.
21360 2003-07-02 Martin Baulig <martin@ximian.com>
21362 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21363 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21365 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21366 than emitting it here.
21368 * statement.cs: Fixed some more flow analysis bugs.
21370 2003-07-02 Martin Baulig <martin@ximian.com>
21372 * class.cs (MethodData.Define): When implementing interface
21373 methods, set Final unless we're Virtual.
21375 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21376 check work for interface methods.
21378 2003-07-01 Martin Baulig <martin@ximian.com>
21380 * ecore.cs (EmitContext.This): Replaced this property with a
21381 GetThis() method which takes a Location argument. This ensures
21382 that we get the correct error location for a CS0188.
21384 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21386 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21387 ImplicitStandardConversion.
21389 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21391 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21393 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21396 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21398 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21401 (MethodData.Define): Turn off initlocals for unsafe methods.
21403 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21405 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21406 complete; Fixes #37521.
21408 * delegate.cs: Use Modifiers.TypeAttr to compute the
21409 TypeAttributes, instead of rolling our own. This makes the flags
21410 correct for the delegates.
21412 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21414 * class.cs (Constructor.Define): Set the private flag for static
21415 constructors as well.
21417 * cs-parser.jay (statement_expression): Set the return value to
21418 null, to avoid a crash when we catch an error.
21420 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21422 * cs-parser.jay: Applied patch from Jackson that adds support for
21423 extern and unsafe modifiers to destructor declarations.
21425 * expression.cs: Report error 21 if the user is trying to index a
21428 * driver.cs: Add an error message, suggested by the bug report.
21430 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21431 if we do not have a ": this ()" constructor initializer. Fixes 45149
21433 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21435 * namespace.cs: Add some information to reduce FAQs.
21437 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21439 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21440 underlying enumeration types. Fixes #43915.
21442 * expression.cs: Treat ushort/short as legal values to be used in
21443 bitwise operations.
21445 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21447 * delegate.cs: transfer custom attributes for paramenters from
21448 the delegate declaration to Invoke and BeginInvoke.
21450 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21452 * attribute.cs: handle custom marshalers and emit marshal info
21455 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21457 * makefile.gnu: Added anonymous.cs to the compiler sources.
21459 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21461 * iterators.cs: Change the name of the proxy class to include two
21464 * cs-parser.jay: Update grammar to include anonymous methods.
21466 * anonymous.cs: new file.
21468 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21470 * class.cs (Field.Define): Add missing test for pointers and
21473 2003-05-27 Ravi Pratap <ravi@ximian.com>
21475 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21476 we use the stobj opcode.
21478 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21479 since it wasn't the correct fix.
21481 It still is puzzling that we are required to use stobj for IntPtr
21482 which seems to be a ValueType.
21484 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21486 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21487 during regular simple name resolution. Now, the trick is that
21488 instead of returning for processing the simplename, we do a
21489 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21490 contextual lookup type). If a match is found, return that, if
21491 not, return for further composition.
21493 This fixes long-standing 30485.
21495 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21496 using the address to initialize an object, do an Stobj instead of
21497 using the regular Stelem.
21499 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21500 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21501 Because if we are a BaseIndexerAccess that value will be true.
21504 * statement.cs (GotoCase.Resolve): Return after reporting an
21505 error, do not attempt to continue.
21507 * expression.cs (PointerArithmetic.Emit): If our operand is a
21508 long, convert our constants to match the operand before
21509 multiplying. Convert to I type before adding. Fixes 43670.
21511 2003-05-14 Ravi Pratap <ravi@ximian.com>
21513 * enum.cs (ImplicitConversionExists) : Rename to
21514 ImplicitEnumConversionExists to remove ambiguity.
21516 * ecore.cs (NullCast): New type of cast expression class which
21517 basically is very similar to EmptyCast with the difference being
21518 it still is a constant since it is used only to cast a null to
21520 (eg. (string) null)
21522 * convert.cs (ImplicitReferenceConversion): When casting a null
21523 literal, we return a NullCast.
21525 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21526 should be around anymore.
21528 The renaming (reported was slightly wrong). Corrections:
21530 ConvertImplicitStandard -> ImplicitConversionStandard
21531 ConvertExplicitStandard -> ExplicitConversionStandard
21533 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21534 before passing them in !
21536 * convert.cs (ImplicitConversionStandard): When comparing for
21537 equal expr and target types, ensure that expr is not a
21540 In general, we must not be checking (expr_type ==
21541 target_type) in the top level conversion methods
21542 (ImplicitConversion, ExplicitConversion etc). This checking is
21543 done in the methods that they delegate to.
21545 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21547 * convert.cs: Move Error_CannotConvertType,
21548 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21549 ImplicitNumericConversion, ImplicitConversionExists,
21550 ImplicitUserConversionExists, StandardConversionExists,
21551 FindMostEncompassedType, FindMostSpecificSource,
21552 FindMostSpecificTarget, ImplicitUserConversion,
21553 ExplicitUserConversion, GetConversionOperators,
21554 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21555 TryImplicitIntConversion, Error_CannotConvertImplicit,
21556 ConvertImplicitRequired, ConvertNumericExplicit,
21557 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21558 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21561 Perform the following renames:
21563 StandardConversionExists -> ImplicitStandardConversionExists
21564 ConvertImplicit -> ImplicitConversion
21565 ConvertImplicitStandard -> ImplicitStandardConversion
21566 TryImplicitIntConversion -> ImplicitIntConversion
21567 ConvertImplicitRequired -> ImplicitConversionRequired
21568 ConvertNumericExplicit -> ExplicitNumericConversion
21569 ConvertReferenceExplicit -> ExplicitReferenceConversion
21570 ConvertExplicit -> ExplicitConversion
21571 ConvertExplicitStandard -> ExplicitStandardConversion
21573 2003-05-19 Martin Baulig <martin@ximian.com>
21575 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21576 (TypeInfo): Added support for structs having structs as fields.
21578 * ecore.cs (FieldExpr): Implement IVariable.
21579 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21580 VariableInfo for the field.
21582 2003-05-18 Martin Baulig <martin@ximian.com>
21584 * expression.cs (This.DoResolve): Report a CS0027 if we're
21585 emitting a field initializer.
21587 2003-05-18 Martin Baulig <martin@ximian.com>
21589 * expression.cs (This.ResolveBase): New public function.
21590 (This.DoResolve): Check for CS0188.
21592 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21595 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21596 `instance_expression' to null if we don't have any non-static
21599 2003-05-18 Martin Baulig <martin@ximian.com>
21601 Reworked the way how local variables and parameters are handled by
21602 the flow analysis code.
21604 * statement.cs (TypeInfo, VariableMap): New public classes.
21605 (VariableInfo): New public class. This is now responsible for
21606 checking whether a variable has been assigned. It is used for
21607 parameters and local variables.
21608 (Block.EmitMeta): Take the InternalParameters as argument; compute
21609 the layout of the flow vectors here.
21610 (Block.LocalMap, Block.ParameterMap): New public properties.
21611 (FlowBranching): The .ctor doesn't get the InternalParameters
21612 anymore since Block.EmitMeta() now computes the layout of the flow
21614 (MyStructInfo): This class is now known as `StructInfo' and nested
21615 in `TypeInfo'; we don't access this directly anymore.
21617 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21618 property and removed IsAssigned(), IsFieldAssigned(),
21619 SetAssigned() and SetFieldAssigned(); we now call them on the
21620 VariableInfo so we don't need to duplicate this code everywhere.
21622 * expression.cs (ParameterReference): Added `Block block' argument
21624 (LocalVariableReference, ParameterReference, This): The new
21625 VariableInfo class is now responsible for all the definite
21628 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21629 IsParameterAssigned, SetParameterAssigned): Removed.
21631 2003-05-18 Martin Baulig <martin@ximian.com>
21633 * typemanager.cs (InitCoreTypes): Try calling
21634 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21635 the 3-args-version. Corlib now also needs our `void_type'.
21636 (GetMethod): Added overloaded version which takes an optional
21637 `bool report_errors' to allow lookups of optional methods.
21639 2003-05-12 Martin Baulig <martin@ximian.com>
21641 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21642 only used for locals and not for parameters.
21644 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21646 * support.cs (InternalParameters.ParameterType): Return the
21647 ExternalType of the parameter.
21649 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21652 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21654 * class.cs (MethodData.Define): Do not set the `newslot' on
21655 interface members, if they are also flagged as "override".
21657 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21658 better code for ++i and i++. This only works for static fields
21659 and local variables.
21661 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21662 want to pull the DeclSpace out of the builder_to_declspace instead
21663 of the TypeBuilder (like in TypeContainer.FindMembers).
21665 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21666 instead of LookupTypeContainer. Fixes the crash on .NET for
21667 looking up interface members.
21669 * const.cs: Create our own emit context during the Definition
21670 stage, so that constants are evaluated in the proper context, when
21671 a recursive definition happens.
21673 2003-05-11 Martin Baulig <martin@ximian.com>
21675 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21676 new block for a switch section.
21677 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21678 the adding/lookup in the switch block. Fixes #39828.
21680 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21682 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21683 functionality: I needed to convert the data after I had performed
21684 the add/sub operation into the operands type size.
21686 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21687 pass the type for the box operation, otherwise the resulting
21688 object would have been of type object.
21690 (BoxedCast): Add constructor to specify the type to box as.
21692 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21694 * iterators.cs: I was reusing the `count' variable inadvertently,
21695 take steps to not allow this to happen.
21697 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21699 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21700 by creating an array at the point where the params starts and
21701 putting all those arguments there, then adjusting the size of the
21704 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21706 * expression.cs (New.AddressOf): Implement interface
21707 IMemoryLocation. This is used when the `new' operator is used in
21708 the context of an invocation to a method on a value type.
21710 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21713 * namespace.cs: Also check the using aliases here.
21715 * driver.cs: Move the test for using validity after the types have
21716 been entered, so we do a single pass that also includes the using
21719 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21720 in the regular case. CreateSiblingForFinally is doing extra
21723 * attribute.cs (GetAttributeArgumentExpression): Store the result
21724 on an out value, and use the return value to indicate failure
21725 instead of using null (which is a valid return for Constant.GetValue).
21727 * statement.cs: Perform the analysis flow for the increment
21728 portion after the statement, because this will be the real flow of
21729 execution. Fixes #42385
21731 * codegen.cs (EmitContext.EmitArgument,
21732 EmitContext.EmitStoreArgument): New helper functions when the
21733 RemapToProxy flag is set.
21735 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21738 Add support for remapping parameters.
21740 * iterators.cs: Propagate parameter values; Store parameter
21741 values in the proxy classes.
21743 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21745 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21746 need a proxy reference; I do not know what I was thinking
21748 * cs-parser.jay (constructor_initializer): catch another error,
21749 and display nice message.
21751 (field_declaration): catch void field declaration
21752 to flag a better error.
21754 * class.cs (MemberBase.CheckBase): Report an error instead of a
21755 warning if a new protected member is declared in a struct.
21756 (Field.Define): catch the error of readonly/volatile.
21758 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21760 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21761 volatile variable is taken
21763 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21765 * statement.cs (Fixed.Resolve): Report an error if we are not in
21768 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21770 * typemanager.cs: reuse the code that handles type clashes for
21771 delegates and enumerations.
21773 * class.cs (Report28): Always report.
21775 * expression.cs (EncodeAsAttribute): Allow nulls here.
21777 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21779 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21780 the functionality for testing whether an expression is valid for
21781 an attribute here. Also handle the case of arrays of elements
21784 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21785 encoding a linear array into an array of objects that are suitable
21786 to be passed to an CustomAttributeBuilder.
21788 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21790 * ecore.cs: (FieldExpr): Handle field remapping here.
21792 * iteratators.cs: Pass the instance variable (if the method is an
21793 instance method) to the constructors, so we can access the field
21794 variables on the class.
21796 TODO: Test this with structs. I think the THIS variable on
21797 structs might have to be a pointer, and not a refenrece
21799 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21801 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21802 local variables to fields in a proxy class.
21804 * iterators.cs (PopulateProxy): Rename our internal fields to
21806 Create a <THIS> field if we are an instance method, so we can
21807 reference our parent container variables.
21808 (MapVariable): Called back from the EmitContext code to enter a
21809 new variable to field mapping into the proxy class (we just create
21813 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21814 for using the remapped locals to fields.
21816 I placed the code here, because that gives the same semantics to
21817 local variables, and only changes the Emit code.
21819 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21820 statements inside iterators.
21821 (VariableInfo): Add a FieldBuilder for the cases when we are
21822 remapping local variables to fields in a proxy class
21824 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21825 current_block != null.
21827 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21828 not cope with strings, as it has been moved to the
21829 TableSwitchEmit. Fixed bug in switch generation.
21831 * expression.cs (New.DoResolve): Provide more context for the user
21832 when reporting an error.
21834 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21837 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21838 check the permissions for it. Note than in a type-resolution
21839 context the check was already present in DeclSpace.ResolveType,
21840 but was missing from the MemberAccess.
21842 (ArrayCreation.CheckIndices): warn if the user has
21843 more nested levels of expressions, but there are no more
21844 dimensions specified. Avoids crash on bug 41906.
21846 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21848 * statement.cs (Block): replace Implicit bool, for a generic
21850 New flag: `Unchecked'. This is used during the EmitMeta phase
21851 (which is out-of-line with the regular Resolve/Emit process for a
21852 statement, as this is done ahead of time, but still gets a chance
21853 to call constant resolve).
21855 (Block.Flags): new enum for adding a new flag.
21857 (Block.EmitMeta): track the state of unchecked.
21859 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21860 to enable constant resolution to work there as well.
21862 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21864 * typemanager.cs (ienumerable_type): Also look up
21865 System.Collections.IEnumerable.
21867 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21869 TODO: Test more than one conditional per method.
21871 * class.cs (Indexer.Define): Report the location where the user is
21872 referencing the unsupported feature.
21874 (MethodData): Overload the use of `conditionals' to
21875 minimize the creation of needless ArrayLists. This saves roughly
21876 212kb on my machine.
21878 (Method): Implement the new IIteratorContainer interface.
21879 (Method.SetYields): Implement the method by setting the ModFlags
21880 to contain METHOD_YIELDS.
21882 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21883 which just got set to null.
21885 * iterators.cs: New file.
21887 (Yield, YieldBreak): New statements.
21889 * statement.cs (Return.Resolve): Flag an error if we are used in
21890 an iterator method.
21892 * codegen.cs (InIterator): New flag set if the code is being
21893 compiled in an iterator method.
21895 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21896 internal modifier, and we just use it to avoid adding extra
21897 fields, as this is seldom used.
21899 * cs-parser.jay: Add yield_statement (yield and yield break).
21901 * driver.cs: New flag -v2 to turn on version 2 features.
21903 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21904 hashtable when v2 is enabled.
21906 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21908 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21909 there is already a namespace defined with this name.
21911 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21912 people upgraded their corlibs.
21914 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21915 always use fully qualified types, no need to use the compiler
21918 (TypeManager.IsNamespace): Use binarysearch.
21920 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21921 AddDelegate): I did not quite use the new IsValid API properly: I
21922 have to pass the short-name and the fullname. I was passing only
21923 the basename instead of the fullname sometimes.
21925 (TypeContainer.DefineType): call NamespaceClash.
21927 * interface.cs (Interface.DefineType): use NamespaceClash before
21930 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21933 * enum.cs: (Enum.DefineType): use NamespaceClash before
21936 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21937 speed increase. First, use the negative_hits cache when we get a
21938 negative. Second, add the type with its full original name
21939 instead of the new . and + encoded name (reflection uses + to
21940 separate type from a nested type). Use LookupTypeReflection
21941 directly which bypasses the type->name hashtable (that we already
21942 know does not contain the type.
21944 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21945 location/container type.
21947 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21949 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21951 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21953 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21954 method is being referenced in the method group from a static
21955 context, and report error 120 if so.
21957 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21960 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21961 is created, we create the A namespace).
21963 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21966 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21968 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21969 invocation to ModuleBuilder.GetType with the same values will
21970 return a new type instance, so we need to cache its return
21973 * expression.cs (Binary.ResolveOperator): Only allow the compare
21974 operators on enums if they are of the same type.
21976 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21977 types of ValueType on their own case. Before we were giving them
21978 the same treatment as objects.
21980 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21981 fullname. Short name is used to compare against container name.
21982 Fullname is used to check against defined namespace names.
21984 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21985 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21987 (Method.CheckBase): Call parent.
21988 (MemberBase.CheckBase): Check for protected members on sealed
21990 (PropertyBase.CheckBase): Call parent.
21991 (Field.Define): Call parent.
21993 * report.cs: Negative error codes are now mapped to 8000 - code,
21994 so that the display is render more nicely.
21996 * typemanager.cs: Do not use try/catch, instead report a regular
21999 (GetPointerType, GetReferenceType): These methods provide
22000 mechanisms to obtain the T* and T& from a T. We had the code
22001 previously scattered around the code base, and it also used
22002 TypeManager.LookupType that would go through plenty of caches.
22003 This one goes directly to the type source.
22005 In some places we did the Type.GetType followed by
22006 ModuleBuilder.GetType, but not in others, so this unifies the
22007 processing as well.
22009 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22010 statements now that we have namespace information.
22012 * typemanager.cs (IsNamespace): New method, returns whether the
22013 string presented is a namespace or not.
22015 (ComputeNamespaces): New public entry point, computes the list of
22016 available namespaces, using the GetNamespaces API call in Mono, or
22017 the slower version in MS.NET.
22019 Now before we start the semantic analysis phase, we have a
22020 complete list of namespaces including everything that the user has
22023 Deleted old code to cache namespaces in .nsc files.
22025 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22027 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22028 class/struct location definition Location for the implicit
22029 constructor location.
22031 (Operator.Define): Use the location of the operator for the
22032 implicit Method definition.
22034 (Constructor.Emit): use the constructor location for the implicit
22035 base initializer constructor.
22037 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22038 and the Expression class now contains two new methods:
22040 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22041 isolate type lookup from the rest of the resolution process.
22043 Since we use Expressions to hold type definitions due to the way
22044 we parse the input we have historically overloaded Resolve to
22045 perform the Type lookups if a special flag is passed. Now this is
22046 eliminated and two methods take their place.
22048 The differences in the two methods between xStep and xTerminal is
22049 that xStep is involved in our current lookup system that uses
22050 SimpleNames to compose a name, while xTerminal is used just to
22051 catch the case where the simplename lookup failed.
22053 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22055 * expression.cs (ResolveMemberAccess): Remove redundant code.
22056 TypeExpr expressions are always born fully resolved.
22058 * interface.cs (PopulateMethod): Do not lookup the types twice.
22059 We were doing it once during SemanticAnalysis and once during
22062 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22063 in local variable type definitions, were being returned as a
22064 SimpleName (we decomposed everything into a string), that is
22065 because primary_expression was being used instead of a type in the
22066 grammar (reduce/reduce conflicts).
22068 The part that was wrong is that we converted the expression into a
22069 string (an oversimplification in one hand, compounded with primary
22070 expressions doing string concatenation).
22076 Would return "A.B.C[]" as a SimpleName. This stopped things like
22077 using clauses from working on this particular context. And a type
22078 was being matched directly against "A.B.C[]".
22080 We now use the correct approach, and allow for ComposedCast to be
22081 part of the unary expression. So the "A.B.C []" become a composed
22082 cast of "A.B.C" (as a nested group of MemberAccess with a
22083 SimpleName at the end) plus the rank composition "[]".
22087 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22089 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22090 for the access level checking.
22092 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22093 `TypeContainer container', because I kept getting confused when I
22094 was debugging this code.
22096 * expression.cs (Indexers): Instead of tracking getters/setters,
22097 we now track them in parallel. We create one arraylist less, but
22098 most importantly it is possible now for the LValue code to find a
22099 matching get for a set.
22101 (IndexerAccess.DoResolveLValue): Update the code.
22102 GetIndexersForType has been modified already to extract all the
22103 indexers from a type. The code assumed it did not.
22105 Also make the code set the correct return type for the indexer.
22106 This was fixed a long time ago for properties, but was missing for
22107 indexers. It used to be void_type.
22109 (Binary.Emit): Test first for doubles instead of
22110 floats, as they are more common.
22112 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22113 when dealing with floats and the <=, >= operators. This fixes bug
22116 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22117 to load the array value by emitting a load on the foreach variable
22118 type. This was incorrect.
22120 We now emit the code to load an element using the the array
22121 variable type, and then we emit the conversion operator.
22125 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22127 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22129 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22131 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22132 test for protection before we test for signatures.
22134 (MethodSignature.ToString): implement.
22136 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22137 to the case where we reduced into a LongConstant.
22139 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22140 depend on whether the information is acurrate, because the
22141 Microsoft runtime will always claim that the array type is public,
22142 regardless of the real state.
22144 If the type is a pointer, another problem happens: the type is
22145 reported as non-public in Microsoft.
22147 In both cases we have to call CheckAccessLevel recursively with
22148 the underlying type as the argument to be tested.
22150 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22152 * assign.cs (Assign.Emit): If we are dealing with a compound
22153 assignment expression, we should use the code path that stores the
22154 intermediate result in a temporary value. This fixes #40903.
22156 *expression.cs (Indirection.ToString): Provide ToString method for
22159 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22161 * class.cs: Null out fields holding references to Block objects so
22162 they can be garbage collected.
22164 * expression.cs (OverloadResolve): Remove unused local.
22166 2003-04-07 Martin Baulig <martin@ximian.com>
22168 * codegen.cs (EmitContext.CurrentFile): New public field.
22169 (EmitContext.Mark): Use the CurrentFile to check whether the
22170 location is in the correct file.
22171 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22173 2003-04-07 Martin Baulig <martin@ximian.com>
22175 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22177 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22178 location. [FIXME: The location argument which gets passed to this
22179 method is sometimes wrong!]
22181 2003-04-07 Nick Drochak <ndrochak@gol.com>
22183 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22185 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22187 * expression.cs (Indirection.EmitAssign): We were using the
22188 temporary, but returning immediately instead of continuing the
22191 2003-04-06 Martin Baulig <martin@ximian.com>
22193 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22194 if it's a nested child, but also deriving from the outer class.
22197 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22198 nested child, but also deriving from the outer class. See
22200 (FilterWithClosure): We may access private members of the outer
22201 class if we're a nested child and deriving from the outer class.
22202 (RealMemberLookup): Only set `closure_private_ok' if the
22203 `original_bf' contained BindingFlags.NonPublic.
22205 2003-04-05 Martin Baulig <martin@ximian.com>
22207 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22209 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22211 * class.cs (Event.Define): Do not allow abstract events to have
22214 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22216 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22217 block in event declarations.
22219 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22220 value type, get its address.
22222 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22223 leaving a class on the stack instead of a boolean value (int
22224 0/1). Change the code so we compare against null, and then the
22225 result against zero.
22227 * class.cs (TypeContainer.GetClassBases): We were checking for the
22228 parent class being sealed too late.
22230 * expression.cs (Binary.Emit): For <= and >= when dealing with
22231 floating point values, use cgt.un and clt.un instead of cgt and
22234 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22236 * statement.cs: Apply the same optimization as MS: skip the
22237 GetEnumerator returning an IEnumerator, and use the one returning a
22238 CharEnumerator instead. This allows us to avoid the try-finally block
22241 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22243 * cs-parser.jay: Attributes cannot be applied to
22244 namespaces. Fixes #40473
22246 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22249 (Add*): check if the name is valid using the full name for constants,
22250 fields, properties and events.
22252 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22254 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22255 char constants to be part of the enumeration.
22257 * expression.cs (Conditional.DoResolve): Add support for operator
22258 true. Implements the missing functionality from 14.12
22260 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22261 operator true/false as required by the spec.
22263 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22264 implicit conversion to boolean.
22266 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22267 also one where the type implements `operator true'.
22269 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22270 get an expression that will invoke operator true based on an
22273 (GetConversionOperators): Removed the hack that called op_True
22276 (Expression.ResolveBoolean): Move this from Statement.
22278 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22280 * ecore.cs (FieldExpr): do not allow initialization of initonly
22281 fields on derived classes
22283 2003-03-13 Martin Baulig <martin@ximian.com>
22285 * statement.cs (Block.Emit): Call ig.BeginScope() and
22286 ig.EndScope() when compiling with debugging info; call
22287 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22289 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22291 * expression.cs (Indexers): Do not construct immediately, allow
22292 for new members to be appended as we go. Fixes 38143
22294 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22296 * expression.cs: save/restore context when resolving an unchecked
22299 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22301 * cfold.cs: Catch division by zero in modulus operator during
22304 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22306 * interface.cs (Interface.DefineMembers): Avoid defining members
22309 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22311 * driver.cs: handle the +/- options for -noconfig
22313 * statement.cs (Unckeched.Resolve): Also track the state of
22314 unchecked in the Resolve phase.
22316 2003-02-27 Martin Baulig <martin@ximian.com>
22318 * ecore.cs (Expression.MemberLookup): Don't create a
22319 MethodGroupExpr for something which is not a method. Fixes #38291.
22321 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22323 * class.cs (MemberBase.CheckParameters): Also check that the type
22324 is unmanaged if it is a pointer.
22326 * expression.cs (SizeOf.Resolve): Add location information.
22328 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22329 a managed type is declared.
22331 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22332 parameter modifiers as well. Fixes bug 38606
22334 * class.cs: Very sad. Am backing out the speed up changes
22335 introduced by the ArrayList -> Array in the TypeContainer, as they
22336 were not actually that much faster, and introduced a bug (no error
22337 reports on duplicated methods).
22339 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22340 source first, this will guarantee that we have a valid expression
22341 before calling in lower levels functions that will require a
22342 resolved object. Then use this original_source in the
22343 target.ResolveLValue instead of the original source that was
22346 Another change. Use target.Resolve instead of LValueResolve.
22347 Although we are resolving for LValues, we will let the Assign code
22348 take care of that (it will be called again from Resolve). This
22349 basically allows code like this:
22351 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22352 class Y { void A (X x) { x [0] += o; }
22354 The problem was that the indexer was trying to resolve for
22355 set_Item (idx, object o) and never finding one. The real set_Item
22356 was set_Item (idx, X). By delaying the process we get the right
22361 2003-02-23 Martin Baulig <martin@ximian.com>
22363 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22364 while calling DoEmit ().
22366 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22367 source files; if you use the #line directive inside a method, the
22368 compiler stops emitting line numbers for the debugger until it
22369 reaches the end of the method or another #line directive which
22370 restores the original file.
22372 2003-02-23 Martin Baulig <martin@ximian.com>
22374 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22376 2003-02-23 Martin Baulig <martin@ximian.com>
22378 * statement.cs (Block.AddChildVariableNames): We need to call this
22379 recursively, not just for our immediate children.
22381 2003-02-23 Martin Baulig <martin@ximian.com>
22383 * class.cs (Event.Define): Always make the field private, like csc does.
22385 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22386 actually work, fixes bug #37521.
22388 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22390 * delegate.cs: When creating the various temporary "Parameters"
22391 classes, make sure that we call the ComputeAndDefineParameterTypes
22392 on those new parameters (just like we do with the formal ones), to
22393 allow them to be resolved in the context of the DeclSpace.
22395 This fixes the bug that Dick observed in Bugzilla #38530.
22397 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22399 * expression.cs (ResolveMemberAccess): When resolving a constant,
22400 do not attempt to pull a constant if the value was not able to
22401 generate a valid constant.
22403 * const.cs (LookupConstantValue): Do not report more errors than required.
22405 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22407 * expression.cs: fixes bug #38328.
22409 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22411 * class.cs: Changed all the various members that can be part of a
22412 class from being an ArrayList to be an Array of the right type.
22413 During the DefineType type_list, interface_list, delegate_list and
22414 enum_list are turned into types, interfaces, delegates and enums
22417 And during the member population, indexer_list, event_list,
22418 constant_list, field_list, instance_constructor_list, method_list,
22419 operator_list and property_list are turned into their real arrays.
22421 Although we could probably perform this operation earlier, for
22422 good error reporting we need to keep the lists and remove the
22423 lists for longer than required.
22425 This optimization was triggered by Paolo profiling the compiler
22426 speed on the output of `gen-sample-program.pl' perl script.
22428 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22429 not crash in methods like MemberLookupFailed that use this field.
22431 This problem arises when the compiler fails to resolve a type
22432 during interface type definition for example.
22434 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22436 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22437 inherit from System.Object, so we have to stop at null, not only
22438 when reaching System.Object.
22440 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22442 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22443 DeclaredOnly because the parent indexer might have had a different
22444 name, but did not loop until the top of the hierarchy was reached.
22446 The problem this one fixes is 35492: when a class implemented an
22447 indexer from an interface, we were getting the interface method
22448 (which was abstract) and we were flagging an error (can not invoke
22451 This also keeps bug 33089 functioning, and test-148 functioning.
22453 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22454 out if a method is special is to see if it is declared in a
22455 property or event, or whether it is one of the predefined operator
22456 names. This should fix correctly #36804.
22458 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22460 The goal here is to remove the dependency on EmptyCast.Peel ().
22461 Killing it completely.
22463 The problem is that currently in a number of places where
22464 constants are expected, we have to "probe" for an EmptyCast, and
22465 Peel, which is not the correct thing to do, as this will be
22466 repetitive and will likely lead to errors.
22468 The idea is to remove any EmptyCasts that are used in casts that
22469 can be reduced to constants, so we only have to cope with
22472 This bug hunt was triggered by Bug 37363 and the desire to remove
22473 the duplicate pattern where we were "peeling" emptycasts to check
22474 whether they were constants. Now constants will always be
22477 * ecore.cs: Use an enumconstant here instead of wrapping with
22480 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22481 throwing me off. By handling this we can get rid of a few hacks.
22483 * statement.cs (Switch): Removed Peel() code.
22485 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22487 * class.cs: Location information for error 508
22489 * expression.cs (New.DoResolve): Add a guard against double
22490 resolution of an expression.
22492 The New DoResolve might be called twice when initializing field
22493 expressions (see EmitFieldInitializers, the call to
22494 GetInitializerExpression will perform a resolve on the expression,
22495 and later the assign will trigger another resolution
22497 This leads to bugs (#37014)
22499 * delegate.cs: The signature for EndInvoke should contain any ref
22500 or out parameters as well. We were not doing this in the past.
22502 * class.cs (Field.Define): Do not overwrite the type definition
22503 inside the `volatile' group. Turns out that volatile enumerations
22504 were changing the type here to perform a validity test, which
22507 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22509 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22510 and structs, we do not want to load the instance variable
22512 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22513 enum_type has to be handled like an object reference (implicit
22514 conversions exists from this to object), but the regular IsClass
22515 and IsValueType tests will never return true for this one.
22517 Also we use TypeManager.IsValueType instead of type.IsValueType,
22518 just for consistency with the rest of the code (this is only
22519 needed if we ever use the construct exposed by test-180.cs inside
22520 corlib, which we dont today).
22522 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22524 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22527 2003-02-09 Martin Baulig <martin@ximian.com>
22529 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22530 (Namespace.DefineNamespaces): New static public method; this is
22531 called when we're compiling with debugging to add all namespaces
22532 to the symbol file.
22534 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22535 pass it to the Namespace's .ctor.
22537 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22538 and MethodBase arguments; pass the namespace ID to the symwriter;
22539 pass the MethodBase instead of the token to the symwriter.
22540 (SymbolWriter.DefineNamespace): New method to add a namespace to
22543 2003-02-09 Martin Baulig <martin@ximian.com>
22545 * symbolwriter.cs: New file. This is a wrapper around
22546 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22547 methods here in near future.
22549 2003-02-09 Martin Baulig <martin@ximian.com>
22551 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22552 ILGenerator.MarkSequencePoint() which are actually used by the
22555 2003-02-09 Martin Baulig <martin@ximian.com>
22557 * location.cs (SourceFile): New public sealed class. This
22558 contains the name and an index which is used in the location's token.
22559 (Location): Reserve an appropriate number of bits in the token for
22560 the source file instead of walking over that list, this gives us a
22561 really huge performance improvement when compiling with debugging.
22563 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22564 `SourceFile' argument instead of a string.
22565 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22566 but don't parse/tokenize here, we need to generate the list of all
22567 source files before we do that.
22568 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22571 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22572 instead of a string.
22574 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22577 2003-02-09 Martin Baulig <martin@ximian.com>
22579 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22580 filename on `#line default'.
22582 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22584 * statement.cs: don't clear the pinned var when the fixed statement
22585 returns from the method (fixes bug#37752).
22587 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22589 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22592 2003-02-07 Martin Baulig <martin@ximian.com>
22594 * driver.cs: Removed the `--debug-args' command line argument.
22596 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22597 automatically by the AsssemblyBuilder.
22598 (CodeGen.InitializeSymbolWriter): We don't need to call any
22599 initialization function on the symbol writer anymore. This method
22600 doesn't take any arguments.
22602 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22604 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22605 from referenced assemblies as well.
22607 2003-02-02 Martin Baulig <martin@ximian.com>
22609 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22611 2003-02-02 Martin Baulig <martin@ximian.com>
22613 * class.cs (Constructor.Emit): Open the symbol writer before
22614 emitting the constructor initializer.
22615 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22616 single-stepping through constructor initializers.
22618 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22620 * class.cs: Handle error 549: do not allow virtual methods in
22623 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22625 * decl.cs: Check access levels when resolving types
22627 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22629 * statement.cs: Add parameters and locals set in catch blocks that might
22630 return to set vector
22632 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22634 * class.cs (Operator): Set the SpecialName flags for operators.
22636 * expression.cs (Invocation.DoResolve): Only block calls to
22637 accessors and operators on SpecialName methods.
22639 (Cast.TryReduce): Handle conversions from char constants.
22642 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22644 * statement.cs: small memory and time optimization in FlowBranching.
22646 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22648 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22649 problem that the last fix but in the other sid (Set).
22651 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22652 access when there is no indexer in the hierarchy.
22654 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22656 * class.cs: Combine some if statements.
22658 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22660 * driver.cs: fixed bug #37187.
22662 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22664 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22665 any indexer, it's needed to build a list with all the indexers in the
22666 hierarchy (AllGetters), else we have problems. Fixes #35653.
22668 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22670 * class.cs (MethodData.Define): It is wrong for an interface
22671 implementation to be static in both cases: explicit and implicit.
22672 We were only handling this in one case.
22674 Improve the if situation there to not have negations.
22676 * class.cs (Field.Define): Turns out that we do not need to check
22677 the unsafe bit on field definition, only on usage. Remove the test.
22679 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22681 * driver.cs: use assembly.Location instead of Codebase (the latest
22682 patch made mcs fail when using MS assemblies).
22684 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22686 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22687 get the path to *corlib.dll.
22689 2003-01-21 Nick Drochak <ndrochak@gol.com>
22693 * typemanager.cs: Remove compiler warnings
22695 2003-01-20 Duncan Mak <duncan@ximian.com>
22697 * AssemblyInfo.cs: Bump the version number to 0.19.
22699 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22701 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22703 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22705 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22707 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22709 * cs-parser.jay: Small fix: we were not comparing the constructor
22710 name correctly. Thanks to Zoltan for the initial pointer.
22712 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22714 * cs-tokenizer.cs: Set file name when specified with #line
22716 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22718 * cs-parser.jay: Only perform the constructor checks here if we
22719 are named like the class; This will help provider a better
22720 error. The constructor path is taken when a type definition is
22721 not found, but most likely the user forgot to add the type, so
22722 report that rather than the constructor error.
22724 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22726 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22729 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22731 * cs-parser.jay: Add cleanup call.
22733 2003-01-13 Duncan Mak <duncan@ximian.com>
22735 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22736 consistent with other methods.
22738 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22740 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22742 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22744 * attribute.cs: only set GuidAttr to true when we have a
22747 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22751 * typemanager.cs: fixes to allow mcs compile corlib with the new
22752 Type.IsSubclassOf fix.
22754 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22756 * expression.cs (LocalVariableReference.DoResolve): Classify a
22757 constant as a value, not as a variable. Also, set the type for
22760 * cs-parser.jay (fixed_statement): take a type instead of a
22761 pointer_type, so we can produce a better error message later.
22763 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22766 (For.DoEmit): Make inifinite loops have a
22767 non-conditional branch back.
22769 (Fixed.DoEmit): First populate the pinned variables, then emit the
22770 statement, then clear the variables. Before I was emitting the
22771 code once for each fixed piece.
22774 2003-01-08 Martin Baulig <martin@ximian.com>
22776 * statement.cs (FlowBranching.MergeChild): A break in a
22777 SWITCH_SECTION does not leave a loop. Fixes #36155.
22779 2003-01-08 Martin Baulig <martin@ximian.com>
22781 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22782 lives in the same number space than `param_map'. Fixes #36154.
22784 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22786 * cs-parser.jay (constructor_declaration): Set the
22787 Constructor.ModFlags before probing for it. This makes the
22788 compiler report 514, 515 and 132 (the code was there, but got
22791 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22792 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22793 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22795 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22797 * enum.cs: create the enum static fields using the enum type.
22799 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22801 * class.cs: don't try to create the ParamBuilder for the return
22802 type if it's not needed (and handle it breaking for the ms runtime
22805 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22807 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22809 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22811 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22812 the command. This showed up while compiling the JANET source
22813 code, which used \r as its only newline separator.
22815 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22817 * class.cs (Method.Define): If we are an operator (because it
22818 reuses our code), then set the SpecialName and HideBySig. #36128
22820 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22822 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22823 exception, report error 120 `object reference required'.
22825 * driver.cs: Add --pause option, used during to measure the size
22826 of the process as it goes with --timestamp.
22828 * expression.cs (Invocation.DoResolve): Do not allow methods with
22829 SpecialName to be invoked.
22831 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22833 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22834 number before adding it.
22836 2002-12-21 Ravi Pratap <ravi@ximian.com>
22838 * ecore.cs (StandardImplicitConversion): When in an unsafe
22839 context, we allow conversion between void * to any other pointer
22840 type. This fixes bug #35973.
22842 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22844 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22845 is not thrown when extensionless outputs are used
22847 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22849 * rootcontext.cs: fixed compilation of corlib.
22851 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22853 * attribute.cs (Attributes.Contains): Add new method.
22855 * class.cs (MethodCore.LabelParameters): if the parameter is an
22856 `out' parameter, check that no attribute `[In]' has been passed.
22858 * enum.cs: Handle the `value__' name in an enumeration.
22860 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22862 * decl.cs: Added special case to allow overrides on "protected
22865 2002-12-18 Ravi Pratap <ravi@ximian.com>
22867 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22868 since it makes much more sense.
22870 (Attributes.ctor): Don't require a Location parameter.
22872 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22874 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22875 since we already have that information per attribute.
22877 * everywhere : make appropriate changes.
22879 * class.cs (LabelParameters): Write the code which actually
22880 applies attributes to the return type. We can't do this on the MS
22881 .NET runtime so we flag a warning in the case an exception is
22884 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22886 * const.cs: Handle implicit null conversions here too.
22888 2002-12-17 Ravi Pratap <ravi@ximian.com>
22890 * class.cs (MethodCore.LabelParameters): Remove the extra
22891 Type [] parameter since it is completely unnecessary. Instead
22892 pass in the method's attributes so that we can extract
22893 the "return" attribute.
22895 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22897 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22898 of ignoring it and letting the compile continue.
22900 * typemanager.cs (ChangeType): use an extra argument to return an
22901 error condition instead of throwing an exception.
22903 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22905 * expression.cs (Unary.TryReduce): mimic the code for the regular
22906 code path. Perform an implicit cast in the cases where we can
22907 implicitly convert to one of the integral types, and then reduce
22908 based on that constant. This fixes bug #35483.
22910 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22912 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22914 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22916 * namespace.cs: fixed bug #35489.
22918 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22920 * class.cs: Remove some dead code.
22922 * cs-parser.jay: Estimate the number of methods needed
22923 (RootContext.MethodCount);
22925 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22926 numbers instead of StringBuilders.
22928 * support.cs (PtrHashtable): Add constructor with initial size;
22929 We can now reduce reallocations of the method table.
22931 2002-12-10 Ravi Pratap <ravi@ximian.com>
22933 * attribute.cs (ApplyAttributes): Keep track of the emitted
22934 attributes on a per-target basis. This fixes bug #35413.
22936 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22938 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22939 default to the Windows 1252 encoding.
22941 (UnixParseOption): Support version, thanks to Alp for the missing
22944 * AssemblyInfo.cs: Add nice assembly information.
22946 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22949 * cs-parser.jay: Allow a trailing comma before the close bracked
22950 in the attribute_section production.
22952 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22953 address of the instance was being taken, I will take this out,
22954 because we take the address of the object immediately here.
22956 2002-12-09 Ravi Pratap <ravi@ximian.com>
22958 * typemanager.cs (AreMultipleAllowed): Take care of the most
22959 obvious case where attribute type is not in the current assembly -
22962 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22964 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22965 definitions, instead of doing that afterwards.
22967 Also we use a nice little hack, depending on the constructor, we
22968 know if we are a "composed" name or a simple name. Hence, we
22969 avoid the IndexOf test, and we avoid
22971 * codegen.cs: Add code to assist in a bug reporter to track down
22972 the source of a compiler crash.
22974 2002-12-07 Ravi Pratap <ravi@ximian.com>
22976 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22977 types have been emitted for a given element and flag an error
22978 if something which does not have AllowMultiple set is used more
22981 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22982 attribute types and their corresponding AllowMultiple properties
22984 (AreMultipleAllowed): Check the property for a given type.
22986 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22987 property in the case we have a TypeContainer.
22989 (Attributes.AddAttribute): Detect duplicates and just skip on
22990 adding them. This trivial fix catches a pretty gross error in our
22991 attribute emission - global attributes were being emitted twice!
22993 Bugzilla bug #33187 is now fixed.
22995 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22997 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22998 instead of pp_and).
23000 * expression.cs (Binary.ResolveOperator): I can only use the
23001 Concat (string, string, string) and Concat (string, string,
23002 string, string) if the child is actually a concatenation of
23005 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23007 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23008 context where we need a 2-character lookahead.
23010 * pending.cs (PendingImplementation): Rework so we can keep track
23011 of interface types all the time, and flag those which were
23012 implemented by parents as optional.
23014 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23016 * expression.cs (Binary.ResolveOperator): Use
23017 String.Concat(string,string,string) or
23018 String.Concat(string,string,string,string) when possible.
23020 * typemanager: More helper methods.
23023 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23025 * pending.cs: remove the bogus return from GetMissingInterfaces()
23026 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23028 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23030 * namespace.cs: avoid duplicated 'using xxx' being added to
23031 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23032 when we get more than one 'using' statement for the same namespace.
23033 Report a CS0105 warning for it.
23035 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23037 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23038 of calling getChar/putback, uses internal knowledge of it.
23040 (xtoken): Reorder tokenizer so most common patterns are checked
23041 first. This reduces the compilation time in another 5% (from 8.11s
23042 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23044 The parsing time is 22% of the compilation in mcs, and from that
23045 64% is spent on the tokenization process.
23047 I tried using a binary search for keywords, but this is slower
23048 than the hashtable. Another option would be to do a couple of
23051 * Not use a StringBuilder, instead use an array of chars,
23052 with a set value. Notice that this way we could catch
23053 the 645 error without having to do it *afterwards*.
23055 * We could write a hand-parser to avoid the hashtable
23056 compares altogether.
23058 The identifier consumption process takes 37% of the tokenization
23059 time. Another 15% is spent on is_number. 56% of the time spent
23060 on is_number is spent on Int64.Parse:
23062 * We could probably choose based on the string length to
23063 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23066 Another 3% is spend on wrapping `xtoken' in the `token' function.
23068 Handle 0xa0 as whitespace (#34752)
23070 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23072 * typemanager.cs (IsCLRType): New routine to tell whether a type
23073 is one of the builtin types.
23075 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23076 typecode in more places instead of doing pointer comparissions.
23077 We could leverage some knowledge about the way the typecodes are
23080 New code to cache namespaces in assemblies, it is currently not
23081 invoked, to be used soon.
23083 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23085 * expression.cs (Binary.ResolveOperator): specially handle
23086 strings, and do not perform user-defined operator overloading for
23089 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23091 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23092 internalcall as it is a pretty simple operation; Avoid whenever
23093 possible to call Char.IsLetter.
23095 (consume_identifier): Cut by half the number of
23096 hashtable calls by merging the is_keyword and GetKeyword behavior.
23098 Do not short-circuit, because if we do, we
23099 report errors (ie, #if false && true would produce an invalid
23103 2002-11-24 Martin Baulig <martin@ximian.com>
23105 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23106 check constant ranges and report a CS0221. Fixes #33186.
23108 2002-11-24 Martin Baulig <martin@ximian.com>
23110 * cs-parser.jay: Make this work for uninitialized variable
23111 declarations in the `for' initializer. Fixes #32416.
23113 2002-11-24 Martin Baulig <martin@ximian.com>
23115 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23116 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23118 2002-11-24 Martin Baulig <martin@ximian.com>
23120 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23121 argument; if true, we also check for user-defined conversions.
23122 This is only needed if both arguments are of a user-defined type.
23123 Fixes #30443, added test-175.cs.
23124 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23126 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23128 2002-11-24 Martin Baulig <martin@ximian.com>
23130 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23131 function to get the store opcode.
23132 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23133 only emit the Ldelema if the store opcode is Stobj. You must run
23134 both test-34 and test-167 to test this. Fixes #34529.
23136 2002-11-23 Martin Baulig <martin@ximian.com>
23138 * ecore.cs (Expression.MemberLookup): Added additional
23139 `qualifier_type' argument which is used when we're being called
23140 from MemberAccess.DoResolve() and null if we're called from a
23142 (Expression.MemberLookupFailed): New method to report errors; this
23143 does the CS1540 check and reports the correct error message.
23145 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23146 argument for the CS1540 check and redone the way how we're dealing
23147 with private members. See the comment in the source code for details.
23148 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23149 `closure_start_type' to `closure_qualifier_type' and check whether
23150 it's not null. It was not this filter being broken, it was just
23151 being called with the wrong arguments.
23153 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23154 and pass it the correct `qualifier_type'; this also does the error
23157 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23159 * expression.cs (Invocation.EmitParams): If the we are dealing
23160 with a non-built-in value type, load its address as well.
23162 (ArrayCreation): Use a a pretty constant instead
23163 of the hardcoded value 2. Use 6 instead of 2 for the number of
23164 static initializers.
23166 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23167 because they are not really value types, just glorified integers.
23169 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23171 * ecore.cs: Remove redundant code for enumerations, make them use
23172 the same code path as everything else, fixes the casting issue
23173 with enumerations in Windows.Forms.
23175 * attribute.cs: Do only cast to string if it is a string, the
23176 validation happens later.
23178 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23179 people upgrade their corlibs.
23181 * ecore.cs: Oops, enumerations were not following the entire code path
23183 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23185 * typemanager.cs (FilterWithClosure): Commented out the test for
23186 1540 in typemanager.cs, as it has problems when accessing
23187 protected methods from a parent class (see test-174.cs).
23189 * attribute.cs (Attribute.ValidateGuid): new method.
23190 (Attribute.Resolve): Use above.
23192 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23194 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23196 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23197 handling for enumerations, as we only needed the TypeContainer
23198 functionality to begin with (this is required for the fix below to
23199 work for enums that reference constants in a container class for
23202 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23204 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23205 a valid TypeBuilder to perform lookups on.o
23207 * class.cs (InheritableMemberSignatureCompare): Use true in the
23208 call to GetGetMethod and GetSetMethod, because we are comparing
23209 the signature, and we need to get the methods *even* if they are
23212 (PropertyBase.CheckBase): ditto.
23214 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23215 GotoCase.Resolve): Use Peel on EmpytCasts.
23217 * ecore.cs (EmptyCast): drop child, add Peel method.
23219 2002-11-17 Martin Baulig <martin@ximian.com>
23221 * ecore.cs (EmptyCast.Child): New public property.
23223 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23224 label resolved to an EmptyCast. Fixes #34162.
23225 (GotoCase.Resolve): Likewise.
23226 (Block.EmitMeta): Likewise.
23228 2002-11-17 Martin Baulig <martin@ximian.com>
23230 * expression.cs (Invocation.BetterConversion): Prefer int over
23231 uint; short over ushort; long over ulong for integer literals.
23232 Use ImplicitConversionExists instead of StandardConversionExists
23233 since we also need to check for user-defined implicit conversions.
23234 Fixes #34165. Added test-173.cs.
23236 2002-11-16 Martin Baulig <martin@ximian.com>
23238 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23239 with the `true' and `false' literals. Fixes #33151.
23241 2002-11-16 Martin Baulig <martin@ximian.com>
23243 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23244 October 22nd; don't do the cs1540 check for static members.
23246 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23247 now using our own filter here and doing the cs1540 check again.
23249 2002-11-16 Martin Baulig <martin@ximian.com>
23251 * support.cs (InternalParameters): Don't crash if we don't have
23252 any fixed parameters. Fixes #33532.
23254 2002-11-16 Martin Baulig <martin@ximian.com>
23256 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23257 when looking up static methods to make this work on Windows.
23260 2002-11-16 Martin Baulig <martin@ximian.com>
23262 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23263 a setter rather than using PropertyInfo.CanWrite.
23265 2002-11-15 Nick Drochak <ndrochak@gol.com>
23267 * class.cs: Allow acces to block member by subclasses. Fixes build
23270 2002-11-14 Martin Baulig <martin@ximian.com>
23272 * class.cs (Constructor.Emit): Added the extern/block check.
23275 2002-11-14 Martin Baulig <martin@ximian.com>
23277 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23278 iteration while looking for indexers, this is needed because the
23279 indexer may have a different name in our base classes. Fixed the
23280 error reporting (no indexers at all, not get accessor, no
23281 overloaded match). Fixes bug #33089.
23282 (IndexerAccess.DoResolveLValue): Likewise.
23284 2002-11-14 Martin Baulig <martin@ximian.com>
23286 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23287 indexers. Fixes the first part of bug #33089.
23288 (MethodSignature.InheritableMemberSignatureCompare): Added support
23291 2002-11-13 Ravi Pratap <ravi@ximian.com>
23293 * attribute.cs (Attribute.Resolve): Catch the
23294 NullReferenceException and report it since it isn't supposed to
23297 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23299 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23300 LogicalOr and LogicalAnd that can benefit from recursively
23301 handling EmitBranchable. The code now should be nice for Paolo.
23303 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23305 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23306 the Type lookups, as we perform quite a number of lookups on
23307 non-Types. This can be removed once we can deterministically tell
23308 whether we have a type or a namespace in advance.
23310 But this might require special hacks from our corlib.
23314 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23315 and double which avoids a conversion from an integer to a double.
23317 * expression.cs: tiny optimization, avoid calling IsConstant,
23318 because it effectively performs the lookup twice.
23320 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23322 But a bogus return here to keep the semantics of the old code
23323 until the Mono runtime is fixed.
23325 * pending.cs (GetMissingInterfaces): New method used to remove all
23326 the interfaces that are already implemented by our parent
23327 classes from the list of pending methods.
23329 * interface.cs: Add checks for calls after ResolveTypeExpr.
23331 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23333 * class.cs (Class.Emit): Report warning 67: event not used if the
23334 warning level is beyond 3.
23336 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23337 being a NullLiteral.
23339 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23342 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23343 path that might fail if a type can not be resolved.
23345 * expression.cs (Binary.Emit): Emit unsigned versions of the
23348 * driver.cs: use error 5.
23350 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23352 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23354 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23356 * cs-parser.jay (switch_section): A beautiful patch from Martin
23357 Baulig that fixed 33094.
23359 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23361 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23362 Check whether the base is abstract and report an error if so.
23364 * expression.cs (IndexerAccess.DoResolveLValue,
23365 IndexerAccess.DoResolve): ditto.
23367 (Invocation.DoResolve): ditto.
23369 (Invocation.FullMethodDesc): Improve the report string.
23371 * statement.cs (Block): Eliminate IsVariableDefined as it is
23372 basically just a wrapper for GetVariableInfo.
23374 * ecore.cs (SimpleName): Use new
23376 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23377 type, as we return the actual parameter ref/unref state on a
23380 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23382 * support.cs: Return proper flags REF/OUT fixing the previous
23385 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23386 not used to mean `ref' but `ref or out' in ParameterReference
23388 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23389 full type signature instead of calling TypeManger.CSharpName
23392 * support.cs (InternalParameters.ParameterDesc): Do not compare
23393 directly to the modflags, because REF/OUT will actually be bitsets
23396 * delegate.cs (VerifyMethod): Check also the modifiers.
23398 * cs-tokenizer.cs: Fix bug where floating point values with an
23399 exponent where a sign was missing was ignored.
23401 * driver.cs: Allow multiple assemblies to be specified in a single
23404 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23406 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23407 because identifiers after a parenthesis would end up in this kind
23408 of production, and we needed to desamiguate it for having casts
23411 (UserDefinedType *) xxx
23413 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23415 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23416 we should set on the Bindingflags.NonPublic, but not turn on
23417 private_ok. private_ok controls whether a Private member is
23418 returned (this is chekced on the filter routine), while the
23419 BindingFlags.NonPublic just controls whether private/protected
23420 will be allowed. This fixes the problem part of the problem of
23421 private properties being allowed to be used in derived classes.
23423 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23424 so we can call the children DoResolveLValue method (this will
23425 properly signal errors on lvalue assignments to base properties)
23427 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23428 getter are null, and we have a property info, we know that this
23429 happened because the lookup failed, so we report an error 122 for
23430 protection level violation.
23432 We also silently return if setter and getter are null in the
23433 resolve functions, this condition only happens if we have flagged
23434 the error before. This is the other half of the problem.
23436 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23437 not have accessibility information, that is why we were returning
23438 true in the filter function in typemanager.cs.
23440 To properly report 122 (property is inaccessible because of its
23441 protection level) correctly, we report this error in ResolveAccess
23442 by failing if both the setter and the getter are lacking (ie, the
23445 DoResolve and DoLResolve have been modified to check for both
23446 setter/getter being null and returning silently, the reason being
23447 that I did not want to put the knowledge about this error in upper
23450 int old = Report.Errors;
23451 x = new PropertyExpr (...);
23452 if (old != Report.Errors)
23457 So the property expr is returned, but it is invalid, so the error
23458 will be flagged during the resolve process.
23460 * class.cs: Remove InheritablePropertySignatureCompare from the
23461 class, as we no longer depend on the property signature to compute
23462 whether it is possible to implement a method or not.
23464 The reason is that calling PropertyInfo.GetGetMethod will return
23465 null (in .NET, in Mono it works, and we should change this), in
23466 cases where the Get Method does not exist in that particular
23471 class X { public virtual int A { get { return 1; } } }
23473 class Z : Y { public override int A { get { return 2; } } }
23475 Would fail in Z because the parent (Y) would not have the property
23476 defined. So we avoid this completely now (because the alternative
23477 fix was ugly and slow), and we now depend exclusively on the
23480 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23481 reference method, instead of using the property.
23483 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23484 routines are gone now.
23486 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23487 names, they were incorrectly named.
23489 * cs-tokenizer.cs: Return are more gentle token on failure.
23491 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23492 had an out-of-sync index variable, which caused it to remove from
23493 the list of pending methods the wrong method sometimes.
23495 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23497 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23498 CanWrite, because those refer to this particular instance of the
23499 property, and do not take into account the fact that we can
23500 override single members of a property.
23502 Constructor requires an EmitContext. The resolution process does
23503 not happen here, but we need to compute the accessors before,
23504 because the resolution does not always happen for properties.
23506 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23507 subclass, before we did not update this flag, but we did update
23510 (GetAccessors): Drop this routine, as it did not work in the
23511 presence of partially overwritten set/get methods.
23513 Notice that this broke the cs1540 detection, but that will require
23516 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23520 * driver.cs: issue a warning instead of an error if we don't support
23521 debugging for the platform. Also ignore a couple of errors that may
23522 arise when trying to write the symbols. Undo my previous patch.
23524 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23526 * driver.cs: ignore /debug switch except for Unix platforms.
23528 2002-10-23 Nick Drochak <ndrochak@gol.com>
23530 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23532 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23534 * driver.cs: Do not make mcs-debug conditional, so we do not break
23535 builds that use it.
23537 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23538 review this patch. But basically after all the children variables
23539 have been merged, the value of "Breaks" was not being set to
23540 new_breaks for Switch blocks. I think that it should be set after
23541 it has executed. Currently I set this to the value of new_breaks,
23542 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23543 conservative, but I do not understand this code very well.
23545 I did not break anything in the build, so that is good ;-)
23547 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23549 2002-10-20 Mark Crichton <crichton@gimp.org>
23551 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23553 2002-10-20 Nick Drochak <ndrochak@gol.com>
23555 * cfold.cs: Fixed compile blocker.
23557 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23559 * driver.cs: I was chekcing the key, not the file.
23561 2002-10-19 Ravi Pratap <ravi@ximian.com>
23563 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23564 message that we were generating - we just need to silently return
23567 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23569 * class.cs (Event.Define): Change my previous commit, as this
23570 breaks the debugger. This is a temporary hack, as it seems like
23571 the compiler is generating events incorrectly to begin with.
23573 * expression.cs (Binary.ResolveOperator): Added support for
23574 "U operator - (E x, E y)"
23576 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23579 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23580 init-only variables, but this path did not take into account that
23581 there might be also instance readonly variables. Correct this
23584 This fixes bug 32253
23586 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23589 * driver.cs: Change the extension for modules to `netmodule'
23591 * cs-parser.jay: Improved slightly the location tracking for
23592 the debugger symbols.
23594 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23595 modifiers that were specified instead of the hardcoded value
23596 (FamAndAssem). This was basically ignoring the static modifier,
23597 and others. Fixes 32429.
23599 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23600 fixed a bug in the process (32476)
23602 * expression.cs (ArrayAccess.EmitAssign): Patch from
23603 hwang_rob@yahoo.ca that fixes bug 31834.3
23605 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23607 * driver.cs: Make the module extension .netmodule.
23609 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23611 * driver.cs: Report an error if the resource file is not found
23612 instead of crashing.
23614 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23615 false, like Emit does.
23617 2002-10-16 Nick Drochak <ndrochak@gol.com>
23619 * typemanager.cs: Remove unused private member. Also reported mcs
23620 bug to report this as a warning like csc.
23622 2002-10-15 Martin Baulig <martin@gnome.org>
23624 * statement.cs (Statement.Emit): Made this a virtual method; emits
23625 the line number info and calls DoEmit().
23626 (Statement.DoEmit): New protected abstract method, formerly knows
23627 as Statement.Emit().
23629 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23631 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23633 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23634 have fixed a remaining problem: not every AddXXXX was adding a
23635 fully qualified name.
23637 Now everyone registers a fully qualified name in the DeclSpace as
23638 being defined instead of the partial name.
23640 Downsides: we are slower than we need to be due to the excess
23641 copies and the names being registered this way.
23643 The reason for this is that we currently depend (on the corlib
23644 bootstrap for instance) that types are fully qualified, because
23645 we dump all the types in the namespace, and we should really have
23646 types inserted into the proper namespace, so we can only store the
23647 basenames in the defined_names array.
23649 2002-10-10 Martin Baulig <martin@gnome.org>
23651 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23652 from bug #31834, see the bug report for a testcase which is
23655 2002-10-10 Martin Baulig <martin@gnome.org>
23657 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23658 flow analysis code for this.
23660 * statement.cs (Do, While, For): Tell the flow analysis code about
23662 (FlowBranching.UsageVector): Added support for infinite loops.
23663 (Block.Resolve): Moved the dead code elimination here and use flow
23666 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23668 * class.cs (Field.Define): Catch cycles on struct type
23671 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23672 fields if the fields are static. We only need to check instance
23675 * expression.cs (As.DoResolve): Test for reference type.
23677 * statement.cs (Using.ResolveExpression): Use
23678 ConvertImplicitRequired, not ConvertImplicit which reports an
23680 (Using.ResolveLocalVariableDecls): ditto.
23682 * expression.cs (Binary.ResolveOperator): Report errors in a few
23683 places where we had to.
23685 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23687 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23689 * expression.cs: Use StoreFromPtr instead of extracting the type
23690 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23692 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23693 an enumeration value to a System.Enum, but System.Enum is not a
23694 value type, but an class type, so we need to box.
23696 (Expression.ConvertExplicit): One codepath could return
23697 errors but not flag them. Fix this. Fixes #31853
23699 * parameter.cs (Resolve): Do not allow void as a parameter type.
23701 2002-10-06 Martin Baulig <martin@gnome.org>
23703 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23704 if it's a class type and not a struct. Fixes #31815.
23706 2002-10-06 Martin Baulig <martin@gnome.org>
23708 * statement.cs: Reworked the flow analysis code a bit to make it
23709 usable for dead code elimination.
23711 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23713 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23715 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23717 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23718 to fix the test 165, will investigate deeper.
23720 2002-10-04 Martin Baulig <martin@gnome.org>
23722 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23723 finally blocks actually work.
23724 (Try.Resolve): We don't need to create a sibling for `finally' if
23725 there is no finally block.
23727 2002-10-04 Martin Baulig <martin@gnome.org>
23729 * class.cs (Constructor.Define): The default accessibility for a
23730 non-default constructor is private, not public.
23732 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23734 * class.cs (Constructor): Make AllowedModifiers public, add
23737 * cs-parser.jay: Perform the modifiers test here, as the
23738 constructor for the Constructor class usually receives a zero
23739 because of the way we create it (first we create, later we
23740 customize, and we were never checking the modifiers).
23742 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23743 is a version of LookupTypeReflection that includes the type-name
23744 cache. This can be used as a fast path for functions that know
23745 the fully qualified name and are only calling into *.GetType() to
23746 obtain a composed type.
23748 This is also used by TypeManager.LookupType during its type
23751 (LookupType): We now also track the real type name, as sometimes
23752 we can get a quey for the real type name from things like
23753 ComposedCast. This fixes bug 31422.
23755 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23756 complete type fullname, it does not have to go through the type
23757 resolution system to obtain the composed version of the type (for
23758 obtaining arrays or pointers).
23760 (Conditional.Emit): Use the EmitBoolExpression to
23761 generate nicer code, as requested by Paolo.
23763 (ArrayCreation.CheckIndices): Use the patch from
23764 hwang_rob@yahoo.ca to validate the array initializers.
23766 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23768 * class.cs (ConstructorInitializer.Emit): simplify code by using
23769 Invocation.EmitCall, and at the same time, fix the bugs in calling
23770 parent constructors that took variable arguments.
23772 * ecore.cs (Expression.ConvertNumericExplicit,
23773 Expression.ImplicitNumericConversion): Remove the code that
23774 manually wrapped decimal (InternalTypeConstructor call is now gone
23777 * expression.cs (Cast.TryReduce): Also handle decimal types when
23778 trying to perform a constant fold on the type.
23780 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23782 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23783 that only turned off an error report, and did nothing else.
23785 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23787 * driver.cs: Handle and ignore /fullpaths
23789 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23791 * expression.cs (Binary.ResolveOperator): Catch the case where
23792 DoNumericPromotions returns true,
23794 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23796 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23798 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23801 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23803 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23804 conversion exists, but it is also required that the conversion be
23805 performed. This manifested in "(Type64Enum) 2".
23807 * class.cs (TypeManager.AddMethod): The fix is not to change
23808 AddEnum, because that one was using a fully qualified name (every
23809 DeclSpace derivative does), but to change the AddMethod routine
23810 that was using an un-namespaced name. This now correctly reports
23811 the duplicated name.
23813 Revert patch until I can properly fix it. The issue
23814 is that we have a shared Type space across all namespaces
23815 currently, which is wrong.
23817 Options include making the Namespace a DeclSpace, and merge
23818 current_namespace/current_container in the parser.
23820 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23822 * cs-parser.jay: Improve error reporting when we get a different
23823 kind of expression in local_variable_type and
23824 local_variable_pointer_type.
23826 Propagate this to avoid missleading errors being reported.
23828 * ecore.cs (ImplicitReferenceConversion): treat
23829 TypeManager.value_type as a target just like object_type. As
23834 Is valid, and needs to result in the int 1 being boxed before it
23835 is assigned to the value type v.
23837 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23838 to validate the enumeration name.
23840 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23841 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23842 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23844 * ecore.cs (TryImplicitIntConversion): When doing an
23845 implicit-enumeration-conversion, check if the type is 64-bits and
23846 perform a conversion before passing to EnumConstant.
23848 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23850 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23851 report ambiguous type references. Unlike the MS version, we
23852 report what the ambiguity is. Innovation at work ;-)
23854 (DeclSpace.FindType): Require a location argument to
23855 display when we display an ambiguous error.
23857 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23859 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23861 * expression.cs (EmitDynamicInitializers): Apply patch from
23862 hwang_rob@yahoo.ca that fixes the order in which we emit our
23865 2002-09-21 Martin Baulig <martin@gnome.org>
23867 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23868 delegate takes no arguments.
23870 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23872 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23875 * expression.cs: Extract the underlying type.
23877 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23879 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23881 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23883 * class.cs (TypeContainer.DefineType): We can not use the nice
23884 PackingSize with the size set to 1 DefineType method, because it
23885 will not allow us to define the interfaces that the struct
23888 This completes the fixing of bug 27287
23890 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23891 means also structs. This fixes part of the problem.
23892 (Expresion.ImplicitReferenceConversionExists): ditto.
23894 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23895 error if there were no errors reported during the type lookup
23896 process, to avoid duplicates or redundant errors. Without this
23897 you would get an ambiguous errors plus a type not found. We have
23898 beaten the user enough with the first error.
23900 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23903 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23904 during the resolution process, stop the lookup, this avoids
23905 repeated error reports (same error twice).
23907 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23909 * typemanager.cs (LookupType): Redo the type lookup code to match
23910 the needs of System.Reflection.
23912 The issue is that System.Reflection requires references to nested
23913 types to begin with a "+" sign instead of a dot. So toplevel
23914 types look like: "NameSpace.TopLevelClass", and nested ones look
23915 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23918 2002-09-19 Martin Baulig <martin@gnome.org>
23920 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23921 says that a method always returns or always throws an exception,
23922 don't report the CS0161.
23924 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23925 set `Returns = new_returns'.
23927 2002-09-19 Martin Baulig <martin@gnome.org>
23929 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23930 to an enum constant, check for a CS0176.
23932 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23934 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23935 for operators that must be in pairs and report errors.
23937 * ecore.cs (SimpleName.DoResolveType): During the initial type
23938 resolution process, when we define types recursively, we must
23939 check first for types in our current scope before we perform
23940 lookups in the enclosing scopes.
23942 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23944 (Invocation.VerifyArgumentsCompat): Call
23945 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23946 I thought we were supposed to always call this, but there are a
23947 few places in the code where we dont do it.
23949 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23951 * driver.cs: Add support in -linkres and -resource to specify the
23952 name of the identifier.
23954 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23956 * ecore.cs (StandardConversionExists): Sync with the conversion
23957 code: allow anything-* to void* conversions.
23959 (FindMostSpecificSource): Use an Expression argument
23960 instead of a Type, because we might be handed over a Literal which
23961 gets a few more implicit conversions that plain types do not. So
23962 this information was being lost.
23964 Also, we drop the temporary type-holder expression when not
23967 2002-09-17 Martin Baulig <martin@gnome.org>
23969 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23970 this is an explicit interface implementation.
23972 2002-09-17 Martin Baulig <martin@gnome.org>
23974 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23975 different `IndexerName' attributes.
23977 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23978 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23979 virtual CommonResolve().
23981 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23983 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23984 and convert that to the UnderlyingType.
23986 * statement.cs (Foreach.Resolve): Indexers are just like variables
23987 or PropertyAccesses.
23989 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23990 inside quoted strings, we were not doing this before.
23992 2002-09-16 Martin Baulig <martin@gnome.org>
23994 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23995 resolve it. This is needed for the definite assignment check of the
23996 instance expression, fixes bug #29846.
23997 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23999 2002-09-16 Nick Drochak <ndrochak@gol.com>
24001 * parameter.cs: Fix compile error. Cannot reference static member
24002 from an instance object. Is this an mcs bug?
24004 2002-09-14 Martin Baulig <martin@gnome.org>
24006 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24007 multiple times. Fixes bug #30295, added test-166.cs.
24009 2002-09-14 Martin Baulig <martin@gnome.org>
24011 * statement.cs (Block.Emit): Don't emit unreachable code.
24012 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24013 `break' statements.
24014 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24016 2002-09-14 Martin Baulig <martin@gnome.org>
24018 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24021 2002-09-14 Martin Baulig <martin@gnome.org>
24023 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24024 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24025 be false on the ms runtime.
24027 2002-09-13 Martin Baulig <martin@gnome.org>
24029 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24030 the CS0038 error message.
24032 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24034 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24035 constant inside, return it.
24037 2002-09-12 Martin Baulig <martin@gnome.org>
24039 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24040 implicit conversion can be done between enum types.
24042 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24043 check whether an implicit conversion to the current enum's UnderlyingType
24044 exists and report an error if not.
24046 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24047 without debugging support.
24049 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24050 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24052 2002-09-12 Martin Baulig <martin@gnome.org>
24054 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24056 * ecore.cs (IMemberExpr.DeclaringType): New property.
24057 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24058 nonstatic member of an outer type (CS0038).
24060 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24062 * driver.cs: Activate the using-error detector at warning level
24063 4 (at least for MS-compatible APIs).
24065 * namespace.cs (VerifyUsing): Small buglett fix.
24067 * pending.cs (PendingImplementation): pass the container pointer.
24069 * interface.cs (GetMethods): Allow for recursive definition. Long
24070 term, I would like to move every type to support recursive
24071 definitions, not the current ordering mechanism that we have right
24074 The situation is this: Attributes are handled before interfaces,
24075 so we can apply attributes to interfaces. But some attributes
24076 implement interfaces, we will now handle the simple cases
24077 (recursive definitions will just get an error).
24079 * parameter.cs: Only invalidate types at the end if we fail to
24082 2002-09-09 Martin Baulig <martin@gnome.org>
24084 * ecore.cs (PropertyExpr.Emit): Also check for
24085 TypeManager.system_int_array_get_length so this'll also work when
24086 compiling corlib. Fixes #30003.
24088 2002-09-09 Martin Baulig <martin@gnome.org>
24090 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24091 and throw an exception if we can't get the type's size. Fixed #30040,
24094 2002-09-09 Martin Baulig <martin@gnome.org>
24096 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24098 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24099 context. Fixes bug #30027.
24101 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24102 virtual functions. Fixes bug #30043, added test-164.cs.
24104 2002-09-08 Ravi Pratap <ravi@ximian.com>
24106 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24108 2002-09-08 Nick Drochak <ndrochak@gol.com>
24110 * driver.cs: Use an object to get the windows codepage since it's not a
24113 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24115 * statement.cs (For.Emit): for infinite loops (test == null)
24116 return whether there is a break inside, not always "true".
24118 * namespace.cs (UsingEntry): New struct to hold the name of the
24119 using definition, the location where it is defined, and whether it
24120 has been used in a successful type lookup.
24122 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24127 2002-09-06 Ravi Pratap <ravi@ximian.com>
24129 * attribute.cs : Fix incorrect code which relied on catching
24130 a NullReferenceException to detect a null being passed in
24131 where an object was expected.
24133 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24135 * statement.cs (Try): flag the catch variable as assigned
24137 * expression.cs (Cast): Simplified by using ResolveType instead of
24138 manually resolving.
24140 * statement.cs (Catch): Fix bug by using ResolveType.
24142 2002-09-06 Ravi Pratap <ravi@ximian.com>
24144 * expression.cs (BetterConversion): Special case for when we have
24145 a NullLiteral as the argument and we have to choose between string
24146 and object types - we choose string the way csc does.
24148 * attribute.cs (Attribute.Resolve): Catch the
24149 NullReferenceException and report error #182 since the Mono
24150 runtime no more has the bug and having this exception raised means
24151 we tried to select a constructor which takes an object and is
24154 2002-09-05 Ravi Pratap <ravi@ximian.com>
24156 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24157 message (1502, 1503) when we can't locate a method after overload
24158 resolution. This is much more informative and closes the bug
24161 * interface.cs (PopulateMethod): Return if there are no argument
24162 types. Fixes a NullReferenceException bug.
24164 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24165 expressions too. Previously we were checking only in one place for
24166 positional arguments leaving out named arguments.
24168 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24169 type to the enum type is not allowed. Remove code corresponding to
24172 (ConvertNumericExplicit): Allow explicit conversions from
24173 the underlying type to enum type. This precisely follows the spec
24174 and closes a bug filed by Gonzalo.
24176 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24179 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24181 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24183 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24184 it was important that we stored the right value after the
24185 reduction in `converted'.
24187 2002-09-04 Martin Baulig <martin@gnome.org>
24189 * location.cs (Location.SymbolDocument): Use full pathnames for the
24192 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24194 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24195 of the expression resolve mechanism, because that will catch the
24196 SimpleName error failures.
24198 (Conditional): If we can not resolve the
24199 expression, return, do not crash.
24201 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24204 (location): display token name instead of its number.
24206 2002-08-28 Martin Baulig <martin@gnome.org>
24208 * expression.cs (Binary.ResolveOperator): Don't silently return
24209 but return an error if an operator cannot be applied between two
24212 2002-08-28 Martin Baulig <martin@gnome.org>
24214 * class.cs (Constructor.Define): Set the permission attributes
24215 correctly instead of making all constructors public.
24217 2002-08-28 Martin Baulig <martin@gnome.org>
24219 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24220 for private members before reporting a CS0103; if we find anything,
24223 2002-08-28 Martin Baulig <martin@gnome.org>
24225 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24226 to check whether `closure_start_type == closure_invocation_type',
24227 we also need to check whether `m.DeclaringType == closure_invocation_type'
24228 before bypassing the permission checks. We might be accessing
24229 protected/private members from the base class.
24230 (TypeManager.RealMemberLookup): Only set private_ok if private
24231 members were requested via BindingFlags.NonPublic.
24233 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24235 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24236 MethodGroupExpr.IsExplicitImpl if appropriate.
24237 (Invocation.DoResolve): Don't report the CS0120 for explicit
24238 interface implementations.
24240 2002-08-27 Martin Baulig <martin@gnome.org>
24242 * expression.cs (Invocation.DoResolve): If this is a static
24243 method and we don't have an InstanceExpression, we must report
24246 2002-08-25 Martin Baulig <martin@gnome.org>
24248 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24249 `==' between a valuetype and an object.
24251 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24253 * ecore.cs (TypeExpr): Provide a ToString method.
24255 2002-08-24 Martin Baulig <martin@gnome.org>
24257 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24258 now called proggie.dbg and it's a binary file.
24260 2002-08-23 Martin Baulig <martin@gnome.org>
24262 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24264 2002-08-23 Martin Baulig <martin@gnome.org>
24266 * struct.cs (MyStructInfo.ctor): Make this work with empty
24267 structs; it's not allowed to use foreach() on null.
24269 2002-08-23 Martin Baulig <martin@gnome.org>
24271 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24272 writer the full pathname of the generated assembly.
24274 2002-08-23 Martin Baulig <martin@gnome.org>
24276 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24277 A `finally' block never returns or breaks; improved handling of
24280 2002-08-23 Martin Baulig <martin@gnome.org>
24282 * statement.cs (Throw.Resolve): Allow `throw null'.
24284 2002-08-23 Martin Baulig <martin@gnome.org>
24286 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24287 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24288 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24289 MemberLookup would return a wrong event if this is an explicit
24290 interface implementation and the class has an event with the same
24293 2002-08-23 Martin Baulig <martin@gnome.org>
24295 * statement.cs (Block.AddChildVariableNames): New public method.
24296 (Block.AddChildVariableName): Likewise.
24297 (Block.IsVariableNameUsedInChildBlock): Likewise.
24298 (Block.AddVariable): Check whether a variable name has already
24299 been used in a child block.
24301 * cs-parser.jay (declare_local_variables): Mark all variable names
24302 from the current block as being used in a child block in the
24305 2002-08-23 Martin Baulig <martin@gnome.org>
24307 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24308 find the symbol writer.
24310 * driver.cs: csc also allows the arguments to /define being
24311 separated by commas, not only by semicolons.
24313 2002-08-23 Martin Baulig <martin@gnome.org>
24315 * interface.cs (Interface.GetMembers): Added static check for events.
24317 2002-08-15 Martin Baulig <martin@gnome.org>
24319 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24320 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24322 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24323 why the MethodData.EmitDestructor() change was necessary.
24325 2002-08-20 Martin Baulig <martin@gnome.org>
24327 * class.cs (TypeContainer.FindMembers): Added static check for events.
24329 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24331 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24332 use Type.GetEvents(), not Type.FindMembers().
24334 2002-08-20 Martin Baulig <martin@gnome.org>
24336 * decl.cs (MemberCache): Added a special method cache which will
24337 be used for method-only searched. This ensures that a method
24338 search will return a MethodInfo with the correct ReflectedType for
24341 2002-08-20 Martin Baulig <martin@gnome.org>
24343 * decl.cs (DeclSpace.FindMembers): Made this public.
24345 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24347 * delegate.cs: fixed build on windows.
24348 [FIXME: Filed as bug #29150: MCS must report these errors.]
24350 2002-08-19 Ravi Pratap <ravi@ximian.com>
24352 * ecore.cs (StandardConversionExists): Return a false
24353 if we are trying to convert the void type to anything else
24354 since that is not allowed.
24356 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24357 we flag error 70 in the event an event is trying to be accessed
24358 directly from outside the declaring type.
24360 2002-08-20 Martin Baulig <martin@gnome.org>
24362 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24363 MemberCache from typemanager.cs to decl.cs.
24365 2002-08-19 Martin Baulig <martin@gnome.org>
24367 * class.cs (TypeContainer): Implement IMemberContainer.
24368 (TypeContainer.DefineMembers): Create the MemberCache.
24369 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24370 return public members if BindingFlags.Public was given, check
24371 whether members are static.
24373 2002-08-16 Martin Baulig <martin@gnome.org>
24375 * decl.cs (DeclSpace.Define): Splitted this in Define and
24376 DefineMembers. DefineMembers is called first and initializes the
24379 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24380 DefineMembers() on all our DeclSpaces.
24382 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24383 but call DefineMembers() on all nested interfaces. We call their
24384 Define() in our new Define() function.
24386 * interface.cs (Interface): Implement IMemberContainer.
24387 (Interface.Define): Moved all code except the attribute stuf to
24389 (Interface.DefineMembers): Initialize the member cache.
24391 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24392 need this anymore since we can use MemberCache.FindMembers directly.
24394 2002-08-19 Martin Baulig <martin@gnome.org>
24396 * typemanager.cs (MemberCache): When creating the cache for an
24397 interface type, add all inherited members.
24398 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24399 to `out bool used_cache' and documented it.
24400 (TypeManager.MemberLookup): If we already used the cache in the first
24401 iteration, we don't need to do the interfaces check.
24403 2002-08-19 Martin Baulig <martin@gnome.org>
24405 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24406 here from IMemberFinder and don't implement this interface anymore.
24407 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24409 * typemanager.cs (IMemberFinder): This interface is now only used by
24410 classes which actually support the member cache.
24411 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24412 since we only put DeclSpaces into this Hashtable.
24413 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24414 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24416 2002-08-16 Martin Baulig <martin@gnome.org>
24418 * typemanager.cs (ICachingMemberFinder): Removed.
24419 (IMemberFinder.MemberCache): New property.
24420 (TypeManager.FindMembers): Merged this with RealFindMembers().
24421 This function will never be called from TypeManager.MemberLookup()
24422 so we can't use the cache here, just the IMemberFinder.
24423 (TypeManager.MemberLookup_FindMembers): Check whether the
24424 IMemberFinder has a MemberCache and call the cache's FindMembers
24426 (MemberCache): Rewrote larger parts of this yet another time and
24427 cleaned it up a bit.
24429 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24431 * driver.cs (LoadArgs): Support quoting.
24433 (Usage): Show the CSC-like command line arguments.
24435 Improved a few error messages.
24437 2002-08-15 Martin Baulig <martin@gnome.org>
24439 * typemanager.cs (IMemberContainer.Type): New property.
24440 (IMemberContainer.IsInterface): New property.
24442 The following changes are conditional to BROKEN_RUNTIME, which is
24443 defined at the top of the file.
24445 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24446 class'es members, but add all members from TypeHandle.ObjectType
24447 if we're an interface.
24448 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24449 is the current type.
24450 (MemberCache.CacheEntry.Container): Removed this field.
24451 (TypeHandle.GetMembers): Include inherited members.
24453 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24455 * typemanager.cs: fixed compilation and added a comment on a field that
24458 2002-08-15 Martin Baulig <martin@gnome.org>
24460 * class.cs (ConstructorInitializer.Resolve): In the
24461 Expression.MemberLookup call, use the queried_type as
24464 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24465 declared' attribute, it's always true.
24466 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24467 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24468 temporary wrapper for FindMembers which tells MemberLookup whether
24469 members from the base classes are included in the return value.
24470 This will go away soon.
24471 (TypeManager.MemberLookup): Use this temporary hack here; once the
24472 new MemberCache is completed, we don't need to do the DeclaredOnly
24473 looping here anymore since the MemberCache will take care of this.
24474 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24475 (MemberCache): When creating the MemberCache for a class, get
24476 members from the current class and all its base classes.
24477 (MemberCache.CacheEntry.Container): New field. This is a
24478 temporary hack until the Mono runtime is fixed to distinguish
24479 between ReflectedType and DeclaringType. It allows us to use MCS
24480 with both the MS runtime and the unfixed Mono runtime without
24481 problems and without accecting performance.
24482 (MemberCache.SearchMembers): The DeclaredOnly looping from
24483 TypeManager.MemberLookup is now done here.
24485 2002-08-14 Martin Baulig <martin@gnome.org>
24487 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24488 Type.GetFields on dynamic types but get the fields from the
24489 corresponding TypeContainer.
24490 (MyStructInfo.GetStructInfo): Added check for enum types.
24492 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24493 (MemberList.SyncRoot): Implemented.
24494 (TypeManager.FilterWithClosure): No need to check permissions if
24495 closure_start_type == closure_invocation_type, don't crash if
24496 closure_invocation_type is null.
24498 2002-08-13 Martin Baulig <martin@gnome.org>
24500 Rewrote TypeContainer.FindMembers to use a member cache. This
24501 gives us a speed increase of about 35% for the self-hosting MCS
24502 build and of about 15-20% for the class libs (both on GNU/Linux).
24504 * report.cs (Timer): New class to get enhanced profiling. This
24505 whole class is "TIMER" conditional since it remarkably slows down
24508 * class.cs (MemberList): New class. This is an IList wrapper
24509 which we're now using instead of passing MemberInfo[]'s around to
24510 avoid copying this array unnecessarily.
24511 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24512 (ICachingMemberFinder, IMemberContainer): New interface.
24513 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24514 has already been checked, otherwise use it for the name comparision.
24515 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24516 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24517 if possible. Returns a MemberList, not a MemberInfo [].
24518 (TypeHandle): New class, implements IMemberContainer. We create
24519 one instance of this class per type, it contains a MemberCache
24520 which is used to do the member lookups.
24521 (MemberCache): New class. Each instance of this class contains
24522 all members of a type and a name-based hash table.
24523 (MemberCache.FindMembers): This is our new member lookup
24524 function. First, it looks up all members of the requested name in
24525 the hash table. Then, it walks this list and sorts out all
24526 applicable members and returns them.
24528 2002-08-13 Martin Baulig <martin@gnome.org>
24530 In addition to a nice code cleanup, this gives us a performance
24531 increase of about 1.4% on GNU/Linux - not much, but it's already
24532 half a second for the self-hosting MCS compilation.
24534 * typemanager.cs (IMemberFinder): New interface. It is used by
24535 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24536 Enum, Delegate or Interface.
24537 (TypeManager.finder_to_member_finder): New PtrHashtable.
24538 (TypeManager.finder_to_container): Removed.
24539 (TypeManager.finder_to_delegate): Removed.
24540 (TypeManager.finder_to_interface): Removed.
24541 (TypeManager.finder_to_enum): Removed.
24543 * interface.cs (Interface): Implement IMemberFinder.
24545 * delegate.cs (Delegate): Implement IMemberFinder.
24547 * enum.cs (Enum): Implement IMemberFinder.
24549 * class.cs (TypeContainer): Implement IMemberFinder.
24551 2002-08-12 Martin Baulig <martin@gnome.org>
24553 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24555 2002-08-12 Martin Baulig <martin@gnome.org>
24557 * ecore.cs (ITypeExpression): New interface for expressions which
24559 (TypeExpression): Renamed to TypeLookupExpression.
24560 (Expression.DoResolve): If we're doing a types-only lookup, the
24561 expression must implement the ITypeExpression interface and we
24562 call DoResolveType() on it.
24563 (SimpleName): Implement the new ITypeExpression interface.
24564 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24565 hack, the situation that we're only looking up types can't happen
24566 anymore when this method is called. Moved the type lookup code to
24567 DoResolveType() and call it.
24568 (SimpleName.DoResolveType): This ITypeExpression interface method
24569 is now doing the types-only lookup.
24570 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24571 (ResolveFlags): Added MaskExprClass.
24573 * expression.cs (MemberAccess): Implement the ITypeExpression
24575 (MemberAccess.DoResolve): Added support for a types-only lookup
24576 when we're called via ITypeExpression.DoResolveType().
24577 (ComposedCast): Implement the ITypeExpression interface.
24579 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24580 Expression.Resolve() with ResolveFlags.Type instead.
24582 2002-08-12 Martin Baulig <martin@gnome.org>
24584 * interface.cs (Interface.Define): Apply attributes.
24586 * attribute.cs (Attribute.ApplyAttributes): Added support for
24587 interface attributes.
24589 2002-08-11 Martin Baulig <martin@gnome.org>
24591 * statement.cs (Block.Emit): Only check the "this" variable if we
24592 do not always throw an exception.
24594 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24595 whether the property has a set accessor.
24597 2002-08-11 Martin Baulig <martin@gnome.org>
24599 Added control flow analysis support for structs.
24601 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24602 with control flow analysis turned off.
24603 (IVariable): New interface.
24604 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24605 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24606 (FieldExpr.DoResolve): Resolve the instance expression with flow
24607 analysis turned off and do the definite assignment check after the
24608 resolving when we know what the expression will resolve to.
24610 * expression.cs (LocalVariableReference, ParameterReference):
24611 Implement the new IVariable interface, only call the flow analysis
24612 code if ec.DoFlowAnalysis is true.
24613 (This): Added constructor which takes a Block argument. Implement
24614 the new IVariable interface.
24615 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24616 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24617 This does the definite assignment checks for struct members.
24619 * class.cs (Constructor.Emit): If this is a non-static `struct'
24620 constructor which doesn't have any initializer, call
24621 Block.AddThisVariable() to tell the flow analysis code that all
24622 struct elements must be initialized before control returns from
24625 * statement.cs (MyStructInfo): New public class.
24626 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24627 argument to this indexer. If non-zero, check an individual struct
24628 member, not the whole struct.
24629 (FlowBranching.CheckOutParameters): Check struct members.
24630 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24631 overloaded versions of these methods which take an additional
24632 `int field_idx' argument to check struct members.
24633 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24634 overloaded versions of these methods which take an additional
24635 `string field_name' argument to check struct member.s
24636 (VariableInfo): Implement the IVariable interface.
24637 (VariableInfo.StructInfo): New public property. Returns the
24638 MyStructInfo instance of the variable if it's a struct or null.
24639 (Block.AddThisVariable): New public method. This is called from
24640 Constructor.Emit() for non-static `struct' constructor which do
24641 not have any initializer. It creates a special variable for the
24642 "this" instance variable which will be checked by the flow
24643 analysis code to ensure that all of the struct's fields are
24644 initialized before control returns from the constructor.
24645 (UsageVector): Added support for struct members. If a
24646 variable/parameter is a struct with N members, we reserve a slot
24647 in the usage vector for each member. A struct is considered fully
24648 initialized if either the struct itself (slot 0) or all its
24649 members are initialized.
24651 2002-08-08 Martin Baulig <martin@gnome.org>
24653 * driver.cs (Driver.MainDriver): Only report an error CS5001
24654 if there were no compilation errors.
24656 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24657 `UnsafeContext' property to determine whether the parent is in
24658 unsafe context rather than checking the parent's ModFlags:
24659 classes nested in an unsafe class are unsafe as well.
24661 2002-08-08 Martin Baulig <martin@gnome.org>
24663 * statement.cs (UsageVector.MergeChildren): Distinguish between
24664 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24665 we return. Added test17() and test18() to test-154.cs.
24667 2002-08-08 Martin Baulig <martin@gnome.org>
24669 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24670 Family access, make sure the invoking type isn't a subclass of the
24671 queried type (that'd be a CS1540).
24673 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24674 this method which takes an additional `Type invocation_type'.
24676 * expression.cs (BaseAccess.DoResolve): Use the base type as
24677 invocation and query type.
24678 (MemberAccess.DoResolve): If the lookup failed and we're about to
24679 report a CS0122, try a lookup with the ec.ContainerType - if this
24680 succeeds, we must report a CS1540.
24682 2002-08-08 Martin Baulig <martin@gnome.org>
24684 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24685 (MethodGroupExpr): Implement the IMemberExpr interface.
24687 * expression (MemberAccess.ResolveMemberAccess): No need to have
24688 any special code for MethodGroupExprs anymore, they're now
24691 2002-08-08 Martin Baulig <martin@gnome.org>
24693 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24694 Family, FamANDAssem and FamORAssem permissions.
24695 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24697 2002-08-08 Martin Baulig <martin@gnome.org>
24699 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24700 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24703 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24705 * driver.cs: implemented /resource option to embed managed resources.
24707 2002-08-07 Martin Baulig <martin@gnome.org>
24709 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24710 (FieldBase.HasFieldInitializer): New public property.
24711 (FieldBase.GetInitializerExpression): New public method. Resolves and
24712 returns the field initializer and makes sure it is only resolved once.
24713 (TypeContainer.EmitFieldInitializers): Call
24714 FieldBase.GetInitializerExpression to get the initializer, this ensures
24715 that it isn't resolved multiple times.
24717 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24718 the resolving process (SimpleName/MemberLookup) that we're currently
24719 emitting a field initializer (which must not access any instance members,
24720 this is an error CS0236).
24722 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24723 argument, if the `IsFieldInitializer' flag is set, we must report and
24724 error CS0236 and not an error CS0120.
24726 2002-08-07 Martin Baulig <martin@gnome.org>
24728 * ecore.cs (IMemberExpr): New public interface.
24729 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24730 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24731 if the expression is an IMemberExpr.
24733 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24734 to be null, implicitly default to `this' if we're non-static in
24735 this case. Simplified the code a lot by using the new IMemberExpr
24736 interface. Also fixed bug #28176 here.
24738 2002-08-06 Martin Baulig <martin@gnome.org>
24740 * cs-parser.jay (SimpleLookup): Removed. We need to create
24741 ParameterReferences during semantic analysis so that we can do a
24742 type-only search when resolving Cast, TypeOf and SizeOf.
24743 (block): Pass the `current_local_parameters' to the Block's
24746 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24747 argument to the constructor.
24748 (ConstructorInitializer.Resolve): Create a temporary implicit
24749 block with the parameters.
24751 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24752 references here if we aren't doing a type-only search.
24754 * statement.cs (Block): Added constructor which takes a
24755 `Parameters parameters' argument.
24756 (Block.Parameters): New public property.
24758 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24759 to `Parameters' and made it public readonly.
24761 2002-08-06 Martin Baulig <martin@gnome.org>
24763 * ecore.cs (Expression.Warning): Made this public as well.
24765 * report.cs (Report.Debug): Print the contents of collections.
24767 2002-08-06 Martin Baulig <martin@gnome.org>
24769 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24770 used to tell Resolve() which kinds of expressions it may return.
24771 (Expression.Resolve): Added overloaded version of this method which
24772 takes a `ResolveFlags flags' argument. This can be used to tell
24773 Resolve() which kinds of expressions it may return. Reports a
24775 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24776 ResolveFlags.SimpleName.
24777 (Expression.Error118): Added overloaded version of this method which
24778 takes a `ResolveFlags flags' argument. It uses the flags to determine
24779 which kinds of expressions are allowed.
24781 * expression.cs (Argument.ResolveMethodGroup): New public method.
24782 Resolves an argument, but allows a MethodGroup to be returned.
24783 This is used when invoking a delegate.
24785 * TODO: Updated a bit.
24787 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24789 Fixed compilation with csc.
24791 * ecore.cs: Expression.Error made public. Is this correct? Should
24792 Warning be made public too?
24794 * expression.cs: use ea.Location instead of ea.loc.
24795 [FIXME: Filed as bug #28607: MCS must report these errors.]
24797 2002-08-06 Martin Baulig <martin@gnome.org>
24799 * ecore.cs (Expression.loc): Moved the location here instead of
24800 duplicating it in all derived classes.
24801 (Expression.Location): New public property.
24802 (Expression.Error, Expression.Warning): Made them non-static and
24803 removed the location argument.
24804 (Expression.Warning): Added overloaded version which takes an
24805 `int level' argument.
24806 (Expression.Error118): Make this non-static and removed the
24807 expression and location arguments.
24808 (TypeExpr): Added location argument to the constructor.
24810 * expression.cs (StaticCallExpr): Added location argument to
24812 (Indirection, PointerArithmetic): Likewise.
24813 (CheckedExpr, UnCheckedExpr): Likewise.
24814 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24815 (StringPtr): Likewise.
24818 2002-08-05 Martin Baulig <martin@gnome.org>
24820 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24822 * assign.cs (Assign.DoResolve): Check whether the source
24823 expression is a value or variable.
24825 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24826 while resolving the corresponding blocks.
24828 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24829 an error, don't silently return null.
24831 * statement.cs (Block.AddVariable): Do the error reporting here
24832 and distinguish between CS0128 and CS0136.
24833 (Block.DoResolve): Report all unused labels (warning CS0164).
24834 (LabeledStatement): Pass the location to the constructor.
24835 (LabeledStatement.HasBeenReferenced): New property.
24836 (LabeledStatement.Resolve): Set it to true here.
24838 * statement.cs (Return.Emit): Return success even after reporting
24839 a type mismatch error (CS0126 or CS0127), this is what csc does and
24840 it avoids confusing the users with any consecutive errors.
24842 2002-08-05 Martin Baulig <martin@gnome.org>
24844 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24846 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24848 * expression.cs (MemberAccess.DoResolve): Silently return if an
24849 error has already been reported.
24851 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24852 error has already been reported.
24854 2002-08-05 Martin Baulig <martin@gnome.org>
24856 * statement.cs (UsageVector): Only initialize the `parameters'
24857 vector if we actually have any "out" parameters.
24859 2002-08-05 Martin Baulig <martin@gnome.org>
24861 * expression.cs (Binary.ResolveOperator): When combining delegates,
24862 they must have the same type.
24864 2002-08-05 Martin Baulig <martin@gnome.org>
24866 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24867 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24868 work with the ms runtime and we also don't need it: if we're a
24869 PropertyBuilder and not in the `indexer_arguments' hash, then we
24870 are a property and not an indexer.
24872 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24873 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24874 since the latter one doesn't work with the ms runtime.
24876 2002-08-03 Martin Baulig <martin@gnome.org>
24878 Fixed bugs #27998 and #22735.
24880 * class.cs (Method.IsOperator): New public field.
24881 (Method.CheckBase): Report CS0111 if there's already a method
24882 with the same parameters in the current class. Report CS0508 when
24883 attempting to change the return type of an inherited method.
24884 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24885 and it's not marked abstract or extern.
24886 (PropertyBase): New abstract base class for Property and Indexer.
24887 (PropertyBase.CheckBase): Moved here from Property and made it work
24889 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24890 the same so we can reuse it there.
24891 (Property, Indexer): Derive from PropertyBase.
24892 (MethodSignature.inheritable_property_signature_filter): New delegate
24893 to find properties and indexers.
24895 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24896 argument and improved error reporting.
24898 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24899 EmptyReadOnlyParameters and made it a property.
24901 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24902 version of this method which takes a `PropertyInfo indexer'.
24903 (TypeManager.RegisterIndexer): New method.
24905 * class.cs: Added myself as author of this file :-)
24907 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24909 * class.cs: fixed compilation on windoze.
24911 2002-08-03 Martin Baulig <martin@gnome.org>
24913 * interface.cs (Interface.GetInterfaceBases): Check whether all
24914 base interfaces are at least as accessible than the current one.
24916 * class.cs (TypeContainer.GetClassBases): Check whether base types
24917 are at least as accessible than the current type.
24918 (TypeContainer.AsAccessible): Implemented and made non-static.
24919 (MemberBase.CheckParameters): Report errors if the accessibility
24922 * delegate.cs (Delegate.Delegate): The default visibility is
24923 internal for top-level types and private for nested types.
24924 (Delegate.Define): Report errors if the accessibility checks fail.
24926 * enum.cs (Enum.Enum): The default visibility is internal for
24927 top-level types and private for nested types.
24928 (Enum.DefineType): Compute the correct visibility.
24930 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24931 function which takes a `bool is_toplevel' instead of a TypeContainer.
24933 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24936 2002-08-02 Martin Baulig <martin@gnome.org>
24938 * expression.cs (LocalVariableReferenc): Added constructor which
24939 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24940 (LocalVariableReference.IsReadOnly): New property.
24941 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24942 variable is readonly, use our own readonly flag to do this; you can
24943 use the new constructor to get a writable reference to a read-only
24946 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24947 reference to the local variable.
24949 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24951 * rootcontext.cs (ResolveCore): Also include System.Exception
24953 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24954 we reach an EmptyStatement.
24956 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24959 * expression.cs (Binary.ResolveOperator): Check error result in
24962 use brtrue/brfalse directly and avoid compares to null.
24964 2002-08-02 Martin Baulig <martin@gnome.org>
24966 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24967 Fixes bug #28407, added test-155.cs.
24969 2002-08-01 Martin Baulig <martin@gnome.org>
24971 * class.cs (Event.EmitDefaultMethod): Make this work with static
24972 events. Fixes #28311, added verify-3.cs.
24974 2002-08-01 Martin Baulig <martin@gnome.org>
24976 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24977 `is_disposable' fields.
24978 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24979 `hm.is_disposable' if we're using the collection pattern.
24980 (Foreach.EmitCollectionForeach): Use the correct type for the
24981 enumerator's local variable, only emit the try/finally block if
24982 necessary (fixes #27713).
24984 2002-08-01 Martin Baulig <martin@gnome.org>
24986 * ecore.cs (Expression.report118): Renamed to Error118 and made
24989 * statement.cs (Throw.Resolve): Check whether the expression is of
24990 the correct type (CS0118) and whether the type derives from
24991 System.Exception (CS0155).
24992 (Catch.Resolve): New method. Do the type lookup here and check
24993 whether it derives from System.Exception (CS0155).
24994 (Catch.CatchType, Catch.IsGeneral): New public properties.
24996 * typemanager.cs (TypeManager.exception_type): Added.
24998 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25000 * driver.cs: Updated About function.
25002 2002-07-31 Martin Baulig <martin@gnome.org>
25004 Implemented Control Flow Analysis.
25006 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25007 (EmitContext.CurrentBranching): Added.
25008 (EmitContext.StartFlowBranching): Added.
25009 (EmitContext.EndFlowBranching): Added.
25010 (EmitContext.KillFlowBranching): Added.
25011 (EmitContext.IsVariableAssigned): Added.
25012 (EmitContext.SetVariableAssigned): Added.
25013 (EmitContext.IsParameterAssigned): Added.
25014 (EmitContext.SetParameterAssigned): Added.
25015 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25016 Added control flow analysis stuff here.
25018 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25019 resolve the expression as lvalue.
25020 (LocalVariableReference.DoResolve): Check whether the variable has
25021 already been assigned.
25022 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25023 the parameter as assigned here.
25024 (ParameterReference.DoResolve): Check whether the parameter has already
25026 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25027 expression as lvalue.
25029 * statement.cs (FlowBranching): New class for the flow analysis code.
25030 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25031 (LabeledStatement.IsDefined): New public property.
25032 (LabeledStatement.AddUsageVector): New public method to tell flow
25033 analyis that the label may be reached via a forward jump.
25034 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25036 (VariableInfo.Number): New public field. This is used by flow analysis
25037 to number all locals of a block.
25038 (Block.CountVariables): New public property. This is the number of
25039 local variables in this block (including the locals from all parent
25041 (Block.EmitMeta): Number all the variables.
25043 * statement.cs: Added flow analysis support to all classes.
25045 2002-07-31 Martin Baulig <martin@gnome.org>
25047 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25048 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25049 then use this argument.
25051 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25053 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25054 use this to specify /define options.
25056 2002-07-29 Martin Baulig <martin@gnome.org>
25058 * statement.cs (Fixed): Moved all code that does variable lookups
25059 and resolvings from Emit to Resolve.
25061 * statement.cs (For): Moved all code that does variable lookups
25062 and resolvings from Emit to Resolve.
25064 * statement.cs (Using): Moved all code that does variable lookups
25065 and resolvings from Emit to Resolve.
25067 2002-07-29 Martin Baulig <martin@gnome.org>
25069 * attribute.cs (Attribute.Resolve): Explicitly catch a
25070 System.NullReferenceException when creating the
25071 CustromAttributeBuilder and report a different warning message.
25073 2002-07-29 Martin Baulig <martin@gnome.org>
25075 * support.cs (ParameterData.ParameterName): Added method to
25076 get the name of a parameter.
25078 * typemanager.cs (TypeManager.IsValueType): New public method.
25080 2002-07-29 Martin Baulig <martin@gnome.org>
25082 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25083 is a flag which specifies that it's either ref or out.
25084 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25085 the out parameter to `out Parameter.Modifier mod', also set the
25086 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25088 * support.cs (InternalParameters.ParameterModifier): Distinguish
25089 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25090 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25092 * expression.cs (Argument.GetParameterModifier): Distinguish
25093 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25094 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25096 2002-07-29 Martin Baulig <martin@gnome.org>
25098 * expression.cs (ParameterReference.ParameterReference): Added
25099 `Location loc' argument to the constructor.
25101 * cs-parser.jay: Pass location to ParameterReference.
25103 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25105 * statement.cs (Try): Initialize the location.
25107 * cs-parser.jay: pass location to Try.
25109 * expression.cs (Unary.Reduce): Change the prototype to return
25110 whether a constant fold could be performed or not. The result is
25111 returned in an out parameters. In the case of Indirection and
25112 AddressOf, we want to perform the full tests.
25114 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25116 * statement.cs (Statement.Emit): Flag dead code.
25118 2002-07-27 Andrew Birkett <andy@nobugs.org>
25120 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25122 2002-07-27 Martin Baulig <martin@gnome.org>
25124 * class.cs (MethodData.Define): Put back call to
25125 TypeManager.AddMethod(), accidentally commented this out.
25127 * report.cs (Debug): New public method to print debugging information,
25128 this is `[Conditional ("DEBUG")]'.
25130 2002-07-26 Martin Baulig <martin@gnome.org>
25132 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25133 (switch_statement): Push the current_block to the switch_stack and
25134 pop it again when we're done with the switch.
25135 (switch_section): The new block is a child of the current_block.
25136 Fixes bug #24007, added test-152.cs.
25138 2002-07-27 Martin Baulig <martin@gnome.org>
25140 * expression.cs (Invocation.EmitArguments): When calling a varargs
25141 function with only its fixed arguments, we need to pass an empty
25144 2002-07-27 Martin Baulig <martin@gnome.org>
25146 Mono 0.13 has been released.
25148 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25150 * driver.cs: Rename --resource to --linkres, because that is what
25151 we do currently, we dont support --resource yet.
25153 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25155 2002-07-25 Martin Baulig <martin@gnome.org>
25157 * class.cs (MethodData): New public class. This is a `method builder'
25158 class for a method or one accessor of a Property/Indexer/Event.
25159 (MethodData.GetMethodFlags): Moved here from MemberBase.
25160 (MethodData.ApplyAttributes): Likewise.
25161 (MethodData.ApplyObsoleteAttribute): Likewise.
25162 (MethodData.ApplyConditionalAttribute): Likewise.
25163 (MethodData.ApplyDllImportAttribute): Likewise.
25164 (MethodData.CheckAbstractAndExternal): Likewise.
25165 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25166 (MethodData.Emit): Formerly known as Method.Emit().
25167 (MemberBase): Moved everything which was specific to a single
25168 accessor/method to MethodData.
25169 (Method): Create a new MethodData and call Define() and Emit() on it.
25170 (Property, Indexer, Event): Create a new MethodData objects for each
25171 accessor and call Define() and Emit() on them.
25173 2002-07-25 Martin Baulig <martin@gnome.org>
25175 Made MethodCore derive from MemberBase to reuse the code from there.
25176 MemberBase now also checks for attributes.
25178 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25179 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25181 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25182 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25183 (MemberBase.ApplyAttributes): New virtual method; applies the
25184 attributes to a method or accessor.
25185 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25186 (MemberBase.ApplyConditionalAttribute): Likewise.
25187 (MemberBase.ApplyDllImportAttribute): Likewise.
25188 (MemberBase.CheckAbstractAndExternal): Likewise.
25189 (MethodCore.ParameterTypes): This is now a property instead of a
25190 method, it's initialized from DoDefineParameters().
25191 (MethodCore.ParameterInfo): Removed the set accessor.
25192 (MethodCore.DoDefineParameters): New protected virtual method to
25193 initialize ParameterTypes and ParameterInfo.
25194 (Method.GetReturnType): We can now simply return the MemberType.
25195 (Method.GetMethodFlags): Override the MemberBase version and add
25196 the conditional flags.
25197 (Method.CheckBase): Moved some code from Define() here, call
25198 DoDefineParameters() here.
25199 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25200 here to avoid some larger code duplication.
25201 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25202 ensure that abstract and external accessors don't declare a body.
25204 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25205 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25206 lookup in the attribute's parent classes, so we need to abort as soon
25207 as we found the first match.
25208 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25209 the attribute has no arguments.
25211 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25214 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25216 * cs-parser.jay: reverted previous patch.
25218 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25220 * cs-parser.jay: fixed bug #22119.
25222 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25224 * attribute.cs: fixed compilation. The error was:
25225 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25226 be assigned to before control leaves the current method."
25227 [FIXME: Filed as bug #28186: MCS must report this error.]
25229 2002-07-25 Martin Baulig <martin@gnome.org>
25231 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25232 method to pull the condition name ouf of a Conditional attribute.
25233 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25234 the obsolete message and error flag out of an Obsolete attribute.
25236 * class.cs (Method.GetMethodFlags): New public method to get the
25237 TypeManager.MethodFlags for this method.
25238 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25240 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25241 if we're overriding a virtual function, set the new private variable
25242 `parent_method'; call the new TypeManager.AddMethod().
25244 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25245 the MethodBuilder and the Method in a PtrHashtable.
25246 (TypeManager.builder_to_method): Added for this purpose.
25247 (TypeManager.MethodFlags): Added IsObsoleteError.
25248 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25249 Obsolete and Conditional arguments in MethodBuilders. If we discover
25250 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25251 the message from the attribute.
25253 2002-07-24 Martin Baulig <martin@gnome.org>
25255 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25256 preprocessor directives, ensure that the argument to #define/#undef is
25257 exactly one identifier and that it's actually an identifier.
25259 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25262 2002-07-24 Martin Baulig <martin@gnome.org>
25264 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25265 initialize it to TypeManager.object_type in the constructor.
25266 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25267 of the `hm.get_current' method if we're using the collection pattern.
25268 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25269 for the explicit conversion to make it work when we're using the collection
25270 pattern and the `Current' property has a different return type than `object'.
25273 2002-07-24 Martin Baulig <martin@gnome.org>
25275 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25276 does not match, but don't report any errors. This method is called in
25277 order for all methods in a MethodGroupExpr until a matching method is
25278 found, so we don't want to bail out if the first method doesn't match.
25279 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25280 matches, report the 123. Fixes #28070.
25282 2002-07-24 Martin Baulig <martin@gnome.org>
25284 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25285 TypeManager.TypeToCoreType() to the top of the method so the
25286 following equality checks will work. Fixes #28107.
25288 2002-07-24 Martin Baulig <martin@gnome.org>
25290 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25291 operand is of type uint, and the other operand is of type sbyte,
25292 short or int, the operands are converted to type long." -
25293 Actually do what this comment already told us. Fixes bug #28106,
25296 2002-07-24 Martin Baulig <martin@gnome.org>
25298 * class.cs (MethodBase): New abstract class. This is now a base
25299 class for Property, Indexer and Event to avoid some code duplication
25300 in their Define() and DefineMethods() methods.
25301 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25302 generic methods for Define() and DefineMethods().
25303 (FieldBase): Derive from MemberBase, not MemberCore.
25304 (Property): Derive from MemberBase, not MemberCore.
25305 (Property.DefineMethod): Moved all the code from this method to the
25306 new MethodBase.DefineAccessor(), just call it with appropriate
25308 (Property.Define): Call the new Property.DoDefine(), this does some
25309 sanity checks and we don't need to duplicate the code everywhere.
25310 (Event): Derive from MemberBase, not MemberCore.
25311 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25312 accessors, this will also make them work with interface events.
25313 (Indexer): Derive from MemberBase, not MemberCore.
25314 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25315 (Indexer.Define): Use the new MethodBase functions.
25317 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25318 argument to the constructor.
25319 (Interface.FindMembers): Added support for interface events.
25320 (Interface.PopluateEvent): Implemented.
25322 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25324 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25326 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25327 but this is required to check for a method name being the same as
25328 the containing class.
25332 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25334 * interface.cs: initialize variable.
25336 2002-07-23 Martin Baulig <martin@gnome.org>
25338 Implemented the IndexerName attribute in interfaces.
25340 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25341 name if this is an explicit interface implementation.
25342 (Indexer.InterfaceIndexerName): New public variable. If we're
25343 implementing an interface indexer, this is the IndexerName in that
25344 interface. Otherwise, it's the IndexerName.
25345 (Indexer.DefineMethod): If we're implementing interface indexer,
25346 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25347 and Pending.ImplementIndexer methods.
25348 (Indexer.Define): Also define the PropertyBuilder if we're
25349 implementing an interface indexer and this is neither an explicit
25350 interface implementation nor do the IndexerName match the one in
25353 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25354 If a method is defined here, then we always need to create a proxy
25355 for it. This is used when implementing interface indexers.
25356 (Pending.IsInterfaceIndexer): New public method.
25357 (Pending.ImplementIndexer): New public method.
25358 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25359 This is used when implementing interface indexers to define a proxy
25361 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25362 define a proxy if necessary.
25364 * interface.cs (Interface.IndexerName): New public variable.
25365 (Interface.PopulateIndexer): Set the IndexerName.
25366 (Interface.DefineIndexers): New private method. Populate all the
25367 indexers and make sure their IndexerNames match.
25369 * typemanager.cs (IndexerPropertyName): Added support for interface
25372 2002-07-22 Martin Baulig <martin@gnome.org>
25374 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25375 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25376 ret if HasReturnLabel.
25377 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25380 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25381 and set the ec.LoopBeginTryCatchLevel.
25382 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25383 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25384 the current ec.TryCatchLevel, the branch goes out of an exception
25385 block. In this case, we need to use Leave and not Br.
25387 2002-07-22 Martin Baulig <martin@gnome.org>
25389 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25390 block unless the block does not always return or it is contained in
25391 another try { ... } catch { ... } block. Fixes bug #26506.
25392 Added verify-1.cs to the test suite.
25394 2002-07-22 Martin Baulig <martin@gnome.org>
25396 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25397 then we do not always return. Fixes bug #24985.
25399 2002-07-22 Martin Baulig <martin@gnome.org>
25401 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25402 lookup on a per-class level; ie. walk up the class hierarchy until we
25403 found at least one applicable method, then choose the best among them.
25404 Fixes bug #24463 and test-29.cs.
25406 2002-07-22 Martin Baulig <martin@gnome.org>
25408 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25409 return types of the methods. The return type is not part of the
25410 signature and we must not check it to make the `new' modifier work.
25411 Fixes bug #27999, also added test-147.cs.
25412 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25414 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25415 on the method's return type.
25417 2002-07-21 Martin Baulig <martin@gnome.org>
25419 * assign.cs: Make this work if the rightmost source is a constant and
25420 we need to do an implicit type conversion. Also adding a few more tests
25421 to test-38.cs which should have caught this.
25423 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25424 target in the makefile for this. The makefile.gnu is primarily intended
25425 for end-users who don't want to debug the compiler.
25427 2002-07-21 Martin Baulig <martin@gnome.org>
25429 * assign.cs: Improved the Assign class so it can now handle embedded
25430 assignments (X = Y = Z = something). As a side-effect this'll now also
25431 consume less local variables. test-38.cs now passes with MCS, added
25432 a few new test cases to that test.
25434 2002-07-20 Martin Baulig <martin@gnome.org>
25436 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25437 instructions. Fixes bug #27977, also added test-146.cs.
25439 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25441 * cs-tokenizer.cs: fixed getHex ().
25443 2002-07-19 Martin Baulig <martin@gnome.org>
25445 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25446 not Type.GetType() to lookup the array type. This is needed when
25447 we're constructing an array of a user-defined type.
25448 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25449 single-dimensional arrays, but also for single-dimensial arrays of
25452 2002-07-19 Martin Baulig <martin@gnome.org>
25454 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25455 this function is called, it's not allowed to share LocalBuilders
25456 among ILGenerators.
25458 2002-07-19 Martin Baulig <martin@gnome.org>
25460 * expression.cs (Argument.Resolve): Report an error 118 when trying
25461 to pass a type as argument.
25463 2002-07-18 Martin Baulig <martin@gnome.org>
25465 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25466 Conv_R_Un for the signed `long' type.
25468 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25470 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25471 `expr' for the temporary result, as that will fail if we do
25472 multiple resolves on the same expression.
25474 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25476 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25477 ec.TypeContainer for looking up aliases.
25479 * class.cs (TypeContainer): Remove LookupAlias from here.
25481 * decl.cs (DeclSpace); Move here.
25483 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25485 * class.cs (FindMembers): Only call filter if the constructor
25486 bulider is not null.
25488 Also handle delegates in `NestedTypes' now. Now we will perform
25489 type lookups using the standard resolution process. This also
25492 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25493 This uses Expressions (the limited kind that can be parsed by the
25494 tree) instead of strings.
25496 * expression.cs (ComposedCast.ToString): Implement, used to flag
25497 errors since now we have to render expressions.
25499 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25502 * ecore.cs (SimpleName.ToString): ditto.
25504 * cs-parser.jay: Instead of using strings to assemble types, use
25505 Expressions to assemble the type (using SimpleName, ComposedCast,
25506 MemberAccess). This should fix the type lookups in declarations,
25507 because we were using a different code path for this.
25509 * statement.cs (Block.Resolve): Continue processing statements
25510 even when there is an error.
25512 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25514 * class.cs (Event.Define): Also remove the `remove' method from
25515 the list of pending items.
25517 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25518 generate more compact code.
25520 2002-07-17 Martin Baulig <martin@gnome.org>
25522 * const.cs (Const.LookupConstantValue): Add support for constant
25523 `unchecked' and `checked' expressions.
25524 Also adding test case test-140.cs for this.
25526 2002-07-17 Martin Baulig <martin@gnome.org>
25528 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25529 check whether mi.ReturnType implements the IEnumerator interface; the
25530 `==' and the IsAssignableFrom() will fail in this situation.
25532 2002-07-16 Ravi Pratap <ravi@ximian.com>
25534 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25537 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25539 * expression.cs: fixed bug #27811.
25541 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25543 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25544 Molaro: when we are a ref, the value already contains a pointer
25545 value, do not take the address of it.
25547 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25548 * removed mb-parser.jay and mb-tokenizer.cs
25550 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25552 * expression.cs: check against the building corlib void type.
25554 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25556 * ecore.cs: fix for valuetype static readonly fields: when
25557 initializing them, we need their address, not the address of a copy.
25559 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25561 * typemanager.cs: register also enum_type in corlib.
25563 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25565 * class.cs: allow calling this (but not base) initializers in structs.
25567 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25569 * ecore.cs: make sure we compare against the building base types
25572 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25574 * typemanager.cs: fix TypeToCoreType() to handle void and object
25575 (corlib gets no more typerefs after this change).
25577 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25579 * expression.cs (ArrayCreation.EmitArrayArguments): use
25580 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25582 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25583 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25584 array indexes, the runtime actually forbids them.
25586 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25587 for array arguments here.
25589 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25590 instead of the default for ValueTypes.
25592 (New.DoEmit): Use IsValueType instead of
25593 IsSubclassOf (value_type)
25594 (New.DoResolve): ditto.
25595 (Invocation.EmitCall): ditto.
25597 * assign.cs (Assign): ditto.
25599 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25600 Statements *are* currently doing part of their resolution during
25603 Expressions do always resolve during resolve, but statements are
25604 only required to propagate resolution to their children.
25606 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25608 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25610 (LoadAssembly): Do not add the dll if it is already specified
25612 (MainDriver): Add the System directory to the link path at the end,
25613 after all the other -L arguments.
25615 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25616 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25617 ldelem.u1) and using the opposite for sbytes.
25619 This fixes Digger, and we can finally run it.
25621 * driver.cs (UnixParseOption): Move the option parsing here.
25622 (CSCParseOption): Implement CSC-like parsing of options.
25624 We now support both modes of operation, the old Unix way, and the
25625 new CSC-like way. This should help those who wanted to make cross
25626 platform makefiles.
25628 The only thing broken is that /r:, /reference: and /lib: are not
25629 implemented, because I want to make those have the same semantics
25630 as the CSC compiler has, and kill once and for all the confussion
25631 around this. Will be doing this tomorrow.
25633 * statement.cs (Unsafe.Resolve): The state is checked during
25634 resolve, not emit, so we have to set the flags for IsUnsfe here.
25636 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25638 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25639 not catch the Error_ObjectRefRequired in SimpleName (as it is
25640 possible to have a class/instance variable name that later gets
25641 deambiguated), we have to check this here.
25643 2002-07-10 Ravi Pratap <ravi@ximian.com>
25645 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25646 make static and put into Expression.
25648 (Event.Define): Register the private field of the event with the
25649 TypeManager so that GetFieldFromEvent can get at it.
25651 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25652 keep track of the private field associated with an event which
25655 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25658 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25660 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25662 * expression.cs (Binary.EmitBranchable): this routine emits the
25663 Binary expression in a branchable context. This basically means:
25664 we need to branch somewhere, not just get the value on the stack.
25666 This works together with Statement.EmitBoolExpression.
25668 * statement.cs (Statement.EmitBoolExpression): Use
25671 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25673 * statement.cs (For): Reduce the number of jumps in loops.
25675 (For): Implement loop inversion for the For statement.
25677 (Break): We can be breaking out of a Try/Catch controlled section
25678 (foreach might have an implicit try/catch clause), so we need to
25679 use Leave instead of Br.
25681 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25682 now). If the instace expression supports IMemoryLocation, we use
25683 the AddressOf method from the IMemoryLocation to extract the
25684 address instead of emitting the instance.
25686 This showed up with `This', as we were emitting the instance
25687 always (Emit) instead of the Address of This. Particularly
25688 interesting when This is a value type, as we dont want the Emit
25689 effect (which was to load the object).
25691 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25693 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25695 * statement.cs (Checked): Set the CheckedState during the resolve
25696 process too, as the ConvCast operations track the checked state on
25697 the resolve process, and not emit.
25699 * cs-parser.jay (namespace_member_declaration): Flag that we have
25700 found a declaration when we do. This is used to flag error 1529
25702 * driver.cs: Report ok when we display the help only.
25704 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25706 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25708 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25710 * cs-tokenizer.cs (define): We also have to track locally the
25711 defines. AllDefines is just used for the Conditional Attribute,
25712 but we also need the local defines for the current source code.
25714 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25716 * statement.cs (While, For, Do): These loops can exit through a
25717 Break statement, use this information to tell whether the
25718 statement is the last piece of code.
25720 (Break): Flag that we break.
25722 * codegen.cs (EmitContexts): New `Breaks' state variable.
25724 2002-07-03 Martin Baulig <martin@gnome.org>
25726 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25727 modifiers in method declarations in structs. Otherwise, you won't
25728 be able to override things like Object.Equals().
25730 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25732 * class.cs (Method, Property, Indexer): Do not allow the public
25733 modifier to be used in explicit interface implementations.
25735 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25736 override modifiers in method declarations in structs
25738 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25740 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25741 integer or real overflow, report an error
25743 2002-07-02 Martin Baulig <martin@gnome.org>
25745 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25746 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25747 to tell the runtime about our newly created System.Object and
25748 System.ValueType types.
25750 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25752 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25753 struct instead of Ldarg/Starg.
25755 2002-07-02 Martin Baulig <martin@gnome.org>
25757 * expression.cs (Indirection.Indirection): Call
25758 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25760 2002-07-02 Martin Baulig <martin@gnome.org>
25762 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25763 ValueType, call TypeManager.TypeToCoreType() on it.
25764 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25765 the OpCodes.Newarr argument.
25767 2002-07-02 Martin Baulig <martin@gnome.org>
25769 * expression.cs (Invocation.EmitCall): When compiling corlib,
25770 replace all calls to the system's System.Array type to calls to
25771 the newly created one.
25773 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25774 System.Array methods.
25775 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25776 from the system's System.Array type which must be replaced.
25778 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25780 * typemanager.cs: load unverifiable_code_ctor so we can build
25781 corlib using the correct type. Avoid using GetTypeCode() with
25783 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25784 TypeManager.object_type to allow building corlib.
25786 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25788 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25790 2002-07-01 Martin Baulig <martin@gnome.org>
25792 * class.cs: Make the last change actually work, we need to check
25793 whether `ifaces != null' to avoid a crash.
25795 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25797 * class.cs: when we build structs without fields that implement
25798 interfaces, we need to add the interfaces separately, since there is
25799 no API to both set the size and add the interfaces at type creation
25802 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25804 * expression.cs: the dimension arguments to the array constructors
25805 need to be converted if they are a long.
25807 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25809 * class.cs: don't emit ldarg.0 if there is no parent constructor
25810 (fixes showstopper for corlib).
25812 2002-06-29 Martin Baulig <martin@gnome.org>
25814 MCS now compiles corlib on GNU/Linux :-)
25816 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25817 ie. check for MethodImplOptions.InternalCall.
25819 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25820 and TypeManager.attribute_type are null, so we must explicitly check
25821 whether parent is not null to find out whether it's an attribute type.
25822 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25823 and SetBuilder, not only if the property is neither abstract nor external.
25824 This is necessary to set the MethodImplOptions on the accessor methods.
25825 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25826 SetBuilder, see Property.Emit().
25828 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25829 populate "System.Object", "System.ValueType" and "System.Attribute" since
25830 they've already been populated from BootCorlib_PopulateCoreTypes().
25832 2002-06-29 Martin Baulig <martin@gnome.org>
25834 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25835 is the NullLiteral, we also need to make sure that target_type is not
25838 2002-06-29 Martin Baulig <martin@gnome.org>
25840 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25841 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25842 before calling BootstrapCorlib_ResolveDelegate ().
25844 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25846 * statement.cs: fixed build-breaker. All tests passed ok.
25848 2002-06-27 Martin Baulig <martin@gnome.org>
25850 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25851 for System.Decimal when compiling corlib.
25853 2002-06-27 Martin Baulig <martin@gnome.org>
25855 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25856 switch blocks which contain nothing but a default clause.
25858 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25860 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25862 2002-06-27 Martin Baulig <martin@gnome.org>
25864 * ecore.cs (PropertyExpr.PropertyExpr): Call
25865 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25867 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25868 is already a TypeBuilder.
25870 2002-06-27 Martin Baulig <martin@gnome.org>
25872 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25873 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25874 the "from an array-type to System.Array" case. This makes it work
25875 when compiling corlib.
25877 2002-06-27 Martin Baulig <martin@gnome.org>
25879 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25880 non-static PropertyExpr, set its InstanceExpression. This makes
25881 the `ICollection.Count' property work in System/Array.cs.
25883 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25885 * driver.cs: Made error handling more consistent. Errors now
25886 tracked by Report class, so many methods which used to return int
25887 now return void. Main() now prints success/failure and
25888 errors/warnings message.
25890 Renamed '--probe' compiler argument to '--expect-error'. Removed
25891 the magic number return values (123 and 124). Now, if the
25892 expected error occurs, the compiler exits with success (exit value
25893 0). If the compilation completes without seeing that particular
25894 error, the compiler exits with failure (exit value 1). The
25895 makefile in mcs/errors has been changed to handle the new behaviour.
25897 * report.cs: Made 'expected error' number a property and renamed
25898 it from 'Probe' to 'ExpectedError'.
25900 * genericparser.cs: Removed error handling support, since it is
25901 now all done by Report class.
25903 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25904 class, so parse() no longer returns an int.
25906 * namespace.cs: Use Report.Error instead of GenericParser.error
25908 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25910 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25911 TypeContainer.AddOperator): At the front of the list put the
25912 explicit implementations, so they get resolved/defined first.
25914 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25916 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25917 interface type is implemented by this TypeContainer. Used during
25918 explicit interface implementation.
25920 (Property.Define, Indexer.Define, Method.Define): Validate that
25921 the given interface in the explicit implementation is one of the
25922 base classes for the containing type.
25924 Also if we are explicitly implementing an interface, but there is
25925 no match in the pending implementation table, report an error.
25927 (Property.Define): Only define the property if we are
25928 not explicitly implementing a property from an interface. Use the
25929 correct name also for those properties (the same CSC uses,
25930 although that is really not needed).
25932 (Property.Emit): Do not emit attributes for explicitly implemented
25933 properties, as there is no TypeBuilder.
25935 (Indexer.Emit): ditto.
25937 Hiding then means that we do not really *implement* a pending
25938 implementation, which makes code fail.
25940 2002-06-22 Martin Baulig <martin@gnome.org>
25942 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25943 the return value of Object.GetType(). [FIXME: we need to do this whenever
25944 we get a type back from the reflection library].
25946 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25948 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25950 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25952 * attribute.cs: Return null if we can not look up the type.
25954 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25955 the interface types found.
25957 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25958 interface types found.
25960 * typemanager.cs (GetInterfaces): Make this routine returns alll
25961 the interfaces and work around the lame differences between
25962 System.Type and System.Reflection.Emit.TypeBuilder in the results
25963 result for GetInterfaces.
25965 (ExpandInterfaces): Given an array of interface types, expand and
25966 eliminate repeated ocurrences of an interface. This expands in
25967 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25970 2002-06-21 Martin Baulig <martin@gnome.org>
25972 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25975 2002-06-21 Martin Baulig <martin@gnome.org>
25977 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25978 and called with one of the core types, return the corresponding typebuilder for
25981 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25984 2002-06-21 Martin Baulig <martin@gnome.org>
25986 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25987 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25988 (Expression.ConvertReferenceExplicit): Likewise.
25990 * expression.cs (ElementAccess.DoResolve): Likewise.
25991 (ElementAccess.DoResolveLValue): Likewise.
25993 2002-06-10 Martin Baulig <martin@gnome.org>
25995 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25996 add the "value" parameter to the parameter list.
25998 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26001 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26003 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26004 the argument to an int, uint, long or ulong, per the spec. Also
26005 catch negative constants in array creation.
26007 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26009 * class.cs: do not allow the same interface to appear twice in
26010 the definition list.
26012 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26014 * ecore.cs: don't use ldlen with System.Array.
26016 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26018 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26020 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26022 * modifiers.cs: produce correct field attributes for protected
26023 internal. Easy fix so miguel can work on ther harder stuff:-)
26025 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26027 * pending.cs: New file. Move the code from class.cs here.
26028 Support clearning the pending flag for all methods (when not doing
26029 explicit interface implementation).
26031 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26033 * rootcontext.cs: added a couple more types needed to bootstrap.
26035 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26037 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26038 constructor in the type, instead of any constructor in the type
26039 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26040 a bug in the Mono runtime when applying the params attribute).
26042 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26043 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26045 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26047 * expression.cs (Unary.ResolveOperator): Use TypeManager
26048 to resolve the type.
26050 2002-06-13 Ravi Pratap <ravi@ximian.com>
26052 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26055 * enum.cs (AddEnumMember): Add support to store the attributes associated
26056 with each member too.
26058 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26059 field builders too - this takes care of the enum member case.
26061 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26063 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26064 address-of operator on both value types and pointers.
26066 2002-06-10 Martin Baulig <martin@gnome.org>
26068 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26069 PropertyBuilder to the `property_builders' list.
26071 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26072 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26073 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26074 find any indexers which are inherited from an interface.
26076 2002-06-09 Martin Baulig <martin@gnome.org>
26078 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26079 the same type as the constant if necessary. There's also a test-130.cs
26082 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26084 * typemanager.cs (TypeManager.ChangeType): Previously known as
26085 Enum.ChangeEnumType().
26087 2002-06-09 Martin Baulig <martin@gnome.org>
26089 * expression.cs (Cast.TryReduce): Added support for consts.
26091 2002-06-08 Ravi Pratap <ravi@ximian.com>
26093 * class.cs (Accessor): Hold attributes information so we can pass
26096 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26097 Modify to pass in attributes attached to the methods.
26099 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26101 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26102 to handle the Accessor kind :-)
26104 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26106 2002-06-08 Martin Baulig <martin@gnome.org>
26108 * expression.cs (Unary.TryReduceNegative): Added support for
26111 2002-06-08 Martin Baulig <martin@gnome.org>
26113 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26114 name can't be found in the `defined_names' - the caller will do a
26115 MemberLookup in this case and thus find methods in System.Enum
26116 such as Enum.IsDefined().
26118 2002-06-08 Martin Baulig <martin@gnome.org>
26120 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26121 Convert.ChangeType() which works with TypeBuilder created types.
26122 (Enum.LookupEnumValue, Enum.Define): Use it here.
26124 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26125 `TypeBuilder.BaseType != null' check.
26126 (TypeContainer.FindMembers): Only lookup parent members if we
26127 actually have a parent.
26128 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26129 (ConstructorInitializer.Resolve): Likewise.
26131 * interface.cs (Interface.FindMembers): Added
26132 `TypeBuilder.BaseType != null' check.
26134 * rootcontext.cs (RootContext.ResolveCore): Added
26135 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26136 classes_second_stage.
26138 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26139 debug_type and trace_type when compiling with --nostdlib.
26141 2002-06-07 Martin Baulig <martin@gnome.org>
26143 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26144 (AddField): Set it to true when adding a non-static field.
26145 (DefineType): Use `have_nonstatic_fields' to find out whether we
26146 have non-static fields, not `Fields != null'.
26148 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26150 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26151 dereferencing a null on the static-field code path)
26153 2002-05-30 Martin Baulig <martin@gnome.org>
26155 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26156 to take command line arguments. Use reflection to call the new
26157 custom `Initialize' function on the symbol writer and pass it the
26158 command line arguments.
26160 * driver.cs (--debug-args): New command line argument to pass command
26161 line arguments to the symbol writer.
26163 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26165 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26166 the target type for indexers and properties. Thanks to Joe for
26169 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26171 * typemanager.cs (MethodFlags): returns the method flags
26172 (Obsolete/ShouldIgnore) that control warning emission and whether
26173 the invocation should be made, or ignored.
26175 * expression.cs (Invocation.Emit): Remove previous hack, we should
26176 not do this on matching a base type, we should do this based on an attribute
26178 Only emit calls to System.Diagnostics.Debug and
26179 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26180 on the command line.
26182 * rootcontext.cs: Global settings for tracing and debugging.
26184 * cs-tokenizer.cs (define): New utility function to track
26185 defines. Set the global settings for TRACE and DEBUG if found.
26187 2002-05-25 Ravi Pratap <ravi@ximian.com>
26189 * interface.cs (Populate*): Pass in the TypeContainer as well as
26190 the DeclSpace as parameters so that we can create EmitContexts and
26191 then use that to apply attributes etc.
26193 (PopulateMethod, PopulateEvent, PopulateProperty)
26194 (PopulateIndexer): Apply attributes everywhere.
26196 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26199 (ApplyAttributes): Update accordingly.
26201 We now apply interface attributes for all members too.
26203 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26205 * class.cs (Indexer.Define); Correctly check if we are explicit
26206 implementation (instead of checking the Name for a ".", we
26207 directly look up if the InterfaceType was specified).
26209 Delay the creation of the PropertyBuilder.
26211 Only create the PropertyBuilder if we are not an explicit
26212 interface implementation. This means that explicit interface
26213 implementation members do not participate in regular function
26214 lookups, and hence fixes another major ambiguity problem in
26215 overload resolution (that was the visible effect).
26217 (DefineMethod): Return whether we are doing an interface
26220 * typemanager.cs: Temporary hack until we get attributes in
26221 interfaces (Ravi is working on that) and we get IndexerName
26222 support in interfaces.
26224 * interface.cs: Register the indexers as properties.
26226 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26227 warning, I have verified that this is a bug in the .NET runtime
26228 (JavaScript suffers of the same problem).
26230 * typemanager.cs (MemberLookup): When looking up members for
26231 interfaces, the parent of an interface is the implicit
26232 System.Object (so we succeed in searches of Object methods in an
26233 interface method invocation. Example: IEnumerable x; x.ToString
26236 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26238 * class.cs (Event): Events should also register if they do
26239 implement the methods that an interface requires.
26241 * typemanager.cs (MemberLookup); use the new GetInterfaces
26244 (GetInterfaces): The code used to lookup interfaces for a type is
26245 used in more than one place, factor it here.
26247 * driver.cs: Track the errors at the bottom of the file, we kept
26250 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26251 instance if the method we are calling is static!
26253 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26255 * attribute.cs (ApplyAttributes): Make this function filter out
26256 the IndexerName attribute (as that attribute in reality is never
26257 applied) and return the string constant for the IndexerName
26260 * class.cs (TypeContainer.Emit): Validate that all the indexers
26261 have the same IndexerName attribute, and if so, set the
26262 DefaultName attribute on the class.
26264 * typemanager.cs: The return value might contain other stuff (not
26265 only methods). For instance, consider a method with an "Item"
26266 property and an Item method.
26268 * class.cs: If there is a problem with the parameter types,
26271 2002-05-24 Ravi Pratap <ravi@ximian.com>
26273 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26274 looks at user defined conversion after making a call to
26275 StandardConversionExists - we need this for overload resolution.
26277 * expression.cs : Update accordingly the various method calls.
26279 This fixes 2 bugs filed against implicit user defined conversions
26281 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26283 * statement.cs: Track the result of the assignment.
26285 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26287 * expression.cs (MemberAccess): Improved error reporting for
26288 inaccessible members.
26290 2002-05-22 Martin Baulig <martin@gnome.org>
26292 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26293 itself with debugging support.
26295 2002-05-22 Martin Baulig <martin@gnome.org>
26297 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26298 Removed, this isn't needed anymore.
26300 2002-05-20 Martin Baulig <martin@gnome.org>
26302 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26303 be underlying type for an enum.
26305 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26307 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26308 that splits out the loading of just the core types.
26310 * rootcontext.cs (ResolveCore): Split the struct resolution in
26311 two, so we can load the enumeration underlying types before any
26314 * expression.cs (Is): Bandaid until we fix properly Switch (see
26315 bug #24985 for details).
26317 * typemanager.cs (ImplementsInterface): The hashtable will contain
26318 a null if there are no interfaces implemented.
26320 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26322 * cs-parser.jay (indexer_declarator): It is fine to have array
26325 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26327 * typemanager.cs: (RegisterBuilder): New function used to register
26328 TypeBuilders that implement interfaces. Since
26329 TypeBuilder.GetInterfaces (as usual) does not work with lame
26331 (AddUserType): register interfaces.
26333 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26334 dealing with TypeBuilder. Also, arrays are showing up as
26335 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26336 methods can not be invoked on them!
26338 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26339 (ImplicitReferenceConversionExists): Split out from
26340 StandardConversionExists.
26342 * expression.cs (As): We were only implementing one of the three
26343 cases for the as operator. We now implement them all.
26344 (Is): Implement the various other cases for Is as well.
26346 * typemanager.cs (CACHE): New define used to control if we want or
26347 not the FindMembers cache. Seems to have a negative impact on
26348 performance currently
26350 (MemberLookup): Nested types have full acess to
26351 enclosing type members
26353 Remove code that coped with instance/static returns for events, we
26354 now catch this in RealFindMembers.
26356 (RealFindMembers): only perform static lookup if the instance
26357 lookup did not return a type or an event.
26359 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26361 * assign.cs (CompoundAssign): We pass more semantic information
26362 now to Compound Assignments than we did before: now we have all
26363 the information at hand, and now we resolve the target *before* we
26364 do the expression expansion, which allows the "CacheValue" method
26365 to have the effect we intended (before, a [x] += 1 would generate
26366 two differen ArrayAccess expressions from the ElementAccess,
26367 during the resolution process).
26369 (CompoundAssign.DoResolve): Resolve target and original_source here.
26371 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26373 * expression.cs (ArrayAccess): dropped debugging information.
26375 * typemanager.cs: Small bug fix: I was always returning i_members,
26376 instead of one of i_members or s_members (depending on which had
26379 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26380 method is invoked before any code generation takes place, and it
26381 is a mechanism to inform that the expression will be invoked more
26382 than once, and that the method should use temporary values to
26383 avoid having side effects
26385 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26387 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26390 * expression.cs (Indirection, ArrayAccess): Add support for
26391 CacheTemporaries in these two bad boys.
26393 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26394 ldobj or ldind_ref.
26395 (StoreFromPtr): Handle stobj as well.
26397 * expression.cs (UnaryMutator): Share more code.
26399 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26400 down: I was not tracking the Filter function as well, which
26401 was affecting the results of the cache.
26403 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26405 * attribute.cs: Remove the hack to handle the CharSet property on
26408 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26410 * attribute.cs (DoResolve): More uglyness, we now only try to
26411 resolve the attribute partially, to extract the CharSet
26412 information (only if we are a StructLayout attribute). Otherwise
26414 (GetExtraTypeInfo): Add some code to conditionally kill in the
26415 future this. I am more and more convinced that the .NET
26416 framework has special code to handle the attribute setting on
26419 * expression.cs (IsParamsMethodApplicable): Revert my previous
26420 foreach change here, it was wrong.
26422 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26424 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26425 (pp_expr): do not abort on unknown input, just return.
26426 (eval): abort if there are pending chars.
26428 * attribute.cs (Attribute.Resolve): Positional parameters are
26429 optional. Deal with that case.
26431 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26432 the Ansi/Unicode/Auto information for the type.
26434 (TypeContainer.DefineType): instantiate the EmitContext here, as
26435 we will be using it during the type definition (to resolve
26436 attributes) and during the emit phase.
26438 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26439 to pull type information out of the attributes
26441 (Attribute.Resolve): track the constructor builder, and allow for
26442 multiple invocations (structs and classes will use this).
26444 * ecore.cs (MemberLookupFinal): new version with all the
26445 parameters customizable.
26447 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26448 constructors. Return if the result value is null (as the error
26449 would have been flagged already by MemberLookupFinal)
26451 Do not allow instances of abstract classes or interfaces to be
26454 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26455 We have to compare the assembly property here when dealing with
26456 FamANDAssem and Assembly access modifiers, because we might be
26457 creating an assembly from *modules* (that means that we are not
26458 getting TypeBuilders for types defined in other modules that are
26459 part of this assembly).
26461 (Method.Emit): If the method is marked abstract and has a body,
26464 (TypeContainer.DefineMembers): If both the defined member and the
26465 parent name match are methods, then do not emit any warnings: let
26466 the Method.Define routine take care of flagging warnings. But if
26467 there is a mismatch (method overrides something else, or method is
26468 overriwritten by something, then emit warning).
26470 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26471 set to null, this means `do not check for the return type on the
26474 (Method.Define): set the return type for the method signature to
26475 null, so that we get methods with the same name and parameters and
26476 different return types. This is used to flag warning 114 (you are
26477 hiding a method, and you probably want to use the new/override
26480 * typemanager.cs (MemberLookup): Implemented proper access
26481 control, closing a long standing set of bug reports. The problem
26482 was that the Framework only has two bits: Public and NonPublic,
26483 and NonPublic includes private and protected methods, but we need
26484 to enforce the FamANDAssem, FamOrAssem and Family.
26486 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26488 * statement.cs (GotoCase): Return true: Ammounts to giving up
26489 knowledge on whether we return or not, and letting the other case
26490 be responsible for it.
26492 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26494 * driver.cs: Do not load directories for each file processed, only
26495 do it if there is a pattern.
26497 * ecore.cs: Report readonly assigns here as well, as we might have
26498 been resolved only by MemberAccess.
26500 (SimpleName.SimpleNameResolve): Also be useful for LValue
26501 resolution. We need this to propagate assign to local readonly variables
26503 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26504 do not want to reuse potential criteria memory.
26506 * class.cs (MyEventBuilder): Set reflected_type;
26508 * ecore.cs (Constantify): Added support for constifying bools.
26510 (RootContext.LookupType): Added a cache for values looked up in
26511 the declaration space.
26513 * typemanager.cs (FindMembers): Now is a front-end to
26514 RealFindMembers, and provides a two-level hashtable-based cache to
26517 15% performance improvement: from 22.5 to 19.2 seconds.
26519 * expression.cs (IsParamsMethodApplicable): use foreach.
26520 (Invocation.DoResolve): ditto.
26521 (New.DoResolve): ditto.
26522 (ArrayCreation.DoResolve): ditto.
26524 * ecore.cs (FindMostEncompassingType): use foreach.
26526 * delegate.cs (NewDelegate.DoResolve): Use foreach
26528 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26529 (RemoveMethods): use foreach.
26531 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26532 nested foreach statements instead of for, and also break out of
26533 the inner loop once a match is found.
26535 (Invocation.OverloadResolve): Use foreach, simplify the code.
26537 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26539 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26540 we actually unwrap the expression to allow for extra information
26543 * expression.cs: Use Shr_Un on unsigned operations.
26545 2002-05-08 Ravi Pratap <ravi@ximian.com>
26547 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26548 applicable operators was not being considered correctly. This closes
26549 the bug Miguel reported.
26551 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26553 * attribute.cs: check that the type derives from System.Attribute
26554 and report the correct error in that case (moved the duplicate code to
26555 its own method, too).
26557 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26559 * attribute.cs: lookup attribute type name as the spec says: first the
26560 bare attribute name and then name + "Attribute" (nant compiles with
26561 mcs after this fix).
26563 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26565 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26566 Because of the way we parse things, we should try to see if a
26567 UIntConstant can fit in an integer.
26569 2002-05-07 Ravi Pratap <ravi@ximian.com>
26571 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26572 when we are in an explicit context.
26574 (ConvertReferenceExplicit): When converting from Iface type S to Class
26575 T make sure the rules are implemented as an OR.
26577 * parameter.cs (ParameterType): Make it a property for now although the
26578 purpose really isn't anything immediate.
26580 * expression.cs (Is*Applicable): Do better checking on the parameter type
26581 of a ref/out parameter. The ones from the system assemblies are already
26582 marked with the correct type so we don't need to do any correction.
26584 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26585 the object type is standard too so include that.
26587 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26589 * ecore.cs (StandardConversionExists): Augment with missing code:
26590 deal with IntConstant, LongConstants and Enumerations.
26592 * assign.cs: Report the error, instead of failing silently
26594 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26595 typecontainer that they are declared, because the
26596 typecontainer/namespace will have the list of using clauses that
26597 need to be applied.
26599 Assembly Attributes were escaping the normal registration
26602 (EmitCode): Apply attributes within an EmitContext that represents
26603 the container they were declared on.
26605 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26607 2002-05-06 Ravi Pratap <ravi@ximian.com>
26609 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26610 Revamp completely - make much cleaner as we now operate only
26613 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26614 to implement the logic detailed in the spec more correctly.
26616 (UserDefinedConversion): Update accordingly.
26618 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26620 * statement.cs: Return flow analysis information up.
26622 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26625 (token): Do not consume an extra character before calling
26628 2002-05-06 Piers Haken <piersh@friskit.com>
26630 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26632 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26634 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26635 EmitContext during the instance constructor initializer
26636 resolution, to stop access to instance variables.
26638 This is mandated by the spec, last paragraph of the `constructor
26639 initializers' section.
26641 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26643 * cs-parser.jay, class.cs (Accessor): new class used to represent
26644 an accessor (get or set). In the past we used `null' to represent
26645 a missing accessor. But this is ambiguous because there was no
26646 way to tell in abstract indexers/properties if one of them was
26649 Now there is a way of addressing that.
26651 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26652 instead of FindMembers.
26654 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26655 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26657 * attribute.cs: Treat indexers and properties as the same in terms
26658 of applying attributes
26660 * ecore.cs (FindMostEncompassedType): Use statically initialized
26661 EmptyExpressions()s like we do elsewhere to avoid creating useless
26662 objects (and we take this out of the tight loop).
26664 (GetConversionOperators): Move the code to extract the actual
26665 operators to a separate routine to clean things up.
26667 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26669 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26670 events are always registered FieldBuilders.
26672 * class.cs (FieldBase): New class shared by Fields
26674 * delegate.cs: If we are a toplevel delegate, use our full name.
26675 If we are a nested delegate, then only use our tail name.
26677 2002-05-02 Ravi Pratap <ravi@ximian.com>
26679 * expression.cs (IsApplicable): Ensure that we add the "&" to
26680 ref/out types before comparing it with the type of the argument.
26682 (IsParamsMethodApplicable): Ditto.
26684 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26687 * delegate.cs : Handle the case when we have more than one applicable
26688 method. Flag an error only when we finish checking all.
26690 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26692 * expression.cs: Add support for boolean static initializers.
26694 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26696 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26698 * parameter.cs (ComputeParameterTypes,
26699 ComputeAndDefineParameterTypes): Better error handling: now we
26700 clear the `types' cache if we fail during any of the type lookups.
26701 We also return the status code correctly to our caller
26703 * delegate.cs: If we fail to define a delegate, abort the extra
26706 * expression.cs (Binary.ResolveOperator): for
26707 operator==(object,object) and operator !=(object, object) we also
26708 have to verify that there is an implicit conversion from one to
26711 (ArrayAccess.DoResolve): Array Access can operate on
26714 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26716 * assign.cs (CompoundAssign): A new class used as a "flag" that
26717 the assignment actually is happening as part of a compound
26718 assignment operator.
26720 During compound assignment, a few new rules exist to enable things
26727 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26728 to the type of x) if y is implicitly convertible to the type of x,
26729 and the operator is a builtin operator and the return type of the
26730 operator is explicitly convertible to the type of x.
26732 * rootcontext.cs: Reset warning level to 2. 4 catches various
26733 "interesting" features in mcs, we must clean this up at some
26734 point, but currently am trying to kill other bugs ;-)
26736 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26737 in container classes as well.
26739 * expression.cs (Binary.ResolveOperator): Handle string case
26740 before anything else (as operator overloading does emit an error
26741 before doing anything else).
26743 This code could go away when we move to a table driven model, but
26744 i could not come up with a good plan last night.
26746 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26748 * typemanager.cs (CSharpName): reimplementation using regex.
26749 * class.cs: added null check for fields in Emit
26750 * rootcontext.cs: set warninglevel to 4
26752 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26754 * typemanager.cs (CSharpName): reimplemented with Lupus
26757 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26759 * statement.cs (If): correclty implement Resolve, because we were
26760 not catching sem errors in there. The same process is needed
26762 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26765 (Statement.Warning_DeadCodeFound): Factorize code.
26766 (While): Report dead code here too.
26768 (Statement): Added Resolve virtual method to allow
26769 for resolution split from the emit code.
26771 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26773 * statement.cs (EmitBoolExpression): No longer try to resolve the
26775 (MakeBoolean): New utility function that resolve, implicitly
26776 converts to boolean and tags the expression.
26779 (If, Do): Implement dead code elimination.
26780 (While): Implement loop inversion
26782 (Do, While, For, If): Resolve the expression prior to calling our
26785 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26788 - added method Report28 (warning: program has more than one entry point)
26789 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26790 - modified method Method.Define, the part at the end of the method
26792 * rootcontext.cs: added static public Location EntryPointLocation;
26794 * ../errors/cs0028.cs : Add test case for the above warning.
26797 - modified method CSharpName to allow arrays of primitive type to
26798 be printed nicely (e.g. instead of System.Int32[][] it now prints
26800 - added method CSharpSignature: returns the signature of a method
26801 in string format to be used in reporting errors, warnings, etc.
26803 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26806 2002-04-26 Ravi Pratap <ravi@ximian.com>
26808 * delegate.cs (Define): Fix extremely silly bug where I was
26809 setting the type of the 'object' parameter of the BeginInvoke
26810 method to System.IAsyncResult instead of System.Object ;-)
26812 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26814 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26817 (Constructor.Emit): return if we fail to initialize the
26818 constructor. Another door closed!
26820 * expression.cs (New.DoResolve): Improve error message (from -6 to
26821 1501). Use DeclaredOnly lookup to find the exact constructor.
26823 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26824 loop. This is useful.
26826 * cs-parser.jay: Adjust the default parameters so that destructors
26827 have the proper signature.
26829 2002-04-26 Martin Baulig <martin@gnome.org>
26831 * driver.cs (LoadAssembly): If `assembly' contains any characters
26832 which are only valid in path names and not in assembly names
26833 (currently slash, backslash and point), use Assembly.LoadFrom ()
26834 instead of Assembly.Load () on the `assembly' (before iteration
26835 over the link_paths).
26837 2002-04-26 Martin Baulig <martin@gnome.org>
26839 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26841 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26843 * class.cs (Property): use the new typemanager.MemberLookup
26845 (TypeContainer.MemberLookup): Implement using the
26846 TypeManager.MemberLookup now.
26848 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26849 and return MemberInfos, so that these can be used without an
26850 EmitContext (what we had before).
26852 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26854 * expression.cs: Fix the case where the argument to params if the
26855 type of the params. I omitted handling this before. Fixed
26857 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26859 * driver.cs: Call BootCorlib_PopulateCoreType
26861 * class.cs (Property.CheckBase): Check for properties only, not
26864 * interface.cs: Temporary hack: try/catch around the
26865 CustomAttributeBuilder, because I am getting an exception that I
26868 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26869 types whose definitions are required to be there (attributes are
26870 defined before standard types).
26872 Compute definitions as we boot the various types, as they are used
26873 immediately (value_type class will need object_type, but if we do
26874 not initialize object_type, we will pass a null, which will let
26875 the runtime pick the System.Object from the existing corlib, which
26876 is not what we want).
26878 2002-04-22 Patrik Torstensson <totte@labs2.com>
26880 * cs-tokenizer.cs: fixed a number of trim() issues.
26882 2002-04-22 Ravi Pratap <ravi@ximian.com>
26884 * expression.cs (Argument.Type): Ensure that we return the correct
26885 type when we have out or ref parameters [in which case we
26888 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26890 * class.cs (Property, Indexer): Allow extern modifier in there.
26892 * typemanager.cs (InitBaseTypes): Initializes object_type and
26893 value_type, since those will be used early on during the bootstrap
26894 process to compile corlib.
26896 (InitCoreTypes): Move code from here to InitBaseTypes.
26898 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26900 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26901 single-dimension arrays as using the ldlen opcode.
26903 Daniel Lewis discovered this optimization.
26905 * typemanager.cs: Add signature for System.Array::get_Length
26907 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26909 * statement.cs: report the error when the foreach does not apply to an
26910 array nor a collection.
26912 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26914 * expression.cs: Add implicit conversions to the operator ~.
26916 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26918 * typemanager.cs: Locate the decimal constructor.
26920 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26922 * attribute.cs: use the new property of TypeOf.
26923 * expression.cs: added 'get' property around typearg.
26925 These changes fix a build breaker reported by NickD. Is this the
26926 correct way to fix? If not, please, revert my changes and make it
26929 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26931 * attribute.cs: Add support for typeof in attribute invocations.
26932 I am not sure that this is right though.
26934 2002-04-14 Duncan Mak <duncan@ximian.com>
26936 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26937 Binary.Operator.Division case.
26939 2002-04-13 Ravi Pratap <ravi@ximian.com>
26941 * class.cs (DefineType): Ensure that we do a proper check on
26942 attribute types and also register it with the TypeManager.
26944 (TypeContainer.Targets): The default for attribute types is
26945 AttributeTargets.All.
26947 * attribute.cs (ApplyAttributes): Registering the attribute type
26948 is done elsewhere, not when we discover we have a Usage attribute.
26950 2002-04-12 Ravi Pratap <ravi@ximian.com>
26952 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26953 and get rid of is_delegate parameter.
26955 * everywhere : update.
26957 2002-04-12 Ravi Pratap <ravi@ximian.com>
26959 * cs-parser.jay (compilation_unit): Revamp completely to use
26960 some new ideas that I got from Rhys' grammar to solve the problems
26961 with assembly level attributes.
26963 (outer_declaration): New grammar production.
26965 (attribute_sections): Add.
26967 (opt_attributes): Base on attribute_sections
26969 (namespace_declaration): Allow opt_attributes to tackle the case
26970 when we have assembly level attributes - we are clever in this
26973 * attribute.cs (ApplyAttributes): Do not worry about assembly
26974 attributes in the non-global context.
26976 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26977 instead of SetGlobalAttributes.
26979 * class.cs, rootcontext.cs : Ensure we define and generate
26980 attribute types before anything else.
26982 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26983 and flag the new error -20 for the case when the attribute type
26984 does not have valid targets specified. csc does not catch this.
26986 * ../errors/errors.txt : update for error # -20
26988 2002-04-11 Ravi Pratap <ravi@ximian.com>
26990 * support.cs (InternalParameters.ParameterModifier): Do some null
26991 checking and return sane values.
26993 * class.cs (Method.Define): If we are a PInvoke method, ensure
26994 that we are static and extern. Report error # 601
26996 * ../errors/cs0601.cs : Add test case for the above error.
26998 2002-04-07 Ravi Pratap <ravi@ximian.com>
27000 * rootcontext.cs (attribute_types): We need to keep type of
27001 all attribute types separately and emit code for them first.
27003 (RegisterAttribute) : Implement.
27005 * class.cs (DefineType): Check if the current Type is a custom
27006 attribute type and register it accordingly.
27008 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27009 adding the first attribute twice and rename to
27011 (SetGlobalAttributes): this.
27013 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27016 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27017 if we are processing global arguments. Hmm, I am unsure of this.
27019 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27021 * expression.cs: added static array of strings to avoid calling
27022 Enum.ToString () for Operator in Binary. Significant recover of
27025 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27027 * class.cs (FindMembers): Allow the Builders of the various
27028 members to be null. If they are skip them. This only happens
27029 during the PInvoke declaration.
27031 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27033 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27034 failure, so we do not keep going afterwards.
27036 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27037 wanted to pass `false' as the `is_delegate' argument. If this is
27038 the case, why not use delegate_type == null to mean `is_delegate =
27039 false' and anything else as is_delegate = true.
27041 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27043 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27044 code for the section, not the beginning of the tests.
27046 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27048 * cfold.cs: Handle operator + (Enum x, Underlying x)
27050 * expression.cs (Binary): same. Warn about errors where we have
27051 Enum/Enum in operator + as well.
27053 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27056 - added support for switch(bool)
27057 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27058 - add TableSwitchEmit() to handle table-based switch statements
27060 2002-04-05 Ravi Pratap <ravi@ximian.com>
27062 * expression.cs (Invocation.OverloadResolve): Factor out code which
27063 does parameter compatibility checking with arguments so that we can
27064 re-use the code even from Delegate.VerifyApplicability
27066 (VerifyArgumentsCompat): Move above code here.
27068 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27069 and instead make a call to the above method.
27071 2002-03-31 Ravi Pratap <ravi@ximian.com>
27073 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27074 We use it to keep track of classes which are attribute types.
27076 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27078 * delegate.cs (Delegate.Define): Correctly define the types in the
27079 presence of fixed and array parameters.
27081 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27084 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27085 include NonPublic after the first iteration.
27087 * class.cs (Indexer.CheckBase): Only check if both parents are
27090 * cs-parser.jay (accessor_body): If empty, set to null.
27092 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27093 same code path here to resolve constants names that we did have in
27094 MemberAccess.DoResolve. There is too much code duplicated here.
27096 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27098 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27100 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27103 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27104 tokens, numbers and strings.
27106 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27109 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27110 asyncronous parameters and the regular parameters.
27112 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27113 specify the target directory.
27115 * expression.cs: (This.DoResolve): Simplify
27116 (As.Emit): Optimize, do not generate IsInst if the expression is
27117 always of the given type.
27119 (Is.DoResolve): Bug fix, we were reporting both always/never for
27122 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27123 creating too many unnecessary arrays.
27125 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27127 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27128 fields instead of rolling our own initializer. Takes care of all
27129 implicit conversions, and drops unnecessary static checks/argument.
27131 2002-03-31 Dick Porter <dick@ximian.com>
27133 * driver.cs: use the GetDirectories() return values properly, and
27134 use "/" as path separator.
27136 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27138 * expression.cs (Unary): Optimize - - expr into expr.
27139 (Binary): Optimize a + (-b) into a -b.
27141 * codegen.cs (CodeGen): Made all methods static.
27143 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27147 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27148 TypeBuilder property.
27150 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27153 * tree.cs: Removed the various RecordXXXX, and replaced with a
27154 single RecordDecl. Removed all the accessor methods, and just
27155 left a single access point Type
27157 * enum.cs: Rename DefineEnum to DefineType.
27159 * decl.cs: New abstract method `DefineType' used to unify the
27160 Defines for Enumerations, Interfaces, TypeContainers and
27163 (FindType): Moved LookupInterfaceOrClass here. Moved the
27164 LookupBaseClasses method that used to live in class.cs and
27165 interface.cs here, and renamed to FindType.
27167 * delegate.cs: Implement DefineType. Take advantage of the
27168 refactored pattern for locating the parent builder without taking
27169 the parent_builder argument (which we know does not work if we are
27170 nested, and triggering a toplevel definition).
27172 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27174 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27175 accessibility of a member has changed during override and report
27178 * class.cs (Method.Define, Property.Define): Only complain on
27179 overrides if the method is private, any other accessibility is
27180 fine (and since we just checked the permission is the same, we are
27183 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27184 and elif are processed always. The other pre-processing
27185 directives are only processed if we are "taking" the path
27187 2002-03-29 Martin Baulig <martin@gnome.org>
27189 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27190 current location is not Null.
27192 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27193 a separate method so we can profile it.
27195 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27196 `span.Seconds' are just seconds, but no minutes or hours.
27197 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27199 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27201 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27202 Remove the gratuitous set of Final:
27204 // If an interface implementation, then we can set Final.
27205 if (((flags & MethodAttributes.Abstract) == 0) &&
27206 implementing.DeclaringType.IsInterface)
27207 flags |= MethodAttributes.Final;
27209 I do not know what I was smoking when I used that.
27212 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27213 step into fixing the name resolution issues for delegates and
27214 unifying the toplevel name resolution.
27216 2002-03-28 Martin Baulig <martin@gnome.org>
27218 * class.cs (Method.Emit): If we have a symbol writer, call its
27219 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27220 tell it about the current method.
27222 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27223 writer that we're going to emit the first byte of IL code for a new
27224 statement (a new source line).
27225 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27226 EmitContext.Mark() before emitting any code.
27228 * location.cs (SymbolDocument): Return null when we're Null.
27230 * statement.cs (Statement): Moved the `Location loc' variable here.
27231 (Statement.EmitBoolExpression): If we have a symbol writer, call
27232 ec.Mark() before emitting any code to tell it that we're at the
27233 beginning of a new statement.
27234 (StatementExpression): Added `Location' argument to the constructor.
27235 (Block): Added public readonly variable `StartLocation' and public
27236 variable `EndLocation'. The latter is to be set using SetEndLocation().
27237 (Block): Added constructor which takes a start and end location.
27238 (Block.SetEndLocation): New method. This sets the end location.
27239 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27240 local variables we create.
27241 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27242 each statement and do also mark the begin and end of the block.
27244 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27245 tell it the current lexer.Location, use Location.Null for the end of the
27247 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27248 current block, set its end location using SetEndLocation().
27249 (statement_expression): StatementExpression constructor now takes the
27250 lexer.Location as additional argument.
27251 (for_statement, declare_local_variables): Likewise.
27252 (declare_local_variables): When creating a new implicit block, use the
27253 new Block constructor and pass it the lexer.Location.
27255 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27257 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27258 members also on the parent interfaces recursively.
27260 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27262 * report.cs: Use new formats, since Gonzalo finished the missing
27265 * expression.cs (Binary.ResolveOperator): added missing operator|
27266 operator& and operator^ for bool/bool.
27268 * cs-parser.jay: CheckDef now takes a Location argument that is
27269 used to report errors more precisly (instead of reporting the end
27270 of a definition, we try to track something which is a lot closer
27271 to the source of the problem).
27273 * cs-tokenizer.cs: Track global token use, so we can properly flag
27274 the use of #define/#undef after the first token has been seen.
27276 Also, rename the reportXXXX to Error_DescriptiveName
27278 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27279 TypeContainer, so that Enum and Interface can use this too.
27281 * class.cs (TypeContainer.LookupInterfaceOrClass,
27282 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27283 `builder' argument. Typically this was used to pass the parent
27284 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27287 The problem is that a nested class could trigger the definition of
27288 a toplevel class, and the builder would be obviously wrong in that
27291 So we drop this argument, and we compute dynamically the
27292 TypeBuilder/ModuleBuilder (the correct information was available
27293 to us anyways from DeclSpace.Parent)
27295 * interface.cs (Interface.DefineInterface): Drop builder
27296 parameter cleanup like class.cs
27298 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27301 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27304 (Try.Emit): Propagate the returns value from the statement.
27306 (Return.Emit): Even if we are leavning
27308 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27310 * modifiers.cs: Fix the computation of MethodAttributes flags.
27312 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27314 * driver.cs: allow compilation of files that start with '/'.
27315 Add a default case when checking the argument of --target.
27317 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27319 * interface.cs: Implement the same search algorithm for types in
27320 the interface code.
27322 * delegate.cs: Do not allow multiple definition.
27324 * Recovered ChangeLog that got accidentally amputated
27326 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27328 * rootcontext.cs: Load manually enum to allow core classes to
27329 contain enumerations.
27331 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27332 Update to new static methods in TypeManager.
27334 * typemanager.cs (GetMethod, GetConstructor): Use our
27335 implementation of FindMembers to find the members, since during
27336 corlib compilation, the types are TypeBuilders and GetMethod and
27337 GetConstructor do not work.
27339 Make all methods in TypeManager static.
27341 (InitCodeHelpers): Split the functionality from
27342 the InitCodeTypes function.
27344 * driver.cs: Call InitCodeHelpers after we have populated the
27347 * cs-parser.jay (delegate_declaration): we did not used to compute
27348 the delegate name correctly for void delegates.
27350 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27352 * rootcontext.cs (RootContext): Init the interface_resolve_order
27353 and type_container_resolve_order always.
27355 (ResolveCore, BootstrapCorlib_ResolveClass,
27356 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27357 compiler when compiling with --nostdlib
27359 * class.cs (TypeContainer.DefineType): Check that our parent is
27360 not null. This test is most important when we are bootstraping
27363 * codegen.cs: Split out the symbol writing code.
27365 2002-03-25 Martin Baulig <martin@gnome.org>
27367 * driver.cs (-g): Made -g an alias for --debug.
27369 2002-03-24 Martin Baulig <martin@gnome.org>
27371 * codegen.cs (SymbolWriter): New public variable. Returns the
27372 current symbol writer.
27373 (CodeGen): Added `bool want_debugging_support' argument to the
27374 constructor. If true, tell the ModuleBuild that we want debugging
27375 support and ask it for the ISymbolWriter.
27376 (Save): If we have a symbol writer, call it's Close() method after
27377 saving the assembly.
27379 * driver.c (--debug): New command line argument to create a
27380 debugger information file.
27382 * location.cs (SymbolDocument): New public property. Returns an
27383 ISymbolDocumentWriter object for the current source file or null
27384 if we don't have a symbol writer.
27386 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27388 * driver.cs (LoadAssembly): Correctly return when all the paths
27389 have been tried and not before.
27391 * statement.cs (Switch.Emit): return the actual coverage for this
27392 statement (returns/not-returns)
27394 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27395 switch of the statement if we are the last switch section. That
27396 kills two problems: try/catch problems (we used to emit an empty
27397 nop at the end) and switch statements where all branches would
27400 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27402 * driver.cs: Add default assemblies (the equivalent to the
27403 Microsoft CSC.RSP file)
27405 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27406 also update tokens_seen and set it to false.
27408 * driver.cs: Implement --recurse for Mike.
27410 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27411 correctly splitting out the paths.
27413 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27415 * interface.cs (Interface.PopulateProperty): Instead of using
27416 `parent' as the declaration space for the set parameters, use
27419 * support.cs (InternalParameters): InternalParameters constructor
27420 takes a DeclSpace instead of a TypeContainer.
27422 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27423 types are being initialized, load the address of it before calling
27426 (New): Provide a mechanism to disable the generation of local
27427 value type temporaries when the caller will be providing us with
27428 an address to store it.
27430 (ArrayCreation.EmitDynamicInitializers): Use it.
27432 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27434 * expression.cs (Invocation.EmitArguments): Only probe for array
27435 property if there is more than one argument. Sorry about that.
27437 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27438 empty param arrays.
27440 * class.cs (Method.LabelParameters): Fix incorrect code path that
27441 prevented the `ParamArrayAttribute' from being applied to the
27444 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27446 * support.cs (ReflectionParameters): Correctly compute whether the
27447 last argument is a params array. Fixes the problem with
27450 * typemanager.cs: Make the assemblies array always be non-null
27451 (empty, but non-null)
27453 * tree.cs (RecordDecl): New function that abstracts the recording
27454 of names. This reports error 101, and provides a pointer to the
27455 previous declaration. Fixes a crash in the compiler.
27457 * cs-parser.jay (constructor_declaration): Update to new grammar,
27458 and provide a constructor_body that can be empty.
27460 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27462 * driver.cs: Add support for --resources.
27464 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27465 Make all types for the various array helper methods be integer.
27467 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27468 CheckState to ConvCast.
27470 (ConvCast): Now it takes a `checked' state argument, to avoid
27471 depending on the emit context for the conversion, and just using
27472 the resolve time setting.
27474 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27475 instead of Invocation.EmitArguments. We do not emit the original
27476 arguments, instead we emit those which have been converted to
27477 unsigned int expressions.
27479 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27481 * codegen.cs: ditto.
27483 * expression.cs (LocalVariableReference): Drop the use of the
27484 Store function that depended on the variable index.
27486 * statement.cs (VariableInfo): Drop the `Idx' property from this
27487 class, as this is not taking into account the indexes for
27488 temporaries tat we generate during the execution, getting the
27491 * class.cs: First emit class initializers, then call the parent
27494 * expression.cs (Binary): Fix opcode emision.
27495 (UnaryMutator.EmitCode): Support checked code generation
27497 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27498 matches for events for both the Static and Instance scans,
27499 pointing to the same element. Fix that.
27501 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27503 * rootcontext.cs (ResolveTree): Always set the
27504 interface_resolve_order, because nested interfaces will be calling
27507 * class.cs (GetInterfaceOrClass): Track the same resolution
27508 process used by TypeManager.LookupType. This fixes the nested
27509 type lookups in class declarations (separate path from
27512 (TypeContainer.DefineType): Also define nested interfaces.
27513 (TypeContainer.RegisterOrder): New public function used to
27514 register the order in which child interfaces need to be closed.
27516 Nested interfaces need to be closed after their parents have been
27519 * interface.cs (InterfaceAttr): Put all the logic for computing
27520 the interface attribute here.
27522 (DefineInterface): Register our interface order with the
27523 RootContext or with the TypeContainer depending on the case.
27525 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27527 * cs-parser.jay: rework foreach statement to work with the new
27528 changes to the policy on SimpleNames.
27530 * report.cs: support Stacktrace on warnings as well.
27532 * makefile: drop --unsafe and /unsafe from the compile.
27534 2002-03-13 Ravi Pratap <ravi@ximian.com>
27536 * ecore.cs (StandardConversionExists): Modify to take an Expression
27537 as the first parameter. Ensure we do null -> reference type conversion
27540 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27541 temporary Expression objects.
27543 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27545 * interface.cs: workaround bug in method overloading resolution
27546 (there is already a bugzilla bug for it).
27548 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27550 We could also solve this problem by having a separate path for
27551 performing type lookups, instead of DoResolve, we could have a
27552 ResolveType entry point, and only participating pieces of the
27553 production (simplename, deref, array) would implement this.
27555 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27556 signal SimpleName to only resolve type names and not attempt to
27557 resolve anything else.
27559 * expression.cs (Cast): Set the flag.
27561 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27563 * class.cs: Only report 108 if there is no `new' modifier.
27565 * cs-parser.jay: rework foreach statement to work with the new
27566 changes to the policy on SimpleNames.
27568 * report.cs: support Stacktrace on warnings as well.
27570 * makefile: drop --unsafe and /unsafe from the compile.
27572 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27574 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27575 lookups here, instead of doing that at parse time. This means
27576 that our grammar will not introduce `LocalVariableReferences' as
27577 expressions at this point. That solves the problem of code like
27581 static void Main ()
27585 This is only half the fix. The full fix requires parameters to
27586 also be handled in this way.
27588 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27589 makes the use more obvious of the DeclSpace. The
27590 ec.TypeContainer.TypeBuilder is now only used to pull the
27591 TypeBuilder for it.
27593 My theory is that I can get rid of the TypeBuilder completely from
27594 the EmitContext, and have typecasts where it is used (from
27595 DeclSpace to where it matters).
27597 The only pending problem is that the code that implements Aliases
27598 is on TypeContainer, and probably should go in DeclSpace.
27600 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27601 lookups here, instead of doing that at parse time. This means
27602 that our grammar will not introduce `LocalVariableReferences' as
27603 expressions at this point. That solves the problem of code like
27607 static void Main ()
27611 This is only half the fix. The full fix requires parameters to
27612 also be handled in this way.
27614 * class.cs (Property.DefineMethod): When implementing an interface
27615 method, set newslot, when implementing an abstract method, do not
27616 set the flag (before we tried never setting it, or always setting
27617 it, which is the difference).
27618 (Indexer.DefineMethod): same.
27619 (Method.DefineMethod): same.
27621 * ecore.cs: Only set the status used flag if we get back a Field.
27623 * attribute.cs: Temporary hack, so Paolo can keep working.
27625 2002-03-08 Ravi Pratap <ravi@ximian.com>
27627 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27628 the unmanaged type in the case we have a MarshalAs attribute.
27630 (Resolve): Handle the case when we are parsing the special MarshalAs
27631 attribute [we need to store the unmanaged type to use later]
27633 * typemanager.cs (marshal_as_attr_type): Built in type for the
27634 MarshalAs Attribute.
27636 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27637 on parameters and accordingly set the marshalling info.
27639 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27641 * class.cs: Optimizing slightly by removing redundant code after
27642 we switched to the `NoTypes' return value.
27643 (Property.DefineMethod): use NoTypes here too.
27645 This fixes the bug I introduced in my last batch of changes.
27647 2002-03-05 Ravi Pratap <ravi@ximian.com>
27649 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27651 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27652 Enums since those are types too.
27654 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27656 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27657 thanks to a call during the lookup process.
27659 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27661 * statement.cs (Foreach): Lots of work to accomodate a particular
27662 kind of foreach statement that I had not kept in mind. It is
27663 possible to have foreachs on classes that provide a GetEnumerator
27664 method that return objects that implement the "pattern" for using
27665 a foreach, there is no need to support GetEnumerator
27668 This is needed to compile nant.
27670 * decl.cs: Only report 114 if the member is not `Finalize' and if
27671 the warning level is at least 2.
27673 * class.cs: Moved the compare function from Method to
27676 (MethodSignature.InheritableMemberSignatureCompare): Add new
27677 filter function that is used to extract inheritable methods from a
27680 (Method.Define): Use the new `inheritable_method_signature_filter'
27683 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27686 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27688 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27690 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27692 * expression.cs: Pass location information to
27693 ConvertImplicitStandard.
27695 * class.cs: Added debugging code to track return values from
27698 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27700 * expression.cs (Is.DoResolve): If either side of the `is' is an
27701 interface, do not flag the warning.
27703 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27706 * report.cs: Allow for --fatal to be used with --probe.
27708 * typemanager.cs (NoTypes): Move the definition for the empty Type
27711 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27713 (TypeContainer.DefineProxy): New function used to proxy to parent
27714 implementations when implementing interfaces.
27715 (TypeContainer.ParentImplements): used to lookup if our parent
27716 implements a public function that is required by an interface.
27717 (TypeContainer.VerifyPendingMethods): Hook this up.
27719 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27720 `modules' and `assemblies' arraylists into arrays. We only grow
27721 these are the very early start up of the program, so this improves
27722 the speedof LookupType (nicely measured).
27724 * expression.cs (MakeByteBlob): Replaced unsafe code with
27725 BitConverter, as suggested by Paolo.
27727 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27728 folding of string concatenation, but if either side is a string,
27729 and the other is not, then return null, and let the runtime use
27730 the concatenation on the string plus the object (using
27731 `Object.ToString').
27733 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27735 Constant Folding has been implemented now.
27737 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27738 the error instead on types that are not supported in one's
27741 * constant.cs (Constant and all children): New set of functions to
27742 perform implict and explicit conversions.
27744 * ecore.cs (EnumConstant): Implement the new functions to perform
27745 conversion by proxying to the child expression.
27747 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27748 own separate setting that can not be turned off from the command
27749 line using --unchecked or --checked and is only controlled using
27750 the checked/unchecked statements and expressions. This setting is
27751 used by the constant folder to flag errors.
27753 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27754 ConstantCheckState as well.
27756 During Resolve, they also have to flag the state, because the
27757 constant folder runs completely in the Resolve phase.
27759 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27762 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27764 * cfold.cs: New file, this file contains the constant folder.
27766 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27767 argument to track whether we are using the resulting address to
27768 load or store a value and provide better error messages.
27770 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27771 new AddressOf arguments.
27773 * statement.cs (Foreach.EmitCollectionForeach): Update
27775 * expression.cs (Argument.Emit): Call AddressOf with proper
27776 arguments to track usage.
27778 (New.DoEmit): Call AddressOf with new arguments.
27780 (Unary.Emit): Adjust AddressOf call.
27782 2002-03-01 Ravi Pratap <ravi@ximian.com>
27784 * cs-parser.jay (member_access): Change the case for pre-defined types
27785 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27788 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27791 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27792 essentially like methods and apply attributes like MethodImplOptions to them too.
27794 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27797 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27798 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27801 * Update code everywhere accordingly.
27803 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27805 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27807 2002-02-28 Ravi Pratap <ravi@ximian.com>
27809 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27810 try performing lookups against those instead of jumping straight into using
27811 the 'using' clauses.
27813 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27815 (LookupType): Perform lookups in implicit parents too.
27817 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27818 sequence as RootContext.LookupType.
27820 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27821 the various cases of namespace lookups into this method.
27823 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27825 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27826 in positional arguments)
27828 * class.cs (Operator): Update the AllowedModifiers to contain
27831 * cs-parser.jay: Update operator declaration to allow for the
27832 operator body to be empty.
27834 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27837 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27839 * class.cs (Method.Emit): Label parameters.
27841 * driver.cs: Return 1 or 0 as the program exit code.
27843 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27845 * expression.cs: Special case the `null' object when trying to
27846 auto-compute the type, as anything can be explicitly converted to
27849 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27850 spotting this Paolo.
27852 (Expression.ImplicitNumericConversion): Perform comparissions of
27853 the type using the underlying type in the case of an enumeration
27854 rather than using the enumeration type for the compare.
27856 Cope with the underlying == type case, which is not possible to
27859 (Expression.ConvertNumericExplicit): Perform comparissions of
27860 the type using the underlying type in the case of an enumeration
27861 rather than using the enumeration type for the compare.
27863 * driver.cs: If the user does not supply an extension, assume .exe
27865 * cs-parser.jay (if_statement): Rewrote so that we can track the
27866 location for the if statement.
27868 * expression.cs (Binary.ConstantFold): Only concat strings when
27869 the operation is "+", not everything ;-)
27871 * statement.cs (Statement.EmitBoolExpression): Take a location
27873 (If, While, Do): Track location.
27875 * expression.cs (Binary.ResolveOperator): In the object + string
27876 case, I was missing a call to ConvertImplicit
27878 2002-02-25 Ravi Pratap <ravi@ximian.com>
27880 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27881 Location arguments. Ensure we use RootContext.LookupType to do our work
27882 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27884 * interface.cs (PopulateMethod): Handle the type of the parameter being
27887 * expression.cs (Invocation.BetterFunction): Handle the case when we
27888 have a params method with no fixed arguments and a call is made with no
27891 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27893 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27894 the verbatim-string-literal
27896 * support.cs (InternalParameters.ParameterModifier): handle null
27898 (InternalParameters.ParameterType): ditto.
27900 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27901 duplicating the name of the variable parameter.
27902 (GetParameterByName): Fix bug where we were not looking up array
27903 paramters if they were the only present (thanks Paolo!).
27904 (GetParameterInfo): We only have an empty set of types if both
27905 fixed and array are set to null.
27906 (GetParameterInfo-idx): Handle FixedParameter == null
27908 * cs-parser.jay: Handle the case where there is no catch
27909 statements (missing null test).
27911 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27913 * driver.cs (MainDriver): Be conservative on our command line
27916 Catch DirectoryNotFoundException when calling GetFiles.
27918 (SplitPathAndPattern): Used to split the input specification into
27919 a path and a pattern that we can feed to Directory.GetFiles.
27921 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27923 * statement.cs (Fixed): Implement the last case of the Fixed
27924 statement (string handling).
27926 * expression.cs (StringPtr): New class used to return a char * to
27927 a string; Used by the Fixed statement.
27929 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27931 * expression.cs (Binary.ResolveOperator): Remove redundant
27932 MemberLookup pn parent type.
27933 Optimize union call, we do not need a union if the types are the same.
27934 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27937 Specialize the use of MemberLookup everywhere, instead of using
27938 the default settings.
27940 (StackAlloc): Implement stackalloc keyword.
27942 * cs-parser.jay: Add rule to parse stackalloc.
27944 * driver.cs: Handle /h, /help, /?
27946 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27947 before we supported unsafe code.
27949 * makefile: add --unsafe to the self compilation of mcs.
27951 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27953 * expression.cs (PointerArithmetic): New class that is used to
27954 perform pointer arithmetic.
27955 (Binary.Resolve): Handle pointer arithmetic
27956 Handle pointer comparission.
27957 (ArrayPtr): Utility expression class that is used to take the
27958 address of an array.
27960 (ElementAccess): Implement array access for pointers
27962 * statement.cs (Fixed): Implement fixed statement for arrays, we
27963 are missing one more case before we are done.
27965 * expression.cs (Indirection): Implement EmitAssign and set the
27966 ExprClass to Variable. This allows pointer dereferences to be
27967 treated as variables, and to have values assigned to them.
27969 * ecore.cs (Expression.StoreFromPtr): New utility function to
27970 store values dereferencing.
27972 2002-02-20 Ravi Pratap <ravi@ximian.com>
27974 * expression.cs (Binary.ResolveOperator): Ensure that we are
27975 not trying to operate on a void type - this fixes the reported
27978 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27979 the parent implementation is sealed.
27981 * ../errors/cs0239.cs : Add.
27983 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27985 * typemanager.cs (unverifiable_code_type): Corresponds to
27986 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27987 which have unsafe code in them.
27989 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27992 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27994 * cs-tokenizer.cs: Add support for @"litreal strings"
27996 Make tokenizer accept pre-processor directives
27997 on any column (remove the old C-like limitation).
27999 * rootcontext.cs (EmitCode): Emit any global attributes.
28000 (AddGlobalAttributes): Used to keep track of assembly attributes.
28002 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28004 * cs-parser.jay: Add support for global attributes.
28006 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28008 * expression.cs (Indirection): New helper class. Unary will
28009 create Indirection classes to be able to implement the
28010 IMemoryLocation interface on it.
28012 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28014 * cs-parser.jay (fixed_statement): reference the right statement.
28016 * statement.cs (Fixed.Emit): Finish implementing the fixed
28017 statement for the &x case.
28019 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28021 * class.cs (Property.Define, Method.Define): Remove newslot when
28024 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28025 wrong. NewSlot should only be used if the `new' keyword is present.
28027 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28028 locating our system dir. Sorry about this.
28030 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28032 * driver.cs (GetSystemDir): Compute correctly the location of our
28033 system assemblies. I was using the compiler directory instead of
28034 the library directory.
28036 2002-02-13 Ravi Pratap <ravi@ximian.com>
28038 * expression.cs (BetterFunction): Put back in what Miguel commented out
28039 since it is the correct fix. The problem is elsewhere ;-)
28041 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28042 parameters of the parms method are themselves compatible or not !
28044 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28045 to check that a class implements an interface before saying that an implicit
28046 conversion was allowed. Use ImplementsInterface to do the checking.
28048 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28050 * class.cs (Method.Define): Track whether we are an explicit
28051 implementation or not. And only call DefineMethodOverride if we
28052 are an explicit implementation.
28054 (Property.DefineMethod): Ditto.
28056 2002-02-11 Ravi Pratap <ravi@ximian.com>
28058 * expression.cs (BetterFunction): Catch hideous bug which was
28059 preventing us from detecting ambiguous calls due to implicit casts i.e
28062 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28064 * support.cs (Pair): Remove un-needed method. I figured why I was
28065 getting the error in cs-parser.jay, the variable in a foreach loop
28066 is readonly, and the compiler does not really treat this as a variable.
28068 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28069 instead of EQUALS in grammar.
28071 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28073 * expression.cs (Unary.DoResolve): Check whether the argument is
28076 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28078 * support.cs: Api for Pair to set a value. Despite the fact that
28079 the variables are public the MS C# compiler refuses to compile
28080 code that accesses the field if the variable is part of a foreach
28083 * statement.cs (Fixed): Begin implementation of the fixed
28086 (Block.AddVariable): Return the VariableInfo on success and null
28087 on failure instead of true/false.
28089 * cs-parser.jay (foreach): Catch errors on variables already
28090 defined (we were ignoring this value before) and properly unwind
28091 the block hierarchy
28093 (fixed_statement): grammar for the fixed statement.
28095 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28097 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28098 pointer types to be incretemented.
28100 (SizeOf): Implement.
28102 * cs-parser.jay (pointer_member_access): Implement
28103 expr->IDENTIFIER production.
28105 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28106 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28109 (Unary): Implement indirection.
28111 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28112 use in non-unsafe context).
28114 (SimpleName.DoResolve): Check for pointers in field access on safe
28117 (Expression.LoadFromPtr): Factor the load-indirect code in this
28118 function. This was duplicated in UnboxCast and ParameterReference
28120 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28122 * expression.cs (ComposedCast): report an error if a pointer cast
28123 is used in a safe region.
28125 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28126 pointer type casts in unsafe context.
28128 * codegen.cs (EmitContext): Set up IsUnsafe.
28130 * cs-parser.jay (non_expression_type): Add productions for pointer
28133 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28134 code. We should not use force into static mode if the method is
28135 not virtual. Fixes bug in MIS
28137 * statement.cs (Do.Emit, While.Emit, For.Emit,
28138 Statement.EmitBoolExpression): Add support to Do and While to
28139 propagate infinite loop as `I do return' semantics.
28141 Improve the For case to also test for boolean constants.
28143 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28144 to the list of attributes we can add.
28146 Remove `EmitContext' argument.
28148 * class.cs (Method.Define): Apply parameter attributes.
28149 (Constructor.Define): Apply parameter attributes.
28150 (MethodCore.LabelParameters): Move here the core of labeling
28153 * support.cs (ReflectionParameters.ParameterModifier,
28154 InternalParameters.ParameterModifier): Use IsByRef on the type and
28155 only return the OUT bit for these parameters instead of in/out/ref
28158 This is because I miss-understood things. The ParameterInfo.IsIn
28159 and IsOut represent whether the parameter has the [In] and [Out]
28162 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28164 * ecore.cs (FieldExpr.Emit): Release temporaries.
28166 * assign.cs (LocalTemporary.Release): new function.
28168 * codegen.cs (EmitContext.GetTemporaryStorage,
28169 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28170 temporary storage. Now we can "put back" localbuilders when we
28173 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28175 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28176 need to make a copy of the variable to generate verifiable code.
28178 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28180 * driver.cs: Compute dynamically the system directory.
28182 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28183 Slower, but more generally useful. Used by the abstract
28184 registering implementation.
28186 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28187 the rules for the special rule on Type/instances. First check if
28188 we have the same name, and if so, try that special static path
28189 rather than the instance path.
28191 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28193 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28196 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28197 Enum, ValueType, Delegate or Array for non-corlib compiles.
28199 * cs-tokenizer.cs: Catch long identifiers (645)
28201 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28204 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28205 fix, we were returning too early, so we were not registering
28206 pending methods from abstract classes.
28208 Do not register pending methods if the class is abstract.
28210 * expression.cs (Conditional.DoResolve): Report circular implicit
28211 conversions when we neecd to compute it for conditional
28214 (Is.DoResolve): If the expression is always of the provided type,
28215 flag warning 183. If the expression can not ever be of the
28216 provided type flag warning 184.
28218 * class.cs: Catch 169 as well.
28220 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28223 2002-01-18 Nick Drochak <ndrochak@gol.com>
28225 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28227 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28229 * interface.cs: (PopulateMethod): Check for pointers being defined
28230 only if the unsafe context is active.
28231 (PopulateProperty): ditto.
28232 (PopulateIndexer): ditto.
28234 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28235 specified. If pointers are present, make sure that they are
28236 present in an unsafe context.
28237 (Constructor, Constructor.Define): ditto.
28238 (Field, Field.Define): ditto.
28239 (Property, Property.Define): ditto.
28240 (Event, Event.Define): ditto.
28242 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28243 hashtable if there are classes or structs defined.
28245 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28246 code, as the constant resolution moved.
28248 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28249 the metadata, so we can flag error 133.
28251 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28252 pointer is being declared in an unsafe context.
28254 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28256 * modifiers.cs (Modifiers.Check): Require a Location argument.
28257 Report error 227 for Unsafe use.
28259 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28261 * statement.cs (For.Emit): If the test is null, then report that
28262 we do `return', as we wont reach anything afterwards.
28264 (Switch.SwitchGoverningType): Track the expression that matched
28267 * driver.cs: Allow negative numbers as an error code to flag.
28269 * cs-parser.jay: Handle 1551.
28271 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28273 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28275 * cs-parser.jay: Report 1518 (type declaration can only contain
28276 class, struct, interface, enum or delegate)
28278 (switch_label): Report 1523 (keywords `case' or `default' must
28281 (opt_switch_sections): Report 1522 (empty switch)
28283 * driver.cs: Report 1515 (response file specified multiple times)
28284 Report 1516 (Source file specified multiple times).
28286 * expression.cs (Argument.Resolve): Signal 1510
28288 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28289 access not allowed in static code)
28291 2002-01-11 Ravi Pratap <ravi@ximian.com>
28293 * typemanager.cs (IsPointerType): Utility method which we are going
28296 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28297 the object type, so we take care of that.
28299 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28301 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28302 added to non-params parameters :-)
28304 * typemanager.cs (CSharpName): Include 'void' type too.
28306 (void_ptr_type): Include in the set of core types.
28308 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28311 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28314 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28315 completely forgotten about it.
28317 2002-01-10 Ravi Pratap <ravi@ximian.com>
28319 * cs-parser.jay (pointer_type): Add. This begins our implementation
28320 of parsing rules for unsafe code.
28322 (unsafe_statement): Implement.
28324 (embedded_statement): Modify to include the above.
28326 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28328 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28329 if the current context is an unsafe one.
28331 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28332 are handled differently, we need separate rules for them.
28334 (local_variable_declaration): Update to use local_variable_pointer_type
28335 to allow variable declarations of unmanaged pointer types.
28337 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28338 in unsafe contexts.
28340 * ../errors/cs0214.cs : Add.
28342 2002-01-16 Nick Drochak <ndrochak@gol.com>
28344 * makefile: remove 'response' file when cleaning.
28346 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28348 * cs-parser.jay: Report 1524.
28350 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28352 * typemanager.cs (RegisterMethod): drop checking if we have
28353 registered this from here
28355 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28357 * class.cs (Method.EmitDestructor): Implement calling our base
28360 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28361 value of InFinally.
28363 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28364 this routine and will wrap the call in a try/catch block. Deal
28367 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28369 * ecore.cs (Expression.MemberLookup): instead of taking a
28370 parameter `same_type' that was used to tell whether we could
28371 access private members we compute our containing type from the
28374 (FieldExpr): Added partial support for volatile fields. This does
28375 not work for volatile fields exposed from assemblies, as I can not
28376 figure out how to extract the modreq from it.
28378 Updated all the source files to use this.
28380 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28381 because it is referenced by MemberLookup very often.
28383 2002-01-09 Ravi Pratap <ravi@ximian.com>
28385 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28386 TypeBuilder.GetCustomAttributes to retrieve what we need.
28388 Get rid of redundant default_member_attr_type as this is the same as
28389 default_member_type which already exists.
28391 * interface.cs, attribute.cs : Update accordingly.
28393 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28395 * typemanager.cs: Enable IndexerPropertyName again. It does not
28396 work for TYpeBuilders though. Ravi, can you please fix this?
28398 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28400 * expression.cs (Argument.Emit): Handle the case of ref objects
28401 being passed to ref functions;
28403 (ParameterReference.EmitLoad): Loads the content of the pointer
28404 without dereferencing.
28406 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28408 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28410 2002-01-08 Ravi Pratap <ravi@ximian.com>
28412 * class.cs (Indexer.DefineMethod): Incorporate the interface
28413 type in the name of the method if we are doing explicit interface
28416 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28418 (BetterConversion): Fix extremely trivial bug where we were referring to
28419 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28422 * ../errors/bug16.cs : Add although we have fixed it.
28424 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28426 * expression.cs (BaseIndexer): Begin implementation.
28428 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28430 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28431 production directly to remove a shift/reduce, and implement
28432 explicit interface implementation.
28434 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28435 after a floating point suffix.
28437 * expression.cs (DoNumericPromotions): Improved the conversion for
28438 uint/uint. If we have a constant, we avoid doing a typecast to a
28441 * class.cs (Indexer): Implement explicit interface implementation
28444 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28446 * class.cs: make the default instance constructor public and hidebysig.
28448 2001-01-03 Ravi Pratap <ravi@ximian.com>
28450 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28451 so we can call it from elsewhere.
28453 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28454 we emit it internally if the class has a defined indexer; otherwise the user
28455 emits it by decorating the class definition with the DefaultMemberAttribute.
28457 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28458 attribute is not used on a type which defines an indexer.
28460 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28461 character when we skip whitespace.
28463 * ../errors/cs0646.cs : Add.
28465 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28467 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28470 * makefile: Add practical target `mcs3.exe' which builds the third
28471 generation compiler.
28473 * expression.cs (New): Fix structures constructor calling.
28475 * class.cs (Property, Method, Indexer): Emit Final flag on the
28476 method if we are an interface implementation and we are not
28479 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28480 whether this property is referencing a `base' method.
28482 * expression.cs (Invocation.EmitCall): take an extra argument:
28483 is_base, this is used to determine whether the `call' or
28484 `callvirt' opcode should be used.
28487 * delegate.cs: update EmitCall.
28489 * class.cs (Method.Define): Set NewSlot for the cases where we are
28490 not implementing an interface method.
28492 (Property.Define): ditto.
28494 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28496 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28497 'r'. Allows mcs to parse itself fully.
28499 2002-01-02 Ravi Pratap <ravi@ximian.com>
28501 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28502 of the number of initializers that require the InitializeArray method.
28504 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28505 update the above field where necessary.
28507 (MakeByteBlob): Update accordingly.
28509 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28512 (EmitDynamicInitializers): Update in accordance with the new optimization.
28514 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28515 same OpCode applies.
28517 * cs-parser.jay : Fix some glaring errors I introduced.
28519 2002-01-01 Ravi Pratap <ravi@ximian.com>
28521 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28522 so that we can check for name clashes there too.
28524 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28525 for interface indexers.
28527 * interfaces.cs (Define): Emit the default member attribute.
28529 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28530 variable was being referred to while setting the value ;-)
28532 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28534 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28535 byte-by-byte information when we know the data is zero.
28537 Make the block always a multiple of 4, because
28538 DefineInitializedData has a bug.
28540 * assign.cs: Fix, we should assign from the temporary, not from
28543 * expression.cs (MakeByteBlob): Fix my incorrect code.
28545 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28547 * typemanager.cs (EnumToUnderlying): This function is used to get
28548 the underlying type from an enumeration, because it does not
28551 * constant.cs: Use the I4_S form for values between -128 and 127.
28553 * statement.cs (Block.LookupLabel): Looks up a label.
28554 (Block): Drop support for labeled blocks.
28556 (LabeledStatement): New kind of statement that represents a label
28559 (Goto): Finally implement this bad boy.
28561 * cs-parser.jay: Update to reflect new mechanism to implement
28564 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28566 * codegen.cs (EmitContext.This): a codegen property that keeps the
28567 a single instance of this instead of creating many different this
28570 * delegate.cs (Delegate.DoResolve): Update to use the property;
28572 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28574 * expression.cs (BaseAccess.DoResolve): Ditto.
28576 2001-12-29 Ravi Pratap <ravi@ximian.com>
28578 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28579 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28581 (InitCoreTypes): Update accordingly.
28583 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28584 so we can quickly store the state.
28586 (ApplyAttributes): Set the correct implementation flags
28587 for InternalCall methods.
28589 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28591 * expression.cs (EmitCall): if a method is not virtual, then do
28592 not use callvirt on it.
28594 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28595 user defined stuff) requires the use of stobj, which takes an
28596 address on the stack instead of an array and an index. So emit
28597 the Ldelema operation for it.
28599 (EmitStoreOpcode): Use stobj for valuetypes.
28601 (UnaryMutator.EmitCode): Use the right 1 value depending on
28602 whether we are dealing with int64/uint64, float or doubles.
28604 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28605 constructors that I implemented last night.
28607 (Constructor.IsDefault): Fix to work properly for static
28610 * cs-parser.jay (CheckDef): report method signature errors.
28611 Update error number 103 to be 132.
28613 * decl.cs: New AdditionResult enumeration value: MethodExists.
28614 Although we do this check for methods later on in the semantic
28615 analysis, catching repeated default constructors is so easy that
28616 we catch these here.
28618 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28621 (ParameterReference.EmitAssign, Emit): handle
28624 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28625 (ArrayAccess.EmitStoreOpcode): ditto.
28627 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28629 * expression.cs (MakeByteBlob): Complete all the missing types
28630 (uint, short, ushort, byte, sbyte)
28632 * class.cs: Only init instance field initializers on instance
28635 Rename `constructors' to instance_constructors.
28637 (TypeContainer.AddConstructor): Only add constructors to the list
28638 if it is not static.
28640 Make sure that we handle default_static_constructor independently
28641 everywhere where we handle instance_constructors
28643 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28645 * class.cs: Do not lookup or create a base initializer for a
28646 static constructor.
28648 (ConstructorInitializer.Resolve): use the proper type to lookup
28651 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28653 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28656 * decl.cs: CloseType is now an virtual method, the default
28657 implementation just closes this type.
28659 2001-12-28 Ravi Pratap <ravi@ximian.com>
28661 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28662 to PreserveSig by default. Also emit HideBySig on such methods.
28664 Basically, set the defaults to standard values.
28666 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28667 argument, if candidate is better, it can't be worse than the best !
28669 (Invocation): Re-write bits to differentiate between methods being
28670 applicable in their expanded form and their normal form - for params
28673 Get rid of use_standard everywhere as only standard conversions are allowed
28674 in overload resolution.
28676 More spec conformance.
28678 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28680 * driver.cs: Add --timestamp, to see where the compiler spends
28683 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28684 `this' in static code.
28686 (SimpleName.DoResolve): Implement in terms of a helper function
28687 that allows static-references to be passed upstream to
28690 (Expression.ResolveWithSimpleName): Resolve specially simple
28691 names when called by MemberAccess to implement the special
28694 (Expression.ImplicitReferenceConversion): Handle conversions from
28695 Null to reference types before others, as Null's type is
28698 * expression.cs (Invocation.EmitCall): Handle the special case of
28699 calling methods declared on a reference type from a ValueType
28700 (Base classes System.Object and System.Enum)
28702 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28703 the left hand side is a TypeExpr, not on every enumeration.
28705 (Binary.Resolve): If types are reference types, then do a cast to
28706 object on operators != and == of both arguments.
28708 * typemanager.cs (FindMembers): Extract instance and static
28709 members if requested.
28711 * interface.cs (PopulateProperty): Use void_type instead of null
28712 as the return type for the setter method.
28714 (PopulateIndexer): ditto.
28716 2001-12-27 Ravi Pratap <ravi@ximian.com>
28718 * support.cs (ReflectionParameters): Fix minor bug where we
28719 were examining the wrong parameter for the ParamArray attribute.
28721 Cope with requests for the type of the parameter at position
28722 greater than the params parameter's. We now return the element
28723 type of the params array as that makes more sense.
28725 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28726 accordingly as we no longer have to extract the element type
28729 (Invocation.OverloadResolve): Update.
28731 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28733 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28734 against IEnumerator, test whether the return value is a descendant
28735 of the IEnumerator interface.
28737 * class.cs (Indexer.Define): Use an auxiliary method to implement
28738 the other bits of the method definition. Begin support for
28739 explicit interface implementation.
28741 (Property.DefineMethod): Use TypeManager.void_type instead of null
28742 for an empty return value.
28744 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28746 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28747 dealing with a FieldExpr which is composed of a FieldBuilder, in
28748 the code path we did extract the constant, but we should have
28749 obtained the underlying value to be able to cast it (otherwise we
28750 end up in an infinite loop, this is what Ravi was running into).
28752 (ArrayCreation.UpdateIndices): Arrays might be empty.
28754 (MemberAccess.ResolveMemberAccess): Add support for section
28755 14.5.4.1 that deals with the special case of E.I when E is a type
28756 and something else, that I can be a reference to a static member.
28758 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28759 handle a particular array type to create byte blobs, it is just
28760 something we dont generate byteblobs for.
28762 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28765 * location.cs (Push): remove the key from the hashtable that we
28766 are about to add. This happens for empty files.
28768 * driver.cs: Dispose files after we have parsed them.
28770 (tokenize): new function that only runs the tokenizer on its
28771 input, for speed testing.
28773 2001-12-26 Ravi Pratap <ravi@ximian.com>
28775 * class.cs (Event.Define): Define the private field only if there
28776 are no accessors defined.
28778 * expression.cs (ResolveMemberAccess): If there is no associated
28779 field with the event, that means we have an event defined with its
28780 own accessors and we should flag error cs0070 since transforming
28781 ourselves into a field is not valid in that case.
28783 * ecore.cs (SimpleName.DoResolve): Same as above.
28785 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28786 and charset to sane values.
28788 2001-12-25 Ravi Pratap <ravi@ximian.com>
28790 * assign.cs (DoResolve): Perform check on events only if they
28791 are being accessed outside the declaring type.
28793 * cs-parser.jay (event_declarations): Update rules to correctly
28794 set the type of the implicit parameter etc.
28796 (add_accessor, remove_accessor): Set current local parameters.
28798 * expression.cs (Binary): For delegate addition and subtraction,
28799 cast the return value from the method into the appropriate delegate
28802 2001-12-24 Ravi Pratap <ravi@ximian.com>
28804 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28805 of these as the workaround is unnecessary.
28807 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28808 delegate data - none of that is needed at all.
28810 Re-write bits to extract the instance expression and the delegate method
28813 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28816 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28817 of attaching attributes instead of duplicating code everywhere.
28819 * everywhere : Update code to do attribute emission using the above method.
28821 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28823 * expression.cs (IsParamsMethodApplicable): if there are not
28824 parameters, return immediately.
28826 * ecore.cs: The 0 literal can be implicity converted to an enum
28829 (SimpleName.DoResolve): First lookup the type, then lookup the
28832 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28833 want to get its address. If the InstanceExpression is not
28834 addressable, store the result in a temporary variable, then get
28837 * codegen.cs: Only display 219 errors on warning level or above.
28839 * expression.cs (ArrayAccess): Make it implement the
28840 IMemoryLocation interface.
28842 (Binary.DoResolve): handle the operator == (object a, object b)
28843 and operator != (object a, object b) without incurring into a
28844 BoxedCast (because 5 != o should never be performed).
28846 Handle binary enumerator operators.
28848 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28849 value type, otherwise use Ldelem_ref.
28851 Use precomputed names;
28853 (AddressOf): Implement address of
28855 * cs-parser.jay (labeled_statement): Fix recursive block
28856 addition by reworking the production.
28858 * expression.cs (New.DoEmit): New has a special case:
28860 If we are dealing with a ValueType, we have a few
28861 situations to deal with:
28863 * The target of New is a ValueType variable, that is
28864 easy, we just pass this as the variable reference
28866 * The target of New is being passed as an argument,
28867 to a boxing operation or a function that takes a
28870 In this case, we need to create a temporary variable
28871 that is the argument of New.
28874 2001-12-23 Ravi Pratap <ravi@ximian.com>
28876 * rootcontext.cs (LookupType): Check that current_type is not null before
28877 going about looking at nested types.
28879 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28880 not implement the IAssignMethod interface any more.
28882 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28883 where we tranform them into FieldExprs if they are being resolved from within
28884 the declaring type.
28886 * ecore.cs (SimpleName.DoResolve): Do the same here.
28888 * assign.cs (DoResolve, Emit): Clean up code considerably.
28890 * ../errors/bug10.cs : Add.
28892 * ../errors/cs0070.cs : Add.
28894 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28896 * assign.cs : Get rid of EventIsLocal everywhere.
28898 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28900 * ecore.cs (ConvertIntLiteral): finished the implementation.
28902 * statement.cs (SwitchLabel): Convert the value we are using as a
28903 key before looking up the table.
28905 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28907 * codegen.cs (EmitTopBlock): Require a Location argument now.
28909 * cs-parser.jay (constructor_declarator): We need to setup
28910 current_local_parameters before we parse the
28911 opt_constructor_initializer, to allow the variables to be bound
28912 to the constructor arguments.
28914 * rootcontext.cs (LookupType): First lookup nested classes in our
28915 class and our parents before we go looking outside our class.
28917 * expression.cs (ConstantFold): Extract/debox the values at the
28920 * rootcontext.cs (EmitCode): Resolve the constants first before we
28921 resolve the types. This is not really needed, but it helps debugging.
28923 * statement.cs: report location.
28925 * cs-parser.jay: pass location to throw statement.
28927 * driver.cs: Small bug fix.
28929 * report.cs: Updated format to be 4-zero filled digits.
28931 2001-12-22 Ravi Pratap <ravi@ximian.com>
28933 * expression.cs (CheckIndices): Fix minor bug where the wrong
28934 variable was being referred to ;-)
28936 (DoEmit): Do not call EmitStaticInitializers when the
28937 underlying type is System.Object.
28939 2001-12-21 Ravi Pratap <ravi@ximian.com>
28941 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28942 and do the usual workaround for SRE.
28944 * class.cs (MyEventBuilder.EventType): New member to get at the type
28945 of the event, quickly.
28947 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28949 * assign.cs (Assign.DoResolve): Handle the case when the target
28950 is an EventExpr and perform the necessary checks.
28952 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28955 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28957 (EventExpr): Set the type in the constructor itself since we
28958 are meant to be born fully resolved.
28960 (EventExpr.Define): Revert code I wrote earlier.
28962 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28963 instance expression is null. The instance expression is a This in that case
28964 or a null, depending on whether it is a static method or not.
28966 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28967 refers to more than one method.
28969 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28970 and accordingly flag errors.
28972 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28974 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28976 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28978 * location.cs (ToString): Provide useful rutine.
28980 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28982 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28983 objects, return the actual integral boxed.
28985 * statement.cs (SwitchLabel): define an ILLabel for each
28988 (Switch.CheckSwitch): If the value is a Literal, extract
28989 the underlying literal.
28991 Also in the unused hashtable we had, add the SwitchLabel so we can
28992 quickly look this value up.
28994 * constant.cs: Implement a bunch of new constants. Rewrite
28995 Literal based on this. Made changes everywhere to adapt to this.
28997 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28998 dereferencing array only once, and also copes with enumrations.
29000 bytes are two bytes wide, not one.
29002 (Cast): Perform constant conversions.
29004 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29005 wrappers to the literals here.
29007 * expression.cs (DoNumericPromotions): long literals can converted
29008 to ulong implicity (this is taken care of elsewhere, but I was
29009 missing this spot).
29011 * ecore.cs (Expression.Literalize): Make the return type Literal,
29012 to improve type checking.
29014 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29016 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29018 * literal.cs: Revert code from ravi that checked the bounds. The
29019 bounds are sane by the definition of the type itself.
29021 * typemanager.cs: Fix implementation of ImplementsInterface. We
29022 need to actually look up in our parent hierarchy for interfaces
29025 * const.cs: Use the underlying type for enumerations
29027 * delegate.cs: Compute the basename for the delegate creation,
29028 that should fix the delegate test case, and restore the correct
29029 Type Lookup semantics in rootcontext
29031 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29032 referencing a nested type with the Reflection API is using the "+"
29035 * cs-parser.jay: Do not require EOF token at the end.
29037 2001-12-20 Ravi Pratap <ravi@ximian.com>
29039 * rootcontext.cs (LookupType): Concatenate type names with
29040 a '.' instead of a '+' The test suite passes again.
29042 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29043 field of the enumeration.
29045 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29046 the case when the member is an EventExpr.
29048 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29049 static has an associated instance expression.
29051 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29053 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29055 * class.cs (Event.Define): Register event and perform appropriate checks
29058 We define the Add and Remove methods even if the use provides none because
29059 in that case, we provide default implementations ourselves.
29061 Define a private field of the type of the event. This is done by the CSC compiler
29062 and we should be doing it too ;-)
29064 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29065 More methods we use in code we generate.
29067 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29070 (InitCoreTypes): Update accordingly for the above.
29072 * class.cs (Event.Emit): Generate code for default accessors that we provide
29074 (EmitDefaultMethod): Do the job in the above.
29076 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29079 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29081 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29082 builders even if we were missing one.
29084 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29085 pass the Basename as our class name instead of the Name. The
29086 basename will be correctly composed for us.
29088 * parameter.cs (Paramters): Now takes a Location argument.
29090 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29091 make all the code call directly LookupType in RootContext and take
29092 this chance to pass the Location information everywhere.
29094 * Everywhere: pass Location information.
29096 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29098 * class.cs (Constructor.Define): Updated way of detecting the
29099 length of the parameters.
29101 (TypeContainer.DefineType): Use basename as the type name for
29104 (TypeContainer.Define): Do not recursively define types here, as
29105 definition is taken care in order by the RootContext.
29107 * tree.cs: Keep track of namespaces in a per-file basis.
29109 * parameter.cs (Parameter.ComputeSignature): Update to use
29112 (Parameters.GetSignature): ditto.
29114 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29115 instead of a TypeContainer.
29117 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29118 resolve names. Because we need to be resolve in our context, not
29121 * driver.cs: Implement response files.
29123 * class.cs (TypeContainer.DefineType): If we are defined, do not
29124 redefine ourselves.
29126 (Event.Emit): Emit the code for add/remove handlers.
29127 (Event.Define): Save the MethodBuilders for add/remove.
29129 * typemanager.cs: Use pair here too.
29131 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29132 DictionaryEntry requires the first argument to be non-null.
29134 (enum_declaration): Compute full name for registering the
29137 (delegate_declaration): Instead of using
29138 formal_parameter_list, use opt_formal_parameter_list as the list
29141 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29142 (EventParsing): New property that controls whether `add' and
29143 `remove' are returned as tokens or identifiers (for events);
29145 2001-12-19 Ravi Pratap <ravi@ximian.com>
29147 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29148 use MyEventBuilder only and let it wrap the real builder for us.
29150 (MyEventBuilder): Revamp constructor etc.
29152 Implement all operations that we perform on EventBuilder in precisely the same
29155 (FindMembers): Update to use the EventBuilder member.
29157 (Event.Emit): Update accordingly.
29159 2001-12-18 Ravi Pratap <ravi@ximian.com>
29161 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29162 by calling the appropriate methods.
29164 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29167 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29169 2001-12-17 Ravi Pratap <ravi@ximian.com>
29171 * delegate.cs (Delegate.Populate): Check that the return type
29172 and various parameters types are indeed accessible.
29174 * class.cs (Constructor.Define): Same here.
29176 (Field.Define): Ditto.
29178 (Event.Define): Ditto.
29180 (Operator.Define): Check that the underlying Method defined itself
29181 correctly - so it's MethodBuilder should not be null.
29183 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29184 expression happens to be null.
29186 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29187 members but as of now we don't seem to be able to do anything really useful with it.
29189 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29190 not the EventBuilder.
29192 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29194 * cs-tokenizer.cs: Add support for defines.
29195 Add support for #if, #elif, #else, #endif
29197 (eval_var): evaluates a variable.
29198 (eval): stubbed for evaluating functions.
29200 * cs-parser.jay: Pass the defines information
29202 * driver.cs: Add --define command line option.
29204 * decl.cs: Move MemberCore here.
29206 Make it the base class for DeclSpace. This allows us to catch and
29207 report 108 and 109 for everything now.
29209 * class.cs (TypeContainer.Define): Extract all the members
29210 before populating and emit the warning 108 (new keyword required
29211 to override) instead of having each member implement this.
29213 (MemberCore.Define): New abstract method, we will be using this in
29214 the warning reporting engine in Populate.
29216 (Operator.Define): Adjust to new MemberCore protocol.
29218 * const.cs (Const): This does not derive from Expression, it is a
29219 temporary object we use to create fields, it is a MemberCore.
29221 * class.cs (Method.Define): Allow the entry point to be in a
29224 * driver.cs: Rewrite the argument handler to clean it up a bit.
29226 * rootcontext.cs: Made it just an auxiliary namespace feature by
29227 making everything static.
29229 * driver.cs: Adapt code to use RootContext type name instead of
29232 * delegate.cs: Remove RootContext argument.
29234 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29237 * class.cs (Event.Define): The lookup can fail.
29239 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29241 * expression.cs: Resolve the this instance before invoking the code.
29243 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29245 * cs-parser.jay: Add a production in element_access that allows
29246 the thing to become a "type" reference. This way we can parse
29247 things like "(string [])" as a type.
29249 Note that this still does not handle the more complex rules of
29253 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29255 * ecore.cs: (CopyNewMethods): new utility function used to
29256 assemble the list of methods from running FindMembers.
29258 (MemberLookup): Rework FindMembers so that
29260 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29262 * class.cs (TypeContainer): Remove Delegates who fail to be
29265 * delegate.cs (Populate): Verify that we dont get null return
29266 values. TODO: Check for AsAccessible.
29268 * cs-parser.jay: Use basename to emit error 574 (destructor should
29269 have the same name as container class), not the full name.
29271 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29272 possible representation.
29274 Also implements integer type suffixes U and L.
29276 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29278 * expression.cs (ArrayCreation.DoResolve): We need to do the
29279 argument resolution *always*.
29281 * decl.cs: Make this hold the namespace. Hold the root context as
29283 (LookupType): Move here.
29285 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29287 * location.cs (Row, Name): Fixed the code, it was always returning
29288 references to the first file.
29290 * interface.cs: Register properties defined through interfaces.
29292 * driver.cs: Add support for globbing on the command line
29294 * class.cs (Field): Make it derive from MemberCore as well.
29297 2001-12-15 Ravi Pratap <ravi@ximian.com>
29299 * class.cs (Event::Define): Check that the type of the event is a delegate
29300 type else flag error #66.
29302 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29305 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29306 values of EntryPoint, CharSet etc etc.
29308 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29310 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29311 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29312 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29313 which needs this to do its work.
29315 * ../errors/cs0066.cs : Add.
29317 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29319 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29322 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29323 clears out the parameters field.
29324 (MemberSignatureCompare): Cleanup
29326 (MemberCore): New base class used to share code between MethodCore
29329 (RegisterRequiredImplementations) BindingFlags.Public requires
29330 either BindingFlags.Instace or Static. Use instance here.
29332 (Property): Refactored code to cope better with the full spec.
29334 * parameter.cs (GetParameterInfo): Return an empty array instead
29337 * class.cs (Property): Abstract or extern properties have no bodies.
29339 * parameter.cs (GetParameterInfo): return a zero-sized array.
29341 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29342 method modifier validation to the typecontainer so we can reuse
29343 this on properties.
29345 (MethodCore.ParameterTypes): return an empty sized array of types.
29347 (Property.Define): Test property modifier validity.
29349 Add tests for sealed/override too.
29351 (Method.Emit): abstract or extern methods have no bodies.
29353 2001-12-14 Ravi Pratap <ravi@ximian.com>
29355 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29358 (Method::Define, ::Emit): Modify accordingly.
29360 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29362 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29364 * makefile: Pass in /unsafe.
29366 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29368 * class.cs (MakeKey): Kill routine.
29370 * class.cs (TypeContainer.Define): Correctly define explicit
29371 method implementations (they require the full interface name plus
29374 * typemanager.cs: Deply the PtrHashtable here and stop using the
29375 lame keys. Things work so much better.
29377 This of course broke everyone who depended on `RegisterMethod' to
29378 do the `test for existance' test. This has to be done elsewhere.
29380 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29381 the object stupid Equals method (because, that like fails all over
29382 the place). We still do not use it.
29384 * class.cs (TypeContainer.SetRequiredInterface,
29385 TypeContainer.RequireMethods): Killed these two routines and moved
29386 all the functionality to RegisterRequiredImplementations.
29388 (TypeContainer.RegisterRequiredImplementations): This routine now
29389 registers all the implementations required in an array for the
29390 interfaces and abstract methods. We use an array of structures
29391 which can be computed ahead of time to reduce memory usage and we
29392 also assume that lookups are cheap as most classes will not
29393 implement too many interfaces.
29395 We also avoid creating too many MethodSignatures.
29397 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29398 clear the "pending" bit if we find that there are problems with
29401 (TypeContainer.VerifyPendingMethods): Update to report errors of
29402 methods that look like implementations but are not.
29404 (TypeContainer.Define): Add support for explicit interface method
29407 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29409 * typemanager.cs: Keep track of the parameters here instead of
29410 being a feature of the TypeContainer.
29412 * class.cs: Drop the registration of parameters here, as
29413 InterfaceMethods are also interface declarations.
29415 * delegate.cs: Register methods with the TypeManager not only with
29416 the TypeContainer. This code was buggy.
29418 * interface.cs: Full registation here.
29420 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29422 * expression.cs: Remove reducer for binary expressions, it can not
29425 * const.cs: Put here the code that used to go into constant.cs
29427 * constant.cs: Put here the code for constants, this is a new base
29428 class for Literals.
29430 * literal.cs: Make Literal derive from Constant.
29432 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29434 * statement.cs (Return.Emit): Report error 157 if the user
29435 attempts to return from a finally block.
29437 (Return.Emit): Instead of emitting a return, jump to the end of
29440 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29441 LocalBuilder to store the result of the function. ReturnLabel is
29442 the target where we jump.
29445 2001-12-09 Radek Doulik <rodo@ximian.com>
29447 * cs-parser.jay: remember alias in current namespace
29449 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29452 * class.cs (LookupAlias): lookup alias in my_namespace
29454 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29456 (LookupAlias): lookup alias in this and if needed in parent
29459 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29463 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29464 making things static. I need this to avoid passing the
29465 TypeContainer when calling ParameterType.
29467 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29468 that did string manipulation to compute the type and then call
29469 GetType. Use Parameter.ParameterType instead.
29471 * cs-tokenizer.cs: Consume the suffix for floating values.
29473 * expression.cs (ParameterReference): figure out whether this is a
29474 reference parameter or not. Kill an extra variable by computing
29475 the arg_idx during emission.
29477 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29478 function that returns whether a parameter is an out/ref value or not.
29480 (Parameter.ParameterType): The type of the parameter (base,
29481 without ref/out applied).
29483 (Parameter.Resolve): Perform resolution here.
29484 (Parameter.ExternalType): The full type (with ref/out applied).
29486 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29487 support for expressions on the using statement.
29489 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29491 * statement.cs (Using.EmitLocalVariableDecls): Split the
29492 localvariable handling of the using statement.
29494 (Block.EmitMeta): Keep track of variable count across blocks. We
29495 were reusing slots on separate branches of blocks.
29497 (Try.Emit): Emit the general code block, we were not emitting it.
29499 Check the type of the declaration to be an IDisposable or
29500 something that can be implicity converted to it.
29502 Emit conversions if required.
29504 * ecore.cs (EmptyExpression): New utility class.
29505 (Expression.ImplicitConversionExists): New utility function.
29507 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29509 * statement.cs (Using): Implement.
29511 * expression.cs (LocalVariableReference): Support read only variables.
29513 * statement.cs: Remove the explicit emit for the Leave opcode.
29514 (VariableInfo): Add a readonly field.
29516 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29518 * ecore.cs (ConvCast): new class used to encapsulate the various
29519 explicit integer conversions that works in both checked and
29520 unchecked contexts.
29522 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29523 properly generate the overflow opcodes.
29525 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29527 * statement.cs: The correct type for the EmptyExpression is the
29528 element_type, not the variable type. Ravi pointed this out.
29530 2001-12-04 Ravi Pratap <ravi@ximian.com>
29532 * class.cs (Method::Define): Handle PInvoke methods specially
29533 by using DefinePInvokeMethod instead of the usual one.
29535 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29536 above to do the task of extracting information and defining the method.
29538 2001-12-04 Ravi Pratap <ravi@ximian.com>
29540 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29541 of the condition for string type.
29543 (Emit): Move that here.
29545 (ArrayCreation::CheckIndices): Keep string literals in their expression
29548 (EmitDynamicInitializers): Handle strings appropriately.
29550 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29552 * codegen.cs (EmitContext): Replace multiple variables with a
29553 single pointer to the current Switch statement.
29555 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29558 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29562 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29565 (Foreach.Emit): Foreach on arrays was not setting
29566 up the loop variables (for break/continue).
29568 (GotoCase): Semi-implented.
29570 2001-12-03 Ravi Pratap <ravi@ximian.com>
29572 * attribute.cs (CheckAttribute): Handle system attributes by using
29573 Attribute.GetAttributes to examine information we need.
29575 (GetValidPlaces): Same here.
29577 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29579 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29581 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29583 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29585 (Method::Emit): Handle the case when we are a PInvoke method.
29587 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29589 * expression.cs: Use ResolveWithSimpleName on compound names.
29591 2001-12-02 Ravi Pratap <ravi@ximian.com>
29593 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29594 before trying to reduce it.
29596 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29598 * constant.cs (LookupConstantValue): Implement.
29600 (EmitConstant): Use the above in emitting the constant.
29602 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29603 that are user-defined by doing a LookupConstantValue on them.
29605 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29608 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29610 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29612 (BaseAccess.DoResolve): Implement.
29614 (MemberAccess.DoResolve): Split this routine into a
29615 ResolveMemberAccess routine that can be used independently
29617 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29619 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29620 As that share bits of the implementation. Is returns a boolean,
29621 while As returns the Type that is being probed.
29623 2001-12-01 Ravi Pratap <ravi@ximian.com>
29625 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29626 instead of a Literal - much easier.
29628 (EnumInTransit): Remove - utterly useless :-)
29630 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29632 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29634 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29635 chain when we have no associated expression.
29637 2001-11-30 Ravi Pratap <ravi@ximian.com>
29639 * constant.cs (Define): Use Location while reporting the errror.
29641 Also emit a warning when 'new' is used and there is no inherited
29644 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29647 (LookupEnumValue): Implement to lookup an enum member's value and define it
29650 (Populate): Re-write accordingly to use the above routine.
29652 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29654 * expression.cs (This): Fix prototype for DoResolveLValue to
29655 override the base class DoResolveLValue.
29657 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29660 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29661 (we need to load the address of the field here). This fixes
29664 (FieldExpr.DoResolveLValue): Call the DoResolve
29665 function to initialize the Instance expression.
29667 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29668 correctly the GetEnumerator operation on a value type.
29670 * cs-parser.jay: Add more simple parsing error catches.
29672 * statement.cs (Switch): Add support for string switches.
29673 Handle null specially.
29675 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29677 2001-11-28 Ravi Pratap <ravi@ximian.com>
29679 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29681 (declare_local_constant): New helper function.
29683 * statement.cs (AddConstant): Keep a separate record of constants
29685 (IsConstant): Implement to determine if a variable is a constant.
29687 (GetConstantExpression): Implement.
29689 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29691 * statement.cs (IsVariableDefined): Re-write.
29693 2001-11-27 Ravi Pratap <ravi@ximian.com>
29695 * class.cs (TypeContainer::FindMembers): Look for constants
29696 in the case when we are looking for MemberTypes.Field
29698 * expression.cs (MemberAccess::DoResolve): Check that in the
29699 case we are a FieldExpr and a Literal, we are not being accessed
29700 by an instance reference.
29702 * cs-parser.jay (local_constant_declaration): Implement.
29704 (declaration_statement): Implement for constant declarations.
29706 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29708 * statement.cs (Switch): Catch double defaults.
29710 (Switch): More work on the switch() statement
29711 implementation. It works for integral values now, need to finish
29715 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29717 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29718 integer literals into other integer literals. To be used by
29721 2001-11-24 Ravi Pratap <ravi@ximian.com>
29723 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29726 (EmitDynamicInitializers): Cope with the above since we extract data
29727 directly from ArrayData now.
29729 (ExpectInitializers): Keep track of whether initializers are mandatory
29732 (Bounds): Make it a hashtable to prevent the same dimension being
29733 recorded for every element in that dimension.
29735 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29738 Also fix bug which was causing the indices to be emitted in the reverse
29741 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29743 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29744 unfinished. They do not work, because the underlying code is
29747 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29749 * cs-parser.jay: Remove bogus fixme.
29751 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29752 on Switch statement.
29754 2001-11-23 Ravi Pratap <ravi@ximian.com>
29756 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29759 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29760 parameter. Apparently, any expression is allowed.
29762 (ValidateInitializers): Update accordingly.
29764 (CheckIndices): Fix some tricky bugs thanks to recursion.
29766 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29767 I was being completely brain-dead.
29769 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29770 and re-write acordingly.
29772 (DelegateInvocation): Re-write accordingly.
29774 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29776 (MakeByteBlob): Handle types more correctly.
29778 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29779 initialization from expressions but it is incomplete because I am a complete
29782 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29784 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29785 on If. Basically, we have to return `true' (ie, we do return to
29786 our caller) only if both branches of the if return.
29788 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29789 short-circuit operators, handle them as short circuit operators.
29791 (Cast.DoResolve): Resolve type.
29792 (Cast.Cast): Take an expression as the target type.
29794 * cs-parser.jay (cast_expression): Remove old hack that only
29795 allowed a limited set of types to be handled. Now we take a
29796 unary_expression and we resolve to a type during semantic
29799 Use the grammar productions from Rhys to handle casts (this is
29800 not complete like Rhys syntax yet, we fail to handle that corner
29801 case that C# has regarding (-x), but we will get there.
29803 2001-11-22 Ravi Pratap <ravi@ximian.com>
29805 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29806 field which is an array type.
29808 * cs-parser.jay (declare_local_variables): Support array initialization too.
29810 * typemanager.cs (MakeKey): Implement.
29812 (everywhere): Use the above appropriately.
29814 * cs-parser.jay (for_statement): Update for array initialization while
29815 declaring variables.
29817 * ecore.cs : The error message was correct, it's the variable's names that
29818 were misleading ;-) Make the code more readable.
29820 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29821 the correct type etc.
29823 (ConvertExplicit): Handle Enum types by examining the underlying type.
29825 2001-11-21 Ravi Pratap <ravi@ximian.com>
29827 * parameter.cs (GetCallingConvention): Always return
29828 CallingConventions.Standard for now.
29830 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29832 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29833 and `r' after calling DoNumericPromotions.
29835 * ecore.cs: Fix error message (the types were in the wrong order).
29837 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29838 BindingFlags.Instance as well
29840 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29841 implicit int literal conversion in an empty cast so that we
29842 propagate the right type upstream.
29844 (UnboxCast): new class used to unbox value types.
29845 (Expression.ConvertExplicit): Add explicit type conversions done
29848 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29849 the target type before applying the implicit LongLiterals to ULong
29852 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29854 * cs-parser.jay (for_statement): Reworked the way For works: now
29855 we declare manually any variables that are introduced in
29856 for_initializer to solve the problem of having out-of-band code
29857 emition (that is what got for broken).
29859 (declaration_statement): Perform the actual variable declaration
29860 that used to be done in local_variable_declaration here.
29862 (local_variable_declaration): Do not declare anything, just pass
29863 the information on a DictionaryEntry
29865 2001-11-20 Ravi Pratap <ravi@ximian.com>
29867 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29868 re-write of the logic to now make it recursive.
29870 (UpdateIndices): Re-write accordingly.
29872 Store element data in a separate ArrayData list in the above methods.
29874 (MakeByteBlob): Implement to dump the array data into a byte array.
29876 2001-11-19 Ravi Pratap <ravi@ximian.com>
29878 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29881 * constant.cs (Define): Implement.
29883 (EmitConstant): Re-write fully.
29885 Pass in location info.
29887 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29890 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29891 DictionaryEntry since we need location info too.
29893 (constant_declaration): Update accordingly.
29895 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29896 code into another method : UpdateIndices.
29898 2001-11-18 Ravi Pratap <ravi@ximian.com>
29900 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29901 some type checking etc.
29903 2001-11-17 Ravi Pratap <ravi@ximian.com>
29905 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29906 bits to provide dimension info if the user skips doing that.
29908 Update second constructor to store the rank correctly.
29910 2001-11-16 Ravi Pratap <ravi@ximian.com>
29912 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29913 and try to implement.
29915 * ../errors/cs0150.cs : Add.
29917 * ../errors/cs0178.cs : Add.
29919 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29921 * statement.cs: Implement foreach on multi-dimensional arrays.
29923 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29924 name of the params argument.
29926 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29927 initializing the array.
29929 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29930 we can use this elsewhere.
29932 * statement.cs: Finish implementation of foreach for single
29935 * cs-parser.jay: Use an out-of-band stack to pass information
29936 around, I wonder why I need this.
29938 foreach_block: Make the new foreach_block the current_block.
29940 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29941 function used to return a static Parameters structure. Used for
29942 empty parameters, as those are created very frequently.
29944 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29946 2001-11-15 Ravi Pratap <ravi@ximian.com>
29948 * interface.cs : Default modifier is private, not public. The
29949 make verify test passes again.
29951 2001-11-15 Ravi Pratap <ravi@ximian.com>
29953 * support.cs (ReflectionParameters): Fix logic to determine
29954 whether the last parameter is a params one. Test 9 passes again.
29956 * delegate.cs (Populate): Register the builders we define with
29957 RegisterParameterForBuilder. Test 19 passes again.
29959 * cs-parser.jay (property_declaration): Reference $6 instead
29960 of $$ to get at the location.
29962 (indexer_declaration): Similar stuff.
29964 (attribute): Ditto.
29966 * class.cs (Property): Register parameters for the Get and Set methods
29967 if they exist. Test 23 passes again.
29969 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29970 call to EmitArguments as we are sure there aren't any params arguments.
29971 Test 32 passes again.
29973 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29974 IndexOutOfRangeException.
29976 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29977 Test 33 now passes again.
29979 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29981 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29982 broke a bunch of things. Will have to come up with a better way
29983 of tracking locations.
29985 * statement.cs: Implemented foreach for single dimension arrays.
29987 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29989 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29990 an error. This removes the lookup from the critical path.
29992 * cs-parser.jay: Removed use of temporary_loc, which is completely
29995 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29997 * support.cs (ReflectionParameters.ParameterModifier): Report
29998 whether the argument is a PARAMS argument or not.
30000 * class.cs: Set the attribute `ParamArrayAttribute' on the
30001 parameter argument.
30003 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30004 and cons_param_array_attribute (ConstructorInfo for
30005 ParamArrayAttribute).,
30007 * codegen.cs: Emit the return using the `Return' statement, that
30008 way we can report the error correctly for missing return values.
30010 * class.cs (Method.Emit): Clean up.
30012 * expression.cs (Argument.Resolve): Take another argument: the
30013 location where this argument is used. Notice that this is not
30014 part of the "Argument" class as to reduce the size of the
30015 structure (we know the approximate location anyways).
30017 Test if the argument is a variable-reference, if not, then
30018 complain with a 206.
30020 (Argument.Emit): Emit addresses of variables.
30022 (Argument.FullDesc): Simplify.
30024 (Invocation.DoResolve): Update for Argument.Resolve.
30026 (ElementAccess.DoResolve): ditto.
30028 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30029 method should be virtual, as this method is always virtual.
30031 (NewDelegate.DoResolve): Update for Argument.Resolve.
30033 * class.cs (ConstructorInitializer.DoResolve): ditto.
30035 * attribute.cs (Attribute.Resolve): ditto.
30037 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30039 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30041 * expression.cs (ParameterReference): Drop IStackStorage and implement
30042 IAssignMethod instead.
30044 (LocalVariableReference): ditto.
30046 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30047 IAssignMethod instead.
30049 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30051 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30052 enumerations that are used in heavily used structures derive from
30053 byte in a laughable and pathetic attempt to reduce memory usage.
30054 This is the kind of pre-optimzations that you should not do at
30055 home without adult supervision.
30057 * expression.cs (UnaryMutator): New class, used to handle ++ and
30058 -- separatedly from the other unary operators. Cleans up the
30059 code, and kills the ExpressionStatement dependency in Unary.
30061 (Unary): Removed `method' and `Arguments' from this class, making
30062 it smaller, and moving it all to SimpleCall, so I can reuse this
30063 code in other locations and avoid creating a lot of transient data
30064 strucutres when not required.
30066 * cs-parser.jay: Adjust for new changes.
30068 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30070 * enum.cs (Enum.Populate): If there is a failure during
30073 * cs-parser.jay (opt_enum_base): we used to catch type errors
30074 here, but this is really incorrect. The type error should be
30075 catched during semantic analysis.
30077 2001-12-11 Ravi Pratap <ravi@ximian.com>
30079 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30080 current_local_parameters as expected since I, in my stupidity, had forgotten
30083 * attribute.cs (GetValidPlaces): Fix stupid bug.
30085 * class.cs (Method::Emit): Perform check on applicability of attributes.
30087 (Constructor::Emit): Ditto.
30089 (Field::Emit): Ditto.
30091 (Field.Location): Store location information.
30093 (Property, Event, Indexer, Operator): Ditto.
30095 * cs-parser.jay (field_declaration): Pass in location for each field.
30097 * ../errors/cs0592.cs : Add.
30099 2001-11-12 Ravi Pratap <ravi@ximian.com>
30101 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30103 (InitCoreTypes): Update accordingly.
30105 (RegisterAttrType, LookupAttr): Implement.
30107 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30108 info about the same.
30110 (Resolve): Update to populate the above as necessary.
30112 (Error592): Helper.
30114 (GetValidPlaces): Helper to the above.
30116 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30118 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30120 2001-11-12 Ravi Pratap <ravi@ximian.com>
30122 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30124 * ../errors/cs0617.cs : Add.
30126 2001-11-11 Ravi Pratap <ravi@ximian.com>
30128 * enum.cs (Emit): Rename to Populate to be more consistent with what
30129 we expect it to do and when exactly it is called.
30131 * class.cs, rootcontext.cs : Update accordingly.
30133 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30134 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30136 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30138 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30139 of a fieldinfo using the above, when dealing with a FieldBuilder.
30141 2001-11-10 Ravi Pratap <ravi@ximian.com>
30143 * ../errors/cs0031.cs : Add.
30145 * ../errors/cs1008.cs : Add.
30147 * ../errrors/cs0543.cs : Add.
30149 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30152 (FindMembers): Implement.
30154 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30155 enums and delegates too.
30157 (enum_types): Rename to builder_to_enum.
30159 (delegate_types): Rename to builder_to_delegate.
30161 * delegate.cs (FindMembers): Implement.
30163 2001-11-09 Ravi Pratap <ravi@ximian.com>
30165 * typemanager.cs (IsEnumType): Implement.
30167 * enum.cs (Emit): Re-write parts to account for the underlying type
30168 better and perform checking etc.
30170 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30171 of the underlying type.
30173 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30176 * enum.cs (error31): Helper to report error #31.
30178 * cs-parser.jay (enum_declaration): Store location of each member too.
30180 * enum.cs (member_to_location): New hashtable.
30182 (AddEnumMember): Update location hashtable.
30184 (Emit): Use the location of each member while reporting errors.
30186 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30188 * cs-parser.jay: A for_initializer if is a
30189 local_variable_declaration really ammount to have an implicit
30190 block with the variable declaration and no initializer for for.
30192 * statement.cs (For.Emit): Cope with null initializers.
30194 This fixes the infinite loop on for initializers.
30196 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30198 * enum.cs: More cleanup.
30200 * ecore.cs: Remove dead code.
30202 * class.cs (Property.Emit): More simplification.
30203 (Event.Emit): ditto.
30205 Reworked to have less levels of indentation.
30207 2001-11-08 Ravi Pratap <ravi@ximian.com>
30209 * class.cs (Property): Emit attributes.
30219 * enum.cs (Emit): Ditto.
30221 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30224 * class.cs (Field, Event, etc.): Move attribute generation into the
30225 Emit method everywhere.
30227 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30228 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30229 as we had no way of defining nested enums !
30231 * rootcontext.cs : Adjust code accordingly.
30233 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30235 2001-11-07 Ravi Pratap <ravi@ximian.com>
30237 * expression.cs (EvalConstantExpression): Move into ecore.cs
30239 * enum.cs (Enum): Rename some members and make them public and readonly
30240 according to our convention.
30242 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30245 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30247 (Enum::Emit): Write a simple version for now which doesn't try to compute
30248 expressions. I shall modify this to be more robust in just a while.
30250 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30252 (TypeContainer::CloseType): Create the Enum types too.
30254 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30256 * expression.cs (EvalConstantExpression): Get rid of completely.
30258 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30259 user-defined values and other cases.
30261 (IsValidEnumLiteral): Helper function.
30263 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30264 out there in the case we had a literal FieldExpr.
30266 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30268 (Literalize): Revamp a bit to take two arguments.
30270 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30272 2001-11-06 Ravi Pratap <ravi@ximian.com>
30274 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30276 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30278 (Resolve): Use the above to ensure we have proper initializers.
30280 2001-11-05 Ravi Pratap <ravi@ximian.com>
30282 * expression.cs (Expression::EvalConstantExpression): New method to
30283 evaluate constant expressions.
30285 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30287 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30289 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30292 (Binary.ResolveOperator): Handle operator != (object a, object b)
30293 and operator == (object a, object b);
30295 (Binary.DoNumericPromotions): Indicate whether the numeric
30296 promotion was possible.
30298 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30301 Made the ArrayAccess implement interface IAssignMethod instead of
30302 IStackStore as the order in which arguments are passed reflects
30305 * assign.cs: Instead of using expr.ExprClass to select the way of
30306 assinging, probe for the IStackStore/IAssignMethod interfaces.
30308 * typemanager.cs: Load InitializeArray definition.
30310 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30311 static data that can be used to initialize arrays.
30313 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30315 * expression.cs: Handle operator== and operator!= for booleans.
30317 (Conditioal.Reduce): Implement reducer for the ?: operator.
30319 (Conditional.Resolve): Implement dead code elimination.
30321 (Binary.Resolve): Catch string literals and return a new
30322 concatenated string.
30324 (Unary.Reduce): Implement reduction of unary expressions.
30326 * ecore.cs: Split out the expression core handling here.
30328 (Expression.Reduce): New method used to perform constant folding
30329 and CSE. This is needed to support constant-expressions.
30331 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30332 targets, and optimize for !x.
30334 2001-11-04 Ravi Pratap <ravi@ximian.com>
30336 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30337 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30338 set custom atttributes.
30340 * literal.cs (Literal::GetValue): New abstract method to return the actual
30341 value of the literal, cast as an object.
30343 (*Literal): Implement GetValue method.
30345 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30346 expressions to the arraylist but objects of type Argument.
30348 * class.cs (TypeContainer::Emit): Emit our attributes too.
30350 (Method::Emit, Constructor::Emit): Ditto.
30352 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30353 to be ignoring earlier.
30355 2001-11-03 Ravi Pratap <ravi@ximian.com>
30357 * attribute.cs (AttributeSection::Define): Implement to do the business
30358 of constructing a CustomAttributeBuilder.
30360 (Attribute): New trivial class. Increases readability of code.
30362 * cs-parser.jay : Update accordingly.
30364 (positional_argument_list, named_argument_list, named_argument): New rules
30366 (attribute_arguments): Use the above so that we are more correct.
30368 2001-11-02 Ravi Pratap <ravi@ximian.com>
30370 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30371 to perform all checks for a method with a params parameter.
30373 (Invocation::OverloadResolve): Update to use the above method and therefore
30374 cope correctly with params method invocations.
30376 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30379 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30380 constructors in our parent too because we can't afford to miss out on
30383 * attribute.cs (AttributeSection): New name for the class Attribute
30385 Other trivial changes to improve readability.
30387 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30388 use the new class names.
30390 2001-11-01 Ravi Pratap <ravi@ximian.com>
30392 * class.cs (Method::Define): Complete definition for params types too
30394 (Indexer::Define): Ditto.
30396 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30397 Cope everywhere with a request for info about the array parameter.
30399 2001-11-01 Ravi Pratap <ravi@ximian.com>
30401 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30403 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30404 local_variable_type to extract the string corresponding to the type.
30406 (local_variable_type): Fixup the action to use the new helper method.
30408 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30411 * expression.cs : Clean out code which uses the above.
30413 2001-10-31 Ravi Pratap <ravi@ximian.com>
30415 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30416 and bale out if necessary by returning a false.
30418 (RegisterProperty): Ditto.
30420 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30421 and print out appropriate error messages.
30423 * interface.cs (everywhere): Ditto.
30425 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30426 location to constructor.
30428 * class.cs (Property, Event, Indexer): Update accordingly.
30430 * ../errors/cs111.cs : Added.
30432 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30433 of a method, as laid down by the spec.
30435 (Invocation::OverloadResolve): Use the above method.
30437 2001-10-31 Ravi Pratap <ravi@ximian.com>
30439 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30440 now take a TypeContainer and a Parameters object.
30442 (ParameterData): Modify return type of ParameterModifier method to be
30443 Parameter.Modifier and not a string.
30445 (ReflectionParameters, InternalParameters): Update accordingly.
30447 * expression.cs (Argument::GetParameterModifier): Same here.
30449 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30450 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30451 symbol in it at all so maybe this is only for now.
30453 2001-10-30 Ravi Pratap <ravi@ximian.com>
30455 * support.cs (InternalParameters): Constructor now takes an extra argument
30456 which is the actual Parameters class.
30458 (ParameterDesc): Update to provide info on ref/out modifiers.
30460 * class.cs (everywhere): Update call to InternalParameters to pass in
30461 the second argument too.
30463 * support.cs (ParameterData): Add ParameterModifier, which is a method
30464 to return the modifier info [ref/out etc]
30466 (InternalParameters, ReflectionParameters): Implement the above.
30468 * expression.cs (Argument::ParameterModifier): Similar function to return
30469 info about the argument's modifiers.
30471 (Invocation::OverloadResolve): Update to take into account matching modifiers
30474 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30475 a new SetFormalParameters object which we pass to InternalParameters.
30477 2001-10-30 Ravi Pratap <ravi@ximian.com>
30479 * expression.cs (NewArray): Merge into the ArrayCreation class.
30481 2001-10-29 Ravi Pratap <ravi@ximian.com>
30483 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30484 NewUserdefinedArray into one as there wasn't much of a use in having
30487 * expression.cs (Argument): Change field's name to ArgType from Type.
30489 (Type): New readonly property which returns the proper type, taking into
30490 account ref/out modifiers.
30492 (everywhere): Adjust code accordingly for the above.
30494 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30495 whether we are emitting for a ref or out parameter.
30497 * expression.cs (Argument::Emit): Use the above field to set the state.
30499 (LocalVariableReference::Emit): Update to honour the flag and emit the
30502 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30504 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30506 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30508 (ReflectionParameters, InternalParameters): Implement the above method.
30510 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30513 (Invocation::FullMethodDesc): Ditto.
30515 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30517 * cs-parser.jay: Add extra production for the second form of array
30520 * expression.cs (ArrayCreation): Update to reflect the above
30523 * Small changes to prepare for Array initialization.
30525 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30527 * typemanager.cs (ImplementsInterface): interface might be null;
30528 Deal with this problem;
30530 Also, we do store negative hits on the cache (null values), so use
30531 this instead of calling t.GetInterfaces on the type everytime.
30533 2001-10-28 Ravi Pratap <ravi@ximian.com>
30535 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30537 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30538 split functionality out into different classes.
30540 (New::FormArrayType): Move into NewBuiltinArray.
30542 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30545 (NewBuiltinArray): New class to handle creation of built-in arrays.
30547 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30548 account creation of one-dimensional arrays.
30550 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30552 (NewUserdefinedArray::DoResolve): Implement.
30554 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30556 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30557 we maintain inside the TypeManager. This is necessary to perform lookups on the
30560 (LookupType): Update to perform GetType on the module builders too.
30562 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30564 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30566 2001-10-23 Ravi Pratap <ravi@ximian.com>
30568 * expression.cs (New::DoResolve): Implement guts of array creation.
30570 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30572 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30574 * expression.cs: Fix bug I introduced lsat night that broke
30577 (Expression.Resolve): Report a 246 error (can not resolve name)
30578 if we find a SimpleName in the stream.
30580 (Expression.ResolveLValue): Ditto.
30582 (Expression.ResolveWithSimpleName): This function is a variant of
30583 ResolveName, this one allows SimpleNames to be returned without a
30584 warning. The only consumer of SimpleNames is MemberAccess
30586 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30588 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30589 might arrive here. I have my doubts that this is correct.
30591 * statement.cs (Lock): Implement lock statement.
30593 * cs-parser.jay: Small fixes to support `lock' and `using'
30595 * cs-tokenizer.cs: Remove extra space
30597 * driver.cs: New flag --checked, allows to turn on integer math
30600 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30601 Threading.Monitor.Exit
30603 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30605 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30606 Expression Class to be IndexerAccess.
30608 Notice that Indexer::DoResolve sets the eclass to Value.
30610 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30612 * class.cs (TypeContainer::Emit): Emit code for indexers.
30614 * assign.cs (IAssignMethod): New interface implemented by Indexers
30615 and Properties for handling assignment.
30617 (Assign::Emit): Simplify and reuse code.
30619 * expression.cs (IndexerAccess, PropertyExpr): Implement
30620 IAssignMethod, clean up old code.
30622 2001-10-22 Ravi Pratap <ravi@ximian.com>
30624 * typemanager.cs (ImplementsInterface): New method to determine if a type
30625 implements a given interface. Provides a nice cache too.
30627 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30630 (ConvertReferenceExplicit): Ditto.
30632 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30633 various methods, with correct names etc.
30635 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30636 Operator.UnaryNegation.
30638 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30639 we have a unary plus or minus operator.
30641 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30644 * everywhere : update accordingly.
30646 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30649 * class.cs (Method::Define): For the case where we are implementing a method
30650 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30651 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30653 2001-10-21 Ravi Pratap <ravi@ximian.com>
30655 * interface.cs (FindMembers): Implement to work around S.R.E
30658 * typemanager.cs (IsInterfaceType): Implement.
30660 (FindMembers): Update to handle interface types too.
30662 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30663 use IsAssignableFrom as that is not correct - it doesn't work.
30665 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30666 and accordingly override EmitStatement.
30668 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30669 using the correct logic :-)
30671 2001-10-19 Ravi Pratap <ravi@ximian.com>
30673 * ../errors/cs-11.cs : Add to demonstrate error -11
30675 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30677 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30678 then pass this as a hint to ResolveLValue.
30680 * expression.cs (FieldExpr): Add Location information
30682 (FieldExpr::LValueResolve): Report assignment to readonly
30685 (Expression::ExprClassFromMemberInfo): Pass location information.
30687 (Expression::ResolveLValue): Add new method that resolves an
30690 (Expression::DoResolveLValue): Default invocation calls
30693 (Indexers): New class used to keep track of indexers in a given
30696 (IStackStore): Renamed from LValue, as it did not really describe
30697 what this did. Also ResolveLValue is gone from this interface and
30698 now is part of Expression.
30700 (ElementAccess): Depending on the element access type
30702 * typemanager.cs: Add `indexer_name_type' as a Core type
30703 (System.Runtime.CompilerServices.IndexerNameAttribute)
30705 * statement.cs (Goto): Take a location.
30707 2001-10-18 Ravi Pratap <ravi@ximian.com>
30709 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30710 if two delegates are compatible.
30712 (NewDelegate::DoResolve): Update to take care of the case when
30713 we instantiate a delegate from another delegate.
30715 * typemanager.cs (FindMembers): Don't even try to look up members
30716 of Delegate types for now.
30718 2001-10-18 Ravi Pratap <ravi@ximian.com>
30720 * delegate.cs (NewDelegate): New class to take care of delegate
30723 * expression.cs (New): Split the delegate related code out into
30724 the NewDelegate class.
30726 * delegate.cs (DelegateInvocation): New class to handle delegate
30729 * expression.cs (Invocation): Split out delegate related code into
30730 the DelegateInvocation class.
30732 2001-10-17 Ravi Pratap <ravi@ximian.com>
30734 * expression.cs (New::DoResolve): Implement delegate creation fully
30735 and according to the spec.
30737 (New::DoEmit): Update to handle delegates differently.
30739 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30740 because of which we were printing out arguments in reverse order !
30742 * delegate.cs (VerifyMethod): Implement to check if the given method
30743 matches the delegate.
30745 (FullDelegateDesc): Implement.
30747 (VerifyApplicability): Implement.
30749 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30750 delegate invocations too.
30752 (Invocation::Emit): Ditto.
30754 * ../errors/cs1593.cs : Added.
30756 * ../errors/cs1594.cs : Added.
30758 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30760 2001-10-16 Ravi Pratap <ravi@ximian.com>
30762 * typemanager.cs (intptr_type): Core type for System.IntPtr
30764 (InitCoreTypes): Update for the same.
30766 (iasyncresult_type, asynccallback_type): Ditto.
30768 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30771 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30774 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30775 the builders for the 4 members of a delegate type :-)
30777 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30780 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30782 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30784 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30786 * statement.cs (Break::Emit): Implement.
30787 (Continue::Emit): Implement.
30789 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30790 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30791 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30792 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30795 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30796 properties that track the label for the current loop (begin of the
30797 loop and end of the loop).
30799 2001-10-15 Ravi Pratap <ravi@ximian.com>
30801 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30802 use of emitting anything at all.
30804 * class.cs, rootcontext.cs : Get rid of calls to the same.
30806 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30808 (Populate): Define the constructor correctly and set the implementation
30811 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30814 (AddDelegateType): Implement.
30816 (IsDelegateType): Implement helper method.
30818 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30820 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30821 and accordingly handle it.
30823 * delegate.cs (Populate): Take TypeContainer argument.
30824 Implement bits to define the Invoke method. However, I still haven't figured out
30825 how to take care of the native int bit :-(
30827 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30828 Qualify the name of the delegate, not its return type !
30830 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30833 (StandardConversionExists): Checking for array types turns out to be recursive.
30835 (ConvertReferenceExplicit): Implement array conversion.
30837 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30839 2001-10-12 Ravi Pratap <ravi@ximian.com>
30841 * cs-parser.jay (delegate_declaration): Store the fully qualified
30842 name as it is a type declaration.
30844 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30847 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30848 as TypeContainer::DefineType.
30850 (Populate): Method in which all the definition of the various methods (Invoke)
30853 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30856 (CloseDelegate): Finally creates the delegate.
30858 * class.cs (TypeContainer::DefineType): Update to define delegates.
30859 (Populate, Emit and CloseType): Do the same thing here too.
30861 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30862 delegates in all these operations.
30864 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30866 * expression.cs: LocalTemporary: a new expression used to
30867 reference a temporary that has been created.
30869 * assign.cs: Handle PropertyAccess back here, so that we can
30870 provide the proper semantic access to properties.
30872 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30873 a few more explicit conversions.
30875 * modifiers.cs: `NEW' modifier maps to HideBySig.
30877 * expression.cs (PropertyExpr): Make this into an
30878 ExpressionStatement, and support the EmitStatement code path.
30880 Perform get/set error checking, clean up the interface.
30882 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30883 them into toplevel access objects.
30885 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30887 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30890 * typemanager.cs: Keep track here of our PropertyBuilders again to
30891 work around lameness in SRE.
30893 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30895 * expression.cs (LValue::LValueResolve): New method in the
30896 interface, used to perform a second resolution pass for LValues.
30898 (This::DoResolve): Catch the use of this in static methods.
30900 (This::LValueResolve): Implement.
30902 (This::Store): Remove warning, assigning to `this' in structures
30905 (Invocation::Emit): Deal with invocation of
30906 methods on value types. We need to pass the address to structure
30907 methods rather than the object itself. (The equivalent code to
30908 emit "this" for structures leaves the entire structure on the
30909 stack instead of a pointer to it).
30911 (ParameterReference::DoResolve): Compute the real index for the
30912 argument based on whether the method takes or not a `this' pointer
30913 (ie, the method is static).
30915 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30916 value types returned from functions when we need to invoke a
30917 method on the sturcture.
30920 2001-10-11 Ravi Pratap <ravi@ximian.com>
30922 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30923 defining the type in the Modulebuilder or Typebuilder. This is to take
30924 care of nested types which need to be defined on the TypeBuilder using
30925 DefineNestedMethod.
30927 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30928 methods in RootContext, only ported to be part of TypeContainer.
30930 (TypeContainer::GetInterfaceOrClass): Ditto.
30932 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30934 * interface.cs (Interface::DefineInterface): New method. Does exactly
30935 what RootContext.CreateInterface did earlier, only it takes care of nested types
30938 (Interface::GetInterfaces): Move from RootContext here and port.
30940 (Interface::GetInterfaceByName): Same here.
30942 * rootcontext.cs (ResolveTree): Re-write.
30944 (PopulateTypes): Re-write.
30946 * class.cs (TypeContainer::Populate): Populate nested types too.
30947 (TypeContainer::Emit): Emit nested members too.
30949 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30950 instead just use the name argument passed in as it is already fully
30953 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30954 to TypeContainer mapping to see if a type is user-defined.
30956 * class.cs (TypeContainer::CloseType): Implement.
30958 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30959 the default constructor.
30961 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30964 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30966 * interface.cs (CloseType): Create the type here.
30968 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30971 Remove all the methods which are now in TypeContainer.
30973 2001-10-10 Ravi Pratap <ravi@ximian.com>
30975 * delegate.cs (Define): Re-write bits to define the delegate
30978 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30980 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30982 * expression.cs (ImplicitReferenceConversion): handle null as well
30983 as a source to convert to any reference type.
30985 * statement.cs (Return): Perform any implicit conversions to
30986 expected return type.
30988 Validate use of return statement.
30990 * codegen.cs (EmitContext): Pass the expected return type here.
30992 * class.cs (Method, Constructor, Property): Pass expected return
30993 type to EmitContext.
30995 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30997 * expression.cs: Make DoResolve take an EmitContext instead of a
31000 Replaced `l' and `location' for `loc', for consistency.
31002 (Error, Warning): Remove unneeded Tc argument.
31004 * assign.cs, literal.cs, constant.cs: Update to new calling
31007 * codegen.cs: EmitContext now contains a flag indicating whether
31008 code is being generated in a static method or not.
31010 * cs-parser.jay: DecomposeQI, new function that replaces the old
31011 QualifiedIdentifier. Now we always decompose the assembled
31012 strings from qualified_identifier productions into a group of
31015 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31017 * rootcontext.cs: Deal with field-less struct types correctly now
31018 by passing the size option to Define Type.
31020 * class.cs: Removed hack that created one static field.
31022 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31024 * statement.cs: Moved most of the code generation here.
31026 2001-10-09 Ravi Pratap <ravi@ximian.com>
31028 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31031 (ElementAccess): Remove useless bits for now - keep checks as the spec
31034 2001-10-08 Ravi Pratap <ravi@ximian.com>
31036 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31037 and start performing checks according to the spec.
31039 2001-10-07 Ravi Pratap <ravi@ximian.com>
31041 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31042 rank_specifiers instead.
31044 (rank_specifiers): Change the order in which the rank specifiers are stored
31046 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31048 * expression.cs (ElementAccess): Implement the LValue interface too.
31050 2001-10-06 Ravi Pratap <ravi@ximian.com>
31052 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31053 except that user defined conversions are not included.
31055 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31056 perform the conversion of the return type, if necessary.
31058 (New::DoResolve): Check whether we are creating an array or an object
31059 and accordingly do the needful.
31061 (New::Emit): Same here.
31063 (New::DoResolve): Implement guts of array creation.
31065 (New::FormLookupType): Helper function.
31067 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31069 * codegen.cs: Removed most of the code generation here, and move the
31070 corresponding code generation bits to the statement classes.
31072 Added support for try/catch/finalize and throw.
31074 * cs-parser.jay: Added support for try/catch/finalize.
31076 * class.cs: Catch static methods having the flags override,
31077 virtual or abstract.
31079 * expression.cs (UserCast): This user cast was not really doing
31080 what it was supposed to do. Which is to be born in fully resolved
31081 state. Parts of the resolution were being performed at Emit time!
31085 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31087 * expression.cs: Implicity convert the result from UserCast.
31089 2001-10-05 Ravi Pratap <ravi@ximian.com>
31091 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31092 prevented it from working correctly.
31094 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31095 merely ConvertImplicit.
31097 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31099 * typemanager.cs: Make the LookupTypeContainer function static,
31100 and not per-instance.
31102 * class.cs: Make static FindMembers (the one that takes a Type
31105 * codegen.cs: Add EmitForeach here.
31107 * cs-parser.jay: Make foreach a toplevel object instead of the
31108 inline expansion, as we need to perform semantic analysis on it.
31110 2001-10-05 Ravi Pratap <ravi@ximian.com>
31112 * expression.cs (Expression::ImplicitUserConversion): Rename to
31113 UserDefinedConversion.
31115 (Expression::UserDefinedConversion): Take an extra argument specifying
31116 whether we look for explicit user conversions too.
31118 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31120 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31122 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31123 with the appropriate arguments.
31125 * cs-parser.jay (cast_expression): Record location too.
31127 * expression.cs (Cast): Record location info.
31129 (Expression::ConvertExplicit): Take location argument.
31131 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31132 to determine if we are doing explicit conversions.
31134 (UserCast::Emit): Update accordingly.
31136 (Expression::ConvertExplicit): Report an error if everything fails.
31138 * ../errors/cs0030.cs : Add.
31140 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31142 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31143 virtual and newslot bits.
31145 * class.cs (TypeContainer::RegisterRequiredImplementations):
31146 Record methods we need.
31148 (TypeContainer::MakeKey): Helper function to make keys for
31149 MethodBases, since the Methodbase key is useless.
31151 (TypeContainer::Populate): Call RegisterRequiredImplementations
31152 before defining the methods.
31154 Create a mapping for method_builders_to_methods ahead of time
31155 instead of inside a tight loop.
31157 (::RequireMethods): Accept an object as the data to set into the
31158 hashtable so we can report interface vs abstract method mismatch.
31160 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31162 * report.cs: Make all of it static.
31164 * rootcontext.cs: Drop object_type and value_type computations, as
31165 we have those in the TypeManager anyways.
31167 Drop report instance variable too, now it is a global.
31169 * driver.cs: Use try/catch on command line handling.
31171 Add --probe option to debug the error reporting system with a test
31174 * report.cs: Add support for exiting program when a probe
31175 condition is reached.
31177 2001-10-03 Ravi Pratap <ravi@ximian.com>
31179 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31180 we do a forcible conversion regardless of type, to check if
31181 ForceConversion returns a null.
31183 (Binary::error19): Use location to report error.
31185 (Unary::error23): Use location here too.
31187 * ../errors/cs0019.cs : Check in.
31189 * ../errors/cs0023.cs : Check in.
31191 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31192 case of a non-null MethodInfo object with a length of 0 !
31194 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31195 an applicable member - according to the spec :-)
31196 Also fix logic to find members in base types.
31198 (Unary::ResolveOperator): Same here.
31200 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31201 as I was getting thoroughly confused between this and error19 :-)
31203 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31204 (::FindMostEncompassedType): Implement.
31205 (::FindMostEncompassingType): Implement.
31206 (::StandardConversionExists): Implement.
31208 (UserImplicitCast): Re-vamp. We now need info about most specific
31209 source and target types so that we can do the necessary conversions.
31211 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31212 mathematical union with no duplicates.
31214 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31216 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31217 in order from base classes to child classes, so that we can in
31218 child classes look up in our parent for method names and
31219 attributes (required for handling abstract, virtual, new, override
31220 constructs: we need to instrospect our base class, and if we dont
31221 populate the classes in order, the introspection might be
31222 incorrect. For example, a method could query its parent before
31223 the parent has any methods and would determine that the parent has
31224 no abstract methods (while it could have had them)).
31226 (RootContext::CreateType): Record the order in which we define the
31229 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31231 * class.cs (TypeContainer::Populate): Also method definitions can
31232 fail now, keep track of this.
31234 (TypeContainer::FindMembers): Implement support for
31235 DeclaredOnly/noDeclaredOnly flag.
31237 (Constructor::Emit) Return the ConstructorBuilder.
31239 (Method::Emit) Return the MethodBuilder.
31240 Check for abstract or virtual methods to be public.
31242 * rootcontext.cs (RootContext::CreateType): Register all the
31243 abstract methods required for the class to be complete and the
31244 interface methods that must be implemented.
31246 * cs-parser.jay: Report error 501 (method requires body if it is
31247 not marked abstract or extern).
31249 * expression.cs (TypeOf::Emit): Implement.
31251 * typemanager.cs: runtime_handle_type, new global type.
31253 * class.cs (Property::Emit): Generate code for properties.
31255 2001-10-02 Ravi Pratap <ravi@ximian.com>
31257 * expression.cs (Unary::ResolveOperator): Find operators on base type
31258 too - we now conform exactly to the spec.
31260 (Binary::ResolveOperator): Same here.
31262 * class.cs (Operator::Define): Fix minor quirk in the tests.
31264 * ../errors/cs0215.cs : Added.
31266 * ../errors/cs0556.cs : Added.
31268 * ../errors/cs0555.cs : Added.
31270 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31272 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31273 single integer which is really efficient
31275 2001-10-01 Ravi Pratap <ravi@ximian.com>
31277 * expression.cs (Expression::ImplicitUserConversion): Use location
31278 even in the case when we are examining True operators.
31280 * class.cs (Operator::Define): Perform extensive checks to conform
31281 with the rules for operator overloading in the spec.
31283 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31284 some of the other conversions mentioned in the spec.
31286 * typemanager.cs (array_type): New static member for the System.Array built-in
31289 (cloneable_interface): For System.ICloneable interface.
31291 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31292 we start resolving the tree and populating types.
31294 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31296 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31298 * expression.cs (Expression::ExprClassFromMemberInfo,
31299 Expression::Literalize): Create literal expressions from
31300 FieldInfos which are literals.
31302 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31303 type casts, because they were wrong. The test suite in tests
31306 (ImplicitNumericConversion): ushort to ulong requires a widening
31309 Int32 constant to long requires widening cast as well.
31311 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31312 for integers because the type on the stack is not i4.
31314 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31316 * expression.cs (report118): require location argument.
31318 * parameter.cs: Do not dereference potential null value.
31320 * class.cs: Catch methods that lack the `new' keyword when
31321 overriding a name. Report warnings when `new' is used without
31322 anything being there to override.
31324 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31326 * class.cs: Only add constructor to hashtable if it is non-null
31327 (as now constructors can fail on define).
31329 (TypeManager, Class, Struct): Take location arguments.
31331 Catch field instance initialization in structs as errors.
31333 accepting_filter: a new filter for FindMembers that is static so
31334 that we dont create an instance per invocation.
31336 (Constructor::Define): Catch errors where a struct constructor is
31339 * cs-parser.jay: Pass location information for various new
31342 * delegate.cs (Delegate): take a location argument.
31344 * driver.cs: Do not call EmitCode if there were problesm in the
31345 Definition of the types, as many Builders wont be there.
31347 * decl.cs (Decl::Decl): Require a location argument.
31349 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31350 into integers, and find the most appropiate integer for it.
31352 * literal.cs: Implement ULongLiteral.
31354 * rootcontext.cs: Provide better information about the location of
31355 failure when CreateType fails.
31357 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31359 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31362 * expression.cs (Binary::CheckShiftArguments): Add missing type
31364 (Binary::ResolveOperator): Add type to the logical and and logical
31365 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31368 (Binary::DoNumericPromotions): In the case where either argument
31369 is ulong (and most signed types combined with ulong cause an
31370 error) perform implicit integer constant conversions as well.
31372 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31374 * expression.cs (UserImplicitCast): Method should always be
31376 (Invocation::BetterConversion): Simplified test for IntLiteral.
31378 (Expression::ImplicitNumericConversion): Split this routine out.
31379 Put the code that performs implicit constant integer conversions
31382 (Expression::Resolve): Become a wrapper around DoResolve so we can
31383 check eclass and type being set after resolve.
31385 (Invocation::Badness): Remove this dead function
31387 (Binary::ResolveOperator): Do not compute the expensive argumnets
31388 unless we have a union for it.
31390 (Probe::Emit): Is needs to do an isinst and then
31391 compare against null.
31393 (::CanConvert): Added Location argument. If the Location argument
31394 is null (Location.Null), then we do not report errors. This is
31395 used by the `probe' mechanism of the Explicit conversion. We do
31396 not want to generate an error for something that the user
31397 explicitly requested to be casted. But the pipeline for an
31398 explicit cast first tests for potential implicit casts.
31400 So for now, if the Location is null, it means `Probe only' to
31401 avoid adding another argument. Might have to revise this
31404 (ClassCast): New class used to type cast objects into arbitrary
31405 classes (used in Explicit Reference Conversions).
31407 Implement `as' as well.
31409 Reverted all the patches from Ravi below: they were broken:
31411 * The use of `level' as a mechanism to stop recursive
31412 invocations is wrong. That was there just to catch the
31413 bug with a strack trace but not as a way of addressing
31416 To fix the problem we have to *understand* what is going
31417 on and the interactions and come up with a plan, not
31418 just get things going.
31420 * The use of the type conversion cache that I proposed
31421 last night had an open topic: How does this work across
31422 protection domains. A user defined conversion might not
31423 be public in the location where we are applying the
31424 conversion, a different conversion might be selected
31425 (ie, private A->B (better) but public B->A (worse),
31426 inside A, A->B applies, but outside it, B->A will
31429 * On top of that (ie, even if the above is solved),
31430 conversions in a cache need to be abstract. Ie, `To
31431 convert from an Int to a Short use an OpcodeCast', not
31432 `To convert from an Int to a Short use the OpcodeCast on
31433 the variable 5' (which is what this patch was doing).
31435 2001-09-28 Ravi Pratap <ravi@ximian.com>
31437 * expression.cs (Invocation::ConversionExists): Re-write to use
31438 the conversion cache
31440 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31441 cache all conversions done, not just user-defined ones.
31443 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31444 to determine if a conversion exists instead of acutually trying to
31445 perform the conversion. It's faster too.
31447 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31448 and only then attempt the implicit conversion.
31450 2001-09-28 Ravi Pratap <ravi@ximian.com>
31452 * expression.cs (ConvertImplicit): Use a cache for conversions
31453 already found. Check level of recursion and bail out if necessary.
31455 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31457 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31458 Export standard methods that we expect for string operations.
31460 * statement.cs (Block::UsageWarning): Track usage of variables and
31461 report the errors for not used variables.
31463 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31466 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31468 * codegen.cs: remove unnneded code
31470 * expression.cs: Removed BuiltinTypeAccess class
31472 Fix the order in which implicit conversions are
31475 The previous fixed dropped support for boxed conversions (adding a
31476 test to the test suite now)
31478 (UserImplicitCast::CanConvert): Remove test for source being null,
31479 that code is broken. We should not feed a null to begin with, if
31480 we do, then we should track the bug where the problem originates
31481 and not try to cover it up here.
31483 Return a resolved expression of type UserImplicitCast on success
31484 rather than true/false. Ravi: this is what I was talking about,
31485 the pattern is to use a static method as a "constructor" for
31488 Also, do not create arguments until the very last minute,
31489 otherwise we always create the arguments even for lookups that
31490 will never be performed.
31492 (UserImplicitCast::Resolve): Eliminate, objects of type
31493 UserImplicitCast are born in a fully resolved state.
31495 * typemanager.cs (InitCoreTypes): Init also value_type
31496 (System.ValueType).
31498 * expression.cs (Cast::Resolve): First resolve the child expression.
31500 (LValue): Add new method AddressOf to be used by
31503 Change the argument of Store to take an EmitContext instead of an
31504 ILGenerator, because things like FieldExpr need to be able to call
31505 their children expression to generate the instance code.
31507 (Expression::Error, Expression::Warning): Sugar functions for
31510 (Expression::MemberLookup): Accept a TypeContainer instead of a
31511 Report as the first argument.
31513 (Expression::ResolvePrimary): Killed. I still want to improve
31514 this as currently the code is just not right.
31516 (Expression::ResolveMemberAccess): Simplify, but it is still
31519 (Unary::Resolve): Catch errors in AddressOf operators.
31521 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31522 index to a byte for the short-version, or the compiler will choose
31523 the wrong Emit call, which generates the wrong data.
31525 (ParameterReference::Emit, ::Store): same.
31527 (FieldExpr::AddressOf): Implement.
31529 * typemanager.cs: TypeManager: made public variable instead of
31532 * driver.cs: document --fatal.
31534 * report.cs (ErrorMessage, WarningMessage): new names for the old
31535 Error and Warning classes.
31537 * cs-parser.jay (member_access): Turn built-in access to types
31538 into a normal simplename
31540 2001-09-27 Ravi Pratap <ravi@ximian.com>
31542 * expression.cs (Invocation::BetterConversion): Fix to cope
31543 with q being null, since this was introducing a bug.
31545 * expression.cs (ConvertImplicit): Do built-in conversions first.
31547 2001-09-27 Ravi Pratap <ravi@ximian.com>
31549 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31551 2001-09-27 Ravi Pratap <ravi@ximian.com>
31553 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31554 I had introduced long ago (what's new ?).
31556 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31557 the work of all the checking.
31558 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31559 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31561 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31562 that is the right way.
31564 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31565 overloading resolution. Use everywhere instead of cutting and pasting code.
31567 (Binary::ResolveOperator): Use MakeUnionSet.
31569 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31570 we have to convert to bool types. Not complete yet.
31572 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31574 * typemanager.cs (TypeManager::CSharpName): support ushort.
31576 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31577 to provide an expression that performsn an implicit constant int
31578 conversion (section 6.1.6).
31579 (Expression::ConvertImplicitRequired): Reworked to include
31580 implicit constant expression conversions.
31582 (Expression::ConvertNumericExplicit): Finished.
31584 (Invocation::Emit): If InstanceExpression is null, then it means
31585 that we perform a call on this.
31587 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31589 * expression.cs (Unary::Emit): Remove some dead code.
31590 (Probe): Implement Resolve and Emit for `is'.
31591 (Expression::ConvertImplicitRequired): Attempt to do constant
31592 expression conversions here. Maybe should be moved to
31593 ConvertImplicit, but I am not sure.
31594 (Expression::ImplicitLongConstantConversionPossible,
31595 Expression::ImplicitIntConstantConversionPossible): New functions
31596 that tell whether is it possible to apply an implicit constant
31597 expression conversion.
31599 (ConvertNumericExplicit): Started work on explicit numeric
31602 * cs-parser.jay: Update operator constants.
31604 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31605 (Parameters::GetSignature): Hook up VerifyArgs here.
31606 (Parameters::VerifyArgs): Verifies that no two arguments have the
31609 * class.cs (Operator): Update the operator names to reflect the
31610 ones that the spec expects (as we are just stringizing the
31613 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31614 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31615 previous usage did only work for our methods.
31616 (Expression::ConvertImplicit): Handle decimal implicit numeric
31617 conversions as well.
31618 (Expression::InternalTypeConstructor): Used to invoke constructors
31619 on internal types for default promotions.
31621 (Unary::Emit): Implement special handling for the pre/post
31622 increment/decrement for overloaded operators, as they need to have
31623 the same semantics as the other operators.
31625 (Binary::ResolveOperator): ditto.
31626 (Invocation::ConversionExists): ditto.
31627 (UserImplicitCast::Resolve): ditto.
31629 2001-09-26 Ravi Pratap <ravi@ximian.com>
31631 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31632 operator, return after emitting body. Regression tests pass again !
31634 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31635 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31636 (Invocation::OverloadResolve): Ditto.
31637 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31639 * everywhere : update calls to the above methods accordingly.
31641 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31643 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31645 * expression.cs (ExpressionStatement): New base class used for
31646 expressions that can appear in statements, so that we can provide
31647 an alternate path to generate expression that do not leave a value
31650 (Expression::Emit, and all the derivatives): We no longer return
31651 whether a value is left on the stack or not. Every expression
31652 after being emitted leaves a single value on the stack.
31654 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31655 facilties of ExpressionStatement if possible.
31657 * cs-parser.jay: Update statement_expression.
31659 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31661 * driver.cs: Change the wording of message
31663 2001-09-25 Ravi Pratap <ravi@ximian.com>
31665 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31666 the type of the expression to the return type of the method if
31667 we have an overloaded operator match ! The regression tests pass again !
31668 (Unary::ResolveOperator): Ditto.
31670 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31671 to find "op_Implicit", not "implicit" ;-)
31672 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31673 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31675 * everywhere : Correct calls to the above accordingly.
31677 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31678 (ConvertImplicit): Do user-defined conversion if it exists.
31680 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31682 * assign.cs: track location.
31683 (Resolve): Use implicit conversions on assignment.
31685 * literal.cs: Oops. Not good, Emit of short access values should
31686 pass (Bytes) or the wrong argument will be selected.
31688 * expression.cs (Unary::Emit): Emit code for -expr.
31690 (Unary::ResolveOperator): Handle `Substract' for non-constants
31691 (substract from zero from the non-constants).
31692 Deal with Doubles as well.
31694 (Expression::ConvertImplicitRequired): New routine that reports an
31695 error if no implicit conversion exists.
31697 (Invocation::OverloadResolve): Store the converted implicit
31698 expressions if we make them
31700 2001-09-24 Ravi Pratap <ravi@ximian.com>
31702 * class.cs (ConstructorInitializer): Take a Location argument.
31703 (ConstructorBaseInitializer): Same here.
31704 (ConstructorThisInitializer): Same here.
31706 * cs-parser.jay : Update all calls accordingly.
31708 * expression.cs (Unary, Binary, New): Take location argument.
31709 Update accordingly everywhere.
31711 * cs-parser.jay : Update all calls to the above to take a location
31714 * class.cs : Ditto.
31716 2001-09-24 Ravi Pratap <ravi@ximian.com>
31718 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31719 (Invocation::BetterConversion): Same here
31720 (Invocation::ConversionExists): Ditto.
31722 (Invocation::ConversionExists): Implement.
31724 2001-09-22 Ravi Pratap <ravi@ximian.com>
31726 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31727 Also take an additional TypeContainer argument.
31729 * All over : Pass in TypeContainer as argument to OverloadResolve.
31731 * typemanager.cs (CSharpName): Update to check for the string type and return
31734 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31737 2001-09-21 Ravi Pratap <ravi@ximian.com>
31739 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31740 (Invocation::BetterFunction): Implement.
31741 (Invocation::BetterConversion): Implement.
31742 (Invocation::ConversionExists): Skeleton, no implementation yet.
31744 Okay, things work fine !
31746 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31748 * typemanager.cs: declare and load enum_type, delegate_type and
31751 * expression.cs (Expression::Emit): Now emit returns a value that
31752 tells whether a value is left on the stack or not. This strategy
31753 might be reveted tomorrow with a mechanism that would address
31754 multiple assignments.
31755 (Expression::report118): Utility routine to report mismatches on
31758 (Unary::Report23): Report impossible type/operator combination
31761 (Unary::IsIncrementableNumber): Whether the type can be
31762 incremented or decremented with add.
31763 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31765 (Unary::ResolveOperator): Implement ++, !, ~,
31767 (Invocation::Emit): Deal with new Emit convetion.
31769 * All Expression derivatives: Updated their Emit method to return
31770 whether they leave values on the stack or not.
31772 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31773 stack for expressions that are statements.
31775 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31777 * expression.cs (LValue): New interface. Must be implemented by
31779 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31782 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31783 interface for generating code, simplifies the code.
31785 2001-09-20 Ravi Pratap <ravi@ximian.com>
31787 * expression.cs (everywhere): Comment out return statements in ::Resolve
31788 methods to avoid the warnings.
31790 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31792 * driver.cs (parse): Report error 2001 if we can not open the
31795 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31798 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31801 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31802 otherwise nested blocks end up with the same index.
31804 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31806 * expression.cs: Instead of having FIXMEs in the Resolve
31807 functions, throw exceptions so it is obvious that we are facing a
31810 * cs-parser.jay (invocation_expression): Pass Location information.
31812 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31813 Use a basename for those routines because .NET does not like paths
31816 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31819 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31821 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31822 are loading the correct data types (throws an exception if not).
31823 (TypeManager::InitCoreTypes): Use CoreLookupType
31825 * expression.cs (Unary::ResolveOperator): return the child
31826 expression for expressions which are just +expr.
31827 (Unary::ResolveOperator): Return negative literals for -LITERAL
31828 expressions (otherwise they are Unary {Literal}).
31829 (Invocation::Badness): Take into account `Implicit constant
31830 expression conversions'.
31832 * literal.cs (LongLiteral): Implement long literal class.
31833 (IntLiteral): export the `Value' of the intliteral.
31835 2001-09-19 Ravi Pratap <ravi@ximian.com>
31837 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31839 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31840 instead of 'Operator'
31842 * expression.cs (Binary::ResolveOperator): Update accordingly.
31843 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31846 * cs-parser.jay (unary_expression): Update to use the new names.
31848 * gen-treedump.cs (GetUnary): Same here.
31850 * expression.cs (Unary::Resolve): Implement.
31851 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31852 operators are found instead of making noise ;-)
31853 (Unary::ResolveOperator): New method to do precisely the same thing which
31854 Binary::ResolveOperator does for Binary expressions.
31855 (Unary.method, .Arguments): Add.
31856 (Unary::OperName): Implement.
31857 (Unary::ForceConversion): Copy and Paste !
31859 * class.cs (Operator::Define): Fix a small bug for the case when we have
31862 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31863 for the inbuilt operators. Only overloading works for now ;-)
31865 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31867 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31868 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31870 * expression.cs (This::Emit): Implement.
31871 (This::Resolve): Implement.
31872 (TypeOf:Resolve): Implement.
31873 (Expression::ResolveSimpleName): Add an implicit this to instance
31875 (MemberAccess::Resolve): Deal with Parameters and Fields.
31876 Bind instance variable to Field expressions.
31877 (FieldExpr::Instance): New field used to track the expression that
31878 represents the object instance.
31879 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31881 (FieldExpr::Emit): Implement.
31883 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31884 the last instruction contains a return opcode to avoid generating
31885 the last `ret' instruction (this generates correct code, and it is
31886 nice to pass the peverify output).
31888 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31889 initializer for static and instance variables.
31890 (Constructor::Emit): Allow initializer to be null in the case of
31891 static constructors. Only emit initializer for instance
31894 (TypeContainer::FindMembers): Return a null array if there are no
31897 Also fix the code for the MemberTypes.Method branch, as it was not
31898 scanning that for operators (or tried to access null variables before).
31900 * assign.cs (Assign::Emit): Handle instance and static fields.
31904 * driver.cs: Stop compilation if there are parse errors.
31906 * cs-parser.jay (constructor_declaration): Provide default base
31907 initializer for non-static constructors.
31908 (constructor_declarator): Do not provide a default base
31909 initializers if none was specified.
31910 Catch the fact that constructors should not have parameters.
31912 * class.cs: Do not emit parent class initializers for static
31913 constructors, that should be flagged as an error.
31915 2001-09-18 Ravi Pratap <ravi@ximian.com>
31917 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31918 Move back code into TypeContainer::Populate.
31920 2001-09-18 Ravi Pratap <ravi@ximian.com>
31922 * class.cs (TypeContainer::AddConstructor): Fix the check to
31923 compare against Name, not Basename.
31924 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31926 * cs-parser.jay : Update accordingly.
31928 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31929 for methods, don't forget to look into the operators too.
31930 (RegisterMethodBuilder): Helper method to take care of this for
31931 methods, constructors and operators.
31932 (Operator::Define): Completely revamp.
31933 (Operator.OperatorMethod, MethodName): New fields.
31934 (TypeContainer::Populate): Move the registering of builders into
31935 RegisterMethodBuilder.
31936 (Operator::Emit): Re-write.
31938 * expression.cs (Binary::Emit): Comment out code path to emit method
31939 invocation stuff for the case when we have a user defined operator. I am
31940 just not able to get it right !
31942 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31944 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31947 (Expression::MemberLookup): Provide a version that allows to
31948 specify the MemberTypes and BindingFlags.
31950 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31951 so it was not fetching variable information from outer blocks.
31953 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31954 Beforefieldinit as it was buggy.
31956 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31957 that Ravi put here.
31959 * class.cs (Constructor::Emit): Only emit if block is not null.
31960 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31961 deal with this by semantically definining it as if the user had
31964 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31965 constructors as we now "emit" them at a higher level.
31967 (TypeContainer::DefineDefaultConstructor): Used to define the
31968 default constructors if none was provided.
31970 (ConstructorInitializer): Add methods Resolve and Emit.
31972 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31974 2001-09-17 Ravi Pratap <ravi@ximian.com>
31976 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31977 the default constructor builder with our hashtable for methodbuilders
31980 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31981 and argument_count is 0 in which case we have a match.
31982 (Binary::ResolveOperator): More null checking and miscellaneous coding
31985 2001-09-17 Ravi Pratap <ravi@ximian.com>
31987 * rootcontext.cs (IsNameSpace): Compare against null.
31989 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31991 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31992 and Unary::Operator.
31994 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31997 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31998 we have overloaded operators.
31999 (Binary::ResolveOperator): Implement the part which does the operator overload
32002 * class.cs (Operator::Emit): Implement.
32003 (TypeContainer::Emit): Emit the operators we have too.
32005 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32006 the case when we have a user-defined operator.
32008 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32010 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32012 2001-09-16 Ravi Pratap <ravi@ximian.com>
32014 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32015 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32016 (Constructor::Emit): Implement.
32017 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32018 if we have no work to do.
32019 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32022 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32023 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32025 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32028 2001-09-15 Ravi Pratap <ravi@ximian.com>
32030 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32032 (Tree::RecordNamespace): Method to do what the name says ;-)
32033 (Tree::Namespaces): Property to get at the namespaces hashtable.
32035 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32038 * rootcontext.cs (IsNamespace): Fixed it :-)
32040 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32042 * class.cs (TypeContainer::FindMembers): Add support for
32044 (MethodCore): New class that encapsulates both the shared aspects
32045 of a Constructor and a Method.
32046 (Method, Constructor): Factored pieces into MethodCore.
32048 * driver.cs: Added --fatal which makes errors throw exceptions.
32049 Load System assembly as well as part of the standard library.
32051 * report.cs: Allow throwing exceptions on errors for debugging.
32053 * modifiers.cs: Do not use `parent', instead use the real type
32054 container to evaluate permission settings.
32056 * class.cs: Put Ravi's patch back in. He is right, and we will
32057 have to cope with the
32059 2001-09-14 Ravi Pratap <ravi@ximian.com>
32061 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32062 FamORAssem, not FamANDAssem.
32064 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32066 * driver.cs: Added --parse option that only parses its input files
32069 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32070 incorrect. IsTopLevel is not used to tell whether an object is
32071 root_types or not (that can be achieved by testing this ==
32072 root_types). But to see if this is a top-level *class* (not
32073 necessarly our "toplevel" container).
32075 2001-09-14 Ravi Pratap <ravi@ximian.com>
32077 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32078 parent instead of a direct call to GetType.
32080 2001-09-14 Ravi Pratap <ravi@ximian.com>
32082 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32083 Modifiers.TypeAttr. This should just be a call to that method.
32085 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32086 object so that we can determine if we are top-level or not.
32088 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32091 * enum.cs (Enum::Define): Ditto.
32093 * modifiers.cs (FieldAttr): Re-write.
32095 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32096 (TypeContainer::HaveStaticConstructor): New property to provide access
32097 to precisely that info.
32099 * modifiers.cs (MethodAttr): Re-write.
32100 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32102 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32103 of top-level types as claimed.
32105 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32107 * expression.cs (MemberLookup): Fruitless attempt to lookup
32108 constructors. Maybe I need to emit default constructors? That
32109 might be it (currently .NET emits this for me automatically).
32110 (Invocation::OverloadResolve): Cope with Arguments == null.
32111 (Invocation::EmitArguments): new function, shared by the new
32112 constructor and us.
32113 (Invocation::Emit): Handle static and instance methods. Emit
32114 proper call instruction for virtual or non-virtual invocations.
32115 (New::Emit): Implement.
32116 (New::Resolve): Implement.
32117 (MemberAccess:Resolve): Implement.
32118 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32119 to track instances.
32120 (FieldExpr::Resolve): Set type.
32122 * support.cs: Handle empty arguments.
32124 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32125 SimpleLookup): Auxiliary routines to help parse a qualifier
32128 Update qualifier_identifier rule.
32130 * codegen.cs: Removed debugging messages.
32132 * class.cs: Make this a global thing, this acts just as a "key" to
32133 objects that we might have around.
32135 (Populate): Only initialize method_builders_to_methods once.
32137 * expression.cs (PropertyExpr): Initialize type from the
32140 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32141 Resolve pattern. Attempt to implicitly convert value to boolean.
32144 * expression.cs: Set the type for the int32/int32 argument case.
32145 (Binary::ResolveOperator): Set the return type to boolean for
32146 comparission operators
32148 * typemanager.cs: Remove debugging print code.
32150 (Invocation::Resolve): resolve type.
32152 * class.cs: Allocate a MemberInfo of the correct size, as the code
32153 elsewhere depends on the test to reflect the correct contents.
32155 (Method::) Keep track of parameters, due to System.Reflection holes
32157 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32160 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32161 of the exact size and return that.
32163 (Class::LookupMethodByBuilder): New function that maps
32164 MethodBuilders to its methods. Required to locate the information
32165 on methods because System.Reflection bit us again.
32167 * support.cs: New file, contains an interface ParameterData and
32168 two implementations: ReflectionParameters and InternalParameters
32169 used to access Parameter information. We will need to grow this
32172 * expression.cs (Invocation::GetParameterData): implement a cache
32173 and a wrapper around the ParameterData creation for methods.
32174 (Invocation::OverloadResolve): Use new code.
32176 2001-09-13 Ravi Pratap <ravi@ximian.com>
32178 * class.cs (TypeContainer::EmitField): Remove and move into
32179 (Field::Define): here and modify accordingly.
32180 (Field.FieldBuilder): New member.
32181 (TypeContainer::Populate): Update accordingly.
32182 (TypeContainer::FindMembers): Implement.
32184 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32186 * statement.cs: (VariableInfo::VariableType): New field to be
32187 initialized with the full type once it is resolved.
32189 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32191 * parameter.cs (GetParameterInfo): Use a type cache to compute
32192 things only once, and to reuse this information
32194 * expression.cs (LocalVariableReference::Emit): Implement.
32195 (OpcodeCast::Emit): fix.
32197 (ParameterReference::Resolve): Implement.
32198 (ParameterReference::Emit): Implement.
32200 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32201 that are expressions need to stay as Expressions.
32203 * typemanager.cs (CSharpName): Returns the C# name of a type if
32206 * expression.cs (Expression::ConvertImplicit): New function that
32207 implements implicit type conversions.
32209 (Expression::ImplicitReferenceConversion): Implements implicit
32210 reference conversions.
32212 (EmptyCast): New type for transparent casts.
32214 (OpcodeCast): New type for casts of types that are performed with
32215 a sequence of bytecodes.
32217 (BoxedCast): New type used for casting value types into reference
32218 types. Emits a box opcode.
32220 (Binary::DoNumericPromotions): Implements numeric promotions of
32221 and computation of the Binary::Type.
32223 (Binary::EmitBranchable): Optimization.
32225 (Binary::Emit): Implement code emission for expressions.
32227 * typemanager.cs (TypeManager): Added two new core types: sbyte
32230 2001-09-12 Ravi Pratap <ravi@ximian.com>
32232 * class.cs (TypeContainer::FindMembers): Method which does exactly
32233 what Type.FindMembers does, only we don't have to use reflection. No
32234 implementation yet.
32236 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32237 typecontainer objects as we need to get at them.
32238 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32240 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32241 typecontainer object.
32243 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32244 of just a Report object.
32246 2001-09-11 Ravi Pratap <ravi@ximian.com>
32248 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32250 (TypeContainer::Populate): Now define the delegates of the type too.
32251 (TypeContainer.Delegates): Property to access the list of delegates defined
32254 * delegates.cs (Delegate::Define): Implement partially.
32256 * modifiers.cs (TypeAttr): Handle more flags.
32258 2001-09-11 Ravi Pratap <ravi@ximian.com>
32260 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32262 (Operator::Define): Re-write logic to get types by using the LookupType method
32263 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32264 (Indexer::Define): Ditto.
32265 (Event::Define): Ditto.
32266 (Property::Define): Ditto.
32268 2001-09-10 Ravi Pratap <ravi@ximian.com>
32270 * class.cs (TypeContainer::Populate): Now define operators too.
32271 (TypeContainer.Operators): New property to access the list of operators
32273 (Operator.OperatorMethodBuilder): New member to hold the method builder
32274 for the operator we are defining.
32275 (Operator::Define): Implement.
32277 2001-09-10 Ravi Pratap <ravi@ximian.com>
32279 * class.cs (Event::Define): Make the prefixes of the accessor methods
32280 addOn_ and removeOn_
32282 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32283 of the location being passed in too. Ideally, this should go later since all
32284 error reporting should be done through the Report object.
32286 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32287 (Populate): Iterate thru the indexers we have and define them too.
32288 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32289 for the get and set accessors.
32290 (Indexer::Define): Implement.
32292 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32294 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32295 my previous implementation, did not work.
32297 * typemanager.cs: Add a couple of missing types (the longs).
32299 * literal.cs: Use TypeManager.bool_type instead of getting it.
32301 * expression.cs (EventExpr): New kind of expressions.
32302 (Expressio::ExprClassFromMemberInfo): finish
32304 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32306 * assign.cs: Emit stores to static fields differently.
32308 2001-09-08 Ravi Pratap <ravi@ximian.com>
32310 * Merge in changes and adjust code to tackle conflicts. Backed out my
32311 code in Assign::Resolve ;-)
32313 2001-09-08 Ravi Pratap <ravi@ximian.com>
32315 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32316 instead Report.Error and also pass in the location.
32317 (CSharpParser::Lexer): New readonly property to return the reference
32318 to the Tokenizer object.
32319 (declare_local_variables): Use Report.Error with location instead of plain
32323 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32324 (Operator.CheckBinaryOperator): Ditto.
32326 * cs-parser.jay (operator_declarator): Update accordingly.
32328 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32329 (CheckBinaryOperator): Same here.
32331 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32332 on the name without any prefixes of namespace names etc. This is because we
32333 already might have something already fully qualified like
32334 'System.Console.WriteLine'
32336 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32338 2001-09-07 Ravi Pratap <ravi@ximian.com>
32340 * cs-tokenizer.cs (location): Return a string which also contains
32343 * expression.cs (ElementAccess): New class for expressions of the
32344 type 'element access.'
32345 (BaseAccess): New class for expressions of the type 'base access.'
32346 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32349 * cs-parser.jay (element_access): Implement action.
32350 (base_access): Implement actions.
32351 (checked_expression, unchecked_expression): Implement.
32353 * cs-parser.jay (local_variable_type): Correct and implement.
32354 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32356 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32358 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32359 name and the specifiers.
32361 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32363 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32364 making them all public ;-)
32366 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32369 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32371 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32373 (FieldExpr, PropertyExprs): New resolved expressions.
32374 (SimpleName::MemberStaticCheck): Perform static checks for access
32375 to non-static fields on static methods. Maybe this should be
32376 generalized for MemberAccesses.
32377 (SimpleName::ResolveSimpleName): More work on simple name
32380 * cs-parser.jay (primary_expression/qualified_identifier): track
32381 the parameter index.
32383 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32384 (EmitContext::EmitBoolExpression): Chain to expression generation
32385 instead of temporary hack.
32386 (::EmitStatementExpression): Put generic expression code generation.
32388 * assign.cs (Assign::Emit): Implement variable assignments to
32389 local variables, parameters and fields.
32391 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32393 * statement.cs (Block::GetVariableInfo): New method, returns the
32394 VariableInfo for a variable name in a block.
32395 (Block::GetVariableType): Implement in terms of GetVariableInfo
32397 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32398 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32400 2001-09-06 Ravi Pratap <ravi@ximian.com>
32402 * cs-parser.jay (operator_declaration): Continue on my quest : update
32403 to take attributes argument.
32404 (event_declaration): Ditto.
32405 (enum_declaration): Ditto.
32406 (indexer_declaration): Ditto.
32408 * class.cs (Operator::Operator): Update constructor accordingly.
32409 (Event::Event): Ditto.
32411 * delegate.cs (Delegate::Delegate): Same here.
32413 * enum.cs (Enum::Enum): Same here.
32415 2001-09-05 Ravi Pratap <ravi@ximian.com>
32417 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32419 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32421 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32422 being passed around as an arraylist.
32423 (Attributes::AddAttribute): Method to add attribute sections.
32425 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32426 (struct_declaration): Update accordingly.
32427 (constant_declaration): Update.
32428 (field_declaration): Update.
32429 (method_header): Update.
32430 (fixed_parameter): Update.
32431 (parameter_array): Ditto.
32432 (property_declaration): Ditto.
32433 (destructor_declaration): Ditto.
32435 * class.cs (Struct::Struct): Update constructors accordingly.
32436 (Class::Class): Ditto.
32437 (Field::Field): Ditto.
32438 (Method::Method): Ditto.
32439 (Property::Property): Ditto.
32440 (TypeContainer::OptAttribute): update property's return type.
32442 * interface.cs (Interface.opt_attributes): New member.
32443 (Interface::Interface): Update to take the extra Attributes argument.
32445 * parameter.cs (Parameter::Parameter): Ditto.
32447 * constant.cs (Constant::Constant): Ditto.
32449 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32450 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32451 the attributes as a parameter.
32452 (InterfaceProperty): Update constructor call.
32453 (InterfaceEvent): Ditto.
32454 (InterfaceMethod): Ditto.
32455 (InterfaceIndexer): Ditto.
32457 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32458 pass the attributes too.
32459 (interface_event_declaration): Ditto.
32460 (interface_property_declaration): Ditto.
32461 (interface_method_declaration): Ditto.
32462 (interface_declaration): Ditto.
32464 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32466 * class.cs (Method::Define): Track the "static Main" definition to
32467 create an entry point.
32469 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32470 EntryPoint if we find it.
32472 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32473 (EmitContext::ig): Make this variable public.
32475 * driver.cs: Make the default output file be the first file name
32476 with the .exe extension.
32478 Detect empty compilations
32480 Handle various kinds of output targets. Handle --target and
32481 rename -t to --dumper.
32483 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32484 methods inherited from Expression return now an Expression. This
32485 will is used during the tree rewriting as we resolve them during
32488 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32489 the spec. Missing entirely is the information about
32490 accessability of elements of it.
32492 (Expression::ExprClassFromMemberInfo): New constructor for
32493 Expressions that creates a fully initialized Expression based on
32494 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32497 (Invocation::Resolve): Begin implementing resolution of invocations.
32499 * literal.cs (StringLiteral): Implement Emit.
32501 2001-09-05 Ravi Pratap <ravi@ximian.com>
32503 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32506 2001-09-04 Ravi Pratap <ravi@ximian.com>
32508 * cs-parser.jay (attribute_arguments): Implement actions.
32509 (attribute): Fix bug in production. Implement action.
32510 (attribute_list): Implement.
32511 (attribute_target): Implement.
32512 (attribute_target_specifier, opt_target_specifier): Implement
32513 (CheckAttributeTarget): New method to check if the attribute target
32515 (attribute_section): Implement.
32516 (opt_attributes): Implement.
32518 * attribute.cs : New file to handle attributes.
32519 (Attribute): Class to hold attribute info.
32521 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32522 (attribute_section): Modify production to use 2 different rules to
32523 achieve the same thing. 1 s/r conflict down !
32524 Clean out commented, useless, non-reducing dimension_separator rules.
32526 * class.cs (TypeContainer.attributes): New member to hold list
32527 of attributes for a type.
32528 (Struct::Struct): Modify to take one more argument, the attribute list.
32529 (Class::Class): Ditto.
32530 (Field::Field): Ditto.
32531 (Method::Method): Ditto.
32532 (Property::Property): Ditto.
32534 * cs-parser.jay (struct_declaration): Update constructor call to
32535 pass in the attributes too.
32536 (class_declaration): Ditto.
32537 (constant_declaration): Ditto.
32538 (field_declaration): Ditto.
32539 (method_header): Ditto.
32540 (fixed_parameter): Ditto.
32541 (parameter_array): Ditto.
32542 (property_declaration): Ditto.
32544 * constant.cs (Constant::Constant): Update constructor similarly.
32545 Use System.Collections.
32547 * parameter.cs (Parameter::Parameter): Update as above.
32549 2001-09-02 Ravi Pratap <ravi@ximian.com>
32551 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32552 (TypeContainer.delegates): New member to hold list of delegates.
32554 * cs-parser.jay (delegate_declaration): Implement the action correctly
32555 this time as I seem to be on crack ;-)
32557 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32559 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32560 tell whether an identifier represents a namespace.
32562 * expression.cs (NamespaceExpr): A namespace expression, used only
32563 temporarly during expression resolution.
32564 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32565 utility functions to resolve names on expressions.
32567 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32569 * codegen.cs: Add hook for StatementExpressions.
32571 * class.cs: Fix inverted test for static flag in methods.
32573 2001-09-02 Ravi Pratap <ravi@ximian.com>
32575 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32576 to make it coincide with MS' number.
32577 (Operator::CheckBinaryOperator): Ditto.
32579 * ../errors/errors.txt : Remove error numbers added earlier.
32581 * ../errors/cs1019.cs : Test case for error # 1019
32583 * ../errros/cs1020.cs : Test case for error # 1020
32585 * cs-parser.jay : Clean out commented cruft.
32586 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32587 used anywhere - non-reducing rule.
32588 (namespace_declarations): Non-reducing rule - comment out.
32590 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32591 with TypeContainer::AddEnum.
32593 * delegate.cs : New file for delegate handling classes.
32594 (Delegate): Class for declaring delegates.
32596 * makefile : Update.
32598 * cs-parser.jay (delegate_declaration): Implement.
32600 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32602 * class.cs (Event::Define): Implement.
32603 (Event.EventBuilder): New member.
32605 * class.cs (TypeContainer::Populate): Update to define all enums and events
32607 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32608 readonly fields for all these cases ?
32610 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32612 * class.cs (Property): Revamp to use the convention of making fields readonly.
32613 Accordingly modify code elsewhere.
32615 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32616 the Define method of the Property class.
32618 * class.cs : Clean up applied patch and update references to variables etc. Fix
32620 (TypeContainer::Populate): Update to define all the properties we have. Also
32621 define all enumerations.
32623 * enum.cs (Define): Implement.
32625 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32627 * cs-parser.jay (overloadable_operator): The semantic value is an
32628 enum of the Operator class.
32629 (operator_declarator): Implement actions.
32630 (operator_declaration): Implement.
32632 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32633 validity of definitions.
32634 (Operator::CheckBinaryOperator): Static method to check for binary operators
32635 (TypeContainer::AddOperator): New method to add an operator to a type.
32637 * cs-parser.jay (indexer_declaration): Added line to actually call the
32638 AddIndexer method so it gets added ;-)
32640 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32641 already taken care of by the MS compiler ?
32643 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32645 * class.cs (Operator): New class for operator declarations.
32646 (Operator::OpType): Enum for the various operators.
32648 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32650 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32651 ostensibly handle this in semantic analysis.
32653 * cs-parser.jay (general_catch_clause): Comment out
32654 (specific_catch_clauses, specific_catch_clause): Ditto.
32655 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32656 (catch_args, opt_catch_args): New productions.
32657 (catch_clause): Rewrite to use the new productions above
32658 (catch_clauses): Modify accordingly.
32659 (opt_catch_clauses): New production to use in try_statement
32660 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32661 and re-write the code in the actions to extract the specific and
32662 general catch clauses by being a little smart ;-)
32664 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32665 Hooray, try and catch statements parse fine !
32667 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32669 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32670 string from the hashtable of variables.
32672 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32673 I end up making that mistake ;-)
32674 (catch_clauses): Fixed gross error which made Key and Value of the
32675 DictionaryEntry the same : $1 !!
32677 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32679 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32681 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32682 when the add and remove accessors are specified.
32684 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32686 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32687 information about indexer_declarator.
32688 (indexer_declarator): Implement actions.
32689 (parsing_indexer): New local boolean used to keep track of whether
32690 we are parsing indexers or properties. This is necessary because
32691 implicit_parameters come into picture even for the get accessor in the
32692 case of an indexer.
32693 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32695 * class.cs (Indexer): New class for indexer declarations.
32696 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32697 (TypeContainer::indexers): New member to hold list of indexers for the
32700 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32702 * cs-parser.jay (add_accessor_declaration): Implement action.
32703 (remove_accessor_declaration): Implement action.
32704 (event_accessors_declaration): Implement
32705 (variable_declarators): swap statements for first rule - trivial.
32707 * class.cs (Event): New class to hold information about event
32709 (TypeContainer::AddEvent): New method to add an event to a type
32710 (TypeContainer::events): New member to hold list of events.
32712 * cs-parser.jay (event_declaration): Implement actions.
32714 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32716 * cs-parser.jay (dim_separators): Implement. Make it a string
32717 concatenating all the commas together, just as they appear.
32718 (opt_dim_separators): Modify accordingly
32719 (rank_specifiers): Update accordingly. Basically do the same
32720 thing - instead, collect the brackets here.
32721 (opt_rank_sepcifiers): Modify accordingly.
32722 (array_type): Modify to actually return the complete type string
32723 instead of ignoring the rank_specifiers.
32724 (expression_list): Implement to collect the expressions
32725 (variable_initializer): Implement. We make it a list of expressions
32726 essentially so that we can handle the array_initializer case neatly too.
32727 (variable_initializer_list): Implement.
32728 (array_initializer): Make it a list of variable_initializers
32729 (opt_array_initializer): Modify accordingly.
32731 * expression.cs (New::NType): Add enumeration to help us
32732 keep track of whether we have an object/delegate creation
32733 or an array creation.
32734 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32735 members to hold data about array creation.
32736 (New:New): Modify to update NewType
32737 (New:New): New Overloaded contructor for the array creation
32740 * cs-parser.jay (array_creation_expression): Implement to call
32741 the overloaded New constructor.
32743 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32745 * class.cs (TypeContainer::Constructors): Return member
32746 constructors instead of returning null.
32748 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32750 * typemanager.cs (InitCoreTypes): Initialize the various core
32751 types after we have populated the type manager with the user
32752 defined types (this distinction will be important later while
32753 compiling corlib.dll)
32755 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32756 on Expression Classification. Now all expressions have a method
32757 `Resolve' and a method `Emit'.
32759 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32760 generation from working. Also add some temporary debugging
32763 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32765 * codegen.cs: Lots of code generation pieces. This is only the
32766 beginning, will continue tomorrow with more touches of polish. We
32767 handle the fundamentals of if, while, do, for, return. Others are
32768 trickier and I need to start working on invocations soon.
32770 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32773 * codegen.cs (EmitContext): New struct, used during code
32774 emission to keep a context. Most of the code generation will be
32777 * cs-parser.jay: Add embedded blocks to the list of statements of
32778 this block. So code generation proceeds in a top down fashion.
32780 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32782 * statement.cs: Add support for multiple child blocks.
32784 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32786 * codegen.cs (EmitCode): New function, will emit the code for a
32787 Block of code given a TypeContainer and its ILGenerator.
32789 * statement.cs (Block): Standard public readonly optimization.
32790 (Block::Block constructors): Link children.
32791 (Block::Child): Child Linker.
32792 (Block::EmitVariables): Emits IL variable declarations.
32794 * class.cs: Drop support for MethodGroups here, delay until
32796 (Method::): Applied the same simplification that I did before, and
32797 move from Properties to public readonly fields.
32798 (Method::ParameterTypes): Returns the parameter types for the
32799 function, and implements a cache that will be useful later when I
32800 do error checking and the semantic analysis on the methods is
32802 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32803 and made a method, optional argument tells whether this is a class
32804 or a structure to apply the `has-this' bit.
32805 (Method::GetCallingConvention): Implement, returns the calling
32807 (Method::Define): Defines the type, a second pass is performed
32808 later to populate the methods.
32810 (Constructor::ParameterTypes): implement a cache similar to the
32811 one on Method::ParameterTypes, useful later when we do semantic
32814 (TypeContainer::EmitMethod): New method. Emits methods.
32816 * expression.cs: Removed MethodGroup class from here.
32818 * parameter.cs (Parameters::GetCallingConvention): new method.
32820 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32822 * class.cs (TypeContainer::Populate): Drop RootContext from the
32825 (Constructor::CallingConvention): Returns the calling convention.
32826 (Constructor::ParameterTypes): Returns the constructor parameter
32829 (TypeContainer::AddConstructor): Keep track of default constructor
32830 and the default static constructor.
32832 (Constructor::) Another class that starts using `public readonly'
32833 instead of properties.
32835 (Constructor::IsDefault): Whether this is a default constructor.
32837 (Field::) use readonly public fields instead of properties also.
32839 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32840 track of static constructors; If none is used, turn on
32841 BeforeFieldInit in the TypeAttributes.
32843 * cs-parser.jay (opt_argument_list): now the return can be null
32844 for the cases where there are no arguments.
32846 (constructor_declarator): If there is no implicit `base' or
32847 `this', then invoke the default parent constructor.
32849 * modifiers.cs (MethodAttr): New static function maps a set of
32850 modifiers flags into a MethodAttributes enum
32851 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32852 MethodAttr, TypeAttr to represent the various mappings where the
32853 modifiers are used.
32854 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32856 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32858 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32861 * interface.cs (PopulateIndexer): Implemented the code generator
32862 for interface indexers.
32864 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32866 * interface.cs (InterfaceMemberBase): Now we track the new status
32869 (PopulateProperty): Implement property population. Woohoo! Got
32870 Methods and Properties going today.
32872 Removed all the properties for interfaces, and replaced them with
32873 `public readonly' fields.
32875 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32877 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32878 initialize their hashtables/arraylists only when they are needed
32879 instead of doing this always.
32881 * parameter.cs: Handle refs and out parameters.
32883 * cs-parser.jay: Use an ArrayList to construct the arguments
32884 instead of the ParameterCollection, and then cast that to a
32887 * parameter.cs: Drop the use of ParameterCollection and use
32888 instead arrays of Parameters.
32890 (GetParameterInfo): Use the Type, not the Name when resolving
32893 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32895 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32896 and instead use public readonly fields.
32898 * class.cs: Put back walking code for type containers.
32900 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32902 * class.cs (MakeConstant): Code to define constants.
32904 * rootcontext.cs (LookupType): New function. Used to locate types
32907 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32909 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32910 this System.Reflection code is. Kudos to Microsoft
32912 * typemanager.cs: Implement a type cache and avoid loading all
32913 types at boot time. Wrap in LookupType the internals. This made
32914 the compiler so much faster. Wow. I rule!
32916 * driver.cs: Make sure we always load mscorlib first (for
32917 debugging purposes, nothing really important).
32919 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32920 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32922 * rootcontext.cs: Lookup types on their namespace; Lookup types
32923 on namespaces that have been imported using the `using' keyword.
32925 * class.cs (TypeContainer::TypeAttr): Virtualize.
32926 (Class::TypeAttr): Return attributes suitable for this bad boy.
32927 (Struct::TypeAttr): ditto.
32928 Handle nested classes.
32929 (TypeContainer::) Remove all the type visiting code, it is now
32930 replaced with the rootcontext.cs code
32932 * rootcontext.cs (GetClassBases): Added support for structs.
32934 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32936 * interface.cs, statement.cs, class.cs, parameter.cs,
32937 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32938 Drop use of TypeRefs, and use strings instead.
32940 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32944 * class.cs (Struct::Struct): set the SEALED flags after
32945 checking the modifiers.
32946 (TypeContainer::TypeAttr): new property, returns the
32947 TypeAttributes for a class.
32949 * cs-parser.jay (type_list): Oops, list production was creating a
32950 new list of base types.
32952 * rootcontext.cs (StdLib): New property.
32953 (GetInterfaceTypeByName): returns an interface by type name, and
32954 encapsulates error handling here.
32955 (GetInterfaces): simplified.
32956 (ResolveTree): Encapsulated all the tree resolution here.
32957 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32960 * driver.cs: Add support for --nostdlib, to avoid loading the
32961 default assemblies.
32962 (Main): Do not put tree resolution here.
32964 * rootcontext.cs: Beginning of the class resolution.
32966 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32968 * rootcontext.cs: Provide better error reporting.
32970 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32972 * rootcontext.cs (CreateInterface): Handle the case where there
32973 are no parent interfaces.
32975 (CloseTypes): Routine to flush types at the end.
32976 (CreateInterface): Track types.
32977 (GetInterfaces): Returns an array of Types from the list of
32978 defined interfaces.
32980 * typemanager.c (AddUserType): Mechanism to track user types (puts
32981 the type on the global type hash, and allows us to close it at the
32984 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32986 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32987 RecordInterface instead.
32989 * cs-parser.jay: Updated to reflect changes above.
32991 * decl.cs (Definition): Keep track of the TypeBuilder type that
32992 represents this type here. Not sure we will use it in the long
32993 run, but wont hurt for now.
32995 * driver.cs: Smaller changes to accomodate the new code.
32997 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33000 * rootcontext.cs (CreateInterface): New method, used to create
33001 the System.TypeBuilder type for interfaces.
33002 (ResolveInterfaces): new entry point to resolve the interface
33004 (CodeGen): Property, used to keep track of the code generator.
33006 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33008 * cs-parser.jay: Add a second production for delegate_declaration
33011 (enum_body): Put an opt_comma here instead of putting it on
33012 enum_body or enum_member_declarations so we can handle trailing
33013 commas on enumeration members. Gets rid of a shift/reduce.
33015 (type_list): Need a COMMA in the middle.
33017 (indexer_declaration): Tell tokenizer to recognize get/set
33019 * Remove old targets.
33021 * Re-add the parser target.
33023 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33025 * cs-parser.jay: Add precendence rules for a number of operators
33026 ot reduce the number of shift/reduce conflicts in the grammar.
33028 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33030 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33033 Get rid of old crufty code.
33035 * rootcontext.cs: Use this to keep track of the parsed
33036 representation and the defined types available to the program.
33038 * gen-treedump.cs: adjust for new convention.
33040 * type.cs: Split out the type manager, and the assembly builder
33043 * typemanager.cs: the type manager will live here now.
33045 * cil-codegen.cs: And the code generator here.
33047 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33049 * makefile: Fixed up for easy making.
33051 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33053 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33056 (unary_expression): Expand pre_increment_expression and
33057 post_decrement_expression to reduce a shift/reduce.
33059 2001-07-11 Simon Cozens
33061 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33063 Improve allow_keyword_as_indent name.
33065 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33067 * Adjustments for Beta2.
33069 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33071 * decl.cs: Added `Define' abstract method.
33072 (InTransit): new property, used to catch recursive definitions.
33074 * interface.cs: Implement `Define'.
33076 * modifiers.cs: Map Modifiers.constants to
33077 System.Reflection.TypeAttribute flags.
33079 * class.cs: Keep track of types and user-defined types.
33080 (BuilderInit): New method for creating an assembly
33081 (ResolveType): New function to launch the resolution process, only
33082 used by interfaces for now.
33084 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33085 that are inserted into the name space.
33087 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33089 * ARGH. I have screwed up my tree so many times due to the use of
33090 rsync rather than using CVS. Going to fix this at once.
33092 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33095 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33097 * Experiment successful: Use System.Type rather that our own
33100 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33102 * cs-parser.jay: Removed nsAliases from here.
33104 Use new namespaces, handle `using XXX;'
33106 * namespace.cs: Reimplemented namespace handling, use a recursive
33107 definition of the class. Now we can keep track of using clauses
33108 and catch invalid using clauses.
33110 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33112 * gen-treedump.cs: Adapted for all the renaming.
33114 * expression.cs (Expression): this class now has a Type property
33115 which returns an expression Type.
33117 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33118 `Type', as this has a different meaning now in the base
33120 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33122 * interface.cs, class.cs: Removed from all the sources the
33123 references to signature computation, as we can not do method
33124 signature computation during the parsing time, as we are not
33125 trying to solve at that point distinguishing:
33129 void a (NS.Blah x) {}
33132 Which depending on the context might be valid or not, as we do not
33133 know if Blah is the same thing as NS.Blah at that point.
33135 * Redid everything so the code uses TypeRefs now instead of
33136 Types. TypeRefs are just temporary type placeholders, that need
33137 to be resolved. They initially have a pointer to a string and the
33138 current scope in which they are used. This is used later by the
33139 compiler to resolve the reference to an actual Type.
33141 * DeclSpace is no longer a CIR.Type, and neither are
33142 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33143 are all DeclSpaces, but no Types.
33145 * type.cs (TypeRefManager): This implements the TypeRef manager,
33146 which keeps track of all the types that need to be resolved after
33147 the parsing has finished.
33149 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33151 * ARGH. We are going to have to store `foreach' as a class rather
33152 than resolving it, as we need to verify error 1579 after name
33153 resolution. *OR* we could keep a flag that says `This request to
33154 IEnumerator comes from a foreach statement' which we can then use
33155 to generate the error.
33157 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33159 * class.cs (TypeContainer.AddMethod): we now add methods to the
33160 MethodGroup instead of the method hashtable.
33162 * expression.cs: Add MethodGroup abstraction, which gets us one
33163 step closer to the specification in the way we handle method
33166 * cs-parser.jay (primary_expression): qualified_identifier now
33167 tried to match up an identifier to a local variable reference or
33168 to a parameter reference.
33170 current_local_parameters is now a parser global variable that
33171 points to the current parameters for the block, used during name
33174 (property_declaration): Now creates an implicit `value' argument to
33177 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33179 * parameter.cs: Do not use `param' arguments as part of the
33180 signature, per the spec.
33182 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33184 * decl.cs: Base class for classes, structs and interfaces. This
33185 is the "Declaration Space"
33187 * cs-parser.jay: Use CheckDef for checking declaration errors
33188 instead of having one on each function.
33190 * class.cs: Factor out some code for handling error handling in
33191 accordance to the "Declarations" section in the "Basic Concepts"
33192 chapter in the ECMA C# spec.
33194 * interface.cs: Make all interface member classes derive from
33195 InterfaceMemberBase.
33197 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33199 * Many things: all interfaces are parsed and generated in
33200 gen-treedump. Support for member variables, constructors,
33201 destructors, properties, constants is there.
33203 Beginning of the IL backend, but very little done, just there for
33206 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33208 * cs-parser.jay: Fix labeled statement.
33210 * cs-tokenizer.cs (escape): Escape " and ' always.
33211 ref_line, ref_name: keep track of the line/filename as instructed
33212 by #line by the compiler.
33215 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33217 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33218 to match the values in System.CodeDOM.
33220 Divid renamed to Divide.
33222 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33224 (Statements.set): remove.
33226 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33229 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33230 falseStatements always have valid values.
33232 * cs-parser.jay: Use System.CodeDOM now.