1 2004-11-18 Marek Safar <marek.safar@seznam.cz>
4 * attribute.cs (Attributable): Removed CheckTargets.
\r
5 (Attributes.Emit): Explicit attribute targets are tested here.
\r
7 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
\r
8 not enabled for interfaces.
\r
10 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
\r
12 2004-11-18 Martin Baulig <martin@ximian.com>
14 Merged latest changes into gmcs. Please keep this comment in
15 here, it makes it easier for me to see what changed in MCS since
16 the last time I merged.
18 2004-11-17 Raja R Harinath <rharinath@novell.com>
20 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
21 (TypeHandle.GetMemberCache): New.
22 (TypeHandle.TypeHandle): Update.
23 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
24 (TypeManager.LookupParentInterfacesCache):
25 Rename from LookupInterfaceCache. Optimize slightly.
26 (TypeManager.MemberLookup_FindMembers): Update.
27 * decl.cs (MemberCache.MemberCache): Set Container to null in the
29 (AddCacheContents): Rename from AddHashtable.
30 * class.cs (TypeContainer.parent_container): Remove.
31 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
32 (TypeContainer.DoDefineMembers): Don't initialize it.
33 Update to name changes.
35 2004-11-17 Miguel de Icaza <miguel@ximian.com>
37 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
38 that factors the code to check access modifiers on override.
40 (PropertyBase): Use the code here.
42 Patch from Lluis S'anchez, fixes bug #69361.
44 2004-11-15 Miguel de Icaza <miguel@ximian.com>
46 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
47 routine that is used to report the use of a captured variable
48 whose address has been taken.
50 There are two checks: one when variables are being captured and
51 the other check is when the address of a variable is taken.
53 (because an anonymous methods might be resolved before *or* after
54 the address has been taken) and
56 * expression.cs (Conditional.DoResolve): Remove the special
57 casing that Martin added to trueExpr and falseExpr being both
58 NullLiteral. We get the right behavior now just by introducing
59 the null_type into the compiler.
61 * convert.cs (ExplicitConversion): Change the code to use
62 null_type instead of testing `expr is NullLiteral'.
63 (ImplicitConversionStandard): use null_type too.
64 (ImplicitReferenceConversionExists): use null_type too.
65 (ImplicitReferenceConversion): use null_type too.
67 * literal.cs: The type of `NullLiteral' is now null_type instead
69 (Resolve): Set the type here.
71 * typemanager.cs: Introduce null_type.
73 2004-11-17 Martin Baulig <martin@ximian.com>
75 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
76 direction, like FindMembers() does. Fixes #69546, testcase is in
79 2004-11-16 Martin Baulig <martin@ximian.com>
81 This is based on a patch from Marek Safar, see bug #69082.
82 Fixes bugs #63705 and #67130.
84 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
85 method; create a MemberCache for an interface type and cache the
88 * decl.cs (IMemberContainer.ParentContainer): Removed.
89 (IMemberContainer.ParentCache): New property.
90 (MemberCache.SetupCacheForInterface): Removed.
91 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
92 to create a cache for an interface's "parent".
94 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
97 2004-11-16 Martin Baulig <martin@ximian.com>
99 Merged back from gmcs; these changes already went into gmcs a
103 (TypeManager.AddUserType): Removed the `ifaces' argument.
104 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
106 (TypeManager.AddUserInterface): Removed.
107 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
109 (TypeManager.GetInterfaces): Likewise.
110 (TypeManager.GetExplicitInterfaces): Likewise.
112 * ecore.cs (TypeExpr.GetInterfaces): Removed.
114 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
115 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
117 2004-11-14 Ben Maurer <bmaurer@ximian.com>
119 * statement.cs: Avoid adding bools to a hashtable.
121 2004-11-07 Miguel de Icaza <miguel@ximian.com>
123 * expression.cs (Invocation.OverloadResolve): Flag error if we are
124 calling an unsafe method from a safe location.
126 2004-11-06 Marek Safar <marek.safar@seznam.cz>
129 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
131 2004-11-06 Miguel de Icaza <miguel@ximian.com>
133 * namespace.cs (VerifyUsing): use GetPartialName instead of
136 2004-11-05 Miguel de Icaza <miguel@ximian.com>
138 * statement.cs (Return.Resolve): Fix regression in typo: if
139 `in_exc', we have to request a NeedReturnLabel, this was a typo
140 introduced in the anonymous method check-in. Fixes #69131.
142 * Indexers were using the ShortName when defining themselves,
143 causing a regression in the compiler bootstrap when applying the
144 patch from 2004-11-02 (first part), now they use their full name
147 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
149 * driver.cs: Strip the path from the names of embedded resources. Fixes
152 2004-11-04 Raja R Harinath <rharinath@novell.com>
154 Fix error message regression: cs0104-2.cs.
155 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
156 (AliasEntry.Resolve): Update.
157 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
159 (RootContext.LookupType): Update.
161 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
163 * cs-parser.jay: Add support for handling accessor modifiers
164 * class: Add support port accessor modifiers and error checking,
165 define PropertyMethod.Define as virtual (not abstract anymore)
166 * ecore.cs: Add checking for proeprties access with access modifiers
167 * iterators.cs: Modify Accessor constructor call based in the modified
169 2004-11-02 Ben Maurer <bmaurer@ximian.com>
171 * expression.cs (StringConcat): Handle being called twice,
172 as when we have a concat in a field init with more than two
175 2004-11-02 Miguel de Icaza <miguel@ximian.com>
177 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
178 special case explicit implementations, we should always produce
179 the .property or .event declaration.
181 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
182 since it will not return correct data if people use this
183 unresolved in the presence of using statements (see test-313).
185 * class.cs (MethodData.Define): If we are an explicit interface
186 implementation, set the method name to the full name of the
187 interface plus the name of the method.
189 Notice that using the method.MethodName.GetFullName() does not
190 work, as it will only contain the name as declared on the source
191 file (it can be a shorthand in the presence of using statements)
192 and not the fully qualifed type name, for example:
196 class D : ICloneable {
197 object ICloneable.Clone () {
201 Would produce a method called `ICloneable.Clone' instead of
202 `System.ICloneable.Clone'.
204 * namespace.cs (Alias.Resolve): Use GetPartialName.
206 2004-11-01 Marek Safar <marek.safar@seznam.cz>
208 * cs-parser.jay: Add error 1055 report.
210 2004-11-01 Miguel de Icaza <miguel@ximian.com>
212 * assign.cs (Assign.DoResolve): Only do the transform of
213 assignment into a New if the types are compatible, if not, fall
214 through and let the implicit code deal with the errors and with
215 the necessary conversions.
217 2004-11-01 Marek Safar <marek.safar@seznam.cz>
219 * cs-parser.jay: Add error 1031 report.
221 * cs-tokenizer.cs: Add location for error 1038.
223 2004-10-31 Marek Safar <marek.safar@seznam.cz>
225 * cs-parser.jay: Add error 1016 report.
227 2004-10-31 Marek Safar <marek.safar@seznam.cz>
229 * cs-parser.jay: Add errors 1575,1611 report.
231 2004-10-31 Marek Safar <marek.safar@seznam.cz>
233 * cs-parser.jay: Add error 1001 report.
235 2004-10-31 Marek Safar <marek.safar@seznam.cz>
238 * attribute.cs (GetMarshal): Add method argument for
239 caller identification.
241 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
242 agument for GetMarshal and RuntimeMissingSupport.
244 2004-10-31 Marek Safar <marek.safar@seznam.cz>
246 * attribute.cs (ExtractSecurityPermissionSet): Removed
247 TypeManager.code_access_permission_type.
249 * typemanager.cs: Removed TypeManager.code_access_permission_type.
251 2004-10-27 Miguel de Icaza <miguel@ximian.com>
253 * expression.cs (LocalVariableReference.DoResolveLValue): Check
254 for obsolete use of a variable here. Fixes regression on errors
255 cs0619-25 and cs0619-26.
257 2004-10-27 Marek Safar <marek.safar@seznam.cz>
259 Fix #62358, implemented security attribute encoding.
261 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
262 Tests permitted SecurityAction for assembly or other types.
263 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
264 data from SecurityPermissionAttribute to PermisionSet class.
266 * class.cs (ApplyAttributeBuilder): Added special handling
267 for System.Security.Permissions.SecurityAttribute based types.
269 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
270 special handling for System.Security.Permissions.SecurityAttribute
273 * enum.cs (ApplyAttributeBuilder): Added special handling
274 for System.Security.Permissions.SecurityAttribute based types.
276 * parameter.cs (ApplyAttributeBuilder): Added special handling
277 for System.Security.Permissions.SecurityAttribute based types.
279 * rootcontext.cs: Next 2 core types.
281 * typemanager.cs (TypeManager.security_permission_attr_type):
282 Built in type for the SecurityPermission Attribute.
283 (code_access_permission_type): Build in type.
285 2004-10-17 Miguel de Icaza <miguel@ximian.com>
287 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
288 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
289 all of this information into
290 EmitContext.EmitCapturedVariableInstance.
292 * codegen.cs (EmitCapturedVariableInstance): move here the
293 funcionality of emitting an ldarg.0 in the presence of a
294 remapping. This centralizes the instance emit code.
296 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
297 then emit a load of this: it means that we have reached the
298 topmost ScopeInfo: the one that contains the pointer to the
299 instance of the class hosting the anonymous method.
301 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
302 captures to the topmost CaptureContext.
304 2004-10-12 Miguel de Icaza <miguel@ximian.com>
306 * expression.cs (LocalVariableReference): Move the knowledge about
307 the iterators into codegen's EmitCapturedVariableInstance.
309 2004-10-11 Miguel de Icaza <miguel@ximian.com>
311 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
312 all code paths return a value from an anonymous method (it is the
313 same as the 161 error, but for anonymous methods).
315 2004-10-08 Miguel de Icaza <miguel@ximian.com>
317 The introduction of anonymous methods in the compiler changed
318 various ways of doing things in the compiler. The most
319 significant one is the hard split between the resolution phase
320 and the emission phases of the compiler.
322 For instance, routines that referenced local variables no
323 longer can safely create temporary variables during the
324 resolution phase: they must do so from the emission phase,
325 since the variable might have been "captured", hence access to
326 it can not be done with the local-variable operations from the runtime.
330 (Block.Flags): New flag `IsTopLevel' to indicate that this block
333 (ToplevelBlock): A new kind of Block, these are the blocks that
334 are created by the parser for all toplevel method bodies. These
335 include methods, accessors and anonymous methods.
337 These contain some extra information not found in regular blocks:
338 A pointer to an optional CaptureContext (for tracking captured
339 local variables and parameters). A pointer to the parent
342 (Return.Resolve): Catch missmatches when returning a value from an
343 anonymous method (error 1662).
344 Invoke NeedReturnLabel from the Resolve phase instead of the emit
347 (Break.Resolve): ditto.
349 (SwitchLabel): instead of defining the labels during the
350 resolution phase, we now turned the public ILLabel and ILLabelCode
351 labels into methods called GetILLabelCode() and GetILLabel() that
352 only define the label during the Emit phase.
354 (GotoCase): Track the SwitchLabel instead of the computed label
355 (its contained therein). Emit the code by using
356 SwitchLabel.GetILLabelCode ().
358 (LocalInfo.Flags.Captured): A new flag has been introduce to track
359 whether the Local has been captured or not.
361 (LocalInfo.IsCaptured): New property, used to tell whether the
362 local has been captured.
364 * anonymous.cs: Vastly updated to contain the anonymous method
367 The main classes here are: CaptureContext which tracks any
368 captured information for a toplevel block and ScopeInfo used to
369 track the activation frames for various local variables.
371 Each toplevel block has an optional capture context associated
372 with it. When a method contains an anonymous method both the
373 toplevel method and the anonymous method will create a capture
374 context. When variables or parameters are captured, they are
375 recorded on the CaptureContext that owns them, for example:
379 MyDelegate d = delegate {
384 Here `a' will be recorded as captured on the toplevel
385 CapturedContext, the inner captured context will not have anything
386 (it will only have data if local variables or parameters from it
387 are captured in a nested anonymous method.
389 The ScopeInfo is used to track the activation frames for local
390 variables, for example:
392 for (int i = 0; i < 10; i++)
393 for (int j = 0; j < 10; j++){
394 MyDelegate d = delegate {
399 At runtime this captures a single captured variable `i', but it
400 captures 10 different versions of the variable `j'. The variable
401 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
404 The toplevel ScopeInfo will also track information like the `this'
405 pointer if instance variables were referenced (this is necessary
406 as the anonymous method lives inside a nested class in the host
409 (AnonymousMethod): Expanded to track the Toplevel, implement
410 `AnonymousMethod.Compatible' to tell whether an anonymous method
411 can be converted to a target delegate type.
413 The routine now also produces the anonymous method content
415 (AnonymousDelegate): A helper class that derives from
416 DelegateCreation, this is used to generate the code necessary to
417 produce the delegate for the anonymous method that was created.
419 * assign.cs: API adjustments for new changes in
420 Convert.ImplicitStandardConversionExists.
422 * class.cs: Adjustments to cope with the fact that now toplevel
423 blocks are of type `ToplevelBlock'.
425 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
426 insteda of standard blocks.
428 Flag errors if params arguments are passed to anonymous methods.
430 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
431 `CurrentAnonymousMethod' which points to the current Anonymous
432 Method. The variable points to the AnonymousMethod class that
433 holds the code being compiled. It is set in the new EmitContext
434 created for the anonymous method.
436 (EmitContext.Phase): Introduce a variable and an enumeration to
437 assist in enforcing some rules about when and where we are allowed
438 to invoke certain methods (EmitContext.NeedsReturnLabel is the
439 only one that enfonces this right now).
441 (EmitContext.HaveCaptureInfo): new helper method that returns
442 whether we have a CapturedContext initialized.
444 (EmitContext.CaptureVariable): New method used to register that a
445 LocalInfo must be flagged for capturing.
447 (EmitContext.CapturedParameter): New method used to register that a
448 parameters must be flagged for capturing.
450 (EmitContext.CapturedField): New method used to register that a
451 field must be flagged for capturing.
453 (EmitContext.HaveCapturedVariables,
454 EmitContext.HaveCapturedFields): Return whether there are captured
457 (EmitContext.EmitMethodHostInstance): This is used to emit the
458 instance for the anonymous method. The instance might be null
459 (static methods), this (for anonymous methods that capture nothing
460 and happen to live side-by-side with the current method body) or a
461 more complicated expression if the method has a CaptureContext.
463 (EmitContext.EmitTopBlock): Routine that drives the emission of
464 code: it will first resolve the top block, then emit any metadata
465 and then emit the code. The split is done so that we can extract
466 any anonymous methods and flag any captured variables/parameters.
468 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
469 during this phase, the ILGenerator should not be used as labels
470 and local variables declared here might not be accessible to any
471 code that is part of an anonymous method.
473 Exceptions to this include the temporary variables that are
474 created by some statements internally for holding temporary
477 (EmitContext.EmitMeta): New routine, in charge of emitting all the
480 (EmitContext.TemporaryReturn): This method is typically called
481 from the Emit phase, and its the only place where we allow the
482 ReturnLabel to be defined other than the EmitMeta. The reason is
483 that otherwise we would have to duplicate a lot of logic in the
484 Resolve phases of various methods that today is on the Emit
487 (EmitContext.NeedReturnLabel): This no longer creates the label,
488 as the ILGenerator is not valid during the resolve phase.
490 (EmitContext.EmitThis): Extended the knowledge in this class to
491 work in anonymous methods in addition to iterators.
493 (EmitContext.EmitCapturedVariableInstance): This emits whatever
494 code is necessary on the stack to access the instance to a local
495 variable (the variable will be accessed as a field).
497 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
498 EmitContext.EmitAddressOfParameter): Routines to support
499 parameters (not completed at this point).
501 Removals: Removed RemapLocal and RemapLocalLValue. We probably
502 will also remove the parameters.
504 * convert.cs (Convert): Define a `ConstantEC' which points to a
505 null. This is just to prefity some code that uses
506 ImplicitStandardConversion code and do not have an EmitContext
509 The idea is to flag explicitly that at that point in time, it is
510 known that the conversion will not trigger the delegate checking
511 code in implicit conversions (which requires a valid
514 Everywhere: pass new EmitContext parameter since
515 ImplicitStandardConversionExists now requires it to check for
516 anonymous method conversions.
518 (Convert.ImplicitStandardConversionExists): If the type of an
519 expression is the anonymous_method_type, and the type is a
520 delegate, we invoke the AnonymousMethod.Compatible method to check
521 whether an implicit conversion is possible.
523 (Convert.ImplicitConversionStandard): Only do implicit method
524 group conversions if the language level is not ISO_1.
526 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
527 MethodInfo for the Invoke method. used by Delegate and
530 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
531 method conversions if the target type is a delegate.
533 Removed extra debugging nops.
535 (LocalVariableReference): Turn the `local_info' into a public
538 Add `prepared' field, the same hack used for FieldExprs to cope
539 with composed assignments, as Local variables do not necessarily
540 operate purely on the stack as they used to: they can be captured
543 Add `temp' for a temporary result, like fields.
545 Refactor DoResolve and DoResolveLValue into DoResolveBase.
547 It now copes with Local variables that are captured and emits the
548 proper instance variable to load it from a field in the captured
551 (ParameterReference.DoResolveBase): During the resolve phase,
552 capture parameters if we are in an anonymous method.
554 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
555 anonymous method, use the EmitContext helper routines to emit the
558 * iterators.cs: Set RemapToProxy to true/false during the
561 * parameters.cs (GetParameterByName): New helper method.
563 * typemanager.cs (anonymous_method_type) a new type that
564 represents an anonyous method. This is always an internal type,
565 used as a fencepost to test against the anonymous-methodness of an
568 2004-10-20 Marek Safar <marek.safar@seznam.cz>
570 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
572 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
574 2004-10-18 Martin Baulig <martin@ximian.com>
576 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
577 `Type' directly, but call ResolveType() on it.
578 (Catch.Resolve): Likewise.
579 (Foreach.Resolve): Likewise.
581 2004-10-18 Martin Baulig <martin@ximian.com>
583 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
584 `Type' directly, but call ResolveType() on it.
585 (Probe.DoResolve): Likewise.
586 (ArrayCreation.LookupType): Likewise.
587 (TypeOf.DoResolve): Likewise.
588 (SizeOf.DoResolve): Likewise.
590 2004-10-18 Martin Baulig <martin@ximian.com>
592 * expression.cs (Invocation.BetterFunction): Put back
593 TypeManager.TypeToCoreType().
595 2004-10-18 Raja R Harinath <rharinath@novell.com>
597 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
600 2004-10-18 Martin Baulig <martin@ximian.com>
602 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
603 `Type' directly, but call ResolveType() on it.
605 2004-10-18 Martin Baulig <martin@ximian.com>
607 * class.cs (FieldMember.Define): Don't access the TypeExpr's
608 `Type' directly, but call ResolveType() on it.
609 (MemberBase.DoDefine): Likewise.
611 * expression.cs (New.DoResolve): Don't access the TypeExpr's
612 `Type' directly, but call ResolveType() on it.
613 (ComposedCast.DoResolveAsTypeStep): Likewise.
615 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
616 `Type' directly, but call ResolveType() on it.
618 2004-10-17 John Luke <john.luke@gmail.com>
620 * class.cs (Operator.GetSignatureForError): use CSharpName
622 * parameter.cs (Parameter.GetSignatureForError): Returns
623 correct name even if was not defined.
625 2004-10-13 Raja R Harinath <rharinath@novell.com>
628 * class.cs (TypeContainer.EmitContext): New property.
629 (DefineNestedTypes): Create an emitcontext for each part.
630 (MethodCore.DoDefineParameters): Use container's emitcontext.
631 Pass type array to InternalParameters.
632 (MemberBase.DoDefine): Use container's emitcontext.
633 (FieldMember.Define): Likewise.
634 (Event.Define): Likewise.
635 (SetMethod.GetParameterInfo): Change argument to EmitContext.
636 Pass type array to InternalParameters.
637 (SetIndexerMethod.GetParameterInfo): Likewise.
638 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
639 * delegate.cs (Define): Pass emitcontext to
640 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
641 array to InternalParameters.
642 * expression.cs (ParameterReference.DoResolveBase): Pass
643 emitcontext to GetParameterInfo.
644 (ComposedCast.DoResolveAsTypeStep): Remove check on
645 ec.ResolvingTypeTree.
646 * parameter.cs (Parameter.Resolve): Change argument to
647 EmitContext. Use ResolveAsTypeTerminal.
648 (Parameter.GetSignature): Change argument to EmitContext.
649 (Parameters.ComputeSignature): Likewise.
650 (Parameters.ComputeParameterTypes): Likewise.
651 (Parameters.GetParameterInfo): Likewise.
652 (Parameters.ComputeAndDefineParameterTypes): Likewise.
653 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
654 * support.cs (InternalParameters..ctor): Remove variant that takes
656 * typemanager.cs (system_intptr_expr): New.
657 (InitExpressionTypes): Initialize it.
659 2004-10-12 Chris Toshok <toshok@ximian.com>
661 * cs-parser.jay: fix location for try_statement and catch_clause.
663 2004-10-11 Martin Baulig <martin@ximian.com>
665 * report.cs: Don't make --fatal abort on warnings, we have
666 -warnaserror for that.
668 2004-10-07 Raja R Harinath <rharinath@novell.com>
670 More DeclSpace.ResolveType avoidance.
671 * decl.cs (MemberCore.InUnsafe): New property.
672 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
673 with newly created EmitContext.
674 (FieldMember.Define): Likewise.
675 * delegate.cs (Delegate.Define): Likewise.
676 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
677 only if normal name-lookup fails.
678 (TypeExpr.DoResolve): Enable error-checking.
679 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
680 (SizeOf.DoResolve): Likewise.
681 (ComposedCast.DoResolveAsTypeStep): Likewise.
682 (StackAlloc.DoResolve): Likewise.
683 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
684 (Block.Unsafe): New property.
685 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
686 (Unsafe): Set 'unsafe' flag of contained block.
687 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
688 (Fixed.Resolve): Likewise.
689 (Catch.Resolve): Likewise.
690 (Using.ResolveLocalVariableDecls): Likewise.
691 (Foreach.Resolve): Likewise.
693 2004-10-05 John Luke <john.luke@gmail.com>
695 * cs-parser.jay: add location to error CS0175
697 2004-10-04 Miguel de Icaza <miguel@ximian.com>
699 * ecore.cs (Expression.Constantity): Add support for turning null
702 * const.cs (Const.Define): Allow constants to be reference types
703 as long as the value is Null.
705 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
707 * namespace.cs (NamespaceEntry.Using): No matter which warning
708 level is set, check if this namespace name has already been added.
710 2004-10-03 Ben Maurer <bmaurer@ximian.com>
712 * expression.cs: reftype [!=]= null should always use br[true,false].
715 2004-10-03 Marek Safar <marek.safar@seznam.cz>
718 * attribute.cs: Enum conversion moved to
719 GetAttributeArgumentExpression to be applied to the all
722 2004-10-01 Raja R Harinath <rharinath@novell.com>
724 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
725 * class.c (TypeContainer.DefineType): Flag error if
726 base types aren't accessible due to access permissions.
727 * decl.cs (DeclSpace.ResolveType): Move logic to
728 Expression.ResolveAsTypeTerminal.
729 (DeclSpace.ResolveTypeExpr): Thin layer over
730 Expression.ResolveAsTypeTerminal.
731 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
732 Refactor code into NestedAccess. Use it.
733 (DeclSpace.NestedAccess): New.
734 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
735 argument to silence errors. Check access permissions.
736 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
737 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
738 (Cast.DoResolve): Likewise.
739 (New.DoResolve): Likewise.
740 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
741 (TypeOf.DoResolve): Likewise.
743 * expression.cs (Invocation.BetterConversion): Return the Type of
744 the better conversion. Implement section 14.4.2.3 more faithfully.
745 (Invocation.BetterFunction): Make boolean. Make correspondence to
746 section 14.4.2.2 explicit.
747 (Invocation.OverloadResolve): Update.
748 (Invocation): Remove is_base field.
749 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
750 (Invocation.Emit): Likewise.
752 2004-09-27 Raja R Harinath <rharinath@novell.com>
754 * README: Update to changes.
756 2004-09-24 Marek Safar <marek.safar@seznam.cz>
758 * cs-parser.jay: Reverted 642 warning fix.
760 2004-09-23 Marek Safar <marek.safar@seznam.cz>
763 * decl.cs (FindMemberWithSameName): Indexer can have more than
766 2004-09-23 Marek Safar <marek.safar@seznam.cz>
768 * expression.cs (LocalVariableReference.DoResolveLValue):
769 Do not report warning 219 for out values.
770 (EmptyExpression.Null): New member to avoid extra allocations.
772 2004-09-23 Marek Safar <marek.safar@seznam.cz>
774 * cs-parser.jay: Fix wrong warning 642 report.
776 * cs-tokenizer.cs (CheckNextToken): New helper;
777 Inspect next character if is same as expected.
779 2004-09-23 Martin Baulig <martin@ximian.com>
781 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
782 (Convert.ImplicitReferenceConversionExists): Likewise.
784 2004-09-23 Marek Safar <marek.safar@seznam.cz>
786 * class.cs (Operator.Define): Add error 448 and 559 report.
788 2004-09-22 Marek Safar <marek.safar@seznam.cz>
790 * class.cs (MemberBase.IsTypePermitted): New protected
791 method for checking error CS0610.
793 2004-09-22 Marek Safar <marek.safar@seznam.cz>
795 * class.cs (TypeContainer.HasExplicitLayout): New property
796 Returns whether container has StructLayout attribute set Explicit.
797 (FieldMember): New abstract class for consts and fields.
798 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
799 (Field): Reuse FieldMember.
801 * const.cs (Const): Reuse FieldMember.
803 * rootcontext.cs: EmitConstants call moved to class.
805 2004-09-22 Martin Baulig <martin@ximian.com>
807 Thanks to Peter Sestoft for this bug report.
809 * expression.cs (Conditional): If both the `trueExpr' and the
810 `falseExpr' is a NullLiteral, return a NullLiteral.
812 2004-09-22 Martin Baulig <martin@ximian.com>
814 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
815 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
816 for the "get_Current" call.
818 2004-09-22 Martin Baulig <martin@ximian.com>
820 Marek and me just fixed one of our oldest bugs: #28562 :-)
822 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
824 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
825 we're an EnumConstant, just return that.
826 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
827 an EnumConstant. In this case, we need to use GetValueAsEnumType()
828 to get the value which'll actually be written into the attribute.
829 However, we have to use GetValue() to access the attribute's value
832 2004-09-22 Marek Safar <marek.safar@seznam.cz>
834 * constant.cs (Constant.IsNegative): New abstract property
837 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
838 (StackAlloc.DoResolve): Reused IsNegative.
840 2004-09-21 Martin Baulig <martin@ximian.com>
842 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
843 if we're used in an iterator, we may be called from different
846 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
847 we actually have an exception block.
849 2004-09-20 John Luke <jluke@cfl.rr.com>
851 * class.cs, cs-parser.jay: Improve the error report for 1520:
852 report the actual line where the error happens, not where the
855 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
856 Pass location information that was available elsewhere.
858 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
860 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
861 runtime to delay sign assemblies.
863 2004-09-19 Miguel de Icaza <miguel@ximian.com>
865 * cs-parser.jay: Do not report the stack trace, this is barely
868 2004-08-22 John Luke <john.luke@gmail.com>
870 * driver.cs : check that a resource id is not already used
871 before adding it, report CS1508 if it is, bug #63637
873 2004-09-19 Miguel de Icaza <miguel@ximian.com>
875 * ecore.cs: Removed dead code.
877 2004-09-18 Marek Safar <marek.safar@seznam.cz>
879 * class.cs: Do not report warning CS0067 on the interfaces.
881 2004-09-16 Marek Safar <marek.safar@seznam.cz>
883 * cs-parser.jay: Add error 504 report.
885 2004-09-16 Marek Safar <marek.safar@seznam.cz>
887 * rootcontext.cs: WarningLevel is 4 by default now.
889 * statement.cs (Fixed.Resolve): Do not null
892 2004-09-16 Marek Safar <marek.safar@seznam.cz>
895 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
896 deep search when property is not virtual.
897 (PropertyExpr.ResolveAccessors): Make one call for both
900 2004-09-15 Marek Safar <marek.safar@seznam.cz>
903 * statement.cs: Error 152 report constains also location.
905 2004-09-15 Marek Safar <marek.safar@seznam.cz>
908 * const.cs: Explicitly set constant as static.
910 2004-09-15 Marek Safar <marek.safar@seznam.cz>
913 * cs-parser.jay: Add error 1017 report.
915 2004-09-15 Marek Safar <marek.safar@seznam.cz>
917 Fixed bug #59980, #64224
918 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
920 * typemanager.cs (IsSpecialMethod): Simplified
922 2004-09-14 Marek Safar <marek.safar@seznam.cz>
924 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
925 condition with better params.
927 2004-09-14 Marek Safar <marek.safar@seznam.cz>
930 * attribute.cs (Resolve): Property has to have both
933 2004-09-14 Martin Baulig <martin@ximian.com>
935 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
937 2004-09-14 Marek Safar <marek.safar@seznam.cz>
940 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
941 called and is obsolete then this member suppress message
942 when call is inside next [Obsolete] method or type.
944 * expression.cs: Use TestObsoleteMethodUsage member.
946 2004-09-14 Martin Baulig <martin@ximian.com>
948 * cs-parser.jay: Sync a bit with the GMCS version.
950 2004-09-14 Martin Baulig <martin@ximian.com>
952 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
953 (CSharpParser.yacc_verbose_flag): New public field.
955 * genericparser.cs: Removed.
957 2004-09-14 Raja R Harinath <rharinath@novell.com>
959 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
961 2004-09-13 Marek Safar <marek.safar@seznam.cz>
963 * class.cs (MethodCore.CheckBase): Fix bug #65757.
965 2004-09-10 Martin Baulig <martin@ximian.com>
967 Backported my MemberName changes from GMCS into MCS.
969 - we are now using a special `MemberName' class instead of using
970 strings; in GMCS, the `MemberName' also contains the type
973 - changed the grammar rules a bit:
974 * the old `member_name' is now a `namespace_or_type_name':
975 The rule is that we use `namespace_or_type_name' everywhere
976 where we expect either a "member name" (GetEnumerator) or a
977 "member name" with an explicit interface name
978 (IEnumerable.GetEnumerator).
979 In GMCS, the explicit interface name may include type arguments
980 (IEnumerable<T>.GetEnumerator).
981 * we use `member_name' instead of just `IDENTIFIER' for
983 The rule is that we use `member_name' wherever a member may
984 have type parameters in GMCS.
986 * decl.cs (MemberName): New public class.
987 (MemberCore.MemberName): New public readonly field.
988 (MemberCore.ctor): Take a `MemberName' argument, not a string.
989 (DeclSpace): Likewise.
991 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
992 * enum.cs (Enum.ctor): Likewise.
994 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
996 (AliasEntry.ctor): Take a MemberName, not an Expression.
997 (AliasEntry.UsingAlias): Likewise.
999 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1000 (IMethodData.MemberName): Changed type from string to MemberName.
1001 (MemberBase.ExplicitInterfaceName): Likewise.
1002 (AbstractPropertyEventMethod.SetupName): Make this private.
1003 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1004 argument; compute the member name here.
1005 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1006 on the `member.MemberName' and the `prefix'.
1008 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1010 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1011 thus, we get a `MemberName' instead of a `string'. These
1012 declarations may have type parameters in GMCS.
1013 (interface_method_declaration, delegate_declaration): Likewise.
1014 (class_declaration, interface_declaration): Likewise.
1015 (method_header): Use `namespace_or_type_name' instead of
1016 `member_name'. We may be an explicit interface implementation.
1017 (property_declaration, event_declaration): Likewise.
1018 (member_name): This is now just an `IDENTIFIER', not a
1019 `namespace_or_type_name'.
1020 (type_name, interface_type): Removed.
1021 (namespace_or_type_name): Return a MemberName, not an Expression.
1022 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1023 call GetTypeExpression() on the MemberName to get an expression.
1024 (IndexerDeclaration.interface_type): Changed type from string to
1026 (MakeName): Operate on MemberName's instead of string's.
1028 2004-09-13 Raja R Harinath <rharinath@novell.com>
1031 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1032 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1033 lookup to avoid symbols introduced by 'using'.
1034 * rootcontext.cs (NamespaceLookup): Update.
1036 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1038 * class.cs (TypeContainer.DoDefineMembers): Do not call
1039 DefineDefaultConstructor for static classes.
1041 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1043 * attribute.cs (Attribute.Resolve): Add error 653 report.
1045 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1047 (Method.ApplyAttributeBuilder): Add error 685 report.
1048 (Operator.Define): Add error 564 report.
1050 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1052 * expression.cs (Invocation.DoResolve): Add error
1055 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1058 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1060 * class.cs (ConstructorInitializer.Resolve):
1061 Wrong error number (515->516).
1063 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1065 * class.cs (Indexer.Define): Add error 631 report.
1067 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1069 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1071 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1073 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1075 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1077 * cs-parser.jay: Added error CS0241 report.
1079 2004-09-10 Raja R Harinath <rharinath@novell.com>
1081 * cs-parser.jay (fixed_statement): Introduce a scope for the
1082 declaration in the 'fixed' statement.
1084 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1086 * cs-parser.jay: Added CS0230 error report.
1088 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1090 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1092 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1094 * expression.cs (Argument.Resolve): Added error CS0192 and
1097 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1099 C# 2.0 #pragma warning feature
1101 * cs-tokenizer.cs (PreProcessPragma): New method;
1102 Handles #pragma directive.
1104 * report.cs (WarningRegions): New class; Support
1105 class for #pragma warning directive. It tests whether
1106 warning is enabled for a given line.
1108 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1110 * const.cs: Add more descriptive error report, tahnks to
1113 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1115 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1117 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1119 * expression.cs: Apply patch from Ben: Remove dead code from
1120 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1121 as that code just threw an exception anwyays.
1123 * const.cs: Remove the call to the turnintoconstant, for details
1126 * literal.cs: The type of the null-literal is the null type; So
1127 we use a placeholder type (literal.cs:System.Null, defined here)
1130 * expression.cs (Conditional.DoResolve): Remove some old code that
1131 is no longer needed, conversions have been fixed.
1133 (ArrayCreationExpression.DoResolve): Return false if we fail to
1134 resolve the inner expression.
1136 2004-09-07 Raja R Harinath <rharinath@novell.com>
1139 * cs-parser.jay (delegate_declaration): Record a delegate
1140 declaration as a type declaration.
1141 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1143 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1145 * parameter.cs: Do not crash if the type can not be resolved.
1147 * expression.cs: Report errors with unsafe pointers, fixes #64896
1149 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1151 * expression.cs: Pointer arith always needs to do a conv.i
1152 if the operand is a long. fix 65320
1154 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1156 Fixed cs0619-37.cs, cs0619-38.cs
1158 * enum.cs (GetObsoleteAttribute): Removed.
1160 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1161 on Enum member is double staged. The first is tested member
1164 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1166 Fixed #56986, #63631, #65231
1168 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1169 adds member to name container.
1170 (TypeContainer.AddToTypeContainer): New method, adds type to
1172 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1173 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1174 AddOperator): Simplified by reusing AddToMemberContainer.
1175 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1177 (Method.CheckForDuplications): Fixed implementation to test all
1179 (MemberBase): Detection whether member is explicit interface
1180 implementation is now in constructor.
1181 (MemberBase.UpdateMemberName): Handles IndexerName.
1182 (Accessor): Changed to keep also location information.
1183 (AbstractPropertyEventMethod): Is derived from MemberCore.
1184 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1185 will be emited or not.
1186 (PropertyBase.AreAccessorsDuplicateImplementation):
1187 Tests whether accessors are not in collision with some method.
1188 (Operator): Is derived from MethodCore to simplify common
1191 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1193 (DeclSpace.AddToContainer): Adds the member to defined_names
1194 table. It tests for duplications and enclosing name conflicts.
1196 * enum.cs (EnumMember): Clean up to reuse the base structures
1198 2004-09-03 Martin Baulig <martin@ximian.com>
1200 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1201 into TypeContainer, to make partial classes work again.
1203 2004-09-03 Martin Baulig <martin@ximian.com>
1205 * rootcontext.cs (RootContext.V2): Removed.
1207 2004-03-23 Martin Baulig <martin@ximian.com>
1209 * expression.cs (Invocation.OverloadResolve): Added `bool
1210 may_fail' argument and use it instead of the Location.IsNull() hack.
1212 2004-09-03 Martin Baulig <martin@ximian.com>
1214 Merged latest changes into gmcs. Please keep this comment in
1215 here, it makes it easier for me to see what changed in MCS since
1216 the last time I merged.
1218 2004-09-03 Raja R Harinath <rharinath@novell.com>
1221 * expression.cs (BetterConversion): Don't allow either conversion
1222 to be null. Remove redundant implicit conversion test when 'q ==
1223 null' -- when this function is invoked, we already know that the
1224 implicit conversion exists.
1225 (BetterFunction): Assume that 'best' is non-null. Remove
1226 redundant reimplementation of IsApplicable when 'best' is null.
1227 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1228 number of arguments.
1229 (IsAncestralType): Extract from OverloadResolve.
1230 (OverloadResolve): Make robust to the MethodGroupExpr being
1231 unsorted. Implement all the logic of Section 14.5.5.1, and
1232 support overloading of methods from multiple applicable types.
1233 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1235 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1236 (RealError, Warning): Append type of report to related symbol.
1238 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1240 * enum.cs: Fixed CLS-Compliance checks for enum members.
1241 Error tests cs3008-8.cs, cs3014-8.cs
1243 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1245 Fixed bug #62342, #63102
1246 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1247 like ImplementMethod.
1249 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1251 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1254 2004-09-02 Martin Baulig <martin@ximian.com>
1256 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1257 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1260 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1262 C# 2.0 Static classes implemented
1264 * class.cs (TypeContainer): instance_constructors,
1265 initialized_fields, initialized_static_fields,
1266 default_constructor, base_inteface_types are protected to be
1267 accessible from StaticClass.
1268 (TypeContainer.DefineDefaultConstructor): New virtual method
1269 for custom default constructor generating
1270 (StaticClass): New class to handle "Static classes" feature.
1272 * cs-parser.jay: Handle static keyword on class like instance
1275 * driver.cs: Added "/langversion" command line switch with two
1276 options (iso-1, default).
1278 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1280 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1282 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1284 * delegate.cs: Style.
1286 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1288 * delegate.cs: Add seperate instance expr field for miguel.
1290 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1292 * PointerArithmetic (Resolve): make sure we are not doing
1293 pointer arith on void*. Also, make sure we are resolved
1294 by not setting eclass until resolve.
1296 All callers: Make sure that PointerArithmetic gets resolved.
1298 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1300 * ArrayCreation (LookupType): If the type does not resolve
1301 to an array, give an error.
1303 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1305 * statement.cs (Try.Resolve): Fixed bug #64222
1307 2004-08-27 Martin Baulig <martin@ximian.com>
1310 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1313 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1315 * ecore.cs (Constantify): Get underlying type via
1316 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1317 Windows in special cases.
1319 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1321 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1322 for obtaining also private methods.
1323 (GetRemoveMethod): Used GetRemoveMethod (true)
1324 for obtaining also private methods.
1326 2004-08-24 Martin Baulig <martin@ximian.com>
1328 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1329 MethodAttributes.HideBySig for operators.
1331 2004-08-23 Martin Baulig <martin@ximian.com>
1333 Back to the old error reporting system :-)
1335 * report.cs (Message): Removed.
1336 (Report.MessageData, ErrorData, WarningData): Removed.
1337 (Report.Error, Warning): Back to the old system.
1339 2004-08-23 Martin Baulig <martin@ximian.com>
1341 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1343 * class.cs (TypeContainer.ParentContainer): New public virtual
1344 method; replaces the explicit interface implementation.
1345 (ClassPart.ParentContainer): Override.
1347 2004-08-23 Martin Baulig <martin@ximian.com>
1349 * statement.cs (Switch): Added support for constant switches; see
1350 #59428 or test-285.cs.
1352 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1355 * statement.cs (GetEnumeratorFilter): Removed useless
1356 logic because C# specs is strict. GetEnumerator must be
1359 2004-08-22 Martin Baulig <martin@ximian.com>
1361 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1362 a switch and may break, reset the barrier. Fixes #59867.
1364 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1366 CLS-Compliance speed up (~5% for corlib)
1368 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1369 New method. Tests container for CLS-Compliant names
1371 * class.cs (TypeContainer.VerifyClsName): New method.
1372 Checks whether container name is CLS Compliant.
1373 (Constructor): Implements IMethodData.
1375 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1376 low-case table for CLS Compliance test.
1377 (MemberCache.VerifyClsParameterConflict): New method.
1378 Checks method parameters for CS3006 error.
1380 * enum.cs (EnumMember): Is derived from MemberCore.
1381 (Enum.VerifyClsName): Optimized for better performance.
1383 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1385 * report.cs: Renamed Error_T to Error and changed all
1388 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1390 * class.cs (TypeContainer.IndexerArrayList): New inner class
1391 container for indexers.
1392 (TypeContainer.DefaultIndexerName): New constant for default
1393 indexer name. Replaced all "Item" with this constant.
1394 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1396 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1397 DefaultMemberAttribute constructor.
1399 2004-08-05 Martin Baulig <martin@ximian.com>
1401 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1404 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1406 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1407 multi platforms problem.
1409 * compiler.csproj: Included shared files.
1411 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1413 Fix bug 60333, 55971 in the more general way
1414 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1415 Added arg_type argument for constant conversion.
1416 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1418 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1421 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1422 OperatorArrayList, MethodCoreArrayList for typecontainer
1423 containers. Changed class member types to these new types.
1424 (MethodArrayList.DefineMembers): Added test for CS0659.
1426 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1428 * cfold.cs: Synchronize the folding with the code in expression.cs
1429 Binary.DoNumericPromotions for uint operands.
1431 * attribute.cs: Revert patch from Raja, it introduced a regression
1432 while building Blam-1.2.1 (hard to isolate a test case).
1434 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1438 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1440 (MethodCore.parent_method): New member. The method we're overriding
1441 if this is an override method.
1442 (MethodCore.CheckBase): Moved from Method class and made common.
1443 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1445 (MethodCore.CheckForDuplications): New abstract method. For custom
1446 member duplication search in a container
1447 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1448 method and its return type.
1449 (Event.conflict_symbol): New member. Symbol with same name in the
1453 (MemberCache.FindMemberWithSameName): New method. The method
1454 is looking for conflict with inherited symbols.
1456 2004-08-04 Martin Baulig <martin@ximian.com>
1458 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1460 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1462 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1464 * report.cs (Message): New enum for better error, warning reference in
1466 (MessageData): New inner abstract class. It generally handles printing of
1467 error and warning messages.
1468 Removed unused Error, Warning, Message methods.
1470 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1472 Fix for cs0592-8.cs test
1474 (Attributable.ValidAttributeTargets): Made public.
1475 (Attribute.ExplicitTarget): New member for explicit target value.
1476 (Attribute.CheckTargets): Now we translate explicit attribute
1477 target to Target here.
1479 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1481 * ecore.cs (MethodGroupExpr): new IsBase property.
1483 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1485 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1486 rather than an instance expr.
1488 (DelegateCreation.Emit): Use the method group rather than
1489 the instance expression. Also, if you have base.Foo as the
1490 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1492 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1494 (NewDelegate.DoResolve): Only check for the existance of Invoke
1495 if the method is going to be needed. Use MethodGroupExpr.
1497 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1499 * expression.cs: For pointer arith., make sure to use
1500 the size of the type, not the size of the pointer to
1503 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1506 * class.cs (Class): Added error CS0502 test.
1508 2004-08-03 John Luke <jluke@cfl.rr.com>
1509 Raja R Harinath <rharinath@novell.com>
1512 * attribute.cs (Attribute.complained_before): New flag.
1513 (Attribute.ResolveType, Attribute.Resolve),
1514 (Attribute.DefinePInvokeMethod): Set it.
1515 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1517 2004-08-03 Martin Baulig <martin@ximian.com>
1519 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1520 use a user-defined operator; we still need to do numeric
1521 promotions in case one argument is a builtin type and the other
1522 one has an implicit conversion to that type. Fixes #62322.
1524 2004-08-02 Martin Baulig <martin@ximian.com>
1526 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1527 (LocalInfo.IsThis): New public property.
1528 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1530 2004-08-01 Martin Baulig <martin@ximian.com>
1532 * class.cs (TypeContainer.GetClassBases): Don't set the default
1533 here since we may get called from GetPartialBases().
1534 (TypeContainer.DefineType): If GetClassBases() didn't return a
1535 parent, use the default one.
1537 2004-07-30 Duncan Mak <duncan@ximian.com>
1539 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
1541 2004-07-30 Martin Baulig <martin@ximian.com>
1543 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1545 * class.cs (SourceMethod): New public class, derive from the
1546 symbol writer's ISourceMethod.
1547 (Method): Use the new symbol writer API.
1549 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1550 as argument and use the new symbol writer.
1553 (SourceFile): Implement the symbol writer's ISourceFile.
1554 (Location.SymbolDocument): Removed.
1555 (Location.SourceFile): New public property.
1557 * symbolwriter.cs: Use the new symbol writer API.
1559 2004-07-30 Raja R Harinath <rharinath@novell.com>
1561 * Makefile (install-local): Remove. Functionality moved to
1564 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1566 * Makefile: Install mcs.exe.config file together with mcs.exe.
1567 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1568 correct runtime version.
1570 2004-07-25 Martin Baulig <martin@ximian.com>
1573 (TypeContainer.RegisterOrder): Removed, this was unused.
1574 (TypeContainer, interface_order): Removed.
1575 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1576 TypeContainer as argument since we can also be called with a
1577 `PartialContainer' for a partial class/struct/interface.
1578 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1579 of checking whether we're an `Interface' - we could be a
1581 (PartialContainer.Register): Override; call
1582 AddClass()/AddStruct()/AddInterface() on our parent.
1584 * cs-parser.jay (interface_member_declaration): Add things to the
1585 `current_container', not the `current_class'.
1587 * rootcontext.cs (RegisterOrder): The overloaded version which
1588 takes an `Interface' was unused, removed.
1590 * typemanager.cs (TypeManager.LookupInterface): Return a
1591 `TypeContainer', not an `Interface'.
1592 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1593 contain a `PartialContainer' for an interface, so check it's
1594 `Kind' to figure out what it is.
1596 2004-07-25 Martin Baulig <martin@ximian.com>
1598 * class.cs (Class.DefaultTypeAttributes): New public constant.
1599 (Struct.DefaultTypeAttributes): Likewise.
1600 (Interface.DefaultTypeAttributes): Likewise.
1601 (PartialContainer.TypeAttr): Override this and add the
1602 DefaultTypeAttributes.
1604 2004-07-25 Martin Baulig <martin@ximian.com>
1606 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1607 we can just use the `Parent' field instead.
1609 2004-07-25 Martin Baulig <martin@ximian.com>
1611 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1613 2004-07-25 Martin Baulig <martin@ximian.com>
1615 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1616 our parts before defining any methods.
1617 (TypeContainer.VerifyImplements): Make this virtual.
1618 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1619 on our PartialContainer.
1621 2004-07-25 Martin Baulig <martin@ximian.com>
1623 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1625 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1626 argument, we can just use the `Parent' field instead.
1629 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1630 (MemberBase.DoDefine): Likewise.
1632 2004-07-24 Martin Baulig <martin@ximian.com>
1634 * decl.cs (MemberCore.Parent): New public field.
1635 (DeclSpace.Parent): Moved to MemberCore.
1637 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1638 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1640 (FieldBase, Field, Operator): Likewise.
1641 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1642 (EventField, Event): Likewise.
1644 2004-07-23 Martin Baulig <martin@ximian.com>
1646 * class.cs (PartialContainer): New public class.
1647 (ClassPart): New public class.
1648 (TypeContainer): Added support for partial classes.
1649 (TypeContainer.GetClassBases): Splitted some of the functionality
1650 out into GetNormalBases() and GetPartialBases().
1652 * cs-tokenizer.cs (Token.PARTIAL): New token.
1653 (Tokenizer.consume_identifier): Added some hacks to recognize
1654 `partial', but only if it's immediately followed by `class',
1655 `struct' or `interface'.
1657 * cs-parser.jay: Added support for partial clases.
1659 2004-07-23 Martin Baulig <martin@ximian.com>
1661 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1662 a `DeclSpace' and also made it readonly.
1663 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1664 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1665 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1667 * cs-parser.jay: Pass the `current_class', not the
1668 `current_container' (at the moment, this is still the same thing)
1669 to a new Method, Property, Event, Indexer or Constructor.
1671 2004-07-23 Martin Baulig <martin@ximian.com>
1673 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1674 and removed the `current_interface' one.
1675 (struct_declaration, class_declaration, interface_declaration):
1676 Set `current_class' to the newly created class/struct/interface;
1677 set their `Bases' and call Register() before parsing their body.
1679 2004-07-23 Martin Baulig <martin@ximian.com>
1681 * class.cs (Kind): New public enum.
1682 (TypeContainer): Made this class abstract.
1683 (TypeContainer.Kind): New public readonly field.
1684 (TypeContainer.CheckDef): New public method; moved here from
1686 (TypeContainer.Register): New public abstract method.
1687 (TypeContainer.GetPendingImplementations): New public abstract
1689 (TypeContainer.GetClassBases): Removed the `is_class' and
1690 `is_iface' parameters.
1691 (TypeContainer.DefineNestedTypes): Formerly known as
1693 (ClassOrStruct): Made this class abstract.
1695 * tree.cs (RootTypes): New public type.
1697 2004-07-20 Martin Baulig <martin@ximian.com>
1699 * tree.cs (Tree.RecordNamespace): Removed.
1700 (Tree.Namespaces): Removed.
1702 * rootcontext.cs (RootContext.IsNamespace): Removed.
1704 * cs-parser.jay (namespace_declaration): Just create a new
1705 NamespaceEntry here.
1707 2004-07-20 Martin Baulig <martin@ximian.com>
1709 * statement.cs (ExceptionStatement): New abstract class. This is
1710 now used as a base class for everyone who's using `finally'.
1711 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
1712 our local variables before using them.
1714 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
1715 virtual method. This is used by Yield.Resolve() to "steal" an
1716 outer block's `finally' clauses.
1717 (FlowBranchingException): The .ctor now takes an ExceptionStatement
1720 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
1721 version which takes an ExceptionStatement. This version must be
1722 used to create exception branchings.
1725 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
1726 (Iterator.EmitMoveNext): Added exception support; protect the
1727 block with a `fault' clause, properly handle 'finally' clauses.
1728 (Iterator.EmitDispose): Run all the `finally' clauses here.
1730 2004-07-20 Martin Baulig <martin@ximian.com>
1732 * iterator.cs: This is the first of a set of changes in the
1733 iterator code. Match the spec more closely: if we're an
1734 IEnumerable, then GetEnumerator() must be called. The first time
1735 GetEnumerator() is called, it returns the current instance; all
1736 subsequent invocations (if any) must create a copy.
1738 2004-07-19 Miguel de Icaza <miguel@ximian.com>
1740 * expression.cs: Resolve the constant expression before returning
1743 2004-07-19 Martin Baulig <martin@ximian.com>
1745 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
1746 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
1747 the return type of the new EmitContext.
1749 2004-07-18 Martin Baulig <martin@ximian.com>
1751 * class.cs (Property.Define): Fix iterators.
1753 * iterators.cs (Iterator.Define): Moved the
1754 `container.AddInterator (this)' call here from the .ctor; only do
1755 it if we resolved successfully.
1757 2004-07-17 Miguel de Icaza <miguel@ximian.com>
1759 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
1760 `true' for preprocessing directives that we parse. The return
1761 value indicates whether we should return to regular tokenizing or
1762 not, not whether it was parsed successfully.
1764 In the past if we were in: #if false ... #line #endif, we would
1765 resume parsing after `#line'. See bug 61604.
1767 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
1768 building: IsEnumType should return true only for enums, not for
1769 enums or System.Enum itself. This fixes #61593.
1771 Likely what happened is that corlib was wrong: mcs depended on
1772 this bug in some places. The bug got fixed, we had to add the
1773 hack, which caused bug 61593.
1775 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
1776 that was a workaround for the older conditions.
1778 2004-07-16 Ben Maurer <bmaurer@ximian.com>
1780 * assign.cs: IAssignMethod has a new interface, as documented
1781 inline. All assignment code now uses this new api.
1783 * ecore.cs, expression.cs: All classes which implement
1784 IAssignMethod now use the new interface.
1786 * expression.cs (Invocation): add a hack to EmitCall so that
1787 IndexerAccess can be the target of a compound assignment without
1788 evaluating its arguments twice.
1790 * statement.cs: Handle changes in Invocation api.
1792 2004-07-16 Martin Baulig <martin@ximian.com>
1794 * iterators.cs: Rewrote this. We're now using one single Proxy
1795 class for both the IEnumerable and the IEnumerator interface and
1796 `Iterator' derives from Class so we can use the high-level API.
1798 * class.cs (TypeContainer.AddIterator): New method.
1799 (TypeContainer.DoDefineType): New protected virtual method, which
1800 is called from DefineType().
1801 (TypeContainer.DoDefineMembers): Call DefineType() and
1802 DefineMembers() on all our iterators.
1803 (TypeContainer.Emit): Call Emit() on all our iterators.
1804 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1806 * codegen.cs (EmitContext.CurrentIterator): New public field.
1808 2004-07-15 Martin Baulig <martin@ximian.com>
1811 (TypeManager.not_supported_exception_type): New type.
1813 2004-07-14 Martin Baulig <martin@ximian.com>
1815 * iterators.cs: Use real error numbers.
1817 2004-07-14 Martin Baulig <martin@ximian.com>
1819 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
1820 requires this to be a System.Collection.IEnumerable and not a
1821 class implementing that interface.
1822 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
1824 2004-07-13 Marek Safar <marek.safar@seznam.cz>
1826 * class.cs: Fixed previous fix, it broke some error tests.
1828 2004-07-12 Martin Baulig <martin@ximian.com>
1830 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
1833 2004-07-09 Miguel de Icaza <miguel@ximian.com>
1835 * assign.cs (LocalTemporary): Add new argument: is_address,If
1836 `is_address' is true, then the value that we store is the address
1837 to the real value, and not the value itself.
1839 * ecore.cs (PropertyExpr): use the new local temporary
1840 stuff to allow us to handle X.Y += z (where X is a struct)
1842 2004-07-08 Martin Baulig <martin@ximian.com>
1844 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
1845 not always return, just like we're doing in Using.Resolve().
1847 2004-07-07 Miguel de Icaza <miguel@ximian.com>
1849 * cs-parser.jay (fixed_statement): flag this as Pinned.
1851 2004-07-06 Miguel de Icaza <miguel@ximian.com>
1853 * typemanager.cs (TypeManager): Removed MakePinned method, this
1854 mechanism is replaced with the .NET 2.x compatible mechanism of
1855 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1857 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1858 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1859 `IsFixed' property which has a different meaning.
1861 2004-07-02 Raja R Harinath <rharinath@novell.com>
1863 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1864 visible from inside a nested class, not just the names of the
1865 immediately enclosing class.
1868 2004-06-24 Raja R Harinath <rharinath@novell.com>
1870 * expression.cs (BetterConversion): Remove buggy special-case
1871 handling of "implicit constant expression conversions". At this
1872 point, we already know that the conversion is possible -- we're
1873 only checking to see which is better.
1875 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1877 * cs-parser.jay: Added error CS0210 test.
1879 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1881 * cs-parser.jay: Added error CS0134 test.
1883 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1886 * cs-parser.jay: Added error CS0145 test.
1888 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1890 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
1892 2004-06-23 Ben Maurer <bmaurer@ximian.com>
1894 * expression.cs (StackAlloc.Resolve): The argument may not
1895 be a constant; deal with this case.
1897 2004-06-23 Marek Safar <marek.safar@seznam.cz>
1899 * attribute.cs (IndexerName_GetIndexerName): Renamed to
1900 GetIndexerAttributeValue.
1901 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
1903 * class.cs (Indexer.Define): Added error tests for CS0415,
1906 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1908 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1911 2004-06-23 Martin Baulig <martin@ximian.com>
1913 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1914 neither return nor throw, reset the barrier as well. Fixes #60457.
1916 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1918 * class.cs : EventAttributes is now set to None by default.
1919 This fixes bug #60459.
1921 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1924 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1925 Don't throw exception but return null (it's sufficient now).
1927 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1929 * typemanager.cs (GetArgumentTypes): Faster implementation.
1931 2004-06-18 Martin Baulig <martin@ximian.com>
1933 * attribute.cs (Attribute.Resolve): Check whether we're an
1934 EmptyCast which a Constant child. Fixes #60333.
1936 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1938 * statement.cs (EmitCollectionForeach): Account for the fact that
1939 not all valuetypes are in areas which we can take the address of.
1940 For these variables, we store to a temporary variable. Also, make
1941 sure that we dont emit a `callvirt' on a valuetype method.
1943 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1945 * expression.cs (StackAlloc.DoReSolve): Added test for
1946 negative parameter (CS0247).
1948 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1951 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1953 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1956 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1959 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1961 Fix bug #58254 & cs1555.cs, cs1556.cs
1962 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1964 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1966 * cs-parser.jay: Added error CS1669 test for indexers.
1968 2004-06-11 Martin Baulig <martin@ximian.com>
1970 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1971 call this twice: for params and varargs methods.
1973 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1976 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1978 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1980 * attribute.cs (Attribute.GetValidTargets): Made public.
1983 (AbstractPropertyEventMethod): New class for better code sharing.
1984 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1986 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1988 2004-06-11 Raja R Harinath <rharinath@novell.com>
1991 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
1992 that the call to Resolve is part of a MemberAccess.
1993 (Expression.Resolve): Use it for SimpleName resolution.
1994 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
1995 Add 'intermediate' boolean argument.
1996 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
1997 error message when the SimpleName can be resolved ambiguously
1998 between an expression and a type.
1999 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2001 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2002 call on the left-side.
2004 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2007 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2009 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2011 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2013 2004-06-11 Martin Baulig <martin@ximian.com>
2015 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2016 varargs methods if applicable.
2018 2004-06-11 Martin Baulig <martin@ximian.com>
2020 * expression.cs (Invocation.EmitCall): Don't use
2021 `method.CallingConvention == CallingConventions.VarArgs' since the
2022 method could also have `CallingConventions.HasThis'.
2024 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2026 * class.cs (Event.GetSignatureForError): Implemented.
2027 Fixed crash in error test cs3010.cs
2029 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2031 * cs-tokenizer.cs: Change the way we track __arglist to be
2032 consistent with the other keywords.
2034 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2036 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2039 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2041 * codegen.cs: Check that all referenced assemblies have a strongname
2042 before strongnaming the compiled assembly. If not report error CS1577.
2043 Fix bug #56563. Patch by Jackson Harper.
2044 * typemanager.cs: Added a method to return all referenced assemblies.
2045 Fix bug #56563. Patch by Jackson Harper.
2047 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2050 (Method.ApplyAttributeBuilder): Moved and added conditional
2051 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2054 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2056 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2059 * class.cs: (EventField.attribute_targets): Changed default target.
2061 2004-06-08 Martin Baulig <martin@ximian.com>
2063 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2065 2004-06-08 Martin Baulig <martin@ximian.com>
2067 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2069 2004-06-07 Martin Baulig <martin@ximian.com>
2071 Added support for varargs methods.
2073 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2076 * cs-parser.jay: Added support for `__arglist'.
2078 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2080 * expression.cs (Argument.AType): Added `ArgList'.
2081 (Invocation): Added support for varargs methods.
2082 (ArglistAccess): New public class.
2083 (Arglist): New public class.
2085 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2087 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2088 a method's top-level block if the method has varargs.
2090 * support.cs (ReflectionParameters, InternalParameters): Added
2091 support for varargs methods.
2093 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2095 * class.cs: Provide location in indexer error report.
2097 * driver.cs: Use standard names.
2099 * namespace.cs: Catch the use of using after a namespace has been
2100 declared also on using aliases.
2102 2004-06-03 Raja R Harinath <rharinath@novell.com>
2105 * typemanager.cs (closure_private_ok, closure_invocation_type)
2106 (closure_qualifier_type, closure_invocation_assembly)
2107 (FilterWithClosure): Move to ...
2108 (Closure): New internal nested class.
2109 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2110 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2111 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2112 (MemberLookup, MemberLookupFailed): Use it.
2113 * expression.cs (New.DoResolve): Treat the lookup for the
2114 constructor as being qualified by the 'new'ed type.
2115 (Indexers.GetIndexersForTypeOrInterface): Update.
2117 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2120 (GetConditionalAttributeValue): New method. Returns
2121 condition of ConditionalAttribute.
2122 (SearchMulti): New method. Returns all attributes of type 't'.
2123 Use it when attribute is AllowMultiple = true.
2124 (IsConditionalMethodExcluded): New method.
2127 (Method.IsExcluded): Implemented. Returns true if method has conditional
2128 attribute and the conditions is not defined (method is excluded).
2129 (IMethodData): Extended interface for ConditionalAttribute support.
2130 (PropertyMethod.IsExcluded): Implemented.
2133 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2136 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2139 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2141 * expression.cs (ArrayCreationExpression): Make this just an
2142 `expression'. It can't be a statement, so the code here was
2145 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2148 * typemanager.cs (GetFullNameSignature): New method for
2151 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2154 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2155 Use this method when MethodBuilder is null.
2156 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2157 Added test for error CS0626 (MONO reports error for this situation).
2158 (IMethodData.GetSignatureForError): Extended interface.
2160 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2163 (AttributeTester.GetObsoleteAttribute): Returns instance of
2164 ObsoleteAttribute when type is obsolete.
2167 (TypeContainer.VerifyObsoleteAttribute): Override.
2168 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2169 (MethodCode.VerifyObsoleteAttribute): Override.
2170 (MemberBase.VerifyObsoleteAttribute): Override.
2173 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2174 and report proper error.
2177 Delegate.VerifyObsoleteAttribute): Override.
2180 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2181 and report proper error.
2182 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2185 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2189 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2190 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2191 Added test for ObsoleteAttribute.
2194 (Catch): Derived from Statement.
2196 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2198 Fixed bug #59071 & cs0160.cs
2200 * statement.cs (Try.Resolve): Check here whether order of catch
2201 clauses matches their dependencies.
2203 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2205 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2206 caused a regression: #59343. Referencing nested classes from an
2207 assembly stopped working.
2209 2004-05-31 Martin Baulig <martin@ximian.com>
2211 MCS is now frozen for beta 2.
2213 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2215 * convert.cs: add a trivial cache for overload operator resolution.
2217 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2219 * decl.cs: If possible, use lookuptypedirect here. We can only do
2220 this if there is no `.' after the namespace. Avoids using
2221 LookupType, which does lots of slow processing.
2222 (FindNestedType) New method, does what it says :-).
2223 * namespace.cs: use LookupTypeDirect.
2224 * rootcontext.cs: use membercache, if possible.
2225 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2227 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2230 According to the spec,
2232 In a member access of the form E.I, if E is a single identifier,
2233 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2234 field, property, localvariable, or parameter with the same type as
2235 the meaning of E as a type-name (§3.8), then both possible
2236 meanings of E are permitted.
2238 We did not check that E as a simple-name had the same type as E as
2241 This trivial check gives us 5-7% on bootstrap time.
2243 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2245 * expression.cs (Invocation.OverloadResolve): Avoid the
2246 use of hashtables and boxing here by allocating on demand.
2248 2004-05-30 Martin Baulig <martin@ximian.com>
2250 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2251 we're doing a silent lookup. Don't try to lookup nested types in
2252 TypeManager.object_type (thanks to Ben Maurer).
2254 2004-05-30 Martin Baulig <martin@ximian.com>
2256 Committing a patch from Ben Maurer.
2258 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2260 2004-05-29 Martin Baulig <martin@ximian.com>
2262 * class.cs (IMethodData.ShouldIgnore): New method.
2264 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2265 `Location' argument, we don't need it anywhere. Use
2266 `IMethodData.ShouldIgnore ()' instead of
2267 `MethodData.GetMethodFlags ()'.
2268 (TypeManager.AddMethod): Removed.
2269 (TypeManager.AddMethod2): Renamed to AddMethod.
2271 2004-05-29 Martin Baulig <martin@ximian.com>
2273 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2275 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2276 converting from a class type S to an interface type and we already
2277 have an object on the stack, don't box it again. Fixes #52578.
2279 2004-05-29 Martin Baulig <martin@ximian.com>
2281 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2282 Added support for `params' parameters. Fixes #59267.
2284 2004-05-29 Martin Baulig <martin@ximian.com>
2286 * literal.cs (NullPointer): Provide a private .ctor which sets
2287 `type' to TypeManager.object_type. Fixes #59048.
2289 2004-05-29 Martin Baulig <martin@ximian.com>
2291 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2292 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2294 * ecore.cs (EventExpr.instance_expr): Make the field private.
2296 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2298 Fixed bug #50080 & cs0214-2.cs
2299 * expression.cs (Cast.DoResolve): Check unsafe context here.
2301 * statement.cs (Resolve.DoResolve): Likewise.
2303 2004-05-26 Martin Baulig <martin@ximian.com>
2305 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2307 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2308 (RootContext.LookupType): Pass down the `silent' flag.
2310 2004-05-25 Martin Baulig <martin@ximian.com>
2313 (MethodGroupExpr.IdenticalTypeName): New public property.
2314 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2315 expression actually refers to a type.
2317 2004-05-25 Martin Baulig <martin@ximian.com>
2319 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2320 for #56176 and made it actually work.
2322 2004-05-25 Martin Baulig <martin@ximian.com>
2324 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2325 (FieldExpr, PropertyExpr): Override and implement
2326 CacheTemporaries. Fixes #52279.
2328 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2330 * location.cs: In the new compiler listing a file twice is a
2331 warning, not an error.
2333 2004-05-24 Martin Baulig <martin@ximian.com>
2335 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2336 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2338 2004-05-24 Martin Baulig <martin@ximian.com>
2340 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2341 walking the `using' list. Fixes #53921.
2343 2004-05-24 Martin Baulig <martin@ximian.com>
2345 * const.cs (Const.LookupConstantValue): Added support for
2346 EmptyCast's; fixes #55251.
2348 2004-05-24 Martin Baulig <martin@ximian.com>
2350 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2351 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2352 which does the CS0135 check. The reason is that we first need to
2353 check whether the variable actually exists.
2355 2004-05-24 Martin Baulig <martin@ximian.com>
2357 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2358 than RootContext.LookupType() to find the explicit interface
2361 2004-05-24 Raja R Harinath <rharinath@novell.com>
2363 * Makefile: Simplify. Use executable.make.
2364 * mcs.exe.sources: New file. List of sources of mcs.exe.
2366 2004-05-24 Anders Carlsson <andersca@gnome.org>
2370 Use the invariant culture when doing String.Compare for CLS case
2373 2004-05-23 Martin Baulig <martin@ximian.com>
2375 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2376 don't have any dots. Fixes #52622, added cs0246-8.cs.
2378 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2380 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2382 * class.cs (MemberBase.Define): Reuse MemberType member for
2383 resolved type. Other methods can use it too.
2385 2004-05-23 Martin Baulig <martin@ximian.com>
2387 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2388 the variable also exists in the current block (otherwise, we need
2389 to report a CS0103). Fixes #58670.
2391 2004-05-23 Martin Baulig <martin@ximian.com>
2393 * flowanalysis.cs (Reachability.Reachable): Compute this
2394 on-the-fly rather than storing it as a field.
2396 2004-05-23 Martin Baulig <martin@ximian.com>
2398 * flowanalysis.cs (Reachability.And): Manually compute the
2399 resulting `barrier' from the reachability.
2401 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2404 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2405 instance of ObsoleteAttribute when symbol is obsolete.
2408 (IMethodData): Extended interface for ObsoleteAttribute support.
2410 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2412 * attribute.cs: Fix bug #55970
2414 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2418 (GetObsoleteAttribute): New method. Creates the instance of
2420 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2421 ObsoleteAttribute when member is obsolete.
2422 (AttributeTester.Report_ObsoleteMessage): Common method for
2423 Obsolete error/warning reporting.
2426 (TypeContainer.base_classs_type): New member for storing parent type.
2429 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2430 for this MemberCore.
2432 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2434 * attribute.cs, const.cs: Fix bug #58590
2436 2004-05-21 Martin Baulig <martin@ximian.com>
2438 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2439 out parameters if the end of the method is unreachable. Fixes
2442 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2444 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2445 Hari was right, why extra method.
2447 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2449 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2451 2004-05-20 Martin Baulig <martin@ximian.com>
2453 Merged this back from gmcs to keep the differences to a minumum.
2455 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2456 instead of a Declspace.
2457 (Attribute.ResolveType): Likewise.
2458 (Attributes.Search): Likewise.
2459 (Attributes.Contains): Likewise.
2460 (Attributes.GetClsCompliantAttribute): Likewise.
2462 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
2464 (MethodData.ApplyAttributes): Take an EmitContext instead of a
2467 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2469 Fix bug #58688 (MCS does not report error when the same attribute
2472 * attribute.cs (Attribute.Emit): Distinction between null and default.
2474 2004-05-19 Raja R Harinath <rharinath@novell.com>
2476 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2477 of a top-level attribute without an attribute target.
2478 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2480 (Attribute.Conditional_GetConditionName),
2481 (Attribute.Obsolete_GetObsoleteMessage): Update.
2482 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2483 part of ScanForIndexerName.
2484 (Attribute.CanIgnoreInvalidAttribute): New function.
2485 (Attribute.ScanForIndexerName): Move to ...
2486 (Attributes.ScanForIndexerName): ... here.
2487 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2488 (Attributes.Search): New internal variant that can choose not to
2489 complain if types aren't resolved. The original signature now
2491 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2492 complaints suppressed.
2493 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2494 only if it not useful.
2495 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2496 top-level for attributes that are shared between the assembly
2497 and a top-level class.
2498 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2499 * class.cs: Update to reflect changes.
2500 (DefineIndexers): Fuse loops.
2501 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2502 a couple more variants of attribute names.
2504 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2506 Fix bug #52585 (Implemented explicit attribute declaration)
2509 (Attributable.ValidAttributeTargets): New abstract method. It gets
2510 list of valid attribute targets for explicit target declaration.
2511 (Attribute.Target): It holds target itself.
2512 (AttributeSection): Removed.
2513 (Attribute.CheckTargets): New method. It checks whether attribute
2514 target is valid for the current element.
2517 (EventProperty): New class. For events that are declared like
2518 property (with add and remove accessors).
2519 (EventField): New class. For events that are declared like field.
2522 * cs-parser.jay: Implemented explicit attribute target declaration.
2524 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2525 Override ValidAttributeTargets.
2528 (ReturnParameter): Class for applying custom attributes on
2530 (ParameterAtribute): New class. Class for applying custom
2531 attributes on the parameter type.
2533 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2535 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2538 (Method): Allow UNSAFE here.
2540 * modifiers.cs: Support unsafe reporting.
2542 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2544 * decl.cs: Fix bug #58478.
2546 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2548 * statement.cs: When checking for unreachable code on an EmptyStatement,
2549 set the location. Fixes bug #58488.
2551 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2553 * driver.cs: Add -pkg handling.
2555 From Gonzalo: UseShelLExecute=false
2557 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2560 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2562 (Attribute.IsClsCompliaceRequired): Moved to base for better
2564 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2565 when attribute is AttributeUsageAttribute.
2566 (Attribute.GetValidTargets): Simplified.
2567 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2568 attribute for this type.
2569 (Attribute.ApplyAttributes): Method renamed to Emit and make
2571 (GlobalAttributeSection): New class for special handling of global
2572 attributes (assembly, module).
2573 (AttributeSection.Emit): New method.
2575 * class.cs: Implemented Attributable abstract methods.
2576 (MethodCore.LabelParameters): Moved to Parameter class.
2577 (Accessor): Is back simple class.
2578 (PropertyMethod): Implemented Attributable abstract class.
2579 (DelegateMethod): Implemented Attributable abstract class.
2580 (Event): New constructor for disctintion between normal Event
2581 and Event with accessors.
2583 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2585 * codegen.cs, const.cs, decl.cs, delegate.cs:
2586 (CommonAssemblyModulClass): Implemented Attributable abstract class
2589 * enum.cs: Implement IAttributeSupport interface.
2590 (EnumMember): New class for emum members. Implemented Attributable
2594 (ParameterBase): Is abstract.
2595 (ReturnParameter): New class for easier [return:] attribute handling.
2597 * typemanager.cs: Removed builder_to_attr.
2599 2004-05-11 Raja R Harinath <rharinath@novell.com>
2602 * attribute.cs (Attribute.GetPositionalValue): New function.
2603 * class.cs (TypeContainer.VerifyMembers): New function.
2604 (TypeContainer.Emit): Use it.
2605 (ClassOrStruct): New base class for Class and Struct.
2606 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2607 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2609 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2610 then each non-static field should have a FieldOffset attribute.
2611 Otherwise, none of the fields should have a FieldOffset attribute.
2612 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2613 and FieldOffset attributes.
2614 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2615 (TypeManager.field_offset_attribute_type): New core types.
2616 (TypeManager.InitCoreTypes): Initialize them.
2618 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2620 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2621 Return correct type.
2624 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2626 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2627 be implicitly converted to ulong.
2629 * expression.cs: The logic for allowing operator &, | and ^ worked
2630 was wrong, it worked before because we did not report an error in
2631 an else branch. Fixes 57895.
2633 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2634 allow volatile fields to be reference types.
2636 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2638 * driver.cs: Add support for /debug-
2640 2004-05-07 Raja R Harinath <rharinath@novell.com>
2642 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2643 Add a 'complain' parameter to silence errors.
2644 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2645 silently overlooked type-resolutions.
2646 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2648 (Attributes.Search): New function.
2649 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2650 (Attributes.GetAttributeFullName): Remove hack.
2651 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2652 Update to reflect changes.
2653 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2654 Use Attributes.Search instead of nested loops.
2656 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2659 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2660 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2661 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2663 * report.cs: (Report.Warning): Renamed to Warning_T because of
2664 parameter collision.
2666 2004-05-05 Raja R Harinath <rharinath@novell.com>
2668 * expression.cs (MemberAccess.ResolveMemberAccess):
2669 Exit with non-zero status after Report.Error.
2670 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2672 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2674 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2676 * support.cs: Don't hang when the file is empty.
2678 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2680 * support.cs: In SeekableStreamReader, compute the preamble size of the
2681 underlying stream. Position changes should take into account that initial
2684 2004-05-03 Todd Berman <tberman@sevenl.net>
2686 * driver.cs: remove unused GetSysVersion function.
2688 2004-05-03 Todd Berman <tberman@sevenl.net>
2690 * driver.cs: Remove the hack from saturday, as well as the hack
2691 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2692 link_paths to get that bit proper.
2694 2004-05-01 Todd Berman <tberman@sevenl.net>
2696 * driver.cs: Try a LoadFrom before a Load, this checks the current
2697 path. This is currently a bug in mono that is be fixed, however, this
2698 provides a workaround for now. This will be removed when the bug
2701 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2703 * CryptoConvert.cs: Updated to latest version. Fix issue with
2704 incomplete key pairs (#57941).
2706 2004-05-01 Todd Berman <tberman@sevenl.net>
2708 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2711 2004-04-30 Jackson Harper <jackson@ximian.com>
2713 * codegen.cs: Open keys readonly.
2715 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2717 * typemanager.cs: don't report cyclic struct layout when a struct
2718 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2719 which has 2 Pango.Rectangle fields.
2721 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2723 * expression.cs: Handle IntPtr comparisons with IL code
2724 rather than a method call.
2726 2004-04-29 Martin Baulig <martin@ximian.com>
2728 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2729 the list of PropertyInfo's in class hierarchy and find the
2730 accessor. Fixes #56013.
2732 2004-04-29 Martin Baulig <martin@ximian.com>
2734 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2736 2004-04-29 Martin Baulig <martin@ximian.com>
2738 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2740 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2742 2004-04-29 Martin Baulig <martin@ximian.com>
2744 * class.cs (ConstructorInitializer.Resolve): Check whether the
2745 parent .ctor is accessible. Fixes #52146.
2747 2004-04-29 Martin Baulig <martin@ximian.com>
2749 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2751 * statement.cs (Using.EmitLocalVariableDecls): Use
2752 TypeManager.idisposable_type, not typeof (IDisposable).
2753 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2755 2004-04-29 Martin Baulig <martin@ximian.com>
2757 * class.cs (Event.Define): Don't emit the field and don't set
2758 RTSpecialName and SpecialName for events on interfaces. Fixes
2761 2004-04-29 Raja R Harinath <rharinath@novell.com>
2763 Refactor Attribute.ApplyAttributes.
2764 * attribute.cs (Attributable): New base class for objects that can
2765 have Attributes applied on them.
2766 (Attribute): Make AttributeUsage fields public.
2767 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2768 (Attribute.IsInternalCall): New property.
2769 (Attribute.UsageAttr): Convert to a public read-only property.
2770 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2771 (Attribute.ResolveType, Attribute.Resolve)
2772 (Attribute.ScanForIndexerName): Update to reflect changes.
2773 (Attribute.CheckAttributeTarget): Re-format.
2774 (Attribute.ApplyAttributes): Refactor, to various
2775 Attributable.ApplyAttributeBuilder methods.
2776 * decl.cs (MemberCore): Make Attributable.
2777 * class.cs (Accessor): Make Attributable.
2778 (MethodData.ApplyAttributes): Use proper attribute types, not
2780 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2781 (TypeContainer.ApplyAttributeBuilder)
2782 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2783 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2784 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2785 (Operator.ApplyAttributeBuilder): New factored-out methods.
2786 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2787 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2788 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2789 * parameter.cs (ParameterBase): New Attributable base class
2790 that can also represent Return types.
2791 (Parameter): Update to the changes.
2793 2004-04-29 Jackson Harper <jackson@ximian.com>
2795 * driver.cs: Prefer the corlib system version when looking for
2796 assemblies in the GAC. This is still a hack, but its a better hack
2799 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2801 * decl.cs, enum.cs: Improved error 3005 reporting.
2803 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2804 (related_symbols): New private member for list of symbols
2805 related to reported error/warning.
2807 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2809 2004-04-29 Martin Baulig <martin@ximian.com>
2811 * ecore.cs (Expression.Constantify): If we're an enum and
2812 TypeManager.TypeToCoreType() doesn't give us another type, use
2813 t.UnderlyingSystemType. Fixes #56178.
2815 2004-04-29 Martin Baulig <martin@ximian.com>
2817 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2818 interfaces and for each interface, only add members directly
2819 declared in that interface. Fixes #53255.
2821 2004-04-28 Martin Baulig <martin@ximian.com>
2823 * expression.cs (ConditionalLogicalOperator): Use a temporary
2824 variable for `left' to avoid that we evaluate it more than once;
2827 2004-04-28 Martin Baulig <martin@ximian.com>
2829 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2832 2004-04-28 Martin Baulig <martin@ximian.com>
2834 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2837 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2838 whether the type is not void (CS1547).
2840 2004-04-28 Martin Baulig <martin@ximian.com>
2842 * expression.cs (Unary.DoResolveLValue): Override this and report
2843 CS0131 for anything but Operator.Indirection.
2845 2004-04-28 Martin Baulig <martin@ximian.com>
2847 Committing a patch from Ben Maurer; see bug #50820.
2849 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2852 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2855 2004-04-28 Martin Baulig <martin@ximian.com>
2857 Committing a patch from Ben Maurer; see bug #50820.
2859 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2862 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2865 2004-04-28 Martin Baulig <martin@ximian.com>
2867 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2868 (Block.AddLabel): Call DoLookupLabel() to only search in the
2871 2004-04-28 Martin Baulig <martin@ximian.com>
2873 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2874 comparing StringConstants and NullLiterals in Equality and Inequality.
2876 2004-04-28 Jackson Harper <jackson@ximian.com>
2878 * driver.cs: Attempt to load referenced assemblies from the
2879 GAC. This is the quick and dirty version of this method that
2880 doesnt take into account versions and just takes the first
2881 canidate found. Will be good enough for now as we will not have more
2882 then one version installed into the GAC until I update this method.
2884 2004-04-28 Martin Baulig <martin@ximian.com>
2886 * typemanager.cs (TypeManager.CheckStructCycles): New public
2887 static method to check for cycles in the struct layout.
2889 * rootcontext.cs (RootContext.PopulateTypes): Call
2890 TypeManager.CheckStructCycles() for each TypeContainer.
2891 [Note: We only need to visit each type once.]
2893 2004-04-28 Martin Baulig <martin@ximian.com>
2895 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2897 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2898 success and added `out object value'. Use a `bool resolved' field
2899 to check whether we've already been called rather than
2900 `ConstantValue != null' since this breaks for NullLiterals.
2902 2004-04-28 Raja R Harinath <rharinath@novell.com>
2904 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2905 setting of this flag, since the 'set' method may be non-public.
2907 2004-04-28 Raja R Harinath <rharinath@novell.com>
2909 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2910 check on current_vector.Block.
2912 2004-04-27 Martin Baulig <martin@ximian.com>
2914 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2915 a field initializer. Fixes #56459.
2917 2004-04-27 Martin Baulig <martin@ximian.com>
2919 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2920 we're not attempting to use an indexer. Fixes #52154.
2922 2004-04-27 Martin Baulig <martin@ximian.com>
2924 * statement.cs (Return): Don't create a return label if we don't
2925 need it; reverts my change from January 20th. Thanks to Ben
2928 2004-04-27 Martin Baulig <martin@ximian.com>
2930 According to the spec, `goto' can only leave a nested scope, but
2933 * statement.cs (Block.LookupLabel): Only lookup in the current
2934 block, don't recurse into parent or child blocks.
2935 (Block.AddLabel): Check in parent and child blocks, report
2936 CS0140/CS0158 if we find a duplicate.
2937 (Block): Removed this indexer for label lookups.
2938 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2939 this already does the error reporting for us.
2942 (FlowBranching.UsageVector.Block): New public variable; may be null.
2943 (FlowBranching.CreateSibling): Added `Block' argument.
2944 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2945 label for the target of a `goto' and check whether we're not
2946 leaving a `finally'.
2948 2004-04-27 Martin Baulig <martin@ximian.com>
2950 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2951 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2954 2004-04-27 Martin Baulig <martin@ximian.com>
2956 * statement.cs (Block.AddLabel): Also check for implicit blocks
2957 and added a CS0158 check.
2959 2004-04-27 Martin Baulig <martin@ximian.com>
2961 * flowanalysis.cs (FlowBranchingLoop): New class.
2962 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2963 UsageVector's instead of an ArrayList.
2964 (FlowBranching.Label): Likewise.
2965 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2966 (FlowBranching.AddBreakVector): New method.
2968 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2970 * attribute.cs: Small regression fix: only convert the type if we
2971 the type is different, fixes System.Drawing build.
2973 2004-04-27 Martin Baulig <martin@ximian.com>
2975 * attribute.cs (Attribute.Resolve): If we have a constant value
2976 for a named field or property, implicity convert it to the correct
2979 2004-04-27 Raja R Harinath <rharinath@novell.com>
2981 * statement.cs (Block.Block): Implicit blocks share
2982 'child_variable_names' fields with parent blocks.
2983 (Block.AddChildVariableNames): Remove.
2984 (Block.AddVariable): Mark variable as "used by a child block" in
2985 every surrounding block.
2986 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2987 been used in a child block, complain about violation of "Invariant
2988 meaning in blocks" rule.
2989 * cs-parser.jay (declare_local_variables): Don't use
2990 AddChildVariableNames.
2991 (foreach_statement): Don't create an implicit block: 'foreach'
2994 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2996 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2997 converting from 0L to ulong. Fixes 57522.
2999 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3001 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3002 derived class hides via 'new' keyword field from base class (test-242.cs).
3003 TODO: Handle this in the more general way.
3005 * class.cs (CheckBase): Ditto.
3007 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3009 * decl.cs (caching_flags): New member for storing cached values
3011 (MemberCore.Flags): New enum where bit flags for caching_flags
3013 (MemberCore.cls_compliance): Moved to caching_flags.
3014 (DeclSpace.Created): Moved to caching_flags.
3016 * class.cs: Use caching_flags instead of DeclSpace.Created
3018 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3020 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3021 if we are only a derived class, not a nested class.
3023 * typemanager.cs: Same as above, but do this at the MemberLookup
3024 level (used by field and methods, properties are handled in
3025 PropertyExpr). Allow for the qualified access if we are a nested
3028 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3030 * class.cs: Refactoring.
3031 (IMethodData): New inteface; Holds links to parent members
3032 to avoid member duplication (reduced memory allocation).
3033 (Method): Implemented IMethodData interface.
3034 (PropertyBase): New inner classes for get/set methods.
3035 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3036 (Event): New inner classes for add/remove methods.
3037 (Event.DelegateMethod): Implemented IMethodData interface.
3039 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3040 EmitContext (related to class.cs refactoring).
3042 2004-04-21 Raja R Harinath <rharinath@novell.com>
3044 * delegate.cs (Delegate.VerifyApplicability): If the number of
3045 arguments are the same as the number of parameters, first try to
3046 verify applicability ignoring any 'params' modifier on the last
3050 2004-04-16 Raja R Harinath <rharinath@novell.com>
3052 * class.cs (TypeContainer.AddIndexer): Use
3053 'ExplicitInterfaceName' to determine if interface name was
3054 explicitly specified. 'InterfaceType' is not initialized at this time.
3055 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3056 Indexers array is already in the required order. Initialize
3057 'IndexerName' only if there are normal indexers.
3058 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3059 (TypeContainer.Emit): Emit DefaultMember attribute only if
3060 IndexerName is initialized.
3063 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3065 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3068 2004-04-15 Raja R Harinath <rharinath@novell.com>
3070 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3074 * attribute.cs (Attribute.Resolve): Check for duplicate named
3078 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3080 * iterators.cs (MarkYield): track whether we are in an exception,
3081 and generate code accordingly. Use a temporary value to store the
3082 result for our state.
3084 I had ignored a bit the interaction of try/catch with iterators
3085 since their behavior was not entirely obvious, but now it is
3086 possible to verify that our behavior is the same as MS .NET 2.0
3090 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3092 * iterators.cs: Avoid creating temporaries if there is no work to
3095 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3096 Enumerations, use TypeManager.EnumToUnderlying and call
3099 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3102 (This.Emit): Use EmitContext.EmitThis to emit our
3105 (This.EmitAssign): Ditto.
3107 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3108 codepaths, we will move all the functionality into
3111 (FieldExpr.EmitAssign): Ditto.
3113 This fixes several hidden bugs that I uncovered while doing a code
3114 review of this today.
3116 * codegen.cs (EmitThis): reworked so the semantics are more clear
3117 and also support value types "this" instances.
3119 * iterators.cs: Changed so that for iterators in value types, we
3120 do not pass the value type as a parameter.
3122 Initialization of the enumerator helpers is now done in the caller
3123 instead of passing the parameters to the constructors and having
3124 the constructor set the fields.
3126 The fields have now `assembly' visibility instead of private.
3128 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3130 * expression.cs (Argument.Resolve): Check if fields passed as ref
3131 or out are contained in a MarshalByRefObject.
3133 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3134 another compiler type.
3136 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3138 * class.cs (Indexer.Define): use the new name checking method.
3139 Also, return false on an error.
3140 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3141 (is_identifier_[start/part]_character): make static.
3143 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3145 * expression.cs (Binary.ResolveOperator): Do no append strings
3146 twice: since we can be invoked more than once (array evaluation)
3147 on the same concatenation, take care of this here. Based on a fix
3148 from Ben (bug #56454)
3150 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3152 * codegen.cs: Fix another case where CS1548 must be reported (when
3153 delay-sign isn't specified and no private is available #56564). Fix
3154 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3155 error when MCS is used on the MS runtime and we need to delay-sign
3156 (which seems unsupported by AssemblyBuilder - see #56621).
3158 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3160 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3161 (TypeManager.ComputeNamespaces): Faster implementation for
3164 * compiler.csproj: Updated AssemblyName to mcs.
3166 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3168 * rootcontext.cs: Add new types to the boot resolution.
3170 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3171 MulticastDelegate is not allowed.
3173 * typemanager.cs: Add new types to lookup: System.TypedReference
3176 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3177 check for TypedReference or ArgIterator, they are not allowed.
3179 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3180 makes us properly catch 1510 in some conditions (see bug 56016 for
3183 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3185 * CryptoConvert.cs: update from corlib version
3188 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3190 * class.cs (Indexer.Define): Check indexername declaration
3192 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3194 * attribute.cs (IsClsCompliant): Fixed problem with handling
3195 all three states (compliant, not-compliant, undetected).
3197 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3199 * attribute.cs (Attribute): Location is now public.
3200 (Resolve): Store resolved arguments (pos_values) in attribute class.
3201 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3202 (GetClsCompliantAttributeValue): New method that gets
3203 CLSCompliantAttribute value.
3204 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3205 if exists else null.
3206 (AttributeTester): New class for CLS-Compliant verification routines.
3208 * class.cs (Emit): Add CLS-Compliant verification.
3209 (Method.GetSignatureForError): Implemented.
3210 (Constructor.GetSignatureForError): Implemented
3211 (Constructor.HasCompliantArgs): Returns if constructor has
3212 CLS-Compliant arguments.
3213 (Constructor.Emit): Override.
3214 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3215 is needed to test only parameters.
3216 (FieldBase.GetSignatureForError): Implemented.
3217 (TypeContainer): New member for storing base interfaces.
3218 (TypeContainer.FindMembers): Search in base interfaces too.
3220 * codegen.cs (GetClsComplianceAttribute): New method that gets
3221 assembly or module CLSCompliantAttribute value.
3222 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3224 (ModuleClass.Emit): Add error 3012 test.
3226 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3228 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3229 state for all decl types.
3230 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3231 if CLS-Compliant tests are required.
3232 (IsClsCompliaceRequired): New method. Analyze whether code
3233 must be CLS-Compliant.
3234 (IsExposedFromAssembly): New method. Returns true when MemberCore
3235 is exposed from assembly.
3236 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3237 value or gets cached value.
3238 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3239 is explicitly marked with CLSCompliantAttribute.
3240 (IsIdentifierClsCompliant): New abstract method. This method is
3241 used to testing error 3005.
3242 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3243 for identifier and parameters CLS-Compliant testing.
3244 (VerifyClsCompliance): New method. The main virtual method for
3245 CLS-Compliant verifications.
3246 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3247 null. I don't know why is null (too many public members !).
3248 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3249 and get value of first CLSCompliantAttribute that found.
3251 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3252 (VerifyClsCompliance): Override and add extra tests.
3254 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3255 clscheck- disable CLS-Compliant verification event if assembly is has
3256 CLSCompliantAttribute(true).
3258 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3259 ApllyAttribute is now called in emit section as in the other cases.
3260 Possible future Emit integration.
3261 (IsIdentifierClsCompliant): New override.
3262 (VerifyClsCompliance): New override.
3263 (GetEnumeratorName): Returns full enum name.
3265 * parameter.cs (GetSignatureForError): Implemented.
3267 * report.cs (WarningData): New struct for Warning message information.
3268 (LocationOfPreviousError): New method.
3269 (Warning): New method. Reports warning based on the warning table.
3270 (Error_T): New method. Reports error based on the error table.
3272 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3273 verifications are done here.
3275 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3277 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3278 CLSCompliantAttribute.
3279 (all_imported_types): New member holds all imported types from other
3281 (LoadAllImportedTypes): New method fills static table with exported types
3282 from all referenced assemblies.
3283 (Modules): New property returns all assembly modules.
3285 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3287 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3288 throwing a parser error.
3290 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3291 which removes the hardcoded get_/set_ prefixes for properties, as
3292 IL allows for the properties to be named something else.
3296 * expression.cs: Do not override operand before we know if it is
3299 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3301 * typemanager.cs: support for pinned variables.
3303 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3305 * decl.cs, typemanager.cs: Avoid using an arraylist
3306 as a buffer if there is only one result set.
3308 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3310 * expression.cs: Make sure you cant call a static method
3311 with an instance expression, bug #56174.
3313 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3315 * class.cs (IsDuplicateImplementation): Improve error reporting to
3316 flag 663 (method only differs in parameter modifier).
3318 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3319 in preprocessor directives.
3321 * location.cs (LookupFile): Allow for the empty path.
3323 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3324 better approach for some of that patch, but its failing with the
3325 CharSet enumeration. For now try/catch will do.
3327 * typemanager.cs: Do not crash if a struct does not have fields.
3330 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3332 * expression.cs: cs0213, cant fix a fixed expression.
3335 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3337 * cs-parser.jay: detect invalid embeded statements gracefully.
3340 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3342 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3345 the invocation type may not be a subclass of the tye of the item/
3346 The type of the item must be a subclass of the invocation item.
3351 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3353 * attribute.cs: Added methods to get a string and a bool from an
3354 attribute. Required to information from AssemblyKeyFileAttribute,
3355 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3356 * codegen.cs: Modified AssemblyName creation to include support for
3357 strongnames. Catch additional exceptions to report them as CS1548.
3358 * compiler.csproj: Updated include CryptoConvert.cs.
3359 * compiler.csproj.user: Removed file - user specific configuration.
3360 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3361 Mono.Security assembly. The original class is maintained and tested in
3362 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3363 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3364 like CSC 8.0 (C# v2) supports.
3365 * Makefile: Added CryptoConvert.cs to mcs sources.
3366 * rootcontext.cs: Added new options for strongnames.
3368 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3370 * driver.cs: For --expect-error, report error code `2'
3371 if the program compiled with no errors, error code `1' if
3372 it compiled with an error other than the one expected.
3374 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3376 * compiler.csproj: Updated for Visual Studio .NET 2003.
3377 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3378 * compiler.sln: Updated for Visual Studio .NET 2003.
3380 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3382 * expression.cs: Fix bug #47234. We basically need to apply the
3383 rule that we prefer the conversion of null to a reference type
3384 when faced with a conversion to 'object' (csc behaviour).
3386 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3388 * statement.cs: Shorter form for foreach, eliminates
3389 a local variable. r=Martin.
3391 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3393 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3394 checks if we can use brtrue/brfalse to test for 0.
3395 * expression.cs: use the above in the test for using brtrue/brfalse.
3398 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3400 * expression.cs: Rewrite string concat stuff. Benefits:
3402 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3403 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3404 rather than a concat chain.
3406 * typemanager.cs: Add lookups for more concat overloads.
3408 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3410 * expression.cs: Emit shorter il code for array init.
3427 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3429 * statement.cs: Before, two switch blocks would be merged if the
3430 total size of the blocks (end_item - begin_item + 1) was less than
3431 two times the combined sizes of the blocks.
3433 Now, it will only merge if after the merge at least half of the
3438 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3440 * class.cs : csc build fix for GetMethods(). See bug #52503.
3442 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3444 * expression.cs: Make sure fp comparisons work with NaN.
3445 This fixes bug #54303. Mig approved this patch a long
3446 time ago, but we were not able to test b/c the runtime
3449 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3451 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3453 2004-03-19 Martin Baulig <martin@ximian.com>
3455 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3456 error here and not in our caller.
3458 2004-03-19 Martin Baulig <martin@ximian.com>
3460 * interface.cs: Completely killed this file.
3461 (Interface): We're now a TypeContainer and live in class.cs.
3463 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3464 argument; we're now also called for interfaces.
3465 (TypeContainer.DefineMembers): Allow this method being called
3467 (TypeContainer.GetMethods): New public method; formerly known as
3468 Interface.GetMethod(). This is used by PendingImplementation.
3469 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3470 it's now private and non-static.
3471 (Interface): Moved this here; it's now implemented similar to
3473 (Method, Property, Event, Indexer): Added `bool is_interface'
3474 argument to their .ctor's.
3475 (MemberBase.IsInterface): New public field.
3477 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3478 instances instead of InterfaceMethod, InterfaceProperty, etc.
3479 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3480 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3482 2004-03-19 Martin Baulig <martin@ximian.com>
3484 * class.cs (MethodCore.IsDuplicateImplementation): New private
3485 method which does the CS0111 checking.
3486 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3487 Use IsDuplicateImplementation().
3489 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3491 * decl.cs (FindMemberToOverride): New method to find the correct
3492 method or property to override in the base class.
3494 - Make Method/Property use the above method to find the
3495 version in the base class.
3496 - Remove the InheritableMemberSignatureCompare as it is now
3499 This patch makes large code bases much faster to compile, as it is
3500 O(n) rather than O(n^2) to do this validation.
3502 Also, it fixes bug 52458 which is that nested classes are not
3503 taken into account when finding the base class member.
3505 Reviewed/Approved by Martin.
3507 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3509 * interface.cs: In all interface classes removed redundant
3510 member initialization.
3512 2004-03-16 Martin Baulig <martin@ximian.com>
3514 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3516 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3518 * decl.cs (DefineTypeAndParents): New helper method to define a
3519 type's containers before the type itself is defined; This is a
3520 bug exposed by the recent changes to Windows.Forms when an
3521 implemented interface was defined inside a class that had not been
3524 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3526 (Check): Loop correctly to report errors modifiers
3527 (UNSAFE was not in the loop, since it was the same as TOP).
3529 * interface.cs: Every interface member now takes a ModFlags,
3530 instead of a "is_new" bool, which we set on the base MemberCore.
3532 Every place where we called "UnsafeOk" in the interface, now we
3533 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3534 the unsafe settings from the member declaration instead of the
3535 container interface.
3537 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3539 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3540 `set_indexer_name' to the pending bits (one per type).
3542 We fixed a bug today that was picking the wrong method to
3543 override, since for properties the existing InterfaceMethod code
3544 basically ignored the method name. Now we make sure that the
3545 method name is one of the valid indexer names.
3547 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3549 * support.cs (SeekableStreamReader): Keep track of stream byte
3550 positions and don't mix them with character offsets to the buffer.
3552 Patch from Gustavo Giráldez
3554 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3556 * interface.cs (InterfaceSetGetBase): Removed double member
3557 initialization, base class does it as well.
3559 2004-03-13 Martin Baulig <martin@ximian.com>
3561 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3562 when compiling corlib.
3564 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3566 * convert.cs (ExplicitConversion): We were reporting an error on
3567 certain conversions (object_type source to a value type, when the
3568 expression was `null') before we had a chance to pass it through
3569 the user defined conversions.
3571 * driver.cs: Replace / and \ in resource specifications to dots.
3574 * class.cs: Add check for duplicate operators. Fixes 52477
3576 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3578 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
3579 that are in the middle of the statements, not only at the end.
3582 * class.cs (TypeContainer.AddField): No longer set the
3583 `HaveStaticConstructor' flag, now we call it
3584 `UserDefineStaticConstructor' to diferentiate the slightly
3585 semantic difference.
3587 The situation is that we were not adding BeforeFieldInit (from
3588 Modifiers.TypeAttr) to classes that could have it.
3589 BeforeFieldInit should be set to classes that have no static
3594 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
3596 And most importantly Zoltan's comment:
3598 http://bugzilla.ximian.com/show_bug.cgi?id=44229
3600 "I think beforefieldinit means 'it's ok to initialize the type sometime
3601 before its static fields are used', i.e. initialization does not need
3602 to be triggered by the first access to the type. Setting this flag
3603 helps the JIT to compile better code, since it can run the static
3604 constructor at JIT time, and does not need to generate code to call it
3605 (possibly lots of times) at runtime. Unfortunately, mcs does not set
3606 this flag for lots of classes like String.
3608 csc sets this flag if the type does not have an explicit static
3609 constructor. The reasoning seems to be that if there are only static
3610 initalizers for a type, and no static constructor, then the programmer
3611 does not care when this initialization happens, so beforefieldinit
3614 This bug prevents the AOT compiler from being usable, since it
3615 generates so many calls to mono_runtime_class_init that the AOT code
3616 is much slower than the JITted code. The JITted code is faster,
3617 because it does not generate these calls if the vtable is type is
3618 already initialized, which is true in the majority of cases. But the
3619 AOT compiler can't do this."
3621 2004-03-10 Miguel de Icaza <miguel@ximian.com>
3623 * class.cs (MethodData.Emit): Refactor the code so symbolic
3624 information is generated for destructors; For some reasons we
3625 were taking a code path that did not generate symbolic information
3628 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
3630 * class.cs: Create a Constructor.CheckBase method that
3631 takes care of all validation type code. The method
3632 contains some code that was moved from Define.
3634 It also includes new code that checks for duplicate ctors.
3635 This fixes bug #55148.
3637 2004-03-09 Joshua Tauberer <tauberer@for.net>
3639 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
3640 a { ... }-style array creation invokes EmitStaticInitializers
3641 which is not good for reference-type arrays. String, decimal
3642 and now null constants (NullCast) are not counted toward
3643 static initializers.
3645 2004-03-05 Martin Baulig <martin@ximian.com>
3647 * location.cs (SourceFile.HasLineDirective): New public field;
3648 specifies whether the file contains or is referenced by a "#line"
3650 (Location.DefineSymbolDocuments): Ignore source files which
3651 either contain or are referenced by a "#line" directive.
3653 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
3655 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
3656 direct access to our parent, so check the method inline there.
3658 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
3660 * expression.cs (Invocation.EmitCall): Miguel's last commit
3661 caused a regression. If you had:
3666 In Foo the implict this would be null.
3668 2004-02-27 Miguel de Icaza <miguel@ximian.com>
3670 * expression.cs (Invocation.EmitCall): If the method is not
3671 virtual, do not emit a CallVirt to it, use Call.
3673 * typemanager.cs (GetFullNameSignature): Improve the method to
3674 cope with ".ctor" and replace it with the type name.
3676 * class.cs (ConstructorInitializer.Resolve): Now the method takes
3677 as an argument the ConstructorBuilder where it is being defined,
3678 to catch the recursive constructor invocations.
3680 2004-02-26 Miguel de Icaza <miguel@ximian.com>
3682 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
3683 routines to check if a type is an enumerable/enumerator allow
3684 classes that implement the IEnumerable or IEnumerator interfaces.
3686 * class.cs (Property, Operator): Implement IIteratorContainer, and
3687 implement SetYields.
3689 (Property.Define): Do the block swapping for get_methods in the
3690 context of iterators. We need to check if Properties also
3691 include indexers or not.
3693 (Operator): Assign the Block before invoking the
3694 OperatorMethod.Define, so we can trigger the Iterator code
3697 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
3698 Property and Operator classes are not created when we parse the
3699 declarator but until we have the block completed, so we use a
3700 singleton SimpleIteratorContainer.Simple to flag whether the
3701 SetYields has been invoked.
3703 We propagate this setting then to the Property or the Operator to
3704 allow the `yield' to function.
3706 2004-02-25 Marek Safar <marek.safar@seznam.cz>
3708 * codegen.cs: Implemented attribute support for modules.
3709 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
3710 Assembly/Module functionality.
3712 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
3713 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
3714 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
3716 2004-02-16 Marek Safar <marek.safar@seznam.cz>
3718 * interface.cs (FindMembers): The operation is performed on all base
3719 interfaces and not only on the first. It is required for future CLS Compliance patch.
3721 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
3723 * statement.cs, codegen.cs:
3724 This patch deals with patterns such as:
3726 public class List : IEnumerable {
3728 public MyEnumerator GetEnumerator () {
3729 return new MyEnumerator(this);
3732 IEnumerator IEnumerable.GetEnumerator () {
3736 public struct MyEnumerator : IEnumerator {
3741 Before, there were a few things we did wrong:
3742 1) we would emit callvirt on a struct, which is illegal
3743 2) we emited ldarg when we needed to emit ldarga
3744 3) we would mistakenly call the interface methods on an enumerator
3745 type that derived from IEnumerator and was in another assembly. For example:
3747 public class MyEnumerator : IEnumerator
3749 Would have the interface methods called, even if there were public impls of the
3750 method. In a struct, this lead to invalid IL code.
3752 2004-02-11 Marek Safar <marek.safar@seznam.cz>
3754 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
3757 * delegate.cs (Define): Fixed crash when delegate type is undefined.
3759 2004-02-11 Miguel de Icaza <miguel@ximian.com>
3761 * cs-parser.jay: Fix small regression: we were not testing V2
3762 compiler features correctly.
3764 * interface.cs: If the emit context is null, then create one
3766 2004-02-09 Marek Safar <marek.safar@seznam.cz>
3768 * decl.cs (GetSignatureForError): New virtual method to get full name
3771 * attribute.cs (IAttributeSupport): New interface for attribute setting.
3772 Now it is possible to rewrite ApplyAttributes method to be less if/else.
3774 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
3775 Duplicated members and code in these classes has been removed.
3776 Better encapsulation in these classes.
3778 2004-02-07 Miguel de Icaza <miguel@ximian.com>
3780 * assign.cs (Assign.DoResolve): When dealing with compound
3781 assignments, there is a new rule in ECMA C# 2.4 (might have been
3782 there before, but it is documented here) that states that in:
3786 If b is of type int, and the `op' is a shift-operator, then the
3787 above is evaluated as:
3791 * expression.cs (Binary.ResolveOperator): Instead of testing for
3792 int/uint/long/ulong, try to implicitly convert to any of those
3793 types and use that in pointer arithmetic.
3795 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
3796 method to print information for from the type, not from the
3797 null-method we were given.
3799 2004-02-01 Duncan Mak <duncan@ximian.com>
3801 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
3802 parsing for cmd, fixes bug #53694.
3804 2004-02-04 Marek Safar <marek.safar@seznam.cz>
3806 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
3807 in the member name duplication tests. Property and operator name duplication
3808 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
3810 2004-02-03 Marek Safar <marek.safar@seznam.cz>
3812 * interface.cs (PopulateMethod): Fixed crash when interface method
3813 returns not existing type (error test cs0246-3.cs).
3815 2004-02-02 Ravi Pratap M <ravi@ximian.com>
3817 * cs-parser.jay (interface_accessors): Re-write actions to also
3818 store attributes attached to get and set methods. Fix spelling
3821 (inteface_property_declaration): Modify accordingly.
3823 (InterfaceAccessorInfo): New helper class to store information to pass
3824 around between rules that use interface_accessors.
3826 * interface.cs (Emit): Apply attributes on the get and set
3827 accessors of properties and indexers too.
3829 * attribute.cs (ApplyAttributes): Modify accordingly to use the
3830 right MethodBuilder when applying attributes to the get and set accessors.
3832 2004-01-31 Miguel de Icaza <miguel@ximian.com>
3834 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
3836 2004-01-26 Miguel de Icaza <miguel@ximian.com>
3838 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
3840 2004-01-25 Miguel de Icaza <miguel@ximian.com>
3842 * cs-parser.jay: Remove YIELD token, instead use the new grammar
3843 changes that treat `yield' specially when present before `break'
3846 * cs-tokenizer.cs: yield is no longer a keyword.
3848 2004-01-23 Marek Safar <marek.safar@seznam.cz>
3850 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
3851 setting for default constructors.
3852 For default constructors are almost every time set wrong Modifier. The
3853 generated IL code has been alright. But inside mcs this values was
3854 wrong and this was reason why several of my CLS Compliance tests
3857 2004-01-22 Martin Baulig <martin@ximian.com>
3859 * cs-parser.jay (namespace_or_type_name): Return an Expression,
3860 not a QualifiedIdentifier. This is what `type_name_expression'
3861 was previously doing.
3862 (type_name_expression): Removed; the code is now in
3863 `namespace_or_type_name'.
3864 (qualified_identifier): Removed, use `namespace_or_type_name'
3866 (QualifiedIdentifier): Removed this class.
3868 2004-01-22 Martin Baulig <martin@ximian.com>
3870 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
3871 not a string as alias name.
3873 2004-01-21 Miguel de Icaza <miguel@ximian.com>
3875 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
3876 #52730 bug, and instead compute correctly the need to use a
3877 temporary variable when requesting an address based on the
3878 static/instace modified of the field and the constructor.
3880 2004-01-21 Martin Baulig <martin@ximian.com>
3882 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
3883 class and namespace before looking up aliases. Fixes #52517.
3885 2004-01-21 Martin Baulig <martin@ximian.com>
3887 * flowanalysis.cs (UsageVector.Merge): Allow variables being
3888 assinged in a 'try'; fixes exception4.cs.
3890 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3891 * class.cs : Implemented parameter-less constructor for TypeContainer
3893 * decl.cs: Attributes are now stored here. New property OptAttributes
3895 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
3897 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
3899 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3901 * typemanager.cs (CSharpSignature): Now reports also inner class name.
3902 (CSharpSignature): New method for indexer and property signature.
3904 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3906 * pending.cs (IsVirtualFilter): Faster implementation.
3908 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3910 * typemanager.cs: Avoid inclusion of same assembly more than once.
3912 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3914 * cs-parser.jay: Fixed problem where the last assembly attribute
3915 has been applied also to following declaration (class, struct, etc.)
3917 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3919 * class.cs: Added error CS0538, CS0539 reporting.
3920 Fixed crash on Microsoft runtime when field type is void.
3922 * cs-parser.jay: Added error CS0537 reporting.
3924 * pending.cs: Added error CS0535 reporting.
3925 Improved error report for errors CS0536, CS0534.
3927 2004-01-20 Miguel de Icaza <miguel@ximian.com>
3929 Merge a few bits from the Anonymous Method MCS tree.
3931 * statement.cs (ToplevelBlock): New class for toplevel methods,
3932 will hold anonymous methods, lifted variables.
3934 * cs-parser.jay: Create toplevel blocks for delegates and for
3935 regular blocks of code.
3937 2004-01-20 Martin Baulig <martin@ximian.com>
3939 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
3940 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
3941 and `NeedExplicitReturn'; added `IsLastStatement'.
3942 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
3943 have a `ReturnLabel' or we're not unreachable.
3945 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
3946 child's reachability; don't just override ours with it. Fixes
3947 #58058 (lluis's example).
3948 (FlowBranching): Added public InTryOrCatch(), InCatch(),
3949 InFinally(), InLoop(), InSwitch() and
3950 BreakCrossesTryCatchBoundary() methods.
3952 * statement.cs (Return): Do all error checking in Resolve().
3953 Unless we are the last statement in a top-level block, always
3954 create a return label and jump to it.
3955 (Break, Continue): Do all error checking in Resolve(); also make
3956 sure we aren't leaving a `finally'.
3957 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
3958 statement in a top-level block.
3959 (Block.Flags): Added `IsDestructor'.
3960 (Block.IsDestructor): New public property.
3962 2004-01-20 Martin Baulig <martin@ximian.com>
3964 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
3966 2004-01-20 Martin Baulig <martin@ximian.com>
3968 * statement.cs (Statement.ResolveUnreachable): New public method.
3969 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
3970 (Block.Resolve): Resolve unreachable statements.
3972 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3974 * expression.cs: We need to fix the case where we do
3975 not have a temp variable here.
3977 * assign.cs: Only expression compound assignments need
3978 temporary variables.
3980 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3982 * flowanalysis.cs: Reduce memory allocation in a few ways:
3983 - A block with no variables should not allocate a bit
3985 - A method with no out parameters does not need any tracking
3986 for assignment of the parameters, so we need not allocate
3989 public readonly Type[] VariableTypes;
3990 public readonly string[] VariableNames;
3991 Are redundant. The data is already stored in the variable
3992 map, so we need not allocate another array for it.
3993 - We need to add alot of checks for if (params | locals) == null
3994 due to the first two changes.
3996 2004-01-18 Miguel de Icaza <miguel@ximian.com>
3998 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
3999 implement IMemoryLocation, we store a copy on a local variable and
4000 take the address of it. Patch from Benjamin Jemlich
4002 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4003 to use a special "type_name_expression" rule which reduces the
4004 number of "QualifiedIdentifier" classes created, and instead
4005 directly creates MemberAccess expressions.
4007 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4009 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4010 that fixes #52853. Null literal assignment to ValueType
4012 * class.cs (MethodData.Emit): Instead of checking the name of the
4013 method to determine if its a destructor, create a new derived
4014 class from Method called Destructor, and test for that.
4016 * cs-parser.jay: Create a Destructor object instead of a Method.
4018 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4022 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4024 * expression.cs (Binary.ResolveOperator): Perform an implicit
4025 conversion from MethodGroups to their delegate types on the
4028 * delegate.cs: Introduce a new class DelegateCreation that is the
4029 base class for `NewDelegate' and `ImplicitDelegateCreation',
4030 factor some code in here.
4032 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4033 conversion from MethodGroups to compatible delegate types.
4035 * ecore.cs (Expression.Resolve): Do not flag error 654
4036 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4037 we allow conversions from MethodGroups to delegate types now.
4039 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4040 assignments in v2 either.
4042 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4044 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4045 static read-only fields in ctors.
4047 Applied patch from Benjamin Jemlich
4049 * expression.cs (UnaryMutator): Avoid leaking local variables.
4051 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4053 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4054 here to return true, as they can be used like this:
4058 Fixed 49836 and all the other dups
4060 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4062 * driver.cs: Implement /win32res and /win32icon.
4064 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4066 * cs-parser.jay: Add a rule to improve error handling for the
4067 common mistake of placing modifiers after the type.
4069 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4071 * cs-parser.jay (interface_event_declaration): Catch
4072 initialization of events on interfaces, and report cs0068
4074 * cs-parser.jay (interface_event_declaration): Catch
4075 initialization of events.
4077 * ecore.cs: Better report missing constructors.
4079 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4080 the error reporting done in the wrong place. Fix.
4082 * expression.cs (Binary.ResolveOperator): Catch the
4083 operator + (E x, E y) error earlier, and later allow for implicit
4084 conversions in operator +/- (E e, U x) from U to the underlying
4087 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4088 52596, if the container class is abstract, the default constructor
4089 is protected otherwise its public (before, we were always public).
4091 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4094 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4095 Jemlich that fixes bug #52597, MCS was generating invalid code for
4096 idisposable structs. Thanks to Ben for following up with this
4099 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4101 * driver.cs: Allow assemblies without code to be generated, fixes
4104 2004-01-07 Nick Drochak <ndrochak@gol.com>
4106 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4108 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4110 * cs-parser.jay: Add rules to improve error reporting if fields or
4111 methods are declared at the namespace level (error 116)
4113 * Add rules to catch event add/remove
4115 2004-01-04 David Sheldon <dave-mono@earth.li>
4117 * expression.cs: Added matching ")" to error message for
4120 2004-01-03 Todd Berman <tberman@gentoo.org>
4122 * ecore.cs, attribute.cs:
4123 Applying fix from #52429.
4125 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4127 * ecore.cs, expression.cs, statement.cs:
4128 Total rewrite of how we handle branching. We
4129 now handle complex boolean expressions with fewer
4130 jumps. As well if (x == 0) no longer emits a ceq.
4132 if (x is Foo) is much faster now, because we generate
4135 Overall, we get a pretty big improvement on our benchmark
4136 tests. The code we generate is smaller and more readable.
4138 I did a full two-stage bootstrap. The patch was reviewed
4139 by Martin and Miguel.
4141 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4143 * cs-parser.jay: Make primary_expression not take a QI.
4144 we dont need this because the member_access rule covers
4145 us here. So we replace the rule with just IDENTIFIER.
4147 This has two good effects. First, we remove a s/r conflict.
4148 Second, we allocate many fewer QualifiedIdentifier objects.
4150 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4152 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4153 set the correct information via SRE. This prevents
4154 hanging on the MS runtime. Fixes #29374.
4156 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4158 * convert.cs: correctly handle conversions to value types
4159 from Enum and ValueType as unboxing conversions.
4161 Fixes bug #52569. Patch by Benjamin Jemlich.
4163 2004-01-02 Ravi Pratap <ravi@ximian.com>
4165 * expression.cs (BetterConversion): Prefer int -> uint
4166 over int -> ulong (csc's behaviour). This fixed bug #52046.
4168 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4170 * decl.cs (MemberCache.FindMembers): now returns a
4173 * typemanager.cs: In general, go with with ^^.
4174 (CopyNewMethods): take an IList.
4175 (RealMemberLookup): Only allocate an arraylist
4176 if we copy from two sets of methods.
4178 This change basically does two things:
4179 1) Fewer array lists allocated due to CopyNewMethods.
4180 2) the explicit cast in MemberList costed ALOT.
4182 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4184 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4185 a hashtable to avoid needless string allocations when an identifier is
4186 used more than once (the common case).
4188 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4190 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4191 is broken, it will not return anything. So, we
4192 have to use the information we have in mcs to
4195 * typemanager.cs: Add a cache for GetInterfaces,
4196 since this will now be used more often (due to ^^)
4198 (GetExplicitInterfaces) New method that gets the
4199 declared, not effective, interfaces on a type
4200 builder (eg, if you have interface IFoo, interface
4201 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4204 This patch makes MCS able to bootstrap itself on
4207 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4209 * expression.cs: Remove the Nop's that Miguel put
4212 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4214 * report.cs, codegen.cs: Give the real stack trace to
4215 the error when an exception is thrown.
4217 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4219 * decl.cs: only allocate hashtables for ifaces if
4222 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4224 * expression.cs: fix the error from cs0121-2.cs
4225 (a parent interface has two child interfaces that
4226 have a function with the same name and 0 params
4227 and the function is called through the parent).
4229 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4231 * class.cs, rootcontext.cs, typmanager.cs: do not
4234 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4236 * codegen.cs: remove stack for the ec flow branching.
4237 It is already a linked list, so no need.
4239 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4241 * Makefile: Allow custom profiler here.
4243 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4245 * typemanager.cs (LookupType):
4246 - Use a static char [], because split takes
4247 a param array for args, so it was allocating
4249 - Do not store true in a hashtable, it boxes.
4251 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4253 * flowanalysis.cs: bytify common enums.
4255 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4257 * modifiers.cs: Add a new set of flags for the
4258 flags allowed on explicit interface impls.
4259 * cs-parser.jay: catch the use of modifiers in
4260 interfaces correctly.
4261 * class.cs: catch private void IFoo.Blah ().
4263 All related to bug #50572.
4265 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4267 * decl.cs: Rewrite the consistant accessability checking.
4268 Accessability is not linear, it must be implemented in
4269 a tableish way. Fixes #49704.
4271 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4273 * expression.cs: Handle negation in a checked context.
4274 We must use subtraction from zero. Fixes #38674.
4276 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4278 * class.cs: Ignore static void main in DLLs.
4279 * rootcontext.cs: Handle the target type here,
4280 since we are have to access it from class.cs
4281 * driver.cs: account for the above.
4283 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4285 * report.cs: Give line numbers and files if available.
4287 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4289 * driver.cs: Implement /addmodule.
4291 * typemanager.cs: Change 'modules' field so it now contains Modules not
4294 2003-12-20 Martin Baulig <martin@ximian.com>
4296 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4297 (FieldBase.IsAssigned): Removed this field.
4298 (FieldBase.SetAssigned): New public method.
4299 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4301 2003-12-20 Martin Baulig <martin@ximian.com>
4303 * expression.cs (LocalVariableReference.DoResolve): Don't set
4304 `vi.Used' if we're called from DoResolveLValue().
4306 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4307 returns the usage vector it just merged into the current one -
4308 pass this one to UsageWarning().
4309 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4310 of the `EmitContext', don't call this recursively on our children.
4312 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4314 * driver.cs: Implement /target:module.
4316 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4318 * support.cs (CharArrayHashtable): New helper class.
4320 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4321 char arrays, not strings, so we can avoid creating a string in
4322 consume_identifier if the identifier is a keyword.
4324 2003-12-16 Martin Baulig <martin@ximian.com>
4326 * statement.cs (LocalInfo.Assigned): Removed this property.
4327 (LocalInfo.Flags): Removed `Assigned'.
4328 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4329 and uses flow analysis.
4330 (Block.UsageWarning): Made this method private.
4331 (Block.Resolve): Call UsageWarning() if appropriate.
4333 * expression.cs (LocalVariableReference.DoResolve): Always set
4334 LocalInfo.Used here.
4336 2003-12-13 Martin Baulig <martin@ximian.com>
4338 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4339 any value here; we're now using flow analysis to figure out
4340 whether a statement/block returns a value.
4342 2003-12-13 Martin Baulig <martin@ximian.com>
4344 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4346 (FlowBranching.MergeFinally): Don't call
4347 `branching.CheckOutParameters()' here, this is called in
4349 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4350 when adding the `finally' vector.
4352 2003-12-13 Martin Baulig <martin@ximian.com>
4355 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4356 actually work and also fix #48962.
4358 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4360 * decl.cs: Do not check System.Object for nested types,
4361 since we know it does not have any. Big bang for buck:
4366 corlib: 17.99 seconds
4370 corlib: 17.39 seconds
4372 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4374 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4375 time we are returning 0 members, so we save alot here.
4377 2003-12-11 Martin Baulig <martin@ximian.com>
4379 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4380 `MergeChild()', also just take the `FlowBranching' as argument;
4381 call Merge() on it and return the result.
4382 (FlowBranching.Merge): We don't need to do anything if we just
4385 2003-12-11 Martin Baulig <martin@ximian.com>
4387 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4388 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4389 Maurer for this idea.
4391 2003-12-11 Martin Baulig <martin@ximian.com>
4393 * flowanalysis.cs (MergeResult): This class is now gone; we now
4394 use the `UsageVector' for this. The reason for this is that if a
4395 branching just has one sibling, we don't need to "merge" them at
4396 all - that's the next step to do.
4397 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4400 2003-12-11 Martin Baulig <martin@ximian.com>
4402 Reworked flow analyis and made it more precise and bug-free. The
4403 most important change is that we're now using a special `Reachability'
4404 class instead of having "magic" meanings of `FlowReturns'. I'll
4405 do some more cleanups and optimizations and also add some more
4406 documentation this week.
4408 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4409 largely reworked this class.
4410 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4411 the new `Reachability' class instead of having "magic" values here.
4412 (FlowBranching): We're now using an instance of `Reachability'
4413 instead of having separate `Returns', `Breaks' etc. fields.
4415 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4416 based on flow analysis; ignore the return value of block.Emit ().
4418 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4420 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4421 if they are private.
4423 2003-12-09 Martin Baulig <martin@ximian.com>
4425 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4426 call them directly on the UsageVector.
4428 2003-12-09 Martin Baulig <martin@ximian.com>
4430 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4431 Changed return type from `FlowReturns' to `Reachability'.
4433 2003-12-09 Martin Baulig <martin@ximian.com>
4435 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4436 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4437 `Reachable' fields with a single `Reachability' one.
4439 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4441 * class.cs (FindMembers): Remove foreach's.
4454 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4459 This patch does a few things:
4460 1. EmptyStatement is now a singleton, so it is never reallocated.
4461 2. All blah is EmptyStatement constructs have been changed to
4462 blah == EmptyStatement.Value, which is much faster and valid
4463 now that EmptyStatement is a singleton.
4464 3. When resolving a block, rather than allocating a new array for
4465 the non-empty statements, empty statements are replaced with
4466 EmptyStatement.Value
4467 4. Some recursive functions have been made non-recursive.
4468 Mainly the performance impact is from (3), however (1) and (2) are needed for
4469 this to work. (4) does not make a big difference in normal situations, however
4470 it makes the profile look saner.
4475 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4476 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4477 Total memory allocated: 56397 KB
4480 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4481 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4482 Total memory allocated: 55666 KB
4484 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4486 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4487 than the hashtable in a hashtable version
4489 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4490 we always end up concating a string. This results in a huge perf
4491 loss, because many strings have to be tracked by the GC. In this
4492 patch, we first use a hashtable that works with two keys, so that
4493 the strings do not need to be concat'ed.
4504 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4506 * Makefile: Add a new target `do-time' that does a quick and simple
4507 profile, leaving easy to parse output.
4509 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4511 * codegen.cs (Init): Create the dynamic assembly with
4512 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4514 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4516 * support.cs: Make the PtrHashtable use only one
4517 instance of its comparer.
4519 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4521 * typemanager.cs: Fix lookup of GetNamespaces.
4523 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4525 * expression.cs: Removed redundant line.
4527 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4528 ArrayLists, use for loops with bounds.
4530 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4533 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4534 arraylists, use for loop with bounds.
4536 The above three changes give us a 0.071 second performance
4537 improvement out of 3.294 seconds down to 3.223. On my machine
4538 the above changes reduced the memory usage by 1,387 KB during
4541 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4542 QualifiedIdentifiers. Before we created a new string through
4543 concatenation, and mostly later on, the result would be
4544 manipulated by DecomposeQI through string manipulation.
4546 This reduced the compiler memory usage for bootstrapping from
4547 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4548 compile times in 0.05 seconds.
4550 2003-11-28 Dick Porter <dick@ximian.com>
4552 * support.cs: Do string compares with the Invariant culture.
4560 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4561 the comparison is done with the Invariant culture.
4563 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4565 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4566 GetEnumerator method.
4568 (ProbeCollectionType): Iterate starting at the most specific type
4569 upwards looking for a GetEnumerator
4571 * expression.cs: Shift count can be up to 31 for int/uint and 63
4574 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4576 * statement.cs (Block.LookupLabel): Also look for the label on the
4577 children blocks. Use a hash table to keep track of visited
4580 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
4581 we actually did transform the other operand, otherwise fall back
4582 to the common codepath that casts to long.
4584 * cs-tokenizer.cs: Use the same code pattern as the int case.
4585 Maybe I should do the parsing myself, and avoid depending on the
4586 Parse routines to get this done.
4588 2003-11-25 Miguel de Icaza <miguel@ximian.com>
4590 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4591 which fixes bug 51347. This time test it.
4593 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
4594 attributes for example can not tell the difference between these.
4595 The difference was only a syntax feature of the language.
4597 * attribute.cs: Apply attributes to delegates.
4599 * delegate.cs: Call the apply attributes method.
4601 2003-11-24 Miguel de Icaza <miguel@ximian.com>
4603 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
4604 comparing 0 vs Byte.MinValue, not the value
4606 (ImplicitConversionRequired): When reporting a conversion error,
4607 use error 31 to print out the constant error instead of the
4610 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4611 which fixes bug 51347.
4613 2003-11-22 Miguel de Icaza <miguel@ximian.com>
4615 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
4616 which fixes the -warnaserror command line option.
4618 2003-11-21 Miguel de Icaza <miguel@ximian.com>
4620 * cfold.cs (DoNumericPromotions): During constant folding of
4621 additions on UIntConstant, special case intconstants with
4622 IntConstants like we do on the expression binary operator.
4624 2003-11-12 Miguel de Icaza <miguel@ximian.com>
4626 * convert.cs (ImplicitReferenceConversion): We were missing a case
4627 (System.Enum are not value types or class types, so we need to
4628 classify them separatedly).
4630 * driver.cs: We do not support error 2007.
4632 2003-11-12 Jackson Harper <jackson@ximian.com>
4634 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
4635 system directory. Also use the full file name so users can
4636 libraries names mscorlib-o-tron.dll in a non system dir.
4638 2003-11-10 Martin Baulig <martin@ximian.com>
4640 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
4641 (TypeManager.InitCoreTypes): Initialize them here, but instead of
4642 calling `ResolveType()' on them, directly assign their `Type'.
4644 2003-11-08 Martin Baulig <martin@ximian.com>
4646 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
4647 return value and the `out parent' parameter.
4648 (TypeContainer.DefineType): Moved the CS0644 check into
4649 GetClassBases(). Don't pass the interface types to the
4650 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
4651 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
4653 * ecore.cs (TypeExpr.IsAttribute): New property.
4654 (TypeExpr.GetInterfaces): New method.
4656 * interface.cs (Interface.GetInterfaceTypeByName): Return a
4657 TypeExpr instead of a Type.
4658 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
4659 (Interface.DefineType): Don't pass the interface types to the
4660 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
4661 them later and then call `TypeBulider.AddInterfaceImplementation()'.
4663 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
4664 instead of a `Type[]'.
4665 (TypeManager.RegisterBuilder): Likewise.
4666 (TypeManager.AddUserInterface): Likewise.
4667 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
4668 `Type[]' and also return a `TypeExpr[]'.
4669 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
4671 2003-11-08 Martin Baulig <martin@ximian.com>
4673 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
4676 2003-11-08 Martin Baulig <martin@ximian.com>
4678 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
4679 TypeManager.ResolveExpressionTypes().
4681 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
4682 instead of an Expression.
4683 (TypeExpr): This is now an abstract base class for `TypeExpression'.
4684 (TypeExpression): New public class; formerly known as `TypeExpr'.
4686 * expression.cs (ComposedCast): Derive from TypeExpr.
4688 * typemanager.cs (TypeManager.system_*_expr): These are now
4689 TypExpr's instead of Expression's.
4690 (TypeManager.ResolveExpressionTypes): New public static function;
4691 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
4694 2003-11-06 Miguel de Icaza <miguel@ximian.com>
4696 * expression.cs (New.DoResolve): Do not dereference value that
4697 might be a null return.
4699 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
4700 sure that the constant value has the right type. Fixes an
4701 unreported bug, similar to 50425.
4703 * const.cs (Const.LookupConstantValue): Call
4704 ImplicitStandardConversionExists before doing a conversion to
4705 avoid havng the TypeManager.ChangeType do conversions.
4707 Reduced the number of casts used
4709 (Const.ChangeType): New routine to enable reuse of the constant
4710 type changing code from statement.
4712 * typemanager.cs (ChangeType): Move common initialization to
4713 static global variables.
4717 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
4718 every value type to go through, even if it was void. Fix that.
4720 * cs-tokenizer.cs: Use is_identifier_start_character on the start
4721 character of the define, and the is_identifier_part_character for
4722 the rest of the string.
4724 2003-11-05 Miguel de Icaza <miguel@ximian.com>
4726 * expression.cs (UnaryMutator.EmitCode): When I updated
4727 LocalVariableReference.DoResolve, I overdid it, and dropped an
4728 optimization done on local variable references.
4730 2003-11-04 Miguel de Icaza <miguel@ximian.com>
4732 * ecore.cs: Convert the return from Ldlen into an int.
4734 2003-10-20 Miguel de Icaza <miguel@ximian.com>
4736 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
4737 the accessibility, this is a special case for toplevel non-public
4738 classes (internal for instance).
4740 2003-10-20 Nick Drochak <ndrochak@gol.com>
4742 * ecore.cs: Fix typo and build. Needed another right paren.
4744 2003-10-19 Miguel de Icaza <miguel@ximian.com>
4746 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
4747 `internal' case regular and protected, but not allowing protected
4748 to be evaluated later. Bug 49840
4750 2003-10-15 Miguel de Icaza <miguel@ximian.com>
4752 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
4753 to kb.Nlast, and not the kb.nFirst to isolate the switch
4756 Extract the underlying type, so enumerations of long/ulong are
4757 treated like long/ulong.
4759 2003-10-14 Miguel de Icaza <miguel@ximian.com>
4761 * expression.cs (New): Overload the meaning of RequestedType to
4762 track the possible creation of the NewDelegate type, since
4763 DoResolve is invoked more than once for new constructors on field
4766 See bugs: #48800 and #37014
4768 * cs-parser.jay (declare_local_constants): Take an arraylist
4769 instead of a single constant.
4771 (local_constant_declaration): It should take a
4772 constant_declarators, not a constant_declarator. Fixes 49487
4774 * convert.cs: Fix error report.
4776 2003-10-13 Jackson Harper <jackson@ximian.com>
4778 * typemanager.cs (TypeToCoreType): Add float and double this fixes
4781 2003-10-09 Martin Baulig <martin@ximian.com>
4783 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
4785 (MethodCore.DoDefineParameters): Removed the TypeContainer
4786 argument; use the DeclSpace which was passed to the .ctor instead.
4787 (MethodCore.CheckParameter): Take a DeclSpace instead of a
4788 TypeContainer; we only need a DeclSpace here.
4790 2003-10-09 Martin Baulig <martin@ximian.com>
4792 * class.cs (MethodData): Added additional `DeclSpace ds' argument
4794 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
4795 EmitContext's .ctor.
4797 2003-10-09 Martin Baulig <martin@ximian.com>
4799 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
4800 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
4801 AsAccessible(), moved them as well.
4803 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
4805 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
4807 * cs-parser.jay : Renamed yyName to yyNames related to jay.
4809 2003-10-07 Miguel de Icaza <miguel@ximian.com>
4811 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
4812 generation for >=, as spotted by Paolo, bug 48679.
4813 Patch from David Waite.
4815 * cs-tokenizer.cs: Add handling for #pragma.
4817 * cs-parser.jay: Allow for both yield and yield return in the
4818 syntax. The anti-cobolization of C# fight will go on!
4820 * class.cs (TypeBuilder.DefineType): Catch error condition here
4821 (Parent.DefineType erroring out and returning null).
4823 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
4824 coping with enumerations variables, we were mistakenly processing
4825 them as a regular value type instead of built-in types. Fixes the
4828 * typemanager.cs (IsBuiltinOrEnum): New method.
4830 2003-09-30 Miguel de Icaza <miguel@ximian.com>
4832 * cs-parser.jay: Upgrade: yield now needs the return clause.
4834 2003-09-19 Martin Baulig <martin@ximian.com>
4836 * decl.cs (MemberCache.SetupCacheForInterface): Take a
4837 `MemberCache parent' argument. Normally, an interface doesn't
4838 have a parent type except System.Object, but we use this in gmcs
4839 for generic type parameters.
4841 2003-09-18 Martin Baulig <martin@ximian.com>
4843 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
4844 on `type.IsInterface'; don't check whether the type has a parent
4845 to determine whether it's an interface.
4847 2003-09-15 Martin Baulig <martin@ximian.com>
4849 * class.cs (TypeContainer.DefineType): Added an error flag to
4850 avoid reporting duplicate CS0146's ("class definition is
4853 * driver.cs (Driver.MainDriver): Abort if
4854 RootContext.ResolveTree() reported any errors.
4856 2003-09-07 Martin Baulig <martin@ximian.com>
4858 * report.cs (Error, Warning): Added overloaded versions which take
4859 a `params object[] args' and call String.Format().
4861 2003-09-07 Martin Baulig <martin@ximian.com>
4863 * decl.cs (DeclSpace..ctor): Don't call
4864 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
4865 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
4866 (DeclSpace.RecordDecl): New method.
4868 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
4870 2003-09-02 Ravi Pratap <ravi@ximian.com>
4872 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
4873 value attributes to be applied to ParameterBuilders.
4875 * class.cs (MethodCore.LabelParameters): Make static and more
4876 generic so that it can be used from other places - like interface
4877 methods, for instance.
4879 * interface.cs (Interface.Emit): Call LabelParameters before
4880 emitting attributes on the InterfaceMethod.
4882 2003-08-26 Martin Baulig <martin@ximian.com>
4884 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
4885 resolving aliases; fixes #47927.
4887 2003-08-26 Martin Baulig <martin@ximian.com>
4889 * statement.cs (Using.DoResolve): This is internally emitting a
4890 try/finally clause, so we need to set ec.NeedExplicitReturn if we
4891 do not always return. Fixes #47681.
4893 2003-08-26 Martin Baulig <martin@ximian.com>
4895 * decl.cs (MemberCore): Moved WarningNotHiding(),
4896 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
4898 (AdditionResult): Make this nested in DeclSpace.
4899 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
4900 argument; call NamespaceEntry.Define() unless we're nested in a
4903 * namespace.cs (Namespace.DefineName): New public function. This
4904 is called from DeclSpace's .ctor to add
4905 (Namespace.Lookup): Include DeclSpaces in the lookup.
4907 * class.cs (Operator): Derive from MemberBase, not MemberCore.
4909 * const.cs (Const): Derive from MemberBase, not MemberCore.
4911 2003-08-25 Martin Baulig <martin@ximian.com>
4913 * convert.cs (Convert.ExplicitReferenceConversion): When
4914 converting from an interface type to a class, unbox if the target
4915 type is a struct type. Fixes #47822.
4917 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4919 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
4922 2003-08-22 Martin Baulig <martin@ximian.com>
4924 * class.cs (TypeManager.DefineType): When defining a nested type,
4925 call DefineType() on our parent; fixes #47801.
4927 2003-08-22 Martin Baulig <martin@ximian.com>
4929 * class.cs (MethodData.Define): While checking if a method is an
4930 interface implementation, improve the test a bit more to fix #47654.
4932 2003-08-22 Martin Baulig <martin@ximian.com>
4934 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
4935 correctly; fixes #47722.
4937 2003-08-22 Martin Baulig <martin@ximian.com>
4939 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
4940 LocalVariableReference, ensure it's not read-only. Fixes #47536.
4942 * statement.cs (Fixed.DoResolve): Make all variables read-only.
4944 2003-08-22 Martin Baulig <martin@ximian.com>
4946 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
4947 can only be assigned in static constructors. Fixes #47161.
4949 2003-08-22 Martin Baulig <martin@ximian.com>
4951 Rewrote and improved the flow analysis code.
4953 * flowbranching.cs (FlowBranching): Make this class abstract.
4954 (FlowBranching.CreateBranching): New static function to create a
4956 (FlowBranchingBlock, FlowBranchingException): New classes.
4957 (FlowBranching.UsageVector.Type): New public readonly field.
4958 (FlowBranching.UsageVector.Breaks): Removed the setter.
4959 (FlowBranching.UsageVector.Returns): Removed the setter.
4960 (FlowBranching.UsageVector): Added Break(), Return(),
4961 NeverReachable() and Throw() methods to modify the reachability.
4962 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
4963 done by FlowBranching.Merge().
4964 (FlowBranching.UsageVector.MergeChild): New method; merges the
4965 merge result into the current vector.
4966 (FlowBranching.Merge): New abstract method to merge a branching.
4968 2003-08-12 Martin Baulig <martin@ximian.com>
4970 * expression.cs (Indirection.CacheTemporaries): Create the
4971 LocalTemporary with the pointer type, not its element type.
4973 2003-08-10 Miguel de Icaza <miguel@ximian.com>
4975 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
4976 token was a keyword or not.
4978 Add `error' options where an IDENTIFIER was expected; Provide
4979 CheckToken and CheckIdentifierToken convenience error reporting
4982 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
4984 * decl.cs: Rename `NamespaceEntry Namespace' public field into
4985 NameSpaceEntry NameSpaceEntry.
4987 (LookupInterfaceOrClass): Avoid creating a full qualified name
4988 from namespace and name: avoid doing lookups when we know the
4989 namespace is non-existant. Use new Tree.LookupByNamespace which
4990 looks up DeclSpaces based on their namespace, name pair.
4992 * driver.cs: Provide a new `parser verbose' to display the
4993 exception thrown during parsing. This is turned off by default
4994 now, so the output of a failure from mcs is more graceful.
4996 * namespace.cs: Track all the namespaces defined in a hashtable
4999 (IsNamespace): New method
5001 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5003 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5004 we know that we need to concatenate (full typename can never be
5009 * statement.cs: Use a bitfield; Do not initialize to null things
5010 which are done by the constructor by default.
5012 * cs-parser.jay: bug fix, parameter was 4, not 3.
5014 * expression.cs: Just use the property;
5016 * statement.cs: No need for GetVariableInfo method.
5018 2003-08-08 Martin Baulig <martin@ximian.com>
5020 * flowanalysis.cs (FlowReturns): This is now nested in the
5021 `FlowBranching' class.
5022 (MyBitVector): Moved this here from statement.cs.
5023 (FlowBranching.SiblingType): New enum type.
5024 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5026 2003-08-07 Martin Baulig <martin@ximian.com>
5028 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5029 `FlowBranching' class and called `BranchingType'.
5031 2003-08-07 Martin Baulig <martin@ximian.com>
5033 * flowanalysis.cs: Moved all the control flow analysis code into
5036 2003-08-07 Martin Baulig <martin@ximian.com>
5038 * assign.cs (Assign.DoResolve): `target' must either be an
5039 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5042 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5044 * expression.cs (BinaryMethod): This kind of expression is created by the
5045 Binary class if it determines that the operator has to be handled
5048 (BinaryDelegate): This kind of expression is created if we are
5049 dealing with a + or - operator on delegates.
5051 (Binary): remove method, argumetns, and DelegateOperator: when
5052 dealing with methods,
5054 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5056 * statement.cs (Block): use bitfields for the three extra booleans
5057 we had in use. Remove unused topblock parameter.
5059 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5061 * assign.cs: Drop extra unneeded tests.
5063 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5065 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5067 * statement.cs (Foreach): Use VariableStorage instead of
5070 * codegen.cs (VariableStorage): New class used by clients that
5071 require a variable stored: locals or fields for variables that
5072 need to live across yield.
5074 Maybe provide a convenience api for EmitThis+EmitLoad?
5076 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5079 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5081 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5082 RemapParameterLValue): New methods that are used to turn a
5083 precomputed FieldInfo into an expression like this:
5087 The idea is to use this instead of making LocalVariableReference
5088 have more than one meaning.
5090 * cs-parser.jay: Add error production to BASE.
5092 * ecore.cs: Deal with TypeManager.GetField returning null, which
5093 is now a valid return value.
5095 (FieldExprNoAddress): New expression for Fields whose address can
5098 * expression.cs (LocalVariableReference): During the resolve
5099 phases, create new expressions if we are in a remapping context.
5100 Remove code that dealt with remapping here.
5102 (ParameterReference): same.
5104 (ProxyInstance): New expression, like the `This' expression, but
5105 it is born fully resolved. We know what we are doing, so remove
5106 the errors that are targeted to user-provided uses of `this'.
5108 * statement.cs (Foreach): our variable is now stored as an
5109 Expression; During resolution, follow the protocol, dont just
5110 assume it will return this.
5112 2003-08-06 Martin Baulig <martin@ximian.com>
5114 * support.cs (SeekableStreamReader.cs): New public class.
5116 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5117 SeekableStreamReader instead of the normal StreamReader.
5119 2003-08-04 Martin Baulig <martin@ximian.com>
5121 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5122 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5123 deambiguate casts and delegate invocations.
5124 (parenthesized_expression): Use the new tokens to ensure this is
5125 not a cast of method invocation.
5127 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5128 when reading a `)' and Deambiguate_CloseParens () was previously
5131 * expression.cs (ParenthesizedExpression): New class. This is
5132 just used for the CS0075 test.
5133 (Binary.DoResolve): Check for CS0075.
5135 2003-07-29 Ravi Pratap <ravi@ximian.com>
5137 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5138 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5139 reference comparison.
5141 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5142 examine the ReturnType for equality - this is necessary in the
5143 cases of implicit and explicit operators whose signature also
5144 includes the return type.
5146 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5148 * namespace.cs: Cache the result of the namespace computation,
5149 instead of computing it every time.
5151 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5153 * decl.cs: Use a global arraylist that we reuse over invocations
5154 to avoid excesive memory consumption. Reduces memory usage on an
5155 mcs compile by one meg (45 average).
5157 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5158 private, work around that.
5160 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5162 * literal.cs (IntLiteral): Define Zero and One static literals.
5164 * cs-parser.jay (integer_literal): use static literals to reduce
5165 memory usage for the most used literals (0, 1 and -1). 211kb
5166 reduced in memory usage.
5168 Replace all calls to `new ArrayList' with `new
5169 ArrayList(4)' which is a good average number for most allocations,
5170 and also requires only 16 bytes of memory for its buffer by
5173 This reduced MCS memory usage in seven megabytes for the RSS after
5176 2003-07-28 Ravi Pratap <ravi@ximian.com>
5178 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5179 handle params methods the correct way by forming only one
5180 applicable set with params and normal methods in them. Earlier we
5181 were looking at params methods only if we found no normal methods
5182 which was not the correct thing to do.
5184 (Invocation.BetterFunction): Take separate arguments indicating
5185 when candidate and the best method are params methods in their
5188 This fixes bugs #43367 and #46199.
5190 * attribute.cs: Documentation updates.
5192 (CheckAttribute): Rename to CheckAttributeTarget.
5193 (GetValidPlaces): Rename to GetValidTargets.
5195 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5196 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5200 2003-07-28 Martin Baulig <martin@ximian.com>
5202 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5203 name when looking up the base class of a nested class. Fixes #46977.
5205 2003-07-26 Martin Baulig <martin@ximian.com>
5207 * expression.cs (Indexers.Indexer): New nested struct; contains
5208 getter, setter and the indexer's type.
5209 (Indexers.Properties): This is now an ArrayList of
5211 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5212 indexer doesn't have any getters.
5214 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5215 for embedded property and indexer assignments.
5217 2003-07-26 Martin Baulig <martin@ximian.com>
5219 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5220 preprocessor directive is not the first non-whitespace character
5223 2003-07-26 Martin Baulig <martin@ximian.com>
5225 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5226 namespace parsing, follow the spec more closely.
5228 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5229 NamespaceEntry.Lookup().
5231 2003-07-25 Martin Baulig <martin@ximian.com>
5233 * MethodCore.cs (OverridesSomething): New public field; it's set
5234 from TypeContainer.DefineMembers if this method overrides
5235 something (which doesn't need to be a method). Fix #39462.
5237 2003-07-25 Ravi Pratap <ravi@ximian.com>
5239 * typemanager.cs (GetMembers): Ensure that the list of members is
5240 reversed. This keeps things in sync.
5242 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5243 find an AttributeUsage attribute.
5245 * expression.cs (Invocation.OverloadResolve): Perform the check
5246 which disallows Invoke to be directly called on a Delegate.
5248 (Error_InvokeOnDelegate): Report error cs1533.
5250 2003-07-25 Martin Baulig <martin@ximian.com>
5252 * expression.cs (Indexers.GetIndexersForType): Only look in the
5253 interface hierarchy if the requested type is already an
5254 interface. Fixes #46788 while keeping #46502 fixed.
5256 2003-07-25 Martin Baulig <martin@ximian.com>
5258 * class.cs (TypeContainer.DefineMembers): Check whether all
5259 readonly fields have been assigned and report warning CS0649 if
5262 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5265 2003-07-24 Ravi Pratap <ravi@ximian.com>
5267 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5268 returned from GetMethods to make things consistent with the
5269 assumptions MCS makes about ordering of methods.
5271 This should comprehensively fix bug #45127 and it does :-)
5273 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5274 ordering is actually reverse.
5276 * Clean up some debug messages I left lying around.
5278 * interface.cs (Populate*): Get rid of code which emits attributes
5279 since the stage in which we emit attributes is the 'Emit' stage,
5280 not the define stage.
5282 (Emit): Move attribute emission for interface members here.
5284 2003-07-22 Ravi Pratap <ravi@ximian.com>
5286 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5287 closely: we eliminate methods in base types when we have an
5288 applicable method in a top-level type.
5290 Please see section 14.5.5.1 for an exact description of what goes
5293 This fixes bug #45127 and a host of other related to corlib compilation.
5295 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5296 array is the method corresponding to the top-level type (this is
5297 because of the changes made to icall.c) so we change this
5300 (MethodGroupExpr.Name): This too.
5302 * typemanager.cs (GetElementType): New method which does the right
5303 thing when compiling corlib.
5305 * everywhere: Make use of the above in the relevant places.
5307 2003-07-22 Martin Baulig <martin@ximian.com>
5309 * cs-parser.jay (invocation_expression): Moved
5310 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5311 `cast_expression', but create a InvocationOrCast which later
5312 resolves to either an Invocation or a Cast.
5314 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5315 method; call this before EmitStatement() to make sure that this
5316 expression can be used as a statement.
5318 * expression.cs (InvocationOrCast): New class; resolves to either
5319 an Invocation or a Cast.
5321 * statement.cs (StatementExpression): Call ResolveStatement() on
5322 the ExpressionStatement before emitting it.
5324 2003-07-21 Martin Baulig <martin@ximian.com>
5326 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5327 `ref' and `out' attributes match; fixes #46220.
5328 (MemberAccess.ResolveMemberAccess): You can't reference a type
5329 through an expression; fixes #33180.
5330 (Indexers.GetIndexersForType): Don't return the indexers from
5331 interfaces the class implements; fixes #46502.
5333 2003-07-21 Martin Baulig <martin@ximian.com>
5335 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5336 CS0661 checks; fixes bug #30442.
5338 2003-07-21 Martin Baulig <martin@ximian.com>
5340 * decl.cs (AdditionResult): Added `Error'.
5342 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5344 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5345 makes cs0031.cs actually work.
5347 2003-07-20 Martin Baulig <martin@ximian.com>
5349 * namespace.cs: Fixed that bug which caused a crash when compiling
5352 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5354 * typemanager.cs (LookupTypeReflection): Never expose types which
5355 are NotPublic, NestedPrivate, NestedAssembly, or
5356 NestedFamANDAssem. We used to return these, and later do a check
5357 that would report a meaningful error, but the problem is that we
5358 would not get the real match, if there was a name override.
5360 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5362 * namespace.cs (Namespace, Name): Do not compute the namespace
5363 name dynamically, compute it in the constructor. This reduced
5364 memory usage by 1697 KB.
5366 * driver.cs: Use --pause to pause at the end.
5368 2003-07-17 Peter Williams <peter@newton.cx>
5370 * Makefile: Change the name of the test target so that it doesn't
5371 conflict with the recursive test target.
5373 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5375 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5376 AddressOf): Do not use EmitThis, that was wrong, use the actual
5379 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5381 * class.cs (MethodData.Define): While checking if a method is an
5382 interface implementation, improve the test: If we are not public
5383 (use new test here: use the computed MethodAttributes directly,
5384 instead of the parsed modifier flags) check if the `implementing'
5385 method comes from an interface or not.
5387 * pending.cs (VerifyPendingMethods): Slightly better error
5390 * makefile: add test target that does the mcs bootstrap.
5392 2003-07-16 Ravi Pratap <ravi@ximian.com>
5394 * interface.cs (Define): Do nothing here since there are no
5395 members to populate etc. Move the attribute emission out of here
5396 since this was just totally the wrong place to put it. Attribute
5397 application happens during the 'Emit' phase, not in the 'Define'
5400 (Emit): Add this method and move the attribute emission here
5402 * rootcontext.cs (EmitCode): Call the Emit method on interface
5405 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5407 * expression.cs (OverloadResolve): Report error only if Location
5408 is not 'Null' which means that there was a probe going on.
5410 2003-07-14 Martin Baulig <martin@ximian.com>
5412 * expression.cs (ConditionalLogicalOperator): New public class to
5413 implement user defined conditional logical operators.
5414 This is section 14.11.2 in the spec and bug #40505.
5416 2003-07-14 Martin Baulig <martin@ximian.com>
5418 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5420 2003-07-14 Martin Baulig <martin@ximian.com>
5422 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5424 * ecore.cs (IVariable.VerifyFixed): New interface method.
5426 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5427 operator, check whether the variable is actually fixed. Fixes bug
5428 #36055. Set a variable definitely assigned when taking its
5429 address as required by the spec.
5431 * statement.cs (LocalInfo.IsFixed): New field.
5432 (LocalInfo.MakePinned): Set `IsFixed' to true.
5434 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5436 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5437 for .ctors, ensure that we only ask for members declared in the
5438 attribute type (BindingFlags.DeclaredOnly).
5442 * expression.cs (Error_WrongNumArguments): Report error 1501
5443 correctly the way CSC does.
5445 2003-07-13 Martin Baulig <martin@ximian.com>
5447 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5448 lookup on the fully qualified name, to make things like "X.X" work
5449 where "X.X" is a fully qualified type name, but we also have a
5450 namespace "X" in the using list. Fixes #41975.
5452 2003-07-13 Martin Baulig <martin@ximian.com>
5454 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5455 function. If we're a CompoundAssign, we need to create an embedded
5456 CompoundAssign, not an embedded Assign.
5457 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5460 2003-07-13 Martin Baulig <martin@ximian.com>
5462 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5463 work to fix bug #46088.
5465 2003-07-13 Ravi Pratap <ravi@ximian.com>
5467 * class.cs (Operator.Emit): Do not emit attributes here - it is
5468 taken care of by the Method class that we delegate too. This takes
5471 2003-07-10 Martin Baulig <martin@ximian.com>
5473 * expression.cs (TypeOfVoid): New class.
5474 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5476 2003-07-10 Martin Baulig <martin@ximian.com>
5478 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5481 2003-07-10 Martin Baulig <martin@ximian.com>
5483 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5484 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5486 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5488 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5490 2003-07-10 Martin Baulig <martin@ximian.com>
5492 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5493 of decimal. Fixes #42850.
5495 NOTE: I also fixed the created byte blob, but this doesn't work on
5496 the MS runtime and csc never produces any byte blobs for decimal
5499 2003-07-10 Martin Baulig <martin@ximian.com>
5501 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5502 structs; fixes #32068.
5503 (Block.AddChildVariableNames): Fixed #44302.
5505 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5507 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5509 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5511 * attribute.cs: And this test is onger needed.
5513 2003-07-08 Martin Baulig <martin@ximian.com>
5515 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5516 inaccessible types. Fixes #36313.
5518 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5520 * namespace.cs (NamespaceEntry): Create implicit entries for all
5521 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5522 implicit entries for N1.N2 and N1.
5524 2003-07-08 Martin Baulig <martin@ximian.com>
5526 Rewrote the handling of namespaces to fix a lot of the issues
5527 wrt. `using' aliases etc.
5529 * namespace.cs (Namespace): Splitted this class into a
5530 per-assembly `Namespace' and a per-file `NamespaceEntry'.
5532 * typemanager.cs (TypeManager.IsNamespace): Removed.
5533 (TypeManager.ComputeNamespaces): Only compute namespaces from
5534 loaded assemblies here, not the namespaces from the assembly we're
5535 currently compiling.
5537 2003-07-08 Martin Baulig <martin@ximian.com>
5539 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
5541 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5543 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
5546 I thought about the memory savings here, but LookupTypeReflection
5547 is used under already very constrained scenarios. Compiling
5548 corlib or mcs only exposes one hit, so it would not really reduce
5549 any memory consumption.
5551 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5553 * typemanager.cs: fixes bug #45889 by only adding public types from
5554 other assemblies to the list of known types.
5556 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5558 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
5559 on the type we resolved.
5561 2003-07-05 Martin Baulig <martin@ximian.com>
5563 * pending.cs (PendingImplementation.ParentImplements): Don't
5564 create the proxy if the parent is abstract.
5566 * class.cs (TypeContainer.DefineIndexers): Process explicit
5567 interface implementations first. Fixes #37714.
5569 2003-07-04 Miguel de Icaza <miguel@ximian.com>
5571 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
5572 defined recursively; but since we modify the input parameters
5573 (left is set to `this' temporarily), we reset this value if the
5574 left_is_explicit is false, which gives the original semantics to
5577 * literal.cs (NullPointer): new class used to represent a null
5578 literal in a pointer context.
5580 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
5581 type is a pointer, use a NullPointer object instead of a
5582 NullLiteral. Closes 43687
5584 (ExplicitConversion): Convert pointer values using
5585 the conv opcode to the proper type.
5587 * ecore.cs (New): change ValueTypeVariable property into a method,
5588 that returns whether the valuetype is suitable for being used.
5590 * expression.cs (Binary.DoNumericPromotions): Only return if we
5591 the int constant was a valid uint, and we can return both left and
5592 right as uints. If not, we continue processing, to trigger the
5593 type conversion. This fixes 39018.
5595 * statement.cs (Block.EmitMeta): During constant resolution, set
5596 the CurrentBlock property on the emitcontext, so that we resolve
5597 constants propertly.
5599 2003-07-02 Martin Baulig <martin@ximian.com>
5601 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
5602 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
5604 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
5605 than emitting it here.
5607 * statement.cs: Fixed some more flow analysis bugs.
5609 2003-07-02 Martin Baulig <martin@ximian.com>
5611 * class.cs (MethodData.Define): When implementing interface
5612 methods, set Final unless we're Virtual.
5614 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
5615 check work for interface methods.
5617 2003-07-01 Martin Baulig <martin@ximian.com>
5619 * ecore.cs (EmitContext.This): Replaced this property with a
5620 GetThis() method which takes a Location argument. This ensures
5621 that we get the correct error location for a CS0188.
5623 2003-07-01 Miguel de Icaza <miguel@ximian.com>
5625 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
5626 ImplicitStandardConversion.
5628 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
5630 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
5632 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
5635 2003-06-30 Miguel de Icaza <miguel@ximian.com>
5637 * class.cs (Constructor.Define): Turn off initlocals for unsafe
5640 (MethodData.Define): Turn off initlocals for unsafe methods.
5642 2003-06-29 Miguel de Icaza <miguel@ximian.com>
5644 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
5645 complete; Fixes #37521.
5647 * delegate.cs: Use Modifiers.TypeAttr to compute the
5648 TypeAttributes, instead of rolling our own. This makes the flags
5649 correct for the delegates.
5651 2003-06-28 Miguel de Icaza <miguel@ximian.com>
5653 * class.cs (Constructor.Define): Set the private flag for static
5654 constructors as well.
5656 * cs-parser.jay (statement_expression): Set the return value to
5657 null, to avoid a crash when we catch an error.
5659 2003-06-24 Miguel de Icaza <miguel@ximian.com>
5661 * cs-parser.jay: Applied patch from Jackson that adds support for
5662 extern and unsafe modifiers to destructor declarations.
5664 * expression.cs: Report error 21 if the user is trying to index a
5667 * driver.cs: Add an error message, suggested by the bug report.
5669 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
5670 if we do not have a ": this ()" constructor initializer. Fixes 45149
5672 2003-06-14 Miguel de Icaza <miguel@ximian.com>
5674 * namespace.cs: Add some information to reduce FAQs.
5676 2003-06-13 Miguel de Icaza <miguel@ximian.com>
5678 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
5679 underlying enumeration types. Fixes #43915.
5681 * expression.cs: Treat ushort/short as legal values to be used in
5684 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
5686 * delegate.cs: transfer custom attributes for paramenters from
5687 the delegate declaration to Invoke and BeginInvoke.
5689 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
5691 * attribute.cs: handle custom marshalers and emit marshal info
5694 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
5696 * makefile.gnu: Added anonymous.cs to the compiler sources.
5698 2003-05-28 Miguel de Icaza <miguel@ximian.com>
5700 * iterators.cs: Change the name of the proxy class to include two
5703 * cs-parser.jay: Update grammar to include anonymous methods.
5705 * anonymous.cs: new file.
5707 2003-05-27 Miguel de Icaza <miguel@ximian.com>
5709 * class.cs (Field.Define): Add missing test for pointers and
5712 2003-05-27 Ravi Pratap <ravi@ximian.com>
5714 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
5715 we use the stobj opcode.
5717 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
5718 since it wasn't the correct fix.
5720 It still is puzzling that we are required to use stobj for IntPtr
5721 which seems to be a ValueType.
5723 2003-05-26 Miguel de Icaza <miguel@ximian.com>
5725 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
5726 during regular simple name resolution. Now, the trick is that
5727 instead of returning for processing the simplename, we do a
5728 TypeManager.LookupType (ie, a rooted lookup as opposed to a
5729 contextual lookup type). If a match is found, return that, if
5730 not, return for further composition.
5732 This fixes long-standing 30485.
5734 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5735 using the address to initialize an object, do an Stobj instead of
5736 using the regular Stelem.
5738 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
5739 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
5740 Because if we are a BaseIndexerAccess that value will be true.
5743 * statement.cs (GotoCase.Resolve): Return after reporting an
5744 error, do not attempt to continue.
5746 * expression.cs (PointerArithmetic.Emit): If our operand is a
5747 long, convert our constants to match the operand before
5748 multiplying. Convert to I type before adding. Fixes 43670.
5750 2003-05-14 Ravi Pratap <ravi@ximian.com>
5752 * enum.cs (ImplicitConversionExists) : Rename to
5753 ImplicitEnumConversionExists to remove ambiguity.
5755 * ecore.cs (NullCast): New type of cast expression class which
5756 basically is very similar to EmptyCast with the difference being
5757 it still is a constant since it is used only to cast a null to
5761 * convert.cs (ImplicitReferenceConversion): When casting a null
5762 literal, we return a NullCast.
5764 * literal.cs (NullLiteralTyped): Remove - I don't see why this
5765 should be around anymore.
5767 The renaming (reported was slightly wrong). Corrections:
5769 ConvertImplicitStandard -> ImplicitConversionStandard
5770 ConvertExplicitStandard -> ExplicitConversionStandard
5772 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
5773 before passing them in !
5775 * convert.cs (ImplicitConversionStandard): When comparing for
5776 equal expr and target types, ensure that expr is not a
5779 In general, we must not be checking (expr_type ==
5780 target_type) in the top level conversion methods
5781 (ImplicitConversion, ExplicitConversion etc). This checking is
5782 done in the methods that they delegate to.
5784 2003-05-20 Miguel de Icaza <miguel@ximian.com>
5786 * convert.cs: Move Error_CannotConvertType,
5787 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
5788 ImplicitNumericConversion, ImplicitConversionExists,
5789 ImplicitUserConversionExists, StandardConversionExists,
5790 FindMostEncompassedType, FindMostSpecificSource,
5791 FindMostSpecificTarget, ImplicitUserConversion,
5792 ExplicitUserConversion, GetConversionOperators,
5793 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
5794 TryImplicitIntConversion, Error_CannotConvertImplicit,
5795 ConvertImplicitRequired, ConvertNumericExplicit,
5796 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
5797 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
5800 Perform the following renames:
5802 StandardConversionExists -> ImplicitStandardConversionExists
5803 ConvertImplicit -> ImplicitConversion
5804 ConvertImplicitStandard -> ImplicitStandardConversion
5805 TryImplicitIntConversion -> ImplicitIntConversion
5806 ConvertImplicitRequired -> ImplicitConversionRequired
5807 ConvertNumericExplicit -> ExplicitNumericConversion
5808 ConvertReferenceExplicit -> ExplicitReferenceConversion
5809 ConvertExplicit -> ExplicitConversion
5810 ConvertExplicitStandard -> ExplicitStandardConversion
5812 2003-05-19 Martin Baulig <martin@ximian.com>
5814 * statement.cs (TypeInfo.StructInfo): Made this type protected.
5815 (TypeInfo): Added support for structs having structs as fields.
5817 * ecore.cs (FieldExpr): Implement IVariable.
5818 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
5819 VariableInfo for the field.
5821 2003-05-18 Martin Baulig <martin@ximian.com>
5823 * expression.cs (This.DoResolve): Report a CS0027 if we're
5824 emitting a field initializer.
5826 2003-05-18 Martin Baulig <martin@ximian.com>
5828 * expression.cs (This.ResolveBase): New public function.
5829 (This.DoResolve): Check for CS0188.
5831 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
5834 * ecore.cs (MethodGroupExpr.DoResolve): Set the
5835 `instance_expression' to null if we don't have any non-static
5838 2003-05-18 Martin Baulig <martin@ximian.com>
5840 Reworked the way how local variables and parameters are handled by
5841 the flow analysis code.
5843 * statement.cs (TypeInfo, VariableMap): New public classes.
5844 (VariableInfo): New public class. This is now responsible for
5845 checking whether a variable has been assigned. It is used for
5846 parameters and local variables.
5847 (Block.EmitMeta): Take the InternalParameters as argument; compute
5848 the layout of the flow vectors here.
5849 (Block.LocalMap, Block.ParameterMap): New public properties.
5850 (FlowBranching): The .ctor doesn't get the InternalParameters
5851 anymore since Block.EmitMeta() now computes the layout of the flow
5853 (MyStructInfo): This class is now known as `StructInfo' and nested
5854 in `TypeInfo'; we don't access this directly anymore.
5856 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
5857 property and removed IsAssigned(), IsFieldAssigned(),
5858 SetAssigned() and SetFieldAssigned(); we now call them on the
5859 VariableInfo so we don't need to duplicate this code everywhere.
5861 * expression.cs (ParameterReference): Added `Block block' argument
5863 (LocalVariableReference, ParameterReference, This): The new
5864 VariableInfo class is now responsible for all the definite
5867 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
5868 IsParameterAssigned, SetParameterAssigned): Removed.
5870 2003-05-18 Martin Baulig <martin@ximian.com>
5872 * typemanager.cs (InitCoreTypes): Try calling
5873 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
5874 the 3-args-version. Corlib now also needs our `void_type'.
5875 (GetMethod): Added overloaded version which takes an optional
5876 `bool report_errors' to allow lookups of optional methods.
5878 2003-05-12 Martin Baulig <martin@ximian.com>
5880 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
5881 only used for locals and not for parameters.
5883 2003-05-12 Miguel de Icaza <miguel@ximian.com>
5885 * support.cs (InternalParameters.ParameterType): Return the
5886 ExternalType of the parameter.
5888 * parameter.cs (Parameter.ExternalType): drop the two arguments,
5891 2003-05-11 Miguel de Icaza <miguel@ximian.com>
5893 * class.cs (MethodData.Define): Do not set the `newslot' on
5894 interface members, if they are also flagged as "override".
5896 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
5897 better code for ++i and i++. This only works for static fields
5898 and local variables.
5900 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
5901 want to pull the DeclSpace out of the builder_to_declspace instead
5902 of the TypeBuilder (like in TypeContainer.FindMembers).
5904 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
5905 instead of LookupTypeContainer. Fixes the crash on .NET for
5906 looking up interface members.
5908 * const.cs: Create our own emit context during the Definition
5909 stage, so that constants are evaluated in the proper context, when
5910 a recursive definition happens.
5912 2003-05-11 Martin Baulig <martin@ximian.com>
5914 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
5915 new block for a switch section.
5916 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
5917 the adding/lookup in the switch block. Fixes #39828.
5919 2003-05-09 Miguel de Icaza <miguel@ximian.com>
5921 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
5922 functionality: I needed to convert the data after I had performed
5923 the add/sub operation into the operands type size.
5925 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
5926 pass the type for the box operation, otherwise the resulting
5927 object would have been of type object.
5929 (BoxedCast): Add constructor to specify the type to box as.
5931 2003-05-07 Miguel de Icaza <miguel@ximian.com>
5933 * iterators.cs: I was reusing the `count' variable inadvertently,
5934 take steps to not allow this to happen.
5936 2003-05-06 Miguel de Icaza <miguel@ximian.com>
5938 * attribute.cs (Attribute.Resolve): Params attributes are encoded
5939 by creating an array at the point where the params starts and
5940 putting all those arguments there, then adjusting the size of the
5943 2003-05-05 Miguel de Icaza <miguel@ximian.com>
5945 * expression.cs (New.AddressOf): Implement interface
5946 IMemoryLocation. This is used when the `new' operator is used in
5947 the context of an invocation to a method on a value type.
5949 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
5952 * namespace.cs: Also check the using aliases here.
5954 * driver.cs: Move the test for using validity after the types have
5955 been entered, so we do a single pass that also includes the using
5958 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
5959 in the regular case. CreateSiblingForFinally is doing extra
5962 * attribute.cs (GetAttributeArgumentExpression): Store the result
5963 on an out value, and use the return value to indicate failure
5964 instead of using null (which is a valid return for Constant.GetValue).
5966 * statement.cs: Perform the analysis flow for the increment
5967 portion after the statement, because this will be the real flow of
5968 execution. Fixes #42385
5970 * codegen.cs (EmitContext.EmitArgument,
5971 EmitContext.EmitStoreArgument): New helper functions when the
5972 RemapToProxy flag is set.
5974 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
5977 Add support for remapping parameters.
5979 * iterators.cs: Propagate parameter values; Store parameter
5980 values in the proxy classes.
5982 2003-05-04 Miguel de Icaza <miguel@ximian.com>
5984 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
5985 need a proxy reference; I do not know what I was thinking
5987 * cs-parser.jay (constructor_initializer): catch another error,
5988 and display nice message.
5990 (field_declaration): catch void field declaration
5991 to flag a better error.
5993 * class.cs (MemberBase.CheckBase): Report an error instead of a
5994 warning if a new protected member is declared in a struct.
5995 (Field.Define): catch the error of readonly/volatile.
5997 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
5999 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6000 volatile variable is taken
6002 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6004 * statement.cs (Fixed.Resolve): Report an error if we are not in
6007 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6009 * typemanager.cs: reuse the code that handles type clashes for
6010 delegates and enumerations.
6012 * class.cs (Report28): Always report.
6014 * expression.cs (EncodeAsAttribute): Allow nulls here.
6016 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6018 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6019 the functionality for testing whether an expression is valid for
6020 an attribute here. Also handle the case of arrays of elements
6023 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6024 encoding a linear array into an array of objects that are suitable
6025 to be passed to an CustomAttributeBuilder.
6027 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6029 * ecore.cs: (FieldExpr): Handle field remapping here.
6031 * iteratators.cs: Pass the instance variable (if the method is an
6032 instance method) to the constructors, so we can access the field
6033 variables on the class.
6035 TODO: Test this with structs. I think the THIS variable on
6036 structs might have to be a pointer, and not a refenrece
6038 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6040 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6041 local variables to fields in a proxy class.
6043 * iterators.cs (PopulateProxy): Rename our internal fields to
6045 Create a <THIS> field if we are an instance method, so we can
6046 reference our parent container variables.
6047 (MapVariable): Called back from the EmitContext code to enter a
6048 new variable to field mapping into the proxy class (we just create
6052 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6053 for using the remapped locals to fields.
6055 I placed the code here, because that gives the same semantics to
6056 local variables, and only changes the Emit code.
6058 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6059 statements inside iterators.
6060 (VariableInfo): Add a FieldBuilder for the cases when we are
6061 remapping local variables to fields in a proxy class
6063 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6064 current_block != null.
6066 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6067 not cope with strings, as it has been moved to the
6068 TableSwitchEmit. Fixed bug in switch generation.
6070 * expression.cs (New.DoResolve): Provide more context for the user
6071 when reporting an error.
6073 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6076 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6077 check the permissions for it. Note than in a type-resolution
6078 context the check was already present in DeclSpace.ResolveType,
6079 but was missing from the MemberAccess.
6081 (ArrayCreation.CheckIndices): warn if the user has
6082 more nested levels of expressions, but there are no more
6083 dimensions specified. Avoids crash on bug 41906.
6085 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6087 * statement.cs (Block): replace Implicit bool, for a generic
6089 New flag: `Unchecked'. This is used during the EmitMeta phase
6090 (which is out-of-line with the regular Resolve/Emit process for a
6091 statement, as this is done ahead of time, but still gets a chance
6092 to call constant resolve).
6094 (Block.Flags): new enum for adding a new flag.
6096 (Block.EmitMeta): track the state of unchecked.
6098 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6099 to enable constant resolution to work there as well.
6101 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6103 * typemanager.cs (ienumerable_type): Also look up
6104 System.Collections.IEnumerable.
6106 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6108 TODO: Test more than one conditional per method.
6110 * class.cs (Indexer.Define): Report the location where the user is
6111 referencing the unsupported feature.
6113 (MethodData): Overload the use of `conditionals' to
6114 minimize the creation of needless ArrayLists. This saves roughly
6115 212kb on my machine.
6117 (Method): Implement the new IIteratorContainer interface.
6118 (Method.SetYields): Implement the method by setting the ModFlags
6119 to contain METHOD_YIELDS.
6121 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6122 which just got set to null.
6124 * iterators.cs: New file.
6126 (Yield, YieldBreak): New statements.
6128 * statement.cs (Return.Resolve): Flag an error if we are used in
6131 * codegen.cs (InIterator): New flag set if the code is being
6132 compiled in an iterator method.
6134 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6135 internal modifier, and we just use it to avoid adding extra
6136 fields, as this is seldom used.
6138 * cs-parser.jay: Add yield_statement (yield and yield break).
6140 * driver.cs: New flag -v2 to turn on version 2 features.
6142 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6143 hashtable when v2 is enabled.
6145 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6147 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6148 there is already a namespace defined with this name.
6150 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6151 people upgraded their corlibs.
6153 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6154 always use fully qualified types, no need to use the compiler
6157 (TypeManager.IsNamespace): Use binarysearch.
6159 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6160 AddDelegate): I did not quite use the new IsValid API properly: I
6161 have to pass the short-name and the fullname. I was passing only
6162 the basename instead of the fullname sometimes.
6164 (TypeContainer.DefineType): call NamespaceClash.
6166 * interface.cs (Interface.DefineType): use NamespaceClash before
6169 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6172 * enum.cs: (Enum.DefineType): use NamespaceClash before
6175 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6176 speed increase. First, use the negative_hits cache when we get a
6177 negative. Second, add the type with its full original name
6178 instead of the new . and + encoded name (reflection uses + to
6179 separate type from a nested type). Use LookupTypeReflection
6180 directly which bypasses the type->name hashtable (that we already
6181 know does not contain the type.
6183 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6184 location/container type.
6186 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6188 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6190 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6192 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6193 method is being referenced in the method group from a static
6194 context, and report error 120 if so.
6196 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6199 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6200 is created, we create the A namespace).
6202 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6205 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6207 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6208 invocation to ModuleBuilder.GetType with the same values will
6209 return a new type instance, so we need to cache its return
6212 * expression.cs (Binary.ResolveOperator): Only allow the compare
6213 operators on enums if they are of the same type.
6215 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6216 types of ValueType on their own case. Before we were giving them
6217 the same treatment as objects.
6219 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6220 fullname. Short name is used to compare against container name.
6221 Fullname is used to check against defined namespace names.
6223 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6224 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6226 (Method.CheckBase): Call parent.
6227 (MemberBase.CheckBase): Check for protected members on sealed
6229 (PropertyBase.CheckBase): Call parent.
6230 (Field.Define): Call parent.
6232 * report.cs: Negative error codes are now mapped to 8000 - code,
6233 so that the display is render more nicely.
6235 * typemanager.cs: Do not use try/catch, instead report a regular
6238 (GetPointerType, GetReferenceType): These methods provide
6239 mechanisms to obtain the T* and T& from a T. We had the code
6240 previously scattered around the code base, and it also used
6241 TypeManager.LookupType that would go through plenty of caches.
6242 This one goes directly to the type source.
6244 In some places we did the Type.GetType followed by
6245 ModuleBuilder.GetType, but not in others, so this unifies the
6248 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6249 statements now that we have namespace information.
6251 * typemanager.cs (IsNamespace): New method, returns whether the
6252 string presented is a namespace or not.
6254 (ComputeNamespaces): New public entry point, computes the list of
6255 available namespaces, using the GetNamespaces API call in Mono, or
6256 the slower version in MS.NET.
6258 Now before we start the semantic analysis phase, we have a
6259 complete list of namespaces including everything that the user has
6262 Deleted old code to cache namespaces in .nsc files.
6264 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6266 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6267 class/struct location definition Location for the implicit
6268 constructor location.
6270 (Operator.Define): Use the location of the operator for the
6271 implicit Method definition.
6273 (Constructor.Emit): use the constructor location for the implicit
6274 base initializer constructor.
6276 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6277 and the Expression class now contains two new methods:
6279 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6280 isolate type lookup from the rest of the resolution process.
6282 Since we use Expressions to hold type definitions due to the way
6283 we parse the input we have historically overloaded Resolve to
6284 perform the Type lookups if a special flag is passed. Now this is
6285 eliminated and two methods take their place.
6287 The differences in the two methods between xStep and xTerminal is
6288 that xStep is involved in our current lookup system that uses
6289 SimpleNames to compose a name, while xTerminal is used just to
6290 catch the case where the simplename lookup failed.
6292 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6294 * expression.cs (ResolveMemberAccess): Remove redundant code.
6295 TypeExpr expressions are always born fully resolved.
6297 * interface.cs (PopulateMethod): Do not lookup the types twice.
6298 We were doing it once during SemanticAnalysis and once during
6301 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6302 in local variable type definitions, were being returned as a
6303 SimpleName (we decomposed everything into a string), that is
6304 because primary_expression was being used instead of a type in the
6305 grammar (reduce/reduce conflicts).
6307 The part that was wrong is that we converted the expression into a
6308 string (an oversimplification in one hand, compounded with primary
6309 expressions doing string concatenation).
6315 Would return "A.B.C[]" as a SimpleName. This stopped things like
6316 using clauses from working on this particular context. And a type
6317 was being matched directly against "A.B.C[]".
6319 We now use the correct approach, and allow for ComposedCast to be
6320 part of the unary expression. So the "A.B.C []" become a composed
6321 cast of "A.B.C" (as a nested group of MemberAccess with a
6322 SimpleName at the end) plus the rank composition "[]".
6326 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6328 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6329 for the access level checking.
6331 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6332 `TypeContainer container', because I kept getting confused when I
6333 was debugging this code.
6335 * expression.cs (Indexers): Instead of tracking getters/setters,
6336 we now track them in parallel. We create one arraylist less, but
6337 most importantly it is possible now for the LValue code to find a
6338 matching get for a set.
6340 (IndexerAccess.DoResolveLValue): Update the code.
6341 GetIndexersForType has been modified already to extract all the
6342 indexers from a type. The code assumed it did not.
6344 Also make the code set the correct return type for the indexer.
6345 This was fixed a long time ago for properties, but was missing for
6346 indexers. It used to be void_type.
6348 (Binary.Emit): Test first for doubles instead of
6349 floats, as they are more common.
6351 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6352 when dealing with floats and the <=, >= operators. This fixes bug
6355 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6356 to load the array value by emitting a load on the foreach variable
6357 type. This was incorrect.
6359 We now emit the code to load an element using the the array
6360 variable type, and then we emit the conversion operator.
6364 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6366 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6368 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6370 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6371 test for protection before we test for signatures.
6373 (MethodSignature.ToString): implement.
6375 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6376 to the case where we reduced into a LongConstant.
6378 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6379 depend on whether the information is acurrate, because the
6380 Microsoft runtime will always claim that the array type is public,
6381 regardless of the real state.
6383 If the type is a pointer, another problem happens: the type is
6384 reported as non-public in Microsoft.
6386 In both cases we have to call CheckAccessLevel recursively with
6387 the underlying type as the argument to be tested.
6389 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6391 * assign.cs (Assign.Emit): If we are dealing with a compound
6392 assignment expression, we should use the code path that stores the
6393 intermediate result in a temporary value. This fixes #40903.
6395 *expression.cs (Indirection.ToString): Provide ToString method for
6398 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6400 * class.cs: Null out fields holding references to Block objects so
6401 they can be garbage collected.
6403 * expression.cs (OverloadResolve): Remove unused local.
6405 2003-04-07 Martin Baulig <martin@ximian.com>
6407 * codegen.cs (EmitContext.CurrentFile): New public field.
6408 (EmitContext.Mark): Use the CurrentFile to check whether the
6409 location is in the correct file.
6410 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6412 2003-04-07 Martin Baulig <martin@ximian.com>
6414 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6416 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6417 location. [FIXME: The location argument which gets passed to this
6418 method is sometimes wrong!]
6420 2003-04-07 Nick Drochak <ndrochak@gol.com>
6422 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6424 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6426 * expression.cs (Indirection.EmitAssign): We were using the
6427 temporary, but returning immediately instead of continuing the
6430 2003-04-06 Martin Baulig <martin@ximian.com>
6432 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6433 if it's a nested child, but also deriving from the outer class.
6436 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6437 nested child, but also deriving from the outer class. See
6439 (FilterWithClosure): We may access private members of the outer
6440 class if we're a nested child and deriving from the outer class.
6441 (RealMemberLookup): Only set `closure_private_ok' if the
6442 `original_bf' contained BindingFlags.NonPublic.
6444 2003-04-05 Martin Baulig <martin@ximian.com>
6446 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6448 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6450 * class.cs (Event.Define): Do not allow abstract events to have
6453 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6455 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6456 block in event declarations.
6458 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6459 value type, get its address.
6461 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6462 leaving a class on the stack instead of a boolean value (int
6463 0/1). Change the code so we compare against null, and then the
6464 result against zero.
6466 * class.cs (TypeContainer.GetClassBases): We were checking for the
6467 parent class being sealed too late.
6469 * expression.cs (Binary.Emit): For <= and >= when dealing with
6470 floating point values, use cgt.un and clt.un instead of cgt and
6473 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6475 * statement.cs: Apply the same optimization as MS: skip the
6476 GetEnumerator returning an IEnumerator, and use the one returning a
6477 CharEnumerator instead. This allows us to avoid the try-finally block
6480 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6482 * cs-parser.jay: Attributes cannot be applied to
6483 namespaces. Fixes #40473
6485 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6488 (Add*): check if the name is valid using the full name for constants,
6489 fields, properties and events.
6491 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6493 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6494 char constants to be part of the enumeration.
6496 * expression.cs (Conditional.DoResolve): Add support for operator
6497 true. Implements the missing functionality from 14.12
6499 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6500 operator true/false as required by the spec.
6502 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6503 implicit conversion to boolean.
6505 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6506 also one where the type implements `operator true'.
6508 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
6509 get an expression that will invoke operator true based on an
6512 (GetConversionOperators): Removed the hack that called op_True
6515 (Expression.ResolveBoolean): Move this from Statement.
6517 2003-03-17 Miguel de Icaza <miguel@ximian.com>
6519 * ecore.cs (FieldExpr): do not allow initialization of initonly
6520 fields on derived classes
6522 2003-03-13 Martin Baulig <martin@ximian.com>
6524 * statement.cs (Block.Emit): Call ig.BeginScope() and
6525 ig.EndScope() when compiling with debugging info; call
6526 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
6528 2003-03-08 Miguel de Icaza <miguel@ximian.com>
6530 * expression.cs (Indexers): Do not construct immediately, allow
6531 for new members to be appended as we go. Fixes 38143
6533 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6535 * expression.cs: save/restore context when resolving an unchecked
6538 2003-03-05 Miguel de Icaza <miguel@ximian.com>
6540 * cfold.cs: Catch division by zero in modulus operator during
6543 2003-03-03 Miguel de Icaza <miguel@ximian.com>
6545 * interface.cs (Interface.DefineMembers): Avoid defining members
6548 2003-02-27 Miguel de Icaza <miguel@ximian.com>
6550 * driver.cs: handle the +/- options for -noconfig
6552 * statement.cs (Unckeched.Resolve): Also track the state of
6553 unchecked in the Resolve phase.
6555 2003-02-27 Martin Baulig <martin@ximian.com>
6557 * ecore.cs (Expression.MemberLookup): Don't create a
6558 MethodGroupExpr for something which is not a method. Fixes #38291.
6560 2003-02-25 Miguel de Icaza <miguel@ximian.com>
6562 * class.cs (MemberBase.CheckParameters): Also check that the type
6563 is unmanaged if it is a pointer.
6565 * expression.cs (SizeOf.Resolve): Add location information.
6567 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
6568 a managed type is declared.
6570 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
6571 parameter modifiers as well. Fixes bug 38606
6573 * class.cs: Very sad. Am backing out the speed up changes
6574 introduced by the ArrayList -> Array in the TypeContainer, as they
6575 were not actually that much faster, and introduced a bug (no error
6576 reports on duplicated methods).
6578 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
6579 source first, this will guarantee that we have a valid expression
6580 before calling in lower levels functions that will require a
6581 resolved object. Then use this original_source in the
6582 target.ResolveLValue instead of the original source that was
6585 Another change. Use target.Resolve instead of LValueResolve.
6586 Although we are resolving for LValues, we will let the Assign code
6587 take care of that (it will be called again from Resolve). This
6588 basically allows code like this:
6590 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
6591 class Y { void A (X x) { x [0] += o; }
6593 The problem was that the indexer was trying to resolve for
6594 set_Item (idx, object o) and never finding one. The real set_Item
6595 was set_Item (idx, X). By delaying the process we get the right
6600 2003-02-23 Martin Baulig <martin@ximian.com>
6602 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
6603 while calling DoEmit ().
6605 * codegen.cs (EmitContext.Mark): Don't mark locations in other
6606 source files; if you use the #line directive inside a method, the
6607 compiler stops emitting line numbers for the debugger until it
6608 reaches the end of the method or another #line directive which
6609 restores the original file.
6611 2003-02-23 Martin Baulig <martin@ximian.com>
6613 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
6615 2003-02-23 Martin Baulig <martin@ximian.com>
6617 * statement.cs (Block.AddChildVariableNames): We need to call this
6618 recursively, not just for our immediate children.
6620 2003-02-23 Martin Baulig <martin@ximian.com>
6622 * class.cs (Event.Define): Always make the field private, like csc does.
6624 * typemanager.cs (TypeManager.RealMemberLookup): Make events
6625 actually work, fixes bug #37521.
6627 2003-02-23 Miguel de Icaza <miguel@ximian.com>
6629 * delegate.cs: When creating the various temporary "Parameters"
6630 classes, make sure that we call the ComputeAndDefineParameterTypes
6631 on those new parameters (just like we do with the formal ones), to
6632 allow them to be resolved in the context of the DeclSpace.
6634 This fixes the bug that Dick observed in Bugzilla #38530.
6636 2003-02-22 Miguel de Icaza <miguel@ximian.com>
6638 * expression.cs (ResolveMemberAccess): When resolving a constant,
6639 do not attempt to pull a constant if the value was not able to
6640 generate a valid constant.
6642 * const.cs (LookupConstantValue): Do not report more errors than required.
6644 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6646 * expression.cs: fixes bug #38328.
6648 2003-02-18 Miguel de Icaza <miguel@ximian.com>
6650 * class.cs: Changed all the various members that can be part of a
6651 class from being an ArrayList to be an Array of the right type.
6652 During the DefineType type_list, interface_list, delegate_list and
6653 enum_list are turned into types, interfaces, delegates and enums
6656 And during the member population, indexer_list, event_list,
6657 constant_list, field_list, instance_constructor_list, method_list,
6658 operator_list and property_list are turned into their real arrays.
6660 Although we could probably perform this operation earlier, for
6661 good error reporting we need to keep the lists and remove the
6662 lists for longer than required.
6664 This optimization was triggered by Paolo profiling the compiler
6665 speed on the output of `gen-sample-program.pl' perl script.
6667 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
6668 not crash in methods like MemberLookupFailed that use this field.
6670 This problem arises when the compiler fails to resolve a type
6671 during interface type definition for example.
6673 2003-02-18 Miguel de Icaza <miguel@ximian.com>
6675 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
6676 inherit from System.Object, so we have to stop at null, not only
6677 when reaching System.Object.
6679 2003-02-17 Miguel de Icaza <miguel@ximian.com>
6681 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
6682 DeclaredOnly because the parent indexer might have had a different
6683 name, but did not loop until the top of the hierarchy was reached.
6685 The problem this one fixes is 35492: when a class implemented an
6686 indexer from an interface, we were getting the interface method
6687 (which was abstract) and we were flagging an error (can not invoke
6690 This also keeps bug 33089 functioning, and test-148 functioning.
6692 * typemanager.cs (IsSpecialMethod): The correct way of figuring
6693 out if a method is special is to see if it is declared in a
6694 property or event, or whether it is one of the predefined operator
6695 names. This should fix correctly #36804.
6697 2003-02-15 Miguel de Icaza <miguel@ximian.com>
6699 The goal here is to remove the dependency on EmptyCast.Peel ().
6700 Killing it completely.
6702 The problem is that currently in a number of places where
6703 constants are expected, we have to "probe" for an EmptyCast, and
6704 Peel, which is not the correct thing to do, as this will be
6705 repetitive and will likely lead to errors.
6707 The idea is to remove any EmptyCasts that are used in casts that
6708 can be reduced to constants, so we only have to cope with
6711 This bug hunt was triggered by Bug 37363 and the desire to remove
6712 the duplicate pattern where we were "peeling" emptycasts to check
6713 whether they were constants. Now constants will always be
6716 * ecore.cs: Use an enumconstant here instead of wrapping with
6719 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
6720 throwing me off. By handling this we can get rid of a few hacks.
6722 * statement.cs (Switch): Removed Peel() code.
6724 2003-02-14 Miguel de Icaza <miguel@ximian.com>
6726 * class.cs: Location information for error 508
6728 * expression.cs (New.DoResolve): Add a guard against double
6729 resolution of an expression.
6731 The New DoResolve might be called twice when initializing field
6732 expressions (see EmitFieldInitializers, the call to
6733 GetInitializerExpression will perform a resolve on the expression,
6734 and later the assign will trigger another resolution
6736 This leads to bugs (#37014)
6738 * delegate.cs: The signature for EndInvoke should contain any ref
6739 or out parameters as well. We were not doing this in the past.
6741 * class.cs (Field.Define): Do not overwrite the type definition
6742 inside the `volatile' group. Turns out that volatile enumerations
6743 were changing the type here to perform a validity test, which
6746 2003-02-12 Miguel de Icaza <miguel@ximian.com>
6748 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
6749 and structs, we do not want to load the instance variable
6751 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
6752 enum_type has to be handled like an object reference (implicit
6753 conversions exists from this to object), but the regular IsClass
6754 and IsValueType tests will never return true for this one.
6756 Also we use TypeManager.IsValueType instead of type.IsValueType,
6757 just for consistency with the rest of the code (this is only
6758 needed if we ever use the construct exposed by test-180.cs inside
6759 corlib, which we dont today).
6761 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
6763 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
6766 2003-02-09 Martin Baulig <martin@ximian.com>
6768 * namespace.cs (Namespace..ctor): Added SourceFile argument.
6769 (Namespace.DefineNamespaces): New static public method; this is
6770 called when we're compiling with debugging to add all namespaces
6773 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
6774 pass it to the Namespace's .ctor.
6776 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
6777 and MethodBase arguments; pass the namespace ID to the symwriter;
6778 pass the MethodBase instead of the token to the symwriter.
6779 (SymbolWriter.DefineNamespace): New method to add a namespace to
6782 2003-02-09 Martin Baulig <martin@ximian.com>
6784 * symbolwriter.cs: New file. This is a wrapper around
6785 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
6786 methods here in near future.
6788 2003-02-09 Martin Baulig <martin@ximian.com>
6790 * codegen.cs (EmitContext.Mark): Just pass the arguments to
6791 ILGenerator.MarkSequencePoint() which are actually used by the
6794 2003-02-09 Martin Baulig <martin@ximian.com>
6796 * location.cs (SourceFile): New public sealed class. This
6797 contains the name and an index which is used in the location's token.
6798 (Location): Reserve an appropriate number of bits in the token for
6799 the source file instead of walking over that list, this gives us a
6800 really huge performance improvement when compiling with debugging.
6802 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
6803 `SourceFile' argument instead of a string.
6804 (Driver.ProcessFile): Add all the files via Location.AddFile(),
6805 but don't parse/tokenize here, we need to generate the list of all
6806 source files before we do that.
6807 (Driver.ProcessFiles): New static function. Parses/tokenizes all
6810 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
6811 instead of a string.
6813 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
6816 2003-02-09 Martin Baulig <martin@ximian.com>
6818 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
6819 filename on `#line default'.
6821 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
6823 * statement.cs: don't clear the pinned var when the fixed statement
6824 returns from the method (fixes bug#37752).
6826 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
6828 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
6831 2003-02-07 Martin Baulig <martin@ximian.com>
6833 * driver.cs: Removed the `--debug-args' command line argument.
6835 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
6836 automatically by the AsssemblyBuilder.
6837 (CodeGen.InitializeSymbolWriter): We don't need to call any
6838 initialization function on the symbol writer anymore. This method
6839 doesn't take any arguments.
6841 2003-02-03 Miguel de Icaza <miguel@ximian.com>
6843 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
6844 from referenced assemblies as well.
6846 2003-02-02 Martin Baulig <martin@ximian.com>
6848 * class.cs (MethodData.Emit): Generate debugging info for external methods.
6850 2003-02-02 Martin Baulig <martin@ximian.com>
6852 * class.cs (Constructor.Emit): Open the symbol writer before
6853 emitting the constructor initializer.
6854 (ConstructorInitializer.Emit): Call ec.Mark() to allow
6855 single-stepping through constructor initializers.
6857 2003-01-30 Miguel de Icaza <miguel@ximian.com>
6859 * class.cs: Handle error 549: do not allow virtual methods in
6862 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
6864 * decl.cs: Check access levels when resolving types
6866 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
6868 * statement.cs: Add parameters and locals set in catch blocks that might
6869 return to set vector
6871 2003-01-29 Miguel de Icaza <miguel@ximian.com>
6873 * class.cs (Operator): Set the SpecialName flags for operators.
6875 * expression.cs (Invocation.DoResolve): Only block calls to
6876 accessors and operators on SpecialName methods.
6878 (Cast.TryReduce): Handle conversions from char constants.
6881 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
6883 * statement.cs: small memory and time optimization in FlowBranching.
6885 2003-01-28 Pedro Mart <yoros@wanadoo.es>
6887 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
6888 problem that the last fix but in the other sid (Set).
6890 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
6891 access when there is no indexer in the hierarchy.
6893 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
6895 * class.cs: Combine some if statements.
6897 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6899 * driver.cs: fixed bug #37187.
6901 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
6903 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
6904 any indexer, it's needed to build a list with all the indexers in the
6905 hierarchy (AllGetters), else we have problems. Fixes #35653.
6907 2003-01-23 Miguel de Icaza <miguel@ximian.com>
6909 * class.cs (MethodData.Define): It is wrong for an interface
6910 implementation to be static in both cases: explicit and implicit.
6911 We were only handling this in one case.
6913 Improve the if situation there to not have negations.
6915 * class.cs (Field.Define): Turns out that we do not need to check
6916 the unsafe bit on field definition, only on usage. Remove the test.
6918 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6920 * driver.cs: use assembly.Location instead of Codebase (the latest
6921 patch made mcs fail when using MS assemblies).
6923 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
6925 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
6926 get the path to *corlib.dll.
6928 2003-01-21 Nick Drochak <ndrochak@gol.com>
6932 * typemanager.cs: Remove compiler warnings
6934 2003-01-20 Duncan Mak <duncan@ximian.com>
6936 * AssemblyInfo.cs: Bump the version number to 0.19.
6938 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6940 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
6942 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
6944 * class.cs (Constructor::Emit): Emit debugging info for constructors.
6946 2003-01-17 Miguel de Icaza <miguel@ximian.com>
6948 * cs-parser.jay: Small fix: we were not comparing the constructor
6949 name correctly. Thanks to Zoltan for the initial pointer.
6951 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
6953 * cs-tokenizer.cs: Set file name when specified with #line
6955 2003-01-15 Miguel de Icaza <miguel@ximian.com>
6957 * cs-parser.jay: Only perform the constructor checks here if we
6958 are named like the class; This will help provider a better
6959 error. The constructor path is taken when a type definition is
6960 not found, but most likely the user forgot to add the type, so
6961 report that rather than the constructor error.
6963 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
6965 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
6968 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6970 * cs-parser.jay: Add cleanup call.
6972 2003-01-13 Duncan Mak <duncan@ximian.com>
6974 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
6975 consistent with other methods.
6977 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6979 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
6981 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
6983 * attribute.cs: only set GuidAttr to true when we have a
6986 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6990 * typemanager.cs: fixes to allow mcs compile corlib with the new
6991 Type.IsSubclassOf fix.
6993 2003-01-08 Miguel de Icaza <miguel@ximian.com>
6995 * expression.cs (LocalVariableReference.DoResolve): Classify a
6996 constant as a value, not as a variable. Also, set the type for
6999 * cs-parser.jay (fixed_statement): take a type instead of a
7000 pointer_type, so we can produce a better error message later.
7002 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7005 (For.DoEmit): Make inifinite loops have a
7006 non-conditional branch back.
7008 (Fixed.DoEmit): First populate the pinned variables, then emit the
7009 statement, then clear the variables. Before I was emitting the
7010 code once for each fixed piece.
7013 2003-01-08 Martin Baulig <martin@ximian.com>
7015 * statement.cs (FlowBranching.MergeChild): A break in a
7016 SWITCH_SECTION does not leave a loop. Fixes #36155.
7018 2003-01-08 Martin Baulig <martin@ximian.com>
7020 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7021 lives in the same number space than `param_map'. Fixes #36154.
7023 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7025 * cs-parser.jay (constructor_declaration): Set the
7026 Constructor.ModFlags before probing for it. This makes the
7027 compiler report 514, 515 and 132 (the code was there, but got
7030 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7031 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7032 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7034 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7036 * enum.cs: create the enum static fields using the enum type.
7038 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7040 * class.cs: don't try to create the ParamBuilder for the return
7041 type if it's not needed (and handle it breaking for the ms runtime
7044 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7046 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7048 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7050 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7051 the command. This showed up while compiling the JANET source
7052 code, which used \r as its only newline separator.
7054 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7056 * class.cs (Method.Define): If we are an operator (because it
7057 reuses our code), then set the SpecialName and HideBySig. #36128
7059 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7061 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7062 exception, report error 120 `object reference required'.
7064 * driver.cs: Add --pause option, used during to measure the size
7065 of the process as it goes with --timestamp.
7067 * expression.cs (Invocation.DoResolve): Do not allow methods with
7068 SpecialName to be invoked.
7070 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7072 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7073 number before adding it.
7075 2002-12-21 Ravi Pratap <ravi@ximian.com>
7077 * ecore.cs (StandardImplicitConversion): When in an unsafe
7078 context, we allow conversion between void * to any other pointer
7079 type. This fixes bug #35973.
7081 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7083 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7084 is not thrown when extensionless outputs are used
7086 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7088 * rootcontext.cs: fixed compilation of corlib.
7090 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7092 * attribute.cs (Attributes.Contains): Add new method.
7094 * class.cs (MethodCore.LabelParameters): if the parameter is an
7095 `out' parameter, check that no attribute `[In]' has been passed.
7097 * enum.cs: Handle the `value__' name in an enumeration.
7099 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7101 * decl.cs: Added special case to allow overrides on "protected
7104 2002-12-18 Ravi Pratap <ravi@ximian.com>
7106 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7107 since it makes much more sense.
7109 (Attributes.ctor): Don't require a Location parameter.
7111 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7113 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7114 since we already have that information per attribute.
7116 * everywhere : make appropriate changes.
7118 * class.cs (LabelParameters): Write the code which actually
7119 applies attributes to the return type. We can't do this on the MS
7120 .NET runtime so we flag a warning in the case an exception is
7123 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7125 * const.cs: Handle implicit null conversions here too.
7127 2002-12-17 Ravi Pratap <ravi@ximian.com>
7129 * class.cs (MethodCore.LabelParameters): Remove the extra
7130 Type [] parameter since it is completely unnecessary. Instead
7131 pass in the method's attributes so that we can extract
7132 the "return" attribute.
7134 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7136 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7137 of ignoring it and letting the compile continue.
7139 * typemanager.cs (ChangeType): use an extra argument to return an
7140 error condition instead of throwing an exception.
7142 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7144 * expression.cs (Unary.TryReduce): mimic the code for the regular
7145 code path. Perform an implicit cast in the cases where we can
7146 implicitly convert to one of the integral types, and then reduce
7147 based on that constant. This fixes bug #35483.
7149 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7151 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7153 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7155 * namespace.cs: fixed bug #35489.
7157 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7159 * class.cs: Remove some dead code.
7161 * cs-parser.jay: Estimate the number of methods needed
7162 (RootContext.MethodCount);
7164 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7165 numbers instead of StringBuilders.
7167 * support.cs (PtrHashtable): Add constructor with initial size;
7168 We can now reduce reallocations of the method table.
7170 2002-12-10 Ravi Pratap <ravi@ximian.com>
7172 * attribute.cs (ApplyAttributes): Keep track of the emitted
7173 attributes on a per-target basis. This fixes bug #35413.
7175 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7177 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7178 default to the Windows 1252 encoding.
7180 (UnixParseOption): Support version, thanks to Alp for the missing
7183 * AssemblyInfo.cs: Add nice assembly information.
7185 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7188 * cs-parser.jay: Allow a trailing comma before the close bracked
7189 in the attribute_section production.
7191 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7192 address of the instance was being taken, I will take this out,
7193 because we take the address of the object immediately here.
7195 2002-12-09 Ravi Pratap <ravi@ximian.com>
7197 * typemanager.cs (AreMultipleAllowed): Take care of the most
7198 obvious case where attribute type is not in the current assembly -
7201 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7203 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7204 definitions, instead of doing that afterwards.
7206 Also we use a nice little hack, depending on the constructor, we
7207 know if we are a "composed" name or a simple name. Hence, we
7208 avoid the IndexOf test, and we avoid
7210 * codegen.cs: Add code to assist in a bug reporter to track down
7211 the source of a compiler crash.
7213 2002-12-07 Ravi Pratap <ravi@ximian.com>
7215 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7216 types have been emitted for a given element and flag an error
7217 if something which does not have AllowMultiple set is used more
7220 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7221 attribute types and their corresponding AllowMultiple properties
7223 (AreMultipleAllowed): Check the property for a given type.
7225 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7226 property in the case we have a TypeContainer.
7228 (Attributes.AddAttribute): Detect duplicates and just skip on
7229 adding them. This trivial fix catches a pretty gross error in our
7230 attribute emission - global attributes were being emitted twice!
7232 Bugzilla bug #33187 is now fixed.
7234 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7236 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7239 * expression.cs (Binary.ResolveOperator): I can only use the
7240 Concat (string, string, string) and Concat (string, string,
7241 string, string) if the child is actually a concatenation of
7244 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7246 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7247 context where we need a 2-character lookahead.
7249 * pending.cs (PendingImplementation): Rework so we can keep track
7250 of interface types all the time, and flag those which were
7251 implemented by parents as optional.
7253 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7255 * expression.cs (Binary.ResolveOperator): Use
7256 String.Concat(string,string,string) or
7257 String.Concat(string,string,string,string) when possible.
7259 * typemanager: More helper methods.
7262 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7264 * pending.cs: remove the bogus return from GetMissingInterfaces()
7265 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7267 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7269 * namespace.cs: avoid duplicated 'using xxx' being added to
7270 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7271 when we get more than one 'using' statement for the same namespace.
7272 Report a CS0105 warning for it.
7274 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7276 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7277 of calling getChar/putback, uses internal knowledge of it.
7279 (xtoken): Reorder tokenizer so most common patterns are checked
7280 first. This reduces the compilation time in another 5% (from 8.11s
7281 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7283 The parsing time is 22% of the compilation in mcs, and from that
7284 64% is spent on the tokenization process.
7286 I tried using a binary search for keywords, but this is slower
7287 than the hashtable. Another option would be to do a couple of
7290 * Not use a StringBuilder, instead use an array of chars,
7291 with a set value. Notice that this way we could catch
7292 the 645 error without having to do it *afterwards*.
7294 * We could write a hand-parser to avoid the hashtable
7295 compares altogether.
7297 The identifier consumption process takes 37% of the tokenization
7298 time. Another 15% is spent on is_number. 56% of the time spent
7299 on is_number is spent on Int64.Parse:
7301 * We could probably choose based on the string length to
7302 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7305 Another 3% is spend on wrapping `xtoken' in the `token' function.
7307 Handle 0xa0 as whitespace (#34752)
7309 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7311 * typemanager.cs (IsCLRType): New routine to tell whether a type
7312 is one of the builtin types.
7314 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7315 typecode in more places instead of doing pointer comparissions.
7316 We could leverage some knowledge about the way the typecodes are
7319 New code to cache namespaces in assemblies, it is currently not
7320 invoked, to be used soon.
7322 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7324 * expression.cs (Binary.ResolveOperator): specially handle
7325 strings, and do not perform user-defined operator overloading for
7328 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7330 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7331 internalcall as it is a pretty simple operation; Avoid whenever
7332 possible to call Char.IsLetter.
7334 (consume_identifier): Cut by half the number of
7335 hashtable calls by merging the is_keyword and GetKeyword behavior.
7337 Do not short-circuit, because if we do, we
7338 report errors (ie, #if false && true would produce an invalid
7342 2002-11-24 Martin Baulig <martin@ximian.com>
7344 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7345 check constant ranges and report a CS0221. Fixes #33186.
7347 2002-11-24 Martin Baulig <martin@ximian.com>
7349 * cs-parser.jay: Make this work for uninitialized variable
7350 declarations in the `for' initializer. Fixes #32416.
7352 2002-11-24 Martin Baulig <martin@ximian.com>
7354 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7355 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7357 2002-11-24 Martin Baulig <martin@ximian.com>
7359 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7360 argument; if true, we also check for user-defined conversions.
7361 This is only needed if both arguments are of a user-defined type.
7362 Fixes #30443, added test-175.cs.
7363 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7365 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7367 2002-11-24 Martin Baulig <martin@ximian.com>
7369 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7370 function to get the store opcode.
7371 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7372 only emit the Ldelema if the store opcode is Stobj. You must run
7373 both test-34 and test-167 to test this. Fixes #34529.
7375 2002-11-23 Martin Baulig <martin@ximian.com>
7377 * ecore.cs (Expression.MemberLookup): Added additional
7378 `qualifier_type' argument which is used when we're being called
7379 from MemberAccess.DoResolve() and null if we're called from a
7381 (Expression.MemberLookupFailed): New method to report errors; this
7382 does the CS1540 check and reports the correct error message.
7384 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7385 argument for the CS1540 check and redone the way how we're dealing
7386 with private members. See the comment in the source code for details.
7387 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7388 `closure_start_type' to `closure_qualifier_type' and check whether
7389 it's not null. It was not this filter being broken, it was just
7390 being called with the wrong arguments.
7392 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7393 and pass it the correct `qualifier_type'; this also does the error
7396 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7398 * expression.cs (Invocation.EmitParams): If the we are dealing
7399 with a non-built-in value type, load its address as well.
7401 (ArrayCreation): Use a a pretty constant instead
7402 of the hardcoded value 2. Use 6 instead of 2 for the number of
7403 static initializers.
7405 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7406 because they are not really value types, just glorified integers.
7408 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7410 * ecore.cs: Remove redundant code for enumerations, make them use
7411 the same code path as everything else, fixes the casting issue
7412 with enumerations in Windows.Forms.
7414 * attribute.cs: Do only cast to string if it is a string, the
7415 validation happens later.
7417 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7418 people upgrade their corlibs.
7420 * ecore.cs: Oops, enumerations were not following the entire code path
7422 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7424 * typemanager.cs (FilterWithClosure): Commented out the test for
7425 1540 in typemanager.cs, as it has problems when accessing
7426 protected methods from a parent class (see test-174.cs).
7428 * attribute.cs (Attribute.ValidateGuid): new method.
7429 (Attribute.Resolve): Use above.
7431 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7433 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7435 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7436 handling for enumerations, as we only needed the TypeContainer
7437 functionality to begin with (this is required for the fix below to
7438 work for enums that reference constants in a container class for
7441 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7443 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7444 a valid TypeBuilder to perform lookups on.o
7446 * class.cs (InheritableMemberSignatureCompare): Use true in the
7447 call to GetGetMethod and GetSetMethod, because we are comparing
7448 the signature, and we need to get the methods *even* if they are
7451 (PropertyBase.CheckBase): ditto.
7453 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7454 GotoCase.Resolve): Use Peel on EmpytCasts.
7456 * ecore.cs (EmptyCast): drop child, add Peel method.
7458 2002-11-17 Martin Baulig <martin@ximian.com>
7460 * ecore.cs (EmptyCast.Child): New public property.
7462 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7463 label resolved to an EmptyCast. Fixes #34162.
7464 (GotoCase.Resolve): Likewise.
7465 (Block.EmitMeta): Likewise.
7467 2002-11-17 Martin Baulig <martin@ximian.com>
7469 * expression.cs (Invocation.BetterConversion): Prefer int over
7470 uint; short over ushort; long over ulong for integer literals.
7471 Use ImplicitConversionExists instead of StandardConversionExists
7472 since we also need to check for user-defined implicit conversions.
7473 Fixes #34165. Added test-173.cs.
7475 2002-11-16 Martin Baulig <martin@ximian.com>
7477 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7478 with the `true' and `false' literals. Fixes #33151.
7480 2002-11-16 Martin Baulig <martin@ximian.com>
7482 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7483 October 22nd; don't do the cs1540 check for static members.
7485 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7486 now using our own filter here and doing the cs1540 check again.
7488 2002-11-16 Martin Baulig <martin@ximian.com>
7490 * support.cs (InternalParameters): Don't crash if we don't have
7491 any fixed parameters. Fixes #33532.
7493 2002-11-16 Martin Baulig <martin@ximian.com>
7495 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7496 when looking up static methods to make this work on Windows.
7499 2002-11-16 Martin Baulig <martin@ximian.com>
7501 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7502 a setter rather than using PropertyInfo.CanWrite.
7504 2002-11-15 Nick Drochak <ndrochak@gol.com>
7506 * class.cs: Allow acces to block member by subclasses. Fixes build
7509 2002-11-14 Martin Baulig <martin@ximian.com>
7511 * class.cs (Constructor.Emit): Added the extern/block check.
7514 2002-11-14 Martin Baulig <martin@ximian.com>
7516 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
7517 iteration while looking for indexers, this is needed because the
7518 indexer may have a different name in our base classes. Fixed the
7519 error reporting (no indexers at all, not get accessor, no
7520 overloaded match). Fixes bug #33089.
7521 (IndexerAccess.DoResolveLValue): Likewise.
7523 2002-11-14 Martin Baulig <martin@ximian.com>
7525 * class.cs (PropertyBase.CheckBase): Make this work for multiple
7526 indexers. Fixes the first part of bug #33089.
7527 (MethodSignature.InheritableMemberSignatureCompare): Added support
7530 2002-11-13 Ravi Pratap <ravi@ximian.com>
7532 * attribute.cs (Attribute.Resolve): Catch the
7533 NullReferenceException and report it since it isn't supposed to
7536 2002-11-12 Miguel de Icaza <miguel@ximian.com>
7538 * expression.cs (Binary.EmitBranchable): Also handle the cases for
7539 LogicalOr and LogicalAnd that can benefit from recursively
7540 handling EmitBranchable. The code now should be nice for Paolo.
7542 2002-11-08 Miguel de Icaza <miguel@ximian.com>
7544 * typemanager.cs (LookupType): Added a negative-hit hashtable for
7545 the Type lookups, as we perform quite a number of lookups on
7546 non-Types. This can be removed once we can deterministically tell
7547 whether we have a type or a namespace in advance.
7549 But this might require special hacks from our corlib.
7553 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
7554 and double which avoids a conversion from an integer to a double.
7556 * expression.cs: tiny optimization, avoid calling IsConstant,
7557 because it effectively performs the lookup twice.
7559 2002-11-06 Miguel de Icaza <miguel@ximian.com>
7561 But a bogus return here to keep the semantics of the old code
7562 until the Mono runtime is fixed.
7564 * pending.cs (GetMissingInterfaces): New method used to remove all
7565 the interfaces that are already implemented by our parent
7566 classes from the list of pending methods.
7568 * interface.cs: Add checks for calls after ResolveTypeExpr.
7570 2002-11-05 Miguel de Icaza <miguel@ximian.com>
7572 * class.cs (Class.Emit): Report warning 67: event not used if the
7573 warning level is beyond 3.
7575 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
7576 being a NullLiteral.
7578 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
7581 * class.cs (TypeContainer.GetClassBases): Cover a missing code
7582 path that might fail if a type can not be resolved.
7584 * expression.cs (Binary.Emit): Emit unsigned versions of the
7587 * driver.cs: use error 5.
7589 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
7591 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
7593 2002-11-01 Miguel de Icaza <miguel@ximian.com>
7595 * cs-parser.jay (switch_section): A beautiful patch from Martin
7596 Baulig that fixed 33094.
7598 2002-10-31 Miguel de Icaza <miguel@ximian.com>
7600 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
7601 Check whether the base is abstract and report an error if so.
7603 * expression.cs (IndexerAccess.DoResolveLValue,
7604 IndexerAccess.DoResolve): ditto.
7606 (Invocation.DoResolve): ditto.
7608 (Invocation.FullMethodDesc): Improve the report string.
7610 * statement.cs (Block): Eliminate IsVariableDefined as it is
7611 basically just a wrapper for GetVariableInfo.
7613 * ecore.cs (SimpleName): Use new
7615 * support.cs (ReflectionParamter.ParameterType): We unwrap the
7616 type, as we return the actual parameter ref/unref state on a
7619 2002-10-30 Miguel de Icaza <miguel@ximian.com>
7621 * support.cs: Return proper flags REF/OUT fixing the previous
7624 * expression.cs: Reverted last patch, that was wrong. Is_ref is
7625 not used to mean `ref' but `ref or out' in ParameterReference
7627 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
7628 full type signature instead of calling TypeManger.CSharpName
7631 * support.cs (InternalParameters.ParameterDesc): Do not compare
7632 directly to the modflags, because REF/OUT will actually be bitsets
7635 * delegate.cs (VerifyMethod): Check also the modifiers.
7637 * cs-tokenizer.cs: Fix bug where floating point values with an
7638 exponent where a sign was missing was ignored.
7640 * driver.cs: Allow multiple assemblies to be specified in a single
7643 2002-10-28 Miguel de Icaza <miguel@ximian.com>
7645 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
7646 because identifiers after a parenthesis would end up in this kind
7647 of production, and we needed to desamiguate it for having casts
7650 (UserDefinedType *) xxx
7652 2002-10-24 Miguel de Icaza <miguel@ximian.com>
7654 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
7655 we should set on the Bindingflags.NonPublic, but not turn on
7656 private_ok. private_ok controls whether a Private member is
7657 returned (this is chekced on the filter routine), while the
7658 BindingFlags.NonPublic just controls whether private/protected
7659 will be allowed. This fixes the problem part of the problem of
7660 private properties being allowed to be used in derived classes.
7662 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
7663 so we can call the children DoResolveLValue method (this will
7664 properly signal errors on lvalue assignments to base properties)
7666 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
7667 getter are null, and we have a property info, we know that this
7668 happened because the lookup failed, so we report an error 122 for
7669 protection level violation.
7671 We also silently return if setter and getter are null in the
7672 resolve functions, this condition only happens if we have flagged
7673 the error before. This is the other half of the problem.
7675 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
7676 not have accessibility information, that is why we were returning
7677 true in the filter function in typemanager.cs.
7679 To properly report 122 (property is inaccessible because of its
7680 protection level) correctly, we report this error in ResolveAccess
7681 by failing if both the setter and the getter are lacking (ie, the
7684 DoResolve and DoLResolve have been modified to check for both
7685 setter/getter being null and returning silently, the reason being
7686 that I did not want to put the knowledge about this error in upper
7689 int old = Report.Errors;
7690 x = new PropertyExpr (...);
7691 if (old != Report.Errors)
7696 So the property expr is returned, but it is invalid, so the error
7697 will be flagged during the resolve process.
7699 * class.cs: Remove InheritablePropertySignatureCompare from the
7700 class, as we no longer depend on the property signature to compute
7701 whether it is possible to implement a method or not.
7703 The reason is that calling PropertyInfo.GetGetMethod will return
7704 null (in .NET, in Mono it works, and we should change this), in
7705 cases where the Get Method does not exist in that particular
7710 class X { public virtual int A { get { return 1; } } }
7712 class Z : Y { public override int A { get { return 2; } } }
7714 Would fail in Z because the parent (Y) would not have the property
7715 defined. So we avoid this completely now (because the alternative
7716 fix was ugly and slow), and we now depend exclusively on the
7719 (PropertyBase.CheckBase): Use a method-base mechanism to find our
7720 reference method, instead of using the property.
7722 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
7723 routines are gone now.
7725 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
7726 names, they were incorrectly named.
7728 * cs-tokenizer.cs: Return are more gentle token on failure.
7730 * pending.cs (PendingImplementation.InterfaceMethod): This routine
7731 had an out-of-sync index variable, which caused it to remove from
7732 the list of pending methods the wrong method sometimes.
7734 2002-10-22 Miguel de Icaza <miguel@ximian.com>
7736 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
7737 CanWrite, because those refer to this particular instance of the
7738 property, and do not take into account the fact that we can
7739 override single members of a property.
7741 Constructor requires an EmitContext. The resolution process does
7742 not happen here, but we need to compute the accessors before,
7743 because the resolution does not always happen for properties.
7745 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
7746 subclass, before we did not update this flag, but we did update
7749 (GetAccessors): Drop this routine, as it did not work in the
7750 presence of partially overwritten set/get methods.
7752 Notice that this broke the cs1540 detection, but that will require
7755 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7759 * driver.cs: issue a warning instead of an error if we don't support
7760 debugging for the platform. Also ignore a couple of errors that may
7761 arise when trying to write the symbols. Undo my previous patch.
7763 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7765 * driver.cs: ignore /debug switch except for Unix platforms.
7767 2002-10-23 Nick Drochak <ndrochak@gol.com>
7769 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
7771 2002-10-21 Miguel de Icaza <miguel@ximian.com>
7773 * driver.cs: Do not make mcs-debug conditional, so we do not break
7776 * statement.cs (UsageVector.MergeChildren): I would like Martin to
7777 review this patch. But basically after all the children variables
7778 have been merged, the value of "Breaks" was not being set to
7779 new_breaks for Switch blocks. I think that it should be set after
7780 it has executed. Currently I set this to the value of new_breaks,
7781 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
7782 conservative, but I do not understand this code very well.
7784 I did not break anything in the build, so that is good ;-)
7786 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
7788 2002-10-20 Mark Crichton <crichton@gimp.org>
7790 * cfold.cs: Fixed compile blocker. Really fixed it this time.
7792 2002-10-20 Nick Drochak <ndrochak@gol.com>
7794 * cfold.cs: Fixed compile blocker.
7796 2002-10-20 Miguel de Icaza <miguel@ximian.com>
7798 * driver.cs: I was chekcing the key, not the file.
7800 2002-10-19 Ravi Pratap <ravi@ximian.com>
7802 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
7803 message that we were generating - we just need to silently return
7806 2002-10-19 Miguel de Icaza <miguel@ximian.com>
7808 * class.cs (Event.Define): Change my previous commit, as this
7809 breaks the debugger. This is a temporary hack, as it seems like
7810 the compiler is generating events incorrectly to begin with.
7812 * expression.cs (Binary.ResolveOperator): Added support for
7813 "U operator - (E x, E y)"
7815 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
7818 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
7819 init-only variables, but this path did not take into account that
7820 there might be also instance readonly variables. Correct this
7823 This fixes bug 32253
7825 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
7828 * driver.cs: Change the extension for modules to `netmodule'
7830 * cs-parser.jay: Improved slightly the location tracking for
7831 the debugger symbols.
7833 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
7834 modifiers that were specified instead of the hardcoded value
7835 (FamAndAssem). This was basically ignoring the static modifier,
7836 and others. Fixes 32429.
7838 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
7839 fixed a bug in the process (32476)
7841 * expression.cs (ArrayAccess.EmitAssign): Patch from
7842 hwang_rob@yahoo.ca that fixes bug 31834.3
7844 2002-10-18 Miguel de Icaza <miguel@ximian.com>
7846 * driver.cs: Make the module extension .netmodule.
7848 2002-10-16 Miguel de Icaza <miguel@ximian.com>
7850 * driver.cs: Report an error if the resource file is not found
7851 instead of crashing.
7853 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
7854 false, like Emit does.
7856 2002-10-16 Nick Drochak <ndrochak@gol.com>
7858 * typemanager.cs: Remove unused private member. Also reported mcs
7859 bug to report this as a warning like csc.
7861 2002-10-15 Martin Baulig <martin@gnome.org>
7863 * statement.cs (Statement.Emit): Made this a virtual method; emits
7864 the line number info and calls DoEmit().
7865 (Statement.DoEmit): New protected abstract method, formerly knows
7866 as Statement.Emit().
7868 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
7870 2002-10-11 Miguel de Icaza <miguel@ximian.com>
7872 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
7873 have fixed a remaining problem: not every AddXXXX was adding a
7874 fully qualified name.
7876 Now everyone registers a fully qualified name in the DeclSpace as
7877 being defined instead of the partial name.
7879 Downsides: we are slower than we need to be due to the excess
7880 copies and the names being registered this way.
7882 The reason for this is that we currently depend (on the corlib
7883 bootstrap for instance) that types are fully qualified, because
7884 we dump all the types in the namespace, and we should really have
7885 types inserted into the proper namespace, so we can only store the
7886 basenames in the defined_names array.
7888 2002-10-10 Martin Baulig <martin@gnome.org>
7890 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
7891 from bug #31834, see the bug report for a testcase which is
7894 2002-10-10 Martin Baulig <martin@gnome.org>
7896 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
7897 flow analysis code for this.
7899 * statement.cs (Do, While, For): Tell the flow analysis code about
7901 (FlowBranching.UsageVector): Added support for infinite loops.
7902 (Block.Resolve): Moved the dead code elimination here and use flow
7905 2002-10-09 Miguel de Icaza <miguel@ximian.com>
7907 * class.cs (Field.Define): Catch cycles on struct type
7910 * typemanager.cs (IsUnmanagedtype): Do not recursively check
7911 fields if the fields are static. We only need to check instance
7914 * expression.cs (As.DoResolve): Test for reference type.
7916 * statement.cs (Using.ResolveExpression): Use
7917 ConvertImplicitRequired, not ConvertImplicit which reports an
7919 (Using.ResolveLocalVariableDecls): ditto.
7921 * expression.cs (Binary.ResolveOperator): Report errors in a few
7922 places where we had to.
7924 * typemanager.cs (IsUnmanagedtype): Finish implementation.
7926 2002-10-08 Miguel de Icaza <miguel@ximian.com>
7928 * expression.cs: Use StoreFromPtr instead of extracting the type
7929 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
7931 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
7932 an enumeration value to a System.Enum, but System.Enum is not a
7933 value type, but an class type, so we need to box.
7935 (Expression.ConvertExplicit): One codepath could return
7936 errors but not flag them. Fix this. Fixes #31853
7938 * parameter.cs (Resolve): Do not allow void as a parameter type.
7940 2002-10-06 Martin Baulig <martin@gnome.org>
7942 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
7943 if it's a class type and not a struct. Fixes #31815.
7945 2002-10-06 Martin Baulig <martin@gnome.org>
7947 * statement.cs: Reworked the flow analysis code a bit to make it
7948 usable for dead code elimination.
7950 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7952 * cs-parser.jay: allow empty source files. Fixes bug #31781.
7954 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7956 * expression.cs (ComposedCast.DoResolveType): A quick workaround
7957 to fix the test 165, will investigate deeper.
7959 2002-10-04 Martin Baulig <martin@gnome.org>
7961 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
7962 finally blocks actually work.
7963 (Try.Resolve): We don't need to create a sibling for `finally' if
7964 there is no finally block.
7966 2002-10-04 Martin Baulig <martin@gnome.org>
7968 * class.cs (Constructor.Define): The default accessibility for a
7969 non-default constructor is private, not public.
7971 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7973 * class.cs (Constructor): Make AllowedModifiers public, add
7976 * cs-parser.jay: Perform the modifiers test here, as the
7977 constructor for the Constructor class usually receives a zero
7978 because of the way we create it (first we create, later we
7979 customize, and we were never checking the modifiers).
7981 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
7982 is a version of LookupTypeReflection that includes the type-name
7983 cache. This can be used as a fast path for functions that know
7984 the fully qualified name and are only calling into *.GetType() to
7985 obtain a composed type.
7987 This is also used by TypeManager.LookupType during its type
7990 (LookupType): We now also track the real type name, as sometimes
7991 we can get a quey for the real type name from things like
7992 ComposedCast. This fixes bug 31422.
7994 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
7995 complete type fullname, it does not have to go through the type
7996 resolution system to obtain the composed version of the type (for
7997 obtaining arrays or pointers).
7999 (Conditional.Emit): Use the EmitBoolExpression to
8000 generate nicer code, as requested by Paolo.
8002 (ArrayCreation.CheckIndices): Use the patch from
8003 hwang_rob@yahoo.ca to validate the array initializers.
8005 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8007 * class.cs (ConstructorInitializer.Emit): simplify code by using
8008 Invocation.EmitCall, and at the same time, fix the bugs in calling
8009 parent constructors that took variable arguments.
8011 * ecore.cs (Expression.ConvertNumericExplicit,
8012 Expression.ImplicitNumericConversion): Remove the code that
8013 manually wrapped decimal (InternalTypeConstructor call is now gone
8016 * expression.cs (Cast.TryReduce): Also handle decimal types when
8017 trying to perform a constant fold on the type.
8019 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8021 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8022 that only turned off an error report, and did nothing else.
8024 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8026 * driver.cs: Handle and ignore /fullpaths
8028 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8030 * expression.cs (Binary.ResolveOperator): Catch the case where
8031 DoNumericPromotions returns true,
8033 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8035 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8037 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8040 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8042 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8043 conversion exists, but it is also required that the conversion be
8044 performed. This manifested in "(Type64Enum) 2".
8046 * class.cs (TypeManager.AddMethod): The fix is not to change
8047 AddEnum, because that one was using a fully qualified name (every
8048 DeclSpace derivative does), but to change the AddMethod routine
8049 that was using an un-namespaced name. This now correctly reports
8050 the duplicated name.
8052 Revert patch until I can properly fix it. The issue
8053 is that we have a shared Type space across all namespaces
8054 currently, which is wrong.
8056 Options include making the Namespace a DeclSpace, and merge
8057 current_namespace/current_container in the parser.
8059 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8061 * cs-parser.jay: Improve error reporting when we get a different
8062 kind of expression in local_variable_type and
8063 local_variable_pointer_type.
8065 Propagate this to avoid missleading errors being reported.
8067 * ecore.cs (ImplicitReferenceConversion): treat
8068 TypeManager.value_type as a target just like object_type. As
8073 Is valid, and needs to result in the int 1 being boxed before it
8074 is assigned to the value type v.
8076 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8077 to validate the enumeration name.
8079 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8080 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8081 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8083 * ecore.cs (TryImplicitIntConversion): When doing an
8084 implicit-enumeration-conversion, check if the type is 64-bits and
8085 perform a conversion before passing to EnumConstant.
8087 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8089 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8090 report ambiguous type references. Unlike the MS version, we
8091 report what the ambiguity is. Innovation at work ;-)
8093 (DeclSpace.FindType): Require a location argument to
8094 display when we display an ambiguous error.
8096 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8098 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8100 * expression.cs (EmitDynamicInitializers): Apply patch from
8101 hwang_rob@yahoo.ca that fixes the order in which we emit our
8104 2002-09-21 Martin Baulig <martin@gnome.org>
8106 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8107 delegate takes no arguments.
8109 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8111 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8114 * expression.cs: Extract the underlying type.
8116 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8118 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8120 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8122 * class.cs (TypeContainer.DefineType): We can not use the nice
8123 PackingSize with the size set to 1 DefineType method, because it
8124 will not allow us to define the interfaces that the struct
8127 This completes the fixing of bug 27287
8129 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8130 means also structs. This fixes part of the problem.
8131 (Expresion.ImplicitReferenceConversionExists): ditto.
8133 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8134 error if there were no errors reported during the type lookup
8135 process, to avoid duplicates or redundant errors. Without this
8136 you would get an ambiguous errors plus a type not found. We have
8137 beaten the user enough with the first error.
8139 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8142 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8143 during the resolution process, stop the lookup, this avoids
8144 repeated error reports (same error twice).
8146 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8148 * typemanager.cs (LookupType): Redo the type lookup code to match
8149 the needs of System.Reflection.
8151 The issue is that System.Reflection requires references to nested
8152 types to begin with a "+" sign instead of a dot. So toplevel
8153 types look like: "NameSpace.TopLevelClass", and nested ones look
8154 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8157 2002-09-19 Martin Baulig <martin@gnome.org>
8159 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8160 says that a method always returns or always throws an exception,
8161 don't report the CS0161.
8163 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8164 set `Returns = new_returns'.
8166 2002-09-19 Martin Baulig <martin@gnome.org>
8168 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8169 to an enum constant, check for a CS0176.
8171 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8173 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8174 for operators that must be in pairs and report errors.
8176 * ecore.cs (SimpleName.DoResolveType): During the initial type
8177 resolution process, when we define types recursively, we must
8178 check first for types in our current scope before we perform
8179 lookups in the enclosing scopes.
8181 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8183 (Invocation.VerifyArgumentsCompat): Call
8184 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8185 I thought we were supposed to always call this, but there are a
8186 few places in the code where we dont do it.
8188 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8190 * driver.cs: Add support in -linkres and -resource to specify the
8191 name of the identifier.
8193 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8195 * ecore.cs (StandardConversionExists): Sync with the conversion
8196 code: allow anything-* to void* conversions.
8198 (FindMostSpecificSource): Use an Expression argument
8199 instead of a Type, because we might be handed over a Literal which
8200 gets a few more implicit conversions that plain types do not. So
8201 this information was being lost.
8203 Also, we drop the temporary type-holder expression when not
8206 2002-09-17 Martin Baulig <martin@gnome.org>
8208 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8209 this is an explicit interface implementation.
8211 2002-09-17 Martin Baulig <martin@gnome.org>
8213 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8214 different `IndexerName' attributes.
8216 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8217 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8218 virtual CommonResolve().
8220 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8222 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8223 and convert that to the UnderlyingType.
8225 * statement.cs (Foreach.Resolve): Indexers are just like variables
8226 or PropertyAccesses.
8228 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8229 inside quoted strings, we were not doing this before.
8231 2002-09-16 Martin Baulig <martin@gnome.org>
8233 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8234 resolve it. This is needed for the definite assignment check of the
8235 instance expression, fixes bug #29846.
8236 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8238 2002-09-16 Nick Drochak <ndrochak@gol.com>
8240 * parameter.cs: Fix compile error. Cannot reference static member
8241 from an instance object. Is this an mcs bug?
8243 2002-09-14 Martin Baulig <martin@gnome.org>
8245 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8246 multiple times. Fixes bug #30295, added test-166.cs.
8248 2002-09-14 Martin Baulig <martin@gnome.org>
8250 * statement.cs (Block.Emit): Don't emit unreachable code.
8251 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8253 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8255 2002-09-14 Martin Baulig <martin@gnome.org>
8257 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8260 2002-09-14 Martin Baulig <martin@gnome.org>
8262 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8263 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8264 be false on the ms runtime.
8266 2002-09-13 Martin Baulig <martin@gnome.org>
8268 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8269 the CS0038 error message.
8271 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8273 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8274 constant inside, return it.
8276 2002-09-12 Martin Baulig <martin@gnome.org>
8278 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8279 implicit conversion can be done between enum types.
8281 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8282 check whether an implicit conversion to the current enum's UnderlyingType
8283 exists and report an error if not.
8285 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8286 without debugging support.
8288 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8289 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8291 2002-09-12 Martin Baulig <martin@gnome.org>
8293 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8295 * ecore.cs (IMemberExpr.DeclaringType): New property.
8296 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8297 nonstatic member of an outer type (CS0038).
8299 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8301 * driver.cs: Activate the using-error detector at warning level
8302 4 (at least for MS-compatible APIs).
8304 * namespace.cs (VerifyUsing): Small buglett fix.
8306 * pending.cs (PendingImplementation): pass the container pointer.
8308 * interface.cs (GetMethods): Allow for recursive definition. Long
8309 term, I would like to move every type to support recursive
8310 definitions, not the current ordering mechanism that we have right
8313 The situation is this: Attributes are handled before interfaces,
8314 so we can apply attributes to interfaces. But some attributes
8315 implement interfaces, we will now handle the simple cases
8316 (recursive definitions will just get an error).
8318 * parameter.cs: Only invalidate types at the end if we fail to
8321 2002-09-09 Martin Baulig <martin@gnome.org>
8323 * ecore.cs (PropertyExpr.Emit): Also check for
8324 TypeManager.system_int_array_get_length so this'll also work when
8325 compiling corlib. Fixes #30003.
8327 2002-09-09 Martin Baulig <martin@gnome.org>
8329 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8330 and throw an exception if we can't get the type's size. Fixed #30040,
8333 2002-09-09 Martin Baulig <martin@gnome.org>
8335 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8337 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8338 context. Fixes bug #30027.
8340 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8341 virtual functions. Fixes bug #30043, added test-164.cs.
8343 2002-09-08 Ravi Pratap <ravi@ximian.com>
8345 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8347 2002-09-08 Nick Drochak <ndrochak@gol.com>
8349 * driver.cs: Use an object to get the windows codepage since it's not a
8352 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8354 * statement.cs (For.Emit): for infinite loops (test == null)
8355 return whether there is a break inside, not always "true".
8357 * namespace.cs (UsingEntry): New struct to hold the name of the
8358 using definition, the location where it is defined, and whether it
8359 has been used in a successful type lookup.
8361 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8366 2002-09-06 Ravi Pratap <ravi@ximian.com>
8368 * attribute.cs : Fix incorrect code which relied on catching
8369 a NullReferenceException to detect a null being passed in
8370 where an object was expected.
8372 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8374 * statement.cs (Try): flag the catch variable as assigned
8376 * expression.cs (Cast): Simplified by using ResolveType instead of
8379 * statement.cs (Catch): Fix bug by using ResolveType.
8381 2002-09-06 Ravi Pratap <ravi@ximian.com>
8383 * expression.cs (BetterConversion): Special case for when we have
8384 a NullLiteral as the argument and we have to choose between string
8385 and object types - we choose string the way csc does.
8387 * attribute.cs (Attribute.Resolve): Catch the
8388 NullReferenceException and report error #182 since the Mono
8389 runtime no more has the bug and having this exception raised means
8390 we tried to select a constructor which takes an object and is
8393 2002-09-05 Ravi Pratap <ravi@ximian.com>
8395 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8396 message (1502, 1503) when we can't locate a method after overload
8397 resolution. This is much more informative and closes the bug
8400 * interface.cs (PopulateMethod): Return if there are no argument
8401 types. Fixes a NullReferenceException bug.
8403 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8404 expressions too. Previously we were checking only in one place for
8405 positional arguments leaving out named arguments.
8407 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8408 type to the enum type is not allowed. Remove code corresponding to
8411 (ConvertNumericExplicit): Allow explicit conversions from
8412 the underlying type to enum type. This precisely follows the spec
8413 and closes a bug filed by Gonzalo.
8415 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8418 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8420 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8422 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8423 it was important that we stored the right value after the
8424 reduction in `converted'.
8426 2002-09-04 Martin Baulig <martin@gnome.org>
8428 * location.cs (Location.SymbolDocument): Use full pathnames for the
8431 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8433 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8434 of the expression resolve mechanism, because that will catch the
8435 SimpleName error failures.
8437 (Conditional): If we can not resolve the
8438 expression, return, do not crash.
8440 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8443 (location): display token name instead of its number.
8445 2002-08-28 Martin Baulig <martin@gnome.org>
8447 * expression.cs (Binary.ResolveOperator): Don't silently return
8448 but return an error if an operator cannot be applied between two
8451 2002-08-28 Martin Baulig <martin@gnome.org>
8453 * class.cs (Constructor.Define): Set the permission attributes
8454 correctly instead of making all constructors public.
8456 2002-08-28 Martin Baulig <martin@gnome.org>
8458 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8459 for private members before reporting a CS0103; if we find anything,
8462 2002-08-28 Martin Baulig <martin@gnome.org>
8464 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8465 to check whether `closure_start_type == closure_invocation_type',
8466 we also need to check whether `m.DeclaringType == closure_invocation_type'
8467 before bypassing the permission checks. We might be accessing
8468 protected/private members from the base class.
8469 (TypeManager.RealMemberLookup): Only set private_ok if private
8470 members were requested via BindingFlags.NonPublic.
8472 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8474 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8475 MethodGroupExpr.IsExplicitImpl if appropriate.
8476 (Invocation.DoResolve): Don't report the CS0120 for explicit
8477 interface implementations.
8479 2002-08-27 Martin Baulig <martin@gnome.org>
8481 * expression.cs (Invocation.DoResolve): If this is a static
8482 method and we don't have an InstanceExpression, we must report
8485 2002-08-25 Martin Baulig <martin@gnome.org>
8487 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8488 `==' between a valuetype and an object.
8490 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8492 * ecore.cs (TypeExpr): Provide a ToString method.
8494 2002-08-24 Martin Baulig <martin@gnome.org>
8496 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8497 now called proggie.dbg and it's a binary file.
8499 2002-08-23 Martin Baulig <martin@gnome.org>
8501 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8503 2002-08-23 Martin Baulig <martin@gnome.org>
8505 * struct.cs (MyStructInfo.ctor): Make this work with empty
8506 structs; it's not allowed to use foreach() on null.
8508 2002-08-23 Martin Baulig <martin@gnome.org>
8510 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
8511 writer the full pathname of the generated assembly.
8513 2002-08-23 Martin Baulig <martin@gnome.org>
8515 * statements.cs (FlowBranching.UsageVector.MergeChildren):
8516 A `finally' block never returns or breaks; improved handling of
8519 2002-08-23 Martin Baulig <martin@gnome.org>
8521 * statement.cs (Throw.Resolve): Allow `throw null'.
8523 2002-08-23 Martin Baulig <martin@gnome.org>
8525 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
8526 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
8527 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
8528 MemberLookup would return a wrong event if this is an explicit
8529 interface implementation and the class has an event with the same
8532 2002-08-23 Martin Baulig <martin@gnome.org>
8534 * statement.cs (Block.AddChildVariableNames): New public method.
8535 (Block.AddChildVariableName): Likewise.
8536 (Block.IsVariableNameUsedInChildBlock): Likewise.
8537 (Block.AddVariable): Check whether a variable name has already
8538 been used in a child block.
8540 * cs-parser.jay (declare_local_variables): Mark all variable names
8541 from the current block as being used in a child block in the
8544 2002-08-23 Martin Baulig <martin@gnome.org>
8546 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
8547 find the symbol writer.
8549 * driver.cs: csc also allows the arguments to /define being
8550 separated by commas, not only by semicolons.
8552 2002-08-23 Martin Baulig <martin@gnome.org>
8554 * interface.cs (Interface.GetMembers): Added static check for events.
8556 2002-08-15 Martin Baulig <martin@gnome.org>
8558 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
8559 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
8561 * ecore.cs (Expression.MemberLookup): Added documentation and explained
8562 why the MethodData.EmitDestructor() change was necessary.
8564 2002-08-20 Martin Baulig <martin@gnome.org>
8566 * class.cs (TypeContainer.FindMembers): Added static check for events.
8568 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
8570 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
8571 use Type.GetEvents(), not Type.FindMembers().
8573 2002-08-20 Martin Baulig <martin@gnome.org>
8575 * decl.cs (MemberCache): Added a special method cache which will
8576 be used for method-only searched. This ensures that a method
8577 search will return a MethodInfo with the correct ReflectedType for
8580 2002-08-20 Martin Baulig <martin@gnome.org>
8582 * decl.cs (DeclSpace.FindMembers): Made this public.
8584 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8586 * delegate.cs: fixed build on windows.
8587 [FIXME: Filed as bug #29150: MCS must report these errors.]
8589 2002-08-19 Ravi Pratap <ravi@ximian.com>
8591 * ecore.cs (StandardConversionExists): Return a false
8592 if we are trying to convert the void type to anything else
8593 since that is not allowed.
8595 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
8596 we flag error 70 in the event an event is trying to be accessed
8597 directly from outside the declaring type.
8599 2002-08-20 Martin Baulig <martin@gnome.org>
8601 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
8602 MemberCache from typemanager.cs to decl.cs.
8604 2002-08-19 Martin Baulig <martin@gnome.org>
8606 * class.cs (TypeContainer): Implement IMemberContainer.
8607 (TypeContainer.DefineMembers): Create the MemberCache.
8608 (TypeContainer.FindMembers): Do better BindingFlags checking; only
8609 return public members if BindingFlags.Public was given, check
8610 whether members are static.
8612 2002-08-16 Martin Baulig <martin@gnome.org>
8614 * decl.cs (DeclSpace.Define): Splitted this in Define and
8615 DefineMembers. DefineMembers is called first and initializes the
8618 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
8619 DefineMembers() on all our DeclSpaces.
8621 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
8622 but call DefineMembers() on all nested interfaces. We call their
8623 Define() in our new Define() function.
8625 * interface.cs (Interface): Implement IMemberContainer.
8626 (Interface.Define): Moved all code except the attribute stuf to
8628 (Interface.DefineMembers): Initialize the member cache.
8630 * typemanager.cs (IMemberFinder): Removed this interface, we don't
8631 need this anymore since we can use MemberCache.FindMembers directly.
8633 2002-08-19 Martin Baulig <martin@gnome.org>
8635 * typemanager.cs (MemberCache): When creating the cache for an
8636 interface type, add all inherited members.
8637 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
8638 to `out bool used_cache' and documented it.
8639 (TypeManager.MemberLookup): If we already used the cache in the first
8640 iteration, we don't need to do the interfaces check.
8642 2002-08-19 Martin Baulig <martin@gnome.org>
8644 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
8645 here from IMemberFinder and don't implement this interface anymore.
8646 (DeclSpace.MemberCache): Moved here from IMemberFinder.
8648 * typemanager.cs (IMemberFinder): This interface is now only used by
8649 classes which actually support the member cache.
8650 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
8651 since we only put DeclSpaces into this Hashtable.
8652 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
8653 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
8655 2002-08-16 Martin Baulig <martin@gnome.org>
8657 * typemanager.cs (ICachingMemberFinder): Removed.
8658 (IMemberFinder.MemberCache): New property.
8659 (TypeManager.FindMembers): Merged this with RealFindMembers().
8660 This function will never be called from TypeManager.MemberLookup()
8661 so we can't use the cache here, just the IMemberFinder.
8662 (TypeManager.MemberLookup_FindMembers): Check whether the
8663 IMemberFinder has a MemberCache and call the cache's FindMembers
8665 (MemberCache): Rewrote larger parts of this yet another time and
8666 cleaned it up a bit.
8668 2002-08-15 Miguel de Icaza <miguel@ximian.com>
8670 * driver.cs (LoadArgs): Support quoting.
8672 (Usage): Show the CSC-like command line arguments.
8674 Improved a few error messages.
8676 2002-08-15 Martin Baulig <martin@gnome.org>
8678 * typemanager.cs (IMemberContainer.Type): New property.
8679 (IMemberContainer.IsInterface): New property.
8681 The following changes are conditional to BROKEN_RUNTIME, which is
8682 defined at the top of the file.
8684 * typemanager.cs (MemberCache.MemberCache): Don't add the base
8685 class'es members, but add all members from TypeHandle.ObjectType
8686 if we're an interface.
8687 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
8688 is the current type.
8689 (MemberCache.CacheEntry.Container): Removed this field.
8690 (TypeHandle.GetMembers): Include inherited members.
8692 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8694 * typemanager.cs: fixed compilation and added a comment on a field that
8697 2002-08-15 Martin Baulig <martin@gnome.org>
8699 * class.cs (ConstructorInitializer.Resolve): In the
8700 Expression.MemberLookup call, use the queried_type as
8703 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
8704 declared' attribute, it's always true.
8705 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
8706 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
8707 temporary wrapper for FindMembers which tells MemberLookup whether
8708 members from the base classes are included in the return value.
8709 This will go away soon.
8710 (TypeManager.MemberLookup): Use this temporary hack here; once the
8711 new MemberCache is completed, we don't need to do the DeclaredOnly
8712 looping here anymore since the MemberCache will take care of this.
8713 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
8714 (MemberCache): When creating the MemberCache for a class, get
8715 members from the current class and all its base classes.
8716 (MemberCache.CacheEntry.Container): New field. This is a
8717 temporary hack until the Mono runtime is fixed to distinguish
8718 between ReflectedType and DeclaringType. It allows us to use MCS
8719 with both the MS runtime and the unfixed Mono runtime without
8720 problems and without accecting performance.
8721 (MemberCache.SearchMembers): The DeclaredOnly looping from
8722 TypeManager.MemberLookup is now done here.
8724 2002-08-14 Martin Baulig <martin@gnome.org>
8726 * statement.cs (MyStructInfo.MyStructInfo): Don't call
8727 Type.GetFields on dynamic types but get the fields from the
8728 corresponding TypeContainer.
8729 (MyStructInfo.GetStructInfo): Added check for enum types.
8731 * typemanager.cs (MemberList.IsSynchronized): Implemented.
8732 (MemberList.SyncRoot): Implemented.
8733 (TypeManager.FilterWithClosure): No need to check permissions if
8734 closure_start_type == closure_invocation_type, don't crash if
8735 closure_invocation_type is null.
8737 2002-08-13 Martin Baulig <martin@gnome.org>
8739 Rewrote TypeContainer.FindMembers to use a member cache. This
8740 gives us a speed increase of about 35% for the self-hosting MCS
8741 build and of about 15-20% for the class libs (both on GNU/Linux).
8743 * report.cs (Timer): New class to get enhanced profiling. This
8744 whole class is "TIMER" conditional since it remarkably slows down
8747 * class.cs (MemberList): New class. This is an IList wrapper
8748 which we're now using instead of passing MemberInfo[]'s around to
8749 avoid copying this array unnecessarily.
8750 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
8751 (ICachingMemberFinder, IMemberContainer): New interface.
8752 (TypeManager.FilterWithClosure): If `criteria' is null, the name
8753 has already been checked, otherwise use it for the name comparision.
8754 (TypeManager.FindMembers): Renamed to RealMemberFinder and
8755 provided wrapper which tries to use ICachingMemberFinder.FindMembers
8756 if possible. Returns a MemberList, not a MemberInfo [].
8757 (TypeHandle): New class, implements IMemberContainer. We create
8758 one instance of this class per type, it contains a MemberCache
8759 which is used to do the member lookups.
8760 (MemberCache): New class. Each instance of this class contains
8761 all members of a type and a name-based hash table.
8762 (MemberCache.FindMembers): This is our new member lookup
8763 function. First, it looks up all members of the requested name in
8764 the hash table. Then, it walks this list and sorts out all
8765 applicable members and returns them.
8767 2002-08-13 Martin Baulig <martin@gnome.org>
8769 In addition to a nice code cleanup, this gives us a performance
8770 increase of about 1.4% on GNU/Linux - not much, but it's already
8771 half a second for the self-hosting MCS compilation.
8773 * typemanager.cs (IMemberFinder): New interface. It is used by
8774 TypeManager.FindMembers to call FindMembers on a TypeContainer,
8775 Enum, Delegate or Interface.
8776 (TypeManager.finder_to_member_finder): New PtrHashtable.
8777 (TypeManager.finder_to_container): Removed.
8778 (TypeManager.finder_to_delegate): Removed.
8779 (TypeManager.finder_to_interface): Removed.
8780 (TypeManager.finder_to_enum): Removed.
8782 * interface.cs (Interface): Implement IMemberFinder.
8784 * delegate.cs (Delegate): Implement IMemberFinder.
8786 * enum.cs (Enum): Implement IMemberFinder.
8788 * class.cs (TypeContainer): Implement IMemberFinder.
8790 2002-08-12 Martin Baulig <martin@gnome.org>
8792 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
8794 2002-08-12 Martin Baulig <martin@gnome.org>
8796 * ecore.cs (ITypeExpression): New interface for expressions which
8798 (TypeExpression): Renamed to TypeLookupExpression.
8799 (Expression.DoResolve): If we're doing a types-only lookup, the
8800 expression must implement the ITypeExpression interface and we
8801 call DoResolveType() on it.
8802 (SimpleName): Implement the new ITypeExpression interface.
8803 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
8804 hack, the situation that we're only looking up types can't happen
8805 anymore when this method is called. Moved the type lookup code to
8806 DoResolveType() and call it.
8807 (SimpleName.DoResolveType): This ITypeExpression interface method
8808 is now doing the types-only lookup.
8809 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
8810 (ResolveFlags): Added MaskExprClass.
8812 * expression.cs (MemberAccess): Implement the ITypeExpression
8814 (MemberAccess.DoResolve): Added support for a types-only lookup
8815 when we're called via ITypeExpression.DoResolveType().
8816 (ComposedCast): Implement the ITypeExpression interface.
8818 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
8819 Expression.Resolve() with ResolveFlags.Type instead.
8821 2002-08-12 Martin Baulig <martin@gnome.org>
8823 * interface.cs (Interface.Define): Apply attributes.
8825 * attribute.cs (Attribute.ApplyAttributes): Added support for
8826 interface attributes.
8828 2002-08-11 Martin Baulig <martin@gnome.org>
8830 * statement.cs (Block.Emit): Only check the "this" variable if we
8831 do not always throw an exception.
8833 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
8834 whether the property has a set accessor.
8836 2002-08-11 Martin Baulig <martin@gnome.org>
8838 Added control flow analysis support for structs.
8840 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
8841 with control flow analysis turned off.
8842 (IVariable): New interface.
8843 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
8844 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
8845 (FieldExpr.DoResolve): Resolve the instance expression with flow
8846 analysis turned off and do the definite assignment check after the
8847 resolving when we know what the expression will resolve to.
8849 * expression.cs (LocalVariableReference, ParameterReference):
8850 Implement the new IVariable interface, only call the flow analysis
8851 code if ec.DoFlowAnalysis is true.
8852 (This): Added constructor which takes a Block argument. Implement
8853 the new IVariable interface.
8854 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
8855 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
8856 This does the definite assignment checks for struct members.
8858 * class.cs (Constructor.Emit): If this is a non-static `struct'
8859 constructor which doesn't have any initializer, call
8860 Block.AddThisVariable() to tell the flow analysis code that all
8861 struct elements must be initialized before control returns from
8864 * statement.cs (MyStructInfo): New public class.
8865 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
8866 argument to this indexer. If non-zero, check an individual struct
8867 member, not the whole struct.
8868 (FlowBranching.CheckOutParameters): Check struct members.
8869 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
8870 overloaded versions of these methods which take an additional
8871 `int field_idx' argument to check struct members.
8872 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
8873 overloaded versions of these methods which take an additional
8874 `string field_name' argument to check struct member.s
8875 (VariableInfo): Implement the IVariable interface.
8876 (VariableInfo.StructInfo): New public property. Returns the
8877 MyStructInfo instance of the variable if it's a struct or null.
8878 (Block.AddThisVariable): New public method. This is called from
8879 Constructor.Emit() for non-static `struct' constructor which do
8880 not have any initializer. It creates a special variable for the
8881 "this" instance variable which will be checked by the flow
8882 analysis code to ensure that all of the struct's fields are
8883 initialized before control returns from the constructor.
8884 (UsageVector): Added support for struct members. If a
8885 variable/parameter is a struct with N members, we reserve a slot
8886 in the usage vector for each member. A struct is considered fully
8887 initialized if either the struct itself (slot 0) or all its
8888 members are initialized.
8890 2002-08-08 Martin Baulig <martin@gnome.org>
8892 * driver.cs (Driver.MainDriver): Only report an error CS5001
8893 if there were no compilation errors.
8895 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
8896 `UnsafeContext' property to determine whether the parent is in
8897 unsafe context rather than checking the parent's ModFlags:
8898 classes nested in an unsafe class are unsafe as well.
8900 2002-08-08 Martin Baulig <martin@gnome.org>
8902 * statement.cs (UsageVector.MergeChildren): Distinguish between
8903 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
8904 we return. Added test17() and test18() to test-154.cs.
8906 2002-08-08 Martin Baulig <martin@gnome.org>
8908 * typemanager.cs (TypeManager.FilterWithClosure): If we have
8909 Family access, make sure the invoking type isn't a subclass of the
8910 queried type (that'd be a CS1540).
8912 * ecore.cs (Expression.MemberLookup): Added overloaded version of
8913 this method which takes an additional `Type invocation_type'.
8915 * expression.cs (BaseAccess.DoResolve): Use the base type as
8916 invocation and query type.
8917 (MemberAccess.DoResolve): If the lookup failed and we're about to
8918 report a CS0122, try a lookup with the ec.ContainerType - if this
8919 succeeds, we must report a CS1540.
8921 2002-08-08 Martin Baulig <martin@gnome.org>
8923 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
8924 (MethodGroupExpr): Implement the IMemberExpr interface.
8926 * expression (MemberAccess.ResolveMemberAccess): No need to have
8927 any special code for MethodGroupExprs anymore, they're now
8930 2002-08-08 Martin Baulig <martin@gnome.org>
8932 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
8933 Family, FamANDAssem and FamORAssem permissions.
8934 (TypeManager.IsSubclassOrNestedChildOf): New public method.
8936 2002-08-08 Martin Baulig <martin@gnome.org>
8938 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
8939 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
8942 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
8944 * driver.cs: implemented /resource option to embed managed resources.
8946 2002-08-07 Martin Baulig <martin@gnome.org>
8948 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
8949 (FieldBase.HasFieldInitializer): New public property.
8950 (FieldBase.GetInitializerExpression): New public method. Resolves and
8951 returns the field initializer and makes sure it is only resolved once.
8952 (TypeContainer.EmitFieldInitializers): Call
8953 FieldBase.GetInitializerExpression to get the initializer, this ensures
8954 that it isn't resolved multiple times.
8956 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
8957 the resolving process (SimpleName/MemberLookup) that we're currently
8958 emitting a field initializer (which must not access any instance members,
8959 this is an error CS0236).
8961 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
8962 argument, if the `IsFieldInitializer' flag is set, we must report and
8963 error CS0236 and not an error CS0120.
8965 2002-08-07 Martin Baulig <martin@gnome.org>
8967 * ecore.cs (IMemberExpr): New public interface.
8968 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
8969 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
8970 if the expression is an IMemberExpr.
8972 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
8973 to be null, implicitly default to `this' if we're non-static in
8974 this case. Simplified the code a lot by using the new IMemberExpr
8975 interface. Also fixed bug #28176 here.
8977 2002-08-06 Martin Baulig <martin@gnome.org>
8979 * cs-parser.jay (SimpleLookup): Removed. We need to create
8980 ParameterReferences during semantic analysis so that we can do a
8981 type-only search when resolving Cast, TypeOf and SizeOf.
8982 (block): Pass the `current_local_parameters' to the Block's
8985 * class.cs (ConstructorInitializer): Added `Parameters parameters'
8986 argument to the constructor.
8987 (ConstructorInitializer.Resolve): Create a temporary implicit
8988 block with the parameters.
8990 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
8991 references here if we aren't doing a type-only search.
8993 * statement.cs (Block): Added constructor which takes a
8994 `Parameters parameters' argument.
8995 (Block.Parameters): New public property.
8997 * support.cs (InternalParameters.Parameters): Renamed `parameters'
8998 to `Parameters' and made it public readonly.
9000 2002-08-06 Martin Baulig <martin@gnome.org>
9002 * ecore.cs (Expression.Warning): Made this public as well.
9004 * report.cs (Report.Debug): Print the contents of collections.
9006 2002-08-06 Martin Baulig <martin@gnome.org>
9008 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9009 used to tell Resolve() which kinds of expressions it may return.
9010 (Expression.Resolve): Added overloaded version of this method which
9011 takes a `ResolveFlags flags' argument. This can be used to tell
9012 Resolve() which kinds of expressions it may return. Reports a
9014 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9015 ResolveFlags.SimpleName.
9016 (Expression.Error118): Added overloaded version of this method which
9017 takes a `ResolveFlags flags' argument. It uses the flags to determine
9018 which kinds of expressions are allowed.
9020 * expression.cs (Argument.ResolveMethodGroup): New public method.
9021 Resolves an argument, but allows a MethodGroup to be returned.
9022 This is used when invoking a delegate.
9024 * TODO: Updated a bit.
9026 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9028 Fixed compilation with csc.
9030 * ecore.cs: Expression.Error made public. Is this correct? Should
9031 Warning be made public too?
9033 * expression.cs: use ea.Location instead of ea.loc.
9034 [FIXME: Filed as bug #28607: MCS must report these errors.]
9036 2002-08-06 Martin Baulig <martin@gnome.org>
9038 * ecore.cs (Expression.loc): Moved the location here instead of
9039 duplicating it in all derived classes.
9040 (Expression.Location): New public property.
9041 (Expression.Error, Expression.Warning): Made them non-static and
9042 removed the location argument.
9043 (Expression.Warning): Added overloaded version which takes an
9044 `int level' argument.
9045 (Expression.Error118): Make this non-static and removed the
9046 expression and location arguments.
9047 (TypeExpr): Added location argument to the constructor.
9049 * expression.cs (StaticCallExpr): Added location argument to
9051 (Indirection, PointerArithmetic): Likewise.
9052 (CheckedExpr, UnCheckedExpr): Likewise.
9053 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9054 (StringPtr): Likewise.
9057 2002-08-05 Martin Baulig <martin@gnome.org>
9059 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9061 * assign.cs (Assign.DoResolve): Check whether the source
9062 expression is a value or variable.
9064 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9065 while resolving the corresponding blocks.
9067 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9068 an error, don't silently return null.
9070 * statement.cs (Block.AddVariable): Do the error reporting here
9071 and distinguish between CS0128 and CS0136.
9072 (Block.DoResolve): Report all unused labels (warning CS0164).
9073 (LabeledStatement): Pass the location to the constructor.
9074 (LabeledStatement.HasBeenReferenced): New property.
9075 (LabeledStatement.Resolve): Set it to true here.
9077 * statement.cs (Return.Emit): Return success even after reporting
9078 a type mismatch error (CS0126 or CS0127), this is what csc does and
9079 it avoids confusing the users with any consecutive errors.
9081 2002-08-05 Martin Baulig <martin@gnome.org>
9083 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9085 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9087 * expression.cs (MemberAccess.DoResolve): Silently return if an
9088 error has already been reported.
9090 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9091 error has already been reported.
9093 2002-08-05 Martin Baulig <martin@gnome.org>
9095 * statement.cs (UsageVector): Only initialize the `parameters'
9096 vector if we actually have any "out" parameters.
9098 2002-08-05 Martin Baulig <martin@gnome.org>
9100 * expression.cs (Binary.ResolveOperator): When combining delegates,
9101 they must have the same type.
9103 2002-08-05 Martin Baulig <martin@gnome.org>
9105 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9106 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9107 work with the ms runtime and we also don't need it: if we're a
9108 PropertyBuilder and not in the `indexer_arguments' hash, then we
9109 are a property and not an indexer.
9111 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9112 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9113 since the latter one doesn't work with the ms runtime.
9115 2002-08-03 Martin Baulig <martin@gnome.org>
9117 Fixed bugs #27998 and #22735.
9119 * class.cs (Method.IsOperator): New public field.
9120 (Method.CheckBase): Report CS0111 if there's already a method
9121 with the same parameters in the current class. Report CS0508 when
9122 attempting to change the return type of an inherited method.
9123 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9124 and it's not marked abstract or extern.
9125 (PropertyBase): New abstract base class for Property and Indexer.
9126 (PropertyBase.CheckBase): Moved here from Property and made it work
9128 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9129 the same so we can reuse it there.
9130 (Property, Indexer): Derive from PropertyBase.
9131 (MethodSignature.inheritable_property_signature_filter): New delegate
9132 to find properties and indexers.
9134 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9135 argument and improved error reporting.
9137 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9138 EmptyReadOnlyParameters and made it a property.
9140 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9141 version of this method which takes a `PropertyInfo indexer'.
9142 (TypeManager.RegisterIndexer): New method.
9144 * class.cs: Added myself as author of this file :-)
9146 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9148 * class.cs: fixed compilation on windoze.
9150 2002-08-03 Martin Baulig <martin@gnome.org>
9152 * interface.cs (Interface.GetInterfaceBases): Check whether all
9153 base interfaces are at least as accessible than the current one.
9155 * class.cs (TypeContainer.GetClassBases): Check whether base types
9156 are at least as accessible than the current type.
9157 (TypeContainer.AsAccessible): Implemented and made non-static.
9158 (MemberBase.CheckParameters): Report errors if the accessibility
9161 * delegate.cs (Delegate.Delegate): The default visibility is
9162 internal for top-level types and private for nested types.
9163 (Delegate.Define): Report errors if the accessibility checks fail.
9165 * enum.cs (Enum.Enum): The default visibility is internal for
9166 top-level types and private for nested types.
9167 (Enum.DefineType): Compute the correct visibility.
9169 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9170 function which takes a `bool is_toplevel' instead of a TypeContainer.
9172 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9175 2002-08-02 Martin Baulig <martin@gnome.org>
9177 * expression.cs (LocalVariableReferenc): Added constructor which
9178 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9179 (LocalVariableReference.IsReadOnly): New property.
9180 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9181 variable is readonly, use our own readonly flag to do this; you can
9182 use the new constructor to get a writable reference to a read-only
9185 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9186 reference to the local variable.
9188 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9190 * rootcontext.cs (ResolveCore): Also include System.Exception
9192 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9193 we reach an EmptyStatement.
9195 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9198 * expression.cs (Binary.ResolveOperator): Check error result in
9201 use brtrue/brfalse directly and avoid compares to null.
9203 2002-08-02 Martin Baulig <martin@gnome.org>
9205 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9206 Fixes bug #28407, added test-155.cs.
9208 2002-08-01 Martin Baulig <martin@gnome.org>
9210 * class.cs (Event.EmitDefaultMethod): Make this work with static
9211 events. Fixes #28311, added verify-3.cs.
9213 2002-08-01 Martin Baulig <martin@gnome.org>
9215 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9216 `is_disposable' fields.
9217 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9218 `hm.is_disposable' if we're using the collection pattern.
9219 (Foreach.EmitCollectionForeach): Use the correct type for the
9220 enumerator's local variable, only emit the try/finally block if
9221 necessary (fixes #27713).
9223 2002-08-01 Martin Baulig <martin@gnome.org>
9225 * ecore.cs (Expression.report118): Renamed to Error118 and made
9228 * statement.cs (Throw.Resolve): Check whether the expression is of
9229 the correct type (CS0118) and whether the type derives from
9230 System.Exception (CS0155).
9231 (Catch.Resolve): New method. Do the type lookup here and check
9232 whether it derives from System.Exception (CS0155).
9233 (Catch.CatchType, Catch.IsGeneral): New public properties.
9235 * typemanager.cs (TypeManager.exception_type): Added.
9237 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9239 * driver.cs: Updated About function.
9241 2002-07-31 Martin Baulig <martin@gnome.org>
9243 Implemented Control Flow Analysis.
9245 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9246 (EmitContext.CurrentBranching): Added.
9247 (EmitContext.StartFlowBranching): Added.
9248 (EmitContext.EndFlowBranching): Added.
9249 (EmitContext.KillFlowBranching): Added.
9250 (EmitContext.IsVariableAssigned): Added.
9251 (EmitContext.SetVariableAssigned): Added.
9252 (EmitContext.IsParameterAssigned): Added.
9253 (EmitContext.SetParameterAssigned): Added.
9254 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9255 Added control flow analysis stuff here.
9257 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9258 resolve the expression as lvalue.
9259 (LocalVariableReference.DoResolve): Check whether the variable has
9260 already been assigned.
9261 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9262 the parameter as assigned here.
9263 (ParameterReference.DoResolve): Check whether the parameter has already
9265 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9266 expression as lvalue.
9268 * statement.cs (FlowBranching): New class for the flow analysis code.
9269 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9270 (LabeledStatement.IsDefined): New public property.
9271 (LabeledStatement.AddUsageVector): New public method to tell flow
9272 analyis that the label may be reached via a forward jump.
9273 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9275 (VariableInfo.Number): New public field. This is used by flow analysis
9276 to number all locals of a block.
9277 (Block.CountVariables): New public property. This is the number of
9278 local variables in this block (including the locals from all parent
9280 (Block.EmitMeta): Number all the variables.
9282 * statement.cs: Added flow analysis support to all classes.
9284 2002-07-31 Martin Baulig <martin@gnome.org>
9286 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9287 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9288 then use this argument.
9290 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9292 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9293 use this to specify /define options.
9295 2002-07-29 Martin Baulig <martin@gnome.org>
9297 * statement.cs (Fixed): Moved all code that does variable lookups
9298 and resolvings from Emit to Resolve.
9300 * statement.cs (For): Moved all code that does variable lookups
9301 and resolvings from Emit to Resolve.
9303 * statement.cs (Using): Moved all code that does variable lookups
9304 and resolvings from Emit to Resolve.
9306 2002-07-29 Martin Baulig <martin@gnome.org>
9308 * attribute.cs (Attribute.Resolve): Explicitly catch a
9309 System.NullReferenceException when creating the
9310 CustromAttributeBuilder and report a different warning message.
9312 2002-07-29 Martin Baulig <martin@gnome.org>
9314 * support.cs (ParameterData.ParameterName): Added method to
9315 get the name of a parameter.
9317 * typemanager.cs (TypeManager.IsValueType): New public method.
9319 2002-07-29 Martin Baulig <martin@gnome.org>
9321 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9322 is a flag which specifies that it's either ref or out.
9323 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9324 the out parameter to `out Parameter.Modifier mod', also set the
9325 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9327 * support.cs (InternalParameters.ParameterModifier): Distinguish
9328 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9329 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9331 * expression.cs (Argument.GetParameterModifier): Distinguish
9332 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9333 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9335 2002-07-29 Martin Baulig <martin@gnome.org>
9337 * expression.cs (ParameterReference.ParameterReference): Added
9338 `Location loc' argument to the constructor.
9340 * cs-parser.jay: Pass location to ParameterReference.
9342 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9344 * statement.cs (Try): Initialize the location.
9346 * cs-parser.jay: pass location to Try.
9348 * expression.cs (Unary.Reduce): Change the prototype to return
9349 whether a constant fold could be performed or not. The result is
9350 returned in an out parameters. In the case of Indirection and
9351 AddressOf, we want to perform the full tests.
9353 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9355 * statement.cs (Statement.Emit): Flag dead code.
9357 2002-07-27 Andrew Birkett <andy@nobugs.org>
9359 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9361 2002-07-27 Martin Baulig <martin@gnome.org>
9363 * class.cs (MethodData.Define): Put back call to
9364 TypeManager.AddMethod(), accidentally commented this out.
9366 * report.cs (Debug): New public method to print debugging information,
9367 this is `[Conditional ("DEBUG")]'.
9369 2002-07-26 Martin Baulig <martin@gnome.org>
9371 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9372 (switch_statement): Push the current_block to the switch_stack and
9373 pop it again when we're done with the switch.
9374 (switch_section): The new block is a child of the current_block.
9375 Fixes bug #24007, added test-152.cs.
9377 2002-07-27 Martin Baulig <martin@gnome.org>
9379 * expression.cs (Invocation.EmitArguments): When calling a varargs
9380 function with only its fixed arguments, we need to pass an empty
9383 2002-07-27 Martin Baulig <martin@gnome.org>
9385 Mono 0.13 has been released.
9387 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9389 * driver.cs: Rename --resource to --linkres, because that is what
9390 we do currently, we dont support --resource yet.
9392 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9394 2002-07-25 Martin Baulig <martin@gnome.org>
9396 * class.cs (MethodData): New public class. This is a `method builder'
9397 class for a method or one accessor of a Property/Indexer/Event.
9398 (MethodData.GetMethodFlags): Moved here from MemberBase.
9399 (MethodData.ApplyAttributes): Likewise.
9400 (MethodData.ApplyObsoleteAttribute): Likewise.
9401 (MethodData.ApplyConditionalAttribute): Likewise.
9402 (MethodData.ApplyDllImportAttribute): Likewise.
9403 (MethodData.CheckAbstractAndExternal): Likewise.
9404 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9405 (MethodData.Emit): Formerly known as Method.Emit().
9406 (MemberBase): Moved everything which was specific to a single
9407 accessor/method to MethodData.
9408 (Method): Create a new MethodData and call Define() and Emit() on it.
9409 (Property, Indexer, Event): Create a new MethodData objects for each
9410 accessor and call Define() and Emit() on them.
9412 2002-07-25 Martin Baulig <martin@gnome.org>
9414 Made MethodCore derive from MemberBase to reuse the code from there.
9415 MemberBase now also checks for attributes.
9417 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9418 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9420 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9421 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9422 (MemberBase.ApplyAttributes): New virtual method; applies the
9423 attributes to a method or accessor.
9424 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9425 (MemberBase.ApplyConditionalAttribute): Likewise.
9426 (MemberBase.ApplyDllImportAttribute): Likewise.
9427 (MemberBase.CheckAbstractAndExternal): Likewise.
9428 (MethodCore.ParameterTypes): This is now a property instead of a
9429 method, it's initialized from DoDefineParameters().
9430 (MethodCore.ParameterInfo): Removed the set accessor.
9431 (MethodCore.DoDefineParameters): New protected virtual method to
9432 initialize ParameterTypes and ParameterInfo.
9433 (Method.GetReturnType): We can now simply return the MemberType.
9434 (Method.GetMethodFlags): Override the MemberBase version and add
9435 the conditional flags.
9436 (Method.CheckBase): Moved some code from Define() here, call
9437 DoDefineParameters() here.
9438 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9439 here to avoid some larger code duplication.
9440 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9441 ensure that abstract and external accessors don't declare a body.
9443 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9444 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9445 lookup in the attribute's parent classes, so we need to abort as soon
9446 as we found the first match.
9447 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9448 the attribute has no arguments.
9450 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9453 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9455 * cs-parser.jay: reverted previous patch.
9457 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9459 * cs-parser.jay: fixed bug #22119.
9461 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9463 * attribute.cs: fixed compilation. The error was:
9464 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9465 be assigned to before control leaves the current method."
9466 [FIXME: Filed as bug #28186: MCS must report this error.]
9468 2002-07-25 Martin Baulig <martin@gnome.org>
9470 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9471 method to pull the condition name ouf of a Conditional attribute.
9472 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9473 the obsolete message and error flag out of an Obsolete attribute.
9475 * class.cs (Method.GetMethodFlags): New public method to get the
9476 TypeManager.MethodFlags for this method.
9477 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9479 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9480 if we're overriding a virtual function, set the new private variable
9481 `parent_method'; call the new TypeManager.AddMethod().
9483 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9484 the MethodBuilder and the Method in a PtrHashtable.
9485 (TypeManager.builder_to_method): Added for this purpose.
9486 (TypeManager.MethodFlags): Added IsObsoleteError.
9487 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9488 Obsolete and Conditional arguments in MethodBuilders. If we discover
9489 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9490 the message from the attribute.
9492 2002-07-24 Martin Baulig <martin@gnome.org>
9494 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9495 preprocessor directives, ensure that the argument to #define/#undef is
9496 exactly one identifier and that it's actually an identifier.
9498 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9501 2002-07-24 Martin Baulig <martin@gnome.org>
9503 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9504 initialize it to TypeManager.object_type in the constructor.
9505 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9506 of the `hm.get_current' method if we're using the collection pattern.
9507 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
9508 for the explicit conversion to make it work when we're using the collection
9509 pattern and the `Current' property has a different return type than `object'.
9512 2002-07-24 Martin Baulig <martin@gnome.org>
9514 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
9515 does not match, but don't report any errors. This method is called in
9516 order for all methods in a MethodGroupExpr until a matching method is
9517 found, so we don't want to bail out if the first method doesn't match.
9518 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
9519 matches, report the 123. Fixes #28070.
9521 2002-07-24 Martin Baulig <martin@gnome.org>
9523 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
9524 TypeManager.TypeToCoreType() to the top of the method so the
9525 following equality checks will work. Fixes #28107.
9527 2002-07-24 Martin Baulig <martin@gnome.org>
9529 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
9530 operand is of type uint, and the other operand is of type sbyte,
9531 short or int, the operands are converted to type long." -
9532 Actually do what this comment already told us. Fixes bug #28106,
9535 2002-07-24 Martin Baulig <martin@gnome.org>
9537 * class.cs (MethodBase): New abstract class. This is now a base
9538 class for Property, Indexer and Event to avoid some code duplication
9539 in their Define() and DefineMethods() methods.
9540 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
9541 generic methods for Define() and DefineMethods().
9542 (FieldBase): Derive from MemberBase, not MemberCore.
9543 (Property): Derive from MemberBase, not MemberCore.
9544 (Property.DefineMethod): Moved all the code from this method to the
9545 new MethodBase.DefineAccessor(), just call it with appropriate
9547 (Property.Define): Call the new Property.DoDefine(), this does some
9548 sanity checks and we don't need to duplicate the code everywhere.
9549 (Event): Derive from MemberBase, not MemberCore.
9550 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
9551 accessors, this will also make them work with interface events.
9552 (Indexer): Derive from MemberBase, not MemberCore.
9553 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
9554 (Indexer.Define): Use the new MethodBase functions.
9556 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
9557 argument to the constructor.
9558 (Interface.FindMembers): Added support for interface events.
9559 (Interface.PopluateEvent): Implemented.
9561 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
9563 2002-07-22 Miguel de Icaza <miguel@ximian.com>
9565 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
9566 but this is required to check for a method name being the same as
9567 the containing class.
9571 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9573 * interface.cs: initialize variable.
9575 2002-07-23 Martin Baulig <martin@gnome.org>
9577 Implemented the IndexerName attribute in interfaces.
9579 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
9580 name if this is an explicit interface implementation.
9581 (Indexer.InterfaceIndexerName): New public variable. If we're
9582 implementing an interface indexer, this is the IndexerName in that
9583 interface. Otherwise, it's the IndexerName.
9584 (Indexer.DefineMethod): If we're implementing interface indexer,
9585 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
9586 and Pending.ImplementIndexer methods.
9587 (Indexer.Define): Also define the PropertyBuilder if we're
9588 implementing an interface indexer and this is neither an explicit
9589 interface implementation nor do the IndexerName match the one in
9592 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
9593 If a method is defined here, then we always need to create a proxy
9594 for it. This is used when implementing interface indexers.
9595 (Pending.IsInterfaceIndexer): New public method.
9596 (Pending.ImplementIndexer): New public method.
9597 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
9598 This is used when implementing interface indexers to define a proxy
9600 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
9601 define a proxy if necessary.
9603 * interface.cs (Interface.IndexerName): New public variable.
9604 (Interface.PopulateIndexer): Set the IndexerName.
9605 (Interface.DefineIndexers): New private method. Populate all the
9606 indexers and make sure their IndexerNames match.
9608 * typemanager.cs (IndexerPropertyName): Added support for interface
9611 2002-07-22 Martin Baulig <martin@gnome.org>
9613 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
9614 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
9615 ret if HasReturnLabel.
9616 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
9619 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
9620 and set the ec.LoopBeginTryCatchLevel.
9621 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
9622 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
9623 the current ec.TryCatchLevel, the branch goes out of an exception
9624 block. In this case, we need to use Leave and not Br.
9626 2002-07-22 Martin Baulig <martin@gnome.org>
9628 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
9629 block unless the block does not always return or it is contained in
9630 another try { ... } catch { ... } block. Fixes bug #26506.
9631 Added verify-1.cs to the test suite.
9633 2002-07-22 Martin Baulig <martin@gnome.org>
9635 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
9636 then we do not always return. Fixes bug #24985.
9638 2002-07-22 Martin Baulig <martin@gnome.org>
9640 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
9641 lookup on a per-class level; ie. walk up the class hierarchy until we
9642 found at least one applicable method, then choose the best among them.
9643 Fixes bug #24463 and test-29.cs.
9645 2002-07-22 Martin Baulig <martin@gnome.org>
9647 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
9648 return types of the methods. The return type is not part of the
9649 signature and we must not check it to make the `new' modifier work.
9650 Fixes bug #27999, also added test-147.cs.
9651 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
9653 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
9654 on the method's return type.
9656 2002-07-21 Martin Baulig <martin@gnome.org>
9658 * assign.cs: Make this work if the rightmost source is a constant and
9659 we need to do an implicit type conversion. Also adding a few more tests
9660 to test-38.cs which should have caught this.
9662 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
9663 target in the makefile for this. The makefile.gnu is primarily intended
9664 for end-users who don't want to debug the compiler.
9666 2002-07-21 Martin Baulig <martin@gnome.org>
9668 * assign.cs: Improved the Assign class so it can now handle embedded
9669 assignments (X = Y = Z = something). As a side-effect this'll now also
9670 consume less local variables. test-38.cs now passes with MCS, added
9671 a few new test cases to that test.
9673 2002-07-20 Martin Baulig <martin@gnome.org>
9675 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
9676 instructions. Fixes bug #27977, also added test-146.cs.
9678 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9680 * cs-tokenizer.cs: fixed getHex ().
9682 2002-07-19 Martin Baulig <martin@gnome.org>
9684 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
9685 not Type.GetType() to lookup the array type. This is needed when
9686 we're constructing an array of a user-defined type.
9687 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
9688 single-dimensional arrays, but also for single-dimensial arrays of
9691 2002-07-19 Martin Baulig <martin@gnome.org>
9693 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
9694 this function is called, it's not allowed to share LocalBuilders
9697 2002-07-19 Martin Baulig <martin@gnome.org>
9699 * expression.cs (Argument.Resolve): Report an error 118 when trying
9700 to pass a type as argument.
9702 2002-07-18 Martin Baulig <martin@gnome.org>
9704 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
9705 Conv_R_Un for the signed `long' type.
9707 2002-07-15 Miguel de Icaza <miguel@ximian.com>
9709 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
9710 `expr' for the temporary result, as that will fail if we do
9711 multiple resolves on the same expression.
9713 2002-07-05 Miguel de Icaza <miguel@ximian.com>
9715 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
9716 ec.TypeContainer for looking up aliases.
9718 * class.cs (TypeContainer): Remove LookupAlias from here.
9720 * decl.cs (DeclSpace); Move here.
9722 2002-07-01 Miguel de Icaza <miguel@ximian.com>
9724 * class.cs (FindMembers): Only call filter if the constructor
9725 bulider is not null.
9727 Also handle delegates in `NestedTypes' now. Now we will perform
9728 type lookups using the standard resolution process. This also
9731 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
9732 This uses Expressions (the limited kind that can be parsed by the
9733 tree) instead of strings.
9735 * expression.cs (ComposedCast.ToString): Implement, used to flag
9736 errors since now we have to render expressions.
9738 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
9741 * ecore.cs (SimpleName.ToString): ditto.
9743 * cs-parser.jay: Instead of using strings to assemble types, use
9744 Expressions to assemble the type (using SimpleName, ComposedCast,
9745 MemberAccess). This should fix the type lookups in declarations,
9746 because we were using a different code path for this.
9748 * statement.cs (Block.Resolve): Continue processing statements
9749 even when there is an error.
9751 2002-07-17 Miguel de Icaza <miguel@ximian.com>
9753 * class.cs (Event.Define): Also remove the `remove' method from
9754 the list of pending items.
9756 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
9757 generate more compact code.
9759 2002-07-17 Martin Baulig <martin@gnome.org>
9761 * const.cs (Const.LookupConstantValue): Add support for constant
9762 `unchecked' and `checked' expressions.
9763 Also adding test case test-140.cs for this.
9765 2002-07-17 Martin Baulig <martin@gnome.org>
9767 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
9768 check whether mi.ReturnType implements the IEnumerator interface; the
9769 `==' and the IsAssignableFrom() will fail in this situation.
9771 2002-07-16 Ravi Pratap <ravi@ximian.com>
9773 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
9776 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9778 * expression.cs: fixed bug #27811.
9780 2002-07-14 Miguel de Icaza <miguel@ximian.com>
9782 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
9783 Molaro: when we are a ref, the value already contains a pointer
9784 value, do not take the address of it.
9786 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
9787 * removed mb-parser.jay and mb-tokenizer.cs
9789 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
9791 * expression.cs: check against the building corlib void type.
9793 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
9795 * ecore.cs: fix for valuetype static readonly fields: when
9796 initializing them, we need their address, not the address of a copy.
9798 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
9800 * typemanager.cs: register also enum_type in corlib.
9802 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
9804 * class.cs: allow calling this (but not base) initializers in structs.
9806 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
9808 * ecore.cs: make sure we compare against the building base types
9811 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
9813 * typemanager.cs: fix TypeToCoreType() to handle void and object
9814 (corlib gets no more typerefs after this change).
9816 2002-07-12 Miguel de Icaza <miguel@ximian.com>
9818 * expression.cs (ArrayCreation.EmitArrayArguments): use
9819 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
9821 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
9822 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
9823 array indexes, the runtime actually forbids them.
9825 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
9826 for array arguments here.
9828 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
9829 instead of the default for ValueTypes.
9831 (New.DoEmit): Use IsValueType instead of
9832 IsSubclassOf (value_type)
9833 (New.DoResolve): ditto.
9834 (Invocation.EmitCall): ditto.
9836 * assign.cs (Assign): ditto.
9838 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
9839 Statements *are* currently doing part of their resolution during
9842 Expressions do always resolve during resolve, but statements are
9843 only required to propagate resolution to their children.
9845 2002-07-11 Miguel de Icaza <miguel@ximian.com>
9847 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
9849 (LoadAssembly): Do not add the dll if it is already specified
9851 (MainDriver): Add the System directory to the link path at the end,
9852 after all the other -L arguments.
9854 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
9855 wrong opcode for loading bytes and bools (ldelem.i1 instead of
9856 ldelem.u1) and using the opposite for sbytes.
9858 This fixes Digger, and we can finally run it.
9860 * driver.cs (UnixParseOption): Move the option parsing here.
9861 (CSCParseOption): Implement CSC-like parsing of options.
9863 We now support both modes of operation, the old Unix way, and the
9864 new CSC-like way. This should help those who wanted to make cross
9867 The only thing broken is that /r:, /reference: and /lib: are not
9868 implemented, because I want to make those have the same semantics
9869 as the CSC compiler has, and kill once and for all the confussion
9870 around this. Will be doing this tomorrow.
9872 * statement.cs (Unsafe.Resolve): The state is checked during
9873 resolve, not emit, so we have to set the flags for IsUnsfe here.
9875 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9877 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
9878 not catch the Error_ObjectRefRequired in SimpleName (as it is
9879 possible to have a class/instance variable name that later gets
9880 deambiguated), we have to check this here.
9882 2002-07-10 Ravi Pratap <ravi@ximian.com>
9884 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
9885 make static and put into Expression.
9887 (Event.Define): Register the private field of the event with the
9888 TypeManager so that GetFieldFromEvent can get at it.
9890 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
9891 keep track of the private field associated with an event which
9894 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
9897 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
9899 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9901 * expression.cs (Binary.EmitBranchable): this routine emits the
9902 Binary expression in a branchable context. This basically means:
9903 we need to branch somewhere, not just get the value on the stack.
9905 This works together with Statement.EmitBoolExpression.
9907 * statement.cs (Statement.EmitBoolExpression): Use
9910 2002-07-09 Miguel de Icaza <miguel@ximian.com>
9912 * statement.cs (For): Reduce the number of jumps in loops.
9914 (For): Implement loop inversion for the For statement.
9916 (Break): We can be breaking out of a Try/Catch controlled section
9917 (foreach might have an implicit try/catch clause), so we need to
9918 use Leave instead of Br.
9920 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
9921 now). If the instace expression supports IMemoryLocation, we use
9922 the AddressOf method from the IMemoryLocation to extract the
9923 address instead of emitting the instance.
9925 This showed up with `This', as we were emitting the instance
9926 always (Emit) instead of the Address of This. Particularly
9927 interesting when This is a value type, as we dont want the Emit
9928 effect (which was to load the object).
9930 2002-07-08 Miguel de Icaza <miguel@ximian.com>
9932 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
9934 * statement.cs (Checked): Set the CheckedState during the resolve
9935 process too, as the ConvCast operations track the checked state on
9936 the resolve process, and not emit.
9938 * cs-parser.jay (namespace_member_declaration): Flag that we have
9939 found a declaration when we do. This is used to flag error 1529
9941 * driver.cs: Report ok when we display the help only.
9943 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
9945 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
9947 2002-07-04 Miguel de Icaza <miguel@ximian.com>
9949 * cs-tokenizer.cs (define): We also have to track locally the
9950 defines. AllDefines is just used for the Conditional Attribute,
9951 but we also need the local defines for the current source code.
9953 2002-07-03 Miguel de Icaza <miguel@ximian.com>
9955 * statement.cs (While, For, Do): These loops can exit through a
9956 Break statement, use this information to tell whether the
9957 statement is the last piece of code.
9959 (Break): Flag that we break.
9961 * codegen.cs (EmitContexts): New `Breaks' state variable.
9963 2002-07-03 Martin Baulig <martin@gnome.org>
9965 * class.cs (TypeContainer.MethodModifiersValid): Allow override
9966 modifiers in method declarations in structs. Otherwise, you won't
9967 be able to override things like Object.Equals().
9969 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9971 * class.cs (Method, Property, Indexer): Do not allow the public
9972 modifier to be used in explicit interface implementations.
9974 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
9975 override modifiers in method declarations in structs
9977 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
9979 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
9980 integer or real overflow, report an error
9982 2002-07-02 Martin Baulig <martin@gnome.org>
9984 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
9985 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
9986 to tell the runtime about our newly created System.Object and
9987 System.ValueType types.
9989 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9991 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
9992 struct instead of Ldarg/Starg.
9994 2002-07-02 Martin Baulig <martin@gnome.org>
9996 * expression.cs (Indirection.Indirection): Call
9997 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
9999 2002-07-02 Martin Baulig <martin@gnome.org>
10001 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10002 ValueType, call TypeManager.TypeToCoreType() on it.
10003 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10004 the OpCodes.Newarr argument.
10006 2002-07-02 Martin Baulig <martin@gnome.org>
10008 * expression.cs (Invocation.EmitCall): When compiling corlib,
10009 replace all calls to the system's System.Array type to calls to
10010 the newly created one.
10012 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10013 System.Array methods.
10014 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10015 from the system's System.Array type which must be replaced.
10017 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10019 * typemanager.cs: load unverifiable_code_ctor so we can build
10020 corlib using the correct type. Avoid using GetTypeCode() with
10022 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10023 TypeManager.object_type to allow building corlib.
10025 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10027 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10029 2002-07-01 Martin Baulig <martin@gnome.org>
10031 * class.cs: Make the last change actually work, we need to check
10032 whether `ifaces != null' to avoid a crash.
10034 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10036 * class.cs: when we build structs without fields that implement
10037 interfaces, we need to add the interfaces separately, since there is
10038 no API to both set the size and add the interfaces at type creation
10041 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10043 * expression.cs: the dimension arguments to the array constructors
10044 need to be converted if they are a long.
10046 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10048 * class.cs: don't emit ldarg.0 if there is no parent constructor
10049 (fixes showstopper for corlib).
10051 2002-06-29 Martin Baulig <martin@gnome.org>
10053 MCS now compiles corlib on GNU/Linux :-)
10055 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10056 ie. check for MethodImplOptions.InternalCall.
10058 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10059 and TypeManager.attribute_type are null, so we must explicitly check
10060 whether parent is not null to find out whether it's an attribute type.
10061 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10062 and SetBuilder, not only if the property is neither abstract nor external.
10063 This is necessary to set the MethodImplOptions on the accessor methods.
10064 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10065 SetBuilder, see Property.Emit().
10067 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10068 populate "System.Object", "System.ValueType" and "System.Attribute" since
10069 they've already been populated from BootCorlib_PopulateCoreTypes().
10071 2002-06-29 Martin Baulig <martin@gnome.org>
10073 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10074 is the NullLiteral, we also need to make sure that target_type is not
10077 2002-06-29 Martin Baulig <martin@gnome.org>
10079 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10080 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10081 before calling BootstrapCorlib_ResolveDelegate ().
10083 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10085 * statement.cs: fixed build-breaker. All tests passed ok.
10087 2002-06-27 Martin Baulig <martin@gnome.org>
10089 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10090 for System.Decimal when compiling corlib.
10092 2002-06-27 Martin Baulig <martin@gnome.org>
10094 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10095 switch blocks which contain nothing but a default clause.
10097 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10099 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10101 2002-06-27 Martin Baulig <martin@gnome.org>
10103 * ecore.cs (PropertyExpr.PropertyExpr): Call
10104 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10106 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10107 is already a TypeBuilder.
10109 2002-06-27 Martin Baulig <martin@gnome.org>
10111 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10112 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10113 the "from an array-type to System.Array" case. This makes it work
10114 when compiling corlib.
10116 2002-06-27 Martin Baulig <martin@gnome.org>
10118 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10119 non-static PropertyExpr, set its InstanceExpression. This makes
10120 the `ICollection.Count' property work in System/Array.cs.
10122 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10124 * driver.cs: Made error handling more consistent. Errors now
10125 tracked by Report class, so many methods which used to return int
10126 now return void. Main() now prints success/failure and
10127 errors/warnings message.
10129 Renamed '--probe' compiler argument to '--expect-error'. Removed
10130 the magic number return values (123 and 124). Now, if the
10131 expected error occurs, the compiler exits with success (exit value
10132 0). If the compilation completes without seeing that particular
10133 error, the compiler exits with failure (exit value 1). The
10134 makefile in mcs/errors has been changed to handle the new behaviour.
10136 * report.cs: Made 'expected error' number a property and renamed
10137 it from 'Probe' to 'ExpectedError'.
10139 * genericparser.cs: Removed error handling support, since it is
10140 now all done by Report class.
10142 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10143 class, so parse() no longer returns an int.
10145 * namespace.cs: Use Report.Error instead of GenericParser.error
10147 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10149 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10150 TypeContainer.AddOperator): At the front of the list put the
10151 explicit implementations, so they get resolved/defined first.
10153 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10155 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10156 interface type is implemented by this TypeContainer. Used during
10157 explicit interface implementation.
10159 (Property.Define, Indexer.Define, Method.Define): Validate that
10160 the given interface in the explicit implementation is one of the
10161 base classes for the containing type.
10163 Also if we are explicitly implementing an interface, but there is
10164 no match in the pending implementation table, report an error.
10166 (Property.Define): Only define the property if we are
10167 not explicitly implementing a property from an interface. Use the
10168 correct name also for those properties (the same CSC uses,
10169 although that is really not needed).
10171 (Property.Emit): Do not emit attributes for explicitly implemented
10172 properties, as there is no TypeBuilder.
10174 (Indexer.Emit): ditto.
10176 Hiding then means that we do not really *implement* a pending
10177 implementation, which makes code fail.
10179 2002-06-22 Martin Baulig <martin@gnome.org>
10181 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10182 the return value of Object.GetType(). [FIXME: we need to do this whenever
10183 we get a type back from the reflection library].
10185 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10187 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10189 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10191 * attribute.cs: Return null if we can not look up the type.
10193 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10194 the interface types found.
10196 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10197 interface types found.
10199 * typemanager.cs (GetInterfaces): Make this routine returns alll
10200 the interfaces and work around the lame differences between
10201 System.Type and System.Reflection.Emit.TypeBuilder in the results
10202 result for GetInterfaces.
10204 (ExpandInterfaces): Given an array of interface types, expand and
10205 eliminate repeated ocurrences of an interface. This expands in
10206 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10209 2002-06-21 Martin Baulig <martin@gnome.org>
10211 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10214 2002-06-21 Martin Baulig <martin@gnome.org>
10216 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10217 and called with one of the core types, return the corresponding typebuilder for
10220 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10223 2002-06-21 Martin Baulig <martin@gnome.org>
10225 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10226 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10227 (Expression.ConvertReferenceExplicit): Likewise.
10229 * expression.cs (ElementAccess.DoResolve): Likewise.
10230 (ElementAccess.DoResolveLValue): Likewise.
10232 2002-06-10 Martin Baulig <martin@gnome.org>
10234 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10235 add the "value" parameter to the parameter list.
10237 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10240 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10242 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10243 the argument to an int, uint, long or ulong, per the spec. Also
10244 catch negative constants in array creation.
10246 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10248 * class.cs: do not allow the same interface to appear twice in
10249 the definition list.
10251 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10253 * ecore.cs: don't use ldlen with System.Array.
10255 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10257 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10259 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10261 * modifiers.cs: produce correct field attributes for protected
10262 internal. Easy fix so miguel can work on ther harder stuff:-)
10264 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10266 * pending.cs: New file. Move the code from class.cs here.
10267 Support clearning the pending flag for all methods (when not doing
10268 explicit interface implementation).
10270 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10272 * rootcontext.cs: added a couple more types needed to bootstrap.
10274 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10276 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10277 constructor in the type, instead of any constructor in the type
10278 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10279 a bug in the Mono runtime when applying the params attribute).
10281 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10282 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10284 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10286 * expression.cs (Unary.ResolveOperator): Use TypeManager
10287 to resolve the type.
10289 2002-06-13 Ravi Pratap <ravi@ximian.com>
10291 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10294 * enum.cs (AddEnumMember): Add support to store the attributes associated
10295 with each member too.
10297 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10298 field builders too - this takes care of the enum member case.
10300 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10302 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10303 address-of operator on both value types and pointers.
10305 2002-06-10 Martin Baulig <martin@gnome.org>
10307 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10308 PropertyBuilder to the `property_builders' list.
10310 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10311 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10312 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10313 find any indexers which are inherited from an interface.
10315 2002-06-09 Martin Baulig <martin@gnome.org>
10317 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10318 the same type as the constant if necessary. There's also a test-130.cs
10321 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10323 * typemanager.cs (TypeManager.ChangeType): Previously known as
10324 Enum.ChangeEnumType().
10326 2002-06-09 Martin Baulig <martin@gnome.org>
10328 * expression.cs (Cast.TryReduce): Added support for consts.
10330 2002-06-08 Ravi Pratap <ravi@ximian.com>
10332 * class.cs (Accessor): Hold attributes information so we can pass
10335 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10336 Modify to pass in attributes attached to the methods.
10338 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10340 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10341 to handle the Accessor kind :-)
10343 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10345 2002-06-08 Martin Baulig <martin@gnome.org>
10347 * expression.cs (Unary.TryReduceNegative): Added support for
10350 2002-06-08 Martin Baulig <martin@gnome.org>
10352 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10353 name can't be found in the `defined_names' - the caller will do a
10354 MemberLookup in this case and thus find methods in System.Enum
10355 such as Enum.IsDefined().
10357 2002-06-08 Martin Baulig <martin@gnome.org>
10359 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10360 Convert.ChangeType() which works with TypeBuilder created types.
10361 (Enum.LookupEnumValue, Enum.Define): Use it here.
10363 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10364 `TypeBuilder.BaseType != null' check.
10365 (TypeContainer.FindMembers): Only lookup parent members if we
10366 actually have a parent.
10367 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10368 (ConstructorInitializer.Resolve): Likewise.
10370 * interface.cs (Interface.FindMembers): Added
10371 `TypeBuilder.BaseType != null' check.
10373 * rootcontext.cs (RootContext.ResolveCore): Added
10374 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10375 classes_second_stage.
10377 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10378 debug_type and trace_type when compiling with --nostdlib.
10380 2002-06-07 Martin Baulig <martin@gnome.org>
10382 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10383 (AddField): Set it to true when adding a non-static field.
10384 (DefineType): Use `have_nonstatic_fields' to find out whether we
10385 have non-static fields, not `Fields != null'.
10387 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10389 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10390 dereferencing a null on the static-field code path)
10392 2002-05-30 Martin Baulig <martin@gnome.org>
10394 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10395 to take command line arguments. Use reflection to call the new
10396 custom `Initialize' function on the symbol writer and pass it the
10397 command line arguments.
10399 * driver.cs (--debug-args): New command line argument to pass command
10400 line arguments to the symbol writer.
10402 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10404 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10405 the target type for indexers and properties. Thanks to Joe for
10408 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10410 * typemanager.cs (MethodFlags): returns the method flags
10411 (Obsolete/ShouldIgnore) that control warning emission and whether
10412 the invocation should be made, or ignored.
10414 * expression.cs (Invocation.Emit): Remove previous hack, we should
10415 not do this on matching a base type, we should do this based on an attribute
10417 Only emit calls to System.Diagnostics.Debug and
10418 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10419 on the command line.
10421 * rootcontext.cs: Global settings for tracing and debugging.
10423 * cs-tokenizer.cs (define): New utility function to track
10424 defines. Set the global settings for TRACE and DEBUG if found.
10426 2002-05-25 Ravi Pratap <ravi@ximian.com>
10428 * interface.cs (Populate*): Pass in the TypeContainer as well as
10429 the DeclSpace as parameters so that we can create EmitContexts and
10430 then use that to apply attributes etc.
10432 (PopulateMethod, PopulateEvent, PopulateProperty)
10433 (PopulateIndexer): Apply attributes everywhere.
10435 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10438 (ApplyAttributes): Update accordingly.
10440 We now apply interface attributes for all members too.
10442 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10444 * class.cs (Indexer.Define); Correctly check if we are explicit
10445 implementation (instead of checking the Name for a ".", we
10446 directly look up if the InterfaceType was specified).
10448 Delay the creation of the PropertyBuilder.
10450 Only create the PropertyBuilder if we are not an explicit
10451 interface implementation. This means that explicit interface
10452 implementation members do not participate in regular function
10453 lookups, and hence fixes another major ambiguity problem in
10454 overload resolution (that was the visible effect).
10456 (DefineMethod): Return whether we are doing an interface
10459 * typemanager.cs: Temporary hack until we get attributes in
10460 interfaces (Ravi is working on that) and we get IndexerName
10461 support in interfaces.
10463 * interface.cs: Register the indexers as properties.
10465 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10466 warning, I have verified that this is a bug in the .NET runtime
10467 (JavaScript suffers of the same problem).
10469 * typemanager.cs (MemberLookup): When looking up members for
10470 interfaces, the parent of an interface is the implicit
10471 System.Object (so we succeed in searches of Object methods in an
10472 interface method invocation. Example: IEnumerable x; x.ToString
10475 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10477 * class.cs (Event): Events should also register if they do
10478 implement the methods that an interface requires.
10480 * typemanager.cs (MemberLookup); use the new GetInterfaces
10483 (GetInterfaces): The code used to lookup interfaces for a type is
10484 used in more than one place, factor it here.
10486 * driver.cs: Track the errors at the bottom of the file, we kept
10489 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10490 instance if the method we are calling is static!
10492 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10494 * attribute.cs (ApplyAttributes): Make this function filter out
10495 the IndexerName attribute (as that attribute in reality is never
10496 applied) and return the string constant for the IndexerName
10499 * class.cs (TypeContainer.Emit): Validate that all the indexers
10500 have the same IndexerName attribute, and if so, set the
10501 DefaultName attribute on the class.
10503 * typemanager.cs: The return value might contain other stuff (not
10504 only methods). For instance, consider a method with an "Item"
10505 property and an Item method.
10507 * class.cs: If there is a problem with the parameter types,
10510 2002-05-24 Ravi Pratap <ravi@ximian.com>
10512 * ecore.cs (ImplicitConversionExists): Wrapper function which also
10513 looks at user defined conversion after making a call to
10514 StandardConversionExists - we need this for overload resolution.
10516 * expression.cs : Update accordingly the various method calls.
10518 This fixes 2 bugs filed against implicit user defined conversions
10520 2002-05-22 Miguel de Icaza <miguel@ximian.com>
10522 * statement.cs: Track the result of the assignment.
10524 2002-05-21 Miguel de Icaza <miguel@ximian.com>
10526 * expression.cs (MemberAccess): Improved error reporting for
10527 inaccessible members.
10529 2002-05-22 Martin Baulig <martin@gnome.org>
10531 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
10532 itself with debugging support.
10534 2002-05-22 Martin Baulig <martin@gnome.org>
10536 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
10537 Removed, this isn't needed anymore.
10539 2002-05-20 Martin Baulig <martin@gnome.org>
10541 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
10542 be underlying type for an enum.
10544 2002-05-20 Miguel de Icaza <miguel@ximian.com>
10546 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
10547 that splits out the loading of just the core types.
10549 * rootcontext.cs (ResolveCore): Split the struct resolution in
10550 two, so we can load the enumeration underlying types before any
10553 * expression.cs (Is): Bandaid until we fix properly Switch (see
10554 bug #24985 for details).
10556 * typemanager.cs (ImplementsInterface): The hashtable will contain
10557 a null if there are no interfaces implemented.
10559 2002-05-18 Miguel de Icaza <miguel@ximian.com>
10561 * cs-parser.jay (indexer_declarator): It is fine to have array
10564 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10566 * typemanager.cs: (RegisterBuilder): New function used to register
10567 TypeBuilders that implement interfaces. Since
10568 TypeBuilder.GetInterfaces (as usual) does not work with lame
10570 (AddUserType): register interfaces.
10572 (ImplementsInterface): Use the builder_to_ifaces hash if we are
10573 dealing with TypeBuilder. Also, arrays are showing up as
10574 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
10575 methods can not be invoked on them!
10577 * ecore.cs (ExplicitReferenceConversionExists): Made public.
10578 (ImplicitReferenceConversionExists): Split out from
10579 StandardConversionExists.
10581 * expression.cs (As): We were only implementing one of the three
10582 cases for the as operator. We now implement them all.
10583 (Is): Implement the various other cases for Is as well.
10585 * typemanager.cs (CACHE): New define used to control if we want or
10586 not the FindMembers cache. Seems to have a negative impact on
10587 performance currently
10589 (MemberLookup): Nested types have full acess to
10590 enclosing type members
10592 Remove code that coped with instance/static returns for events, we
10593 now catch this in RealFindMembers.
10595 (RealFindMembers): only perform static lookup if the instance
10596 lookup did not return a type or an event.
10598 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10600 * assign.cs (CompoundAssign): We pass more semantic information
10601 now to Compound Assignments than we did before: now we have all
10602 the information at hand, and now we resolve the target *before* we
10603 do the expression expansion, which allows the "CacheValue" method
10604 to have the effect we intended (before, a [x] += 1 would generate
10605 two differen ArrayAccess expressions from the ElementAccess,
10606 during the resolution process).
10608 (CompoundAssign.DoResolve): Resolve target and original_source here.
10610 2002-05-16 Miguel de Icaza <miguel@ximian.com>
10612 * expression.cs (ArrayAccess): dropped debugging information.
10614 * typemanager.cs: Small bug fix: I was always returning i_members,
10615 instead of one of i_members or s_members (depending on which had
10618 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
10619 method is invoked before any code generation takes place, and it
10620 is a mechanism to inform that the expression will be invoked more
10621 than once, and that the method should use temporary values to
10622 avoid having side effects
10624 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
10626 * ecore.cs (Expression.CacheTemporaries): Provide empty default
10629 * expression.cs (Indirection, ArrayAccess): Add support for
10630 CacheTemporaries in these two bad boys.
10632 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
10633 ldobj or ldind_ref.
10634 (StoreFromPtr): Handle stobj as well.
10636 * expression.cs (UnaryMutator): Share more code.
10638 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
10639 down: I was not tracking the Filter function as well, which
10640 was affecting the results of the cache.
10642 2002-05-15 Miguel de Icaza <miguel@ximian.com>
10644 * attribute.cs: Remove the hack to handle the CharSet property on
10647 2002-05-14 Miguel de Icaza <miguel@ximian.com>
10649 * attribute.cs (DoResolve): More uglyness, we now only try to
10650 resolve the attribute partially, to extract the CharSet
10651 information (only if we are a StructLayout attribute). Otherwise
10653 (GetExtraTypeInfo): Add some code to conditionally kill in the
10654 future this. I am more and more convinced that the .NET
10655 framework has special code to handle the attribute setting on
10658 * expression.cs (IsParamsMethodApplicable): Revert my previous
10659 foreach change here, it was wrong.
10661 2002-05-13 Miguel de Icaza <miguel@ximian.com>
10663 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
10664 (pp_expr): do not abort on unknown input, just return.
10665 (eval): abort if there are pending chars.
10667 * attribute.cs (Attribute.Resolve): Positional parameters are
10668 optional. Deal with that case.
10670 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
10671 the Ansi/Unicode/Auto information for the type.
10673 (TypeContainer.DefineType): instantiate the EmitContext here, as
10674 we will be using it during the type definition (to resolve
10675 attributes) and during the emit phase.
10677 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
10678 to pull type information out of the attributes
10680 (Attribute.Resolve): track the constructor builder, and allow for
10681 multiple invocations (structs and classes will use this).
10683 * ecore.cs (MemberLookupFinal): new version with all the
10684 parameters customizable.
10686 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
10687 constructors. Return if the result value is null (as the error
10688 would have been flagged already by MemberLookupFinal)
10690 Do not allow instances of abstract classes or interfaces to be
10693 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
10694 We have to compare the assembly property here when dealing with
10695 FamANDAssem and Assembly access modifiers, because we might be
10696 creating an assembly from *modules* (that means that we are not
10697 getting TypeBuilders for types defined in other modules that are
10698 part of this assembly).
10700 (Method.Emit): If the method is marked abstract and has a body,
10703 (TypeContainer.DefineMembers): If both the defined member and the
10704 parent name match are methods, then do not emit any warnings: let
10705 the Method.Define routine take care of flagging warnings. But if
10706 there is a mismatch (method overrides something else, or method is
10707 overriwritten by something, then emit warning).
10709 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
10710 set to null, this means `do not check for the return type on the
10713 (Method.Define): set the return type for the method signature to
10714 null, so that we get methods with the same name and parameters and
10715 different return types. This is used to flag warning 114 (you are
10716 hiding a method, and you probably want to use the new/override
10719 * typemanager.cs (MemberLookup): Implemented proper access
10720 control, closing a long standing set of bug reports. The problem
10721 was that the Framework only has two bits: Public and NonPublic,
10722 and NonPublic includes private and protected methods, but we need
10723 to enforce the FamANDAssem, FamOrAssem and Family.
10725 2002-05-11 Miguel de Icaza <miguel@ximian.com>
10727 * statement.cs (GotoCase): Return true: Ammounts to giving up
10728 knowledge on whether we return or not, and letting the other case
10729 be responsible for it.
10731 2002-05-10 Miguel de Icaza <miguel@ximian.com>
10733 * driver.cs: Do not load directories for each file processed, only
10734 do it if there is a pattern.
10736 * ecore.cs: Report readonly assigns here as well, as we might have
10737 been resolved only by MemberAccess.
10739 (SimpleName.SimpleNameResolve): Also be useful for LValue
10740 resolution. We need this to propagate assign to local readonly variables
10742 * typemanager.cs: Use a ptrhashtable for the criteria, because we
10743 do not want to reuse potential criteria memory.
10745 * class.cs (MyEventBuilder): Set reflected_type;
10747 * ecore.cs (Constantify): Added support for constifying bools.
10749 (RootContext.LookupType): Added a cache for values looked up in
10750 the declaration space.
10752 * typemanager.cs (FindMembers): Now is a front-end to
10753 RealFindMembers, and provides a two-level hashtable-based cache to
10756 15% performance improvement: from 22.5 to 19.2 seconds.
10758 * expression.cs (IsParamsMethodApplicable): use foreach.
10759 (Invocation.DoResolve): ditto.
10760 (New.DoResolve): ditto.
10761 (ArrayCreation.DoResolve): ditto.
10763 * ecore.cs (FindMostEncompassingType): use foreach.
10765 * delegate.cs (NewDelegate.DoResolve): Use foreach
10767 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
10768 (RemoveMethods): use foreach.
10770 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
10771 nested foreach statements instead of for, and also break out of
10772 the inner loop once a match is found.
10774 (Invocation.OverloadResolve): Use foreach, simplify the code.
10776 2002-05-08 Miguel de Icaza <miguel@ximian.com>
10778 * cfold.cs (BinaryFold): During an enumeration evaluation context,
10779 we actually unwrap the expression to allow for extra information
10782 * expression.cs: Use Shr_Un on unsigned operations.
10784 2002-05-08 Ravi Pratap <ravi@ximian.com>
10786 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
10787 applicable operators was not being considered correctly. This closes
10788 the bug Miguel reported.
10790 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
10792 * attribute.cs: check that the type derives from System.Attribute
10793 and report the correct error in that case (moved the duplicate code to
10794 its own method, too).
10796 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
10798 * attribute.cs: lookup attribute type name as the spec says: first the
10799 bare attribute name and then name + "Attribute" (nant compiles with
10800 mcs after this fix).
10802 2002-05-07 Miguel de Icaza <miguel@ximian.com>
10804 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
10805 Because of the way we parse things, we should try to see if a
10806 UIntConstant can fit in an integer.
10808 2002-05-07 Ravi Pratap <ravi@ximian.com>
10810 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
10811 when we are in an explicit context.
10813 (ConvertReferenceExplicit): When converting from Iface type S to Class
10814 T make sure the rules are implemented as an OR.
10816 * parameter.cs (ParameterType): Make it a property for now although the
10817 purpose really isn't anything immediate.
10819 * expression.cs (Is*Applicable): Do better checking on the parameter type
10820 of a ref/out parameter. The ones from the system assemblies are already
10821 marked with the correct type so we don't need to do any correction.
10823 * ecore.cs (StandardConversionExists): Conversion from Interface types to
10824 the object type is standard too so include that.
10826 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10828 * ecore.cs (StandardConversionExists): Augment with missing code:
10829 deal with IntConstant, LongConstants and Enumerations.
10831 * assign.cs: Report the error, instead of failing silently
10833 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
10834 typecontainer that they are declared, because the
10835 typecontainer/namespace will have the list of using clauses that
10836 need to be applied.
10838 Assembly Attributes were escaping the normal registration
10841 (EmitCode): Apply attributes within an EmitContext that represents
10842 the container they were declared on.
10844 * cs-parser.jay: Track bases for structs. How did I get this wrong?
10846 2002-05-06 Ravi Pratap <ravi@ximian.com>
10848 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
10849 Revamp completely - make much cleaner as we now operate only
10852 (FindMostSpecificSource, FindMostSpecificTarget): New methods
10853 to implement the logic detailed in the spec more correctly.
10855 (UserDefinedConversion): Update accordingly.
10857 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10859 * statement.cs: Return flow analysis information up.
10861 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
10864 (token): Do not consume an extra character before calling
10867 2002-05-06 Piers Haken <piersh@friskit.com>
10869 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
10871 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10873 * class.cs (Constructor.Emit): Set the IsStatic flag in the
10874 EmitContext during the instance constructor initializer
10875 resolution, to stop access to instance variables.
10877 This is mandated by the spec, last paragraph of the `constructor
10878 initializers' section.
10880 2002-05-05 Miguel de Icaza <miguel@ximian.com>
10882 * cs-parser.jay, class.cs (Accessor): new class used to represent
10883 an accessor (get or set). In the past we used `null' to represent
10884 a missing accessor. But this is ambiguous because there was no
10885 way to tell in abstract indexers/properties if one of them was
10888 Now there is a way of addressing that.
10890 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
10891 instead of FindMembers.
10893 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
10894 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
10896 * attribute.cs: Treat indexers and properties as the same in terms
10897 of applying attributes
10899 * ecore.cs (FindMostEncompassedType): Use statically initialized
10900 EmptyExpressions()s like we do elsewhere to avoid creating useless
10901 objects (and we take this out of the tight loop).
10903 (GetConversionOperators): Move the code to extract the actual
10904 operators to a separate routine to clean things up.
10906 2002-05-04 Miguel de Icaza <miguel@ximian.com>
10908 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
10909 events are always registered FieldBuilders.
10911 * class.cs (FieldBase): New class shared by Fields
10913 * delegate.cs: If we are a toplevel delegate, use our full name.
10914 If we are a nested delegate, then only use our tail name.
10916 2002-05-02 Ravi Pratap <ravi@ximian.com>
10918 * expression.cs (IsApplicable): Ensure that we add the "&" to
10919 ref/out types before comparing it with the type of the argument.
10921 (IsParamsMethodApplicable): Ditto.
10923 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
10926 * delegate.cs : Handle the case when we have more than one applicable
10927 method. Flag an error only when we finish checking all.
10929 2002-05-02 Miguel de Icaza <miguel@ximian.com>
10931 * expression.cs: Add support for boolean static initializers.
10933 2002-05-01 Miguel de Icaza <miguel@ximian.com>
10935 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
10937 * parameter.cs (ComputeParameterTypes,
10938 ComputeAndDefineParameterTypes): Better error handling: now we
10939 clear the `types' cache if we fail during any of the type lookups.
10940 We also return the status code correctly to our caller
10942 * delegate.cs: If we fail to define a delegate, abort the extra
10945 * expression.cs (Binary.ResolveOperator): for
10946 operator==(object,object) and operator !=(object, object) we also
10947 have to verify that there is an implicit conversion from one to
10950 (ArrayAccess.DoResolve): Array Access can operate on
10953 2002-04-30 Miguel de Icaza <miguel@ximian.com>
10955 * assign.cs (CompoundAssign): A new class used as a "flag" that
10956 the assignment actually is happening as part of a compound
10957 assignment operator.
10959 During compound assignment, a few new rules exist to enable things
10966 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
10967 to the type of x) if y is implicitly convertible to the type of x,
10968 and the operator is a builtin operator and the return type of the
10969 operator is explicitly convertible to the type of x.
10971 * rootcontext.cs: Reset warning level to 2. 4 catches various
10972 "interesting" features in mcs, we must clean this up at some
10973 point, but currently am trying to kill other bugs ;-)
10975 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
10976 in container classes as well.
10978 * expression.cs (Binary.ResolveOperator): Handle string case
10979 before anything else (as operator overloading does emit an error
10980 before doing anything else).
10982 This code could go away when we move to a table driven model, but
10983 i could not come up with a good plan last night.
10985 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
10987 * typemanager.cs (CSharpName): reimplementation using regex.
10988 * class.cs: added null check for fields in Emit
10989 * rootcontext.cs: set warninglevel to 4
10991 2002-04-29 Miguel de Icaza <miguel@ximian.com>
10993 * typemanager.cs (CSharpName): reimplemented with Lupus
10996 2002-04-28 Miguel de Icaza <miguel@ximian.com>
10998 * statement.cs (If): correclty implement Resolve, because we were
10999 not catching sem errors in there. The same process is needed
11001 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11004 (Statement.Warning_DeadCodeFound): Factorize code.
11005 (While): Report dead code here too.
11007 (Statement): Added Resolve virtual method to allow
11008 for resolution split from the emit code.
11010 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11012 * statement.cs (EmitBoolExpression): No longer try to resolve the
11014 (MakeBoolean): New utility function that resolve, implicitly
11015 converts to boolean and tags the expression.
11018 (If, Do): Implement dead code elimination.
11019 (While): Implement loop inversion
11021 (Do, While, For, If): Resolve the expression prior to calling our
11024 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11027 - added method Report28 (warning: program has more than one entry point)
11028 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11029 - modified method Method.Define, the part at the end of the method
11031 * rootcontext.cs: added static public Location EntryPointLocation;
11033 * ../errors/cs0028.cs : Add test case for the above warning.
11036 - modified method CSharpName to allow arrays of primitive type to
11037 be printed nicely (e.g. instead of System.Int32[][] it now prints
11039 - added method CSharpSignature: returns the signature of a method
11040 in string format to be used in reporting errors, warnings, etc.
11042 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11045 2002-04-26 Ravi Pratap <ravi@ximian.com>
11047 * delegate.cs (Define): Fix extremely silly bug where I was
11048 setting the type of the 'object' parameter of the BeginInvoke
11049 method to System.IAsyncResult instead of System.Object ;-)
11051 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11053 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11056 (Constructor.Emit): return if we fail to initialize the
11057 constructor. Another door closed!
11059 * expression.cs (New.DoResolve): Improve error message (from -6 to
11060 1501). Use DeclaredOnly lookup to find the exact constructor.
11062 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11063 loop. This is useful.
11065 * cs-parser.jay: Adjust the default parameters so that destructors
11066 have the proper signature.
11068 2002-04-26 Martin Baulig <martin@gnome.org>
11070 * driver.cs (LoadAssembly): If `assembly' contains any characters
11071 which are only valid in path names and not in assembly names
11072 (currently slash, backslash and point), use Assembly.LoadFrom ()
11073 instead of Assembly.Load () on the `assembly' (before iteration
11074 over the link_paths).
11076 2002-04-26 Martin Baulig <martin@gnome.org>
11078 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11080 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11082 * class.cs (Property): use the new typemanager.MemberLookup
11084 (TypeContainer.MemberLookup): Implement using the
11085 TypeManager.MemberLookup now.
11087 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11088 and return MemberInfos, so that these can be used without an
11089 EmitContext (what we had before).
11091 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11093 * expression.cs: Fix the case where the argument to params if the
11094 type of the params. I omitted handling this before. Fixed
11096 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11098 * driver.cs: Call BootCorlib_PopulateCoreType
11100 * class.cs (Property.CheckBase): Check for properties only, not
11103 * interface.cs: Temporary hack: try/catch around the
11104 CustomAttributeBuilder, because I am getting an exception that I
11107 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11108 types whose definitions are required to be there (attributes are
11109 defined before standard types).
11111 Compute definitions as we boot the various types, as they are used
11112 immediately (value_type class will need object_type, but if we do
11113 not initialize object_type, we will pass a null, which will let
11114 the runtime pick the System.Object from the existing corlib, which
11115 is not what we want).
11117 2002-04-22 Patrik Torstensson <totte@labs2.com>
11119 * cs-tokenizer.cs: fixed a number of trim() issues.
11121 2002-04-22 Ravi Pratap <ravi@ximian.com>
11123 * expression.cs (Argument.Type): Ensure that we return the correct
11124 type when we have out or ref parameters [in which case we
11127 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11129 * class.cs (Property, Indexer): Allow extern modifier in there.
11131 * typemanager.cs (InitBaseTypes): Initializes object_type and
11132 value_type, since those will be used early on during the bootstrap
11133 process to compile corlib.
11135 (InitCoreTypes): Move code from here to InitBaseTypes.
11137 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11139 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11140 single-dimension arrays as using the ldlen opcode.
11142 Daniel Lewis discovered this optimization.
11144 * typemanager.cs: Add signature for System.Array::get_Length
11146 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11148 * statement.cs: report the error when the foreach does not apply to an
11149 array nor a collection.
11151 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11153 * expression.cs: Add implicit conversions to the operator ~.
11155 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11157 * typemanager.cs: Locate the decimal constructor.
11159 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11161 * attribute.cs: use the new property of TypeOf.
11162 * expression.cs: added 'get' property around typearg.
11164 These changes fix a build breaker reported by NickD. Is this the
11165 correct way to fix? If not, please, revert my changes and make it
11168 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11170 * attribute.cs: Add support for typeof in attribute invocations.
11171 I am not sure that this is right though.
11173 2002-04-14 Duncan Mak <duncan@ximian.com>
11175 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11176 Binary.Operator.Division case.
11178 2002-04-13 Ravi Pratap <ravi@ximian.com>
11180 * class.cs (DefineType): Ensure that we do a proper check on
11181 attribute types and also register it with the TypeManager.
11183 (TypeContainer.Targets): The default for attribute types is
11184 AttributeTargets.All.
11186 * attribute.cs (ApplyAttributes): Registering the attribute type
11187 is done elsewhere, not when we discover we have a Usage attribute.
11189 2002-04-12 Ravi Pratap <ravi@ximian.com>
11191 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11192 and get rid of is_delegate parameter.
11194 * everywhere : update.
11196 2002-04-12 Ravi Pratap <ravi@ximian.com>
11198 * cs-parser.jay (compilation_unit): Revamp completely to use
11199 some new ideas that I got from Rhys' grammar to solve the problems
11200 with assembly level attributes.
11202 (outer_declaration): New grammar production.
11204 (attribute_sections): Add.
11206 (opt_attributes): Base on attribute_sections
11208 (namespace_declaration): Allow opt_attributes to tackle the case
11209 when we have assembly level attributes - we are clever in this
11212 * attribute.cs (ApplyAttributes): Do not worry about assembly
11213 attributes in the non-global context.
11215 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11216 instead of SetGlobalAttributes.
11218 * class.cs, rootcontext.cs : Ensure we define and generate
11219 attribute types before anything else.
11221 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11222 and flag the new error -20 for the case when the attribute type
11223 does not have valid targets specified. csc does not catch this.
11225 * ../errors/errors.txt : update for error # -20
11227 2002-04-11 Ravi Pratap <ravi@ximian.com>
11229 * support.cs (InternalParameters.ParameterModifier): Do some null
11230 checking and return sane values.
11232 * class.cs (Method.Define): If we are a PInvoke method, ensure
11233 that we are static and extern. Report error # 601
11235 * ../errors/cs0601.cs : Add test case for the above error.
11237 2002-04-07 Ravi Pratap <ravi@ximian.com>
11239 * rootcontext.cs (attribute_types): We need to keep type of
11240 all attribute types separately and emit code for them first.
11242 (RegisterAttribute) : Implement.
11244 * class.cs (DefineType): Check if the current Type is a custom
11245 attribute type and register it accordingly.
11247 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11248 adding the first attribute twice and rename to
11250 (SetGlobalAttributes): this.
11252 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11255 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11256 if we are processing global arguments. Hmm, I am unsure of this.
11258 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11260 * expression.cs: added static array of strings to avoid calling
11261 Enum.ToString () for Operator in Binary. Significant recover of
11264 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11266 * class.cs (FindMembers): Allow the Builders of the various
11267 members to be null. If they are skip them. This only happens
11268 during the PInvoke declaration.
11270 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11272 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11273 failure, so we do not keep going afterwards.
11275 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11276 wanted to pass `false' as the `is_delegate' argument. If this is
11277 the case, why not use delegate_type == null to mean `is_delegate =
11278 false' and anything else as is_delegate = true.
11280 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11282 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11283 code for the section, not the beginning of the tests.
11285 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11287 * cfold.cs: Handle operator + (Enum x, Underlying x)
11289 * expression.cs (Binary): same. Warn about errors where we have
11290 Enum/Enum in operator + as well.
11292 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11295 - added support for switch(bool)
11296 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11297 - add TableSwitchEmit() to handle table-based switch statements
11299 2002-04-05 Ravi Pratap <ravi@ximian.com>
11301 * expression.cs (Invocation.OverloadResolve): Factor out code which
11302 does parameter compatibility checking with arguments so that we can
11303 re-use the code even from Delegate.VerifyApplicability
11305 (VerifyArgumentsCompat): Move above code here.
11307 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11308 and instead make a call to the above method.
11310 2002-03-31 Ravi Pratap <ravi@ximian.com>
11312 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11313 We use it to keep track of classes which are attribute types.
11315 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11317 * delegate.cs (Delegate.Define): Correctly define the types in the
11318 presence of fixed and array parameters.
11320 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11323 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11324 include NonPublic after the first iteration.
11326 * class.cs (Indexer.CheckBase): Only check if both parents are
11329 * cs-parser.jay (accessor_body): If empty, set to null.
11331 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11332 same code path here to resolve constants names that we did have in
11333 MemberAccess.DoResolve. There is too much code duplicated here.
11335 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11337 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11339 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11342 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11343 tokens, numbers and strings.
11345 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11348 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11349 asyncronous parameters and the regular parameters.
11351 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11352 specify the target directory.
11354 * expression.cs: (This.DoResolve): Simplify
11355 (As.Emit): Optimize, do not generate IsInst if the expression is
11356 always of the given type.
11358 (Is.DoResolve): Bug fix, we were reporting both always/never for
11361 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11362 creating too many unnecessary arrays.
11364 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11366 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11367 fields instead of rolling our own initializer. Takes care of all
11368 implicit conversions, and drops unnecessary static checks/argument.
11370 2002-03-31 Dick Porter <dick@ximian.com>
11372 * driver.cs: use the GetDirectories() return values properly, and
11373 use "/" as path separator.
11375 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11377 * expression.cs (Unary): Optimize - - expr into expr.
11378 (Binary): Optimize a + (-b) into a -b.
11380 * codegen.cs (CodeGen): Made all methods static.
11382 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11386 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11387 TypeBuilder property.
11389 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11392 * tree.cs: Removed the various RecordXXXX, and replaced with a
11393 single RecordDecl. Removed all the accessor methods, and just
11394 left a single access point Type
11396 * enum.cs: Rename DefineEnum to DefineType.
11398 * decl.cs: New abstract method `DefineType' used to unify the
11399 Defines for Enumerations, Interfaces, TypeContainers and
11402 (FindType): Moved LookupInterfaceOrClass here. Moved the
11403 LookupBaseClasses method that used to live in class.cs and
11404 interface.cs here, and renamed to FindType.
11406 * delegate.cs: Implement DefineType. Take advantage of the
11407 refactored pattern for locating the parent builder without taking
11408 the parent_builder argument (which we know does not work if we are
11409 nested, and triggering a toplevel definition).
11411 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11413 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11414 accessibility of a member has changed during override and report
11417 * class.cs (Method.Define, Property.Define): Only complain on
11418 overrides if the method is private, any other accessibility is
11419 fine (and since we just checked the permission is the same, we are
11422 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11423 and elif are processed always. The other pre-processing
11424 directives are only processed if we are "taking" the path
11426 2002-03-29 Martin Baulig <martin@gnome.org>
11428 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11429 current location is not Null.
11431 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11432 a separate method so we can profile it.
11434 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11435 `span.Seconds' are just seconds, but no minutes or hours.
11436 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11438 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11440 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11441 Remove the gratuitous set of Final:
11443 // If an interface implementation, then we can set Final.
11444 if (((flags & MethodAttributes.Abstract) == 0) &&
11445 implementing.DeclaringType.IsInterface)
11446 flags |= MethodAttributes.Final;
11448 I do not know what I was smoking when I used that.
11451 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11452 step into fixing the name resolution issues for delegates and
11453 unifying the toplevel name resolution.
11455 2002-03-28 Martin Baulig <martin@gnome.org>
11457 * class.cs (Method.Emit): If we have a symbol writer, call its
11458 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11459 tell it about the current method.
11461 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11462 writer that we're going to emit the first byte of IL code for a new
11463 statement (a new source line).
11464 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11465 EmitContext.Mark() before emitting any code.
11467 * location.cs (SymbolDocument): Return null when we're Null.
11469 * statement.cs (Statement): Moved the `Location loc' variable here.
11470 (Statement.EmitBoolExpression): If we have a symbol writer, call
11471 ec.Mark() before emitting any code to tell it that we're at the
11472 beginning of a new statement.
11473 (StatementExpression): Added `Location' argument to the constructor.
11474 (Block): Added public readonly variable `StartLocation' and public
11475 variable `EndLocation'. The latter is to be set using SetEndLocation().
11476 (Block): Added constructor which takes a start and end location.
11477 (Block.SetEndLocation): New method. This sets the end location.
11478 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11479 local variables we create.
11480 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11481 each statement and do also mark the begin and end of the block.
11483 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11484 tell it the current lexer.Location, use Location.Null for the end of the
11486 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11487 current block, set its end location using SetEndLocation().
11488 (statement_expression): StatementExpression constructor now takes the
11489 lexer.Location as additional argument.
11490 (for_statement, declare_local_variables): Likewise.
11491 (declare_local_variables): When creating a new implicit block, use the
11492 new Block constructor and pass it the lexer.Location.
11494 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11496 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11497 members also on the parent interfaces recursively.
11499 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11501 * report.cs: Use new formats, since Gonzalo finished the missing
11504 * expression.cs (Binary.ResolveOperator): added missing operator|
11505 operator& and operator^ for bool/bool.
11507 * cs-parser.jay: CheckDef now takes a Location argument that is
11508 used to report errors more precisly (instead of reporting the end
11509 of a definition, we try to track something which is a lot closer
11510 to the source of the problem).
11512 * cs-tokenizer.cs: Track global token use, so we can properly flag
11513 the use of #define/#undef after the first token has been seen.
11515 Also, rename the reportXXXX to Error_DescriptiveName
11517 * decl.cs (DeclSpace.IsTopLevel): Move property here from
11518 TypeContainer, so that Enum and Interface can use this too.
11520 * class.cs (TypeContainer.LookupInterfaceOrClass,
11521 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
11522 `builder' argument. Typically this was used to pass the parent
11523 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
11526 The problem is that a nested class could trigger the definition of
11527 a toplevel class, and the builder would be obviously wrong in that
11530 So we drop this argument, and we compute dynamically the
11531 TypeBuilder/ModuleBuilder (the correct information was available
11532 to us anyways from DeclSpace.Parent)
11534 * interface.cs (Interface.DefineInterface): Drop builder
11535 parameter cleanup like class.cs
11537 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
11540 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
11543 (Try.Emit): Propagate the returns value from the statement.
11545 (Return.Emit): Even if we are leavning
11547 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
11549 * modifiers.cs: Fix the computation of MethodAttributes flags.
11551 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
11553 * driver.cs: allow compilation of files that start with '/'.
11554 Add a default case when checking the argument of --target.
11556 2002-03-25 Miguel de Icaza <miguel@ximian.com>
11558 * interface.cs: Implement the same search algorithm for types in
11559 the interface code.
11561 * delegate.cs: Do not allow multiple definition.
11563 * Recovered ChangeLog that got accidentally amputated
11565 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
11567 * rootcontext.cs: Load manually enum to allow core classes to
11568 contain enumerations.
11570 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
11571 Update to new static methods in TypeManager.
11573 * typemanager.cs (GetMethod, GetConstructor): Use our
11574 implementation of FindMembers to find the members, since during
11575 corlib compilation, the types are TypeBuilders and GetMethod and
11576 GetConstructor do not work.
11578 Make all methods in TypeManager static.
11580 (InitCodeHelpers): Split the functionality from
11581 the InitCodeTypes function.
11583 * driver.cs: Call InitCodeHelpers after we have populated the
11586 * cs-parser.jay (delegate_declaration): we did not used to compute
11587 the delegate name correctly for void delegates.
11589 2002-03-24 Miguel de Icaza <miguel@ximian.com>
11591 * rootcontext.cs (RootContext): Init the interface_resolve_order
11592 and type_container_resolve_order always.
11594 (ResolveCore, BootstrapCorlib_ResolveClass,
11595 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
11596 compiler when compiling with --nostdlib
11598 * class.cs (TypeContainer.DefineType): Check that our parent is
11599 not null. This test is most important when we are bootstraping
11602 * codegen.cs: Split out the symbol writing code.
11604 2002-03-25 Martin Baulig <martin@gnome.org>
11606 * driver.cs (-g): Made -g an alias for --debug.
11608 2002-03-24 Martin Baulig <martin@gnome.org>
11610 * codegen.cs (SymbolWriter): New public variable. Returns the
11611 current symbol writer.
11612 (CodeGen): Added `bool want_debugging_support' argument to the
11613 constructor. If true, tell the ModuleBuild that we want debugging
11614 support and ask it for the ISymbolWriter.
11615 (Save): If we have a symbol writer, call it's Close() method after
11616 saving the assembly.
11618 * driver.c (--debug): New command line argument to create a
11619 debugger information file.
11621 * location.cs (SymbolDocument): New public property. Returns an
11622 ISymbolDocumentWriter object for the current source file or null
11623 if we don't have a symbol writer.
11625 2002-03-21 Miguel de Icaza <miguel@ximian.com>
11627 * driver.cs (LoadAssembly): Correctly return when all the paths
11628 have been tried and not before.
11630 * statement.cs (Switch.Emit): return the actual coverage for this
11631 statement (returns/not-returns)
11633 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
11634 switch of the statement if we are the last switch section. That
11635 kills two problems: try/catch problems (we used to emit an empty
11636 nop at the end) and switch statements where all branches would
11639 2002-03-19 Miguel de Icaza <miguel@ximian.com>
11641 * driver.cs: Add default assemblies (the equivalent to the
11642 Microsoft CSC.RSP file)
11644 * cs-tokenizer.cs: When updating `cols and setting it to zero,
11645 also update tokens_seen and set it to false.
11647 * driver.cs: Implement --recurse for Mike.
11649 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
11650 correctly splitting out the paths.
11652 2002-03-18 Miguel de Icaza <miguel@ximian.com>
11654 * interface.cs (Interface.PopulateProperty): Instead of using
11655 `parent' as the declaration space for the set parameters, use
11658 * support.cs (InternalParameters): InternalParameters constructor
11659 takes a DeclSpace instead of a TypeContainer.
11661 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
11662 types are being initialized, load the address of it before calling
11665 (New): Provide a mechanism to disable the generation of local
11666 value type temporaries when the caller will be providing us with
11667 an address to store it.
11669 (ArrayCreation.EmitDynamicInitializers): Use it.
11671 2002-03-17 Miguel de Icaza <miguel@ximian.com>
11673 * expression.cs (Invocation.EmitArguments): Only probe for array
11674 property if there is more than one argument. Sorry about that.
11676 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
11677 empty param arrays.
11679 * class.cs (Method.LabelParameters): Fix incorrect code path that
11680 prevented the `ParamArrayAttribute' from being applied to the
11683 2002-03-16 Miguel de Icaza <miguel@ximian.com>
11685 * support.cs (ReflectionParameters): Correctly compute whether the
11686 last argument is a params array. Fixes the problem with
11689 * typemanager.cs: Make the assemblies array always be non-null
11690 (empty, but non-null)
11692 * tree.cs (RecordDecl): New function that abstracts the recording
11693 of names. This reports error 101, and provides a pointer to the
11694 previous declaration. Fixes a crash in the compiler.
11696 * cs-parser.jay (constructor_declaration): Update to new grammar,
11697 and provide a constructor_body that can be empty.
11699 2002-03-15 Miguel de Icaza <miguel@ximian.com>
11701 * driver.cs: Add support for --resources.
11703 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
11704 Make all types for the various array helper methods be integer.
11706 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
11707 CheckState to ConvCast.
11709 (ConvCast): Now it takes a `checked' state argument, to avoid
11710 depending on the emit context for the conversion, and just using
11711 the resolve time setting.
11713 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
11714 instead of Invocation.EmitArguments. We do not emit the original
11715 arguments, instead we emit those which have been converted to
11716 unsigned int expressions.
11718 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
11720 * codegen.cs: ditto.
11722 * expression.cs (LocalVariableReference): Drop the use of the
11723 Store function that depended on the variable index.
11725 * statement.cs (VariableInfo): Drop the `Idx' property from this
11726 class, as this is not taking into account the indexes for
11727 temporaries tat we generate during the execution, getting the
11730 * class.cs: First emit class initializers, then call the parent
11733 * expression.cs (Binary): Fix opcode emision.
11734 (UnaryMutator.EmitCode): Support checked code generation
11736 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
11737 matches for events for both the Static and Instance scans,
11738 pointing to the same element. Fix that.
11740 2002-03-14 Miguel de Icaza <miguel@ximian.com>
11742 * rootcontext.cs (ResolveTree): Always set the
11743 interface_resolve_order, because nested interfaces will be calling
11746 * class.cs (GetInterfaceOrClass): Track the same resolution
11747 process used by TypeManager.LookupType. This fixes the nested
11748 type lookups in class declarations (separate path from
11751 (TypeContainer.DefineType): Also define nested interfaces.
11752 (TypeContainer.RegisterOrder): New public function used to
11753 register the order in which child interfaces need to be closed.
11755 Nested interfaces need to be closed after their parents have been
11758 * interface.cs (InterfaceAttr): Put all the logic for computing
11759 the interface attribute here.
11761 (DefineInterface): Register our interface order with the
11762 RootContext or with the TypeContainer depending on the case.
11764 2002-03-12 Miguel de Icaza <miguel@ximian.com>
11766 * cs-parser.jay: rework foreach statement to work with the new
11767 changes to the policy on SimpleNames.
11769 * report.cs: support Stacktrace on warnings as well.
11771 * makefile: drop --unsafe and /unsafe from the compile.
11773 2002-03-13 Ravi Pratap <ravi@ximian.com>
11775 * ecore.cs (StandardConversionExists): Modify to take an Expression
11776 as the first parameter. Ensure we do null -> reference type conversion
11779 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
11780 temporary Expression objects.
11782 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
11784 * interface.cs: workaround bug in method overloading resolution
11785 (there is already a bugzilla bug for it).
11787 2002-03-12 Miguel de Icaza <miguel@ximian.com>
11789 We could also solve this problem by having a separate path for
11790 performing type lookups, instead of DoResolve, we could have a
11791 ResolveType entry point, and only participating pieces of the
11792 production (simplename, deref, array) would implement this.
11794 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
11795 signal SimpleName to only resolve type names and not attempt to
11796 resolve anything else.
11798 * expression.cs (Cast): Set the flag.
11800 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
11802 * class.cs: Only report 108 if there is no `new' modifier.
11804 * cs-parser.jay: rework foreach statement to work with the new
11805 changes to the policy on SimpleNames.
11807 * report.cs: support Stacktrace on warnings as well.
11809 * makefile: drop --unsafe and /unsafe from the compile.
11811 2002-03-11 Miguel de Icaza <miguel@ximian.com>
11813 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
11814 lookups here, instead of doing that at parse time. This means
11815 that our grammar will not introduce `LocalVariableReferences' as
11816 expressions at this point. That solves the problem of code like
11820 static void Main ()
11824 This is only half the fix. The full fix requires parameters to
11825 also be handled in this way.
11827 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
11828 makes the use more obvious of the DeclSpace. The
11829 ec.TypeContainer.TypeBuilder is now only used to pull the
11830 TypeBuilder for it.
11832 My theory is that I can get rid of the TypeBuilder completely from
11833 the EmitContext, and have typecasts where it is used (from
11834 DeclSpace to where it matters).
11836 The only pending problem is that the code that implements Aliases
11837 is on TypeContainer, and probably should go in DeclSpace.
11839 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
11840 lookups here, instead of doing that at parse time. This means
11841 that our grammar will not introduce `LocalVariableReferences' as
11842 expressions at this point. That solves the problem of code like
11846 static void Main ()
11850 This is only half the fix. The full fix requires parameters to
11851 also be handled in this way.
11853 * class.cs (Property.DefineMethod): When implementing an interface
11854 method, set newslot, when implementing an abstract method, do not
11855 set the flag (before we tried never setting it, or always setting
11856 it, which is the difference).
11857 (Indexer.DefineMethod): same.
11858 (Method.DefineMethod): same.
11860 * ecore.cs: Only set the status used flag if we get back a Field.
11862 * attribute.cs: Temporary hack, so Paolo can keep working.
11864 2002-03-08 Ravi Pratap <ravi@ximian.com>
11866 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
11867 the unmanaged type in the case we have a MarshalAs attribute.
11869 (Resolve): Handle the case when we are parsing the special MarshalAs
11870 attribute [we need to store the unmanaged type to use later]
11872 * typemanager.cs (marshal_as_attr_type): Built in type for the
11873 MarshalAs Attribute.
11875 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
11876 on parameters and accordingly set the marshalling info.
11878 2002-03-09 Miguel de Icaza <miguel@ximian.com>
11880 * class.cs: Optimizing slightly by removing redundant code after
11881 we switched to the `NoTypes' return value.
11882 (Property.DefineMethod): use NoTypes here too.
11884 This fixes the bug I introduced in my last batch of changes.
11886 2002-03-05 Ravi Pratap <ravi@ximian.com>
11888 * tree.cs (RecordEnum): Add. We now keep track of enums too.
11890 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
11891 Enums since those are types too.
11893 * cs-parser.jay (enum_declaration): Record enums as we parse them.
11895 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
11896 thanks to a call during the lookup process.
11898 2002-03-07 Miguel de Icaza <miguel@ximian.com>
11900 * statement.cs (Foreach): Lots of work to accomodate a particular
11901 kind of foreach statement that I had not kept in mind. It is
11902 possible to have foreachs on classes that provide a GetEnumerator
11903 method that return objects that implement the "pattern" for using
11904 a foreach, there is no need to support GetEnumerator
11907 This is needed to compile nant.
11909 * decl.cs: Only report 114 if the member is not `Finalize' and if
11910 the warning level is at least 2.
11912 * class.cs: Moved the compare function from Method to
11915 (MethodSignature.InheritableMemberSignatureCompare): Add new
11916 filter function that is used to extract inheritable methods from a
11919 (Method.Define): Use the new `inheritable_method_signature_filter'
11922 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
11925 2002-03-06 Miguel de Icaza <miguel@ximian.com>
11927 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
11929 * cs-parser.jay: Add opt_semicolon to the interface declaration.
11931 * expression.cs: Pass location information to
11932 ConvertImplicitStandard.
11934 * class.cs: Added debugging code to track return values from
11937 2002-03-05 Miguel de Icaza <miguel@ximian.com>
11939 * expression.cs (Is.DoResolve): If either side of the `is' is an
11940 interface, do not flag the warning.
11942 * ecore.cs (ImplicitReferenceConversion): We need a separate test
11945 * report.cs: Allow for --fatal to be used with --probe.
11947 * typemanager.cs (NoTypes): Move the definition for the empty Type
11950 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
11952 (TypeContainer.DefineProxy): New function used to proxy to parent
11953 implementations when implementing interfaces.
11954 (TypeContainer.ParentImplements): used to lookup if our parent
11955 implements a public function that is required by an interface.
11956 (TypeContainer.VerifyPendingMethods): Hook this up.
11958 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
11959 `modules' and `assemblies' arraylists into arrays. We only grow
11960 these are the very early start up of the program, so this improves
11961 the speedof LookupType (nicely measured).
11963 * expression.cs (MakeByteBlob): Replaced unsafe code with
11964 BitConverter, as suggested by Paolo.
11966 * cfold.cs (ConstantFold.Binary): Special case: perform constant
11967 folding of string concatenation, but if either side is a string,
11968 and the other is not, then return null, and let the runtime use
11969 the concatenation on the string plus the object (using
11970 `Object.ToString').
11972 2002-03-04 Miguel de Icaza <miguel@ximian.com>
11974 Constant Folding has been implemented now.
11976 * expression.cs (Unary.Reduce): Do not throw an exception, catch
11977 the error instead on types that are not supported in one's
11980 * constant.cs (Constant and all children): New set of functions to
11981 perform implict and explicit conversions.
11983 * ecore.cs (EnumConstant): Implement the new functions to perform
11984 conversion by proxying to the child expression.
11986 * codegen.cs: (ConstantCheckState): Constant evaluation has its
11987 own separate setting that can not be turned off from the command
11988 line using --unchecked or --checked and is only controlled using
11989 the checked/unchecked statements and expressions. This setting is
11990 used by the constant folder to flag errors.
11992 * expression.cs (CheckedExpr, UncheckedExpr): Set the
11993 ConstantCheckState as well.
11995 During Resolve, they also have to flag the state, because the
11996 constant folder runs completely in the Resolve phase.
11998 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12001 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12003 * cfold.cs: New file, this file contains the constant folder.
12005 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12006 argument to track whether we are using the resulting address to
12007 load or store a value and provide better error messages.
12009 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12010 new AddressOf arguments.
12012 * statement.cs (Foreach.EmitCollectionForeach): Update
12014 * expression.cs (Argument.Emit): Call AddressOf with proper
12015 arguments to track usage.
12017 (New.DoEmit): Call AddressOf with new arguments.
12019 (Unary.Emit): Adjust AddressOf call.
12021 2002-03-01 Ravi Pratap <ravi@ximian.com>
12023 * cs-parser.jay (member_access): Change the case for pre-defined types
12024 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12027 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12030 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12031 essentially like methods and apply attributes like MethodImplOptions to them too.
12033 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12036 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12037 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12040 * Update code everywhere accordingly.
12042 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12044 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12046 2002-02-28 Ravi Pratap <ravi@ximian.com>
12048 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12049 try performing lookups against those instead of jumping straight into using
12050 the 'using' clauses.
12052 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12054 (LookupType): Perform lookups in implicit parents too.
12056 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12057 sequence as RootContext.LookupType.
12059 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12060 the various cases of namespace lookups into this method.
12062 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12064 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12065 in positional arguments)
12067 * class.cs (Operator): Update the AllowedModifiers to contain
12070 * cs-parser.jay: Update operator declaration to allow for the
12071 operator body to be empty.
12073 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12076 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12078 * class.cs (Method.Emit): Label parameters.
12080 * driver.cs: Return 1 or 0 as the program exit code.
12082 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12084 * expression.cs: Special case the `null' object when trying to
12085 auto-compute the type, as anything can be explicitly converted to
12088 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12089 spotting this Paolo.
12091 (Expression.ImplicitNumericConversion): Perform comparissions of
12092 the type using the underlying type in the case of an enumeration
12093 rather than using the enumeration type for the compare.
12095 Cope with the underlying == type case, which is not possible to
12098 (Expression.ConvertNumericExplicit): Perform comparissions of
12099 the type using the underlying type in the case of an enumeration
12100 rather than using the enumeration type for the compare.
12102 * driver.cs: If the user does not supply an extension, assume .exe
12104 * cs-parser.jay (if_statement): Rewrote so that we can track the
12105 location for the if statement.
12107 * expression.cs (Binary.ConstantFold): Only concat strings when
12108 the operation is "+", not everything ;-)
12110 * statement.cs (Statement.EmitBoolExpression): Take a location
12112 (If, While, Do): Track location.
12114 * expression.cs (Binary.ResolveOperator): In the object + string
12115 case, I was missing a call to ConvertImplicit
12117 2002-02-25 Ravi Pratap <ravi@ximian.com>
12119 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12120 Location arguments. Ensure we use RootContext.LookupType to do our work
12121 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12123 * interface.cs (PopulateMethod): Handle the type of the parameter being
12126 * expression.cs (Invocation.BetterFunction): Handle the case when we
12127 have a params method with no fixed arguments and a call is made with no
12130 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12132 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12133 the verbatim-string-literal
12135 * support.cs (InternalParameters.ParameterModifier): handle null
12137 (InternalParameters.ParameterType): ditto.
12139 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12140 duplicating the name of the variable parameter.
12141 (GetParameterByName): Fix bug where we were not looking up array
12142 paramters if they were the only present (thanks Paolo!).
12143 (GetParameterInfo): We only have an empty set of types if both
12144 fixed and array are set to null.
12145 (GetParameterInfo-idx): Handle FixedParameter == null
12147 * cs-parser.jay: Handle the case where there is no catch
12148 statements (missing null test).
12150 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12152 * driver.cs (MainDriver): Be conservative on our command line
12155 Catch DirectoryNotFoundException when calling GetFiles.
12157 (SplitPathAndPattern): Used to split the input specification into
12158 a path and a pattern that we can feed to Directory.GetFiles.
12160 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12162 * statement.cs (Fixed): Implement the last case of the Fixed
12163 statement (string handling).
12165 * expression.cs (StringPtr): New class used to return a char * to
12166 a string; Used by the Fixed statement.
12168 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12170 * expression.cs (Binary.ResolveOperator): Remove redundant
12171 MemberLookup pn parent type.
12172 Optimize union call, we do not need a union if the types are the same.
12173 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12176 Specialize the use of MemberLookup everywhere, instead of using
12177 the default settings.
12179 (StackAlloc): Implement stackalloc keyword.
12181 * cs-parser.jay: Add rule to parse stackalloc.
12183 * driver.cs: Handle /h, /help, /?
12185 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12186 before we supported unsafe code.
12188 * makefile: add --unsafe to the self compilation of mcs.
12190 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12192 * expression.cs (PointerArithmetic): New class that is used to
12193 perform pointer arithmetic.
12194 (Binary.Resolve): Handle pointer arithmetic
12195 Handle pointer comparission.
12196 (ArrayPtr): Utility expression class that is used to take the
12197 address of an array.
12199 (ElementAccess): Implement array access for pointers
12201 * statement.cs (Fixed): Implement fixed statement for arrays, we
12202 are missing one more case before we are done.
12204 * expression.cs (Indirection): Implement EmitAssign and set the
12205 ExprClass to Variable. This allows pointer dereferences to be
12206 treated as variables, and to have values assigned to them.
12208 * ecore.cs (Expression.StoreFromPtr): New utility function to
12209 store values dereferencing.
12211 2002-02-20 Ravi Pratap <ravi@ximian.com>
12213 * expression.cs (Binary.ResolveOperator): Ensure that we are
12214 not trying to operate on a void type - this fixes the reported
12217 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12218 the parent implementation is sealed.
12220 * ../errors/cs0239.cs : Add.
12222 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12224 * typemanager.cs (unverifiable_code_type): Corresponds to
12225 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12226 which have unsafe code in them.
12228 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12231 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12233 * cs-tokenizer.cs: Add support for @"litreal strings"
12235 Make tokenizer accept pre-processor directives
12236 on any column (remove the old C-like limitation).
12238 * rootcontext.cs (EmitCode): Emit any global attributes.
12239 (AddGlobalAttributes): Used to keep track of assembly attributes.
12241 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12243 * cs-parser.jay: Add support for global attributes.
12245 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12247 * expression.cs (Indirection): New helper class. Unary will
12248 create Indirection classes to be able to implement the
12249 IMemoryLocation interface on it.
12251 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12253 * cs-parser.jay (fixed_statement): reference the right statement.
12255 * statement.cs (Fixed.Emit): Finish implementing the fixed
12256 statement for the &x case.
12258 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12260 * class.cs (Property.Define, Method.Define): Remove newslot when
12263 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12264 wrong. NewSlot should only be used if the `new' keyword is present.
12266 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12267 locating our system dir. Sorry about this.
12269 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12271 * driver.cs (GetSystemDir): Compute correctly the location of our
12272 system assemblies. I was using the compiler directory instead of
12273 the library directory.
12275 2002-02-13 Ravi Pratap <ravi@ximian.com>
12277 * expression.cs (BetterFunction): Put back in what Miguel commented out
12278 since it is the correct fix. The problem is elsewhere ;-)
12280 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12281 parameters of the parms method are themselves compatible or not !
12283 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12284 to check that a class implements an interface before saying that an implicit
12285 conversion was allowed. Use ImplementsInterface to do the checking.
12287 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12289 * class.cs (Method.Define): Track whether we are an explicit
12290 implementation or not. And only call DefineMethodOverride if we
12291 are an explicit implementation.
12293 (Property.DefineMethod): Ditto.
12295 2002-02-11 Ravi Pratap <ravi@ximian.com>
12297 * expression.cs (BetterFunction): Catch hideous bug which was
12298 preventing us from detecting ambiguous calls due to implicit casts i.e
12301 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12303 * support.cs (Pair): Remove un-needed method. I figured why I was
12304 getting the error in cs-parser.jay, the variable in a foreach loop
12305 is readonly, and the compiler does not really treat this as a variable.
12307 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12308 instead of EQUALS in grammar.
12310 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12312 * expression.cs (Unary.DoResolve): Check whether the argument is
12315 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12317 * support.cs: Api for Pair to set a value. Despite the fact that
12318 the variables are public the MS C# compiler refuses to compile
12319 code that accesses the field if the variable is part of a foreach
12322 * statement.cs (Fixed): Begin implementation of the fixed
12325 (Block.AddVariable): Return the VariableInfo on success and null
12326 on failure instead of true/false.
12328 * cs-parser.jay (foreach): Catch errors on variables already
12329 defined (we were ignoring this value before) and properly unwind
12330 the block hierarchy
12332 (fixed_statement): grammar for the fixed statement.
12334 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12336 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12337 pointer types to be incretemented.
12339 (SizeOf): Implement.
12341 * cs-parser.jay (pointer_member_access): Implement
12342 expr->IDENTIFIER production.
12344 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12345 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12348 (Unary): Implement indirection.
12350 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12351 use in non-unsafe context).
12353 (SimpleName.DoResolve): Check for pointers in field access on safe
12356 (Expression.LoadFromPtr): Factor the load-indirect code in this
12357 function. This was duplicated in UnboxCast and ParameterReference
12359 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12361 * expression.cs (ComposedCast): report an error if a pointer cast
12362 is used in a safe region.
12364 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12365 pointer type casts in unsafe context.
12367 * codegen.cs (EmitContext): Set up IsUnsafe.
12369 * cs-parser.jay (non_expression_type): Add productions for pointer
12372 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12373 code. We should not use force into static mode if the method is
12374 not virtual. Fixes bug in MIS
12376 * statement.cs (Do.Emit, While.Emit, For.Emit,
12377 Statement.EmitBoolExpression): Add support to Do and While to
12378 propagate infinite loop as `I do return' semantics.
12380 Improve the For case to also test for boolean constants.
12382 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12383 to the list of attributes we can add.
12385 Remove `EmitContext' argument.
12387 * class.cs (Method.Define): Apply parameter attributes.
12388 (Constructor.Define): Apply parameter attributes.
12389 (MethodCore.LabelParameters): Move here the core of labeling
12392 * support.cs (ReflectionParameters.ParameterModifier,
12393 InternalParameters.ParameterModifier): Use IsByRef on the type and
12394 only return the OUT bit for these parameters instead of in/out/ref
12397 This is because I miss-understood things. The ParameterInfo.IsIn
12398 and IsOut represent whether the parameter has the [In] and [Out]
12401 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12403 * ecore.cs (FieldExpr.Emit): Release temporaries.
12405 * assign.cs (LocalTemporary.Release): new function.
12407 * codegen.cs (EmitContext.GetTemporaryStorage,
12408 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12409 temporary storage. Now we can "put back" localbuilders when we
12412 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12414 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12415 need to make a copy of the variable to generate verifiable code.
12417 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12419 * driver.cs: Compute dynamically the system directory.
12421 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12422 Slower, but more generally useful. Used by the abstract
12423 registering implementation.
12425 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12426 the rules for the special rule on Type/instances. First check if
12427 we have the same name, and if so, try that special static path
12428 rather than the instance path.
12430 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12432 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12435 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12436 Enum, ValueType, Delegate or Array for non-corlib compiles.
12438 * cs-tokenizer.cs: Catch long identifiers (645)
12440 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12443 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12444 fix, we were returning too early, so we were not registering
12445 pending methods from abstract classes.
12447 Do not register pending methods if the class is abstract.
12449 * expression.cs (Conditional.DoResolve): Report circular implicit
12450 conversions when we neecd to compute it for conditional
12453 (Is.DoResolve): If the expression is always of the provided type,
12454 flag warning 183. If the expression can not ever be of the
12455 provided type flag warning 184.
12457 * class.cs: Catch 169 as well.
12459 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12462 2002-01-18 Nick Drochak <ndrochak@gol.com>
12464 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12466 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12468 * interface.cs: (PopulateMethod): Check for pointers being defined
12469 only if the unsafe context is active.
12470 (PopulateProperty): ditto.
12471 (PopulateIndexer): ditto.
12473 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12474 specified. If pointers are present, make sure that they are
12475 present in an unsafe context.
12476 (Constructor, Constructor.Define): ditto.
12477 (Field, Field.Define): ditto.
12478 (Property, Property.Define): ditto.
12479 (Event, Event.Define): ditto.
12481 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12482 hashtable if there are classes or structs defined.
12484 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12485 code, as the constant resolution moved.
12487 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12488 the metadata, so we can flag error 133.
12490 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12491 pointer is being declared in an unsafe context.
12493 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12495 * modifiers.cs (Modifiers.Check): Require a Location argument.
12496 Report error 227 for Unsafe use.
12498 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12500 * statement.cs (For.Emit): If the test is null, then report that
12501 we do `return', as we wont reach anything afterwards.
12503 (Switch.SwitchGoverningType): Track the expression that matched
12506 * driver.cs: Allow negative numbers as an error code to flag.
12508 * cs-parser.jay: Handle 1551.
12510 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
12512 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12514 * cs-parser.jay: Report 1518 (type declaration can only contain
12515 class, struct, interface, enum or delegate)
12517 (switch_label): Report 1523 (keywords `case' or `default' must
12520 (opt_switch_sections): Report 1522 (empty switch)
12522 * driver.cs: Report 1515 (response file specified multiple times)
12523 Report 1516 (Source file specified multiple times).
12525 * expression.cs (Argument.Resolve): Signal 1510
12527 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
12528 access not allowed in static code)
12530 2002-01-11 Ravi Pratap <ravi@ximian.com>
12532 * typemanager.cs (IsPointerType): Utility method which we are going
12535 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
12536 the object type, so we take care of that.
12538 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
12540 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
12541 added to non-params parameters :-)
12543 * typemanager.cs (CSharpName): Include 'void' type too.
12545 (void_ptr_type): Include in the set of core types.
12547 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
12550 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
12553 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
12554 completely forgotten about it.
12556 2002-01-10 Ravi Pratap <ravi@ximian.com>
12558 * cs-parser.jay (pointer_type): Add. This begins our implementation
12559 of parsing rules for unsafe code.
12561 (unsafe_statement): Implement.
12563 (embedded_statement): Modify to include the above.
12565 * statement.cs (Unsafe): Implement new class for unsafe blocks.
12567 * codegen.cs (EmitContext.InUnsafe): Add. This determines
12568 if the current context is an unsafe one.
12570 * cs-parser.jay (local_variable_pointer_type): Since local variable types
12571 are handled differently, we need separate rules for them.
12573 (local_variable_declaration): Update to use local_variable_pointer_type
12574 to allow variable declarations of unmanaged pointer types.
12576 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
12577 in unsafe contexts.
12579 * ../errors/cs0214.cs : Add.
12581 2002-01-16 Nick Drochak <ndrochak@gol.com>
12583 * makefile: remove 'response' file when cleaning.
12585 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12587 * cs-parser.jay: Report 1524.
12589 2002-01-14 Miguel de Icaza <miguel@ximian.com>
12591 * typemanager.cs (RegisterMethod): drop checking if we have
12592 registered this from here
12594 2002-01-12 Miguel de Icaza <miguel@ximian.com>
12596 * class.cs (Method.EmitDestructor): Implement calling our base
12599 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
12600 value of InFinally.
12602 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
12603 this routine and will wrap the call in a try/catch block. Deal
12606 2002-01-11 Miguel de Icaza <miguel@ximian.com>
12608 * ecore.cs (Expression.MemberLookup): instead of taking a
12609 parameter `same_type' that was used to tell whether we could
12610 access private members we compute our containing type from the
12613 (FieldExpr): Added partial support for volatile fields. This does
12614 not work for volatile fields exposed from assemblies, as I can not
12615 figure out how to extract the modreq from it.
12617 Updated all the source files to use this.
12619 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
12620 because it is referenced by MemberLookup very often.
12622 2002-01-09 Ravi Pratap <ravi@ximian.com>
12624 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
12625 TypeBuilder.GetCustomAttributes to retrieve what we need.
12627 Get rid of redundant default_member_attr_type as this is the same as
12628 default_member_type which already exists.
12630 * interface.cs, attribute.cs : Update accordingly.
12632 2002-01-08 Miguel de Icaza <miguel@ximian.com>
12634 * typemanager.cs: Enable IndexerPropertyName again. It does not
12635 work for TYpeBuilders though. Ravi, can you please fix this?
12637 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
12639 * expression.cs (Argument.Emit): Handle the case of ref objects
12640 being passed to ref functions;
12642 (ParameterReference.EmitLoad): Loads the content of the pointer
12643 without dereferencing.
12645 2002-01-07 Miguel de Icaza <miguel@ximian.com>
12647 * cs-tokenizer.cs: Implemented the pre-processing expressions.
12649 2002-01-08 Ravi Pratap <ravi@ximian.com>
12651 * class.cs (Indexer.DefineMethod): Incorporate the interface
12652 type in the name of the method if we are doing explicit interface
12655 * expression.cs (ConversionExists): Remove as it is completely obsolete.
12657 (BetterConversion): Fix extremely trivial bug where we were referring to
12658 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
12661 * ../errors/bug16.cs : Add although we have fixed it.
12663 2002-01-07 Miguel de Icaza <miguel@ximian.com>
12665 * expression.cs (BaseIndexer): Begin implementation.
12667 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
12669 * cs-parser.jay (indexer_declarator): Use qualified_identifier
12670 production directly to remove a shift/reduce, and implement
12671 explicit interface implementation.
12673 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
12674 after a floating point suffix.
12676 * expression.cs (DoNumericPromotions): Improved the conversion for
12677 uint/uint. If we have a constant, we avoid doing a typecast to a
12680 * class.cs (Indexer): Implement explicit interface implementation
12683 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
12685 * class.cs: make the default instance constructor public and hidebysig.
12687 2001-01-03 Ravi Pratap <ravi@ximian.com>
12689 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
12690 so we can call it from elsewhere.
12692 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
12693 we emit it internally if the class has a defined indexer; otherwise the user
12694 emits it by decorating the class definition with the DefaultMemberAttribute.
12696 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
12697 attribute is not used on a type which defines an indexer.
12699 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
12700 character when we skip whitespace.
12702 * ../errors/cs0646.cs : Add.
12704 2002-01-03 Miguel de Icaza <miguel@ximian.com>
12706 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
12709 * makefile: Add practical target `mcs3.exe' which builds the third
12710 generation compiler.
12712 * expression.cs (New): Fix structures constructor calling.
12714 * class.cs (Property, Method, Indexer): Emit Final flag on the
12715 method if we are an interface implementation and we are not
12718 * ecore.cs (PropertyExpr): New public field `IsBase', tells
12719 whether this property is referencing a `base' method.
12721 * expression.cs (Invocation.EmitCall): take an extra argument:
12722 is_base, this is used to determine whether the `call' or
12723 `callvirt' opcode should be used.
12726 * delegate.cs: update EmitCall.
12728 * class.cs (Method.Define): Set NewSlot for the cases where we are
12729 not implementing an interface method.
12731 (Property.Define): ditto.
12733 2002-01-02 Miguel de Icaza <miguel@ximian.com>
12735 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
12736 'r'. Allows mcs to parse itself fully.
12738 2002-01-02 Ravi Pratap <ravi@ximian.com>
12740 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
12741 of the number of initializers that require the InitializeArray method.
12743 (CheckIndices): Store the Expression in all cases - not the plain value. Also
12744 update the above field where necessary.
12746 (MakeByteBlob): Update accordingly.
12748 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
12751 (EmitDynamicInitializers): Update in accordance with the new optimization.
12753 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
12754 same OpCode applies.
12756 * cs-parser.jay : Fix some glaring errors I introduced.
12758 2002-01-01 Ravi Pratap <ravi@ximian.com>
12760 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
12761 so that we can check for name clashes there too.
12763 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
12764 for interface indexers.
12766 * interfaces.cs (Define): Emit the default member attribute.
12768 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
12769 variable was being referred to while setting the value ;-)
12771 2002-01-01 Miguel de Icaza <miguel@ximian.com>
12773 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
12774 byte-by-byte information when we know the data is zero.
12776 Make the block always a multiple of 4, because
12777 DefineInitializedData has a bug.
12779 * assign.cs: Fix, we should assign from the temporary, not from
12782 * expression.cs (MakeByteBlob): Fix my incorrect code.
12784 2001-12-31 Miguel de Icaza <miguel@ximian.com>
12786 * typemanager.cs (EnumToUnderlying): This function is used to get
12787 the underlying type from an enumeration, because it does not
12790 * constant.cs: Use the I4_S form for values between -128 and 127.
12792 * statement.cs (Block.LookupLabel): Looks up a label.
12793 (Block): Drop support for labeled blocks.
12795 (LabeledStatement): New kind of statement that represents a label
12798 (Goto): Finally implement this bad boy.
12800 * cs-parser.jay: Update to reflect new mechanism to implement
12803 2001-12-30 Miguel de Icaza <miguel@ximian.com>
12805 * codegen.cs (EmitContext.This): a codegen property that keeps the
12806 a single instance of this instead of creating many different this
12809 * delegate.cs (Delegate.DoResolve): Update to use the property;
12811 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
12813 * expression.cs (BaseAccess.DoResolve): Ditto.
12815 2001-12-29 Ravi Pratap <ravi@ximian.com>
12817 * typemanager.cs (methodimpl_attr_type): Add to hold the type
12818 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
12820 (InitCoreTypes): Update accordingly.
12822 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
12823 so we can quickly store the state.
12825 (ApplyAttributes): Set the correct implementation flags
12826 for InternalCall methods.
12828 2001-12-29 Miguel de Icaza <miguel@ximian.com>
12830 * expression.cs (EmitCall): if a method is not virtual, then do
12831 not use callvirt on it.
12833 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
12834 user defined stuff) requires the use of stobj, which takes an
12835 address on the stack instead of an array and an index. So emit
12836 the Ldelema operation for it.
12838 (EmitStoreOpcode): Use stobj for valuetypes.
12840 (UnaryMutator.EmitCode): Use the right 1 value depending on
12841 whether we are dealing with int64/uint64, float or doubles.
12843 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
12844 constructors that I implemented last night.
12846 (Constructor.IsDefault): Fix to work properly for static
12849 * cs-parser.jay (CheckDef): report method signature errors.
12850 Update error number 103 to be 132.
12852 * decl.cs: New AdditionResult enumeration value: MethodExists.
12853 Although we do this check for methods later on in the semantic
12854 analysis, catching repeated default constructors is so easy that
12855 we catch these here.
12857 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
12860 (ParameterReference.EmitAssign, Emit): handle
12863 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
12864 (ArrayAccess.EmitStoreOpcode): ditto.
12866 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
12868 * expression.cs (MakeByteBlob): Complete all the missing types
12869 (uint, short, ushort, byte, sbyte)
12871 * class.cs: Only init instance field initializers on instance
12874 Rename `constructors' to instance_constructors.
12876 (TypeContainer.AddConstructor): Only add constructors to the list
12877 if it is not static.
12879 Make sure that we handle default_static_constructor independently
12880 everywhere where we handle instance_constructors
12882 2001-12-28 Miguel de Icaza <miguel@ximian.com>
12884 * class.cs: Do not lookup or create a base initializer for a
12885 static constructor.
12887 (ConstructorInitializer.Resolve): use the proper type to lookup
12890 * cs-parser.jay: Report error 1585 (modifiers between type and name).
12892 * enum.cs, interface.cs: Remove CloseType, this is taken care by
12895 * decl.cs: CloseType is now an virtual method, the default
12896 implementation just closes this type.
12898 2001-12-28 Ravi Pratap <ravi@ximian.com>
12900 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
12901 to PreserveSig by default. Also emit HideBySig on such methods.
12903 Basically, set the defaults to standard values.
12905 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
12906 argument, if candidate is better, it can't be worse than the best !
12908 (Invocation): Re-write bits to differentiate between methods being
12909 applicable in their expanded form and their normal form - for params
12912 Get rid of use_standard everywhere as only standard conversions are allowed
12913 in overload resolution.
12915 More spec conformance.
12917 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12919 * driver.cs: Add --timestamp, to see where the compiler spends
12922 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
12923 `this' in static code.
12925 (SimpleName.DoResolve): Implement in terms of a helper function
12926 that allows static-references to be passed upstream to
12929 (Expression.ResolveWithSimpleName): Resolve specially simple
12930 names when called by MemberAccess to implement the special
12933 (Expression.ImplicitReferenceConversion): Handle conversions from
12934 Null to reference types before others, as Null's type is
12937 * expression.cs (Invocation.EmitCall): Handle the special case of
12938 calling methods declared on a reference type from a ValueType
12939 (Base classes System.Object and System.Enum)
12941 (MemberAccess.Resolve): Only perform lookups on Enumerations if
12942 the left hand side is a TypeExpr, not on every enumeration.
12944 (Binary.Resolve): If types are reference types, then do a cast to
12945 object on operators != and == of both arguments.
12947 * typemanager.cs (FindMembers): Extract instance and static
12948 members if requested.
12950 * interface.cs (PopulateProperty): Use void_type instead of null
12951 as the return type for the setter method.
12953 (PopulateIndexer): ditto.
12955 2001-12-27 Ravi Pratap <ravi@ximian.com>
12957 * support.cs (ReflectionParameters): Fix minor bug where we
12958 were examining the wrong parameter for the ParamArray attribute.
12960 Cope with requests for the type of the parameter at position
12961 greater than the params parameter's. We now return the element
12962 type of the params array as that makes more sense.
12964 * expression.cs (Invocation.IsParamsMethodApplicable): Update
12965 accordingly as we no longer have to extract the element type
12968 (Invocation.OverloadResolve): Update.
12970 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12972 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
12973 against IEnumerator, test whether the return value is a descendant
12974 of the IEnumerator interface.
12976 * class.cs (Indexer.Define): Use an auxiliary method to implement
12977 the other bits of the method definition. Begin support for
12978 explicit interface implementation.
12980 (Property.DefineMethod): Use TypeManager.void_type instead of null
12981 for an empty return value.
12983 2001-12-26 Miguel de Icaza <miguel@ximian.com>
12985 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
12986 dealing with a FieldExpr which is composed of a FieldBuilder, in
12987 the code path we did extract the constant, but we should have
12988 obtained the underlying value to be able to cast it (otherwise we
12989 end up in an infinite loop, this is what Ravi was running into).
12991 (ArrayCreation.UpdateIndices): Arrays might be empty.
12993 (MemberAccess.ResolveMemberAccess): Add support for section
12994 14.5.4.1 that deals with the special case of E.I when E is a type
12995 and something else, that I can be a reference to a static member.
12997 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
12998 handle a particular array type to create byte blobs, it is just
12999 something we dont generate byteblobs for.
13001 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13004 * location.cs (Push): remove the key from the hashtable that we
13005 are about to add. This happens for empty files.
13007 * driver.cs: Dispose files after we have parsed them.
13009 (tokenize): new function that only runs the tokenizer on its
13010 input, for speed testing.
13012 2001-12-26 Ravi Pratap <ravi@ximian.com>
13014 * class.cs (Event.Define): Define the private field only if there
13015 are no accessors defined.
13017 * expression.cs (ResolveMemberAccess): If there is no associated
13018 field with the event, that means we have an event defined with its
13019 own accessors and we should flag error cs0070 since transforming
13020 ourselves into a field is not valid in that case.
13022 * ecore.cs (SimpleName.DoResolve): Same as above.
13024 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13025 and charset to sane values.
13027 2001-12-25 Ravi Pratap <ravi@ximian.com>
13029 * assign.cs (DoResolve): Perform check on events only if they
13030 are being accessed outside the declaring type.
13032 * cs-parser.jay (event_declarations): Update rules to correctly
13033 set the type of the implicit parameter etc.
13035 (add_accessor, remove_accessor): Set current local parameters.
13037 * expression.cs (Binary): For delegate addition and subtraction,
13038 cast the return value from the method into the appropriate delegate
13041 2001-12-24 Ravi Pratap <ravi@ximian.com>
13043 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13044 of these as the workaround is unnecessary.
13046 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13047 delegate data - none of that is needed at all.
13049 Re-write bits to extract the instance expression and the delegate method
13052 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13055 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13056 of attaching attributes instead of duplicating code everywhere.
13058 * everywhere : Update code to do attribute emission using the above method.
13060 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13062 * expression.cs (IsParamsMethodApplicable): if there are not
13063 parameters, return immediately.
13065 * ecore.cs: The 0 literal can be implicity converted to an enum
13068 (SimpleName.DoResolve): First lookup the type, then lookup the
13071 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13072 want to get its address. If the InstanceExpression is not
13073 addressable, store the result in a temporary variable, then get
13076 * codegen.cs: Only display 219 errors on warning level or above.
13078 * expression.cs (ArrayAccess): Make it implement the
13079 IMemoryLocation interface.
13081 (Binary.DoResolve): handle the operator == (object a, object b)
13082 and operator != (object a, object b) without incurring into a
13083 BoxedCast (because 5 != o should never be performed).
13085 Handle binary enumerator operators.
13087 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13088 value type, otherwise use Ldelem_ref.
13090 Use precomputed names;
13092 (AddressOf): Implement address of
13094 * cs-parser.jay (labeled_statement): Fix recursive block
13095 addition by reworking the production.
13097 * expression.cs (New.DoEmit): New has a special case:
13099 If we are dealing with a ValueType, we have a few
13100 situations to deal with:
13102 * The target of New is a ValueType variable, that is
13103 easy, we just pass this as the variable reference
13105 * The target of New is being passed as an argument,
13106 to a boxing operation or a function that takes a
13109 In this case, we need to create a temporary variable
13110 that is the argument of New.
13113 2001-12-23 Ravi Pratap <ravi@ximian.com>
13115 * rootcontext.cs (LookupType): Check that current_type is not null before
13116 going about looking at nested types.
13118 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13119 not implement the IAssignMethod interface any more.
13121 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13122 where we tranform them into FieldExprs if they are being resolved from within
13123 the declaring type.
13125 * ecore.cs (SimpleName.DoResolve): Do the same here.
13127 * assign.cs (DoResolve, Emit): Clean up code considerably.
13129 * ../errors/bug10.cs : Add.
13131 * ../errors/cs0070.cs : Add.
13133 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13135 * assign.cs : Get rid of EventIsLocal everywhere.
13137 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13139 * ecore.cs (ConvertIntLiteral): finished the implementation.
13141 * statement.cs (SwitchLabel): Convert the value we are using as a
13142 key before looking up the table.
13144 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13146 * codegen.cs (EmitTopBlock): Require a Location argument now.
13148 * cs-parser.jay (constructor_declarator): We need to setup
13149 current_local_parameters before we parse the
13150 opt_constructor_initializer, to allow the variables to be bound
13151 to the constructor arguments.
13153 * rootcontext.cs (LookupType): First lookup nested classes in our
13154 class and our parents before we go looking outside our class.
13156 * expression.cs (ConstantFold): Extract/debox the values at the
13159 * rootcontext.cs (EmitCode): Resolve the constants first before we
13160 resolve the types. This is not really needed, but it helps debugging.
13162 * statement.cs: report location.
13164 * cs-parser.jay: pass location to throw statement.
13166 * driver.cs: Small bug fix.
13168 * report.cs: Updated format to be 4-zero filled digits.
13170 2001-12-22 Ravi Pratap <ravi@ximian.com>
13172 * expression.cs (CheckIndices): Fix minor bug where the wrong
13173 variable was being referred to ;-)
13175 (DoEmit): Do not call EmitStaticInitializers when the
13176 underlying type is System.Object.
13178 2001-12-21 Ravi Pratap <ravi@ximian.com>
13180 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13181 and do the usual workaround for SRE.
13183 * class.cs (MyEventBuilder.EventType): New member to get at the type
13184 of the event, quickly.
13186 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13188 * assign.cs (Assign.DoResolve): Handle the case when the target
13189 is an EventExpr and perform the necessary checks.
13191 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13194 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13196 (EventExpr): Set the type in the constructor itself since we
13197 are meant to be born fully resolved.
13199 (EventExpr.Define): Revert code I wrote earlier.
13201 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13202 instance expression is null. The instance expression is a This in that case
13203 or a null, depending on whether it is a static method or not.
13205 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13206 refers to more than one method.
13208 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13209 and accordingly flag errors.
13211 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13213 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13215 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13217 * location.cs (ToString): Provide useful rutine.
13219 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13221 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13222 objects, return the actual integral boxed.
13224 * statement.cs (SwitchLabel): define an ILLabel for each
13227 (Switch.CheckSwitch): If the value is a Literal, extract
13228 the underlying literal.
13230 Also in the unused hashtable we had, add the SwitchLabel so we can
13231 quickly look this value up.
13233 * constant.cs: Implement a bunch of new constants. Rewrite
13234 Literal based on this. Made changes everywhere to adapt to this.
13236 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13237 dereferencing array only once, and also copes with enumrations.
13239 bytes are two bytes wide, not one.
13241 (Cast): Perform constant conversions.
13243 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13244 wrappers to the literals here.
13246 * expression.cs (DoNumericPromotions): long literals can converted
13247 to ulong implicity (this is taken care of elsewhere, but I was
13248 missing this spot).
13250 * ecore.cs (Expression.Literalize): Make the return type Literal,
13251 to improve type checking.
13253 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13255 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13257 * literal.cs: Revert code from ravi that checked the bounds. The
13258 bounds are sane by the definition of the type itself.
13260 * typemanager.cs: Fix implementation of ImplementsInterface. We
13261 need to actually look up in our parent hierarchy for interfaces
13264 * const.cs: Use the underlying type for enumerations
13266 * delegate.cs: Compute the basename for the delegate creation,
13267 that should fix the delegate test case, and restore the correct
13268 Type Lookup semantics in rootcontext
13270 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13271 referencing a nested type with the Reflection API is using the "+"
13274 * cs-parser.jay: Do not require EOF token at the end.
13276 2001-12-20 Ravi Pratap <ravi@ximian.com>
13278 * rootcontext.cs (LookupType): Concatenate type names with
13279 a '.' instead of a '+' The test suite passes again.
13281 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13282 field of the enumeration.
13284 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13285 the case when the member is an EventExpr.
13287 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13288 static has an associated instance expression.
13290 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13292 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13294 * class.cs (Event.Define): Register event and perform appropriate checks
13297 We define the Add and Remove methods even if the use provides none because
13298 in that case, we provide default implementations ourselves.
13300 Define a private field of the type of the event. This is done by the CSC compiler
13301 and we should be doing it too ;-)
13303 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13304 More methods we use in code we generate.
13306 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13309 (InitCoreTypes): Update accordingly for the above.
13311 * class.cs (Event.Emit): Generate code for default accessors that we provide
13313 (EmitDefaultMethod): Do the job in the above.
13315 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13318 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13320 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13321 builders even if we were missing one.
13323 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13324 pass the Basename as our class name instead of the Name. The
13325 basename will be correctly composed for us.
13327 * parameter.cs (Paramters): Now takes a Location argument.
13329 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13330 make all the code call directly LookupType in RootContext and take
13331 this chance to pass the Location information everywhere.
13333 * Everywhere: pass Location information.
13335 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13337 * class.cs (Constructor.Define): Updated way of detecting the
13338 length of the parameters.
13340 (TypeContainer.DefineType): Use basename as the type name for
13343 (TypeContainer.Define): Do not recursively define types here, as
13344 definition is taken care in order by the RootContext.
13346 * tree.cs: Keep track of namespaces in a per-file basis.
13348 * parameter.cs (Parameter.ComputeSignature): Update to use
13351 (Parameters.GetSignature): ditto.
13353 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13354 instead of a TypeContainer.
13356 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13357 resolve names. Because we need to be resolve in our context, not
13360 * driver.cs: Implement response files.
13362 * class.cs (TypeContainer.DefineType): If we are defined, do not
13363 redefine ourselves.
13365 (Event.Emit): Emit the code for add/remove handlers.
13366 (Event.Define): Save the MethodBuilders for add/remove.
13368 * typemanager.cs: Use pair here too.
13370 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13371 DictionaryEntry requires the first argument to be non-null.
13373 (enum_declaration): Compute full name for registering the
13376 (delegate_declaration): Instead of using
13377 formal_parameter_list, use opt_formal_parameter_list as the list
13380 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13381 (EventParsing): New property that controls whether `add' and
13382 `remove' are returned as tokens or identifiers (for events);
13384 2001-12-19 Ravi Pratap <ravi@ximian.com>
13386 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13387 use MyEventBuilder only and let it wrap the real builder for us.
13389 (MyEventBuilder): Revamp constructor etc.
13391 Implement all operations that we perform on EventBuilder in precisely the same
13394 (FindMembers): Update to use the EventBuilder member.
13396 (Event.Emit): Update accordingly.
13398 2001-12-18 Ravi Pratap <ravi@ximian.com>
13400 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13401 by calling the appropriate methods.
13403 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13406 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13408 2001-12-17 Ravi Pratap <ravi@ximian.com>
13410 * delegate.cs (Delegate.Populate): Check that the return type
13411 and various parameters types are indeed accessible.
13413 * class.cs (Constructor.Define): Same here.
13415 (Field.Define): Ditto.
13417 (Event.Define): Ditto.
13419 (Operator.Define): Check that the underlying Method defined itself
13420 correctly - so it's MethodBuilder should not be null.
13422 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13423 expression happens to be null.
13425 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13426 members but as of now we don't seem to be able to do anything really useful with it.
13428 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13429 not the EventBuilder.
13431 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13433 * cs-tokenizer.cs: Add support for defines.
13434 Add support for #if, #elif, #else, #endif
13436 (eval_var): evaluates a variable.
13437 (eval): stubbed for evaluating functions.
13439 * cs-parser.jay: Pass the defines information
13441 * driver.cs: Add --define command line option.
13443 * decl.cs: Move MemberCore here.
13445 Make it the base class for DeclSpace. This allows us to catch and
13446 report 108 and 109 for everything now.
13448 * class.cs (TypeContainer.Define): Extract all the members
13449 before populating and emit the warning 108 (new keyword required
13450 to override) instead of having each member implement this.
13452 (MemberCore.Define): New abstract method, we will be using this in
13453 the warning reporting engine in Populate.
13455 (Operator.Define): Adjust to new MemberCore protocol.
13457 * const.cs (Const): This does not derive from Expression, it is a
13458 temporary object we use to create fields, it is a MemberCore.
13460 * class.cs (Method.Define): Allow the entry point to be in a
13463 * driver.cs: Rewrite the argument handler to clean it up a bit.
13465 * rootcontext.cs: Made it just an auxiliary namespace feature by
13466 making everything static.
13468 * driver.cs: Adapt code to use RootContext type name instead of
13471 * delegate.cs: Remove RootContext argument.
13473 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13476 * class.cs (Event.Define): The lookup can fail.
13478 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13480 * expression.cs: Resolve the this instance before invoking the code.
13482 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13484 * cs-parser.jay: Add a production in element_access that allows
13485 the thing to become a "type" reference. This way we can parse
13486 things like "(string [])" as a type.
13488 Note that this still does not handle the more complex rules of
13492 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13494 * ecore.cs: (CopyNewMethods): new utility function used to
13495 assemble the list of methods from running FindMembers.
13497 (MemberLookup): Rework FindMembers so that
13499 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13501 * class.cs (TypeContainer): Remove Delegates who fail to be
13504 * delegate.cs (Populate): Verify that we dont get null return
13505 values. TODO: Check for AsAccessible.
13507 * cs-parser.jay: Use basename to emit error 574 (destructor should
13508 have the same name as container class), not the full name.
13510 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
13511 possible representation.
13513 Also implements integer type suffixes U and L.
13515 2001-12-15 Miguel de Icaza <miguel@ximian.com>
13517 * expression.cs (ArrayCreation.DoResolve): We need to do the
13518 argument resolution *always*.
13520 * decl.cs: Make this hold the namespace. Hold the root context as
13522 (LookupType): Move here.
13524 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
13526 * location.cs (Row, Name): Fixed the code, it was always returning
13527 references to the first file.
13529 * interface.cs: Register properties defined through interfaces.
13531 * driver.cs: Add support for globbing on the command line
13533 * class.cs (Field): Make it derive from MemberCore as well.
13536 2001-12-15 Ravi Pratap <ravi@ximian.com>
13538 * class.cs (Event::Define): Check that the type of the event is a delegate
13539 type else flag error #66.
13541 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
13544 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
13545 values of EntryPoint, CharSet etc etc.
13547 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
13549 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
13550 be null and we should ignore this. I am not sure if this is really clean. Apparently,
13551 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
13552 which needs this to do its work.
13554 * ../errors/cs0066.cs : Add.
13556 2001-12-14 Miguel de Icaza <miguel@ximian.com>
13558 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
13561 * class.cs: (MethodSignature.MethodSignature): Removed hack that
13562 clears out the parameters field.
13563 (MemberSignatureCompare): Cleanup
13565 (MemberCore): New base class used to share code between MethodCore
13568 (RegisterRequiredImplementations) BindingFlags.Public requires
13569 either BindingFlags.Instace or Static. Use instance here.
13571 (Property): Refactored code to cope better with the full spec.
13573 * parameter.cs (GetParameterInfo): Return an empty array instead
13576 * class.cs (Property): Abstract or extern properties have no bodies.
13578 * parameter.cs (GetParameterInfo): return a zero-sized array.
13580 * class.cs (TypeContainer.MethodModifiersValid): Move all the
13581 method modifier validation to the typecontainer so we can reuse
13582 this on properties.
13584 (MethodCore.ParameterTypes): return an empty sized array of types.
13586 (Property.Define): Test property modifier validity.
13588 Add tests for sealed/override too.
13590 (Method.Emit): abstract or extern methods have no bodies.
13592 2001-12-14 Ravi Pratap <ravi@ximian.com>
13594 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
13597 (Method::Define, ::Emit): Modify accordingly.
13599 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
13601 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
13603 * makefile: Pass in /unsafe.
13605 2001-12-13 Miguel de Icaza <miguel@ximian.com>
13607 * class.cs (MakeKey): Kill routine.
13609 * class.cs (TypeContainer.Define): Correctly define explicit
13610 method implementations (they require the full interface name plus
13613 * typemanager.cs: Deply the PtrHashtable here and stop using the
13614 lame keys. Things work so much better.
13616 This of course broke everyone who depended on `RegisterMethod' to
13617 do the `test for existance' test. This has to be done elsewhere.
13619 * support.cs (PtrHashtable): A hashtable that avoid comparing with
13620 the object stupid Equals method (because, that like fails all over
13621 the place). We still do not use it.
13623 * class.cs (TypeContainer.SetRequiredInterface,
13624 TypeContainer.RequireMethods): Killed these two routines and moved
13625 all the functionality to RegisterRequiredImplementations.
13627 (TypeContainer.RegisterRequiredImplementations): This routine now
13628 registers all the implementations required in an array for the
13629 interfaces and abstract methods. We use an array of structures
13630 which can be computed ahead of time to reduce memory usage and we
13631 also assume that lookups are cheap as most classes will not
13632 implement too many interfaces.
13634 We also avoid creating too many MethodSignatures.
13636 (TypeContainer.IsInterfaceMethod): Update and optionally does not
13637 clear the "pending" bit if we find that there are problems with
13640 (TypeContainer.VerifyPendingMethods): Update to report errors of
13641 methods that look like implementations but are not.
13643 (TypeContainer.Define): Add support for explicit interface method
13646 2001-12-12 Miguel de Icaza <miguel@ximian.com>
13648 * typemanager.cs: Keep track of the parameters here instead of
13649 being a feature of the TypeContainer.
13651 * class.cs: Drop the registration of parameters here, as
13652 InterfaceMethods are also interface declarations.
13654 * delegate.cs: Register methods with the TypeManager not only with
13655 the TypeContainer. This code was buggy.
13657 * interface.cs: Full registation here.
13659 2001-12-11 Miguel de Icaza <miguel@ximian.com>
13661 * expression.cs: Remove reducer for binary expressions, it can not
13664 * const.cs: Put here the code that used to go into constant.cs
13666 * constant.cs: Put here the code for constants, this is a new base
13667 class for Literals.
13669 * literal.cs: Make Literal derive from Constant.
13671 2001-12-09 Miguel de Icaza <miguel@ximian.com>
13673 * statement.cs (Return.Emit): Report error 157 if the user
13674 attempts to return from a finally block.
13676 (Return.Emit): Instead of emitting a return, jump to the end of
13679 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
13680 LocalBuilder to store the result of the function. ReturnLabel is
13681 the target where we jump.
13684 2001-12-09 Radek Doulik <rodo@ximian.com>
13686 * cs-parser.jay: remember alias in current namespace
13688 * ecore.cs (SimpleName::DoResolve): use aliases for types or
13691 * class.cs (LookupAlias): lookup alias in my_namespace
13693 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
13695 (LookupAlias): lookup alias in this and if needed in parent
13698 2001-12-08 Miguel de Icaza <miguel@ximian.com>
13702 * rootcontext.cs: (ModuleBuilder) Made static, first step into
13703 making things static. I need this to avoid passing the
13704 TypeContainer when calling ParameterType.
13706 * support.cs (InternalParameters.ParameterType): Remove ugly hack
13707 that did string manipulation to compute the type and then call
13708 GetType. Use Parameter.ParameterType instead.
13710 * cs-tokenizer.cs: Consume the suffix for floating values.
13712 * expression.cs (ParameterReference): figure out whether this is a
13713 reference parameter or not. Kill an extra variable by computing
13714 the arg_idx during emission.
13716 * parameter.cs (Parameters.GetParameterInfo): New overloaded
13717 function that returns whether a parameter is an out/ref value or not.
13719 (Parameter.ParameterType): The type of the parameter (base,
13720 without ref/out applied).
13722 (Parameter.Resolve): Perform resolution here.
13723 (Parameter.ExternalType): The full type (with ref/out applied).
13725 * statement.cs (Using.Emit, Using.EmitExpression): Implement
13726 support for expressions on the using statement.
13728 2001-12-07 Miguel de Icaza <miguel@ximian.com>
13730 * statement.cs (Using.EmitLocalVariableDecls): Split the
13731 localvariable handling of the using statement.
13733 (Block.EmitMeta): Keep track of variable count across blocks. We
13734 were reusing slots on separate branches of blocks.
13736 (Try.Emit): Emit the general code block, we were not emitting it.
13738 Check the type of the declaration to be an IDisposable or
13739 something that can be implicity converted to it.
13741 Emit conversions if required.
13743 * ecore.cs (EmptyExpression): New utility class.
13744 (Expression.ImplicitConversionExists): New utility function.
13746 2001-12-06 Miguel de Icaza <miguel@ximian.com>
13748 * statement.cs (Using): Implement.
13750 * expression.cs (LocalVariableReference): Support read only variables.
13752 * statement.cs: Remove the explicit emit for the Leave opcode.
13753 (VariableInfo): Add a readonly field.
13755 2001-12-05 Miguel de Icaza <miguel@ximian.com>
13757 * ecore.cs (ConvCast): new class used to encapsulate the various
13758 explicit integer conversions that works in both checked and
13759 unchecked contexts.
13761 (Expression.ConvertNumericExplicit): Use new ConvCast class to
13762 properly generate the overflow opcodes.
13764 2001-12-04 Miguel de Icaza <miguel@ximian.com>
13766 * statement.cs: The correct type for the EmptyExpression is the
13767 element_type, not the variable type. Ravi pointed this out.
13769 2001-12-04 Ravi Pratap <ravi@ximian.com>
13771 * class.cs (Method::Define): Handle PInvoke methods specially
13772 by using DefinePInvokeMethod instead of the usual one.
13774 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
13775 above to do the task of extracting information and defining the method.
13777 2001-12-04 Ravi Pratap <ravi@ximian.com>
13779 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
13780 of the condition for string type.
13782 (Emit): Move that here.
13784 (ArrayCreation::CheckIndices): Keep string literals in their expression
13787 (EmitDynamicInitializers): Handle strings appropriately.
13789 2001-12-04 Miguel de Icaza <miguel@ximian.com>
13791 * codegen.cs (EmitContext): Replace multiple variables with a
13792 single pointer to the current Switch statement.
13794 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
13797 2001-12-03 Miguel de Icaza <miguel@ximian.com>
13801 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
13804 (Foreach.Emit): Foreach on arrays was not setting
13805 up the loop variables (for break/continue).
13807 (GotoCase): Semi-implented.
13809 2001-12-03 Ravi Pratap <ravi@ximian.com>
13811 * attribute.cs (CheckAttribute): Handle system attributes by using
13812 Attribute.GetAttributes to examine information we need.
13814 (GetValidPlaces): Same here.
13816 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
13818 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
13820 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
13822 (Method::Define): Set appropriate flags if we have a DllImport attribute.
13824 (Method::Emit): Handle the case when we are a PInvoke method.
13826 2001-12-03 Miguel de Icaza <miguel@ximian.com>
13828 * expression.cs: Use ResolveWithSimpleName on compound names.
13830 2001-12-02 Ravi Pratap <ravi@ximian.com>
13832 * constant.cs (EmitConstant): Make sure we resolve the associated expression
13833 before trying to reduce it.
13835 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
13837 * constant.cs (LookupConstantValue): Implement.
13839 (EmitConstant): Use the above in emitting the constant.
13841 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
13842 that are user-defined by doing a LookupConstantValue on them.
13844 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
13847 2001-11-29 Miguel de Icaza <miguel@ximian.com>
13849 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
13851 (BaseAccess.DoResolve): Implement.
13853 (MemberAccess.DoResolve): Split this routine into a
13854 ResolveMemberAccess routine that can be used independently
13856 2001-11-28 Miguel de Icaza <miguel@ximian.com>
13858 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
13859 As that share bits of the implementation. Is returns a boolean,
13860 while As returns the Type that is being probed.
13862 2001-12-01 Ravi Pratap <ravi@ximian.com>
13864 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
13865 instead of a Literal - much easier.
13867 (EnumInTransit): Remove - utterly useless :-)
13869 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
13871 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
13873 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
13874 chain when we have no associated expression.
13876 2001-11-30 Ravi Pratap <ravi@ximian.com>
13878 * constant.cs (Define): Use Location while reporting the errror.
13880 Also emit a warning when 'new' is used and there is no inherited
13883 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
13886 (LookupEnumValue): Implement to lookup an enum member's value and define it
13889 (Populate): Re-write accordingly to use the above routine.
13891 2001-11-27 Miguel de Icaza <miguel@ximian.com>
13893 * expression.cs (This): Fix prototype for DoResolveLValue to
13894 override the base class DoResolveLValue.
13896 * cs-parser.cs: Report errors cs574 and cs575 (destructor
13899 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
13900 (we need to load the address of the field here). This fixes
13903 (FieldExpr.DoResolveLValue): Call the DoResolve
13904 function to initialize the Instance expression.
13906 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
13907 correctly the GetEnumerator operation on a value type.
13909 * cs-parser.jay: Add more simple parsing error catches.
13911 * statement.cs (Switch): Add support for string switches.
13912 Handle null specially.
13914 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
13916 2001-11-28 Ravi Pratap <ravi@ximian.com>
13918 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
13920 (declare_local_constant): New helper function.
13922 * statement.cs (AddConstant): Keep a separate record of constants
13924 (IsConstant): Implement to determine if a variable is a constant.
13926 (GetConstantExpression): Implement.
13928 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
13930 * statement.cs (IsVariableDefined): Re-write.
13932 2001-11-27 Ravi Pratap <ravi@ximian.com>
13934 * class.cs (TypeContainer::FindMembers): Look for constants
13935 in the case when we are looking for MemberTypes.Field
13937 * expression.cs (MemberAccess::DoResolve): Check that in the
13938 case we are a FieldExpr and a Literal, we are not being accessed
13939 by an instance reference.
13941 * cs-parser.jay (local_constant_declaration): Implement.
13943 (declaration_statement): Implement for constant declarations.
13945 2001-11-26 Miguel de Icaza <miguel@ximian.com>
13947 * statement.cs (Switch): Catch double defaults.
13949 (Switch): More work on the switch() statement
13950 implementation. It works for integral values now, need to finish
13954 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13956 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
13957 integer literals into other integer literals. To be used by
13960 2001-11-24 Ravi Pratap <ravi@ximian.com>
13962 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
13965 (EmitDynamicInitializers): Cope with the above since we extract data
13966 directly from ArrayData now.
13968 (ExpectInitializers): Keep track of whether initializers are mandatory
13971 (Bounds): Make it a hashtable to prevent the same dimension being
13972 recorded for every element in that dimension.
13974 (EmitDynamicInitializers): Fix bug which prevented the Set array method
13977 Also fix bug which was causing the indices to be emitted in the reverse
13980 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13982 * expression.cs (ArrayCreation): Implement the bits that Ravi left
13983 unfinished. They do not work, because the underlying code is
13986 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13988 * cs-parser.jay: Remove bogus fixme.
13990 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
13991 on Switch statement.
13993 2001-11-23 Ravi Pratap <ravi@ximian.com>
13995 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
13998 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
13999 parameter. Apparently, any expression is allowed.
14001 (ValidateInitializers): Update accordingly.
14003 (CheckIndices): Fix some tricky bugs thanks to recursion.
14005 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14006 I was being completely brain-dead.
14008 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14009 and re-write acordingly.
14011 (DelegateInvocation): Re-write accordingly.
14013 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14015 (MakeByteBlob): Handle types more correctly.
14017 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14018 initialization from expressions but it is incomplete because I am a complete
14021 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14023 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14024 on If. Basically, we have to return `true' (ie, we do return to
14025 our caller) only if both branches of the if return.
14027 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14028 short-circuit operators, handle them as short circuit operators.
14030 (Cast.DoResolve): Resolve type.
14031 (Cast.Cast): Take an expression as the target type.
14033 * cs-parser.jay (cast_expression): Remove old hack that only
14034 allowed a limited set of types to be handled. Now we take a
14035 unary_expression and we resolve to a type during semantic
14038 Use the grammar productions from Rhys to handle casts (this is
14039 not complete like Rhys syntax yet, we fail to handle that corner
14040 case that C# has regarding (-x), but we will get there.
14042 2001-11-22 Ravi Pratap <ravi@ximian.com>
14044 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14045 field which is an array type.
14047 * cs-parser.jay (declare_local_variables): Support array initialization too.
14049 * typemanager.cs (MakeKey): Implement.
14051 (everywhere): Use the above appropriately.
14053 * cs-parser.jay (for_statement): Update for array initialization while
14054 declaring variables.
14056 * ecore.cs : The error message was correct, it's the variable's names that
14057 were misleading ;-) Make the code more readable.
14059 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14060 the correct type etc.
14062 (ConvertExplicit): Handle Enum types by examining the underlying type.
14064 2001-11-21 Ravi Pratap <ravi@ximian.com>
14066 * parameter.cs (GetCallingConvention): Always return
14067 CallingConventions.Standard for now.
14069 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14071 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14072 and `r' after calling DoNumericPromotions.
14074 * ecore.cs: Fix error message (the types were in the wrong order).
14076 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14077 BindingFlags.Instance as well
14079 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14080 implicit int literal conversion in an empty cast so that we
14081 propagate the right type upstream.
14083 (UnboxCast): new class used to unbox value types.
14084 (Expression.ConvertExplicit): Add explicit type conversions done
14087 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14088 the target type before applying the implicit LongLiterals to ULong
14091 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14093 * cs-parser.jay (for_statement): Reworked the way For works: now
14094 we declare manually any variables that are introduced in
14095 for_initializer to solve the problem of having out-of-band code
14096 emition (that is what got for broken).
14098 (declaration_statement): Perform the actual variable declaration
14099 that used to be done in local_variable_declaration here.
14101 (local_variable_declaration): Do not declare anything, just pass
14102 the information on a DictionaryEntry
14104 2001-11-20 Ravi Pratap <ravi@ximian.com>
14106 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14107 re-write of the logic to now make it recursive.
14109 (UpdateIndices): Re-write accordingly.
14111 Store element data in a separate ArrayData list in the above methods.
14113 (MakeByteBlob): Implement to dump the array data into a byte array.
14115 2001-11-19 Ravi Pratap <ravi@ximian.com>
14117 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14120 * constant.cs (Define): Implement.
14122 (EmitConstant): Re-write fully.
14124 Pass in location info.
14126 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14129 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14130 DictionaryEntry since we need location info too.
14132 (constant_declaration): Update accordingly.
14134 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14135 code into another method : UpdateIndices.
14137 2001-11-18 Ravi Pratap <ravi@ximian.com>
14139 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14140 some type checking etc.
14142 2001-11-17 Ravi Pratap <ravi@ximian.com>
14144 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14145 bits to provide dimension info if the user skips doing that.
14147 Update second constructor to store the rank correctly.
14149 2001-11-16 Ravi Pratap <ravi@ximian.com>
14151 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14152 and try to implement.
14154 * ../errors/cs0150.cs : Add.
14156 * ../errors/cs0178.cs : Add.
14158 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14160 * statement.cs: Implement foreach on multi-dimensional arrays.
14162 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14163 name of the params argument.
14165 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14166 initializing the array.
14168 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14169 we can use this elsewhere.
14171 * statement.cs: Finish implementation of foreach for single
14174 * cs-parser.jay: Use an out-of-band stack to pass information
14175 around, I wonder why I need this.
14177 foreach_block: Make the new foreach_block the current_block.
14179 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14180 function used to return a static Parameters structure. Used for
14181 empty parameters, as those are created very frequently.
14183 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14185 2001-11-15 Ravi Pratap <ravi@ximian.com>
14187 * interface.cs : Default modifier is private, not public. The
14188 make verify test passes again.
14190 2001-11-15 Ravi Pratap <ravi@ximian.com>
14192 * support.cs (ReflectionParameters): Fix logic to determine
14193 whether the last parameter is a params one. Test 9 passes again.
14195 * delegate.cs (Populate): Register the builders we define with
14196 RegisterParameterForBuilder. Test 19 passes again.
14198 * cs-parser.jay (property_declaration): Reference $6 instead
14199 of $$ to get at the location.
14201 (indexer_declaration): Similar stuff.
14203 (attribute): Ditto.
14205 * class.cs (Property): Register parameters for the Get and Set methods
14206 if they exist. Test 23 passes again.
14208 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14209 call to EmitArguments as we are sure there aren't any params arguments.
14210 Test 32 passes again.
14212 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14213 IndexOutOfRangeException.
14215 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14216 Test 33 now passes again.
14218 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14220 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14221 broke a bunch of things. Will have to come up with a better way
14222 of tracking locations.
14224 * statement.cs: Implemented foreach for single dimension arrays.
14226 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14228 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14229 an error. This removes the lookup from the critical path.
14231 * cs-parser.jay: Removed use of temporary_loc, which is completely
14234 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14236 * support.cs (ReflectionParameters.ParameterModifier): Report
14237 whether the argument is a PARAMS argument or not.
14239 * class.cs: Set the attribute `ParamArrayAttribute' on the
14240 parameter argument.
14242 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14243 and cons_param_array_attribute (ConstructorInfo for
14244 ParamArrayAttribute).,
14246 * codegen.cs: Emit the return using the `Return' statement, that
14247 way we can report the error correctly for missing return values.
14249 * class.cs (Method.Emit): Clean up.
14251 * expression.cs (Argument.Resolve): Take another argument: the
14252 location where this argument is used. Notice that this is not
14253 part of the "Argument" class as to reduce the size of the
14254 structure (we know the approximate location anyways).
14256 Test if the argument is a variable-reference, if not, then
14257 complain with a 206.
14259 (Argument.Emit): Emit addresses of variables.
14261 (Argument.FullDesc): Simplify.
14263 (Invocation.DoResolve): Update for Argument.Resolve.
14265 (ElementAccess.DoResolve): ditto.
14267 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14268 method should be virtual, as this method is always virtual.
14270 (NewDelegate.DoResolve): Update for Argument.Resolve.
14272 * class.cs (ConstructorInitializer.DoResolve): ditto.
14274 * attribute.cs (Attribute.Resolve): ditto.
14276 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14278 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14280 * expression.cs (ParameterReference): Drop IStackStorage and implement
14281 IAssignMethod instead.
14283 (LocalVariableReference): ditto.
14285 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14286 IAssignMethod instead.
14288 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14290 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14291 enumerations that are used in heavily used structures derive from
14292 byte in a laughable and pathetic attempt to reduce memory usage.
14293 This is the kind of pre-optimzations that you should not do at
14294 home without adult supervision.
14296 * expression.cs (UnaryMutator): New class, used to handle ++ and
14297 -- separatedly from the other unary operators. Cleans up the
14298 code, and kills the ExpressionStatement dependency in Unary.
14300 (Unary): Removed `method' and `Arguments' from this class, making
14301 it smaller, and moving it all to SimpleCall, so I can reuse this
14302 code in other locations and avoid creating a lot of transient data
14303 strucutres when not required.
14305 * cs-parser.jay: Adjust for new changes.
14307 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14309 * enum.cs (Enum.Populate): If there is a failure during
14312 * cs-parser.jay (opt_enum_base): we used to catch type errors
14313 here, but this is really incorrect. The type error should be
14314 catched during semantic analysis.
14316 2001-12-11 Ravi Pratap <ravi@ximian.com>
14318 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14319 current_local_parameters as expected since I, in my stupidity, had forgotten
14322 * attribute.cs (GetValidPlaces): Fix stupid bug.
14324 * class.cs (Method::Emit): Perform check on applicability of attributes.
14326 (Constructor::Emit): Ditto.
14328 (Field::Emit): Ditto.
14330 (Field.Location): Store location information.
14332 (Property, Event, Indexer, Operator): Ditto.
14334 * cs-parser.jay (field_declaration): Pass in location for each field.
14336 * ../errors/cs0592.cs : Add.
14338 2001-11-12 Ravi Pratap <ravi@ximian.com>
14340 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14342 (InitCoreTypes): Update accordingly.
14344 (RegisterAttrType, LookupAttr): Implement.
14346 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14347 info about the same.
14349 (Resolve): Update to populate the above as necessary.
14351 (Error592): Helper.
14353 (GetValidPlaces): Helper to the above.
14355 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14357 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14359 2001-11-12 Ravi Pratap <ravi@ximian.com>
14361 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14363 * ../errors/cs0617.cs : Add.
14365 2001-11-11 Ravi Pratap <ravi@ximian.com>
14367 * enum.cs (Emit): Rename to Populate to be more consistent with what
14368 we expect it to do and when exactly it is called.
14370 * class.cs, rootcontext.cs : Update accordingly.
14372 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14373 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14375 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14377 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14378 of a fieldinfo using the above, when dealing with a FieldBuilder.
14380 2001-11-10 Ravi Pratap <ravi@ximian.com>
14382 * ../errors/cs0031.cs : Add.
14384 * ../errors/cs1008.cs : Add.
14386 * ../errrors/cs0543.cs : Add.
14388 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14391 (FindMembers): Implement.
14393 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14394 enums and delegates too.
14396 (enum_types): Rename to builder_to_enum.
14398 (delegate_types): Rename to builder_to_delegate.
14400 * delegate.cs (FindMembers): Implement.
14402 2001-11-09 Ravi Pratap <ravi@ximian.com>
14404 * typemanager.cs (IsEnumType): Implement.
14406 * enum.cs (Emit): Re-write parts to account for the underlying type
14407 better and perform checking etc.
14409 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14410 of the underlying type.
14412 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14415 * enum.cs (error31): Helper to report error #31.
14417 * cs-parser.jay (enum_declaration): Store location of each member too.
14419 * enum.cs (member_to_location): New hashtable.
14421 (AddEnumMember): Update location hashtable.
14423 (Emit): Use the location of each member while reporting errors.
14425 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14427 * cs-parser.jay: A for_initializer if is a
14428 local_variable_declaration really ammount to have an implicit
14429 block with the variable declaration and no initializer for for.
14431 * statement.cs (For.Emit): Cope with null initializers.
14433 This fixes the infinite loop on for initializers.
14435 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14437 * enum.cs: More cleanup.
14439 * ecore.cs: Remove dead code.
14441 * class.cs (Property.Emit): More simplification.
14442 (Event.Emit): ditto.
14444 Reworked to have less levels of indentation.
14446 2001-11-08 Ravi Pratap <ravi@ximian.com>
14448 * class.cs (Property): Emit attributes.
14458 * enum.cs (Emit): Ditto.
14460 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14463 * class.cs (Field, Event, etc.): Move attribute generation into the
14464 Emit method everywhere.
14466 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14467 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14468 as we had no way of defining nested enums !
14470 * rootcontext.cs : Adjust code accordingly.
14472 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14474 2001-11-07 Ravi Pratap <ravi@ximian.com>
14476 * expression.cs (EvalConstantExpression): Move into ecore.cs
14478 * enum.cs (Enum): Rename some members and make them public and readonly
14479 according to our convention.
14481 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14484 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14486 (Enum::Emit): Write a simple version for now which doesn't try to compute
14487 expressions. I shall modify this to be more robust in just a while.
14489 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14491 (TypeContainer::CloseType): Create the Enum types too.
14493 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14495 * expression.cs (EvalConstantExpression): Get rid of completely.
14497 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14498 user-defined values and other cases.
14500 (IsValidEnumLiteral): Helper function.
14502 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14503 out there in the case we had a literal FieldExpr.
14505 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
14507 (Literalize): Revamp a bit to take two arguments.
14509 (EnumLiteral): New class which derives from Literal to wrap enum literals.
14511 2001-11-06 Ravi Pratap <ravi@ximian.com>
14513 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
14515 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
14517 (Resolve): Use the above to ensure we have proper initializers.
14519 2001-11-05 Ravi Pratap <ravi@ximian.com>
14521 * expression.cs (Expression::EvalConstantExpression): New method to
14522 evaluate constant expressions.
14524 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
14526 2001-11-07 Miguel de Icaza <miguel@ximian.com>
14528 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
14531 (Binary.ResolveOperator): Handle operator != (object a, object b)
14532 and operator == (object a, object b);
14534 (Binary.DoNumericPromotions): Indicate whether the numeric
14535 promotion was possible.
14537 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
14540 Made the ArrayAccess implement interface IAssignMethod instead of
14541 IStackStore as the order in which arguments are passed reflects
14544 * assign.cs: Instead of using expr.ExprClass to select the way of
14545 assinging, probe for the IStackStore/IAssignMethod interfaces.
14547 * typemanager.cs: Load InitializeArray definition.
14549 * rootcontext.cs (RootContext.MakeStaticData): Used to define
14550 static data that can be used to initialize arrays.
14552 2001-11-05 Miguel de Icaza <miguel@ximian.com>
14554 * expression.cs: Handle operator== and operator!= for booleans.
14556 (Conditioal.Reduce): Implement reducer for the ?: operator.
14558 (Conditional.Resolve): Implement dead code elimination.
14560 (Binary.Resolve): Catch string literals and return a new
14561 concatenated string.
14563 (Unary.Reduce): Implement reduction of unary expressions.
14565 * ecore.cs: Split out the expression core handling here.
14567 (Expression.Reduce): New method used to perform constant folding
14568 and CSE. This is needed to support constant-expressions.
14570 * statement.cs (Statement.EmitBoolExpression): Pass true and false
14571 targets, and optimize for !x.
14573 2001-11-04 Ravi Pratap <ravi@ximian.com>
14575 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
14576 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
14577 set custom atttributes.
14579 * literal.cs (Literal::GetValue): New abstract method to return the actual
14580 value of the literal, cast as an object.
14582 (*Literal): Implement GetValue method.
14584 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
14585 expressions to the arraylist but objects of type Argument.
14587 * class.cs (TypeContainer::Emit): Emit our attributes too.
14589 (Method::Emit, Constructor::Emit): Ditto.
14591 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
14592 to be ignoring earlier.
14594 2001-11-03 Ravi Pratap <ravi@ximian.com>
14596 * attribute.cs (AttributeSection::Define): Implement to do the business
14597 of constructing a CustomAttributeBuilder.
14599 (Attribute): New trivial class. Increases readability of code.
14601 * cs-parser.jay : Update accordingly.
14603 (positional_argument_list, named_argument_list, named_argument): New rules
14605 (attribute_arguments): Use the above so that we are more correct.
14607 2001-11-02 Ravi Pratap <ravi@ximian.com>
14609 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
14610 to perform all checks for a method with a params parameter.
14612 (Invocation::OverloadResolve): Update to use the above method and therefore
14613 cope correctly with params method invocations.
14615 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
14618 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
14619 constructors in our parent too because we can't afford to miss out on
14622 * attribute.cs (AttributeSection): New name for the class Attribute
14624 Other trivial changes to improve readability.
14626 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
14627 use the new class names.
14629 2001-11-01 Ravi Pratap <ravi@ximian.com>
14631 * class.cs (Method::Define): Complete definition for params types too
14633 (Indexer::Define): Ditto.
14635 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
14636 Cope everywhere with a request for info about the array parameter.
14638 2001-11-01 Ravi Pratap <ravi@ximian.com>
14640 * tree.cs (RecordNamespace): Fix up to check for the correct key.
14642 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
14643 local_variable_type to extract the string corresponding to the type.
14645 (local_variable_type): Fixup the action to use the new helper method.
14647 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
14650 * expression.cs : Clean out code which uses the above.
14652 2001-10-31 Ravi Pratap <ravi@ximian.com>
14654 * typemanager.cs (RegisterMethod): Check if we already have an existing key
14655 and bale out if necessary by returning a false.
14657 (RegisterProperty): Ditto.
14659 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
14660 and print out appropriate error messages.
14662 * interface.cs (everywhere): Ditto.
14664 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
14665 location to constructor.
14667 * class.cs (Property, Event, Indexer): Update accordingly.
14669 * ../errors/cs111.cs : Added.
14671 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
14672 of a method, as laid down by the spec.
14674 (Invocation::OverloadResolve): Use the above method.
14676 2001-10-31 Ravi Pratap <ravi@ximian.com>
14678 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
14679 now take a TypeContainer and a Parameters object.
14681 (ParameterData): Modify return type of ParameterModifier method to be
14682 Parameter.Modifier and not a string.
14684 (ReflectionParameters, InternalParameters): Update accordingly.
14686 * expression.cs (Argument::GetParameterModifier): Same here.
14688 * support.cs (InternalParameters::ParameterType): Find a better way of determining
14689 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
14690 symbol in it at all so maybe this is only for now.
14692 2001-10-30 Ravi Pratap <ravi@ximian.com>
14694 * support.cs (InternalParameters): Constructor now takes an extra argument
14695 which is the actual Parameters class.
14697 (ParameterDesc): Update to provide info on ref/out modifiers.
14699 * class.cs (everywhere): Update call to InternalParameters to pass in
14700 the second argument too.
14702 * support.cs (ParameterData): Add ParameterModifier, which is a method
14703 to return the modifier info [ref/out etc]
14705 (InternalParameters, ReflectionParameters): Implement the above.
14707 * expression.cs (Argument::ParameterModifier): Similar function to return
14708 info about the argument's modifiers.
14710 (Invocation::OverloadResolve): Update to take into account matching modifiers
14713 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
14714 a new SetFormalParameters object which we pass to InternalParameters.
14716 2001-10-30 Ravi Pratap <ravi@ximian.com>
14718 * expression.cs (NewArray): Merge into the ArrayCreation class.
14720 2001-10-29 Ravi Pratap <ravi@ximian.com>
14722 * expression.cs (NewArray): Merge classes NewBuiltinArray and
14723 NewUserdefinedArray into one as there wasn't much of a use in having
14726 * expression.cs (Argument): Change field's name to ArgType from Type.
14728 (Type): New readonly property which returns the proper type, taking into
14729 account ref/out modifiers.
14731 (everywhere): Adjust code accordingly for the above.
14733 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
14734 whether we are emitting for a ref or out parameter.
14736 * expression.cs (Argument::Emit): Use the above field to set the state.
14738 (LocalVariableReference::Emit): Update to honour the flag and emit the
14741 * parameter.cs (Attributes): Set the correct flags for ref parameters.
14743 * expression.cs (Argument::FullDesc): New function to provide a full desc.
14745 * support.cs (ParameterData): Add method ParameterDesc to the interface.
14747 (ReflectionParameters, InternalParameters): Implement the above method.
14749 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
14752 (Invocation::FullMethodDesc): Ditto.
14754 2001-10-29 Miguel de Icaza <miguel@ximian.com>
14756 * cs-parser.jay: Add extra production for the second form of array
14759 * expression.cs (ArrayCreation): Update to reflect the above
14762 * Small changes to prepare for Array initialization.
14764 2001-10-28 Miguel de Icaza <miguel@ximian.com>
14766 * typemanager.cs (ImplementsInterface): interface might be null;
14767 Deal with this problem;
14769 Also, we do store negative hits on the cache (null values), so use
14770 this instead of calling t.GetInterfaces on the type everytime.
14772 2001-10-28 Ravi Pratap <ravi@ximian.com>
14774 * typemanager.cs (IsBuiltinType): New method to help determine the same.
14776 * expression.cs (New::DoResolve): Get rid of array creation code and instead
14777 split functionality out into different classes.
14779 (New::FormArrayType): Move into NewBuiltinArray.
14781 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
14784 (NewBuiltinArray): New class to handle creation of built-in arrays.
14786 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
14787 account creation of one-dimensional arrays.
14789 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
14791 (NewUserdefinedArray::DoResolve): Implement.
14793 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
14795 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
14796 we maintain inside the TypeManager. This is necessary to perform lookups on the
14799 (LookupType): Update to perform GetType on the module builders too.
14801 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
14803 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
14805 2001-10-23 Ravi Pratap <ravi@ximian.com>
14807 * expression.cs (New::DoResolve): Implement guts of array creation.
14809 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
14811 2001-10-27 Miguel de Icaza <miguel@ximian.com>
14813 * expression.cs: Fix bug I introduced lsat night that broke
14816 (Expression.Resolve): Report a 246 error (can not resolve name)
14817 if we find a SimpleName in the stream.
14819 (Expression.ResolveLValue): Ditto.
14821 (Expression.ResolveWithSimpleName): This function is a variant of
14822 ResolveName, this one allows SimpleNames to be returned without a
14823 warning. The only consumer of SimpleNames is MemberAccess
14825 2001-10-26 Miguel de Icaza <miguel@ximian.com>
14827 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
14828 might arrive here. I have my doubts that this is correct.
14830 * statement.cs (Lock): Implement lock statement.
14832 * cs-parser.jay: Small fixes to support `lock' and `using'
14834 * cs-tokenizer.cs: Remove extra space
14836 * driver.cs: New flag --checked, allows to turn on integer math
14839 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
14840 Threading.Monitor.Exit
14842 2001-10-23 Miguel de Icaza <miguel@ximian.com>
14844 * expression.cs (IndexerAccess::DoResolveLValue): Set the
14845 Expression Class to be IndexerAccess.
14847 Notice that Indexer::DoResolve sets the eclass to Value.
14849 2001-10-22 Miguel de Icaza <miguel@ximian.com>
14851 * class.cs (TypeContainer::Emit): Emit code for indexers.
14853 * assign.cs (IAssignMethod): New interface implemented by Indexers
14854 and Properties for handling assignment.
14856 (Assign::Emit): Simplify and reuse code.
14858 * expression.cs (IndexerAccess, PropertyExpr): Implement
14859 IAssignMethod, clean up old code.
14861 2001-10-22 Ravi Pratap <ravi@ximian.com>
14863 * typemanager.cs (ImplementsInterface): New method to determine if a type
14864 implements a given interface. Provides a nice cache too.
14866 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
14869 (ConvertReferenceExplicit): Ditto.
14871 * delegate.cs (Delegate::Populate): Update to define the parameters on the
14872 various methods, with correct names etc.
14874 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
14875 Operator.UnaryNegation.
14877 * cs-parser.jay (operator_declarator): Be a little clever in the case where
14878 we have a unary plus or minus operator.
14880 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
14883 * everywhere : update accordingly.
14885 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
14888 * class.cs (Method::Define): For the case where we are implementing a method
14889 inherited from an interface, we need to set the MethodAttributes.Final flag too.
14890 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
14892 2001-10-21 Ravi Pratap <ravi@ximian.com>
14894 * interface.cs (FindMembers): Implement to work around S.R.E
14897 * typemanager.cs (IsInterfaceType): Implement.
14899 (FindMembers): Update to handle interface types too.
14901 * expression.cs (ImplicitReferenceConversion): Re-write bits which
14902 use IsAssignableFrom as that is not correct - it doesn't work.
14904 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
14905 and accordingly override EmitStatement.
14907 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
14908 using the correct logic :-)
14910 2001-10-19 Ravi Pratap <ravi@ximian.com>
14912 * ../errors/cs-11.cs : Add to demonstrate error -11
14914 2001-10-17 Miguel de Icaza <miguel@ximian.com>
14916 * assign.cs (Assign::Resolve): Resolve right hand side first, and
14917 then pass this as a hint to ResolveLValue.
14919 * expression.cs (FieldExpr): Add Location information
14921 (FieldExpr::LValueResolve): Report assignment to readonly
14924 (Expression::ExprClassFromMemberInfo): Pass location information.
14926 (Expression::ResolveLValue): Add new method that resolves an
14929 (Expression::DoResolveLValue): Default invocation calls
14932 (Indexers): New class used to keep track of indexers in a given
14935 (IStackStore): Renamed from LValue, as it did not really describe
14936 what this did. Also ResolveLValue is gone from this interface and
14937 now is part of Expression.
14939 (ElementAccess): Depending on the element access type
14941 * typemanager.cs: Add `indexer_name_type' as a Core type
14942 (System.Runtime.CompilerServices.IndexerNameAttribute)
14944 * statement.cs (Goto): Take a location.
14946 2001-10-18 Ravi Pratap <ravi@ximian.com>
14948 * delegate.cs (Delegate::VerifyDelegate): New method to verify
14949 if two delegates are compatible.
14951 (NewDelegate::DoResolve): Update to take care of the case when
14952 we instantiate a delegate from another delegate.
14954 * typemanager.cs (FindMembers): Don't even try to look up members
14955 of Delegate types for now.
14957 2001-10-18 Ravi Pratap <ravi@ximian.com>
14959 * delegate.cs (NewDelegate): New class to take care of delegate
14962 * expression.cs (New): Split the delegate related code out into
14963 the NewDelegate class.
14965 * delegate.cs (DelegateInvocation): New class to handle delegate
14968 * expression.cs (Invocation): Split out delegate related code into
14969 the DelegateInvocation class.
14971 2001-10-17 Ravi Pratap <ravi@ximian.com>
14973 * expression.cs (New::DoResolve): Implement delegate creation fully
14974 and according to the spec.
14976 (New::DoEmit): Update to handle delegates differently.
14978 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
14979 because of which we were printing out arguments in reverse order !
14981 * delegate.cs (VerifyMethod): Implement to check if the given method
14982 matches the delegate.
14984 (FullDelegateDesc): Implement.
14986 (VerifyApplicability): Implement.
14988 * expression.cs (Invocation::DoResolve): Update to accordingly handle
14989 delegate invocations too.
14991 (Invocation::Emit): Ditto.
14993 * ../errors/cs1593.cs : Added.
14995 * ../errors/cs1594.cs : Added.
14997 * delegate.cs (InstanceExpression, TargetMethod): New properties.
14999 2001-10-16 Ravi Pratap <ravi@ximian.com>
15001 * typemanager.cs (intptr_type): Core type for System.IntPtr
15003 (InitCoreTypes): Update for the same.
15005 (iasyncresult_type, asynccallback_type): Ditto.
15007 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15010 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15013 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15014 the builders for the 4 members of a delegate type :-)
15016 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15019 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15021 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15023 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15025 * statement.cs (Break::Emit): Implement.
15026 (Continue::Emit): Implement.
15028 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15029 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15030 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15031 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15034 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15035 properties that track the label for the current loop (begin of the
15036 loop and end of the loop).
15038 2001-10-15 Ravi Pratap <ravi@ximian.com>
15040 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15041 use of emitting anything at all.
15043 * class.cs, rootcontext.cs : Get rid of calls to the same.
15045 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15047 (Populate): Define the constructor correctly and set the implementation
15050 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15053 (AddDelegateType): Implement.
15055 (IsDelegateType): Implement helper method.
15057 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15059 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15060 and accordingly handle it.
15062 * delegate.cs (Populate): Take TypeContainer argument.
15063 Implement bits to define the Invoke method. However, I still haven't figured out
15064 how to take care of the native int bit :-(
15066 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15067 Qualify the name of the delegate, not its return type !
15069 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15072 (StandardConversionExists): Checking for array types turns out to be recursive.
15074 (ConvertReferenceExplicit): Implement array conversion.
15076 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15078 2001-10-12 Ravi Pratap <ravi@ximian.com>
15080 * cs-parser.jay (delegate_declaration): Store the fully qualified
15081 name as it is a type declaration.
15083 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15086 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15087 as TypeContainer::DefineType.
15089 (Populate): Method in which all the definition of the various methods (Invoke)
15092 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15095 (CloseDelegate): Finally creates the delegate.
15097 * class.cs (TypeContainer::DefineType): Update to define delegates.
15098 (Populate, Emit and CloseType): Do the same thing here too.
15100 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15101 delegates in all these operations.
15103 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15105 * expression.cs: LocalTemporary: a new expression used to
15106 reference a temporary that has been created.
15108 * assign.cs: Handle PropertyAccess back here, so that we can
15109 provide the proper semantic access to properties.
15111 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15112 a few more explicit conversions.
15114 * modifiers.cs: `NEW' modifier maps to HideBySig.
15116 * expression.cs (PropertyExpr): Make this into an
15117 ExpressionStatement, and support the EmitStatement code path.
15119 Perform get/set error checking, clean up the interface.
15121 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15122 them into toplevel access objects.
15124 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15126 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15129 * typemanager.cs: Keep track here of our PropertyBuilders again to
15130 work around lameness in SRE.
15132 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15134 * expression.cs (LValue::LValueResolve): New method in the
15135 interface, used to perform a second resolution pass for LValues.
15137 (This::DoResolve): Catch the use of this in static methods.
15139 (This::LValueResolve): Implement.
15141 (This::Store): Remove warning, assigning to `this' in structures
15144 (Invocation::Emit): Deal with invocation of
15145 methods on value types. We need to pass the address to structure
15146 methods rather than the object itself. (The equivalent code to
15147 emit "this" for structures leaves the entire structure on the
15148 stack instead of a pointer to it).
15150 (ParameterReference::DoResolve): Compute the real index for the
15151 argument based on whether the method takes or not a `this' pointer
15152 (ie, the method is static).
15154 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15155 value types returned from functions when we need to invoke a
15156 method on the sturcture.
15159 2001-10-11 Ravi Pratap <ravi@ximian.com>
15161 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15162 defining the type in the Modulebuilder or Typebuilder. This is to take
15163 care of nested types which need to be defined on the TypeBuilder using
15164 DefineNestedMethod.
15166 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15167 methods in RootContext, only ported to be part of TypeContainer.
15169 (TypeContainer::GetInterfaceOrClass): Ditto.
15171 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15173 * interface.cs (Interface::DefineInterface): New method. Does exactly
15174 what RootContext.CreateInterface did earlier, only it takes care of nested types
15177 (Interface::GetInterfaces): Move from RootContext here and port.
15179 (Interface::GetInterfaceByName): Same here.
15181 * rootcontext.cs (ResolveTree): Re-write.
15183 (PopulateTypes): Re-write.
15185 * class.cs (TypeContainer::Populate): Populate nested types too.
15186 (TypeContainer::Emit): Emit nested members too.
15188 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15189 instead just use the name argument passed in as it is already fully
15192 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15193 to TypeContainer mapping to see if a type is user-defined.
15195 * class.cs (TypeContainer::CloseType): Implement.
15197 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15198 the default constructor.
15200 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15203 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15205 * interface.cs (CloseType): Create the type here.
15207 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15210 Remove all the methods which are now in TypeContainer.
15212 2001-10-10 Ravi Pratap <ravi@ximian.com>
15214 * delegate.cs (Define): Re-write bits to define the delegate
15217 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15219 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15221 * expression.cs (ImplicitReferenceConversion): handle null as well
15222 as a source to convert to any reference type.
15224 * statement.cs (Return): Perform any implicit conversions to
15225 expected return type.
15227 Validate use of return statement.
15229 * codegen.cs (EmitContext): Pass the expected return type here.
15231 * class.cs (Method, Constructor, Property): Pass expected return
15232 type to EmitContext.
15234 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15236 * expression.cs: Make DoResolve take an EmitContext instead of a
15239 Replaced `l' and `location' for `loc', for consistency.
15241 (Error, Warning): Remove unneeded Tc argument.
15243 * assign.cs, literal.cs, constant.cs: Update to new calling
15246 * codegen.cs: EmitContext now contains a flag indicating whether
15247 code is being generated in a static method or not.
15249 * cs-parser.jay: DecomposeQI, new function that replaces the old
15250 QualifiedIdentifier. Now we always decompose the assembled
15251 strings from qualified_identifier productions into a group of
15254 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15256 * rootcontext.cs: Deal with field-less struct types correctly now
15257 by passing the size option to Define Type.
15259 * class.cs: Removed hack that created one static field.
15261 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15263 * statement.cs: Moved most of the code generation here.
15265 2001-10-09 Ravi Pratap <ravi@ximian.com>
15267 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15270 (ElementAccess): Remove useless bits for now - keep checks as the spec
15273 2001-10-08 Ravi Pratap <ravi@ximian.com>
15275 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15276 and start performing checks according to the spec.
15278 2001-10-07 Ravi Pratap <ravi@ximian.com>
15280 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15281 rank_specifiers instead.
15283 (rank_specifiers): Change the order in which the rank specifiers are stored
15285 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15287 * expression.cs (ElementAccess): Implement the LValue interface too.
15289 2001-10-06 Ravi Pratap <ravi@ximian.com>
15291 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15292 except that user defined conversions are not included.
15294 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15295 perform the conversion of the return type, if necessary.
15297 (New::DoResolve): Check whether we are creating an array or an object
15298 and accordingly do the needful.
15300 (New::Emit): Same here.
15302 (New::DoResolve): Implement guts of array creation.
15304 (New::FormLookupType): Helper function.
15306 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15308 * codegen.cs: Removed most of the code generation here, and move the
15309 corresponding code generation bits to the statement classes.
15311 Added support for try/catch/finalize and throw.
15313 * cs-parser.jay: Added support for try/catch/finalize.
15315 * class.cs: Catch static methods having the flags override,
15316 virtual or abstract.
15318 * expression.cs (UserCast): This user cast was not really doing
15319 what it was supposed to do. Which is to be born in fully resolved
15320 state. Parts of the resolution were being performed at Emit time!
15324 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15326 * expression.cs: Implicity convert the result from UserCast.
15328 2001-10-05 Ravi Pratap <ravi@ximian.com>
15330 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15331 prevented it from working correctly.
15333 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15334 merely ConvertImplicit.
15336 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15338 * typemanager.cs: Make the LookupTypeContainer function static,
15339 and not per-instance.
15341 * class.cs: Make static FindMembers (the one that takes a Type
15344 * codegen.cs: Add EmitForeach here.
15346 * cs-parser.jay: Make foreach a toplevel object instead of the
15347 inline expansion, as we need to perform semantic analysis on it.
15349 2001-10-05 Ravi Pratap <ravi@ximian.com>
15351 * expression.cs (Expression::ImplicitUserConversion): Rename to
15352 UserDefinedConversion.
15354 (Expression::UserDefinedConversion): Take an extra argument specifying
15355 whether we look for explicit user conversions too.
15357 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15359 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15361 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15362 with the appropriate arguments.
15364 * cs-parser.jay (cast_expression): Record location too.
15366 * expression.cs (Cast): Record location info.
15368 (Expression::ConvertExplicit): Take location argument.
15370 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15371 to determine if we are doing explicit conversions.
15373 (UserCast::Emit): Update accordingly.
15375 (Expression::ConvertExplicit): Report an error if everything fails.
15377 * ../errors/cs0030.cs : Add.
15379 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15381 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15382 virtual and newslot bits.
15384 * class.cs (TypeContainer::RegisterRequiredImplementations):
15385 Record methods we need.
15387 (TypeContainer::MakeKey): Helper function to make keys for
15388 MethodBases, since the Methodbase key is useless.
15390 (TypeContainer::Populate): Call RegisterRequiredImplementations
15391 before defining the methods.
15393 Create a mapping for method_builders_to_methods ahead of time
15394 instead of inside a tight loop.
15396 (::RequireMethods): Accept an object as the data to set into the
15397 hashtable so we can report interface vs abstract method mismatch.
15399 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15401 * report.cs: Make all of it static.
15403 * rootcontext.cs: Drop object_type and value_type computations, as
15404 we have those in the TypeManager anyways.
15406 Drop report instance variable too, now it is a global.
15408 * driver.cs: Use try/catch on command line handling.
15410 Add --probe option to debug the error reporting system with a test
15413 * report.cs: Add support for exiting program when a probe
15414 condition is reached.
15416 2001-10-03 Ravi Pratap <ravi@ximian.com>
15418 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15419 we do a forcible conversion regardless of type, to check if
15420 ForceConversion returns a null.
15422 (Binary::error19): Use location to report error.
15424 (Unary::error23): Use location here too.
15426 * ../errors/cs0019.cs : Check in.
15428 * ../errors/cs0023.cs : Check in.
15430 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15431 case of a non-null MethodInfo object with a length of 0 !
15433 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15434 an applicable member - according to the spec :-)
15435 Also fix logic to find members in base types.
15437 (Unary::ResolveOperator): Same here.
15439 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15440 as I was getting thoroughly confused between this and error19 :-)
15442 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15443 (::FindMostEncompassedType): Implement.
15444 (::FindMostEncompassingType): Implement.
15445 (::StandardConversionExists): Implement.
15447 (UserImplicitCast): Re-vamp. We now need info about most specific
15448 source and target types so that we can do the necessary conversions.
15450 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15451 mathematical union with no duplicates.
15453 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15455 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15456 in order from base classes to child classes, so that we can in
15457 child classes look up in our parent for method names and
15458 attributes (required for handling abstract, virtual, new, override
15459 constructs: we need to instrospect our base class, and if we dont
15460 populate the classes in order, the introspection might be
15461 incorrect. For example, a method could query its parent before
15462 the parent has any methods and would determine that the parent has
15463 no abstract methods (while it could have had them)).
15465 (RootContext::CreateType): Record the order in which we define the
15468 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15470 * class.cs (TypeContainer::Populate): Also method definitions can
15471 fail now, keep track of this.
15473 (TypeContainer::FindMembers): Implement support for
15474 DeclaredOnly/noDeclaredOnly flag.
15476 (Constructor::Emit) Return the ConstructorBuilder.
15478 (Method::Emit) Return the MethodBuilder.
15479 Check for abstract or virtual methods to be public.
15481 * rootcontext.cs (RootContext::CreateType): Register all the
15482 abstract methods required for the class to be complete and the
15483 interface methods that must be implemented.
15485 * cs-parser.jay: Report error 501 (method requires body if it is
15486 not marked abstract or extern).
15488 * expression.cs (TypeOf::Emit): Implement.
15490 * typemanager.cs: runtime_handle_type, new global type.
15492 * class.cs (Property::Emit): Generate code for properties.
15494 2001-10-02 Ravi Pratap <ravi@ximian.com>
15496 * expression.cs (Unary::ResolveOperator): Find operators on base type
15497 too - we now conform exactly to the spec.
15499 (Binary::ResolveOperator): Same here.
15501 * class.cs (Operator::Define): Fix minor quirk in the tests.
15503 * ../errors/cs0215.cs : Added.
15505 * ../errors/cs0556.cs : Added.
15507 * ../errors/cs0555.cs : Added.
15509 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15511 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
15512 single integer which is really efficient
15514 2001-10-01 Ravi Pratap <ravi@ximian.com>
15516 * expression.cs (Expression::ImplicitUserConversion): Use location
15517 even in the case when we are examining True operators.
15519 * class.cs (Operator::Define): Perform extensive checks to conform
15520 with the rules for operator overloading in the spec.
15522 * expression.cs (Expression::ImplicitReferenceConversion): Implement
15523 some of the other conversions mentioned in the spec.
15525 * typemanager.cs (array_type): New static member for the System.Array built-in
15528 (cloneable_interface): For System.ICloneable interface.
15530 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
15531 we start resolving the tree and populating types.
15533 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
15535 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15537 * expression.cs (Expression::ExprClassFromMemberInfo,
15538 Expression::Literalize): Create literal expressions from
15539 FieldInfos which are literals.
15541 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
15542 type casts, because they were wrong. The test suite in tests
15545 (ImplicitNumericConversion): ushort to ulong requires a widening
15548 Int32 constant to long requires widening cast as well.
15550 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
15551 for integers because the type on the stack is not i4.
15553 2001-09-30 Miguel de Icaza <miguel@ximian.com>
15555 * expression.cs (report118): require location argument.
15557 * parameter.cs: Do not dereference potential null value.
15559 * class.cs: Catch methods that lack the `new' keyword when
15560 overriding a name. Report warnings when `new' is used without
15561 anything being there to override.
15563 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
15565 * class.cs: Only add constructor to hashtable if it is non-null
15566 (as now constructors can fail on define).
15568 (TypeManager, Class, Struct): Take location arguments.
15570 Catch field instance initialization in structs as errors.
15572 accepting_filter: a new filter for FindMembers that is static so
15573 that we dont create an instance per invocation.
15575 (Constructor::Define): Catch errors where a struct constructor is
15578 * cs-parser.jay: Pass location information for various new
15581 * delegate.cs (Delegate): take a location argument.
15583 * driver.cs: Do not call EmitCode if there were problesm in the
15584 Definition of the types, as many Builders wont be there.
15586 * decl.cs (Decl::Decl): Require a location argument.
15588 * cs-tokenizer.cs: Handle properly hex constants that can not fit
15589 into integers, and find the most appropiate integer for it.
15591 * literal.cs: Implement ULongLiteral.
15593 * rootcontext.cs: Provide better information about the location of
15594 failure when CreateType fails.
15596 2001-09-29 Miguel de Icaza <miguel@ximian.com>
15598 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
15601 * expression.cs (Binary::CheckShiftArguments): Add missing type
15603 (Binary::ResolveOperator): Add type to the logical and and logical
15604 or, Bitwise And/Or and Exclusive Or code paths, it was missing
15607 (Binary::DoNumericPromotions): In the case where either argument
15608 is ulong (and most signed types combined with ulong cause an
15609 error) perform implicit integer constant conversions as well.
15611 2001-09-28 Miguel de Icaza <miguel@ximian.com>
15613 * expression.cs (UserImplicitCast): Method should always be
15615 (Invocation::BetterConversion): Simplified test for IntLiteral.
15617 (Expression::ImplicitNumericConversion): Split this routine out.
15618 Put the code that performs implicit constant integer conversions
15621 (Expression::Resolve): Become a wrapper around DoResolve so we can
15622 check eclass and type being set after resolve.
15624 (Invocation::Badness): Remove this dead function
15626 (Binary::ResolveOperator): Do not compute the expensive argumnets
15627 unless we have a union for it.
15629 (Probe::Emit): Is needs to do an isinst and then
15630 compare against null.
15632 (::CanConvert): Added Location argument. If the Location argument
15633 is null (Location.Null), then we do not report errors. This is
15634 used by the `probe' mechanism of the Explicit conversion. We do
15635 not want to generate an error for something that the user
15636 explicitly requested to be casted. But the pipeline for an
15637 explicit cast first tests for potential implicit casts.
15639 So for now, if the Location is null, it means `Probe only' to
15640 avoid adding another argument. Might have to revise this
15643 (ClassCast): New class used to type cast objects into arbitrary
15644 classes (used in Explicit Reference Conversions).
15646 Implement `as' as well.
15648 Reverted all the patches from Ravi below: they were broken:
15650 * The use of `level' as a mechanism to stop recursive
15651 invocations is wrong. That was there just to catch the
15652 bug with a strack trace but not as a way of addressing
15655 To fix the problem we have to *understand* what is going
15656 on and the interactions and come up with a plan, not
15657 just get things going.
15659 * The use of the type conversion cache that I proposed
15660 last night had an open topic: How does this work across
15661 protection domains. A user defined conversion might not
15662 be public in the location where we are applying the
15663 conversion, a different conversion might be selected
15664 (ie, private A->B (better) but public B->A (worse),
15665 inside A, A->B applies, but outside it, B->A will
15668 * On top of that (ie, even if the above is solved),
15669 conversions in a cache need to be abstract. Ie, `To
15670 convert from an Int to a Short use an OpcodeCast', not
15671 `To convert from an Int to a Short use the OpcodeCast on
15672 the variable 5' (which is what this patch was doing).
15674 2001-09-28 Ravi Pratap <ravi@ximian.com>
15676 * expression.cs (Invocation::ConversionExists): Re-write to use
15677 the conversion cache
15679 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
15680 cache all conversions done, not just user-defined ones.
15682 (Invocation::BetterConversion): The real culprit. Use ConversionExists
15683 to determine if a conversion exists instead of acutually trying to
15684 perform the conversion. It's faster too.
15686 (Expression::ConvertExplicit): Modify to use ConversionExists to check
15687 and only then attempt the implicit conversion.
15689 2001-09-28 Ravi Pratap <ravi@ximian.com>
15691 * expression.cs (ConvertImplicit): Use a cache for conversions
15692 already found. Check level of recursion and bail out if necessary.
15694 2001-09-28 Miguel de Icaza <miguel@ximian.com>
15696 * typemanager.cs (string_concat_string_string, string_concat_object_object):
15697 Export standard methods that we expect for string operations.
15699 * statement.cs (Block::UsageWarning): Track usage of variables and
15700 report the errors for not used variables.
15702 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
15705 2001-09-27 Miguel de Icaza <miguel@ximian.com>
15707 * codegen.cs: remove unnneded code
15709 * expression.cs: Removed BuiltinTypeAccess class
15711 Fix the order in which implicit conversions are
15714 The previous fixed dropped support for boxed conversions (adding a
15715 test to the test suite now)
15717 (UserImplicitCast::CanConvert): Remove test for source being null,
15718 that code is broken. We should not feed a null to begin with, if
15719 we do, then we should track the bug where the problem originates
15720 and not try to cover it up here.
15722 Return a resolved expression of type UserImplicitCast on success
15723 rather than true/false. Ravi: this is what I was talking about,
15724 the pattern is to use a static method as a "constructor" for
15727 Also, do not create arguments until the very last minute,
15728 otherwise we always create the arguments even for lookups that
15729 will never be performed.
15731 (UserImplicitCast::Resolve): Eliminate, objects of type
15732 UserImplicitCast are born in a fully resolved state.
15734 * typemanager.cs (InitCoreTypes): Init also value_type
15735 (System.ValueType).
15737 * expression.cs (Cast::Resolve): First resolve the child expression.
15739 (LValue): Add new method AddressOf to be used by
15742 Change the argument of Store to take an EmitContext instead of an
15743 ILGenerator, because things like FieldExpr need to be able to call
15744 their children expression to generate the instance code.
15746 (Expression::Error, Expression::Warning): Sugar functions for
15749 (Expression::MemberLookup): Accept a TypeContainer instead of a
15750 Report as the first argument.
15752 (Expression::ResolvePrimary): Killed. I still want to improve
15753 this as currently the code is just not right.
15755 (Expression::ResolveMemberAccess): Simplify, but it is still
15758 (Unary::Resolve): Catch errors in AddressOf operators.
15760 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
15761 index to a byte for the short-version, or the compiler will choose
15762 the wrong Emit call, which generates the wrong data.
15764 (ParameterReference::Emit, ::Store): same.
15766 (FieldExpr::AddressOf): Implement.
15768 * typemanager.cs: TypeManager: made public variable instead of
15771 * driver.cs: document --fatal.
15773 * report.cs (ErrorMessage, WarningMessage): new names for the old
15774 Error and Warning classes.
15776 * cs-parser.jay (member_access): Turn built-in access to types
15777 into a normal simplename
15779 2001-09-27 Ravi Pratap <ravi@ximian.com>
15781 * expression.cs (Invocation::BetterConversion): Fix to cope
15782 with q being null, since this was introducing a bug.
15784 * expression.cs (ConvertImplicit): Do built-in conversions first.
15786 2001-09-27 Ravi Pratap <ravi@ximian.com>
15788 * expression.cs (UserImplicitCast::Resolve): Fix bug.
15790 2001-09-27 Ravi Pratap <ravi@ximian.com>
15792 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
15793 I had introduced long ago (what's new ?).
15795 * expression.cs (UserImplicitCast::CanConvert): Static method to do
15796 the work of all the checking.
15797 (ConvertImplicit): Call CanConvert and only then create object if necessary.
15798 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
15800 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
15801 that is the right way.
15803 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
15804 overloading resolution. Use everywhere instead of cutting and pasting code.
15806 (Binary::ResolveOperator): Use MakeUnionSet.
15808 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
15809 we have to convert to bool types. Not complete yet.
15811 2001-09-27 Miguel de Icaza <miguel@ximian.com>
15813 * typemanager.cs (TypeManager::CSharpName): support ushort.
15815 * expression.cs (Expression::TryImplicitIntConversion): Attempts
15816 to provide an expression that performsn an implicit constant int
15817 conversion (section 6.1.6).
15818 (Expression::ConvertImplicitRequired): Reworked to include
15819 implicit constant expression conversions.
15821 (Expression::ConvertNumericExplicit): Finished.
15823 (Invocation::Emit): If InstanceExpression is null, then it means
15824 that we perform a call on this.
15826 2001-09-26 Miguel de Icaza <miguel@ximian.com>
15828 * expression.cs (Unary::Emit): Remove some dead code.
15829 (Probe): Implement Resolve and Emit for `is'.
15830 (Expression::ConvertImplicitRequired): Attempt to do constant
15831 expression conversions here. Maybe should be moved to
15832 ConvertImplicit, but I am not sure.
15833 (Expression::ImplicitLongConstantConversionPossible,
15834 Expression::ImplicitIntConstantConversionPossible): New functions
15835 that tell whether is it possible to apply an implicit constant
15836 expression conversion.
15838 (ConvertNumericExplicit): Started work on explicit numeric
15841 * cs-parser.jay: Update operator constants.
15843 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
15844 (Parameters::GetSignature): Hook up VerifyArgs here.
15845 (Parameters::VerifyArgs): Verifies that no two arguments have the
15848 * class.cs (Operator): Update the operator names to reflect the
15849 ones that the spec expects (as we are just stringizing the
15852 * expression.cs (Unary::ResolveOperator): Fix bug: Use
15853 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
15854 previous usage did only work for our methods.
15855 (Expression::ConvertImplicit): Handle decimal implicit numeric
15856 conversions as well.
15857 (Expression::InternalTypeConstructor): Used to invoke constructors
15858 on internal types for default promotions.
15860 (Unary::Emit): Implement special handling for the pre/post
15861 increment/decrement for overloaded operators, as they need to have
15862 the same semantics as the other operators.
15864 (Binary::ResolveOperator): ditto.
15865 (Invocation::ConversionExists): ditto.
15866 (UserImplicitCast::Resolve): ditto.
15868 2001-09-26 Ravi Pratap <ravi@ximian.com>
15870 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
15871 operator, return after emitting body. Regression tests pass again !
15873 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
15874 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
15875 (Invocation::OverloadResolve): Ditto.
15876 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
15878 * everywhere : update calls to the above methods accordingly.
15880 2001-09-26 Miguel de Icaza <miguel@ximian.com>
15882 * assign.cs (Assign): Make it inherit from ExpressionStatement.
15884 * expression.cs (ExpressionStatement): New base class used for
15885 expressions that can appear in statements, so that we can provide
15886 an alternate path to generate expression that do not leave a value
15889 (Expression::Emit, and all the derivatives): We no longer return
15890 whether a value is left on the stack or not. Every expression
15891 after being emitted leaves a single value on the stack.
15893 * codegen.cs (EmitContext::EmitStatementExpression): Use the
15894 facilties of ExpressionStatement if possible.
15896 * cs-parser.jay: Update statement_expression.
15898 2001-09-25 Miguel de Icaza <miguel@ximian.com>
15900 * driver.cs: Change the wording of message
15902 2001-09-25 Ravi Pratap <ravi@ximian.com>
15904 * expression.cs (Binary::ResolveOperator): Had forgottten to set
15905 the type of the expression to the return type of the method if
15906 we have an overloaded operator match ! The regression tests pass again !
15907 (Unary::ResolveOperator): Ditto.
15909 * expression.cs (Invocation::ConversionExists): Correct the member lookup
15910 to find "op_Implicit", not "implicit" ;-)
15911 (UserImplicitCast): New class to take care of user-defined implicit conversions.
15912 (ConvertImplicit, ForceConversion): Take TypeContainer argument
15914 * everywhere : Correct calls to the above accordingly.
15916 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
15917 (ConvertImplicit): Do user-defined conversion if it exists.
15919 2001-09-24 Miguel de Icaza <miguel@ximian.com>
15921 * assign.cs: track location.
15922 (Resolve): Use implicit conversions on assignment.
15924 * literal.cs: Oops. Not good, Emit of short access values should
15925 pass (Bytes) or the wrong argument will be selected.
15927 * expression.cs (Unary::Emit): Emit code for -expr.
15929 (Unary::ResolveOperator): Handle `Substract' for non-constants
15930 (substract from zero from the non-constants).
15931 Deal with Doubles as well.
15933 (Expression::ConvertImplicitRequired): New routine that reports an
15934 error if no implicit conversion exists.
15936 (Invocation::OverloadResolve): Store the converted implicit
15937 expressions if we make them
15939 2001-09-24 Ravi Pratap <ravi@ximian.com>
15941 * class.cs (ConstructorInitializer): Take a Location argument.
15942 (ConstructorBaseInitializer): Same here.
15943 (ConstructorThisInitializer): Same here.
15945 * cs-parser.jay : Update all calls accordingly.
15947 * expression.cs (Unary, Binary, New): Take location argument.
15948 Update accordingly everywhere.
15950 * cs-parser.jay : Update all calls to the above to take a location
15953 * class.cs : Ditto.
15955 2001-09-24 Ravi Pratap <ravi@ximian.com>
15957 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
15958 (Invocation::BetterConversion): Same here
15959 (Invocation::ConversionExists): Ditto.
15961 (Invocation::ConversionExists): Implement.
15963 2001-09-22 Ravi Pratap <ravi@ximian.com>
15965 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
15966 Also take an additional TypeContainer argument.
15968 * All over : Pass in TypeContainer as argument to OverloadResolve.
15970 * typemanager.cs (CSharpName): Update to check for the string type and return
15973 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
15976 2001-09-21 Ravi Pratap <ravi@ximian.com>
15978 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
15979 (Invocation::BetterFunction): Implement.
15980 (Invocation::BetterConversion): Implement.
15981 (Invocation::ConversionExists): Skeleton, no implementation yet.
15983 Okay, things work fine !
15985 2001-09-21 Miguel de Icaza <miguel@ximian.com>
15987 * typemanager.cs: declare and load enum_type, delegate_type and
15990 * expression.cs (Expression::Emit): Now emit returns a value that
15991 tells whether a value is left on the stack or not. This strategy
15992 might be reveted tomorrow with a mechanism that would address
15993 multiple assignments.
15994 (Expression::report118): Utility routine to report mismatches on
15997 (Unary::Report23): Report impossible type/operator combination
16000 (Unary::IsIncrementableNumber): Whether the type can be
16001 incremented or decremented with add.
16002 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16004 (Unary::ResolveOperator): Implement ++, !, ~,
16006 (Invocation::Emit): Deal with new Emit convetion.
16008 * All Expression derivatives: Updated their Emit method to return
16009 whether they leave values on the stack or not.
16011 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16012 stack for expressions that are statements.
16014 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16016 * expression.cs (LValue): New interface. Must be implemented by
16018 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16021 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16022 interface for generating code, simplifies the code.
16024 2001-09-20 Ravi Pratap <ravi@ximian.com>
16026 * expression.cs (everywhere): Comment out return statements in ::Resolve
16027 methods to avoid the warnings.
16029 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16031 * driver.cs (parse): Report error 2001 if we can not open the
16034 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16037 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16040 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16041 otherwise nested blocks end up with the same index.
16043 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16045 * expression.cs: Instead of having FIXMEs in the Resolve
16046 functions, throw exceptions so it is obvious that we are facing a
16049 * cs-parser.jay (invocation_expression): Pass Location information.
16051 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16052 Use a basename for those routines because .NET does not like paths
16055 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16058 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16060 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16061 are loading the correct data types (throws an exception if not).
16062 (TypeManager::InitCoreTypes): Use CoreLookupType
16064 * expression.cs (Unary::ResolveOperator): return the child
16065 expression for expressions which are just +expr.
16066 (Unary::ResolveOperator): Return negative literals for -LITERAL
16067 expressions (otherwise they are Unary {Literal}).
16068 (Invocation::Badness): Take into account `Implicit constant
16069 expression conversions'.
16071 * literal.cs (LongLiteral): Implement long literal class.
16072 (IntLiteral): export the `Value' of the intliteral.
16074 2001-09-19 Ravi Pratap <ravi@ximian.com>
16076 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16078 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16079 instead of 'Operator'
16081 * expression.cs (Binary::ResolveOperator): Update accordingly.
16082 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16085 * cs-parser.jay (unary_expression): Update to use the new names.
16087 * gen-treedump.cs (GetUnary): Same here.
16089 * expression.cs (Unary::Resolve): Implement.
16090 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16091 operators are found instead of making noise ;-)
16092 (Unary::ResolveOperator): New method to do precisely the same thing which
16093 Binary::ResolveOperator does for Binary expressions.
16094 (Unary.method, .Arguments): Add.
16095 (Unary::OperName): Implement.
16096 (Unary::ForceConversion): Copy and Paste !
16098 * class.cs (Operator::Define): Fix a small bug for the case when we have
16101 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16102 for the inbuilt operators. Only overloading works for now ;-)
16104 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16106 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16107 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16109 * expression.cs (This::Emit): Implement.
16110 (This::Resolve): Implement.
16111 (TypeOf:Resolve): Implement.
16112 (Expression::ResolveSimpleName): Add an implicit this to instance
16114 (MemberAccess::Resolve): Deal with Parameters and Fields.
16115 Bind instance variable to Field expressions.
16116 (FieldExpr::Instance): New field used to track the expression that
16117 represents the object instance.
16118 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16120 (FieldExpr::Emit): Implement.
16122 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16123 the last instruction contains a return opcode to avoid generating
16124 the last `ret' instruction (this generates correct code, and it is
16125 nice to pass the peverify output).
16127 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16128 initializer for static and instance variables.
16129 (Constructor::Emit): Allow initializer to be null in the case of
16130 static constructors. Only emit initializer for instance
16133 (TypeContainer::FindMembers): Return a null array if there are no
16136 Also fix the code for the MemberTypes.Method branch, as it was not
16137 scanning that for operators (or tried to access null variables before).
16139 * assign.cs (Assign::Emit): Handle instance and static fields.
16143 * driver.cs: Stop compilation if there are parse errors.
16145 * cs-parser.jay (constructor_declaration): Provide default base
16146 initializer for non-static constructors.
16147 (constructor_declarator): Do not provide a default base
16148 initializers if none was specified.
16149 Catch the fact that constructors should not have parameters.
16151 * class.cs: Do not emit parent class initializers for static
16152 constructors, that should be flagged as an error.
16154 2001-09-18 Ravi Pratap <ravi@ximian.com>
16156 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16157 Move back code into TypeContainer::Populate.
16159 2001-09-18 Ravi Pratap <ravi@ximian.com>
16161 * class.cs (TypeContainer::AddConstructor): Fix the check to
16162 compare against Name, not Basename.
16163 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16165 * cs-parser.jay : Update accordingly.
16167 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16168 for methods, don't forget to look into the operators too.
16169 (RegisterMethodBuilder): Helper method to take care of this for
16170 methods, constructors and operators.
16171 (Operator::Define): Completely revamp.
16172 (Operator.OperatorMethod, MethodName): New fields.
16173 (TypeContainer::Populate): Move the registering of builders into
16174 RegisterMethodBuilder.
16175 (Operator::Emit): Re-write.
16177 * expression.cs (Binary::Emit): Comment out code path to emit method
16178 invocation stuff for the case when we have a user defined operator. I am
16179 just not able to get it right !
16181 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16183 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16186 (Expression::MemberLookup): Provide a version that allows to
16187 specify the MemberTypes and BindingFlags.
16189 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16190 so it was not fetching variable information from outer blocks.
16192 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16193 Beforefieldinit as it was buggy.
16195 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16196 that Ravi put here.
16198 * class.cs (Constructor::Emit): Only emit if block is not null.
16199 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16200 deal with this by semantically definining it as if the user had
16203 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16204 constructors as we now "emit" them at a higher level.
16206 (TypeContainer::DefineDefaultConstructor): Used to define the
16207 default constructors if none was provided.
16209 (ConstructorInitializer): Add methods Resolve and Emit.
16211 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16213 2001-09-17 Ravi Pratap <ravi@ximian.com>
16215 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16216 the default constructor builder with our hashtable for methodbuilders
16219 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16220 and argument_count is 0 in which case we have a match.
16221 (Binary::ResolveOperator): More null checking and miscellaneous coding
16224 2001-09-17 Ravi Pratap <ravi@ximian.com>
16226 * rootcontext.cs (IsNameSpace): Compare against null.
16228 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16230 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16231 and Unary::Operator.
16233 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16236 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16237 we have overloaded operators.
16238 (Binary::ResolveOperator): Implement the part which does the operator overload
16241 * class.cs (Operator::Emit): Implement.
16242 (TypeContainer::Emit): Emit the operators we have too.
16244 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16245 the case when we have a user-defined operator.
16247 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16249 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16251 2001-09-16 Ravi Pratap <ravi@ximian.com>
16253 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16254 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16255 (Constructor::Emit): Implement.
16256 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16257 if we have no work to do.
16258 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16261 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16262 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16264 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16267 2001-09-15 Ravi Pratap <ravi@ximian.com>
16269 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16271 (Tree::RecordNamespace): Method to do what the name says ;-)
16272 (Tree::Namespaces): Property to get at the namespaces hashtable.
16274 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16277 * rootcontext.cs (IsNamespace): Fixed it :-)
16279 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16281 * class.cs (TypeContainer::FindMembers): Add support for
16283 (MethodCore): New class that encapsulates both the shared aspects
16284 of a Constructor and a Method.
16285 (Method, Constructor): Factored pieces into MethodCore.
16287 * driver.cs: Added --fatal which makes errors throw exceptions.
16288 Load System assembly as well as part of the standard library.
16290 * report.cs: Allow throwing exceptions on errors for debugging.
16292 * modifiers.cs: Do not use `parent', instead use the real type
16293 container to evaluate permission settings.
16295 * class.cs: Put Ravi's patch back in. He is right, and we will
16296 have to cope with the
16298 2001-09-14 Ravi Pratap <ravi@ximian.com>
16300 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16301 FamORAssem, not FamANDAssem.
16303 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16305 * driver.cs: Added --parse option that only parses its input files
16308 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16309 incorrect. IsTopLevel is not used to tell whether an object is
16310 root_types or not (that can be achieved by testing this ==
16311 root_types). But to see if this is a top-level *class* (not
16312 necessarly our "toplevel" container).
16314 2001-09-14 Ravi Pratap <ravi@ximian.com>
16316 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16317 parent instead of a direct call to GetType.
16319 2001-09-14 Ravi Pratap <ravi@ximian.com>
16321 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16322 Modifiers.TypeAttr. This should just be a call to that method.
16324 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16325 object so that we can determine if we are top-level or not.
16327 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16330 * enum.cs (Enum::Define): Ditto.
16332 * modifiers.cs (FieldAttr): Re-write.
16334 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16335 (TypeContainer::HaveStaticConstructor): New property to provide access
16336 to precisely that info.
16338 * modifiers.cs (MethodAttr): Re-write.
16339 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16341 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16342 of top-level types as claimed.
16344 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16346 * expression.cs (MemberLookup): Fruitless attempt to lookup
16347 constructors. Maybe I need to emit default constructors? That
16348 might be it (currently .NET emits this for me automatically).
16349 (Invocation::OverloadResolve): Cope with Arguments == null.
16350 (Invocation::EmitArguments): new function, shared by the new
16351 constructor and us.
16352 (Invocation::Emit): Handle static and instance methods. Emit
16353 proper call instruction for virtual or non-virtual invocations.
16354 (New::Emit): Implement.
16355 (New::Resolve): Implement.
16356 (MemberAccess:Resolve): Implement.
16357 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16358 to track instances.
16359 (FieldExpr::Resolve): Set type.
16361 * support.cs: Handle empty arguments.
16363 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16364 SimpleLookup): Auxiliary routines to help parse a qualifier
16367 Update qualifier_identifier rule.
16369 * codegen.cs: Removed debugging messages.
16371 * class.cs: Make this a global thing, this acts just as a "key" to
16372 objects that we might have around.
16374 (Populate): Only initialize method_builders_to_methods once.
16376 * expression.cs (PropertyExpr): Initialize type from the
16379 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16380 Resolve pattern. Attempt to implicitly convert value to boolean.
16383 * expression.cs: Set the type for the int32/int32 argument case.
16384 (Binary::ResolveOperator): Set the return type to boolean for
16385 comparission operators
16387 * typemanager.cs: Remove debugging print code.
16389 (Invocation::Resolve): resolve type.
16391 * class.cs: Allocate a MemberInfo of the correct size, as the code
16392 elsewhere depends on the test to reflect the correct contents.
16394 (Method::) Keep track of parameters, due to System.Reflection holes
16396 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16399 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16400 of the exact size and return that.
16402 (Class::LookupMethodByBuilder): New function that maps
16403 MethodBuilders to its methods. Required to locate the information
16404 on methods because System.Reflection bit us again.
16406 * support.cs: New file, contains an interface ParameterData and
16407 two implementations: ReflectionParameters and InternalParameters
16408 used to access Parameter information. We will need to grow this
16411 * expression.cs (Invocation::GetParameterData): implement a cache
16412 and a wrapper around the ParameterData creation for methods.
16413 (Invocation::OverloadResolve): Use new code.
16415 2001-09-13 Ravi Pratap <ravi@ximian.com>
16417 * class.cs (TypeContainer::EmitField): Remove and move into
16418 (Field::Define): here and modify accordingly.
16419 (Field.FieldBuilder): New member.
16420 (TypeContainer::Populate): Update accordingly.
16421 (TypeContainer::FindMembers): Implement.
16423 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16425 * statement.cs: (VariableInfo::VariableType): New field to be
16426 initialized with the full type once it is resolved.
16428 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16430 * parameter.cs (GetParameterInfo): Use a type cache to compute
16431 things only once, and to reuse this information
16433 * expression.cs (LocalVariableReference::Emit): Implement.
16434 (OpcodeCast::Emit): fix.
16436 (ParameterReference::Resolve): Implement.
16437 (ParameterReference::Emit): Implement.
16439 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16440 that are expressions need to stay as Expressions.
16442 * typemanager.cs (CSharpName): Returns the C# name of a type if
16445 * expression.cs (Expression::ConvertImplicit): New function that
16446 implements implicit type conversions.
16448 (Expression::ImplicitReferenceConversion): Implements implicit
16449 reference conversions.
16451 (EmptyCast): New type for transparent casts.
16453 (OpcodeCast): New type for casts of types that are performed with
16454 a sequence of bytecodes.
16456 (BoxedCast): New type used for casting value types into reference
16457 types. Emits a box opcode.
16459 (Binary::DoNumericPromotions): Implements numeric promotions of
16460 and computation of the Binary::Type.
16462 (Binary::EmitBranchable): Optimization.
16464 (Binary::Emit): Implement code emission for expressions.
16466 * typemanager.cs (TypeManager): Added two new core types: sbyte
16469 2001-09-12 Ravi Pratap <ravi@ximian.com>
16471 * class.cs (TypeContainer::FindMembers): Method which does exactly
16472 what Type.FindMembers does, only we don't have to use reflection. No
16473 implementation yet.
16475 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16476 typecontainer objects as we need to get at them.
16477 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16479 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16480 typecontainer object.
16482 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16483 of just a Report object.
16485 2001-09-11 Ravi Pratap <ravi@ximian.com>
16487 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16489 (TypeContainer::Populate): Now define the delegates of the type too.
16490 (TypeContainer.Delegates): Property to access the list of delegates defined
16493 * delegates.cs (Delegate::Define): Implement partially.
16495 * modifiers.cs (TypeAttr): Handle more flags.
16497 2001-09-11 Ravi Pratap <ravi@ximian.com>
16499 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16501 (Operator::Define): Re-write logic to get types by using the LookupType method
16502 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16503 (Indexer::Define): Ditto.
16504 (Event::Define): Ditto.
16505 (Property::Define): Ditto.
16507 2001-09-10 Ravi Pratap <ravi@ximian.com>
16509 * class.cs (TypeContainer::Populate): Now define operators too.
16510 (TypeContainer.Operators): New property to access the list of operators
16512 (Operator.OperatorMethodBuilder): New member to hold the method builder
16513 for the operator we are defining.
16514 (Operator::Define): Implement.
16516 2001-09-10 Ravi Pratap <ravi@ximian.com>
16518 * class.cs (Event::Define): Make the prefixes of the accessor methods
16519 addOn_ and removeOn_
16521 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
16522 of the location being passed in too. Ideally, this should go later since all
16523 error reporting should be done through the Report object.
16525 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
16526 (Populate): Iterate thru the indexers we have and define them too.
16527 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
16528 for the get and set accessors.
16529 (Indexer::Define): Implement.
16531 2001-09-09 Miguel de Icaza <miguel@ximian.com>
16533 * expression.cs (Binary::Resolve): Beginning of it. I scratched
16534 my previous implementation, did not work.
16536 * typemanager.cs: Add a couple of missing types (the longs).
16538 * literal.cs: Use TypeManager.bool_type instead of getting it.
16540 * expression.cs (EventExpr): New kind of expressions.
16541 (Expressio::ExprClassFromMemberInfo): finish
16543 2001-09-08 Miguel de Icaza <miguel@ximian.com>
16545 * assign.cs: Emit stores to static fields differently.
16547 2001-09-08 Ravi Pratap <ravi@ximian.com>
16549 * Merge in changes and adjust code to tackle conflicts. Backed out my
16550 code in Assign::Resolve ;-)
16552 2001-09-08 Ravi Pratap <ravi@ximian.com>
16554 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
16555 instead Report.Error and also pass in the location.
16556 (CSharpParser::Lexer): New readonly property to return the reference
16557 to the Tokenizer object.
16558 (declare_local_variables): Use Report.Error with location instead of plain
16562 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
16563 (Operator.CheckBinaryOperator): Ditto.
16565 * cs-parser.jay (operator_declarator): Update accordingly.
16567 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
16568 (CheckBinaryOperator): Same here.
16570 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
16571 on the name without any prefixes of namespace names etc. This is because we
16572 already might have something already fully qualified like
16573 'System.Console.WriteLine'
16575 * assign.cs (Resolve): Begin implementation. Stuck ;-)
16577 2001-09-07 Ravi Pratap <ravi@ximian.com>
16579 * cs-tokenizer.cs (location): Return a string which also contains
16582 * expression.cs (ElementAccess): New class for expressions of the
16583 type 'element access.'
16584 (BaseAccess): New class for expressions of the type 'base access.'
16585 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
16588 * cs-parser.jay (element_access): Implement action.
16589 (base_access): Implement actions.
16590 (checked_expression, unchecked_expression): Implement.
16592 * cs-parser.jay (local_variable_type): Correct and implement.
16593 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
16595 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
16597 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
16598 name and the specifiers.
16600 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
16602 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
16603 making them all public ;-)
16605 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
16608 2001-09-07 Miguel de Icaza <miguel@ximian.com>
16610 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
16612 (FieldExpr, PropertyExprs): New resolved expressions.
16613 (SimpleName::MemberStaticCheck): Perform static checks for access
16614 to non-static fields on static methods. Maybe this should be
16615 generalized for MemberAccesses.
16616 (SimpleName::ResolveSimpleName): More work on simple name
16619 * cs-parser.jay (primary_expression/qualified_identifier): track
16620 the parameter index.
16622 * codegen.cs (CodeGen::Save): Catch save exception, report error.
16623 (EmitContext::EmitBoolExpression): Chain to expression generation
16624 instead of temporary hack.
16625 (::EmitStatementExpression): Put generic expression code generation.
16627 * assign.cs (Assign::Emit): Implement variable assignments to
16628 local variables, parameters and fields.
16630 2001-09-06 Miguel de Icaza <miguel@ximian.com>
16632 * statement.cs (Block::GetVariableInfo): New method, returns the
16633 VariableInfo for a variable name in a block.
16634 (Block::GetVariableType): Implement in terms of GetVariableInfo
16636 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
16637 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
16639 2001-09-06 Ravi Pratap <ravi@ximian.com>
16641 * cs-parser.jay (operator_declaration): Continue on my quest : update
16642 to take attributes argument.
16643 (event_declaration): Ditto.
16644 (enum_declaration): Ditto.
16645 (indexer_declaration): Ditto.
16647 * class.cs (Operator::Operator): Update constructor accordingly.
16648 (Event::Event): Ditto.
16650 * delegate.cs (Delegate::Delegate): Same here.
16652 * enum.cs (Enum::Enum): Same here.
16654 2001-09-05 Ravi Pratap <ravi@ximian.com>
16656 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
16658 * ../tests/cs0658.cs : New file to demonstrate error 0658.
16660 * attribute.cs (Attributes): New class to encapsulate all attributes which were
16661 being passed around as an arraylist.
16662 (Attributes::AddAttribute): Method to add attribute sections.
16664 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
16665 (struct_declaration): Update accordingly.
16666 (constant_declaration): Update.
16667 (field_declaration): Update.
16668 (method_header): Update.
16669 (fixed_parameter): Update.
16670 (parameter_array): Ditto.
16671 (property_declaration): Ditto.
16672 (destructor_declaration): Ditto.
16674 * class.cs (Struct::Struct): Update constructors accordingly.
16675 (Class::Class): Ditto.
16676 (Field::Field): Ditto.
16677 (Method::Method): Ditto.
16678 (Property::Property): Ditto.
16679 (TypeContainer::OptAttribute): update property's return type.
16681 * interface.cs (Interface.opt_attributes): New member.
16682 (Interface::Interface): Update to take the extra Attributes argument.
16684 * parameter.cs (Parameter::Parameter): Ditto.
16686 * constant.cs (Constant::Constant): Ditto.
16688 * interface.cs (InterfaceMemberBase): New OptAttributes field.
16689 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
16690 the attributes as a parameter.
16691 (InterfaceProperty): Update constructor call.
16692 (InterfaceEvent): Ditto.
16693 (InterfaceMethod): Ditto.
16694 (InterfaceIndexer): Ditto.
16696 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
16697 pass the attributes too.
16698 (interface_event_declaration): Ditto.
16699 (interface_property_declaration): Ditto.
16700 (interface_method_declaration): Ditto.
16701 (interface_declaration): Ditto.
16703 2001-09-05 Miguel de Icaza <miguel@ximian.com>
16705 * class.cs (Method::Define): Track the "static Main" definition to
16706 create an entry point.
16708 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
16709 EntryPoint if we find it.
16711 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
16712 (EmitContext::ig): Make this variable public.
16714 * driver.cs: Make the default output file be the first file name
16715 with the .exe extension.
16717 Detect empty compilations
16719 Handle various kinds of output targets. Handle --target and
16720 rename -t to --dumper.
16722 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
16723 methods inherited from Expression return now an Expression. This
16724 will is used during the tree rewriting as we resolve them during
16727 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
16728 the spec. Missing entirely is the information about
16729 accessability of elements of it.
16731 (Expression::ExprClassFromMemberInfo): New constructor for
16732 Expressions that creates a fully initialized Expression based on
16733 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
16736 (Invocation::Resolve): Begin implementing resolution of invocations.
16738 * literal.cs (StringLiteral): Implement Emit.
16740 2001-09-05 Ravi Pratap <ravi@ximian.com>
16742 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
16745 2001-09-04 Ravi Pratap <ravi@ximian.com>
16747 * cs-parser.jay (attribute_arguments): Implement actions.
16748 (attribute): Fix bug in production. Implement action.
16749 (attribute_list): Implement.
16750 (attribute_target): Implement.
16751 (attribute_target_specifier, opt_target_specifier): Implement
16752 (CheckAttributeTarget): New method to check if the attribute target
16754 (attribute_section): Implement.
16755 (opt_attributes): Implement.
16757 * attribute.cs : New file to handle attributes.
16758 (Attribute): Class to hold attribute info.
16760 * cs-parser.jay (opt_attribute_target_specifier): Remove production
16761 (attribute_section): Modify production to use 2 different rules to
16762 achieve the same thing. 1 s/r conflict down !
16763 Clean out commented, useless, non-reducing dimension_separator rules.
16765 * class.cs (TypeContainer.attributes): New member to hold list
16766 of attributes for a type.
16767 (Struct::Struct): Modify to take one more argument, the attribute list.
16768 (Class::Class): Ditto.
16769 (Field::Field): Ditto.
16770 (Method::Method): Ditto.
16771 (Property::Property): Ditto.
16773 * cs-parser.jay (struct_declaration): Update constructor call to
16774 pass in the attributes too.
16775 (class_declaration): Ditto.
16776 (constant_declaration): Ditto.
16777 (field_declaration): Ditto.
16778 (method_header): Ditto.
16779 (fixed_parameter): Ditto.
16780 (parameter_array): Ditto.
16781 (property_declaration): Ditto.
16783 * constant.cs (Constant::Constant): Update constructor similarly.
16784 Use System.Collections.
16786 * parameter.cs (Parameter::Parameter): Update as above.
16788 2001-09-02 Ravi Pratap <ravi@ximian.com>
16790 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
16791 (TypeContainer.delegates): New member to hold list of delegates.
16793 * cs-parser.jay (delegate_declaration): Implement the action correctly
16794 this time as I seem to be on crack ;-)
16796 2001-09-02 Miguel de Icaza <miguel@ximian.com>
16798 * rootcontext.cs (RootContext::IsNamespace): new function, used to
16799 tell whether an identifier represents a namespace.
16801 * expression.cs (NamespaceExpr): A namespace expression, used only
16802 temporarly during expression resolution.
16803 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
16804 utility functions to resolve names on expressions.
16806 2001-09-01 Miguel de Icaza <miguel@ximian.com>
16808 * codegen.cs: Add hook for StatementExpressions.
16810 * class.cs: Fix inverted test for static flag in methods.
16812 2001-09-02 Ravi Pratap <ravi@ximian.com>
16814 * class.cs (Operator::CheckUnaryOperator): Correct error number used
16815 to make it coincide with MS' number.
16816 (Operator::CheckBinaryOperator): Ditto.
16818 * ../errors/errors.txt : Remove error numbers added earlier.
16820 * ../errors/cs1019.cs : Test case for error # 1019
16822 * ../errros/cs1020.cs : Test case for error # 1020
16824 * cs-parser.jay : Clean out commented cruft.
16825 (dimension_separators, dimension_separator): Comment out. Ostensibly not
16826 used anywhere - non-reducing rule.
16827 (namespace_declarations): Non-reducing rule - comment out.
16829 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
16830 with TypeContainer::AddEnum.
16832 * delegate.cs : New file for delegate handling classes.
16833 (Delegate): Class for declaring delegates.
16835 * makefile : Update.
16837 * cs-parser.jay (delegate_declaration): Implement.
16839 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
16841 * class.cs (Event::Define): Implement.
16842 (Event.EventBuilder): New member.
16844 * class.cs (TypeContainer::Populate): Update to define all enums and events
16846 (Events): New property for the events arraylist we hold. Shouldn't we move to using
16847 readonly fields for all these cases ?
16849 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
16851 * class.cs (Property): Revamp to use the convention of making fields readonly.
16852 Accordingly modify code elsewhere.
16854 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
16855 the Define method of the Property class.
16857 * class.cs : Clean up applied patch and update references to variables etc. Fix
16859 (TypeContainer::Populate): Update to define all the properties we have. Also
16860 define all enumerations.
16862 * enum.cs (Define): Implement.
16864 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
16866 * cs-parser.jay (overloadable_operator): The semantic value is an
16867 enum of the Operator class.
16868 (operator_declarator): Implement actions.
16869 (operator_declaration): Implement.
16871 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
16872 validity of definitions.
16873 (Operator::CheckBinaryOperator): Static method to check for binary operators
16874 (TypeContainer::AddOperator): New method to add an operator to a type.
16876 * cs-parser.jay (indexer_declaration): Added line to actually call the
16877 AddIndexer method so it gets added ;-)
16879 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
16880 already taken care of by the MS compiler ?
16882 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16884 * class.cs (Operator): New class for operator declarations.
16885 (Operator::OpType): Enum for the various operators.
16887 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16889 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
16890 ostensibly handle this in semantic analysis.
16892 * cs-parser.jay (general_catch_clause): Comment out
16893 (specific_catch_clauses, specific_catch_clause): Ditto.
16894 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
16895 (catch_args, opt_catch_args): New productions.
16896 (catch_clause): Rewrite to use the new productions above
16897 (catch_clauses): Modify accordingly.
16898 (opt_catch_clauses): New production to use in try_statement
16899 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
16900 and re-write the code in the actions to extract the specific and
16901 general catch clauses by being a little smart ;-)
16903 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
16904 Hooray, try and catch statements parse fine !
16906 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16908 * statement.cs (Block::GetVariableType): Fix logic to extract the type
16909 string from the hashtable of variables.
16911 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
16912 I end up making that mistake ;-)
16913 (catch_clauses): Fixed gross error which made Key and Value of the
16914 DictionaryEntry the same : $1 !!
16916 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16918 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
16920 * cs-parser.jay (event_declaration): Correct to remove the semicolon
16921 when the add and remove accessors are specified.
16923 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16925 * cs-parser.jay (IndexerDeclaration): New helper class to hold
16926 information about indexer_declarator.
16927 (indexer_declarator): Implement actions.
16928 (parsing_indexer): New local boolean used to keep track of whether
16929 we are parsing indexers or properties. This is necessary because
16930 implicit_parameters come into picture even for the get accessor in the
16931 case of an indexer.
16932 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
16934 * class.cs (Indexer): New class for indexer declarations.
16935 (TypeContainer::AddIndexer): New method to add an indexer to a type.
16936 (TypeContainer::indexers): New member to hold list of indexers for the
16939 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16941 * cs-parser.jay (add_accessor_declaration): Implement action.
16942 (remove_accessor_declaration): Implement action.
16943 (event_accessors_declaration): Implement
16944 (variable_declarators): swap statements for first rule - trivial.
16946 * class.cs (Event): New class to hold information about event
16948 (TypeContainer::AddEvent): New method to add an event to a type
16949 (TypeContainer::events): New member to hold list of events.
16951 * cs-parser.jay (event_declaration): Implement actions.
16953 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16955 * cs-parser.jay (dim_separators): Implement. Make it a string
16956 concatenating all the commas together, just as they appear.
16957 (opt_dim_separators): Modify accordingly
16958 (rank_specifiers): Update accordingly. Basically do the same
16959 thing - instead, collect the brackets here.
16960 (opt_rank_sepcifiers): Modify accordingly.
16961 (array_type): Modify to actually return the complete type string
16962 instead of ignoring the rank_specifiers.
16963 (expression_list): Implement to collect the expressions
16964 (variable_initializer): Implement. We make it a list of expressions
16965 essentially so that we can handle the array_initializer case neatly too.
16966 (variable_initializer_list): Implement.
16967 (array_initializer): Make it a list of variable_initializers
16968 (opt_array_initializer): Modify accordingly.
16970 * expression.cs (New::NType): Add enumeration to help us
16971 keep track of whether we have an object/delegate creation
16972 or an array creation.
16973 (New:NewType, New::Rank, New::Indices, New::Initializers): New
16974 members to hold data about array creation.
16975 (New:New): Modify to update NewType
16976 (New:New): New Overloaded contructor for the array creation
16979 * cs-parser.jay (array_creation_expression): Implement to call
16980 the overloaded New constructor.
16982 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
16984 * class.cs (TypeContainer::Constructors): Return member
16985 constructors instead of returning null.
16987 2001-08-26 Miguel de Icaza <miguel@ximian.com>
16989 * typemanager.cs (InitCoreTypes): Initialize the various core
16990 types after we have populated the type manager with the user
16991 defined types (this distinction will be important later while
16992 compiling corlib.dll)
16994 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
16995 on Expression Classification. Now all expressions have a method
16996 `Resolve' and a method `Emit'.
16998 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
16999 generation from working. Also add some temporary debugging
17002 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17004 * codegen.cs: Lots of code generation pieces. This is only the
17005 beginning, will continue tomorrow with more touches of polish. We
17006 handle the fundamentals of if, while, do, for, return. Others are
17007 trickier and I need to start working on invocations soon.
17009 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17012 * codegen.cs (EmitContext): New struct, used during code
17013 emission to keep a context. Most of the code generation will be
17016 * cs-parser.jay: Add embedded blocks to the list of statements of
17017 this block. So code generation proceeds in a top down fashion.
17019 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17021 * statement.cs: Add support for multiple child blocks.
17023 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17025 * codegen.cs (EmitCode): New function, will emit the code for a
17026 Block of code given a TypeContainer and its ILGenerator.
17028 * statement.cs (Block): Standard public readonly optimization.
17029 (Block::Block constructors): Link children.
17030 (Block::Child): Child Linker.
17031 (Block::EmitVariables): Emits IL variable declarations.
17033 * class.cs: Drop support for MethodGroups here, delay until
17035 (Method::): Applied the same simplification that I did before, and
17036 move from Properties to public readonly fields.
17037 (Method::ParameterTypes): Returns the parameter types for the
17038 function, and implements a cache that will be useful later when I
17039 do error checking and the semantic analysis on the methods is
17041 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17042 and made a method, optional argument tells whether this is a class
17043 or a structure to apply the `has-this' bit.
17044 (Method::GetCallingConvention): Implement, returns the calling
17046 (Method::Define): Defines the type, a second pass is performed
17047 later to populate the methods.
17049 (Constructor::ParameterTypes): implement a cache similar to the
17050 one on Method::ParameterTypes, useful later when we do semantic
17053 (TypeContainer::EmitMethod): New method. Emits methods.
17055 * expression.cs: Removed MethodGroup class from here.
17057 * parameter.cs (Parameters::GetCallingConvention): new method.
17059 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17061 * class.cs (TypeContainer::Populate): Drop RootContext from the
17064 (Constructor::CallingConvention): Returns the calling convention.
17065 (Constructor::ParameterTypes): Returns the constructor parameter
17068 (TypeContainer::AddConstructor): Keep track of default constructor
17069 and the default static constructor.
17071 (Constructor::) Another class that starts using `public readonly'
17072 instead of properties.
17074 (Constructor::IsDefault): Whether this is a default constructor.
17076 (Field::) use readonly public fields instead of properties also.
17078 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17079 track of static constructors; If none is used, turn on
17080 BeforeFieldInit in the TypeAttributes.
17082 * cs-parser.jay (opt_argument_list): now the return can be null
17083 for the cases where there are no arguments.
17085 (constructor_declarator): If there is no implicit `base' or
17086 `this', then invoke the default parent constructor.
17088 * modifiers.cs (MethodAttr): New static function maps a set of
17089 modifiers flags into a MethodAttributes enum
17090 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17091 MethodAttr, TypeAttr to represent the various mappings where the
17092 modifiers are used.
17093 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17095 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17097 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17100 * interface.cs (PopulateIndexer): Implemented the code generator
17101 for interface indexers.
17103 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17105 * interface.cs (InterfaceMemberBase): Now we track the new status
17108 (PopulateProperty): Implement property population. Woohoo! Got
17109 Methods and Properties going today.
17111 Removed all the properties for interfaces, and replaced them with
17112 `public readonly' fields.
17114 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17116 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17117 initialize their hashtables/arraylists only when they are needed
17118 instead of doing this always.
17120 * parameter.cs: Handle refs and out parameters.
17122 * cs-parser.jay: Use an ArrayList to construct the arguments
17123 instead of the ParameterCollection, and then cast that to a
17126 * parameter.cs: Drop the use of ParameterCollection and use
17127 instead arrays of Parameters.
17129 (GetParameterInfo): Use the Type, not the Name when resolving
17132 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17134 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17135 and instead use public readonly fields.
17137 * class.cs: Put back walking code for type containers.
17139 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17141 * class.cs (MakeConstant): Code to define constants.
17143 * rootcontext.cs (LookupType): New function. Used to locate types
17146 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17148 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17149 this System.Reflection code is. Kudos to Microsoft
17151 * typemanager.cs: Implement a type cache and avoid loading all
17152 types at boot time. Wrap in LookupType the internals. This made
17153 the compiler so much faster. Wow. I rule!
17155 * driver.cs: Make sure we always load mscorlib first (for
17156 debugging purposes, nothing really important).
17158 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17159 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17161 * rootcontext.cs: Lookup types on their namespace; Lookup types
17162 on namespaces that have been imported using the `using' keyword.
17164 * class.cs (TypeContainer::TypeAttr): Virtualize.
17165 (Class::TypeAttr): Return attributes suitable for this bad boy.
17166 (Struct::TypeAttr): ditto.
17167 Handle nested classes.
17168 (TypeContainer::) Remove all the type visiting code, it is now
17169 replaced with the rootcontext.cs code
17171 * rootcontext.cs (GetClassBases): Added support for structs.
17173 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17175 * interface.cs, statement.cs, class.cs, parameter.cs,
17176 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17177 Drop use of TypeRefs, and use strings instead.
17179 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17183 * class.cs (Struct::Struct): set the SEALED flags after
17184 checking the modifiers.
17185 (TypeContainer::TypeAttr): new property, returns the
17186 TypeAttributes for a class.
17188 * cs-parser.jay (type_list): Oops, list production was creating a
17189 new list of base types.
17191 * rootcontext.cs (StdLib): New property.
17192 (GetInterfaceTypeByName): returns an interface by type name, and
17193 encapsulates error handling here.
17194 (GetInterfaces): simplified.
17195 (ResolveTree): Encapsulated all the tree resolution here.
17196 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17199 * driver.cs: Add support for --nostdlib, to avoid loading the
17200 default assemblies.
17201 (Main): Do not put tree resolution here.
17203 * rootcontext.cs: Beginning of the class resolution.
17205 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17207 * rootcontext.cs: Provide better error reporting.
17209 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17211 * rootcontext.cs (CreateInterface): Handle the case where there
17212 are no parent interfaces.
17214 (CloseTypes): Routine to flush types at the end.
17215 (CreateInterface): Track types.
17216 (GetInterfaces): Returns an array of Types from the list of
17217 defined interfaces.
17219 * typemanager.c (AddUserType): Mechanism to track user types (puts
17220 the type on the global type hash, and allows us to close it at the
17223 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17225 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17226 RecordInterface instead.
17228 * cs-parser.jay: Updated to reflect changes above.
17230 * decl.cs (Definition): Keep track of the TypeBuilder type that
17231 represents this type here. Not sure we will use it in the long
17232 run, but wont hurt for now.
17234 * driver.cs: Smaller changes to accomodate the new code.
17236 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17239 * rootcontext.cs (CreateInterface): New method, used to create
17240 the System.TypeBuilder type for interfaces.
17241 (ResolveInterfaces): new entry point to resolve the interface
17243 (CodeGen): Property, used to keep track of the code generator.
17245 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17247 * cs-parser.jay: Add a second production for delegate_declaration
17250 (enum_body): Put an opt_comma here instead of putting it on
17251 enum_body or enum_member_declarations so we can handle trailing
17252 commas on enumeration members. Gets rid of a shift/reduce.
17254 (type_list): Need a COMMA in the middle.
17256 (indexer_declaration): Tell tokenizer to recognize get/set
17258 * Remove old targets.
17260 * Re-add the parser target.
17262 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17264 * cs-parser.jay: Add precendence rules for a number of operators
17265 ot reduce the number of shift/reduce conflicts in the grammar.
17267 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17269 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17272 Get rid of old crufty code.
17274 * rootcontext.cs: Use this to keep track of the parsed
17275 representation and the defined types available to the program.
17277 * gen-treedump.cs: adjust for new convention.
17279 * type.cs: Split out the type manager, and the assembly builder
17282 * typemanager.cs: the type manager will live here now.
17284 * cil-codegen.cs: And the code generator here.
17286 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17288 * makefile: Fixed up for easy making.
17290 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17292 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17295 (unary_expression): Expand pre_increment_expression and
17296 post_decrement_expression to reduce a shift/reduce.
17298 2001-07-11 Simon Cozens
17300 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17302 Improve allow_keyword_as_indent name.
17304 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17306 * Adjustments for Beta2.
17308 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17310 * decl.cs: Added `Define' abstract method.
17311 (InTransit): new property, used to catch recursive definitions.
17313 * interface.cs: Implement `Define'.
17315 * modifiers.cs: Map Modifiers.constants to
17316 System.Reflection.TypeAttribute flags.
17318 * class.cs: Keep track of types and user-defined types.
17319 (BuilderInit): New method for creating an assembly
17320 (ResolveType): New function to launch the resolution process, only
17321 used by interfaces for now.
17323 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17324 that are inserted into the name space.
17326 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17328 * ARGH. I have screwed up my tree so many times due to the use of
17329 rsync rather than using CVS. Going to fix this at once.
17331 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17334 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17336 * Experiment successful: Use System.Type rather that our own
17339 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17341 * cs-parser.jay: Removed nsAliases from here.
17343 Use new namespaces, handle `using XXX;'
17345 * namespace.cs: Reimplemented namespace handling, use a recursive
17346 definition of the class. Now we can keep track of using clauses
17347 and catch invalid using clauses.
17349 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17351 * gen-treedump.cs: Adapted for all the renaming.
17353 * expression.cs (Expression): this class now has a Type property
17354 which returns an expression Type.
17356 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17357 `Type', as this has a different meaning now in the base
17359 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17361 * interface.cs, class.cs: Removed from all the sources the
17362 references to signature computation, as we can not do method
17363 signature computation during the parsing time, as we are not
17364 trying to solve at that point distinguishing:
17368 void a (NS.Blah x) {}
17371 Which depending on the context might be valid or not, as we do not
17372 know if Blah is the same thing as NS.Blah at that point.
17374 * Redid everything so the code uses TypeRefs now instead of
17375 Types. TypeRefs are just temporary type placeholders, that need
17376 to be resolved. They initially have a pointer to a string and the
17377 current scope in which they are used. This is used later by the
17378 compiler to resolve the reference to an actual Type.
17380 * DeclSpace is no longer a CIR.Type, and neither are
17381 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17382 are all DeclSpaces, but no Types.
17384 * type.cs (TypeRefManager): This implements the TypeRef manager,
17385 which keeps track of all the types that need to be resolved after
17386 the parsing has finished.
17388 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17390 * ARGH. We are going to have to store `foreach' as a class rather
17391 than resolving it, as we need to verify error 1579 after name
17392 resolution. *OR* we could keep a flag that says `This request to
17393 IEnumerator comes from a foreach statement' which we can then use
17394 to generate the error.
17396 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17398 * class.cs (TypeContainer.AddMethod): we now add methods to the
17399 MethodGroup instead of the method hashtable.
17401 * expression.cs: Add MethodGroup abstraction, which gets us one
17402 step closer to the specification in the way we handle method
17405 * cs-parser.jay (primary_expression): qualified_identifier now
17406 tried to match up an identifier to a local variable reference or
17407 to a parameter reference.
17409 current_local_parameters is now a parser global variable that
17410 points to the current parameters for the block, used during name
17413 (property_declaration): Now creates an implicit `value' argument to
17416 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17418 * parameter.cs: Do not use `param' arguments as part of the
17419 signature, per the spec.
17421 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17423 * decl.cs: Base class for classes, structs and interfaces. This
17424 is the "Declaration Space"
17426 * cs-parser.jay: Use CheckDef for checking declaration errors
17427 instead of having one on each function.
17429 * class.cs: Factor out some code for handling error handling in
17430 accordance to the "Declarations" section in the "Basic Concepts"
17431 chapter in the ECMA C# spec.
17433 * interface.cs: Make all interface member classes derive from
17434 InterfaceMemberBase.
17436 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17438 * Many things: all interfaces are parsed and generated in
17439 gen-treedump. Support for member variables, constructors,
17440 destructors, properties, constants is there.
17442 Beginning of the IL backend, but very little done, just there for
17445 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17447 * cs-parser.jay: Fix labeled statement.
17449 * cs-tokenizer.cs (escape): Escape " and ' always.
17450 ref_line, ref_name: keep track of the line/filename as instructed
17451 by #line by the compiler.
17454 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17456 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17457 to match the values in System.CodeDOM.
17459 Divid renamed to Divide.
17461 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17463 (Statements.set): remove.
17465 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17468 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17469 falseStatements always have valid values.
17471 * cs-parser.jay: Use System.CodeDOM now.