1 2004-12-06 Raja R Harinath <rharinath@novell.com>
3 Fix crash on cs0657-17.cs.
4 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
5 Use RootContext.Tree.Types, not 'new RootTypes ()'.
6 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7 the case where the NamespaceEntry gets overwritten.
9 2004-12-06 Marek Safar <marek.safar@seznam.cz>
12 * ecore.cs (ResolveBoolean): Tiny refactoring.
14 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15 of right expression resolving when left is false constant and
16 operator is LogicalAnd OR true constant and operator is LogicalOr.
18 * statement.cs (ResolveUnreachable): Always reports warning.
20 2004-12-05 Miguel de Icaza <miguel@ximian.com>
22 * class.cs: Distinguish between 1721 and 1722 (just a little help
25 2004-12-03 Miguel de Icaza <miguel@ximian.com>
27 * delegate.cs: Only allow this on new versions of the language.
29 2004-12-02 Duncan Mak <duncan@ximian.com>
31 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
33 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
34 here as a static method. Take an additional bool out parameter
35 `must_do_cs1540_check' for signaling to InstanceResolve.
36 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
37 member field from PropertyExpr class and made it an argument of
39 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
40 check for MarshalByRefObject, and report CS0122 instead of CS1540.
41 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
42 and `remove_accessor' as well as InstanceResolve: report CS0122
47 2004-12-03 Raja R Harinath <rharinath@novell.com>
49 Fix test-327.cs, test-328.cs, and put in early infrastructure
50 for eventually fixing #52697.
51 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
52 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
54 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
55 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
56 (VerifyUsing, error246): Update.
57 * rootcontext.cs (RootContext.NamespaceLookup): Just use
58 'NamespaceEntry.LookupNamespaceOrType'.
60 2004-12-03 Martin Baulig <martin@ximian.com>
62 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
63 method as our child, call AnonymousMethod.Compatible() on it.
65 2004-12-03 Raja R Harinath <rharinath@novell.com>
67 Disable XML documentation support in 'basic' profile.
68 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
69 Redirect XmlElement to System.Object.
70 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
71 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
72 * mcs.exe.sources: Add doc-bootstrap.cs.
73 * doc-bootstrap.cs: New file. Contains empty stub implementation
76 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
78 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
81 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
83 * delegate.cs: Add checks for subtypes in paramaters and return values
84 in VerifyMethod () to add support for Covariance/Contravariance
87 2004-12-02 Miguel de Icaza <miguel@ximian.com>
89 * report.cs: Remove extra closing parenthesis.
91 * convert.cs (Error_CannotImplicitConversion): If the name of the
92 types are the same, provide some extra information.
94 * class.cs (FieldBase): Use an unused bit field from the field to
95 encode the `has_offset' property from the FieldMember. This saves
96 a couple of Ks on bootstrap compilation.
98 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
99 method as our child, return the AnonymousMethod resolved
102 * expression.cs (New.DoResolve): Allow return values from
103 NewDelegate to also include AnonymousMethods.
107 2004-12-02 Marek Safar <marek.safar@seznam.cz>
110 * attribute.cs (Resolve): Improved implementation of params
113 * support.cs (ParameterData): Add HasParams to be faster.
115 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
117 all things are for /doc support:
119 * doc.cs: new file that supports XML documentation generation.
120 * mcs.exe.sources: added doc.cs.
122 Handle /doc command line option.
123 Report error 2006 instead of 5 for missing file name for /doc.
124 Generate XML documentation when required, after type resolution.
126 Added support for picking up documentation (/// and /** ... */),
127 including a new XmlCommentState enumeration.
129 Added lines to fill Documentation element for field, constant,
130 property, indexer, method, constructor, destructor, operator, event
131 and class, struct, interface, delegate, enum.
132 Added lines to warn incorrect comment.
134 Added Documentation field (passed only when /doc was specified).
136 Added DocComment, DocCommentHeader, GenerateDocComment() and
137 OnGenerateDocComment() and some supporting private members for
138 /doc feature to MemberCore.
140 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
142 Added overriden DocCommentHeader.
144 Added overriden DocCommentHeader and GenerateDocComment().
146 2004-12-01 Miguel de Icaza <miguel@ximian.com>
148 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
149 unwrapping the enumeration values, chain to
150 DoConstantNumericPromotions again, so we can promote things to the
151 fundamental types (takes care of enums that are bytes, sbytes).
155 2004-12-01 Raja R Harinath <rharinath@novell.com>
157 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
158 Fix long-standing bug in type-lookup. Use FindType instead of
159 LookupType when ec.ResolvingTypeTree.
160 (Attribute.ResolveType, Attribute.Resolve)
161 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
163 (Attributes.Search): Remove internal version. Update.
164 (Attributes.SearchMulti): Update.
165 (Attributes.GetClsCompliantAttribute): Remove.
166 (Attributes.GetIndexerNameAttribute): Remove.
167 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
168 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
169 * class.cs (Indexer.Define): Likewise.
171 2004-12-01 Marek Safar <marek.safar@seznam.cz>
174 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
175 MarshallByReference members access.
177 * expression.cs: Use CheckMarshallByRefAccess;
178 Better error CS0197 message.
180 * report.cs: Print whole related error message.
182 2004-11-30 Raja R Harinath <rharinath@novell.com>
184 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
185 the current directory to help debugging.
187 2004-11-29 Marek Safar <marek.safar@seznam.cz>
189 * class (GetClassBases): Better error 60 report.
190 (EventProperty): Disabled warning 67 detection.
192 2004-11-29 Marek Safar <marek.safar@seznam.cz>
195 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
197 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
200 2004-11-29 Marek Safar <marek.safar@seznam.cz>
203 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
205 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
207 2004-11-26 Miguel de Icaza <miguel@ximian.com>
209 * attribute.cs (Attribute.Resolve): Refine error reporting and
210 report a cs0117 if the identifier does not exist, to distinguish
211 from 0617 which is a miss-use of the actual identifier.
213 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
214 between cs0070 and cs0079.
216 * class.cs (MemberBase.DoDefine): When reporting a wrong
217 accessibility level, we use MethodCore to compare instead of
218 Method (this was a regression in some refactoring effort).
220 So now we correctly report cs0056 again.
222 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
223 testing the target_type (which was known to be object_type) and
224 not the source type (which is anonymous_method).
226 Fixed reporting of error cs1660.
228 * expression.cs (UserCast.Source): Expose the underlying cast.
230 * statement.cs (Switch.SwitchGoverningType): Sort the list of
231 allowed types to find a match to int32 first (most common).
233 In addition, it ignores any ImplicitUserConversions that did an
234 internal implicit conversion (as the switch statement allows only
235 one integral conversion to exist).
237 * class.cs (PartialContainer.Create): rename `name' to
238 `member_name' for clarity. Then replace the string calls with a
239 call to MemberName.GetPartialName, as now using
240 MemberName.ToString is an error (this is due to the side effects
241 it had, that were fixed in the past).
243 This will restore the error reporting on a number of partial class
244 errors that were missusing this (and getting an exception as a
245 results, which is now just a plain textual warning, because
246 yyparse debug output would crash otherwise).
248 2004-11-26 Raja R Harinath <rharinath@novell.com>
250 * Makefile (PROGRAM_INSTALL_DIR): Remove.
252 2004-11-25 Ben Maurer <bmaurer@ximian.com>
254 * rootcontext.cs (LookupType): Make sure to cache lookups that
255 don't give us a negative result. This saves about 5% of corlib
258 2004-11-25 Miguel de Icaza <miguel@ximian.com>
260 * report.cs (AbstractMessage.Print): messages are sent to stderr
262 * class.cs (TypeContainer.GetClassBases): It is an error to have a
263 non-interface in the list of interfaces (at this point, either
264 parent was properly set, or a base class is being listed in the
267 This flags error 1722, and resolves the crash from bug 69259.
269 2004-11-25 Ben Maurer <bmaurer@ximian.com>
271 * statement.cs (Using.EmitExpressionFinally): make this work right
272 for valuetypes. Fixes 69926.
274 2004-11-25 Miguel de Icaza <miguel@ximian.com>
276 * const.cs (Const.ChangeType): Cope with the "0 literal can be
277 converted to an enum" here, before we try to change the underlying
278 type. This code exists, but it is a different code path than the
279 one used while encoding constants.
281 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
282 old bug: when converting from the null literal to a pointer,
283 return an EmptyCast, not the NullLiteral.
285 This fixes #69921, the recent null_type changes probably made this
288 (ImplicitReferenceConversionExists): In addition, resynchronized
289 the code here, so it matches the same code in
290 ImplicitReferenceConversionExists for the `from any class-type S
291 to any interface-type T'.
294 2004-11-25 Marek Safar <marek.safar@seznam.cz>
296 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
298 2004-11-24 Miguel de Icaza <miguel@ximian.com>
300 * cs-parser.jay: Use verbosity accordingly.
302 2004-11-24 Marek Safar <marek.safar@seznam.cz>
304 * expression.cs (Unary.ResolveOperator): Do not report warning;
305 AddressOf reads from variable.
307 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
309 2004-11-24 Marek Safar <marek.safar@seznam.cz>
313 * attribute.cs (Attributable): Removed CheckTargets.
314 (Attributes.Emit): Explicit attribute targets are tested here.
316 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
317 not enabled for interfaces.
319 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
320 (GetAssemblyName): Ouch next bug there.
322 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
324 * expression.cs: Error 275 added.
326 2004-11-23 Marek Safar <marek.safar@seznam.cz>
328 Fix bug #69177 (Implemented decimal constant support)
330 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
331 (BinaryFold): Add DecimalConstant.
333 * const.cs (Define): Decimal constant
335 (ChangeType): Add decimal type handling.
336 (LookupConstantValue): Don't set value for decimal type but
337 emit DecimalConstantAttribute. Needed for constant optimization.
339 * constant.cs (ToDecimal): New method.
340 (ConvertToDecimal): New method.
341 (IntConstant): Implemented ConvertToDecimal.
342 (DecimalConstant.Emit): Emit optimized version for decimals in
345 * expression.cs (ResolveOperator): Changed order of constant
346 reduction to work correctly with native types which have
347 overloaded operators.
348 (ResolveMemberAccess): Extract constant value from attribute
351 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
353 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
354 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
355 (ChangeType): Decimal is special.
356 (TypeToCoreType): Add decimal type.
358 2004-11-22 Marek Safar <marek.safar@seznam.cz>
360 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
363 2004-11-22 Marek Safar <marek.safar@seznam.cz>
365 * class.cs (EventField.ApplyAttributeBuilder): Fix error
368 2004-11-19 Marek Safar <marek.safar@seznam.cz>
370 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
372 * pending.cs (PendingImplementation): Grab only interfaces.
374 2004-11-19 Marek Safar <marek.safar@seznam.cz>
376 * statement.cs (ForeachHelperMethods): Add location member and
379 2004-11-19 Raja R Harinath <rharinath@novell.com>
381 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
382 automatically handled by executable.make.
383 (PROGRAM): Make profile-specific.
385 2004-11-18 Marek Safar <marek.safar@seznam.cz>
387 * expression.cs (DoResolveBase): Fixed wrong warning for out
390 2004-11-18 Martin Baulig <martin@ximian.com>
392 Merged latest changes into gmcs. Please keep this comment in
393 here, it makes it easier for me to see what changed in MCS since
394 the last time I merged.
396 2004-11-17 Raja R Harinath <rharinath@novell.com>
398 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
399 (TypeHandle.GetMemberCache): New.
400 (TypeHandle.TypeHandle): Update.
401 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
402 (TypeManager.LookupParentInterfacesCache):
403 Rename from LookupInterfaceCache. Optimize slightly.
404 (TypeManager.MemberLookup_FindMembers): Update.
405 * decl.cs (MemberCache.MemberCache): Set Container to null in the
407 (AddCacheContents): Rename from AddHashtable.
408 * class.cs (TypeContainer.parent_container): Remove.
409 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
410 (TypeContainer.DoDefineMembers): Don't initialize it.
411 Update to name changes.
413 2004-11-17 Miguel de Icaza <miguel@ximian.com>
415 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
416 that factors the code to check access modifiers on override.
418 (PropertyBase): Use the code here.
420 Patch from Lluis S'anchez, fixes bug #69361.
422 2004-11-15 Miguel de Icaza <miguel@ximian.com>
424 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
425 routine that is used to report the use of a captured variable
426 whose address has been taken.
428 There are two checks: one when variables are being captured and
429 the other check is when the address of a variable is taken.
431 (because an anonymous methods might be resolved before *or* after
432 the address has been taken) and
434 * expression.cs (Conditional.DoResolve): Remove the special
435 casing that Martin added to trueExpr and falseExpr being both
436 NullLiteral. We get the right behavior now just by introducing
437 the null_type into the compiler.
439 * convert.cs (ExplicitConversion): Change the code to use
440 null_type instead of testing `expr is NullLiteral'.
441 (ImplicitConversionStandard): use null_type too.
442 (ImplicitReferenceConversionExists): use null_type too.
443 (ImplicitReferenceConversion): use null_type too.
445 * literal.cs: The type of `NullLiteral' is now null_type instead
447 (Resolve): Set the type here.
449 * typemanager.cs: Introduce null_type.
451 2004-11-17 Martin Baulig <martin@ximian.com>
453 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
454 direction, like FindMembers() does. Fixes #69546, testcase is in
457 2004-11-16 Martin Baulig <martin@ximian.com>
459 This is based on a patch from Marek Safar, see bug #69082.
460 Fixes bugs #63705 and #67130.
462 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
463 method; create a MemberCache for an interface type and cache the
466 * decl.cs (IMemberContainer.ParentContainer): Removed.
467 (IMemberContainer.ParentCache): New property.
468 (MemberCache.SetupCacheForInterface): Removed.
469 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
470 to create a cache for an interface's "parent".
472 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
475 2004-11-16 Martin Baulig <martin@ximian.com>
477 Merged back from gmcs; these changes already went into gmcs a
481 (TypeManager.AddUserType): Removed the `ifaces' argument.
482 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
484 (TypeManager.AddUserInterface): Removed.
485 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
487 (TypeManager.GetInterfaces): Likewise.
488 (TypeManager.GetExplicitInterfaces): Likewise.
490 * ecore.cs (TypeExpr.GetInterfaces): Removed.
492 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
493 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
495 2004-11-14 Ben Maurer <bmaurer@ximian.com>
497 * statement.cs: Avoid adding bools to a hashtable.
499 2004-11-07 Miguel de Icaza <miguel@ximian.com>
501 * expression.cs (Invocation.OverloadResolve): Flag error if we are
502 calling an unsafe method from a safe location.
504 2004-11-06 Marek Safar <marek.safar@seznam.cz>
507 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
509 2004-11-06 Miguel de Icaza <miguel@ximian.com>
511 * namespace.cs (VerifyUsing): use GetPartialName instead of
514 2004-11-05 Miguel de Icaza <miguel@ximian.com>
516 * statement.cs (Return.Resolve): Fix regression in typo: if
517 `in_exc', we have to request a NeedReturnLabel, this was a typo
518 introduced in the anonymous method check-in. Fixes #69131.
520 * Indexers were using the ShortName when defining themselves,
521 causing a regression in the compiler bootstrap when applying the
522 patch from 2004-11-02 (first part), now they use their full name
525 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
527 * driver.cs: Strip the path from the names of embedded resources. Fixes
530 2004-11-04 Raja R Harinath <rharinath@novell.com>
532 Fix error message regression: cs0104-2.cs.
533 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
534 (AliasEntry.Resolve): Update.
535 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
537 (RootContext.LookupType): Update.
539 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
541 * cs-parser.jay: Add support for handling accessor modifiers
542 * class: Add support port accessor modifiers and error checking,
543 define PropertyMethod.Define as virtual (not abstract anymore)
544 * ecore.cs: Add checking for proeprties access with access modifiers
545 * iterators.cs: Modify Accessor constructor call based in the modified
547 2004-11-02 Ben Maurer <bmaurer@ximian.com>
549 * expression.cs (StringConcat): Handle being called twice,
550 as when we have a concat in a field init with more than two
553 2004-11-02 Miguel de Icaza <miguel@ximian.com>
555 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
556 special case explicit implementations, we should always produce
557 the .property or .event declaration.
559 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
560 since it will not return correct data if people use this
561 unresolved in the presence of using statements (see test-313).
563 * class.cs (MethodData.Define): If we are an explicit interface
564 implementation, set the method name to the full name of the
565 interface plus the name of the method.
567 Notice that using the method.MethodName.GetFullName() does not
568 work, as it will only contain the name as declared on the source
569 file (it can be a shorthand in the presence of using statements)
570 and not the fully qualifed type name, for example:
574 class D : ICloneable {
575 object ICloneable.Clone () {
579 Would produce a method called `ICloneable.Clone' instead of
580 `System.ICloneable.Clone'.
582 * namespace.cs (Alias.Resolve): Use GetPartialName.
584 2004-11-01 Marek Safar <marek.safar@seznam.cz>
586 * cs-parser.jay: Add error 1055 report.
588 2004-11-01 Miguel de Icaza <miguel@ximian.com>
590 * assign.cs (Assign.DoResolve): Only do the transform of
591 assignment into a New if the types are compatible, if not, fall
592 through and let the implicit code deal with the errors and with
593 the necessary conversions.
595 2004-11-01 Marek Safar <marek.safar@seznam.cz>
597 * cs-parser.jay: Add error 1031 report.
599 * cs-tokenizer.cs: Add location for error 1038.
601 2004-10-31 Marek Safar <marek.safar@seznam.cz>
603 * cs-parser.jay: Add error 1016 report.
605 2004-10-31 Marek Safar <marek.safar@seznam.cz>
607 * cs-parser.jay: Add errors 1575,1611 report.
609 2004-10-31 Marek Safar <marek.safar@seznam.cz>
611 * cs-parser.jay: Add error 1001 report.
613 2004-10-31 Marek Safar <marek.safar@seznam.cz>
616 * attribute.cs (GetMarshal): Add method argument for
617 caller identification.
619 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
620 agument for GetMarshal and RuntimeMissingSupport.
622 2004-10-31 Marek Safar <marek.safar@seznam.cz>
624 * attribute.cs (ExtractSecurityPermissionSet): Removed
625 TypeManager.code_access_permission_type.
627 * typemanager.cs: Removed TypeManager.code_access_permission_type.
629 2004-10-27 Miguel de Icaza <miguel@ximian.com>
631 * expression.cs (LocalVariableReference.DoResolveLValue): Check
632 for obsolete use of a variable here. Fixes regression on errors
633 cs0619-25 and cs0619-26.
635 2004-10-27 Marek Safar <marek.safar@seznam.cz>
637 Fix #62358, implemented security attribute encoding.
639 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
640 Tests permitted SecurityAction for assembly or other types.
641 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
642 data from SecurityPermissionAttribute to PermisionSet class.
644 * class.cs (ApplyAttributeBuilder): Added special handling
645 for System.Security.Permissions.SecurityAttribute based types.
647 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
648 special handling for System.Security.Permissions.SecurityAttribute
651 * enum.cs (ApplyAttributeBuilder): Added special handling
652 for System.Security.Permissions.SecurityAttribute based types.
654 * parameter.cs (ApplyAttributeBuilder): Added special handling
655 for System.Security.Permissions.SecurityAttribute based types.
657 * rootcontext.cs: Next 2 core types.
659 * typemanager.cs (TypeManager.security_permission_attr_type):
660 Built in type for the SecurityPermission Attribute.
661 (code_access_permission_type): Build in type.
663 2004-10-17 Miguel de Icaza <miguel@ximian.com>
665 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
666 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
667 all of this information into
668 EmitContext.EmitCapturedVariableInstance.
670 * codegen.cs (EmitCapturedVariableInstance): move here the
671 funcionality of emitting an ldarg.0 in the presence of a
672 remapping. This centralizes the instance emit code.
674 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
675 then emit a load of this: it means that we have reached the
676 topmost ScopeInfo: the one that contains the pointer to the
677 instance of the class hosting the anonymous method.
679 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
680 captures to the topmost CaptureContext.
682 2004-10-12 Miguel de Icaza <miguel@ximian.com>
684 * expression.cs (LocalVariableReference): Move the knowledge about
685 the iterators into codegen's EmitCapturedVariableInstance.
687 2004-10-11 Miguel de Icaza <miguel@ximian.com>
689 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
690 all code paths return a value from an anonymous method (it is the
691 same as the 161 error, but for anonymous methods).
693 2004-10-08 Miguel de Icaza <miguel@ximian.com>
695 The introduction of anonymous methods in the compiler changed
696 various ways of doing things in the compiler. The most
697 significant one is the hard split between the resolution phase
698 and the emission phases of the compiler.
700 For instance, routines that referenced local variables no
701 longer can safely create temporary variables during the
702 resolution phase: they must do so from the emission phase,
703 since the variable might have been "captured", hence access to
704 it can not be done with the local-variable operations from the runtime.
708 (Block.Flags): New flag `IsTopLevel' to indicate that this block
711 (ToplevelBlock): A new kind of Block, these are the blocks that
712 are created by the parser for all toplevel method bodies. These
713 include methods, accessors and anonymous methods.
715 These contain some extra information not found in regular blocks:
716 A pointer to an optional CaptureContext (for tracking captured
717 local variables and parameters). A pointer to the parent
720 (Return.Resolve): Catch missmatches when returning a value from an
721 anonymous method (error 1662).
722 Invoke NeedReturnLabel from the Resolve phase instead of the emit
725 (Break.Resolve): ditto.
727 (SwitchLabel): instead of defining the labels during the
728 resolution phase, we now turned the public ILLabel and ILLabelCode
729 labels into methods called GetILLabelCode() and GetILLabel() that
730 only define the label during the Emit phase.
732 (GotoCase): Track the SwitchLabel instead of the computed label
733 (its contained therein). Emit the code by using
734 SwitchLabel.GetILLabelCode ().
736 (LocalInfo.Flags.Captured): A new flag has been introduce to track
737 whether the Local has been captured or not.
739 (LocalInfo.IsCaptured): New property, used to tell whether the
740 local has been captured.
742 * anonymous.cs: Vastly updated to contain the anonymous method
745 The main classes here are: CaptureContext which tracks any
746 captured information for a toplevel block and ScopeInfo used to
747 track the activation frames for various local variables.
749 Each toplevel block has an optional capture context associated
750 with it. When a method contains an anonymous method both the
751 toplevel method and the anonymous method will create a capture
752 context. When variables or parameters are captured, they are
753 recorded on the CaptureContext that owns them, for example:
757 MyDelegate d = delegate {
762 Here `a' will be recorded as captured on the toplevel
763 CapturedContext, the inner captured context will not have anything
764 (it will only have data if local variables or parameters from it
765 are captured in a nested anonymous method.
767 The ScopeInfo is used to track the activation frames for local
768 variables, for example:
770 for (int i = 0; i < 10; i++)
771 for (int j = 0; j < 10; j++){
772 MyDelegate d = delegate {
777 At runtime this captures a single captured variable `i', but it
778 captures 10 different versions of the variable `j'. The variable
779 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
782 The toplevel ScopeInfo will also track information like the `this'
783 pointer if instance variables were referenced (this is necessary
784 as the anonymous method lives inside a nested class in the host
787 (AnonymousMethod): Expanded to track the Toplevel, implement
788 `AnonymousMethod.Compatible' to tell whether an anonymous method
789 can be converted to a target delegate type.
791 The routine now also produces the anonymous method content
793 (AnonymousDelegate): A helper class that derives from
794 DelegateCreation, this is used to generate the code necessary to
795 produce the delegate for the anonymous method that was created.
797 * assign.cs: API adjustments for new changes in
798 Convert.ImplicitStandardConversionExists.
800 * class.cs: Adjustments to cope with the fact that now toplevel
801 blocks are of type `ToplevelBlock'.
803 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
804 insteda of standard blocks.
806 Flag errors if params arguments are passed to anonymous methods.
808 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
809 `CurrentAnonymousMethod' which points to the current Anonymous
810 Method. The variable points to the AnonymousMethod class that
811 holds the code being compiled. It is set in the new EmitContext
812 created for the anonymous method.
814 (EmitContext.Phase): Introduce a variable and an enumeration to
815 assist in enforcing some rules about when and where we are allowed
816 to invoke certain methods (EmitContext.NeedsReturnLabel is the
817 only one that enfonces this right now).
819 (EmitContext.HaveCaptureInfo): new helper method that returns
820 whether we have a CapturedContext initialized.
822 (EmitContext.CaptureVariable): New method used to register that a
823 LocalInfo must be flagged for capturing.
825 (EmitContext.CapturedParameter): New method used to register that a
826 parameters must be flagged for capturing.
828 (EmitContext.CapturedField): New method used to register that a
829 field must be flagged for capturing.
831 (EmitContext.HaveCapturedVariables,
832 EmitContext.HaveCapturedFields): Return whether there are captured
835 (EmitContext.EmitMethodHostInstance): This is used to emit the
836 instance for the anonymous method. The instance might be null
837 (static methods), this (for anonymous methods that capture nothing
838 and happen to live side-by-side with the current method body) or a
839 more complicated expression if the method has a CaptureContext.
841 (EmitContext.EmitTopBlock): Routine that drives the emission of
842 code: it will first resolve the top block, then emit any metadata
843 and then emit the code. The split is done so that we can extract
844 any anonymous methods and flag any captured variables/parameters.
846 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
847 during this phase, the ILGenerator should not be used as labels
848 and local variables declared here might not be accessible to any
849 code that is part of an anonymous method.
851 Exceptions to this include the temporary variables that are
852 created by some statements internally for holding temporary
855 (EmitContext.EmitMeta): New routine, in charge of emitting all the
858 (EmitContext.TemporaryReturn): This method is typically called
859 from the Emit phase, and its the only place where we allow the
860 ReturnLabel to be defined other than the EmitMeta. The reason is
861 that otherwise we would have to duplicate a lot of logic in the
862 Resolve phases of various methods that today is on the Emit
865 (EmitContext.NeedReturnLabel): This no longer creates the label,
866 as the ILGenerator is not valid during the resolve phase.
868 (EmitContext.EmitThis): Extended the knowledge in this class to
869 work in anonymous methods in addition to iterators.
871 (EmitContext.EmitCapturedVariableInstance): This emits whatever
872 code is necessary on the stack to access the instance to a local
873 variable (the variable will be accessed as a field).
875 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
876 EmitContext.EmitAddressOfParameter): Routines to support
877 parameters (not completed at this point).
879 Removals: Removed RemapLocal and RemapLocalLValue. We probably
880 will also remove the parameters.
882 * convert.cs (Convert): Define a `ConstantEC' which points to a
883 null. This is just to prefity some code that uses
884 ImplicitStandardConversion code and do not have an EmitContext
887 The idea is to flag explicitly that at that point in time, it is
888 known that the conversion will not trigger the delegate checking
889 code in implicit conversions (which requires a valid
892 Everywhere: pass new EmitContext parameter since
893 ImplicitStandardConversionExists now requires it to check for
894 anonymous method conversions.
896 (Convert.ImplicitStandardConversionExists): If the type of an
897 expression is the anonymous_method_type, and the type is a
898 delegate, we invoke the AnonymousMethod.Compatible method to check
899 whether an implicit conversion is possible.
901 (Convert.ImplicitConversionStandard): Only do implicit method
902 group conversions if the language level is not ISO_1.
904 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
905 MethodInfo for the Invoke method. used by Delegate and
908 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
909 method conversions if the target type is a delegate.
911 Removed extra debugging nops.
913 (LocalVariableReference): Turn the `local_info' into a public
916 Add `prepared' field, the same hack used for FieldExprs to cope
917 with composed assignments, as Local variables do not necessarily
918 operate purely on the stack as they used to: they can be captured
921 Add `temp' for a temporary result, like fields.
923 Refactor DoResolve and DoResolveLValue into DoResolveBase.
925 It now copes with Local variables that are captured and emits the
926 proper instance variable to load it from a field in the captured
929 (ParameterReference.DoResolveBase): During the resolve phase,
930 capture parameters if we are in an anonymous method.
932 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
933 anonymous method, use the EmitContext helper routines to emit the
936 * iterators.cs: Set RemapToProxy to true/false during the
939 * parameters.cs (GetParameterByName): New helper method.
941 * typemanager.cs (anonymous_method_type) a new type that
942 represents an anonyous method. This is always an internal type,
943 used as a fencepost to test against the anonymous-methodness of an
946 2004-10-20 Marek Safar <marek.safar@seznam.cz>
948 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
950 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
952 2004-10-18 Martin Baulig <martin@ximian.com>
954 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
955 `Type' directly, but call ResolveType() on it.
956 (Catch.Resolve): Likewise.
957 (Foreach.Resolve): Likewise.
959 2004-10-18 Martin Baulig <martin@ximian.com>
961 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
962 `Type' directly, but call ResolveType() on it.
963 (Probe.DoResolve): Likewise.
964 (ArrayCreation.LookupType): Likewise.
965 (TypeOf.DoResolve): Likewise.
966 (SizeOf.DoResolve): Likewise.
968 2004-10-18 Martin Baulig <martin@ximian.com>
970 * expression.cs (Invocation.BetterFunction): Put back
971 TypeManager.TypeToCoreType().
973 2004-10-18 Raja R Harinath <rharinath@novell.com>
975 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
978 2004-10-18 Martin Baulig <martin@ximian.com>
980 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
981 `Type' directly, but call ResolveType() on it.
983 2004-10-18 Martin Baulig <martin@ximian.com>
985 * class.cs (FieldMember.Define): Don't access the TypeExpr's
986 `Type' directly, but call ResolveType() on it.
987 (MemberBase.DoDefine): Likewise.
989 * expression.cs (New.DoResolve): Don't access the TypeExpr's
990 `Type' directly, but call ResolveType() on it.
991 (ComposedCast.DoResolveAsTypeStep): Likewise.
993 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
994 `Type' directly, but call ResolveType() on it.
996 2004-10-17 John Luke <john.luke@gmail.com>
998 * class.cs (Operator.GetSignatureForError): use CSharpName
1000 * parameter.cs (Parameter.GetSignatureForError): Returns
1001 correct name even if was not defined.
1003 2004-10-13 Raja R Harinath <rharinath@novell.com>
1006 * class.cs (TypeContainer.EmitContext): New property.
1007 (DefineNestedTypes): Create an emitcontext for each part.
1008 (MethodCore.DoDefineParameters): Use container's emitcontext.
1009 Pass type array to InternalParameters.
1010 (MemberBase.DoDefine): Use container's emitcontext.
1011 (FieldMember.Define): Likewise.
1012 (Event.Define): Likewise.
1013 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1014 Pass type array to InternalParameters.
1015 (SetIndexerMethod.GetParameterInfo): Likewise.
1016 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1017 * delegate.cs (Define): Pass emitcontext to
1018 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1019 array to InternalParameters.
1020 * expression.cs (ParameterReference.DoResolveBase): Pass
1021 emitcontext to GetParameterInfo.
1022 (ComposedCast.DoResolveAsTypeStep): Remove check on
1023 ec.ResolvingTypeTree.
1024 * parameter.cs (Parameter.Resolve): Change argument to
1025 EmitContext. Use ResolveAsTypeTerminal.
1026 (Parameter.GetSignature): Change argument to EmitContext.
1027 (Parameters.ComputeSignature): Likewise.
1028 (Parameters.ComputeParameterTypes): Likewise.
1029 (Parameters.GetParameterInfo): Likewise.
1030 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1031 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1032 * support.cs (InternalParameters..ctor): Remove variant that takes
1034 * typemanager.cs (system_intptr_expr): New.
1035 (InitExpressionTypes): Initialize it.
1037 2004-10-12 Chris Toshok <toshok@ximian.com>
1039 * cs-parser.jay: fix location for try_statement and catch_clause.
1041 2004-10-11 Martin Baulig <martin@ximian.com>
1043 * report.cs: Don't make --fatal abort on warnings, we have
1044 -warnaserror for that.
1046 2004-10-07 Raja R Harinath <rharinath@novell.com>
1048 More DeclSpace.ResolveType avoidance.
1049 * decl.cs (MemberCore.InUnsafe): New property.
1050 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1051 with newly created EmitContext.
1052 (FieldMember.Define): Likewise.
1053 * delegate.cs (Delegate.Define): Likewise.
1054 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1055 only if normal name-lookup fails.
1056 (TypeExpr.DoResolve): Enable error-checking.
1057 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1058 (SizeOf.DoResolve): Likewise.
1059 (ComposedCast.DoResolveAsTypeStep): Likewise.
1060 (StackAlloc.DoResolve): Likewise.
1061 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1062 (Block.Unsafe): New property.
1063 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1064 (Unsafe): Set 'unsafe' flag of contained block.
1065 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1066 (Fixed.Resolve): Likewise.
1067 (Catch.Resolve): Likewise.
1068 (Using.ResolveLocalVariableDecls): Likewise.
1069 (Foreach.Resolve): Likewise.
1071 2004-10-05 John Luke <john.luke@gmail.com>
1073 * cs-parser.jay: add location to error CS0175
1075 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1077 * ecore.cs (Expression.Constantity): Add support for turning null
1080 * const.cs (Const.Define): Allow constants to be reference types
1081 as long as the value is Null.
1083 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1085 * namespace.cs (NamespaceEntry.Using): No matter which warning
1086 level is set, check if this namespace name has already been added.
1088 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1090 * expression.cs: reftype [!=]= null should always use br[true,false].
1093 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1096 * attribute.cs: Enum conversion moved to
1097 GetAttributeArgumentExpression to be applied to the all
1100 2004-10-01 Raja R Harinath <rharinath@novell.com>
1102 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1103 * class.c (TypeContainer.DefineType): Flag error if
1104 base types aren't accessible due to access permissions.
1105 * decl.cs (DeclSpace.ResolveType): Move logic to
1106 Expression.ResolveAsTypeTerminal.
1107 (DeclSpace.ResolveTypeExpr): Thin layer over
1108 Expression.ResolveAsTypeTerminal.
1109 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1110 Refactor code into NestedAccess. Use it.
1111 (DeclSpace.NestedAccess): New.
1112 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1113 argument to silence errors. Check access permissions.
1114 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1115 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1116 (Cast.DoResolve): Likewise.
1117 (New.DoResolve): Likewise.
1118 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1119 (TypeOf.DoResolve): Likewise.
1121 * expression.cs (Invocation.BetterConversion): Return the Type of
1122 the better conversion. Implement section 14.4.2.3 more faithfully.
1123 (Invocation.BetterFunction): Make boolean. Make correspondence to
1124 section 14.4.2.2 explicit.
1125 (Invocation.OverloadResolve): Update.
1126 (Invocation): Remove is_base field.
1127 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1128 (Invocation.Emit): Likewise.
1130 2004-09-27 Raja R Harinath <rharinath@novell.com>
1132 * README: Update to changes.
1134 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1136 * cs-parser.jay: Reverted 642 warning fix.
1138 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1141 * decl.cs (FindMemberWithSameName): Indexer can have more than
1144 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1146 * expression.cs (LocalVariableReference.DoResolveLValue):
1147 Do not report warning 219 for out values.
1148 (EmptyExpression.Null): New member to avoid extra allocations.
1150 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1152 * cs-parser.jay: Fix wrong warning 642 report.
1154 * cs-tokenizer.cs (CheckNextToken): New helper;
1155 Inspect next character if is same as expected.
1157 2004-09-23 Martin Baulig <martin@ximian.com>
1159 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1160 (Convert.ImplicitReferenceConversionExists): Likewise.
1162 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1164 * class.cs (Operator.Define): Add error 448 and 559 report.
1166 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1168 * class.cs (MemberBase.IsTypePermitted): New protected
1169 method for checking error CS0610.
1171 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1173 * class.cs (TypeContainer.HasExplicitLayout): New property
1174 Returns whether container has StructLayout attribute set Explicit.
1175 (FieldMember): New abstract class for consts and fields.
1176 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1177 (Field): Reuse FieldMember.
1179 * const.cs (Const): Reuse FieldMember.
1181 * rootcontext.cs: EmitConstants call moved to class.
1183 2004-09-22 Martin Baulig <martin@ximian.com>
1185 Thanks to Peter Sestoft for this bug report.
1187 * expression.cs (Conditional): If both the `trueExpr' and the
1188 `falseExpr' is a NullLiteral, return a NullLiteral.
1190 2004-09-22 Martin Baulig <martin@ximian.com>
1192 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1193 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1194 for the "get_Current" call.
1196 2004-09-22 Martin Baulig <martin@ximian.com>
1198 Marek and me just fixed one of our oldest bugs: #28562 :-)
1200 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1202 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1203 we're an EnumConstant, just return that.
1204 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1205 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1206 to get the value which'll actually be written into the attribute.
1207 However, we have to use GetValue() to access the attribute's value
1210 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1212 * constant.cs (Constant.IsNegative): New abstract property
1215 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1216 (StackAlloc.DoResolve): Reused IsNegative.
1218 2004-09-21 Martin Baulig <martin@ximian.com>
1220 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1221 if we're used in an iterator, we may be called from different
1224 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1225 we actually have an exception block.
1227 2004-09-20 John Luke <jluke@cfl.rr.com>
1229 * class.cs, cs-parser.jay: Improve the error report for 1520:
1230 report the actual line where the error happens, not where the
1233 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1234 Pass location information that was available elsewhere.
1236 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1238 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1239 runtime to delay sign assemblies.
1241 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1243 * cs-parser.jay: Do not report the stack trace, this is barely
1246 2004-08-22 John Luke <john.luke@gmail.com>
1248 * driver.cs : check that a resource id is not already used
1249 before adding it, report CS1508 if it is, bug #63637
1251 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1253 * ecore.cs: Removed dead code.
1255 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1257 * class.cs: Do not report warning CS0067 on the interfaces.
1259 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1261 * cs-parser.jay: Add error 504 report.
1263 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1265 * rootcontext.cs: WarningLevel is 4 by default now.
1267 * statement.cs (Fixed.Resolve): Do not null
1270 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1273 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1274 deep search when property is not virtual.
1275 (PropertyExpr.ResolveAccessors): Make one call for both
1278 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1281 * statement.cs: Error 152 report constains also location.
1283 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1286 * const.cs: Explicitly set constant as static.
1288 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1291 * cs-parser.jay: Add error 1017 report.
1293 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1295 Fixed bug #59980, #64224
1296 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1298 * typemanager.cs (IsSpecialMethod): Simplified
1300 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1302 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1303 condition with better params.
1305 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1308 * attribute.cs (Resolve): Property has to have both
1311 2004-09-14 Martin Baulig <martin@ximian.com>
1313 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1315 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1318 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1319 called and is obsolete then this member suppress message
1320 when call is inside next [Obsolete] method or type.
1322 * expression.cs: Use TestObsoleteMethodUsage member.
1324 2004-09-14 Martin Baulig <martin@ximian.com>
1326 * cs-parser.jay: Sync a bit with the GMCS version.
1328 2004-09-14 Martin Baulig <martin@ximian.com>
1330 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1331 (CSharpParser.yacc_verbose_flag): New public field.
1333 * genericparser.cs: Removed.
1335 2004-09-14 Raja R Harinath <rharinath@novell.com>
1337 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1339 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1341 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1343 2004-09-10 Martin Baulig <martin@ximian.com>
1345 Backported my MemberName changes from GMCS into MCS.
1347 - we are now using a special `MemberName' class instead of using
1348 strings; in GMCS, the `MemberName' also contains the type
1351 - changed the grammar rules a bit:
1352 * the old `member_name' is now a `namespace_or_type_name':
1353 The rule is that we use `namespace_or_type_name' everywhere
1354 where we expect either a "member name" (GetEnumerator) or a
1355 "member name" with an explicit interface name
1356 (IEnumerable.GetEnumerator).
1357 In GMCS, the explicit interface name may include type arguments
1358 (IEnumerable<T>.GetEnumerator).
1359 * we use `member_name' instead of just `IDENTIFIER' for
1361 The rule is that we use `member_name' wherever a member may
1362 have type parameters in GMCS.
1364 * decl.cs (MemberName): New public class.
1365 (MemberCore.MemberName): New public readonly field.
1366 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1367 (DeclSpace): Likewise.
1369 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1370 * enum.cs (Enum.ctor): Likewise.
1372 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1374 (AliasEntry.ctor): Take a MemberName, not an Expression.
1375 (AliasEntry.UsingAlias): Likewise.
1377 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1378 (IMethodData.MemberName): Changed type from string to MemberName.
1379 (MemberBase.ExplicitInterfaceName): Likewise.
1380 (AbstractPropertyEventMethod.SetupName): Make this private.
1381 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1382 argument; compute the member name here.
1383 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1384 on the `member.MemberName' and the `prefix'.
1386 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1388 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1389 thus, we get a `MemberName' instead of a `string'. These
1390 declarations may have type parameters in GMCS.
1391 (interface_method_declaration, delegate_declaration): Likewise.
1392 (class_declaration, interface_declaration): Likewise.
1393 (method_header): Use `namespace_or_type_name' instead of
1394 `member_name'. We may be an explicit interface implementation.
1395 (property_declaration, event_declaration): Likewise.
1396 (member_name): This is now just an `IDENTIFIER', not a
1397 `namespace_or_type_name'.
1398 (type_name, interface_type): Removed.
1399 (namespace_or_type_name): Return a MemberName, not an Expression.
1400 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1401 call GetTypeExpression() on the MemberName to get an expression.
1402 (IndexerDeclaration.interface_type): Changed type from string to
1404 (MakeName): Operate on MemberName's instead of string's.
1406 2004-09-13 Raja R Harinath <rharinath@novell.com>
1409 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1410 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1411 lookup to avoid symbols introduced by 'using'.
1412 * rootcontext.cs (NamespaceLookup): Update.
1414 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1416 * class.cs (TypeContainer.DoDefineMembers): Do not call
1417 DefineDefaultConstructor for static classes.
1419 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1421 * attribute.cs (Attribute.Resolve): Add error 653 report.
1423 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1425 (Method.ApplyAttributeBuilder): Add error 685 report.
1426 (Operator.Define): Add error 564 report.
1428 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1430 * expression.cs (Invocation.DoResolve): Add error
1433 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1436 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1438 * class.cs (ConstructorInitializer.Resolve):
1439 Wrong error number (515->516).
1441 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1443 * class.cs (Indexer.Define): Add error 631 report.
1445 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1447 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1449 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1451 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1453 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1455 * cs-parser.jay: Added error CS0241 report.
1457 2004-09-10 Raja R Harinath <rharinath@novell.com>
1459 * cs-parser.jay (fixed_statement): Introduce a scope for the
1460 declaration in the 'fixed' statement.
1462 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1464 * cs-parser.jay: Added CS0230 error report.
1466 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1468 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1470 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1472 * expression.cs (Argument.Resolve): Added error CS0192 and
1475 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1477 C# 2.0 #pragma warning feature
1479 * cs-tokenizer.cs (PreProcessPragma): New method;
1480 Handles #pragma directive.
1482 * report.cs (WarningRegions): New class; Support
1483 class for #pragma warning directive. It tests whether
1484 warning is enabled for a given line.
1486 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1488 * const.cs: Add more descriptive error report, tahnks to
1491 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1493 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1495 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1497 * expression.cs: Apply patch from Ben: Remove dead code from
1498 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1499 as that code just threw an exception anwyays.
1501 * const.cs: Remove the call to the turnintoconstant, for details
1504 * literal.cs: The type of the null-literal is the null type; So
1505 we use a placeholder type (literal.cs:System.Null, defined here)
1508 * expression.cs (Conditional.DoResolve): Remove some old code that
1509 is no longer needed, conversions have been fixed.
1511 (ArrayCreationExpression.DoResolve): Return false if we fail to
1512 resolve the inner expression.
1514 2004-09-07 Raja R Harinath <rharinath@novell.com>
1517 * cs-parser.jay (delegate_declaration): Record a delegate
1518 declaration as a type declaration.
1519 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1521 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1523 * parameter.cs: Do not crash if the type can not be resolved.
1525 * expression.cs: Report errors with unsafe pointers, fixes #64896
1527 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1529 * expression.cs: Pointer arith always needs to do a conv.i
1530 if the operand is a long. fix 65320
1532 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1534 Fixed cs0619-37.cs, cs0619-38.cs
1536 * enum.cs (GetObsoleteAttribute): Removed.
1538 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1539 on Enum member is double staged. The first is tested member
1542 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1544 Fixed #56986, #63631, #65231
1546 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1547 adds member to name container.
1548 (TypeContainer.AddToTypeContainer): New method, adds type to
1550 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1551 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1552 AddOperator): Simplified by reusing AddToMemberContainer.
1553 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1555 (Method.CheckForDuplications): Fixed implementation to test all
1557 (MemberBase): Detection whether member is explicit interface
1558 implementation is now in constructor.
1559 (MemberBase.UpdateMemberName): Handles IndexerName.
1560 (Accessor): Changed to keep also location information.
1561 (AbstractPropertyEventMethod): Is derived from MemberCore.
1562 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1563 will be emited or not.
1564 (PropertyBase.AreAccessorsDuplicateImplementation):
1565 Tests whether accessors are not in collision with some method.
1566 (Operator): Is derived from MethodCore to simplify common
1569 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1571 (DeclSpace.AddToContainer): Adds the member to defined_names
1572 table. It tests for duplications and enclosing name conflicts.
1574 * enum.cs (EnumMember): Clean up to reuse the base structures
1576 2004-09-03 Martin Baulig <martin@ximian.com>
1578 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1579 into TypeContainer, to make partial classes work again.
1581 2004-09-03 Martin Baulig <martin@ximian.com>
1583 * rootcontext.cs (RootContext.V2): Removed.
1585 2004-03-23 Martin Baulig <martin@ximian.com>
1587 * expression.cs (Invocation.OverloadResolve): Added `bool
1588 may_fail' argument and use it instead of the Location.IsNull() hack.
1590 2004-09-03 Martin Baulig <martin@ximian.com>
1592 Merged latest changes into gmcs. Please keep this comment in
1593 here, it makes it easier for me to see what changed in MCS since
1594 the last time I merged.
1596 2004-09-03 Raja R Harinath <rharinath@novell.com>
1599 * expression.cs (BetterConversion): Don't allow either conversion
1600 to be null. Remove redundant implicit conversion test when 'q ==
1601 null' -- when this function is invoked, we already know that the
1602 implicit conversion exists.
1603 (BetterFunction): Assume that 'best' is non-null. Remove
1604 redundant reimplementation of IsApplicable when 'best' is null.
1605 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1606 number of arguments.
1607 (IsAncestralType): Extract from OverloadResolve.
1608 (OverloadResolve): Make robust to the MethodGroupExpr being
1609 unsorted. Implement all the logic of Section 14.5.5.1, and
1610 support overloading of methods from multiple applicable types.
1611 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1613 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1614 (RealError, Warning): Append type of report to related symbol.
1616 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1618 * enum.cs: Fixed CLS-Compliance checks for enum members.
1619 Error tests cs3008-8.cs, cs3014-8.cs
1621 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1623 Fixed bug #62342, #63102
1624 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1625 like ImplementMethod.
1627 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1629 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1632 2004-09-02 Martin Baulig <martin@ximian.com>
1634 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1635 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1638 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1640 C# 2.0 Static classes implemented
1642 * class.cs (TypeContainer): instance_constructors,
1643 initialized_fields, initialized_static_fields,
1644 default_constructor, base_inteface_types are protected to be
1645 accessible from StaticClass.
1646 (TypeContainer.DefineDefaultConstructor): New virtual method
1647 for custom default constructor generating
1648 (StaticClass): New class to handle "Static classes" feature.
1650 * cs-parser.jay: Handle static keyword on class like instance
1653 * driver.cs: Added "/langversion" command line switch with two
1654 options (iso-1, default).
1656 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1658 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1660 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1662 * delegate.cs: Style.
1664 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1666 * delegate.cs: Add seperate instance expr field for miguel.
1668 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1670 * PointerArithmetic (Resolve): make sure we are not doing
1671 pointer arith on void*. Also, make sure we are resolved
1672 by not setting eclass until resolve.
1674 All callers: Make sure that PointerArithmetic gets resolved.
1676 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1678 * ArrayCreation (LookupType): If the type does not resolve
1679 to an array, give an error.
1681 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1683 * statement.cs (Try.Resolve): Fixed bug #64222
1685 2004-08-27 Martin Baulig <martin@ximian.com>
1688 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1691 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1693 * ecore.cs (Constantify): Get underlying type via
1694 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1695 Windows in special cases.
1697 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1699 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1700 for obtaining also private methods.
1701 (GetRemoveMethod): Used GetRemoveMethod (true)
1702 for obtaining also private methods.
1704 2004-08-24 Martin Baulig <martin@ximian.com>
1706 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1707 MethodAttributes.HideBySig for operators.
1709 2004-08-23 Martin Baulig <martin@ximian.com>
1711 Back to the old error reporting system :-)
1713 * report.cs (Message): Removed.
1714 (Report.MessageData, ErrorData, WarningData): Removed.
1715 (Report.Error, Warning): Back to the old system.
1717 2004-08-23 Martin Baulig <martin@ximian.com>
1719 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1721 * class.cs (TypeContainer.ParentContainer): New public virtual
1722 method; replaces the explicit interface implementation.
1723 (ClassPart.ParentContainer): Override.
1725 2004-08-23 Martin Baulig <martin@ximian.com>
1727 * statement.cs (Switch): Added support for constant switches; see
1728 #59428 or test-285.cs.
1730 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1733 * statement.cs (GetEnumeratorFilter): Removed useless
1734 logic because C# specs is strict. GetEnumerator must be
1737 2004-08-22 Martin Baulig <martin@ximian.com>
1739 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1740 a switch and may break, reset the barrier. Fixes #59867.
1742 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1744 CLS-Compliance speed up (~5% for corlib)
1746 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1747 New method. Tests container for CLS-Compliant names
1749 * class.cs (TypeContainer.VerifyClsName): New method.
1750 Checks whether container name is CLS Compliant.
1751 (Constructor): Implements IMethodData.
1753 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1754 low-case table for CLS Compliance test.
1755 (MemberCache.VerifyClsParameterConflict): New method.
1756 Checks method parameters for CS3006 error.
1758 * enum.cs (EnumMember): Is derived from MemberCore.
1759 (Enum.VerifyClsName): Optimized for better performance.
1761 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1763 * report.cs: Renamed Error_T to Error and changed all
1766 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1768 * class.cs (TypeContainer.IndexerArrayList): New inner class
1769 container for indexers.
1770 (TypeContainer.DefaultIndexerName): New constant for default
1771 indexer name. Replaced all "Item" with this constant.
1772 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1774 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1775 DefaultMemberAttribute constructor.
1777 2004-08-05 Martin Baulig <martin@ximian.com>
1779 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1782 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1784 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1785 multi platforms problem.
1787 * compiler.csproj: Included shared files.
1789 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1791 Fix bug 60333, 55971 in the more general way
1792 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1793 Added arg_type argument for constant conversion.
1794 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1796 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1799 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1800 OperatorArrayList, MethodCoreArrayList for typecontainer
1801 containers. Changed class member types to these new types.
1802 (MethodArrayList.DefineMembers): Added test for CS0659.
1804 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1806 * cfold.cs: Synchronize the folding with the code in expression.cs
1807 Binary.DoNumericPromotions for uint operands.
1809 * attribute.cs: Revert patch from Raja, it introduced a regression
1810 while building Blam-1.2.1 (hard to isolate a test case).
1812 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1816 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1818 (MethodCore.parent_method): New member. The method we're overriding
1819 if this is an override method.
1820 (MethodCore.CheckBase): Moved from Method class and made common.
1821 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1823 (MethodCore.CheckForDuplications): New abstract method. For custom
1824 member duplication search in a container
1825 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1826 method and its return type.
1827 (Event.conflict_symbol): New member. Symbol with same name in the
1831 (MemberCache.FindMemberWithSameName): New method. The method
1832 is looking for conflict with inherited symbols.
1834 2004-08-04 Martin Baulig <martin@ximian.com>
1836 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1838 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1840 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1842 * report.cs (Message): New enum for better error, warning reference in
1844 (MessageData): New inner abstract class. It generally handles printing of
1845 error and warning messages.
1846 Removed unused Error, Warning, Message methods.
1848 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1850 Fix for cs0592-8.cs test
1852 (Attributable.ValidAttributeTargets): Made public.
1853 (Attribute.ExplicitTarget): New member for explicit target value.
1854 (Attribute.CheckTargets): Now we translate explicit attribute
1855 target to Target here.
1857 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1859 * ecore.cs (MethodGroupExpr): new IsBase property.
1861 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1863 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1864 rather than an instance expr.
1866 (DelegateCreation.Emit): Use the method group rather than
1867 the instance expression. Also, if you have base.Foo as the
1868 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1870 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1872 (NewDelegate.DoResolve): Only check for the existance of Invoke
1873 if the method is going to be needed. Use MethodGroupExpr.
1875 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1877 * expression.cs: For pointer arith., make sure to use
1878 the size of the type, not the size of the pointer to
1881 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1884 * class.cs (Class): Added error CS0502 test.
1886 2004-08-03 John Luke <jluke@cfl.rr.com>
1887 Raja R Harinath <rharinath@novell.com>
1890 * attribute.cs (Attribute.complained_before): New flag.
1891 (Attribute.ResolveType, Attribute.Resolve),
1892 (Attribute.DefinePInvokeMethod): Set it.
1893 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1895 2004-08-03 Martin Baulig <martin@ximian.com>
1897 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1898 use a user-defined operator; we still need to do numeric
1899 promotions in case one argument is a builtin type and the other
1900 one has an implicit conversion to that type. Fixes #62322.
1902 2004-08-02 Martin Baulig <martin@ximian.com>
1904 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1905 (LocalInfo.IsThis): New public property.
1906 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1908 2004-08-01 Martin Baulig <martin@ximian.com>
1910 * class.cs (TypeContainer.GetClassBases): Don't set the default
1911 here since we may get called from GetPartialBases().
1912 (TypeContainer.DefineType): If GetClassBases() didn't return a
1913 parent, use the default one.
1915 2004-07-30 Duncan Mak <duncan@ximian.com>
1917 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
1919 2004-07-30 Martin Baulig <martin@ximian.com>
1921 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1923 * class.cs (SourceMethod): New public class, derive from the
1924 symbol writer's ISourceMethod.
1925 (Method): Use the new symbol writer API.
1927 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1928 as argument and use the new symbol writer.
1931 (SourceFile): Implement the symbol writer's ISourceFile.
1932 (Location.SymbolDocument): Removed.
1933 (Location.SourceFile): New public property.
1935 * symbolwriter.cs: Use the new symbol writer API.
1937 2004-07-30 Raja R Harinath <rharinath@novell.com>
1939 * Makefile (install-local): Remove. Functionality moved to
1942 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1944 * Makefile: Install mcs.exe.config file together with mcs.exe.
1945 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1946 correct runtime version.
1948 2004-07-25 Martin Baulig <martin@ximian.com>
1951 (TypeContainer.RegisterOrder): Removed, this was unused.
1952 (TypeContainer, interface_order): Removed.
1953 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1954 TypeContainer as argument since we can also be called with a
1955 `PartialContainer' for a partial class/struct/interface.
1956 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1957 of checking whether we're an `Interface' - we could be a
1959 (PartialContainer.Register): Override; call
1960 AddClass()/AddStruct()/AddInterface() on our parent.
1962 * cs-parser.jay (interface_member_declaration): Add things to the
1963 `current_container', not the `current_class'.
1965 * rootcontext.cs (RegisterOrder): The overloaded version which
1966 takes an `Interface' was unused, removed.
1968 * typemanager.cs (TypeManager.LookupInterface): Return a
1969 `TypeContainer', not an `Interface'.
1970 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1971 contain a `PartialContainer' for an interface, so check it's
1972 `Kind' to figure out what it is.
1974 2004-07-25 Martin Baulig <martin@ximian.com>
1976 * class.cs (Class.DefaultTypeAttributes): New public constant.
1977 (Struct.DefaultTypeAttributes): Likewise.
1978 (Interface.DefaultTypeAttributes): Likewise.
1979 (PartialContainer.TypeAttr): Override this and add the
1980 DefaultTypeAttributes.
1982 2004-07-25 Martin Baulig <martin@ximian.com>
1984 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1985 we can just use the `Parent' field instead.
1987 2004-07-25 Martin Baulig <martin@ximian.com>
1989 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1991 2004-07-25 Martin Baulig <martin@ximian.com>
1993 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1994 our parts before defining any methods.
1995 (TypeContainer.VerifyImplements): Make this virtual.
1996 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1997 on our PartialContainer.
1999 2004-07-25 Martin Baulig <martin@ximian.com>
2001 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2003 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2004 argument, we can just use the `Parent' field instead.
2007 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2008 (MemberBase.DoDefine): Likewise.
2010 2004-07-24 Martin Baulig <martin@ximian.com>
2012 * decl.cs (MemberCore.Parent): New public field.
2013 (DeclSpace.Parent): Moved to MemberCore.
2015 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2016 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2018 (FieldBase, Field, Operator): Likewise.
2019 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2020 (EventField, Event): Likewise.
2022 2004-07-23 Martin Baulig <martin@ximian.com>
2024 * class.cs (PartialContainer): New public class.
2025 (ClassPart): New public class.
2026 (TypeContainer): Added support for partial classes.
2027 (TypeContainer.GetClassBases): Splitted some of the functionality
2028 out into GetNormalBases() and GetPartialBases().
2030 * cs-tokenizer.cs (Token.PARTIAL): New token.
2031 (Tokenizer.consume_identifier): Added some hacks to recognize
2032 `partial', but only if it's immediately followed by `class',
2033 `struct' or `interface'.
2035 * cs-parser.jay: Added support for partial clases.
2037 2004-07-23 Martin Baulig <martin@ximian.com>
2039 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2040 a `DeclSpace' and also made it readonly.
2041 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2042 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2043 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2045 * cs-parser.jay: Pass the `current_class', not the
2046 `current_container' (at the moment, this is still the same thing)
2047 to a new Method, Property, Event, Indexer or Constructor.
2049 2004-07-23 Martin Baulig <martin@ximian.com>
2051 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2052 and removed the `current_interface' one.
2053 (struct_declaration, class_declaration, interface_declaration):
2054 Set `current_class' to the newly created class/struct/interface;
2055 set their `Bases' and call Register() before parsing their body.
2057 2004-07-23 Martin Baulig <martin@ximian.com>
2059 * class.cs (Kind): New public enum.
2060 (TypeContainer): Made this class abstract.
2061 (TypeContainer.Kind): New public readonly field.
2062 (TypeContainer.CheckDef): New public method; moved here from
2064 (TypeContainer.Register): New public abstract method.
2065 (TypeContainer.GetPendingImplementations): New public abstract
2067 (TypeContainer.GetClassBases): Removed the `is_class' and
2068 `is_iface' parameters.
2069 (TypeContainer.DefineNestedTypes): Formerly known as
2071 (ClassOrStruct): Made this class abstract.
2073 * tree.cs (RootTypes): New public type.
2075 2004-07-20 Martin Baulig <martin@ximian.com>
2077 * tree.cs (Tree.RecordNamespace): Removed.
2078 (Tree.Namespaces): Removed.
2080 * rootcontext.cs (RootContext.IsNamespace): Removed.
2082 * cs-parser.jay (namespace_declaration): Just create a new
2083 NamespaceEntry here.
2085 2004-07-20 Martin Baulig <martin@ximian.com>
2087 * statement.cs (ExceptionStatement): New abstract class. This is
2088 now used as a base class for everyone who's using `finally'.
2089 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2090 our local variables before using them.
2092 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2093 virtual method. This is used by Yield.Resolve() to "steal" an
2094 outer block's `finally' clauses.
2095 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2098 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2099 version which takes an ExceptionStatement. This version must be
2100 used to create exception branchings.
2103 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2104 (Iterator.EmitMoveNext): Added exception support; protect the
2105 block with a `fault' clause, properly handle 'finally' clauses.
2106 (Iterator.EmitDispose): Run all the `finally' clauses here.
2108 2004-07-20 Martin Baulig <martin@ximian.com>
2110 * iterator.cs: This is the first of a set of changes in the
2111 iterator code. Match the spec more closely: if we're an
2112 IEnumerable, then GetEnumerator() must be called. The first time
2113 GetEnumerator() is called, it returns the current instance; all
2114 subsequent invocations (if any) must create a copy.
2116 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2118 * expression.cs: Resolve the constant expression before returning
2121 2004-07-19 Martin Baulig <martin@ximian.com>
2123 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2124 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2125 the return type of the new EmitContext.
2127 2004-07-18 Martin Baulig <martin@ximian.com>
2129 * class.cs (Property.Define): Fix iterators.
2131 * iterators.cs (Iterator.Define): Moved the
2132 `container.AddInterator (this)' call here from the .ctor; only do
2133 it if we resolved successfully.
2135 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2137 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2138 `true' for preprocessing directives that we parse. The return
2139 value indicates whether we should return to regular tokenizing or
2140 not, not whether it was parsed successfully.
2142 In the past if we were in: #if false ... #line #endif, we would
2143 resume parsing after `#line'. See bug 61604.
2145 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2146 building: IsEnumType should return true only for enums, not for
2147 enums or System.Enum itself. This fixes #61593.
2149 Likely what happened is that corlib was wrong: mcs depended on
2150 this bug in some places. The bug got fixed, we had to add the
2151 hack, which caused bug 61593.
2153 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2154 that was a workaround for the older conditions.
2156 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2158 * assign.cs: IAssignMethod has a new interface, as documented
2159 inline. All assignment code now uses this new api.
2161 * ecore.cs, expression.cs: All classes which implement
2162 IAssignMethod now use the new interface.
2164 * expression.cs (Invocation): add a hack to EmitCall so that
2165 IndexerAccess can be the target of a compound assignment without
2166 evaluating its arguments twice.
2168 * statement.cs: Handle changes in Invocation api.
2170 2004-07-16 Martin Baulig <martin@ximian.com>
2172 * iterators.cs: Rewrote this. We're now using one single Proxy
2173 class for both the IEnumerable and the IEnumerator interface and
2174 `Iterator' derives from Class so we can use the high-level API.
2176 * class.cs (TypeContainer.AddIterator): New method.
2177 (TypeContainer.DoDefineType): New protected virtual method, which
2178 is called from DefineType().
2179 (TypeContainer.DoDefineMembers): Call DefineType() and
2180 DefineMembers() on all our iterators.
2181 (TypeContainer.Emit): Call Emit() on all our iterators.
2182 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2184 * codegen.cs (EmitContext.CurrentIterator): New public field.
2186 2004-07-15 Martin Baulig <martin@ximian.com>
2189 (TypeManager.not_supported_exception_type): New type.
2191 2004-07-14 Martin Baulig <martin@ximian.com>
2193 * iterators.cs: Use real error numbers.
2195 2004-07-14 Martin Baulig <martin@ximian.com>
2197 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2198 requires this to be a System.Collection.IEnumerable and not a
2199 class implementing that interface.
2200 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2202 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2204 * class.cs: Fixed previous fix, it broke some error tests.
2206 2004-07-12 Martin Baulig <martin@ximian.com>
2208 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2211 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2213 * assign.cs (LocalTemporary): Add new argument: is_address,If
2214 `is_address' is true, then the value that we store is the address
2215 to the real value, and not the value itself.
2217 * ecore.cs (PropertyExpr): use the new local temporary
2218 stuff to allow us to handle X.Y += z (where X is a struct)
2220 2004-07-08 Martin Baulig <martin@ximian.com>
2222 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2223 not always return, just like we're doing in Using.Resolve().
2225 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2227 * cs-parser.jay (fixed_statement): flag this as Pinned.
2229 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2231 * typemanager.cs (TypeManager): Removed MakePinned method, this
2232 mechanism is replaced with the .NET 2.x compatible mechanism of
2233 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2235 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2236 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2237 `IsFixed' property which has a different meaning.
2239 2004-07-02 Raja R Harinath <rharinath@novell.com>
2241 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2242 visible from inside a nested class, not just the names of the
2243 immediately enclosing class.
2246 2004-06-24 Raja R Harinath <rharinath@novell.com>
2248 * expression.cs (BetterConversion): Remove buggy special-case
2249 handling of "implicit constant expression conversions". At this
2250 point, we already know that the conversion is possible -- we're
2251 only checking to see which is better.
2253 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2255 * cs-parser.jay: Added error CS0210 test.
2257 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2259 * cs-parser.jay: Added error CS0134 test.
2261 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2264 * cs-parser.jay: Added error CS0145 test.
2266 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2268 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2270 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2272 * expression.cs (StackAlloc.Resolve): The argument may not
2273 be a constant; deal with this case.
2275 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2277 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2278 GetIndexerAttributeValue.
2279 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2281 * class.cs (Indexer.Define): Added error tests for CS0415,
2284 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2286 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2289 2004-06-23 Martin Baulig <martin@ximian.com>
2291 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2292 neither return nor throw, reset the barrier as well. Fixes #60457.
2294 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2296 * class.cs : EventAttributes is now set to None by default.
2297 This fixes bug #60459.
2299 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2302 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2303 Don't throw exception but return null (it's sufficient now).
2305 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2307 * typemanager.cs (GetArgumentTypes): Faster implementation.
2309 2004-06-18 Martin Baulig <martin@ximian.com>
2311 * attribute.cs (Attribute.Resolve): Check whether we're an
2312 EmptyCast which a Constant child. Fixes #60333.
2314 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2316 * statement.cs (EmitCollectionForeach): Account for the fact that
2317 not all valuetypes are in areas which we can take the address of.
2318 For these variables, we store to a temporary variable. Also, make
2319 sure that we dont emit a `callvirt' on a valuetype method.
2321 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2323 * expression.cs (StackAlloc.DoReSolve): Added test for
2324 negative parameter (CS0247).
2326 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2329 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2331 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2334 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2337 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2339 Fix bug #58254 & cs1555.cs, cs1556.cs
2340 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2342 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2344 * cs-parser.jay: Added error CS1669 test for indexers.
2346 2004-06-11 Martin Baulig <martin@ximian.com>
2348 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2349 call this twice: for params and varargs methods.
2351 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2354 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2356 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2358 * attribute.cs (Attribute.GetValidTargets): Made public.
2361 (AbstractPropertyEventMethod): New class for better code sharing.
2362 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2364 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2366 2004-06-11 Raja R Harinath <rharinath@novell.com>
2369 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2370 that the call to Resolve is part of a MemberAccess.
2371 (Expression.Resolve): Use it for SimpleName resolution.
2372 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2373 Add 'intermediate' boolean argument.
2374 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2375 error message when the SimpleName can be resolved ambiguously
2376 between an expression and a type.
2377 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2379 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2380 call on the left-side.
2382 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2385 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2387 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2389 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2391 2004-06-11 Martin Baulig <martin@ximian.com>
2393 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2394 varargs methods if applicable.
2396 2004-06-11 Martin Baulig <martin@ximian.com>
2398 * expression.cs (Invocation.EmitCall): Don't use
2399 `method.CallingConvention == CallingConventions.VarArgs' since the
2400 method could also have `CallingConventions.HasThis'.
2402 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2404 * class.cs (Event.GetSignatureForError): Implemented.
2405 Fixed crash in error test cs3010.cs
2407 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2409 * cs-tokenizer.cs: Change the way we track __arglist to be
2410 consistent with the other keywords.
2412 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2414 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2417 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2419 * codegen.cs: Check that all referenced assemblies have a strongname
2420 before strongnaming the compiled assembly. If not report error CS1577.
2421 Fix bug #56563. Patch by Jackson Harper.
2422 * typemanager.cs: Added a method to return all referenced assemblies.
2423 Fix bug #56563. Patch by Jackson Harper.
2425 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2428 (Method.ApplyAttributeBuilder): Moved and added conditional
2429 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2432 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2434 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2437 * class.cs: (EventField.attribute_targets): Changed default target.
2439 2004-06-08 Martin Baulig <martin@ximian.com>
2441 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2443 2004-06-08 Martin Baulig <martin@ximian.com>
2445 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2447 2004-06-07 Martin Baulig <martin@ximian.com>
2449 Added support for varargs methods.
2451 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2454 * cs-parser.jay: Added support for `__arglist'.
2456 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2458 * expression.cs (Argument.AType): Added `ArgList'.
2459 (Invocation): Added support for varargs methods.
2460 (ArglistAccess): New public class.
2461 (Arglist): New public class.
2463 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2465 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2466 a method's top-level block if the method has varargs.
2468 * support.cs (ReflectionParameters, InternalParameters): Added
2469 support for varargs methods.
2471 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2473 * class.cs: Provide location in indexer error report.
2475 * driver.cs: Use standard names.
2477 * namespace.cs: Catch the use of using after a namespace has been
2478 declared also on using aliases.
2480 2004-06-03 Raja R Harinath <rharinath@novell.com>
2483 * typemanager.cs (closure_private_ok, closure_invocation_type)
2484 (closure_qualifier_type, closure_invocation_assembly)
2485 (FilterWithClosure): Move to ...
2486 (Closure): New internal nested class.
2487 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2488 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2489 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2490 (MemberLookup, MemberLookupFailed): Use it.
2491 * expression.cs (New.DoResolve): Treat the lookup for the
2492 constructor as being qualified by the 'new'ed type.
2493 (Indexers.GetIndexersForTypeOrInterface): Update.
2495 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2498 (GetConditionalAttributeValue): New method. Returns
2499 condition of ConditionalAttribute.
2500 (SearchMulti): New method. Returns all attributes of type 't'.
2501 Use it when attribute is AllowMultiple = true.
2502 (IsConditionalMethodExcluded): New method.
2505 (Method.IsExcluded): Implemented. Returns true if method has conditional
2506 attribute and the conditions is not defined (method is excluded).
2507 (IMethodData): Extended interface for ConditionalAttribute support.
2508 (PropertyMethod.IsExcluded): Implemented.
2511 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2514 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2517 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2519 * expression.cs (ArrayCreationExpression): Make this just an
2520 `expression'. It can't be a statement, so the code here was
2523 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2526 * typemanager.cs (GetFullNameSignature): New method for
2529 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2532 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2533 Use this method when MethodBuilder is null.
2534 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2535 Added test for error CS0626 (MONO reports error for this situation).
2536 (IMethodData.GetSignatureForError): Extended interface.
2538 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2541 (AttributeTester.GetObsoleteAttribute): Returns instance of
2542 ObsoleteAttribute when type is obsolete.
2545 (TypeContainer.VerifyObsoleteAttribute): Override.
2546 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2547 (MethodCode.VerifyObsoleteAttribute): Override.
2548 (MemberBase.VerifyObsoleteAttribute): Override.
2551 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2552 and report proper error.
2555 Delegate.VerifyObsoleteAttribute): Override.
2558 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2559 and report proper error.
2560 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2563 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2567 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2568 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2569 Added test for ObsoleteAttribute.
2572 (Catch): Derived from Statement.
2574 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2576 Fixed bug #59071 & cs0160.cs
2578 * statement.cs (Try.Resolve): Check here whether order of catch
2579 clauses matches their dependencies.
2581 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2583 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2584 caused a regression: #59343. Referencing nested classes from an
2585 assembly stopped working.
2587 2004-05-31 Martin Baulig <martin@ximian.com>
2589 MCS is now frozen for beta 2.
2591 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2593 * convert.cs: add a trivial cache for overload operator resolution.
2595 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2597 * decl.cs: If possible, use lookuptypedirect here. We can only do
2598 this if there is no `.' after the namespace. Avoids using
2599 LookupType, which does lots of slow processing.
2600 (FindNestedType) New method, does what it says :-).
2601 * namespace.cs: use LookupTypeDirect.
2602 * rootcontext.cs: use membercache, if possible.
2603 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2605 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2608 According to the spec,
2610 In a member access of the form E.I, if E is a single identifier,
2611 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2612 field, property, localvariable, or parameter with the same type as
2613 the meaning of E as a type-name (§3.8), then both possible
2614 meanings of E are permitted.
2616 We did not check that E as a simple-name had the same type as E as
2619 This trivial check gives us 5-7% on bootstrap time.
2621 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2623 * expression.cs (Invocation.OverloadResolve): Avoid the
2624 use of hashtables and boxing here by allocating on demand.
2626 2004-05-30 Martin Baulig <martin@ximian.com>
2628 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2629 we're doing a silent lookup. Don't try to lookup nested types in
2630 TypeManager.object_type (thanks to Ben Maurer).
2632 2004-05-30 Martin Baulig <martin@ximian.com>
2634 Committing a patch from Ben Maurer.
2636 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2638 2004-05-29 Martin Baulig <martin@ximian.com>
2640 * class.cs (IMethodData.ShouldIgnore): New method.
2642 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2643 `Location' argument, we don't need it anywhere. Use
2644 `IMethodData.ShouldIgnore ()' instead of
2645 `MethodData.GetMethodFlags ()'.
2646 (TypeManager.AddMethod): Removed.
2647 (TypeManager.AddMethod2): Renamed to AddMethod.
2649 2004-05-29 Martin Baulig <martin@ximian.com>
2651 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2653 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2654 converting from a class type S to an interface type and we already
2655 have an object on the stack, don't box it again. Fixes #52578.
2657 2004-05-29 Martin Baulig <martin@ximian.com>
2659 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2660 Added support for `params' parameters. Fixes #59267.
2662 2004-05-29 Martin Baulig <martin@ximian.com>
2664 * literal.cs (NullPointer): Provide a private .ctor which sets
2665 `type' to TypeManager.object_type. Fixes #59048.
2667 2004-05-29 Martin Baulig <martin@ximian.com>
2669 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2670 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2672 * ecore.cs (EventExpr.instance_expr): Make the field private.
2674 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2676 Fixed bug #50080 & cs0214-2.cs
2677 * expression.cs (Cast.DoResolve): Check unsafe context here.
2679 * statement.cs (Resolve.DoResolve): Likewise.
2681 2004-05-26 Martin Baulig <martin@ximian.com>
2683 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2685 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2686 (RootContext.LookupType): Pass down the `silent' flag.
2688 2004-05-25 Martin Baulig <martin@ximian.com>
2691 (MethodGroupExpr.IdenticalTypeName): New public property.
2692 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2693 expression actually refers to a type.
2695 2004-05-25 Martin Baulig <martin@ximian.com>
2697 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2698 for #56176 and made it actually work.
2700 2004-05-25 Martin Baulig <martin@ximian.com>
2702 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2703 (FieldExpr, PropertyExpr): Override and implement
2704 CacheTemporaries. Fixes #52279.
2706 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2708 * location.cs: In the new compiler listing a file twice is a
2709 warning, not an error.
2711 2004-05-24 Martin Baulig <martin@ximian.com>
2713 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2714 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2716 2004-05-24 Martin Baulig <martin@ximian.com>
2718 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2719 walking the `using' list. Fixes #53921.
2721 2004-05-24 Martin Baulig <martin@ximian.com>
2723 * const.cs (Const.LookupConstantValue): Added support for
2724 EmptyCast's; fixes #55251.
2726 2004-05-24 Martin Baulig <martin@ximian.com>
2728 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2729 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2730 which does the CS0135 check. The reason is that we first need to
2731 check whether the variable actually exists.
2733 2004-05-24 Martin Baulig <martin@ximian.com>
2735 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2736 than RootContext.LookupType() to find the explicit interface
2739 2004-05-24 Raja R Harinath <rharinath@novell.com>
2741 * Makefile: Simplify. Use executable.make.
2742 * mcs.exe.sources: New file. List of sources of mcs.exe.
2744 2004-05-24 Anders Carlsson <andersca@gnome.org>
2748 Use the invariant culture when doing String.Compare for CLS case
2751 2004-05-23 Martin Baulig <martin@ximian.com>
2753 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2754 don't have any dots. Fixes #52622, added cs0246-8.cs.
2756 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2758 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2760 * class.cs (MemberBase.Define): Reuse MemberType member for
2761 resolved type. Other methods can use it too.
2763 2004-05-23 Martin Baulig <martin@ximian.com>
2765 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2766 the variable also exists in the current block (otherwise, we need
2767 to report a CS0103). Fixes #58670.
2769 2004-05-23 Martin Baulig <martin@ximian.com>
2771 * flowanalysis.cs (Reachability.Reachable): Compute this
2772 on-the-fly rather than storing it as a field.
2774 2004-05-23 Martin Baulig <martin@ximian.com>
2776 * flowanalysis.cs (Reachability.And): Manually compute the
2777 resulting `barrier' from the reachability.
2779 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2782 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2783 instance of ObsoleteAttribute when symbol is obsolete.
2786 (IMethodData): Extended interface for ObsoleteAttribute support.
2788 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2790 * attribute.cs: Fix bug #55970
2792 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2796 (GetObsoleteAttribute): New method. Creates the instance of
2798 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2799 ObsoleteAttribute when member is obsolete.
2800 (AttributeTester.Report_ObsoleteMessage): Common method for
2801 Obsolete error/warning reporting.
2804 (TypeContainer.base_classs_type): New member for storing parent type.
2807 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2808 for this MemberCore.
2810 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2812 * attribute.cs, const.cs: Fix bug #58590
2814 2004-05-21 Martin Baulig <martin@ximian.com>
2816 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2817 out parameters if the end of the method is unreachable. Fixes
2820 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2822 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2823 Hari was right, why extra method.
2825 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2827 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2829 2004-05-20 Martin Baulig <martin@ximian.com>
2831 Merged this back from gmcs to keep the differences to a minumum.
2833 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2834 instead of a Declspace.
2835 (Attribute.ResolveType): Likewise.
2836 (Attributes.Search): Likewise.
2837 (Attributes.Contains): Likewise.
2838 (Attributes.GetClsCompliantAttribute): Likewise.
2840 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
2842 (MethodData.ApplyAttributes): Take an EmitContext instead of a
2845 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2847 Fix bug #58688 (MCS does not report error when the same attribute
2850 * attribute.cs (Attribute.Emit): Distinction between null and default.
2852 2004-05-19 Raja R Harinath <rharinath@novell.com>
2854 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2855 of a top-level attribute without an attribute target.
2856 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2858 (Attribute.Conditional_GetConditionName),
2859 (Attribute.Obsolete_GetObsoleteMessage): Update.
2860 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2861 part of ScanForIndexerName.
2862 (Attribute.CanIgnoreInvalidAttribute): New function.
2863 (Attribute.ScanForIndexerName): Move to ...
2864 (Attributes.ScanForIndexerName): ... here.
2865 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2866 (Attributes.Search): New internal variant that can choose not to
2867 complain if types aren't resolved. The original signature now
2869 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2870 complaints suppressed.
2871 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2872 only if it not useful.
2873 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2874 top-level for attributes that are shared between the assembly
2875 and a top-level class.
2876 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2877 * class.cs: Update to reflect changes.
2878 (DefineIndexers): Fuse loops.
2879 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2880 a couple more variants of attribute names.
2882 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2884 Fix bug #52585 (Implemented explicit attribute declaration)
2887 (Attributable.ValidAttributeTargets): New abstract method. It gets
2888 list of valid attribute targets for explicit target declaration.
2889 (Attribute.Target): It holds target itself.
2890 (AttributeSection): Removed.
2891 (Attribute.CheckTargets): New method. It checks whether attribute
2892 target is valid for the current element.
2895 (EventProperty): New class. For events that are declared like
2896 property (with add and remove accessors).
2897 (EventField): New class. For events that are declared like field.
2900 * cs-parser.jay: Implemented explicit attribute target declaration.
2902 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2903 Override ValidAttributeTargets.
2906 (ReturnParameter): Class for applying custom attributes on
2908 (ParameterAtribute): New class. Class for applying custom
2909 attributes on the parameter type.
2911 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2913 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2916 (Method): Allow UNSAFE here.
2918 * modifiers.cs: Support unsafe reporting.
2920 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2922 * decl.cs: Fix bug #58478.
2924 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2926 * statement.cs: When checking for unreachable code on an EmptyStatement,
2927 set the location. Fixes bug #58488.
2929 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2931 * driver.cs: Add -pkg handling.
2933 From Gonzalo: UseShelLExecute=false
2935 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2938 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2940 (Attribute.IsClsCompliaceRequired): Moved to base for better
2942 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2943 when attribute is AttributeUsageAttribute.
2944 (Attribute.GetValidTargets): Simplified.
2945 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2946 attribute for this type.
2947 (Attribute.ApplyAttributes): Method renamed to Emit and make
2949 (GlobalAttributeSection): New class for special handling of global
2950 attributes (assembly, module).
2951 (AttributeSection.Emit): New method.
2953 * class.cs: Implemented Attributable abstract methods.
2954 (MethodCore.LabelParameters): Moved to Parameter class.
2955 (Accessor): Is back simple class.
2956 (PropertyMethod): Implemented Attributable abstract class.
2957 (DelegateMethod): Implemented Attributable abstract class.
2958 (Event): New constructor for disctintion between normal Event
2959 and Event with accessors.
2961 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2963 * codegen.cs, const.cs, decl.cs, delegate.cs:
2964 (CommonAssemblyModulClass): Implemented Attributable abstract class
2967 * enum.cs: Implement IAttributeSupport interface.
2968 (EnumMember): New class for emum members. Implemented Attributable
2972 (ParameterBase): Is abstract.
2973 (ReturnParameter): New class for easier [return:] attribute handling.
2975 * typemanager.cs: Removed builder_to_attr.
2977 2004-05-11 Raja R Harinath <rharinath@novell.com>
2980 * attribute.cs (Attribute.GetPositionalValue): New function.
2981 * class.cs (TypeContainer.VerifyMembers): New function.
2982 (TypeContainer.Emit): Use it.
2983 (ClassOrStruct): New base class for Class and Struct.
2984 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2985 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2987 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2988 then each non-static field should have a FieldOffset attribute.
2989 Otherwise, none of the fields should have a FieldOffset attribute.
2990 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2991 and FieldOffset attributes.
2992 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2993 (TypeManager.field_offset_attribute_type): New core types.
2994 (TypeManager.InitCoreTypes): Initialize them.
2996 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2998 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2999 Return correct type.
3002 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3004 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3005 be implicitly converted to ulong.
3007 * expression.cs: The logic for allowing operator &, | and ^ worked
3008 was wrong, it worked before because we did not report an error in
3009 an else branch. Fixes 57895.
3011 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3012 allow volatile fields to be reference types.
3014 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3016 * driver.cs: Add support for /debug-
3018 2004-05-07 Raja R Harinath <rharinath@novell.com>
3020 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3021 Add a 'complain' parameter to silence errors.
3022 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3023 silently overlooked type-resolutions.
3024 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3026 (Attributes.Search): New function.
3027 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3028 (Attributes.GetAttributeFullName): Remove hack.
3029 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3030 Update to reflect changes.
3031 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3032 Use Attributes.Search instead of nested loops.
3034 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3037 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3038 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3039 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3041 * report.cs: (Report.Warning): Renamed to Warning_T because of
3042 parameter collision.
3044 2004-05-05 Raja R Harinath <rharinath@novell.com>
3046 * expression.cs (MemberAccess.ResolveMemberAccess):
3047 Exit with non-zero status after Report.Error.
3048 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3050 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3052 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3054 * support.cs: Don't hang when the file is empty.
3056 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3058 * support.cs: In SeekableStreamReader, compute the preamble size of the
3059 underlying stream. Position changes should take into account that initial
3062 2004-05-03 Todd Berman <tberman@sevenl.net>
3064 * driver.cs: remove unused GetSysVersion function.
3066 2004-05-03 Todd Berman <tberman@sevenl.net>
3068 * driver.cs: Remove the hack from saturday, as well as the hack
3069 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3070 link_paths to get that bit proper.
3072 2004-05-01 Todd Berman <tberman@sevenl.net>
3074 * driver.cs: Try a LoadFrom before a Load, this checks the current
3075 path. This is currently a bug in mono that is be fixed, however, this
3076 provides a workaround for now. This will be removed when the bug
3079 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3081 * CryptoConvert.cs: Updated to latest version. Fix issue with
3082 incomplete key pairs (#57941).
3084 2004-05-01 Todd Berman <tberman@sevenl.net>
3086 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3089 2004-04-30 Jackson Harper <jackson@ximian.com>
3091 * codegen.cs: Open keys readonly.
3093 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3095 * typemanager.cs: don't report cyclic struct layout when a struct
3096 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3097 which has 2 Pango.Rectangle fields.
3099 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3101 * expression.cs: Handle IntPtr comparisons with IL code
3102 rather than a method call.
3104 2004-04-29 Martin Baulig <martin@ximian.com>
3106 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3107 the list of PropertyInfo's in class hierarchy and find the
3108 accessor. Fixes #56013.
3110 2004-04-29 Martin Baulig <martin@ximian.com>
3112 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3114 2004-04-29 Martin Baulig <martin@ximian.com>
3116 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3118 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3120 2004-04-29 Martin Baulig <martin@ximian.com>
3122 * class.cs (ConstructorInitializer.Resolve): Check whether the
3123 parent .ctor is accessible. Fixes #52146.
3125 2004-04-29 Martin Baulig <martin@ximian.com>
3127 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3129 * statement.cs (Using.EmitLocalVariableDecls): Use
3130 TypeManager.idisposable_type, not typeof (IDisposable).
3131 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3133 2004-04-29 Martin Baulig <martin@ximian.com>
3135 * class.cs (Event.Define): Don't emit the field and don't set
3136 RTSpecialName and SpecialName for events on interfaces. Fixes
3139 2004-04-29 Raja R Harinath <rharinath@novell.com>
3141 Refactor Attribute.ApplyAttributes.
3142 * attribute.cs (Attributable): New base class for objects that can
3143 have Attributes applied on them.
3144 (Attribute): Make AttributeUsage fields public.
3145 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3146 (Attribute.IsInternalCall): New property.
3147 (Attribute.UsageAttr): Convert to a public read-only property.
3148 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3149 (Attribute.ResolveType, Attribute.Resolve)
3150 (Attribute.ScanForIndexerName): Update to reflect changes.
3151 (Attribute.CheckAttributeTarget): Re-format.
3152 (Attribute.ApplyAttributes): Refactor, to various
3153 Attributable.ApplyAttributeBuilder methods.
3154 * decl.cs (MemberCore): Make Attributable.
3155 * class.cs (Accessor): Make Attributable.
3156 (MethodData.ApplyAttributes): Use proper attribute types, not
3158 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3159 (TypeContainer.ApplyAttributeBuilder)
3160 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3161 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3162 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3163 (Operator.ApplyAttributeBuilder): New factored-out methods.
3164 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3165 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3166 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3167 * parameter.cs (ParameterBase): New Attributable base class
3168 that can also represent Return types.
3169 (Parameter): Update to the changes.
3171 2004-04-29 Jackson Harper <jackson@ximian.com>
3173 * driver.cs: Prefer the corlib system version when looking for
3174 assemblies in the GAC. This is still a hack, but its a better hack
3177 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3179 * decl.cs, enum.cs: Improved error 3005 reporting.
3181 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3182 (related_symbols): New private member for list of symbols
3183 related to reported error/warning.
3185 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3187 2004-04-29 Martin Baulig <martin@ximian.com>
3189 * ecore.cs (Expression.Constantify): If we're an enum and
3190 TypeManager.TypeToCoreType() doesn't give us another type, use
3191 t.UnderlyingSystemType. Fixes #56178.
3193 2004-04-29 Martin Baulig <martin@ximian.com>
3195 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3196 interfaces and for each interface, only add members directly
3197 declared in that interface. Fixes #53255.
3199 2004-04-28 Martin Baulig <martin@ximian.com>
3201 * expression.cs (ConditionalLogicalOperator): Use a temporary
3202 variable for `left' to avoid that we evaluate it more than once;
3205 2004-04-28 Martin Baulig <martin@ximian.com>
3207 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3210 2004-04-28 Martin Baulig <martin@ximian.com>
3212 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3215 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3216 whether the type is not void (CS1547).
3218 2004-04-28 Martin Baulig <martin@ximian.com>
3220 * expression.cs (Unary.DoResolveLValue): Override this and report
3221 CS0131 for anything but Operator.Indirection.
3223 2004-04-28 Martin Baulig <martin@ximian.com>
3225 Committing a patch from Ben Maurer; see bug #50820.
3227 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3230 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3233 2004-04-28 Martin Baulig <martin@ximian.com>
3235 Committing a patch from Ben Maurer; see bug #50820.
3237 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3240 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3243 2004-04-28 Martin Baulig <martin@ximian.com>
3245 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3246 (Block.AddLabel): Call DoLookupLabel() to only search in the
3249 2004-04-28 Martin Baulig <martin@ximian.com>
3251 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3252 comparing StringConstants and NullLiterals in Equality and Inequality.
3254 2004-04-28 Jackson Harper <jackson@ximian.com>
3256 * driver.cs: Attempt to load referenced assemblies from the
3257 GAC. This is the quick and dirty version of this method that
3258 doesnt take into account versions and just takes the first
3259 canidate found. Will be good enough for now as we will not have more
3260 then one version installed into the GAC until I update this method.
3262 2004-04-28 Martin Baulig <martin@ximian.com>
3264 * typemanager.cs (TypeManager.CheckStructCycles): New public
3265 static method to check for cycles in the struct layout.
3267 * rootcontext.cs (RootContext.PopulateTypes): Call
3268 TypeManager.CheckStructCycles() for each TypeContainer.
3269 [Note: We only need to visit each type once.]
3271 2004-04-28 Martin Baulig <martin@ximian.com>
3273 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3275 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3276 success and added `out object value'. Use a `bool resolved' field
3277 to check whether we've already been called rather than
3278 `ConstantValue != null' since this breaks for NullLiterals.
3280 2004-04-28 Raja R Harinath <rharinath@novell.com>
3282 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3283 setting of this flag, since the 'set' method may be non-public.
3285 2004-04-28 Raja R Harinath <rharinath@novell.com>
3287 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3288 check on current_vector.Block.
3290 2004-04-27 Martin Baulig <martin@ximian.com>
3292 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3293 a field initializer. Fixes #56459.
3295 2004-04-27 Martin Baulig <martin@ximian.com>
3297 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3298 we're not attempting to use an indexer. Fixes #52154.
3300 2004-04-27 Martin Baulig <martin@ximian.com>
3302 * statement.cs (Return): Don't create a return label if we don't
3303 need it; reverts my change from January 20th. Thanks to Ben
3306 2004-04-27 Martin Baulig <martin@ximian.com>
3308 According to the spec, `goto' can only leave a nested scope, but
3311 * statement.cs (Block.LookupLabel): Only lookup in the current
3312 block, don't recurse into parent or child blocks.
3313 (Block.AddLabel): Check in parent and child blocks, report
3314 CS0140/CS0158 if we find a duplicate.
3315 (Block): Removed this indexer for label lookups.
3316 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3317 this already does the error reporting for us.
3320 (FlowBranching.UsageVector.Block): New public variable; may be null.
3321 (FlowBranching.CreateSibling): Added `Block' argument.
3322 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3323 label for the target of a `goto' and check whether we're not
3324 leaving a `finally'.
3326 2004-04-27 Martin Baulig <martin@ximian.com>
3328 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3329 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3332 2004-04-27 Martin Baulig <martin@ximian.com>
3334 * statement.cs (Block.AddLabel): Also check for implicit blocks
3335 and added a CS0158 check.
3337 2004-04-27 Martin Baulig <martin@ximian.com>
3339 * flowanalysis.cs (FlowBranchingLoop): New class.
3340 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3341 UsageVector's instead of an ArrayList.
3342 (FlowBranching.Label): Likewise.
3343 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3344 (FlowBranching.AddBreakVector): New method.
3346 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3348 * attribute.cs: Small regression fix: only convert the type if we
3349 the type is different, fixes System.Drawing build.
3351 2004-04-27 Martin Baulig <martin@ximian.com>
3353 * attribute.cs (Attribute.Resolve): If we have a constant value
3354 for a named field or property, implicity convert it to the correct
3357 2004-04-27 Raja R Harinath <rharinath@novell.com>
3359 * statement.cs (Block.Block): Implicit blocks share
3360 'child_variable_names' fields with parent blocks.
3361 (Block.AddChildVariableNames): Remove.
3362 (Block.AddVariable): Mark variable as "used by a child block" in
3363 every surrounding block.
3364 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3365 been used in a child block, complain about violation of "Invariant
3366 meaning in blocks" rule.
3367 * cs-parser.jay (declare_local_variables): Don't use
3368 AddChildVariableNames.
3369 (foreach_statement): Don't create an implicit block: 'foreach'
3372 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3374 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3375 converting from 0L to ulong. Fixes 57522.
3377 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3379 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3380 derived class hides via 'new' keyword field from base class (test-242.cs).
3381 TODO: Handle this in the more general way.
3383 * class.cs (CheckBase): Ditto.
3385 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3387 * decl.cs (caching_flags): New member for storing cached values
3389 (MemberCore.Flags): New enum where bit flags for caching_flags
3391 (MemberCore.cls_compliance): Moved to caching_flags.
3392 (DeclSpace.Created): Moved to caching_flags.
3394 * class.cs: Use caching_flags instead of DeclSpace.Created
3396 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3398 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3399 if we are only a derived class, not a nested class.
3401 * typemanager.cs: Same as above, but do this at the MemberLookup
3402 level (used by field and methods, properties are handled in
3403 PropertyExpr). Allow for the qualified access if we are a nested
3406 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3408 * class.cs: Refactoring.
3409 (IMethodData): New inteface; Holds links to parent members
3410 to avoid member duplication (reduced memory allocation).
3411 (Method): Implemented IMethodData interface.
3412 (PropertyBase): New inner classes for get/set methods.
3413 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3414 (Event): New inner classes for add/remove methods.
3415 (Event.DelegateMethod): Implemented IMethodData interface.
3417 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3418 EmitContext (related to class.cs refactoring).
3420 2004-04-21 Raja R Harinath <rharinath@novell.com>
3422 * delegate.cs (Delegate.VerifyApplicability): If the number of
3423 arguments are the same as the number of parameters, first try to
3424 verify applicability ignoring any 'params' modifier on the last
3428 2004-04-16 Raja R Harinath <rharinath@novell.com>
3430 * class.cs (TypeContainer.AddIndexer): Use
3431 'ExplicitInterfaceName' to determine if interface name was
3432 explicitly specified. 'InterfaceType' is not initialized at this time.
3433 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3434 Indexers array is already in the required order. Initialize
3435 'IndexerName' only if there are normal indexers.
3436 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3437 (TypeContainer.Emit): Emit DefaultMember attribute only if
3438 IndexerName is initialized.
3441 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3443 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3446 2004-04-15 Raja R Harinath <rharinath@novell.com>
3448 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3452 * attribute.cs (Attribute.Resolve): Check for duplicate named
3456 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3458 * iterators.cs (MarkYield): track whether we are in an exception,
3459 and generate code accordingly. Use a temporary value to store the
3460 result for our state.
3462 I had ignored a bit the interaction of try/catch with iterators
3463 since their behavior was not entirely obvious, but now it is
3464 possible to verify that our behavior is the same as MS .NET 2.0
3468 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3470 * iterators.cs: Avoid creating temporaries if there is no work to
3473 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3474 Enumerations, use TypeManager.EnumToUnderlying and call
3477 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3480 (This.Emit): Use EmitContext.EmitThis to emit our
3483 (This.EmitAssign): Ditto.
3485 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3486 codepaths, we will move all the functionality into
3489 (FieldExpr.EmitAssign): Ditto.
3491 This fixes several hidden bugs that I uncovered while doing a code
3492 review of this today.
3494 * codegen.cs (EmitThis): reworked so the semantics are more clear
3495 and also support value types "this" instances.
3497 * iterators.cs: Changed so that for iterators in value types, we
3498 do not pass the value type as a parameter.
3500 Initialization of the enumerator helpers is now done in the caller
3501 instead of passing the parameters to the constructors and having
3502 the constructor set the fields.
3504 The fields have now `assembly' visibility instead of private.
3506 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3508 * expression.cs (Argument.Resolve): Check if fields passed as ref
3509 or out are contained in a MarshalByRefObject.
3511 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3512 another compiler type.
3514 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3516 * class.cs (Indexer.Define): use the new name checking method.
3517 Also, return false on an error.
3518 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3519 (is_identifier_[start/part]_character): make static.
3521 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3523 * expression.cs (Binary.ResolveOperator): Do no append strings
3524 twice: since we can be invoked more than once (array evaluation)
3525 on the same concatenation, take care of this here. Based on a fix
3526 from Ben (bug #56454)
3528 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3530 * codegen.cs: Fix another case where CS1548 must be reported (when
3531 delay-sign isn't specified and no private is available #56564). Fix
3532 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3533 error when MCS is used on the MS runtime and we need to delay-sign
3534 (which seems unsupported by AssemblyBuilder - see #56621).
3536 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3538 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3539 (TypeManager.ComputeNamespaces): Faster implementation for
3542 * compiler.csproj: Updated AssemblyName to mcs.
3544 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3546 * rootcontext.cs: Add new types to the boot resolution.
3548 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3549 MulticastDelegate is not allowed.
3551 * typemanager.cs: Add new types to lookup: System.TypedReference
3554 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3555 check for TypedReference or ArgIterator, they are not allowed.
3557 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3558 makes us properly catch 1510 in some conditions (see bug 56016 for
3561 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3563 * CryptoConvert.cs: update from corlib version
3566 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3568 * class.cs (Indexer.Define): Check indexername declaration
3570 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3572 * attribute.cs (IsClsCompliant): Fixed problem with handling
3573 all three states (compliant, not-compliant, undetected).
3575 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3577 * attribute.cs (Attribute): Location is now public.
3578 (Resolve): Store resolved arguments (pos_values) in attribute class.
3579 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3580 (GetClsCompliantAttributeValue): New method that gets
3581 CLSCompliantAttribute value.
3582 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3583 if exists else null.
3584 (AttributeTester): New class for CLS-Compliant verification routines.
3586 * class.cs (Emit): Add CLS-Compliant verification.
3587 (Method.GetSignatureForError): Implemented.
3588 (Constructor.GetSignatureForError): Implemented
3589 (Constructor.HasCompliantArgs): Returns if constructor has
3590 CLS-Compliant arguments.
3591 (Constructor.Emit): Override.
3592 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3593 is needed to test only parameters.
3594 (FieldBase.GetSignatureForError): Implemented.
3595 (TypeContainer): New member for storing base interfaces.
3596 (TypeContainer.FindMembers): Search in base interfaces too.
3598 * codegen.cs (GetClsComplianceAttribute): New method that gets
3599 assembly or module CLSCompliantAttribute value.
3600 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3602 (ModuleClass.Emit): Add error 3012 test.
3604 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3606 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3607 state for all decl types.
3608 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3609 if CLS-Compliant tests are required.
3610 (IsClsCompliaceRequired): New method. Analyze whether code
3611 must be CLS-Compliant.
3612 (IsExposedFromAssembly): New method. Returns true when MemberCore
3613 is exposed from assembly.
3614 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3615 value or gets cached value.
3616 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3617 is explicitly marked with CLSCompliantAttribute.
3618 (IsIdentifierClsCompliant): New abstract method. This method is
3619 used to testing error 3005.
3620 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3621 for identifier and parameters CLS-Compliant testing.
3622 (VerifyClsCompliance): New method. The main virtual method for
3623 CLS-Compliant verifications.
3624 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3625 null. I don't know why is null (too many public members !).
3626 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3627 and get value of first CLSCompliantAttribute that found.
3629 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3630 (VerifyClsCompliance): Override and add extra tests.
3632 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3633 clscheck- disable CLS-Compliant verification event if assembly is has
3634 CLSCompliantAttribute(true).
3636 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3637 ApllyAttribute is now called in emit section as in the other cases.
3638 Possible future Emit integration.
3639 (IsIdentifierClsCompliant): New override.
3640 (VerifyClsCompliance): New override.
3641 (GetEnumeratorName): Returns full enum name.
3643 * parameter.cs (GetSignatureForError): Implemented.
3645 * report.cs (WarningData): New struct for Warning message information.
3646 (LocationOfPreviousError): New method.
3647 (Warning): New method. Reports warning based on the warning table.
3648 (Error_T): New method. Reports error based on the error table.
3650 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3651 verifications are done here.
3653 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3655 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3656 CLSCompliantAttribute.
3657 (all_imported_types): New member holds all imported types from other
3659 (LoadAllImportedTypes): New method fills static table with exported types
3660 from all referenced assemblies.
3661 (Modules): New property returns all assembly modules.
3663 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3665 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3666 throwing a parser error.
3668 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3669 which removes the hardcoded get_/set_ prefixes for properties, as
3670 IL allows for the properties to be named something else.
3674 * expression.cs: Do not override operand before we know if it is
3677 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3679 * typemanager.cs: support for pinned variables.
3681 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3683 * decl.cs, typemanager.cs: Avoid using an arraylist
3684 as a buffer if there is only one result set.
3686 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3688 * expression.cs: Make sure you cant call a static method
3689 with an instance expression, bug #56174.
3691 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3693 * class.cs (IsDuplicateImplementation): Improve error reporting to
3694 flag 663 (method only differs in parameter modifier).
3696 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3697 in preprocessor directives.
3699 * location.cs (LookupFile): Allow for the empty path.
3701 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3702 better approach for some of that patch, but its failing with the
3703 CharSet enumeration. For now try/catch will do.
3705 * typemanager.cs: Do not crash if a struct does not have fields.
3708 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3710 * expression.cs: cs0213, cant fix a fixed expression.
3713 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3715 * cs-parser.jay: detect invalid embeded statements gracefully.
3718 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3720 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3723 the invocation type may not be a subclass of the tye of the item/
3724 The type of the item must be a subclass of the invocation item.
3729 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3731 * attribute.cs: Added methods to get a string and a bool from an
3732 attribute. Required to information from AssemblyKeyFileAttribute,
3733 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3734 * codegen.cs: Modified AssemblyName creation to include support for
3735 strongnames. Catch additional exceptions to report them as CS1548.
3736 * compiler.csproj: Updated include CryptoConvert.cs.
3737 * compiler.csproj.user: Removed file - user specific configuration.
3738 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3739 Mono.Security assembly. The original class is maintained and tested in
3740 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3741 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3742 like CSC 8.0 (C# v2) supports.
3743 * Makefile: Added CryptoConvert.cs to mcs sources.
3744 * rootcontext.cs: Added new options for strongnames.
3746 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3748 * driver.cs: For --expect-error, report error code `2'
3749 if the program compiled with no errors, error code `1' if
3750 it compiled with an error other than the one expected.
3752 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3754 * compiler.csproj: Updated for Visual Studio .NET 2003.
3755 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3756 * compiler.sln: Updated for Visual Studio .NET 2003.
3758 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3760 * expression.cs: Fix bug #47234. We basically need to apply the
3761 rule that we prefer the conversion of null to a reference type
3762 when faced with a conversion to 'object' (csc behaviour).
3764 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3766 * statement.cs: Shorter form for foreach, eliminates
3767 a local variable. r=Martin.
3769 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3771 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3772 checks if we can use brtrue/brfalse to test for 0.
3773 * expression.cs: use the above in the test for using brtrue/brfalse.
3776 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3778 * expression.cs: Rewrite string concat stuff. Benefits:
3780 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3781 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3782 rather than a concat chain.
3784 * typemanager.cs: Add lookups for more concat overloads.
3786 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3788 * expression.cs: Emit shorter il code for array init.
3805 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3807 * statement.cs: Before, two switch blocks would be merged if the
3808 total size of the blocks (end_item - begin_item + 1) was less than
3809 two times the combined sizes of the blocks.
3811 Now, it will only merge if after the merge at least half of the
3816 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3818 * class.cs : csc build fix for GetMethods(). See bug #52503.
3820 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3822 * expression.cs: Make sure fp comparisons work with NaN.
3823 This fixes bug #54303. Mig approved this patch a long
3824 time ago, but we were not able to test b/c the runtime
3827 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3829 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3831 2004-03-19 Martin Baulig <martin@ximian.com>
3833 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3834 error here and not in our caller.
3836 2004-03-19 Martin Baulig <martin@ximian.com>
3838 * interface.cs: Completely killed this file.
3839 (Interface): We're now a TypeContainer and live in class.cs.
3841 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3842 argument; we're now also called for interfaces.
3843 (TypeContainer.DefineMembers): Allow this method being called
3845 (TypeContainer.GetMethods): New public method; formerly known as
3846 Interface.GetMethod(). This is used by PendingImplementation.
3847 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3848 it's now private and non-static.
3849 (Interface): Moved this here; it's now implemented similar to
3851 (Method, Property, Event, Indexer): Added `bool is_interface'
3852 argument to their .ctor's.
3853 (MemberBase.IsInterface): New public field.
3855 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3856 instances instead of InterfaceMethod, InterfaceProperty, etc.
3857 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3858 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3860 2004-03-19 Martin Baulig <martin@ximian.com>
3862 * class.cs (MethodCore.IsDuplicateImplementation): New private
3863 method which does the CS0111 checking.
3864 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3865 Use IsDuplicateImplementation().
3867 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3869 * decl.cs (FindMemberToOverride): New method to find the correct
3870 method or property to override in the base class.
3872 - Make Method/Property use the above method to find the
3873 version in the base class.
3874 - Remove the InheritableMemberSignatureCompare as it is now
3877 This patch makes large code bases much faster to compile, as it is
3878 O(n) rather than O(n^2) to do this validation.
3880 Also, it fixes bug 52458 which is that nested classes are not
3881 taken into account when finding the base class member.
3883 Reviewed/Approved by Martin.
3885 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3887 * interface.cs: In all interface classes removed redundant
3888 member initialization.
3890 2004-03-16 Martin Baulig <martin@ximian.com>
3892 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3894 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3896 * decl.cs (DefineTypeAndParents): New helper method to define a
3897 type's containers before the type itself is defined; This is a
3898 bug exposed by the recent changes to Windows.Forms when an
3899 implemented interface was defined inside a class that had not been
3902 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3904 (Check): Loop correctly to report errors modifiers
3905 (UNSAFE was not in the loop, since it was the same as TOP).
3907 * interface.cs: Every interface member now takes a ModFlags,
3908 instead of a "is_new" bool, which we set on the base MemberCore.
3910 Every place where we called "UnsafeOk" in the interface, now we
3911 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3912 the unsafe settings from the member declaration instead of the
3913 container interface.
3915 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3917 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3918 `set_indexer_name' to the pending bits (one per type).
3920 We fixed a bug today that was picking the wrong method to
3921 override, since for properties the existing InterfaceMethod code
3922 basically ignored the method name. Now we make sure that the
3923 method name is one of the valid indexer names.
3925 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3927 * support.cs (SeekableStreamReader): Keep track of stream byte
3928 positions and don't mix them with character offsets to the buffer.
3930 Patch from Gustavo Giráldez
3932 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3934 * interface.cs (InterfaceSetGetBase): Removed double member
3935 initialization, base class does it as well.
3937 2004-03-13 Martin Baulig <martin@ximian.com>
3939 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3940 when compiling corlib.
3942 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3944 * convert.cs (ExplicitConversion): We were reporting an error on
3945 certain conversions (object_type source to a value type, when the
3946 expression was `null') before we had a chance to pass it through
3947 the user defined conversions.
3949 * driver.cs: Replace / and \ in resource specifications to dots.
3952 * class.cs: Add check for duplicate operators. Fixes 52477
3954 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3956 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
3957 that are in the middle of the statements, not only at the end.
3960 * class.cs (TypeContainer.AddField): No longer set the
3961 `HaveStaticConstructor' flag, now we call it
3962 `UserDefineStaticConstructor' to diferentiate the slightly
3963 semantic difference.
3965 The situation is that we were not adding BeforeFieldInit (from
3966 Modifiers.TypeAttr) to classes that could have it.
3967 BeforeFieldInit should be set to classes that have no static
3972 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
3974 And most importantly Zoltan's comment:
3976 http://bugzilla.ximian.com/show_bug.cgi?id=44229
3978 "I think beforefieldinit means 'it's ok to initialize the type sometime
3979 before its static fields are used', i.e. initialization does not need
3980 to be triggered by the first access to the type. Setting this flag
3981 helps the JIT to compile better code, since it can run the static
3982 constructor at JIT time, and does not need to generate code to call it
3983 (possibly lots of times) at runtime. Unfortunately, mcs does not set
3984 this flag for lots of classes like String.
3986 csc sets this flag if the type does not have an explicit static
3987 constructor. The reasoning seems to be that if there are only static
3988 initalizers for a type, and no static constructor, then the programmer
3989 does not care when this initialization happens, so beforefieldinit
3992 This bug prevents the AOT compiler from being usable, since it
3993 generates so many calls to mono_runtime_class_init that the AOT code
3994 is much slower than the JITted code. The JITted code is faster,
3995 because it does not generate these calls if the vtable is type is
3996 already initialized, which is true in the majority of cases. But the
3997 AOT compiler can't do this."
3999 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4001 * class.cs (MethodData.Emit): Refactor the code so symbolic
4002 information is generated for destructors; For some reasons we
4003 were taking a code path that did not generate symbolic information
4006 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4008 * class.cs: Create a Constructor.CheckBase method that
4009 takes care of all validation type code. The method
4010 contains some code that was moved from Define.
4012 It also includes new code that checks for duplicate ctors.
4013 This fixes bug #55148.
4015 2004-03-09 Joshua Tauberer <tauberer@for.net>
4017 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4018 a { ... }-style array creation invokes EmitStaticInitializers
4019 which is not good for reference-type arrays. String, decimal
4020 and now null constants (NullCast) are not counted toward
4021 static initializers.
4023 2004-03-05 Martin Baulig <martin@ximian.com>
4025 * location.cs (SourceFile.HasLineDirective): New public field;
4026 specifies whether the file contains or is referenced by a "#line"
4028 (Location.DefineSymbolDocuments): Ignore source files which
4029 either contain or are referenced by a "#line" directive.
4031 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4033 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4034 direct access to our parent, so check the method inline there.
4036 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4038 * expression.cs (Invocation.EmitCall): Miguel's last commit
4039 caused a regression. If you had:
4044 In Foo the implict this would be null.
4046 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4048 * expression.cs (Invocation.EmitCall): If the method is not
4049 virtual, do not emit a CallVirt to it, use Call.
4051 * typemanager.cs (GetFullNameSignature): Improve the method to
4052 cope with ".ctor" and replace it with the type name.
4054 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4055 as an argument the ConstructorBuilder where it is being defined,
4056 to catch the recursive constructor invocations.
4058 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4060 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4061 routines to check if a type is an enumerable/enumerator allow
4062 classes that implement the IEnumerable or IEnumerator interfaces.
4064 * class.cs (Property, Operator): Implement IIteratorContainer, and
4065 implement SetYields.
4067 (Property.Define): Do the block swapping for get_methods in the
4068 context of iterators. We need to check if Properties also
4069 include indexers or not.
4071 (Operator): Assign the Block before invoking the
4072 OperatorMethod.Define, so we can trigger the Iterator code
4075 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4076 Property and Operator classes are not created when we parse the
4077 declarator but until we have the block completed, so we use a
4078 singleton SimpleIteratorContainer.Simple to flag whether the
4079 SetYields has been invoked.
4081 We propagate this setting then to the Property or the Operator to
4082 allow the `yield' to function.
4084 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4086 * codegen.cs: Implemented attribute support for modules.
4087 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4088 Assembly/Module functionality.
4090 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4091 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4092 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4094 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4096 * interface.cs (FindMembers): The operation is performed on all base
4097 interfaces and not only on the first. It is required for future CLS Compliance patch.
4099 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4101 * statement.cs, codegen.cs:
4102 This patch deals with patterns such as:
4104 public class List : IEnumerable {
4106 public MyEnumerator GetEnumerator () {
4107 return new MyEnumerator(this);
4110 IEnumerator IEnumerable.GetEnumerator () {
4114 public struct MyEnumerator : IEnumerator {
4119 Before, there were a few things we did wrong:
4120 1) we would emit callvirt on a struct, which is illegal
4121 2) we emited ldarg when we needed to emit ldarga
4122 3) we would mistakenly call the interface methods on an enumerator
4123 type that derived from IEnumerator and was in another assembly. For example:
4125 public class MyEnumerator : IEnumerator
4127 Would have the interface methods called, even if there were public impls of the
4128 method. In a struct, this lead to invalid IL code.
4130 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4132 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4135 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4137 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4139 * cs-parser.jay: Fix small regression: we were not testing V2
4140 compiler features correctly.
4142 * interface.cs: If the emit context is null, then create one
4144 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4146 * decl.cs (GetSignatureForError): New virtual method to get full name
4149 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4150 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4152 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4153 Duplicated members and code in these classes has been removed.
4154 Better encapsulation in these classes.
4156 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4158 * assign.cs (Assign.DoResolve): When dealing with compound
4159 assignments, there is a new rule in ECMA C# 2.4 (might have been
4160 there before, but it is documented here) that states that in:
4164 If b is of type int, and the `op' is a shift-operator, then the
4165 above is evaluated as:
4169 * expression.cs (Binary.ResolveOperator): Instead of testing for
4170 int/uint/long/ulong, try to implicitly convert to any of those
4171 types and use that in pointer arithmetic.
4173 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4174 method to print information for from the type, not from the
4175 null-method we were given.
4177 2004-02-01 Duncan Mak <duncan@ximian.com>
4179 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4180 parsing for cmd, fixes bug #53694.
4182 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4184 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4185 in the member name duplication tests. Property and operator name duplication
4186 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4188 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4190 * interface.cs (PopulateMethod): Fixed crash when interface method
4191 returns not existing type (error test cs0246-3.cs).
4193 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4195 * cs-parser.jay (interface_accessors): Re-write actions to also
4196 store attributes attached to get and set methods. Fix spelling
4199 (inteface_property_declaration): Modify accordingly.
4201 (InterfaceAccessorInfo): New helper class to store information to pass
4202 around between rules that use interface_accessors.
4204 * interface.cs (Emit): Apply attributes on the get and set
4205 accessors of properties and indexers too.
4207 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4208 right MethodBuilder when applying attributes to the get and set accessors.
4210 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4212 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4214 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4216 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4218 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4220 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4221 changes that treat `yield' specially when present before `break'
4224 * cs-tokenizer.cs: yield is no longer a keyword.
4226 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4228 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4229 setting for default constructors.
4230 For default constructors are almost every time set wrong Modifier. The
4231 generated IL code has been alright. But inside mcs this values was
4232 wrong and this was reason why several of my CLS Compliance tests
4235 2004-01-22 Martin Baulig <martin@ximian.com>
4237 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4238 not a QualifiedIdentifier. This is what `type_name_expression'
4239 was previously doing.
4240 (type_name_expression): Removed; the code is now in
4241 `namespace_or_type_name'.
4242 (qualified_identifier): Removed, use `namespace_or_type_name'
4244 (QualifiedIdentifier): Removed this class.
4246 2004-01-22 Martin Baulig <martin@ximian.com>
4248 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4249 not a string as alias name.
4251 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4253 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4254 #52730 bug, and instead compute correctly the need to use a
4255 temporary variable when requesting an address based on the
4256 static/instace modified of the field and the constructor.
4258 2004-01-21 Martin Baulig <martin@ximian.com>
4260 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4261 class and namespace before looking up aliases. Fixes #52517.
4263 2004-01-21 Martin Baulig <martin@ximian.com>
4265 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4266 assinged in a 'try'; fixes exception4.cs.
4268 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4269 * class.cs : Implemented parameter-less constructor for TypeContainer
4271 * decl.cs: Attributes are now stored here. New property OptAttributes
4273 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4275 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4277 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4279 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4280 (CSharpSignature): New method for indexer and property signature.
4282 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4284 * pending.cs (IsVirtualFilter): Faster implementation.
4286 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4288 * typemanager.cs: Avoid inclusion of same assembly more than once.
4290 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4292 * cs-parser.jay: Fixed problem where the last assembly attribute
4293 has been applied also to following declaration (class, struct, etc.)
4295 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4297 * class.cs: Added error CS0538, CS0539 reporting.
4298 Fixed crash on Microsoft runtime when field type is void.
4300 * cs-parser.jay: Added error CS0537 reporting.
4302 * pending.cs: Added error CS0535 reporting.
4303 Improved error report for errors CS0536, CS0534.
4305 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4307 Merge a few bits from the Anonymous Method MCS tree.
4309 * statement.cs (ToplevelBlock): New class for toplevel methods,
4310 will hold anonymous methods, lifted variables.
4312 * cs-parser.jay: Create toplevel blocks for delegates and for
4313 regular blocks of code.
4315 2004-01-20 Martin Baulig <martin@ximian.com>
4317 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4318 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4319 and `NeedExplicitReturn'; added `IsLastStatement'.
4320 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4321 have a `ReturnLabel' or we're not unreachable.
4323 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4324 child's reachability; don't just override ours with it. Fixes
4325 #58058 (lluis's example).
4326 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4327 InFinally(), InLoop(), InSwitch() and
4328 BreakCrossesTryCatchBoundary() methods.
4330 * statement.cs (Return): Do all error checking in Resolve().
4331 Unless we are the last statement in a top-level block, always
4332 create a return label and jump to it.
4333 (Break, Continue): Do all error checking in Resolve(); also make
4334 sure we aren't leaving a `finally'.
4335 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4336 statement in a top-level block.
4337 (Block.Flags): Added `IsDestructor'.
4338 (Block.IsDestructor): New public property.
4340 2004-01-20 Martin Baulig <martin@ximian.com>
4342 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4344 2004-01-20 Martin Baulig <martin@ximian.com>
4346 * statement.cs (Statement.ResolveUnreachable): New public method.
4347 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4348 (Block.Resolve): Resolve unreachable statements.
4350 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4352 * expression.cs: We need to fix the case where we do
4353 not have a temp variable here.
4355 * assign.cs: Only expression compound assignments need
4356 temporary variables.
4358 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4360 * flowanalysis.cs: Reduce memory allocation in a few ways:
4361 - A block with no variables should not allocate a bit
4363 - A method with no out parameters does not need any tracking
4364 for assignment of the parameters, so we need not allocate
4367 public readonly Type[] VariableTypes;
4368 public readonly string[] VariableNames;
4369 Are redundant. The data is already stored in the variable
4370 map, so we need not allocate another array for it.
4371 - We need to add alot of checks for if (params | locals) == null
4372 due to the first two changes.
4374 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4376 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4377 implement IMemoryLocation, we store a copy on a local variable and
4378 take the address of it. Patch from Benjamin Jemlich
4380 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4381 to use a special "type_name_expression" rule which reduces the
4382 number of "QualifiedIdentifier" classes created, and instead
4383 directly creates MemberAccess expressions.
4385 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4387 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4388 that fixes #52853. Null literal assignment to ValueType
4390 * class.cs (MethodData.Emit): Instead of checking the name of the
4391 method to determine if its a destructor, create a new derived
4392 class from Method called Destructor, and test for that.
4394 * cs-parser.jay: Create a Destructor object instead of a Method.
4396 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4400 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4402 * expression.cs (Binary.ResolveOperator): Perform an implicit
4403 conversion from MethodGroups to their delegate types on the
4406 * delegate.cs: Introduce a new class DelegateCreation that is the
4407 base class for `NewDelegate' and `ImplicitDelegateCreation',
4408 factor some code in here.
4410 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4411 conversion from MethodGroups to compatible delegate types.
4413 * ecore.cs (Expression.Resolve): Do not flag error 654
4414 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4415 we allow conversions from MethodGroups to delegate types now.
4417 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4418 assignments in v2 either.
4420 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4422 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4423 static read-only fields in ctors.
4425 Applied patch from Benjamin Jemlich
4427 * expression.cs (UnaryMutator): Avoid leaking local variables.
4429 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4431 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4432 here to return true, as they can be used like this:
4436 Fixed 49836 and all the other dups
4438 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4440 * driver.cs: Implement /win32res and /win32icon.
4442 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4444 * cs-parser.jay: Add a rule to improve error handling for the
4445 common mistake of placing modifiers after the type.
4447 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4449 * cs-parser.jay (interface_event_declaration): Catch
4450 initialization of events on interfaces, and report cs0068
4452 * cs-parser.jay (interface_event_declaration): Catch
4453 initialization of events.
4455 * ecore.cs: Better report missing constructors.
4457 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4458 the error reporting done in the wrong place. Fix.
4460 * expression.cs (Binary.ResolveOperator): Catch the
4461 operator + (E x, E y) error earlier, and later allow for implicit
4462 conversions in operator +/- (E e, U x) from U to the underlying
4465 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4466 52596, if the container class is abstract, the default constructor
4467 is protected otherwise its public (before, we were always public).
4469 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4472 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4473 Jemlich that fixes bug #52597, MCS was generating invalid code for
4474 idisposable structs. Thanks to Ben for following up with this
4477 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4479 * driver.cs: Allow assemblies without code to be generated, fixes
4482 2004-01-07 Nick Drochak <ndrochak@gol.com>
4484 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4486 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4488 * cs-parser.jay: Add rules to improve error reporting if fields or
4489 methods are declared at the namespace level (error 116)
4491 * Add rules to catch event add/remove
4493 2004-01-04 David Sheldon <dave-mono@earth.li>
4495 * expression.cs: Added matching ")" to error message for
4498 2004-01-03 Todd Berman <tberman@gentoo.org>
4500 * ecore.cs, attribute.cs:
4501 Applying fix from #52429.
4503 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4505 * ecore.cs, expression.cs, statement.cs:
4506 Total rewrite of how we handle branching. We
4507 now handle complex boolean expressions with fewer
4508 jumps. As well if (x == 0) no longer emits a ceq.
4510 if (x is Foo) is much faster now, because we generate
4513 Overall, we get a pretty big improvement on our benchmark
4514 tests. The code we generate is smaller and more readable.
4516 I did a full two-stage bootstrap. The patch was reviewed
4517 by Martin and Miguel.
4519 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4521 * cs-parser.jay: Make primary_expression not take a QI.
4522 we dont need this because the member_access rule covers
4523 us here. So we replace the rule with just IDENTIFIER.
4525 This has two good effects. First, we remove a s/r conflict.
4526 Second, we allocate many fewer QualifiedIdentifier objects.
4528 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4530 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4531 set the correct information via SRE. This prevents
4532 hanging on the MS runtime. Fixes #29374.
4534 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4536 * convert.cs: correctly handle conversions to value types
4537 from Enum and ValueType as unboxing conversions.
4539 Fixes bug #52569. Patch by Benjamin Jemlich.
4541 2004-01-02 Ravi Pratap <ravi@ximian.com>
4543 * expression.cs (BetterConversion): Prefer int -> uint
4544 over int -> ulong (csc's behaviour). This fixed bug #52046.
4546 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4548 * decl.cs (MemberCache.FindMembers): now returns a
4551 * typemanager.cs: In general, go with with ^^.
4552 (CopyNewMethods): take an IList.
4553 (RealMemberLookup): Only allocate an arraylist
4554 if we copy from two sets of methods.
4556 This change basically does two things:
4557 1) Fewer array lists allocated due to CopyNewMethods.
4558 2) the explicit cast in MemberList costed ALOT.
4560 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4562 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4563 a hashtable to avoid needless string allocations when an identifier is
4564 used more than once (the common case).
4566 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4568 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4569 is broken, it will not return anything. So, we
4570 have to use the information we have in mcs to
4573 * typemanager.cs: Add a cache for GetInterfaces,
4574 since this will now be used more often (due to ^^)
4576 (GetExplicitInterfaces) New method that gets the
4577 declared, not effective, interfaces on a type
4578 builder (eg, if you have interface IFoo, interface
4579 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4582 This patch makes MCS able to bootstrap itself on
4585 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4587 * expression.cs: Remove the Nop's that Miguel put
4590 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4592 * report.cs, codegen.cs: Give the real stack trace to
4593 the error when an exception is thrown.
4595 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4597 * decl.cs: only allocate hashtables for ifaces if
4600 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4602 * expression.cs: fix the error from cs0121-2.cs
4603 (a parent interface has two child interfaces that
4604 have a function with the same name and 0 params
4605 and the function is called through the parent).
4607 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4609 * class.cs, rootcontext.cs, typmanager.cs: do not
4612 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4614 * codegen.cs: remove stack for the ec flow branching.
4615 It is already a linked list, so no need.
4617 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4619 * Makefile: Allow custom profiler here.
4621 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4623 * typemanager.cs (LookupType):
4624 - Use a static char [], because split takes
4625 a param array for args, so it was allocating
4627 - Do not store true in a hashtable, it boxes.
4629 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4631 * flowanalysis.cs: bytify common enums.
4633 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4635 * modifiers.cs: Add a new set of flags for the
4636 flags allowed on explicit interface impls.
4637 * cs-parser.jay: catch the use of modifiers in
4638 interfaces correctly.
4639 * class.cs: catch private void IFoo.Blah ().
4641 All related to bug #50572.
4643 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4645 * decl.cs: Rewrite the consistant accessability checking.
4646 Accessability is not linear, it must be implemented in
4647 a tableish way. Fixes #49704.
4649 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4651 * expression.cs: Handle negation in a checked context.
4652 We must use subtraction from zero. Fixes #38674.
4654 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4656 * class.cs: Ignore static void main in DLLs.
4657 * rootcontext.cs: Handle the target type here,
4658 since we are have to access it from class.cs
4659 * driver.cs: account for the above.
4661 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4663 * report.cs: Give line numbers and files if available.
4665 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4667 * driver.cs: Implement /addmodule.
4669 * typemanager.cs: Change 'modules' field so it now contains Modules not
4672 2003-12-20 Martin Baulig <martin@ximian.com>
4674 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4675 (FieldBase.IsAssigned): Removed this field.
4676 (FieldBase.SetAssigned): New public method.
4677 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4679 2003-12-20 Martin Baulig <martin@ximian.com>
4681 * expression.cs (LocalVariableReference.DoResolve): Don't set
4682 `vi.Used' if we're called from DoResolveLValue().
4684 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4685 returns the usage vector it just merged into the current one -
4686 pass this one to UsageWarning().
4687 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4688 of the `EmitContext', don't call this recursively on our children.
4690 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4692 * driver.cs: Implement /target:module.
4694 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4696 * support.cs (CharArrayHashtable): New helper class.
4698 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4699 char arrays, not strings, so we can avoid creating a string in
4700 consume_identifier if the identifier is a keyword.
4702 2003-12-16 Martin Baulig <martin@ximian.com>
4704 * statement.cs (LocalInfo.Assigned): Removed this property.
4705 (LocalInfo.Flags): Removed `Assigned'.
4706 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4707 and uses flow analysis.
4708 (Block.UsageWarning): Made this method private.
4709 (Block.Resolve): Call UsageWarning() if appropriate.
4711 * expression.cs (LocalVariableReference.DoResolve): Always set
4712 LocalInfo.Used here.
4714 2003-12-13 Martin Baulig <martin@ximian.com>
4716 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4717 any value here; we're now using flow analysis to figure out
4718 whether a statement/block returns a value.
4720 2003-12-13 Martin Baulig <martin@ximian.com>
4722 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4724 (FlowBranching.MergeFinally): Don't call
4725 `branching.CheckOutParameters()' here, this is called in
4727 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4728 when adding the `finally' vector.
4730 2003-12-13 Martin Baulig <martin@ximian.com>
4733 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4734 actually work and also fix #48962.
4736 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4738 * decl.cs: Do not check System.Object for nested types,
4739 since we know it does not have any. Big bang for buck:
4744 corlib: 17.99 seconds
4748 corlib: 17.39 seconds
4750 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4752 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4753 time we are returning 0 members, so we save alot here.
4755 2003-12-11 Martin Baulig <martin@ximian.com>
4757 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4758 `MergeChild()', also just take the `FlowBranching' as argument;
4759 call Merge() on it and return the result.
4760 (FlowBranching.Merge): We don't need to do anything if we just
4763 2003-12-11 Martin Baulig <martin@ximian.com>
4765 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4766 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4767 Maurer for this idea.
4769 2003-12-11 Martin Baulig <martin@ximian.com>
4771 * flowanalysis.cs (MergeResult): This class is now gone; we now
4772 use the `UsageVector' for this. The reason for this is that if a
4773 branching just has one sibling, we don't need to "merge" them at
4774 all - that's the next step to do.
4775 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4778 2003-12-11 Martin Baulig <martin@ximian.com>
4780 Reworked flow analyis and made it more precise and bug-free. The
4781 most important change is that we're now using a special `Reachability'
4782 class instead of having "magic" meanings of `FlowReturns'. I'll
4783 do some more cleanups and optimizations and also add some more
4784 documentation this week.
4786 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4787 largely reworked this class.
4788 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4789 the new `Reachability' class instead of having "magic" values here.
4790 (FlowBranching): We're now using an instance of `Reachability'
4791 instead of having separate `Returns', `Breaks' etc. fields.
4793 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4794 based on flow analysis; ignore the return value of block.Emit ().
4796 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4798 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4799 if they are private.
4801 2003-12-09 Martin Baulig <martin@ximian.com>
4803 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4804 call them directly on the UsageVector.
4806 2003-12-09 Martin Baulig <martin@ximian.com>
4808 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4809 Changed return type from `FlowReturns' to `Reachability'.
4811 2003-12-09 Martin Baulig <martin@ximian.com>
4813 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4814 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4815 `Reachable' fields with a single `Reachability' one.
4817 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4819 * class.cs (FindMembers): Remove foreach's.
4832 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4837 This patch does a few things:
4838 1. EmptyStatement is now a singleton, so it is never reallocated.
4839 2. All blah is EmptyStatement constructs have been changed to
4840 blah == EmptyStatement.Value, which is much faster and valid
4841 now that EmptyStatement is a singleton.
4842 3. When resolving a block, rather than allocating a new array for
4843 the non-empty statements, empty statements are replaced with
4844 EmptyStatement.Value
4845 4. Some recursive functions have been made non-recursive.
4846 Mainly the performance impact is from (3), however (1) and (2) are needed for
4847 this to work. (4) does not make a big difference in normal situations, however
4848 it makes the profile look saner.
4853 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4854 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4855 Total memory allocated: 56397 KB
4858 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4859 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4860 Total memory allocated: 55666 KB
4862 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4864 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4865 than the hashtable in a hashtable version
4867 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4868 we always end up concating a string. This results in a huge perf
4869 loss, because many strings have to be tracked by the GC. In this
4870 patch, we first use a hashtable that works with two keys, so that
4871 the strings do not need to be concat'ed.
4882 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4884 * Makefile: Add a new target `do-time' that does a quick and simple
4885 profile, leaving easy to parse output.
4887 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4889 * codegen.cs (Init): Create the dynamic assembly with
4890 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4892 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4894 * support.cs: Make the PtrHashtable use only one
4895 instance of its comparer.
4897 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4899 * typemanager.cs: Fix lookup of GetNamespaces.
4901 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4903 * expression.cs: Removed redundant line.
4905 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4906 ArrayLists, use for loops with bounds.
4908 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4911 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4912 arraylists, use for loop with bounds.
4914 The above three changes give us a 0.071 second performance
4915 improvement out of 3.294 seconds down to 3.223. On my machine
4916 the above changes reduced the memory usage by 1,387 KB during
4919 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4920 QualifiedIdentifiers. Before we created a new string through
4921 concatenation, and mostly later on, the result would be
4922 manipulated by DecomposeQI through string manipulation.
4924 This reduced the compiler memory usage for bootstrapping from
4925 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4926 compile times in 0.05 seconds.
4928 2003-11-28 Dick Porter <dick@ximian.com>
4930 * support.cs: Do string compares with the Invariant culture.
4938 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4939 the comparison is done with the Invariant culture.
4941 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4943 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4944 GetEnumerator method.
4946 (ProbeCollectionType): Iterate starting at the most specific type
4947 upwards looking for a GetEnumerator
4949 * expression.cs: Shift count can be up to 31 for int/uint and 63
4952 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4954 * statement.cs (Block.LookupLabel): Also look for the label on the
4955 children blocks. Use a hash table to keep track of visited
4958 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
4959 we actually did transform the other operand, otherwise fall back
4960 to the common codepath that casts to long.
4962 * cs-tokenizer.cs: Use the same code pattern as the int case.
4963 Maybe I should do the parsing myself, and avoid depending on the
4964 Parse routines to get this done.
4966 2003-11-25 Miguel de Icaza <miguel@ximian.com>
4968 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4969 which fixes bug 51347. This time test it.
4971 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
4972 attributes for example can not tell the difference between these.
4973 The difference was only a syntax feature of the language.
4975 * attribute.cs: Apply attributes to delegates.
4977 * delegate.cs: Call the apply attributes method.
4979 2003-11-24 Miguel de Icaza <miguel@ximian.com>
4981 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
4982 comparing 0 vs Byte.MinValue, not the value
4984 (ImplicitConversionRequired): When reporting a conversion error,
4985 use error 31 to print out the constant error instead of the
4988 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4989 which fixes bug 51347.
4991 2003-11-22 Miguel de Icaza <miguel@ximian.com>
4993 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
4994 which fixes the -warnaserror command line option.
4996 2003-11-21 Miguel de Icaza <miguel@ximian.com>
4998 * cfold.cs (DoNumericPromotions): During constant folding of
4999 additions on UIntConstant, special case intconstants with
5000 IntConstants like we do on the expression binary operator.
5002 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5004 * convert.cs (ImplicitReferenceConversion): We were missing a case
5005 (System.Enum are not value types or class types, so we need to
5006 classify them separatedly).
5008 * driver.cs: We do not support error 2007.
5010 2003-11-12 Jackson Harper <jackson@ximian.com>
5012 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5013 system directory. Also use the full file name so users can
5014 libraries names mscorlib-o-tron.dll in a non system dir.
5016 2003-11-10 Martin Baulig <martin@ximian.com>
5018 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5019 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5020 calling `ResolveType()' on them, directly assign their `Type'.
5022 2003-11-08 Martin Baulig <martin@ximian.com>
5024 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5025 return value and the `out parent' parameter.
5026 (TypeContainer.DefineType): Moved the CS0644 check into
5027 GetClassBases(). Don't pass the interface types to the
5028 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5029 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5031 * ecore.cs (TypeExpr.IsAttribute): New property.
5032 (TypeExpr.GetInterfaces): New method.
5034 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5035 TypeExpr instead of a Type.
5036 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5037 (Interface.DefineType): Don't pass the interface types to the
5038 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5039 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5041 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5042 instead of a `Type[]'.
5043 (TypeManager.RegisterBuilder): Likewise.
5044 (TypeManager.AddUserInterface): Likewise.
5045 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5046 `Type[]' and also return a `TypeExpr[]'.
5047 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5049 2003-11-08 Martin Baulig <martin@ximian.com>
5051 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5054 2003-11-08 Martin Baulig <martin@ximian.com>
5056 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5057 TypeManager.ResolveExpressionTypes().
5059 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5060 instead of an Expression.
5061 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5062 (TypeExpression): New public class; formerly known as `TypeExpr'.
5064 * expression.cs (ComposedCast): Derive from TypeExpr.
5066 * typemanager.cs (TypeManager.system_*_expr): These are now
5067 TypExpr's instead of Expression's.
5068 (TypeManager.ResolveExpressionTypes): New public static function;
5069 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5072 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5074 * expression.cs (New.DoResolve): Do not dereference value that
5075 might be a null return.
5077 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5078 sure that the constant value has the right type. Fixes an
5079 unreported bug, similar to 50425.
5081 * const.cs (Const.LookupConstantValue): Call
5082 ImplicitStandardConversionExists before doing a conversion to
5083 avoid havng the TypeManager.ChangeType do conversions.
5085 Reduced the number of casts used
5087 (Const.ChangeType): New routine to enable reuse of the constant
5088 type changing code from statement.
5090 * typemanager.cs (ChangeType): Move common initialization to
5091 static global variables.
5095 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5096 every value type to go through, even if it was void. Fix that.
5098 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5099 character of the define, and the is_identifier_part_character for
5100 the rest of the string.
5102 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5104 * expression.cs (UnaryMutator.EmitCode): When I updated
5105 LocalVariableReference.DoResolve, I overdid it, and dropped an
5106 optimization done on local variable references.
5108 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5110 * ecore.cs: Convert the return from Ldlen into an int.
5112 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5114 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5115 the accessibility, this is a special case for toplevel non-public
5116 classes (internal for instance).
5118 2003-10-20 Nick Drochak <ndrochak@gol.com>
5120 * ecore.cs: Fix typo and build. Needed another right paren.
5122 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5124 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5125 `internal' case regular and protected, but not allowing protected
5126 to be evaluated later. Bug 49840
5128 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5130 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5131 to kb.Nlast, and not the kb.nFirst to isolate the switch
5134 Extract the underlying type, so enumerations of long/ulong are
5135 treated like long/ulong.
5137 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5139 * expression.cs (New): Overload the meaning of RequestedType to
5140 track the possible creation of the NewDelegate type, since
5141 DoResolve is invoked more than once for new constructors on field
5144 See bugs: #48800 and #37014
5146 * cs-parser.jay (declare_local_constants): Take an arraylist
5147 instead of a single constant.
5149 (local_constant_declaration): It should take a
5150 constant_declarators, not a constant_declarator. Fixes 49487
5152 * convert.cs: Fix error report.
5154 2003-10-13 Jackson Harper <jackson@ximian.com>
5156 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5159 2003-10-09 Martin Baulig <martin@ximian.com>
5161 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5163 (MethodCore.DoDefineParameters): Removed the TypeContainer
5164 argument; use the DeclSpace which was passed to the .ctor instead.
5165 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5166 TypeContainer; we only need a DeclSpace here.
5168 2003-10-09 Martin Baulig <martin@ximian.com>
5170 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5172 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5173 EmitContext's .ctor.
5175 2003-10-09 Martin Baulig <martin@ximian.com>
5177 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5178 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5179 AsAccessible(), moved them as well.
5181 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5183 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5185 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5187 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5189 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5190 generation for >=, as spotted by Paolo, bug 48679.
5191 Patch from David Waite.
5193 * cs-tokenizer.cs: Add handling for #pragma.
5195 * cs-parser.jay: Allow for both yield and yield return in the
5196 syntax. The anti-cobolization of C# fight will go on!
5198 * class.cs (TypeBuilder.DefineType): Catch error condition here
5199 (Parent.DefineType erroring out and returning null).
5201 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5202 coping with enumerations variables, we were mistakenly processing
5203 them as a regular value type instead of built-in types. Fixes the
5206 * typemanager.cs (IsBuiltinOrEnum): New method.
5208 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5210 * cs-parser.jay: Upgrade: yield now needs the return clause.
5212 2003-09-19 Martin Baulig <martin@ximian.com>
5214 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5215 `MemberCache parent' argument. Normally, an interface doesn't
5216 have a parent type except System.Object, but we use this in gmcs
5217 for generic type parameters.
5219 2003-09-18 Martin Baulig <martin@ximian.com>
5221 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5222 on `type.IsInterface'; don't check whether the type has a parent
5223 to determine whether it's an interface.
5225 2003-09-15 Martin Baulig <martin@ximian.com>
5227 * class.cs (TypeContainer.DefineType): Added an error flag to
5228 avoid reporting duplicate CS0146's ("class definition is
5231 * driver.cs (Driver.MainDriver): Abort if
5232 RootContext.ResolveTree() reported any errors.
5234 2003-09-07 Martin Baulig <martin@ximian.com>
5236 * report.cs (Error, Warning): Added overloaded versions which take
5237 a `params object[] args' and call String.Format().
5239 2003-09-07 Martin Baulig <martin@ximian.com>
5241 * decl.cs (DeclSpace..ctor): Don't call
5242 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5243 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5244 (DeclSpace.RecordDecl): New method.
5246 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5248 2003-09-02 Ravi Pratap <ravi@ximian.com>
5250 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5251 value attributes to be applied to ParameterBuilders.
5253 * class.cs (MethodCore.LabelParameters): Make static and more
5254 generic so that it can be used from other places - like interface
5255 methods, for instance.
5257 * interface.cs (Interface.Emit): Call LabelParameters before
5258 emitting attributes on the InterfaceMethod.
5260 2003-08-26 Martin Baulig <martin@ximian.com>
5262 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5263 resolving aliases; fixes #47927.
5265 2003-08-26 Martin Baulig <martin@ximian.com>
5267 * statement.cs (Using.DoResolve): This is internally emitting a
5268 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5269 do not always return. Fixes #47681.
5271 2003-08-26 Martin Baulig <martin@ximian.com>
5273 * decl.cs (MemberCore): Moved WarningNotHiding(),
5274 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5276 (AdditionResult): Make this nested in DeclSpace.
5277 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5278 argument; call NamespaceEntry.Define() unless we're nested in a
5281 * namespace.cs (Namespace.DefineName): New public function. This
5282 is called from DeclSpace's .ctor to add
5283 (Namespace.Lookup): Include DeclSpaces in the lookup.
5285 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5287 * const.cs (Const): Derive from MemberBase, not MemberCore.
5289 2003-08-25 Martin Baulig <martin@ximian.com>
5291 * convert.cs (Convert.ExplicitReferenceConversion): When
5292 converting from an interface type to a class, unbox if the target
5293 type is a struct type. Fixes #47822.
5295 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5297 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5300 2003-08-22 Martin Baulig <martin@ximian.com>
5302 * class.cs (TypeManager.DefineType): When defining a nested type,
5303 call DefineType() on our parent; fixes #47801.
5305 2003-08-22 Martin Baulig <martin@ximian.com>
5307 * class.cs (MethodData.Define): While checking if a method is an
5308 interface implementation, improve the test a bit more to fix #47654.
5310 2003-08-22 Martin Baulig <martin@ximian.com>
5312 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5313 correctly; fixes #47722.
5315 2003-08-22 Martin Baulig <martin@ximian.com>
5317 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5318 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5320 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5322 2003-08-22 Martin Baulig <martin@ximian.com>
5324 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5325 can only be assigned in static constructors. Fixes #47161.
5327 2003-08-22 Martin Baulig <martin@ximian.com>
5329 Rewrote and improved the flow analysis code.
5331 * flowbranching.cs (FlowBranching): Make this class abstract.
5332 (FlowBranching.CreateBranching): New static function to create a
5334 (FlowBranchingBlock, FlowBranchingException): New classes.
5335 (FlowBranching.UsageVector.Type): New public readonly field.
5336 (FlowBranching.UsageVector.Breaks): Removed the setter.
5337 (FlowBranching.UsageVector.Returns): Removed the setter.
5338 (FlowBranching.UsageVector): Added Break(), Return(),
5339 NeverReachable() and Throw() methods to modify the reachability.
5340 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5341 done by FlowBranching.Merge().
5342 (FlowBranching.UsageVector.MergeChild): New method; merges the
5343 merge result into the current vector.
5344 (FlowBranching.Merge): New abstract method to merge a branching.
5346 2003-08-12 Martin Baulig <martin@ximian.com>
5348 * expression.cs (Indirection.CacheTemporaries): Create the
5349 LocalTemporary with the pointer type, not its element type.
5351 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5353 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5354 token was a keyword or not.
5356 Add `error' options where an IDENTIFIER was expected; Provide
5357 CheckToken and CheckIdentifierToken convenience error reporting
5360 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5362 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5363 NameSpaceEntry NameSpaceEntry.
5365 (LookupInterfaceOrClass): Avoid creating a full qualified name
5366 from namespace and name: avoid doing lookups when we know the
5367 namespace is non-existant. Use new Tree.LookupByNamespace which
5368 looks up DeclSpaces based on their namespace, name pair.
5370 * driver.cs: Provide a new `parser verbose' to display the
5371 exception thrown during parsing. This is turned off by default
5372 now, so the output of a failure from mcs is more graceful.
5374 * namespace.cs: Track all the namespaces defined in a hashtable
5377 (IsNamespace): New method
5379 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5381 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5382 we know that we need to concatenate (full typename can never be
5387 * statement.cs: Use a bitfield; Do not initialize to null things
5388 which are done by the constructor by default.
5390 * cs-parser.jay: bug fix, parameter was 4, not 3.
5392 * expression.cs: Just use the property;
5394 * statement.cs: No need for GetVariableInfo method.
5396 2003-08-08 Martin Baulig <martin@ximian.com>
5398 * flowanalysis.cs (FlowReturns): This is now nested in the
5399 `FlowBranching' class.
5400 (MyBitVector): Moved this here from statement.cs.
5401 (FlowBranching.SiblingType): New enum type.
5402 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5404 2003-08-07 Martin Baulig <martin@ximian.com>
5406 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5407 `FlowBranching' class and called `BranchingType'.
5409 2003-08-07 Martin Baulig <martin@ximian.com>
5411 * flowanalysis.cs: Moved all the control flow analysis code into
5414 2003-08-07 Martin Baulig <martin@ximian.com>
5416 * assign.cs (Assign.DoResolve): `target' must either be an
5417 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5420 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5422 * expression.cs (BinaryMethod): This kind of expression is created by the
5423 Binary class if it determines that the operator has to be handled
5426 (BinaryDelegate): This kind of expression is created if we are
5427 dealing with a + or - operator on delegates.
5429 (Binary): remove method, argumetns, and DelegateOperator: when
5430 dealing with methods,
5432 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5434 * statement.cs (Block): use bitfields for the three extra booleans
5435 we had in use. Remove unused topblock parameter.
5437 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5439 * assign.cs: Drop extra unneeded tests.
5441 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5443 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5445 * statement.cs (Foreach): Use VariableStorage instead of
5448 * codegen.cs (VariableStorage): New class used by clients that
5449 require a variable stored: locals or fields for variables that
5450 need to live across yield.
5452 Maybe provide a convenience api for EmitThis+EmitLoad?
5454 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5457 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5459 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5460 RemapParameterLValue): New methods that are used to turn a
5461 precomputed FieldInfo into an expression like this:
5465 The idea is to use this instead of making LocalVariableReference
5466 have more than one meaning.
5468 * cs-parser.jay: Add error production to BASE.
5470 * ecore.cs: Deal with TypeManager.GetField returning null, which
5471 is now a valid return value.
5473 (FieldExprNoAddress): New expression for Fields whose address can
5476 * expression.cs (LocalVariableReference): During the resolve
5477 phases, create new expressions if we are in a remapping context.
5478 Remove code that dealt with remapping here.
5480 (ParameterReference): same.
5482 (ProxyInstance): New expression, like the `This' expression, but
5483 it is born fully resolved. We know what we are doing, so remove
5484 the errors that are targeted to user-provided uses of `this'.
5486 * statement.cs (Foreach): our variable is now stored as an
5487 Expression; During resolution, follow the protocol, dont just
5488 assume it will return this.
5490 2003-08-06 Martin Baulig <martin@ximian.com>
5492 * support.cs (SeekableStreamReader.cs): New public class.
5494 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5495 SeekableStreamReader instead of the normal StreamReader.
5497 2003-08-04 Martin Baulig <martin@ximian.com>
5499 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5500 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5501 deambiguate casts and delegate invocations.
5502 (parenthesized_expression): Use the new tokens to ensure this is
5503 not a cast of method invocation.
5505 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5506 when reading a `)' and Deambiguate_CloseParens () was previously
5509 * expression.cs (ParenthesizedExpression): New class. This is
5510 just used for the CS0075 test.
5511 (Binary.DoResolve): Check for CS0075.
5513 2003-07-29 Ravi Pratap <ravi@ximian.com>
5515 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5516 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5517 reference comparison.
5519 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5520 examine the ReturnType for equality - this is necessary in the
5521 cases of implicit and explicit operators whose signature also
5522 includes the return type.
5524 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5526 * namespace.cs: Cache the result of the namespace computation,
5527 instead of computing it every time.
5529 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5531 * decl.cs: Use a global arraylist that we reuse over invocations
5532 to avoid excesive memory consumption. Reduces memory usage on an
5533 mcs compile by one meg (45 average).
5535 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5536 private, work around that.
5538 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5540 * literal.cs (IntLiteral): Define Zero and One static literals.
5542 * cs-parser.jay (integer_literal): use static literals to reduce
5543 memory usage for the most used literals (0, 1 and -1). 211kb
5544 reduced in memory usage.
5546 Replace all calls to `new ArrayList' with `new
5547 ArrayList(4)' which is a good average number for most allocations,
5548 and also requires only 16 bytes of memory for its buffer by
5551 This reduced MCS memory usage in seven megabytes for the RSS after
5554 2003-07-28 Ravi Pratap <ravi@ximian.com>
5556 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5557 handle params methods the correct way by forming only one
5558 applicable set with params and normal methods in them. Earlier we
5559 were looking at params methods only if we found no normal methods
5560 which was not the correct thing to do.
5562 (Invocation.BetterFunction): Take separate arguments indicating
5563 when candidate and the best method are params methods in their
5566 This fixes bugs #43367 and #46199.
5568 * attribute.cs: Documentation updates.
5570 (CheckAttribute): Rename to CheckAttributeTarget.
5571 (GetValidPlaces): Rename to GetValidTargets.
5573 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5574 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5578 2003-07-28 Martin Baulig <martin@ximian.com>
5580 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5581 name when looking up the base class of a nested class. Fixes #46977.
5583 2003-07-26 Martin Baulig <martin@ximian.com>
5585 * expression.cs (Indexers.Indexer): New nested struct; contains
5586 getter, setter and the indexer's type.
5587 (Indexers.Properties): This is now an ArrayList of
5589 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5590 indexer doesn't have any getters.
5592 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5593 for embedded property and indexer assignments.
5595 2003-07-26 Martin Baulig <martin@ximian.com>
5597 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5598 preprocessor directive is not the first non-whitespace character
5601 2003-07-26 Martin Baulig <martin@ximian.com>
5603 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5604 namespace parsing, follow the spec more closely.
5606 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5607 NamespaceEntry.Lookup().
5609 2003-07-25 Martin Baulig <martin@ximian.com>
5611 * MethodCore.cs (OverridesSomething): New public field; it's set
5612 from TypeContainer.DefineMembers if this method overrides
5613 something (which doesn't need to be a method). Fix #39462.
5615 2003-07-25 Ravi Pratap <ravi@ximian.com>
5617 * typemanager.cs (GetMembers): Ensure that the list of members is
5618 reversed. This keeps things in sync.
5620 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5621 find an AttributeUsage attribute.
5623 * expression.cs (Invocation.OverloadResolve): Perform the check
5624 which disallows Invoke to be directly called on a Delegate.
5626 (Error_InvokeOnDelegate): Report error cs1533.
5628 2003-07-25 Martin Baulig <martin@ximian.com>
5630 * expression.cs (Indexers.GetIndexersForType): Only look in the
5631 interface hierarchy if the requested type is already an
5632 interface. Fixes #46788 while keeping #46502 fixed.
5634 2003-07-25 Martin Baulig <martin@ximian.com>
5636 * class.cs (TypeContainer.DefineMembers): Check whether all
5637 readonly fields have been assigned and report warning CS0649 if
5640 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5643 2003-07-24 Ravi Pratap <ravi@ximian.com>
5645 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5646 returned from GetMethods to make things consistent with the
5647 assumptions MCS makes about ordering of methods.
5649 This should comprehensively fix bug #45127 and it does :-)
5651 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5652 ordering is actually reverse.
5654 * Clean up some debug messages I left lying around.
5656 * interface.cs (Populate*): Get rid of code which emits attributes
5657 since the stage in which we emit attributes is the 'Emit' stage,
5658 not the define stage.
5660 (Emit): Move attribute emission for interface members here.
5662 2003-07-22 Ravi Pratap <ravi@ximian.com>
5664 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5665 closely: we eliminate methods in base types when we have an
5666 applicable method in a top-level type.
5668 Please see section 14.5.5.1 for an exact description of what goes
5671 This fixes bug #45127 and a host of other related to corlib compilation.
5673 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5674 array is the method corresponding to the top-level type (this is
5675 because of the changes made to icall.c) so we change this
5678 (MethodGroupExpr.Name): This too.
5680 * typemanager.cs (GetElementType): New method which does the right
5681 thing when compiling corlib.
5683 * everywhere: Make use of the above in the relevant places.
5685 2003-07-22 Martin Baulig <martin@ximian.com>
5687 * cs-parser.jay (invocation_expression): Moved
5688 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5689 `cast_expression', but create a InvocationOrCast which later
5690 resolves to either an Invocation or a Cast.
5692 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5693 method; call this before EmitStatement() to make sure that this
5694 expression can be used as a statement.
5696 * expression.cs (InvocationOrCast): New class; resolves to either
5697 an Invocation or a Cast.
5699 * statement.cs (StatementExpression): Call ResolveStatement() on
5700 the ExpressionStatement before emitting it.
5702 2003-07-21 Martin Baulig <martin@ximian.com>
5704 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5705 `ref' and `out' attributes match; fixes #46220.
5706 (MemberAccess.ResolveMemberAccess): You can't reference a type
5707 through an expression; fixes #33180.
5708 (Indexers.GetIndexersForType): Don't return the indexers from
5709 interfaces the class implements; fixes #46502.
5711 2003-07-21 Martin Baulig <martin@ximian.com>
5713 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5714 CS0661 checks; fixes bug #30442.
5716 2003-07-21 Martin Baulig <martin@ximian.com>
5718 * decl.cs (AdditionResult): Added `Error'.
5720 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5722 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5723 makes cs0031.cs actually work.
5725 2003-07-20 Martin Baulig <martin@ximian.com>
5727 * namespace.cs: Fixed that bug which caused a crash when compiling
5730 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5732 * typemanager.cs (LookupTypeReflection): Never expose types which
5733 are NotPublic, NestedPrivate, NestedAssembly, or
5734 NestedFamANDAssem. We used to return these, and later do a check
5735 that would report a meaningful error, but the problem is that we
5736 would not get the real match, if there was a name override.
5738 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5740 * namespace.cs (Namespace, Name): Do not compute the namespace
5741 name dynamically, compute it in the constructor. This reduced
5742 memory usage by 1697 KB.
5744 * driver.cs: Use --pause to pause at the end.
5746 2003-07-17 Peter Williams <peter@newton.cx>
5748 * Makefile: Change the name of the test target so that it doesn't
5749 conflict with the recursive test target.
5751 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5753 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5754 AddressOf): Do not use EmitThis, that was wrong, use the actual
5757 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5759 * class.cs (MethodData.Define): While checking if a method is an
5760 interface implementation, improve the test: If we are not public
5761 (use new test here: use the computed MethodAttributes directly,
5762 instead of the parsed modifier flags) check if the `implementing'
5763 method comes from an interface or not.
5765 * pending.cs (VerifyPendingMethods): Slightly better error
5768 * makefile: add test target that does the mcs bootstrap.
5770 2003-07-16 Ravi Pratap <ravi@ximian.com>
5772 * interface.cs (Define): Do nothing here since there are no
5773 members to populate etc. Move the attribute emission out of here
5774 since this was just totally the wrong place to put it. Attribute
5775 application happens during the 'Emit' phase, not in the 'Define'
5778 (Emit): Add this method and move the attribute emission here
5780 * rootcontext.cs (EmitCode): Call the Emit method on interface
5783 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5785 * expression.cs (OverloadResolve): Report error only if Location
5786 is not 'Null' which means that there was a probe going on.
5788 2003-07-14 Martin Baulig <martin@ximian.com>
5790 * expression.cs (ConditionalLogicalOperator): New public class to
5791 implement user defined conditional logical operators.
5792 This is section 14.11.2 in the spec and bug #40505.
5794 2003-07-14 Martin Baulig <martin@ximian.com>
5796 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5798 2003-07-14 Martin Baulig <martin@ximian.com>
5800 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5802 * ecore.cs (IVariable.VerifyFixed): New interface method.
5804 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5805 operator, check whether the variable is actually fixed. Fixes bug
5806 #36055. Set a variable definitely assigned when taking its
5807 address as required by the spec.
5809 * statement.cs (LocalInfo.IsFixed): New field.
5810 (LocalInfo.MakePinned): Set `IsFixed' to true.
5812 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5814 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5815 for .ctors, ensure that we only ask for members declared in the
5816 attribute type (BindingFlags.DeclaredOnly).
5820 * expression.cs (Error_WrongNumArguments): Report error 1501
5821 correctly the way CSC does.
5823 2003-07-13 Martin Baulig <martin@ximian.com>
5825 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5826 lookup on the fully qualified name, to make things like "X.X" work
5827 where "X.X" is a fully qualified type name, but we also have a
5828 namespace "X" in the using list. Fixes #41975.
5830 2003-07-13 Martin Baulig <martin@ximian.com>
5832 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5833 function. If we're a CompoundAssign, we need to create an embedded
5834 CompoundAssign, not an embedded Assign.
5835 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5838 2003-07-13 Martin Baulig <martin@ximian.com>
5840 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5841 work to fix bug #46088.
5843 2003-07-13 Ravi Pratap <ravi@ximian.com>
5845 * class.cs (Operator.Emit): Do not emit attributes here - it is
5846 taken care of by the Method class that we delegate too. This takes
5849 2003-07-10 Martin Baulig <martin@ximian.com>
5851 * expression.cs (TypeOfVoid): New class.
5852 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5854 2003-07-10 Martin Baulig <martin@ximian.com>
5856 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5859 2003-07-10 Martin Baulig <martin@ximian.com>
5861 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5862 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5864 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5866 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5868 2003-07-10 Martin Baulig <martin@ximian.com>
5870 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5871 of decimal. Fixes #42850.
5873 NOTE: I also fixed the created byte blob, but this doesn't work on
5874 the MS runtime and csc never produces any byte blobs for decimal
5877 2003-07-10 Martin Baulig <martin@ximian.com>
5879 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5880 structs; fixes #32068.
5881 (Block.AddChildVariableNames): Fixed #44302.
5883 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5885 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5887 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5889 * attribute.cs: And this test is onger needed.
5891 2003-07-08 Martin Baulig <martin@ximian.com>
5893 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5894 inaccessible types. Fixes #36313.
5896 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5898 * namespace.cs (NamespaceEntry): Create implicit entries for all
5899 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5900 implicit entries for N1.N2 and N1.
5902 2003-07-08 Martin Baulig <martin@ximian.com>
5904 Rewrote the handling of namespaces to fix a lot of the issues
5905 wrt. `using' aliases etc.
5907 * namespace.cs (Namespace): Splitted this class into a
5908 per-assembly `Namespace' and a per-file `NamespaceEntry'.
5910 * typemanager.cs (TypeManager.IsNamespace): Removed.
5911 (TypeManager.ComputeNamespaces): Only compute namespaces from
5912 loaded assemblies here, not the namespaces from the assembly we're
5913 currently compiling.
5915 2003-07-08 Martin Baulig <martin@ximian.com>
5917 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
5919 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5921 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
5924 I thought about the memory savings here, but LookupTypeReflection
5925 is used under already very constrained scenarios. Compiling
5926 corlib or mcs only exposes one hit, so it would not really reduce
5927 any memory consumption.
5929 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5931 * typemanager.cs: fixes bug #45889 by only adding public types from
5932 other assemblies to the list of known types.
5934 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5936 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
5937 on the type we resolved.
5939 2003-07-05 Martin Baulig <martin@ximian.com>
5941 * pending.cs (PendingImplementation.ParentImplements): Don't
5942 create the proxy if the parent is abstract.
5944 * class.cs (TypeContainer.DefineIndexers): Process explicit
5945 interface implementations first. Fixes #37714.
5947 2003-07-04 Miguel de Icaza <miguel@ximian.com>
5949 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
5950 defined recursively; but since we modify the input parameters
5951 (left is set to `this' temporarily), we reset this value if the
5952 left_is_explicit is false, which gives the original semantics to
5955 * literal.cs (NullPointer): new class used to represent a null
5956 literal in a pointer context.
5958 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
5959 type is a pointer, use a NullPointer object instead of a
5960 NullLiteral. Closes 43687
5962 (ExplicitConversion): Convert pointer values using
5963 the conv opcode to the proper type.
5965 * ecore.cs (New): change ValueTypeVariable property into a method,
5966 that returns whether the valuetype is suitable for being used.
5968 * expression.cs (Binary.DoNumericPromotions): Only return if we
5969 the int constant was a valid uint, and we can return both left and
5970 right as uints. If not, we continue processing, to trigger the
5971 type conversion. This fixes 39018.
5973 * statement.cs (Block.EmitMeta): During constant resolution, set
5974 the CurrentBlock property on the emitcontext, so that we resolve
5975 constants propertly.
5977 2003-07-02 Martin Baulig <martin@ximian.com>
5979 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
5980 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
5982 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
5983 than emitting it here.
5985 * statement.cs: Fixed some more flow analysis bugs.
5987 2003-07-02 Martin Baulig <martin@ximian.com>
5989 * class.cs (MethodData.Define): When implementing interface
5990 methods, set Final unless we're Virtual.
5992 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
5993 check work for interface methods.
5995 2003-07-01 Martin Baulig <martin@ximian.com>
5997 * ecore.cs (EmitContext.This): Replaced this property with a
5998 GetThis() method which takes a Location argument. This ensures
5999 that we get the correct error location for a CS0188.
6001 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6003 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6004 ImplicitStandardConversion.
6006 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6008 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6010 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6013 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6015 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6018 (MethodData.Define): Turn off initlocals for unsafe methods.
6020 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6022 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6023 complete; Fixes #37521.
6025 * delegate.cs: Use Modifiers.TypeAttr to compute the
6026 TypeAttributes, instead of rolling our own. This makes the flags
6027 correct for the delegates.
6029 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6031 * class.cs (Constructor.Define): Set the private flag for static
6032 constructors as well.
6034 * cs-parser.jay (statement_expression): Set the return value to
6035 null, to avoid a crash when we catch an error.
6037 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6039 * cs-parser.jay: Applied patch from Jackson that adds support for
6040 extern and unsafe modifiers to destructor declarations.
6042 * expression.cs: Report error 21 if the user is trying to index a
6045 * driver.cs: Add an error message, suggested by the bug report.
6047 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6048 if we do not have a ": this ()" constructor initializer. Fixes 45149
6050 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6052 * namespace.cs: Add some information to reduce FAQs.
6054 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6056 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6057 underlying enumeration types. Fixes #43915.
6059 * expression.cs: Treat ushort/short as legal values to be used in
6062 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6064 * delegate.cs: transfer custom attributes for paramenters from
6065 the delegate declaration to Invoke and BeginInvoke.
6067 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6069 * attribute.cs: handle custom marshalers and emit marshal info
6072 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6074 * makefile.gnu: Added anonymous.cs to the compiler sources.
6076 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6078 * iterators.cs: Change the name of the proxy class to include two
6081 * cs-parser.jay: Update grammar to include anonymous methods.
6083 * anonymous.cs: new file.
6085 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6087 * class.cs (Field.Define): Add missing test for pointers and
6090 2003-05-27 Ravi Pratap <ravi@ximian.com>
6092 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6093 we use the stobj opcode.
6095 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6096 since it wasn't the correct fix.
6098 It still is puzzling that we are required to use stobj for IntPtr
6099 which seems to be a ValueType.
6101 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6103 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6104 during regular simple name resolution. Now, the trick is that
6105 instead of returning for processing the simplename, we do a
6106 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6107 contextual lookup type). If a match is found, return that, if
6108 not, return for further composition.
6110 This fixes long-standing 30485.
6112 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6113 using the address to initialize an object, do an Stobj instead of
6114 using the regular Stelem.
6116 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6117 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6118 Because if we are a BaseIndexerAccess that value will be true.
6121 * statement.cs (GotoCase.Resolve): Return after reporting an
6122 error, do not attempt to continue.
6124 * expression.cs (PointerArithmetic.Emit): If our operand is a
6125 long, convert our constants to match the operand before
6126 multiplying. Convert to I type before adding. Fixes 43670.
6128 2003-05-14 Ravi Pratap <ravi@ximian.com>
6130 * enum.cs (ImplicitConversionExists) : Rename to
6131 ImplicitEnumConversionExists to remove ambiguity.
6133 * ecore.cs (NullCast): New type of cast expression class which
6134 basically is very similar to EmptyCast with the difference being
6135 it still is a constant since it is used only to cast a null to
6139 * convert.cs (ImplicitReferenceConversion): When casting a null
6140 literal, we return a NullCast.
6142 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6143 should be around anymore.
6145 The renaming (reported was slightly wrong). Corrections:
6147 ConvertImplicitStandard -> ImplicitConversionStandard
6148 ConvertExplicitStandard -> ExplicitConversionStandard
6150 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6151 before passing them in !
6153 * convert.cs (ImplicitConversionStandard): When comparing for
6154 equal expr and target types, ensure that expr is not a
6157 In general, we must not be checking (expr_type ==
6158 target_type) in the top level conversion methods
6159 (ImplicitConversion, ExplicitConversion etc). This checking is
6160 done in the methods that they delegate to.
6162 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6164 * convert.cs: Move Error_CannotConvertType,
6165 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6166 ImplicitNumericConversion, ImplicitConversionExists,
6167 ImplicitUserConversionExists, StandardConversionExists,
6168 FindMostEncompassedType, FindMostSpecificSource,
6169 FindMostSpecificTarget, ImplicitUserConversion,
6170 ExplicitUserConversion, GetConversionOperators,
6171 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6172 TryImplicitIntConversion, Error_CannotConvertImplicit,
6173 ConvertImplicitRequired, ConvertNumericExplicit,
6174 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6175 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6178 Perform the following renames:
6180 StandardConversionExists -> ImplicitStandardConversionExists
6181 ConvertImplicit -> ImplicitConversion
6182 ConvertImplicitStandard -> ImplicitStandardConversion
6183 TryImplicitIntConversion -> ImplicitIntConversion
6184 ConvertImplicitRequired -> ImplicitConversionRequired
6185 ConvertNumericExplicit -> ExplicitNumericConversion
6186 ConvertReferenceExplicit -> ExplicitReferenceConversion
6187 ConvertExplicit -> ExplicitConversion
6188 ConvertExplicitStandard -> ExplicitStandardConversion
6190 2003-05-19 Martin Baulig <martin@ximian.com>
6192 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6193 (TypeInfo): Added support for structs having structs as fields.
6195 * ecore.cs (FieldExpr): Implement IVariable.
6196 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6197 VariableInfo for the field.
6199 2003-05-18 Martin Baulig <martin@ximian.com>
6201 * expression.cs (This.DoResolve): Report a CS0027 if we're
6202 emitting a field initializer.
6204 2003-05-18 Martin Baulig <martin@ximian.com>
6206 * expression.cs (This.ResolveBase): New public function.
6207 (This.DoResolve): Check for CS0188.
6209 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6212 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6213 `instance_expression' to null if we don't have any non-static
6216 2003-05-18 Martin Baulig <martin@ximian.com>
6218 Reworked the way how local variables and parameters are handled by
6219 the flow analysis code.
6221 * statement.cs (TypeInfo, VariableMap): New public classes.
6222 (VariableInfo): New public class. This is now responsible for
6223 checking whether a variable has been assigned. It is used for
6224 parameters and local variables.
6225 (Block.EmitMeta): Take the InternalParameters as argument; compute
6226 the layout of the flow vectors here.
6227 (Block.LocalMap, Block.ParameterMap): New public properties.
6228 (FlowBranching): The .ctor doesn't get the InternalParameters
6229 anymore since Block.EmitMeta() now computes the layout of the flow
6231 (MyStructInfo): This class is now known as `StructInfo' and nested
6232 in `TypeInfo'; we don't access this directly anymore.
6234 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6235 property and removed IsAssigned(), IsFieldAssigned(),
6236 SetAssigned() and SetFieldAssigned(); we now call them on the
6237 VariableInfo so we don't need to duplicate this code everywhere.
6239 * expression.cs (ParameterReference): Added `Block block' argument
6241 (LocalVariableReference, ParameterReference, This): The new
6242 VariableInfo class is now responsible for all the definite
6245 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6246 IsParameterAssigned, SetParameterAssigned): Removed.
6248 2003-05-18 Martin Baulig <martin@ximian.com>
6250 * typemanager.cs (InitCoreTypes): Try calling
6251 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6252 the 3-args-version. Corlib now also needs our `void_type'.
6253 (GetMethod): Added overloaded version which takes an optional
6254 `bool report_errors' to allow lookups of optional methods.
6256 2003-05-12 Martin Baulig <martin@ximian.com>
6258 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6259 only used for locals and not for parameters.
6261 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6263 * support.cs (InternalParameters.ParameterType): Return the
6264 ExternalType of the parameter.
6266 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6269 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6271 * class.cs (MethodData.Define): Do not set the `newslot' on
6272 interface members, if they are also flagged as "override".
6274 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6275 better code for ++i and i++. This only works for static fields
6276 and local variables.
6278 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6279 want to pull the DeclSpace out of the builder_to_declspace instead
6280 of the TypeBuilder (like in TypeContainer.FindMembers).
6282 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6283 instead of LookupTypeContainer. Fixes the crash on .NET for
6284 looking up interface members.
6286 * const.cs: Create our own emit context during the Definition
6287 stage, so that constants are evaluated in the proper context, when
6288 a recursive definition happens.
6290 2003-05-11 Martin Baulig <martin@ximian.com>
6292 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6293 new block for a switch section.
6294 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6295 the adding/lookup in the switch block. Fixes #39828.
6297 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6299 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6300 functionality: I needed to convert the data after I had performed
6301 the add/sub operation into the operands type size.
6303 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6304 pass the type for the box operation, otherwise the resulting
6305 object would have been of type object.
6307 (BoxedCast): Add constructor to specify the type to box as.
6309 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6311 * iterators.cs: I was reusing the `count' variable inadvertently,
6312 take steps to not allow this to happen.
6314 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6316 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6317 by creating an array at the point where the params starts and
6318 putting all those arguments there, then adjusting the size of the
6321 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6323 * expression.cs (New.AddressOf): Implement interface
6324 IMemoryLocation. This is used when the `new' operator is used in
6325 the context of an invocation to a method on a value type.
6327 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6330 * namespace.cs: Also check the using aliases here.
6332 * driver.cs: Move the test for using validity after the types have
6333 been entered, so we do a single pass that also includes the using
6336 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6337 in the regular case. CreateSiblingForFinally is doing extra
6340 * attribute.cs (GetAttributeArgumentExpression): Store the result
6341 on an out value, and use the return value to indicate failure
6342 instead of using null (which is a valid return for Constant.GetValue).
6344 * statement.cs: Perform the analysis flow for the increment
6345 portion after the statement, because this will be the real flow of
6346 execution. Fixes #42385
6348 * codegen.cs (EmitContext.EmitArgument,
6349 EmitContext.EmitStoreArgument): New helper functions when the
6350 RemapToProxy flag is set.
6352 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6355 Add support for remapping parameters.
6357 * iterators.cs: Propagate parameter values; Store parameter
6358 values in the proxy classes.
6360 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6362 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6363 need a proxy reference; I do not know what I was thinking
6365 * cs-parser.jay (constructor_initializer): catch another error,
6366 and display nice message.
6368 (field_declaration): catch void field declaration
6369 to flag a better error.
6371 * class.cs (MemberBase.CheckBase): Report an error instead of a
6372 warning if a new protected member is declared in a struct.
6373 (Field.Define): catch the error of readonly/volatile.
6375 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6377 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6378 volatile variable is taken
6380 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6382 * statement.cs (Fixed.Resolve): Report an error if we are not in
6385 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6387 * typemanager.cs: reuse the code that handles type clashes for
6388 delegates and enumerations.
6390 * class.cs (Report28): Always report.
6392 * expression.cs (EncodeAsAttribute): Allow nulls here.
6394 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6396 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6397 the functionality for testing whether an expression is valid for
6398 an attribute here. Also handle the case of arrays of elements
6401 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6402 encoding a linear array into an array of objects that are suitable
6403 to be passed to an CustomAttributeBuilder.
6405 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6407 * ecore.cs: (FieldExpr): Handle field remapping here.
6409 * iteratators.cs: Pass the instance variable (if the method is an
6410 instance method) to the constructors, so we can access the field
6411 variables on the class.
6413 TODO: Test this with structs. I think the THIS variable on
6414 structs might have to be a pointer, and not a refenrece
6416 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6418 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6419 local variables to fields in a proxy class.
6421 * iterators.cs (PopulateProxy): Rename our internal fields to
6423 Create a <THIS> field if we are an instance method, so we can
6424 reference our parent container variables.
6425 (MapVariable): Called back from the EmitContext code to enter a
6426 new variable to field mapping into the proxy class (we just create
6430 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6431 for using the remapped locals to fields.
6433 I placed the code here, because that gives the same semantics to
6434 local variables, and only changes the Emit code.
6436 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6437 statements inside iterators.
6438 (VariableInfo): Add a FieldBuilder for the cases when we are
6439 remapping local variables to fields in a proxy class
6441 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6442 current_block != null.
6444 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6445 not cope with strings, as it has been moved to the
6446 TableSwitchEmit. Fixed bug in switch generation.
6448 * expression.cs (New.DoResolve): Provide more context for the user
6449 when reporting an error.
6451 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6454 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6455 check the permissions for it. Note than in a type-resolution
6456 context the check was already present in DeclSpace.ResolveType,
6457 but was missing from the MemberAccess.
6459 (ArrayCreation.CheckIndices): warn if the user has
6460 more nested levels of expressions, but there are no more
6461 dimensions specified. Avoids crash on bug 41906.
6463 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6465 * statement.cs (Block): replace Implicit bool, for a generic
6467 New flag: `Unchecked'. This is used during the EmitMeta phase
6468 (which is out-of-line with the regular Resolve/Emit process for a
6469 statement, as this is done ahead of time, but still gets a chance
6470 to call constant resolve).
6472 (Block.Flags): new enum for adding a new flag.
6474 (Block.EmitMeta): track the state of unchecked.
6476 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6477 to enable constant resolution to work there as well.
6479 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6481 * typemanager.cs (ienumerable_type): Also look up
6482 System.Collections.IEnumerable.
6484 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6486 TODO: Test more than one conditional per method.
6488 * class.cs (Indexer.Define): Report the location where the user is
6489 referencing the unsupported feature.
6491 (MethodData): Overload the use of `conditionals' to
6492 minimize the creation of needless ArrayLists. This saves roughly
6493 212kb on my machine.
6495 (Method): Implement the new IIteratorContainer interface.
6496 (Method.SetYields): Implement the method by setting the ModFlags
6497 to contain METHOD_YIELDS.
6499 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6500 which just got set to null.
6502 * iterators.cs: New file.
6504 (Yield, YieldBreak): New statements.
6506 * statement.cs (Return.Resolve): Flag an error if we are used in
6509 * codegen.cs (InIterator): New flag set if the code is being
6510 compiled in an iterator method.
6512 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6513 internal modifier, and we just use it to avoid adding extra
6514 fields, as this is seldom used.
6516 * cs-parser.jay: Add yield_statement (yield and yield break).
6518 * driver.cs: New flag -v2 to turn on version 2 features.
6520 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6521 hashtable when v2 is enabled.
6523 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6525 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6526 there is already a namespace defined with this name.
6528 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6529 people upgraded their corlibs.
6531 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6532 always use fully qualified types, no need to use the compiler
6535 (TypeManager.IsNamespace): Use binarysearch.
6537 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6538 AddDelegate): I did not quite use the new IsValid API properly: I
6539 have to pass the short-name and the fullname. I was passing only
6540 the basename instead of the fullname sometimes.
6542 (TypeContainer.DefineType): call NamespaceClash.
6544 * interface.cs (Interface.DefineType): use NamespaceClash before
6547 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6550 * enum.cs: (Enum.DefineType): use NamespaceClash before
6553 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6554 speed increase. First, use the negative_hits cache when we get a
6555 negative. Second, add the type with its full original name
6556 instead of the new . and + encoded name (reflection uses + to
6557 separate type from a nested type). Use LookupTypeReflection
6558 directly which bypasses the type->name hashtable (that we already
6559 know does not contain the type.
6561 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6562 location/container type.
6564 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6566 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6568 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6570 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6571 method is being referenced in the method group from a static
6572 context, and report error 120 if so.
6574 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6577 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6578 is created, we create the A namespace).
6580 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6583 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6585 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6586 invocation to ModuleBuilder.GetType with the same values will
6587 return a new type instance, so we need to cache its return
6590 * expression.cs (Binary.ResolveOperator): Only allow the compare
6591 operators on enums if they are of the same type.
6593 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6594 types of ValueType on their own case. Before we were giving them
6595 the same treatment as objects.
6597 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6598 fullname. Short name is used to compare against container name.
6599 Fullname is used to check against defined namespace names.
6601 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6602 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6604 (Method.CheckBase): Call parent.
6605 (MemberBase.CheckBase): Check for protected members on sealed
6607 (PropertyBase.CheckBase): Call parent.
6608 (Field.Define): Call parent.
6610 * report.cs: Negative error codes are now mapped to 8000 - code,
6611 so that the display is render more nicely.
6613 * typemanager.cs: Do not use try/catch, instead report a regular
6616 (GetPointerType, GetReferenceType): These methods provide
6617 mechanisms to obtain the T* and T& from a T. We had the code
6618 previously scattered around the code base, and it also used
6619 TypeManager.LookupType that would go through plenty of caches.
6620 This one goes directly to the type source.
6622 In some places we did the Type.GetType followed by
6623 ModuleBuilder.GetType, but not in others, so this unifies the
6626 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6627 statements now that we have namespace information.
6629 * typemanager.cs (IsNamespace): New method, returns whether the
6630 string presented is a namespace or not.
6632 (ComputeNamespaces): New public entry point, computes the list of
6633 available namespaces, using the GetNamespaces API call in Mono, or
6634 the slower version in MS.NET.
6636 Now before we start the semantic analysis phase, we have a
6637 complete list of namespaces including everything that the user has
6640 Deleted old code to cache namespaces in .nsc files.
6642 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6644 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6645 class/struct location definition Location for the implicit
6646 constructor location.
6648 (Operator.Define): Use the location of the operator for the
6649 implicit Method definition.
6651 (Constructor.Emit): use the constructor location for the implicit
6652 base initializer constructor.
6654 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6655 and the Expression class now contains two new methods:
6657 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6658 isolate type lookup from the rest of the resolution process.
6660 Since we use Expressions to hold type definitions due to the way
6661 we parse the input we have historically overloaded Resolve to
6662 perform the Type lookups if a special flag is passed. Now this is
6663 eliminated and two methods take their place.
6665 The differences in the two methods between xStep and xTerminal is
6666 that xStep is involved in our current lookup system that uses
6667 SimpleNames to compose a name, while xTerminal is used just to
6668 catch the case where the simplename lookup failed.
6670 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6672 * expression.cs (ResolveMemberAccess): Remove redundant code.
6673 TypeExpr expressions are always born fully resolved.
6675 * interface.cs (PopulateMethod): Do not lookup the types twice.
6676 We were doing it once during SemanticAnalysis and once during
6679 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6680 in local variable type definitions, were being returned as a
6681 SimpleName (we decomposed everything into a string), that is
6682 because primary_expression was being used instead of a type in the
6683 grammar (reduce/reduce conflicts).
6685 The part that was wrong is that we converted the expression into a
6686 string (an oversimplification in one hand, compounded with primary
6687 expressions doing string concatenation).
6693 Would return "A.B.C[]" as a SimpleName. This stopped things like
6694 using clauses from working on this particular context. And a type
6695 was being matched directly against "A.B.C[]".
6697 We now use the correct approach, and allow for ComposedCast to be
6698 part of the unary expression. So the "A.B.C []" become a composed
6699 cast of "A.B.C" (as a nested group of MemberAccess with a
6700 SimpleName at the end) plus the rank composition "[]".
6704 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6706 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6707 for the access level checking.
6709 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6710 `TypeContainer container', because I kept getting confused when I
6711 was debugging this code.
6713 * expression.cs (Indexers): Instead of tracking getters/setters,
6714 we now track them in parallel. We create one arraylist less, but
6715 most importantly it is possible now for the LValue code to find a
6716 matching get for a set.
6718 (IndexerAccess.DoResolveLValue): Update the code.
6719 GetIndexersForType has been modified already to extract all the
6720 indexers from a type. The code assumed it did not.
6722 Also make the code set the correct return type for the indexer.
6723 This was fixed a long time ago for properties, but was missing for
6724 indexers. It used to be void_type.
6726 (Binary.Emit): Test first for doubles instead of
6727 floats, as they are more common.
6729 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6730 when dealing with floats and the <=, >= operators. This fixes bug
6733 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6734 to load the array value by emitting a load on the foreach variable
6735 type. This was incorrect.
6737 We now emit the code to load an element using the the array
6738 variable type, and then we emit the conversion operator.
6742 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6744 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6746 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6748 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6749 test for protection before we test for signatures.
6751 (MethodSignature.ToString): implement.
6753 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6754 to the case where we reduced into a LongConstant.
6756 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6757 depend on whether the information is acurrate, because the
6758 Microsoft runtime will always claim that the array type is public,
6759 regardless of the real state.
6761 If the type is a pointer, another problem happens: the type is
6762 reported as non-public in Microsoft.
6764 In both cases we have to call CheckAccessLevel recursively with
6765 the underlying type as the argument to be tested.
6767 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6769 * assign.cs (Assign.Emit): If we are dealing with a compound
6770 assignment expression, we should use the code path that stores the
6771 intermediate result in a temporary value. This fixes #40903.
6773 *expression.cs (Indirection.ToString): Provide ToString method for
6776 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6778 * class.cs: Null out fields holding references to Block objects so
6779 they can be garbage collected.
6781 * expression.cs (OverloadResolve): Remove unused local.
6783 2003-04-07 Martin Baulig <martin@ximian.com>
6785 * codegen.cs (EmitContext.CurrentFile): New public field.
6786 (EmitContext.Mark): Use the CurrentFile to check whether the
6787 location is in the correct file.
6788 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6790 2003-04-07 Martin Baulig <martin@ximian.com>
6792 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6794 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6795 location. [FIXME: The location argument which gets passed to this
6796 method is sometimes wrong!]
6798 2003-04-07 Nick Drochak <ndrochak@gol.com>
6800 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6802 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6804 * expression.cs (Indirection.EmitAssign): We were using the
6805 temporary, but returning immediately instead of continuing the
6808 2003-04-06 Martin Baulig <martin@ximian.com>
6810 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6811 if it's a nested child, but also deriving from the outer class.
6814 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6815 nested child, but also deriving from the outer class. See
6817 (FilterWithClosure): We may access private members of the outer
6818 class if we're a nested child and deriving from the outer class.
6819 (RealMemberLookup): Only set `closure_private_ok' if the
6820 `original_bf' contained BindingFlags.NonPublic.
6822 2003-04-05 Martin Baulig <martin@ximian.com>
6824 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6826 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6828 * class.cs (Event.Define): Do not allow abstract events to have
6831 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6833 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6834 block in event declarations.
6836 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6837 value type, get its address.
6839 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6840 leaving a class on the stack instead of a boolean value (int
6841 0/1). Change the code so we compare against null, and then the
6842 result against zero.
6844 * class.cs (TypeContainer.GetClassBases): We were checking for the
6845 parent class being sealed too late.
6847 * expression.cs (Binary.Emit): For <= and >= when dealing with
6848 floating point values, use cgt.un and clt.un instead of cgt and
6851 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6853 * statement.cs: Apply the same optimization as MS: skip the
6854 GetEnumerator returning an IEnumerator, and use the one returning a
6855 CharEnumerator instead. This allows us to avoid the try-finally block
6858 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6860 * cs-parser.jay: Attributes cannot be applied to
6861 namespaces. Fixes #40473
6863 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6866 (Add*): check if the name is valid using the full name for constants,
6867 fields, properties and events.
6869 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6871 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6872 char constants to be part of the enumeration.
6874 * expression.cs (Conditional.DoResolve): Add support for operator
6875 true. Implements the missing functionality from 14.12
6877 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6878 operator true/false as required by the spec.
6880 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6881 implicit conversion to boolean.
6883 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6884 also one where the type implements `operator true'.
6886 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
6887 get an expression that will invoke operator true based on an
6890 (GetConversionOperators): Removed the hack that called op_True
6893 (Expression.ResolveBoolean): Move this from Statement.
6895 2003-03-17 Miguel de Icaza <miguel@ximian.com>
6897 * ecore.cs (FieldExpr): do not allow initialization of initonly
6898 fields on derived classes
6900 2003-03-13 Martin Baulig <martin@ximian.com>
6902 * statement.cs (Block.Emit): Call ig.BeginScope() and
6903 ig.EndScope() when compiling with debugging info; call
6904 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
6906 2003-03-08 Miguel de Icaza <miguel@ximian.com>
6908 * expression.cs (Indexers): Do not construct immediately, allow
6909 for new members to be appended as we go. Fixes 38143
6911 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6913 * expression.cs: save/restore context when resolving an unchecked
6916 2003-03-05 Miguel de Icaza <miguel@ximian.com>
6918 * cfold.cs: Catch division by zero in modulus operator during
6921 2003-03-03 Miguel de Icaza <miguel@ximian.com>
6923 * interface.cs (Interface.DefineMembers): Avoid defining members
6926 2003-02-27 Miguel de Icaza <miguel@ximian.com>
6928 * driver.cs: handle the +/- options for -noconfig
6930 * statement.cs (Unckeched.Resolve): Also track the state of
6931 unchecked in the Resolve phase.
6933 2003-02-27 Martin Baulig <martin@ximian.com>
6935 * ecore.cs (Expression.MemberLookup): Don't create a
6936 MethodGroupExpr for something which is not a method. Fixes #38291.
6938 2003-02-25 Miguel de Icaza <miguel@ximian.com>
6940 * class.cs (MemberBase.CheckParameters): Also check that the type
6941 is unmanaged if it is a pointer.
6943 * expression.cs (SizeOf.Resolve): Add location information.
6945 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
6946 a managed type is declared.
6948 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
6949 parameter modifiers as well. Fixes bug 38606
6951 * class.cs: Very sad. Am backing out the speed up changes
6952 introduced by the ArrayList -> Array in the TypeContainer, as they
6953 were not actually that much faster, and introduced a bug (no error
6954 reports on duplicated methods).
6956 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
6957 source first, this will guarantee that we have a valid expression
6958 before calling in lower levels functions that will require a
6959 resolved object. Then use this original_source in the
6960 target.ResolveLValue instead of the original source that was
6963 Another change. Use target.Resolve instead of LValueResolve.
6964 Although we are resolving for LValues, we will let the Assign code
6965 take care of that (it will be called again from Resolve). This
6966 basically allows code like this:
6968 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
6969 class Y { void A (X x) { x [0] += o; }
6971 The problem was that the indexer was trying to resolve for
6972 set_Item (idx, object o) and never finding one. The real set_Item
6973 was set_Item (idx, X). By delaying the process we get the right
6978 2003-02-23 Martin Baulig <martin@ximian.com>
6980 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
6981 while calling DoEmit ().
6983 * codegen.cs (EmitContext.Mark): Don't mark locations in other
6984 source files; if you use the #line directive inside a method, the
6985 compiler stops emitting line numbers for the debugger until it
6986 reaches the end of the method or another #line directive which
6987 restores the original file.
6989 2003-02-23 Martin Baulig <martin@ximian.com>
6991 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
6993 2003-02-23 Martin Baulig <martin@ximian.com>
6995 * statement.cs (Block.AddChildVariableNames): We need to call this
6996 recursively, not just for our immediate children.
6998 2003-02-23 Martin Baulig <martin@ximian.com>
7000 * class.cs (Event.Define): Always make the field private, like csc does.
7002 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7003 actually work, fixes bug #37521.
7005 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7007 * delegate.cs: When creating the various temporary "Parameters"
7008 classes, make sure that we call the ComputeAndDefineParameterTypes
7009 on those new parameters (just like we do with the formal ones), to
7010 allow them to be resolved in the context of the DeclSpace.
7012 This fixes the bug that Dick observed in Bugzilla #38530.
7014 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7016 * expression.cs (ResolveMemberAccess): When resolving a constant,
7017 do not attempt to pull a constant if the value was not able to
7018 generate a valid constant.
7020 * const.cs (LookupConstantValue): Do not report more errors than required.
7022 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7024 * expression.cs: fixes bug #38328.
7026 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7028 * class.cs: Changed all the various members that can be part of a
7029 class from being an ArrayList to be an Array of the right type.
7030 During the DefineType type_list, interface_list, delegate_list and
7031 enum_list are turned into types, interfaces, delegates and enums
7034 And during the member population, indexer_list, event_list,
7035 constant_list, field_list, instance_constructor_list, method_list,
7036 operator_list and property_list are turned into their real arrays.
7038 Although we could probably perform this operation earlier, for
7039 good error reporting we need to keep the lists and remove the
7040 lists for longer than required.
7042 This optimization was triggered by Paolo profiling the compiler
7043 speed on the output of `gen-sample-program.pl' perl script.
7045 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7046 not crash in methods like MemberLookupFailed that use this field.
7048 This problem arises when the compiler fails to resolve a type
7049 during interface type definition for example.
7051 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7053 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7054 inherit from System.Object, so we have to stop at null, not only
7055 when reaching System.Object.
7057 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7059 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7060 DeclaredOnly because the parent indexer might have had a different
7061 name, but did not loop until the top of the hierarchy was reached.
7063 The problem this one fixes is 35492: when a class implemented an
7064 indexer from an interface, we were getting the interface method
7065 (which was abstract) and we were flagging an error (can not invoke
7068 This also keeps bug 33089 functioning, and test-148 functioning.
7070 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7071 out if a method is special is to see if it is declared in a
7072 property or event, or whether it is one of the predefined operator
7073 names. This should fix correctly #36804.
7075 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7077 The goal here is to remove the dependency on EmptyCast.Peel ().
7078 Killing it completely.
7080 The problem is that currently in a number of places where
7081 constants are expected, we have to "probe" for an EmptyCast, and
7082 Peel, which is not the correct thing to do, as this will be
7083 repetitive and will likely lead to errors.
7085 The idea is to remove any EmptyCasts that are used in casts that
7086 can be reduced to constants, so we only have to cope with
7089 This bug hunt was triggered by Bug 37363 and the desire to remove
7090 the duplicate pattern where we were "peeling" emptycasts to check
7091 whether they were constants. Now constants will always be
7094 * ecore.cs: Use an enumconstant here instead of wrapping with
7097 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7098 throwing me off. By handling this we can get rid of a few hacks.
7100 * statement.cs (Switch): Removed Peel() code.
7102 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7104 * class.cs: Location information for error 508
7106 * expression.cs (New.DoResolve): Add a guard against double
7107 resolution of an expression.
7109 The New DoResolve might be called twice when initializing field
7110 expressions (see EmitFieldInitializers, the call to
7111 GetInitializerExpression will perform a resolve on the expression,
7112 and later the assign will trigger another resolution
7114 This leads to bugs (#37014)
7116 * delegate.cs: The signature for EndInvoke should contain any ref
7117 or out parameters as well. We were not doing this in the past.
7119 * class.cs (Field.Define): Do not overwrite the type definition
7120 inside the `volatile' group. Turns out that volatile enumerations
7121 were changing the type here to perform a validity test, which
7124 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7126 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7127 and structs, we do not want to load the instance variable
7129 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7130 enum_type has to be handled like an object reference (implicit
7131 conversions exists from this to object), but the regular IsClass
7132 and IsValueType tests will never return true for this one.
7134 Also we use TypeManager.IsValueType instead of type.IsValueType,
7135 just for consistency with the rest of the code (this is only
7136 needed if we ever use the construct exposed by test-180.cs inside
7137 corlib, which we dont today).
7139 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7141 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7144 2003-02-09 Martin Baulig <martin@ximian.com>
7146 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7147 (Namespace.DefineNamespaces): New static public method; this is
7148 called when we're compiling with debugging to add all namespaces
7151 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7152 pass it to the Namespace's .ctor.
7154 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7155 and MethodBase arguments; pass the namespace ID to the symwriter;
7156 pass the MethodBase instead of the token to the symwriter.
7157 (SymbolWriter.DefineNamespace): New method to add a namespace to
7160 2003-02-09 Martin Baulig <martin@ximian.com>
7162 * symbolwriter.cs: New file. This is a wrapper around
7163 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7164 methods here in near future.
7166 2003-02-09 Martin Baulig <martin@ximian.com>
7168 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7169 ILGenerator.MarkSequencePoint() which are actually used by the
7172 2003-02-09 Martin Baulig <martin@ximian.com>
7174 * location.cs (SourceFile): New public sealed class. This
7175 contains the name and an index which is used in the location's token.
7176 (Location): Reserve an appropriate number of bits in the token for
7177 the source file instead of walking over that list, this gives us a
7178 really huge performance improvement when compiling with debugging.
7180 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7181 `SourceFile' argument instead of a string.
7182 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7183 but don't parse/tokenize here, we need to generate the list of all
7184 source files before we do that.
7185 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7188 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7189 instead of a string.
7191 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7194 2003-02-09 Martin Baulig <martin@ximian.com>
7196 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7197 filename on `#line default'.
7199 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7201 * statement.cs: don't clear the pinned var when the fixed statement
7202 returns from the method (fixes bug#37752).
7204 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7206 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7209 2003-02-07 Martin Baulig <martin@ximian.com>
7211 * driver.cs: Removed the `--debug-args' command line argument.
7213 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7214 automatically by the AsssemblyBuilder.
7215 (CodeGen.InitializeSymbolWriter): We don't need to call any
7216 initialization function on the symbol writer anymore. This method
7217 doesn't take any arguments.
7219 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7221 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7222 from referenced assemblies as well.
7224 2003-02-02 Martin Baulig <martin@ximian.com>
7226 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7228 2003-02-02 Martin Baulig <martin@ximian.com>
7230 * class.cs (Constructor.Emit): Open the symbol writer before
7231 emitting the constructor initializer.
7232 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7233 single-stepping through constructor initializers.
7235 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7237 * class.cs: Handle error 549: do not allow virtual methods in
7240 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7242 * decl.cs: Check access levels when resolving types
7244 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7246 * statement.cs: Add parameters and locals set in catch blocks that might
7247 return to set vector
7249 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7251 * class.cs (Operator): Set the SpecialName flags for operators.
7253 * expression.cs (Invocation.DoResolve): Only block calls to
7254 accessors and operators on SpecialName methods.
7256 (Cast.TryReduce): Handle conversions from char constants.
7259 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7261 * statement.cs: small memory and time optimization in FlowBranching.
7263 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7265 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7266 problem that the last fix but in the other sid (Set).
7268 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7269 access when there is no indexer in the hierarchy.
7271 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7273 * class.cs: Combine some if statements.
7275 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7277 * driver.cs: fixed bug #37187.
7279 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7281 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7282 any indexer, it's needed to build a list with all the indexers in the
7283 hierarchy (AllGetters), else we have problems. Fixes #35653.
7285 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7287 * class.cs (MethodData.Define): It is wrong for an interface
7288 implementation to be static in both cases: explicit and implicit.
7289 We were only handling this in one case.
7291 Improve the if situation there to not have negations.
7293 * class.cs (Field.Define): Turns out that we do not need to check
7294 the unsafe bit on field definition, only on usage. Remove the test.
7296 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7298 * driver.cs: use assembly.Location instead of Codebase (the latest
7299 patch made mcs fail when using MS assemblies).
7301 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7303 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7304 get the path to *corlib.dll.
7306 2003-01-21 Nick Drochak <ndrochak@gol.com>
7310 * typemanager.cs: Remove compiler warnings
7312 2003-01-20 Duncan Mak <duncan@ximian.com>
7314 * AssemblyInfo.cs: Bump the version number to 0.19.
7316 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7318 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7320 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7322 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7324 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7326 * cs-parser.jay: Small fix: we were not comparing the constructor
7327 name correctly. Thanks to Zoltan for the initial pointer.
7329 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7331 * cs-tokenizer.cs: Set file name when specified with #line
7333 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7335 * cs-parser.jay: Only perform the constructor checks here if we
7336 are named like the class; This will help provider a better
7337 error. The constructor path is taken when a type definition is
7338 not found, but most likely the user forgot to add the type, so
7339 report that rather than the constructor error.
7341 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7343 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7346 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7348 * cs-parser.jay: Add cleanup call.
7350 2003-01-13 Duncan Mak <duncan@ximian.com>
7352 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7353 consistent with other methods.
7355 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7357 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7359 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7361 * attribute.cs: only set GuidAttr to true when we have a
7364 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7368 * typemanager.cs: fixes to allow mcs compile corlib with the new
7369 Type.IsSubclassOf fix.
7371 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7373 * expression.cs (LocalVariableReference.DoResolve): Classify a
7374 constant as a value, not as a variable. Also, set the type for
7377 * cs-parser.jay (fixed_statement): take a type instead of a
7378 pointer_type, so we can produce a better error message later.
7380 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7383 (For.DoEmit): Make inifinite loops have a
7384 non-conditional branch back.
7386 (Fixed.DoEmit): First populate the pinned variables, then emit the
7387 statement, then clear the variables. Before I was emitting the
7388 code once for each fixed piece.
7391 2003-01-08 Martin Baulig <martin@ximian.com>
7393 * statement.cs (FlowBranching.MergeChild): A break in a
7394 SWITCH_SECTION does not leave a loop. Fixes #36155.
7396 2003-01-08 Martin Baulig <martin@ximian.com>
7398 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7399 lives in the same number space than `param_map'. Fixes #36154.
7401 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7403 * cs-parser.jay (constructor_declaration): Set the
7404 Constructor.ModFlags before probing for it. This makes the
7405 compiler report 514, 515 and 132 (the code was there, but got
7408 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7409 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7410 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7412 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7414 * enum.cs: create the enum static fields using the enum type.
7416 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7418 * class.cs: don't try to create the ParamBuilder for the return
7419 type if it's not needed (and handle it breaking for the ms runtime
7422 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7424 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7426 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7428 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7429 the command. This showed up while compiling the JANET source
7430 code, which used \r as its only newline separator.
7432 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7434 * class.cs (Method.Define): If we are an operator (because it
7435 reuses our code), then set the SpecialName and HideBySig. #36128
7437 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7439 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7440 exception, report error 120 `object reference required'.
7442 * driver.cs: Add --pause option, used during to measure the size
7443 of the process as it goes with --timestamp.
7445 * expression.cs (Invocation.DoResolve): Do not allow methods with
7446 SpecialName to be invoked.
7448 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7450 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7451 number before adding it.
7453 2002-12-21 Ravi Pratap <ravi@ximian.com>
7455 * ecore.cs (StandardImplicitConversion): When in an unsafe
7456 context, we allow conversion between void * to any other pointer
7457 type. This fixes bug #35973.
7459 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7461 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7462 is not thrown when extensionless outputs are used
7464 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7466 * rootcontext.cs: fixed compilation of corlib.
7468 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7470 * attribute.cs (Attributes.Contains): Add new method.
7472 * class.cs (MethodCore.LabelParameters): if the parameter is an
7473 `out' parameter, check that no attribute `[In]' has been passed.
7475 * enum.cs: Handle the `value__' name in an enumeration.
7477 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7479 * decl.cs: Added special case to allow overrides on "protected
7482 2002-12-18 Ravi Pratap <ravi@ximian.com>
7484 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7485 since it makes much more sense.
7487 (Attributes.ctor): Don't require a Location parameter.
7489 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7491 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7492 since we already have that information per attribute.
7494 * everywhere : make appropriate changes.
7496 * class.cs (LabelParameters): Write the code which actually
7497 applies attributes to the return type. We can't do this on the MS
7498 .NET runtime so we flag a warning in the case an exception is
7501 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7503 * const.cs: Handle implicit null conversions here too.
7505 2002-12-17 Ravi Pratap <ravi@ximian.com>
7507 * class.cs (MethodCore.LabelParameters): Remove the extra
7508 Type [] parameter since it is completely unnecessary. Instead
7509 pass in the method's attributes so that we can extract
7510 the "return" attribute.
7512 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7514 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7515 of ignoring it and letting the compile continue.
7517 * typemanager.cs (ChangeType): use an extra argument to return an
7518 error condition instead of throwing an exception.
7520 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7522 * expression.cs (Unary.TryReduce): mimic the code for the regular
7523 code path. Perform an implicit cast in the cases where we can
7524 implicitly convert to one of the integral types, and then reduce
7525 based on that constant. This fixes bug #35483.
7527 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7529 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7531 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7533 * namespace.cs: fixed bug #35489.
7535 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7537 * class.cs: Remove some dead code.
7539 * cs-parser.jay: Estimate the number of methods needed
7540 (RootContext.MethodCount);
7542 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7543 numbers instead of StringBuilders.
7545 * support.cs (PtrHashtable): Add constructor with initial size;
7546 We can now reduce reallocations of the method table.
7548 2002-12-10 Ravi Pratap <ravi@ximian.com>
7550 * attribute.cs (ApplyAttributes): Keep track of the emitted
7551 attributes on a per-target basis. This fixes bug #35413.
7553 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7555 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7556 default to the Windows 1252 encoding.
7558 (UnixParseOption): Support version, thanks to Alp for the missing
7561 * AssemblyInfo.cs: Add nice assembly information.
7563 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7566 * cs-parser.jay: Allow a trailing comma before the close bracked
7567 in the attribute_section production.
7569 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7570 address of the instance was being taken, I will take this out,
7571 because we take the address of the object immediately here.
7573 2002-12-09 Ravi Pratap <ravi@ximian.com>
7575 * typemanager.cs (AreMultipleAllowed): Take care of the most
7576 obvious case where attribute type is not in the current assembly -
7579 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7581 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7582 definitions, instead of doing that afterwards.
7584 Also we use a nice little hack, depending on the constructor, we
7585 know if we are a "composed" name or a simple name. Hence, we
7586 avoid the IndexOf test, and we avoid
7588 * codegen.cs: Add code to assist in a bug reporter to track down
7589 the source of a compiler crash.
7591 2002-12-07 Ravi Pratap <ravi@ximian.com>
7593 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7594 types have been emitted for a given element and flag an error
7595 if something which does not have AllowMultiple set is used more
7598 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7599 attribute types and their corresponding AllowMultiple properties
7601 (AreMultipleAllowed): Check the property for a given type.
7603 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7604 property in the case we have a TypeContainer.
7606 (Attributes.AddAttribute): Detect duplicates and just skip on
7607 adding them. This trivial fix catches a pretty gross error in our
7608 attribute emission - global attributes were being emitted twice!
7610 Bugzilla bug #33187 is now fixed.
7612 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7614 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7617 * expression.cs (Binary.ResolveOperator): I can only use the
7618 Concat (string, string, string) and Concat (string, string,
7619 string, string) if the child is actually a concatenation of
7622 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7624 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7625 context where we need a 2-character lookahead.
7627 * pending.cs (PendingImplementation): Rework so we can keep track
7628 of interface types all the time, and flag those which were
7629 implemented by parents as optional.
7631 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7633 * expression.cs (Binary.ResolveOperator): Use
7634 String.Concat(string,string,string) or
7635 String.Concat(string,string,string,string) when possible.
7637 * typemanager: More helper methods.
7640 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7642 * pending.cs: remove the bogus return from GetMissingInterfaces()
7643 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7645 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7647 * namespace.cs: avoid duplicated 'using xxx' being added to
7648 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7649 when we get more than one 'using' statement for the same namespace.
7650 Report a CS0105 warning for it.
7652 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7654 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7655 of calling getChar/putback, uses internal knowledge of it.
7657 (xtoken): Reorder tokenizer so most common patterns are checked
7658 first. This reduces the compilation time in another 5% (from 8.11s
7659 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7661 The parsing time is 22% of the compilation in mcs, and from that
7662 64% is spent on the tokenization process.
7664 I tried using a binary search for keywords, but this is slower
7665 than the hashtable. Another option would be to do a couple of
7668 * Not use a StringBuilder, instead use an array of chars,
7669 with a set value. Notice that this way we could catch
7670 the 645 error without having to do it *afterwards*.
7672 * We could write a hand-parser to avoid the hashtable
7673 compares altogether.
7675 The identifier consumption process takes 37% of the tokenization
7676 time. Another 15% is spent on is_number. 56% of the time spent
7677 on is_number is spent on Int64.Parse:
7679 * We could probably choose based on the string length to
7680 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7683 Another 3% is spend on wrapping `xtoken' in the `token' function.
7685 Handle 0xa0 as whitespace (#34752)
7687 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7689 * typemanager.cs (IsCLRType): New routine to tell whether a type
7690 is one of the builtin types.
7692 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7693 typecode in more places instead of doing pointer comparissions.
7694 We could leverage some knowledge about the way the typecodes are
7697 New code to cache namespaces in assemblies, it is currently not
7698 invoked, to be used soon.
7700 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7702 * expression.cs (Binary.ResolveOperator): specially handle
7703 strings, and do not perform user-defined operator overloading for
7706 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7708 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7709 internalcall as it is a pretty simple operation; Avoid whenever
7710 possible to call Char.IsLetter.
7712 (consume_identifier): Cut by half the number of
7713 hashtable calls by merging the is_keyword and GetKeyword behavior.
7715 Do not short-circuit, because if we do, we
7716 report errors (ie, #if false && true would produce an invalid
7720 2002-11-24 Martin Baulig <martin@ximian.com>
7722 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7723 check constant ranges and report a CS0221. Fixes #33186.
7725 2002-11-24 Martin Baulig <martin@ximian.com>
7727 * cs-parser.jay: Make this work for uninitialized variable
7728 declarations in the `for' initializer. Fixes #32416.
7730 2002-11-24 Martin Baulig <martin@ximian.com>
7732 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7733 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7735 2002-11-24 Martin Baulig <martin@ximian.com>
7737 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7738 argument; if true, we also check for user-defined conversions.
7739 This is only needed if both arguments are of a user-defined type.
7740 Fixes #30443, added test-175.cs.
7741 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7743 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7745 2002-11-24 Martin Baulig <martin@ximian.com>
7747 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7748 function to get the store opcode.
7749 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7750 only emit the Ldelema if the store opcode is Stobj. You must run
7751 both test-34 and test-167 to test this. Fixes #34529.
7753 2002-11-23 Martin Baulig <martin@ximian.com>
7755 * ecore.cs (Expression.MemberLookup): Added additional
7756 `qualifier_type' argument which is used when we're being called
7757 from MemberAccess.DoResolve() and null if we're called from a
7759 (Expression.MemberLookupFailed): New method to report errors; this
7760 does the CS1540 check and reports the correct error message.
7762 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7763 argument for the CS1540 check and redone the way how we're dealing
7764 with private members. See the comment in the source code for details.
7765 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7766 `closure_start_type' to `closure_qualifier_type' and check whether
7767 it's not null. It was not this filter being broken, it was just
7768 being called with the wrong arguments.
7770 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7771 and pass it the correct `qualifier_type'; this also does the error
7774 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7776 * expression.cs (Invocation.EmitParams): If the we are dealing
7777 with a non-built-in value type, load its address as well.
7779 (ArrayCreation): Use a a pretty constant instead
7780 of the hardcoded value 2. Use 6 instead of 2 for the number of
7781 static initializers.
7783 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7784 because they are not really value types, just glorified integers.
7786 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7788 * ecore.cs: Remove redundant code for enumerations, make them use
7789 the same code path as everything else, fixes the casting issue
7790 with enumerations in Windows.Forms.
7792 * attribute.cs: Do only cast to string if it is a string, the
7793 validation happens later.
7795 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7796 people upgrade their corlibs.
7798 * ecore.cs: Oops, enumerations were not following the entire code path
7800 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7802 * typemanager.cs (FilterWithClosure): Commented out the test for
7803 1540 in typemanager.cs, as it has problems when accessing
7804 protected methods from a parent class (see test-174.cs).
7806 * attribute.cs (Attribute.ValidateGuid): new method.
7807 (Attribute.Resolve): Use above.
7809 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7811 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7813 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7814 handling for enumerations, as we only needed the TypeContainer
7815 functionality to begin with (this is required for the fix below to
7816 work for enums that reference constants in a container class for
7819 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7821 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7822 a valid TypeBuilder to perform lookups on.o
7824 * class.cs (InheritableMemberSignatureCompare): Use true in the
7825 call to GetGetMethod and GetSetMethod, because we are comparing
7826 the signature, and we need to get the methods *even* if they are
7829 (PropertyBase.CheckBase): ditto.
7831 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7832 GotoCase.Resolve): Use Peel on EmpytCasts.
7834 * ecore.cs (EmptyCast): drop child, add Peel method.
7836 2002-11-17 Martin Baulig <martin@ximian.com>
7838 * ecore.cs (EmptyCast.Child): New public property.
7840 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7841 label resolved to an EmptyCast. Fixes #34162.
7842 (GotoCase.Resolve): Likewise.
7843 (Block.EmitMeta): Likewise.
7845 2002-11-17 Martin Baulig <martin@ximian.com>
7847 * expression.cs (Invocation.BetterConversion): Prefer int over
7848 uint; short over ushort; long over ulong for integer literals.
7849 Use ImplicitConversionExists instead of StandardConversionExists
7850 since we also need to check for user-defined implicit conversions.
7851 Fixes #34165. Added test-173.cs.
7853 2002-11-16 Martin Baulig <martin@ximian.com>
7855 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7856 with the `true' and `false' literals. Fixes #33151.
7858 2002-11-16 Martin Baulig <martin@ximian.com>
7860 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7861 October 22nd; don't do the cs1540 check for static members.
7863 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7864 now using our own filter here and doing the cs1540 check again.
7866 2002-11-16 Martin Baulig <martin@ximian.com>
7868 * support.cs (InternalParameters): Don't crash if we don't have
7869 any fixed parameters. Fixes #33532.
7871 2002-11-16 Martin Baulig <martin@ximian.com>
7873 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7874 when looking up static methods to make this work on Windows.
7877 2002-11-16 Martin Baulig <martin@ximian.com>
7879 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7880 a setter rather than using PropertyInfo.CanWrite.
7882 2002-11-15 Nick Drochak <ndrochak@gol.com>
7884 * class.cs: Allow acces to block member by subclasses. Fixes build
7887 2002-11-14 Martin Baulig <martin@ximian.com>
7889 * class.cs (Constructor.Emit): Added the extern/block check.
7892 2002-11-14 Martin Baulig <martin@ximian.com>
7894 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
7895 iteration while looking for indexers, this is needed because the
7896 indexer may have a different name in our base classes. Fixed the
7897 error reporting (no indexers at all, not get accessor, no
7898 overloaded match). Fixes bug #33089.
7899 (IndexerAccess.DoResolveLValue): Likewise.
7901 2002-11-14 Martin Baulig <martin@ximian.com>
7903 * class.cs (PropertyBase.CheckBase): Make this work for multiple
7904 indexers. Fixes the first part of bug #33089.
7905 (MethodSignature.InheritableMemberSignatureCompare): Added support
7908 2002-11-13 Ravi Pratap <ravi@ximian.com>
7910 * attribute.cs (Attribute.Resolve): Catch the
7911 NullReferenceException and report it since it isn't supposed to
7914 2002-11-12 Miguel de Icaza <miguel@ximian.com>
7916 * expression.cs (Binary.EmitBranchable): Also handle the cases for
7917 LogicalOr and LogicalAnd that can benefit from recursively
7918 handling EmitBranchable. The code now should be nice for Paolo.
7920 2002-11-08 Miguel de Icaza <miguel@ximian.com>
7922 * typemanager.cs (LookupType): Added a negative-hit hashtable for
7923 the Type lookups, as we perform quite a number of lookups on
7924 non-Types. This can be removed once we can deterministically tell
7925 whether we have a type or a namespace in advance.
7927 But this might require special hacks from our corlib.
7931 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
7932 and double which avoids a conversion from an integer to a double.
7934 * expression.cs: tiny optimization, avoid calling IsConstant,
7935 because it effectively performs the lookup twice.
7937 2002-11-06 Miguel de Icaza <miguel@ximian.com>
7939 But a bogus return here to keep the semantics of the old code
7940 until the Mono runtime is fixed.
7942 * pending.cs (GetMissingInterfaces): New method used to remove all
7943 the interfaces that are already implemented by our parent
7944 classes from the list of pending methods.
7946 * interface.cs: Add checks for calls after ResolveTypeExpr.
7948 2002-11-05 Miguel de Icaza <miguel@ximian.com>
7950 * class.cs (Class.Emit): Report warning 67: event not used if the
7951 warning level is beyond 3.
7953 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
7954 being a NullLiteral.
7956 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
7959 * class.cs (TypeContainer.GetClassBases): Cover a missing code
7960 path that might fail if a type can not be resolved.
7962 * expression.cs (Binary.Emit): Emit unsigned versions of the
7965 * driver.cs: use error 5.
7967 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
7969 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
7971 2002-11-01 Miguel de Icaza <miguel@ximian.com>
7973 * cs-parser.jay (switch_section): A beautiful patch from Martin
7974 Baulig that fixed 33094.
7976 2002-10-31 Miguel de Icaza <miguel@ximian.com>
7978 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
7979 Check whether the base is abstract and report an error if so.
7981 * expression.cs (IndexerAccess.DoResolveLValue,
7982 IndexerAccess.DoResolve): ditto.
7984 (Invocation.DoResolve): ditto.
7986 (Invocation.FullMethodDesc): Improve the report string.
7988 * statement.cs (Block): Eliminate IsVariableDefined as it is
7989 basically just a wrapper for GetVariableInfo.
7991 * ecore.cs (SimpleName): Use new
7993 * support.cs (ReflectionParamter.ParameterType): We unwrap the
7994 type, as we return the actual parameter ref/unref state on a
7997 2002-10-30 Miguel de Icaza <miguel@ximian.com>
7999 * support.cs: Return proper flags REF/OUT fixing the previous
8002 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8003 not used to mean `ref' but `ref or out' in ParameterReference
8005 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8006 full type signature instead of calling TypeManger.CSharpName
8009 * support.cs (InternalParameters.ParameterDesc): Do not compare
8010 directly to the modflags, because REF/OUT will actually be bitsets
8013 * delegate.cs (VerifyMethod): Check also the modifiers.
8015 * cs-tokenizer.cs: Fix bug where floating point values with an
8016 exponent where a sign was missing was ignored.
8018 * driver.cs: Allow multiple assemblies to be specified in a single
8021 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8023 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8024 because identifiers after a parenthesis would end up in this kind
8025 of production, and we needed to desamiguate it for having casts
8028 (UserDefinedType *) xxx
8030 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8032 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8033 we should set on the Bindingflags.NonPublic, but not turn on
8034 private_ok. private_ok controls whether a Private member is
8035 returned (this is chekced on the filter routine), while the
8036 BindingFlags.NonPublic just controls whether private/protected
8037 will be allowed. This fixes the problem part of the problem of
8038 private properties being allowed to be used in derived classes.
8040 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8041 so we can call the children DoResolveLValue method (this will
8042 properly signal errors on lvalue assignments to base properties)
8044 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8045 getter are null, and we have a property info, we know that this
8046 happened because the lookup failed, so we report an error 122 for
8047 protection level violation.
8049 We also silently return if setter and getter are null in the
8050 resolve functions, this condition only happens if we have flagged
8051 the error before. This is the other half of the problem.
8053 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8054 not have accessibility information, that is why we were returning
8055 true in the filter function in typemanager.cs.
8057 To properly report 122 (property is inaccessible because of its
8058 protection level) correctly, we report this error in ResolveAccess
8059 by failing if both the setter and the getter are lacking (ie, the
8062 DoResolve and DoLResolve have been modified to check for both
8063 setter/getter being null and returning silently, the reason being
8064 that I did not want to put the knowledge about this error in upper
8067 int old = Report.Errors;
8068 x = new PropertyExpr (...);
8069 if (old != Report.Errors)
8074 So the property expr is returned, but it is invalid, so the error
8075 will be flagged during the resolve process.
8077 * class.cs: Remove InheritablePropertySignatureCompare from the
8078 class, as we no longer depend on the property signature to compute
8079 whether it is possible to implement a method or not.
8081 The reason is that calling PropertyInfo.GetGetMethod will return
8082 null (in .NET, in Mono it works, and we should change this), in
8083 cases where the Get Method does not exist in that particular
8088 class X { public virtual int A { get { return 1; } } }
8090 class Z : Y { public override int A { get { return 2; } } }
8092 Would fail in Z because the parent (Y) would not have the property
8093 defined. So we avoid this completely now (because the alternative
8094 fix was ugly and slow), and we now depend exclusively on the
8097 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8098 reference method, instead of using the property.
8100 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8101 routines are gone now.
8103 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8104 names, they were incorrectly named.
8106 * cs-tokenizer.cs: Return are more gentle token on failure.
8108 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8109 had an out-of-sync index variable, which caused it to remove from
8110 the list of pending methods the wrong method sometimes.
8112 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8114 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8115 CanWrite, because those refer to this particular instance of the
8116 property, and do not take into account the fact that we can
8117 override single members of a property.
8119 Constructor requires an EmitContext. The resolution process does
8120 not happen here, but we need to compute the accessors before,
8121 because the resolution does not always happen for properties.
8123 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8124 subclass, before we did not update this flag, but we did update
8127 (GetAccessors): Drop this routine, as it did not work in the
8128 presence of partially overwritten set/get methods.
8130 Notice that this broke the cs1540 detection, but that will require
8133 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8137 * driver.cs: issue a warning instead of an error if we don't support
8138 debugging for the platform. Also ignore a couple of errors that may
8139 arise when trying to write the symbols. Undo my previous patch.
8141 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8143 * driver.cs: ignore /debug switch except for Unix platforms.
8145 2002-10-23 Nick Drochak <ndrochak@gol.com>
8147 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8149 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8151 * driver.cs: Do not make mcs-debug conditional, so we do not break
8154 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8155 review this patch. But basically after all the children variables
8156 have been merged, the value of "Breaks" was not being set to
8157 new_breaks for Switch blocks. I think that it should be set after
8158 it has executed. Currently I set this to the value of new_breaks,
8159 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8160 conservative, but I do not understand this code very well.
8162 I did not break anything in the build, so that is good ;-)
8164 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8166 2002-10-20 Mark Crichton <crichton@gimp.org>
8168 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8170 2002-10-20 Nick Drochak <ndrochak@gol.com>
8172 * cfold.cs: Fixed compile blocker.
8174 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8176 * driver.cs: I was chekcing the key, not the file.
8178 2002-10-19 Ravi Pratap <ravi@ximian.com>
8180 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8181 message that we were generating - we just need to silently return
8184 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8186 * class.cs (Event.Define): Change my previous commit, as this
8187 breaks the debugger. This is a temporary hack, as it seems like
8188 the compiler is generating events incorrectly to begin with.
8190 * expression.cs (Binary.ResolveOperator): Added support for
8191 "U operator - (E x, E y)"
8193 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8196 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8197 init-only variables, but this path did not take into account that
8198 there might be also instance readonly variables. Correct this
8201 This fixes bug 32253
8203 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8206 * driver.cs: Change the extension for modules to `netmodule'
8208 * cs-parser.jay: Improved slightly the location tracking for
8209 the debugger symbols.
8211 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8212 modifiers that were specified instead of the hardcoded value
8213 (FamAndAssem). This was basically ignoring the static modifier,
8214 and others. Fixes 32429.
8216 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8217 fixed a bug in the process (32476)
8219 * expression.cs (ArrayAccess.EmitAssign): Patch from
8220 hwang_rob@yahoo.ca that fixes bug 31834.3
8222 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8224 * driver.cs: Make the module extension .netmodule.
8226 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8228 * driver.cs: Report an error if the resource file is not found
8229 instead of crashing.
8231 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8232 false, like Emit does.
8234 2002-10-16 Nick Drochak <ndrochak@gol.com>
8236 * typemanager.cs: Remove unused private member. Also reported mcs
8237 bug to report this as a warning like csc.
8239 2002-10-15 Martin Baulig <martin@gnome.org>
8241 * statement.cs (Statement.Emit): Made this a virtual method; emits
8242 the line number info and calls DoEmit().
8243 (Statement.DoEmit): New protected abstract method, formerly knows
8244 as Statement.Emit().
8246 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8248 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8250 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8251 have fixed a remaining problem: not every AddXXXX was adding a
8252 fully qualified name.
8254 Now everyone registers a fully qualified name in the DeclSpace as
8255 being defined instead of the partial name.
8257 Downsides: we are slower than we need to be due to the excess
8258 copies and the names being registered this way.
8260 The reason for this is that we currently depend (on the corlib
8261 bootstrap for instance) that types are fully qualified, because
8262 we dump all the types in the namespace, and we should really have
8263 types inserted into the proper namespace, so we can only store the
8264 basenames in the defined_names array.
8266 2002-10-10 Martin Baulig <martin@gnome.org>
8268 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8269 from bug #31834, see the bug report for a testcase which is
8272 2002-10-10 Martin Baulig <martin@gnome.org>
8274 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8275 flow analysis code for this.
8277 * statement.cs (Do, While, For): Tell the flow analysis code about
8279 (FlowBranching.UsageVector): Added support for infinite loops.
8280 (Block.Resolve): Moved the dead code elimination here and use flow
8283 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8285 * class.cs (Field.Define): Catch cycles on struct type
8288 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8289 fields if the fields are static. We only need to check instance
8292 * expression.cs (As.DoResolve): Test for reference type.
8294 * statement.cs (Using.ResolveExpression): Use
8295 ConvertImplicitRequired, not ConvertImplicit which reports an
8297 (Using.ResolveLocalVariableDecls): ditto.
8299 * expression.cs (Binary.ResolveOperator): Report errors in a few
8300 places where we had to.
8302 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8304 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8306 * expression.cs: Use StoreFromPtr instead of extracting the type
8307 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8309 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8310 an enumeration value to a System.Enum, but System.Enum is not a
8311 value type, but an class type, so we need to box.
8313 (Expression.ConvertExplicit): One codepath could return
8314 errors but not flag them. Fix this. Fixes #31853
8316 * parameter.cs (Resolve): Do not allow void as a parameter type.
8318 2002-10-06 Martin Baulig <martin@gnome.org>
8320 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8321 if it's a class type and not a struct. Fixes #31815.
8323 2002-10-06 Martin Baulig <martin@gnome.org>
8325 * statement.cs: Reworked the flow analysis code a bit to make it
8326 usable for dead code elimination.
8328 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8330 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8332 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8334 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8335 to fix the test 165, will investigate deeper.
8337 2002-10-04 Martin Baulig <martin@gnome.org>
8339 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8340 finally blocks actually work.
8341 (Try.Resolve): We don't need to create a sibling for `finally' if
8342 there is no finally block.
8344 2002-10-04 Martin Baulig <martin@gnome.org>
8346 * class.cs (Constructor.Define): The default accessibility for a
8347 non-default constructor is private, not public.
8349 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8351 * class.cs (Constructor): Make AllowedModifiers public, add
8354 * cs-parser.jay: Perform the modifiers test here, as the
8355 constructor for the Constructor class usually receives a zero
8356 because of the way we create it (first we create, later we
8357 customize, and we were never checking the modifiers).
8359 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8360 is a version of LookupTypeReflection that includes the type-name
8361 cache. This can be used as a fast path for functions that know
8362 the fully qualified name and are only calling into *.GetType() to
8363 obtain a composed type.
8365 This is also used by TypeManager.LookupType during its type
8368 (LookupType): We now also track the real type name, as sometimes
8369 we can get a quey for the real type name from things like
8370 ComposedCast. This fixes bug 31422.
8372 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8373 complete type fullname, it does not have to go through the type
8374 resolution system to obtain the composed version of the type (for
8375 obtaining arrays or pointers).
8377 (Conditional.Emit): Use the EmitBoolExpression to
8378 generate nicer code, as requested by Paolo.
8380 (ArrayCreation.CheckIndices): Use the patch from
8381 hwang_rob@yahoo.ca to validate the array initializers.
8383 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8385 * class.cs (ConstructorInitializer.Emit): simplify code by using
8386 Invocation.EmitCall, and at the same time, fix the bugs in calling
8387 parent constructors that took variable arguments.
8389 * ecore.cs (Expression.ConvertNumericExplicit,
8390 Expression.ImplicitNumericConversion): Remove the code that
8391 manually wrapped decimal (InternalTypeConstructor call is now gone
8394 * expression.cs (Cast.TryReduce): Also handle decimal types when
8395 trying to perform a constant fold on the type.
8397 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8399 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8400 that only turned off an error report, and did nothing else.
8402 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8404 * driver.cs: Handle and ignore /fullpaths
8406 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8408 * expression.cs (Binary.ResolveOperator): Catch the case where
8409 DoNumericPromotions returns true,
8411 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8413 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8415 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8418 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8420 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8421 conversion exists, but it is also required that the conversion be
8422 performed. This manifested in "(Type64Enum) 2".
8424 * class.cs (TypeManager.AddMethod): The fix is not to change
8425 AddEnum, because that one was using a fully qualified name (every
8426 DeclSpace derivative does), but to change the AddMethod routine
8427 that was using an un-namespaced name. This now correctly reports
8428 the duplicated name.
8430 Revert patch until I can properly fix it. The issue
8431 is that we have a shared Type space across all namespaces
8432 currently, which is wrong.
8434 Options include making the Namespace a DeclSpace, and merge
8435 current_namespace/current_container in the parser.
8437 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8439 * cs-parser.jay: Improve error reporting when we get a different
8440 kind of expression in local_variable_type and
8441 local_variable_pointer_type.
8443 Propagate this to avoid missleading errors being reported.
8445 * ecore.cs (ImplicitReferenceConversion): treat
8446 TypeManager.value_type as a target just like object_type. As
8451 Is valid, and needs to result in the int 1 being boxed before it
8452 is assigned to the value type v.
8454 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8455 to validate the enumeration name.
8457 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8458 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8459 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8461 * ecore.cs (TryImplicitIntConversion): When doing an
8462 implicit-enumeration-conversion, check if the type is 64-bits and
8463 perform a conversion before passing to EnumConstant.
8465 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8467 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8468 report ambiguous type references. Unlike the MS version, we
8469 report what the ambiguity is. Innovation at work ;-)
8471 (DeclSpace.FindType): Require a location argument to
8472 display when we display an ambiguous error.
8474 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8476 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8478 * expression.cs (EmitDynamicInitializers): Apply patch from
8479 hwang_rob@yahoo.ca that fixes the order in which we emit our
8482 2002-09-21 Martin Baulig <martin@gnome.org>
8484 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8485 delegate takes no arguments.
8487 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8489 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8492 * expression.cs: Extract the underlying type.
8494 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8496 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8498 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8500 * class.cs (TypeContainer.DefineType): We can not use the nice
8501 PackingSize with the size set to 1 DefineType method, because it
8502 will not allow us to define the interfaces that the struct
8505 This completes the fixing of bug 27287
8507 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8508 means also structs. This fixes part of the problem.
8509 (Expresion.ImplicitReferenceConversionExists): ditto.
8511 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8512 error if there were no errors reported during the type lookup
8513 process, to avoid duplicates or redundant errors. Without this
8514 you would get an ambiguous errors plus a type not found. We have
8515 beaten the user enough with the first error.
8517 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8520 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8521 during the resolution process, stop the lookup, this avoids
8522 repeated error reports (same error twice).
8524 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8526 * typemanager.cs (LookupType): Redo the type lookup code to match
8527 the needs of System.Reflection.
8529 The issue is that System.Reflection requires references to nested
8530 types to begin with a "+" sign instead of a dot. So toplevel
8531 types look like: "NameSpace.TopLevelClass", and nested ones look
8532 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8535 2002-09-19 Martin Baulig <martin@gnome.org>
8537 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8538 says that a method always returns or always throws an exception,
8539 don't report the CS0161.
8541 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8542 set `Returns = new_returns'.
8544 2002-09-19 Martin Baulig <martin@gnome.org>
8546 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8547 to an enum constant, check for a CS0176.
8549 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8551 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8552 for operators that must be in pairs and report errors.
8554 * ecore.cs (SimpleName.DoResolveType): During the initial type
8555 resolution process, when we define types recursively, we must
8556 check first for types in our current scope before we perform
8557 lookups in the enclosing scopes.
8559 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8561 (Invocation.VerifyArgumentsCompat): Call
8562 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8563 I thought we were supposed to always call this, but there are a
8564 few places in the code where we dont do it.
8566 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8568 * driver.cs: Add support in -linkres and -resource to specify the
8569 name of the identifier.
8571 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8573 * ecore.cs (StandardConversionExists): Sync with the conversion
8574 code: allow anything-* to void* conversions.
8576 (FindMostSpecificSource): Use an Expression argument
8577 instead of a Type, because we might be handed over a Literal which
8578 gets a few more implicit conversions that plain types do not. So
8579 this information was being lost.
8581 Also, we drop the temporary type-holder expression when not
8584 2002-09-17 Martin Baulig <martin@gnome.org>
8586 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8587 this is an explicit interface implementation.
8589 2002-09-17 Martin Baulig <martin@gnome.org>
8591 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8592 different `IndexerName' attributes.
8594 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8595 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8596 virtual CommonResolve().
8598 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8600 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8601 and convert that to the UnderlyingType.
8603 * statement.cs (Foreach.Resolve): Indexers are just like variables
8604 or PropertyAccesses.
8606 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8607 inside quoted strings, we were not doing this before.
8609 2002-09-16 Martin Baulig <martin@gnome.org>
8611 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8612 resolve it. This is needed for the definite assignment check of the
8613 instance expression, fixes bug #29846.
8614 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8616 2002-09-16 Nick Drochak <ndrochak@gol.com>
8618 * parameter.cs: Fix compile error. Cannot reference static member
8619 from an instance object. Is this an mcs bug?
8621 2002-09-14 Martin Baulig <martin@gnome.org>
8623 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8624 multiple times. Fixes bug #30295, added test-166.cs.
8626 2002-09-14 Martin Baulig <martin@gnome.org>
8628 * statement.cs (Block.Emit): Don't emit unreachable code.
8629 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8631 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8633 2002-09-14 Martin Baulig <martin@gnome.org>
8635 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8638 2002-09-14 Martin Baulig <martin@gnome.org>
8640 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8641 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8642 be false on the ms runtime.
8644 2002-09-13 Martin Baulig <martin@gnome.org>
8646 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8647 the CS0038 error message.
8649 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8651 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8652 constant inside, return it.
8654 2002-09-12 Martin Baulig <martin@gnome.org>
8656 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8657 implicit conversion can be done between enum types.
8659 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8660 check whether an implicit conversion to the current enum's UnderlyingType
8661 exists and report an error if not.
8663 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8664 without debugging support.
8666 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8667 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8669 2002-09-12 Martin Baulig <martin@gnome.org>
8671 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8673 * ecore.cs (IMemberExpr.DeclaringType): New property.
8674 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8675 nonstatic member of an outer type (CS0038).
8677 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8679 * driver.cs: Activate the using-error detector at warning level
8680 4 (at least for MS-compatible APIs).
8682 * namespace.cs (VerifyUsing): Small buglett fix.
8684 * pending.cs (PendingImplementation): pass the container pointer.
8686 * interface.cs (GetMethods): Allow for recursive definition. Long
8687 term, I would like to move every type to support recursive
8688 definitions, not the current ordering mechanism that we have right
8691 The situation is this: Attributes are handled before interfaces,
8692 so we can apply attributes to interfaces. But some attributes
8693 implement interfaces, we will now handle the simple cases
8694 (recursive definitions will just get an error).
8696 * parameter.cs: Only invalidate types at the end if we fail to
8699 2002-09-09 Martin Baulig <martin@gnome.org>
8701 * ecore.cs (PropertyExpr.Emit): Also check for
8702 TypeManager.system_int_array_get_length so this'll also work when
8703 compiling corlib. Fixes #30003.
8705 2002-09-09 Martin Baulig <martin@gnome.org>
8707 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8708 and throw an exception if we can't get the type's size. Fixed #30040,
8711 2002-09-09 Martin Baulig <martin@gnome.org>
8713 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8715 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8716 context. Fixes bug #30027.
8718 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8719 virtual functions. Fixes bug #30043, added test-164.cs.
8721 2002-09-08 Ravi Pratap <ravi@ximian.com>
8723 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8725 2002-09-08 Nick Drochak <ndrochak@gol.com>
8727 * driver.cs: Use an object to get the windows codepage since it's not a
8730 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8732 * statement.cs (For.Emit): for infinite loops (test == null)
8733 return whether there is a break inside, not always "true".
8735 * namespace.cs (UsingEntry): New struct to hold the name of the
8736 using definition, the location where it is defined, and whether it
8737 has been used in a successful type lookup.
8739 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8744 2002-09-06 Ravi Pratap <ravi@ximian.com>
8746 * attribute.cs : Fix incorrect code which relied on catching
8747 a NullReferenceException to detect a null being passed in
8748 where an object was expected.
8750 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8752 * statement.cs (Try): flag the catch variable as assigned
8754 * expression.cs (Cast): Simplified by using ResolveType instead of
8757 * statement.cs (Catch): Fix bug by using ResolveType.
8759 2002-09-06 Ravi Pratap <ravi@ximian.com>
8761 * expression.cs (BetterConversion): Special case for when we have
8762 a NullLiteral as the argument and we have to choose between string
8763 and object types - we choose string the way csc does.
8765 * attribute.cs (Attribute.Resolve): Catch the
8766 NullReferenceException and report error #182 since the Mono
8767 runtime no more has the bug and having this exception raised means
8768 we tried to select a constructor which takes an object and is
8771 2002-09-05 Ravi Pratap <ravi@ximian.com>
8773 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8774 message (1502, 1503) when we can't locate a method after overload
8775 resolution. This is much more informative and closes the bug
8778 * interface.cs (PopulateMethod): Return if there are no argument
8779 types. Fixes a NullReferenceException bug.
8781 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8782 expressions too. Previously we were checking only in one place for
8783 positional arguments leaving out named arguments.
8785 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8786 type to the enum type is not allowed. Remove code corresponding to
8789 (ConvertNumericExplicit): Allow explicit conversions from
8790 the underlying type to enum type. This precisely follows the spec
8791 and closes a bug filed by Gonzalo.
8793 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8796 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8798 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8800 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8801 it was important that we stored the right value after the
8802 reduction in `converted'.
8804 2002-09-04 Martin Baulig <martin@gnome.org>
8806 * location.cs (Location.SymbolDocument): Use full pathnames for the
8809 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8811 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8812 of the expression resolve mechanism, because that will catch the
8813 SimpleName error failures.
8815 (Conditional): If we can not resolve the
8816 expression, return, do not crash.
8818 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8821 (location): display token name instead of its number.
8823 2002-08-28 Martin Baulig <martin@gnome.org>
8825 * expression.cs (Binary.ResolveOperator): Don't silently return
8826 but return an error if an operator cannot be applied between two
8829 2002-08-28 Martin Baulig <martin@gnome.org>
8831 * class.cs (Constructor.Define): Set the permission attributes
8832 correctly instead of making all constructors public.
8834 2002-08-28 Martin Baulig <martin@gnome.org>
8836 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8837 for private members before reporting a CS0103; if we find anything,
8840 2002-08-28 Martin Baulig <martin@gnome.org>
8842 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8843 to check whether `closure_start_type == closure_invocation_type',
8844 we also need to check whether `m.DeclaringType == closure_invocation_type'
8845 before bypassing the permission checks. We might be accessing
8846 protected/private members from the base class.
8847 (TypeManager.RealMemberLookup): Only set private_ok if private
8848 members were requested via BindingFlags.NonPublic.
8850 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8852 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8853 MethodGroupExpr.IsExplicitImpl if appropriate.
8854 (Invocation.DoResolve): Don't report the CS0120 for explicit
8855 interface implementations.
8857 2002-08-27 Martin Baulig <martin@gnome.org>
8859 * expression.cs (Invocation.DoResolve): If this is a static
8860 method and we don't have an InstanceExpression, we must report
8863 2002-08-25 Martin Baulig <martin@gnome.org>
8865 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8866 `==' between a valuetype and an object.
8868 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8870 * ecore.cs (TypeExpr): Provide a ToString method.
8872 2002-08-24 Martin Baulig <martin@gnome.org>
8874 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8875 now called proggie.dbg and it's a binary file.
8877 2002-08-23 Martin Baulig <martin@gnome.org>
8879 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8881 2002-08-23 Martin Baulig <martin@gnome.org>
8883 * struct.cs (MyStructInfo.ctor): Make this work with empty
8884 structs; it's not allowed to use foreach() on null.
8886 2002-08-23 Martin Baulig <martin@gnome.org>
8888 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
8889 writer the full pathname of the generated assembly.
8891 2002-08-23 Martin Baulig <martin@gnome.org>
8893 * statements.cs (FlowBranching.UsageVector.MergeChildren):
8894 A `finally' block never returns or breaks; improved handling of
8897 2002-08-23 Martin Baulig <martin@gnome.org>
8899 * statement.cs (Throw.Resolve): Allow `throw null'.
8901 2002-08-23 Martin Baulig <martin@gnome.org>
8903 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
8904 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
8905 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
8906 MemberLookup would return a wrong event if this is an explicit
8907 interface implementation and the class has an event with the same
8910 2002-08-23 Martin Baulig <martin@gnome.org>
8912 * statement.cs (Block.AddChildVariableNames): New public method.
8913 (Block.AddChildVariableName): Likewise.
8914 (Block.IsVariableNameUsedInChildBlock): Likewise.
8915 (Block.AddVariable): Check whether a variable name has already
8916 been used in a child block.
8918 * cs-parser.jay (declare_local_variables): Mark all variable names
8919 from the current block as being used in a child block in the
8922 2002-08-23 Martin Baulig <martin@gnome.org>
8924 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
8925 find the symbol writer.
8927 * driver.cs: csc also allows the arguments to /define being
8928 separated by commas, not only by semicolons.
8930 2002-08-23 Martin Baulig <martin@gnome.org>
8932 * interface.cs (Interface.GetMembers): Added static check for events.
8934 2002-08-15 Martin Baulig <martin@gnome.org>
8936 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
8937 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
8939 * ecore.cs (Expression.MemberLookup): Added documentation and explained
8940 why the MethodData.EmitDestructor() change was necessary.
8942 2002-08-20 Martin Baulig <martin@gnome.org>
8944 * class.cs (TypeContainer.FindMembers): Added static check for events.
8946 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
8948 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
8949 use Type.GetEvents(), not Type.FindMembers().
8951 2002-08-20 Martin Baulig <martin@gnome.org>
8953 * decl.cs (MemberCache): Added a special method cache which will
8954 be used for method-only searched. This ensures that a method
8955 search will return a MethodInfo with the correct ReflectedType for
8958 2002-08-20 Martin Baulig <martin@gnome.org>
8960 * decl.cs (DeclSpace.FindMembers): Made this public.
8962 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8964 * delegate.cs: fixed build on windows.
8965 [FIXME: Filed as bug #29150: MCS must report these errors.]
8967 2002-08-19 Ravi Pratap <ravi@ximian.com>
8969 * ecore.cs (StandardConversionExists): Return a false
8970 if we are trying to convert the void type to anything else
8971 since that is not allowed.
8973 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
8974 we flag error 70 in the event an event is trying to be accessed
8975 directly from outside the declaring type.
8977 2002-08-20 Martin Baulig <martin@gnome.org>
8979 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
8980 MemberCache from typemanager.cs to decl.cs.
8982 2002-08-19 Martin Baulig <martin@gnome.org>
8984 * class.cs (TypeContainer): Implement IMemberContainer.
8985 (TypeContainer.DefineMembers): Create the MemberCache.
8986 (TypeContainer.FindMembers): Do better BindingFlags checking; only
8987 return public members if BindingFlags.Public was given, check
8988 whether members are static.
8990 2002-08-16 Martin Baulig <martin@gnome.org>
8992 * decl.cs (DeclSpace.Define): Splitted this in Define and
8993 DefineMembers. DefineMembers is called first and initializes the
8996 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
8997 DefineMembers() on all our DeclSpaces.
8999 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9000 but call DefineMembers() on all nested interfaces. We call their
9001 Define() in our new Define() function.
9003 * interface.cs (Interface): Implement IMemberContainer.
9004 (Interface.Define): Moved all code except the attribute stuf to
9006 (Interface.DefineMembers): Initialize the member cache.
9008 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9009 need this anymore since we can use MemberCache.FindMembers directly.
9011 2002-08-19 Martin Baulig <martin@gnome.org>
9013 * typemanager.cs (MemberCache): When creating the cache for an
9014 interface type, add all inherited members.
9015 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9016 to `out bool used_cache' and documented it.
9017 (TypeManager.MemberLookup): If we already used the cache in the first
9018 iteration, we don't need to do the interfaces check.
9020 2002-08-19 Martin Baulig <martin@gnome.org>
9022 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9023 here from IMemberFinder and don't implement this interface anymore.
9024 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9026 * typemanager.cs (IMemberFinder): This interface is now only used by
9027 classes which actually support the member cache.
9028 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9029 since we only put DeclSpaces into this Hashtable.
9030 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9031 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9033 2002-08-16 Martin Baulig <martin@gnome.org>
9035 * typemanager.cs (ICachingMemberFinder): Removed.
9036 (IMemberFinder.MemberCache): New property.
9037 (TypeManager.FindMembers): Merged this with RealFindMembers().
9038 This function will never be called from TypeManager.MemberLookup()
9039 so we can't use the cache here, just the IMemberFinder.
9040 (TypeManager.MemberLookup_FindMembers): Check whether the
9041 IMemberFinder has a MemberCache and call the cache's FindMembers
9043 (MemberCache): Rewrote larger parts of this yet another time and
9044 cleaned it up a bit.
9046 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9048 * driver.cs (LoadArgs): Support quoting.
9050 (Usage): Show the CSC-like command line arguments.
9052 Improved a few error messages.
9054 2002-08-15 Martin Baulig <martin@gnome.org>
9056 * typemanager.cs (IMemberContainer.Type): New property.
9057 (IMemberContainer.IsInterface): New property.
9059 The following changes are conditional to BROKEN_RUNTIME, which is
9060 defined at the top of the file.
9062 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9063 class'es members, but add all members from TypeHandle.ObjectType
9064 if we're an interface.
9065 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9066 is the current type.
9067 (MemberCache.CacheEntry.Container): Removed this field.
9068 (TypeHandle.GetMembers): Include inherited members.
9070 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9072 * typemanager.cs: fixed compilation and added a comment on a field that
9075 2002-08-15 Martin Baulig <martin@gnome.org>
9077 * class.cs (ConstructorInitializer.Resolve): In the
9078 Expression.MemberLookup call, use the queried_type as
9081 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9082 declared' attribute, it's always true.
9083 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9084 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9085 temporary wrapper for FindMembers which tells MemberLookup whether
9086 members from the base classes are included in the return value.
9087 This will go away soon.
9088 (TypeManager.MemberLookup): Use this temporary hack here; once the
9089 new MemberCache is completed, we don't need to do the DeclaredOnly
9090 looping here anymore since the MemberCache will take care of this.
9091 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9092 (MemberCache): When creating the MemberCache for a class, get
9093 members from the current class and all its base classes.
9094 (MemberCache.CacheEntry.Container): New field. This is a
9095 temporary hack until the Mono runtime is fixed to distinguish
9096 between ReflectedType and DeclaringType. It allows us to use MCS
9097 with both the MS runtime and the unfixed Mono runtime without
9098 problems and without accecting performance.
9099 (MemberCache.SearchMembers): The DeclaredOnly looping from
9100 TypeManager.MemberLookup is now done here.
9102 2002-08-14 Martin Baulig <martin@gnome.org>
9104 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9105 Type.GetFields on dynamic types but get the fields from the
9106 corresponding TypeContainer.
9107 (MyStructInfo.GetStructInfo): Added check for enum types.
9109 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9110 (MemberList.SyncRoot): Implemented.
9111 (TypeManager.FilterWithClosure): No need to check permissions if
9112 closure_start_type == closure_invocation_type, don't crash if
9113 closure_invocation_type is null.
9115 2002-08-13 Martin Baulig <martin@gnome.org>
9117 Rewrote TypeContainer.FindMembers to use a member cache. This
9118 gives us a speed increase of about 35% for the self-hosting MCS
9119 build and of about 15-20% for the class libs (both on GNU/Linux).
9121 * report.cs (Timer): New class to get enhanced profiling. This
9122 whole class is "TIMER" conditional since it remarkably slows down
9125 * class.cs (MemberList): New class. This is an IList wrapper
9126 which we're now using instead of passing MemberInfo[]'s around to
9127 avoid copying this array unnecessarily.
9128 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9129 (ICachingMemberFinder, IMemberContainer): New interface.
9130 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9131 has already been checked, otherwise use it for the name comparision.
9132 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9133 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9134 if possible. Returns a MemberList, not a MemberInfo [].
9135 (TypeHandle): New class, implements IMemberContainer. We create
9136 one instance of this class per type, it contains a MemberCache
9137 which is used to do the member lookups.
9138 (MemberCache): New class. Each instance of this class contains
9139 all members of a type and a name-based hash table.
9140 (MemberCache.FindMembers): This is our new member lookup
9141 function. First, it looks up all members of the requested name in
9142 the hash table. Then, it walks this list and sorts out all
9143 applicable members and returns them.
9145 2002-08-13 Martin Baulig <martin@gnome.org>
9147 In addition to a nice code cleanup, this gives us a performance
9148 increase of about 1.4% on GNU/Linux - not much, but it's already
9149 half a second for the self-hosting MCS compilation.
9151 * typemanager.cs (IMemberFinder): New interface. It is used by
9152 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9153 Enum, Delegate or Interface.
9154 (TypeManager.finder_to_member_finder): New PtrHashtable.
9155 (TypeManager.finder_to_container): Removed.
9156 (TypeManager.finder_to_delegate): Removed.
9157 (TypeManager.finder_to_interface): Removed.
9158 (TypeManager.finder_to_enum): Removed.
9160 * interface.cs (Interface): Implement IMemberFinder.
9162 * delegate.cs (Delegate): Implement IMemberFinder.
9164 * enum.cs (Enum): Implement IMemberFinder.
9166 * class.cs (TypeContainer): Implement IMemberFinder.
9168 2002-08-12 Martin Baulig <martin@gnome.org>
9170 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9172 2002-08-12 Martin Baulig <martin@gnome.org>
9174 * ecore.cs (ITypeExpression): New interface for expressions which
9176 (TypeExpression): Renamed to TypeLookupExpression.
9177 (Expression.DoResolve): If we're doing a types-only lookup, the
9178 expression must implement the ITypeExpression interface and we
9179 call DoResolveType() on it.
9180 (SimpleName): Implement the new ITypeExpression interface.
9181 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9182 hack, the situation that we're only looking up types can't happen
9183 anymore when this method is called. Moved the type lookup code to
9184 DoResolveType() and call it.
9185 (SimpleName.DoResolveType): This ITypeExpression interface method
9186 is now doing the types-only lookup.
9187 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9188 (ResolveFlags): Added MaskExprClass.
9190 * expression.cs (MemberAccess): Implement the ITypeExpression
9192 (MemberAccess.DoResolve): Added support for a types-only lookup
9193 when we're called via ITypeExpression.DoResolveType().
9194 (ComposedCast): Implement the ITypeExpression interface.
9196 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9197 Expression.Resolve() with ResolveFlags.Type instead.
9199 2002-08-12 Martin Baulig <martin@gnome.org>
9201 * interface.cs (Interface.Define): Apply attributes.
9203 * attribute.cs (Attribute.ApplyAttributes): Added support for
9204 interface attributes.
9206 2002-08-11 Martin Baulig <martin@gnome.org>
9208 * statement.cs (Block.Emit): Only check the "this" variable if we
9209 do not always throw an exception.
9211 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9212 whether the property has a set accessor.
9214 2002-08-11 Martin Baulig <martin@gnome.org>
9216 Added control flow analysis support for structs.
9218 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9219 with control flow analysis turned off.
9220 (IVariable): New interface.
9221 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9222 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9223 (FieldExpr.DoResolve): Resolve the instance expression with flow
9224 analysis turned off and do the definite assignment check after the
9225 resolving when we know what the expression will resolve to.
9227 * expression.cs (LocalVariableReference, ParameterReference):
9228 Implement the new IVariable interface, only call the flow analysis
9229 code if ec.DoFlowAnalysis is true.
9230 (This): Added constructor which takes a Block argument. Implement
9231 the new IVariable interface.
9232 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9233 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9234 This does the definite assignment checks for struct members.
9236 * class.cs (Constructor.Emit): If this is a non-static `struct'
9237 constructor which doesn't have any initializer, call
9238 Block.AddThisVariable() to tell the flow analysis code that all
9239 struct elements must be initialized before control returns from
9242 * statement.cs (MyStructInfo): New public class.
9243 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9244 argument to this indexer. If non-zero, check an individual struct
9245 member, not the whole struct.
9246 (FlowBranching.CheckOutParameters): Check struct members.
9247 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9248 overloaded versions of these methods which take an additional
9249 `int field_idx' argument to check struct members.
9250 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9251 overloaded versions of these methods which take an additional
9252 `string field_name' argument to check struct member.s
9253 (VariableInfo): Implement the IVariable interface.
9254 (VariableInfo.StructInfo): New public property. Returns the
9255 MyStructInfo instance of the variable if it's a struct or null.
9256 (Block.AddThisVariable): New public method. This is called from
9257 Constructor.Emit() for non-static `struct' constructor which do
9258 not have any initializer. It creates a special variable for the
9259 "this" instance variable which will be checked by the flow
9260 analysis code to ensure that all of the struct's fields are
9261 initialized before control returns from the constructor.
9262 (UsageVector): Added support for struct members. If a
9263 variable/parameter is a struct with N members, we reserve a slot
9264 in the usage vector for each member. A struct is considered fully
9265 initialized if either the struct itself (slot 0) or all its
9266 members are initialized.
9268 2002-08-08 Martin Baulig <martin@gnome.org>
9270 * driver.cs (Driver.MainDriver): Only report an error CS5001
9271 if there were no compilation errors.
9273 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9274 `UnsafeContext' property to determine whether the parent is in
9275 unsafe context rather than checking the parent's ModFlags:
9276 classes nested in an unsafe class are unsafe as well.
9278 2002-08-08 Martin Baulig <martin@gnome.org>
9280 * statement.cs (UsageVector.MergeChildren): Distinguish between
9281 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9282 we return. Added test17() and test18() to test-154.cs.
9284 2002-08-08 Martin Baulig <martin@gnome.org>
9286 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9287 Family access, make sure the invoking type isn't a subclass of the
9288 queried type (that'd be a CS1540).
9290 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9291 this method which takes an additional `Type invocation_type'.
9293 * expression.cs (BaseAccess.DoResolve): Use the base type as
9294 invocation and query type.
9295 (MemberAccess.DoResolve): If the lookup failed and we're about to
9296 report a CS0122, try a lookup with the ec.ContainerType - if this
9297 succeeds, we must report a CS1540.
9299 2002-08-08 Martin Baulig <martin@gnome.org>
9301 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9302 (MethodGroupExpr): Implement the IMemberExpr interface.
9304 * expression (MemberAccess.ResolveMemberAccess): No need to have
9305 any special code for MethodGroupExprs anymore, they're now
9308 2002-08-08 Martin Baulig <martin@gnome.org>
9310 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9311 Family, FamANDAssem and FamORAssem permissions.
9312 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9314 2002-08-08 Martin Baulig <martin@gnome.org>
9316 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9317 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9320 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9322 * driver.cs: implemented /resource option to embed managed resources.
9324 2002-08-07 Martin Baulig <martin@gnome.org>
9326 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9327 (FieldBase.HasFieldInitializer): New public property.
9328 (FieldBase.GetInitializerExpression): New public method. Resolves and
9329 returns the field initializer and makes sure it is only resolved once.
9330 (TypeContainer.EmitFieldInitializers): Call
9331 FieldBase.GetInitializerExpression to get the initializer, this ensures
9332 that it isn't resolved multiple times.
9334 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9335 the resolving process (SimpleName/MemberLookup) that we're currently
9336 emitting a field initializer (which must not access any instance members,
9337 this is an error CS0236).
9339 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9340 argument, if the `IsFieldInitializer' flag is set, we must report and
9341 error CS0236 and not an error CS0120.
9343 2002-08-07 Martin Baulig <martin@gnome.org>
9345 * ecore.cs (IMemberExpr): New public interface.
9346 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9347 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9348 if the expression is an IMemberExpr.
9350 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9351 to be null, implicitly default to `this' if we're non-static in
9352 this case. Simplified the code a lot by using the new IMemberExpr
9353 interface. Also fixed bug #28176 here.
9355 2002-08-06 Martin Baulig <martin@gnome.org>
9357 * cs-parser.jay (SimpleLookup): Removed. We need to create
9358 ParameterReferences during semantic analysis so that we can do a
9359 type-only search when resolving Cast, TypeOf and SizeOf.
9360 (block): Pass the `current_local_parameters' to the Block's
9363 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9364 argument to the constructor.
9365 (ConstructorInitializer.Resolve): Create a temporary implicit
9366 block with the parameters.
9368 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9369 references here if we aren't doing a type-only search.
9371 * statement.cs (Block): Added constructor which takes a
9372 `Parameters parameters' argument.
9373 (Block.Parameters): New public property.
9375 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9376 to `Parameters' and made it public readonly.
9378 2002-08-06 Martin Baulig <martin@gnome.org>
9380 * ecore.cs (Expression.Warning): Made this public as well.
9382 * report.cs (Report.Debug): Print the contents of collections.
9384 2002-08-06 Martin Baulig <martin@gnome.org>
9386 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9387 used to tell Resolve() which kinds of expressions it may return.
9388 (Expression.Resolve): Added overloaded version of this method which
9389 takes a `ResolveFlags flags' argument. This can be used to tell
9390 Resolve() which kinds of expressions it may return. Reports a
9392 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9393 ResolveFlags.SimpleName.
9394 (Expression.Error118): Added overloaded version of this method which
9395 takes a `ResolveFlags flags' argument. It uses the flags to determine
9396 which kinds of expressions are allowed.
9398 * expression.cs (Argument.ResolveMethodGroup): New public method.
9399 Resolves an argument, but allows a MethodGroup to be returned.
9400 This is used when invoking a delegate.
9402 * TODO: Updated a bit.
9404 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9406 Fixed compilation with csc.
9408 * ecore.cs: Expression.Error made public. Is this correct? Should
9409 Warning be made public too?
9411 * expression.cs: use ea.Location instead of ea.loc.
9412 [FIXME: Filed as bug #28607: MCS must report these errors.]
9414 2002-08-06 Martin Baulig <martin@gnome.org>
9416 * ecore.cs (Expression.loc): Moved the location here instead of
9417 duplicating it in all derived classes.
9418 (Expression.Location): New public property.
9419 (Expression.Error, Expression.Warning): Made them non-static and
9420 removed the location argument.
9421 (Expression.Warning): Added overloaded version which takes an
9422 `int level' argument.
9423 (Expression.Error118): Make this non-static and removed the
9424 expression and location arguments.
9425 (TypeExpr): Added location argument to the constructor.
9427 * expression.cs (StaticCallExpr): Added location argument to
9429 (Indirection, PointerArithmetic): Likewise.
9430 (CheckedExpr, UnCheckedExpr): Likewise.
9431 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9432 (StringPtr): Likewise.
9435 2002-08-05 Martin Baulig <martin@gnome.org>
9437 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9439 * assign.cs (Assign.DoResolve): Check whether the source
9440 expression is a value or variable.
9442 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9443 while resolving the corresponding blocks.
9445 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9446 an error, don't silently return null.
9448 * statement.cs (Block.AddVariable): Do the error reporting here
9449 and distinguish between CS0128 and CS0136.
9450 (Block.DoResolve): Report all unused labels (warning CS0164).
9451 (LabeledStatement): Pass the location to the constructor.
9452 (LabeledStatement.HasBeenReferenced): New property.
9453 (LabeledStatement.Resolve): Set it to true here.
9455 * statement.cs (Return.Emit): Return success even after reporting
9456 a type mismatch error (CS0126 or CS0127), this is what csc does and
9457 it avoids confusing the users with any consecutive errors.
9459 2002-08-05 Martin Baulig <martin@gnome.org>
9461 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9463 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9465 * expression.cs (MemberAccess.DoResolve): Silently return if an
9466 error has already been reported.
9468 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9469 error has already been reported.
9471 2002-08-05 Martin Baulig <martin@gnome.org>
9473 * statement.cs (UsageVector): Only initialize the `parameters'
9474 vector if we actually have any "out" parameters.
9476 2002-08-05 Martin Baulig <martin@gnome.org>
9478 * expression.cs (Binary.ResolveOperator): When combining delegates,
9479 they must have the same type.
9481 2002-08-05 Martin Baulig <martin@gnome.org>
9483 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9484 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9485 work with the ms runtime and we also don't need it: if we're a
9486 PropertyBuilder and not in the `indexer_arguments' hash, then we
9487 are a property and not an indexer.
9489 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9490 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9491 since the latter one doesn't work with the ms runtime.
9493 2002-08-03 Martin Baulig <martin@gnome.org>
9495 Fixed bugs #27998 and #22735.
9497 * class.cs (Method.IsOperator): New public field.
9498 (Method.CheckBase): Report CS0111 if there's already a method
9499 with the same parameters in the current class. Report CS0508 when
9500 attempting to change the return type of an inherited method.
9501 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9502 and it's not marked abstract or extern.
9503 (PropertyBase): New abstract base class for Property and Indexer.
9504 (PropertyBase.CheckBase): Moved here from Property and made it work
9506 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9507 the same so we can reuse it there.
9508 (Property, Indexer): Derive from PropertyBase.
9509 (MethodSignature.inheritable_property_signature_filter): New delegate
9510 to find properties and indexers.
9512 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9513 argument and improved error reporting.
9515 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9516 EmptyReadOnlyParameters and made it a property.
9518 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9519 version of this method which takes a `PropertyInfo indexer'.
9520 (TypeManager.RegisterIndexer): New method.
9522 * class.cs: Added myself as author of this file :-)
9524 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9526 * class.cs: fixed compilation on windoze.
9528 2002-08-03 Martin Baulig <martin@gnome.org>
9530 * interface.cs (Interface.GetInterfaceBases): Check whether all
9531 base interfaces are at least as accessible than the current one.
9533 * class.cs (TypeContainer.GetClassBases): Check whether base types
9534 are at least as accessible than the current type.
9535 (TypeContainer.AsAccessible): Implemented and made non-static.
9536 (MemberBase.CheckParameters): Report errors if the accessibility
9539 * delegate.cs (Delegate.Delegate): The default visibility is
9540 internal for top-level types and private for nested types.
9541 (Delegate.Define): Report errors if the accessibility checks fail.
9543 * enum.cs (Enum.Enum): The default visibility is internal for
9544 top-level types and private for nested types.
9545 (Enum.DefineType): Compute the correct visibility.
9547 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9548 function which takes a `bool is_toplevel' instead of a TypeContainer.
9550 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9553 2002-08-02 Martin Baulig <martin@gnome.org>
9555 * expression.cs (LocalVariableReferenc): Added constructor which
9556 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9557 (LocalVariableReference.IsReadOnly): New property.
9558 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9559 variable is readonly, use our own readonly flag to do this; you can
9560 use the new constructor to get a writable reference to a read-only
9563 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9564 reference to the local variable.
9566 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9568 * rootcontext.cs (ResolveCore): Also include System.Exception
9570 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9571 we reach an EmptyStatement.
9573 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9576 * expression.cs (Binary.ResolveOperator): Check error result in
9579 use brtrue/brfalse directly and avoid compares to null.
9581 2002-08-02 Martin Baulig <martin@gnome.org>
9583 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9584 Fixes bug #28407, added test-155.cs.
9586 2002-08-01 Martin Baulig <martin@gnome.org>
9588 * class.cs (Event.EmitDefaultMethod): Make this work with static
9589 events. Fixes #28311, added verify-3.cs.
9591 2002-08-01 Martin Baulig <martin@gnome.org>
9593 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9594 `is_disposable' fields.
9595 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9596 `hm.is_disposable' if we're using the collection pattern.
9597 (Foreach.EmitCollectionForeach): Use the correct type for the
9598 enumerator's local variable, only emit the try/finally block if
9599 necessary (fixes #27713).
9601 2002-08-01 Martin Baulig <martin@gnome.org>
9603 * ecore.cs (Expression.report118): Renamed to Error118 and made
9606 * statement.cs (Throw.Resolve): Check whether the expression is of
9607 the correct type (CS0118) and whether the type derives from
9608 System.Exception (CS0155).
9609 (Catch.Resolve): New method. Do the type lookup here and check
9610 whether it derives from System.Exception (CS0155).
9611 (Catch.CatchType, Catch.IsGeneral): New public properties.
9613 * typemanager.cs (TypeManager.exception_type): Added.
9615 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9617 * driver.cs: Updated About function.
9619 2002-07-31 Martin Baulig <martin@gnome.org>
9621 Implemented Control Flow Analysis.
9623 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9624 (EmitContext.CurrentBranching): Added.
9625 (EmitContext.StartFlowBranching): Added.
9626 (EmitContext.EndFlowBranching): Added.
9627 (EmitContext.KillFlowBranching): Added.
9628 (EmitContext.IsVariableAssigned): Added.
9629 (EmitContext.SetVariableAssigned): Added.
9630 (EmitContext.IsParameterAssigned): Added.
9631 (EmitContext.SetParameterAssigned): Added.
9632 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9633 Added control flow analysis stuff here.
9635 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9636 resolve the expression as lvalue.
9637 (LocalVariableReference.DoResolve): Check whether the variable has
9638 already been assigned.
9639 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9640 the parameter as assigned here.
9641 (ParameterReference.DoResolve): Check whether the parameter has already
9643 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9644 expression as lvalue.
9646 * statement.cs (FlowBranching): New class for the flow analysis code.
9647 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9648 (LabeledStatement.IsDefined): New public property.
9649 (LabeledStatement.AddUsageVector): New public method to tell flow
9650 analyis that the label may be reached via a forward jump.
9651 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9653 (VariableInfo.Number): New public field. This is used by flow analysis
9654 to number all locals of a block.
9655 (Block.CountVariables): New public property. This is the number of
9656 local variables in this block (including the locals from all parent
9658 (Block.EmitMeta): Number all the variables.
9660 * statement.cs: Added flow analysis support to all classes.
9662 2002-07-31 Martin Baulig <martin@gnome.org>
9664 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9665 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9666 then use this argument.
9668 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9670 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9671 use this to specify /define options.
9673 2002-07-29 Martin Baulig <martin@gnome.org>
9675 * statement.cs (Fixed): Moved all code that does variable lookups
9676 and resolvings from Emit to Resolve.
9678 * statement.cs (For): Moved all code that does variable lookups
9679 and resolvings from Emit to Resolve.
9681 * statement.cs (Using): Moved all code that does variable lookups
9682 and resolvings from Emit to Resolve.
9684 2002-07-29 Martin Baulig <martin@gnome.org>
9686 * attribute.cs (Attribute.Resolve): Explicitly catch a
9687 System.NullReferenceException when creating the
9688 CustromAttributeBuilder and report a different warning message.
9690 2002-07-29 Martin Baulig <martin@gnome.org>
9692 * support.cs (ParameterData.ParameterName): Added method to
9693 get the name of a parameter.
9695 * typemanager.cs (TypeManager.IsValueType): New public method.
9697 2002-07-29 Martin Baulig <martin@gnome.org>
9699 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9700 is a flag which specifies that it's either ref or out.
9701 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9702 the out parameter to `out Parameter.Modifier mod', also set the
9703 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9705 * support.cs (InternalParameters.ParameterModifier): Distinguish
9706 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9707 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9709 * expression.cs (Argument.GetParameterModifier): Distinguish
9710 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9711 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9713 2002-07-29 Martin Baulig <martin@gnome.org>
9715 * expression.cs (ParameterReference.ParameterReference): Added
9716 `Location loc' argument to the constructor.
9718 * cs-parser.jay: Pass location to ParameterReference.
9720 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9722 * statement.cs (Try): Initialize the location.
9724 * cs-parser.jay: pass location to Try.
9726 * expression.cs (Unary.Reduce): Change the prototype to return
9727 whether a constant fold could be performed or not. The result is
9728 returned in an out parameters. In the case of Indirection and
9729 AddressOf, we want to perform the full tests.
9731 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9733 * statement.cs (Statement.Emit): Flag dead code.
9735 2002-07-27 Andrew Birkett <andy@nobugs.org>
9737 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9739 2002-07-27 Martin Baulig <martin@gnome.org>
9741 * class.cs (MethodData.Define): Put back call to
9742 TypeManager.AddMethod(), accidentally commented this out.
9744 * report.cs (Debug): New public method to print debugging information,
9745 this is `[Conditional ("DEBUG")]'.
9747 2002-07-26 Martin Baulig <martin@gnome.org>
9749 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9750 (switch_statement): Push the current_block to the switch_stack and
9751 pop it again when we're done with the switch.
9752 (switch_section): The new block is a child of the current_block.
9753 Fixes bug #24007, added test-152.cs.
9755 2002-07-27 Martin Baulig <martin@gnome.org>
9757 * expression.cs (Invocation.EmitArguments): When calling a varargs
9758 function with only its fixed arguments, we need to pass an empty
9761 2002-07-27 Martin Baulig <martin@gnome.org>
9763 Mono 0.13 has been released.
9765 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9767 * driver.cs: Rename --resource to --linkres, because that is what
9768 we do currently, we dont support --resource yet.
9770 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9772 2002-07-25 Martin Baulig <martin@gnome.org>
9774 * class.cs (MethodData): New public class. This is a `method builder'
9775 class for a method or one accessor of a Property/Indexer/Event.
9776 (MethodData.GetMethodFlags): Moved here from MemberBase.
9777 (MethodData.ApplyAttributes): Likewise.
9778 (MethodData.ApplyObsoleteAttribute): Likewise.
9779 (MethodData.ApplyConditionalAttribute): Likewise.
9780 (MethodData.ApplyDllImportAttribute): Likewise.
9781 (MethodData.CheckAbstractAndExternal): Likewise.
9782 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9783 (MethodData.Emit): Formerly known as Method.Emit().
9784 (MemberBase): Moved everything which was specific to a single
9785 accessor/method to MethodData.
9786 (Method): Create a new MethodData and call Define() and Emit() on it.
9787 (Property, Indexer, Event): Create a new MethodData objects for each
9788 accessor and call Define() and Emit() on them.
9790 2002-07-25 Martin Baulig <martin@gnome.org>
9792 Made MethodCore derive from MemberBase to reuse the code from there.
9793 MemberBase now also checks for attributes.
9795 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9796 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9798 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9799 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9800 (MemberBase.ApplyAttributes): New virtual method; applies the
9801 attributes to a method or accessor.
9802 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9803 (MemberBase.ApplyConditionalAttribute): Likewise.
9804 (MemberBase.ApplyDllImportAttribute): Likewise.
9805 (MemberBase.CheckAbstractAndExternal): Likewise.
9806 (MethodCore.ParameterTypes): This is now a property instead of a
9807 method, it's initialized from DoDefineParameters().
9808 (MethodCore.ParameterInfo): Removed the set accessor.
9809 (MethodCore.DoDefineParameters): New protected virtual method to
9810 initialize ParameterTypes and ParameterInfo.
9811 (Method.GetReturnType): We can now simply return the MemberType.
9812 (Method.GetMethodFlags): Override the MemberBase version and add
9813 the conditional flags.
9814 (Method.CheckBase): Moved some code from Define() here, call
9815 DoDefineParameters() here.
9816 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9817 here to avoid some larger code duplication.
9818 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9819 ensure that abstract and external accessors don't declare a body.
9821 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9822 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9823 lookup in the attribute's parent classes, so we need to abort as soon
9824 as we found the first match.
9825 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9826 the attribute has no arguments.
9828 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9831 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9833 * cs-parser.jay: reverted previous patch.
9835 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9837 * cs-parser.jay: fixed bug #22119.
9839 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9841 * attribute.cs: fixed compilation. The error was:
9842 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9843 be assigned to before control leaves the current method."
9844 [FIXME: Filed as bug #28186: MCS must report this error.]
9846 2002-07-25 Martin Baulig <martin@gnome.org>
9848 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9849 method to pull the condition name ouf of a Conditional attribute.
9850 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9851 the obsolete message and error flag out of an Obsolete attribute.
9853 * class.cs (Method.GetMethodFlags): New public method to get the
9854 TypeManager.MethodFlags for this method.
9855 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9857 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9858 if we're overriding a virtual function, set the new private variable
9859 `parent_method'; call the new TypeManager.AddMethod().
9861 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9862 the MethodBuilder and the Method in a PtrHashtable.
9863 (TypeManager.builder_to_method): Added for this purpose.
9864 (TypeManager.MethodFlags): Added IsObsoleteError.
9865 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9866 Obsolete and Conditional arguments in MethodBuilders. If we discover
9867 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9868 the message from the attribute.
9870 2002-07-24 Martin Baulig <martin@gnome.org>
9872 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9873 preprocessor directives, ensure that the argument to #define/#undef is
9874 exactly one identifier and that it's actually an identifier.
9876 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9879 2002-07-24 Martin Baulig <martin@gnome.org>
9881 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9882 initialize it to TypeManager.object_type in the constructor.
9883 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9884 of the `hm.get_current' method if we're using the collection pattern.
9885 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
9886 for the explicit conversion to make it work when we're using the collection
9887 pattern and the `Current' property has a different return type than `object'.
9890 2002-07-24 Martin Baulig <martin@gnome.org>
9892 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
9893 does not match, but don't report any errors. This method is called in
9894 order for all methods in a MethodGroupExpr until a matching method is
9895 found, so we don't want to bail out if the first method doesn't match.
9896 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
9897 matches, report the 123. Fixes #28070.
9899 2002-07-24 Martin Baulig <martin@gnome.org>
9901 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
9902 TypeManager.TypeToCoreType() to the top of the method so the
9903 following equality checks will work. Fixes #28107.
9905 2002-07-24 Martin Baulig <martin@gnome.org>
9907 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
9908 operand is of type uint, and the other operand is of type sbyte,
9909 short or int, the operands are converted to type long." -
9910 Actually do what this comment already told us. Fixes bug #28106,
9913 2002-07-24 Martin Baulig <martin@gnome.org>
9915 * class.cs (MethodBase): New abstract class. This is now a base
9916 class for Property, Indexer and Event to avoid some code duplication
9917 in their Define() and DefineMethods() methods.
9918 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
9919 generic methods for Define() and DefineMethods().
9920 (FieldBase): Derive from MemberBase, not MemberCore.
9921 (Property): Derive from MemberBase, not MemberCore.
9922 (Property.DefineMethod): Moved all the code from this method to the
9923 new MethodBase.DefineAccessor(), just call it with appropriate
9925 (Property.Define): Call the new Property.DoDefine(), this does some
9926 sanity checks and we don't need to duplicate the code everywhere.
9927 (Event): Derive from MemberBase, not MemberCore.
9928 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
9929 accessors, this will also make them work with interface events.
9930 (Indexer): Derive from MemberBase, not MemberCore.
9931 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
9932 (Indexer.Define): Use the new MethodBase functions.
9934 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
9935 argument to the constructor.
9936 (Interface.FindMembers): Added support for interface events.
9937 (Interface.PopluateEvent): Implemented.
9939 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
9941 2002-07-22 Miguel de Icaza <miguel@ximian.com>
9943 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
9944 but this is required to check for a method name being the same as
9945 the containing class.
9949 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9951 * interface.cs: initialize variable.
9953 2002-07-23 Martin Baulig <martin@gnome.org>
9955 Implemented the IndexerName attribute in interfaces.
9957 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
9958 name if this is an explicit interface implementation.
9959 (Indexer.InterfaceIndexerName): New public variable. If we're
9960 implementing an interface indexer, this is the IndexerName in that
9961 interface. Otherwise, it's the IndexerName.
9962 (Indexer.DefineMethod): If we're implementing interface indexer,
9963 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
9964 and Pending.ImplementIndexer methods.
9965 (Indexer.Define): Also define the PropertyBuilder if we're
9966 implementing an interface indexer and this is neither an explicit
9967 interface implementation nor do the IndexerName match the one in
9970 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
9971 If a method is defined here, then we always need to create a proxy
9972 for it. This is used when implementing interface indexers.
9973 (Pending.IsInterfaceIndexer): New public method.
9974 (Pending.ImplementIndexer): New public method.
9975 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
9976 This is used when implementing interface indexers to define a proxy
9978 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
9979 define a proxy if necessary.
9981 * interface.cs (Interface.IndexerName): New public variable.
9982 (Interface.PopulateIndexer): Set the IndexerName.
9983 (Interface.DefineIndexers): New private method. Populate all the
9984 indexers and make sure their IndexerNames match.
9986 * typemanager.cs (IndexerPropertyName): Added support for interface
9989 2002-07-22 Martin Baulig <martin@gnome.org>
9991 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
9992 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
9993 ret if HasReturnLabel.
9994 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
9997 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
9998 and set the ec.LoopBeginTryCatchLevel.
9999 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10000 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10001 the current ec.TryCatchLevel, the branch goes out of an exception
10002 block. In this case, we need to use Leave and not Br.
10004 2002-07-22 Martin Baulig <martin@gnome.org>
10006 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10007 block unless the block does not always return or it is contained in
10008 another try { ... } catch { ... } block. Fixes bug #26506.
10009 Added verify-1.cs to the test suite.
10011 2002-07-22 Martin Baulig <martin@gnome.org>
10013 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10014 then we do not always return. Fixes bug #24985.
10016 2002-07-22 Martin Baulig <martin@gnome.org>
10018 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10019 lookup on a per-class level; ie. walk up the class hierarchy until we
10020 found at least one applicable method, then choose the best among them.
10021 Fixes bug #24463 and test-29.cs.
10023 2002-07-22 Martin Baulig <martin@gnome.org>
10025 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10026 return types of the methods. The return type is not part of the
10027 signature and we must not check it to make the `new' modifier work.
10028 Fixes bug #27999, also added test-147.cs.
10029 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10031 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10032 on the method's return type.
10034 2002-07-21 Martin Baulig <martin@gnome.org>
10036 * assign.cs: Make this work if the rightmost source is a constant and
10037 we need to do an implicit type conversion. Also adding a few more tests
10038 to test-38.cs which should have caught this.
10040 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10041 target in the makefile for this. The makefile.gnu is primarily intended
10042 for end-users who don't want to debug the compiler.
10044 2002-07-21 Martin Baulig <martin@gnome.org>
10046 * assign.cs: Improved the Assign class so it can now handle embedded
10047 assignments (X = Y = Z = something). As a side-effect this'll now also
10048 consume less local variables. test-38.cs now passes with MCS, added
10049 a few new test cases to that test.
10051 2002-07-20 Martin Baulig <martin@gnome.org>
10053 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10054 instructions. Fixes bug #27977, also added test-146.cs.
10056 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10058 * cs-tokenizer.cs: fixed getHex ().
10060 2002-07-19 Martin Baulig <martin@gnome.org>
10062 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10063 not Type.GetType() to lookup the array type. This is needed when
10064 we're constructing an array of a user-defined type.
10065 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10066 single-dimensional arrays, but also for single-dimensial arrays of
10069 2002-07-19 Martin Baulig <martin@gnome.org>
10071 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10072 this function is called, it's not allowed to share LocalBuilders
10073 among ILGenerators.
10075 2002-07-19 Martin Baulig <martin@gnome.org>
10077 * expression.cs (Argument.Resolve): Report an error 118 when trying
10078 to pass a type as argument.
10080 2002-07-18 Martin Baulig <martin@gnome.org>
10082 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10083 Conv_R_Un for the signed `long' type.
10085 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10087 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10088 `expr' for the temporary result, as that will fail if we do
10089 multiple resolves on the same expression.
10091 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10093 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10094 ec.TypeContainer for looking up aliases.
10096 * class.cs (TypeContainer): Remove LookupAlias from here.
10098 * decl.cs (DeclSpace); Move here.
10100 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10102 * class.cs (FindMembers): Only call filter if the constructor
10103 bulider is not null.
10105 Also handle delegates in `NestedTypes' now. Now we will perform
10106 type lookups using the standard resolution process. This also
10109 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10110 This uses Expressions (the limited kind that can be parsed by the
10111 tree) instead of strings.
10113 * expression.cs (ComposedCast.ToString): Implement, used to flag
10114 errors since now we have to render expressions.
10116 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10119 * ecore.cs (SimpleName.ToString): ditto.
10121 * cs-parser.jay: Instead of using strings to assemble types, use
10122 Expressions to assemble the type (using SimpleName, ComposedCast,
10123 MemberAccess). This should fix the type lookups in declarations,
10124 because we were using a different code path for this.
10126 * statement.cs (Block.Resolve): Continue processing statements
10127 even when there is an error.
10129 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10131 * class.cs (Event.Define): Also remove the `remove' method from
10132 the list of pending items.
10134 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10135 generate more compact code.
10137 2002-07-17 Martin Baulig <martin@gnome.org>
10139 * const.cs (Const.LookupConstantValue): Add support for constant
10140 `unchecked' and `checked' expressions.
10141 Also adding test case test-140.cs for this.
10143 2002-07-17 Martin Baulig <martin@gnome.org>
10145 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10146 check whether mi.ReturnType implements the IEnumerator interface; the
10147 `==' and the IsAssignableFrom() will fail in this situation.
10149 2002-07-16 Ravi Pratap <ravi@ximian.com>
10151 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10154 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10156 * expression.cs: fixed bug #27811.
10158 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10160 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10161 Molaro: when we are a ref, the value already contains a pointer
10162 value, do not take the address of it.
10164 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10165 * removed mb-parser.jay and mb-tokenizer.cs
10167 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10169 * expression.cs: check against the building corlib void type.
10171 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10173 * ecore.cs: fix for valuetype static readonly fields: when
10174 initializing them, we need their address, not the address of a copy.
10176 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10178 * typemanager.cs: register also enum_type in corlib.
10180 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10182 * class.cs: allow calling this (but not base) initializers in structs.
10184 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10186 * ecore.cs: make sure we compare against the building base types
10189 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10191 * typemanager.cs: fix TypeToCoreType() to handle void and object
10192 (corlib gets no more typerefs after this change).
10194 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10196 * expression.cs (ArrayCreation.EmitArrayArguments): use
10197 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10199 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10200 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10201 array indexes, the runtime actually forbids them.
10203 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10204 for array arguments here.
10206 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10207 instead of the default for ValueTypes.
10209 (New.DoEmit): Use IsValueType instead of
10210 IsSubclassOf (value_type)
10211 (New.DoResolve): ditto.
10212 (Invocation.EmitCall): ditto.
10214 * assign.cs (Assign): ditto.
10216 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10217 Statements *are* currently doing part of their resolution during
10220 Expressions do always resolve during resolve, but statements are
10221 only required to propagate resolution to their children.
10223 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10225 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10227 (LoadAssembly): Do not add the dll if it is already specified
10229 (MainDriver): Add the System directory to the link path at the end,
10230 after all the other -L arguments.
10232 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10233 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10234 ldelem.u1) and using the opposite for sbytes.
10236 This fixes Digger, and we can finally run it.
10238 * driver.cs (UnixParseOption): Move the option parsing here.
10239 (CSCParseOption): Implement CSC-like parsing of options.
10241 We now support both modes of operation, the old Unix way, and the
10242 new CSC-like way. This should help those who wanted to make cross
10243 platform makefiles.
10245 The only thing broken is that /r:, /reference: and /lib: are not
10246 implemented, because I want to make those have the same semantics
10247 as the CSC compiler has, and kill once and for all the confussion
10248 around this. Will be doing this tomorrow.
10250 * statement.cs (Unsafe.Resolve): The state is checked during
10251 resolve, not emit, so we have to set the flags for IsUnsfe here.
10253 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10255 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10256 not catch the Error_ObjectRefRequired in SimpleName (as it is
10257 possible to have a class/instance variable name that later gets
10258 deambiguated), we have to check this here.
10260 2002-07-10 Ravi Pratap <ravi@ximian.com>
10262 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10263 make static and put into Expression.
10265 (Event.Define): Register the private field of the event with the
10266 TypeManager so that GetFieldFromEvent can get at it.
10268 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10269 keep track of the private field associated with an event which
10272 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10275 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10277 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10279 * expression.cs (Binary.EmitBranchable): this routine emits the
10280 Binary expression in a branchable context. This basically means:
10281 we need to branch somewhere, not just get the value on the stack.
10283 This works together with Statement.EmitBoolExpression.
10285 * statement.cs (Statement.EmitBoolExpression): Use
10288 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10290 * statement.cs (For): Reduce the number of jumps in loops.
10292 (For): Implement loop inversion for the For statement.
10294 (Break): We can be breaking out of a Try/Catch controlled section
10295 (foreach might have an implicit try/catch clause), so we need to
10296 use Leave instead of Br.
10298 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10299 now). If the instace expression supports IMemoryLocation, we use
10300 the AddressOf method from the IMemoryLocation to extract the
10301 address instead of emitting the instance.
10303 This showed up with `This', as we were emitting the instance
10304 always (Emit) instead of the Address of This. Particularly
10305 interesting when This is a value type, as we dont want the Emit
10306 effect (which was to load the object).
10308 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10310 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10312 * statement.cs (Checked): Set the CheckedState during the resolve
10313 process too, as the ConvCast operations track the checked state on
10314 the resolve process, and not emit.
10316 * cs-parser.jay (namespace_member_declaration): Flag that we have
10317 found a declaration when we do. This is used to flag error 1529
10319 * driver.cs: Report ok when we display the help only.
10321 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10323 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10325 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10327 * cs-tokenizer.cs (define): We also have to track locally the
10328 defines. AllDefines is just used for the Conditional Attribute,
10329 but we also need the local defines for the current source code.
10331 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10333 * statement.cs (While, For, Do): These loops can exit through a
10334 Break statement, use this information to tell whether the
10335 statement is the last piece of code.
10337 (Break): Flag that we break.
10339 * codegen.cs (EmitContexts): New `Breaks' state variable.
10341 2002-07-03 Martin Baulig <martin@gnome.org>
10343 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10344 modifiers in method declarations in structs. Otherwise, you won't
10345 be able to override things like Object.Equals().
10347 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10349 * class.cs (Method, Property, Indexer): Do not allow the public
10350 modifier to be used in explicit interface implementations.
10352 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10353 override modifiers in method declarations in structs
10355 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10357 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10358 integer or real overflow, report an error
10360 2002-07-02 Martin Baulig <martin@gnome.org>
10362 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10363 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10364 to tell the runtime about our newly created System.Object and
10365 System.ValueType types.
10367 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10369 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10370 struct instead of Ldarg/Starg.
10372 2002-07-02 Martin Baulig <martin@gnome.org>
10374 * expression.cs (Indirection.Indirection): Call
10375 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10377 2002-07-02 Martin Baulig <martin@gnome.org>
10379 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10380 ValueType, call TypeManager.TypeToCoreType() on it.
10381 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10382 the OpCodes.Newarr argument.
10384 2002-07-02 Martin Baulig <martin@gnome.org>
10386 * expression.cs (Invocation.EmitCall): When compiling corlib,
10387 replace all calls to the system's System.Array type to calls to
10388 the newly created one.
10390 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10391 System.Array methods.
10392 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10393 from the system's System.Array type which must be replaced.
10395 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10397 * typemanager.cs: load unverifiable_code_ctor so we can build
10398 corlib using the correct type. Avoid using GetTypeCode() with
10400 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10401 TypeManager.object_type to allow building corlib.
10403 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10405 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10407 2002-07-01 Martin Baulig <martin@gnome.org>
10409 * class.cs: Make the last change actually work, we need to check
10410 whether `ifaces != null' to avoid a crash.
10412 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10414 * class.cs: when we build structs without fields that implement
10415 interfaces, we need to add the interfaces separately, since there is
10416 no API to both set the size and add the interfaces at type creation
10419 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10421 * expression.cs: the dimension arguments to the array constructors
10422 need to be converted if they are a long.
10424 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10426 * class.cs: don't emit ldarg.0 if there is no parent constructor
10427 (fixes showstopper for corlib).
10429 2002-06-29 Martin Baulig <martin@gnome.org>
10431 MCS now compiles corlib on GNU/Linux :-)
10433 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10434 ie. check for MethodImplOptions.InternalCall.
10436 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10437 and TypeManager.attribute_type are null, so we must explicitly check
10438 whether parent is not null to find out whether it's an attribute type.
10439 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10440 and SetBuilder, not only if the property is neither abstract nor external.
10441 This is necessary to set the MethodImplOptions on the accessor methods.
10442 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10443 SetBuilder, see Property.Emit().
10445 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10446 populate "System.Object", "System.ValueType" and "System.Attribute" since
10447 they've already been populated from BootCorlib_PopulateCoreTypes().
10449 2002-06-29 Martin Baulig <martin@gnome.org>
10451 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10452 is the NullLiteral, we also need to make sure that target_type is not
10455 2002-06-29 Martin Baulig <martin@gnome.org>
10457 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10458 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10459 before calling BootstrapCorlib_ResolveDelegate ().
10461 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10463 * statement.cs: fixed build-breaker. All tests passed ok.
10465 2002-06-27 Martin Baulig <martin@gnome.org>
10467 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10468 for System.Decimal when compiling corlib.
10470 2002-06-27 Martin Baulig <martin@gnome.org>
10472 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10473 switch blocks which contain nothing but a default clause.
10475 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10477 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10479 2002-06-27 Martin Baulig <martin@gnome.org>
10481 * ecore.cs (PropertyExpr.PropertyExpr): Call
10482 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10484 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10485 is already a TypeBuilder.
10487 2002-06-27 Martin Baulig <martin@gnome.org>
10489 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10490 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10491 the "from an array-type to System.Array" case. This makes it work
10492 when compiling corlib.
10494 2002-06-27 Martin Baulig <martin@gnome.org>
10496 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10497 non-static PropertyExpr, set its InstanceExpression. This makes
10498 the `ICollection.Count' property work in System/Array.cs.
10500 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10502 * driver.cs: Made error handling more consistent. Errors now
10503 tracked by Report class, so many methods which used to return int
10504 now return void. Main() now prints success/failure and
10505 errors/warnings message.
10507 Renamed '--probe' compiler argument to '--expect-error'. Removed
10508 the magic number return values (123 and 124). Now, if the
10509 expected error occurs, the compiler exits with success (exit value
10510 0). If the compilation completes without seeing that particular
10511 error, the compiler exits with failure (exit value 1). The
10512 makefile in mcs/errors has been changed to handle the new behaviour.
10514 * report.cs: Made 'expected error' number a property and renamed
10515 it from 'Probe' to 'ExpectedError'.
10517 * genericparser.cs: Removed error handling support, since it is
10518 now all done by Report class.
10520 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10521 class, so parse() no longer returns an int.
10523 * namespace.cs: Use Report.Error instead of GenericParser.error
10525 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10527 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10528 TypeContainer.AddOperator): At the front of the list put the
10529 explicit implementations, so they get resolved/defined first.
10531 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10533 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10534 interface type is implemented by this TypeContainer. Used during
10535 explicit interface implementation.
10537 (Property.Define, Indexer.Define, Method.Define): Validate that
10538 the given interface in the explicit implementation is one of the
10539 base classes for the containing type.
10541 Also if we are explicitly implementing an interface, but there is
10542 no match in the pending implementation table, report an error.
10544 (Property.Define): Only define the property if we are
10545 not explicitly implementing a property from an interface. Use the
10546 correct name also for those properties (the same CSC uses,
10547 although that is really not needed).
10549 (Property.Emit): Do not emit attributes for explicitly implemented
10550 properties, as there is no TypeBuilder.
10552 (Indexer.Emit): ditto.
10554 Hiding then means that we do not really *implement* a pending
10555 implementation, which makes code fail.
10557 2002-06-22 Martin Baulig <martin@gnome.org>
10559 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10560 the return value of Object.GetType(). [FIXME: we need to do this whenever
10561 we get a type back from the reflection library].
10563 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10565 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10567 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10569 * attribute.cs: Return null if we can not look up the type.
10571 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10572 the interface types found.
10574 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10575 interface types found.
10577 * typemanager.cs (GetInterfaces): Make this routine returns alll
10578 the interfaces and work around the lame differences between
10579 System.Type and System.Reflection.Emit.TypeBuilder in the results
10580 result for GetInterfaces.
10582 (ExpandInterfaces): Given an array of interface types, expand and
10583 eliminate repeated ocurrences of an interface. This expands in
10584 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10587 2002-06-21 Martin Baulig <martin@gnome.org>
10589 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10592 2002-06-21 Martin Baulig <martin@gnome.org>
10594 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10595 and called with one of the core types, return the corresponding typebuilder for
10598 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10601 2002-06-21 Martin Baulig <martin@gnome.org>
10603 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10604 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10605 (Expression.ConvertReferenceExplicit): Likewise.
10607 * expression.cs (ElementAccess.DoResolve): Likewise.
10608 (ElementAccess.DoResolveLValue): Likewise.
10610 2002-06-10 Martin Baulig <martin@gnome.org>
10612 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10613 add the "value" parameter to the parameter list.
10615 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10618 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10620 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10621 the argument to an int, uint, long or ulong, per the spec. Also
10622 catch negative constants in array creation.
10624 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10626 * class.cs: do not allow the same interface to appear twice in
10627 the definition list.
10629 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10631 * ecore.cs: don't use ldlen with System.Array.
10633 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10635 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10637 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10639 * modifiers.cs: produce correct field attributes for protected
10640 internal. Easy fix so miguel can work on ther harder stuff:-)
10642 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10644 * pending.cs: New file. Move the code from class.cs here.
10645 Support clearning the pending flag for all methods (when not doing
10646 explicit interface implementation).
10648 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10650 * rootcontext.cs: added a couple more types needed to bootstrap.
10652 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10654 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10655 constructor in the type, instead of any constructor in the type
10656 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10657 a bug in the Mono runtime when applying the params attribute).
10659 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10660 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10662 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10664 * expression.cs (Unary.ResolveOperator): Use TypeManager
10665 to resolve the type.
10667 2002-06-13 Ravi Pratap <ravi@ximian.com>
10669 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10672 * enum.cs (AddEnumMember): Add support to store the attributes associated
10673 with each member too.
10675 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10676 field builders too - this takes care of the enum member case.
10678 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10680 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10681 address-of operator on both value types and pointers.
10683 2002-06-10 Martin Baulig <martin@gnome.org>
10685 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10686 PropertyBuilder to the `property_builders' list.
10688 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10689 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10690 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10691 find any indexers which are inherited from an interface.
10693 2002-06-09 Martin Baulig <martin@gnome.org>
10695 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10696 the same type as the constant if necessary. There's also a test-130.cs
10699 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10701 * typemanager.cs (TypeManager.ChangeType): Previously known as
10702 Enum.ChangeEnumType().
10704 2002-06-09 Martin Baulig <martin@gnome.org>
10706 * expression.cs (Cast.TryReduce): Added support for consts.
10708 2002-06-08 Ravi Pratap <ravi@ximian.com>
10710 * class.cs (Accessor): Hold attributes information so we can pass
10713 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10714 Modify to pass in attributes attached to the methods.
10716 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10718 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10719 to handle the Accessor kind :-)
10721 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10723 2002-06-08 Martin Baulig <martin@gnome.org>
10725 * expression.cs (Unary.TryReduceNegative): Added support for
10728 2002-06-08 Martin Baulig <martin@gnome.org>
10730 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10731 name can't be found in the `defined_names' - the caller will do a
10732 MemberLookup in this case and thus find methods in System.Enum
10733 such as Enum.IsDefined().
10735 2002-06-08 Martin Baulig <martin@gnome.org>
10737 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10738 Convert.ChangeType() which works with TypeBuilder created types.
10739 (Enum.LookupEnumValue, Enum.Define): Use it here.
10741 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10742 `TypeBuilder.BaseType != null' check.
10743 (TypeContainer.FindMembers): Only lookup parent members if we
10744 actually have a parent.
10745 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10746 (ConstructorInitializer.Resolve): Likewise.
10748 * interface.cs (Interface.FindMembers): Added
10749 `TypeBuilder.BaseType != null' check.
10751 * rootcontext.cs (RootContext.ResolveCore): Added
10752 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10753 classes_second_stage.
10755 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10756 debug_type and trace_type when compiling with --nostdlib.
10758 2002-06-07 Martin Baulig <martin@gnome.org>
10760 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10761 (AddField): Set it to true when adding a non-static field.
10762 (DefineType): Use `have_nonstatic_fields' to find out whether we
10763 have non-static fields, not `Fields != null'.
10765 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10767 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10768 dereferencing a null on the static-field code path)
10770 2002-05-30 Martin Baulig <martin@gnome.org>
10772 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10773 to take command line arguments. Use reflection to call the new
10774 custom `Initialize' function on the symbol writer and pass it the
10775 command line arguments.
10777 * driver.cs (--debug-args): New command line argument to pass command
10778 line arguments to the symbol writer.
10780 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10782 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10783 the target type for indexers and properties. Thanks to Joe for
10786 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10788 * typemanager.cs (MethodFlags): returns the method flags
10789 (Obsolete/ShouldIgnore) that control warning emission and whether
10790 the invocation should be made, or ignored.
10792 * expression.cs (Invocation.Emit): Remove previous hack, we should
10793 not do this on matching a base type, we should do this based on an attribute
10795 Only emit calls to System.Diagnostics.Debug and
10796 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10797 on the command line.
10799 * rootcontext.cs: Global settings for tracing and debugging.
10801 * cs-tokenizer.cs (define): New utility function to track
10802 defines. Set the global settings for TRACE and DEBUG if found.
10804 2002-05-25 Ravi Pratap <ravi@ximian.com>
10806 * interface.cs (Populate*): Pass in the TypeContainer as well as
10807 the DeclSpace as parameters so that we can create EmitContexts and
10808 then use that to apply attributes etc.
10810 (PopulateMethod, PopulateEvent, PopulateProperty)
10811 (PopulateIndexer): Apply attributes everywhere.
10813 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10816 (ApplyAttributes): Update accordingly.
10818 We now apply interface attributes for all members too.
10820 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10822 * class.cs (Indexer.Define); Correctly check if we are explicit
10823 implementation (instead of checking the Name for a ".", we
10824 directly look up if the InterfaceType was specified).
10826 Delay the creation of the PropertyBuilder.
10828 Only create the PropertyBuilder if we are not an explicit
10829 interface implementation. This means that explicit interface
10830 implementation members do not participate in regular function
10831 lookups, and hence fixes another major ambiguity problem in
10832 overload resolution (that was the visible effect).
10834 (DefineMethod): Return whether we are doing an interface
10837 * typemanager.cs: Temporary hack until we get attributes in
10838 interfaces (Ravi is working on that) and we get IndexerName
10839 support in interfaces.
10841 * interface.cs: Register the indexers as properties.
10843 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10844 warning, I have verified that this is a bug in the .NET runtime
10845 (JavaScript suffers of the same problem).
10847 * typemanager.cs (MemberLookup): When looking up members for
10848 interfaces, the parent of an interface is the implicit
10849 System.Object (so we succeed in searches of Object methods in an
10850 interface method invocation. Example: IEnumerable x; x.ToString
10853 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10855 * class.cs (Event): Events should also register if they do
10856 implement the methods that an interface requires.
10858 * typemanager.cs (MemberLookup); use the new GetInterfaces
10861 (GetInterfaces): The code used to lookup interfaces for a type is
10862 used in more than one place, factor it here.
10864 * driver.cs: Track the errors at the bottom of the file, we kept
10867 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10868 instance if the method we are calling is static!
10870 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10872 * attribute.cs (ApplyAttributes): Make this function filter out
10873 the IndexerName attribute (as that attribute in reality is never
10874 applied) and return the string constant for the IndexerName
10877 * class.cs (TypeContainer.Emit): Validate that all the indexers
10878 have the same IndexerName attribute, and if so, set the
10879 DefaultName attribute on the class.
10881 * typemanager.cs: The return value might contain other stuff (not
10882 only methods). For instance, consider a method with an "Item"
10883 property and an Item method.
10885 * class.cs: If there is a problem with the parameter types,
10888 2002-05-24 Ravi Pratap <ravi@ximian.com>
10890 * ecore.cs (ImplicitConversionExists): Wrapper function which also
10891 looks at user defined conversion after making a call to
10892 StandardConversionExists - we need this for overload resolution.
10894 * expression.cs : Update accordingly the various method calls.
10896 This fixes 2 bugs filed against implicit user defined conversions
10898 2002-05-22 Miguel de Icaza <miguel@ximian.com>
10900 * statement.cs: Track the result of the assignment.
10902 2002-05-21 Miguel de Icaza <miguel@ximian.com>
10904 * expression.cs (MemberAccess): Improved error reporting for
10905 inaccessible members.
10907 2002-05-22 Martin Baulig <martin@gnome.org>
10909 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
10910 itself with debugging support.
10912 2002-05-22 Martin Baulig <martin@gnome.org>
10914 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
10915 Removed, this isn't needed anymore.
10917 2002-05-20 Martin Baulig <martin@gnome.org>
10919 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
10920 be underlying type for an enum.
10922 2002-05-20 Miguel de Icaza <miguel@ximian.com>
10924 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
10925 that splits out the loading of just the core types.
10927 * rootcontext.cs (ResolveCore): Split the struct resolution in
10928 two, so we can load the enumeration underlying types before any
10931 * expression.cs (Is): Bandaid until we fix properly Switch (see
10932 bug #24985 for details).
10934 * typemanager.cs (ImplementsInterface): The hashtable will contain
10935 a null if there are no interfaces implemented.
10937 2002-05-18 Miguel de Icaza <miguel@ximian.com>
10939 * cs-parser.jay (indexer_declarator): It is fine to have array
10942 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10944 * typemanager.cs: (RegisterBuilder): New function used to register
10945 TypeBuilders that implement interfaces. Since
10946 TypeBuilder.GetInterfaces (as usual) does not work with lame
10948 (AddUserType): register interfaces.
10950 (ImplementsInterface): Use the builder_to_ifaces hash if we are
10951 dealing with TypeBuilder. Also, arrays are showing up as
10952 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
10953 methods can not be invoked on them!
10955 * ecore.cs (ExplicitReferenceConversionExists): Made public.
10956 (ImplicitReferenceConversionExists): Split out from
10957 StandardConversionExists.
10959 * expression.cs (As): We were only implementing one of the three
10960 cases for the as operator. We now implement them all.
10961 (Is): Implement the various other cases for Is as well.
10963 * typemanager.cs (CACHE): New define used to control if we want or
10964 not the FindMembers cache. Seems to have a negative impact on
10965 performance currently
10967 (MemberLookup): Nested types have full acess to
10968 enclosing type members
10970 Remove code that coped with instance/static returns for events, we
10971 now catch this in RealFindMembers.
10973 (RealFindMembers): only perform static lookup if the instance
10974 lookup did not return a type or an event.
10976 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10978 * assign.cs (CompoundAssign): We pass more semantic information
10979 now to Compound Assignments than we did before: now we have all
10980 the information at hand, and now we resolve the target *before* we
10981 do the expression expansion, which allows the "CacheValue" method
10982 to have the effect we intended (before, a [x] += 1 would generate
10983 two differen ArrayAccess expressions from the ElementAccess,
10984 during the resolution process).
10986 (CompoundAssign.DoResolve): Resolve target and original_source here.
10988 2002-05-16 Miguel de Icaza <miguel@ximian.com>
10990 * expression.cs (ArrayAccess): dropped debugging information.
10992 * typemanager.cs: Small bug fix: I was always returning i_members,
10993 instead of one of i_members or s_members (depending on which had
10996 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
10997 method is invoked before any code generation takes place, and it
10998 is a mechanism to inform that the expression will be invoked more
10999 than once, and that the method should use temporary values to
11000 avoid having side effects
11002 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11004 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11007 * expression.cs (Indirection, ArrayAccess): Add support for
11008 CacheTemporaries in these two bad boys.
11010 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11011 ldobj or ldind_ref.
11012 (StoreFromPtr): Handle stobj as well.
11014 * expression.cs (UnaryMutator): Share more code.
11016 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11017 down: I was not tracking the Filter function as well, which
11018 was affecting the results of the cache.
11020 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11022 * attribute.cs: Remove the hack to handle the CharSet property on
11025 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11027 * attribute.cs (DoResolve): More uglyness, we now only try to
11028 resolve the attribute partially, to extract the CharSet
11029 information (only if we are a StructLayout attribute). Otherwise
11031 (GetExtraTypeInfo): Add some code to conditionally kill in the
11032 future this. I am more and more convinced that the .NET
11033 framework has special code to handle the attribute setting on
11036 * expression.cs (IsParamsMethodApplicable): Revert my previous
11037 foreach change here, it was wrong.
11039 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11041 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11042 (pp_expr): do not abort on unknown input, just return.
11043 (eval): abort if there are pending chars.
11045 * attribute.cs (Attribute.Resolve): Positional parameters are
11046 optional. Deal with that case.
11048 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11049 the Ansi/Unicode/Auto information for the type.
11051 (TypeContainer.DefineType): instantiate the EmitContext here, as
11052 we will be using it during the type definition (to resolve
11053 attributes) and during the emit phase.
11055 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11056 to pull type information out of the attributes
11058 (Attribute.Resolve): track the constructor builder, and allow for
11059 multiple invocations (structs and classes will use this).
11061 * ecore.cs (MemberLookupFinal): new version with all the
11062 parameters customizable.
11064 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11065 constructors. Return if the result value is null (as the error
11066 would have been flagged already by MemberLookupFinal)
11068 Do not allow instances of abstract classes or interfaces to be
11071 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11072 We have to compare the assembly property here when dealing with
11073 FamANDAssem and Assembly access modifiers, because we might be
11074 creating an assembly from *modules* (that means that we are not
11075 getting TypeBuilders for types defined in other modules that are
11076 part of this assembly).
11078 (Method.Emit): If the method is marked abstract and has a body,
11081 (TypeContainer.DefineMembers): If both the defined member and the
11082 parent name match are methods, then do not emit any warnings: let
11083 the Method.Define routine take care of flagging warnings. But if
11084 there is a mismatch (method overrides something else, or method is
11085 overriwritten by something, then emit warning).
11087 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11088 set to null, this means `do not check for the return type on the
11091 (Method.Define): set the return type for the method signature to
11092 null, so that we get methods with the same name and parameters and
11093 different return types. This is used to flag warning 114 (you are
11094 hiding a method, and you probably want to use the new/override
11097 * typemanager.cs (MemberLookup): Implemented proper access
11098 control, closing a long standing set of bug reports. The problem
11099 was that the Framework only has two bits: Public and NonPublic,
11100 and NonPublic includes private and protected methods, but we need
11101 to enforce the FamANDAssem, FamOrAssem and Family.
11103 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11105 * statement.cs (GotoCase): Return true: Ammounts to giving up
11106 knowledge on whether we return or not, and letting the other case
11107 be responsible for it.
11109 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11111 * driver.cs: Do not load directories for each file processed, only
11112 do it if there is a pattern.
11114 * ecore.cs: Report readonly assigns here as well, as we might have
11115 been resolved only by MemberAccess.
11117 (SimpleName.SimpleNameResolve): Also be useful for LValue
11118 resolution. We need this to propagate assign to local readonly variables
11120 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11121 do not want to reuse potential criteria memory.
11123 * class.cs (MyEventBuilder): Set reflected_type;
11125 * ecore.cs (Constantify): Added support for constifying bools.
11127 (RootContext.LookupType): Added a cache for values looked up in
11128 the declaration space.
11130 * typemanager.cs (FindMembers): Now is a front-end to
11131 RealFindMembers, and provides a two-level hashtable-based cache to
11134 15% performance improvement: from 22.5 to 19.2 seconds.
11136 * expression.cs (IsParamsMethodApplicable): use foreach.
11137 (Invocation.DoResolve): ditto.
11138 (New.DoResolve): ditto.
11139 (ArrayCreation.DoResolve): ditto.
11141 * ecore.cs (FindMostEncompassingType): use foreach.
11143 * delegate.cs (NewDelegate.DoResolve): Use foreach
11145 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11146 (RemoveMethods): use foreach.
11148 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11149 nested foreach statements instead of for, and also break out of
11150 the inner loop once a match is found.
11152 (Invocation.OverloadResolve): Use foreach, simplify the code.
11154 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11156 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11157 we actually unwrap the expression to allow for extra information
11160 * expression.cs: Use Shr_Un on unsigned operations.
11162 2002-05-08 Ravi Pratap <ravi@ximian.com>
11164 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11165 applicable operators was not being considered correctly. This closes
11166 the bug Miguel reported.
11168 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11170 * attribute.cs: check that the type derives from System.Attribute
11171 and report the correct error in that case (moved the duplicate code to
11172 its own method, too).
11174 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11176 * attribute.cs: lookup attribute type name as the spec says: first the
11177 bare attribute name and then name + "Attribute" (nant compiles with
11178 mcs after this fix).
11180 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11182 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11183 Because of the way we parse things, we should try to see if a
11184 UIntConstant can fit in an integer.
11186 2002-05-07 Ravi Pratap <ravi@ximian.com>
11188 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11189 when we are in an explicit context.
11191 (ConvertReferenceExplicit): When converting from Iface type S to Class
11192 T make sure the rules are implemented as an OR.
11194 * parameter.cs (ParameterType): Make it a property for now although the
11195 purpose really isn't anything immediate.
11197 * expression.cs (Is*Applicable): Do better checking on the parameter type
11198 of a ref/out parameter. The ones from the system assemblies are already
11199 marked with the correct type so we don't need to do any correction.
11201 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11202 the object type is standard too so include that.
11204 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11206 * ecore.cs (StandardConversionExists): Augment with missing code:
11207 deal with IntConstant, LongConstants and Enumerations.
11209 * assign.cs: Report the error, instead of failing silently
11211 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11212 typecontainer that they are declared, because the
11213 typecontainer/namespace will have the list of using clauses that
11214 need to be applied.
11216 Assembly Attributes were escaping the normal registration
11219 (EmitCode): Apply attributes within an EmitContext that represents
11220 the container they were declared on.
11222 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11224 2002-05-06 Ravi Pratap <ravi@ximian.com>
11226 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11227 Revamp completely - make much cleaner as we now operate only
11230 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11231 to implement the logic detailed in the spec more correctly.
11233 (UserDefinedConversion): Update accordingly.
11235 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11237 * statement.cs: Return flow analysis information up.
11239 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11242 (token): Do not consume an extra character before calling
11245 2002-05-06 Piers Haken <piersh@friskit.com>
11247 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11249 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11251 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11252 EmitContext during the instance constructor initializer
11253 resolution, to stop access to instance variables.
11255 This is mandated by the spec, last paragraph of the `constructor
11256 initializers' section.
11258 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11260 * cs-parser.jay, class.cs (Accessor): new class used to represent
11261 an accessor (get or set). In the past we used `null' to represent
11262 a missing accessor. But this is ambiguous because there was no
11263 way to tell in abstract indexers/properties if one of them was
11266 Now there is a way of addressing that.
11268 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11269 instead of FindMembers.
11271 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11272 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11274 * attribute.cs: Treat indexers and properties as the same in terms
11275 of applying attributes
11277 * ecore.cs (FindMostEncompassedType): Use statically initialized
11278 EmptyExpressions()s like we do elsewhere to avoid creating useless
11279 objects (and we take this out of the tight loop).
11281 (GetConversionOperators): Move the code to extract the actual
11282 operators to a separate routine to clean things up.
11284 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11286 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11287 events are always registered FieldBuilders.
11289 * class.cs (FieldBase): New class shared by Fields
11291 * delegate.cs: If we are a toplevel delegate, use our full name.
11292 If we are a nested delegate, then only use our tail name.
11294 2002-05-02 Ravi Pratap <ravi@ximian.com>
11296 * expression.cs (IsApplicable): Ensure that we add the "&" to
11297 ref/out types before comparing it with the type of the argument.
11299 (IsParamsMethodApplicable): Ditto.
11301 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11304 * delegate.cs : Handle the case when we have more than one applicable
11305 method. Flag an error only when we finish checking all.
11307 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11309 * expression.cs: Add support for boolean static initializers.
11311 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11313 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11315 * parameter.cs (ComputeParameterTypes,
11316 ComputeAndDefineParameterTypes): Better error handling: now we
11317 clear the `types' cache if we fail during any of the type lookups.
11318 We also return the status code correctly to our caller
11320 * delegate.cs: If we fail to define a delegate, abort the extra
11323 * expression.cs (Binary.ResolveOperator): for
11324 operator==(object,object) and operator !=(object, object) we also
11325 have to verify that there is an implicit conversion from one to
11328 (ArrayAccess.DoResolve): Array Access can operate on
11331 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11333 * assign.cs (CompoundAssign): A new class used as a "flag" that
11334 the assignment actually is happening as part of a compound
11335 assignment operator.
11337 During compound assignment, a few new rules exist to enable things
11344 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11345 to the type of x) if y is implicitly convertible to the type of x,
11346 and the operator is a builtin operator and the return type of the
11347 operator is explicitly convertible to the type of x.
11349 * rootcontext.cs: Reset warning level to 2. 4 catches various
11350 "interesting" features in mcs, we must clean this up at some
11351 point, but currently am trying to kill other bugs ;-)
11353 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11354 in container classes as well.
11356 * expression.cs (Binary.ResolveOperator): Handle string case
11357 before anything else (as operator overloading does emit an error
11358 before doing anything else).
11360 This code could go away when we move to a table driven model, but
11361 i could not come up with a good plan last night.
11363 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11365 * typemanager.cs (CSharpName): reimplementation using regex.
11366 * class.cs: added null check for fields in Emit
11367 * rootcontext.cs: set warninglevel to 4
11369 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11371 * typemanager.cs (CSharpName): reimplemented with Lupus
11374 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11376 * statement.cs (If): correclty implement Resolve, because we were
11377 not catching sem errors in there. The same process is needed
11379 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11382 (Statement.Warning_DeadCodeFound): Factorize code.
11383 (While): Report dead code here too.
11385 (Statement): Added Resolve virtual method to allow
11386 for resolution split from the emit code.
11388 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11390 * statement.cs (EmitBoolExpression): No longer try to resolve the
11392 (MakeBoolean): New utility function that resolve, implicitly
11393 converts to boolean and tags the expression.
11396 (If, Do): Implement dead code elimination.
11397 (While): Implement loop inversion
11399 (Do, While, For, If): Resolve the expression prior to calling our
11402 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11405 - added method Report28 (warning: program has more than one entry point)
11406 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11407 - modified method Method.Define, the part at the end of the method
11409 * rootcontext.cs: added static public Location EntryPointLocation;
11411 * ../errors/cs0028.cs : Add test case for the above warning.
11414 - modified method CSharpName to allow arrays of primitive type to
11415 be printed nicely (e.g. instead of System.Int32[][] it now prints
11417 - added method CSharpSignature: returns the signature of a method
11418 in string format to be used in reporting errors, warnings, etc.
11420 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11423 2002-04-26 Ravi Pratap <ravi@ximian.com>
11425 * delegate.cs (Define): Fix extremely silly bug where I was
11426 setting the type of the 'object' parameter of the BeginInvoke
11427 method to System.IAsyncResult instead of System.Object ;-)
11429 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11431 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11434 (Constructor.Emit): return if we fail to initialize the
11435 constructor. Another door closed!
11437 * expression.cs (New.DoResolve): Improve error message (from -6 to
11438 1501). Use DeclaredOnly lookup to find the exact constructor.
11440 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11441 loop. This is useful.
11443 * cs-parser.jay: Adjust the default parameters so that destructors
11444 have the proper signature.
11446 2002-04-26 Martin Baulig <martin@gnome.org>
11448 * driver.cs (LoadAssembly): If `assembly' contains any characters
11449 which are only valid in path names and not in assembly names
11450 (currently slash, backslash and point), use Assembly.LoadFrom ()
11451 instead of Assembly.Load () on the `assembly' (before iteration
11452 over the link_paths).
11454 2002-04-26 Martin Baulig <martin@gnome.org>
11456 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11458 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11460 * class.cs (Property): use the new typemanager.MemberLookup
11462 (TypeContainer.MemberLookup): Implement using the
11463 TypeManager.MemberLookup now.
11465 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11466 and return MemberInfos, so that these can be used without an
11467 EmitContext (what we had before).
11469 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11471 * expression.cs: Fix the case where the argument to params if the
11472 type of the params. I omitted handling this before. Fixed
11474 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11476 * driver.cs: Call BootCorlib_PopulateCoreType
11478 * class.cs (Property.CheckBase): Check for properties only, not
11481 * interface.cs: Temporary hack: try/catch around the
11482 CustomAttributeBuilder, because I am getting an exception that I
11485 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11486 types whose definitions are required to be there (attributes are
11487 defined before standard types).
11489 Compute definitions as we boot the various types, as they are used
11490 immediately (value_type class will need object_type, but if we do
11491 not initialize object_type, we will pass a null, which will let
11492 the runtime pick the System.Object from the existing corlib, which
11493 is not what we want).
11495 2002-04-22 Patrik Torstensson <totte@labs2.com>
11497 * cs-tokenizer.cs: fixed a number of trim() issues.
11499 2002-04-22 Ravi Pratap <ravi@ximian.com>
11501 * expression.cs (Argument.Type): Ensure that we return the correct
11502 type when we have out or ref parameters [in which case we
11505 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11507 * class.cs (Property, Indexer): Allow extern modifier in there.
11509 * typemanager.cs (InitBaseTypes): Initializes object_type and
11510 value_type, since those will be used early on during the bootstrap
11511 process to compile corlib.
11513 (InitCoreTypes): Move code from here to InitBaseTypes.
11515 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11517 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11518 single-dimension arrays as using the ldlen opcode.
11520 Daniel Lewis discovered this optimization.
11522 * typemanager.cs: Add signature for System.Array::get_Length
11524 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11526 * statement.cs: report the error when the foreach does not apply to an
11527 array nor a collection.
11529 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11531 * expression.cs: Add implicit conversions to the operator ~.
11533 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11535 * typemanager.cs: Locate the decimal constructor.
11537 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11539 * attribute.cs: use the new property of TypeOf.
11540 * expression.cs: added 'get' property around typearg.
11542 These changes fix a build breaker reported by NickD. Is this the
11543 correct way to fix? If not, please, revert my changes and make it
11546 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11548 * attribute.cs: Add support for typeof in attribute invocations.
11549 I am not sure that this is right though.
11551 2002-04-14 Duncan Mak <duncan@ximian.com>
11553 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11554 Binary.Operator.Division case.
11556 2002-04-13 Ravi Pratap <ravi@ximian.com>
11558 * class.cs (DefineType): Ensure that we do a proper check on
11559 attribute types and also register it with the TypeManager.
11561 (TypeContainer.Targets): The default for attribute types is
11562 AttributeTargets.All.
11564 * attribute.cs (ApplyAttributes): Registering the attribute type
11565 is done elsewhere, not when we discover we have a Usage attribute.
11567 2002-04-12 Ravi Pratap <ravi@ximian.com>
11569 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11570 and get rid of is_delegate parameter.
11572 * everywhere : update.
11574 2002-04-12 Ravi Pratap <ravi@ximian.com>
11576 * cs-parser.jay (compilation_unit): Revamp completely to use
11577 some new ideas that I got from Rhys' grammar to solve the problems
11578 with assembly level attributes.
11580 (outer_declaration): New grammar production.
11582 (attribute_sections): Add.
11584 (opt_attributes): Base on attribute_sections
11586 (namespace_declaration): Allow opt_attributes to tackle the case
11587 when we have assembly level attributes - we are clever in this
11590 * attribute.cs (ApplyAttributes): Do not worry about assembly
11591 attributes in the non-global context.
11593 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11594 instead of SetGlobalAttributes.
11596 * class.cs, rootcontext.cs : Ensure we define and generate
11597 attribute types before anything else.
11599 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11600 and flag the new error -20 for the case when the attribute type
11601 does not have valid targets specified. csc does not catch this.
11603 * ../errors/errors.txt : update for error # -20
11605 2002-04-11 Ravi Pratap <ravi@ximian.com>
11607 * support.cs (InternalParameters.ParameterModifier): Do some null
11608 checking and return sane values.
11610 * class.cs (Method.Define): If we are a PInvoke method, ensure
11611 that we are static and extern. Report error # 601
11613 * ../errors/cs0601.cs : Add test case for the above error.
11615 2002-04-07 Ravi Pratap <ravi@ximian.com>
11617 * rootcontext.cs (attribute_types): We need to keep type of
11618 all attribute types separately and emit code for them first.
11620 (RegisterAttribute) : Implement.
11622 * class.cs (DefineType): Check if the current Type is a custom
11623 attribute type and register it accordingly.
11625 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11626 adding the first attribute twice and rename to
11628 (SetGlobalAttributes): this.
11630 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11633 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11634 if we are processing global arguments. Hmm, I am unsure of this.
11636 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11638 * expression.cs: added static array of strings to avoid calling
11639 Enum.ToString () for Operator in Binary. Significant recover of
11642 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11644 * class.cs (FindMembers): Allow the Builders of the various
11645 members to be null. If they are skip them. This only happens
11646 during the PInvoke declaration.
11648 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11650 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11651 failure, so we do not keep going afterwards.
11653 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11654 wanted to pass `false' as the `is_delegate' argument. If this is
11655 the case, why not use delegate_type == null to mean `is_delegate =
11656 false' and anything else as is_delegate = true.
11658 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11660 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11661 code for the section, not the beginning of the tests.
11663 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11665 * cfold.cs: Handle operator + (Enum x, Underlying x)
11667 * expression.cs (Binary): same. Warn about errors where we have
11668 Enum/Enum in operator + as well.
11670 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11673 - added support for switch(bool)
11674 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11675 - add TableSwitchEmit() to handle table-based switch statements
11677 2002-04-05 Ravi Pratap <ravi@ximian.com>
11679 * expression.cs (Invocation.OverloadResolve): Factor out code which
11680 does parameter compatibility checking with arguments so that we can
11681 re-use the code even from Delegate.VerifyApplicability
11683 (VerifyArgumentsCompat): Move above code here.
11685 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11686 and instead make a call to the above method.
11688 2002-03-31 Ravi Pratap <ravi@ximian.com>
11690 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11691 We use it to keep track of classes which are attribute types.
11693 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11695 * delegate.cs (Delegate.Define): Correctly define the types in the
11696 presence of fixed and array parameters.
11698 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11701 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11702 include NonPublic after the first iteration.
11704 * class.cs (Indexer.CheckBase): Only check if both parents are
11707 * cs-parser.jay (accessor_body): If empty, set to null.
11709 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11710 same code path here to resolve constants names that we did have in
11711 MemberAccess.DoResolve. There is too much code duplicated here.
11713 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11715 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11717 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11720 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11721 tokens, numbers and strings.
11723 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11726 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11727 asyncronous parameters and the regular parameters.
11729 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11730 specify the target directory.
11732 * expression.cs: (This.DoResolve): Simplify
11733 (As.Emit): Optimize, do not generate IsInst if the expression is
11734 always of the given type.
11736 (Is.DoResolve): Bug fix, we were reporting both always/never for
11739 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11740 creating too many unnecessary arrays.
11742 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11744 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11745 fields instead of rolling our own initializer. Takes care of all
11746 implicit conversions, and drops unnecessary static checks/argument.
11748 2002-03-31 Dick Porter <dick@ximian.com>
11750 * driver.cs: use the GetDirectories() return values properly, and
11751 use "/" as path separator.
11753 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11755 * expression.cs (Unary): Optimize - - expr into expr.
11756 (Binary): Optimize a + (-b) into a -b.
11758 * codegen.cs (CodeGen): Made all methods static.
11760 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11764 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11765 TypeBuilder property.
11767 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11770 * tree.cs: Removed the various RecordXXXX, and replaced with a
11771 single RecordDecl. Removed all the accessor methods, and just
11772 left a single access point Type
11774 * enum.cs: Rename DefineEnum to DefineType.
11776 * decl.cs: New abstract method `DefineType' used to unify the
11777 Defines for Enumerations, Interfaces, TypeContainers and
11780 (FindType): Moved LookupInterfaceOrClass here. Moved the
11781 LookupBaseClasses method that used to live in class.cs and
11782 interface.cs here, and renamed to FindType.
11784 * delegate.cs: Implement DefineType. Take advantage of the
11785 refactored pattern for locating the parent builder without taking
11786 the parent_builder argument (which we know does not work if we are
11787 nested, and triggering a toplevel definition).
11789 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11791 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11792 accessibility of a member has changed during override and report
11795 * class.cs (Method.Define, Property.Define): Only complain on
11796 overrides if the method is private, any other accessibility is
11797 fine (and since we just checked the permission is the same, we are
11800 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11801 and elif are processed always. The other pre-processing
11802 directives are only processed if we are "taking" the path
11804 2002-03-29 Martin Baulig <martin@gnome.org>
11806 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11807 current location is not Null.
11809 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11810 a separate method so we can profile it.
11812 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11813 `span.Seconds' are just seconds, but no minutes or hours.
11814 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11816 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11818 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11819 Remove the gratuitous set of Final:
11821 // If an interface implementation, then we can set Final.
11822 if (((flags & MethodAttributes.Abstract) == 0) &&
11823 implementing.DeclaringType.IsInterface)
11824 flags |= MethodAttributes.Final;
11826 I do not know what I was smoking when I used that.
11829 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11830 step into fixing the name resolution issues for delegates and
11831 unifying the toplevel name resolution.
11833 2002-03-28 Martin Baulig <martin@gnome.org>
11835 * class.cs (Method.Emit): If we have a symbol writer, call its
11836 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11837 tell it about the current method.
11839 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11840 writer that we're going to emit the first byte of IL code for a new
11841 statement (a new source line).
11842 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11843 EmitContext.Mark() before emitting any code.
11845 * location.cs (SymbolDocument): Return null when we're Null.
11847 * statement.cs (Statement): Moved the `Location loc' variable here.
11848 (Statement.EmitBoolExpression): If we have a symbol writer, call
11849 ec.Mark() before emitting any code to tell it that we're at the
11850 beginning of a new statement.
11851 (StatementExpression): Added `Location' argument to the constructor.
11852 (Block): Added public readonly variable `StartLocation' and public
11853 variable `EndLocation'. The latter is to be set using SetEndLocation().
11854 (Block): Added constructor which takes a start and end location.
11855 (Block.SetEndLocation): New method. This sets the end location.
11856 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11857 local variables we create.
11858 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11859 each statement and do also mark the begin and end of the block.
11861 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11862 tell it the current lexer.Location, use Location.Null for the end of the
11864 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11865 current block, set its end location using SetEndLocation().
11866 (statement_expression): StatementExpression constructor now takes the
11867 lexer.Location as additional argument.
11868 (for_statement, declare_local_variables): Likewise.
11869 (declare_local_variables): When creating a new implicit block, use the
11870 new Block constructor and pass it the lexer.Location.
11872 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11874 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11875 members also on the parent interfaces recursively.
11877 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11879 * report.cs: Use new formats, since Gonzalo finished the missing
11882 * expression.cs (Binary.ResolveOperator): added missing operator|
11883 operator& and operator^ for bool/bool.
11885 * cs-parser.jay: CheckDef now takes a Location argument that is
11886 used to report errors more precisly (instead of reporting the end
11887 of a definition, we try to track something which is a lot closer
11888 to the source of the problem).
11890 * cs-tokenizer.cs: Track global token use, so we can properly flag
11891 the use of #define/#undef after the first token has been seen.
11893 Also, rename the reportXXXX to Error_DescriptiveName
11895 * decl.cs (DeclSpace.IsTopLevel): Move property here from
11896 TypeContainer, so that Enum and Interface can use this too.
11898 * class.cs (TypeContainer.LookupInterfaceOrClass,
11899 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
11900 `builder' argument. Typically this was used to pass the parent
11901 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
11904 The problem is that a nested class could trigger the definition of
11905 a toplevel class, and the builder would be obviously wrong in that
11908 So we drop this argument, and we compute dynamically the
11909 TypeBuilder/ModuleBuilder (the correct information was available
11910 to us anyways from DeclSpace.Parent)
11912 * interface.cs (Interface.DefineInterface): Drop builder
11913 parameter cleanup like class.cs
11915 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
11918 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
11921 (Try.Emit): Propagate the returns value from the statement.
11923 (Return.Emit): Even if we are leavning
11925 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
11927 * modifiers.cs: Fix the computation of MethodAttributes flags.
11929 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
11931 * driver.cs: allow compilation of files that start with '/'.
11932 Add a default case when checking the argument of --target.
11934 2002-03-25 Miguel de Icaza <miguel@ximian.com>
11936 * interface.cs: Implement the same search algorithm for types in
11937 the interface code.
11939 * delegate.cs: Do not allow multiple definition.
11941 * Recovered ChangeLog that got accidentally amputated
11943 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
11945 * rootcontext.cs: Load manually enum to allow core classes to
11946 contain enumerations.
11948 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
11949 Update to new static methods in TypeManager.
11951 * typemanager.cs (GetMethod, GetConstructor): Use our
11952 implementation of FindMembers to find the members, since during
11953 corlib compilation, the types are TypeBuilders and GetMethod and
11954 GetConstructor do not work.
11956 Make all methods in TypeManager static.
11958 (InitCodeHelpers): Split the functionality from
11959 the InitCodeTypes function.
11961 * driver.cs: Call InitCodeHelpers after we have populated the
11964 * cs-parser.jay (delegate_declaration): we did not used to compute
11965 the delegate name correctly for void delegates.
11967 2002-03-24 Miguel de Icaza <miguel@ximian.com>
11969 * rootcontext.cs (RootContext): Init the interface_resolve_order
11970 and type_container_resolve_order always.
11972 (ResolveCore, BootstrapCorlib_ResolveClass,
11973 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
11974 compiler when compiling with --nostdlib
11976 * class.cs (TypeContainer.DefineType): Check that our parent is
11977 not null. This test is most important when we are bootstraping
11980 * codegen.cs: Split out the symbol writing code.
11982 2002-03-25 Martin Baulig <martin@gnome.org>
11984 * driver.cs (-g): Made -g an alias for --debug.
11986 2002-03-24 Martin Baulig <martin@gnome.org>
11988 * codegen.cs (SymbolWriter): New public variable. Returns the
11989 current symbol writer.
11990 (CodeGen): Added `bool want_debugging_support' argument to the
11991 constructor. If true, tell the ModuleBuild that we want debugging
11992 support and ask it for the ISymbolWriter.
11993 (Save): If we have a symbol writer, call it's Close() method after
11994 saving the assembly.
11996 * driver.c (--debug): New command line argument to create a
11997 debugger information file.
11999 * location.cs (SymbolDocument): New public property. Returns an
12000 ISymbolDocumentWriter object for the current source file or null
12001 if we don't have a symbol writer.
12003 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12005 * driver.cs (LoadAssembly): Correctly return when all the paths
12006 have been tried and not before.
12008 * statement.cs (Switch.Emit): return the actual coverage for this
12009 statement (returns/not-returns)
12011 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12012 switch of the statement if we are the last switch section. That
12013 kills two problems: try/catch problems (we used to emit an empty
12014 nop at the end) and switch statements where all branches would
12017 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12019 * driver.cs: Add default assemblies (the equivalent to the
12020 Microsoft CSC.RSP file)
12022 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12023 also update tokens_seen and set it to false.
12025 * driver.cs: Implement --recurse for Mike.
12027 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12028 correctly splitting out the paths.
12030 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12032 * interface.cs (Interface.PopulateProperty): Instead of using
12033 `parent' as the declaration space for the set parameters, use
12036 * support.cs (InternalParameters): InternalParameters constructor
12037 takes a DeclSpace instead of a TypeContainer.
12039 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12040 types are being initialized, load the address of it before calling
12043 (New): Provide a mechanism to disable the generation of local
12044 value type temporaries when the caller will be providing us with
12045 an address to store it.
12047 (ArrayCreation.EmitDynamicInitializers): Use it.
12049 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12051 * expression.cs (Invocation.EmitArguments): Only probe for array
12052 property if there is more than one argument. Sorry about that.
12054 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12055 empty param arrays.
12057 * class.cs (Method.LabelParameters): Fix incorrect code path that
12058 prevented the `ParamArrayAttribute' from being applied to the
12061 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12063 * support.cs (ReflectionParameters): Correctly compute whether the
12064 last argument is a params array. Fixes the problem with
12067 * typemanager.cs: Make the assemblies array always be non-null
12068 (empty, but non-null)
12070 * tree.cs (RecordDecl): New function that abstracts the recording
12071 of names. This reports error 101, and provides a pointer to the
12072 previous declaration. Fixes a crash in the compiler.
12074 * cs-parser.jay (constructor_declaration): Update to new grammar,
12075 and provide a constructor_body that can be empty.
12077 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12079 * driver.cs: Add support for --resources.
12081 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12082 Make all types for the various array helper methods be integer.
12084 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12085 CheckState to ConvCast.
12087 (ConvCast): Now it takes a `checked' state argument, to avoid
12088 depending on the emit context for the conversion, and just using
12089 the resolve time setting.
12091 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12092 instead of Invocation.EmitArguments. We do not emit the original
12093 arguments, instead we emit those which have been converted to
12094 unsigned int expressions.
12096 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12098 * codegen.cs: ditto.
12100 * expression.cs (LocalVariableReference): Drop the use of the
12101 Store function that depended on the variable index.
12103 * statement.cs (VariableInfo): Drop the `Idx' property from this
12104 class, as this is not taking into account the indexes for
12105 temporaries tat we generate during the execution, getting the
12108 * class.cs: First emit class initializers, then call the parent
12111 * expression.cs (Binary): Fix opcode emision.
12112 (UnaryMutator.EmitCode): Support checked code generation
12114 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12115 matches for events for both the Static and Instance scans,
12116 pointing to the same element. Fix that.
12118 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12120 * rootcontext.cs (ResolveTree): Always set the
12121 interface_resolve_order, because nested interfaces will be calling
12124 * class.cs (GetInterfaceOrClass): Track the same resolution
12125 process used by TypeManager.LookupType. This fixes the nested
12126 type lookups in class declarations (separate path from
12129 (TypeContainer.DefineType): Also define nested interfaces.
12130 (TypeContainer.RegisterOrder): New public function used to
12131 register the order in which child interfaces need to be closed.
12133 Nested interfaces need to be closed after their parents have been
12136 * interface.cs (InterfaceAttr): Put all the logic for computing
12137 the interface attribute here.
12139 (DefineInterface): Register our interface order with the
12140 RootContext or with the TypeContainer depending on the case.
12142 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12144 * cs-parser.jay: rework foreach statement to work with the new
12145 changes to the policy on SimpleNames.
12147 * report.cs: support Stacktrace on warnings as well.
12149 * makefile: drop --unsafe and /unsafe from the compile.
12151 2002-03-13 Ravi Pratap <ravi@ximian.com>
12153 * ecore.cs (StandardConversionExists): Modify to take an Expression
12154 as the first parameter. Ensure we do null -> reference type conversion
12157 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12158 temporary Expression objects.
12160 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12162 * interface.cs: workaround bug in method overloading resolution
12163 (there is already a bugzilla bug for it).
12165 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12167 We could also solve this problem by having a separate path for
12168 performing type lookups, instead of DoResolve, we could have a
12169 ResolveType entry point, and only participating pieces of the
12170 production (simplename, deref, array) would implement this.
12172 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12173 signal SimpleName to only resolve type names and not attempt to
12174 resolve anything else.
12176 * expression.cs (Cast): Set the flag.
12178 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12180 * class.cs: Only report 108 if there is no `new' modifier.
12182 * cs-parser.jay: rework foreach statement to work with the new
12183 changes to the policy on SimpleNames.
12185 * report.cs: support Stacktrace on warnings as well.
12187 * makefile: drop --unsafe and /unsafe from the compile.
12189 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12191 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12192 lookups here, instead of doing that at parse time. This means
12193 that our grammar will not introduce `LocalVariableReferences' as
12194 expressions at this point. That solves the problem of code like
12198 static void Main ()
12202 This is only half the fix. The full fix requires parameters to
12203 also be handled in this way.
12205 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12206 makes the use more obvious of the DeclSpace. The
12207 ec.TypeContainer.TypeBuilder is now only used to pull the
12208 TypeBuilder for it.
12210 My theory is that I can get rid of the TypeBuilder completely from
12211 the EmitContext, and have typecasts where it is used (from
12212 DeclSpace to where it matters).
12214 The only pending problem is that the code that implements Aliases
12215 is on TypeContainer, and probably should go in DeclSpace.
12217 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12218 lookups here, instead of doing that at parse time. This means
12219 that our grammar will not introduce `LocalVariableReferences' as
12220 expressions at this point. That solves the problem of code like
12224 static void Main ()
12228 This is only half the fix. The full fix requires parameters to
12229 also be handled in this way.
12231 * class.cs (Property.DefineMethod): When implementing an interface
12232 method, set newslot, when implementing an abstract method, do not
12233 set the flag (before we tried never setting it, or always setting
12234 it, which is the difference).
12235 (Indexer.DefineMethod): same.
12236 (Method.DefineMethod): same.
12238 * ecore.cs: Only set the status used flag if we get back a Field.
12240 * attribute.cs: Temporary hack, so Paolo can keep working.
12242 2002-03-08 Ravi Pratap <ravi@ximian.com>
12244 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12245 the unmanaged type in the case we have a MarshalAs attribute.
12247 (Resolve): Handle the case when we are parsing the special MarshalAs
12248 attribute [we need to store the unmanaged type to use later]
12250 * typemanager.cs (marshal_as_attr_type): Built in type for the
12251 MarshalAs Attribute.
12253 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12254 on parameters and accordingly set the marshalling info.
12256 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12258 * class.cs: Optimizing slightly by removing redundant code after
12259 we switched to the `NoTypes' return value.
12260 (Property.DefineMethod): use NoTypes here too.
12262 This fixes the bug I introduced in my last batch of changes.
12264 2002-03-05 Ravi Pratap <ravi@ximian.com>
12266 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12268 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12269 Enums since those are types too.
12271 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12273 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12274 thanks to a call during the lookup process.
12276 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12278 * statement.cs (Foreach): Lots of work to accomodate a particular
12279 kind of foreach statement that I had not kept in mind. It is
12280 possible to have foreachs on classes that provide a GetEnumerator
12281 method that return objects that implement the "pattern" for using
12282 a foreach, there is no need to support GetEnumerator
12285 This is needed to compile nant.
12287 * decl.cs: Only report 114 if the member is not `Finalize' and if
12288 the warning level is at least 2.
12290 * class.cs: Moved the compare function from Method to
12293 (MethodSignature.InheritableMemberSignatureCompare): Add new
12294 filter function that is used to extract inheritable methods from a
12297 (Method.Define): Use the new `inheritable_method_signature_filter'
12300 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12303 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12305 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12307 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12309 * expression.cs: Pass location information to
12310 ConvertImplicitStandard.
12312 * class.cs: Added debugging code to track return values from
12315 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12317 * expression.cs (Is.DoResolve): If either side of the `is' is an
12318 interface, do not flag the warning.
12320 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12323 * report.cs: Allow for --fatal to be used with --probe.
12325 * typemanager.cs (NoTypes): Move the definition for the empty Type
12328 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12330 (TypeContainer.DefineProxy): New function used to proxy to parent
12331 implementations when implementing interfaces.
12332 (TypeContainer.ParentImplements): used to lookup if our parent
12333 implements a public function that is required by an interface.
12334 (TypeContainer.VerifyPendingMethods): Hook this up.
12336 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12337 `modules' and `assemblies' arraylists into arrays. We only grow
12338 these are the very early start up of the program, so this improves
12339 the speedof LookupType (nicely measured).
12341 * expression.cs (MakeByteBlob): Replaced unsafe code with
12342 BitConverter, as suggested by Paolo.
12344 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12345 folding of string concatenation, but if either side is a string,
12346 and the other is not, then return null, and let the runtime use
12347 the concatenation on the string plus the object (using
12348 `Object.ToString').
12350 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12352 Constant Folding has been implemented now.
12354 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12355 the error instead on types that are not supported in one's
12358 * constant.cs (Constant and all children): New set of functions to
12359 perform implict and explicit conversions.
12361 * ecore.cs (EnumConstant): Implement the new functions to perform
12362 conversion by proxying to the child expression.
12364 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12365 own separate setting that can not be turned off from the command
12366 line using --unchecked or --checked and is only controlled using
12367 the checked/unchecked statements and expressions. This setting is
12368 used by the constant folder to flag errors.
12370 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12371 ConstantCheckState as well.
12373 During Resolve, they also have to flag the state, because the
12374 constant folder runs completely in the Resolve phase.
12376 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12379 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12381 * cfold.cs: New file, this file contains the constant folder.
12383 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12384 argument to track whether we are using the resulting address to
12385 load or store a value and provide better error messages.
12387 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12388 new AddressOf arguments.
12390 * statement.cs (Foreach.EmitCollectionForeach): Update
12392 * expression.cs (Argument.Emit): Call AddressOf with proper
12393 arguments to track usage.
12395 (New.DoEmit): Call AddressOf with new arguments.
12397 (Unary.Emit): Adjust AddressOf call.
12399 2002-03-01 Ravi Pratap <ravi@ximian.com>
12401 * cs-parser.jay (member_access): Change the case for pre-defined types
12402 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12405 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12408 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12409 essentially like methods and apply attributes like MethodImplOptions to them too.
12411 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12414 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12415 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12418 * Update code everywhere accordingly.
12420 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12422 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12424 2002-02-28 Ravi Pratap <ravi@ximian.com>
12426 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12427 try performing lookups against those instead of jumping straight into using
12428 the 'using' clauses.
12430 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12432 (LookupType): Perform lookups in implicit parents too.
12434 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12435 sequence as RootContext.LookupType.
12437 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12438 the various cases of namespace lookups into this method.
12440 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12442 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12443 in positional arguments)
12445 * class.cs (Operator): Update the AllowedModifiers to contain
12448 * cs-parser.jay: Update operator declaration to allow for the
12449 operator body to be empty.
12451 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12454 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12456 * class.cs (Method.Emit): Label parameters.
12458 * driver.cs: Return 1 or 0 as the program exit code.
12460 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12462 * expression.cs: Special case the `null' object when trying to
12463 auto-compute the type, as anything can be explicitly converted to
12466 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12467 spotting this Paolo.
12469 (Expression.ImplicitNumericConversion): Perform comparissions of
12470 the type using the underlying type in the case of an enumeration
12471 rather than using the enumeration type for the compare.
12473 Cope with the underlying == type case, which is not possible to
12476 (Expression.ConvertNumericExplicit): Perform comparissions of
12477 the type using the underlying type in the case of an enumeration
12478 rather than using the enumeration type for the compare.
12480 * driver.cs: If the user does not supply an extension, assume .exe
12482 * cs-parser.jay (if_statement): Rewrote so that we can track the
12483 location for the if statement.
12485 * expression.cs (Binary.ConstantFold): Only concat strings when
12486 the operation is "+", not everything ;-)
12488 * statement.cs (Statement.EmitBoolExpression): Take a location
12490 (If, While, Do): Track location.
12492 * expression.cs (Binary.ResolveOperator): In the object + string
12493 case, I was missing a call to ConvertImplicit
12495 2002-02-25 Ravi Pratap <ravi@ximian.com>
12497 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12498 Location arguments. Ensure we use RootContext.LookupType to do our work
12499 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12501 * interface.cs (PopulateMethod): Handle the type of the parameter being
12504 * expression.cs (Invocation.BetterFunction): Handle the case when we
12505 have a params method with no fixed arguments and a call is made with no
12508 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12510 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12511 the verbatim-string-literal
12513 * support.cs (InternalParameters.ParameterModifier): handle null
12515 (InternalParameters.ParameterType): ditto.
12517 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12518 duplicating the name of the variable parameter.
12519 (GetParameterByName): Fix bug where we were not looking up array
12520 paramters if they were the only present (thanks Paolo!).
12521 (GetParameterInfo): We only have an empty set of types if both
12522 fixed and array are set to null.
12523 (GetParameterInfo-idx): Handle FixedParameter == null
12525 * cs-parser.jay: Handle the case where there is no catch
12526 statements (missing null test).
12528 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12530 * driver.cs (MainDriver): Be conservative on our command line
12533 Catch DirectoryNotFoundException when calling GetFiles.
12535 (SplitPathAndPattern): Used to split the input specification into
12536 a path and a pattern that we can feed to Directory.GetFiles.
12538 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12540 * statement.cs (Fixed): Implement the last case of the Fixed
12541 statement (string handling).
12543 * expression.cs (StringPtr): New class used to return a char * to
12544 a string; Used by the Fixed statement.
12546 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12548 * expression.cs (Binary.ResolveOperator): Remove redundant
12549 MemberLookup pn parent type.
12550 Optimize union call, we do not need a union if the types are the same.
12551 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12554 Specialize the use of MemberLookup everywhere, instead of using
12555 the default settings.
12557 (StackAlloc): Implement stackalloc keyword.
12559 * cs-parser.jay: Add rule to parse stackalloc.
12561 * driver.cs: Handle /h, /help, /?
12563 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12564 before we supported unsafe code.
12566 * makefile: add --unsafe to the self compilation of mcs.
12568 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12570 * expression.cs (PointerArithmetic): New class that is used to
12571 perform pointer arithmetic.
12572 (Binary.Resolve): Handle pointer arithmetic
12573 Handle pointer comparission.
12574 (ArrayPtr): Utility expression class that is used to take the
12575 address of an array.
12577 (ElementAccess): Implement array access for pointers
12579 * statement.cs (Fixed): Implement fixed statement for arrays, we
12580 are missing one more case before we are done.
12582 * expression.cs (Indirection): Implement EmitAssign and set the
12583 ExprClass to Variable. This allows pointer dereferences to be
12584 treated as variables, and to have values assigned to them.
12586 * ecore.cs (Expression.StoreFromPtr): New utility function to
12587 store values dereferencing.
12589 2002-02-20 Ravi Pratap <ravi@ximian.com>
12591 * expression.cs (Binary.ResolveOperator): Ensure that we are
12592 not trying to operate on a void type - this fixes the reported
12595 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12596 the parent implementation is sealed.
12598 * ../errors/cs0239.cs : Add.
12600 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12602 * typemanager.cs (unverifiable_code_type): Corresponds to
12603 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12604 which have unsafe code in them.
12606 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12609 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12611 * cs-tokenizer.cs: Add support for @"litreal strings"
12613 Make tokenizer accept pre-processor directives
12614 on any column (remove the old C-like limitation).
12616 * rootcontext.cs (EmitCode): Emit any global attributes.
12617 (AddGlobalAttributes): Used to keep track of assembly attributes.
12619 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12621 * cs-parser.jay: Add support for global attributes.
12623 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12625 * expression.cs (Indirection): New helper class. Unary will
12626 create Indirection classes to be able to implement the
12627 IMemoryLocation interface on it.
12629 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12631 * cs-parser.jay (fixed_statement): reference the right statement.
12633 * statement.cs (Fixed.Emit): Finish implementing the fixed
12634 statement for the &x case.
12636 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12638 * class.cs (Property.Define, Method.Define): Remove newslot when
12641 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12642 wrong. NewSlot should only be used if the `new' keyword is present.
12644 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12645 locating our system dir. Sorry about this.
12647 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12649 * driver.cs (GetSystemDir): Compute correctly the location of our
12650 system assemblies. I was using the compiler directory instead of
12651 the library directory.
12653 2002-02-13 Ravi Pratap <ravi@ximian.com>
12655 * expression.cs (BetterFunction): Put back in what Miguel commented out
12656 since it is the correct fix. The problem is elsewhere ;-)
12658 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12659 parameters of the parms method are themselves compatible or not !
12661 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12662 to check that a class implements an interface before saying that an implicit
12663 conversion was allowed. Use ImplementsInterface to do the checking.
12665 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12667 * class.cs (Method.Define): Track whether we are an explicit
12668 implementation or not. And only call DefineMethodOverride if we
12669 are an explicit implementation.
12671 (Property.DefineMethod): Ditto.
12673 2002-02-11 Ravi Pratap <ravi@ximian.com>
12675 * expression.cs (BetterFunction): Catch hideous bug which was
12676 preventing us from detecting ambiguous calls due to implicit casts i.e
12679 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12681 * support.cs (Pair): Remove un-needed method. I figured why I was
12682 getting the error in cs-parser.jay, the variable in a foreach loop
12683 is readonly, and the compiler does not really treat this as a variable.
12685 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12686 instead of EQUALS in grammar.
12688 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12690 * expression.cs (Unary.DoResolve): Check whether the argument is
12693 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12695 * support.cs: Api for Pair to set a value. Despite the fact that
12696 the variables are public the MS C# compiler refuses to compile
12697 code that accesses the field if the variable is part of a foreach
12700 * statement.cs (Fixed): Begin implementation of the fixed
12703 (Block.AddVariable): Return the VariableInfo on success and null
12704 on failure instead of true/false.
12706 * cs-parser.jay (foreach): Catch errors on variables already
12707 defined (we were ignoring this value before) and properly unwind
12708 the block hierarchy
12710 (fixed_statement): grammar for the fixed statement.
12712 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12714 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12715 pointer types to be incretemented.
12717 (SizeOf): Implement.
12719 * cs-parser.jay (pointer_member_access): Implement
12720 expr->IDENTIFIER production.
12722 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12723 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12726 (Unary): Implement indirection.
12728 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12729 use in non-unsafe context).
12731 (SimpleName.DoResolve): Check for pointers in field access on safe
12734 (Expression.LoadFromPtr): Factor the load-indirect code in this
12735 function. This was duplicated in UnboxCast and ParameterReference
12737 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12739 * expression.cs (ComposedCast): report an error if a pointer cast
12740 is used in a safe region.
12742 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12743 pointer type casts in unsafe context.
12745 * codegen.cs (EmitContext): Set up IsUnsafe.
12747 * cs-parser.jay (non_expression_type): Add productions for pointer
12750 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12751 code. We should not use force into static mode if the method is
12752 not virtual. Fixes bug in MIS
12754 * statement.cs (Do.Emit, While.Emit, For.Emit,
12755 Statement.EmitBoolExpression): Add support to Do and While to
12756 propagate infinite loop as `I do return' semantics.
12758 Improve the For case to also test for boolean constants.
12760 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12761 to the list of attributes we can add.
12763 Remove `EmitContext' argument.
12765 * class.cs (Method.Define): Apply parameter attributes.
12766 (Constructor.Define): Apply parameter attributes.
12767 (MethodCore.LabelParameters): Move here the core of labeling
12770 * support.cs (ReflectionParameters.ParameterModifier,
12771 InternalParameters.ParameterModifier): Use IsByRef on the type and
12772 only return the OUT bit for these parameters instead of in/out/ref
12775 This is because I miss-understood things. The ParameterInfo.IsIn
12776 and IsOut represent whether the parameter has the [In] and [Out]
12779 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12781 * ecore.cs (FieldExpr.Emit): Release temporaries.
12783 * assign.cs (LocalTemporary.Release): new function.
12785 * codegen.cs (EmitContext.GetTemporaryStorage,
12786 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12787 temporary storage. Now we can "put back" localbuilders when we
12790 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12792 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12793 need to make a copy of the variable to generate verifiable code.
12795 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12797 * driver.cs: Compute dynamically the system directory.
12799 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12800 Slower, but more generally useful. Used by the abstract
12801 registering implementation.
12803 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12804 the rules for the special rule on Type/instances. First check if
12805 we have the same name, and if so, try that special static path
12806 rather than the instance path.
12808 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12810 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12813 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12814 Enum, ValueType, Delegate or Array for non-corlib compiles.
12816 * cs-tokenizer.cs: Catch long identifiers (645)
12818 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12821 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12822 fix, we were returning too early, so we were not registering
12823 pending methods from abstract classes.
12825 Do not register pending methods if the class is abstract.
12827 * expression.cs (Conditional.DoResolve): Report circular implicit
12828 conversions when we neecd to compute it for conditional
12831 (Is.DoResolve): If the expression is always of the provided type,
12832 flag warning 183. If the expression can not ever be of the
12833 provided type flag warning 184.
12835 * class.cs: Catch 169 as well.
12837 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12840 2002-01-18 Nick Drochak <ndrochak@gol.com>
12842 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12844 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12846 * interface.cs: (PopulateMethod): Check for pointers being defined
12847 only if the unsafe context is active.
12848 (PopulateProperty): ditto.
12849 (PopulateIndexer): ditto.
12851 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12852 specified. If pointers are present, make sure that they are
12853 present in an unsafe context.
12854 (Constructor, Constructor.Define): ditto.
12855 (Field, Field.Define): ditto.
12856 (Property, Property.Define): ditto.
12857 (Event, Event.Define): ditto.
12859 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12860 hashtable if there are classes or structs defined.
12862 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12863 code, as the constant resolution moved.
12865 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12866 the metadata, so we can flag error 133.
12868 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12869 pointer is being declared in an unsafe context.
12871 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12873 * modifiers.cs (Modifiers.Check): Require a Location argument.
12874 Report error 227 for Unsafe use.
12876 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12878 * statement.cs (For.Emit): If the test is null, then report that
12879 we do `return', as we wont reach anything afterwards.
12881 (Switch.SwitchGoverningType): Track the expression that matched
12884 * driver.cs: Allow negative numbers as an error code to flag.
12886 * cs-parser.jay: Handle 1551.
12888 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
12890 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12892 * cs-parser.jay: Report 1518 (type declaration can only contain
12893 class, struct, interface, enum or delegate)
12895 (switch_label): Report 1523 (keywords `case' or `default' must
12898 (opt_switch_sections): Report 1522 (empty switch)
12900 * driver.cs: Report 1515 (response file specified multiple times)
12901 Report 1516 (Source file specified multiple times).
12903 * expression.cs (Argument.Resolve): Signal 1510
12905 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
12906 access not allowed in static code)
12908 2002-01-11 Ravi Pratap <ravi@ximian.com>
12910 * typemanager.cs (IsPointerType): Utility method which we are going
12913 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
12914 the object type, so we take care of that.
12916 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
12918 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
12919 added to non-params parameters :-)
12921 * typemanager.cs (CSharpName): Include 'void' type too.
12923 (void_ptr_type): Include in the set of core types.
12925 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
12928 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
12931 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
12932 completely forgotten about it.
12934 2002-01-10 Ravi Pratap <ravi@ximian.com>
12936 * cs-parser.jay (pointer_type): Add. This begins our implementation
12937 of parsing rules for unsafe code.
12939 (unsafe_statement): Implement.
12941 (embedded_statement): Modify to include the above.
12943 * statement.cs (Unsafe): Implement new class for unsafe blocks.
12945 * codegen.cs (EmitContext.InUnsafe): Add. This determines
12946 if the current context is an unsafe one.
12948 * cs-parser.jay (local_variable_pointer_type): Since local variable types
12949 are handled differently, we need separate rules for them.
12951 (local_variable_declaration): Update to use local_variable_pointer_type
12952 to allow variable declarations of unmanaged pointer types.
12954 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
12955 in unsafe contexts.
12957 * ../errors/cs0214.cs : Add.
12959 2002-01-16 Nick Drochak <ndrochak@gol.com>
12961 * makefile: remove 'response' file when cleaning.
12963 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12965 * cs-parser.jay: Report 1524.
12967 2002-01-14 Miguel de Icaza <miguel@ximian.com>
12969 * typemanager.cs (RegisterMethod): drop checking if we have
12970 registered this from here
12972 2002-01-12 Miguel de Icaza <miguel@ximian.com>
12974 * class.cs (Method.EmitDestructor): Implement calling our base
12977 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
12978 value of InFinally.
12980 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
12981 this routine and will wrap the call in a try/catch block. Deal
12984 2002-01-11 Miguel de Icaza <miguel@ximian.com>
12986 * ecore.cs (Expression.MemberLookup): instead of taking a
12987 parameter `same_type' that was used to tell whether we could
12988 access private members we compute our containing type from the
12991 (FieldExpr): Added partial support for volatile fields. This does
12992 not work for volatile fields exposed from assemblies, as I can not
12993 figure out how to extract the modreq from it.
12995 Updated all the source files to use this.
12997 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
12998 because it is referenced by MemberLookup very often.
13000 2002-01-09 Ravi Pratap <ravi@ximian.com>
13002 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13003 TypeBuilder.GetCustomAttributes to retrieve what we need.
13005 Get rid of redundant default_member_attr_type as this is the same as
13006 default_member_type which already exists.
13008 * interface.cs, attribute.cs : Update accordingly.
13010 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13012 * typemanager.cs: Enable IndexerPropertyName again. It does not
13013 work for TYpeBuilders though. Ravi, can you please fix this?
13015 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13017 * expression.cs (Argument.Emit): Handle the case of ref objects
13018 being passed to ref functions;
13020 (ParameterReference.EmitLoad): Loads the content of the pointer
13021 without dereferencing.
13023 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13025 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13027 2002-01-08 Ravi Pratap <ravi@ximian.com>
13029 * class.cs (Indexer.DefineMethod): Incorporate the interface
13030 type in the name of the method if we are doing explicit interface
13033 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13035 (BetterConversion): Fix extremely trivial bug where we were referring to
13036 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13039 * ../errors/bug16.cs : Add although we have fixed it.
13041 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13043 * expression.cs (BaseIndexer): Begin implementation.
13045 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13047 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13048 production directly to remove a shift/reduce, and implement
13049 explicit interface implementation.
13051 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13052 after a floating point suffix.
13054 * expression.cs (DoNumericPromotions): Improved the conversion for
13055 uint/uint. If we have a constant, we avoid doing a typecast to a
13058 * class.cs (Indexer): Implement explicit interface implementation
13061 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13063 * class.cs: make the default instance constructor public and hidebysig.
13065 2001-01-03 Ravi Pratap <ravi@ximian.com>
13067 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13068 so we can call it from elsewhere.
13070 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13071 we emit it internally if the class has a defined indexer; otherwise the user
13072 emits it by decorating the class definition with the DefaultMemberAttribute.
13074 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13075 attribute is not used on a type which defines an indexer.
13077 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13078 character when we skip whitespace.
13080 * ../errors/cs0646.cs : Add.
13082 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13084 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13087 * makefile: Add practical target `mcs3.exe' which builds the third
13088 generation compiler.
13090 * expression.cs (New): Fix structures constructor calling.
13092 * class.cs (Property, Method, Indexer): Emit Final flag on the
13093 method if we are an interface implementation and we are not
13096 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13097 whether this property is referencing a `base' method.
13099 * expression.cs (Invocation.EmitCall): take an extra argument:
13100 is_base, this is used to determine whether the `call' or
13101 `callvirt' opcode should be used.
13104 * delegate.cs: update EmitCall.
13106 * class.cs (Method.Define): Set NewSlot for the cases where we are
13107 not implementing an interface method.
13109 (Property.Define): ditto.
13111 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13113 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13114 'r'. Allows mcs to parse itself fully.
13116 2002-01-02 Ravi Pratap <ravi@ximian.com>
13118 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13119 of the number of initializers that require the InitializeArray method.
13121 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13122 update the above field where necessary.
13124 (MakeByteBlob): Update accordingly.
13126 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13129 (EmitDynamicInitializers): Update in accordance with the new optimization.
13131 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13132 same OpCode applies.
13134 * cs-parser.jay : Fix some glaring errors I introduced.
13136 2002-01-01 Ravi Pratap <ravi@ximian.com>
13138 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13139 so that we can check for name clashes there too.
13141 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13142 for interface indexers.
13144 * interfaces.cs (Define): Emit the default member attribute.
13146 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13147 variable was being referred to while setting the value ;-)
13149 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13151 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13152 byte-by-byte information when we know the data is zero.
13154 Make the block always a multiple of 4, because
13155 DefineInitializedData has a bug.
13157 * assign.cs: Fix, we should assign from the temporary, not from
13160 * expression.cs (MakeByteBlob): Fix my incorrect code.
13162 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13164 * typemanager.cs (EnumToUnderlying): This function is used to get
13165 the underlying type from an enumeration, because it does not
13168 * constant.cs: Use the I4_S form for values between -128 and 127.
13170 * statement.cs (Block.LookupLabel): Looks up a label.
13171 (Block): Drop support for labeled blocks.
13173 (LabeledStatement): New kind of statement that represents a label
13176 (Goto): Finally implement this bad boy.
13178 * cs-parser.jay: Update to reflect new mechanism to implement
13181 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13183 * codegen.cs (EmitContext.This): a codegen property that keeps the
13184 a single instance of this instead of creating many different this
13187 * delegate.cs (Delegate.DoResolve): Update to use the property;
13189 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13191 * expression.cs (BaseAccess.DoResolve): Ditto.
13193 2001-12-29 Ravi Pratap <ravi@ximian.com>
13195 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13196 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13198 (InitCoreTypes): Update accordingly.
13200 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13201 so we can quickly store the state.
13203 (ApplyAttributes): Set the correct implementation flags
13204 for InternalCall methods.
13206 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13208 * expression.cs (EmitCall): if a method is not virtual, then do
13209 not use callvirt on it.
13211 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13212 user defined stuff) requires the use of stobj, which takes an
13213 address on the stack instead of an array and an index. So emit
13214 the Ldelema operation for it.
13216 (EmitStoreOpcode): Use stobj for valuetypes.
13218 (UnaryMutator.EmitCode): Use the right 1 value depending on
13219 whether we are dealing with int64/uint64, float or doubles.
13221 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13222 constructors that I implemented last night.
13224 (Constructor.IsDefault): Fix to work properly for static
13227 * cs-parser.jay (CheckDef): report method signature errors.
13228 Update error number 103 to be 132.
13230 * decl.cs: New AdditionResult enumeration value: MethodExists.
13231 Although we do this check for methods later on in the semantic
13232 analysis, catching repeated default constructors is so easy that
13233 we catch these here.
13235 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13238 (ParameterReference.EmitAssign, Emit): handle
13241 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13242 (ArrayAccess.EmitStoreOpcode): ditto.
13244 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13246 * expression.cs (MakeByteBlob): Complete all the missing types
13247 (uint, short, ushort, byte, sbyte)
13249 * class.cs: Only init instance field initializers on instance
13252 Rename `constructors' to instance_constructors.
13254 (TypeContainer.AddConstructor): Only add constructors to the list
13255 if it is not static.
13257 Make sure that we handle default_static_constructor independently
13258 everywhere where we handle instance_constructors
13260 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13262 * class.cs: Do not lookup or create a base initializer for a
13263 static constructor.
13265 (ConstructorInitializer.Resolve): use the proper type to lookup
13268 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13270 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13273 * decl.cs: CloseType is now an virtual method, the default
13274 implementation just closes this type.
13276 2001-12-28 Ravi Pratap <ravi@ximian.com>
13278 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13279 to PreserveSig by default. Also emit HideBySig on such methods.
13281 Basically, set the defaults to standard values.
13283 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13284 argument, if candidate is better, it can't be worse than the best !
13286 (Invocation): Re-write bits to differentiate between methods being
13287 applicable in their expanded form and their normal form - for params
13290 Get rid of use_standard everywhere as only standard conversions are allowed
13291 in overload resolution.
13293 More spec conformance.
13295 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13297 * driver.cs: Add --timestamp, to see where the compiler spends
13300 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13301 `this' in static code.
13303 (SimpleName.DoResolve): Implement in terms of a helper function
13304 that allows static-references to be passed upstream to
13307 (Expression.ResolveWithSimpleName): Resolve specially simple
13308 names when called by MemberAccess to implement the special
13311 (Expression.ImplicitReferenceConversion): Handle conversions from
13312 Null to reference types before others, as Null's type is
13315 * expression.cs (Invocation.EmitCall): Handle the special case of
13316 calling methods declared on a reference type from a ValueType
13317 (Base classes System.Object and System.Enum)
13319 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13320 the left hand side is a TypeExpr, not on every enumeration.
13322 (Binary.Resolve): If types are reference types, then do a cast to
13323 object on operators != and == of both arguments.
13325 * typemanager.cs (FindMembers): Extract instance and static
13326 members if requested.
13328 * interface.cs (PopulateProperty): Use void_type instead of null
13329 as the return type for the setter method.
13331 (PopulateIndexer): ditto.
13333 2001-12-27 Ravi Pratap <ravi@ximian.com>
13335 * support.cs (ReflectionParameters): Fix minor bug where we
13336 were examining the wrong parameter for the ParamArray attribute.
13338 Cope with requests for the type of the parameter at position
13339 greater than the params parameter's. We now return the element
13340 type of the params array as that makes more sense.
13342 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13343 accordingly as we no longer have to extract the element type
13346 (Invocation.OverloadResolve): Update.
13348 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13350 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13351 against IEnumerator, test whether the return value is a descendant
13352 of the IEnumerator interface.
13354 * class.cs (Indexer.Define): Use an auxiliary method to implement
13355 the other bits of the method definition. Begin support for
13356 explicit interface implementation.
13358 (Property.DefineMethod): Use TypeManager.void_type instead of null
13359 for an empty return value.
13361 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13363 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13364 dealing with a FieldExpr which is composed of a FieldBuilder, in
13365 the code path we did extract the constant, but we should have
13366 obtained the underlying value to be able to cast it (otherwise we
13367 end up in an infinite loop, this is what Ravi was running into).
13369 (ArrayCreation.UpdateIndices): Arrays might be empty.
13371 (MemberAccess.ResolveMemberAccess): Add support for section
13372 14.5.4.1 that deals with the special case of E.I when E is a type
13373 and something else, that I can be a reference to a static member.
13375 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13376 handle a particular array type to create byte blobs, it is just
13377 something we dont generate byteblobs for.
13379 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13382 * location.cs (Push): remove the key from the hashtable that we
13383 are about to add. This happens for empty files.
13385 * driver.cs: Dispose files after we have parsed them.
13387 (tokenize): new function that only runs the tokenizer on its
13388 input, for speed testing.
13390 2001-12-26 Ravi Pratap <ravi@ximian.com>
13392 * class.cs (Event.Define): Define the private field only if there
13393 are no accessors defined.
13395 * expression.cs (ResolveMemberAccess): If there is no associated
13396 field with the event, that means we have an event defined with its
13397 own accessors and we should flag error cs0070 since transforming
13398 ourselves into a field is not valid in that case.
13400 * ecore.cs (SimpleName.DoResolve): Same as above.
13402 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13403 and charset to sane values.
13405 2001-12-25 Ravi Pratap <ravi@ximian.com>
13407 * assign.cs (DoResolve): Perform check on events only if they
13408 are being accessed outside the declaring type.
13410 * cs-parser.jay (event_declarations): Update rules to correctly
13411 set the type of the implicit parameter etc.
13413 (add_accessor, remove_accessor): Set current local parameters.
13415 * expression.cs (Binary): For delegate addition and subtraction,
13416 cast the return value from the method into the appropriate delegate
13419 2001-12-24 Ravi Pratap <ravi@ximian.com>
13421 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13422 of these as the workaround is unnecessary.
13424 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13425 delegate data - none of that is needed at all.
13427 Re-write bits to extract the instance expression and the delegate method
13430 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13433 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13434 of attaching attributes instead of duplicating code everywhere.
13436 * everywhere : Update code to do attribute emission using the above method.
13438 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13440 * expression.cs (IsParamsMethodApplicable): if there are not
13441 parameters, return immediately.
13443 * ecore.cs: The 0 literal can be implicity converted to an enum
13446 (SimpleName.DoResolve): First lookup the type, then lookup the
13449 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13450 want to get its address. If the InstanceExpression is not
13451 addressable, store the result in a temporary variable, then get
13454 * codegen.cs: Only display 219 errors on warning level or above.
13456 * expression.cs (ArrayAccess): Make it implement the
13457 IMemoryLocation interface.
13459 (Binary.DoResolve): handle the operator == (object a, object b)
13460 and operator != (object a, object b) without incurring into a
13461 BoxedCast (because 5 != o should never be performed).
13463 Handle binary enumerator operators.
13465 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13466 value type, otherwise use Ldelem_ref.
13468 Use precomputed names;
13470 (AddressOf): Implement address of
13472 * cs-parser.jay (labeled_statement): Fix recursive block
13473 addition by reworking the production.
13475 * expression.cs (New.DoEmit): New has a special case:
13477 If we are dealing with a ValueType, we have a few
13478 situations to deal with:
13480 * The target of New is a ValueType variable, that is
13481 easy, we just pass this as the variable reference
13483 * The target of New is being passed as an argument,
13484 to a boxing operation or a function that takes a
13487 In this case, we need to create a temporary variable
13488 that is the argument of New.
13491 2001-12-23 Ravi Pratap <ravi@ximian.com>
13493 * rootcontext.cs (LookupType): Check that current_type is not null before
13494 going about looking at nested types.
13496 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13497 not implement the IAssignMethod interface any more.
13499 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13500 where we tranform them into FieldExprs if they are being resolved from within
13501 the declaring type.
13503 * ecore.cs (SimpleName.DoResolve): Do the same here.
13505 * assign.cs (DoResolve, Emit): Clean up code considerably.
13507 * ../errors/bug10.cs : Add.
13509 * ../errors/cs0070.cs : Add.
13511 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13513 * assign.cs : Get rid of EventIsLocal everywhere.
13515 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13517 * ecore.cs (ConvertIntLiteral): finished the implementation.
13519 * statement.cs (SwitchLabel): Convert the value we are using as a
13520 key before looking up the table.
13522 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13524 * codegen.cs (EmitTopBlock): Require a Location argument now.
13526 * cs-parser.jay (constructor_declarator): We need to setup
13527 current_local_parameters before we parse the
13528 opt_constructor_initializer, to allow the variables to be bound
13529 to the constructor arguments.
13531 * rootcontext.cs (LookupType): First lookup nested classes in our
13532 class and our parents before we go looking outside our class.
13534 * expression.cs (ConstantFold): Extract/debox the values at the
13537 * rootcontext.cs (EmitCode): Resolve the constants first before we
13538 resolve the types. This is not really needed, but it helps debugging.
13540 * statement.cs: report location.
13542 * cs-parser.jay: pass location to throw statement.
13544 * driver.cs: Small bug fix.
13546 * report.cs: Updated format to be 4-zero filled digits.
13548 2001-12-22 Ravi Pratap <ravi@ximian.com>
13550 * expression.cs (CheckIndices): Fix minor bug where the wrong
13551 variable was being referred to ;-)
13553 (DoEmit): Do not call EmitStaticInitializers when the
13554 underlying type is System.Object.
13556 2001-12-21 Ravi Pratap <ravi@ximian.com>
13558 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13559 and do the usual workaround for SRE.
13561 * class.cs (MyEventBuilder.EventType): New member to get at the type
13562 of the event, quickly.
13564 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13566 * assign.cs (Assign.DoResolve): Handle the case when the target
13567 is an EventExpr and perform the necessary checks.
13569 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13572 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13574 (EventExpr): Set the type in the constructor itself since we
13575 are meant to be born fully resolved.
13577 (EventExpr.Define): Revert code I wrote earlier.
13579 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13580 instance expression is null. The instance expression is a This in that case
13581 or a null, depending on whether it is a static method or not.
13583 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13584 refers to more than one method.
13586 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13587 and accordingly flag errors.
13589 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13591 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13593 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13595 * location.cs (ToString): Provide useful rutine.
13597 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13599 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13600 objects, return the actual integral boxed.
13602 * statement.cs (SwitchLabel): define an ILLabel for each
13605 (Switch.CheckSwitch): If the value is a Literal, extract
13606 the underlying literal.
13608 Also in the unused hashtable we had, add the SwitchLabel so we can
13609 quickly look this value up.
13611 * constant.cs: Implement a bunch of new constants. Rewrite
13612 Literal based on this. Made changes everywhere to adapt to this.
13614 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13615 dereferencing array only once, and also copes with enumrations.
13617 bytes are two bytes wide, not one.
13619 (Cast): Perform constant conversions.
13621 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13622 wrappers to the literals here.
13624 * expression.cs (DoNumericPromotions): long literals can converted
13625 to ulong implicity (this is taken care of elsewhere, but I was
13626 missing this spot).
13628 * ecore.cs (Expression.Literalize): Make the return type Literal,
13629 to improve type checking.
13631 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13633 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13635 * literal.cs: Revert code from ravi that checked the bounds. The
13636 bounds are sane by the definition of the type itself.
13638 * typemanager.cs: Fix implementation of ImplementsInterface. We
13639 need to actually look up in our parent hierarchy for interfaces
13642 * const.cs: Use the underlying type for enumerations
13644 * delegate.cs: Compute the basename for the delegate creation,
13645 that should fix the delegate test case, and restore the correct
13646 Type Lookup semantics in rootcontext
13648 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13649 referencing a nested type with the Reflection API is using the "+"
13652 * cs-parser.jay: Do not require EOF token at the end.
13654 2001-12-20 Ravi Pratap <ravi@ximian.com>
13656 * rootcontext.cs (LookupType): Concatenate type names with
13657 a '.' instead of a '+' The test suite passes again.
13659 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13660 field of the enumeration.
13662 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13663 the case when the member is an EventExpr.
13665 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13666 static has an associated instance expression.
13668 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13670 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13672 * class.cs (Event.Define): Register event and perform appropriate checks
13675 We define the Add and Remove methods even if the use provides none because
13676 in that case, we provide default implementations ourselves.
13678 Define a private field of the type of the event. This is done by the CSC compiler
13679 and we should be doing it too ;-)
13681 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13682 More methods we use in code we generate.
13684 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13687 (InitCoreTypes): Update accordingly for the above.
13689 * class.cs (Event.Emit): Generate code for default accessors that we provide
13691 (EmitDefaultMethod): Do the job in the above.
13693 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13696 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13698 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13699 builders even if we were missing one.
13701 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13702 pass the Basename as our class name instead of the Name. The
13703 basename will be correctly composed for us.
13705 * parameter.cs (Paramters): Now takes a Location argument.
13707 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13708 make all the code call directly LookupType in RootContext and take
13709 this chance to pass the Location information everywhere.
13711 * Everywhere: pass Location information.
13713 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13715 * class.cs (Constructor.Define): Updated way of detecting the
13716 length of the parameters.
13718 (TypeContainer.DefineType): Use basename as the type name for
13721 (TypeContainer.Define): Do not recursively define types here, as
13722 definition is taken care in order by the RootContext.
13724 * tree.cs: Keep track of namespaces in a per-file basis.
13726 * parameter.cs (Parameter.ComputeSignature): Update to use
13729 (Parameters.GetSignature): ditto.
13731 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13732 instead of a TypeContainer.
13734 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13735 resolve names. Because we need to be resolve in our context, not
13738 * driver.cs: Implement response files.
13740 * class.cs (TypeContainer.DefineType): If we are defined, do not
13741 redefine ourselves.
13743 (Event.Emit): Emit the code for add/remove handlers.
13744 (Event.Define): Save the MethodBuilders for add/remove.
13746 * typemanager.cs: Use pair here too.
13748 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13749 DictionaryEntry requires the first argument to be non-null.
13751 (enum_declaration): Compute full name for registering the
13754 (delegate_declaration): Instead of using
13755 formal_parameter_list, use opt_formal_parameter_list as the list
13758 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13759 (EventParsing): New property that controls whether `add' and
13760 `remove' are returned as tokens or identifiers (for events);
13762 2001-12-19 Ravi Pratap <ravi@ximian.com>
13764 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13765 use MyEventBuilder only and let it wrap the real builder for us.
13767 (MyEventBuilder): Revamp constructor etc.
13769 Implement all operations that we perform on EventBuilder in precisely the same
13772 (FindMembers): Update to use the EventBuilder member.
13774 (Event.Emit): Update accordingly.
13776 2001-12-18 Ravi Pratap <ravi@ximian.com>
13778 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13779 by calling the appropriate methods.
13781 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13784 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13786 2001-12-17 Ravi Pratap <ravi@ximian.com>
13788 * delegate.cs (Delegate.Populate): Check that the return type
13789 and various parameters types are indeed accessible.
13791 * class.cs (Constructor.Define): Same here.
13793 (Field.Define): Ditto.
13795 (Event.Define): Ditto.
13797 (Operator.Define): Check that the underlying Method defined itself
13798 correctly - so it's MethodBuilder should not be null.
13800 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13801 expression happens to be null.
13803 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13804 members but as of now we don't seem to be able to do anything really useful with it.
13806 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13807 not the EventBuilder.
13809 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13811 * cs-tokenizer.cs: Add support for defines.
13812 Add support for #if, #elif, #else, #endif
13814 (eval_var): evaluates a variable.
13815 (eval): stubbed for evaluating functions.
13817 * cs-parser.jay: Pass the defines information
13819 * driver.cs: Add --define command line option.
13821 * decl.cs: Move MemberCore here.
13823 Make it the base class for DeclSpace. This allows us to catch and
13824 report 108 and 109 for everything now.
13826 * class.cs (TypeContainer.Define): Extract all the members
13827 before populating and emit the warning 108 (new keyword required
13828 to override) instead of having each member implement this.
13830 (MemberCore.Define): New abstract method, we will be using this in
13831 the warning reporting engine in Populate.
13833 (Operator.Define): Adjust to new MemberCore protocol.
13835 * const.cs (Const): This does not derive from Expression, it is a
13836 temporary object we use to create fields, it is a MemberCore.
13838 * class.cs (Method.Define): Allow the entry point to be in a
13841 * driver.cs: Rewrite the argument handler to clean it up a bit.
13843 * rootcontext.cs: Made it just an auxiliary namespace feature by
13844 making everything static.
13846 * driver.cs: Adapt code to use RootContext type name instead of
13849 * delegate.cs: Remove RootContext argument.
13851 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13854 * class.cs (Event.Define): The lookup can fail.
13856 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13858 * expression.cs: Resolve the this instance before invoking the code.
13860 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13862 * cs-parser.jay: Add a production in element_access that allows
13863 the thing to become a "type" reference. This way we can parse
13864 things like "(string [])" as a type.
13866 Note that this still does not handle the more complex rules of
13870 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13872 * ecore.cs: (CopyNewMethods): new utility function used to
13873 assemble the list of methods from running FindMembers.
13875 (MemberLookup): Rework FindMembers so that
13877 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13879 * class.cs (TypeContainer): Remove Delegates who fail to be
13882 * delegate.cs (Populate): Verify that we dont get null return
13883 values. TODO: Check for AsAccessible.
13885 * cs-parser.jay: Use basename to emit error 574 (destructor should
13886 have the same name as container class), not the full name.
13888 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
13889 possible representation.
13891 Also implements integer type suffixes U and L.
13893 2001-12-15 Miguel de Icaza <miguel@ximian.com>
13895 * expression.cs (ArrayCreation.DoResolve): We need to do the
13896 argument resolution *always*.
13898 * decl.cs: Make this hold the namespace. Hold the root context as
13900 (LookupType): Move here.
13902 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
13904 * location.cs (Row, Name): Fixed the code, it was always returning
13905 references to the first file.
13907 * interface.cs: Register properties defined through interfaces.
13909 * driver.cs: Add support for globbing on the command line
13911 * class.cs (Field): Make it derive from MemberCore as well.
13914 2001-12-15 Ravi Pratap <ravi@ximian.com>
13916 * class.cs (Event::Define): Check that the type of the event is a delegate
13917 type else flag error #66.
13919 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
13922 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
13923 values of EntryPoint, CharSet etc etc.
13925 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
13927 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
13928 be null and we should ignore this. I am not sure if this is really clean. Apparently,
13929 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
13930 which needs this to do its work.
13932 * ../errors/cs0066.cs : Add.
13934 2001-12-14 Miguel de Icaza <miguel@ximian.com>
13936 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
13939 * class.cs: (MethodSignature.MethodSignature): Removed hack that
13940 clears out the parameters field.
13941 (MemberSignatureCompare): Cleanup
13943 (MemberCore): New base class used to share code between MethodCore
13946 (RegisterRequiredImplementations) BindingFlags.Public requires
13947 either BindingFlags.Instace or Static. Use instance here.
13949 (Property): Refactored code to cope better with the full spec.
13951 * parameter.cs (GetParameterInfo): Return an empty array instead
13954 * class.cs (Property): Abstract or extern properties have no bodies.
13956 * parameter.cs (GetParameterInfo): return a zero-sized array.
13958 * class.cs (TypeContainer.MethodModifiersValid): Move all the
13959 method modifier validation to the typecontainer so we can reuse
13960 this on properties.
13962 (MethodCore.ParameterTypes): return an empty sized array of types.
13964 (Property.Define): Test property modifier validity.
13966 Add tests for sealed/override too.
13968 (Method.Emit): abstract or extern methods have no bodies.
13970 2001-12-14 Ravi Pratap <ravi@ximian.com>
13972 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
13975 (Method::Define, ::Emit): Modify accordingly.
13977 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
13979 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
13981 * makefile: Pass in /unsafe.
13983 2001-12-13 Miguel de Icaza <miguel@ximian.com>
13985 * class.cs (MakeKey): Kill routine.
13987 * class.cs (TypeContainer.Define): Correctly define explicit
13988 method implementations (they require the full interface name plus
13991 * typemanager.cs: Deply the PtrHashtable here and stop using the
13992 lame keys. Things work so much better.
13994 This of course broke everyone who depended on `RegisterMethod' to
13995 do the `test for existance' test. This has to be done elsewhere.
13997 * support.cs (PtrHashtable): A hashtable that avoid comparing with
13998 the object stupid Equals method (because, that like fails all over
13999 the place). We still do not use it.
14001 * class.cs (TypeContainer.SetRequiredInterface,
14002 TypeContainer.RequireMethods): Killed these two routines and moved
14003 all the functionality to RegisterRequiredImplementations.
14005 (TypeContainer.RegisterRequiredImplementations): This routine now
14006 registers all the implementations required in an array for the
14007 interfaces and abstract methods. We use an array of structures
14008 which can be computed ahead of time to reduce memory usage and we
14009 also assume that lookups are cheap as most classes will not
14010 implement too many interfaces.
14012 We also avoid creating too many MethodSignatures.
14014 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14015 clear the "pending" bit if we find that there are problems with
14018 (TypeContainer.VerifyPendingMethods): Update to report errors of
14019 methods that look like implementations but are not.
14021 (TypeContainer.Define): Add support for explicit interface method
14024 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14026 * typemanager.cs: Keep track of the parameters here instead of
14027 being a feature of the TypeContainer.
14029 * class.cs: Drop the registration of parameters here, as
14030 InterfaceMethods are also interface declarations.
14032 * delegate.cs: Register methods with the TypeManager not only with
14033 the TypeContainer. This code was buggy.
14035 * interface.cs: Full registation here.
14037 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14039 * expression.cs: Remove reducer for binary expressions, it can not
14042 * const.cs: Put here the code that used to go into constant.cs
14044 * constant.cs: Put here the code for constants, this is a new base
14045 class for Literals.
14047 * literal.cs: Make Literal derive from Constant.
14049 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14051 * statement.cs (Return.Emit): Report error 157 if the user
14052 attempts to return from a finally block.
14054 (Return.Emit): Instead of emitting a return, jump to the end of
14057 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14058 LocalBuilder to store the result of the function. ReturnLabel is
14059 the target where we jump.
14062 2001-12-09 Radek Doulik <rodo@ximian.com>
14064 * cs-parser.jay: remember alias in current namespace
14066 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14069 * class.cs (LookupAlias): lookup alias in my_namespace
14071 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14073 (LookupAlias): lookup alias in this and if needed in parent
14076 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14080 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14081 making things static. I need this to avoid passing the
14082 TypeContainer when calling ParameterType.
14084 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14085 that did string manipulation to compute the type and then call
14086 GetType. Use Parameter.ParameterType instead.
14088 * cs-tokenizer.cs: Consume the suffix for floating values.
14090 * expression.cs (ParameterReference): figure out whether this is a
14091 reference parameter or not. Kill an extra variable by computing
14092 the arg_idx during emission.
14094 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14095 function that returns whether a parameter is an out/ref value or not.
14097 (Parameter.ParameterType): The type of the parameter (base,
14098 without ref/out applied).
14100 (Parameter.Resolve): Perform resolution here.
14101 (Parameter.ExternalType): The full type (with ref/out applied).
14103 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14104 support for expressions on the using statement.
14106 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14108 * statement.cs (Using.EmitLocalVariableDecls): Split the
14109 localvariable handling of the using statement.
14111 (Block.EmitMeta): Keep track of variable count across blocks. We
14112 were reusing slots on separate branches of blocks.
14114 (Try.Emit): Emit the general code block, we were not emitting it.
14116 Check the type of the declaration to be an IDisposable or
14117 something that can be implicity converted to it.
14119 Emit conversions if required.
14121 * ecore.cs (EmptyExpression): New utility class.
14122 (Expression.ImplicitConversionExists): New utility function.
14124 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14126 * statement.cs (Using): Implement.
14128 * expression.cs (LocalVariableReference): Support read only variables.
14130 * statement.cs: Remove the explicit emit for the Leave opcode.
14131 (VariableInfo): Add a readonly field.
14133 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14135 * ecore.cs (ConvCast): new class used to encapsulate the various
14136 explicit integer conversions that works in both checked and
14137 unchecked contexts.
14139 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14140 properly generate the overflow opcodes.
14142 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14144 * statement.cs: The correct type for the EmptyExpression is the
14145 element_type, not the variable type. Ravi pointed this out.
14147 2001-12-04 Ravi Pratap <ravi@ximian.com>
14149 * class.cs (Method::Define): Handle PInvoke methods specially
14150 by using DefinePInvokeMethod instead of the usual one.
14152 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14153 above to do the task of extracting information and defining the method.
14155 2001-12-04 Ravi Pratap <ravi@ximian.com>
14157 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14158 of the condition for string type.
14160 (Emit): Move that here.
14162 (ArrayCreation::CheckIndices): Keep string literals in their expression
14165 (EmitDynamicInitializers): Handle strings appropriately.
14167 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14169 * codegen.cs (EmitContext): Replace multiple variables with a
14170 single pointer to the current Switch statement.
14172 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14175 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14179 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14182 (Foreach.Emit): Foreach on arrays was not setting
14183 up the loop variables (for break/continue).
14185 (GotoCase): Semi-implented.
14187 2001-12-03 Ravi Pratap <ravi@ximian.com>
14189 * attribute.cs (CheckAttribute): Handle system attributes by using
14190 Attribute.GetAttributes to examine information we need.
14192 (GetValidPlaces): Same here.
14194 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14196 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14198 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14200 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14202 (Method::Emit): Handle the case when we are a PInvoke method.
14204 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14206 * expression.cs: Use ResolveWithSimpleName on compound names.
14208 2001-12-02 Ravi Pratap <ravi@ximian.com>
14210 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14211 before trying to reduce it.
14213 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14215 * constant.cs (LookupConstantValue): Implement.
14217 (EmitConstant): Use the above in emitting the constant.
14219 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14220 that are user-defined by doing a LookupConstantValue on them.
14222 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14225 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14227 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14229 (BaseAccess.DoResolve): Implement.
14231 (MemberAccess.DoResolve): Split this routine into a
14232 ResolveMemberAccess routine that can be used independently
14234 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14236 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14237 As that share bits of the implementation. Is returns a boolean,
14238 while As returns the Type that is being probed.
14240 2001-12-01 Ravi Pratap <ravi@ximian.com>
14242 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14243 instead of a Literal - much easier.
14245 (EnumInTransit): Remove - utterly useless :-)
14247 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14249 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14251 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14252 chain when we have no associated expression.
14254 2001-11-30 Ravi Pratap <ravi@ximian.com>
14256 * constant.cs (Define): Use Location while reporting the errror.
14258 Also emit a warning when 'new' is used and there is no inherited
14261 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14264 (LookupEnumValue): Implement to lookup an enum member's value and define it
14267 (Populate): Re-write accordingly to use the above routine.
14269 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14271 * expression.cs (This): Fix prototype for DoResolveLValue to
14272 override the base class DoResolveLValue.
14274 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14277 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14278 (we need to load the address of the field here). This fixes
14281 (FieldExpr.DoResolveLValue): Call the DoResolve
14282 function to initialize the Instance expression.
14284 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14285 correctly the GetEnumerator operation on a value type.
14287 * cs-parser.jay: Add more simple parsing error catches.
14289 * statement.cs (Switch): Add support for string switches.
14290 Handle null specially.
14292 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14294 2001-11-28 Ravi Pratap <ravi@ximian.com>
14296 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14298 (declare_local_constant): New helper function.
14300 * statement.cs (AddConstant): Keep a separate record of constants
14302 (IsConstant): Implement to determine if a variable is a constant.
14304 (GetConstantExpression): Implement.
14306 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14308 * statement.cs (IsVariableDefined): Re-write.
14310 2001-11-27 Ravi Pratap <ravi@ximian.com>
14312 * class.cs (TypeContainer::FindMembers): Look for constants
14313 in the case when we are looking for MemberTypes.Field
14315 * expression.cs (MemberAccess::DoResolve): Check that in the
14316 case we are a FieldExpr and a Literal, we are not being accessed
14317 by an instance reference.
14319 * cs-parser.jay (local_constant_declaration): Implement.
14321 (declaration_statement): Implement for constant declarations.
14323 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14325 * statement.cs (Switch): Catch double defaults.
14327 (Switch): More work on the switch() statement
14328 implementation. It works for integral values now, need to finish
14332 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14334 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14335 integer literals into other integer literals. To be used by
14338 2001-11-24 Ravi Pratap <ravi@ximian.com>
14340 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14343 (EmitDynamicInitializers): Cope with the above since we extract data
14344 directly from ArrayData now.
14346 (ExpectInitializers): Keep track of whether initializers are mandatory
14349 (Bounds): Make it a hashtable to prevent the same dimension being
14350 recorded for every element in that dimension.
14352 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14355 Also fix bug which was causing the indices to be emitted in the reverse
14358 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14360 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14361 unfinished. They do not work, because the underlying code is
14364 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14366 * cs-parser.jay: Remove bogus fixme.
14368 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14369 on Switch statement.
14371 2001-11-23 Ravi Pratap <ravi@ximian.com>
14373 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14376 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14377 parameter. Apparently, any expression is allowed.
14379 (ValidateInitializers): Update accordingly.
14381 (CheckIndices): Fix some tricky bugs thanks to recursion.
14383 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14384 I was being completely brain-dead.
14386 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14387 and re-write acordingly.
14389 (DelegateInvocation): Re-write accordingly.
14391 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14393 (MakeByteBlob): Handle types more correctly.
14395 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14396 initialization from expressions but it is incomplete because I am a complete
14399 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14401 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14402 on If. Basically, we have to return `true' (ie, we do return to
14403 our caller) only if both branches of the if return.
14405 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14406 short-circuit operators, handle them as short circuit operators.
14408 (Cast.DoResolve): Resolve type.
14409 (Cast.Cast): Take an expression as the target type.
14411 * cs-parser.jay (cast_expression): Remove old hack that only
14412 allowed a limited set of types to be handled. Now we take a
14413 unary_expression and we resolve to a type during semantic
14416 Use the grammar productions from Rhys to handle casts (this is
14417 not complete like Rhys syntax yet, we fail to handle that corner
14418 case that C# has regarding (-x), but we will get there.
14420 2001-11-22 Ravi Pratap <ravi@ximian.com>
14422 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14423 field which is an array type.
14425 * cs-parser.jay (declare_local_variables): Support array initialization too.
14427 * typemanager.cs (MakeKey): Implement.
14429 (everywhere): Use the above appropriately.
14431 * cs-parser.jay (for_statement): Update for array initialization while
14432 declaring variables.
14434 * ecore.cs : The error message was correct, it's the variable's names that
14435 were misleading ;-) Make the code more readable.
14437 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14438 the correct type etc.
14440 (ConvertExplicit): Handle Enum types by examining the underlying type.
14442 2001-11-21 Ravi Pratap <ravi@ximian.com>
14444 * parameter.cs (GetCallingConvention): Always return
14445 CallingConventions.Standard for now.
14447 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14449 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14450 and `r' after calling DoNumericPromotions.
14452 * ecore.cs: Fix error message (the types were in the wrong order).
14454 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14455 BindingFlags.Instance as well
14457 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14458 implicit int literal conversion in an empty cast so that we
14459 propagate the right type upstream.
14461 (UnboxCast): new class used to unbox value types.
14462 (Expression.ConvertExplicit): Add explicit type conversions done
14465 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14466 the target type before applying the implicit LongLiterals to ULong
14469 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14471 * cs-parser.jay (for_statement): Reworked the way For works: now
14472 we declare manually any variables that are introduced in
14473 for_initializer to solve the problem of having out-of-band code
14474 emition (that is what got for broken).
14476 (declaration_statement): Perform the actual variable declaration
14477 that used to be done in local_variable_declaration here.
14479 (local_variable_declaration): Do not declare anything, just pass
14480 the information on a DictionaryEntry
14482 2001-11-20 Ravi Pratap <ravi@ximian.com>
14484 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14485 re-write of the logic to now make it recursive.
14487 (UpdateIndices): Re-write accordingly.
14489 Store element data in a separate ArrayData list in the above methods.
14491 (MakeByteBlob): Implement to dump the array data into a byte array.
14493 2001-11-19 Ravi Pratap <ravi@ximian.com>
14495 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14498 * constant.cs (Define): Implement.
14500 (EmitConstant): Re-write fully.
14502 Pass in location info.
14504 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14507 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14508 DictionaryEntry since we need location info too.
14510 (constant_declaration): Update accordingly.
14512 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14513 code into another method : UpdateIndices.
14515 2001-11-18 Ravi Pratap <ravi@ximian.com>
14517 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14518 some type checking etc.
14520 2001-11-17 Ravi Pratap <ravi@ximian.com>
14522 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14523 bits to provide dimension info if the user skips doing that.
14525 Update second constructor to store the rank correctly.
14527 2001-11-16 Ravi Pratap <ravi@ximian.com>
14529 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14530 and try to implement.
14532 * ../errors/cs0150.cs : Add.
14534 * ../errors/cs0178.cs : Add.
14536 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14538 * statement.cs: Implement foreach on multi-dimensional arrays.
14540 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14541 name of the params argument.
14543 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14544 initializing the array.
14546 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14547 we can use this elsewhere.
14549 * statement.cs: Finish implementation of foreach for single
14552 * cs-parser.jay: Use an out-of-band stack to pass information
14553 around, I wonder why I need this.
14555 foreach_block: Make the new foreach_block the current_block.
14557 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14558 function used to return a static Parameters structure. Used for
14559 empty parameters, as those are created very frequently.
14561 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14563 2001-11-15 Ravi Pratap <ravi@ximian.com>
14565 * interface.cs : Default modifier is private, not public. The
14566 make verify test passes again.
14568 2001-11-15 Ravi Pratap <ravi@ximian.com>
14570 * support.cs (ReflectionParameters): Fix logic to determine
14571 whether the last parameter is a params one. Test 9 passes again.
14573 * delegate.cs (Populate): Register the builders we define with
14574 RegisterParameterForBuilder. Test 19 passes again.
14576 * cs-parser.jay (property_declaration): Reference $6 instead
14577 of $$ to get at the location.
14579 (indexer_declaration): Similar stuff.
14581 (attribute): Ditto.
14583 * class.cs (Property): Register parameters for the Get and Set methods
14584 if they exist. Test 23 passes again.
14586 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14587 call to EmitArguments as we are sure there aren't any params arguments.
14588 Test 32 passes again.
14590 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14591 IndexOutOfRangeException.
14593 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14594 Test 33 now passes again.
14596 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14598 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14599 broke a bunch of things. Will have to come up with a better way
14600 of tracking locations.
14602 * statement.cs: Implemented foreach for single dimension arrays.
14604 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14606 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14607 an error. This removes the lookup from the critical path.
14609 * cs-parser.jay: Removed use of temporary_loc, which is completely
14612 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14614 * support.cs (ReflectionParameters.ParameterModifier): Report
14615 whether the argument is a PARAMS argument or not.
14617 * class.cs: Set the attribute `ParamArrayAttribute' on the
14618 parameter argument.
14620 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14621 and cons_param_array_attribute (ConstructorInfo for
14622 ParamArrayAttribute).,
14624 * codegen.cs: Emit the return using the `Return' statement, that
14625 way we can report the error correctly for missing return values.
14627 * class.cs (Method.Emit): Clean up.
14629 * expression.cs (Argument.Resolve): Take another argument: the
14630 location where this argument is used. Notice that this is not
14631 part of the "Argument" class as to reduce the size of the
14632 structure (we know the approximate location anyways).
14634 Test if the argument is a variable-reference, if not, then
14635 complain with a 206.
14637 (Argument.Emit): Emit addresses of variables.
14639 (Argument.FullDesc): Simplify.
14641 (Invocation.DoResolve): Update for Argument.Resolve.
14643 (ElementAccess.DoResolve): ditto.
14645 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14646 method should be virtual, as this method is always virtual.
14648 (NewDelegate.DoResolve): Update for Argument.Resolve.
14650 * class.cs (ConstructorInitializer.DoResolve): ditto.
14652 * attribute.cs (Attribute.Resolve): ditto.
14654 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14656 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14658 * expression.cs (ParameterReference): Drop IStackStorage and implement
14659 IAssignMethod instead.
14661 (LocalVariableReference): ditto.
14663 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14664 IAssignMethod instead.
14666 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14668 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14669 enumerations that are used in heavily used structures derive from
14670 byte in a laughable and pathetic attempt to reduce memory usage.
14671 This is the kind of pre-optimzations that you should not do at
14672 home without adult supervision.
14674 * expression.cs (UnaryMutator): New class, used to handle ++ and
14675 -- separatedly from the other unary operators. Cleans up the
14676 code, and kills the ExpressionStatement dependency in Unary.
14678 (Unary): Removed `method' and `Arguments' from this class, making
14679 it smaller, and moving it all to SimpleCall, so I can reuse this
14680 code in other locations and avoid creating a lot of transient data
14681 strucutres when not required.
14683 * cs-parser.jay: Adjust for new changes.
14685 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14687 * enum.cs (Enum.Populate): If there is a failure during
14690 * cs-parser.jay (opt_enum_base): we used to catch type errors
14691 here, but this is really incorrect. The type error should be
14692 catched during semantic analysis.
14694 2001-12-11 Ravi Pratap <ravi@ximian.com>
14696 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14697 current_local_parameters as expected since I, in my stupidity, had forgotten
14700 * attribute.cs (GetValidPlaces): Fix stupid bug.
14702 * class.cs (Method::Emit): Perform check on applicability of attributes.
14704 (Constructor::Emit): Ditto.
14706 (Field::Emit): Ditto.
14708 (Field.Location): Store location information.
14710 (Property, Event, Indexer, Operator): Ditto.
14712 * cs-parser.jay (field_declaration): Pass in location for each field.
14714 * ../errors/cs0592.cs : Add.
14716 2001-11-12 Ravi Pratap <ravi@ximian.com>
14718 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14720 (InitCoreTypes): Update accordingly.
14722 (RegisterAttrType, LookupAttr): Implement.
14724 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14725 info about the same.
14727 (Resolve): Update to populate the above as necessary.
14729 (Error592): Helper.
14731 (GetValidPlaces): Helper to the above.
14733 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14735 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14737 2001-11-12 Ravi Pratap <ravi@ximian.com>
14739 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14741 * ../errors/cs0617.cs : Add.
14743 2001-11-11 Ravi Pratap <ravi@ximian.com>
14745 * enum.cs (Emit): Rename to Populate to be more consistent with what
14746 we expect it to do and when exactly it is called.
14748 * class.cs, rootcontext.cs : Update accordingly.
14750 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14751 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14753 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14755 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14756 of a fieldinfo using the above, when dealing with a FieldBuilder.
14758 2001-11-10 Ravi Pratap <ravi@ximian.com>
14760 * ../errors/cs0031.cs : Add.
14762 * ../errors/cs1008.cs : Add.
14764 * ../errrors/cs0543.cs : Add.
14766 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14769 (FindMembers): Implement.
14771 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14772 enums and delegates too.
14774 (enum_types): Rename to builder_to_enum.
14776 (delegate_types): Rename to builder_to_delegate.
14778 * delegate.cs (FindMembers): Implement.
14780 2001-11-09 Ravi Pratap <ravi@ximian.com>
14782 * typemanager.cs (IsEnumType): Implement.
14784 * enum.cs (Emit): Re-write parts to account for the underlying type
14785 better and perform checking etc.
14787 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14788 of the underlying type.
14790 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14793 * enum.cs (error31): Helper to report error #31.
14795 * cs-parser.jay (enum_declaration): Store location of each member too.
14797 * enum.cs (member_to_location): New hashtable.
14799 (AddEnumMember): Update location hashtable.
14801 (Emit): Use the location of each member while reporting errors.
14803 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14805 * cs-parser.jay: A for_initializer if is a
14806 local_variable_declaration really ammount to have an implicit
14807 block with the variable declaration and no initializer for for.
14809 * statement.cs (For.Emit): Cope with null initializers.
14811 This fixes the infinite loop on for initializers.
14813 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14815 * enum.cs: More cleanup.
14817 * ecore.cs: Remove dead code.
14819 * class.cs (Property.Emit): More simplification.
14820 (Event.Emit): ditto.
14822 Reworked to have less levels of indentation.
14824 2001-11-08 Ravi Pratap <ravi@ximian.com>
14826 * class.cs (Property): Emit attributes.
14836 * enum.cs (Emit): Ditto.
14838 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14841 * class.cs (Field, Event, etc.): Move attribute generation into the
14842 Emit method everywhere.
14844 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14845 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14846 as we had no way of defining nested enums !
14848 * rootcontext.cs : Adjust code accordingly.
14850 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14852 2001-11-07 Ravi Pratap <ravi@ximian.com>
14854 * expression.cs (EvalConstantExpression): Move into ecore.cs
14856 * enum.cs (Enum): Rename some members and make them public and readonly
14857 according to our convention.
14859 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14862 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14864 (Enum::Emit): Write a simple version for now which doesn't try to compute
14865 expressions. I shall modify this to be more robust in just a while.
14867 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14869 (TypeContainer::CloseType): Create the Enum types too.
14871 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14873 * expression.cs (EvalConstantExpression): Get rid of completely.
14875 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14876 user-defined values and other cases.
14878 (IsValidEnumLiteral): Helper function.
14880 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14881 out there in the case we had a literal FieldExpr.
14883 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
14885 (Literalize): Revamp a bit to take two arguments.
14887 (EnumLiteral): New class which derives from Literal to wrap enum literals.
14889 2001-11-06 Ravi Pratap <ravi@ximian.com>
14891 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
14893 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
14895 (Resolve): Use the above to ensure we have proper initializers.
14897 2001-11-05 Ravi Pratap <ravi@ximian.com>
14899 * expression.cs (Expression::EvalConstantExpression): New method to
14900 evaluate constant expressions.
14902 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
14904 2001-11-07 Miguel de Icaza <miguel@ximian.com>
14906 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
14909 (Binary.ResolveOperator): Handle operator != (object a, object b)
14910 and operator == (object a, object b);
14912 (Binary.DoNumericPromotions): Indicate whether the numeric
14913 promotion was possible.
14915 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
14918 Made the ArrayAccess implement interface IAssignMethod instead of
14919 IStackStore as the order in which arguments are passed reflects
14922 * assign.cs: Instead of using expr.ExprClass to select the way of
14923 assinging, probe for the IStackStore/IAssignMethod interfaces.
14925 * typemanager.cs: Load InitializeArray definition.
14927 * rootcontext.cs (RootContext.MakeStaticData): Used to define
14928 static data that can be used to initialize arrays.
14930 2001-11-05 Miguel de Icaza <miguel@ximian.com>
14932 * expression.cs: Handle operator== and operator!= for booleans.
14934 (Conditioal.Reduce): Implement reducer for the ?: operator.
14936 (Conditional.Resolve): Implement dead code elimination.
14938 (Binary.Resolve): Catch string literals and return a new
14939 concatenated string.
14941 (Unary.Reduce): Implement reduction of unary expressions.
14943 * ecore.cs: Split out the expression core handling here.
14945 (Expression.Reduce): New method used to perform constant folding
14946 and CSE. This is needed to support constant-expressions.
14948 * statement.cs (Statement.EmitBoolExpression): Pass true and false
14949 targets, and optimize for !x.
14951 2001-11-04 Ravi Pratap <ravi@ximian.com>
14953 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
14954 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
14955 set custom atttributes.
14957 * literal.cs (Literal::GetValue): New abstract method to return the actual
14958 value of the literal, cast as an object.
14960 (*Literal): Implement GetValue method.
14962 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
14963 expressions to the arraylist but objects of type Argument.
14965 * class.cs (TypeContainer::Emit): Emit our attributes too.
14967 (Method::Emit, Constructor::Emit): Ditto.
14969 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
14970 to be ignoring earlier.
14972 2001-11-03 Ravi Pratap <ravi@ximian.com>
14974 * attribute.cs (AttributeSection::Define): Implement to do the business
14975 of constructing a CustomAttributeBuilder.
14977 (Attribute): New trivial class. Increases readability of code.
14979 * cs-parser.jay : Update accordingly.
14981 (positional_argument_list, named_argument_list, named_argument): New rules
14983 (attribute_arguments): Use the above so that we are more correct.
14985 2001-11-02 Ravi Pratap <ravi@ximian.com>
14987 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
14988 to perform all checks for a method with a params parameter.
14990 (Invocation::OverloadResolve): Update to use the above method and therefore
14991 cope correctly with params method invocations.
14993 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
14996 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
14997 constructors in our parent too because we can't afford to miss out on
15000 * attribute.cs (AttributeSection): New name for the class Attribute
15002 Other trivial changes to improve readability.
15004 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15005 use the new class names.
15007 2001-11-01 Ravi Pratap <ravi@ximian.com>
15009 * class.cs (Method::Define): Complete definition for params types too
15011 (Indexer::Define): Ditto.
15013 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15014 Cope everywhere with a request for info about the array parameter.
15016 2001-11-01 Ravi Pratap <ravi@ximian.com>
15018 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15020 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15021 local_variable_type to extract the string corresponding to the type.
15023 (local_variable_type): Fixup the action to use the new helper method.
15025 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15028 * expression.cs : Clean out code which uses the above.
15030 2001-10-31 Ravi Pratap <ravi@ximian.com>
15032 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15033 and bale out if necessary by returning a false.
15035 (RegisterProperty): Ditto.
15037 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15038 and print out appropriate error messages.
15040 * interface.cs (everywhere): Ditto.
15042 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15043 location to constructor.
15045 * class.cs (Property, Event, Indexer): Update accordingly.
15047 * ../errors/cs111.cs : Added.
15049 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15050 of a method, as laid down by the spec.
15052 (Invocation::OverloadResolve): Use the above method.
15054 2001-10-31 Ravi Pratap <ravi@ximian.com>
15056 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15057 now take a TypeContainer and a Parameters object.
15059 (ParameterData): Modify return type of ParameterModifier method to be
15060 Parameter.Modifier and not a string.
15062 (ReflectionParameters, InternalParameters): Update accordingly.
15064 * expression.cs (Argument::GetParameterModifier): Same here.
15066 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15067 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15068 symbol in it at all so maybe this is only for now.
15070 2001-10-30 Ravi Pratap <ravi@ximian.com>
15072 * support.cs (InternalParameters): Constructor now takes an extra argument
15073 which is the actual Parameters class.
15075 (ParameterDesc): Update to provide info on ref/out modifiers.
15077 * class.cs (everywhere): Update call to InternalParameters to pass in
15078 the second argument too.
15080 * support.cs (ParameterData): Add ParameterModifier, which is a method
15081 to return the modifier info [ref/out etc]
15083 (InternalParameters, ReflectionParameters): Implement the above.
15085 * expression.cs (Argument::ParameterModifier): Similar function to return
15086 info about the argument's modifiers.
15088 (Invocation::OverloadResolve): Update to take into account matching modifiers
15091 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15092 a new SetFormalParameters object which we pass to InternalParameters.
15094 2001-10-30 Ravi Pratap <ravi@ximian.com>
15096 * expression.cs (NewArray): Merge into the ArrayCreation class.
15098 2001-10-29 Ravi Pratap <ravi@ximian.com>
15100 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15101 NewUserdefinedArray into one as there wasn't much of a use in having
15104 * expression.cs (Argument): Change field's name to ArgType from Type.
15106 (Type): New readonly property which returns the proper type, taking into
15107 account ref/out modifiers.
15109 (everywhere): Adjust code accordingly for the above.
15111 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15112 whether we are emitting for a ref or out parameter.
15114 * expression.cs (Argument::Emit): Use the above field to set the state.
15116 (LocalVariableReference::Emit): Update to honour the flag and emit the
15119 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15121 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15123 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15125 (ReflectionParameters, InternalParameters): Implement the above method.
15127 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15130 (Invocation::FullMethodDesc): Ditto.
15132 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15134 * cs-parser.jay: Add extra production for the second form of array
15137 * expression.cs (ArrayCreation): Update to reflect the above
15140 * Small changes to prepare for Array initialization.
15142 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15144 * typemanager.cs (ImplementsInterface): interface might be null;
15145 Deal with this problem;
15147 Also, we do store negative hits on the cache (null values), so use
15148 this instead of calling t.GetInterfaces on the type everytime.
15150 2001-10-28 Ravi Pratap <ravi@ximian.com>
15152 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15154 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15155 split functionality out into different classes.
15157 (New::FormArrayType): Move into NewBuiltinArray.
15159 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15162 (NewBuiltinArray): New class to handle creation of built-in arrays.
15164 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15165 account creation of one-dimensional arrays.
15167 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15169 (NewUserdefinedArray::DoResolve): Implement.
15171 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15173 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15174 we maintain inside the TypeManager. This is necessary to perform lookups on the
15177 (LookupType): Update to perform GetType on the module builders too.
15179 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15181 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15183 2001-10-23 Ravi Pratap <ravi@ximian.com>
15185 * expression.cs (New::DoResolve): Implement guts of array creation.
15187 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15189 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15191 * expression.cs: Fix bug I introduced lsat night that broke
15194 (Expression.Resolve): Report a 246 error (can not resolve name)
15195 if we find a SimpleName in the stream.
15197 (Expression.ResolveLValue): Ditto.
15199 (Expression.ResolveWithSimpleName): This function is a variant of
15200 ResolveName, this one allows SimpleNames to be returned without a
15201 warning. The only consumer of SimpleNames is MemberAccess
15203 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15205 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15206 might arrive here. I have my doubts that this is correct.
15208 * statement.cs (Lock): Implement lock statement.
15210 * cs-parser.jay: Small fixes to support `lock' and `using'
15212 * cs-tokenizer.cs: Remove extra space
15214 * driver.cs: New flag --checked, allows to turn on integer math
15217 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15218 Threading.Monitor.Exit
15220 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15222 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15223 Expression Class to be IndexerAccess.
15225 Notice that Indexer::DoResolve sets the eclass to Value.
15227 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15229 * class.cs (TypeContainer::Emit): Emit code for indexers.
15231 * assign.cs (IAssignMethod): New interface implemented by Indexers
15232 and Properties for handling assignment.
15234 (Assign::Emit): Simplify and reuse code.
15236 * expression.cs (IndexerAccess, PropertyExpr): Implement
15237 IAssignMethod, clean up old code.
15239 2001-10-22 Ravi Pratap <ravi@ximian.com>
15241 * typemanager.cs (ImplementsInterface): New method to determine if a type
15242 implements a given interface. Provides a nice cache too.
15244 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15247 (ConvertReferenceExplicit): Ditto.
15249 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15250 various methods, with correct names etc.
15252 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15253 Operator.UnaryNegation.
15255 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15256 we have a unary plus or minus operator.
15258 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15261 * everywhere : update accordingly.
15263 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15266 * class.cs (Method::Define): For the case where we are implementing a method
15267 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15268 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15270 2001-10-21 Ravi Pratap <ravi@ximian.com>
15272 * interface.cs (FindMembers): Implement to work around S.R.E
15275 * typemanager.cs (IsInterfaceType): Implement.
15277 (FindMembers): Update to handle interface types too.
15279 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15280 use IsAssignableFrom as that is not correct - it doesn't work.
15282 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15283 and accordingly override EmitStatement.
15285 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15286 using the correct logic :-)
15288 2001-10-19 Ravi Pratap <ravi@ximian.com>
15290 * ../errors/cs-11.cs : Add to demonstrate error -11
15292 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15294 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15295 then pass this as a hint to ResolveLValue.
15297 * expression.cs (FieldExpr): Add Location information
15299 (FieldExpr::LValueResolve): Report assignment to readonly
15302 (Expression::ExprClassFromMemberInfo): Pass location information.
15304 (Expression::ResolveLValue): Add new method that resolves an
15307 (Expression::DoResolveLValue): Default invocation calls
15310 (Indexers): New class used to keep track of indexers in a given
15313 (IStackStore): Renamed from LValue, as it did not really describe
15314 what this did. Also ResolveLValue is gone from this interface and
15315 now is part of Expression.
15317 (ElementAccess): Depending on the element access type
15319 * typemanager.cs: Add `indexer_name_type' as a Core type
15320 (System.Runtime.CompilerServices.IndexerNameAttribute)
15322 * statement.cs (Goto): Take a location.
15324 2001-10-18 Ravi Pratap <ravi@ximian.com>
15326 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15327 if two delegates are compatible.
15329 (NewDelegate::DoResolve): Update to take care of the case when
15330 we instantiate a delegate from another delegate.
15332 * typemanager.cs (FindMembers): Don't even try to look up members
15333 of Delegate types for now.
15335 2001-10-18 Ravi Pratap <ravi@ximian.com>
15337 * delegate.cs (NewDelegate): New class to take care of delegate
15340 * expression.cs (New): Split the delegate related code out into
15341 the NewDelegate class.
15343 * delegate.cs (DelegateInvocation): New class to handle delegate
15346 * expression.cs (Invocation): Split out delegate related code into
15347 the DelegateInvocation class.
15349 2001-10-17 Ravi Pratap <ravi@ximian.com>
15351 * expression.cs (New::DoResolve): Implement delegate creation fully
15352 and according to the spec.
15354 (New::DoEmit): Update to handle delegates differently.
15356 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15357 because of which we were printing out arguments in reverse order !
15359 * delegate.cs (VerifyMethod): Implement to check if the given method
15360 matches the delegate.
15362 (FullDelegateDesc): Implement.
15364 (VerifyApplicability): Implement.
15366 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15367 delegate invocations too.
15369 (Invocation::Emit): Ditto.
15371 * ../errors/cs1593.cs : Added.
15373 * ../errors/cs1594.cs : Added.
15375 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15377 2001-10-16 Ravi Pratap <ravi@ximian.com>
15379 * typemanager.cs (intptr_type): Core type for System.IntPtr
15381 (InitCoreTypes): Update for the same.
15383 (iasyncresult_type, asynccallback_type): Ditto.
15385 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15388 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15391 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15392 the builders for the 4 members of a delegate type :-)
15394 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15397 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15399 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15401 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15403 * statement.cs (Break::Emit): Implement.
15404 (Continue::Emit): Implement.
15406 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15407 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15408 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15409 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15412 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15413 properties that track the label for the current loop (begin of the
15414 loop and end of the loop).
15416 2001-10-15 Ravi Pratap <ravi@ximian.com>
15418 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15419 use of emitting anything at all.
15421 * class.cs, rootcontext.cs : Get rid of calls to the same.
15423 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15425 (Populate): Define the constructor correctly and set the implementation
15428 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15431 (AddDelegateType): Implement.
15433 (IsDelegateType): Implement helper method.
15435 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15437 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15438 and accordingly handle it.
15440 * delegate.cs (Populate): Take TypeContainer argument.
15441 Implement bits to define the Invoke method. However, I still haven't figured out
15442 how to take care of the native int bit :-(
15444 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15445 Qualify the name of the delegate, not its return type !
15447 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15450 (StandardConversionExists): Checking for array types turns out to be recursive.
15452 (ConvertReferenceExplicit): Implement array conversion.
15454 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15456 2001-10-12 Ravi Pratap <ravi@ximian.com>
15458 * cs-parser.jay (delegate_declaration): Store the fully qualified
15459 name as it is a type declaration.
15461 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15464 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15465 as TypeContainer::DefineType.
15467 (Populate): Method in which all the definition of the various methods (Invoke)
15470 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15473 (CloseDelegate): Finally creates the delegate.
15475 * class.cs (TypeContainer::DefineType): Update to define delegates.
15476 (Populate, Emit and CloseType): Do the same thing here too.
15478 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15479 delegates in all these operations.
15481 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15483 * expression.cs: LocalTemporary: a new expression used to
15484 reference a temporary that has been created.
15486 * assign.cs: Handle PropertyAccess back here, so that we can
15487 provide the proper semantic access to properties.
15489 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15490 a few more explicit conversions.
15492 * modifiers.cs: `NEW' modifier maps to HideBySig.
15494 * expression.cs (PropertyExpr): Make this into an
15495 ExpressionStatement, and support the EmitStatement code path.
15497 Perform get/set error checking, clean up the interface.
15499 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15500 them into toplevel access objects.
15502 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15504 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15507 * typemanager.cs: Keep track here of our PropertyBuilders again to
15508 work around lameness in SRE.
15510 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15512 * expression.cs (LValue::LValueResolve): New method in the
15513 interface, used to perform a second resolution pass for LValues.
15515 (This::DoResolve): Catch the use of this in static methods.
15517 (This::LValueResolve): Implement.
15519 (This::Store): Remove warning, assigning to `this' in structures
15522 (Invocation::Emit): Deal with invocation of
15523 methods on value types. We need to pass the address to structure
15524 methods rather than the object itself. (The equivalent code to
15525 emit "this" for structures leaves the entire structure on the
15526 stack instead of a pointer to it).
15528 (ParameterReference::DoResolve): Compute the real index for the
15529 argument based on whether the method takes or not a `this' pointer
15530 (ie, the method is static).
15532 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15533 value types returned from functions when we need to invoke a
15534 method on the sturcture.
15537 2001-10-11 Ravi Pratap <ravi@ximian.com>
15539 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15540 defining the type in the Modulebuilder or Typebuilder. This is to take
15541 care of nested types which need to be defined on the TypeBuilder using
15542 DefineNestedMethod.
15544 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15545 methods in RootContext, only ported to be part of TypeContainer.
15547 (TypeContainer::GetInterfaceOrClass): Ditto.
15549 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15551 * interface.cs (Interface::DefineInterface): New method. Does exactly
15552 what RootContext.CreateInterface did earlier, only it takes care of nested types
15555 (Interface::GetInterfaces): Move from RootContext here and port.
15557 (Interface::GetInterfaceByName): Same here.
15559 * rootcontext.cs (ResolveTree): Re-write.
15561 (PopulateTypes): Re-write.
15563 * class.cs (TypeContainer::Populate): Populate nested types too.
15564 (TypeContainer::Emit): Emit nested members too.
15566 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15567 instead just use the name argument passed in as it is already fully
15570 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15571 to TypeContainer mapping to see if a type is user-defined.
15573 * class.cs (TypeContainer::CloseType): Implement.
15575 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15576 the default constructor.
15578 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15581 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15583 * interface.cs (CloseType): Create the type here.
15585 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15588 Remove all the methods which are now in TypeContainer.
15590 2001-10-10 Ravi Pratap <ravi@ximian.com>
15592 * delegate.cs (Define): Re-write bits to define the delegate
15595 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15597 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15599 * expression.cs (ImplicitReferenceConversion): handle null as well
15600 as a source to convert to any reference type.
15602 * statement.cs (Return): Perform any implicit conversions to
15603 expected return type.
15605 Validate use of return statement.
15607 * codegen.cs (EmitContext): Pass the expected return type here.
15609 * class.cs (Method, Constructor, Property): Pass expected return
15610 type to EmitContext.
15612 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15614 * expression.cs: Make DoResolve take an EmitContext instead of a
15617 Replaced `l' and `location' for `loc', for consistency.
15619 (Error, Warning): Remove unneeded Tc argument.
15621 * assign.cs, literal.cs, constant.cs: Update to new calling
15624 * codegen.cs: EmitContext now contains a flag indicating whether
15625 code is being generated in a static method or not.
15627 * cs-parser.jay: DecomposeQI, new function that replaces the old
15628 QualifiedIdentifier. Now we always decompose the assembled
15629 strings from qualified_identifier productions into a group of
15632 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15634 * rootcontext.cs: Deal with field-less struct types correctly now
15635 by passing the size option to Define Type.
15637 * class.cs: Removed hack that created one static field.
15639 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15641 * statement.cs: Moved most of the code generation here.
15643 2001-10-09 Ravi Pratap <ravi@ximian.com>
15645 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15648 (ElementAccess): Remove useless bits for now - keep checks as the spec
15651 2001-10-08 Ravi Pratap <ravi@ximian.com>
15653 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15654 and start performing checks according to the spec.
15656 2001-10-07 Ravi Pratap <ravi@ximian.com>
15658 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15659 rank_specifiers instead.
15661 (rank_specifiers): Change the order in which the rank specifiers are stored
15663 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15665 * expression.cs (ElementAccess): Implement the LValue interface too.
15667 2001-10-06 Ravi Pratap <ravi@ximian.com>
15669 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15670 except that user defined conversions are not included.
15672 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15673 perform the conversion of the return type, if necessary.
15675 (New::DoResolve): Check whether we are creating an array or an object
15676 and accordingly do the needful.
15678 (New::Emit): Same here.
15680 (New::DoResolve): Implement guts of array creation.
15682 (New::FormLookupType): Helper function.
15684 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15686 * codegen.cs: Removed most of the code generation here, and move the
15687 corresponding code generation bits to the statement classes.
15689 Added support for try/catch/finalize and throw.
15691 * cs-parser.jay: Added support for try/catch/finalize.
15693 * class.cs: Catch static methods having the flags override,
15694 virtual or abstract.
15696 * expression.cs (UserCast): This user cast was not really doing
15697 what it was supposed to do. Which is to be born in fully resolved
15698 state. Parts of the resolution were being performed at Emit time!
15702 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15704 * expression.cs: Implicity convert the result from UserCast.
15706 2001-10-05 Ravi Pratap <ravi@ximian.com>
15708 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15709 prevented it from working correctly.
15711 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15712 merely ConvertImplicit.
15714 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15716 * typemanager.cs: Make the LookupTypeContainer function static,
15717 and not per-instance.
15719 * class.cs: Make static FindMembers (the one that takes a Type
15722 * codegen.cs: Add EmitForeach here.
15724 * cs-parser.jay: Make foreach a toplevel object instead of the
15725 inline expansion, as we need to perform semantic analysis on it.
15727 2001-10-05 Ravi Pratap <ravi@ximian.com>
15729 * expression.cs (Expression::ImplicitUserConversion): Rename to
15730 UserDefinedConversion.
15732 (Expression::UserDefinedConversion): Take an extra argument specifying
15733 whether we look for explicit user conversions too.
15735 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15737 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15739 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15740 with the appropriate arguments.
15742 * cs-parser.jay (cast_expression): Record location too.
15744 * expression.cs (Cast): Record location info.
15746 (Expression::ConvertExplicit): Take location argument.
15748 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15749 to determine if we are doing explicit conversions.
15751 (UserCast::Emit): Update accordingly.
15753 (Expression::ConvertExplicit): Report an error if everything fails.
15755 * ../errors/cs0030.cs : Add.
15757 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15759 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15760 virtual and newslot bits.
15762 * class.cs (TypeContainer::RegisterRequiredImplementations):
15763 Record methods we need.
15765 (TypeContainer::MakeKey): Helper function to make keys for
15766 MethodBases, since the Methodbase key is useless.
15768 (TypeContainer::Populate): Call RegisterRequiredImplementations
15769 before defining the methods.
15771 Create a mapping for method_builders_to_methods ahead of time
15772 instead of inside a tight loop.
15774 (::RequireMethods): Accept an object as the data to set into the
15775 hashtable so we can report interface vs abstract method mismatch.
15777 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15779 * report.cs: Make all of it static.
15781 * rootcontext.cs: Drop object_type and value_type computations, as
15782 we have those in the TypeManager anyways.
15784 Drop report instance variable too, now it is a global.
15786 * driver.cs: Use try/catch on command line handling.
15788 Add --probe option to debug the error reporting system with a test
15791 * report.cs: Add support for exiting program when a probe
15792 condition is reached.
15794 2001-10-03 Ravi Pratap <ravi@ximian.com>
15796 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15797 we do a forcible conversion regardless of type, to check if
15798 ForceConversion returns a null.
15800 (Binary::error19): Use location to report error.
15802 (Unary::error23): Use location here too.
15804 * ../errors/cs0019.cs : Check in.
15806 * ../errors/cs0023.cs : Check in.
15808 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15809 case of a non-null MethodInfo object with a length of 0 !
15811 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15812 an applicable member - according to the spec :-)
15813 Also fix logic to find members in base types.
15815 (Unary::ResolveOperator): Same here.
15817 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15818 as I was getting thoroughly confused between this and error19 :-)
15820 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15821 (::FindMostEncompassedType): Implement.
15822 (::FindMostEncompassingType): Implement.
15823 (::StandardConversionExists): Implement.
15825 (UserImplicitCast): Re-vamp. We now need info about most specific
15826 source and target types so that we can do the necessary conversions.
15828 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15829 mathematical union with no duplicates.
15831 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15833 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15834 in order from base classes to child classes, so that we can in
15835 child classes look up in our parent for method names and
15836 attributes (required for handling abstract, virtual, new, override
15837 constructs: we need to instrospect our base class, and if we dont
15838 populate the classes in order, the introspection might be
15839 incorrect. For example, a method could query its parent before
15840 the parent has any methods and would determine that the parent has
15841 no abstract methods (while it could have had them)).
15843 (RootContext::CreateType): Record the order in which we define the
15846 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15848 * class.cs (TypeContainer::Populate): Also method definitions can
15849 fail now, keep track of this.
15851 (TypeContainer::FindMembers): Implement support for
15852 DeclaredOnly/noDeclaredOnly flag.
15854 (Constructor::Emit) Return the ConstructorBuilder.
15856 (Method::Emit) Return the MethodBuilder.
15857 Check for abstract or virtual methods to be public.
15859 * rootcontext.cs (RootContext::CreateType): Register all the
15860 abstract methods required for the class to be complete and the
15861 interface methods that must be implemented.
15863 * cs-parser.jay: Report error 501 (method requires body if it is
15864 not marked abstract or extern).
15866 * expression.cs (TypeOf::Emit): Implement.
15868 * typemanager.cs: runtime_handle_type, new global type.
15870 * class.cs (Property::Emit): Generate code for properties.
15872 2001-10-02 Ravi Pratap <ravi@ximian.com>
15874 * expression.cs (Unary::ResolveOperator): Find operators on base type
15875 too - we now conform exactly to the spec.
15877 (Binary::ResolveOperator): Same here.
15879 * class.cs (Operator::Define): Fix minor quirk in the tests.
15881 * ../errors/cs0215.cs : Added.
15883 * ../errors/cs0556.cs : Added.
15885 * ../errors/cs0555.cs : Added.
15887 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15889 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
15890 single integer which is really efficient
15892 2001-10-01 Ravi Pratap <ravi@ximian.com>
15894 * expression.cs (Expression::ImplicitUserConversion): Use location
15895 even in the case when we are examining True operators.
15897 * class.cs (Operator::Define): Perform extensive checks to conform
15898 with the rules for operator overloading in the spec.
15900 * expression.cs (Expression::ImplicitReferenceConversion): Implement
15901 some of the other conversions mentioned in the spec.
15903 * typemanager.cs (array_type): New static member for the System.Array built-in
15906 (cloneable_interface): For System.ICloneable interface.
15908 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
15909 we start resolving the tree and populating types.
15911 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
15913 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15915 * expression.cs (Expression::ExprClassFromMemberInfo,
15916 Expression::Literalize): Create literal expressions from
15917 FieldInfos which are literals.
15919 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
15920 type casts, because they were wrong. The test suite in tests
15923 (ImplicitNumericConversion): ushort to ulong requires a widening
15926 Int32 constant to long requires widening cast as well.
15928 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
15929 for integers because the type on the stack is not i4.
15931 2001-09-30 Miguel de Icaza <miguel@ximian.com>
15933 * expression.cs (report118): require location argument.
15935 * parameter.cs: Do not dereference potential null value.
15937 * class.cs: Catch methods that lack the `new' keyword when
15938 overriding a name. Report warnings when `new' is used without
15939 anything being there to override.
15941 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
15943 * class.cs: Only add constructor to hashtable if it is non-null
15944 (as now constructors can fail on define).
15946 (TypeManager, Class, Struct): Take location arguments.
15948 Catch field instance initialization in structs as errors.
15950 accepting_filter: a new filter for FindMembers that is static so
15951 that we dont create an instance per invocation.
15953 (Constructor::Define): Catch errors where a struct constructor is
15956 * cs-parser.jay: Pass location information for various new
15959 * delegate.cs (Delegate): take a location argument.
15961 * driver.cs: Do not call EmitCode if there were problesm in the
15962 Definition of the types, as many Builders wont be there.
15964 * decl.cs (Decl::Decl): Require a location argument.
15966 * cs-tokenizer.cs: Handle properly hex constants that can not fit
15967 into integers, and find the most appropiate integer for it.
15969 * literal.cs: Implement ULongLiteral.
15971 * rootcontext.cs: Provide better information about the location of
15972 failure when CreateType fails.
15974 2001-09-29 Miguel de Icaza <miguel@ximian.com>
15976 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
15979 * expression.cs (Binary::CheckShiftArguments): Add missing type
15981 (Binary::ResolveOperator): Add type to the logical and and logical
15982 or, Bitwise And/Or and Exclusive Or code paths, it was missing
15985 (Binary::DoNumericPromotions): In the case where either argument
15986 is ulong (and most signed types combined with ulong cause an
15987 error) perform implicit integer constant conversions as well.
15989 2001-09-28 Miguel de Icaza <miguel@ximian.com>
15991 * expression.cs (UserImplicitCast): Method should always be
15993 (Invocation::BetterConversion): Simplified test for IntLiteral.
15995 (Expression::ImplicitNumericConversion): Split this routine out.
15996 Put the code that performs implicit constant integer conversions
15999 (Expression::Resolve): Become a wrapper around DoResolve so we can
16000 check eclass and type being set after resolve.
16002 (Invocation::Badness): Remove this dead function
16004 (Binary::ResolveOperator): Do not compute the expensive argumnets
16005 unless we have a union for it.
16007 (Probe::Emit): Is needs to do an isinst and then
16008 compare against null.
16010 (::CanConvert): Added Location argument. If the Location argument
16011 is null (Location.Null), then we do not report errors. This is
16012 used by the `probe' mechanism of the Explicit conversion. We do
16013 not want to generate an error for something that the user
16014 explicitly requested to be casted. But the pipeline for an
16015 explicit cast first tests for potential implicit casts.
16017 So for now, if the Location is null, it means `Probe only' to
16018 avoid adding another argument. Might have to revise this
16021 (ClassCast): New class used to type cast objects into arbitrary
16022 classes (used in Explicit Reference Conversions).
16024 Implement `as' as well.
16026 Reverted all the patches from Ravi below: they were broken:
16028 * The use of `level' as a mechanism to stop recursive
16029 invocations is wrong. That was there just to catch the
16030 bug with a strack trace but not as a way of addressing
16033 To fix the problem we have to *understand* what is going
16034 on and the interactions and come up with a plan, not
16035 just get things going.
16037 * The use of the type conversion cache that I proposed
16038 last night had an open topic: How does this work across
16039 protection domains. A user defined conversion might not
16040 be public in the location where we are applying the
16041 conversion, a different conversion might be selected
16042 (ie, private A->B (better) but public B->A (worse),
16043 inside A, A->B applies, but outside it, B->A will
16046 * On top of that (ie, even if the above is solved),
16047 conversions in a cache need to be abstract. Ie, `To
16048 convert from an Int to a Short use an OpcodeCast', not
16049 `To convert from an Int to a Short use the OpcodeCast on
16050 the variable 5' (which is what this patch was doing).
16052 2001-09-28 Ravi Pratap <ravi@ximian.com>
16054 * expression.cs (Invocation::ConversionExists): Re-write to use
16055 the conversion cache
16057 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16058 cache all conversions done, not just user-defined ones.
16060 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16061 to determine if a conversion exists instead of acutually trying to
16062 perform the conversion. It's faster too.
16064 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16065 and only then attempt the implicit conversion.
16067 2001-09-28 Ravi Pratap <ravi@ximian.com>
16069 * expression.cs (ConvertImplicit): Use a cache for conversions
16070 already found. Check level of recursion and bail out if necessary.
16072 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16074 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16075 Export standard methods that we expect for string operations.
16077 * statement.cs (Block::UsageWarning): Track usage of variables and
16078 report the errors for not used variables.
16080 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16083 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16085 * codegen.cs: remove unnneded code
16087 * expression.cs: Removed BuiltinTypeAccess class
16089 Fix the order in which implicit conversions are
16092 The previous fixed dropped support for boxed conversions (adding a
16093 test to the test suite now)
16095 (UserImplicitCast::CanConvert): Remove test for source being null,
16096 that code is broken. We should not feed a null to begin with, if
16097 we do, then we should track the bug where the problem originates
16098 and not try to cover it up here.
16100 Return a resolved expression of type UserImplicitCast on success
16101 rather than true/false. Ravi: this is what I was talking about,
16102 the pattern is to use a static method as a "constructor" for
16105 Also, do not create arguments until the very last minute,
16106 otherwise we always create the arguments even for lookups that
16107 will never be performed.
16109 (UserImplicitCast::Resolve): Eliminate, objects of type
16110 UserImplicitCast are born in a fully resolved state.
16112 * typemanager.cs (InitCoreTypes): Init also value_type
16113 (System.ValueType).
16115 * expression.cs (Cast::Resolve): First resolve the child expression.
16117 (LValue): Add new method AddressOf to be used by
16120 Change the argument of Store to take an EmitContext instead of an
16121 ILGenerator, because things like FieldExpr need to be able to call
16122 their children expression to generate the instance code.
16124 (Expression::Error, Expression::Warning): Sugar functions for
16127 (Expression::MemberLookup): Accept a TypeContainer instead of a
16128 Report as the first argument.
16130 (Expression::ResolvePrimary): Killed. I still want to improve
16131 this as currently the code is just not right.
16133 (Expression::ResolveMemberAccess): Simplify, but it is still
16136 (Unary::Resolve): Catch errors in AddressOf operators.
16138 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16139 index to a byte for the short-version, or the compiler will choose
16140 the wrong Emit call, which generates the wrong data.
16142 (ParameterReference::Emit, ::Store): same.
16144 (FieldExpr::AddressOf): Implement.
16146 * typemanager.cs: TypeManager: made public variable instead of
16149 * driver.cs: document --fatal.
16151 * report.cs (ErrorMessage, WarningMessage): new names for the old
16152 Error and Warning classes.
16154 * cs-parser.jay (member_access): Turn built-in access to types
16155 into a normal simplename
16157 2001-09-27 Ravi Pratap <ravi@ximian.com>
16159 * expression.cs (Invocation::BetterConversion): Fix to cope
16160 with q being null, since this was introducing a bug.
16162 * expression.cs (ConvertImplicit): Do built-in conversions first.
16164 2001-09-27 Ravi Pratap <ravi@ximian.com>
16166 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16168 2001-09-27 Ravi Pratap <ravi@ximian.com>
16170 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16171 I had introduced long ago (what's new ?).
16173 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16174 the work of all the checking.
16175 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16176 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16178 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16179 that is the right way.
16181 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16182 overloading resolution. Use everywhere instead of cutting and pasting code.
16184 (Binary::ResolveOperator): Use MakeUnionSet.
16186 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16187 we have to convert to bool types. Not complete yet.
16189 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16191 * typemanager.cs (TypeManager::CSharpName): support ushort.
16193 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16194 to provide an expression that performsn an implicit constant int
16195 conversion (section 6.1.6).
16196 (Expression::ConvertImplicitRequired): Reworked to include
16197 implicit constant expression conversions.
16199 (Expression::ConvertNumericExplicit): Finished.
16201 (Invocation::Emit): If InstanceExpression is null, then it means
16202 that we perform a call on this.
16204 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16206 * expression.cs (Unary::Emit): Remove some dead code.
16207 (Probe): Implement Resolve and Emit for `is'.
16208 (Expression::ConvertImplicitRequired): Attempt to do constant
16209 expression conversions here. Maybe should be moved to
16210 ConvertImplicit, but I am not sure.
16211 (Expression::ImplicitLongConstantConversionPossible,
16212 Expression::ImplicitIntConstantConversionPossible): New functions
16213 that tell whether is it possible to apply an implicit constant
16214 expression conversion.
16216 (ConvertNumericExplicit): Started work on explicit numeric
16219 * cs-parser.jay: Update operator constants.
16221 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16222 (Parameters::GetSignature): Hook up VerifyArgs here.
16223 (Parameters::VerifyArgs): Verifies that no two arguments have the
16226 * class.cs (Operator): Update the operator names to reflect the
16227 ones that the spec expects (as we are just stringizing the
16230 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16231 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16232 previous usage did only work for our methods.
16233 (Expression::ConvertImplicit): Handle decimal implicit numeric
16234 conversions as well.
16235 (Expression::InternalTypeConstructor): Used to invoke constructors
16236 on internal types for default promotions.
16238 (Unary::Emit): Implement special handling for the pre/post
16239 increment/decrement for overloaded operators, as they need to have
16240 the same semantics as the other operators.
16242 (Binary::ResolveOperator): ditto.
16243 (Invocation::ConversionExists): ditto.
16244 (UserImplicitCast::Resolve): ditto.
16246 2001-09-26 Ravi Pratap <ravi@ximian.com>
16248 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16249 operator, return after emitting body. Regression tests pass again !
16251 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16252 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16253 (Invocation::OverloadResolve): Ditto.
16254 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16256 * everywhere : update calls to the above methods accordingly.
16258 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16260 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16262 * expression.cs (ExpressionStatement): New base class used for
16263 expressions that can appear in statements, so that we can provide
16264 an alternate path to generate expression that do not leave a value
16267 (Expression::Emit, and all the derivatives): We no longer return
16268 whether a value is left on the stack or not. Every expression
16269 after being emitted leaves a single value on the stack.
16271 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16272 facilties of ExpressionStatement if possible.
16274 * cs-parser.jay: Update statement_expression.
16276 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16278 * driver.cs: Change the wording of message
16280 2001-09-25 Ravi Pratap <ravi@ximian.com>
16282 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16283 the type of the expression to the return type of the method if
16284 we have an overloaded operator match ! The regression tests pass again !
16285 (Unary::ResolveOperator): Ditto.
16287 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16288 to find "op_Implicit", not "implicit" ;-)
16289 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16290 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16292 * everywhere : Correct calls to the above accordingly.
16294 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16295 (ConvertImplicit): Do user-defined conversion if it exists.
16297 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16299 * assign.cs: track location.
16300 (Resolve): Use implicit conversions on assignment.
16302 * literal.cs: Oops. Not good, Emit of short access values should
16303 pass (Bytes) or the wrong argument will be selected.
16305 * expression.cs (Unary::Emit): Emit code for -expr.
16307 (Unary::ResolveOperator): Handle `Substract' for non-constants
16308 (substract from zero from the non-constants).
16309 Deal with Doubles as well.
16311 (Expression::ConvertImplicitRequired): New routine that reports an
16312 error if no implicit conversion exists.
16314 (Invocation::OverloadResolve): Store the converted implicit
16315 expressions if we make them
16317 2001-09-24 Ravi Pratap <ravi@ximian.com>
16319 * class.cs (ConstructorInitializer): Take a Location argument.
16320 (ConstructorBaseInitializer): Same here.
16321 (ConstructorThisInitializer): Same here.
16323 * cs-parser.jay : Update all calls accordingly.
16325 * expression.cs (Unary, Binary, New): Take location argument.
16326 Update accordingly everywhere.
16328 * cs-parser.jay : Update all calls to the above to take a location
16331 * class.cs : Ditto.
16333 2001-09-24 Ravi Pratap <ravi@ximian.com>
16335 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16336 (Invocation::BetterConversion): Same here
16337 (Invocation::ConversionExists): Ditto.
16339 (Invocation::ConversionExists): Implement.
16341 2001-09-22 Ravi Pratap <ravi@ximian.com>
16343 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16344 Also take an additional TypeContainer argument.
16346 * All over : Pass in TypeContainer as argument to OverloadResolve.
16348 * typemanager.cs (CSharpName): Update to check for the string type and return
16351 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16354 2001-09-21 Ravi Pratap <ravi@ximian.com>
16356 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16357 (Invocation::BetterFunction): Implement.
16358 (Invocation::BetterConversion): Implement.
16359 (Invocation::ConversionExists): Skeleton, no implementation yet.
16361 Okay, things work fine !
16363 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16365 * typemanager.cs: declare and load enum_type, delegate_type and
16368 * expression.cs (Expression::Emit): Now emit returns a value that
16369 tells whether a value is left on the stack or not. This strategy
16370 might be reveted tomorrow with a mechanism that would address
16371 multiple assignments.
16372 (Expression::report118): Utility routine to report mismatches on
16375 (Unary::Report23): Report impossible type/operator combination
16378 (Unary::IsIncrementableNumber): Whether the type can be
16379 incremented or decremented with add.
16380 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16382 (Unary::ResolveOperator): Implement ++, !, ~,
16384 (Invocation::Emit): Deal with new Emit convetion.
16386 * All Expression derivatives: Updated their Emit method to return
16387 whether they leave values on the stack or not.
16389 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16390 stack for expressions that are statements.
16392 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16394 * expression.cs (LValue): New interface. Must be implemented by
16396 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16399 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16400 interface for generating code, simplifies the code.
16402 2001-09-20 Ravi Pratap <ravi@ximian.com>
16404 * expression.cs (everywhere): Comment out return statements in ::Resolve
16405 methods to avoid the warnings.
16407 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16409 * driver.cs (parse): Report error 2001 if we can not open the
16412 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16415 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16418 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16419 otherwise nested blocks end up with the same index.
16421 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16423 * expression.cs: Instead of having FIXMEs in the Resolve
16424 functions, throw exceptions so it is obvious that we are facing a
16427 * cs-parser.jay (invocation_expression): Pass Location information.
16429 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16430 Use a basename for those routines because .NET does not like paths
16433 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16436 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16438 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16439 are loading the correct data types (throws an exception if not).
16440 (TypeManager::InitCoreTypes): Use CoreLookupType
16442 * expression.cs (Unary::ResolveOperator): return the child
16443 expression for expressions which are just +expr.
16444 (Unary::ResolveOperator): Return negative literals for -LITERAL
16445 expressions (otherwise they are Unary {Literal}).
16446 (Invocation::Badness): Take into account `Implicit constant
16447 expression conversions'.
16449 * literal.cs (LongLiteral): Implement long literal class.
16450 (IntLiteral): export the `Value' of the intliteral.
16452 2001-09-19 Ravi Pratap <ravi@ximian.com>
16454 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16456 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16457 instead of 'Operator'
16459 * expression.cs (Binary::ResolveOperator): Update accordingly.
16460 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16463 * cs-parser.jay (unary_expression): Update to use the new names.
16465 * gen-treedump.cs (GetUnary): Same here.
16467 * expression.cs (Unary::Resolve): Implement.
16468 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16469 operators are found instead of making noise ;-)
16470 (Unary::ResolveOperator): New method to do precisely the same thing which
16471 Binary::ResolveOperator does for Binary expressions.
16472 (Unary.method, .Arguments): Add.
16473 (Unary::OperName): Implement.
16474 (Unary::ForceConversion): Copy and Paste !
16476 * class.cs (Operator::Define): Fix a small bug for the case when we have
16479 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16480 for the inbuilt operators. Only overloading works for now ;-)
16482 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16484 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16485 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16487 * expression.cs (This::Emit): Implement.
16488 (This::Resolve): Implement.
16489 (TypeOf:Resolve): Implement.
16490 (Expression::ResolveSimpleName): Add an implicit this to instance
16492 (MemberAccess::Resolve): Deal with Parameters and Fields.
16493 Bind instance variable to Field expressions.
16494 (FieldExpr::Instance): New field used to track the expression that
16495 represents the object instance.
16496 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16498 (FieldExpr::Emit): Implement.
16500 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16501 the last instruction contains a return opcode to avoid generating
16502 the last `ret' instruction (this generates correct code, and it is
16503 nice to pass the peverify output).
16505 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16506 initializer for static and instance variables.
16507 (Constructor::Emit): Allow initializer to be null in the case of
16508 static constructors. Only emit initializer for instance
16511 (TypeContainer::FindMembers): Return a null array if there are no
16514 Also fix the code for the MemberTypes.Method branch, as it was not
16515 scanning that for operators (or tried to access null variables before).
16517 * assign.cs (Assign::Emit): Handle instance and static fields.
16521 * driver.cs: Stop compilation if there are parse errors.
16523 * cs-parser.jay (constructor_declaration): Provide default base
16524 initializer for non-static constructors.
16525 (constructor_declarator): Do not provide a default base
16526 initializers if none was specified.
16527 Catch the fact that constructors should not have parameters.
16529 * class.cs: Do not emit parent class initializers for static
16530 constructors, that should be flagged as an error.
16532 2001-09-18 Ravi Pratap <ravi@ximian.com>
16534 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16535 Move back code into TypeContainer::Populate.
16537 2001-09-18 Ravi Pratap <ravi@ximian.com>
16539 * class.cs (TypeContainer::AddConstructor): Fix the check to
16540 compare against Name, not Basename.
16541 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16543 * cs-parser.jay : Update accordingly.
16545 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16546 for methods, don't forget to look into the operators too.
16547 (RegisterMethodBuilder): Helper method to take care of this for
16548 methods, constructors and operators.
16549 (Operator::Define): Completely revamp.
16550 (Operator.OperatorMethod, MethodName): New fields.
16551 (TypeContainer::Populate): Move the registering of builders into
16552 RegisterMethodBuilder.
16553 (Operator::Emit): Re-write.
16555 * expression.cs (Binary::Emit): Comment out code path to emit method
16556 invocation stuff for the case when we have a user defined operator. I am
16557 just not able to get it right !
16559 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16561 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16564 (Expression::MemberLookup): Provide a version that allows to
16565 specify the MemberTypes and BindingFlags.
16567 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16568 so it was not fetching variable information from outer blocks.
16570 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16571 Beforefieldinit as it was buggy.
16573 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16574 that Ravi put here.
16576 * class.cs (Constructor::Emit): Only emit if block is not null.
16577 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16578 deal with this by semantically definining it as if the user had
16581 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16582 constructors as we now "emit" them at a higher level.
16584 (TypeContainer::DefineDefaultConstructor): Used to define the
16585 default constructors if none was provided.
16587 (ConstructorInitializer): Add methods Resolve and Emit.
16589 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16591 2001-09-17 Ravi Pratap <ravi@ximian.com>
16593 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16594 the default constructor builder with our hashtable for methodbuilders
16597 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16598 and argument_count is 0 in which case we have a match.
16599 (Binary::ResolveOperator): More null checking and miscellaneous coding
16602 2001-09-17 Ravi Pratap <ravi@ximian.com>
16604 * rootcontext.cs (IsNameSpace): Compare against null.
16606 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16608 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16609 and Unary::Operator.
16611 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16614 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16615 we have overloaded operators.
16616 (Binary::ResolveOperator): Implement the part which does the operator overload
16619 * class.cs (Operator::Emit): Implement.
16620 (TypeContainer::Emit): Emit the operators we have too.
16622 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16623 the case when we have a user-defined operator.
16625 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16627 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16629 2001-09-16 Ravi Pratap <ravi@ximian.com>
16631 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16632 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16633 (Constructor::Emit): Implement.
16634 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16635 if we have no work to do.
16636 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16639 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16640 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16642 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16645 2001-09-15 Ravi Pratap <ravi@ximian.com>
16647 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16649 (Tree::RecordNamespace): Method to do what the name says ;-)
16650 (Tree::Namespaces): Property to get at the namespaces hashtable.
16652 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16655 * rootcontext.cs (IsNamespace): Fixed it :-)
16657 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16659 * class.cs (TypeContainer::FindMembers): Add support for
16661 (MethodCore): New class that encapsulates both the shared aspects
16662 of a Constructor and a Method.
16663 (Method, Constructor): Factored pieces into MethodCore.
16665 * driver.cs: Added --fatal which makes errors throw exceptions.
16666 Load System assembly as well as part of the standard library.
16668 * report.cs: Allow throwing exceptions on errors for debugging.
16670 * modifiers.cs: Do not use `parent', instead use the real type
16671 container to evaluate permission settings.
16673 * class.cs: Put Ravi's patch back in. He is right, and we will
16674 have to cope with the
16676 2001-09-14 Ravi Pratap <ravi@ximian.com>
16678 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16679 FamORAssem, not FamANDAssem.
16681 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16683 * driver.cs: Added --parse option that only parses its input files
16686 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16687 incorrect. IsTopLevel is not used to tell whether an object is
16688 root_types or not (that can be achieved by testing this ==
16689 root_types). But to see if this is a top-level *class* (not
16690 necessarly our "toplevel" container).
16692 2001-09-14 Ravi Pratap <ravi@ximian.com>
16694 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16695 parent instead of a direct call to GetType.
16697 2001-09-14 Ravi Pratap <ravi@ximian.com>
16699 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16700 Modifiers.TypeAttr. This should just be a call to that method.
16702 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16703 object so that we can determine if we are top-level or not.
16705 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16708 * enum.cs (Enum::Define): Ditto.
16710 * modifiers.cs (FieldAttr): Re-write.
16712 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16713 (TypeContainer::HaveStaticConstructor): New property to provide access
16714 to precisely that info.
16716 * modifiers.cs (MethodAttr): Re-write.
16717 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16719 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16720 of top-level types as claimed.
16722 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16724 * expression.cs (MemberLookup): Fruitless attempt to lookup
16725 constructors. Maybe I need to emit default constructors? That
16726 might be it (currently .NET emits this for me automatically).
16727 (Invocation::OverloadResolve): Cope with Arguments == null.
16728 (Invocation::EmitArguments): new function, shared by the new
16729 constructor and us.
16730 (Invocation::Emit): Handle static and instance methods. Emit
16731 proper call instruction for virtual or non-virtual invocations.
16732 (New::Emit): Implement.
16733 (New::Resolve): Implement.
16734 (MemberAccess:Resolve): Implement.
16735 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16736 to track instances.
16737 (FieldExpr::Resolve): Set type.
16739 * support.cs: Handle empty arguments.
16741 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16742 SimpleLookup): Auxiliary routines to help parse a qualifier
16745 Update qualifier_identifier rule.
16747 * codegen.cs: Removed debugging messages.
16749 * class.cs: Make this a global thing, this acts just as a "key" to
16750 objects that we might have around.
16752 (Populate): Only initialize method_builders_to_methods once.
16754 * expression.cs (PropertyExpr): Initialize type from the
16757 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16758 Resolve pattern. Attempt to implicitly convert value to boolean.
16761 * expression.cs: Set the type for the int32/int32 argument case.
16762 (Binary::ResolveOperator): Set the return type to boolean for
16763 comparission operators
16765 * typemanager.cs: Remove debugging print code.
16767 (Invocation::Resolve): resolve type.
16769 * class.cs: Allocate a MemberInfo of the correct size, as the code
16770 elsewhere depends on the test to reflect the correct contents.
16772 (Method::) Keep track of parameters, due to System.Reflection holes
16774 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16777 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16778 of the exact size and return that.
16780 (Class::LookupMethodByBuilder): New function that maps
16781 MethodBuilders to its methods. Required to locate the information
16782 on methods because System.Reflection bit us again.
16784 * support.cs: New file, contains an interface ParameterData and
16785 two implementations: ReflectionParameters and InternalParameters
16786 used to access Parameter information. We will need to grow this
16789 * expression.cs (Invocation::GetParameterData): implement a cache
16790 and a wrapper around the ParameterData creation for methods.
16791 (Invocation::OverloadResolve): Use new code.
16793 2001-09-13 Ravi Pratap <ravi@ximian.com>
16795 * class.cs (TypeContainer::EmitField): Remove and move into
16796 (Field::Define): here and modify accordingly.
16797 (Field.FieldBuilder): New member.
16798 (TypeContainer::Populate): Update accordingly.
16799 (TypeContainer::FindMembers): Implement.
16801 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16803 * statement.cs: (VariableInfo::VariableType): New field to be
16804 initialized with the full type once it is resolved.
16806 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16808 * parameter.cs (GetParameterInfo): Use a type cache to compute
16809 things only once, and to reuse this information
16811 * expression.cs (LocalVariableReference::Emit): Implement.
16812 (OpcodeCast::Emit): fix.
16814 (ParameterReference::Resolve): Implement.
16815 (ParameterReference::Emit): Implement.
16817 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16818 that are expressions need to stay as Expressions.
16820 * typemanager.cs (CSharpName): Returns the C# name of a type if
16823 * expression.cs (Expression::ConvertImplicit): New function that
16824 implements implicit type conversions.
16826 (Expression::ImplicitReferenceConversion): Implements implicit
16827 reference conversions.
16829 (EmptyCast): New type for transparent casts.
16831 (OpcodeCast): New type for casts of types that are performed with
16832 a sequence of bytecodes.
16834 (BoxedCast): New type used for casting value types into reference
16835 types. Emits a box opcode.
16837 (Binary::DoNumericPromotions): Implements numeric promotions of
16838 and computation of the Binary::Type.
16840 (Binary::EmitBranchable): Optimization.
16842 (Binary::Emit): Implement code emission for expressions.
16844 * typemanager.cs (TypeManager): Added two new core types: sbyte
16847 2001-09-12 Ravi Pratap <ravi@ximian.com>
16849 * class.cs (TypeContainer::FindMembers): Method which does exactly
16850 what Type.FindMembers does, only we don't have to use reflection. No
16851 implementation yet.
16853 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16854 typecontainer objects as we need to get at them.
16855 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16857 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16858 typecontainer object.
16860 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16861 of just a Report object.
16863 2001-09-11 Ravi Pratap <ravi@ximian.com>
16865 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16867 (TypeContainer::Populate): Now define the delegates of the type too.
16868 (TypeContainer.Delegates): Property to access the list of delegates defined
16871 * delegates.cs (Delegate::Define): Implement partially.
16873 * modifiers.cs (TypeAttr): Handle more flags.
16875 2001-09-11 Ravi Pratap <ravi@ximian.com>
16877 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16879 (Operator::Define): Re-write logic to get types by using the LookupType method
16880 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16881 (Indexer::Define): Ditto.
16882 (Event::Define): Ditto.
16883 (Property::Define): Ditto.
16885 2001-09-10 Ravi Pratap <ravi@ximian.com>
16887 * class.cs (TypeContainer::Populate): Now define operators too.
16888 (TypeContainer.Operators): New property to access the list of operators
16890 (Operator.OperatorMethodBuilder): New member to hold the method builder
16891 for the operator we are defining.
16892 (Operator::Define): Implement.
16894 2001-09-10 Ravi Pratap <ravi@ximian.com>
16896 * class.cs (Event::Define): Make the prefixes of the accessor methods
16897 addOn_ and removeOn_
16899 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
16900 of the location being passed in too. Ideally, this should go later since all
16901 error reporting should be done through the Report object.
16903 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
16904 (Populate): Iterate thru the indexers we have and define them too.
16905 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
16906 for the get and set accessors.
16907 (Indexer::Define): Implement.
16909 2001-09-09 Miguel de Icaza <miguel@ximian.com>
16911 * expression.cs (Binary::Resolve): Beginning of it. I scratched
16912 my previous implementation, did not work.
16914 * typemanager.cs: Add a couple of missing types (the longs).
16916 * literal.cs: Use TypeManager.bool_type instead of getting it.
16918 * expression.cs (EventExpr): New kind of expressions.
16919 (Expressio::ExprClassFromMemberInfo): finish
16921 2001-09-08 Miguel de Icaza <miguel@ximian.com>
16923 * assign.cs: Emit stores to static fields differently.
16925 2001-09-08 Ravi Pratap <ravi@ximian.com>
16927 * Merge in changes and adjust code to tackle conflicts. Backed out my
16928 code in Assign::Resolve ;-)
16930 2001-09-08 Ravi Pratap <ravi@ximian.com>
16932 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
16933 instead Report.Error and also pass in the location.
16934 (CSharpParser::Lexer): New readonly property to return the reference
16935 to the Tokenizer object.
16936 (declare_local_variables): Use Report.Error with location instead of plain
16940 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
16941 (Operator.CheckBinaryOperator): Ditto.
16943 * cs-parser.jay (operator_declarator): Update accordingly.
16945 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
16946 (CheckBinaryOperator): Same here.
16948 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
16949 on the name without any prefixes of namespace names etc. This is because we
16950 already might have something already fully qualified like
16951 'System.Console.WriteLine'
16953 * assign.cs (Resolve): Begin implementation. Stuck ;-)
16955 2001-09-07 Ravi Pratap <ravi@ximian.com>
16957 * cs-tokenizer.cs (location): Return a string which also contains
16960 * expression.cs (ElementAccess): New class for expressions of the
16961 type 'element access.'
16962 (BaseAccess): New class for expressions of the type 'base access.'
16963 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
16966 * cs-parser.jay (element_access): Implement action.
16967 (base_access): Implement actions.
16968 (checked_expression, unchecked_expression): Implement.
16970 * cs-parser.jay (local_variable_type): Correct and implement.
16971 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
16973 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
16975 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
16976 name and the specifiers.
16978 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
16980 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
16981 making them all public ;-)
16983 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
16986 2001-09-07 Miguel de Icaza <miguel@ximian.com>
16988 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
16990 (FieldExpr, PropertyExprs): New resolved expressions.
16991 (SimpleName::MemberStaticCheck): Perform static checks for access
16992 to non-static fields on static methods. Maybe this should be
16993 generalized for MemberAccesses.
16994 (SimpleName::ResolveSimpleName): More work on simple name
16997 * cs-parser.jay (primary_expression/qualified_identifier): track
16998 the parameter index.
17000 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17001 (EmitContext::EmitBoolExpression): Chain to expression generation
17002 instead of temporary hack.
17003 (::EmitStatementExpression): Put generic expression code generation.
17005 * assign.cs (Assign::Emit): Implement variable assignments to
17006 local variables, parameters and fields.
17008 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17010 * statement.cs (Block::GetVariableInfo): New method, returns the
17011 VariableInfo for a variable name in a block.
17012 (Block::GetVariableType): Implement in terms of GetVariableInfo
17014 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17015 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17017 2001-09-06 Ravi Pratap <ravi@ximian.com>
17019 * cs-parser.jay (operator_declaration): Continue on my quest : update
17020 to take attributes argument.
17021 (event_declaration): Ditto.
17022 (enum_declaration): Ditto.
17023 (indexer_declaration): Ditto.
17025 * class.cs (Operator::Operator): Update constructor accordingly.
17026 (Event::Event): Ditto.
17028 * delegate.cs (Delegate::Delegate): Same here.
17030 * enum.cs (Enum::Enum): Same here.
17032 2001-09-05 Ravi Pratap <ravi@ximian.com>
17034 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17036 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17038 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17039 being passed around as an arraylist.
17040 (Attributes::AddAttribute): Method to add attribute sections.
17042 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17043 (struct_declaration): Update accordingly.
17044 (constant_declaration): Update.
17045 (field_declaration): Update.
17046 (method_header): Update.
17047 (fixed_parameter): Update.
17048 (parameter_array): Ditto.
17049 (property_declaration): Ditto.
17050 (destructor_declaration): Ditto.
17052 * class.cs (Struct::Struct): Update constructors accordingly.
17053 (Class::Class): Ditto.
17054 (Field::Field): Ditto.
17055 (Method::Method): Ditto.
17056 (Property::Property): Ditto.
17057 (TypeContainer::OptAttribute): update property's return type.
17059 * interface.cs (Interface.opt_attributes): New member.
17060 (Interface::Interface): Update to take the extra Attributes argument.
17062 * parameter.cs (Parameter::Parameter): Ditto.
17064 * constant.cs (Constant::Constant): Ditto.
17066 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17067 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17068 the attributes as a parameter.
17069 (InterfaceProperty): Update constructor call.
17070 (InterfaceEvent): Ditto.
17071 (InterfaceMethod): Ditto.
17072 (InterfaceIndexer): Ditto.
17074 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17075 pass the attributes too.
17076 (interface_event_declaration): Ditto.
17077 (interface_property_declaration): Ditto.
17078 (interface_method_declaration): Ditto.
17079 (interface_declaration): Ditto.
17081 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17083 * class.cs (Method::Define): Track the "static Main" definition to
17084 create an entry point.
17086 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17087 EntryPoint if we find it.
17089 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17090 (EmitContext::ig): Make this variable public.
17092 * driver.cs: Make the default output file be the first file name
17093 with the .exe extension.
17095 Detect empty compilations
17097 Handle various kinds of output targets. Handle --target and
17098 rename -t to --dumper.
17100 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17101 methods inherited from Expression return now an Expression. This
17102 will is used during the tree rewriting as we resolve them during
17105 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17106 the spec. Missing entirely is the information about
17107 accessability of elements of it.
17109 (Expression::ExprClassFromMemberInfo): New constructor for
17110 Expressions that creates a fully initialized Expression based on
17111 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17114 (Invocation::Resolve): Begin implementing resolution of invocations.
17116 * literal.cs (StringLiteral): Implement Emit.
17118 2001-09-05 Ravi Pratap <ravi@ximian.com>
17120 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17123 2001-09-04 Ravi Pratap <ravi@ximian.com>
17125 * cs-parser.jay (attribute_arguments): Implement actions.
17126 (attribute): Fix bug in production. Implement action.
17127 (attribute_list): Implement.
17128 (attribute_target): Implement.
17129 (attribute_target_specifier, opt_target_specifier): Implement
17130 (CheckAttributeTarget): New method to check if the attribute target
17132 (attribute_section): Implement.
17133 (opt_attributes): Implement.
17135 * attribute.cs : New file to handle attributes.
17136 (Attribute): Class to hold attribute info.
17138 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17139 (attribute_section): Modify production to use 2 different rules to
17140 achieve the same thing. 1 s/r conflict down !
17141 Clean out commented, useless, non-reducing dimension_separator rules.
17143 * class.cs (TypeContainer.attributes): New member to hold list
17144 of attributes for a type.
17145 (Struct::Struct): Modify to take one more argument, the attribute list.
17146 (Class::Class): Ditto.
17147 (Field::Field): Ditto.
17148 (Method::Method): Ditto.
17149 (Property::Property): Ditto.
17151 * cs-parser.jay (struct_declaration): Update constructor call to
17152 pass in the attributes too.
17153 (class_declaration): Ditto.
17154 (constant_declaration): Ditto.
17155 (field_declaration): Ditto.
17156 (method_header): Ditto.
17157 (fixed_parameter): Ditto.
17158 (parameter_array): Ditto.
17159 (property_declaration): Ditto.
17161 * constant.cs (Constant::Constant): Update constructor similarly.
17162 Use System.Collections.
17164 * parameter.cs (Parameter::Parameter): Update as above.
17166 2001-09-02 Ravi Pratap <ravi@ximian.com>
17168 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17169 (TypeContainer.delegates): New member to hold list of delegates.
17171 * cs-parser.jay (delegate_declaration): Implement the action correctly
17172 this time as I seem to be on crack ;-)
17174 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17176 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17177 tell whether an identifier represents a namespace.
17179 * expression.cs (NamespaceExpr): A namespace expression, used only
17180 temporarly during expression resolution.
17181 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17182 utility functions to resolve names on expressions.
17184 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17186 * codegen.cs: Add hook for StatementExpressions.
17188 * class.cs: Fix inverted test for static flag in methods.
17190 2001-09-02 Ravi Pratap <ravi@ximian.com>
17192 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17193 to make it coincide with MS' number.
17194 (Operator::CheckBinaryOperator): Ditto.
17196 * ../errors/errors.txt : Remove error numbers added earlier.
17198 * ../errors/cs1019.cs : Test case for error # 1019
17200 * ../errros/cs1020.cs : Test case for error # 1020
17202 * cs-parser.jay : Clean out commented cruft.
17203 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17204 used anywhere - non-reducing rule.
17205 (namespace_declarations): Non-reducing rule - comment out.
17207 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17208 with TypeContainer::AddEnum.
17210 * delegate.cs : New file for delegate handling classes.
17211 (Delegate): Class for declaring delegates.
17213 * makefile : Update.
17215 * cs-parser.jay (delegate_declaration): Implement.
17217 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17219 * class.cs (Event::Define): Implement.
17220 (Event.EventBuilder): New member.
17222 * class.cs (TypeContainer::Populate): Update to define all enums and events
17224 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17225 readonly fields for all these cases ?
17227 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17229 * class.cs (Property): Revamp to use the convention of making fields readonly.
17230 Accordingly modify code elsewhere.
17232 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17233 the Define method of the Property class.
17235 * class.cs : Clean up applied patch and update references to variables etc. Fix
17237 (TypeContainer::Populate): Update to define all the properties we have. Also
17238 define all enumerations.
17240 * enum.cs (Define): Implement.
17242 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17244 * cs-parser.jay (overloadable_operator): The semantic value is an
17245 enum of the Operator class.
17246 (operator_declarator): Implement actions.
17247 (operator_declaration): Implement.
17249 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17250 validity of definitions.
17251 (Operator::CheckBinaryOperator): Static method to check for binary operators
17252 (TypeContainer::AddOperator): New method to add an operator to a type.
17254 * cs-parser.jay (indexer_declaration): Added line to actually call the
17255 AddIndexer method so it gets added ;-)
17257 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17258 already taken care of by the MS compiler ?
17260 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17262 * class.cs (Operator): New class for operator declarations.
17263 (Operator::OpType): Enum for the various operators.
17265 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17267 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17268 ostensibly handle this in semantic analysis.
17270 * cs-parser.jay (general_catch_clause): Comment out
17271 (specific_catch_clauses, specific_catch_clause): Ditto.
17272 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17273 (catch_args, opt_catch_args): New productions.
17274 (catch_clause): Rewrite to use the new productions above
17275 (catch_clauses): Modify accordingly.
17276 (opt_catch_clauses): New production to use in try_statement
17277 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17278 and re-write the code in the actions to extract the specific and
17279 general catch clauses by being a little smart ;-)
17281 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17282 Hooray, try and catch statements parse fine !
17284 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17286 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17287 string from the hashtable of variables.
17289 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17290 I end up making that mistake ;-)
17291 (catch_clauses): Fixed gross error which made Key and Value of the
17292 DictionaryEntry the same : $1 !!
17294 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17296 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17298 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17299 when the add and remove accessors are specified.
17301 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17303 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17304 information about indexer_declarator.
17305 (indexer_declarator): Implement actions.
17306 (parsing_indexer): New local boolean used to keep track of whether
17307 we are parsing indexers or properties. This is necessary because
17308 implicit_parameters come into picture even for the get accessor in the
17309 case of an indexer.
17310 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17312 * class.cs (Indexer): New class for indexer declarations.
17313 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17314 (TypeContainer::indexers): New member to hold list of indexers for the
17317 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17319 * cs-parser.jay (add_accessor_declaration): Implement action.
17320 (remove_accessor_declaration): Implement action.
17321 (event_accessors_declaration): Implement
17322 (variable_declarators): swap statements for first rule - trivial.
17324 * class.cs (Event): New class to hold information about event
17326 (TypeContainer::AddEvent): New method to add an event to a type
17327 (TypeContainer::events): New member to hold list of events.
17329 * cs-parser.jay (event_declaration): Implement actions.
17331 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17333 * cs-parser.jay (dim_separators): Implement. Make it a string
17334 concatenating all the commas together, just as they appear.
17335 (opt_dim_separators): Modify accordingly
17336 (rank_specifiers): Update accordingly. Basically do the same
17337 thing - instead, collect the brackets here.
17338 (opt_rank_sepcifiers): Modify accordingly.
17339 (array_type): Modify to actually return the complete type string
17340 instead of ignoring the rank_specifiers.
17341 (expression_list): Implement to collect the expressions
17342 (variable_initializer): Implement. We make it a list of expressions
17343 essentially so that we can handle the array_initializer case neatly too.
17344 (variable_initializer_list): Implement.
17345 (array_initializer): Make it a list of variable_initializers
17346 (opt_array_initializer): Modify accordingly.
17348 * expression.cs (New::NType): Add enumeration to help us
17349 keep track of whether we have an object/delegate creation
17350 or an array creation.
17351 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17352 members to hold data about array creation.
17353 (New:New): Modify to update NewType
17354 (New:New): New Overloaded contructor for the array creation
17357 * cs-parser.jay (array_creation_expression): Implement to call
17358 the overloaded New constructor.
17360 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17362 * class.cs (TypeContainer::Constructors): Return member
17363 constructors instead of returning null.
17365 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17367 * typemanager.cs (InitCoreTypes): Initialize the various core
17368 types after we have populated the type manager with the user
17369 defined types (this distinction will be important later while
17370 compiling corlib.dll)
17372 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17373 on Expression Classification. Now all expressions have a method
17374 `Resolve' and a method `Emit'.
17376 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17377 generation from working. Also add some temporary debugging
17380 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17382 * codegen.cs: Lots of code generation pieces. This is only the
17383 beginning, will continue tomorrow with more touches of polish. We
17384 handle the fundamentals of if, while, do, for, return. Others are
17385 trickier and I need to start working on invocations soon.
17387 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17390 * codegen.cs (EmitContext): New struct, used during code
17391 emission to keep a context. Most of the code generation will be
17394 * cs-parser.jay: Add embedded blocks to the list of statements of
17395 this block. So code generation proceeds in a top down fashion.
17397 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17399 * statement.cs: Add support for multiple child blocks.
17401 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17403 * codegen.cs (EmitCode): New function, will emit the code for a
17404 Block of code given a TypeContainer and its ILGenerator.
17406 * statement.cs (Block): Standard public readonly optimization.
17407 (Block::Block constructors): Link children.
17408 (Block::Child): Child Linker.
17409 (Block::EmitVariables): Emits IL variable declarations.
17411 * class.cs: Drop support for MethodGroups here, delay until
17413 (Method::): Applied the same simplification that I did before, and
17414 move from Properties to public readonly fields.
17415 (Method::ParameterTypes): Returns the parameter types for the
17416 function, and implements a cache that will be useful later when I
17417 do error checking and the semantic analysis on the methods is
17419 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17420 and made a method, optional argument tells whether this is a class
17421 or a structure to apply the `has-this' bit.
17422 (Method::GetCallingConvention): Implement, returns the calling
17424 (Method::Define): Defines the type, a second pass is performed
17425 later to populate the methods.
17427 (Constructor::ParameterTypes): implement a cache similar to the
17428 one on Method::ParameterTypes, useful later when we do semantic
17431 (TypeContainer::EmitMethod): New method. Emits methods.
17433 * expression.cs: Removed MethodGroup class from here.
17435 * parameter.cs (Parameters::GetCallingConvention): new method.
17437 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17439 * class.cs (TypeContainer::Populate): Drop RootContext from the
17442 (Constructor::CallingConvention): Returns the calling convention.
17443 (Constructor::ParameterTypes): Returns the constructor parameter
17446 (TypeContainer::AddConstructor): Keep track of default constructor
17447 and the default static constructor.
17449 (Constructor::) Another class that starts using `public readonly'
17450 instead of properties.
17452 (Constructor::IsDefault): Whether this is a default constructor.
17454 (Field::) use readonly public fields instead of properties also.
17456 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17457 track of static constructors; If none is used, turn on
17458 BeforeFieldInit in the TypeAttributes.
17460 * cs-parser.jay (opt_argument_list): now the return can be null
17461 for the cases where there are no arguments.
17463 (constructor_declarator): If there is no implicit `base' or
17464 `this', then invoke the default parent constructor.
17466 * modifiers.cs (MethodAttr): New static function maps a set of
17467 modifiers flags into a MethodAttributes enum
17468 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17469 MethodAttr, TypeAttr to represent the various mappings where the
17470 modifiers are used.
17471 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17473 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17475 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17478 * interface.cs (PopulateIndexer): Implemented the code generator
17479 for interface indexers.
17481 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17483 * interface.cs (InterfaceMemberBase): Now we track the new status
17486 (PopulateProperty): Implement property population. Woohoo! Got
17487 Methods and Properties going today.
17489 Removed all the properties for interfaces, and replaced them with
17490 `public readonly' fields.
17492 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17494 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17495 initialize their hashtables/arraylists only when they are needed
17496 instead of doing this always.
17498 * parameter.cs: Handle refs and out parameters.
17500 * cs-parser.jay: Use an ArrayList to construct the arguments
17501 instead of the ParameterCollection, and then cast that to a
17504 * parameter.cs: Drop the use of ParameterCollection and use
17505 instead arrays of Parameters.
17507 (GetParameterInfo): Use the Type, not the Name when resolving
17510 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17512 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17513 and instead use public readonly fields.
17515 * class.cs: Put back walking code for type containers.
17517 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17519 * class.cs (MakeConstant): Code to define constants.
17521 * rootcontext.cs (LookupType): New function. Used to locate types
17524 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17526 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17527 this System.Reflection code is. Kudos to Microsoft
17529 * typemanager.cs: Implement a type cache and avoid loading all
17530 types at boot time. Wrap in LookupType the internals. This made
17531 the compiler so much faster. Wow. I rule!
17533 * driver.cs: Make sure we always load mscorlib first (for
17534 debugging purposes, nothing really important).
17536 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17537 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17539 * rootcontext.cs: Lookup types on their namespace; Lookup types
17540 on namespaces that have been imported using the `using' keyword.
17542 * class.cs (TypeContainer::TypeAttr): Virtualize.
17543 (Class::TypeAttr): Return attributes suitable for this bad boy.
17544 (Struct::TypeAttr): ditto.
17545 Handle nested classes.
17546 (TypeContainer::) Remove all the type visiting code, it is now
17547 replaced with the rootcontext.cs code
17549 * rootcontext.cs (GetClassBases): Added support for structs.
17551 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17553 * interface.cs, statement.cs, class.cs, parameter.cs,
17554 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17555 Drop use of TypeRefs, and use strings instead.
17557 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17561 * class.cs (Struct::Struct): set the SEALED flags after
17562 checking the modifiers.
17563 (TypeContainer::TypeAttr): new property, returns the
17564 TypeAttributes for a class.
17566 * cs-parser.jay (type_list): Oops, list production was creating a
17567 new list of base types.
17569 * rootcontext.cs (StdLib): New property.
17570 (GetInterfaceTypeByName): returns an interface by type name, and
17571 encapsulates error handling here.
17572 (GetInterfaces): simplified.
17573 (ResolveTree): Encapsulated all the tree resolution here.
17574 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17577 * driver.cs: Add support for --nostdlib, to avoid loading the
17578 default assemblies.
17579 (Main): Do not put tree resolution here.
17581 * rootcontext.cs: Beginning of the class resolution.
17583 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17585 * rootcontext.cs: Provide better error reporting.
17587 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17589 * rootcontext.cs (CreateInterface): Handle the case where there
17590 are no parent interfaces.
17592 (CloseTypes): Routine to flush types at the end.
17593 (CreateInterface): Track types.
17594 (GetInterfaces): Returns an array of Types from the list of
17595 defined interfaces.
17597 * typemanager.c (AddUserType): Mechanism to track user types (puts
17598 the type on the global type hash, and allows us to close it at the
17601 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17603 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17604 RecordInterface instead.
17606 * cs-parser.jay: Updated to reflect changes above.
17608 * decl.cs (Definition): Keep track of the TypeBuilder type that
17609 represents this type here. Not sure we will use it in the long
17610 run, but wont hurt for now.
17612 * driver.cs: Smaller changes to accomodate the new code.
17614 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17617 * rootcontext.cs (CreateInterface): New method, used to create
17618 the System.TypeBuilder type for interfaces.
17619 (ResolveInterfaces): new entry point to resolve the interface
17621 (CodeGen): Property, used to keep track of the code generator.
17623 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17625 * cs-parser.jay: Add a second production for delegate_declaration
17628 (enum_body): Put an opt_comma here instead of putting it on
17629 enum_body or enum_member_declarations so we can handle trailing
17630 commas on enumeration members. Gets rid of a shift/reduce.
17632 (type_list): Need a COMMA in the middle.
17634 (indexer_declaration): Tell tokenizer to recognize get/set
17636 * Remove old targets.
17638 * Re-add the parser target.
17640 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17642 * cs-parser.jay: Add precendence rules for a number of operators
17643 ot reduce the number of shift/reduce conflicts in the grammar.
17645 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17647 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17650 Get rid of old crufty code.
17652 * rootcontext.cs: Use this to keep track of the parsed
17653 representation and the defined types available to the program.
17655 * gen-treedump.cs: adjust for new convention.
17657 * type.cs: Split out the type manager, and the assembly builder
17660 * typemanager.cs: the type manager will live here now.
17662 * cil-codegen.cs: And the code generator here.
17664 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17666 * makefile: Fixed up for easy making.
17668 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17670 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17673 (unary_expression): Expand pre_increment_expression and
17674 post_decrement_expression to reduce a shift/reduce.
17676 2001-07-11 Simon Cozens
17678 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17680 Improve allow_keyword_as_indent name.
17682 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17684 * Adjustments for Beta2.
17686 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17688 * decl.cs: Added `Define' abstract method.
17689 (InTransit): new property, used to catch recursive definitions.
17691 * interface.cs: Implement `Define'.
17693 * modifiers.cs: Map Modifiers.constants to
17694 System.Reflection.TypeAttribute flags.
17696 * class.cs: Keep track of types and user-defined types.
17697 (BuilderInit): New method for creating an assembly
17698 (ResolveType): New function to launch the resolution process, only
17699 used by interfaces for now.
17701 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17702 that are inserted into the name space.
17704 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17706 * ARGH. I have screwed up my tree so many times due to the use of
17707 rsync rather than using CVS. Going to fix this at once.
17709 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17712 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17714 * Experiment successful: Use System.Type rather that our own
17717 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17719 * cs-parser.jay: Removed nsAliases from here.
17721 Use new namespaces, handle `using XXX;'
17723 * namespace.cs: Reimplemented namespace handling, use a recursive
17724 definition of the class. Now we can keep track of using clauses
17725 and catch invalid using clauses.
17727 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17729 * gen-treedump.cs: Adapted for all the renaming.
17731 * expression.cs (Expression): this class now has a Type property
17732 which returns an expression Type.
17734 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17735 `Type', as this has a different meaning now in the base
17737 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17739 * interface.cs, class.cs: Removed from all the sources the
17740 references to signature computation, as we can not do method
17741 signature computation during the parsing time, as we are not
17742 trying to solve at that point distinguishing:
17746 void a (NS.Blah x) {}
17749 Which depending on the context might be valid or not, as we do not
17750 know if Blah is the same thing as NS.Blah at that point.
17752 * Redid everything so the code uses TypeRefs now instead of
17753 Types. TypeRefs are just temporary type placeholders, that need
17754 to be resolved. They initially have a pointer to a string and the
17755 current scope in which they are used. This is used later by the
17756 compiler to resolve the reference to an actual Type.
17758 * DeclSpace is no longer a CIR.Type, and neither are
17759 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17760 are all DeclSpaces, but no Types.
17762 * type.cs (TypeRefManager): This implements the TypeRef manager,
17763 which keeps track of all the types that need to be resolved after
17764 the parsing has finished.
17766 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17768 * ARGH. We are going to have to store `foreach' as a class rather
17769 than resolving it, as we need to verify error 1579 after name
17770 resolution. *OR* we could keep a flag that says `This request to
17771 IEnumerator comes from a foreach statement' which we can then use
17772 to generate the error.
17774 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17776 * class.cs (TypeContainer.AddMethod): we now add methods to the
17777 MethodGroup instead of the method hashtable.
17779 * expression.cs: Add MethodGroup abstraction, which gets us one
17780 step closer to the specification in the way we handle method
17783 * cs-parser.jay (primary_expression): qualified_identifier now
17784 tried to match up an identifier to a local variable reference or
17785 to a parameter reference.
17787 current_local_parameters is now a parser global variable that
17788 points to the current parameters for the block, used during name
17791 (property_declaration): Now creates an implicit `value' argument to
17794 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17796 * parameter.cs: Do not use `param' arguments as part of the
17797 signature, per the spec.
17799 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17801 * decl.cs: Base class for classes, structs and interfaces. This
17802 is the "Declaration Space"
17804 * cs-parser.jay: Use CheckDef for checking declaration errors
17805 instead of having one on each function.
17807 * class.cs: Factor out some code for handling error handling in
17808 accordance to the "Declarations" section in the "Basic Concepts"
17809 chapter in the ECMA C# spec.
17811 * interface.cs: Make all interface member classes derive from
17812 InterfaceMemberBase.
17814 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17816 * Many things: all interfaces are parsed and generated in
17817 gen-treedump. Support for member variables, constructors,
17818 destructors, properties, constants is there.
17820 Beginning of the IL backend, but very little done, just there for
17823 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17825 * cs-parser.jay: Fix labeled statement.
17827 * cs-tokenizer.cs (escape): Escape " and ' always.
17828 ref_line, ref_name: keep track of the line/filename as instructed
17829 by #line by the compiler.
17832 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17834 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17835 to match the values in System.CodeDOM.
17837 Divid renamed to Divide.
17839 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17841 (Statements.set): remove.
17843 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17846 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17847 falseStatements always have valid values.
17849 * cs-parser.jay: Use System.CodeDOM now.