1 2008-01-14 Marek Safar <marek.safar@gmail.com>
3 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
4 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5 statement.cs: The first expression tree implementation drop, mostly
8 2008-01-14 Marek Safar <marek.safar@gmail.com>
10 * ecore.cs (IsNestedChild): Refactored.
12 2008-01-11 Marek Safar <marek.safar@gmail.com>
14 * lambda.cs: Don't use a cast on unknown expression statement.
16 2008-01-10 Geoff Norton <gnorton@novell.com>
18 * cs-tokenizer.cs: One more token to distinguish between method and lambda
21 2008-01-09 Marek Safar <marek.safar@gmail.com>
23 * doc.cs: Report better /doc crash details.
25 2008-01-09 Marek Safar <marek.safar@gmail.com>
28 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
30 2008-01-08 Marek Safar <marek.safar@gmail.com>
33 * ecore.cs, expression.cs: Do `this' access checking in all member access
36 2008-01-08 Marek Safar <marek.safar@gmail.com>
38 * rootcontext.cs, driver.cs: Switch to linq mode by default.
40 * report.cs: Reset message stacks.
42 2008-01-08 Marek Safar <marek.safar@gmail.com>
44 * generic.cs (InferInPhases): Correctly calculate params position.
46 2008-01-08 Marek Safar <marek.safar@gmail.com>
48 * cs-tokenizer.cs: No need to parse full string when parsing lambda
51 2008-01-07 Marek Safar <marek.safar@gmail.com>
53 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
55 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
57 * driver.cs: Updated --help option.
59 2008-01-07 Marek Safar <marek.safar@gmail.com>
61 * generic.cs (InferParamsTypeArguments): Removed.
62 (InferInPhases): Add params type inference.
63 (LowerBoundInference): Fixed scoring mechanism.
65 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
67 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
69 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
70 byte array for unsigned "baked" assemblies.
72 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
74 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
75 array for assemblies that are not strongnamed.
77 2008-01-04 Marek Safar <marek.safar@gmail.com>
80 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
81 declaring type for nested generic types.
83 2008-01-04 Marek Safar <marek.safar@gmail.com>
85 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
88 2008-01-03 Marek Safar <marek.safar@gmail.com>
91 * expression.cs (Binary.ResolveOperator): Allow equality operators between
92 null and structs only when equality and inequality operators are defined
93 either as an user-operators or predefined operators.
95 2008-01-03 Marek Safar <marek.safar@gmail.com>
98 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
100 2008-01-03 Marek Safar <marek.safar@gmail.com>
102 A fix for bug #351257
103 * cs-tokenizer.cs: Advance line number for '\r' correctly.
105 2008-01-03 Marek Safar <marek.safar@gmail.com>
107 A fix for bug #351157
108 * class.cs (Using): Fixed yet another broken cloning.
110 (Block): Put back more sensible default value for statements.
112 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
114 * codegen.cs: Allow AssemblyVersion with only major version component.
117 2007-12-29 Marek Safar <marek.safar@gmail.com>
119 A fix for bug #324654
120 * class.cs: Use FullName property as member name.
122 2007-12-28 Marek Safar <marek.safar@gmail.com>
124 A fix for bug #342117
125 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
126 constructor constraint.
128 2007-12-28 Marek Safar <marek.safar@gmail.com>
130 A fix for bug #338273
131 * class.cs (ProbertyBase): Access modifier checks are required for overrides
134 2007-12-28 Marek Safar <marek.safar@gmail.com>
136 A fix for bug #350839
137 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
139 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
141 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
144 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
146 * statement.cs: Changed some Hashtables to use HybridDictionaries
147 instead. It was observed that some HashTables only contained a few
148 items in the vast majority of cases. Since HybridDictionary is
149 more efficient on small sets (<10 elements), "known_variables"
150 from class ExplicitBlock as well as "labels" and "constants " from
151 class Block were changed to HybridDictionaries.
153 Atsai results: (56216kb->54987kb)
155 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
158 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
160 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
163 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
165 * expression.cs: foreach loop to for loop, saved on allocation of
166 enumerator (59333kb->59141kb)
168 * statement.cs. Changed foreach loops to for loops, saved on
169 allocation of enumerator (59141kb->59006kb)
171 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
172 when constructed with no specified capacity. This was causing a
173 few ArrayLists to allocate more memory than they would potentially
174 need in the Block class and MemberCache class. Setting the
175 ArrayLists to construct with a capacity of 1 saves some
176 memory. (56216kb->55585kb)
178 2007-12-27 Marek Safar <marek.safar@gmail.com>
180 A fix for bug #347189 (2nd issue)
181 * expression.cs (MemberAccess): Nested type can be found in base non-generic
184 2007-12-27 Miguel de Icaza <miguel@novell.com>
186 * report.cs: Do not use colors if stdout and stderr are not a
189 2007-12-27 Marek Safar <marek.safar@gmail.com>
191 A fix for bug #346998
192 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
195 2007-12-27 Marek Safar <marek.safar@gmail.com>
197 A fix for bug #343465
198 * class.cs: Explicit method name for nested types uses dots only.
200 2007-12-27 Marek Safar <marek.safar@gmail.com>
202 A fix for bug #343707
203 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
205 2007-12-27 Marek Safar <marek.safar@gmail.com>
207 * ecore.cs: Report type inference errors only when arguments count matches
210 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
212 * expression.cs, report.cs: New warning.
214 * typemanager.cs: Catch anonymous method type too.
216 2007-12-23 Marek Safar <marek.safar@gmail.com>
218 A fix for bug #346379
219 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
221 2007-12-23 Marek Safar <marek.safar@gmail.com>
223 A fix for bug #347359
224 * expression.cs (Invocation): Don't resolve already resolved expression.
226 2007-12-23 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #347189
229 * class.cs (FixedField): Use non-dependent code only in the define phase.
231 2007-12-23 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #348076
234 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
236 2007-12-22 Marek Safar <marek.safar@gmail.com>
238 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
239 discovered extension methods.
241 2007-12-22 Marek Safar <marek.safar@gmail.com>
243 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
246 2007-12-21 Miguel de Icaza <miguel@novell.com>
248 * report.cs (ErrorMessage): Add support for using colors on
249 terminals that support it.
251 2007-12-21 Marek Safar <marek.safar@gmail.com>
253 * ecore.cs: Use information about expanded params for error reporting.
255 2007-12-21 Marek Safar <marek.safar@gmail.com>
257 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
258 and logic for params overloads.
260 2007-12-15 Miguel de Icaza <miguel@novell.com>
262 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
263 as this is also created from the parser. Fixes #349034
265 2007-12-12 Miguel de Icaza <miguel@novell.com>
267 * statement.cs (Throw.CloneTo): it is valid to have empty
268 expressions for throw.
270 2007-12-03 Marek Safar <marek.safar@gmail.com>
272 * cs-parser.jay: Set delegate constraint parsing region correctly.
274 2007-12-03 Marek Safar <marek.safar@gmail.com>
276 A fix for bug #345467
277 * typemanager.cs (IsEqual): Compare generic parameters position only.
279 2007-11-28 Marek Safar <marek.safar@gmail.com>
281 * expression.cs (BaseAccess): Type arguments can be null.
283 2007-11-27 Raja R Harinath <harinath@gmail.com>
285 * statement.cs (Block.Resolve): Ensure flow-branching tree is
286 consistent even when an error has occured.
287 (Switch.Resolve): Likewise.
289 2007-11-22 Marek Safar <marek.safar@gmail.com>
291 A fix for bug #334505
292 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
295 2007-11-22 Marek Safar <marek.safar@gmail.com>
297 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
298 refactorings required to resolve extension methods correctly when mixing
299 generics and non-generics members.
301 2007-11-20 Marek Safar <marek.safar@gmail.com>
303 A fix for bug #342584
304 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
307 2007-11-19 Marek Safar <marek.safar@gmail.com>
309 A fix for bug #342512
310 * delegate.cs: Use delegate argument expression when is available. Don't
311 emit virtual call when class is sealed.
313 2007-11-16 Marek Safar <marek.safar@gmail.com>
315 A fix for bug #325423
316 * assign.cs (FieldInitializer): Use resolved expression for emit.
318 * class.cs: Print less confusing error message.
320 2007-11-16 Marek Safar <marek.safar@gmail.com>
322 * cs-tokenizer.cs: Removed GMCS ifdefs.
324 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
327 * cs-parser.jay: Disabled nullable check.
329 * generic-mcs: Copied more generic stuff.
331 2007-11-16 Marek Safar <marek.safar@gmail.com>
333 * gcs-parser.jay: Merged to cs-parser.jay.
335 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
336 * *.csproj, *.sources: Updated to use only jay parser file.
338 2007-11-16 Marek Safar <marek.safar@gmail.com>
340 * gcs-parser.jay: Added nullable and default expression feature checks.
342 2007-11-16 Marek Safar <marek.safar@gmail.com>
344 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
345 it fixes many TODOs and hidden bugs.
347 * expression: Removed duplicate error check.
349 2007-11-15 Marek Safar <marek.safar@gmail.com>
351 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
352 implicitly type local variable only when it is used in a declaration.
354 2007-11-15 Marek Safar <marek.safar@gmail.com>
356 * attribute.cs: Use CS0612 for empty strings.
358 2007-11-14 Marek Safar <marek.safar@gmail.com>
360 * lambda.cs, statement.cs: Contextual return may act as a statement.
362 2007-11-14 Marek Safar <marek.safar@gmail.com>
364 A fix for a regression cause by #324222
365 * class.cs: Don't report unused even when it implements an interface.
367 2007-11-13 Marek Safar <marek.safar@gmail.com>
369 A fix for bug #341205
370 * ecore.cs, expression.cs: Method group expression cannot do static
371 method access with an instance reference check before overloading takes
374 2007-11-13 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #325359
377 * class.cs: Use predictable name for automatically generated property.
379 2007-11-12 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #324996
382 * expression.cs (Is): Handle case where D is nullable and T is not
385 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
387 2007-11-12 Marek Safar <marek.safar@gmail.com>
389 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
390 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
391 Flush small error reporting changes.
393 2007-11-09 Marek Safar <marek.safar@gmail.com>
395 A fix for bug #324996
396 * expression.cs: Rewrote Is expression implementation to work with
397 generics, nullable types, anonymous method. A const result expression
398 uses existing infrastructure instead of custom not fully-featured one.
400 2007-11-08 Marek Safar <marek.safar@gmail.com>
402 A fix for bug #340202
403 * class.cs: Consider generics for volatile field.
405 2007-11-08 Marek Safar <marek.safar@gmail.com>
407 A fix for bug #335594
408 * expression.cs: Use conversion rules when handling string addition.
410 2007-11-07 Marek Safar <marek.safar@gmail.com>
412 A fix for bug #336651
413 * expression.cs: Fixed a crash when probing is on.
415 2007-11-07 Marek Safar <marek.safar@gmail.com>
417 A fix for bug #324242
418 * covert.cs: Added a conversion from any nullable-type with an
419 underlying enum-type to the type System.Enum.
421 2007-11-07 Marek Safar <marek.safar@gmail.com>
423 A fix for bug #324222
424 * class.cs: Report all non-used event fields.
426 2007-11-07 Marek Safar <marek.safar@gmail.com>
428 A fix for bug #325161
429 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
430 qualifier for generic types.
432 2007-11-07 Marek Safar <marek.safar@gmail.com>
434 A fix for bug #322971
435 * expression.cs, ecore.cs: Added intermediate result value check for
438 2007-11-07 Marek Safar <marek.safar@gmail.com>
440 A fix for bug #324754
441 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
442 when it was requested.
444 2007-11-07 Marek Safar <marek.safar@gmail.com>
446 A fix for bug #325101
447 * expression.cs: Do type not value comparison for `is' expression.
449 2007-11-07 Marek Safar <marek.safar@gmail.com>
451 A fix for bug #320236
452 * convert.cs: Don't apply user conversion on underlying target type.
454 2007-11-06 Marek Safar <marek.safar@gmail.com>
456 * expression.cs: Don't use unresolved expression for error reporting.
458 2007-11-06 Marek Safar <marek.safar@gmail.com>
460 A fix for bugs #337712, #324490
461 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
462 overloading resolution too.
464 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
465 the process consistent and more robust.
467 * expression.cs, linq.cs, report.cs: Update.
469 2007-11-02 Marek Safar <marek.safar@gmail.com>
471 A fix for bug #332909
472 * attribute.cs: Resolve attributes in correct context using error
475 * rootcontext.cs: Define Obsolete attribute members as core members.
477 2007-11-02 Marek Safar <marek.safar@gmail.com>
479 * statement.cs: Removed unused methods.
481 2007-10-31 Wade Berrier <wberrier@novell.com>
483 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
484 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
487 2007-10-31 Marek Safar <marek.safar@gmail.com>
489 A fix for bug #338102
490 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
491 methods registered as non-generics.
493 2007-10-31 Marek Safar <marek.safar@gmail.com>
495 A fix for bugs #337712, #324490
496 * delegate.cs: Delegate covariance and contravariance is not allowed for
499 2007-10-31 Marek Safar <marek.safar@gmail.com>
501 A fix for bug #337719
502 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
505 2007-10-30 Marek Safar <marek.safar@gmail.com>
507 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
509 2007-10-29 Marek Safar <marek.safar@gmail.com>
511 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
514 2007-10-29 Raja R Harinath <rharinath@novell.com>
516 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
518 2007-10-29 Marek Safar <marek.safar@gmail.com>
520 A fix for bug #334652
521 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
522 extension methods when we have not found the best candidate in normal
525 2007-10-27 Marek Safar <marek.safar@gmail.com>
527 * AssemblyInfo.cs: Keep up-to-date.
529 2007-10-27 Marek Safar <marek.safar@gmail.com>
531 * Makefile: Fixed generics compiler name.
533 2007-10-27 Marek Safar <marek.safar@gmail.com>
535 * lambda.test: removed, lambda parsing is done differently.
537 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
539 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
541 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
543 2007-10-27 Marek Safar <marek.safar@gmail.com>
545 * Makefile, *.sources : All C# compilers are in mcs folder.
547 * *.cs: Use existing 2_1 define for smcs.
549 2007-10-26 Marek Safar <marek.safar@gmail.com>
551 A fix for bug #335847
552 * assign.cs, expression.cs: Couple of changes to avoid creating a
553 temporary variable for each object initializer assignment statement. It
554 simplifies struct initialization too, otherwise two temporary variables
556 Implemented optimization of redundant default element initializers.
558 2007-10-25 Marek Safar <marek.safar@gmail.com>
560 A fix for bug #336766
561 * expression.cs (Class.CheckBase): Use generic name when method is
564 2007-10-25 Marek Safar <marek.safar@gmail.com>
566 A fix for bug #334737
567 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
568 variable and not variable argument for prepared copies.
570 2007-10-24 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #325110
573 * class.cs, expression.cs, attribute.cs: Use open generic method when
574 checking conditional attribute.
576 2007-10-24 Marek Safar <marek.safar@gmail.com>
578 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
579 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
580 FeatureIsNotAvailable.
582 2007-10-24 Marek Safar <marek.safar@gmail.com>
584 ** C# 3.0 Partial methods
586 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
587 methods support. Because of member cache issue with generics only
588 non-generics partial methods are fully supported.
590 2007-10-23 Marek Safar <marek.safar@gmail.com>
592 * class.cs, decl.cs: Rewrote member overloads check to cope with
593 generics and to use member cache for member checking. It also improves
594 performance and fixes remaining overloads issues.
596 2007-10-20 Marek Safar <marek.safar@gmail.com>
598 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
599 roottypes.cs, typemanager.cs:
601 A member cache creation logic changed to add members immediately and
602 not rely on fallback. The member cache is now only prefered way
603 how to access and find type declaration members. It saves 5 MB of memory
604 during MWF compilation and makes code ready for more optimizations and
605 clean-ups, it's also a pre-requirement for partial methods.
607 2007-10-18 Raja R Harinath <harinath@gmail.com>
609 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
610 handling for generic parameters.
612 2007-10-15 Marek Safar <marek.safar@gmail.com>
614 * class.cs (FixedField): Removed redundant volatile check.
616 2007-10-15 Marek Safar <marek.safar@gmail.com>
618 * class.cs, decl.cs: Fixed overload members verification to do only one
619 check per possible collision.
621 2007-10-13 Marek Safar <marek.safar@gmail.com>
623 A fix for bug #325478
624 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
625 and create only one disposable flags container.
627 2007-10-12 Marek Safar <marek.safar@gmail.com>
629 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
630 * statement.cs (Fixed): Fixed variables cloning.
632 2007-10-12 Marek Safar <marek.safar@gmail.com>
634 A fix for bug #333342
635 * class.cs (EventField): Don't mark value type event as synchronized.
637 2007-10-12 Marek Safar <marek.safar@gmail.com>
639 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
640 inference to identify best candidate method correctly.
641 (ProperyExpr): A range variable is read only and cannot be modified.
643 2007-10-11 Marek Safar <marek.safar@gmail.com>
645 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
646 logic to identify best candidate method correctly.
648 2007-10-11 Marek Safar <marek.safar@gmail.com>
650 * location.cs (Equals, GetHashCode): Removed.
652 2007-10-11 Marek Safar <marek.safar@gmail.com>
654 * report.cs: Implemented message recorder. It is used mainly for lambda
655 expressions to capture otherwise swallowed error messages.
657 * anonymous.cs, lambda.cs.cs: Do full parameters check.
659 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
661 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
663 * expression.cs (MemberAccess): Always report lookup failure.
665 * location.cs: Implemented Equals, GetHashCode.
667 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
669 2007-10-10 Jb Evain <jbevain@novell.com>
671 * codegen.cs: re-enable assembly version check.
673 2007-10-09 Marek Safar <marek.safar@gmail.com>
675 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
678 * namespace.cs (UsingAlias): Do correct version check.
680 2007-10-08 Marek Safar <marek.safar@gmail.com>
682 * expresison.cs, ecore.cs: Issue extension method error message when
685 * rootcontext.cs: Added ISO_2 compiler mode option.
687 2007-10-08 Marek Safar <marek.safar@gmail.com>
689 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
692 2007-10-08 Marek Safar <marek.safar@gmail.com>
694 * attribute.cs (GetString, GetBoolean): Work with both literal and
697 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
698 Moved method overload specific methods to MethodGroupExpr.
700 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
701 it should be less memory consuming.
703 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
705 * codegen.cs: remove the assembly version check until the buildbot is
708 2007-10-07 Jb Evain <jbevain@novell.com>
710 * attribute.cs (Attribute.GetString): if the value
711 expression is a StringConstant, return its string value.
713 2007-10-07 Jb Evain <jbevain@novell.com>
715 * typemanager.cs: add `assembly_version_attribute_type`.
716 * codegen.cs: on attribute emission, check that the
717 AssemblyVersionAttribute doesn't overflow.
719 2007-10-05 Marek Safar <marek.safar@gmail.com>
721 A fix for bug #324677
722 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
723 parent container of a scope container with currently resolved one.
725 2007-10-05 Marek Safar <marek.safar@gmail.com>
727 A fix for bug #325534
728 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
731 2007-10-05 Marek Safar <marek.safar@gmail.com>
733 A fix for bug #327504
734 * class.cs (Operator.Define): Refactored implicit and explicit user
735 operator conversion rules.
737 2007-10-05 Marek Safar <marek.safar@gmail.com>
739 A fix for bug #327520
740 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
742 2007-10-04 Marek Safar <marek.safar@gmail.com>
744 A fix for bug #328022
745 * class.cs (MethodData.Define): Use correct method to check whether
746 a method implementents an accessor.
748 2007-10-04 Marek Safar <marek.safar@gmail.com>
750 A fix for bug #330069
751 * statement.cs (Fixed.Resolve): Read the first array element only when
752 an array is instantiated.
754 2007-10-04 Marek Safar <marek.safar@gmail.com>
756 * expression.cs, assign.cs, generics.cs: Print correct operator when
757 compound assignment is used.
759 2007-10-04 Marek Safar <marek.safar@gmail.com>
761 A fix for bug #325841
762 * expression.cs (ArrayAccess): Use full argument cloning only for
763 string compound concatenation.
765 2007-10-03 Marek Safar <marek.safar@gmail.com>
767 A fix for bug #328774
768 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
770 (PropertyExpr.EmitAssign): Fixed string concatenation compound
773 2007-10-03 Raja R Harinath <rharinath@novell.com>
776 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
777 Event accessibility checks here. Remove some bogus code that
778 accidently made GenericMethods work.
779 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
781 2007-09-25 Marek Safar <marek.safar@gmail.com>
783 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
785 * statement.cs (Block): Refactored AddVariable to allow error handling
788 * generic.cs: New stub.
790 2007-09-23 Marek Safar <marek.safar@gmail.com>
792 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
795 2007-09-17 Marek Safar <marek.safar@gmail.com>
797 * class.cs: Use partial container to record whether any partial part
798 contains static field initializer and therefore default contructor has
801 2007-09-14 Marek Safar <marek.safar@gmail.com>
803 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
804 mono-list when only one of two partial parts has defined accessibility
807 2007-09-14 Marek Safar <marek.safar@gmail.com>
811 * class.cs (TypeContainer): Set correct resolve context for all field
814 2007-09-13 Marek Safar <marek.safar@gmail.com>
816 * assign.cs: Fixed a crash when field is resolved twice with an error.
818 * codegen.cs: Changed InFieldInitializer to be flag.
820 * anonymous.cs, ecore.cs, expression.cs: Update after
821 IsInFieldInitializer rename.
823 * const.cs: Removed unused parameter.
825 * class.cs: Changed the way how we resolve and emit field initializers.
826 The field initilizers have to have access to contructor block to emit
827 compiler generated code.
829 2007-09-13 Marek Safar <marek.safar@gmail.com>
831 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
832 generics use TypeContainer instead.
834 2007-09-12 Marek Safar <marek.safar@gmail.com>
836 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
838 * lambda.cs (ResolveParameters): Use more powerful
839 InflateGenericArgument.
841 * parameters.cs: Better exception message.
843 2007-09-10 Marek Safar <marek.safar@gmail.com>
845 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
846 correct expression block type.
848 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
850 * expression.cs (Invocation): Extracted method group resolve to
853 2007-09-07 Marek Safar <marek.safar@gmail.com>
855 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
856 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
858 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
859 generic extension methods.
861 2007-09-06 Marek Safar <marek.safar@gmail.com>
863 A fix for bug #82676 (Do I get it right now?)
864 * convert.cs (Binary.ResolveOperator): An interface is converted to the
865 object before a standard conversion is applied.
867 2007-09-06 Marek Safar <marek.safar@gmail.com>
869 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
872 2007-09-05 Marek Safar <marek.safar@gmail.com>
875 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
876 non-generic interface types.
878 2007-09-05 Marek Safar <marek.safar@gmail.com>
881 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
883 2007-09-05 Marek Safar <marek.safar@gmail.com>
886 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
887 modifier for container based methods.
889 2007-09-05 Marek Safar <marek.safar@gmail.com>
892 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
893 any interface-type T means to any of interface type T.
895 2007-09-04 Marek Safar <marek.safar@gmail.com>
897 * namespace.cs: We have 2 versions of System.Core assembly.
899 2007-09-04 Marek Safar <marek.safar@gmail.com>
902 * class.cs (Class.GetClassBases): Compare types and not expressions.
904 2007-09-04 Marek Safar <marek.safar@gmail.com>
907 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
908 actually never worked before.
909 (IndexerAccess): Emit prepared arguments before they are modified.
911 2007-09-04 Marek Safar <marek.safar@gmail.com>
914 * assign.cs: Revert wrong fix.
916 * expression.cs (VariableReference.EmitAssign): Handle ref reference
918 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
919 Instead of ldelema/stdind we have to use temporary variables to handle
920 cases like String.Concat (params string[]).
922 2007-08-31 Marek Safar <marek.safar@gmail.com>
924 * class.cs: EmitAttributes to Emit rename.
926 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
928 (MemberCore.HasClsCompliantAttribute): Don't depend on
929 GetClsCompliantAttributeValue execution.
931 2007-08-31 Marek Safar <marek.safar@gmail.com>
933 * anonymous.cs: Use shorter type prefix.
935 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
938 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
939 variables when probing is on.
941 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
942 unresolved variables.
943 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
944 handle transparent identifiers.
946 2007-08-26 Marek Safar <marek.safar@gmail.com>
948 * attribute.cs (IsClsCompliant): Add nullable types test.
950 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
952 * doc.cs : catch other types of exception than XmlException to
953 report CS1570. Fixed bug #82565.
955 2007-08-23 Marek Safar <marek.safar@gmail.com>
957 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
958 The number of delegate parameters has to match.
959 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
962 2007-08-21 Marek Safar <marek.safar@gmail.com>
964 * anonymous.cs (AnonymousMethod): Generate private anonymous method
965 to fix problem with private arguments.
967 2007-08-20 Marek Safar <marek.safar@gmail.com>
969 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
971 * decl.cs (MemberName): Ignore generic type with no generic arguments.
973 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
974 empty. Add cloning suport.
976 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
978 2007-08-20 Marek Safar <marek.safar@gmail.com>
980 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
981 to create EmptyCast. It handles EmptyConstantCast specialization for
984 2007-08-18 Marek Safar <marek.safar@gmail.com>
986 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
987 (EmitArrayArgument): One routine for array arguments.
988 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
990 2007-08-17 Marek Safar <marek.safar@gmail.com>
992 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
994 2007-08-17 Marek Safar <marek.safar@gmail.com>
996 * anonymous.cs: MemberLookupFinal update.
998 * class.cs (ConstructorInitializer): Is expression based.
1000 * delegate.cs: MethodGroupExpr update.
1002 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1004 (Error_MemberLookupFailed): Customizable error override.
1005 (MethodGroupExpr): Keep queried type for later usage.
1006 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1009 * expression.cs: Error_MemberLookupFailed refactoring.
1010 (New.DoResolve): Resolve as much as possible.
1011 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1012 customization for invalid member types.
1014 * statement.cs: MethodGroupExpr update.
1016 2007-08-16 Marek Safar <marek.safar@gmail.com>
1018 * modifier.cs (Check): Check all modifiers and not only accessibility
1021 2007-08-16 Marek Safar <marek.safar@gmail.com>
1023 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1024 type and not an expression.
1026 2007-08-16 Marek Safar <marek.safar@gmail.com>
1028 * statement.cs (Catch.Clone): Type and variable can be null.
1030 2007-08-16 Marek Safar <marek.safar@gmail.com>
1032 A fix for bug #81979
1033 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1034 I am really not sure whether this is the best fix.
1036 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1039 2007-08-14 Marek Safar <marek.safar@gmail.com>
1041 ** C# 3.0 Object and collection initializers (major re-write)
1043 * assign.cs (DoResolve): Initializers are not assign related.
1045 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1046 used during collection or object initialization.
1048 * expression.cs (Error_InvalidArguments): Add initializers specific
1049 messages. More will come later because it requires some general
1051 (New.DoResolve): Better error handling for unsafe types.
1052 (EmptyExpressionStatement): New class.
1053 (ElementInitializer): An object initializer expression.
1054 (CollectionElementInitializer): A collection initializer expression.
1055 (CollectionOrObjectInitializers): A block of object or collection
1057 (NewInitialize): New expression with element/object initializers.
1059 * statement.cs: Reverted object/collection initializer hacks.
1061 * typemanager.cs (CSharpName): Filter __arglist type.
1063 2007-08-09 Marek Safar <marek.safar@gmail.com>
1065 ** C# 3.0 Anonymous Types (update to the latest standard)
1067 * expression.cs (Binary.ResolveOperator): Threat all null based types
1069 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1070 (AnonymousTypeParameter): Updated.
1072 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1073 (AnonymousTypeClass): New anonymous type container.
1075 * class.cs (AddField): Return operation result.
1077 * generic.cs: Another empty TypeArguments overload.
1079 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1080 are stored at top of normal hierarchy.
1082 * typemanager.cs (CSharpName): Filter anonymous types.
1084 2007-08-09 Marek Safar <marek.safar@gmail.com>
1086 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1087 as single Concat call. How could we miss that :-(
1089 2007-08-08 Marek Safar <marek.safar@gmail.com>
1091 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1093 2007-08-07 Miguel de Icaza <miguel@novell.com>
1095 * expression.cs: Fix the previous commit, the creation of the
1096 arguments array list needs also to be conditional on the arguments
1099 * class.cs: Add a little bit of help to help narrow down problems.
1101 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1102 not try to copy in that case.
1104 * driver.cs: When building SMCS, include a new different set of
1105 default assemblies here. Do this here so we can control whether
1106 to include the default assemblies with /noconfig.
1108 2007-08-03 Marek Safar <marek.safar@gmail.com>
1110 A fix for bug #81979
1111 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1114 2007-08-03 Marek Safar <marek.safar@gmail.com>
1116 A fix for bug #82300
1118 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1119 we are in probing scope.
1121 2007-08-03 Marek Safar <marek.safar@gmail.com>
1123 A fix for bug #82301
1125 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1126 (Statement.CloneTo): Clone and not map children blocks.
1128 2007-08-03 Marek Safar <marek.safar@gmail.com>
1130 A fix for bug #82299
1132 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1135 * statement.cs (Statement.CloneTo): Clone variables before statements
1136 to allow remaping of local variables.
1138 2007-08-03 Marek Safar <marek.safar@gmail.com>
1140 A fix for bug #82296
1143 * report.cs: Log crash details for future clone problems.
1145 * statement.cs (Return.Clone): Don't clone non-existent expression.
1147 2007-08-03 Raja R Harinath <harinath@gmail.com>
1149 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1150 (Class.AddBasesForPart): Move CS0537 check here from ...
1151 * cs-parser.jay (class_declaration): ... here. Move calling of
1152 'AddBasesForPart' to ...
1153 (class_bases): ... here.
1154 (struct_declaration, interface_declaration): Update to changes.
1156 2007-08-02 Marek Safar <marek.safar@gmail.com>
1158 A fix for bug #81923
1160 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1161 conversion is allowed.
1163 2007-08-02 Marek Safar <marek.safar@gmail.com>
1165 A fix for bug #81564
1167 * ecore.cs (EventExpr): Add IsBase handling.
1169 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1172 2007-08-02 Raja R Harinath <harinath@gmail.com>
1174 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1175 * cs-parser.jay: Some whitespace cleanups.
1176 (current_delegate): New.
1178 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1179 a dummy code block, and use 'type_name' instead of 'member_name'.
1180 (interface_declaration, class_declaration): Likewise.
1181 (delegate_declaration): Likewise. Rearrange slightly and use
1183 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1184 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1186 2007-08-02 Marek Safar <marek.safar@gmail.com>
1188 A fix for bug #82039
1190 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1193 * typemanager.cs (CSharpName): Split to string overload.
1195 2007-08-02 Marek Safar <marek.safar@gmail.com>
1198 * report.cs: Updated warning CS0472.
1200 2007-08-01 Marek Safar <marek.safar@gmail.com>
1202 A fix for bug #82181
1204 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1206 2007-08-01 Marek Safar <marek.safar@gmail.com>
1208 A fix for bug #82277
1209 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1211 2007-08-01 Marek Safar <marek.safar@gmail.com>
1213 ** C# 3.0 Type Inference (major bits are working)
1215 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1216 (.ImplicitStandardConversionExists): Uses compatible.
1217 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1218 (.InferReturnType): New method.
1219 (.Compatible): Refactored.
1220 (.ResolveParameters): Uses factory to create resolved parameters.
1221 (.CompatibleMethod): Add probing mode support.
1222 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1223 clearly distinguish between 2 different operations.
1224 (LambdaMethod): Moved to lambda.cs.
1225 (AnonymousMethod): Removed unused fields and methods.
1226 (AnonymousDelegate): Simplified.
1228 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1230 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1232 * delegate.cs (Delegate): New mehods to reduce code duplication.
1233 (.GetConstructor): New method.
1234 (.GetInvokeMethod): New method.
1235 (DelegateCreation): Updated.
1237 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1239 (OverloadResolve): Made probing little bit faster.
1241 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1244 * generic.cs (TypeInferenceContext): Dummy implementation.
1246 * iterators.cs: Updated after Resolve/Define rename.
1248 * lambda.cs (LambdaExpression)
1249 (.ResolveParameters): Handles both type of arguments and type inference too.
1251 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1252 (InflateTypes): Updated.
1254 * support.cs (InflateTypes): Changed signature and updated.
1256 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1257 (MemberLookup_FindMembers): More MS tricks.
1258 (GetParameterData): Ditto.
1259 (GetDelegateParameters): Uses quick path for dynamic types.
1261 2007-08-01 Marek Safar <marek.safar@gmail.com>
1263 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1266 2007-07-31 Marek Safar <marek.safar@gmail.com>
1268 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1271 2007-07-26 Jb Evain <jbevain@novell.com>
1273 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1274 which takes a boolean 'report_errors', similar to the GetMethod.
1275 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1276 in .net 2.1, do not report errors here.
1278 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1279 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1280 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1283 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1284 of the type InternalsVisibleToAttribute before the first call
1285 to CoreLookupType which is allowed to fail (third boolean parameter
1286 to true). Because, during the resolution for a type that is not
1287 immediately found, we try to check if the type is not defined in
1288 a friend assembly, and to do so, we need the
1289 InternalVisibleToAttribute.
1291 2007-07-23 Miguel de Icaza <miguel@novell.com>
1293 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1294 feature that allows structs to be compared against null and inline
1295 the result as true or false.
1297 Notice that the same code is not permitted inside a generic block
1298 of code that would do:
1300 class Foo<T> where T : struct {
1307 It is only allowed if the type of T is not bound (no where
1308 clause). In my opinion, this CSC 2 behavior is broken but people
1309 seem to be using it (IronRuby does, a few bug reports on bugzilla
1310 have it and some people have complained about it).
1312 All of the users that depend on this behavior have code that is
1315 * report.cs (Warning, Error): make these take object arguments,
1316 not strings, as that allows us to take advantage of Format.
1318 2007-07-20 William Holmes <billholmes54@gmail.com>
1320 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1321 Left member variable for the Count.
1322 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1323 MemberName.CountTypeArguments to avoid a NRE.
1325 This code is contributed under the MIT X11 license
1327 2007-07-18 Marek Safar <marek.safar@gmail.com>
1329 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1331 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1333 * doc.cs : generic method arguments are written as ``x while generic
1334 type arguments are `x. Combined with the previous change, fixed bug
1337 2007-07-18 Raja R Harinath <rharinath@novell.com>
1340 * expression.cs (Binary.ResolveOperator): When converting
1341 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1343 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1345 * doc.cs : when T: or whatever x: is specified, it does not really
1346 check the doc comment's syntax correctness. Fixed bug #82006.
1348 2007-07-18 Marek Safar <marek.safar@gmail.com>
1350 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1351 LambdaExpression better.
1353 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1355 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1357 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1358 as it can be generated.
1360 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1363 * lambda.cs (LambdaExpression): Refactored to share same code with
1364 AnonymousMethodExpression.
1366 2007-07-17 Marek Safar <marek.safar@gmail.com>
1368 * anonymous.cs (MakeName): Include host name for easier debugging.
1369 (LambdaMethod): New class for lambda spcecific stuff.
1371 * attribute.cs: Set EmitContext return type.
1373 * class.cs: Set EmitContext return type.
1375 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1376 with null/void meaning.
1378 * iterators.cs (ContainerType): Implemented.
1380 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1382 * statement.cs (Return): Updated to lambda expressions.
1383 (Block.CloneTo): Parent can be null.
1385 2007-07-13 Marek Safar <marek.safar@gmail.com>
1387 A fix for bug #81917
1388 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1390 * class.cs (FixedField): Check whether field is in unsafe scope.
1392 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1393 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1395 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1398 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1400 2007-07-13 Marek Safar <marek.safar@gmail.com>
1402 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1403 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1406 2007-07-13 Marek Safar <marek.safar@gmail.com>
1408 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1410 2007-07-13 Marek Safar <marek.safar@gmail.com>
1412 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1413 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1415 * codegen.cs(EmitContext): Add ProbingMode flag.
1417 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1419 * driver.cs: For now set both warning values.
1421 * ecore.cs (SimpleName): Name is readonly.
1422 (MethodGroup.OverloadResolve): One quick path for probing.
1424 * expression.cs (Unary): Set Oper r/o.
1425 (Binary): Set Oper r/o.
1426 (ParameterReference): Set few instance variables as r/o.
1427 (ParameterReference.DoResolveBase): Don't capture aruments when
1429 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1430 (Arglist): arguments are private.
1431 (SizeOf): type is private and r/o.
1432 (MemberAccess): arguments are private.
1434 * report.cs: Enhanced reporting on/off capabilities.
1436 * lambda.cs: Uses ec.IsInProbingMode.
1437 (ContextualReturn): Derives from return.
1439 * rootcontext.cs: For now set both warning values.
1441 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1443 (Return.Resolve): Don't die immediately.
1444 (Block.Resolve): Speed-up probing.
1445 (Block.CloneTo): Clone only child blocks.
1447 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1449 * iterators.cs: reverted Miguel's latest change (r81925) as it
1450 breaks the build in System.
1452 2007-07-13 Miguel de Icaza <miguel@novell.com>
1454 * iterators.cs (Yield.CheckContext): Check for the iterator type
1455 also here as we can call into Yield even in codepaths that are not
1457 (MethodOrOperator is the only path that was checked).
1459 In addition to the standard check, use a more specific check for
1460 constructors to report a more verbose error.
1462 2007-07-12 Miguel de Icaza <miguel@novell.com>
1464 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1465 report the warning and continue
1467 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1468 values on the stack on the call to Emit. Use EmitStatement if
1469 possible, or using Emit + Pop if not possible. Fixes #82064
1471 2007-07-12 Raja R Harinath <rharinath@novell.com>
1473 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1474 avoid try...finally in some cases.
1476 2007-07-10 Marek Safar <marek.safar@gmail.com>
1478 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1480 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1481 instead of method. Re-use standard error handling.
1482 (ConstructorInitializer.Emit): Simplified.
1484 * delegate.cs: Updated after Invocation.EmitCall change.
1486 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1487 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1488 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1489 method and don't permanently changing input arguments.
1490 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1491 is resolved it has one of the candidates is the best one which is later
1492 used to emit. Removed a few unused method.
1493 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1495 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1496 (Binary.ResolveOperator): Ditto.
1497 (ConditionalLogicalOperator.DoResolve): Ditto.
1498 (Invocation): Uses method group.
1499 (Invocation.DoResolve): Simplified.
1500 (Invocation.EmitCall): Removed useless is_static.
1501 (Invocation.Emit): Delegate to method group.
1502 (Invocation.EmitStatement): Simplified.
1503 (New): Uses method group.
1504 (MemberAccess.DoResolve): Don't destroy original expression.
1506 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1508 2007-07-04 Marek Safar <marek.safar@gmail.com>
1510 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1513 * lambda.cs: Add custom error message type.
1515 2007-07-03 Marek Safar <marek.safar@gmail.com>
1517 * lambda.cs: Simplified little bit.
1519 * parameter.cs: Introduced ImplicitLambdaParameter.
1520 (Parameters.CreateFullyResolved): New factory instead of ctor.
1524 * delegate.cs: Updated parameter creation.
1526 2007-07-03 Marek Safar <marek.safar@gmail.com>
1528 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1531 * generic.cs: Synchronized with gmcs.
1533 2007-07-03 Marek Safar <marek.safar@gmail.com>
1535 * class.cs (Indexer): Check return type as soon as possible.
1537 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1540 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1542 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1544 * parameter.cs (Parameter): Use expression type when it is available.
1546 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1547 method modifier for the first parameter only.
1549 2007-06-24 Marek Safar <marek.safar@gmail.com>
1551 A fix for bug #81938
1552 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1554 * constant.cs: Tide up an exception message.
1556 2007-06-22 Marek Safar <marek.safar@gmail.com>
1558 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1559 an uninitialized variable is used.
1561 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1563 2007-06-22 Marek Safar <marek.safar@gmail.com>
1565 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1566 not found error handling.
1568 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1570 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1571 (ArrayCreation.DoResolve): Simplified.
1572 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1573 its own resolve process.
1574 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1576 2007-06-20 Marek Safar <marek.safar@gmail.com>
1578 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1581 2007-06-20 Marek Safar <marek.safar@gmail.com>
1583 * cs-tokenizer.cs: Removed var related stuff.
1585 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1586 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1587 a type and a keyword at same time.
1589 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1592 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1593 implicitly typed arrays, more changes will follow.
1595 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1597 2007-06-19 Marek Safar <marek.safar@gmail.com>
1599 * ecore.cs (VarExpr): Removed Handled field.
1601 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1602 build-in assign functionality.
1603 (ForEach.Resolve): Removed all implicitly typed local variable code and
1605 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1606 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1608 2007-06-18 Marek Safar <marek.safar@gmail.com>
1610 * assign.cs: Removed implicitly typed local variable check.
1612 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1613 referencing implicitly typed local variable.
1614 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1617 * statement.cs (Fixed): Removed unsupported implicitly typed local
1620 2007-06-15 Marek Safar <marek.safar@gmail.com>
1622 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1624 2007-06-14 Marek Safar <marek.safar@gmail.com>
1626 A fix for bugs #81855 and #76274
1627 * attribute.cs (AttachTo): Always set owner for global attributes to
1630 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1633 * cs-parser.jay: Assembly and module attributes must precede all other
1634 elements except using clauses and extern alias declarations.
1636 2007-06-13 Marek Safar <marek.safar@gmail.com>
1638 A fix for bug #81748
1640 * expression.cs: More checks for non ISO-1 features.
1642 2007-06-12 Marek Safar <marek.safar@gmail.com>
1644 A fix for bug #81807
1645 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1646 present inside switch statement and it is required by nullable check.
1648 2007-06-12 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #81840
1651 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1652 when type matching fails.
1654 * namespace.cs: Tiny error message change.
1656 2007-06-12 Marek Safar <marek.safar@gmail.com>
1658 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1659 reporting. Added automatic property check.
1661 * class.cs: Updated after CheckAbstractAndExtern relocation.
1662 (AEventPropertyAccessor.GetSignatureForError): Customized.
1664 2007-06-11 Marek Safar <marek.safar@gmail.com>
1666 * class.cs (DefineBaseTypes): Base type can be undefined.
1668 * ecore.cs (TypeLookup): Minor refactoring.
1669 (DoResolveAsTypeStep): Removed redundant check.
1671 * namespace.cs (Lookup): Removed redundant check.
1673 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1674 ResolveAsTypeTerminal step.
1675 (BootstrapCorlib_*): Simplified.
1676 (PopulateCoreType): Core types can be now external.
1678 2007-06-07 Marek Safar <marek.safar@gmail.com>
1680 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1682 (InferTypeArguments): Infers anonymous expression type arguments.
1683 (Compatible): Split to Compatible and InferTypeArguments.
1685 * lambda.cs: Updated.
1687 2007-06-08 Marek Safar <marek.safar@gmail.com>
1689 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1691 2007-06-07 Raja R Harinath <harinath@gmail.com>
1693 Fix #80477, cs0135-2.cs, cs0135-3.cs
1694 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1695 names to the "known" variables list.
1696 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1697 parameter names are also "known".
1698 (Block.CheckError136): Remove.
1699 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1702 2007-06-07 Marek Safar <marek.safar@gmail.com>
1704 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1706 2007-06-06 Marek Safar <marek.safar@gmail.com>
1708 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1709 internal error not an user error.
1711 * expression.cs (IsApplicable): Refactored to make debugging easier.
1713 * support.cs: More tricks for non-mono runtimes.
1715 * typemanager.cs (CoreLookupType): Made public.
1716 (InitSystemCore): All linq specific stuff moved to linq.cs
1718 2007-06-05 Marek Safar <marek.safar@gmail.com>
1720 * typemanager.cs (CSharpSignature): One more missing build-in types
1722 More tricks for non-mono runtime.
1724 2007-06-05 Raja R Harinath <harinath@gmail.com>
1726 * statement.cs (Block.CheckError136_InParents): Remove.
1727 (Block.AddVariable): Use GetParameterInfo instead.
1728 (ToplevelBlock.ProcessArguments): Likewise.
1730 2007-06-04 Raja R Harinath <rharinath@novell.com>
1732 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1734 (ToplevelBlock.GetParameterInfo): Split out of ...
1735 (ToplevelBlock.GetParameterRefernce): ... this.
1736 (ToplevelBlock.ParameterMap): Remove.
1737 * expression.cs (ParameterReference): Update to use
1738 ToplevelParameterInfo.
1740 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
1743 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
1744 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
1746 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
1747 (ToplevelBlock.ProcessParameters) ... here.
1748 (ToplevelBlock..ctor): Invoke it.
1750 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
1753 * statement.cs (IKnownVariable): New interface.
1754 (LocalInfo): Implement it.
1755 (ToplevelParameterInfo): New class.
1756 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
1757 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
1758 GetKnownVariableInfo.
1760 2007-06-03 Raja R Harinath <harinath@gmail.com>
1762 Partly speed up CS0136 error checks.
1763 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
1764 'recurse' parameter.
1765 (Block.DoCheckError136): Only check errors in parameters. Move
1766 local variable checks ...
1767 (Block.AddVariable): ... here, and ...
1768 (ToplevelBlock.ResolveMeta): ... here.
1770 2007-06-02 Raja R Harinath <harinath@gmail.com>
1772 * statement.cs (Block.IsChildOf): Remove.
1774 * statement.cs (Statement.Clone): Move special case code ...
1775 (Block.CloneTo): ... here.
1777 2007-05-29 Raja R Harinath <rharinath@novell.com>
1779 * statement.cs (ToplevelBlock.container): Remove field. It's
1780 redundant with 'Parent'.
1781 (ToplevelBlock.ContainerBlock): Remove accessor.
1782 (ToplevelBlock..ctor): Update to changes. Register anonymous
1783 child with parent here, ...
1784 * cs-parser.jay (end_anonymous): ... not here. Don't modify
1786 (start_anonymous): Don't save current_block.
1787 (top_current_block): Remove.
1789 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
1790 (Block.Resolve): Update to changes.
1791 (Block..ctor): Move setting of "correct" 'Toplevel'
1792 and 'Explicit' fields to ...
1793 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
1795 2007-05-27 Raja R Harinath <harinath@gmail.com>
1798 * statement.cs (Block.Implicit): Remove.
1799 (Block): Update to changes.
1800 * flowanalysis.cs: Likewise.
1802 Mildly speed up CheckInvariantMeaningInBlock
1803 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
1804 Recursively call AddKnownVariable to all enclosing blocks.
1805 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
1806 Remove recursive calls.
1807 (Block): Update to changes.
1809 New ExplicitBlock invariants
1810 * statement.cs (Block.Explicit): New field. It points to the
1811 immediately enclosing non-implicit block.
1812 (Block..ctor): Maintain the invariant.
1813 * cs-parser.jay: Take advantage of invariant.
1815 Introduce ExplicitBlock
1816 * statement.cs (ExplicitBlock): New.
1817 (ToplevelBlock): Derive from it.
1818 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
1820 (Block.Implicit): Update to changes.
1821 * cs-parser.jay: Update to changes.
1824 * codegen.cs (EmitContext.IsLastStatement): Remove.
1825 * statement.cs (Block.DoEmit): Update to changes.
1827 2007-05-25 Raja R Harinath <rharinath@novell.com>
1829 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
1830 modifying current_block directly.
1832 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
1834 * class.cs: Implemented automatic properties (C# 3.0)
1835 Thanks to Marek for the help.
1837 2007-05-23 Raja R Harinath <rharinath@novell.com>
1839 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
1840 variable as assigned, note also that all its components are
1842 (MyBitVector.SetRange): New. Function to set multiple bits to true.
1844 2007-05-19 Marek Safar <marek.safar@gmail.com>
1846 * anonymous.cs, class.cs: Emit Compiler generated attribute when
1847 member is marked as compiler generated.
1849 * decl.cs (MemberCore): Refactored ModFlags into property.
1851 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
1852 (Check): Check only accessibility modifiers.
1854 2007-05-18 Raja R Harinath <rharinath@novell.com>
1856 Track all assignable slots in one bit array
1857 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
1858 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
1859 logic from VariableMap constructor here. Use the same 'offset'
1860 variable that's later used for computing offsets of local
1862 * flowanalysis.cs (UsageVector.parameters): Remove.
1863 (UsageVector): Update to changes.
1864 (VariableMap): Remove.
1866 Avoid creating ParameterMap in every block
1867 * statement.cs (Block.ParameterMap): Move ...
1868 (ToplevelBlock.ParameterMap): ... here.
1869 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
1871 * flowanalysis.cs (FlowBranching.param_map): Remove.
1872 (FlowBranching.UsageVector): Update to changes.
1873 (FlowBranchingToplevel.CheckOutParameters): Likewise.
1875 * statement.cs (Block.CloneTo): Clone Toplevel field too.
1877 * expression.cs (ParameterReference): Distinguish between block
1878 where parameter was referenced and declared.
1880 2007-05-18 Marek Safar <marek.safar@gmail.com>
1882 * flowanalysis.cs, statement.cs: Put back improved error handling.
1884 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
1888 Imporved object and collection initialization (C# 3.0).
1890 2007-05-15 Marek Safar <marek.safar@gmail.com>
1892 A fix for bug #81380
1893 * expression.cs (Is.DoResolve): Only value types have constant `is'
1896 2007-05-15 Raja R Harinath <rharinath@novell.com>
1898 * statement.cs (ToplevelBlock.child): Remove.
1900 2007-05-15 Raja R Harinath <harinath@gmail.com>
1902 Rationalize ResolveMeta: refactoring
1903 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
1904 out constant handling code into ...
1905 (Block.DoResolveConstants): ... this.
1907 Rationalize ResolveMeta: kill local_map
1908 * statement.cs (Block.local_map, Block.LocalMap): Remove.
1909 (Block.AssignableSlots): New.
1910 (Block.ResolveMeta): Make protected. Don't create a VariableMap
1911 for locals -- move code from VariableMap here. Avoid unnecessary
1913 * flowanalysis.cs (FlowBranching.local_map): Remove.
1914 (FlowBranching..ctor): Use Block.AssignableSlots.
1915 (VariableMap): Remove unused constructors.
1917 2007-05-11 Raja R Harinath <rharinath@novell.com>
1919 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
1921 2007-05-11 Marek Safar <marek.safar@gmail.com>
1923 * typemanager.cs (IsFriendAssembly): Should not be called for building
1926 2007-05-09 Marek Safar <marek.safar@gmail.com>
1928 * literal.cs (NullConstant): Print null in all cases.
1930 * expression.cs (Binary.ResolveOperator): Implemented delegate
1931 comparison based on C# 2.0 changes.
1933 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
1935 This code is contributed under the MIT X11 license
1937 The following enables support for several C# 3.0 language features:
1939 * cs-tokenizer.cs: Added support for the "var" keyword.
1941 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
1942 Added VarExpr class to facilitate type inferencing.
1944 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
1945 to support anonymous types.
1947 * assign.cs: Added support for type inferencing and initialization.
1949 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
1951 * expression.cs: Added implicit array support to ArrayCreation.
1952 Added 5 types and 1 interface:
1954 IInitializable Implementing classes can inject initializing
1955 statements after object instantiation.
1957 Initializer Stores data for object initialization.
1959 AnonymousType An expression for anonymous types.
1961 AnonymousTypeParameter Stores data about an anonymous type's field.
1963 NewInitialize An expression for object initialization.
1965 CollectionInitialize An expression for collection initialization.
1967 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
1970 2007-05-06 Marek Safar <marek.safar@gmail.com>
1972 A fix for bug #81500
1973 * cs-tokenizer.cs: Add special handling for coalescing operator.
1975 2007-05-06 Marek Safar <marek.safar@gmail.com>
1977 A fix for bug #81529
1978 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
1979 its value from base class until it is redefined.
1981 2007-05-02 Raja R Harinath <rharinath@novell.com>
1983 Fix regression in cs0631-3.cs
1984 * cs-parser.jay (operator_declarator): Add opt_attributes to error
1985 fallback. Make error fallback catch more cases.
1987 2007-05-01 Miguel de Icaza <miguel@novell.com>
1989 * cs-parser.jay: Allow parameters in operator declarations to have
1992 2007-04-27 Miguel de Icaza <miguel@novell.com>
1994 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
1997 * lambda.cs (ContextualReturn.Resolve): An expression is valid
1998 inside the ContextualReturn, it does not have to be an
1999 ExpressionStatement.
2001 2007-04-24 Miguel de Icaza <miguel@novell.com>
2003 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2006 2007-04-23 Miguel de Icaza <miguel@novell.com>
2008 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2009 method in two methods: ResolveNoDefine and Resolve.
2011 ResolveNoDefine will stop just after ResolveTopBlock has been
2014 Resolve will then continue by creating a method and issuing the
2015 call to method.Define ().
2017 (AnonymousMethod): Split and implement the new Resolve and
2018 ResolveNoDefine as well.
2020 * lambda.cs (LambdaExpression): Split the anonymous method
2021 resolution code into a separate routine (CoreCompatibilityTest)
2022 from DoCompatibleTest.
2024 (LambdaExpression.TryBuild): New method, this method tries to
2025 build the LambdaExpression with the given set of types to be used
2026 as the types for the various parameters of the lambda expression.
2028 If the compilation succeed with the given types, the infered type
2029 of the Anonymous method is returned, otherwise null is returned.
2031 2007-04-23 Marek Safar <marek.safar@gmail.com>
2033 A fix for bug #81414
2034 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2036 2007-04-22 Miguel de Icaza <miguel@novell.com>
2038 * cs-tokenizer.cs: Change various identifiers here from the
2039 camelCasing to the recommended Linux-like style for instance
2040 variables from the Coding Guidelines.
2042 2007-04-19 Martin Baulig <martin@ximian.com>
2045 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2046 System.Enum to System.ValueType.
2048 2007-04-13 Martin Baulig <martin@ximian.com>
2050 Rewrote implicit reference conversions. We need to distinguish
2051 between implicit reference conversions (13.1.4) and implicit
2052 boxing conversions (13.1.5).
2054 According to the spec, there's an an implicit conversion
2055 "From a one-dimensional array-type S[] to IList<T> and base
2056 interfaces of this interface, provided there is an implicit
2057 reference conversion from S to T." Note that this does not
2058 include boxing conversions.
2061 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2062 (Convert.ImplicitReferenceConversion): Split into
2063 ImplicitReferenceConversionCore() and
2064 ImplicitBoxingConversionExist().
2065 (Convert.ImplicitReferenceConversionExists): Use the new
2066 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2068 2007-04-12 Martin Baulig <martin@ximian.com>
2070 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2071 `TypeManager.null_type' checks up to the top of the method.
2073 2007-04-11 Marek Safar <marek.safar@gmail.com>
2075 A fix for bug #81350
2076 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2079 2007-04-11 Martin Baulig <martin@ximian.com>
2081 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2082 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2083 to make this work for generic classes; fixes #79561.
2085 2007-04-11 Martin Baulig <martin@ximian.com>
2087 * expression.cs (As): Add support for nullable types; fixes #79371.
2089 2007-04-11 Martin Baulig <martin@ximian.com>
2091 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2092 `type.FullName' is null; fixes #80243.
2094 2007-04-11 Martin Baulig <martin@ximian.com>
2096 * expression.cs (Invocation.IsApplicable): Don't modify the method
2097 if type inference succeeded, but the method was not applicable.
2100 2007-04-10 Marek Safar <marek.safar@gmail.com>
2102 A fix for bug #81324
2103 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2104 internal and external namespaces containers.
2106 2007-04-10 Martin Baulig <martin@ximian.com>
2108 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2109 TypeManager.DropGenericMethodArguments() so we also call
2110 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2112 2007-04-10 Martin Baulig <martin@ximian.com>
2114 * iterators.cs (Iterator.CreateIterator): Don't crash if
2115 `method.ReturnType' is null. This happens if something went wrong
2116 while resolving that typ (we already reported an error in this case).
2118 2007-04-10 Martin Baulig <martin@ximian.com>
2120 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2121 generic interfaces; report the CS0144 directly.
2123 2007-04-10 Martin Baulig <martin@ximian.com>
2125 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2126 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2128 2007-04-10 Martin Baulig <martin@ximian.com>
2130 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2132 2007-04-09 Raja R Harinath <rharinath@novell.com>
2135 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2136 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2139 * statement.cs (For.Resolve): If resolution fails, use
2142 2007-04-08 Marek Safar <marek.safar@gmail.com>
2144 * anonymous.cs (MakeName): Make faster and zero-based.
2145 (VerifyExplicitParameterCompatibility): Back to mode where generic
2146 parameter is ignored.
2147 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2149 * class.cs (EmitType): Method can emit another new method.
2151 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2153 * driver.cs: Updated.
2155 * lambda.cs: Reuse predefined empty parameters.
2157 * parameter.cs: Updated
2159 * support.cs: Implemented InflateTypes.
2161 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2162 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2164 2007-04-03 Martin Baulig <martin@ximian.com>
2168 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2169 version of TypeManager.IsOverride() which also works with generic
2172 2007-04-03 Martin Baulig <martin@ximian.com>
2177 (Convert.ExplicitReferenceConversion): We need to cast when
2178 converting from IList<T> to S[].
2180 2007-04-01 Marek Safar <marek.safar@gmail.com>
2182 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2185 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2187 2007-03-31 Marek Safar <marek.safar@gmail.com>
2189 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2190 argument and return type inferring.
2192 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2193 (ReturnType): Turned to property.
2195 * statement.cs (Return): Implemented return type inferring.
2197 * support.cs (ReflectionParameters): Use local types if possible.
2199 2007-03-30 Raja R Harinath <rharinath@novell.com>
2201 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2202 (FlowBranching.UsageVector): Update to changes.
2204 Prepare to kill 'Reachability'
2205 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2206 argument of constructor.
2208 2007-03-29 Raja R Harinath <rharinath@novell.com>
2210 Prepare to kill 'Reachability'
2211 * flowanalysis.cs (UsageVector.is_unreachable): New.
2212 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2213 'reachability', and verify they're consistent.
2216 * expression.cs (New.EmitStatement): Handle type parameters here too.
2218 2007-03-29 Martin Baulig <martin@ximian.com>
2223 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2224 CompilerGeneratedClass.
2225 (ScopeInfo.EmitScopeInstance): Make this protected.
2226 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2227 `ec.CurrentAnonymousMethod.Scope == Scope'.
2229 * statement.cs (Block.ScopeInfo): Make this a property.
2231 2007-03-27 Raja R Harinath <harinath@gmail.com>
2233 Prepare to kill 'Reachability'
2234 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2235 (FlowBranching.UsageVector.Reachability): Remove property.
2236 (FlowBranching.UsageVector.IsUnreachable): New property.
2237 (FlowBranching.UsageVector.ResetBarrier): New.
2238 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2239 * codegen.cs, statement.cs: Update to changes.
2241 2007-03-27 Martin Baulig <martin@ximian.com>
2246 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2249 2007-03-26 Raja R Harinath <rharinath@novell.com>
2251 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2252 instead of TriState. Remove all mention of TriState.
2254 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2255 replaced by a boolean. Add boolean 'is_unreachable' field, check
2256 and maintain invariants.
2258 2007-03-25 Marek Safar <marek.safar@gmail.com>
2260 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2262 2007-03-25 Marek Safar <marek.safar@gmail.com>
2264 * expression.cs: Stop using obsolete 2.0 opcodes.
2266 2007-03-25 Marek Safar <marek.safar@gmail.com>
2268 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2269 one of the latests Martin's fixes.
2271 2007-03-23 Miguel de Icaza <miguel@novell.com>
2273 * expression.cs: On BigEndian systems, swap the bytes, temporary
2274 solution until we get a new bitconverter class.
2276 2007-03-23 Martin Baulig <martin@ximian.com>
2280 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2281 "Method" and "Method`1". Normally, a cache lookup is done on the
2282 "Method" form (ie. without the generic arity), but this one makes
2283 lookups on the full form work as well.
2285 2007-03-22 Raja R Harinath <rharinath@novell.com>
2287 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2290 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2292 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2293 ordered_member_list, to TypeBuilder to store members to be defined
2294 in the order they were parsed in.
2295 - ordered_explicit_member_list contains all properties indexers
2296 and methods that are defined as explicit implementation of an
2297 interface or base class.
2298 - ordered_member_list contains all properties indexers and methods
2299 that are not defined as explicit implementation of an interface
2302 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2303 functionality in these removed classes has been replaced with
2304 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2305 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2307 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2308 to CheckForDuplications inside GetMethod and SetMethod Define Method
2309 to handle method property and indexer name conflicts.
2313 All code is contributed under the MIT/X11 license.
2315 2007-03-20 Martin Baulig <martin@ximian.com>
2317 * class.cs (TypeContainer.Interfaces): Removed; they're now
2318 included in `TypeContainer.Types'.
2320 2007-03-20 Martin Baulig <martin@ximian.com>
2322 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2324 * class.cs (TypeContainer.CreateType): New public method. This is
2325 now called before DefineType() to create the TypeBuilders.
2326 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2327 has already been created by CreateType().
2328 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2329 don't resolve our base classes here; this has been moved into
2330 DefineBaseTypes(). We're now called from CreateType().
2331 (TypeContainer.DefineBaseTypes): New private method; resolve our
2332 base classes here. We're now called from DefineType().
2335 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2336 our types first to create all the TypeBuilders. After that, call
2337 TypeContainer.DefineType() on all the types which'll resolve their
2338 base classes and setup the resolve order.
2340 2007-03-20 Martin Baulig <martin@ximian.com>
2342 * class.cs (TypeContainer.Enums): Removed; they're now included in
2343 `TypeContainer.Types'.
2345 2007-03-20 Martin Baulig <martin@ximian.com>
2348 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2349 (TypeContainer.DoResolveMembers): Call DefineType() on our
2350 `compiler_generated' classes; moved here from DefineNestedTypes().
2353 (RootContext.ResolveTree): Call ResolveMembers() on all
2354 TypeContainer's in the `type_container_resolve_order'.
2356 2007-03-19 Marek Safar <marek.safar@gmail.com>
2358 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2360 2007-03-17 Marek Safar <marek.safar@gmail.com>
2362 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2363 implementation flags.
2365 2007-03-17 Marek Safar <marek.safar@gmail.com>
2367 * class.cs: More optimizations for type parameters.
2369 2007-03-15 Marek Safar <marek.safar@gmail.com>
2371 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2373 * ecore.cs, parameter.cs: More common code for both corlibs.
2375 * typemanager.cs (IsGenericMethod): Simplified.
2377 2007-03-15 Raja R Harinath <rharinath@novell.com>
2379 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2381 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2383 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2384 unconditionally. Simplify explanation.
2385 (Try.Resolve, Using.Resolve): Likewise.
2387 2007-03-15 Martin Baulig <martin@ximian.com>
2391 * decl.cs (DeclSpace): If we're a partial class, use our
2392 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2394 2007-03-15 Raja R Harinath <rharinath@novell.com>
2396 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2398 (FlowBranching.UsageVector): Update to changes.
2399 (FlowBranching.MergeSiblings): Likewise.
2400 * statement.cs: Likewise.
2402 2007-03-15 Martin Baulig <martin@ximian.com>
2407 (MemberCache): Added a special .ctor for type parameters.
2410 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2413 2007-03-09 Martin Baulig <martin@ximian.com>
2415 * enum.cs (Enum): Make this a TypeContainer.
2416 (EnumMember): Derive from `Const'.
2419 (Const.DoResolveValue): New protected virtual method; move most of
2420 the functionality of ResolveValue() here so we can override it in
2422 (Const.CreateConstantReference): Make this virtual.
2424 * class.cs (Kind): Add `Kind.Enum'.
2425 (TypeContainer.Emit): Don't emit the enums here; they're already
2426 in the `RootContext.typecontainer_resolve_order'.
2428 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2429 here; they're already in the `typecontainer_resolve_order'.
2431 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2432 TypeManager.DropGenericTypeArguments().
2435 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2436 (TypeManager.IsEnumType): Likewise.
2437 (TypeManager.EnumToUnderlying): Likewise.
2438 (TypeManager.IsEqual): Add support for enums.
2440 2007-03-12 Raja R Harinath <rharinath@novell.com>
2442 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2443 DefaultParameterValueAttribute to be undefined, say if System.dll
2446 2007-03-11 Marek Safar <marek.safar@gmail.com>
2448 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2451 2007-03-10 Marek Safar <marek.safar@gmail.com>
2453 * class.cs, parameter.cs: Unified parameters verification.
2455 2007-03-08 Martin Baulig <martin@ximian.com>
2457 * cs-parser.jay (constructor_header): Pass the location to the
2458 newly created TopLevelBlock.
2460 2007-03-07 Martin Baulig <martin@ximian.com>
2462 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2464 2007-03-06 Miguel de Icaza <miguel@novell.com>
2466 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2467 with the changes from David, fixes the build.
2469 2007-03-05 David Mitchell <dmitchell@logos.com>
2471 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2472 and its base interfaces to a one-dimensional array type S[],
2473 provided there is an implicit or explicit reference conversion
2476 2007-03-03 Marek Safar <marek.safar@gmail.com>
2478 * cs-tokenizer.cs: Implemented basic linq grammar.
2480 * driver.cs: Set linq lang version on demand.
2482 2007-02-26 Marek Safar <marek.safar@gmail.com>
2484 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2486 2007-02-25 Marek Safar <marek.safar@gmail.com>
2488 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2491 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2493 Check property and event extern attributes.
2495 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2498 2007-02-24 Marek Safar <marek.safar@gmail.com>
2500 A fix for bug #80407
2501 * ecore.cs: Don't report ambiguity error when methods have same parent.
2503 2007-02-23 Marek Safar <marek.safar@gmail.com>
2505 A fix for bug #80878
2506 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2508 2007-02-22 Marek Safar <marek.safar@gmail.com>
2510 * attribute.cs: Enable ExtensionAttribute presence test.
2512 2007-02-22 Marek Safar <marek.safar@gmail.com>
2514 * class.cs: Warn about missing GetHashCode only when Equals is override.
2516 * decl.cs: Check accessibility of type arguments.
2518 * typemanager.cs: Correctly report nullable array.
2520 2007-02-20 Marek Safar <marek.safar@gmail.com>
2522 * class.cs, report.cs: Capture more details when things go wrong.
2524 2007-02-20 Marek Safar <marek.safar@gmail.com>
2526 A fix for bug #80650
2527 * cs-parser.jay: Anonymous container starts at constructor declaration
2528 and not at block beginning because it has to be usable in constructor
2531 * statement.cs: Use context location and not block one for error reporting.
2533 2007-02-18 Marek Safar <marek.safar@gmail.com>
2535 A fix for bug #78712
2536 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2539 2007-02-18 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #80493 by Atsushi Enomoto
2542 * cs-parser.jay: Ignore invalid attribute target.
2544 2007-02-18 Marek Safar <marek.safar@gmail.com>
2546 * cs-tokenizer.cs: Ignore '\0' as white space character.
2548 2007-02-17 Miguel de Icaza <miguel@novell.com>
2550 * cs-parser.jay: Add support for lambda expressions to the mcs
2553 * lambda.cs: Only clone when we are probing, not on the final call
2554 (Compatible is the final call).
2556 * statement.cs (CloneContext): Introduce class to provide block
2557 remapping during clone.
2559 All statements Clone themselves now.
2561 (Clone): special handling for blocks, when we clone a block, we
2562 register the block inside this routine, as children of the block
2563 might trigger a lookup.
2565 * expression.cs: Add support for CloneContext in all expressions.
2567 2007-02-17 Marek Safar <marek.safar@gmail.com>
2569 A fix for bug #80493
2570 * statement.cs: Report ambiguous warning when interfaces are not related.
2572 2007-02-15 Marek Safar <marek.safar@gmail.com>
2574 C# 3.0 extension methods.
2576 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2577 cannot be used directly.
2579 * class.cs (Class.Emit): Emit extension attribute if any class method
2580 is extension method.
2581 (Method.Define): Add basic extension method validation conditions.
2582 (Method.Emit): Emit extension attribute for method.
2584 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2585 extension method exists. Currently we follow same approach as Microsoft
2586 does, emit even if a method or a class are private but this can change
2589 * cs-parser.jay: Add handling of `this' keyword in method parameters
2592 * decl.cs (DeclSpace.IsStaticClass): New property.
2593 (MemberCache.FindExtensionMethods): Looks for extension methods with
2594 defined name and extension type.
2596 * doc.cs: Updated after OverloadResolve changes.
2598 * driver.cs: Add new soft reference to System.Core.dll.
2600 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2601 (ExtensionMethodGroupExpr): Represents group of extension methods.
2603 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2604 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2605 to MethodGroupExpr and made non-static for easier customization.
2606 (Invocation.DoResolve): Add extension method lookup when no standard
2608 (MemberAccess.DoResolve): Try extension methods if no member exists.
2610 * modifiers.cs: Add METHOD_EXTENSION modifier.
2612 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2613 as well as candidate extension type.
2614 (ComputeNamespaces): When assembly constains extension methods registers
2616 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2617 extension method lookup.
2618 (Namespace.LookupExtensionMethod): Looks for extension method in this
2620 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2621 find a method which matches name and extensionType.
2623 * parameter.cs (Parameter): Add This modifer.
2624 (HasExtensionMethodModifier): New property.
2625 (Resolve): Add extension parameter check.
2626 (ModFlags): turned to property to exclude this modifier as it is not real
2628 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2630 * support.cs (ParameterData): Add ExtensionMethodType.
2631 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2633 * typemanager.cs: Add type and ctor extension attribute type.
2635 2007-02-15 Miguel de Icaza <miguel@novell.com>
2637 * report.cs (DisableErrors, EnableErrors): used to prevent error
2638 output when we are "trying" to compile various methods with
2641 * ecore.cs (Expression): Add Clone method that calls the virtual
2642 CloneTo method. The current CloneTo method in Expression throws
2643 an exception so we can track down all the places where this must
2644 be implemented (not using abstract, because that would be a lot of
2645 up-front-work before we can start testing the implementation
2648 Important: we only need Clone capabilities for expressions created
2649 by the parser, as the expressions we will be cloning are
2650 expressions in the pre-resolved state. This vastly simplifies
2653 (SimpleName): Add CloneTo that does nothing.
2654 (EmptyCast): Add CloneTo.
2656 * expression.cs (Binary): Implement CloneTo.
2657 (Invocation.IsApplicable): Store the current ec in
2658 EmitContext.TempEc and restore it on return. This is used so we
2659 do not have to sprinkle hundres of methods with an extra
2660 EmitContext, we know that the only user is the lambda expression
2661 ImplicitConversionExists code.
2663 (Argument): Add Cloning capabilities.
2664 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2665 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2666 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2667 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2668 IndexerAccess): Add Clone capability.
2670 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2672 (Argument): Add cloning capability.
2674 * assign.cs (Assign): Implement CloneTo.
2676 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2678 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2679 version by calling Convert with the EmitContext (that we are
2680 currently storing in ec, this is not great, but will do for now,
2681 to avoid passing EmitContext parameters to hundreds of functions
2682 that do not need them now).
2684 (SetExpression): Remove, it is not needed.
2686 (ContextualReturn): Implement CloneTo.
2688 * statement.cs (Statement): Implement cloning infrastructure,
2689 similar to expressions.
2691 (Block): Partial implementation of Clone for statements.
2693 (Return): Implement clone.
2695 * constant.cs (Constant.CloneTo): New method, does nothing.
2697 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2698 solution, until we decide how to exactly do this.
2700 2007-02-14 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #80493
2703 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2704 a property is override we need to use second accessor.
2706 2007-02-13 Marek Safar <marek.safar@gmail.com>
2708 A fix for bug #80418
2709 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2712 2007-02-13 Marek Safar <marek.safar@gmail.com>
2714 Another fix for bug #80749
2715 * pending.cs: Abstract class has priority over interfaces.
2717 2007-02-13 Marek Safar <marek.safar@gmail.com>
2719 Another fix for bug #80749
2720 * pending.cs: Abstract class has priority over interfaces.
2722 2007-02-13 Marek Safar <marek.safar@gmail.com>
2724 Another fix for bug #80749
2725 * pending.cs: Abstract class has priority over interfaces.
2727 2007-02-13 Marek Safar <marek.safar@gmail.com>
2729 Another fix for bug #80749
2730 * pending.cs: Abstract class has priority over interfaces.
2732 2007-02-13 Marek Safar <marek.safar@gmail.com>
2734 * class.cs Better error message.
2736 * driver.cs: Add shorter versions of -optimize option.
2738 2007-02-13 Martin Baulig <martin@ximian.com>
2740 * class.cs (Constructor.Emit): Check the return value of
2741 ec.ResolveTopBlock() and return on error.
2743 2007-02-13 Raja R Harinath <rharinath@novell.com>
2745 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
2746 message to fix error message regression.
2748 2007-02-12 Marek Safar <marek.safar@gmail.com>
2750 * delegate.cs: Delegate creation expression cannot be of Nullable type.
2752 2007-02-12 Marek Safar <marek.safar@gmail.com>
2754 A fix for bug #80749
2755 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
2756 its parent container.
2758 * class.cs (DefineFieldInitializers): Each initializer can has different
2761 * const.cs: Updated.
2763 2007-02-11 Miguel de Icaza <miguel@novell.com>
2765 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
2766 now all the heavy lifting to check that embedded statements or
2767 expressions have the right form is done in the ContextualReturn.
2769 (ContextualReturn): New class.
2771 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
2772 method that can be invoked to report 201, so we do not replicate
2775 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
2777 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
2778 treating tabs as spaces.
2780 2007-02-09 Marek Safar <marek.safar@gmail.com>
2782 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
2783 * assign.cs: Use full implicit conversion for right side check.
2785 2007-02-09 Marek Safar <marek.safar@gmail.com>
2787 * statement.cs (Switch): Switch over boolean type is not standardized.
2789 2007-02-08 Marek Safar <marek.safar@gmail.com>
2791 A fix for bug #80755
2792 * decl.cs (FindBaseEvent): Don't use method cache for events.
2794 2007-02-07 Marek Safar <marek.safar@gmail.com>
2796 * cs-parser.jay: Better syntax error handling.
2798 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
2799 instead of underlying type value.
2801 2007-02-06 Marek Safar <marek.safar@gmail.com>
2803 * driver.cs: Check define identifier before is registered.
2805 * namespace.cs: Use existing error message.
2807 * report.cs: New warning.
2809 2007-02-06 Marek Safar <marek.safar@gmail.com>
2811 A fix for bug #80742
2812 * expression.cs: Delegate Invoke method can be called directly.
2814 2007-02-06 Marek Safar <marek.safar@gmail.com>
2816 A fix for bug #80676
2817 * class.cs (IsEntryPoint): The Main method can have params modifier.
2819 2007-02-04 Miguel de Icaza <miguel@novell.com>
2821 * parameter.cs (Parameter, Parameters): Add Clone method.
2823 * anonymous.cs (Compatible): Turn method into virtual method, so
2824 LambdaExpression can implement a different behavior.
2826 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
2827 out the basic checking here, so it can be used by
2830 * lambda.cs: Introduce "Compatible" function that will do the
2833 2007-02-02 Marek Safar <marek.safar@gmail.com>
2835 * attribute.cs: Unified one error message.
2837 * class.cs (Class): Use type attributes and not properties to test static
2839 (IsEntryPoint): Don's pass local variable.
2841 * convert.cs: Removed duplicate check.
2843 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
2845 * driver.cs: Don't crash when soft reference does not exist.
2847 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
2848 (UsingEntry): Removed redundant allocation.
2850 * parameter.cs: Add fast path for type parameters.
2852 * support.cs: Don't allocate attribute when it's not used.
2854 2007-01-30 Miguel de Icaza <miguel@novell.com>
2857 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
2858 this into a virtual method, so we can override it in LambdaExpression.
2860 * driver.cs: Improve diagnostics in case of failure.
2862 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
2863 write a function that is slightly more complex and that parses:
2865 type identifier [, type identifier]* )
2867 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
2870 (canEmpty ? i >= 0 : i > 0)
2872 2007-01-30 Raja R Harinath <rharinath@novell.com>
2874 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
2875 exception on possibly valid code.
2877 2007-01-29 Raja R Harinath <rharinath@novell.com>
2879 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
2881 (parse_opt_type_arguments): Remove. It's almost the same as
2883 (parse_namespace_or_typename): Use parse_less_than.
2885 2007-01-28 Miguel de Icaza <miguel@novell.com>
2887 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
2888 this bug took a few hours to find, because the state saved and
2889 restored by PushPosition and PopPosition was ignoring the state of
2890 parse_generic_less_than.
2892 I can also now remove the handling of OP_LT and OP_GT, this solves
2895 * cs-tokenizer.cs: store the location for the ARROW token, we use
2898 (PushPosition, PopPosition): save/restore also `current_token',
2899 restore `parse_generic_less_than' (was missing).
2901 (parse_opt_type_arguments): use parse_type, not
2902 parse_namespace_or_typename to parse types.
2904 * lambda.cs: Empty new file, will eventually have the lambda
2905 expression implementation.
2907 * lambda.test: used to test the internal tokenizer.
2909 * report.cs (FeatureIsNotISO1): Rename from
2910 FeatureIsNotStandardized, because it was about the language level
2911 (1 vs 2) it was not about standarization.
2913 (FeatureRequiresLINQ): New.
2915 * support.cs (SeekableStreamReader): Only require that the reader
2916 is a TextReader, not a StreamReader, so we can plug StringReader.
2918 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
2919 given position in the input stream the following tokens can be
2920 parsed as a type followed by an identifier.
2922 (is_punct): after a '(' if parse_type_and_parameter returns true,
2923 then return a special token OPEN_PARENS_LAMBDA which is used to
2924 avoid reduce/reduce errors in the grammar for the
2925 lambda_expression rules.
2927 (parse_type): implement a type parser inside the
2928 tokenizer, the parser only returns true or false depending on
2929 whether the input at a given position can be parsed as a type.
2931 (peek_token): new method used during type parsing.
2933 2007-01-28 Raja R Harinath <rharinath@novell.com>
2936 * anonymous.cs (ScopeInfo.InflateParameters): New.
2937 (AnonymousContainer.Resolve): Use it to redirect types of
2938 delegate parameters.
2940 2007-01-27 Raja R Harinath <rharinath@novell.com>
2943 * expression.cs (Error_InvalidArguments): Don't use two different
2944 messages for CS1503. Use ExtraInformation and
2945 SymbolRelatedToPreviousError instead.
2948 * decl.cs (DeclSpace.initialize_type_params): Don't access
2949 'type_params' of a partial class directly.
2951 2007-01-26 Miguel de Icaza <miguel@novell.com>
2953 * constant.cs: Removed a handful of out-of-range checks that were
2956 2007-01-25 Marek Safar <marek.safar@gmail.com>
2958 * expression.cs (CheckUselessComparison): Add additional check for char
2961 * namespace.cs: Fixed typo.
2963 2007-01-23 Miguel de Icaza <miguel@novell.com>
2965 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
2966 gone, instead we inline the test, preventing the needless casts to
2967 longs, ulongs and doubles for the parameters, avoiding calls to
2968 methods that overchecked stuff, and instead inlined things
2971 2007-01-20 Marek Safar <marek.safar@gmail.com>
2973 * cs-parser.jay: Better parameter error handling.
2975 2007-01-17 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #80368, #80522
2978 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
2979 whether array initializer contains constants only.
2980 (ArrayCreation.Emit): Use better formula to decide when
2981 are array initializers for static initialization.
2982 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
2983 have to emit even constants otherwise they are pre-initialized.
2985 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
2986 Raja R Harinath <rharinath@novell.com>
2988 Fix emit order of 'get' vs. 'set'.
2989 * support.cs (Accessors): New.
2990 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
2991 Note the order in which accessors are declared in the source.
2992 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
2993 Refactored from Property.Define and Indexer.Define.
2994 (PropertyBase.DefineAccessors): New helper that calls the above in
2995 appropriate order as noted by the parser.
2996 (Property.Define, Indexer.Define): Update to changes.
2997 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
2999 2007-01-17 Raja R Harinath <rharinath@novell.com>
3001 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3002 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3003 there's an implicit conversion from the current type to the target
3004 type before converting the underlying constant.
3006 2007-01-16 Marek Safar <marek.safar@gmail.com>
3008 * const.cs (ResolveValue): Updated after constant conversion was made more
3011 * constant.cs (GetAttributableValue): constant to object conversion is
3012 used for attributes only.
3013 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3014 constant conversions.
3015 (LongConstant.ConvertImplicitly): Ditto.
3017 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3018 (ImplicitConversionStandard): Handle constant conversion as extra step.
3019 It solves the issue when constant conversion was called indirectly like
3020 inside array initializer and constant folding was skipped.
3022 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3025 * statement.cs(ImplicitConversionStandard): Updated after constant
3026 conversion was made more generic.
3028 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3030 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3031 Constraints, solves the problem where the compiler incorrectly
3032 reported that a type parameter was not constrained to a class (Bug
3035 2007-01-14 Marek Habersack <grendello@gmail.com>
3037 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3039 2007-01-14 Marek Safar <marek.safar@gmail.com>
3041 A fix for bug #80368
3042 * assign.cs (FieldInitializer): New class implements field
3043 initializer statement.
3045 * attribute.cs: Update after FieldMember rename.
3047 * class.cs (PropertyBasedMember): New common class for property based
3049 (InterfaceMemberBase): New base class for all members which can be used as
3050 an interface members.
3051 (MethodCore): Moved really common code to InterfaceMemberBase.
3052 (Method.Define): Equal and GetHasCode detection is relevant for methods
3054 (MethodData.Define): Don't assume that public event implements an
3055 interface automatically.
3056 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3058 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3059 (FieldMember): Merged with FieldBase.
3060 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3061 event extern modifier can be used.
3062 (EventField.EventFieldAccessor): Moved event field specific code here.
3063 (Event.AllowedModifiers): Even event can be extern.
3064 (Event.FindOutBaseMethod): New override specific to events.
3065 (Indexer.parameters): Reintroduce parameters because base class holds
3066 only properties common data.
3067 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3068 need do extra parameters check.
3070 * const.cs: Update after FieldMember rename.
3072 * decl.cs (MemberCache.FindBaseEvent): New method.
3074 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3075 to reflect that indexer is now derived from PropertyBased.
3077 * ecore.cs (GetMemberType): Made public.
3078 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3081 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3083 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3084 (RegisterEvent): Removed.
3085 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3086 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3088 2007-01-11 Raja R Harinath <rharinath@novell.com>
3091 * statement.cs (CollectionForeach.TryType): Prefer generic
3092 GetEnumerator over non-generic variant. Fix code to follow comments.
3094 2007-01-09 Raja R Harinath <rharinath@novell.com>
3097 * support.cs (ReflectionParameter): Don't use an invalid index on
3098 the generic parameter data.
3100 2007-01-08 Miguel de Icaza <miguel@novell.com>
3102 * driver.cs: Just add a tiny bit of infrastructure.
3104 2007-01-02 Marek Safar <marek.safar@gmail.com>
3106 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3107 where field type is struct from current assembly.
3109 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3112 2007-01-02 Marek Safar <marek.safar@gmail.com>
3114 A fix for bug #80381
3115 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3118 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3120 (Namespace.LookupType): Always use core types from corlib when speficied.
3122 * report.cs: A new warning.
3124 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3125 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3126 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3128 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3129 (InitCoreTypes): Set expression type of object_type and value_type
3130 immediately after lookup.
3132 2007-01-01 Miguel de Icaza <miguel@novell.com>
3134 * cs-tokenizer.cs: Accept Pc class characters (Connector
3135 Punctuation) as valid identifiers. Fixes #78259
3137 * expression.cs (Invocation.DoResolve): Moved the check for the
3138 use of `this' for doing method calls to the Invocation resolution
3139 step, after overload resolution has taken place instead of doing
3140 the check at the low-level `This.DoResolve' level.
3142 The `This.DoResolve'(appens before overload resolution, so it has
3143 no way of knowing if the method that will be called will be
3144 instace or static, triggering an erroneous report for cs0188 (Bug
3147 We now do the check for instance method invocations after we know
3148 what method will be called.
3150 (This.CheckThisUsage): Move the actual use of this structure
3151 checking into its own method and expose it.
3153 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3156 Exceptions: Null.ConvertImplicitly,
3157 Constant.ImplicitConversionRequired as there are too many call
3158 sites for passing the ec.
3160 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3161 EmitContext, if the value is null, then we do not try to provide
3162 the extra information from the error (If a userdefined conversion
3163 exists, as UserDefinedConversion requires a non null-EmitContext).
3167 2006-12-30 Raja R Harinath <rharinath@novell.com>
3169 * flowanalysis.cs (MyBitVector): Document some invariants.
3170 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3171 introduced below, and add a couple of others,
3173 2006-12-30 Marek Safar <marek.safar@gmail.com>
3175 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3176 GetPropertyFromAccessor and GetEventFromAccessor.
3178 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3179 overrides non-obsolete one.
3180 (Indexer.Define): Error message has been moved to the parser.
3182 * cs-parser.jay: Better syntax errors handling.
3184 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3185 when an invocation has no arguments.
3187 * ecore.cs: Removed not used caching.
3189 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3192 * report.cs: Add a new warning.
3194 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3196 * typemanager.cs (enumeration_type): Removed.
3197 (CSharpSignature): Reuses IsSpecialMethod.
3198 (IsEqual): Hack for MS BCL.
3199 (GetPropertyFromAccessor): New method.
3200 (GetEventFromAccessor): New method.
3201 (IsSpecialMethod): Fixed to handle more cases.
3203 2006-12-30 Marek Safar <marek.safar@gmail.com>
3205 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3206 Made white spaces array static.
3208 * ecore.cs (RemoveGenericArity): Optimized.
3210 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3212 (MyBitVector.initialize_vector): Simplified.
3214 2006-12-22 Miguel de Icaza <miguel@novell.com>
3216 * ecore.cs: Am not entirely happy with this hack, but it seems to
3217 address the issue in 80257 (a small test case for
3220 I set the MethodGroupExpr.Type to an internal compiler type
3221 (itself in this case) to force the resolution to take place. Why
3222 it does not take place with a null is beyond me.
3224 2006-12-20 Marek Safar <marek.safar@gmail.com>
3226 A fix for bug #80288
3227 * expression.cs (ResolveOperator): Consider user defined conversion for
3228 logical and operator too.
3229 (EmitBranchable): Optimization for logical and when full constant folding
3230 could not be applied but one operand is constant.
3232 2006-12-19 Marek Safar <marek.safar@gmail.com>
3234 * class.cs (GetClassBases): Write 5 times every day, will never use
3235 FullName for error reporting.
3237 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3239 2006-12-19 Martin Baulig <martin@ximian.com>
3241 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3242 the symbol file info here.
3244 2006-12-18 Marek Safar <marek.safar@gmail.com>
3246 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3247 of `elseif' is taking then following sections are not taking.
3248 Fixes an issue reported on mono mailing list.
3250 2006-12-18 Marek Safar <marek.safar@gmail.com>
3252 A fix for bug #80300
3253 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3254 a caller is not taking.
3256 2006-12-18 Raja R Harinath <rharinath@novell.com>
3258 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3259 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3260 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3261 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3262 * class.cs: Update to changes.
3264 2006-12-17 Marek Safar <marek.safar@gmail.com>
3266 A fix for bug #79934
3267 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3270 * class.cs (ResolveMembers): Register an iterator in current container and
3273 2006-12-16 Raja R Harinath <rharinath@novell.com>
3276 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3277 satisfy a params annotated parameter.
3279 2006-12-16 Marek Safar <marek.safar@gmail.com>
3281 A fix for bug #77014
3282 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3283 paramters correctly and not rely on hacks in Parameters class.
3284 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3286 (Invocation.VerifyArgumentsCompat): Ditto.
3287 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3290 * parameter.cs (HasParams): Don't assume that params is the last one.
3292 * support.cs (ReflectionParameters.ctor): Look for params attribute
3294 (ReflectionParameters.ParameterType): Removed hack when we returned last
3295 parameter for out of range parameters.
3296 (ParameterName, ParameterModifier): Ditto.
3298 2006-12-14 Marek Safar <marek.safar@gmail.com>
3300 A fix for bug #79987
3301 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3302 when assembly is not CLS compliant but type is. I have no idea why is this
3305 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3307 2006-12-13 Miguel de Icaza <miguel@novell.com>
3309 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3310 in struct constructors, they are basically no-ops.
3312 2006-12-12 Marek Safar <marek.safar@gmail.com>
3314 * cs-tokenizer.cs (Position): Save preprocessor status too.
3316 2006-12-12 Marek Safar <marek.safar@gmail.com>
3318 A fix for bug #77794
3319 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3321 2006-12-12 Marek Safar <marek.safar@gmail.com>
3323 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3325 (pp_expr): Report error for an invalid expression.
3326 (handle_preprocessing_directive): Simplified; add more error checking.
3328 2006-12-11 Marek Safar <marek.safar@gmail.com>
3330 A fix for bug #74939
3331 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3332 directives handling.
3334 2006-12-10 Marek Safar <marek.safar@gmail.com>
3336 A fix for bugs #80093, and #75984
3337 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3338 logic, it seems to me as it worked before "by coincidence".
3339 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3340 (cleanup): Enabled endif check.
3342 2006-12-09 Marek Safar <marek.safar@gmail.com>
3344 A fix for bug #80162
3345 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3346 enumerators are never ambiguous.
3348 2006-12-08 Raja R Harinath <rharinath@novell.com>
3351 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3353 2006-12-06 Marek Safar <marek.safar@gmail.com>
3355 A fix for bug #80144
3356 * class.cs (EventProperty.Define): Explicit implementation means
3357 that an even is used.
3359 2006-12-06 Marek Safar <marek.safar@gmail.com>
3361 Fixes the operators implementation (part II)
3363 * cfold.cs (DoConstantNumericPromotions): Renamed to
3364 DoBinaryNumericPromotions and simplified.
3365 (BinaryFold): Couple of conversion fixes; simplified.
3367 * constant.cs, ecore.cs, literal.cs
3368 (ToType): Renamed to ConvertImplicitly.
3369 (Reduce): Renamed to ConvertExplicitly.
3371 * class.cs, convert.cs: Updated.
3373 * expression.cs: TryReduce doesn't throw an exception.
3375 2006-12-01 Marek Safar <marek.safar@gmail.com>
3377 A fix for bug #80108
3378 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3381 2006-11-30 Marek Safar <marek.safar@gmail.com>
3383 Fixes unary operators implementation (part I)
3386 * cfold.cs (Error_CompileTimeOverflow): Made internal
3388 * const.cs (IConstant): Changed to use reference to constant and
3389 not constant itself.
3390 Updated IConstant implementations.
3392 * constant.cs (CreateConstant): New factory method.
3393 Updated IConstant implementation.
3395 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3397 * ecore.cs: Updated to use CreateConstantReference.
3399 * enum.cs: Reflects IConstant changes.
3401 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3403 * literal.cs (NullConstant): Change to be independently usable.
3405 2006-11-29 Martin Baulig <martin@ximian.com>
3407 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3408 we need to emit the scope initializer before calling the base .ctor.
3410 * anonymous.cs: Merged back from the new anonymous methods branch.
3411 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3413 * expression.cs (ParameterReference.DoResolveBase): Create a
3414 "normal" ScopeInfo when capturing parameters rather than using the
3415 root scope; this makes things work with anonymous methods having
3419 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3421 2006-11-22 Marek Safar <marek.safar@gmail.com>
3423 A fix for bug #79987
3424 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3425 check to a base class.
3426 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3427 only when assembly has missing attribute.
3428 * report.cs: Update.
3430 2006-11-21 Marek Safar <marek.safar@gmail.com>
3432 * cs-tokenizer.cs: Merged with gmcs version.
3434 2006-11-20 Marek Safar <marek.safar@gmail.com>
3437 * cs-parser.jay: Better error message when partial keyword is misplaced.
3439 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3441 A fix for bug #79810
3442 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3443 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3444 a RuntimeWrappedException by default.
3446 2006-11-18 Marek Safar <marek.safar@gmail.com>
3448 A fix for bug #79843
3449 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3451 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3453 2006-11-18 Marek Safar <marek.safar@gmail.com>
3455 * driver.cs, namespace.cs: Uses faster IndexOf version.
3457 2006-11-17 Marek Safar <marek.safar@gmail.com>
3459 A fix for bug #79941
3460 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3462 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3463 even if internal name is different.
3464 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3465 (UserDefinedConversion): Simplified as the operators cannot be internal.
3466 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3468 (MethodLookup): Replaced EmitContext with parentType.
3469 * expression.cs: Updated.
3471 2006-11-09 Raja R Harinath <rharinath@novell.com>
3473 * driver.cs (BadAssembly): Handle all the ugliness of
3474 DefineDynamicAssembly.
3476 2006-11-08 Raja R Harinath <rharinath@novell.com>
3478 Address parts of #58244 -- most of what's left is in the runtime
3479 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3480 CS1509 error checks, and handle them for all assembly loads, not
3481 just the first invocation.
3482 (LoadModule): Likewise. Move handling of 'adder_method' ...
3483 * codegen.cs (AssemblyClass.AddModule): ... here.
3485 2006-11-02 Marek Safar <marek.safar@gmail.com>
3487 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3488 IEnumerable<T> is ambiguous.
3490 2006-10-31 Marek Safar <marek.safar@gmail.com>
3492 A fix for bug #67689
3493 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3494 GetEnumerator is ambiguous.
3496 * report.cs: Add new warning.
3498 2006-10-29 Marek Safar <marek.safar@gmail.com>
3500 A fix for bug #78602
3501 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3502 to protected member can be nested type.
3504 2006-10-28 Marek Safar <marek.safar@gmail.com>
3506 A fix for bug #78965
3507 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3508 to protected member must derive from current type.
3510 2006-10-27 Marek Safar <marek.safar@gmail.com>
3512 assign.cs: Reuses error method.
3514 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3515 instead of type for constants.
3516 (Expression.Error_ValueAssignment): Common error method.
3518 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3521 2006-10-27 Marek Safar <marek.safar@gmail.com>
3523 A fix for bug #79081
3524 * expression.cs (MemberAccess.DoResolve): Check nested type
3527 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3529 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3531 2006-10-26 Marek Safar <marek.safar@gmail.com>
3533 A fix for bug #76591
3534 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3536 2006-10-26 Marek Safar <marek.safar@gmail.com>
3538 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3539 type forwarder of the same type multiple times.
3541 2006-10-26 Raja R Harinath <rharinath@novell.com>
3544 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3545 instance as an rvalue, even when we later resolve as an lvalue.
3547 2006-10-25 Martin Baulig <martin@ximian.com>
3549 * anonymous.cs: Fix #79673.
3551 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3553 A fix for bug #79666
3554 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3555 ignored when is optimized (= default value) as its value is already set.
3557 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3559 A fix for bug #79724
3560 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3561 TypeContainer for type lookup.
3563 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3565 A fix for bug #79231
3566 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3567 * expression.cs (OverloadResolve): Always convert type name for
3569 (ResolveNamespaceOrType): Don't confuse a nested type with any
3572 2006-10-18 Martin Baulig <martin@ximian.com>
3574 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3576 2006-10-17 Miguel de Icaza <miguel@novell.com>
3578 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3579 an int32, but requesting an int64 from the conversion
3581 2006-10-12 Martin Baulig <martin@ximian.com>
3584 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3586 2006-10-12 Martin Baulig <martin@ximian.com>
3589 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3591 2006-10-11 Miguel de Icaza <miguel@novell.com>
3593 * convert.cs: Remove broken code: I was doing the "Existance"
3594 tests for Implicit conversions.
3596 2006-10-10 Miguel de Icaza <miguel@novell.com>
3598 * convert.cs: Added one missing case in
3599 ImplicitStandardConversionExists uint64 to intptr.
3603 * typemanager.cs (uintptr_type): another core known type.
3605 * ecore.cs (OperatorCast): routine used to do cast operations that
3606 depend on op_Explicit. We could change some of the Decimal
3607 conversions to use this.
3609 This one has a probe mechanism that checks both types for an op_
3610 which it coudl be used to eliminate two classes: CastToDecimal
3611 and CastFromDecimal.
3613 * convert.cs: Implement the conversions documented in #59800
3615 2006-10-10 Martin Baulig <martin@ximian.com>
3617 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3618 before RootScope.ResolveMembers().
3620 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3621 `CurrentType' if appropriate.
3623 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3625 A fix for bug #78568
3626 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3627 when contains binary operators.
3628 * cs-parser.jay: Updated.
3630 2006-10-09 Martin Baulig <martin@ximian.com>
3633 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3634 moved that into Define() and also do the other type parameter
3635 checks there. Fixes #79094. Added gtest-292.cs.
3638 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3639 since that doesn't include type parameters; don't use `Ldelema'
3640 for type parameters. Fixes #78980. Added gtest-293.cs.
3642 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3645 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3646 conversion is allowed.
3648 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3650 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3651 error reporting when no error occurs.
3653 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3655 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3658 2006-10-06 Raja R Harinath <rharinath@novell.com>
3661 * class.cs (DefineTypeBuilder): Check circular dependencies before
3662 setting the parent of the TypeBuilder.
3663 (CheckRecursiveDefinition): Don't use 'BaseType', since
3664 it may not be valid until after DefineTypeBuilder. Use
3665 'base_type' instead.
3667 2006-10-04 Martin Baulig <martin@ximian.com>
3669 Merged the Anonymous Methods patch.
3671 * anonymous.cs, iterators.cs: The new anonymous methods code.
3673 * statement.cs (Variable): New public abstract class.
3674 (LocalInfo.Variable): New public property.
3675 (LocalInfo.ResolveVariable): New public method.
3676 (Block.Flags): Add `IsIterator'.
3677 (Block.AddVariable): Improved the CS0136 check.
3678 (Block.AnonymousChildren): New public property.
3679 (Block.AddAnonymousChild): New public method.
3680 (ToplevelBlock): Update to use the new anonymous method framework.
3681 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3682 `ToplevelBlock'; this is required to correctly implement the
3684 (Fixed, Using): Use `TemporaryVariable' instead of directly
3685 creating the `LocalBuilder'.
3687 * parameter.cs (Parameter.ResolveVariable): New public method.
3688 (Parameters.ResolveVariable): Likewise.
3690 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3692 * class.cs (TypeContainer): Replaced the `iterators' list and
3693 corresponding methods with a list of `CompilerGeneratedClass'es.
3694 (TypeContainer.ResolveMembers): New public method.
3695 (Method): `IIteratorContainer' has been replaced by
3698 * expression.cs (VariableReference): New public abstract base
3699 class for `LocalVariableReference', `ParameterReference' and
3702 * codegen.cs (EmitContext): Removed `capture_context',
3703 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3704 (EmitContext.EmitThis): Removed.
3706 * cs-parser.jay: Replace `iterator_container' with
3709 2006-10-04 Martin Baulig <martin@ximian.com>
3711 * generic.cs (GenericMethod): Don't make this abstract.
3712 (Constraints.Clone): Added dummy implementation.
3714 2006-10-04 Raja R Harinath <harinath@gmail.com>
3717 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3718 'declspaces'. Avoid allocating arrays willy-nilly.
3721 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3722 cases out of the switch.
3724 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3726 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3727 message when non-generic type is used with the type arguments.
3728 * expression.cs: Updated.
3730 2006-09-28 Raja R Harinath <rharinath@novell.com>
3733 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3734 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3735 Change semantics slightly. Don't insist on having only one
3736 temporary EmptyExpression -- just throttle the creation of new ones.
3739 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
3740 non-interfaces too. If no methods are found, don't try to create
3743 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3745 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
3748 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
3749 us produce better error message.
3751 2006-09-27 Marek Safar <marek.safar@seznam.cz>
3753 * expression.cs (Binary.ResolveOperator): Warn about a side effect
3754 of the `|' operator.
3756 * report.cs: A new warning added.
3758 2006-09-27 Martin Baulig <martin@ximian.com>
3760 * generic.cs (GenericMethod): Don't make this abstract.
3762 2006-09-27 Martin Baulig <martin@ximian.com>
3765 (InternalErrorException): Added overloaded ctor taking a params array.
3767 2006-09-26 Marek Safar <marek.safar@seznam.cz>
3769 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
3770 Fixed the cases when same error was reported twice.
3772 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
3773 now report symbol information.
3775 2006-09-25 Martin Baulig <martin@ximian.com>
3777 * class.cs: Completely unified with the gmcs version.
3779 2006-09-25 Martin Baulig <martin@ximian.com>
3781 * typemanager.cs (TypeManager.IsNullableType): New public function.
3782 (TypeManager.IsNullableTypeOf): Likewise.
3783 (TypeManager.IsNullableValueType): Likewise.
3785 * class.cs (MethodCore): Added the `GenericMethod' argument from
3786 gmcs and also unified all classes derived from `MethodCore' with gmcs.
3788 2006-09-24 Raja R Harinath <harinath@gmail.com>
3790 * convert.cs: Unify with gmcs version.
3792 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3794 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
3795 verify them as well.
3797 * report.cs: New warning.
3799 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3801 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
3802 for anonymous block with out argument.
3804 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3806 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
3807 not used private events only.
3809 2006-09-23 Marek Safar <marek.safar@seznam.cz>
3811 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
3813 * const.cs (Const.Define): Check for constant type.
3814 (Const.IsConstantTypeValid): Looks for valid constant types.
3816 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
3818 * ecore.cs (EmptyConstantCast): New common class for all constant based
3821 * expression.cs (Is.DoResolve): Handle null constant especially.
3822 (New.DoResolve): Check for new void().
3823 (MemberAccess.DoResolve): Cope with all kind of nulls.
3825 * literal.cs (NullConstant): Uses EmptyConstantCast.
3826 (NullDefault): Based on EmptyConstantCast.
3827 (NullLiteral): Uses EmptyConstantCast.
3829 * statement.cs (Block.ResolveMeta): Check for constant type.
3831 2006-09-22 Martin Baulig <martin@ximian.com>
3833 * delegate.cs, attribute.cs: Merged with the gmcs versions.
3835 2006-09-22 Raja R Harinath <rharinath@novell.com>
3837 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
3841 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
3842 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
3845 2006-09-22 Martin Baulig <martin@ximian.com>
3847 * ecore.cs: Merged with the gmcs version.
3849 * generic.cs (ConstructedType): New dummy class.
3850 (TypeArguments): Don't make this abstract.
3853 (TypeManager.IsGenericTypeDefinition): New method.
3854 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
3856 2006-09-22 Raja R Harinath <rharinath@novell.com>
3858 * expression.cs (ComposedCast): Check for arrays of TypedReference
3859 before creating the type, not after.
3861 2006-09-21 Marek Safar <marek.safar@seznam.cz>
3863 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
3864 after ToType change.
3866 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
3867 when constant must be implicitly convertible.
3869 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
3871 * ecore.cs (NullCast): Derives from NullConstant.
3873 * expression.cs (Is.DoResolve): Removed useless variables.
3874 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
3875 (New.Constantify): Add enum support.
3876 (MemberAccess.DoResolve): Add warning when accessing null constant or
3879 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
3882 * literal.cs (NullConstant): New abstract class with common
3883 functionality for all null specializations.
3884 (NullDefault): Represents default(X) when result can be
3886 (NullLiteral): Updated.
3888 * report.cs: Add new warning.
3890 2006-09-21 Martin Baulig <martin@ximian.com>
3892 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
3894 2006-09-21 Martin Baulig <martin@ximian.com>
3896 * generic.cs (GenericConstraints): New dummy class.
3897 (Constraints): Likewise.
3898 (TypeParameter): Likewise.
3899 (TypeParameterName): Likewise.
3900 (GenericMethod): Likewise.
3902 * typemanager.cs (TypeManager.GetGenericArguments): New method.
3904 * decl.cs: Merged with the gmcs version.
3906 2006-09-21 Raja R Harinath <rharinath@novell.com>
3908 * generic.cs (TypeParameter): Implement IMemberContainer.
3909 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
3911 * rootcontext.cs: Unify with gmcs version.
3913 * report.cs: Unify with gmcs version.
3914 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
3915 from gmcs/generics.cs.
3916 * generics.cs (TypeParameter): New dummy class.
3918 * support.cs: Unify with gmcs version.
3920 2006-09-20 Raja R Harinath <rharinath@novell.com>
3922 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
3923 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
3925 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
3926 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
3927 * mcs.exe.sources: Add generic.cs.
3929 * codegen.cs: Unify with gmcs version.
3931 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
3932 (EmitContext): Add GenericDeclContainer implementation.
3933 * decl.cs (MemberCore, DeclSpace): Likewise.
3934 * namespace.cs: Remove #ifdef GMCS_SOURCE.
3936 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
3937 MCS TypeManager has a corresponding dummy method.
3939 2006-09-19 Martin Baulig <martin@ximian.com>
3941 * expression.cs: Completely merged with the gmcs version.
3943 2006-09-19 Martin Baulig <martin@ximian.com>
3945 * expression.cs (Invocation): Merged with the gmcs version.
3946 (ArrayAccess.GetStoreOpcode): Likewise.
3948 2006-09-19 Martin Baulig <martin@ximian.com>
3951 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
3952 (TypeManager.IsGenericMethodDefinition): Likewise.
3954 2006-09-19 Martin Baulig <martin@ximian.com>
3957 (TypeManager.IsEqual): Moved the gmcs implementation here.
3958 (TypeManager.DropGenericTypeArguments): Likewise.
3959 (TypeManager.DropGenericMethodArguments): Likewise.
3960 (TypeManager.GetTypeArguments): Moved here from gmcs.
3961 (TypeManager.HasGenericArguments): Likewise.
3963 2006-09-19 Martin Baulig <martin@ximian.com>
3965 * expression.cs (Binary): Merged with the gmcs version.
3967 2006-09-19 Martin Baulig <martin@ximian.com>
3969 * expression.cs (Probe, As, Is): Merged with the gmcs version.
3971 2006-09-19 Martin Baulig <martin@ximian.com>
3973 * typemanager.cs: Merged with the gmcs version.
3975 2006-09-16 Raja R Harinath <rharinath@novell.com>
3977 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
3978 * driver.cs: Likewise.
3980 2006-09-16 Marek Safar <marek.safar@seznam.cz>
3983 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
3984 only if parent type is class.
3985 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
3988 2006-09-15 Marek Safar <marek.safar@seznam.cz>
3991 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
3993 * typemanager.cs(CSharpName): Converts NullType to null.
3995 2006-09-15 Martin Baulig <martin@ximian.com>
3998 (TypeManager.GetMethodName): Added mcs implementation.
3999 (TypeManager.IsEqual): Likewise.
4002 (SimpleName.RemoveGenericArity): Added dummy implementation.
4004 * pending.cs: Merged with the gmcs version.
4006 2006-09-15 Martin Baulig <martin@ximian.com>
4008 * statement.cs: Merge with the gmcs version.
4010 2006-09-15 Martin Baulig <martin@ximian.com>
4012 * statement.cs (Switch): Merge with the gmcs implementation
4013 (without nullables), which is newer.
4015 2006-09-15 Martin Baulig <martin@ximian.com>
4017 * statement.cs (Block.Variables): Make this public.
4018 (ToplevelBlock.Parameters): Make this a property.
4019 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4021 2006-09-15 Martin Baulig <martin@ximian.com>
4023 * namespace.cs: Merge with the gmcs version.
4025 2006-09-15 Martin Baulig <martin@ximian.com>
4027 * decl.cs (MemberName): Minor code cleanups.
4029 2006-09-15 Martin Baulig <martin@ximian.com>
4031 * parameter.cs: Merge with the gmcs version.
4033 2006-09-15 Martin Baulig <martin@ximian.com>
4035 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4036 and an error in mcs.
4038 2006-09-15 Martin Baulig <martin@ximian.com>
4040 * flowanalysis.cs: Merged from GMCS; added the generics code into
4041 a `GMCS_SOURCE' conditional so we can share this file.
4043 2006-09-08 Martin Baulig <martin@ximian.com>
4045 * typemanager.cs (TypeManager.interlocked_type): New public field.
4046 (TypeManager.int_interlocked_compare-exchange): New public field.
4047 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4048 enumerator types here and call InitGenericCoreTypes().
4049 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4050 after calling InitEnumUnderlyingTypes().
4053 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4054 `classes_second_stage'.
4056 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4058 * assign.cs, ecore.cs, expression.cs: Share error message text.
4059 * class.cs (FieldMember.Define): Check for varible of static type.
4060 * driver.cs (LoadAssembly): Uses error output for errors.
4061 * statement.cs: Updated.
4063 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4065 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4068 2006-09-07 Martin Baulig <martin@ximian.com>
4071 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4073 2006-08-29 Miguel de Icaza <miguel@novell.com>
4075 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4077 2006-08-17 Miguel de Icaza <miguel@novell.com>
4079 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4080 #52019 and #79064, the use of the \uXXXX sequence in source code
4081 to represent unicode characters.
4083 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4085 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4087 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4089 2006-08-13 Miguel de Icaza <miguel@novell.com>
4091 * assign.cs: Catch attempts to assign to a method groups in += and
4094 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4097 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4099 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4101 * class.cs (Method.Define): Issue a warning when generic method looks like
4103 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4106 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4108 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4110 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4111 search all base interfaces as a member can be ambiguous.
4112 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4113 Constructor member type filter.
4114 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4115 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4116 reporting for returned memberinfos.
4117 * report.cs: Updated.
4118 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4119 version to work on all runtimes.
4120 (TypeManager.RealMemberLookup): Removed members filtering.
4122 2006-08-08 Raja R Harinath <rharinath@novell.com>
4124 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4125 (PropertyExpr.EmitAssign): Likewise.
4126 * expression.cs (Indirection.EmitAssign): Likewise.
4127 (LocalVariableReference.EmitAssign): Likewise.
4128 (ParameterReference.EmitAssign): Likewise.
4129 (Invocation.EmitArguments): Likewise.
4130 (ArrayAccess.EmitAssign): Likewise.
4131 (IndexerAccess.EmitAssign): Likewise.
4132 (This.EmitAssign): Likewise.
4133 (ConditionalLogicalOperator.Emit): Likewise.
4136 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4137 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4138 leave it in after returning it.
4139 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4141 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4143 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4146 2006-08-03 Raja R Harinath <rharinath@novell.com>
4148 Fix cs0146-3.cs and cs0146-4.cs.
4149 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4150 enclosing types don't depend on the current type.
4152 2006-08-02 Raja R Harinath <rharinath@novell.com>
4155 * class.cs (TypeContainer.DoDefineMembers): Use
4156 FindBaseMemberWithSameName on Parent, since we're interested in
4157 whether we hide inherited members or not.
4158 (FindBaseMemberWithSameName): Make slightly more robust.
4160 Fix the non-generic testcase from #77396
4161 * decl.cs (DeclSpace.DeclContainer): Remove override.
4163 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4164 declspaces for doppelgangers too.
4165 (UsingEntry): Implement IResolveContext.
4166 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4167 'this' as the resolve context.
4168 (LocalAliasEntry): Likewise.
4170 Implement parts of #77403
4171 * roottypes.cs (RootDeclSpace): New. Used to represent the
4172 toplevel declaration space. Each namespace declaration introduces
4173 a "partial" root declaretion space.
4174 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4175 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4176 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4177 from 'current_namespace.SlaveDeclSpace'.
4178 (namespace_declaration): Likewise.
4179 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4180 check. It can't happen now.
4181 * decl.cs (DeclSpace.LookupType): Likewise.
4182 * driver.cs (MainDriver): Sanity check.
4184 2006-08-01 Raja R Harinath <rharinath@novell.com>
4186 * decl.cs (DeclSpace.FindNestedType): Remove.
4187 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4188 LookupTypeContainer to get the container of the nested type.
4189 * class.cs (TypeContainer.FindNestedType): Make non-override.
4191 2006-07-31 Raja R Harinath <rharinath@novell.com>
4193 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4194 * class.cs (TypeContainer.PartialContainer): ... here.
4195 (TypeContainer.AddBasesForPart): New helper.
4196 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4198 * cs-parser.jay (current_class): Convert to DeclSpace.
4199 (struct_declaration, interface_declaration, class_declaration):
4200 Use AddBasesForPart instead of .Bases directly.
4201 * const.cs, iterators.cs: Update to changes.
4203 2006-07-28 Raja R Harinath <rharinath@novell.com>
4205 * class.cs (TypeContainer.AddMemberType): Rename from
4207 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4208 (AddTypeContainer): New. Combine AddClassOrStruct and
4210 (AddPartial): Update. Add 'is_partial' argument.
4211 * roottypes.cs: Update to changes.
4212 * cs-parser.jay (push_current_class): New helper for handling
4213 current_container and current_class.
4214 (struct_declaration, interface_declaration, class_declaration):
4217 2006-07-26 Raja R Harinath <rharinath@novell.com>
4219 * roottypes.cs: Rename from tree.cs.
4221 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4222 * tree.cs (Tree, ITreeDump): Remove types.
4223 * rootcontext.cs (tree, Tree): Remove fields.
4224 (root, ToplevelTypes): New.
4225 * *.cs: Update to rename.
4227 * tree.cs (Tree.RecordDecl): Remove.
4228 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4230 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4232 2006-07-23 Raja R Harinath <harinath@gmail.com>
4234 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4235 DoFlowAnalysis and OmitStructFlowAnalysis here.
4236 (ec.With): Rename from WithUnsafe and generalize.
4237 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4238 (ec.WithFlowAnalyis): New.
4239 * ecore.cs, expression.cs, statement.cs: Update.
4241 2006-07-22 Raja R Harinath <harinath@gmail.com>
4243 * statement.cs (Block.ResolveMeta): Simplify slightly.
4245 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4246 multiple boolean fields. Convert InUnsafe, constant_check_state,
4247 check_state to flags.
4248 (CheckState, ConstantCheckState): Update.
4249 (InUnsafe): New read-only property.
4250 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4252 (WithUnsafe): New helper similar to WithCheckState.
4253 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4254 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4256 2006-07-21 Raja R Harinath <rharinath@novell.com>
4258 Make comparisons use the same IL irrespective of whether they're
4259 in a 'checked' or 'unchecked' context: one of the issues in #78899
4260 * codegen.cs (EmitContext.CheckState): Make read-only property.
4261 (EmitContext.ConstantCheckState): Likewise.
4262 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4263 helper that implement a save/restore stack for CheckState
4264 values. This is the only way to change check-state.
4265 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4266 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4267 (CheckedExpr.EmitBranchable): New forwarding method.
4268 (UnCheckedExpr): Likewise.
4269 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4270 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4271 (Checked.Resolve, checked.DoEmit): Likewise.
4273 2006-07-20 Miguel de Icaza <miguel@novell.com>
4275 * anonymous.cs: Cache the resolved anonymous delegate, and return
4276 this so that the ResolveTopBlock is only triggered once, not
4279 Currently we trigger ResolvetopBlock twice due to a first pass of
4280 argument check compatibility, and a second pass that does the
4283 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4285 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4287 * rootcontext.cs (Reset): Add helper_classes.
4289 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4292 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4295 2006-07-13 Miguel de Icaza <miguel@novell.com>
4297 * statement.cs (Lock): Handle expressions of type
4298 TypeManager.null_type specially. Fixes #78770
4300 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4302 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4305 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4307 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4308 for accessors as well.
4309 * ecore.cs (EventExpr): Add AccessorTable.
4311 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4314 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4315 for CS0122 where appropriate.
4316 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4318 (Filter): Assembly can be null in the case of top level attributes.
4320 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4324 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4325 is done at global level.
4327 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4329 A fix for #77002, Implemented TypeForwarder support.
4331 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4332 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4333 * typemanager.cs (): Add type_forwarder_attr_type.
4335 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4337 * report.cs: Add CS0469 warning.
4339 2006-06-21 Martin Baulig <martin@ximian.com>
4341 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4342 the `try'-block, so we also report CS0016 etc. there.
4344 2006-06-21 Martin Baulig <martin@ximian.com>
4347 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4349 2006-06-21 Martin Baulig <martin@ximian.com>
4351 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4352 also report CS1686 for parameters.
4354 2006-06-21 Martin Baulig <martin@ximian.com>
4356 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4357 instead of an error if the value is not implicitly convertible to
4358 the switch types; fixes #77964.
4360 2006-06-21 Raja R Harinath <rharinath@novell.com>
4363 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4364 FieldBuilder is null.
4367 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4368 'left' and 'right' before error-checking.
4370 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4372 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4374 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4375 (FieldExpr.DoResolve): likewise.
4376 (PropertyExpr.InstanceResolve): likewise.
4377 (EventExpr.InstanceResolve): likewise.
4379 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4381 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4382 attribute applicable tests for attribute argument.
4384 2006-06-02 Raja R Harinath <rharinath@novell.com>
4387 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4388 (Binary.OverloadResolve_PredefinedIntegral): New.
4389 (Binary.OverloadResolve_PredefinedFloating): New.
4390 (Binary.OverloadResolve_PredefinedString): New.
4391 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4392 Follow the standard more closely, and treat numeric promotions in
4393 terms of overload resolution.
4394 (Binary.CheckShiftArguments): Simplify.
4396 2006-06-01 Raja R Harinath <rharinath@novell.com>
4398 * flowanalysis.cs (MyBitVector): Simplify representation.
4399 (MyBitVector.Clone): Avoid allocating BitArray.
4400 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4401 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4402 (*): Update. Change all references to MyBitVector.And and
4403 MyBitVector.Or to &= and |=.
4405 2006-05-29 Raja R Harinath <rharinath@novell.com>
4408 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4409 to param arguments too.
4411 2006-05-26 Miguel de Icaza <miguel@novell.com>
4413 * cs-parser.jay: Catch another parsing form for arglist being
4414 followed by other arguments. Fixes #78313.
4416 2006-05-24 Raja R Harinath <rharinath@novell.com>
4418 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4419 checking of out parameters to ...
4420 (FlowBranchingToplevel.Merge): ... here.
4421 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4422 set, propagate the origin upward, and only complain if there was
4424 (FlowBranchingException.AddContinueOrigin): Likewise.
4425 (FlowBranchingException.AddReturnOrigin): Likewise.
4426 (FlowBranchingException.AddGotoOrigin): Likewise.
4428 2006-05-23 Raja R Harinath <rharinath@novell.com>
4430 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4431 unreachable, skip it.
4432 (FlowBranchingException.Merge): Always propagate jumps, even if
4433 the finally block renders subsequent code unreachable.
4435 2006-05-18 Raja R Harinath <rharinath@novell.com>
4438 * statement.cs (Goto.Resolve): Move responsibility for resolving
4439 'goto' to FlowBranching.AddGotoOrigin.
4440 (Goto.SetResolvedTarget): New. Callback to set the
4441 LabeledStatement that's the target of the goto.
4442 (Goto.DoEmit): Use Leave instead of Br when crossing an
4443 unwind-protect boundary.
4444 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4445 LookupLabel and adjust to new semantics.
4446 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4447 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4448 Goto.SetResolvedTarget to update target.
4449 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4450 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4451 AddBreakOrigin & co. Delay propagation until ...
4452 (FlowBranchingException.Merge): ... this.
4454 * statement.cs (Block.Resolve): Always depend on flow-branching to
4455 determine unreachability. Kill workaround that originally emitted
4456 only one statement after an "unreachable" label (see infloop in
4459 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4460 This is still "wrong", but anything better would probably need a
4461 multi-pass algorithm.
4462 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4463 usage vector. Force current usage vector to be reachable, to
4464 optimistically signify backward jumps.
4465 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4467 (FlowBranchingLabeled.Merge): New. If no backward jump was
4468 detected, return the original salted-away usage vector instead,
4469 updated with appropriate changes. Print unreachable warning if
4471 * statement.cs (Block.Resolve): Don't print unreachable warning on
4472 a labeled statement.
4474 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4476 * driver.cs: Pass filename without path to AssemblyBuilder's
4477 AddResourceFile. Fixes bug #78407.
4479 2006-05-17 Raja R Harinath <rharinath@novell.com>
4481 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4482 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4483 (FlowBranching.MergeChild): Overwrite
4484 reachability information from Labeled branchings too.
4486 2006-05-16 Raja R Harinath <rharinath@novell.com>
4488 * statement.cs (Goto.Resolve): Merge jump origins here ...
4489 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4491 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4492 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4493 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4494 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4496 * statement.cs (Goto.Resolve): ... not here.
4497 (Goto.Emit): Remove CS1632 check.
4499 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4501 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4504 2006-05-11 Raja R Harinath <rharinath@novell.com>
4506 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4507 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4508 (FlowBranchingException.Label): Likewise.
4510 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4512 (MyBitVector.Or): Use it to avoid losing information (Count).
4513 (FlowBranching.MergeOrigins): Likewise.
4515 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4516 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4517 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4518 (UsageVector.ToString): Simplify.
4519 (UsageVector.MergeSiblings): Move here from ...
4520 (FlowBranching.Merge): ... here.
4521 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4524 2006-05-10 Raja R Harinath <rharinath@novell.com>
4526 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4527 null bitvector is treated as all-true.
4529 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4530 (MyBitVector): Rationalize invariants. 'vector != null' implies
4531 that we have our own copy of the bitvector. Otherwise,
4532 'InheritsFrom == null' implies all inherited bits are true.
4534 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4536 * statement.cs (LocalInfo): Add IsConstant.
4537 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4538 local variable for constants.
4540 2006-05-09 Raja R Harinath <rharinath@novell.com>
4542 * flowanalysis.cs (MyBitVector.Empty): New.
4543 (MyBitVector): Don't allow InheritedFrom to be null.
4544 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4545 (UsageVector, FlowBranching): Update to changes.
4547 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4548 recursion. The 'Parent == null' condition isn't sufficient for
4550 (FlowBranching.AddBreakOrigin): Likewise.
4551 (FlowBranching.AddContinueOrigin): Likewise.
4552 (FlowBranching.AddReturnOrigin): Likewise.
4553 (FlowBranching.StealFinallyClauses): Likewise.
4554 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4555 (FlowBranching.CheckOutParameters): Likewise.
4556 (FlowBranchingToplevel): Terminate all the above recursions here.
4557 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4558 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4560 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4562 (FlowBranchingToplevel): New. Empty for now.
4563 (FlowBranching.MergeTopBlock): Update.
4564 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4565 branching for the anonymous delegate.
4566 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4568 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4569 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4570 information at the start of the merge. Reorganize.
4572 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4574 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4576 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4578 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4579 to newly introduced ctor.
4581 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4582 message to one place.
4583 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4586 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4588 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4590 * ecore.cs (Expression.ResolveAsConstant): Updated.
4592 * statement.cs (ResolveMeta): Updated.
4594 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4596 * cs-parser.jay: __arglist cannot be used in initializer.
4598 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4601 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4604 2006-05-05 Raja R Harinath <rharinath@novell.com>
4606 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4607 (LabeledStatement): Add 'name' parameter.
4608 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4609 (Block.AddLabel): Update to changes.
4610 * cs-parser.jay (labeled_statement): Likewise.
4612 * flowanalysis.cs (BranchingType.Labeled): New.
4613 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4614 (FlowBranchingLabeled): New. Does nothing for now, but will
4615 eventually handle 'goto' flows.
4616 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4617 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4618 that's terminated ...
4619 (Block.Resolve): ... here.
4621 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4622 (UsageVector.MergeFinallyOrigins): Likewise.
4623 (FlowBranching.InTryOrCatch): Likewise.
4624 (FlowBranching.AddFinallyVector): Likewise.
4625 (FlowBranchingException): Update to changes.
4628 * statement.cs (Return.Resolve): Move error checking to ...
4629 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4630 (FlowBranchingException): Handle return origins like break and
4632 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4634 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4637 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4640 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4643 * class.cs (MethodData.Define): Do public accessor check only when method
4644 implements an interface.
4646 2006-05-04 Raja R Harinath <rharinath@novell.com>
4648 Remove special handling of 'break'
4649 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4650 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4651 (UsageVector.Break): Remove.
4652 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4654 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4656 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4657 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4659 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4662 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4663 be the interface member.
4665 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4668 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4669 for emitting small (int) values.
4671 2006-05-03 Raja R Harinath <rharinath@novell.com>
4674 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4675 control-flow passes through the 'finally' after merging-in all the
4676 control-flows from 'try' and the 'catch' clauses.
4678 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4679 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4680 always true at the only non-recursive entry point.
4681 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4682 FlowBranchingBreakable.
4683 (FlowBranchingLoop): Remove.
4684 * statement.cs (Return.DoResolve): Update to changes.
4687 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4688 (FlowBranching.CreateBranching): Handle it: create a
4689 FlowBranchingContinuable.
4690 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4691 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4692 except that it handles the 'continue' command.
4693 (FlowBranching.UsageVector.MergeOrigins): Rename from
4695 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4696 except that it overrides AddContinueOrigin.
4697 (FlowBranchingException): Override AddContinueOrigin, similar to
4699 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4700 Create a new branching around the embedded statement.
4701 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4702 control flow after the embedded statement.
4703 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4705 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4706 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4707 FlowBranchingBreakable.
4708 (FlowBranchingSwitch): Remove.
4711 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4712 error reporting to ...
4713 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4714 Rename from 'AddBreakVector'. Add new location argument. Return
4715 a bool indicating whether the 'break' crosses an unwind-protect.
4716 (FlowBranchingException.AddBreakOrigin): Add.
4717 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4718 flowbranching after updating with the effects of the 'finally'
4720 (FlowBranchingBreakable): New common base class for
4721 FlowBranchingLoop and FlowBranchingSwitch.
4723 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4725 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4727 2006-05-02 Raja R Harinath <rharinath@novell.com>
4729 * statement.cs (Do.Resolve): If the loop is infinite, set the
4731 (While.Resolve, For.Resolve): Set a barrier after the embedded
4732 statement. There's no direct control flow that goes from the end
4733 of the embedded statement to the end of the loop.
4734 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4735 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4736 above ensure that the reachability is correctly computed.
4738 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
4739 (UsageVector.MergeBreakOrigins): If the current path is
4740 unreachable, treat it as if all parameters/locals are initialized.
4741 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
4742 infinite loops before merging-in break origins.
4744 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
4745 (Reachability.Reachable): Split part into ...
4746 (Reachability.Unreachable): ... this. Simplify.
4747 (Reachability.IsUnreachable): Use 'Unreachable' instead.
4749 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
4750 (Reachability.SetThrowsSometimes): Likewise.
4751 (FlowBranchingBlock.MergeTopBlock): Don't compare against
4752 TriState.Always, use corresponding property.
4753 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
4754 (Block.Resolve): Likewise. Remove some redundant checks.
4756 2006-05-02 Raja R Harinath <harinath@gmail.com>
4758 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
4759 (Reachability.Meet): Don't bother checking AlwaysThrows --
4760 barrier is always set.
4761 (FlowBranchingBlock.Merge): Likewise.
4763 2006-05-01 Raja R Harinath <harinath@gmail.com>
4765 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
4766 checks for unreachable.
4768 2006-05-01 Marek Safar <marek.safar@seznam.cz>
4771 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
4773 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
4774 whether field is really assigned.
4776 2006-04-30 Raja R Harinath <harinath@gmail.com>
4778 * flowanalysis.cs (Reachability): Make 4-argument constructor
4780 (Reachability.Meet): Rename from 'And'. Remove static variant.
4781 (Reachability.Always): Rename from the highly misleading
4782 'Reachability.Never'.
4783 (FlowBranching.Merge): Update to changes. Mark an impossible
4784 situation with a 'throw'.
4785 (*): Update to changes.
4787 2006-04-29 Raja R Harinath <harinath@gmail.com>
4789 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
4791 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
4792 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
4793 (*): Update to changes.
4794 * statement.cs: Update to changes.
4796 2006-04-28 Marek Safar <marek.safar@seznam.cz>
4799 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
4801 2006-04-28 Raja R Harinath <harinath@gmail.com>
4803 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
4806 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
4807 argument to two arguments: an usage-vector and a bool. Move call
4808 to FlowBranching.Merge () ...
4809 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
4811 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
4812 handling of loop and switch reachability to ...
4813 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
4815 2006-04-27 Raja R Harinath <harinath@gmail.com>
4817 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
4818 handling to FlowBranchingLoop.InLoop.
4819 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
4821 2006-04-26 Marek Safar <marek.safar@seznam.cz>
4824 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
4825 anonymous method is allowed from AnonymousContainer here.
4827 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
4829 2006-04-24 Raja R Harinath <rharinath@novell.com>
4832 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
4834 2006-04-23 Marek Safar <marek.safar@seznam.cz>
4837 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
4838 (DoubleConstant.Reduce): Ditto.
4840 2006-04-23 Raja R Harinath <rharinath@novell.com>
4842 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
4843 Remove 'lvalue_right_side' argument. Move parts to ...
4844 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
4845 (LocalVariable.DoResolveLValue): ... these.
4847 2006-04-21 Raja R Harinath <rharinath@novell.com>
4850 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
4851 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
4852 (LocalVariableReference.DoResolveBase): Use it to implement new
4854 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
4855 (Argument.Resolve): Simplify. Move CS1510 check ...
4856 * ecore.cs (Expression.ResolveLValue): ... here.
4857 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
4858 (PropertyExpr.DoResolveLValue): Likewise.
4859 (FieldExpr.Report_AssignToReadonly): Likewise.
4860 (FieldExpr.DoResolve): Add 'out_access' argument. Use
4861 LValueMemberAccess or LValueMemberOutAccess on instance depending
4863 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
4864 DoResolve as appropriate.
4866 2006-04-20 Raja R Harinath <rharinath@novell.com>
4869 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
4870 implicit conversions on 'out' and 'ref' arguments.
4872 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
4873 improve clarity. Remove dead code.
4876 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
4877 (Catch.Resolve): Resolve VarBlock if it exists.
4879 2006-04-19 Miguel de Icaza <miguel@novell.com>
4881 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
4882 twice, this was some residual code, the enumerator was emitted
4883 properly in the two branche of if later.
4885 2006-04-19 Raja R Harinath <rharinath@novell.com>
4887 * expression.cs (Cast.ResolveLValue): Remove. The result of a
4888 cast is never an lvalue.
4889 (Cast.DoResolve, Cast.ResolveRest): Combine.
4890 (Argument.Emit): Simplify slightly. Move 'Expr is
4891 IMemoryLocation' check ...
4892 (Argument.Resolve): ... here.
4893 (Argument.Error_LValueRequired): Remove. Inline into only user.
4895 Simplifications. Fix cs0191-2.cs
4896 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
4897 CS1649 and CS1651 to ...
4898 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
4899 the actual selection of the error code and message to a lookup
4900 table. Add a dummy return value to simplify callsites.
4901 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
4902 readonly fields of other instances of the same type. Move CS0197
4904 * expression.cs (Argument.Resolve): ... here. Simplify code.
4905 Ensure that ec.InRefOutArgumentResolving is only set during LValue
4906 resolution of an out or ref argument. The code simplification
4907 above uses this invariant.
4909 2006-04-18 Raja R Harinath <rharinath@novell.com>
4911 Possibly fix #77752. Fix cs1690-[4-7].cs.
4912 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
4913 CheckMarshallByRefAccess. Drop parameter.
4914 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
4916 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
4918 * report.cs (AllWarnings): Add CS1690.
4919 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
4921 (LocalVariableReference.DoResolveBase): Update.
4923 2006-04-09 Marek Safar <marek.safar@seznam.cz>
4925 * class.cs (MethodOrOperator): Moved common parts from method class.
4926 detect obsolete attributes.
4927 (Method.Define): Simplified as it reuses code from base.
4928 (Constructor.ValidAttributeTargets): Fixed issue found during
4930 (Destructor.ValidAttributeTargets): Fixed issue found during
4932 (Operator): Finished refactoring set off by #78020. Operator class is now
4933 ordinary method class.
4935 * anonymous.cs: Updated.
4937 * decl.cs (DeclSpace): Add IsGeneric
4939 2006-04-09 Marek Safar <marek.safar@seznam.cz>
4941 * class.cs (Constructor.Emit): Don't emit the attributes twice.
4943 2006-04-09 Marek Safar <marek.safar@seznam.cz>
4945 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
4946 detect obsolete attributes.
4947 (Method.CreateEmitContext): Moved to MethodOrOperator.
4949 2006-04-09 Marek Safar <marek.safar@seznam.cz>
4952 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
4953 customized exception to make crash detection easier.
4954 (MethodOrOperator): Started to work on new base class for methods and
4956 (Method): Derives from MethodOrOperator.
4957 (Constructor.Emit): Emits its own attributes.
4958 (AbstractPropertyEventMethod.Emit): Ditto.
4959 (Operator): Derives from MethodOrOperator, will refactor fully in extra
4961 (Operator.Emit): It's temporary more tricky than should be.
4963 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
4965 * report.cs (InternalErrorException): Add ctor with inner exception.
4967 2006-04-08 Marek Safar <marek.safar@seznam.cz>
4970 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
4973 2006-04-07 Marek Safar <marek.safar@seznam.cz>
4976 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
4979 2006-04-06 Marek Safar <marek.safar@seznam.cz>
4981 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
4982 attribute is present and Guid not.
4983 (Interface.ApplyAttributeBuilder): Ditto.
4985 * attribute.cs: Add error message.
4987 2006-04-06 Marek Safar <marek.safar@seznam.cz>
4991 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
4992 sources (it's composite) so hold them in extra array as they are used in
4993 Emit phase only. It worked in the previous versions by mistake.
4994 (Attribute.Emit): Emit attribute for more owners when exist.
4996 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
4997 it has now different behaviour.
4999 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5001 * constant.cs (Constant.IsDefaultInitializer): New method.
5003 * class.cs: Updated.
5005 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5006 re-initialize default values. It saves KBs almost for every assembly.
5007 Thanks Zoltan for the idea.
5008 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5009 (ArrayCreation.DoResolve): Resolve only once.
5010 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5011 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5013 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5015 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5018 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5020 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5021 in an embedded statement too.
5023 2006-04-01 Raja R Harinath <rharinath@novell.com>
5026 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5028 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5032 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5035 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5037 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5039 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5042 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5043 LocalTemporary change.
5045 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5047 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5048 initializers optimization.
5049 (ClassOrStruct.TypeAttr): Moved from modifiers.
5050 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5051 (FieldBase.ResolveInitializer): Resolves initializer.
5052 (FieldBase.HasDefaultInitializer): New property.
5054 * cs-parser.jay: Removed message.
5056 * expression.cs (CompilerGeneratedThis): New specialization.
5058 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5060 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5062 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5064 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5066 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5067 be now EnumConstants only.
5069 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5071 * attribute.cs, driver.cs: Reset more caches.
5073 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5075 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5077 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5079 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5080 for easier reuse. Updated all overrides.
5081 (IntegralConstant): New base class for all integral constants.
5082 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5083 of the constant range, report custom error.
5084 (UIntConstant.Reduce): Fixed uint conversion.
5086 * ecore.cs, literal.cs: Reduce updates.
5088 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5092 * class.cs (Constructor.Define): Removed extra if for default ctors.
5093 A patch from Atsushi Enomoto.
5095 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5097 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5098 GetAttributableValue.
5100 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5103 * convert.cs (ImplicitConversionRequired): Error message moved to
5106 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5107 automatic implicit conversion of an output value.
5108 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5110 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5112 (TypeOf.GetAttributableValue): Add extra handling for object type.
5114 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5115 special error message.
5117 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5119 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5121 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5122 compatible with MS runtime.
5124 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5126 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5127 attribute arguments here.
5129 * class.cs (Indexer.Define): The check was moved to attribute class.
5131 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5133 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5134 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5137 2006-03-22 Raja R Harinath <rharinath@novell.com>
5139 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5140 mcs to keep code differences small.
5141 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5142 * typemanager.cs (parameter_default_value_attribute_type): New.
5143 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5146 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5148 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5150 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5152 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5154 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5157 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5159 * doc-bootstrap.cs : fix build.
5161 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5163 * expression.cs (StringConcat.Append): Issue a warning when empty string
5166 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5168 * assign.cs (CompoundAssign.ResolveSource): Removed.
5170 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5173 * class.cs (TypeContainer.FindMethods): Removed.
5174 (TypeContainer.CheckMemberUsage): Made static.
5176 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5178 * constant.cs (CheckRange): Removed unused type argument.
5179 (CheckUnsigned): Removed unused type argument.
5181 * cs-parser.jay: Updated after MemberAccess clean up.
5182 Uses Length for empty string test.
5184 * cs-tokenizer.cs: Uses Length for empty string test.
5185 (IsCastToken): Made static.
5186 (is_hex): Made static.
5187 (real_type_suffix): Made static.
5189 * decl.cs (SetupCache): Made static.
5190 (OnGenerateDocComment): Removed unused ds argument.
5192 * delegate.cs (VerifyDelegate): Removed unused argument.
5194 * doc.cs: Uses Length for empty string test.
5196 * driver.cs: Uses Length for empty string test.
5198 * enum.cs (IsValidEnumType): Made static
5200 * expression.cs (EnumLiftUp): Removed unused argument.
5201 (ResolveMethodGroup): Ditto.
5202 (BetterConversion): Ditto.
5203 (GetVarargsTypes): Ditto.
5204 (UpdateIndices): Ditto.
5205 (ValidateInitializers): Ditto.
5206 (MemberAccess.ctor): Ditto.
5207 (GetIndexersForType): Ditto.
5209 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5211 * iterators.cs: Updated after MemberAccess clean up.
5213 * location.cs: Uses Length for empty string test.
5215 * namespace.cs: Uses Length for empty string test.
5217 * report.cs (CheckWarningCode): Made static.
5219 * statement.cs (LabeledStatement): Removed unused argument.
5221 * typemanager.cs (FilterNone): Removed.
5223 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5225 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5228 * class.cs: Updated.
5230 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5232 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5234 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5238 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5239 reporting, it's more tricky than I thought.
5241 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5245 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5247 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5248 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5249 Add more error reporting; Fixed issue with params.
5251 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5253 * cs-parser.jay: AnonymousMethod requires host container.
5255 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5257 2006-03-18 Raja R Harinath <harinath@gmail.com>
5259 * class.cs: Change 'TypeContainer ds' constructor argument to
5260 'DeclSpace parent'. Some classes were missed below due to
5261 different naming convention.
5263 * class.cs (MemberCore.Parent): Delete. This makes the
5264 ParentContainer changes below enforceable by the compiler.
5266 Treat pointers to enclosing declaration space as 'DeclSpace', not
5268 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5269 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5271 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5273 (Block.AddThisVariable): Likewise.
5274 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5275 (AbstractPropertyEventMethod.Emit): Likewise.
5276 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5277 (GetMethod.Define, SetMethod.Define): Likewise.
5278 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5279 (DelegateMethod.EmitMethod): Likewise.
5281 Fix regression test-partial-13.cs.
5282 Rationalize use of PartialContainer. Ensure that the partial
5283 class semantics can be tied to type-correctness, i.e., any
5284 violation will cause a compile error.
5285 * class.cs, const.cs: Access all fields that belong to class
5286 TypeContainer via ParentContainer. Arguments of EmitContexts and
5287 Resolve()-like functions still use 'Parent'.
5289 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5290 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5291 (PropertyMethod.CheckModifiers): Remove unused argument.
5292 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5295 2006-03-17 Raja R Harinath <harinath@gmail.com>
5297 Make semantics of PartialContainer simpler.
5298 * decl.cs (DeclSpace.IsPartial): Remove.
5299 * class.cs (TypeContainer.IsPartial): Likewise.
5300 (TypeContainer..ctor): Set PartialContainer to point to self.
5301 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5302 (TypeContainer.FindNestedType): Likewise.
5303 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5305 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5307 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5309 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5311 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5314 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5316 * class.cs (Operator.Define): An error for base conversion was not
5319 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5321 * iterator.cs : yield break is allowed in try statement which has
5322 catch clauses. Fixed bug #77767.
5324 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5326 A fix for #77593, #77574.
5328 * class.cs (MethodCore.CheckBase): Another if for operator.
5330 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5332 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5335 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5336 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5339 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5342 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5343 Updated after another emitcontext usage was clean up. It should help us to
5344 synchronize with gmcs easier.
5346 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5350 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5351 (Event.Define): ditto
5352 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5354 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5355 Removed redundant code and set NewSlot for Invoke method too.
5357 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5358 (Parameters.MergeGenerated): New method. Use this method when you merge
5359 compiler generated argument with user arguments.
5361 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5363 * attribute.cs (ResolveAsTypeTerminal): Removed.
5365 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5366 specialization for predefined types; 30% speed up.
5367 Finally placed obsolete check to right place.
5368 (Expression.ResolveType): Removed.
5370 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5371 Updated after ResolveType was removed.
5373 * expression.cs (Cast.ctor): Check void cast.
5374 (Binary.ResolveAsTypeTerminal): Is never type.
5375 (Conditional.ResolveAsTypeTerminal): Is never type.
5377 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5379 2006-03-01 Raja R Harinath <rharinath@novell.com>
5382 * expression.cs (ParameterReference.DoResolveBase): Change return
5384 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5388 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5391 * typemanager.cs (GetFullNameSignature): Don't nullref on
5392 protected accessors.
5394 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5396 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5397 these two separated members to simplify the code.
5398 (Attribute.Resolve): Refactored to use new fields and methods.
5399 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5400 implemented obsolete attribute checking.
5401 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5402 implemented obsolete checking again. It look line never ending quest ;-)
5403 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5405 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5407 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5409 *class.cs (Property.Define): Add RegisterProperty call.
5411 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5412 argument groups (only 2).
5414 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5415 encoding expression to arguments.
5416 (Expression.ExprClassToResolveFlags): Just turned to property.
5418 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5419 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5420 optimized as well as implemented support for zero-length attributes.
5422 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5423 Add caching of PropertyInfo's.
5425 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5427 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5428 error multiple times.
5430 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5432 New partial class implementation.
5433 A fix for #77027, #77029, #77403
5435 * attribute.cs (Attributable): Made attributes protected.
5437 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5438 the replacements of ClassPart and PartialContainer.
5439 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5440 (TypeContainer.AddInterface): Ditto.
5441 (TypeContainer.AddPartial): The main method for partial classes. It checks
5442 for errors and merges ModFlags and attributes. At the end class is added to
5444 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5446 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5447 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5448 from the rest of partial classes.
5449 (TypeContainer.GetClassBases): Simplified.
5450 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5452 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5453 (TypeContainer.HasExplicitLayout): Uses Flags now.
5454 (PartialContainer): Removed.
5455 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5456 (StaticClass): Was merged with Class.
5457 (Class.GetClassBases): class and static class bases are verified here.
5458 (Class.TypeAttr): Added static attributes when class is static.
5459 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5460 (MemberBase): In some cases we need to call parent container for partial
5461 class. It should be eliminated but it's not easy now.
5463 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5465 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5466 partial classed to accumulate class comments.
5467 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5469 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5471 * driver.cs (MainDriver): Tree.GetDecl was removed.
5473 * modifiers.cs (Modifiers): Add partial modifier.
5475 * tree.cs (Tree.decl): Removed.
5476 (RootTypes): Started to use this class more often for root types
5479 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5483 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5484 external interface does not have an attribute.
5486 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5488 Another prerequisites for new partial classs implementation.
5490 * attribute.cs (Attribute.Equal): Implemented.
5491 (Attribute.Emit): Changed as attributes can be applied more than twice.
5492 (Attributes.Emit): Check for duplicate attributes here.
5494 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5495 as a parameter, clean-up.
5497 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5501 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5502 contains obsolete attribute check which can in some cases look for base
5503 type of current class which is not initialized yet.
5504 (TypeContainer.BaseType): Replacement of ptype.
5506 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5508 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5510 First of prerequisites for new partial classs implemention.
5512 * attribute.cs (Attributable): Extended by ResolveContext;
5513 Attributes finally have correct context for resolving in all cases.
5514 (AttachTo): Attribute owner is assigned here.
5516 * codegen.cs (IResolveContext): Introduce new interface to hold
5517 all information needed in resolving phase.
5518 (EmitContext): Implements IResolveContext; more clean-up needed here.
5520 * decl.cs (MemberCore): Implemented IResolveContext.
5522 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5523 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5524 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5525 Refactored to use new IResolveContext instead of EmitContext; cleanup
5527 2006-02-06 Miguel de Icaza <miguel@novell.com>
5529 * codegen.cs (EmitScopeInitFromBlock): check here the
5530 capture_context, there is no need to make two calls to the
5533 * anonymous.cs: Add some debugging messages that might help me
5534 track other instances of this problem in the future (the
5535 regression of test 467).
5537 * cs-parser.jay: track the variable block, as we need to initalize
5538 any captured variables declared in this block for the "catch"
5539 portion of the "Try" statement.
5541 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5542 scope initialization for captured variables.
5544 Also, move the emit for the variables after the block location has
5547 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5549 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5551 2006-02-02 Miguel de Icaza <miguel@novell.com>
5553 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5554 commit yesterday, the initialization for the roots is necessary.
5555 What is not necessary is the scope activation.
5557 2006-02-02 Raja R Harinath <rharinath@novell.com>
5559 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5560 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5562 (Argument.Resolve): Remove CS0206 checks.
5564 2006-02-01 Miguel de Icaza <miguel@novell.com>
5566 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5567 scopes for all the roots, the scopes will now be emitted when the
5568 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5570 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5571 code. This reduces a lot of existing cruft.
5573 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5574 that the ScopeInfo is generated as we enter the scope, not at the
5575 time of use, which is what we used to do before.
5577 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5578 every time a Block is about to be emitted if we have a
5581 2006-02-01 Raja R Harinath <rharinath@novell.com>
5583 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5585 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5587 * typemanager.cs (cons_param_array_attribute): Make private.
5588 (Reset): Set it to null.
5589 (InitCoreHelpers): Don't initialize it.
5590 (ConsParamArrayAttribute): New. Initialize it as needed.
5591 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5593 2006-01-31 Miguel de Icaza <miguel@novell.com>
5595 * expression.cs: There might be errors reported during the
5596 selection of applicable methods. If there are errors, do not
5597 continue execution as it will lead the compiler to crash.
5599 2006-01-30 Miguel de Icaza <miguel@novell.com>
5601 * expression.cs: Member access is not allowed on anonymous
5602 methods. Fixes #77402.
5604 2006-01-30 Raja R Harinath <rharinath@novell.com>
5607 * cs-parser.jay (VariableDeclaration): Don't set
5608 current_array_type to null.
5609 (field_declaration, event_declaration, declaration_statement):
5610 Set it to null here.
5612 2006-01-28 Raja R Harinath <harinath@gmail.com>
5614 * typemanager.cs (GenericParameterPosition): New.
5617 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5619 * doc.cs : To process "include" elements, first we should create
5620 another list than XmlNodeList, because it could result in node
5621 removal, which could result in that the XmlNodeList gives up
5624 (Also made code identical to gmcs again.)
5626 2006-01-25 Miguel de Icaza <miguel@novell.com>
5628 * ecore.cs: Introduce an error report that we were not catching
5629 before, if not silent, we must report the error. Gonzalo ran into
5632 2006-01-23 Miguel de Icaza <miguel@novell.com>
5634 A fix for bug: #76957
5636 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5637 ComputeMethodHost before creating the method, this is a new
5640 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5641 that this method references (RegisterScope). The actual scope
5642 where the method is hosted is computed with the ComputeMethodHost
5643 before we create the method.
5645 Moved the Deepest routine here.
5647 (AnonymousContainer.ComputeMethodHost): New routine used to
5648 compute the proper ScopeInfo that will host the anonymous method.
5650 (ScopeInfo): Deal with multiple roots. The problem was that we
5651 did not have a unique root where all ScopeInfos could be hanged
5652 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5655 Remove AdjustMethodScope which is now computed at the end. Remove
5656 LinkScope which did a partial link, instead link all ScopeInfos
5657 before code generation from the new "LinkScopes" routine.
5659 Simplify all the Add* routines as they no longer need to maintain
5660 the tree, they just need to record that they are using variables
5663 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5664 routines to produce the forest of ScopeInfo trees.
5666 * class.cs (TypeContainer.AppendMethod): This is just like
5667 AddMethod, but ensures that an interface implementation method
5668 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5669 methods, but at the end.
5671 We use this functionality to ensure that the generated MoveNext
5672 method in the iterator class is resolved/emitted before the
5673 enumerator methods created.
5675 This is required because the MoveNext method computes the right
5676 ScopeInfo for the method. And the other methods will eventually
5677 need to resolve and fetch information computed from the anonymous
5680 2006-01-21 Raja R Harinath <harinath@gmail.com>
5681 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5684 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5686 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5687 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5689 2006-01-18 Raja R Harinath <rharinath@novell.com>
5691 Fix #76656, cs0231-2.cs.
5692 * cs-parser.jay (formal_parameter_list): Make error case catch
5694 (parenthesized_expression_0): Add CS1026 check.
5695 (invocation_expression): Remove unused { $$ = lexer.Location }.
5697 2006-01-17 Raja R Harinath <rharinath@novell.com>
5700 * cs-parser.jay (statement_expression): Don't list out the
5701 individual statement-expressions. Convert syntax error into
5704 2006-01-16 Raja R Harinath <rharinath@novell.com>
5707 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5708 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5709 CheckIntermediateModification.
5710 (FieldExpr.DoResolve): Add new two-argument version that
5711 allows us to resolve the InstanceExpression as an lvalue.
5712 The one-argument variant is now just a wrapper.
5713 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5714 Resolve the lhs as an lvalue if the it has a value type.
5715 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5716 from Assign.DoResolve.
5717 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5718 resolved as an lvalue.
5719 (PropertyExpr.DoResolve): Update.
5720 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5721 has a value type. Move CS1612 check here from
5722 CheckIntermediateModification.
5723 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5724 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5725 'right_side' of a ResolveLValue on an 'out' argument.
5726 (EmptyExpression.LValueMemberAccess): New. Used as the
5727 'right_side' of a propagated ResolveLValue on a value type.
5728 (LocalVariableReference.DoResolveBase): Recognize
5729 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5731 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5732 EmptyExpression.Null.
5734 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5736 * typemanager.cs : added IsGenericParameter(). In mcs it always
5738 * doc.cs : for generic parameters, use GenericParameterPosition,
5741 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
5743 * expression.cs: Fix Console.WriteLine ((this = x).foo);
5745 2006-01-12 Miguel de Icaza <miguel@novell.com>
5747 This fixes the problem where we used ldfld instead of ldflda to
5748 load the "THIS" pointer on captured parameters, when THIS is a
5749 value type. See bug #77205.
5751 * iterators.cs (CapturedThisReference.Emit): Pass false to
5752 EmitThis (we do not need the address).
5754 * codegen.cs (EmitThis): it needs to know whether we need the
5755 address of `this' or not. This is used by value types.
5757 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
5758 every other call passes false.
5760 2006-01-12 Raja R Harinath <rharinath@novell.com>
5763 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
5765 * expression.cs (Invocation.OverloadResolve): Update.
5766 (Invocation.DoResolve): Avoid double resolution of invocation.
5768 2006-01-11 Raja R Harinath <rharinath@novell.com>
5771 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
5772 unary negation of floating point types as 0-expr; negation cannot
5773 overflow in floating point types.
5776 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
5777 on operands of 'void' type.
5780 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
5781 and ExclusiveOr for boolean constants too.
5783 2006-01-09 Raja R Harinath <rharinath@novell.com>
5786 * expression.cs (Invocation.OverloadResolve): Replace reflected
5787 override methods with their base virtual methods, rather than
5789 * typemanager.cs (TypeManager.GetOverride): New.
5791 2006-01-05 Jb Evain <jbevain@gmail.com>
5793 * class.cs (Property.Define, Indexer.Define): do not tag the
5794 properties as SpecialName | RTSpecialName.
5796 2006-01-04 Miguel de Icaza <miguel@novell.com>
5798 * class.cs (MethodCore.IsDuplicateImplementation): This method was
5799 doing a low-level comparission of parameter types. It was lacking
5800 a check for __argslist.
5802 2005-12-30 Miguel de Icaza <miguel@novell.com>
5804 * expression.cs (ParameterReference.DoResolveBase): Allow
5805 reference parameters if they are local to this block.
5807 This allows the ref and out parameters of a delegate to be used in
5808 an anonymous method, for example:
5810 delegate void set (out int x);
5812 set s = delegate (out int x){
5816 This is used by functionality introduced late in the C# language.
5818 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
5819 method that take ref and out parameters.
5821 Fixes #77119 which was a late change in the spec.
5823 2005-12-23 Miguel de Icaza <miguel@novell.com>
5825 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
5826 parent if its the same scope. Fixes #77060.
5828 2005-12-21 Miguel de Icaza <miguel@novell.com>
5830 * driver.cs: Report the case of no source files and no -out:
5833 2005-12-20 Raja R Harinath <rharinath@novell.com>
5836 * expression.cs (ComposedCast.GetSignatureForError): Define.
5838 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5842 * namespace.cs (NamespaceEntry): Add extern_aliases as a
5843 ListDictionary, to contain the ExternAliasEntry entries (in
5844 addition to the NamespaceEntry.aliases hashtable). This field is
5845 shared between the original entry and its doppelganger (bodyless
5847 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
5848 extern_aliases field.
5849 (NamespaceEntry.Lookup): Move the IsImplicit check after the
5850 lookup in extern_aliases.
5852 2005-12-16 Raja R Harinath <rharinath@novell.com>
5855 * class.cs (TypeContainer.Mark_HasEquals): New.
5856 (TypeContainer.Mark_HasGetHashCode): New.
5857 (ClassPart): Override them.
5858 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
5861 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
5862 'parent' argument to the base constructor.
5864 Remove all mention of TypeContainer from decl.cs.
5865 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
5866 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
5867 (DeclSpace.DeclSpace): Likewise.
5868 (DeclSpace.DefineMembers): Remove unused argument.
5869 * cs-parser.jay (pop_current_class): Update to changes. Simplify
5870 debugging check -- we don't care if the debug code throws an
5871 InvalidCastException instead of an InternalErrorException.
5872 * class.cs (TypeContainer.DefineMembers): Update to changes.
5873 (TypeContainer.DoDefineMembers): Likewise.
5874 (TypeContainer.GetMethods): Likewise.
5875 (PropertyMember.Define): Likewise.
5876 (MemberBase.Parent): New property that forwards to
5877 MemberCore.Parent, but ensures that we get a TypeContainer.
5878 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
5879 (RootContext.PopulateTypes): Likewise. Remove special case code
5880 for !RootContext.StdLib: DefineMembers is idempotent.
5882 2005-12-14 Miguel de Icaza <miguel@novell.com>
5884 * convert.cs (ExplicitConversionCore): Check the return value from
5885 ExplicitConversionCore which can return null on failure. Fixes #76914
5887 2005-12-13 Marek Safar <marek.safar@seznam.cz>
5889 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
5891 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
5893 * doc.cs : The search for referenced namespace was insufficient to
5894 get global one as it used to do. Fixed bug #76965.
5896 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
5898 * doc.cs : check name in cref in the last phase that whether it is
5901 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
5903 * cs-tokenizer.cs : reverted the latest change: it somehow broke
5906 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
5908 * doc.cs : so it turned out that we cannot skip override check for
5909 interface members. Fixed bug #76954.
5911 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
5913 * cs-tokenizer.cs : fixed bug #75984:
5914 - #warning and #error should not be handled when the source line
5916 - #line is not checked strictly when the source line is disabled.
5917 - #define and #undef is on the other hand checked strictly at any
5920 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
5922 * cs-tokenizer.cs : missing Location (actually, filename) in one of
5925 2005-12-05 Marek Safar <marek.safar@seznam.cz>
5927 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
5929 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
5931 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
5932 (FieldBase.Initializer): Initializer is now optional.
5933 (EventField.Define): Only event field can have initializer.
5935 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
5937 * const.cs (Const): Reuse initializer.
5939 * cs-parser.jay: Updated after FieldBase changes.
5940 Added current_array_type to simplify array initializers.
5942 * ecore.cs (NullCast.IsDefaultValue): Implemented.
5944 * expression.cs, iterators.cs: Updated.
5946 * namespace.cs (NamespaceEntry): Made UsingFound private.
5948 2005-12-05 Marek Safar <marek.safar@seznam.cz>
5950 * parameterCollection.cs: Obsolete, removed.
5951 * parser.cs: Obsolete, removed.
5953 2005-12-05 Marek Safar <marek.safar@seznam.cz>
5956 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
5958 * enum.cs (Enum.Define): Set obsolete context here.
5960 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
5963 - FindDocumentedMember() now expects 1) paramList as null
5964 when "we don't have to check the number of parameters" and
5965 2) Type.EmptyTypes when "there is no arguments".
5966 - Introduced FoundMember struct to hold the exact type which was
5967 used to find the documented member (the above change broke
5968 test-xml-044; it might be better just to use DeclaringType than
5969 what MS does, like this change does, but it depends on usage.)
5971 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
5973 * doc.cs : documented member might be from DeclaringType for nested
5974 types. Fixed bug #76782.
5976 2005-12-03 Ben Maurer <bmaurer@ximian.com>
5978 * anonymous.cs: Have the param code handle leaving copies on the
5979 stack etc. Allows anonymous params to take part in the assignment
5980 code (++, +=, etc). Fixes bug #76550
5982 * expression.cs: Handle the prepare_for_load/leave_copy by passing
5983 it down to the anon code.
5985 * iterators.cs: Use dummy var here
5987 * codegen.cs: Handle new vars
5989 2005-12-01 Marek Safar <marek.safar@seznam.cz>
5992 * class.cs (MethodData.Define): Set proper Obsolete context.
5994 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
5996 (FieldExpr.DoResolve): Ditto.
5998 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6001 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6002 parent is not obsolete.
6004 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6006 * doc.cs : (FindDocumentedMember) find parameterless members first
6007 and get CS0419 in the early stage. Fixed first case of bug #76727.
6009 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6012 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6013 no error was reported.
6015 *expression.cs (Binary.DoResolve): left can be null.
6017 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6020 * class.cs (MethodData.Emit): Parameters should be labeled first.
6022 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6025 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6027 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6029 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6031 * class.cs (MethodCore): Parameter clean up.
6032 (IMethodData): Added ParameterInfo.
6033 (MethodData): Parameter clean up.
6034 (Indexer.Define): Parameter clean up.
6046 * typemanager.cs: Parameter clean up.
6048 * delegate.cs (Define): Get rid of duplicated code.
6050 * expression.cs (ParameterReference): Removed useless parameters
6052 (Invocation): Ditto.
6054 * parameter.cs (ParamsParameter): New class, params specialization.
6055 (ArglistParameter): Attemp to separate arglist.
6056 (Parameter): Refactored to be reusable and faster.
6057 (Parameter.Modifier): Made understandable.
6058 (Parameters): Changed to be used as a class for `this' assembly
6059 parameters. Refactored to use new specialized classes.
6061 * support.cs (ParameterData): Added Types property.
6062 (InternalParameters): Deleted.
6064 2005-08-20 Martin Baulig <martin@ximian.com>
6066 Merging this patch from GMCS to fix #75867.
6068 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6069 scope if we don't already have it.
6071 2005-11-17 Martin Baulig <martin@ximian.com>
6074 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6075 inherit the scope from our parent. Fixes #76653.
6077 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6079 * doc.cs : the previous patch does not actually fix the bug.
6080 PropertyInfo override check is now implemented and really fixed it.
6081 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6083 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6085 * doc.cs : apply "override filter" also to properties.
6088 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6090 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6091 no need to check overrides. For classes, omit those results from
6092 interfaces since they must exist in the class. Fixed bug #76726.
6094 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6096 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6097 with different parameters. Fixed the second problem in #76685.
6099 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6101 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6102 get expected 'protected' access in CheckValidFamilyAccess()).
6105 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6107 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6108 Fixed bug #76705. CS1569 was incorrectly commented out.
6110 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6112 * doc.cs : use Invocation.IsOverride() to do real override check.
6113 * expression.cs : made Invocation.IsOverride() internal.
6115 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6117 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6118 TypeBuilder.FindMembers() and filter overriden base members out.
6121 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6123 * doc.cs : ref/out parameters are represented as '@' (instead of
6124 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6126 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6128 * doc.cs : when there was no '.' in cref to methods in doc comment,
6129 then parameters were missing in the output. Fixed bug #76691.
6131 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6133 * driver.cs : don't output docs when there is an error.
6136 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6139 Now it should detect indexers. Fixed primary concern in bug #76685.
6140 Fixed CS0419 message to not show the identical member signature in
6143 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6145 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6146 instead of Type.FindMembers() since it does not handle events.
6149 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6151 * codegen.cs: Fixed typo (speficied -> specified).
6153 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6156 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6158 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6160 * attribute.cs: Changed error message.
6162 * cs-tokenizer.cs: One more check.
6164 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6166 * statement.cs (Block.Resolve): Ignore empty statement.
6168 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6170 * report.cs: Made error/warning methods more strict to avoid
6173 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6174 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6175 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6176 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6178 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6180 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6181 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6183 * class.cs (TypeContainer.IsComImport): New property.
6184 (Constructor.Define): Create proper ctor for ComImport types.
6186 * expression.cs (New.CheckComImport): Fixed.
6188 2005-11-07 Miguel de Icaza <miguel@novell.com>
6190 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6191 that a parameter has been captured does not mean that we do not
6192 have to do the rest of the processing. This fixes the second part
6193 of #76592. If there was another anonymous method capturing
6194 values in the past, the Scope would never be set for the second
6195 method that captured the same parameter.
6197 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6198 properly manipulate the stack. Second part of fix for #76592.
6200 * expression.cs (New): Add support for invoking "new" on
6201 interfaces that have been flagged with the ComImport attribute and
6202 the CoClass. Fixes #76637
6204 * statement.cs (Try.DoEmit): When a variable is captured, do not
6205 try to emit the vi.LocalBuilder variable as it has been captured.
6206 Create a temporary variable and store the results on the
6207 FieldBuilder. Fixes #76642
6209 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6211 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6213 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6215 * expression.cs (Binary.DoResolve): Added && optimalization.
6217 * typemanager.cs (AddUserType): Removed useless argument.
6219 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6221 * statement.cs (Block.variables): Uses ListDictionary.
6223 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6226 * class.cs (PartialContainer.EmitType): Customized to emit
6227 security attributes.
6228 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6229 for partial classes.
6231 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6234 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6235 access has to be fixed.
6237 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6239 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6242 * ecore.cs (NullCast.Reduce): Implemented.
6244 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6247 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6249 (Foreach.Resolve): Catch null properly.
6251 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6253 * cs-tokenizer.cs: Warning text fix.
6255 * driver.cs: AllWarningNumbers exposed on public interface.
6257 * report.cs (): Reviewed warning numbers.
6258 (IsValidWarning): Use binary search.
6260 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6262 * driver.cs: Implemeted resource visibility.
6263 (Resources): New class for code sharing between /res: and
6266 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6269 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6272 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6275 * ecore.cs (NullCast): Child is contant only.
6277 * literal.cs (NullLiteral.Reduce): null can be converted to any
6280 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6282 * driver.cs: Use Encoding.Default as default code page instead
6285 2005-10-27 Raja R Harinath <rharinath@novell.com>
6288 * expression.cs (Invocation.Error_InvalidArguments): Handle
6289 __arglist parameters.
6290 (Invocation.VerifyArgumentsCompat): Likewise.
6291 * support.cs (ReflectionParameters.GetSignatureForError): Print
6292 __arglist parameters.
6293 (InternalParamters.GetSignatureForError): Likewise.
6294 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6296 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6298 * attribute.cs (GetPropertyValue): Made public.
6300 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6302 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6304 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6307 * driver.cs: Reflect method name change.
6309 * statement.cs (Try.Resolve): Warn when try has both general
6312 * typemanager.cs: runtime_compatibility_attr_type new predefined
6315 2005-10-26 Raja R Harinath <harinath@gmail.com>
6318 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6319 treat it as an empty parameter list.
6321 2005-10-26 Raja R Harinath <rharinath@novell.com>
6324 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6325 ResolveAsTypeStep silent.
6326 * statement.cs (Block.AddConstant): Mark block as used.
6327 (Block.ResolveMeta): Avoid piling on error messages
6328 if a constant initializer resolution fails.
6330 2005-10-25 Raja R Harinath <rharinath@novell.com>
6332 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6334 (NamespaceEntry.VerifyAllUsing): New.
6335 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6336 behaviour. Delegates actual resolution of alias to ...
6337 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6338 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6340 * driver.cs (Driver.MainDriver): Update.
6342 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6343 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6345 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6347 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6348 RootNamespace.DefineNamespacesForAll.
6350 2005-10-24 Raja R Harinath <harinath@gmail.com>
6352 * typemanager.cs (assemblies, external_aliases, modules)
6353 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6354 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6355 overhead. Move resposibility ...
6356 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6357 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6359 2005-10-23 Raja R Harinath <harinath@gmail.com>
6361 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6362 cached_namespaces. Improve usage.
6363 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6364 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6365 Move from GlobalRootNamespace and simplify.
6366 (RootNamespace.Global): Make instance variable.
6367 (RootNamespace.RootNamespace): Add "alias name" parameter.
6368 (GlobalRootNamespace): Simplify drastically.
6369 (Namespace.Lookup): Don't use GetNamespace.
6370 * typemanager.cs (GetRootNamespace): Rename from
6371 ComputeNamespaceForAlias.
6372 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6374 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6376 * anonymous.cs (AnonymousContainer): Don't crash when container
6379 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6381 * expression.cs (Binary.DoResolve): Warn when comparing same
6384 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6387 * expression.cs (Binary.DoResolve): It looks like there are no
6388 convetsion rules in enum context.
6390 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6392 Add support for extern alias qualifiers.
6393 * typemanager.cs: Move some LookupTypeReflection code
6394 to namespace.cs, to have cleaner code. Added some methods
6395 to help us keep track of the extern aliased references.
6396 * driver.cs: Add suport for extern alias assemblies on command
6397 line and check for their warnings/errors. Also keep track of the
6398 extern aliased assemblies.
6399 * namespace.cs: Move the global functionality of Namespace
6400 to GlobalRootNamespace/RootNamespace. Now the global namespace
6401 is GlobalRootNamespace.Globa. Also the code moved from
6402 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6403 Finally added LocalAliasEntry (AliasEntry before) and
6404 ExternAliasEntry, to handle alias statements.
6405 * cs-parser.jay: Add support in the grammar for extern alias
6407 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6408 Update callings to Namespace (now in GlobalRootNamespace).
6410 2005-10-18 Raja R Harinath <rharinath@novell.com>
6413 * class.cs (TypeContainer.DefineType): Move updating of
6414 topological sort earlier in the code.
6415 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6417 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6420 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6422 * constant.cs (Constant.TryReduce): Moved from Cast class.
6423 (Reduce): Made little bit more OO and fixed missing conversions.
6425 * ecore.cs (Reduce): Implemented.
6426 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6428 * literal.cs (Reduce): Implemented.
6430 * class.cs: Reverted Miguel's wrong commit.
6432 2005-10-14 Miguel de Icaza <miguel@novell.com>
6434 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6436 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6438 * cs-parser.jay, expression.cs : CS0214 was missing error location
6439 for constants. Fixed bug #76404.
6441 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6444 * convert.cs (ExplicitConversionCore): Fixed object->enum
6447 2005-10-10 Raja R Harinath <rharinath@novell.com>
6449 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6451 (PropertyExpr.EmitCall): Likewise.
6452 * expression.cs (Invocation.EmitArguments): Handle case where
6454 (Invocation.EmitCall): Avoid allocating temporary variable if
6455 there are no arguments.
6457 2005-10-07 Raja R Harinath <rharinath@novell.com>
6460 * convert.cs (ImplicitConversionStandard): Move conversion of
6461 void* to arbitrary pointer types ...
6462 (ExplicitConversionStandard): .. here.
6463 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6464 error to always print typenames.
6466 2005-10-07 Raja R Harinath <rharinath@novell.com>
6468 * convert.cs (GetConversionOperator): Rename from
6469 GetConversionOperators. Move operator selection code from ...
6470 (UserDefinedConversion): ... here.
6472 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6474 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6477 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6479 * assign.cs (Assign.DoResolve): Error method changed.
6481 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6483 * const.cs (ResolveValue): Reset in_transit immediately.
6485 * constant.cs: Error method changed.
6487 * convert.cs: Removed useless location parameter.
6488 (ExplicitNumericConversion): Don't do double enum check.
6489 (ExplicitConversionCore): Renamed from ExplicitConversion.
6490 (ExplicitUnsafe): Extracted from ExplicitConversion.
6491 (ExplicitConversion): Uses for error reporting.
6493 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6495 (ResolveBoolean): Uses common error method.
6496 (CastToDecimal): Get rid of ec.
6497 (CastFromDecimal): Optimized.
6498 (ConvCast): Get rid of ec.
6500 * enum.cs (ResolveValue): Reset in_transit immediately.
6501 (Emit): Return after first error.
6503 * expression.cs: Convert changes.
6505 * literal.cs: Error method changed.
6507 * statement.cs: Error method changed.
6509 2005-10-03 Raja R Harinath <rharinath@novell.com>
6511 * support.cs (SeekableStreamReader.Position): Don't error out when
6512 the requested position is just beyond the end of the current
6515 2005-09-28 Raja R Harinath <rharinath@novell.com>
6517 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6518 try to keep in sync with the byte count of the underlying Stream.
6519 However, this limits us to a window size of 2048 characters: i.e.,
6520 the maximum lookahead of our lexer/parser can be 2048 characters.
6522 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6525 * driver.cs: Fix compilation files with full root path.
6527 2005-09-25 Miguel de Icaza <miguel@novell.com>
6529 * report.cs (SymbolRelatedToPreviousError): Format the output so
6530 it does not use an open parenthesis that is never closed.
6532 * driver.cs: Follow coding guidelines
6534 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6537 * const.cs (Const.ResolveValue): Check for assigning non-null
6538 value to reference type.
6540 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6542 * anonymous.cs: Implemented ExprClassName.
6544 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6547 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6550 * class.cs (StaticClass.DefineContainerMembers): Report protected
6553 * codegen.cs: if(ed) PRODUCTION.
6555 * convert.cs (Error_CannotImplicitConversion): Better error
6558 * cs-parser.jay: More error checks.
6560 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6562 * driver.cs (CSCParseOption): Enabled wrong option check.
6564 * ecore.cs (Expression.ExprClassName): Turned to property.
6565 (MemberExpr.CheckIntermediateModification): For checking boxed
6566 value types modification.
6568 * statement.cs (Fixed.Resolve): Expression type must be
6569 convertible to fixed type.
6570 (CollectionForeach.GetEnumeratorFilter,TryType):
6571 Small refactoring for easier error checking.
6573 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6575 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6578 * class.cs (GeneratedBaseInitializer): New class for customization
6579 compiler generated initializers.
6580 (MemberBase.DoDefine): Check Obsolete attribute here.
6581 (FieldMember.DoDefine): Ditto.
6583 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6586 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6587 (MemberCore.GetObsoleteAttribute): Removed argument.
6588 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6589 (MemberCore.CheckObsoleteType): New helper.
6593 * statement.cs: Updates after MemberCore changes.
6595 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6596 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6598 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6599 obsolete attribute for compiler construct.
6600 (As.DoResolve): Cache result.
6602 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6604 2005-09-26 Raja R Harinath <rharinath@novell.com>
6607 * expression.cs (This.VerifyFixed): In a value type T, the type of
6608 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6609 value type R, 'this' is treated as a value parameter.
6611 2005-09-22 Miguel de Icaza <miguel@novell.com>
6613 * statement.cs (Lock): Use the TemporaryVariable class instead of
6614 manually using local variables as those do not work when variables
6617 * ecore.cs: Moved the TemporaryVariable class from being a nested
6618 class inside Foreach to be a public class that can be employed in
6621 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6623 * cs-parser.jay: interface_accessors replaced by
6624 accessor_declarations.
6626 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6629 * statement.cs (GotoCase.Resolve): Convert null constant to
6631 (SwitchLabel.ResolveAndReduce): Ditto.
6632 (SwitchLabel.NullStringCase): Custom null stamp.
6633 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6635 typemanager.cs (CSharpSignature): Don't skip first argument
6638 2005-09-18 Miguel de Icaza <miguel@novell.com>
6640 * driver.cs: Set InEmacs based on the environment variable EMACS.
6642 * location.cs (InEmacs): in this mode, do not report column
6643 location as it confuses Emacs.
6645 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6647 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6648 expression.cs, iterators.cs, literal.cs: Store constants and
6651 * class.cs (MemberBase.ShortName): Pass location.
6653 * cs-parser.jay: Some location fixes.
6655 * ecore.cs (Expression.Location): Made virtual.
6657 2005-09-05 Miguel de Icaza <miguel@novell.com>
6659 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6660 if the underlying types are the same, otherwise we need to produce
6661 code that will do the proper cast.
6663 This was exposed by Marek's constant rewrite which produced
6664 invalid code for the call site:
6667 void Method (X v) {}
6671 This fixes test-49.cs
6673 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6675 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6676 Type/Object should be allowed as well. Fixed bug #75968.
6678 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6680 * expression.cs : (Binary.DoResolve): when one is enum constant and
6681 another is constant 0, then return enum one *as enum type*.
6684 2005-09-02 Raja R Harinath <rharinath@novell.com>
6686 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6690 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6691 flow-branching for LocalVariableReferences in case we were invoked
6692 from a MemberAccess.
6693 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6695 (LocalVariableReference.DoResolveBase): ... this.
6696 (MemberAccess.Resolve): Do the check that was disabled during
6699 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6702 (PartialContainer.Create): check abstract/sealed/static strictly
6703 but abstract/sealed can exist only at one side. Fixed bug #75883.
6705 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6708 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6709 specified, don't default to UnmanagedType.I4.
6711 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6713 * expression.cs : conditional operator should check possibly
6714 incorrect assign expression. Fixed bug #75946.
6716 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6718 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6719 Reverting the change. gmcs is much complex than mcs on this matter.
6721 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6723 * cs-tokenizer.cs : To read another token ahead of the actual
6724 consumption, use new SavedToken and cache token instead of moving
6725 back the stream with SeekableStreamReader (it seemed problematic).
6727 driver.cs : Thus use StreamReader directly.
6728 * support.cs : Thus removed SeekableStreamReader.
6730 2005-08-30 Raja R Harinath <rharinath@novell.com>
6733 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6734 (ScopeInfo.EmitScopeType): Use it to construct field names from
6735 names of captured locals.
6738 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
6739 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
6740 Pass 'target_type' to BoxedCast. Don't default to 'object'.
6741 (ExplicitConversion): Remove enum cases already handled by
6742 implicit conversion. Move implicit conversion check to the beginning.
6743 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
6744 * expression.cs (ArrayCreation.EmitDynamicInitializers):
6745 Don't treat System.Enum as a struct.
6747 2005-08-30 Jb Evain <jbevain@gmail.com>
6749 * attribute.cs: handles as expression in parameters.
6751 2005-08-30 Raja R Harinath <rharinath@novell.com>
6754 * class.cs (TypeContainer.VerifyClsName): Don't use a
6755 PartialContainer when verifying CLS compliance.
6756 (AbstractPropertyEventMethod): Set Parent here, ...
6757 (PropertyMethod): ... not here.
6759 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
6761 * attribute.cs : escaped attribute name should not be allowed to be
6762 resolved (e.g. @class as classAttribute). Fixed bug #75930.
6764 2005-08-29 Raja R Harinath <rharinath@novell.com>
6767 * convert.cs (ImplicitStandardConversionExists): Allow zero also
6768 when converting a long constant to unsigned long.
6769 * expression.cs (Invocation.OverloadResolve): Add sanity check to
6770 detect where IsApplicable and VerifyArgumentsCompat disagree.
6772 2005-08-29 Raja R Harinath <rharinath@novell.com>
6773 and Carlos Alberto Cortez <carlos@unixmexico.org>
6776 * class.cs (TypeContainer.CanElideInitializer): New helper.
6777 (TypeContainer.EmitFieldInitializers): Use it to determine if we
6778 can safely emitting the initializer of a field.
6780 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6782 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
6783 allowed inside a switch (without loop). Fixed bug #75433.
6785 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
6787 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
6788 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
6790 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6792 * driver.cs : kinda reverting the default encoding changes (not exact
6793 revert since I noticed that "codepage:reset" might not work fine).
6795 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6797 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
6798 Location. Now getter and setter store location correctly.
6799 (errors/cs0111-12.cs now reports the expected location.)
6801 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6803 * driver.cs : Use default encoding on the environment.
6804 Removed (now that) extra parameter for SeekableStreamReader.
6805 * support.cs : (SeekableStreamReader) third .ctor() argument for
6806 StreamReader is not required (always true). preamble size could
6807 be acquired in simpler and safe way.
6809 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
6811 * cs-parser.jay: report CS0642 at warning level 3
6812 and report CS0642 for an if else statement also
6813 fixes bug #74745. Patch by John Luke (and a bit
6815 Removed extra CS0642 warning check for "while",
6817 * statement.cs: In Block.Resolve(), CS0642 check
6818 is reimplemented to check a sequence of an empty
6819 statement and a block.
6821 Both fix bug #66777.
6823 2005-08-24 Marek Safar <marek.safar@seznam.cz>
6825 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
6826 detection until I fix it.
6828 * cs-tokenizer.cs: Changed error message.
6830 * cs-parser.jay: Fixed 2 error locations.
6832 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
6833 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
6836 * enum.cs (GetSignatureForError): Fixed.
6838 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
6842 * typemanager.cs (RegisterProperty): Removed.
6844 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
6846 2005-08-24 Raja R Harinath <rharinath@novell.com>
6849 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
6850 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
6852 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6854 * expression.cs : tiny fix is required for not warning positive ulong.
6857 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6859 * expression.cs : add CS0652 check for constant and integral
6860 expression. Fixed bug #53974.
6862 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6864 * expression.cs : in DoNumericPromotions(), check if there is implicit
6865 conversion overload for string (to check CS0034). Fixed bug #52492.
6867 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6869 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
6871 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6873 * ecore.cs : report location when it is *not* Null.
6875 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6881 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
6882 correctly. Fixed bug #75721.
6884 2005-08-23 Raja R Harinath <rharinath@novell.com>
6886 * support.cs (SeekableStreamReader.Position): Avoid an expensive
6887 loop that performs 'min (pos, char_count)'.
6890 * expression.cs (Unary.ResolveOperator): Don't discard implicit
6891 converted value in Operator.OnesComplement.
6893 2005-08-22 Ben Maurer <bmaurer@ximian.com>
6895 * anonymous.cs: If the anon method is pulled into a helper class,
6896 it needs to be `internal' not `private'. Fixes runtime behavior on
6899 2005-08-20 Martin Baulig <martin@ximian.com>
6901 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6902 scope if we don't already have it.
6904 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
6905 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
6908 2005-08-17 Marek Safar <marek.safar@seznam.cz>
6911 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
6914 2005-08-16 Marek Safar <marek.safar@seznam.cz>
6916 The big constants rewrite
6917 Fix #75746, #75685 and more
6918 As a side effect saved 1MB for MWF ;-)
6920 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
6921 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
6922 enum based for corlib compilation.
6924 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
6927 * class.cs (FixedField.Define): Use ResolveAsConstant.
6929 * const.cs (IConstant): Interface constants and enums.
6930 (Const.ResolveValue): New method for constant resolvning.
6931 (ExternalConstant): Constants from imported assemblies.
6933 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
6934 conversion; like enums.
6935 (Constant.ToType): Converts this constant to different type.
6936 (Constant.Increment): Adds 1.
6938 * convert.cs (ImplicitConversionRequired): Simplified.
6940 * cs-parser.jay: Create EnumMember directly.
6942 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
6944 * doc.cs (GenerateEnumDocComment): Removed.
6946 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
6947 (ConvertIntLiteral): Removed.
6948 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
6950 * enum.cs (EnumMember): Implement IConstant.
6951 (Enum.IsValidEnumConstant): Removed.
6952 (Enum.GetNextDefaultValue): Removed.
6953 (Enum.FindMembers): Updated.
6954 (Enum.GenerateDocComment): Iterate enum members.
6956 * expression.cs (Cast.TryReduce): Handle enums correctly.
6957 (New.Constantify): Made public.
6958 (MemberAccess.DoResolve): Removed contant specific if(s).
6960 * literal.cs (NullLiteral): Implement new abstract methods.
6962 * statement.cs (GotoCase.Resolve): Use new constant methods.
6963 (SwitchLabel.ResolveAndReduce): Use new constant methods.
6965 * typemanager.cs (LookupEnum): Removed.
6966 (IsEnumType): Fixed to work with corlib.
6967 (RegisterConstant): Removed.
6968 (LookupConstant): Removed.
6969 (GetConstant): Changed to work with IConstant.
6971 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
6973 * location.cs : Fixed overflown (>255) column number.
6975 2005-08-03 Raja R Harinath <rharinath@novell.com>
6977 First cut of the qualified-alias-member feature.
6978 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
6980 * cs-parser.jay (DOUBLE_COLON): New token.
6981 (namespace_or_type_name): Add rule for recognizing
6982 qualified-alias-members.
6983 (primary_expression): Likewise.
6984 (element_access): Allow QualifiedAliasMember as a possible
6985 type-bearing expression.
6986 (local_variable_type, local_variable_pointer_type): Likewise.
6987 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
6988 aliases in the current and enclosing namespace declarations.
6989 (NamespaceEntry.UsingAlias): Add CS0440 warning.
6990 * decl.cs (MemberName.is_double_colon): New.
6991 (MemberName.MemberName): Add new constructor for alias-member.
6992 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
6993 * expression.cs (QualifiedAliasMember): New expression type.
6995 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
6997 * location.cs : it borked when no argument was specified.
6999 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7001 * location.cs : tiny ToString() format fix.
7003 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7005 * statement.cs : oops, it was missing.
7007 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7009 A set of fixes for precise line/column location.
7012 "token" field now holds a file/line "delta", a line number offset
7013 from the segment, and a column number. See also:
7014 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7015 December/009508.html
7016 Removed static IsNull. Use instance IsNull property instead.
7018 For some tokens it stores Location. For Identifier it stores
7019 LocatedToken which is a pair of string name and location.
7020 Column numbers are adjusted only at getChar().
7022 Use Location.ToString() for reporting (it now contains column).
7024 Largely modified to use LocatedToken instead of
7025 string (IDENTIFIER), and to acquire Location from some tokens.
7026 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7027 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7029 Now MemberName holds Location. DeclSpace.ctor() receives Location
7030 as a parameter. Removed extra parameters to all derived classes.
7031 Replaced Location.IsNull() with instance property.
7032 * assign.cs, expression.cs :
7033 Added .ctor() overload that omits Location.
7035 Added "nameEscaped" flag that indicates the identifier was escaped
7036 in the source file. This fixes bug #57047.
7038 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7040 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7041 New method, looking for lo-case imported cls type.
7043 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7046 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7048 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7050 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7052 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7054 Optimized to save 3.5 MB for SWF compilation.
7056 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7058 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7059 (PartialContainer.Create): Moved logic AddToContainer.
7060 (PartialContainer.MarkForDuplicationCheck): Shares name.
7062 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7065 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7067 (Namespace.GetSignatureForError): New method.
7069 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7070 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7072 2005-08-01 Raja R Harinath <rharinath@novell.com>
7075 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7076 member lookup rather than qualifier_type, since qualifier_type can
7079 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7081 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7084 2005-07-31 Miguel de Icaza <miguel@novell.com>
7086 * statement.cs: Copy the local exception into the exception
7087 captured local. Fixes 75674
7089 2005-07-31 Raja R Harinath <harinath@gmail.com>
7092 * expression.cs (Invocation.OverloadResolve): Don't report error
7093 CS1501 if error CS1502 has been reported.
7094 (New.DoResolve): Delegate CS1501 reporting to
7095 Invocation.OverloadResolve.
7098 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7099 invariant-meaning-in-block property in an enclosing block if
7102 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7104 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7105 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7106 (Switch.CheckSwitch): Just save 50kb for SWF.
7108 2005-07-27 Martin Baulig <martin@ximian.com>
7110 * anonymous.cs (CaptureContext.AddField): Added
7111 `AnonymousContainer am' argument; compute its toplevel scope if
7112 it's not already computed. Fixes #75649.
7114 2005-07-26 Raja R Harinath <rharinath@novell.com>
7117 * class.cs (Constructor.Emit): Reset block to null if the block
7120 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7122 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7124 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7126 * class.cs (MethodData.Define): Check whether accessor implementing
7127 interface is public.
7129 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7131 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7134 * namespace.cs (LookupType): Moved same type check to...
7136 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7139 2005-07-21 Raja R Harinath <rharinath@novell.com>
7141 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7142 already found a typebuilder.
7143 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7144 MemberNames, not strings.
7146 * const.cs (Error_ExpressionMustBeConst):
7147 Rename from Error_EpressionMustBeConst.
7148 * const.cs, class.cs, statement.cd: Update.
7150 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7154 * const.cs (Const.LookupConstantValue): Report missing contant expression
7156 (Error_EpressionMustBeConstant): Only one error method.
7158 * class.cs, statement.c: Updated.
7160 2005-07-20 Raja R Harinath <rharinath@novell.com>
7162 * statement.cs (Block.Flags): Add back HasVarargs.
7163 (Block.flags): Make protected.
7164 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7166 * typemanager.cs (types, typecontainers, user_types): Remove.
7167 (UserTypes, TypeContainers): Likewise.
7168 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7169 (CleanUp, Reset): Update.
7170 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7171 (GetNestedType): Use Type.GetNestedType.
7172 (CoreLookupType): Take two arguments, the namespace and the
7173 basename of the type. Update to use the Namespace.Lookup
7175 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7176 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7177 string concatenation and substring matches.
7178 * class.cs, enum.cs, delegate.cs: Update to changes.
7180 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7182 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7183 Expression and made virtual.
7185 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7186 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7188 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7190 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7193 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7196 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7199 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7200 AssemblyCultureAttribute is not used on executable.
7203 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7205 2005-07-16 Raja R Harinath <rharinath@novell.com>
7208 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7209 New. Reports CS0252/CS0253.
7210 Mostly taken from preliminary patch by Duncak Mak.
7211 (Binary.DoResolveOperator): Store results of operator lookup.
7212 Use them to detect if we need to warn about unintended reference
7215 2005-07-15 Raja R Harinath <rharinath@novell.com>
7218 * namespace.cs (Namespace.Lookup): Add back location parameter.
7219 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7220 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7222 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7223 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7224 (Namespace.LookupType): ... this.
7225 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7227 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7228 purported to handle pointers.
7229 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7232 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7234 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7237 2005-07-15 Raja R Harinath <rharinath@novell.com>
7239 * namespace.cs (Namespace.Lookup): Drop location parameter.
7240 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7241 (NamespaceEntry.Lookup): ... this.
7242 (NamespaceEntry.Error_AmbiguousTypeReference):
7243 Move here from DeclSpace.
7244 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7246 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7247 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7248 Move to NamespaceEntry.
7249 * delegate.cs, expression.cs: Update to changes.
7251 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7253 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7254 CheckAttributeType and refactored.
7255 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7256 ResolveAsTypeTerminal error handling.
7257 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7259 (GetSignatureForError): Print errors in same way.
7262 * codegen.cs: Reflect attribute GetSignatureForError change.
7265 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7267 * namespace.cs (UsingEntry): Refactored to make fields private.
7270 statement.cs: Error_UnexpectedKind has extra parameter.
7272 2005-07-14 Raja R Harinath <rharinath@novell.com>
7274 * ecore.cs (IAlias): Remove.
7275 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7276 that implement the interface.
7277 * namespace.cs (Namespace): Likewise.
7278 (Namespace.declspaces): Renamed from 'defined_names'.
7279 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7280 DeclSpace instead of an IAlias.
7281 * tree.cs (Tree.AddDecl): Update.
7283 2005-07-12 Raja R Harinath <rharinath@novell.com>
7285 * statement.cs (Block.Flags); Remove HasVarargs.
7286 (Block.HasVarargs): Move to ToplevelBlock.
7287 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7288 (Block.Variables): Make protected. Initialize variable hashtable
7290 (Block.AddVariable): Update.
7291 (Block.Resolve): Update to changes.
7292 (ToplevelBlock.HasVarargs): New boolean.
7293 (ToplevelBlock.ThisVariable): Move here from Block.
7294 (ToplevelBlock.AddThisVariable): Likewise.
7295 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7296 * expression.cs (This.ResolveBase): Update to changes.
7297 (ArglistAccess.DoResolve): Likewise.
7299 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7302 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7304 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7305 not used and not used & assigned.
7306 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7308 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7311 * expression.cs (Is.DoResolve): null is never provided type.
7313 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7316 * cs-parser.jay: Less strict event error rule to catch more errors.
7318 2005-07-08 Martin Baulig <martin@ximian.com>
7320 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7321 gettter (allowed) or setter (not allowed).
7323 * class.cs (Accessor): Implement IIteratorContainer.
7324 (Accessor.Yields): New public field.
7325 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7329 (get_accessor_declaration, set_accessor_declaration): Set the
7330 `yields' flag on the accessor, not the property.
7331 (property_declaration): Do the iterators check on a per-accessor
7332 basis and not for the whole property.
7334 2005-07-08 Martin Baulig <martin@ximian.com>
7336 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7337 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7339 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7342 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7343 (ExtractSecurityPermissionSet): Cope with self referencing security
7344 attributes properly.
7346 * driver.cs (SetOutputFile): Made public property OutputFile.
7348 2005-07-07 Raja R Harinath <rharinath@novell.com>
7351 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7352 has_nonstatic_fields. Make into a FieldBase pointer.
7353 (TypeContainer.AddField): Add CS0282 check.
7354 (TypeContainer.EmitType): Update.
7356 2005-07-06 Miguel de Icaza <miguel@novell.com>
7358 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7359 compare if they start with __.
7361 2005-07-06 Raja R Harinath <rharinath@novell.com>
7363 * statement.cs (Switch.SwitchGoverningType): Only look at
7364 UserCasts that don't need implicit standard conversions to one of
7365 the allowed switch types (Fixes test-322.cs).
7366 (LocalInfo.Resolve): Re-enable sanity-test.
7368 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7370 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7372 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7374 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7376 2005-07-06 Raja R Harinath <rharinath@novell.com>
7379 * ecore.cs (SimpleName.GetSignatureForError): Add.
7380 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7381 (MemberAccess.GetSignatureForError): Add.
7383 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7385 The big error and warning messages review.
7415 * typemanager.cs: Updated.
7417 * class.cs: (MethodCore.SetYields): Moved here to share.
7418 (PropertyMethod.Define): Moved iterator setup here.
7420 * iterators.cs: Add orig_method to have full access to parent
7423 2005-07-05 Raja R Harinath <rharinath@novell.com>
7425 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7426 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7427 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7428 variable of struct type.
7429 * expression.cs (Unary.ResolveOperator): Update to change.
7430 (Indirection.VerifyFixed): Likewise.
7431 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7432 (ParameterReference.VerifyFixed): Value parameters are fixed.
7433 (This.VerifyFixed): Treat 'this' as a value parameter.
7434 * statement.cs (LocalInfo.IsFixed): Remove.
7436 2005-07-01 Martin Baulig <martin@ximian.com>
7438 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7439 `ec.EmitThis ()' to get the correct scope.
7441 2005-07-01 Martin Baulig <martin@ximian.com>
7443 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7444 instance is a ParameterReference; fixes #75299.
7446 2005-07-01 Martin Baulig <martin@ximian.com>
7448 Reverted Marek's latest patch (r46725):
7449 - it contains structural changes which are neither mentioned in
7450 the ChangeLog nor explained anywhere; for example the additional
7451 argument of EmitContext's and Iterator's .ctor's and the
7452 TypeContainer.DefineMembers() change.
7453 - structural changes like this should go in in seperate patches
7454 and not be hidden in a huge patch which just seems to affect
7455 warnings and errors.
7456 a big and hard to understand patch.
7457 - it breaks iterators and causes regressions, for instance in
7460 2005-06-30 Raja R Harinath <rharinath@novell.com>
7463 * expression.cs (Indexers.map): Remove.
7464 (Indexers.Append): Filter out inaccessible setters and getters.
7465 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7468 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7470 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7471 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7472 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7473 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7475 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7478 * class.cs (FieldBase.GetInitializerExpression): One more field
7481 2005-06-28 Miguel de Icaza <miguel@novell.com>
7483 * pending.cs: Do not define a proxy if the base method is virtual,
7484 it will be picked up by the runtime (bug 75270).
7486 2005-06-08 Martin Baulig <martin@ximian.com>
7488 The big Iterators rewrite :-)
7490 * iterators.cs: Rewrite this to use the anonymous methods framework.
7492 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7493 before the TypeContainers; see 2test-21.cs.
7496 (TypeContainer.DefineType): Don't create a new EmitContext if we
7497 already have one (this only happens if we're an Iterator).
7498 (TypeContainer.Define): Also call Define() on all our iterators.
7499 (Method.CreateEmitContext): Added support for iterators.
7502 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7503 (AnonymousContainer.CreateMethodHost): Moved here from
7504 AnonymousMethod and made abstract.
7505 (AnonymousContainer.CreateScopeType): New abstract method.
7506 (AnonymousContainer.IsIterator): New public property.
7507 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7508 get the ScopeTypeBuilder rather than manually defining it here.
7509 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7512 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7513 before RootContext.DefineTypes().
7515 * codegen.cs (EmitContext.RemapToProxy): Removed.
7516 (EmitContext.CurrentAnonymousMethod): Changed type from
7517 AnonymousMethod -> AnonymousContainer.
7518 (EmitContext.ResolveTopBlock): Protect from being called twice.
7519 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7520 (EmitContext.EmitThis): Removed the iterators hacks; use the
7521 anonymous methods framework for that.
7524 (ToplevelBlock.Container): Make this a property, not a field.
7525 (ToplevelBlock.ReParent): New public method; move the
7526 ToplevelBlock into a new container.
7527 (Foreach.TemporaryVariable): Simplify.
7529 2005-06-05 Martin Baulig <martin@ximian.com>
7531 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7532 (Block.AddTemporaryVariable): New public method; creates a new
7533 `LocalInfo' for a temporary variable.
7534 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7536 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7537 non-iterator variables.
7539 2005-06-05 Martin Baulig <martin@ximian.com>
7541 * statement.cs (Foreach.TemporaryVariable): Create the
7542 LocalBuilder in the Emit phase and not in Resolve since in some
7543 situations, we don't have an ILGenerator during Resolve; see
7544 2test-19.cs for an example.
7546 2005-06-04 Martin Baulig <martin@ximian.com>
7548 **** Merged r45395 from GCS ****
7550 The big Foreach rewrite - Part II.
7552 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7553 with `PropertyInfo ienumerator_getcurrent'.
7555 * codegen.cs (VariableStorage): Removed.
7558 (Foreach): Derive from Statement, not ExceptionStatement.
7559 (Foreach.CollectionForeach): New nested class. Moved all the code
7560 dealing with collection foreach here.
7561 (Foreach.ForeachHelperMethods): Removed.
7562 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7564 2005-05-23 Martin Baulig <martin@ximian.com>
7566 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7567 don't need to. Fix #75014.
7569 2005-05-20 Martin Baulig <martin@ximian.com>
7571 Merged r44808 from GMCS.
7573 * class.cs (TypeContainer.CircularDepException): Removed.
7574 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7575 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7576 (CS0146) and interface (CS0529) dependencies here.
7578 2005-06-21 Raja R Harinath <rharinath@novell.com>
7580 * expression.cs (Invocation.EmitCall): Fix initialization
7581 'this_call' to reflect current behaviour. Fix indentation.
7583 * convert.cs (FindMostEncompassedType): Add two trivial special
7584 cases (number_of_types == 0 || number_of_types == 1).
7585 (FindMostEncompasingType): Likewise.
7587 2005-06-17 Raja R Harinath <rharinath@novell.com>
7589 Some cleanups preparing for the fix of #75283.
7590 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7592 (EventExpr.InstanceResolve): Likewise.
7593 (EventExpr.DoResolve): Remove redundant checks.
7595 2005-06-10 Duncan Mak <duncan@novell.com>
7597 * cs-tokenizer.cs (process_directives): New flag for controlling
7598 the processing of preprocessor directives.
7599 (x_token): After seeing a '#', return Token.NONE instead of going
7600 to handle_preprocessing_directive() when not processing
7601 directives. This avoids unnecessary processing during the token peek in
7606 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7607 the existing error reporting methods instead of Report.Error.
7609 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7610 after Raja's rewrite.
7612 2005-06-08 Miguel de Icaza <miguel@novell.com>
7614 * class.cs: Small fix.
7616 2005-06-08 Raja R Harinath <rharinath@novell.com>
7619 * class.cs (GetPartialBases): Fix return value check of
7622 2005-06-07 Raja R Harinath <rharinath@novell.com>
7624 Ensure that partial classes are registered in their enclosing
7625 namespace. Initial part of fix of #75160.
7626 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7627 Register declspace with namespace here, not in
7628 DeclSpace.RecordDecl.
7629 * cs-parser.jay: Pass namespace to RecordDecl.
7630 * class.cs (PartialContainer.Create): Likewise.
7631 (ClassPart.DefineType): New sanity-check. Throws an exception if
7633 * decl.cs (Declspace.RecordDecl): Remove.
7634 * namespace.cs (NamespaceEntry.DefineName): Remove.
7636 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7638 * rootcontext.cs: Reset TargetExt as well.
7640 2005-06-03 Raja R Harinath <rharinath@novell.com>
7642 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7645 2005-06-02 Raja R Harinath <rharinath@novell.com>
7647 Fix #75080, cs0119.cs.
7648 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7650 (Expression.Resolve): ... this. Use it. Remove bogus code
7651 allowing ExprClass.Type and ExprClass.Namespace for
7652 ResolveFlags.VariableOrValue.
7653 (Expression.Resolve) [1-argument variant]: Change default resolve
7654 flags based on language version.
7655 (Expression.Error_UnexpectedKind): Use a simple string array
7656 rather than an ArrayList.
7657 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7659 (TypeOfVoid.DoResolve): Likewise.
7660 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7661 flags argument -- it always has the same value.
7663 2005-05-31 Raja R Harinath <rharinath@novell.com>
7666 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7667 Use it in the error message.
7668 * assign.cs, expression.cs, statement.cs: Update.
7670 2005-05-30 Raja R Harinath <rharinath@novell.com>
7673 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7674 the "almostMatchedMember" case too.
7675 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7676 that failed the accessibility checks to 'almost_match'.
7678 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7680 * attribute.cs: Use internal MethodBuilder methods to set
7681 ExactSpelling and SetLastError on PInvoke methods, instead
7682 of passing them via charset. Fixes #75060.
7684 2005-05-27 Raja R Harinath <rharinath@novell.com>
7686 * parameter.cs (Parameter): Remove TODO comment.
7687 (Parameter.DefineParameter): Remove Location parameter.
7688 (Parameters.LabelParameters): Likewise.
7689 * class.cs (Constructor.Emit): Update to change.
7690 (MethodData.Emit): Likewise.
7691 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7692 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7694 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7697 Removed Parameters.Location and added Parameter.Location instead.
7698 Removed Location parameter from Emit() and GetSignature().
7705 Modified all related calls.
7707 2005-05-26 Raja R Harinath <rharinath@novell.com>
7709 Improve user-defined conversion handling.
7710 * convert.cs (GetConversionOperators): Rewrite. Return only the
7711 applicable operators.
7712 (AddConversionOperators): New. Helper for GetConversionOperators.
7713 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7714 there is only one most encompassed/encompassing type.
7715 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7716 "applicable operator" handling.
7717 (UserConversion): Move cache here from GetConversionOperators.
7718 Directly cache the chosen operator, rather than the whole
7720 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7721 case. Allow conversion of decimal to sbyte and byte too.
7722 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7723 New static methods. Used to avoid allocating EmptyExpressions in
7726 2005-05-24 Duncan Mak <duncan@novell.com>
7728 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7729 another class, used in Convert.ExplicitNumericConversion.
7730 (CastToDecimal): New class, similar to above, but casts to
7731 System.Decimal, used in Convert.ImplicitNumericConversion and also
7732 in explicit convesion from double/float to decimal.
7734 * convert.cs (ImplicitNumericConversion): Handle implicit
7735 conversions to System.Decimal.
7736 (ExplicitNumericConversion): handle explicit conversions to
7741 2005-05-20 Miguel de Icaza <miguel@novell.com>
7743 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
7744 know the type at this stage, just break through. Fixes #75008
7746 2005-05-19 Martin Baulig <martin@ximian.com>
7749 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
7750 to disable error reporting.
7752 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
7753 here since we don't want to report an error; see the new test-336.cs.
7755 2005-05-19 Raja R Harinath <rharinath@novell.com>
7757 * statement.cs (ToplevelBlock.GetParameterReference)
7758 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
7759 Move here from class Block.
7760 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
7761 * expression.cs (ParameterReference.DoResolveBase): Likewise.
7763 2005-05-18 Martin Baulig <martin@ximian.com>
7768 (FlowBranching.Reachability): Add non-static public And() and Or()
7770 (FlowBranchingSwitch): New class; do the `break_origins' thing
7771 like in FlowBranchingLoop.
7772 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
7773 reachability, not just locals and parameters.
7774 (FlowBranching.MergeChild): Remove some of the hacks for loop and
7775 switch; MergeBreakOrigins() now takes care of that.
7777 2005-05-18 Martin Baulig <martin@ximian.com>
7779 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7780 a loop and may leave it, reset the barrier; fixes #74974.
7782 2005-05-17 Marek Safar <marek.safar@seznam.cz>
7784 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
7787 * cs-parser.jay: Catch more lexical errors.
7789 * report.cs: Add one more Error method.
7792 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
7794 2005-05-17 Martin Baulig <martin@ximian.com>
7796 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
7799 2005-05-16 Raja R Harinath <rharinath@novell.com>
7801 Fix test-382.cs. Emit values of decimal constants.
7802 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
7804 (TypeContainer.AddField): ... this.
7805 (TypeContainer.EmitFieldInitializers): Allow the list of fields
7806 with initializers to include 'Const's.
7807 (ClassPart.RegisterFieldForInitialization): Forward to
7809 * const.cs (Const.Const): Pass initializer to base class.
7810 (Const.Define): In case of decimal constants, register them for
7811 initialization in a static constructor.
7813 2005-05-14 Martin Baulig <martin@ximian.com>
7815 * statement.cs (Block.Resolve): Correctly handle unreachable code;
7816 do not call ResolveUnreachable() on unreachable statements in
7817 here, see the comment in the source code.
7819 2005-05-13 Raja R Harinath <rharinath@novell.com>
7822 * expression.cs (BinaryResolveOperator): If one of the operands of
7823 an equality comparison is 'null' and the other is a pointer type,
7824 convert the null to a NullPointer.
7825 * convert.cs (ImplicitReferenceConversion): If the expression is a
7826 NullLiteral and the target type is a pointer type, return a
7827 NullPointer instead.
7828 (ImplicitConversionStandard): Likewise.
7830 2005-05-13 Marek Safar <marek.safar@seznam.cz>
7832 * cs-parser.jay: Set readonly context based on special constructs.
7834 * expression.cs (LocalVariableReference.DoResolveBase): Improved
7835 readonly variable error handling.
7837 * rootcontext.cs (EmitCode): Don't verify members when error
7840 * statement.cs (LocalInfo): Add reaodnly context information.
7841 (SetReadOnlyContext, GetReadOnlyContext): New methods.
7843 2005-05-13 Raja R Harinath <rharinath@novell.com>
7845 * statement.cs (Block.Resolve): Revert change below. Modify fix
7846 for #74041 to initialize 'resolved' to false only for explicit
7847 blocks. Fixes #74873.
7849 2005-05-12 Raja R Harinath <harinath@gmail.com>
7852 * typemanager.cs (unmanaged_enclosing_types): New.
7853 (IsUnmanagedType): Avoid infloops by using
7854 'unmanaged_enclosing_types' to talk with recursive invocations.
7856 2005-05-13 Martin Baulig <martin@ximian.com>
7858 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
7859 instance variable, not a local. Fix #74873.
7860 (Block.ResolveUnreachable): Set it to true here.
7862 2005-05-11 Duncan Mak <duncan@novell.com>
7864 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
7865 continuing to process for 'arg'.
7866 (handle_preprocessing_directive): Check the argument of the #endif
7867 directive and report error CS1025 if there are any trailing
7870 According to the C# spec, having even whitespace after the #endif
7871 directive is illegal; however, because we call arg.TrimEnd ()
7872 beforehand, we have the same behavior as csc, allowing whitespace
7873 after the directive.
7877 2005-05-11 Marek Safar <marek.safar@seznam.cz>
7881 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
7882 (Constructor.GetObsoleteAttribute): Implemented correctly.
7884 2005-05-10 Martin Baulig <martin@ximian.com>
7886 * support.cs (ReflectionParameters.ParameterModifier): Use
7887 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
7888 and `ParameterAttributes.In'. Fixes #74884.
7890 2005-05-10 Marek Safar <marek.safar@seznam.cz>
7892 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
7894 * expression.cs (Argument.GetParameterModifier): Turned to property.
7895 (Invocation.Error_InvalidArguments): Add more descriptive errors.
7897 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
7900 2005-05-09 Raja R Harinath <rharinath@novell.com>
7903 * decl.cs (MemberCache.AddMethods): Register override methods,
7904 rather than non-override methods.
7905 * typemanager.cs (RegisterOverride): New.
7906 (IsOverride): Update.
7908 2005-05-09 Marek Safar <marek.safar@seznam.cz>
7912 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
7913 recursive declaration.
7915 * statement.cs (Block.ResolveMeta): Report any error in resolving.
7917 2005-05-06 Marek Safar <marek.safar@seznam.cz>
7919 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
7921 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
7923 2005-05-05 Raja R Harinath <rharinath@novell.com>
7926 * decl.cs (DeclSpace.FamilyAccessible):
7927 Use TypeManager.IsNestedFamilyAccessible.
7929 Fix reopened #64812.
7930 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
7933 2005-05-04 Raja R Harinath <rharinath@novell.com>
7934 Abin Thomas <projectmonokochi@rediffmail.com>
7935 Anoob V E <projectmonokochi@rediffmail.com>
7936 Harilal P R <projectmonokochi@rediffmail.com>
7939 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
7940 allow access to all static members.
7942 2005-05-04 Martin Baulig <martin@ximian.com>
7944 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
7946 2005-05-04 Martin Baulig <martin@ximian.com>
7950 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
7951 section at the end; make things work if `default' is not the last
7954 2005-05-04 Martin Baulig <martin@ximian.com>
7958 * statement.cs (Switch): Replaced the `got_default' field with a
7959 `default_section' one.
7960 (Switch.CheckSwitch): Set `default_section' here.
7961 (Switch.Resolve): If we're a constant switch and the constant is
7962 not found, use the default section.
7964 2005-05-03 Martin Baulig <martin@ximian.com>
7966 * expression.cs (ArrayAccess.EmitGetLength): New public method.
7968 * statement.cs (Foreach.ArrayForeach): New nested class.
7969 (Foreach.TemporaryVariable): New nested class.
7970 (Foreach.EmitArrayForeach): Removed; this is now in the new
7973 2005-05-03 Raja R Harinath <rharinath@novell.com>
7975 * pending.cs (BaseImplements): Move the #74773 fix here. This is
7977 (VerifyPendingMethods): Revert change below.
7979 * typemanager.cs (IsOverride, RegisterNonOverride): New.
7980 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
7981 that used to trigger warning -28. Remove warning -28.
7982 * expression.cs (Invocation.OverloadResolve): Use
7983 TypeManager.IsOverride to distinguish override methods.
7986 * pending.cs (VerifyPendingMethods): If a base type implements the
7987 requested interface, don't bother checking individual methods of
7988 the base type. As a side-effect, this prevents the creation of
7989 unnecessary proxies.
7991 2005-05-02 Martin Baulig <martin@ximian.com>
7995 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
7996 Also `And' the locals if the old vector is null.
7997 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
7998 null; in this case we basically reset all the variables.
8000 2005-05-02 Martin Baulig <martin@ximian.com>
8004 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8005 Added `FlowBranching branching' argument; always `and' the
8006 variables instead of `or'ing them unless we're an infinite loop.
8008 * statement.cs (While.Resolve): Create a new sibling unless we're
8011 2005-05-02 Martin Baulig <martin@ximian.com>
8015 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8016 arguments; use it instead of creating a new TopLevelBlock.
8017 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8018 our ConstructorInitializer.
8021 (TopLevelBlock.TopLevelBranching): New public property.
8022 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8023 and create our `TopLevelBranching'.
8025 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8026 anonymous method host, use `block.TopLevelBranching' rather than
8027 creating a new branching.
8029 2005-04-20 Miguel de Icaza <miguel@novell.com>
8031 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8032 a ScopeInfo, if any of the current children is a child of the new
8033 entry, move those children there.
8035 2005-04-30 Martin Baulig <martin@ximian.com>
8037 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8038 at the beginning of a SwitchSection. Fix #73335.
8040 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8043 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8045 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8046 (FieldExpr.DoResolve): Obsolete members are ignored for field
8049 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8051 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8052 of arrays detection.
8054 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8056 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8058 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8061 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8063 * cs-parser.jay: Use the prefered version of -unsafe in error
8066 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8068 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8071 2005-04-20 John Luke <john.luke@gmail.com>
8073 * driver.cs: fix typo in error message, --outout to --output
8075 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8077 * codegen.cs (InRefOutArgumentResolving): New field.
8079 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8080 fields outside contructor.
8082 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8084 2005-04-19 Miguel de Icaza <miguel@novell.com>
8086 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8087 parameter code was not completed ever, so it was not as up-to-date
8088 as local variables. Must finish it.
8090 The bug fix was to compare the Toplevel of the block, not the
8091 current block. Thanks for Ben for pointing this out.
8093 2005-04-19 Raja R Harinath <rharinath@novell.com>
8095 * decl.cs (AddMethods): Use the declaring type of the problem
8096 method to determine if we want to squash a warning.
8098 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8100 * attribute.cs: Removed debug output.
8102 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8104 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8107 2005-04-18 Raja R Harinath <rharinath@novell.com>
8110 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8111 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8112 all null comparisons against reference types.
8114 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8117 * class.cs (TypeContainer.CircularDepException) New nested
8119 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8120 (TypeContainer.DefineType): Removed error, reset InTransit before
8122 (Class.DefineType): Throw exception when is in Transit.
8123 Catch exception and report error.
8124 (Struct.DefineType): Throw exception when is in Transit.
8125 Catch exception and report error.
8126 (Interface.DefineType): Throw exception when is in Transit.
8127 Catch exception and report error.
8129 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8130 handle nested exception handlers.
8132 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8135 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8136 InFinally and InCatch storage.
8138 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8139 (Catch.Resolve): Set and Restore ec.InCatch.
8140 (Try.Resolve): Set and Restore ec.InFinally.
8141 (Try.HasCatch): True when try has catch.
8143 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8145 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8146 for the same event member, so exclude such cases from warning 419.
8149 2005-04-16 Miguel de Icaza <miguel@novell.com>
8151 * expression.cs (Binary.ResolveOperator): Apply patch from John
8152 Luke to fix bug 59864: operators &, | and ^ on enumerations
8153 require that the same enum type on both sides.
8155 * driver.cs: Add warnings to old flag usage, this is to assist
8156 people who produce Makefiles and hope that the Makefiles will be
8159 * class.cs (TypeContainer.EmitType): Moved the definition of the
8160 special $PRIVATE$ field from the resolve phase to the Emit phase.
8161 During resolve we do not know if we are a struct with
8162 HasExplicitLayout, we know this only after the attributes for the
8165 Set the FieldOffset to zero on the dummy field that we create for
8166 the class. Fixes 74590.
8168 2005-04-16 Raja R Harinath <rharinath@novell.com>
8171 * ecore.cs (PropertyExpr.resolved): New.
8172 (DoResolve): Use it to handle a case of double resolution here.
8173 Handle a case of identical-name-and-type-name.
8174 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8175 resolution by storing the results of expression resolution back
8176 into the "probes" array.
8178 2005-04-15 Raja R Harinath <rharinath@novell.com>
8180 Fix cs0208-7.cs and cs0208-8.cs.
8181 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8182 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8183 error reporting to point out the reason a struct is not unmanaged.
8185 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8187 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8188 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8190 2005-04-13 Raja R Harinath <rharinath@novell.com>
8193 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8194 IdenticalNameAndTypeName here.
8195 (EventExpr.InstanceResolve): Likewise.
8197 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8199 C# 2.0 DefaultCharSetAttribute implementation
8201 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8202 which allows us to set GlobalNamespace for every resolve.
8203 (Attribute.ResolveArguments): Cut from Resolve.
8204 (Attribute.GetCharSetValue): Returns CharSet named argument.
8205 (Attribute.DefinePInvokeMethod): Gets default charset from
8207 (GlobalAttribute.ResolveAsTypeStep): Override.
8208 (GlobalAttribute.ResolveArguments): Override.
8210 * class.cs (TypeAttr): Is protected.
8212 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8213 (ModuleClass.DefaultCharSetType): New memeber.
8214 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8216 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8217 charset from module.
8219 * delegate.cs (TypeAttr): Override.
8220 (Delegate.DefineType): Use this TypeAttr.
8222 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8223 at very early stage (before types are defined) to resolve model
8224 module attributes. It will probably not work with corlib but it
8227 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8228 charset from module.
8230 * typemanager.cs (default_charset_type): New type.
8232 2005-04-13 Raja R Harinath <rharinath@novell.com>
8234 * decl.cs (MemberCache.AddMethods): Don't warn if
8235 System.Object.Finalize has buggy MethodAttributes.
8237 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8240 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8242 * doc.cs : detect ambiguous reference to overloaded members.
8243 Fixed bug #71603. MS 1.1 csc does not detect it.
8245 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8247 * doc.cs : delegates must not be referenced with parameters.
8250 2005-04-12 Miguel de Icaza <miguel@novell.com>
8252 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8254 2005-04-10 Miguel de Icaza <miguel@novell.com>
8256 * driver.cs (MainDriver): Stop processing if the CLS stage found
8259 (CompilerCallableEntryPoint.InvokeCompiler): Always
8260 reset after execution; Take a TextWriter argument for the
8263 * report.cs: Use the error stream instead of hardcoding stderr.
8265 2005-04-09 Miguel de Icaza <miguel@novell.com>
8267 * class.cs: Reduce code paths to test, too small of an
8268 optimization to make it worth the extra testing. Always perform
8271 2005-04-08 Raja R Harinath <rharinath@novell.com>
8274 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8275 operators that had errors reported on them.
8277 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8279 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8281 (Attribute.Resolve): Add named argument type checking.
8283 * class.cs (FixedField.Define): Use IsPrimitiveType
8285 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8287 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8288 unsafe parameter types.
8290 * statement.cs (Using.ResolveExpression): Add better error description.
8292 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8294 2005-04-08 Raja R Harinath <rharinath@novell.com>
8297 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8298 AttributeUsageAttribute in the emitcontext of the attribute class,
8299 not in the emitcontext of the attributable entity it was attached to.
8300 * cs-parser.jay: Use 'current_class', not 'current_container',
8301 when creating a GlobalAttribute.
8303 2005-04-08 Alp Toker <alp@atoker.com>
8305 * pending.cs: The fix to #58413 failed to compile methods implementing
8306 interfaces with/without params modifiers and vice versa, even though
8307 params modifiers aren't part of the signature. Make the modifier check
8308 less strict as in csc.
8310 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8311 Anoob V E <projectmonokochi@rediffmail.com>
8312 Harilal P R <projectmonokochi@rediffmail.com>
8315 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8316 modifiers of pending methods.
8317 (PendingImplementation.PendingImplementation): Initialize it.
8318 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8319 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8320 with ParameterData. Add check for modifiers.
8321 * class.cs (MethodData.Define): Update to changes.
8323 2005-04-07 Raja R Harinath <rharinath@novell.com>
8325 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8327 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8329 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8332 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8335 * typemanager.cs: Registered RequiredAttributeAttribute.
8337 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8339 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8340 Warning CS0169 is back at level 3.
8341 (IMethodData.SetMemberIsUsed): New method.
8343 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8344 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8346 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8348 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8350 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8353 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8356 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8357 to avoid the problems with nested types.
8359 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8360 Anoob V.E <projectmonokochi@rediffmail.com>
8361 Harilal P.R <projectmonokochi@rediffmail.com>
8362 Raja R Harinath <rharinath@novell.com>
8365 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8367 * typemanager (GetConstructor): Make public.
8369 2005-04-05 John Luke <john.luke@gmail.com>
8370 Raja R Harinath <rharinath@novell.com>
8373 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8374 struct too. Return false quicker in a few cases.
8375 (VerifyUnManaged): Use it.
8377 2005-04-05 Raja R Harinath <rharinath@novell.com>
8380 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8381 not 'unreachable_seen'.
8383 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8385 * attribute.cs (Attribute.GetValue): Removed unused.
8387 * codegen.cs (CodeGen.TrimExt): Removed unused.
8389 * cs-parser.jay (output): Removed unused.
8391 * cs-tokenizer.cs (hex_digits): Removed unused.
8393 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8395 * expression.cs (Indirection.LoadExprValue): Removed unused.
8396 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8398 * iterators.cs (Iterator.param_types): Removed unused.
8400 * statement.cs (Goto.block): Removed unused.
8401 (ToplevelBlock.did): Removed unused.
8402 (Switch.ResolveConstantSwitch): Removed unused.
8404 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8406 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8409 2005-04-01 Raja R Harinath <rharinath@novell.com>
8411 Fix #74232 and cs0208-3.cs.
8412 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8413 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8414 unmanaged type. Don't use FieldBuilders when 't' is a
8415 TypeBuilder. Use ModFlags and MemberType fields.
8416 * class.cs (MemberBase.member_type): Rename from MemberType.
8417 (MemberBase.MemberType): New property. Determines member_type on
8419 (MemberBase.DoDefine): Don't initialize MemberType here.
8420 (FieldMember.Define): Likewise.
8422 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8425 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8426 Attributes are emitted there.
8428 2005-04-01 Raja R Harinath <rharinath@novell.com>
8430 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8431 keyword in 'partial enum' too.
8432 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8434 Report from Kamil Skalski <nazgul@omega.pl>.
8437 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8438 have partial containers too.
8440 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8441 in block' checks to Block.CheckInvariantMeaningInBlock.
8442 * statement.cs (Block.GetKnownVariableInfo): Make private.
8443 (Block.IsVariableUsedInChildBlock): Remove.
8444 (Block.IsVariableUsedInBlock): Likewise.
8445 (Block.CheckInvariantMeaningInBlock): New. Show location of
8446 conflicting declaration.
8447 (Block.AddVariable): Make error messages less long-winded and more
8448 specific. Show location of conflicting declaration.
8449 * parameter.cs (Parameters.Location): New readonly property.
8451 2005-03-31 Raja R Harinath <rharinath@novell.com>
8453 Clean up semantics of invoking ResolveMemberAccess.
8454 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8455 can have an instance, ensure that we pass in a non-TypeExpression
8456 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8457 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8458 argument. Update to changes and simplify.
8459 (FieldExpr.Emitinstance): Remove CS0120 check.
8460 (PropertyExpr.EmitInstance): Likewise.
8461 * expression.cs (Argument.Resolve): Likewise.
8462 (Invocation.DoResolve): Update to changes in semantics of
8465 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8468 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8471 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8473 2005-03-31 Raja R Harinath <rharinath@novell.com>
8475 Fix difference in behaviour with commandline invocation.
8476 * driver.cs (Driver.Reset): New.
8477 (CompilerCallableEntryPoint): Call it.
8479 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8480 variable" warnings if the boolean expression failed to resolve.
8482 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8484 * attribute.cs: Fix the union of several permissions when some of them
8485 are unrestricted (so the result isn't an unrestricted permission set).
8488 2005-03-30 Raja R Harinath <rharinath@novell.com>
8490 * ecore.cs (MemberExpr): New class. Convert from interface
8492 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8493 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8495 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8496 (MethodGroupExpr.IsExplicitImpl): Remove.
8497 (Expression.GetFieldFromEvent): Remove.
8498 (SimpleName.MemberStaticCheck): Remove.
8499 (SimpleName.DoSimpleNameResolve): Update to changes.
8500 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8501 (MemberAccess.IdenticalNameAndTypeName): Remove.
8502 (MemberAccess.error176): Move to MemberExpr.
8503 (MemberAccess.DoResolve): Update to changes.
8504 (BaseAccess.DoResolve): Likewise.
8506 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8508 C# 2.0 Conditional attribute class implementation
8510 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8511 Analyzes class whether it has attribute which has ConditionalAttribute
8512 and its condition is not defined.
8514 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8515 (Class.IsExcluded): New method. Search for at least one defined
8516 condition in ConditionalAttribute of attribute class.
8518 2005-03-30 Raja R Harinath <rharinath@novell.com>
8520 * ecore.cs (PropertyExpr): Derive from Expression, not
8521 ExpressionStatement.
8522 (PropertyExpr.EmitStatement): Remove.
8524 2005-03-29 Raja R Harinath <rharinath@novell.com>
8527 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8528 internal field "value__" of an enum be private. The examples for
8529 "value__" that I found on MSDN all used FieldAttributes.Private.
8531 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8532 Don't mention IL method attribute names.
8534 Fix #47991. Remove a TODO.
8535 * statement.cs (Block.Toplevel): Make into a field.
8536 (Block.Parameters): Move into ToplevelBlock.
8537 (Block.known_variables): Rename from child_variable_names.
8538 (Block.Block): Remove variants that take Parameters. Initialize
8539 'Toplevel' with the immediately surrounding toplevel block.
8540 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8541 LocalInfo parameter.
8542 (Block.GetKnownVariableInfo): New.
8543 (Block.IsVariableNameUsedInChildBlock): Update.
8544 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8545 the block, even though it may not be in scope.
8546 (Block.AddVariable): Remove Parameters parameter. Use
8547 Toplevel.Parameters instead.
8548 (Block.AddConstant): Remove Parameters parameter.
8549 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8550 (Block.IsParamaterReference): Likewise.
8551 (Block.IsLocalParameter): Likewise. Simplify a lot.
8552 (ToplevelBlock.Parameters): New. Moved from Block.
8553 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8554 initialize Parameters to a non-null value.
8555 * cs-parser.jay: Update to changes.
8556 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8557 simple names that mean different things in the same block. Use
8558 Block.IsVariableNameUsedInBlock.
8560 2005-03-28 Raja R Harinath <rharinath@novell.com>
8562 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8563 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8564 GetTypeHandle. It is possible for a reflected type to derive from
8565 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8566 System.Array during mscorlib compilation).
8567 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8568 contain a method_hash, don't create one either. Don't create a
8569 deep copy of the base cache's method_hash.
8570 (MemberCache.SetupCache): Rename back from DeepCopy.
8571 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8572 already initialized. If we see an override function, add its
8573 underlying base virtual function to the member_hash too.
8575 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8577 2005-03-26 Raja R Harinath <harinath@acm.org>
8580 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8581 fails to resolve, ensure that the LHS is still resolved as an
8584 2005-03-25 Raja R Harinath <harinath@acm.org>
8586 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8588 (Enum.current_ec): Remove.
8589 (Enum.LookupEnumValue): Remove EmitContext argument.
8590 Just uses the one created during DefineType.
8591 (Enum.FindMembers): Update.
8592 * expression.cs (MemberAccess.DoResolve): Update.
8594 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8596 * assign.cs (Assign.DoResolve): Check for CS1717 when
8597 source and target are same (uses Equals).
8599 * expression.cs (LocalVariableReference, ParameterReference,
8600 This): Implemented Equals, GetHashCode.
8602 * statement.cs (Block.GetParameterReference): Removed useless
8605 2005-03-22 Raja R Harinath <rharinath@novell.com>
8608 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8609 blocks before deciding whether the error is cs0136 or cs0128.
8611 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8612 (using_alias_directive, using_namespace_directive): Pass
8613 MemberName, not an expression to Namespace.UsingAlias and
8615 (MakeName): Use the MemberName of the namespace.
8616 * namespace.cs (Namespace.MemberName): New.
8617 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8618 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8620 * decl.cs (MemberName.Name): Make readonly.
8621 (MemberName.FromDotted): New "constructor".
8622 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8623 (MemberCore.Name): Compute from MemberName on demand.
8624 (MemberCore.SetMemberName): Provide a way to change the
8626 (MemberCore.AddToContainer): Don't take a fullname parameter.
8627 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8628 fully qualified name of the container to the member name.
8629 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8630 only if the type is a member of the root container.
8631 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8632 MemberName.Left rather than searching for an embedded ".".
8633 (PartialContainer.CreatePart): Update to changes in RootContext.
8634 (MemberBase.ShortName): Turn into a property. Use
8635 MemberCore.SetMemberName.
8636 (MemberBase.ExplicitInterfaceName): Remove.
8637 (MemberBase.UpdateMemberName): Remove.
8638 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8639 (PropertyBase.SetMemberName): New override.
8640 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8641 (Tree.GetDecl): New.
8642 (Tree.AllDecls): Rename from Decls.
8643 * attribute.cs, enum.cs, report.cs: Update to changes.
8644 * driver.cs (MainDriver): Use MemberName.FromDotted on
8645 RootContext.MainClass.
8647 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8649 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8652 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8654 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8656 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8657 property accessor modifiers.
8659 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8660 fixed buffer attribute (CS1716).
8661 (PropertyMethod.HasCustomAccessModifier): When property accessor
8662 has custom modifier.
8664 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8666 (PropertyExpr.DoResolveLValue): Add CS0272.
8668 2005-03-17 Miguel de Icaza <miguel@novell.com>
8670 * convert.cs: When converting to a pointer, use the proper Conv.U
8671 or Conv.I depending on the source data type.
8673 * cs-tokenizer.cs: Make the size for large decimal constants,
8676 2005-03-17 Martin Baulig <martin@ximian.com>
8678 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8679 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8681 2005-03-17 Martin Baulig <martin@ximian.com>
8683 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8684 to bool so we can return an error condition.
8685 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8688 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8690 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8693 2005-03-16 Raja R Harinath <rharinath@novell.com>
8695 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8696 Refactor to avoid traversing the list of assemblies, and to avoid
8697 string concatenation.
8698 * typemanager.cs (guid_attr_type): Remove.
8699 (negative_hits, pointers, references): Remove hashes.
8701 (GetConstructedType): New. Uses type_hash to handle constructed
8702 types (arrays, references, pointers).
8703 (GetReferenceType, GetPointerType): Use it.
8704 (GetNestedType): New. Uses type_hash to handle nested types of
8706 (LookupType, LookupTypeDirect): Remove.
8707 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8708 'types' hash and LookupTypeReflection directly.
8709 (params_string, params_object): Use GetConstructedType.
8710 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8712 (Namespace.Lookup): Use cached_types.
8713 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8714 provided by old TypeManager.LookupType.
8715 * rootcontext.cs (MakeFQN): Remove.
8716 * decl.cs (DeclSpace.MakeFQN): Likewise.
8717 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8718 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8719 TypeManager.GetConstructedType.
8720 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8722 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8724 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8727 * cs-parser.jay: Reports CS1527 for any namespace element.
8729 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8732 * expression.cs (ParameterReference.IsAssigned): Changed error to
8734 (Error_WrongNumArguments): Moved CS0245 detection here.
8736 * statement.cs (Return.Resolve): Add CS1622 report.
8738 2005-03-11 Marek Safar <marek.safar@seznam.cz>
8740 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
8742 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
8744 * attribute.cs expression.cs: Get rid of some allocations.
8746 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
8748 * doc.cs : just eliminate the latest change.
8750 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8752 * doc.cs : commented out the latest change. It breaks xml-030.cs
8754 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8756 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
8757 fail. So invoke CreateType() in FindDocumentedType().
8759 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8761 * cs-tokenizer.cs : added IsKeyword().
8762 * doc.cs : Detect keyword incorrectly used as identifier.
8763 Allow identifiers prefixed by @.
8765 2005-03-10 Marek Safar <marek.safar@seznam.cz>
8767 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
8768 It caused exception in namespace resolving (again!).
8770 * class.cs (Class.ctor): Removed exit.
8771 (PropertyMethod.ctor): ditto.
8773 * codegen.cs (Codegen.Reset): Reset static data.
8774 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
8776 * cs-tokenizer.cs (Cleanup): Removed.
8778 * driver.cs (GetSystemDir): Rewrote to one line command.
8779 It caused problem with unloaded dynamic modules.
8780 (UnixParseOption): Removed Exit.
8781 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
8782 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
8783 Now can be mcs used as library.
8785 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
8788 * location.cs (Reset): Reset static data.
8790 * namespace.cs (Reset): Reset static data.
8792 * report.cs (Report.Reset): Reset static data.
8794 * rootcontext.cs (RootContext.Reset): Reset static data.
8796 * tree.cs (RootTypes.ctor): Use Location.Null
8798 * typemanager.cs (TypeManager.Reset): Reset static data.
8799 (CoreLookupType): Removed Exit.
8800 (TypeHandle.Reset): Reset static data.
8802 2005-03-10 Raja R Harinath <rharinath@novell.com>
8805 * typemanager.cs (ComputeNamespaces): Import namespaces from
8806 referenced modules too.
8808 2005-03-09 Raja R Harinath <rharinath@novell.com>
8810 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
8813 2005-03-09 Raja R Harinath <rharinath@novell.com>
8815 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
8816 enclosing DeclSpace. This ensures that a name-lookup populates
8817 more caches and there are fewer 'TypeExpression's. Carve out
8818 nested type lookup into ...
8819 (LookupNestedTypeInHierarchy): ... this.
8821 2005-03-09 Raja R Harinath <rharinath@novell.com>
8823 Clean up a few partial-class semantics.
8824 Fixes test-357.cs and cs1618-2.cs.
8825 * cs-parser.jay (struct_declaration): Use 'current_class' as
8826 parent of newly-created struct. Remove call to Register ().
8827 Use 'pop_current_class' to complete handing the current struct.
8828 (interface_declaration): Likewise.
8829 (class_declaration): Likewise.
8830 (enum_declaration): Use 'current_class' as parent of newly created
8832 (delegate_declaration): Likewise.
8833 (pop_current_class): New function. This is used to handle closing
8834 up the 'current_class' and 'current_container', and pointing them
8835 to the enclosing class/container.
8836 (CSharpParser): Initialize 'current_class' too.
8837 * decl.cs (MemberCore): Add check for invariant: a partial
8838 container is not a parsed entity, and thus does not enclose any
8840 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
8841 (DeclSpace.BaseTypeExpr): Use it.
8842 (DeclSpace.LookupType): Add check for invariant.
8843 * class.cs (TypeContainer): Add check for invariant: a nested
8844 class should have the same NamespaceEntry as its enclosing class.
8845 (TypeContainer.EmitFieldInitializers): Make virtual.
8846 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
8848 (TypeContainer.Register): Remove.
8849 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
8850 null. Use TypeResolveEmitContext for resolving base types and
8851 interfaces. Move initialization of Parts.TypeBuilder here from
8853 (TypeContainer.DefineNestedTypes): ... here.
8854 (PartialContainer): Take a Namespace not a NamespaceEntry.
8855 (PartialContainer.Create): Don't use Register. Call the
8856 appropriate Add... function directly.
8857 (ClassPart): Take both the PartialContainer and the enclosing
8858 class as constructor arguments.
8859 (ClassPart.EmitFieldInitializers): Override.
8860 (ClassPart.PartFindNestedTypes): Remove.
8861 (FieldBase.GetInitializerExpression): Resolve the initializer
8862 expression in the emit context of the enclosing class.
8863 * tree.cs (RootTypes): Remove Register ().
8865 2005-03-08 Marek Safar <marek.safar@seznam.cz>
8867 * cs-parser.jay: Removed CS0134.
8869 * driver.cs: Removed CS1901.
8871 * expression.cs (SizeOf.DoResolve): Don't report CS0233
8872 for predefined types.
8874 2005-03-07 Duncan Mak <duncan@novell.com>
8876 * codegen.cs (Save): Catch UnauthorizedAccessException as
8877 well. Fixes bug #73454.
8879 2005-03-07 Marek Safar <marek.safar@seznam.cz>
8881 * cs-tokenizer.cs (xtoken): Add CS1035.
8883 * class.cs (MethodData.Define): Add CS0683.
8884 (FieldMember.ctor): Add CS0681.
8886 2005-03-07 Raja R Harinath <rharinath@novell.com>
8888 * ecore.cs (SimpleName.DoResolve): Rename from
8889 SimpleName.DoResolveAllowStatic.
8890 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
8891 Pass 'intermediate' flag to MemberStaticCheck.
8892 (SimpleName.MemberStaticCheck): Skip "static check" only in case
8893 of "intermediate" lookups via MemberAccess.
8894 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
8895 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
8897 2005-03-07 Raja R Harinath <rharinath@novell.com>
8900 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
8901 slipped in because of variable names that are identical to a
8902 builtin type's BCL equivalent ('string String;', 'int Int32;').
8903 (PropertyExpr.EmitInstance): Likewise.
8905 2005-03-04 Marek Safar <marek.safar@seznam.cz>
8907 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
8909 * report.cs (warning_ignore_table): Made public.
8911 2005-03-04 Raja R Harinath <rharinath@novell.com>
8914 * class.cs (MethodData.Emit): Pass 'container' to
8915 container.GetObsoleteAttribute instead of 'container.Parent'.
8917 2005-03-03 Marek Safar <marek.safar@seznam.cz>
8919 * cs-parser.jay: Add 1534 error test.
8921 * iterators.cs (Yield.CheckContext): Add error 1629.
8922 (Iterator.ctor): Save unsafe modifier.
8923 (MoveNextMethod.DoEmit): Restore unsafe context.
8925 * namespace.cs (UsingAlias): Better error message.
8927 2005-03-03 Dan Winship <danw@novell.com>
8929 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
8930 the warning message [#73219]
8932 2005-03-03 Raja R Harinath <rharinath@novell.com>
8934 Fix compile with MCS 1.0.0.0.
8935 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
8936 w_restore to not depend on string constant folding.
8938 2005-03-03 Raja R Harinath <rharinath@novell.com>
8940 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
8941 CS0246 check to users who passed 'silent = false'.
8942 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
8944 (SimpleName.SimpleNameResolve): Update.
8945 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
8946 (MemberAccess.IdenticalNameAndTypeName): Update.
8947 * doc.cs (FindDocumentedTypeNonArray): Update.
8949 2005-03-03 Raja R Harinath <rharinath@novell.com>
8951 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
8952 * parameters.cs (ComputeAndDefineParameters): Remove.
8953 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
8954 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
8955 Use GetParameterInfo.
8957 2005-03-02 Marek Safar <marek.safar@seznam.cz>
8959 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
8961 2005-03-02 Raja R Harinath <rharinath@novell.com>
8963 Unify DeclSpace.LookupType and DeclSpace.FindType.
8964 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
8965 is in charge of defining nested types on demand.
8966 (DeclSpace.LookupType): Use it when the current_type is a
8967 TypeBuilder. Use LookupTypeDirect for reflected types.
8968 (DeclSpace.FindType): Remove.
8969 (DeclSpace.LookupInterfaceOrClass): Likewise.
8970 (DeclSpace.DefineTypeAndParents): Likewise.
8971 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
8972 DeclSpace.LookupType.
8973 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
8974 * typemanager.cs (LookupType): Simplify.
8975 (AddUserType): Remove type from negative_hits.
8976 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
8977 * class.cs (TypeContainer.FindMembers): Move handling of nested
8979 (TypeContainer.FindMembers_NestedTypes): ... here.
8980 (TypeContainer.FindNestedType): Implement override.
8981 (ClassPart.FindNestedType): Delegate to PartialContainer.
8982 (ClassPart.PartFindNestedType): Looks up the nested types of the
8985 2005-03-02 Martin Baulig <martin@ximian.com>
8987 * class.cs (TypeContainer.DoDefineMembers): We also need a default
8988 static constructor in static classes.
8990 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
8992 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
8993 sizeParamIndex is not specified.
8995 2005-03-01 Marek Safar <marek.safar@seznam.cz>
8998 * report.cs (WarningMessage.IsEnabled): Missing null check.
9000 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9002 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9003 in the fields and not in the properties.
9005 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9007 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9010 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9012 * attribute.cs: Small refactoring (improved robustness).
9013 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9014 (ValidateGuid): Removed.
9015 (Resolve): Removed referenced to above mentioned.
9016 (GetAttributeUsage): Made private and changed to work without
9018 (GetIndexerAttributeValue): Don't crash.
9019 (GetConditionalAttributeValue): Ditto.
9020 (GetClsCompliantAttributeValue): Ditto.
9021 (ExtractSecurityPermissionSet): All attributes exceptions are
9023 (GetPropertyValue): New helper.
9024 (GetMethodImplOptions): New method.
9025 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9026 some missing properties.
9028 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9029 (Method.ApplyAttributeBuilder): Updated.
9031 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9034 2005-02-28 Raja R Harinath <rharinath@novell.com>
9037 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9038 non-simple types (array, pointer, reference).
9040 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9042 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9044 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9046 (Method.CheckBase): Catch wrong destructor here.
9047 (MethodData.Define): Add errors 550, 668.
9049 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9051 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9053 * pending.cs (VerifyPendingMethods): Add error 551.
9055 * typemanager.cs (CSharpName): Next error report helper.
9057 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9059 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9060 attributes. Removed useless attribute double check.
9061 It saves almost 2MBs for corlib.
9063 2005-02-25 Raja R Harinath <rharinath@novell.com>
9066 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9067 called twice in case of error.
9069 2005-02-23 Chris Toshok <toshok@ximian.com>
9071 Fix compiler portions of #72827.
9072 * statement.cs (Block.Emit): call Begin/EndScope on the
9073 EmitContext instead of the ILGenerator.
9075 * codegen.cs (EmitContext.BeginScope): new method, call
9076 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9078 (EmitContext.BeginScope): same, but EndScope and CloseScope
9080 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9081 offset and call the superclass's OpenScope(int) with it.
9082 (SymbolWriter.CloseScope): get the current il
9083 offset and call superclass's CloseScope(int) with it.
9085 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9087 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9088 CS1677 for out and ref as well.
9090 * class.cs (Method.Define): Add error CS1599 detection.
9092 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9094 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9096 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9098 * support.cs.cs (ModifierDesc): New helper method.
9100 2005-02-23 Raja R Harinath <rharinath@novell.com>
9101 Abin Thomas <projectmonokochi@rediffmail.com>
9102 Anoob V E <projectmonokochi@rediffmail.com>
9103 Harilal P R <projectmonokochi@rediffmail.com>
9106 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9107 MemberLookup (used for error reporting) actually returns a result.
9108 Fix error report number (122, not 112).
9110 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9111 Anoob V E <projectmonokochi@rediffmail.com>
9112 Harilal P R <projectmonokochi@rediffmail.com>
9115 * pending.cs (PendingImplementation.GetAbstractMethods):
9116 Find NonPublic members too.
9118 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9120 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9123 * class.cs (MethodCore.CheckMethodAgainstBase):
9124 Add error 239 report.
9126 2005-02-21 Raja R Harinath <rharinath@novell.com>
9129 * expression.cs (Invocation.IsApplicable): Make public.
9130 (Invocation.IsParamsMethodApplicable): Likewise.
9131 * delegate.cs (Delegate.VerifyApplicability): Don't use
9132 Invocation.VerifyArgumentCompat for parameter applicability
9133 testing. Use Invocation.IsApplicable and
9134 Invocation.IsParamsMethodApplicable.
9136 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9138 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9140 * class.cs (Operator.Define): Add error 217 report.
9142 2005-02-21 Raja R Harinath <rharinath@novell.com>
9144 * namespace.cs (UsingEntry.Resolve): Undo change below.
9146 2005-02-21 Raja R Harinath <rharinath@novell.com>
9149 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9150 disable the error message when the extended MemberLookup also
9152 (Expression.MemberLookupFinal): Update.
9153 (SimpleName.DoSimpleNameResolve): Update.
9154 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9155 Don't use MemberLookupFinal.
9156 (New.DoResolve): Update.
9157 (BaseAccess.CommonResolve): Update.
9159 2005-02-21 Raja R Harinath <rharinath@novell.com>
9162 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9163 occured previously, don't resolve again.
9165 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9168 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9169 argument. Call ResolveAttributeUsage for unresolved.
9170 when types doesn't match ctor arguments.
9172 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9173 for nested attribute classes.
9174 (Class.attribute_usage): Removed.
9175 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9176 for attribute class.
9178 * ecore.cs (IsAttribute): Removed.
9180 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9182 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9184 (attribute_types): Removed.
9185 (EmitCode): Global attributes are emited as the latest.
9187 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9189 * class.cs (EmitFieldInitializers): Don't emit field initializer
9190 for default values when optimilization is on.
9192 * constant.cs (Constant.IsDefaultValue): New property.
9194 * driver.cs: Add /optimize handling.
9198 * literal.cs: Implement new IsDefaultValue property.
9200 * rootcontext.cs (Optimize): New field, holds /optimize option.
9202 2005-02-18 Raja R Harinath <rharinath@novell.com>
9204 Fix crasher in re-opened #72347.
9205 * namespace.cs (Namespace.Lookup): Return null if
9206 DeclSpace.DefineType returns null.
9209 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9211 2005-02-18 Raja R Harinath <rharinath@novell.com>
9213 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9214 now returns null if it cannot resolve to an lvalue.
9215 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9216 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9217 returned null. Remove check for SimpleName.
9218 (EventExpr.DoResolveLValue): New.
9219 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9220 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9222 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9224 (Unary.ResolveOperator): Move CS0211 check ...
9225 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9227 (Unary.DoResolveLValue): Simplify.
9228 (AddressOf.DoResolveLValue): New.
9229 (ArrayAccess.DoResolveLValue): New.
9231 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9233 * attribute.cs (Attribute.Resolve): Add arguments casting for
9234 when types doesn't match ctor arguments.
9236 2005-02-16 Raja R Harinath <rharinath@novell.com>
9238 Fix parts of #63202.
9239 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9240 lookup of operator in base type. Ensure that all checks happen
9241 when the operator resolves to an "op_..." method.
9243 2005-02-15 Raja R Harinath <rharinath@novell.com>
9246 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9247 'ignore_cs0104' parameter. Pass it to ...
9248 (NamespaceEntry.Lookup): ... this.
9249 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9250 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9251 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9252 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9253 Update. Request that cs0104 errors be ignored.
9254 (ComposedCast.ResolveAsTypeStep): Update.
9256 2005-02-14 Raja R Harinath <rharinath@novell.com>
9259 * expression.cs (Invocation.BetterFunction): Remove support for
9260 comparing virtual functions and their overrides.
9261 (Invocation.IsOverride): New.
9262 (Invocation.OverloadResolve): Don't consider 'override' functions
9263 during candidate selection. Store them in a lookaside list.
9264 If the selected method is a 'virtual' function, use the list to
9265 find any overrides that are closer to the LHS type.
9267 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9269 * expression.cs (New.DoResolve): Add complex core type reduction.
9270 (New.Constantify): Converts complex core type syntax like 'new int ()'
9273 2005-02-14 Raja R Harinath <rharinath@novell.com>
9275 * decl.cs (EntryType.EntryType): New constructor to create an
9276 updated copy of a cache entry.
9277 (MemberCache.AddMethods): Use it.
9278 (MemberCache.ClearDeclaredOnly): Remove.
9279 (MemberCache.MemberCache): Update.
9281 2005-02-11 Miguel de Icaza <miguel@novell.com>
9283 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9284 variable. This one is represents the actual low-level declaration
9285 of the method, as opposed to the semantic level `IsStatic'.
9287 An anonymous method which is hosted into a static method might be
9288 actually an instance method. IsStatic would reflect the
9289 container, while MethodIsStatic represents the actual code
9292 * expression.cs (ParameterReference): Use the new MethodIsStatic
9293 instead of IsStatic.
9295 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9296 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9297 set on the current EmitContext.
9299 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9300 resolve our casted expression as an LValue. This triggers the
9301 proper LValue processing that is later required by Assign.
9305 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9307 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9309 C# 2.0 Fixed buffer implementation
9311 * anonymous.cs: Update after RegisterHelperClass renaming.
9313 * attribute.cs (AttributeTester.fixed_buffer_cache):
9314 Cache of external fixed buffers.
9315 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9316 implementation if field is fixed buffer else null.
9319 (TypeContainer.AddField): Accept FieldMember instead of Field.
9320 (FieldBase.IsFieldClsCompliant): Extracted code from
9321 VerifyClsCompliance descendant customization.
9322 (FixedField): New class handles fixed buffer fields.
9323 (FixedFieldExternal): Keeps information about imported fixed
9325 (IFixedField): Make access to internal or external fixed buffer
9328 * cs-parser.jay: Add fixed buffer parsing.
9330 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9333 * expression.cs (Indirection): Extended implementation to accept
9335 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9336 (ElementAccess.MakePointerAccess): Get type as parameter.
9337 (DoResolve): Add fixed buffer field expression conversion.
9338 (DoResolveLValue): Ditto.
9339 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9340 (ArrayPtr): Derives from FixedBufferPtr.
9341 (ArrayPtr.Emit): Add extra emit for array elements.
9343 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9345 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9346 for compiler generated types.
9347 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9349 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9350 and consume less memory.
9351 (Fixed.Resolve): Add fixed buffer case.
9353 * typemanager.cs (compiler_generated_attr_ctor,
9354 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9355 (HasElementType): Add our own implementation to work on every
9358 2005-02-11 Miguel de Icaza <miguel@novell.com>
9360 * anonymous.cs (CaptureContext): Track whether `this' has been
9363 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9364 only captured `this' if it was implicitly done (instance
9365 methods/variables were used).
9367 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9368 `this' must be captured.
9370 2005-01-30 Miguel de Icaza <miguel@novell.com>
9372 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9373 is null it means that there has been no need to capture anything,
9374 so we just create a sibling.
9376 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9378 Just a partial fix. The other half is fairly elusive.
9380 2005-02-10 Raja R Harinath <rharinath@novell.com>
9382 Fix #52586, cs0121-4.cs.
9383 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9384 and return a hashtable.
9385 (MemberCache.ClearDeclaredOnly): New.
9386 (MemberCache.MemberCache): Update to change. Make a deep copy of
9387 the method_hash of a base type too.
9388 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9389 type methods. Overwrite entries with the same MethodHandle so
9390 that the ReflectedType is correct. The process leaves in base
9391 virtual functions and their overrides as distinct entries.
9392 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9393 matters since it was boxed in a ArrayList before.
9394 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9396 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9397 case of a virtual function and its override (choose the overload
9399 (Invocation.OverloadResolve): Avoid 'override' members during
9400 'applicable_type' calculation.
9402 2005-02-09 Raja R Harinath <rharinath@novell.com>
9404 Combine two near-redundant caches.
9405 * typemanager.cs (method_params): Rename from method_internal_params.
9406 (TypeManager.GetParameterData): New. Replace
9407 Invocation.GetParameterData.
9408 (TypeManager.LookupParametersByBuilder): Remove.
9409 * expression.cs (Invocation.method_parameter_cache): Remove.
9410 (Invocation.GetParameterData): Remove.
9412 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9415 2005-02-08 Raja R Harinath <rharinath@novell.com>
9418 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9419 TypeManager.multicast_delegate_type is null, resolve it by looking
9420 up "System.MulticastDelegate".
9421 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9423 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9424 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9425 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9428 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9429 (LabeledStatement.AddReference): New. Set 'referenced'.
9430 (Goto.Resolve): Use it.
9432 2005-02-05 John Luke <john.luke@gmail.com>
9434 * driver.cs: remove duplicate -doc line in Usage ()
9436 2005-02-04 Raja R Harinath <rharinath@novell.com>
9438 * location.cs (Location.AddFile): Fix CS2002 error report.
9440 2005-02-02 Martin Baulig <martin@ximian.com>
9442 * delegate.cs (Delegate.DefineType): Report an internal error if
9443 TypeManager.multicast_delegate_type is null. See bug #72015 for
9446 2005-02-02 Raja R Harinath <rharinath@novell.com>
9448 Fix a crasher in a variant of #31984.
9449 * const.cs (Constant.CheckBase): New override that defers the
9450 new-or-override check in case the base type hasn't been populated
9452 (Constant.Define): Ensure the new-or-override check is performed.
9454 2005-02-01 Duncan Mak <duncan@ximian.com>
9456 * const.cs (LookupConstantValue): Check that `ce' is not null
9457 before calling GetValue ().
9459 2005-02-01 Raja R Harinath <rharinath@novell.com>
9461 Fix test-334.cs (#69519).
9462 * cs-parser.jay (using_alias_directive): Pass in an expression to
9463 NamespaceEntry.UsingAlias.
9464 (using_namespace_directive): Pass in an expression to
9465 NamespaceEntry.Using.
9466 (namespace_name): Don't flatten to a string.
9467 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9468 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9470 (NamespaceEntry.UsingEntry): Likewise.
9471 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9473 (NamespaceEntry.LookupForUsing): Remove.
9474 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9476 (NamespaceEntry.Lookup): Remove support for dotted names.
9478 2005-02-01 Raja R Harinath <rharinath@novell.com>
9480 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9482 (NamespaceEntry.ImplicitParent): Compute on demand.
9483 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9484 parallels the current.
9485 (NamespaceEntry.LookupForUsing): Use it.
9486 (NamespaceEntry.Lookup): If the current namespace-entry is
9487 implicit, don't search aliases and using tables.
9489 2005-02-01 Raja R Harinath <rharinath@novell.com>
9492 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9494 (TypeContainer.BaseCache): Compute on demand.
9495 (TypeContainer.FindMembers): Define constants and types if they're
9496 not already created.
9497 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9499 * const.cs (Constant.Define): Make idempotent.
9501 2005-01-29 Miguel de Icaza <miguel@novell.com>
9503 * pending.cs: Produce better code (no nops produced by using Ldarg
9506 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9507 i - 1' it should be arg + 1.
9511 2005-01-28 Raja R Harinath <rharinath@novell.com>
9513 * attribute.cs (Attribute.CheckAttributeType): Make private
9515 (Attribute.ResolveType): Make virtual.
9516 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9517 handling of RootContext.Tree.Types.
9519 2005-01-27 Raja R Harinath <rharinath@novell.com>
9521 Update attribute-handling to use the SimpleName/MemberAccess
9523 * cs-parser.jay (attribute): Pass in an expression to the
9524 constructors of Attribute and GlobalAttribute.
9525 * attribute.cs (Attribute): Take an expression for the name.
9526 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9527 passed in attribute name expression.
9528 (Attribute.CheckAttributeType): Use it.
9529 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9530 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9531 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9532 argument to prevent error messages if the lookup fails.
9534 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9536 * expression.cs (Indirection): Implemented IVariable interface
9537 to support indirection in AddressOf operator.
9538 (PointerArithmetic.Emit): Add optimalization for case where
9539 result can be precomputed.
9541 2005-01-26 Martin Baulig <martin@ximian.com>
9543 * class.cs (TypeContainer.AttributeTargets): Return the correct
9544 AttributeTargets depending on our `Kind' instead of throwing an
9545 exception; fixes #71632.
9547 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9550 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9553 2005-01-25 Raja R Harinath <rharinath@novell.com>
9556 * expression.cs (MemberAccess.DoResolve): Don't complain with
9557 cs0572 when the LHS of a member access has identical name and type
9560 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9563 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9565 Create custom PermissionSet only for PermissionSetAttribute.
9567 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9570 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9571 delegates in static class.
9573 2005-01-24 Martin Baulig <martin@ximian.com>
9575 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9576 merging an implicit block, just use its reachability.
9578 * statement.cs (Block.Resolve): Make the unreachable code check
9579 work wrt. implicit blocks; see test-337 from #63842.
9581 2005-01-21 Alp Toker <alp@atoker.com>
9583 * cs-parser.jay: destructor_declaration's container is PartialContainer
9584 not Class when partial types are used, so use Kind prop instead of
9587 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9589 * cs-parser.jay: Improve error reporting when an interface
9592 2005-01-20 Dick Porter <dick@ximian.com>
9594 * support.cs: SeekableStreamReader fix from Sandor Dobos
9595 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9596 chars are read. Fixes bug 70369.
9598 2005-01-20 Raja R Harinath <rharinath@novell.com>
9600 * cs-parser.jay (catch_clause): Simplify current_block handling
9603 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9605 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9606 code with ImplicitStandardConversion to handle the implicit
9607 conversion of method groups into valid delegate invocations.
9609 The problem is that in parameter handling we were using this code
9610 path. Fixes bug #64698
9612 2005-01-19 Raja R Harinath <rharinath@novell.com>
9614 * cs-parser.jay: Fix several infelicities.
9615 - Avoid assigning to the parser value stack. Code like
9616 '$3 = null' is unclean. Synthesize a value for the code block
9618 - Avoid using oob_stack for storing location information. Use ...
9619 (_mark_): ... this. New (empty) rule. Saves the current location
9621 (foreach_statement): Avoid using oob_stack for current_block
9622 handling. Use technique used in for_statement and
9623 using_statement. Synthesize a value for the code block to store
9624 additional intermediate information.
9626 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9628 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9629 of a different type is only allowed to private fields of a
9630 containing type, not on fields of a base class.
9632 See test-174.cs and error cs0122-9.cs
9634 2005-01-13 Raja R Harinath <rharinath@novell.com>
9636 Fix test-335.cs (bug #58126).
9637 * cs-parser.jay (argument): Split out non-expression parts of the
9638 rule into 'non_simple_argument'.
9639 (invocation_expression): Support parenthesized invocations with
9640 multiple arguments, and with single non-simple arguments.
9642 2005-01-13 Raja R Harinath <rharinath@novell.com>
9644 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9647 2005-01-12 Raja R Harinath <rharinath@novell.com>
9649 Fix cs0038-1.cs, cs1640-6.cs.
9650 * ecore.cs (Expression.Resolve): Remove special-case for
9651 SimpleName in error-handling.
9652 (Expression.almostMatchedMembers): Relax access permission to
9654 (Expression.MemberLookupFailed): Handle duplicates in
9655 almostMatchedMembers list.
9656 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9657 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9658 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9659 overload if the passed in MemberInfo is a MethodBase.
9661 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9664 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9665 for non-CAS & merge permission sets properly.
9667 2005-01-11 Raja R Harinath <rharinath@novell.com>
9669 Improve standard-compliance of simple name and member access
9670 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9671 * ecore.cs (FullNamedExpression): New abstract base class
9672 for Namespaces and TypeExpressions.
9673 (ResolveFlags.SimpleName): Remove.
9674 (SimpleName): Remove support for dotted names.
9675 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9676 DeclSpace.FindType and DeclSpace.LookupType.
9677 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9678 (Expression.ExprClassName): Make member function.
9679 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9680 a namespace. Remove creation of dotted "SimpleName"s.
9681 (MemberAccess.DoResolve): Likewise.
9682 * decl.cs (DeclSpace.Cache): Make private.
9683 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9684 (DeclSpace.FindType): Update.
9685 (DeclSpace.LookupType): Move here from RootContext. Return a
9686 FullNamedExpression.
9687 * namespace.cs (Namespace): Derive from FullNamedExpression
9688 so that it can be part of expression resolution.
9689 (Namespace.Lookup): Return an FullNamedExpression.
9690 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9692 * rootcontext.cs (NamespaceLookup): Remove.
9693 (LookupType): Move to DeclSpace.
9694 * attribute.cs (CheckAttributeType): Update.
9695 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9696 (FindDocumentedTypeNonArray): Likewise.
9698 2005-01-11 Raja R Harinath <rharinath@novell.com>
9700 Fix cs0509.cs, cs1632.cs.
9701 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9702 is the same as IsInterface.
9703 (TypeContainer.GetClassBases): Likewise.
9704 * statement.cs (LabeledStatement.ig): New field.
9705 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9707 (LabeledStatement.DoEmit): Check that the label was created with
9708 the same ILGenerator.
9710 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9713 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9714 accessors to its properties.
9716 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9717 from accessors to property.
9719 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9722 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9725 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9727 * attribute.cs: Check for null and empty strings.
9729 I have lost another battle to Paolo.
9731 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9734 * class.cs (PropertyMethod): Set Parent field in ctors.
9735 (SetMethod.InternalParameters): Add unsafe switch hack.
9736 Override MarkForDuplicationCheck where it is appropriate.
9738 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
9739 It says whether container allows members with the same name.
9741 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
9742 Removed is_method parameter.
9744 2005-01-06 Duncan Mak <duncan@ximian.com>
9746 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
9747 because the previous change led to incorrect reporting of CS1032
9748 ("Cannot define/undefine preprocessor symbols after first token in
9749 file"). Instead of using `tokens_seen' as the only flag that
9750 triggers CS1040, introduce `comments_seen'. This new flag is used
9751 to signify having seen comments on the current line, so it is
9752 unset after a newline.
9754 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9756 * doc.cs : When searching for a type, find nested type too.
9757 This fixes bug #71040.
9759 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9762 - Warn missing member comment on those classes which also does not
9763 have doc comments. Fixed bug #71041.
9764 - Don't warn missing doc comment on default constructor.
9767 2005-01-06 Duncan Mak <duncan@ximian.com>
9769 * cs-tokenizer.cs (xtoken): After handling traditional C-style
9770 comments, set `tokens_seen' to true. This allows us to detect
9771 misplaced preprocessor directives (i.e. not at the beginning of
9772 the a line, nor after whitespaces). In that case, report error
9773 CS1040. This fixes bug #56460.
9775 * cs-parser.jay (interface_member_declaration): Add checks for
9776 IsExplicitImpl, and report CS0541 error if an interface member is
9777 defined as an explicit interface declaration.
9779 2005-01-06 Marek Safar <marek.safar@seznam.cz>
9782 * class.cs (PropertyMethod): Set Parent field in ctors.
9783 (SetMethod.InternalParameters): Add unsafe switch hack.
9785 * decl.cs (MemberCore.Parent): Cannot be readonly.
9787 2005-01-06 Raja R Harinath <rharinath@novell.com>
9789 * decl.cs (DeclSpace.ResolveType): Remove.
9790 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
9791 Merge in code from ...
9792 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
9793 * class.cs, enum.cs: Update to changes.
9795 2005-01-06 Miguel de Icaza <miguel@ximian.com>
9797 * anonymous.cs: Ensure that we init the scope of our parent if it
9798 has not been initialized yet.
9800 2004-12-30 Duncan Mak <duncan@ximian.com>
9802 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
9803 if field.FieldBuilder is null. Fixes #70758.
9805 * convert.cs: Fixed some typos and updated some of the comments.
9806 (ImplicitStandardConversionExists):
9807 (TryImplicitIntConversion): If `target_type' is an interface and
9808 the type of `ic' implements this interface, return true or a new
9809 BoxedCast instead of null. This fixes #70468.
9811 2004-12-29 Duncan Mak <duncan@ximian.com>
9813 * expression.cs (Argument.Emit): Check that Expr is
9814 IMemoryLocation before casting to it, and report CS1510 otherwise.
9818 2004-12-21 Ben Maurer <bmaurer@ximian.com>
9820 * statement.cs (Block.ThisVariable): remove the recursion here, to
9821 make the --profile more sane.
9823 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
9825 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
9826 assembly, by JB Evain.
9828 2004-12-17 Raja R Harinath <rharinath@novell.com>
9830 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
9831 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
9832 "parent" refers to enclosing type/class. "base" refers to superclass.
9834 2004-12-17 Raja R Harinath <rharinath@novell.com>
9836 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
9837 Ensure that we only have GlobalAttributes.
9838 * attribute.cs (Attribute.Emit): Make non-virtual.
9839 (GlobalAttribute.Emit): Remove.
9840 (Attribute.Resolve): Make virtual.
9841 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
9842 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
9843 the argument. Don't create one.
9844 (Attribute.GetObsoleteAttribute): Likewise.
9845 (Attribute.GetClsCompliantAttributeValue): Likewise.
9846 * class.cs, decl.cs: Update to changes.
9848 2004-12-17 Marek Safar <marek.safar@seznam.cz>
9850 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
9852 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
9854 * statement.cs (Foreach.Resolve): Add error 186 report.
9856 2004-12-16 Marek Safar <marek.safar@seznam.cz>
9858 * expression.cs (Conditional.DoResolve): Add warning 429.
9860 * statement.cs (If.Resolve): Add warning 665.
9862 2004-12-16 Raja R Harinath <rharinath@novell.com>
9864 New invariant: RootContext.Tree.Types.NamespaceEntry == null
9865 except when in the parser, and in GlobalAttribute.
9866 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
9867 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
9868 RootContext.Tree.Types.NamespaceEntry once work is done.
9869 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
9870 and resets RootContext.Tree.Types.NamespaceEntry.
9872 2004-12-15 Marek Safar <marek.safar@seznam.cz>
9874 * cs-parser.jay: Don't create a block for every variable.
9876 2004-12-14 Miguel de Icaza <miguel@ximian.com>
9878 * location.cs: Provide extra information.
9880 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
9881 variables from the captured environment, it is the ldarg_0.
9883 2004-12-14 Marek Safar <marek.safar@seznam.cz>
9885 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
9888 * class.cs: Changed warning level for 169 to avoid developer
9889 displeasure from warning flooding. It will be changed back when they
9890 fix most of current BCL warnings.
9892 * RootContext.cs: Pushed default WarningLevel to 3.
9894 * statement.cs: Removed unused variable.
9896 2004-12-14 Marek Safar <marek.safar@seznam.cz>
9898 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
9899 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
9900 Add error 502 report.
9901 (StaticClass.DefineType): Add error 441 report.
9902 (Class.AllowedModifiersProp): New virtual property as temporary
9903 extension to AllowedModifiers.
9904 (Class.DefineType): Add error 418 report. Moved ModFlags check here
9905 to share implementation with StaticClass and don't call virtual
9908 * driver.cs (MainDriver): Add error 1558 test.
9910 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
9911 report. Moved error 36 test here.
9913 * statement.cs (Throw.Resolve): Add error 724 report.
9915 * typemanager.cs: Add out_attribute_type core type.
9917 2004-12-13 Marek Safar <marek.safar@seznam.cz>
9919 * class.cs (TypeContainer.VerifyClsCompliance): Add error
9921 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
9923 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
9926 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
9928 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
9929 Add error 3023 report.
9930 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
9932 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
9935 2004-12-12 John Luke <john.luke@gmail.com>
9937 * driver.cs (AddArgs): take -- into account when
9938 adding arguments, fixes bug 65710
9940 2004-12-12 Martin Baulig <martin@ximian.com>
9942 * expression.cs (Unary.TryReduceNegative): Added support for
9943 SByteConstant and ByteConstant.
9944 (Unary.Reduce): Check error values from TryReduceNegative().
9946 2004-12-10 Marek Safar <marek.safar@seznam.cz>
9948 * attributes.cs (Attribute.Resolve): Avoid multiple error report
9949 and report exception as error 182.
9951 2004-12-10 Raja R Harinath <rharinath@novell.com>
9953 * driver.cs (Main): Fix message when there are warnings.
9955 2004-12-09 Miguel de Icaza <miguel@ximian.com>
9957 * delegate.cs: Fixed my fix from yesterday, sorry about that.
9959 2004-12-09 Marek Safar <marek.safar@seznam.cz>
9961 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
9962 Reduced number of warnings.
9964 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
9966 2004-12-08 Miguel de Icaza <miguel@ximian.com>
9968 * driver.cs: Removed message.
9970 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
9972 2004-12-08 <vargaz@freemail.hu>
9974 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
9976 2004-12-08 Martin Baulig <martin@ximian.com>
9978 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
9979 instead of a CS3002 for properties and indexer.
9981 2004-12-08 Martin Baulig <martin@ximian.com>
9983 * decl.cs (MemberName.ToString): Make this work again.
9985 2004-12-08 Marek Safar <marek.safar@seznam.cz>
9987 * attribute.cs (Resolve): Add error 591 detection.
9989 * class.cs (FieldMember.Define): Add error 1547 detection.
9990 (Indexer.Define): Add error 620 detection.
9991 (Operator.Define): Add error 590 detection.
9993 * ecore.cs: Missing argument for error 79.
9995 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
9998 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10001 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10004 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10006 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10007 Some operator comments were suppressed.
10008 * doc.cs : Implicit/explicit operator name in doc comments are like
10009 "op_Explicit(type)~returnType", so added suffix handling.
10011 2004-12-07 Martin Baulig <martin@ximian.com>
10014 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10015 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10016 (DeclSpace.ec): New protected field; store the EmitContext here.
10017 (DeclSpace.EmitContext): New public property; moved here from
10019 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10022 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10023 (Enum.Emit): Don't create a new EmitContext.
10025 * delegate.cs (Delegate.DefineType): Always create the
10028 * iterators.cs (Iterators.DefineIterator): Create a new
10029 EmitContext and store it in `ec'.
10031 2004-08-24 Martin Baulig <martin@ximian.com>
10034 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10035 this for accessibility checks.
10036 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10037 IsNestedFamilyAccessible.
10038 (TypeManager.IsSubclassOf): New method, do what the name actually
10041 2004-12-06 Raja R Harinath <rharinath@novell.com>
10043 Fix crash on cs0657-17.cs.
10044 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10045 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10046 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10047 the case where the NamespaceEntry gets overwritten.
10049 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10051 Fixed #69195, #56821
10052 * ecore.cs (ResolveBoolean): Tiny refactoring.
10054 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10055 of right expression resolving when left is false constant and
10056 operator is LogicalAnd OR true constant and operator is LogicalOr.
10058 * statement.cs (ResolveUnreachable): Always reports warning.
10060 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10062 * class.cs: Distinguish between 1721 and 1722 (just a little help
10063 for the programmer).
10065 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10067 * delegate.cs: Only allow this on new versions of the language.
10069 2004-12-02 Duncan Mak <duncan@ximian.com>
10071 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10073 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10074 here as a static method. Take an additional bool out parameter
10075 `must_do_cs1540_check' for signaling to InstanceResolve.
10076 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10077 member field from PropertyExpr class and made it an argument of
10078 the method instead.
10079 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10080 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10081 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10082 and `remove_accessor' as well as InstanceResolve: report CS0122
10087 2004-12-03 Raja R Harinath <rharinath@novell.com>
10089 Fix test-327.cs, test-328.cs, and put in early infrastructure
10090 for eventually fixing #52697.
10091 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10092 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10093 from other methods.
10094 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10095 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10096 (VerifyUsing, error246): Update.
10097 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10098 'NamespaceEntry.LookupNamespaceOrType'.
10100 2004-12-03 Martin Baulig <martin@ximian.com>
10102 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10103 method as our child, call AnonymousMethod.Compatible() on it.
10105 2004-12-03 Raja R Harinath <rharinath@novell.com>
10107 Disable XML documentation support in 'basic' profile.
10108 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10109 Redirect XmlElement to System.Object.
10110 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10111 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10112 * mcs.exe.sources: Add doc-bootstrap.cs.
10113 * doc-bootstrap.cs: New file. Contains empty stub implementation
10116 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10118 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10119 comments are allowed.
10121 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10123 * delegate.cs: Add checks for subtypes in paramaters and return values
10124 in VerifyMethod () to add support for Covariance/Contravariance
10127 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10129 * report.cs: Remove extra closing parenthesis.
10131 * convert.cs (Error_CannotImplicitConversion): If the name of the
10132 types are the same, provide some extra information.
10134 * class.cs (FieldBase): Use an unused bit field from the field to
10135 encode the `has_offset' property from the FieldMember. This saves
10136 a couple of Ks on bootstrap compilation.
10138 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10139 method as our child, return the AnonymousMethod resolved
10142 * expression.cs (New.DoResolve): Allow return values from
10143 NewDelegate to also include AnonymousMethods.
10147 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10150 * attribute.cs (Resolve): Improved implementation of params
10151 attribute arguments.
10153 * support.cs (ParameterData): Add HasParams to be faster.
10155 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10157 all things are for /doc support:
10159 * doc.cs: new file that supports XML documentation generation.
10160 * mcs.exe.sources: added doc.cs.
10162 Handle /doc command line option.
10163 Report error 2006 instead of 5 for missing file name for /doc.
10164 Generate XML documentation when required, after type resolution.
10166 Added support for picking up documentation (/// and /** ... */),
10167 including a new XmlCommentState enumeration.
10169 Added lines to fill Documentation element for field, constant,
10170 property, indexer, method, constructor, destructor, operator, event
10171 and class, struct, interface, delegate, enum.
10172 Added lines to warn incorrect comment.
10174 Added Documentation field (passed only when /doc was specified).
10176 Added DocComment, DocCommentHeader, GenerateDocComment() and
10177 OnGenerateDocComment() and some supporting private members for
10178 /doc feature to MemberCore.
10180 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10182 Added overriden DocCommentHeader.
10184 Added overriden DocCommentHeader and GenerateDocComment().
10186 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10188 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10189 unwrapping the enumeration values, chain to
10190 DoConstantNumericPromotions again, so we can promote things to the
10191 fundamental types (takes care of enums that are bytes, sbytes).
10195 2004-12-01 Raja R Harinath <rharinath@novell.com>
10197 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10198 Fix long-standing bug in type-lookup. Use FindType instead of
10199 LookupType when ec.ResolvingTypeTree.
10200 (Attribute.ResolveType, Attribute.Resolve)
10201 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10203 (Attributes.Search): Remove internal version. Update.
10204 (Attributes.SearchMulti): Update.
10205 (Attributes.GetClsCompliantAttribute): Remove.
10206 (Attributes.GetIndexerNameAttribute): Remove.
10207 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10208 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10209 * class.cs (Indexer.Define): Likewise.
10211 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10214 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10215 MarshallByReference members access.
10217 * expression.cs: Use CheckMarshallByRefAccess;
10218 Better error CS0197 message.
10220 * report.cs: Print whole related error message.
10222 2004-11-30 Raja R Harinath <rharinath@novell.com>
10224 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10225 the current directory to help debugging.
10227 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10229 * class (GetClassBases): Better error 60 report.
10230 (EventProperty): Disabled warning 67 detection.
10232 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10235 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10237 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10240 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10243 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10245 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10247 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10249 * attribute.cs (Attribute.Resolve): Refine error reporting and
10250 report a cs0117 if the identifier does not exist, to distinguish
10251 from 0617 which is a miss-use of the actual identifier.
10253 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10254 between cs0070 and cs0079.
10256 * class.cs (MemberBase.DoDefine): When reporting a wrong
10257 accessibility level, we use MethodCore to compare instead of
10258 Method (this was a regression in some refactoring effort).
10260 So now we correctly report cs0056 again.
10262 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10263 testing the target_type (which was known to be object_type) and
10264 not the source type (which is anonymous_method).
10266 Fixed reporting of error cs1660.
10268 * expression.cs (UserCast.Source): Expose the underlying cast.
10270 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10271 allowed types to find a match to int32 first (most common).
10273 In addition, it ignores any ImplicitUserConversions that did an
10274 internal implicit conversion (as the switch statement allows only
10275 one integral conversion to exist).
10277 * class.cs (PartialContainer.Create): rename `name' to
10278 `member_name' for clarity. Then replace the string calls with a
10279 call to MemberName.GetPartialName, as now using
10280 MemberName.ToString is an error (this is due to the side effects
10281 it had, that were fixed in the past).
10283 This will restore the error reporting on a number of partial class
10284 errors that were missusing this (and getting an exception as a
10285 results, which is now just a plain textual warning, because
10286 yyparse debug output would crash otherwise).
10288 2004-11-26 Raja R Harinath <rharinath@novell.com>
10290 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10292 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10294 * rootcontext.cs (LookupType): Make sure to cache lookups that
10295 don't give us a negative result. This saves about 5% of corlib
10298 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10300 * report.cs (AbstractMessage.Print): messages are sent to stderr
10302 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10303 non-interface in the list of interfaces (at this point, either
10304 parent was properly set, or a base class is being listed in the
10305 interfaces section).
10307 This flags error 1722, and resolves the crash from bug 69259.
10309 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10311 * statement.cs (Using.EmitExpressionFinally): make this work right
10312 for valuetypes. Fixes 69926.
10314 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10316 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10317 converted to an enum" here, before we try to change the underlying
10318 type. This code exists, but it is a different code path than the
10319 one used while encoding constants.
10321 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10322 old bug: when converting from the null literal to a pointer,
10323 return an EmptyCast, not the NullLiteral.
10325 This fixes #69921, the recent null_type changes probably made this
10326 bug more prominent.
10328 (ImplicitReferenceConversionExists): In addition, resynchronized
10329 the code here, so it matches the same code in
10330 ImplicitReferenceConversionExists for the `from any class-type S
10331 to any interface-type T'.
10334 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10336 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10338 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10340 * cs-parser.jay: Use verbosity accordingly.
10342 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10344 * expression.cs (Unary.ResolveOperator): Do not report warning;
10345 AddressOf reads from variable.
10347 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10349 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10353 * attribute.cs (Attributable): Removed CheckTargets.
10354 (Attributes.Emit): Explicit attribute targets are tested here.
10356 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10357 not enabled for interfaces.
10359 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10360 (GetAssemblyName): Ouch next bug there.
10362 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10364 * expression.cs: Error 275 added.
10366 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10368 Fix bug #69177 (Implemented decimal constant support)
10370 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10371 (BinaryFold): Add DecimalConstant.
10373 * const.cs (Define): Decimal constant
10375 (ChangeType): Add decimal type handling.
10376 (LookupConstantValue): Don't set value for decimal type but
10377 emit DecimalConstantAttribute. Needed for constant optimization.
10379 * constant.cs (ToDecimal): New method.
10380 (ConvertToDecimal): New method.
10381 (IntConstant): Implemented ConvertToDecimal.
10382 (DecimalConstant.Emit): Emit optimized version for decimals in
10385 * expression.cs (ResolveOperator): Changed order of constant
10386 reduction to work correctly with native types which have
10387 overloaded operators.
10388 (ResolveMemberAccess): Extract constant value from attribute
10391 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10393 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10394 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10395 (ChangeType): Decimal is special.
10396 (TypeToCoreType): Add decimal type.
10398 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10400 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10403 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10405 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10408 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10410 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10412 * pending.cs (PendingImplementation): Grab only interfaces.
10414 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10416 * statement.cs (ForeachHelperMethods): Add location member and
10417 error 202 detection.
10419 2004-11-19 Raja R Harinath <rharinath@novell.com>
10421 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10422 automatically handled by executable.make.
10423 (PROGRAM): Make profile-specific.
10425 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10427 * expression.cs (DoResolveBase): Fixed wrong warning for out
10430 2004-11-18 Martin Baulig <martin@ximian.com>
10432 Merged latest changes into gmcs. Please keep this comment in
10433 here, it makes it easier for me to see what changed in MCS since
10434 the last time I merged.
10436 2004-11-17 Raja R Harinath <rharinath@novell.com>
10438 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10439 (TypeHandle.GetMemberCache): New.
10440 (TypeHandle.TypeHandle): Update.
10441 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10442 (TypeManager.LookupParentInterfacesCache):
10443 Rename from LookupInterfaceCache. Optimize slightly.
10444 (TypeManager.MemberLookup_FindMembers): Update.
10445 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10446 multi-type variant.
10447 (AddCacheContents): Rename from AddHashtable.
10448 * class.cs (TypeContainer.parent_container): Remove.
10449 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10450 (TypeContainer.DoDefineMembers): Don't initialize it.
10451 Update to name changes.
10453 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10455 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10456 that factors the code to check access modifiers on override.
10458 (PropertyBase): Use the code here.
10460 Patch from Lluis S'anchez, fixes bug #69361.
10462 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10464 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10465 routine that is used to report the use of a captured variable
10466 whose address has been taken.
10468 There are two checks: one when variables are being captured and
10469 the other check is when the address of a variable is taken.
10471 (because an anonymous methods might be resolved before *or* after
10472 the address has been taken) and
10474 * expression.cs (Conditional.DoResolve): Remove the special
10475 casing that Martin added to trueExpr and falseExpr being both
10476 NullLiteral. We get the right behavior now just by introducing
10477 the null_type into the compiler.
10479 * convert.cs (ExplicitConversion): Change the code to use
10480 null_type instead of testing `expr is NullLiteral'.
10481 (ImplicitConversionStandard): use null_type too.
10482 (ImplicitReferenceConversionExists): use null_type too.
10483 (ImplicitReferenceConversion): use null_type too.
10485 * literal.cs: The type of `NullLiteral' is now null_type instead
10487 (Resolve): Set the type here.
10489 * typemanager.cs: Introduce null_type.
10491 2004-11-17 Martin Baulig <martin@ximian.com>
10493 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10494 direction, like FindMembers() does. Fixes #69546, testcase is in
10497 2004-11-16 Martin Baulig <martin@ximian.com>
10499 This is based on a patch from Marek Safar, see bug #69082.
10500 Fixes bugs #63705 and #67130.
10502 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10503 method; create a MemberCache for an interface type and cache the
10506 * decl.cs (IMemberContainer.ParentContainer): Removed.
10507 (IMemberContainer.ParentCache): New property.
10508 (MemberCache.SetupCacheForInterface): Removed.
10509 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10510 to create a cache for an interface's "parent".
10512 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10515 2004-11-16 Martin Baulig <martin@ximian.com>
10517 Merged back from gmcs; these changes already went into gmcs a
10518 couple of weeks ago.
10521 (TypeManager.AddUserType): Removed the `ifaces' argument.
10522 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10524 (TypeManager.AddUserInterface): Removed.
10525 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10527 (TypeManager.GetInterfaces): Likewise.
10528 (TypeManager.GetExplicitInterfaces): Likewise.
10530 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10532 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10533 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10535 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10537 * statement.cs: Avoid adding bools to a hashtable.
10539 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10541 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10542 calling an unsafe method from a safe location.
10544 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10547 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10549 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10551 * namespace.cs (VerifyUsing): use GetPartialName instead of
10554 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10556 * statement.cs (Return.Resolve): Fix regression in typo: if
10557 `in_exc', we have to request a NeedReturnLabel, this was a typo
10558 introduced in the anonymous method check-in. Fixes #69131.
10560 * Indexers were using the ShortName when defining themselves,
10561 causing a regression in the compiler bootstrap when applying the
10562 patch from 2004-11-02 (first part), now they use their full name
10563 and the bug is gone.
10565 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10567 * driver.cs: Strip the path from the names of embedded resources. Fixes
10570 2004-11-04 Raja R Harinath <rharinath@novell.com>
10572 Fix error message regression: cs0104-2.cs.
10573 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10574 (AliasEntry.Resolve): Update.
10575 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10577 (RootContext.LookupType): Update.
10579 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10581 * cs-parser.jay: Add support for handling accessor modifiers
10582 * class: Add support port accessor modifiers and error checking,
10583 define PropertyMethod.Define as virtual (not abstract anymore)
10584 * ecore.cs: Add checking for proeprties access with access modifiers
10585 * iterators.cs: Modify Accessor constructor call based in the modified
10587 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10589 * expression.cs (StringConcat): Handle being called twice,
10590 as when we have a concat in a field init with more than two
10593 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10595 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10596 special case explicit implementations, we should always produce
10597 the .property or .event declaration.
10599 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10600 since it will not return correct data if people use this
10601 unresolved in the presence of using statements (see test-313).
10603 * class.cs (MethodData.Define): If we are an explicit interface
10604 implementation, set the method name to the full name of the
10605 interface plus the name of the method.
10607 Notice that using the method.MethodName.GetFullName() does not
10608 work, as it will only contain the name as declared on the source
10609 file (it can be a shorthand in the presence of using statements)
10610 and not the fully qualifed type name, for example:
10614 class D : ICloneable {
10615 object ICloneable.Clone () {
10619 Would produce a method called `ICloneable.Clone' instead of
10620 `System.ICloneable.Clone'.
10622 * namespace.cs (Alias.Resolve): Use GetPartialName.
10624 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10626 * cs-parser.jay: Add error 1055 report.
10628 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10630 * assign.cs (Assign.DoResolve): Only do the transform of
10631 assignment into a New if the types are compatible, if not, fall
10632 through and let the implicit code deal with the errors and with
10633 the necessary conversions.
10635 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10637 * cs-parser.jay: Add error 1031 report.
10639 * cs-tokenizer.cs: Add location for error 1038.
10641 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10643 * cs-parser.jay: Add error 1016 report.
10645 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10647 * cs-parser.jay: Add errors 1575,1611 report.
10649 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10651 * cs-parser.jay: Add error 1001 report.
10653 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10656 * attribute.cs (GetMarshal): Add method argument for
10657 caller identification.
10659 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10660 agument for GetMarshal and RuntimeMissingSupport.
10662 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10664 * attribute.cs (ExtractSecurityPermissionSet): Removed
10665 TypeManager.code_access_permission_type.
10667 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10669 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10671 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10672 for obsolete use of a variable here. Fixes regression on errors
10673 cs0619-25 and cs0619-26.
10675 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10677 Fix #62358, implemented security attribute encoding.
10679 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10680 Tests permitted SecurityAction for assembly or other types.
10681 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10682 data from SecurityPermissionAttribute to PermisionSet class.
10684 * class.cs (ApplyAttributeBuilder): Added special handling
10685 for System.Security.Permissions.SecurityAttribute based types.
10687 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10688 special handling for System.Security.Permissions.SecurityAttribute
10691 * enum.cs (ApplyAttributeBuilder): Added special handling
10692 for System.Security.Permissions.SecurityAttribute based types.
10694 * parameter.cs (ApplyAttributeBuilder): Added special handling
10695 for System.Security.Permissions.SecurityAttribute based types.
10697 * rootcontext.cs: Next 2 core types.
10699 * typemanager.cs (TypeManager.security_permission_attr_type):
10700 Built in type for the SecurityPermission Attribute.
10701 (code_access_permission_type): Build in type.
10703 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10705 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10706 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10707 all of this information into
10708 EmitContext.EmitCapturedVariableInstance.
10710 * codegen.cs (EmitCapturedVariableInstance): move here the
10711 funcionality of emitting an ldarg.0 in the presence of a
10712 remapping. This centralizes the instance emit code.
10714 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10715 then emit a load of this: it means that we have reached the
10716 topmost ScopeInfo: the one that contains the pointer to the
10717 instance of the class hosting the anonymous method.
10719 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10720 captures to the topmost CaptureContext.
10722 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10724 * expression.cs (LocalVariableReference): Move the knowledge about
10725 the iterators into codegen's EmitCapturedVariableInstance.
10727 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10729 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10730 all code paths return a value from an anonymous method (it is the
10731 same as the 161 error, but for anonymous methods).
10733 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10735 The introduction of anonymous methods in the compiler changed
10736 various ways of doing things in the compiler. The most
10737 significant one is the hard split between the resolution phase
10738 and the emission phases of the compiler.
10740 For instance, routines that referenced local variables no
10741 longer can safely create temporary variables during the
10742 resolution phase: they must do so from the emission phase,
10743 since the variable might have been "captured", hence access to
10744 it can not be done with the local-variable operations from the runtime.
10748 (Block.Flags): New flag `IsTopLevel' to indicate that this block
10749 is a toplevel block.
10751 (ToplevelBlock): A new kind of Block, these are the blocks that
10752 are created by the parser for all toplevel method bodies. These
10753 include methods, accessors and anonymous methods.
10755 These contain some extra information not found in regular blocks:
10756 A pointer to an optional CaptureContext (for tracking captured
10757 local variables and parameters). A pointer to the parent
10760 (Return.Resolve): Catch missmatches when returning a value from an
10761 anonymous method (error 1662).
10762 Invoke NeedReturnLabel from the Resolve phase instead of the emit
10765 (Break.Resolve): ditto.
10767 (SwitchLabel): instead of defining the labels during the
10768 resolution phase, we now turned the public ILLabel and ILLabelCode
10769 labels into methods called GetILLabelCode() and GetILLabel() that
10770 only define the label during the Emit phase.
10772 (GotoCase): Track the SwitchLabel instead of the computed label
10773 (its contained therein). Emit the code by using
10774 SwitchLabel.GetILLabelCode ().
10776 (LocalInfo.Flags.Captured): A new flag has been introduce to track
10777 whether the Local has been captured or not.
10779 (LocalInfo.IsCaptured): New property, used to tell whether the
10780 local has been captured.
10782 * anonymous.cs: Vastly updated to contain the anonymous method
10785 The main classes here are: CaptureContext which tracks any
10786 captured information for a toplevel block and ScopeInfo used to
10787 track the activation frames for various local variables.
10789 Each toplevel block has an optional capture context associated
10790 with it. When a method contains an anonymous method both the
10791 toplevel method and the anonymous method will create a capture
10792 context. When variables or parameters are captured, they are
10793 recorded on the CaptureContext that owns them, for example:
10797 MyDelegate d = delegate {
10802 Here `a' will be recorded as captured on the toplevel
10803 CapturedContext, the inner captured context will not have anything
10804 (it will only have data if local variables or parameters from it
10805 are captured in a nested anonymous method.
10807 The ScopeInfo is used to track the activation frames for local
10808 variables, for example:
10810 for (int i = 0; i < 10; i++)
10811 for (int j = 0; j < 10; j++){
10812 MyDelegate d = delegate {
10817 At runtime this captures a single captured variable `i', but it
10818 captures 10 different versions of the variable `j'. The variable
10819 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
10820 recorded on a child.
10822 The toplevel ScopeInfo will also track information like the `this'
10823 pointer if instance variables were referenced (this is necessary
10824 as the anonymous method lives inside a nested class in the host
10825 type of the method).
10827 (AnonymousMethod): Expanded to track the Toplevel, implement
10828 `AnonymousMethod.Compatible' to tell whether an anonymous method
10829 can be converted to a target delegate type.
10831 The routine now also produces the anonymous method content
10833 (AnonymousDelegate): A helper class that derives from
10834 DelegateCreation, this is used to generate the code necessary to
10835 produce the delegate for the anonymous method that was created.
10837 * assign.cs: API adjustments for new changes in
10838 Convert.ImplicitStandardConversionExists.
10840 * class.cs: Adjustments to cope with the fact that now toplevel
10841 blocks are of type `ToplevelBlock'.
10843 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
10844 insteda of standard blocks.
10846 Flag errors if params arguments are passed to anonymous methods.
10848 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
10849 `CurrentAnonymousMethod' which points to the current Anonymous
10850 Method. The variable points to the AnonymousMethod class that
10851 holds the code being compiled. It is set in the new EmitContext
10852 created for the anonymous method.
10854 (EmitContext.Phase): Introduce a variable and an enumeration to
10855 assist in enforcing some rules about when and where we are allowed
10856 to invoke certain methods (EmitContext.NeedsReturnLabel is the
10857 only one that enfonces this right now).
10859 (EmitContext.HaveCaptureInfo): new helper method that returns
10860 whether we have a CapturedContext initialized.
10862 (EmitContext.CaptureVariable): New method used to register that a
10863 LocalInfo must be flagged for capturing.
10865 (EmitContext.CapturedParameter): New method used to register that a
10866 parameters must be flagged for capturing.
10868 (EmitContext.CapturedField): New method used to register that a
10869 field must be flagged for capturing.
10871 (EmitContext.HaveCapturedVariables,
10872 EmitContext.HaveCapturedFields): Return whether there are captured
10873 variables or fields.
10875 (EmitContext.EmitMethodHostInstance): This is used to emit the
10876 instance for the anonymous method. The instance might be null
10877 (static methods), this (for anonymous methods that capture nothing
10878 and happen to live side-by-side with the current method body) or a
10879 more complicated expression if the method has a CaptureContext.
10881 (EmitContext.EmitTopBlock): Routine that drives the emission of
10882 code: it will first resolve the top block, then emit any metadata
10883 and then emit the code. The split is done so that we can extract
10884 any anonymous methods and flag any captured variables/parameters.
10886 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
10887 during this phase, the ILGenerator should not be used as labels
10888 and local variables declared here might not be accessible to any
10889 code that is part of an anonymous method.
10891 Exceptions to this include the temporary variables that are
10892 created by some statements internally for holding temporary
10895 (EmitContext.EmitMeta): New routine, in charge of emitting all the
10898 (EmitContext.TemporaryReturn): This method is typically called
10899 from the Emit phase, and its the only place where we allow the
10900 ReturnLabel to be defined other than the EmitMeta. The reason is
10901 that otherwise we would have to duplicate a lot of logic in the
10902 Resolve phases of various methods that today is on the Emit
10905 (EmitContext.NeedReturnLabel): This no longer creates the label,
10906 as the ILGenerator is not valid during the resolve phase.
10908 (EmitContext.EmitThis): Extended the knowledge in this class to
10909 work in anonymous methods in addition to iterators.
10911 (EmitContext.EmitCapturedVariableInstance): This emits whatever
10912 code is necessary on the stack to access the instance to a local
10913 variable (the variable will be accessed as a field).
10915 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
10916 EmitContext.EmitAddressOfParameter): Routines to support
10917 parameters (not completed at this point).
10919 Removals: Removed RemapLocal and RemapLocalLValue. We probably
10920 will also remove the parameters.
10922 * convert.cs (Convert): Define a `ConstantEC' which points to a
10923 null. This is just to prefity some code that uses
10924 ImplicitStandardConversion code and do not have an EmitContext
10927 The idea is to flag explicitly that at that point in time, it is
10928 known that the conversion will not trigger the delegate checking
10929 code in implicit conversions (which requires a valid
10932 Everywhere: pass new EmitContext parameter since
10933 ImplicitStandardConversionExists now requires it to check for
10934 anonymous method conversions.
10936 (Convert.ImplicitStandardConversionExists): If the type of an
10937 expression is the anonymous_method_type, and the type is a
10938 delegate, we invoke the AnonymousMethod.Compatible method to check
10939 whether an implicit conversion is possible.
10941 (Convert.ImplicitConversionStandard): Only do implicit method
10942 group conversions if the language level is not ISO_1.
10944 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
10945 MethodInfo for the Invoke method. used by Delegate and
10948 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
10949 method conversions if the target type is a delegate.
10951 Removed extra debugging nops.
10953 (LocalVariableReference): Turn the `local_info' into a public
10956 Add `prepared' field, the same hack used for FieldExprs to cope
10957 with composed assignments, as Local variables do not necessarily
10958 operate purely on the stack as they used to: they can be captured
10961 Add `temp' for a temporary result, like fields.
10963 Refactor DoResolve and DoResolveLValue into DoResolveBase.
10965 It now copes with Local variables that are captured and emits the
10966 proper instance variable to load it from a field in the captured
10969 (ParameterReference.DoResolveBase): During the resolve phase,
10970 capture parameters if we are in an anonymous method.
10972 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
10973 anonymous method, use the EmitContext helper routines to emit the
10974 parameter reference.
10976 * iterators.cs: Set RemapToProxy to true/false during the
10979 * parameters.cs (GetParameterByName): New helper method.
10981 * typemanager.cs (anonymous_method_type) a new type that
10982 represents an anonyous method. This is always an internal type,
10983 used as a fencepost to test against the anonymous-methodness of an
10986 2004-10-20 Marek Safar <marek.safar@seznam.cz>
10988 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
10990 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
10992 2004-10-18 Martin Baulig <martin@ximian.com>
10994 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
10995 `Type' directly, but call ResolveType() on it.
10996 (Catch.Resolve): Likewise.
10997 (Foreach.Resolve): Likewise.
10999 2004-10-18 Martin Baulig <martin@ximian.com>
11001 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11002 `Type' directly, but call ResolveType() on it.
11003 (Probe.DoResolve): Likewise.
11004 (ArrayCreation.LookupType): Likewise.
11005 (TypeOf.DoResolve): Likewise.
11006 (SizeOf.DoResolve): Likewise.
11008 2004-10-18 Martin Baulig <martin@ximian.com>
11010 * expression.cs (Invocation.BetterFunction): Put back
11011 TypeManager.TypeToCoreType().
11013 2004-10-18 Raja R Harinath <rharinath@novell.com>
11015 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11018 2004-10-18 Martin Baulig <martin@ximian.com>
11020 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11021 `Type' directly, but call ResolveType() on it.
11023 2004-10-18 Martin Baulig <martin@ximian.com>
11025 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11026 `Type' directly, but call ResolveType() on it.
11027 (MemberBase.DoDefine): Likewise.
11029 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11030 `Type' directly, but call ResolveType() on it.
11031 (ComposedCast.DoResolveAsTypeStep): Likewise.
11033 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11034 `Type' directly, but call ResolveType() on it.
11036 2004-10-17 John Luke <john.luke@gmail.com>
11038 * class.cs (Operator.GetSignatureForError): use CSharpName
11040 * parameter.cs (Parameter.GetSignatureForError): Returns
11041 correct name even if was not defined.
11043 2004-10-13 Raja R Harinath <rharinath@novell.com>
11046 * class.cs (TypeContainer.EmitContext): New property.
11047 (DefineNestedTypes): Create an emitcontext for each part.
11048 (MethodCore.DoDefineParameters): Use container's emitcontext.
11049 Pass type array to InternalParameters.
11050 (MemberBase.DoDefine): Use container's emitcontext.
11051 (FieldMember.Define): Likewise.
11052 (Event.Define): Likewise.
11053 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11054 Pass type array to InternalParameters.
11055 (SetIndexerMethod.GetParameterInfo): Likewise.
11056 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11057 * delegate.cs (Define): Pass emitcontext to
11058 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11059 array to InternalParameters.
11060 * expression.cs (ParameterReference.DoResolveBase): Pass
11061 emitcontext to GetParameterInfo.
11062 (ComposedCast.DoResolveAsTypeStep): Remove check on
11063 ec.ResolvingTypeTree.
11064 * parameter.cs (Parameter.Resolve): Change argument to
11065 EmitContext. Use ResolveAsTypeTerminal.
11066 (Parameter.GetSignature): Change argument to EmitContext.
11067 (Parameters.ComputeSignature): Likewise.
11068 (Parameters.ComputeParameterTypes): Likewise.
11069 (Parameters.GetParameterInfo): Likewise.
11070 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11071 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11072 * support.cs (InternalParameters..ctor): Remove variant that takes
11074 * typemanager.cs (system_intptr_expr): New.
11075 (InitExpressionTypes): Initialize it.
11077 2004-10-12 Chris Toshok <toshok@ximian.com>
11079 * cs-parser.jay: fix location for try_statement and catch_clause.
11081 2004-10-11 Martin Baulig <martin@ximian.com>
11083 * report.cs: Don't make --fatal abort on warnings, we have
11084 -warnaserror for that.
11086 2004-10-07 Raja R Harinath <rharinath@novell.com>
11088 More DeclSpace.ResolveType avoidance.
11089 * decl.cs (MemberCore.InUnsafe): New property.
11090 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11091 with newly created EmitContext.
11092 (FieldMember.Define): Likewise.
11093 * delegate.cs (Delegate.Define): Likewise.
11094 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11095 only if normal name-lookup fails.
11096 (TypeExpr.DoResolve): Enable error-checking.
11097 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11098 (SizeOf.DoResolve): Likewise.
11099 (ComposedCast.DoResolveAsTypeStep): Likewise.
11100 (StackAlloc.DoResolve): Likewise.
11101 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11102 (Block.Unsafe): New property.
11103 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11104 (Unsafe): Set 'unsafe' flag of contained block.
11105 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11106 (Fixed.Resolve): Likewise.
11107 (Catch.Resolve): Likewise.
11108 (Using.ResolveLocalVariableDecls): Likewise.
11109 (Foreach.Resolve): Likewise.
11111 2004-10-05 John Luke <john.luke@gmail.com>
11113 * cs-parser.jay: add location to error CS0175
11115 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11117 * ecore.cs (Expression.Constantity): Add support for turning null
11120 * const.cs (Const.Define): Allow constants to be reference types
11121 as long as the value is Null.
11123 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11125 * namespace.cs (NamespaceEntry.Using): No matter which warning
11126 level is set, check if this namespace name has already been added.
11128 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11130 * expression.cs: reftype [!=]= null should always use br[true,false].
11133 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11136 * attribute.cs: Enum conversion moved to
11137 GetAttributeArgumentExpression to be applied to the all
11140 2004-10-01 Raja R Harinath <rharinath@novell.com>
11142 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11143 * class.c (TypeContainer.DefineType): Flag error if
11144 base types aren't accessible due to access permissions.
11145 * decl.cs (DeclSpace.ResolveType): Move logic to
11146 Expression.ResolveAsTypeTerminal.
11147 (DeclSpace.ResolveTypeExpr): Thin layer over
11148 Expression.ResolveAsTypeTerminal.
11149 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11150 Refactor code into NestedAccess. Use it.
11151 (DeclSpace.NestedAccess): New.
11152 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11153 argument to silence errors. Check access permissions.
11154 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11155 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11156 (Cast.DoResolve): Likewise.
11157 (New.DoResolve): Likewise.
11158 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11159 (TypeOf.DoResolve): Likewise.
11161 * expression.cs (Invocation.BetterConversion): Return the Type of
11162 the better conversion. Implement section 14.4.2.3 more faithfully.
11163 (Invocation.BetterFunction): Make boolean. Make correspondence to
11164 section 14.4.2.2 explicit.
11165 (Invocation.OverloadResolve): Update.
11166 (Invocation): Remove is_base field.
11167 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11168 (Invocation.Emit): Likewise.
11170 2004-09-27 Raja R Harinath <rharinath@novell.com>
11172 * README: Update to changes.
11174 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11176 * cs-parser.jay: Reverted 642 warning fix.
11178 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11181 * decl.cs (FindMemberWithSameName): Indexer can have more than
11184 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11186 * expression.cs (LocalVariableReference.DoResolveLValue):
11187 Do not report warning 219 for out values.
11188 (EmptyExpression.Null): New member to avoid extra allocations.
11190 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11192 * cs-parser.jay: Fix wrong warning 642 report.
11194 * cs-tokenizer.cs (CheckNextToken): New helper;
11195 Inspect next character if is same as expected.
11197 2004-09-23 Martin Baulig <martin@ximian.com>
11199 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11200 (Convert.ImplicitReferenceConversionExists): Likewise.
11202 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11204 * class.cs (Operator.Define): Add error 448 and 559 report.
11206 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11208 * class.cs (MemberBase.IsTypePermitted): New protected
11209 method for checking error CS0610.
11211 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11213 * class.cs (TypeContainer.HasExplicitLayout): New property
11214 Returns whether container has StructLayout attribute set Explicit.
11215 (FieldMember): New abstract class for consts and fields.
11216 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11217 (Field): Reuse FieldMember.
11219 * const.cs (Const): Reuse FieldMember.
11221 * rootcontext.cs: EmitConstants call moved to class.
11223 2004-09-22 Martin Baulig <martin@ximian.com>
11225 Thanks to Peter Sestoft for this bug report.
11227 * expression.cs (Conditional): If both the `trueExpr' and the
11228 `falseExpr' is a NullLiteral, return a NullLiteral.
11230 2004-09-22 Martin Baulig <martin@ximian.com>
11232 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11233 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11234 for the "get_Current" call.
11236 2004-09-22 Martin Baulig <martin@ximian.com>
11238 Marek and me just fixed one of our oldest bugs: #28562 :-)
11240 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11242 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11243 we're an EnumConstant, just return that.
11244 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11245 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11246 to get the value which'll actually be written into the attribute.
11247 However, we have to use GetValue() to access the attribute's value
11250 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11252 * constant.cs (Constant.IsNegative): New abstract property
11255 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11256 (StackAlloc.DoResolve): Reused IsNegative.
11258 2004-09-21 Martin Baulig <martin@ximian.com>
11260 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11261 if we're used in an iterator, we may be called from different
11264 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11265 we actually have an exception block.
11267 2004-09-20 John Luke <jluke@cfl.rr.com>
11269 * class.cs, cs-parser.jay: Improve the error report for 1520:
11270 report the actual line where the error happens, not where the
11271 class was declared.
11273 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11274 Pass location information that was available elsewhere.
11276 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11278 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11279 runtime to delay sign assemblies.
11281 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11283 * cs-parser.jay: Do not report the stack trace, this is barely
11286 2004-08-22 John Luke <john.luke@gmail.com>
11288 * driver.cs : check that a resource id is not already used
11289 before adding it, report CS1508 if it is, bug #63637
11291 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11293 * ecore.cs: Removed dead code.
11295 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11297 * class.cs: Do not report warning CS0067 on the interfaces.
11299 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11301 * cs-parser.jay: Add error 504 report.
11303 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11305 * rootcontext.cs: WarningLevel is 4 by default now.
11307 * statement.cs (Fixed.Resolve): Do not null
11310 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11313 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11314 deep search when property is not virtual.
11315 (PropertyExpr.ResolveAccessors): Make one call for both
11318 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11321 * statement.cs: Error 152 report constains also location.
11323 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11326 * const.cs: Explicitly set constant as static.
11328 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11331 * cs-parser.jay: Add error 1017 report.
11333 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11335 Fixed bug #59980, #64224
11336 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11338 * typemanager.cs (IsSpecialMethod): Simplified
11340 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11342 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11343 condition with better params.
11345 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11348 * attribute.cs (Resolve): Property has to have both
11351 2004-09-14 Martin Baulig <martin@ximian.com>
11353 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11355 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11358 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11359 called and is obsolete then this member suppress message
11360 when call is inside next [Obsolete] method or type.
11362 * expression.cs: Use TestObsoleteMethodUsage member.
11364 2004-09-14 Martin Baulig <martin@ximian.com>
11366 * cs-parser.jay: Sync a bit with the GMCS version.
11368 2004-09-14 Martin Baulig <martin@ximian.com>
11370 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11371 (CSharpParser.yacc_verbose_flag): New public field.
11373 * genericparser.cs: Removed.
11375 2004-09-14 Raja R Harinath <rharinath@novell.com>
11377 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11379 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11381 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11383 2004-09-10 Martin Baulig <martin@ximian.com>
11385 Backported my MemberName changes from GMCS into MCS.
11387 - we are now using a special `MemberName' class instead of using
11388 strings; in GMCS, the `MemberName' also contains the type
11391 - changed the grammar rules a bit:
11392 * the old `member_name' is now a `namespace_or_type_name':
11393 The rule is that we use `namespace_or_type_name' everywhere
11394 where we expect either a "member name" (GetEnumerator) or a
11395 "member name" with an explicit interface name
11396 (IEnumerable.GetEnumerator).
11397 In GMCS, the explicit interface name may include type arguments
11398 (IEnumerable<T>.GetEnumerator).
11399 * we use `member_name' instead of just `IDENTIFIER' for
11401 The rule is that we use `member_name' wherever a member may
11402 have type parameters in GMCS.
11404 * decl.cs (MemberName): New public class.
11405 (MemberCore.MemberName): New public readonly field.
11406 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11407 (DeclSpace): Likewise.
11409 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11410 * enum.cs (Enum.ctor): Likewise.
11412 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11414 (AliasEntry.ctor): Take a MemberName, not an Expression.
11415 (AliasEntry.UsingAlias): Likewise.
11417 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11418 (IMethodData.MemberName): Changed type from string to MemberName.
11419 (MemberBase.ExplicitInterfaceName): Likewise.
11420 (AbstractPropertyEventMethod.SetupName): Make this private.
11421 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11422 argument; compute the member name here.
11423 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11424 on the `member.MemberName' and the `prefix'.
11426 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11428 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11429 thus, we get a `MemberName' instead of a `string'. These
11430 declarations may have type parameters in GMCS.
11431 (interface_method_declaration, delegate_declaration): Likewise.
11432 (class_declaration, interface_declaration): Likewise.
11433 (method_header): Use `namespace_or_type_name' instead of
11434 `member_name'. We may be an explicit interface implementation.
11435 (property_declaration, event_declaration): Likewise.
11436 (member_name): This is now just an `IDENTIFIER', not a
11437 `namespace_or_type_name'.
11438 (type_name, interface_type): Removed.
11439 (namespace_or_type_name): Return a MemberName, not an Expression.
11440 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11441 call GetTypeExpression() on the MemberName to get an expression.
11442 (IndexerDeclaration.interface_type): Changed type from string to
11444 (MakeName): Operate on MemberName's instead of string's.
11446 2004-09-13 Raja R Harinath <rharinath@novell.com>
11449 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11450 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11451 lookup to avoid symbols introduced by 'using'.
11452 * rootcontext.cs (NamespaceLookup): Update.
11454 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11456 * class.cs (TypeContainer.DoDefineMembers): Do not call
11457 DefineDefaultConstructor for static classes.
11459 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11461 * attribute.cs (Attribute.Resolve): Add error 653 report.
11463 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11465 (Method.ApplyAttributeBuilder): Add error 685 report.
11466 (Operator.Define): Add error 564 report.
11468 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11470 * expression.cs (Invocation.DoResolve): Add error
11471 245 and 250 report.
11473 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11476 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11478 * class.cs (ConstructorInitializer.Resolve):
11479 Wrong error number (515->516).
11481 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11483 * class.cs (Indexer.Define): Add error 631 report.
11485 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11487 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11489 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11491 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11493 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11495 * cs-parser.jay: Added error CS0241 report.
11497 2004-09-10 Raja R Harinath <rharinath@novell.com>
11499 * cs-parser.jay (fixed_statement): Introduce a scope for the
11500 declaration in the 'fixed' statement.
11502 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11504 * cs-parser.jay: Added CS0230 error report.
11506 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11508 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11510 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11512 * expression.cs (Argument.Resolve): Added error CS0192 and
11515 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11517 C# 2.0 #pragma warning feature
11519 * cs-tokenizer.cs (PreProcessPragma): New method;
11520 Handles #pragma directive.
11522 * report.cs (WarningRegions): New class; Support
11523 class for #pragma warning directive. It tests whether
11524 warning is enabled for a given line.
11526 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11528 * const.cs: Add more descriptive error report, tahnks to
11531 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11533 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11535 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11537 * expression.cs: Apply patch from Ben: Remove dead code from
11538 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11539 as that code just threw an exception anwyays.
11541 * const.cs: Remove the call to the turnintoconstant, for details
11544 * literal.cs: The type of the null-literal is the null type; So
11545 we use a placeholder type (literal.cs:System.Null, defined here)
11548 * expression.cs (Conditional.DoResolve): Remove some old code that
11549 is no longer needed, conversions have been fixed.
11551 (ArrayCreationExpression.DoResolve): Return false if we fail to
11552 resolve the inner expression.
11554 2004-09-07 Raja R Harinath <rharinath@novell.com>
11557 * cs-parser.jay (delegate_declaration): Record a delegate
11558 declaration as a type declaration.
11559 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11561 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11563 * parameter.cs: Do not crash if the type can not be resolved.
11565 * expression.cs: Report errors with unsafe pointers, fixes #64896
11567 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11569 * expression.cs: Pointer arith always needs to do a conv.i
11570 if the operand is a long. fix 65320
11572 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11574 Fixed cs0619-37.cs, cs0619-38.cs
11576 * enum.cs (GetObsoleteAttribute): Removed.
11578 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11579 on Enum member is double staged. The first is tested member
11582 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11584 Fixed #56986, #63631, #65231
11586 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11587 adds member to name container.
11588 (TypeContainer.AddToTypeContainer): New method, adds type to
11590 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11591 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11592 AddOperator): Simplified by reusing AddToMemberContainer.
11593 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11595 (Method.CheckForDuplications): Fixed implementation to test all
11597 (MemberBase): Detection whether member is explicit interface
11598 implementation is now in constructor.
11599 (MemberBase.UpdateMemberName): Handles IndexerName.
11600 (Accessor): Changed to keep also location information.
11601 (AbstractPropertyEventMethod): Is derived from MemberCore.
11602 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11603 will be emited or not.
11604 (PropertyBase.AreAccessorsDuplicateImplementation):
11605 Tests whether accessors are not in collision with some method.
11606 (Operator): Is derived from MethodCore to simplify common
11609 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11611 (DeclSpace.AddToContainer): Adds the member to defined_names
11612 table. It tests for duplications and enclosing name conflicts.
11614 * enum.cs (EnumMember): Clean up to reuse the base structures
11616 2004-09-03 Martin Baulig <martin@ximian.com>
11618 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11619 into TypeContainer, to make partial classes work again.
11621 2004-09-03 Martin Baulig <martin@ximian.com>
11623 * rootcontext.cs (RootContext.V2): Removed.
11625 2004-03-23 Martin Baulig <martin@ximian.com>
11627 * expression.cs (Invocation.OverloadResolve): Added `bool
11628 may_fail' argument and use it instead of the Location.IsNull() hack.
11630 2004-09-03 Martin Baulig <martin@ximian.com>
11632 Merged latest changes into gmcs. Please keep this comment in
11633 here, it makes it easier for me to see what changed in MCS since
11634 the last time I merged.
11636 2004-09-03 Raja R Harinath <rharinath@novell.com>
11639 * expression.cs (BetterConversion): Don't allow either conversion
11640 to be null. Remove redundant implicit conversion test when 'q ==
11641 null' -- when this function is invoked, we already know that the
11642 implicit conversion exists.
11643 (BetterFunction): Assume that 'best' is non-null. Remove
11644 redundant reimplementation of IsApplicable when 'best' is null.
11645 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11646 number of arguments.
11647 (IsAncestralType): Extract from OverloadResolve.
11648 (OverloadResolve): Make robust to the MethodGroupExpr being
11649 unsorted. Implement all the logic of Section 14.5.5.1, and
11650 support overloading of methods from multiple applicable types.
11651 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11653 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11654 (RealError, Warning): Append type of report to related symbol.
11656 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11658 * enum.cs: Fixed CLS-Compliance checks for enum members.
11659 Error tests cs3008-8.cs, cs3014-8.cs
11661 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11663 Fixed bug #62342, #63102
11664 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11665 like ImplementMethod.
11667 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11669 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11672 2004-09-02 Martin Baulig <martin@ximian.com>
11674 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11675 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11678 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11680 C# 2.0 Static classes implemented
11682 * class.cs (TypeContainer): instance_constructors,
11683 initialized_fields, initialized_static_fields,
11684 default_constructor, base_inteface_types are protected to be
11685 accessible from StaticClass.
11686 (TypeContainer.DefineDefaultConstructor): New virtual method
11687 for custom default constructor generating
11688 (StaticClass): New class to handle "Static classes" feature.
11690 * cs-parser.jay: Handle static keyword on class like instance
11693 * driver.cs: Added "/langversion" command line switch with two
11694 options (iso-1, default).
11696 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11698 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11700 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11702 * delegate.cs: Style.
11704 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11706 * delegate.cs: Add seperate instance expr field for miguel.
11708 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11710 * PointerArithmetic (Resolve): make sure we are not doing
11711 pointer arith on void*. Also, make sure we are resolved
11712 by not setting eclass until resolve.
11714 All callers: Make sure that PointerArithmetic gets resolved.
11716 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11718 * ArrayCreation (LookupType): If the type does not resolve
11719 to an array, give an error.
11721 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11723 * statement.cs (Try.Resolve): Fixed bug #64222
11725 2004-08-27 Martin Baulig <martin@ximian.com>
11728 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11731 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11733 * ecore.cs (Constantify): Get underlying type via
11734 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11735 Windows in special cases.
11737 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11739 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
11740 for obtaining also private methods.
11741 (GetRemoveMethod): Used GetRemoveMethod (true)
11742 for obtaining also private methods.
11744 2004-08-24 Martin Baulig <martin@ximian.com>
11746 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
11747 MethodAttributes.HideBySig for operators.
11749 2004-08-23 Martin Baulig <martin@ximian.com>
11751 Back to the old error reporting system :-)
11753 * report.cs (Message): Removed.
11754 (Report.MessageData, ErrorData, WarningData): Removed.
11755 (Report.Error, Warning): Back to the old system.
11757 2004-08-23 Martin Baulig <martin@ximian.com>
11759 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
11761 * class.cs (TypeContainer.ParentContainer): New public virtual
11762 method; replaces the explicit interface implementation.
11763 (ClassPart.ParentContainer): Override.
11765 2004-08-23 Martin Baulig <martin@ximian.com>
11767 * statement.cs (Switch): Added support for constant switches; see
11768 #59428 or test-285.cs.
11770 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11773 * statement.cs (GetEnumeratorFilter): Removed useless
11774 logic because C# specs is strict. GetEnumerator must be
11777 2004-08-22 Martin Baulig <martin@ximian.com>
11779 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11780 a switch and may break, reset the barrier. Fixes #59867.
11782 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11784 CLS-Compliance speed up (~5% for corlib)
11786 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
11787 New method. Tests container for CLS-Compliant names
11789 * class.cs (TypeContainer.VerifyClsName): New method.
11790 Checks whether container name is CLS Compliant.
11791 (Constructor): Implements IMethodData.
11793 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
11794 low-case table for CLS Compliance test.
11795 (MemberCache.VerifyClsParameterConflict): New method.
11796 Checks method parameters for CS3006 error.
11798 * enum.cs (EnumMember): Is derived from MemberCore.
11799 (Enum.VerifyClsName): Optimized for better performance.
11801 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11803 * report.cs: Renamed Error_T to Error and changed all
11806 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11808 * class.cs (TypeContainer.IndexerArrayList): New inner class
11809 container for indexers.
11810 (TypeContainer.DefaultIndexerName): New constant for default
11811 indexer name. Replaced all "Item" with this constant.
11812 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
11814 * typemanager.cs (TypeManager.default_member_ctor): Cache here
11815 DefaultMemberAttribute constructor.
11817 2004-08-05 Martin Baulig <martin@ximian.com>
11819 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
11822 2004-08-05 Marek Safar <marek.safar@seznam.cz>
11824 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
11825 multi platforms problem.
11827 * compiler.csproj: Included shared files.
11829 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11831 Fix bug 60333, 55971 in the more general way
11832 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11833 Added arg_type argument for constant conversion.
11834 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
11836 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11839 * class.cs (TypeContainer ): New inner classes MethodArrayList,
11840 OperatorArrayList, MethodCoreArrayList for typecontainer
11841 containers. Changed class member types to these new types.
11842 (MethodArrayList.DefineMembers): Added test for CS0659.
11844 2004-08-04 Miguel de Icaza <miguel@ximian.com>
11846 * cfold.cs: Synchronize the folding with the code in expression.cs
11847 Binary.DoNumericPromotions for uint operands.
11849 * attribute.cs: Revert patch from Raja, it introduced a regression
11850 while building Blam-1.2.1 (hard to isolate a test case).
11852 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11856 (TypeContainer.Define): Renamed to DefineContainerMembers because of
11858 (MethodCore.parent_method): New member. The method we're overriding
11859 if this is an override method.
11860 (MethodCore.CheckBase): Moved from Method class and made common.
11861 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
11863 (MethodCore.CheckForDuplications): New abstract method. For custom
11864 member duplication search in a container
11865 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
11866 method and its return type.
11867 (Event.conflict_symbol): New member. Symbol with same name in the
11871 (MemberCache.FindMemberWithSameName): New method. The method
11872 is looking for conflict with inherited symbols.
11874 2004-08-04 Martin Baulig <martin@ximian.com>
11876 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
11878 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
11880 2004-08-03 Marek Safar <marek.safar@seznam.cz>
11882 * report.cs (Message): New enum for better error, warning reference in
11884 (MessageData): New inner abstract class. It generally handles printing of
11885 error and warning messages.
11886 Removed unused Error, Warning, Message methods.
11888 2004-08-03 Marek Safar <marek.safar@seznam.cz>
11890 Fix for cs0592-8.cs test
11892 (Attributable.ValidAttributeTargets): Made public.
11893 (Attribute.ExplicitTarget): New member for explicit target value.
11894 (Attribute.CheckTargets): Now we translate explicit attribute
11895 target to Target here.
11897 2004-08-03 Ben Maurer <bmaurer@ximian.com>
11899 * ecore.cs (MethodGroupExpr): new IsBase property.
11901 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
11903 * delegate.cs (DelegateCreation): store a MethodGroupExpr
11904 rather than an instance expr.
11906 (DelegateCreation.Emit): Use the method group rather than
11907 the instance expression. Also, if you have base.Foo as the
11908 method for a delegate, make sure to emit ldftn, not ldftnvirt.
11910 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
11912 (NewDelegate.DoResolve): Only check for the existance of Invoke
11913 if the method is going to be needed. Use MethodGroupExpr.
11915 (NewDelegate.Emit): Remove, DelegateCreation implements this.
11917 * expression.cs: For pointer arith., make sure to use
11918 the size of the type, not the size of the pointer to
11921 2004-08-03 Marek Safar <marek.safar@seznam.cz>
11924 * class.cs (Class): Added error CS0502 test.
11926 2004-08-03 John Luke <jluke@cfl.rr.com>
11927 Raja R Harinath <rharinath@novell.com>
11930 * attribute.cs (Attribute.complained_before): New flag.
11931 (Attribute.ResolveType, Attribute.Resolve),
11932 (Attribute.DefinePInvokeMethod): Set it.
11933 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
11935 2004-08-03 Martin Baulig <martin@ximian.com>
11937 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
11938 use a user-defined operator; we still need to do numeric
11939 promotions in case one argument is a builtin type and the other
11940 one has an implicit conversion to that type. Fixes #62322.
11942 2004-08-02 Martin Baulig <martin@ximian.com>
11944 * statement.cs (LocalInfo.Flags): Added `IsThis'.
11945 (LocalInfo.IsThis): New public property.
11946 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
11948 2004-08-01 Martin Baulig <martin@ximian.com>
11950 * class.cs (TypeContainer.GetClassBases): Don't set the default
11951 here since we may get called from GetPartialBases().
11952 (TypeContainer.DefineType): If GetClassBases() didn't return a
11953 parent, use the default one.
11955 2004-07-30 Duncan Mak <duncan@ximian.com>
11957 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
11959 2004-07-30 Martin Baulig <martin@ximian.com>
11961 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
11963 * class.cs (SourceMethod): New public class, derive from the
11964 symbol writer's ISourceMethod.
11965 (Method): Use the new symbol writer API.
11967 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
11968 as argument and use the new symbol writer.
11971 (SourceFile): Implement the symbol writer's ISourceFile.
11972 (Location.SymbolDocument): Removed.
11973 (Location.SourceFile): New public property.
11975 * symbolwriter.cs: Use the new symbol writer API.
11977 2004-07-30 Raja R Harinath <rharinath@novell.com>
11979 * Makefile (install-local): Remove. Functionality moved to
11982 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
11984 * Makefile: Install mcs.exe.config file together with mcs.exe.
11985 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
11986 correct runtime version.
11988 2004-07-25 Martin Baulig <martin@ximian.com>
11991 (TypeContainer.RegisterOrder): Removed, this was unused.
11992 (TypeContainer, interface_order): Removed.
11993 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
11994 TypeContainer as argument since we can also be called with a
11995 `PartialContainer' for a partial class/struct/interface.
11996 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
11997 of checking whether we're an `Interface' - we could be a
11998 `PartialContainer'.
11999 (PartialContainer.Register): Override; call
12000 AddClass()/AddStruct()/AddInterface() on our parent.
12002 * cs-parser.jay (interface_member_declaration): Add things to the
12003 `current_container', not the `current_class'.
12005 * rootcontext.cs (RegisterOrder): The overloaded version which
12006 takes an `Interface' was unused, removed.
12008 * typemanager.cs (TypeManager.LookupInterface): Return a
12009 `TypeContainer', not an `Interface'.
12010 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12011 contain a `PartialContainer' for an interface, so check it's
12012 `Kind' to figure out what it is.
12014 2004-07-25 Martin Baulig <martin@ximian.com>
12016 * class.cs (Class.DefaultTypeAttributes): New public constant.
12017 (Struct.DefaultTypeAttributes): Likewise.
12018 (Interface.DefaultTypeAttributes): Likewise.
12019 (PartialContainer.TypeAttr): Override this and add the
12020 DefaultTypeAttributes.
12022 2004-07-25 Martin Baulig <martin@ximian.com>
12024 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12025 we can just use the `Parent' field instead.
12027 2004-07-25 Martin Baulig <martin@ximian.com>
12029 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12031 2004-07-25 Martin Baulig <martin@ximian.com>
12033 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12034 our parts before defining any methods.
12035 (TypeContainer.VerifyImplements): Make this virtual.
12036 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12037 on our PartialContainer.
12039 2004-07-25 Martin Baulig <martin@ximian.com>
12041 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12043 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12044 argument, we can just use the `Parent' field instead.
12047 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12048 (MemberBase.DoDefine): Likewise.
12050 2004-07-24 Martin Baulig <martin@ximian.com>
12052 * decl.cs (MemberCore.Parent): New public field.
12053 (DeclSpace.Parent): Moved to MemberCore.
12055 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12056 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12058 (FieldBase, Field, Operator): Likewise.
12059 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12060 (EventField, Event): Likewise.
12062 2004-07-23 Martin Baulig <martin@ximian.com>
12064 * class.cs (PartialContainer): New public class.
12065 (ClassPart): New public class.
12066 (TypeContainer): Added support for partial classes.
12067 (TypeContainer.GetClassBases): Splitted some of the functionality
12068 out into GetNormalBases() and GetPartialBases().
12070 * cs-tokenizer.cs (Token.PARTIAL): New token.
12071 (Tokenizer.consume_identifier): Added some hacks to recognize
12072 `partial', but only if it's immediately followed by `class',
12073 `struct' or `interface'.
12075 * cs-parser.jay: Added support for partial clases.
12077 2004-07-23 Martin Baulig <martin@ximian.com>
12079 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12080 a `DeclSpace' and also made it readonly.
12081 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12082 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12083 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12085 * cs-parser.jay: Pass the `current_class', not the
12086 `current_container' (at the moment, this is still the same thing)
12087 to a new Method, Property, Event, Indexer or Constructor.
12089 2004-07-23 Martin Baulig <martin@ximian.com>
12091 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12092 and removed the `current_interface' one.
12093 (struct_declaration, class_declaration, interface_declaration):
12094 Set `current_class' to the newly created class/struct/interface;
12095 set their `Bases' and call Register() before parsing their body.
12097 2004-07-23 Martin Baulig <martin@ximian.com>
12099 * class.cs (Kind): New public enum.
12100 (TypeContainer): Made this class abstract.
12101 (TypeContainer.Kind): New public readonly field.
12102 (TypeContainer.CheckDef): New public method; moved here from
12104 (TypeContainer.Register): New public abstract method.
12105 (TypeContainer.GetPendingImplementations): New public abstract
12107 (TypeContainer.GetClassBases): Removed the `is_class' and
12108 `is_iface' parameters.
12109 (TypeContainer.DefineNestedTypes): Formerly known as
12111 (ClassOrStruct): Made this class abstract.
12113 * tree.cs (RootTypes): New public type.
12115 2004-07-20 Martin Baulig <martin@ximian.com>
12117 * tree.cs (Tree.RecordNamespace): Removed.
12118 (Tree.Namespaces): Removed.
12120 * rootcontext.cs (RootContext.IsNamespace): Removed.
12122 * cs-parser.jay (namespace_declaration): Just create a new
12123 NamespaceEntry here.
12125 2004-07-20 Martin Baulig <martin@ximian.com>
12127 * statement.cs (ExceptionStatement): New abstract class. This is
12128 now used as a base class for everyone who's using `finally'.
12129 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12130 our local variables before using them.
12132 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12133 virtual method. This is used by Yield.Resolve() to "steal" an
12134 outer block's `finally' clauses.
12135 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12138 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12139 version which takes an ExceptionStatement. This version must be
12140 used to create exception branchings.
12143 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12144 (Iterator.EmitMoveNext): Added exception support; protect the
12145 block with a `fault' clause, properly handle 'finally' clauses.
12146 (Iterator.EmitDispose): Run all the `finally' clauses here.
12148 2004-07-20 Martin Baulig <martin@ximian.com>
12150 * iterator.cs: This is the first of a set of changes in the
12151 iterator code. Match the spec more closely: if we're an
12152 IEnumerable, then GetEnumerator() must be called. The first time
12153 GetEnumerator() is called, it returns the current instance; all
12154 subsequent invocations (if any) must create a copy.
12156 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12158 * expression.cs: Resolve the constant expression before returning
12161 2004-07-19 Martin Baulig <martin@ximian.com>
12163 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12164 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12165 the return type of the new EmitContext.
12167 2004-07-18 Martin Baulig <martin@ximian.com>
12169 * class.cs (Property.Define): Fix iterators.
12171 * iterators.cs (Iterator.Define): Moved the
12172 `container.AddInterator (this)' call here from the .ctor; only do
12173 it if we resolved successfully.
12175 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12177 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12178 `true' for preprocessing directives that we parse. The return
12179 value indicates whether we should return to regular tokenizing or
12180 not, not whether it was parsed successfully.
12182 In the past if we were in: #if false ... #line #endif, we would
12183 resume parsing after `#line'. See bug 61604.
12185 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12186 building: IsEnumType should return true only for enums, not for
12187 enums or System.Enum itself. This fixes #61593.
12189 Likely what happened is that corlib was wrong: mcs depended on
12190 this bug in some places. The bug got fixed, we had to add the
12191 hack, which caused bug 61593.
12193 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12194 that was a workaround for the older conditions.
12196 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12198 * assign.cs: IAssignMethod has a new interface, as documented
12199 inline. All assignment code now uses this new api.
12201 * ecore.cs, expression.cs: All classes which implement
12202 IAssignMethod now use the new interface.
12204 * expression.cs (Invocation): add a hack to EmitCall so that
12205 IndexerAccess can be the target of a compound assignment without
12206 evaluating its arguments twice.
12208 * statement.cs: Handle changes in Invocation api.
12210 2004-07-16 Martin Baulig <martin@ximian.com>
12212 * iterators.cs: Rewrote this. We're now using one single Proxy
12213 class for both the IEnumerable and the IEnumerator interface and
12214 `Iterator' derives from Class so we can use the high-level API.
12216 * class.cs (TypeContainer.AddIterator): New method.
12217 (TypeContainer.DoDefineType): New protected virtual method, which
12218 is called from DefineType().
12219 (TypeContainer.DoDefineMembers): Call DefineType() and
12220 DefineMembers() on all our iterators.
12221 (TypeContainer.Emit): Call Emit() on all our iterators.
12222 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12224 * codegen.cs (EmitContext.CurrentIterator): New public field.
12226 2004-07-15 Martin Baulig <martin@ximian.com>
12229 (TypeManager.not_supported_exception_type): New type.
12231 2004-07-14 Martin Baulig <martin@ximian.com>
12233 * iterators.cs: Use real error numbers.
12235 2004-07-14 Martin Baulig <martin@ximian.com>
12237 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12238 requires this to be a System.Collection.IEnumerable and not a
12239 class implementing that interface.
12240 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12242 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12244 * class.cs: Fixed previous fix, it broke some error tests.
12246 2004-07-12 Martin Baulig <martin@ximian.com>
12248 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12251 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12253 * assign.cs (LocalTemporary): Add new argument: is_address,If
12254 `is_address' is true, then the value that we store is the address
12255 to the real value, and not the value itself.
12257 * ecore.cs (PropertyExpr): use the new local temporary
12258 stuff to allow us to handle X.Y += z (where X is a struct)
12260 2004-07-08 Martin Baulig <martin@ximian.com>
12262 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12263 not always return, just like we're doing in Using.Resolve().
12265 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12267 * cs-parser.jay (fixed_statement): flag this as Pinned.
12269 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12271 * typemanager.cs (TypeManager): Removed MakePinned method, this
12272 mechanism is replaced with the .NET 2.x compatible mechanism of
12273 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12275 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12276 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12277 `IsFixed' property which has a different meaning.
12279 2004-07-02 Raja R Harinath <rharinath@novell.com>
12281 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12282 visible from inside a nested class, not just the names of the
12283 immediately enclosing class.
12284 Fix for bug #60730.
12286 2004-06-24 Raja R Harinath <rharinath@novell.com>
12288 * expression.cs (BetterConversion): Remove buggy special-case
12289 handling of "implicit constant expression conversions". At this
12290 point, we already know that the conversion is possible -- we're
12291 only checking to see which is better.
12293 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12295 * cs-parser.jay: Added error CS0210 test.
12297 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12299 * cs-parser.jay: Added error CS0134 test.
12301 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12304 * cs-parser.jay: Added error CS0145 test.
12306 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12308 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12310 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12312 * expression.cs (StackAlloc.Resolve): The argument may not
12313 be a constant; deal with this case.
12315 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12317 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12318 GetIndexerAttributeValue.
12319 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12321 * class.cs (Indexer.Define): Added error tests for CS0415,
12324 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12326 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12329 2004-06-23 Martin Baulig <martin@ximian.com>
12331 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12332 neither return nor throw, reset the barrier as well. Fixes #60457.
12334 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12336 * class.cs : EventAttributes is now set to None by default.
12337 This fixes bug #60459.
12339 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12342 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12343 Don't throw exception but return null (it's sufficient now).
12345 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12347 * typemanager.cs (GetArgumentTypes): Faster implementation.
12349 2004-06-18 Martin Baulig <martin@ximian.com>
12351 * attribute.cs (Attribute.Resolve): Check whether we're an
12352 EmptyCast which a Constant child. Fixes #60333.
12354 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12356 * statement.cs (EmitCollectionForeach): Account for the fact that
12357 not all valuetypes are in areas which we can take the address of.
12358 For these variables, we store to a temporary variable. Also, make
12359 sure that we dont emit a `callvirt' on a valuetype method.
12361 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12363 * expression.cs (StackAlloc.DoReSolve): Added test for
12364 negative parameter (CS0247).
12366 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12369 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12371 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12374 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12377 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12379 Fix bug #58254 & cs1555.cs, cs1556.cs
12380 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12382 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12384 * cs-parser.jay: Added error CS1669 test for indexers.
12386 2004-06-11 Martin Baulig <martin@ximian.com>
12388 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12389 call this twice: for params and varargs methods.
12391 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12394 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12396 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12398 * attribute.cs (Attribute.GetValidTargets): Made public.
12401 (AbstractPropertyEventMethod): New class for better code sharing.
12402 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12404 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12406 2004-06-11 Raja R Harinath <rharinath@novell.com>
12409 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12410 that the call to Resolve is part of a MemberAccess.
12411 (Expression.Resolve): Use it for SimpleName resolution.
12412 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12413 Add 'intermediate' boolean argument.
12414 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12415 error message when the SimpleName can be resolved ambiguously
12416 between an expression and a type.
12417 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12419 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12420 call on the left-side.
12422 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12425 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12427 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12429 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12431 2004-06-11 Martin Baulig <martin@ximian.com>
12433 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12434 varargs methods if applicable.
12436 2004-06-11 Martin Baulig <martin@ximian.com>
12438 * expression.cs (Invocation.EmitCall): Don't use
12439 `method.CallingConvention == CallingConventions.VarArgs' since the
12440 method could also have `CallingConventions.HasThis'.
12442 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12444 * class.cs (Event.GetSignatureForError): Implemented.
12445 Fixed crash in error test cs3010.cs
12447 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12449 * cs-tokenizer.cs: Change the way we track __arglist to be
12450 consistent with the other keywords.
12452 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12454 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12457 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12459 * codegen.cs: Check that all referenced assemblies have a strongname
12460 before strongnaming the compiled assembly. If not report error CS1577.
12461 Fix bug #56563. Patch by Jackson Harper.
12462 * typemanager.cs: Added a method to return all referenced assemblies.
12463 Fix bug #56563. Patch by Jackson Harper.
12465 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12468 (Method.ApplyAttributeBuilder): Moved and added conditional
12469 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12472 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12474 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12477 * class.cs: (EventField.attribute_targets): Changed default target.
12479 2004-06-08 Martin Baulig <martin@ximian.com>
12481 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12483 2004-06-08 Martin Baulig <martin@ximian.com>
12485 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12487 2004-06-07 Martin Baulig <martin@ximian.com>
12489 Added support for varargs methods.
12491 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12494 * cs-parser.jay: Added support for `__arglist'.
12496 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12498 * expression.cs (Argument.AType): Added `ArgList'.
12499 (Invocation): Added support for varargs methods.
12500 (ArglistAccess): New public class.
12501 (Arglist): New public class.
12503 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12505 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12506 a method's top-level block if the method has varargs.
12508 * support.cs (ReflectionParameters, InternalParameters): Added
12509 support for varargs methods.
12511 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12513 * class.cs: Provide location in indexer error report.
12515 * driver.cs: Use standard names.
12517 * namespace.cs: Catch the use of using after a namespace has been
12518 declared also on using aliases.
12520 2004-06-03 Raja R Harinath <rharinath@novell.com>
12523 * typemanager.cs (closure_private_ok, closure_invocation_type)
12524 (closure_qualifier_type, closure_invocation_assembly)
12525 (FilterWithClosure): Move to ...
12526 (Closure): New internal nested class.
12527 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12528 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12529 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12530 (MemberLookup, MemberLookupFailed): Use it.
12531 * expression.cs (New.DoResolve): Treat the lookup for the
12532 constructor as being qualified by the 'new'ed type.
12533 (Indexers.GetIndexersForTypeOrInterface): Update.
12535 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12538 (GetConditionalAttributeValue): New method. Returns
12539 condition of ConditionalAttribute.
12540 (SearchMulti): New method. Returns all attributes of type 't'.
12541 Use it when attribute is AllowMultiple = true.
12542 (IsConditionalMethodExcluded): New method.
12545 (Method.IsExcluded): Implemented. Returns true if method has conditional
12546 attribute and the conditions is not defined (method is excluded).
12547 (IMethodData): Extended interface for ConditionalAttribute support.
12548 (PropertyMethod.IsExcluded): Implemented.
12551 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12554 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12557 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12559 * expression.cs (ArrayCreationExpression): Make this just an
12560 `expression'. It can't be a statement, so the code here was
12563 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12566 * typemanager.cs (GetFullNameSignature): New method for
12569 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12572 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12573 Use this method when MethodBuilder is null.
12574 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12575 Added test for error CS0626 (MONO reports error for this situation).
12576 (IMethodData.GetSignatureForError): Extended interface.
12578 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12581 (AttributeTester.GetObsoleteAttribute): Returns instance of
12582 ObsoleteAttribute when type is obsolete.
12585 (TypeContainer.VerifyObsoleteAttribute): Override.
12586 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12587 (MethodCode.VerifyObsoleteAttribute): Override.
12588 (MemberBase.VerifyObsoleteAttribute): Override.
12591 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12592 and report proper error.
12595 Delegate.VerifyObsoleteAttribute): Override.
12598 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12599 and report proper error.
12600 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12603 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12607 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12608 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12609 Added test for ObsoleteAttribute.
12612 (Catch): Derived from Statement.
12614 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12616 Fixed bug #59071 & cs0160.cs
12618 * statement.cs (Try.Resolve): Check here whether order of catch
12619 clauses matches their dependencies.
12621 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12623 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12624 caused a regression: #59343. Referencing nested classes from an
12625 assembly stopped working.
12627 2004-05-31 Martin Baulig <martin@ximian.com>
12629 MCS is now frozen for beta 2.
12631 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12633 * convert.cs: add a trivial cache for overload operator resolution.
12635 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12637 * decl.cs: If possible, use lookuptypedirect here. We can only do
12638 this if there is no `.' after the namespace. Avoids using
12639 LookupType, which does lots of slow processing.
12640 (FindNestedType) New method, does what it says :-).
12641 * namespace.cs: use LookupTypeDirect.
12642 * rootcontext.cs: use membercache, if possible.
12643 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12645 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12648 According to the spec,
12650 In a member access of the form E.I, if E is a single identifier,
12651 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12652 field, property, localvariable, or parameter with the same type as
12653 the meaning of E as a type-name (§3.8), then both possible
12654 meanings of E are permitted.
12656 We did not check that E as a simple-name had the same type as E as
12659 This trivial check gives us 5-7% on bootstrap time.
12661 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12663 * expression.cs (Invocation.OverloadResolve): Avoid the
12664 use of hashtables and boxing here by allocating on demand.
12666 2004-05-30 Martin Baulig <martin@ximian.com>
12668 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12669 we're doing a silent lookup. Don't try to lookup nested types in
12670 TypeManager.object_type (thanks to Ben Maurer).
12672 2004-05-30 Martin Baulig <martin@ximian.com>
12674 Committing a patch from Ben Maurer.
12676 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12678 2004-05-29 Martin Baulig <martin@ximian.com>
12680 * class.cs (IMethodData.ShouldIgnore): New method.
12682 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12683 `Location' argument, we don't need it anywhere. Use
12684 `IMethodData.ShouldIgnore ()' instead of
12685 `MethodData.GetMethodFlags ()'.
12686 (TypeManager.AddMethod): Removed.
12687 (TypeManager.AddMethod2): Renamed to AddMethod.
12689 2004-05-29 Martin Baulig <martin@ximian.com>
12691 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12693 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12694 converting from a class type S to an interface type and we already
12695 have an object on the stack, don't box it again. Fixes #52578.
12697 2004-05-29 Martin Baulig <martin@ximian.com>
12699 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12700 Added support for `params' parameters. Fixes #59267.
12702 2004-05-29 Martin Baulig <martin@ximian.com>
12704 * literal.cs (NullPointer): Provide a private .ctor which sets
12705 `type' to TypeManager.object_type. Fixes #59048.
12707 2004-05-29 Martin Baulig <martin@ximian.com>
12709 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12710 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12712 * ecore.cs (EventExpr.instance_expr): Make the field private.
12714 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12716 Fixed bug #50080 & cs0214-2.cs
12717 * expression.cs (Cast.DoResolve): Check unsafe context here.
12719 * statement.cs (Resolve.DoResolve): Likewise.
12721 2004-05-26 Martin Baulig <martin@ximian.com>
12723 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12725 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12726 (RootContext.LookupType): Pass down the `silent' flag.
12728 2004-05-25 Martin Baulig <martin@ximian.com>
12731 (MethodGroupExpr.IdenticalTypeName): New public property.
12732 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12733 expression actually refers to a type.
12735 2004-05-25 Martin Baulig <martin@ximian.com>
12737 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
12738 for #56176 and made it actually work.
12740 2004-05-25 Martin Baulig <martin@ximian.com>
12742 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
12743 (FieldExpr, PropertyExpr): Override and implement
12744 CacheTemporaries. Fixes #52279.
12746 2004-05-25 Miguel de Icaza <miguel@ximian.com>
12748 * location.cs: In the new compiler listing a file twice is a
12749 warning, not an error.
12751 2004-05-24 Martin Baulig <martin@ximian.com>
12753 * enum.cs (Enum.DefineType): For the `BaseType' to be a
12754 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
12756 2004-05-24 Martin Baulig <martin@ximian.com>
12758 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
12759 walking the `using' list. Fixes #53921.
12761 2004-05-24 Martin Baulig <martin@ximian.com>
12763 * const.cs (Const.LookupConstantValue): Added support for
12764 EmptyCast's; fixes #55251.
12766 2004-05-24 Martin Baulig <martin@ximian.com>
12768 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
12769 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
12770 which does the CS0135 check. The reason is that we first need to
12771 check whether the variable actually exists.
12773 2004-05-24 Martin Baulig <martin@ximian.com>
12775 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
12776 than RootContext.LookupType() to find the explicit interface
12777 type. Fixes #58584.
12779 2004-05-24 Raja R Harinath <rharinath@novell.com>
12781 * Makefile: Simplify. Use executable.make.
12782 * mcs.exe.sources: New file. List of sources of mcs.exe.
12784 2004-05-24 Anders Carlsson <andersca@gnome.org>
12788 Use the invariant culture when doing String.Compare for CLS case
12791 2004-05-23 Martin Baulig <martin@ximian.com>
12793 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
12794 don't have any dots. Fixes #52622, added cs0246-8.cs.
12796 * namespace.cs (NamespaceEntry.Lookup): Likewise.
12798 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12800 * class.cs (MemberBase.Define): Reuse MemberType member for
12801 resolved type. Other methods can use it too.
12803 2004-05-23 Martin Baulig <martin@ximian.com>
12805 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
12806 the variable also exists in the current block (otherwise, we need
12807 to report a CS0103). Fixes #58670.
12809 2004-05-23 Martin Baulig <martin@ximian.com>
12811 * flowanalysis.cs (Reachability.Reachable): Compute this
12812 on-the-fly rather than storing it as a field.
12814 2004-05-23 Martin Baulig <martin@ximian.com>
12816 * flowanalysis.cs (Reachability.And): Manually compute the
12817 resulting `barrier' from the reachability.
12819 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12822 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
12823 instance of ObsoleteAttribute when symbol is obsolete.
12826 (IMethodData): Extended interface for ObsoleteAttribute support.
12828 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12830 * attribute.cs: Fix bug #55970
12832 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12836 (GetObsoleteAttribute): New method. Creates the instance of
12838 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
12839 ObsoleteAttribute when member is obsolete.
12840 (AttributeTester.Report_ObsoleteMessage): Common method for
12841 Obsolete error/warning reporting.
12844 (TypeContainer.base_classs_type): New member for storing parent type.
12847 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
12848 for this MemberCore.
12850 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12852 * attribute.cs, const.cs: Fix bug #58590
12854 2004-05-21 Martin Baulig <martin@ximian.com>
12856 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
12857 out parameters if the end of the method is unreachable. Fixes
12860 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12862 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
12863 Hari was right, why extra method.
12865 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12867 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
12869 2004-05-20 Martin Baulig <martin@ximian.com>
12871 Merged this back from gmcs to keep the differences to a minumum.
12873 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
12874 instead of a Declspace.
12875 (Attribute.ResolveType): Likewise.
12876 (Attributes.Search): Likewise.
12877 (Attributes.Contains): Likewise.
12878 (Attributes.GetClsCompliantAttribute): Likewise.
12880 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
12882 (MethodData.ApplyAttributes): Take an EmitContext instead of a
12885 2004-05-19 Marek Safar <marek.safar@seznam.cz>
12887 Fix bug #58688 (MCS does not report error when the same attribute
12890 * attribute.cs (Attribute.Emit): Distinction between null and default.
12892 2004-05-19 Raja R Harinath <rharinath@novell.com>
12894 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
12895 of a top-level attribute without an attribute target.
12896 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
12898 (Attribute.Conditional_GetConditionName),
12899 (Attribute.Obsolete_GetObsoleteMessage): Update.
12900 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
12901 part of ScanForIndexerName.
12902 (Attribute.CanIgnoreInvalidAttribute): New function.
12903 (Attribute.ScanForIndexerName): Move to ...
12904 (Attributes.ScanForIndexerName): ... here.
12905 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
12906 (Attributes.Search): New internal variant that can choose not to
12907 complain if types aren't resolved. The original signature now
12909 (Attributes.GetClsCompliantAttribute): Use internal variant, with
12910 complaints suppressed.
12911 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
12912 only if it not useful.
12913 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
12914 top-level for attributes that are shared between the assembly
12915 and a top-level class.
12916 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
12917 * class.cs: Update to reflect changes.
12918 (DefineIndexers): Fuse loops.
12919 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
12920 a couple more variants of attribute names.
12922 2004-05-18 Marek Safar <marek.safar@seznam.cz>
12924 Fix bug #52585 (Implemented explicit attribute declaration)
12927 (Attributable.ValidAttributeTargets): New abstract method. It gets
12928 list of valid attribute targets for explicit target declaration.
12929 (Attribute.Target): It holds target itself.
12930 (AttributeSection): Removed.
12931 (Attribute.CheckTargets): New method. It checks whether attribute
12932 target is valid for the current element.
12935 (EventProperty): New class. For events that are declared like
12936 property (with add and remove accessors).
12937 (EventField): New class. For events that are declared like field.
12940 * cs-parser.jay: Implemented explicit attribute target declaration.
12942 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
12943 Override ValidAttributeTargets.
12946 (ReturnParameter): Class for applying custom attributes on
12948 (ParameterAtribute): New class. Class for applying custom
12949 attributes on the parameter type.
12951 2004-05-17 Miguel de Icaza <miguel@ximian.com>
12953 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
12956 (Method): Allow UNSAFE here.
12958 * modifiers.cs: Support unsafe reporting.
12960 2004-05-17 Marek Safar <marek.safar@seznam.cz>
12962 * decl.cs: Fix bug #58478.
12964 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12966 * statement.cs: When checking for unreachable code on an EmptyStatement,
12967 set the location. Fixes bug #58488.
12969 2004-05-13 Miguel de Icaza <miguel@ximian.com>
12971 * driver.cs: Add -pkg handling.
12973 From Gonzalo: UseShelLExecute=false
12975 2004-05-12 Marek Safar <marek.safar@seznam.cz>
12978 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
12980 (Attribute.IsClsCompliaceRequired): Moved to base for better
12982 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
12983 when attribute is AttributeUsageAttribute.
12984 (Attribute.GetValidTargets): Simplified.
12985 (Attribute.GetAttributeUsage): New method returns AttributeUsage
12986 attribute for this type.
12987 (Attribute.ApplyAttributes): Method renamed to Emit and make
12989 (GlobalAttributeSection): New class for special handling of global
12990 attributes (assembly, module).
12991 (AttributeSection.Emit): New method.
12993 * class.cs: Implemented Attributable abstract methods.
12994 (MethodCore.LabelParameters): Moved to Parameter class.
12995 (Accessor): Is back simple class.
12996 (PropertyMethod): Implemented Attributable abstract class.
12997 (DelegateMethod): Implemented Attributable abstract class.
12998 (Event): New constructor for disctintion between normal Event
12999 and Event with accessors.
13001 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13003 * codegen.cs, const.cs, decl.cs, delegate.cs:
13004 (CommonAssemblyModulClass): Implemented Attributable abstract class
13007 * enum.cs: Implement IAttributeSupport interface.
13008 (EnumMember): New class for emum members. Implemented Attributable
13012 (ParameterBase): Is abstract.
13013 (ReturnParameter): New class for easier [return:] attribute handling.
13015 * typemanager.cs: Removed builder_to_attr.
13017 2004-05-11 Raja R Harinath <rharinath@novell.com>
13020 * attribute.cs (Attribute.GetPositionalValue): New function.
13021 * class.cs (TypeContainer.VerifyMembers): New function.
13022 (TypeContainer.Emit): Use it.
13023 (ClassOrStruct): New base class for Class and Struct.
13024 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13025 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13027 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13028 then each non-static field should have a FieldOffset attribute.
13029 Otherwise, none of the fields should have a FieldOffset attribute.
13030 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13031 and FieldOffset attributes.
13032 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13033 (TypeManager.field_offset_attribute_type): New core types.
13034 (TypeManager.InitCoreTypes): Initialize them.
13036 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13038 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13039 Return correct type.
13042 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13044 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13045 be implicitly converted to ulong.
13047 * expression.cs: The logic for allowing operator &, | and ^ worked
13048 was wrong, it worked before because we did not report an error in
13049 an else branch. Fixes 57895.
13051 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13052 allow volatile fields to be reference types.
13054 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13056 * driver.cs: Add support for /debug-
13058 2004-05-07 Raja R Harinath <rharinath@novell.com>
13060 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13061 Add a 'complain' parameter to silence errors.
13062 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13063 silently overlooked type-resolutions.
13064 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13065 to reflect changes.
13066 (Attributes.Search): New function.
13067 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13068 (Attributes.GetAttributeFullName): Remove hack.
13069 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13070 Update to reflect changes.
13071 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13072 Use Attributes.Search instead of nested loops.
13074 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13077 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13078 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13079 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13081 * report.cs: (Report.Warning): Renamed to Warning_T because of
13082 parameter collision.
13084 2004-05-05 Raja R Harinath <rharinath@novell.com>
13086 * expression.cs (MemberAccess.ResolveMemberAccess):
13087 Exit with non-zero status after Report.Error.
13088 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13090 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13092 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13094 * support.cs: Don't hang when the file is empty.
13096 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13098 * support.cs: In SeekableStreamReader, compute the preamble size of the
13099 underlying stream. Position changes should take into account that initial
13102 2004-05-03 Todd Berman <tberman@sevenl.net>
13104 * driver.cs: remove unused GetSysVersion function.
13106 2004-05-03 Todd Berman <tberman@sevenl.net>
13108 * driver.cs: Remove the hack from saturday, as well as the hack
13109 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13110 link_paths to get that bit proper.
13112 2004-05-01 Todd Berman <tberman@sevenl.net>
13114 * driver.cs: Try a LoadFrom before a Load, this checks the current
13115 path. This is currently a bug in mono that is be fixed, however, this
13116 provides a workaround for now. This will be removed when the bug
13119 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13121 * CryptoConvert.cs: Updated to latest version. Fix issue with
13122 incomplete key pairs (#57941).
13124 2004-05-01 Todd Berman <tberman@sevenl.net>
13126 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13129 2004-04-30 Jackson Harper <jackson@ximian.com>
13131 * codegen.cs: Open keys readonly.
13133 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13135 * typemanager.cs: don't report cyclic struct layout when a struct
13136 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13137 which has 2 Pango.Rectangle fields.
13139 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13141 * expression.cs: Handle IntPtr comparisons with IL code
13142 rather than a method call.
13144 2004-04-29 Martin Baulig <martin@ximian.com>
13146 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13147 the list of PropertyInfo's in class hierarchy and find the
13148 accessor. Fixes #56013.
13150 2004-04-29 Martin Baulig <martin@ximian.com>
13152 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13154 2004-04-29 Martin Baulig <martin@ximian.com>
13156 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13158 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13160 2004-04-29 Martin Baulig <martin@ximian.com>
13162 * class.cs (ConstructorInitializer.Resolve): Check whether the
13163 parent .ctor is accessible. Fixes #52146.
13165 2004-04-29 Martin Baulig <martin@ximian.com>
13167 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13169 * statement.cs (Using.EmitLocalVariableDecls): Use
13170 TypeManager.idisposable_type, not typeof (IDisposable).
13171 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13173 2004-04-29 Martin Baulig <martin@ximian.com>
13175 * class.cs (Event.Define): Don't emit the field and don't set
13176 RTSpecialName and SpecialName for events on interfaces. Fixes
13179 2004-04-29 Raja R Harinath <rharinath@novell.com>
13181 Refactor Attribute.ApplyAttributes.
13182 * attribute.cs (Attributable): New base class for objects that can
13183 have Attributes applied on them.
13184 (Attribute): Make AttributeUsage fields public.
13185 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13186 (Attribute.IsInternalCall): New property.
13187 (Attribute.UsageAttr): Convert to a public read-only property.
13188 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13189 (Attribute.ResolveType, Attribute.Resolve)
13190 (Attribute.ScanForIndexerName): Update to reflect changes.
13191 (Attribute.CheckAttributeTarget): Re-format.
13192 (Attribute.ApplyAttributes): Refactor, to various
13193 Attributable.ApplyAttributeBuilder methods.
13194 * decl.cs (MemberCore): Make Attributable.
13195 * class.cs (Accessor): Make Attributable.
13196 (MethodData.ApplyAttributes): Use proper attribute types, not
13198 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13199 (TypeContainer.ApplyAttributeBuilder)
13200 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13201 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13202 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13203 (Operator.ApplyAttributeBuilder): New factored-out methods.
13204 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13205 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13206 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13207 * parameter.cs (ParameterBase): New Attributable base class
13208 that can also represent Return types.
13209 (Parameter): Update to the changes.
13211 2004-04-29 Jackson Harper <jackson@ximian.com>
13213 * driver.cs: Prefer the corlib system version when looking for
13214 assemblies in the GAC. This is still a hack, but its a better hack
13217 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13219 * decl.cs, enum.cs: Improved error 3005 reporting.
13221 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13222 (related_symbols): New private member for list of symbols
13223 related to reported error/warning.
13225 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13227 2004-04-29 Martin Baulig <martin@ximian.com>
13229 * ecore.cs (Expression.Constantify): If we're an enum and
13230 TypeManager.TypeToCoreType() doesn't give us another type, use
13231 t.UnderlyingSystemType. Fixes #56178.
13233 2004-04-29 Martin Baulig <martin@ximian.com>
13235 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13236 interfaces and for each interface, only add members directly
13237 declared in that interface. Fixes #53255.
13239 2004-04-28 Martin Baulig <martin@ximian.com>
13241 * expression.cs (ConditionalLogicalOperator): Use a temporary
13242 variable for `left' to avoid that we evaluate it more than once;
13245 2004-04-28 Martin Baulig <martin@ximian.com>
13247 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13250 2004-04-28 Martin Baulig <martin@ximian.com>
13252 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13255 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13256 whether the type is not void (CS1547).
13258 2004-04-28 Martin Baulig <martin@ximian.com>
13260 * expression.cs (Unary.DoResolveLValue): Override this and report
13261 CS0131 for anything but Operator.Indirection.
13263 2004-04-28 Martin Baulig <martin@ximian.com>
13265 Committing a patch from Ben Maurer; see bug #50820.
13267 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13270 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13273 2004-04-28 Martin Baulig <martin@ximian.com>
13275 Committing a patch from Ben Maurer; see bug #50820.
13277 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13280 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13283 2004-04-28 Martin Baulig <martin@ximian.com>
13285 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13286 (Block.AddLabel): Call DoLookupLabel() to only search in the
13289 2004-04-28 Martin Baulig <martin@ximian.com>
13291 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13292 comparing StringConstants and NullLiterals in Equality and Inequality.
13294 2004-04-28 Jackson Harper <jackson@ximian.com>
13296 * driver.cs: Attempt to load referenced assemblies from the
13297 GAC. This is the quick and dirty version of this method that
13298 doesnt take into account versions and just takes the first
13299 canidate found. Will be good enough for now as we will not have more
13300 then one version installed into the GAC until I update this method.
13302 2004-04-28 Martin Baulig <martin@ximian.com>
13304 * typemanager.cs (TypeManager.CheckStructCycles): New public
13305 static method to check for cycles in the struct layout.
13307 * rootcontext.cs (RootContext.PopulateTypes): Call
13308 TypeManager.CheckStructCycles() for each TypeContainer.
13309 [Note: We only need to visit each type once.]
13311 2004-04-28 Martin Baulig <martin@ximian.com>
13313 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13315 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13316 success and added `out object value'. Use a `bool resolved' field
13317 to check whether we've already been called rather than
13318 `ConstantValue != null' since this breaks for NullLiterals.
13320 2004-04-28 Raja R Harinath <rharinath@novell.com>
13322 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13323 setting of this flag, since the 'set' method may be non-public.
13325 2004-04-28 Raja R Harinath <rharinath@novell.com>
13327 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13328 check on current_vector.Block.
13330 2004-04-27 Martin Baulig <martin@ximian.com>
13332 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13333 a field initializer. Fixes #56459.
13335 2004-04-27 Martin Baulig <martin@ximian.com>
13337 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13338 we're not attempting to use an indexer. Fixes #52154.
13340 2004-04-27 Martin Baulig <martin@ximian.com>
13342 * statement.cs (Return): Don't create a return label if we don't
13343 need it; reverts my change from January 20th. Thanks to Ben
13346 2004-04-27 Martin Baulig <martin@ximian.com>
13348 According to the spec, `goto' can only leave a nested scope, but
13351 * statement.cs (Block.LookupLabel): Only lookup in the current
13352 block, don't recurse into parent or child blocks.
13353 (Block.AddLabel): Check in parent and child blocks, report
13354 CS0140/CS0158 if we find a duplicate.
13355 (Block): Removed this indexer for label lookups.
13356 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13357 this already does the error reporting for us.
13360 (FlowBranching.UsageVector.Block): New public variable; may be null.
13361 (FlowBranching.CreateSibling): Added `Block' argument.
13362 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13363 label for the target of a `goto' and check whether we're not
13364 leaving a `finally'.
13366 2004-04-27 Martin Baulig <martin@ximian.com>
13368 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13369 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13372 2004-04-27 Martin Baulig <martin@ximian.com>
13374 * statement.cs (Block.AddLabel): Also check for implicit blocks
13375 and added a CS0158 check.
13377 2004-04-27 Martin Baulig <martin@ximian.com>
13379 * flowanalysis.cs (FlowBranchingLoop): New class.
13380 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13381 UsageVector's instead of an ArrayList.
13382 (FlowBranching.Label): Likewise.
13383 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13384 (FlowBranching.AddBreakVector): New method.
13386 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13388 * attribute.cs: Small regression fix: only convert the type if we
13389 the type is different, fixes System.Drawing build.
13391 2004-04-27 Martin Baulig <martin@ximian.com>
13393 * attribute.cs (Attribute.Resolve): If we have a constant value
13394 for a named field or property, implicity convert it to the correct
13397 2004-04-27 Raja R Harinath <rharinath@novell.com>
13399 * statement.cs (Block.Block): Implicit blocks share
13400 'child_variable_names' fields with parent blocks.
13401 (Block.AddChildVariableNames): Remove.
13402 (Block.AddVariable): Mark variable as "used by a child block" in
13403 every surrounding block.
13404 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13405 been used in a child block, complain about violation of "Invariant
13406 meaning in blocks" rule.
13407 * cs-parser.jay (declare_local_variables): Don't use
13408 AddChildVariableNames.
13409 (foreach_statement): Don't create an implicit block: 'foreach'
13410 introduces a scope.
13412 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13414 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13415 converting from 0L to ulong. Fixes 57522.
13417 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13419 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13420 derived class hides via 'new' keyword field from base class (test-242.cs).
13421 TODO: Handle this in the more general way.
13423 * class.cs (CheckBase): Ditto.
13425 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13427 * decl.cs (caching_flags): New member for storing cached values
13429 (MemberCore.Flags): New enum where bit flags for caching_flags
13431 (MemberCore.cls_compliance): Moved to caching_flags.
13432 (DeclSpace.Created): Moved to caching_flags.
13434 * class.cs: Use caching_flags instead of DeclSpace.Created
13436 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13438 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13439 if we are only a derived class, not a nested class.
13441 * typemanager.cs: Same as above, but do this at the MemberLookup
13442 level (used by field and methods, properties are handled in
13443 PropertyExpr). Allow for the qualified access if we are a nested
13446 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13448 * class.cs: Refactoring.
13449 (IMethodData): New inteface; Holds links to parent members
13450 to avoid member duplication (reduced memory allocation).
13451 (Method): Implemented IMethodData interface.
13452 (PropertyBase): New inner classes for get/set methods.
13453 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13454 (Event): New inner classes for add/remove methods.
13455 (Event.DelegateMethod): Implemented IMethodData interface.
13457 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13458 EmitContext (related to class.cs refactoring).
13460 2004-04-21 Raja R Harinath <rharinath@novell.com>
13462 * delegate.cs (Delegate.VerifyApplicability): If the number of
13463 arguments are the same as the number of parameters, first try to
13464 verify applicability ignoring any 'params' modifier on the last
13468 2004-04-16 Raja R Harinath <rharinath@novell.com>
13470 * class.cs (TypeContainer.AddIndexer): Use
13471 'ExplicitInterfaceName' to determine if interface name was
13472 explicitly specified. 'InterfaceType' is not initialized at this time.
13473 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13474 Indexers array is already in the required order. Initialize
13475 'IndexerName' only if there are normal indexers.
13476 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13477 (TypeContainer.Emit): Emit DefaultMember attribute only if
13478 IndexerName is initialized.
13481 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13483 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13486 2004-04-15 Raja R Harinath <rharinath@novell.com>
13488 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13492 * attribute.cs (Attribute.Resolve): Check for duplicate named
13496 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13498 * iterators.cs (MarkYield): track whether we are in an exception,
13499 and generate code accordingly. Use a temporary value to store the
13500 result for our state.
13502 I had ignored a bit the interaction of try/catch with iterators
13503 since their behavior was not entirely obvious, but now it is
13504 possible to verify that our behavior is the same as MS .NET 2.0
13508 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13510 * iterators.cs: Avoid creating temporaries if there is no work to
13513 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13514 Enumerations, use TypeManager.EnumToUnderlying and call
13517 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13520 (This.Emit): Use EmitContext.EmitThis to emit our
13523 (This.EmitAssign): Ditto.
13525 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13526 codepaths, we will move all the functionality into
13529 (FieldExpr.EmitAssign): Ditto.
13531 This fixes several hidden bugs that I uncovered while doing a code
13532 review of this today.
13534 * codegen.cs (EmitThis): reworked so the semantics are more clear
13535 and also support value types "this" instances.
13537 * iterators.cs: Changed so that for iterators in value types, we
13538 do not pass the value type as a parameter.
13540 Initialization of the enumerator helpers is now done in the caller
13541 instead of passing the parameters to the constructors and having
13542 the constructor set the fields.
13544 The fields have now `assembly' visibility instead of private.
13546 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13548 * expression.cs (Argument.Resolve): Check if fields passed as ref
13549 or out are contained in a MarshalByRefObject.
13551 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13552 another compiler type.
13554 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13556 * class.cs (Indexer.Define): use the new name checking method.
13557 Also, return false on an error.
13558 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13559 (is_identifier_[start/part]_character): make static.
13561 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13563 * expression.cs (Binary.ResolveOperator): Do no append strings
13564 twice: since we can be invoked more than once (array evaluation)
13565 on the same concatenation, take care of this here. Based on a fix
13566 from Ben (bug #56454)
13568 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13570 * codegen.cs: Fix another case where CS1548 must be reported (when
13571 delay-sign isn't specified and no private is available #56564). Fix
13572 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13573 error when MCS is used on the MS runtime and we need to delay-sign
13574 (which seems unsupported by AssemblyBuilder - see #56621).
13576 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13578 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13579 (TypeManager.ComputeNamespaces): Faster implementation for
13582 * compiler.csproj: Updated AssemblyName to mcs.
13584 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13586 * rootcontext.cs: Add new types to the boot resolution.
13588 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13589 MulticastDelegate is not allowed.
13591 * typemanager.cs: Add new types to lookup: System.TypedReference
13594 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13595 check for TypedReference or ArgIterator, they are not allowed.
13597 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13598 makes us properly catch 1510 in some conditions (see bug 56016 for
13601 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13603 * CryptoConvert.cs: update from corlib version
13606 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13608 * class.cs (Indexer.Define): Check indexername declaration
13610 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13612 * attribute.cs (IsClsCompliant): Fixed problem with handling
13613 all three states (compliant, not-compliant, undetected).
13615 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13617 * attribute.cs (Attribute): Location is now public.
13618 (Resolve): Store resolved arguments (pos_values) in attribute class.
13619 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13620 (GetClsCompliantAttributeValue): New method that gets
13621 CLSCompliantAttribute value.
13622 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13623 if exists else null.
13624 (AttributeTester): New class for CLS-Compliant verification routines.
13626 * class.cs (Emit): Add CLS-Compliant verification.
13627 (Method.GetSignatureForError): Implemented.
13628 (Constructor.GetSignatureForError): Implemented
13629 (Constructor.HasCompliantArgs): Returns if constructor has
13630 CLS-Compliant arguments.
13631 (Constructor.Emit): Override.
13632 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13633 is needed to test only parameters.
13634 (FieldBase.GetSignatureForError): Implemented.
13635 (TypeContainer): New member for storing base interfaces.
13636 (TypeContainer.FindMembers): Search in base interfaces too.
13638 * codegen.cs (GetClsComplianceAttribute): New method that gets
13639 assembly or module CLSCompliantAttribute value.
13640 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13642 (ModuleClass.Emit): Add error 3012 test.
13644 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13646 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13647 state for all decl types.
13648 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13649 if CLS-Compliant tests are required.
13650 (IsClsCompliaceRequired): New method. Analyze whether code
13651 must be CLS-Compliant.
13652 (IsExposedFromAssembly): New method. Returns true when MemberCore
13653 is exposed from assembly.
13654 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13655 value or gets cached value.
13656 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13657 is explicitly marked with CLSCompliantAttribute.
13658 (IsIdentifierClsCompliant): New abstract method. This method is
13659 used to testing error 3005.
13660 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13661 for identifier and parameters CLS-Compliant testing.
13662 (VerifyClsCompliance): New method. The main virtual method for
13663 CLS-Compliant verifications.
13664 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13665 null. I don't know why is null (too many public members !).
13666 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13667 and get value of first CLSCompliantAttribute that found.
13669 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13670 (VerifyClsCompliance): Override and add extra tests.
13672 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13673 clscheck- disable CLS-Compliant verification event if assembly is has
13674 CLSCompliantAttribute(true).
13676 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13677 ApllyAttribute is now called in emit section as in the other cases.
13678 Possible future Emit integration.
13679 (IsIdentifierClsCompliant): New override.
13680 (VerifyClsCompliance): New override.
13681 (GetEnumeratorName): Returns full enum name.
13683 * parameter.cs (GetSignatureForError): Implemented.
13685 * report.cs (WarningData): New struct for Warning message information.
13686 (LocationOfPreviousError): New method.
13687 (Warning): New method. Reports warning based on the warning table.
13688 (Error_T): New method. Reports error based on the error table.
13690 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13691 verifications are done here.
13693 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13695 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13696 CLSCompliantAttribute.
13697 (all_imported_types): New member holds all imported types from other
13699 (LoadAllImportedTypes): New method fills static table with exported types
13700 from all referenced assemblies.
13701 (Modules): New property returns all assembly modules.
13703 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13705 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13706 throwing a parser error.
13708 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13709 which removes the hardcoded get_/set_ prefixes for properties, as
13710 IL allows for the properties to be named something else.
13714 * expression.cs: Do not override operand before we know if it is
13715 non-null. Fix 56207
13717 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13719 * typemanager.cs: support for pinned variables.
13721 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13723 * decl.cs, typemanager.cs: Avoid using an arraylist
13724 as a buffer if there is only one result set.
13726 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13728 * expression.cs: Make sure you cant call a static method
13729 with an instance expression, bug #56174.
13731 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13733 * class.cs (IsDuplicateImplementation): Improve error reporting to
13734 flag 663 (method only differs in parameter modifier).
13736 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
13737 in preprocessor directives.
13739 * location.cs (LookupFile): Allow for the empty path.
13741 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
13742 better approach for some of that patch, but its failing with the
13743 CharSet enumeration. For now try/catch will do.
13745 * typemanager.cs: Do not crash if a struct does not have fields.
13748 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13750 * expression.cs: cs0213, cant fix a fixed expression.
13753 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13755 * cs-parser.jay: detect invalid embeded statements gracefully.
13758 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13760 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
13763 the invocation type may not be a subclass of the tye of the item/
13764 The type of the item must be a subclass of the invocation item.
13769 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
13771 * attribute.cs: Added methods to get a string and a bool from an
13772 attribute. Required to information from AssemblyKeyFileAttribute,
13773 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
13774 * codegen.cs: Modified AssemblyName creation to include support for
13775 strongnames. Catch additional exceptions to report them as CS1548.
13776 * compiler.csproj: Updated include CryptoConvert.cs.
13777 * compiler.csproj.user: Removed file - user specific configuration.
13778 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
13779 Mono.Security assembly. The original class is maintained and tested in
13780 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
13781 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
13782 like CSC 8.0 (C# v2) supports.
13783 * Makefile: Added CryptoConvert.cs to mcs sources.
13784 * rootcontext.cs: Added new options for strongnames.
13786 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
13788 * driver.cs: For --expect-error, report error code `2'
13789 if the program compiled with no errors, error code `1' if
13790 it compiled with an error other than the one expected.
13792 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
13794 * compiler.csproj: Updated for Visual Studio .NET 2003.
13795 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
13796 * compiler.sln: Updated for Visual Studio .NET 2003.
13798 2004-03-24 Ravi Pratap M <ravi@ximian.com>
13800 * expression.cs: Fix bug #47234. We basically need to apply the
13801 rule that we prefer the conversion of null to a reference type
13802 when faced with a conversion to 'object' (csc behaviour).
13804 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13806 * statement.cs: Shorter form for foreach, eliminates
13807 a local variable. r=Martin.
13809 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13811 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
13812 checks if we can use brtrue/brfalse to test for 0.
13813 * expression.cs: use the above in the test for using brtrue/brfalse.
13814 cleanup code a bit.
13816 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13818 * expression.cs: Rewrite string concat stuff. Benefits:
13820 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
13821 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
13822 rather than a concat chain.
13824 * typemanager.cs: Add lookups for more concat overloads.
13826 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13828 * expression.cs: Emit shorter il code for array init.
13845 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
13847 * statement.cs: Before, two switch blocks would be merged if the
13848 total size of the blocks (end_item - begin_item + 1) was less than
13849 two times the combined sizes of the blocks.
13851 Now, it will only merge if after the merge at least half of the
13856 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
13858 * class.cs : csc build fix for GetMethods(). See bug #52503.
13860 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
13862 * expression.cs: Make sure fp comparisons work with NaN.
13863 This fixes bug #54303. Mig approved this patch a long
13864 time ago, but we were not able to test b/c the runtime
13867 2004-03-19 Miguel de Icaza <miguel@ximian.com>
13869 * ecore.cs (TypExpr.GetHashCode): implement this overload.
13871 2004-03-19 Martin Baulig <martin@ximian.com>
13873 * class.cs (MemberCore.IsDuplicateImplementation): Report the
13874 error here and not in our caller.
13876 2004-03-19 Martin Baulig <martin@ximian.com>
13878 * interface.cs: Completely killed this file.
13879 (Interface): We're now a TypeContainer and live in class.cs.
13881 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
13882 argument; we're now also called for interfaces.
13883 (TypeContainer.DefineMembers): Allow this method being called
13885 (TypeContainer.GetMethods): New public method; formerly known as
13886 Interface.GetMethod(). This is used by PendingImplementation.
13887 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
13888 it's now private and non-static.
13889 (Interface): Moved this here; it's now implemented similar to
13891 (Method, Property, Event, Indexer): Added `bool is_interface'
13892 argument to their .ctor's.
13893 (MemberBase.IsInterface): New public field.
13895 * cs-parser.jay: Create normal Method, Property, Event, Indexer
13896 instances instead of InterfaceMethod, InterfaceProperty, etc.
13897 (opt_interface_base): Removed; we now use `opt_class_base' instead.
13898 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
13900 2004-03-19 Martin Baulig <martin@ximian.com>
13902 * class.cs (MethodCore.IsDuplicateImplementation): New private
13903 method which does the CS0111 checking.
13904 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
13905 Use IsDuplicateImplementation().
13907 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
13909 * decl.cs (FindMemberToOverride): New method to find the correct
13910 method or property to override in the base class.
13912 - Make Method/Property use the above method to find the
13913 version in the base class.
13914 - Remove the InheritableMemberSignatureCompare as it is now
13917 This patch makes large code bases much faster to compile, as it is
13918 O(n) rather than O(n^2) to do this validation.
13920 Also, it fixes bug 52458 which is that nested classes are not
13921 taken into account when finding the base class member.
13923 Reviewed/Approved by Martin.
13925 2004-03-17 Marek Safar <marek.safar@seznam.cz>
13927 * interface.cs: In all interface classes removed redundant
13928 member initialization.
13930 2004-03-16 Martin Baulig <martin@ximian.com>
13932 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
13934 2004-03-15 Miguel de Icaza <miguel@ximian.com>
13936 * decl.cs (DefineTypeAndParents): New helper method to define a
13937 type's containers before the type itself is defined; This is a
13938 bug exposed by the recent changes to Windows.Forms when an
13939 implemented interface was defined inside a class that had not been
13942 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
13944 (Check): Loop correctly to report errors modifiers
13945 (UNSAFE was not in the loop, since it was the same as TOP).
13947 * interface.cs: Every interface member now takes a ModFlags,
13948 instead of a "is_new" bool, which we set on the base MemberCore.
13950 Every place where we called "UnsafeOk" in the interface, now we
13951 call the proper member (InterfaceMethod.UnsafeOK) instead to get
13952 the unsafe settings from the member declaration instead of the
13953 container interface.
13955 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
13957 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
13958 `set_indexer_name' to the pending bits (one per type).
13960 We fixed a bug today that was picking the wrong method to
13961 override, since for properties the existing InterfaceMethod code
13962 basically ignored the method name. Now we make sure that the
13963 method name is one of the valid indexer names.
13965 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
13967 * support.cs (SeekableStreamReader): Keep track of stream byte
13968 positions and don't mix them with character offsets to the buffer.
13970 Patch from Gustavo Giráldez
13972 2004-03-15 Marek Safar <marek.safar@seznam.cz>
13974 * interface.cs (InterfaceSetGetBase): Removed double member
13975 initialization, base class does it as well.
13977 2004-03-13 Martin Baulig <martin@ximian.com>
13979 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
13980 when compiling corlib.
13982 2004-03-13 Miguel de Icaza <miguel@ximian.com>
13984 * convert.cs (ExplicitConversion): We were reporting an error on
13985 certain conversions (object_type source to a value type, when the
13986 expression was `null') before we had a chance to pass it through
13987 the user defined conversions.
13989 * driver.cs: Replace / and \ in resource specifications to dots.
13992 * class.cs: Add check for duplicate operators. Fixes 52477
13994 2004-03-11 Miguel de Icaza <miguel@ximian.com>
13996 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
13997 that are in the middle of the statements, not only at the end.
14000 * class.cs (TypeContainer.AddField): No longer set the
14001 `HaveStaticConstructor' flag, now we call it
14002 `UserDefineStaticConstructor' to diferentiate the slightly
14003 semantic difference.
14005 The situation is that we were not adding BeforeFieldInit (from
14006 Modifiers.TypeAttr) to classes that could have it.
14007 BeforeFieldInit should be set to classes that have no static
14012 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14014 And most importantly Zoltan's comment:
14016 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14018 "I think beforefieldinit means 'it's ok to initialize the type sometime
14019 before its static fields are used', i.e. initialization does not need
14020 to be triggered by the first access to the type. Setting this flag
14021 helps the JIT to compile better code, since it can run the static
14022 constructor at JIT time, and does not need to generate code to call it
14023 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14024 this flag for lots of classes like String.
14026 csc sets this flag if the type does not have an explicit static
14027 constructor. The reasoning seems to be that if there are only static
14028 initalizers for a type, and no static constructor, then the programmer
14029 does not care when this initialization happens, so beforefieldinit
14032 This bug prevents the AOT compiler from being usable, since it
14033 generates so many calls to mono_runtime_class_init that the AOT code
14034 is much slower than the JITted code. The JITted code is faster,
14035 because it does not generate these calls if the vtable is type is
14036 already initialized, which is true in the majority of cases. But the
14037 AOT compiler can't do this."
14039 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14041 * class.cs (MethodData.Emit): Refactor the code so symbolic
14042 information is generated for destructors; For some reasons we
14043 were taking a code path that did not generate symbolic information
14046 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14048 * class.cs: Create a Constructor.CheckBase method that
14049 takes care of all validation type code. The method
14050 contains some code that was moved from Define.
14052 It also includes new code that checks for duplicate ctors.
14053 This fixes bug #55148.
14055 2004-03-09 Joshua Tauberer <tauberer@for.net>
14057 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14058 a { ... }-style array creation invokes EmitStaticInitializers
14059 which is not good for reference-type arrays. String, decimal
14060 and now null constants (NullCast) are not counted toward
14061 static initializers.
14063 2004-03-05 Martin Baulig <martin@ximian.com>
14065 * location.cs (SourceFile.HasLineDirective): New public field;
14066 specifies whether the file contains or is referenced by a "#line"
14068 (Location.DefineSymbolDocuments): Ignore source files which
14069 either contain or are referenced by a "#line" directive.
14071 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14073 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14074 direct access to our parent, so check the method inline there.
14076 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14078 * expression.cs (Invocation.EmitCall): Miguel's last commit
14079 caused a regression. If you had:
14084 In Foo the implict this would be null.
14086 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14088 * expression.cs (Invocation.EmitCall): If the method is not
14089 virtual, do not emit a CallVirt to it, use Call.
14091 * typemanager.cs (GetFullNameSignature): Improve the method to
14092 cope with ".ctor" and replace it with the type name.
14094 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14095 as an argument the ConstructorBuilder where it is being defined,
14096 to catch the recursive constructor invocations.
14098 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14100 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14101 routines to check if a type is an enumerable/enumerator allow
14102 classes that implement the IEnumerable or IEnumerator interfaces.
14104 * class.cs (Property, Operator): Implement IIteratorContainer, and
14105 implement SetYields.
14107 (Property.Define): Do the block swapping for get_methods in the
14108 context of iterators. We need to check if Properties also
14109 include indexers or not.
14111 (Operator): Assign the Block before invoking the
14112 OperatorMethod.Define, so we can trigger the Iterator code
14115 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14116 Property and Operator classes are not created when we parse the
14117 declarator but until we have the block completed, so we use a
14118 singleton SimpleIteratorContainer.Simple to flag whether the
14119 SetYields has been invoked.
14121 We propagate this setting then to the Property or the Operator to
14122 allow the `yield' to function.
14124 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14126 * codegen.cs: Implemented attribute support for modules.
14127 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14128 Assembly/Module functionality.
14130 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14131 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14132 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14134 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14136 * interface.cs (FindMembers): The operation is performed on all base
14137 interfaces and not only on the first. It is required for future CLS Compliance patch.
14139 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14141 * statement.cs, codegen.cs:
14142 This patch deals with patterns such as:
14144 public class List : IEnumerable {
14146 public MyEnumerator GetEnumerator () {
14147 return new MyEnumerator(this);
14150 IEnumerator IEnumerable.GetEnumerator () {
14154 public struct MyEnumerator : IEnumerator {
14159 Before, there were a few things we did wrong:
14160 1) we would emit callvirt on a struct, which is illegal
14161 2) we emited ldarg when we needed to emit ldarga
14162 3) we would mistakenly call the interface methods on an enumerator
14163 type that derived from IEnumerator and was in another assembly. For example:
14165 public class MyEnumerator : IEnumerator
14167 Would have the interface methods called, even if there were public impls of the
14168 method. In a struct, this lead to invalid IL code.
14170 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14172 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14175 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14177 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14179 * cs-parser.jay: Fix small regression: we were not testing V2
14180 compiler features correctly.
14182 * interface.cs: If the emit context is null, then create one
14184 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14186 * decl.cs (GetSignatureForError): New virtual method to get full name
14187 for error messages.
14189 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14190 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14192 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14193 Duplicated members and code in these classes has been removed.
14194 Better encapsulation in these classes.
14196 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14198 * assign.cs (Assign.DoResolve): When dealing with compound
14199 assignments, there is a new rule in ECMA C# 2.4 (might have been
14200 there before, but it is documented here) that states that in:
14204 If b is of type int, and the `op' is a shift-operator, then the
14205 above is evaluated as:
14209 * expression.cs (Binary.ResolveOperator): Instead of testing for
14210 int/uint/long/ulong, try to implicitly convert to any of those
14211 types and use that in pointer arithmetic.
14213 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14214 method to print information for from the type, not from the
14215 null-method we were given.
14217 2004-02-01 Duncan Mak <duncan@ximian.com>
14219 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14220 parsing for cmd, fixes bug #53694.
14222 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14224 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14225 in the member name duplication tests. Property and operator name duplication
14226 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14228 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14230 * interface.cs (PopulateMethod): Fixed crash when interface method
14231 returns not existing type (error test cs0246-3.cs).
14233 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14235 * cs-parser.jay (interface_accessors): Re-write actions to also
14236 store attributes attached to get and set methods. Fix spelling
14239 (inteface_property_declaration): Modify accordingly.
14241 (InterfaceAccessorInfo): New helper class to store information to pass
14242 around between rules that use interface_accessors.
14244 * interface.cs (Emit): Apply attributes on the get and set
14245 accessors of properties and indexers too.
14247 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14248 right MethodBuilder when applying attributes to the get and set accessors.
14250 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14252 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14254 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14256 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14258 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14260 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14261 changes that treat `yield' specially when present before `break'
14262 or `return' tokens.
14264 * cs-tokenizer.cs: yield is no longer a keyword.
14266 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14268 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14269 setting for default constructors.
14270 For default constructors are almost every time set wrong Modifier. The
14271 generated IL code has been alright. But inside mcs this values was
14272 wrong and this was reason why several of my CLS Compliance tests
14275 2004-01-22 Martin Baulig <martin@ximian.com>
14277 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14278 not a QualifiedIdentifier. This is what `type_name_expression'
14279 was previously doing.
14280 (type_name_expression): Removed; the code is now in
14281 `namespace_or_type_name'.
14282 (qualified_identifier): Removed, use `namespace_or_type_name'
14284 (QualifiedIdentifier): Removed this class.
14286 2004-01-22 Martin Baulig <martin@ximian.com>
14288 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14289 not a string as alias name.
14291 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14293 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14294 #52730 bug, and instead compute correctly the need to use a
14295 temporary variable when requesting an address based on the
14296 static/instace modified of the field and the constructor.
14298 2004-01-21 Martin Baulig <martin@ximian.com>
14300 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14301 class and namespace before looking up aliases. Fixes #52517.
14303 2004-01-21 Martin Baulig <martin@ximian.com>
14305 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14306 assinged in a 'try'; fixes exception4.cs.
14308 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14309 * class.cs : Implemented parameter-less constructor for TypeContainer
14311 * decl.cs: Attributes are now stored here. New property OptAttributes
14313 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14315 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14317 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14319 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14320 (CSharpSignature): New method for indexer and property signature.
14322 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14324 * pending.cs (IsVirtualFilter): Faster implementation.
14326 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14328 * typemanager.cs: Avoid inclusion of same assembly more than once.
14330 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14332 * cs-parser.jay: Fixed problem where the last assembly attribute
14333 has been applied also to following declaration (class, struct, etc.)
14335 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14337 * class.cs: Added error CS0538, CS0539 reporting.
14338 Fixed crash on Microsoft runtime when field type is void.
14340 * cs-parser.jay: Added error CS0537 reporting.
14342 * pending.cs: Added error CS0535 reporting.
14343 Improved error report for errors CS0536, CS0534.
14345 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14347 Merge a few bits from the Anonymous Method MCS tree.
14349 * statement.cs (ToplevelBlock): New class for toplevel methods,
14350 will hold anonymous methods, lifted variables.
14352 * cs-parser.jay: Create toplevel blocks for delegates and for
14353 regular blocks of code.
14355 2004-01-20 Martin Baulig <martin@ximian.com>
14357 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14358 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14359 and `NeedExplicitReturn'; added `IsLastStatement'.
14360 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14361 have a `ReturnLabel' or we're not unreachable.
14363 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14364 child's reachability; don't just override ours with it. Fixes
14365 #58058 (lluis's example).
14366 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14367 InFinally(), InLoop(), InSwitch() and
14368 BreakCrossesTryCatchBoundary() methods.
14370 * statement.cs (Return): Do all error checking in Resolve().
14371 Unless we are the last statement in a top-level block, always
14372 create a return label and jump to it.
14373 (Break, Continue): Do all error checking in Resolve(); also make
14374 sure we aren't leaving a `finally'.
14375 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14376 statement in a top-level block.
14377 (Block.Flags): Added `IsDestructor'.
14378 (Block.IsDestructor): New public property.
14380 2004-01-20 Martin Baulig <martin@ximian.com>
14382 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14384 2004-01-20 Martin Baulig <martin@ximian.com>
14386 * statement.cs (Statement.ResolveUnreachable): New public method.
14387 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14388 (Block.Resolve): Resolve unreachable statements.
14390 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14392 * expression.cs: We need to fix the case where we do
14393 not have a temp variable here.
14395 * assign.cs: Only expression compound assignments need
14396 temporary variables.
14398 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14400 * flowanalysis.cs: Reduce memory allocation in a few ways:
14401 - A block with no variables should not allocate a bit
14403 - A method with no out parameters does not need any tracking
14404 for assignment of the parameters, so we need not allocate
14407 public readonly Type[] VariableTypes;
14408 public readonly string[] VariableNames;
14409 Are redundant. The data is already stored in the variable
14410 map, so we need not allocate another array for it.
14411 - We need to add alot of checks for if (params | locals) == null
14412 due to the first two changes.
14414 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14416 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14417 implement IMemoryLocation, we store a copy on a local variable and
14418 take the address of it. Patch from Benjamin Jemlich
14420 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14421 to use a special "type_name_expression" rule which reduces the
14422 number of "QualifiedIdentifier" classes created, and instead
14423 directly creates MemberAccess expressions.
14425 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14427 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14428 that fixes #52853. Null literal assignment to ValueType
14430 * class.cs (MethodData.Emit): Instead of checking the name of the
14431 method to determine if its a destructor, create a new derived
14432 class from Method called Destructor, and test for that.
14434 * cs-parser.jay: Create a Destructor object instead of a Method.
14436 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14440 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14442 * expression.cs (Binary.ResolveOperator): Perform an implicit
14443 conversion from MethodGroups to their delegate types on the
14444 Addition operation.
14446 * delegate.cs: Introduce a new class DelegateCreation that is the
14447 base class for `NewDelegate' and `ImplicitDelegateCreation',
14448 factor some code in here.
14450 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14451 conversion from MethodGroups to compatible delegate types.
14453 * ecore.cs (Expression.Resolve): Do not flag error 654
14454 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14455 we allow conversions from MethodGroups to delegate types now.
14457 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14458 assignments in v2 either.
14460 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14462 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14463 static read-only fields in ctors.
14465 Applied patch from Benjamin Jemlich
14467 * expression.cs (UnaryMutator): Avoid leaking local variables.
14469 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14471 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14472 here to return true, as they can be used like this:
14474 (XXX) int.MEMBER ()
14476 Fixed 49836 and all the other dups
14478 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14480 * driver.cs: Implement /win32res and /win32icon.
14482 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14484 * cs-parser.jay: Add a rule to improve error handling for the
14485 common mistake of placing modifiers after the type.
14487 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14489 * cs-parser.jay (interface_event_declaration): Catch
14490 initialization of events on interfaces, and report cs0068
14492 * cs-parser.jay (interface_event_declaration): Catch
14493 initialization of events.
14495 * ecore.cs: Better report missing constructors.
14497 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14498 the error reporting done in the wrong place. Fix.
14500 * expression.cs (Binary.ResolveOperator): Catch the
14501 operator + (E x, E y) error earlier, and later allow for implicit
14502 conversions in operator +/- (E e, U x) from U to the underlying
14505 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14506 52596, if the container class is abstract, the default constructor
14507 is protected otherwise its public (before, we were always public).
14509 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14512 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14513 Jemlich that fixes bug #52597, MCS was generating invalid code for
14514 idisposable structs. Thanks to Ben for following up with this
14517 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14519 * driver.cs: Allow assemblies without code to be generated, fixes
14522 2004-01-07 Nick Drochak <ndrochak@gol.com>
14524 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14526 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14528 * cs-parser.jay: Add rules to improve error reporting if fields or
14529 methods are declared at the namespace level (error 116)
14531 * Add rules to catch event add/remove
14533 2004-01-04 David Sheldon <dave-mono@earth.li>
14535 * expression.cs: Added matching ")" to error message for
14538 2004-01-03 Todd Berman <tberman@gentoo.org>
14540 * ecore.cs, attribute.cs:
14541 Applying fix from #52429.
14543 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14545 * ecore.cs, expression.cs, statement.cs:
14546 Total rewrite of how we handle branching. We
14547 now handle complex boolean expressions with fewer
14548 jumps. As well if (x == 0) no longer emits a ceq.
14550 if (x is Foo) is much faster now, because we generate
14553 Overall, we get a pretty big improvement on our benchmark
14554 tests. The code we generate is smaller and more readable.
14556 I did a full two-stage bootstrap. The patch was reviewed
14557 by Martin and Miguel.
14559 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14561 * cs-parser.jay: Make primary_expression not take a QI.
14562 we dont need this because the member_access rule covers
14563 us here. So we replace the rule with just IDENTIFIER.
14565 This has two good effects. First, we remove a s/r conflict.
14566 Second, we allocate many fewer QualifiedIdentifier objects.
14568 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14570 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14571 set the correct information via SRE. This prevents
14572 hanging on the MS runtime. Fixes #29374.
14574 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14576 * convert.cs: correctly handle conversions to value types
14577 from Enum and ValueType as unboxing conversions.
14579 Fixes bug #52569. Patch by Benjamin Jemlich.
14581 2004-01-02 Ravi Pratap <ravi@ximian.com>
14583 * expression.cs (BetterConversion): Prefer int -> uint
14584 over int -> ulong (csc's behaviour). This fixed bug #52046.
14586 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14588 * decl.cs (MemberCache.FindMembers): now returns a
14591 * typemanager.cs: In general, go with with ^^.
14592 (CopyNewMethods): take an IList.
14593 (RealMemberLookup): Only allocate an arraylist
14594 if we copy from two sets of methods.
14596 This change basically does two things:
14597 1) Fewer array lists allocated due to CopyNewMethods.
14598 2) the explicit cast in MemberList costed ALOT.
14600 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14602 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14603 a hashtable to avoid needless string allocations when an identifier is
14604 used more than once (the common case).
14606 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14608 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14609 is broken, it will not return anything. So, we
14610 have to use the information we have in mcs to
14613 * typemanager.cs: Add a cache for GetInterfaces,
14614 since this will now be used more often (due to ^^)
14616 (GetExplicitInterfaces) New method that gets the
14617 declared, not effective, interfaces on a type
14618 builder (eg, if you have interface IFoo, interface
14619 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14622 This patch makes MCS able to bootstrap itself on
14625 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14627 * expression.cs: Remove the Nop's that Miguel put
14630 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14632 * report.cs, codegen.cs: Give the real stack trace to
14633 the error when an exception is thrown.
14635 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14637 * decl.cs: only allocate hashtables for ifaces if
14640 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14642 * expression.cs: fix the error from cs0121-2.cs
14643 (a parent interface has two child interfaces that
14644 have a function with the same name and 0 params
14645 and the function is called through the parent).
14647 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14649 * class.cs, rootcontext.cs, typmanager.cs: do not
14652 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14654 * codegen.cs: remove stack for the ec flow branching.
14655 It is already a linked list, so no need.
14657 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14659 * Makefile: Allow custom profiler here.
14661 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14663 * typemanager.cs (LookupType):
14664 - Use a static char [], because split takes
14665 a param array for args, so it was allocating
14667 - Do not store true in a hashtable, it boxes.
14669 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14671 * flowanalysis.cs: bytify common enums.
14673 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14675 * modifiers.cs: Add a new set of flags for the
14676 flags allowed on explicit interface impls.
14677 * cs-parser.jay: catch the use of modifiers in
14678 interfaces correctly.
14679 * class.cs: catch private void IFoo.Blah ().
14681 All related to bug #50572.
14683 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14685 * decl.cs: Rewrite the consistant accessability checking.
14686 Accessability is not linear, it must be implemented in
14687 a tableish way. Fixes #49704.
14689 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14691 * expression.cs: Handle negation in a checked context.
14692 We must use subtraction from zero. Fixes #38674.
14694 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14696 * class.cs: Ignore static void main in DLLs.
14697 * rootcontext.cs: Handle the target type here,
14698 since we are have to access it from class.cs
14699 * driver.cs: account for the above.
14701 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14703 * report.cs: Give line numbers and files if available.
14705 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14707 * driver.cs: Implement /addmodule.
14709 * typemanager.cs: Change 'modules' field so it now contains Modules not
14712 2003-12-20 Martin Baulig <martin@ximian.com>
14714 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14715 (FieldBase.IsAssigned): Removed this field.
14716 (FieldBase.SetAssigned): New public method.
14717 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14719 2003-12-20 Martin Baulig <martin@ximian.com>
14721 * expression.cs (LocalVariableReference.DoResolve): Don't set
14722 `vi.Used' if we're called from DoResolveLValue().
14724 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14725 returns the usage vector it just merged into the current one -
14726 pass this one to UsageWarning().
14727 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14728 of the `EmitContext', don't call this recursively on our children.
14730 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14732 * driver.cs: Implement /target:module.
14734 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14736 * support.cs (CharArrayHashtable): New helper class.
14738 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
14739 char arrays, not strings, so we can avoid creating a string in
14740 consume_identifier if the identifier is a keyword.
14742 2003-12-16 Martin Baulig <martin@ximian.com>
14744 * statement.cs (LocalInfo.Assigned): Removed this property.
14745 (LocalInfo.Flags): Removed `Assigned'.
14746 (LocalInfo.IsAssigned): New public method; takes the EmitContext
14747 and uses flow analysis.
14748 (Block.UsageWarning): Made this method private.
14749 (Block.Resolve): Call UsageWarning() if appropriate.
14751 * expression.cs (LocalVariableReference.DoResolve): Always set
14752 LocalInfo.Used here.
14754 2003-12-13 Martin Baulig <martin@ximian.com>
14756 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
14757 any value here; we're now using flow analysis to figure out
14758 whether a statement/block returns a value.
14760 2003-12-13 Martin Baulig <martin@ximian.com>
14762 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
14764 (FlowBranching.MergeFinally): Don't call
14765 `branching.CheckOutParameters()' here, this is called in
14767 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
14768 when adding the `finally' vector.
14770 2003-12-13 Martin Baulig <martin@ximian.com>
14773 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
14774 actually work and also fix #48962.
14776 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
14778 * decl.cs: Do not check System.Object for nested types,
14779 since we know it does not have any. Big bang for buck:
14782 Run 1: 8.35 seconds
14783 Run 2: 8.32 seconds
14784 corlib: 17.99 seconds
14786 Run 1: 8.17 seconds
14787 Run 2: 8.17 seconds
14788 corlib: 17.39 seconds
14790 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
14792 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
14793 time we are returning 0 members, so we save alot here.
14795 2003-12-11 Martin Baulig <martin@ximian.com>
14797 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
14798 `MergeChild()', also just take the `FlowBranching' as argument;
14799 call Merge() on it and return the result.
14800 (FlowBranching.Merge): We don't need to do anything if we just
14803 2003-12-11 Martin Baulig <martin@ximian.com>
14805 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
14806 them in an `ArrayList' to reduce memory usage. Thanks to Ben
14807 Maurer for this idea.
14809 2003-12-11 Martin Baulig <martin@ximian.com>
14811 * flowanalysis.cs (MergeResult): This class is now gone; we now
14812 use the `UsageVector' for this. The reason for this is that if a
14813 branching just has one sibling, we don't need to "merge" them at
14814 all - that's the next step to do.
14815 (FlowBranching.Merge): We now return a `UsageVector' instead of a
14818 2003-12-11 Martin Baulig <martin@ximian.com>
14820 Reworked flow analyis and made it more precise and bug-free. The
14821 most important change is that we're now using a special `Reachability'
14822 class instead of having "magic" meanings of `FlowReturns'. I'll
14823 do some more cleanups and optimizations and also add some more
14824 documentation this week.
14826 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
14827 largely reworked this class.
14828 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
14829 the new `Reachability' class instead of having "magic" values here.
14830 (FlowBranching): We're now using an instance of `Reachability'
14831 instead of having separate `Returns', `Breaks' etc. fields.
14833 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
14834 based on flow analysis; ignore the return value of block.Emit ().
14836 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
14838 * driver.cs typemanager.cs: Find the mono extensions to corlib even
14839 if they are private.
14841 2003-12-09 Martin Baulig <martin@ximian.com>
14843 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
14844 call them directly on the UsageVector.
14846 2003-12-09 Martin Baulig <martin@ximian.com>
14848 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
14849 Changed return type from `FlowReturns' to `Reachability'.
14851 2003-12-09 Martin Baulig <martin@ximian.com>
14853 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
14854 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
14855 `Reachable' fields with a single `Reachability' one.
14857 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14859 * class.cs (FindMembers): Remove foreach's.
14864 Run 1: 8.74 seconds
14865 Run 2: 8.71 seconds
14868 Run 1: 8.64 seconds
14869 Run 2: 8.58 seconds
14872 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14877 This patch does a few things:
14878 1. EmptyStatement is now a singleton, so it is never reallocated.
14879 2. All blah is EmptyStatement constructs have been changed to
14880 blah == EmptyStatement.Value, which is much faster and valid
14881 now that EmptyStatement is a singleton.
14882 3. When resolving a block, rather than allocating a new array for
14883 the non-empty statements, empty statements are replaced with
14884 EmptyStatement.Value
14885 4. Some recursive functions have been made non-recursive.
14886 Mainly the performance impact is from (3), however (1) and (2) are needed for
14887 this to work. (4) does not make a big difference in normal situations, however
14888 it makes the profile look saner.
14893 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
14894 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
14895 Total memory allocated: 56397 KB
14898 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
14899 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
14900 Total memory allocated: 55666 KB
14902 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14904 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
14905 than the hashtable in a hashtable version
14907 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
14908 we always end up concating a string. This results in a huge perf
14909 loss, because many strings have to be tracked by the GC. In this
14910 patch, we first use a hashtable that works with two keys, so that
14911 the strings do not need to be concat'ed.
14915 Run 1: 8.74 seconds
14916 Run 2: 8.71 seconds
14919 Run 1: 8.65 seconds
14920 Run 2: 8.56 seconds
14922 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14924 * Makefile: Add a new target `do-time' that does a quick and simple
14925 profile, leaving easy to parse output.
14927 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
14929 * codegen.cs (Init): Create the dynamic assembly with
14930 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
14932 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
14934 * support.cs: Make the PtrHashtable use only one
14935 instance of its comparer.
14937 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
14939 * typemanager.cs: Fix lookup of GetNamespaces.
14941 2003-11-29 Miguel de Icaza <miguel@ximian.com>
14943 * expression.cs: Removed redundant line.
14945 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
14946 ArrayLists, use for loops with bounds.
14948 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
14951 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
14952 arraylists, use for loop with bounds.
14954 The above three changes give us a 0.071 second performance
14955 improvement out of 3.294 seconds down to 3.223. On my machine
14956 the above changes reduced the memory usage by 1,387 KB during
14957 compiler bootstrap.
14959 * cs-parser.jay (QualifiedIdentifier): New class used to represent
14960 QualifiedIdentifiers. Before we created a new string through
14961 concatenation, and mostly later on, the result would be
14962 manipulated by DecomposeQI through string manipulation.
14964 This reduced the compiler memory usage for bootstrapping from
14965 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
14966 compile times in 0.05 seconds.
14968 2003-11-28 Dick Porter <dick@ximian.com>
14970 * support.cs: Do string compares with the Invariant culture.
14978 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
14979 the comparison is done with the Invariant culture.
14981 2003-11-27 Miguel de Icaza <miguel@ximian.com>
14983 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
14984 GetEnumerator method.
14986 (ProbeCollectionType): Iterate starting at the most specific type
14987 upwards looking for a GetEnumerator
14989 * expression.cs: Shift count can be up to 31 for int/uint and 63
14992 2003-11-26 Miguel de Icaza <miguel@ximian.com>
14994 * statement.cs (Block.LookupLabel): Also look for the label on the
14995 children blocks. Use a hash table to keep track of visited
14998 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
14999 we actually did transform the other operand, otherwise fall back
15000 to the common codepath that casts to long.
15002 * cs-tokenizer.cs: Use the same code pattern as the int case.
15003 Maybe I should do the parsing myself, and avoid depending on the
15004 Parse routines to get this done.
15006 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15008 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15009 which fixes bug 51347. This time test it.
15011 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15012 attributes for example can not tell the difference between these.
15013 The difference was only a syntax feature of the language.
15015 * attribute.cs: Apply attributes to delegates.
15017 * delegate.cs: Call the apply attributes method.
15019 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15021 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15022 comparing 0 vs Byte.MinValue, not the value
15024 (ImplicitConversionRequired): When reporting a conversion error,
15025 use error 31 to print out the constant error instead of the
15028 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15029 which fixes bug 51347.
15031 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15033 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15034 which fixes the -warnaserror command line option.
15036 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15038 * cfold.cs (DoNumericPromotions): During constant folding of
15039 additions on UIntConstant, special case intconstants with
15040 IntConstants like we do on the expression binary operator.
15042 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15044 * convert.cs (ImplicitReferenceConversion): We were missing a case
15045 (System.Enum are not value types or class types, so we need to
15046 classify them separatedly).
15048 * driver.cs: We do not support error 2007.
15050 2003-11-12 Jackson Harper <jackson@ximian.com>
15052 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15053 system directory. Also use the full file name so users can
15054 libraries names mscorlib-o-tron.dll in a non system dir.
15056 2003-11-10 Martin Baulig <martin@ximian.com>
15058 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15059 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15060 calling `ResolveType()' on them, directly assign their `Type'.
15062 2003-11-08 Martin Baulig <martin@ximian.com>
15064 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15065 return value and the `out parent' parameter.
15066 (TypeContainer.DefineType): Moved the CS0644 check into
15067 GetClassBases(). Don't pass the interface types to the
15068 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15069 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15071 * ecore.cs (TypeExpr.IsAttribute): New property.
15072 (TypeExpr.GetInterfaces): New method.
15074 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15075 TypeExpr instead of a Type.
15076 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15077 (Interface.DefineType): Don't pass the interface types to the
15078 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15079 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15081 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15082 instead of a `Type[]'.
15083 (TypeManager.RegisterBuilder): Likewise.
15084 (TypeManager.AddUserInterface): Likewise.
15085 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15086 `Type[]' and also return a `TypeExpr[]'.
15087 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15089 2003-11-08 Martin Baulig <martin@ximian.com>
15091 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15094 2003-11-08 Martin Baulig <martin@ximian.com>
15096 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15097 TypeManager.ResolveExpressionTypes().
15099 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15100 instead of an Expression.
15101 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15102 (TypeExpression): New public class; formerly known as `TypeExpr'.
15104 * expression.cs (ComposedCast): Derive from TypeExpr.
15106 * typemanager.cs (TypeManager.system_*_expr): These are now
15107 TypExpr's instead of Expression's.
15108 (TypeManager.ResolveExpressionTypes): New public static function;
15109 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15112 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15114 * expression.cs (New.DoResolve): Do not dereference value that
15115 might be a null return.
15117 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15118 sure that the constant value has the right type. Fixes an
15119 unreported bug, similar to 50425.
15121 * const.cs (Const.LookupConstantValue): Call
15122 ImplicitStandardConversionExists before doing a conversion to
15123 avoid havng the TypeManager.ChangeType do conversions.
15125 Reduced the number of casts used
15127 (Const.ChangeType): New routine to enable reuse of the constant
15128 type changing code from statement.
15130 * typemanager.cs (ChangeType): Move common initialization to
15131 static global variables.
15135 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15136 every value type to go through, even if it was void. Fix that.
15138 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15139 character of the define, and the is_identifier_part_character for
15140 the rest of the string.
15142 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15144 * expression.cs (UnaryMutator.EmitCode): When I updated
15145 LocalVariableReference.DoResolve, I overdid it, and dropped an
15146 optimization done on local variable references.
15148 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15150 * ecore.cs: Convert the return from Ldlen into an int.
15152 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15154 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15155 the accessibility, this is a special case for toplevel non-public
15156 classes (internal for instance).
15158 2003-10-20 Nick Drochak <ndrochak@gol.com>
15160 * ecore.cs: Fix typo and build. Needed another right paren.
15162 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15164 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15165 `internal' case regular and protected, but not allowing protected
15166 to be evaluated later. Bug 49840
15168 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15170 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15171 to kb.Nlast, and not the kb.nFirst to isolate the switch
15174 Extract the underlying type, so enumerations of long/ulong are
15175 treated like long/ulong.
15177 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15179 * expression.cs (New): Overload the meaning of RequestedType to
15180 track the possible creation of the NewDelegate type, since
15181 DoResolve is invoked more than once for new constructors on field
15184 See bugs: #48800 and #37014
15186 * cs-parser.jay (declare_local_constants): Take an arraylist
15187 instead of a single constant.
15189 (local_constant_declaration): It should take a
15190 constant_declarators, not a constant_declarator. Fixes 49487
15192 * convert.cs: Fix error report.
15194 2003-10-13 Jackson Harper <jackson@ximian.com>
15196 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15199 2003-10-09 Martin Baulig <martin@ximian.com>
15201 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15203 (MethodCore.DoDefineParameters): Removed the TypeContainer
15204 argument; use the DeclSpace which was passed to the .ctor instead.
15205 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15206 TypeContainer; we only need a DeclSpace here.
15208 2003-10-09 Martin Baulig <martin@ximian.com>
15210 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15212 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15213 EmitContext's .ctor.
15215 2003-10-09 Martin Baulig <martin@ximian.com>
15217 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15218 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15219 AsAccessible(), moved them as well.
15221 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15223 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15225 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15227 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15229 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15230 generation for >=, as spotted by Paolo, bug 48679.
15231 Patch from David Waite.
15233 * cs-tokenizer.cs: Add handling for #pragma.
15235 * cs-parser.jay: Allow for both yield and yield return in the
15236 syntax. The anti-cobolization of C# fight will go on!
15238 * class.cs (TypeBuilder.DefineType): Catch error condition here
15239 (Parent.DefineType erroring out and returning null).
15241 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15242 coping with enumerations variables, we were mistakenly processing
15243 them as a regular value type instead of built-in types. Fixes the
15246 * typemanager.cs (IsBuiltinOrEnum): New method.
15248 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15250 * cs-parser.jay: Upgrade: yield now needs the return clause.
15252 2003-09-19 Martin Baulig <martin@ximian.com>
15254 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15255 `MemberCache parent' argument. Normally, an interface doesn't
15256 have a parent type except System.Object, but we use this in gmcs
15257 for generic type parameters.
15259 2003-09-18 Martin Baulig <martin@ximian.com>
15261 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15262 on `type.IsInterface'; don't check whether the type has a parent
15263 to determine whether it's an interface.
15265 2003-09-15 Martin Baulig <martin@ximian.com>
15267 * class.cs (TypeContainer.DefineType): Added an error flag to
15268 avoid reporting duplicate CS0146's ("class definition is
15271 * driver.cs (Driver.MainDriver): Abort if
15272 RootContext.ResolveTree() reported any errors.
15274 2003-09-07 Martin Baulig <martin@ximian.com>
15276 * report.cs (Error, Warning): Added overloaded versions which take
15277 a `params object[] args' and call String.Format().
15279 2003-09-07 Martin Baulig <martin@ximian.com>
15281 * decl.cs (DeclSpace..ctor): Don't call
15282 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15283 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15284 (DeclSpace.RecordDecl): New method.
15286 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15288 2003-09-02 Ravi Pratap <ravi@ximian.com>
15290 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15291 value attributes to be applied to ParameterBuilders.
15293 * class.cs (MethodCore.LabelParameters): Make static and more
15294 generic so that it can be used from other places - like interface
15295 methods, for instance.
15297 * interface.cs (Interface.Emit): Call LabelParameters before
15298 emitting attributes on the InterfaceMethod.
15300 2003-08-26 Martin Baulig <martin@ximian.com>
15302 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15303 resolving aliases; fixes #47927.
15305 2003-08-26 Martin Baulig <martin@ximian.com>
15307 * statement.cs (Using.DoResolve): This is internally emitting a
15308 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15309 do not always return. Fixes #47681.
15311 2003-08-26 Martin Baulig <martin@ximian.com>
15313 * decl.cs (MemberCore): Moved WarningNotHiding(),
15314 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15316 (AdditionResult): Make this nested in DeclSpace.
15317 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15318 argument; call NamespaceEntry.Define() unless we're nested in a
15321 * namespace.cs (Namespace.DefineName): New public function. This
15322 is called from DeclSpace's .ctor to add
15323 (Namespace.Lookup): Include DeclSpaces in the lookup.
15325 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15327 * const.cs (Const): Derive from MemberBase, not MemberCore.
15329 2003-08-25 Martin Baulig <martin@ximian.com>
15331 * convert.cs (Convert.ExplicitReferenceConversion): When
15332 converting from an interface type to a class, unbox if the target
15333 type is a struct type. Fixes #47822.
15335 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15337 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15340 2003-08-22 Martin Baulig <martin@ximian.com>
15342 * class.cs (TypeManager.DefineType): When defining a nested type,
15343 call DefineType() on our parent; fixes #47801.
15345 2003-08-22 Martin Baulig <martin@ximian.com>
15347 * class.cs (MethodData.Define): While checking if a method is an
15348 interface implementation, improve the test a bit more to fix #47654.
15350 2003-08-22 Martin Baulig <martin@ximian.com>
15352 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15353 correctly; fixes #47722.
15355 2003-08-22 Martin Baulig <martin@ximian.com>
15357 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15358 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15360 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15362 2003-08-22 Martin Baulig <martin@ximian.com>
15364 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15365 can only be assigned in static constructors. Fixes #47161.
15367 2003-08-22 Martin Baulig <martin@ximian.com>
15369 Rewrote and improved the flow analysis code.
15371 * flowbranching.cs (FlowBranching): Make this class abstract.
15372 (FlowBranching.CreateBranching): New static function to create a
15373 new flow branching.
15374 (FlowBranchingBlock, FlowBranchingException): New classes.
15375 (FlowBranching.UsageVector.Type): New public readonly field.
15376 (FlowBranching.UsageVector.Breaks): Removed the setter.
15377 (FlowBranching.UsageVector.Returns): Removed the setter.
15378 (FlowBranching.UsageVector): Added Break(), Return(),
15379 NeverReachable() and Throw() methods to modify the reachability.
15380 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15381 done by FlowBranching.Merge().
15382 (FlowBranching.UsageVector.MergeChild): New method; merges the
15383 merge result into the current vector.
15384 (FlowBranching.Merge): New abstract method to merge a branching.
15386 2003-08-12 Martin Baulig <martin@ximian.com>
15388 * expression.cs (Indirection.CacheTemporaries): Create the
15389 LocalTemporary with the pointer type, not its element type.
15391 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15393 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15394 token was a keyword or not.
15396 Add `error' options where an IDENTIFIER was expected; Provide
15397 CheckToken and CheckIdentifierToken convenience error reporting
15400 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15402 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15403 NameSpaceEntry NameSpaceEntry.
15405 (LookupInterfaceOrClass): Avoid creating a full qualified name
15406 from namespace and name: avoid doing lookups when we know the
15407 namespace is non-existant. Use new Tree.LookupByNamespace which
15408 looks up DeclSpaces based on their namespace, name pair.
15410 * driver.cs: Provide a new `parser verbose' to display the
15411 exception thrown during parsing. This is turned off by default
15412 now, so the output of a failure from mcs is more graceful.
15414 * namespace.cs: Track all the namespaces defined in a hashtable
15417 (IsNamespace): New method
15419 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15421 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15422 we know that we need to concatenate (full typename can never be
15427 * statement.cs: Use a bitfield; Do not initialize to null things
15428 which are done by the constructor by default.
15430 * cs-parser.jay: bug fix, parameter was 4, not 3.
15432 * expression.cs: Just use the property;
15434 * statement.cs: No need for GetVariableInfo method.
15436 2003-08-08 Martin Baulig <martin@ximian.com>
15438 * flowanalysis.cs (FlowReturns): This is now nested in the
15439 `FlowBranching' class.
15440 (MyBitVector): Moved this here from statement.cs.
15441 (FlowBranching.SiblingType): New enum type.
15442 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15444 2003-08-07 Martin Baulig <martin@ximian.com>
15446 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15447 `FlowBranching' class and called `BranchingType'.
15449 2003-08-07 Martin Baulig <martin@ximian.com>
15451 * flowanalysis.cs: Moved all the control flow analysis code into
15454 2003-08-07 Martin Baulig <martin@ximian.com>
15456 * assign.cs (Assign.DoResolve): `target' must either be an
15457 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15460 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15462 * expression.cs (BinaryMethod): This kind of expression is created by the
15463 Binary class if it determines that the operator has to be handled
15466 (BinaryDelegate): This kind of expression is created if we are
15467 dealing with a + or - operator on delegates.
15469 (Binary): remove method, argumetns, and DelegateOperator: when
15470 dealing with methods,
15472 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15474 * statement.cs (Block): use bitfields for the three extra booleans
15475 we had in use. Remove unused topblock parameter.
15477 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15479 * assign.cs: Drop extra unneeded tests.
15481 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15483 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15485 * statement.cs (Foreach): Use VariableStorage instead of
15488 * codegen.cs (VariableStorage): New class used by clients that
15489 require a variable stored: locals or fields for variables that
15490 need to live across yield.
15492 Maybe provide a convenience api for EmitThis+EmitLoad?
15494 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15497 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15499 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15500 RemapParameterLValue): New methods that are used to turn a
15501 precomputed FieldInfo into an expression like this:
15505 The idea is to use this instead of making LocalVariableReference
15506 have more than one meaning.
15508 * cs-parser.jay: Add error production to BASE.
15510 * ecore.cs: Deal with TypeManager.GetField returning null, which
15511 is now a valid return value.
15513 (FieldExprNoAddress): New expression for Fields whose address can
15516 * expression.cs (LocalVariableReference): During the resolve
15517 phases, create new expressions if we are in a remapping context.
15518 Remove code that dealt with remapping here.
15520 (ParameterReference): same.
15522 (ProxyInstance): New expression, like the `This' expression, but
15523 it is born fully resolved. We know what we are doing, so remove
15524 the errors that are targeted to user-provided uses of `this'.
15526 * statement.cs (Foreach): our variable is now stored as an
15527 Expression; During resolution, follow the protocol, dont just
15528 assume it will return this.
15530 2003-08-06 Martin Baulig <martin@ximian.com>
15532 * support.cs (SeekableStreamReader.cs): New public class.
15534 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15535 SeekableStreamReader instead of the normal StreamReader.
15537 2003-08-04 Martin Baulig <martin@ximian.com>
15539 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15540 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15541 deambiguate casts and delegate invocations.
15542 (parenthesized_expression): Use the new tokens to ensure this is
15543 not a cast of method invocation.
15545 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15546 when reading a `)' and Deambiguate_CloseParens () was previously
15549 * expression.cs (ParenthesizedExpression): New class. This is
15550 just used for the CS0075 test.
15551 (Binary.DoResolve): Check for CS0075.
15553 2003-07-29 Ravi Pratap <ravi@ximian.com>
15555 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15556 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15557 reference comparison.
15559 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15560 examine the ReturnType for equality - this is necessary in the
15561 cases of implicit and explicit operators whose signature also
15562 includes the return type.
15564 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15566 * namespace.cs: Cache the result of the namespace computation,
15567 instead of computing it every time.
15569 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15571 * decl.cs: Use a global arraylist that we reuse over invocations
15572 to avoid excesive memory consumption. Reduces memory usage on an
15573 mcs compile by one meg (45 average).
15575 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15576 private, work around that.
15578 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15580 * literal.cs (IntLiteral): Define Zero and One static literals.
15582 * cs-parser.jay (integer_literal): use static literals to reduce
15583 memory usage for the most used literals (0, 1 and -1). 211kb
15584 reduced in memory usage.
15586 Replace all calls to `new ArrayList' with `new
15587 ArrayList(4)' which is a good average number for most allocations,
15588 and also requires only 16 bytes of memory for its buffer by
15591 This reduced MCS memory usage in seven megabytes for the RSS after
15594 2003-07-28 Ravi Pratap <ravi@ximian.com>
15596 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15597 handle params methods the correct way by forming only one
15598 applicable set with params and normal methods in them. Earlier we
15599 were looking at params methods only if we found no normal methods
15600 which was not the correct thing to do.
15602 (Invocation.BetterFunction): Take separate arguments indicating
15603 when candidate and the best method are params methods in their
15606 This fixes bugs #43367 and #46199.
15608 * attribute.cs: Documentation updates.
15610 (CheckAttribute): Rename to CheckAttributeTarget.
15611 (GetValidPlaces): Rename to GetValidTargets.
15613 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15614 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15618 2003-07-28 Martin Baulig <martin@ximian.com>
15620 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15621 name when looking up the base class of a nested class. Fixes #46977.
15623 2003-07-26 Martin Baulig <martin@ximian.com>
15625 * expression.cs (Indexers.Indexer): New nested struct; contains
15626 getter, setter and the indexer's type.
15627 (Indexers.Properties): This is now an ArrayList of
15628 Indexers.Indexer's.
15629 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15630 indexer doesn't have any getters.
15632 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15633 for embedded property and indexer assignments.
15635 2003-07-26 Martin Baulig <martin@ximian.com>
15637 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15638 preprocessor directive is not the first non-whitespace character
15641 2003-07-26 Martin Baulig <martin@ximian.com>
15643 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15644 namespace parsing, follow the spec more closely.
15646 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15647 NamespaceEntry.Lookup().
15649 2003-07-25 Martin Baulig <martin@ximian.com>
15651 * MethodCore.cs (OverridesSomething): New public field; it's set
15652 from TypeContainer.DefineMembers if this method overrides
15653 something (which doesn't need to be a method). Fix #39462.
15655 2003-07-25 Ravi Pratap <ravi@ximian.com>
15657 * typemanager.cs (GetMembers): Ensure that the list of members is
15658 reversed. This keeps things in sync.
15660 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15661 find an AttributeUsage attribute.
15663 * expression.cs (Invocation.OverloadResolve): Perform the check
15664 which disallows Invoke to be directly called on a Delegate.
15666 (Error_InvokeOnDelegate): Report error cs1533.
15668 2003-07-25 Martin Baulig <martin@ximian.com>
15670 * expression.cs (Indexers.GetIndexersForType): Only look in the
15671 interface hierarchy if the requested type is already an
15672 interface. Fixes #46788 while keeping #46502 fixed.
15674 2003-07-25 Martin Baulig <martin@ximian.com>
15676 * class.cs (TypeContainer.DefineMembers): Check whether all
15677 readonly fields have been assigned and report warning CS0649 if
15680 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15683 2003-07-24 Ravi Pratap <ravi@ximian.com>
15685 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15686 returned from GetMethods to make things consistent with the
15687 assumptions MCS makes about ordering of methods.
15689 This should comprehensively fix bug #45127 and it does :-)
15691 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15692 ordering is actually reverse.
15694 * Clean up some debug messages I left lying around.
15696 * interface.cs (Populate*): Get rid of code which emits attributes
15697 since the stage in which we emit attributes is the 'Emit' stage,
15698 not the define stage.
15700 (Emit): Move attribute emission for interface members here.
15702 2003-07-22 Ravi Pratap <ravi@ximian.com>
15704 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15705 closely: we eliminate methods in base types when we have an
15706 applicable method in a top-level type.
15708 Please see section 14.5.5.1 for an exact description of what goes
15711 This fixes bug #45127 and a host of other related to corlib compilation.
15713 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15714 array is the method corresponding to the top-level type (this is
15715 because of the changes made to icall.c) so we change this
15718 (MethodGroupExpr.Name): This too.
15720 * typemanager.cs (GetElementType): New method which does the right
15721 thing when compiling corlib.
15723 * everywhere: Make use of the above in the relevant places.
15725 2003-07-22 Martin Baulig <martin@ximian.com>
15727 * cs-parser.jay (invocation_expression): Moved
15728 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15729 `cast_expression', but create a InvocationOrCast which later
15730 resolves to either an Invocation or a Cast.
15732 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15733 method; call this before EmitStatement() to make sure that this
15734 expression can be used as a statement.
15736 * expression.cs (InvocationOrCast): New class; resolves to either
15737 an Invocation or a Cast.
15739 * statement.cs (StatementExpression): Call ResolveStatement() on
15740 the ExpressionStatement before emitting it.
15742 2003-07-21 Martin Baulig <martin@ximian.com>
15744 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15745 `ref' and `out' attributes match; fixes #46220.
15746 (MemberAccess.ResolveMemberAccess): You can't reference a type
15747 through an expression; fixes #33180.
15748 (Indexers.GetIndexersForType): Don't return the indexers from
15749 interfaces the class implements; fixes #46502.
15751 2003-07-21 Martin Baulig <martin@ximian.com>
15753 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15754 CS0661 checks; fixes bug #30442.
15756 2003-07-21 Martin Baulig <martin@ximian.com>
15758 * decl.cs (AdditionResult): Added `Error'.
15760 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15762 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
15763 makes cs0031.cs actually work.
15765 2003-07-20 Martin Baulig <martin@ximian.com>
15767 * namespace.cs: Fixed that bug which caused a crash when compiling
15768 the debugger's GUI.
15770 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15772 * typemanager.cs (LookupTypeReflection): Never expose types which
15773 are NotPublic, NestedPrivate, NestedAssembly, or
15774 NestedFamANDAssem. We used to return these, and later do a check
15775 that would report a meaningful error, but the problem is that we
15776 would not get the real match, if there was a name override.
15778 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15780 * namespace.cs (Namespace, Name): Do not compute the namespace
15781 name dynamically, compute it in the constructor. This reduced
15782 memory usage by 1697 KB.
15784 * driver.cs: Use --pause to pause at the end.
15786 2003-07-17 Peter Williams <peter@newton.cx>
15788 * Makefile: Change the name of the test target so that it doesn't
15789 conflict with the recursive test target.
15791 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15793 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15794 AddressOf): Do not use EmitThis, that was wrong, use the actual
15797 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15799 * class.cs (MethodData.Define): While checking if a method is an
15800 interface implementation, improve the test: If we are not public
15801 (use new test here: use the computed MethodAttributes directly,
15802 instead of the parsed modifier flags) check if the `implementing'
15803 method comes from an interface or not.
15805 * pending.cs (VerifyPendingMethods): Slightly better error
15808 * makefile: add test target that does the mcs bootstrap.
15810 2003-07-16 Ravi Pratap <ravi@ximian.com>
15812 * interface.cs (Define): Do nothing here since there are no
15813 members to populate etc. Move the attribute emission out of here
15814 since this was just totally the wrong place to put it. Attribute
15815 application happens during the 'Emit' phase, not in the 'Define'
15818 (Emit): Add this method and move the attribute emission here
15820 * rootcontext.cs (EmitCode): Call the Emit method on interface
15823 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15825 * expression.cs (OverloadResolve): Report error only if Location
15826 is not 'Null' which means that there was a probe going on.
15828 2003-07-14 Martin Baulig <martin@ximian.com>
15830 * expression.cs (ConditionalLogicalOperator): New public class to
15831 implement user defined conditional logical operators.
15832 This is section 14.11.2 in the spec and bug #40505.
15834 2003-07-14 Martin Baulig <martin@ximian.com>
15836 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15838 2003-07-14 Martin Baulig <martin@ximian.com>
15840 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15842 * ecore.cs (IVariable.VerifyFixed): New interface method.
15844 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15845 operator, check whether the variable is actually fixed. Fixes bug
15846 #36055. Set a variable definitely assigned when taking its
15847 address as required by the spec.
15849 * statement.cs (LocalInfo.IsFixed): New field.
15850 (LocalInfo.MakePinned): Set `IsFixed' to true.
15852 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15854 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15855 for .ctors, ensure that we only ask for members declared in the
15856 attribute type (BindingFlags.DeclaredOnly).
15860 * expression.cs (Error_WrongNumArguments): Report error 1501
15861 correctly the way CSC does.
15863 2003-07-13 Martin Baulig <martin@ximian.com>
15865 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15866 lookup on the fully qualified name, to make things like "X.X" work
15867 where "X.X" is a fully qualified type name, but we also have a
15868 namespace "X" in the using list. Fixes #41975.
15870 2003-07-13 Martin Baulig <martin@ximian.com>
15872 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15873 function. If we're a CompoundAssign, we need to create an embedded
15874 CompoundAssign, not an embedded Assign.
15875 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15878 2003-07-13 Martin Baulig <martin@ximian.com>
15880 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15881 work to fix bug #46088.
15883 2003-07-13 Ravi Pratap <ravi@ximian.com>
15885 * class.cs (Operator.Emit): Do not emit attributes here - it is
15886 taken care of by the Method class that we delegate too. This takes
15887 care of bug #45876.
15889 2003-07-10 Martin Baulig <martin@ximian.com>
15891 * expression.cs (TypeOfVoid): New class.
15892 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15894 2003-07-10 Martin Baulig <martin@ximian.com>
15896 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15899 2003-07-10 Martin Baulig <martin@ximian.com>
15901 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15902 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15904 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15906 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15908 2003-07-10 Martin Baulig <martin@ximian.com>
15910 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15911 of decimal. Fixes #42850.
15913 NOTE: I also fixed the created byte blob, but this doesn't work on
15914 the MS runtime and csc never produces any byte blobs for decimal
15917 2003-07-10 Martin Baulig <martin@ximian.com>
15919 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15920 structs; fixes #32068.
15921 (Block.AddChildVariableNames): Fixed #44302.
15923 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15925 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15927 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15929 * attribute.cs: And this test is onger needed.
15931 2003-07-08 Martin Baulig <martin@ximian.com>
15933 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15934 inaccessible types. Fixes #36313.
15936 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15938 * namespace.cs (NamespaceEntry): Create implicit entries for all
15939 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15940 implicit entries for N1.N2 and N1.
15942 2003-07-08 Martin Baulig <martin@ximian.com>
15944 Rewrote the handling of namespaces to fix a lot of the issues
15945 wrt. `using' aliases etc.
15947 * namespace.cs (Namespace): Splitted this class into a
15948 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15950 * typemanager.cs (TypeManager.IsNamespace): Removed.
15951 (TypeManager.ComputeNamespaces): Only compute namespaces from
15952 loaded assemblies here, not the namespaces from the assembly we're
15953 currently compiling.
15955 2003-07-08 Martin Baulig <martin@ximian.com>
15957 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15959 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15961 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15964 I thought about the memory savings here, but LookupTypeReflection
15965 is used under already very constrained scenarios. Compiling
15966 corlib or mcs only exposes one hit, so it would not really reduce
15967 any memory consumption.
15969 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15971 * typemanager.cs: fixes bug #45889 by only adding public types from
15972 other assemblies to the list of known types.
15974 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15976 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15977 on the type we resolved.
15979 2003-07-05 Martin Baulig <martin@ximian.com>
15981 * pending.cs (PendingImplementation.ParentImplements): Don't
15982 create the proxy if the parent is abstract.
15984 * class.cs (TypeContainer.DefineIndexers): Process explicit
15985 interface implementations first. Fixes #37714.
15987 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15989 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15990 defined recursively; but since we modify the input parameters
15991 (left is set to `this' temporarily), we reset this value if the
15992 left_is_explicit is false, which gives the original semantics to
15995 * literal.cs (NullPointer): new class used to represent a null
15996 literal in a pointer context.
15998 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15999 type is a pointer, use a NullPointer object instead of a
16000 NullLiteral. Closes 43687
16002 (ExplicitConversion): Convert pointer values using
16003 the conv opcode to the proper type.
16005 * ecore.cs (New): change ValueTypeVariable property into a method,
16006 that returns whether the valuetype is suitable for being used.
16008 * expression.cs (Binary.DoNumericPromotions): Only return if we
16009 the int constant was a valid uint, and we can return both left and
16010 right as uints. If not, we continue processing, to trigger the
16011 type conversion. This fixes 39018.
16013 * statement.cs (Block.EmitMeta): During constant resolution, set
16014 the CurrentBlock property on the emitcontext, so that we resolve
16015 constants propertly.
16017 2003-07-02 Martin Baulig <martin@ximian.com>
16019 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16020 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16022 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16023 than emitting it here.
16025 * statement.cs: Fixed some more flow analysis bugs.
16027 2003-07-02 Martin Baulig <martin@ximian.com>
16029 * class.cs (MethodData.Define): When implementing interface
16030 methods, set Final unless we're Virtual.
16032 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16033 check work for interface methods.
16035 2003-07-01 Martin Baulig <martin@ximian.com>
16037 * ecore.cs (EmitContext.This): Replaced this property with a
16038 GetThis() method which takes a Location argument. This ensures
16039 that we get the correct error location for a CS0188.
16041 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16043 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16044 ImplicitStandardConversion.
16046 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16048 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16050 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16053 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16055 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16058 (MethodData.Define): Turn off initlocals for unsafe methods.
16060 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16062 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16063 complete; Fixes #37521.
16065 * delegate.cs: Use Modifiers.TypeAttr to compute the
16066 TypeAttributes, instead of rolling our own. This makes the flags
16067 correct for the delegates.
16069 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16071 * class.cs (Constructor.Define): Set the private flag for static
16072 constructors as well.
16074 * cs-parser.jay (statement_expression): Set the return value to
16075 null, to avoid a crash when we catch an error.
16077 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16079 * cs-parser.jay: Applied patch from Jackson that adds support for
16080 extern and unsafe modifiers to destructor declarations.
16082 * expression.cs: Report error 21 if the user is trying to index a
16085 * driver.cs: Add an error message, suggested by the bug report.
16087 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16088 if we do not have a ": this ()" constructor initializer. Fixes 45149
16090 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16092 * namespace.cs: Add some information to reduce FAQs.
16094 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16096 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16097 underlying enumeration types. Fixes #43915.
16099 * expression.cs: Treat ushort/short as legal values to be used in
16100 bitwise operations.
16102 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16104 * delegate.cs: transfer custom attributes for paramenters from
16105 the delegate declaration to Invoke and BeginInvoke.
16107 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16109 * attribute.cs: handle custom marshalers and emit marshal info
16112 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16114 * makefile.gnu: Added anonymous.cs to the compiler sources.
16116 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16118 * iterators.cs: Change the name of the proxy class to include two
16121 * cs-parser.jay: Update grammar to include anonymous methods.
16123 * anonymous.cs: new file.
16125 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16127 * class.cs (Field.Define): Add missing test for pointers and
16130 2003-05-27 Ravi Pratap <ravi@ximian.com>
16132 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16133 we use the stobj opcode.
16135 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16136 since it wasn't the correct fix.
16138 It still is puzzling that we are required to use stobj for IntPtr
16139 which seems to be a ValueType.
16141 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16143 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16144 during regular simple name resolution. Now, the trick is that
16145 instead of returning for processing the simplename, we do a
16146 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16147 contextual lookup type). If a match is found, return that, if
16148 not, return for further composition.
16150 This fixes long-standing 30485.
16152 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16153 using the address to initialize an object, do an Stobj instead of
16154 using the regular Stelem.
16156 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16157 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16158 Because if we are a BaseIndexerAccess that value will be true.
16161 * statement.cs (GotoCase.Resolve): Return after reporting an
16162 error, do not attempt to continue.
16164 * expression.cs (PointerArithmetic.Emit): If our operand is a
16165 long, convert our constants to match the operand before
16166 multiplying. Convert to I type before adding. Fixes 43670.
16168 2003-05-14 Ravi Pratap <ravi@ximian.com>
16170 * enum.cs (ImplicitConversionExists) : Rename to
16171 ImplicitEnumConversionExists to remove ambiguity.
16173 * ecore.cs (NullCast): New type of cast expression class which
16174 basically is very similar to EmptyCast with the difference being
16175 it still is a constant since it is used only to cast a null to
16177 (eg. (string) null)
16179 * convert.cs (ImplicitReferenceConversion): When casting a null
16180 literal, we return a NullCast.
16182 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16183 should be around anymore.
16185 The renaming (reported was slightly wrong). Corrections:
16187 ConvertImplicitStandard -> ImplicitConversionStandard
16188 ConvertExplicitStandard -> ExplicitConversionStandard
16190 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16191 before passing them in !
16193 * convert.cs (ImplicitConversionStandard): When comparing for
16194 equal expr and target types, ensure that expr is not a
16197 In general, we must not be checking (expr_type ==
16198 target_type) in the top level conversion methods
16199 (ImplicitConversion, ExplicitConversion etc). This checking is
16200 done in the methods that they delegate to.
16202 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16204 * convert.cs: Move Error_CannotConvertType,
16205 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16206 ImplicitNumericConversion, ImplicitConversionExists,
16207 ImplicitUserConversionExists, StandardConversionExists,
16208 FindMostEncompassedType, FindMostSpecificSource,
16209 FindMostSpecificTarget, ImplicitUserConversion,
16210 ExplicitUserConversion, GetConversionOperators,
16211 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16212 TryImplicitIntConversion, Error_CannotConvertImplicit,
16213 ConvertImplicitRequired, ConvertNumericExplicit,
16214 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16215 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16218 Perform the following renames:
16220 StandardConversionExists -> ImplicitStandardConversionExists
16221 ConvertImplicit -> ImplicitConversion
16222 ConvertImplicitStandard -> ImplicitStandardConversion
16223 TryImplicitIntConversion -> ImplicitIntConversion
16224 ConvertImplicitRequired -> ImplicitConversionRequired
16225 ConvertNumericExplicit -> ExplicitNumericConversion
16226 ConvertReferenceExplicit -> ExplicitReferenceConversion
16227 ConvertExplicit -> ExplicitConversion
16228 ConvertExplicitStandard -> ExplicitStandardConversion
16230 2003-05-19 Martin Baulig <martin@ximian.com>
16232 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16233 (TypeInfo): Added support for structs having structs as fields.
16235 * ecore.cs (FieldExpr): Implement IVariable.
16236 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16237 VariableInfo for the field.
16239 2003-05-18 Martin Baulig <martin@ximian.com>
16241 * expression.cs (This.DoResolve): Report a CS0027 if we're
16242 emitting a field initializer.
16244 2003-05-18 Martin Baulig <martin@ximian.com>
16246 * expression.cs (This.ResolveBase): New public function.
16247 (This.DoResolve): Check for CS0188.
16249 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16252 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16253 `instance_expression' to null if we don't have any non-static
16256 2003-05-18 Martin Baulig <martin@ximian.com>
16258 Reworked the way how local variables and parameters are handled by
16259 the flow analysis code.
16261 * statement.cs (TypeInfo, VariableMap): New public classes.
16262 (VariableInfo): New public class. This is now responsible for
16263 checking whether a variable has been assigned. It is used for
16264 parameters and local variables.
16265 (Block.EmitMeta): Take the InternalParameters as argument; compute
16266 the layout of the flow vectors here.
16267 (Block.LocalMap, Block.ParameterMap): New public properties.
16268 (FlowBranching): The .ctor doesn't get the InternalParameters
16269 anymore since Block.EmitMeta() now computes the layout of the flow
16271 (MyStructInfo): This class is now known as `StructInfo' and nested
16272 in `TypeInfo'; we don't access this directly anymore.
16274 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16275 property and removed IsAssigned(), IsFieldAssigned(),
16276 SetAssigned() and SetFieldAssigned(); we now call them on the
16277 VariableInfo so we don't need to duplicate this code everywhere.
16279 * expression.cs (ParameterReference): Added `Block block' argument
16281 (LocalVariableReference, ParameterReference, This): The new
16282 VariableInfo class is now responsible for all the definite
16285 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16286 IsParameterAssigned, SetParameterAssigned): Removed.
16288 2003-05-18 Martin Baulig <martin@ximian.com>
16290 * typemanager.cs (InitCoreTypes): Try calling
16291 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16292 the 3-args-version. Corlib now also needs our `void_type'.
16293 (GetMethod): Added overloaded version which takes an optional
16294 `bool report_errors' to allow lookups of optional methods.
16296 2003-05-12 Martin Baulig <martin@ximian.com>
16298 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16299 only used for locals and not for parameters.
16301 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16303 * support.cs (InternalParameters.ParameterType): Return the
16304 ExternalType of the parameter.
16306 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16309 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16311 * class.cs (MethodData.Define): Do not set the `newslot' on
16312 interface members, if they are also flagged as "override".
16314 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16315 better code for ++i and i++. This only works for static fields
16316 and local variables.
16318 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16319 want to pull the DeclSpace out of the builder_to_declspace instead
16320 of the TypeBuilder (like in TypeContainer.FindMembers).
16322 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16323 instead of LookupTypeContainer. Fixes the crash on .NET for
16324 looking up interface members.
16326 * const.cs: Create our own emit context during the Definition
16327 stage, so that constants are evaluated in the proper context, when
16328 a recursive definition happens.
16330 2003-05-11 Martin Baulig <martin@ximian.com>
16332 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16333 new block for a switch section.
16334 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16335 the adding/lookup in the switch block. Fixes #39828.
16337 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16339 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16340 functionality: I needed to convert the data after I had performed
16341 the add/sub operation into the operands type size.
16343 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16344 pass the type for the box operation, otherwise the resulting
16345 object would have been of type object.
16347 (BoxedCast): Add constructor to specify the type to box as.
16349 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16351 * iterators.cs: I was reusing the `count' variable inadvertently,
16352 take steps to not allow this to happen.
16354 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16356 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16357 by creating an array at the point where the params starts and
16358 putting all those arguments there, then adjusting the size of the
16361 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16363 * expression.cs (New.AddressOf): Implement interface
16364 IMemoryLocation. This is used when the `new' operator is used in
16365 the context of an invocation to a method on a value type.
16367 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16370 * namespace.cs: Also check the using aliases here.
16372 * driver.cs: Move the test for using validity after the types have
16373 been entered, so we do a single pass that also includes the using
16376 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16377 in the regular case. CreateSiblingForFinally is doing extra
16380 * attribute.cs (GetAttributeArgumentExpression): Store the result
16381 on an out value, and use the return value to indicate failure
16382 instead of using null (which is a valid return for Constant.GetValue).
16384 * statement.cs: Perform the analysis flow for the increment
16385 portion after the statement, because this will be the real flow of
16386 execution. Fixes #42385
16388 * codegen.cs (EmitContext.EmitArgument,
16389 EmitContext.EmitStoreArgument): New helper functions when the
16390 RemapToProxy flag is set.
16392 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16395 Add support for remapping parameters.
16397 * iterators.cs: Propagate parameter values; Store parameter
16398 values in the proxy classes.
16400 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16402 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16403 need a proxy reference; I do not know what I was thinking
16405 * cs-parser.jay (constructor_initializer): catch another error,
16406 and display nice message.
16408 (field_declaration): catch void field declaration
16409 to flag a better error.
16411 * class.cs (MemberBase.CheckBase): Report an error instead of a
16412 warning if a new protected member is declared in a struct.
16413 (Field.Define): catch the error of readonly/volatile.
16415 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16417 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16418 volatile variable is taken
16420 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16422 * statement.cs (Fixed.Resolve): Report an error if we are not in
16425 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16427 * typemanager.cs: reuse the code that handles type clashes for
16428 delegates and enumerations.
16430 * class.cs (Report28): Always report.
16432 * expression.cs (EncodeAsAttribute): Allow nulls here.
16434 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16436 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16437 the functionality for testing whether an expression is valid for
16438 an attribute here. Also handle the case of arrays of elements
16441 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16442 encoding a linear array into an array of objects that are suitable
16443 to be passed to an CustomAttributeBuilder.
16445 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16447 * ecore.cs: (FieldExpr): Handle field remapping here.
16449 * iteratators.cs: Pass the instance variable (if the method is an
16450 instance method) to the constructors, so we can access the field
16451 variables on the class.
16453 TODO: Test this with structs. I think the THIS variable on
16454 structs might have to be a pointer, and not a refenrece
16456 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16458 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16459 local variables to fields in a proxy class.
16461 * iterators.cs (PopulateProxy): Rename our internal fields to
16463 Create a <THIS> field if we are an instance method, so we can
16464 reference our parent container variables.
16465 (MapVariable): Called back from the EmitContext code to enter a
16466 new variable to field mapping into the proxy class (we just create
16470 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16471 for using the remapped locals to fields.
16473 I placed the code here, because that gives the same semantics to
16474 local variables, and only changes the Emit code.
16476 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16477 statements inside iterators.
16478 (VariableInfo): Add a FieldBuilder for the cases when we are
16479 remapping local variables to fields in a proxy class
16481 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16482 current_block != null.
16484 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16485 not cope with strings, as it has been moved to the
16486 TableSwitchEmit. Fixed bug in switch generation.
16488 * expression.cs (New.DoResolve): Provide more context for the user
16489 when reporting an error.
16491 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16494 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16495 check the permissions for it. Note than in a type-resolution
16496 context the check was already present in DeclSpace.ResolveType,
16497 but was missing from the MemberAccess.
16499 (ArrayCreation.CheckIndices): warn if the user has
16500 more nested levels of expressions, but there are no more
16501 dimensions specified. Avoids crash on bug 41906.
16503 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16505 * statement.cs (Block): replace Implicit bool, for a generic
16507 New flag: `Unchecked'. This is used during the EmitMeta phase
16508 (which is out-of-line with the regular Resolve/Emit process for a
16509 statement, as this is done ahead of time, but still gets a chance
16510 to call constant resolve).
16512 (Block.Flags): new enum for adding a new flag.
16514 (Block.EmitMeta): track the state of unchecked.
16516 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16517 to enable constant resolution to work there as well.
16519 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16521 * typemanager.cs (ienumerable_type): Also look up
16522 System.Collections.IEnumerable.
16524 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16526 TODO: Test more than one conditional per method.
16528 * class.cs (Indexer.Define): Report the location where the user is
16529 referencing the unsupported feature.
16531 (MethodData): Overload the use of `conditionals' to
16532 minimize the creation of needless ArrayLists. This saves roughly
16533 212kb on my machine.
16535 (Method): Implement the new IIteratorContainer interface.
16536 (Method.SetYields): Implement the method by setting the ModFlags
16537 to contain METHOD_YIELDS.
16539 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16540 which just got set to null.
16542 * iterators.cs: New file.
16544 (Yield, YieldBreak): New statements.
16546 * statement.cs (Return.Resolve): Flag an error if we are used in
16547 an iterator method.
16549 * codegen.cs (InIterator): New flag set if the code is being
16550 compiled in an iterator method.
16552 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16553 internal modifier, and we just use it to avoid adding extra
16554 fields, as this is seldom used.
16556 * cs-parser.jay: Add yield_statement (yield and yield break).
16558 * driver.cs: New flag -v2 to turn on version 2 features.
16560 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16561 hashtable when v2 is enabled.
16563 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16565 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16566 there is already a namespace defined with this name.
16568 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16569 people upgraded their corlibs.
16571 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16572 always use fully qualified types, no need to use the compiler
16575 (TypeManager.IsNamespace): Use binarysearch.
16577 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16578 AddDelegate): I did not quite use the new IsValid API properly: I
16579 have to pass the short-name and the fullname. I was passing only
16580 the basename instead of the fullname sometimes.
16582 (TypeContainer.DefineType): call NamespaceClash.
16584 * interface.cs (Interface.DefineType): use NamespaceClash before
16587 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16590 * enum.cs: (Enum.DefineType): use NamespaceClash before
16593 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16594 speed increase. First, use the negative_hits cache when we get a
16595 negative. Second, add the type with its full original name
16596 instead of the new . and + encoded name (reflection uses + to
16597 separate type from a nested type). Use LookupTypeReflection
16598 directly which bypasses the type->name hashtable (that we already
16599 know does not contain the type.
16601 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16602 location/container type.
16604 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16606 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16608 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16610 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16611 method is being referenced in the method group from a static
16612 context, and report error 120 if so.
16614 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16617 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16618 is created, we create the A namespace).
16620 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16623 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16625 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16626 invocation to ModuleBuilder.GetType with the same values will
16627 return a new type instance, so we need to cache its return
16630 * expression.cs (Binary.ResolveOperator): Only allow the compare
16631 operators on enums if they are of the same type.
16633 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16634 types of ValueType on their own case. Before we were giving them
16635 the same treatment as objects.
16637 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16638 fullname. Short name is used to compare against container name.
16639 Fullname is used to check against defined namespace names.
16641 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16642 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16644 (Method.CheckBase): Call parent.
16645 (MemberBase.CheckBase): Check for protected members on sealed
16647 (PropertyBase.CheckBase): Call parent.
16648 (Field.Define): Call parent.
16650 * report.cs: Negative error codes are now mapped to 8000 - code,
16651 so that the display is render more nicely.
16653 * typemanager.cs: Do not use try/catch, instead report a regular
16656 (GetPointerType, GetReferenceType): These methods provide
16657 mechanisms to obtain the T* and T& from a T. We had the code
16658 previously scattered around the code base, and it also used
16659 TypeManager.LookupType that would go through plenty of caches.
16660 This one goes directly to the type source.
16662 In some places we did the Type.GetType followed by
16663 ModuleBuilder.GetType, but not in others, so this unifies the
16664 processing as well.
16666 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16667 statements now that we have namespace information.
16669 * typemanager.cs (IsNamespace): New method, returns whether the
16670 string presented is a namespace or not.
16672 (ComputeNamespaces): New public entry point, computes the list of
16673 available namespaces, using the GetNamespaces API call in Mono, or
16674 the slower version in MS.NET.
16676 Now before we start the semantic analysis phase, we have a
16677 complete list of namespaces including everything that the user has
16680 Deleted old code to cache namespaces in .nsc files.
16682 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16684 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16685 class/struct location definition Location for the implicit
16686 constructor location.
16688 (Operator.Define): Use the location of the operator for the
16689 implicit Method definition.
16691 (Constructor.Emit): use the constructor location for the implicit
16692 base initializer constructor.
16694 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16695 and the Expression class now contains two new methods:
16697 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16698 isolate type lookup from the rest of the resolution process.
16700 Since we use Expressions to hold type definitions due to the way
16701 we parse the input we have historically overloaded Resolve to
16702 perform the Type lookups if a special flag is passed. Now this is
16703 eliminated and two methods take their place.
16705 The differences in the two methods between xStep and xTerminal is
16706 that xStep is involved in our current lookup system that uses
16707 SimpleNames to compose a name, while xTerminal is used just to
16708 catch the case where the simplename lookup failed.
16710 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16712 * expression.cs (ResolveMemberAccess): Remove redundant code.
16713 TypeExpr expressions are always born fully resolved.
16715 * interface.cs (PopulateMethod): Do not lookup the types twice.
16716 We were doing it once during SemanticAnalysis and once during
16719 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16720 in local variable type definitions, were being returned as a
16721 SimpleName (we decomposed everything into a string), that is
16722 because primary_expression was being used instead of a type in the
16723 grammar (reduce/reduce conflicts).
16725 The part that was wrong is that we converted the expression into a
16726 string (an oversimplification in one hand, compounded with primary
16727 expressions doing string concatenation).
16733 Would return "A.B.C[]" as a SimpleName. This stopped things like
16734 using clauses from working on this particular context. And a type
16735 was being matched directly against "A.B.C[]".
16737 We now use the correct approach, and allow for ComposedCast to be
16738 part of the unary expression. So the "A.B.C []" become a composed
16739 cast of "A.B.C" (as a nested group of MemberAccess with a
16740 SimpleName at the end) plus the rank composition "[]".
16744 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16746 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16747 for the access level checking.
16749 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16750 `TypeContainer container', because I kept getting confused when I
16751 was debugging this code.
16753 * expression.cs (Indexers): Instead of tracking getters/setters,
16754 we now track them in parallel. We create one arraylist less, but
16755 most importantly it is possible now for the LValue code to find a
16756 matching get for a set.
16758 (IndexerAccess.DoResolveLValue): Update the code.
16759 GetIndexersForType has been modified already to extract all the
16760 indexers from a type. The code assumed it did not.
16762 Also make the code set the correct return type for the indexer.
16763 This was fixed a long time ago for properties, but was missing for
16764 indexers. It used to be void_type.
16766 (Binary.Emit): Test first for doubles instead of
16767 floats, as they are more common.
16769 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16770 when dealing with floats and the <=, >= operators. This fixes bug
16773 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16774 to load the array value by emitting a load on the foreach variable
16775 type. This was incorrect.
16777 We now emit the code to load an element using the the array
16778 variable type, and then we emit the conversion operator.
16782 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16784 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16786 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16788 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16789 test for protection before we test for signatures.
16791 (MethodSignature.ToString): implement.
16793 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16794 to the case where we reduced into a LongConstant.
16796 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16797 depend on whether the information is acurrate, because the
16798 Microsoft runtime will always claim that the array type is public,
16799 regardless of the real state.
16801 If the type is a pointer, another problem happens: the type is
16802 reported as non-public in Microsoft.
16804 In both cases we have to call CheckAccessLevel recursively with
16805 the underlying type as the argument to be tested.
16807 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16809 * assign.cs (Assign.Emit): If we are dealing with a compound
16810 assignment expression, we should use the code path that stores the
16811 intermediate result in a temporary value. This fixes #40903.
16813 *expression.cs (Indirection.ToString): Provide ToString method for
16816 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16818 * class.cs: Null out fields holding references to Block objects so
16819 they can be garbage collected.
16821 * expression.cs (OverloadResolve): Remove unused local.
16823 2003-04-07 Martin Baulig <martin@ximian.com>
16825 * codegen.cs (EmitContext.CurrentFile): New public field.
16826 (EmitContext.Mark): Use the CurrentFile to check whether the
16827 location is in the correct file.
16828 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16830 2003-04-07 Martin Baulig <martin@ximian.com>
16832 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16834 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16835 location. [FIXME: The location argument which gets passed to this
16836 method is sometimes wrong!]
16838 2003-04-07 Nick Drochak <ndrochak@gol.com>
16840 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16842 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16844 * expression.cs (Indirection.EmitAssign): We were using the
16845 temporary, but returning immediately instead of continuing the
16848 2003-04-06 Martin Baulig <martin@ximian.com>
16850 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16851 if it's a nested child, but also deriving from the outer class.
16854 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16855 nested child, but also deriving from the outer class. See
16857 (FilterWithClosure): We may access private members of the outer
16858 class if we're a nested child and deriving from the outer class.
16859 (RealMemberLookup): Only set `closure_private_ok' if the
16860 `original_bf' contained BindingFlags.NonPublic.
16862 2003-04-05 Martin Baulig <martin@ximian.com>
16864 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
16866 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16868 * class.cs (Event.Define): Do not allow abstract events to have
16871 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16873 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16874 block in event declarations.
16876 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16877 value type, get its address.
16879 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16880 leaving a class on the stack instead of a boolean value (int
16881 0/1). Change the code so we compare against null, and then the
16882 result against zero.
16884 * class.cs (TypeContainer.GetClassBases): We were checking for the
16885 parent class being sealed too late.
16887 * expression.cs (Binary.Emit): For <= and >= when dealing with
16888 floating point values, use cgt.un and clt.un instead of cgt and
16891 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16893 * statement.cs: Apply the same optimization as MS: skip the
16894 GetEnumerator returning an IEnumerator, and use the one returning a
16895 CharEnumerator instead. This allows us to avoid the try-finally block
16898 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16900 * cs-parser.jay: Attributes cannot be applied to
16901 namespaces. Fixes #40473
16903 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16906 (Add*): check if the name is valid using the full name for constants,
16907 fields, properties and events.
16909 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16911 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16912 char constants to be part of the enumeration.
16914 * expression.cs (Conditional.DoResolve): Add support for operator
16915 true. Implements the missing functionality from 14.12
16917 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16918 operator true/false as required by the spec.
16920 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16921 implicit conversion to boolean.
16923 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16924 also one where the type implements `operator true'.
16926 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16927 get an expression that will invoke operator true based on an
16930 (GetConversionOperators): Removed the hack that called op_True
16933 (Expression.ResolveBoolean): Move this from Statement.
16935 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16937 * ecore.cs (FieldExpr): do not allow initialization of initonly
16938 fields on derived classes
16940 2003-03-13 Martin Baulig <martin@ximian.com>
16942 * statement.cs (Block.Emit): Call ig.BeginScope() and
16943 ig.EndScope() when compiling with debugging info; call
16944 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16946 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16948 * expression.cs (Indexers): Do not construct immediately, allow
16949 for new members to be appended as we go. Fixes 38143
16951 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16953 * expression.cs: save/restore context when resolving an unchecked
16956 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16958 * cfold.cs: Catch division by zero in modulus operator during
16961 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16963 * interface.cs (Interface.DefineMembers): Avoid defining members
16966 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16968 * driver.cs: handle the +/- options for -noconfig
16970 * statement.cs (Unckeched.Resolve): Also track the state of
16971 unchecked in the Resolve phase.
16973 2003-02-27 Martin Baulig <martin@ximian.com>
16975 * ecore.cs (Expression.MemberLookup): Don't create a
16976 MethodGroupExpr for something which is not a method. Fixes #38291.
16978 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16980 * class.cs (MemberBase.CheckParameters): Also check that the type
16981 is unmanaged if it is a pointer.
16983 * expression.cs (SizeOf.Resolve): Add location information.
16985 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16986 a managed type is declared.
16988 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16989 parameter modifiers as well. Fixes bug 38606
16991 * class.cs: Very sad. Am backing out the speed up changes
16992 introduced by the ArrayList -> Array in the TypeContainer, as they
16993 were not actually that much faster, and introduced a bug (no error
16994 reports on duplicated methods).
16996 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16997 source first, this will guarantee that we have a valid expression
16998 before calling in lower levels functions that will require a
16999 resolved object. Then use this original_source in the
17000 target.ResolveLValue instead of the original source that was
17003 Another change. Use target.Resolve instead of LValueResolve.
17004 Although we are resolving for LValues, we will let the Assign code
17005 take care of that (it will be called again from Resolve). This
17006 basically allows code like this:
17008 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17009 class Y { void A (X x) { x [0] += o; }
17011 The problem was that the indexer was trying to resolve for
17012 set_Item (idx, object o) and never finding one. The real set_Item
17013 was set_Item (idx, X). By delaying the process we get the right
17018 2003-02-23 Martin Baulig <martin@ximian.com>
17020 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17021 while calling DoEmit ().
17023 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17024 source files; if you use the #line directive inside a method, the
17025 compiler stops emitting line numbers for the debugger until it
17026 reaches the end of the method or another #line directive which
17027 restores the original file.
17029 2003-02-23 Martin Baulig <martin@ximian.com>
17031 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17033 2003-02-23 Martin Baulig <martin@ximian.com>
17035 * statement.cs (Block.AddChildVariableNames): We need to call this
17036 recursively, not just for our immediate children.
17038 2003-02-23 Martin Baulig <martin@ximian.com>
17040 * class.cs (Event.Define): Always make the field private, like csc does.
17042 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17043 actually work, fixes bug #37521.
17045 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17047 * delegate.cs: When creating the various temporary "Parameters"
17048 classes, make sure that we call the ComputeAndDefineParameterTypes
17049 on those new parameters (just like we do with the formal ones), to
17050 allow them to be resolved in the context of the DeclSpace.
17052 This fixes the bug that Dick observed in Bugzilla #38530.
17054 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17056 * expression.cs (ResolveMemberAccess): When resolving a constant,
17057 do not attempt to pull a constant if the value was not able to
17058 generate a valid constant.
17060 * const.cs (LookupConstantValue): Do not report more errors than required.
17062 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17064 * expression.cs: fixes bug #38328.
17066 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17068 * class.cs: Changed all the various members that can be part of a
17069 class from being an ArrayList to be an Array of the right type.
17070 During the DefineType type_list, interface_list, delegate_list and
17071 enum_list are turned into types, interfaces, delegates and enums
17074 And during the member population, indexer_list, event_list,
17075 constant_list, field_list, instance_constructor_list, method_list,
17076 operator_list and property_list are turned into their real arrays.
17078 Although we could probably perform this operation earlier, for
17079 good error reporting we need to keep the lists and remove the
17080 lists for longer than required.
17082 This optimization was triggered by Paolo profiling the compiler
17083 speed on the output of `gen-sample-program.pl' perl script.
17085 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17086 not crash in methods like MemberLookupFailed that use this field.
17088 This problem arises when the compiler fails to resolve a type
17089 during interface type definition for example.
17091 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17093 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17094 inherit from System.Object, so we have to stop at null, not only
17095 when reaching System.Object.
17097 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17099 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17100 DeclaredOnly because the parent indexer might have had a different
17101 name, but did not loop until the top of the hierarchy was reached.
17103 The problem this one fixes is 35492: when a class implemented an
17104 indexer from an interface, we were getting the interface method
17105 (which was abstract) and we were flagging an error (can not invoke
17108 This also keeps bug 33089 functioning, and test-148 functioning.
17110 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17111 out if a method is special is to see if it is declared in a
17112 property or event, or whether it is one of the predefined operator
17113 names. This should fix correctly #36804.
17115 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17117 The goal here is to remove the dependency on EmptyCast.Peel ().
17118 Killing it completely.
17120 The problem is that currently in a number of places where
17121 constants are expected, we have to "probe" for an EmptyCast, and
17122 Peel, which is not the correct thing to do, as this will be
17123 repetitive and will likely lead to errors.
17125 The idea is to remove any EmptyCasts that are used in casts that
17126 can be reduced to constants, so we only have to cope with
17129 This bug hunt was triggered by Bug 37363 and the desire to remove
17130 the duplicate pattern where we were "peeling" emptycasts to check
17131 whether they were constants. Now constants will always be
17134 * ecore.cs: Use an enumconstant here instead of wrapping with
17137 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17138 throwing me off. By handling this we can get rid of a few hacks.
17140 * statement.cs (Switch): Removed Peel() code.
17142 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17144 * class.cs: Location information for error 508
17146 * expression.cs (New.DoResolve): Add a guard against double
17147 resolution of an expression.
17149 The New DoResolve might be called twice when initializing field
17150 expressions (see EmitFieldInitializers, the call to
17151 GetInitializerExpression will perform a resolve on the expression,
17152 and later the assign will trigger another resolution
17154 This leads to bugs (#37014)
17156 * delegate.cs: The signature for EndInvoke should contain any ref
17157 or out parameters as well. We were not doing this in the past.
17159 * class.cs (Field.Define): Do not overwrite the type definition
17160 inside the `volatile' group. Turns out that volatile enumerations
17161 were changing the type here to perform a validity test, which
17164 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17166 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17167 and structs, we do not want to load the instance variable
17169 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17170 enum_type has to be handled like an object reference (implicit
17171 conversions exists from this to object), but the regular IsClass
17172 and IsValueType tests will never return true for this one.
17174 Also we use TypeManager.IsValueType instead of type.IsValueType,
17175 just for consistency with the rest of the code (this is only
17176 needed if we ever use the construct exposed by test-180.cs inside
17177 corlib, which we dont today).
17179 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17181 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17184 2003-02-09 Martin Baulig <martin@ximian.com>
17186 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17187 (Namespace.DefineNamespaces): New static public method; this is
17188 called when we're compiling with debugging to add all namespaces
17189 to the symbol file.
17191 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17192 pass it to the Namespace's .ctor.
17194 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17195 and MethodBase arguments; pass the namespace ID to the symwriter;
17196 pass the MethodBase instead of the token to the symwriter.
17197 (SymbolWriter.DefineNamespace): New method to add a namespace to
17200 2003-02-09 Martin Baulig <martin@ximian.com>
17202 * symbolwriter.cs: New file. This is a wrapper around
17203 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17204 methods here in near future.
17206 2003-02-09 Martin Baulig <martin@ximian.com>
17208 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17209 ILGenerator.MarkSequencePoint() which are actually used by the
17212 2003-02-09 Martin Baulig <martin@ximian.com>
17214 * location.cs (SourceFile): New public sealed class. This
17215 contains the name and an index which is used in the location's token.
17216 (Location): Reserve an appropriate number of bits in the token for
17217 the source file instead of walking over that list, this gives us a
17218 really huge performance improvement when compiling with debugging.
17220 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17221 `SourceFile' argument instead of a string.
17222 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17223 but don't parse/tokenize here, we need to generate the list of all
17224 source files before we do that.
17225 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17228 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17229 instead of a string.
17231 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17234 2003-02-09 Martin Baulig <martin@ximian.com>
17236 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17237 filename on `#line default'.
17239 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17241 * statement.cs: don't clear the pinned var when the fixed statement
17242 returns from the method (fixes bug#37752).
17244 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17246 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17249 2003-02-07 Martin Baulig <martin@ximian.com>
17251 * driver.cs: Removed the `--debug-args' command line argument.
17253 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17254 automatically by the AsssemblyBuilder.
17255 (CodeGen.InitializeSymbolWriter): We don't need to call any
17256 initialization function on the symbol writer anymore. This method
17257 doesn't take any arguments.
17259 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17261 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17262 from referenced assemblies as well.
17264 2003-02-02 Martin Baulig <martin@ximian.com>
17266 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17268 2003-02-02 Martin Baulig <martin@ximian.com>
17270 * class.cs (Constructor.Emit): Open the symbol writer before
17271 emitting the constructor initializer.
17272 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17273 single-stepping through constructor initializers.
17275 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17277 * class.cs: Handle error 549: do not allow virtual methods in
17280 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17282 * decl.cs: Check access levels when resolving types
17284 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17286 * statement.cs: Add parameters and locals set in catch blocks that might
17287 return to set vector
17289 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17291 * class.cs (Operator): Set the SpecialName flags for operators.
17293 * expression.cs (Invocation.DoResolve): Only block calls to
17294 accessors and operators on SpecialName methods.
17296 (Cast.TryReduce): Handle conversions from char constants.
17299 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17301 * statement.cs: small memory and time optimization in FlowBranching.
17303 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17305 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17306 problem that the last fix but in the other sid (Set).
17308 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17309 access when there is no indexer in the hierarchy.
17311 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17313 * class.cs: Combine some if statements.
17315 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17317 * driver.cs: fixed bug #37187.
17319 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17321 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17322 any indexer, it's needed to build a list with all the indexers in the
17323 hierarchy (AllGetters), else we have problems. Fixes #35653.
17325 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17327 * class.cs (MethodData.Define): It is wrong for an interface
17328 implementation to be static in both cases: explicit and implicit.
17329 We were only handling this in one case.
17331 Improve the if situation there to not have negations.
17333 * class.cs (Field.Define): Turns out that we do not need to check
17334 the unsafe bit on field definition, only on usage. Remove the test.
17336 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17338 * driver.cs: use assembly.Location instead of Codebase (the latest
17339 patch made mcs fail when using MS assemblies).
17341 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17343 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17344 get the path to *corlib.dll.
17346 2003-01-21 Nick Drochak <ndrochak@gol.com>
17350 * typemanager.cs: Remove compiler warnings
17352 2003-01-20 Duncan Mak <duncan@ximian.com>
17354 * AssemblyInfo.cs: Bump the version number to 0.19.
17356 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17358 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17360 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17362 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17364 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17366 * cs-parser.jay: Small fix: we were not comparing the constructor
17367 name correctly. Thanks to Zoltan for the initial pointer.
17369 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17371 * cs-tokenizer.cs: Set file name when specified with #line
17373 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17375 * cs-parser.jay: Only perform the constructor checks here if we
17376 are named like the class; This will help provider a better
17377 error. The constructor path is taken when a type definition is
17378 not found, but most likely the user forgot to add the type, so
17379 report that rather than the constructor error.
17381 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17383 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17386 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17388 * cs-parser.jay: Add cleanup call.
17390 2003-01-13 Duncan Mak <duncan@ximian.com>
17392 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17393 consistent with other methods.
17395 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17397 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17399 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17401 * attribute.cs: only set GuidAttr to true when we have a
17404 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17408 * typemanager.cs: fixes to allow mcs compile corlib with the new
17409 Type.IsSubclassOf fix.
17411 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17413 * expression.cs (LocalVariableReference.DoResolve): Classify a
17414 constant as a value, not as a variable. Also, set the type for
17417 * cs-parser.jay (fixed_statement): take a type instead of a
17418 pointer_type, so we can produce a better error message later.
17420 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17423 (For.DoEmit): Make inifinite loops have a
17424 non-conditional branch back.
17426 (Fixed.DoEmit): First populate the pinned variables, then emit the
17427 statement, then clear the variables. Before I was emitting the
17428 code once for each fixed piece.
17431 2003-01-08 Martin Baulig <martin@ximian.com>
17433 * statement.cs (FlowBranching.MergeChild): A break in a
17434 SWITCH_SECTION does not leave a loop. Fixes #36155.
17436 2003-01-08 Martin Baulig <martin@ximian.com>
17438 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17439 lives in the same number space than `param_map'. Fixes #36154.
17441 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17443 * cs-parser.jay (constructor_declaration): Set the
17444 Constructor.ModFlags before probing for it. This makes the
17445 compiler report 514, 515 and 132 (the code was there, but got
17448 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17449 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17450 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17452 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17454 * enum.cs: create the enum static fields using the enum type.
17456 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17458 * class.cs: don't try to create the ParamBuilder for the return
17459 type if it's not needed (and handle it breaking for the ms runtime
17462 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17464 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17466 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17468 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17469 the command. This showed up while compiling the JANET source
17470 code, which used \r as its only newline separator.
17472 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17474 * class.cs (Method.Define): If we are an operator (because it
17475 reuses our code), then set the SpecialName and HideBySig. #36128
17477 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17479 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17480 exception, report error 120 `object reference required'.
17482 * driver.cs: Add --pause option, used during to measure the size
17483 of the process as it goes with --timestamp.
17485 * expression.cs (Invocation.DoResolve): Do not allow methods with
17486 SpecialName to be invoked.
17488 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17490 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17491 number before adding it.
17493 2002-12-21 Ravi Pratap <ravi@ximian.com>
17495 * ecore.cs (StandardImplicitConversion): When in an unsafe
17496 context, we allow conversion between void * to any other pointer
17497 type. This fixes bug #35973.
17499 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17501 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17502 is not thrown when extensionless outputs are used
17504 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17506 * rootcontext.cs: fixed compilation of corlib.
17508 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17510 * attribute.cs (Attributes.Contains): Add new method.
17512 * class.cs (MethodCore.LabelParameters): if the parameter is an
17513 `out' parameter, check that no attribute `[In]' has been passed.
17515 * enum.cs: Handle the `value__' name in an enumeration.
17517 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17519 * decl.cs: Added special case to allow overrides on "protected
17522 2002-12-18 Ravi Pratap <ravi@ximian.com>
17524 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17525 since it makes much more sense.
17527 (Attributes.ctor): Don't require a Location parameter.
17529 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17531 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17532 since we already have that information per attribute.
17534 * everywhere : make appropriate changes.
17536 * class.cs (LabelParameters): Write the code which actually
17537 applies attributes to the return type. We can't do this on the MS
17538 .NET runtime so we flag a warning in the case an exception is
17541 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17543 * const.cs: Handle implicit null conversions here too.
17545 2002-12-17 Ravi Pratap <ravi@ximian.com>
17547 * class.cs (MethodCore.LabelParameters): Remove the extra
17548 Type [] parameter since it is completely unnecessary. Instead
17549 pass in the method's attributes so that we can extract
17550 the "return" attribute.
17552 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17554 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17555 of ignoring it and letting the compile continue.
17557 * typemanager.cs (ChangeType): use an extra argument to return an
17558 error condition instead of throwing an exception.
17560 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17562 * expression.cs (Unary.TryReduce): mimic the code for the regular
17563 code path. Perform an implicit cast in the cases where we can
17564 implicitly convert to one of the integral types, and then reduce
17565 based on that constant. This fixes bug #35483.
17567 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17569 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17571 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17573 * namespace.cs: fixed bug #35489.
17575 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17577 * class.cs: Remove some dead code.
17579 * cs-parser.jay: Estimate the number of methods needed
17580 (RootContext.MethodCount);
17582 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17583 numbers instead of StringBuilders.
17585 * support.cs (PtrHashtable): Add constructor with initial size;
17586 We can now reduce reallocations of the method table.
17588 2002-12-10 Ravi Pratap <ravi@ximian.com>
17590 * attribute.cs (ApplyAttributes): Keep track of the emitted
17591 attributes on a per-target basis. This fixes bug #35413.
17593 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17595 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17596 default to the Windows 1252 encoding.
17598 (UnixParseOption): Support version, thanks to Alp for the missing
17601 * AssemblyInfo.cs: Add nice assembly information.
17603 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17606 * cs-parser.jay: Allow a trailing comma before the close bracked
17607 in the attribute_section production.
17609 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17610 address of the instance was being taken, I will take this out,
17611 because we take the address of the object immediately here.
17613 2002-12-09 Ravi Pratap <ravi@ximian.com>
17615 * typemanager.cs (AreMultipleAllowed): Take care of the most
17616 obvious case where attribute type is not in the current assembly -
17619 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17621 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17622 definitions, instead of doing that afterwards.
17624 Also we use a nice little hack, depending on the constructor, we
17625 know if we are a "composed" name or a simple name. Hence, we
17626 avoid the IndexOf test, and we avoid
17628 * codegen.cs: Add code to assist in a bug reporter to track down
17629 the source of a compiler crash.
17631 2002-12-07 Ravi Pratap <ravi@ximian.com>
17633 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17634 types have been emitted for a given element and flag an error
17635 if something which does not have AllowMultiple set is used more
17638 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17639 attribute types and their corresponding AllowMultiple properties
17641 (AreMultipleAllowed): Check the property for a given type.
17643 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17644 property in the case we have a TypeContainer.
17646 (Attributes.AddAttribute): Detect duplicates and just skip on
17647 adding them. This trivial fix catches a pretty gross error in our
17648 attribute emission - global attributes were being emitted twice!
17650 Bugzilla bug #33187 is now fixed.
17652 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17654 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17655 instead of pp_and).
17657 * expression.cs (Binary.ResolveOperator): I can only use the
17658 Concat (string, string, string) and Concat (string, string,
17659 string, string) if the child is actually a concatenation of
17662 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17664 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17665 context where we need a 2-character lookahead.
17667 * pending.cs (PendingImplementation): Rework so we can keep track
17668 of interface types all the time, and flag those which were
17669 implemented by parents as optional.
17671 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17673 * expression.cs (Binary.ResolveOperator): Use
17674 String.Concat(string,string,string) or
17675 String.Concat(string,string,string,string) when possible.
17677 * typemanager: More helper methods.
17680 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17682 * pending.cs: remove the bogus return from GetMissingInterfaces()
17683 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17685 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17687 * namespace.cs: avoid duplicated 'using xxx' being added to
17688 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17689 when we get more than one 'using' statement for the same namespace.
17690 Report a CS0105 warning for it.
17692 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17694 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17695 of calling getChar/putback, uses internal knowledge of it.
17697 (xtoken): Reorder tokenizer so most common patterns are checked
17698 first. This reduces the compilation time in another 5% (from 8.11s
17699 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17701 The parsing time is 22% of the compilation in mcs, and from that
17702 64% is spent on the tokenization process.
17704 I tried using a binary search for keywords, but this is slower
17705 than the hashtable. Another option would be to do a couple of
17708 * Not use a StringBuilder, instead use an array of chars,
17709 with a set value. Notice that this way we could catch
17710 the 645 error without having to do it *afterwards*.
17712 * We could write a hand-parser to avoid the hashtable
17713 compares altogether.
17715 The identifier consumption process takes 37% of the tokenization
17716 time. Another 15% is spent on is_number. 56% of the time spent
17717 on is_number is spent on Int64.Parse:
17719 * We could probably choose based on the string length to
17720 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17723 Another 3% is spend on wrapping `xtoken' in the `token' function.
17725 Handle 0xa0 as whitespace (#34752)
17727 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17729 * typemanager.cs (IsCLRType): New routine to tell whether a type
17730 is one of the builtin types.
17732 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17733 typecode in more places instead of doing pointer comparissions.
17734 We could leverage some knowledge about the way the typecodes are
17737 New code to cache namespaces in assemblies, it is currently not
17738 invoked, to be used soon.
17740 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17742 * expression.cs (Binary.ResolveOperator): specially handle
17743 strings, and do not perform user-defined operator overloading for
17746 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17748 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17749 internalcall as it is a pretty simple operation; Avoid whenever
17750 possible to call Char.IsLetter.
17752 (consume_identifier): Cut by half the number of
17753 hashtable calls by merging the is_keyword and GetKeyword behavior.
17755 Do not short-circuit, because if we do, we
17756 report errors (ie, #if false && true would produce an invalid
17760 2002-11-24 Martin Baulig <martin@ximian.com>
17762 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17763 check constant ranges and report a CS0221. Fixes #33186.
17765 2002-11-24 Martin Baulig <martin@ximian.com>
17767 * cs-parser.jay: Make this work for uninitialized variable
17768 declarations in the `for' initializer. Fixes #32416.
17770 2002-11-24 Martin Baulig <martin@ximian.com>
17772 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17773 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17775 2002-11-24 Martin Baulig <martin@ximian.com>
17777 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17778 argument; if true, we also check for user-defined conversions.
17779 This is only needed if both arguments are of a user-defined type.
17780 Fixes #30443, added test-175.cs.
17781 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17783 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17785 2002-11-24 Martin Baulig <martin@ximian.com>
17787 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17788 function to get the store opcode.
17789 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17790 only emit the Ldelema if the store opcode is Stobj. You must run
17791 both test-34 and test-167 to test this. Fixes #34529.
17793 2002-11-23 Martin Baulig <martin@ximian.com>
17795 * ecore.cs (Expression.MemberLookup): Added additional
17796 `qualifier_type' argument which is used when we're being called
17797 from MemberAccess.DoResolve() and null if we're called from a
17799 (Expression.MemberLookupFailed): New method to report errors; this
17800 does the CS1540 check and reports the correct error message.
17802 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17803 argument for the CS1540 check and redone the way how we're dealing
17804 with private members. See the comment in the source code for details.
17805 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17806 `closure_start_type' to `closure_qualifier_type' and check whether
17807 it's not null. It was not this filter being broken, it was just
17808 being called with the wrong arguments.
17810 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17811 and pass it the correct `qualifier_type'; this also does the error
17814 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17816 * expression.cs (Invocation.EmitParams): If the we are dealing
17817 with a non-built-in value type, load its address as well.
17819 (ArrayCreation): Use a a pretty constant instead
17820 of the hardcoded value 2. Use 6 instead of 2 for the number of
17821 static initializers.
17823 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17824 because they are not really value types, just glorified integers.
17826 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17828 * ecore.cs: Remove redundant code for enumerations, make them use
17829 the same code path as everything else, fixes the casting issue
17830 with enumerations in Windows.Forms.
17832 * attribute.cs: Do only cast to string if it is a string, the
17833 validation happens later.
17835 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17836 people upgrade their corlibs.
17838 * ecore.cs: Oops, enumerations were not following the entire code path
17840 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17842 * typemanager.cs (FilterWithClosure): Commented out the test for
17843 1540 in typemanager.cs, as it has problems when accessing
17844 protected methods from a parent class (see test-174.cs).
17846 * attribute.cs (Attribute.ValidateGuid): new method.
17847 (Attribute.Resolve): Use above.
17849 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17851 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17853 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17854 handling for enumerations, as we only needed the TypeContainer
17855 functionality to begin with (this is required for the fix below to
17856 work for enums that reference constants in a container class for
17859 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17861 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17862 a valid TypeBuilder to perform lookups on.o
17864 * class.cs (InheritableMemberSignatureCompare): Use true in the
17865 call to GetGetMethod and GetSetMethod, because we are comparing
17866 the signature, and we need to get the methods *even* if they are
17869 (PropertyBase.CheckBase): ditto.
17871 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17872 GotoCase.Resolve): Use Peel on EmpytCasts.
17874 * ecore.cs (EmptyCast): drop child, add Peel method.
17876 2002-11-17 Martin Baulig <martin@ximian.com>
17878 * ecore.cs (EmptyCast.Child): New public property.
17880 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17881 label resolved to an EmptyCast. Fixes #34162.
17882 (GotoCase.Resolve): Likewise.
17883 (Block.EmitMeta): Likewise.
17885 2002-11-17 Martin Baulig <martin@ximian.com>
17887 * expression.cs (Invocation.BetterConversion): Prefer int over
17888 uint; short over ushort; long over ulong for integer literals.
17889 Use ImplicitConversionExists instead of StandardConversionExists
17890 since we also need to check for user-defined implicit conversions.
17891 Fixes #34165. Added test-173.cs.
17893 2002-11-16 Martin Baulig <martin@ximian.com>
17895 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17896 with the `true' and `false' literals. Fixes #33151.
17898 2002-11-16 Martin Baulig <martin@ximian.com>
17900 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17901 October 22nd; don't do the cs1540 check for static members.
17903 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17904 now using our own filter here and doing the cs1540 check again.
17906 2002-11-16 Martin Baulig <martin@ximian.com>
17908 * support.cs (InternalParameters): Don't crash if we don't have
17909 any fixed parameters. Fixes #33532.
17911 2002-11-16 Martin Baulig <martin@ximian.com>
17913 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17914 when looking up static methods to make this work on Windows.
17917 2002-11-16 Martin Baulig <martin@ximian.com>
17919 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17920 a setter rather than using PropertyInfo.CanWrite.
17922 2002-11-15 Nick Drochak <ndrochak@gol.com>
17924 * class.cs: Allow acces to block member by subclasses. Fixes build
17927 2002-11-14 Martin Baulig <martin@ximian.com>
17929 * class.cs (Constructor.Emit): Added the extern/block check.
17932 2002-11-14 Martin Baulig <martin@ximian.com>
17934 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17935 iteration while looking for indexers, this is needed because the
17936 indexer may have a different name in our base classes. Fixed the
17937 error reporting (no indexers at all, not get accessor, no
17938 overloaded match). Fixes bug #33089.
17939 (IndexerAccess.DoResolveLValue): Likewise.
17941 2002-11-14 Martin Baulig <martin@ximian.com>
17943 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17944 indexers. Fixes the first part of bug #33089.
17945 (MethodSignature.InheritableMemberSignatureCompare): Added support
17948 2002-11-13 Ravi Pratap <ravi@ximian.com>
17950 * attribute.cs (Attribute.Resolve): Catch the
17951 NullReferenceException and report it since it isn't supposed to
17954 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17956 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17957 LogicalOr and LogicalAnd that can benefit from recursively
17958 handling EmitBranchable. The code now should be nice for Paolo.
17960 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17962 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17963 the Type lookups, as we perform quite a number of lookups on
17964 non-Types. This can be removed once we can deterministically tell
17965 whether we have a type or a namespace in advance.
17967 But this might require special hacks from our corlib.
17971 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17972 and double which avoids a conversion from an integer to a double.
17974 * expression.cs: tiny optimization, avoid calling IsConstant,
17975 because it effectively performs the lookup twice.
17977 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17979 But a bogus return here to keep the semantics of the old code
17980 until the Mono runtime is fixed.
17982 * pending.cs (GetMissingInterfaces): New method used to remove all
17983 the interfaces that are already implemented by our parent
17984 classes from the list of pending methods.
17986 * interface.cs: Add checks for calls after ResolveTypeExpr.
17988 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17990 * class.cs (Class.Emit): Report warning 67: event not used if the
17991 warning level is beyond 3.
17993 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17994 being a NullLiteral.
17996 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17999 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18000 path that might fail if a type can not be resolved.
18002 * expression.cs (Binary.Emit): Emit unsigned versions of the
18005 * driver.cs: use error 5.
18007 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18009 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18011 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18013 * cs-parser.jay (switch_section): A beautiful patch from Martin
18014 Baulig that fixed 33094.
18016 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18018 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18019 Check whether the base is abstract and report an error if so.
18021 * expression.cs (IndexerAccess.DoResolveLValue,
18022 IndexerAccess.DoResolve): ditto.
18024 (Invocation.DoResolve): ditto.
18026 (Invocation.FullMethodDesc): Improve the report string.
18028 * statement.cs (Block): Eliminate IsVariableDefined as it is
18029 basically just a wrapper for GetVariableInfo.
18031 * ecore.cs (SimpleName): Use new
18033 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18034 type, as we return the actual parameter ref/unref state on a
18037 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18039 * support.cs: Return proper flags REF/OUT fixing the previous
18042 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18043 not used to mean `ref' but `ref or out' in ParameterReference
18045 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18046 full type signature instead of calling TypeManger.CSharpName
18049 * support.cs (InternalParameters.ParameterDesc): Do not compare
18050 directly to the modflags, because REF/OUT will actually be bitsets
18053 * delegate.cs (VerifyMethod): Check also the modifiers.
18055 * cs-tokenizer.cs: Fix bug where floating point values with an
18056 exponent where a sign was missing was ignored.
18058 * driver.cs: Allow multiple assemblies to be specified in a single
18061 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18063 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18064 because identifiers after a parenthesis would end up in this kind
18065 of production, and we needed to desamiguate it for having casts
18068 (UserDefinedType *) xxx
18070 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18072 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18073 we should set on the Bindingflags.NonPublic, but not turn on
18074 private_ok. private_ok controls whether a Private member is
18075 returned (this is chekced on the filter routine), while the
18076 BindingFlags.NonPublic just controls whether private/protected
18077 will be allowed. This fixes the problem part of the problem of
18078 private properties being allowed to be used in derived classes.
18080 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18081 so we can call the children DoResolveLValue method (this will
18082 properly signal errors on lvalue assignments to base properties)
18084 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18085 getter are null, and we have a property info, we know that this
18086 happened because the lookup failed, so we report an error 122 for
18087 protection level violation.
18089 We also silently return if setter and getter are null in the
18090 resolve functions, this condition only happens if we have flagged
18091 the error before. This is the other half of the problem.
18093 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18094 not have accessibility information, that is why we were returning
18095 true in the filter function in typemanager.cs.
18097 To properly report 122 (property is inaccessible because of its
18098 protection level) correctly, we report this error in ResolveAccess
18099 by failing if both the setter and the getter are lacking (ie, the
18102 DoResolve and DoLResolve have been modified to check for both
18103 setter/getter being null and returning silently, the reason being
18104 that I did not want to put the knowledge about this error in upper
18107 int old = Report.Errors;
18108 x = new PropertyExpr (...);
18109 if (old != Report.Errors)
18114 So the property expr is returned, but it is invalid, so the error
18115 will be flagged during the resolve process.
18117 * class.cs: Remove InheritablePropertySignatureCompare from the
18118 class, as we no longer depend on the property signature to compute
18119 whether it is possible to implement a method or not.
18121 The reason is that calling PropertyInfo.GetGetMethod will return
18122 null (in .NET, in Mono it works, and we should change this), in
18123 cases where the Get Method does not exist in that particular
18128 class X { public virtual int A { get { return 1; } } }
18130 class Z : Y { public override int A { get { return 2; } } }
18132 Would fail in Z because the parent (Y) would not have the property
18133 defined. So we avoid this completely now (because the alternative
18134 fix was ugly and slow), and we now depend exclusively on the
18137 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18138 reference method, instead of using the property.
18140 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18141 routines are gone now.
18143 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18144 names, they were incorrectly named.
18146 * cs-tokenizer.cs: Return are more gentle token on failure.
18148 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18149 had an out-of-sync index variable, which caused it to remove from
18150 the list of pending methods the wrong method sometimes.
18152 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18154 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18155 CanWrite, because those refer to this particular instance of the
18156 property, and do not take into account the fact that we can
18157 override single members of a property.
18159 Constructor requires an EmitContext. The resolution process does
18160 not happen here, but we need to compute the accessors before,
18161 because the resolution does not always happen for properties.
18163 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18164 subclass, before we did not update this flag, but we did update
18167 (GetAccessors): Drop this routine, as it did not work in the
18168 presence of partially overwritten set/get methods.
18170 Notice that this broke the cs1540 detection, but that will require
18173 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18177 * driver.cs: issue a warning instead of an error if we don't support
18178 debugging for the platform. Also ignore a couple of errors that may
18179 arise when trying to write the symbols. Undo my previous patch.
18181 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18183 * driver.cs: ignore /debug switch except for Unix platforms.
18185 2002-10-23 Nick Drochak <ndrochak@gol.com>
18187 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18189 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18191 * driver.cs: Do not make mcs-debug conditional, so we do not break
18192 builds that use it.
18194 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18195 review this patch. But basically after all the children variables
18196 have been merged, the value of "Breaks" was not being set to
18197 new_breaks for Switch blocks. I think that it should be set after
18198 it has executed. Currently I set this to the value of new_breaks,
18199 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18200 conservative, but I do not understand this code very well.
18202 I did not break anything in the build, so that is good ;-)
18204 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18206 2002-10-20 Mark Crichton <crichton@gimp.org>
18208 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18210 2002-10-20 Nick Drochak <ndrochak@gol.com>
18212 * cfold.cs: Fixed compile blocker.
18214 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18216 * driver.cs: I was chekcing the key, not the file.
18218 2002-10-19 Ravi Pratap <ravi@ximian.com>
18220 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18221 message that we were generating - we just need to silently return
18224 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18226 * class.cs (Event.Define): Change my previous commit, as this
18227 breaks the debugger. This is a temporary hack, as it seems like
18228 the compiler is generating events incorrectly to begin with.
18230 * expression.cs (Binary.ResolveOperator): Added support for
18231 "U operator - (E x, E y)"
18233 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18236 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18237 init-only variables, but this path did not take into account that
18238 there might be also instance readonly variables. Correct this
18241 This fixes bug 32253
18243 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18246 * driver.cs: Change the extension for modules to `netmodule'
18248 * cs-parser.jay: Improved slightly the location tracking for
18249 the debugger symbols.
18251 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18252 modifiers that were specified instead of the hardcoded value
18253 (FamAndAssem). This was basically ignoring the static modifier,
18254 and others. Fixes 32429.
18256 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18257 fixed a bug in the process (32476)
18259 * expression.cs (ArrayAccess.EmitAssign): Patch from
18260 hwang_rob@yahoo.ca that fixes bug 31834.3
18262 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18264 * driver.cs: Make the module extension .netmodule.
18266 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18268 * driver.cs: Report an error if the resource file is not found
18269 instead of crashing.
18271 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18272 false, like Emit does.
18274 2002-10-16 Nick Drochak <ndrochak@gol.com>
18276 * typemanager.cs: Remove unused private member. Also reported mcs
18277 bug to report this as a warning like csc.
18279 2002-10-15 Martin Baulig <martin@gnome.org>
18281 * statement.cs (Statement.Emit): Made this a virtual method; emits
18282 the line number info and calls DoEmit().
18283 (Statement.DoEmit): New protected abstract method, formerly knows
18284 as Statement.Emit().
18286 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18288 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18290 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18291 have fixed a remaining problem: not every AddXXXX was adding a
18292 fully qualified name.
18294 Now everyone registers a fully qualified name in the DeclSpace as
18295 being defined instead of the partial name.
18297 Downsides: we are slower than we need to be due to the excess
18298 copies and the names being registered this way.
18300 The reason for this is that we currently depend (on the corlib
18301 bootstrap for instance) that types are fully qualified, because
18302 we dump all the types in the namespace, and we should really have
18303 types inserted into the proper namespace, so we can only store the
18304 basenames in the defined_names array.
18306 2002-10-10 Martin Baulig <martin@gnome.org>
18308 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18309 from bug #31834, see the bug report for a testcase which is
18312 2002-10-10 Martin Baulig <martin@gnome.org>
18314 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18315 flow analysis code for this.
18317 * statement.cs (Do, While, For): Tell the flow analysis code about
18319 (FlowBranching.UsageVector): Added support for infinite loops.
18320 (Block.Resolve): Moved the dead code elimination here and use flow
18323 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18325 * class.cs (Field.Define): Catch cycles on struct type
18328 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18329 fields if the fields are static. We only need to check instance
18332 * expression.cs (As.DoResolve): Test for reference type.
18334 * statement.cs (Using.ResolveExpression): Use
18335 ConvertImplicitRequired, not ConvertImplicit which reports an
18337 (Using.ResolveLocalVariableDecls): ditto.
18339 * expression.cs (Binary.ResolveOperator): Report errors in a few
18340 places where we had to.
18342 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18344 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18346 * expression.cs: Use StoreFromPtr instead of extracting the type
18347 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18349 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18350 an enumeration value to a System.Enum, but System.Enum is not a
18351 value type, but an class type, so we need to box.
18353 (Expression.ConvertExplicit): One codepath could return
18354 errors but not flag them. Fix this. Fixes #31853
18356 * parameter.cs (Resolve): Do not allow void as a parameter type.
18358 2002-10-06 Martin Baulig <martin@gnome.org>
18360 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18361 if it's a class type and not a struct. Fixes #31815.
18363 2002-10-06 Martin Baulig <martin@gnome.org>
18365 * statement.cs: Reworked the flow analysis code a bit to make it
18366 usable for dead code elimination.
18368 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18370 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18372 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18374 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18375 to fix the test 165, will investigate deeper.
18377 2002-10-04 Martin Baulig <martin@gnome.org>
18379 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18380 finally blocks actually work.
18381 (Try.Resolve): We don't need to create a sibling for `finally' if
18382 there is no finally block.
18384 2002-10-04 Martin Baulig <martin@gnome.org>
18386 * class.cs (Constructor.Define): The default accessibility for a
18387 non-default constructor is private, not public.
18389 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18391 * class.cs (Constructor): Make AllowedModifiers public, add
18394 * cs-parser.jay: Perform the modifiers test here, as the
18395 constructor for the Constructor class usually receives a zero
18396 because of the way we create it (first we create, later we
18397 customize, and we were never checking the modifiers).
18399 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18400 is a version of LookupTypeReflection that includes the type-name
18401 cache. This can be used as a fast path for functions that know
18402 the fully qualified name and are only calling into *.GetType() to
18403 obtain a composed type.
18405 This is also used by TypeManager.LookupType during its type
18408 (LookupType): We now also track the real type name, as sometimes
18409 we can get a quey for the real type name from things like
18410 ComposedCast. This fixes bug 31422.
18412 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18413 complete type fullname, it does not have to go through the type
18414 resolution system to obtain the composed version of the type (for
18415 obtaining arrays or pointers).
18417 (Conditional.Emit): Use the EmitBoolExpression to
18418 generate nicer code, as requested by Paolo.
18420 (ArrayCreation.CheckIndices): Use the patch from
18421 hwang_rob@yahoo.ca to validate the array initializers.
18423 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18425 * class.cs (ConstructorInitializer.Emit): simplify code by using
18426 Invocation.EmitCall, and at the same time, fix the bugs in calling
18427 parent constructors that took variable arguments.
18429 * ecore.cs (Expression.ConvertNumericExplicit,
18430 Expression.ImplicitNumericConversion): Remove the code that
18431 manually wrapped decimal (InternalTypeConstructor call is now gone
18434 * expression.cs (Cast.TryReduce): Also handle decimal types when
18435 trying to perform a constant fold on the type.
18437 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18439 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18440 that only turned off an error report, and did nothing else.
18442 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18444 * driver.cs: Handle and ignore /fullpaths
18446 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18448 * expression.cs (Binary.ResolveOperator): Catch the case where
18449 DoNumericPromotions returns true,
18451 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18453 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18455 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18458 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18460 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18461 conversion exists, but it is also required that the conversion be
18462 performed. This manifested in "(Type64Enum) 2".
18464 * class.cs (TypeManager.AddMethod): The fix is not to change
18465 AddEnum, because that one was using a fully qualified name (every
18466 DeclSpace derivative does), but to change the AddMethod routine
18467 that was using an un-namespaced name. This now correctly reports
18468 the duplicated name.
18470 Revert patch until I can properly fix it. The issue
18471 is that we have a shared Type space across all namespaces
18472 currently, which is wrong.
18474 Options include making the Namespace a DeclSpace, and merge
18475 current_namespace/current_container in the parser.
18477 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18479 * cs-parser.jay: Improve error reporting when we get a different
18480 kind of expression in local_variable_type and
18481 local_variable_pointer_type.
18483 Propagate this to avoid missleading errors being reported.
18485 * ecore.cs (ImplicitReferenceConversion): treat
18486 TypeManager.value_type as a target just like object_type. As
18491 Is valid, and needs to result in the int 1 being boxed before it
18492 is assigned to the value type v.
18494 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18495 to validate the enumeration name.
18497 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18498 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18499 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18501 * ecore.cs (TryImplicitIntConversion): When doing an
18502 implicit-enumeration-conversion, check if the type is 64-bits and
18503 perform a conversion before passing to EnumConstant.
18505 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18507 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18508 report ambiguous type references. Unlike the MS version, we
18509 report what the ambiguity is. Innovation at work ;-)
18511 (DeclSpace.FindType): Require a location argument to
18512 display when we display an ambiguous error.
18514 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18516 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18518 * expression.cs (EmitDynamicInitializers): Apply patch from
18519 hwang_rob@yahoo.ca that fixes the order in which we emit our
18522 2002-09-21 Martin Baulig <martin@gnome.org>
18524 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18525 delegate takes no arguments.
18527 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18529 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18532 * expression.cs: Extract the underlying type.
18534 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18536 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18538 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18540 * class.cs (TypeContainer.DefineType): We can not use the nice
18541 PackingSize with the size set to 1 DefineType method, because it
18542 will not allow us to define the interfaces that the struct
18545 This completes the fixing of bug 27287
18547 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18548 means also structs. This fixes part of the problem.
18549 (Expresion.ImplicitReferenceConversionExists): ditto.
18551 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18552 error if there were no errors reported during the type lookup
18553 process, to avoid duplicates or redundant errors. Without this
18554 you would get an ambiguous errors plus a type not found. We have
18555 beaten the user enough with the first error.
18557 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18560 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18561 during the resolution process, stop the lookup, this avoids
18562 repeated error reports (same error twice).
18564 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18566 * typemanager.cs (LookupType): Redo the type lookup code to match
18567 the needs of System.Reflection.
18569 The issue is that System.Reflection requires references to nested
18570 types to begin with a "+" sign instead of a dot. So toplevel
18571 types look like: "NameSpace.TopLevelClass", and nested ones look
18572 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18575 2002-09-19 Martin Baulig <martin@gnome.org>
18577 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18578 says that a method always returns or always throws an exception,
18579 don't report the CS0161.
18581 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18582 set `Returns = new_returns'.
18584 2002-09-19 Martin Baulig <martin@gnome.org>
18586 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18587 to an enum constant, check for a CS0176.
18589 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18591 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18592 for operators that must be in pairs and report errors.
18594 * ecore.cs (SimpleName.DoResolveType): During the initial type
18595 resolution process, when we define types recursively, we must
18596 check first for types in our current scope before we perform
18597 lookups in the enclosing scopes.
18599 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18601 (Invocation.VerifyArgumentsCompat): Call
18602 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18603 I thought we were supposed to always call this, but there are a
18604 few places in the code where we dont do it.
18606 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18608 * driver.cs: Add support in -linkres and -resource to specify the
18609 name of the identifier.
18611 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18613 * ecore.cs (StandardConversionExists): Sync with the conversion
18614 code: allow anything-* to void* conversions.
18616 (FindMostSpecificSource): Use an Expression argument
18617 instead of a Type, because we might be handed over a Literal which
18618 gets a few more implicit conversions that plain types do not. So
18619 this information was being lost.
18621 Also, we drop the temporary type-holder expression when not
18624 2002-09-17 Martin Baulig <martin@gnome.org>
18626 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18627 this is an explicit interface implementation.
18629 2002-09-17 Martin Baulig <martin@gnome.org>
18631 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18632 different `IndexerName' attributes.
18634 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18635 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18636 virtual CommonResolve().
18638 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18640 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18641 and convert that to the UnderlyingType.
18643 * statement.cs (Foreach.Resolve): Indexers are just like variables
18644 or PropertyAccesses.
18646 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18647 inside quoted strings, we were not doing this before.
18649 2002-09-16 Martin Baulig <martin@gnome.org>
18651 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18652 resolve it. This is needed for the definite assignment check of the
18653 instance expression, fixes bug #29846.
18654 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18656 2002-09-16 Nick Drochak <ndrochak@gol.com>
18658 * parameter.cs: Fix compile error. Cannot reference static member
18659 from an instance object. Is this an mcs bug?
18661 2002-09-14 Martin Baulig <martin@gnome.org>
18663 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18664 multiple times. Fixes bug #30295, added test-166.cs.
18666 2002-09-14 Martin Baulig <martin@gnome.org>
18668 * statement.cs (Block.Emit): Don't emit unreachable code.
18669 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18670 `break' statements.
18671 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18673 2002-09-14 Martin Baulig <martin@gnome.org>
18675 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18678 2002-09-14 Martin Baulig <martin@gnome.org>
18680 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18681 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18682 be false on the ms runtime.
18684 2002-09-13 Martin Baulig <martin@gnome.org>
18686 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18687 the CS0038 error message.
18689 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18691 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18692 constant inside, return it.
18694 2002-09-12 Martin Baulig <martin@gnome.org>
18696 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18697 implicit conversion can be done between enum types.
18699 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18700 check whether an implicit conversion to the current enum's UnderlyingType
18701 exists and report an error if not.
18703 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18704 without debugging support.
18706 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18707 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18709 2002-09-12 Martin Baulig <martin@gnome.org>
18711 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18713 * ecore.cs (IMemberExpr.DeclaringType): New property.
18714 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18715 nonstatic member of an outer type (CS0038).
18717 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18719 * driver.cs: Activate the using-error detector at warning level
18720 4 (at least for MS-compatible APIs).
18722 * namespace.cs (VerifyUsing): Small buglett fix.
18724 * pending.cs (PendingImplementation): pass the container pointer.
18726 * interface.cs (GetMethods): Allow for recursive definition. Long
18727 term, I would like to move every type to support recursive
18728 definitions, not the current ordering mechanism that we have right
18731 The situation is this: Attributes are handled before interfaces,
18732 so we can apply attributes to interfaces. But some attributes
18733 implement interfaces, we will now handle the simple cases
18734 (recursive definitions will just get an error).
18736 * parameter.cs: Only invalidate types at the end if we fail to
18739 2002-09-09 Martin Baulig <martin@gnome.org>
18741 * ecore.cs (PropertyExpr.Emit): Also check for
18742 TypeManager.system_int_array_get_length so this'll also work when
18743 compiling corlib. Fixes #30003.
18745 2002-09-09 Martin Baulig <martin@gnome.org>
18747 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18748 and throw an exception if we can't get the type's size. Fixed #30040,
18751 2002-09-09 Martin Baulig <martin@gnome.org>
18753 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18755 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18756 context. Fixes bug #30027.
18758 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18759 virtual functions. Fixes bug #30043, added test-164.cs.
18761 2002-09-08 Ravi Pratap <ravi@ximian.com>
18763 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18765 2002-09-08 Nick Drochak <ndrochak@gol.com>
18767 * driver.cs: Use an object to get the windows codepage since it's not a
18770 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18772 * statement.cs (For.Emit): for infinite loops (test == null)
18773 return whether there is a break inside, not always "true".
18775 * namespace.cs (UsingEntry): New struct to hold the name of the
18776 using definition, the location where it is defined, and whether it
18777 has been used in a successful type lookup.
18779 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18784 2002-09-06 Ravi Pratap <ravi@ximian.com>
18786 * attribute.cs : Fix incorrect code which relied on catching
18787 a NullReferenceException to detect a null being passed in
18788 where an object was expected.
18790 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18792 * statement.cs (Try): flag the catch variable as assigned
18794 * expression.cs (Cast): Simplified by using ResolveType instead of
18795 manually resolving.
18797 * statement.cs (Catch): Fix bug by using ResolveType.
18799 2002-09-06 Ravi Pratap <ravi@ximian.com>
18801 * expression.cs (BetterConversion): Special case for when we have
18802 a NullLiteral as the argument and we have to choose between string
18803 and object types - we choose string the way csc does.
18805 * attribute.cs (Attribute.Resolve): Catch the
18806 NullReferenceException and report error #182 since the Mono
18807 runtime no more has the bug and having this exception raised means
18808 we tried to select a constructor which takes an object and is
18811 2002-09-05 Ravi Pratap <ravi@ximian.com>
18813 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18814 message (1502, 1503) when we can't locate a method after overload
18815 resolution. This is much more informative and closes the bug
18818 * interface.cs (PopulateMethod): Return if there are no argument
18819 types. Fixes a NullReferenceException bug.
18821 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18822 expressions too. Previously we were checking only in one place for
18823 positional arguments leaving out named arguments.
18825 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18826 type to the enum type is not allowed. Remove code corresponding to
18829 (ConvertNumericExplicit): Allow explicit conversions from
18830 the underlying type to enum type. This precisely follows the spec
18831 and closes a bug filed by Gonzalo.
18833 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18836 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18838 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18840 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18841 it was important that we stored the right value after the
18842 reduction in `converted'.
18844 2002-09-04 Martin Baulig <martin@gnome.org>
18846 * location.cs (Location.SymbolDocument): Use full pathnames for the
18849 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18851 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18852 of the expression resolve mechanism, because that will catch the
18853 SimpleName error failures.
18855 (Conditional): If we can not resolve the
18856 expression, return, do not crash.
18858 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18861 (location): display token name instead of its number.
18863 2002-08-28 Martin Baulig <martin@gnome.org>
18865 * expression.cs (Binary.ResolveOperator): Don't silently return
18866 but return an error if an operator cannot be applied between two
18869 2002-08-28 Martin Baulig <martin@gnome.org>
18871 * class.cs (Constructor.Define): Set the permission attributes
18872 correctly instead of making all constructors public.
18874 2002-08-28 Martin Baulig <martin@gnome.org>
18876 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18877 for private members before reporting a CS0103; if we find anything,
18880 2002-08-28 Martin Baulig <martin@gnome.org>
18882 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18883 to check whether `closure_start_type == closure_invocation_type',
18884 we also need to check whether `m.DeclaringType == closure_invocation_type'
18885 before bypassing the permission checks. We might be accessing
18886 protected/private members from the base class.
18887 (TypeManager.RealMemberLookup): Only set private_ok if private
18888 members were requested via BindingFlags.NonPublic.
18890 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18892 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18893 MethodGroupExpr.IsExplicitImpl if appropriate.
18894 (Invocation.DoResolve): Don't report the CS0120 for explicit
18895 interface implementations.
18897 2002-08-27 Martin Baulig <martin@gnome.org>
18899 * expression.cs (Invocation.DoResolve): If this is a static
18900 method and we don't have an InstanceExpression, we must report
18903 2002-08-25 Martin Baulig <martin@gnome.org>
18905 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18906 `==' between a valuetype and an object.
18908 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18910 * ecore.cs (TypeExpr): Provide a ToString method.
18912 2002-08-24 Martin Baulig <martin@gnome.org>
18914 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18915 now called proggie.dbg and it's a binary file.
18917 2002-08-23 Martin Baulig <martin@gnome.org>
18919 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18921 2002-08-23 Martin Baulig <martin@gnome.org>
18923 * struct.cs (MyStructInfo.ctor): Make this work with empty
18924 structs; it's not allowed to use foreach() on null.
18926 2002-08-23 Martin Baulig <martin@gnome.org>
18928 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18929 writer the full pathname of the generated assembly.
18931 2002-08-23 Martin Baulig <martin@gnome.org>
18933 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18934 A `finally' block never returns or breaks; improved handling of
18937 2002-08-23 Martin Baulig <martin@gnome.org>
18939 * statement.cs (Throw.Resolve): Allow `throw null'.
18941 2002-08-23 Martin Baulig <martin@gnome.org>
18943 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18944 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18945 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18946 MemberLookup would return a wrong event if this is an explicit
18947 interface implementation and the class has an event with the same
18950 2002-08-23 Martin Baulig <martin@gnome.org>
18952 * statement.cs (Block.AddChildVariableNames): New public method.
18953 (Block.AddChildVariableName): Likewise.
18954 (Block.IsVariableNameUsedInChildBlock): Likewise.
18955 (Block.AddVariable): Check whether a variable name has already
18956 been used in a child block.
18958 * cs-parser.jay (declare_local_variables): Mark all variable names
18959 from the current block as being used in a child block in the
18962 2002-08-23 Martin Baulig <martin@gnome.org>
18964 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18965 find the symbol writer.
18967 * driver.cs: csc also allows the arguments to /define being
18968 separated by commas, not only by semicolons.
18970 2002-08-23 Martin Baulig <martin@gnome.org>
18972 * interface.cs (Interface.GetMembers): Added static check for events.
18974 2002-08-15 Martin Baulig <martin@gnome.org>
18976 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18977 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18979 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18980 why the MethodData.EmitDestructor() change was necessary.
18982 2002-08-20 Martin Baulig <martin@gnome.org>
18984 * class.cs (TypeContainer.FindMembers): Added static check for events.
18986 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18988 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18989 use Type.GetEvents(), not Type.FindMembers().
18991 2002-08-20 Martin Baulig <martin@gnome.org>
18993 * decl.cs (MemberCache): Added a special method cache which will
18994 be used for method-only searched. This ensures that a method
18995 search will return a MethodInfo with the correct ReflectedType for
18998 2002-08-20 Martin Baulig <martin@gnome.org>
19000 * decl.cs (DeclSpace.FindMembers): Made this public.
19002 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19004 * delegate.cs: fixed build on windows.
19005 [FIXME: Filed as bug #29150: MCS must report these errors.]
19007 2002-08-19 Ravi Pratap <ravi@ximian.com>
19009 * ecore.cs (StandardConversionExists): Return a false
19010 if we are trying to convert the void type to anything else
19011 since that is not allowed.
19013 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19014 we flag error 70 in the event an event is trying to be accessed
19015 directly from outside the declaring type.
19017 2002-08-20 Martin Baulig <martin@gnome.org>
19019 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19020 MemberCache from typemanager.cs to decl.cs.
19022 2002-08-19 Martin Baulig <martin@gnome.org>
19024 * class.cs (TypeContainer): Implement IMemberContainer.
19025 (TypeContainer.DefineMembers): Create the MemberCache.
19026 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19027 return public members if BindingFlags.Public was given, check
19028 whether members are static.
19030 2002-08-16 Martin Baulig <martin@gnome.org>
19032 * decl.cs (DeclSpace.Define): Splitted this in Define and
19033 DefineMembers. DefineMembers is called first and initializes the
19036 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19037 DefineMembers() on all our DeclSpaces.
19039 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19040 but call DefineMembers() on all nested interfaces. We call their
19041 Define() in our new Define() function.
19043 * interface.cs (Interface): Implement IMemberContainer.
19044 (Interface.Define): Moved all code except the attribute stuf to
19046 (Interface.DefineMembers): Initialize the member cache.
19048 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19049 need this anymore since we can use MemberCache.FindMembers directly.
19051 2002-08-19 Martin Baulig <martin@gnome.org>
19053 * typemanager.cs (MemberCache): When creating the cache for an
19054 interface type, add all inherited members.
19055 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19056 to `out bool used_cache' and documented it.
19057 (TypeManager.MemberLookup): If we already used the cache in the first
19058 iteration, we don't need to do the interfaces check.
19060 2002-08-19 Martin Baulig <martin@gnome.org>
19062 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19063 here from IMemberFinder and don't implement this interface anymore.
19064 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19066 * typemanager.cs (IMemberFinder): This interface is now only used by
19067 classes which actually support the member cache.
19068 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19069 since we only put DeclSpaces into this Hashtable.
19070 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19071 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19073 2002-08-16 Martin Baulig <martin@gnome.org>
19075 * typemanager.cs (ICachingMemberFinder): Removed.
19076 (IMemberFinder.MemberCache): New property.
19077 (TypeManager.FindMembers): Merged this with RealFindMembers().
19078 This function will never be called from TypeManager.MemberLookup()
19079 so we can't use the cache here, just the IMemberFinder.
19080 (TypeManager.MemberLookup_FindMembers): Check whether the
19081 IMemberFinder has a MemberCache and call the cache's FindMembers
19083 (MemberCache): Rewrote larger parts of this yet another time and
19084 cleaned it up a bit.
19086 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19088 * driver.cs (LoadArgs): Support quoting.
19090 (Usage): Show the CSC-like command line arguments.
19092 Improved a few error messages.
19094 2002-08-15 Martin Baulig <martin@gnome.org>
19096 * typemanager.cs (IMemberContainer.Type): New property.
19097 (IMemberContainer.IsInterface): New property.
19099 The following changes are conditional to BROKEN_RUNTIME, which is
19100 defined at the top of the file.
19102 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19103 class'es members, but add all members from TypeHandle.ObjectType
19104 if we're an interface.
19105 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19106 is the current type.
19107 (MemberCache.CacheEntry.Container): Removed this field.
19108 (TypeHandle.GetMembers): Include inherited members.
19110 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19112 * typemanager.cs: fixed compilation and added a comment on a field that
19115 2002-08-15 Martin Baulig <martin@gnome.org>
19117 * class.cs (ConstructorInitializer.Resolve): In the
19118 Expression.MemberLookup call, use the queried_type as
19121 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19122 declared' attribute, it's always true.
19123 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19124 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19125 temporary wrapper for FindMembers which tells MemberLookup whether
19126 members from the base classes are included in the return value.
19127 This will go away soon.
19128 (TypeManager.MemberLookup): Use this temporary hack here; once the
19129 new MemberCache is completed, we don't need to do the DeclaredOnly
19130 looping here anymore since the MemberCache will take care of this.
19131 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19132 (MemberCache): When creating the MemberCache for a class, get
19133 members from the current class and all its base classes.
19134 (MemberCache.CacheEntry.Container): New field. This is a
19135 temporary hack until the Mono runtime is fixed to distinguish
19136 between ReflectedType and DeclaringType. It allows us to use MCS
19137 with both the MS runtime and the unfixed Mono runtime without
19138 problems and without accecting performance.
19139 (MemberCache.SearchMembers): The DeclaredOnly looping from
19140 TypeManager.MemberLookup is now done here.
19142 2002-08-14 Martin Baulig <martin@gnome.org>
19144 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19145 Type.GetFields on dynamic types but get the fields from the
19146 corresponding TypeContainer.
19147 (MyStructInfo.GetStructInfo): Added check for enum types.
19149 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19150 (MemberList.SyncRoot): Implemented.
19151 (TypeManager.FilterWithClosure): No need to check permissions if
19152 closure_start_type == closure_invocation_type, don't crash if
19153 closure_invocation_type is null.
19155 2002-08-13 Martin Baulig <martin@gnome.org>
19157 Rewrote TypeContainer.FindMembers to use a member cache. This
19158 gives us a speed increase of about 35% for the self-hosting MCS
19159 build and of about 15-20% for the class libs (both on GNU/Linux).
19161 * report.cs (Timer): New class to get enhanced profiling. This
19162 whole class is "TIMER" conditional since it remarkably slows down
19165 * class.cs (MemberList): New class. This is an IList wrapper
19166 which we're now using instead of passing MemberInfo[]'s around to
19167 avoid copying this array unnecessarily.
19168 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19169 (ICachingMemberFinder, IMemberContainer): New interface.
19170 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19171 has already been checked, otherwise use it for the name comparision.
19172 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19173 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19174 if possible. Returns a MemberList, not a MemberInfo [].
19175 (TypeHandle): New class, implements IMemberContainer. We create
19176 one instance of this class per type, it contains a MemberCache
19177 which is used to do the member lookups.
19178 (MemberCache): New class. Each instance of this class contains
19179 all members of a type and a name-based hash table.
19180 (MemberCache.FindMembers): This is our new member lookup
19181 function. First, it looks up all members of the requested name in
19182 the hash table. Then, it walks this list and sorts out all
19183 applicable members and returns them.
19185 2002-08-13 Martin Baulig <martin@gnome.org>
19187 In addition to a nice code cleanup, this gives us a performance
19188 increase of about 1.4% on GNU/Linux - not much, but it's already
19189 half a second for the self-hosting MCS compilation.
19191 * typemanager.cs (IMemberFinder): New interface. It is used by
19192 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19193 Enum, Delegate or Interface.
19194 (TypeManager.finder_to_member_finder): New PtrHashtable.
19195 (TypeManager.finder_to_container): Removed.
19196 (TypeManager.finder_to_delegate): Removed.
19197 (TypeManager.finder_to_interface): Removed.
19198 (TypeManager.finder_to_enum): Removed.
19200 * interface.cs (Interface): Implement IMemberFinder.
19202 * delegate.cs (Delegate): Implement IMemberFinder.
19204 * enum.cs (Enum): Implement IMemberFinder.
19206 * class.cs (TypeContainer): Implement IMemberFinder.
19208 2002-08-12 Martin Baulig <martin@gnome.org>
19210 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19212 2002-08-12 Martin Baulig <martin@gnome.org>
19214 * ecore.cs (ITypeExpression): New interface for expressions which
19216 (TypeExpression): Renamed to TypeLookupExpression.
19217 (Expression.DoResolve): If we're doing a types-only lookup, the
19218 expression must implement the ITypeExpression interface and we
19219 call DoResolveType() on it.
19220 (SimpleName): Implement the new ITypeExpression interface.
19221 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19222 hack, the situation that we're only looking up types can't happen
19223 anymore when this method is called. Moved the type lookup code to
19224 DoResolveType() and call it.
19225 (SimpleName.DoResolveType): This ITypeExpression interface method
19226 is now doing the types-only lookup.
19227 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19228 (ResolveFlags): Added MaskExprClass.
19230 * expression.cs (MemberAccess): Implement the ITypeExpression
19232 (MemberAccess.DoResolve): Added support for a types-only lookup
19233 when we're called via ITypeExpression.DoResolveType().
19234 (ComposedCast): Implement the ITypeExpression interface.
19236 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19237 Expression.Resolve() with ResolveFlags.Type instead.
19239 2002-08-12 Martin Baulig <martin@gnome.org>
19241 * interface.cs (Interface.Define): Apply attributes.
19243 * attribute.cs (Attribute.ApplyAttributes): Added support for
19244 interface attributes.
19246 2002-08-11 Martin Baulig <martin@gnome.org>
19248 * statement.cs (Block.Emit): Only check the "this" variable if we
19249 do not always throw an exception.
19251 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19252 whether the property has a set accessor.
19254 2002-08-11 Martin Baulig <martin@gnome.org>
19256 Added control flow analysis support for structs.
19258 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19259 with control flow analysis turned off.
19260 (IVariable): New interface.
19261 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19262 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19263 (FieldExpr.DoResolve): Resolve the instance expression with flow
19264 analysis turned off and do the definite assignment check after the
19265 resolving when we know what the expression will resolve to.
19267 * expression.cs (LocalVariableReference, ParameterReference):
19268 Implement the new IVariable interface, only call the flow analysis
19269 code if ec.DoFlowAnalysis is true.
19270 (This): Added constructor which takes a Block argument. Implement
19271 the new IVariable interface.
19272 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19273 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19274 This does the definite assignment checks for struct members.
19276 * class.cs (Constructor.Emit): If this is a non-static `struct'
19277 constructor which doesn't have any initializer, call
19278 Block.AddThisVariable() to tell the flow analysis code that all
19279 struct elements must be initialized before control returns from
19282 * statement.cs (MyStructInfo): New public class.
19283 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19284 argument to this indexer. If non-zero, check an individual struct
19285 member, not the whole struct.
19286 (FlowBranching.CheckOutParameters): Check struct members.
19287 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19288 overloaded versions of these methods which take an additional
19289 `int field_idx' argument to check struct members.
19290 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19291 overloaded versions of these methods which take an additional
19292 `string field_name' argument to check struct member.s
19293 (VariableInfo): Implement the IVariable interface.
19294 (VariableInfo.StructInfo): New public property. Returns the
19295 MyStructInfo instance of the variable if it's a struct or null.
19296 (Block.AddThisVariable): New public method. This is called from
19297 Constructor.Emit() for non-static `struct' constructor which do
19298 not have any initializer. It creates a special variable for the
19299 "this" instance variable which will be checked by the flow
19300 analysis code to ensure that all of the struct's fields are
19301 initialized before control returns from the constructor.
19302 (UsageVector): Added support for struct members. If a
19303 variable/parameter is a struct with N members, we reserve a slot
19304 in the usage vector for each member. A struct is considered fully
19305 initialized if either the struct itself (slot 0) or all its
19306 members are initialized.
19308 2002-08-08 Martin Baulig <martin@gnome.org>
19310 * driver.cs (Driver.MainDriver): Only report an error CS5001
19311 if there were no compilation errors.
19313 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19314 `UnsafeContext' property to determine whether the parent is in
19315 unsafe context rather than checking the parent's ModFlags:
19316 classes nested in an unsafe class are unsafe as well.
19318 2002-08-08 Martin Baulig <martin@gnome.org>
19320 * statement.cs (UsageVector.MergeChildren): Distinguish between
19321 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19322 we return. Added test17() and test18() to test-154.cs.
19324 2002-08-08 Martin Baulig <martin@gnome.org>
19326 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19327 Family access, make sure the invoking type isn't a subclass of the
19328 queried type (that'd be a CS1540).
19330 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19331 this method which takes an additional `Type invocation_type'.
19333 * expression.cs (BaseAccess.DoResolve): Use the base type as
19334 invocation and query type.
19335 (MemberAccess.DoResolve): If the lookup failed and we're about to
19336 report a CS0122, try a lookup with the ec.ContainerType - if this
19337 succeeds, we must report a CS1540.
19339 2002-08-08 Martin Baulig <martin@gnome.org>
19341 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19342 (MethodGroupExpr): Implement the IMemberExpr interface.
19344 * expression (MemberAccess.ResolveMemberAccess): No need to have
19345 any special code for MethodGroupExprs anymore, they're now
19348 2002-08-08 Martin Baulig <martin@gnome.org>
19350 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19351 Family, FamANDAssem and FamORAssem permissions.
19352 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19354 2002-08-08 Martin Baulig <martin@gnome.org>
19356 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19357 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19360 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19362 * driver.cs: implemented /resource option to embed managed resources.
19364 2002-08-07 Martin Baulig <martin@gnome.org>
19366 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19367 (FieldBase.HasFieldInitializer): New public property.
19368 (FieldBase.GetInitializerExpression): New public method. Resolves and
19369 returns the field initializer and makes sure it is only resolved once.
19370 (TypeContainer.EmitFieldInitializers): Call
19371 FieldBase.GetInitializerExpression to get the initializer, this ensures
19372 that it isn't resolved multiple times.
19374 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19375 the resolving process (SimpleName/MemberLookup) that we're currently
19376 emitting a field initializer (which must not access any instance members,
19377 this is an error CS0236).
19379 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19380 argument, if the `IsFieldInitializer' flag is set, we must report and
19381 error CS0236 and not an error CS0120.
19383 2002-08-07 Martin Baulig <martin@gnome.org>
19385 * ecore.cs (IMemberExpr): New public interface.
19386 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19387 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19388 if the expression is an IMemberExpr.
19390 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19391 to be null, implicitly default to `this' if we're non-static in
19392 this case. Simplified the code a lot by using the new IMemberExpr
19393 interface. Also fixed bug #28176 here.
19395 2002-08-06 Martin Baulig <martin@gnome.org>
19397 * cs-parser.jay (SimpleLookup): Removed. We need to create
19398 ParameterReferences during semantic analysis so that we can do a
19399 type-only search when resolving Cast, TypeOf and SizeOf.
19400 (block): Pass the `current_local_parameters' to the Block's
19403 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19404 argument to the constructor.
19405 (ConstructorInitializer.Resolve): Create a temporary implicit
19406 block with the parameters.
19408 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19409 references here if we aren't doing a type-only search.
19411 * statement.cs (Block): Added constructor which takes a
19412 `Parameters parameters' argument.
19413 (Block.Parameters): New public property.
19415 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19416 to `Parameters' and made it public readonly.
19418 2002-08-06 Martin Baulig <martin@gnome.org>
19420 * ecore.cs (Expression.Warning): Made this public as well.
19422 * report.cs (Report.Debug): Print the contents of collections.
19424 2002-08-06 Martin Baulig <martin@gnome.org>
19426 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19427 used to tell Resolve() which kinds of expressions it may return.
19428 (Expression.Resolve): Added overloaded version of this method which
19429 takes a `ResolveFlags flags' argument. This can be used to tell
19430 Resolve() which kinds of expressions it may return. Reports a
19432 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19433 ResolveFlags.SimpleName.
19434 (Expression.Error118): Added overloaded version of this method which
19435 takes a `ResolveFlags flags' argument. It uses the flags to determine
19436 which kinds of expressions are allowed.
19438 * expression.cs (Argument.ResolveMethodGroup): New public method.
19439 Resolves an argument, but allows a MethodGroup to be returned.
19440 This is used when invoking a delegate.
19442 * TODO: Updated a bit.
19444 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19446 Fixed compilation with csc.
19448 * ecore.cs: Expression.Error made public. Is this correct? Should
19449 Warning be made public too?
19451 * expression.cs: use ea.Location instead of ea.loc.
19452 [FIXME: Filed as bug #28607: MCS must report these errors.]
19454 2002-08-06 Martin Baulig <martin@gnome.org>
19456 * ecore.cs (Expression.loc): Moved the location here instead of
19457 duplicating it in all derived classes.
19458 (Expression.Location): New public property.
19459 (Expression.Error, Expression.Warning): Made them non-static and
19460 removed the location argument.
19461 (Expression.Warning): Added overloaded version which takes an
19462 `int level' argument.
19463 (Expression.Error118): Make this non-static and removed the
19464 expression and location arguments.
19465 (TypeExpr): Added location argument to the constructor.
19467 * expression.cs (StaticCallExpr): Added location argument to
19469 (Indirection, PointerArithmetic): Likewise.
19470 (CheckedExpr, UnCheckedExpr): Likewise.
19471 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19472 (StringPtr): Likewise.
19475 2002-08-05 Martin Baulig <martin@gnome.org>
19477 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19479 * assign.cs (Assign.DoResolve): Check whether the source
19480 expression is a value or variable.
19482 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19483 while resolving the corresponding blocks.
19485 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19486 an error, don't silently return null.
19488 * statement.cs (Block.AddVariable): Do the error reporting here
19489 and distinguish between CS0128 and CS0136.
19490 (Block.DoResolve): Report all unused labels (warning CS0164).
19491 (LabeledStatement): Pass the location to the constructor.
19492 (LabeledStatement.HasBeenReferenced): New property.
19493 (LabeledStatement.Resolve): Set it to true here.
19495 * statement.cs (Return.Emit): Return success even after reporting
19496 a type mismatch error (CS0126 or CS0127), this is what csc does and
19497 it avoids confusing the users with any consecutive errors.
19499 2002-08-05 Martin Baulig <martin@gnome.org>
19501 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19503 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19505 * expression.cs (MemberAccess.DoResolve): Silently return if an
19506 error has already been reported.
19508 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19509 error has already been reported.
19511 2002-08-05 Martin Baulig <martin@gnome.org>
19513 * statement.cs (UsageVector): Only initialize the `parameters'
19514 vector if we actually have any "out" parameters.
19516 2002-08-05 Martin Baulig <martin@gnome.org>
19518 * expression.cs (Binary.ResolveOperator): When combining delegates,
19519 they must have the same type.
19521 2002-08-05 Martin Baulig <martin@gnome.org>
19523 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19524 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19525 work with the ms runtime and we also don't need it: if we're a
19526 PropertyBuilder and not in the `indexer_arguments' hash, then we
19527 are a property and not an indexer.
19529 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19530 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19531 since the latter one doesn't work with the ms runtime.
19533 2002-08-03 Martin Baulig <martin@gnome.org>
19535 Fixed bugs #27998 and #22735.
19537 * class.cs (Method.IsOperator): New public field.
19538 (Method.CheckBase): Report CS0111 if there's already a method
19539 with the same parameters in the current class. Report CS0508 when
19540 attempting to change the return type of an inherited method.
19541 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19542 and it's not marked abstract or extern.
19543 (PropertyBase): New abstract base class for Property and Indexer.
19544 (PropertyBase.CheckBase): Moved here from Property and made it work
19546 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19547 the same so we can reuse it there.
19548 (Property, Indexer): Derive from PropertyBase.
19549 (MethodSignature.inheritable_property_signature_filter): New delegate
19550 to find properties and indexers.
19552 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19553 argument and improved error reporting.
19555 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19556 EmptyReadOnlyParameters and made it a property.
19558 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19559 version of this method which takes a `PropertyInfo indexer'.
19560 (TypeManager.RegisterIndexer): New method.
19562 * class.cs: Added myself as author of this file :-)
19564 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19566 * class.cs: fixed compilation on windoze.
19568 2002-08-03 Martin Baulig <martin@gnome.org>
19570 * interface.cs (Interface.GetInterfaceBases): Check whether all
19571 base interfaces are at least as accessible than the current one.
19573 * class.cs (TypeContainer.GetClassBases): Check whether base types
19574 are at least as accessible than the current type.
19575 (TypeContainer.AsAccessible): Implemented and made non-static.
19576 (MemberBase.CheckParameters): Report errors if the accessibility
19579 * delegate.cs (Delegate.Delegate): The default visibility is
19580 internal for top-level types and private for nested types.
19581 (Delegate.Define): Report errors if the accessibility checks fail.
19583 * enum.cs (Enum.Enum): The default visibility is internal for
19584 top-level types and private for nested types.
19585 (Enum.DefineType): Compute the correct visibility.
19587 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19588 function which takes a `bool is_toplevel' instead of a TypeContainer.
19590 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19593 2002-08-02 Martin Baulig <martin@gnome.org>
19595 * expression.cs (LocalVariableReferenc): Added constructor which
19596 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19597 (LocalVariableReference.IsReadOnly): New property.
19598 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19599 variable is readonly, use our own readonly flag to do this; you can
19600 use the new constructor to get a writable reference to a read-only
19603 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19604 reference to the local variable.
19606 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19608 * rootcontext.cs (ResolveCore): Also include System.Exception
19610 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19611 we reach an EmptyStatement.
19613 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19616 * expression.cs (Binary.ResolveOperator): Check error result in
19619 use brtrue/brfalse directly and avoid compares to null.
19621 2002-08-02 Martin Baulig <martin@gnome.org>
19623 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19624 Fixes bug #28407, added test-155.cs.
19626 2002-08-01 Martin Baulig <martin@gnome.org>
19628 * class.cs (Event.EmitDefaultMethod): Make this work with static
19629 events. Fixes #28311, added verify-3.cs.
19631 2002-08-01 Martin Baulig <martin@gnome.org>
19633 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19634 `is_disposable' fields.
19635 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19636 `hm.is_disposable' if we're using the collection pattern.
19637 (Foreach.EmitCollectionForeach): Use the correct type for the
19638 enumerator's local variable, only emit the try/finally block if
19639 necessary (fixes #27713).
19641 2002-08-01 Martin Baulig <martin@gnome.org>
19643 * ecore.cs (Expression.report118): Renamed to Error118 and made
19646 * statement.cs (Throw.Resolve): Check whether the expression is of
19647 the correct type (CS0118) and whether the type derives from
19648 System.Exception (CS0155).
19649 (Catch.Resolve): New method. Do the type lookup here and check
19650 whether it derives from System.Exception (CS0155).
19651 (Catch.CatchType, Catch.IsGeneral): New public properties.
19653 * typemanager.cs (TypeManager.exception_type): Added.
19655 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19657 * driver.cs: Updated About function.
19659 2002-07-31 Martin Baulig <martin@gnome.org>
19661 Implemented Control Flow Analysis.
19663 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19664 (EmitContext.CurrentBranching): Added.
19665 (EmitContext.StartFlowBranching): Added.
19666 (EmitContext.EndFlowBranching): Added.
19667 (EmitContext.KillFlowBranching): Added.
19668 (EmitContext.IsVariableAssigned): Added.
19669 (EmitContext.SetVariableAssigned): Added.
19670 (EmitContext.IsParameterAssigned): Added.
19671 (EmitContext.SetParameterAssigned): Added.
19672 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19673 Added control flow analysis stuff here.
19675 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19676 resolve the expression as lvalue.
19677 (LocalVariableReference.DoResolve): Check whether the variable has
19678 already been assigned.
19679 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19680 the parameter as assigned here.
19681 (ParameterReference.DoResolve): Check whether the parameter has already
19683 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19684 expression as lvalue.
19686 * statement.cs (FlowBranching): New class for the flow analysis code.
19687 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19688 (LabeledStatement.IsDefined): New public property.
19689 (LabeledStatement.AddUsageVector): New public method to tell flow
19690 analyis that the label may be reached via a forward jump.
19691 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19693 (VariableInfo.Number): New public field. This is used by flow analysis
19694 to number all locals of a block.
19695 (Block.CountVariables): New public property. This is the number of
19696 local variables in this block (including the locals from all parent
19698 (Block.EmitMeta): Number all the variables.
19700 * statement.cs: Added flow analysis support to all classes.
19702 2002-07-31 Martin Baulig <martin@gnome.org>
19704 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19705 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19706 then use this argument.
19708 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19710 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19711 use this to specify /define options.
19713 2002-07-29 Martin Baulig <martin@gnome.org>
19715 * statement.cs (Fixed): Moved all code that does variable lookups
19716 and resolvings from Emit to Resolve.
19718 * statement.cs (For): Moved all code that does variable lookups
19719 and resolvings from Emit to Resolve.
19721 * statement.cs (Using): Moved all code that does variable lookups
19722 and resolvings from Emit to Resolve.
19724 2002-07-29 Martin Baulig <martin@gnome.org>
19726 * attribute.cs (Attribute.Resolve): Explicitly catch a
19727 System.NullReferenceException when creating the
19728 CustromAttributeBuilder and report a different warning message.
19730 2002-07-29 Martin Baulig <martin@gnome.org>
19732 * support.cs (ParameterData.ParameterName): Added method to
19733 get the name of a parameter.
19735 * typemanager.cs (TypeManager.IsValueType): New public method.
19737 2002-07-29 Martin Baulig <martin@gnome.org>
19739 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19740 is a flag which specifies that it's either ref or out.
19741 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19742 the out parameter to `out Parameter.Modifier mod', also set the
19743 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19745 * support.cs (InternalParameters.ParameterModifier): Distinguish
19746 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19747 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19749 * expression.cs (Argument.GetParameterModifier): Distinguish
19750 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19751 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19753 2002-07-29 Martin Baulig <martin@gnome.org>
19755 * expression.cs (ParameterReference.ParameterReference): Added
19756 `Location loc' argument to the constructor.
19758 * cs-parser.jay: Pass location to ParameterReference.
19760 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19762 * statement.cs (Try): Initialize the location.
19764 * cs-parser.jay: pass location to Try.
19766 * expression.cs (Unary.Reduce): Change the prototype to return
19767 whether a constant fold could be performed or not. The result is
19768 returned in an out parameters. In the case of Indirection and
19769 AddressOf, we want to perform the full tests.
19771 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19773 * statement.cs (Statement.Emit): Flag dead code.
19775 2002-07-27 Andrew Birkett <andy@nobugs.org>
19777 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19779 2002-07-27 Martin Baulig <martin@gnome.org>
19781 * class.cs (MethodData.Define): Put back call to
19782 TypeManager.AddMethod(), accidentally commented this out.
19784 * report.cs (Debug): New public method to print debugging information,
19785 this is `[Conditional ("DEBUG")]'.
19787 2002-07-26 Martin Baulig <martin@gnome.org>
19789 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19790 (switch_statement): Push the current_block to the switch_stack and
19791 pop it again when we're done with the switch.
19792 (switch_section): The new block is a child of the current_block.
19793 Fixes bug #24007, added test-152.cs.
19795 2002-07-27 Martin Baulig <martin@gnome.org>
19797 * expression.cs (Invocation.EmitArguments): When calling a varargs
19798 function with only its fixed arguments, we need to pass an empty
19801 2002-07-27 Martin Baulig <martin@gnome.org>
19803 Mono 0.13 has been released.
19805 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19807 * driver.cs: Rename --resource to --linkres, because that is what
19808 we do currently, we dont support --resource yet.
19810 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19812 2002-07-25 Martin Baulig <martin@gnome.org>
19814 * class.cs (MethodData): New public class. This is a `method builder'
19815 class for a method or one accessor of a Property/Indexer/Event.
19816 (MethodData.GetMethodFlags): Moved here from MemberBase.
19817 (MethodData.ApplyAttributes): Likewise.
19818 (MethodData.ApplyObsoleteAttribute): Likewise.
19819 (MethodData.ApplyConditionalAttribute): Likewise.
19820 (MethodData.ApplyDllImportAttribute): Likewise.
19821 (MethodData.CheckAbstractAndExternal): Likewise.
19822 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19823 (MethodData.Emit): Formerly known as Method.Emit().
19824 (MemberBase): Moved everything which was specific to a single
19825 accessor/method to MethodData.
19826 (Method): Create a new MethodData and call Define() and Emit() on it.
19827 (Property, Indexer, Event): Create a new MethodData objects for each
19828 accessor and call Define() and Emit() on them.
19830 2002-07-25 Martin Baulig <martin@gnome.org>
19832 Made MethodCore derive from MemberBase to reuse the code from there.
19833 MemberBase now also checks for attributes.
19835 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19836 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19838 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19839 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19840 (MemberBase.ApplyAttributes): New virtual method; applies the
19841 attributes to a method or accessor.
19842 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19843 (MemberBase.ApplyConditionalAttribute): Likewise.
19844 (MemberBase.ApplyDllImportAttribute): Likewise.
19845 (MemberBase.CheckAbstractAndExternal): Likewise.
19846 (MethodCore.ParameterTypes): This is now a property instead of a
19847 method, it's initialized from DoDefineParameters().
19848 (MethodCore.ParameterInfo): Removed the set accessor.
19849 (MethodCore.DoDefineParameters): New protected virtual method to
19850 initialize ParameterTypes and ParameterInfo.
19851 (Method.GetReturnType): We can now simply return the MemberType.
19852 (Method.GetMethodFlags): Override the MemberBase version and add
19853 the conditional flags.
19854 (Method.CheckBase): Moved some code from Define() here, call
19855 DoDefineParameters() here.
19856 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19857 here to avoid some larger code duplication.
19858 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19859 ensure that abstract and external accessors don't declare a body.
19861 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19862 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19863 lookup in the attribute's parent classes, so we need to abort as soon
19864 as we found the first match.
19865 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19866 the attribute has no arguments.
19868 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19871 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19873 * cs-parser.jay: reverted previous patch.
19875 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19877 * cs-parser.jay: fixed bug #22119.
19879 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19881 * attribute.cs: fixed compilation. The error was:
19882 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19883 be assigned to before control leaves the current method."
19884 [FIXME: Filed as bug #28186: MCS must report this error.]
19886 2002-07-25 Martin Baulig <martin@gnome.org>
19888 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19889 method to pull the condition name ouf of a Conditional attribute.
19890 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19891 the obsolete message and error flag out of an Obsolete attribute.
19893 * class.cs (Method.GetMethodFlags): New public method to get the
19894 TypeManager.MethodFlags for this method.
19895 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19897 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19898 if we're overriding a virtual function, set the new private variable
19899 `parent_method'; call the new TypeManager.AddMethod().
19901 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19902 the MethodBuilder and the Method in a PtrHashtable.
19903 (TypeManager.builder_to_method): Added for this purpose.
19904 (TypeManager.MethodFlags): Added IsObsoleteError.
19905 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19906 Obsolete and Conditional arguments in MethodBuilders. If we discover
19907 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19908 the message from the attribute.
19910 2002-07-24 Martin Baulig <martin@gnome.org>
19912 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19913 preprocessor directives, ensure that the argument to #define/#undef is
19914 exactly one identifier and that it's actually an identifier.
19916 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19919 2002-07-24 Martin Baulig <martin@gnome.org>
19921 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19922 initialize it to TypeManager.object_type in the constructor.
19923 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19924 of the `hm.get_current' method if we're using the collection pattern.
19925 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19926 for the explicit conversion to make it work when we're using the collection
19927 pattern and the `Current' property has a different return type than `object'.
19930 2002-07-24 Martin Baulig <martin@gnome.org>
19932 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19933 does not match, but don't report any errors. This method is called in
19934 order for all methods in a MethodGroupExpr until a matching method is
19935 found, so we don't want to bail out if the first method doesn't match.
19936 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19937 matches, report the 123. Fixes #28070.
19939 2002-07-24 Martin Baulig <martin@gnome.org>
19941 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19942 TypeManager.TypeToCoreType() to the top of the method so the
19943 following equality checks will work. Fixes #28107.
19945 2002-07-24 Martin Baulig <martin@gnome.org>
19947 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19948 operand is of type uint, and the other operand is of type sbyte,
19949 short or int, the operands are converted to type long." -
19950 Actually do what this comment already told us. Fixes bug #28106,
19953 2002-07-24 Martin Baulig <martin@gnome.org>
19955 * class.cs (MethodBase): New abstract class. This is now a base
19956 class for Property, Indexer and Event to avoid some code duplication
19957 in their Define() and DefineMethods() methods.
19958 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19959 generic methods for Define() and DefineMethods().
19960 (FieldBase): Derive from MemberBase, not MemberCore.
19961 (Property): Derive from MemberBase, not MemberCore.
19962 (Property.DefineMethod): Moved all the code from this method to the
19963 new MethodBase.DefineAccessor(), just call it with appropriate
19965 (Property.Define): Call the new Property.DoDefine(), this does some
19966 sanity checks and we don't need to duplicate the code everywhere.
19967 (Event): Derive from MemberBase, not MemberCore.
19968 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19969 accessors, this will also make them work with interface events.
19970 (Indexer): Derive from MemberBase, not MemberCore.
19971 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19972 (Indexer.Define): Use the new MethodBase functions.
19974 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19975 argument to the constructor.
19976 (Interface.FindMembers): Added support for interface events.
19977 (Interface.PopluateEvent): Implemented.
19979 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19981 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19983 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19984 but this is required to check for a method name being the same as
19985 the containing class.
19989 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19991 * interface.cs: initialize variable.
19993 2002-07-23 Martin Baulig <martin@gnome.org>
19995 Implemented the IndexerName attribute in interfaces.
19997 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19998 name if this is an explicit interface implementation.
19999 (Indexer.InterfaceIndexerName): New public variable. If we're
20000 implementing an interface indexer, this is the IndexerName in that
20001 interface. Otherwise, it's the IndexerName.
20002 (Indexer.DefineMethod): If we're implementing interface indexer,
20003 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20004 and Pending.ImplementIndexer methods.
20005 (Indexer.Define): Also define the PropertyBuilder if we're
20006 implementing an interface indexer and this is neither an explicit
20007 interface implementation nor do the IndexerName match the one in
20010 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20011 If a method is defined here, then we always need to create a proxy
20012 for it. This is used when implementing interface indexers.
20013 (Pending.IsInterfaceIndexer): New public method.
20014 (Pending.ImplementIndexer): New public method.
20015 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20016 This is used when implementing interface indexers to define a proxy
20018 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20019 define a proxy if necessary.
20021 * interface.cs (Interface.IndexerName): New public variable.
20022 (Interface.PopulateIndexer): Set the IndexerName.
20023 (Interface.DefineIndexers): New private method. Populate all the
20024 indexers and make sure their IndexerNames match.
20026 * typemanager.cs (IndexerPropertyName): Added support for interface
20029 2002-07-22 Martin Baulig <martin@gnome.org>
20031 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20032 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20033 ret if HasReturnLabel.
20034 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20037 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20038 and set the ec.LoopBeginTryCatchLevel.
20039 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20040 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20041 the current ec.TryCatchLevel, the branch goes out of an exception
20042 block. In this case, we need to use Leave and not Br.
20044 2002-07-22 Martin Baulig <martin@gnome.org>
20046 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20047 block unless the block does not always return or it is contained in
20048 another try { ... } catch { ... } block. Fixes bug #26506.
20049 Added verify-1.cs to the test suite.
20051 2002-07-22 Martin Baulig <martin@gnome.org>
20053 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20054 then we do not always return. Fixes bug #24985.
20056 2002-07-22 Martin Baulig <martin@gnome.org>
20058 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20059 lookup on a per-class level; ie. walk up the class hierarchy until we
20060 found at least one applicable method, then choose the best among them.
20061 Fixes bug #24463 and test-29.cs.
20063 2002-07-22 Martin Baulig <martin@gnome.org>
20065 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20066 return types of the methods. The return type is not part of the
20067 signature and we must not check it to make the `new' modifier work.
20068 Fixes bug #27999, also added test-147.cs.
20069 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20071 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20072 on the method's return type.
20074 2002-07-21 Martin Baulig <martin@gnome.org>
20076 * assign.cs: Make this work if the rightmost source is a constant and
20077 we need to do an implicit type conversion. Also adding a few more tests
20078 to test-38.cs which should have caught this.
20080 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20081 target in the makefile for this. The makefile.gnu is primarily intended
20082 for end-users who don't want to debug the compiler.
20084 2002-07-21 Martin Baulig <martin@gnome.org>
20086 * assign.cs: Improved the Assign class so it can now handle embedded
20087 assignments (X = Y = Z = something). As a side-effect this'll now also
20088 consume less local variables. test-38.cs now passes with MCS, added
20089 a few new test cases to that test.
20091 2002-07-20 Martin Baulig <martin@gnome.org>
20093 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20094 instructions. Fixes bug #27977, also added test-146.cs.
20096 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20098 * cs-tokenizer.cs: fixed getHex ().
20100 2002-07-19 Martin Baulig <martin@gnome.org>
20102 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20103 not Type.GetType() to lookup the array type. This is needed when
20104 we're constructing an array of a user-defined type.
20105 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20106 single-dimensional arrays, but also for single-dimensial arrays of
20109 2002-07-19 Martin Baulig <martin@gnome.org>
20111 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20112 this function is called, it's not allowed to share LocalBuilders
20113 among ILGenerators.
20115 2002-07-19 Martin Baulig <martin@gnome.org>
20117 * expression.cs (Argument.Resolve): Report an error 118 when trying
20118 to pass a type as argument.
20120 2002-07-18 Martin Baulig <martin@gnome.org>
20122 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20123 Conv_R_Un for the signed `long' type.
20125 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20127 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20128 `expr' for the temporary result, as that will fail if we do
20129 multiple resolves on the same expression.
20131 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20133 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20134 ec.TypeContainer for looking up aliases.
20136 * class.cs (TypeContainer): Remove LookupAlias from here.
20138 * decl.cs (DeclSpace); Move here.
20140 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20142 * class.cs (FindMembers): Only call filter if the constructor
20143 bulider is not null.
20145 Also handle delegates in `NestedTypes' now. Now we will perform
20146 type lookups using the standard resolution process. This also
20149 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20150 This uses Expressions (the limited kind that can be parsed by the
20151 tree) instead of strings.
20153 * expression.cs (ComposedCast.ToString): Implement, used to flag
20154 errors since now we have to render expressions.
20156 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20159 * ecore.cs (SimpleName.ToString): ditto.
20161 * cs-parser.jay: Instead of using strings to assemble types, use
20162 Expressions to assemble the type (using SimpleName, ComposedCast,
20163 MemberAccess). This should fix the type lookups in declarations,
20164 because we were using a different code path for this.
20166 * statement.cs (Block.Resolve): Continue processing statements
20167 even when there is an error.
20169 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20171 * class.cs (Event.Define): Also remove the `remove' method from
20172 the list of pending items.
20174 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20175 generate more compact code.
20177 2002-07-17 Martin Baulig <martin@gnome.org>
20179 * const.cs (Const.LookupConstantValue): Add support for constant
20180 `unchecked' and `checked' expressions.
20181 Also adding test case test-140.cs for this.
20183 2002-07-17 Martin Baulig <martin@gnome.org>
20185 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20186 check whether mi.ReturnType implements the IEnumerator interface; the
20187 `==' and the IsAssignableFrom() will fail in this situation.
20189 2002-07-16 Ravi Pratap <ravi@ximian.com>
20191 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20194 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20196 * expression.cs: fixed bug #27811.
20198 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20200 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20201 Molaro: when we are a ref, the value already contains a pointer
20202 value, do not take the address of it.
20204 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20205 * removed mb-parser.jay and mb-tokenizer.cs
20207 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20209 * expression.cs: check against the building corlib void type.
20211 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20213 * ecore.cs: fix for valuetype static readonly fields: when
20214 initializing them, we need their address, not the address of a copy.
20216 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20218 * typemanager.cs: register also enum_type in corlib.
20220 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20222 * class.cs: allow calling this (but not base) initializers in structs.
20224 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20226 * ecore.cs: make sure we compare against the building base types
20229 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20231 * typemanager.cs: fix TypeToCoreType() to handle void and object
20232 (corlib gets no more typerefs after this change).
20234 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20236 * expression.cs (ArrayCreation.EmitArrayArguments): use
20237 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20239 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20240 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20241 array indexes, the runtime actually forbids them.
20243 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20244 for array arguments here.
20246 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20247 instead of the default for ValueTypes.
20249 (New.DoEmit): Use IsValueType instead of
20250 IsSubclassOf (value_type)
20251 (New.DoResolve): ditto.
20252 (Invocation.EmitCall): ditto.
20254 * assign.cs (Assign): ditto.
20256 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20257 Statements *are* currently doing part of their resolution during
20260 Expressions do always resolve during resolve, but statements are
20261 only required to propagate resolution to their children.
20263 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20265 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20267 (LoadAssembly): Do not add the dll if it is already specified
20269 (MainDriver): Add the System directory to the link path at the end,
20270 after all the other -L arguments.
20272 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20273 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20274 ldelem.u1) and using the opposite for sbytes.
20276 This fixes Digger, and we can finally run it.
20278 * driver.cs (UnixParseOption): Move the option parsing here.
20279 (CSCParseOption): Implement CSC-like parsing of options.
20281 We now support both modes of operation, the old Unix way, and the
20282 new CSC-like way. This should help those who wanted to make cross
20283 platform makefiles.
20285 The only thing broken is that /r:, /reference: and /lib: are not
20286 implemented, because I want to make those have the same semantics
20287 as the CSC compiler has, and kill once and for all the confussion
20288 around this. Will be doing this tomorrow.
20290 * statement.cs (Unsafe.Resolve): The state is checked during
20291 resolve, not emit, so we have to set the flags for IsUnsfe here.
20293 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20295 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20296 not catch the Error_ObjectRefRequired in SimpleName (as it is
20297 possible to have a class/instance variable name that later gets
20298 deambiguated), we have to check this here.
20300 2002-07-10 Ravi Pratap <ravi@ximian.com>
20302 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20303 make static and put into Expression.
20305 (Event.Define): Register the private field of the event with the
20306 TypeManager so that GetFieldFromEvent can get at it.
20308 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20309 keep track of the private field associated with an event which
20312 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20315 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20317 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20319 * expression.cs (Binary.EmitBranchable): this routine emits the
20320 Binary expression in a branchable context. This basically means:
20321 we need to branch somewhere, not just get the value on the stack.
20323 This works together with Statement.EmitBoolExpression.
20325 * statement.cs (Statement.EmitBoolExpression): Use
20328 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20330 * statement.cs (For): Reduce the number of jumps in loops.
20332 (For): Implement loop inversion for the For statement.
20334 (Break): We can be breaking out of a Try/Catch controlled section
20335 (foreach might have an implicit try/catch clause), so we need to
20336 use Leave instead of Br.
20338 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20339 now). If the instace expression supports IMemoryLocation, we use
20340 the AddressOf method from the IMemoryLocation to extract the
20341 address instead of emitting the instance.
20343 This showed up with `This', as we were emitting the instance
20344 always (Emit) instead of the Address of This. Particularly
20345 interesting when This is a value type, as we dont want the Emit
20346 effect (which was to load the object).
20348 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20350 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20352 * statement.cs (Checked): Set the CheckedState during the resolve
20353 process too, as the ConvCast operations track the checked state on
20354 the resolve process, and not emit.
20356 * cs-parser.jay (namespace_member_declaration): Flag that we have
20357 found a declaration when we do. This is used to flag error 1529
20359 * driver.cs: Report ok when we display the help only.
20361 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20363 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20365 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20367 * cs-tokenizer.cs (define): We also have to track locally the
20368 defines. AllDefines is just used for the Conditional Attribute,
20369 but we also need the local defines for the current source code.
20371 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20373 * statement.cs (While, For, Do): These loops can exit through a
20374 Break statement, use this information to tell whether the
20375 statement is the last piece of code.
20377 (Break): Flag that we break.
20379 * codegen.cs (EmitContexts): New `Breaks' state variable.
20381 2002-07-03 Martin Baulig <martin@gnome.org>
20383 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20384 modifiers in method declarations in structs. Otherwise, you won't
20385 be able to override things like Object.Equals().
20387 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20389 * class.cs (Method, Property, Indexer): Do not allow the public
20390 modifier to be used in explicit interface implementations.
20392 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20393 override modifiers in method declarations in structs
20395 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20397 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20398 integer or real overflow, report an error
20400 2002-07-02 Martin Baulig <martin@gnome.org>
20402 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20403 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20404 to tell the runtime about our newly created System.Object and
20405 System.ValueType types.
20407 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20409 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20410 struct instead of Ldarg/Starg.
20412 2002-07-02 Martin Baulig <martin@gnome.org>
20414 * expression.cs (Indirection.Indirection): Call
20415 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20417 2002-07-02 Martin Baulig <martin@gnome.org>
20419 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20420 ValueType, call TypeManager.TypeToCoreType() on it.
20421 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20422 the OpCodes.Newarr argument.
20424 2002-07-02 Martin Baulig <martin@gnome.org>
20426 * expression.cs (Invocation.EmitCall): When compiling corlib,
20427 replace all calls to the system's System.Array type to calls to
20428 the newly created one.
20430 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20431 System.Array methods.
20432 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20433 from the system's System.Array type which must be replaced.
20435 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20437 * typemanager.cs: load unverifiable_code_ctor so we can build
20438 corlib using the correct type. Avoid using GetTypeCode() with
20440 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20441 TypeManager.object_type to allow building corlib.
20443 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20445 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20447 2002-07-01 Martin Baulig <martin@gnome.org>
20449 * class.cs: Make the last change actually work, we need to check
20450 whether `ifaces != null' to avoid a crash.
20452 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20454 * class.cs: when we build structs without fields that implement
20455 interfaces, we need to add the interfaces separately, since there is
20456 no API to both set the size and add the interfaces at type creation
20459 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20461 * expression.cs: the dimension arguments to the array constructors
20462 need to be converted if they are a long.
20464 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20466 * class.cs: don't emit ldarg.0 if there is no parent constructor
20467 (fixes showstopper for corlib).
20469 2002-06-29 Martin Baulig <martin@gnome.org>
20471 MCS now compiles corlib on GNU/Linux :-)
20473 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20474 ie. check for MethodImplOptions.InternalCall.
20476 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20477 and TypeManager.attribute_type are null, so we must explicitly check
20478 whether parent is not null to find out whether it's an attribute type.
20479 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20480 and SetBuilder, not only if the property is neither abstract nor external.
20481 This is necessary to set the MethodImplOptions on the accessor methods.
20482 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20483 SetBuilder, see Property.Emit().
20485 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20486 populate "System.Object", "System.ValueType" and "System.Attribute" since
20487 they've already been populated from BootCorlib_PopulateCoreTypes().
20489 2002-06-29 Martin Baulig <martin@gnome.org>
20491 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20492 is the NullLiteral, we also need to make sure that target_type is not
20495 2002-06-29 Martin Baulig <martin@gnome.org>
20497 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20498 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20499 before calling BootstrapCorlib_ResolveDelegate ().
20501 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20503 * statement.cs: fixed build-breaker. All tests passed ok.
20505 2002-06-27 Martin Baulig <martin@gnome.org>
20507 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20508 for System.Decimal when compiling corlib.
20510 2002-06-27 Martin Baulig <martin@gnome.org>
20512 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20513 switch blocks which contain nothing but a default clause.
20515 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20517 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20519 2002-06-27 Martin Baulig <martin@gnome.org>
20521 * ecore.cs (PropertyExpr.PropertyExpr): Call
20522 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20524 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20525 is already a TypeBuilder.
20527 2002-06-27 Martin Baulig <martin@gnome.org>
20529 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20530 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20531 the "from an array-type to System.Array" case. This makes it work
20532 when compiling corlib.
20534 2002-06-27 Martin Baulig <martin@gnome.org>
20536 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20537 non-static PropertyExpr, set its InstanceExpression. This makes
20538 the `ICollection.Count' property work in System/Array.cs.
20540 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20542 * driver.cs: Made error handling more consistent. Errors now
20543 tracked by Report class, so many methods which used to return int
20544 now return void. Main() now prints success/failure and
20545 errors/warnings message.
20547 Renamed '--probe' compiler argument to '--expect-error'. Removed
20548 the magic number return values (123 and 124). Now, if the
20549 expected error occurs, the compiler exits with success (exit value
20550 0). If the compilation completes without seeing that particular
20551 error, the compiler exits with failure (exit value 1). The
20552 makefile in mcs/errors has been changed to handle the new behaviour.
20554 * report.cs: Made 'expected error' number a property and renamed
20555 it from 'Probe' to 'ExpectedError'.
20557 * genericparser.cs: Removed error handling support, since it is
20558 now all done by Report class.
20560 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20561 class, so parse() no longer returns an int.
20563 * namespace.cs: Use Report.Error instead of GenericParser.error
20565 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20567 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20568 TypeContainer.AddOperator): At the front of the list put the
20569 explicit implementations, so they get resolved/defined first.
20571 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20573 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20574 interface type is implemented by this TypeContainer. Used during
20575 explicit interface implementation.
20577 (Property.Define, Indexer.Define, Method.Define): Validate that
20578 the given interface in the explicit implementation is one of the
20579 base classes for the containing type.
20581 Also if we are explicitly implementing an interface, but there is
20582 no match in the pending implementation table, report an error.
20584 (Property.Define): Only define the property if we are
20585 not explicitly implementing a property from an interface. Use the
20586 correct name also for those properties (the same CSC uses,
20587 although that is really not needed).
20589 (Property.Emit): Do not emit attributes for explicitly implemented
20590 properties, as there is no TypeBuilder.
20592 (Indexer.Emit): ditto.
20594 Hiding then means that we do not really *implement* a pending
20595 implementation, which makes code fail.
20597 2002-06-22 Martin Baulig <martin@gnome.org>
20599 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20600 the return value of Object.GetType(). [FIXME: we need to do this whenever
20601 we get a type back from the reflection library].
20603 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20605 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20607 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20609 * attribute.cs: Return null if we can not look up the type.
20611 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20612 the interface types found.
20614 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20615 interface types found.
20617 * typemanager.cs (GetInterfaces): Make this routine returns alll
20618 the interfaces and work around the lame differences between
20619 System.Type and System.Reflection.Emit.TypeBuilder in the results
20620 result for GetInterfaces.
20622 (ExpandInterfaces): Given an array of interface types, expand and
20623 eliminate repeated ocurrences of an interface. This expands in
20624 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20627 2002-06-21 Martin Baulig <martin@gnome.org>
20629 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20632 2002-06-21 Martin Baulig <martin@gnome.org>
20634 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20635 and called with one of the core types, return the corresponding typebuilder for
20638 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20641 2002-06-21 Martin Baulig <martin@gnome.org>
20643 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20644 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20645 (Expression.ConvertReferenceExplicit): Likewise.
20647 * expression.cs (ElementAccess.DoResolve): Likewise.
20648 (ElementAccess.DoResolveLValue): Likewise.
20650 2002-06-10 Martin Baulig <martin@gnome.org>
20652 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20653 add the "value" parameter to the parameter list.
20655 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20658 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20660 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20661 the argument to an int, uint, long or ulong, per the spec. Also
20662 catch negative constants in array creation.
20664 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20666 * class.cs: do not allow the same interface to appear twice in
20667 the definition list.
20669 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20671 * ecore.cs: don't use ldlen with System.Array.
20673 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20675 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20677 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20679 * modifiers.cs: produce correct field attributes for protected
20680 internal. Easy fix so miguel can work on ther harder stuff:-)
20682 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20684 * pending.cs: New file. Move the code from class.cs here.
20685 Support clearning the pending flag for all methods (when not doing
20686 explicit interface implementation).
20688 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20690 * rootcontext.cs: added a couple more types needed to bootstrap.
20692 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20694 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20695 constructor in the type, instead of any constructor in the type
20696 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20697 a bug in the Mono runtime when applying the params attribute).
20699 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20700 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20702 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20704 * expression.cs (Unary.ResolveOperator): Use TypeManager
20705 to resolve the type.
20707 2002-06-13 Ravi Pratap <ravi@ximian.com>
20709 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20712 * enum.cs (AddEnumMember): Add support to store the attributes associated
20713 with each member too.
20715 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20716 field builders too - this takes care of the enum member case.
20718 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20720 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20721 address-of operator on both value types and pointers.
20723 2002-06-10 Martin Baulig <martin@gnome.org>
20725 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20726 PropertyBuilder to the `property_builders' list.
20728 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20729 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20730 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20731 find any indexers which are inherited from an interface.
20733 2002-06-09 Martin Baulig <martin@gnome.org>
20735 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20736 the same type as the constant if necessary. There's also a test-130.cs
20739 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20741 * typemanager.cs (TypeManager.ChangeType): Previously known as
20742 Enum.ChangeEnumType().
20744 2002-06-09 Martin Baulig <martin@gnome.org>
20746 * expression.cs (Cast.TryReduce): Added support for consts.
20748 2002-06-08 Ravi Pratap <ravi@ximian.com>
20750 * class.cs (Accessor): Hold attributes information so we can pass
20753 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20754 Modify to pass in attributes attached to the methods.
20756 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20758 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20759 to handle the Accessor kind :-)
20761 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20763 2002-06-08 Martin Baulig <martin@gnome.org>
20765 * expression.cs (Unary.TryReduceNegative): Added support for
20768 2002-06-08 Martin Baulig <martin@gnome.org>
20770 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20771 name can't be found in the `defined_names' - the caller will do a
20772 MemberLookup in this case and thus find methods in System.Enum
20773 such as Enum.IsDefined().
20775 2002-06-08 Martin Baulig <martin@gnome.org>
20777 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20778 Convert.ChangeType() which works with TypeBuilder created types.
20779 (Enum.LookupEnumValue, Enum.Define): Use it here.
20781 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20782 `TypeBuilder.BaseType != null' check.
20783 (TypeContainer.FindMembers): Only lookup parent members if we
20784 actually have a parent.
20785 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20786 (ConstructorInitializer.Resolve): Likewise.
20788 * interface.cs (Interface.FindMembers): Added
20789 `TypeBuilder.BaseType != null' check.
20791 * rootcontext.cs (RootContext.ResolveCore): Added
20792 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20793 classes_second_stage.
20795 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20796 debug_type and trace_type when compiling with --nostdlib.
20798 2002-06-07 Martin Baulig <martin@gnome.org>
20800 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20801 (AddField): Set it to true when adding a non-static field.
20802 (DefineType): Use `have_nonstatic_fields' to find out whether we
20803 have non-static fields, not `Fields != null'.
20805 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20807 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20808 dereferencing a null on the static-field code path)
20810 2002-05-30 Martin Baulig <martin@gnome.org>
20812 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20813 to take command line arguments. Use reflection to call the new
20814 custom `Initialize' function on the symbol writer and pass it the
20815 command line arguments.
20817 * driver.cs (--debug-args): New command line argument to pass command
20818 line arguments to the symbol writer.
20820 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20822 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20823 the target type for indexers and properties. Thanks to Joe for
20826 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20828 * typemanager.cs (MethodFlags): returns the method flags
20829 (Obsolete/ShouldIgnore) that control warning emission and whether
20830 the invocation should be made, or ignored.
20832 * expression.cs (Invocation.Emit): Remove previous hack, we should
20833 not do this on matching a base type, we should do this based on an attribute
20835 Only emit calls to System.Diagnostics.Debug and
20836 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20837 on the command line.
20839 * rootcontext.cs: Global settings for tracing and debugging.
20841 * cs-tokenizer.cs (define): New utility function to track
20842 defines. Set the global settings for TRACE and DEBUG if found.
20844 2002-05-25 Ravi Pratap <ravi@ximian.com>
20846 * interface.cs (Populate*): Pass in the TypeContainer as well as
20847 the DeclSpace as parameters so that we can create EmitContexts and
20848 then use that to apply attributes etc.
20850 (PopulateMethod, PopulateEvent, PopulateProperty)
20851 (PopulateIndexer): Apply attributes everywhere.
20853 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20856 (ApplyAttributes): Update accordingly.
20858 We now apply interface attributes for all members too.
20860 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20862 * class.cs (Indexer.Define); Correctly check if we are explicit
20863 implementation (instead of checking the Name for a ".", we
20864 directly look up if the InterfaceType was specified).
20866 Delay the creation of the PropertyBuilder.
20868 Only create the PropertyBuilder if we are not an explicit
20869 interface implementation. This means that explicit interface
20870 implementation members do not participate in regular function
20871 lookups, and hence fixes another major ambiguity problem in
20872 overload resolution (that was the visible effect).
20874 (DefineMethod): Return whether we are doing an interface
20877 * typemanager.cs: Temporary hack until we get attributes in
20878 interfaces (Ravi is working on that) and we get IndexerName
20879 support in interfaces.
20881 * interface.cs: Register the indexers as properties.
20883 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20884 warning, I have verified that this is a bug in the .NET runtime
20885 (JavaScript suffers of the same problem).
20887 * typemanager.cs (MemberLookup): When looking up members for
20888 interfaces, the parent of an interface is the implicit
20889 System.Object (so we succeed in searches of Object methods in an
20890 interface method invocation. Example: IEnumerable x; x.ToString
20893 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20895 * class.cs (Event): Events should also register if they do
20896 implement the methods that an interface requires.
20898 * typemanager.cs (MemberLookup); use the new GetInterfaces
20901 (GetInterfaces): The code used to lookup interfaces for a type is
20902 used in more than one place, factor it here.
20904 * driver.cs: Track the errors at the bottom of the file, we kept
20907 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20908 instance if the method we are calling is static!
20910 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20912 * attribute.cs (ApplyAttributes): Make this function filter out
20913 the IndexerName attribute (as that attribute in reality is never
20914 applied) and return the string constant for the IndexerName
20917 * class.cs (TypeContainer.Emit): Validate that all the indexers
20918 have the same IndexerName attribute, and if so, set the
20919 DefaultName attribute on the class.
20921 * typemanager.cs: The return value might contain other stuff (not
20922 only methods). For instance, consider a method with an "Item"
20923 property and an Item method.
20925 * class.cs: If there is a problem with the parameter types,
20928 2002-05-24 Ravi Pratap <ravi@ximian.com>
20930 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20931 looks at user defined conversion after making a call to
20932 StandardConversionExists - we need this for overload resolution.
20934 * expression.cs : Update accordingly the various method calls.
20936 This fixes 2 bugs filed against implicit user defined conversions
20938 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20940 * statement.cs: Track the result of the assignment.
20942 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20944 * expression.cs (MemberAccess): Improved error reporting for
20945 inaccessible members.
20947 2002-05-22 Martin Baulig <martin@gnome.org>
20949 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20950 itself with debugging support.
20952 2002-05-22 Martin Baulig <martin@gnome.org>
20954 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20955 Removed, this isn't needed anymore.
20957 2002-05-20 Martin Baulig <martin@gnome.org>
20959 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20960 be underlying type for an enum.
20962 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20964 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20965 that splits out the loading of just the core types.
20967 * rootcontext.cs (ResolveCore): Split the struct resolution in
20968 two, so we can load the enumeration underlying types before any
20971 * expression.cs (Is): Bandaid until we fix properly Switch (see
20972 bug #24985 for details).
20974 * typemanager.cs (ImplementsInterface): The hashtable will contain
20975 a null if there are no interfaces implemented.
20977 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20979 * cs-parser.jay (indexer_declarator): It is fine to have array
20982 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20984 * typemanager.cs: (RegisterBuilder): New function used to register
20985 TypeBuilders that implement interfaces. Since
20986 TypeBuilder.GetInterfaces (as usual) does not work with lame
20988 (AddUserType): register interfaces.
20990 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20991 dealing with TypeBuilder. Also, arrays are showing up as
20992 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20993 methods can not be invoked on them!
20995 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20996 (ImplicitReferenceConversionExists): Split out from
20997 StandardConversionExists.
20999 * expression.cs (As): We were only implementing one of the three
21000 cases for the as operator. We now implement them all.
21001 (Is): Implement the various other cases for Is as well.
21003 * typemanager.cs (CACHE): New define used to control if we want or
21004 not the FindMembers cache. Seems to have a negative impact on
21005 performance currently
21007 (MemberLookup): Nested types have full acess to
21008 enclosing type members
21010 Remove code that coped with instance/static returns for events, we
21011 now catch this in RealFindMembers.
21013 (RealFindMembers): only perform static lookup if the instance
21014 lookup did not return a type or an event.
21016 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21018 * assign.cs (CompoundAssign): We pass more semantic information
21019 now to Compound Assignments than we did before: now we have all
21020 the information at hand, and now we resolve the target *before* we
21021 do the expression expansion, which allows the "CacheValue" method
21022 to have the effect we intended (before, a [x] += 1 would generate
21023 two differen ArrayAccess expressions from the ElementAccess,
21024 during the resolution process).
21026 (CompoundAssign.DoResolve): Resolve target and original_source here.
21028 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21030 * expression.cs (ArrayAccess): dropped debugging information.
21032 * typemanager.cs: Small bug fix: I was always returning i_members,
21033 instead of one of i_members or s_members (depending on which had
21036 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21037 method is invoked before any code generation takes place, and it
21038 is a mechanism to inform that the expression will be invoked more
21039 than once, and that the method should use temporary values to
21040 avoid having side effects
21042 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21044 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21047 * expression.cs (Indirection, ArrayAccess): Add support for
21048 CacheTemporaries in these two bad boys.
21050 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21051 ldobj or ldind_ref.
21052 (StoreFromPtr): Handle stobj as well.
21054 * expression.cs (UnaryMutator): Share more code.
21056 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21057 down: I was not tracking the Filter function as well, which
21058 was affecting the results of the cache.
21060 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21062 * attribute.cs: Remove the hack to handle the CharSet property on
21065 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21067 * attribute.cs (DoResolve): More uglyness, we now only try to
21068 resolve the attribute partially, to extract the CharSet
21069 information (only if we are a StructLayout attribute). Otherwise
21071 (GetExtraTypeInfo): Add some code to conditionally kill in the
21072 future this. I am more and more convinced that the .NET
21073 framework has special code to handle the attribute setting on
21076 * expression.cs (IsParamsMethodApplicable): Revert my previous
21077 foreach change here, it was wrong.
21079 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21081 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21082 (pp_expr): do not abort on unknown input, just return.
21083 (eval): abort if there are pending chars.
21085 * attribute.cs (Attribute.Resolve): Positional parameters are
21086 optional. Deal with that case.
21088 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21089 the Ansi/Unicode/Auto information for the type.
21091 (TypeContainer.DefineType): instantiate the EmitContext here, as
21092 we will be using it during the type definition (to resolve
21093 attributes) and during the emit phase.
21095 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21096 to pull type information out of the attributes
21098 (Attribute.Resolve): track the constructor builder, and allow for
21099 multiple invocations (structs and classes will use this).
21101 * ecore.cs (MemberLookupFinal): new version with all the
21102 parameters customizable.
21104 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21105 constructors. Return if the result value is null (as the error
21106 would have been flagged already by MemberLookupFinal)
21108 Do not allow instances of abstract classes or interfaces to be
21111 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21112 We have to compare the assembly property here when dealing with
21113 FamANDAssem and Assembly access modifiers, because we might be
21114 creating an assembly from *modules* (that means that we are not
21115 getting TypeBuilders for types defined in other modules that are
21116 part of this assembly).
21118 (Method.Emit): If the method is marked abstract and has a body,
21121 (TypeContainer.DefineMembers): If both the defined member and the
21122 parent name match are methods, then do not emit any warnings: let
21123 the Method.Define routine take care of flagging warnings. But if
21124 there is a mismatch (method overrides something else, or method is
21125 overriwritten by something, then emit warning).
21127 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21128 set to null, this means `do not check for the return type on the
21131 (Method.Define): set the return type for the method signature to
21132 null, so that we get methods with the same name and parameters and
21133 different return types. This is used to flag warning 114 (you are
21134 hiding a method, and you probably want to use the new/override
21137 * typemanager.cs (MemberLookup): Implemented proper access
21138 control, closing a long standing set of bug reports. The problem
21139 was that the Framework only has two bits: Public and NonPublic,
21140 and NonPublic includes private and protected methods, but we need
21141 to enforce the FamANDAssem, FamOrAssem and Family.
21143 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21145 * statement.cs (GotoCase): Return true: Ammounts to giving up
21146 knowledge on whether we return or not, and letting the other case
21147 be responsible for it.
21149 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21151 * driver.cs: Do not load directories for each file processed, only
21152 do it if there is a pattern.
21154 * ecore.cs: Report readonly assigns here as well, as we might have
21155 been resolved only by MemberAccess.
21157 (SimpleName.SimpleNameResolve): Also be useful for LValue
21158 resolution. We need this to propagate assign to local readonly variables
21160 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21161 do not want to reuse potential criteria memory.
21163 * class.cs (MyEventBuilder): Set reflected_type;
21165 * ecore.cs (Constantify): Added support for constifying bools.
21167 (RootContext.LookupType): Added a cache for values looked up in
21168 the declaration space.
21170 * typemanager.cs (FindMembers): Now is a front-end to
21171 RealFindMembers, and provides a two-level hashtable-based cache to
21174 15% performance improvement: from 22.5 to 19.2 seconds.
21176 * expression.cs (IsParamsMethodApplicable): use foreach.
21177 (Invocation.DoResolve): ditto.
21178 (New.DoResolve): ditto.
21179 (ArrayCreation.DoResolve): ditto.
21181 * ecore.cs (FindMostEncompassingType): use foreach.
21183 * delegate.cs (NewDelegate.DoResolve): Use foreach
21185 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21186 (RemoveMethods): use foreach.
21188 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21189 nested foreach statements instead of for, and also break out of
21190 the inner loop once a match is found.
21192 (Invocation.OverloadResolve): Use foreach, simplify the code.
21194 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21196 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21197 we actually unwrap the expression to allow for extra information
21200 * expression.cs: Use Shr_Un on unsigned operations.
21202 2002-05-08 Ravi Pratap <ravi@ximian.com>
21204 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21205 applicable operators was not being considered correctly. This closes
21206 the bug Miguel reported.
21208 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21210 * attribute.cs: check that the type derives from System.Attribute
21211 and report the correct error in that case (moved the duplicate code to
21212 its own method, too).
21214 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21216 * attribute.cs: lookup attribute type name as the spec says: first the
21217 bare attribute name and then name + "Attribute" (nant compiles with
21218 mcs after this fix).
21220 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21222 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21223 Because of the way we parse things, we should try to see if a
21224 UIntConstant can fit in an integer.
21226 2002-05-07 Ravi Pratap <ravi@ximian.com>
21228 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21229 when we are in an explicit context.
21231 (ConvertReferenceExplicit): When converting from Iface type S to Class
21232 T make sure the rules are implemented as an OR.
21234 * parameter.cs (ParameterType): Make it a property for now although the
21235 purpose really isn't anything immediate.
21237 * expression.cs (Is*Applicable): Do better checking on the parameter type
21238 of a ref/out parameter. The ones from the system assemblies are already
21239 marked with the correct type so we don't need to do any correction.
21241 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21242 the object type is standard too so include that.
21244 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21246 * ecore.cs (StandardConversionExists): Augment with missing code:
21247 deal with IntConstant, LongConstants and Enumerations.
21249 * assign.cs: Report the error, instead of failing silently
21251 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21252 typecontainer that they are declared, because the
21253 typecontainer/namespace will have the list of using clauses that
21254 need to be applied.
21256 Assembly Attributes were escaping the normal registration
21259 (EmitCode): Apply attributes within an EmitContext that represents
21260 the container they were declared on.
21262 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21264 2002-05-06 Ravi Pratap <ravi@ximian.com>
21266 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21267 Revamp completely - make much cleaner as we now operate only
21270 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21271 to implement the logic detailed in the spec more correctly.
21273 (UserDefinedConversion): Update accordingly.
21275 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21277 * statement.cs: Return flow analysis information up.
21279 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21282 (token): Do not consume an extra character before calling
21285 2002-05-06 Piers Haken <piersh@friskit.com>
21287 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21289 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21291 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21292 EmitContext during the instance constructor initializer
21293 resolution, to stop access to instance variables.
21295 This is mandated by the spec, last paragraph of the `constructor
21296 initializers' section.
21298 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21300 * cs-parser.jay, class.cs (Accessor): new class used to represent
21301 an accessor (get or set). In the past we used `null' to represent
21302 a missing accessor. But this is ambiguous because there was no
21303 way to tell in abstract indexers/properties if one of them was
21306 Now there is a way of addressing that.
21308 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21309 instead of FindMembers.
21311 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21312 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21314 * attribute.cs: Treat indexers and properties as the same in terms
21315 of applying attributes
21317 * ecore.cs (FindMostEncompassedType): Use statically initialized
21318 EmptyExpressions()s like we do elsewhere to avoid creating useless
21319 objects (and we take this out of the tight loop).
21321 (GetConversionOperators): Move the code to extract the actual
21322 operators to a separate routine to clean things up.
21324 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21326 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21327 events are always registered FieldBuilders.
21329 * class.cs (FieldBase): New class shared by Fields
21331 * delegate.cs: If we are a toplevel delegate, use our full name.
21332 If we are a nested delegate, then only use our tail name.
21334 2002-05-02 Ravi Pratap <ravi@ximian.com>
21336 * expression.cs (IsApplicable): Ensure that we add the "&" to
21337 ref/out types before comparing it with the type of the argument.
21339 (IsParamsMethodApplicable): Ditto.
21341 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21344 * delegate.cs : Handle the case when we have more than one applicable
21345 method. Flag an error only when we finish checking all.
21347 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21349 * expression.cs: Add support for boolean static initializers.
21351 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21353 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21355 * parameter.cs (ComputeParameterTypes,
21356 ComputeAndDefineParameterTypes): Better error handling: now we
21357 clear the `types' cache if we fail during any of the type lookups.
21358 We also return the status code correctly to our caller
21360 * delegate.cs: If we fail to define a delegate, abort the extra
21363 * expression.cs (Binary.ResolveOperator): for
21364 operator==(object,object) and operator !=(object, object) we also
21365 have to verify that there is an implicit conversion from one to
21368 (ArrayAccess.DoResolve): Array Access can operate on
21371 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21373 * assign.cs (CompoundAssign): A new class used as a "flag" that
21374 the assignment actually is happening as part of a compound
21375 assignment operator.
21377 During compound assignment, a few new rules exist to enable things
21384 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21385 to the type of x) if y is implicitly convertible to the type of x,
21386 and the operator is a builtin operator and the return type of the
21387 operator is explicitly convertible to the type of x.
21389 * rootcontext.cs: Reset warning level to 2. 4 catches various
21390 "interesting" features in mcs, we must clean this up at some
21391 point, but currently am trying to kill other bugs ;-)
21393 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21394 in container classes as well.
21396 * expression.cs (Binary.ResolveOperator): Handle string case
21397 before anything else (as operator overloading does emit an error
21398 before doing anything else).
21400 This code could go away when we move to a table driven model, but
21401 i could not come up with a good plan last night.
21403 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21405 * typemanager.cs (CSharpName): reimplementation using regex.
21406 * class.cs: added null check for fields in Emit
21407 * rootcontext.cs: set warninglevel to 4
21409 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21411 * typemanager.cs (CSharpName): reimplemented with Lupus
21414 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21416 * statement.cs (If): correclty implement Resolve, because we were
21417 not catching sem errors in there. The same process is needed
21419 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21422 (Statement.Warning_DeadCodeFound): Factorize code.
21423 (While): Report dead code here too.
21425 (Statement): Added Resolve virtual method to allow
21426 for resolution split from the emit code.
21428 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21430 * statement.cs (EmitBoolExpression): No longer try to resolve the
21432 (MakeBoolean): New utility function that resolve, implicitly
21433 converts to boolean and tags the expression.
21436 (If, Do): Implement dead code elimination.
21437 (While): Implement loop inversion
21439 (Do, While, For, If): Resolve the expression prior to calling our
21442 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21445 - added method Report28 (warning: program has more than one entry point)
21446 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21447 - modified method Method.Define, the part at the end of the method
21449 * rootcontext.cs: added static public Location EntryPointLocation;
21451 * ../errors/cs0028.cs : Add test case for the above warning.
21454 - modified method CSharpName to allow arrays of primitive type to
21455 be printed nicely (e.g. instead of System.Int32[][] it now prints
21457 - added method CSharpSignature: returns the signature of a method
21458 in string format to be used in reporting errors, warnings, etc.
21460 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21463 2002-04-26 Ravi Pratap <ravi@ximian.com>
21465 * delegate.cs (Define): Fix extremely silly bug where I was
21466 setting the type of the 'object' parameter of the BeginInvoke
21467 method to System.IAsyncResult instead of System.Object ;-)
21469 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21471 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21474 (Constructor.Emit): return if we fail to initialize the
21475 constructor. Another door closed!
21477 * expression.cs (New.DoResolve): Improve error message (from -6 to
21478 1501). Use DeclaredOnly lookup to find the exact constructor.
21480 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21481 loop. This is useful.
21483 * cs-parser.jay: Adjust the default parameters so that destructors
21484 have the proper signature.
21486 2002-04-26 Martin Baulig <martin@gnome.org>
21488 * driver.cs (LoadAssembly): If `assembly' contains any characters
21489 which are only valid in path names and not in assembly names
21490 (currently slash, backslash and point), use Assembly.LoadFrom ()
21491 instead of Assembly.Load () on the `assembly' (before iteration
21492 over the link_paths).
21494 2002-04-26 Martin Baulig <martin@gnome.org>
21496 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21498 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21500 * class.cs (Property): use the new typemanager.MemberLookup
21502 (TypeContainer.MemberLookup): Implement using the
21503 TypeManager.MemberLookup now.
21505 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21506 and return MemberInfos, so that these can be used without an
21507 EmitContext (what we had before).
21509 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21511 * expression.cs: Fix the case where the argument to params if the
21512 type of the params. I omitted handling this before. Fixed
21514 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21516 * driver.cs: Call BootCorlib_PopulateCoreType
21518 * class.cs (Property.CheckBase): Check for properties only, not
21521 * interface.cs: Temporary hack: try/catch around the
21522 CustomAttributeBuilder, because I am getting an exception that I
21525 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21526 types whose definitions are required to be there (attributes are
21527 defined before standard types).
21529 Compute definitions as we boot the various types, as they are used
21530 immediately (value_type class will need object_type, but if we do
21531 not initialize object_type, we will pass a null, which will let
21532 the runtime pick the System.Object from the existing corlib, which
21533 is not what we want).
21535 2002-04-22 Patrik Torstensson <totte@labs2.com>
21537 * cs-tokenizer.cs: fixed a number of trim() issues.
21539 2002-04-22 Ravi Pratap <ravi@ximian.com>
21541 * expression.cs (Argument.Type): Ensure that we return the correct
21542 type when we have out or ref parameters [in which case we
21545 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21547 * class.cs (Property, Indexer): Allow extern modifier in there.
21549 * typemanager.cs (InitBaseTypes): Initializes object_type and
21550 value_type, since those will be used early on during the bootstrap
21551 process to compile corlib.
21553 (InitCoreTypes): Move code from here to InitBaseTypes.
21555 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21557 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21558 single-dimension arrays as using the ldlen opcode.
21560 Daniel Lewis discovered this optimization.
21562 * typemanager.cs: Add signature for System.Array::get_Length
21564 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21566 * statement.cs: report the error when the foreach does not apply to an
21567 array nor a collection.
21569 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21571 * expression.cs: Add implicit conversions to the operator ~.
21573 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21575 * typemanager.cs: Locate the decimal constructor.
21577 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21579 * attribute.cs: use the new property of TypeOf.
21580 * expression.cs: added 'get' property around typearg.
21582 These changes fix a build breaker reported by NickD. Is this the
21583 correct way to fix? If not, please, revert my changes and make it
21586 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21588 * attribute.cs: Add support for typeof in attribute invocations.
21589 I am not sure that this is right though.
21591 2002-04-14 Duncan Mak <duncan@ximian.com>
21593 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21594 Binary.Operator.Division case.
21596 2002-04-13 Ravi Pratap <ravi@ximian.com>
21598 * class.cs (DefineType): Ensure that we do a proper check on
21599 attribute types and also register it with the TypeManager.
21601 (TypeContainer.Targets): The default for attribute types is
21602 AttributeTargets.All.
21604 * attribute.cs (ApplyAttributes): Registering the attribute type
21605 is done elsewhere, not when we discover we have a Usage attribute.
21607 2002-04-12 Ravi Pratap <ravi@ximian.com>
21609 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21610 and get rid of is_delegate parameter.
21612 * everywhere : update.
21614 2002-04-12 Ravi Pratap <ravi@ximian.com>
21616 * cs-parser.jay (compilation_unit): Revamp completely to use
21617 some new ideas that I got from Rhys' grammar to solve the problems
21618 with assembly level attributes.
21620 (outer_declaration): New grammar production.
21622 (attribute_sections): Add.
21624 (opt_attributes): Base on attribute_sections
21626 (namespace_declaration): Allow opt_attributes to tackle the case
21627 when we have assembly level attributes - we are clever in this
21630 * attribute.cs (ApplyAttributes): Do not worry about assembly
21631 attributes in the non-global context.
21633 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21634 instead of SetGlobalAttributes.
21636 * class.cs, rootcontext.cs : Ensure we define and generate
21637 attribute types before anything else.
21639 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21640 and flag the new error -20 for the case when the attribute type
21641 does not have valid targets specified. csc does not catch this.
21643 * ../errors/errors.txt : update for error # -20
21645 2002-04-11 Ravi Pratap <ravi@ximian.com>
21647 * support.cs (InternalParameters.ParameterModifier): Do some null
21648 checking and return sane values.
21650 * class.cs (Method.Define): If we are a PInvoke method, ensure
21651 that we are static and extern. Report error # 601
21653 * ../errors/cs0601.cs : Add test case for the above error.
21655 2002-04-07 Ravi Pratap <ravi@ximian.com>
21657 * rootcontext.cs (attribute_types): We need to keep type of
21658 all attribute types separately and emit code for them first.
21660 (RegisterAttribute) : Implement.
21662 * class.cs (DefineType): Check if the current Type is a custom
21663 attribute type and register it accordingly.
21665 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21666 adding the first attribute twice and rename to
21668 (SetGlobalAttributes): this.
21670 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21673 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21674 if we are processing global arguments. Hmm, I am unsure of this.
21676 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21678 * expression.cs: added static array of strings to avoid calling
21679 Enum.ToString () for Operator in Binary. Significant recover of
21682 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21684 * class.cs (FindMembers): Allow the Builders of the various
21685 members to be null. If they are skip them. This only happens
21686 during the PInvoke declaration.
21688 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21690 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21691 failure, so we do not keep going afterwards.
21693 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21694 wanted to pass `false' as the `is_delegate' argument. If this is
21695 the case, why not use delegate_type == null to mean `is_delegate =
21696 false' and anything else as is_delegate = true.
21698 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21700 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21701 code for the section, not the beginning of the tests.
21703 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21705 * cfold.cs: Handle operator + (Enum x, Underlying x)
21707 * expression.cs (Binary): same. Warn about errors where we have
21708 Enum/Enum in operator + as well.
21710 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21713 - added support for switch(bool)
21714 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21715 - add TableSwitchEmit() to handle table-based switch statements
21717 2002-04-05 Ravi Pratap <ravi@ximian.com>
21719 * expression.cs (Invocation.OverloadResolve): Factor out code which
21720 does parameter compatibility checking with arguments so that we can
21721 re-use the code even from Delegate.VerifyApplicability
21723 (VerifyArgumentsCompat): Move above code here.
21725 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21726 and instead make a call to the above method.
21728 2002-03-31 Ravi Pratap <ravi@ximian.com>
21730 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21731 We use it to keep track of classes which are attribute types.
21733 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21735 * delegate.cs (Delegate.Define): Correctly define the types in the
21736 presence of fixed and array parameters.
21738 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21741 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21742 include NonPublic after the first iteration.
21744 * class.cs (Indexer.CheckBase): Only check if both parents are
21747 * cs-parser.jay (accessor_body): If empty, set to null.
21749 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21750 same code path here to resolve constants names that we did have in
21751 MemberAccess.DoResolve. There is too much code duplicated here.
21753 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21755 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21757 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21760 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21761 tokens, numbers and strings.
21763 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21766 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21767 asyncronous parameters and the regular parameters.
21769 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21770 specify the target directory.
21772 * expression.cs: (This.DoResolve): Simplify
21773 (As.Emit): Optimize, do not generate IsInst if the expression is
21774 always of the given type.
21776 (Is.DoResolve): Bug fix, we were reporting both always/never for
21779 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21780 creating too many unnecessary arrays.
21782 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21784 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21785 fields instead of rolling our own initializer. Takes care of all
21786 implicit conversions, and drops unnecessary static checks/argument.
21788 2002-03-31 Dick Porter <dick@ximian.com>
21790 * driver.cs: use the GetDirectories() return values properly, and
21791 use "/" as path separator.
21793 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21795 * expression.cs (Unary): Optimize - - expr into expr.
21796 (Binary): Optimize a + (-b) into a -b.
21798 * codegen.cs (CodeGen): Made all methods static.
21800 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21804 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21805 TypeBuilder property.
21807 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21810 * tree.cs: Removed the various RecordXXXX, and replaced with a
21811 single RecordDecl. Removed all the accessor methods, and just
21812 left a single access point Type
21814 * enum.cs: Rename DefineEnum to DefineType.
21816 * decl.cs: New abstract method `DefineType' used to unify the
21817 Defines for Enumerations, Interfaces, TypeContainers and
21820 (FindType): Moved LookupInterfaceOrClass here. Moved the
21821 LookupBaseClasses method that used to live in class.cs and
21822 interface.cs here, and renamed to FindType.
21824 * delegate.cs: Implement DefineType. Take advantage of the
21825 refactored pattern for locating the parent builder without taking
21826 the parent_builder argument (which we know does not work if we are
21827 nested, and triggering a toplevel definition).
21829 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21831 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21832 accessibility of a member has changed during override and report
21835 * class.cs (Method.Define, Property.Define): Only complain on
21836 overrides if the method is private, any other accessibility is
21837 fine (and since we just checked the permission is the same, we are
21840 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21841 and elif are processed always. The other pre-processing
21842 directives are only processed if we are "taking" the path
21844 2002-03-29 Martin Baulig <martin@gnome.org>
21846 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21847 current location is not Null.
21849 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21850 a separate method so we can profile it.
21852 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21853 `span.Seconds' are just seconds, but no minutes or hours.
21854 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21856 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21858 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21859 Remove the gratuitous set of Final:
21861 // If an interface implementation, then we can set Final.
21862 if (((flags & MethodAttributes.Abstract) == 0) &&
21863 implementing.DeclaringType.IsInterface)
21864 flags |= MethodAttributes.Final;
21866 I do not know what I was smoking when I used that.
21869 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21870 step into fixing the name resolution issues for delegates and
21871 unifying the toplevel name resolution.
21873 2002-03-28 Martin Baulig <martin@gnome.org>
21875 * class.cs (Method.Emit): If we have a symbol writer, call its
21876 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21877 tell it about the current method.
21879 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21880 writer that we're going to emit the first byte of IL code for a new
21881 statement (a new source line).
21882 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21883 EmitContext.Mark() before emitting any code.
21885 * location.cs (SymbolDocument): Return null when we're Null.
21887 * statement.cs (Statement): Moved the `Location loc' variable here.
21888 (Statement.EmitBoolExpression): If we have a symbol writer, call
21889 ec.Mark() before emitting any code to tell it that we're at the
21890 beginning of a new statement.
21891 (StatementExpression): Added `Location' argument to the constructor.
21892 (Block): Added public readonly variable `StartLocation' and public
21893 variable `EndLocation'. The latter is to be set using SetEndLocation().
21894 (Block): Added constructor which takes a start and end location.
21895 (Block.SetEndLocation): New method. This sets the end location.
21896 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21897 local variables we create.
21898 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21899 each statement and do also mark the begin and end of the block.
21901 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21902 tell it the current lexer.Location, use Location.Null for the end of the
21904 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21905 current block, set its end location using SetEndLocation().
21906 (statement_expression): StatementExpression constructor now takes the
21907 lexer.Location as additional argument.
21908 (for_statement, declare_local_variables): Likewise.
21909 (declare_local_variables): When creating a new implicit block, use the
21910 new Block constructor and pass it the lexer.Location.
21912 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21914 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21915 members also on the parent interfaces recursively.
21917 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21919 * report.cs: Use new formats, since Gonzalo finished the missing
21922 * expression.cs (Binary.ResolveOperator): added missing operator|
21923 operator& and operator^ for bool/bool.
21925 * cs-parser.jay: CheckDef now takes a Location argument that is
21926 used to report errors more precisly (instead of reporting the end
21927 of a definition, we try to track something which is a lot closer
21928 to the source of the problem).
21930 * cs-tokenizer.cs: Track global token use, so we can properly flag
21931 the use of #define/#undef after the first token has been seen.
21933 Also, rename the reportXXXX to Error_DescriptiveName
21935 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21936 TypeContainer, so that Enum and Interface can use this too.
21938 * class.cs (TypeContainer.LookupInterfaceOrClass,
21939 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21940 `builder' argument. Typically this was used to pass the parent
21941 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21944 The problem is that a nested class could trigger the definition of
21945 a toplevel class, and the builder would be obviously wrong in that
21948 So we drop this argument, and we compute dynamically the
21949 TypeBuilder/ModuleBuilder (the correct information was available
21950 to us anyways from DeclSpace.Parent)
21952 * interface.cs (Interface.DefineInterface): Drop builder
21953 parameter cleanup like class.cs
21955 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21958 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21961 (Try.Emit): Propagate the returns value from the statement.
21963 (Return.Emit): Even if we are leavning
21965 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21967 * modifiers.cs: Fix the computation of MethodAttributes flags.
21969 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21971 * driver.cs: allow compilation of files that start with '/'.
21972 Add a default case when checking the argument of --target.
21974 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21976 * interface.cs: Implement the same search algorithm for types in
21977 the interface code.
21979 * delegate.cs: Do not allow multiple definition.
21981 * Recovered ChangeLog that got accidentally amputated
21983 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21985 * rootcontext.cs: Load manually enum to allow core classes to
21986 contain enumerations.
21988 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21989 Update to new static methods in TypeManager.
21991 * typemanager.cs (GetMethod, GetConstructor): Use our
21992 implementation of FindMembers to find the members, since during
21993 corlib compilation, the types are TypeBuilders and GetMethod and
21994 GetConstructor do not work.
21996 Make all methods in TypeManager static.
21998 (InitCodeHelpers): Split the functionality from
21999 the InitCodeTypes function.
22001 * driver.cs: Call InitCodeHelpers after we have populated the
22004 * cs-parser.jay (delegate_declaration): we did not used to compute
22005 the delegate name correctly for void delegates.
22007 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22009 * rootcontext.cs (RootContext): Init the interface_resolve_order
22010 and type_container_resolve_order always.
22012 (ResolveCore, BootstrapCorlib_ResolveClass,
22013 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22014 compiler when compiling with --nostdlib
22016 * class.cs (TypeContainer.DefineType): Check that our parent is
22017 not null. This test is most important when we are bootstraping
22020 * codegen.cs: Split out the symbol writing code.
22022 2002-03-25 Martin Baulig <martin@gnome.org>
22024 * driver.cs (-g): Made -g an alias for --debug.
22026 2002-03-24 Martin Baulig <martin@gnome.org>
22028 * codegen.cs (SymbolWriter): New public variable. Returns the
22029 current symbol writer.
22030 (CodeGen): Added `bool want_debugging_support' argument to the
22031 constructor. If true, tell the ModuleBuild that we want debugging
22032 support and ask it for the ISymbolWriter.
22033 (Save): If we have a symbol writer, call it's Close() method after
22034 saving the assembly.
22036 * driver.c (--debug): New command line argument to create a
22037 debugger information file.
22039 * location.cs (SymbolDocument): New public property. Returns an
22040 ISymbolDocumentWriter object for the current source file or null
22041 if we don't have a symbol writer.
22043 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22045 * driver.cs (LoadAssembly): Correctly return when all the paths
22046 have been tried and not before.
22048 * statement.cs (Switch.Emit): return the actual coverage for this
22049 statement (returns/not-returns)
22051 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22052 switch of the statement if we are the last switch section. That
22053 kills two problems: try/catch problems (we used to emit an empty
22054 nop at the end) and switch statements where all branches would
22057 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22059 * driver.cs: Add default assemblies (the equivalent to the
22060 Microsoft CSC.RSP file)
22062 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22063 also update tokens_seen and set it to false.
22065 * driver.cs: Implement --recurse for Mike.
22067 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22068 correctly splitting out the paths.
22070 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22072 * interface.cs (Interface.PopulateProperty): Instead of using
22073 `parent' as the declaration space for the set parameters, use
22076 * support.cs (InternalParameters): InternalParameters constructor
22077 takes a DeclSpace instead of a TypeContainer.
22079 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22080 types are being initialized, load the address of it before calling
22083 (New): Provide a mechanism to disable the generation of local
22084 value type temporaries when the caller will be providing us with
22085 an address to store it.
22087 (ArrayCreation.EmitDynamicInitializers): Use it.
22089 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22091 * expression.cs (Invocation.EmitArguments): Only probe for array
22092 property if there is more than one argument. Sorry about that.
22094 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22095 empty param arrays.
22097 * class.cs (Method.LabelParameters): Fix incorrect code path that
22098 prevented the `ParamArrayAttribute' from being applied to the
22101 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22103 * support.cs (ReflectionParameters): Correctly compute whether the
22104 last argument is a params array. Fixes the problem with
22107 * typemanager.cs: Make the assemblies array always be non-null
22108 (empty, but non-null)
22110 * tree.cs (RecordDecl): New function that abstracts the recording
22111 of names. This reports error 101, and provides a pointer to the
22112 previous declaration. Fixes a crash in the compiler.
22114 * cs-parser.jay (constructor_declaration): Update to new grammar,
22115 and provide a constructor_body that can be empty.
22117 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22119 * driver.cs: Add support for --resources.
22121 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22122 Make all types for the various array helper methods be integer.
22124 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22125 CheckState to ConvCast.
22127 (ConvCast): Now it takes a `checked' state argument, to avoid
22128 depending on the emit context for the conversion, and just using
22129 the resolve time setting.
22131 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22132 instead of Invocation.EmitArguments. We do not emit the original
22133 arguments, instead we emit those which have been converted to
22134 unsigned int expressions.
22136 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22138 * codegen.cs: ditto.
22140 * expression.cs (LocalVariableReference): Drop the use of the
22141 Store function that depended on the variable index.
22143 * statement.cs (VariableInfo): Drop the `Idx' property from this
22144 class, as this is not taking into account the indexes for
22145 temporaries tat we generate during the execution, getting the
22148 * class.cs: First emit class initializers, then call the parent
22151 * expression.cs (Binary): Fix opcode emision.
22152 (UnaryMutator.EmitCode): Support checked code generation
22154 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22155 matches for events for both the Static and Instance scans,
22156 pointing to the same element. Fix that.
22158 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22160 * rootcontext.cs (ResolveTree): Always set the
22161 interface_resolve_order, because nested interfaces will be calling
22164 * class.cs (GetInterfaceOrClass): Track the same resolution
22165 process used by TypeManager.LookupType. This fixes the nested
22166 type lookups in class declarations (separate path from
22169 (TypeContainer.DefineType): Also define nested interfaces.
22170 (TypeContainer.RegisterOrder): New public function used to
22171 register the order in which child interfaces need to be closed.
22173 Nested interfaces need to be closed after their parents have been
22176 * interface.cs (InterfaceAttr): Put all the logic for computing
22177 the interface attribute here.
22179 (DefineInterface): Register our interface order with the
22180 RootContext or with the TypeContainer depending on the case.
22182 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22184 * cs-parser.jay: rework foreach statement to work with the new
22185 changes to the policy on SimpleNames.
22187 * report.cs: support Stacktrace on warnings as well.
22189 * makefile: drop --unsafe and /unsafe from the compile.
22191 2002-03-13 Ravi Pratap <ravi@ximian.com>
22193 * ecore.cs (StandardConversionExists): Modify to take an Expression
22194 as the first parameter. Ensure we do null -> reference type conversion
22197 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22198 temporary Expression objects.
22200 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22202 * interface.cs: workaround bug in method overloading resolution
22203 (there is already a bugzilla bug for it).
22205 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22207 We could also solve this problem by having a separate path for
22208 performing type lookups, instead of DoResolve, we could have a
22209 ResolveType entry point, and only participating pieces of the
22210 production (simplename, deref, array) would implement this.
22212 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22213 signal SimpleName to only resolve type names and not attempt to
22214 resolve anything else.
22216 * expression.cs (Cast): Set the flag.
22218 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22220 * class.cs: Only report 108 if there is no `new' modifier.
22222 * cs-parser.jay: rework foreach statement to work with the new
22223 changes to the policy on SimpleNames.
22225 * report.cs: support Stacktrace on warnings as well.
22227 * makefile: drop --unsafe and /unsafe from the compile.
22229 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22231 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22232 lookups here, instead of doing that at parse time. This means
22233 that our grammar will not introduce `LocalVariableReferences' as
22234 expressions at this point. That solves the problem of code like
22238 static void Main ()
22242 This is only half the fix. The full fix requires parameters to
22243 also be handled in this way.
22245 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22246 makes the use more obvious of the DeclSpace. The
22247 ec.TypeContainer.TypeBuilder is now only used to pull the
22248 TypeBuilder for it.
22250 My theory is that I can get rid of the TypeBuilder completely from
22251 the EmitContext, and have typecasts where it is used (from
22252 DeclSpace to where it matters).
22254 The only pending problem is that the code that implements Aliases
22255 is on TypeContainer, and probably should go in DeclSpace.
22257 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22258 lookups here, instead of doing that at parse time. This means
22259 that our grammar will not introduce `LocalVariableReferences' as
22260 expressions at this point. That solves the problem of code like
22264 static void Main ()
22268 This is only half the fix. The full fix requires parameters to
22269 also be handled in this way.
22271 * class.cs (Property.DefineMethod): When implementing an interface
22272 method, set newslot, when implementing an abstract method, do not
22273 set the flag (before we tried never setting it, or always setting
22274 it, which is the difference).
22275 (Indexer.DefineMethod): same.
22276 (Method.DefineMethod): same.
22278 * ecore.cs: Only set the status used flag if we get back a Field.
22280 * attribute.cs: Temporary hack, so Paolo can keep working.
22282 2002-03-08 Ravi Pratap <ravi@ximian.com>
22284 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22285 the unmanaged type in the case we have a MarshalAs attribute.
22287 (Resolve): Handle the case when we are parsing the special MarshalAs
22288 attribute [we need to store the unmanaged type to use later]
22290 * typemanager.cs (marshal_as_attr_type): Built in type for the
22291 MarshalAs Attribute.
22293 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22294 on parameters and accordingly set the marshalling info.
22296 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22298 * class.cs: Optimizing slightly by removing redundant code after
22299 we switched to the `NoTypes' return value.
22300 (Property.DefineMethod): use NoTypes here too.
22302 This fixes the bug I introduced in my last batch of changes.
22304 2002-03-05 Ravi Pratap <ravi@ximian.com>
22306 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22308 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22309 Enums since those are types too.
22311 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22313 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22314 thanks to a call during the lookup process.
22316 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22318 * statement.cs (Foreach): Lots of work to accomodate a particular
22319 kind of foreach statement that I had not kept in mind. It is
22320 possible to have foreachs on classes that provide a GetEnumerator
22321 method that return objects that implement the "pattern" for using
22322 a foreach, there is no need to support GetEnumerator
22325 This is needed to compile nant.
22327 * decl.cs: Only report 114 if the member is not `Finalize' and if
22328 the warning level is at least 2.
22330 * class.cs: Moved the compare function from Method to
22333 (MethodSignature.InheritableMemberSignatureCompare): Add new
22334 filter function that is used to extract inheritable methods from a
22337 (Method.Define): Use the new `inheritable_method_signature_filter'
22340 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22343 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22345 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22347 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22349 * expression.cs: Pass location information to
22350 ConvertImplicitStandard.
22352 * class.cs: Added debugging code to track return values from
22355 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22357 * expression.cs (Is.DoResolve): If either side of the `is' is an
22358 interface, do not flag the warning.
22360 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22363 * report.cs: Allow for --fatal to be used with --probe.
22365 * typemanager.cs (NoTypes): Move the definition for the empty Type
22368 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22370 (TypeContainer.DefineProxy): New function used to proxy to parent
22371 implementations when implementing interfaces.
22372 (TypeContainer.ParentImplements): used to lookup if our parent
22373 implements a public function that is required by an interface.
22374 (TypeContainer.VerifyPendingMethods): Hook this up.
22376 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22377 `modules' and `assemblies' arraylists into arrays. We only grow
22378 these are the very early start up of the program, so this improves
22379 the speedof LookupType (nicely measured).
22381 * expression.cs (MakeByteBlob): Replaced unsafe code with
22382 BitConverter, as suggested by Paolo.
22384 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22385 folding of string concatenation, but if either side is a string,
22386 and the other is not, then return null, and let the runtime use
22387 the concatenation on the string plus the object (using
22388 `Object.ToString').
22390 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22392 Constant Folding has been implemented now.
22394 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22395 the error instead on types that are not supported in one's
22398 * constant.cs (Constant and all children): New set of functions to
22399 perform implict and explicit conversions.
22401 * ecore.cs (EnumConstant): Implement the new functions to perform
22402 conversion by proxying to the child expression.
22404 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22405 own separate setting that can not be turned off from the command
22406 line using --unchecked or --checked and is only controlled using
22407 the checked/unchecked statements and expressions. This setting is
22408 used by the constant folder to flag errors.
22410 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22411 ConstantCheckState as well.
22413 During Resolve, they also have to flag the state, because the
22414 constant folder runs completely in the Resolve phase.
22416 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22419 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22421 * cfold.cs: New file, this file contains the constant folder.
22423 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22424 argument to track whether we are using the resulting address to
22425 load or store a value and provide better error messages.
22427 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22428 new AddressOf arguments.
22430 * statement.cs (Foreach.EmitCollectionForeach): Update
22432 * expression.cs (Argument.Emit): Call AddressOf with proper
22433 arguments to track usage.
22435 (New.DoEmit): Call AddressOf with new arguments.
22437 (Unary.Emit): Adjust AddressOf call.
22439 2002-03-01 Ravi Pratap <ravi@ximian.com>
22441 * cs-parser.jay (member_access): Change the case for pre-defined types
22442 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22445 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22448 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22449 essentially like methods and apply attributes like MethodImplOptions to them too.
22451 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22454 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22455 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22458 * Update code everywhere accordingly.
22460 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22462 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22464 2002-02-28 Ravi Pratap <ravi@ximian.com>
22466 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22467 try performing lookups against those instead of jumping straight into using
22468 the 'using' clauses.
22470 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22472 (LookupType): Perform lookups in implicit parents too.
22474 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22475 sequence as RootContext.LookupType.
22477 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22478 the various cases of namespace lookups into this method.
22480 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22482 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22483 in positional arguments)
22485 * class.cs (Operator): Update the AllowedModifiers to contain
22488 * cs-parser.jay: Update operator declaration to allow for the
22489 operator body to be empty.
22491 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22494 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22496 * class.cs (Method.Emit): Label parameters.
22498 * driver.cs: Return 1 or 0 as the program exit code.
22500 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22502 * expression.cs: Special case the `null' object when trying to
22503 auto-compute the type, as anything can be explicitly converted to
22506 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22507 spotting this Paolo.
22509 (Expression.ImplicitNumericConversion): Perform comparissions of
22510 the type using the underlying type in the case of an enumeration
22511 rather than using the enumeration type for the compare.
22513 Cope with the underlying == type case, which is not possible to
22516 (Expression.ConvertNumericExplicit): Perform comparissions of
22517 the type using the underlying type in the case of an enumeration
22518 rather than using the enumeration type for the compare.
22520 * driver.cs: If the user does not supply an extension, assume .exe
22522 * cs-parser.jay (if_statement): Rewrote so that we can track the
22523 location for the if statement.
22525 * expression.cs (Binary.ConstantFold): Only concat strings when
22526 the operation is "+", not everything ;-)
22528 * statement.cs (Statement.EmitBoolExpression): Take a location
22530 (If, While, Do): Track location.
22532 * expression.cs (Binary.ResolveOperator): In the object + string
22533 case, I was missing a call to ConvertImplicit
22535 2002-02-25 Ravi Pratap <ravi@ximian.com>
22537 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22538 Location arguments. Ensure we use RootContext.LookupType to do our work
22539 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22541 * interface.cs (PopulateMethod): Handle the type of the parameter being
22544 * expression.cs (Invocation.BetterFunction): Handle the case when we
22545 have a params method with no fixed arguments and a call is made with no
22548 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22550 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22551 the verbatim-string-literal
22553 * support.cs (InternalParameters.ParameterModifier): handle null
22555 (InternalParameters.ParameterType): ditto.
22557 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22558 duplicating the name of the variable parameter.
22559 (GetParameterByName): Fix bug where we were not looking up array
22560 paramters if they were the only present (thanks Paolo!).
22561 (GetParameterInfo): We only have an empty set of types if both
22562 fixed and array are set to null.
22563 (GetParameterInfo-idx): Handle FixedParameter == null
22565 * cs-parser.jay: Handle the case where there is no catch
22566 statements (missing null test).
22568 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22570 * driver.cs (MainDriver): Be conservative on our command line
22573 Catch DirectoryNotFoundException when calling GetFiles.
22575 (SplitPathAndPattern): Used to split the input specification into
22576 a path and a pattern that we can feed to Directory.GetFiles.
22578 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22580 * statement.cs (Fixed): Implement the last case of the Fixed
22581 statement (string handling).
22583 * expression.cs (StringPtr): New class used to return a char * to
22584 a string; Used by the Fixed statement.
22586 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22588 * expression.cs (Binary.ResolveOperator): Remove redundant
22589 MemberLookup pn parent type.
22590 Optimize union call, we do not need a union if the types are the same.
22591 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22594 Specialize the use of MemberLookup everywhere, instead of using
22595 the default settings.
22597 (StackAlloc): Implement stackalloc keyword.
22599 * cs-parser.jay: Add rule to parse stackalloc.
22601 * driver.cs: Handle /h, /help, /?
22603 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22604 before we supported unsafe code.
22606 * makefile: add --unsafe to the self compilation of mcs.
22608 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22610 * expression.cs (PointerArithmetic): New class that is used to
22611 perform pointer arithmetic.
22612 (Binary.Resolve): Handle pointer arithmetic
22613 Handle pointer comparission.
22614 (ArrayPtr): Utility expression class that is used to take the
22615 address of an array.
22617 (ElementAccess): Implement array access for pointers
22619 * statement.cs (Fixed): Implement fixed statement for arrays, we
22620 are missing one more case before we are done.
22622 * expression.cs (Indirection): Implement EmitAssign and set the
22623 ExprClass to Variable. This allows pointer dereferences to be
22624 treated as variables, and to have values assigned to them.
22626 * ecore.cs (Expression.StoreFromPtr): New utility function to
22627 store values dereferencing.
22629 2002-02-20 Ravi Pratap <ravi@ximian.com>
22631 * expression.cs (Binary.ResolveOperator): Ensure that we are
22632 not trying to operate on a void type - this fixes the reported
22635 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22636 the parent implementation is sealed.
22638 * ../errors/cs0239.cs : Add.
22640 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22642 * typemanager.cs (unverifiable_code_type): Corresponds to
22643 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22644 which have unsafe code in them.
22646 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22649 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22651 * cs-tokenizer.cs: Add support for @"litreal strings"
22653 Make tokenizer accept pre-processor directives
22654 on any column (remove the old C-like limitation).
22656 * rootcontext.cs (EmitCode): Emit any global attributes.
22657 (AddGlobalAttributes): Used to keep track of assembly attributes.
22659 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22661 * cs-parser.jay: Add support for global attributes.
22663 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22665 * expression.cs (Indirection): New helper class. Unary will
22666 create Indirection classes to be able to implement the
22667 IMemoryLocation interface on it.
22669 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22671 * cs-parser.jay (fixed_statement): reference the right statement.
22673 * statement.cs (Fixed.Emit): Finish implementing the fixed
22674 statement for the &x case.
22676 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22678 * class.cs (Property.Define, Method.Define): Remove newslot when
22681 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22682 wrong. NewSlot should only be used if the `new' keyword is present.
22684 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22685 locating our system dir. Sorry about this.
22687 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22689 * driver.cs (GetSystemDir): Compute correctly the location of our
22690 system assemblies. I was using the compiler directory instead of
22691 the library directory.
22693 2002-02-13 Ravi Pratap <ravi@ximian.com>
22695 * expression.cs (BetterFunction): Put back in what Miguel commented out
22696 since it is the correct fix. The problem is elsewhere ;-)
22698 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22699 parameters of the parms method are themselves compatible or not !
22701 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22702 to check that a class implements an interface before saying that an implicit
22703 conversion was allowed. Use ImplementsInterface to do the checking.
22705 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22707 * class.cs (Method.Define): Track whether we are an explicit
22708 implementation or not. And only call DefineMethodOverride if we
22709 are an explicit implementation.
22711 (Property.DefineMethod): Ditto.
22713 2002-02-11 Ravi Pratap <ravi@ximian.com>
22715 * expression.cs (BetterFunction): Catch hideous bug which was
22716 preventing us from detecting ambiguous calls due to implicit casts i.e
22719 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22721 * support.cs (Pair): Remove un-needed method. I figured why I was
22722 getting the error in cs-parser.jay, the variable in a foreach loop
22723 is readonly, and the compiler does not really treat this as a variable.
22725 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22726 instead of EQUALS in grammar.
22728 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22730 * expression.cs (Unary.DoResolve): Check whether the argument is
22733 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22735 * support.cs: Api for Pair to set a value. Despite the fact that
22736 the variables are public the MS C# compiler refuses to compile
22737 code that accesses the field if the variable is part of a foreach
22740 * statement.cs (Fixed): Begin implementation of the fixed
22743 (Block.AddVariable): Return the VariableInfo on success and null
22744 on failure instead of true/false.
22746 * cs-parser.jay (foreach): Catch errors on variables already
22747 defined (we were ignoring this value before) and properly unwind
22748 the block hierarchy
22750 (fixed_statement): grammar for the fixed statement.
22752 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22754 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22755 pointer types to be incretemented.
22757 (SizeOf): Implement.
22759 * cs-parser.jay (pointer_member_access): Implement
22760 expr->IDENTIFIER production.
22762 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22763 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22766 (Unary): Implement indirection.
22768 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22769 use in non-unsafe context).
22771 (SimpleName.DoResolve): Check for pointers in field access on safe
22774 (Expression.LoadFromPtr): Factor the load-indirect code in this
22775 function. This was duplicated in UnboxCast and ParameterReference
22777 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22779 * expression.cs (ComposedCast): report an error if a pointer cast
22780 is used in a safe region.
22782 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22783 pointer type casts in unsafe context.
22785 * codegen.cs (EmitContext): Set up IsUnsafe.
22787 * cs-parser.jay (non_expression_type): Add productions for pointer
22790 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22791 code. We should not use force into static mode if the method is
22792 not virtual. Fixes bug in MIS
22794 * statement.cs (Do.Emit, While.Emit, For.Emit,
22795 Statement.EmitBoolExpression): Add support to Do and While to
22796 propagate infinite loop as `I do return' semantics.
22798 Improve the For case to also test for boolean constants.
22800 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22801 to the list of attributes we can add.
22803 Remove `EmitContext' argument.
22805 * class.cs (Method.Define): Apply parameter attributes.
22806 (Constructor.Define): Apply parameter attributes.
22807 (MethodCore.LabelParameters): Move here the core of labeling
22810 * support.cs (ReflectionParameters.ParameterModifier,
22811 InternalParameters.ParameterModifier): Use IsByRef on the type and
22812 only return the OUT bit for these parameters instead of in/out/ref
22815 This is because I miss-understood things. The ParameterInfo.IsIn
22816 and IsOut represent whether the parameter has the [In] and [Out]
22819 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22821 * ecore.cs (FieldExpr.Emit): Release temporaries.
22823 * assign.cs (LocalTemporary.Release): new function.
22825 * codegen.cs (EmitContext.GetTemporaryStorage,
22826 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22827 temporary storage. Now we can "put back" localbuilders when we
22830 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22832 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22833 need to make a copy of the variable to generate verifiable code.
22835 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22837 * driver.cs: Compute dynamically the system directory.
22839 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22840 Slower, but more generally useful. Used by the abstract
22841 registering implementation.
22843 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22844 the rules for the special rule on Type/instances. First check if
22845 we have the same name, and if so, try that special static path
22846 rather than the instance path.
22848 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22850 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22853 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22854 Enum, ValueType, Delegate or Array for non-corlib compiles.
22856 * cs-tokenizer.cs: Catch long identifiers (645)
22858 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22861 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22862 fix, we were returning too early, so we were not registering
22863 pending methods from abstract classes.
22865 Do not register pending methods if the class is abstract.
22867 * expression.cs (Conditional.DoResolve): Report circular implicit
22868 conversions when we neecd to compute it for conditional
22871 (Is.DoResolve): If the expression is always of the provided type,
22872 flag warning 183. If the expression can not ever be of the
22873 provided type flag warning 184.
22875 * class.cs: Catch 169 as well.
22877 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22880 2002-01-18 Nick Drochak <ndrochak@gol.com>
22882 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22884 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22886 * interface.cs: (PopulateMethod): Check for pointers being defined
22887 only if the unsafe context is active.
22888 (PopulateProperty): ditto.
22889 (PopulateIndexer): ditto.
22891 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22892 specified. If pointers are present, make sure that they are
22893 present in an unsafe context.
22894 (Constructor, Constructor.Define): ditto.
22895 (Field, Field.Define): ditto.
22896 (Property, Property.Define): ditto.
22897 (Event, Event.Define): ditto.
22899 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22900 hashtable if there are classes or structs defined.
22902 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22903 code, as the constant resolution moved.
22905 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22906 the metadata, so we can flag error 133.
22908 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22909 pointer is being declared in an unsafe context.
22911 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22913 * modifiers.cs (Modifiers.Check): Require a Location argument.
22914 Report error 227 for Unsafe use.
22916 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22918 * statement.cs (For.Emit): If the test is null, then report that
22919 we do `return', as we wont reach anything afterwards.
22921 (Switch.SwitchGoverningType): Track the expression that matched
22924 * driver.cs: Allow negative numbers as an error code to flag.
22926 * cs-parser.jay: Handle 1551.
22928 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22930 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22932 * cs-parser.jay: Report 1518 (type declaration can only contain
22933 class, struct, interface, enum or delegate)
22935 (switch_label): Report 1523 (keywords `case' or `default' must
22938 (opt_switch_sections): Report 1522 (empty switch)
22940 * driver.cs: Report 1515 (response file specified multiple times)
22941 Report 1516 (Source file specified multiple times).
22943 * expression.cs (Argument.Resolve): Signal 1510
22945 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22946 access not allowed in static code)
22948 2002-01-11 Ravi Pratap <ravi@ximian.com>
22950 * typemanager.cs (IsPointerType): Utility method which we are going
22953 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22954 the object type, so we take care of that.
22956 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22958 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22959 added to non-params parameters :-)
22961 * typemanager.cs (CSharpName): Include 'void' type too.
22963 (void_ptr_type): Include in the set of core types.
22965 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22968 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22971 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22972 completely forgotten about it.
22974 2002-01-10 Ravi Pratap <ravi@ximian.com>
22976 * cs-parser.jay (pointer_type): Add. This begins our implementation
22977 of parsing rules for unsafe code.
22979 (unsafe_statement): Implement.
22981 (embedded_statement): Modify to include the above.
22983 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22985 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22986 if the current context is an unsafe one.
22988 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22989 are handled differently, we need separate rules for them.
22991 (local_variable_declaration): Update to use local_variable_pointer_type
22992 to allow variable declarations of unmanaged pointer types.
22994 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22995 in unsafe contexts.
22997 * ../errors/cs0214.cs : Add.
22999 2002-01-16 Nick Drochak <ndrochak@gol.com>
23001 * makefile: remove 'response' file when cleaning.
23003 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23005 * cs-parser.jay: Report 1524.
23007 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23009 * typemanager.cs (RegisterMethod): drop checking if we have
23010 registered this from here
23012 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23014 * class.cs (Method.EmitDestructor): Implement calling our base
23017 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23018 value of InFinally.
23020 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23021 this routine and will wrap the call in a try/catch block. Deal
23024 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23026 * ecore.cs (Expression.MemberLookup): instead of taking a
23027 parameter `same_type' that was used to tell whether we could
23028 access private members we compute our containing type from the
23031 (FieldExpr): Added partial support for volatile fields. This does
23032 not work for volatile fields exposed from assemblies, as I can not
23033 figure out how to extract the modreq from it.
23035 Updated all the source files to use this.
23037 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23038 because it is referenced by MemberLookup very often.
23040 2002-01-09 Ravi Pratap <ravi@ximian.com>
23042 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23043 TypeBuilder.GetCustomAttributes to retrieve what we need.
23045 Get rid of redundant default_member_attr_type as this is the same as
23046 default_member_type which already exists.
23048 * interface.cs, attribute.cs : Update accordingly.
23050 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23052 * typemanager.cs: Enable IndexerPropertyName again. It does not
23053 work for TYpeBuilders though. Ravi, can you please fix this?
23055 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23057 * expression.cs (Argument.Emit): Handle the case of ref objects
23058 being passed to ref functions;
23060 (ParameterReference.EmitLoad): Loads the content of the pointer
23061 without dereferencing.
23063 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23065 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23067 2002-01-08 Ravi Pratap <ravi@ximian.com>
23069 * class.cs (Indexer.DefineMethod): Incorporate the interface
23070 type in the name of the method if we are doing explicit interface
23073 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23075 (BetterConversion): Fix extremely trivial bug where we were referring to
23076 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23079 * ../errors/bug16.cs : Add although we have fixed it.
23081 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23083 * expression.cs (BaseIndexer): Begin implementation.
23085 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23087 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23088 production directly to remove a shift/reduce, and implement
23089 explicit interface implementation.
23091 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23092 after a floating point suffix.
23094 * expression.cs (DoNumericPromotions): Improved the conversion for
23095 uint/uint. If we have a constant, we avoid doing a typecast to a
23098 * class.cs (Indexer): Implement explicit interface implementation
23101 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23103 * class.cs: make the default instance constructor public and hidebysig.
23105 2001-01-03 Ravi Pratap <ravi@ximian.com>
23107 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23108 so we can call it from elsewhere.
23110 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23111 we emit it internally if the class has a defined indexer; otherwise the user
23112 emits it by decorating the class definition with the DefaultMemberAttribute.
23114 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23115 attribute is not used on a type which defines an indexer.
23117 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23118 character when we skip whitespace.
23120 * ../errors/cs0646.cs : Add.
23122 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23124 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23127 * makefile: Add practical target `mcs3.exe' which builds the third
23128 generation compiler.
23130 * expression.cs (New): Fix structures constructor calling.
23132 * class.cs (Property, Method, Indexer): Emit Final flag on the
23133 method if we are an interface implementation and we are not
23136 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23137 whether this property is referencing a `base' method.
23139 * expression.cs (Invocation.EmitCall): take an extra argument:
23140 is_base, this is used to determine whether the `call' or
23141 `callvirt' opcode should be used.
23144 * delegate.cs: update EmitCall.
23146 * class.cs (Method.Define): Set NewSlot for the cases where we are
23147 not implementing an interface method.
23149 (Property.Define): ditto.
23151 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23153 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23154 'r'. Allows mcs to parse itself fully.
23156 2002-01-02 Ravi Pratap <ravi@ximian.com>
23158 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23159 of the number of initializers that require the InitializeArray method.
23161 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23162 update the above field where necessary.
23164 (MakeByteBlob): Update accordingly.
23166 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23169 (EmitDynamicInitializers): Update in accordance with the new optimization.
23171 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23172 same OpCode applies.
23174 * cs-parser.jay : Fix some glaring errors I introduced.
23176 2002-01-01 Ravi Pratap <ravi@ximian.com>
23178 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23179 so that we can check for name clashes there too.
23181 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23182 for interface indexers.
23184 * interfaces.cs (Define): Emit the default member attribute.
23186 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23187 variable was being referred to while setting the value ;-)
23189 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23191 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23192 byte-by-byte information when we know the data is zero.
23194 Make the block always a multiple of 4, because
23195 DefineInitializedData has a bug.
23197 * assign.cs: Fix, we should assign from the temporary, not from
23200 * expression.cs (MakeByteBlob): Fix my incorrect code.
23202 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23204 * typemanager.cs (EnumToUnderlying): This function is used to get
23205 the underlying type from an enumeration, because it does not
23208 * constant.cs: Use the I4_S form for values between -128 and 127.
23210 * statement.cs (Block.LookupLabel): Looks up a label.
23211 (Block): Drop support for labeled blocks.
23213 (LabeledStatement): New kind of statement that represents a label
23216 (Goto): Finally implement this bad boy.
23218 * cs-parser.jay: Update to reflect new mechanism to implement
23221 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23223 * codegen.cs (EmitContext.This): a codegen property that keeps the
23224 a single instance of this instead of creating many different this
23227 * delegate.cs (Delegate.DoResolve): Update to use the property;
23229 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23231 * expression.cs (BaseAccess.DoResolve): Ditto.
23233 2001-12-29 Ravi Pratap <ravi@ximian.com>
23235 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23236 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23238 (InitCoreTypes): Update accordingly.
23240 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23241 so we can quickly store the state.
23243 (ApplyAttributes): Set the correct implementation flags
23244 for InternalCall methods.
23246 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23248 * expression.cs (EmitCall): if a method is not virtual, then do
23249 not use callvirt on it.
23251 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23252 user defined stuff) requires the use of stobj, which takes an
23253 address on the stack instead of an array and an index. So emit
23254 the Ldelema operation for it.
23256 (EmitStoreOpcode): Use stobj for valuetypes.
23258 (UnaryMutator.EmitCode): Use the right 1 value depending on
23259 whether we are dealing with int64/uint64, float or doubles.
23261 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23262 constructors that I implemented last night.
23264 (Constructor.IsDefault): Fix to work properly for static
23267 * cs-parser.jay (CheckDef): report method signature errors.
23268 Update error number 103 to be 132.
23270 * decl.cs: New AdditionResult enumeration value: MethodExists.
23271 Although we do this check for methods later on in the semantic
23272 analysis, catching repeated default constructors is so easy that
23273 we catch these here.
23275 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23278 (ParameterReference.EmitAssign, Emit): handle
23281 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23282 (ArrayAccess.EmitStoreOpcode): ditto.
23284 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23286 * expression.cs (MakeByteBlob): Complete all the missing types
23287 (uint, short, ushort, byte, sbyte)
23289 * class.cs: Only init instance field initializers on instance
23292 Rename `constructors' to instance_constructors.
23294 (TypeContainer.AddConstructor): Only add constructors to the list
23295 if it is not static.
23297 Make sure that we handle default_static_constructor independently
23298 everywhere where we handle instance_constructors
23300 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23302 * class.cs: Do not lookup or create a base initializer for a
23303 static constructor.
23305 (ConstructorInitializer.Resolve): use the proper type to lookup
23308 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23310 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23313 * decl.cs: CloseType is now an virtual method, the default
23314 implementation just closes this type.
23316 2001-12-28 Ravi Pratap <ravi@ximian.com>
23318 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23319 to PreserveSig by default. Also emit HideBySig on such methods.
23321 Basically, set the defaults to standard values.
23323 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23324 argument, if candidate is better, it can't be worse than the best !
23326 (Invocation): Re-write bits to differentiate between methods being
23327 applicable in their expanded form and their normal form - for params
23330 Get rid of use_standard everywhere as only standard conversions are allowed
23331 in overload resolution.
23333 More spec conformance.
23335 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23337 * driver.cs: Add --timestamp, to see where the compiler spends
23340 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23341 `this' in static code.
23343 (SimpleName.DoResolve): Implement in terms of a helper function
23344 that allows static-references to be passed upstream to
23347 (Expression.ResolveWithSimpleName): Resolve specially simple
23348 names when called by MemberAccess to implement the special
23351 (Expression.ImplicitReferenceConversion): Handle conversions from
23352 Null to reference types before others, as Null's type is
23355 * expression.cs (Invocation.EmitCall): Handle the special case of
23356 calling methods declared on a reference type from a ValueType
23357 (Base classes System.Object and System.Enum)
23359 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23360 the left hand side is a TypeExpr, not on every enumeration.
23362 (Binary.Resolve): If types are reference types, then do a cast to
23363 object on operators != and == of both arguments.
23365 * typemanager.cs (FindMembers): Extract instance and static
23366 members if requested.
23368 * interface.cs (PopulateProperty): Use void_type instead of null
23369 as the return type for the setter method.
23371 (PopulateIndexer): ditto.
23373 2001-12-27 Ravi Pratap <ravi@ximian.com>
23375 * support.cs (ReflectionParameters): Fix minor bug where we
23376 were examining the wrong parameter for the ParamArray attribute.
23378 Cope with requests for the type of the parameter at position
23379 greater than the params parameter's. We now return the element
23380 type of the params array as that makes more sense.
23382 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23383 accordingly as we no longer have to extract the element type
23386 (Invocation.OverloadResolve): Update.
23388 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23390 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23391 against IEnumerator, test whether the return value is a descendant
23392 of the IEnumerator interface.
23394 * class.cs (Indexer.Define): Use an auxiliary method to implement
23395 the other bits of the method definition. Begin support for
23396 explicit interface implementation.
23398 (Property.DefineMethod): Use TypeManager.void_type instead of null
23399 for an empty return value.
23401 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23403 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23404 dealing with a FieldExpr which is composed of a FieldBuilder, in
23405 the code path we did extract the constant, but we should have
23406 obtained the underlying value to be able to cast it (otherwise we
23407 end up in an infinite loop, this is what Ravi was running into).
23409 (ArrayCreation.UpdateIndices): Arrays might be empty.
23411 (MemberAccess.ResolveMemberAccess): Add support for section
23412 14.5.4.1 that deals with the special case of E.I when E is a type
23413 and something else, that I can be a reference to a static member.
23415 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23416 handle a particular array type to create byte blobs, it is just
23417 something we dont generate byteblobs for.
23419 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23422 * location.cs (Push): remove the key from the hashtable that we
23423 are about to add. This happens for empty files.
23425 * driver.cs: Dispose files after we have parsed them.
23427 (tokenize): new function that only runs the tokenizer on its
23428 input, for speed testing.
23430 2001-12-26 Ravi Pratap <ravi@ximian.com>
23432 * class.cs (Event.Define): Define the private field only if there
23433 are no accessors defined.
23435 * expression.cs (ResolveMemberAccess): If there is no associated
23436 field with the event, that means we have an event defined with its
23437 own accessors and we should flag error cs0070 since transforming
23438 ourselves into a field is not valid in that case.
23440 * ecore.cs (SimpleName.DoResolve): Same as above.
23442 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23443 and charset to sane values.
23445 2001-12-25 Ravi Pratap <ravi@ximian.com>
23447 * assign.cs (DoResolve): Perform check on events only if they
23448 are being accessed outside the declaring type.
23450 * cs-parser.jay (event_declarations): Update rules to correctly
23451 set the type of the implicit parameter etc.
23453 (add_accessor, remove_accessor): Set current local parameters.
23455 * expression.cs (Binary): For delegate addition and subtraction,
23456 cast the return value from the method into the appropriate delegate
23459 2001-12-24 Ravi Pratap <ravi@ximian.com>
23461 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23462 of these as the workaround is unnecessary.
23464 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23465 delegate data - none of that is needed at all.
23467 Re-write bits to extract the instance expression and the delegate method
23470 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23473 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23474 of attaching attributes instead of duplicating code everywhere.
23476 * everywhere : Update code to do attribute emission using the above method.
23478 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23480 * expression.cs (IsParamsMethodApplicable): if there are not
23481 parameters, return immediately.
23483 * ecore.cs: The 0 literal can be implicity converted to an enum
23486 (SimpleName.DoResolve): First lookup the type, then lookup the
23489 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23490 want to get its address. If the InstanceExpression is not
23491 addressable, store the result in a temporary variable, then get
23494 * codegen.cs: Only display 219 errors on warning level or above.
23496 * expression.cs (ArrayAccess): Make it implement the
23497 IMemoryLocation interface.
23499 (Binary.DoResolve): handle the operator == (object a, object b)
23500 and operator != (object a, object b) without incurring into a
23501 BoxedCast (because 5 != o should never be performed).
23503 Handle binary enumerator operators.
23505 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23506 value type, otherwise use Ldelem_ref.
23508 Use precomputed names;
23510 (AddressOf): Implement address of
23512 * cs-parser.jay (labeled_statement): Fix recursive block
23513 addition by reworking the production.
23515 * expression.cs (New.DoEmit): New has a special case:
23517 If we are dealing with a ValueType, we have a few
23518 situations to deal with:
23520 * The target of New is a ValueType variable, that is
23521 easy, we just pass this as the variable reference
23523 * The target of New is being passed as an argument,
23524 to a boxing operation or a function that takes a
23527 In this case, we need to create a temporary variable
23528 that is the argument of New.
23531 2001-12-23 Ravi Pratap <ravi@ximian.com>
23533 * rootcontext.cs (LookupType): Check that current_type is not null before
23534 going about looking at nested types.
23536 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23537 not implement the IAssignMethod interface any more.
23539 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23540 where we tranform them into FieldExprs if they are being resolved from within
23541 the declaring type.
23543 * ecore.cs (SimpleName.DoResolve): Do the same here.
23545 * assign.cs (DoResolve, Emit): Clean up code considerably.
23547 * ../errors/bug10.cs : Add.
23549 * ../errors/cs0070.cs : Add.
23551 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23553 * assign.cs : Get rid of EventIsLocal everywhere.
23555 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23557 * ecore.cs (ConvertIntLiteral): finished the implementation.
23559 * statement.cs (SwitchLabel): Convert the value we are using as a
23560 key before looking up the table.
23562 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23564 * codegen.cs (EmitTopBlock): Require a Location argument now.
23566 * cs-parser.jay (constructor_declarator): We need to setup
23567 current_local_parameters before we parse the
23568 opt_constructor_initializer, to allow the variables to be bound
23569 to the constructor arguments.
23571 * rootcontext.cs (LookupType): First lookup nested classes in our
23572 class and our parents before we go looking outside our class.
23574 * expression.cs (ConstantFold): Extract/debox the values at the
23577 * rootcontext.cs (EmitCode): Resolve the constants first before we
23578 resolve the types. This is not really needed, but it helps debugging.
23580 * statement.cs: report location.
23582 * cs-parser.jay: pass location to throw statement.
23584 * driver.cs: Small bug fix.
23586 * report.cs: Updated format to be 4-zero filled digits.
23588 2001-12-22 Ravi Pratap <ravi@ximian.com>
23590 * expression.cs (CheckIndices): Fix minor bug where the wrong
23591 variable was being referred to ;-)
23593 (DoEmit): Do not call EmitStaticInitializers when the
23594 underlying type is System.Object.
23596 2001-12-21 Ravi Pratap <ravi@ximian.com>
23598 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23599 and do the usual workaround for SRE.
23601 * class.cs (MyEventBuilder.EventType): New member to get at the type
23602 of the event, quickly.
23604 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23606 * assign.cs (Assign.DoResolve): Handle the case when the target
23607 is an EventExpr and perform the necessary checks.
23609 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23612 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23614 (EventExpr): Set the type in the constructor itself since we
23615 are meant to be born fully resolved.
23617 (EventExpr.Define): Revert code I wrote earlier.
23619 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23620 instance expression is null. The instance expression is a This in that case
23621 or a null, depending on whether it is a static method or not.
23623 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23624 refers to more than one method.
23626 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23627 and accordingly flag errors.
23629 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23631 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23633 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23635 * location.cs (ToString): Provide useful rutine.
23637 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23639 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23640 objects, return the actual integral boxed.
23642 * statement.cs (SwitchLabel): define an ILLabel for each
23645 (Switch.CheckSwitch): If the value is a Literal, extract
23646 the underlying literal.
23648 Also in the unused hashtable we had, add the SwitchLabel so we can
23649 quickly look this value up.
23651 * constant.cs: Implement a bunch of new constants. Rewrite
23652 Literal based on this. Made changes everywhere to adapt to this.
23654 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23655 dereferencing array only once, and also copes with enumrations.
23657 bytes are two bytes wide, not one.
23659 (Cast): Perform constant conversions.
23661 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23662 wrappers to the literals here.
23664 * expression.cs (DoNumericPromotions): long literals can converted
23665 to ulong implicity (this is taken care of elsewhere, but I was
23666 missing this spot).
23668 * ecore.cs (Expression.Literalize): Make the return type Literal,
23669 to improve type checking.
23671 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23673 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23675 * literal.cs: Revert code from ravi that checked the bounds. The
23676 bounds are sane by the definition of the type itself.
23678 * typemanager.cs: Fix implementation of ImplementsInterface. We
23679 need to actually look up in our parent hierarchy for interfaces
23682 * const.cs: Use the underlying type for enumerations
23684 * delegate.cs: Compute the basename for the delegate creation,
23685 that should fix the delegate test case, and restore the correct
23686 Type Lookup semantics in rootcontext
23688 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23689 referencing a nested type with the Reflection API is using the "+"
23692 * cs-parser.jay: Do not require EOF token at the end.
23694 2001-12-20 Ravi Pratap <ravi@ximian.com>
23696 * rootcontext.cs (LookupType): Concatenate type names with
23697 a '.' instead of a '+' The test suite passes again.
23699 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23700 field of the enumeration.
23702 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23703 the case when the member is an EventExpr.
23705 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23706 static has an associated instance expression.
23708 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23710 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23712 * class.cs (Event.Define): Register event and perform appropriate checks
23715 We define the Add and Remove methods even if the use provides none because
23716 in that case, we provide default implementations ourselves.
23718 Define a private field of the type of the event. This is done by the CSC compiler
23719 and we should be doing it too ;-)
23721 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23722 More methods we use in code we generate.
23724 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23727 (InitCoreTypes): Update accordingly for the above.
23729 * class.cs (Event.Emit): Generate code for default accessors that we provide
23731 (EmitDefaultMethod): Do the job in the above.
23733 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23736 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23738 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23739 builders even if we were missing one.
23741 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23742 pass the Basename as our class name instead of the Name. The
23743 basename will be correctly composed for us.
23745 * parameter.cs (Paramters): Now takes a Location argument.
23747 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23748 make all the code call directly LookupType in RootContext and take
23749 this chance to pass the Location information everywhere.
23751 * Everywhere: pass Location information.
23753 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23755 * class.cs (Constructor.Define): Updated way of detecting the
23756 length of the parameters.
23758 (TypeContainer.DefineType): Use basename as the type name for
23761 (TypeContainer.Define): Do not recursively define types here, as
23762 definition is taken care in order by the RootContext.
23764 * tree.cs: Keep track of namespaces in a per-file basis.
23766 * parameter.cs (Parameter.ComputeSignature): Update to use
23769 (Parameters.GetSignature): ditto.
23771 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23772 instead of a TypeContainer.
23774 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23775 resolve names. Because we need to be resolve in our context, not
23778 * driver.cs: Implement response files.
23780 * class.cs (TypeContainer.DefineType): If we are defined, do not
23781 redefine ourselves.
23783 (Event.Emit): Emit the code for add/remove handlers.
23784 (Event.Define): Save the MethodBuilders for add/remove.
23786 * typemanager.cs: Use pair here too.
23788 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23789 DictionaryEntry requires the first argument to be non-null.
23791 (enum_declaration): Compute full name for registering the
23794 (delegate_declaration): Instead of using
23795 formal_parameter_list, use opt_formal_parameter_list as the list
23798 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23799 (EventParsing): New property that controls whether `add' and
23800 `remove' are returned as tokens or identifiers (for events);
23802 2001-12-19 Ravi Pratap <ravi@ximian.com>
23804 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23805 use MyEventBuilder only and let it wrap the real builder for us.
23807 (MyEventBuilder): Revamp constructor etc.
23809 Implement all operations that we perform on EventBuilder in precisely the same
23812 (FindMembers): Update to use the EventBuilder member.
23814 (Event.Emit): Update accordingly.
23816 2001-12-18 Ravi Pratap <ravi@ximian.com>
23818 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23819 by calling the appropriate methods.
23821 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23824 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23826 2001-12-17 Ravi Pratap <ravi@ximian.com>
23828 * delegate.cs (Delegate.Populate): Check that the return type
23829 and various parameters types are indeed accessible.
23831 * class.cs (Constructor.Define): Same here.
23833 (Field.Define): Ditto.
23835 (Event.Define): Ditto.
23837 (Operator.Define): Check that the underlying Method defined itself
23838 correctly - so it's MethodBuilder should not be null.
23840 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23841 expression happens to be null.
23843 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23844 members but as of now we don't seem to be able to do anything really useful with it.
23846 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23847 not the EventBuilder.
23849 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23851 * cs-tokenizer.cs: Add support for defines.
23852 Add support for #if, #elif, #else, #endif
23854 (eval_var): evaluates a variable.
23855 (eval): stubbed for evaluating functions.
23857 * cs-parser.jay: Pass the defines information
23859 * driver.cs: Add --define command line option.
23861 * decl.cs: Move MemberCore here.
23863 Make it the base class for DeclSpace. This allows us to catch and
23864 report 108 and 109 for everything now.
23866 * class.cs (TypeContainer.Define): Extract all the members
23867 before populating and emit the warning 108 (new keyword required
23868 to override) instead of having each member implement this.
23870 (MemberCore.Define): New abstract method, we will be using this in
23871 the warning reporting engine in Populate.
23873 (Operator.Define): Adjust to new MemberCore protocol.
23875 * const.cs (Const): This does not derive from Expression, it is a
23876 temporary object we use to create fields, it is a MemberCore.
23878 * class.cs (Method.Define): Allow the entry point to be in a
23881 * driver.cs: Rewrite the argument handler to clean it up a bit.
23883 * rootcontext.cs: Made it just an auxiliary namespace feature by
23884 making everything static.
23886 * driver.cs: Adapt code to use RootContext type name instead of
23889 * delegate.cs: Remove RootContext argument.
23891 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23894 * class.cs (Event.Define): The lookup can fail.
23896 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23898 * expression.cs: Resolve the this instance before invoking the code.
23900 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23902 * cs-parser.jay: Add a production in element_access that allows
23903 the thing to become a "type" reference. This way we can parse
23904 things like "(string [])" as a type.
23906 Note that this still does not handle the more complex rules of
23910 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23912 * ecore.cs: (CopyNewMethods): new utility function used to
23913 assemble the list of methods from running FindMembers.
23915 (MemberLookup): Rework FindMembers so that
23917 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23919 * class.cs (TypeContainer): Remove Delegates who fail to be
23922 * delegate.cs (Populate): Verify that we dont get null return
23923 values. TODO: Check for AsAccessible.
23925 * cs-parser.jay: Use basename to emit error 574 (destructor should
23926 have the same name as container class), not the full name.
23928 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23929 possible representation.
23931 Also implements integer type suffixes U and L.
23933 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23935 * expression.cs (ArrayCreation.DoResolve): We need to do the
23936 argument resolution *always*.
23938 * decl.cs: Make this hold the namespace. Hold the root context as
23940 (LookupType): Move here.
23942 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23944 * location.cs (Row, Name): Fixed the code, it was always returning
23945 references to the first file.
23947 * interface.cs: Register properties defined through interfaces.
23949 * driver.cs: Add support for globbing on the command line
23951 * class.cs (Field): Make it derive from MemberCore as well.
23954 2001-12-15 Ravi Pratap <ravi@ximian.com>
23956 * class.cs (Event::Define): Check that the type of the event is a delegate
23957 type else flag error #66.
23959 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23962 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23963 values of EntryPoint, CharSet etc etc.
23965 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23967 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23968 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23969 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23970 which needs this to do its work.
23972 * ../errors/cs0066.cs : Add.
23974 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23976 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23979 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23980 clears out the parameters field.
23981 (MemberSignatureCompare): Cleanup
23983 (MemberCore): New base class used to share code between MethodCore
23986 (RegisterRequiredImplementations) BindingFlags.Public requires
23987 either BindingFlags.Instace or Static. Use instance here.
23989 (Property): Refactored code to cope better with the full spec.
23991 * parameter.cs (GetParameterInfo): Return an empty array instead
23994 * class.cs (Property): Abstract or extern properties have no bodies.
23996 * parameter.cs (GetParameterInfo): return a zero-sized array.
23998 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23999 method modifier validation to the typecontainer so we can reuse
24000 this on properties.
24002 (MethodCore.ParameterTypes): return an empty sized array of types.
24004 (Property.Define): Test property modifier validity.
24006 Add tests for sealed/override too.
24008 (Method.Emit): abstract or extern methods have no bodies.
24010 2001-12-14 Ravi Pratap <ravi@ximian.com>
24012 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24015 (Method::Define, ::Emit): Modify accordingly.
24017 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24019 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24021 * makefile: Pass in /unsafe.
24023 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24025 * class.cs (MakeKey): Kill routine.
24027 * class.cs (TypeContainer.Define): Correctly define explicit
24028 method implementations (they require the full interface name plus
24031 * typemanager.cs: Deply the PtrHashtable here and stop using the
24032 lame keys. Things work so much better.
24034 This of course broke everyone who depended on `RegisterMethod' to
24035 do the `test for existance' test. This has to be done elsewhere.
24037 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24038 the object stupid Equals method (because, that like fails all over
24039 the place). We still do not use it.
24041 * class.cs (TypeContainer.SetRequiredInterface,
24042 TypeContainer.RequireMethods): Killed these two routines and moved
24043 all the functionality to RegisterRequiredImplementations.
24045 (TypeContainer.RegisterRequiredImplementations): This routine now
24046 registers all the implementations required in an array for the
24047 interfaces and abstract methods. We use an array of structures
24048 which can be computed ahead of time to reduce memory usage and we
24049 also assume that lookups are cheap as most classes will not
24050 implement too many interfaces.
24052 We also avoid creating too many MethodSignatures.
24054 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24055 clear the "pending" bit if we find that there are problems with
24058 (TypeContainer.VerifyPendingMethods): Update to report errors of
24059 methods that look like implementations but are not.
24061 (TypeContainer.Define): Add support for explicit interface method
24064 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24066 * typemanager.cs: Keep track of the parameters here instead of
24067 being a feature of the TypeContainer.
24069 * class.cs: Drop the registration of parameters here, as
24070 InterfaceMethods are also interface declarations.
24072 * delegate.cs: Register methods with the TypeManager not only with
24073 the TypeContainer. This code was buggy.
24075 * interface.cs: Full registation here.
24077 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24079 * expression.cs: Remove reducer for binary expressions, it can not
24082 * const.cs: Put here the code that used to go into constant.cs
24084 * constant.cs: Put here the code for constants, this is a new base
24085 class for Literals.
24087 * literal.cs: Make Literal derive from Constant.
24089 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24091 * statement.cs (Return.Emit): Report error 157 if the user
24092 attempts to return from a finally block.
24094 (Return.Emit): Instead of emitting a return, jump to the end of
24097 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24098 LocalBuilder to store the result of the function. ReturnLabel is
24099 the target where we jump.
24102 2001-12-09 Radek Doulik <rodo@ximian.com>
24104 * cs-parser.jay: remember alias in current namespace
24106 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24109 * class.cs (LookupAlias): lookup alias in my_namespace
24111 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24113 (LookupAlias): lookup alias in this and if needed in parent
24116 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24120 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24121 making things static. I need this to avoid passing the
24122 TypeContainer when calling ParameterType.
24124 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24125 that did string manipulation to compute the type and then call
24126 GetType. Use Parameter.ParameterType instead.
24128 * cs-tokenizer.cs: Consume the suffix for floating values.
24130 * expression.cs (ParameterReference): figure out whether this is a
24131 reference parameter or not. Kill an extra variable by computing
24132 the arg_idx during emission.
24134 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24135 function that returns whether a parameter is an out/ref value or not.
24137 (Parameter.ParameterType): The type of the parameter (base,
24138 without ref/out applied).
24140 (Parameter.Resolve): Perform resolution here.
24141 (Parameter.ExternalType): The full type (with ref/out applied).
24143 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24144 support for expressions on the using statement.
24146 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24148 * statement.cs (Using.EmitLocalVariableDecls): Split the
24149 localvariable handling of the using statement.
24151 (Block.EmitMeta): Keep track of variable count across blocks. We
24152 were reusing slots on separate branches of blocks.
24154 (Try.Emit): Emit the general code block, we were not emitting it.
24156 Check the type of the declaration to be an IDisposable or
24157 something that can be implicity converted to it.
24159 Emit conversions if required.
24161 * ecore.cs (EmptyExpression): New utility class.
24162 (Expression.ImplicitConversionExists): New utility function.
24164 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24166 * statement.cs (Using): Implement.
24168 * expression.cs (LocalVariableReference): Support read only variables.
24170 * statement.cs: Remove the explicit emit for the Leave opcode.
24171 (VariableInfo): Add a readonly field.
24173 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24175 * ecore.cs (ConvCast): new class used to encapsulate the various
24176 explicit integer conversions that works in both checked and
24177 unchecked contexts.
24179 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24180 properly generate the overflow opcodes.
24182 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24184 * statement.cs: The correct type for the EmptyExpression is the
24185 element_type, not the variable type. Ravi pointed this out.
24187 2001-12-04 Ravi Pratap <ravi@ximian.com>
24189 * class.cs (Method::Define): Handle PInvoke methods specially
24190 by using DefinePInvokeMethod instead of the usual one.
24192 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24193 above to do the task of extracting information and defining the method.
24195 2001-12-04 Ravi Pratap <ravi@ximian.com>
24197 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24198 of the condition for string type.
24200 (Emit): Move that here.
24202 (ArrayCreation::CheckIndices): Keep string literals in their expression
24205 (EmitDynamicInitializers): Handle strings appropriately.
24207 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24209 * codegen.cs (EmitContext): Replace multiple variables with a
24210 single pointer to the current Switch statement.
24212 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24215 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24219 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24222 (Foreach.Emit): Foreach on arrays was not setting
24223 up the loop variables (for break/continue).
24225 (GotoCase): Semi-implented.
24227 2001-12-03 Ravi Pratap <ravi@ximian.com>
24229 * attribute.cs (CheckAttribute): Handle system attributes by using
24230 Attribute.GetAttributes to examine information we need.
24232 (GetValidPlaces): Same here.
24234 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24236 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24238 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24240 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24242 (Method::Emit): Handle the case when we are a PInvoke method.
24244 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24246 * expression.cs: Use ResolveWithSimpleName on compound names.
24248 2001-12-02 Ravi Pratap <ravi@ximian.com>
24250 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24251 before trying to reduce it.
24253 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24255 * constant.cs (LookupConstantValue): Implement.
24257 (EmitConstant): Use the above in emitting the constant.
24259 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24260 that are user-defined by doing a LookupConstantValue on them.
24262 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24265 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24267 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24269 (BaseAccess.DoResolve): Implement.
24271 (MemberAccess.DoResolve): Split this routine into a
24272 ResolveMemberAccess routine that can be used independently
24274 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24276 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24277 As that share bits of the implementation. Is returns a boolean,
24278 while As returns the Type that is being probed.
24280 2001-12-01 Ravi Pratap <ravi@ximian.com>
24282 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24283 instead of a Literal - much easier.
24285 (EnumInTransit): Remove - utterly useless :-)
24287 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24289 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24291 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24292 chain when we have no associated expression.
24294 2001-11-30 Ravi Pratap <ravi@ximian.com>
24296 * constant.cs (Define): Use Location while reporting the errror.
24298 Also emit a warning when 'new' is used and there is no inherited
24301 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24304 (LookupEnumValue): Implement to lookup an enum member's value and define it
24307 (Populate): Re-write accordingly to use the above routine.
24309 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24311 * expression.cs (This): Fix prototype for DoResolveLValue to
24312 override the base class DoResolveLValue.
24314 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24317 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24318 (we need to load the address of the field here). This fixes
24321 (FieldExpr.DoResolveLValue): Call the DoResolve
24322 function to initialize the Instance expression.
24324 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24325 correctly the GetEnumerator operation on a value type.
24327 * cs-parser.jay: Add more simple parsing error catches.
24329 * statement.cs (Switch): Add support for string switches.
24330 Handle null specially.
24332 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24334 2001-11-28 Ravi Pratap <ravi@ximian.com>
24336 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24338 (declare_local_constant): New helper function.
24340 * statement.cs (AddConstant): Keep a separate record of constants
24342 (IsConstant): Implement to determine if a variable is a constant.
24344 (GetConstantExpression): Implement.
24346 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24348 * statement.cs (IsVariableDefined): Re-write.
24350 2001-11-27 Ravi Pratap <ravi@ximian.com>
24352 * class.cs (TypeContainer::FindMembers): Look for constants
24353 in the case when we are looking for MemberTypes.Field
24355 * expression.cs (MemberAccess::DoResolve): Check that in the
24356 case we are a FieldExpr and a Literal, we are not being accessed
24357 by an instance reference.
24359 * cs-parser.jay (local_constant_declaration): Implement.
24361 (declaration_statement): Implement for constant declarations.
24363 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24365 * statement.cs (Switch): Catch double defaults.
24367 (Switch): More work on the switch() statement
24368 implementation. It works for integral values now, need to finish
24372 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24374 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24375 integer literals into other integer literals. To be used by
24378 2001-11-24 Ravi Pratap <ravi@ximian.com>
24380 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24383 (EmitDynamicInitializers): Cope with the above since we extract data
24384 directly from ArrayData now.
24386 (ExpectInitializers): Keep track of whether initializers are mandatory
24389 (Bounds): Make it a hashtable to prevent the same dimension being
24390 recorded for every element in that dimension.
24392 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24395 Also fix bug which was causing the indices to be emitted in the reverse
24398 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24400 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24401 unfinished. They do not work, because the underlying code is
24404 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24406 * cs-parser.jay: Remove bogus fixme.
24408 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24409 on Switch statement.
24411 2001-11-23 Ravi Pratap <ravi@ximian.com>
24413 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24416 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24417 parameter. Apparently, any expression is allowed.
24419 (ValidateInitializers): Update accordingly.
24421 (CheckIndices): Fix some tricky bugs thanks to recursion.
24423 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24424 I was being completely brain-dead.
24426 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24427 and re-write acordingly.
24429 (DelegateInvocation): Re-write accordingly.
24431 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24433 (MakeByteBlob): Handle types more correctly.
24435 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24436 initialization from expressions but it is incomplete because I am a complete
24439 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24441 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24442 on If. Basically, we have to return `true' (ie, we do return to
24443 our caller) only if both branches of the if return.
24445 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24446 short-circuit operators, handle them as short circuit operators.
24448 (Cast.DoResolve): Resolve type.
24449 (Cast.Cast): Take an expression as the target type.
24451 * cs-parser.jay (cast_expression): Remove old hack that only
24452 allowed a limited set of types to be handled. Now we take a
24453 unary_expression and we resolve to a type during semantic
24456 Use the grammar productions from Rhys to handle casts (this is
24457 not complete like Rhys syntax yet, we fail to handle that corner
24458 case that C# has regarding (-x), but we will get there.
24460 2001-11-22 Ravi Pratap <ravi@ximian.com>
24462 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24463 field which is an array type.
24465 * cs-parser.jay (declare_local_variables): Support array initialization too.
24467 * typemanager.cs (MakeKey): Implement.
24469 (everywhere): Use the above appropriately.
24471 * cs-parser.jay (for_statement): Update for array initialization while
24472 declaring variables.
24474 * ecore.cs : The error message was correct, it's the variable's names that
24475 were misleading ;-) Make the code more readable.
24477 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24478 the correct type etc.
24480 (ConvertExplicit): Handle Enum types by examining the underlying type.
24482 2001-11-21 Ravi Pratap <ravi@ximian.com>
24484 * parameter.cs (GetCallingConvention): Always return
24485 CallingConventions.Standard for now.
24487 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24489 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24490 and `r' after calling DoNumericPromotions.
24492 * ecore.cs: Fix error message (the types were in the wrong order).
24494 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24495 BindingFlags.Instance as well
24497 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24498 implicit int literal conversion in an empty cast so that we
24499 propagate the right type upstream.
24501 (UnboxCast): new class used to unbox value types.
24502 (Expression.ConvertExplicit): Add explicit type conversions done
24505 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24506 the target type before applying the implicit LongLiterals to ULong
24509 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24511 * cs-parser.jay (for_statement): Reworked the way For works: now
24512 we declare manually any variables that are introduced in
24513 for_initializer to solve the problem of having out-of-band code
24514 emition (that is what got for broken).
24516 (declaration_statement): Perform the actual variable declaration
24517 that used to be done in local_variable_declaration here.
24519 (local_variable_declaration): Do not declare anything, just pass
24520 the information on a DictionaryEntry
24522 2001-11-20 Ravi Pratap <ravi@ximian.com>
24524 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24525 re-write of the logic to now make it recursive.
24527 (UpdateIndices): Re-write accordingly.
24529 Store element data in a separate ArrayData list in the above methods.
24531 (MakeByteBlob): Implement to dump the array data into a byte array.
24533 2001-11-19 Ravi Pratap <ravi@ximian.com>
24535 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24538 * constant.cs (Define): Implement.
24540 (EmitConstant): Re-write fully.
24542 Pass in location info.
24544 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24547 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24548 DictionaryEntry since we need location info too.
24550 (constant_declaration): Update accordingly.
24552 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24553 code into another method : UpdateIndices.
24555 2001-11-18 Ravi Pratap <ravi@ximian.com>
24557 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24558 some type checking etc.
24560 2001-11-17 Ravi Pratap <ravi@ximian.com>
24562 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24563 bits to provide dimension info if the user skips doing that.
24565 Update second constructor to store the rank correctly.
24567 2001-11-16 Ravi Pratap <ravi@ximian.com>
24569 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24570 and try to implement.
24572 * ../errors/cs0150.cs : Add.
24574 * ../errors/cs0178.cs : Add.
24576 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24578 * statement.cs: Implement foreach on multi-dimensional arrays.
24580 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24581 name of the params argument.
24583 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24584 initializing the array.
24586 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24587 we can use this elsewhere.
24589 * statement.cs: Finish implementation of foreach for single
24592 * cs-parser.jay: Use an out-of-band stack to pass information
24593 around, I wonder why I need this.
24595 foreach_block: Make the new foreach_block the current_block.
24597 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24598 function used to return a static Parameters structure. Used for
24599 empty parameters, as those are created very frequently.
24601 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24603 2001-11-15 Ravi Pratap <ravi@ximian.com>
24605 * interface.cs : Default modifier is private, not public. The
24606 make verify test passes again.
24608 2001-11-15 Ravi Pratap <ravi@ximian.com>
24610 * support.cs (ReflectionParameters): Fix logic to determine
24611 whether the last parameter is a params one. Test 9 passes again.
24613 * delegate.cs (Populate): Register the builders we define with
24614 RegisterParameterForBuilder. Test 19 passes again.
24616 * cs-parser.jay (property_declaration): Reference $6 instead
24617 of $$ to get at the location.
24619 (indexer_declaration): Similar stuff.
24621 (attribute): Ditto.
24623 * class.cs (Property): Register parameters for the Get and Set methods
24624 if they exist. Test 23 passes again.
24626 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24627 call to EmitArguments as we are sure there aren't any params arguments.
24628 Test 32 passes again.
24630 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24631 IndexOutOfRangeException.
24633 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24634 Test 33 now passes again.
24636 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24638 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24639 broke a bunch of things. Will have to come up with a better way
24640 of tracking locations.
24642 * statement.cs: Implemented foreach for single dimension arrays.
24644 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24646 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24647 an error. This removes the lookup from the critical path.
24649 * cs-parser.jay: Removed use of temporary_loc, which is completely
24652 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24654 * support.cs (ReflectionParameters.ParameterModifier): Report
24655 whether the argument is a PARAMS argument or not.
24657 * class.cs: Set the attribute `ParamArrayAttribute' on the
24658 parameter argument.
24660 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24661 and cons_param_array_attribute (ConstructorInfo for
24662 ParamArrayAttribute).,
24664 * codegen.cs: Emit the return using the `Return' statement, that
24665 way we can report the error correctly for missing return values.
24667 * class.cs (Method.Emit): Clean up.
24669 * expression.cs (Argument.Resolve): Take another argument: the
24670 location where this argument is used. Notice that this is not
24671 part of the "Argument" class as to reduce the size of the
24672 structure (we know the approximate location anyways).
24674 Test if the argument is a variable-reference, if not, then
24675 complain with a 206.
24677 (Argument.Emit): Emit addresses of variables.
24679 (Argument.FullDesc): Simplify.
24681 (Invocation.DoResolve): Update for Argument.Resolve.
24683 (ElementAccess.DoResolve): ditto.
24685 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24686 method should be virtual, as this method is always virtual.
24688 (NewDelegate.DoResolve): Update for Argument.Resolve.
24690 * class.cs (ConstructorInitializer.DoResolve): ditto.
24692 * attribute.cs (Attribute.Resolve): ditto.
24694 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24696 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24698 * expression.cs (ParameterReference): Drop IStackStorage and implement
24699 IAssignMethod instead.
24701 (LocalVariableReference): ditto.
24703 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24704 IAssignMethod instead.
24706 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24708 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24709 enumerations that are used in heavily used structures derive from
24710 byte in a laughable and pathetic attempt to reduce memory usage.
24711 This is the kind of pre-optimzations that you should not do at
24712 home without adult supervision.
24714 * expression.cs (UnaryMutator): New class, used to handle ++ and
24715 -- separatedly from the other unary operators. Cleans up the
24716 code, and kills the ExpressionStatement dependency in Unary.
24718 (Unary): Removed `method' and `Arguments' from this class, making
24719 it smaller, and moving it all to SimpleCall, so I can reuse this
24720 code in other locations and avoid creating a lot of transient data
24721 strucutres when not required.
24723 * cs-parser.jay: Adjust for new changes.
24725 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24727 * enum.cs (Enum.Populate): If there is a failure during
24730 * cs-parser.jay (opt_enum_base): we used to catch type errors
24731 here, but this is really incorrect. The type error should be
24732 catched during semantic analysis.
24734 2001-12-11 Ravi Pratap <ravi@ximian.com>
24736 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24737 current_local_parameters as expected since I, in my stupidity, had forgotten
24740 * attribute.cs (GetValidPlaces): Fix stupid bug.
24742 * class.cs (Method::Emit): Perform check on applicability of attributes.
24744 (Constructor::Emit): Ditto.
24746 (Field::Emit): Ditto.
24748 (Field.Location): Store location information.
24750 (Property, Event, Indexer, Operator): Ditto.
24752 * cs-parser.jay (field_declaration): Pass in location for each field.
24754 * ../errors/cs0592.cs : Add.
24756 2001-11-12 Ravi Pratap <ravi@ximian.com>
24758 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24760 (InitCoreTypes): Update accordingly.
24762 (RegisterAttrType, LookupAttr): Implement.
24764 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24765 info about the same.
24767 (Resolve): Update to populate the above as necessary.
24769 (Error592): Helper.
24771 (GetValidPlaces): Helper to the above.
24773 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24775 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24777 2001-11-12 Ravi Pratap <ravi@ximian.com>
24779 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24781 * ../errors/cs0617.cs : Add.
24783 2001-11-11 Ravi Pratap <ravi@ximian.com>
24785 * enum.cs (Emit): Rename to Populate to be more consistent with what
24786 we expect it to do and when exactly it is called.
24788 * class.cs, rootcontext.cs : Update accordingly.
24790 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24791 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24793 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24795 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24796 of a fieldinfo using the above, when dealing with a FieldBuilder.
24798 2001-11-10 Ravi Pratap <ravi@ximian.com>
24800 * ../errors/cs0031.cs : Add.
24802 * ../errors/cs1008.cs : Add.
24804 * ../errrors/cs0543.cs : Add.
24806 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24809 (FindMembers): Implement.
24811 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24812 enums and delegates too.
24814 (enum_types): Rename to builder_to_enum.
24816 (delegate_types): Rename to builder_to_delegate.
24818 * delegate.cs (FindMembers): Implement.
24820 2001-11-09 Ravi Pratap <ravi@ximian.com>
24822 * typemanager.cs (IsEnumType): Implement.
24824 * enum.cs (Emit): Re-write parts to account for the underlying type
24825 better and perform checking etc.
24827 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24828 of the underlying type.
24830 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24833 * enum.cs (error31): Helper to report error #31.
24835 * cs-parser.jay (enum_declaration): Store location of each member too.
24837 * enum.cs (member_to_location): New hashtable.
24839 (AddEnumMember): Update location hashtable.
24841 (Emit): Use the location of each member while reporting errors.
24843 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24845 * cs-parser.jay: A for_initializer if is a
24846 local_variable_declaration really ammount to have an implicit
24847 block with the variable declaration and no initializer for for.
24849 * statement.cs (For.Emit): Cope with null initializers.
24851 This fixes the infinite loop on for initializers.
24853 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24855 * enum.cs: More cleanup.
24857 * ecore.cs: Remove dead code.
24859 * class.cs (Property.Emit): More simplification.
24860 (Event.Emit): ditto.
24862 Reworked to have less levels of indentation.
24864 2001-11-08 Ravi Pratap <ravi@ximian.com>
24866 * class.cs (Property): Emit attributes.
24876 * enum.cs (Emit): Ditto.
24878 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24881 * class.cs (Field, Event, etc.): Move attribute generation into the
24882 Emit method everywhere.
24884 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24885 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24886 as we had no way of defining nested enums !
24888 * rootcontext.cs : Adjust code accordingly.
24890 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24892 2001-11-07 Ravi Pratap <ravi@ximian.com>
24894 * expression.cs (EvalConstantExpression): Move into ecore.cs
24896 * enum.cs (Enum): Rename some members and make them public and readonly
24897 according to our convention.
24899 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24902 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24904 (Enum::Emit): Write a simple version for now which doesn't try to compute
24905 expressions. I shall modify this to be more robust in just a while.
24907 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24909 (TypeContainer::CloseType): Create the Enum types too.
24911 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24913 * expression.cs (EvalConstantExpression): Get rid of completely.
24915 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24916 user-defined values and other cases.
24918 (IsValidEnumLiteral): Helper function.
24920 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24921 out there in the case we had a literal FieldExpr.
24923 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24925 (Literalize): Revamp a bit to take two arguments.
24927 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24929 2001-11-06 Ravi Pratap <ravi@ximian.com>
24931 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24933 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24935 (Resolve): Use the above to ensure we have proper initializers.
24937 2001-11-05 Ravi Pratap <ravi@ximian.com>
24939 * expression.cs (Expression::EvalConstantExpression): New method to
24940 evaluate constant expressions.
24942 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24944 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24946 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24949 (Binary.ResolveOperator): Handle operator != (object a, object b)
24950 and operator == (object a, object b);
24952 (Binary.DoNumericPromotions): Indicate whether the numeric
24953 promotion was possible.
24955 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24958 Made the ArrayAccess implement interface IAssignMethod instead of
24959 IStackStore as the order in which arguments are passed reflects
24962 * assign.cs: Instead of using expr.ExprClass to select the way of
24963 assinging, probe for the IStackStore/IAssignMethod interfaces.
24965 * typemanager.cs: Load InitializeArray definition.
24967 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24968 static data that can be used to initialize arrays.
24970 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24972 * expression.cs: Handle operator== and operator!= for booleans.
24974 (Conditioal.Reduce): Implement reducer for the ?: operator.
24976 (Conditional.Resolve): Implement dead code elimination.
24978 (Binary.Resolve): Catch string literals and return a new
24979 concatenated string.
24981 (Unary.Reduce): Implement reduction of unary expressions.
24983 * ecore.cs: Split out the expression core handling here.
24985 (Expression.Reduce): New method used to perform constant folding
24986 and CSE. This is needed to support constant-expressions.
24988 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24989 targets, and optimize for !x.
24991 2001-11-04 Ravi Pratap <ravi@ximian.com>
24993 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24994 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24995 set custom atttributes.
24997 * literal.cs (Literal::GetValue): New abstract method to return the actual
24998 value of the literal, cast as an object.
25000 (*Literal): Implement GetValue method.
25002 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25003 expressions to the arraylist but objects of type Argument.
25005 * class.cs (TypeContainer::Emit): Emit our attributes too.
25007 (Method::Emit, Constructor::Emit): Ditto.
25009 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25010 to be ignoring earlier.
25012 2001-11-03 Ravi Pratap <ravi@ximian.com>
25014 * attribute.cs (AttributeSection::Define): Implement to do the business
25015 of constructing a CustomAttributeBuilder.
25017 (Attribute): New trivial class. Increases readability of code.
25019 * cs-parser.jay : Update accordingly.
25021 (positional_argument_list, named_argument_list, named_argument): New rules
25023 (attribute_arguments): Use the above so that we are more correct.
25025 2001-11-02 Ravi Pratap <ravi@ximian.com>
25027 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25028 to perform all checks for a method with a params parameter.
25030 (Invocation::OverloadResolve): Update to use the above method and therefore
25031 cope correctly with params method invocations.
25033 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25036 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25037 constructors in our parent too because we can't afford to miss out on
25040 * attribute.cs (AttributeSection): New name for the class Attribute
25042 Other trivial changes to improve readability.
25044 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25045 use the new class names.
25047 2001-11-01 Ravi Pratap <ravi@ximian.com>
25049 * class.cs (Method::Define): Complete definition for params types too
25051 (Indexer::Define): Ditto.
25053 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25054 Cope everywhere with a request for info about the array parameter.
25056 2001-11-01 Ravi Pratap <ravi@ximian.com>
25058 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25060 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25061 local_variable_type to extract the string corresponding to the type.
25063 (local_variable_type): Fixup the action to use the new helper method.
25065 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25068 * expression.cs : Clean out code which uses the above.
25070 2001-10-31 Ravi Pratap <ravi@ximian.com>
25072 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25073 and bale out if necessary by returning a false.
25075 (RegisterProperty): Ditto.
25077 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25078 and print out appropriate error messages.
25080 * interface.cs (everywhere): Ditto.
25082 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25083 location to constructor.
25085 * class.cs (Property, Event, Indexer): Update accordingly.
25087 * ../errors/cs111.cs : Added.
25089 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25090 of a method, as laid down by the spec.
25092 (Invocation::OverloadResolve): Use the above method.
25094 2001-10-31 Ravi Pratap <ravi@ximian.com>
25096 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25097 now take a TypeContainer and a Parameters object.
25099 (ParameterData): Modify return type of ParameterModifier method to be
25100 Parameter.Modifier and not a string.
25102 (ReflectionParameters, InternalParameters): Update accordingly.
25104 * expression.cs (Argument::GetParameterModifier): Same here.
25106 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25107 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25108 symbol in it at all so maybe this is only for now.
25110 2001-10-30 Ravi Pratap <ravi@ximian.com>
25112 * support.cs (InternalParameters): Constructor now takes an extra argument
25113 which is the actual Parameters class.
25115 (ParameterDesc): Update to provide info on ref/out modifiers.
25117 * class.cs (everywhere): Update call to InternalParameters to pass in
25118 the second argument too.
25120 * support.cs (ParameterData): Add ParameterModifier, which is a method
25121 to return the modifier info [ref/out etc]
25123 (InternalParameters, ReflectionParameters): Implement the above.
25125 * expression.cs (Argument::ParameterModifier): Similar function to return
25126 info about the argument's modifiers.
25128 (Invocation::OverloadResolve): Update to take into account matching modifiers
25131 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25132 a new SetFormalParameters object which we pass to InternalParameters.
25134 2001-10-30 Ravi Pratap <ravi@ximian.com>
25136 * expression.cs (NewArray): Merge into the ArrayCreation class.
25138 2001-10-29 Ravi Pratap <ravi@ximian.com>
25140 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25141 NewUserdefinedArray into one as there wasn't much of a use in having
25144 * expression.cs (Argument): Change field's name to ArgType from Type.
25146 (Type): New readonly property which returns the proper type, taking into
25147 account ref/out modifiers.
25149 (everywhere): Adjust code accordingly for the above.
25151 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25152 whether we are emitting for a ref or out parameter.
25154 * expression.cs (Argument::Emit): Use the above field to set the state.
25156 (LocalVariableReference::Emit): Update to honour the flag and emit the
25159 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25161 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25163 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25165 (ReflectionParameters, InternalParameters): Implement the above method.
25167 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25170 (Invocation::FullMethodDesc): Ditto.
25172 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25174 * cs-parser.jay: Add extra production for the second form of array
25177 * expression.cs (ArrayCreation): Update to reflect the above
25180 * Small changes to prepare for Array initialization.
25182 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25184 * typemanager.cs (ImplementsInterface): interface might be null;
25185 Deal with this problem;
25187 Also, we do store negative hits on the cache (null values), so use
25188 this instead of calling t.GetInterfaces on the type everytime.
25190 2001-10-28 Ravi Pratap <ravi@ximian.com>
25192 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25194 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25195 split functionality out into different classes.
25197 (New::FormArrayType): Move into NewBuiltinArray.
25199 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25202 (NewBuiltinArray): New class to handle creation of built-in arrays.
25204 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25205 account creation of one-dimensional arrays.
25207 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25209 (NewUserdefinedArray::DoResolve): Implement.
25211 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25213 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25214 we maintain inside the TypeManager. This is necessary to perform lookups on the
25217 (LookupType): Update to perform GetType on the module builders too.
25219 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25221 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25223 2001-10-23 Ravi Pratap <ravi@ximian.com>
25225 * expression.cs (New::DoResolve): Implement guts of array creation.
25227 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25229 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25231 * expression.cs: Fix bug I introduced lsat night that broke
25234 (Expression.Resolve): Report a 246 error (can not resolve name)
25235 if we find a SimpleName in the stream.
25237 (Expression.ResolveLValue): Ditto.
25239 (Expression.ResolveWithSimpleName): This function is a variant of
25240 ResolveName, this one allows SimpleNames to be returned without a
25241 warning. The only consumer of SimpleNames is MemberAccess
25243 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25245 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25246 might arrive here. I have my doubts that this is correct.
25248 * statement.cs (Lock): Implement lock statement.
25250 * cs-parser.jay: Small fixes to support `lock' and `using'
25252 * cs-tokenizer.cs: Remove extra space
25254 * driver.cs: New flag --checked, allows to turn on integer math
25257 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25258 Threading.Monitor.Exit
25260 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25262 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25263 Expression Class to be IndexerAccess.
25265 Notice that Indexer::DoResolve sets the eclass to Value.
25267 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25269 * class.cs (TypeContainer::Emit): Emit code for indexers.
25271 * assign.cs (IAssignMethod): New interface implemented by Indexers
25272 and Properties for handling assignment.
25274 (Assign::Emit): Simplify and reuse code.
25276 * expression.cs (IndexerAccess, PropertyExpr): Implement
25277 IAssignMethod, clean up old code.
25279 2001-10-22 Ravi Pratap <ravi@ximian.com>
25281 * typemanager.cs (ImplementsInterface): New method to determine if a type
25282 implements a given interface. Provides a nice cache too.
25284 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25287 (ConvertReferenceExplicit): Ditto.
25289 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25290 various methods, with correct names etc.
25292 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25293 Operator.UnaryNegation.
25295 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25296 we have a unary plus or minus operator.
25298 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25301 * everywhere : update accordingly.
25303 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25306 * class.cs (Method::Define): For the case where we are implementing a method
25307 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25308 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25310 2001-10-21 Ravi Pratap <ravi@ximian.com>
25312 * interface.cs (FindMembers): Implement to work around S.R.E
25315 * typemanager.cs (IsInterfaceType): Implement.
25317 (FindMembers): Update to handle interface types too.
25319 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25320 use IsAssignableFrom as that is not correct - it doesn't work.
25322 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25323 and accordingly override EmitStatement.
25325 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25326 using the correct logic :-)
25328 2001-10-19 Ravi Pratap <ravi@ximian.com>
25330 * ../errors/cs-11.cs : Add to demonstrate error -11
25332 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25334 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25335 then pass this as a hint to ResolveLValue.
25337 * expression.cs (FieldExpr): Add Location information
25339 (FieldExpr::LValueResolve): Report assignment to readonly
25342 (Expression::ExprClassFromMemberInfo): Pass location information.
25344 (Expression::ResolveLValue): Add new method that resolves an
25347 (Expression::DoResolveLValue): Default invocation calls
25350 (Indexers): New class used to keep track of indexers in a given
25353 (IStackStore): Renamed from LValue, as it did not really describe
25354 what this did. Also ResolveLValue is gone from this interface and
25355 now is part of Expression.
25357 (ElementAccess): Depending on the element access type
25359 * typemanager.cs: Add `indexer_name_type' as a Core type
25360 (System.Runtime.CompilerServices.IndexerNameAttribute)
25362 * statement.cs (Goto): Take a location.
25364 2001-10-18 Ravi Pratap <ravi@ximian.com>
25366 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25367 if two delegates are compatible.
25369 (NewDelegate::DoResolve): Update to take care of the case when
25370 we instantiate a delegate from another delegate.
25372 * typemanager.cs (FindMembers): Don't even try to look up members
25373 of Delegate types for now.
25375 2001-10-18 Ravi Pratap <ravi@ximian.com>
25377 * delegate.cs (NewDelegate): New class to take care of delegate
25380 * expression.cs (New): Split the delegate related code out into
25381 the NewDelegate class.
25383 * delegate.cs (DelegateInvocation): New class to handle delegate
25386 * expression.cs (Invocation): Split out delegate related code into
25387 the DelegateInvocation class.
25389 2001-10-17 Ravi Pratap <ravi@ximian.com>
25391 * expression.cs (New::DoResolve): Implement delegate creation fully
25392 and according to the spec.
25394 (New::DoEmit): Update to handle delegates differently.
25396 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25397 because of which we were printing out arguments in reverse order !
25399 * delegate.cs (VerifyMethod): Implement to check if the given method
25400 matches the delegate.
25402 (FullDelegateDesc): Implement.
25404 (VerifyApplicability): Implement.
25406 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25407 delegate invocations too.
25409 (Invocation::Emit): Ditto.
25411 * ../errors/cs1593.cs : Added.
25413 * ../errors/cs1594.cs : Added.
25415 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25417 2001-10-16 Ravi Pratap <ravi@ximian.com>
25419 * typemanager.cs (intptr_type): Core type for System.IntPtr
25421 (InitCoreTypes): Update for the same.
25423 (iasyncresult_type, asynccallback_type): Ditto.
25425 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25428 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25431 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25432 the builders for the 4 members of a delegate type :-)
25434 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25437 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25439 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25441 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25443 * statement.cs (Break::Emit): Implement.
25444 (Continue::Emit): Implement.
25446 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25447 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25448 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25449 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25452 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25453 properties that track the label for the current loop (begin of the
25454 loop and end of the loop).
25456 2001-10-15 Ravi Pratap <ravi@ximian.com>
25458 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25459 use of emitting anything at all.
25461 * class.cs, rootcontext.cs : Get rid of calls to the same.
25463 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25465 (Populate): Define the constructor correctly and set the implementation
25468 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25471 (AddDelegateType): Implement.
25473 (IsDelegateType): Implement helper method.
25475 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25477 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25478 and accordingly handle it.
25480 * delegate.cs (Populate): Take TypeContainer argument.
25481 Implement bits to define the Invoke method. However, I still haven't figured out
25482 how to take care of the native int bit :-(
25484 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25485 Qualify the name of the delegate, not its return type !
25487 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25490 (StandardConversionExists): Checking for array types turns out to be recursive.
25492 (ConvertReferenceExplicit): Implement array conversion.
25494 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25496 2001-10-12 Ravi Pratap <ravi@ximian.com>
25498 * cs-parser.jay (delegate_declaration): Store the fully qualified
25499 name as it is a type declaration.
25501 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25504 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25505 as TypeContainer::DefineType.
25507 (Populate): Method in which all the definition of the various methods (Invoke)
25510 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25513 (CloseDelegate): Finally creates the delegate.
25515 * class.cs (TypeContainer::DefineType): Update to define delegates.
25516 (Populate, Emit and CloseType): Do the same thing here too.
25518 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25519 delegates in all these operations.
25521 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25523 * expression.cs: LocalTemporary: a new expression used to
25524 reference a temporary that has been created.
25526 * assign.cs: Handle PropertyAccess back here, so that we can
25527 provide the proper semantic access to properties.
25529 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25530 a few more explicit conversions.
25532 * modifiers.cs: `NEW' modifier maps to HideBySig.
25534 * expression.cs (PropertyExpr): Make this into an
25535 ExpressionStatement, and support the EmitStatement code path.
25537 Perform get/set error checking, clean up the interface.
25539 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25540 them into toplevel access objects.
25542 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25544 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25547 * typemanager.cs: Keep track here of our PropertyBuilders again to
25548 work around lameness in SRE.
25550 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25552 * expression.cs (LValue::LValueResolve): New method in the
25553 interface, used to perform a second resolution pass for LValues.
25555 (This::DoResolve): Catch the use of this in static methods.
25557 (This::LValueResolve): Implement.
25559 (This::Store): Remove warning, assigning to `this' in structures
25562 (Invocation::Emit): Deal with invocation of
25563 methods on value types. We need to pass the address to structure
25564 methods rather than the object itself. (The equivalent code to
25565 emit "this" for structures leaves the entire structure on the
25566 stack instead of a pointer to it).
25568 (ParameterReference::DoResolve): Compute the real index for the
25569 argument based on whether the method takes or not a `this' pointer
25570 (ie, the method is static).
25572 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25573 value types returned from functions when we need to invoke a
25574 method on the sturcture.
25577 2001-10-11 Ravi Pratap <ravi@ximian.com>
25579 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25580 defining the type in the Modulebuilder or Typebuilder. This is to take
25581 care of nested types which need to be defined on the TypeBuilder using
25582 DefineNestedMethod.
25584 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25585 methods in RootContext, only ported to be part of TypeContainer.
25587 (TypeContainer::GetInterfaceOrClass): Ditto.
25589 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25591 * interface.cs (Interface::DefineInterface): New method. Does exactly
25592 what RootContext.CreateInterface did earlier, only it takes care of nested types
25595 (Interface::GetInterfaces): Move from RootContext here and port.
25597 (Interface::GetInterfaceByName): Same here.
25599 * rootcontext.cs (ResolveTree): Re-write.
25601 (PopulateTypes): Re-write.
25603 * class.cs (TypeContainer::Populate): Populate nested types too.
25604 (TypeContainer::Emit): Emit nested members too.
25606 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25607 instead just use the name argument passed in as it is already fully
25610 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25611 to TypeContainer mapping to see if a type is user-defined.
25613 * class.cs (TypeContainer::CloseType): Implement.
25615 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25616 the default constructor.
25618 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25621 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25623 * interface.cs (CloseType): Create the type here.
25625 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25628 Remove all the methods which are now in TypeContainer.
25630 2001-10-10 Ravi Pratap <ravi@ximian.com>
25632 * delegate.cs (Define): Re-write bits to define the delegate
25635 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25637 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25639 * expression.cs (ImplicitReferenceConversion): handle null as well
25640 as a source to convert to any reference type.
25642 * statement.cs (Return): Perform any implicit conversions to
25643 expected return type.
25645 Validate use of return statement.
25647 * codegen.cs (EmitContext): Pass the expected return type here.
25649 * class.cs (Method, Constructor, Property): Pass expected return
25650 type to EmitContext.
25652 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25654 * expression.cs: Make DoResolve take an EmitContext instead of a
25657 Replaced `l' and `location' for `loc', for consistency.
25659 (Error, Warning): Remove unneeded Tc argument.
25661 * assign.cs, literal.cs, constant.cs: Update to new calling
25664 * codegen.cs: EmitContext now contains a flag indicating whether
25665 code is being generated in a static method or not.
25667 * cs-parser.jay: DecomposeQI, new function that replaces the old
25668 QualifiedIdentifier. Now we always decompose the assembled
25669 strings from qualified_identifier productions into a group of
25672 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25674 * rootcontext.cs: Deal with field-less struct types correctly now
25675 by passing the size option to Define Type.
25677 * class.cs: Removed hack that created one static field.
25679 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25681 * statement.cs: Moved most of the code generation here.
25683 2001-10-09 Ravi Pratap <ravi@ximian.com>
25685 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25688 (ElementAccess): Remove useless bits for now - keep checks as the spec
25691 2001-10-08 Ravi Pratap <ravi@ximian.com>
25693 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25694 and start performing checks according to the spec.
25696 2001-10-07 Ravi Pratap <ravi@ximian.com>
25698 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25699 rank_specifiers instead.
25701 (rank_specifiers): Change the order in which the rank specifiers are stored
25703 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25705 * expression.cs (ElementAccess): Implement the LValue interface too.
25707 2001-10-06 Ravi Pratap <ravi@ximian.com>
25709 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25710 except that user defined conversions are not included.
25712 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25713 perform the conversion of the return type, if necessary.
25715 (New::DoResolve): Check whether we are creating an array or an object
25716 and accordingly do the needful.
25718 (New::Emit): Same here.
25720 (New::DoResolve): Implement guts of array creation.
25722 (New::FormLookupType): Helper function.
25724 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25726 * codegen.cs: Removed most of the code generation here, and move the
25727 corresponding code generation bits to the statement classes.
25729 Added support for try/catch/finalize and throw.
25731 * cs-parser.jay: Added support for try/catch/finalize.
25733 * class.cs: Catch static methods having the flags override,
25734 virtual or abstract.
25736 * expression.cs (UserCast): This user cast was not really doing
25737 what it was supposed to do. Which is to be born in fully resolved
25738 state. Parts of the resolution were being performed at Emit time!
25742 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25744 * expression.cs: Implicity convert the result from UserCast.
25746 2001-10-05 Ravi Pratap <ravi@ximian.com>
25748 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25749 prevented it from working correctly.
25751 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25752 merely ConvertImplicit.
25754 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25756 * typemanager.cs: Make the LookupTypeContainer function static,
25757 and not per-instance.
25759 * class.cs: Make static FindMembers (the one that takes a Type
25762 * codegen.cs: Add EmitForeach here.
25764 * cs-parser.jay: Make foreach a toplevel object instead of the
25765 inline expansion, as we need to perform semantic analysis on it.
25767 2001-10-05 Ravi Pratap <ravi@ximian.com>
25769 * expression.cs (Expression::ImplicitUserConversion): Rename to
25770 UserDefinedConversion.
25772 (Expression::UserDefinedConversion): Take an extra argument specifying
25773 whether we look for explicit user conversions too.
25775 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25777 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25779 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25780 with the appropriate arguments.
25782 * cs-parser.jay (cast_expression): Record location too.
25784 * expression.cs (Cast): Record location info.
25786 (Expression::ConvertExplicit): Take location argument.
25788 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25789 to determine if we are doing explicit conversions.
25791 (UserCast::Emit): Update accordingly.
25793 (Expression::ConvertExplicit): Report an error if everything fails.
25795 * ../errors/cs0030.cs : Add.
25797 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25799 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25800 virtual and newslot bits.
25802 * class.cs (TypeContainer::RegisterRequiredImplementations):
25803 Record methods we need.
25805 (TypeContainer::MakeKey): Helper function to make keys for
25806 MethodBases, since the Methodbase key is useless.
25808 (TypeContainer::Populate): Call RegisterRequiredImplementations
25809 before defining the methods.
25811 Create a mapping for method_builders_to_methods ahead of time
25812 instead of inside a tight loop.
25814 (::RequireMethods): Accept an object as the data to set into the
25815 hashtable so we can report interface vs abstract method mismatch.
25817 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25819 * report.cs: Make all of it static.
25821 * rootcontext.cs: Drop object_type and value_type computations, as
25822 we have those in the TypeManager anyways.
25824 Drop report instance variable too, now it is a global.
25826 * driver.cs: Use try/catch on command line handling.
25828 Add --probe option to debug the error reporting system with a test
25831 * report.cs: Add support for exiting program when a probe
25832 condition is reached.
25834 2001-10-03 Ravi Pratap <ravi@ximian.com>
25836 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25837 we do a forcible conversion regardless of type, to check if
25838 ForceConversion returns a null.
25840 (Binary::error19): Use location to report error.
25842 (Unary::error23): Use location here too.
25844 * ../errors/cs0019.cs : Check in.
25846 * ../errors/cs0023.cs : Check in.
25848 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25849 case of a non-null MethodInfo object with a length of 0 !
25851 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25852 an applicable member - according to the spec :-)
25853 Also fix logic to find members in base types.
25855 (Unary::ResolveOperator): Same here.
25857 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25858 as I was getting thoroughly confused between this and error19 :-)
25860 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25861 (::FindMostEncompassedType): Implement.
25862 (::FindMostEncompassingType): Implement.
25863 (::StandardConversionExists): Implement.
25865 (UserImplicitCast): Re-vamp. We now need info about most specific
25866 source and target types so that we can do the necessary conversions.
25868 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25869 mathematical union with no duplicates.
25871 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25873 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25874 in order from base classes to child classes, so that we can in
25875 child classes look up in our parent for method names and
25876 attributes (required for handling abstract, virtual, new, override
25877 constructs: we need to instrospect our base class, and if we dont
25878 populate the classes in order, the introspection might be
25879 incorrect. For example, a method could query its parent before
25880 the parent has any methods and would determine that the parent has
25881 no abstract methods (while it could have had them)).
25883 (RootContext::CreateType): Record the order in which we define the
25886 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25888 * class.cs (TypeContainer::Populate): Also method definitions can
25889 fail now, keep track of this.
25891 (TypeContainer::FindMembers): Implement support for
25892 DeclaredOnly/noDeclaredOnly flag.
25894 (Constructor::Emit) Return the ConstructorBuilder.
25896 (Method::Emit) Return the MethodBuilder.
25897 Check for abstract or virtual methods to be public.
25899 * rootcontext.cs (RootContext::CreateType): Register all the
25900 abstract methods required for the class to be complete and the
25901 interface methods that must be implemented.
25903 * cs-parser.jay: Report error 501 (method requires body if it is
25904 not marked abstract or extern).
25906 * expression.cs (TypeOf::Emit): Implement.
25908 * typemanager.cs: runtime_handle_type, new global type.
25910 * class.cs (Property::Emit): Generate code for properties.
25912 2001-10-02 Ravi Pratap <ravi@ximian.com>
25914 * expression.cs (Unary::ResolveOperator): Find operators on base type
25915 too - we now conform exactly to the spec.
25917 (Binary::ResolveOperator): Same here.
25919 * class.cs (Operator::Define): Fix minor quirk in the tests.
25921 * ../errors/cs0215.cs : Added.
25923 * ../errors/cs0556.cs : Added.
25925 * ../errors/cs0555.cs : Added.
25927 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25929 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25930 single integer which is really efficient
25932 2001-10-01 Ravi Pratap <ravi@ximian.com>
25934 * expression.cs (Expression::ImplicitUserConversion): Use location
25935 even in the case when we are examining True operators.
25937 * class.cs (Operator::Define): Perform extensive checks to conform
25938 with the rules for operator overloading in the spec.
25940 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25941 some of the other conversions mentioned in the spec.
25943 * typemanager.cs (array_type): New static member for the System.Array built-in
25946 (cloneable_interface): For System.ICloneable interface.
25948 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25949 we start resolving the tree and populating types.
25951 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25953 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25955 * expression.cs (Expression::ExprClassFromMemberInfo,
25956 Expression::Literalize): Create literal expressions from
25957 FieldInfos which are literals.
25959 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25960 type casts, because they were wrong. The test suite in tests
25963 (ImplicitNumericConversion): ushort to ulong requires a widening
25966 Int32 constant to long requires widening cast as well.
25968 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25969 for integers because the type on the stack is not i4.
25971 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25973 * expression.cs (report118): require location argument.
25975 * parameter.cs: Do not dereference potential null value.
25977 * class.cs: Catch methods that lack the `new' keyword when
25978 overriding a name. Report warnings when `new' is used without
25979 anything being there to override.
25981 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25983 * class.cs: Only add constructor to hashtable if it is non-null
25984 (as now constructors can fail on define).
25986 (TypeManager, Class, Struct): Take location arguments.
25988 Catch field instance initialization in structs as errors.
25990 accepting_filter: a new filter for FindMembers that is static so
25991 that we dont create an instance per invocation.
25993 (Constructor::Define): Catch errors where a struct constructor is
25996 * cs-parser.jay: Pass location information for various new
25999 * delegate.cs (Delegate): take a location argument.
26001 * driver.cs: Do not call EmitCode if there were problesm in the
26002 Definition of the types, as many Builders wont be there.
26004 * decl.cs (Decl::Decl): Require a location argument.
26006 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26007 into integers, and find the most appropiate integer for it.
26009 * literal.cs: Implement ULongLiteral.
26011 * rootcontext.cs: Provide better information about the location of
26012 failure when CreateType fails.
26014 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26016 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26019 * expression.cs (Binary::CheckShiftArguments): Add missing type
26021 (Binary::ResolveOperator): Add type to the logical and and logical
26022 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26025 (Binary::DoNumericPromotions): In the case where either argument
26026 is ulong (and most signed types combined with ulong cause an
26027 error) perform implicit integer constant conversions as well.
26029 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26031 * expression.cs (UserImplicitCast): Method should always be
26033 (Invocation::BetterConversion): Simplified test for IntLiteral.
26035 (Expression::ImplicitNumericConversion): Split this routine out.
26036 Put the code that performs implicit constant integer conversions
26039 (Expression::Resolve): Become a wrapper around DoResolve so we can
26040 check eclass and type being set after resolve.
26042 (Invocation::Badness): Remove this dead function
26044 (Binary::ResolveOperator): Do not compute the expensive argumnets
26045 unless we have a union for it.
26047 (Probe::Emit): Is needs to do an isinst and then
26048 compare against null.
26050 (::CanConvert): Added Location argument. If the Location argument
26051 is null (Location.Null), then we do not report errors. This is
26052 used by the `probe' mechanism of the Explicit conversion. We do
26053 not want to generate an error for something that the user
26054 explicitly requested to be casted. But the pipeline for an
26055 explicit cast first tests for potential implicit casts.
26057 So for now, if the Location is null, it means `Probe only' to
26058 avoid adding another argument. Might have to revise this
26061 (ClassCast): New class used to type cast objects into arbitrary
26062 classes (used in Explicit Reference Conversions).
26064 Implement `as' as well.
26066 Reverted all the patches from Ravi below: they were broken:
26068 * The use of `level' as a mechanism to stop recursive
26069 invocations is wrong. That was there just to catch the
26070 bug with a strack trace but not as a way of addressing
26073 To fix the problem we have to *understand* what is going
26074 on and the interactions and come up with a plan, not
26075 just get things going.
26077 * The use of the type conversion cache that I proposed
26078 last night had an open topic: How does this work across
26079 protection domains. A user defined conversion might not
26080 be public in the location where we are applying the
26081 conversion, a different conversion might be selected
26082 (ie, private A->B (better) but public B->A (worse),
26083 inside A, A->B applies, but outside it, B->A will
26086 * On top of that (ie, even if the above is solved),
26087 conversions in a cache need to be abstract. Ie, `To
26088 convert from an Int to a Short use an OpcodeCast', not
26089 `To convert from an Int to a Short use the OpcodeCast on
26090 the variable 5' (which is what this patch was doing).
26092 2001-09-28 Ravi Pratap <ravi@ximian.com>
26094 * expression.cs (Invocation::ConversionExists): Re-write to use
26095 the conversion cache
26097 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26098 cache all conversions done, not just user-defined ones.
26100 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26101 to determine if a conversion exists instead of acutually trying to
26102 perform the conversion. It's faster too.
26104 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26105 and only then attempt the implicit conversion.
26107 2001-09-28 Ravi Pratap <ravi@ximian.com>
26109 * expression.cs (ConvertImplicit): Use a cache for conversions
26110 already found. Check level of recursion and bail out if necessary.
26112 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26114 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26115 Export standard methods that we expect for string operations.
26117 * statement.cs (Block::UsageWarning): Track usage of variables and
26118 report the errors for not used variables.
26120 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26123 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26125 * codegen.cs: remove unnneded code
26127 * expression.cs: Removed BuiltinTypeAccess class
26129 Fix the order in which implicit conversions are
26132 The previous fixed dropped support for boxed conversions (adding a
26133 test to the test suite now)
26135 (UserImplicitCast::CanConvert): Remove test for source being null,
26136 that code is broken. We should not feed a null to begin with, if
26137 we do, then we should track the bug where the problem originates
26138 and not try to cover it up here.
26140 Return a resolved expression of type UserImplicitCast on success
26141 rather than true/false. Ravi: this is what I was talking about,
26142 the pattern is to use a static method as a "constructor" for
26145 Also, do not create arguments until the very last minute,
26146 otherwise we always create the arguments even for lookups that
26147 will never be performed.
26149 (UserImplicitCast::Resolve): Eliminate, objects of type
26150 UserImplicitCast are born in a fully resolved state.
26152 * typemanager.cs (InitCoreTypes): Init also value_type
26153 (System.ValueType).
26155 * expression.cs (Cast::Resolve): First resolve the child expression.
26157 (LValue): Add new method AddressOf to be used by
26160 Change the argument of Store to take an EmitContext instead of an
26161 ILGenerator, because things like FieldExpr need to be able to call
26162 their children expression to generate the instance code.
26164 (Expression::Error, Expression::Warning): Sugar functions for
26167 (Expression::MemberLookup): Accept a TypeContainer instead of a
26168 Report as the first argument.
26170 (Expression::ResolvePrimary): Killed. I still want to improve
26171 this as currently the code is just not right.
26173 (Expression::ResolveMemberAccess): Simplify, but it is still
26176 (Unary::Resolve): Catch errors in AddressOf operators.
26178 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26179 index to a byte for the short-version, or the compiler will choose
26180 the wrong Emit call, which generates the wrong data.
26182 (ParameterReference::Emit, ::Store): same.
26184 (FieldExpr::AddressOf): Implement.
26186 * typemanager.cs: TypeManager: made public variable instead of
26189 * driver.cs: document --fatal.
26191 * report.cs (ErrorMessage, WarningMessage): new names for the old
26192 Error and Warning classes.
26194 * cs-parser.jay (member_access): Turn built-in access to types
26195 into a normal simplename
26197 2001-09-27 Ravi Pratap <ravi@ximian.com>
26199 * expression.cs (Invocation::BetterConversion): Fix to cope
26200 with q being null, since this was introducing a bug.
26202 * expression.cs (ConvertImplicit): Do built-in conversions first.
26204 2001-09-27 Ravi Pratap <ravi@ximian.com>
26206 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26208 2001-09-27 Ravi Pratap <ravi@ximian.com>
26210 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26211 I had introduced long ago (what's new ?).
26213 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26214 the work of all the checking.
26215 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26216 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26218 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26219 that is the right way.
26221 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26222 overloading resolution. Use everywhere instead of cutting and pasting code.
26224 (Binary::ResolveOperator): Use MakeUnionSet.
26226 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26227 we have to convert to bool types. Not complete yet.
26229 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26231 * typemanager.cs (TypeManager::CSharpName): support ushort.
26233 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26234 to provide an expression that performsn an implicit constant int
26235 conversion (section 6.1.6).
26236 (Expression::ConvertImplicitRequired): Reworked to include
26237 implicit constant expression conversions.
26239 (Expression::ConvertNumericExplicit): Finished.
26241 (Invocation::Emit): If InstanceExpression is null, then it means
26242 that we perform a call on this.
26244 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26246 * expression.cs (Unary::Emit): Remove some dead code.
26247 (Probe): Implement Resolve and Emit for `is'.
26248 (Expression::ConvertImplicitRequired): Attempt to do constant
26249 expression conversions here. Maybe should be moved to
26250 ConvertImplicit, but I am not sure.
26251 (Expression::ImplicitLongConstantConversionPossible,
26252 Expression::ImplicitIntConstantConversionPossible): New functions
26253 that tell whether is it possible to apply an implicit constant
26254 expression conversion.
26256 (ConvertNumericExplicit): Started work on explicit numeric
26259 * cs-parser.jay: Update operator constants.
26261 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26262 (Parameters::GetSignature): Hook up VerifyArgs here.
26263 (Parameters::VerifyArgs): Verifies that no two arguments have the
26266 * class.cs (Operator): Update the operator names to reflect the
26267 ones that the spec expects (as we are just stringizing the
26270 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26271 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26272 previous usage did only work for our methods.
26273 (Expression::ConvertImplicit): Handle decimal implicit numeric
26274 conversions as well.
26275 (Expression::InternalTypeConstructor): Used to invoke constructors
26276 on internal types for default promotions.
26278 (Unary::Emit): Implement special handling for the pre/post
26279 increment/decrement for overloaded operators, as they need to have
26280 the same semantics as the other operators.
26282 (Binary::ResolveOperator): ditto.
26283 (Invocation::ConversionExists): ditto.
26284 (UserImplicitCast::Resolve): ditto.
26286 2001-09-26 Ravi Pratap <ravi@ximian.com>
26288 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26289 operator, return after emitting body. Regression tests pass again !
26291 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26292 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26293 (Invocation::OverloadResolve): Ditto.
26294 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26296 * everywhere : update calls to the above methods accordingly.
26298 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26300 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26302 * expression.cs (ExpressionStatement): New base class used for
26303 expressions that can appear in statements, so that we can provide
26304 an alternate path to generate expression that do not leave a value
26307 (Expression::Emit, and all the derivatives): We no longer return
26308 whether a value is left on the stack or not. Every expression
26309 after being emitted leaves a single value on the stack.
26311 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26312 facilties of ExpressionStatement if possible.
26314 * cs-parser.jay: Update statement_expression.
26316 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26318 * driver.cs: Change the wording of message
26320 2001-09-25 Ravi Pratap <ravi@ximian.com>
26322 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26323 the type of the expression to the return type of the method if
26324 we have an overloaded operator match ! The regression tests pass again !
26325 (Unary::ResolveOperator): Ditto.
26327 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26328 to find "op_Implicit", not "implicit" ;-)
26329 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26330 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26332 * everywhere : Correct calls to the above accordingly.
26334 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26335 (ConvertImplicit): Do user-defined conversion if it exists.
26337 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26339 * assign.cs: track location.
26340 (Resolve): Use implicit conversions on assignment.
26342 * literal.cs: Oops. Not good, Emit of short access values should
26343 pass (Bytes) or the wrong argument will be selected.
26345 * expression.cs (Unary::Emit): Emit code for -expr.
26347 (Unary::ResolveOperator): Handle `Substract' for non-constants
26348 (substract from zero from the non-constants).
26349 Deal with Doubles as well.
26351 (Expression::ConvertImplicitRequired): New routine that reports an
26352 error if no implicit conversion exists.
26354 (Invocation::OverloadResolve): Store the converted implicit
26355 expressions if we make them
26357 2001-09-24 Ravi Pratap <ravi@ximian.com>
26359 * class.cs (ConstructorInitializer): Take a Location argument.
26360 (ConstructorBaseInitializer): Same here.
26361 (ConstructorThisInitializer): Same here.
26363 * cs-parser.jay : Update all calls accordingly.
26365 * expression.cs (Unary, Binary, New): Take location argument.
26366 Update accordingly everywhere.
26368 * cs-parser.jay : Update all calls to the above to take a location
26371 * class.cs : Ditto.
26373 2001-09-24 Ravi Pratap <ravi@ximian.com>
26375 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26376 (Invocation::BetterConversion): Same here
26377 (Invocation::ConversionExists): Ditto.
26379 (Invocation::ConversionExists): Implement.
26381 2001-09-22 Ravi Pratap <ravi@ximian.com>
26383 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26384 Also take an additional TypeContainer argument.
26386 * All over : Pass in TypeContainer as argument to OverloadResolve.
26388 * typemanager.cs (CSharpName): Update to check for the string type and return
26391 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26394 2001-09-21 Ravi Pratap <ravi@ximian.com>
26396 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26397 (Invocation::BetterFunction): Implement.
26398 (Invocation::BetterConversion): Implement.
26399 (Invocation::ConversionExists): Skeleton, no implementation yet.
26401 Okay, things work fine !
26403 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26405 * typemanager.cs: declare and load enum_type, delegate_type and
26408 * expression.cs (Expression::Emit): Now emit returns a value that
26409 tells whether a value is left on the stack or not. This strategy
26410 might be reveted tomorrow with a mechanism that would address
26411 multiple assignments.
26412 (Expression::report118): Utility routine to report mismatches on
26415 (Unary::Report23): Report impossible type/operator combination
26418 (Unary::IsIncrementableNumber): Whether the type can be
26419 incremented or decremented with add.
26420 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26422 (Unary::ResolveOperator): Implement ++, !, ~,
26424 (Invocation::Emit): Deal with new Emit convetion.
26426 * All Expression derivatives: Updated their Emit method to return
26427 whether they leave values on the stack or not.
26429 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26430 stack for expressions that are statements.
26432 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26434 * expression.cs (LValue): New interface. Must be implemented by
26436 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26439 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26440 interface for generating code, simplifies the code.
26442 2001-09-20 Ravi Pratap <ravi@ximian.com>
26444 * expression.cs (everywhere): Comment out return statements in ::Resolve
26445 methods to avoid the warnings.
26447 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26449 * driver.cs (parse): Report error 2001 if we can not open the
26452 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26455 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26458 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26459 otherwise nested blocks end up with the same index.
26461 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26463 * expression.cs: Instead of having FIXMEs in the Resolve
26464 functions, throw exceptions so it is obvious that we are facing a
26467 * cs-parser.jay (invocation_expression): Pass Location information.
26469 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26470 Use a basename for those routines because .NET does not like paths
26473 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26476 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26478 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26479 are loading the correct data types (throws an exception if not).
26480 (TypeManager::InitCoreTypes): Use CoreLookupType
26482 * expression.cs (Unary::ResolveOperator): return the child
26483 expression for expressions which are just +expr.
26484 (Unary::ResolveOperator): Return negative literals for -LITERAL
26485 expressions (otherwise they are Unary {Literal}).
26486 (Invocation::Badness): Take into account `Implicit constant
26487 expression conversions'.
26489 * literal.cs (LongLiteral): Implement long literal class.
26490 (IntLiteral): export the `Value' of the intliteral.
26492 2001-09-19 Ravi Pratap <ravi@ximian.com>
26494 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26496 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26497 instead of 'Operator'
26499 * expression.cs (Binary::ResolveOperator): Update accordingly.
26500 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26503 * cs-parser.jay (unary_expression): Update to use the new names.
26505 * gen-treedump.cs (GetUnary): Same here.
26507 * expression.cs (Unary::Resolve): Implement.
26508 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26509 operators are found instead of making noise ;-)
26510 (Unary::ResolveOperator): New method to do precisely the same thing which
26511 Binary::ResolveOperator does for Binary expressions.
26512 (Unary.method, .Arguments): Add.
26513 (Unary::OperName): Implement.
26514 (Unary::ForceConversion): Copy and Paste !
26516 * class.cs (Operator::Define): Fix a small bug for the case when we have
26519 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26520 for the inbuilt operators. Only overloading works for now ;-)
26522 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26524 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26525 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26527 * expression.cs (This::Emit): Implement.
26528 (This::Resolve): Implement.
26529 (TypeOf:Resolve): Implement.
26530 (Expression::ResolveSimpleName): Add an implicit this to instance
26532 (MemberAccess::Resolve): Deal with Parameters and Fields.
26533 Bind instance variable to Field expressions.
26534 (FieldExpr::Instance): New field used to track the expression that
26535 represents the object instance.
26536 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26538 (FieldExpr::Emit): Implement.
26540 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26541 the last instruction contains a return opcode to avoid generating
26542 the last `ret' instruction (this generates correct code, and it is
26543 nice to pass the peverify output).
26545 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26546 initializer for static and instance variables.
26547 (Constructor::Emit): Allow initializer to be null in the case of
26548 static constructors. Only emit initializer for instance
26551 (TypeContainer::FindMembers): Return a null array if there are no
26554 Also fix the code for the MemberTypes.Method branch, as it was not
26555 scanning that for operators (or tried to access null variables before).
26557 * assign.cs (Assign::Emit): Handle instance and static fields.
26561 * driver.cs: Stop compilation if there are parse errors.
26563 * cs-parser.jay (constructor_declaration): Provide default base
26564 initializer for non-static constructors.
26565 (constructor_declarator): Do not provide a default base
26566 initializers if none was specified.
26567 Catch the fact that constructors should not have parameters.
26569 * class.cs: Do not emit parent class initializers for static
26570 constructors, that should be flagged as an error.
26572 2001-09-18 Ravi Pratap <ravi@ximian.com>
26574 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26575 Move back code into TypeContainer::Populate.
26577 2001-09-18 Ravi Pratap <ravi@ximian.com>
26579 * class.cs (TypeContainer::AddConstructor): Fix the check to
26580 compare against Name, not Basename.
26581 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26583 * cs-parser.jay : Update accordingly.
26585 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26586 for methods, don't forget to look into the operators too.
26587 (RegisterMethodBuilder): Helper method to take care of this for
26588 methods, constructors and operators.
26589 (Operator::Define): Completely revamp.
26590 (Operator.OperatorMethod, MethodName): New fields.
26591 (TypeContainer::Populate): Move the registering of builders into
26592 RegisterMethodBuilder.
26593 (Operator::Emit): Re-write.
26595 * expression.cs (Binary::Emit): Comment out code path to emit method
26596 invocation stuff for the case when we have a user defined operator. I am
26597 just not able to get it right !
26599 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26601 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26604 (Expression::MemberLookup): Provide a version that allows to
26605 specify the MemberTypes and BindingFlags.
26607 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26608 so it was not fetching variable information from outer blocks.
26610 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26611 Beforefieldinit as it was buggy.
26613 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26614 that Ravi put here.
26616 * class.cs (Constructor::Emit): Only emit if block is not null.
26617 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26618 deal with this by semantically definining it as if the user had
26621 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26622 constructors as we now "emit" them at a higher level.
26624 (TypeContainer::DefineDefaultConstructor): Used to define the
26625 default constructors if none was provided.
26627 (ConstructorInitializer): Add methods Resolve and Emit.
26629 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26631 2001-09-17 Ravi Pratap <ravi@ximian.com>
26633 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26634 the default constructor builder with our hashtable for methodbuilders
26637 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26638 and argument_count is 0 in which case we have a match.
26639 (Binary::ResolveOperator): More null checking and miscellaneous coding
26642 2001-09-17 Ravi Pratap <ravi@ximian.com>
26644 * rootcontext.cs (IsNameSpace): Compare against null.
26646 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26648 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26649 and Unary::Operator.
26651 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26654 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26655 we have overloaded operators.
26656 (Binary::ResolveOperator): Implement the part which does the operator overload
26659 * class.cs (Operator::Emit): Implement.
26660 (TypeContainer::Emit): Emit the operators we have too.
26662 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26663 the case when we have a user-defined operator.
26665 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26667 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26669 2001-09-16 Ravi Pratap <ravi@ximian.com>
26671 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26672 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26673 (Constructor::Emit): Implement.
26674 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26675 if we have no work to do.
26676 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26679 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26680 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26682 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26685 2001-09-15 Ravi Pratap <ravi@ximian.com>
26687 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26689 (Tree::RecordNamespace): Method to do what the name says ;-)
26690 (Tree::Namespaces): Property to get at the namespaces hashtable.
26692 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26695 * rootcontext.cs (IsNamespace): Fixed it :-)
26697 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26699 * class.cs (TypeContainer::FindMembers): Add support for
26701 (MethodCore): New class that encapsulates both the shared aspects
26702 of a Constructor and a Method.
26703 (Method, Constructor): Factored pieces into MethodCore.
26705 * driver.cs: Added --fatal which makes errors throw exceptions.
26706 Load System assembly as well as part of the standard library.
26708 * report.cs: Allow throwing exceptions on errors for debugging.
26710 * modifiers.cs: Do not use `parent', instead use the real type
26711 container to evaluate permission settings.
26713 * class.cs: Put Ravi's patch back in. He is right, and we will
26714 have to cope with the
26716 2001-09-14 Ravi Pratap <ravi@ximian.com>
26718 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26719 FamORAssem, not FamANDAssem.
26721 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26723 * driver.cs: Added --parse option that only parses its input files
26726 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26727 incorrect. IsTopLevel is not used to tell whether an object is
26728 root_types or not (that can be achieved by testing this ==
26729 root_types). But to see if this is a top-level *class* (not
26730 necessarly our "toplevel" container).
26732 2001-09-14 Ravi Pratap <ravi@ximian.com>
26734 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26735 parent instead of a direct call to GetType.
26737 2001-09-14 Ravi Pratap <ravi@ximian.com>
26739 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26740 Modifiers.TypeAttr. This should just be a call to that method.
26742 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26743 object so that we can determine if we are top-level or not.
26745 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26748 * enum.cs (Enum::Define): Ditto.
26750 * modifiers.cs (FieldAttr): Re-write.
26752 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26753 (TypeContainer::HaveStaticConstructor): New property to provide access
26754 to precisely that info.
26756 * modifiers.cs (MethodAttr): Re-write.
26757 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26759 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26760 of top-level types as claimed.
26762 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26764 * expression.cs (MemberLookup): Fruitless attempt to lookup
26765 constructors. Maybe I need to emit default constructors? That
26766 might be it (currently .NET emits this for me automatically).
26767 (Invocation::OverloadResolve): Cope with Arguments == null.
26768 (Invocation::EmitArguments): new function, shared by the new
26769 constructor and us.
26770 (Invocation::Emit): Handle static and instance methods. Emit
26771 proper call instruction for virtual or non-virtual invocations.
26772 (New::Emit): Implement.
26773 (New::Resolve): Implement.
26774 (MemberAccess:Resolve): Implement.
26775 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26776 to track instances.
26777 (FieldExpr::Resolve): Set type.
26779 * support.cs: Handle empty arguments.
26781 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26782 SimpleLookup): Auxiliary routines to help parse a qualifier
26785 Update qualifier_identifier rule.
26787 * codegen.cs: Removed debugging messages.
26789 * class.cs: Make this a global thing, this acts just as a "key" to
26790 objects that we might have around.
26792 (Populate): Only initialize method_builders_to_methods once.
26794 * expression.cs (PropertyExpr): Initialize type from the
26797 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26798 Resolve pattern. Attempt to implicitly convert value to boolean.
26801 * expression.cs: Set the type for the int32/int32 argument case.
26802 (Binary::ResolveOperator): Set the return type to boolean for
26803 comparission operators
26805 * typemanager.cs: Remove debugging print code.
26807 (Invocation::Resolve): resolve type.
26809 * class.cs: Allocate a MemberInfo of the correct size, as the code
26810 elsewhere depends on the test to reflect the correct contents.
26812 (Method::) Keep track of parameters, due to System.Reflection holes
26814 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26817 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26818 of the exact size and return that.
26820 (Class::LookupMethodByBuilder): New function that maps
26821 MethodBuilders to its methods. Required to locate the information
26822 on methods because System.Reflection bit us again.
26824 * support.cs: New file, contains an interface ParameterData and
26825 two implementations: ReflectionParameters and InternalParameters
26826 used to access Parameter information. We will need to grow this
26829 * expression.cs (Invocation::GetParameterData): implement a cache
26830 and a wrapper around the ParameterData creation for methods.
26831 (Invocation::OverloadResolve): Use new code.
26833 2001-09-13 Ravi Pratap <ravi@ximian.com>
26835 * class.cs (TypeContainer::EmitField): Remove and move into
26836 (Field::Define): here and modify accordingly.
26837 (Field.FieldBuilder): New member.
26838 (TypeContainer::Populate): Update accordingly.
26839 (TypeContainer::FindMembers): Implement.
26841 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26843 * statement.cs: (VariableInfo::VariableType): New field to be
26844 initialized with the full type once it is resolved.
26846 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26848 * parameter.cs (GetParameterInfo): Use a type cache to compute
26849 things only once, and to reuse this information
26851 * expression.cs (LocalVariableReference::Emit): Implement.
26852 (OpcodeCast::Emit): fix.
26854 (ParameterReference::Resolve): Implement.
26855 (ParameterReference::Emit): Implement.
26857 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26858 that are expressions need to stay as Expressions.
26860 * typemanager.cs (CSharpName): Returns the C# name of a type if
26863 * expression.cs (Expression::ConvertImplicit): New function that
26864 implements implicit type conversions.
26866 (Expression::ImplicitReferenceConversion): Implements implicit
26867 reference conversions.
26869 (EmptyCast): New type for transparent casts.
26871 (OpcodeCast): New type for casts of types that are performed with
26872 a sequence of bytecodes.
26874 (BoxedCast): New type used for casting value types into reference
26875 types. Emits a box opcode.
26877 (Binary::DoNumericPromotions): Implements numeric promotions of
26878 and computation of the Binary::Type.
26880 (Binary::EmitBranchable): Optimization.
26882 (Binary::Emit): Implement code emission for expressions.
26884 * typemanager.cs (TypeManager): Added two new core types: sbyte
26887 2001-09-12 Ravi Pratap <ravi@ximian.com>
26889 * class.cs (TypeContainer::FindMembers): Method which does exactly
26890 what Type.FindMembers does, only we don't have to use reflection. No
26891 implementation yet.
26893 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26894 typecontainer objects as we need to get at them.
26895 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26897 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26898 typecontainer object.
26900 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26901 of just a Report object.
26903 2001-09-11 Ravi Pratap <ravi@ximian.com>
26905 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26907 (TypeContainer::Populate): Now define the delegates of the type too.
26908 (TypeContainer.Delegates): Property to access the list of delegates defined
26911 * delegates.cs (Delegate::Define): Implement partially.
26913 * modifiers.cs (TypeAttr): Handle more flags.
26915 2001-09-11 Ravi Pratap <ravi@ximian.com>
26917 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26919 (Operator::Define): Re-write logic to get types by using the LookupType method
26920 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26921 (Indexer::Define): Ditto.
26922 (Event::Define): Ditto.
26923 (Property::Define): Ditto.
26925 2001-09-10 Ravi Pratap <ravi@ximian.com>
26927 * class.cs (TypeContainer::Populate): Now define operators too.
26928 (TypeContainer.Operators): New property to access the list of operators
26930 (Operator.OperatorMethodBuilder): New member to hold the method builder
26931 for the operator we are defining.
26932 (Operator::Define): Implement.
26934 2001-09-10 Ravi Pratap <ravi@ximian.com>
26936 * class.cs (Event::Define): Make the prefixes of the accessor methods
26937 addOn_ and removeOn_
26939 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26940 of the location being passed in too. Ideally, this should go later since all
26941 error reporting should be done through the Report object.
26943 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26944 (Populate): Iterate thru the indexers we have and define them too.
26945 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26946 for the get and set accessors.
26947 (Indexer::Define): Implement.
26949 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26951 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26952 my previous implementation, did not work.
26954 * typemanager.cs: Add a couple of missing types (the longs).
26956 * literal.cs: Use TypeManager.bool_type instead of getting it.
26958 * expression.cs (EventExpr): New kind of expressions.
26959 (Expressio::ExprClassFromMemberInfo): finish
26961 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26963 * assign.cs: Emit stores to static fields differently.
26965 2001-09-08 Ravi Pratap <ravi@ximian.com>
26967 * Merge in changes and adjust code to tackle conflicts. Backed out my
26968 code in Assign::Resolve ;-)
26970 2001-09-08 Ravi Pratap <ravi@ximian.com>
26972 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26973 instead Report.Error and also pass in the location.
26974 (CSharpParser::Lexer): New readonly property to return the reference
26975 to the Tokenizer object.
26976 (declare_local_variables): Use Report.Error with location instead of plain
26980 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26981 (Operator.CheckBinaryOperator): Ditto.
26983 * cs-parser.jay (operator_declarator): Update accordingly.
26985 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26986 (CheckBinaryOperator): Same here.
26988 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26989 on the name without any prefixes of namespace names etc. This is because we
26990 already might have something already fully qualified like
26991 'System.Console.WriteLine'
26993 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26995 2001-09-07 Ravi Pratap <ravi@ximian.com>
26997 * cs-tokenizer.cs (location): Return a string which also contains
27000 * expression.cs (ElementAccess): New class for expressions of the
27001 type 'element access.'
27002 (BaseAccess): New class for expressions of the type 'base access.'
27003 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27006 * cs-parser.jay (element_access): Implement action.
27007 (base_access): Implement actions.
27008 (checked_expression, unchecked_expression): Implement.
27010 * cs-parser.jay (local_variable_type): Correct and implement.
27011 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27013 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27015 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27016 name and the specifiers.
27018 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27020 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27021 making them all public ;-)
27023 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27026 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27028 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27030 (FieldExpr, PropertyExprs): New resolved expressions.
27031 (SimpleName::MemberStaticCheck): Perform static checks for access
27032 to non-static fields on static methods. Maybe this should be
27033 generalized for MemberAccesses.
27034 (SimpleName::ResolveSimpleName): More work on simple name
27037 * cs-parser.jay (primary_expression/qualified_identifier): track
27038 the parameter index.
27040 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27041 (EmitContext::EmitBoolExpression): Chain to expression generation
27042 instead of temporary hack.
27043 (::EmitStatementExpression): Put generic expression code generation.
27045 * assign.cs (Assign::Emit): Implement variable assignments to
27046 local variables, parameters and fields.
27048 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27050 * statement.cs (Block::GetVariableInfo): New method, returns the
27051 VariableInfo for a variable name in a block.
27052 (Block::GetVariableType): Implement in terms of GetVariableInfo
27054 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27055 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27057 2001-09-06 Ravi Pratap <ravi@ximian.com>
27059 * cs-parser.jay (operator_declaration): Continue on my quest : update
27060 to take attributes argument.
27061 (event_declaration): Ditto.
27062 (enum_declaration): Ditto.
27063 (indexer_declaration): Ditto.
27065 * class.cs (Operator::Operator): Update constructor accordingly.
27066 (Event::Event): Ditto.
27068 * delegate.cs (Delegate::Delegate): Same here.
27070 * enum.cs (Enum::Enum): Same here.
27072 2001-09-05 Ravi Pratap <ravi@ximian.com>
27074 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27076 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27078 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27079 being passed around as an arraylist.
27080 (Attributes::AddAttribute): Method to add attribute sections.
27082 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27083 (struct_declaration): Update accordingly.
27084 (constant_declaration): Update.
27085 (field_declaration): Update.
27086 (method_header): Update.
27087 (fixed_parameter): Update.
27088 (parameter_array): Ditto.
27089 (property_declaration): Ditto.
27090 (destructor_declaration): Ditto.
27092 * class.cs (Struct::Struct): Update constructors accordingly.
27093 (Class::Class): Ditto.
27094 (Field::Field): Ditto.
27095 (Method::Method): Ditto.
27096 (Property::Property): Ditto.
27097 (TypeContainer::OptAttribute): update property's return type.
27099 * interface.cs (Interface.opt_attributes): New member.
27100 (Interface::Interface): Update to take the extra Attributes argument.
27102 * parameter.cs (Parameter::Parameter): Ditto.
27104 * constant.cs (Constant::Constant): Ditto.
27106 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27107 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27108 the attributes as a parameter.
27109 (InterfaceProperty): Update constructor call.
27110 (InterfaceEvent): Ditto.
27111 (InterfaceMethod): Ditto.
27112 (InterfaceIndexer): Ditto.
27114 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27115 pass the attributes too.
27116 (interface_event_declaration): Ditto.
27117 (interface_property_declaration): Ditto.
27118 (interface_method_declaration): Ditto.
27119 (interface_declaration): Ditto.
27121 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27123 * class.cs (Method::Define): Track the "static Main" definition to
27124 create an entry point.
27126 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27127 EntryPoint if we find it.
27129 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27130 (EmitContext::ig): Make this variable public.
27132 * driver.cs: Make the default output file be the first file name
27133 with the .exe extension.
27135 Detect empty compilations
27137 Handle various kinds of output targets. Handle --target and
27138 rename -t to --dumper.
27140 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27141 methods inherited from Expression return now an Expression. This
27142 will is used during the tree rewriting as we resolve them during
27145 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27146 the spec. Missing entirely is the information about
27147 accessability of elements of it.
27149 (Expression::ExprClassFromMemberInfo): New constructor for
27150 Expressions that creates a fully initialized Expression based on
27151 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27154 (Invocation::Resolve): Begin implementing resolution of invocations.
27156 * literal.cs (StringLiteral): Implement Emit.
27158 2001-09-05 Ravi Pratap <ravi@ximian.com>
27160 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27163 2001-09-04 Ravi Pratap <ravi@ximian.com>
27165 * cs-parser.jay (attribute_arguments): Implement actions.
27166 (attribute): Fix bug in production. Implement action.
27167 (attribute_list): Implement.
27168 (attribute_target): Implement.
27169 (attribute_target_specifier, opt_target_specifier): Implement
27170 (CheckAttributeTarget): New method to check if the attribute target
27172 (attribute_section): Implement.
27173 (opt_attributes): Implement.
27175 * attribute.cs : New file to handle attributes.
27176 (Attribute): Class to hold attribute info.
27178 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27179 (attribute_section): Modify production to use 2 different rules to
27180 achieve the same thing. 1 s/r conflict down !
27181 Clean out commented, useless, non-reducing dimension_separator rules.
27183 * class.cs (TypeContainer.attributes): New member to hold list
27184 of attributes for a type.
27185 (Struct::Struct): Modify to take one more argument, the attribute list.
27186 (Class::Class): Ditto.
27187 (Field::Field): Ditto.
27188 (Method::Method): Ditto.
27189 (Property::Property): Ditto.
27191 * cs-parser.jay (struct_declaration): Update constructor call to
27192 pass in the attributes too.
27193 (class_declaration): Ditto.
27194 (constant_declaration): Ditto.
27195 (field_declaration): Ditto.
27196 (method_header): Ditto.
27197 (fixed_parameter): Ditto.
27198 (parameter_array): Ditto.
27199 (property_declaration): Ditto.
27201 * constant.cs (Constant::Constant): Update constructor similarly.
27202 Use System.Collections.
27204 * parameter.cs (Parameter::Parameter): Update as above.
27206 2001-09-02 Ravi Pratap <ravi@ximian.com>
27208 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27209 (TypeContainer.delegates): New member to hold list of delegates.
27211 * cs-parser.jay (delegate_declaration): Implement the action correctly
27212 this time as I seem to be on crack ;-)
27214 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27216 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27217 tell whether an identifier represents a namespace.
27219 * expression.cs (NamespaceExpr): A namespace expression, used only
27220 temporarly during expression resolution.
27221 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27222 utility functions to resolve names on expressions.
27224 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27226 * codegen.cs: Add hook for StatementExpressions.
27228 * class.cs: Fix inverted test for static flag in methods.
27230 2001-09-02 Ravi Pratap <ravi@ximian.com>
27232 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27233 to make it coincide with MS' number.
27234 (Operator::CheckBinaryOperator): Ditto.
27236 * ../errors/errors.txt : Remove error numbers added earlier.
27238 * ../errors/cs1019.cs : Test case for error # 1019
27240 * ../errros/cs1020.cs : Test case for error # 1020
27242 * cs-parser.jay : Clean out commented cruft.
27243 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27244 used anywhere - non-reducing rule.
27245 (namespace_declarations): Non-reducing rule - comment out.
27247 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27248 with TypeContainer::AddEnum.
27250 * delegate.cs : New file for delegate handling classes.
27251 (Delegate): Class for declaring delegates.
27253 * makefile : Update.
27255 * cs-parser.jay (delegate_declaration): Implement.
27257 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27259 * class.cs (Event::Define): Implement.
27260 (Event.EventBuilder): New member.
27262 * class.cs (TypeContainer::Populate): Update to define all enums and events
27264 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27265 readonly fields for all these cases ?
27267 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27269 * class.cs (Property): Revamp to use the convention of making fields readonly.
27270 Accordingly modify code elsewhere.
27272 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27273 the Define method of the Property class.
27275 * class.cs : Clean up applied patch and update references to variables etc. Fix
27277 (TypeContainer::Populate): Update to define all the properties we have. Also
27278 define all enumerations.
27280 * enum.cs (Define): Implement.
27282 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27284 * cs-parser.jay (overloadable_operator): The semantic value is an
27285 enum of the Operator class.
27286 (operator_declarator): Implement actions.
27287 (operator_declaration): Implement.
27289 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27290 validity of definitions.
27291 (Operator::CheckBinaryOperator): Static method to check for binary operators
27292 (TypeContainer::AddOperator): New method to add an operator to a type.
27294 * cs-parser.jay (indexer_declaration): Added line to actually call the
27295 AddIndexer method so it gets added ;-)
27297 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27298 already taken care of by the MS compiler ?
27300 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27302 * class.cs (Operator): New class for operator declarations.
27303 (Operator::OpType): Enum for the various operators.
27305 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27307 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27308 ostensibly handle this in semantic analysis.
27310 * cs-parser.jay (general_catch_clause): Comment out
27311 (specific_catch_clauses, specific_catch_clause): Ditto.
27312 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27313 (catch_args, opt_catch_args): New productions.
27314 (catch_clause): Rewrite to use the new productions above
27315 (catch_clauses): Modify accordingly.
27316 (opt_catch_clauses): New production to use in try_statement
27317 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27318 and re-write the code in the actions to extract the specific and
27319 general catch clauses by being a little smart ;-)
27321 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27322 Hooray, try and catch statements parse fine !
27324 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27326 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27327 string from the hashtable of variables.
27329 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27330 I end up making that mistake ;-)
27331 (catch_clauses): Fixed gross error which made Key and Value of the
27332 DictionaryEntry the same : $1 !!
27334 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27336 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27338 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27339 when the add and remove accessors are specified.
27341 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27343 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27344 information about indexer_declarator.
27345 (indexer_declarator): Implement actions.
27346 (parsing_indexer): New local boolean used to keep track of whether
27347 we are parsing indexers or properties. This is necessary because
27348 implicit_parameters come into picture even for the get accessor in the
27349 case of an indexer.
27350 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27352 * class.cs (Indexer): New class for indexer declarations.
27353 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27354 (TypeContainer::indexers): New member to hold list of indexers for the
27357 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27359 * cs-parser.jay (add_accessor_declaration): Implement action.
27360 (remove_accessor_declaration): Implement action.
27361 (event_accessors_declaration): Implement
27362 (variable_declarators): swap statements for first rule - trivial.
27364 * class.cs (Event): New class to hold information about event
27366 (TypeContainer::AddEvent): New method to add an event to a type
27367 (TypeContainer::events): New member to hold list of events.
27369 * cs-parser.jay (event_declaration): Implement actions.
27371 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27373 * cs-parser.jay (dim_separators): Implement. Make it a string
27374 concatenating all the commas together, just as they appear.
27375 (opt_dim_separators): Modify accordingly
27376 (rank_specifiers): Update accordingly. Basically do the same
27377 thing - instead, collect the brackets here.
27378 (opt_rank_sepcifiers): Modify accordingly.
27379 (array_type): Modify to actually return the complete type string
27380 instead of ignoring the rank_specifiers.
27381 (expression_list): Implement to collect the expressions
27382 (variable_initializer): Implement. We make it a list of expressions
27383 essentially so that we can handle the array_initializer case neatly too.
27384 (variable_initializer_list): Implement.
27385 (array_initializer): Make it a list of variable_initializers
27386 (opt_array_initializer): Modify accordingly.
27388 * expression.cs (New::NType): Add enumeration to help us
27389 keep track of whether we have an object/delegate creation
27390 or an array creation.
27391 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27392 members to hold data about array creation.
27393 (New:New): Modify to update NewType
27394 (New:New): New Overloaded contructor for the array creation
27397 * cs-parser.jay (array_creation_expression): Implement to call
27398 the overloaded New constructor.
27400 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27402 * class.cs (TypeContainer::Constructors): Return member
27403 constructors instead of returning null.
27405 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27407 * typemanager.cs (InitCoreTypes): Initialize the various core
27408 types after we have populated the type manager with the user
27409 defined types (this distinction will be important later while
27410 compiling corlib.dll)
27412 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27413 on Expression Classification. Now all expressions have a method
27414 `Resolve' and a method `Emit'.
27416 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27417 generation from working. Also add some temporary debugging
27420 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27422 * codegen.cs: Lots of code generation pieces. This is only the
27423 beginning, will continue tomorrow with more touches of polish. We
27424 handle the fundamentals of if, while, do, for, return. Others are
27425 trickier and I need to start working on invocations soon.
27427 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27430 * codegen.cs (EmitContext): New struct, used during code
27431 emission to keep a context. Most of the code generation will be
27434 * cs-parser.jay: Add embedded blocks to the list of statements of
27435 this block. So code generation proceeds in a top down fashion.
27437 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27439 * statement.cs: Add support for multiple child blocks.
27441 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27443 * codegen.cs (EmitCode): New function, will emit the code for a
27444 Block of code given a TypeContainer and its ILGenerator.
27446 * statement.cs (Block): Standard public readonly optimization.
27447 (Block::Block constructors): Link children.
27448 (Block::Child): Child Linker.
27449 (Block::EmitVariables): Emits IL variable declarations.
27451 * class.cs: Drop support for MethodGroups here, delay until
27453 (Method::): Applied the same simplification that I did before, and
27454 move from Properties to public readonly fields.
27455 (Method::ParameterTypes): Returns the parameter types for the
27456 function, and implements a cache that will be useful later when I
27457 do error checking and the semantic analysis on the methods is
27459 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27460 and made a method, optional argument tells whether this is a class
27461 or a structure to apply the `has-this' bit.
27462 (Method::GetCallingConvention): Implement, returns the calling
27464 (Method::Define): Defines the type, a second pass is performed
27465 later to populate the methods.
27467 (Constructor::ParameterTypes): implement a cache similar to the
27468 one on Method::ParameterTypes, useful later when we do semantic
27471 (TypeContainer::EmitMethod): New method. Emits methods.
27473 * expression.cs: Removed MethodGroup class from here.
27475 * parameter.cs (Parameters::GetCallingConvention): new method.
27477 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27479 * class.cs (TypeContainer::Populate): Drop RootContext from the
27482 (Constructor::CallingConvention): Returns the calling convention.
27483 (Constructor::ParameterTypes): Returns the constructor parameter
27486 (TypeContainer::AddConstructor): Keep track of default constructor
27487 and the default static constructor.
27489 (Constructor::) Another class that starts using `public readonly'
27490 instead of properties.
27492 (Constructor::IsDefault): Whether this is a default constructor.
27494 (Field::) use readonly public fields instead of properties also.
27496 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27497 track of static constructors; If none is used, turn on
27498 BeforeFieldInit in the TypeAttributes.
27500 * cs-parser.jay (opt_argument_list): now the return can be null
27501 for the cases where there are no arguments.
27503 (constructor_declarator): If there is no implicit `base' or
27504 `this', then invoke the default parent constructor.
27506 * modifiers.cs (MethodAttr): New static function maps a set of
27507 modifiers flags into a MethodAttributes enum
27508 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27509 MethodAttr, TypeAttr to represent the various mappings where the
27510 modifiers are used.
27511 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27513 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27515 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27518 * interface.cs (PopulateIndexer): Implemented the code generator
27519 for interface indexers.
27521 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27523 * interface.cs (InterfaceMemberBase): Now we track the new status
27526 (PopulateProperty): Implement property population. Woohoo! Got
27527 Methods and Properties going today.
27529 Removed all the properties for interfaces, and replaced them with
27530 `public readonly' fields.
27532 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27534 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27535 initialize their hashtables/arraylists only when they are needed
27536 instead of doing this always.
27538 * parameter.cs: Handle refs and out parameters.
27540 * cs-parser.jay: Use an ArrayList to construct the arguments
27541 instead of the ParameterCollection, and then cast that to a
27544 * parameter.cs: Drop the use of ParameterCollection and use
27545 instead arrays of Parameters.
27547 (GetParameterInfo): Use the Type, not the Name when resolving
27550 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27552 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27553 and instead use public readonly fields.
27555 * class.cs: Put back walking code for type containers.
27557 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27559 * class.cs (MakeConstant): Code to define constants.
27561 * rootcontext.cs (LookupType): New function. Used to locate types
27564 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27566 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27567 this System.Reflection code is. Kudos to Microsoft
27569 * typemanager.cs: Implement a type cache and avoid loading all
27570 types at boot time. Wrap in LookupType the internals. This made
27571 the compiler so much faster. Wow. I rule!
27573 * driver.cs: Make sure we always load mscorlib first (for
27574 debugging purposes, nothing really important).
27576 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27577 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27579 * rootcontext.cs: Lookup types on their namespace; Lookup types
27580 on namespaces that have been imported using the `using' keyword.
27582 * class.cs (TypeContainer::TypeAttr): Virtualize.
27583 (Class::TypeAttr): Return attributes suitable for this bad boy.
27584 (Struct::TypeAttr): ditto.
27585 Handle nested classes.
27586 (TypeContainer::) Remove all the type visiting code, it is now
27587 replaced with the rootcontext.cs code
27589 * rootcontext.cs (GetClassBases): Added support for structs.
27591 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27593 * interface.cs, statement.cs, class.cs, parameter.cs,
27594 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27595 Drop use of TypeRefs, and use strings instead.
27597 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27601 * class.cs (Struct::Struct): set the SEALED flags after
27602 checking the modifiers.
27603 (TypeContainer::TypeAttr): new property, returns the
27604 TypeAttributes for a class.
27606 * cs-parser.jay (type_list): Oops, list production was creating a
27607 new list of base types.
27609 * rootcontext.cs (StdLib): New property.
27610 (GetInterfaceTypeByName): returns an interface by type name, and
27611 encapsulates error handling here.
27612 (GetInterfaces): simplified.
27613 (ResolveTree): Encapsulated all the tree resolution here.
27614 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27617 * driver.cs: Add support for --nostdlib, to avoid loading the
27618 default assemblies.
27619 (Main): Do not put tree resolution here.
27621 * rootcontext.cs: Beginning of the class resolution.
27623 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27625 * rootcontext.cs: Provide better error reporting.
27627 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27629 * rootcontext.cs (CreateInterface): Handle the case where there
27630 are no parent interfaces.
27632 (CloseTypes): Routine to flush types at the end.
27633 (CreateInterface): Track types.
27634 (GetInterfaces): Returns an array of Types from the list of
27635 defined interfaces.
27637 * typemanager.c (AddUserType): Mechanism to track user types (puts
27638 the type on the global type hash, and allows us to close it at the
27641 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27643 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27644 RecordInterface instead.
27646 * cs-parser.jay: Updated to reflect changes above.
27648 * decl.cs (Definition): Keep track of the TypeBuilder type that
27649 represents this type here. Not sure we will use it in the long
27650 run, but wont hurt for now.
27652 * driver.cs: Smaller changes to accomodate the new code.
27654 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27657 * rootcontext.cs (CreateInterface): New method, used to create
27658 the System.TypeBuilder type for interfaces.
27659 (ResolveInterfaces): new entry point to resolve the interface
27661 (CodeGen): Property, used to keep track of the code generator.
27663 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27665 * cs-parser.jay: Add a second production for delegate_declaration
27668 (enum_body): Put an opt_comma here instead of putting it on
27669 enum_body or enum_member_declarations so we can handle trailing
27670 commas on enumeration members. Gets rid of a shift/reduce.
27672 (type_list): Need a COMMA in the middle.
27674 (indexer_declaration): Tell tokenizer to recognize get/set
27676 * Remove old targets.
27678 * Re-add the parser target.
27680 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27682 * cs-parser.jay: Add precendence rules for a number of operators
27683 ot reduce the number of shift/reduce conflicts in the grammar.
27685 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27687 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27690 Get rid of old crufty code.
27692 * rootcontext.cs: Use this to keep track of the parsed
27693 representation and the defined types available to the program.
27695 * gen-treedump.cs: adjust for new convention.
27697 * type.cs: Split out the type manager, and the assembly builder
27700 * typemanager.cs: the type manager will live here now.
27702 * cil-codegen.cs: And the code generator here.
27704 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27706 * makefile: Fixed up for easy making.
27708 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27710 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27713 (unary_expression): Expand pre_increment_expression and
27714 post_decrement_expression to reduce a shift/reduce.
27716 2001-07-11 Simon Cozens
27718 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27720 Improve allow_keyword_as_indent name.
27722 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27724 * Adjustments for Beta2.
27726 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27728 * decl.cs: Added `Define' abstract method.
27729 (InTransit): new property, used to catch recursive definitions.
27731 * interface.cs: Implement `Define'.
27733 * modifiers.cs: Map Modifiers.constants to
27734 System.Reflection.TypeAttribute flags.
27736 * class.cs: Keep track of types and user-defined types.
27737 (BuilderInit): New method for creating an assembly
27738 (ResolveType): New function to launch the resolution process, only
27739 used by interfaces for now.
27741 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27742 that are inserted into the name space.
27744 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27746 * ARGH. I have screwed up my tree so many times due to the use of
27747 rsync rather than using CVS. Going to fix this at once.
27749 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27752 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27754 * Experiment successful: Use System.Type rather that our own
27757 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27759 * cs-parser.jay: Removed nsAliases from here.
27761 Use new namespaces, handle `using XXX;'
27763 * namespace.cs: Reimplemented namespace handling, use a recursive
27764 definition of the class. Now we can keep track of using clauses
27765 and catch invalid using clauses.
27767 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27769 * gen-treedump.cs: Adapted for all the renaming.
27771 * expression.cs (Expression): this class now has a Type property
27772 which returns an expression Type.
27774 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27775 `Type', as this has a different meaning now in the base
27777 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27779 * interface.cs, class.cs: Removed from all the sources the
27780 references to signature computation, as we can not do method
27781 signature computation during the parsing time, as we are not
27782 trying to solve at that point distinguishing:
27786 void a (NS.Blah x) {}
27789 Which depending on the context might be valid or not, as we do not
27790 know if Blah is the same thing as NS.Blah at that point.
27792 * Redid everything so the code uses TypeRefs now instead of
27793 Types. TypeRefs are just temporary type placeholders, that need
27794 to be resolved. They initially have a pointer to a string and the
27795 current scope in which they are used. This is used later by the
27796 compiler to resolve the reference to an actual Type.
27798 * DeclSpace is no longer a CIR.Type, and neither are
27799 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27800 are all DeclSpaces, but no Types.
27802 * type.cs (TypeRefManager): This implements the TypeRef manager,
27803 which keeps track of all the types that need to be resolved after
27804 the parsing has finished.
27806 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27808 * ARGH. We are going to have to store `foreach' as a class rather
27809 than resolving it, as we need to verify error 1579 after name
27810 resolution. *OR* we could keep a flag that says `This request to
27811 IEnumerator comes from a foreach statement' which we can then use
27812 to generate the error.
27814 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27816 * class.cs (TypeContainer.AddMethod): we now add methods to the
27817 MethodGroup instead of the method hashtable.
27819 * expression.cs: Add MethodGroup abstraction, which gets us one
27820 step closer to the specification in the way we handle method
27823 * cs-parser.jay (primary_expression): qualified_identifier now
27824 tried to match up an identifier to a local variable reference or
27825 to a parameter reference.
27827 current_local_parameters is now a parser global variable that
27828 points to the current parameters for the block, used during name
27831 (property_declaration): Now creates an implicit `value' argument to
27834 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27836 * parameter.cs: Do not use `param' arguments as part of the
27837 signature, per the spec.
27839 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27841 * decl.cs: Base class for classes, structs and interfaces. This
27842 is the "Declaration Space"
27844 * cs-parser.jay: Use CheckDef for checking declaration errors
27845 instead of having one on each function.
27847 * class.cs: Factor out some code for handling error handling in
27848 accordance to the "Declarations" section in the "Basic Concepts"
27849 chapter in the ECMA C# spec.
27851 * interface.cs: Make all interface member classes derive from
27852 InterfaceMemberBase.
27854 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27856 * Many things: all interfaces are parsed and generated in
27857 gen-treedump. Support for member variables, constructors,
27858 destructors, properties, constants is there.
27860 Beginning of the IL backend, but very little done, just there for
27863 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27865 * cs-parser.jay: Fix labeled statement.
27867 * cs-tokenizer.cs (escape): Escape " and ' always.
27868 ref_line, ref_name: keep track of the line/filename as instructed
27869 by #line by the compiler.
27872 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27874 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27875 to match the values in System.CodeDOM.
27877 Divid renamed to Divide.
27879 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27881 (Statements.set): remove.
27883 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27886 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27887 falseStatements always have valid values.
27889 * cs-parser.jay: Use System.CodeDOM now.