1 2008-02-05 Jb Evain <jbevain@novell.com>
3 * class.cs: use generic type comparison for parameters
6 2008-02-05 Marek Safar <marek.safar@gmail.com>
9 * class.cs: Use generic type comparison when testing method signatures.
11 2008-02-05 Marek Safar <marek.safar@gmail.com>
14 * ecore.cs: Applied C# 3.0 changes to better conversion.
16 2008-02-05 Marek Safar <marek.safar@gmail.com>
19 * cs-parser.jay: Correctly set modifiers for all constructor types.
21 2008-02-04 Marek Safar <marek.safar@gmail.com>
24 * generic.cs: Added base class constraint based type inference.
26 2008-02-01 Marek Safar <marek.safar@gmail.com>
29 * decl.cs: One more missing visibility check.
31 2008-02-01 Marek Safar <marek.safar@gmail.com>
33 * support.cs: Fixed broken return.
35 2008-01-25 Marek Safar <marek.safar@gmail.com>
37 * report.cs: Correctly reset warnings count after probing.
39 2008-01-25 Martin Baulig <martin@ximian.com>
42 (NamespaceEntry.SymbolFileID): Make this work again after
43 MemberName.ToString() is gone.
45 2008-01-25 Marek Safar <marek.safar@gmail.com>
47 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
50 2008-01-25 Marek Safar <marek.safar@gmail.com>
52 * generic.cs: Use full implicit conversion for type inference fixing.
54 2008-01-24 Marek Safar <marek.safar@gmail.com>
56 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
57 Fixed user operator conversions.
59 2008-01-24 Marek Safar <marek.safar@gmail.com>
61 * generic.cs: Do nullable type to null comparison optimization during
64 2008-01-24 Marek Safar <marek.safar@gmail.com>
67 * generic.cs: Enabled l-value resolve on nullable expressions.
69 2008-01-24 Marek Safar <marek.safar@gmail.com>
72 * class.cs: Ingore static ctors with parameters for any further checks.
74 2008-01-24 Marek Safar <marek.safar@gmail.com>
77 * namespace.cs: Removed redundant check.
79 2008-01-24 Marek Safar <marek.safar@gmail.com>
82 * expression.cs: ElementInitializers can be resolved only once.
84 2008-01-24 Marek Safar <marek.safar@gmail.com>
86 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
87 Condition expressions.
89 2008-01-23 Marek Safar <marek.safar@gmail.com>
91 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
93 2008-01-22 Marek Safar <marek.safar@gmail.com>
95 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
98 * generic.cs: Implemented coalesce expression.
100 2008-01-22 Marek Safar <marek.safar@gmail.com>
102 A fix for bug #355145
103 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
104 expression tree type inference.
106 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
109 * expression.cs (Binary.IsUnsignedType): Fix typo.
111 2008-01-22 Marek Safar <marek.safar@gmail.com>
113 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
115 2008-01-22 Marek Safar <marek.safar@gmail.com>
117 A fix for bug #355161
118 * ecore.cs, expression.cs: Wider range of extension method supported
121 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
123 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
124 AssemblyBuilder to operate in compiler context. Fixes mcs part of
127 2008-01-22 Marek Safar <marek.safar@gmail.com>
129 A fix for bug #355148
130 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
132 2008-01-22 Miguel de Icaza <miguel@novell.com>
134 * expression.cs (CreateExpressionTree): Add support for or and
135 logical or, and indent following the coding conventions.
137 * typemanager.cs (LinqExpression): renamed from
138 ExpressionTreeManager, for a shorter name.
140 Use TypeManager.CoreLookupType to lookup types from our core
141 assemblies and turn those into "Type" variables.
143 Consumers that previously used "Namespace" and "Type" from this
144 class should instead use the TypeExpression which is a type that
145 is fully resolved (without involving the regular C# resolution
148 This typically looks like this:
150 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
151 new MemberAccess (texpr, name, type_arguments, loc)
153 This avoids the problem in: #355178
155 2008-01-21 Marek Safar <marek.safar@gmail.com>
157 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
158 feature in parser only as we do in other cases.
160 2008-01-21 Marek Safar <marek.safar@gmail.com>
162 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
163 typemanager.cs: A refactoring of params arguments to reuse existing
164 expressions (params -> array initializer) to emit params argument instead
165 of specialized handling.
166 It was required by expression tree implementation and it has other benefits
167 as well, we now apply same optimization for params arguments as we do for
170 2008-01-18 Marek Safar <marek.safar@gmail.com>
172 A fix for bug #353526
173 * generic.cs: A type inference of params arguments may not required any
174 temporary array creation.
176 2008-01-18 Marek Safar <marek.safar@gmail.com>
178 A fix for bug #353534
179 * generic.cs, ecore.cs, expression.cs: A method group type inference is
180 supported for delegates only.
182 2008-01-18 Marek Safar <marek.safar@gmail.com>
184 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
185 type for more than 1 candidates.
187 2008-01-18 Marek Safar <marek.safar@gmail.com>
189 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
192 2008-01-16 Marek Safar <marek.safar@gmail.com>
194 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
195 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
196 operator) expressions.
198 2008-01-16 Zoltan Varga <vargaz@gmail.com>
200 * statement.cs: Avoid declaring an IL variable for this_variable since it is
201 not accessed from the generated IL.
203 2008-01-14 Marek Safar <marek.safar@gmail.com>
205 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
206 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
207 statement.cs: The first expression tree implementation drop, mostly
210 2008-01-14 Marek Safar <marek.safar@gmail.com>
212 * ecore.cs (IsNestedChild): Refactored.
214 2008-01-11 Marek Safar <marek.safar@gmail.com>
216 * lambda.cs: Don't use a cast on unknown expression statement.
218 2008-01-10 Geoff Norton <gnorton@novell.com>
220 * cs-tokenizer.cs: One more token to distinguish between method and lambda
223 2008-01-09 Marek Safar <marek.safar@gmail.com>
225 * doc.cs: Report better /doc crash details.
227 2008-01-09 Marek Safar <marek.safar@gmail.com>
229 A fix for bug #352536
230 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
232 2008-01-08 Marek Safar <marek.safar@gmail.com>
234 A fix for bug #352287
235 * ecore.cs, expression.cs: Do `this' access checking in all member access
238 2008-01-08 Marek Safar <marek.safar@gmail.com>
240 * rootcontext.cs, driver.cs: Switch to linq mode by default.
242 * report.cs: Reset message stacks.
244 2008-01-08 Marek Safar <marek.safar@gmail.com>
246 * generic.cs (InferInPhases): Correctly calculate params position.
248 2008-01-08 Marek Safar <marek.safar@gmail.com>
250 * cs-tokenizer.cs: No need to parse full string when parsing lambda
253 2008-01-07 Marek Safar <marek.safar@gmail.com>
255 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
257 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
259 * driver.cs: Updated --help option.
261 2008-01-07 Marek Safar <marek.safar@gmail.com>
263 * generic.cs (InferParamsTypeArguments): Removed.
264 (InferInPhases): Add params type inference.
265 (LowerBoundInference): Fixed scoring mechanism.
267 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
269 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
271 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
272 byte array for unsigned "baked" assemblies.
274 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
276 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
277 array for assemblies that are not strongnamed.
279 2008-01-04 Marek Safar <marek.safar@gmail.com>
281 A fix for bug #351481
282 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
283 declaring type for nested generic types.
285 2008-01-04 Marek Safar <marek.safar@gmail.com>
287 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
290 2008-01-03 Marek Safar <marek.safar@gmail.com>
292 A fix for bug #351047
293 * expression.cs (Binary.ResolveOperator): Allow equality operators between
294 null and structs only when equality and inequality operators are defined
295 either as an user-operators or predefined operators.
297 2008-01-03 Marek Safar <marek.safar@gmail.com>
299 A fix for bug #351047
300 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
302 2008-01-03 Marek Safar <marek.safar@gmail.com>
304 A fix for bug #351257
305 * cs-tokenizer.cs: Advance line number for '\r' correctly.
307 2008-01-03 Marek Safar <marek.safar@gmail.com>
309 A fix for bug #351157
310 * class.cs (Using): Fixed yet another broken cloning.
312 (Block): Put back more sensible default value for statements.
314 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
316 * codegen.cs: Allow AssemblyVersion with only major version component.
319 2007-12-29 Marek Safar <marek.safar@gmail.com>
321 A fix for bug #324654
322 * class.cs: Use FullName property as member name.
324 2007-12-28 Marek Safar <marek.safar@gmail.com>
326 A fix for bug #342117
327 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
328 constructor constraint.
330 2007-12-28 Marek Safar <marek.safar@gmail.com>
332 A fix for bug #338273
333 * class.cs (ProbertyBase): Access modifier checks are required for overrides
336 2007-12-28 Marek Safar <marek.safar@gmail.com>
338 A fix for bug #350839
339 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
341 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
343 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
346 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
348 * statement.cs: Changed some Hashtables to use HybridDictionaries
349 instead. It was observed that some HashTables only contained a few
350 items in the vast majority of cases. Since HybridDictionary is
351 more efficient on small sets (<10 elements), "known_variables"
352 from class ExplicitBlock as well as "labels" and "constants " from
353 class Block were changed to HybridDictionaries.
355 Atsai results: (56216kb->54987kb)
357 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
360 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
362 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
365 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
367 * expression.cs: foreach loop to for loop, saved on allocation of
368 enumerator (59333kb->59141kb)
370 * statement.cs. Changed foreach loops to for loops, saved on
371 allocation of enumerator (59141kb->59006kb)
373 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
374 when constructed with no specified capacity. This was causing a
375 few ArrayLists to allocate more memory than they would potentially
376 need in the Block class and MemberCache class. Setting the
377 ArrayLists to construct with a capacity of 1 saves some
378 memory. (56216kb->55585kb)
380 2007-12-27 Marek Safar <marek.safar@gmail.com>
382 A fix for bug #347189 (2nd issue)
383 * expression.cs (MemberAccess): Nested type can be found in base non-generic
386 2007-12-27 Miguel de Icaza <miguel@novell.com>
388 * report.cs: Do not use colors if stdout and stderr are not a
391 2007-12-27 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #346998
394 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
397 2007-12-27 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #343465
400 * class.cs: Explicit method name for nested types uses dots only.
402 2007-12-27 Marek Safar <marek.safar@gmail.com>
404 A fix for bug #343707
405 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
407 2007-12-27 Marek Safar <marek.safar@gmail.com>
409 * ecore.cs: Report type inference errors only when arguments count matches
412 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
414 * expression.cs, report.cs: New warning.
416 * typemanager.cs: Catch anonymous method type too.
418 2007-12-23 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #346379
421 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
423 2007-12-23 Marek Safar <marek.safar@gmail.com>
425 A fix for bug #347359
426 * expression.cs (Invocation): Don't resolve already resolved expression.
428 2007-12-23 Marek Safar <marek.safar@gmail.com>
430 A fix for bug #347189
431 * class.cs (FixedField): Use non-dependent code only in the define phase.
433 2007-12-23 Marek Safar <marek.safar@gmail.com>
435 A fix for bug #348076
436 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
438 2007-12-22 Marek Safar <marek.safar@gmail.com>
440 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
441 discovered extension methods.
443 2007-12-22 Marek Safar <marek.safar@gmail.com>
445 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
448 2007-12-21 Miguel de Icaza <miguel@novell.com>
450 * report.cs (ErrorMessage): Add support for using colors on
451 terminals that support it.
453 2007-12-21 Marek Safar <marek.safar@gmail.com>
455 * ecore.cs: Use information about expanded params for error reporting.
457 2007-12-21 Marek Safar <marek.safar@gmail.com>
459 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
460 and logic for params overloads.
462 2007-12-15 Miguel de Icaza <miguel@novell.com>
464 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
465 as this is also created from the parser. Fixes #349034
467 2007-12-12 Miguel de Icaza <miguel@novell.com>
469 * statement.cs (Throw.CloneTo): it is valid to have empty
470 expressions for throw.
472 2007-12-03 Marek Safar <marek.safar@gmail.com>
474 * cs-parser.jay: Set delegate constraint parsing region correctly.
476 2007-12-03 Marek Safar <marek.safar@gmail.com>
478 A fix for bug #345467
479 * typemanager.cs (IsEqual): Compare generic parameters position only.
481 2007-11-28 Marek Safar <marek.safar@gmail.com>
483 * expression.cs (BaseAccess): Type arguments can be null.
485 2007-11-27 Raja R Harinath <harinath@gmail.com>
487 * statement.cs (Block.Resolve): Ensure flow-branching tree is
488 consistent even when an error has occured.
489 (Switch.Resolve): Likewise.
491 2007-11-22 Marek Safar <marek.safar@gmail.com>
493 A fix for bug #334505
494 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
497 2007-11-22 Marek Safar <marek.safar@gmail.com>
499 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
500 refactorings required to resolve extension methods correctly when mixing
501 generics and non-generics members.
503 2007-11-20 Marek Safar <marek.safar@gmail.com>
505 A fix for bug #342584
506 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
509 2007-11-19 Marek Safar <marek.safar@gmail.com>
511 A fix for bug #342512
512 * delegate.cs: Use delegate argument expression when is available. Don't
513 emit virtual call when class is sealed.
515 2007-11-16 Marek Safar <marek.safar@gmail.com>
517 A fix for bug #325423
518 * assign.cs (FieldInitializer): Use resolved expression for emit.
520 * class.cs: Print less confusing error message.
522 2007-11-16 Marek Safar <marek.safar@gmail.com>
524 * cs-tokenizer.cs: Removed GMCS ifdefs.
526 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
529 * cs-parser.jay: Disabled nullable check.
531 * generic-mcs: Copied more generic stuff.
533 2007-11-16 Marek Safar <marek.safar@gmail.com>
535 * gcs-parser.jay: Merged to cs-parser.jay.
537 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
538 * *.csproj, *.sources: Updated to use only jay parser file.
540 2007-11-16 Marek Safar <marek.safar@gmail.com>
542 * gcs-parser.jay: Added nullable and default expression feature checks.
544 2007-11-16 Marek Safar <marek.safar@gmail.com>
546 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
547 it fixes many TODOs and hidden bugs.
549 * expression: Removed duplicate error check.
551 2007-11-15 Marek Safar <marek.safar@gmail.com>
553 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
554 implicitly type local variable only when it is used in a declaration.
556 2007-11-15 Marek Safar <marek.safar@gmail.com>
558 * attribute.cs: Use CS0612 for empty strings.
560 2007-11-14 Marek Safar <marek.safar@gmail.com>
562 * lambda.cs, statement.cs: Contextual return may act as a statement.
564 2007-11-14 Marek Safar <marek.safar@gmail.com>
566 A fix for a regression cause by #324222
567 * class.cs: Don't report unused even when it implements an interface.
569 2007-11-13 Marek Safar <marek.safar@gmail.com>
571 A fix for bug #341205
572 * ecore.cs, expression.cs: Method group expression cannot do static
573 method access with an instance reference check before overloading takes
576 2007-11-13 Marek Safar <marek.safar@gmail.com>
578 A fix for bug #325359
579 * class.cs: Use predictable name for automatically generated property.
581 2007-11-12 Marek Safar <marek.safar@gmail.com>
583 A fix for bug #324996
584 * expression.cs (Is): Handle case where D is nullable and T is not
587 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
589 2007-11-12 Marek Safar <marek.safar@gmail.com>
591 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
592 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
593 Flush small error reporting changes.
595 2007-11-09 Marek Safar <marek.safar@gmail.com>
597 A fix for bug #324996
598 * expression.cs: Rewrote Is expression implementation to work with
599 generics, nullable types, anonymous method. A const result expression
600 uses existing infrastructure instead of custom not fully-featured one.
602 2007-11-08 Marek Safar <marek.safar@gmail.com>
604 A fix for bug #340202
605 * class.cs: Consider generics for volatile field.
607 2007-11-08 Marek Safar <marek.safar@gmail.com>
609 A fix for bug #335594
610 * expression.cs: Use conversion rules when handling string addition.
612 2007-11-07 Marek Safar <marek.safar@gmail.com>
614 A fix for bug #336651
615 * expression.cs: Fixed a crash when probing is on.
617 2007-11-07 Marek Safar <marek.safar@gmail.com>
619 A fix for bug #324242
620 * covert.cs: Added a conversion from any nullable-type with an
621 underlying enum-type to the type System.Enum.
623 2007-11-07 Marek Safar <marek.safar@gmail.com>
625 A fix for bug #324222
626 * class.cs: Report all non-used event fields.
628 2007-11-07 Marek Safar <marek.safar@gmail.com>
630 A fix for bug #325161
631 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
632 qualifier for generic types.
634 2007-11-07 Marek Safar <marek.safar@gmail.com>
636 A fix for bug #322971
637 * expression.cs, ecore.cs: Added intermediate result value check for
640 2007-11-07 Marek Safar <marek.safar@gmail.com>
642 A fix for bug #324754
643 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
644 when it was requested.
646 2007-11-07 Marek Safar <marek.safar@gmail.com>
648 A fix for bug #325101
649 * expression.cs: Do type not value comparison for `is' expression.
651 2007-11-07 Marek Safar <marek.safar@gmail.com>
653 A fix for bug #320236
654 * convert.cs: Don't apply user conversion on underlying target type.
656 2007-11-06 Marek Safar <marek.safar@gmail.com>
658 * expression.cs: Don't use unresolved expression for error reporting.
660 2007-11-06 Marek Safar <marek.safar@gmail.com>
662 A fix for bugs #337712, #324490
663 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
664 overloading resolution too.
666 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
667 the process consistent and more robust.
669 * expression.cs, linq.cs, report.cs: Update.
671 2007-11-02 Marek Safar <marek.safar@gmail.com>
673 A fix for bug #332909
674 * attribute.cs: Resolve attributes in correct context using error
677 * rootcontext.cs: Define Obsolete attribute members as core members.
679 2007-11-02 Marek Safar <marek.safar@gmail.com>
681 * statement.cs: Removed unused methods.
683 2007-10-31 Wade Berrier <wberrier@novell.com>
685 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
686 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
689 2007-10-31 Marek Safar <marek.safar@gmail.com>
691 A fix for bug #338102
692 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
693 methods registered as non-generics.
695 2007-10-31 Marek Safar <marek.safar@gmail.com>
697 A fix for bugs #337712, #324490
698 * delegate.cs: Delegate covariance and contravariance is not allowed for
701 2007-10-31 Marek Safar <marek.safar@gmail.com>
703 A fix for bug #337719
704 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
707 2007-10-30 Marek Safar <marek.safar@gmail.com>
709 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
711 2007-10-29 Marek Safar <marek.safar@gmail.com>
713 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
716 2007-10-29 Raja R Harinath <rharinath@novell.com>
718 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
720 2007-10-29 Marek Safar <marek.safar@gmail.com>
722 A fix for bug #334652
723 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
724 extension methods when we have not found the best candidate in normal
727 2007-10-27 Marek Safar <marek.safar@gmail.com>
729 * AssemblyInfo.cs: Keep up-to-date.
731 2007-10-27 Marek Safar <marek.safar@gmail.com>
733 * Makefile: Fixed generics compiler name.
735 2007-10-27 Marek Safar <marek.safar@gmail.com>
737 * lambda.test: removed, lambda parsing is done differently.
739 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
741 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
743 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
745 2007-10-27 Marek Safar <marek.safar@gmail.com>
747 * Makefile, *.sources : All C# compilers are in mcs folder.
749 * *.cs: Use existing 2_1 define for smcs.
751 2007-10-26 Marek Safar <marek.safar@gmail.com>
753 A fix for bug #335847
754 * assign.cs, expression.cs: Couple of changes to avoid creating a
755 temporary variable for each object initializer assignment statement. It
756 simplifies struct initialization too, otherwise two temporary variables
758 Implemented optimization of redundant default element initializers.
760 2007-10-25 Marek Safar <marek.safar@gmail.com>
762 A fix for bug #336766
763 * expression.cs (Class.CheckBase): Use generic name when method is
766 2007-10-25 Marek Safar <marek.safar@gmail.com>
768 A fix for bug #334737
769 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
770 variable and not variable argument for prepared copies.
772 2007-10-24 Marek Safar <marek.safar@gmail.com>
774 A fix for bug #325110
775 * class.cs, expression.cs, attribute.cs: Use open generic method when
776 checking conditional attribute.
778 2007-10-24 Marek Safar <marek.safar@gmail.com>
780 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
781 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
782 FeatureIsNotAvailable.
784 2007-10-24 Marek Safar <marek.safar@gmail.com>
786 ** C# 3.0 Partial methods
788 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
789 methods support. Because of member cache issue with generics only
790 non-generics partial methods are fully supported.
792 2007-10-23 Marek Safar <marek.safar@gmail.com>
794 * class.cs, decl.cs: Rewrote member overloads check to cope with
795 generics and to use member cache for member checking. It also improves
796 performance and fixes remaining overloads issues.
798 2007-10-20 Marek Safar <marek.safar@gmail.com>
800 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
801 roottypes.cs, typemanager.cs:
803 A member cache creation logic changed to add members immediately and
804 not rely on fallback. The member cache is now only prefered way
805 how to access and find type declaration members. It saves 5 MB of memory
806 during MWF compilation and makes code ready for more optimizations and
807 clean-ups, it's also a pre-requirement for partial methods.
809 2007-10-18 Raja R Harinath <harinath@gmail.com>
811 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
812 handling for generic parameters.
814 2007-10-15 Marek Safar <marek.safar@gmail.com>
816 * class.cs (FixedField): Removed redundant volatile check.
818 2007-10-15 Marek Safar <marek.safar@gmail.com>
820 * class.cs, decl.cs: Fixed overload members verification to do only one
821 check per possible collision.
823 2007-10-13 Marek Safar <marek.safar@gmail.com>
825 A fix for bug #325478
826 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
827 and create only one disposable flags container.
829 2007-10-12 Marek Safar <marek.safar@gmail.com>
831 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
832 * statement.cs (Fixed): Fixed variables cloning.
834 2007-10-12 Marek Safar <marek.safar@gmail.com>
836 A fix for bug #333342
837 * class.cs (EventField): Don't mark value type event as synchronized.
839 2007-10-12 Marek Safar <marek.safar@gmail.com>
841 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
842 inference to identify best candidate method correctly.
843 (ProperyExpr): A range variable is read only and cannot be modified.
845 2007-10-11 Marek Safar <marek.safar@gmail.com>
847 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
848 logic to identify best candidate method correctly.
850 2007-10-11 Marek Safar <marek.safar@gmail.com>
852 * location.cs (Equals, GetHashCode): Removed.
854 2007-10-11 Marek Safar <marek.safar@gmail.com>
856 * report.cs: Implemented message recorder. It is used mainly for lambda
857 expressions to capture otherwise swallowed error messages.
859 * anonymous.cs, lambda.cs.cs: Do full parameters check.
861 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
863 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
865 * expression.cs (MemberAccess): Always report lookup failure.
867 * location.cs: Implemented Equals, GetHashCode.
869 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
871 2007-10-10 Jb Evain <jbevain@novell.com>
873 * codegen.cs: re-enable assembly version check.
875 2007-10-09 Marek Safar <marek.safar@gmail.com>
877 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
880 * namespace.cs (UsingAlias): Do correct version check.
882 2007-10-08 Marek Safar <marek.safar@gmail.com>
884 * expresison.cs, ecore.cs: Issue extension method error message when
887 * rootcontext.cs: Added ISO_2 compiler mode option.
889 2007-10-08 Marek Safar <marek.safar@gmail.com>
891 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
894 2007-10-08 Marek Safar <marek.safar@gmail.com>
896 * attribute.cs (GetString, GetBoolean): Work with both literal and
899 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
900 Moved method overload specific methods to MethodGroupExpr.
902 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
903 it should be less memory consuming.
905 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
907 * codegen.cs: remove the assembly version check until the buildbot is
910 2007-10-07 Jb Evain <jbevain@novell.com>
912 * attribute.cs (Attribute.GetString): if the value
913 expression is a StringConstant, return its string value.
915 2007-10-07 Jb Evain <jbevain@novell.com>
917 * typemanager.cs: add `assembly_version_attribute_type`.
918 * codegen.cs: on attribute emission, check that the
919 AssemblyVersionAttribute doesn't overflow.
921 2007-10-05 Marek Safar <marek.safar@gmail.com>
923 A fix for bug #324677
924 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
925 parent container of a scope container with currently resolved one.
927 2007-10-05 Marek Safar <marek.safar@gmail.com>
929 A fix for bug #325534
930 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
933 2007-10-05 Marek Safar <marek.safar@gmail.com>
935 A fix for bug #327504
936 * class.cs (Operator.Define): Refactored implicit and explicit user
937 operator conversion rules.
939 2007-10-05 Marek Safar <marek.safar@gmail.com>
941 A fix for bug #327520
942 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
944 2007-10-04 Marek Safar <marek.safar@gmail.com>
946 A fix for bug #328022
947 * class.cs (MethodData.Define): Use correct method to check whether
948 a method implementents an accessor.
950 2007-10-04 Marek Safar <marek.safar@gmail.com>
952 A fix for bug #330069
953 * statement.cs (Fixed.Resolve): Read the first array element only when
954 an array is instantiated.
956 2007-10-04 Marek Safar <marek.safar@gmail.com>
958 * expression.cs, assign.cs, generics.cs: Print correct operator when
959 compound assignment is used.
961 2007-10-04 Marek Safar <marek.safar@gmail.com>
963 A fix for bug #325841
964 * expression.cs (ArrayAccess): Use full argument cloning only for
965 string compound concatenation.
967 2007-10-03 Marek Safar <marek.safar@gmail.com>
969 A fix for bug #328774
970 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
972 (PropertyExpr.EmitAssign): Fixed string concatenation compound
975 2007-10-03 Raja R Harinath <rharinath@novell.com>
978 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
979 Event accessibility checks here. Remove some bogus code that
980 accidently made GenericMethods work.
981 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
983 2007-09-25 Marek Safar <marek.safar@gmail.com>
985 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
987 * statement.cs (Block): Refactored AddVariable to allow error handling
990 * generic.cs: New stub.
992 2007-09-23 Marek Safar <marek.safar@gmail.com>
994 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
997 2007-09-17 Marek Safar <marek.safar@gmail.com>
999 * class.cs: Use partial container to record whether any partial part
1000 contains static field initializer and therefore default contructor has
1003 2007-09-14 Marek Safar <marek.safar@gmail.com>
1005 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1006 mono-list when only one of two partial parts has defined accessibility
1009 2007-09-14 Marek Safar <marek.safar@gmail.com>
1011 A fix for bug #82845
1013 * class.cs (TypeContainer): Set correct resolve context for all field
1016 2007-09-13 Marek Safar <marek.safar@gmail.com>
1018 * assign.cs: Fixed a crash when field is resolved twice with an error.
1020 * codegen.cs: Changed InFieldInitializer to be flag.
1022 * anonymous.cs, ecore.cs, expression.cs: Update after
1023 IsInFieldInitializer rename.
1025 * const.cs: Removed unused parameter.
1027 * class.cs: Changed the way how we resolve and emit field initializers.
1028 The field initilizers have to have access to contructor block to emit
1029 compiler generated code.
1031 2007-09-13 Marek Safar <marek.safar@gmail.com>
1033 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1034 generics use TypeContainer instead.
1036 2007-09-12 Marek Safar <marek.safar@gmail.com>
1038 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1040 * lambda.cs (ResolveParameters): Use more powerful
1041 InflateGenericArgument.
1043 * parameters.cs: Better exception message.
1045 2007-09-10 Marek Safar <marek.safar@gmail.com>
1047 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1048 correct expression block type.
1050 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1052 * expression.cs (Invocation): Extracted method group resolve to
1055 2007-09-07 Marek Safar <marek.safar@gmail.com>
1057 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1058 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1060 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1061 generic extension methods.
1063 2007-09-06 Marek Safar <marek.safar@gmail.com>
1065 A fix for bug #82676 (Do I get it right now?)
1066 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1067 object before a standard conversion is applied.
1069 2007-09-06 Marek Safar <marek.safar@gmail.com>
1071 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1074 2007-09-05 Marek Safar <marek.safar@gmail.com>
1076 A fix for bug #82676
1077 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1078 non-generic interface types.
1080 2007-09-05 Marek Safar <marek.safar@gmail.com>
1082 A fix for bug #82690
1083 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1085 2007-09-05 Marek Safar <marek.safar@gmail.com>
1087 A fix for bug #82571
1088 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1089 modifier for container based methods.
1091 2007-09-05 Marek Safar <marek.safar@gmail.com>
1093 A fix for bug #82676
1094 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1095 any interface-type T means to any of interface type T.
1097 2007-09-04 Marek Safar <marek.safar@gmail.com>
1099 * namespace.cs: We have 2 versions of System.Core assembly.
1101 2007-09-04 Marek Safar <marek.safar@gmail.com>
1103 A fix for bug #82652
1104 * class.cs (Class.GetClassBases): Compare types and not expressions.
1106 2007-09-04 Marek Safar <marek.safar@gmail.com>
1108 A fix for bug #82620
1109 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1110 actually never worked before.
1111 (IndexerAccess): Emit prepared arguments before they are modified.
1113 2007-09-04 Marek Safar <marek.safar@gmail.com>
1115 A fix for bug #82563
1116 * assign.cs: Revert wrong fix.
1118 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1120 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1121 Instead of ldelema/stdind we have to use temporary variables to handle
1122 cases like String.Concat (params string[]).
1124 2007-08-31 Marek Safar <marek.safar@gmail.com>
1126 * class.cs: EmitAttributes to Emit rename.
1128 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1130 (MemberCore.HasClsCompliantAttribute): Don't depend on
1131 GetClsCompliantAttributeValue execution.
1133 2007-08-31 Marek Safar <marek.safar@gmail.com>
1135 * anonymous.cs: Use shorter type prefix.
1137 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1140 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1141 variables when probing is on.
1143 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1144 unresolved variables.
1145 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1146 handle transparent identifiers.
1148 2007-08-26 Marek Safar <marek.safar@gmail.com>
1150 * attribute.cs (IsClsCompliant): Add nullable types test.
1152 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1154 * doc.cs : catch other types of exception than XmlException to
1155 report CS1570. Fixed bug #82565.
1157 2007-08-23 Marek Safar <marek.safar@gmail.com>
1159 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1160 The number of delegate parameters has to match.
1161 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1164 2007-08-21 Marek Safar <marek.safar@gmail.com>
1166 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1167 to fix problem with private arguments.
1169 2007-08-20 Marek Safar <marek.safar@gmail.com>
1171 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1173 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1175 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1176 empty. Add cloning suport.
1178 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1180 2007-08-20 Marek Safar <marek.safar@gmail.com>
1182 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1183 to create EmptyCast. It handles EmptyConstantCast specialization for
1186 2007-08-18 Marek Safar <marek.safar@gmail.com>
1188 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1189 (EmitArrayArgument): One routine for array arguments.
1190 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1192 2007-08-17 Marek Safar <marek.safar@gmail.com>
1194 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1196 2007-08-17 Marek Safar <marek.safar@gmail.com>
1198 * anonymous.cs: MemberLookupFinal update.
1200 * class.cs (ConstructorInitializer): Is expression based.
1202 * delegate.cs: MethodGroupExpr update.
1204 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1206 (Error_MemberLookupFailed): Customizable error override.
1207 (MethodGroupExpr): Keep queried type for later usage.
1208 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1211 * expression.cs: Error_MemberLookupFailed refactoring.
1212 (New.DoResolve): Resolve as much as possible.
1213 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1214 customization for invalid member types.
1216 * statement.cs: MethodGroupExpr update.
1218 2007-08-16 Marek Safar <marek.safar@gmail.com>
1220 * modifier.cs (Check): Check all modifiers and not only accessibility
1223 2007-08-16 Marek Safar <marek.safar@gmail.com>
1225 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1226 type and not an expression.
1228 2007-08-16 Marek Safar <marek.safar@gmail.com>
1230 * statement.cs (Catch.Clone): Type and variable can be null.
1232 2007-08-16 Marek Safar <marek.safar@gmail.com>
1234 A fix for bug #81979
1235 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1236 I am really not sure whether this is the best fix.
1238 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1241 2007-08-14 Marek Safar <marek.safar@gmail.com>
1243 ** C# 3.0 Object and collection initializers (major re-write)
1245 * assign.cs (DoResolve): Initializers are not assign related.
1247 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1248 used during collection or object initialization.
1250 * expression.cs (Error_InvalidArguments): Add initializers specific
1251 messages. More will come later because it requires some general
1253 (New.DoResolve): Better error handling for unsafe types.
1254 (EmptyExpressionStatement): New class.
1255 (ElementInitializer): An object initializer expression.
1256 (CollectionElementInitializer): A collection initializer expression.
1257 (CollectionOrObjectInitializers): A block of object or collection
1259 (NewInitialize): New expression with element/object initializers.
1261 * statement.cs: Reverted object/collection initializer hacks.
1263 * typemanager.cs (CSharpName): Filter __arglist type.
1265 2007-08-09 Marek Safar <marek.safar@gmail.com>
1267 ** C# 3.0 Anonymous Types (update to the latest standard)
1269 * expression.cs (Binary.ResolveOperator): Threat all null based types
1271 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1272 (AnonymousTypeParameter): Updated.
1274 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1275 (AnonymousTypeClass): New anonymous type container.
1277 * class.cs (AddField): Return operation result.
1279 * generic.cs: Another empty TypeArguments overload.
1281 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1282 are stored at top of normal hierarchy.
1284 * typemanager.cs (CSharpName): Filter anonymous types.
1286 2007-08-09 Marek Safar <marek.safar@gmail.com>
1288 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1289 as single Concat call. How could we miss that :-(
1291 2007-08-08 Marek Safar <marek.safar@gmail.com>
1293 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1295 2007-08-07 Miguel de Icaza <miguel@novell.com>
1297 * expression.cs: Fix the previous commit, the creation of the
1298 arguments array list needs also to be conditional on the arguments
1301 * class.cs: Add a little bit of help to help narrow down problems.
1303 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1304 not try to copy in that case.
1306 * driver.cs: When building SMCS, include a new different set of
1307 default assemblies here. Do this here so we can control whether
1308 to include the default assemblies with /noconfig.
1310 2007-08-03 Marek Safar <marek.safar@gmail.com>
1312 A fix for bug #81979
1313 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1316 2007-08-03 Marek Safar <marek.safar@gmail.com>
1318 A fix for bug #82300
1320 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1321 we are in probing scope.
1323 2007-08-03 Marek Safar <marek.safar@gmail.com>
1325 A fix for bug #82301
1327 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1328 (Statement.CloneTo): Clone and not map children blocks.
1330 2007-08-03 Marek Safar <marek.safar@gmail.com>
1332 A fix for bug #82299
1334 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1337 * statement.cs (Statement.CloneTo): Clone variables before statements
1338 to allow remaping of local variables.
1340 2007-08-03 Marek Safar <marek.safar@gmail.com>
1342 A fix for bug #82296
1345 * report.cs: Log crash details for future clone problems.
1347 * statement.cs (Return.Clone): Don't clone non-existent expression.
1349 2007-08-03 Raja R Harinath <harinath@gmail.com>
1351 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1352 (Class.AddBasesForPart): Move CS0537 check here from ...
1353 * cs-parser.jay (class_declaration): ... here. Move calling of
1354 'AddBasesForPart' to ...
1355 (class_bases): ... here.
1356 (struct_declaration, interface_declaration): Update to changes.
1358 2007-08-02 Marek Safar <marek.safar@gmail.com>
1360 A fix for bug #81923
1362 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1363 conversion is allowed.
1365 2007-08-02 Marek Safar <marek.safar@gmail.com>
1367 A fix for bug #81564
1369 * ecore.cs (EventExpr): Add IsBase handling.
1371 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1374 2007-08-02 Raja R Harinath <harinath@gmail.com>
1376 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1377 * cs-parser.jay: Some whitespace cleanups.
1378 (current_delegate): New.
1380 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1381 a dummy code block, and use 'type_name' instead of 'member_name'.
1382 (interface_declaration, class_declaration): Likewise.
1383 (delegate_declaration): Likewise. Rearrange slightly and use
1385 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1386 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1388 2007-08-02 Marek Safar <marek.safar@gmail.com>
1390 A fix for bug #82039
1392 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1395 * typemanager.cs (CSharpName): Split to string overload.
1397 2007-08-02 Marek Safar <marek.safar@gmail.com>
1400 * report.cs: Updated warning CS0472.
1402 2007-08-01 Marek Safar <marek.safar@gmail.com>
1404 A fix for bug #82181
1406 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1408 2007-08-01 Marek Safar <marek.safar@gmail.com>
1410 A fix for bug #82277
1411 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1413 2007-08-01 Marek Safar <marek.safar@gmail.com>
1415 ** C# 3.0 Type Inference (major bits are working)
1417 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1418 (.ImplicitStandardConversionExists): Uses compatible.
1419 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1420 (.InferReturnType): New method.
1421 (.Compatible): Refactored.
1422 (.ResolveParameters): Uses factory to create resolved parameters.
1423 (.CompatibleMethod): Add probing mode support.
1424 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1425 clearly distinguish between 2 different operations.
1426 (LambdaMethod): Moved to lambda.cs.
1427 (AnonymousMethod): Removed unused fields and methods.
1428 (AnonymousDelegate): Simplified.
1430 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1432 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1434 * delegate.cs (Delegate): New mehods to reduce code duplication.
1435 (.GetConstructor): New method.
1436 (.GetInvokeMethod): New method.
1437 (DelegateCreation): Updated.
1439 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1441 (OverloadResolve): Made probing little bit faster.
1443 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1446 * generic.cs (TypeInferenceContext): Dummy implementation.
1448 * iterators.cs: Updated after Resolve/Define rename.
1450 * lambda.cs (LambdaExpression)
1451 (.ResolveParameters): Handles both type of arguments and type inference too.
1453 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1454 (InflateTypes): Updated.
1456 * support.cs (InflateTypes): Changed signature and updated.
1458 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1459 (MemberLookup_FindMembers): More MS tricks.
1460 (GetParameterData): Ditto.
1461 (GetDelegateParameters): Uses quick path for dynamic types.
1463 2007-08-01 Marek Safar <marek.safar@gmail.com>
1465 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1468 2007-07-31 Marek Safar <marek.safar@gmail.com>
1470 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1473 2007-07-26 Jb Evain <jbevain@novell.com>
1475 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1476 which takes a boolean 'report_errors', similar to the GetMethod.
1477 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1478 in .net 2.1, do not report errors here.
1480 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1481 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1482 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1485 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1486 of the type InternalsVisibleToAttribute before the first call
1487 to CoreLookupType which is allowed to fail (third boolean parameter
1488 to true). Because, during the resolution for a type that is not
1489 immediately found, we try to check if the type is not defined in
1490 a friend assembly, and to do so, we need the
1491 InternalVisibleToAttribute.
1493 2007-07-23 Miguel de Icaza <miguel@novell.com>
1495 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1496 feature that allows structs to be compared against null and inline
1497 the result as true or false.
1499 Notice that the same code is not permitted inside a generic block
1500 of code that would do:
1502 class Foo<T> where T : struct {
1509 It is only allowed if the type of T is not bound (no where
1510 clause). In my opinion, this CSC 2 behavior is broken but people
1511 seem to be using it (IronRuby does, a few bug reports on bugzilla
1512 have it and some people have complained about it).
1514 All of the users that depend on this behavior have code that is
1517 * report.cs (Warning, Error): make these take object arguments,
1518 not strings, as that allows us to take advantage of Format.
1520 2007-07-20 William Holmes <billholmes54@gmail.com>
1522 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1523 Left member variable for the Count.
1524 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1525 MemberName.CountTypeArguments to avoid a NRE.
1527 This code is contributed under the MIT X11 license
1529 2007-07-18 Marek Safar <marek.safar@gmail.com>
1531 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1533 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1535 * doc.cs : generic method arguments are written as ``x while generic
1536 type arguments are `x. Combined with the previous change, fixed bug
1539 2007-07-18 Raja R Harinath <rharinath@novell.com>
1542 * expression.cs (Binary.ResolveOperator): When converting
1543 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1545 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1547 * doc.cs : when T: or whatever x: is specified, it does not really
1548 check the doc comment's syntax correctness. Fixed bug #82006.
1550 2007-07-18 Marek Safar <marek.safar@gmail.com>
1552 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1553 LambdaExpression better.
1555 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1557 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1559 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1560 as it can be generated.
1562 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1565 * lambda.cs (LambdaExpression): Refactored to share same code with
1566 AnonymousMethodExpression.
1568 2007-07-17 Marek Safar <marek.safar@gmail.com>
1570 * anonymous.cs (MakeName): Include host name for easier debugging.
1571 (LambdaMethod): New class for lambda spcecific stuff.
1573 * attribute.cs: Set EmitContext return type.
1575 * class.cs: Set EmitContext return type.
1577 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1578 with null/void meaning.
1580 * iterators.cs (ContainerType): Implemented.
1582 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1584 * statement.cs (Return): Updated to lambda expressions.
1585 (Block.CloneTo): Parent can be null.
1587 2007-07-13 Marek Safar <marek.safar@gmail.com>
1589 A fix for bug #81917
1590 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1592 * class.cs (FixedField): Check whether field is in unsafe scope.
1594 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1595 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1597 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1600 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1602 2007-07-13 Marek Safar <marek.safar@gmail.com>
1604 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1605 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1608 2007-07-13 Marek Safar <marek.safar@gmail.com>
1610 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1612 2007-07-13 Marek Safar <marek.safar@gmail.com>
1614 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1615 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1617 * codegen.cs(EmitContext): Add ProbingMode flag.
1619 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1621 * driver.cs: For now set both warning values.
1623 * ecore.cs (SimpleName): Name is readonly.
1624 (MethodGroup.OverloadResolve): One quick path for probing.
1626 * expression.cs (Unary): Set Oper r/o.
1627 (Binary): Set Oper r/o.
1628 (ParameterReference): Set few instance variables as r/o.
1629 (ParameterReference.DoResolveBase): Don't capture aruments when
1631 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1632 (Arglist): arguments are private.
1633 (SizeOf): type is private and r/o.
1634 (MemberAccess): arguments are private.
1636 * report.cs: Enhanced reporting on/off capabilities.
1638 * lambda.cs: Uses ec.IsInProbingMode.
1639 (ContextualReturn): Derives from return.
1641 * rootcontext.cs: For now set both warning values.
1643 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1645 (Return.Resolve): Don't die immediately.
1646 (Block.Resolve): Speed-up probing.
1647 (Block.CloneTo): Clone only child blocks.
1649 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1651 * iterators.cs: reverted Miguel's latest change (r81925) as it
1652 breaks the build in System.
1654 2007-07-13 Miguel de Icaza <miguel@novell.com>
1656 * iterators.cs (Yield.CheckContext): Check for the iterator type
1657 also here as we can call into Yield even in codepaths that are not
1659 (MethodOrOperator is the only path that was checked).
1661 In addition to the standard check, use a more specific check for
1662 constructors to report a more verbose error.
1664 2007-07-12 Miguel de Icaza <miguel@novell.com>
1666 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1667 report the warning and continue
1669 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1670 values on the stack on the call to Emit. Use EmitStatement if
1671 possible, or using Emit + Pop if not possible. Fixes #82064
1673 2007-07-12 Raja R Harinath <rharinath@novell.com>
1675 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1676 avoid try...finally in some cases.
1678 2007-07-10 Marek Safar <marek.safar@gmail.com>
1680 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1682 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1683 instead of method. Re-use standard error handling.
1684 (ConstructorInitializer.Emit): Simplified.
1686 * delegate.cs: Updated after Invocation.EmitCall change.
1688 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1689 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1690 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1691 method and don't permanently changing input arguments.
1692 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1693 is resolved it has one of the candidates is the best one which is later
1694 used to emit. Removed a few unused method.
1695 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1697 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1698 (Binary.ResolveOperator): Ditto.
1699 (ConditionalLogicalOperator.DoResolve): Ditto.
1700 (Invocation): Uses method group.
1701 (Invocation.DoResolve): Simplified.
1702 (Invocation.EmitCall): Removed useless is_static.
1703 (Invocation.Emit): Delegate to method group.
1704 (Invocation.EmitStatement): Simplified.
1705 (New): Uses method group.
1706 (MemberAccess.DoResolve): Don't destroy original expression.
1708 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1710 2007-07-04 Marek Safar <marek.safar@gmail.com>
1712 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1715 * lambda.cs: Add custom error message type.
1717 2007-07-03 Marek Safar <marek.safar@gmail.com>
1719 * lambda.cs: Simplified little bit.
1721 * parameter.cs: Introduced ImplicitLambdaParameter.
1722 (Parameters.CreateFullyResolved): New factory instead of ctor.
1726 * delegate.cs: Updated parameter creation.
1728 2007-07-03 Marek Safar <marek.safar@gmail.com>
1730 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1733 * generic.cs: Synchronized with gmcs.
1735 2007-07-03 Marek Safar <marek.safar@gmail.com>
1737 * class.cs (Indexer): Check return type as soon as possible.
1739 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1742 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1744 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1746 * parameter.cs (Parameter): Use expression type when it is available.
1748 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1749 method modifier for the first parameter only.
1751 2007-06-24 Marek Safar <marek.safar@gmail.com>
1753 A fix for bug #81938
1754 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1756 * constant.cs: Tide up an exception message.
1758 2007-06-22 Marek Safar <marek.safar@gmail.com>
1760 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1761 an uninitialized variable is used.
1763 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1765 2007-06-22 Marek Safar <marek.safar@gmail.com>
1767 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1768 not found error handling.
1770 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1772 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1773 (ArrayCreation.DoResolve): Simplified.
1774 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1775 its own resolve process.
1776 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1778 2007-06-20 Marek Safar <marek.safar@gmail.com>
1780 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1783 2007-06-20 Marek Safar <marek.safar@gmail.com>
1785 * cs-tokenizer.cs: Removed var related stuff.
1787 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1788 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1789 a type and a keyword at same time.
1791 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1794 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1795 implicitly typed arrays, more changes will follow.
1797 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1799 2007-06-19 Marek Safar <marek.safar@gmail.com>
1801 * ecore.cs (VarExpr): Removed Handled field.
1803 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1804 build-in assign functionality.
1805 (ForEach.Resolve): Removed all implicitly typed local variable code and
1807 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1808 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1810 2007-06-18 Marek Safar <marek.safar@gmail.com>
1812 * assign.cs: Removed implicitly typed local variable check.
1814 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1815 referencing implicitly typed local variable.
1816 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1819 * statement.cs (Fixed): Removed unsupported implicitly typed local
1822 2007-06-15 Marek Safar <marek.safar@gmail.com>
1824 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1826 2007-06-14 Marek Safar <marek.safar@gmail.com>
1828 A fix for bugs #81855 and #76274
1829 * attribute.cs (AttachTo): Always set owner for global attributes to
1832 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1835 * cs-parser.jay: Assembly and module attributes must precede all other
1836 elements except using clauses and extern alias declarations.
1838 2007-06-13 Marek Safar <marek.safar@gmail.com>
1840 A fix for bug #81748
1842 * expression.cs: More checks for non ISO-1 features.
1844 2007-06-12 Marek Safar <marek.safar@gmail.com>
1846 A fix for bug #81807
1847 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1848 present inside switch statement and it is required by nullable check.
1850 2007-06-12 Marek Safar <marek.safar@gmail.com>
1852 A fix for bug #81840
1853 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1854 when type matching fails.
1856 * namespace.cs: Tiny error message change.
1858 2007-06-12 Marek Safar <marek.safar@gmail.com>
1860 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1861 reporting. Added automatic property check.
1863 * class.cs: Updated after CheckAbstractAndExtern relocation.
1864 (AEventPropertyAccessor.GetSignatureForError): Customized.
1866 2007-06-11 Marek Safar <marek.safar@gmail.com>
1868 * class.cs (DefineBaseTypes): Base type can be undefined.
1870 * ecore.cs (TypeLookup): Minor refactoring.
1871 (DoResolveAsTypeStep): Removed redundant check.
1873 * namespace.cs (Lookup): Removed redundant check.
1875 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1876 ResolveAsTypeTerminal step.
1877 (BootstrapCorlib_*): Simplified.
1878 (PopulateCoreType): Core types can be now external.
1880 2007-06-07 Marek Safar <marek.safar@gmail.com>
1882 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1884 (InferTypeArguments): Infers anonymous expression type arguments.
1885 (Compatible): Split to Compatible and InferTypeArguments.
1887 * lambda.cs: Updated.
1889 2007-06-08 Marek Safar <marek.safar@gmail.com>
1891 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1893 2007-06-07 Raja R Harinath <harinath@gmail.com>
1895 Fix #80477, cs0135-2.cs, cs0135-3.cs
1896 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1897 names to the "known" variables list.
1898 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1899 parameter names are also "known".
1900 (Block.CheckError136): Remove.
1901 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1904 2007-06-07 Marek Safar <marek.safar@gmail.com>
1906 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1908 2007-06-06 Marek Safar <marek.safar@gmail.com>
1910 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1911 internal error not an user error.
1913 * expression.cs (IsApplicable): Refactored to make debugging easier.
1915 * support.cs: More tricks for non-mono runtimes.
1917 * typemanager.cs (CoreLookupType): Made public.
1918 (InitSystemCore): All linq specific stuff moved to linq.cs
1920 2007-06-05 Marek Safar <marek.safar@gmail.com>
1922 * typemanager.cs (CSharpSignature): One more missing build-in types
1924 More tricks for non-mono runtime.
1926 2007-06-05 Raja R Harinath <harinath@gmail.com>
1928 * statement.cs (Block.CheckError136_InParents): Remove.
1929 (Block.AddVariable): Use GetParameterInfo instead.
1930 (ToplevelBlock.ProcessArguments): Likewise.
1932 2007-06-04 Raja R Harinath <rharinath@novell.com>
1934 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1936 (ToplevelBlock.GetParameterInfo): Split out of ...
1937 (ToplevelBlock.GetParameterRefernce): ... this.
1938 (ToplevelBlock.ParameterMap): Remove.
1939 * expression.cs (ParameterReference): Update to use
1940 ToplevelParameterInfo.
1942 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
1945 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
1946 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
1948 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
1949 (ToplevelBlock.ProcessParameters) ... here.
1950 (ToplevelBlock..ctor): Invoke it.
1952 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
1955 * statement.cs (IKnownVariable): New interface.
1956 (LocalInfo): Implement it.
1957 (ToplevelParameterInfo): New class.
1958 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
1959 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
1960 GetKnownVariableInfo.
1962 2007-06-03 Raja R Harinath <harinath@gmail.com>
1964 Partly speed up CS0136 error checks.
1965 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
1966 'recurse' parameter.
1967 (Block.DoCheckError136): Only check errors in parameters. Move
1968 local variable checks ...
1969 (Block.AddVariable): ... here, and ...
1970 (ToplevelBlock.ResolveMeta): ... here.
1972 2007-06-02 Raja R Harinath <harinath@gmail.com>
1974 * statement.cs (Block.IsChildOf): Remove.
1976 * statement.cs (Statement.Clone): Move special case code ...
1977 (Block.CloneTo): ... here.
1979 2007-05-29 Raja R Harinath <rharinath@novell.com>
1981 * statement.cs (ToplevelBlock.container): Remove field. It's
1982 redundant with 'Parent'.
1983 (ToplevelBlock.ContainerBlock): Remove accessor.
1984 (ToplevelBlock..ctor): Update to changes. Register anonymous
1985 child with parent here, ...
1986 * cs-parser.jay (end_anonymous): ... not here. Don't modify
1988 (start_anonymous): Don't save current_block.
1989 (top_current_block): Remove.
1991 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
1992 (Block.Resolve): Update to changes.
1993 (Block..ctor): Move setting of "correct" 'Toplevel'
1994 and 'Explicit' fields to ...
1995 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
1997 2007-05-27 Raja R Harinath <harinath@gmail.com>
2000 * statement.cs (Block.Implicit): Remove.
2001 (Block): Update to changes.
2002 * flowanalysis.cs: Likewise.
2004 Mildly speed up CheckInvariantMeaningInBlock
2005 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2006 Recursively call AddKnownVariable to all enclosing blocks.
2007 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2008 Remove recursive calls.
2009 (Block): Update to changes.
2011 New ExplicitBlock invariants
2012 * statement.cs (Block.Explicit): New field. It points to the
2013 immediately enclosing non-implicit block.
2014 (Block..ctor): Maintain the invariant.
2015 * cs-parser.jay: Take advantage of invariant.
2017 Introduce ExplicitBlock
2018 * statement.cs (ExplicitBlock): New.
2019 (ToplevelBlock): Derive from it.
2020 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2022 (Block.Implicit): Update to changes.
2023 * cs-parser.jay: Update to changes.
2026 * codegen.cs (EmitContext.IsLastStatement): Remove.
2027 * statement.cs (Block.DoEmit): Update to changes.
2029 2007-05-25 Raja R Harinath <rharinath@novell.com>
2031 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2032 modifying current_block directly.
2034 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2036 * class.cs: Implemented automatic properties (C# 3.0)
2037 Thanks to Marek for the help.
2039 2007-05-23 Raja R Harinath <rharinath@novell.com>
2041 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2042 variable as assigned, note also that all its components are
2044 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2046 2007-05-19 Marek Safar <marek.safar@gmail.com>
2048 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2049 member is marked as compiler generated.
2051 * decl.cs (MemberCore): Refactored ModFlags into property.
2053 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2054 (Check): Check only accessibility modifiers.
2056 2007-05-18 Raja R Harinath <rharinath@novell.com>
2058 Track all assignable slots in one bit array
2059 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2060 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2061 logic from VariableMap constructor here. Use the same 'offset'
2062 variable that's later used for computing offsets of local
2064 * flowanalysis.cs (UsageVector.parameters): Remove.
2065 (UsageVector): Update to changes.
2066 (VariableMap): Remove.
2068 Avoid creating ParameterMap in every block
2069 * statement.cs (Block.ParameterMap): Move ...
2070 (ToplevelBlock.ParameterMap): ... here.
2071 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2073 * flowanalysis.cs (FlowBranching.param_map): Remove.
2074 (FlowBranching.UsageVector): Update to changes.
2075 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2077 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2079 * expression.cs (ParameterReference): Distinguish between block
2080 where parameter was referenced and declared.
2082 2007-05-18 Marek Safar <marek.safar@gmail.com>
2084 * flowanalysis.cs, statement.cs: Put back improved error handling.
2086 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2090 Imporved object and collection initialization (C# 3.0).
2092 2007-05-15 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #81380
2095 * expression.cs (Is.DoResolve): Only value types have constant `is'
2098 2007-05-15 Raja R Harinath <rharinath@novell.com>
2100 * statement.cs (ToplevelBlock.child): Remove.
2102 2007-05-15 Raja R Harinath <harinath@gmail.com>
2104 Rationalize ResolveMeta: refactoring
2105 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2106 out constant handling code into ...
2107 (Block.DoResolveConstants): ... this.
2109 Rationalize ResolveMeta: kill local_map
2110 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2111 (Block.AssignableSlots): New.
2112 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2113 for locals -- move code from VariableMap here. Avoid unnecessary
2115 * flowanalysis.cs (FlowBranching.local_map): Remove.
2116 (FlowBranching..ctor): Use Block.AssignableSlots.
2117 (VariableMap): Remove unused constructors.
2119 2007-05-11 Raja R Harinath <rharinath@novell.com>
2121 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2123 2007-05-11 Marek Safar <marek.safar@gmail.com>
2125 * typemanager.cs (IsFriendAssembly): Should not be called for building
2128 2007-05-09 Marek Safar <marek.safar@gmail.com>
2130 * literal.cs (NullConstant): Print null in all cases.
2132 * expression.cs (Binary.ResolveOperator): Implemented delegate
2133 comparison based on C# 2.0 changes.
2135 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2137 This code is contributed under the MIT X11 license
2139 The following enables support for several C# 3.0 language features:
2141 * cs-tokenizer.cs: Added support for the "var" keyword.
2143 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2144 Added VarExpr class to facilitate type inferencing.
2146 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2147 to support anonymous types.
2149 * assign.cs: Added support for type inferencing and initialization.
2151 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2153 * expression.cs: Added implicit array support to ArrayCreation.
2154 Added 5 types and 1 interface:
2156 IInitializable Implementing classes can inject initializing
2157 statements after object instantiation.
2159 Initializer Stores data for object initialization.
2161 AnonymousType An expression for anonymous types.
2163 AnonymousTypeParameter Stores data about an anonymous type's field.
2165 NewInitialize An expression for object initialization.
2167 CollectionInitialize An expression for collection initialization.
2169 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2172 2007-05-06 Marek Safar <marek.safar@gmail.com>
2174 A fix for bug #81500
2175 * cs-tokenizer.cs: Add special handling for coalescing operator.
2177 2007-05-06 Marek Safar <marek.safar@gmail.com>
2179 A fix for bug #81529
2180 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2181 its value from base class until it is redefined.
2183 2007-05-02 Raja R Harinath <rharinath@novell.com>
2185 Fix regression in cs0631-3.cs
2186 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2187 fallback. Make error fallback catch more cases.
2189 2007-05-01 Miguel de Icaza <miguel@novell.com>
2191 * cs-parser.jay: Allow parameters in operator declarations to have
2194 2007-04-27 Miguel de Icaza <miguel@novell.com>
2196 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2199 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2200 inside the ContextualReturn, it does not have to be an
2201 ExpressionStatement.
2203 2007-04-24 Miguel de Icaza <miguel@novell.com>
2205 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2208 2007-04-23 Miguel de Icaza <miguel@novell.com>
2210 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2211 method in two methods: ResolveNoDefine and Resolve.
2213 ResolveNoDefine will stop just after ResolveTopBlock has been
2216 Resolve will then continue by creating a method and issuing the
2217 call to method.Define ().
2219 (AnonymousMethod): Split and implement the new Resolve and
2220 ResolveNoDefine as well.
2222 * lambda.cs (LambdaExpression): Split the anonymous method
2223 resolution code into a separate routine (CoreCompatibilityTest)
2224 from DoCompatibleTest.
2226 (LambdaExpression.TryBuild): New method, this method tries to
2227 build the LambdaExpression with the given set of types to be used
2228 as the types for the various parameters of the lambda expression.
2230 If the compilation succeed with the given types, the infered type
2231 of the Anonymous method is returned, otherwise null is returned.
2233 2007-04-23 Marek Safar <marek.safar@gmail.com>
2235 A fix for bug #81414
2236 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2238 2007-04-22 Miguel de Icaza <miguel@novell.com>
2240 * cs-tokenizer.cs: Change various identifiers here from the
2241 camelCasing to the recommended Linux-like style for instance
2242 variables from the Coding Guidelines.
2244 2007-04-19 Martin Baulig <martin@ximian.com>
2247 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2248 System.Enum to System.ValueType.
2250 2007-04-13 Martin Baulig <martin@ximian.com>
2252 Rewrote implicit reference conversions. We need to distinguish
2253 between implicit reference conversions (13.1.4) and implicit
2254 boxing conversions (13.1.5).
2256 According to the spec, there's an an implicit conversion
2257 "From a one-dimensional array-type S[] to IList<T> and base
2258 interfaces of this interface, provided there is an implicit
2259 reference conversion from S to T." Note that this does not
2260 include boxing conversions.
2263 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2264 (Convert.ImplicitReferenceConversion): Split into
2265 ImplicitReferenceConversionCore() and
2266 ImplicitBoxingConversionExist().
2267 (Convert.ImplicitReferenceConversionExists): Use the new
2268 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2270 2007-04-12 Martin Baulig <martin@ximian.com>
2272 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2273 `TypeManager.null_type' checks up to the top of the method.
2275 2007-04-11 Marek Safar <marek.safar@gmail.com>
2277 A fix for bug #81350
2278 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2281 2007-04-11 Martin Baulig <martin@ximian.com>
2283 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2284 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2285 to make this work for generic classes; fixes #79561.
2287 2007-04-11 Martin Baulig <martin@ximian.com>
2289 * expression.cs (As): Add support for nullable types; fixes #79371.
2291 2007-04-11 Martin Baulig <martin@ximian.com>
2293 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2294 `type.FullName' is null; fixes #80243.
2296 2007-04-11 Martin Baulig <martin@ximian.com>
2298 * expression.cs (Invocation.IsApplicable): Don't modify the method
2299 if type inference succeeded, but the method was not applicable.
2302 2007-04-10 Marek Safar <marek.safar@gmail.com>
2304 A fix for bug #81324
2305 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2306 internal and external namespaces containers.
2308 2007-04-10 Martin Baulig <martin@ximian.com>
2310 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2311 TypeManager.DropGenericMethodArguments() so we also call
2312 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2314 2007-04-10 Martin Baulig <martin@ximian.com>
2316 * iterators.cs (Iterator.CreateIterator): Don't crash if
2317 `method.ReturnType' is null. This happens if something went wrong
2318 while resolving that typ (we already reported an error in this case).
2320 2007-04-10 Martin Baulig <martin@ximian.com>
2322 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2323 generic interfaces; report the CS0144 directly.
2325 2007-04-10 Martin Baulig <martin@ximian.com>
2327 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2328 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2330 2007-04-10 Martin Baulig <martin@ximian.com>
2332 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2334 2007-04-09 Raja R Harinath <rharinath@novell.com>
2337 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2338 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2341 * statement.cs (For.Resolve): If resolution fails, use
2344 2007-04-08 Marek Safar <marek.safar@gmail.com>
2346 * anonymous.cs (MakeName): Make faster and zero-based.
2347 (VerifyExplicitParameterCompatibility): Back to mode where generic
2348 parameter is ignored.
2349 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2351 * class.cs (EmitType): Method can emit another new method.
2353 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2355 * driver.cs: Updated.
2357 * lambda.cs: Reuse predefined empty parameters.
2359 * parameter.cs: Updated
2361 * support.cs: Implemented InflateTypes.
2363 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2364 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2366 2007-04-03 Martin Baulig <martin@ximian.com>
2370 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2371 version of TypeManager.IsOverride() which also works with generic
2374 2007-04-03 Martin Baulig <martin@ximian.com>
2379 (Convert.ExplicitReferenceConversion): We need to cast when
2380 converting from IList<T> to S[].
2382 2007-04-01 Marek Safar <marek.safar@gmail.com>
2384 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2387 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2389 2007-03-31 Marek Safar <marek.safar@gmail.com>
2391 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2392 argument and return type inferring.
2394 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2395 (ReturnType): Turned to property.
2397 * statement.cs (Return): Implemented return type inferring.
2399 * support.cs (ReflectionParameters): Use local types if possible.
2401 2007-03-30 Raja R Harinath <rharinath@novell.com>
2403 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2404 (FlowBranching.UsageVector): Update to changes.
2406 Prepare to kill 'Reachability'
2407 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2408 argument of constructor.
2410 2007-03-29 Raja R Harinath <rharinath@novell.com>
2412 Prepare to kill 'Reachability'
2413 * flowanalysis.cs (UsageVector.is_unreachable): New.
2414 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2415 'reachability', and verify they're consistent.
2418 * expression.cs (New.EmitStatement): Handle type parameters here too.
2420 2007-03-29 Martin Baulig <martin@ximian.com>
2425 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2426 CompilerGeneratedClass.
2427 (ScopeInfo.EmitScopeInstance): Make this protected.
2428 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2429 `ec.CurrentAnonymousMethod.Scope == Scope'.
2431 * statement.cs (Block.ScopeInfo): Make this a property.
2433 2007-03-27 Raja R Harinath <harinath@gmail.com>
2435 Prepare to kill 'Reachability'
2436 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2437 (FlowBranching.UsageVector.Reachability): Remove property.
2438 (FlowBranching.UsageVector.IsUnreachable): New property.
2439 (FlowBranching.UsageVector.ResetBarrier): New.
2440 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2441 * codegen.cs, statement.cs: Update to changes.
2443 2007-03-27 Martin Baulig <martin@ximian.com>
2448 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2451 2007-03-26 Raja R Harinath <rharinath@novell.com>
2453 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2454 instead of TriState. Remove all mention of TriState.
2456 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2457 replaced by a boolean. Add boolean 'is_unreachable' field, check
2458 and maintain invariants.
2460 2007-03-25 Marek Safar <marek.safar@gmail.com>
2462 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2464 2007-03-25 Marek Safar <marek.safar@gmail.com>
2466 * expression.cs: Stop using obsolete 2.0 opcodes.
2468 2007-03-25 Marek Safar <marek.safar@gmail.com>
2470 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2471 one of the latests Martin's fixes.
2473 2007-03-23 Miguel de Icaza <miguel@novell.com>
2475 * expression.cs: On BigEndian systems, swap the bytes, temporary
2476 solution until we get a new bitconverter class.
2478 2007-03-23 Martin Baulig <martin@ximian.com>
2482 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2483 "Method" and "Method`1". Normally, a cache lookup is done on the
2484 "Method" form (ie. without the generic arity), but this one makes
2485 lookups on the full form work as well.
2487 2007-03-22 Raja R Harinath <rharinath@novell.com>
2489 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2492 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2494 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2495 ordered_member_list, to TypeBuilder to store members to be defined
2496 in the order they were parsed in.
2497 - ordered_explicit_member_list contains all properties indexers
2498 and methods that are defined as explicit implementation of an
2499 interface or base class.
2500 - ordered_member_list contains all properties indexers and methods
2501 that are not defined as explicit implementation of an interface
2504 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2505 functionality in these removed classes has been replaced with
2506 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2507 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2509 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2510 to CheckForDuplications inside GetMethod and SetMethod Define Method
2511 to handle method property and indexer name conflicts.
2515 All code is contributed under the MIT/X11 license.
2517 2007-03-20 Martin Baulig <martin@ximian.com>
2519 * class.cs (TypeContainer.Interfaces): Removed; they're now
2520 included in `TypeContainer.Types'.
2522 2007-03-20 Martin Baulig <martin@ximian.com>
2524 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2526 * class.cs (TypeContainer.CreateType): New public method. This is
2527 now called before DefineType() to create the TypeBuilders.
2528 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2529 has already been created by CreateType().
2530 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2531 don't resolve our base classes here; this has been moved into
2532 DefineBaseTypes(). We're now called from CreateType().
2533 (TypeContainer.DefineBaseTypes): New private method; resolve our
2534 base classes here. We're now called from DefineType().
2537 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2538 our types first to create all the TypeBuilders. After that, call
2539 TypeContainer.DefineType() on all the types which'll resolve their
2540 base classes and setup the resolve order.
2542 2007-03-20 Martin Baulig <martin@ximian.com>
2544 * class.cs (TypeContainer.Enums): Removed; they're now included in
2545 `TypeContainer.Types'.
2547 2007-03-20 Martin Baulig <martin@ximian.com>
2550 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2551 (TypeContainer.DoResolveMembers): Call DefineType() on our
2552 `compiler_generated' classes; moved here from DefineNestedTypes().
2555 (RootContext.ResolveTree): Call ResolveMembers() on all
2556 TypeContainer's in the `type_container_resolve_order'.
2558 2007-03-19 Marek Safar <marek.safar@gmail.com>
2560 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2562 2007-03-17 Marek Safar <marek.safar@gmail.com>
2564 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2565 implementation flags.
2567 2007-03-17 Marek Safar <marek.safar@gmail.com>
2569 * class.cs: More optimizations for type parameters.
2571 2007-03-15 Marek Safar <marek.safar@gmail.com>
2573 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2575 * ecore.cs, parameter.cs: More common code for both corlibs.
2577 * typemanager.cs (IsGenericMethod): Simplified.
2579 2007-03-15 Raja R Harinath <rharinath@novell.com>
2581 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2583 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2585 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2586 unconditionally. Simplify explanation.
2587 (Try.Resolve, Using.Resolve): Likewise.
2589 2007-03-15 Martin Baulig <martin@ximian.com>
2593 * decl.cs (DeclSpace): If we're a partial class, use our
2594 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2596 2007-03-15 Raja R Harinath <rharinath@novell.com>
2598 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2600 (FlowBranching.UsageVector): Update to changes.
2601 (FlowBranching.MergeSiblings): Likewise.
2602 * statement.cs: Likewise.
2604 2007-03-15 Martin Baulig <martin@ximian.com>
2609 (MemberCache): Added a special .ctor for type parameters.
2612 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2615 2007-03-09 Martin Baulig <martin@ximian.com>
2617 * enum.cs (Enum): Make this a TypeContainer.
2618 (EnumMember): Derive from `Const'.
2621 (Const.DoResolveValue): New protected virtual method; move most of
2622 the functionality of ResolveValue() here so we can override it in
2624 (Const.CreateConstantReference): Make this virtual.
2626 * class.cs (Kind): Add `Kind.Enum'.
2627 (TypeContainer.Emit): Don't emit the enums here; they're already
2628 in the `RootContext.typecontainer_resolve_order'.
2630 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2631 here; they're already in the `typecontainer_resolve_order'.
2633 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2634 TypeManager.DropGenericTypeArguments().
2637 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2638 (TypeManager.IsEnumType): Likewise.
2639 (TypeManager.EnumToUnderlying): Likewise.
2640 (TypeManager.IsEqual): Add support for enums.
2642 2007-03-12 Raja R Harinath <rharinath@novell.com>
2644 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2645 DefaultParameterValueAttribute to be undefined, say if System.dll
2648 2007-03-11 Marek Safar <marek.safar@gmail.com>
2650 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2653 2007-03-10 Marek Safar <marek.safar@gmail.com>
2655 * class.cs, parameter.cs: Unified parameters verification.
2657 2007-03-08 Martin Baulig <martin@ximian.com>
2659 * cs-parser.jay (constructor_header): Pass the location to the
2660 newly created TopLevelBlock.
2662 2007-03-07 Martin Baulig <martin@ximian.com>
2664 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2666 2007-03-06 Miguel de Icaza <miguel@novell.com>
2668 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2669 with the changes from David, fixes the build.
2671 2007-03-05 David Mitchell <dmitchell@logos.com>
2673 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2674 and its base interfaces to a one-dimensional array type S[],
2675 provided there is an implicit or explicit reference conversion
2678 2007-03-03 Marek Safar <marek.safar@gmail.com>
2680 * cs-tokenizer.cs: Implemented basic linq grammar.
2682 * driver.cs: Set linq lang version on demand.
2684 2007-02-26 Marek Safar <marek.safar@gmail.com>
2686 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2688 2007-02-25 Marek Safar <marek.safar@gmail.com>
2690 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2693 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2695 Check property and event extern attributes.
2697 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2700 2007-02-24 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #80407
2703 * ecore.cs: Don't report ambiguity error when methods have same parent.
2705 2007-02-23 Marek Safar <marek.safar@gmail.com>
2707 A fix for bug #80878
2708 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2710 2007-02-22 Marek Safar <marek.safar@gmail.com>
2712 * attribute.cs: Enable ExtensionAttribute presence test.
2714 2007-02-22 Marek Safar <marek.safar@gmail.com>
2716 * class.cs: Warn about missing GetHashCode only when Equals is override.
2718 * decl.cs: Check accessibility of type arguments.
2720 * typemanager.cs: Correctly report nullable array.
2722 2007-02-20 Marek Safar <marek.safar@gmail.com>
2724 * class.cs, report.cs: Capture more details when things go wrong.
2726 2007-02-20 Marek Safar <marek.safar@gmail.com>
2728 A fix for bug #80650
2729 * cs-parser.jay: Anonymous container starts at constructor declaration
2730 and not at block beginning because it has to be usable in constructor
2733 * statement.cs: Use context location and not block one for error reporting.
2735 2007-02-18 Marek Safar <marek.safar@gmail.com>
2737 A fix for bug #78712
2738 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2741 2007-02-18 Marek Safar <marek.safar@gmail.com>
2743 A fix for bug #80493 by Atsushi Enomoto
2744 * cs-parser.jay: Ignore invalid attribute target.
2746 2007-02-18 Marek Safar <marek.safar@gmail.com>
2748 * cs-tokenizer.cs: Ignore '\0' as white space character.
2750 2007-02-17 Miguel de Icaza <miguel@novell.com>
2752 * cs-parser.jay: Add support for lambda expressions to the mcs
2755 * lambda.cs: Only clone when we are probing, not on the final call
2756 (Compatible is the final call).
2758 * statement.cs (CloneContext): Introduce class to provide block
2759 remapping during clone.
2761 All statements Clone themselves now.
2763 (Clone): special handling for blocks, when we clone a block, we
2764 register the block inside this routine, as children of the block
2765 might trigger a lookup.
2767 * expression.cs: Add support for CloneContext in all expressions.
2769 2007-02-17 Marek Safar <marek.safar@gmail.com>
2771 A fix for bug #80493
2772 * statement.cs: Report ambiguous warning when interfaces are not related.
2774 2007-02-15 Marek Safar <marek.safar@gmail.com>
2776 C# 3.0 extension methods.
2778 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2779 cannot be used directly.
2781 * class.cs (Class.Emit): Emit extension attribute if any class method
2782 is extension method.
2783 (Method.Define): Add basic extension method validation conditions.
2784 (Method.Emit): Emit extension attribute for method.
2786 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2787 extension method exists. Currently we follow same approach as Microsoft
2788 does, emit even if a method or a class are private but this can change
2791 * cs-parser.jay: Add handling of `this' keyword in method parameters
2794 * decl.cs (DeclSpace.IsStaticClass): New property.
2795 (MemberCache.FindExtensionMethods): Looks for extension methods with
2796 defined name and extension type.
2798 * doc.cs: Updated after OverloadResolve changes.
2800 * driver.cs: Add new soft reference to System.Core.dll.
2802 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2803 (ExtensionMethodGroupExpr): Represents group of extension methods.
2805 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2806 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2807 to MethodGroupExpr and made non-static for easier customization.
2808 (Invocation.DoResolve): Add extension method lookup when no standard
2810 (MemberAccess.DoResolve): Try extension methods if no member exists.
2812 * modifiers.cs: Add METHOD_EXTENSION modifier.
2814 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2815 as well as candidate extension type.
2816 (ComputeNamespaces): When assembly constains extension methods registers
2818 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2819 extension method lookup.
2820 (Namespace.LookupExtensionMethod): Looks for extension method in this
2822 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2823 find a method which matches name and extensionType.
2825 * parameter.cs (Parameter): Add This modifer.
2826 (HasExtensionMethodModifier): New property.
2827 (Resolve): Add extension parameter check.
2828 (ModFlags): turned to property to exclude this modifier as it is not real
2830 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2832 * support.cs (ParameterData): Add ExtensionMethodType.
2833 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2835 * typemanager.cs: Add type and ctor extension attribute type.
2837 2007-02-15 Miguel de Icaza <miguel@novell.com>
2839 * report.cs (DisableErrors, EnableErrors): used to prevent error
2840 output when we are "trying" to compile various methods with
2843 * ecore.cs (Expression): Add Clone method that calls the virtual
2844 CloneTo method. The current CloneTo method in Expression throws
2845 an exception so we can track down all the places where this must
2846 be implemented (not using abstract, because that would be a lot of
2847 up-front-work before we can start testing the implementation
2850 Important: we only need Clone capabilities for expressions created
2851 by the parser, as the expressions we will be cloning are
2852 expressions in the pre-resolved state. This vastly simplifies
2855 (SimpleName): Add CloneTo that does nothing.
2856 (EmptyCast): Add CloneTo.
2858 * expression.cs (Binary): Implement CloneTo.
2859 (Invocation.IsApplicable): Store the current ec in
2860 EmitContext.TempEc and restore it on return. This is used so we
2861 do not have to sprinkle hundres of methods with an extra
2862 EmitContext, we know that the only user is the lambda expression
2863 ImplicitConversionExists code.
2865 (Argument): Add Cloning capabilities.
2866 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2867 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2868 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2869 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2870 IndexerAccess): Add Clone capability.
2872 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2874 (Argument): Add cloning capability.
2876 * assign.cs (Assign): Implement CloneTo.
2878 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2880 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2881 version by calling Convert with the EmitContext (that we are
2882 currently storing in ec, this is not great, but will do for now,
2883 to avoid passing EmitContext parameters to hundreds of functions
2884 that do not need them now).
2886 (SetExpression): Remove, it is not needed.
2888 (ContextualReturn): Implement CloneTo.
2890 * statement.cs (Statement): Implement cloning infrastructure,
2891 similar to expressions.
2893 (Block): Partial implementation of Clone for statements.
2895 (Return): Implement clone.
2897 * constant.cs (Constant.CloneTo): New method, does nothing.
2899 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2900 solution, until we decide how to exactly do this.
2902 2007-02-14 Marek Safar <marek.safar@gmail.com>
2904 A fix for bug #80493
2905 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2906 a property is override we need to use second accessor.
2908 2007-02-13 Marek Safar <marek.safar@gmail.com>
2910 A fix for bug #80418
2911 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2914 2007-02-13 Marek Safar <marek.safar@gmail.com>
2916 Another fix for bug #80749
2917 * pending.cs: Abstract class has priority over interfaces.
2919 2007-02-13 Marek Safar <marek.safar@gmail.com>
2921 Another fix for bug #80749
2922 * pending.cs: Abstract class has priority over interfaces.
2924 2007-02-13 Marek Safar <marek.safar@gmail.com>
2926 Another fix for bug #80749
2927 * pending.cs: Abstract class has priority over interfaces.
2929 2007-02-13 Marek Safar <marek.safar@gmail.com>
2931 Another fix for bug #80749
2932 * pending.cs: Abstract class has priority over interfaces.
2934 2007-02-13 Marek Safar <marek.safar@gmail.com>
2936 * class.cs Better error message.
2938 * driver.cs: Add shorter versions of -optimize option.
2940 2007-02-13 Martin Baulig <martin@ximian.com>
2942 * class.cs (Constructor.Emit): Check the return value of
2943 ec.ResolveTopBlock() and return on error.
2945 2007-02-13 Raja R Harinath <rharinath@novell.com>
2947 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
2948 message to fix error message regression.
2950 2007-02-12 Marek Safar <marek.safar@gmail.com>
2952 * delegate.cs: Delegate creation expression cannot be of Nullable type.
2954 2007-02-12 Marek Safar <marek.safar@gmail.com>
2956 A fix for bug #80749
2957 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
2958 its parent container.
2960 * class.cs (DefineFieldInitializers): Each initializer can has different
2963 * const.cs: Updated.
2965 2007-02-11 Miguel de Icaza <miguel@novell.com>
2967 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
2968 now all the heavy lifting to check that embedded statements or
2969 expressions have the right form is done in the ContextualReturn.
2971 (ContextualReturn): New class.
2973 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
2974 method that can be invoked to report 201, so we do not replicate
2977 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
2979 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
2980 treating tabs as spaces.
2982 2007-02-09 Marek Safar <marek.safar@gmail.com>
2984 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
2985 * assign.cs: Use full implicit conversion for right side check.
2987 2007-02-09 Marek Safar <marek.safar@gmail.com>
2989 * statement.cs (Switch): Switch over boolean type is not standardized.
2991 2007-02-08 Marek Safar <marek.safar@gmail.com>
2993 A fix for bug #80755
2994 * decl.cs (FindBaseEvent): Don't use method cache for events.
2996 2007-02-07 Marek Safar <marek.safar@gmail.com>
2998 * cs-parser.jay: Better syntax error handling.
3000 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3001 instead of underlying type value.
3003 2007-02-06 Marek Safar <marek.safar@gmail.com>
3005 * driver.cs: Check define identifier before is registered.
3007 * namespace.cs: Use existing error message.
3009 * report.cs: New warning.
3011 2007-02-06 Marek Safar <marek.safar@gmail.com>
3013 A fix for bug #80742
3014 * expression.cs: Delegate Invoke method can be called directly.
3016 2007-02-06 Marek Safar <marek.safar@gmail.com>
3018 A fix for bug #80676
3019 * class.cs (IsEntryPoint): The Main method can have params modifier.
3021 2007-02-04 Miguel de Icaza <miguel@novell.com>
3023 * parameter.cs (Parameter, Parameters): Add Clone method.
3025 * anonymous.cs (Compatible): Turn method into virtual method, so
3026 LambdaExpression can implement a different behavior.
3028 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3029 out the basic checking here, so it can be used by
3032 * lambda.cs: Introduce "Compatible" function that will do the
3035 2007-02-02 Marek Safar <marek.safar@gmail.com>
3037 * attribute.cs: Unified one error message.
3039 * class.cs (Class): Use type attributes and not properties to test static
3041 (IsEntryPoint): Don's pass local variable.
3043 * convert.cs: Removed duplicate check.
3045 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3047 * driver.cs: Don't crash when soft reference does not exist.
3049 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3050 (UsingEntry): Removed redundant allocation.
3052 * parameter.cs: Add fast path for type parameters.
3054 * support.cs: Don't allocate attribute when it's not used.
3056 2007-01-30 Miguel de Icaza <miguel@novell.com>
3059 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3060 this into a virtual method, so we can override it in LambdaExpression.
3062 * driver.cs: Improve diagnostics in case of failure.
3064 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3065 write a function that is slightly more complex and that parses:
3067 type identifier [, type identifier]* )
3069 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3072 (canEmpty ? i >= 0 : i > 0)
3074 2007-01-30 Raja R Harinath <rharinath@novell.com>
3076 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3077 exception on possibly valid code.
3079 2007-01-29 Raja R Harinath <rharinath@novell.com>
3081 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3083 (parse_opt_type_arguments): Remove. It's almost the same as
3085 (parse_namespace_or_typename): Use parse_less_than.
3087 2007-01-28 Miguel de Icaza <miguel@novell.com>
3089 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3090 this bug took a few hours to find, because the state saved and
3091 restored by PushPosition and PopPosition was ignoring the state of
3092 parse_generic_less_than.
3094 I can also now remove the handling of OP_LT and OP_GT, this solves
3097 * cs-tokenizer.cs: store the location for the ARROW token, we use
3100 (PushPosition, PopPosition): save/restore also `current_token',
3101 restore `parse_generic_less_than' (was missing).
3103 (parse_opt_type_arguments): use parse_type, not
3104 parse_namespace_or_typename to parse types.
3106 * lambda.cs: Empty new file, will eventually have the lambda
3107 expression implementation.
3109 * lambda.test: used to test the internal tokenizer.
3111 * report.cs (FeatureIsNotISO1): Rename from
3112 FeatureIsNotStandardized, because it was about the language level
3113 (1 vs 2) it was not about standarization.
3115 (FeatureRequiresLINQ): New.
3117 * support.cs (SeekableStreamReader): Only require that the reader
3118 is a TextReader, not a StreamReader, so we can plug StringReader.
3120 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3121 given position in the input stream the following tokens can be
3122 parsed as a type followed by an identifier.
3124 (is_punct): after a '(' if parse_type_and_parameter returns true,
3125 then return a special token OPEN_PARENS_LAMBDA which is used to
3126 avoid reduce/reduce errors in the grammar for the
3127 lambda_expression rules.
3129 (parse_type): implement a type parser inside the
3130 tokenizer, the parser only returns true or false depending on
3131 whether the input at a given position can be parsed as a type.
3133 (peek_token): new method used during type parsing.
3135 2007-01-28 Raja R Harinath <rharinath@novell.com>
3138 * anonymous.cs (ScopeInfo.InflateParameters): New.
3139 (AnonymousContainer.Resolve): Use it to redirect types of
3140 delegate parameters.
3142 2007-01-27 Raja R Harinath <rharinath@novell.com>
3145 * expression.cs (Error_InvalidArguments): Don't use two different
3146 messages for CS1503. Use ExtraInformation and
3147 SymbolRelatedToPreviousError instead.
3150 * decl.cs (DeclSpace.initialize_type_params): Don't access
3151 'type_params' of a partial class directly.
3153 2007-01-26 Miguel de Icaza <miguel@novell.com>
3155 * constant.cs: Removed a handful of out-of-range checks that were
3158 2007-01-25 Marek Safar <marek.safar@gmail.com>
3160 * expression.cs (CheckUselessComparison): Add additional check for char
3163 * namespace.cs: Fixed typo.
3165 2007-01-23 Miguel de Icaza <miguel@novell.com>
3167 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3168 gone, instead we inline the test, preventing the needless casts to
3169 longs, ulongs and doubles for the parameters, avoiding calls to
3170 methods that overchecked stuff, and instead inlined things
3173 2007-01-20 Marek Safar <marek.safar@gmail.com>
3175 * cs-parser.jay: Better parameter error handling.
3177 2007-01-17 Marek Safar <marek.safar@gmail.com>
3179 A fix for bug #80368, #80522
3180 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3181 whether array initializer contains constants only.
3182 (ArrayCreation.Emit): Use better formula to decide when
3183 are array initializers for static initialization.
3184 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3185 have to emit even constants otherwise they are pre-initialized.
3187 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3188 Raja R Harinath <rharinath@novell.com>
3190 Fix emit order of 'get' vs. 'set'.
3191 * support.cs (Accessors): New.
3192 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3193 Note the order in which accessors are declared in the source.
3194 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3195 Refactored from Property.Define and Indexer.Define.
3196 (PropertyBase.DefineAccessors): New helper that calls the above in
3197 appropriate order as noted by the parser.
3198 (Property.Define, Indexer.Define): Update to changes.
3199 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3201 2007-01-17 Raja R Harinath <rharinath@novell.com>
3203 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3204 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3205 there's an implicit conversion from the current type to the target
3206 type before converting the underlying constant.
3208 2007-01-16 Marek Safar <marek.safar@gmail.com>
3210 * const.cs (ResolveValue): Updated after constant conversion was made more
3213 * constant.cs (GetAttributableValue): constant to object conversion is
3214 used for attributes only.
3215 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3216 constant conversions.
3217 (LongConstant.ConvertImplicitly): Ditto.
3219 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3220 (ImplicitConversionStandard): Handle constant conversion as extra step.
3221 It solves the issue when constant conversion was called indirectly like
3222 inside array initializer and constant folding was skipped.
3224 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3227 * statement.cs(ImplicitConversionStandard): Updated after constant
3228 conversion was made more generic.
3230 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3232 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3233 Constraints, solves the problem where the compiler incorrectly
3234 reported that a type parameter was not constrained to a class (Bug
3237 2007-01-14 Marek Habersack <grendello@gmail.com>
3239 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3241 2007-01-14 Marek Safar <marek.safar@gmail.com>
3243 A fix for bug #80368
3244 * assign.cs (FieldInitializer): New class implements field
3245 initializer statement.
3247 * attribute.cs: Update after FieldMember rename.
3249 * class.cs (PropertyBasedMember): New common class for property based
3251 (InterfaceMemberBase): New base class for all members which can be used as
3252 an interface members.
3253 (MethodCore): Moved really common code to InterfaceMemberBase.
3254 (Method.Define): Equal and GetHasCode detection is relevant for methods
3256 (MethodData.Define): Don't assume that public event implements an
3257 interface automatically.
3258 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3260 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3261 (FieldMember): Merged with FieldBase.
3262 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3263 event extern modifier can be used.
3264 (EventField.EventFieldAccessor): Moved event field specific code here.
3265 (Event.AllowedModifiers): Even event can be extern.
3266 (Event.FindOutBaseMethod): New override specific to events.
3267 (Indexer.parameters): Reintroduce parameters because base class holds
3268 only properties common data.
3269 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3270 need do extra parameters check.
3272 * const.cs: Update after FieldMember rename.
3274 * decl.cs (MemberCache.FindBaseEvent): New method.
3276 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3277 to reflect that indexer is now derived from PropertyBased.
3279 * ecore.cs (GetMemberType): Made public.
3280 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3283 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3285 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3286 (RegisterEvent): Removed.
3287 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3288 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3290 2007-01-11 Raja R Harinath <rharinath@novell.com>
3293 * statement.cs (CollectionForeach.TryType): Prefer generic
3294 GetEnumerator over non-generic variant. Fix code to follow comments.
3296 2007-01-09 Raja R Harinath <rharinath@novell.com>
3299 * support.cs (ReflectionParameter): Don't use an invalid index on
3300 the generic parameter data.
3302 2007-01-08 Miguel de Icaza <miguel@novell.com>
3304 * driver.cs: Just add a tiny bit of infrastructure.
3306 2007-01-02 Marek Safar <marek.safar@gmail.com>
3308 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3309 where field type is struct from current assembly.
3311 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3314 2007-01-02 Marek Safar <marek.safar@gmail.com>
3316 A fix for bug #80381
3317 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3320 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3322 (Namespace.LookupType): Always use core types from corlib when speficied.
3324 * report.cs: A new warning.
3326 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3327 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3328 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3330 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3331 (InitCoreTypes): Set expression type of object_type and value_type
3332 immediately after lookup.
3334 2007-01-01 Miguel de Icaza <miguel@novell.com>
3336 * cs-tokenizer.cs: Accept Pc class characters (Connector
3337 Punctuation) as valid identifiers. Fixes #78259
3339 * expression.cs (Invocation.DoResolve): Moved the check for the
3340 use of `this' for doing method calls to the Invocation resolution
3341 step, after overload resolution has taken place instead of doing
3342 the check at the low-level `This.DoResolve' level.
3344 The `This.DoResolve'(appens before overload resolution, so it has
3345 no way of knowing if the method that will be called will be
3346 instace or static, triggering an erroneous report for cs0188 (Bug
3349 We now do the check for instance method invocations after we know
3350 what method will be called.
3352 (This.CheckThisUsage): Move the actual use of this structure
3353 checking into its own method and expose it.
3355 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3358 Exceptions: Null.ConvertImplicitly,
3359 Constant.ImplicitConversionRequired as there are too many call
3360 sites for passing the ec.
3362 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3363 EmitContext, if the value is null, then we do not try to provide
3364 the extra information from the error (If a userdefined conversion
3365 exists, as UserDefinedConversion requires a non null-EmitContext).
3369 2006-12-30 Raja R Harinath <rharinath@novell.com>
3371 * flowanalysis.cs (MyBitVector): Document some invariants.
3372 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3373 introduced below, and add a couple of others,
3375 2006-12-30 Marek Safar <marek.safar@gmail.com>
3377 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3378 GetPropertyFromAccessor and GetEventFromAccessor.
3380 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3381 overrides non-obsolete one.
3382 (Indexer.Define): Error message has been moved to the parser.
3384 * cs-parser.jay: Better syntax errors handling.
3386 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3387 when an invocation has no arguments.
3389 * ecore.cs: Removed not used caching.
3391 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3394 * report.cs: Add a new warning.
3396 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3398 * typemanager.cs (enumeration_type): Removed.
3399 (CSharpSignature): Reuses IsSpecialMethod.
3400 (IsEqual): Hack for MS BCL.
3401 (GetPropertyFromAccessor): New method.
3402 (GetEventFromAccessor): New method.
3403 (IsSpecialMethod): Fixed to handle more cases.
3405 2006-12-30 Marek Safar <marek.safar@gmail.com>
3407 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3408 Made white spaces array static.
3410 * ecore.cs (RemoveGenericArity): Optimized.
3412 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3414 (MyBitVector.initialize_vector): Simplified.
3416 2006-12-22 Miguel de Icaza <miguel@novell.com>
3418 * ecore.cs: Am not entirely happy with this hack, but it seems to
3419 address the issue in 80257 (a small test case for
3422 I set the MethodGroupExpr.Type to an internal compiler type
3423 (itself in this case) to force the resolution to take place. Why
3424 it does not take place with a null is beyond me.
3426 2006-12-20 Marek Safar <marek.safar@gmail.com>
3428 A fix for bug #80288
3429 * expression.cs (ResolveOperator): Consider user defined conversion for
3430 logical and operator too.
3431 (EmitBranchable): Optimization for logical and when full constant folding
3432 could not be applied but one operand is constant.
3434 2006-12-19 Marek Safar <marek.safar@gmail.com>
3436 * class.cs (GetClassBases): Write 5 times every day, will never use
3437 FullName for error reporting.
3439 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3441 2006-12-19 Martin Baulig <martin@ximian.com>
3443 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3444 the symbol file info here.
3446 2006-12-18 Marek Safar <marek.safar@gmail.com>
3448 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3449 of `elseif' is taking then following sections are not taking.
3450 Fixes an issue reported on mono mailing list.
3452 2006-12-18 Marek Safar <marek.safar@gmail.com>
3454 A fix for bug #80300
3455 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3456 a caller is not taking.
3458 2006-12-18 Raja R Harinath <rharinath@novell.com>
3460 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3461 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3462 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3463 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3464 * class.cs: Update to changes.
3466 2006-12-17 Marek Safar <marek.safar@gmail.com>
3468 A fix for bug #79934
3469 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3472 * class.cs (ResolveMembers): Register an iterator in current container and
3475 2006-12-16 Raja R Harinath <rharinath@novell.com>
3478 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3479 satisfy a params annotated parameter.
3481 2006-12-16 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #77014
3484 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3485 paramters correctly and not rely on hacks in Parameters class.
3486 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3488 (Invocation.VerifyArgumentsCompat): Ditto.
3489 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3492 * parameter.cs (HasParams): Don't assume that params is the last one.
3494 * support.cs (ReflectionParameters.ctor): Look for params attribute
3496 (ReflectionParameters.ParameterType): Removed hack when we returned last
3497 parameter for out of range parameters.
3498 (ParameterName, ParameterModifier): Ditto.
3500 2006-12-14 Marek Safar <marek.safar@gmail.com>
3502 A fix for bug #79987
3503 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3504 when assembly is not CLS compliant but type is. I have no idea why is this
3507 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3509 2006-12-13 Miguel de Icaza <miguel@novell.com>
3511 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3512 in struct constructors, they are basically no-ops.
3514 2006-12-12 Marek Safar <marek.safar@gmail.com>
3516 * cs-tokenizer.cs (Position): Save preprocessor status too.
3518 2006-12-12 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #77794
3521 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3523 2006-12-12 Marek Safar <marek.safar@gmail.com>
3525 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3527 (pp_expr): Report error for an invalid expression.
3528 (handle_preprocessing_directive): Simplified; add more error checking.
3530 2006-12-11 Marek Safar <marek.safar@gmail.com>
3532 A fix for bug #74939
3533 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3534 directives handling.
3536 2006-12-10 Marek Safar <marek.safar@gmail.com>
3538 A fix for bugs #80093, and #75984
3539 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3540 logic, it seems to me as it worked before "by coincidence".
3541 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3542 (cleanup): Enabled endif check.
3544 2006-12-09 Marek Safar <marek.safar@gmail.com>
3546 A fix for bug #80162
3547 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3548 enumerators are never ambiguous.
3550 2006-12-08 Raja R Harinath <rharinath@novell.com>
3553 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3555 2006-12-06 Marek Safar <marek.safar@gmail.com>
3557 A fix for bug #80144
3558 * class.cs (EventProperty.Define): Explicit implementation means
3559 that an even is used.
3561 2006-12-06 Marek Safar <marek.safar@gmail.com>
3563 Fixes the operators implementation (part II)
3565 * cfold.cs (DoConstantNumericPromotions): Renamed to
3566 DoBinaryNumericPromotions and simplified.
3567 (BinaryFold): Couple of conversion fixes; simplified.
3569 * constant.cs, ecore.cs, literal.cs
3570 (ToType): Renamed to ConvertImplicitly.
3571 (Reduce): Renamed to ConvertExplicitly.
3573 * class.cs, convert.cs: Updated.
3575 * expression.cs: TryReduce doesn't throw an exception.
3577 2006-12-01 Marek Safar <marek.safar@gmail.com>
3579 A fix for bug #80108
3580 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3583 2006-11-30 Marek Safar <marek.safar@gmail.com>
3585 Fixes unary operators implementation (part I)
3588 * cfold.cs (Error_CompileTimeOverflow): Made internal
3590 * const.cs (IConstant): Changed to use reference to constant and
3591 not constant itself.
3592 Updated IConstant implementations.
3594 * constant.cs (CreateConstant): New factory method.
3595 Updated IConstant implementation.
3597 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3599 * ecore.cs: Updated to use CreateConstantReference.
3601 * enum.cs: Reflects IConstant changes.
3603 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3605 * literal.cs (NullConstant): Change to be independently usable.
3607 2006-11-29 Martin Baulig <martin@ximian.com>
3609 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3610 we need to emit the scope initializer before calling the base .ctor.
3612 * anonymous.cs: Merged back from the new anonymous methods branch.
3613 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3615 * expression.cs (ParameterReference.DoResolveBase): Create a
3616 "normal" ScopeInfo when capturing parameters rather than using the
3617 root scope; this makes things work with anonymous methods having
3621 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3623 2006-11-22 Marek Safar <marek.safar@gmail.com>
3625 A fix for bug #79987
3626 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3627 check to a base class.
3628 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3629 only when assembly has missing attribute.
3630 * report.cs: Update.
3632 2006-11-21 Marek Safar <marek.safar@gmail.com>
3634 * cs-tokenizer.cs: Merged with gmcs version.
3636 2006-11-20 Marek Safar <marek.safar@gmail.com>
3639 * cs-parser.jay: Better error message when partial keyword is misplaced.
3641 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3643 A fix for bug #79810
3644 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3645 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3646 a RuntimeWrappedException by default.
3648 2006-11-18 Marek Safar <marek.safar@gmail.com>
3650 A fix for bug #79843
3651 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3653 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3655 2006-11-18 Marek Safar <marek.safar@gmail.com>
3657 * driver.cs, namespace.cs: Uses faster IndexOf version.
3659 2006-11-17 Marek Safar <marek.safar@gmail.com>
3661 A fix for bug #79941
3662 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3664 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3665 even if internal name is different.
3666 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3667 (UserDefinedConversion): Simplified as the operators cannot be internal.
3668 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3670 (MethodLookup): Replaced EmitContext with parentType.
3671 * expression.cs: Updated.
3673 2006-11-09 Raja R Harinath <rharinath@novell.com>
3675 * driver.cs (BadAssembly): Handle all the ugliness of
3676 DefineDynamicAssembly.
3678 2006-11-08 Raja R Harinath <rharinath@novell.com>
3680 Address parts of #58244 -- most of what's left is in the runtime
3681 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3682 CS1509 error checks, and handle them for all assembly loads, not
3683 just the first invocation.
3684 (LoadModule): Likewise. Move handling of 'adder_method' ...
3685 * codegen.cs (AssemblyClass.AddModule): ... here.
3687 2006-11-02 Marek Safar <marek.safar@gmail.com>
3689 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3690 IEnumerable<T> is ambiguous.
3692 2006-10-31 Marek Safar <marek.safar@gmail.com>
3694 A fix for bug #67689
3695 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3696 GetEnumerator is ambiguous.
3698 * report.cs: Add new warning.
3700 2006-10-29 Marek Safar <marek.safar@gmail.com>
3702 A fix for bug #78602
3703 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3704 to protected member can be nested type.
3706 2006-10-28 Marek Safar <marek.safar@gmail.com>
3708 A fix for bug #78965
3709 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3710 to protected member must derive from current type.
3712 2006-10-27 Marek Safar <marek.safar@gmail.com>
3714 assign.cs: Reuses error method.
3716 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3717 instead of type for constants.
3718 (Expression.Error_ValueAssignment): Common error method.
3720 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3723 2006-10-27 Marek Safar <marek.safar@gmail.com>
3725 A fix for bug #79081
3726 * expression.cs (MemberAccess.DoResolve): Check nested type
3729 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3731 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3733 2006-10-26 Marek Safar <marek.safar@gmail.com>
3735 A fix for bug #76591
3736 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3738 2006-10-26 Marek Safar <marek.safar@gmail.com>
3740 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3741 type forwarder of the same type multiple times.
3743 2006-10-26 Raja R Harinath <rharinath@novell.com>
3746 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3747 instance as an rvalue, even when we later resolve as an lvalue.
3749 2006-10-25 Martin Baulig <martin@ximian.com>
3751 * anonymous.cs: Fix #79673.
3753 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3755 A fix for bug #79666
3756 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3757 ignored when is optimized (= default value) as its value is already set.
3759 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3761 A fix for bug #79724
3762 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3763 TypeContainer for type lookup.
3765 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3767 A fix for bug #79231
3768 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3769 * expression.cs (OverloadResolve): Always convert type name for
3771 (ResolveNamespaceOrType): Don't confuse a nested type with any
3774 2006-10-18 Martin Baulig <martin@ximian.com>
3776 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3778 2006-10-17 Miguel de Icaza <miguel@novell.com>
3780 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3781 an int32, but requesting an int64 from the conversion
3783 2006-10-12 Martin Baulig <martin@ximian.com>
3786 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3788 2006-10-12 Martin Baulig <martin@ximian.com>
3791 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3793 2006-10-11 Miguel de Icaza <miguel@novell.com>
3795 * convert.cs: Remove broken code: I was doing the "Existance"
3796 tests for Implicit conversions.
3798 2006-10-10 Miguel de Icaza <miguel@novell.com>
3800 * convert.cs: Added one missing case in
3801 ImplicitStandardConversionExists uint64 to intptr.
3805 * typemanager.cs (uintptr_type): another core known type.
3807 * ecore.cs (OperatorCast): routine used to do cast operations that
3808 depend on op_Explicit. We could change some of the Decimal
3809 conversions to use this.
3811 This one has a probe mechanism that checks both types for an op_
3812 which it coudl be used to eliminate two classes: CastToDecimal
3813 and CastFromDecimal.
3815 * convert.cs: Implement the conversions documented in #59800
3817 2006-10-10 Martin Baulig <martin@ximian.com>
3819 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3820 before RootScope.ResolveMembers().
3822 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3823 `CurrentType' if appropriate.
3825 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3827 A fix for bug #78568
3828 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3829 when contains binary operators.
3830 * cs-parser.jay: Updated.
3832 2006-10-09 Martin Baulig <martin@ximian.com>
3835 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3836 moved that into Define() and also do the other type parameter
3837 checks there. Fixes #79094. Added gtest-292.cs.
3840 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3841 since that doesn't include type parameters; don't use `Ldelema'
3842 for type parameters. Fixes #78980. Added gtest-293.cs.
3844 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3847 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3848 conversion is allowed.
3850 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3852 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3853 error reporting when no error occurs.
3855 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3857 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3860 2006-10-06 Raja R Harinath <rharinath@novell.com>
3863 * class.cs (DefineTypeBuilder): Check circular dependencies before
3864 setting the parent of the TypeBuilder.
3865 (CheckRecursiveDefinition): Don't use 'BaseType', since
3866 it may not be valid until after DefineTypeBuilder. Use
3867 'base_type' instead.
3869 2006-10-04 Martin Baulig <martin@ximian.com>
3871 Merged the Anonymous Methods patch.
3873 * anonymous.cs, iterators.cs: The new anonymous methods code.
3875 * statement.cs (Variable): New public abstract class.
3876 (LocalInfo.Variable): New public property.
3877 (LocalInfo.ResolveVariable): New public method.
3878 (Block.Flags): Add `IsIterator'.
3879 (Block.AddVariable): Improved the CS0136 check.
3880 (Block.AnonymousChildren): New public property.
3881 (Block.AddAnonymousChild): New public method.
3882 (ToplevelBlock): Update to use the new anonymous method framework.
3883 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3884 `ToplevelBlock'; this is required to correctly implement the
3886 (Fixed, Using): Use `TemporaryVariable' instead of directly
3887 creating the `LocalBuilder'.
3889 * parameter.cs (Parameter.ResolveVariable): New public method.
3890 (Parameters.ResolveVariable): Likewise.
3892 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3894 * class.cs (TypeContainer): Replaced the `iterators' list and
3895 corresponding methods with a list of `CompilerGeneratedClass'es.
3896 (TypeContainer.ResolveMembers): New public method.
3897 (Method): `IIteratorContainer' has been replaced by
3900 * expression.cs (VariableReference): New public abstract base
3901 class for `LocalVariableReference', `ParameterReference' and
3904 * codegen.cs (EmitContext): Removed `capture_context',
3905 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3906 (EmitContext.EmitThis): Removed.
3908 * cs-parser.jay: Replace `iterator_container' with
3911 2006-10-04 Martin Baulig <martin@ximian.com>
3913 * generic.cs (GenericMethod): Don't make this abstract.
3914 (Constraints.Clone): Added dummy implementation.
3916 2006-10-04 Raja R Harinath <harinath@gmail.com>
3919 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3920 'declspaces'. Avoid allocating arrays willy-nilly.
3923 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3924 cases out of the switch.
3926 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3928 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3929 message when non-generic type is used with the type arguments.
3930 * expression.cs: Updated.
3932 2006-09-28 Raja R Harinath <rharinath@novell.com>
3935 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3936 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3937 Change semantics slightly. Don't insist on having only one
3938 temporary EmptyExpression -- just throttle the creation of new ones.
3941 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
3942 non-interfaces too. If no methods are found, don't try to create
3945 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3947 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
3950 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
3951 us produce better error message.
3953 2006-09-27 Marek Safar <marek.safar@seznam.cz>
3955 * expression.cs (Binary.ResolveOperator): Warn about a side effect
3956 of the `|' operator.
3958 * report.cs: A new warning added.
3960 2006-09-27 Martin Baulig <martin@ximian.com>
3962 * generic.cs (GenericMethod): Don't make this abstract.
3964 2006-09-27 Martin Baulig <martin@ximian.com>
3967 (InternalErrorException): Added overloaded ctor taking a params array.
3969 2006-09-26 Marek Safar <marek.safar@seznam.cz>
3971 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
3972 Fixed the cases when same error was reported twice.
3974 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
3975 now report symbol information.
3977 2006-09-25 Martin Baulig <martin@ximian.com>
3979 * class.cs: Completely unified with the gmcs version.
3981 2006-09-25 Martin Baulig <martin@ximian.com>
3983 * typemanager.cs (TypeManager.IsNullableType): New public function.
3984 (TypeManager.IsNullableTypeOf): Likewise.
3985 (TypeManager.IsNullableValueType): Likewise.
3987 * class.cs (MethodCore): Added the `GenericMethod' argument from
3988 gmcs and also unified all classes derived from `MethodCore' with gmcs.
3990 2006-09-24 Raja R Harinath <harinath@gmail.com>
3992 * convert.cs: Unify with gmcs version.
3994 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3996 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
3997 verify them as well.
3999 * report.cs: New warning.
4001 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4003 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4004 for anonymous block with out argument.
4006 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4008 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4009 not used private events only.
4011 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4013 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4015 * const.cs (Const.Define): Check for constant type.
4016 (Const.IsConstantTypeValid): Looks for valid constant types.
4018 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4020 * ecore.cs (EmptyConstantCast): New common class for all constant based
4023 * expression.cs (Is.DoResolve): Handle null constant especially.
4024 (New.DoResolve): Check for new void().
4025 (MemberAccess.DoResolve): Cope with all kind of nulls.
4027 * literal.cs (NullConstant): Uses EmptyConstantCast.
4028 (NullDefault): Based on EmptyConstantCast.
4029 (NullLiteral): Uses EmptyConstantCast.
4031 * statement.cs (Block.ResolveMeta): Check for constant type.
4033 2006-09-22 Martin Baulig <martin@ximian.com>
4035 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4037 2006-09-22 Raja R Harinath <rharinath@novell.com>
4039 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4043 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4044 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4047 2006-09-22 Martin Baulig <martin@ximian.com>
4049 * ecore.cs: Merged with the gmcs version.
4051 * generic.cs (ConstructedType): New dummy class.
4052 (TypeArguments): Don't make this abstract.
4055 (TypeManager.IsGenericTypeDefinition): New method.
4056 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4058 2006-09-22 Raja R Harinath <rharinath@novell.com>
4060 * expression.cs (ComposedCast): Check for arrays of TypedReference
4061 before creating the type, not after.
4063 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4065 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4066 after ToType change.
4068 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4069 when constant must be implicitly convertible.
4071 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4073 * ecore.cs (NullCast): Derives from NullConstant.
4075 * expression.cs (Is.DoResolve): Removed useless variables.
4076 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4077 (New.Constantify): Add enum support.
4078 (MemberAccess.DoResolve): Add warning when accessing null constant or
4081 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4084 * literal.cs (NullConstant): New abstract class with common
4085 functionality for all null specializations.
4086 (NullDefault): Represents default(X) when result can be
4088 (NullLiteral): Updated.
4090 * report.cs: Add new warning.
4092 2006-09-21 Martin Baulig <martin@ximian.com>
4094 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4096 2006-09-21 Martin Baulig <martin@ximian.com>
4098 * generic.cs (GenericConstraints): New dummy class.
4099 (Constraints): Likewise.
4100 (TypeParameter): Likewise.
4101 (TypeParameterName): Likewise.
4102 (GenericMethod): Likewise.
4104 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4106 * decl.cs: Merged with the gmcs version.
4108 2006-09-21 Raja R Harinath <rharinath@novell.com>
4110 * generic.cs (TypeParameter): Implement IMemberContainer.
4111 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4113 * rootcontext.cs: Unify with gmcs version.
4115 * report.cs: Unify with gmcs version.
4116 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4117 from gmcs/generics.cs.
4118 * generics.cs (TypeParameter): New dummy class.
4120 * support.cs: Unify with gmcs version.
4122 2006-09-20 Raja R Harinath <rharinath@novell.com>
4124 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4125 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4127 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4128 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4129 * mcs.exe.sources: Add generic.cs.
4131 * codegen.cs: Unify with gmcs version.
4133 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4134 (EmitContext): Add GenericDeclContainer implementation.
4135 * decl.cs (MemberCore, DeclSpace): Likewise.
4136 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4138 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4139 MCS TypeManager has a corresponding dummy method.
4141 2006-09-19 Martin Baulig <martin@ximian.com>
4143 * expression.cs: Completely merged with the gmcs version.
4145 2006-09-19 Martin Baulig <martin@ximian.com>
4147 * expression.cs (Invocation): Merged with the gmcs version.
4148 (ArrayAccess.GetStoreOpcode): Likewise.
4150 2006-09-19 Martin Baulig <martin@ximian.com>
4153 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4154 (TypeManager.IsGenericMethodDefinition): Likewise.
4156 2006-09-19 Martin Baulig <martin@ximian.com>
4159 (TypeManager.IsEqual): Moved the gmcs implementation here.
4160 (TypeManager.DropGenericTypeArguments): Likewise.
4161 (TypeManager.DropGenericMethodArguments): Likewise.
4162 (TypeManager.GetTypeArguments): Moved here from gmcs.
4163 (TypeManager.HasGenericArguments): Likewise.
4165 2006-09-19 Martin Baulig <martin@ximian.com>
4167 * expression.cs (Binary): Merged with the gmcs version.
4169 2006-09-19 Martin Baulig <martin@ximian.com>
4171 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4173 2006-09-19 Martin Baulig <martin@ximian.com>
4175 * typemanager.cs: Merged with the gmcs version.
4177 2006-09-16 Raja R Harinath <rharinath@novell.com>
4179 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4180 * driver.cs: Likewise.
4182 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4185 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4186 only if parent type is class.
4187 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4190 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4193 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4195 * typemanager.cs(CSharpName): Converts NullType to null.
4197 2006-09-15 Martin Baulig <martin@ximian.com>
4200 (TypeManager.GetMethodName): Added mcs implementation.
4201 (TypeManager.IsEqual): Likewise.
4204 (SimpleName.RemoveGenericArity): Added dummy implementation.
4206 * pending.cs: Merged with the gmcs version.
4208 2006-09-15 Martin Baulig <martin@ximian.com>
4210 * statement.cs: Merge with the gmcs version.
4212 2006-09-15 Martin Baulig <martin@ximian.com>
4214 * statement.cs (Switch): Merge with the gmcs implementation
4215 (without nullables), which is newer.
4217 2006-09-15 Martin Baulig <martin@ximian.com>
4219 * statement.cs (Block.Variables): Make this public.
4220 (ToplevelBlock.Parameters): Make this a property.
4221 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4223 2006-09-15 Martin Baulig <martin@ximian.com>
4225 * namespace.cs: Merge with the gmcs version.
4227 2006-09-15 Martin Baulig <martin@ximian.com>
4229 * decl.cs (MemberName): Minor code cleanups.
4231 2006-09-15 Martin Baulig <martin@ximian.com>
4233 * parameter.cs: Merge with the gmcs version.
4235 2006-09-15 Martin Baulig <martin@ximian.com>
4237 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4238 and an error in mcs.
4240 2006-09-15 Martin Baulig <martin@ximian.com>
4242 * flowanalysis.cs: Merged from GMCS; added the generics code into
4243 a `GMCS_SOURCE' conditional so we can share this file.
4245 2006-09-08 Martin Baulig <martin@ximian.com>
4247 * typemanager.cs (TypeManager.interlocked_type): New public field.
4248 (TypeManager.int_interlocked_compare-exchange): New public field.
4249 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4250 enumerator types here and call InitGenericCoreTypes().
4251 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4252 after calling InitEnumUnderlyingTypes().
4255 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4256 `classes_second_stage'.
4258 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4260 * assign.cs, ecore.cs, expression.cs: Share error message text.
4261 * class.cs (FieldMember.Define): Check for varible of static type.
4262 * driver.cs (LoadAssembly): Uses error output for errors.
4263 * statement.cs: Updated.
4265 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4267 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4270 2006-09-07 Martin Baulig <martin@ximian.com>
4273 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4275 2006-08-29 Miguel de Icaza <miguel@novell.com>
4277 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4279 2006-08-17 Miguel de Icaza <miguel@novell.com>
4281 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4282 #52019 and #79064, the use of the \uXXXX sequence in source code
4283 to represent unicode characters.
4285 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4287 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4289 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4291 2006-08-13 Miguel de Icaza <miguel@novell.com>
4293 * assign.cs: Catch attempts to assign to a method groups in += and
4296 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4299 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4301 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4303 * class.cs (Method.Define): Issue a warning when generic method looks like
4305 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4308 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4310 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4312 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4313 search all base interfaces as a member can be ambiguous.
4314 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4315 Constructor member type filter.
4316 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4317 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4318 reporting for returned memberinfos.
4319 * report.cs: Updated.
4320 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4321 version to work on all runtimes.
4322 (TypeManager.RealMemberLookup): Removed members filtering.
4324 2006-08-08 Raja R Harinath <rharinath@novell.com>
4326 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4327 (PropertyExpr.EmitAssign): Likewise.
4328 * expression.cs (Indirection.EmitAssign): Likewise.
4329 (LocalVariableReference.EmitAssign): Likewise.
4330 (ParameterReference.EmitAssign): Likewise.
4331 (Invocation.EmitArguments): Likewise.
4332 (ArrayAccess.EmitAssign): Likewise.
4333 (IndexerAccess.EmitAssign): Likewise.
4334 (This.EmitAssign): Likewise.
4335 (ConditionalLogicalOperator.Emit): Likewise.
4338 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4339 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4340 leave it in after returning it.
4341 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4343 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4345 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4348 2006-08-03 Raja R Harinath <rharinath@novell.com>
4350 Fix cs0146-3.cs and cs0146-4.cs.
4351 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4352 enclosing types don't depend on the current type.
4354 2006-08-02 Raja R Harinath <rharinath@novell.com>
4357 * class.cs (TypeContainer.DoDefineMembers): Use
4358 FindBaseMemberWithSameName on Parent, since we're interested in
4359 whether we hide inherited members or not.
4360 (FindBaseMemberWithSameName): Make slightly more robust.
4362 Fix the non-generic testcase from #77396
4363 * decl.cs (DeclSpace.DeclContainer): Remove override.
4365 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4366 declspaces for doppelgangers too.
4367 (UsingEntry): Implement IResolveContext.
4368 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4369 'this' as the resolve context.
4370 (LocalAliasEntry): Likewise.
4372 Implement parts of #77403
4373 * roottypes.cs (RootDeclSpace): New. Used to represent the
4374 toplevel declaration space. Each namespace declaration introduces
4375 a "partial" root declaretion space.
4376 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4377 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4378 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4379 from 'current_namespace.SlaveDeclSpace'.
4380 (namespace_declaration): Likewise.
4381 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4382 check. It can't happen now.
4383 * decl.cs (DeclSpace.LookupType): Likewise.
4384 * driver.cs (MainDriver): Sanity check.
4386 2006-08-01 Raja R Harinath <rharinath@novell.com>
4388 * decl.cs (DeclSpace.FindNestedType): Remove.
4389 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4390 LookupTypeContainer to get the container of the nested type.
4391 * class.cs (TypeContainer.FindNestedType): Make non-override.
4393 2006-07-31 Raja R Harinath <rharinath@novell.com>
4395 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4396 * class.cs (TypeContainer.PartialContainer): ... here.
4397 (TypeContainer.AddBasesForPart): New helper.
4398 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4400 * cs-parser.jay (current_class): Convert to DeclSpace.
4401 (struct_declaration, interface_declaration, class_declaration):
4402 Use AddBasesForPart instead of .Bases directly.
4403 * const.cs, iterators.cs: Update to changes.
4405 2006-07-28 Raja R Harinath <rharinath@novell.com>
4407 * class.cs (TypeContainer.AddMemberType): Rename from
4409 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4410 (AddTypeContainer): New. Combine AddClassOrStruct and
4412 (AddPartial): Update. Add 'is_partial' argument.
4413 * roottypes.cs: Update to changes.
4414 * cs-parser.jay (push_current_class): New helper for handling
4415 current_container and current_class.
4416 (struct_declaration, interface_declaration, class_declaration):
4419 2006-07-26 Raja R Harinath <rharinath@novell.com>
4421 * roottypes.cs: Rename from tree.cs.
4423 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4424 * tree.cs (Tree, ITreeDump): Remove types.
4425 * rootcontext.cs (tree, Tree): Remove fields.
4426 (root, ToplevelTypes): New.
4427 * *.cs: Update to rename.
4429 * tree.cs (Tree.RecordDecl): Remove.
4430 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4432 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4434 2006-07-23 Raja R Harinath <harinath@gmail.com>
4436 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4437 DoFlowAnalysis and OmitStructFlowAnalysis here.
4438 (ec.With): Rename from WithUnsafe and generalize.
4439 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4440 (ec.WithFlowAnalyis): New.
4441 * ecore.cs, expression.cs, statement.cs: Update.
4443 2006-07-22 Raja R Harinath <harinath@gmail.com>
4445 * statement.cs (Block.ResolveMeta): Simplify slightly.
4447 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4448 multiple boolean fields. Convert InUnsafe, constant_check_state,
4449 check_state to flags.
4450 (CheckState, ConstantCheckState): Update.
4451 (InUnsafe): New read-only property.
4452 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4454 (WithUnsafe): New helper similar to WithCheckState.
4455 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4456 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4458 2006-07-21 Raja R Harinath <rharinath@novell.com>
4460 Make comparisons use the same IL irrespective of whether they're
4461 in a 'checked' or 'unchecked' context: one of the issues in #78899
4462 * codegen.cs (EmitContext.CheckState): Make read-only property.
4463 (EmitContext.ConstantCheckState): Likewise.
4464 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4465 helper that implement a save/restore stack for CheckState
4466 values. This is the only way to change check-state.
4467 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4468 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4469 (CheckedExpr.EmitBranchable): New forwarding method.
4470 (UnCheckedExpr): Likewise.
4471 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4472 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4473 (Checked.Resolve, checked.DoEmit): Likewise.
4475 2006-07-20 Miguel de Icaza <miguel@novell.com>
4477 * anonymous.cs: Cache the resolved anonymous delegate, and return
4478 this so that the ResolveTopBlock is only triggered once, not
4481 Currently we trigger ResolvetopBlock twice due to a first pass of
4482 argument check compatibility, and a second pass that does the
4485 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4487 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4489 * rootcontext.cs (Reset): Add helper_classes.
4491 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4494 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4497 2006-07-13 Miguel de Icaza <miguel@novell.com>
4499 * statement.cs (Lock): Handle expressions of type
4500 TypeManager.null_type specially. Fixes #78770
4502 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4504 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4507 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4509 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4510 for accessors as well.
4511 * ecore.cs (EventExpr): Add AccessorTable.
4513 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4516 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4517 for CS0122 where appropriate.
4518 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4520 (Filter): Assembly can be null in the case of top level attributes.
4522 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4526 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4527 is done at global level.
4529 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4531 A fix for #77002, Implemented TypeForwarder support.
4533 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4534 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4535 * typemanager.cs (): Add type_forwarder_attr_type.
4537 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4539 * report.cs: Add CS0469 warning.
4541 2006-06-21 Martin Baulig <martin@ximian.com>
4543 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4544 the `try'-block, so we also report CS0016 etc. there.
4546 2006-06-21 Martin Baulig <martin@ximian.com>
4549 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4551 2006-06-21 Martin Baulig <martin@ximian.com>
4553 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4554 also report CS1686 for parameters.
4556 2006-06-21 Martin Baulig <martin@ximian.com>
4558 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4559 instead of an error if the value is not implicitly convertible to
4560 the switch types; fixes #77964.
4562 2006-06-21 Raja R Harinath <rharinath@novell.com>
4565 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4566 FieldBuilder is null.
4569 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4570 'left' and 'right' before error-checking.
4572 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4574 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4576 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4577 (FieldExpr.DoResolve): likewise.
4578 (PropertyExpr.InstanceResolve): likewise.
4579 (EventExpr.InstanceResolve): likewise.
4581 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4583 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4584 attribute applicable tests for attribute argument.
4586 2006-06-02 Raja R Harinath <rharinath@novell.com>
4589 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4590 (Binary.OverloadResolve_PredefinedIntegral): New.
4591 (Binary.OverloadResolve_PredefinedFloating): New.
4592 (Binary.OverloadResolve_PredefinedString): New.
4593 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4594 Follow the standard more closely, and treat numeric promotions in
4595 terms of overload resolution.
4596 (Binary.CheckShiftArguments): Simplify.
4598 2006-06-01 Raja R Harinath <rharinath@novell.com>
4600 * flowanalysis.cs (MyBitVector): Simplify representation.
4601 (MyBitVector.Clone): Avoid allocating BitArray.
4602 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4603 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4604 (*): Update. Change all references to MyBitVector.And and
4605 MyBitVector.Or to &= and |=.
4607 2006-05-29 Raja R Harinath <rharinath@novell.com>
4610 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4611 to param arguments too.
4613 2006-05-26 Miguel de Icaza <miguel@novell.com>
4615 * cs-parser.jay: Catch another parsing form for arglist being
4616 followed by other arguments. Fixes #78313.
4618 2006-05-24 Raja R Harinath <rharinath@novell.com>
4620 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4621 checking of out parameters to ...
4622 (FlowBranchingToplevel.Merge): ... here.
4623 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4624 set, propagate the origin upward, and only complain if there was
4626 (FlowBranchingException.AddContinueOrigin): Likewise.
4627 (FlowBranchingException.AddReturnOrigin): Likewise.
4628 (FlowBranchingException.AddGotoOrigin): Likewise.
4630 2006-05-23 Raja R Harinath <rharinath@novell.com>
4632 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4633 unreachable, skip it.
4634 (FlowBranchingException.Merge): Always propagate jumps, even if
4635 the finally block renders subsequent code unreachable.
4637 2006-05-18 Raja R Harinath <rharinath@novell.com>
4640 * statement.cs (Goto.Resolve): Move responsibility for resolving
4641 'goto' to FlowBranching.AddGotoOrigin.
4642 (Goto.SetResolvedTarget): New. Callback to set the
4643 LabeledStatement that's the target of the goto.
4644 (Goto.DoEmit): Use Leave instead of Br when crossing an
4645 unwind-protect boundary.
4646 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4647 LookupLabel and adjust to new semantics.
4648 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4649 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4650 Goto.SetResolvedTarget to update target.
4651 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4652 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4653 AddBreakOrigin & co. Delay propagation until ...
4654 (FlowBranchingException.Merge): ... this.
4656 * statement.cs (Block.Resolve): Always depend on flow-branching to
4657 determine unreachability. Kill workaround that originally emitted
4658 only one statement after an "unreachable" label (see infloop in
4661 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4662 This is still "wrong", but anything better would probably need a
4663 multi-pass algorithm.
4664 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4665 usage vector. Force current usage vector to be reachable, to
4666 optimistically signify backward jumps.
4667 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4669 (FlowBranchingLabeled.Merge): New. If no backward jump was
4670 detected, return the original salted-away usage vector instead,
4671 updated with appropriate changes. Print unreachable warning if
4673 * statement.cs (Block.Resolve): Don't print unreachable warning on
4674 a labeled statement.
4676 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4678 * driver.cs: Pass filename without path to AssemblyBuilder's
4679 AddResourceFile. Fixes bug #78407.
4681 2006-05-17 Raja R Harinath <rharinath@novell.com>
4683 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4684 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4685 (FlowBranching.MergeChild): Overwrite
4686 reachability information from Labeled branchings too.
4688 2006-05-16 Raja R Harinath <rharinath@novell.com>
4690 * statement.cs (Goto.Resolve): Merge jump origins here ...
4691 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4693 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4694 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4695 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4696 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4698 * statement.cs (Goto.Resolve): ... not here.
4699 (Goto.Emit): Remove CS1632 check.
4701 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4703 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4706 2006-05-11 Raja R Harinath <rharinath@novell.com>
4708 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4709 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4710 (FlowBranchingException.Label): Likewise.
4712 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4714 (MyBitVector.Or): Use it to avoid losing information (Count).
4715 (FlowBranching.MergeOrigins): Likewise.
4717 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4718 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4719 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4720 (UsageVector.ToString): Simplify.
4721 (UsageVector.MergeSiblings): Move here from ...
4722 (FlowBranching.Merge): ... here.
4723 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4726 2006-05-10 Raja R Harinath <rharinath@novell.com>
4728 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4729 null bitvector is treated as all-true.
4731 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4732 (MyBitVector): Rationalize invariants. 'vector != null' implies
4733 that we have our own copy of the bitvector. Otherwise,
4734 'InheritsFrom == null' implies all inherited bits are true.
4736 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4738 * statement.cs (LocalInfo): Add IsConstant.
4739 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4740 local variable for constants.
4742 2006-05-09 Raja R Harinath <rharinath@novell.com>
4744 * flowanalysis.cs (MyBitVector.Empty): New.
4745 (MyBitVector): Don't allow InheritedFrom to be null.
4746 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4747 (UsageVector, FlowBranching): Update to changes.
4749 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4750 recursion. The 'Parent == null' condition isn't sufficient for
4752 (FlowBranching.AddBreakOrigin): Likewise.
4753 (FlowBranching.AddContinueOrigin): Likewise.
4754 (FlowBranching.AddReturnOrigin): Likewise.
4755 (FlowBranching.StealFinallyClauses): Likewise.
4756 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4757 (FlowBranching.CheckOutParameters): Likewise.
4758 (FlowBranchingToplevel): Terminate all the above recursions here.
4759 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4760 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4762 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4764 (FlowBranchingToplevel): New. Empty for now.
4765 (FlowBranching.MergeTopBlock): Update.
4766 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4767 branching for the anonymous delegate.
4768 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4770 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4771 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4772 information at the start of the merge. Reorganize.
4774 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4776 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4778 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4780 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4781 to newly introduced ctor.
4783 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4784 message to one place.
4785 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4788 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4790 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4792 * ecore.cs (Expression.ResolveAsConstant): Updated.
4794 * statement.cs (ResolveMeta): Updated.
4796 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4798 * cs-parser.jay: __arglist cannot be used in initializer.
4800 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4803 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4806 2006-05-05 Raja R Harinath <rharinath@novell.com>
4808 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4809 (LabeledStatement): Add 'name' parameter.
4810 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4811 (Block.AddLabel): Update to changes.
4812 * cs-parser.jay (labeled_statement): Likewise.
4814 * flowanalysis.cs (BranchingType.Labeled): New.
4815 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4816 (FlowBranchingLabeled): New. Does nothing for now, but will
4817 eventually handle 'goto' flows.
4818 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4819 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4820 that's terminated ...
4821 (Block.Resolve): ... here.
4823 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4824 (UsageVector.MergeFinallyOrigins): Likewise.
4825 (FlowBranching.InTryOrCatch): Likewise.
4826 (FlowBranching.AddFinallyVector): Likewise.
4827 (FlowBranchingException): Update to changes.
4830 * statement.cs (Return.Resolve): Move error checking to ...
4831 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4832 (FlowBranchingException): Handle return origins like break and
4834 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4836 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4839 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4842 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4845 * class.cs (MethodData.Define): Do public accessor check only when method
4846 implements an interface.
4848 2006-05-04 Raja R Harinath <rharinath@novell.com>
4850 Remove special handling of 'break'
4851 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4852 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4853 (UsageVector.Break): Remove.
4854 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4856 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4858 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4859 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4861 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4864 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4865 be the interface member.
4867 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4870 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4871 for emitting small (int) values.
4873 2006-05-03 Raja R Harinath <rharinath@novell.com>
4876 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4877 control-flow passes through the 'finally' after merging-in all the
4878 control-flows from 'try' and the 'catch' clauses.
4880 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4881 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4882 always true at the only non-recursive entry point.
4883 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4884 FlowBranchingBreakable.
4885 (FlowBranchingLoop): Remove.
4886 * statement.cs (Return.DoResolve): Update to changes.
4889 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4890 (FlowBranching.CreateBranching): Handle it: create a
4891 FlowBranchingContinuable.
4892 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4893 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4894 except that it handles the 'continue' command.
4895 (FlowBranching.UsageVector.MergeOrigins): Rename from
4897 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4898 except that it overrides AddContinueOrigin.
4899 (FlowBranchingException): Override AddContinueOrigin, similar to
4901 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4902 Create a new branching around the embedded statement.
4903 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4904 control flow after the embedded statement.
4905 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4907 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4908 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4909 FlowBranchingBreakable.
4910 (FlowBranchingSwitch): Remove.
4913 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4914 error reporting to ...
4915 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4916 Rename from 'AddBreakVector'. Add new location argument. Return
4917 a bool indicating whether the 'break' crosses an unwind-protect.
4918 (FlowBranchingException.AddBreakOrigin): Add.
4919 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4920 flowbranching after updating with the effects of the 'finally'
4922 (FlowBranchingBreakable): New common base class for
4923 FlowBranchingLoop and FlowBranchingSwitch.
4925 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4927 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4929 2006-05-02 Raja R Harinath <rharinath@novell.com>
4931 * statement.cs (Do.Resolve): If the loop is infinite, set the
4933 (While.Resolve, For.Resolve): Set a barrier after the embedded
4934 statement. There's no direct control flow that goes from the end
4935 of the embedded statement to the end of the loop.
4936 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4937 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4938 above ensure that the reachability is correctly computed.
4940 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
4941 (UsageVector.MergeBreakOrigins): If the current path is
4942 unreachable, treat it as if all parameters/locals are initialized.
4943 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
4944 infinite loops before merging-in break origins.
4946 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
4947 (Reachability.Reachable): Split part into ...
4948 (Reachability.Unreachable): ... this. Simplify.
4949 (Reachability.IsUnreachable): Use 'Unreachable' instead.
4951 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
4952 (Reachability.SetThrowsSometimes): Likewise.
4953 (FlowBranchingBlock.MergeTopBlock): Don't compare against
4954 TriState.Always, use corresponding property.
4955 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
4956 (Block.Resolve): Likewise. Remove some redundant checks.
4958 2006-05-02 Raja R Harinath <harinath@gmail.com>
4960 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
4961 (Reachability.Meet): Don't bother checking AlwaysThrows --
4962 barrier is always set.
4963 (FlowBranchingBlock.Merge): Likewise.
4965 2006-05-01 Raja R Harinath <harinath@gmail.com>
4967 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
4968 checks for unreachable.
4970 2006-05-01 Marek Safar <marek.safar@seznam.cz>
4973 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
4975 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
4976 whether field is really assigned.
4978 2006-04-30 Raja R Harinath <harinath@gmail.com>
4980 * flowanalysis.cs (Reachability): Make 4-argument constructor
4982 (Reachability.Meet): Rename from 'And'. Remove static variant.
4983 (Reachability.Always): Rename from the highly misleading
4984 'Reachability.Never'.
4985 (FlowBranching.Merge): Update to changes. Mark an impossible
4986 situation with a 'throw'.
4987 (*): Update to changes.
4989 2006-04-29 Raja R Harinath <harinath@gmail.com>
4991 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
4993 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
4994 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
4995 (*): Update to changes.
4996 * statement.cs: Update to changes.
4998 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5001 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5003 2006-04-28 Raja R Harinath <harinath@gmail.com>
5005 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5008 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5009 argument to two arguments: an usage-vector and a bool. Move call
5010 to FlowBranching.Merge () ...
5011 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5013 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5014 handling of loop and switch reachability to ...
5015 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5017 2006-04-27 Raja R Harinath <harinath@gmail.com>
5019 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5020 handling to FlowBranchingLoop.InLoop.
5021 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5023 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5026 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5027 anonymous method is allowed from AnonymousContainer here.
5029 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5031 2006-04-24 Raja R Harinath <rharinath@novell.com>
5034 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5036 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5039 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5040 (DoubleConstant.Reduce): Ditto.
5042 2006-04-23 Raja R Harinath <rharinath@novell.com>
5044 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5045 Remove 'lvalue_right_side' argument. Move parts to ...
5046 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5047 (LocalVariable.DoResolveLValue): ... these.
5049 2006-04-21 Raja R Harinath <rharinath@novell.com>
5052 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5053 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5054 (LocalVariableReference.DoResolveBase): Use it to implement new
5056 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5057 (Argument.Resolve): Simplify. Move CS1510 check ...
5058 * ecore.cs (Expression.ResolveLValue): ... here.
5059 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5060 (PropertyExpr.DoResolveLValue): Likewise.
5061 (FieldExpr.Report_AssignToReadonly): Likewise.
5062 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5063 LValueMemberAccess or LValueMemberOutAccess on instance depending
5065 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5066 DoResolve as appropriate.
5068 2006-04-20 Raja R Harinath <rharinath@novell.com>
5071 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5072 implicit conversions on 'out' and 'ref' arguments.
5074 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5075 improve clarity. Remove dead code.
5078 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5079 (Catch.Resolve): Resolve VarBlock if it exists.
5081 2006-04-19 Miguel de Icaza <miguel@novell.com>
5083 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5084 twice, this was some residual code, the enumerator was emitted
5085 properly in the two branche of if later.
5087 2006-04-19 Raja R Harinath <rharinath@novell.com>
5089 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5090 cast is never an lvalue.
5091 (Cast.DoResolve, Cast.ResolveRest): Combine.
5092 (Argument.Emit): Simplify slightly. Move 'Expr is
5093 IMemoryLocation' check ...
5094 (Argument.Resolve): ... here.
5095 (Argument.Error_LValueRequired): Remove. Inline into only user.
5097 Simplifications. Fix cs0191-2.cs
5098 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5099 CS1649 and CS1651 to ...
5100 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5101 the actual selection of the error code and message to a lookup
5102 table. Add a dummy return value to simplify callsites.
5103 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5104 readonly fields of other instances of the same type. Move CS0197
5106 * expression.cs (Argument.Resolve): ... here. Simplify code.
5107 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5108 resolution of an out or ref argument. The code simplification
5109 above uses this invariant.
5111 2006-04-18 Raja R Harinath <rharinath@novell.com>
5113 Possibly fix #77752. Fix cs1690-[4-7].cs.
5114 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5115 CheckMarshallByRefAccess. Drop parameter.
5116 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5118 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5120 * report.cs (AllWarnings): Add CS1690.
5121 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5123 (LocalVariableReference.DoResolveBase): Update.
5125 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5127 * class.cs (MethodOrOperator): Moved common parts from method class.
5128 detect obsolete attributes.
5129 (Method.Define): Simplified as it reuses code from base.
5130 (Constructor.ValidAttributeTargets): Fixed issue found during
5132 (Destructor.ValidAttributeTargets): Fixed issue found during
5134 (Operator): Finished refactoring set off by #78020. Operator class is now
5135 ordinary method class.
5137 * anonymous.cs: Updated.
5139 * decl.cs (DeclSpace): Add IsGeneric
5141 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5143 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5145 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5147 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5148 detect obsolete attributes.
5149 (Method.CreateEmitContext): Moved to MethodOrOperator.
5151 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5154 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5155 customized exception to make crash detection easier.
5156 (MethodOrOperator): Started to work on new base class for methods and
5158 (Method): Derives from MethodOrOperator.
5159 (Constructor.Emit): Emits its own attributes.
5160 (AbstractPropertyEventMethod.Emit): Ditto.
5161 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5163 (Operator.Emit): It's temporary more tricky than should be.
5165 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5167 * report.cs (InternalErrorException): Add ctor with inner exception.
5169 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5172 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5175 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5178 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5181 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5183 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5184 attribute is present and Guid not.
5185 (Interface.ApplyAttributeBuilder): Ditto.
5187 * attribute.cs: Add error message.
5189 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5193 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5194 sources (it's composite) so hold them in extra array as they are used in
5195 Emit phase only. It worked in the previous versions by mistake.
5196 (Attribute.Emit): Emit attribute for more owners when exist.
5198 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5199 it has now different behaviour.
5201 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5203 * constant.cs (Constant.IsDefaultInitializer): New method.
5205 * class.cs: Updated.
5207 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5208 re-initialize default values. It saves KBs almost for every assembly.
5209 Thanks Zoltan for the idea.
5210 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5211 (ArrayCreation.DoResolve): Resolve only once.
5212 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5213 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5215 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5217 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5220 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5222 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5223 in an embedded statement too.
5225 2006-04-01 Raja R Harinath <rharinath@novell.com>
5228 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5230 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5234 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5237 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5239 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5241 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5244 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5245 LocalTemporary change.
5247 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5249 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5250 initializers optimization.
5251 (ClassOrStruct.TypeAttr): Moved from modifiers.
5252 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5253 (FieldBase.ResolveInitializer): Resolves initializer.
5254 (FieldBase.HasDefaultInitializer): New property.
5256 * cs-parser.jay: Removed message.
5258 * expression.cs (CompilerGeneratedThis): New specialization.
5260 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5262 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5264 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5266 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5268 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5269 be now EnumConstants only.
5271 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5273 * attribute.cs, driver.cs: Reset more caches.
5275 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5277 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5279 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5281 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5282 for easier reuse. Updated all overrides.
5283 (IntegralConstant): New base class for all integral constants.
5284 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5285 of the constant range, report custom error.
5286 (UIntConstant.Reduce): Fixed uint conversion.
5288 * ecore.cs, literal.cs: Reduce updates.
5290 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5294 * class.cs (Constructor.Define): Removed extra if for default ctors.
5295 A patch from Atsushi Enomoto.
5297 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5299 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5300 GetAttributableValue.
5302 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5305 * convert.cs (ImplicitConversionRequired): Error message moved to
5308 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5309 automatic implicit conversion of an output value.
5310 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5312 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5314 (TypeOf.GetAttributableValue): Add extra handling for object type.
5316 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5317 special error message.
5319 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5321 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5323 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5324 compatible with MS runtime.
5326 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5328 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5329 attribute arguments here.
5331 * class.cs (Indexer.Define): The check was moved to attribute class.
5333 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5335 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5336 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5339 2006-03-22 Raja R Harinath <rharinath@novell.com>
5341 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5342 mcs to keep code differences small.
5343 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5344 * typemanager.cs (parameter_default_value_attribute_type): New.
5345 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5348 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5350 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5352 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5354 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5356 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5359 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5361 * doc-bootstrap.cs : fix build.
5363 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5365 * expression.cs (StringConcat.Append): Issue a warning when empty string
5368 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5370 * assign.cs (CompoundAssign.ResolveSource): Removed.
5372 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5375 * class.cs (TypeContainer.FindMethods): Removed.
5376 (TypeContainer.CheckMemberUsage): Made static.
5378 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5380 * constant.cs (CheckRange): Removed unused type argument.
5381 (CheckUnsigned): Removed unused type argument.
5383 * cs-parser.jay: Updated after MemberAccess clean up.
5384 Uses Length for empty string test.
5386 * cs-tokenizer.cs: Uses Length for empty string test.
5387 (IsCastToken): Made static.
5388 (is_hex): Made static.
5389 (real_type_suffix): Made static.
5391 * decl.cs (SetupCache): Made static.
5392 (OnGenerateDocComment): Removed unused ds argument.
5394 * delegate.cs (VerifyDelegate): Removed unused argument.
5396 * doc.cs: Uses Length for empty string test.
5398 * driver.cs: Uses Length for empty string test.
5400 * enum.cs (IsValidEnumType): Made static
5402 * expression.cs (EnumLiftUp): Removed unused argument.
5403 (ResolveMethodGroup): Ditto.
5404 (BetterConversion): Ditto.
5405 (GetVarargsTypes): Ditto.
5406 (UpdateIndices): Ditto.
5407 (ValidateInitializers): Ditto.
5408 (MemberAccess.ctor): Ditto.
5409 (GetIndexersForType): Ditto.
5411 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5413 * iterators.cs: Updated after MemberAccess clean up.
5415 * location.cs: Uses Length for empty string test.
5417 * namespace.cs: Uses Length for empty string test.
5419 * report.cs (CheckWarningCode): Made static.
5421 * statement.cs (LabeledStatement): Removed unused argument.
5423 * typemanager.cs (FilterNone): Removed.
5425 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5427 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5430 * class.cs: Updated.
5432 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5434 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5436 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5440 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5441 reporting, it's more tricky than I thought.
5443 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5447 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5449 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5450 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5451 Add more error reporting; Fixed issue with params.
5453 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5455 * cs-parser.jay: AnonymousMethod requires host container.
5457 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5459 2006-03-18 Raja R Harinath <harinath@gmail.com>
5461 * class.cs: Change 'TypeContainer ds' constructor argument to
5462 'DeclSpace parent'. Some classes were missed below due to
5463 different naming convention.
5465 * class.cs (MemberCore.Parent): Delete. This makes the
5466 ParentContainer changes below enforceable by the compiler.
5468 Treat pointers to enclosing declaration space as 'DeclSpace', not
5470 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5471 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5473 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5475 (Block.AddThisVariable): Likewise.
5476 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5477 (AbstractPropertyEventMethod.Emit): Likewise.
5478 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5479 (GetMethod.Define, SetMethod.Define): Likewise.
5480 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5481 (DelegateMethod.EmitMethod): Likewise.
5483 Fix regression test-partial-13.cs.
5484 Rationalize use of PartialContainer. Ensure that the partial
5485 class semantics can be tied to type-correctness, i.e., any
5486 violation will cause a compile error.
5487 * class.cs, const.cs: Access all fields that belong to class
5488 TypeContainer via ParentContainer. Arguments of EmitContexts and
5489 Resolve()-like functions still use 'Parent'.
5491 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5492 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5493 (PropertyMethod.CheckModifiers): Remove unused argument.
5494 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5497 2006-03-17 Raja R Harinath <harinath@gmail.com>
5499 Make semantics of PartialContainer simpler.
5500 * decl.cs (DeclSpace.IsPartial): Remove.
5501 * class.cs (TypeContainer.IsPartial): Likewise.
5502 (TypeContainer..ctor): Set PartialContainer to point to self.
5503 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5504 (TypeContainer.FindNestedType): Likewise.
5505 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5507 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5509 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5511 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5513 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5516 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5518 * class.cs (Operator.Define): An error for base conversion was not
5521 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5523 * iterator.cs : yield break is allowed in try statement which has
5524 catch clauses. Fixed bug #77767.
5526 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5528 A fix for #77593, #77574.
5530 * class.cs (MethodCore.CheckBase): Another if for operator.
5532 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5534 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5537 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5538 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5541 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5544 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5545 Updated after another emitcontext usage was clean up. It should help us to
5546 synchronize with gmcs easier.
5548 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5552 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5553 (Event.Define): ditto
5554 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5556 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5557 Removed redundant code and set NewSlot for Invoke method too.
5559 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5560 (Parameters.MergeGenerated): New method. Use this method when you merge
5561 compiler generated argument with user arguments.
5563 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5565 * attribute.cs (ResolveAsTypeTerminal): Removed.
5567 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5568 specialization for predefined types; 30% speed up.
5569 Finally placed obsolete check to right place.
5570 (Expression.ResolveType): Removed.
5572 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5573 Updated after ResolveType was removed.
5575 * expression.cs (Cast.ctor): Check void cast.
5576 (Binary.ResolveAsTypeTerminal): Is never type.
5577 (Conditional.ResolveAsTypeTerminal): Is never type.
5579 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5581 2006-03-01 Raja R Harinath <rharinath@novell.com>
5584 * expression.cs (ParameterReference.DoResolveBase): Change return
5586 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5590 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5593 * typemanager.cs (GetFullNameSignature): Don't nullref on
5594 protected accessors.
5596 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5598 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5599 these two separated members to simplify the code.
5600 (Attribute.Resolve): Refactored to use new fields and methods.
5601 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5602 implemented obsolete attribute checking.
5603 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5604 implemented obsolete checking again. It look line never ending quest ;-)
5605 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5607 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5609 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5611 *class.cs (Property.Define): Add RegisterProperty call.
5613 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5614 argument groups (only 2).
5616 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5617 encoding expression to arguments.
5618 (Expression.ExprClassToResolveFlags): Just turned to property.
5620 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5621 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5622 optimized as well as implemented support for zero-length attributes.
5624 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5625 Add caching of PropertyInfo's.
5627 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5629 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5630 error multiple times.
5632 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5634 New partial class implementation.
5635 A fix for #77027, #77029, #77403
5637 * attribute.cs (Attributable): Made attributes protected.
5639 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5640 the replacements of ClassPart and PartialContainer.
5641 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5642 (TypeContainer.AddInterface): Ditto.
5643 (TypeContainer.AddPartial): The main method for partial classes. It checks
5644 for errors and merges ModFlags and attributes. At the end class is added to
5646 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5648 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5649 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5650 from the rest of partial classes.
5651 (TypeContainer.GetClassBases): Simplified.
5652 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5654 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5655 (TypeContainer.HasExplicitLayout): Uses Flags now.
5656 (PartialContainer): Removed.
5657 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5658 (StaticClass): Was merged with Class.
5659 (Class.GetClassBases): class and static class bases are verified here.
5660 (Class.TypeAttr): Added static attributes when class is static.
5661 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5662 (MemberBase): In some cases we need to call parent container for partial
5663 class. It should be eliminated but it's not easy now.
5665 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5667 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5668 partial classed to accumulate class comments.
5669 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5671 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5673 * driver.cs (MainDriver): Tree.GetDecl was removed.
5675 * modifiers.cs (Modifiers): Add partial modifier.
5677 * tree.cs (Tree.decl): Removed.
5678 (RootTypes): Started to use this class more often for root types
5681 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5685 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5686 external interface does not have an attribute.
5688 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5690 Another prerequisites for new partial classs implementation.
5692 * attribute.cs (Attribute.Equal): Implemented.
5693 (Attribute.Emit): Changed as attributes can be applied more than twice.
5694 (Attributes.Emit): Check for duplicate attributes here.
5696 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5697 as a parameter, clean-up.
5699 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5703 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5704 contains obsolete attribute check which can in some cases look for base
5705 type of current class which is not initialized yet.
5706 (TypeContainer.BaseType): Replacement of ptype.
5708 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5710 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5712 First of prerequisites for new partial classs implemention.
5714 * attribute.cs (Attributable): Extended by ResolveContext;
5715 Attributes finally have correct context for resolving in all cases.
5716 (AttachTo): Attribute owner is assigned here.
5718 * codegen.cs (IResolveContext): Introduce new interface to hold
5719 all information needed in resolving phase.
5720 (EmitContext): Implements IResolveContext; more clean-up needed here.
5722 * decl.cs (MemberCore): Implemented IResolveContext.
5724 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5725 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5726 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5727 Refactored to use new IResolveContext instead of EmitContext; cleanup
5729 2006-02-06 Miguel de Icaza <miguel@novell.com>
5731 * codegen.cs (EmitScopeInitFromBlock): check here the
5732 capture_context, there is no need to make two calls to the
5735 * anonymous.cs: Add some debugging messages that might help me
5736 track other instances of this problem in the future (the
5737 regression of test 467).
5739 * cs-parser.jay: track the variable block, as we need to initalize
5740 any captured variables declared in this block for the "catch"
5741 portion of the "Try" statement.
5743 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5744 scope initialization for captured variables.
5746 Also, move the emit for the variables after the block location has
5749 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5751 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5753 2006-02-02 Miguel de Icaza <miguel@novell.com>
5755 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5756 commit yesterday, the initialization for the roots is necessary.
5757 What is not necessary is the scope activation.
5759 2006-02-02 Raja R Harinath <rharinath@novell.com>
5761 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5762 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5764 (Argument.Resolve): Remove CS0206 checks.
5766 2006-02-01 Miguel de Icaza <miguel@novell.com>
5768 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5769 scopes for all the roots, the scopes will now be emitted when the
5770 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5772 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5773 code. This reduces a lot of existing cruft.
5775 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5776 that the ScopeInfo is generated as we enter the scope, not at the
5777 time of use, which is what we used to do before.
5779 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5780 every time a Block is about to be emitted if we have a
5783 2006-02-01 Raja R Harinath <rharinath@novell.com>
5785 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5787 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5789 * typemanager.cs (cons_param_array_attribute): Make private.
5790 (Reset): Set it to null.
5791 (InitCoreHelpers): Don't initialize it.
5792 (ConsParamArrayAttribute): New. Initialize it as needed.
5793 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5795 2006-01-31 Miguel de Icaza <miguel@novell.com>
5797 * expression.cs: There might be errors reported during the
5798 selection of applicable methods. If there are errors, do not
5799 continue execution as it will lead the compiler to crash.
5801 2006-01-30 Miguel de Icaza <miguel@novell.com>
5803 * expression.cs: Member access is not allowed on anonymous
5804 methods. Fixes #77402.
5806 2006-01-30 Raja R Harinath <rharinath@novell.com>
5809 * cs-parser.jay (VariableDeclaration): Don't set
5810 current_array_type to null.
5811 (field_declaration, event_declaration, declaration_statement):
5812 Set it to null here.
5814 2006-01-28 Raja R Harinath <harinath@gmail.com>
5816 * typemanager.cs (GenericParameterPosition): New.
5819 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5821 * doc.cs : To process "include" elements, first we should create
5822 another list than XmlNodeList, because it could result in node
5823 removal, which could result in that the XmlNodeList gives up
5826 (Also made code identical to gmcs again.)
5828 2006-01-25 Miguel de Icaza <miguel@novell.com>
5830 * ecore.cs: Introduce an error report that we were not catching
5831 before, if not silent, we must report the error. Gonzalo ran into
5834 2006-01-23 Miguel de Icaza <miguel@novell.com>
5836 A fix for bug: #76957
5838 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5839 ComputeMethodHost before creating the method, this is a new
5842 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5843 that this method references (RegisterScope). The actual scope
5844 where the method is hosted is computed with the ComputeMethodHost
5845 before we create the method.
5847 Moved the Deepest routine here.
5849 (AnonymousContainer.ComputeMethodHost): New routine used to
5850 compute the proper ScopeInfo that will host the anonymous method.
5852 (ScopeInfo): Deal with multiple roots. The problem was that we
5853 did not have a unique root where all ScopeInfos could be hanged
5854 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5857 Remove AdjustMethodScope which is now computed at the end. Remove
5858 LinkScope which did a partial link, instead link all ScopeInfos
5859 before code generation from the new "LinkScopes" routine.
5861 Simplify all the Add* routines as they no longer need to maintain
5862 the tree, they just need to record that they are using variables
5865 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5866 routines to produce the forest of ScopeInfo trees.
5868 * class.cs (TypeContainer.AppendMethod): This is just like
5869 AddMethod, but ensures that an interface implementation method
5870 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5871 methods, but at the end.
5873 We use this functionality to ensure that the generated MoveNext
5874 method in the iterator class is resolved/emitted before the
5875 enumerator methods created.
5877 This is required because the MoveNext method computes the right
5878 ScopeInfo for the method. And the other methods will eventually
5879 need to resolve and fetch information computed from the anonymous
5882 2006-01-21 Raja R Harinath <harinath@gmail.com>
5883 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5886 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5888 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5889 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5891 2006-01-18 Raja R Harinath <rharinath@novell.com>
5893 Fix #76656, cs0231-2.cs.
5894 * cs-parser.jay (formal_parameter_list): Make error case catch
5896 (parenthesized_expression_0): Add CS1026 check.
5897 (invocation_expression): Remove unused { $$ = lexer.Location }.
5899 2006-01-17 Raja R Harinath <rharinath@novell.com>
5902 * cs-parser.jay (statement_expression): Don't list out the
5903 individual statement-expressions. Convert syntax error into
5906 2006-01-16 Raja R Harinath <rharinath@novell.com>
5909 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5910 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5911 CheckIntermediateModification.
5912 (FieldExpr.DoResolve): Add new two-argument version that
5913 allows us to resolve the InstanceExpression as an lvalue.
5914 The one-argument variant is now just a wrapper.
5915 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5916 Resolve the lhs as an lvalue if the it has a value type.
5917 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5918 from Assign.DoResolve.
5919 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5920 resolved as an lvalue.
5921 (PropertyExpr.DoResolve): Update.
5922 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5923 has a value type. Move CS1612 check here from
5924 CheckIntermediateModification.
5925 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5926 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5927 'right_side' of a ResolveLValue on an 'out' argument.
5928 (EmptyExpression.LValueMemberAccess): New. Used as the
5929 'right_side' of a propagated ResolveLValue on a value type.
5930 (LocalVariableReference.DoResolveBase): Recognize
5931 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5933 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5934 EmptyExpression.Null.
5936 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5938 * typemanager.cs : added IsGenericParameter(). In mcs it always
5940 * doc.cs : for generic parameters, use GenericParameterPosition,
5943 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
5945 * expression.cs: Fix Console.WriteLine ((this = x).foo);
5947 2006-01-12 Miguel de Icaza <miguel@novell.com>
5949 This fixes the problem where we used ldfld instead of ldflda to
5950 load the "THIS" pointer on captured parameters, when THIS is a
5951 value type. See bug #77205.
5953 * iterators.cs (CapturedThisReference.Emit): Pass false to
5954 EmitThis (we do not need the address).
5956 * codegen.cs (EmitThis): it needs to know whether we need the
5957 address of `this' or not. This is used by value types.
5959 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
5960 every other call passes false.
5962 2006-01-12 Raja R Harinath <rharinath@novell.com>
5965 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
5967 * expression.cs (Invocation.OverloadResolve): Update.
5968 (Invocation.DoResolve): Avoid double resolution of invocation.
5970 2006-01-11 Raja R Harinath <rharinath@novell.com>
5973 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
5974 unary negation of floating point types as 0-expr; negation cannot
5975 overflow in floating point types.
5978 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
5979 on operands of 'void' type.
5982 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
5983 and ExclusiveOr for boolean constants too.
5985 2006-01-09 Raja R Harinath <rharinath@novell.com>
5988 * expression.cs (Invocation.OverloadResolve): Replace reflected
5989 override methods with their base virtual methods, rather than
5991 * typemanager.cs (TypeManager.GetOverride): New.
5993 2006-01-05 Jb Evain <jbevain@gmail.com>
5995 * class.cs (Property.Define, Indexer.Define): do not tag the
5996 properties as SpecialName | RTSpecialName.
5998 2006-01-04 Miguel de Icaza <miguel@novell.com>
6000 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6001 doing a low-level comparission of parameter types. It was lacking
6002 a check for __argslist.
6004 2005-12-30 Miguel de Icaza <miguel@novell.com>
6006 * expression.cs (ParameterReference.DoResolveBase): Allow
6007 reference parameters if they are local to this block.
6009 This allows the ref and out parameters of a delegate to be used in
6010 an anonymous method, for example:
6012 delegate void set (out int x);
6014 set s = delegate (out int x){
6018 This is used by functionality introduced late in the C# language.
6020 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6021 method that take ref and out parameters.
6023 Fixes #77119 which was a late change in the spec.
6025 2005-12-23 Miguel de Icaza <miguel@novell.com>
6027 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6028 parent if its the same scope. Fixes #77060.
6030 2005-12-21 Miguel de Icaza <miguel@novell.com>
6032 * driver.cs: Report the case of no source files and no -out:
6035 2005-12-20 Raja R Harinath <rharinath@novell.com>
6038 * expression.cs (ComposedCast.GetSignatureForError): Define.
6040 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6044 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6045 ListDictionary, to contain the ExternAliasEntry entries (in
6046 addition to the NamespaceEntry.aliases hashtable). This field is
6047 shared between the original entry and its doppelganger (bodyless
6049 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6050 extern_aliases field.
6051 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6052 lookup in extern_aliases.
6054 2005-12-16 Raja R Harinath <rharinath@novell.com>
6057 * class.cs (TypeContainer.Mark_HasEquals): New.
6058 (TypeContainer.Mark_HasGetHashCode): New.
6059 (ClassPart): Override them.
6060 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6063 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6064 'parent' argument to the base constructor.
6066 Remove all mention of TypeContainer from decl.cs.
6067 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6068 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6069 (DeclSpace.DeclSpace): Likewise.
6070 (DeclSpace.DefineMembers): Remove unused argument.
6071 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6072 debugging check -- we don't care if the debug code throws an
6073 InvalidCastException instead of an InternalErrorException.
6074 * class.cs (TypeContainer.DefineMembers): Update to changes.
6075 (TypeContainer.DoDefineMembers): Likewise.
6076 (TypeContainer.GetMethods): Likewise.
6077 (PropertyMember.Define): Likewise.
6078 (MemberBase.Parent): New property that forwards to
6079 MemberCore.Parent, but ensures that we get a TypeContainer.
6080 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6081 (RootContext.PopulateTypes): Likewise. Remove special case code
6082 for !RootContext.StdLib: DefineMembers is idempotent.
6084 2005-12-14 Miguel de Icaza <miguel@novell.com>
6086 * convert.cs (ExplicitConversionCore): Check the return value from
6087 ExplicitConversionCore which can return null on failure. Fixes #76914
6089 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6091 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6093 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6095 * doc.cs : The search for referenced namespace was insufficient to
6096 get global one as it used to do. Fixed bug #76965.
6098 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6100 * doc.cs : check name in cref in the last phase that whether it is
6103 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6105 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6108 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6110 * doc.cs : so it turned out that we cannot skip override check for
6111 interface members. Fixed bug #76954.
6113 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6115 * cs-tokenizer.cs : fixed bug #75984:
6116 - #warning and #error should not be handled when the source line
6118 - #line is not checked strictly when the source line is disabled.
6119 - #define and #undef is on the other hand checked strictly at any
6122 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6124 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6127 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6129 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6131 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6133 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6134 (FieldBase.Initializer): Initializer is now optional.
6135 (EventField.Define): Only event field can have initializer.
6137 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6139 * const.cs (Const): Reuse initializer.
6141 * cs-parser.jay: Updated after FieldBase changes.
6142 Added current_array_type to simplify array initializers.
6144 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6146 * expression.cs, iterators.cs: Updated.
6148 * namespace.cs (NamespaceEntry): Made UsingFound private.
6150 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6152 * parameterCollection.cs: Obsolete, removed.
6153 * parser.cs: Obsolete, removed.
6155 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6158 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6160 * enum.cs (Enum.Define): Set obsolete context here.
6162 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6165 - FindDocumentedMember() now expects 1) paramList as null
6166 when "we don't have to check the number of parameters" and
6167 2) Type.EmptyTypes when "there is no arguments".
6168 - Introduced FoundMember struct to hold the exact type which was
6169 used to find the documented member (the above change broke
6170 test-xml-044; it might be better just to use DeclaringType than
6171 what MS does, like this change does, but it depends on usage.)
6173 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6175 * doc.cs : documented member might be from DeclaringType for nested
6176 types. Fixed bug #76782.
6178 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6180 * anonymous.cs: Have the param code handle leaving copies on the
6181 stack etc. Allows anonymous params to take part in the assignment
6182 code (++, +=, etc). Fixes bug #76550
6184 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6185 it down to the anon code.
6187 * iterators.cs: Use dummy var here
6189 * codegen.cs: Handle new vars
6191 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6194 * class.cs (MethodData.Define): Set proper Obsolete context.
6196 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6198 (FieldExpr.DoResolve): Ditto.
6200 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6203 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6204 parent is not obsolete.
6206 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6208 * doc.cs : (FindDocumentedMember) find parameterless members first
6209 and get CS0419 in the early stage. Fixed first case of bug #76727.
6211 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6214 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6215 no error was reported.
6217 *expression.cs (Binary.DoResolve): left can be null.
6219 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6222 * class.cs (MethodData.Emit): Parameters should be labeled first.
6224 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6227 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6229 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6231 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6233 * class.cs (MethodCore): Parameter clean up.
6234 (IMethodData): Added ParameterInfo.
6235 (MethodData): Parameter clean up.
6236 (Indexer.Define): Parameter clean up.
6248 * typemanager.cs: Parameter clean up.
6250 * delegate.cs (Define): Get rid of duplicated code.
6252 * expression.cs (ParameterReference): Removed useless parameters
6254 (Invocation): Ditto.
6256 * parameter.cs (ParamsParameter): New class, params specialization.
6257 (ArglistParameter): Attemp to separate arglist.
6258 (Parameter): Refactored to be reusable and faster.
6259 (Parameter.Modifier): Made understandable.
6260 (Parameters): Changed to be used as a class for `this' assembly
6261 parameters. Refactored to use new specialized classes.
6263 * support.cs (ParameterData): Added Types property.
6264 (InternalParameters): Deleted.
6266 2005-08-20 Martin Baulig <martin@ximian.com>
6268 Merging this patch from GMCS to fix #75867.
6270 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6271 scope if we don't already have it.
6273 2005-11-17 Martin Baulig <martin@ximian.com>
6276 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6277 inherit the scope from our parent. Fixes #76653.
6279 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6281 * doc.cs : the previous patch does not actually fix the bug.
6282 PropertyInfo override check is now implemented and really fixed it.
6283 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6285 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6287 * doc.cs : apply "override filter" also to properties.
6290 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6292 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6293 no need to check overrides. For classes, omit those results from
6294 interfaces since they must exist in the class. Fixed bug #76726.
6296 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6298 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6299 with different parameters. Fixed the second problem in #76685.
6301 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6303 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6304 get expected 'protected' access in CheckValidFamilyAccess()).
6307 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6309 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6310 Fixed bug #76705. CS1569 was incorrectly commented out.
6312 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6314 * doc.cs : use Invocation.IsOverride() to do real override check.
6315 * expression.cs : made Invocation.IsOverride() internal.
6317 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6319 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6320 TypeBuilder.FindMembers() and filter overriden base members out.
6323 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6325 * doc.cs : ref/out parameters are represented as '@' (instead of
6326 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6328 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6330 * doc.cs : when there was no '.' in cref to methods in doc comment,
6331 then parameters were missing in the output. Fixed bug #76691.
6333 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6335 * driver.cs : don't output docs when there is an error.
6338 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6341 Now it should detect indexers. Fixed primary concern in bug #76685.
6342 Fixed CS0419 message to not show the identical member signature in
6345 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6347 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6348 instead of Type.FindMembers() since it does not handle events.
6351 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6353 * codegen.cs: Fixed typo (speficied -> specified).
6355 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6358 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6360 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6362 * attribute.cs: Changed error message.
6364 * cs-tokenizer.cs: One more check.
6366 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6368 * statement.cs (Block.Resolve): Ignore empty statement.
6370 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6372 * report.cs: Made error/warning methods more strict to avoid
6375 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6376 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6377 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6378 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6380 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6382 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6383 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6385 * class.cs (TypeContainer.IsComImport): New property.
6386 (Constructor.Define): Create proper ctor for ComImport types.
6388 * expression.cs (New.CheckComImport): Fixed.
6390 2005-11-07 Miguel de Icaza <miguel@novell.com>
6392 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6393 that a parameter has been captured does not mean that we do not
6394 have to do the rest of the processing. This fixes the second part
6395 of #76592. If there was another anonymous method capturing
6396 values in the past, the Scope would never be set for the second
6397 method that captured the same parameter.
6399 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6400 properly manipulate the stack. Second part of fix for #76592.
6402 * expression.cs (New): Add support for invoking "new" on
6403 interfaces that have been flagged with the ComImport attribute and
6404 the CoClass. Fixes #76637
6406 * statement.cs (Try.DoEmit): When a variable is captured, do not
6407 try to emit the vi.LocalBuilder variable as it has been captured.
6408 Create a temporary variable and store the results on the
6409 FieldBuilder. Fixes #76642
6411 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6413 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6415 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6417 * expression.cs (Binary.DoResolve): Added && optimalization.
6419 * typemanager.cs (AddUserType): Removed useless argument.
6421 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6423 * statement.cs (Block.variables): Uses ListDictionary.
6425 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6428 * class.cs (PartialContainer.EmitType): Customized to emit
6429 security attributes.
6430 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6431 for partial classes.
6433 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6436 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6437 access has to be fixed.
6439 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6441 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6444 * ecore.cs (NullCast.Reduce): Implemented.
6446 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6449 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6451 (Foreach.Resolve): Catch null properly.
6453 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6455 * cs-tokenizer.cs: Warning text fix.
6457 * driver.cs: AllWarningNumbers exposed on public interface.
6459 * report.cs (): Reviewed warning numbers.
6460 (IsValidWarning): Use binary search.
6462 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6464 * driver.cs: Implemeted resource visibility.
6465 (Resources): New class for code sharing between /res: and
6468 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6471 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6474 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6477 * ecore.cs (NullCast): Child is contant only.
6479 * literal.cs (NullLiteral.Reduce): null can be converted to any
6482 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6484 * driver.cs: Use Encoding.Default as default code page instead
6487 2005-10-27 Raja R Harinath <rharinath@novell.com>
6490 * expression.cs (Invocation.Error_InvalidArguments): Handle
6491 __arglist parameters.
6492 (Invocation.VerifyArgumentsCompat): Likewise.
6493 * support.cs (ReflectionParameters.GetSignatureForError): Print
6494 __arglist parameters.
6495 (InternalParamters.GetSignatureForError): Likewise.
6496 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6498 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6500 * attribute.cs (GetPropertyValue): Made public.
6502 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6504 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6506 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6509 * driver.cs: Reflect method name change.
6511 * statement.cs (Try.Resolve): Warn when try has both general
6514 * typemanager.cs: runtime_compatibility_attr_type new predefined
6517 2005-10-26 Raja R Harinath <harinath@gmail.com>
6520 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6521 treat it as an empty parameter list.
6523 2005-10-26 Raja R Harinath <rharinath@novell.com>
6526 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6527 ResolveAsTypeStep silent.
6528 * statement.cs (Block.AddConstant): Mark block as used.
6529 (Block.ResolveMeta): Avoid piling on error messages
6530 if a constant initializer resolution fails.
6532 2005-10-25 Raja R Harinath <rharinath@novell.com>
6534 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6536 (NamespaceEntry.VerifyAllUsing): New.
6537 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6538 behaviour. Delegates actual resolution of alias to ...
6539 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6540 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6542 * driver.cs (Driver.MainDriver): Update.
6544 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6545 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6547 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6549 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6550 RootNamespace.DefineNamespacesForAll.
6552 2005-10-24 Raja R Harinath <harinath@gmail.com>
6554 * typemanager.cs (assemblies, external_aliases, modules)
6555 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6556 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6557 overhead. Move resposibility ...
6558 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6559 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6561 2005-10-23 Raja R Harinath <harinath@gmail.com>
6563 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6564 cached_namespaces. Improve usage.
6565 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6566 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6567 Move from GlobalRootNamespace and simplify.
6568 (RootNamespace.Global): Make instance variable.
6569 (RootNamespace.RootNamespace): Add "alias name" parameter.
6570 (GlobalRootNamespace): Simplify drastically.
6571 (Namespace.Lookup): Don't use GetNamespace.
6572 * typemanager.cs (GetRootNamespace): Rename from
6573 ComputeNamespaceForAlias.
6574 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6576 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6578 * anonymous.cs (AnonymousContainer): Don't crash when container
6581 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6583 * expression.cs (Binary.DoResolve): Warn when comparing same
6586 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6589 * expression.cs (Binary.DoResolve): It looks like there are no
6590 convetsion rules in enum context.
6592 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6594 Add support for extern alias qualifiers.
6595 * typemanager.cs: Move some LookupTypeReflection code
6596 to namespace.cs, to have cleaner code. Added some methods
6597 to help us keep track of the extern aliased references.
6598 * driver.cs: Add suport for extern alias assemblies on command
6599 line and check for their warnings/errors. Also keep track of the
6600 extern aliased assemblies.
6601 * namespace.cs: Move the global functionality of Namespace
6602 to GlobalRootNamespace/RootNamespace. Now the global namespace
6603 is GlobalRootNamespace.Globa. Also the code moved from
6604 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6605 Finally added LocalAliasEntry (AliasEntry before) and
6606 ExternAliasEntry, to handle alias statements.
6607 * cs-parser.jay: Add support in the grammar for extern alias
6609 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6610 Update callings to Namespace (now in GlobalRootNamespace).
6612 2005-10-18 Raja R Harinath <rharinath@novell.com>
6615 * class.cs (TypeContainer.DefineType): Move updating of
6616 topological sort earlier in the code.
6617 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6619 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6622 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6624 * constant.cs (Constant.TryReduce): Moved from Cast class.
6625 (Reduce): Made little bit more OO and fixed missing conversions.
6627 * ecore.cs (Reduce): Implemented.
6628 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6630 * literal.cs (Reduce): Implemented.
6632 * class.cs: Reverted Miguel's wrong commit.
6634 2005-10-14 Miguel de Icaza <miguel@novell.com>
6636 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6638 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6640 * cs-parser.jay, expression.cs : CS0214 was missing error location
6641 for constants. Fixed bug #76404.
6643 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6646 * convert.cs (ExplicitConversionCore): Fixed object->enum
6649 2005-10-10 Raja R Harinath <rharinath@novell.com>
6651 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6653 (PropertyExpr.EmitCall): Likewise.
6654 * expression.cs (Invocation.EmitArguments): Handle case where
6656 (Invocation.EmitCall): Avoid allocating temporary variable if
6657 there are no arguments.
6659 2005-10-07 Raja R Harinath <rharinath@novell.com>
6662 * convert.cs (ImplicitConversionStandard): Move conversion of
6663 void* to arbitrary pointer types ...
6664 (ExplicitConversionStandard): .. here.
6665 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6666 error to always print typenames.
6668 2005-10-07 Raja R Harinath <rharinath@novell.com>
6670 * convert.cs (GetConversionOperator): Rename from
6671 GetConversionOperators. Move operator selection code from ...
6672 (UserDefinedConversion): ... here.
6674 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6676 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6679 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6681 * assign.cs (Assign.DoResolve): Error method changed.
6683 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6685 * const.cs (ResolveValue): Reset in_transit immediately.
6687 * constant.cs: Error method changed.
6689 * convert.cs: Removed useless location parameter.
6690 (ExplicitNumericConversion): Don't do double enum check.
6691 (ExplicitConversionCore): Renamed from ExplicitConversion.
6692 (ExplicitUnsafe): Extracted from ExplicitConversion.
6693 (ExplicitConversion): Uses for error reporting.
6695 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6697 (ResolveBoolean): Uses common error method.
6698 (CastToDecimal): Get rid of ec.
6699 (CastFromDecimal): Optimized.
6700 (ConvCast): Get rid of ec.
6702 * enum.cs (ResolveValue): Reset in_transit immediately.
6703 (Emit): Return after first error.
6705 * expression.cs: Convert changes.
6707 * literal.cs: Error method changed.
6709 * statement.cs: Error method changed.
6711 2005-10-03 Raja R Harinath <rharinath@novell.com>
6713 * support.cs (SeekableStreamReader.Position): Don't error out when
6714 the requested position is just beyond the end of the current
6717 2005-09-28 Raja R Harinath <rharinath@novell.com>
6719 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6720 try to keep in sync with the byte count of the underlying Stream.
6721 However, this limits us to a window size of 2048 characters: i.e.,
6722 the maximum lookahead of our lexer/parser can be 2048 characters.
6724 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6727 * driver.cs: Fix compilation files with full root path.
6729 2005-09-25 Miguel de Icaza <miguel@novell.com>
6731 * report.cs (SymbolRelatedToPreviousError): Format the output so
6732 it does not use an open parenthesis that is never closed.
6734 * driver.cs: Follow coding guidelines
6736 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6739 * const.cs (Const.ResolveValue): Check for assigning non-null
6740 value to reference type.
6742 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6744 * anonymous.cs: Implemented ExprClassName.
6746 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6749 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6752 * class.cs (StaticClass.DefineContainerMembers): Report protected
6755 * codegen.cs: if(ed) PRODUCTION.
6757 * convert.cs (Error_CannotImplicitConversion): Better error
6760 * cs-parser.jay: More error checks.
6762 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6764 * driver.cs (CSCParseOption): Enabled wrong option check.
6766 * ecore.cs (Expression.ExprClassName): Turned to property.
6767 (MemberExpr.CheckIntermediateModification): For checking boxed
6768 value types modification.
6770 * statement.cs (Fixed.Resolve): Expression type must be
6771 convertible to fixed type.
6772 (CollectionForeach.GetEnumeratorFilter,TryType):
6773 Small refactoring for easier error checking.
6775 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6777 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6780 * class.cs (GeneratedBaseInitializer): New class for customization
6781 compiler generated initializers.
6782 (MemberBase.DoDefine): Check Obsolete attribute here.
6783 (FieldMember.DoDefine): Ditto.
6785 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6788 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6789 (MemberCore.GetObsoleteAttribute): Removed argument.
6790 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6791 (MemberCore.CheckObsoleteType): New helper.
6795 * statement.cs: Updates after MemberCore changes.
6797 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6798 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6800 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6801 obsolete attribute for compiler construct.
6802 (As.DoResolve): Cache result.
6804 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6806 2005-09-26 Raja R Harinath <rharinath@novell.com>
6809 * expression.cs (This.VerifyFixed): In a value type T, the type of
6810 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6811 value type R, 'this' is treated as a value parameter.
6813 2005-09-22 Miguel de Icaza <miguel@novell.com>
6815 * statement.cs (Lock): Use the TemporaryVariable class instead of
6816 manually using local variables as those do not work when variables
6819 * ecore.cs: Moved the TemporaryVariable class from being a nested
6820 class inside Foreach to be a public class that can be employed in
6823 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6825 * cs-parser.jay: interface_accessors replaced by
6826 accessor_declarations.
6828 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6831 * statement.cs (GotoCase.Resolve): Convert null constant to
6833 (SwitchLabel.ResolveAndReduce): Ditto.
6834 (SwitchLabel.NullStringCase): Custom null stamp.
6835 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6837 typemanager.cs (CSharpSignature): Don't skip first argument
6840 2005-09-18 Miguel de Icaza <miguel@novell.com>
6842 * driver.cs: Set InEmacs based on the environment variable EMACS.
6844 * location.cs (InEmacs): in this mode, do not report column
6845 location as it confuses Emacs.
6847 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6849 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6850 expression.cs, iterators.cs, literal.cs: Store constants and
6853 * class.cs (MemberBase.ShortName): Pass location.
6855 * cs-parser.jay: Some location fixes.
6857 * ecore.cs (Expression.Location): Made virtual.
6859 2005-09-05 Miguel de Icaza <miguel@novell.com>
6861 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6862 if the underlying types are the same, otherwise we need to produce
6863 code that will do the proper cast.
6865 This was exposed by Marek's constant rewrite which produced
6866 invalid code for the call site:
6869 void Method (X v) {}
6873 This fixes test-49.cs
6875 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6877 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6878 Type/Object should be allowed as well. Fixed bug #75968.
6880 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6882 * expression.cs : (Binary.DoResolve): when one is enum constant and
6883 another is constant 0, then return enum one *as enum type*.
6886 2005-09-02 Raja R Harinath <rharinath@novell.com>
6888 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6892 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6893 flow-branching for LocalVariableReferences in case we were invoked
6894 from a MemberAccess.
6895 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6897 (LocalVariableReference.DoResolveBase): ... this.
6898 (MemberAccess.Resolve): Do the check that was disabled during
6901 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6904 (PartialContainer.Create): check abstract/sealed/static strictly
6905 but abstract/sealed can exist only at one side. Fixed bug #75883.
6907 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6910 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6911 specified, don't default to UnmanagedType.I4.
6913 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6915 * expression.cs : conditional operator should check possibly
6916 incorrect assign expression. Fixed bug #75946.
6918 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6920 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6921 Reverting the change. gmcs is much complex than mcs on this matter.
6923 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6925 * cs-tokenizer.cs : To read another token ahead of the actual
6926 consumption, use new SavedToken and cache token instead of moving
6927 back the stream with SeekableStreamReader (it seemed problematic).
6929 driver.cs : Thus use StreamReader directly.
6930 * support.cs : Thus removed SeekableStreamReader.
6932 2005-08-30 Raja R Harinath <rharinath@novell.com>
6935 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6936 (ScopeInfo.EmitScopeType): Use it to construct field names from
6937 names of captured locals.
6940 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
6941 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
6942 Pass 'target_type' to BoxedCast. Don't default to 'object'.
6943 (ExplicitConversion): Remove enum cases already handled by
6944 implicit conversion. Move implicit conversion check to the beginning.
6945 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
6946 * expression.cs (ArrayCreation.EmitDynamicInitializers):
6947 Don't treat System.Enum as a struct.
6949 2005-08-30 Jb Evain <jbevain@gmail.com>
6951 * attribute.cs: handles as expression in parameters.
6953 2005-08-30 Raja R Harinath <rharinath@novell.com>
6956 * class.cs (TypeContainer.VerifyClsName): Don't use a
6957 PartialContainer when verifying CLS compliance.
6958 (AbstractPropertyEventMethod): Set Parent here, ...
6959 (PropertyMethod): ... not here.
6961 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
6963 * attribute.cs : escaped attribute name should not be allowed to be
6964 resolved (e.g. @class as classAttribute). Fixed bug #75930.
6966 2005-08-29 Raja R Harinath <rharinath@novell.com>
6969 * convert.cs (ImplicitStandardConversionExists): Allow zero also
6970 when converting a long constant to unsigned long.
6971 * expression.cs (Invocation.OverloadResolve): Add sanity check to
6972 detect where IsApplicable and VerifyArgumentsCompat disagree.
6974 2005-08-29 Raja R Harinath <rharinath@novell.com>
6975 and Carlos Alberto Cortez <carlos@unixmexico.org>
6978 * class.cs (TypeContainer.CanElideInitializer): New helper.
6979 (TypeContainer.EmitFieldInitializers): Use it to determine if we
6980 can safely emitting the initializer of a field.
6982 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6984 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
6985 allowed inside a switch (without loop). Fixed bug #75433.
6987 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
6989 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
6990 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
6992 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6994 * driver.cs : kinda reverting the default encoding changes (not exact
6995 revert since I noticed that "codepage:reset" might not work fine).
6997 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6999 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7000 Location. Now getter and setter store location correctly.
7001 (errors/cs0111-12.cs now reports the expected location.)
7003 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7005 * driver.cs : Use default encoding on the environment.
7006 Removed (now that) extra parameter for SeekableStreamReader.
7007 * support.cs : (SeekableStreamReader) third .ctor() argument for
7008 StreamReader is not required (always true). preamble size could
7009 be acquired in simpler and safe way.
7011 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7013 * cs-parser.jay: report CS0642 at warning level 3
7014 and report CS0642 for an if else statement also
7015 fixes bug #74745. Patch by John Luke (and a bit
7017 Removed extra CS0642 warning check for "while",
7019 * statement.cs: In Block.Resolve(), CS0642 check
7020 is reimplemented to check a sequence of an empty
7021 statement and a block.
7023 Both fix bug #66777.
7025 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7027 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7028 detection until I fix it.
7030 * cs-tokenizer.cs: Changed error message.
7032 * cs-parser.jay: Fixed 2 error locations.
7034 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7035 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7038 * enum.cs (GetSignatureForError): Fixed.
7040 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7044 * typemanager.cs (RegisterProperty): Removed.
7046 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7048 2005-08-24 Raja R Harinath <rharinath@novell.com>
7051 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7052 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7054 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7056 * expression.cs : tiny fix is required for not warning positive ulong.
7059 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7061 * expression.cs : add CS0652 check for constant and integral
7062 expression. Fixed bug #53974.
7064 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7066 * expression.cs : in DoNumericPromotions(), check if there is implicit
7067 conversion overload for string (to check CS0034). Fixed bug #52492.
7069 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7071 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7073 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7075 * ecore.cs : report location when it is *not* Null.
7077 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7083 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7084 correctly. Fixed bug #75721.
7086 2005-08-23 Raja R Harinath <rharinath@novell.com>
7088 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7089 loop that performs 'min (pos, char_count)'.
7092 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7093 converted value in Operator.OnesComplement.
7095 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7097 * anonymous.cs: If the anon method is pulled into a helper class,
7098 it needs to be `internal' not `private'. Fixes runtime behavior on
7101 2005-08-20 Martin Baulig <martin@ximian.com>
7103 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7104 scope if we don't already have it.
7106 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7107 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7110 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7113 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7116 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7118 The big constants rewrite
7119 Fix #75746, #75685 and more
7120 As a side effect saved 1MB for MWF ;-)
7122 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7123 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7124 enum based for corlib compilation.
7126 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7129 * class.cs (FixedField.Define): Use ResolveAsConstant.
7131 * const.cs (IConstant): Interface constants and enums.
7132 (Const.ResolveValue): New method for constant resolvning.
7133 (ExternalConstant): Constants from imported assemblies.
7135 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7136 conversion; like enums.
7137 (Constant.ToType): Converts this constant to different type.
7138 (Constant.Increment): Adds 1.
7140 * convert.cs (ImplicitConversionRequired): Simplified.
7142 * cs-parser.jay: Create EnumMember directly.
7144 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7146 * doc.cs (GenerateEnumDocComment): Removed.
7148 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7149 (ConvertIntLiteral): Removed.
7150 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7152 * enum.cs (EnumMember): Implement IConstant.
7153 (Enum.IsValidEnumConstant): Removed.
7154 (Enum.GetNextDefaultValue): Removed.
7155 (Enum.FindMembers): Updated.
7156 (Enum.GenerateDocComment): Iterate enum members.
7158 * expression.cs (Cast.TryReduce): Handle enums correctly.
7159 (New.Constantify): Made public.
7160 (MemberAccess.DoResolve): Removed contant specific if(s).
7162 * literal.cs (NullLiteral): Implement new abstract methods.
7164 * statement.cs (GotoCase.Resolve): Use new constant methods.
7165 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7167 * typemanager.cs (LookupEnum): Removed.
7168 (IsEnumType): Fixed to work with corlib.
7169 (RegisterConstant): Removed.
7170 (LookupConstant): Removed.
7171 (GetConstant): Changed to work with IConstant.
7173 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7175 * location.cs : Fixed overflown (>255) column number.
7177 2005-08-03 Raja R Harinath <rharinath@novell.com>
7179 First cut of the qualified-alias-member feature.
7180 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7182 * cs-parser.jay (DOUBLE_COLON): New token.
7183 (namespace_or_type_name): Add rule for recognizing
7184 qualified-alias-members.
7185 (primary_expression): Likewise.
7186 (element_access): Allow QualifiedAliasMember as a possible
7187 type-bearing expression.
7188 (local_variable_type, local_variable_pointer_type): Likewise.
7189 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7190 aliases in the current and enclosing namespace declarations.
7191 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7192 * decl.cs (MemberName.is_double_colon): New.
7193 (MemberName.MemberName): Add new constructor for alias-member.
7194 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7195 * expression.cs (QualifiedAliasMember): New expression type.
7197 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7199 * location.cs : it borked when no argument was specified.
7201 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7203 * location.cs : tiny ToString() format fix.
7205 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7207 * statement.cs : oops, it was missing.
7209 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7211 A set of fixes for precise line/column location.
7214 "token" field now holds a file/line "delta", a line number offset
7215 from the segment, and a column number. See also:
7216 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7217 December/009508.html
7218 Removed static IsNull. Use instance IsNull property instead.
7220 For some tokens it stores Location. For Identifier it stores
7221 LocatedToken which is a pair of string name and location.
7222 Column numbers are adjusted only at getChar().
7224 Use Location.ToString() for reporting (it now contains column).
7226 Largely modified to use LocatedToken instead of
7227 string (IDENTIFIER), and to acquire Location from some tokens.
7228 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7229 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7231 Now MemberName holds Location. DeclSpace.ctor() receives Location
7232 as a parameter. Removed extra parameters to all derived classes.
7233 Replaced Location.IsNull() with instance property.
7234 * assign.cs, expression.cs :
7235 Added .ctor() overload that omits Location.
7237 Added "nameEscaped" flag that indicates the identifier was escaped
7238 in the source file. This fixes bug #57047.
7240 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7242 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7243 New method, looking for lo-case imported cls type.
7245 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7248 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7250 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7252 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7254 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7256 Optimized to save 3.5 MB for SWF compilation.
7258 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7260 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7261 (PartialContainer.Create): Moved logic AddToContainer.
7262 (PartialContainer.MarkForDuplicationCheck): Shares name.
7264 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7267 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7269 (Namespace.GetSignatureForError): New method.
7271 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7272 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7274 2005-08-01 Raja R Harinath <rharinath@novell.com>
7277 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7278 member lookup rather than qualifier_type, since qualifier_type can
7281 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7283 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7286 2005-07-31 Miguel de Icaza <miguel@novell.com>
7288 * statement.cs: Copy the local exception into the exception
7289 captured local. Fixes 75674
7291 2005-07-31 Raja R Harinath <harinath@gmail.com>
7294 * expression.cs (Invocation.OverloadResolve): Don't report error
7295 CS1501 if error CS1502 has been reported.
7296 (New.DoResolve): Delegate CS1501 reporting to
7297 Invocation.OverloadResolve.
7300 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7301 invariant-meaning-in-block property in an enclosing block if
7304 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7306 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7307 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7308 (Switch.CheckSwitch): Just save 50kb for SWF.
7310 2005-07-27 Martin Baulig <martin@ximian.com>
7312 * anonymous.cs (CaptureContext.AddField): Added
7313 `AnonymousContainer am' argument; compute its toplevel scope if
7314 it's not already computed. Fixes #75649.
7316 2005-07-26 Raja R Harinath <rharinath@novell.com>
7319 * class.cs (Constructor.Emit): Reset block to null if the block
7322 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7324 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7326 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7328 * class.cs (MethodData.Define): Check whether accessor implementing
7329 interface is public.
7331 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7333 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7336 * namespace.cs (LookupType): Moved same type check to...
7338 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7341 2005-07-21 Raja R Harinath <rharinath@novell.com>
7343 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7344 already found a typebuilder.
7345 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7346 MemberNames, not strings.
7348 * const.cs (Error_ExpressionMustBeConst):
7349 Rename from Error_EpressionMustBeConst.
7350 * const.cs, class.cs, statement.cd: Update.
7352 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7356 * const.cs (Const.LookupConstantValue): Report missing contant expression
7358 (Error_EpressionMustBeConstant): Only one error method.
7360 * class.cs, statement.c: Updated.
7362 2005-07-20 Raja R Harinath <rharinath@novell.com>
7364 * statement.cs (Block.Flags): Add back HasVarargs.
7365 (Block.flags): Make protected.
7366 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7368 * typemanager.cs (types, typecontainers, user_types): Remove.
7369 (UserTypes, TypeContainers): Likewise.
7370 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7371 (CleanUp, Reset): Update.
7372 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7373 (GetNestedType): Use Type.GetNestedType.
7374 (CoreLookupType): Take two arguments, the namespace and the
7375 basename of the type. Update to use the Namespace.Lookup
7377 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7378 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7379 string concatenation and substring matches.
7380 * class.cs, enum.cs, delegate.cs: Update to changes.
7382 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7384 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7385 Expression and made virtual.
7387 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7388 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7390 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7392 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7395 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7398 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7401 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7402 AssemblyCultureAttribute is not used on executable.
7405 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7407 2005-07-16 Raja R Harinath <rharinath@novell.com>
7410 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7411 New. Reports CS0252/CS0253.
7412 Mostly taken from preliminary patch by Duncak Mak.
7413 (Binary.DoResolveOperator): Store results of operator lookup.
7414 Use them to detect if we need to warn about unintended reference
7417 2005-07-15 Raja R Harinath <rharinath@novell.com>
7420 * namespace.cs (Namespace.Lookup): Add back location parameter.
7421 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7422 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7424 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7425 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7426 (Namespace.LookupType): ... this.
7427 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7429 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7430 purported to handle pointers.
7431 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7434 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7436 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7439 2005-07-15 Raja R Harinath <rharinath@novell.com>
7441 * namespace.cs (Namespace.Lookup): Drop location parameter.
7442 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7443 (NamespaceEntry.Lookup): ... this.
7444 (NamespaceEntry.Error_AmbiguousTypeReference):
7445 Move here from DeclSpace.
7446 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7448 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7449 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7450 Move to NamespaceEntry.
7451 * delegate.cs, expression.cs: Update to changes.
7453 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7455 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7456 CheckAttributeType and refactored.
7457 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7458 ResolveAsTypeTerminal error handling.
7459 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7461 (GetSignatureForError): Print errors in same way.
7464 * codegen.cs: Reflect attribute GetSignatureForError change.
7467 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7469 * namespace.cs (UsingEntry): Refactored to make fields private.
7472 statement.cs: Error_UnexpectedKind has extra parameter.
7474 2005-07-14 Raja R Harinath <rharinath@novell.com>
7476 * ecore.cs (IAlias): Remove.
7477 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7478 that implement the interface.
7479 * namespace.cs (Namespace): Likewise.
7480 (Namespace.declspaces): Renamed from 'defined_names'.
7481 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7482 DeclSpace instead of an IAlias.
7483 * tree.cs (Tree.AddDecl): Update.
7485 2005-07-12 Raja R Harinath <rharinath@novell.com>
7487 * statement.cs (Block.Flags); Remove HasVarargs.
7488 (Block.HasVarargs): Move to ToplevelBlock.
7489 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7490 (Block.Variables): Make protected. Initialize variable hashtable
7492 (Block.AddVariable): Update.
7493 (Block.Resolve): Update to changes.
7494 (ToplevelBlock.HasVarargs): New boolean.
7495 (ToplevelBlock.ThisVariable): Move here from Block.
7496 (ToplevelBlock.AddThisVariable): Likewise.
7497 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7498 * expression.cs (This.ResolveBase): Update to changes.
7499 (ArglistAccess.DoResolve): Likewise.
7501 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7504 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7506 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7507 not used and not used & assigned.
7508 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7510 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7513 * expression.cs (Is.DoResolve): null is never provided type.
7515 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7518 * cs-parser.jay: Less strict event error rule to catch more errors.
7520 2005-07-08 Martin Baulig <martin@ximian.com>
7522 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7523 gettter (allowed) or setter (not allowed).
7525 * class.cs (Accessor): Implement IIteratorContainer.
7526 (Accessor.Yields): New public field.
7527 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7531 (get_accessor_declaration, set_accessor_declaration): Set the
7532 `yields' flag on the accessor, not the property.
7533 (property_declaration): Do the iterators check on a per-accessor
7534 basis and not for the whole property.
7536 2005-07-08 Martin Baulig <martin@ximian.com>
7538 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7539 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7541 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7544 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7545 (ExtractSecurityPermissionSet): Cope with self referencing security
7546 attributes properly.
7548 * driver.cs (SetOutputFile): Made public property OutputFile.
7550 2005-07-07 Raja R Harinath <rharinath@novell.com>
7553 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7554 has_nonstatic_fields. Make into a FieldBase pointer.
7555 (TypeContainer.AddField): Add CS0282 check.
7556 (TypeContainer.EmitType): Update.
7558 2005-07-06 Miguel de Icaza <miguel@novell.com>
7560 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7561 compare if they start with __.
7563 2005-07-06 Raja R Harinath <rharinath@novell.com>
7565 * statement.cs (Switch.SwitchGoverningType): Only look at
7566 UserCasts that don't need implicit standard conversions to one of
7567 the allowed switch types (Fixes test-322.cs).
7568 (LocalInfo.Resolve): Re-enable sanity-test.
7570 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7572 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7574 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7576 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7578 2005-07-06 Raja R Harinath <rharinath@novell.com>
7581 * ecore.cs (SimpleName.GetSignatureForError): Add.
7582 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7583 (MemberAccess.GetSignatureForError): Add.
7585 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7587 The big error and warning messages review.
7617 * typemanager.cs: Updated.
7619 * class.cs: (MethodCore.SetYields): Moved here to share.
7620 (PropertyMethod.Define): Moved iterator setup here.
7622 * iterators.cs: Add orig_method to have full access to parent
7625 2005-07-05 Raja R Harinath <rharinath@novell.com>
7627 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7628 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7629 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7630 variable of struct type.
7631 * expression.cs (Unary.ResolveOperator): Update to change.
7632 (Indirection.VerifyFixed): Likewise.
7633 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7634 (ParameterReference.VerifyFixed): Value parameters are fixed.
7635 (This.VerifyFixed): Treat 'this' as a value parameter.
7636 * statement.cs (LocalInfo.IsFixed): Remove.
7638 2005-07-01 Martin Baulig <martin@ximian.com>
7640 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7641 `ec.EmitThis ()' to get the correct scope.
7643 2005-07-01 Martin Baulig <martin@ximian.com>
7645 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7646 instance is a ParameterReference; fixes #75299.
7648 2005-07-01 Martin Baulig <martin@ximian.com>
7650 Reverted Marek's latest patch (r46725):
7651 - it contains structural changes which are neither mentioned in
7652 the ChangeLog nor explained anywhere; for example the additional
7653 argument of EmitContext's and Iterator's .ctor's and the
7654 TypeContainer.DefineMembers() change.
7655 - structural changes like this should go in in seperate patches
7656 and not be hidden in a huge patch which just seems to affect
7657 warnings and errors.
7658 a big and hard to understand patch.
7659 - it breaks iterators and causes regressions, for instance in
7662 2005-06-30 Raja R Harinath <rharinath@novell.com>
7665 * expression.cs (Indexers.map): Remove.
7666 (Indexers.Append): Filter out inaccessible setters and getters.
7667 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7670 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7672 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7673 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7674 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7675 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7677 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7680 * class.cs (FieldBase.GetInitializerExpression): One more field
7683 2005-06-28 Miguel de Icaza <miguel@novell.com>
7685 * pending.cs: Do not define a proxy if the base method is virtual,
7686 it will be picked up by the runtime (bug 75270).
7688 2005-06-08 Martin Baulig <martin@ximian.com>
7690 The big Iterators rewrite :-)
7692 * iterators.cs: Rewrite this to use the anonymous methods framework.
7694 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7695 before the TypeContainers; see 2test-21.cs.
7698 (TypeContainer.DefineType): Don't create a new EmitContext if we
7699 already have one (this only happens if we're an Iterator).
7700 (TypeContainer.Define): Also call Define() on all our iterators.
7701 (Method.CreateEmitContext): Added support for iterators.
7704 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7705 (AnonymousContainer.CreateMethodHost): Moved here from
7706 AnonymousMethod and made abstract.
7707 (AnonymousContainer.CreateScopeType): New abstract method.
7708 (AnonymousContainer.IsIterator): New public property.
7709 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7710 get the ScopeTypeBuilder rather than manually defining it here.
7711 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7714 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7715 before RootContext.DefineTypes().
7717 * codegen.cs (EmitContext.RemapToProxy): Removed.
7718 (EmitContext.CurrentAnonymousMethod): Changed type from
7719 AnonymousMethod -> AnonymousContainer.
7720 (EmitContext.ResolveTopBlock): Protect from being called twice.
7721 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7722 (EmitContext.EmitThis): Removed the iterators hacks; use the
7723 anonymous methods framework for that.
7726 (ToplevelBlock.Container): Make this a property, not a field.
7727 (ToplevelBlock.ReParent): New public method; move the
7728 ToplevelBlock into a new container.
7729 (Foreach.TemporaryVariable): Simplify.
7731 2005-06-05 Martin Baulig <martin@ximian.com>
7733 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7734 (Block.AddTemporaryVariable): New public method; creates a new
7735 `LocalInfo' for a temporary variable.
7736 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7738 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7739 non-iterator variables.
7741 2005-06-05 Martin Baulig <martin@ximian.com>
7743 * statement.cs (Foreach.TemporaryVariable): Create the
7744 LocalBuilder in the Emit phase and not in Resolve since in some
7745 situations, we don't have an ILGenerator during Resolve; see
7746 2test-19.cs for an example.
7748 2005-06-04 Martin Baulig <martin@ximian.com>
7750 **** Merged r45395 from GCS ****
7752 The big Foreach rewrite - Part II.
7754 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7755 with `PropertyInfo ienumerator_getcurrent'.
7757 * codegen.cs (VariableStorage): Removed.
7760 (Foreach): Derive from Statement, not ExceptionStatement.
7761 (Foreach.CollectionForeach): New nested class. Moved all the code
7762 dealing with collection foreach here.
7763 (Foreach.ForeachHelperMethods): Removed.
7764 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7766 2005-05-23 Martin Baulig <martin@ximian.com>
7768 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7769 don't need to. Fix #75014.
7771 2005-05-20 Martin Baulig <martin@ximian.com>
7773 Merged r44808 from GMCS.
7775 * class.cs (TypeContainer.CircularDepException): Removed.
7776 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7777 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7778 (CS0146) and interface (CS0529) dependencies here.
7780 2005-06-21 Raja R Harinath <rharinath@novell.com>
7782 * expression.cs (Invocation.EmitCall): Fix initialization
7783 'this_call' to reflect current behaviour. Fix indentation.
7785 * convert.cs (FindMostEncompassedType): Add two trivial special
7786 cases (number_of_types == 0 || number_of_types == 1).
7787 (FindMostEncompasingType): Likewise.
7789 2005-06-17 Raja R Harinath <rharinath@novell.com>
7791 Some cleanups preparing for the fix of #75283.
7792 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7794 (EventExpr.InstanceResolve): Likewise.
7795 (EventExpr.DoResolve): Remove redundant checks.
7797 2005-06-10 Duncan Mak <duncan@novell.com>
7799 * cs-tokenizer.cs (process_directives): New flag for controlling
7800 the processing of preprocessor directives.
7801 (x_token): After seeing a '#', return Token.NONE instead of going
7802 to handle_preprocessing_directive() when not processing
7803 directives. This avoids unnecessary processing during the token peek in
7808 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7809 the existing error reporting methods instead of Report.Error.
7811 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7812 after Raja's rewrite.
7814 2005-06-08 Miguel de Icaza <miguel@novell.com>
7816 * class.cs: Small fix.
7818 2005-06-08 Raja R Harinath <rharinath@novell.com>
7821 * class.cs (GetPartialBases): Fix return value check of
7824 2005-06-07 Raja R Harinath <rharinath@novell.com>
7826 Ensure that partial classes are registered in their enclosing
7827 namespace. Initial part of fix of #75160.
7828 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7829 Register declspace with namespace here, not in
7830 DeclSpace.RecordDecl.
7831 * cs-parser.jay: Pass namespace to RecordDecl.
7832 * class.cs (PartialContainer.Create): Likewise.
7833 (ClassPart.DefineType): New sanity-check. Throws an exception if
7835 * decl.cs (Declspace.RecordDecl): Remove.
7836 * namespace.cs (NamespaceEntry.DefineName): Remove.
7838 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7840 * rootcontext.cs: Reset TargetExt as well.
7842 2005-06-03 Raja R Harinath <rharinath@novell.com>
7844 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7847 2005-06-02 Raja R Harinath <rharinath@novell.com>
7849 Fix #75080, cs0119.cs.
7850 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7852 (Expression.Resolve): ... this. Use it. Remove bogus code
7853 allowing ExprClass.Type and ExprClass.Namespace for
7854 ResolveFlags.VariableOrValue.
7855 (Expression.Resolve) [1-argument variant]: Change default resolve
7856 flags based on language version.
7857 (Expression.Error_UnexpectedKind): Use a simple string array
7858 rather than an ArrayList.
7859 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7861 (TypeOfVoid.DoResolve): Likewise.
7862 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7863 flags argument -- it always has the same value.
7865 2005-05-31 Raja R Harinath <rharinath@novell.com>
7868 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7869 Use it in the error message.
7870 * assign.cs, expression.cs, statement.cs: Update.
7872 2005-05-30 Raja R Harinath <rharinath@novell.com>
7875 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7876 the "almostMatchedMember" case too.
7877 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7878 that failed the accessibility checks to 'almost_match'.
7880 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7882 * attribute.cs: Use internal MethodBuilder methods to set
7883 ExactSpelling and SetLastError on PInvoke methods, instead
7884 of passing them via charset. Fixes #75060.
7886 2005-05-27 Raja R Harinath <rharinath@novell.com>
7888 * parameter.cs (Parameter): Remove TODO comment.
7889 (Parameter.DefineParameter): Remove Location parameter.
7890 (Parameters.LabelParameters): Likewise.
7891 * class.cs (Constructor.Emit): Update to change.
7892 (MethodData.Emit): Likewise.
7893 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7894 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7896 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7899 Removed Parameters.Location and added Parameter.Location instead.
7900 Removed Location parameter from Emit() and GetSignature().
7907 Modified all related calls.
7909 2005-05-26 Raja R Harinath <rharinath@novell.com>
7911 Improve user-defined conversion handling.
7912 * convert.cs (GetConversionOperators): Rewrite. Return only the
7913 applicable operators.
7914 (AddConversionOperators): New. Helper for GetConversionOperators.
7915 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7916 there is only one most encompassed/encompassing type.
7917 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7918 "applicable operator" handling.
7919 (UserConversion): Move cache here from GetConversionOperators.
7920 Directly cache the chosen operator, rather than the whole
7922 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7923 case. Allow conversion of decimal to sbyte and byte too.
7924 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7925 New static methods. Used to avoid allocating EmptyExpressions in
7928 2005-05-24 Duncan Mak <duncan@novell.com>
7930 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7931 another class, used in Convert.ExplicitNumericConversion.
7932 (CastToDecimal): New class, similar to above, but casts to
7933 System.Decimal, used in Convert.ImplicitNumericConversion and also
7934 in explicit convesion from double/float to decimal.
7936 * convert.cs (ImplicitNumericConversion): Handle implicit
7937 conversions to System.Decimal.
7938 (ExplicitNumericConversion): handle explicit conversions to
7943 2005-05-20 Miguel de Icaza <miguel@novell.com>
7945 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
7946 know the type at this stage, just break through. Fixes #75008
7948 2005-05-19 Martin Baulig <martin@ximian.com>
7951 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
7952 to disable error reporting.
7954 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
7955 here since we don't want to report an error; see the new test-336.cs.
7957 2005-05-19 Raja R Harinath <rharinath@novell.com>
7959 * statement.cs (ToplevelBlock.GetParameterReference)
7960 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
7961 Move here from class Block.
7962 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
7963 * expression.cs (ParameterReference.DoResolveBase): Likewise.
7965 2005-05-18 Martin Baulig <martin@ximian.com>
7970 (FlowBranching.Reachability): Add non-static public And() and Or()
7972 (FlowBranchingSwitch): New class; do the `break_origins' thing
7973 like in FlowBranchingLoop.
7974 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
7975 reachability, not just locals and parameters.
7976 (FlowBranching.MergeChild): Remove some of the hacks for loop and
7977 switch; MergeBreakOrigins() now takes care of that.
7979 2005-05-18 Martin Baulig <martin@ximian.com>
7981 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7982 a loop and may leave it, reset the barrier; fixes #74974.
7984 2005-05-17 Marek Safar <marek.safar@seznam.cz>
7986 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
7989 * cs-parser.jay: Catch more lexical errors.
7991 * report.cs: Add one more Error method.
7994 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
7996 2005-05-17 Martin Baulig <martin@ximian.com>
7998 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8001 2005-05-16 Raja R Harinath <rharinath@novell.com>
8003 Fix test-382.cs. Emit values of decimal constants.
8004 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8006 (TypeContainer.AddField): ... this.
8007 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8008 with initializers to include 'Const's.
8009 (ClassPart.RegisterFieldForInitialization): Forward to
8011 * const.cs (Const.Const): Pass initializer to base class.
8012 (Const.Define): In case of decimal constants, register them for
8013 initialization in a static constructor.
8015 2005-05-14 Martin Baulig <martin@ximian.com>
8017 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8018 do not call ResolveUnreachable() on unreachable statements in
8019 here, see the comment in the source code.
8021 2005-05-13 Raja R Harinath <rharinath@novell.com>
8024 * expression.cs (BinaryResolveOperator): If one of the operands of
8025 an equality comparison is 'null' and the other is a pointer type,
8026 convert the null to a NullPointer.
8027 * convert.cs (ImplicitReferenceConversion): If the expression is a
8028 NullLiteral and the target type is a pointer type, return a
8029 NullPointer instead.
8030 (ImplicitConversionStandard): Likewise.
8032 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8034 * cs-parser.jay: Set readonly context based on special constructs.
8036 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8037 readonly variable error handling.
8039 * rootcontext.cs (EmitCode): Don't verify members when error
8042 * statement.cs (LocalInfo): Add reaodnly context information.
8043 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8045 2005-05-13 Raja R Harinath <rharinath@novell.com>
8047 * statement.cs (Block.Resolve): Revert change below. Modify fix
8048 for #74041 to initialize 'resolved' to false only for explicit
8049 blocks. Fixes #74873.
8051 2005-05-12 Raja R Harinath <harinath@gmail.com>
8054 * typemanager.cs (unmanaged_enclosing_types): New.
8055 (IsUnmanagedType): Avoid infloops by using
8056 'unmanaged_enclosing_types' to talk with recursive invocations.
8058 2005-05-13 Martin Baulig <martin@ximian.com>
8060 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8061 instance variable, not a local. Fix #74873.
8062 (Block.ResolveUnreachable): Set it to true here.
8064 2005-05-11 Duncan Mak <duncan@novell.com>
8066 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8067 continuing to process for 'arg'.
8068 (handle_preprocessing_directive): Check the argument of the #endif
8069 directive and report error CS1025 if there are any trailing
8072 According to the C# spec, having even whitespace after the #endif
8073 directive is illegal; however, because we call arg.TrimEnd ()
8074 beforehand, we have the same behavior as csc, allowing whitespace
8075 after the directive.
8079 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8083 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8084 (Constructor.GetObsoleteAttribute): Implemented correctly.
8086 2005-05-10 Martin Baulig <martin@ximian.com>
8088 * support.cs (ReflectionParameters.ParameterModifier): Use
8089 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8090 and `ParameterAttributes.In'. Fixes #74884.
8092 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8094 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8096 * expression.cs (Argument.GetParameterModifier): Turned to property.
8097 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8099 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8102 2005-05-09 Raja R Harinath <rharinath@novell.com>
8105 * decl.cs (MemberCache.AddMethods): Register override methods,
8106 rather than non-override methods.
8107 * typemanager.cs (RegisterOverride): New.
8108 (IsOverride): Update.
8110 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8114 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8115 recursive declaration.
8117 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8119 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8121 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8123 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8125 2005-05-05 Raja R Harinath <rharinath@novell.com>
8128 * decl.cs (DeclSpace.FamilyAccessible):
8129 Use TypeManager.IsNestedFamilyAccessible.
8131 Fix reopened #64812.
8132 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8135 2005-05-04 Raja R Harinath <rharinath@novell.com>
8136 Abin Thomas <projectmonokochi@rediffmail.com>
8137 Anoob V E <projectmonokochi@rediffmail.com>
8138 Harilal P R <projectmonokochi@rediffmail.com>
8141 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8142 allow access to all static members.
8144 2005-05-04 Martin Baulig <martin@ximian.com>
8146 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8148 2005-05-04 Martin Baulig <martin@ximian.com>
8152 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8153 section at the end; make things work if `default' is not the last
8156 2005-05-04 Martin Baulig <martin@ximian.com>
8160 * statement.cs (Switch): Replaced the `got_default' field with a
8161 `default_section' one.
8162 (Switch.CheckSwitch): Set `default_section' here.
8163 (Switch.Resolve): If we're a constant switch and the constant is
8164 not found, use the default section.
8166 2005-05-03 Martin Baulig <martin@ximian.com>
8168 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8170 * statement.cs (Foreach.ArrayForeach): New nested class.
8171 (Foreach.TemporaryVariable): New nested class.
8172 (Foreach.EmitArrayForeach): Removed; this is now in the new
8175 2005-05-03 Raja R Harinath <rharinath@novell.com>
8177 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8179 (VerifyPendingMethods): Revert change below.
8181 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8182 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8183 that used to trigger warning -28. Remove warning -28.
8184 * expression.cs (Invocation.OverloadResolve): Use
8185 TypeManager.IsOverride to distinguish override methods.
8188 * pending.cs (VerifyPendingMethods): If a base type implements the
8189 requested interface, don't bother checking individual methods of
8190 the base type. As a side-effect, this prevents the creation of
8191 unnecessary proxies.
8193 2005-05-02 Martin Baulig <martin@ximian.com>
8197 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8198 Also `And' the locals if the old vector is null.
8199 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8200 null; in this case we basically reset all the variables.
8202 2005-05-02 Martin Baulig <martin@ximian.com>
8206 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8207 Added `FlowBranching branching' argument; always `and' the
8208 variables instead of `or'ing them unless we're an infinite loop.
8210 * statement.cs (While.Resolve): Create a new sibling unless we're
8213 2005-05-02 Martin Baulig <martin@ximian.com>
8217 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8218 arguments; use it instead of creating a new TopLevelBlock.
8219 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8220 our ConstructorInitializer.
8223 (TopLevelBlock.TopLevelBranching): New public property.
8224 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8225 and create our `TopLevelBranching'.
8227 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8228 anonymous method host, use `block.TopLevelBranching' rather than
8229 creating a new branching.
8231 2005-04-20 Miguel de Icaza <miguel@novell.com>
8233 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8234 a ScopeInfo, if any of the current children is a child of the new
8235 entry, move those children there.
8237 2005-04-30 Martin Baulig <martin@ximian.com>
8239 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8240 at the beginning of a SwitchSection. Fix #73335.
8242 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8245 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8247 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8248 (FieldExpr.DoResolve): Obsolete members are ignored for field
8251 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8253 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8254 of arrays detection.
8256 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8258 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8260 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8263 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8265 * cs-parser.jay: Use the prefered version of -unsafe in error
8268 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8270 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8273 2005-04-20 John Luke <john.luke@gmail.com>
8275 * driver.cs: fix typo in error message, --outout to --output
8277 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8279 * codegen.cs (InRefOutArgumentResolving): New field.
8281 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8282 fields outside contructor.
8284 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8286 2005-04-19 Miguel de Icaza <miguel@novell.com>
8288 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8289 parameter code was not completed ever, so it was not as up-to-date
8290 as local variables. Must finish it.
8292 The bug fix was to compare the Toplevel of the block, not the
8293 current block. Thanks for Ben for pointing this out.
8295 2005-04-19 Raja R Harinath <rharinath@novell.com>
8297 * decl.cs (AddMethods): Use the declaring type of the problem
8298 method to determine if we want to squash a warning.
8300 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8302 * attribute.cs: Removed debug output.
8304 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8306 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8309 2005-04-18 Raja R Harinath <rharinath@novell.com>
8312 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8313 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8314 all null comparisons against reference types.
8316 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8319 * class.cs (TypeContainer.CircularDepException) New nested
8321 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8322 (TypeContainer.DefineType): Removed error, reset InTransit before
8324 (Class.DefineType): Throw exception when is in Transit.
8325 Catch exception and report error.
8326 (Struct.DefineType): Throw exception when is in Transit.
8327 Catch exception and report error.
8328 (Interface.DefineType): Throw exception when is in Transit.
8329 Catch exception and report error.
8331 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8332 handle nested exception handlers.
8334 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8337 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8338 InFinally and InCatch storage.
8340 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8341 (Catch.Resolve): Set and Restore ec.InCatch.
8342 (Try.Resolve): Set and Restore ec.InFinally.
8343 (Try.HasCatch): True when try has catch.
8345 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8347 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8348 for the same event member, so exclude such cases from warning 419.
8351 2005-04-16 Miguel de Icaza <miguel@novell.com>
8353 * expression.cs (Binary.ResolveOperator): Apply patch from John
8354 Luke to fix bug 59864: operators &, | and ^ on enumerations
8355 require that the same enum type on both sides.
8357 * driver.cs: Add warnings to old flag usage, this is to assist
8358 people who produce Makefiles and hope that the Makefiles will be
8361 * class.cs (TypeContainer.EmitType): Moved the definition of the
8362 special $PRIVATE$ field from the resolve phase to the Emit phase.
8363 During resolve we do not know if we are a struct with
8364 HasExplicitLayout, we know this only after the attributes for the
8367 Set the FieldOffset to zero on the dummy field that we create for
8368 the class. Fixes 74590.
8370 2005-04-16 Raja R Harinath <rharinath@novell.com>
8373 * ecore.cs (PropertyExpr.resolved): New.
8374 (DoResolve): Use it to handle a case of double resolution here.
8375 Handle a case of identical-name-and-type-name.
8376 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8377 resolution by storing the results of expression resolution back
8378 into the "probes" array.
8380 2005-04-15 Raja R Harinath <rharinath@novell.com>
8382 Fix cs0208-7.cs and cs0208-8.cs.
8383 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8384 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8385 error reporting to point out the reason a struct is not unmanaged.
8387 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8389 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8390 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8392 2005-04-13 Raja R Harinath <rharinath@novell.com>
8395 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8396 IdenticalNameAndTypeName here.
8397 (EventExpr.InstanceResolve): Likewise.
8399 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8401 C# 2.0 DefaultCharSetAttribute implementation
8403 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8404 which allows us to set GlobalNamespace for every resolve.
8405 (Attribute.ResolveArguments): Cut from Resolve.
8406 (Attribute.GetCharSetValue): Returns CharSet named argument.
8407 (Attribute.DefinePInvokeMethod): Gets default charset from
8409 (GlobalAttribute.ResolveAsTypeStep): Override.
8410 (GlobalAttribute.ResolveArguments): Override.
8412 * class.cs (TypeAttr): Is protected.
8414 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8415 (ModuleClass.DefaultCharSetType): New memeber.
8416 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8418 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8419 charset from module.
8421 * delegate.cs (TypeAttr): Override.
8422 (Delegate.DefineType): Use this TypeAttr.
8424 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8425 at very early stage (before types are defined) to resolve model
8426 module attributes. It will probably not work with corlib but it
8429 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8430 charset from module.
8432 * typemanager.cs (default_charset_type): New type.
8434 2005-04-13 Raja R Harinath <rharinath@novell.com>
8436 * decl.cs (MemberCache.AddMethods): Don't warn if
8437 System.Object.Finalize has buggy MethodAttributes.
8439 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8442 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8444 * doc.cs : detect ambiguous reference to overloaded members.
8445 Fixed bug #71603. MS 1.1 csc does not detect it.
8447 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8449 * doc.cs : delegates must not be referenced with parameters.
8452 2005-04-12 Miguel de Icaza <miguel@novell.com>
8454 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8456 2005-04-10 Miguel de Icaza <miguel@novell.com>
8458 * driver.cs (MainDriver): Stop processing if the CLS stage found
8461 (CompilerCallableEntryPoint.InvokeCompiler): Always
8462 reset after execution; Take a TextWriter argument for the
8465 * report.cs: Use the error stream instead of hardcoding stderr.
8467 2005-04-09 Miguel de Icaza <miguel@novell.com>
8469 * class.cs: Reduce code paths to test, too small of an
8470 optimization to make it worth the extra testing. Always perform
8473 2005-04-08 Raja R Harinath <rharinath@novell.com>
8476 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8477 operators that had errors reported on them.
8479 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8481 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8483 (Attribute.Resolve): Add named argument type checking.
8485 * class.cs (FixedField.Define): Use IsPrimitiveType
8487 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8489 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8490 unsafe parameter types.
8492 * statement.cs (Using.ResolveExpression): Add better error description.
8494 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8496 2005-04-08 Raja R Harinath <rharinath@novell.com>
8499 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8500 AttributeUsageAttribute in the emitcontext of the attribute class,
8501 not in the emitcontext of the attributable entity it was attached to.
8502 * cs-parser.jay: Use 'current_class', not 'current_container',
8503 when creating a GlobalAttribute.
8505 2005-04-08 Alp Toker <alp@atoker.com>
8507 * pending.cs: The fix to #58413 failed to compile methods implementing
8508 interfaces with/without params modifiers and vice versa, even though
8509 params modifiers aren't part of the signature. Make the modifier check
8510 less strict as in csc.
8512 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8513 Anoob V E <projectmonokochi@rediffmail.com>
8514 Harilal P R <projectmonokochi@rediffmail.com>
8517 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8518 modifiers of pending methods.
8519 (PendingImplementation.PendingImplementation): Initialize it.
8520 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8521 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8522 with ParameterData. Add check for modifiers.
8523 * class.cs (MethodData.Define): Update to changes.
8525 2005-04-07 Raja R Harinath <rharinath@novell.com>
8527 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8529 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8531 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8534 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8537 * typemanager.cs: Registered RequiredAttributeAttribute.
8539 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8541 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8542 Warning CS0169 is back at level 3.
8543 (IMethodData.SetMemberIsUsed): New method.
8545 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8546 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8548 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8550 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8552 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8555 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8558 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8559 to avoid the problems with nested types.
8561 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8562 Anoob V.E <projectmonokochi@rediffmail.com>
8563 Harilal P.R <projectmonokochi@rediffmail.com>
8564 Raja R Harinath <rharinath@novell.com>
8567 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8569 * typemanager (GetConstructor): Make public.
8571 2005-04-05 John Luke <john.luke@gmail.com>
8572 Raja R Harinath <rharinath@novell.com>
8575 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8576 struct too. Return false quicker in a few cases.
8577 (VerifyUnManaged): Use it.
8579 2005-04-05 Raja R Harinath <rharinath@novell.com>
8582 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8583 not 'unreachable_seen'.
8585 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8587 * attribute.cs (Attribute.GetValue): Removed unused.
8589 * codegen.cs (CodeGen.TrimExt): Removed unused.
8591 * cs-parser.jay (output): Removed unused.
8593 * cs-tokenizer.cs (hex_digits): Removed unused.
8595 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8597 * expression.cs (Indirection.LoadExprValue): Removed unused.
8598 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8600 * iterators.cs (Iterator.param_types): Removed unused.
8602 * statement.cs (Goto.block): Removed unused.
8603 (ToplevelBlock.did): Removed unused.
8604 (Switch.ResolveConstantSwitch): Removed unused.
8606 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8608 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8611 2005-04-01 Raja R Harinath <rharinath@novell.com>
8613 Fix #74232 and cs0208-3.cs.
8614 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8615 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8616 unmanaged type. Don't use FieldBuilders when 't' is a
8617 TypeBuilder. Use ModFlags and MemberType fields.
8618 * class.cs (MemberBase.member_type): Rename from MemberType.
8619 (MemberBase.MemberType): New property. Determines member_type on
8621 (MemberBase.DoDefine): Don't initialize MemberType here.
8622 (FieldMember.Define): Likewise.
8624 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8627 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8628 Attributes are emitted there.
8630 2005-04-01 Raja R Harinath <rharinath@novell.com>
8632 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8633 keyword in 'partial enum' too.
8634 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8636 Report from Kamil Skalski <nazgul@omega.pl>.
8639 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8640 have partial containers too.
8642 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8643 in block' checks to Block.CheckInvariantMeaningInBlock.
8644 * statement.cs (Block.GetKnownVariableInfo): Make private.
8645 (Block.IsVariableUsedInChildBlock): Remove.
8646 (Block.IsVariableUsedInBlock): Likewise.
8647 (Block.CheckInvariantMeaningInBlock): New. Show location of
8648 conflicting declaration.
8649 (Block.AddVariable): Make error messages less long-winded and more
8650 specific. Show location of conflicting declaration.
8651 * parameter.cs (Parameters.Location): New readonly property.
8653 2005-03-31 Raja R Harinath <rharinath@novell.com>
8655 Clean up semantics of invoking ResolveMemberAccess.
8656 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8657 can have an instance, ensure that we pass in a non-TypeExpression
8658 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8659 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8660 argument. Update to changes and simplify.
8661 (FieldExpr.Emitinstance): Remove CS0120 check.
8662 (PropertyExpr.EmitInstance): Likewise.
8663 * expression.cs (Argument.Resolve): Likewise.
8664 (Invocation.DoResolve): Update to changes in semantics of
8667 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8670 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8673 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8675 2005-03-31 Raja R Harinath <rharinath@novell.com>
8677 Fix difference in behaviour with commandline invocation.
8678 * driver.cs (Driver.Reset): New.
8679 (CompilerCallableEntryPoint): Call it.
8681 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8682 variable" warnings if the boolean expression failed to resolve.
8684 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8686 * attribute.cs: Fix the union of several permissions when some of them
8687 are unrestricted (so the result isn't an unrestricted permission set).
8690 2005-03-30 Raja R Harinath <rharinath@novell.com>
8692 * ecore.cs (MemberExpr): New class. Convert from interface
8694 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8695 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8697 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8698 (MethodGroupExpr.IsExplicitImpl): Remove.
8699 (Expression.GetFieldFromEvent): Remove.
8700 (SimpleName.MemberStaticCheck): Remove.
8701 (SimpleName.DoSimpleNameResolve): Update to changes.
8702 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8703 (MemberAccess.IdenticalNameAndTypeName): Remove.
8704 (MemberAccess.error176): Move to MemberExpr.
8705 (MemberAccess.DoResolve): Update to changes.
8706 (BaseAccess.DoResolve): Likewise.
8708 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8710 C# 2.0 Conditional attribute class implementation
8712 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8713 Analyzes class whether it has attribute which has ConditionalAttribute
8714 and its condition is not defined.
8716 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8717 (Class.IsExcluded): New method. Search for at least one defined
8718 condition in ConditionalAttribute of attribute class.
8720 2005-03-30 Raja R Harinath <rharinath@novell.com>
8722 * ecore.cs (PropertyExpr): Derive from Expression, not
8723 ExpressionStatement.
8724 (PropertyExpr.EmitStatement): Remove.
8726 2005-03-29 Raja R Harinath <rharinath@novell.com>
8729 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8730 internal field "value__" of an enum be private. The examples for
8731 "value__" that I found on MSDN all used FieldAttributes.Private.
8733 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8734 Don't mention IL method attribute names.
8736 Fix #47991. Remove a TODO.
8737 * statement.cs (Block.Toplevel): Make into a field.
8738 (Block.Parameters): Move into ToplevelBlock.
8739 (Block.known_variables): Rename from child_variable_names.
8740 (Block.Block): Remove variants that take Parameters. Initialize
8741 'Toplevel' with the immediately surrounding toplevel block.
8742 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8743 LocalInfo parameter.
8744 (Block.GetKnownVariableInfo): New.
8745 (Block.IsVariableNameUsedInChildBlock): Update.
8746 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8747 the block, even though it may not be in scope.
8748 (Block.AddVariable): Remove Parameters parameter. Use
8749 Toplevel.Parameters instead.
8750 (Block.AddConstant): Remove Parameters parameter.
8751 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8752 (Block.IsParamaterReference): Likewise.
8753 (Block.IsLocalParameter): Likewise. Simplify a lot.
8754 (ToplevelBlock.Parameters): New. Moved from Block.
8755 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8756 initialize Parameters to a non-null value.
8757 * cs-parser.jay: Update to changes.
8758 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8759 simple names that mean different things in the same block. Use
8760 Block.IsVariableNameUsedInBlock.
8762 2005-03-28 Raja R Harinath <rharinath@novell.com>
8764 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8765 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8766 GetTypeHandle. It is possible for a reflected type to derive from
8767 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8768 System.Array during mscorlib compilation).
8769 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8770 contain a method_hash, don't create one either. Don't create a
8771 deep copy of the base cache's method_hash.
8772 (MemberCache.SetupCache): Rename back from DeepCopy.
8773 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8774 already initialized. If we see an override function, add its
8775 underlying base virtual function to the member_hash too.
8777 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8779 2005-03-26 Raja R Harinath <harinath@acm.org>
8782 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8783 fails to resolve, ensure that the LHS is still resolved as an
8786 2005-03-25 Raja R Harinath <harinath@acm.org>
8788 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8790 (Enum.current_ec): Remove.
8791 (Enum.LookupEnumValue): Remove EmitContext argument.
8792 Just uses the one created during DefineType.
8793 (Enum.FindMembers): Update.
8794 * expression.cs (MemberAccess.DoResolve): Update.
8796 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8798 * assign.cs (Assign.DoResolve): Check for CS1717 when
8799 source and target are same (uses Equals).
8801 * expression.cs (LocalVariableReference, ParameterReference,
8802 This): Implemented Equals, GetHashCode.
8804 * statement.cs (Block.GetParameterReference): Removed useless
8807 2005-03-22 Raja R Harinath <rharinath@novell.com>
8810 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8811 blocks before deciding whether the error is cs0136 or cs0128.
8813 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8814 (using_alias_directive, using_namespace_directive): Pass
8815 MemberName, not an expression to Namespace.UsingAlias and
8817 (MakeName): Use the MemberName of the namespace.
8818 * namespace.cs (Namespace.MemberName): New.
8819 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8820 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8822 * decl.cs (MemberName.Name): Make readonly.
8823 (MemberName.FromDotted): New "constructor".
8824 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8825 (MemberCore.Name): Compute from MemberName on demand.
8826 (MemberCore.SetMemberName): Provide a way to change the
8828 (MemberCore.AddToContainer): Don't take a fullname parameter.
8829 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8830 fully qualified name of the container to the member name.
8831 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8832 only if the type is a member of the root container.
8833 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8834 MemberName.Left rather than searching for an embedded ".".
8835 (PartialContainer.CreatePart): Update to changes in RootContext.
8836 (MemberBase.ShortName): Turn into a property. Use
8837 MemberCore.SetMemberName.
8838 (MemberBase.ExplicitInterfaceName): Remove.
8839 (MemberBase.UpdateMemberName): Remove.
8840 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8841 (PropertyBase.SetMemberName): New override.
8842 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8843 (Tree.GetDecl): New.
8844 (Tree.AllDecls): Rename from Decls.
8845 * attribute.cs, enum.cs, report.cs: Update to changes.
8846 * driver.cs (MainDriver): Use MemberName.FromDotted on
8847 RootContext.MainClass.
8849 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8851 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8854 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8856 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8858 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8859 property accessor modifiers.
8861 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8862 fixed buffer attribute (CS1716).
8863 (PropertyMethod.HasCustomAccessModifier): When property accessor
8864 has custom modifier.
8866 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8868 (PropertyExpr.DoResolveLValue): Add CS0272.
8870 2005-03-17 Miguel de Icaza <miguel@novell.com>
8872 * convert.cs: When converting to a pointer, use the proper Conv.U
8873 or Conv.I depending on the source data type.
8875 * cs-tokenizer.cs: Make the size for large decimal constants,
8878 2005-03-17 Martin Baulig <martin@ximian.com>
8880 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8881 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8883 2005-03-17 Martin Baulig <martin@ximian.com>
8885 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8886 to bool so we can return an error condition.
8887 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8890 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8892 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8895 2005-03-16 Raja R Harinath <rharinath@novell.com>
8897 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8898 Refactor to avoid traversing the list of assemblies, and to avoid
8899 string concatenation.
8900 * typemanager.cs (guid_attr_type): Remove.
8901 (negative_hits, pointers, references): Remove hashes.
8903 (GetConstructedType): New. Uses type_hash to handle constructed
8904 types (arrays, references, pointers).
8905 (GetReferenceType, GetPointerType): Use it.
8906 (GetNestedType): New. Uses type_hash to handle nested types of
8908 (LookupType, LookupTypeDirect): Remove.
8909 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8910 'types' hash and LookupTypeReflection directly.
8911 (params_string, params_object): Use GetConstructedType.
8912 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8914 (Namespace.Lookup): Use cached_types.
8915 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8916 provided by old TypeManager.LookupType.
8917 * rootcontext.cs (MakeFQN): Remove.
8918 * decl.cs (DeclSpace.MakeFQN): Likewise.
8919 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8920 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8921 TypeManager.GetConstructedType.
8922 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8924 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8926 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8929 * cs-parser.jay: Reports CS1527 for any namespace element.
8931 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8934 * expression.cs (ParameterReference.IsAssigned): Changed error to
8936 (Error_WrongNumArguments): Moved CS0245 detection here.
8938 * statement.cs (Return.Resolve): Add CS1622 report.
8940 2005-03-11 Marek Safar <marek.safar@seznam.cz>
8942 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
8944 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
8946 * attribute.cs expression.cs: Get rid of some allocations.
8948 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
8950 * doc.cs : just eliminate the latest change.
8952 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8954 * doc.cs : commented out the latest change. It breaks xml-030.cs
8956 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8958 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
8959 fail. So invoke CreateType() in FindDocumentedType().
8961 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8963 * cs-tokenizer.cs : added IsKeyword().
8964 * doc.cs : Detect keyword incorrectly used as identifier.
8965 Allow identifiers prefixed by @.
8967 2005-03-10 Marek Safar <marek.safar@seznam.cz>
8969 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
8970 It caused exception in namespace resolving (again!).
8972 * class.cs (Class.ctor): Removed exit.
8973 (PropertyMethod.ctor): ditto.
8975 * codegen.cs (Codegen.Reset): Reset static data.
8976 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
8978 * cs-tokenizer.cs (Cleanup): Removed.
8980 * driver.cs (GetSystemDir): Rewrote to one line command.
8981 It caused problem with unloaded dynamic modules.
8982 (UnixParseOption): Removed Exit.
8983 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
8984 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
8985 Now can be mcs used as library.
8987 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
8990 * location.cs (Reset): Reset static data.
8992 * namespace.cs (Reset): Reset static data.
8994 * report.cs (Report.Reset): Reset static data.
8996 * rootcontext.cs (RootContext.Reset): Reset static data.
8998 * tree.cs (RootTypes.ctor): Use Location.Null
9000 * typemanager.cs (TypeManager.Reset): Reset static data.
9001 (CoreLookupType): Removed Exit.
9002 (TypeHandle.Reset): Reset static data.
9004 2005-03-10 Raja R Harinath <rharinath@novell.com>
9007 * typemanager.cs (ComputeNamespaces): Import namespaces from
9008 referenced modules too.
9010 2005-03-09 Raja R Harinath <rharinath@novell.com>
9012 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9015 2005-03-09 Raja R Harinath <rharinath@novell.com>
9017 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9018 enclosing DeclSpace. This ensures that a name-lookup populates
9019 more caches and there are fewer 'TypeExpression's. Carve out
9020 nested type lookup into ...
9021 (LookupNestedTypeInHierarchy): ... this.
9023 2005-03-09 Raja R Harinath <rharinath@novell.com>
9025 Clean up a few partial-class semantics.
9026 Fixes test-357.cs and cs1618-2.cs.
9027 * cs-parser.jay (struct_declaration): Use 'current_class' as
9028 parent of newly-created struct. Remove call to Register ().
9029 Use 'pop_current_class' to complete handing the current struct.
9030 (interface_declaration): Likewise.
9031 (class_declaration): Likewise.
9032 (enum_declaration): Use 'current_class' as parent of newly created
9034 (delegate_declaration): Likewise.
9035 (pop_current_class): New function. This is used to handle closing
9036 up the 'current_class' and 'current_container', and pointing them
9037 to the enclosing class/container.
9038 (CSharpParser): Initialize 'current_class' too.
9039 * decl.cs (MemberCore): Add check for invariant: a partial
9040 container is not a parsed entity, and thus does not enclose any
9042 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9043 (DeclSpace.BaseTypeExpr): Use it.
9044 (DeclSpace.LookupType): Add check for invariant.
9045 * class.cs (TypeContainer): Add check for invariant: a nested
9046 class should have the same NamespaceEntry as its enclosing class.
9047 (TypeContainer.EmitFieldInitializers): Make virtual.
9048 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9050 (TypeContainer.Register): Remove.
9051 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9052 null. Use TypeResolveEmitContext for resolving base types and
9053 interfaces. Move initialization of Parts.TypeBuilder here from
9055 (TypeContainer.DefineNestedTypes): ... here.
9056 (PartialContainer): Take a Namespace not a NamespaceEntry.
9057 (PartialContainer.Create): Don't use Register. Call the
9058 appropriate Add... function directly.
9059 (ClassPart): Take both the PartialContainer and the enclosing
9060 class as constructor arguments.
9061 (ClassPart.EmitFieldInitializers): Override.
9062 (ClassPart.PartFindNestedTypes): Remove.
9063 (FieldBase.GetInitializerExpression): Resolve the initializer
9064 expression in the emit context of the enclosing class.
9065 * tree.cs (RootTypes): Remove Register ().
9067 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9069 * cs-parser.jay: Removed CS0134.
9071 * driver.cs: Removed CS1901.
9073 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9074 for predefined types.
9076 2005-03-07 Duncan Mak <duncan@novell.com>
9078 * codegen.cs (Save): Catch UnauthorizedAccessException as
9079 well. Fixes bug #73454.
9081 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9083 * cs-tokenizer.cs (xtoken): Add CS1035.
9085 * class.cs (MethodData.Define): Add CS0683.
9086 (FieldMember.ctor): Add CS0681.
9088 2005-03-07 Raja R Harinath <rharinath@novell.com>
9090 * ecore.cs (SimpleName.DoResolve): Rename from
9091 SimpleName.DoResolveAllowStatic.
9092 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9093 Pass 'intermediate' flag to MemberStaticCheck.
9094 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9095 of "intermediate" lookups via MemberAccess.
9096 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9097 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9099 2005-03-07 Raja R Harinath <rharinath@novell.com>
9102 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9103 slipped in because of variable names that are identical to a
9104 builtin type's BCL equivalent ('string String;', 'int Int32;').
9105 (PropertyExpr.EmitInstance): Likewise.
9107 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9109 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9111 * report.cs (warning_ignore_table): Made public.
9113 2005-03-04 Raja R Harinath <rharinath@novell.com>
9116 * class.cs (MethodData.Emit): Pass 'container' to
9117 container.GetObsoleteAttribute instead of 'container.Parent'.
9119 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9121 * cs-parser.jay: Add 1534 error test.
9123 * iterators.cs (Yield.CheckContext): Add error 1629.
9124 (Iterator.ctor): Save unsafe modifier.
9125 (MoveNextMethod.DoEmit): Restore unsafe context.
9127 * namespace.cs (UsingAlias): Better error message.
9129 2005-03-03 Dan Winship <danw@novell.com>
9131 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9132 the warning message [#73219]
9134 2005-03-03 Raja R Harinath <rharinath@novell.com>
9136 Fix compile with MCS 1.0.0.0.
9137 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9138 w_restore to not depend on string constant folding.
9140 2005-03-03 Raja R Harinath <rharinath@novell.com>
9142 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9143 CS0246 check to users who passed 'silent = false'.
9144 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9146 (SimpleName.SimpleNameResolve): Update.
9147 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9148 (MemberAccess.IdenticalNameAndTypeName): Update.
9149 * doc.cs (FindDocumentedTypeNonArray): Update.
9151 2005-03-03 Raja R Harinath <rharinath@novell.com>
9153 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9154 * parameters.cs (ComputeAndDefineParameters): Remove.
9155 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9156 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9157 Use GetParameterInfo.
9159 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9161 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9163 2005-03-02 Raja R Harinath <rharinath@novell.com>
9165 Unify DeclSpace.LookupType and DeclSpace.FindType.
9166 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9167 is in charge of defining nested types on demand.
9168 (DeclSpace.LookupType): Use it when the current_type is a
9169 TypeBuilder. Use LookupTypeDirect for reflected types.
9170 (DeclSpace.FindType): Remove.
9171 (DeclSpace.LookupInterfaceOrClass): Likewise.
9172 (DeclSpace.DefineTypeAndParents): Likewise.
9173 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9174 DeclSpace.LookupType.
9175 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9176 * typemanager.cs (LookupType): Simplify.
9177 (AddUserType): Remove type from negative_hits.
9178 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9179 * class.cs (TypeContainer.FindMembers): Move handling of nested
9181 (TypeContainer.FindMembers_NestedTypes): ... here.
9182 (TypeContainer.FindNestedType): Implement override.
9183 (ClassPart.FindNestedType): Delegate to PartialContainer.
9184 (ClassPart.PartFindNestedType): Looks up the nested types of the
9187 2005-03-02 Martin Baulig <martin@ximian.com>
9189 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9190 static constructor in static classes.
9192 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9194 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9195 sizeParamIndex is not specified.
9197 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9200 * report.cs (WarningMessage.IsEnabled): Missing null check.
9202 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9204 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9205 in the fields and not in the properties.
9207 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9209 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9212 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9214 * attribute.cs: Small refactoring (improved robustness).
9215 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9216 (ValidateGuid): Removed.
9217 (Resolve): Removed referenced to above mentioned.
9218 (GetAttributeUsage): Made private and changed to work without
9220 (GetIndexerAttributeValue): Don't crash.
9221 (GetConditionalAttributeValue): Ditto.
9222 (GetClsCompliantAttributeValue): Ditto.
9223 (ExtractSecurityPermissionSet): All attributes exceptions are
9225 (GetPropertyValue): New helper.
9226 (GetMethodImplOptions): New method.
9227 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9228 some missing properties.
9230 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9231 (Method.ApplyAttributeBuilder): Updated.
9233 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9236 2005-02-28 Raja R Harinath <rharinath@novell.com>
9239 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9240 non-simple types (array, pointer, reference).
9242 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9244 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9246 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9248 (Method.CheckBase): Catch wrong destructor here.
9249 (MethodData.Define): Add errors 550, 668.
9251 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9253 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9255 * pending.cs (VerifyPendingMethods): Add error 551.
9257 * typemanager.cs (CSharpName): Next error report helper.
9259 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9261 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9262 attributes. Removed useless attribute double check.
9263 It saves almost 2MBs for corlib.
9265 2005-02-25 Raja R Harinath <rharinath@novell.com>
9268 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9269 called twice in case of error.
9271 2005-02-23 Chris Toshok <toshok@ximian.com>
9273 Fix compiler portions of #72827.
9274 * statement.cs (Block.Emit): call Begin/EndScope on the
9275 EmitContext instead of the ILGenerator.
9277 * codegen.cs (EmitContext.BeginScope): new method, call
9278 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9280 (EmitContext.BeginScope): same, but EndScope and CloseScope
9282 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9283 offset and call the superclass's OpenScope(int) with it.
9284 (SymbolWriter.CloseScope): get the current il
9285 offset and call superclass's CloseScope(int) with it.
9287 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9289 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9290 CS1677 for out and ref as well.
9292 * class.cs (Method.Define): Add error CS1599 detection.
9294 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9296 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9298 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9300 * support.cs.cs (ModifierDesc): New helper method.
9302 2005-02-23 Raja R Harinath <rharinath@novell.com>
9303 Abin Thomas <projectmonokochi@rediffmail.com>
9304 Anoob V E <projectmonokochi@rediffmail.com>
9305 Harilal P R <projectmonokochi@rediffmail.com>
9308 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9309 MemberLookup (used for error reporting) actually returns a result.
9310 Fix error report number (122, not 112).
9312 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9313 Anoob V E <projectmonokochi@rediffmail.com>
9314 Harilal P R <projectmonokochi@rediffmail.com>
9317 * pending.cs (PendingImplementation.GetAbstractMethods):
9318 Find NonPublic members too.
9320 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9322 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9325 * class.cs (MethodCore.CheckMethodAgainstBase):
9326 Add error 239 report.
9328 2005-02-21 Raja R Harinath <rharinath@novell.com>
9331 * expression.cs (Invocation.IsApplicable): Make public.
9332 (Invocation.IsParamsMethodApplicable): Likewise.
9333 * delegate.cs (Delegate.VerifyApplicability): Don't use
9334 Invocation.VerifyArgumentCompat for parameter applicability
9335 testing. Use Invocation.IsApplicable and
9336 Invocation.IsParamsMethodApplicable.
9338 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9340 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9342 * class.cs (Operator.Define): Add error 217 report.
9344 2005-02-21 Raja R Harinath <rharinath@novell.com>
9346 * namespace.cs (UsingEntry.Resolve): Undo change below.
9348 2005-02-21 Raja R Harinath <rharinath@novell.com>
9351 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9352 disable the error message when the extended MemberLookup also
9354 (Expression.MemberLookupFinal): Update.
9355 (SimpleName.DoSimpleNameResolve): Update.
9356 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9357 Don't use MemberLookupFinal.
9358 (New.DoResolve): Update.
9359 (BaseAccess.CommonResolve): Update.
9361 2005-02-21 Raja R Harinath <rharinath@novell.com>
9364 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9365 occured previously, don't resolve again.
9367 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9370 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9371 argument. Call ResolveAttributeUsage for unresolved.
9372 when types doesn't match ctor arguments.
9374 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9375 for nested attribute classes.
9376 (Class.attribute_usage): Removed.
9377 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9378 for attribute class.
9380 * ecore.cs (IsAttribute): Removed.
9382 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9384 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9386 (attribute_types): Removed.
9387 (EmitCode): Global attributes are emited as the latest.
9389 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9391 * class.cs (EmitFieldInitializers): Don't emit field initializer
9392 for default values when optimilization is on.
9394 * constant.cs (Constant.IsDefaultValue): New property.
9396 * driver.cs: Add /optimize handling.
9400 * literal.cs: Implement new IsDefaultValue property.
9402 * rootcontext.cs (Optimize): New field, holds /optimize option.
9404 2005-02-18 Raja R Harinath <rharinath@novell.com>
9406 Fix crasher in re-opened #72347.
9407 * namespace.cs (Namespace.Lookup): Return null if
9408 DeclSpace.DefineType returns null.
9411 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9413 2005-02-18 Raja R Harinath <rharinath@novell.com>
9415 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9416 now returns null if it cannot resolve to an lvalue.
9417 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9418 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9419 returned null. Remove check for SimpleName.
9420 (EventExpr.DoResolveLValue): New.
9421 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9422 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9424 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9426 (Unary.ResolveOperator): Move CS0211 check ...
9427 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9429 (Unary.DoResolveLValue): Simplify.
9430 (AddressOf.DoResolveLValue): New.
9431 (ArrayAccess.DoResolveLValue): New.
9433 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9435 * attribute.cs (Attribute.Resolve): Add arguments casting for
9436 when types doesn't match ctor arguments.
9438 2005-02-16 Raja R Harinath <rharinath@novell.com>
9440 Fix parts of #63202.
9441 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9442 lookup of operator in base type. Ensure that all checks happen
9443 when the operator resolves to an "op_..." method.
9445 2005-02-15 Raja R Harinath <rharinath@novell.com>
9448 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9449 'ignore_cs0104' parameter. Pass it to ...
9450 (NamespaceEntry.Lookup): ... this.
9451 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9452 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9453 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9454 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9455 Update. Request that cs0104 errors be ignored.
9456 (ComposedCast.ResolveAsTypeStep): Update.
9458 2005-02-14 Raja R Harinath <rharinath@novell.com>
9461 * expression.cs (Invocation.BetterFunction): Remove support for
9462 comparing virtual functions and their overrides.
9463 (Invocation.IsOverride): New.
9464 (Invocation.OverloadResolve): Don't consider 'override' functions
9465 during candidate selection. Store them in a lookaside list.
9466 If the selected method is a 'virtual' function, use the list to
9467 find any overrides that are closer to the LHS type.
9469 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9471 * expression.cs (New.DoResolve): Add complex core type reduction.
9472 (New.Constantify): Converts complex core type syntax like 'new int ()'
9475 2005-02-14 Raja R Harinath <rharinath@novell.com>
9477 * decl.cs (EntryType.EntryType): New constructor to create an
9478 updated copy of a cache entry.
9479 (MemberCache.AddMethods): Use it.
9480 (MemberCache.ClearDeclaredOnly): Remove.
9481 (MemberCache.MemberCache): Update.
9483 2005-02-11 Miguel de Icaza <miguel@novell.com>
9485 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9486 variable. This one is represents the actual low-level declaration
9487 of the method, as opposed to the semantic level `IsStatic'.
9489 An anonymous method which is hosted into a static method might be
9490 actually an instance method. IsStatic would reflect the
9491 container, while MethodIsStatic represents the actual code
9494 * expression.cs (ParameterReference): Use the new MethodIsStatic
9495 instead of IsStatic.
9497 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9498 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9499 set on the current EmitContext.
9501 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9502 resolve our casted expression as an LValue. This triggers the
9503 proper LValue processing that is later required by Assign.
9507 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9509 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9511 C# 2.0 Fixed buffer implementation
9513 * anonymous.cs: Update after RegisterHelperClass renaming.
9515 * attribute.cs (AttributeTester.fixed_buffer_cache):
9516 Cache of external fixed buffers.
9517 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9518 implementation if field is fixed buffer else null.
9521 (TypeContainer.AddField): Accept FieldMember instead of Field.
9522 (FieldBase.IsFieldClsCompliant): Extracted code from
9523 VerifyClsCompliance descendant customization.
9524 (FixedField): New class handles fixed buffer fields.
9525 (FixedFieldExternal): Keeps information about imported fixed
9527 (IFixedField): Make access to internal or external fixed buffer
9530 * cs-parser.jay: Add fixed buffer parsing.
9532 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9535 * expression.cs (Indirection): Extended implementation to accept
9537 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9538 (ElementAccess.MakePointerAccess): Get type as parameter.
9539 (DoResolve): Add fixed buffer field expression conversion.
9540 (DoResolveLValue): Ditto.
9541 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9542 (ArrayPtr): Derives from FixedBufferPtr.
9543 (ArrayPtr.Emit): Add extra emit for array elements.
9545 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9547 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9548 for compiler generated types.
9549 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9551 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9552 and consume less memory.
9553 (Fixed.Resolve): Add fixed buffer case.
9555 * typemanager.cs (compiler_generated_attr_ctor,
9556 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9557 (HasElementType): Add our own implementation to work on every
9560 2005-02-11 Miguel de Icaza <miguel@novell.com>
9562 * anonymous.cs (CaptureContext): Track whether `this' has been
9565 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9566 only captured `this' if it was implicitly done (instance
9567 methods/variables were used).
9569 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9570 `this' must be captured.
9572 2005-01-30 Miguel de Icaza <miguel@novell.com>
9574 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9575 is null it means that there has been no need to capture anything,
9576 so we just create a sibling.
9578 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9580 Just a partial fix. The other half is fairly elusive.
9582 2005-02-10 Raja R Harinath <rharinath@novell.com>
9584 Fix #52586, cs0121-4.cs.
9585 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9586 and return a hashtable.
9587 (MemberCache.ClearDeclaredOnly): New.
9588 (MemberCache.MemberCache): Update to change. Make a deep copy of
9589 the method_hash of a base type too.
9590 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9591 type methods. Overwrite entries with the same MethodHandle so
9592 that the ReflectedType is correct. The process leaves in base
9593 virtual functions and their overrides as distinct entries.
9594 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9595 matters since it was boxed in a ArrayList before.
9596 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9598 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9599 case of a virtual function and its override (choose the overload
9601 (Invocation.OverloadResolve): Avoid 'override' members during
9602 'applicable_type' calculation.
9604 2005-02-09 Raja R Harinath <rharinath@novell.com>
9606 Combine two near-redundant caches.
9607 * typemanager.cs (method_params): Rename from method_internal_params.
9608 (TypeManager.GetParameterData): New. Replace
9609 Invocation.GetParameterData.
9610 (TypeManager.LookupParametersByBuilder): Remove.
9611 * expression.cs (Invocation.method_parameter_cache): Remove.
9612 (Invocation.GetParameterData): Remove.
9614 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9617 2005-02-08 Raja R Harinath <rharinath@novell.com>
9620 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9621 TypeManager.multicast_delegate_type is null, resolve it by looking
9622 up "System.MulticastDelegate".
9623 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9625 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9626 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9627 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9630 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9631 (LabeledStatement.AddReference): New. Set 'referenced'.
9632 (Goto.Resolve): Use it.
9634 2005-02-05 John Luke <john.luke@gmail.com>
9636 * driver.cs: remove duplicate -doc line in Usage ()
9638 2005-02-04 Raja R Harinath <rharinath@novell.com>
9640 * location.cs (Location.AddFile): Fix CS2002 error report.
9642 2005-02-02 Martin Baulig <martin@ximian.com>
9644 * delegate.cs (Delegate.DefineType): Report an internal error if
9645 TypeManager.multicast_delegate_type is null. See bug #72015 for
9648 2005-02-02 Raja R Harinath <rharinath@novell.com>
9650 Fix a crasher in a variant of #31984.
9651 * const.cs (Constant.CheckBase): New override that defers the
9652 new-or-override check in case the base type hasn't been populated
9654 (Constant.Define): Ensure the new-or-override check is performed.
9656 2005-02-01 Duncan Mak <duncan@ximian.com>
9658 * const.cs (LookupConstantValue): Check that `ce' is not null
9659 before calling GetValue ().
9661 2005-02-01 Raja R Harinath <rharinath@novell.com>
9663 Fix test-334.cs (#69519).
9664 * cs-parser.jay (using_alias_directive): Pass in an expression to
9665 NamespaceEntry.UsingAlias.
9666 (using_namespace_directive): Pass in an expression to
9667 NamespaceEntry.Using.
9668 (namespace_name): Don't flatten to a string.
9669 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9670 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9672 (NamespaceEntry.UsingEntry): Likewise.
9673 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9675 (NamespaceEntry.LookupForUsing): Remove.
9676 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9678 (NamespaceEntry.Lookup): Remove support for dotted names.
9680 2005-02-01 Raja R Harinath <rharinath@novell.com>
9682 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9684 (NamespaceEntry.ImplicitParent): Compute on demand.
9685 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9686 parallels the current.
9687 (NamespaceEntry.LookupForUsing): Use it.
9688 (NamespaceEntry.Lookup): If the current namespace-entry is
9689 implicit, don't search aliases and using tables.
9691 2005-02-01 Raja R Harinath <rharinath@novell.com>
9694 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9696 (TypeContainer.BaseCache): Compute on demand.
9697 (TypeContainer.FindMembers): Define constants and types if they're
9698 not already created.
9699 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9701 * const.cs (Constant.Define): Make idempotent.
9703 2005-01-29 Miguel de Icaza <miguel@novell.com>
9705 * pending.cs: Produce better code (no nops produced by using Ldarg
9708 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9709 i - 1' it should be arg + 1.
9713 2005-01-28 Raja R Harinath <rharinath@novell.com>
9715 * attribute.cs (Attribute.CheckAttributeType): Make private
9717 (Attribute.ResolveType): Make virtual.
9718 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9719 handling of RootContext.Tree.Types.
9721 2005-01-27 Raja R Harinath <rharinath@novell.com>
9723 Update attribute-handling to use the SimpleName/MemberAccess
9725 * cs-parser.jay (attribute): Pass in an expression to the
9726 constructors of Attribute and GlobalAttribute.
9727 * attribute.cs (Attribute): Take an expression for the name.
9728 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9729 passed in attribute name expression.
9730 (Attribute.CheckAttributeType): Use it.
9731 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9732 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9733 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9734 argument to prevent error messages if the lookup fails.
9736 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9738 * expression.cs (Indirection): Implemented IVariable interface
9739 to support indirection in AddressOf operator.
9740 (PointerArithmetic.Emit): Add optimalization for case where
9741 result can be precomputed.
9743 2005-01-26 Martin Baulig <martin@ximian.com>
9745 * class.cs (TypeContainer.AttributeTargets): Return the correct
9746 AttributeTargets depending on our `Kind' instead of throwing an
9747 exception; fixes #71632.
9749 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9752 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9755 2005-01-25 Raja R Harinath <rharinath@novell.com>
9758 * expression.cs (MemberAccess.DoResolve): Don't complain with
9759 cs0572 when the LHS of a member access has identical name and type
9762 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9765 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9767 Create custom PermissionSet only for PermissionSetAttribute.
9769 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9772 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9773 delegates in static class.
9775 2005-01-24 Martin Baulig <martin@ximian.com>
9777 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9778 merging an implicit block, just use its reachability.
9780 * statement.cs (Block.Resolve): Make the unreachable code check
9781 work wrt. implicit blocks; see test-337 from #63842.
9783 2005-01-21 Alp Toker <alp@atoker.com>
9785 * cs-parser.jay: destructor_declaration's container is PartialContainer
9786 not Class when partial types are used, so use Kind prop instead of
9789 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9791 * cs-parser.jay: Improve error reporting when an interface
9794 2005-01-20 Dick Porter <dick@ximian.com>
9796 * support.cs: SeekableStreamReader fix from Sandor Dobos
9797 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9798 chars are read. Fixes bug 70369.
9800 2005-01-20 Raja R Harinath <rharinath@novell.com>
9802 * cs-parser.jay (catch_clause): Simplify current_block handling
9805 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9807 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9808 code with ImplicitStandardConversion to handle the implicit
9809 conversion of method groups into valid delegate invocations.
9811 The problem is that in parameter handling we were using this code
9812 path. Fixes bug #64698
9814 2005-01-19 Raja R Harinath <rharinath@novell.com>
9816 * cs-parser.jay: Fix several infelicities.
9817 - Avoid assigning to the parser value stack. Code like
9818 '$3 = null' is unclean. Synthesize a value for the code block
9820 - Avoid using oob_stack for storing location information. Use ...
9821 (_mark_): ... this. New (empty) rule. Saves the current location
9823 (foreach_statement): Avoid using oob_stack for current_block
9824 handling. Use technique used in for_statement and
9825 using_statement. Synthesize a value for the code block to store
9826 additional intermediate information.
9828 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9830 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9831 of a different type is only allowed to private fields of a
9832 containing type, not on fields of a base class.
9834 See test-174.cs and error cs0122-9.cs
9836 2005-01-13 Raja R Harinath <rharinath@novell.com>
9838 Fix test-335.cs (bug #58126).
9839 * cs-parser.jay (argument): Split out non-expression parts of the
9840 rule into 'non_simple_argument'.
9841 (invocation_expression): Support parenthesized invocations with
9842 multiple arguments, and with single non-simple arguments.
9844 2005-01-13 Raja R Harinath <rharinath@novell.com>
9846 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9849 2005-01-12 Raja R Harinath <rharinath@novell.com>
9851 Fix cs0038-1.cs, cs1640-6.cs.
9852 * ecore.cs (Expression.Resolve): Remove special-case for
9853 SimpleName in error-handling.
9854 (Expression.almostMatchedMembers): Relax access permission to
9856 (Expression.MemberLookupFailed): Handle duplicates in
9857 almostMatchedMembers list.
9858 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9859 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9860 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9861 overload if the passed in MemberInfo is a MethodBase.
9863 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9866 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9867 for non-CAS & merge permission sets properly.
9869 2005-01-11 Raja R Harinath <rharinath@novell.com>
9871 Improve standard-compliance of simple name and member access
9872 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9873 * ecore.cs (FullNamedExpression): New abstract base class
9874 for Namespaces and TypeExpressions.
9875 (ResolveFlags.SimpleName): Remove.
9876 (SimpleName): Remove support for dotted names.
9877 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9878 DeclSpace.FindType and DeclSpace.LookupType.
9879 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9880 (Expression.ExprClassName): Make member function.
9881 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9882 a namespace. Remove creation of dotted "SimpleName"s.
9883 (MemberAccess.DoResolve): Likewise.
9884 * decl.cs (DeclSpace.Cache): Make private.
9885 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9886 (DeclSpace.FindType): Update.
9887 (DeclSpace.LookupType): Move here from RootContext. Return a
9888 FullNamedExpression.
9889 * namespace.cs (Namespace): Derive from FullNamedExpression
9890 so that it can be part of expression resolution.
9891 (Namespace.Lookup): Return an FullNamedExpression.
9892 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9894 * rootcontext.cs (NamespaceLookup): Remove.
9895 (LookupType): Move to DeclSpace.
9896 * attribute.cs (CheckAttributeType): Update.
9897 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9898 (FindDocumentedTypeNonArray): Likewise.
9900 2005-01-11 Raja R Harinath <rharinath@novell.com>
9902 Fix cs0509.cs, cs1632.cs.
9903 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9904 is the same as IsInterface.
9905 (TypeContainer.GetClassBases): Likewise.
9906 * statement.cs (LabeledStatement.ig): New field.
9907 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9909 (LabeledStatement.DoEmit): Check that the label was created with
9910 the same ILGenerator.
9912 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9915 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9916 accessors to its properties.
9918 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9919 from accessors to property.
9921 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9924 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9927 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9929 * attribute.cs: Check for null and empty strings.
9931 I have lost another battle to Paolo.
9933 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9936 * class.cs (PropertyMethod): Set Parent field in ctors.
9937 (SetMethod.InternalParameters): Add unsafe switch hack.
9938 Override MarkForDuplicationCheck where it is appropriate.
9940 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
9941 It says whether container allows members with the same name.
9943 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
9944 Removed is_method parameter.
9946 2005-01-06 Duncan Mak <duncan@ximian.com>
9948 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
9949 because the previous change led to incorrect reporting of CS1032
9950 ("Cannot define/undefine preprocessor symbols after first token in
9951 file"). Instead of using `tokens_seen' as the only flag that
9952 triggers CS1040, introduce `comments_seen'. This new flag is used
9953 to signify having seen comments on the current line, so it is
9954 unset after a newline.
9956 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9958 * doc.cs : When searching for a type, find nested type too.
9959 This fixes bug #71040.
9961 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9964 - Warn missing member comment on those classes which also does not
9965 have doc comments. Fixed bug #71041.
9966 - Don't warn missing doc comment on default constructor.
9969 2005-01-06 Duncan Mak <duncan@ximian.com>
9971 * cs-tokenizer.cs (xtoken): After handling traditional C-style
9972 comments, set `tokens_seen' to true. This allows us to detect
9973 misplaced preprocessor directives (i.e. not at the beginning of
9974 the a line, nor after whitespaces). In that case, report error
9975 CS1040. This fixes bug #56460.
9977 * cs-parser.jay (interface_member_declaration): Add checks for
9978 IsExplicitImpl, and report CS0541 error if an interface member is
9979 defined as an explicit interface declaration.
9981 2005-01-06 Marek Safar <marek.safar@seznam.cz>
9984 * class.cs (PropertyMethod): Set Parent field in ctors.
9985 (SetMethod.InternalParameters): Add unsafe switch hack.
9987 * decl.cs (MemberCore.Parent): Cannot be readonly.
9989 2005-01-06 Raja R Harinath <rharinath@novell.com>
9991 * decl.cs (DeclSpace.ResolveType): Remove.
9992 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
9993 Merge in code from ...
9994 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
9995 * class.cs, enum.cs: Update to changes.
9997 2005-01-06 Miguel de Icaza <miguel@ximian.com>
9999 * anonymous.cs: Ensure that we init the scope of our parent if it
10000 has not been initialized yet.
10002 2004-12-30 Duncan Mak <duncan@ximian.com>
10004 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10005 if field.FieldBuilder is null. Fixes #70758.
10007 * convert.cs: Fixed some typos and updated some of the comments.
10008 (ImplicitStandardConversionExists):
10009 (TryImplicitIntConversion): If `target_type' is an interface and
10010 the type of `ic' implements this interface, return true or a new
10011 BoxedCast instead of null. This fixes #70468.
10013 2004-12-29 Duncan Mak <duncan@ximian.com>
10015 * expression.cs (Argument.Emit): Check that Expr is
10016 IMemoryLocation before casting to it, and report CS1510 otherwise.
10020 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10022 * statement.cs (Block.ThisVariable): remove the recursion here, to
10023 make the --profile more sane.
10025 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10027 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10028 assembly, by JB Evain.
10030 2004-12-17 Raja R Harinath <rharinath@novell.com>
10032 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10033 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10034 "parent" refers to enclosing type/class. "base" refers to superclass.
10036 2004-12-17 Raja R Harinath <rharinath@novell.com>
10038 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10039 Ensure that we only have GlobalAttributes.
10040 * attribute.cs (Attribute.Emit): Make non-virtual.
10041 (GlobalAttribute.Emit): Remove.
10042 (Attribute.Resolve): Make virtual.
10043 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10044 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10045 the argument. Don't create one.
10046 (Attribute.GetObsoleteAttribute): Likewise.
10047 (Attribute.GetClsCompliantAttributeValue): Likewise.
10048 * class.cs, decl.cs: Update to changes.
10050 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10052 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10054 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10056 * statement.cs (Foreach.Resolve): Add error 186 report.
10058 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10060 * expression.cs (Conditional.DoResolve): Add warning 429.
10062 * statement.cs (If.Resolve): Add warning 665.
10064 2004-12-16 Raja R Harinath <rharinath@novell.com>
10066 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10067 except when in the parser, and in GlobalAttribute.
10068 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10069 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10070 RootContext.Tree.Types.NamespaceEntry once work is done.
10071 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10072 and resets RootContext.Tree.Types.NamespaceEntry.
10074 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10076 * cs-parser.jay: Don't create a block for every variable.
10078 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10080 * location.cs: Provide extra information.
10082 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10083 variables from the captured environment, it is the ldarg_0.
10085 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10087 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10090 * class.cs: Changed warning level for 169 to avoid developer
10091 displeasure from warning flooding. It will be changed back when they
10092 fix most of current BCL warnings.
10094 * RootContext.cs: Pushed default WarningLevel to 3.
10096 * statement.cs: Removed unused variable.
10098 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10100 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10101 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10102 Add error 502 report.
10103 (StaticClass.DefineType): Add error 441 report.
10104 (Class.AllowedModifiersProp): New virtual property as temporary
10105 extension to AllowedModifiers.
10106 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10107 to share implementation with StaticClass and don't call virtual
10110 * driver.cs (MainDriver): Add error 1558 test.
10112 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10113 report. Moved error 36 test here.
10115 * statement.cs (Throw.Resolve): Add error 724 report.
10117 * typemanager.cs: Add out_attribute_type core type.
10119 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10121 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10123 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10125 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10128 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10130 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10131 Add error 3023 report.
10132 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10134 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10137 2004-12-12 John Luke <john.luke@gmail.com>
10139 * driver.cs (AddArgs): take -- into account when
10140 adding arguments, fixes bug 65710
10142 2004-12-12 Martin Baulig <martin@ximian.com>
10144 * expression.cs (Unary.TryReduceNegative): Added support for
10145 SByteConstant and ByteConstant.
10146 (Unary.Reduce): Check error values from TryReduceNegative().
10148 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10150 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10151 and report exception as error 182.
10153 2004-12-10 Raja R Harinath <rharinath@novell.com>
10155 * driver.cs (Main): Fix message when there are warnings.
10157 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10159 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10161 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10163 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10164 Reduced number of warnings.
10166 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10168 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10170 * driver.cs: Removed message.
10172 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10174 2004-12-08 <vargaz@freemail.hu>
10176 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10178 2004-12-08 Martin Baulig <martin@ximian.com>
10180 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10181 instead of a CS3002 for properties and indexer.
10183 2004-12-08 Martin Baulig <martin@ximian.com>
10185 * decl.cs (MemberName.ToString): Make this work again.
10187 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10189 * attribute.cs (Resolve): Add error 591 detection.
10191 * class.cs (FieldMember.Define): Add error 1547 detection.
10192 (Indexer.Define): Add error 620 detection.
10193 (Operator.Define): Add error 590 detection.
10195 * ecore.cs: Missing argument for error 79.
10197 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10200 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10203 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10206 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10208 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10209 Some operator comments were suppressed.
10210 * doc.cs : Implicit/explicit operator name in doc comments are like
10211 "op_Explicit(type)~returnType", so added suffix handling.
10213 2004-12-07 Martin Baulig <martin@ximian.com>
10216 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10217 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10218 (DeclSpace.ec): New protected field; store the EmitContext here.
10219 (DeclSpace.EmitContext): New public property; moved here from
10221 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10224 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10225 (Enum.Emit): Don't create a new EmitContext.
10227 * delegate.cs (Delegate.DefineType): Always create the
10230 * iterators.cs (Iterators.DefineIterator): Create a new
10231 EmitContext and store it in `ec'.
10233 2004-08-24 Martin Baulig <martin@ximian.com>
10236 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10237 this for accessibility checks.
10238 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10239 IsNestedFamilyAccessible.
10240 (TypeManager.IsSubclassOf): New method, do what the name actually
10243 2004-12-06 Raja R Harinath <rharinath@novell.com>
10245 Fix crash on cs0657-17.cs.
10246 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10247 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10248 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10249 the case where the NamespaceEntry gets overwritten.
10251 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10253 Fixed #69195, #56821
10254 * ecore.cs (ResolveBoolean): Tiny refactoring.
10256 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10257 of right expression resolving when left is false constant and
10258 operator is LogicalAnd OR true constant and operator is LogicalOr.
10260 * statement.cs (ResolveUnreachable): Always reports warning.
10262 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10264 * class.cs: Distinguish between 1721 and 1722 (just a little help
10265 for the programmer).
10267 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10269 * delegate.cs: Only allow this on new versions of the language.
10271 2004-12-02 Duncan Mak <duncan@ximian.com>
10273 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10275 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10276 here as a static method. Take an additional bool out parameter
10277 `must_do_cs1540_check' for signaling to InstanceResolve.
10278 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10279 member field from PropertyExpr class and made it an argument of
10280 the method instead.
10281 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10282 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10283 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10284 and `remove_accessor' as well as InstanceResolve: report CS0122
10289 2004-12-03 Raja R Harinath <rharinath@novell.com>
10291 Fix test-327.cs, test-328.cs, and put in early infrastructure
10292 for eventually fixing #52697.
10293 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10294 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10295 from other methods.
10296 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10297 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10298 (VerifyUsing, error246): Update.
10299 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10300 'NamespaceEntry.LookupNamespaceOrType'.
10302 2004-12-03 Martin Baulig <martin@ximian.com>
10304 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10305 method as our child, call AnonymousMethod.Compatible() on it.
10307 2004-12-03 Raja R Harinath <rharinath@novell.com>
10309 Disable XML documentation support in 'basic' profile.
10310 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10311 Redirect XmlElement to System.Object.
10312 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10313 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10314 * mcs.exe.sources: Add doc-bootstrap.cs.
10315 * doc-bootstrap.cs: New file. Contains empty stub implementation
10318 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10320 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10321 comments are allowed.
10323 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10325 * delegate.cs: Add checks for subtypes in paramaters and return values
10326 in VerifyMethod () to add support for Covariance/Contravariance
10329 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10331 * report.cs: Remove extra closing parenthesis.
10333 * convert.cs (Error_CannotImplicitConversion): If the name of the
10334 types are the same, provide some extra information.
10336 * class.cs (FieldBase): Use an unused bit field from the field to
10337 encode the `has_offset' property from the FieldMember. This saves
10338 a couple of Ks on bootstrap compilation.
10340 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10341 method as our child, return the AnonymousMethod resolved
10344 * expression.cs (New.DoResolve): Allow return values from
10345 NewDelegate to also include AnonymousMethods.
10349 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10352 * attribute.cs (Resolve): Improved implementation of params
10353 attribute arguments.
10355 * support.cs (ParameterData): Add HasParams to be faster.
10357 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10359 all things are for /doc support:
10361 * doc.cs: new file that supports XML documentation generation.
10362 * mcs.exe.sources: added doc.cs.
10364 Handle /doc command line option.
10365 Report error 2006 instead of 5 for missing file name for /doc.
10366 Generate XML documentation when required, after type resolution.
10368 Added support for picking up documentation (/// and /** ... */),
10369 including a new XmlCommentState enumeration.
10371 Added lines to fill Documentation element for field, constant,
10372 property, indexer, method, constructor, destructor, operator, event
10373 and class, struct, interface, delegate, enum.
10374 Added lines to warn incorrect comment.
10376 Added Documentation field (passed only when /doc was specified).
10378 Added DocComment, DocCommentHeader, GenerateDocComment() and
10379 OnGenerateDocComment() and some supporting private members for
10380 /doc feature to MemberCore.
10382 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10384 Added overriden DocCommentHeader.
10386 Added overriden DocCommentHeader and GenerateDocComment().
10388 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10390 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10391 unwrapping the enumeration values, chain to
10392 DoConstantNumericPromotions again, so we can promote things to the
10393 fundamental types (takes care of enums that are bytes, sbytes).
10397 2004-12-01 Raja R Harinath <rharinath@novell.com>
10399 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10400 Fix long-standing bug in type-lookup. Use FindType instead of
10401 LookupType when ec.ResolvingTypeTree.
10402 (Attribute.ResolveType, Attribute.Resolve)
10403 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10405 (Attributes.Search): Remove internal version. Update.
10406 (Attributes.SearchMulti): Update.
10407 (Attributes.GetClsCompliantAttribute): Remove.
10408 (Attributes.GetIndexerNameAttribute): Remove.
10409 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10410 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10411 * class.cs (Indexer.Define): Likewise.
10413 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10416 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10417 MarshallByReference members access.
10419 * expression.cs: Use CheckMarshallByRefAccess;
10420 Better error CS0197 message.
10422 * report.cs: Print whole related error message.
10424 2004-11-30 Raja R Harinath <rharinath@novell.com>
10426 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10427 the current directory to help debugging.
10429 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10431 * class (GetClassBases): Better error 60 report.
10432 (EventProperty): Disabled warning 67 detection.
10434 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10437 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10439 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10442 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10445 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10447 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10449 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10451 * attribute.cs (Attribute.Resolve): Refine error reporting and
10452 report a cs0117 if the identifier does not exist, to distinguish
10453 from 0617 which is a miss-use of the actual identifier.
10455 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10456 between cs0070 and cs0079.
10458 * class.cs (MemberBase.DoDefine): When reporting a wrong
10459 accessibility level, we use MethodCore to compare instead of
10460 Method (this was a regression in some refactoring effort).
10462 So now we correctly report cs0056 again.
10464 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10465 testing the target_type (which was known to be object_type) and
10466 not the source type (which is anonymous_method).
10468 Fixed reporting of error cs1660.
10470 * expression.cs (UserCast.Source): Expose the underlying cast.
10472 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10473 allowed types to find a match to int32 first (most common).
10475 In addition, it ignores any ImplicitUserConversions that did an
10476 internal implicit conversion (as the switch statement allows only
10477 one integral conversion to exist).
10479 * class.cs (PartialContainer.Create): rename `name' to
10480 `member_name' for clarity. Then replace the string calls with a
10481 call to MemberName.GetPartialName, as now using
10482 MemberName.ToString is an error (this is due to the side effects
10483 it had, that were fixed in the past).
10485 This will restore the error reporting on a number of partial class
10486 errors that were missusing this (and getting an exception as a
10487 results, which is now just a plain textual warning, because
10488 yyparse debug output would crash otherwise).
10490 2004-11-26 Raja R Harinath <rharinath@novell.com>
10492 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10494 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10496 * rootcontext.cs (LookupType): Make sure to cache lookups that
10497 don't give us a negative result. This saves about 5% of corlib
10500 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10502 * report.cs (AbstractMessage.Print): messages are sent to stderr
10504 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10505 non-interface in the list of interfaces (at this point, either
10506 parent was properly set, or a base class is being listed in the
10507 interfaces section).
10509 This flags error 1722, and resolves the crash from bug 69259.
10511 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10513 * statement.cs (Using.EmitExpressionFinally): make this work right
10514 for valuetypes. Fixes 69926.
10516 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10518 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10519 converted to an enum" here, before we try to change the underlying
10520 type. This code exists, but it is a different code path than the
10521 one used while encoding constants.
10523 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10524 old bug: when converting from the null literal to a pointer,
10525 return an EmptyCast, not the NullLiteral.
10527 This fixes #69921, the recent null_type changes probably made this
10528 bug more prominent.
10530 (ImplicitReferenceConversionExists): In addition, resynchronized
10531 the code here, so it matches the same code in
10532 ImplicitReferenceConversionExists for the `from any class-type S
10533 to any interface-type T'.
10536 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10538 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10540 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10542 * cs-parser.jay: Use verbosity accordingly.
10544 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10546 * expression.cs (Unary.ResolveOperator): Do not report warning;
10547 AddressOf reads from variable.
10549 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10551 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10555 * attribute.cs (Attributable): Removed CheckTargets.
10556 (Attributes.Emit): Explicit attribute targets are tested here.
10558 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10559 not enabled for interfaces.
10561 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10562 (GetAssemblyName): Ouch next bug there.
10564 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10566 * expression.cs: Error 275 added.
10568 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10570 Fix bug #69177 (Implemented decimal constant support)
10572 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10573 (BinaryFold): Add DecimalConstant.
10575 * const.cs (Define): Decimal constant
10577 (ChangeType): Add decimal type handling.
10578 (LookupConstantValue): Don't set value for decimal type but
10579 emit DecimalConstantAttribute. Needed for constant optimization.
10581 * constant.cs (ToDecimal): New method.
10582 (ConvertToDecimal): New method.
10583 (IntConstant): Implemented ConvertToDecimal.
10584 (DecimalConstant.Emit): Emit optimized version for decimals in
10587 * expression.cs (ResolveOperator): Changed order of constant
10588 reduction to work correctly with native types which have
10589 overloaded operators.
10590 (ResolveMemberAccess): Extract constant value from attribute
10593 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10595 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10596 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10597 (ChangeType): Decimal is special.
10598 (TypeToCoreType): Add decimal type.
10600 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10602 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10605 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10607 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10610 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10612 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10614 * pending.cs (PendingImplementation): Grab only interfaces.
10616 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10618 * statement.cs (ForeachHelperMethods): Add location member and
10619 error 202 detection.
10621 2004-11-19 Raja R Harinath <rharinath@novell.com>
10623 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10624 automatically handled by executable.make.
10625 (PROGRAM): Make profile-specific.
10627 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10629 * expression.cs (DoResolveBase): Fixed wrong warning for out
10632 2004-11-18 Martin Baulig <martin@ximian.com>
10634 Merged latest changes into gmcs. Please keep this comment in
10635 here, it makes it easier for me to see what changed in MCS since
10636 the last time I merged.
10638 2004-11-17 Raja R Harinath <rharinath@novell.com>
10640 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10641 (TypeHandle.GetMemberCache): New.
10642 (TypeHandle.TypeHandle): Update.
10643 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10644 (TypeManager.LookupParentInterfacesCache):
10645 Rename from LookupInterfaceCache. Optimize slightly.
10646 (TypeManager.MemberLookup_FindMembers): Update.
10647 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10648 multi-type variant.
10649 (AddCacheContents): Rename from AddHashtable.
10650 * class.cs (TypeContainer.parent_container): Remove.
10651 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10652 (TypeContainer.DoDefineMembers): Don't initialize it.
10653 Update to name changes.
10655 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10657 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10658 that factors the code to check access modifiers on override.
10660 (PropertyBase): Use the code here.
10662 Patch from Lluis S'anchez, fixes bug #69361.
10664 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10666 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10667 routine that is used to report the use of a captured variable
10668 whose address has been taken.
10670 There are two checks: one when variables are being captured and
10671 the other check is when the address of a variable is taken.
10673 (because an anonymous methods might be resolved before *or* after
10674 the address has been taken) and
10676 * expression.cs (Conditional.DoResolve): Remove the special
10677 casing that Martin added to trueExpr and falseExpr being both
10678 NullLiteral. We get the right behavior now just by introducing
10679 the null_type into the compiler.
10681 * convert.cs (ExplicitConversion): Change the code to use
10682 null_type instead of testing `expr is NullLiteral'.
10683 (ImplicitConversionStandard): use null_type too.
10684 (ImplicitReferenceConversionExists): use null_type too.
10685 (ImplicitReferenceConversion): use null_type too.
10687 * literal.cs: The type of `NullLiteral' is now null_type instead
10689 (Resolve): Set the type here.
10691 * typemanager.cs: Introduce null_type.
10693 2004-11-17 Martin Baulig <martin@ximian.com>
10695 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10696 direction, like FindMembers() does. Fixes #69546, testcase is in
10699 2004-11-16 Martin Baulig <martin@ximian.com>
10701 This is based on a patch from Marek Safar, see bug #69082.
10702 Fixes bugs #63705 and #67130.
10704 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10705 method; create a MemberCache for an interface type and cache the
10708 * decl.cs (IMemberContainer.ParentContainer): Removed.
10709 (IMemberContainer.ParentCache): New property.
10710 (MemberCache.SetupCacheForInterface): Removed.
10711 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10712 to create a cache for an interface's "parent".
10714 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10717 2004-11-16 Martin Baulig <martin@ximian.com>
10719 Merged back from gmcs; these changes already went into gmcs a
10720 couple of weeks ago.
10723 (TypeManager.AddUserType): Removed the `ifaces' argument.
10724 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10726 (TypeManager.AddUserInterface): Removed.
10727 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10729 (TypeManager.GetInterfaces): Likewise.
10730 (TypeManager.GetExplicitInterfaces): Likewise.
10732 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10734 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10735 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10737 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10739 * statement.cs: Avoid adding bools to a hashtable.
10741 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10743 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10744 calling an unsafe method from a safe location.
10746 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10749 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10751 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10753 * namespace.cs (VerifyUsing): use GetPartialName instead of
10756 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10758 * statement.cs (Return.Resolve): Fix regression in typo: if
10759 `in_exc', we have to request a NeedReturnLabel, this was a typo
10760 introduced in the anonymous method check-in. Fixes #69131.
10762 * Indexers were using the ShortName when defining themselves,
10763 causing a regression in the compiler bootstrap when applying the
10764 patch from 2004-11-02 (first part), now they use their full name
10765 and the bug is gone.
10767 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10769 * driver.cs: Strip the path from the names of embedded resources. Fixes
10772 2004-11-04 Raja R Harinath <rharinath@novell.com>
10774 Fix error message regression: cs0104-2.cs.
10775 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10776 (AliasEntry.Resolve): Update.
10777 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10779 (RootContext.LookupType): Update.
10781 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10783 * cs-parser.jay: Add support for handling accessor modifiers
10784 * class: Add support port accessor modifiers and error checking,
10785 define PropertyMethod.Define as virtual (not abstract anymore)
10786 * ecore.cs: Add checking for proeprties access with access modifiers
10787 * iterators.cs: Modify Accessor constructor call based in the modified
10789 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10791 * expression.cs (StringConcat): Handle being called twice,
10792 as when we have a concat in a field init with more than two
10795 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10797 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10798 special case explicit implementations, we should always produce
10799 the .property or .event declaration.
10801 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10802 since it will not return correct data if people use this
10803 unresolved in the presence of using statements (see test-313).
10805 * class.cs (MethodData.Define): If we are an explicit interface
10806 implementation, set the method name to the full name of the
10807 interface plus the name of the method.
10809 Notice that using the method.MethodName.GetFullName() does not
10810 work, as it will only contain the name as declared on the source
10811 file (it can be a shorthand in the presence of using statements)
10812 and not the fully qualifed type name, for example:
10816 class D : ICloneable {
10817 object ICloneable.Clone () {
10821 Would produce a method called `ICloneable.Clone' instead of
10822 `System.ICloneable.Clone'.
10824 * namespace.cs (Alias.Resolve): Use GetPartialName.
10826 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10828 * cs-parser.jay: Add error 1055 report.
10830 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10832 * assign.cs (Assign.DoResolve): Only do the transform of
10833 assignment into a New if the types are compatible, if not, fall
10834 through and let the implicit code deal with the errors and with
10835 the necessary conversions.
10837 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10839 * cs-parser.jay: Add error 1031 report.
10841 * cs-tokenizer.cs: Add location for error 1038.
10843 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10845 * cs-parser.jay: Add error 1016 report.
10847 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10849 * cs-parser.jay: Add errors 1575,1611 report.
10851 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10853 * cs-parser.jay: Add error 1001 report.
10855 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10858 * attribute.cs (GetMarshal): Add method argument for
10859 caller identification.
10861 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10862 agument for GetMarshal and RuntimeMissingSupport.
10864 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10866 * attribute.cs (ExtractSecurityPermissionSet): Removed
10867 TypeManager.code_access_permission_type.
10869 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10871 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10873 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10874 for obsolete use of a variable here. Fixes regression on errors
10875 cs0619-25 and cs0619-26.
10877 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10879 Fix #62358, implemented security attribute encoding.
10881 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10882 Tests permitted SecurityAction for assembly or other types.
10883 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10884 data from SecurityPermissionAttribute to PermisionSet class.
10886 * class.cs (ApplyAttributeBuilder): Added special handling
10887 for System.Security.Permissions.SecurityAttribute based types.
10889 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10890 special handling for System.Security.Permissions.SecurityAttribute
10893 * enum.cs (ApplyAttributeBuilder): Added special handling
10894 for System.Security.Permissions.SecurityAttribute based types.
10896 * parameter.cs (ApplyAttributeBuilder): Added special handling
10897 for System.Security.Permissions.SecurityAttribute based types.
10899 * rootcontext.cs: Next 2 core types.
10901 * typemanager.cs (TypeManager.security_permission_attr_type):
10902 Built in type for the SecurityPermission Attribute.
10903 (code_access_permission_type): Build in type.
10905 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10907 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10908 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10909 all of this information into
10910 EmitContext.EmitCapturedVariableInstance.
10912 * codegen.cs (EmitCapturedVariableInstance): move here the
10913 funcionality of emitting an ldarg.0 in the presence of a
10914 remapping. This centralizes the instance emit code.
10916 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10917 then emit a load of this: it means that we have reached the
10918 topmost ScopeInfo: the one that contains the pointer to the
10919 instance of the class hosting the anonymous method.
10921 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10922 captures to the topmost CaptureContext.
10924 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10926 * expression.cs (LocalVariableReference): Move the knowledge about
10927 the iterators into codegen's EmitCapturedVariableInstance.
10929 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10931 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10932 all code paths return a value from an anonymous method (it is the
10933 same as the 161 error, but for anonymous methods).
10935 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10937 The introduction of anonymous methods in the compiler changed
10938 various ways of doing things in the compiler. The most
10939 significant one is the hard split between the resolution phase
10940 and the emission phases of the compiler.
10942 For instance, routines that referenced local variables no
10943 longer can safely create temporary variables during the
10944 resolution phase: they must do so from the emission phase,
10945 since the variable might have been "captured", hence access to
10946 it can not be done with the local-variable operations from the runtime.
10950 (Block.Flags): New flag `IsTopLevel' to indicate that this block
10951 is a toplevel block.
10953 (ToplevelBlock): A new kind of Block, these are the blocks that
10954 are created by the parser for all toplevel method bodies. These
10955 include methods, accessors and anonymous methods.
10957 These contain some extra information not found in regular blocks:
10958 A pointer to an optional CaptureContext (for tracking captured
10959 local variables and parameters). A pointer to the parent
10962 (Return.Resolve): Catch missmatches when returning a value from an
10963 anonymous method (error 1662).
10964 Invoke NeedReturnLabel from the Resolve phase instead of the emit
10967 (Break.Resolve): ditto.
10969 (SwitchLabel): instead of defining the labels during the
10970 resolution phase, we now turned the public ILLabel and ILLabelCode
10971 labels into methods called GetILLabelCode() and GetILLabel() that
10972 only define the label during the Emit phase.
10974 (GotoCase): Track the SwitchLabel instead of the computed label
10975 (its contained therein). Emit the code by using
10976 SwitchLabel.GetILLabelCode ().
10978 (LocalInfo.Flags.Captured): A new flag has been introduce to track
10979 whether the Local has been captured or not.
10981 (LocalInfo.IsCaptured): New property, used to tell whether the
10982 local has been captured.
10984 * anonymous.cs: Vastly updated to contain the anonymous method
10987 The main classes here are: CaptureContext which tracks any
10988 captured information for a toplevel block and ScopeInfo used to
10989 track the activation frames for various local variables.
10991 Each toplevel block has an optional capture context associated
10992 with it. When a method contains an anonymous method both the
10993 toplevel method and the anonymous method will create a capture
10994 context. When variables or parameters are captured, they are
10995 recorded on the CaptureContext that owns them, for example:
10999 MyDelegate d = delegate {
11004 Here `a' will be recorded as captured on the toplevel
11005 CapturedContext, the inner captured context will not have anything
11006 (it will only have data if local variables or parameters from it
11007 are captured in a nested anonymous method.
11009 The ScopeInfo is used to track the activation frames for local
11010 variables, for example:
11012 for (int i = 0; i < 10; i++)
11013 for (int j = 0; j < 10; j++){
11014 MyDelegate d = delegate {
11019 At runtime this captures a single captured variable `i', but it
11020 captures 10 different versions of the variable `j'. The variable
11021 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11022 recorded on a child.
11024 The toplevel ScopeInfo will also track information like the `this'
11025 pointer if instance variables were referenced (this is necessary
11026 as the anonymous method lives inside a nested class in the host
11027 type of the method).
11029 (AnonymousMethod): Expanded to track the Toplevel, implement
11030 `AnonymousMethod.Compatible' to tell whether an anonymous method
11031 can be converted to a target delegate type.
11033 The routine now also produces the anonymous method content
11035 (AnonymousDelegate): A helper class that derives from
11036 DelegateCreation, this is used to generate the code necessary to
11037 produce the delegate for the anonymous method that was created.
11039 * assign.cs: API adjustments for new changes in
11040 Convert.ImplicitStandardConversionExists.
11042 * class.cs: Adjustments to cope with the fact that now toplevel
11043 blocks are of type `ToplevelBlock'.
11045 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11046 insteda of standard blocks.
11048 Flag errors if params arguments are passed to anonymous methods.
11050 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11051 `CurrentAnonymousMethod' which points to the current Anonymous
11052 Method. The variable points to the AnonymousMethod class that
11053 holds the code being compiled. It is set in the new EmitContext
11054 created for the anonymous method.
11056 (EmitContext.Phase): Introduce a variable and an enumeration to
11057 assist in enforcing some rules about when and where we are allowed
11058 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11059 only one that enfonces this right now).
11061 (EmitContext.HaveCaptureInfo): new helper method that returns
11062 whether we have a CapturedContext initialized.
11064 (EmitContext.CaptureVariable): New method used to register that a
11065 LocalInfo must be flagged for capturing.
11067 (EmitContext.CapturedParameter): New method used to register that a
11068 parameters must be flagged for capturing.
11070 (EmitContext.CapturedField): New method used to register that a
11071 field must be flagged for capturing.
11073 (EmitContext.HaveCapturedVariables,
11074 EmitContext.HaveCapturedFields): Return whether there are captured
11075 variables or fields.
11077 (EmitContext.EmitMethodHostInstance): This is used to emit the
11078 instance for the anonymous method. The instance might be null
11079 (static methods), this (for anonymous methods that capture nothing
11080 and happen to live side-by-side with the current method body) or a
11081 more complicated expression if the method has a CaptureContext.
11083 (EmitContext.EmitTopBlock): Routine that drives the emission of
11084 code: it will first resolve the top block, then emit any metadata
11085 and then emit the code. The split is done so that we can extract
11086 any anonymous methods and flag any captured variables/parameters.
11088 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11089 during this phase, the ILGenerator should not be used as labels
11090 and local variables declared here might not be accessible to any
11091 code that is part of an anonymous method.
11093 Exceptions to this include the temporary variables that are
11094 created by some statements internally for holding temporary
11097 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11100 (EmitContext.TemporaryReturn): This method is typically called
11101 from the Emit phase, and its the only place where we allow the
11102 ReturnLabel to be defined other than the EmitMeta. The reason is
11103 that otherwise we would have to duplicate a lot of logic in the
11104 Resolve phases of various methods that today is on the Emit
11107 (EmitContext.NeedReturnLabel): This no longer creates the label,
11108 as the ILGenerator is not valid during the resolve phase.
11110 (EmitContext.EmitThis): Extended the knowledge in this class to
11111 work in anonymous methods in addition to iterators.
11113 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11114 code is necessary on the stack to access the instance to a local
11115 variable (the variable will be accessed as a field).
11117 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11118 EmitContext.EmitAddressOfParameter): Routines to support
11119 parameters (not completed at this point).
11121 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11122 will also remove the parameters.
11124 * convert.cs (Convert): Define a `ConstantEC' which points to a
11125 null. This is just to prefity some code that uses
11126 ImplicitStandardConversion code and do not have an EmitContext
11129 The idea is to flag explicitly that at that point in time, it is
11130 known that the conversion will not trigger the delegate checking
11131 code in implicit conversions (which requires a valid
11134 Everywhere: pass new EmitContext parameter since
11135 ImplicitStandardConversionExists now requires it to check for
11136 anonymous method conversions.
11138 (Convert.ImplicitStandardConversionExists): If the type of an
11139 expression is the anonymous_method_type, and the type is a
11140 delegate, we invoke the AnonymousMethod.Compatible method to check
11141 whether an implicit conversion is possible.
11143 (Convert.ImplicitConversionStandard): Only do implicit method
11144 group conversions if the language level is not ISO_1.
11146 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11147 MethodInfo for the Invoke method. used by Delegate and
11150 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11151 method conversions if the target type is a delegate.
11153 Removed extra debugging nops.
11155 (LocalVariableReference): Turn the `local_info' into a public
11158 Add `prepared' field, the same hack used for FieldExprs to cope
11159 with composed assignments, as Local variables do not necessarily
11160 operate purely on the stack as they used to: they can be captured
11163 Add `temp' for a temporary result, like fields.
11165 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11167 It now copes with Local variables that are captured and emits the
11168 proper instance variable to load it from a field in the captured
11171 (ParameterReference.DoResolveBase): During the resolve phase,
11172 capture parameters if we are in an anonymous method.
11174 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11175 anonymous method, use the EmitContext helper routines to emit the
11176 parameter reference.
11178 * iterators.cs: Set RemapToProxy to true/false during the
11181 * parameters.cs (GetParameterByName): New helper method.
11183 * typemanager.cs (anonymous_method_type) a new type that
11184 represents an anonyous method. This is always an internal type,
11185 used as a fencepost to test against the anonymous-methodness of an
11188 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11190 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11192 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11194 2004-10-18 Martin Baulig <martin@ximian.com>
11196 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11197 `Type' directly, but call ResolveType() on it.
11198 (Catch.Resolve): Likewise.
11199 (Foreach.Resolve): Likewise.
11201 2004-10-18 Martin Baulig <martin@ximian.com>
11203 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11204 `Type' directly, but call ResolveType() on it.
11205 (Probe.DoResolve): Likewise.
11206 (ArrayCreation.LookupType): Likewise.
11207 (TypeOf.DoResolve): Likewise.
11208 (SizeOf.DoResolve): Likewise.
11210 2004-10-18 Martin Baulig <martin@ximian.com>
11212 * expression.cs (Invocation.BetterFunction): Put back
11213 TypeManager.TypeToCoreType().
11215 2004-10-18 Raja R Harinath <rharinath@novell.com>
11217 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11220 2004-10-18 Martin Baulig <martin@ximian.com>
11222 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11223 `Type' directly, but call ResolveType() on it.
11225 2004-10-18 Martin Baulig <martin@ximian.com>
11227 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11228 `Type' directly, but call ResolveType() on it.
11229 (MemberBase.DoDefine): Likewise.
11231 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11232 `Type' directly, but call ResolveType() on it.
11233 (ComposedCast.DoResolveAsTypeStep): Likewise.
11235 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11236 `Type' directly, but call ResolveType() on it.
11238 2004-10-17 John Luke <john.luke@gmail.com>
11240 * class.cs (Operator.GetSignatureForError): use CSharpName
11242 * parameter.cs (Parameter.GetSignatureForError): Returns
11243 correct name even if was not defined.
11245 2004-10-13 Raja R Harinath <rharinath@novell.com>
11248 * class.cs (TypeContainer.EmitContext): New property.
11249 (DefineNestedTypes): Create an emitcontext for each part.
11250 (MethodCore.DoDefineParameters): Use container's emitcontext.
11251 Pass type array to InternalParameters.
11252 (MemberBase.DoDefine): Use container's emitcontext.
11253 (FieldMember.Define): Likewise.
11254 (Event.Define): Likewise.
11255 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11256 Pass type array to InternalParameters.
11257 (SetIndexerMethod.GetParameterInfo): Likewise.
11258 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11259 * delegate.cs (Define): Pass emitcontext to
11260 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11261 array to InternalParameters.
11262 * expression.cs (ParameterReference.DoResolveBase): Pass
11263 emitcontext to GetParameterInfo.
11264 (ComposedCast.DoResolveAsTypeStep): Remove check on
11265 ec.ResolvingTypeTree.
11266 * parameter.cs (Parameter.Resolve): Change argument to
11267 EmitContext. Use ResolveAsTypeTerminal.
11268 (Parameter.GetSignature): Change argument to EmitContext.
11269 (Parameters.ComputeSignature): Likewise.
11270 (Parameters.ComputeParameterTypes): Likewise.
11271 (Parameters.GetParameterInfo): Likewise.
11272 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11273 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11274 * support.cs (InternalParameters..ctor): Remove variant that takes
11276 * typemanager.cs (system_intptr_expr): New.
11277 (InitExpressionTypes): Initialize it.
11279 2004-10-12 Chris Toshok <toshok@ximian.com>
11281 * cs-parser.jay: fix location for try_statement and catch_clause.
11283 2004-10-11 Martin Baulig <martin@ximian.com>
11285 * report.cs: Don't make --fatal abort on warnings, we have
11286 -warnaserror for that.
11288 2004-10-07 Raja R Harinath <rharinath@novell.com>
11290 More DeclSpace.ResolveType avoidance.
11291 * decl.cs (MemberCore.InUnsafe): New property.
11292 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11293 with newly created EmitContext.
11294 (FieldMember.Define): Likewise.
11295 * delegate.cs (Delegate.Define): Likewise.
11296 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11297 only if normal name-lookup fails.
11298 (TypeExpr.DoResolve): Enable error-checking.
11299 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11300 (SizeOf.DoResolve): Likewise.
11301 (ComposedCast.DoResolveAsTypeStep): Likewise.
11302 (StackAlloc.DoResolve): Likewise.
11303 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11304 (Block.Unsafe): New property.
11305 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11306 (Unsafe): Set 'unsafe' flag of contained block.
11307 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11308 (Fixed.Resolve): Likewise.
11309 (Catch.Resolve): Likewise.
11310 (Using.ResolveLocalVariableDecls): Likewise.
11311 (Foreach.Resolve): Likewise.
11313 2004-10-05 John Luke <john.luke@gmail.com>
11315 * cs-parser.jay: add location to error CS0175
11317 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11319 * ecore.cs (Expression.Constantity): Add support for turning null
11322 * const.cs (Const.Define): Allow constants to be reference types
11323 as long as the value is Null.
11325 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11327 * namespace.cs (NamespaceEntry.Using): No matter which warning
11328 level is set, check if this namespace name has already been added.
11330 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11332 * expression.cs: reftype [!=]= null should always use br[true,false].
11335 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11338 * attribute.cs: Enum conversion moved to
11339 GetAttributeArgumentExpression to be applied to the all
11342 2004-10-01 Raja R Harinath <rharinath@novell.com>
11344 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11345 * class.c (TypeContainer.DefineType): Flag error if
11346 base types aren't accessible due to access permissions.
11347 * decl.cs (DeclSpace.ResolveType): Move logic to
11348 Expression.ResolveAsTypeTerminal.
11349 (DeclSpace.ResolveTypeExpr): Thin layer over
11350 Expression.ResolveAsTypeTerminal.
11351 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11352 Refactor code into NestedAccess. Use it.
11353 (DeclSpace.NestedAccess): New.
11354 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11355 argument to silence errors. Check access permissions.
11356 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11357 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11358 (Cast.DoResolve): Likewise.
11359 (New.DoResolve): Likewise.
11360 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11361 (TypeOf.DoResolve): Likewise.
11363 * expression.cs (Invocation.BetterConversion): Return the Type of
11364 the better conversion. Implement section 14.4.2.3 more faithfully.
11365 (Invocation.BetterFunction): Make boolean. Make correspondence to
11366 section 14.4.2.2 explicit.
11367 (Invocation.OverloadResolve): Update.
11368 (Invocation): Remove is_base field.
11369 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11370 (Invocation.Emit): Likewise.
11372 2004-09-27 Raja R Harinath <rharinath@novell.com>
11374 * README: Update to changes.
11376 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11378 * cs-parser.jay: Reverted 642 warning fix.
11380 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11383 * decl.cs (FindMemberWithSameName): Indexer can have more than
11386 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11388 * expression.cs (LocalVariableReference.DoResolveLValue):
11389 Do not report warning 219 for out values.
11390 (EmptyExpression.Null): New member to avoid extra allocations.
11392 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11394 * cs-parser.jay: Fix wrong warning 642 report.
11396 * cs-tokenizer.cs (CheckNextToken): New helper;
11397 Inspect next character if is same as expected.
11399 2004-09-23 Martin Baulig <martin@ximian.com>
11401 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11402 (Convert.ImplicitReferenceConversionExists): Likewise.
11404 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11406 * class.cs (Operator.Define): Add error 448 and 559 report.
11408 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11410 * class.cs (MemberBase.IsTypePermitted): New protected
11411 method for checking error CS0610.
11413 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11415 * class.cs (TypeContainer.HasExplicitLayout): New property
11416 Returns whether container has StructLayout attribute set Explicit.
11417 (FieldMember): New abstract class for consts and fields.
11418 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11419 (Field): Reuse FieldMember.
11421 * const.cs (Const): Reuse FieldMember.
11423 * rootcontext.cs: EmitConstants call moved to class.
11425 2004-09-22 Martin Baulig <martin@ximian.com>
11427 Thanks to Peter Sestoft for this bug report.
11429 * expression.cs (Conditional): If both the `trueExpr' and the
11430 `falseExpr' is a NullLiteral, return a NullLiteral.
11432 2004-09-22 Martin Baulig <martin@ximian.com>
11434 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11435 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11436 for the "get_Current" call.
11438 2004-09-22 Martin Baulig <martin@ximian.com>
11440 Marek and me just fixed one of our oldest bugs: #28562 :-)
11442 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11444 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11445 we're an EnumConstant, just return that.
11446 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11447 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11448 to get the value which'll actually be written into the attribute.
11449 However, we have to use GetValue() to access the attribute's value
11452 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11454 * constant.cs (Constant.IsNegative): New abstract property
11457 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11458 (StackAlloc.DoResolve): Reused IsNegative.
11460 2004-09-21 Martin Baulig <martin@ximian.com>
11462 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11463 if we're used in an iterator, we may be called from different
11466 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11467 we actually have an exception block.
11469 2004-09-20 John Luke <jluke@cfl.rr.com>
11471 * class.cs, cs-parser.jay: Improve the error report for 1520:
11472 report the actual line where the error happens, not where the
11473 class was declared.
11475 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11476 Pass location information that was available elsewhere.
11478 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11480 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11481 runtime to delay sign assemblies.
11483 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11485 * cs-parser.jay: Do not report the stack trace, this is barely
11488 2004-08-22 John Luke <john.luke@gmail.com>
11490 * driver.cs : check that a resource id is not already used
11491 before adding it, report CS1508 if it is, bug #63637
11493 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11495 * ecore.cs: Removed dead code.
11497 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11499 * class.cs: Do not report warning CS0067 on the interfaces.
11501 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11503 * cs-parser.jay: Add error 504 report.
11505 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11507 * rootcontext.cs: WarningLevel is 4 by default now.
11509 * statement.cs (Fixed.Resolve): Do not null
11512 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11515 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11516 deep search when property is not virtual.
11517 (PropertyExpr.ResolveAccessors): Make one call for both
11520 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11523 * statement.cs: Error 152 report constains also location.
11525 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11528 * const.cs: Explicitly set constant as static.
11530 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11533 * cs-parser.jay: Add error 1017 report.
11535 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11537 Fixed bug #59980, #64224
11538 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11540 * typemanager.cs (IsSpecialMethod): Simplified
11542 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11544 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11545 condition with better params.
11547 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11550 * attribute.cs (Resolve): Property has to have both
11553 2004-09-14 Martin Baulig <martin@ximian.com>
11555 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11557 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11560 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11561 called and is obsolete then this member suppress message
11562 when call is inside next [Obsolete] method or type.
11564 * expression.cs: Use TestObsoleteMethodUsage member.
11566 2004-09-14 Martin Baulig <martin@ximian.com>
11568 * cs-parser.jay: Sync a bit with the GMCS version.
11570 2004-09-14 Martin Baulig <martin@ximian.com>
11572 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11573 (CSharpParser.yacc_verbose_flag): New public field.
11575 * genericparser.cs: Removed.
11577 2004-09-14 Raja R Harinath <rharinath@novell.com>
11579 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11581 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11583 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11585 2004-09-10 Martin Baulig <martin@ximian.com>
11587 Backported my MemberName changes from GMCS into MCS.
11589 - we are now using a special `MemberName' class instead of using
11590 strings; in GMCS, the `MemberName' also contains the type
11593 - changed the grammar rules a bit:
11594 * the old `member_name' is now a `namespace_or_type_name':
11595 The rule is that we use `namespace_or_type_name' everywhere
11596 where we expect either a "member name" (GetEnumerator) or a
11597 "member name" with an explicit interface name
11598 (IEnumerable.GetEnumerator).
11599 In GMCS, the explicit interface name may include type arguments
11600 (IEnumerable<T>.GetEnumerator).
11601 * we use `member_name' instead of just `IDENTIFIER' for
11603 The rule is that we use `member_name' wherever a member may
11604 have type parameters in GMCS.
11606 * decl.cs (MemberName): New public class.
11607 (MemberCore.MemberName): New public readonly field.
11608 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11609 (DeclSpace): Likewise.
11611 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11612 * enum.cs (Enum.ctor): Likewise.
11614 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11616 (AliasEntry.ctor): Take a MemberName, not an Expression.
11617 (AliasEntry.UsingAlias): Likewise.
11619 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11620 (IMethodData.MemberName): Changed type from string to MemberName.
11621 (MemberBase.ExplicitInterfaceName): Likewise.
11622 (AbstractPropertyEventMethod.SetupName): Make this private.
11623 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11624 argument; compute the member name here.
11625 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11626 on the `member.MemberName' and the `prefix'.
11628 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11630 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11631 thus, we get a `MemberName' instead of a `string'. These
11632 declarations may have type parameters in GMCS.
11633 (interface_method_declaration, delegate_declaration): Likewise.
11634 (class_declaration, interface_declaration): Likewise.
11635 (method_header): Use `namespace_or_type_name' instead of
11636 `member_name'. We may be an explicit interface implementation.
11637 (property_declaration, event_declaration): Likewise.
11638 (member_name): This is now just an `IDENTIFIER', not a
11639 `namespace_or_type_name'.
11640 (type_name, interface_type): Removed.
11641 (namespace_or_type_name): Return a MemberName, not an Expression.
11642 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11643 call GetTypeExpression() on the MemberName to get an expression.
11644 (IndexerDeclaration.interface_type): Changed type from string to
11646 (MakeName): Operate on MemberName's instead of string's.
11648 2004-09-13 Raja R Harinath <rharinath@novell.com>
11651 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11652 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11653 lookup to avoid symbols introduced by 'using'.
11654 * rootcontext.cs (NamespaceLookup): Update.
11656 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11658 * class.cs (TypeContainer.DoDefineMembers): Do not call
11659 DefineDefaultConstructor for static classes.
11661 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11663 * attribute.cs (Attribute.Resolve): Add error 653 report.
11665 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11667 (Method.ApplyAttributeBuilder): Add error 685 report.
11668 (Operator.Define): Add error 564 report.
11670 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11672 * expression.cs (Invocation.DoResolve): Add error
11673 245 and 250 report.
11675 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11678 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11680 * class.cs (ConstructorInitializer.Resolve):
11681 Wrong error number (515->516).
11683 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11685 * class.cs (Indexer.Define): Add error 631 report.
11687 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11689 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11691 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11693 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11695 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11697 * cs-parser.jay: Added error CS0241 report.
11699 2004-09-10 Raja R Harinath <rharinath@novell.com>
11701 * cs-parser.jay (fixed_statement): Introduce a scope for the
11702 declaration in the 'fixed' statement.
11704 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11706 * cs-parser.jay: Added CS0230 error report.
11708 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11710 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11712 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11714 * expression.cs (Argument.Resolve): Added error CS0192 and
11717 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11719 C# 2.0 #pragma warning feature
11721 * cs-tokenizer.cs (PreProcessPragma): New method;
11722 Handles #pragma directive.
11724 * report.cs (WarningRegions): New class; Support
11725 class for #pragma warning directive. It tests whether
11726 warning is enabled for a given line.
11728 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11730 * const.cs: Add more descriptive error report, tahnks to
11733 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11735 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11737 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11739 * expression.cs: Apply patch from Ben: Remove dead code from
11740 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11741 as that code just threw an exception anwyays.
11743 * const.cs: Remove the call to the turnintoconstant, for details
11746 * literal.cs: The type of the null-literal is the null type; So
11747 we use a placeholder type (literal.cs:System.Null, defined here)
11750 * expression.cs (Conditional.DoResolve): Remove some old code that
11751 is no longer needed, conversions have been fixed.
11753 (ArrayCreationExpression.DoResolve): Return false if we fail to
11754 resolve the inner expression.
11756 2004-09-07 Raja R Harinath <rharinath@novell.com>
11759 * cs-parser.jay (delegate_declaration): Record a delegate
11760 declaration as a type declaration.
11761 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11763 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11765 * parameter.cs: Do not crash if the type can not be resolved.
11767 * expression.cs: Report errors with unsafe pointers, fixes #64896
11769 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11771 * expression.cs: Pointer arith always needs to do a conv.i
11772 if the operand is a long. fix 65320
11774 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11776 Fixed cs0619-37.cs, cs0619-38.cs
11778 * enum.cs (GetObsoleteAttribute): Removed.
11780 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11781 on Enum member is double staged. The first is tested member
11784 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11786 Fixed #56986, #63631, #65231
11788 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11789 adds member to name container.
11790 (TypeContainer.AddToTypeContainer): New method, adds type to
11792 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11793 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11794 AddOperator): Simplified by reusing AddToMemberContainer.
11795 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11797 (Method.CheckForDuplications): Fixed implementation to test all
11799 (MemberBase): Detection whether member is explicit interface
11800 implementation is now in constructor.
11801 (MemberBase.UpdateMemberName): Handles IndexerName.
11802 (Accessor): Changed to keep also location information.
11803 (AbstractPropertyEventMethod): Is derived from MemberCore.
11804 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11805 will be emited or not.
11806 (PropertyBase.AreAccessorsDuplicateImplementation):
11807 Tests whether accessors are not in collision with some method.
11808 (Operator): Is derived from MethodCore to simplify common
11811 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11813 (DeclSpace.AddToContainer): Adds the member to defined_names
11814 table. It tests for duplications and enclosing name conflicts.
11816 * enum.cs (EnumMember): Clean up to reuse the base structures
11818 2004-09-03 Martin Baulig <martin@ximian.com>
11820 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11821 into TypeContainer, to make partial classes work again.
11823 2004-09-03 Martin Baulig <martin@ximian.com>
11825 * rootcontext.cs (RootContext.V2): Removed.
11827 2004-03-23 Martin Baulig <martin@ximian.com>
11829 * expression.cs (Invocation.OverloadResolve): Added `bool
11830 may_fail' argument and use it instead of the Location.IsNull() hack.
11832 2004-09-03 Martin Baulig <martin@ximian.com>
11834 Merged latest changes into gmcs. Please keep this comment in
11835 here, it makes it easier for me to see what changed in MCS since
11836 the last time I merged.
11838 2004-09-03 Raja R Harinath <rharinath@novell.com>
11841 * expression.cs (BetterConversion): Don't allow either conversion
11842 to be null. Remove redundant implicit conversion test when 'q ==
11843 null' -- when this function is invoked, we already know that the
11844 implicit conversion exists.
11845 (BetterFunction): Assume that 'best' is non-null. Remove
11846 redundant reimplementation of IsApplicable when 'best' is null.
11847 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11848 number of arguments.
11849 (IsAncestralType): Extract from OverloadResolve.
11850 (OverloadResolve): Make robust to the MethodGroupExpr being
11851 unsorted. Implement all the logic of Section 14.5.5.1, and
11852 support overloading of methods from multiple applicable types.
11853 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11855 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11856 (RealError, Warning): Append type of report to related symbol.
11858 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11860 * enum.cs: Fixed CLS-Compliance checks for enum members.
11861 Error tests cs3008-8.cs, cs3014-8.cs
11863 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11865 Fixed bug #62342, #63102
11866 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11867 like ImplementMethod.
11869 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11871 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11874 2004-09-02 Martin Baulig <martin@ximian.com>
11876 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11877 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11880 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11882 C# 2.0 Static classes implemented
11884 * class.cs (TypeContainer): instance_constructors,
11885 initialized_fields, initialized_static_fields,
11886 default_constructor, base_inteface_types are protected to be
11887 accessible from StaticClass.
11888 (TypeContainer.DefineDefaultConstructor): New virtual method
11889 for custom default constructor generating
11890 (StaticClass): New class to handle "Static classes" feature.
11892 * cs-parser.jay: Handle static keyword on class like instance
11895 * driver.cs: Added "/langversion" command line switch with two
11896 options (iso-1, default).
11898 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11900 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11902 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11904 * delegate.cs: Style.
11906 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11908 * delegate.cs: Add seperate instance expr field for miguel.
11910 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11912 * PointerArithmetic (Resolve): make sure we are not doing
11913 pointer arith on void*. Also, make sure we are resolved
11914 by not setting eclass until resolve.
11916 All callers: Make sure that PointerArithmetic gets resolved.
11918 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11920 * ArrayCreation (LookupType): If the type does not resolve
11921 to an array, give an error.
11923 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11925 * statement.cs (Try.Resolve): Fixed bug #64222
11927 2004-08-27 Martin Baulig <martin@ximian.com>
11930 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11933 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11935 * ecore.cs (Constantify): Get underlying type via
11936 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11937 Windows in special cases.
11939 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11941 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
11942 for obtaining also private methods.
11943 (GetRemoveMethod): Used GetRemoveMethod (true)
11944 for obtaining also private methods.
11946 2004-08-24 Martin Baulig <martin@ximian.com>
11948 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
11949 MethodAttributes.HideBySig for operators.
11951 2004-08-23 Martin Baulig <martin@ximian.com>
11953 Back to the old error reporting system :-)
11955 * report.cs (Message): Removed.
11956 (Report.MessageData, ErrorData, WarningData): Removed.
11957 (Report.Error, Warning): Back to the old system.
11959 2004-08-23 Martin Baulig <martin@ximian.com>
11961 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
11963 * class.cs (TypeContainer.ParentContainer): New public virtual
11964 method; replaces the explicit interface implementation.
11965 (ClassPart.ParentContainer): Override.
11967 2004-08-23 Martin Baulig <martin@ximian.com>
11969 * statement.cs (Switch): Added support for constant switches; see
11970 #59428 or test-285.cs.
11972 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11975 * statement.cs (GetEnumeratorFilter): Removed useless
11976 logic because C# specs is strict. GetEnumerator must be
11979 2004-08-22 Martin Baulig <martin@ximian.com>
11981 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11982 a switch and may break, reset the barrier. Fixes #59867.
11984 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11986 CLS-Compliance speed up (~5% for corlib)
11988 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
11989 New method. Tests container for CLS-Compliant names
11991 * class.cs (TypeContainer.VerifyClsName): New method.
11992 Checks whether container name is CLS Compliant.
11993 (Constructor): Implements IMethodData.
11995 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
11996 low-case table for CLS Compliance test.
11997 (MemberCache.VerifyClsParameterConflict): New method.
11998 Checks method parameters for CS3006 error.
12000 * enum.cs (EnumMember): Is derived from MemberCore.
12001 (Enum.VerifyClsName): Optimized for better performance.
12003 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12005 * report.cs: Renamed Error_T to Error and changed all
12008 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12010 * class.cs (TypeContainer.IndexerArrayList): New inner class
12011 container for indexers.
12012 (TypeContainer.DefaultIndexerName): New constant for default
12013 indexer name. Replaced all "Item" with this constant.
12014 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12016 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12017 DefaultMemberAttribute constructor.
12019 2004-08-05 Martin Baulig <martin@ximian.com>
12021 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12024 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12026 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12027 multi platforms problem.
12029 * compiler.csproj: Included shared files.
12031 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12033 Fix bug 60333, 55971 in the more general way
12034 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12035 Added arg_type argument for constant conversion.
12036 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12038 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12041 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12042 OperatorArrayList, MethodCoreArrayList for typecontainer
12043 containers. Changed class member types to these new types.
12044 (MethodArrayList.DefineMembers): Added test for CS0659.
12046 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12048 * cfold.cs: Synchronize the folding with the code in expression.cs
12049 Binary.DoNumericPromotions for uint operands.
12051 * attribute.cs: Revert patch from Raja, it introduced a regression
12052 while building Blam-1.2.1 (hard to isolate a test case).
12054 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12058 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12060 (MethodCore.parent_method): New member. The method we're overriding
12061 if this is an override method.
12062 (MethodCore.CheckBase): Moved from Method class and made common.
12063 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12065 (MethodCore.CheckForDuplications): New abstract method. For custom
12066 member duplication search in a container
12067 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12068 method and its return type.
12069 (Event.conflict_symbol): New member. Symbol with same name in the
12073 (MemberCache.FindMemberWithSameName): New method. The method
12074 is looking for conflict with inherited symbols.
12076 2004-08-04 Martin Baulig <martin@ximian.com>
12078 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12080 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12082 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12084 * report.cs (Message): New enum for better error, warning reference in
12086 (MessageData): New inner abstract class. It generally handles printing of
12087 error and warning messages.
12088 Removed unused Error, Warning, Message methods.
12090 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12092 Fix for cs0592-8.cs test
12094 (Attributable.ValidAttributeTargets): Made public.
12095 (Attribute.ExplicitTarget): New member for explicit target value.
12096 (Attribute.CheckTargets): Now we translate explicit attribute
12097 target to Target here.
12099 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12101 * ecore.cs (MethodGroupExpr): new IsBase property.
12103 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12105 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12106 rather than an instance expr.
12108 (DelegateCreation.Emit): Use the method group rather than
12109 the instance expression. Also, if you have base.Foo as the
12110 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12112 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12114 (NewDelegate.DoResolve): Only check for the existance of Invoke
12115 if the method is going to be needed. Use MethodGroupExpr.
12117 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12119 * expression.cs: For pointer arith., make sure to use
12120 the size of the type, not the size of the pointer to
12123 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12126 * class.cs (Class): Added error CS0502 test.
12128 2004-08-03 John Luke <jluke@cfl.rr.com>
12129 Raja R Harinath <rharinath@novell.com>
12132 * attribute.cs (Attribute.complained_before): New flag.
12133 (Attribute.ResolveType, Attribute.Resolve),
12134 (Attribute.DefinePInvokeMethod): Set it.
12135 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12137 2004-08-03 Martin Baulig <martin@ximian.com>
12139 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12140 use a user-defined operator; we still need to do numeric
12141 promotions in case one argument is a builtin type and the other
12142 one has an implicit conversion to that type. Fixes #62322.
12144 2004-08-02 Martin Baulig <martin@ximian.com>
12146 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12147 (LocalInfo.IsThis): New public property.
12148 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12150 2004-08-01 Martin Baulig <martin@ximian.com>
12152 * class.cs (TypeContainer.GetClassBases): Don't set the default
12153 here since we may get called from GetPartialBases().
12154 (TypeContainer.DefineType): If GetClassBases() didn't return a
12155 parent, use the default one.
12157 2004-07-30 Duncan Mak <duncan@ximian.com>
12159 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12161 2004-07-30 Martin Baulig <martin@ximian.com>
12163 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12165 * class.cs (SourceMethod): New public class, derive from the
12166 symbol writer's ISourceMethod.
12167 (Method): Use the new symbol writer API.
12169 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12170 as argument and use the new symbol writer.
12173 (SourceFile): Implement the symbol writer's ISourceFile.
12174 (Location.SymbolDocument): Removed.
12175 (Location.SourceFile): New public property.
12177 * symbolwriter.cs: Use the new symbol writer API.
12179 2004-07-30 Raja R Harinath <rharinath@novell.com>
12181 * Makefile (install-local): Remove. Functionality moved to
12184 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12186 * Makefile: Install mcs.exe.config file together with mcs.exe.
12187 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12188 correct runtime version.
12190 2004-07-25 Martin Baulig <martin@ximian.com>
12193 (TypeContainer.RegisterOrder): Removed, this was unused.
12194 (TypeContainer, interface_order): Removed.
12195 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12196 TypeContainer as argument since we can also be called with a
12197 `PartialContainer' for a partial class/struct/interface.
12198 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12199 of checking whether we're an `Interface' - we could be a
12200 `PartialContainer'.
12201 (PartialContainer.Register): Override; call
12202 AddClass()/AddStruct()/AddInterface() on our parent.
12204 * cs-parser.jay (interface_member_declaration): Add things to the
12205 `current_container', not the `current_class'.
12207 * rootcontext.cs (RegisterOrder): The overloaded version which
12208 takes an `Interface' was unused, removed.
12210 * typemanager.cs (TypeManager.LookupInterface): Return a
12211 `TypeContainer', not an `Interface'.
12212 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12213 contain a `PartialContainer' for an interface, so check it's
12214 `Kind' to figure out what it is.
12216 2004-07-25 Martin Baulig <martin@ximian.com>
12218 * class.cs (Class.DefaultTypeAttributes): New public constant.
12219 (Struct.DefaultTypeAttributes): Likewise.
12220 (Interface.DefaultTypeAttributes): Likewise.
12221 (PartialContainer.TypeAttr): Override this and add the
12222 DefaultTypeAttributes.
12224 2004-07-25 Martin Baulig <martin@ximian.com>
12226 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12227 we can just use the `Parent' field instead.
12229 2004-07-25 Martin Baulig <martin@ximian.com>
12231 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12233 2004-07-25 Martin Baulig <martin@ximian.com>
12235 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12236 our parts before defining any methods.
12237 (TypeContainer.VerifyImplements): Make this virtual.
12238 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12239 on our PartialContainer.
12241 2004-07-25 Martin Baulig <martin@ximian.com>
12243 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12245 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12246 argument, we can just use the `Parent' field instead.
12249 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12250 (MemberBase.DoDefine): Likewise.
12252 2004-07-24 Martin Baulig <martin@ximian.com>
12254 * decl.cs (MemberCore.Parent): New public field.
12255 (DeclSpace.Parent): Moved to MemberCore.
12257 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12258 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12260 (FieldBase, Field, Operator): Likewise.
12261 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12262 (EventField, Event): Likewise.
12264 2004-07-23 Martin Baulig <martin@ximian.com>
12266 * class.cs (PartialContainer): New public class.
12267 (ClassPart): New public class.
12268 (TypeContainer): Added support for partial classes.
12269 (TypeContainer.GetClassBases): Splitted some of the functionality
12270 out into GetNormalBases() and GetPartialBases().
12272 * cs-tokenizer.cs (Token.PARTIAL): New token.
12273 (Tokenizer.consume_identifier): Added some hacks to recognize
12274 `partial', but only if it's immediately followed by `class',
12275 `struct' or `interface'.
12277 * cs-parser.jay: Added support for partial clases.
12279 2004-07-23 Martin Baulig <martin@ximian.com>
12281 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12282 a `DeclSpace' and also made it readonly.
12283 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12284 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12285 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12287 * cs-parser.jay: Pass the `current_class', not the
12288 `current_container' (at the moment, this is still the same thing)
12289 to a new Method, Property, Event, Indexer or Constructor.
12291 2004-07-23 Martin Baulig <martin@ximian.com>
12293 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12294 and removed the `current_interface' one.
12295 (struct_declaration, class_declaration, interface_declaration):
12296 Set `current_class' to the newly created class/struct/interface;
12297 set their `Bases' and call Register() before parsing their body.
12299 2004-07-23 Martin Baulig <martin@ximian.com>
12301 * class.cs (Kind): New public enum.
12302 (TypeContainer): Made this class abstract.
12303 (TypeContainer.Kind): New public readonly field.
12304 (TypeContainer.CheckDef): New public method; moved here from
12306 (TypeContainer.Register): New public abstract method.
12307 (TypeContainer.GetPendingImplementations): New public abstract
12309 (TypeContainer.GetClassBases): Removed the `is_class' and
12310 `is_iface' parameters.
12311 (TypeContainer.DefineNestedTypes): Formerly known as
12313 (ClassOrStruct): Made this class abstract.
12315 * tree.cs (RootTypes): New public type.
12317 2004-07-20 Martin Baulig <martin@ximian.com>
12319 * tree.cs (Tree.RecordNamespace): Removed.
12320 (Tree.Namespaces): Removed.
12322 * rootcontext.cs (RootContext.IsNamespace): Removed.
12324 * cs-parser.jay (namespace_declaration): Just create a new
12325 NamespaceEntry here.
12327 2004-07-20 Martin Baulig <martin@ximian.com>
12329 * statement.cs (ExceptionStatement): New abstract class. This is
12330 now used as a base class for everyone who's using `finally'.
12331 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12332 our local variables before using them.
12334 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12335 virtual method. This is used by Yield.Resolve() to "steal" an
12336 outer block's `finally' clauses.
12337 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12340 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12341 version which takes an ExceptionStatement. This version must be
12342 used to create exception branchings.
12345 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12346 (Iterator.EmitMoveNext): Added exception support; protect the
12347 block with a `fault' clause, properly handle 'finally' clauses.
12348 (Iterator.EmitDispose): Run all the `finally' clauses here.
12350 2004-07-20 Martin Baulig <martin@ximian.com>
12352 * iterator.cs: This is the first of a set of changes in the
12353 iterator code. Match the spec more closely: if we're an
12354 IEnumerable, then GetEnumerator() must be called. The first time
12355 GetEnumerator() is called, it returns the current instance; all
12356 subsequent invocations (if any) must create a copy.
12358 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12360 * expression.cs: Resolve the constant expression before returning
12363 2004-07-19 Martin Baulig <martin@ximian.com>
12365 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12366 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12367 the return type of the new EmitContext.
12369 2004-07-18 Martin Baulig <martin@ximian.com>
12371 * class.cs (Property.Define): Fix iterators.
12373 * iterators.cs (Iterator.Define): Moved the
12374 `container.AddInterator (this)' call here from the .ctor; only do
12375 it if we resolved successfully.
12377 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12379 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12380 `true' for preprocessing directives that we parse. The return
12381 value indicates whether we should return to regular tokenizing or
12382 not, not whether it was parsed successfully.
12384 In the past if we were in: #if false ... #line #endif, we would
12385 resume parsing after `#line'. See bug 61604.
12387 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12388 building: IsEnumType should return true only for enums, not for
12389 enums or System.Enum itself. This fixes #61593.
12391 Likely what happened is that corlib was wrong: mcs depended on
12392 this bug in some places. The bug got fixed, we had to add the
12393 hack, which caused bug 61593.
12395 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12396 that was a workaround for the older conditions.
12398 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12400 * assign.cs: IAssignMethod has a new interface, as documented
12401 inline. All assignment code now uses this new api.
12403 * ecore.cs, expression.cs: All classes which implement
12404 IAssignMethod now use the new interface.
12406 * expression.cs (Invocation): add a hack to EmitCall so that
12407 IndexerAccess can be the target of a compound assignment without
12408 evaluating its arguments twice.
12410 * statement.cs: Handle changes in Invocation api.
12412 2004-07-16 Martin Baulig <martin@ximian.com>
12414 * iterators.cs: Rewrote this. We're now using one single Proxy
12415 class for both the IEnumerable and the IEnumerator interface and
12416 `Iterator' derives from Class so we can use the high-level API.
12418 * class.cs (TypeContainer.AddIterator): New method.
12419 (TypeContainer.DoDefineType): New protected virtual method, which
12420 is called from DefineType().
12421 (TypeContainer.DoDefineMembers): Call DefineType() and
12422 DefineMembers() on all our iterators.
12423 (TypeContainer.Emit): Call Emit() on all our iterators.
12424 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12426 * codegen.cs (EmitContext.CurrentIterator): New public field.
12428 2004-07-15 Martin Baulig <martin@ximian.com>
12431 (TypeManager.not_supported_exception_type): New type.
12433 2004-07-14 Martin Baulig <martin@ximian.com>
12435 * iterators.cs: Use real error numbers.
12437 2004-07-14 Martin Baulig <martin@ximian.com>
12439 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12440 requires this to be a System.Collection.IEnumerable and not a
12441 class implementing that interface.
12442 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12444 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12446 * class.cs: Fixed previous fix, it broke some error tests.
12448 2004-07-12 Martin Baulig <martin@ximian.com>
12450 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12453 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12455 * assign.cs (LocalTemporary): Add new argument: is_address,If
12456 `is_address' is true, then the value that we store is the address
12457 to the real value, and not the value itself.
12459 * ecore.cs (PropertyExpr): use the new local temporary
12460 stuff to allow us to handle X.Y += z (where X is a struct)
12462 2004-07-08 Martin Baulig <martin@ximian.com>
12464 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12465 not always return, just like we're doing in Using.Resolve().
12467 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12469 * cs-parser.jay (fixed_statement): flag this as Pinned.
12471 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12473 * typemanager.cs (TypeManager): Removed MakePinned method, this
12474 mechanism is replaced with the .NET 2.x compatible mechanism of
12475 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12477 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12478 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12479 `IsFixed' property which has a different meaning.
12481 2004-07-02 Raja R Harinath <rharinath@novell.com>
12483 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12484 visible from inside a nested class, not just the names of the
12485 immediately enclosing class.
12486 Fix for bug #60730.
12488 2004-06-24 Raja R Harinath <rharinath@novell.com>
12490 * expression.cs (BetterConversion): Remove buggy special-case
12491 handling of "implicit constant expression conversions". At this
12492 point, we already know that the conversion is possible -- we're
12493 only checking to see which is better.
12495 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12497 * cs-parser.jay: Added error CS0210 test.
12499 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12501 * cs-parser.jay: Added error CS0134 test.
12503 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12506 * cs-parser.jay: Added error CS0145 test.
12508 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12510 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12512 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12514 * expression.cs (StackAlloc.Resolve): The argument may not
12515 be a constant; deal with this case.
12517 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12519 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12520 GetIndexerAttributeValue.
12521 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12523 * class.cs (Indexer.Define): Added error tests for CS0415,
12526 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12528 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12531 2004-06-23 Martin Baulig <martin@ximian.com>
12533 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12534 neither return nor throw, reset the barrier as well. Fixes #60457.
12536 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12538 * class.cs : EventAttributes is now set to None by default.
12539 This fixes bug #60459.
12541 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12544 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12545 Don't throw exception but return null (it's sufficient now).
12547 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12549 * typemanager.cs (GetArgumentTypes): Faster implementation.
12551 2004-06-18 Martin Baulig <martin@ximian.com>
12553 * attribute.cs (Attribute.Resolve): Check whether we're an
12554 EmptyCast which a Constant child. Fixes #60333.
12556 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12558 * statement.cs (EmitCollectionForeach): Account for the fact that
12559 not all valuetypes are in areas which we can take the address of.
12560 For these variables, we store to a temporary variable. Also, make
12561 sure that we dont emit a `callvirt' on a valuetype method.
12563 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12565 * expression.cs (StackAlloc.DoReSolve): Added test for
12566 negative parameter (CS0247).
12568 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12571 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12573 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12576 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12579 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12581 Fix bug #58254 & cs1555.cs, cs1556.cs
12582 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12584 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12586 * cs-parser.jay: Added error CS1669 test for indexers.
12588 2004-06-11 Martin Baulig <martin@ximian.com>
12590 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12591 call this twice: for params and varargs methods.
12593 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12596 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12598 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12600 * attribute.cs (Attribute.GetValidTargets): Made public.
12603 (AbstractPropertyEventMethod): New class for better code sharing.
12604 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12606 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12608 2004-06-11 Raja R Harinath <rharinath@novell.com>
12611 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12612 that the call to Resolve is part of a MemberAccess.
12613 (Expression.Resolve): Use it for SimpleName resolution.
12614 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12615 Add 'intermediate' boolean argument.
12616 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12617 error message when the SimpleName can be resolved ambiguously
12618 between an expression and a type.
12619 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12621 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12622 call on the left-side.
12624 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12627 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12629 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12631 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12633 2004-06-11 Martin Baulig <martin@ximian.com>
12635 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12636 varargs methods if applicable.
12638 2004-06-11 Martin Baulig <martin@ximian.com>
12640 * expression.cs (Invocation.EmitCall): Don't use
12641 `method.CallingConvention == CallingConventions.VarArgs' since the
12642 method could also have `CallingConventions.HasThis'.
12644 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12646 * class.cs (Event.GetSignatureForError): Implemented.
12647 Fixed crash in error test cs3010.cs
12649 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12651 * cs-tokenizer.cs: Change the way we track __arglist to be
12652 consistent with the other keywords.
12654 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12656 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12659 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12661 * codegen.cs: Check that all referenced assemblies have a strongname
12662 before strongnaming the compiled assembly. If not report error CS1577.
12663 Fix bug #56563. Patch by Jackson Harper.
12664 * typemanager.cs: Added a method to return all referenced assemblies.
12665 Fix bug #56563. Patch by Jackson Harper.
12667 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12670 (Method.ApplyAttributeBuilder): Moved and added conditional
12671 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12674 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12676 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12679 * class.cs: (EventField.attribute_targets): Changed default target.
12681 2004-06-08 Martin Baulig <martin@ximian.com>
12683 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12685 2004-06-08 Martin Baulig <martin@ximian.com>
12687 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12689 2004-06-07 Martin Baulig <martin@ximian.com>
12691 Added support for varargs methods.
12693 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12696 * cs-parser.jay: Added support for `__arglist'.
12698 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12700 * expression.cs (Argument.AType): Added `ArgList'.
12701 (Invocation): Added support for varargs methods.
12702 (ArglistAccess): New public class.
12703 (Arglist): New public class.
12705 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12707 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12708 a method's top-level block if the method has varargs.
12710 * support.cs (ReflectionParameters, InternalParameters): Added
12711 support for varargs methods.
12713 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12715 * class.cs: Provide location in indexer error report.
12717 * driver.cs: Use standard names.
12719 * namespace.cs: Catch the use of using after a namespace has been
12720 declared also on using aliases.
12722 2004-06-03 Raja R Harinath <rharinath@novell.com>
12725 * typemanager.cs (closure_private_ok, closure_invocation_type)
12726 (closure_qualifier_type, closure_invocation_assembly)
12727 (FilterWithClosure): Move to ...
12728 (Closure): New internal nested class.
12729 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12730 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12731 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12732 (MemberLookup, MemberLookupFailed): Use it.
12733 * expression.cs (New.DoResolve): Treat the lookup for the
12734 constructor as being qualified by the 'new'ed type.
12735 (Indexers.GetIndexersForTypeOrInterface): Update.
12737 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12740 (GetConditionalAttributeValue): New method. Returns
12741 condition of ConditionalAttribute.
12742 (SearchMulti): New method. Returns all attributes of type 't'.
12743 Use it when attribute is AllowMultiple = true.
12744 (IsConditionalMethodExcluded): New method.
12747 (Method.IsExcluded): Implemented. Returns true if method has conditional
12748 attribute and the conditions is not defined (method is excluded).
12749 (IMethodData): Extended interface for ConditionalAttribute support.
12750 (PropertyMethod.IsExcluded): Implemented.
12753 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12756 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12759 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12761 * expression.cs (ArrayCreationExpression): Make this just an
12762 `expression'. It can't be a statement, so the code here was
12765 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12768 * typemanager.cs (GetFullNameSignature): New method for
12771 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12774 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12775 Use this method when MethodBuilder is null.
12776 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12777 Added test for error CS0626 (MONO reports error for this situation).
12778 (IMethodData.GetSignatureForError): Extended interface.
12780 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12783 (AttributeTester.GetObsoleteAttribute): Returns instance of
12784 ObsoleteAttribute when type is obsolete.
12787 (TypeContainer.VerifyObsoleteAttribute): Override.
12788 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12789 (MethodCode.VerifyObsoleteAttribute): Override.
12790 (MemberBase.VerifyObsoleteAttribute): Override.
12793 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12794 and report proper error.
12797 Delegate.VerifyObsoleteAttribute): Override.
12800 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12801 and report proper error.
12802 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12805 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12809 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12810 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12811 Added test for ObsoleteAttribute.
12814 (Catch): Derived from Statement.
12816 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12818 Fixed bug #59071 & cs0160.cs
12820 * statement.cs (Try.Resolve): Check here whether order of catch
12821 clauses matches their dependencies.
12823 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12825 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12826 caused a regression: #59343. Referencing nested classes from an
12827 assembly stopped working.
12829 2004-05-31 Martin Baulig <martin@ximian.com>
12831 MCS is now frozen for beta 2.
12833 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12835 * convert.cs: add a trivial cache for overload operator resolution.
12837 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12839 * decl.cs: If possible, use lookuptypedirect here. We can only do
12840 this if there is no `.' after the namespace. Avoids using
12841 LookupType, which does lots of slow processing.
12842 (FindNestedType) New method, does what it says :-).
12843 * namespace.cs: use LookupTypeDirect.
12844 * rootcontext.cs: use membercache, if possible.
12845 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12847 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12850 According to the spec,
12852 In a member access of the form E.I, if E is a single identifier,
12853 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12854 field, property, localvariable, or parameter with the same type as
12855 the meaning of E as a type-name (§3.8), then both possible
12856 meanings of E are permitted.
12858 We did not check that E as a simple-name had the same type as E as
12861 This trivial check gives us 5-7% on bootstrap time.
12863 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12865 * expression.cs (Invocation.OverloadResolve): Avoid the
12866 use of hashtables and boxing here by allocating on demand.
12868 2004-05-30 Martin Baulig <martin@ximian.com>
12870 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12871 we're doing a silent lookup. Don't try to lookup nested types in
12872 TypeManager.object_type (thanks to Ben Maurer).
12874 2004-05-30 Martin Baulig <martin@ximian.com>
12876 Committing a patch from Ben Maurer.
12878 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12880 2004-05-29 Martin Baulig <martin@ximian.com>
12882 * class.cs (IMethodData.ShouldIgnore): New method.
12884 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12885 `Location' argument, we don't need it anywhere. Use
12886 `IMethodData.ShouldIgnore ()' instead of
12887 `MethodData.GetMethodFlags ()'.
12888 (TypeManager.AddMethod): Removed.
12889 (TypeManager.AddMethod2): Renamed to AddMethod.
12891 2004-05-29 Martin Baulig <martin@ximian.com>
12893 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12895 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12896 converting from a class type S to an interface type and we already
12897 have an object on the stack, don't box it again. Fixes #52578.
12899 2004-05-29 Martin Baulig <martin@ximian.com>
12901 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12902 Added support for `params' parameters. Fixes #59267.
12904 2004-05-29 Martin Baulig <martin@ximian.com>
12906 * literal.cs (NullPointer): Provide a private .ctor which sets
12907 `type' to TypeManager.object_type. Fixes #59048.
12909 2004-05-29 Martin Baulig <martin@ximian.com>
12911 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12912 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12914 * ecore.cs (EventExpr.instance_expr): Make the field private.
12916 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12918 Fixed bug #50080 & cs0214-2.cs
12919 * expression.cs (Cast.DoResolve): Check unsafe context here.
12921 * statement.cs (Resolve.DoResolve): Likewise.
12923 2004-05-26 Martin Baulig <martin@ximian.com>
12925 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12927 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12928 (RootContext.LookupType): Pass down the `silent' flag.
12930 2004-05-25 Martin Baulig <martin@ximian.com>
12933 (MethodGroupExpr.IdenticalTypeName): New public property.
12934 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12935 expression actually refers to a type.
12937 2004-05-25 Martin Baulig <martin@ximian.com>
12939 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
12940 for #56176 and made it actually work.
12942 2004-05-25 Martin Baulig <martin@ximian.com>
12944 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
12945 (FieldExpr, PropertyExpr): Override and implement
12946 CacheTemporaries. Fixes #52279.
12948 2004-05-25 Miguel de Icaza <miguel@ximian.com>
12950 * location.cs: In the new compiler listing a file twice is a
12951 warning, not an error.
12953 2004-05-24 Martin Baulig <martin@ximian.com>
12955 * enum.cs (Enum.DefineType): For the `BaseType' to be a
12956 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
12958 2004-05-24 Martin Baulig <martin@ximian.com>
12960 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
12961 walking the `using' list. Fixes #53921.
12963 2004-05-24 Martin Baulig <martin@ximian.com>
12965 * const.cs (Const.LookupConstantValue): Added support for
12966 EmptyCast's; fixes #55251.
12968 2004-05-24 Martin Baulig <martin@ximian.com>
12970 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
12971 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
12972 which does the CS0135 check. The reason is that we first need to
12973 check whether the variable actually exists.
12975 2004-05-24 Martin Baulig <martin@ximian.com>
12977 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
12978 than RootContext.LookupType() to find the explicit interface
12979 type. Fixes #58584.
12981 2004-05-24 Raja R Harinath <rharinath@novell.com>
12983 * Makefile: Simplify. Use executable.make.
12984 * mcs.exe.sources: New file. List of sources of mcs.exe.
12986 2004-05-24 Anders Carlsson <andersca@gnome.org>
12990 Use the invariant culture when doing String.Compare for CLS case
12993 2004-05-23 Martin Baulig <martin@ximian.com>
12995 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
12996 don't have any dots. Fixes #52622, added cs0246-8.cs.
12998 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13000 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13002 * class.cs (MemberBase.Define): Reuse MemberType member for
13003 resolved type. Other methods can use it too.
13005 2004-05-23 Martin Baulig <martin@ximian.com>
13007 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13008 the variable also exists in the current block (otherwise, we need
13009 to report a CS0103). Fixes #58670.
13011 2004-05-23 Martin Baulig <martin@ximian.com>
13013 * flowanalysis.cs (Reachability.Reachable): Compute this
13014 on-the-fly rather than storing it as a field.
13016 2004-05-23 Martin Baulig <martin@ximian.com>
13018 * flowanalysis.cs (Reachability.And): Manually compute the
13019 resulting `barrier' from the reachability.
13021 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13024 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13025 instance of ObsoleteAttribute when symbol is obsolete.
13028 (IMethodData): Extended interface for ObsoleteAttribute support.
13030 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13032 * attribute.cs: Fix bug #55970
13034 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13038 (GetObsoleteAttribute): New method. Creates the instance of
13040 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13041 ObsoleteAttribute when member is obsolete.
13042 (AttributeTester.Report_ObsoleteMessage): Common method for
13043 Obsolete error/warning reporting.
13046 (TypeContainer.base_classs_type): New member for storing parent type.
13049 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13050 for this MemberCore.
13052 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13054 * attribute.cs, const.cs: Fix bug #58590
13056 2004-05-21 Martin Baulig <martin@ximian.com>
13058 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13059 out parameters if the end of the method is unreachable. Fixes
13062 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13064 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13065 Hari was right, why extra method.
13067 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13069 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13071 2004-05-20 Martin Baulig <martin@ximian.com>
13073 Merged this back from gmcs to keep the differences to a minumum.
13075 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13076 instead of a Declspace.
13077 (Attribute.ResolveType): Likewise.
13078 (Attributes.Search): Likewise.
13079 (Attributes.Contains): Likewise.
13080 (Attributes.GetClsCompliantAttribute): Likewise.
13082 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13084 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13087 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13089 Fix bug #58688 (MCS does not report error when the same attribute
13092 * attribute.cs (Attribute.Emit): Distinction between null and default.
13094 2004-05-19 Raja R Harinath <rharinath@novell.com>
13096 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13097 of a top-level attribute without an attribute target.
13098 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13100 (Attribute.Conditional_GetConditionName),
13101 (Attribute.Obsolete_GetObsoleteMessage): Update.
13102 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13103 part of ScanForIndexerName.
13104 (Attribute.CanIgnoreInvalidAttribute): New function.
13105 (Attribute.ScanForIndexerName): Move to ...
13106 (Attributes.ScanForIndexerName): ... here.
13107 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13108 (Attributes.Search): New internal variant that can choose not to
13109 complain if types aren't resolved. The original signature now
13111 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13112 complaints suppressed.
13113 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13114 only if it not useful.
13115 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13116 top-level for attributes that are shared between the assembly
13117 and a top-level class.
13118 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13119 * class.cs: Update to reflect changes.
13120 (DefineIndexers): Fuse loops.
13121 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13122 a couple more variants of attribute names.
13124 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13126 Fix bug #52585 (Implemented explicit attribute declaration)
13129 (Attributable.ValidAttributeTargets): New abstract method. It gets
13130 list of valid attribute targets for explicit target declaration.
13131 (Attribute.Target): It holds target itself.
13132 (AttributeSection): Removed.
13133 (Attribute.CheckTargets): New method. It checks whether attribute
13134 target is valid for the current element.
13137 (EventProperty): New class. For events that are declared like
13138 property (with add and remove accessors).
13139 (EventField): New class. For events that are declared like field.
13142 * cs-parser.jay: Implemented explicit attribute target declaration.
13144 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13145 Override ValidAttributeTargets.
13148 (ReturnParameter): Class for applying custom attributes on
13150 (ParameterAtribute): New class. Class for applying custom
13151 attributes on the parameter type.
13153 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13155 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13158 (Method): Allow UNSAFE here.
13160 * modifiers.cs: Support unsafe reporting.
13162 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13164 * decl.cs: Fix bug #58478.
13166 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13168 * statement.cs: When checking for unreachable code on an EmptyStatement,
13169 set the location. Fixes bug #58488.
13171 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13173 * driver.cs: Add -pkg handling.
13175 From Gonzalo: UseShelLExecute=false
13177 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13180 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13182 (Attribute.IsClsCompliaceRequired): Moved to base for better
13184 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13185 when attribute is AttributeUsageAttribute.
13186 (Attribute.GetValidTargets): Simplified.
13187 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13188 attribute for this type.
13189 (Attribute.ApplyAttributes): Method renamed to Emit and make
13191 (GlobalAttributeSection): New class for special handling of global
13192 attributes (assembly, module).
13193 (AttributeSection.Emit): New method.
13195 * class.cs: Implemented Attributable abstract methods.
13196 (MethodCore.LabelParameters): Moved to Parameter class.
13197 (Accessor): Is back simple class.
13198 (PropertyMethod): Implemented Attributable abstract class.
13199 (DelegateMethod): Implemented Attributable abstract class.
13200 (Event): New constructor for disctintion between normal Event
13201 and Event with accessors.
13203 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13205 * codegen.cs, const.cs, decl.cs, delegate.cs:
13206 (CommonAssemblyModulClass): Implemented Attributable abstract class
13209 * enum.cs: Implement IAttributeSupport interface.
13210 (EnumMember): New class for emum members. Implemented Attributable
13214 (ParameterBase): Is abstract.
13215 (ReturnParameter): New class for easier [return:] attribute handling.
13217 * typemanager.cs: Removed builder_to_attr.
13219 2004-05-11 Raja R Harinath <rharinath@novell.com>
13222 * attribute.cs (Attribute.GetPositionalValue): New function.
13223 * class.cs (TypeContainer.VerifyMembers): New function.
13224 (TypeContainer.Emit): Use it.
13225 (ClassOrStruct): New base class for Class and Struct.
13226 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13227 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13229 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13230 then each non-static field should have a FieldOffset attribute.
13231 Otherwise, none of the fields should have a FieldOffset attribute.
13232 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13233 and FieldOffset attributes.
13234 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13235 (TypeManager.field_offset_attribute_type): New core types.
13236 (TypeManager.InitCoreTypes): Initialize them.
13238 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13240 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13241 Return correct type.
13244 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13246 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13247 be implicitly converted to ulong.
13249 * expression.cs: The logic for allowing operator &, | and ^ worked
13250 was wrong, it worked before because we did not report an error in
13251 an else branch. Fixes 57895.
13253 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13254 allow volatile fields to be reference types.
13256 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13258 * driver.cs: Add support for /debug-
13260 2004-05-07 Raja R Harinath <rharinath@novell.com>
13262 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13263 Add a 'complain' parameter to silence errors.
13264 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13265 silently overlooked type-resolutions.
13266 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13267 to reflect changes.
13268 (Attributes.Search): New function.
13269 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13270 (Attributes.GetAttributeFullName): Remove hack.
13271 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13272 Update to reflect changes.
13273 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13274 Use Attributes.Search instead of nested loops.
13276 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13279 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13280 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13281 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13283 * report.cs: (Report.Warning): Renamed to Warning_T because of
13284 parameter collision.
13286 2004-05-05 Raja R Harinath <rharinath@novell.com>
13288 * expression.cs (MemberAccess.ResolveMemberAccess):
13289 Exit with non-zero status after Report.Error.
13290 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13292 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13294 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13296 * support.cs: Don't hang when the file is empty.
13298 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13300 * support.cs: In SeekableStreamReader, compute the preamble size of the
13301 underlying stream. Position changes should take into account that initial
13304 2004-05-03 Todd Berman <tberman@sevenl.net>
13306 * driver.cs: remove unused GetSysVersion function.
13308 2004-05-03 Todd Berman <tberman@sevenl.net>
13310 * driver.cs: Remove the hack from saturday, as well as the hack
13311 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13312 link_paths to get that bit proper.
13314 2004-05-01 Todd Berman <tberman@sevenl.net>
13316 * driver.cs: Try a LoadFrom before a Load, this checks the current
13317 path. This is currently a bug in mono that is be fixed, however, this
13318 provides a workaround for now. This will be removed when the bug
13321 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13323 * CryptoConvert.cs: Updated to latest version. Fix issue with
13324 incomplete key pairs (#57941).
13326 2004-05-01 Todd Berman <tberman@sevenl.net>
13328 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13331 2004-04-30 Jackson Harper <jackson@ximian.com>
13333 * codegen.cs: Open keys readonly.
13335 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13337 * typemanager.cs: don't report cyclic struct layout when a struct
13338 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13339 which has 2 Pango.Rectangle fields.
13341 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13343 * expression.cs: Handle IntPtr comparisons with IL code
13344 rather than a method call.
13346 2004-04-29 Martin Baulig <martin@ximian.com>
13348 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13349 the list of PropertyInfo's in class hierarchy and find the
13350 accessor. Fixes #56013.
13352 2004-04-29 Martin Baulig <martin@ximian.com>
13354 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13356 2004-04-29 Martin Baulig <martin@ximian.com>
13358 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13360 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13362 2004-04-29 Martin Baulig <martin@ximian.com>
13364 * class.cs (ConstructorInitializer.Resolve): Check whether the
13365 parent .ctor is accessible. Fixes #52146.
13367 2004-04-29 Martin Baulig <martin@ximian.com>
13369 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13371 * statement.cs (Using.EmitLocalVariableDecls): Use
13372 TypeManager.idisposable_type, not typeof (IDisposable).
13373 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13375 2004-04-29 Martin Baulig <martin@ximian.com>
13377 * class.cs (Event.Define): Don't emit the field and don't set
13378 RTSpecialName and SpecialName for events on interfaces. Fixes
13381 2004-04-29 Raja R Harinath <rharinath@novell.com>
13383 Refactor Attribute.ApplyAttributes.
13384 * attribute.cs (Attributable): New base class for objects that can
13385 have Attributes applied on them.
13386 (Attribute): Make AttributeUsage fields public.
13387 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13388 (Attribute.IsInternalCall): New property.
13389 (Attribute.UsageAttr): Convert to a public read-only property.
13390 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13391 (Attribute.ResolveType, Attribute.Resolve)
13392 (Attribute.ScanForIndexerName): Update to reflect changes.
13393 (Attribute.CheckAttributeTarget): Re-format.
13394 (Attribute.ApplyAttributes): Refactor, to various
13395 Attributable.ApplyAttributeBuilder methods.
13396 * decl.cs (MemberCore): Make Attributable.
13397 * class.cs (Accessor): Make Attributable.
13398 (MethodData.ApplyAttributes): Use proper attribute types, not
13400 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13401 (TypeContainer.ApplyAttributeBuilder)
13402 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13403 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13404 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13405 (Operator.ApplyAttributeBuilder): New factored-out methods.
13406 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13407 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13408 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13409 * parameter.cs (ParameterBase): New Attributable base class
13410 that can also represent Return types.
13411 (Parameter): Update to the changes.
13413 2004-04-29 Jackson Harper <jackson@ximian.com>
13415 * driver.cs: Prefer the corlib system version when looking for
13416 assemblies in the GAC. This is still a hack, but its a better hack
13419 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13421 * decl.cs, enum.cs: Improved error 3005 reporting.
13423 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13424 (related_symbols): New private member for list of symbols
13425 related to reported error/warning.
13427 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13429 2004-04-29 Martin Baulig <martin@ximian.com>
13431 * ecore.cs (Expression.Constantify): If we're an enum and
13432 TypeManager.TypeToCoreType() doesn't give us another type, use
13433 t.UnderlyingSystemType. Fixes #56178.
13435 2004-04-29 Martin Baulig <martin@ximian.com>
13437 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13438 interfaces and for each interface, only add members directly
13439 declared in that interface. Fixes #53255.
13441 2004-04-28 Martin Baulig <martin@ximian.com>
13443 * expression.cs (ConditionalLogicalOperator): Use a temporary
13444 variable for `left' to avoid that we evaluate it more than once;
13447 2004-04-28 Martin Baulig <martin@ximian.com>
13449 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13452 2004-04-28 Martin Baulig <martin@ximian.com>
13454 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13457 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13458 whether the type is not void (CS1547).
13460 2004-04-28 Martin Baulig <martin@ximian.com>
13462 * expression.cs (Unary.DoResolveLValue): Override this and report
13463 CS0131 for anything but Operator.Indirection.
13465 2004-04-28 Martin Baulig <martin@ximian.com>
13467 Committing a patch from Ben Maurer; see bug #50820.
13469 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13472 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13475 2004-04-28 Martin Baulig <martin@ximian.com>
13477 Committing a patch from Ben Maurer; see bug #50820.
13479 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13482 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13485 2004-04-28 Martin Baulig <martin@ximian.com>
13487 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13488 (Block.AddLabel): Call DoLookupLabel() to only search in the
13491 2004-04-28 Martin Baulig <martin@ximian.com>
13493 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13494 comparing StringConstants and NullLiterals in Equality and Inequality.
13496 2004-04-28 Jackson Harper <jackson@ximian.com>
13498 * driver.cs: Attempt to load referenced assemblies from the
13499 GAC. This is the quick and dirty version of this method that
13500 doesnt take into account versions and just takes the first
13501 canidate found. Will be good enough for now as we will not have more
13502 then one version installed into the GAC until I update this method.
13504 2004-04-28 Martin Baulig <martin@ximian.com>
13506 * typemanager.cs (TypeManager.CheckStructCycles): New public
13507 static method to check for cycles in the struct layout.
13509 * rootcontext.cs (RootContext.PopulateTypes): Call
13510 TypeManager.CheckStructCycles() for each TypeContainer.
13511 [Note: We only need to visit each type once.]
13513 2004-04-28 Martin Baulig <martin@ximian.com>
13515 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13517 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13518 success and added `out object value'. Use a `bool resolved' field
13519 to check whether we've already been called rather than
13520 `ConstantValue != null' since this breaks for NullLiterals.
13522 2004-04-28 Raja R Harinath <rharinath@novell.com>
13524 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13525 setting of this flag, since the 'set' method may be non-public.
13527 2004-04-28 Raja R Harinath <rharinath@novell.com>
13529 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13530 check on current_vector.Block.
13532 2004-04-27 Martin Baulig <martin@ximian.com>
13534 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13535 a field initializer. Fixes #56459.
13537 2004-04-27 Martin Baulig <martin@ximian.com>
13539 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13540 we're not attempting to use an indexer. Fixes #52154.
13542 2004-04-27 Martin Baulig <martin@ximian.com>
13544 * statement.cs (Return): Don't create a return label if we don't
13545 need it; reverts my change from January 20th. Thanks to Ben
13548 2004-04-27 Martin Baulig <martin@ximian.com>
13550 According to the spec, `goto' can only leave a nested scope, but
13553 * statement.cs (Block.LookupLabel): Only lookup in the current
13554 block, don't recurse into parent or child blocks.
13555 (Block.AddLabel): Check in parent and child blocks, report
13556 CS0140/CS0158 if we find a duplicate.
13557 (Block): Removed this indexer for label lookups.
13558 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13559 this already does the error reporting for us.
13562 (FlowBranching.UsageVector.Block): New public variable; may be null.
13563 (FlowBranching.CreateSibling): Added `Block' argument.
13564 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13565 label for the target of a `goto' and check whether we're not
13566 leaving a `finally'.
13568 2004-04-27 Martin Baulig <martin@ximian.com>
13570 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13571 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13574 2004-04-27 Martin Baulig <martin@ximian.com>
13576 * statement.cs (Block.AddLabel): Also check for implicit blocks
13577 and added a CS0158 check.
13579 2004-04-27 Martin Baulig <martin@ximian.com>
13581 * flowanalysis.cs (FlowBranchingLoop): New class.
13582 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13583 UsageVector's instead of an ArrayList.
13584 (FlowBranching.Label): Likewise.
13585 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13586 (FlowBranching.AddBreakVector): New method.
13588 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13590 * attribute.cs: Small regression fix: only convert the type if we
13591 the type is different, fixes System.Drawing build.
13593 2004-04-27 Martin Baulig <martin@ximian.com>
13595 * attribute.cs (Attribute.Resolve): If we have a constant value
13596 for a named field or property, implicity convert it to the correct
13599 2004-04-27 Raja R Harinath <rharinath@novell.com>
13601 * statement.cs (Block.Block): Implicit blocks share
13602 'child_variable_names' fields with parent blocks.
13603 (Block.AddChildVariableNames): Remove.
13604 (Block.AddVariable): Mark variable as "used by a child block" in
13605 every surrounding block.
13606 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13607 been used in a child block, complain about violation of "Invariant
13608 meaning in blocks" rule.
13609 * cs-parser.jay (declare_local_variables): Don't use
13610 AddChildVariableNames.
13611 (foreach_statement): Don't create an implicit block: 'foreach'
13612 introduces a scope.
13614 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13616 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13617 converting from 0L to ulong. Fixes 57522.
13619 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13621 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13622 derived class hides via 'new' keyword field from base class (test-242.cs).
13623 TODO: Handle this in the more general way.
13625 * class.cs (CheckBase): Ditto.
13627 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13629 * decl.cs (caching_flags): New member for storing cached values
13631 (MemberCore.Flags): New enum where bit flags for caching_flags
13633 (MemberCore.cls_compliance): Moved to caching_flags.
13634 (DeclSpace.Created): Moved to caching_flags.
13636 * class.cs: Use caching_flags instead of DeclSpace.Created
13638 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13640 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13641 if we are only a derived class, not a nested class.
13643 * typemanager.cs: Same as above, but do this at the MemberLookup
13644 level (used by field and methods, properties are handled in
13645 PropertyExpr). Allow for the qualified access if we are a nested
13648 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13650 * class.cs: Refactoring.
13651 (IMethodData): New inteface; Holds links to parent members
13652 to avoid member duplication (reduced memory allocation).
13653 (Method): Implemented IMethodData interface.
13654 (PropertyBase): New inner classes for get/set methods.
13655 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13656 (Event): New inner classes for add/remove methods.
13657 (Event.DelegateMethod): Implemented IMethodData interface.
13659 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13660 EmitContext (related to class.cs refactoring).
13662 2004-04-21 Raja R Harinath <rharinath@novell.com>
13664 * delegate.cs (Delegate.VerifyApplicability): If the number of
13665 arguments are the same as the number of parameters, first try to
13666 verify applicability ignoring any 'params' modifier on the last
13670 2004-04-16 Raja R Harinath <rharinath@novell.com>
13672 * class.cs (TypeContainer.AddIndexer): Use
13673 'ExplicitInterfaceName' to determine if interface name was
13674 explicitly specified. 'InterfaceType' is not initialized at this time.
13675 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13676 Indexers array is already in the required order. Initialize
13677 'IndexerName' only if there are normal indexers.
13678 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13679 (TypeContainer.Emit): Emit DefaultMember attribute only if
13680 IndexerName is initialized.
13683 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13685 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13688 2004-04-15 Raja R Harinath <rharinath@novell.com>
13690 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13694 * attribute.cs (Attribute.Resolve): Check for duplicate named
13698 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13700 * iterators.cs (MarkYield): track whether we are in an exception,
13701 and generate code accordingly. Use a temporary value to store the
13702 result for our state.
13704 I had ignored a bit the interaction of try/catch with iterators
13705 since their behavior was not entirely obvious, but now it is
13706 possible to verify that our behavior is the same as MS .NET 2.0
13710 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13712 * iterators.cs: Avoid creating temporaries if there is no work to
13715 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13716 Enumerations, use TypeManager.EnumToUnderlying and call
13719 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13722 (This.Emit): Use EmitContext.EmitThis to emit our
13725 (This.EmitAssign): Ditto.
13727 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13728 codepaths, we will move all the functionality into
13731 (FieldExpr.EmitAssign): Ditto.
13733 This fixes several hidden bugs that I uncovered while doing a code
13734 review of this today.
13736 * codegen.cs (EmitThis): reworked so the semantics are more clear
13737 and also support value types "this" instances.
13739 * iterators.cs: Changed so that for iterators in value types, we
13740 do not pass the value type as a parameter.
13742 Initialization of the enumerator helpers is now done in the caller
13743 instead of passing the parameters to the constructors and having
13744 the constructor set the fields.
13746 The fields have now `assembly' visibility instead of private.
13748 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13750 * expression.cs (Argument.Resolve): Check if fields passed as ref
13751 or out are contained in a MarshalByRefObject.
13753 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13754 another compiler type.
13756 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13758 * class.cs (Indexer.Define): use the new name checking method.
13759 Also, return false on an error.
13760 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13761 (is_identifier_[start/part]_character): make static.
13763 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13765 * expression.cs (Binary.ResolveOperator): Do no append strings
13766 twice: since we can be invoked more than once (array evaluation)
13767 on the same concatenation, take care of this here. Based on a fix
13768 from Ben (bug #56454)
13770 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13772 * codegen.cs: Fix another case where CS1548 must be reported (when
13773 delay-sign isn't specified and no private is available #56564). Fix
13774 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13775 error when MCS is used on the MS runtime and we need to delay-sign
13776 (which seems unsupported by AssemblyBuilder - see #56621).
13778 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13780 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13781 (TypeManager.ComputeNamespaces): Faster implementation for
13784 * compiler.csproj: Updated AssemblyName to mcs.
13786 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13788 * rootcontext.cs: Add new types to the boot resolution.
13790 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13791 MulticastDelegate is not allowed.
13793 * typemanager.cs: Add new types to lookup: System.TypedReference
13796 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13797 check for TypedReference or ArgIterator, they are not allowed.
13799 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13800 makes us properly catch 1510 in some conditions (see bug 56016 for
13803 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13805 * CryptoConvert.cs: update from corlib version
13808 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13810 * class.cs (Indexer.Define): Check indexername declaration
13812 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13814 * attribute.cs (IsClsCompliant): Fixed problem with handling
13815 all three states (compliant, not-compliant, undetected).
13817 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13819 * attribute.cs (Attribute): Location is now public.
13820 (Resolve): Store resolved arguments (pos_values) in attribute class.
13821 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13822 (GetClsCompliantAttributeValue): New method that gets
13823 CLSCompliantAttribute value.
13824 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13825 if exists else null.
13826 (AttributeTester): New class for CLS-Compliant verification routines.
13828 * class.cs (Emit): Add CLS-Compliant verification.
13829 (Method.GetSignatureForError): Implemented.
13830 (Constructor.GetSignatureForError): Implemented
13831 (Constructor.HasCompliantArgs): Returns if constructor has
13832 CLS-Compliant arguments.
13833 (Constructor.Emit): Override.
13834 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13835 is needed to test only parameters.
13836 (FieldBase.GetSignatureForError): Implemented.
13837 (TypeContainer): New member for storing base interfaces.
13838 (TypeContainer.FindMembers): Search in base interfaces too.
13840 * codegen.cs (GetClsComplianceAttribute): New method that gets
13841 assembly or module CLSCompliantAttribute value.
13842 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13844 (ModuleClass.Emit): Add error 3012 test.
13846 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13848 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13849 state for all decl types.
13850 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13851 if CLS-Compliant tests are required.
13852 (IsClsCompliaceRequired): New method. Analyze whether code
13853 must be CLS-Compliant.
13854 (IsExposedFromAssembly): New method. Returns true when MemberCore
13855 is exposed from assembly.
13856 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13857 value or gets cached value.
13858 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13859 is explicitly marked with CLSCompliantAttribute.
13860 (IsIdentifierClsCompliant): New abstract method. This method is
13861 used to testing error 3005.
13862 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13863 for identifier and parameters CLS-Compliant testing.
13864 (VerifyClsCompliance): New method. The main virtual method for
13865 CLS-Compliant verifications.
13866 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13867 null. I don't know why is null (too many public members !).
13868 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13869 and get value of first CLSCompliantAttribute that found.
13871 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13872 (VerifyClsCompliance): Override and add extra tests.
13874 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13875 clscheck- disable CLS-Compliant verification event if assembly is has
13876 CLSCompliantAttribute(true).
13878 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13879 ApllyAttribute is now called in emit section as in the other cases.
13880 Possible future Emit integration.
13881 (IsIdentifierClsCompliant): New override.
13882 (VerifyClsCompliance): New override.
13883 (GetEnumeratorName): Returns full enum name.
13885 * parameter.cs (GetSignatureForError): Implemented.
13887 * report.cs (WarningData): New struct for Warning message information.
13888 (LocationOfPreviousError): New method.
13889 (Warning): New method. Reports warning based on the warning table.
13890 (Error_T): New method. Reports error based on the error table.
13892 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13893 verifications are done here.
13895 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13897 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13898 CLSCompliantAttribute.
13899 (all_imported_types): New member holds all imported types from other
13901 (LoadAllImportedTypes): New method fills static table with exported types
13902 from all referenced assemblies.
13903 (Modules): New property returns all assembly modules.
13905 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13907 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13908 throwing a parser error.
13910 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13911 which removes the hardcoded get_/set_ prefixes for properties, as
13912 IL allows for the properties to be named something else.
13916 * expression.cs: Do not override operand before we know if it is
13917 non-null. Fix 56207
13919 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13921 * typemanager.cs: support for pinned variables.
13923 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13925 * decl.cs, typemanager.cs: Avoid using an arraylist
13926 as a buffer if there is only one result set.
13928 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13930 * expression.cs: Make sure you cant call a static method
13931 with an instance expression, bug #56174.
13933 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13935 * class.cs (IsDuplicateImplementation): Improve error reporting to
13936 flag 663 (method only differs in parameter modifier).
13938 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
13939 in preprocessor directives.
13941 * location.cs (LookupFile): Allow for the empty path.
13943 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
13944 better approach for some of that patch, but its failing with the
13945 CharSet enumeration. For now try/catch will do.
13947 * typemanager.cs: Do not crash if a struct does not have fields.
13950 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13952 * expression.cs: cs0213, cant fix a fixed expression.
13955 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13957 * cs-parser.jay: detect invalid embeded statements gracefully.
13960 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13962 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
13965 the invocation type may not be a subclass of the tye of the item/
13966 The type of the item must be a subclass of the invocation item.
13971 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
13973 * attribute.cs: Added methods to get a string and a bool from an
13974 attribute. Required to information from AssemblyKeyFileAttribute,
13975 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
13976 * codegen.cs: Modified AssemblyName creation to include support for
13977 strongnames. Catch additional exceptions to report them as CS1548.
13978 * compiler.csproj: Updated include CryptoConvert.cs.
13979 * compiler.csproj.user: Removed file - user specific configuration.
13980 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
13981 Mono.Security assembly. The original class is maintained and tested in
13982 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
13983 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
13984 like CSC 8.0 (C# v2) supports.
13985 * Makefile: Added CryptoConvert.cs to mcs sources.
13986 * rootcontext.cs: Added new options for strongnames.
13988 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
13990 * driver.cs: For --expect-error, report error code `2'
13991 if the program compiled with no errors, error code `1' if
13992 it compiled with an error other than the one expected.
13994 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
13996 * compiler.csproj: Updated for Visual Studio .NET 2003.
13997 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
13998 * compiler.sln: Updated for Visual Studio .NET 2003.
14000 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14002 * expression.cs: Fix bug #47234. We basically need to apply the
14003 rule that we prefer the conversion of null to a reference type
14004 when faced with a conversion to 'object' (csc behaviour).
14006 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14008 * statement.cs: Shorter form for foreach, eliminates
14009 a local variable. r=Martin.
14011 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14013 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14014 checks if we can use brtrue/brfalse to test for 0.
14015 * expression.cs: use the above in the test for using brtrue/brfalse.
14016 cleanup code a bit.
14018 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14020 * expression.cs: Rewrite string concat stuff. Benefits:
14022 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14023 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14024 rather than a concat chain.
14026 * typemanager.cs: Add lookups for more concat overloads.
14028 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14030 * expression.cs: Emit shorter il code for array init.
14047 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14049 * statement.cs: Before, two switch blocks would be merged if the
14050 total size of the blocks (end_item - begin_item + 1) was less than
14051 two times the combined sizes of the blocks.
14053 Now, it will only merge if after the merge at least half of the
14058 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14060 * class.cs : csc build fix for GetMethods(). See bug #52503.
14062 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14064 * expression.cs: Make sure fp comparisons work with NaN.
14065 This fixes bug #54303. Mig approved this patch a long
14066 time ago, but we were not able to test b/c the runtime
14069 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14071 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14073 2004-03-19 Martin Baulig <martin@ximian.com>
14075 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14076 error here and not in our caller.
14078 2004-03-19 Martin Baulig <martin@ximian.com>
14080 * interface.cs: Completely killed this file.
14081 (Interface): We're now a TypeContainer and live in class.cs.
14083 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14084 argument; we're now also called for interfaces.
14085 (TypeContainer.DefineMembers): Allow this method being called
14087 (TypeContainer.GetMethods): New public method; formerly known as
14088 Interface.GetMethod(). This is used by PendingImplementation.
14089 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14090 it's now private and non-static.
14091 (Interface): Moved this here; it's now implemented similar to
14093 (Method, Property, Event, Indexer): Added `bool is_interface'
14094 argument to their .ctor's.
14095 (MemberBase.IsInterface): New public field.
14097 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14098 instances instead of InterfaceMethod, InterfaceProperty, etc.
14099 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14100 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14102 2004-03-19 Martin Baulig <martin@ximian.com>
14104 * class.cs (MethodCore.IsDuplicateImplementation): New private
14105 method which does the CS0111 checking.
14106 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14107 Use IsDuplicateImplementation().
14109 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14111 * decl.cs (FindMemberToOverride): New method to find the correct
14112 method or property to override in the base class.
14114 - Make Method/Property use the above method to find the
14115 version in the base class.
14116 - Remove the InheritableMemberSignatureCompare as it is now
14119 This patch makes large code bases much faster to compile, as it is
14120 O(n) rather than O(n^2) to do this validation.
14122 Also, it fixes bug 52458 which is that nested classes are not
14123 taken into account when finding the base class member.
14125 Reviewed/Approved by Martin.
14127 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14129 * interface.cs: In all interface classes removed redundant
14130 member initialization.
14132 2004-03-16 Martin Baulig <martin@ximian.com>
14134 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14136 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14138 * decl.cs (DefineTypeAndParents): New helper method to define a
14139 type's containers before the type itself is defined; This is a
14140 bug exposed by the recent changes to Windows.Forms when an
14141 implemented interface was defined inside a class that had not been
14144 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14146 (Check): Loop correctly to report errors modifiers
14147 (UNSAFE was not in the loop, since it was the same as TOP).
14149 * interface.cs: Every interface member now takes a ModFlags,
14150 instead of a "is_new" bool, which we set on the base MemberCore.
14152 Every place where we called "UnsafeOk" in the interface, now we
14153 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14154 the unsafe settings from the member declaration instead of the
14155 container interface.
14157 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14159 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14160 `set_indexer_name' to the pending bits (one per type).
14162 We fixed a bug today that was picking the wrong method to
14163 override, since for properties the existing InterfaceMethod code
14164 basically ignored the method name. Now we make sure that the
14165 method name is one of the valid indexer names.
14167 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14169 * support.cs (SeekableStreamReader): Keep track of stream byte
14170 positions and don't mix them with character offsets to the buffer.
14172 Patch from Gustavo Giráldez
14174 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14176 * interface.cs (InterfaceSetGetBase): Removed double member
14177 initialization, base class does it as well.
14179 2004-03-13 Martin Baulig <martin@ximian.com>
14181 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14182 when compiling corlib.
14184 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14186 * convert.cs (ExplicitConversion): We were reporting an error on
14187 certain conversions (object_type source to a value type, when the
14188 expression was `null') before we had a chance to pass it through
14189 the user defined conversions.
14191 * driver.cs: Replace / and \ in resource specifications to dots.
14194 * class.cs: Add check for duplicate operators. Fixes 52477
14196 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14198 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14199 that are in the middle of the statements, not only at the end.
14202 * class.cs (TypeContainer.AddField): No longer set the
14203 `HaveStaticConstructor' flag, now we call it
14204 `UserDefineStaticConstructor' to diferentiate the slightly
14205 semantic difference.
14207 The situation is that we were not adding BeforeFieldInit (from
14208 Modifiers.TypeAttr) to classes that could have it.
14209 BeforeFieldInit should be set to classes that have no static
14214 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14216 And most importantly Zoltan's comment:
14218 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14220 "I think beforefieldinit means 'it's ok to initialize the type sometime
14221 before its static fields are used', i.e. initialization does not need
14222 to be triggered by the first access to the type. Setting this flag
14223 helps the JIT to compile better code, since it can run the static
14224 constructor at JIT time, and does not need to generate code to call it
14225 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14226 this flag for lots of classes like String.
14228 csc sets this flag if the type does not have an explicit static
14229 constructor. The reasoning seems to be that if there are only static
14230 initalizers for a type, and no static constructor, then the programmer
14231 does not care when this initialization happens, so beforefieldinit
14234 This bug prevents the AOT compiler from being usable, since it
14235 generates so many calls to mono_runtime_class_init that the AOT code
14236 is much slower than the JITted code. The JITted code is faster,
14237 because it does not generate these calls if the vtable is type is
14238 already initialized, which is true in the majority of cases. But the
14239 AOT compiler can't do this."
14241 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14243 * class.cs (MethodData.Emit): Refactor the code so symbolic
14244 information is generated for destructors; For some reasons we
14245 were taking a code path that did not generate symbolic information
14248 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14250 * class.cs: Create a Constructor.CheckBase method that
14251 takes care of all validation type code. The method
14252 contains some code that was moved from Define.
14254 It also includes new code that checks for duplicate ctors.
14255 This fixes bug #55148.
14257 2004-03-09 Joshua Tauberer <tauberer@for.net>
14259 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14260 a { ... }-style array creation invokes EmitStaticInitializers
14261 which is not good for reference-type arrays. String, decimal
14262 and now null constants (NullCast) are not counted toward
14263 static initializers.
14265 2004-03-05 Martin Baulig <martin@ximian.com>
14267 * location.cs (SourceFile.HasLineDirective): New public field;
14268 specifies whether the file contains or is referenced by a "#line"
14270 (Location.DefineSymbolDocuments): Ignore source files which
14271 either contain or are referenced by a "#line" directive.
14273 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14275 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14276 direct access to our parent, so check the method inline there.
14278 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14280 * expression.cs (Invocation.EmitCall): Miguel's last commit
14281 caused a regression. If you had:
14286 In Foo the implict this would be null.
14288 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14290 * expression.cs (Invocation.EmitCall): If the method is not
14291 virtual, do not emit a CallVirt to it, use Call.
14293 * typemanager.cs (GetFullNameSignature): Improve the method to
14294 cope with ".ctor" and replace it with the type name.
14296 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14297 as an argument the ConstructorBuilder where it is being defined,
14298 to catch the recursive constructor invocations.
14300 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14302 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14303 routines to check if a type is an enumerable/enumerator allow
14304 classes that implement the IEnumerable or IEnumerator interfaces.
14306 * class.cs (Property, Operator): Implement IIteratorContainer, and
14307 implement SetYields.
14309 (Property.Define): Do the block swapping for get_methods in the
14310 context of iterators. We need to check if Properties also
14311 include indexers or not.
14313 (Operator): Assign the Block before invoking the
14314 OperatorMethod.Define, so we can trigger the Iterator code
14317 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14318 Property and Operator classes are not created when we parse the
14319 declarator but until we have the block completed, so we use a
14320 singleton SimpleIteratorContainer.Simple to flag whether the
14321 SetYields has been invoked.
14323 We propagate this setting then to the Property or the Operator to
14324 allow the `yield' to function.
14326 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14328 * codegen.cs: Implemented attribute support for modules.
14329 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14330 Assembly/Module functionality.
14332 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14333 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14334 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14336 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14338 * interface.cs (FindMembers): The operation is performed on all base
14339 interfaces and not only on the first. It is required for future CLS Compliance patch.
14341 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14343 * statement.cs, codegen.cs:
14344 This patch deals with patterns such as:
14346 public class List : IEnumerable {
14348 public MyEnumerator GetEnumerator () {
14349 return new MyEnumerator(this);
14352 IEnumerator IEnumerable.GetEnumerator () {
14356 public struct MyEnumerator : IEnumerator {
14361 Before, there were a few things we did wrong:
14362 1) we would emit callvirt on a struct, which is illegal
14363 2) we emited ldarg when we needed to emit ldarga
14364 3) we would mistakenly call the interface methods on an enumerator
14365 type that derived from IEnumerator and was in another assembly. For example:
14367 public class MyEnumerator : IEnumerator
14369 Would have the interface methods called, even if there were public impls of the
14370 method. In a struct, this lead to invalid IL code.
14372 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14374 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14377 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14379 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14381 * cs-parser.jay: Fix small regression: we were not testing V2
14382 compiler features correctly.
14384 * interface.cs: If the emit context is null, then create one
14386 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14388 * decl.cs (GetSignatureForError): New virtual method to get full name
14389 for error messages.
14391 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14392 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14394 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14395 Duplicated members and code in these classes has been removed.
14396 Better encapsulation in these classes.
14398 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14400 * assign.cs (Assign.DoResolve): When dealing with compound
14401 assignments, there is a new rule in ECMA C# 2.4 (might have been
14402 there before, but it is documented here) that states that in:
14406 If b is of type int, and the `op' is a shift-operator, then the
14407 above is evaluated as:
14411 * expression.cs (Binary.ResolveOperator): Instead of testing for
14412 int/uint/long/ulong, try to implicitly convert to any of those
14413 types and use that in pointer arithmetic.
14415 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14416 method to print information for from the type, not from the
14417 null-method we were given.
14419 2004-02-01 Duncan Mak <duncan@ximian.com>
14421 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14422 parsing for cmd, fixes bug #53694.
14424 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14426 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14427 in the member name duplication tests. Property and operator name duplication
14428 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14430 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14432 * interface.cs (PopulateMethod): Fixed crash when interface method
14433 returns not existing type (error test cs0246-3.cs).
14435 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14437 * cs-parser.jay (interface_accessors): Re-write actions to also
14438 store attributes attached to get and set methods. Fix spelling
14441 (inteface_property_declaration): Modify accordingly.
14443 (InterfaceAccessorInfo): New helper class to store information to pass
14444 around between rules that use interface_accessors.
14446 * interface.cs (Emit): Apply attributes on the get and set
14447 accessors of properties and indexers too.
14449 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14450 right MethodBuilder when applying attributes to the get and set accessors.
14452 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14454 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14456 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14458 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14460 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14462 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14463 changes that treat `yield' specially when present before `break'
14464 or `return' tokens.
14466 * cs-tokenizer.cs: yield is no longer a keyword.
14468 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14470 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14471 setting for default constructors.
14472 For default constructors are almost every time set wrong Modifier. The
14473 generated IL code has been alright. But inside mcs this values was
14474 wrong and this was reason why several of my CLS Compliance tests
14477 2004-01-22 Martin Baulig <martin@ximian.com>
14479 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14480 not a QualifiedIdentifier. This is what `type_name_expression'
14481 was previously doing.
14482 (type_name_expression): Removed; the code is now in
14483 `namespace_or_type_name'.
14484 (qualified_identifier): Removed, use `namespace_or_type_name'
14486 (QualifiedIdentifier): Removed this class.
14488 2004-01-22 Martin Baulig <martin@ximian.com>
14490 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14491 not a string as alias name.
14493 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14495 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14496 #52730 bug, and instead compute correctly the need to use a
14497 temporary variable when requesting an address based on the
14498 static/instace modified of the field and the constructor.
14500 2004-01-21 Martin Baulig <martin@ximian.com>
14502 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14503 class and namespace before looking up aliases. Fixes #52517.
14505 2004-01-21 Martin Baulig <martin@ximian.com>
14507 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14508 assinged in a 'try'; fixes exception4.cs.
14510 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14511 * class.cs : Implemented parameter-less constructor for TypeContainer
14513 * decl.cs: Attributes are now stored here. New property OptAttributes
14515 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14517 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14519 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14521 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14522 (CSharpSignature): New method for indexer and property signature.
14524 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14526 * pending.cs (IsVirtualFilter): Faster implementation.
14528 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14530 * typemanager.cs: Avoid inclusion of same assembly more than once.
14532 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14534 * cs-parser.jay: Fixed problem where the last assembly attribute
14535 has been applied also to following declaration (class, struct, etc.)
14537 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14539 * class.cs: Added error CS0538, CS0539 reporting.
14540 Fixed crash on Microsoft runtime when field type is void.
14542 * cs-parser.jay: Added error CS0537 reporting.
14544 * pending.cs: Added error CS0535 reporting.
14545 Improved error report for errors CS0536, CS0534.
14547 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14549 Merge a few bits from the Anonymous Method MCS tree.
14551 * statement.cs (ToplevelBlock): New class for toplevel methods,
14552 will hold anonymous methods, lifted variables.
14554 * cs-parser.jay: Create toplevel blocks for delegates and for
14555 regular blocks of code.
14557 2004-01-20 Martin Baulig <martin@ximian.com>
14559 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14560 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14561 and `NeedExplicitReturn'; added `IsLastStatement'.
14562 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14563 have a `ReturnLabel' or we're not unreachable.
14565 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14566 child's reachability; don't just override ours with it. Fixes
14567 #58058 (lluis's example).
14568 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14569 InFinally(), InLoop(), InSwitch() and
14570 BreakCrossesTryCatchBoundary() methods.
14572 * statement.cs (Return): Do all error checking in Resolve().
14573 Unless we are the last statement in a top-level block, always
14574 create a return label and jump to it.
14575 (Break, Continue): Do all error checking in Resolve(); also make
14576 sure we aren't leaving a `finally'.
14577 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14578 statement in a top-level block.
14579 (Block.Flags): Added `IsDestructor'.
14580 (Block.IsDestructor): New public property.
14582 2004-01-20 Martin Baulig <martin@ximian.com>
14584 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14586 2004-01-20 Martin Baulig <martin@ximian.com>
14588 * statement.cs (Statement.ResolveUnreachable): New public method.
14589 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14590 (Block.Resolve): Resolve unreachable statements.
14592 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14594 * expression.cs: We need to fix the case where we do
14595 not have a temp variable here.
14597 * assign.cs: Only expression compound assignments need
14598 temporary variables.
14600 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14602 * flowanalysis.cs: Reduce memory allocation in a few ways:
14603 - A block with no variables should not allocate a bit
14605 - A method with no out parameters does not need any tracking
14606 for assignment of the parameters, so we need not allocate
14609 public readonly Type[] VariableTypes;
14610 public readonly string[] VariableNames;
14611 Are redundant. The data is already stored in the variable
14612 map, so we need not allocate another array for it.
14613 - We need to add alot of checks for if (params | locals) == null
14614 due to the first two changes.
14616 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14618 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14619 implement IMemoryLocation, we store a copy on a local variable and
14620 take the address of it. Patch from Benjamin Jemlich
14622 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14623 to use a special "type_name_expression" rule which reduces the
14624 number of "QualifiedIdentifier" classes created, and instead
14625 directly creates MemberAccess expressions.
14627 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14629 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14630 that fixes #52853. Null literal assignment to ValueType
14632 * class.cs (MethodData.Emit): Instead of checking the name of the
14633 method to determine if its a destructor, create a new derived
14634 class from Method called Destructor, and test for that.
14636 * cs-parser.jay: Create a Destructor object instead of a Method.
14638 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14642 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14644 * expression.cs (Binary.ResolveOperator): Perform an implicit
14645 conversion from MethodGroups to their delegate types on the
14646 Addition operation.
14648 * delegate.cs: Introduce a new class DelegateCreation that is the
14649 base class for `NewDelegate' and `ImplicitDelegateCreation',
14650 factor some code in here.
14652 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14653 conversion from MethodGroups to compatible delegate types.
14655 * ecore.cs (Expression.Resolve): Do not flag error 654
14656 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14657 we allow conversions from MethodGroups to delegate types now.
14659 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14660 assignments in v2 either.
14662 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14664 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14665 static read-only fields in ctors.
14667 Applied patch from Benjamin Jemlich
14669 * expression.cs (UnaryMutator): Avoid leaking local variables.
14671 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14673 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14674 here to return true, as they can be used like this:
14676 (XXX) int.MEMBER ()
14678 Fixed 49836 and all the other dups
14680 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14682 * driver.cs: Implement /win32res and /win32icon.
14684 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14686 * cs-parser.jay: Add a rule to improve error handling for the
14687 common mistake of placing modifiers after the type.
14689 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14691 * cs-parser.jay (interface_event_declaration): Catch
14692 initialization of events on interfaces, and report cs0068
14694 * cs-parser.jay (interface_event_declaration): Catch
14695 initialization of events.
14697 * ecore.cs: Better report missing constructors.
14699 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14700 the error reporting done in the wrong place. Fix.
14702 * expression.cs (Binary.ResolveOperator): Catch the
14703 operator + (E x, E y) error earlier, and later allow for implicit
14704 conversions in operator +/- (E e, U x) from U to the underlying
14707 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14708 52596, if the container class is abstract, the default constructor
14709 is protected otherwise its public (before, we were always public).
14711 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14714 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14715 Jemlich that fixes bug #52597, MCS was generating invalid code for
14716 idisposable structs. Thanks to Ben for following up with this
14719 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14721 * driver.cs: Allow assemblies without code to be generated, fixes
14724 2004-01-07 Nick Drochak <ndrochak@gol.com>
14726 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14728 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14730 * cs-parser.jay: Add rules to improve error reporting if fields or
14731 methods are declared at the namespace level (error 116)
14733 * Add rules to catch event add/remove
14735 2004-01-04 David Sheldon <dave-mono@earth.li>
14737 * expression.cs: Added matching ")" to error message for
14740 2004-01-03 Todd Berman <tberman@gentoo.org>
14742 * ecore.cs, attribute.cs:
14743 Applying fix from #52429.
14745 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14747 * ecore.cs, expression.cs, statement.cs:
14748 Total rewrite of how we handle branching. We
14749 now handle complex boolean expressions with fewer
14750 jumps. As well if (x == 0) no longer emits a ceq.
14752 if (x is Foo) is much faster now, because we generate
14755 Overall, we get a pretty big improvement on our benchmark
14756 tests. The code we generate is smaller and more readable.
14758 I did a full two-stage bootstrap. The patch was reviewed
14759 by Martin and Miguel.
14761 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14763 * cs-parser.jay: Make primary_expression not take a QI.
14764 we dont need this because the member_access rule covers
14765 us here. So we replace the rule with just IDENTIFIER.
14767 This has two good effects. First, we remove a s/r conflict.
14768 Second, we allocate many fewer QualifiedIdentifier objects.
14770 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14772 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14773 set the correct information via SRE. This prevents
14774 hanging on the MS runtime. Fixes #29374.
14776 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14778 * convert.cs: correctly handle conversions to value types
14779 from Enum and ValueType as unboxing conversions.
14781 Fixes bug #52569. Patch by Benjamin Jemlich.
14783 2004-01-02 Ravi Pratap <ravi@ximian.com>
14785 * expression.cs (BetterConversion): Prefer int -> uint
14786 over int -> ulong (csc's behaviour). This fixed bug #52046.
14788 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14790 * decl.cs (MemberCache.FindMembers): now returns a
14793 * typemanager.cs: In general, go with with ^^.
14794 (CopyNewMethods): take an IList.
14795 (RealMemberLookup): Only allocate an arraylist
14796 if we copy from two sets of methods.
14798 This change basically does two things:
14799 1) Fewer array lists allocated due to CopyNewMethods.
14800 2) the explicit cast in MemberList costed ALOT.
14802 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14804 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14805 a hashtable to avoid needless string allocations when an identifier is
14806 used more than once (the common case).
14808 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14810 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14811 is broken, it will not return anything. So, we
14812 have to use the information we have in mcs to
14815 * typemanager.cs: Add a cache for GetInterfaces,
14816 since this will now be used more often (due to ^^)
14818 (GetExplicitInterfaces) New method that gets the
14819 declared, not effective, interfaces on a type
14820 builder (eg, if you have interface IFoo, interface
14821 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14824 This patch makes MCS able to bootstrap itself on
14827 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14829 * expression.cs: Remove the Nop's that Miguel put
14832 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14834 * report.cs, codegen.cs: Give the real stack trace to
14835 the error when an exception is thrown.
14837 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14839 * decl.cs: only allocate hashtables for ifaces if
14842 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14844 * expression.cs: fix the error from cs0121-2.cs
14845 (a parent interface has two child interfaces that
14846 have a function with the same name and 0 params
14847 and the function is called through the parent).
14849 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14851 * class.cs, rootcontext.cs, typmanager.cs: do not
14854 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14856 * codegen.cs: remove stack for the ec flow branching.
14857 It is already a linked list, so no need.
14859 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14861 * Makefile: Allow custom profiler here.
14863 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14865 * typemanager.cs (LookupType):
14866 - Use a static char [], because split takes
14867 a param array for args, so it was allocating
14869 - Do not store true in a hashtable, it boxes.
14871 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14873 * flowanalysis.cs: bytify common enums.
14875 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14877 * modifiers.cs: Add a new set of flags for the
14878 flags allowed on explicit interface impls.
14879 * cs-parser.jay: catch the use of modifiers in
14880 interfaces correctly.
14881 * class.cs: catch private void IFoo.Blah ().
14883 All related to bug #50572.
14885 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14887 * decl.cs: Rewrite the consistant accessability checking.
14888 Accessability is not linear, it must be implemented in
14889 a tableish way. Fixes #49704.
14891 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14893 * expression.cs: Handle negation in a checked context.
14894 We must use subtraction from zero. Fixes #38674.
14896 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14898 * class.cs: Ignore static void main in DLLs.
14899 * rootcontext.cs: Handle the target type here,
14900 since we are have to access it from class.cs
14901 * driver.cs: account for the above.
14903 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14905 * report.cs: Give line numbers and files if available.
14907 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14909 * driver.cs: Implement /addmodule.
14911 * typemanager.cs: Change 'modules' field so it now contains Modules not
14914 2003-12-20 Martin Baulig <martin@ximian.com>
14916 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14917 (FieldBase.IsAssigned): Removed this field.
14918 (FieldBase.SetAssigned): New public method.
14919 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14921 2003-12-20 Martin Baulig <martin@ximian.com>
14923 * expression.cs (LocalVariableReference.DoResolve): Don't set
14924 `vi.Used' if we're called from DoResolveLValue().
14926 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14927 returns the usage vector it just merged into the current one -
14928 pass this one to UsageWarning().
14929 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14930 of the `EmitContext', don't call this recursively on our children.
14932 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14934 * driver.cs: Implement /target:module.
14936 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14938 * support.cs (CharArrayHashtable): New helper class.
14940 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
14941 char arrays, not strings, so we can avoid creating a string in
14942 consume_identifier if the identifier is a keyword.
14944 2003-12-16 Martin Baulig <martin@ximian.com>
14946 * statement.cs (LocalInfo.Assigned): Removed this property.
14947 (LocalInfo.Flags): Removed `Assigned'.
14948 (LocalInfo.IsAssigned): New public method; takes the EmitContext
14949 and uses flow analysis.
14950 (Block.UsageWarning): Made this method private.
14951 (Block.Resolve): Call UsageWarning() if appropriate.
14953 * expression.cs (LocalVariableReference.DoResolve): Always set
14954 LocalInfo.Used here.
14956 2003-12-13 Martin Baulig <martin@ximian.com>
14958 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
14959 any value here; we're now using flow analysis to figure out
14960 whether a statement/block returns a value.
14962 2003-12-13 Martin Baulig <martin@ximian.com>
14964 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
14966 (FlowBranching.MergeFinally): Don't call
14967 `branching.CheckOutParameters()' here, this is called in
14969 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
14970 when adding the `finally' vector.
14972 2003-12-13 Martin Baulig <martin@ximian.com>
14975 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
14976 actually work and also fix #48962.
14978 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
14980 * decl.cs: Do not check System.Object for nested types,
14981 since we know it does not have any. Big bang for buck:
14984 Run 1: 8.35 seconds
14985 Run 2: 8.32 seconds
14986 corlib: 17.99 seconds
14988 Run 1: 8.17 seconds
14989 Run 2: 8.17 seconds
14990 corlib: 17.39 seconds
14992 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
14994 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
14995 time we are returning 0 members, so we save alot here.
14997 2003-12-11 Martin Baulig <martin@ximian.com>
14999 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15000 `MergeChild()', also just take the `FlowBranching' as argument;
15001 call Merge() on it and return the result.
15002 (FlowBranching.Merge): We don't need to do anything if we just
15005 2003-12-11 Martin Baulig <martin@ximian.com>
15007 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15008 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15009 Maurer for this idea.
15011 2003-12-11 Martin Baulig <martin@ximian.com>
15013 * flowanalysis.cs (MergeResult): This class is now gone; we now
15014 use the `UsageVector' for this. The reason for this is that if a
15015 branching just has one sibling, we don't need to "merge" them at
15016 all - that's the next step to do.
15017 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15020 2003-12-11 Martin Baulig <martin@ximian.com>
15022 Reworked flow analyis and made it more precise and bug-free. The
15023 most important change is that we're now using a special `Reachability'
15024 class instead of having "magic" meanings of `FlowReturns'. I'll
15025 do some more cleanups and optimizations and also add some more
15026 documentation this week.
15028 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15029 largely reworked this class.
15030 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15031 the new `Reachability' class instead of having "magic" values here.
15032 (FlowBranching): We're now using an instance of `Reachability'
15033 instead of having separate `Returns', `Breaks' etc. fields.
15035 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15036 based on flow analysis; ignore the return value of block.Emit ().
15038 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15040 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15041 if they are private.
15043 2003-12-09 Martin Baulig <martin@ximian.com>
15045 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15046 call them directly on the UsageVector.
15048 2003-12-09 Martin Baulig <martin@ximian.com>
15050 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15051 Changed return type from `FlowReturns' to `Reachability'.
15053 2003-12-09 Martin Baulig <martin@ximian.com>
15055 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15056 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15057 `Reachable' fields with a single `Reachability' one.
15059 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15061 * class.cs (FindMembers): Remove foreach's.
15066 Run 1: 8.74 seconds
15067 Run 2: 8.71 seconds
15070 Run 1: 8.64 seconds
15071 Run 2: 8.58 seconds
15074 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15079 This patch does a few things:
15080 1. EmptyStatement is now a singleton, so it is never reallocated.
15081 2. All blah is EmptyStatement constructs have been changed to
15082 blah == EmptyStatement.Value, which is much faster and valid
15083 now that EmptyStatement is a singleton.
15084 3. When resolving a block, rather than allocating a new array for
15085 the non-empty statements, empty statements are replaced with
15086 EmptyStatement.Value
15087 4. Some recursive functions have been made non-recursive.
15088 Mainly the performance impact is from (3), however (1) and (2) are needed for
15089 this to work. (4) does not make a big difference in normal situations, however
15090 it makes the profile look saner.
15095 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15096 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15097 Total memory allocated: 56397 KB
15100 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15101 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15102 Total memory allocated: 55666 KB
15104 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15106 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15107 than the hashtable in a hashtable version
15109 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15110 we always end up concating a string. This results in a huge perf
15111 loss, because many strings have to be tracked by the GC. In this
15112 patch, we first use a hashtable that works with two keys, so that
15113 the strings do not need to be concat'ed.
15117 Run 1: 8.74 seconds
15118 Run 2: 8.71 seconds
15121 Run 1: 8.65 seconds
15122 Run 2: 8.56 seconds
15124 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15126 * Makefile: Add a new target `do-time' that does a quick and simple
15127 profile, leaving easy to parse output.
15129 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15131 * codegen.cs (Init): Create the dynamic assembly with
15132 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15134 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15136 * support.cs: Make the PtrHashtable use only one
15137 instance of its comparer.
15139 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15141 * typemanager.cs: Fix lookup of GetNamespaces.
15143 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15145 * expression.cs: Removed redundant line.
15147 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15148 ArrayLists, use for loops with bounds.
15150 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15153 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15154 arraylists, use for loop with bounds.
15156 The above three changes give us a 0.071 second performance
15157 improvement out of 3.294 seconds down to 3.223. On my machine
15158 the above changes reduced the memory usage by 1,387 KB during
15159 compiler bootstrap.
15161 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15162 QualifiedIdentifiers. Before we created a new string through
15163 concatenation, and mostly later on, the result would be
15164 manipulated by DecomposeQI through string manipulation.
15166 This reduced the compiler memory usage for bootstrapping from
15167 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15168 compile times in 0.05 seconds.
15170 2003-11-28 Dick Porter <dick@ximian.com>
15172 * support.cs: Do string compares with the Invariant culture.
15180 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15181 the comparison is done with the Invariant culture.
15183 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15185 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15186 GetEnumerator method.
15188 (ProbeCollectionType): Iterate starting at the most specific type
15189 upwards looking for a GetEnumerator
15191 * expression.cs: Shift count can be up to 31 for int/uint and 63
15194 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15196 * statement.cs (Block.LookupLabel): Also look for the label on the
15197 children blocks. Use a hash table to keep track of visited
15200 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15201 we actually did transform the other operand, otherwise fall back
15202 to the common codepath that casts to long.
15204 * cs-tokenizer.cs: Use the same code pattern as the int case.
15205 Maybe I should do the parsing myself, and avoid depending on the
15206 Parse routines to get this done.
15208 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15210 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15211 which fixes bug 51347. This time test it.
15213 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15214 attributes for example can not tell the difference between these.
15215 The difference was only a syntax feature of the language.
15217 * attribute.cs: Apply attributes to delegates.
15219 * delegate.cs: Call the apply attributes method.
15221 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15223 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15224 comparing 0 vs Byte.MinValue, not the value
15226 (ImplicitConversionRequired): When reporting a conversion error,
15227 use error 31 to print out the constant error instead of the
15230 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15231 which fixes bug 51347.
15233 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15235 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15236 which fixes the -warnaserror command line option.
15238 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15240 * cfold.cs (DoNumericPromotions): During constant folding of
15241 additions on UIntConstant, special case intconstants with
15242 IntConstants like we do on the expression binary operator.
15244 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15246 * convert.cs (ImplicitReferenceConversion): We were missing a case
15247 (System.Enum are not value types or class types, so we need to
15248 classify them separatedly).
15250 * driver.cs: We do not support error 2007.
15252 2003-11-12 Jackson Harper <jackson@ximian.com>
15254 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15255 system directory. Also use the full file name so users can
15256 libraries names mscorlib-o-tron.dll in a non system dir.
15258 2003-11-10 Martin Baulig <martin@ximian.com>
15260 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15261 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15262 calling `ResolveType()' on them, directly assign their `Type'.
15264 2003-11-08 Martin Baulig <martin@ximian.com>
15266 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15267 return value and the `out parent' parameter.
15268 (TypeContainer.DefineType): Moved the CS0644 check into
15269 GetClassBases(). Don't pass the interface types to the
15270 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15271 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15273 * ecore.cs (TypeExpr.IsAttribute): New property.
15274 (TypeExpr.GetInterfaces): New method.
15276 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15277 TypeExpr instead of a Type.
15278 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15279 (Interface.DefineType): Don't pass the interface types to the
15280 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15281 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15283 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15284 instead of a `Type[]'.
15285 (TypeManager.RegisterBuilder): Likewise.
15286 (TypeManager.AddUserInterface): Likewise.
15287 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15288 `Type[]' and also return a `TypeExpr[]'.
15289 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15291 2003-11-08 Martin Baulig <martin@ximian.com>
15293 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15296 2003-11-08 Martin Baulig <martin@ximian.com>
15298 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15299 TypeManager.ResolveExpressionTypes().
15301 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15302 instead of an Expression.
15303 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15304 (TypeExpression): New public class; formerly known as `TypeExpr'.
15306 * expression.cs (ComposedCast): Derive from TypeExpr.
15308 * typemanager.cs (TypeManager.system_*_expr): These are now
15309 TypExpr's instead of Expression's.
15310 (TypeManager.ResolveExpressionTypes): New public static function;
15311 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15314 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15316 * expression.cs (New.DoResolve): Do not dereference value that
15317 might be a null return.
15319 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15320 sure that the constant value has the right type. Fixes an
15321 unreported bug, similar to 50425.
15323 * const.cs (Const.LookupConstantValue): Call
15324 ImplicitStandardConversionExists before doing a conversion to
15325 avoid havng the TypeManager.ChangeType do conversions.
15327 Reduced the number of casts used
15329 (Const.ChangeType): New routine to enable reuse of the constant
15330 type changing code from statement.
15332 * typemanager.cs (ChangeType): Move common initialization to
15333 static global variables.
15337 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15338 every value type to go through, even if it was void. Fix that.
15340 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15341 character of the define, and the is_identifier_part_character for
15342 the rest of the string.
15344 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15346 * expression.cs (UnaryMutator.EmitCode): When I updated
15347 LocalVariableReference.DoResolve, I overdid it, and dropped an
15348 optimization done on local variable references.
15350 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15352 * ecore.cs: Convert the return from Ldlen into an int.
15354 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15356 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15357 the accessibility, this is a special case for toplevel non-public
15358 classes (internal for instance).
15360 2003-10-20 Nick Drochak <ndrochak@gol.com>
15362 * ecore.cs: Fix typo and build. Needed another right paren.
15364 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15366 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15367 `internal' case regular and protected, but not allowing protected
15368 to be evaluated later. Bug 49840
15370 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15372 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15373 to kb.Nlast, and not the kb.nFirst to isolate the switch
15376 Extract the underlying type, so enumerations of long/ulong are
15377 treated like long/ulong.
15379 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15381 * expression.cs (New): Overload the meaning of RequestedType to
15382 track the possible creation of the NewDelegate type, since
15383 DoResolve is invoked more than once for new constructors on field
15386 See bugs: #48800 and #37014
15388 * cs-parser.jay (declare_local_constants): Take an arraylist
15389 instead of a single constant.
15391 (local_constant_declaration): It should take a
15392 constant_declarators, not a constant_declarator. Fixes 49487
15394 * convert.cs: Fix error report.
15396 2003-10-13 Jackson Harper <jackson@ximian.com>
15398 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15401 2003-10-09 Martin Baulig <martin@ximian.com>
15403 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15405 (MethodCore.DoDefineParameters): Removed the TypeContainer
15406 argument; use the DeclSpace which was passed to the .ctor instead.
15407 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15408 TypeContainer; we only need a DeclSpace here.
15410 2003-10-09 Martin Baulig <martin@ximian.com>
15412 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15414 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15415 EmitContext's .ctor.
15417 2003-10-09 Martin Baulig <martin@ximian.com>
15419 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15420 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15421 AsAccessible(), moved them as well.
15423 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15425 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15427 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15429 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15431 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15432 generation for >=, as spotted by Paolo, bug 48679.
15433 Patch from David Waite.
15435 * cs-tokenizer.cs: Add handling for #pragma.
15437 * cs-parser.jay: Allow for both yield and yield return in the
15438 syntax. The anti-cobolization of C# fight will go on!
15440 * class.cs (TypeBuilder.DefineType): Catch error condition here
15441 (Parent.DefineType erroring out and returning null).
15443 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15444 coping with enumerations variables, we were mistakenly processing
15445 them as a regular value type instead of built-in types. Fixes the
15448 * typemanager.cs (IsBuiltinOrEnum): New method.
15450 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15452 * cs-parser.jay: Upgrade: yield now needs the return clause.
15454 2003-09-19 Martin Baulig <martin@ximian.com>
15456 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15457 `MemberCache parent' argument. Normally, an interface doesn't
15458 have a parent type except System.Object, but we use this in gmcs
15459 for generic type parameters.
15461 2003-09-18 Martin Baulig <martin@ximian.com>
15463 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15464 on `type.IsInterface'; don't check whether the type has a parent
15465 to determine whether it's an interface.
15467 2003-09-15 Martin Baulig <martin@ximian.com>
15469 * class.cs (TypeContainer.DefineType): Added an error flag to
15470 avoid reporting duplicate CS0146's ("class definition is
15473 * driver.cs (Driver.MainDriver): Abort if
15474 RootContext.ResolveTree() reported any errors.
15476 2003-09-07 Martin Baulig <martin@ximian.com>
15478 * report.cs (Error, Warning): Added overloaded versions which take
15479 a `params object[] args' and call String.Format().
15481 2003-09-07 Martin Baulig <martin@ximian.com>
15483 * decl.cs (DeclSpace..ctor): Don't call
15484 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15485 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15486 (DeclSpace.RecordDecl): New method.
15488 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15490 2003-09-02 Ravi Pratap <ravi@ximian.com>
15492 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15493 value attributes to be applied to ParameterBuilders.
15495 * class.cs (MethodCore.LabelParameters): Make static and more
15496 generic so that it can be used from other places - like interface
15497 methods, for instance.
15499 * interface.cs (Interface.Emit): Call LabelParameters before
15500 emitting attributes on the InterfaceMethod.
15502 2003-08-26 Martin Baulig <martin@ximian.com>
15504 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15505 resolving aliases; fixes #47927.
15507 2003-08-26 Martin Baulig <martin@ximian.com>
15509 * statement.cs (Using.DoResolve): This is internally emitting a
15510 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15511 do not always return. Fixes #47681.
15513 2003-08-26 Martin Baulig <martin@ximian.com>
15515 * decl.cs (MemberCore): Moved WarningNotHiding(),
15516 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15518 (AdditionResult): Make this nested in DeclSpace.
15519 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15520 argument; call NamespaceEntry.Define() unless we're nested in a
15523 * namespace.cs (Namespace.DefineName): New public function. This
15524 is called from DeclSpace's .ctor to add
15525 (Namespace.Lookup): Include DeclSpaces in the lookup.
15527 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15529 * const.cs (Const): Derive from MemberBase, not MemberCore.
15531 2003-08-25 Martin Baulig <martin@ximian.com>
15533 * convert.cs (Convert.ExplicitReferenceConversion): When
15534 converting from an interface type to a class, unbox if the target
15535 type is a struct type. Fixes #47822.
15537 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15539 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15542 2003-08-22 Martin Baulig <martin@ximian.com>
15544 * class.cs (TypeManager.DefineType): When defining a nested type,
15545 call DefineType() on our parent; fixes #47801.
15547 2003-08-22 Martin Baulig <martin@ximian.com>
15549 * class.cs (MethodData.Define): While checking if a method is an
15550 interface implementation, improve the test a bit more to fix #47654.
15552 2003-08-22 Martin Baulig <martin@ximian.com>
15554 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15555 correctly; fixes #47722.
15557 2003-08-22 Martin Baulig <martin@ximian.com>
15559 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15560 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15562 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15564 2003-08-22 Martin Baulig <martin@ximian.com>
15566 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15567 can only be assigned in static constructors. Fixes #47161.
15569 2003-08-22 Martin Baulig <martin@ximian.com>
15571 Rewrote and improved the flow analysis code.
15573 * flowbranching.cs (FlowBranching): Make this class abstract.
15574 (FlowBranching.CreateBranching): New static function to create a
15575 new flow branching.
15576 (FlowBranchingBlock, FlowBranchingException): New classes.
15577 (FlowBranching.UsageVector.Type): New public readonly field.
15578 (FlowBranching.UsageVector.Breaks): Removed the setter.
15579 (FlowBranching.UsageVector.Returns): Removed the setter.
15580 (FlowBranching.UsageVector): Added Break(), Return(),
15581 NeverReachable() and Throw() methods to modify the reachability.
15582 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15583 done by FlowBranching.Merge().
15584 (FlowBranching.UsageVector.MergeChild): New method; merges the
15585 merge result into the current vector.
15586 (FlowBranching.Merge): New abstract method to merge a branching.
15588 2003-08-12 Martin Baulig <martin@ximian.com>
15590 * expression.cs (Indirection.CacheTemporaries): Create the
15591 LocalTemporary with the pointer type, not its element type.
15593 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15595 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15596 token was a keyword or not.
15598 Add `error' options where an IDENTIFIER was expected; Provide
15599 CheckToken and CheckIdentifierToken convenience error reporting
15602 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15604 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15605 NameSpaceEntry NameSpaceEntry.
15607 (LookupInterfaceOrClass): Avoid creating a full qualified name
15608 from namespace and name: avoid doing lookups when we know the
15609 namespace is non-existant. Use new Tree.LookupByNamespace which
15610 looks up DeclSpaces based on their namespace, name pair.
15612 * driver.cs: Provide a new `parser verbose' to display the
15613 exception thrown during parsing. This is turned off by default
15614 now, so the output of a failure from mcs is more graceful.
15616 * namespace.cs: Track all the namespaces defined in a hashtable
15619 (IsNamespace): New method
15621 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15623 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15624 we know that we need to concatenate (full typename can never be
15629 * statement.cs: Use a bitfield; Do not initialize to null things
15630 which are done by the constructor by default.
15632 * cs-parser.jay: bug fix, parameter was 4, not 3.
15634 * expression.cs: Just use the property;
15636 * statement.cs: No need for GetVariableInfo method.
15638 2003-08-08 Martin Baulig <martin@ximian.com>
15640 * flowanalysis.cs (FlowReturns): This is now nested in the
15641 `FlowBranching' class.
15642 (MyBitVector): Moved this here from statement.cs.
15643 (FlowBranching.SiblingType): New enum type.
15644 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15646 2003-08-07 Martin Baulig <martin@ximian.com>
15648 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15649 `FlowBranching' class and called `BranchingType'.
15651 2003-08-07 Martin Baulig <martin@ximian.com>
15653 * flowanalysis.cs: Moved all the control flow analysis code into
15656 2003-08-07 Martin Baulig <martin@ximian.com>
15658 * assign.cs (Assign.DoResolve): `target' must either be an
15659 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15662 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15664 * expression.cs (BinaryMethod): This kind of expression is created by the
15665 Binary class if it determines that the operator has to be handled
15668 (BinaryDelegate): This kind of expression is created if we are
15669 dealing with a + or - operator on delegates.
15671 (Binary): remove method, argumetns, and DelegateOperator: when
15672 dealing with methods,
15674 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15676 * statement.cs (Block): use bitfields for the three extra booleans
15677 we had in use. Remove unused topblock parameter.
15679 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15681 * assign.cs: Drop extra unneeded tests.
15683 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15685 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15687 * statement.cs (Foreach): Use VariableStorage instead of
15690 * codegen.cs (VariableStorage): New class used by clients that
15691 require a variable stored: locals or fields for variables that
15692 need to live across yield.
15694 Maybe provide a convenience api for EmitThis+EmitLoad?
15696 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15699 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15701 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15702 RemapParameterLValue): New methods that are used to turn a
15703 precomputed FieldInfo into an expression like this:
15707 The idea is to use this instead of making LocalVariableReference
15708 have more than one meaning.
15710 * cs-parser.jay: Add error production to BASE.
15712 * ecore.cs: Deal with TypeManager.GetField returning null, which
15713 is now a valid return value.
15715 (FieldExprNoAddress): New expression for Fields whose address can
15718 * expression.cs (LocalVariableReference): During the resolve
15719 phases, create new expressions if we are in a remapping context.
15720 Remove code that dealt with remapping here.
15722 (ParameterReference): same.
15724 (ProxyInstance): New expression, like the `This' expression, but
15725 it is born fully resolved. We know what we are doing, so remove
15726 the errors that are targeted to user-provided uses of `this'.
15728 * statement.cs (Foreach): our variable is now stored as an
15729 Expression; During resolution, follow the protocol, dont just
15730 assume it will return this.
15732 2003-08-06 Martin Baulig <martin@ximian.com>
15734 * support.cs (SeekableStreamReader.cs): New public class.
15736 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15737 SeekableStreamReader instead of the normal StreamReader.
15739 2003-08-04 Martin Baulig <martin@ximian.com>
15741 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15742 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15743 deambiguate casts and delegate invocations.
15744 (parenthesized_expression): Use the new tokens to ensure this is
15745 not a cast of method invocation.
15747 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15748 when reading a `)' and Deambiguate_CloseParens () was previously
15751 * expression.cs (ParenthesizedExpression): New class. This is
15752 just used for the CS0075 test.
15753 (Binary.DoResolve): Check for CS0075.
15755 2003-07-29 Ravi Pratap <ravi@ximian.com>
15757 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15758 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15759 reference comparison.
15761 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15762 examine the ReturnType for equality - this is necessary in the
15763 cases of implicit and explicit operators whose signature also
15764 includes the return type.
15766 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15768 * namespace.cs: Cache the result of the namespace computation,
15769 instead of computing it every time.
15771 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15773 * decl.cs: Use a global arraylist that we reuse over invocations
15774 to avoid excesive memory consumption. Reduces memory usage on an
15775 mcs compile by one meg (45 average).
15777 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15778 private, work around that.
15780 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15782 * literal.cs (IntLiteral): Define Zero and One static literals.
15784 * cs-parser.jay (integer_literal): use static literals to reduce
15785 memory usage for the most used literals (0, 1 and -1). 211kb
15786 reduced in memory usage.
15788 Replace all calls to `new ArrayList' with `new
15789 ArrayList(4)' which is a good average number for most allocations,
15790 and also requires only 16 bytes of memory for its buffer by
15793 This reduced MCS memory usage in seven megabytes for the RSS after
15796 2003-07-28 Ravi Pratap <ravi@ximian.com>
15798 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15799 handle params methods the correct way by forming only one
15800 applicable set with params and normal methods in them. Earlier we
15801 were looking at params methods only if we found no normal methods
15802 which was not the correct thing to do.
15804 (Invocation.BetterFunction): Take separate arguments indicating
15805 when candidate and the best method are params methods in their
15808 This fixes bugs #43367 and #46199.
15810 * attribute.cs: Documentation updates.
15812 (CheckAttribute): Rename to CheckAttributeTarget.
15813 (GetValidPlaces): Rename to GetValidTargets.
15815 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15816 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15820 2003-07-28 Martin Baulig <martin@ximian.com>
15822 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15823 name when looking up the base class of a nested class. Fixes #46977.
15825 2003-07-26 Martin Baulig <martin@ximian.com>
15827 * expression.cs (Indexers.Indexer): New nested struct; contains
15828 getter, setter and the indexer's type.
15829 (Indexers.Properties): This is now an ArrayList of
15830 Indexers.Indexer's.
15831 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15832 indexer doesn't have any getters.
15834 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15835 for embedded property and indexer assignments.
15837 2003-07-26 Martin Baulig <martin@ximian.com>
15839 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15840 preprocessor directive is not the first non-whitespace character
15843 2003-07-26 Martin Baulig <martin@ximian.com>
15845 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15846 namespace parsing, follow the spec more closely.
15848 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15849 NamespaceEntry.Lookup().
15851 2003-07-25 Martin Baulig <martin@ximian.com>
15853 * MethodCore.cs (OverridesSomething): New public field; it's set
15854 from TypeContainer.DefineMembers if this method overrides
15855 something (which doesn't need to be a method). Fix #39462.
15857 2003-07-25 Ravi Pratap <ravi@ximian.com>
15859 * typemanager.cs (GetMembers): Ensure that the list of members is
15860 reversed. This keeps things in sync.
15862 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15863 find an AttributeUsage attribute.
15865 * expression.cs (Invocation.OverloadResolve): Perform the check
15866 which disallows Invoke to be directly called on a Delegate.
15868 (Error_InvokeOnDelegate): Report error cs1533.
15870 2003-07-25 Martin Baulig <martin@ximian.com>
15872 * expression.cs (Indexers.GetIndexersForType): Only look in the
15873 interface hierarchy if the requested type is already an
15874 interface. Fixes #46788 while keeping #46502 fixed.
15876 2003-07-25 Martin Baulig <martin@ximian.com>
15878 * class.cs (TypeContainer.DefineMembers): Check whether all
15879 readonly fields have been assigned and report warning CS0649 if
15882 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15885 2003-07-24 Ravi Pratap <ravi@ximian.com>
15887 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15888 returned from GetMethods to make things consistent with the
15889 assumptions MCS makes about ordering of methods.
15891 This should comprehensively fix bug #45127 and it does :-)
15893 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15894 ordering is actually reverse.
15896 * Clean up some debug messages I left lying around.
15898 * interface.cs (Populate*): Get rid of code which emits attributes
15899 since the stage in which we emit attributes is the 'Emit' stage,
15900 not the define stage.
15902 (Emit): Move attribute emission for interface members here.
15904 2003-07-22 Ravi Pratap <ravi@ximian.com>
15906 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15907 closely: we eliminate methods in base types when we have an
15908 applicable method in a top-level type.
15910 Please see section 14.5.5.1 for an exact description of what goes
15913 This fixes bug #45127 and a host of other related to corlib compilation.
15915 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15916 array is the method corresponding to the top-level type (this is
15917 because of the changes made to icall.c) so we change this
15920 (MethodGroupExpr.Name): This too.
15922 * typemanager.cs (GetElementType): New method which does the right
15923 thing when compiling corlib.
15925 * everywhere: Make use of the above in the relevant places.
15927 2003-07-22 Martin Baulig <martin@ximian.com>
15929 * cs-parser.jay (invocation_expression): Moved
15930 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15931 `cast_expression', but create a InvocationOrCast which later
15932 resolves to either an Invocation or a Cast.
15934 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15935 method; call this before EmitStatement() to make sure that this
15936 expression can be used as a statement.
15938 * expression.cs (InvocationOrCast): New class; resolves to either
15939 an Invocation or a Cast.
15941 * statement.cs (StatementExpression): Call ResolveStatement() on
15942 the ExpressionStatement before emitting it.
15944 2003-07-21 Martin Baulig <martin@ximian.com>
15946 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15947 `ref' and `out' attributes match; fixes #46220.
15948 (MemberAccess.ResolveMemberAccess): You can't reference a type
15949 through an expression; fixes #33180.
15950 (Indexers.GetIndexersForType): Don't return the indexers from
15951 interfaces the class implements; fixes #46502.
15953 2003-07-21 Martin Baulig <martin@ximian.com>
15955 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15956 CS0661 checks; fixes bug #30442.
15958 2003-07-21 Martin Baulig <martin@ximian.com>
15960 * decl.cs (AdditionResult): Added `Error'.
15962 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15964 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
15965 makes cs0031.cs actually work.
15967 2003-07-20 Martin Baulig <martin@ximian.com>
15969 * namespace.cs: Fixed that bug which caused a crash when compiling
15970 the debugger's GUI.
15972 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15974 * typemanager.cs (LookupTypeReflection): Never expose types which
15975 are NotPublic, NestedPrivate, NestedAssembly, or
15976 NestedFamANDAssem. We used to return these, and later do a check
15977 that would report a meaningful error, but the problem is that we
15978 would not get the real match, if there was a name override.
15980 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15982 * namespace.cs (Namespace, Name): Do not compute the namespace
15983 name dynamically, compute it in the constructor. This reduced
15984 memory usage by 1697 KB.
15986 * driver.cs: Use --pause to pause at the end.
15988 2003-07-17 Peter Williams <peter@newton.cx>
15990 * Makefile: Change the name of the test target so that it doesn't
15991 conflict with the recursive test target.
15993 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15995 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15996 AddressOf): Do not use EmitThis, that was wrong, use the actual
15999 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16001 * class.cs (MethodData.Define): While checking if a method is an
16002 interface implementation, improve the test: If we are not public
16003 (use new test here: use the computed MethodAttributes directly,
16004 instead of the parsed modifier flags) check if the `implementing'
16005 method comes from an interface or not.
16007 * pending.cs (VerifyPendingMethods): Slightly better error
16010 * makefile: add test target that does the mcs bootstrap.
16012 2003-07-16 Ravi Pratap <ravi@ximian.com>
16014 * interface.cs (Define): Do nothing here since there are no
16015 members to populate etc. Move the attribute emission out of here
16016 since this was just totally the wrong place to put it. Attribute
16017 application happens during the 'Emit' phase, not in the 'Define'
16020 (Emit): Add this method and move the attribute emission here
16022 * rootcontext.cs (EmitCode): Call the Emit method on interface
16025 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16027 * expression.cs (OverloadResolve): Report error only if Location
16028 is not 'Null' which means that there was a probe going on.
16030 2003-07-14 Martin Baulig <martin@ximian.com>
16032 * expression.cs (ConditionalLogicalOperator): New public class to
16033 implement user defined conditional logical operators.
16034 This is section 14.11.2 in the spec and bug #40505.
16036 2003-07-14 Martin Baulig <martin@ximian.com>
16038 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16040 2003-07-14 Martin Baulig <martin@ximian.com>
16042 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16044 * ecore.cs (IVariable.VerifyFixed): New interface method.
16046 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16047 operator, check whether the variable is actually fixed. Fixes bug
16048 #36055. Set a variable definitely assigned when taking its
16049 address as required by the spec.
16051 * statement.cs (LocalInfo.IsFixed): New field.
16052 (LocalInfo.MakePinned): Set `IsFixed' to true.
16054 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16056 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16057 for .ctors, ensure that we only ask for members declared in the
16058 attribute type (BindingFlags.DeclaredOnly).
16062 * expression.cs (Error_WrongNumArguments): Report error 1501
16063 correctly the way CSC does.
16065 2003-07-13 Martin Baulig <martin@ximian.com>
16067 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16068 lookup on the fully qualified name, to make things like "X.X" work
16069 where "X.X" is a fully qualified type name, but we also have a
16070 namespace "X" in the using list. Fixes #41975.
16072 2003-07-13 Martin Baulig <martin@ximian.com>
16074 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16075 function. If we're a CompoundAssign, we need to create an embedded
16076 CompoundAssign, not an embedded Assign.
16077 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16080 2003-07-13 Martin Baulig <martin@ximian.com>
16082 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16083 work to fix bug #46088.
16085 2003-07-13 Ravi Pratap <ravi@ximian.com>
16087 * class.cs (Operator.Emit): Do not emit attributes here - it is
16088 taken care of by the Method class that we delegate too. This takes
16089 care of bug #45876.
16091 2003-07-10 Martin Baulig <martin@ximian.com>
16093 * expression.cs (TypeOfVoid): New class.
16094 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16096 2003-07-10 Martin Baulig <martin@ximian.com>
16098 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16101 2003-07-10 Martin Baulig <martin@ximian.com>
16103 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16104 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16106 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16108 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16110 2003-07-10 Martin Baulig <martin@ximian.com>
16112 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16113 of decimal. Fixes #42850.
16115 NOTE: I also fixed the created byte blob, but this doesn't work on
16116 the MS runtime and csc never produces any byte blobs for decimal
16119 2003-07-10 Martin Baulig <martin@ximian.com>
16121 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16122 structs; fixes #32068.
16123 (Block.AddChildVariableNames): Fixed #44302.
16125 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16127 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16129 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16131 * attribute.cs: And this test is onger needed.
16133 2003-07-08 Martin Baulig <martin@ximian.com>
16135 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16136 inaccessible types. Fixes #36313.
16138 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16140 * namespace.cs (NamespaceEntry): Create implicit entries for all
16141 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16142 implicit entries for N1.N2 and N1.
16144 2003-07-08 Martin Baulig <martin@ximian.com>
16146 Rewrote the handling of namespaces to fix a lot of the issues
16147 wrt. `using' aliases etc.
16149 * namespace.cs (Namespace): Splitted this class into a
16150 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16152 * typemanager.cs (TypeManager.IsNamespace): Removed.
16153 (TypeManager.ComputeNamespaces): Only compute namespaces from
16154 loaded assemblies here, not the namespaces from the assembly we're
16155 currently compiling.
16157 2003-07-08 Martin Baulig <martin@ximian.com>
16159 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16161 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16163 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16166 I thought about the memory savings here, but LookupTypeReflection
16167 is used under already very constrained scenarios. Compiling
16168 corlib or mcs only exposes one hit, so it would not really reduce
16169 any memory consumption.
16171 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16173 * typemanager.cs: fixes bug #45889 by only adding public types from
16174 other assemblies to the list of known types.
16176 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16178 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16179 on the type we resolved.
16181 2003-07-05 Martin Baulig <martin@ximian.com>
16183 * pending.cs (PendingImplementation.ParentImplements): Don't
16184 create the proxy if the parent is abstract.
16186 * class.cs (TypeContainer.DefineIndexers): Process explicit
16187 interface implementations first. Fixes #37714.
16189 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16191 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16192 defined recursively; but since we modify the input parameters
16193 (left is set to `this' temporarily), we reset this value if the
16194 left_is_explicit is false, which gives the original semantics to
16197 * literal.cs (NullPointer): new class used to represent a null
16198 literal in a pointer context.
16200 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16201 type is a pointer, use a NullPointer object instead of a
16202 NullLiteral. Closes 43687
16204 (ExplicitConversion): Convert pointer values using
16205 the conv opcode to the proper type.
16207 * ecore.cs (New): change ValueTypeVariable property into a method,
16208 that returns whether the valuetype is suitable for being used.
16210 * expression.cs (Binary.DoNumericPromotions): Only return if we
16211 the int constant was a valid uint, and we can return both left and
16212 right as uints. If not, we continue processing, to trigger the
16213 type conversion. This fixes 39018.
16215 * statement.cs (Block.EmitMeta): During constant resolution, set
16216 the CurrentBlock property on the emitcontext, so that we resolve
16217 constants propertly.
16219 2003-07-02 Martin Baulig <martin@ximian.com>
16221 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16222 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16224 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16225 than emitting it here.
16227 * statement.cs: Fixed some more flow analysis bugs.
16229 2003-07-02 Martin Baulig <martin@ximian.com>
16231 * class.cs (MethodData.Define): When implementing interface
16232 methods, set Final unless we're Virtual.
16234 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16235 check work for interface methods.
16237 2003-07-01 Martin Baulig <martin@ximian.com>
16239 * ecore.cs (EmitContext.This): Replaced this property with a
16240 GetThis() method which takes a Location argument. This ensures
16241 that we get the correct error location for a CS0188.
16243 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16245 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16246 ImplicitStandardConversion.
16248 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16250 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16252 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16255 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16257 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16260 (MethodData.Define): Turn off initlocals for unsafe methods.
16262 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16264 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16265 complete; Fixes #37521.
16267 * delegate.cs: Use Modifiers.TypeAttr to compute the
16268 TypeAttributes, instead of rolling our own. This makes the flags
16269 correct for the delegates.
16271 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16273 * class.cs (Constructor.Define): Set the private flag for static
16274 constructors as well.
16276 * cs-parser.jay (statement_expression): Set the return value to
16277 null, to avoid a crash when we catch an error.
16279 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16281 * cs-parser.jay: Applied patch from Jackson that adds support for
16282 extern and unsafe modifiers to destructor declarations.
16284 * expression.cs: Report error 21 if the user is trying to index a
16287 * driver.cs: Add an error message, suggested by the bug report.
16289 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16290 if we do not have a ": this ()" constructor initializer. Fixes 45149
16292 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16294 * namespace.cs: Add some information to reduce FAQs.
16296 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16298 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16299 underlying enumeration types. Fixes #43915.
16301 * expression.cs: Treat ushort/short as legal values to be used in
16302 bitwise operations.
16304 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16306 * delegate.cs: transfer custom attributes for paramenters from
16307 the delegate declaration to Invoke and BeginInvoke.
16309 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16311 * attribute.cs: handle custom marshalers and emit marshal info
16314 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16316 * makefile.gnu: Added anonymous.cs to the compiler sources.
16318 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16320 * iterators.cs: Change the name of the proxy class to include two
16323 * cs-parser.jay: Update grammar to include anonymous methods.
16325 * anonymous.cs: new file.
16327 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16329 * class.cs (Field.Define): Add missing test for pointers and
16332 2003-05-27 Ravi Pratap <ravi@ximian.com>
16334 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16335 we use the stobj opcode.
16337 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16338 since it wasn't the correct fix.
16340 It still is puzzling that we are required to use stobj for IntPtr
16341 which seems to be a ValueType.
16343 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16345 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16346 during regular simple name resolution. Now, the trick is that
16347 instead of returning for processing the simplename, we do a
16348 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16349 contextual lookup type). If a match is found, return that, if
16350 not, return for further composition.
16352 This fixes long-standing 30485.
16354 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16355 using the address to initialize an object, do an Stobj instead of
16356 using the regular Stelem.
16358 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16359 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16360 Because if we are a BaseIndexerAccess that value will be true.
16363 * statement.cs (GotoCase.Resolve): Return after reporting an
16364 error, do not attempt to continue.
16366 * expression.cs (PointerArithmetic.Emit): If our operand is a
16367 long, convert our constants to match the operand before
16368 multiplying. Convert to I type before adding. Fixes 43670.
16370 2003-05-14 Ravi Pratap <ravi@ximian.com>
16372 * enum.cs (ImplicitConversionExists) : Rename to
16373 ImplicitEnumConversionExists to remove ambiguity.
16375 * ecore.cs (NullCast): New type of cast expression class which
16376 basically is very similar to EmptyCast with the difference being
16377 it still is a constant since it is used only to cast a null to
16379 (eg. (string) null)
16381 * convert.cs (ImplicitReferenceConversion): When casting a null
16382 literal, we return a NullCast.
16384 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16385 should be around anymore.
16387 The renaming (reported was slightly wrong). Corrections:
16389 ConvertImplicitStandard -> ImplicitConversionStandard
16390 ConvertExplicitStandard -> ExplicitConversionStandard
16392 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16393 before passing them in !
16395 * convert.cs (ImplicitConversionStandard): When comparing for
16396 equal expr and target types, ensure that expr is not a
16399 In general, we must not be checking (expr_type ==
16400 target_type) in the top level conversion methods
16401 (ImplicitConversion, ExplicitConversion etc). This checking is
16402 done in the methods that they delegate to.
16404 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16406 * convert.cs: Move Error_CannotConvertType,
16407 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16408 ImplicitNumericConversion, ImplicitConversionExists,
16409 ImplicitUserConversionExists, StandardConversionExists,
16410 FindMostEncompassedType, FindMostSpecificSource,
16411 FindMostSpecificTarget, ImplicitUserConversion,
16412 ExplicitUserConversion, GetConversionOperators,
16413 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16414 TryImplicitIntConversion, Error_CannotConvertImplicit,
16415 ConvertImplicitRequired, ConvertNumericExplicit,
16416 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16417 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16420 Perform the following renames:
16422 StandardConversionExists -> ImplicitStandardConversionExists
16423 ConvertImplicit -> ImplicitConversion
16424 ConvertImplicitStandard -> ImplicitStandardConversion
16425 TryImplicitIntConversion -> ImplicitIntConversion
16426 ConvertImplicitRequired -> ImplicitConversionRequired
16427 ConvertNumericExplicit -> ExplicitNumericConversion
16428 ConvertReferenceExplicit -> ExplicitReferenceConversion
16429 ConvertExplicit -> ExplicitConversion
16430 ConvertExplicitStandard -> ExplicitStandardConversion
16432 2003-05-19 Martin Baulig <martin@ximian.com>
16434 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16435 (TypeInfo): Added support for structs having structs as fields.
16437 * ecore.cs (FieldExpr): Implement IVariable.
16438 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16439 VariableInfo for the field.
16441 2003-05-18 Martin Baulig <martin@ximian.com>
16443 * expression.cs (This.DoResolve): Report a CS0027 if we're
16444 emitting a field initializer.
16446 2003-05-18 Martin Baulig <martin@ximian.com>
16448 * expression.cs (This.ResolveBase): New public function.
16449 (This.DoResolve): Check for CS0188.
16451 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16454 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16455 `instance_expression' to null if we don't have any non-static
16458 2003-05-18 Martin Baulig <martin@ximian.com>
16460 Reworked the way how local variables and parameters are handled by
16461 the flow analysis code.
16463 * statement.cs (TypeInfo, VariableMap): New public classes.
16464 (VariableInfo): New public class. This is now responsible for
16465 checking whether a variable has been assigned. It is used for
16466 parameters and local variables.
16467 (Block.EmitMeta): Take the InternalParameters as argument; compute
16468 the layout of the flow vectors here.
16469 (Block.LocalMap, Block.ParameterMap): New public properties.
16470 (FlowBranching): The .ctor doesn't get the InternalParameters
16471 anymore since Block.EmitMeta() now computes the layout of the flow
16473 (MyStructInfo): This class is now known as `StructInfo' and nested
16474 in `TypeInfo'; we don't access this directly anymore.
16476 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16477 property and removed IsAssigned(), IsFieldAssigned(),
16478 SetAssigned() and SetFieldAssigned(); we now call them on the
16479 VariableInfo so we don't need to duplicate this code everywhere.
16481 * expression.cs (ParameterReference): Added `Block block' argument
16483 (LocalVariableReference, ParameterReference, This): The new
16484 VariableInfo class is now responsible for all the definite
16487 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16488 IsParameterAssigned, SetParameterAssigned): Removed.
16490 2003-05-18 Martin Baulig <martin@ximian.com>
16492 * typemanager.cs (InitCoreTypes): Try calling
16493 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16494 the 3-args-version. Corlib now also needs our `void_type'.
16495 (GetMethod): Added overloaded version which takes an optional
16496 `bool report_errors' to allow lookups of optional methods.
16498 2003-05-12 Martin Baulig <martin@ximian.com>
16500 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16501 only used for locals and not for parameters.
16503 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16505 * support.cs (InternalParameters.ParameterType): Return the
16506 ExternalType of the parameter.
16508 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16511 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16513 * class.cs (MethodData.Define): Do not set the `newslot' on
16514 interface members, if they are also flagged as "override".
16516 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16517 better code for ++i and i++. This only works for static fields
16518 and local variables.
16520 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16521 want to pull the DeclSpace out of the builder_to_declspace instead
16522 of the TypeBuilder (like in TypeContainer.FindMembers).
16524 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16525 instead of LookupTypeContainer. Fixes the crash on .NET for
16526 looking up interface members.
16528 * const.cs: Create our own emit context during the Definition
16529 stage, so that constants are evaluated in the proper context, when
16530 a recursive definition happens.
16532 2003-05-11 Martin Baulig <martin@ximian.com>
16534 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16535 new block for a switch section.
16536 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16537 the adding/lookup in the switch block. Fixes #39828.
16539 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16541 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16542 functionality: I needed to convert the data after I had performed
16543 the add/sub operation into the operands type size.
16545 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16546 pass the type for the box operation, otherwise the resulting
16547 object would have been of type object.
16549 (BoxedCast): Add constructor to specify the type to box as.
16551 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16553 * iterators.cs: I was reusing the `count' variable inadvertently,
16554 take steps to not allow this to happen.
16556 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16558 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16559 by creating an array at the point where the params starts and
16560 putting all those arguments there, then adjusting the size of the
16563 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16565 * expression.cs (New.AddressOf): Implement interface
16566 IMemoryLocation. This is used when the `new' operator is used in
16567 the context of an invocation to a method on a value type.
16569 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16572 * namespace.cs: Also check the using aliases here.
16574 * driver.cs: Move the test for using validity after the types have
16575 been entered, so we do a single pass that also includes the using
16578 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16579 in the regular case. CreateSiblingForFinally is doing extra
16582 * attribute.cs (GetAttributeArgumentExpression): Store the result
16583 on an out value, and use the return value to indicate failure
16584 instead of using null (which is a valid return for Constant.GetValue).
16586 * statement.cs: Perform the analysis flow for the increment
16587 portion after the statement, because this will be the real flow of
16588 execution. Fixes #42385
16590 * codegen.cs (EmitContext.EmitArgument,
16591 EmitContext.EmitStoreArgument): New helper functions when the
16592 RemapToProxy flag is set.
16594 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16597 Add support for remapping parameters.
16599 * iterators.cs: Propagate parameter values; Store parameter
16600 values in the proxy classes.
16602 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16604 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16605 need a proxy reference; I do not know what I was thinking
16607 * cs-parser.jay (constructor_initializer): catch another error,
16608 and display nice message.
16610 (field_declaration): catch void field declaration
16611 to flag a better error.
16613 * class.cs (MemberBase.CheckBase): Report an error instead of a
16614 warning if a new protected member is declared in a struct.
16615 (Field.Define): catch the error of readonly/volatile.
16617 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16619 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16620 volatile variable is taken
16622 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16624 * statement.cs (Fixed.Resolve): Report an error if we are not in
16627 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16629 * typemanager.cs: reuse the code that handles type clashes for
16630 delegates and enumerations.
16632 * class.cs (Report28): Always report.
16634 * expression.cs (EncodeAsAttribute): Allow nulls here.
16636 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16638 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16639 the functionality for testing whether an expression is valid for
16640 an attribute here. Also handle the case of arrays of elements
16643 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16644 encoding a linear array into an array of objects that are suitable
16645 to be passed to an CustomAttributeBuilder.
16647 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16649 * ecore.cs: (FieldExpr): Handle field remapping here.
16651 * iteratators.cs: Pass the instance variable (if the method is an
16652 instance method) to the constructors, so we can access the field
16653 variables on the class.
16655 TODO: Test this with structs. I think the THIS variable on
16656 structs might have to be a pointer, and not a refenrece
16658 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16660 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16661 local variables to fields in a proxy class.
16663 * iterators.cs (PopulateProxy): Rename our internal fields to
16665 Create a <THIS> field if we are an instance method, so we can
16666 reference our parent container variables.
16667 (MapVariable): Called back from the EmitContext code to enter a
16668 new variable to field mapping into the proxy class (we just create
16672 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16673 for using the remapped locals to fields.
16675 I placed the code here, because that gives the same semantics to
16676 local variables, and only changes the Emit code.
16678 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16679 statements inside iterators.
16680 (VariableInfo): Add a FieldBuilder for the cases when we are
16681 remapping local variables to fields in a proxy class
16683 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16684 current_block != null.
16686 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16687 not cope with strings, as it has been moved to the
16688 TableSwitchEmit. Fixed bug in switch generation.
16690 * expression.cs (New.DoResolve): Provide more context for the user
16691 when reporting an error.
16693 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16696 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16697 check the permissions for it. Note than in a type-resolution
16698 context the check was already present in DeclSpace.ResolveType,
16699 but was missing from the MemberAccess.
16701 (ArrayCreation.CheckIndices): warn if the user has
16702 more nested levels of expressions, but there are no more
16703 dimensions specified. Avoids crash on bug 41906.
16705 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16707 * statement.cs (Block): replace Implicit bool, for a generic
16709 New flag: `Unchecked'. This is used during the EmitMeta phase
16710 (which is out-of-line with the regular Resolve/Emit process for a
16711 statement, as this is done ahead of time, but still gets a chance
16712 to call constant resolve).
16714 (Block.Flags): new enum for adding a new flag.
16716 (Block.EmitMeta): track the state of unchecked.
16718 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16719 to enable constant resolution to work there as well.
16721 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16723 * typemanager.cs (ienumerable_type): Also look up
16724 System.Collections.IEnumerable.
16726 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16728 TODO: Test more than one conditional per method.
16730 * class.cs (Indexer.Define): Report the location where the user is
16731 referencing the unsupported feature.
16733 (MethodData): Overload the use of `conditionals' to
16734 minimize the creation of needless ArrayLists. This saves roughly
16735 212kb on my machine.
16737 (Method): Implement the new IIteratorContainer interface.
16738 (Method.SetYields): Implement the method by setting the ModFlags
16739 to contain METHOD_YIELDS.
16741 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16742 which just got set to null.
16744 * iterators.cs: New file.
16746 (Yield, YieldBreak): New statements.
16748 * statement.cs (Return.Resolve): Flag an error if we are used in
16749 an iterator method.
16751 * codegen.cs (InIterator): New flag set if the code is being
16752 compiled in an iterator method.
16754 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16755 internal modifier, and we just use it to avoid adding extra
16756 fields, as this is seldom used.
16758 * cs-parser.jay: Add yield_statement (yield and yield break).
16760 * driver.cs: New flag -v2 to turn on version 2 features.
16762 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16763 hashtable when v2 is enabled.
16765 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16767 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16768 there is already a namespace defined with this name.
16770 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16771 people upgraded their corlibs.
16773 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16774 always use fully qualified types, no need to use the compiler
16777 (TypeManager.IsNamespace): Use binarysearch.
16779 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16780 AddDelegate): I did not quite use the new IsValid API properly: I
16781 have to pass the short-name and the fullname. I was passing only
16782 the basename instead of the fullname sometimes.
16784 (TypeContainer.DefineType): call NamespaceClash.
16786 * interface.cs (Interface.DefineType): use NamespaceClash before
16789 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16792 * enum.cs: (Enum.DefineType): use NamespaceClash before
16795 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16796 speed increase. First, use the negative_hits cache when we get a
16797 negative. Second, add the type with its full original name
16798 instead of the new . and + encoded name (reflection uses + to
16799 separate type from a nested type). Use LookupTypeReflection
16800 directly which bypasses the type->name hashtable (that we already
16801 know does not contain the type.
16803 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16804 location/container type.
16806 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16808 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16810 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16812 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16813 method is being referenced in the method group from a static
16814 context, and report error 120 if so.
16816 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16819 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16820 is created, we create the A namespace).
16822 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16825 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16827 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16828 invocation to ModuleBuilder.GetType with the same values will
16829 return a new type instance, so we need to cache its return
16832 * expression.cs (Binary.ResolveOperator): Only allow the compare
16833 operators on enums if they are of the same type.
16835 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16836 types of ValueType on their own case. Before we were giving them
16837 the same treatment as objects.
16839 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16840 fullname. Short name is used to compare against container name.
16841 Fullname is used to check against defined namespace names.
16843 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16844 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16846 (Method.CheckBase): Call parent.
16847 (MemberBase.CheckBase): Check for protected members on sealed
16849 (PropertyBase.CheckBase): Call parent.
16850 (Field.Define): Call parent.
16852 * report.cs: Negative error codes are now mapped to 8000 - code,
16853 so that the display is render more nicely.
16855 * typemanager.cs: Do not use try/catch, instead report a regular
16858 (GetPointerType, GetReferenceType): These methods provide
16859 mechanisms to obtain the T* and T& from a T. We had the code
16860 previously scattered around the code base, and it also used
16861 TypeManager.LookupType that would go through plenty of caches.
16862 This one goes directly to the type source.
16864 In some places we did the Type.GetType followed by
16865 ModuleBuilder.GetType, but not in others, so this unifies the
16866 processing as well.
16868 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16869 statements now that we have namespace information.
16871 * typemanager.cs (IsNamespace): New method, returns whether the
16872 string presented is a namespace or not.
16874 (ComputeNamespaces): New public entry point, computes the list of
16875 available namespaces, using the GetNamespaces API call in Mono, or
16876 the slower version in MS.NET.
16878 Now before we start the semantic analysis phase, we have a
16879 complete list of namespaces including everything that the user has
16882 Deleted old code to cache namespaces in .nsc files.
16884 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16886 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16887 class/struct location definition Location for the implicit
16888 constructor location.
16890 (Operator.Define): Use the location of the operator for the
16891 implicit Method definition.
16893 (Constructor.Emit): use the constructor location for the implicit
16894 base initializer constructor.
16896 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16897 and the Expression class now contains two new methods:
16899 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16900 isolate type lookup from the rest of the resolution process.
16902 Since we use Expressions to hold type definitions due to the way
16903 we parse the input we have historically overloaded Resolve to
16904 perform the Type lookups if a special flag is passed. Now this is
16905 eliminated and two methods take their place.
16907 The differences in the two methods between xStep and xTerminal is
16908 that xStep is involved in our current lookup system that uses
16909 SimpleNames to compose a name, while xTerminal is used just to
16910 catch the case where the simplename lookup failed.
16912 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16914 * expression.cs (ResolveMemberAccess): Remove redundant code.
16915 TypeExpr expressions are always born fully resolved.
16917 * interface.cs (PopulateMethod): Do not lookup the types twice.
16918 We were doing it once during SemanticAnalysis and once during
16921 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16922 in local variable type definitions, were being returned as a
16923 SimpleName (we decomposed everything into a string), that is
16924 because primary_expression was being used instead of a type in the
16925 grammar (reduce/reduce conflicts).
16927 The part that was wrong is that we converted the expression into a
16928 string (an oversimplification in one hand, compounded with primary
16929 expressions doing string concatenation).
16935 Would return "A.B.C[]" as a SimpleName. This stopped things like
16936 using clauses from working on this particular context. And a type
16937 was being matched directly against "A.B.C[]".
16939 We now use the correct approach, and allow for ComposedCast to be
16940 part of the unary expression. So the "A.B.C []" become a composed
16941 cast of "A.B.C" (as a nested group of MemberAccess with a
16942 SimpleName at the end) plus the rank composition "[]".
16946 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16948 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16949 for the access level checking.
16951 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16952 `TypeContainer container', because I kept getting confused when I
16953 was debugging this code.
16955 * expression.cs (Indexers): Instead of tracking getters/setters,
16956 we now track them in parallel. We create one arraylist less, but
16957 most importantly it is possible now for the LValue code to find a
16958 matching get for a set.
16960 (IndexerAccess.DoResolveLValue): Update the code.
16961 GetIndexersForType has been modified already to extract all the
16962 indexers from a type. The code assumed it did not.
16964 Also make the code set the correct return type for the indexer.
16965 This was fixed a long time ago for properties, but was missing for
16966 indexers. It used to be void_type.
16968 (Binary.Emit): Test first for doubles instead of
16969 floats, as they are more common.
16971 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16972 when dealing with floats and the <=, >= operators. This fixes bug
16975 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16976 to load the array value by emitting a load on the foreach variable
16977 type. This was incorrect.
16979 We now emit the code to load an element using the the array
16980 variable type, and then we emit the conversion operator.
16984 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16986 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16988 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16990 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16991 test for protection before we test for signatures.
16993 (MethodSignature.ToString): implement.
16995 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16996 to the case where we reduced into a LongConstant.
16998 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16999 depend on whether the information is acurrate, because the
17000 Microsoft runtime will always claim that the array type is public,
17001 regardless of the real state.
17003 If the type is a pointer, another problem happens: the type is
17004 reported as non-public in Microsoft.
17006 In both cases we have to call CheckAccessLevel recursively with
17007 the underlying type as the argument to be tested.
17009 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17011 * assign.cs (Assign.Emit): If we are dealing with a compound
17012 assignment expression, we should use the code path that stores the
17013 intermediate result in a temporary value. This fixes #40903.
17015 *expression.cs (Indirection.ToString): Provide ToString method for
17018 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17020 * class.cs: Null out fields holding references to Block objects so
17021 they can be garbage collected.
17023 * expression.cs (OverloadResolve): Remove unused local.
17025 2003-04-07 Martin Baulig <martin@ximian.com>
17027 * codegen.cs (EmitContext.CurrentFile): New public field.
17028 (EmitContext.Mark): Use the CurrentFile to check whether the
17029 location is in the correct file.
17030 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17032 2003-04-07 Martin Baulig <martin@ximian.com>
17034 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17036 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17037 location. [FIXME: The location argument which gets passed to this
17038 method is sometimes wrong!]
17040 2003-04-07 Nick Drochak <ndrochak@gol.com>
17042 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17044 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17046 * expression.cs (Indirection.EmitAssign): We were using the
17047 temporary, but returning immediately instead of continuing the
17050 2003-04-06 Martin Baulig <martin@ximian.com>
17052 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17053 if it's a nested child, but also deriving from the outer class.
17056 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17057 nested child, but also deriving from the outer class. See
17059 (FilterWithClosure): We may access private members of the outer
17060 class if we're a nested child and deriving from the outer class.
17061 (RealMemberLookup): Only set `closure_private_ok' if the
17062 `original_bf' contained BindingFlags.NonPublic.
17064 2003-04-05 Martin Baulig <martin@ximian.com>
17066 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17068 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17070 * class.cs (Event.Define): Do not allow abstract events to have
17073 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17075 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17076 block in event declarations.
17078 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17079 value type, get its address.
17081 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17082 leaving a class on the stack instead of a boolean value (int
17083 0/1). Change the code so we compare against null, and then the
17084 result against zero.
17086 * class.cs (TypeContainer.GetClassBases): We were checking for the
17087 parent class being sealed too late.
17089 * expression.cs (Binary.Emit): For <= and >= when dealing with
17090 floating point values, use cgt.un and clt.un instead of cgt and
17093 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17095 * statement.cs: Apply the same optimization as MS: skip the
17096 GetEnumerator returning an IEnumerator, and use the one returning a
17097 CharEnumerator instead. This allows us to avoid the try-finally block
17100 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17102 * cs-parser.jay: Attributes cannot be applied to
17103 namespaces. Fixes #40473
17105 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17108 (Add*): check if the name is valid using the full name for constants,
17109 fields, properties and events.
17111 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17113 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17114 char constants to be part of the enumeration.
17116 * expression.cs (Conditional.DoResolve): Add support for operator
17117 true. Implements the missing functionality from 14.12
17119 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17120 operator true/false as required by the spec.
17122 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17123 implicit conversion to boolean.
17125 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17126 also one where the type implements `operator true'.
17128 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17129 get an expression that will invoke operator true based on an
17132 (GetConversionOperators): Removed the hack that called op_True
17135 (Expression.ResolveBoolean): Move this from Statement.
17137 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17139 * ecore.cs (FieldExpr): do not allow initialization of initonly
17140 fields on derived classes
17142 2003-03-13 Martin Baulig <martin@ximian.com>
17144 * statement.cs (Block.Emit): Call ig.BeginScope() and
17145 ig.EndScope() when compiling with debugging info; call
17146 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17148 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17150 * expression.cs (Indexers): Do not construct immediately, allow
17151 for new members to be appended as we go. Fixes 38143
17153 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17155 * expression.cs: save/restore context when resolving an unchecked
17158 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17160 * cfold.cs: Catch division by zero in modulus operator during
17163 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17165 * interface.cs (Interface.DefineMembers): Avoid defining members
17168 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17170 * driver.cs: handle the +/- options for -noconfig
17172 * statement.cs (Unckeched.Resolve): Also track the state of
17173 unchecked in the Resolve phase.
17175 2003-02-27 Martin Baulig <martin@ximian.com>
17177 * ecore.cs (Expression.MemberLookup): Don't create a
17178 MethodGroupExpr for something which is not a method. Fixes #38291.
17180 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17182 * class.cs (MemberBase.CheckParameters): Also check that the type
17183 is unmanaged if it is a pointer.
17185 * expression.cs (SizeOf.Resolve): Add location information.
17187 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17188 a managed type is declared.
17190 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17191 parameter modifiers as well. Fixes bug 38606
17193 * class.cs: Very sad. Am backing out the speed up changes
17194 introduced by the ArrayList -> Array in the TypeContainer, as they
17195 were not actually that much faster, and introduced a bug (no error
17196 reports on duplicated methods).
17198 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17199 source first, this will guarantee that we have a valid expression
17200 before calling in lower levels functions that will require a
17201 resolved object. Then use this original_source in the
17202 target.ResolveLValue instead of the original source that was
17205 Another change. Use target.Resolve instead of LValueResolve.
17206 Although we are resolving for LValues, we will let the Assign code
17207 take care of that (it will be called again from Resolve). This
17208 basically allows code like this:
17210 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17211 class Y { void A (X x) { x [0] += o; }
17213 The problem was that the indexer was trying to resolve for
17214 set_Item (idx, object o) and never finding one. The real set_Item
17215 was set_Item (idx, X). By delaying the process we get the right
17220 2003-02-23 Martin Baulig <martin@ximian.com>
17222 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17223 while calling DoEmit ().
17225 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17226 source files; if you use the #line directive inside a method, the
17227 compiler stops emitting line numbers for the debugger until it
17228 reaches the end of the method or another #line directive which
17229 restores the original file.
17231 2003-02-23 Martin Baulig <martin@ximian.com>
17233 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17235 2003-02-23 Martin Baulig <martin@ximian.com>
17237 * statement.cs (Block.AddChildVariableNames): We need to call this
17238 recursively, not just for our immediate children.
17240 2003-02-23 Martin Baulig <martin@ximian.com>
17242 * class.cs (Event.Define): Always make the field private, like csc does.
17244 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17245 actually work, fixes bug #37521.
17247 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17249 * delegate.cs: When creating the various temporary "Parameters"
17250 classes, make sure that we call the ComputeAndDefineParameterTypes
17251 on those new parameters (just like we do with the formal ones), to
17252 allow them to be resolved in the context of the DeclSpace.
17254 This fixes the bug that Dick observed in Bugzilla #38530.
17256 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17258 * expression.cs (ResolveMemberAccess): When resolving a constant,
17259 do not attempt to pull a constant if the value was not able to
17260 generate a valid constant.
17262 * const.cs (LookupConstantValue): Do not report more errors than required.
17264 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17266 * expression.cs: fixes bug #38328.
17268 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17270 * class.cs: Changed all the various members that can be part of a
17271 class from being an ArrayList to be an Array of the right type.
17272 During the DefineType type_list, interface_list, delegate_list and
17273 enum_list are turned into types, interfaces, delegates and enums
17276 And during the member population, indexer_list, event_list,
17277 constant_list, field_list, instance_constructor_list, method_list,
17278 operator_list and property_list are turned into their real arrays.
17280 Although we could probably perform this operation earlier, for
17281 good error reporting we need to keep the lists and remove the
17282 lists for longer than required.
17284 This optimization was triggered by Paolo profiling the compiler
17285 speed on the output of `gen-sample-program.pl' perl script.
17287 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17288 not crash in methods like MemberLookupFailed that use this field.
17290 This problem arises when the compiler fails to resolve a type
17291 during interface type definition for example.
17293 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17295 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17296 inherit from System.Object, so we have to stop at null, not only
17297 when reaching System.Object.
17299 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17301 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17302 DeclaredOnly because the parent indexer might have had a different
17303 name, but did not loop until the top of the hierarchy was reached.
17305 The problem this one fixes is 35492: when a class implemented an
17306 indexer from an interface, we were getting the interface method
17307 (which was abstract) and we were flagging an error (can not invoke
17310 This also keeps bug 33089 functioning, and test-148 functioning.
17312 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17313 out if a method is special is to see if it is declared in a
17314 property or event, or whether it is one of the predefined operator
17315 names. This should fix correctly #36804.
17317 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17319 The goal here is to remove the dependency on EmptyCast.Peel ().
17320 Killing it completely.
17322 The problem is that currently in a number of places where
17323 constants are expected, we have to "probe" for an EmptyCast, and
17324 Peel, which is not the correct thing to do, as this will be
17325 repetitive and will likely lead to errors.
17327 The idea is to remove any EmptyCasts that are used in casts that
17328 can be reduced to constants, so we only have to cope with
17331 This bug hunt was triggered by Bug 37363 and the desire to remove
17332 the duplicate pattern where we were "peeling" emptycasts to check
17333 whether they were constants. Now constants will always be
17336 * ecore.cs: Use an enumconstant here instead of wrapping with
17339 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17340 throwing me off. By handling this we can get rid of a few hacks.
17342 * statement.cs (Switch): Removed Peel() code.
17344 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17346 * class.cs: Location information for error 508
17348 * expression.cs (New.DoResolve): Add a guard against double
17349 resolution of an expression.
17351 The New DoResolve might be called twice when initializing field
17352 expressions (see EmitFieldInitializers, the call to
17353 GetInitializerExpression will perform a resolve on the expression,
17354 and later the assign will trigger another resolution
17356 This leads to bugs (#37014)
17358 * delegate.cs: The signature for EndInvoke should contain any ref
17359 or out parameters as well. We were not doing this in the past.
17361 * class.cs (Field.Define): Do not overwrite the type definition
17362 inside the `volatile' group. Turns out that volatile enumerations
17363 were changing the type here to perform a validity test, which
17366 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17368 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17369 and structs, we do not want to load the instance variable
17371 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17372 enum_type has to be handled like an object reference (implicit
17373 conversions exists from this to object), but the regular IsClass
17374 and IsValueType tests will never return true for this one.
17376 Also we use TypeManager.IsValueType instead of type.IsValueType,
17377 just for consistency with the rest of the code (this is only
17378 needed if we ever use the construct exposed by test-180.cs inside
17379 corlib, which we dont today).
17381 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17383 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17386 2003-02-09 Martin Baulig <martin@ximian.com>
17388 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17389 (Namespace.DefineNamespaces): New static public method; this is
17390 called when we're compiling with debugging to add all namespaces
17391 to the symbol file.
17393 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17394 pass it to the Namespace's .ctor.
17396 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17397 and MethodBase arguments; pass the namespace ID to the symwriter;
17398 pass the MethodBase instead of the token to the symwriter.
17399 (SymbolWriter.DefineNamespace): New method to add a namespace to
17402 2003-02-09 Martin Baulig <martin@ximian.com>
17404 * symbolwriter.cs: New file. This is a wrapper around
17405 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17406 methods here in near future.
17408 2003-02-09 Martin Baulig <martin@ximian.com>
17410 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17411 ILGenerator.MarkSequencePoint() which are actually used by the
17414 2003-02-09 Martin Baulig <martin@ximian.com>
17416 * location.cs (SourceFile): New public sealed class. This
17417 contains the name and an index which is used in the location's token.
17418 (Location): Reserve an appropriate number of bits in the token for
17419 the source file instead of walking over that list, this gives us a
17420 really huge performance improvement when compiling with debugging.
17422 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17423 `SourceFile' argument instead of a string.
17424 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17425 but don't parse/tokenize here, we need to generate the list of all
17426 source files before we do that.
17427 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17430 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17431 instead of a string.
17433 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17436 2003-02-09 Martin Baulig <martin@ximian.com>
17438 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17439 filename on `#line default'.
17441 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17443 * statement.cs: don't clear the pinned var when the fixed statement
17444 returns from the method (fixes bug#37752).
17446 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17448 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17451 2003-02-07 Martin Baulig <martin@ximian.com>
17453 * driver.cs: Removed the `--debug-args' command line argument.
17455 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17456 automatically by the AsssemblyBuilder.
17457 (CodeGen.InitializeSymbolWriter): We don't need to call any
17458 initialization function on the symbol writer anymore. This method
17459 doesn't take any arguments.
17461 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17463 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17464 from referenced assemblies as well.
17466 2003-02-02 Martin Baulig <martin@ximian.com>
17468 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17470 2003-02-02 Martin Baulig <martin@ximian.com>
17472 * class.cs (Constructor.Emit): Open the symbol writer before
17473 emitting the constructor initializer.
17474 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17475 single-stepping through constructor initializers.
17477 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17479 * class.cs: Handle error 549: do not allow virtual methods in
17482 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17484 * decl.cs: Check access levels when resolving types
17486 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17488 * statement.cs: Add parameters and locals set in catch blocks that might
17489 return to set vector
17491 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17493 * class.cs (Operator): Set the SpecialName flags for operators.
17495 * expression.cs (Invocation.DoResolve): Only block calls to
17496 accessors and operators on SpecialName methods.
17498 (Cast.TryReduce): Handle conversions from char constants.
17501 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17503 * statement.cs: small memory and time optimization in FlowBranching.
17505 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17507 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17508 problem that the last fix but in the other sid (Set).
17510 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17511 access when there is no indexer in the hierarchy.
17513 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17515 * class.cs: Combine some if statements.
17517 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17519 * driver.cs: fixed bug #37187.
17521 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17523 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17524 any indexer, it's needed to build a list with all the indexers in the
17525 hierarchy (AllGetters), else we have problems. Fixes #35653.
17527 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17529 * class.cs (MethodData.Define): It is wrong for an interface
17530 implementation to be static in both cases: explicit and implicit.
17531 We were only handling this in one case.
17533 Improve the if situation there to not have negations.
17535 * class.cs (Field.Define): Turns out that we do not need to check
17536 the unsafe bit on field definition, only on usage. Remove the test.
17538 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17540 * driver.cs: use assembly.Location instead of Codebase (the latest
17541 patch made mcs fail when using MS assemblies).
17543 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17545 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17546 get the path to *corlib.dll.
17548 2003-01-21 Nick Drochak <ndrochak@gol.com>
17552 * typemanager.cs: Remove compiler warnings
17554 2003-01-20 Duncan Mak <duncan@ximian.com>
17556 * AssemblyInfo.cs: Bump the version number to 0.19.
17558 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17560 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17562 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17564 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17566 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17568 * cs-parser.jay: Small fix: we were not comparing the constructor
17569 name correctly. Thanks to Zoltan for the initial pointer.
17571 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17573 * cs-tokenizer.cs: Set file name when specified with #line
17575 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17577 * cs-parser.jay: Only perform the constructor checks here if we
17578 are named like the class; This will help provider a better
17579 error. The constructor path is taken when a type definition is
17580 not found, but most likely the user forgot to add the type, so
17581 report that rather than the constructor error.
17583 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17585 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17588 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17590 * cs-parser.jay: Add cleanup call.
17592 2003-01-13 Duncan Mak <duncan@ximian.com>
17594 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17595 consistent with other methods.
17597 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17599 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17601 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17603 * attribute.cs: only set GuidAttr to true when we have a
17606 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17610 * typemanager.cs: fixes to allow mcs compile corlib with the new
17611 Type.IsSubclassOf fix.
17613 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17615 * expression.cs (LocalVariableReference.DoResolve): Classify a
17616 constant as a value, not as a variable. Also, set the type for
17619 * cs-parser.jay (fixed_statement): take a type instead of a
17620 pointer_type, so we can produce a better error message later.
17622 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17625 (For.DoEmit): Make inifinite loops have a
17626 non-conditional branch back.
17628 (Fixed.DoEmit): First populate the pinned variables, then emit the
17629 statement, then clear the variables. Before I was emitting the
17630 code once for each fixed piece.
17633 2003-01-08 Martin Baulig <martin@ximian.com>
17635 * statement.cs (FlowBranching.MergeChild): A break in a
17636 SWITCH_SECTION does not leave a loop. Fixes #36155.
17638 2003-01-08 Martin Baulig <martin@ximian.com>
17640 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17641 lives in the same number space than `param_map'. Fixes #36154.
17643 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17645 * cs-parser.jay (constructor_declaration): Set the
17646 Constructor.ModFlags before probing for it. This makes the
17647 compiler report 514, 515 and 132 (the code was there, but got
17650 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17651 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17652 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17654 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17656 * enum.cs: create the enum static fields using the enum type.
17658 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17660 * class.cs: don't try to create the ParamBuilder for the return
17661 type if it's not needed (and handle it breaking for the ms runtime
17664 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17666 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17668 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17670 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17671 the command. This showed up while compiling the JANET source
17672 code, which used \r as its only newline separator.
17674 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17676 * class.cs (Method.Define): If we are an operator (because it
17677 reuses our code), then set the SpecialName and HideBySig. #36128
17679 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17681 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17682 exception, report error 120 `object reference required'.
17684 * driver.cs: Add --pause option, used during to measure the size
17685 of the process as it goes with --timestamp.
17687 * expression.cs (Invocation.DoResolve): Do not allow methods with
17688 SpecialName to be invoked.
17690 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17692 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17693 number before adding it.
17695 2002-12-21 Ravi Pratap <ravi@ximian.com>
17697 * ecore.cs (StandardImplicitConversion): When in an unsafe
17698 context, we allow conversion between void * to any other pointer
17699 type. This fixes bug #35973.
17701 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17703 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17704 is not thrown when extensionless outputs are used
17706 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17708 * rootcontext.cs: fixed compilation of corlib.
17710 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17712 * attribute.cs (Attributes.Contains): Add new method.
17714 * class.cs (MethodCore.LabelParameters): if the parameter is an
17715 `out' parameter, check that no attribute `[In]' has been passed.
17717 * enum.cs: Handle the `value__' name in an enumeration.
17719 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17721 * decl.cs: Added special case to allow overrides on "protected
17724 2002-12-18 Ravi Pratap <ravi@ximian.com>
17726 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17727 since it makes much more sense.
17729 (Attributes.ctor): Don't require a Location parameter.
17731 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17733 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17734 since we already have that information per attribute.
17736 * everywhere : make appropriate changes.
17738 * class.cs (LabelParameters): Write the code which actually
17739 applies attributes to the return type. We can't do this on the MS
17740 .NET runtime so we flag a warning in the case an exception is
17743 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17745 * const.cs: Handle implicit null conversions here too.
17747 2002-12-17 Ravi Pratap <ravi@ximian.com>
17749 * class.cs (MethodCore.LabelParameters): Remove the extra
17750 Type [] parameter since it is completely unnecessary. Instead
17751 pass in the method's attributes so that we can extract
17752 the "return" attribute.
17754 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17756 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17757 of ignoring it and letting the compile continue.
17759 * typemanager.cs (ChangeType): use an extra argument to return an
17760 error condition instead of throwing an exception.
17762 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17764 * expression.cs (Unary.TryReduce): mimic the code for the regular
17765 code path. Perform an implicit cast in the cases where we can
17766 implicitly convert to one of the integral types, and then reduce
17767 based on that constant. This fixes bug #35483.
17769 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17771 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17773 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17775 * namespace.cs: fixed bug #35489.
17777 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17779 * class.cs: Remove some dead code.
17781 * cs-parser.jay: Estimate the number of methods needed
17782 (RootContext.MethodCount);
17784 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17785 numbers instead of StringBuilders.
17787 * support.cs (PtrHashtable): Add constructor with initial size;
17788 We can now reduce reallocations of the method table.
17790 2002-12-10 Ravi Pratap <ravi@ximian.com>
17792 * attribute.cs (ApplyAttributes): Keep track of the emitted
17793 attributes on a per-target basis. This fixes bug #35413.
17795 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17797 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17798 default to the Windows 1252 encoding.
17800 (UnixParseOption): Support version, thanks to Alp for the missing
17803 * AssemblyInfo.cs: Add nice assembly information.
17805 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17808 * cs-parser.jay: Allow a trailing comma before the close bracked
17809 in the attribute_section production.
17811 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17812 address of the instance was being taken, I will take this out,
17813 because we take the address of the object immediately here.
17815 2002-12-09 Ravi Pratap <ravi@ximian.com>
17817 * typemanager.cs (AreMultipleAllowed): Take care of the most
17818 obvious case where attribute type is not in the current assembly -
17821 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17823 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17824 definitions, instead of doing that afterwards.
17826 Also we use a nice little hack, depending on the constructor, we
17827 know if we are a "composed" name or a simple name. Hence, we
17828 avoid the IndexOf test, and we avoid
17830 * codegen.cs: Add code to assist in a bug reporter to track down
17831 the source of a compiler crash.
17833 2002-12-07 Ravi Pratap <ravi@ximian.com>
17835 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17836 types have been emitted for a given element and flag an error
17837 if something which does not have AllowMultiple set is used more
17840 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17841 attribute types and their corresponding AllowMultiple properties
17843 (AreMultipleAllowed): Check the property for a given type.
17845 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17846 property in the case we have a TypeContainer.
17848 (Attributes.AddAttribute): Detect duplicates and just skip on
17849 adding them. This trivial fix catches a pretty gross error in our
17850 attribute emission - global attributes were being emitted twice!
17852 Bugzilla bug #33187 is now fixed.
17854 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17856 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17857 instead of pp_and).
17859 * expression.cs (Binary.ResolveOperator): I can only use the
17860 Concat (string, string, string) and Concat (string, string,
17861 string, string) if the child is actually a concatenation of
17864 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17866 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17867 context where we need a 2-character lookahead.
17869 * pending.cs (PendingImplementation): Rework so we can keep track
17870 of interface types all the time, and flag those which were
17871 implemented by parents as optional.
17873 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17875 * expression.cs (Binary.ResolveOperator): Use
17876 String.Concat(string,string,string) or
17877 String.Concat(string,string,string,string) when possible.
17879 * typemanager: More helper methods.
17882 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17884 * pending.cs: remove the bogus return from GetMissingInterfaces()
17885 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17887 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17889 * namespace.cs: avoid duplicated 'using xxx' being added to
17890 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17891 when we get more than one 'using' statement for the same namespace.
17892 Report a CS0105 warning for it.
17894 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17896 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17897 of calling getChar/putback, uses internal knowledge of it.
17899 (xtoken): Reorder tokenizer so most common patterns are checked
17900 first. This reduces the compilation time in another 5% (from 8.11s
17901 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17903 The parsing time is 22% of the compilation in mcs, and from that
17904 64% is spent on the tokenization process.
17906 I tried using a binary search for keywords, but this is slower
17907 than the hashtable. Another option would be to do a couple of
17910 * Not use a StringBuilder, instead use an array of chars,
17911 with a set value. Notice that this way we could catch
17912 the 645 error without having to do it *afterwards*.
17914 * We could write a hand-parser to avoid the hashtable
17915 compares altogether.
17917 The identifier consumption process takes 37% of the tokenization
17918 time. Another 15% is spent on is_number. 56% of the time spent
17919 on is_number is spent on Int64.Parse:
17921 * We could probably choose based on the string length to
17922 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17925 Another 3% is spend on wrapping `xtoken' in the `token' function.
17927 Handle 0xa0 as whitespace (#34752)
17929 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17931 * typemanager.cs (IsCLRType): New routine to tell whether a type
17932 is one of the builtin types.
17934 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17935 typecode in more places instead of doing pointer comparissions.
17936 We could leverage some knowledge about the way the typecodes are
17939 New code to cache namespaces in assemblies, it is currently not
17940 invoked, to be used soon.
17942 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17944 * expression.cs (Binary.ResolveOperator): specially handle
17945 strings, and do not perform user-defined operator overloading for
17948 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17950 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17951 internalcall as it is a pretty simple operation; Avoid whenever
17952 possible to call Char.IsLetter.
17954 (consume_identifier): Cut by half the number of
17955 hashtable calls by merging the is_keyword and GetKeyword behavior.
17957 Do not short-circuit, because if we do, we
17958 report errors (ie, #if false && true would produce an invalid
17962 2002-11-24 Martin Baulig <martin@ximian.com>
17964 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17965 check constant ranges and report a CS0221. Fixes #33186.
17967 2002-11-24 Martin Baulig <martin@ximian.com>
17969 * cs-parser.jay: Make this work for uninitialized variable
17970 declarations in the `for' initializer. Fixes #32416.
17972 2002-11-24 Martin Baulig <martin@ximian.com>
17974 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17975 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17977 2002-11-24 Martin Baulig <martin@ximian.com>
17979 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17980 argument; if true, we also check for user-defined conversions.
17981 This is only needed if both arguments are of a user-defined type.
17982 Fixes #30443, added test-175.cs.
17983 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17985 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17987 2002-11-24 Martin Baulig <martin@ximian.com>
17989 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17990 function to get the store opcode.
17991 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17992 only emit the Ldelema if the store opcode is Stobj. You must run
17993 both test-34 and test-167 to test this. Fixes #34529.
17995 2002-11-23 Martin Baulig <martin@ximian.com>
17997 * ecore.cs (Expression.MemberLookup): Added additional
17998 `qualifier_type' argument which is used when we're being called
17999 from MemberAccess.DoResolve() and null if we're called from a
18001 (Expression.MemberLookupFailed): New method to report errors; this
18002 does the CS1540 check and reports the correct error message.
18004 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18005 argument for the CS1540 check and redone the way how we're dealing
18006 with private members. See the comment in the source code for details.
18007 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18008 `closure_start_type' to `closure_qualifier_type' and check whether
18009 it's not null. It was not this filter being broken, it was just
18010 being called with the wrong arguments.
18012 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18013 and pass it the correct `qualifier_type'; this also does the error
18016 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18018 * expression.cs (Invocation.EmitParams): If the we are dealing
18019 with a non-built-in value type, load its address as well.
18021 (ArrayCreation): Use a a pretty constant instead
18022 of the hardcoded value 2. Use 6 instead of 2 for the number of
18023 static initializers.
18025 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18026 because they are not really value types, just glorified integers.
18028 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18030 * ecore.cs: Remove redundant code for enumerations, make them use
18031 the same code path as everything else, fixes the casting issue
18032 with enumerations in Windows.Forms.
18034 * attribute.cs: Do only cast to string if it is a string, the
18035 validation happens later.
18037 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18038 people upgrade their corlibs.
18040 * ecore.cs: Oops, enumerations were not following the entire code path
18042 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18044 * typemanager.cs (FilterWithClosure): Commented out the test for
18045 1540 in typemanager.cs, as it has problems when accessing
18046 protected methods from a parent class (see test-174.cs).
18048 * attribute.cs (Attribute.ValidateGuid): new method.
18049 (Attribute.Resolve): Use above.
18051 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18053 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18055 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18056 handling for enumerations, as we only needed the TypeContainer
18057 functionality to begin with (this is required for the fix below to
18058 work for enums that reference constants in a container class for
18061 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18063 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18064 a valid TypeBuilder to perform lookups on.o
18066 * class.cs (InheritableMemberSignatureCompare): Use true in the
18067 call to GetGetMethod and GetSetMethod, because we are comparing
18068 the signature, and we need to get the methods *even* if they are
18071 (PropertyBase.CheckBase): ditto.
18073 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18074 GotoCase.Resolve): Use Peel on EmpytCasts.
18076 * ecore.cs (EmptyCast): drop child, add Peel method.
18078 2002-11-17 Martin Baulig <martin@ximian.com>
18080 * ecore.cs (EmptyCast.Child): New public property.
18082 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18083 label resolved to an EmptyCast. Fixes #34162.
18084 (GotoCase.Resolve): Likewise.
18085 (Block.EmitMeta): Likewise.
18087 2002-11-17 Martin Baulig <martin@ximian.com>
18089 * expression.cs (Invocation.BetterConversion): Prefer int over
18090 uint; short over ushort; long over ulong for integer literals.
18091 Use ImplicitConversionExists instead of StandardConversionExists
18092 since we also need to check for user-defined implicit conversions.
18093 Fixes #34165. Added test-173.cs.
18095 2002-11-16 Martin Baulig <martin@ximian.com>
18097 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18098 with the `true' and `false' literals. Fixes #33151.
18100 2002-11-16 Martin Baulig <martin@ximian.com>
18102 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18103 October 22nd; don't do the cs1540 check for static members.
18105 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18106 now using our own filter here and doing the cs1540 check again.
18108 2002-11-16 Martin Baulig <martin@ximian.com>
18110 * support.cs (InternalParameters): Don't crash if we don't have
18111 any fixed parameters. Fixes #33532.
18113 2002-11-16 Martin Baulig <martin@ximian.com>
18115 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18116 when looking up static methods to make this work on Windows.
18119 2002-11-16 Martin Baulig <martin@ximian.com>
18121 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18122 a setter rather than using PropertyInfo.CanWrite.
18124 2002-11-15 Nick Drochak <ndrochak@gol.com>
18126 * class.cs: Allow acces to block member by subclasses. Fixes build
18129 2002-11-14 Martin Baulig <martin@ximian.com>
18131 * class.cs (Constructor.Emit): Added the extern/block check.
18134 2002-11-14 Martin Baulig <martin@ximian.com>
18136 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18137 iteration while looking for indexers, this is needed because the
18138 indexer may have a different name in our base classes. Fixed the
18139 error reporting (no indexers at all, not get accessor, no
18140 overloaded match). Fixes bug #33089.
18141 (IndexerAccess.DoResolveLValue): Likewise.
18143 2002-11-14 Martin Baulig <martin@ximian.com>
18145 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18146 indexers. Fixes the first part of bug #33089.
18147 (MethodSignature.InheritableMemberSignatureCompare): Added support
18150 2002-11-13 Ravi Pratap <ravi@ximian.com>
18152 * attribute.cs (Attribute.Resolve): Catch the
18153 NullReferenceException and report it since it isn't supposed to
18156 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18158 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18159 LogicalOr and LogicalAnd that can benefit from recursively
18160 handling EmitBranchable. The code now should be nice for Paolo.
18162 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18164 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18165 the Type lookups, as we perform quite a number of lookups on
18166 non-Types. This can be removed once we can deterministically tell
18167 whether we have a type or a namespace in advance.
18169 But this might require special hacks from our corlib.
18173 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18174 and double which avoids a conversion from an integer to a double.
18176 * expression.cs: tiny optimization, avoid calling IsConstant,
18177 because it effectively performs the lookup twice.
18179 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18181 But a bogus return here to keep the semantics of the old code
18182 until the Mono runtime is fixed.
18184 * pending.cs (GetMissingInterfaces): New method used to remove all
18185 the interfaces that are already implemented by our parent
18186 classes from the list of pending methods.
18188 * interface.cs: Add checks for calls after ResolveTypeExpr.
18190 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18192 * class.cs (Class.Emit): Report warning 67: event not used if the
18193 warning level is beyond 3.
18195 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18196 being a NullLiteral.
18198 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18201 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18202 path that might fail if a type can not be resolved.
18204 * expression.cs (Binary.Emit): Emit unsigned versions of the
18207 * driver.cs: use error 5.
18209 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18211 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18213 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18215 * cs-parser.jay (switch_section): A beautiful patch from Martin
18216 Baulig that fixed 33094.
18218 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18220 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18221 Check whether the base is abstract and report an error if so.
18223 * expression.cs (IndexerAccess.DoResolveLValue,
18224 IndexerAccess.DoResolve): ditto.
18226 (Invocation.DoResolve): ditto.
18228 (Invocation.FullMethodDesc): Improve the report string.
18230 * statement.cs (Block): Eliminate IsVariableDefined as it is
18231 basically just a wrapper for GetVariableInfo.
18233 * ecore.cs (SimpleName): Use new
18235 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18236 type, as we return the actual parameter ref/unref state on a
18239 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18241 * support.cs: Return proper flags REF/OUT fixing the previous
18244 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18245 not used to mean `ref' but `ref or out' in ParameterReference
18247 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18248 full type signature instead of calling TypeManger.CSharpName
18251 * support.cs (InternalParameters.ParameterDesc): Do not compare
18252 directly to the modflags, because REF/OUT will actually be bitsets
18255 * delegate.cs (VerifyMethod): Check also the modifiers.
18257 * cs-tokenizer.cs: Fix bug where floating point values with an
18258 exponent where a sign was missing was ignored.
18260 * driver.cs: Allow multiple assemblies to be specified in a single
18263 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18265 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18266 because identifiers after a parenthesis would end up in this kind
18267 of production, and we needed to desamiguate it for having casts
18270 (UserDefinedType *) xxx
18272 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18274 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18275 we should set on the Bindingflags.NonPublic, but not turn on
18276 private_ok. private_ok controls whether a Private member is
18277 returned (this is chekced on the filter routine), while the
18278 BindingFlags.NonPublic just controls whether private/protected
18279 will be allowed. This fixes the problem part of the problem of
18280 private properties being allowed to be used in derived classes.
18282 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18283 so we can call the children DoResolveLValue method (this will
18284 properly signal errors on lvalue assignments to base properties)
18286 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18287 getter are null, and we have a property info, we know that this
18288 happened because the lookup failed, so we report an error 122 for
18289 protection level violation.
18291 We also silently return if setter and getter are null in the
18292 resolve functions, this condition only happens if we have flagged
18293 the error before. This is the other half of the problem.
18295 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18296 not have accessibility information, that is why we were returning
18297 true in the filter function in typemanager.cs.
18299 To properly report 122 (property is inaccessible because of its
18300 protection level) correctly, we report this error in ResolveAccess
18301 by failing if both the setter and the getter are lacking (ie, the
18304 DoResolve and DoLResolve have been modified to check for both
18305 setter/getter being null and returning silently, the reason being
18306 that I did not want to put the knowledge about this error in upper
18309 int old = Report.Errors;
18310 x = new PropertyExpr (...);
18311 if (old != Report.Errors)
18316 So the property expr is returned, but it is invalid, so the error
18317 will be flagged during the resolve process.
18319 * class.cs: Remove InheritablePropertySignatureCompare from the
18320 class, as we no longer depend on the property signature to compute
18321 whether it is possible to implement a method or not.
18323 The reason is that calling PropertyInfo.GetGetMethod will return
18324 null (in .NET, in Mono it works, and we should change this), in
18325 cases where the Get Method does not exist in that particular
18330 class X { public virtual int A { get { return 1; } } }
18332 class Z : Y { public override int A { get { return 2; } } }
18334 Would fail in Z because the parent (Y) would not have the property
18335 defined. So we avoid this completely now (because the alternative
18336 fix was ugly and slow), and we now depend exclusively on the
18339 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18340 reference method, instead of using the property.
18342 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18343 routines are gone now.
18345 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18346 names, they were incorrectly named.
18348 * cs-tokenizer.cs: Return are more gentle token on failure.
18350 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18351 had an out-of-sync index variable, which caused it to remove from
18352 the list of pending methods the wrong method sometimes.
18354 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18356 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18357 CanWrite, because those refer to this particular instance of the
18358 property, and do not take into account the fact that we can
18359 override single members of a property.
18361 Constructor requires an EmitContext. The resolution process does
18362 not happen here, but we need to compute the accessors before,
18363 because the resolution does not always happen for properties.
18365 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18366 subclass, before we did not update this flag, but we did update
18369 (GetAccessors): Drop this routine, as it did not work in the
18370 presence of partially overwritten set/get methods.
18372 Notice that this broke the cs1540 detection, but that will require
18375 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18379 * driver.cs: issue a warning instead of an error if we don't support
18380 debugging for the platform. Also ignore a couple of errors that may
18381 arise when trying to write the symbols. Undo my previous patch.
18383 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18385 * driver.cs: ignore /debug switch except for Unix platforms.
18387 2002-10-23 Nick Drochak <ndrochak@gol.com>
18389 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18391 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18393 * driver.cs: Do not make mcs-debug conditional, so we do not break
18394 builds that use it.
18396 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18397 review this patch. But basically after all the children variables
18398 have been merged, the value of "Breaks" was not being set to
18399 new_breaks for Switch blocks. I think that it should be set after
18400 it has executed. Currently I set this to the value of new_breaks,
18401 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18402 conservative, but I do not understand this code very well.
18404 I did not break anything in the build, so that is good ;-)
18406 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18408 2002-10-20 Mark Crichton <crichton@gimp.org>
18410 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18412 2002-10-20 Nick Drochak <ndrochak@gol.com>
18414 * cfold.cs: Fixed compile blocker.
18416 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18418 * driver.cs: I was chekcing the key, not the file.
18420 2002-10-19 Ravi Pratap <ravi@ximian.com>
18422 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18423 message that we were generating - we just need to silently return
18426 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18428 * class.cs (Event.Define): Change my previous commit, as this
18429 breaks the debugger. This is a temporary hack, as it seems like
18430 the compiler is generating events incorrectly to begin with.
18432 * expression.cs (Binary.ResolveOperator): Added support for
18433 "U operator - (E x, E y)"
18435 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18438 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18439 init-only variables, but this path did not take into account that
18440 there might be also instance readonly variables. Correct this
18443 This fixes bug 32253
18445 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18448 * driver.cs: Change the extension for modules to `netmodule'
18450 * cs-parser.jay: Improved slightly the location tracking for
18451 the debugger symbols.
18453 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18454 modifiers that were specified instead of the hardcoded value
18455 (FamAndAssem). This was basically ignoring the static modifier,
18456 and others. Fixes 32429.
18458 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18459 fixed a bug in the process (32476)
18461 * expression.cs (ArrayAccess.EmitAssign): Patch from
18462 hwang_rob@yahoo.ca that fixes bug 31834.3
18464 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18466 * driver.cs: Make the module extension .netmodule.
18468 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18470 * driver.cs: Report an error if the resource file is not found
18471 instead of crashing.
18473 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18474 false, like Emit does.
18476 2002-10-16 Nick Drochak <ndrochak@gol.com>
18478 * typemanager.cs: Remove unused private member. Also reported mcs
18479 bug to report this as a warning like csc.
18481 2002-10-15 Martin Baulig <martin@gnome.org>
18483 * statement.cs (Statement.Emit): Made this a virtual method; emits
18484 the line number info and calls DoEmit().
18485 (Statement.DoEmit): New protected abstract method, formerly knows
18486 as Statement.Emit().
18488 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18490 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18492 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18493 have fixed a remaining problem: not every AddXXXX was adding a
18494 fully qualified name.
18496 Now everyone registers a fully qualified name in the DeclSpace as
18497 being defined instead of the partial name.
18499 Downsides: we are slower than we need to be due to the excess
18500 copies and the names being registered this way.
18502 The reason for this is that we currently depend (on the corlib
18503 bootstrap for instance) that types are fully qualified, because
18504 we dump all the types in the namespace, and we should really have
18505 types inserted into the proper namespace, so we can only store the
18506 basenames in the defined_names array.
18508 2002-10-10 Martin Baulig <martin@gnome.org>
18510 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18511 from bug #31834, see the bug report for a testcase which is
18514 2002-10-10 Martin Baulig <martin@gnome.org>
18516 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18517 flow analysis code for this.
18519 * statement.cs (Do, While, For): Tell the flow analysis code about
18521 (FlowBranching.UsageVector): Added support for infinite loops.
18522 (Block.Resolve): Moved the dead code elimination here and use flow
18525 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18527 * class.cs (Field.Define): Catch cycles on struct type
18530 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18531 fields if the fields are static. We only need to check instance
18534 * expression.cs (As.DoResolve): Test for reference type.
18536 * statement.cs (Using.ResolveExpression): Use
18537 ConvertImplicitRequired, not ConvertImplicit which reports an
18539 (Using.ResolveLocalVariableDecls): ditto.
18541 * expression.cs (Binary.ResolveOperator): Report errors in a few
18542 places where we had to.
18544 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18546 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18548 * expression.cs: Use StoreFromPtr instead of extracting the type
18549 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18551 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18552 an enumeration value to a System.Enum, but System.Enum is not a
18553 value type, but an class type, so we need to box.
18555 (Expression.ConvertExplicit): One codepath could return
18556 errors but not flag them. Fix this. Fixes #31853
18558 * parameter.cs (Resolve): Do not allow void as a parameter type.
18560 2002-10-06 Martin Baulig <martin@gnome.org>
18562 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18563 if it's a class type and not a struct. Fixes #31815.
18565 2002-10-06 Martin Baulig <martin@gnome.org>
18567 * statement.cs: Reworked the flow analysis code a bit to make it
18568 usable for dead code elimination.
18570 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18572 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18574 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18576 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18577 to fix the test 165, will investigate deeper.
18579 2002-10-04 Martin Baulig <martin@gnome.org>
18581 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18582 finally blocks actually work.
18583 (Try.Resolve): We don't need to create a sibling for `finally' if
18584 there is no finally block.
18586 2002-10-04 Martin Baulig <martin@gnome.org>
18588 * class.cs (Constructor.Define): The default accessibility for a
18589 non-default constructor is private, not public.
18591 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18593 * class.cs (Constructor): Make AllowedModifiers public, add
18596 * cs-parser.jay: Perform the modifiers test here, as the
18597 constructor for the Constructor class usually receives a zero
18598 because of the way we create it (first we create, later we
18599 customize, and we were never checking the modifiers).
18601 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18602 is a version of LookupTypeReflection that includes the type-name
18603 cache. This can be used as a fast path for functions that know
18604 the fully qualified name and are only calling into *.GetType() to
18605 obtain a composed type.
18607 This is also used by TypeManager.LookupType during its type
18610 (LookupType): We now also track the real type name, as sometimes
18611 we can get a quey for the real type name from things like
18612 ComposedCast. This fixes bug 31422.
18614 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18615 complete type fullname, it does not have to go through the type
18616 resolution system to obtain the composed version of the type (for
18617 obtaining arrays or pointers).
18619 (Conditional.Emit): Use the EmitBoolExpression to
18620 generate nicer code, as requested by Paolo.
18622 (ArrayCreation.CheckIndices): Use the patch from
18623 hwang_rob@yahoo.ca to validate the array initializers.
18625 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18627 * class.cs (ConstructorInitializer.Emit): simplify code by using
18628 Invocation.EmitCall, and at the same time, fix the bugs in calling
18629 parent constructors that took variable arguments.
18631 * ecore.cs (Expression.ConvertNumericExplicit,
18632 Expression.ImplicitNumericConversion): Remove the code that
18633 manually wrapped decimal (InternalTypeConstructor call is now gone
18636 * expression.cs (Cast.TryReduce): Also handle decimal types when
18637 trying to perform a constant fold on the type.
18639 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18641 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18642 that only turned off an error report, and did nothing else.
18644 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18646 * driver.cs: Handle and ignore /fullpaths
18648 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18650 * expression.cs (Binary.ResolveOperator): Catch the case where
18651 DoNumericPromotions returns true,
18653 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18655 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18657 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18660 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18662 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18663 conversion exists, but it is also required that the conversion be
18664 performed. This manifested in "(Type64Enum) 2".
18666 * class.cs (TypeManager.AddMethod): The fix is not to change
18667 AddEnum, because that one was using a fully qualified name (every
18668 DeclSpace derivative does), but to change the AddMethod routine
18669 that was using an un-namespaced name. This now correctly reports
18670 the duplicated name.
18672 Revert patch until I can properly fix it. The issue
18673 is that we have a shared Type space across all namespaces
18674 currently, which is wrong.
18676 Options include making the Namespace a DeclSpace, and merge
18677 current_namespace/current_container in the parser.
18679 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18681 * cs-parser.jay: Improve error reporting when we get a different
18682 kind of expression in local_variable_type and
18683 local_variable_pointer_type.
18685 Propagate this to avoid missleading errors being reported.
18687 * ecore.cs (ImplicitReferenceConversion): treat
18688 TypeManager.value_type as a target just like object_type. As
18693 Is valid, and needs to result in the int 1 being boxed before it
18694 is assigned to the value type v.
18696 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18697 to validate the enumeration name.
18699 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18700 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18701 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18703 * ecore.cs (TryImplicitIntConversion): When doing an
18704 implicit-enumeration-conversion, check if the type is 64-bits and
18705 perform a conversion before passing to EnumConstant.
18707 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18709 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18710 report ambiguous type references. Unlike the MS version, we
18711 report what the ambiguity is. Innovation at work ;-)
18713 (DeclSpace.FindType): Require a location argument to
18714 display when we display an ambiguous error.
18716 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18718 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18720 * expression.cs (EmitDynamicInitializers): Apply patch from
18721 hwang_rob@yahoo.ca that fixes the order in which we emit our
18724 2002-09-21 Martin Baulig <martin@gnome.org>
18726 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18727 delegate takes no arguments.
18729 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18731 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18734 * expression.cs: Extract the underlying type.
18736 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18738 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18740 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18742 * class.cs (TypeContainer.DefineType): We can not use the nice
18743 PackingSize with the size set to 1 DefineType method, because it
18744 will not allow us to define the interfaces that the struct
18747 This completes the fixing of bug 27287
18749 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18750 means also structs. This fixes part of the problem.
18751 (Expresion.ImplicitReferenceConversionExists): ditto.
18753 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18754 error if there were no errors reported during the type lookup
18755 process, to avoid duplicates or redundant errors. Without this
18756 you would get an ambiguous errors plus a type not found. We have
18757 beaten the user enough with the first error.
18759 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18762 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18763 during the resolution process, stop the lookup, this avoids
18764 repeated error reports (same error twice).
18766 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18768 * typemanager.cs (LookupType): Redo the type lookup code to match
18769 the needs of System.Reflection.
18771 The issue is that System.Reflection requires references to nested
18772 types to begin with a "+" sign instead of a dot. So toplevel
18773 types look like: "NameSpace.TopLevelClass", and nested ones look
18774 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18777 2002-09-19 Martin Baulig <martin@gnome.org>
18779 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18780 says that a method always returns or always throws an exception,
18781 don't report the CS0161.
18783 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18784 set `Returns = new_returns'.
18786 2002-09-19 Martin Baulig <martin@gnome.org>
18788 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18789 to an enum constant, check for a CS0176.
18791 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18793 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18794 for operators that must be in pairs and report errors.
18796 * ecore.cs (SimpleName.DoResolveType): During the initial type
18797 resolution process, when we define types recursively, we must
18798 check first for types in our current scope before we perform
18799 lookups in the enclosing scopes.
18801 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18803 (Invocation.VerifyArgumentsCompat): Call
18804 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18805 I thought we were supposed to always call this, but there are a
18806 few places in the code where we dont do it.
18808 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18810 * driver.cs: Add support in -linkres and -resource to specify the
18811 name of the identifier.
18813 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18815 * ecore.cs (StandardConversionExists): Sync with the conversion
18816 code: allow anything-* to void* conversions.
18818 (FindMostSpecificSource): Use an Expression argument
18819 instead of a Type, because we might be handed over a Literal which
18820 gets a few more implicit conversions that plain types do not. So
18821 this information was being lost.
18823 Also, we drop the temporary type-holder expression when not
18826 2002-09-17 Martin Baulig <martin@gnome.org>
18828 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18829 this is an explicit interface implementation.
18831 2002-09-17 Martin Baulig <martin@gnome.org>
18833 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18834 different `IndexerName' attributes.
18836 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18837 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18838 virtual CommonResolve().
18840 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18842 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18843 and convert that to the UnderlyingType.
18845 * statement.cs (Foreach.Resolve): Indexers are just like variables
18846 or PropertyAccesses.
18848 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18849 inside quoted strings, we were not doing this before.
18851 2002-09-16 Martin Baulig <martin@gnome.org>
18853 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18854 resolve it. This is needed for the definite assignment check of the
18855 instance expression, fixes bug #29846.
18856 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18858 2002-09-16 Nick Drochak <ndrochak@gol.com>
18860 * parameter.cs: Fix compile error. Cannot reference static member
18861 from an instance object. Is this an mcs bug?
18863 2002-09-14 Martin Baulig <martin@gnome.org>
18865 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18866 multiple times. Fixes bug #30295, added test-166.cs.
18868 2002-09-14 Martin Baulig <martin@gnome.org>
18870 * statement.cs (Block.Emit): Don't emit unreachable code.
18871 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18872 `break' statements.
18873 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18875 2002-09-14 Martin Baulig <martin@gnome.org>
18877 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18880 2002-09-14 Martin Baulig <martin@gnome.org>
18882 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18883 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18884 be false on the ms runtime.
18886 2002-09-13 Martin Baulig <martin@gnome.org>
18888 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18889 the CS0038 error message.
18891 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18893 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18894 constant inside, return it.
18896 2002-09-12 Martin Baulig <martin@gnome.org>
18898 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18899 implicit conversion can be done between enum types.
18901 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18902 check whether an implicit conversion to the current enum's UnderlyingType
18903 exists and report an error if not.
18905 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18906 without debugging support.
18908 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18909 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18911 2002-09-12 Martin Baulig <martin@gnome.org>
18913 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18915 * ecore.cs (IMemberExpr.DeclaringType): New property.
18916 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18917 nonstatic member of an outer type (CS0038).
18919 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18921 * driver.cs: Activate the using-error detector at warning level
18922 4 (at least for MS-compatible APIs).
18924 * namespace.cs (VerifyUsing): Small buglett fix.
18926 * pending.cs (PendingImplementation): pass the container pointer.
18928 * interface.cs (GetMethods): Allow for recursive definition. Long
18929 term, I would like to move every type to support recursive
18930 definitions, not the current ordering mechanism that we have right
18933 The situation is this: Attributes are handled before interfaces,
18934 so we can apply attributes to interfaces. But some attributes
18935 implement interfaces, we will now handle the simple cases
18936 (recursive definitions will just get an error).
18938 * parameter.cs: Only invalidate types at the end if we fail to
18941 2002-09-09 Martin Baulig <martin@gnome.org>
18943 * ecore.cs (PropertyExpr.Emit): Also check for
18944 TypeManager.system_int_array_get_length so this'll also work when
18945 compiling corlib. Fixes #30003.
18947 2002-09-09 Martin Baulig <martin@gnome.org>
18949 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18950 and throw an exception if we can't get the type's size. Fixed #30040,
18953 2002-09-09 Martin Baulig <martin@gnome.org>
18955 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18957 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18958 context. Fixes bug #30027.
18960 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18961 virtual functions. Fixes bug #30043, added test-164.cs.
18963 2002-09-08 Ravi Pratap <ravi@ximian.com>
18965 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18967 2002-09-08 Nick Drochak <ndrochak@gol.com>
18969 * driver.cs: Use an object to get the windows codepage since it's not a
18972 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18974 * statement.cs (For.Emit): for infinite loops (test == null)
18975 return whether there is a break inside, not always "true".
18977 * namespace.cs (UsingEntry): New struct to hold the name of the
18978 using definition, the location where it is defined, and whether it
18979 has been used in a successful type lookup.
18981 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18986 2002-09-06 Ravi Pratap <ravi@ximian.com>
18988 * attribute.cs : Fix incorrect code which relied on catching
18989 a NullReferenceException to detect a null being passed in
18990 where an object was expected.
18992 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18994 * statement.cs (Try): flag the catch variable as assigned
18996 * expression.cs (Cast): Simplified by using ResolveType instead of
18997 manually resolving.
18999 * statement.cs (Catch): Fix bug by using ResolveType.
19001 2002-09-06 Ravi Pratap <ravi@ximian.com>
19003 * expression.cs (BetterConversion): Special case for when we have
19004 a NullLiteral as the argument and we have to choose between string
19005 and object types - we choose string the way csc does.
19007 * attribute.cs (Attribute.Resolve): Catch the
19008 NullReferenceException and report error #182 since the Mono
19009 runtime no more has the bug and having this exception raised means
19010 we tried to select a constructor which takes an object and is
19013 2002-09-05 Ravi Pratap <ravi@ximian.com>
19015 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19016 message (1502, 1503) when we can't locate a method after overload
19017 resolution. This is much more informative and closes the bug
19020 * interface.cs (PopulateMethod): Return if there are no argument
19021 types. Fixes a NullReferenceException bug.
19023 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19024 expressions too. Previously we were checking only in one place for
19025 positional arguments leaving out named arguments.
19027 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19028 type to the enum type is not allowed. Remove code corresponding to
19031 (ConvertNumericExplicit): Allow explicit conversions from
19032 the underlying type to enum type. This precisely follows the spec
19033 and closes a bug filed by Gonzalo.
19035 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19038 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19040 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19042 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19043 it was important that we stored the right value after the
19044 reduction in `converted'.
19046 2002-09-04 Martin Baulig <martin@gnome.org>
19048 * location.cs (Location.SymbolDocument): Use full pathnames for the
19051 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19053 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19054 of the expression resolve mechanism, because that will catch the
19055 SimpleName error failures.
19057 (Conditional): If we can not resolve the
19058 expression, return, do not crash.
19060 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19063 (location): display token name instead of its number.
19065 2002-08-28 Martin Baulig <martin@gnome.org>
19067 * expression.cs (Binary.ResolveOperator): Don't silently return
19068 but return an error if an operator cannot be applied between two
19071 2002-08-28 Martin Baulig <martin@gnome.org>
19073 * class.cs (Constructor.Define): Set the permission attributes
19074 correctly instead of making all constructors public.
19076 2002-08-28 Martin Baulig <martin@gnome.org>
19078 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19079 for private members before reporting a CS0103; if we find anything,
19082 2002-08-28 Martin Baulig <martin@gnome.org>
19084 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19085 to check whether `closure_start_type == closure_invocation_type',
19086 we also need to check whether `m.DeclaringType == closure_invocation_type'
19087 before bypassing the permission checks. We might be accessing
19088 protected/private members from the base class.
19089 (TypeManager.RealMemberLookup): Only set private_ok if private
19090 members were requested via BindingFlags.NonPublic.
19092 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19094 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19095 MethodGroupExpr.IsExplicitImpl if appropriate.
19096 (Invocation.DoResolve): Don't report the CS0120 for explicit
19097 interface implementations.
19099 2002-08-27 Martin Baulig <martin@gnome.org>
19101 * expression.cs (Invocation.DoResolve): If this is a static
19102 method and we don't have an InstanceExpression, we must report
19105 2002-08-25 Martin Baulig <martin@gnome.org>
19107 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19108 `==' between a valuetype and an object.
19110 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19112 * ecore.cs (TypeExpr): Provide a ToString method.
19114 2002-08-24 Martin Baulig <martin@gnome.org>
19116 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19117 now called proggie.dbg and it's a binary file.
19119 2002-08-23 Martin Baulig <martin@gnome.org>
19121 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19123 2002-08-23 Martin Baulig <martin@gnome.org>
19125 * struct.cs (MyStructInfo.ctor): Make this work with empty
19126 structs; it's not allowed to use foreach() on null.
19128 2002-08-23 Martin Baulig <martin@gnome.org>
19130 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19131 writer the full pathname of the generated assembly.
19133 2002-08-23 Martin Baulig <martin@gnome.org>
19135 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19136 A `finally' block never returns or breaks; improved handling of
19139 2002-08-23 Martin Baulig <martin@gnome.org>
19141 * statement.cs (Throw.Resolve): Allow `throw null'.
19143 2002-08-23 Martin Baulig <martin@gnome.org>
19145 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19146 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19147 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19148 MemberLookup would return a wrong event if this is an explicit
19149 interface implementation and the class has an event with the same
19152 2002-08-23 Martin Baulig <martin@gnome.org>
19154 * statement.cs (Block.AddChildVariableNames): New public method.
19155 (Block.AddChildVariableName): Likewise.
19156 (Block.IsVariableNameUsedInChildBlock): Likewise.
19157 (Block.AddVariable): Check whether a variable name has already
19158 been used in a child block.
19160 * cs-parser.jay (declare_local_variables): Mark all variable names
19161 from the current block as being used in a child block in the
19164 2002-08-23 Martin Baulig <martin@gnome.org>
19166 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19167 find the symbol writer.
19169 * driver.cs: csc also allows the arguments to /define being
19170 separated by commas, not only by semicolons.
19172 2002-08-23 Martin Baulig <martin@gnome.org>
19174 * interface.cs (Interface.GetMembers): Added static check for events.
19176 2002-08-15 Martin Baulig <martin@gnome.org>
19178 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19179 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19181 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19182 why the MethodData.EmitDestructor() change was necessary.
19184 2002-08-20 Martin Baulig <martin@gnome.org>
19186 * class.cs (TypeContainer.FindMembers): Added static check for events.
19188 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19190 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19191 use Type.GetEvents(), not Type.FindMembers().
19193 2002-08-20 Martin Baulig <martin@gnome.org>
19195 * decl.cs (MemberCache): Added a special method cache which will
19196 be used for method-only searched. This ensures that a method
19197 search will return a MethodInfo with the correct ReflectedType for
19200 2002-08-20 Martin Baulig <martin@gnome.org>
19202 * decl.cs (DeclSpace.FindMembers): Made this public.
19204 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19206 * delegate.cs: fixed build on windows.
19207 [FIXME: Filed as bug #29150: MCS must report these errors.]
19209 2002-08-19 Ravi Pratap <ravi@ximian.com>
19211 * ecore.cs (StandardConversionExists): Return a false
19212 if we are trying to convert the void type to anything else
19213 since that is not allowed.
19215 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19216 we flag error 70 in the event an event is trying to be accessed
19217 directly from outside the declaring type.
19219 2002-08-20 Martin Baulig <martin@gnome.org>
19221 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19222 MemberCache from typemanager.cs to decl.cs.
19224 2002-08-19 Martin Baulig <martin@gnome.org>
19226 * class.cs (TypeContainer): Implement IMemberContainer.
19227 (TypeContainer.DefineMembers): Create the MemberCache.
19228 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19229 return public members if BindingFlags.Public was given, check
19230 whether members are static.
19232 2002-08-16 Martin Baulig <martin@gnome.org>
19234 * decl.cs (DeclSpace.Define): Splitted this in Define and
19235 DefineMembers. DefineMembers is called first and initializes the
19238 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19239 DefineMembers() on all our DeclSpaces.
19241 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19242 but call DefineMembers() on all nested interfaces. We call their
19243 Define() in our new Define() function.
19245 * interface.cs (Interface): Implement IMemberContainer.
19246 (Interface.Define): Moved all code except the attribute stuf to
19248 (Interface.DefineMembers): Initialize the member cache.
19250 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19251 need this anymore since we can use MemberCache.FindMembers directly.
19253 2002-08-19 Martin Baulig <martin@gnome.org>
19255 * typemanager.cs (MemberCache): When creating the cache for an
19256 interface type, add all inherited members.
19257 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19258 to `out bool used_cache' and documented it.
19259 (TypeManager.MemberLookup): If we already used the cache in the first
19260 iteration, we don't need to do the interfaces check.
19262 2002-08-19 Martin Baulig <martin@gnome.org>
19264 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19265 here from IMemberFinder and don't implement this interface anymore.
19266 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19268 * typemanager.cs (IMemberFinder): This interface is now only used by
19269 classes which actually support the member cache.
19270 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19271 since we only put DeclSpaces into this Hashtable.
19272 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19273 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19275 2002-08-16 Martin Baulig <martin@gnome.org>
19277 * typemanager.cs (ICachingMemberFinder): Removed.
19278 (IMemberFinder.MemberCache): New property.
19279 (TypeManager.FindMembers): Merged this with RealFindMembers().
19280 This function will never be called from TypeManager.MemberLookup()
19281 so we can't use the cache here, just the IMemberFinder.
19282 (TypeManager.MemberLookup_FindMembers): Check whether the
19283 IMemberFinder has a MemberCache and call the cache's FindMembers
19285 (MemberCache): Rewrote larger parts of this yet another time and
19286 cleaned it up a bit.
19288 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19290 * driver.cs (LoadArgs): Support quoting.
19292 (Usage): Show the CSC-like command line arguments.
19294 Improved a few error messages.
19296 2002-08-15 Martin Baulig <martin@gnome.org>
19298 * typemanager.cs (IMemberContainer.Type): New property.
19299 (IMemberContainer.IsInterface): New property.
19301 The following changes are conditional to BROKEN_RUNTIME, which is
19302 defined at the top of the file.
19304 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19305 class'es members, but add all members from TypeHandle.ObjectType
19306 if we're an interface.
19307 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19308 is the current type.
19309 (MemberCache.CacheEntry.Container): Removed this field.
19310 (TypeHandle.GetMembers): Include inherited members.
19312 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19314 * typemanager.cs: fixed compilation and added a comment on a field that
19317 2002-08-15 Martin Baulig <martin@gnome.org>
19319 * class.cs (ConstructorInitializer.Resolve): In the
19320 Expression.MemberLookup call, use the queried_type as
19323 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19324 declared' attribute, it's always true.
19325 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19326 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19327 temporary wrapper for FindMembers which tells MemberLookup whether
19328 members from the base classes are included in the return value.
19329 This will go away soon.
19330 (TypeManager.MemberLookup): Use this temporary hack here; once the
19331 new MemberCache is completed, we don't need to do the DeclaredOnly
19332 looping here anymore since the MemberCache will take care of this.
19333 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19334 (MemberCache): When creating the MemberCache for a class, get
19335 members from the current class and all its base classes.
19336 (MemberCache.CacheEntry.Container): New field. This is a
19337 temporary hack until the Mono runtime is fixed to distinguish
19338 between ReflectedType and DeclaringType. It allows us to use MCS
19339 with both the MS runtime and the unfixed Mono runtime without
19340 problems and without accecting performance.
19341 (MemberCache.SearchMembers): The DeclaredOnly looping from
19342 TypeManager.MemberLookup is now done here.
19344 2002-08-14 Martin Baulig <martin@gnome.org>
19346 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19347 Type.GetFields on dynamic types but get the fields from the
19348 corresponding TypeContainer.
19349 (MyStructInfo.GetStructInfo): Added check for enum types.
19351 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19352 (MemberList.SyncRoot): Implemented.
19353 (TypeManager.FilterWithClosure): No need to check permissions if
19354 closure_start_type == closure_invocation_type, don't crash if
19355 closure_invocation_type is null.
19357 2002-08-13 Martin Baulig <martin@gnome.org>
19359 Rewrote TypeContainer.FindMembers to use a member cache. This
19360 gives us a speed increase of about 35% for the self-hosting MCS
19361 build and of about 15-20% for the class libs (both on GNU/Linux).
19363 * report.cs (Timer): New class to get enhanced profiling. This
19364 whole class is "TIMER" conditional since it remarkably slows down
19367 * class.cs (MemberList): New class. This is an IList wrapper
19368 which we're now using instead of passing MemberInfo[]'s around to
19369 avoid copying this array unnecessarily.
19370 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19371 (ICachingMemberFinder, IMemberContainer): New interface.
19372 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19373 has already been checked, otherwise use it for the name comparision.
19374 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19375 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19376 if possible. Returns a MemberList, not a MemberInfo [].
19377 (TypeHandle): New class, implements IMemberContainer. We create
19378 one instance of this class per type, it contains a MemberCache
19379 which is used to do the member lookups.
19380 (MemberCache): New class. Each instance of this class contains
19381 all members of a type and a name-based hash table.
19382 (MemberCache.FindMembers): This is our new member lookup
19383 function. First, it looks up all members of the requested name in
19384 the hash table. Then, it walks this list and sorts out all
19385 applicable members and returns them.
19387 2002-08-13 Martin Baulig <martin@gnome.org>
19389 In addition to a nice code cleanup, this gives us a performance
19390 increase of about 1.4% on GNU/Linux - not much, but it's already
19391 half a second for the self-hosting MCS compilation.
19393 * typemanager.cs (IMemberFinder): New interface. It is used by
19394 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19395 Enum, Delegate or Interface.
19396 (TypeManager.finder_to_member_finder): New PtrHashtable.
19397 (TypeManager.finder_to_container): Removed.
19398 (TypeManager.finder_to_delegate): Removed.
19399 (TypeManager.finder_to_interface): Removed.
19400 (TypeManager.finder_to_enum): Removed.
19402 * interface.cs (Interface): Implement IMemberFinder.
19404 * delegate.cs (Delegate): Implement IMemberFinder.
19406 * enum.cs (Enum): Implement IMemberFinder.
19408 * class.cs (TypeContainer): Implement IMemberFinder.
19410 2002-08-12 Martin Baulig <martin@gnome.org>
19412 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19414 2002-08-12 Martin Baulig <martin@gnome.org>
19416 * ecore.cs (ITypeExpression): New interface for expressions which
19418 (TypeExpression): Renamed to TypeLookupExpression.
19419 (Expression.DoResolve): If we're doing a types-only lookup, the
19420 expression must implement the ITypeExpression interface and we
19421 call DoResolveType() on it.
19422 (SimpleName): Implement the new ITypeExpression interface.
19423 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19424 hack, the situation that we're only looking up types can't happen
19425 anymore when this method is called. Moved the type lookup code to
19426 DoResolveType() and call it.
19427 (SimpleName.DoResolveType): This ITypeExpression interface method
19428 is now doing the types-only lookup.
19429 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19430 (ResolveFlags): Added MaskExprClass.
19432 * expression.cs (MemberAccess): Implement the ITypeExpression
19434 (MemberAccess.DoResolve): Added support for a types-only lookup
19435 when we're called via ITypeExpression.DoResolveType().
19436 (ComposedCast): Implement the ITypeExpression interface.
19438 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19439 Expression.Resolve() with ResolveFlags.Type instead.
19441 2002-08-12 Martin Baulig <martin@gnome.org>
19443 * interface.cs (Interface.Define): Apply attributes.
19445 * attribute.cs (Attribute.ApplyAttributes): Added support for
19446 interface attributes.
19448 2002-08-11 Martin Baulig <martin@gnome.org>
19450 * statement.cs (Block.Emit): Only check the "this" variable if we
19451 do not always throw an exception.
19453 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19454 whether the property has a set accessor.
19456 2002-08-11 Martin Baulig <martin@gnome.org>
19458 Added control flow analysis support for structs.
19460 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19461 with control flow analysis turned off.
19462 (IVariable): New interface.
19463 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19464 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19465 (FieldExpr.DoResolve): Resolve the instance expression with flow
19466 analysis turned off and do the definite assignment check after the
19467 resolving when we know what the expression will resolve to.
19469 * expression.cs (LocalVariableReference, ParameterReference):
19470 Implement the new IVariable interface, only call the flow analysis
19471 code if ec.DoFlowAnalysis is true.
19472 (This): Added constructor which takes a Block argument. Implement
19473 the new IVariable interface.
19474 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19475 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19476 This does the definite assignment checks for struct members.
19478 * class.cs (Constructor.Emit): If this is a non-static `struct'
19479 constructor which doesn't have any initializer, call
19480 Block.AddThisVariable() to tell the flow analysis code that all
19481 struct elements must be initialized before control returns from
19484 * statement.cs (MyStructInfo): New public class.
19485 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19486 argument to this indexer. If non-zero, check an individual struct
19487 member, not the whole struct.
19488 (FlowBranching.CheckOutParameters): Check struct members.
19489 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19490 overloaded versions of these methods which take an additional
19491 `int field_idx' argument to check struct members.
19492 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19493 overloaded versions of these methods which take an additional
19494 `string field_name' argument to check struct member.s
19495 (VariableInfo): Implement the IVariable interface.
19496 (VariableInfo.StructInfo): New public property. Returns the
19497 MyStructInfo instance of the variable if it's a struct or null.
19498 (Block.AddThisVariable): New public method. This is called from
19499 Constructor.Emit() for non-static `struct' constructor which do
19500 not have any initializer. It creates a special variable for the
19501 "this" instance variable which will be checked by the flow
19502 analysis code to ensure that all of the struct's fields are
19503 initialized before control returns from the constructor.
19504 (UsageVector): Added support for struct members. If a
19505 variable/parameter is a struct with N members, we reserve a slot
19506 in the usage vector for each member. A struct is considered fully
19507 initialized if either the struct itself (slot 0) or all its
19508 members are initialized.
19510 2002-08-08 Martin Baulig <martin@gnome.org>
19512 * driver.cs (Driver.MainDriver): Only report an error CS5001
19513 if there were no compilation errors.
19515 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19516 `UnsafeContext' property to determine whether the parent is in
19517 unsafe context rather than checking the parent's ModFlags:
19518 classes nested in an unsafe class are unsafe as well.
19520 2002-08-08 Martin Baulig <martin@gnome.org>
19522 * statement.cs (UsageVector.MergeChildren): Distinguish between
19523 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19524 we return. Added test17() and test18() to test-154.cs.
19526 2002-08-08 Martin Baulig <martin@gnome.org>
19528 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19529 Family access, make sure the invoking type isn't a subclass of the
19530 queried type (that'd be a CS1540).
19532 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19533 this method which takes an additional `Type invocation_type'.
19535 * expression.cs (BaseAccess.DoResolve): Use the base type as
19536 invocation and query type.
19537 (MemberAccess.DoResolve): If the lookup failed and we're about to
19538 report a CS0122, try a lookup with the ec.ContainerType - if this
19539 succeeds, we must report a CS1540.
19541 2002-08-08 Martin Baulig <martin@gnome.org>
19543 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19544 (MethodGroupExpr): Implement the IMemberExpr interface.
19546 * expression (MemberAccess.ResolveMemberAccess): No need to have
19547 any special code for MethodGroupExprs anymore, they're now
19550 2002-08-08 Martin Baulig <martin@gnome.org>
19552 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19553 Family, FamANDAssem and FamORAssem permissions.
19554 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19556 2002-08-08 Martin Baulig <martin@gnome.org>
19558 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19559 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19562 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19564 * driver.cs: implemented /resource option to embed managed resources.
19566 2002-08-07 Martin Baulig <martin@gnome.org>
19568 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19569 (FieldBase.HasFieldInitializer): New public property.
19570 (FieldBase.GetInitializerExpression): New public method. Resolves and
19571 returns the field initializer and makes sure it is only resolved once.
19572 (TypeContainer.EmitFieldInitializers): Call
19573 FieldBase.GetInitializerExpression to get the initializer, this ensures
19574 that it isn't resolved multiple times.
19576 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19577 the resolving process (SimpleName/MemberLookup) that we're currently
19578 emitting a field initializer (which must not access any instance members,
19579 this is an error CS0236).
19581 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19582 argument, if the `IsFieldInitializer' flag is set, we must report and
19583 error CS0236 and not an error CS0120.
19585 2002-08-07 Martin Baulig <martin@gnome.org>
19587 * ecore.cs (IMemberExpr): New public interface.
19588 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19589 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19590 if the expression is an IMemberExpr.
19592 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19593 to be null, implicitly default to `this' if we're non-static in
19594 this case. Simplified the code a lot by using the new IMemberExpr
19595 interface. Also fixed bug #28176 here.
19597 2002-08-06 Martin Baulig <martin@gnome.org>
19599 * cs-parser.jay (SimpleLookup): Removed. We need to create
19600 ParameterReferences during semantic analysis so that we can do a
19601 type-only search when resolving Cast, TypeOf and SizeOf.
19602 (block): Pass the `current_local_parameters' to the Block's
19605 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19606 argument to the constructor.
19607 (ConstructorInitializer.Resolve): Create a temporary implicit
19608 block with the parameters.
19610 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19611 references here if we aren't doing a type-only search.
19613 * statement.cs (Block): Added constructor which takes a
19614 `Parameters parameters' argument.
19615 (Block.Parameters): New public property.
19617 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19618 to `Parameters' and made it public readonly.
19620 2002-08-06 Martin Baulig <martin@gnome.org>
19622 * ecore.cs (Expression.Warning): Made this public as well.
19624 * report.cs (Report.Debug): Print the contents of collections.
19626 2002-08-06 Martin Baulig <martin@gnome.org>
19628 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19629 used to tell Resolve() which kinds of expressions it may return.
19630 (Expression.Resolve): Added overloaded version of this method which
19631 takes a `ResolveFlags flags' argument. This can be used to tell
19632 Resolve() which kinds of expressions it may return. Reports a
19634 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19635 ResolveFlags.SimpleName.
19636 (Expression.Error118): Added overloaded version of this method which
19637 takes a `ResolveFlags flags' argument. It uses the flags to determine
19638 which kinds of expressions are allowed.
19640 * expression.cs (Argument.ResolveMethodGroup): New public method.
19641 Resolves an argument, but allows a MethodGroup to be returned.
19642 This is used when invoking a delegate.
19644 * TODO: Updated a bit.
19646 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19648 Fixed compilation with csc.
19650 * ecore.cs: Expression.Error made public. Is this correct? Should
19651 Warning be made public too?
19653 * expression.cs: use ea.Location instead of ea.loc.
19654 [FIXME: Filed as bug #28607: MCS must report these errors.]
19656 2002-08-06 Martin Baulig <martin@gnome.org>
19658 * ecore.cs (Expression.loc): Moved the location here instead of
19659 duplicating it in all derived classes.
19660 (Expression.Location): New public property.
19661 (Expression.Error, Expression.Warning): Made them non-static and
19662 removed the location argument.
19663 (Expression.Warning): Added overloaded version which takes an
19664 `int level' argument.
19665 (Expression.Error118): Make this non-static and removed the
19666 expression and location arguments.
19667 (TypeExpr): Added location argument to the constructor.
19669 * expression.cs (StaticCallExpr): Added location argument to
19671 (Indirection, PointerArithmetic): Likewise.
19672 (CheckedExpr, UnCheckedExpr): Likewise.
19673 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19674 (StringPtr): Likewise.
19677 2002-08-05 Martin Baulig <martin@gnome.org>
19679 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19681 * assign.cs (Assign.DoResolve): Check whether the source
19682 expression is a value or variable.
19684 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19685 while resolving the corresponding blocks.
19687 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19688 an error, don't silently return null.
19690 * statement.cs (Block.AddVariable): Do the error reporting here
19691 and distinguish between CS0128 and CS0136.
19692 (Block.DoResolve): Report all unused labels (warning CS0164).
19693 (LabeledStatement): Pass the location to the constructor.
19694 (LabeledStatement.HasBeenReferenced): New property.
19695 (LabeledStatement.Resolve): Set it to true here.
19697 * statement.cs (Return.Emit): Return success even after reporting
19698 a type mismatch error (CS0126 or CS0127), this is what csc does and
19699 it avoids confusing the users with any consecutive errors.
19701 2002-08-05 Martin Baulig <martin@gnome.org>
19703 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19705 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19707 * expression.cs (MemberAccess.DoResolve): Silently return if an
19708 error has already been reported.
19710 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19711 error has already been reported.
19713 2002-08-05 Martin Baulig <martin@gnome.org>
19715 * statement.cs (UsageVector): Only initialize the `parameters'
19716 vector if we actually have any "out" parameters.
19718 2002-08-05 Martin Baulig <martin@gnome.org>
19720 * expression.cs (Binary.ResolveOperator): When combining delegates,
19721 they must have the same type.
19723 2002-08-05 Martin Baulig <martin@gnome.org>
19725 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19726 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19727 work with the ms runtime and we also don't need it: if we're a
19728 PropertyBuilder and not in the `indexer_arguments' hash, then we
19729 are a property and not an indexer.
19731 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19732 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19733 since the latter one doesn't work with the ms runtime.
19735 2002-08-03 Martin Baulig <martin@gnome.org>
19737 Fixed bugs #27998 and #22735.
19739 * class.cs (Method.IsOperator): New public field.
19740 (Method.CheckBase): Report CS0111 if there's already a method
19741 with the same parameters in the current class. Report CS0508 when
19742 attempting to change the return type of an inherited method.
19743 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19744 and it's not marked abstract or extern.
19745 (PropertyBase): New abstract base class for Property and Indexer.
19746 (PropertyBase.CheckBase): Moved here from Property and made it work
19748 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19749 the same so we can reuse it there.
19750 (Property, Indexer): Derive from PropertyBase.
19751 (MethodSignature.inheritable_property_signature_filter): New delegate
19752 to find properties and indexers.
19754 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19755 argument and improved error reporting.
19757 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19758 EmptyReadOnlyParameters and made it a property.
19760 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19761 version of this method which takes a `PropertyInfo indexer'.
19762 (TypeManager.RegisterIndexer): New method.
19764 * class.cs: Added myself as author of this file :-)
19766 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19768 * class.cs: fixed compilation on windoze.
19770 2002-08-03 Martin Baulig <martin@gnome.org>
19772 * interface.cs (Interface.GetInterfaceBases): Check whether all
19773 base interfaces are at least as accessible than the current one.
19775 * class.cs (TypeContainer.GetClassBases): Check whether base types
19776 are at least as accessible than the current type.
19777 (TypeContainer.AsAccessible): Implemented and made non-static.
19778 (MemberBase.CheckParameters): Report errors if the accessibility
19781 * delegate.cs (Delegate.Delegate): The default visibility is
19782 internal for top-level types and private for nested types.
19783 (Delegate.Define): Report errors if the accessibility checks fail.
19785 * enum.cs (Enum.Enum): The default visibility is internal for
19786 top-level types and private for nested types.
19787 (Enum.DefineType): Compute the correct visibility.
19789 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19790 function which takes a `bool is_toplevel' instead of a TypeContainer.
19792 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19795 2002-08-02 Martin Baulig <martin@gnome.org>
19797 * expression.cs (LocalVariableReferenc): Added constructor which
19798 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19799 (LocalVariableReference.IsReadOnly): New property.
19800 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19801 variable is readonly, use our own readonly flag to do this; you can
19802 use the new constructor to get a writable reference to a read-only
19805 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19806 reference to the local variable.
19808 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19810 * rootcontext.cs (ResolveCore): Also include System.Exception
19812 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19813 we reach an EmptyStatement.
19815 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19818 * expression.cs (Binary.ResolveOperator): Check error result in
19821 use brtrue/brfalse directly and avoid compares to null.
19823 2002-08-02 Martin Baulig <martin@gnome.org>
19825 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19826 Fixes bug #28407, added test-155.cs.
19828 2002-08-01 Martin Baulig <martin@gnome.org>
19830 * class.cs (Event.EmitDefaultMethod): Make this work with static
19831 events. Fixes #28311, added verify-3.cs.
19833 2002-08-01 Martin Baulig <martin@gnome.org>
19835 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19836 `is_disposable' fields.
19837 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19838 `hm.is_disposable' if we're using the collection pattern.
19839 (Foreach.EmitCollectionForeach): Use the correct type for the
19840 enumerator's local variable, only emit the try/finally block if
19841 necessary (fixes #27713).
19843 2002-08-01 Martin Baulig <martin@gnome.org>
19845 * ecore.cs (Expression.report118): Renamed to Error118 and made
19848 * statement.cs (Throw.Resolve): Check whether the expression is of
19849 the correct type (CS0118) and whether the type derives from
19850 System.Exception (CS0155).
19851 (Catch.Resolve): New method. Do the type lookup here and check
19852 whether it derives from System.Exception (CS0155).
19853 (Catch.CatchType, Catch.IsGeneral): New public properties.
19855 * typemanager.cs (TypeManager.exception_type): Added.
19857 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19859 * driver.cs: Updated About function.
19861 2002-07-31 Martin Baulig <martin@gnome.org>
19863 Implemented Control Flow Analysis.
19865 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19866 (EmitContext.CurrentBranching): Added.
19867 (EmitContext.StartFlowBranching): Added.
19868 (EmitContext.EndFlowBranching): Added.
19869 (EmitContext.KillFlowBranching): Added.
19870 (EmitContext.IsVariableAssigned): Added.
19871 (EmitContext.SetVariableAssigned): Added.
19872 (EmitContext.IsParameterAssigned): Added.
19873 (EmitContext.SetParameterAssigned): Added.
19874 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19875 Added control flow analysis stuff here.
19877 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19878 resolve the expression as lvalue.
19879 (LocalVariableReference.DoResolve): Check whether the variable has
19880 already been assigned.
19881 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19882 the parameter as assigned here.
19883 (ParameterReference.DoResolve): Check whether the parameter has already
19885 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19886 expression as lvalue.
19888 * statement.cs (FlowBranching): New class for the flow analysis code.
19889 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19890 (LabeledStatement.IsDefined): New public property.
19891 (LabeledStatement.AddUsageVector): New public method to tell flow
19892 analyis that the label may be reached via a forward jump.
19893 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19895 (VariableInfo.Number): New public field. This is used by flow analysis
19896 to number all locals of a block.
19897 (Block.CountVariables): New public property. This is the number of
19898 local variables in this block (including the locals from all parent
19900 (Block.EmitMeta): Number all the variables.
19902 * statement.cs: Added flow analysis support to all classes.
19904 2002-07-31 Martin Baulig <martin@gnome.org>
19906 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19907 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19908 then use this argument.
19910 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19912 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19913 use this to specify /define options.
19915 2002-07-29 Martin Baulig <martin@gnome.org>
19917 * statement.cs (Fixed): Moved all code that does variable lookups
19918 and resolvings from Emit to Resolve.
19920 * statement.cs (For): Moved all code that does variable lookups
19921 and resolvings from Emit to Resolve.
19923 * statement.cs (Using): Moved all code that does variable lookups
19924 and resolvings from Emit to Resolve.
19926 2002-07-29 Martin Baulig <martin@gnome.org>
19928 * attribute.cs (Attribute.Resolve): Explicitly catch a
19929 System.NullReferenceException when creating the
19930 CustromAttributeBuilder and report a different warning message.
19932 2002-07-29 Martin Baulig <martin@gnome.org>
19934 * support.cs (ParameterData.ParameterName): Added method to
19935 get the name of a parameter.
19937 * typemanager.cs (TypeManager.IsValueType): New public method.
19939 2002-07-29 Martin Baulig <martin@gnome.org>
19941 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19942 is a flag which specifies that it's either ref or out.
19943 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19944 the out parameter to `out Parameter.Modifier mod', also set the
19945 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19947 * support.cs (InternalParameters.ParameterModifier): Distinguish
19948 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19949 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19951 * expression.cs (Argument.GetParameterModifier): Distinguish
19952 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19953 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19955 2002-07-29 Martin Baulig <martin@gnome.org>
19957 * expression.cs (ParameterReference.ParameterReference): Added
19958 `Location loc' argument to the constructor.
19960 * cs-parser.jay: Pass location to ParameterReference.
19962 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19964 * statement.cs (Try): Initialize the location.
19966 * cs-parser.jay: pass location to Try.
19968 * expression.cs (Unary.Reduce): Change the prototype to return
19969 whether a constant fold could be performed or not. The result is
19970 returned in an out parameters. In the case of Indirection and
19971 AddressOf, we want to perform the full tests.
19973 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19975 * statement.cs (Statement.Emit): Flag dead code.
19977 2002-07-27 Andrew Birkett <andy@nobugs.org>
19979 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19981 2002-07-27 Martin Baulig <martin@gnome.org>
19983 * class.cs (MethodData.Define): Put back call to
19984 TypeManager.AddMethod(), accidentally commented this out.
19986 * report.cs (Debug): New public method to print debugging information,
19987 this is `[Conditional ("DEBUG")]'.
19989 2002-07-26 Martin Baulig <martin@gnome.org>
19991 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19992 (switch_statement): Push the current_block to the switch_stack and
19993 pop it again when we're done with the switch.
19994 (switch_section): The new block is a child of the current_block.
19995 Fixes bug #24007, added test-152.cs.
19997 2002-07-27 Martin Baulig <martin@gnome.org>
19999 * expression.cs (Invocation.EmitArguments): When calling a varargs
20000 function with only its fixed arguments, we need to pass an empty
20003 2002-07-27 Martin Baulig <martin@gnome.org>
20005 Mono 0.13 has been released.
20007 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20009 * driver.cs: Rename --resource to --linkres, because that is what
20010 we do currently, we dont support --resource yet.
20012 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20014 2002-07-25 Martin Baulig <martin@gnome.org>
20016 * class.cs (MethodData): New public class. This is a `method builder'
20017 class for a method or one accessor of a Property/Indexer/Event.
20018 (MethodData.GetMethodFlags): Moved here from MemberBase.
20019 (MethodData.ApplyAttributes): Likewise.
20020 (MethodData.ApplyObsoleteAttribute): Likewise.
20021 (MethodData.ApplyConditionalAttribute): Likewise.
20022 (MethodData.ApplyDllImportAttribute): Likewise.
20023 (MethodData.CheckAbstractAndExternal): Likewise.
20024 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20025 (MethodData.Emit): Formerly known as Method.Emit().
20026 (MemberBase): Moved everything which was specific to a single
20027 accessor/method to MethodData.
20028 (Method): Create a new MethodData and call Define() and Emit() on it.
20029 (Property, Indexer, Event): Create a new MethodData objects for each
20030 accessor and call Define() and Emit() on them.
20032 2002-07-25 Martin Baulig <martin@gnome.org>
20034 Made MethodCore derive from MemberBase to reuse the code from there.
20035 MemberBase now also checks for attributes.
20037 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20038 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20040 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20041 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20042 (MemberBase.ApplyAttributes): New virtual method; applies the
20043 attributes to a method or accessor.
20044 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20045 (MemberBase.ApplyConditionalAttribute): Likewise.
20046 (MemberBase.ApplyDllImportAttribute): Likewise.
20047 (MemberBase.CheckAbstractAndExternal): Likewise.
20048 (MethodCore.ParameterTypes): This is now a property instead of a
20049 method, it's initialized from DoDefineParameters().
20050 (MethodCore.ParameterInfo): Removed the set accessor.
20051 (MethodCore.DoDefineParameters): New protected virtual method to
20052 initialize ParameterTypes and ParameterInfo.
20053 (Method.GetReturnType): We can now simply return the MemberType.
20054 (Method.GetMethodFlags): Override the MemberBase version and add
20055 the conditional flags.
20056 (Method.CheckBase): Moved some code from Define() here, call
20057 DoDefineParameters() here.
20058 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20059 here to avoid some larger code duplication.
20060 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20061 ensure that abstract and external accessors don't declare a body.
20063 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20064 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20065 lookup in the attribute's parent classes, so we need to abort as soon
20066 as we found the first match.
20067 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20068 the attribute has no arguments.
20070 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20073 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20075 * cs-parser.jay: reverted previous patch.
20077 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20079 * cs-parser.jay: fixed bug #22119.
20081 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20083 * attribute.cs: fixed compilation. The error was:
20084 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20085 be assigned to before control leaves the current method."
20086 [FIXME: Filed as bug #28186: MCS must report this error.]
20088 2002-07-25 Martin Baulig <martin@gnome.org>
20090 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20091 method to pull the condition name ouf of a Conditional attribute.
20092 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20093 the obsolete message and error flag out of an Obsolete attribute.
20095 * class.cs (Method.GetMethodFlags): New public method to get the
20096 TypeManager.MethodFlags for this method.
20097 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20099 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20100 if we're overriding a virtual function, set the new private variable
20101 `parent_method'; call the new TypeManager.AddMethod().
20103 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20104 the MethodBuilder and the Method in a PtrHashtable.
20105 (TypeManager.builder_to_method): Added for this purpose.
20106 (TypeManager.MethodFlags): Added IsObsoleteError.
20107 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20108 Obsolete and Conditional arguments in MethodBuilders. If we discover
20109 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20110 the message from the attribute.
20112 2002-07-24 Martin Baulig <martin@gnome.org>
20114 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20115 preprocessor directives, ensure that the argument to #define/#undef is
20116 exactly one identifier and that it's actually an identifier.
20118 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20121 2002-07-24 Martin Baulig <martin@gnome.org>
20123 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20124 initialize it to TypeManager.object_type in the constructor.
20125 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20126 of the `hm.get_current' method if we're using the collection pattern.
20127 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20128 for the explicit conversion to make it work when we're using the collection
20129 pattern and the `Current' property has a different return type than `object'.
20132 2002-07-24 Martin Baulig <martin@gnome.org>
20134 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20135 does not match, but don't report any errors. This method is called in
20136 order for all methods in a MethodGroupExpr until a matching method is
20137 found, so we don't want to bail out if the first method doesn't match.
20138 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20139 matches, report the 123. Fixes #28070.
20141 2002-07-24 Martin Baulig <martin@gnome.org>
20143 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20144 TypeManager.TypeToCoreType() to the top of the method so the
20145 following equality checks will work. Fixes #28107.
20147 2002-07-24 Martin Baulig <martin@gnome.org>
20149 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20150 operand is of type uint, and the other operand is of type sbyte,
20151 short or int, the operands are converted to type long." -
20152 Actually do what this comment already told us. Fixes bug #28106,
20155 2002-07-24 Martin Baulig <martin@gnome.org>
20157 * class.cs (MethodBase): New abstract class. This is now a base
20158 class for Property, Indexer and Event to avoid some code duplication
20159 in their Define() and DefineMethods() methods.
20160 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20161 generic methods for Define() and DefineMethods().
20162 (FieldBase): Derive from MemberBase, not MemberCore.
20163 (Property): Derive from MemberBase, not MemberCore.
20164 (Property.DefineMethod): Moved all the code from this method to the
20165 new MethodBase.DefineAccessor(), just call it with appropriate
20167 (Property.Define): Call the new Property.DoDefine(), this does some
20168 sanity checks and we don't need to duplicate the code everywhere.
20169 (Event): Derive from MemberBase, not MemberCore.
20170 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20171 accessors, this will also make them work with interface events.
20172 (Indexer): Derive from MemberBase, not MemberCore.
20173 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20174 (Indexer.Define): Use the new MethodBase functions.
20176 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20177 argument to the constructor.
20178 (Interface.FindMembers): Added support for interface events.
20179 (Interface.PopluateEvent): Implemented.
20181 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20183 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20185 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20186 but this is required to check for a method name being the same as
20187 the containing class.
20191 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20193 * interface.cs: initialize variable.
20195 2002-07-23 Martin Baulig <martin@gnome.org>
20197 Implemented the IndexerName attribute in interfaces.
20199 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20200 name if this is an explicit interface implementation.
20201 (Indexer.InterfaceIndexerName): New public variable. If we're
20202 implementing an interface indexer, this is the IndexerName in that
20203 interface. Otherwise, it's the IndexerName.
20204 (Indexer.DefineMethod): If we're implementing interface indexer,
20205 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20206 and Pending.ImplementIndexer methods.
20207 (Indexer.Define): Also define the PropertyBuilder if we're
20208 implementing an interface indexer and this is neither an explicit
20209 interface implementation nor do the IndexerName match the one in
20212 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20213 If a method is defined here, then we always need to create a proxy
20214 for it. This is used when implementing interface indexers.
20215 (Pending.IsInterfaceIndexer): New public method.
20216 (Pending.ImplementIndexer): New public method.
20217 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20218 This is used when implementing interface indexers to define a proxy
20220 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20221 define a proxy if necessary.
20223 * interface.cs (Interface.IndexerName): New public variable.
20224 (Interface.PopulateIndexer): Set the IndexerName.
20225 (Interface.DefineIndexers): New private method. Populate all the
20226 indexers and make sure their IndexerNames match.
20228 * typemanager.cs (IndexerPropertyName): Added support for interface
20231 2002-07-22 Martin Baulig <martin@gnome.org>
20233 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20234 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20235 ret if HasReturnLabel.
20236 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20239 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20240 and set the ec.LoopBeginTryCatchLevel.
20241 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20242 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20243 the current ec.TryCatchLevel, the branch goes out of an exception
20244 block. In this case, we need to use Leave and not Br.
20246 2002-07-22 Martin Baulig <martin@gnome.org>
20248 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20249 block unless the block does not always return or it is contained in
20250 another try { ... } catch { ... } block. Fixes bug #26506.
20251 Added verify-1.cs to the test suite.
20253 2002-07-22 Martin Baulig <martin@gnome.org>
20255 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20256 then we do not always return. Fixes bug #24985.
20258 2002-07-22 Martin Baulig <martin@gnome.org>
20260 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20261 lookup on a per-class level; ie. walk up the class hierarchy until we
20262 found at least one applicable method, then choose the best among them.
20263 Fixes bug #24463 and test-29.cs.
20265 2002-07-22 Martin Baulig <martin@gnome.org>
20267 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20268 return types of the methods. The return type is not part of the
20269 signature and we must not check it to make the `new' modifier work.
20270 Fixes bug #27999, also added test-147.cs.
20271 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20273 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20274 on the method's return type.
20276 2002-07-21 Martin Baulig <martin@gnome.org>
20278 * assign.cs: Make this work if the rightmost source is a constant and
20279 we need to do an implicit type conversion. Also adding a few more tests
20280 to test-38.cs which should have caught this.
20282 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20283 target in the makefile for this. The makefile.gnu is primarily intended
20284 for end-users who don't want to debug the compiler.
20286 2002-07-21 Martin Baulig <martin@gnome.org>
20288 * assign.cs: Improved the Assign class so it can now handle embedded
20289 assignments (X = Y = Z = something). As a side-effect this'll now also
20290 consume less local variables. test-38.cs now passes with MCS, added
20291 a few new test cases to that test.
20293 2002-07-20 Martin Baulig <martin@gnome.org>
20295 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20296 instructions. Fixes bug #27977, also added test-146.cs.
20298 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20300 * cs-tokenizer.cs: fixed getHex ().
20302 2002-07-19 Martin Baulig <martin@gnome.org>
20304 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20305 not Type.GetType() to lookup the array type. This is needed when
20306 we're constructing an array of a user-defined type.
20307 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20308 single-dimensional arrays, but also for single-dimensial arrays of
20311 2002-07-19 Martin Baulig <martin@gnome.org>
20313 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20314 this function is called, it's not allowed to share LocalBuilders
20315 among ILGenerators.
20317 2002-07-19 Martin Baulig <martin@gnome.org>
20319 * expression.cs (Argument.Resolve): Report an error 118 when trying
20320 to pass a type as argument.
20322 2002-07-18 Martin Baulig <martin@gnome.org>
20324 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20325 Conv_R_Un for the signed `long' type.
20327 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20329 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20330 `expr' for the temporary result, as that will fail if we do
20331 multiple resolves on the same expression.
20333 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20335 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20336 ec.TypeContainer for looking up aliases.
20338 * class.cs (TypeContainer): Remove LookupAlias from here.
20340 * decl.cs (DeclSpace); Move here.
20342 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20344 * class.cs (FindMembers): Only call filter if the constructor
20345 bulider is not null.
20347 Also handle delegates in `NestedTypes' now. Now we will perform
20348 type lookups using the standard resolution process. This also
20351 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20352 This uses Expressions (the limited kind that can be parsed by the
20353 tree) instead of strings.
20355 * expression.cs (ComposedCast.ToString): Implement, used to flag
20356 errors since now we have to render expressions.
20358 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20361 * ecore.cs (SimpleName.ToString): ditto.
20363 * cs-parser.jay: Instead of using strings to assemble types, use
20364 Expressions to assemble the type (using SimpleName, ComposedCast,
20365 MemberAccess). This should fix the type lookups in declarations,
20366 because we were using a different code path for this.
20368 * statement.cs (Block.Resolve): Continue processing statements
20369 even when there is an error.
20371 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20373 * class.cs (Event.Define): Also remove the `remove' method from
20374 the list of pending items.
20376 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20377 generate more compact code.
20379 2002-07-17 Martin Baulig <martin@gnome.org>
20381 * const.cs (Const.LookupConstantValue): Add support for constant
20382 `unchecked' and `checked' expressions.
20383 Also adding test case test-140.cs for this.
20385 2002-07-17 Martin Baulig <martin@gnome.org>
20387 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20388 check whether mi.ReturnType implements the IEnumerator interface; the
20389 `==' and the IsAssignableFrom() will fail in this situation.
20391 2002-07-16 Ravi Pratap <ravi@ximian.com>
20393 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20396 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20398 * expression.cs: fixed bug #27811.
20400 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20402 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20403 Molaro: when we are a ref, the value already contains a pointer
20404 value, do not take the address of it.
20406 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20407 * removed mb-parser.jay and mb-tokenizer.cs
20409 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20411 * expression.cs: check against the building corlib void type.
20413 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20415 * ecore.cs: fix for valuetype static readonly fields: when
20416 initializing them, we need their address, not the address of a copy.
20418 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20420 * typemanager.cs: register also enum_type in corlib.
20422 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20424 * class.cs: allow calling this (but not base) initializers in structs.
20426 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20428 * ecore.cs: make sure we compare against the building base types
20431 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20433 * typemanager.cs: fix TypeToCoreType() to handle void and object
20434 (corlib gets no more typerefs after this change).
20436 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20438 * expression.cs (ArrayCreation.EmitArrayArguments): use
20439 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20441 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20442 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20443 array indexes, the runtime actually forbids them.
20445 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20446 for array arguments here.
20448 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20449 instead of the default for ValueTypes.
20451 (New.DoEmit): Use IsValueType instead of
20452 IsSubclassOf (value_type)
20453 (New.DoResolve): ditto.
20454 (Invocation.EmitCall): ditto.
20456 * assign.cs (Assign): ditto.
20458 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20459 Statements *are* currently doing part of their resolution during
20462 Expressions do always resolve during resolve, but statements are
20463 only required to propagate resolution to their children.
20465 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20467 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20469 (LoadAssembly): Do not add the dll if it is already specified
20471 (MainDriver): Add the System directory to the link path at the end,
20472 after all the other -L arguments.
20474 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20475 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20476 ldelem.u1) and using the opposite for sbytes.
20478 This fixes Digger, and we can finally run it.
20480 * driver.cs (UnixParseOption): Move the option parsing here.
20481 (CSCParseOption): Implement CSC-like parsing of options.
20483 We now support both modes of operation, the old Unix way, and the
20484 new CSC-like way. This should help those who wanted to make cross
20485 platform makefiles.
20487 The only thing broken is that /r:, /reference: and /lib: are not
20488 implemented, because I want to make those have the same semantics
20489 as the CSC compiler has, and kill once and for all the confussion
20490 around this. Will be doing this tomorrow.
20492 * statement.cs (Unsafe.Resolve): The state is checked during
20493 resolve, not emit, so we have to set the flags for IsUnsfe here.
20495 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20497 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20498 not catch the Error_ObjectRefRequired in SimpleName (as it is
20499 possible to have a class/instance variable name that later gets
20500 deambiguated), we have to check this here.
20502 2002-07-10 Ravi Pratap <ravi@ximian.com>
20504 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20505 make static and put into Expression.
20507 (Event.Define): Register the private field of the event with the
20508 TypeManager so that GetFieldFromEvent can get at it.
20510 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20511 keep track of the private field associated with an event which
20514 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20517 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20519 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20521 * expression.cs (Binary.EmitBranchable): this routine emits the
20522 Binary expression in a branchable context. This basically means:
20523 we need to branch somewhere, not just get the value on the stack.
20525 This works together with Statement.EmitBoolExpression.
20527 * statement.cs (Statement.EmitBoolExpression): Use
20530 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20532 * statement.cs (For): Reduce the number of jumps in loops.
20534 (For): Implement loop inversion for the For statement.
20536 (Break): We can be breaking out of a Try/Catch controlled section
20537 (foreach might have an implicit try/catch clause), so we need to
20538 use Leave instead of Br.
20540 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20541 now). If the instace expression supports IMemoryLocation, we use
20542 the AddressOf method from the IMemoryLocation to extract the
20543 address instead of emitting the instance.
20545 This showed up with `This', as we were emitting the instance
20546 always (Emit) instead of the Address of This. Particularly
20547 interesting when This is a value type, as we dont want the Emit
20548 effect (which was to load the object).
20550 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20552 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20554 * statement.cs (Checked): Set the CheckedState during the resolve
20555 process too, as the ConvCast operations track the checked state on
20556 the resolve process, and not emit.
20558 * cs-parser.jay (namespace_member_declaration): Flag that we have
20559 found a declaration when we do. This is used to flag error 1529
20561 * driver.cs: Report ok when we display the help only.
20563 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20565 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20567 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20569 * cs-tokenizer.cs (define): We also have to track locally the
20570 defines. AllDefines is just used for the Conditional Attribute,
20571 but we also need the local defines for the current source code.
20573 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20575 * statement.cs (While, For, Do): These loops can exit through a
20576 Break statement, use this information to tell whether the
20577 statement is the last piece of code.
20579 (Break): Flag that we break.
20581 * codegen.cs (EmitContexts): New `Breaks' state variable.
20583 2002-07-03 Martin Baulig <martin@gnome.org>
20585 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20586 modifiers in method declarations in structs. Otherwise, you won't
20587 be able to override things like Object.Equals().
20589 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20591 * class.cs (Method, Property, Indexer): Do not allow the public
20592 modifier to be used in explicit interface implementations.
20594 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20595 override modifiers in method declarations in structs
20597 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20599 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20600 integer or real overflow, report an error
20602 2002-07-02 Martin Baulig <martin@gnome.org>
20604 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20605 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20606 to tell the runtime about our newly created System.Object and
20607 System.ValueType types.
20609 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20611 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20612 struct instead of Ldarg/Starg.
20614 2002-07-02 Martin Baulig <martin@gnome.org>
20616 * expression.cs (Indirection.Indirection): Call
20617 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20619 2002-07-02 Martin Baulig <martin@gnome.org>
20621 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20622 ValueType, call TypeManager.TypeToCoreType() on it.
20623 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20624 the OpCodes.Newarr argument.
20626 2002-07-02 Martin Baulig <martin@gnome.org>
20628 * expression.cs (Invocation.EmitCall): When compiling corlib,
20629 replace all calls to the system's System.Array type to calls to
20630 the newly created one.
20632 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20633 System.Array methods.
20634 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20635 from the system's System.Array type which must be replaced.
20637 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20639 * typemanager.cs: load unverifiable_code_ctor so we can build
20640 corlib using the correct type. Avoid using GetTypeCode() with
20642 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20643 TypeManager.object_type to allow building corlib.
20645 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20647 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20649 2002-07-01 Martin Baulig <martin@gnome.org>
20651 * class.cs: Make the last change actually work, we need to check
20652 whether `ifaces != null' to avoid a crash.
20654 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20656 * class.cs: when we build structs without fields that implement
20657 interfaces, we need to add the interfaces separately, since there is
20658 no API to both set the size and add the interfaces at type creation
20661 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20663 * expression.cs: the dimension arguments to the array constructors
20664 need to be converted if they are a long.
20666 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20668 * class.cs: don't emit ldarg.0 if there is no parent constructor
20669 (fixes showstopper for corlib).
20671 2002-06-29 Martin Baulig <martin@gnome.org>
20673 MCS now compiles corlib on GNU/Linux :-)
20675 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20676 ie. check for MethodImplOptions.InternalCall.
20678 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20679 and TypeManager.attribute_type are null, so we must explicitly check
20680 whether parent is not null to find out whether it's an attribute type.
20681 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20682 and SetBuilder, not only if the property is neither abstract nor external.
20683 This is necessary to set the MethodImplOptions on the accessor methods.
20684 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20685 SetBuilder, see Property.Emit().
20687 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20688 populate "System.Object", "System.ValueType" and "System.Attribute" since
20689 they've already been populated from BootCorlib_PopulateCoreTypes().
20691 2002-06-29 Martin Baulig <martin@gnome.org>
20693 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20694 is the NullLiteral, we also need to make sure that target_type is not
20697 2002-06-29 Martin Baulig <martin@gnome.org>
20699 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20700 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20701 before calling BootstrapCorlib_ResolveDelegate ().
20703 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20705 * statement.cs: fixed build-breaker. All tests passed ok.
20707 2002-06-27 Martin Baulig <martin@gnome.org>
20709 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20710 for System.Decimal when compiling corlib.
20712 2002-06-27 Martin Baulig <martin@gnome.org>
20714 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20715 switch blocks which contain nothing but a default clause.
20717 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20719 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20721 2002-06-27 Martin Baulig <martin@gnome.org>
20723 * ecore.cs (PropertyExpr.PropertyExpr): Call
20724 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20726 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20727 is already a TypeBuilder.
20729 2002-06-27 Martin Baulig <martin@gnome.org>
20731 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20732 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20733 the "from an array-type to System.Array" case. This makes it work
20734 when compiling corlib.
20736 2002-06-27 Martin Baulig <martin@gnome.org>
20738 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20739 non-static PropertyExpr, set its InstanceExpression. This makes
20740 the `ICollection.Count' property work in System/Array.cs.
20742 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20744 * driver.cs: Made error handling more consistent. Errors now
20745 tracked by Report class, so many methods which used to return int
20746 now return void. Main() now prints success/failure and
20747 errors/warnings message.
20749 Renamed '--probe' compiler argument to '--expect-error'. Removed
20750 the magic number return values (123 and 124). Now, if the
20751 expected error occurs, the compiler exits with success (exit value
20752 0). If the compilation completes without seeing that particular
20753 error, the compiler exits with failure (exit value 1). The
20754 makefile in mcs/errors has been changed to handle the new behaviour.
20756 * report.cs: Made 'expected error' number a property and renamed
20757 it from 'Probe' to 'ExpectedError'.
20759 * genericparser.cs: Removed error handling support, since it is
20760 now all done by Report class.
20762 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20763 class, so parse() no longer returns an int.
20765 * namespace.cs: Use Report.Error instead of GenericParser.error
20767 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20769 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20770 TypeContainer.AddOperator): At the front of the list put the
20771 explicit implementations, so they get resolved/defined first.
20773 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20775 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20776 interface type is implemented by this TypeContainer. Used during
20777 explicit interface implementation.
20779 (Property.Define, Indexer.Define, Method.Define): Validate that
20780 the given interface in the explicit implementation is one of the
20781 base classes for the containing type.
20783 Also if we are explicitly implementing an interface, but there is
20784 no match in the pending implementation table, report an error.
20786 (Property.Define): Only define the property if we are
20787 not explicitly implementing a property from an interface. Use the
20788 correct name also for those properties (the same CSC uses,
20789 although that is really not needed).
20791 (Property.Emit): Do not emit attributes for explicitly implemented
20792 properties, as there is no TypeBuilder.
20794 (Indexer.Emit): ditto.
20796 Hiding then means that we do not really *implement* a pending
20797 implementation, which makes code fail.
20799 2002-06-22 Martin Baulig <martin@gnome.org>
20801 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20802 the return value of Object.GetType(). [FIXME: we need to do this whenever
20803 we get a type back from the reflection library].
20805 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20807 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20809 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20811 * attribute.cs: Return null if we can not look up the type.
20813 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20814 the interface types found.
20816 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20817 interface types found.
20819 * typemanager.cs (GetInterfaces): Make this routine returns alll
20820 the interfaces and work around the lame differences between
20821 System.Type and System.Reflection.Emit.TypeBuilder in the results
20822 result for GetInterfaces.
20824 (ExpandInterfaces): Given an array of interface types, expand and
20825 eliminate repeated ocurrences of an interface. This expands in
20826 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20829 2002-06-21 Martin Baulig <martin@gnome.org>
20831 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20834 2002-06-21 Martin Baulig <martin@gnome.org>
20836 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20837 and called with one of the core types, return the corresponding typebuilder for
20840 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20843 2002-06-21 Martin Baulig <martin@gnome.org>
20845 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20846 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20847 (Expression.ConvertReferenceExplicit): Likewise.
20849 * expression.cs (ElementAccess.DoResolve): Likewise.
20850 (ElementAccess.DoResolveLValue): Likewise.
20852 2002-06-10 Martin Baulig <martin@gnome.org>
20854 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20855 add the "value" parameter to the parameter list.
20857 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20860 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20862 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20863 the argument to an int, uint, long or ulong, per the spec. Also
20864 catch negative constants in array creation.
20866 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20868 * class.cs: do not allow the same interface to appear twice in
20869 the definition list.
20871 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20873 * ecore.cs: don't use ldlen with System.Array.
20875 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20877 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20879 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20881 * modifiers.cs: produce correct field attributes for protected
20882 internal. Easy fix so miguel can work on ther harder stuff:-)
20884 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20886 * pending.cs: New file. Move the code from class.cs here.
20887 Support clearning the pending flag for all methods (when not doing
20888 explicit interface implementation).
20890 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20892 * rootcontext.cs: added a couple more types needed to bootstrap.
20894 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20896 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20897 constructor in the type, instead of any constructor in the type
20898 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20899 a bug in the Mono runtime when applying the params attribute).
20901 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20902 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20904 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20906 * expression.cs (Unary.ResolveOperator): Use TypeManager
20907 to resolve the type.
20909 2002-06-13 Ravi Pratap <ravi@ximian.com>
20911 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20914 * enum.cs (AddEnumMember): Add support to store the attributes associated
20915 with each member too.
20917 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20918 field builders too - this takes care of the enum member case.
20920 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20922 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20923 address-of operator on both value types and pointers.
20925 2002-06-10 Martin Baulig <martin@gnome.org>
20927 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20928 PropertyBuilder to the `property_builders' list.
20930 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20931 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20932 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20933 find any indexers which are inherited from an interface.
20935 2002-06-09 Martin Baulig <martin@gnome.org>
20937 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20938 the same type as the constant if necessary. There's also a test-130.cs
20941 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20943 * typemanager.cs (TypeManager.ChangeType): Previously known as
20944 Enum.ChangeEnumType().
20946 2002-06-09 Martin Baulig <martin@gnome.org>
20948 * expression.cs (Cast.TryReduce): Added support for consts.
20950 2002-06-08 Ravi Pratap <ravi@ximian.com>
20952 * class.cs (Accessor): Hold attributes information so we can pass
20955 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20956 Modify to pass in attributes attached to the methods.
20958 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20960 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20961 to handle the Accessor kind :-)
20963 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20965 2002-06-08 Martin Baulig <martin@gnome.org>
20967 * expression.cs (Unary.TryReduceNegative): Added support for
20970 2002-06-08 Martin Baulig <martin@gnome.org>
20972 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20973 name can't be found in the `defined_names' - the caller will do a
20974 MemberLookup in this case and thus find methods in System.Enum
20975 such as Enum.IsDefined().
20977 2002-06-08 Martin Baulig <martin@gnome.org>
20979 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20980 Convert.ChangeType() which works with TypeBuilder created types.
20981 (Enum.LookupEnumValue, Enum.Define): Use it here.
20983 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20984 `TypeBuilder.BaseType != null' check.
20985 (TypeContainer.FindMembers): Only lookup parent members if we
20986 actually have a parent.
20987 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20988 (ConstructorInitializer.Resolve): Likewise.
20990 * interface.cs (Interface.FindMembers): Added
20991 `TypeBuilder.BaseType != null' check.
20993 * rootcontext.cs (RootContext.ResolveCore): Added
20994 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20995 classes_second_stage.
20997 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20998 debug_type and trace_type when compiling with --nostdlib.
21000 2002-06-07 Martin Baulig <martin@gnome.org>
21002 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21003 (AddField): Set it to true when adding a non-static field.
21004 (DefineType): Use `have_nonstatic_fields' to find out whether we
21005 have non-static fields, not `Fields != null'.
21007 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21009 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21010 dereferencing a null on the static-field code path)
21012 2002-05-30 Martin Baulig <martin@gnome.org>
21014 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21015 to take command line arguments. Use reflection to call the new
21016 custom `Initialize' function on the symbol writer and pass it the
21017 command line arguments.
21019 * driver.cs (--debug-args): New command line argument to pass command
21020 line arguments to the symbol writer.
21022 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21024 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21025 the target type for indexers and properties. Thanks to Joe for
21028 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21030 * typemanager.cs (MethodFlags): returns the method flags
21031 (Obsolete/ShouldIgnore) that control warning emission and whether
21032 the invocation should be made, or ignored.
21034 * expression.cs (Invocation.Emit): Remove previous hack, we should
21035 not do this on matching a base type, we should do this based on an attribute
21037 Only emit calls to System.Diagnostics.Debug and
21038 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21039 on the command line.
21041 * rootcontext.cs: Global settings for tracing and debugging.
21043 * cs-tokenizer.cs (define): New utility function to track
21044 defines. Set the global settings for TRACE and DEBUG if found.
21046 2002-05-25 Ravi Pratap <ravi@ximian.com>
21048 * interface.cs (Populate*): Pass in the TypeContainer as well as
21049 the DeclSpace as parameters so that we can create EmitContexts and
21050 then use that to apply attributes etc.
21052 (PopulateMethod, PopulateEvent, PopulateProperty)
21053 (PopulateIndexer): Apply attributes everywhere.
21055 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21058 (ApplyAttributes): Update accordingly.
21060 We now apply interface attributes for all members too.
21062 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21064 * class.cs (Indexer.Define); Correctly check if we are explicit
21065 implementation (instead of checking the Name for a ".", we
21066 directly look up if the InterfaceType was specified).
21068 Delay the creation of the PropertyBuilder.
21070 Only create the PropertyBuilder if we are not an explicit
21071 interface implementation. This means that explicit interface
21072 implementation members do not participate in regular function
21073 lookups, and hence fixes another major ambiguity problem in
21074 overload resolution (that was the visible effect).
21076 (DefineMethod): Return whether we are doing an interface
21079 * typemanager.cs: Temporary hack until we get attributes in
21080 interfaces (Ravi is working on that) and we get IndexerName
21081 support in interfaces.
21083 * interface.cs: Register the indexers as properties.
21085 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21086 warning, I have verified that this is a bug in the .NET runtime
21087 (JavaScript suffers of the same problem).
21089 * typemanager.cs (MemberLookup): When looking up members for
21090 interfaces, the parent of an interface is the implicit
21091 System.Object (so we succeed in searches of Object methods in an
21092 interface method invocation. Example: IEnumerable x; x.ToString
21095 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21097 * class.cs (Event): Events should also register if they do
21098 implement the methods that an interface requires.
21100 * typemanager.cs (MemberLookup); use the new GetInterfaces
21103 (GetInterfaces): The code used to lookup interfaces for a type is
21104 used in more than one place, factor it here.
21106 * driver.cs: Track the errors at the bottom of the file, we kept
21109 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21110 instance if the method we are calling is static!
21112 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21114 * attribute.cs (ApplyAttributes): Make this function filter out
21115 the IndexerName attribute (as that attribute in reality is never
21116 applied) and return the string constant for the IndexerName
21119 * class.cs (TypeContainer.Emit): Validate that all the indexers
21120 have the same IndexerName attribute, and if so, set the
21121 DefaultName attribute on the class.
21123 * typemanager.cs: The return value might contain other stuff (not
21124 only methods). For instance, consider a method with an "Item"
21125 property and an Item method.
21127 * class.cs: If there is a problem with the parameter types,
21130 2002-05-24 Ravi Pratap <ravi@ximian.com>
21132 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21133 looks at user defined conversion after making a call to
21134 StandardConversionExists - we need this for overload resolution.
21136 * expression.cs : Update accordingly the various method calls.
21138 This fixes 2 bugs filed against implicit user defined conversions
21140 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21142 * statement.cs: Track the result of the assignment.
21144 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21146 * expression.cs (MemberAccess): Improved error reporting for
21147 inaccessible members.
21149 2002-05-22 Martin Baulig <martin@gnome.org>
21151 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21152 itself with debugging support.
21154 2002-05-22 Martin Baulig <martin@gnome.org>
21156 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21157 Removed, this isn't needed anymore.
21159 2002-05-20 Martin Baulig <martin@gnome.org>
21161 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21162 be underlying type for an enum.
21164 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21166 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21167 that splits out the loading of just the core types.
21169 * rootcontext.cs (ResolveCore): Split the struct resolution in
21170 two, so we can load the enumeration underlying types before any
21173 * expression.cs (Is): Bandaid until we fix properly Switch (see
21174 bug #24985 for details).
21176 * typemanager.cs (ImplementsInterface): The hashtable will contain
21177 a null if there are no interfaces implemented.
21179 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21181 * cs-parser.jay (indexer_declarator): It is fine to have array
21184 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21186 * typemanager.cs: (RegisterBuilder): New function used to register
21187 TypeBuilders that implement interfaces. Since
21188 TypeBuilder.GetInterfaces (as usual) does not work with lame
21190 (AddUserType): register interfaces.
21192 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21193 dealing with TypeBuilder. Also, arrays are showing up as
21194 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21195 methods can not be invoked on them!
21197 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21198 (ImplicitReferenceConversionExists): Split out from
21199 StandardConversionExists.
21201 * expression.cs (As): We were only implementing one of the three
21202 cases for the as operator. We now implement them all.
21203 (Is): Implement the various other cases for Is as well.
21205 * typemanager.cs (CACHE): New define used to control if we want or
21206 not the FindMembers cache. Seems to have a negative impact on
21207 performance currently
21209 (MemberLookup): Nested types have full acess to
21210 enclosing type members
21212 Remove code that coped with instance/static returns for events, we
21213 now catch this in RealFindMembers.
21215 (RealFindMembers): only perform static lookup if the instance
21216 lookup did not return a type or an event.
21218 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21220 * assign.cs (CompoundAssign): We pass more semantic information
21221 now to Compound Assignments than we did before: now we have all
21222 the information at hand, and now we resolve the target *before* we
21223 do the expression expansion, which allows the "CacheValue" method
21224 to have the effect we intended (before, a [x] += 1 would generate
21225 two differen ArrayAccess expressions from the ElementAccess,
21226 during the resolution process).
21228 (CompoundAssign.DoResolve): Resolve target and original_source here.
21230 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21232 * expression.cs (ArrayAccess): dropped debugging information.
21234 * typemanager.cs: Small bug fix: I was always returning i_members,
21235 instead of one of i_members or s_members (depending on which had
21238 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21239 method is invoked before any code generation takes place, and it
21240 is a mechanism to inform that the expression will be invoked more
21241 than once, and that the method should use temporary values to
21242 avoid having side effects
21244 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21246 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21249 * expression.cs (Indirection, ArrayAccess): Add support for
21250 CacheTemporaries in these two bad boys.
21252 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21253 ldobj or ldind_ref.
21254 (StoreFromPtr): Handle stobj as well.
21256 * expression.cs (UnaryMutator): Share more code.
21258 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21259 down: I was not tracking the Filter function as well, which
21260 was affecting the results of the cache.
21262 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21264 * attribute.cs: Remove the hack to handle the CharSet property on
21267 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21269 * attribute.cs (DoResolve): More uglyness, we now only try to
21270 resolve the attribute partially, to extract the CharSet
21271 information (only if we are a StructLayout attribute). Otherwise
21273 (GetExtraTypeInfo): Add some code to conditionally kill in the
21274 future this. I am more and more convinced that the .NET
21275 framework has special code to handle the attribute setting on
21278 * expression.cs (IsParamsMethodApplicable): Revert my previous
21279 foreach change here, it was wrong.
21281 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21283 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21284 (pp_expr): do not abort on unknown input, just return.
21285 (eval): abort if there are pending chars.
21287 * attribute.cs (Attribute.Resolve): Positional parameters are
21288 optional. Deal with that case.
21290 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21291 the Ansi/Unicode/Auto information for the type.
21293 (TypeContainer.DefineType): instantiate the EmitContext here, as
21294 we will be using it during the type definition (to resolve
21295 attributes) and during the emit phase.
21297 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21298 to pull type information out of the attributes
21300 (Attribute.Resolve): track the constructor builder, and allow for
21301 multiple invocations (structs and classes will use this).
21303 * ecore.cs (MemberLookupFinal): new version with all the
21304 parameters customizable.
21306 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21307 constructors. Return if the result value is null (as the error
21308 would have been flagged already by MemberLookupFinal)
21310 Do not allow instances of abstract classes or interfaces to be
21313 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21314 We have to compare the assembly property here when dealing with
21315 FamANDAssem and Assembly access modifiers, because we might be
21316 creating an assembly from *modules* (that means that we are not
21317 getting TypeBuilders for types defined in other modules that are
21318 part of this assembly).
21320 (Method.Emit): If the method is marked abstract and has a body,
21323 (TypeContainer.DefineMembers): If both the defined member and the
21324 parent name match are methods, then do not emit any warnings: let
21325 the Method.Define routine take care of flagging warnings. But if
21326 there is a mismatch (method overrides something else, or method is
21327 overriwritten by something, then emit warning).
21329 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21330 set to null, this means `do not check for the return type on the
21333 (Method.Define): set the return type for the method signature to
21334 null, so that we get methods with the same name and parameters and
21335 different return types. This is used to flag warning 114 (you are
21336 hiding a method, and you probably want to use the new/override
21339 * typemanager.cs (MemberLookup): Implemented proper access
21340 control, closing a long standing set of bug reports. The problem
21341 was that the Framework only has two bits: Public and NonPublic,
21342 and NonPublic includes private and protected methods, but we need
21343 to enforce the FamANDAssem, FamOrAssem and Family.
21345 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21347 * statement.cs (GotoCase): Return true: Ammounts to giving up
21348 knowledge on whether we return or not, and letting the other case
21349 be responsible for it.
21351 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21353 * driver.cs: Do not load directories for each file processed, only
21354 do it if there is a pattern.
21356 * ecore.cs: Report readonly assigns here as well, as we might have
21357 been resolved only by MemberAccess.
21359 (SimpleName.SimpleNameResolve): Also be useful for LValue
21360 resolution. We need this to propagate assign to local readonly variables
21362 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21363 do not want to reuse potential criteria memory.
21365 * class.cs (MyEventBuilder): Set reflected_type;
21367 * ecore.cs (Constantify): Added support for constifying bools.
21369 (RootContext.LookupType): Added a cache for values looked up in
21370 the declaration space.
21372 * typemanager.cs (FindMembers): Now is a front-end to
21373 RealFindMembers, and provides a two-level hashtable-based cache to
21376 15% performance improvement: from 22.5 to 19.2 seconds.
21378 * expression.cs (IsParamsMethodApplicable): use foreach.
21379 (Invocation.DoResolve): ditto.
21380 (New.DoResolve): ditto.
21381 (ArrayCreation.DoResolve): ditto.
21383 * ecore.cs (FindMostEncompassingType): use foreach.
21385 * delegate.cs (NewDelegate.DoResolve): Use foreach
21387 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21388 (RemoveMethods): use foreach.
21390 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21391 nested foreach statements instead of for, and also break out of
21392 the inner loop once a match is found.
21394 (Invocation.OverloadResolve): Use foreach, simplify the code.
21396 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21398 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21399 we actually unwrap the expression to allow for extra information
21402 * expression.cs: Use Shr_Un on unsigned operations.
21404 2002-05-08 Ravi Pratap <ravi@ximian.com>
21406 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21407 applicable operators was not being considered correctly. This closes
21408 the bug Miguel reported.
21410 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21412 * attribute.cs: check that the type derives from System.Attribute
21413 and report the correct error in that case (moved the duplicate code to
21414 its own method, too).
21416 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21418 * attribute.cs: lookup attribute type name as the spec says: first the
21419 bare attribute name and then name + "Attribute" (nant compiles with
21420 mcs after this fix).
21422 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21424 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21425 Because of the way we parse things, we should try to see if a
21426 UIntConstant can fit in an integer.
21428 2002-05-07 Ravi Pratap <ravi@ximian.com>
21430 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21431 when we are in an explicit context.
21433 (ConvertReferenceExplicit): When converting from Iface type S to Class
21434 T make sure the rules are implemented as an OR.
21436 * parameter.cs (ParameterType): Make it a property for now although the
21437 purpose really isn't anything immediate.
21439 * expression.cs (Is*Applicable): Do better checking on the parameter type
21440 of a ref/out parameter. The ones from the system assemblies are already
21441 marked with the correct type so we don't need to do any correction.
21443 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21444 the object type is standard too so include that.
21446 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21448 * ecore.cs (StandardConversionExists): Augment with missing code:
21449 deal with IntConstant, LongConstants and Enumerations.
21451 * assign.cs: Report the error, instead of failing silently
21453 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21454 typecontainer that they are declared, because the
21455 typecontainer/namespace will have the list of using clauses that
21456 need to be applied.
21458 Assembly Attributes were escaping the normal registration
21461 (EmitCode): Apply attributes within an EmitContext that represents
21462 the container they were declared on.
21464 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21466 2002-05-06 Ravi Pratap <ravi@ximian.com>
21468 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21469 Revamp completely - make much cleaner as we now operate only
21472 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21473 to implement the logic detailed in the spec more correctly.
21475 (UserDefinedConversion): Update accordingly.
21477 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21479 * statement.cs: Return flow analysis information up.
21481 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21484 (token): Do not consume an extra character before calling
21487 2002-05-06 Piers Haken <piersh@friskit.com>
21489 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21491 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21493 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21494 EmitContext during the instance constructor initializer
21495 resolution, to stop access to instance variables.
21497 This is mandated by the spec, last paragraph of the `constructor
21498 initializers' section.
21500 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21502 * cs-parser.jay, class.cs (Accessor): new class used to represent
21503 an accessor (get or set). In the past we used `null' to represent
21504 a missing accessor. But this is ambiguous because there was no
21505 way to tell in abstract indexers/properties if one of them was
21508 Now there is a way of addressing that.
21510 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21511 instead of FindMembers.
21513 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21514 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21516 * attribute.cs: Treat indexers and properties as the same in terms
21517 of applying attributes
21519 * ecore.cs (FindMostEncompassedType): Use statically initialized
21520 EmptyExpressions()s like we do elsewhere to avoid creating useless
21521 objects (and we take this out of the tight loop).
21523 (GetConversionOperators): Move the code to extract the actual
21524 operators to a separate routine to clean things up.
21526 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21528 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21529 events are always registered FieldBuilders.
21531 * class.cs (FieldBase): New class shared by Fields
21533 * delegate.cs: If we are a toplevel delegate, use our full name.
21534 If we are a nested delegate, then only use our tail name.
21536 2002-05-02 Ravi Pratap <ravi@ximian.com>
21538 * expression.cs (IsApplicable): Ensure that we add the "&" to
21539 ref/out types before comparing it with the type of the argument.
21541 (IsParamsMethodApplicable): Ditto.
21543 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21546 * delegate.cs : Handle the case when we have more than one applicable
21547 method. Flag an error only when we finish checking all.
21549 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21551 * expression.cs: Add support for boolean static initializers.
21553 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21555 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21557 * parameter.cs (ComputeParameterTypes,
21558 ComputeAndDefineParameterTypes): Better error handling: now we
21559 clear the `types' cache if we fail during any of the type lookups.
21560 We also return the status code correctly to our caller
21562 * delegate.cs: If we fail to define a delegate, abort the extra
21565 * expression.cs (Binary.ResolveOperator): for
21566 operator==(object,object) and operator !=(object, object) we also
21567 have to verify that there is an implicit conversion from one to
21570 (ArrayAccess.DoResolve): Array Access can operate on
21573 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21575 * assign.cs (CompoundAssign): A new class used as a "flag" that
21576 the assignment actually is happening as part of a compound
21577 assignment operator.
21579 During compound assignment, a few new rules exist to enable things
21586 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21587 to the type of x) if y is implicitly convertible to the type of x,
21588 and the operator is a builtin operator and the return type of the
21589 operator is explicitly convertible to the type of x.
21591 * rootcontext.cs: Reset warning level to 2. 4 catches various
21592 "interesting" features in mcs, we must clean this up at some
21593 point, but currently am trying to kill other bugs ;-)
21595 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21596 in container classes as well.
21598 * expression.cs (Binary.ResolveOperator): Handle string case
21599 before anything else (as operator overloading does emit an error
21600 before doing anything else).
21602 This code could go away when we move to a table driven model, but
21603 i could not come up with a good plan last night.
21605 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21607 * typemanager.cs (CSharpName): reimplementation using regex.
21608 * class.cs: added null check for fields in Emit
21609 * rootcontext.cs: set warninglevel to 4
21611 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21613 * typemanager.cs (CSharpName): reimplemented with Lupus
21616 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21618 * statement.cs (If): correclty implement Resolve, because we were
21619 not catching sem errors in there. The same process is needed
21621 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21624 (Statement.Warning_DeadCodeFound): Factorize code.
21625 (While): Report dead code here too.
21627 (Statement): Added Resolve virtual method to allow
21628 for resolution split from the emit code.
21630 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21632 * statement.cs (EmitBoolExpression): No longer try to resolve the
21634 (MakeBoolean): New utility function that resolve, implicitly
21635 converts to boolean and tags the expression.
21638 (If, Do): Implement dead code elimination.
21639 (While): Implement loop inversion
21641 (Do, While, For, If): Resolve the expression prior to calling our
21644 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21647 - added method Report28 (warning: program has more than one entry point)
21648 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21649 - modified method Method.Define, the part at the end of the method
21651 * rootcontext.cs: added static public Location EntryPointLocation;
21653 * ../errors/cs0028.cs : Add test case for the above warning.
21656 - modified method CSharpName to allow arrays of primitive type to
21657 be printed nicely (e.g. instead of System.Int32[][] it now prints
21659 - added method CSharpSignature: returns the signature of a method
21660 in string format to be used in reporting errors, warnings, etc.
21662 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21665 2002-04-26 Ravi Pratap <ravi@ximian.com>
21667 * delegate.cs (Define): Fix extremely silly bug where I was
21668 setting the type of the 'object' parameter of the BeginInvoke
21669 method to System.IAsyncResult instead of System.Object ;-)
21671 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21673 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21676 (Constructor.Emit): return if we fail to initialize the
21677 constructor. Another door closed!
21679 * expression.cs (New.DoResolve): Improve error message (from -6 to
21680 1501). Use DeclaredOnly lookup to find the exact constructor.
21682 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21683 loop. This is useful.
21685 * cs-parser.jay: Adjust the default parameters so that destructors
21686 have the proper signature.
21688 2002-04-26 Martin Baulig <martin@gnome.org>
21690 * driver.cs (LoadAssembly): If `assembly' contains any characters
21691 which are only valid in path names and not in assembly names
21692 (currently slash, backslash and point), use Assembly.LoadFrom ()
21693 instead of Assembly.Load () on the `assembly' (before iteration
21694 over the link_paths).
21696 2002-04-26 Martin Baulig <martin@gnome.org>
21698 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21700 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21702 * class.cs (Property): use the new typemanager.MemberLookup
21704 (TypeContainer.MemberLookup): Implement using the
21705 TypeManager.MemberLookup now.
21707 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21708 and return MemberInfos, so that these can be used without an
21709 EmitContext (what we had before).
21711 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21713 * expression.cs: Fix the case where the argument to params if the
21714 type of the params. I omitted handling this before. Fixed
21716 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21718 * driver.cs: Call BootCorlib_PopulateCoreType
21720 * class.cs (Property.CheckBase): Check for properties only, not
21723 * interface.cs: Temporary hack: try/catch around the
21724 CustomAttributeBuilder, because I am getting an exception that I
21727 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21728 types whose definitions are required to be there (attributes are
21729 defined before standard types).
21731 Compute definitions as we boot the various types, as they are used
21732 immediately (value_type class will need object_type, but if we do
21733 not initialize object_type, we will pass a null, which will let
21734 the runtime pick the System.Object from the existing corlib, which
21735 is not what we want).
21737 2002-04-22 Patrik Torstensson <totte@labs2.com>
21739 * cs-tokenizer.cs: fixed a number of trim() issues.
21741 2002-04-22 Ravi Pratap <ravi@ximian.com>
21743 * expression.cs (Argument.Type): Ensure that we return the correct
21744 type when we have out or ref parameters [in which case we
21747 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21749 * class.cs (Property, Indexer): Allow extern modifier in there.
21751 * typemanager.cs (InitBaseTypes): Initializes object_type and
21752 value_type, since those will be used early on during the bootstrap
21753 process to compile corlib.
21755 (InitCoreTypes): Move code from here to InitBaseTypes.
21757 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21759 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21760 single-dimension arrays as using the ldlen opcode.
21762 Daniel Lewis discovered this optimization.
21764 * typemanager.cs: Add signature for System.Array::get_Length
21766 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21768 * statement.cs: report the error when the foreach does not apply to an
21769 array nor a collection.
21771 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21773 * expression.cs: Add implicit conversions to the operator ~.
21775 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21777 * typemanager.cs: Locate the decimal constructor.
21779 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21781 * attribute.cs: use the new property of TypeOf.
21782 * expression.cs: added 'get' property around typearg.
21784 These changes fix a build breaker reported by NickD. Is this the
21785 correct way to fix? If not, please, revert my changes and make it
21788 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21790 * attribute.cs: Add support for typeof in attribute invocations.
21791 I am not sure that this is right though.
21793 2002-04-14 Duncan Mak <duncan@ximian.com>
21795 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21796 Binary.Operator.Division case.
21798 2002-04-13 Ravi Pratap <ravi@ximian.com>
21800 * class.cs (DefineType): Ensure that we do a proper check on
21801 attribute types and also register it with the TypeManager.
21803 (TypeContainer.Targets): The default for attribute types is
21804 AttributeTargets.All.
21806 * attribute.cs (ApplyAttributes): Registering the attribute type
21807 is done elsewhere, not when we discover we have a Usage attribute.
21809 2002-04-12 Ravi Pratap <ravi@ximian.com>
21811 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21812 and get rid of is_delegate parameter.
21814 * everywhere : update.
21816 2002-04-12 Ravi Pratap <ravi@ximian.com>
21818 * cs-parser.jay (compilation_unit): Revamp completely to use
21819 some new ideas that I got from Rhys' grammar to solve the problems
21820 with assembly level attributes.
21822 (outer_declaration): New grammar production.
21824 (attribute_sections): Add.
21826 (opt_attributes): Base on attribute_sections
21828 (namespace_declaration): Allow opt_attributes to tackle the case
21829 when we have assembly level attributes - we are clever in this
21832 * attribute.cs (ApplyAttributes): Do not worry about assembly
21833 attributes in the non-global context.
21835 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21836 instead of SetGlobalAttributes.
21838 * class.cs, rootcontext.cs : Ensure we define and generate
21839 attribute types before anything else.
21841 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21842 and flag the new error -20 for the case when the attribute type
21843 does not have valid targets specified. csc does not catch this.
21845 * ../errors/errors.txt : update for error # -20
21847 2002-04-11 Ravi Pratap <ravi@ximian.com>
21849 * support.cs (InternalParameters.ParameterModifier): Do some null
21850 checking and return sane values.
21852 * class.cs (Method.Define): If we are a PInvoke method, ensure
21853 that we are static and extern. Report error # 601
21855 * ../errors/cs0601.cs : Add test case for the above error.
21857 2002-04-07 Ravi Pratap <ravi@ximian.com>
21859 * rootcontext.cs (attribute_types): We need to keep type of
21860 all attribute types separately and emit code for them first.
21862 (RegisterAttribute) : Implement.
21864 * class.cs (DefineType): Check if the current Type is a custom
21865 attribute type and register it accordingly.
21867 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21868 adding the first attribute twice and rename to
21870 (SetGlobalAttributes): this.
21872 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21875 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21876 if we are processing global arguments. Hmm, I am unsure of this.
21878 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21880 * expression.cs: added static array of strings to avoid calling
21881 Enum.ToString () for Operator in Binary. Significant recover of
21884 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21886 * class.cs (FindMembers): Allow the Builders of the various
21887 members to be null. If they are skip them. This only happens
21888 during the PInvoke declaration.
21890 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21892 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21893 failure, so we do not keep going afterwards.
21895 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21896 wanted to pass `false' as the `is_delegate' argument. If this is
21897 the case, why not use delegate_type == null to mean `is_delegate =
21898 false' and anything else as is_delegate = true.
21900 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21902 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21903 code for the section, not the beginning of the tests.
21905 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21907 * cfold.cs: Handle operator + (Enum x, Underlying x)
21909 * expression.cs (Binary): same. Warn about errors where we have
21910 Enum/Enum in operator + as well.
21912 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21915 - added support for switch(bool)
21916 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21917 - add TableSwitchEmit() to handle table-based switch statements
21919 2002-04-05 Ravi Pratap <ravi@ximian.com>
21921 * expression.cs (Invocation.OverloadResolve): Factor out code which
21922 does parameter compatibility checking with arguments so that we can
21923 re-use the code even from Delegate.VerifyApplicability
21925 (VerifyArgumentsCompat): Move above code here.
21927 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21928 and instead make a call to the above method.
21930 2002-03-31 Ravi Pratap <ravi@ximian.com>
21932 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21933 We use it to keep track of classes which are attribute types.
21935 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21937 * delegate.cs (Delegate.Define): Correctly define the types in the
21938 presence of fixed and array parameters.
21940 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21943 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21944 include NonPublic after the first iteration.
21946 * class.cs (Indexer.CheckBase): Only check if both parents are
21949 * cs-parser.jay (accessor_body): If empty, set to null.
21951 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21952 same code path here to resolve constants names that we did have in
21953 MemberAccess.DoResolve. There is too much code duplicated here.
21955 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21957 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21959 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21962 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21963 tokens, numbers and strings.
21965 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21968 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21969 asyncronous parameters and the regular parameters.
21971 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21972 specify the target directory.
21974 * expression.cs: (This.DoResolve): Simplify
21975 (As.Emit): Optimize, do not generate IsInst if the expression is
21976 always of the given type.
21978 (Is.DoResolve): Bug fix, we were reporting both always/never for
21981 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21982 creating too many unnecessary arrays.
21984 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21986 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21987 fields instead of rolling our own initializer. Takes care of all
21988 implicit conversions, and drops unnecessary static checks/argument.
21990 2002-03-31 Dick Porter <dick@ximian.com>
21992 * driver.cs: use the GetDirectories() return values properly, and
21993 use "/" as path separator.
21995 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21997 * expression.cs (Unary): Optimize - - expr into expr.
21998 (Binary): Optimize a + (-b) into a -b.
22000 * codegen.cs (CodeGen): Made all methods static.
22002 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22006 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22007 TypeBuilder property.
22009 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22012 * tree.cs: Removed the various RecordXXXX, and replaced with a
22013 single RecordDecl. Removed all the accessor methods, and just
22014 left a single access point Type
22016 * enum.cs: Rename DefineEnum to DefineType.
22018 * decl.cs: New abstract method `DefineType' used to unify the
22019 Defines for Enumerations, Interfaces, TypeContainers and
22022 (FindType): Moved LookupInterfaceOrClass here. Moved the
22023 LookupBaseClasses method that used to live in class.cs and
22024 interface.cs here, and renamed to FindType.
22026 * delegate.cs: Implement DefineType. Take advantage of the
22027 refactored pattern for locating the parent builder without taking
22028 the parent_builder argument (which we know does not work if we are
22029 nested, and triggering a toplevel definition).
22031 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22033 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22034 accessibility of a member has changed during override and report
22037 * class.cs (Method.Define, Property.Define): Only complain on
22038 overrides if the method is private, any other accessibility is
22039 fine (and since we just checked the permission is the same, we are
22042 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22043 and elif are processed always. The other pre-processing
22044 directives are only processed if we are "taking" the path
22046 2002-03-29 Martin Baulig <martin@gnome.org>
22048 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22049 current location is not Null.
22051 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22052 a separate method so we can profile it.
22054 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22055 `span.Seconds' are just seconds, but no minutes or hours.
22056 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22058 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22060 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22061 Remove the gratuitous set of Final:
22063 // If an interface implementation, then we can set Final.
22064 if (((flags & MethodAttributes.Abstract) == 0) &&
22065 implementing.DeclaringType.IsInterface)
22066 flags |= MethodAttributes.Final;
22068 I do not know what I was smoking when I used that.
22071 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22072 step into fixing the name resolution issues for delegates and
22073 unifying the toplevel name resolution.
22075 2002-03-28 Martin Baulig <martin@gnome.org>
22077 * class.cs (Method.Emit): If we have a symbol writer, call its
22078 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22079 tell it about the current method.
22081 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22082 writer that we're going to emit the first byte of IL code for a new
22083 statement (a new source line).
22084 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22085 EmitContext.Mark() before emitting any code.
22087 * location.cs (SymbolDocument): Return null when we're Null.
22089 * statement.cs (Statement): Moved the `Location loc' variable here.
22090 (Statement.EmitBoolExpression): If we have a symbol writer, call
22091 ec.Mark() before emitting any code to tell it that we're at the
22092 beginning of a new statement.
22093 (StatementExpression): Added `Location' argument to the constructor.
22094 (Block): Added public readonly variable `StartLocation' and public
22095 variable `EndLocation'. The latter is to be set using SetEndLocation().
22096 (Block): Added constructor which takes a start and end location.
22097 (Block.SetEndLocation): New method. This sets the end location.
22098 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22099 local variables we create.
22100 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22101 each statement and do also mark the begin and end of the block.
22103 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22104 tell it the current lexer.Location, use Location.Null for the end of the
22106 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22107 current block, set its end location using SetEndLocation().
22108 (statement_expression): StatementExpression constructor now takes the
22109 lexer.Location as additional argument.
22110 (for_statement, declare_local_variables): Likewise.
22111 (declare_local_variables): When creating a new implicit block, use the
22112 new Block constructor and pass it the lexer.Location.
22114 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22116 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22117 members also on the parent interfaces recursively.
22119 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22121 * report.cs: Use new formats, since Gonzalo finished the missing
22124 * expression.cs (Binary.ResolveOperator): added missing operator|
22125 operator& and operator^ for bool/bool.
22127 * cs-parser.jay: CheckDef now takes a Location argument that is
22128 used to report errors more precisly (instead of reporting the end
22129 of a definition, we try to track something which is a lot closer
22130 to the source of the problem).
22132 * cs-tokenizer.cs: Track global token use, so we can properly flag
22133 the use of #define/#undef after the first token has been seen.
22135 Also, rename the reportXXXX to Error_DescriptiveName
22137 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22138 TypeContainer, so that Enum and Interface can use this too.
22140 * class.cs (TypeContainer.LookupInterfaceOrClass,
22141 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22142 `builder' argument. Typically this was used to pass the parent
22143 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22146 The problem is that a nested class could trigger the definition of
22147 a toplevel class, and the builder would be obviously wrong in that
22150 So we drop this argument, and we compute dynamically the
22151 TypeBuilder/ModuleBuilder (the correct information was available
22152 to us anyways from DeclSpace.Parent)
22154 * interface.cs (Interface.DefineInterface): Drop builder
22155 parameter cleanup like class.cs
22157 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22160 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22163 (Try.Emit): Propagate the returns value from the statement.
22165 (Return.Emit): Even if we are leavning
22167 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22169 * modifiers.cs: Fix the computation of MethodAttributes flags.
22171 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22173 * driver.cs: allow compilation of files that start with '/'.
22174 Add a default case when checking the argument of --target.
22176 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22178 * interface.cs: Implement the same search algorithm for types in
22179 the interface code.
22181 * delegate.cs: Do not allow multiple definition.
22183 * Recovered ChangeLog that got accidentally amputated
22185 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22187 * rootcontext.cs: Load manually enum to allow core classes to
22188 contain enumerations.
22190 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22191 Update to new static methods in TypeManager.
22193 * typemanager.cs (GetMethod, GetConstructor): Use our
22194 implementation of FindMembers to find the members, since during
22195 corlib compilation, the types are TypeBuilders and GetMethod and
22196 GetConstructor do not work.
22198 Make all methods in TypeManager static.
22200 (InitCodeHelpers): Split the functionality from
22201 the InitCodeTypes function.
22203 * driver.cs: Call InitCodeHelpers after we have populated the
22206 * cs-parser.jay (delegate_declaration): we did not used to compute
22207 the delegate name correctly for void delegates.
22209 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22211 * rootcontext.cs (RootContext): Init the interface_resolve_order
22212 and type_container_resolve_order always.
22214 (ResolveCore, BootstrapCorlib_ResolveClass,
22215 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22216 compiler when compiling with --nostdlib
22218 * class.cs (TypeContainer.DefineType): Check that our parent is
22219 not null. This test is most important when we are bootstraping
22222 * codegen.cs: Split out the symbol writing code.
22224 2002-03-25 Martin Baulig <martin@gnome.org>
22226 * driver.cs (-g): Made -g an alias for --debug.
22228 2002-03-24 Martin Baulig <martin@gnome.org>
22230 * codegen.cs (SymbolWriter): New public variable. Returns the
22231 current symbol writer.
22232 (CodeGen): Added `bool want_debugging_support' argument to the
22233 constructor. If true, tell the ModuleBuild that we want debugging
22234 support and ask it for the ISymbolWriter.
22235 (Save): If we have a symbol writer, call it's Close() method after
22236 saving the assembly.
22238 * driver.c (--debug): New command line argument to create a
22239 debugger information file.
22241 * location.cs (SymbolDocument): New public property. Returns an
22242 ISymbolDocumentWriter object for the current source file or null
22243 if we don't have a symbol writer.
22245 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22247 * driver.cs (LoadAssembly): Correctly return when all the paths
22248 have been tried and not before.
22250 * statement.cs (Switch.Emit): return the actual coverage for this
22251 statement (returns/not-returns)
22253 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22254 switch of the statement if we are the last switch section. That
22255 kills two problems: try/catch problems (we used to emit an empty
22256 nop at the end) and switch statements where all branches would
22259 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22261 * driver.cs: Add default assemblies (the equivalent to the
22262 Microsoft CSC.RSP file)
22264 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22265 also update tokens_seen and set it to false.
22267 * driver.cs: Implement --recurse for Mike.
22269 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22270 correctly splitting out the paths.
22272 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22274 * interface.cs (Interface.PopulateProperty): Instead of using
22275 `parent' as the declaration space for the set parameters, use
22278 * support.cs (InternalParameters): InternalParameters constructor
22279 takes a DeclSpace instead of a TypeContainer.
22281 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22282 types are being initialized, load the address of it before calling
22285 (New): Provide a mechanism to disable the generation of local
22286 value type temporaries when the caller will be providing us with
22287 an address to store it.
22289 (ArrayCreation.EmitDynamicInitializers): Use it.
22291 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22293 * expression.cs (Invocation.EmitArguments): Only probe for array
22294 property if there is more than one argument. Sorry about that.
22296 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22297 empty param arrays.
22299 * class.cs (Method.LabelParameters): Fix incorrect code path that
22300 prevented the `ParamArrayAttribute' from being applied to the
22303 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22305 * support.cs (ReflectionParameters): Correctly compute whether the
22306 last argument is a params array. Fixes the problem with
22309 * typemanager.cs: Make the assemblies array always be non-null
22310 (empty, but non-null)
22312 * tree.cs (RecordDecl): New function that abstracts the recording
22313 of names. This reports error 101, and provides a pointer to the
22314 previous declaration. Fixes a crash in the compiler.
22316 * cs-parser.jay (constructor_declaration): Update to new grammar,
22317 and provide a constructor_body that can be empty.
22319 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22321 * driver.cs: Add support for --resources.
22323 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22324 Make all types for the various array helper methods be integer.
22326 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22327 CheckState to ConvCast.
22329 (ConvCast): Now it takes a `checked' state argument, to avoid
22330 depending on the emit context for the conversion, and just using
22331 the resolve time setting.
22333 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22334 instead of Invocation.EmitArguments. We do not emit the original
22335 arguments, instead we emit those which have been converted to
22336 unsigned int expressions.
22338 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22340 * codegen.cs: ditto.
22342 * expression.cs (LocalVariableReference): Drop the use of the
22343 Store function that depended on the variable index.
22345 * statement.cs (VariableInfo): Drop the `Idx' property from this
22346 class, as this is not taking into account the indexes for
22347 temporaries tat we generate during the execution, getting the
22350 * class.cs: First emit class initializers, then call the parent
22353 * expression.cs (Binary): Fix opcode emision.
22354 (UnaryMutator.EmitCode): Support checked code generation
22356 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22357 matches for events for both the Static and Instance scans,
22358 pointing to the same element. Fix that.
22360 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22362 * rootcontext.cs (ResolveTree): Always set the
22363 interface_resolve_order, because nested interfaces will be calling
22366 * class.cs (GetInterfaceOrClass): Track the same resolution
22367 process used by TypeManager.LookupType. This fixes the nested
22368 type lookups in class declarations (separate path from
22371 (TypeContainer.DefineType): Also define nested interfaces.
22372 (TypeContainer.RegisterOrder): New public function used to
22373 register the order in which child interfaces need to be closed.
22375 Nested interfaces need to be closed after their parents have been
22378 * interface.cs (InterfaceAttr): Put all the logic for computing
22379 the interface attribute here.
22381 (DefineInterface): Register our interface order with the
22382 RootContext or with the TypeContainer depending on the case.
22384 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22386 * cs-parser.jay: rework foreach statement to work with the new
22387 changes to the policy on SimpleNames.
22389 * report.cs: support Stacktrace on warnings as well.
22391 * makefile: drop --unsafe and /unsafe from the compile.
22393 2002-03-13 Ravi Pratap <ravi@ximian.com>
22395 * ecore.cs (StandardConversionExists): Modify to take an Expression
22396 as the first parameter. Ensure we do null -> reference type conversion
22399 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22400 temporary Expression objects.
22402 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22404 * interface.cs: workaround bug in method overloading resolution
22405 (there is already a bugzilla bug for it).
22407 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22409 We could also solve this problem by having a separate path for
22410 performing type lookups, instead of DoResolve, we could have a
22411 ResolveType entry point, and only participating pieces of the
22412 production (simplename, deref, array) would implement this.
22414 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22415 signal SimpleName to only resolve type names and not attempt to
22416 resolve anything else.
22418 * expression.cs (Cast): Set the flag.
22420 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22422 * class.cs: Only report 108 if there is no `new' modifier.
22424 * cs-parser.jay: rework foreach statement to work with the new
22425 changes to the policy on SimpleNames.
22427 * report.cs: support Stacktrace on warnings as well.
22429 * makefile: drop --unsafe and /unsafe from the compile.
22431 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22433 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22434 lookups here, instead of doing that at parse time. This means
22435 that our grammar will not introduce `LocalVariableReferences' as
22436 expressions at this point. That solves the problem of code like
22440 static void Main ()
22444 This is only half the fix. The full fix requires parameters to
22445 also be handled in this way.
22447 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22448 makes the use more obvious of the DeclSpace. The
22449 ec.TypeContainer.TypeBuilder is now only used to pull the
22450 TypeBuilder for it.
22452 My theory is that I can get rid of the TypeBuilder completely from
22453 the EmitContext, and have typecasts where it is used (from
22454 DeclSpace to where it matters).
22456 The only pending problem is that the code that implements Aliases
22457 is on TypeContainer, and probably should go in DeclSpace.
22459 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22460 lookups here, instead of doing that at parse time. This means
22461 that our grammar will not introduce `LocalVariableReferences' as
22462 expressions at this point. That solves the problem of code like
22466 static void Main ()
22470 This is only half the fix. The full fix requires parameters to
22471 also be handled in this way.
22473 * class.cs (Property.DefineMethod): When implementing an interface
22474 method, set newslot, when implementing an abstract method, do not
22475 set the flag (before we tried never setting it, or always setting
22476 it, which is the difference).
22477 (Indexer.DefineMethod): same.
22478 (Method.DefineMethod): same.
22480 * ecore.cs: Only set the status used flag if we get back a Field.
22482 * attribute.cs: Temporary hack, so Paolo can keep working.
22484 2002-03-08 Ravi Pratap <ravi@ximian.com>
22486 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22487 the unmanaged type in the case we have a MarshalAs attribute.
22489 (Resolve): Handle the case when we are parsing the special MarshalAs
22490 attribute [we need to store the unmanaged type to use later]
22492 * typemanager.cs (marshal_as_attr_type): Built in type for the
22493 MarshalAs Attribute.
22495 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22496 on parameters and accordingly set the marshalling info.
22498 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22500 * class.cs: Optimizing slightly by removing redundant code after
22501 we switched to the `NoTypes' return value.
22502 (Property.DefineMethod): use NoTypes here too.
22504 This fixes the bug I introduced in my last batch of changes.
22506 2002-03-05 Ravi Pratap <ravi@ximian.com>
22508 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22510 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22511 Enums since those are types too.
22513 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22515 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22516 thanks to a call during the lookup process.
22518 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22520 * statement.cs (Foreach): Lots of work to accomodate a particular
22521 kind of foreach statement that I had not kept in mind. It is
22522 possible to have foreachs on classes that provide a GetEnumerator
22523 method that return objects that implement the "pattern" for using
22524 a foreach, there is no need to support GetEnumerator
22527 This is needed to compile nant.
22529 * decl.cs: Only report 114 if the member is not `Finalize' and if
22530 the warning level is at least 2.
22532 * class.cs: Moved the compare function from Method to
22535 (MethodSignature.InheritableMemberSignatureCompare): Add new
22536 filter function that is used to extract inheritable methods from a
22539 (Method.Define): Use the new `inheritable_method_signature_filter'
22542 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22545 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22547 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22549 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22551 * expression.cs: Pass location information to
22552 ConvertImplicitStandard.
22554 * class.cs: Added debugging code to track return values from
22557 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22559 * expression.cs (Is.DoResolve): If either side of the `is' is an
22560 interface, do not flag the warning.
22562 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22565 * report.cs: Allow for --fatal to be used with --probe.
22567 * typemanager.cs (NoTypes): Move the definition for the empty Type
22570 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22572 (TypeContainer.DefineProxy): New function used to proxy to parent
22573 implementations when implementing interfaces.
22574 (TypeContainer.ParentImplements): used to lookup if our parent
22575 implements a public function that is required by an interface.
22576 (TypeContainer.VerifyPendingMethods): Hook this up.
22578 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22579 `modules' and `assemblies' arraylists into arrays. We only grow
22580 these are the very early start up of the program, so this improves
22581 the speedof LookupType (nicely measured).
22583 * expression.cs (MakeByteBlob): Replaced unsafe code with
22584 BitConverter, as suggested by Paolo.
22586 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22587 folding of string concatenation, but if either side is a string,
22588 and the other is not, then return null, and let the runtime use
22589 the concatenation on the string plus the object (using
22590 `Object.ToString').
22592 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22594 Constant Folding has been implemented now.
22596 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22597 the error instead on types that are not supported in one's
22600 * constant.cs (Constant and all children): New set of functions to
22601 perform implict and explicit conversions.
22603 * ecore.cs (EnumConstant): Implement the new functions to perform
22604 conversion by proxying to the child expression.
22606 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22607 own separate setting that can not be turned off from the command
22608 line using --unchecked or --checked and is only controlled using
22609 the checked/unchecked statements and expressions. This setting is
22610 used by the constant folder to flag errors.
22612 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22613 ConstantCheckState as well.
22615 During Resolve, they also have to flag the state, because the
22616 constant folder runs completely in the Resolve phase.
22618 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22621 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22623 * cfold.cs: New file, this file contains the constant folder.
22625 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22626 argument to track whether we are using the resulting address to
22627 load or store a value and provide better error messages.
22629 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22630 new AddressOf arguments.
22632 * statement.cs (Foreach.EmitCollectionForeach): Update
22634 * expression.cs (Argument.Emit): Call AddressOf with proper
22635 arguments to track usage.
22637 (New.DoEmit): Call AddressOf with new arguments.
22639 (Unary.Emit): Adjust AddressOf call.
22641 2002-03-01 Ravi Pratap <ravi@ximian.com>
22643 * cs-parser.jay (member_access): Change the case for pre-defined types
22644 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22647 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22650 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22651 essentially like methods and apply attributes like MethodImplOptions to them too.
22653 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22656 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22657 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22660 * Update code everywhere accordingly.
22662 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22664 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22666 2002-02-28 Ravi Pratap <ravi@ximian.com>
22668 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22669 try performing lookups against those instead of jumping straight into using
22670 the 'using' clauses.
22672 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22674 (LookupType): Perform lookups in implicit parents too.
22676 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22677 sequence as RootContext.LookupType.
22679 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22680 the various cases of namespace lookups into this method.
22682 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22684 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22685 in positional arguments)
22687 * class.cs (Operator): Update the AllowedModifiers to contain
22690 * cs-parser.jay: Update operator declaration to allow for the
22691 operator body to be empty.
22693 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22696 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22698 * class.cs (Method.Emit): Label parameters.
22700 * driver.cs: Return 1 or 0 as the program exit code.
22702 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22704 * expression.cs: Special case the `null' object when trying to
22705 auto-compute the type, as anything can be explicitly converted to
22708 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22709 spotting this Paolo.
22711 (Expression.ImplicitNumericConversion): Perform comparissions of
22712 the type using the underlying type in the case of an enumeration
22713 rather than using the enumeration type for the compare.
22715 Cope with the underlying == type case, which is not possible to
22718 (Expression.ConvertNumericExplicit): Perform comparissions of
22719 the type using the underlying type in the case of an enumeration
22720 rather than using the enumeration type for the compare.
22722 * driver.cs: If the user does not supply an extension, assume .exe
22724 * cs-parser.jay (if_statement): Rewrote so that we can track the
22725 location for the if statement.
22727 * expression.cs (Binary.ConstantFold): Only concat strings when
22728 the operation is "+", not everything ;-)
22730 * statement.cs (Statement.EmitBoolExpression): Take a location
22732 (If, While, Do): Track location.
22734 * expression.cs (Binary.ResolveOperator): In the object + string
22735 case, I was missing a call to ConvertImplicit
22737 2002-02-25 Ravi Pratap <ravi@ximian.com>
22739 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22740 Location arguments. Ensure we use RootContext.LookupType to do our work
22741 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22743 * interface.cs (PopulateMethod): Handle the type of the parameter being
22746 * expression.cs (Invocation.BetterFunction): Handle the case when we
22747 have a params method with no fixed arguments and a call is made with no
22750 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22752 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22753 the verbatim-string-literal
22755 * support.cs (InternalParameters.ParameterModifier): handle null
22757 (InternalParameters.ParameterType): ditto.
22759 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22760 duplicating the name of the variable parameter.
22761 (GetParameterByName): Fix bug where we were not looking up array
22762 paramters if they were the only present (thanks Paolo!).
22763 (GetParameterInfo): We only have an empty set of types if both
22764 fixed and array are set to null.
22765 (GetParameterInfo-idx): Handle FixedParameter == null
22767 * cs-parser.jay: Handle the case where there is no catch
22768 statements (missing null test).
22770 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22772 * driver.cs (MainDriver): Be conservative on our command line
22775 Catch DirectoryNotFoundException when calling GetFiles.
22777 (SplitPathAndPattern): Used to split the input specification into
22778 a path and a pattern that we can feed to Directory.GetFiles.
22780 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22782 * statement.cs (Fixed): Implement the last case of the Fixed
22783 statement (string handling).
22785 * expression.cs (StringPtr): New class used to return a char * to
22786 a string; Used by the Fixed statement.
22788 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22790 * expression.cs (Binary.ResolveOperator): Remove redundant
22791 MemberLookup pn parent type.
22792 Optimize union call, we do not need a union if the types are the same.
22793 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22796 Specialize the use of MemberLookup everywhere, instead of using
22797 the default settings.
22799 (StackAlloc): Implement stackalloc keyword.
22801 * cs-parser.jay: Add rule to parse stackalloc.
22803 * driver.cs: Handle /h, /help, /?
22805 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22806 before we supported unsafe code.
22808 * makefile: add --unsafe to the self compilation of mcs.
22810 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22812 * expression.cs (PointerArithmetic): New class that is used to
22813 perform pointer arithmetic.
22814 (Binary.Resolve): Handle pointer arithmetic
22815 Handle pointer comparission.
22816 (ArrayPtr): Utility expression class that is used to take the
22817 address of an array.
22819 (ElementAccess): Implement array access for pointers
22821 * statement.cs (Fixed): Implement fixed statement for arrays, we
22822 are missing one more case before we are done.
22824 * expression.cs (Indirection): Implement EmitAssign and set the
22825 ExprClass to Variable. This allows pointer dereferences to be
22826 treated as variables, and to have values assigned to them.
22828 * ecore.cs (Expression.StoreFromPtr): New utility function to
22829 store values dereferencing.
22831 2002-02-20 Ravi Pratap <ravi@ximian.com>
22833 * expression.cs (Binary.ResolveOperator): Ensure that we are
22834 not trying to operate on a void type - this fixes the reported
22837 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22838 the parent implementation is sealed.
22840 * ../errors/cs0239.cs : Add.
22842 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22844 * typemanager.cs (unverifiable_code_type): Corresponds to
22845 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22846 which have unsafe code in them.
22848 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22851 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22853 * cs-tokenizer.cs: Add support for @"litreal strings"
22855 Make tokenizer accept pre-processor directives
22856 on any column (remove the old C-like limitation).
22858 * rootcontext.cs (EmitCode): Emit any global attributes.
22859 (AddGlobalAttributes): Used to keep track of assembly attributes.
22861 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22863 * cs-parser.jay: Add support for global attributes.
22865 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22867 * expression.cs (Indirection): New helper class. Unary will
22868 create Indirection classes to be able to implement the
22869 IMemoryLocation interface on it.
22871 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22873 * cs-parser.jay (fixed_statement): reference the right statement.
22875 * statement.cs (Fixed.Emit): Finish implementing the fixed
22876 statement for the &x case.
22878 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22880 * class.cs (Property.Define, Method.Define): Remove newslot when
22883 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22884 wrong. NewSlot should only be used if the `new' keyword is present.
22886 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22887 locating our system dir. Sorry about this.
22889 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22891 * driver.cs (GetSystemDir): Compute correctly the location of our
22892 system assemblies. I was using the compiler directory instead of
22893 the library directory.
22895 2002-02-13 Ravi Pratap <ravi@ximian.com>
22897 * expression.cs (BetterFunction): Put back in what Miguel commented out
22898 since it is the correct fix. The problem is elsewhere ;-)
22900 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22901 parameters of the parms method are themselves compatible or not !
22903 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22904 to check that a class implements an interface before saying that an implicit
22905 conversion was allowed. Use ImplementsInterface to do the checking.
22907 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22909 * class.cs (Method.Define): Track whether we are an explicit
22910 implementation or not. And only call DefineMethodOverride if we
22911 are an explicit implementation.
22913 (Property.DefineMethod): Ditto.
22915 2002-02-11 Ravi Pratap <ravi@ximian.com>
22917 * expression.cs (BetterFunction): Catch hideous bug which was
22918 preventing us from detecting ambiguous calls due to implicit casts i.e
22921 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22923 * support.cs (Pair): Remove un-needed method. I figured why I was
22924 getting the error in cs-parser.jay, the variable in a foreach loop
22925 is readonly, and the compiler does not really treat this as a variable.
22927 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22928 instead of EQUALS in grammar.
22930 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22932 * expression.cs (Unary.DoResolve): Check whether the argument is
22935 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22937 * support.cs: Api for Pair to set a value. Despite the fact that
22938 the variables are public the MS C# compiler refuses to compile
22939 code that accesses the field if the variable is part of a foreach
22942 * statement.cs (Fixed): Begin implementation of the fixed
22945 (Block.AddVariable): Return the VariableInfo on success and null
22946 on failure instead of true/false.
22948 * cs-parser.jay (foreach): Catch errors on variables already
22949 defined (we were ignoring this value before) and properly unwind
22950 the block hierarchy
22952 (fixed_statement): grammar for the fixed statement.
22954 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22956 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22957 pointer types to be incretemented.
22959 (SizeOf): Implement.
22961 * cs-parser.jay (pointer_member_access): Implement
22962 expr->IDENTIFIER production.
22964 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22965 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22968 (Unary): Implement indirection.
22970 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22971 use in non-unsafe context).
22973 (SimpleName.DoResolve): Check for pointers in field access on safe
22976 (Expression.LoadFromPtr): Factor the load-indirect code in this
22977 function. This was duplicated in UnboxCast and ParameterReference
22979 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22981 * expression.cs (ComposedCast): report an error if a pointer cast
22982 is used in a safe region.
22984 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22985 pointer type casts in unsafe context.
22987 * codegen.cs (EmitContext): Set up IsUnsafe.
22989 * cs-parser.jay (non_expression_type): Add productions for pointer
22992 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22993 code. We should not use force into static mode if the method is
22994 not virtual. Fixes bug in MIS
22996 * statement.cs (Do.Emit, While.Emit, For.Emit,
22997 Statement.EmitBoolExpression): Add support to Do and While to
22998 propagate infinite loop as `I do return' semantics.
23000 Improve the For case to also test for boolean constants.
23002 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23003 to the list of attributes we can add.
23005 Remove `EmitContext' argument.
23007 * class.cs (Method.Define): Apply parameter attributes.
23008 (Constructor.Define): Apply parameter attributes.
23009 (MethodCore.LabelParameters): Move here the core of labeling
23012 * support.cs (ReflectionParameters.ParameterModifier,
23013 InternalParameters.ParameterModifier): Use IsByRef on the type and
23014 only return the OUT bit for these parameters instead of in/out/ref
23017 This is because I miss-understood things. The ParameterInfo.IsIn
23018 and IsOut represent whether the parameter has the [In] and [Out]
23021 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23023 * ecore.cs (FieldExpr.Emit): Release temporaries.
23025 * assign.cs (LocalTemporary.Release): new function.
23027 * codegen.cs (EmitContext.GetTemporaryStorage,
23028 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23029 temporary storage. Now we can "put back" localbuilders when we
23032 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23034 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23035 need to make a copy of the variable to generate verifiable code.
23037 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23039 * driver.cs: Compute dynamically the system directory.
23041 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23042 Slower, but more generally useful. Used by the abstract
23043 registering implementation.
23045 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23046 the rules for the special rule on Type/instances. First check if
23047 we have the same name, and if so, try that special static path
23048 rather than the instance path.
23050 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23052 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23055 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23056 Enum, ValueType, Delegate or Array for non-corlib compiles.
23058 * cs-tokenizer.cs: Catch long identifiers (645)
23060 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23063 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23064 fix, we were returning too early, so we were not registering
23065 pending methods from abstract classes.
23067 Do not register pending methods if the class is abstract.
23069 * expression.cs (Conditional.DoResolve): Report circular implicit
23070 conversions when we neecd to compute it for conditional
23073 (Is.DoResolve): If the expression is always of the provided type,
23074 flag warning 183. If the expression can not ever be of the
23075 provided type flag warning 184.
23077 * class.cs: Catch 169 as well.
23079 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23082 2002-01-18 Nick Drochak <ndrochak@gol.com>
23084 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23086 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23088 * interface.cs: (PopulateMethod): Check for pointers being defined
23089 only if the unsafe context is active.
23090 (PopulateProperty): ditto.
23091 (PopulateIndexer): ditto.
23093 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23094 specified. If pointers are present, make sure that they are
23095 present in an unsafe context.
23096 (Constructor, Constructor.Define): ditto.
23097 (Field, Field.Define): ditto.
23098 (Property, Property.Define): ditto.
23099 (Event, Event.Define): ditto.
23101 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23102 hashtable if there are classes or structs defined.
23104 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23105 code, as the constant resolution moved.
23107 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23108 the metadata, so we can flag error 133.
23110 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23111 pointer is being declared in an unsafe context.
23113 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23115 * modifiers.cs (Modifiers.Check): Require a Location argument.
23116 Report error 227 for Unsafe use.
23118 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23120 * statement.cs (For.Emit): If the test is null, then report that
23121 we do `return', as we wont reach anything afterwards.
23123 (Switch.SwitchGoverningType): Track the expression that matched
23126 * driver.cs: Allow negative numbers as an error code to flag.
23128 * cs-parser.jay: Handle 1551.
23130 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23132 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23134 * cs-parser.jay: Report 1518 (type declaration can only contain
23135 class, struct, interface, enum or delegate)
23137 (switch_label): Report 1523 (keywords `case' or `default' must
23140 (opt_switch_sections): Report 1522 (empty switch)
23142 * driver.cs: Report 1515 (response file specified multiple times)
23143 Report 1516 (Source file specified multiple times).
23145 * expression.cs (Argument.Resolve): Signal 1510
23147 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23148 access not allowed in static code)
23150 2002-01-11 Ravi Pratap <ravi@ximian.com>
23152 * typemanager.cs (IsPointerType): Utility method which we are going
23155 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23156 the object type, so we take care of that.
23158 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23160 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23161 added to non-params parameters :-)
23163 * typemanager.cs (CSharpName): Include 'void' type too.
23165 (void_ptr_type): Include in the set of core types.
23167 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23170 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23173 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23174 completely forgotten about it.
23176 2002-01-10 Ravi Pratap <ravi@ximian.com>
23178 * cs-parser.jay (pointer_type): Add. This begins our implementation
23179 of parsing rules for unsafe code.
23181 (unsafe_statement): Implement.
23183 (embedded_statement): Modify to include the above.
23185 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23187 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23188 if the current context is an unsafe one.
23190 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23191 are handled differently, we need separate rules for them.
23193 (local_variable_declaration): Update to use local_variable_pointer_type
23194 to allow variable declarations of unmanaged pointer types.
23196 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23197 in unsafe contexts.
23199 * ../errors/cs0214.cs : Add.
23201 2002-01-16 Nick Drochak <ndrochak@gol.com>
23203 * makefile: remove 'response' file when cleaning.
23205 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23207 * cs-parser.jay: Report 1524.
23209 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23211 * typemanager.cs (RegisterMethod): drop checking if we have
23212 registered this from here
23214 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23216 * class.cs (Method.EmitDestructor): Implement calling our base
23219 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23220 value of InFinally.
23222 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23223 this routine and will wrap the call in a try/catch block. Deal
23226 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23228 * ecore.cs (Expression.MemberLookup): instead of taking a
23229 parameter `same_type' that was used to tell whether we could
23230 access private members we compute our containing type from the
23233 (FieldExpr): Added partial support for volatile fields. This does
23234 not work for volatile fields exposed from assemblies, as I can not
23235 figure out how to extract the modreq from it.
23237 Updated all the source files to use this.
23239 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23240 because it is referenced by MemberLookup very often.
23242 2002-01-09 Ravi Pratap <ravi@ximian.com>
23244 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23245 TypeBuilder.GetCustomAttributes to retrieve what we need.
23247 Get rid of redundant default_member_attr_type as this is the same as
23248 default_member_type which already exists.
23250 * interface.cs, attribute.cs : Update accordingly.
23252 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23254 * typemanager.cs: Enable IndexerPropertyName again. It does not
23255 work for TYpeBuilders though. Ravi, can you please fix this?
23257 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23259 * expression.cs (Argument.Emit): Handle the case of ref objects
23260 being passed to ref functions;
23262 (ParameterReference.EmitLoad): Loads the content of the pointer
23263 without dereferencing.
23265 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23267 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23269 2002-01-08 Ravi Pratap <ravi@ximian.com>
23271 * class.cs (Indexer.DefineMethod): Incorporate the interface
23272 type in the name of the method if we are doing explicit interface
23275 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23277 (BetterConversion): Fix extremely trivial bug where we were referring to
23278 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23281 * ../errors/bug16.cs : Add although we have fixed it.
23283 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23285 * expression.cs (BaseIndexer): Begin implementation.
23287 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23289 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23290 production directly to remove a shift/reduce, and implement
23291 explicit interface implementation.
23293 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23294 after a floating point suffix.
23296 * expression.cs (DoNumericPromotions): Improved the conversion for
23297 uint/uint. If we have a constant, we avoid doing a typecast to a
23300 * class.cs (Indexer): Implement explicit interface implementation
23303 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23305 * class.cs: make the default instance constructor public and hidebysig.
23307 2001-01-03 Ravi Pratap <ravi@ximian.com>
23309 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23310 so we can call it from elsewhere.
23312 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23313 we emit it internally if the class has a defined indexer; otherwise the user
23314 emits it by decorating the class definition with the DefaultMemberAttribute.
23316 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23317 attribute is not used on a type which defines an indexer.
23319 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23320 character when we skip whitespace.
23322 * ../errors/cs0646.cs : Add.
23324 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23326 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23329 * makefile: Add practical target `mcs3.exe' which builds the third
23330 generation compiler.
23332 * expression.cs (New): Fix structures constructor calling.
23334 * class.cs (Property, Method, Indexer): Emit Final flag on the
23335 method if we are an interface implementation and we are not
23338 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23339 whether this property is referencing a `base' method.
23341 * expression.cs (Invocation.EmitCall): take an extra argument:
23342 is_base, this is used to determine whether the `call' or
23343 `callvirt' opcode should be used.
23346 * delegate.cs: update EmitCall.
23348 * class.cs (Method.Define): Set NewSlot for the cases where we are
23349 not implementing an interface method.
23351 (Property.Define): ditto.
23353 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23355 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23356 'r'. Allows mcs to parse itself fully.
23358 2002-01-02 Ravi Pratap <ravi@ximian.com>
23360 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23361 of the number of initializers that require the InitializeArray method.
23363 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23364 update the above field where necessary.
23366 (MakeByteBlob): Update accordingly.
23368 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23371 (EmitDynamicInitializers): Update in accordance with the new optimization.
23373 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23374 same OpCode applies.
23376 * cs-parser.jay : Fix some glaring errors I introduced.
23378 2002-01-01 Ravi Pratap <ravi@ximian.com>
23380 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23381 so that we can check for name clashes there too.
23383 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23384 for interface indexers.
23386 * interfaces.cs (Define): Emit the default member attribute.
23388 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23389 variable was being referred to while setting the value ;-)
23391 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23393 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23394 byte-by-byte information when we know the data is zero.
23396 Make the block always a multiple of 4, because
23397 DefineInitializedData has a bug.
23399 * assign.cs: Fix, we should assign from the temporary, not from
23402 * expression.cs (MakeByteBlob): Fix my incorrect code.
23404 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23406 * typemanager.cs (EnumToUnderlying): This function is used to get
23407 the underlying type from an enumeration, because it does not
23410 * constant.cs: Use the I4_S form for values between -128 and 127.
23412 * statement.cs (Block.LookupLabel): Looks up a label.
23413 (Block): Drop support for labeled blocks.
23415 (LabeledStatement): New kind of statement that represents a label
23418 (Goto): Finally implement this bad boy.
23420 * cs-parser.jay: Update to reflect new mechanism to implement
23423 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23425 * codegen.cs (EmitContext.This): a codegen property that keeps the
23426 a single instance of this instead of creating many different this
23429 * delegate.cs (Delegate.DoResolve): Update to use the property;
23431 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23433 * expression.cs (BaseAccess.DoResolve): Ditto.
23435 2001-12-29 Ravi Pratap <ravi@ximian.com>
23437 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23438 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23440 (InitCoreTypes): Update accordingly.
23442 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23443 so we can quickly store the state.
23445 (ApplyAttributes): Set the correct implementation flags
23446 for InternalCall methods.
23448 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23450 * expression.cs (EmitCall): if a method is not virtual, then do
23451 not use callvirt on it.
23453 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23454 user defined stuff) requires the use of stobj, which takes an
23455 address on the stack instead of an array and an index. So emit
23456 the Ldelema operation for it.
23458 (EmitStoreOpcode): Use stobj for valuetypes.
23460 (UnaryMutator.EmitCode): Use the right 1 value depending on
23461 whether we are dealing with int64/uint64, float or doubles.
23463 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23464 constructors that I implemented last night.
23466 (Constructor.IsDefault): Fix to work properly for static
23469 * cs-parser.jay (CheckDef): report method signature errors.
23470 Update error number 103 to be 132.
23472 * decl.cs: New AdditionResult enumeration value: MethodExists.
23473 Although we do this check for methods later on in the semantic
23474 analysis, catching repeated default constructors is so easy that
23475 we catch these here.
23477 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23480 (ParameterReference.EmitAssign, Emit): handle
23483 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23484 (ArrayAccess.EmitStoreOpcode): ditto.
23486 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23488 * expression.cs (MakeByteBlob): Complete all the missing types
23489 (uint, short, ushort, byte, sbyte)
23491 * class.cs: Only init instance field initializers on instance
23494 Rename `constructors' to instance_constructors.
23496 (TypeContainer.AddConstructor): Only add constructors to the list
23497 if it is not static.
23499 Make sure that we handle default_static_constructor independently
23500 everywhere where we handle instance_constructors
23502 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23504 * class.cs: Do not lookup or create a base initializer for a
23505 static constructor.
23507 (ConstructorInitializer.Resolve): use the proper type to lookup
23510 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23512 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23515 * decl.cs: CloseType is now an virtual method, the default
23516 implementation just closes this type.
23518 2001-12-28 Ravi Pratap <ravi@ximian.com>
23520 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23521 to PreserveSig by default. Also emit HideBySig on such methods.
23523 Basically, set the defaults to standard values.
23525 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23526 argument, if candidate is better, it can't be worse than the best !
23528 (Invocation): Re-write bits to differentiate between methods being
23529 applicable in their expanded form and their normal form - for params
23532 Get rid of use_standard everywhere as only standard conversions are allowed
23533 in overload resolution.
23535 More spec conformance.
23537 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23539 * driver.cs: Add --timestamp, to see where the compiler spends
23542 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23543 `this' in static code.
23545 (SimpleName.DoResolve): Implement in terms of a helper function
23546 that allows static-references to be passed upstream to
23549 (Expression.ResolveWithSimpleName): Resolve specially simple
23550 names when called by MemberAccess to implement the special
23553 (Expression.ImplicitReferenceConversion): Handle conversions from
23554 Null to reference types before others, as Null's type is
23557 * expression.cs (Invocation.EmitCall): Handle the special case of
23558 calling methods declared on a reference type from a ValueType
23559 (Base classes System.Object and System.Enum)
23561 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23562 the left hand side is a TypeExpr, not on every enumeration.
23564 (Binary.Resolve): If types are reference types, then do a cast to
23565 object on operators != and == of both arguments.
23567 * typemanager.cs (FindMembers): Extract instance and static
23568 members if requested.
23570 * interface.cs (PopulateProperty): Use void_type instead of null
23571 as the return type for the setter method.
23573 (PopulateIndexer): ditto.
23575 2001-12-27 Ravi Pratap <ravi@ximian.com>
23577 * support.cs (ReflectionParameters): Fix minor bug where we
23578 were examining the wrong parameter for the ParamArray attribute.
23580 Cope with requests for the type of the parameter at position
23581 greater than the params parameter's. We now return the element
23582 type of the params array as that makes more sense.
23584 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23585 accordingly as we no longer have to extract the element type
23588 (Invocation.OverloadResolve): Update.
23590 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23592 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23593 against IEnumerator, test whether the return value is a descendant
23594 of the IEnumerator interface.
23596 * class.cs (Indexer.Define): Use an auxiliary method to implement
23597 the other bits of the method definition. Begin support for
23598 explicit interface implementation.
23600 (Property.DefineMethod): Use TypeManager.void_type instead of null
23601 for an empty return value.
23603 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23605 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23606 dealing with a FieldExpr which is composed of a FieldBuilder, in
23607 the code path we did extract the constant, but we should have
23608 obtained the underlying value to be able to cast it (otherwise we
23609 end up in an infinite loop, this is what Ravi was running into).
23611 (ArrayCreation.UpdateIndices): Arrays might be empty.
23613 (MemberAccess.ResolveMemberAccess): Add support for section
23614 14.5.4.1 that deals with the special case of E.I when E is a type
23615 and something else, that I can be a reference to a static member.
23617 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23618 handle a particular array type to create byte blobs, it is just
23619 something we dont generate byteblobs for.
23621 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23624 * location.cs (Push): remove the key from the hashtable that we
23625 are about to add. This happens for empty files.
23627 * driver.cs: Dispose files after we have parsed them.
23629 (tokenize): new function that only runs the tokenizer on its
23630 input, for speed testing.
23632 2001-12-26 Ravi Pratap <ravi@ximian.com>
23634 * class.cs (Event.Define): Define the private field only if there
23635 are no accessors defined.
23637 * expression.cs (ResolveMemberAccess): If there is no associated
23638 field with the event, that means we have an event defined with its
23639 own accessors and we should flag error cs0070 since transforming
23640 ourselves into a field is not valid in that case.
23642 * ecore.cs (SimpleName.DoResolve): Same as above.
23644 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23645 and charset to sane values.
23647 2001-12-25 Ravi Pratap <ravi@ximian.com>
23649 * assign.cs (DoResolve): Perform check on events only if they
23650 are being accessed outside the declaring type.
23652 * cs-parser.jay (event_declarations): Update rules to correctly
23653 set the type of the implicit parameter etc.
23655 (add_accessor, remove_accessor): Set current local parameters.
23657 * expression.cs (Binary): For delegate addition and subtraction,
23658 cast the return value from the method into the appropriate delegate
23661 2001-12-24 Ravi Pratap <ravi@ximian.com>
23663 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23664 of these as the workaround is unnecessary.
23666 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23667 delegate data - none of that is needed at all.
23669 Re-write bits to extract the instance expression and the delegate method
23672 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23675 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23676 of attaching attributes instead of duplicating code everywhere.
23678 * everywhere : Update code to do attribute emission using the above method.
23680 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23682 * expression.cs (IsParamsMethodApplicable): if there are not
23683 parameters, return immediately.
23685 * ecore.cs: The 0 literal can be implicity converted to an enum
23688 (SimpleName.DoResolve): First lookup the type, then lookup the
23691 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23692 want to get its address. If the InstanceExpression is not
23693 addressable, store the result in a temporary variable, then get
23696 * codegen.cs: Only display 219 errors on warning level or above.
23698 * expression.cs (ArrayAccess): Make it implement the
23699 IMemoryLocation interface.
23701 (Binary.DoResolve): handle the operator == (object a, object b)
23702 and operator != (object a, object b) without incurring into a
23703 BoxedCast (because 5 != o should never be performed).
23705 Handle binary enumerator operators.
23707 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23708 value type, otherwise use Ldelem_ref.
23710 Use precomputed names;
23712 (AddressOf): Implement address of
23714 * cs-parser.jay (labeled_statement): Fix recursive block
23715 addition by reworking the production.
23717 * expression.cs (New.DoEmit): New has a special case:
23719 If we are dealing with a ValueType, we have a few
23720 situations to deal with:
23722 * The target of New is a ValueType variable, that is
23723 easy, we just pass this as the variable reference
23725 * The target of New is being passed as an argument,
23726 to a boxing operation or a function that takes a
23729 In this case, we need to create a temporary variable
23730 that is the argument of New.
23733 2001-12-23 Ravi Pratap <ravi@ximian.com>
23735 * rootcontext.cs (LookupType): Check that current_type is not null before
23736 going about looking at nested types.
23738 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23739 not implement the IAssignMethod interface any more.
23741 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23742 where we tranform them into FieldExprs if they are being resolved from within
23743 the declaring type.
23745 * ecore.cs (SimpleName.DoResolve): Do the same here.
23747 * assign.cs (DoResolve, Emit): Clean up code considerably.
23749 * ../errors/bug10.cs : Add.
23751 * ../errors/cs0070.cs : Add.
23753 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23755 * assign.cs : Get rid of EventIsLocal everywhere.
23757 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23759 * ecore.cs (ConvertIntLiteral): finished the implementation.
23761 * statement.cs (SwitchLabel): Convert the value we are using as a
23762 key before looking up the table.
23764 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23766 * codegen.cs (EmitTopBlock): Require a Location argument now.
23768 * cs-parser.jay (constructor_declarator): We need to setup
23769 current_local_parameters before we parse the
23770 opt_constructor_initializer, to allow the variables to be bound
23771 to the constructor arguments.
23773 * rootcontext.cs (LookupType): First lookup nested classes in our
23774 class and our parents before we go looking outside our class.
23776 * expression.cs (ConstantFold): Extract/debox the values at the
23779 * rootcontext.cs (EmitCode): Resolve the constants first before we
23780 resolve the types. This is not really needed, but it helps debugging.
23782 * statement.cs: report location.
23784 * cs-parser.jay: pass location to throw statement.
23786 * driver.cs: Small bug fix.
23788 * report.cs: Updated format to be 4-zero filled digits.
23790 2001-12-22 Ravi Pratap <ravi@ximian.com>
23792 * expression.cs (CheckIndices): Fix minor bug where the wrong
23793 variable was being referred to ;-)
23795 (DoEmit): Do not call EmitStaticInitializers when the
23796 underlying type is System.Object.
23798 2001-12-21 Ravi Pratap <ravi@ximian.com>
23800 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23801 and do the usual workaround for SRE.
23803 * class.cs (MyEventBuilder.EventType): New member to get at the type
23804 of the event, quickly.
23806 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23808 * assign.cs (Assign.DoResolve): Handle the case when the target
23809 is an EventExpr and perform the necessary checks.
23811 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23814 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23816 (EventExpr): Set the type in the constructor itself since we
23817 are meant to be born fully resolved.
23819 (EventExpr.Define): Revert code I wrote earlier.
23821 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23822 instance expression is null. The instance expression is a This in that case
23823 or a null, depending on whether it is a static method or not.
23825 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23826 refers to more than one method.
23828 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23829 and accordingly flag errors.
23831 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23833 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23835 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23837 * location.cs (ToString): Provide useful rutine.
23839 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23841 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23842 objects, return the actual integral boxed.
23844 * statement.cs (SwitchLabel): define an ILLabel for each
23847 (Switch.CheckSwitch): If the value is a Literal, extract
23848 the underlying literal.
23850 Also in the unused hashtable we had, add the SwitchLabel so we can
23851 quickly look this value up.
23853 * constant.cs: Implement a bunch of new constants. Rewrite
23854 Literal based on this. Made changes everywhere to adapt to this.
23856 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23857 dereferencing array only once, and also copes with enumrations.
23859 bytes are two bytes wide, not one.
23861 (Cast): Perform constant conversions.
23863 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23864 wrappers to the literals here.
23866 * expression.cs (DoNumericPromotions): long literals can converted
23867 to ulong implicity (this is taken care of elsewhere, but I was
23868 missing this spot).
23870 * ecore.cs (Expression.Literalize): Make the return type Literal,
23871 to improve type checking.
23873 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23875 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23877 * literal.cs: Revert code from ravi that checked the bounds. The
23878 bounds are sane by the definition of the type itself.
23880 * typemanager.cs: Fix implementation of ImplementsInterface. We
23881 need to actually look up in our parent hierarchy for interfaces
23884 * const.cs: Use the underlying type for enumerations
23886 * delegate.cs: Compute the basename for the delegate creation,
23887 that should fix the delegate test case, and restore the correct
23888 Type Lookup semantics in rootcontext
23890 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23891 referencing a nested type with the Reflection API is using the "+"
23894 * cs-parser.jay: Do not require EOF token at the end.
23896 2001-12-20 Ravi Pratap <ravi@ximian.com>
23898 * rootcontext.cs (LookupType): Concatenate type names with
23899 a '.' instead of a '+' The test suite passes again.
23901 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23902 field of the enumeration.
23904 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23905 the case when the member is an EventExpr.
23907 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23908 static has an associated instance expression.
23910 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23912 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23914 * class.cs (Event.Define): Register event and perform appropriate checks
23917 We define the Add and Remove methods even if the use provides none because
23918 in that case, we provide default implementations ourselves.
23920 Define a private field of the type of the event. This is done by the CSC compiler
23921 and we should be doing it too ;-)
23923 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23924 More methods we use in code we generate.
23926 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23929 (InitCoreTypes): Update accordingly for the above.
23931 * class.cs (Event.Emit): Generate code for default accessors that we provide
23933 (EmitDefaultMethod): Do the job in the above.
23935 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23938 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23940 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23941 builders even if we were missing one.
23943 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23944 pass the Basename as our class name instead of the Name. The
23945 basename will be correctly composed for us.
23947 * parameter.cs (Paramters): Now takes a Location argument.
23949 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23950 make all the code call directly LookupType in RootContext and take
23951 this chance to pass the Location information everywhere.
23953 * Everywhere: pass Location information.
23955 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23957 * class.cs (Constructor.Define): Updated way of detecting the
23958 length of the parameters.
23960 (TypeContainer.DefineType): Use basename as the type name for
23963 (TypeContainer.Define): Do not recursively define types here, as
23964 definition is taken care in order by the RootContext.
23966 * tree.cs: Keep track of namespaces in a per-file basis.
23968 * parameter.cs (Parameter.ComputeSignature): Update to use
23971 (Parameters.GetSignature): ditto.
23973 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23974 instead of a TypeContainer.
23976 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23977 resolve names. Because we need to be resolve in our context, not
23980 * driver.cs: Implement response files.
23982 * class.cs (TypeContainer.DefineType): If we are defined, do not
23983 redefine ourselves.
23985 (Event.Emit): Emit the code for add/remove handlers.
23986 (Event.Define): Save the MethodBuilders for add/remove.
23988 * typemanager.cs: Use pair here too.
23990 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23991 DictionaryEntry requires the first argument to be non-null.
23993 (enum_declaration): Compute full name for registering the
23996 (delegate_declaration): Instead of using
23997 formal_parameter_list, use opt_formal_parameter_list as the list
24000 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24001 (EventParsing): New property that controls whether `add' and
24002 `remove' are returned as tokens or identifiers (for events);
24004 2001-12-19 Ravi Pratap <ravi@ximian.com>
24006 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24007 use MyEventBuilder only and let it wrap the real builder for us.
24009 (MyEventBuilder): Revamp constructor etc.
24011 Implement all operations that we perform on EventBuilder in precisely the same
24014 (FindMembers): Update to use the EventBuilder member.
24016 (Event.Emit): Update accordingly.
24018 2001-12-18 Ravi Pratap <ravi@ximian.com>
24020 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24021 by calling the appropriate methods.
24023 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24026 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24028 2001-12-17 Ravi Pratap <ravi@ximian.com>
24030 * delegate.cs (Delegate.Populate): Check that the return type
24031 and various parameters types are indeed accessible.
24033 * class.cs (Constructor.Define): Same here.
24035 (Field.Define): Ditto.
24037 (Event.Define): Ditto.
24039 (Operator.Define): Check that the underlying Method defined itself
24040 correctly - so it's MethodBuilder should not be null.
24042 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24043 expression happens to be null.
24045 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24046 members but as of now we don't seem to be able to do anything really useful with it.
24048 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24049 not the EventBuilder.
24051 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24053 * cs-tokenizer.cs: Add support for defines.
24054 Add support for #if, #elif, #else, #endif
24056 (eval_var): evaluates a variable.
24057 (eval): stubbed for evaluating functions.
24059 * cs-parser.jay: Pass the defines information
24061 * driver.cs: Add --define command line option.
24063 * decl.cs: Move MemberCore here.
24065 Make it the base class for DeclSpace. This allows us to catch and
24066 report 108 and 109 for everything now.
24068 * class.cs (TypeContainer.Define): Extract all the members
24069 before populating and emit the warning 108 (new keyword required
24070 to override) instead of having each member implement this.
24072 (MemberCore.Define): New abstract method, we will be using this in
24073 the warning reporting engine in Populate.
24075 (Operator.Define): Adjust to new MemberCore protocol.
24077 * const.cs (Const): This does not derive from Expression, it is a
24078 temporary object we use to create fields, it is a MemberCore.
24080 * class.cs (Method.Define): Allow the entry point to be in a
24083 * driver.cs: Rewrite the argument handler to clean it up a bit.
24085 * rootcontext.cs: Made it just an auxiliary namespace feature by
24086 making everything static.
24088 * driver.cs: Adapt code to use RootContext type name instead of
24091 * delegate.cs: Remove RootContext argument.
24093 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24096 * class.cs (Event.Define): The lookup can fail.
24098 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24100 * expression.cs: Resolve the this instance before invoking the code.
24102 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24104 * cs-parser.jay: Add a production in element_access that allows
24105 the thing to become a "type" reference. This way we can parse
24106 things like "(string [])" as a type.
24108 Note that this still does not handle the more complex rules of
24112 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24114 * ecore.cs: (CopyNewMethods): new utility function used to
24115 assemble the list of methods from running FindMembers.
24117 (MemberLookup): Rework FindMembers so that
24119 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24121 * class.cs (TypeContainer): Remove Delegates who fail to be
24124 * delegate.cs (Populate): Verify that we dont get null return
24125 values. TODO: Check for AsAccessible.
24127 * cs-parser.jay: Use basename to emit error 574 (destructor should
24128 have the same name as container class), not the full name.
24130 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24131 possible representation.
24133 Also implements integer type suffixes U and L.
24135 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24137 * expression.cs (ArrayCreation.DoResolve): We need to do the
24138 argument resolution *always*.
24140 * decl.cs: Make this hold the namespace. Hold the root context as
24142 (LookupType): Move here.
24144 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24146 * location.cs (Row, Name): Fixed the code, it was always returning
24147 references to the first file.
24149 * interface.cs: Register properties defined through interfaces.
24151 * driver.cs: Add support for globbing on the command line
24153 * class.cs (Field): Make it derive from MemberCore as well.
24156 2001-12-15 Ravi Pratap <ravi@ximian.com>
24158 * class.cs (Event::Define): Check that the type of the event is a delegate
24159 type else flag error #66.
24161 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24164 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24165 values of EntryPoint, CharSet etc etc.
24167 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24169 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24170 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24171 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24172 which needs this to do its work.
24174 * ../errors/cs0066.cs : Add.
24176 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24178 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24181 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24182 clears out the parameters field.
24183 (MemberSignatureCompare): Cleanup
24185 (MemberCore): New base class used to share code between MethodCore
24188 (RegisterRequiredImplementations) BindingFlags.Public requires
24189 either BindingFlags.Instace or Static. Use instance here.
24191 (Property): Refactored code to cope better with the full spec.
24193 * parameter.cs (GetParameterInfo): Return an empty array instead
24196 * class.cs (Property): Abstract or extern properties have no bodies.
24198 * parameter.cs (GetParameterInfo): return a zero-sized array.
24200 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24201 method modifier validation to the typecontainer so we can reuse
24202 this on properties.
24204 (MethodCore.ParameterTypes): return an empty sized array of types.
24206 (Property.Define): Test property modifier validity.
24208 Add tests for sealed/override too.
24210 (Method.Emit): abstract or extern methods have no bodies.
24212 2001-12-14 Ravi Pratap <ravi@ximian.com>
24214 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24217 (Method::Define, ::Emit): Modify accordingly.
24219 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24221 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24223 * makefile: Pass in /unsafe.
24225 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24227 * class.cs (MakeKey): Kill routine.
24229 * class.cs (TypeContainer.Define): Correctly define explicit
24230 method implementations (they require the full interface name plus
24233 * typemanager.cs: Deply the PtrHashtable here and stop using the
24234 lame keys. Things work so much better.
24236 This of course broke everyone who depended on `RegisterMethod' to
24237 do the `test for existance' test. This has to be done elsewhere.
24239 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24240 the object stupid Equals method (because, that like fails all over
24241 the place). We still do not use it.
24243 * class.cs (TypeContainer.SetRequiredInterface,
24244 TypeContainer.RequireMethods): Killed these two routines and moved
24245 all the functionality to RegisterRequiredImplementations.
24247 (TypeContainer.RegisterRequiredImplementations): This routine now
24248 registers all the implementations required in an array for the
24249 interfaces and abstract methods. We use an array of structures
24250 which can be computed ahead of time to reduce memory usage and we
24251 also assume that lookups are cheap as most classes will not
24252 implement too many interfaces.
24254 We also avoid creating too many MethodSignatures.
24256 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24257 clear the "pending" bit if we find that there are problems with
24260 (TypeContainer.VerifyPendingMethods): Update to report errors of
24261 methods that look like implementations but are not.
24263 (TypeContainer.Define): Add support for explicit interface method
24266 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24268 * typemanager.cs: Keep track of the parameters here instead of
24269 being a feature of the TypeContainer.
24271 * class.cs: Drop the registration of parameters here, as
24272 InterfaceMethods are also interface declarations.
24274 * delegate.cs: Register methods with the TypeManager not only with
24275 the TypeContainer. This code was buggy.
24277 * interface.cs: Full registation here.
24279 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24281 * expression.cs: Remove reducer for binary expressions, it can not
24284 * const.cs: Put here the code that used to go into constant.cs
24286 * constant.cs: Put here the code for constants, this is a new base
24287 class for Literals.
24289 * literal.cs: Make Literal derive from Constant.
24291 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24293 * statement.cs (Return.Emit): Report error 157 if the user
24294 attempts to return from a finally block.
24296 (Return.Emit): Instead of emitting a return, jump to the end of
24299 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24300 LocalBuilder to store the result of the function. ReturnLabel is
24301 the target where we jump.
24304 2001-12-09 Radek Doulik <rodo@ximian.com>
24306 * cs-parser.jay: remember alias in current namespace
24308 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24311 * class.cs (LookupAlias): lookup alias in my_namespace
24313 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24315 (LookupAlias): lookup alias in this and if needed in parent
24318 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24322 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24323 making things static. I need this to avoid passing the
24324 TypeContainer when calling ParameterType.
24326 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24327 that did string manipulation to compute the type and then call
24328 GetType. Use Parameter.ParameterType instead.
24330 * cs-tokenizer.cs: Consume the suffix for floating values.
24332 * expression.cs (ParameterReference): figure out whether this is a
24333 reference parameter or not. Kill an extra variable by computing
24334 the arg_idx during emission.
24336 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24337 function that returns whether a parameter is an out/ref value or not.
24339 (Parameter.ParameterType): The type of the parameter (base,
24340 without ref/out applied).
24342 (Parameter.Resolve): Perform resolution here.
24343 (Parameter.ExternalType): The full type (with ref/out applied).
24345 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24346 support for expressions on the using statement.
24348 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24350 * statement.cs (Using.EmitLocalVariableDecls): Split the
24351 localvariable handling of the using statement.
24353 (Block.EmitMeta): Keep track of variable count across blocks. We
24354 were reusing slots on separate branches of blocks.
24356 (Try.Emit): Emit the general code block, we were not emitting it.
24358 Check the type of the declaration to be an IDisposable or
24359 something that can be implicity converted to it.
24361 Emit conversions if required.
24363 * ecore.cs (EmptyExpression): New utility class.
24364 (Expression.ImplicitConversionExists): New utility function.
24366 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24368 * statement.cs (Using): Implement.
24370 * expression.cs (LocalVariableReference): Support read only variables.
24372 * statement.cs: Remove the explicit emit for the Leave opcode.
24373 (VariableInfo): Add a readonly field.
24375 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24377 * ecore.cs (ConvCast): new class used to encapsulate the various
24378 explicit integer conversions that works in both checked and
24379 unchecked contexts.
24381 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24382 properly generate the overflow opcodes.
24384 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24386 * statement.cs: The correct type for the EmptyExpression is the
24387 element_type, not the variable type. Ravi pointed this out.
24389 2001-12-04 Ravi Pratap <ravi@ximian.com>
24391 * class.cs (Method::Define): Handle PInvoke methods specially
24392 by using DefinePInvokeMethod instead of the usual one.
24394 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24395 above to do the task of extracting information and defining the method.
24397 2001-12-04 Ravi Pratap <ravi@ximian.com>
24399 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24400 of the condition for string type.
24402 (Emit): Move that here.
24404 (ArrayCreation::CheckIndices): Keep string literals in their expression
24407 (EmitDynamicInitializers): Handle strings appropriately.
24409 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24411 * codegen.cs (EmitContext): Replace multiple variables with a
24412 single pointer to the current Switch statement.
24414 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24417 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24421 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24424 (Foreach.Emit): Foreach on arrays was not setting
24425 up the loop variables (for break/continue).
24427 (GotoCase): Semi-implented.
24429 2001-12-03 Ravi Pratap <ravi@ximian.com>
24431 * attribute.cs (CheckAttribute): Handle system attributes by using
24432 Attribute.GetAttributes to examine information we need.
24434 (GetValidPlaces): Same here.
24436 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24438 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24440 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24442 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24444 (Method::Emit): Handle the case when we are a PInvoke method.
24446 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24448 * expression.cs: Use ResolveWithSimpleName on compound names.
24450 2001-12-02 Ravi Pratap <ravi@ximian.com>
24452 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24453 before trying to reduce it.
24455 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24457 * constant.cs (LookupConstantValue): Implement.
24459 (EmitConstant): Use the above in emitting the constant.
24461 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24462 that are user-defined by doing a LookupConstantValue on them.
24464 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24467 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24469 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24471 (BaseAccess.DoResolve): Implement.
24473 (MemberAccess.DoResolve): Split this routine into a
24474 ResolveMemberAccess routine that can be used independently
24476 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24478 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24479 As that share bits of the implementation. Is returns a boolean,
24480 while As returns the Type that is being probed.
24482 2001-12-01 Ravi Pratap <ravi@ximian.com>
24484 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24485 instead of a Literal - much easier.
24487 (EnumInTransit): Remove - utterly useless :-)
24489 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24491 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24493 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24494 chain when we have no associated expression.
24496 2001-11-30 Ravi Pratap <ravi@ximian.com>
24498 * constant.cs (Define): Use Location while reporting the errror.
24500 Also emit a warning when 'new' is used and there is no inherited
24503 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24506 (LookupEnumValue): Implement to lookup an enum member's value and define it
24509 (Populate): Re-write accordingly to use the above routine.
24511 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24513 * expression.cs (This): Fix prototype for DoResolveLValue to
24514 override the base class DoResolveLValue.
24516 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24519 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24520 (we need to load the address of the field here). This fixes
24523 (FieldExpr.DoResolveLValue): Call the DoResolve
24524 function to initialize the Instance expression.
24526 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24527 correctly the GetEnumerator operation on a value type.
24529 * cs-parser.jay: Add more simple parsing error catches.
24531 * statement.cs (Switch): Add support for string switches.
24532 Handle null specially.
24534 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24536 2001-11-28 Ravi Pratap <ravi@ximian.com>
24538 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24540 (declare_local_constant): New helper function.
24542 * statement.cs (AddConstant): Keep a separate record of constants
24544 (IsConstant): Implement to determine if a variable is a constant.
24546 (GetConstantExpression): Implement.
24548 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24550 * statement.cs (IsVariableDefined): Re-write.
24552 2001-11-27 Ravi Pratap <ravi@ximian.com>
24554 * class.cs (TypeContainer::FindMembers): Look for constants
24555 in the case when we are looking for MemberTypes.Field
24557 * expression.cs (MemberAccess::DoResolve): Check that in the
24558 case we are a FieldExpr and a Literal, we are not being accessed
24559 by an instance reference.
24561 * cs-parser.jay (local_constant_declaration): Implement.
24563 (declaration_statement): Implement for constant declarations.
24565 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24567 * statement.cs (Switch): Catch double defaults.
24569 (Switch): More work on the switch() statement
24570 implementation. It works for integral values now, need to finish
24574 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24576 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24577 integer literals into other integer literals. To be used by
24580 2001-11-24 Ravi Pratap <ravi@ximian.com>
24582 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24585 (EmitDynamicInitializers): Cope with the above since we extract data
24586 directly from ArrayData now.
24588 (ExpectInitializers): Keep track of whether initializers are mandatory
24591 (Bounds): Make it a hashtable to prevent the same dimension being
24592 recorded for every element in that dimension.
24594 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24597 Also fix bug which was causing the indices to be emitted in the reverse
24600 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24602 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24603 unfinished. They do not work, because the underlying code is
24606 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24608 * cs-parser.jay: Remove bogus fixme.
24610 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24611 on Switch statement.
24613 2001-11-23 Ravi Pratap <ravi@ximian.com>
24615 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24618 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24619 parameter. Apparently, any expression is allowed.
24621 (ValidateInitializers): Update accordingly.
24623 (CheckIndices): Fix some tricky bugs thanks to recursion.
24625 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24626 I was being completely brain-dead.
24628 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24629 and re-write acordingly.
24631 (DelegateInvocation): Re-write accordingly.
24633 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24635 (MakeByteBlob): Handle types more correctly.
24637 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24638 initialization from expressions but it is incomplete because I am a complete
24641 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24643 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24644 on If. Basically, we have to return `true' (ie, we do return to
24645 our caller) only if both branches of the if return.
24647 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24648 short-circuit operators, handle them as short circuit operators.
24650 (Cast.DoResolve): Resolve type.
24651 (Cast.Cast): Take an expression as the target type.
24653 * cs-parser.jay (cast_expression): Remove old hack that only
24654 allowed a limited set of types to be handled. Now we take a
24655 unary_expression and we resolve to a type during semantic
24658 Use the grammar productions from Rhys to handle casts (this is
24659 not complete like Rhys syntax yet, we fail to handle that corner
24660 case that C# has regarding (-x), but we will get there.
24662 2001-11-22 Ravi Pratap <ravi@ximian.com>
24664 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24665 field which is an array type.
24667 * cs-parser.jay (declare_local_variables): Support array initialization too.
24669 * typemanager.cs (MakeKey): Implement.
24671 (everywhere): Use the above appropriately.
24673 * cs-parser.jay (for_statement): Update for array initialization while
24674 declaring variables.
24676 * ecore.cs : The error message was correct, it's the variable's names that
24677 were misleading ;-) Make the code more readable.
24679 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24680 the correct type etc.
24682 (ConvertExplicit): Handle Enum types by examining the underlying type.
24684 2001-11-21 Ravi Pratap <ravi@ximian.com>
24686 * parameter.cs (GetCallingConvention): Always return
24687 CallingConventions.Standard for now.
24689 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24691 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24692 and `r' after calling DoNumericPromotions.
24694 * ecore.cs: Fix error message (the types were in the wrong order).
24696 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24697 BindingFlags.Instance as well
24699 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24700 implicit int literal conversion in an empty cast so that we
24701 propagate the right type upstream.
24703 (UnboxCast): new class used to unbox value types.
24704 (Expression.ConvertExplicit): Add explicit type conversions done
24707 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24708 the target type before applying the implicit LongLiterals to ULong
24711 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24713 * cs-parser.jay (for_statement): Reworked the way For works: now
24714 we declare manually any variables that are introduced in
24715 for_initializer to solve the problem of having out-of-band code
24716 emition (that is what got for broken).
24718 (declaration_statement): Perform the actual variable declaration
24719 that used to be done in local_variable_declaration here.
24721 (local_variable_declaration): Do not declare anything, just pass
24722 the information on a DictionaryEntry
24724 2001-11-20 Ravi Pratap <ravi@ximian.com>
24726 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24727 re-write of the logic to now make it recursive.
24729 (UpdateIndices): Re-write accordingly.
24731 Store element data in a separate ArrayData list in the above methods.
24733 (MakeByteBlob): Implement to dump the array data into a byte array.
24735 2001-11-19 Ravi Pratap <ravi@ximian.com>
24737 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24740 * constant.cs (Define): Implement.
24742 (EmitConstant): Re-write fully.
24744 Pass in location info.
24746 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24749 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24750 DictionaryEntry since we need location info too.
24752 (constant_declaration): Update accordingly.
24754 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24755 code into another method : UpdateIndices.
24757 2001-11-18 Ravi Pratap <ravi@ximian.com>
24759 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24760 some type checking etc.
24762 2001-11-17 Ravi Pratap <ravi@ximian.com>
24764 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24765 bits to provide dimension info if the user skips doing that.
24767 Update second constructor to store the rank correctly.
24769 2001-11-16 Ravi Pratap <ravi@ximian.com>
24771 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24772 and try to implement.
24774 * ../errors/cs0150.cs : Add.
24776 * ../errors/cs0178.cs : Add.
24778 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24780 * statement.cs: Implement foreach on multi-dimensional arrays.
24782 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24783 name of the params argument.
24785 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24786 initializing the array.
24788 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24789 we can use this elsewhere.
24791 * statement.cs: Finish implementation of foreach for single
24794 * cs-parser.jay: Use an out-of-band stack to pass information
24795 around, I wonder why I need this.
24797 foreach_block: Make the new foreach_block the current_block.
24799 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24800 function used to return a static Parameters structure. Used for
24801 empty parameters, as those are created very frequently.
24803 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24805 2001-11-15 Ravi Pratap <ravi@ximian.com>
24807 * interface.cs : Default modifier is private, not public. The
24808 make verify test passes again.
24810 2001-11-15 Ravi Pratap <ravi@ximian.com>
24812 * support.cs (ReflectionParameters): Fix logic to determine
24813 whether the last parameter is a params one. Test 9 passes again.
24815 * delegate.cs (Populate): Register the builders we define with
24816 RegisterParameterForBuilder. Test 19 passes again.
24818 * cs-parser.jay (property_declaration): Reference $6 instead
24819 of $$ to get at the location.
24821 (indexer_declaration): Similar stuff.
24823 (attribute): Ditto.
24825 * class.cs (Property): Register parameters for the Get and Set methods
24826 if they exist. Test 23 passes again.
24828 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24829 call to EmitArguments as we are sure there aren't any params arguments.
24830 Test 32 passes again.
24832 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24833 IndexOutOfRangeException.
24835 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24836 Test 33 now passes again.
24838 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24840 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24841 broke a bunch of things. Will have to come up with a better way
24842 of tracking locations.
24844 * statement.cs: Implemented foreach for single dimension arrays.
24846 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24848 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24849 an error. This removes the lookup from the critical path.
24851 * cs-parser.jay: Removed use of temporary_loc, which is completely
24854 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24856 * support.cs (ReflectionParameters.ParameterModifier): Report
24857 whether the argument is a PARAMS argument or not.
24859 * class.cs: Set the attribute `ParamArrayAttribute' on the
24860 parameter argument.
24862 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24863 and cons_param_array_attribute (ConstructorInfo for
24864 ParamArrayAttribute).,
24866 * codegen.cs: Emit the return using the `Return' statement, that
24867 way we can report the error correctly for missing return values.
24869 * class.cs (Method.Emit): Clean up.
24871 * expression.cs (Argument.Resolve): Take another argument: the
24872 location where this argument is used. Notice that this is not
24873 part of the "Argument" class as to reduce the size of the
24874 structure (we know the approximate location anyways).
24876 Test if the argument is a variable-reference, if not, then
24877 complain with a 206.
24879 (Argument.Emit): Emit addresses of variables.
24881 (Argument.FullDesc): Simplify.
24883 (Invocation.DoResolve): Update for Argument.Resolve.
24885 (ElementAccess.DoResolve): ditto.
24887 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24888 method should be virtual, as this method is always virtual.
24890 (NewDelegate.DoResolve): Update for Argument.Resolve.
24892 * class.cs (ConstructorInitializer.DoResolve): ditto.
24894 * attribute.cs (Attribute.Resolve): ditto.
24896 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24898 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24900 * expression.cs (ParameterReference): Drop IStackStorage and implement
24901 IAssignMethod instead.
24903 (LocalVariableReference): ditto.
24905 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24906 IAssignMethod instead.
24908 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24910 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24911 enumerations that are used in heavily used structures derive from
24912 byte in a laughable and pathetic attempt to reduce memory usage.
24913 This is the kind of pre-optimzations that you should not do at
24914 home without adult supervision.
24916 * expression.cs (UnaryMutator): New class, used to handle ++ and
24917 -- separatedly from the other unary operators. Cleans up the
24918 code, and kills the ExpressionStatement dependency in Unary.
24920 (Unary): Removed `method' and `Arguments' from this class, making
24921 it smaller, and moving it all to SimpleCall, so I can reuse this
24922 code in other locations and avoid creating a lot of transient data
24923 strucutres when not required.
24925 * cs-parser.jay: Adjust for new changes.
24927 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24929 * enum.cs (Enum.Populate): If there is a failure during
24932 * cs-parser.jay (opt_enum_base): we used to catch type errors
24933 here, but this is really incorrect. The type error should be
24934 catched during semantic analysis.
24936 2001-12-11 Ravi Pratap <ravi@ximian.com>
24938 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24939 current_local_parameters as expected since I, in my stupidity, had forgotten
24942 * attribute.cs (GetValidPlaces): Fix stupid bug.
24944 * class.cs (Method::Emit): Perform check on applicability of attributes.
24946 (Constructor::Emit): Ditto.
24948 (Field::Emit): Ditto.
24950 (Field.Location): Store location information.
24952 (Property, Event, Indexer, Operator): Ditto.
24954 * cs-parser.jay (field_declaration): Pass in location for each field.
24956 * ../errors/cs0592.cs : Add.
24958 2001-11-12 Ravi Pratap <ravi@ximian.com>
24960 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24962 (InitCoreTypes): Update accordingly.
24964 (RegisterAttrType, LookupAttr): Implement.
24966 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24967 info about the same.
24969 (Resolve): Update to populate the above as necessary.
24971 (Error592): Helper.
24973 (GetValidPlaces): Helper to the above.
24975 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24977 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24979 2001-11-12 Ravi Pratap <ravi@ximian.com>
24981 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24983 * ../errors/cs0617.cs : Add.
24985 2001-11-11 Ravi Pratap <ravi@ximian.com>
24987 * enum.cs (Emit): Rename to Populate to be more consistent with what
24988 we expect it to do and when exactly it is called.
24990 * class.cs, rootcontext.cs : Update accordingly.
24992 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24993 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24995 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24997 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24998 of a fieldinfo using the above, when dealing with a FieldBuilder.
25000 2001-11-10 Ravi Pratap <ravi@ximian.com>
25002 * ../errors/cs0031.cs : Add.
25004 * ../errors/cs1008.cs : Add.
25006 * ../errrors/cs0543.cs : Add.
25008 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25011 (FindMembers): Implement.
25013 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25014 enums and delegates too.
25016 (enum_types): Rename to builder_to_enum.
25018 (delegate_types): Rename to builder_to_delegate.
25020 * delegate.cs (FindMembers): Implement.
25022 2001-11-09 Ravi Pratap <ravi@ximian.com>
25024 * typemanager.cs (IsEnumType): Implement.
25026 * enum.cs (Emit): Re-write parts to account for the underlying type
25027 better and perform checking etc.
25029 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25030 of the underlying type.
25032 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25035 * enum.cs (error31): Helper to report error #31.
25037 * cs-parser.jay (enum_declaration): Store location of each member too.
25039 * enum.cs (member_to_location): New hashtable.
25041 (AddEnumMember): Update location hashtable.
25043 (Emit): Use the location of each member while reporting errors.
25045 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25047 * cs-parser.jay: A for_initializer if is a
25048 local_variable_declaration really ammount to have an implicit
25049 block with the variable declaration and no initializer for for.
25051 * statement.cs (For.Emit): Cope with null initializers.
25053 This fixes the infinite loop on for initializers.
25055 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25057 * enum.cs: More cleanup.
25059 * ecore.cs: Remove dead code.
25061 * class.cs (Property.Emit): More simplification.
25062 (Event.Emit): ditto.
25064 Reworked to have less levels of indentation.
25066 2001-11-08 Ravi Pratap <ravi@ximian.com>
25068 * class.cs (Property): Emit attributes.
25078 * enum.cs (Emit): Ditto.
25080 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25083 * class.cs (Field, Event, etc.): Move attribute generation into the
25084 Emit method everywhere.
25086 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25087 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25088 as we had no way of defining nested enums !
25090 * rootcontext.cs : Adjust code accordingly.
25092 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25094 2001-11-07 Ravi Pratap <ravi@ximian.com>
25096 * expression.cs (EvalConstantExpression): Move into ecore.cs
25098 * enum.cs (Enum): Rename some members and make them public and readonly
25099 according to our convention.
25101 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25104 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25106 (Enum::Emit): Write a simple version for now which doesn't try to compute
25107 expressions. I shall modify this to be more robust in just a while.
25109 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25111 (TypeContainer::CloseType): Create the Enum types too.
25113 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25115 * expression.cs (EvalConstantExpression): Get rid of completely.
25117 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25118 user-defined values and other cases.
25120 (IsValidEnumLiteral): Helper function.
25122 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25123 out there in the case we had a literal FieldExpr.
25125 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25127 (Literalize): Revamp a bit to take two arguments.
25129 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25131 2001-11-06 Ravi Pratap <ravi@ximian.com>
25133 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25135 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25137 (Resolve): Use the above to ensure we have proper initializers.
25139 2001-11-05 Ravi Pratap <ravi@ximian.com>
25141 * expression.cs (Expression::EvalConstantExpression): New method to
25142 evaluate constant expressions.
25144 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25146 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25148 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25151 (Binary.ResolveOperator): Handle operator != (object a, object b)
25152 and operator == (object a, object b);
25154 (Binary.DoNumericPromotions): Indicate whether the numeric
25155 promotion was possible.
25157 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25160 Made the ArrayAccess implement interface IAssignMethod instead of
25161 IStackStore as the order in which arguments are passed reflects
25164 * assign.cs: Instead of using expr.ExprClass to select the way of
25165 assinging, probe for the IStackStore/IAssignMethod interfaces.
25167 * typemanager.cs: Load InitializeArray definition.
25169 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25170 static data that can be used to initialize arrays.
25172 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25174 * expression.cs: Handle operator== and operator!= for booleans.
25176 (Conditioal.Reduce): Implement reducer for the ?: operator.
25178 (Conditional.Resolve): Implement dead code elimination.
25180 (Binary.Resolve): Catch string literals and return a new
25181 concatenated string.
25183 (Unary.Reduce): Implement reduction of unary expressions.
25185 * ecore.cs: Split out the expression core handling here.
25187 (Expression.Reduce): New method used to perform constant folding
25188 and CSE. This is needed to support constant-expressions.
25190 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25191 targets, and optimize for !x.
25193 2001-11-04 Ravi Pratap <ravi@ximian.com>
25195 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25196 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25197 set custom atttributes.
25199 * literal.cs (Literal::GetValue): New abstract method to return the actual
25200 value of the literal, cast as an object.
25202 (*Literal): Implement GetValue method.
25204 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25205 expressions to the arraylist but objects of type Argument.
25207 * class.cs (TypeContainer::Emit): Emit our attributes too.
25209 (Method::Emit, Constructor::Emit): Ditto.
25211 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25212 to be ignoring earlier.
25214 2001-11-03 Ravi Pratap <ravi@ximian.com>
25216 * attribute.cs (AttributeSection::Define): Implement to do the business
25217 of constructing a CustomAttributeBuilder.
25219 (Attribute): New trivial class. Increases readability of code.
25221 * cs-parser.jay : Update accordingly.
25223 (positional_argument_list, named_argument_list, named_argument): New rules
25225 (attribute_arguments): Use the above so that we are more correct.
25227 2001-11-02 Ravi Pratap <ravi@ximian.com>
25229 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25230 to perform all checks for a method with a params parameter.
25232 (Invocation::OverloadResolve): Update to use the above method and therefore
25233 cope correctly with params method invocations.
25235 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25238 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25239 constructors in our parent too because we can't afford to miss out on
25242 * attribute.cs (AttributeSection): New name for the class Attribute
25244 Other trivial changes to improve readability.
25246 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25247 use the new class names.
25249 2001-11-01 Ravi Pratap <ravi@ximian.com>
25251 * class.cs (Method::Define): Complete definition for params types too
25253 (Indexer::Define): Ditto.
25255 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25256 Cope everywhere with a request for info about the array parameter.
25258 2001-11-01 Ravi Pratap <ravi@ximian.com>
25260 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25262 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25263 local_variable_type to extract the string corresponding to the type.
25265 (local_variable_type): Fixup the action to use the new helper method.
25267 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25270 * expression.cs : Clean out code which uses the above.
25272 2001-10-31 Ravi Pratap <ravi@ximian.com>
25274 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25275 and bale out if necessary by returning a false.
25277 (RegisterProperty): Ditto.
25279 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25280 and print out appropriate error messages.
25282 * interface.cs (everywhere): Ditto.
25284 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25285 location to constructor.
25287 * class.cs (Property, Event, Indexer): Update accordingly.
25289 * ../errors/cs111.cs : Added.
25291 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25292 of a method, as laid down by the spec.
25294 (Invocation::OverloadResolve): Use the above method.
25296 2001-10-31 Ravi Pratap <ravi@ximian.com>
25298 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25299 now take a TypeContainer and a Parameters object.
25301 (ParameterData): Modify return type of ParameterModifier method to be
25302 Parameter.Modifier and not a string.
25304 (ReflectionParameters, InternalParameters): Update accordingly.
25306 * expression.cs (Argument::GetParameterModifier): Same here.
25308 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25309 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25310 symbol in it at all so maybe this is only for now.
25312 2001-10-30 Ravi Pratap <ravi@ximian.com>
25314 * support.cs (InternalParameters): Constructor now takes an extra argument
25315 which is the actual Parameters class.
25317 (ParameterDesc): Update to provide info on ref/out modifiers.
25319 * class.cs (everywhere): Update call to InternalParameters to pass in
25320 the second argument too.
25322 * support.cs (ParameterData): Add ParameterModifier, which is a method
25323 to return the modifier info [ref/out etc]
25325 (InternalParameters, ReflectionParameters): Implement the above.
25327 * expression.cs (Argument::ParameterModifier): Similar function to return
25328 info about the argument's modifiers.
25330 (Invocation::OverloadResolve): Update to take into account matching modifiers
25333 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25334 a new SetFormalParameters object which we pass to InternalParameters.
25336 2001-10-30 Ravi Pratap <ravi@ximian.com>
25338 * expression.cs (NewArray): Merge into the ArrayCreation class.
25340 2001-10-29 Ravi Pratap <ravi@ximian.com>
25342 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25343 NewUserdefinedArray into one as there wasn't much of a use in having
25346 * expression.cs (Argument): Change field's name to ArgType from Type.
25348 (Type): New readonly property which returns the proper type, taking into
25349 account ref/out modifiers.
25351 (everywhere): Adjust code accordingly for the above.
25353 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25354 whether we are emitting for a ref or out parameter.
25356 * expression.cs (Argument::Emit): Use the above field to set the state.
25358 (LocalVariableReference::Emit): Update to honour the flag and emit the
25361 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25363 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25365 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25367 (ReflectionParameters, InternalParameters): Implement the above method.
25369 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25372 (Invocation::FullMethodDesc): Ditto.
25374 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25376 * cs-parser.jay: Add extra production for the second form of array
25379 * expression.cs (ArrayCreation): Update to reflect the above
25382 * Small changes to prepare for Array initialization.
25384 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25386 * typemanager.cs (ImplementsInterface): interface might be null;
25387 Deal with this problem;
25389 Also, we do store negative hits on the cache (null values), so use
25390 this instead of calling t.GetInterfaces on the type everytime.
25392 2001-10-28 Ravi Pratap <ravi@ximian.com>
25394 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25396 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25397 split functionality out into different classes.
25399 (New::FormArrayType): Move into NewBuiltinArray.
25401 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25404 (NewBuiltinArray): New class to handle creation of built-in arrays.
25406 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25407 account creation of one-dimensional arrays.
25409 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25411 (NewUserdefinedArray::DoResolve): Implement.
25413 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25415 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25416 we maintain inside the TypeManager. This is necessary to perform lookups on the
25419 (LookupType): Update to perform GetType on the module builders too.
25421 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25423 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25425 2001-10-23 Ravi Pratap <ravi@ximian.com>
25427 * expression.cs (New::DoResolve): Implement guts of array creation.
25429 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25431 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25433 * expression.cs: Fix bug I introduced lsat night that broke
25436 (Expression.Resolve): Report a 246 error (can not resolve name)
25437 if we find a SimpleName in the stream.
25439 (Expression.ResolveLValue): Ditto.
25441 (Expression.ResolveWithSimpleName): This function is a variant of
25442 ResolveName, this one allows SimpleNames to be returned without a
25443 warning. The only consumer of SimpleNames is MemberAccess
25445 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25447 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25448 might arrive here. I have my doubts that this is correct.
25450 * statement.cs (Lock): Implement lock statement.
25452 * cs-parser.jay: Small fixes to support `lock' and `using'
25454 * cs-tokenizer.cs: Remove extra space
25456 * driver.cs: New flag --checked, allows to turn on integer math
25459 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25460 Threading.Monitor.Exit
25462 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25464 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25465 Expression Class to be IndexerAccess.
25467 Notice that Indexer::DoResolve sets the eclass to Value.
25469 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25471 * class.cs (TypeContainer::Emit): Emit code for indexers.
25473 * assign.cs (IAssignMethod): New interface implemented by Indexers
25474 and Properties for handling assignment.
25476 (Assign::Emit): Simplify and reuse code.
25478 * expression.cs (IndexerAccess, PropertyExpr): Implement
25479 IAssignMethod, clean up old code.
25481 2001-10-22 Ravi Pratap <ravi@ximian.com>
25483 * typemanager.cs (ImplementsInterface): New method to determine if a type
25484 implements a given interface. Provides a nice cache too.
25486 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25489 (ConvertReferenceExplicit): Ditto.
25491 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25492 various methods, with correct names etc.
25494 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25495 Operator.UnaryNegation.
25497 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25498 we have a unary plus or minus operator.
25500 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25503 * everywhere : update accordingly.
25505 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25508 * class.cs (Method::Define): For the case where we are implementing a method
25509 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25510 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25512 2001-10-21 Ravi Pratap <ravi@ximian.com>
25514 * interface.cs (FindMembers): Implement to work around S.R.E
25517 * typemanager.cs (IsInterfaceType): Implement.
25519 (FindMembers): Update to handle interface types too.
25521 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25522 use IsAssignableFrom as that is not correct - it doesn't work.
25524 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25525 and accordingly override EmitStatement.
25527 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25528 using the correct logic :-)
25530 2001-10-19 Ravi Pratap <ravi@ximian.com>
25532 * ../errors/cs-11.cs : Add to demonstrate error -11
25534 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25536 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25537 then pass this as a hint to ResolveLValue.
25539 * expression.cs (FieldExpr): Add Location information
25541 (FieldExpr::LValueResolve): Report assignment to readonly
25544 (Expression::ExprClassFromMemberInfo): Pass location information.
25546 (Expression::ResolveLValue): Add new method that resolves an
25549 (Expression::DoResolveLValue): Default invocation calls
25552 (Indexers): New class used to keep track of indexers in a given
25555 (IStackStore): Renamed from LValue, as it did not really describe
25556 what this did. Also ResolveLValue is gone from this interface and
25557 now is part of Expression.
25559 (ElementAccess): Depending on the element access type
25561 * typemanager.cs: Add `indexer_name_type' as a Core type
25562 (System.Runtime.CompilerServices.IndexerNameAttribute)
25564 * statement.cs (Goto): Take a location.
25566 2001-10-18 Ravi Pratap <ravi@ximian.com>
25568 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25569 if two delegates are compatible.
25571 (NewDelegate::DoResolve): Update to take care of the case when
25572 we instantiate a delegate from another delegate.
25574 * typemanager.cs (FindMembers): Don't even try to look up members
25575 of Delegate types for now.
25577 2001-10-18 Ravi Pratap <ravi@ximian.com>
25579 * delegate.cs (NewDelegate): New class to take care of delegate
25582 * expression.cs (New): Split the delegate related code out into
25583 the NewDelegate class.
25585 * delegate.cs (DelegateInvocation): New class to handle delegate
25588 * expression.cs (Invocation): Split out delegate related code into
25589 the DelegateInvocation class.
25591 2001-10-17 Ravi Pratap <ravi@ximian.com>
25593 * expression.cs (New::DoResolve): Implement delegate creation fully
25594 and according to the spec.
25596 (New::DoEmit): Update to handle delegates differently.
25598 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25599 because of which we were printing out arguments in reverse order !
25601 * delegate.cs (VerifyMethod): Implement to check if the given method
25602 matches the delegate.
25604 (FullDelegateDesc): Implement.
25606 (VerifyApplicability): Implement.
25608 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25609 delegate invocations too.
25611 (Invocation::Emit): Ditto.
25613 * ../errors/cs1593.cs : Added.
25615 * ../errors/cs1594.cs : Added.
25617 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25619 2001-10-16 Ravi Pratap <ravi@ximian.com>
25621 * typemanager.cs (intptr_type): Core type for System.IntPtr
25623 (InitCoreTypes): Update for the same.
25625 (iasyncresult_type, asynccallback_type): Ditto.
25627 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25630 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25633 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25634 the builders for the 4 members of a delegate type :-)
25636 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25639 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25641 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25643 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25645 * statement.cs (Break::Emit): Implement.
25646 (Continue::Emit): Implement.
25648 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25649 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25650 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25651 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25654 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25655 properties that track the label for the current loop (begin of the
25656 loop and end of the loop).
25658 2001-10-15 Ravi Pratap <ravi@ximian.com>
25660 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25661 use of emitting anything at all.
25663 * class.cs, rootcontext.cs : Get rid of calls to the same.
25665 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25667 (Populate): Define the constructor correctly and set the implementation
25670 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25673 (AddDelegateType): Implement.
25675 (IsDelegateType): Implement helper method.
25677 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25679 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25680 and accordingly handle it.
25682 * delegate.cs (Populate): Take TypeContainer argument.
25683 Implement bits to define the Invoke method. However, I still haven't figured out
25684 how to take care of the native int bit :-(
25686 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25687 Qualify the name of the delegate, not its return type !
25689 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25692 (StandardConversionExists): Checking for array types turns out to be recursive.
25694 (ConvertReferenceExplicit): Implement array conversion.
25696 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25698 2001-10-12 Ravi Pratap <ravi@ximian.com>
25700 * cs-parser.jay (delegate_declaration): Store the fully qualified
25701 name as it is a type declaration.
25703 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25706 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25707 as TypeContainer::DefineType.
25709 (Populate): Method in which all the definition of the various methods (Invoke)
25712 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25715 (CloseDelegate): Finally creates the delegate.
25717 * class.cs (TypeContainer::DefineType): Update to define delegates.
25718 (Populate, Emit and CloseType): Do the same thing here too.
25720 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25721 delegates in all these operations.
25723 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25725 * expression.cs: LocalTemporary: a new expression used to
25726 reference a temporary that has been created.
25728 * assign.cs: Handle PropertyAccess back here, so that we can
25729 provide the proper semantic access to properties.
25731 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25732 a few more explicit conversions.
25734 * modifiers.cs: `NEW' modifier maps to HideBySig.
25736 * expression.cs (PropertyExpr): Make this into an
25737 ExpressionStatement, and support the EmitStatement code path.
25739 Perform get/set error checking, clean up the interface.
25741 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25742 them into toplevel access objects.
25744 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25746 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25749 * typemanager.cs: Keep track here of our PropertyBuilders again to
25750 work around lameness in SRE.
25752 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25754 * expression.cs (LValue::LValueResolve): New method in the
25755 interface, used to perform a second resolution pass for LValues.
25757 (This::DoResolve): Catch the use of this in static methods.
25759 (This::LValueResolve): Implement.
25761 (This::Store): Remove warning, assigning to `this' in structures
25764 (Invocation::Emit): Deal with invocation of
25765 methods on value types. We need to pass the address to structure
25766 methods rather than the object itself. (The equivalent code to
25767 emit "this" for structures leaves the entire structure on the
25768 stack instead of a pointer to it).
25770 (ParameterReference::DoResolve): Compute the real index for the
25771 argument based on whether the method takes or not a `this' pointer
25772 (ie, the method is static).
25774 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25775 value types returned from functions when we need to invoke a
25776 method on the sturcture.
25779 2001-10-11 Ravi Pratap <ravi@ximian.com>
25781 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25782 defining the type in the Modulebuilder or Typebuilder. This is to take
25783 care of nested types which need to be defined on the TypeBuilder using
25784 DefineNestedMethod.
25786 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25787 methods in RootContext, only ported to be part of TypeContainer.
25789 (TypeContainer::GetInterfaceOrClass): Ditto.
25791 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25793 * interface.cs (Interface::DefineInterface): New method. Does exactly
25794 what RootContext.CreateInterface did earlier, only it takes care of nested types
25797 (Interface::GetInterfaces): Move from RootContext here and port.
25799 (Interface::GetInterfaceByName): Same here.
25801 * rootcontext.cs (ResolveTree): Re-write.
25803 (PopulateTypes): Re-write.
25805 * class.cs (TypeContainer::Populate): Populate nested types too.
25806 (TypeContainer::Emit): Emit nested members too.
25808 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25809 instead just use the name argument passed in as it is already fully
25812 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25813 to TypeContainer mapping to see if a type is user-defined.
25815 * class.cs (TypeContainer::CloseType): Implement.
25817 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25818 the default constructor.
25820 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25823 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25825 * interface.cs (CloseType): Create the type here.
25827 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25830 Remove all the methods which are now in TypeContainer.
25832 2001-10-10 Ravi Pratap <ravi@ximian.com>
25834 * delegate.cs (Define): Re-write bits to define the delegate
25837 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25839 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25841 * expression.cs (ImplicitReferenceConversion): handle null as well
25842 as a source to convert to any reference type.
25844 * statement.cs (Return): Perform any implicit conversions to
25845 expected return type.
25847 Validate use of return statement.
25849 * codegen.cs (EmitContext): Pass the expected return type here.
25851 * class.cs (Method, Constructor, Property): Pass expected return
25852 type to EmitContext.
25854 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25856 * expression.cs: Make DoResolve take an EmitContext instead of a
25859 Replaced `l' and `location' for `loc', for consistency.
25861 (Error, Warning): Remove unneeded Tc argument.
25863 * assign.cs, literal.cs, constant.cs: Update to new calling
25866 * codegen.cs: EmitContext now contains a flag indicating whether
25867 code is being generated in a static method or not.
25869 * cs-parser.jay: DecomposeQI, new function that replaces the old
25870 QualifiedIdentifier. Now we always decompose the assembled
25871 strings from qualified_identifier productions into a group of
25874 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25876 * rootcontext.cs: Deal with field-less struct types correctly now
25877 by passing the size option to Define Type.
25879 * class.cs: Removed hack that created one static field.
25881 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25883 * statement.cs: Moved most of the code generation here.
25885 2001-10-09 Ravi Pratap <ravi@ximian.com>
25887 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25890 (ElementAccess): Remove useless bits for now - keep checks as the spec
25893 2001-10-08 Ravi Pratap <ravi@ximian.com>
25895 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25896 and start performing checks according to the spec.
25898 2001-10-07 Ravi Pratap <ravi@ximian.com>
25900 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25901 rank_specifiers instead.
25903 (rank_specifiers): Change the order in which the rank specifiers are stored
25905 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25907 * expression.cs (ElementAccess): Implement the LValue interface too.
25909 2001-10-06 Ravi Pratap <ravi@ximian.com>
25911 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25912 except that user defined conversions are not included.
25914 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25915 perform the conversion of the return type, if necessary.
25917 (New::DoResolve): Check whether we are creating an array or an object
25918 and accordingly do the needful.
25920 (New::Emit): Same here.
25922 (New::DoResolve): Implement guts of array creation.
25924 (New::FormLookupType): Helper function.
25926 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25928 * codegen.cs: Removed most of the code generation here, and move the
25929 corresponding code generation bits to the statement classes.
25931 Added support for try/catch/finalize and throw.
25933 * cs-parser.jay: Added support for try/catch/finalize.
25935 * class.cs: Catch static methods having the flags override,
25936 virtual or abstract.
25938 * expression.cs (UserCast): This user cast was not really doing
25939 what it was supposed to do. Which is to be born in fully resolved
25940 state. Parts of the resolution were being performed at Emit time!
25944 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25946 * expression.cs: Implicity convert the result from UserCast.
25948 2001-10-05 Ravi Pratap <ravi@ximian.com>
25950 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25951 prevented it from working correctly.
25953 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25954 merely ConvertImplicit.
25956 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25958 * typemanager.cs: Make the LookupTypeContainer function static,
25959 and not per-instance.
25961 * class.cs: Make static FindMembers (the one that takes a Type
25964 * codegen.cs: Add EmitForeach here.
25966 * cs-parser.jay: Make foreach a toplevel object instead of the
25967 inline expansion, as we need to perform semantic analysis on it.
25969 2001-10-05 Ravi Pratap <ravi@ximian.com>
25971 * expression.cs (Expression::ImplicitUserConversion): Rename to
25972 UserDefinedConversion.
25974 (Expression::UserDefinedConversion): Take an extra argument specifying
25975 whether we look for explicit user conversions too.
25977 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25979 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25981 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25982 with the appropriate arguments.
25984 * cs-parser.jay (cast_expression): Record location too.
25986 * expression.cs (Cast): Record location info.
25988 (Expression::ConvertExplicit): Take location argument.
25990 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25991 to determine if we are doing explicit conversions.
25993 (UserCast::Emit): Update accordingly.
25995 (Expression::ConvertExplicit): Report an error if everything fails.
25997 * ../errors/cs0030.cs : Add.
25999 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26001 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26002 virtual and newslot bits.
26004 * class.cs (TypeContainer::RegisterRequiredImplementations):
26005 Record methods we need.
26007 (TypeContainer::MakeKey): Helper function to make keys for
26008 MethodBases, since the Methodbase key is useless.
26010 (TypeContainer::Populate): Call RegisterRequiredImplementations
26011 before defining the methods.
26013 Create a mapping for method_builders_to_methods ahead of time
26014 instead of inside a tight loop.
26016 (::RequireMethods): Accept an object as the data to set into the
26017 hashtable so we can report interface vs abstract method mismatch.
26019 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26021 * report.cs: Make all of it static.
26023 * rootcontext.cs: Drop object_type and value_type computations, as
26024 we have those in the TypeManager anyways.
26026 Drop report instance variable too, now it is a global.
26028 * driver.cs: Use try/catch on command line handling.
26030 Add --probe option to debug the error reporting system with a test
26033 * report.cs: Add support for exiting program when a probe
26034 condition is reached.
26036 2001-10-03 Ravi Pratap <ravi@ximian.com>
26038 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26039 we do a forcible conversion regardless of type, to check if
26040 ForceConversion returns a null.
26042 (Binary::error19): Use location to report error.
26044 (Unary::error23): Use location here too.
26046 * ../errors/cs0019.cs : Check in.
26048 * ../errors/cs0023.cs : Check in.
26050 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26051 case of a non-null MethodInfo object with a length of 0 !
26053 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26054 an applicable member - according to the spec :-)
26055 Also fix logic to find members in base types.
26057 (Unary::ResolveOperator): Same here.
26059 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26060 as I was getting thoroughly confused between this and error19 :-)
26062 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26063 (::FindMostEncompassedType): Implement.
26064 (::FindMostEncompassingType): Implement.
26065 (::StandardConversionExists): Implement.
26067 (UserImplicitCast): Re-vamp. We now need info about most specific
26068 source and target types so that we can do the necessary conversions.
26070 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26071 mathematical union with no duplicates.
26073 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26075 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26076 in order from base classes to child classes, so that we can in
26077 child classes look up in our parent for method names and
26078 attributes (required for handling abstract, virtual, new, override
26079 constructs: we need to instrospect our base class, and if we dont
26080 populate the classes in order, the introspection might be
26081 incorrect. For example, a method could query its parent before
26082 the parent has any methods and would determine that the parent has
26083 no abstract methods (while it could have had them)).
26085 (RootContext::CreateType): Record the order in which we define the
26088 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26090 * class.cs (TypeContainer::Populate): Also method definitions can
26091 fail now, keep track of this.
26093 (TypeContainer::FindMembers): Implement support for
26094 DeclaredOnly/noDeclaredOnly flag.
26096 (Constructor::Emit) Return the ConstructorBuilder.
26098 (Method::Emit) Return the MethodBuilder.
26099 Check for abstract or virtual methods to be public.
26101 * rootcontext.cs (RootContext::CreateType): Register all the
26102 abstract methods required for the class to be complete and the
26103 interface methods that must be implemented.
26105 * cs-parser.jay: Report error 501 (method requires body if it is
26106 not marked abstract or extern).
26108 * expression.cs (TypeOf::Emit): Implement.
26110 * typemanager.cs: runtime_handle_type, new global type.
26112 * class.cs (Property::Emit): Generate code for properties.
26114 2001-10-02 Ravi Pratap <ravi@ximian.com>
26116 * expression.cs (Unary::ResolveOperator): Find operators on base type
26117 too - we now conform exactly to the spec.
26119 (Binary::ResolveOperator): Same here.
26121 * class.cs (Operator::Define): Fix minor quirk in the tests.
26123 * ../errors/cs0215.cs : Added.
26125 * ../errors/cs0556.cs : Added.
26127 * ../errors/cs0555.cs : Added.
26129 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26131 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26132 single integer which is really efficient
26134 2001-10-01 Ravi Pratap <ravi@ximian.com>
26136 * expression.cs (Expression::ImplicitUserConversion): Use location
26137 even in the case when we are examining True operators.
26139 * class.cs (Operator::Define): Perform extensive checks to conform
26140 with the rules for operator overloading in the spec.
26142 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26143 some of the other conversions mentioned in the spec.
26145 * typemanager.cs (array_type): New static member for the System.Array built-in
26148 (cloneable_interface): For System.ICloneable interface.
26150 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26151 we start resolving the tree and populating types.
26153 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26155 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26157 * expression.cs (Expression::ExprClassFromMemberInfo,
26158 Expression::Literalize): Create literal expressions from
26159 FieldInfos which are literals.
26161 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26162 type casts, because they were wrong. The test suite in tests
26165 (ImplicitNumericConversion): ushort to ulong requires a widening
26168 Int32 constant to long requires widening cast as well.
26170 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26171 for integers because the type on the stack is not i4.
26173 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26175 * expression.cs (report118): require location argument.
26177 * parameter.cs: Do not dereference potential null value.
26179 * class.cs: Catch methods that lack the `new' keyword when
26180 overriding a name. Report warnings when `new' is used without
26181 anything being there to override.
26183 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26185 * class.cs: Only add constructor to hashtable if it is non-null
26186 (as now constructors can fail on define).
26188 (TypeManager, Class, Struct): Take location arguments.
26190 Catch field instance initialization in structs as errors.
26192 accepting_filter: a new filter for FindMembers that is static so
26193 that we dont create an instance per invocation.
26195 (Constructor::Define): Catch errors where a struct constructor is
26198 * cs-parser.jay: Pass location information for various new
26201 * delegate.cs (Delegate): take a location argument.
26203 * driver.cs: Do not call EmitCode if there were problesm in the
26204 Definition of the types, as many Builders wont be there.
26206 * decl.cs (Decl::Decl): Require a location argument.
26208 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26209 into integers, and find the most appropiate integer for it.
26211 * literal.cs: Implement ULongLiteral.
26213 * rootcontext.cs: Provide better information about the location of
26214 failure when CreateType fails.
26216 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26218 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26221 * expression.cs (Binary::CheckShiftArguments): Add missing type
26223 (Binary::ResolveOperator): Add type to the logical and and logical
26224 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26227 (Binary::DoNumericPromotions): In the case where either argument
26228 is ulong (and most signed types combined with ulong cause an
26229 error) perform implicit integer constant conversions as well.
26231 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26233 * expression.cs (UserImplicitCast): Method should always be
26235 (Invocation::BetterConversion): Simplified test for IntLiteral.
26237 (Expression::ImplicitNumericConversion): Split this routine out.
26238 Put the code that performs implicit constant integer conversions
26241 (Expression::Resolve): Become a wrapper around DoResolve so we can
26242 check eclass and type being set after resolve.
26244 (Invocation::Badness): Remove this dead function
26246 (Binary::ResolveOperator): Do not compute the expensive argumnets
26247 unless we have a union for it.
26249 (Probe::Emit): Is needs to do an isinst and then
26250 compare against null.
26252 (::CanConvert): Added Location argument. If the Location argument
26253 is null (Location.Null), then we do not report errors. This is
26254 used by the `probe' mechanism of the Explicit conversion. We do
26255 not want to generate an error for something that the user
26256 explicitly requested to be casted. But the pipeline for an
26257 explicit cast first tests for potential implicit casts.
26259 So for now, if the Location is null, it means `Probe only' to
26260 avoid adding another argument. Might have to revise this
26263 (ClassCast): New class used to type cast objects into arbitrary
26264 classes (used in Explicit Reference Conversions).
26266 Implement `as' as well.
26268 Reverted all the patches from Ravi below: they were broken:
26270 * The use of `level' as a mechanism to stop recursive
26271 invocations is wrong. That was there just to catch the
26272 bug with a strack trace but not as a way of addressing
26275 To fix the problem we have to *understand* what is going
26276 on and the interactions and come up with a plan, not
26277 just get things going.
26279 * The use of the type conversion cache that I proposed
26280 last night had an open topic: How does this work across
26281 protection domains. A user defined conversion might not
26282 be public in the location where we are applying the
26283 conversion, a different conversion might be selected
26284 (ie, private A->B (better) but public B->A (worse),
26285 inside A, A->B applies, but outside it, B->A will
26288 * On top of that (ie, even if the above is solved),
26289 conversions in a cache need to be abstract. Ie, `To
26290 convert from an Int to a Short use an OpcodeCast', not
26291 `To convert from an Int to a Short use the OpcodeCast on
26292 the variable 5' (which is what this patch was doing).
26294 2001-09-28 Ravi Pratap <ravi@ximian.com>
26296 * expression.cs (Invocation::ConversionExists): Re-write to use
26297 the conversion cache
26299 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26300 cache all conversions done, not just user-defined ones.
26302 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26303 to determine if a conversion exists instead of acutually trying to
26304 perform the conversion. It's faster too.
26306 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26307 and only then attempt the implicit conversion.
26309 2001-09-28 Ravi Pratap <ravi@ximian.com>
26311 * expression.cs (ConvertImplicit): Use a cache for conversions
26312 already found. Check level of recursion and bail out if necessary.
26314 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26316 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26317 Export standard methods that we expect for string operations.
26319 * statement.cs (Block::UsageWarning): Track usage of variables and
26320 report the errors for not used variables.
26322 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26325 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26327 * codegen.cs: remove unnneded code
26329 * expression.cs: Removed BuiltinTypeAccess class
26331 Fix the order in which implicit conversions are
26334 The previous fixed dropped support for boxed conversions (adding a
26335 test to the test suite now)
26337 (UserImplicitCast::CanConvert): Remove test for source being null,
26338 that code is broken. We should not feed a null to begin with, if
26339 we do, then we should track the bug where the problem originates
26340 and not try to cover it up here.
26342 Return a resolved expression of type UserImplicitCast on success
26343 rather than true/false. Ravi: this is what I was talking about,
26344 the pattern is to use a static method as a "constructor" for
26347 Also, do not create arguments until the very last minute,
26348 otherwise we always create the arguments even for lookups that
26349 will never be performed.
26351 (UserImplicitCast::Resolve): Eliminate, objects of type
26352 UserImplicitCast are born in a fully resolved state.
26354 * typemanager.cs (InitCoreTypes): Init also value_type
26355 (System.ValueType).
26357 * expression.cs (Cast::Resolve): First resolve the child expression.
26359 (LValue): Add new method AddressOf to be used by
26362 Change the argument of Store to take an EmitContext instead of an
26363 ILGenerator, because things like FieldExpr need to be able to call
26364 their children expression to generate the instance code.
26366 (Expression::Error, Expression::Warning): Sugar functions for
26369 (Expression::MemberLookup): Accept a TypeContainer instead of a
26370 Report as the first argument.
26372 (Expression::ResolvePrimary): Killed. I still want to improve
26373 this as currently the code is just not right.
26375 (Expression::ResolveMemberAccess): Simplify, but it is still
26378 (Unary::Resolve): Catch errors in AddressOf operators.
26380 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26381 index to a byte for the short-version, or the compiler will choose
26382 the wrong Emit call, which generates the wrong data.
26384 (ParameterReference::Emit, ::Store): same.
26386 (FieldExpr::AddressOf): Implement.
26388 * typemanager.cs: TypeManager: made public variable instead of
26391 * driver.cs: document --fatal.
26393 * report.cs (ErrorMessage, WarningMessage): new names for the old
26394 Error and Warning classes.
26396 * cs-parser.jay (member_access): Turn built-in access to types
26397 into a normal simplename
26399 2001-09-27 Ravi Pratap <ravi@ximian.com>
26401 * expression.cs (Invocation::BetterConversion): Fix to cope
26402 with q being null, since this was introducing a bug.
26404 * expression.cs (ConvertImplicit): Do built-in conversions first.
26406 2001-09-27 Ravi Pratap <ravi@ximian.com>
26408 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26410 2001-09-27 Ravi Pratap <ravi@ximian.com>
26412 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26413 I had introduced long ago (what's new ?).
26415 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26416 the work of all the checking.
26417 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26418 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26420 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26421 that is the right way.
26423 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26424 overloading resolution. Use everywhere instead of cutting and pasting code.
26426 (Binary::ResolveOperator): Use MakeUnionSet.
26428 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26429 we have to convert to bool types. Not complete yet.
26431 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26433 * typemanager.cs (TypeManager::CSharpName): support ushort.
26435 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26436 to provide an expression that performsn an implicit constant int
26437 conversion (section 6.1.6).
26438 (Expression::ConvertImplicitRequired): Reworked to include
26439 implicit constant expression conversions.
26441 (Expression::ConvertNumericExplicit): Finished.
26443 (Invocation::Emit): If InstanceExpression is null, then it means
26444 that we perform a call on this.
26446 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26448 * expression.cs (Unary::Emit): Remove some dead code.
26449 (Probe): Implement Resolve and Emit for `is'.
26450 (Expression::ConvertImplicitRequired): Attempt to do constant
26451 expression conversions here. Maybe should be moved to
26452 ConvertImplicit, but I am not sure.
26453 (Expression::ImplicitLongConstantConversionPossible,
26454 Expression::ImplicitIntConstantConversionPossible): New functions
26455 that tell whether is it possible to apply an implicit constant
26456 expression conversion.
26458 (ConvertNumericExplicit): Started work on explicit numeric
26461 * cs-parser.jay: Update operator constants.
26463 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26464 (Parameters::GetSignature): Hook up VerifyArgs here.
26465 (Parameters::VerifyArgs): Verifies that no two arguments have the
26468 * class.cs (Operator): Update the operator names to reflect the
26469 ones that the spec expects (as we are just stringizing the
26472 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26473 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26474 previous usage did only work for our methods.
26475 (Expression::ConvertImplicit): Handle decimal implicit numeric
26476 conversions as well.
26477 (Expression::InternalTypeConstructor): Used to invoke constructors
26478 on internal types for default promotions.
26480 (Unary::Emit): Implement special handling for the pre/post
26481 increment/decrement for overloaded operators, as they need to have
26482 the same semantics as the other operators.
26484 (Binary::ResolveOperator): ditto.
26485 (Invocation::ConversionExists): ditto.
26486 (UserImplicitCast::Resolve): ditto.
26488 2001-09-26 Ravi Pratap <ravi@ximian.com>
26490 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26491 operator, return after emitting body. Regression tests pass again !
26493 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26494 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26495 (Invocation::OverloadResolve): Ditto.
26496 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26498 * everywhere : update calls to the above methods accordingly.
26500 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26502 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26504 * expression.cs (ExpressionStatement): New base class used for
26505 expressions that can appear in statements, so that we can provide
26506 an alternate path to generate expression that do not leave a value
26509 (Expression::Emit, and all the derivatives): We no longer return
26510 whether a value is left on the stack or not. Every expression
26511 after being emitted leaves a single value on the stack.
26513 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26514 facilties of ExpressionStatement if possible.
26516 * cs-parser.jay: Update statement_expression.
26518 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26520 * driver.cs: Change the wording of message
26522 2001-09-25 Ravi Pratap <ravi@ximian.com>
26524 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26525 the type of the expression to the return type of the method if
26526 we have an overloaded operator match ! The regression tests pass again !
26527 (Unary::ResolveOperator): Ditto.
26529 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26530 to find "op_Implicit", not "implicit" ;-)
26531 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26532 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26534 * everywhere : Correct calls to the above accordingly.
26536 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26537 (ConvertImplicit): Do user-defined conversion if it exists.
26539 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26541 * assign.cs: track location.
26542 (Resolve): Use implicit conversions on assignment.
26544 * literal.cs: Oops. Not good, Emit of short access values should
26545 pass (Bytes) or the wrong argument will be selected.
26547 * expression.cs (Unary::Emit): Emit code for -expr.
26549 (Unary::ResolveOperator): Handle `Substract' for non-constants
26550 (substract from zero from the non-constants).
26551 Deal with Doubles as well.
26553 (Expression::ConvertImplicitRequired): New routine that reports an
26554 error if no implicit conversion exists.
26556 (Invocation::OverloadResolve): Store the converted implicit
26557 expressions if we make them
26559 2001-09-24 Ravi Pratap <ravi@ximian.com>
26561 * class.cs (ConstructorInitializer): Take a Location argument.
26562 (ConstructorBaseInitializer): Same here.
26563 (ConstructorThisInitializer): Same here.
26565 * cs-parser.jay : Update all calls accordingly.
26567 * expression.cs (Unary, Binary, New): Take location argument.
26568 Update accordingly everywhere.
26570 * cs-parser.jay : Update all calls to the above to take a location
26573 * class.cs : Ditto.
26575 2001-09-24 Ravi Pratap <ravi@ximian.com>
26577 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26578 (Invocation::BetterConversion): Same here
26579 (Invocation::ConversionExists): Ditto.
26581 (Invocation::ConversionExists): Implement.
26583 2001-09-22 Ravi Pratap <ravi@ximian.com>
26585 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26586 Also take an additional TypeContainer argument.
26588 * All over : Pass in TypeContainer as argument to OverloadResolve.
26590 * typemanager.cs (CSharpName): Update to check for the string type and return
26593 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26596 2001-09-21 Ravi Pratap <ravi@ximian.com>
26598 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26599 (Invocation::BetterFunction): Implement.
26600 (Invocation::BetterConversion): Implement.
26601 (Invocation::ConversionExists): Skeleton, no implementation yet.
26603 Okay, things work fine !
26605 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26607 * typemanager.cs: declare and load enum_type, delegate_type and
26610 * expression.cs (Expression::Emit): Now emit returns a value that
26611 tells whether a value is left on the stack or not. This strategy
26612 might be reveted tomorrow with a mechanism that would address
26613 multiple assignments.
26614 (Expression::report118): Utility routine to report mismatches on
26617 (Unary::Report23): Report impossible type/operator combination
26620 (Unary::IsIncrementableNumber): Whether the type can be
26621 incremented or decremented with add.
26622 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26624 (Unary::ResolveOperator): Implement ++, !, ~,
26626 (Invocation::Emit): Deal with new Emit convetion.
26628 * All Expression derivatives: Updated their Emit method to return
26629 whether they leave values on the stack or not.
26631 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26632 stack for expressions that are statements.
26634 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26636 * expression.cs (LValue): New interface. Must be implemented by
26638 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26641 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26642 interface for generating code, simplifies the code.
26644 2001-09-20 Ravi Pratap <ravi@ximian.com>
26646 * expression.cs (everywhere): Comment out return statements in ::Resolve
26647 methods to avoid the warnings.
26649 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26651 * driver.cs (parse): Report error 2001 if we can not open the
26654 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26657 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26660 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26661 otherwise nested blocks end up with the same index.
26663 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26665 * expression.cs: Instead of having FIXMEs in the Resolve
26666 functions, throw exceptions so it is obvious that we are facing a
26669 * cs-parser.jay (invocation_expression): Pass Location information.
26671 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26672 Use a basename for those routines because .NET does not like paths
26675 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26678 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26680 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26681 are loading the correct data types (throws an exception if not).
26682 (TypeManager::InitCoreTypes): Use CoreLookupType
26684 * expression.cs (Unary::ResolveOperator): return the child
26685 expression for expressions which are just +expr.
26686 (Unary::ResolveOperator): Return negative literals for -LITERAL
26687 expressions (otherwise they are Unary {Literal}).
26688 (Invocation::Badness): Take into account `Implicit constant
26689 expression conversions'.
26691 * literal.cs (LongLiteral): Implement long literal class.
26692 (IntLiteral): export the `Value' of the intliteral.
26694 2001-09-19 Ravi Pratap <ravi@ximian.com>
26696 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26698 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26699 instead of 'Operator'
26701 * expression.cs (Binary::ResolveOperator): Update accordingly.
26702 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26705 * cs-parser.jay (unary_expression): Update to use the new names.
26707 * gen-treedump.cs (GetUnary): Same here.
26709 * expression.cs (Unary::Resolve): Implement.
26710 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26711 operators are found instead of making noise ;-)
26712 (Unary::ResolveOperator): New method to do precisely the same thing which
26713 Binary::ResolveOperator does for Binary expressions.
26714 (Unary.method, .Arguments): Add.
26715 (Unary::OperName): Implement.
26716 (Unary::ForceConversion): Copy and Paste !
26718 * class.cs (Operator::Define): Fix a small bug for the case when we have
26721 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26722 for the inbuilt operators. Only overloading works for now ;-)
26724 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26726 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26727 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26729 * expression.cs (This::Emit): Implement.
26730 (This::Resolve): Implement.
26731 (TypeOf:Resolve): Implement.
26732 (Expression::ResolveSimpleName): Add an implicit this to instance
26734 (MemberAccess::Resolve): Deal with Parameters and Fields.
26735 Bind instance variable to Field expressions.
26736 (FieldExpr::Instance): New field used to track the expression that
26737 represents the object instance.
26738 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26740 (FieldExpr::Emit): Implement.
26742 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26743 the last instruction contains a return opcode to avoid generating
26744 the last `ret' instruction (this generates correct code, and it is
26745 nice to pass the peverify output).
26747 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26748 initializer for static and instance variables.
26749 (Constructor::Emit): Allow initializer to be null in the case of
26750 static constructors. Only emit initializer for instance
26753 (TypeContainer::FindMembers): Return a null array if there are no
26756 Also fix the code for the MemberTypes.Method branch, as it was not
26757 scanning that for operators (or tried to access null variables before).
26759 * assign.cs (Assign::Emit): Handle instance and static fields.
26763 * driver.cs: Stop compilation if there are parse errors.
26765 * cs-parser.jay (constructor_declaration): Provide default base
26766 initializer for non-static constructors.
26767 (constructor_declarator): Do not provide a default base
26768 initializers if none was specified.
26769 Catch the fact that constructors should not have parameters.
26771 * class.cs: Do not emit parent class initializers for static
26772 constructors, that should be flagged as an error.
26774 2001-09-18 Ravi Pratap <ravi@ximian.com>
26776 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26777 Move back code into TypeContainer::Populate.
26779 2001-09-18 Ravi Pratap <ravi@ximian.com>
26781 * class.cs (TypeContainer::AddConstructor): Fix the check to
26782 compare against Name, not Basename.
26783 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26785 * cs-parser.jay : Update accordingly.
26787 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26788 for methods, don't forget to look into the operators too.
26789 (RegisterMethodBuilder): Helper method to take care of this for
26790 methods, constructors and operators.
26791 (Operator::Define): Completely revamp.
26792 (Operator.OperatorMethod, MethodName): New fields.
26793 (TypeContainer::Populate): Move the registering of builders into
26794 RegisterMethodBuilder.
26795 (Operator::Emit): Re-write.
26797 * expression.cs (Binary::Emit): Comment out code path to emit method
26798 invocation stuff for the case when we have a user defined operator. I am
26799 just not able to get it right !
26801 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26803 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26806 (Expression::MemberLookup): Provide a version that allows to
26807 specify the MemberTypes and BindingFlags.
26809 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26810 so it was not fetching variable information from outer blocks.
26812 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26813 Beforefieldinit as it was buggy.
26815 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26816 that Ravi put here.
26818 * class.cs (Constructor::Emit): Only emit if block is not null.
26819 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26820 deal with this by semantically definining it as if the user had
26823 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26824 constructors as we now "emit" them at a higher level.
26826 (TypeContainer::DefineDefaultConstructor): Used to define the
26827 default constructors if none was provided.
26829 (ConstructorInitializer): Add methods Resolve and Emit.
26831 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26833 2001-09-17 Ravi Pratap <ravi@ximian.com>
26835 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26836 the default constructor builder with our hashtable for methodbuilders
26839 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26840 and argument_count is 0 in which case we have a match.
26841 (Binary::ResolveOperator): More null checking and miscellaneous coding
26844 2001-09-17 Ravi Pratap <ravi@ximian.com>
26846 * rootcontext.cs (IsNameSpace): Compare against null.
26848 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26850 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26851 and Unary::Operator.
26853 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26856 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26857 we have overloaded operators.
26858 (Binary::ResolveOperator): Implement the part which does the operator overload
26861 * class.cs (Operator::Emit): Implement.
26862 (TypeContainer::Emit): Emit the operators we have too.
26864 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26865 the case when we have a user-defined operator.
26867 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26869 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26871 2001-09-16 Ravi Pratap <ravi@ximian.com>
26873 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26874 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26875 (Constructor::Emit): Implement.
26876 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26877 if we have no work to do.
26878 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26881 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26882 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26884 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26887 2001-09-15 Ravi Pratap <ravi@ximian.com>
26889 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26891 (Tree::RecordNamespace): Method to do what the name says ;-)
26892 (Tree::Namespaces): Property to get at the namespaces hashtable.
26894 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26897 * rootcontext.cs (IsNamespace): Fixed it :-)
26899 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26901 * class.cs (TypeContainer::FindMembers): Add support for
26903 (MethodCore): New class that encapsulates both the shared aspects
26904 of a Constructor and a Method.
26905 (Method, Constructor): Factored pieces into MethodCore.
26907 * driver.cs: Added --fatal which makes errors throw exceptions.
26908 Load System assembly as well as part of the standard library.
26910 * report.cs: Allow throwing exceptions on errors for debugging.
26912 * modifiers.cs: Do not use `parent', instead use the real type
26913 container to evaluate permission settings.
26915 * class.cs: Put Ravi's patch back in. He is right, and we will
26916 have to cope with the
26918 2001-09-14 Ravi Pratap <ravi@ximian.com>
26920 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26921 FamORAssem, not FamANDAssem.
26923 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26925 * driver.cs: Added --parse option that only parses its input files
26928 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26929 incorrect. IsTopLevel is not used to tell whether an object is
26930 root_types or not (that can be achieved by testing this ==
26931 root_types). But to see if this is a top-level *class* (not
26932 necessarly our "toplevel" container).
26934 2001-09-14 Ravi Pratap <ravi@ximian.com>
26936 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26937 parent instead of a direct call to GetType.
26939 2001-09-14 Ravi Pratap <ravi@ximian.com>
26941 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26942 Modifiers.TypeAttr. This should just be a call to that method.
26944 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26945 object so that we can determine if we are top-level or not.
26947 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26950 * enum.cs (Enum::Define): Ditto.
26952 * modifiers.cs (FieldAttr): Re-write.
26954 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26955 (TypeContainer::HaveStaticConstructor): New property to provide access
26956 to precisely that info.
26958 * modifiers.cs (MethodAttr): Re-write.
26959 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26961 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26962 of top-level types as claimed.
26964 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26966 * expression.cs (MemberLookup): Fruitless attempt to lookup
26967 constructors. Maybe I need to emit default constructors? That
26968 might be it (currently .NET emits this for me automatically).
26969 (Invocation::OverloadResolve): Cope with Arguments == null.
26970 (Invocation::EmitArguments): new function, shared by the new
26971 constructor and us.
26972 (Invocation::Emit): Handle static and instance methods. Emit
26973 proper call instruction for virtual or non-virtual invocations.
26974 (New::Emit): Implement.
26975 (New::Resolve): Implement.
26976 (MemberAccess:Resolve): Implement.
26977 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26978 to track instances.
26979 (FieldExpr::Resolve): Set type.
26981 * support.cs: Handle empty arguments.
26983 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26984 SimpleLookup): Auxiliary routines to help parse a qualifier
26987 Update qualifier_identifier rule.
26989 * codegen.cs: Removed debugging messages.
26991 * class.cs: Make this a global thing, this acts just as a "key" to
26992 objects that we might have around.
26994 (Populate): Only initialize method_builders_to_methods once.
26996 * expression.cs (PropertyExpr): Initialize type from the
26999 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27000 Resolve pattern. Attempt to implicitly convert value to boolean.
27003 * expression.cs: Set the type for the int32/int32 argument case.
27004 (Binary::ResolveOperator): Set the return type to boolean for
27005 comparission operators
27007 * typemanager.cs: Remove debugging print code.
27009 (Invocation::Resolve): resolve type.
27011 * class.cs: Allocate a MemberInfo of the correct size, as the code
27012 elsewhere depends on the test to reflect the correct contents.
27014 (Method::) Keep track of parameters, due to System.Reflection holes
27016 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27019 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27020 of the exact size and return that.
27022 (Class::LookupMethodByBuilder): New function that maps
27023 MethodBuilders to its methods. Required to locate the information
27024 on methods because System.Reflection bit us again.
27026 * support.cs: New file, contains an interface ParameterData and
27027 two implementations: ReflectionParameters and InternalParameters
27028 used to access Parameter information. We will need to grow this
27031 * expression.cs (Invocation::GetParameterData): implement a cache
27032 and a wrapper around the ParameterData creation for methods.
27033 (Invocation::OverloadResolve): Use new code.
27035 2001-09-13 Ravi Pratap <ravi@ximian.com>
27037 * class.cs (TypeContainer::EmitField): Remove and move into
27038 (Field::Define): here and modify accordingly.
27039 (Field.FieldBuilder): New member.
27040 (TypeContainer::Populate): Update accordingly.
27041 (TypeContainer::FindMembers): Implement.
27043 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27045 * statement.cs: (VariableInfo::VariableType): New field to be
27046 initialized with the full type once it is resolved.
27048 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27050 * parameter.cs (GetParameterInfo): Use a type cache to compute
27051 things only once, and to reuse this information
27053 * expression.cs (LocalVariableReference::Emit): Implement.
27054 (OpcodeCast::Emit): fix.
27056 (ParameterReference::Resolve): Implement.
27057 (ParameterReference::Emit): Implement.
27059 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27060 that are expressions need to stay as Expressions.
27062 * typemanager.cs (CSharpName): Returns the C# name of a type if
27065 * expression.cs (Expression::ConvertImplicit): New function that
27066 implements implicit type conversions.
27068 (Expression::ImplicitReferenceConversion): Implements implicit
27069 reference conversions.
27071 (EmptyCast): New type for transparent casts.
27073 (OpcodeCast): New type for casts of types that are performed with
27074 a sequence of bytecodes.
27076 (BoxedCast): New type used for casting value types into reference
27077 types. Emits a box opcode.
27079 (Binary::DoNumericPromotions): Implements numeric promotions of
27080 and computation of the Binary::Type.
27082 (Binary::EmitBranchable): Optimization.
27084 (Binary::Emit): Implement code emission for expressions.
27086 * typemanager.cs (TypeManager): Added two new core types: sbyte
27089 2001-09-12 Ravi Pratap <ravi@ximian.com>
27091 * class.cs (TypeContainer::FindMembers): Method which does exactly
27092 what Type.FindMembers does, only we don't have to use reflection. No
27093 implementation yet.
27095 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27096 typecontainer objects as we need to get at them.
27097 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27099 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27100 typecontainer object.
27102 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27103 of just a Report object.
27105 2001-09-11 Ravi Pratap <ravi@ximian.com>
27107 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27109 (TypeContainer::Populate): Now define the delegates of the type too.
27110 (TypeContainer.Delegates): Property to access the list of delegates defined
27113 * delegates.cs (Delegate::Define): Implement partially.
27115 * modifiers.cs (TypeAttr): Handle more flags.
27117 2001-09-11 Ravi Pratap <ravi@ximian.com>
27119 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27121 (Operator::Define): Re-write logic to get types by using the LookupType method
27122 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27123 (Indexer::Define): Ditto.
27124 (Event::Define): Ditto.
27125 (Property::Define): Ditto.
27127 2001-09-10 Ravi Pratap <ravi@ximian.com>
27129 * class.cs (TypeContainer::Populate): Now define operators too.
27130 (TypeContainer.Operators): New property to access the list of operators
27132 (Operator.OperatorMethodBuilder): New member to hold the method builder
27133 for the operator we are defining.
27134 (Operator::Define): Implement.
27136 2001-09-10 Ravi Pratap <ravi@ximian.com>
27138 * class.cs (Event::Define): Make the prefixes of the accessor methods
27139 addOn_ and removeOn_
27141 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27142 of the location being passed in too. Ideally, this should go later since all
27143 error reporting should be done through the Report object.
27145 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27146 (Populate): Iterate thru the indexers we have and define them too.
27147 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27148 for the get and set accessors.
27149 (Indexer::Define): Implement.
27151 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27153 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27154 my previous implementation, did not work.
27156 * typemanager.cs: Add a couple of missing types (the longs).
27158 * literal.cs: Use TypeManager.bool_type instead of getting it.
27160 * expression.cs (EventExpr): New kind of expressions.
27161 (Expressio::ExprClassFromMemberInfo): finish
27163 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27165 * assign.cs: Emit stores to static fields differently.
27167 2001-09-08 Ravi Pratap <ravi@ximian.com>
27169 * Merge in changes and adjust code to tackle conflicts. Backed out my
27170 code in Assign::Resolve ;-)
27172 2001-09-08 Ravi Pratap <ravi@ximian.com>
27174 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27175 instead Report.Error and also pass in the location.
27176 (CSharpParser::Lexer): New readonly property to return the reference
27177 to the Tokenizer object.
27178 (declare_local_variables): Use Report.Error with location instead of plain
27182 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27183 (Operator.CheckBinaryOperator): Ditto.
27185 * cs-parser.jay (operator_declarator): Update accordingly.
27187 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27188 (CheckBinaryOperator): Same here.
27190 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27191 on the name without any prefixes of namespace names etc. This is because we
27192 already might have something already fully qualified like
27193 'System.Console.WriteLine'
27195 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27197 2001-09-07 Ravi Pratap <ravi@ximian.com>
27199 * cs-tokenizer.cs (location): Return a string which also contains
27202 * expression.cs (ElementAccess): New class for expressions of the
27203 type 'element access.'
27204 (BaseAccess): New class for expressions of the type 'base access.'
27205 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27208 * cs-parser.jay (element_access): Implement action.
27209 (base_access): Implement actions.
27210 (checked_expression, unchecked_expression): Implement.
27212 * cs-parser.jay (local_variable_type): Correct and implement.
27213 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27215 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27217 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27218 name and the specifiers.
27220 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27222 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27223 making them all public ;-)
27225 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27228 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27230 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27232 (FieldExpr, PropertyExprs): New resolved expressions.
27233 (SimpleName::MemberStaticCheck): Perform static checks for access
27234 to non-static fields on static methods. Maybe this should be
27235 generalized for MemberAccesses.
27236 (SimpleName::ResolveSimpleName): More work on simple name
27239 * cs-parser.jay (primary_expression/qualified_identifier): track
27240 the parameter index.
27242 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27243 (EmitContext::EmitBoolExpression): Chain to expression generation
27244 instead of temporary hack.
27245 (::EmitStatementExpression): Put generic expression code generation.
27247 * assign.cs (Assign::Emit): Implement variable assignments to
27248 local variables, parameters and fields.
27250 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27252 * statement.cs (Block::GetVariableInfo): New method, returns the
27253 VariableInfo for a variable name in a block.
27254 (Block::GetVariableType): Implement in terms of GetVariableInfo
27256 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27257 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27259 2001-09-06 Ravi Pratap <ravi@ximian.com>
27261 * cs-parser.jay (operator_declaration): Continue on my quest : update
27262 to take attributes argument.
27263 (event_declaration): Ditto.
27264 (enum_declaration): Ditto.
27265 (indexer_declaration): Ditto.
27267 * class.cs (Operator::Operator): Update constructor accordingly.
27268 (Event::Event): Ditto.
27270 * delegate.cs (Delegate::Delegate): Same here.
27272 * enum.cs (Enum::Enum): Same here.
27274 2001-09-05 Ravi Pratap <ravi@ximian.com>
27276 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27278 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27280 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27281 being passed around as an arraylist.
27282 (Attributes::AddAttribute): Method to add attribute sections.
27284 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27285 (struct_declaration): Update accordingly.
27286 (constant_declaration): Update.
27287 (field_declaration): Update.
27288 (method_header): Update.
27289 (fixed_parameter): Update.
27290 (parameter_array): Ditto.
27291 (property_declaration): Ditto.
27292 (destructor_declaration): Ditto.
27294 * class.cs (Struct::Struct): Update constructors accordingly.
27295 (Class::Class): Ditto.
27296 (Field::Field): Ditto.
27297 (Method::Method): Ditto.
27298 (Property::Property): Ditto.
27299 (TypeContainer::OptAttribute): update property's return type.
27301 * interface.cs (Interface.opt_attributes): New member.
27302 (Interface::Interface): Update to take the extra Attributes argument.
27304 * parameter.cs (Parameter::Parameter): Ditto.
27306 * constant.cs (Constant::Constant): Ditto.
27308 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27309 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27310 the attributes as a parameter.
27311 (InterfaceProperty): Update constructor call.
27312 (InterfaceEvent): Ditto.
27313 (InterfaceMethod): Ditto.
27314 (InterfaceIndexer): Ditto.
27316 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27317 pass the attributes too.
27318 (interface_event_declaration): Ditto.
27319 (interface_property_declaration): Ditto.
27320 (interface_method_declaration): Ditto.
27321 (interface_declaration): Ditto.
27323 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27325 * class.cs (Method::Define): Track the "static Main" definition to
27326 create an entry point.
27328 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27329 EntryPoint if we find it.
27331 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27332 (EmitContext::ig): Make this variable public.
27334 * driver.cs: Make the default output file be the first file name
27335 with the .exe extension.
27337 Detect empty compilations
27339 Handle various kinds of output targets. Handle --target and
27340 rename -t to --dumper.
27342 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27343 methods inherited from Expression return now an Expression. This
27344 will is used during the tree rewriting as we resolve them during
27347 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27348 the spec. Missing entirely is the information about
27349 accessability of elements of it.
27351 (Expression::ExprClassFromMemberInfo): New constructor for
27352 Expressions that creates a fully initialized Expression based on
27353 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27356 (Invocation::Resolve): Begin implementing resolution of invocations.
27358 * literal.cs (StringLiteral): Implement Emit.
27360 2001-09-05 Ravi Pratap <ravi@ximian.com>
27362 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27365 2001-09-04 Ravi Pratap <ravi@ximian.com>
27367 * cs-parser.jay (attribute_arguments): Implement actions.
27368 (attribute): Fix bug in production. Implement action.
27369 (attribute_list): Implement.
27370 (attribute_target): Implement.
27371 (attribute_target_specifier, opt_target_specifier): Implement
27372 (CheckAttributeTarget): New method to check if the attribute target
27374 (attribute_section): Implement.
27375 (opt_attributes): Implement.
27377 * attribute.cs : New file to handle attributes.
27378 (Attribute): Class to hold attribute info.
27380 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27381 (attribute_section): Modify production to use 2 different rules to
27382 achieve the same thing. 1 s/r conflict down !
27383 Clean out commented, useless, non-reducing dimension_separator rules.
27385 * class.cs (TypeContainer.attributes): New member to hold list
27386 of attributes for a type.
27387 (Struct::Struct): Modify to take one more argument, the attribute list.
27388 (Class::Class): Ditto.
27389 (Field::Field): Ditto.
27390 (Method::Method): Ditto.
27391 (Property::Property): Ditto.
27393 * cs-parser.jay (struct_declaration): Update constructor call to
27394 pass in the attributes too.
27395 (class_declaration): Ditto.
27396 (constant_declaration): Ditto.
27397 (field_declaration): Ditto.
27398 (method_header): Ditto.
27399 (fixed_parameter): Ditto.
27400 (parameter_array): Ditto.
27401 (property_declaration): Ditto.
27403 * constant.cs (Constant::Constant): Update constructor similarly.
27404 Use System.Collections.
27406 * parameter.cs (Parameter::Parameter): Update as above.
27408 2001-09-02 Ravi Pratap <ravi@ximian.com>
27410 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27411 (TypeContainer.delegates): New member to hold list of delegates.
27413 * cs-parser.jay (delegate_declaration): Implement the action correctly
27414 this time as I seem to be on crack ;-)
27416 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27418 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27419 tell whether an identifier represents a namespace.
27421 * expression.cs (NamespaceExpr): A namespace expression, used only
27422 temporarly during expression resolution.
27423 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27424 utility functions to resolve names on expressions.
27426 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27428 * codegen.cs: Add hook for StatementExpressions.
27430 * class.cs: Fix inverted test for static flag in methods.
27432 2001-09-02 Ravi Pratap <ravi@ximian.com>
27434 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27435 to make it coincide with MS' number.
27436 (Operator::CheckBinaryOperator): Ditto.
27438 * ../errors/errors.txt : Remove error numbers added earlier.
27440 * ../errors/cs1019.cs : Test case for error # 1019
27442 * ../errros/cs1020.cs : Test case for error # 1020
27444 * cs-parser.jay : Clean out commented cruft.
27445 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27446 used anywhere - non-reducing rule.
27447 (namespace_declarations): Non-reducing rule - comment out.
27449 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27450 with TypeContainer::AddEnum.
27452 * delegate.cs : New file for delegate handling classes.
27453 (Delegate): Class for declaring delegates.
27455 * makefile : Update.
27457 * cs-parser.jay (delegate_declaration): Implement.
27459 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27461 * class.cs (Event::Define): Implement.
27462 (Event.EventBuilder): New member.
27464 * class.cs (TypeContainer::Populate): Update to define all enums and events
27466 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27467 readonly fields for all these cases ?
27469 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27471 * class.cs (Property): Revamp to use the convention of making fields readonly.
27472 Accordingly modify code elsewhere.
27474 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27475 the Define method of the Property class.
27477 * class.cs : Clean up applied patch and update references to variables etc. Fix
27479 (TypeContainer::Populate): Update to define all the properties we have. Also
27480 define all enumerations.
27482 * enum.cs (Define): Implement.
27484 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27486 * cs-parser.jay (overloadable_operator): The semantic value is an
27487 enum of the Operator class.
27488 (operator_declarator): Implement actions.
27489 (operator_declaration): Implement.
27491 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27492 validity of definitions.
27493 (Operator::CheckBinaryOperator): Static method to check for binary operators
27494 (TypeContainer::AddOperator): New method to add an operator to a type.
27496 * cs-parser.jay (indexer_declaration): Added line to actually call the
27497 AddIndexer method so it gets added ;-)
27499 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27500 already taken care of by the MS compiler ?
27502 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27504 * class.cs (Operator): New class for operator declarations.
27505 (Operator::OpType): Enum for the various operators.
27507 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27509 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27510 ostensibly handle this in semantic analysis.
27512 * cs-parser.jay (general_catch_clause): Comment out
27513 (specific_catch_clauses, specific_catch_clause): Ditto.
27514 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27515 (catch_args, opt_catch_args): New productions.
27516 (catch_clause): Rewrite to use the new productions above
27517 (catch_clauses): Modify accordingly.
27518 (opt_catch_clauses): New production to use in try_statement
27519 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27520 and re-write the code in the actions to extract the specific and
27521 general catch clauses by being a little smart ;-)
27523 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27524 Hooray, try and catch statements parse fine !
27526 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27528 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27529 string from the hashtable of variables.
27531 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27532 I end up making that mistake ;-)
27533 (catch_clauses): Fixed gross error which made Key and Value of the
27534 DictionaryEntry the same : $1 !!
27536 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27538 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27540 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27541 when the add and remove accessors are specified.
27543 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27545 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27546 information about indexer_declarator.
27547 (indexer_declarator): Implement actions.
27548 (parsing_indexer): New local boolean used to keep track of whether
27549 we are parsing indexers or properties. This is necessary because
27550 implicit_parameters come into picture even for the get accessor in the
27551 case of an indexer.
27552 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27554 * class.cs (Indexer): New class for indexer declarations.
27555 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27556 (TypeContainer::indexers): New member to hold list of indexers for the
27559 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27561 * cs-parser.jay (add_accessor_declaration): Implement action.
27562 (remove_accessor_declaration): Implement action.
27563 (event_accessors_declaration): Implement
27564 (variable_declarators): swap statements for first rule - trivial.
27566 * class.cs (Event): New class to hold information about event
27568 (TypeContainer::AddEvent): New method to add an event to a type
27569 (TypeContainer::events): New member to hold list of events.
27571 * cs-parser.jay (event_declaration): Implement actions.
27573 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27575 * cs-parser.jay (dim_separators): Implement. Make it a string
27576 concatenating all the commas together, just as they appear.
27577 (opt_dim_separators): Modify accordingly
27578 (rank_specifiers): Update accordingly. Basically do the same
27579 thing - instead, collect the brackets here.
27580 (opt_rank_sepcifiers): Modify accordingly.
27581 (array_type): Modify to actually return the complete type string
27582 instead of ignoring the rank_specifiers.
27583 (expression_list): Implement to collect the expressions
27584 (variable_initializer): Implement. We make it a list of expressions
27585 essentially so that we can handle the array_initializer case neatly too.
27586 (variable_initializer_list): Implement.
27587 (array_initializer): Make it a list of variable_initializers
27588 (opt_array_initializer): Modify accordingly.
27590 * expression.cs (New::NType): Add enumeration to help us
27591 keep track of whether we have an object/delegate creation
27592 or an array creation.
27593 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27594 members to hold data about array creation.
27595 (New:New): Modify to update NewType
27596 (New:New): New Overloaded contructor for the array creation
27599 * cs-parser.jay (array_creation_expression): Implement to call
27600 the overloaded New constructor.
27602 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27604 * class.cs (TypeContainer::Constructors): Return member
27605 constructors instead of returning null.
27607 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27609 * typemanager.cs (InitCoreTypes): Initialize the various core
27610 types after we have populated the type manager with the user
27611 defined types (this distinction will be important later while
27612 compiling corlib.dll)
27614 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27615 on Expression Classification. Now all expressions have a method
27616 `Resolve' and a method `Emit'.
27618 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27619 generation from working. Also add some temporary debugging
27622 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27624 * codegen.cs: Lots of code generation pieces. This is only the
27625 beginning, will continue tomorrow with more touches of polish. We
27626 handle the fundamentals of if, while, do, for, return. Others are
27627 trickier and I need to start working on invocations soon.
27629 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27632 * codegen.cs (EmitContext): New struct, used during code
27633 emission to keep a context. Most of the code generation will be
27636 * cs-parser.jay: Add embedded blocks to the list of statements of
27637 this block. So code generation proceeds in a top down fashion.
27639 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27641 * statement.cs: Add support for multiple child blocks.
27643 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27645 * codegen.cs (EmitCode): New function, will emit the code for a
27646 Block of code given a TypeContainer and its ILGenerator.
27648 * statement.cs (Block): Standard public readonly optimization.
27649 (Block::Block constructors): Link children.
27650 (Block::Child): Child Linker.
27651 (Block::EmitVariables): Emits IL variable declarations.
27653 * class.cs: Drop support for MethodGroups here, delay until
27655 (Method::): Applied the same simplification that I did before, and
27656 move from Properties to public readonly fields.
27657 (Method::ParameterTypes): Returns the parameter types for the
27658 function, and implements a cache that will be useful later when I
27659 do error checking and the semantic analysis on the methods is
27661 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27662 and made a method, optional argument tells whether this is a class
27663 or a structure to apply the `has-this' bit.
27664 (Method::GetCallingConvention): Implement, returns the calling
27666 (Method::Define): Defines the type, a second pass is performed
27667 later to populate the methods.
27669 (Constructor::ParameterTypes): implement a cache similar to the
27670 one on Method::ParameterTypes, useful later when we do semantic
27673 (TypeContainer::EmitMethod): New method. Emits methods.
27675 * expression.cs: Removed MethodGroup class from here.
27677 * parameter.cs (Parameters::GetCallingConvention): new method.
27679 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27681 * class.cs (TypeContainer::Populate): Drop RootContext from the
27684 (Constructor::CallingConvention): Returns the calling convention.
27685 (Constructor::ParameterTypes): Returns the constructor parameter
27688 (TypeContainer::AddConstructor): Keep track of default constructor
27689 and the default static constructor.
27691 (Constructor::) Another class that starts using `public readonly'
27692 instead of properties.
27694 (Constructor::IsDefault): Whether this is a default constructor.
27696 (Field::) use readonly public fields instead of properties also.
27698 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27699 track of static constructors; If none is used, turn on
27700 BeforeFieldInit in the TypeAttributes.
27702 * cs-parser.jay (opt_argument_list): now the return can be null
27703 for the cases where there are no arguments.
27705 (constructor_declarator): If there is no implicit `base' or
27706 `this', then invoke the default parent constructor.
27708 * modifiers.cs (MethodAttr): New static function maps a set of
27709 modifiers flags into a MethodAttributes enum
27710 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27711 MethodAttr, TypeAttr to represent the various mappings where the
27712 modifiers are used.
27713 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27715 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27717 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27720 * interface.cs (PopulateIndexer): Implemented the code generator
27721 for interface indexers.
27723 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27725 * interface.cs (InterfaceMemberBase): Now we track the new status
27728 (PopulateProperty): Implement property population. Woohoo! Got
27729 Methods and Properties going today.
27731 Removed all the properties for interfaces, and replaced them with
27732 `public readonly' fields.
27734 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27736 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27737 initialize their hashtables/arraylists only when they are needed
27738 instead of doing this always.
27740 * parameter.cs: Handle refs and out parameters.
27742 * cs-parser.jay: Use an ArrayList to construct the arguments
27743 instead of the ParameterCollection, and then cast that to a
27746 * parameter.cs: Drop the use of ParameterCollection and use
27747 instead arrays of Parameters.
27749 (GetParameterInfo): Use the Type, not the Name when resolving
27752 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27754 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27755 and instead use public readonly fields.
27757 * class.cs: Put back walking code for type containers.
27759 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27761 * class.cs (MakeConstant): Code to define constants.
27763 * rootcontext.cs (LookupType): New function. Used to locate types
27766 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27768 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27769 this System.Reflection code is. Kudos to Microsoft
27771 * typemanager.cs: Implement a type cache and avoid loading all
27772 types at boot time. Wrap in LookupType the internals. This made
27773 the compiler so much faster. Wow. I rule!
27775 * driver.cs: Make sure we always load mscorlib first (for
27776 debugging purposes, nothing really important).
27778 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27779 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27781 * rootcontext.cs: Lookup types on their namespace; Lookup types
27782 on namespaces that have been imported using the `using' keyword.
27784 * class.cs (TypeContainer::TypeAttr): Virtualize.
27785 (Class::TypeAttr): Return attributes suitable for this bad boy.
27786 (Struct::TypeAttr): ditto.
27787 Handle nested classes.
27788 (TypeContainer::) Remove all the type visiting code, it is now
27789 replaced with the rootcontext.cs code
27791 * rootcontext.cs (GetClassBases): Added support for structs.
27793 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27795 * interface.cs, statement.cs, class.cs, parameter.cs,
27796 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27797 Drop use of TypeRefs, and use strings instead.
27799 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27803 * class.cs (Struct::Struct): set the SEALED flags after
27804 checking the modifiers.
27805 (TypeContainer::TypeAttr): new property, returns the
27806 TypeAttributes for a class.
27808 * cs-parser.jay (type_list): Oops, list production was creating a
27809 new list of base types.
27811 * rootcontext.cs (StdLib): New property.
27812 (GetInterfaceTypeByName): returns an interface by type name, and
27813 encapsulates error handling here.
27814 (GetInterfaces): simplified.
27815 (ResolveTree): Encapsulated all the tree resolution here.
27816 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27819 * driver.cs: Add support for --nostdlib, to avoid loading the
27820 default assemblies.
27821 (Main): Do not put tree resolution here.
27823 * rootcontext.cs: Beginning of the class resolution.
27825 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27827 * rootcontext.cs: Provide better error reporting.
27829 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27831 * rootcontext.cs (CreateInterface): Handle the case where there
27832 are no parent interfaces.
27834 (CloseTypes): Routine to flush types at the end.
27835 (CreateInterface): Track types.
27836 (GetInterfaces): Returns an array of Types from the list of
27837 defined interfaces.
27839 * typemanager.c (AddUserType): Mechanism to track user types (puts
27840 the type on the global type hash, and allows us to close it at the
27843 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27845 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27846 RecordInterface instead.
27848 * cs-parser.jay: Updated to reflect changes above.
27850 * decl.cs (Definition): Keep track of the TypeBuilder type that
27851 represents this type here. Not sure we will use it in the long
27852 run, but wont hurt for now.
27854 * driver.cs: Smaller changes to accomodate the new code.
27856 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27859 * rootcontext.cs (CreateInterface): New method, used to create
27860 the System.TypeBuilder type for interfaces.
27861 (ResolveInterfaces): new entry point to resolve the interface
27863 (CodeGen): Property, used to keep track of the code generator.
27865 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27867 * cs-parser.jay: Add a second production for delegate_declaration
27870 (enum_body): Put an opt_comma here instead of putting it on
27871 enum_body or enum_member_declarations so we can handle trailing
27872 commas on enumeration members. Gets rid of a shift/reduce.
27874 (type_list): Need a COMMA in the middle.
27876 (indexer_declaration): Tell tokenizer to recognize get/set
27878 * Remove old targets.
27880 * Re-add the parser target.
27882 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27884 * cs-parser.jay: Add precendence rules for a number of operators
27885 ot reduce the number of shift/reduce conflicts in the grammar.
27887 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27889 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27892 Get rid of old crufty code.
27894 * rootcontext.cs: Use this to keep track of the parsed
27895 representation and the defined types available to the program.
27897 * gen-treedump.cs: adjust for new convention.
27899 * type.cs: Split out the type manager, and the assembly builder
27902 * typemanager.cs: the type manager will live here now.
27904 * cil-codegen.cs: And the code generator here.
27906 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27908 * makefile: Fixed up for easy making.
27910 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27912 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27915 (unary_expression): Expand pre_increment_expression and
27916 post_decrement_expression to reduce a shift/reduce.
27918 2001-07-11 Simon Cozens
27920 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27922 Improve allow_keyword_as_indent name.
27924 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27926 * Adjustments for Beta2.
27928 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27930 * decl.cs: Added `Define' abstract method.
27931 (InTransit): new property, used to catch recursive definitions.
27933 * interface.cs: Implement `Define'.
27935 * modifiers.cs: Map Modifiers.constants to
27936 System.Reflection.TypeAttribute flags.
27938 * class.cs: Keep track of types and user-defined types.
27939 (BuilderInit): New method for creating an assembly
27940 (ResolveType): New function to launch the resolution process, only
27941 used by interfaces for now.
27943 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27944 that are inserted into the name space.
27946 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27948 * ARGH. I have screwed up my tree so many times due to the use of
27949 rsync rather than using CVS. Going to fix this at once.
27951 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27954 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27956 * Experiment successful: Use System.Type rather that our own
27959 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27961 * cs-parser.jay: Removed nsAliases from here.
27963 Use new namespaces, handle `using XXX;'
27965 * namespace.cs: Reimplemented namespace handling, use a recursive
27966 definition of the class. Now we can keep track of using clauses
27967 and catch invalid using clauses.
27969 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27971 * gen-treedump.cs: Adapted for all the renaming.
27973 * expression.cs (Expression): this class now has a Type property
27974 which returns an expression Type.
27976 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27977 `Type', as this has a different meaning now in the base
27979 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27981 * interface.cs, class.cs: Removed from all the sources the
27982 references to signature computation, as we can not do method
27983 signature computation during the parsing time, as we are not
27984 trying to solve at that point distinguishing:
27988 void a (NS.Blah x) {}
27991 Which depending on the context might be valid or not, as we do not
27992 know if Blah is the same thing as NS.Blah at that point.
27994 * Redid everything so the code uses TypeRefs now instead of
27995 Types. TypeRefs are just temporary type placeholders, that need
27996 to be resolved. They initially have a pointer to a string and the
27997 current scope in which they are used. This is used later by the
27998 compiler to resolve the reference to an actual Type.
28000 * DeclSpace is no longer a CIR.Type, and neither are
28001 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28002 are all DeclSpaces, but no Types.
28004 * type.cs (TypeRefManager): This implements the TypeRef manager,
28005 which keeps track of all the types that need to be resolved after
28006 the parsing has finished.
28008 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28010 * ARGH. We are going to have to store `foreach' as a class rather
28011 than resolving it, as we need to verify error 1579 after name
28012 resolution. *OR* we could keep a flag that says `This request to
28013 IEnumerator comes from a foreach statement' which we can then use
28014 to generate the error.
28016 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28018 * class.cs (TypeContainer.AddMethod): we now add methods to the
28019 MethodGroup instead of the method hashtable.
28021 * expression.cs: Add MethodGroup abstraction, which gets us one
28022 step closer to the specification in the way we handle method
28025 * cs-parser.jay (primary_expression): qualified_identifier now
28026 tried to match up an identifier to a local variable reference or
28027 to a parameter reference.
28029 current_local_parameters is now a parser global variable that
28030 points to the current parameters for the block, used during name
28033 (property_declaration): Now creates an implicit `value' argument to
28036 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28038 * parameter.cs: Do not use `param' arguments as part of the
28039 signature, per the spec.
28041 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28043 * decl.cs: Base class for classes, structs and interfaces. This
28044 is the "Declaration Space"
28046 * cs-parser.jay: Use CheckDef for checking declaration errors
28047 instead of having one on each function.
28049 * class.cs: Factor out some code for handling error handling in
28050 accordance to the "Declarations" section in the "Basic Concepts"
28051 chapter in the ECMA C# spec.
28053 * interface.cs: Make all interface member classes derive from
28054 InterfaceMemberBase.
28056 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28058 * Many things: all interfaces are parsed and generated in
28059 gen-treedump. Support for member variables, constructors,
28060 destructors, properties, constants is there.
28062 Beginning of the IL backend, but very little done, just there for
28065 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28067 * cs-parser.jay: Fix labeled statement.
28069 * cs-tokenizer.cs (escape): Escape " and ' always.
28070 ref_line, ref_name: keep track of the line/filename as instructed
28071 by #line by the compiler.
28074 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28076 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28077 to match the values in System.CodeDOM.
28079 Divid renamed to Divide.
28081 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28083 (Statements.set): remove.
28085 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28088 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28089 falseStatements always have valid values.
28091 * cs-parser.jay: Use System.CodeDOM now.