1 2005-02-10 Raja R Harinath <rharinath@novell.com>
3 Fix #52586, cs0121-4.cs.
4 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
5 and return a hashtable.
6 (MemberCache.ClearDeclaredOnly): New.
7 (MemberCache.MemberCache): Update to change. Make a deep copy of
8 the method_hash of a base type too.
9 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10 type methods. Overwrite entries with the same MethodHandle so
11 that the ReflectedType is correct. The process leaves in base
12 virtual functions and their overrides as distinct entries.
13 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14 matters since it was boxed in a ArrayList before.
15 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
17 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
18 case of a virtual function and its override (choose the overload
20 (Invocation.OverloadResolve): Avoid 'override' members during
21 'applicable_type' calculation.
23 2005-02-09 Raja R Harinath <rharinath@novell.com>
25 Combine two near-redundant caches.
26 * typemanager.cs (method_params): Rename from method_internal_params.
27 (TypeManager.GetParameterData): New. Replace
28 Invocation.GetParameterData.
29 (TypeManager.LookupParametersByBuilder): Remove.
30 * expression.cs (Invocation.method_parameter_cache): Remove.
31 (Invocation.GetParameterData): Remove.
33 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
36 2005-02-08 Raja R Harinath <rharinath@novell.com>
39 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
40 TypeManager.multicast_delegate_type is null, resolve it by looking
41 up "System.MulticastDelegate".
42 * rootcontext.cs (RootContext.ResolveCore): Simplify.
44 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
45 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
46 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
49 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
50 (LabeledStatement.AddReference): New. Set 'referenced'.
51 (Goto.Resolve): Use it.
53 2005-02-05 John Luke <john.luke@gmail.com>
55 * driver.cs: remove duplicate -doc line in Usage ()
57 2005-02-04 Raja R Harinath <rharinath@novell.com>
59 * location.cs (Location.AddFile): Fix CS2002 error report.
61 2005-02-02 Martin Baulig <martin@ximian.com>
63 * delegate.cs (Delegate.DefineType): Report an internal error if
64 TypeManager.multicast_delegate_type is null. See bug #72015 for
67 2005-02-02 Raja R Harinath <rharinath@novell.com>
69 Fix a crasher in a variant of #31984.
70 * const.cs (Constant.CheckBase): New override that defers the
71 new-or-override check in case the base type hasn't been populated
73 (Constant.Define): Ensure the new-or-override check is performed.
75 2005-02-01 Duncan Mak <duncan@ximian.com>
77 * const.cs (LookupConstantValue): Check that `ce' is not null
78 before calling GetValue ().
80 2005-02-01 Raja R Harinath <rharinath@novell.com>
82 Fix test-334.cs (#69519).
83 * cs-parser.jay (using_alias_directive): Pass in an expression to
84 NamespaceEntry.UsingAlias.
85 (using_namespace_directive): Pass in an expression to
87 (namespace_name): Don't flatten to a string.
88 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
89 (NamespaceEntry.AliasEntry.Resolve): Lookup using
91 (NamespaceEntry.UsingEntry): Likewise.
92 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
94 (NamespaceEntry.LookupForUsing): Remove.
95 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
97 (NamespaceEntry.Lookup): Remove support for dotted names.
99 2005-02-01 Raja R Harinath <rharinath@novell.com>
101 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
103 (NamespaceEntry.ImplicitParent): Compute on demand.
104 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
105 parallels the current.
106 (NamespaceEntry.LookupForUsing): Use it.
107 (NamespaceEntry.Lookup): If the current namespace-entry is
108 implicit, don't search aliases and using tables.
110 2005-02-01 Raja R Harinath <rharinath@novell.com>
113 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
115 (TypeContainer.BaseCache): Compute on demand.
116 (TypeContainer.FindMembers): Define constants and types if they're
118 (FieldMember.Define): Move resetting of ec.InUnsafe before error
120 * const.cs (Constant.Define): Make idempotent.
122 2005-01-29 Miguel de Icaza <miguel@novell.com>
124 * pending.cs: Produce better code (no nops produced by using Ldarg
127 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
128 i - 1' it should be arg + 1.
132 2005-01-28 Raja R Harinath <rharinath@novell.com>
134 * attribute.cs (Attribute.CheckAttributeType): Make private
136 (Attribute.ResolveType): Make virtual.
137 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
138 handling of RootContext.Tree.Types.
140 2005-01-27 Raja R Harinath <rharinath@novell.com>
142 Update attribute-handling to use the SimpleName/MemberAccess
144 * cs-parser.jay (attribute): Pass in an expression to the
145 constructors of Attribute and GlobalAttribute.
146 * attribute.cs (Attribute): Take an expression for the name.
147 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
148 passed in attribute name expression.
149 (Attribute.CheckAttributeType): Use it.
150 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
151 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
152 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
153 argument to prevent error messages if the lookup fails.
155 2005-01-27 Marek Safar <marek.safar@seznam.cz>
157 * expression.cs (Indirection): Implemented IVariable interface
158 to support indirection in AddressOf operator.
159 (PointerArithmetic.Emit): Add optimalization for case where
160 result can be precomputed.
162 2005-01-26 Martin Baulig <martin@ximian.com>
164 * class.cs (TypeContainer.AttributeTargets): Return the correct
165 AttributeTargets depending on our `Kind' instead of throwing an
166 exception; fixes #71632.
168 2005-01-26 Marek Safar <marek.safar@seznam.cz>
171 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
174 2005-01-25 Raja R Harinath <rharinath@novell.com>
177 * expression.cs (MemberAccess.DoResolve): Don't complain with
178 cs0572 when the LHS of a member access has identical name and type
181 2005-01-25 Marek Safar <marek.safar@seznam.cz>
184 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
186 Create custom PermissionSet only for PermissionSetAttribute.
188 2005-01-24 Marek Safar <marek.safar@seznam.cz>
191 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
192 delegates in static class.
194 2005-01-24 Martin Baulig <martin@ximian.com>
196 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
197 merging an implicit block, just use its reachability.
199 * statement.cs (Block.Resolve): Make the unreachable code check
200 work wrt. implicit blocks; see test-337 from #63842.
202 2005-01-21 Alp Toker <alp@atoker.com>
204 * cs-parser.jay: destructor_declaration's container is PartialContainer
205 not Class when partial types are used, so use Kind prop instead of
208 2005-01-22 Miguel de Icaza <miguel@ximian.com>
210 * cs-parser.jay: Improve error reporting when an interface
213 2005-01-20 Dick Porter <dick@ximian.com>
215 * support.cs: SeekableStreamReader fix from Sandor Dobos
216 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
217 chars are read. Fixes bug 70369.
219 2005-01-20 Raja R Harinath <rharinath@novell.com>
221 * cs-parser.jay (catch_clause): Simplify current_block handling
224 2005-01-17 Miguel de Icaza <miguel@ximian.com>
226 * convert.cs (ImplicitStandardConversionExists): Synchronize the
227 code with ImplicitStandardConversion to handle the implicit
228 conversion of method groups into valid delegate invocations.
230 The problem is that in parameter handling we were using this code
231 path. Fixes bug #64698
233 2005-01-19 Raja R Harinath <rharinath@novell.com>
235 * cs-parser.jay: Fix several infelicities.
236 - Avoid assigning to the parser value stack. Code like
237 '$3 = null' is unclean. Synthesize a value for the code block
239 - Avoid using oob_stack for storing location information. Use ...
240 (_mark_): ... this. New (empty) rule. Saves the current location
242 (foreach_statement): Avoid using oob_stack for current_block
243 handling. Use technique used in for_statement and
244 using_statement. Synthesize a value for the code block to store
245 additional intermediate information.
247 2005-01-13 Miguel de Icaza <miguel@ximian.com>
249 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
250 of a different type is only allowed to private fields of a
251 containing type, not on fields of a base class.
253 See test-174.cs and error cs0122-9.cs
255 2005-01-13 Raja R Harinath <rharinath@novell.com>
257 Fix test-335.cs (bug #58126).
258 * cs-parser.jay (argument): Split out non-expression parts of the
259 rule into 'non_simple_argument'.
260 (invocation_expression): Support parenthesized invocations with
261 multiple arguments, and with single non-simple arguments.
263 2005-01-13 Raja R Harinath <rharinath@novell.com>
265 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
268 2005-01-12 Raja R Harinath <rharinath@novell.com>
270 Fix cs0038-1.cs, cs1640-6.cs.
271 * ecore.cs (Expression.Resolve): Remove special-case for
272 SimpleName in error-handling.
273 (Expression.almostMatchedMembers): Relax access permission to
275 (Expression.MemberLookupFailed): Handle duplicates in
276 almostMatchedMembers list.
277 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
278 * expression.cs (New.DoResolve): Report CS1540 for more cases.
279 * typemanager.cs (GetFullNameSignature): Use the MethodBase
280 overload if the passed in MemberInfo is a MethodBase.
282 2005-01-12 Marek Safar <marek.safar@seznam.cz>
285 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
286 for non-CAS & merge permission sets properly.
288 2005-01-11 Raja R Harinath <rharinath@novell.com>
290 Improve standard-compliance of simple name and member access
291 resolution. Fixes bugs #52697, #57200, #67520, #69519.
292 * ecore.cs (FullNamedExpression): New abstract base class
293 for Namespaces and TypeExpressions.
294 (ResolveFlags.SimpleName): Remove.
295 (SimpleName): Remove support for dotted names.
296 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
297 DeclSpace.FindType and DeclSpace.LookupType.
298 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
299 (Expression.ExprClassName): Make member function.
300 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
301 a namespace. Remove creation of dotted "SimpleName"s.
302 (MemberAccess.DoResolve): Likewise.
303 * decl.cs (DeclSpace.Cache): Make private.
304 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
305 (DeclSpace.FindType): Update.
306 (DeclSpace.LookupType): Move here from RootContext. Return a
308 * namespace.cs (Namespace): Derive from FullNamedExpression
309 so that it can be part of expression resolution.
310 (Namespace.Lookup): Return an FullNamedExpression.
311 (NamespaceEntry.LookupAlias): Lookup aliases only in current
313 * rootcontext.cs (NamespaceLookup): Remove.
314 (LookupType): Move to DeclSpace.
315 * attribute.cs (CheckAttributeType): Update.
316 * doc.cs (FindDocumentedType): Remove allowAlias argument.
317 (FindDocumentedTypeNonArray): Likewise.
319 2005-01-11 Raja R Harinath <rharinath@novell.com>
321 Fix cs0509.cs, cs1632.cs.
322 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
323 is the same as IsInterface.
324 (TypeContainer.GetClassBases): Likewise.
325 * statement.cs (LabeledStatement.ig): New field.
326 (LabeledStatement.LabelTarget): Save ILGenerator which created the
328 (LabeledStatement.DoEmit): Check that the label was created with
329 the same ILGenerator.
331 2005-01-10 Marek Safar <marek.safar@seznam.cz>
334 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
335 accessors to its properties.
337 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
338 from accessors to property.
340 2005-01-10 Marek Safar <marek.safar@seznam.cz>
343 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
346 2005-01-08 Miguel de Icaza <miguel@ximian.com>
348 * attribute.cs: Check for null and empty strings.
350 I have lost another battle to Paolo.
352 2005-01-07 Marek Safar <marek.safar@seznam.cz>
355 * class.cs (PropertyMethod): Set Parent field in ctors.
356 (SetMethod.InternalParameters): Add unsafe switch hack.
357 Override MarkForDuplicationCheck where it is appropriate.
359 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
360 It says whether container allows members with the same name.
362 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
363 Removed is_method parameter.
365 2005-01-06 Duncan Mak <duncan@ximian.com>
367 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
368 because the previous change led to incorrect reporting of CS1032
369 ("Cannot define/undefine preprocessor symbols after first token in
370 file"). Instead of using `tokens_seen' as the only flag that
371 triggers CS1040, introduce `comments_seen'. This new flag is used
372 to signify having seen comments on the current line, so it is
373 unset after a newline.
375 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
377 * doc.cs : When searching for a type, find nested type too.
378 This fixes bug #71040.
380 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
383 - Warn missing member comment on those classes which also does not
384 have doc comments. Fixed bug #71041.
385 - Don't warn missing doc comment on default constructor.
388 2005-01-06 Duncan Mak <duncan@ximian.com>
390 * cs-tokenizer.cs (xtoken): After handling traditional C-style
391 comments, set `tokens_seen' to true. This allows us to detect
392 misplaced preprocessor directives (i.e. not at the beginning of
393 the a line, nor after whitespaces). In that case, report error
394 CS1040. This fixes bug #56460.
396 * cs-parser.jay (interface_member_declaration): Add checks for
397 IsExplicitImpl, and report CS0541 error if an interface member is
398 defined as an explicit interface declaration.
400 2005-01-06 Marek Safar <marek.safar@seznam.cz>
403 * class.cs (PropertyMethod): Set Parent field in ctors.
404 (SetMethod.InternalParameters): Add unsafe switch hack.
406 * decl.cs (MemberCore.Parent): Cannot be readonly.
408 2005-01-06 Raja R Harinath <rharinath@novell.com>
410 * decl.cs (DeclSpace.ResolveType): Remove.
411 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
412 Merge in code from ...
413 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
414 * class.cs, enum.cs: Update to changes.
416 2005-01-06 Miguel de Icaza <miguel@ximian.com>
418 * anonymous.cs: Ensure that we init the scope of our parent if it
419 has not been initialized yet.
421 2004-12-30 Duncan Mak <duncan@ximian.com>
423 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
424 if field.FieldBuilder is null. Fixes #70758.
426 * convert.cs: Fixed some typos and updated some of the comments.
427 (ImplicitStandardConversionExists):
428 (TryImplicitIntConversion): If `target_type' is an interface and
429 the type of `ic' implements this interface, return true or a new
430 BoxedCast instead of null. This fixes #70468.
432 2004-12-29 Duncan Mak <duncan@ximian.com>
434 * expression.cs (Argument.Emit): Check that Expr is
435 IMemoryLocation before casting to it, and report CS1510 otherwise.
439 2004-12-21 Ben Maurer <bmaurer@ximian.com>
441 * statement.cs (Block.ThisVariable): remove the recursion here, to
442 make the --profile more sane.
444 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
446 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
447 assembly, by JB Evain.
449 2004-12-17 Raja R Harinath <rharinath@novell.com>
451 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
452 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
453 "parent" refers to enclosing type/class. "base" refers to superclass.
455 2004-12-17 Raja R Harinath <rharinath@novell.com>
457 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
458 Ensure that we only have GlobalAttributes.
459 * attribute.cs (Attribute.Emit): Make non-virtual.
460 (GlobalAttribute.Emit): Remove.
461 (Attribute.Resolve): Make virtual.
462 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
463 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
464 the argument. Don't create one.
465 (Attribute.GetObsoleteAttribute): Likewise.
466 (Attribute.GetClsCompliantAttributeValue): Likewise.
467 * class.cs, decl.cs: Update to changes.
469 2004-12-17 Marek Safar <marek.safar@seznam.cz>
471 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
473 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
475 * statement.cs (Foreach.Resolve): Add error 186 report.
477 2004-12-16 Marek Safar <marek.safar@seznam.cz>
479 * expression.cs (Conditional.DoResolve): Add warning 429.
481 * statement.cs (If.Resolve): Add warning 665.
483 2004-12-16 Raja R Harinath <rharinath@novell.com>
485 New invariant: RootContext.Tree.Types.NamespaceEntry == null
486 except when in the parser, and in GlobalAttribute.
487 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
488 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
489 RootContext.Tree.Types.NamespaceEntry once work is done.
490 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
491 and resets RootContext.Tree.Types.NamespaceEntry.
493 2004-12-15 Marek Safar <marek.safar@seznam.cz>
495 * cs-parser.jay: Don't create a block for every variable.
497 2004-12-14 Miguel de Icaza <miguel@ximian.com>
499 * location.cs: Provide extra information.
501 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
502 variables from the captured environment, it is the ldarg_0.
504 2004-12-14 Marek Safar <marek.safar@seznam.cz>
506 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
509 * class.cs: Changed warning level for 169 to avoid developer
510 displeasure from warning flooding. It will be changed back when they
511 fix most of current BCL warnings.
513 * RootContext.cs: Pushed default WarningLevel to 3.
515 * statement.cs: Removed unused variable.
517 2004-12-14 Marek Safar <marek.safar@seznam.cz>
519 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
520 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
521 Add error 502 report.
522 (StaticClass.DefineType): Add error 441 report.
523 (Class.AllowedModifiersProp): New virtual property as temporary
524 extension to AllowedModifiers.
525 (Class.DefineType): Add error 418 report. Moved ModFlags check here
526 to share implementation with StaticClass and don't call virtual
529 * driver.cs (MainDriver): Add error 1558 test.
531 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
532 report. Moved error 36 test here.
534 * statement.cs (Throw.Resolve): Add error 724 report.
536 * typemanager.cs: Add out_attribute_type core type.
538 2004-12-13 Marek Safar <marek.safar@seznam.cz>
540 * class.cs (TypeContainer.VerifyClsCompliance): Add error
542 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
544 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
547 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
549 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
550 Add error 3023 report.
551 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
553 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
556 2004-12-12 John Luke <john.luke@gmail.com>
558 * driver.cs (AddArgs): take -- into account when
559 adding arguments, fixes bug 65710
561 2004-12-12 Martin Baulig <martin@ximian.com>
563 * expression.cs (Unary.TryReduceNegative): Added support for
564 SByteConstant and ByteConstant.
565 (Unary.Reduce): Check error values from TryReduceNegative().
567 2004-12-10 Marek Safar <marek.safar@seznam.cz>
569 * attributes.cs (Attribute.Resolve): Avoid multiple error report
570 and report exception as error 182.
572 2004-12-10 Raja R Harinath <rharinath@novell.com>
574 * driver.cs (Main): Fix message when there are warnings.
576 2004-12-09 Miguel de Icaza <miguel@ximian.com>
578 * delegate.cs: Fixed my fix from yesterday, sorry about that.
580 2004-12-09 Marek Safar <marek.safar@seznam.cz>
582 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
583 Reduced number of warnings.
585 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
587 2004-12-08 Miguel de Icaza <miguel@ximian.com>
589 * driver.cs: Removed message.
591 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
593 2004-12-08 <vargaz@freemail.hu>
595 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
597 2004-12-08 Martin Baulig <martin@ximian.com>
599 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
600 instead of a CS3002 for properties and indexer.
602 2004-12-08 Martin Baulig <martin@ximian.com>
604 * decl.cs (MemberName.ToString): Make this work again.
606 2004-12-08 Marek Safar <marek.safar@seznam.cz>
608 * attribute.cs (Resolve): Add error 591 detection.
610 * class.cs (FieldMember.Define): Add error 1547 detection.
611 (Indexer.Define): Add error 620 detection.
612 (Operator.Define): Add error 590 detection.
614 * ecore.cs: Missing argument for error 79.
616 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
619 2004-12-07 Marek Safar <marek.safar@seznam.cz>
622 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
625 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
627 * cs-parser.jay : handle doc comments on implicit/explicit operators.
628 Some operator comments were suppressed.
629 * doc.cs : Implicit/explicit operator name in doc comments are like
630 "op_Explicit(type)~returnType", so added suffix handling.
632 2004-12-07 Martin Baulig <martin@ximian.com>
635 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
636 (MemberCore.GetClsCompliantAttributeValue): Likewise.
637 (DeclSpace.ec): New protected field; store the EmitContext here.
638 (DeclSpace.EmitContext): New public property; moved here from
640 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
643 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
644 (Enum.Emit): Don't create a new EmitContext.
646 * delegate.cs (Delegate.DefineType): Always create the
649 * iterators.cs (Iterators.DefineIterator): Create a new
650 EmitContext and store it in `ec'.
652 2004-08-24 Martin Baulig <martin@ximian.com>
655 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
656 this for accessibility checks.
657 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
658 IsNestedFamilyAccessible.
659 (TypeManager.IsSubclassOf): New method, do what the name actually
662 2004-12-06 Raja R Harinath <rharinath@novell.com>
664 Fix crash on cs0657-17.cs.
665 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
666 Use RootContext.Tree.Types, not 'new RootTypes ()'.
667 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
668 the case where the NamespaceEntry gets overwritten.
670 2004-12-06 Marek Safar <marek.safar@seznam.cz>
673 * ecore.cs (ResolveBoolean): Tiny refactoring.
675 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
676 of right expression resolving when left is false constant and
677 operator is LogicalAnd OR true constant and operator is LogicalOr.
679 * statement.cs (ResolveUnreachable): Always reports warning.
681 2004-12-05 Miguel de Icaza <miguel@ximian.com>
683 * class.cs: Distinguish between 1721 and 1722 (just a little help
686 2004-12-03 Miguel de Icaza <miguel@ximian.com>
688 * delegate.cs: Only allow this on new versions of the language.
690 2004-12-02 Duncan Mak <duncan@ximian.com>
692 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
694 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
695 here as a static method. Take an additional bool out parameter
696 `must_do_cs1540_check' for signaling to InstanceResolve.
697 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
698 member field from PropertyExpr class and made it an argument of
700 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
701 check for MarshalByRefObject, and report CS0122 instead of CS1540.
702 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
703 and `remove_accessor' as well as InstanceResolve: report CS0122
708 2004-12-03 Raja R Harinath <rharinath@novell.com>
710 Fix test-327.cs, test-328.cs, and put in early infrastructure
711 for eventually fixing #52697.
712 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
713 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
715 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
716 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
717 (VerifyUsing, error246): Update.
718 * rootcontext.cs (RootContext.NamespaceLookup): Just use
719 'NamespaceEntry.LookupNamespaceOrType'.
721 2004-12-03 Martin Baulig <martin@ximian.com>
723 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
724 method as our child, call AnonymousMethod.Compatible() on it.
726 2004-12-03 Raja R Harinath <rharinath@novell.com>
728 Disable XML documentation support in 'basic' profile.
729 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
730 Redirect XmlElement to System.Object.
731 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
732 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
733 * mcs.exe.sources: Add doc-bootstrap.cs.
734 * doc-bootstrap.cs: New file. Contains empty stub implementation
737 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
739 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
740 comments are allowed.
742 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
744 * delegate.cs: Add checks for subtypes in paramaters and return values
745 in VerifyMethod () to add support for Covariance/Contravariance
748 2004-12-02 Miguel de Icaza <miguel@ximian.com>
750 * report.cs: Remove extra closing parenthesis.
752 * convert.cs (Error_CannotImplicitConversion): If the name of the
753 types are the same, provide some extra information.
755 * class.cs (FieldBase): Use an unused bit field from the field to
756 encode the `has_offset' property from the FieldMember. This saves
757 a couple of Ks on bootstrap compilation.
759 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
760 method as our child, return the AnonymousMethod resolved
763 * expression.cs (New.DoResolve): Allow return values from
764 NewDelegate to also include AnonymousMethods.
768 2004-12-02 Marek Safar <marek.safar@seznam.cz>
771 * attribute.cs (Resolve): Improved implementation of params
774 * support.cs (ParameterData): Add HasParams to be faster.
776 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
778 all things are for /doc support:
780 * doc.cs: new file that supports XML documentation generation.
781 * mcs.exe.sources: added doc.cs.
783 Handle /doc command line option.
784 Report error 2006 instead of 5 for missing file name for /doc.
785 Generate XML documentation when required, after type resolution.
787 Added support for picking up documentation (/// and /** ... */),
788 including a new XmlCommentState enumeration.
790 Added lines to fill Documentation element for field, constant,
791 property, indexer, method, constructor, destructor, operator, event
792 and class, struct, interface, delegate, enum.
793 Added lines to warn incorrect comment.
795 Added Documentation field (passed only when /doc was specified).
797 Added DocComment, DocCommentHeader, GenerateDocComment() and
798 OnGenerateDocComment() and some supporting private members for
799 /doc feature to MemberCore.
801 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
803 Added overriden DocCommentHeader.
805 Added overriden DocCommentHeader and GenerateDocComment().
807 2004-12-01 Miguel de Icaza <miguel@ximian.com>
809 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
810 unwrapping the enumeration values, chain to
811 DoConstantNumericPromotions again, so we can promote things to the
812 fundamental types (takes care of enums that are bytes, sbytes).
816 2004-12-01 Raja R Harinath <rharinath@novell.com>
818 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
819 Fix long-standing bug in type-lookup. Use FindType instead of
820 LookupType when ec.ResolvingTypeTree.
821 (Attribute.ResolveType, Attribute.Resolve)
822 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
824 (Attributes.Search): Remove internal version. Update.
825 (Attributes.SearchMulti): Update.
826 (Attributes.GetClsCompliantAttribute): Remove.
827 (Attributes.GetIndexerNameAttribute): Remove.
828 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
829 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
830 * class.cs (Indexer.Define): Likewise.
832 2004-12-01 Marek Safar <marek.safar@seznam.cz>
835 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
836 MarshallByReference members access.
838 * expression.cs: Use CheckMarshallByRefAccess;
839 Better error CS0197 message.
841 * report.cs: Print whole related error message.
843 2004-11-30 Raja R Harinath <rharinath@novell.com>
845 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
846 the current directory to help debugging.
848 2004-11-29 Marek Safar <marek.safar@seznam.cz>
850 * class (GetClassBases): Better error 60 report.
851 (EventProperty): Disabled warning 67 detection.
853 2004-11-29 Marek Safar <marek.safar@seznam.cz>
856 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
858 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
861 2004-11-29 Marek Safar <marek.safar@seznam.cz>
864 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
866 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
868 2004-11-26 Miguel de Icaza <miguel@ximian.com>
870 * attribute.cs (Attribute.Resolve): Refine error reporting and
871 report a cs0117 if the identifier does not exist, to distinguish
872 from 0617 which is a miss-use of the actual identifier.
874 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
875 between cs0070 and cs0079.
877 * class.cs (MemberBase.DoDefine): When reporting a wrong
878 accessibility level, we use MethodCore to compare instead of
879 Method (this was a regression in some refactoring effort).
881 So now we correctly report cs0056 again.
883 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
884 testing the target_type (which was known to be object_type) and
885 not the source type (which is anonymous_method).
887 Fixed reporting of error cs1660.
889 * expression.cs (UserCast.Source): Expose the underlying cast.
891 * statement.cs (Switch.SwitchGoverningType): Sort the list of
892 allowed types to find a match to int32 first (most common).
894 In addition, it ignores any ImplicitUserConversions that did an
895 internal implicit conversion (as the switch statement allows only
896 one integral conversion to exist).
898 * class.cs (PartialContainer.Create): rename `name' to
899 `member_name' for clarity. Then replace the string calls with a
900 call to MemberName.GetPartialName, as now using
901 MemberName.ToString is an error (this is due to the side effects
902 it had, that were fixed in the past).
904 This will restore the error reporting on a number of partial class
905 errors that were missusing this (and getting an exception as a
906 results, which is now just a plain textual warning, because
907 yyparse debug output would crash otherwise).
909 2004-11-26 Raja R Harinath <rharinath@novell.com>
911 * Makefile (PROGRAM_INSTALL_DIR): Remove.
913 2004-11-25 Ben Maurer <bmaurer@ximian.com>
915 * rootcontext.cs (LookupType): Make sure to cache lookups that
916 don't give us a negative result. This saves about 5% of corlib
919 2004-11-25 Miguel de Icaza <miguel@ximian.com>
921 * report.cs (AbstractMessage.Print): messages are sent to stderr
923 * class.cs (TypeContainer.GetClassBases): It is an error to have a
924 non-interface in the list of interfaces (at this point, either
925 parent was properly set, or a base class is being listed in the
928 This flags error 1722, and resolves the crash from bug 69259.
930 2004-11-25 Ben Maurer <bmaurer@ximian.com>
932 * statement.cs (Using.EmitExpressionFinally): make this work right
933 for valuetypes. Fixes 69926.
935 2004-11-25 Miguel de Icaza <miguel@ximian.com>
937 * const.cs (Const.ChangeType): Cope with the "0 literal can be
938 converted to an enum" here, before we try to change the underlying
939 type. This code exists, but it is a different code path than the
940 one used while encoding constants.
942 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
943 old bug: when converting from the null literal to a pointer,
944 return an EmptyCast, not the NullLiteral.
946 This fixes #69921, the recent null_type changes probably made this
949 (ImplicitReferenceConversionExists): In addition, resynchronized
950 the code here, so it matches the same code in
951 ImplicitReferenceConversionExists for the `from any class-type S
952 to any interface-type T'.
955 2004-11-25 Marek Safar <marek.safar@seznam.cz>
957 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
959 2004-11-24 Miguel de Icaza <miguel@ximian.com>
961 * cs-parser.jay: Use verbosity accordingly.
963 2004-11-24 Marek Safar <marek.safar@seznam.cz>
965 * expression.cs (Unary.ResolveOperator): Do not report warning;
966 AddressOf reads from variable.
968 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
970 2004-11-24 Marek Safar <marek.safar@seznam.cz>
974 * attribute.cs (Attributable): Removed CheckTargets.
975 (Attributes.Emit): Explicit attribute targets are tested here.
977 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
978 not enabled for interfaces.
980 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
981 (GetAssemblyName): Ouch next bug there.
983 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
985 * expression.cs: Error 275 added.
987 2004-11-23 Marek Safar <marek.safar@seznam.cz>
989 Fix bug #69177 (Implemented decimal constant support)
991 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
992 (BinaryFold): Add DecimalConstant.
994 * const.cs (Define): Decimal constant
996 (ChangeType): Add decimal type handling.
997 (LookupConstantValue): Don't set value for decimal type but
998 emit DecimalConstantAttribute. Needed for constant optimization.
1000 * constant.cs (ToDecimal): New method.
1001 (ConvertToDecimal): New method.
1002 (IntConstant): Implemented ConvertToDecimal.
1003 (DecimalConstant.Emit): Emit optimized version for decimals in
1006 * expression.cs (ResolveOperator): Changed order of constant
1007 reduction to work correctly with native types which have
1008 overloaded operators.
1009 (ResolveMemberAccess): Extract constant value from attribute
1012 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1014 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1015 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1016 (ChangeType): Decimal is special.
1017 (TypeToCoreType): Add decimal type.
1019 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1021 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1024 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1026 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1029 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1031 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1033 * pending.cs (PendingImplementation): Grab only interfaces.
1035 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1037 * statement.cs (ForeachHelperMethods): Add location member and
1038 error 202 detection.
1040 2004-11-19 Raja R Harinath <rharinath@novell.com>
1042 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
1043 automatically handled by executable.make.
1044 (PROGRAM): Make profile-specific.
1046 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1048 * expression.cs (DoResolveBase): Fixed wrong warning for out
1051 2004-11-18 Martin Baulig <martin@ximian.com>
1053 Merged latest changes into gmcs. Please keep this comment in
1054 here, it makes it easier for me to see what changed in MCS since
1055 the last time I merged.
1057 2004-11-17 Raja R Harinath <rharinath@novell.com>
1059 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1060 (TypeHandle.GetMemberCache): New.
1061 (TypeHandle.TypeHandle): Update.
1062 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1063 (TypeManager.LookupParentInterfacesCache):
1064 Rename from LookupInterfaceCache. Optimize slightly.
1065 (TypeManager.MemberLookup_FindMembers): Update.
1066 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1068 (AddCacheContents): Rename from AddHashtable.
1069 * class.cs (TypeContainer.parent_container): Remove.
1070 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1071 (TypeContainer.DoDefineMembers): Don't initialize it.
1072 Update to name changes.
1074 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1076 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1077 that factors the code to check access modifiers on override.
1079 (PropertyBase): Use the code here.
1081 Patch from Lluis S'anchez, fixes bug #69361.
1083 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1085 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1086 routine that is used to report the use of a captured variable
1087 whose address has been taken.
1089 There are two checks: one when variables are being captured and
1090 the other check is when the address of a variable is taken.
1092 (because an anonymous methods might be resolved before *or* after
1093 the address has been taken) and
1095 * expression.cs (Conditional.DoResolve): Remove the special
1096 casing that Martin added to trueExpr and falseExpr being both
1097 NullLiteral. We get the right behavior now just by introducing
1098 the null_type into the compiler.
1100 * convert.cs (ExplicitConversion): Change the code to use
1101 null_type instead of testing `expr is NullLiteral'.
1102 (ImplicitConversionStandard): use null_type too.
1103 (ImplicitReferenceConversionExists): use null_type too.
1104 (ImplicitReferenceConversion): use null_type too.
1106 * literal.cs: The type of `NullLiteral' is now null_type instead
1108 (Resolve): Set the type here.
1110 * typemanager.cs: Introduce null_type.
1112 2004-11-17 Martin Baulig <martin@ximian.com>
1114 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1115 direction, like FindMembers() does. Fixes #69546, testcase is in
1118 2004-11-16 Martin Baulig <martin@ximian.com>
1120 This is based on a patch from Marek Safar, see bug #69082.
1121 Fixes bugs #63705 and #67130.
1123 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1124 method; create a MemberCache for an interface type and cache the
1127 * decl.cs (IMemberContainer.ParentContainer): Removed.
1128 (IMemberContainer.ParentCache): New property.
1129 (MemberCache.SetupCacheForInterface): Removed.
1130 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1131 to create a cache for an interface's "parent".
1133 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1136 2004-11-16 Martin Baulig <martin@ximian.com>
1138 Merged back from gmcs; these changes already went into gmcs a
1139 couple of weeks ago.
1142 (TypeManager.AddUserType): Removed the `ifaces' argument.
1143 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
1145 (TypeManager.AddUserInterface): Removed.
1146 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
1148 (TypeManager.GetInterfaces): Likewise.
1149 (TypeManager.GetExplicitInterfaces): Likewise.
1151 * ecore.cs (TypeExpr.GetInterfaces): Removed.
1153 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
1154 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
1156 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1158 * statement.cs: Avoid adding bools to a hashtable.
1160 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1162 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1163 calling an unsafe method from a safe location.
1165 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1168 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1170 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1172 * namespace.cs (VerifyUsing): use GetPartialName instead of
1175 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1177 * statement.cs (Return.Resolve): Fix regression in typo: if
1178 `in_exc', we have to request a NeedReturnLabel, this was a typo
1179 introduced in the anonymous method check-in. Fixes #69131.
1181 * Indexers were using the ShortName when defining themselves,
1182 causing a regression in the compiler bootstrap when applying the
1183 patch from 2004-11-02 (first part), now they use their full name
1184 and the bug is gone.
1186 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1188 * driver.cs: Strip the path from the names of embedded resources. Fixes
1191 2004-11-04 Raja R Harinath <rharinath@novell.com>
1193 Fix error message regression: cs0104-2.cs.
1194 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1195 (AliasEntry.Resolve): Update.
1196 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1198 (RootContext.LookupType): Update.
1200 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1202 * cs-parser.jay: Add support for handling accessor modifiers
1203 * class: Add support port accessor modifiers and error checking,
1204 define PropertyMethod.Define as virtual (not abstract anymore)
1205 * ecore.cs: Add checking for proeprties access with access modifiers
1206 * iterators.cs: Modify Accessor constructor call based in the modified
1208 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1210 * expression.cs (StringConcat): Handle being called twice,
1211 as when we have a concat in a field init with more than two
1214 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1216 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1217 special case explicit implementations, we should always produce
1218 the .property or .event declaration.
1220 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1221 since it will not return correct data if people use this
1222 unresolved in the presence of using statements (see test-313).
1224 * class.cs (MethodData.Define): If we are an explicit interface
1225 implementation, set the method name to the full name of the
1226 interface plus the name of the method.
1228 Notice that using the method.MethodName.GetFullName() does not
1229 work, as it will only contain the name as declared on the source
1230 file (it can be a shorthand in the presence of using statements)
1231 and not the fully qualifed type name, for example:
1235 class D : ICloneable {
1236 object ICloneable.Clone () {
1240 Would produce a method called `ICloneable.Clone' instead of
1241 `System.ICloneable.Clone'.
1243 * namespace.cs (Alias.Resolve): Use GetPartialName.
1245 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1247 * cs-parser.jay: Add error 1055 report.
1249 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1251 * assign.cs (Assign.DoResolve): Only do the transform of
1252 assignment into a New if the types are compatible, if not, fall
1253 through and let the implicit code deal with the errors and with
1254 the necessary conversions.
1256 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1258 * cs-parser.jay: Add error 1031 report.
1260 * cs-tokenizer.cs: Add location for error 1038.
1262 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1264 * cs-parser.jay: Add error 1016 report.
1266 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1268 * cs-parser.jay: Add errors 1575,1611 report.
1270 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1272 * cs-parser.jay: Add error 1001 report.
1274 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1277 * attribute.cs (GetMarshal): Add method argument for
1278 caller identification.
1280 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1281 agument for GetMarshal and RuntimeMissingSupport.
1283 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1285 * attribute.cs (ExtractSecurityPermissionSet): Removed
1286 TypeManager.code_access_permission_type.
1288 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1290 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1292 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1293 for obsolete use of a variable here. Fixes regression on errors
1294 cs0619-25 and cs0619-26.
1296 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1298 Fix #62358, implemented security attribute encoding.
1300 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1301 Tests permitted SecurityAction for assembly or other types.
1302 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1303 data from SecurityPermissionAttribute to PermisionSet class.
1305 * class.cs (ApplyAttributeBuilder): Added special handling
1306 for System.Security.Permissions.SecurityAttribute based types.
1308 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1309 special handling for System.Security.Permissions.SecurityAttribute
1312 * enum.cs (ApplyAttributeBuilder): Added special handling
1313 for System.Security.Permissions.SecurityAttribute based types.
1315 * parameter.cs (ApplyAttributeBuilder): Added special handling
1316 for System.Security.Permissions.SecurityAttribute based types.
1318 * rootcontext.cs: Next 2 core types.
1320 * typemanager.cs (TypeManager.security_permission_attr_type):
1321 Built in type for the SecurityPermission Attribute.
1322 (code_access_permission_type): Build in type.
1324 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1326 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1327 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1328 all of this information into
1329 EmitContext.EmitCapturedVariableInstance.
1331 * codegen.cs (EmitCapturedVariableInstance): move here the
1332 funcionality of emitting an ldarg.0 in the presence of a
1333 remapping. This centralizes the instance emit code.
1335 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1336 then emit a load of this: it means that we have reached the
1337 topmost ScopeInfo: the one that contains the pointer to the
1338 instance of the class hosting the anonymous method.
1340 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1341 captures to the topmost CaptureContext.
1343 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1345 * expression.cs (LocalVariableReference): Move the knowledge about
1346 the iterators into codegen's EmitCapturedVariableInstance.
1348 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1350 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1351 all code paths return a value from an anonymous method (it is the
1352 same as the 161 error, but for anonymous methods).
1354 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1356 The introduction of anonymous methods in the compiler changed
1357 various ways of doing things in the compiler. The most
1358 significant one is the hard split between the resolution phase
1359 and the emission phases of the compiler.
1361 For instance, routines that referenced local variables no
1362 longer can safely create temporary variables during the
1363 resolution phase: they must do so from the emission phase,
1364 since the variable might have been "captured", hence access to
1365 it can not be done with the local-variable operations from the runtime.
1369 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1370 is a toplevel block.
1372 (ToplevelBlock): A new kind of Block, these are the blocks that
1373 are created by the parser for all toplevel method bodies. These
1374 include methods, accessors and anonymous methods.
1376 These contain some extra information not found in regular blocks:
1377 A pointer to an optional CaptureContext (for tracking captured
1378 local variables and parameters). A pointer to the parent
1381 (Return.Resolve): Catch missmatches when returning a value from an
1382 anonymous method (error 1662).
1383 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1386 (Break.Resolve): ditto.
1388 (SwitchLabel): instead of defining the labels during the
1389 resolution phase, we now turned the public ILLabel and ILLabelCode
1390 labels into methods called GetILLabelCode() and GetILLabel() that
1391 only define the label during the Emit phase.
1393 (GotoCase): Track the SwitchLabel instead of the computed label
1394 (its contained therein). Emit the code by using
1395 SwitchLabel.GetILLabelCode ().
1397 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1398 whether the Local has been captured or not.
1400 (LocalInfo.IsCaptured): New property, used to tell whether the
1401 local has been captured.
1403 * anonymous.cs: Vastly updated to contain the anonymous method
1406 The main classes here are: CaptureContext which tracks any
1407 captured information for a toplevel block and ScopeInfo used to
1408 track the activation frames for various local variables.
1410 Each toplevel block has an optional capture context associated
1411 with it. When a method contains an anonymous method both the
1412 toplevel method and the anonymous method will create a capture
1413 context. When variables or parameters are captured, they are
1414 recorded on the CaptureContext that owns them, for example:
1418 MyDelegate d = delegate {
1423 Here `a' will be recorded as captured on the toplevel
1424 CapturedContext, the inner captured context will not have anything
1425 (it will only have data if local variables or parameters from it
1426 are captured in a nested anonymous method.
1428 The ScopeInfo is used to track the activation frames for local
1429 variables, for example:
1431 for (int i = 0; i < 10; i++)
1432 for (int j = 0; j < 10; j++){
1433 MyDelegate d = delegate {
1438 At runtime this captures a single captured variable `i', but it
1439 captures 10 different versions of the variable `j'. The variable
1440 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1441 recorded on a child.
1443 The toplevel ScopeInfo will also track information like the `this'
1444 pointer if instance variables were referenced (this is necessary
1445 as the anonymous method lives inside a nested class in the host
1446 type of the method).
1448 (AnonymousMethod): Expanded to track the Toplevel, implement
1449 `AnonymousMethod.Compatible' to tell whether an anonymous method
1450 can be converted to a target delegate type.
1452 The routine now also produces the anonymous method content
1454 (AnonymousDelegate): A helper class that derives from
1455 DelegateCreation, this is used to generate the code necessary to
1456 produce the delegate for the anonymous method that was created.
1458 * assign.cs: API adjustments for new changes in
1459 Convert.ImplicitStandardConversionExists.
1461 * class.cs: Adjustments to cope with the fact that now toplevel
1462 blocks are of type `ToplevelBlock'.
1464 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1465 insteda of standard blocks.
1467 Flag errors if params arguments are passed to anonymous methods.
1469 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1470 `CurrentAnonymousMethod' which points to the current Anonymous
1471 Method. The variable points to the AnonymousMethod class that
1472 holds the code being compiled. It is set in the new EmitContext
1473 created for the anonymous method.
1475 (EmitContext.Phase): Introduce a variable and an enumeration to
1476 assist in enforcing some rules about when and where we are allowed
1477 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1478 only one that enfonces this right now).
1480 (EmitContext.HaveCaptureInfo): new helper method that returns
1481 whether we have a CapturedContext initialized.
1483 (EmitContext.CaptureVariable): New method used to register that a
1484 LocalInfo must be flagged for capturing.
1486 (EmitContext.CapturedParameter): New method used to register that a
1487 parameters must be flagged for capturing.
1489 (EmitContext.CapturedField): New method used to register that a
1490 field must be flagged for capturing.
1492 (EmitContext.HaveCapturedVariables,
1493 EmitContext.HaveCapturedFields): Return whether there are captured
1494 variables or fields.
1496 (EmitContext.EmitMethodHostInstance): This is used to emit the
1497 instance for the anonymous method. The instance might be null
1498 (static methods), this (for anonymous methods that capture nothing
1499 and happen to live side-by-side with the current method body) or a
1500 more complicated expression if the method has a CaptureContext.
1502 (EmitContext.EmitTopBlock): Routine that drives the emission of
1503 code: it will first resolve the top block, then emit any metadata
1504 and then emit the code. The split is done so that we can extract
1505 any anonymous methods and flag any captured variables/parameters.
1507 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1508 during this phase, the ILGenerator should not be used as labels
1509 and local variables declared here might not be accessible to any
1510 code that is part of an anonymous method.
1512 Exceptions to this include the temporary variables that are
1513 created by some statements internally for holding temporary
1516 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1519 (EmitContext.TemporaryReturn): This method is typically called
1520 from the Emit phase, and its the only place where we allow the
1521 ReturnLabel to be defined other than the EmitMeta. The reason is
1522 that otherwise we would have to duplicate a lot of logic in the
1523 Resolve phases of various methods that today is on the Emit
1526 (EmitContext.NeedReturnLabel): This no longer creates the label,
1527 as the ILGenerator is not valid during the resolve phase.
1529 (EmitContext.EmitThis): Extended the knowledge in this class to
1530 work in anonymous methods in addition to iterators.
1532 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1533 code is necessary on the stack to access the instance to a local
1534 variable (the variable will be accessed as a field).
1536 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1537 EmitContext.EmitAddressOfParameter): Routines to support
1538 parameters (not completed at this point).
1540 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1541 will also remove the parameters.
1543 * convert.cs (Convert): Define a `ConstantEC' which points to a
1544 null. This is just to prefity some code that uses
1545 ImplicitStandardConversion code and do not have an EmitContext
1548 The idea is to flag explicitly that at that point in time, it is
1549 known that the conversion will not trigger the delegate checking
1550 code in implicit conversions (which requires a valid
1553 Everywhere: pass new EmitContext parameter since
1554 ImplicitStandardConversionExists now requires it to check for
1555 anonymous method conversions.
1557 (Convert.ImplicitStandardConversionExists): If the type of an
1558 expression is the anonymous_method_type, and the type is a
1559 delegate, we invoke the AnonymousMethod.Compatible method to check
1560 whether an implicit conversion is possible.
1562 (Convert.ImplicitConversionStandard): Only do implicit method
1563 group conversions if the language level is not ISO_1.
1565 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1566 MethodInfo for the Invoke method. used by Delegate and
1569 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1570 method conversions if the target type is a delegate.
1572 Removed extra debugging nops.
1574 (LocalVariableReference): Turn the `local_info' into a public
1577 Add `prepared' field, the same hack used for FieldExprs to cope
1578 with composed assignments, as Local variables do not necessarily
1579 operate purely on the stack as they used to: they can be captured
1582 Add `temp' for a temporary result, like fields.
1584 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1586 It now copes with Local variables that are captured and emits the
1587 proper instance variable to load it from a field in the captured
1590 (ParameterReference.DoResolveBase): During the resolve phase,
1591 capture parameters if we are in an anonymous method.
1593 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1594 anonymous method, use the EmitContext helper routines to emit the
1595 parameter reference.
1597 * iterators.cs: Set RemapToProxy to true/false during the
1600 * parameters.cs (GetParameterByName): New helper method.
1602 * typemanager.cs (anonymous_method_type) a new type that
1603 represents an anonyous method. This is always an internal type,
1604 used as a fencepost to test against the anonymous-methodness of an
1607 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1609 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1611 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1613 2004-10-18 Martin Baulig <martin@ximian.com>
1615 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1616 `Type' directly, but call ResolveType() on it.
1617 (Catch.Resolve): Likewise.
1618 (Foreach.Resolve): Likewise.
1620 2004-10-18 Martin Baulig <martin@ximian.com>
1622 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1623 `Type' directly, but call ResolveType() on it.
1624 (Probe.DoResolve): Likewise.
1625 (ArrayCreation.LookupType): Likewise.
1626 (TypeOf.DoResolve): Likewise.
1627 (SizeOf.DoResolve): Likewise.
1629 2004-10-18 Martin Baulig <martin@ximian.com>
1631 * expression.cs (Invocation.BetterFunction): Put back
1632 TypeManager.TypeToCoreType().
1634 2004-10-18 Raja R Harinath <rharinath@novell.com>
1636 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1639 2004-10-18 Martin Baulig <martin@ximian.com>
1641 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1642 `Type' directly, but call ResolveType() on it.
1644 2004-10-18 Martin Baulig <martin@ximian.com>
1646 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1647 `Type' directly, but call ResolveType() on it.
1648 (MemberBase.DoDefine): Likewise.
1650 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1651 `Type' directly, but call ResolveType() on it.
1652 (ComposedCast.DoResolveAsTypeStep): Likewise.
1654 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1655 `Type' directly, but call ResolveType() on it.
1657 2004-10-17 John Luke <john.luke@gmail.com>
1659 * class.cs (Operator.GetSignatureForError): use CSharpName
1661 * parameter.cs (Parameter.GetSignatureForError): Returns
1662 correct name even if was not defined.
1664 2004-10-13 Raja R Harinath <rharinath@novell.com>
1667 * class.cs (TypeContainer.EmitContext): New property.
1668 (DefineNestedTypes): Create an emitcontext for each part.
1669 (MethodCore.DoDefineParameters): Use container's emitcontext.
1670 Pass type array to InternalParameters.
1671 (MemberBase.DoDefine): Use container's emitcontext.
1672 (FieldMember.Define): Likewise.
1673 (Event.Define): Likewise.
1674 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1675 Pass type array to InternalParameters.
1676 (SetIndexerMethod.GetParameterInfo): Likewise.
1677 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1678 * delegate.cs (Define): Pass emitcontext to
1679 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1680 array to InternalParameters.
1681 * expression.cs (ParameterReference.DoResolveBase): Pass
1682 emitcontext to GetParameterInfo.
1683 (ComposedCast.DoResolveAsTypeStep): Remove check on
1684 ec.ResolvingTypeTree.
1685 * parameter.cs (Parameter.Resolve): Change argument to
1686 EmitContext. Use ResolveAsTypeTerminal.
1687 (Parameter.GetSignature): Change argument to EmitContext.
1688 (Parameters.ComputeSignature): Likewise.
1689 (Parameters.ComputeParameterTypes): Likewise.
1690 (Parameters.GetParameterInfo): Likewise.
1691 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1692 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1693 * support.cs (InternalParameters..ctor): Remove variant that takes
1695 * typemanager.cs (system_intptr_expr): New.
1696 (InitExpressionTypes): Initialize it.
1698 2004-10-12 Chris Toshok <toshok@ximian.com>
1700 * cs-parser.jay: fix location for try_statement and catch_clause.
1702 2004-10-11 Martin Baulig <martin@ximian.com>
1704 * report.cs: Don't make --fatal abort on warnings, we have
1705 -warnaserror for that.
1707 2004-10-07 Raja R Harinath <rharinath@novell.com>
1709 More DeclSpace.ResolveType avoidance.
1710 * decl.cs (MemberCore.InUnsafe): New property.
1711 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1712 with newly created EmitContext.
1713 (FieldMember.Define): Likewise.
1714 * delegate.cs (Delegate.Define): Likewise.
1715 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1716 only if normal name-lookup fails.
1717 (TypeExpr.DoResolve): Enable error-checking.
1718 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1719 (SizeOf.DoResolve): Likewise.
1720 (ComposedCast.DoResolveAsTypeStep): Likewise.
1721 (StackAlloc.DoResolve): Likewise.
1722 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1723 (Block.Unsafe): New property.
1724 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1725 (Unsafe): Set 'unsafe' flag of contained block.
1726 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1727 (Fixed.Resolve): Likewise.
1728 (Catch.Resolve): Likewise.
1729 (Using.ResolveLocalVariableDecls): Likewise.
1730 (Foreach.Resolve): Likewise.
1732 2004-10-05 John Luke <john.luke@gmail.com>
1734 * cs-parser.jay: add location to error CS0175
1736 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1738 * ecore.cs (Expression.Constantity): Add support for turning null
1741 * const.cs (Const.Define): Allow constants to be reference types
1742 as long as the value is Null.
1744 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1746 * namespace.cs (NamespaceEntry.Using): No matter which warning
1747 level is set, check if this namespace name has already been added.
1749 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1751 * expression.cs: reftype [!=]= null should always use br[true,false].
1754 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1757 * attribute.cs: Enum conversion moved to
1758 GetAttributeArgumentExpression to be applied to the all
1761 2004-10-01 Raja R Harinath <rharinath@novell.com>
1763 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1764 * class.c (TypeContainer.DefineType): Flag error if
1765 base types aren't accessible due to access permissions.
1766 * decl.cs (DeclSpace.ResolveType): Move logic to
1767 Expression.ResolveAsTypeTerminal.
1768 (DeclSpace.ResolveTypeExpr): Thin layer over
1769 Expression.ResolveAsTypeTerminal.
1770 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1771 Refactor code into NestedAccess. Use it.
1772 (DeclSpace.NestedAccess): New.
1773 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1774 argument to silence errors. Check access permissions.
1775 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1776 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1777 (Cast.DoResolve): Likewise.
1778 (New.DoResolve): Likewise.
1779 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1780 (TypeOf.DoResolve): Likewise.
1782 * expression.cs (Invocation.BetterConversion): Return the Type of
1783 the better conversion. Implement section 14.4.2.3 more faithfully.
1784 (Invocation.BetterFunction): Make boolean. Make correspondence to
1785 section 14.4.2.2 explicit.
1786 (Invocation.OverloadResolve): Update.
1787 (Invocation): Remove is_base field.
1788 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1789 (Invocation.Emit): Likewise.
1791 2004-09-27 Raja R Harinath <rharinath@novell.com>
1793 * README: Update to changes.
1795 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1797 * cs-parser.jay: Reverted 642 warning fix.
1799 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1802 * decl.cs (FindMemberWithSameName): Indexer can have more than
1805 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1807 * expression.cs (LocalVariableReference.DoResolveLValue):
1808 Do not report warning 219 for out values.
1809 (EmptyExpression.Null): New member to avoid extra allocations.
1811 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1813 * cs-parser.jay: Fix wrong warning 642 report.
1815 * cs-tokenizer.cs (CheckNextToken): New helper;
1816 Inspect next character if is same as expected.
1818 2004-09-23 Martin Baulig <martin@ximian.com>
1820 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1821 (Convert.ImplicitReferenceConversionExists): Likewise.
1823 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1825 * class.cs (Operator.Define): Add error 448 and 559 report.
1827 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1829 * class.cs (MemberBase.IsTypePermitted): New protected
1830 method for checking error CS0610.
1832 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1834 * class.cs (TypeContainer.HasExplicitLayout): New property
1835 Returns whether container has StructLayout attribute set Explicit.
1836 (FieldMember): New abstract class for consts and fields.
1837 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1838 (Field): Reuse FieldMember.
1840 * const.cs (Const): Reuse FieldMember.
1842 * rootcontext.cs: EmitConstants call moved to class.
1844 2004-09-22 Martin Baulig <martin@ximian.com>
1846 Thanks to Peter Sestoft for this bug report.
1848 * expression.cs (Conditional): If both the `trueExpr' and the
1849 `falseExpr' is a NullLiteral, return a NullLiteral.
1851 2004-09-22 Martin Baulig <martin@ximian.com>
1853 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1854 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1855 for the "get_Current" call.
1857 2004-09-22 Martin Baulig <martin@ximian.com>
1859 Marek and me just fixed one of our oldest bugs: #28562 :-)
1861 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1863 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1864 we're an EnumConstant, just return that.
1865 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1866 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1867 to get the value which'll actually be written into the attribute.
1868 However, we have to use GetValue() to access the attribute's value
1871 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1873 * constant.cs (Constant.IsNegative): New abstract property
1876 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1877 (StackAlloc.DoResolve): Reused IsNegative.
1879 2004-09-21 Martin Baulig <martin@ximian.com>
1881 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1882 if we're used in an iterator, we may be called from different
1885 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1886 we actually have an exception block.
1888 2004-09-20 John Luke <jluke@cfl.rr.com>
1890 * class.cs, cs-parser.jay: Improve the error report for 1520:
1891 report the actual line where the error happens, not where the
1894 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1895 Pass location information that was available elsewhere.
1897 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1899 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1900 runtime to delay sign assemblies.
1902 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1904 * cs-parser.jay: Do not report the stack trace, this is barely
1907 2004-08-22 John Luke <john.luke@gmail.com>
1909 * driver.cs : check that a resource id is not already used
1910 before adding it, report CS1508 if it is, bug #63637
1912 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1914 * ecore.cs: Removed dead code.
1916 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1918 * class.cs: Do not report warning CS0067 on the interfaces.
1920 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1922 * cs-parser.jay: Add error 504 report.
1924 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1926 * rootcontext.cs: WarningLevel is 4 by default now.
1928 * statement.cs (Fixed.Resolve): Do not null
1931 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1934 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1935 deep search when property is not virtual.
1936 (PropertyExpr.ResolveAccessors): Make one call for both
1939 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1942 * statement.cs: Error 152 report constains also location.
1944 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1947 * const.cs: Explicitly set constant as static.
1949 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1952 * cs-parser.jay: Add error 1017 report.
1954 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1956 Fixed bug #59980, #64224
1957 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1959 * typemanager.cs (IsSpecialMethod): Simplified
1961 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1963 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1964 condition with better params.
1966 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1969 * attribute.cs (Resolve): Property has to have both
1972 2004-09-14 Martin Baulig <martin@ximian.com>
1974 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1976 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1979 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1980 called and is obsolete then this member suppress message
1981 when call is inside next [Obsolete] method or type.
1983 * expression.cs: Use TestObsoleteMethodUsage member.
1985 2004-09-14 Martin Baulig <martin@ximian.com>
1987 * cs-parser.jay: Sync a bit with the GMCS version.
1989 2004-09-14 Martin Baulig <martin@ximian.com>
1991 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1992 (CSharpParser.yacc_verbose_flag): New public field.
1994 * genericparser.cs: Removed.
1996 2004-09-14 Raja R Harinath <rharinath@novell.com>
1998 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
2000 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2002 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2004 2004-09-10 Martin Baulig <martin@ximian.com>
2006 Backported my MemberName changes from GMCS into MCS.
2008 - we are now using a special `MemberName' class instead of using
2009 strings; in GMCS, the `MemberName' also contains the type
2012 - changed the grammar rules a bit:
2013 * the old `member_name' is now a `namespace_or_type_name':
2014 The rule is that we use `namespace_or_type_name' everywhere
2015 where we expect either a "member name" (GetEnumerator) or a
2016 "member name" with an explicit interface name
2017 (IEnumerable.GetEnumerator).
2018 In GMCS, the explicit interface name may include type arguments
2019 (IEnumerable<T>.GetEnumerator).
2020 * we use `member_name' instead of just `IDENTIFIER' for
2022 The rule is that we use `member_name' wherever a member may
2023 have type parameters in GMCS.
2025 * decl.cs (MemberName): New public class.
2026 (MemberCore.MemberName): New public readonly field.
2027 (MemberCore.ctor): Take a `MemberName' argument, not a string.
2028 (DeclSpace): Likewise.
2030 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
2031 * enum.cs (Enum.ctor): Likewise.
2033 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
2035 (AliasEntry.ctor): Take a MemberName, not an Expression.
2036 (AliasEntry.UsingAlias): Likewise.
2038 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
2039 (IMethodData.MemberName): Changed type from string to MemberName.
2040 (MemberBase.ExplicitInterfaceName): Likewise.
2041 (AbstractPropertyEventMethod.SetupName): Make this private.
2042 (AbstractPropertyEventMethod.ctor): Added `string prefix'
2043 argument; compute the member name here.
2044 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
2045 on the `member.MemberName' and the `prefix'.
2047 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
2049 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
2050 thus, we get a `MemberName' instead of a `string'. These
2051 declarations may have type parameters in GMCS.
2052 (interface_method_declaration, delegate_declaration): Likewise.
2053 (class_declaration, interface_declaration): Likewise.
2054 (method_header): Use `namespace_or_type_name' instead of
2055 `member_name'. We may be an explicit interface implementation.
2056 (property_declaration, event_declaration): Likewise.
2057 (member_name): This is now just an `IDENTIFIER', not a
2058 `namespace_or_type_name'.
2059 (type_name, interface_type): Removed.
2060 (namespace_or_type_name): Return a MemberName, not an Expression.
2061 (primary_expression): Use `member_name' instead of `IDENTIFIER';
2062 call GetTypeExpression() on the MemberName to get an expression.
2063 (IndexerDeclaration.interface_type): Changed type from string to
2065 (MakeName): Operate on MemberName's instead of string's.
2067 2004-09-13 Raja R Harinath <rharinath@novell.com>
2070 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
2071 (NamespaceEntry.Lookup): Add new argument to flag if we want the
2072 lookup to avoid symbols introduced by 'using'.
2073 * rootcontext.cs (NamespaceLookup): Update.
2075 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2077 * class.cs (TypeContainer.DoDefineMembers): Do not call
2078 DefineDefaultConstructor for static classes.
2080 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2082 * attribute.cs (Attribute.Resolve): Add error 653 report.
2084 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2086 (Method.ApplyAttributeBuilder): Add error 685 report.
2087 (Operator.Define): Add error 564 report.
2089 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2091 * expression.cs (Invocation.DoResolve): Add error
2094 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2097 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2099 * class.cs (ConstructorInitializer.Resolve):
2100 Wrong error number (515->516).
2102 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2104 * class.cs (Indexer.Define): Add error 631 report.
2106 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2108 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2110 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2112 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2114 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2116 * cs-parser.jay: Added error CS0241 report.
2118 2004-09-10 Raja R Harinath <rharinath@novell.com>
2120 * cs-parser.jay (fixed_statement): Introduce a scope for the
2121 declaration in the 'fixed' statement.
2123 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2125 * cs-parser.jay: Added CS0230 error report.
2127 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2129 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2131 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2133 * expression.cs (Argument.Resolve): Added error CS0192 and
2136 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2138 C# 2.0 #pragma warning feature
2140 * cs-tokenizer.cs (PreProcessPragma): New method;
2141 Handles #pragma directive.
2143 * report.cs (WarningRegions): New class; Support
2144 class for #pragma warning directive. It tests whether
2145 warning is enabled for a given line.
2147 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2149 * const.cs: Add more descriptive error report, tahnks to
2152 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2154 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2156 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2158 * expression.cs: Apply patch from Ben: Remove dead code from
2159 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2160 as that code just threw an exception anwyays.
2162 * const.cs: Remove the call to the turnintoconstant, for details
2165 * literal.cs: The type of the null-literal is the null type; So
2166 we use a placeholder type (literal.cs:System.Null, defined here)
2169 * expression.cs (Conditional.DoResolve): Remove some old code that
2170 is no longer needed, conversions have been fixed.
2172 (ArrayCreationExpression.DoResolve): Return false if we fail to
2173 resolve the inner expression.
2175 2004-09-07 Raja R Harinath <rharinath@novell.com>
2178 * cs-parser.jay (delegate_declaration): Record a delegate
2179 declaration as a type declaration.
2180 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2182 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2184 * parameter.cs: Do not crash if the type can not be resolved.
2186 * expression.cs: Report errors with unsafe pointers, fixes #64896
2188 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2190 * expression.cs: Pointer arith always needs to do a conv.i
2191 if the operand is a long. fix 65320
2193 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2195 Fixed cs0619-37.cs, cs0619-38.cs
2197 * enum.cs (GetObsoleteAttribute): Removed.
2199 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2200 on Enum member is double staged. The first is tested member
2203 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2205 Fixed #56986, #63631, #65231
2207 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2208 adds member to name container.
2209 (TypeContainer.AddToTypeContainer): New method, adds type to
2211 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2212 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2213 AddOperator): Simplified by reusing AddToMemberContainer.
2214 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2216 (Method.CheckForDuplications): Fixed implementation to test all
2218 (MemberBase): Detection whether member is explicit interface
2219 implementation is now in constructor.
2220 (MemberBase.UpdateMemberName): Handles IndexerName.
2221 (Accessor): Changed to keep also location information.
2222 (AbstractPropertyEventMethod): Is derived from MemberCore.
2223 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2224 will be emited or not.
2225 (PropertyBase.AreAccessorsDuplicateImplementation):
2226 Tests whether accessors are not in collision with some method.
2227 (Operator): Is derived from MethodCore to simplify common
2230 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2232 (DeclSpace.AddToContainer): Adds the member to defined_names
2233 table. It tests for duplications and enclosing name conflicts.
2235 * enum.cs (EnumMember): Clean up to reuse the base structures
2237 2004-09-03 Martin Baulig <martin@ximian.com>
2239 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2240 into TypeContainer, to make partial classes work again.
2242 2004-09-03 Martin Baulig <martin@ximian.com>
2244 * rootcontext.cs (RootContext.V2): Removed.
2246 2004-03-23 Martin Baulig <martin@ximian.com>
2248 * expression.cs (Invocation.OverloadResolve): Added `bool
2249 may_fail' argument and use it instead of the Location.IsNull() hack.
2251 2004-09-03 Martin Baulig <martin@ximian.com>
2253 Merged latest changes into gmcs. Please keep this comment in
2254 here, it makes it easier for me to see what changed in MCS since
2255 the last time I merged.
2257 2004-09-03 Raja R Harinath <rharinath@novell.com>
2260 * expression.cs (BetterConversion): Don't allow either conversion
2261 to be null. Remove redundant implicit conversion test when 'q ==
2262 null' -- when this function is invoked, we already know that the
2263 implicit conversion exists.
2264 (BetterFunction): Assume that 'best' is non-null. Remove
2265 redundant reimplementation of IsApplicable when 'best' is null.
2266 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2267 number of arguments.
2268 (IsAncestralType): Extract from OverloadResolve.
2269 (OverloadResolve): Make robust to the MethodGroupExpr being
2270 unsorted. Implement all the logic of Section 14.5.5.1, and
2271 support overloading of methods from multiple applicable types.
2272 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2274 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2275 (RealError, Warning): Append type of report to related symbol.
2277 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2279 * enum.cs: Fixed CLS-Compliance checks for enum members.
2280 Error tests cs3008-8.cs, cs3014-8.cs
2282 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2284 Fixed bug #62342, #63102
2285 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2286 like ImplementMethod.
2288 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2290 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2293 2004-09-02 Martin Baulig <martin@ximian.com>
2295 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2296 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2299 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2301 C# 2.0 Static classes implemented
2303 * class.cs (TypeContainer): instance_constructors,
2304 initialized_fields, initialized_static_fields,
2305 default_constructor, base_inteface_types are protected to be
2306 accessible from StaticClass.
2307 (TypeContainer.DefineDefaultConstructor): New virtual method
2308 for custom default constructor generating
2309 (StaticClass): New class to handle "Static classes" feature.
2311 * cs-parser.jay: Handle static keyword on class like instance
2314 * driver.cs: Added "/langversion" command line switch with two
2315 options (iso-1, default).
2317 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2319 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2321 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2323 * delegate.cs: Style.
2325 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2327 * delegate.cs: Add seperate instance expr field for miguel.
2329 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2331 * PointerArithmetic (Resolve): make sure we are not doing
2332 pointer arith on void*. Also, make sure we are resolved
2333 by not setting eclass until resolve.
2335 All callers: Make sure that PointerArithmetic gets resolved.
2337 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2339 * ArrayCreation (LookupType): If the type does not resolve
2340 to an array, give an error.
2342 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2344 * statement.cs (Try.Resolve): Fixed bug #64222
2346 2004-08-27 Martin Baulig <martin@ximian.com>
2349 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2352 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2354 * ecore.cs (Constantify): Get underlying type via
2355 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2356 Windows in special cases.
2358 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2360 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2361 for obtaining also private methods.
2362 (GetRemoveMethod): Used GetRemoveMethod (true)
2363 for obtaining also private methods.
2365 2004-08-24 Martin Baulig <martin@ximian.com>
2367 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2368 MethodAttributes.HideBySig for operators.
2370 2004-08-23 Martin Baulig <martin@ximian.com>
2372 Back to the old error reporting system :-)
2374 * report.cs (Message): Removed.
2375 (Report.MessageData, ErrorData, WarningData): Removed.
2376 (Report.Error, Warning): Back to the old system.
2378 2004-08-23 Martin Baulig <martin@ximian.com>
2380 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2382 * class.cs (TypeContainer.ParentContainer): New public virtual
2383 method; replaces the explicit interface implementation.
2384 (ClassPart.ParentContainer): Override.
2386 2004-08-23 Martin Baulig <martin@ximian.com>
2388 * statement.cs (Switch): Added support for constant switches; see
2389 #59428 or test-285.cs.
2391 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2394 * statement.cs (GetEnumeratorFilter): Removed useless
2395 logic because C# specs is strict. GetEnumerator must be
2398 2004-08-22 Martin Baulig <martin@ximian.com>
2400 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2401 a switch and may break, reset the barrier. Fixes #59867.
2403 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2405 CLS-Compliance speed up (~5% for corlib)
2407 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2408 New method. Tests container for CLS-Compliant names
2410 * class.cs (TypeContainer.VerifyClsName): New method.
2411 Checks whether container name is CLS Compliant.
2412 (Constructor): Implements IMethodData.
2414 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2415 low-case table for CLS Compliance test.
2416 (MemberCache.VerifyClsParameterConflict): New method.
2417 Checks method parameters for CS3006 error.
2419 * enum.cs (EnumMember): Is derived from MemberCore.
2420 (Enum.VerifyClsName): Optimized for better performance.
2422 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2424 * report.cs: Renamed Error_T to Error and changed all
2427 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2429 * class.cs (TypeContainer.IndexerArrayList): New inner class
2430 container for indexers.
2431 (TypeContainer.DefaultIndexerName): New constant for default
2432 indexer name. Replaced all "Item" with this constant.
2433 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2435 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2436 DefaultMemberAttribute constructor.
2438 2004-08-05 Martin Baulig <martin@ximian.com>
2440 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2443 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2445 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2446 multi platforms problem.
2448 * compiler.csproj: Included shared files.
2450 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2452 Fix bug 60333, 55971 in the more general way
2453 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2454 Added arg_type argument for constant conversion.
2455 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2457 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2460 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2461 OperatorArrayList, MethodCoreArrayList for typecontainer
2462 containers. Changed class member types to these new types.
2463 (MethodArrayList.DefineMembers): Added test for CS0659.
2465 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2467 * cfold.cs: Synchronize the folding with the code in expression.cs
2468 Binary.DoNumericPromotions for uint operands.
2470 * attribute.cs: Revert patch from Raja, it introduced a regression
2471 while building Blam-1.2.1 (hard to isolate a test case).
2473 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2477 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2479 (MethodCore.parent_method): New member. The method we're overriding
2480 if this is an override method.
2481 (MethodCore.CheckBase): Moved from Method class and made common.
2482 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2484 (MethodCore.CheckForDuplications): New abstract method. For custom
2485 member duplication search in a container
2486 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2487 method and its return type.
2488 (Event.conflict_symbol): New member. Symbol with same name in the
2492 (MemberCache.FindMemberWithSameName): New method. The method
2493 is looking for conflict with inherited symbols.
2495 2004-08-04 Martin Baulig <martin@ximian.com>
2497 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2499 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2501 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2503 * report.cs (Message): New enum for better error, warning reference in
2505 (MessageData): New inner abstract class. It generally handles printing of
2506 error and warning messages.
2507 Removed unused Error, Warning, Message methods.
2509 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2511 Fix for cs0592-8.cs test
2513 (Attributable.ValidAttributeTargets): Made public.
2514 (Attribute.ExplicitTarget): New member for explicit target value.
2515 (Attribute.CheckTargets): Now we translate explicit attribute
2516 target to Target here.
2518 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2520 * ecore.cs (MethodGroupExpr): new IsBase property.
2522 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2524 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2525 rather than an instance expr.
2527 (DelegateCreation.Emit): Use the method group rather than
2528 the instance expression. Also, if you have base.Foo as the
2529 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2531 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2533 (NewDelegate.DoResolve): Only check for the existance of Invoke
2534 if the method is going to be needed. Use MethodGroupExpr.
2536 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2538 * expression.cs: For pointer arith., make sure to use
2539 the size of the type, not the size of the pointer to
2542 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2545 * class.cs (Class): Added error CS0502 test.
2547 2004-08-03 John Luke <jluke@cfl.rr.com>
2548 Raja R Harinath <rharinath@novell.com>
2551 * attribute.cs (Attribute.complained_before): New flag.
2552 (Attribute.ResolveType, Attribute.Resolve),
2553 (Attribute.DefinePInvokeMethod): Set it.
2554 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2556 2004-08-03 Martin Baulig <martin@ximian.com>
2558 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2559 use a user-defined operator; we still need to do numeric
2560 promotions in case one argument is a builtin type and the other
2561 one has an implicit conversion to that type. Fixes #62322.
2563 2004-08-02 Martin Baulig <martin@ximian.com>
2565 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2566 (LocalInfo.IsThis): New public property.
2567 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2569 2004-08-01 Martin Baulig <martin@ximian.com>
2571 * class.cs (TypeContainer.GetClassBases): Don't set the default
2572 here since we may get called from GetPartialBases().
2573 (TypeContainer.DefineType): If GetClassBases() didn't return a
2574 parent, use the default one.
2576 2004-07-30 Duncan Mak <duncan@ximian.com>
2578 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2580 2004-07-30 Martin Baulig <martin@ximian.com>
2582 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2584 * class.cs (SourceMethod): New public class, derive from the
2585 symbol writer's ISourceMethod.
2586 (Method): Use the new symbol writer API.
2588 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2589 as argument and use the new symbol writer.
2592 (SourceFile): Implement the symbol writer's ISourceFile.
2593 (Location.SymbolDocument): Removed.
2594 (Location.SourceFile): New public property.
2596 * symbolwriter.cs: Use the new symbol writer API.
2598 2004-07-30 Raja R Harinath <rharinath@novell.com>
2600 * Makefile (install-local): Remove. Functionality moved to
2603 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2605 * Makefile: Install mcs.exe.config file together with mcs.exe.
2606 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2607 correct runtime version.
2609 2004-07-25 Martin Baulig <martin@ximian.com>
2612 (TypeContainer.RegisterOrder): Removed, this was unused.
2613 (TypeContainer, interface_order): Removed.
2614 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2615 TypeContainer as argument since we can also be called with a
2616 `PartialContainer' for a partial class/struct/interface.
2617 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2618 of checking whether we're an `Interface' - we could be a
2620 (PartialContainer.Register): Override; call
2621 AddClass()/AddStruct()/AddInterface() on our parent.
2623 * cs-parser.jay (interface_member_declaration): Add things to the
2624 `current_container', not the `current_class'.
2626 * rootcontext.cs (RegisterOrder): The overloaded version which
2627 takes an `Interface' was unused, removed.
2629 * typemanager.cs (TypeManager.LookupInterface): Return a
2630 `TypeContainer', not an `Interface'.
2631 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2632 contain a `PartialContainer' for an interface, so check it's
2633 `Kind' to figure out what it is.
2635 2004-07-25 Martin Baulig <martin@ximian.com>
2637 * class.cs (Class.DefaultTypeAttributes): New public constant.
2638 (Struct.DefaultTypeAttributes): Likewise.
2639 (Interface.DefaultTypeAttributes): Likewise.
2640 (PartialContainer.TypeAttr): Override this and add the
2641 DefaultTypeAttributes.
2643 2004-07-25 Martin Baulig <martin@ximian.com>
2645 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2646 we can just use the `Parent' field instead.
2648 2004-07-25 Martin Baulig <martin@ximian.com>
2650 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2652 2004-07-25 Martin Baulig <martin@ximian.com>
2654 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2655 our parts before defining any methods.
2656 (TypeContainer.VerifyImplements): Make this virtual.
2657 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2658 on our PartialContainer.
2660 2004-07-25 Martin Baulig <martin@ximian.com>
2662 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2664 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2665 argument, we can just use the `Parent' field instead.
2668 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2669 (MemberBase.DoDefine): Likewise.
2671 2004-07-24 Martin Baulig <martin@ximian.com>
2673 * decl.cs (MemberCore.Parent): New public field.
2674 (DeclSpace.Parent): Moved to MemberCore.
2676 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2677 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2679 (FieldBase, Field, Operator): Likewise.
2680 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2681 (EventField, Event): Likewise.
2683 2004-07-23 Martin Baulig <martin@ximian.com>
2685 * class.cs (PartialContainer): New public class.
2686 (ClassPart): New public class.
2687 (TypeContainer): Added support for partial classes.
2688 (TypeContainer.GetClassBases): Splitted some of the functionality
2689 out into GetNormalBases() and GetPartialBases().
2691 * cs-tokenizer.cs (Token.PARTIAL): New token.
2692 (Tokenizer.consume_identifier): Added some hacks to recognize
2693 `partial', but only if it's immediately followed by `class',
2694 `struct' or `interface'.
2696 * cs-parser.jay: Added support for partial clases.
2698 2004-07-23 Martin Baulig <martin@ximian.com>
2700 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2701 a `DeclSpace' and also made it readonly.
2702 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2703 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2704 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2706 * cs-parser.jay: Pass the `current_class', not the
2707 `current_container' (at the moment, this is still the same thing)
2708 to a new Method, Property, Event, Indexer or Constructor.
2710 2004-07-23 Martin Baulig <martin@ximian.com>
2712 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2713 and removed the `current_interface' one.
2714 (struct_declaration, class_declaration, interface_declaration):
2715 Set `current_class' to the newly created class/struct/interface;
2716 set their `Bases' and call Register() before parsing their body.
2718 2004-07-23 Martin Baulig <martin@ximian.com>
2720 * class.cs (Kind): New public enum.
2721 (TypeContainer): Made this class abstract.
2722 (TypeContainer.Kind): New public readonly field.
2723 (TypeContainer.CheckDef): New public method; moved here from
2725 (TypeContainer.Register): New public abstract method.
2726 (TypeContainer.GetPendingImplementations): New public abstract
2728 (TypeContainer.GetClassBases): Removed the `is_class' and
2729 `is_iface' parameters.
2730 (TypeContainer.DefineNestedTypes): Formerly known as
2732 (ClassOrStruct): Made this class abstract.
2734 * tree.cs (RootTypes): New public type.
2736 2004-07-20 Martin Baulig <martin@ximian.com>
2738 * tree.cs (Tree.RecordNamespace): Removed.
2739 (Tree.Namespaces): Removed.
2741 * rootcontext.cs (RootContext.IsNamespace): Removed.
2743 * cs-parser.jay (namespace_declaration): Just create a new
2744 NamespaceEntry here.
2746 2004-07-20 Martin Baulig <martin@ximian.com>
2748 * statement.cs (ExceptionStatement): New abstract class. This is
2749 now used as a base class for everyone who's using `finally'.
2750 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2751 our local variables before using them.
2753 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2754 virtual method. This is used by Yield.Resolve() to "steal" an
2755 outer block's `finally' clauses.
2756 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2759 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2760 version which takes an ExceptionStatement. This version must be
2761 used to create exception branchings.
2764 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2765 (Iterator.EmitMoveNext): Added exception support; protect the
2766 block with a `fault' clause, properly handle 'finally' clauses.
2767 (Iterator.EmitDispose): Run all the `finally' clauses here.
2769 2004-07-20 Martin Baulig <martin@ximian.com>
2771 * iterator.cs: This is the first of a set of changes in the
2772 iterator code. Match the spec more closely: if we're an
2773 IEnumerable, then GetEnumerator() must be called. The first time
2774 GetEnumerator() is called, it returns the current instance; all
2775 subsequent invocations (if any) must create a copy.
2777 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2779 * expression.cs: Resolve the constant expression before returning
2782 2004-07-19 Martin Baulig <martin@ximian.com>
2784 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2785 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2786 the return type of the new EmitContext.
2788 2004-07-18 Martin Baulig <martin@ximian.com>
2790 * class.cs (Property.Define): Fix iterators.
2792 * iterators.cs (Iterator.Define): Moved the
2793 `container.AddInterator (this)' call here from the .ctor; only do
2794 it if we resolved successfully.
2796 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2798 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2799 `true' for preprocessing directives that we parse. The return
2800 value indicates whether we should return to regular tokenizing or
2801 not, not whether it was parsed successfully.
2803 In the past if we were in: #if false ... #line #endif, we would
2804 resume parsing after `#line'. See bug 61604.
2806 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2807 building: IsEnumType should return true only for enums, not for
2808 enums or System.Enum itself. This fixes #61593.
2810 Likely what happened is that corlib was wrong: mcs depended on
2811 this bug in some places. The bug got fixed, we had to add the
2812 hack, which caused bug 61593.
2814 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2815 that was a workaround for the older conditions.
2817 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2819 * assign.cs: IAssignMethod has a new interface, as documented
2820 inline. All assignment code now uses this new api.
2822 * ecore.cs, expression.cs: All classes which implement
2823 IAssignMethod now use the new interface.
2825 * expression.cs (Invocation): add a hack to EmitCall so that
2826 IndexerAccess can be the target of a compound assignment without
2827 evaluating its arguments twice.
2829 * statement.cs: Handle changes in Invocation api.
2831 2004-07-16 Martin Baulig <martin@ximian.com>
2833 * iterators.cs: Rewrote this. We're now using one single Proxy
2834 class for both the IEnumerable and the IEnumerator interface and
2835 `Iterator' derives from Class so we can use the high-level API.
2837 * class.cs (TypeContainer.AddIterator): New method.
2838 (TypeContainer.DoDefineType): New protected virtual method, which
2839 is called from DefineType().
2840 (TypeContainer.DoDefineMembers): Call DefineType() and
2841 DefineMembers() on all our iterators.
2842 (TypeContainer.Emit): Call Emit() on all our iterators.
2843 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2845 * codegen.cs (EmitContext.CurrentIterator): New public field.
2847 2004-07-15 Martin Baulig <martin@ximian.com>
2850 (TypeManager.not_supported_exception_type): New type.
2852 2004-07-14 Martin Baulig <martin@ximian.com>
2854 * iterators.cs: Use real error numbers.
2856 2004-07-14 Martin Baulig <martin@ximian.com>
2858 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2859 requires this to be a System.Collection.IEnumerable and not a
2860 class implementing that interface.
2861 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2863 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2865 * class.cs: Fixed previous fix, it broke some error tests.
2867 2004-07-12 Martin Baulig <martin@ximian.com>
2869 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2872 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2874 * assign.cs (LocalTemporary): Add new argument: is_address,If
2875 `is_address' is true, then the value that we store is the address
2876 to the real value, and not the value itself.
2878 * ecore.cs (PropertyExpr): use the new local temporary
2879 stuff to allow us to handle X.Y += z (where X is a struct)
2881 2004-07-08 Martin Baulig <martin@ximian.com>
2883 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2884 not always return, just like we're doing in Using.Resolve().
2886 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2888 * cs-parser.jay (fixed_statement): flag this as Pinned.
2890 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2892 * typemanager.cs (TypeManager): Removed MakePinned method, this
2893 mechanism is replaced with the .NET 2.x compatible mechanism of
2894 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2896 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2897 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2898 `IsFixed' property which has a different meaning.
2900 2004-07-02 Raja R Harinath <rharinath@novell.com>
2902 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2903 visible from inside a nested class, not just the names of the
2904 immediately enclosing class.
2907 2004-06-24 Raja R Harinath <rharinath@novell.com>
2909 * expression.cs (BetterConversion): Remove buggy special-case
2910 handling of "implicit constant expression conversions". At this
2911 point, we already know that the conversion is possible -- we're
2912 only checking to see which is better.
2914 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2916 * cs-parser.jay: Added error CS0210 test.
2918 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2920 * cs-parser.jay: Added error CS0134 test.
2922 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2925 * cs-parser.jay: Added error CS0145 test.
2927 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2929 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2931 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2933 * expression.cs (StackAlloc.Resolve): The argument may not
2934 be a constant; deal with this case.
2936 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2938 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2939 GetIndexerAttributeValue.
2940 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2942 * class.cs (Indexer.Define): Added error tests for CS0415,
2945 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2947 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2950 2004-06-23 Martin Baulig <martin@ximian.com>
2952 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2953 neither return nor throw, reset the barrier as well. Fixes #60457.
2955 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2957 * class.cs : EventAttributes is now set to None by default.
2958 This fixes bug #60459.
2960 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2963 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2964 Don't throw exception but return null (it's sufficient now).
2966 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2968 * typemanager.cs (GetArgumentTypes): Faster implementation.
2970 2004-06-18 Martin Baulig <martin@ximian.com>
2972 * attribute.cs (Attribute.Resolve): Check whether we're an
2973 EmptyCast which a Constant child. Fixes #60333.
2975 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2977 * statement.cs (EmitCollectionForeach): Account for the fact that
2978 not all valuetypes are in areas which we can take the address of.
2979 For these variables, we store to a temporary variable. Also, make
2980 sure that we dont emit a `callvirt' on a valuetype method.
2982 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2984 * expression.cs (StackAlloc.DoReSolve): Added test for
2985 negative parameter (CS0247).
2987 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2990 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2992 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2995 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2998 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3000 Fix bug #58254 & cs1555.cs, cs1556.cs
3001 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3003 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3005 * cs-parser.jay: Added error CS1669 test for indexers.
3007 2004-06-11 Martin Baulig <martin@ximian.com>
3009 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3010 call this twice: for params and varargs methods.
3012 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3015 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3017 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3019 * attribute.cs (Attribute.GetValidTargets): Made public.
3022 (AbstractPropertyEventMethod): New class for better code sharing.
3023 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3025 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3027 2004-06-11 Raja R Harinath <rharinath@novell.com>
3030 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
3031 that the call to Resolve is part of a MemberAccess.
3032 (Expression.Resolve): Use it for SimpleName resolution.
3033 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
3034 Add 'intermediate' boolean argument.
3035 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
3036 error message when the SimpleName can be resolved ambiguously
3037 between an expression and a type.
3038 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
3040 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
3041 call on the left-side.
3043 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3046 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
3048 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3050 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
3052 2004-06-11 Martin Baulig <martin@ximian.com>
3054 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
3055 varargs methods if applicable.
3057 2004-06-11 Martin Baulig <martin@ximian.com>
3059 * expression.cs (Invocation.EmitCall): Don't use
3060 `method.CallingConvention == CallingConventions.VarArgs' since the
3061 method could also have `CallingConventions.HasThis'.
3063 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3065 * class.cs (Event.GetSignatureForError): Implemented.
3066 Fixed crash in error test cs3010.cs
3068 2004-06-10 Miguel de Icaza <miguel@ximian.com>
3070 * cs-tokenizer.cs: Change the way we track __arglist to be
3071 consistent with the other keywords.
3073 2004-06-09 Miguel de Icaza <miguel@ximian.com>
3075 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
3078 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
3080 * codegen.cs: Check that all referenced assemblies have a strongname
3081 before strongnaming the compiled assembly. If not report error CS1577.
3082 Fix bug #56563. Patch by Jackson Harper.
3083 * typemanager.cs: Added a method to return all referenced assemblies.
3084 Fix bug #56563. Patch by Jackson Harper.
3086 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3089 (Method.ApplyAttributeBuilder): Moved and added conditional
3090 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
3093 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
3095 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3098 * class.cs: (EventField.attribute_targets): Changed default target.
3100 2004-06-08 Martin Baulig <martin@ximian.com>
3102 * expression.cs (Invocation.EmitCall): Enable varargs methods.
3104 2004-06-08 Martin Baulig <martin@ximian.com>
3106 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
3108 2004-06-07 Martin Baulig <martin@ximian.com>
3110 Added support for varargs methods.
3112 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
3115 * cs-parser.jay: Added support for `__arglist'.
3117 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
3119 * expression.cs (Argument.AType): Added `ArgList'.
3120 (Invocation): Added support for varargs methods.
3121 (ArglistAccess): New public class.
3122 (Arglist): New public class.
3124 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
3126 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
3127 a method's top-level block if the method has varargs.
3129 * support.cs (ReflectionParameters, InternalParameters): Added
3130 support for varargs methods.
3132 2004-06-07 Miguel de Icaza <miguel@ximian.com>
3134 * class.cs: Provide location in indexer error report.
3136 * driver.cs: Use standard names.
3138 * namespace.cs: Catch the use of using after a namespace has been
3139 declared also on using aliases.
3141 2004-06-03 Raja R Harinath <rharinath@novell.com>
3144 * typemanager.cs (closure_private_ok, closure_invocation_type)
3145 (closure_qualifier_type, closure_invocation_assembly)
3146 (FilterWithClosure): Move to ...
3147 (Closure): New internal nested class.
3148 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
3149 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
3150 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
3151 (MemberLookup, MemberLookupFailed): Use it.
3152 * expression.cs (New.DoResolve): Treat the lookup for the
3153 constructor as being qualified by the 'new'ed type.
3154 (Indexers.GetIndexersForTypeOrInterface): Update.
3156 2004-06-03 Marek Safar <marek.safar@seznam.cz>
3159 (GetConditionalAttributeValue): New method. Returns
3160 condition of ConditionalAttribute.
3161 (SearchMulti): New method. Returns all attributes of type 't'.
3162 Use it when attribute is AllowMultiple = true.
3163 (IsConditionalMethodExcluded): New method.
3166 (Method.IsExcluded): Implemented. Returns true if method has conditional
3167 attribute and the conditions is not defined (method is excluded).
3168 (IMethodData): Extended interface for ConditionalAttribute support.
3169 (PropertyMethod.IsExcluded): Implemented.
3172 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
3175 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
3178 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
3180 * expression.cs (ArrayCreationExpression): Make this just an
3181 `expression'. It can't be a statement, so the code here was
3184 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3187 * typemanager.cs (GetFullNameSignature): New method for
3190 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3193 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3194 Use this method when MethodBuilder is null.
3195 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3196 Added test for error CS0626 (MONO reports error for this situation).
3197 (IMethodData.GetSignatureForError): Extended interface.
3199 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3202 (AttributeTester.GetObsoleteAttribute): Returns instance of
3203 ObsoleteAttribute when type is obsolete.
3206 (TypeContainer.VerifyObsoleteAttribute): Override.
3207 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3208 (MethodCode.VerifyObsoleteAttribute): Override.
3209 (MemberBase.VerifyObsoleteAttribute): Override.
3212 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3213 and report proper error.
3216 Delegate.VerifyObsoleteAttribute): Override.
3219 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3220 and report proper error.
3221 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3224 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3228 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3229 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3230 Added test for ObsoleteAttribute.
3233 (Catch): Derived from Statement.
3235 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3237 Fixed bug #59071 & cs0160.cs
3239 * statement.cs (Try.Resolve): Check here whether order of catch
3240 clauses matches their dependencies.
3242 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3244 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3245 caused a regression: #59343. Referencing nested classes from an
3246 assembly stopped working.
3248 2004-05-31 Martin Baulig <martin@ximian.com>
3250 MCS is now frozen for beta 2.
3252 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3254 * convert.cs: add a trivial cache for overload operator resolution.
3256 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3258 * decl.cs: If possible, use lookuptypedirect here. We can only do
3259 this if there is no `.' after the namespace. Avoids using
3260 LookupType, which does lots of slow processing.
3261 (FindNestedType) New method, does what it says :-).
3262 * namespace.cs: use LookupTypeDirect.
3263 * rootcontext.cs: use membercache, if possible.
3264 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3266 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3269 According to the spec,
3271 In a member access of the form E.I, if E is a single identifier,
3272 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3273 field, property, localvariable, or parameter with the same type as
3274 the meaning of E as a type-name (§3.8), then both possible
3275 meanings of E are permitted.
3277 We did not check that E as a simple-name had the same type as E as
3280 This trivial check gives us 5-7% on bootstrap time.
3282 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3284 * expression.cs (Invocation.OverloadResolve): Avoid the
3285 use of hashtables and boxing here by allocating on demand.
3287 2004-05-30 Martin Baulig <martin@ximian.com>
3289 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3290 we're doing a silent lookup. Don't try to lookup nested types in
3291 TypeManager.object_type (thanks to Ben Maurer).
3293 2004-05-30 Martin Baulig <martin@ximian.com>
3295 Committing a patch from Ben Maurer.
3297 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3299 2004-05-29 Martin Baulig <martin@ximian.com>
3301 * class.cs (IMethodData.ShouldIgnore): New method.
3303 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3304 `Location' argument, we don't need it anywhere. Use
3305 `IMethodData.ShouldIgnore ()' instead of
3306 `MethodData.GetMethodFlags ()'.
3307 (TypeManager.AddMethod): Removed.
3308 (TypeManager.AddMethod2): Renamed to AddMethod.
3310 2004-05-29 Martin Baulig <martin@ximian.com>
3312 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3314 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3315 converting from a class type S to an interface type and we already
3316 have an object on the stack, don't box it again. Fixes #52578.
3318 2004-05-29 Martin Baulig <martin@ximian.com>
3320 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3321 Added support for `params' parameters. Fixes #59267.
3323 2004-05-29 Martin Baulig <martin@ximian.com>
3325 * literal.cs (NullPointer): Provide a private .ctor which sets
3326 `type' to TypeManager.object_type. Fixes #59048.
3328 2004-05-29 Martin Baulig <martin@ximian.com>
3330 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3331 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3333 * ecore.cs (EventExpr.instance_expr): Make the field private.
3335 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3337 Fixed bug #50080 & cs0214-2.cs
3338 * expression.cs (Cast.DoResolve): Check unsafe context here.
3340 * statement.cs (Resolve.DoResolve): Likewise.
3342 2004-05-26 Martin Baulig <martin@ximian.com>
3344 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3346 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3347 (RootContext.LookupType): Pass down the `silent' flag.
3349 2004-05-25 Martin Baulig <martin@ximian.com>
3352 (MethodGroupExpr.IdenticalTypeName): New public property.
3353 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3354 expression actually refers to a type.
3356 2004-05-25 Martin Baulig <martin@ximian.com>
3358 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3359 for #56176 and made it actually work.
3361 2004-05-25 Martin Baulig <martin@ximian.com>
3363 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3364 (FieldExpr, PropertyExpr): Override and implement
3365 CacheTemporaries. Fixes #52279.
3367 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3369 * location.cs: In the new compiler listing a file twice is a
3370 warning, not an error.
3372 2004-05-24 Martin Baulig <martin@ximian.com>
3374 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3375 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3377 2004-05-24 Martin Baulig <martin@ximian.com>
3379 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3380 walking the `using' list. Fixes #53921.
3382 2004-05-24 Martin Baulig <martin@ximian.com>
3384 * const.cs (Const.LookupConstantValue): Added support for
3385 EmptyCast's; fixes #55251.
3387 2004-05-24 Martin Baulig <martin@ximian.com>
3389 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3390 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3391 which does the CS0135 check. The reason is that we first need to
3392 check whether the variable actually exists.
3394 2004-05-24 Martin Baulig <martin@ximian.com>
3396 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3397 than RootContext.LookupType() to find the explicit interface
3400 2004-05-24 Raja R Harinath <rharinath@novell.com>
3402 * Makefile: Simplify. Use executable.make.
3403 * mcs.exe.sources: New file. List of sources of mcs.exe.
3405 2004-05-24 Anders Carlsson <andersca@gnome.org>
3409 Use the invariant culture when doing String.Compare for CLS case
3412 2004-05-23 Martin Baulig <martin@ximian.com>
3414 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3415 don't have any dots. Fixes #52622, added cs0246-8.cs.
3417 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3419 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3421 * class.cs (MemberBase.Define): Reuse MemberType member for
3422 resolved type. Other methods can use it too.
3424 2004-05-23 Martin Baulig <martin@ximian.com>
3426 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3427 the variable also exists in the current block (otherwise, we need
3428 to report a CS0103). Fixes #58670.
3430 2004-05-23 Martin Baulig <martin@ximian.com>
3432 * flowanalysis.cs (Reachability.Reachable): Compute this
3433 on-the-fly rather than storing it as a field.
3435 2004-05-23 Martin Baulig <martin@ximian.com>
3437 * flowanalysis.cs (Reachability.And): Manually compute the
3438 resulting `barrier' from the reachability.
3440 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3443 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3444 instance of ObsoleteAttribute when symbol is obsolete.
3447 (IMethodData): Extended interface for ObsoleteAttribute support.
3449 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3451 * attribute.cs: Fix bug #55970
3453 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3457 (GetObsoleteAttribute): New method. Creates the instance of
3459 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3460 ObsoleteAttribute when member is obsolete.
3461 (AttributeTester.Report_ObsoleteMessage): Common method for
3462 Obsolete error/warning reporting.
3465 (TypeContainer.base_classs_type): New member for storing parent type.
3468 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3469 for this MemberCore.
3471 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3473 * attribute.cs, const.cs: Fix bug #58590
3475 2004-05-21 Martin Baulig <martin@ximian.com>
3477 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3478 out parameters if the end of the method is unreachable. Fixes
3481 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3483 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3484 Hari was right, why extra method.
3486 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3488 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3490 2004-05-20 Martin Baulig <martin@ximian.com>
3492 Merged this back from gmcs to keep the differences to a minumum.
3494 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3495 instead of a Declspace.
3496 (Attribute.ResolveType): Likewise.
3497 (Attributes.Search): Likewise.
3498 (Attributes.Contains): Likewise.
3499 (Attributes.GetClsCompliantAttribute): Likewise.
3501 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3503 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3506 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3508 Fix bug #58688 (MCS does not report error when the same attribute
3511 * attribute.cs (Attribute.Emit): Distinction between null and default.
3513 2004-05-19 Raja R Harinath <rharinath@novell.com>
3515 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3516 of a top-level attribute without an attribute target.
3517 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3519 (Attribute.Conditional_GetConditionName),
3520 (Attribute.Obsolete_GetObsoleteMessage): Update.
3521 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3522 part of ScanForIndexerName.
3523 (Attribute.CanIgnoreInvalidAttribute): New function.
3524 (Attribute.ScanForIndexerName): Move to ...
3525 (Attributes.ScanForIndexerName): ... here.
3526 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3527 (Attributes.Search): New internal variant that can choose not to
3528 complain if types aren't resolved. The original signature now
3530 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3531 complaints suppressed.
3532 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3533 only if it not useful.
3534 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3535 top-level for attributes that are shared between the assembly
3536 and a top-level class.
3537 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3538 * class.cs: Update to reflect changes.
3539 (DefineIndexers): Fuse loops.
3540 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3541 a couple more variants of attribute names.
3543 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3545 Fix bug #52585 (Implemented explicit attribute declaration)
3548 (Attributable.ValidAttributeTargets): New abstract method. It gets
3549 list of valid attribute targets for explicit target declaration.
3550 (Attribute.Target): It holds target itself.
3551 (AttributeSection): Removed.
3552 (Attribute.CheckTargets): New method. It checks whether attribute
3553 target is valid for the current element.
3556 (EventProperty): New class. For events that are declared like
3557 property (with add and remove accessors).
3558 (EventField): New class. For events that are declared like field.
3561 * cs-parser.jay: Implemented explicit attribute target declaration.
3563 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3564 Override ValidAttributeTargets.
3567 (ReturnParameter): Class for applying custom attributes on
3569 (ParameterAtribute): New class. Class for applying custom
3570 attributes on the parameter type.
3572 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3574 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3577 (Method): Allow UNSAFE here.
3579 * modifiers.cs: Support unsafe reporting.
3581 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3583 * decl.cs: Fix bug #58478.
3585 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3587 * statement.cs: When checking for unreachable code on an EmptyStatement,
3588 set the location. Fixes bug #58488.
3590 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3592 * driver.cs: Add -pkg handling.
3594 From Gonzalo: UseShelLExecute=false
3596 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3599 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3601 (Attribute.IsClsCompliaceRequired): Moved to base for better
3603 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3604 when attribute is AttributeUsageAttribute.
3605 (Attribute.GetValidTargets): Simplified.
3606 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3607 attribute for this type.
3608 (Attribute.ApplyAttributes): Method renamed to Emit and make
3610 (GlobalAttributeSection): New class for special handling of global
3611 attributes (assembly, module).
3612 (AttributeSection.Emit): New method.
3614 * class.cs: Implemented Attributable abstract methods.
3615 (MethodCore.LabelParameters): Moved to Parameter class.
3616 (Accessor): Is back simple class.
3617 (PropertyMethod): Implemented Attributable abstract class.
3618 (DelegateMethod): Implemented Attributable abstract class.
3619 (Event): New constructor for disctintion between normal Event
3620 and Event with accessors.
3622 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3624 * codegen.cs, const.cs, decl.cs, delegate.cs:
3625 (CommonAssemblyModulClass): Implemented Attributable abstract class
3628 * enum.cs: Implement IAttributeSupport interface.
3629 (EnumMember): New class for emum members. Implemented Attributable
3633 (ParameterBase): Is abstract.
3634 (ReturnParameter): New class for easier [return:] attribute handling.
3636 * typemanager.cs: Removed builder_to_attr.
3638 2004-05-11 Raja R Harinath <rharinath@novell.com>
3641 * attribute.cs (Attribute.GetPositionalValue): New function.
3642 * class.cs (TypeContainer.VerifyMembers): New function.
3643 (TypeContainer.Emit): Use it.
3644 (ClassOrStruct): New base class for Class and Struct.
3645 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3646 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3648 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3649 then each non-static field should have a FieldOffset attribute.
3650 Otherwise, none of the fields should have a FieldOffset attribute.
3651 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3652 and FieldOffset attributes.
3653 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3654 (TypeManager.field_offset_attribute_type): New core types.
3655 (TypeManager.InitCoreTypes): Initialize them.
3657 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3659 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3660 Return correct type.
3663 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3665 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3666 be implicitly converted to ulong.
3668 * expression.cs: The logic for allowing operator &, | and ^ worked
3669 was wrong, it worked before because we did not report an error in
3670 an else branch. Fixes 57895.
3672 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3673 allow volatile fields to be reference types.
3675 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3677 * driver.cs: Add support for /debug-
3679 2004-05-07 Raja R Harinath <rharinath@novell.com>
3681 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3682 Add a 'complain' parameter to silence errors.
3683 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3684 silently overlooked type-resolutions.
3685 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3687 (Attributes.Search): New function.
3688 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3689 (Attributes.GetAttributeFullName): Remove hack.
3690 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3691 Update to reflect changes.
3692 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3693 Use Attributes.Search instead of nested loops.
3695 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3698 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3699 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3700 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3702 * report.cs: (Report.Warning): Renamed to Warning_T because of
3703 parameter collision.
3705 2004-05-05 Raja R Harinath <rharinath@novell.com>
3707 * expression.cs (MemberAccess.ResolveMemberAccess):
3708 Exit with non-zero status after Report.Error.
3709 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3711 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3713 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3715 * support.cs: Don't hang when the file is empty.
3717 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3719 * support.cs: In SeekableStreamReader, compute the preamble size of the
3720 underlying stream. Position changes should take into account that initial
3723 2004-05-03 Todd Berman <tberman@sevenl.net>
3725 * driver.cs: remove unused GetSysVersion function.
3727 2004-05-03 Todd Berman <tberman@sevenl.net>
3729 * driver.cs: Remove the hack from saturday, as well as the hack
3730 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3731 link_paths to get that bit proper.
3733 2004-05-01 Todd Berman <tberman@sevenl.net>
3735 * driver.cs: Try a LoadFrom before a Load, this checks the current
3736 path. This is currently a bug in mono that is be fixed, however, this
3737 provides a workaround for now. This will be removed when the bug
3740 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3742 * CryptoConvert.cs: Updated to latest version. Fix issue with
3743 incomplete key pairs (#57941).
3745 2004-05-01 Todd Berman <tberman@sevenl.net>
3747 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3750 2004-04-30 Jackson Harper <jackson@ximian.com>
3752 * codegen.cs: Open keys readonly.
3754 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3756 * typemanager.cs: don't report cyclic struct layout when a struct
3757 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3758 which has 2 Pango.Rectangle fields.
3760 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3762 * expression.cs: Handle IntPtr comparisons with IL code
3763 rather than a method call.
3765 2004-04-29 Martin Baulig <martin@ximian.com>
3767 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3768 the list of PropertyInfo's in class hierarchy and find the
3769 accessor. Fixes #56013.
3771 2004-04-29 Martin Baulig <martin@ximian.com>
3773 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3775 2004-04-29 Martin Baulig <martin@ximian.com>
3777 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3779 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3781 2004-04-29 Martin Baulig <martin@ximian.com>
3783 * class.cs (ConstructorInitializer.Resolve): Check whether the
3784 parent .ctor is accessible. Fixes #52146.
3786 2004-04-29 Martin Baulig <martin@ximian.com>
3788 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3790 * statement.cs (Using.EmitLocalVariableDecls): Use
3791 TypeManager.idisposable_type, not typeof (IDisposable).
3792 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3794 2004-04-29 Martin Baulig <martin@ximian.com>
3796 * class.cs (Event.Define): Don't emit the field and don't set
3797 RTSpecialName and SpecialName for events on interfaces. Fixes
3800 2004-04-29 Raja R Harinath <rharinath@novell.com>
3802 Refactor Attribute.ApplyAttributes.
3803 * attribute.cs (Attributable): New base class for objects that can
3804 have Attributes applied on them.
3805 (Attribute): Make AttributeUsage fields public.
3806 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3807 (Attribute.IsInternalCall): New property.
3808 (Attribute.UsageAttr): Convert to a public read-only property.
3809 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3810 (Attribute.ResolveType, Attribute.Resolve)
3811 (Attribute.ScanForIndexerName): Update to reflect changes.
3812 (Attribute.CheckAttributeTarget): Re-format.
3813 (Attribute.ApplyAttributes): Refactor, to various
3814 Attributable.ApplyAttributeBuilder methods.
3815 * decl.cs (MemberCore): Make Attributable.
3816 * class.cs (Accessor): Make Attributable.
3817 (MethodData.ApplyAttributes): Use proper attribute types, not
3819 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3820 (TypeContainer.ApplyAttributeBuilder)
3821 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3822 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3823 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3824 (Operator.ApplyAttributeBuilder): New factored-out methods.
3825 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3826 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3827 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3828 * parameter.cs (ParameterBase): New Attributable base class
3829 that can also represent Return types.
3830 (Parameter): Update to the changes.
3832 2004-04-29 Jackson Harper <jackson@ximian.com>
3834 * driver.cs: Prefer the corlib system version when looking for
3835 assemblies in the GAC. This is still a hack, but its a better hack
3838 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3840 * decl.cs, enum.cs: Improved error 3005 reporting.
3842 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3843 (related_symbols): New private member for list of symbols
3844 related to reported error/warning.
3846 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3848 2004-04-29 Martin Baulig <martin@ximian.com>
3850 * ecore.cs (Expression.Constantify): If we're an enum and
3851 TypeManager.TypeToCoreType() doesn't give us another type, use
3852 t.UnderlyingSystemType. Fixes #56178.
3854 2004-04-29 Martin Baulig <martin@ximian.com>
3856 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3857 interfaces and for each interface, only add members directly
3858 declared in that interface. Fixes #53255.
3860 2004-04-28 Martin Baulig <martin@ximian.com>
3862 * expression.cs (ConditionalLogicalOperator): Use a temporary
3863 variable for `left' to avoid that we evaluate it more than once;
3866 2004-04-28 Martin Baulig <martin@ximian.com>
3868 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3871 2004-04-28 Martin Baulig <martin@ximian.com>
3873 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3876 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3877 whether the type is not void (CS1547).
3879 2004-04-28 Martin Baulig <martin@ximian.com>
3881 * expression.cs (Unary.DoResolveLValue): Override this and report
3882 CS0131 for anything but Operator.Indirection.
3884 2004-04-28 Martin Baulig <martin@ximian.com>
3886 Committing a patch from Ben Maurer; see bug #50820.
3888 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3891 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3894 2004-04-28 Martin Baulig <martin@ximian.com>
3896 Committing a patch from Ben Maurer; see bug #50820.
3898 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3901 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3904 2004-04-28 Martin Baulig <martin@ximian.com>
3906 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3907 (Block.AddLabel): Call DoLookupLabel() to only search in the
3910 2004-04-28 Martin Baulig <martin@ximian.com>
3912 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3913 comparing StringConstants and NullLiterals in Equality and Inequality.
3915 2004-04-28 Jackson Harper <jackson@ximian.com>
3917 * driver.cs: Attempt to load referenced assemblies from the
3918 GAC. This is the quick and dirty version of this method that
3919 doesnt take into account versions and just takes the first
3920 canidate found. Will be good enough for now as we will not have more
3921 then one version installed into the GAC until I update this method.
3923 2004-04-28 Martin Baulig <martin@ximian.com>
3925 * typemanager.cs (TypeManager.CheckStructCycles): New public
3926 static method to check for cycles in the struct layout.
3928 * rootcontext.cs (RootContext.PopulateTypes): Call
3929 TypeManager.CheckStructCycles() for each TypeContainer.
3930 [Note: We only need to visit each type once.]
3932 2004-04-28 Martin Baulig <martin@ximian.com>
3934 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3936 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3937 success and added `out object value'. Use a `bool resolved' field
3938 to check whether we've already been called rather than
3939 `ConstantValue != null' since this breaks for NullLiterals.
3941 2004-04-28 Raja R Harinath <rharinath@novell.com>
3943 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3944 setting of this flag, since the 'set' method may be non-public.
3946 2004-04-28 Raja R Harinath <rharinath@novell.com>
3948 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3949 check on current_vector.Block.
3951 2004-04-27 Martin Baulig <martin@ximian.com>
3953 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3954 a field initializer. Fixes #56459.
3956 2004-04-27 Martin Baulig <martin@ximian.com>
3958 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3959 we're not attempting to use an indexer. Fixes #52154.
3961 2004-04-27 Martin Baulig <martin@ximian.com>
3963 * statement.cs (Return): Don't create a return label if we don't
3964 need it; reverts my change from January 20th. Thanks to Ben
3967 2004-04-27 Martin Baulig <martin@ximian.com>
3969 According to the spec, `goto' can only leave a nested scope, but
3972 * statement.cs (Block.LookupLabel): Only lookup in the current
3973 block, don't recurse into parent or child blocks.
3974 (Block.AddLabel): Check in parent and child blocks, report
3975 CS0140/CS0158 if we find a duplicate.
3976 (Block): Removed this indexer for label lookups.
3977 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3978 this already does the error reporting for us.
3981 (FlowBranching.UsageVector.Block): New public variable; may be null.
3982 (FlowBranching.CreateSibling): Added `Block' argument.
3983 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3984 label for the target of a `goto' and check whether we're not
3985 leaving a `finally'.
3987 2004-04-27 Martin Baulig <martin@ximian.com>
3989 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3990 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3993 2004-04-27 Martin Baulig <martin@ximian.com>
3995 * statement.cs (Block.AddLabel): Also check for implicit blocks
3996 and added a CS0158 check.
3998 2004-04-27 Martin Baulig <martin@ximian.com>
4000 * flowanalysis.cs (FlowBranchingLoop): New class.
4001 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4002 UsageVector's instead of an ArrayList.
4003 (FlowBranching.Label): Likewise.
4004 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4005 (FlowBranching.AddBreakVector): New method.
4007 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4009 * attribute.cs: Small regression fix: only convert the type if we
4010 the type is different, fixes System.Drawing build.
4012 2004-04-27 Martin Baulig <martin@ximian.com>
4014 * attribute.cs (Attribute.Resolve): If we have a constant value
4015 for a named field or property, implicity convert it to the correct
4018 2004-04-27 Raja R Harinath <rharinath@novell.com>
4020 * statement.cs (Block.Block): Implicit blocks share
4021 'child_variable_names' fields with parent blocks.
4022 (Block.AddChildVariableNames): Remove.
4023 (Block.AddVariable): Mark variable as "used by a child block" in
4024 every surrounding block.
4025 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4026 been used in a child block, complain about violation of "Invariant
4027 meaning in blocks" rule.
4028 * cs-parser.jay (declare_local_variables): Don't use
4029 AddChildVariableNames.
4030 (foreach_statement): Don't create an implicit block: 'foreach'
4033 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4035 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4036 converting from 0L to ulong. Fixes 57522.
4038 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4040 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4041 derived class hides via 'new' keyword field from base class (test-242.cs).
4042 TODO: Handle this in the more general way.
4044 * class.cs (CheckBase): Ditto.
4046 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4048 * decl.cs (caching_flags): New member for storing cached values
4050 (MemberCore.Flags): New enum where bit flags for caching_flags
4052 (MemberCore.cls_compliance): Moved to caching_flags.
4053 (DeclSpace.Created): Moved to caching_flags.
4055 * class.cs: Use caching_flags instead of DeclSpace.Created
4057 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4059 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4060 if we are only a derived class, not a nested class.
4062 * typemanager.cs: Same as above, but do this at the MemberLookup
4063 level (used by field and methods, properties are handled in
4064 PropertyExpr). Allow for the qualified access if we are a nested
4067 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4069 * class.cs: Refactoring.
4070 (IMethodData): New inteface; Holds links to parent members
4071 to avoid member duplication (reduced memory allocation).
4072 (Method): Implemented IMethodData interface.
4073 (PropertyBase): New inner classes for get/set methods.
4074 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4075 (Event): New inner classes for add/remove methods.
4076 (Event.DelegateMethod): Implemented IMethodData interface.
4078 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4079 EmitContext (related to class.cs refactoring).
4081 2004-04-21 Raja R Harinath <rharinath@novell.com>
4083 * delegate.cs (Delegate.VerifyApplicability): If the number of
4084 arguments are the same as the number of parameters, first try to
4085 verify applicability ignoring any 'params' modifier on the last
4089 2004-04-16 Raja R Harinath <rharinath@novell.com>
4091 * class.cs (TypeContainer.AddIndexer): Use
4092 'ExplicitInterfaceName' to determine if interface name was
4093 explicitly specified. 'InterfaceType' is not initialized at this time.
4094 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4095 Indexers array is already in the required order. Initialize
4096 'IndexerName' only if there are normal indexers.
4097 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4098 (TypeContainer.Emit): Emit DefaultMember attribute only if
4099 IndexerName is initialized.
4102 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4104 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4107 2004-04-15 Raja R Harinath <rharinath@novell.com>
4109 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4113 * attribute.cs (Attribute.Resolve): Check for duplicate named
4117 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4119 * iterators.cs (MarkYield): track whether we are in an exception,
4120 and generate code accordingly. Use a temporary value to store the
4121 result for our state.
4123 I had ignored a bit the interaction of try/catch with iterators
4124 since their behavior was not entirely obvious, but now it is
4125 possible to verify that our behavior is the same as MS .NET 2.0
4129 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4131 * iterators.cs: Avoid creating temporaries if there is no work to
4134 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4135 Enumerations, use TypeManager.EnumToUnderlying and call
4138 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4141 (This.Emit): Use EmitContext.EmitThis to emit our
4144 (This.EmitAssign): Ditto.
4146 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4147 codepaths, we will move all the functionality into
4150 (FieldExpr.EmitAssign): Ditto.
4152 This fixes several hidden bugs that I uncovered while doing a code
4153 review of this today.
4155 * codegen.cs (EmitThis): reworked so the semantics are more clear
4156 and also support value types "this" instances.
4158 * iterators.cs: Changed so that for iterators in value types, we
4159 do not pass the value type as a parameter.
4161 Initialization of the enumerator helpers is now done in the caller
4162 instead of passing the parameters to the constructors and having
4163 the constructor set the fields.
4165 The fields have now `assembly' visibility instead of private.
4167 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4169 * expression.cs (Argument.Resolve): Check if fields passed as ref
4170 or out are contained in a MarshalByRefObject.
4172 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4173 another compiler type.
4175 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4177 * class.cs (Indexer.Define): use the new name checking method.
4178 Also, return false on an error.
4179 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4180 (is_identifier_[start/part]_character): make static.
4182 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4184 * expression.cs (Binary.ResolveOperator): Do no append strings
4185 twice: since we can be invoked more than once (array evaluation)
4186 on the same concatenation, take care of this here. Based on a fix
4187 from Ben (bug #56454)
4189 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4191 * codegen.cs: Fix another case where CS1548 must be reported (when
4192 delay-sign isn't specified and no private is available #56564). Fix
4193 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4194 error when MCS is used on the MS runtime and we need to delay-sign
4195 (which seems unsupported by AssemblyBuilder - see #56621).
4197 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4199 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4200 (TypeManager.ComputeNamespaces): Faster implementation for
4203 * compiler.csproj: Updated AssemblyName to mcs.
4205 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4207 * rootcontext.cs: Add new types to the boot resolution.
4209 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4210 MulticastDelegate is not allowed.
4212 * typemanager.cs: Add new types to lookup: System.TypedReference
4215 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4216 check for TypedReference or ArgIterator, they are not allowed.
4218 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4219 makes us properly catch 1510 in some conditions (see bug 56016 for
4222 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4224 * CryptoConvert.cs: update from corlib version
4227 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4229 * class.cs (Indexer.Define): Check indexername declaration
4231 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4233 * attribute.cs (IsClsCompliant): Fixed problem with handling
4234 all three states (compliant, not-compliant, undetected).
4236 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4238 * attribute.cs (Attribute): Location is now public.
4239 (Resolve): Store resolved arguments (pos_values) in attribute class.
4240 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4241 (GetClsCompliantAttributeValue): New method that gets
4242 CLSCompliantAttribute value.
4243 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4244 if exists else null.
4245 (AttributeTester): New class for CLS-Compliant verification routines.
4247 * class.cs (Emit): Add CLS-Compliant verification.
4248 (Method.GetSignatureForError): Implemented.
4249 (Constructor.GetSignatureForError): Implemented
4250 (Constructor.HasCompliantArgs): Returns if constructor has
4251 CLS-Compliant arguments.
4252 (Constructor.Emit): Override.
4253 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4254 is needed to test only parameters.
4255 (FieldBase.GetSignatureForError): Implemented.
4256 (TypeContainer): New member for storing base interfaces.
4257 (TypeContainer.FindMembers): Search in base interfaces too.
4259 * codegen.cs (GetClsComplianceAttribute): New method that gets
4260 assembly or module CLSCompliantAttribute value.
4261 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4263 (ModuleClass.Emit): Add error 3012 test.
4265 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4267 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4268 state for all decl types.
4269 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4270 if CLS-Compliant tests are required.
4271 (IsClsCompliaceRequired): New method. Analyze whether code
4272 must be CLS-Compliant.
4273 (IsExposedFromAssembly): New method. Returns true when MemberCore
4274 is exposed from assembly.
4275 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4276 value or gets cached value.
4277 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4278 is explicitly marked with CLSCompliantAttribute.
4279 (IsIdentifierClsCompliant): New abstract method. This method is
4280 used to testing error 3005.
4281 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4282 for identifier and parameters CLS-Compliant testing.
4283 (VerifyClsCompliance): New method. The main virtual method for
4284 CLS-Compliant verifications.
4285 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4286 null. I don't know why is null (too many public members !).
4287 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4288 and get value of first CLSCompliantAttribute that found.
4290 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4291 (VerifyClsCompliance): Override and add extra tests.
4293 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4294 clscheck- disable CLS-Compliant verification event if assembly is has
4295 CLSCompliantAttribute(true).
4297 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4298 ApllyAttribute is now called in emit section as in the other cases.
4299 Possible future Emit integration.
4300 (IsIdentifierClsCompliant): New override.
4301 (VerifyClsCompliance): New override.
4302 (GetEnumeratorName): Returns full enum name.
4304 * parameter.cs (GetSignatureForError): Implemented.
4306 * report.cs (WarningData): New struct for Warning message information.
4307 (LocationOfPreviousError): New method.
4308 (Warning): New method. Reports warning based on the warning table.
4309 (Error_T): New method. Reports error based on the error table.
4311 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4312 verifications are done here.
4314 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4316 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4317 CLSCompliantAttribute.
4318 (all_imported_types): New member holds all imported types from other
4320 (LoadAllImportedTypes): New method fills static table with exported types
4321 from all referenced assemblies.
4322 (Modules): New property returns all assembly modules.
4324 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4326 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4327 throwing a parser error.
4329 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4330 which removes the hardcoded get_/set_ prefixes for properties, as
4331 IL allows for the properties to be named something else.
4335 * expression.cs: Do not override operand before we know if it is
4338 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4340 * typemanager.cs: support for pinned variables.
4342 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4344 * decl.cs, typemanager.cs: Avoid using an arraylist
4345 as a buffer if there is only one result set.
4347 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4349 * expression.cs: Make sure you cant call a static method
4350 with an instance expression, bug #56174.
4352 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4354 * class.cs (IsDuplicateImplementation): Improve error reporting to
4355 flag 663 (method only differs in parameter modifier).
4357 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4358 in preprocessor directives.
4360 * location.cs (LookupFile): Allow for the empty path.
4362 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4363 better approach for some of that patch, but its failing with the
4364 CharSet enumeration. For now try/catch will do.
4366 * typemanager.cs: Do not crash if a struct does not have fields.
4369 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4371 * expression.cs: cs0213, cant fix a fixed expression.
4374 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4376 * cs-parser.jay: detect invalid embeded statements gracefully.
4379 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4381 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4384 the invocation type may not be a subclass of the tye of the item/
4385 The type of the item must be a subclass of the invocation item.
4390 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4392 * attribute.cs: Added methods to get a string and a bool from an
4393 attribute. Required to information from AssemblyKeyFileAttribute,
4394 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4395 * codegen.cs: Modified AssemblyName creation to include support for
4396 strongnames. Catch additional exceptions to report them as CS1548.
4397 * compiler.csproj: Updated include CryptoConvert.cs.
4398 * compiler.csproj.user: Removed file - user specific configuration.
4399 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4400 Mono.Security assembly. The original class is maintained and tested in
4401 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4402 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4403 like CSC 8.0 (C# v2) supports.
4404 * Makefile: Added CryptoConvert.cs to mcs sources.
4405 * rootcontext.cs: Added new options for strongnames.
4407 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4409 * driver.cs: For --expect-error, report error code `2'
4410 if the program compiled with no errors, error code `1' if
4411 it compiled with an error other than the one expected.
4413 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4415 * compiler.csproj: Updated for Visual Studio .NET 2003.
4416 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4417 * compiler.sln: Updated for Visual Studio .NET 2003.
4419 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4421 * expression.cs: Fix bug #47234. We basically need to apply the
4422 rule that we prefer the conversion of null to a reference type
4423 when faced with a conversion to 'object' (csc behaviour).
4425 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4427 * statement.cs: Shorter form for foreach, eliminates
4428 a local variable. r=Martin.
4430 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4432 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4433 checks if we can use brtrue/brfalse to test for 0.
4434 * expression.cs: use the above in the test for using brtrue/brfalse.
4437 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4439 * expression.cs: Rewrite string concat stuff. Benefits:
4441 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4442 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4443 rather than a concat chain.
4445 * typemanager.cs: Add lookups for more concat overloads.
4447 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4449 * expression.cs: Emit shorter il code for array init.
4466 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4468 * statement.cs: Before, two switch blocks would be merged if the
4469 total size of the blocks (end_item - begin_item + 1) was less than
4470 two times the combined sizes of the blocks.
4472 Now, it will only merge if after the merge at least half of the
4477 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4479 * class.cs : csc build fix for GetMethods(). See bug #52503.
4481 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4483 * expression.cs: Make sure fp comparisons work with NaN.
4484 This fixes bug #54303. Mig approved this patch a long
4485 time ago, but we were not able to test b/c the runtime
4488 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4490 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4492 2004-03-19 Martin Baulig <martin@ximian.com>
4494 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4495 error here and not in our caller.
4497 2004-03-19 Martin Baulig <martin@ximian.com>
4499 * interface.cs: Completely killed this file.
4500 (Interface): We're now a TypeContainer and live in class.cs.
4502 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4503 argument; we're now also called for interfaces.
4504 (TypeContainer.DefineMembers): Allow this method being called
4506 (TypeContainer.GetMethods): New public method; formerly known as
4507 Interface.GetMethod(). This is used by PendingImplementation.
4508 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4509 it's now private and non-static.
4510 (Interface): Moved this here; it's now implemented similar to
4512 (Method, Property, Event, Indexer): Added `bool is_interface'
4513 argument to their .ctor's.
4514 (MemberBase.IsInterface): New public field.
4516 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4517 instances instead of InterfaceMethod, InterfaceProperty, etc.
4518 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4519 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4521 2004-03-19 Martin Baulig <martin@ximian.com>
4523 * class.cs (MethodCore.IsDuplicateImplementation): New private
4524 method which does the CS0111 checking.
4525 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4526 Use IsDuplicateImplementation().
4528 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4530 * decl.cs (FindMemberToOverride): New method to find the correct
4531 method or property to override in the base class.
4533 - Make Method/Property use the above method to find the
4534 version in the base class.
4535 - Remove the InheritableMemberSignatureCompare as it is now
4538 This patch makes large code bases much faster to compile, as it is
4539 O(n) rather than O(n^2) to do this validation.
4541 Also, it fixes bug 52458 which is that nested classes are not
4542 taken into account when finding the base class member.
4544 Reviewed/Approved by Martin.
4546 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4548 * interface.cs: In all interface classes removed redundant
4549 member initialization.
4551 2004-03-16 Martin Baulig <martin@ximian.com>
4553 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4555 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4557 * decl.cs (DefineTypeAndParents): New helper method to define a
4558 type's containers before the type itself is defined; This is a
4559 bug exposed by the recent changes to Windows.Forms when an
4560 implemented interface was defined inside a class that had not been
4563 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4565 (Check): Loop correctly to report errors modifiers
4566 (UNSAFE was not in the loop, since it was the same as TOP).
4568 * interface.cs: Every interface member now takes a ModFlags,
4569 instead of a "is_new" bool, which we set on the base MemberCore.
4571 Every place where we called "UnsafeOk" in the interface, now we
4572 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4573 the unsafe settings from the member declaration instead of the
4574 container interface.
4576 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4578 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4579 `set_indexer_name' to the pending bits (one per type).
4581 We fixed a bug today that was picking the wrong method to
4582 override, since for properties the existing InterfaceMethod code
4583 basically ignored the method name. Now we make sure that the
4584 method name is one of the valid indexer names.
4586 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4588 * support.cs (SeekableStreamReader): Keep track of stream byte
4589 positions and don't mix them with character offsets to the buffer.
4591 Patch from Gustavo Giráldez
4593 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4595 * interface.cs (InterfaceSetGetBase): Removed double member
4596 initialization, base class does it as well.
4598 2004-03-13 Martin Baulig <martin@ximian.com>
4600 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4601 when compiling corlib.
4603 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4605 * convert.cs (ExplicitConversion): We were reporting an error on
4606 certain conversions (object_type source to a value type, when the
4607 expression was `null') before we had a chance to pass it through
4608 the user defined conversions.
4610 * driver.cs: Replace / and \ in resource specifications to dots.
4613 * class.cs: Add check for duplicate operators. Fixes 52477
4615 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4617 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4618 that are in the middle of the statements, not only at the end.
4621 * class.cs (TypeContainer.AddField): No longer set the
4622 `HaveStaticConstructor' flag, now we call it
4623 `UserDefineStaticConstructor' to diferentiate the slightly
4624 semantic difference.
4626 The situation is that we were not adding BeforeFieldInit (from
4627 Modifiers.TypeAttr) to classes that could have it.
4628 BeforeFieldInit should be set to classes that have no static
4633 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4635 And most importantly Zoltan's comment:
4637 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4639 "I think beforefieldinit means 'it's ok to initialize the type sometime
4640 before its static fields are used', i.e. initialization does not need
4641 to be triggered by the first access to the type. Setting this flag
4642 helps the JIT to compile better code, since it can run the static
4643 constructor at JIT time, and does not need to generate code to call it
4644 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4645 this flag for lots of classes like String.
4647 csc sets this flag if the type does not have an explicit static
4648 constructor. The reasoning seems to be that if there are only static
4649 initalizers for a type, and no static constructor, then the programmer
4650 does not care when this initialization happens, so beforefieldinit
4653 This bug prevents the AOT compiler from being usable, since it
4654 generates so many calls to mono_runtime_class_init that the AOT code
4655 is much slower than the JITted code. The JITted code is faster,
4656 because it does not generate these calls if the vtable is type is
4657 already initialized, which is true in the majority of cases. But the
4658 AOT compiler can't do this."
4660 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4662 * class.cs (MethodData.Emit): Refactor the code so symbolic
4663 information is generated for destructors; For some reasons we
4664 were taking a code path that did not generate symbolic information
4667 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4669 * class.cs: Create a Constructor.CheckBase method that
4670 takes care of all validation type code. The method
4671 contains some code that was moved from Define.
4673 It also includes new code that checks for duplicate ctors.
4674 This fixes bug #55148.
4676 2004-03-09 Joshua Tauberer <tauberer@for.net>
4678 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4679 a { ... }-style array creation invokes EmitStaticInitializers
4680 which is not good for reference-type arrays. String, decimal
4681 and now null constants (NullCast) are not counted toward
4682 static initializers.
4684 2004-03-05 Martin Baulig <martin@ximian.com>
4686 * location.cs (SourceFile.HasLineDirective): New public field;
4687 specifies whether the file contains or is referenced by a "#line"
4689 (Location.DefineSymbolDocuments): Ignore source files which
4690 either contain or are referenced by a "#line" directive.
4692 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4694 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4695 direct access to our parent, so check the method inline there.
4697 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4699 * expression.cs (Invocation.EmitCall): Miguel's last commit
4700 caused a regression. If you had:
4705 In Foo the implict this would be null.
4707 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4709 * expression.cs (Invocation.EmitCall): If the method is not
4710 virtual, do not emit a CallVirt to it, use Call.
4712 * typemanager.cs (GetFullNameSignature): Improve the method to
4713 cope with ".ctor" and replace it with the type name.
4715 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4716 as an argument the ConstructorBuilder where it is being defined,
4717 to catch the recursive constructor invocations.
4719 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4721 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4722 routines to check if a type is an enumerable/enumerator allow
4723 classes that implement the IEnumerable or IEnumerator interfaces.
4725 * class.cs (Property, Operator): Implement IIteratorContainer, and
4726 implement SetYields.
4728 (Property.Define): Do the block swapping for get_methods in the
4729 context of iterators. We need to check if Properties also
4730 include indexers or not.
4732 (Operator): Assign the Block before invoking the
4733 OperatorMethod.Define, so we can trigger the Iterator code
4736 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4737 Property and Operator classes are not created when we parse the
4738 declarator but until we have the block completed, so we use a
4739 singleton SimpleIteratorContainer.Simple to flag whether the
4740 SetYields has been invoked.
4742 We propagate this setting then to the Property or the Operator to
4743 allow the `yield' to function.
4745 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4747 * codegen.cs: Implemented attribute support for modules.
4748 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4749 Assembly/Module functionality.
4751 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4752 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4753 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4755 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4757 * interface.cs (FindMembers): The operation is performed on all base
4758 interfaces and not only on the first. It is required for future CLS Compliance patch.
4760 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4762 * statement.cs, codegen.cs:
4763 This patch deals with patterns such as:
4765 public class List : IEnumerable {
4767 public MyEnumerator GetEnumerator () {
4768 return new MyEnumerator(this);
4771 IEnumerator IEnumerable.GetEnumerator () {
4775 public struct MyEnumerator : IEnumerator {
4780 Before, there were a few things we did wrong:
4781 1) we would emit callvirt on a struct, which is illegal
4782 2) we emited ldarg when we needed to emit ldarga
4783 3) we would mistakenly call the interface methods on an enumerator
4784 type that derived from IEnumerator and was in another assembly. For example:
4786 public class MyEnumerator : IEnumerator
4788 Would have the interface methods called, even if there were public impls of the
4789 method. In a struct, this lead to invalid IL code.
4791 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4793 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4796 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4798 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4800 * cs-parser.jay: Fix small regression: we were not testing V2
4801 compiler features correctly.
4803 * interface.cs: If the emit context is null, then create one
4805 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4807 * decl.cs (GetSignatureForError): New virtual method to get full name
4810 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4811 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4813 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4814 Duplicated members and code in these classes has been removed.
4815 Better encapsulation in these classes.
4817 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4819 * assign.cs (Assign.DoResolve): When dealing with compound
4820 assignments, there is a new rule in ECMA C# 2.4 (might have been
4821 there before, but it is documented here) that states that in:
4825 If b is of type int, and the `op' is a shift-operator, then the
4826 above is evaluated as:
4830 * expression.cs (Binary.ResolveOperator): Instead of testing for
4831 int/uint/long/ulong, try to implicitly convert to any of those
4832 types and use that in pointer arithmetic.
4834 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4835 method to print information for from the type, not from the
4836 null-method we were given.
4838 2004-02-01 Duncan Mak <duncan@ximian.com>
4840 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4841 parsing for cmd, fixes bug #53694.
4843 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4845 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4846 in the member name duplication tests. Property and operator name duplication
4847 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4849 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4851 * interface.cs (PopulateMethod): Fixed crash when interface method
4852 returns not existing type (error test cs0246-3.cs).
4854 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4856 * cs-parser.jay (interface_accessors): Re-write actions to also
4857 store attributes attached to get and set methods. Fix spelling
4860 (inteface_property_declaration): Modify accordingly.
4862 (InterfaceAccessorInfo): New helper class to store information to pass
4863 around between rules that use interface_accessors.
4865 * interface.cs (Emit): Apply attributes on the get and set
4866 accessors of properties and indexers too.
4868 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4869 right MethodBuilder when applying attributes to the get and set accessors.
4871 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4873 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4875 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4877 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4879 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4881 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4882 changes that treat `yield' specially when present before `break'
4885 * cs-tokenizer.cs: yield is no longer a keyword.
4887 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4889 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4890 setting for default constructors.
4891 For default constructors are almost every time set wrong Modifier. The
4892 generated IL code has been alright. But inside mcs this values was
4893 wrong and this was reason why several of my CLS Compliance tests
4896 2004-01-22 Martin Baulig <martin@ximian.com>
4898 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4899 not a QualifiedIdentifier. This is what `type_name_expression'
4900 was previously doing.
4901 (type_name_expression): Removed; the code is now in
4902 `namespace_or_type_name'.
4903 (qualified_identifier): Removed, use `namespace_or_type_name'
4905 (QualifiedIdentifier): Removed this class.
4907 2004-01-22 Martin Baulig <martin@ximian.com>
4909 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4910 not a string as alias name.
4912 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4914 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4915 #52730 bug, and instead compute correctly the need to use a
4916 temporary variable when requesting an address based on the
4917 static/instace modified of the field and the constructor.
4919 2004-01-21 Martin Baulig <martin@ximian.com>
4921 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4922 class and namespace before looking up aliases. Fixes #52517.
4924 2004-01-21 Martin Baulig <martin@ximian.com>
4926 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4927 assinged in a 'try'; fixes exception4.cs.
4929 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4930 * class.cs : Implemented parameter-less constructor for TypeContainer
4932 * decl.cs: Attributes are now stored here. New property OptAttributes
4934 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4936 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4938 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4940 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4941 (CSharpSignature): New method for indexer and property signature.
4943 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4945 * pending.cs (IsVirtualFilter): Faster implementation.
4947 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4949 * typemanager.cs: Avoid inclusion of same assembly more than once.
4951 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4953 * cs-parser.jay: Fixed problem where the last assembly attribute
4954 has been applied also to following declaration (class, struct, etc.)
4956 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4958 * class.cs: Added error CS0538, CS0539 reporting.
4959 Fixed crash on Microsoft runtime when field type is void.
4961 * cs-parser.jay: Added error CS0537 reporting.
4963 * pending.cs: Added error CS0535 reporting.
4964 Improved error report for errors CS0536, CS0534.
4966 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4968 Merge a few bits from the Anonymous Method MCS tree.
4970 * statement.cs (ToplevelBlock): New class for toplevel methods,
4971 will hold anonymous methods, lifted variables.
4973 * cs-parser.jay: Create toplevel blocks for delegates and for
4974 regular blocks of code.
4976 2004-01-20 Martin Baulig <martin@ximian.com>
4978 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4979 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4980 and `NeedExplicitReturn'; added `IsLastStatement'.
4981 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4982 have a `ReturnLabel' or we're not unreachable.
4984 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4985 child's reachability; don't just override ours with it. Fixes
4986 #58058 (lluis's example).
4987 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4988 InFinally(), InLoop(), InSwitch() and
4989 BreakCrossesTryCatchBoundary() methods.
4991 * statement.cs (Return): Do all error checking in Resolve().
4992 Unless we are the last statement in a top-level block, always
4993 create a return label and jump to it.
4994 (Break, Continue): Do all error checking in Resolve(); also make
4995 sure we aren't leaving a `finally'.
4996 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4997 statement in a top-level block.
4998 (Block.Flags): Added `IsDestructor'.
4999 (Block.IsDestructor): New public property.
5001 2004-01-20 Martin Baulig <martin@ximian.com>
5003 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
5005 2004-01-20 Martin Baulig <martin@ximian.com>
5007 * statement.cs (Statement.ResolveUnreachable): New public method.
5008 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
5009 (Block.Resolve): Resolve unreachable statements.
5011 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5013 * expression.cs: We need to fix the case where we do
5014 not have a temp variable here.
5016 * assign.cs: Only expression compound assignments need
5017 temporary variables.
5019 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5021 * flowanalysis.cs: Reduce memory allocation in a few ways:
5022 - A block with no variables should not allocate a bit
5024 - A method with no out parameters does not need any tracking
5025 for assignment of the parameters, so we need not allocate
5028 public readonly Type[] VariableTypes;
5029 public readonly string[] VariableNames;
5030 Are redundant. The data is already stored in the variable
5031 map, so we need not allocate another array for it.
5032 - We need to add alot of checks for if (params | locals) == null
5033 due to the first two changes.
5035 2004-01-18 Miguel de Icaza <miguel@ximian.com>
5037 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
5038 implement IMemoryLocation, we store a copy on a local variable and
5039 take the address of it. Patch from Benjamin Jemlich
5041 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
5042 to use a special "type_name_expression" rule which reduces the
5043 number of "QualifiedIdentifier" classes created, and instead
5044 directly creates MemberAccess expressions.
5046 2004-01-17 Miguel de Icaza <miguel@ximian.com>
5048 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
5049 that fixes #52853. Null literal assignment to ValueType
5051 * class.cs (MethodData.Emit): Instead of checking the name of the
5052 method to determine if its a destructor, create a new derived
5053 class from Method called Destructor, and test for that.
5055 * cs-parser.jay: Create a Destructor object instead of a Method.
5057 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
5061 2004-01-16 Miguel de Icaza <miguel@ximian.com>
5063 * expression.cs (Binary.ResolveOperator): Perform an implicit
5064 conversion from MethodGroups to their delegate types on the
5067 * delegate.cs: Introduce a new class DelegateCreation that is the
5068 base class for `NewDelegate' and `ImplicitDelegateCreation',
5069 factor some code in here.
5071 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
5072 conversion from MethodGroups to compatible delegate types.
5074 * ecore.cs (Expression.Resolve): Do not flag error 654
5075 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5076 we allow conversions from MethodGroups to delegate types now.
5078 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5079 assignments in v2 either.
5081 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5083 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5084 static read-only fields in ctors.
5086 Applied patch from Benjamin Jemlich
5088 * expression.cs (UnaryMutator): Avoid leaking local variables.
5090 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5092 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5093 here to return true, as they can be used like this:
5097 Fixed 49836 and all the other dups
5099 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5101 * driver.cs: Implement /win32res and /win32icon.
5103 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5105 * cs-parser.jay: Add a rule to improve error handling for the
5106 common mistake of placing modifiers after the type.
5108 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5110 * cs-parser.jay (interface_event_declaration): Catch
5111 initialization of events on interfaces, and report cs0068
5113 * cs-parser.jay (interface_event_declaration): Catch
5114 initialization of events.
5116 * ecore.cs: Better report missing constructors.
5118 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5119 the error reporting done in the wrong place. Fix.
5121 * expression.cs (Binary.ResolveOperator): Catch the
5122 operator + (E x, E y) error earlier, and later allow for implicit
5123 conversions in operator +/- (E e, U x) from U to the underlying
5126 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5127 52596, if the container class is abstract, the default constructor
5128 is protected otherwise its public (before, we were always public).
5130 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5133 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5134 Jemlich that fixes bug #52597, MCS was generating invalid code for
5135 idisposable structs. Thanks to Ben for following up with this
5138 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5140 * driver.cs: Allow assemblies without code to be generated, fixes
5143 2004-01-07 Nick Drochak <ndrochak@gol.com>
5145 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5147 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5149 * cs-parser.jay: Add rules to improve error reporting if fields or
5150 methods are declared at the namespace level (error 116)
5152 * Add rules to catch event add/remove
5154 2004-01-04 David Sheldon <dave-mono@earth.li>
5156 * expression.cs: Added matching ")" to error message for
5159 2004-01-03 Todd Berman <tberman@gentoo.org>
5161 * ecore.cs, attribute.cs:
5162 Applying fix from #52429.
5164 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5166 * ecore.cs, expression.cs, statement.cs:
5167 Total rewrite of how we handle branching. We
5168 now handle complex boolean expressions with fewer
5169 jumps. As well if (x == 0) no longer emits a ceq.
5171 if (x is Foo) is much faster now, because we generate
5174 Overall, we get a pretty big improvement on our benchmark
5175 tests. The code we generate is smaller and more readable.
5177 I did a full two-stage bootstrap. The patch was reviewed
5178 by Martin and Miguel.
5180 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5182 * cs-parser.jay: Make primary_expression not take a QI.
5183 we dont need this because the member_access rule covers
5184 us here. So we replace the rule with just IDENTIFIER.
5186 This has two good effects. First, we remove a s/r conflict.
5187 Second, we allocate many fewer QualifiedIdentifier objects.
5189 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5191 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5192 set the correct information via SRE. This prevents
5193 hanging on the MS runtime. Fixes #29374.
5195 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5197 * convert.cs: correctly handle conversions to value types
5198 from Enum and ValueType as unboxing conversions.
5200 Fixes bug #52569. Patch by Benjamin Jemlich.
5202 2004-01-02 Ravi Pratap <ravi@ximian.com>
5204 * expression.cs (BetterConversion): Prefer int -> uint
5205 over int -> ulong (csc's behaviour). This fixed bug #52046.
5207 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5209 * decl.cs (MemberCache.FindMembers): now returns a
5212 * typemanager.cs: In general, go with with ^^.
5213 (CopyNewMethods): take an IList.
5214 (RealMemberLookup): Only allocate an arraylist
5215 if we copy from two sets of methods.
5217 This change basically does two things:
5218 1) Fewer array lists allocated due to CopyNewMethods.
5219 2) the explicit cast in MemberList costed ALOT.
5221 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5223 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5224 a hashtable to avoid needless string allocations when an identifier is
5225 used more than once (the common case).
5227 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5229 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5230 is broken, it will not return anything. So, we
5231 have to use the information we have in mcs to
5234 * typemanager.cs: Add a cache for GetInterfaces,
5235 since this will now be used more often (due to ^^)
5237 (GetExplicitInterfaces) New method that gets the
5238 declared, not effective, interfaces on a type
5239 builder (eg, if you have interface IFoo, interface
5240 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5243 This patch makes MCS able to bootstrap itself on
5246 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5248 * expression.cs: Remove the Nop's that Miguel put
5251 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5253 * report.cs, codegen.cs: Give the real stack trace to
5254 the error when an exception is thrown.
5256 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5258 * decl.cs: only allocate hashtables for ifaces if
5261 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5263 * expression.cs: fix the error from cs0121-2.cs
5264 (a parent interface has two child interfaces that
5265 have a function with the same name and 0 params
5266 and the function is called through the parent).
5268 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5270 * class.cs, rootcontext.cs, typmanager.cs: do not
5273 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5275 * codegen.cs: remove stack for the ec flow branching.
5276 It is already a linked list, so no need.
5278 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5280 * Makefile: Allow custom profiler here.
5282 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5284 * typemanager.cs (LookupType):
5285 - Use a static char [], because split takes
5286 a param array for args, so it was allocating
5288 - Do not store true in a hashtable, it boxes.
5290 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5292 * flowanalysis.cs: bytify common enums.
5294 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5296 * modifiers.cs: Add a new set of flags for the
5297 flags allowed on explicit interface impls.
5298 * cs-parser.jay: catch the use of modifiers in
5299 interfaces correctly.
5300 * class.cs: catch private void IFoo.Blah ().
5302 All related to bug #50572.
5304 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5306 * decl.cs: Rewrite the consistant accessability checking.
5307 Accessability is not linear, it must be implemented in
5308 a tableish way. Fixes #49704.
5310 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5312 * expression.cs: Handle negation in a checked context.
5313 We must use subtraction from zero. Fixes #38674.
5315 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5317 * class.cs: Ignore static void main in DLLs.
5318 * rootcontext.cs: Handle the target type here,
5319 since we are have to access it from class.cs
5320 * driver.cs: account for the above.
5322 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5324 * report.cs: Give line numbers and files if available.
5326 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5328 * driver.cs: Implement /addmodule.
5330 * typemanager.cs: Change 'modules' field so it now contains Modules not
5333 2003-12-20 Martin Baulig <martin@ximian.com>
5335 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5336 (FieldBase.IsAssigned): Removed this field.
5337 (FieldBase.SetAssigned): New public method.
5338 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5340 2003-12-20 Martin Baulig <martin@ximian.com>
5342 * expression.cs (LocalVariableReference.DoResolve): Don't set
5343 `vi.Used' if we're called from DoResolveLValue().
5345 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5346 returns the usage vector it just merged into the current one -
5347 pass this one to UsageWarning().
5348 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5349 of the `EmitContext', don't call this recursively on our children.
5351 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5353 * driver.cs: Implement /target:module.
5355 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5357 * support.cs (CharArrayHashtable): New helper class.
5359 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5360 char arrays, not strings, so we can avoid creating a string in
5361 consume_identifier if the identifier is a keyword.
5363 2003-12-16 Martin Baulig <martin@ximian.com>
5365 * statement.cs (LocalInfo.Assigned): Removed this property.
5366 (LocalInfo.Flags): Removed `Assigned'.
5367 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5368 and uses flow analysis.
5369 (Block.UsageWarning): Made this method private.
5370 (Block.Resolve): Call UsageWarning() if appropriate.
5372 * expression.cs (LocalVariableReference.DoResolve): Always set
5373 LocalInfo.Used here.
5375 2003-12-13 Martin Baulig <martin@ximian.com>
5377 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5378 any value here; we're now using flow analysis to figure out
5379 whether a statement/block returns a value.
5381 2003-12-13 Martin Baulig <martin@ximian.com>
5383 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5385 (FlowBranching.MergeFinally): Don't call
5386 `branching.CheckOutParameters()' here, this is called in
5388 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5389 when adding the `finally' vector.
5391 2003-12-13 Martin Baulig <martin@ximian.com>
5394 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5395 actually work and also fix #48962.
5397 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5399 * decl.cs: Do not check System.Object for nested types,
5400 since we know it does not have any. Big bang for buck:
5405 corlib: 17.99 seconds
5409 corlib: 17.39 seconds
5411 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5413 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5414 time we are returning 0 members, so we save alot here.
5416 2003-12-11 Martin Baulig <martin@ximian.com>
5418 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5419 `MergeChild()', also just take the `FlowBranching' as argument;
5420 call Merge() on it and return the result.
5421 (FlowBranching.Merge): We don't need to do anything if we just
5424 2003-12-11 Martin Baulig <martin@ximian.com>
5426 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5427 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5428 Maurer for this idea.
5430 2003-12-11 Martin Baulig <martin@ximian.com>
5432 * flowanalysis.cs (MergeResult): This class is now gone; we now
5433 use the `UsageVector' for this. The reason for this is that if a
5434 branching just has one sibling, we don't need to "merge" them at
5435 all - that's the next step to do.
5436 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5439 2003-12-11 Martin Baulig <martin@ximian.com>
5441 Reworked flow analyis and made it more precise and bug-free. The
5442 most important change is that we're now using a special `Reachability'
5443 class instead of having "magic" meanings of `FlowReturns'. I'll
5444 do some more cleanups and optimizations and also add some more
5445 documentation this week.
5447 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5448 largely reworked this class.
5449 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5450 the new `Reachability' class instead of having "magic" values here.
5451 (FlowBranching): We're now using an instance of `Reachability'
5452 instead of having separate `Returns', `Breaks' etc. fields.
5454 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5455 based on flow analysis; ignore the return value of block.Emit ().
5457 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5459 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5460 if they are private.
5462 2003-12-09 Martin Baulig <martin@ximian.com>
5464 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5465 call them directly on the UsageVector.
5467 2003-12-09 Martin Baulig <martin@ximian.com>
5469 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5470 Changed return type from `FlowReturns' to `Reachability'.
5472 2003-12-09 Martin Baulig <martin@ximian.com>
5474 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5475 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5476 `Reachable' fields with a single `Reachability' one.
5478 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5480 * class.cs (FindMembers): Remove foreach's.
5493 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5498 This patch does a few things:
5499 1. EmptyStatement is now a singleton, so it is never reallocated.
5500 2. All blah is EmptyStatement constructs have been changed to
5501 blah == EmptyStatement.Value, which is much faster and valid
5502 now that EmptyStatement is a singleton.
5503 3. When resolving a block, rather than allocating a new array for
5504 the non-empty statements, empty statements are replaced with
5505 EmptyStatement.Value
5506 4. Some recursive functions have been made non-recursive.
5507 Mainly the performance impact is from (3), however (1) and (2) are needed for
5508 this to work. (4) does not make a big difference in normal situations, however
5509 it makes the profile look saner.
5514 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5515 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5516 Total memory allocated: 56397 KB
5519 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5520 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5521 Total memory allocated: 55666 KB
5523 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5525 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5526 than the hashtable in a hashtable version
5528 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5529 we always end up concating a string. This results in a huge perf
5530 loss, because many strings have to be tracked by the GC. In this
5531 patch, we first use a hashtable that works with two keys, so that
5532 the strings do not need to be concat'ed.
5543 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5545 * Makefile: Add a new target `do-time' that does a quick and simple
5546 profile, leaving easy to parse output.
5548 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5550 * codegen.cs (Init): Create the dynamic assembly with
5551 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5553 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5555 * support.cs: Make the PtrHashtable use only one
5556 instance of its comparer.
5558 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5560 * typemanager.cs: Fix lookup of GetNamespaces.
5562 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5564 * expression.cs: Removed redundant line.
5566 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5567 ArrayLists, use for loops with bounds.
5569 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5572 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5573 arraylists, use for loop with bounds.
5575 The above three changes give us a 0.071 second performance
5576 improvement out of 3.294 seconds down to 3.223. On my machine
5577 the above changes reduced the memory usage by 1,387 KB during
5580 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5581 QualifiedIdentifiers. Before we created a new string through
5582 concatenation, and mostly later on, the result would be
5583 manipulated by DecomposeQI through string manipulation.
5585 This reduced the compiler memory usage for bootstrapping from
5586 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5587 compile times in 0.05 seconds.
5589 2003-11-28 Dick Porter <dick@ximian.com>
5591 * support.cs: Do string compares with the Invariant culture.
5599 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5600 the comparison is done with the Invariant culture.
5602 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5604 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5605 GetEnumerator method.
5607 (ProbeCollectionType): Iterate starting at the most specific type
5608 upwards looking for a GetEnumerator
5610 * expression.cs: Shift count can be up to 31 for int/uint and 63
5613 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5615 * statement.cs (Block.LookupLabel): Also look for the label on the
5616 children blocks. Use a hash table to keep track of visited
5619 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5620 we actually did transform the other operand, otherwise fall back
5621 to the common codepath that casts to long.
5623 * cs-tokenizer.cs: Use the same code pattern as the int case.
5624 Maybe I should do the parsing myself, and avoid depending on the
5625 Parse routines to get this done.
5627 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5629 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5630 which fixes bug 51347. This time test it.
5632 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5633 attributes for example can not tell the difference between these.
5634 The difference was only a syntax feature of the language.
5636 * attribute.cs: Apply attributes to delegates.
5638 * delegate.cs: Call the apply attributes method.
5640 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5642 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5643 comparing 0 vs Byte.MinValue, not the value
5645 (ImplicitConversionRequired): When reporting a conversion error,
5646 use error 31 to print out the constant error instead of the
5649 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5650 which fixes bug 51347.
5652 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5654 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5655 which fixes the -warnaserror command line option.
5657 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5659 * cfold.cs (DoNumericPromotions): During constant folding of
5660 additions on UIntConstant, special case intconstants with
5661 IntConstants like we do on the expression binary operator.
5663 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5665 * convert.cs (ImplicitReferenceConversion): We were missing a case
5666 (System.Enum are not value types or class types, so we need to
5667 classify them separatedly).
5669 * driver.cs: We do not support error 2007.
5671 2003-11-12 Jackson Harper <jackson@ximian.com>
5673 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5674 system directory. Also use the full file name so users can
5675 libraries names mscorlib-o-tron.dll in a non system dir.
5677 2003-11-10 Martin Baulig <martin@ximian.com>
5679 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5680 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5681 calling `ResolveType()' on them, directly assign their `Type'.
5683 2003-11-08 Martin Baulig <martin@ximian.com>
5685 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5686 return value and the `out parent' parameter.
5687 (TypeContainer.DefineType): Moved the CS0644 check into
5688 GetClassBases(). Don't pass the interface types to the
5689 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5690 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5692 * ecore.cs (TypeExpr.IsAttribute): New property.
5693 (TypeExpr.GetInterfaces): New method.
5695 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5696 TypeExpr instead of a Type.
5697 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5698 (Interface.DefineType): Don't pass the interface types to the
5699 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5700 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5702 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5703 instead of a `Type[]'.
5704 (TypeManager.RegisterBuilder): Likewise.
5705 (TypeManager.AddUserInterface): Likewise.
5706 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5707 `Type[]' and also return a `TypeExpr[]'.
5708 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5710 2003-11-08 Martin Baulig <martin@ximian.com>
5712 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5715 2003-11-08 Martin Baulig <martin@ximian.com>
5717 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5718 TypeManager.ResolveExpressionTypes().
5720 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5721 instead of an Expression.
5722 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5723 (TypeExpression): New public class; formerly known as `TypeExpr'.
5725 * expression.cs (ComposedCast): Derive from TypeExpr.
5727 * typemanager.cs (TypeManager.system_*_expr): These are now
5728 TypExpr's instead of Expression's.
5729 (TypeManager.ResolveExpressionTypes): New public static function;
5730 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5733 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5735 * expression.cs (New.DoResolve): Do not dereference value that
5736 might be a null return.
5738 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5739 sure that the constant value has the right type. Fixes an
5740 unreported bug, similar to 50425.
5742 * const.cs (Const.LookupConstantValue): Call
5743 ImplicitStandardConversionExists before doing a conversion to
5744 avoid havng the TypeManager.ChangeType do conversions.
5746 Reduced the number of casts used
5748 (Const.ChangeType): New routine to enable reuse of the constant
5749 type changing code from statement.
5751 * typemanager.cs (ChangeType): Move common initialization to
5752 static global variables.
5756 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5757 every value type to go through, even if it was void. Fix that.
5759 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5760 character of the define, and the is_identifier_part_character for
5761 the rest of the string.
5763 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5765 * expression.cs (UnaryMutator.EmitCode): When I updated
5766 LocalVariableReference.DoResolve, I overdid it, and dropped an
5767 optimization done on local variable references.
5769 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5771 * ecore.cs: Convert the return from Ldlen into an int.
5773 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5775 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5776 the accessibility, this is a special case for toplevel non-public
5777 classes (internal for instance).
5779 2003-10-20 Nick Drochak <ndrochak@gol.com>
5781 * ecore.cs: Fix typo and build. Needed another right paren.
5783 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5785 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5786 `internal' case regular and protected, but not allowing protected
5787 to be evaluated later. Bug 49840
5789 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5791 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5792 to kb.Nlast, and not the kb.nFirst to isolate the switch
5795 Extract the underlying type, so enumerations of long/ulong are
5796 treated like long/ulong.
5798 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5800 * expression.cs (New): Overload the meaning of RequestedType to
5801 track the possible creation of the NewDelegate type, since
5802 DoResolve is invoked more than once for new constructors on field
5805 See bugs: #48800 and #37014
5807 * cs-parser.jay (declare_local_constants): Take an arraylist
5808 instead of a single constant.
5810 (local_constant_declaration): It should take a
5811 constant_declarators, not a constant_declarator. Fixes 49487
5813 * convert.cs: Fix error report.
5815 2003-10-13 Jackson Harper <jackson@ximian.com>
5817 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5820 2003-10-09 Martin Baulig <martin@ximian.com>
5822 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5824 (MethodCore.DoDefineParameters): Removed the TypeContainer
5825 argument; use the DeclSpace which was passed to the .ctor instead.
5826 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5827 TypeContainer; we only need a DeclSpace here.
5829 2003-10-09 Martin Baulig <martin@ximian.com>
5831 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5833 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5834 EmitContext's .ctor.
5836 2003-10-09 Martin Baulig <martin@ximian.com>
5838 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5839 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5840 AsAccessible(), moved them as well.
5842 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5844 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5846 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5848 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5850 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5851 generation for >=, as spotted by Paolo, bug 48679.
5852 Patch from David Waite.
5854 * cs-tokenizer.cs: Add handling for #pragma.
5856 * cs-parser.jay: Allow for both yield and yield return in the
5857 syntax. The anti-cobolization of C# fight will go on!
5859 * class.cs (TypeBuilder.DefineType): Catch error condition here
5860 (Parent.DefineType erroring out and returning null).
5862 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5863 coping with enumerations variables, we were mistakenly processing
5864 them as a regular value type instead of built-in types. Fixes the
5867 * typemanager.cs (IsBuiltinOrEnum): New method.
5869 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5871 * cs-parser.jay: Upgrade: yield now needs the return clause.
5873 2003-09-19 Martin Baulig <martin@ximian.com>
5875 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5876 `MemberCache parent' argument. Normally, an interface doesn't
5877 have a parent type except System.Object, but we use this in gmcs
5878 for generic type parameters.
5880 2003-09-18 Martin Baulig <martin@ximian.com>
5882 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5883 on `type.IsInterface'; don't check whether the type has a parent
5884 to determine whether it's an interface.
5886 2003-09-15 Martin Baulig <martin@ximian.com>
5888 * class.cs (TypeContainer.DefineType): Added an error flag to
5889 avoid reporting duplicate CS0146's ("class definition is
5892 * driver.cs (Driver.MainDriver): Abort if
5893 RootContext.ResolveTree() reported any errors.
5895 2003-09-07 Martin Baulig <martin@ximian.com>
5897 * report.cs (Error, Warning): Added overloaded versions which take
5898 a `params object[] args' and call String.Format().
5900 2003-09-07 Martin Baulig <martin@ximian.com>
5902 * decl.cs (DeclSpace..ctor): Don't call
5903 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5904 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5905 (DeclSpace.RecordDecl): New method.
5907 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5909 2003-09-02 Ravi Pratap <ravi@ximian.com>
5911 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5912 value attributes to be applied to ParameterBuilders.
5914 * class.cs (MethodCore.LabelParameters): Make static and more
5915 generic so that it can be used from other places - like interface
5916 methods, for instance.
5918 * interface.cs (Interface.Emit): Call LabelParameters before
5919 emitting attributes on the InterfaceMethod.
5921 2003-08-26 Martin Baulig <martin@ximian.com>
5923 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5924 resolving aliases; fixes #47927.
5926 2003-08-26 Martin Baulig <martin@ximian.com>
5928 * statement.cs (Using.DoResolve): This is internally emitting a
5929 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5930 do not always return. Fixes #47681.
5932 2003-08-26 Martin Baulig <martin@ximian.com>
5934 * decl.cs (MemberCore): Moved WarningNotHiding(),
5935 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5937 (AdditionResult): Make this nested in DeclSpace.
5938 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5939 argument; call NamespaceEntry.Define() unless we're nested in a
5942 * namespace.cs (Namespace.DefineName): New public function. This
5943 is called from DeclSpace's .ctor to add
5944 (Namespace.Lookup): Include DeclSpaces in the lookup.
5946 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5948 * const.cs (Const): Derive from MemberBase, not MemberCore.
5950 2003-08-25 Martin Baulig <martin@ximian.com>
5952 * convert.cs (Convert.ExplicitReferenceConversion): When
5953 converting from an interface type to a class, unbox if the target
5954 type is a struct type. Fixes #47822.
5956 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5958 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5961 2003-08-22 Martin Baulig <martin@ximian.com>
5963 * class.cs (TypeManager.DefineType): When defining a nested type,
5964 call DefineType() on our parent; fixes #47801.
5966 2003-08-22 Martin Baulig <martin@ximian.com>
5968 * class.cs (MethodData.Define): While checking if a method is an
5969 interface implementation, improve the test a bit more to fix #47654.
5971 2003-08-22 Martin Baulig <martin@ximian.com>
5973 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5974 correctly; fixes #47722.
5976 2003-08-22 Martin Baulig <martin@ximian.com>
5978 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5979 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5981 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5983 2003-08-22 Martin Baulig <martin@ximian.com>
5985 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5986 can only be assigned in static constructors. Fixes #47161.
5988 2003-08-22 Martin Baulig <martin@ximian.com>
5990 Rewrote and improved the flow analysis code.
5992 * flowbranching.cs (FlowBranching): Make this class abstract.
5993 (FlowBranching.CreateBranching): New static function to create a
5995 (FlowBranchingBlock, FlowBranchingException): New classes.
5996 (FlowBranching.UsageVector.Type): New public readonly field.
5997 (FlowBranching.UsageVector.Breaks): Removed the setter.
5998 (FlowBranching.UsageVector.Returns): Removed the setter.
5999 (FlowBranching.UsageVector): Added Break(), Return(),
6000 NeverReachable() and Throw() methods to modify the reachability.
6001 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6002 done by FlowBranching.Merge().
6003 (FlowBranching.UsageVector.MergeChild): New method; merges the
6004 merge result into the current vector.
6005 (FlowBranching.Merge): New abstract method to merge a branching.
6007 2003-08-12 Martin Baulig <martin@ximian.com>
6009 * expression.cs (Indirection.CacheTemporaries): Create the
6010 LocalTemporary with the pointer type, not its element type.
6012 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6014 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6015 token was a keyword or not.
6017 Add `error' options where an IDENTIFIER was expected; Provide
6018 CheckToken and CheckIdentifierToken convenience error reporting
6021 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6023 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6024 NameSpaceEntry NameSpaceEntry.
6026 (LookupInterfaceOrClass): Avoid creating a full qualified name
6027 from namespace and name: avoid doing lookups when we know the
6028 namespace is non-existant. Use new Tree.LookupByNamespace which
6029 looks up DeclSpaces based on their namespace, name pair.
6031 * driver.cs: Provide a new `parser verbose' to display the
6032 exception thrown during parsing. This is turned off by default
6033 now, so the output of a failure from mcs is more graceful.
6035 * namespace.cs: Track all the namespaces defined in a hashtable
6038 (IsNamespace): New method
6040 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6042 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6043 we know that we need to concatenate (full typename can never be
6048 * statement.cs: Use a bitfield; Do not initialize to null things
6049 which are done by the constructor by default.
6051 * cs-parser.jay: bug fix, parameter was 4, not 3.
6053 * expression.cs: Just use the property;
6055 * statement.cs: No need for GetVariableInfo method.
6057 2003-08-08 Martin Baulig <martin@ximian.com>
6059 * flowanalysis.cs (FlowReturns): This is now nested in the
6060 `FlowBranching' class.
6061 (MyBitVector): Moved this here from statement.cs.
6062 (FlowBranching.SiblingType): New enum type.
6063 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6065 2003-08-07 Martin Baulig <martin@ximian.com>
6067 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6068 `FlowBranching' class and called `BranchingType'.
6070 2003-08-07 Martin Baulig <martin@ximian.com>
6072 * flowanalysis.cs: Moved all the control flow analysis code into
6075 2003-08-07 Martin Baulig <martin@ximian.com>
6077 * assign.cs (Assign.DoResolve): `target' must either be an
6078 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6081 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6083 * expression.cs (BinaryMethod): This kind of expression is created by the
6084 Binary class if it determines that the operator has to be handled
6087 (BinaryDelegate): This kind of expression is created if we are
6088 dealing with a + or - operator on delegates.
6090 (Binary): remove method, argumetns, and DelegateOperator: when
6091 dealing with methods,
6093 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6095 * statement.cs (Block): use bitfields for the three extra booleans
6096 we had in use. Remove unused topblock parameter.
6098 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6100 * assign.cs: Drop extra unneeded tests.
6102 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6104 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6106 * statement.cs (Foreach): Use VariableStorage instead of
6109 * codegen.cs (VariableStorage): New class used by clients that
6110 require a variable stored: locals or fields for variables that
6111 need to live across yield.
6113 Maybe provide a convenience api for EmitThis+EmitLoad?
6115 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6118 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6120 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6121 RemapParameterLValue): New methods that are used to turn a
6122 precomputed FieldInfo into an expression like this:
6126 The idea is to use this instead of making LocalVariableReference
6127 have more than one meaning.
6129 * cs-parser.jay: Add error production to BASE.
6131 * ecore.cs: Deal with TypeManager.GetField returning null, which
6132 is now a valid return value.
6134 (FieldExprNoAddress): New expression for Fields whose address can
6137 * expression.cs (LocalVariableReference): During the resolve
6138 phases, create new expressions if we are in a remapping context.
6139 Remove code that dealt with remapping here.
6141 (ParameterReference): same.
6143 (ProxyInstance): New expression, like the `This' expression, but
6144 it is born fully resolved. We know what we are doing, so remove
6145 the errors that are targeted to user-provided uses of `this'.
6147 * statement.cs (Foreach): our variable is now stored as an
6148 Expression; During resolution, follow the protocol, dont just
6149 assume it will return this.
6151 2003-08-06 Martin Baulig <martin@ximian.com>
6153 * support.cs (SeekableStreamReader.cs): New public class.
6155 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6156 SeekableStreamReader instead of the normal StreamReader.
6158 2003-08-04 Martin Baulig <martin@ximian.com>
6160 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6161 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6162 deambiguate casts and delegate invocations.
6163 (parenthesized_expression): Use the new tokens to ensure this is
6164 not a cast of method invocation.
6166 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6167 when reading a `)' and Deambiguate_CloseParens () was previously
6170 * expression.cs (ParenthesizedExpression): New class. This is
6171 just used for the CS0075 test.
6172 (Binary.DoResolve): Check for CS0075.
6174 2003-07-29 Ravi Pratap <ravi@ximian.com>
6176 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6177 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6178 reference comparison.
6180 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6181 examine the ReturnType for equality - this is necessary in the
6182 cases of implicit and explicit operators whose signature also
6183 includes the return type.
6185 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6187 * namespace.cs: Cache the result of the namespace computation,
6188 instead of computing it every time.
6190 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6192 * decl.cs: Use a global arraylist that we reuse over invocations
6193 to avoid excesive memory consumption. Reduces memory usage on an
6194 mcs compile by one meg (45 average).
6196 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6197 private, work around that.
6199 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6201 * literal.cs (IntLiteral): Define Zero and One static literals.
6203 * cs-parser.jay (integer_literal): use static literals to reduce
6204 memory usage for the most used literals (0, 1 and -1). 211kb
6205 reduced in memory usage.
6207 Replace all calls to `new ArrayList' with `new
6208 ArrayList(4)' which is a good average number for most allocations,
6209 and also requires only 16 bytes of memory for its buffer by
6212 This reduced MCS memory usage in seven megabytes for the RSS after
6215 2003-07-28 Ravi Pratap <ravi@ximian.com>
6217 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6218 handle params methods the correct way by forming only one
6219 applicable set with params and normal methods in them. Earlier we
6220 were looking at params methods only if we found no normal methods
6221 which was not the correct thing to do.
6223 (Invocation.BetterFunction): Take separate arguments indicating
6224 when candidate and the best method are params methods in their
6227 This fixes bugs #43367 and #46199.
6229 * attribute.cs: Documentation updates.
6231 (CheckAttribute): Rename to CheckAttributeTarget.
6232 (GetValidPlaces): Rename to GetValidTargets.
6234 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6235 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6239 2003-07-28 Martin Baulig <martin@ximian.com>
6241 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6242 name when looking up the base class of a nested class. Fixes #46977.
6244 2003-07-26 Martin Baulig <martin@ximian.com>
6246 * expression.cs (Indexers.Indexer): New nested struct; contains
6247 getter, setter and the indexer's type.
6248 (Indexers.Properties): This is now an ArrayList of
6250 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6251 indexer doesn't have any getters.
6253 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6254 for embedded property and indexer assignments.
6256 2003-07-26 Martin Baulig <martin@ximian.com>
6258 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6259 preprocessor directive is not the first non-whitespace character
6262 2003-07-26 Martin Baulig <martin@ximian.com>
6264 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6265 namespace parsing, follow the spec more closely.
6267 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6268 NamespaceEntry.Lookup().
6270 2003-07-25 Martin Baulig <martin@ximian.com>
6272 * MethodCore.cs (OverridesSomething): New public field; it's set
6273 from TypeContainer.DefineMembers if this method overrides
6274 something (which doesn't need to be a method). Fix #39462.
6276 2003-07-25 Ravi Pratap <ravi@ximian.com>
6278 * typemanager.cs (GetMembers): Ensure that the list of members is
6279 reversed. This keeps things in sync.
6281 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6282 find an AttributeUsage attribute.
6284 * expression.cs (Invocation.OverloadResolve): Perform the check
6285 which disallows Invoke to be directly called on a Delegate.
6287 (Error_InvokeOnDelegate): Report error cs1533.
6289 2003-07-25 Martin Baulig <martin@ximian.com>
6291 * expression.cs (Indexers.GetIndexersForType): Only look in the
6292 interface hierarchy if the requested type is already an
6293 interface. Fixes #46788 while keeping #46502 fixed.
6295 2003-07-25 Martin Baulig <martin@ximian.com>
6297 * class.cs (TypeContainer.DefineMembers): Check whether all
6298 readonly fields have been assigned and report warning CS0649 if
6301 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6304 2003-07-24 Ravi Pratap <ravi@ximian.com>
6306 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6307 returned from GetMethods to make things consistent with the
6308 assumptions MCS makes about ordering of methods.
6310 This should comprehensively fix bug #45127 and it does :-)
6312 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6313 ordering is actually reverse.
6315 * Clean up some debug messages I left lying around.
6317 * interface.cs (Populate*): Get rid of code which emits attributes
6318 since the stage in which we emit attributes is the 'Emit' stage,
6319 not the define stage.
6321 (Emit): Move attribute emission for interface members here.
6323 2003-07-22 Ravi Pratap <ravi@ximian.com>
6325 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6326 closely: we eliminate methods in base types when we have an
6327 applicable method in a top-level type.
6329 Please see section 14.5.5.1 for an exact description of what goes
6332 This fixes bug #45127 and a host of other related to corlib compilation.
6334 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6335 array is the method corresponding to the top-level type (this is
6336 because of the changes made to icall.c) so we change this
6339 (MethodGroupExpr.Name): This too.
6341 * typemanager.cs (GetElementType): New method which does the right
6342 thing when compiling corlib.
6344 * everywhere: Make use of the above in the relevant places.
6346 2003-07-22 Martin Baulig <martin@ximian.com>
6348 * cs-parser.jay (invocation_expression): Moved
6349 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6350 `cast_expression', but create a InvocationOrCast which later
6351 resolves to either an Invocation or a Cast.
6353 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6354 method; call this before EmitStatement() to make sure that this
6355 expression can be used as a statement.
6357 * expression.cs (InvocationOrCast): New class; resolves to either
6358 an Invocation or a Cast.
6360 * statement.cs (StatementExpression): Call ResolveStatement() on
6361 the ExpressionStatement before emitting it.
6363 2003-07-21 Martin Baulig <martin@ximian.com>
6365 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6366 `ref' and `out' attributes match; fixes #46220.
6367 (MemberAccess.ResolveMemberAccess): You can't reference a type
6368 through an expression; fixes #33180.
6369 (Indexers.GetIndexersForType): Don't return the indexers from
6370 interfaces the class implements; fixes #46502.
6372 2003-07-21 Martin Baulig <martin@ximian.com>
6374 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6375 CS0661 checks; fixes bug #30442.
6377 2003-07-21 Martin Baulig <martin@ximian.com>
6379 * decl.cs (AdditionResult): Added `Error'.
6381 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6383 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6384 makes cs0031.cs actually work.
6386 2003-07-20 Martin Baulig <martin@ximian.com>
6388 * namespace.cs: Fixed that bug which caused a crash when compiling
6391 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6393 * typemanager.cs (LookupTypeReflection): Never expose types which
6394 are NotPublic, NestedPrivate, NestedAssembly, or
6395 NestedFamANDAssem. We used to return these, and later do a check
6396 that would report a meaningful error, but the problem is that we
6397 would not get the real match, if there was a name override.
6399 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6401 * namespace.cs (Namespace, Name): Do not compute the namespace
6402 name dynamically, compute it in the constructor. This reduced
6403 memory usage by 1697 KB.
6405 * driver.cs: Use --pause to pause at the end.
6407 2003-07-17 Peter Williams <peter@newton.cx>
6409 * Makefile: Change the name of the test target so that it doesn't
6410 conflict with the recursive test target.
6412 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6414 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6415 AddressOf): Do not use EmitThis, that was wrong, use the actual
6418 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6420 * class.cs (MethodData.Define): While checking if a method is an
6421 interface implementation, improve the test: If we are not public
6422 (use new test here: use the computed MethodAttributes directly,
6423 instead of the parsed modifier flags) check if the `implementing'
6424 method comes from an interface or not.
6426 * pending.cs (VerifyPendingMethods): Slightly better error
6429 * makefile: add test target that does the mcs bootstrap.
6431 2003-07-16 Ravi Pratap <ravi@ximian.com>
6433 * interface.cs (Define): Do nothing here since there are no
6434 members to populate etc. Move the attribute emission out of here
6435 since this was just totally the wrong place to put it. Attribute
6436 application happens during the 'Emit' phase, not in the 'Define'
6439 (Emit): Add this method and move the attribute emission here
6441 * rootcontext.cs (EmitCode): Call the Emit method on interface
6444 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6446 * expression.cs (OverloadResolve): Report error only if Location
6447 is not 'Null' which means that there was a probe going on.
6449 2003-07-14 Martin Baulig <martin@ximian.com>
6451 * expression.cs (ConditionalLogicalOperator): New public class to
6452 implement user defined conditional logical operators.
6453 This is section 14.11.2 in the spec and bug #40505.
6455 2003-07-14 Martin Baulig <martin@ximian.com>
6457 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6459 2003-07-14 Martin Baulig <martin@ximian.com>
6461 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6463 * ecore.cs (IVariable.VerifyFixed): New interface method.
6465 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6466 operator, check whether the variable is actually fixed. Fixes bug
6467 #36055. Set a variable definitely assigned when taking its
6468 address as required by the spec.
6470 * statement.cs (LocalInfo.IsFixed): New field.
6471 (LocalInfo.MakePinned): Set `IsFixed' to true.
6473 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6475 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6476 for .ctors, ensure that we only ask for members declared in the
6477 attribute type (BindingFlags.DeclaredOnly).
6481 * expression.cs (Error_WrongNumArguments): Report error 1501
6482 correctly the way CSC does.
6484 2003-07-13 Martin Baulig <martin@ximian.com>
6486 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6487 lookup on the fully qualified name, to make things like "X.X" work
6488 where "X.X" is a fully qualified type name, but we also have a
6489 namespace "X" in the using list. Fixes #41975.
6491 2003-07-13 Martin Baulig <martin@ximian.com>
6493 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6494 function. If we're a CompoundAssign, we need to create an embedded
6495 CompoundAssign, not an embedded Assign.
6496 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6499 2003-07-13 Martin Baulig <martin@ximian.com>
6501 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6502 work to fix bug #46088.
6504 2003-07-13 Ravi Pratap <ravi@ximian.com>
6506 * class.cs (Operator.Emit): Do not emit attributes here - it is
6507 taken care of by the Method class that we delegate too. This takes
6510 2003-07-10 Martin Baulig <martin@ximian.com>
6512 * expression.cs (TypeOfVoid): New class.
6513 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6515 2003-07-10 Martin Baulig <martin@ximian.com>
6517 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6520 2003-07-10 Martin Baulig <martin@ximian.com>
6522 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6523 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6525 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6527 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6529 2003-07-10 Martin Baulig <martin@ximian.com>
6531 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6532 of decimal. Fixes #42850.
6534 NOTE: I also fixed the created byte blob, but this doesn't work on
6535 the MS runtime and csc never produces any byte blobs for decimal
6538 2003-07-10 Martin Baulig <martin@ximian.com>
6540 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6541 structs; fixes #32068.
6542 (Block.AddChildVariableNames): Fixed #44302.
6544 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6546 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6548 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6550 * attribute.cs: And this test is onger needed.
6552 2003-07-08 Martin Baulig <martin@ximian.com>
6554 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6555 inaccessible types. Fixes #36313.
6557 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6559 * namespace.cs (NamespaceEntry): Create implicit entries for all
6560 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6561 implicit entries for N1.N2 and N1.
6563 2003-07-08 Martin Baulig <martin@ximian.com>
6565 Rewrote the handling of namespaces to fix a lot of the issues
6566 wrt. `using' aliases etc.
6568 * namespace.cs (Namespace): Splitted this class into a
6569 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6571 * typemanager.cs (TypeManager.IsNamespace): Removed.
6572 (TypeManager.ComputeNamespaces): Only compute namespaces from
6573 loaded assemblies here, not the namespaces from the assembly we're
6574 currently compiling.
6576 2003-07-08 Martin Baulig <martin@ximian.com>
6578 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6580 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6582 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6585 I thought about the memory savings here, but LookupTypeReflection
6586 is used under already very constrained scenarios. Compiling
6587 corlib or mcs only exposes one hit, so it would not really reduce
6588 any memory consumption.
6590 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6592 * typemanager.cs: fixes bug #45889 by only adding public types from
6593 other assemblies to the list of known types.
6595 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6597 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6598 on the type we resolved.
6600 2003-07-05 Martin Baulig <martin@ximian.com>
6602 * pending.cs (PendingImplementation.ParentImplements): Don't
6603 create the proxy if the parent is abstract.
6605 * class.cs (TypeContainer.DefineIndexers): Process explicit
6606 interface implementations first. Fixes #37714.
6608 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6610 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6611 defined recursively; but since we modify the input parameters
6612 (left is set to `this' temporarily), we reset this value if the
6613 left_is_explicit is false, which gives the original semantics to
6616 * literal.cs (NullPointer): new class used to represent a null
6617 literal in a pointer context.
6619 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6620 type is a pointer, use a NullPointer object instead of a
6621 NullLiteral. Closes 43687
6623 (ExplicitConversion): Convert pointer values using
6624 the conv opcode to the proper type.
6626 * ecore.cs (New): change ValueTypeVariable property into a method,
6627 that returns whether the valuetype is suitable for being used.
6629 * expression.cs (Binary.DoNumericPromotions): Only return if we
6630 the int constant was a valid uint, and we can return both left and
6631 right as uints. If not, we continue processing, to trigger the
6632 type conversion. This fixes 39018.
6634 * statement.cs (Block.EmitMeta): During constant resolution, set
6635 the CurrentBlock property on the emitcontext, so that we resolve
6636 constants propertly.
6638 2003-07-02 Martin Baulig <martin@ximian.com>
6640 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6641 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6643 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6644 than emitting it here.
6646 * statement.cs: Fixed some more flow analysis bugs.
6648 2003-07-02 Martin Baulig <martin@ximian.com>
6650 * class.cs (MethodData.Define): When implementing interface
6651 methods, set Final unless we're Virtual.
6653 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6654 check work for interface methods.
6656 2003-07-01 Martin Baulig <martin@ximian.com>
6658 * ecore.cs (EmitContext.This): Replaced this property with a
6659 GetThis() method which takes a Location argument. This ensures
6660 that we get the correct error location for a CS0188.
6662 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6664 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6665 ImplicitStandardConversion.
6667 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6669 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6671 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6674 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6676 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6679 (MethodData.Define): Turn off initlocals for unsafe methods.
6681 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6683 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6684 complete; Fixes #37521.
6686 * delegate.cs: Use Modifiers.TypeAttr to compute the
6687 TypeAttributes, instead of rolling our own. This makes the flags
6688 correct for the delegates.
6690 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6692 * class.cs (Constructor.Define): Set the private flag for static
6693 constructors as well.
6695 * cs-parser.jay (statement_expression): Set the return value to
6696 null, to avoid a crash when we catch an error.
6698 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6700 * cs-parser.jay: Applied patch from Jackson that adds support for
6701 extern and unsafe modifiers to destructor declarations.
6703 * expression.cs: Report error 21 if the user is trying to index a
6706 * driver.cs: Add an error message, suggested by the bug report.
6708 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6709 if we do not have a ": this ()" constructor initializer. Fixes 45149
6711 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6713 * namespace.cs: Add some information to reduce FAQs.
6715 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6717 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6718 underlying enumeration types. Fixes #43915.
6720 * expression.cs: Treat ushort/short as legal values to be used in
6723 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6725 * delegate.cs: transfer custom attributes for paramenters from
6726 the delegate declaration to Invoke and BeginInvoke.
6728 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6730 * attribute.cs: handle custom marshalers and emit marshal info
6733 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6735 * makefile.gnu: Added anonymous.cs to the compiler sources.
6737 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6739 * iterators.cs: Change the name of the proxy class to include two
6742 * cs-parser.jay: Update grammar to include anonymous methods.
6744 * anonymous.cs: new file.
6746 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6748 * class.cs (Field.Define): Add missing test for pointers and
6751 2003-05-27 Ravi Pratap <ravi@ximian.com>
6753 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6754 we use the stobj opcode.
6756 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6757 since it wasn't the correct fix.
6759 It still is puzzling that we are required to use stobj for IntPtr
6760 which seems to be a ValueType.
6762 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6764 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6765 during regular simple name resolution. Now, the trick is that
6766 instead of returning for processing the simplename, we do a
6767 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6768 contextual lookup type). If a match is found, return that, if
6769 not, return for further composition.
6771 This fixes long-standing 30485.
6773 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6774 using the address to initialize an object, do an Stobj instead of
6775 using the regular Stelem.
6777 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6778 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6779 Because if we are a BaseIndexerAccess that value will be true.
6782 * statement.cs (GotoCase.Resolve): Return after reporting an
6783 error, do not attempt to continue.
6785 * expression.cs (PointerArithmetic.Emit): If our operand is a
6786 long, convert our constants to match the operand before
6787 multiplying. Convert to I type before adding. Fixes 43670.
6789 2003-05-14 Ravi Pratap <ravi@ximian.com>
6791 * enum.cs (ImplicitConversionExists) : Rename to
6792 ImplicitEnumConversionExists to remove ambiguity.
6794 * ecore.cs (NullCast): New type of cast expression class which
6795 basically is very similar to EmptyCast with the difference being
6796 it still is a constant since it is used only to cast a null to
6800 * convert.cs (ImplicitReferenceConversion): When casting a null
6801 literal, we return a NullCast.
6803 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6804 should be around anymore.
6806 The renaming (reported was slightly wrong). Corrections:
6808 ConvertImplicitStandard -> ImplicitConversionStandard
6809 ConvertExplicitStandard -> ExplicitConversionStandard
6811 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6812 before passing them in !
6814 * convert.cs (ImplicitConversionStandard): When comparing for
6815 equal expr and target types, ensure that expr is not a
6818 In general, we must not be checking (expr_type ==
6819 target_type) in the top level conversion methods
6820 (ImplicitConversion, ExplicitConversion etc). This checking is
6821 done in the methods that they delegate to.
6823 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6825 * convert.cs: Move Error_CannotConvertType,
6826 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6827 ImplicitNumericConversion, ImplicitConversionExists,
6828 ImplicitUserConversionExists, StandardConversionExists,
6829 FindMostEncompassedType, FindMostSpecificSource,
6830 FindMostSpecificTarget, ImplicitUserConversion,
6831 ExplicitUserConversion, GetConversionOperators,
6832 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6833 TryImplicitIntConversion, Error_CannotConvertImplicit,
6834 ConvertImplicitRequired, ConvertNumericExplicit,
6835 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6836 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6839 Perform the following renames:
6841 StandardConversionExists -> ImplicitStandardConversionExists
6842 ConvertImplicit -> ImplicitConversion
6843 ConvertImplicitStandard -> ImplicitStandardConversion
6844 TryImplicitIntConversion -> ImplicitIntConversion
6845 ConvertImplicitRequired -> ImplicitConversionRequired
6846 ConvertNumericExplicit -> ExplicitNumericConversion
6847 ConvertReferenceExplicit -> ExplicitReferenceConversion
6848 ConvertExplicit -> ExplicitConversion
6849 ConvertExplicitStandard -> ExplicitStandardConversion
6851 2003-05-19 Martin Baulig <martin@ximian.com>
6853 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6854 (TypeInfo): Added support for structs having structs as fields.
6856 * ecore.cs (FieldExpr): Implement IVariable.
6857 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6858 VariableInfo for the field.
6860 2003-05-18 Martin Baulig <martin@ximian.com>
6862 * expression.cs (This.DoResolve): Report a CS0027 if we're
6863 emitting a field initializer.
6865 2003-05-18 Martin Baulig <martin@ximian.com>
6867 * expression.cs (This.ResolveBase): New public function.
6868 (This.DoResolve): Check for CS0188.
6870 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6873 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6874 `instance_expression' to null if we don't have any non-static
6877 2003-05-18 Martin Baulig <martin@ximian.com>
6879 Reworked the way how local variables and parameters are handled by
6880 the flow analysis code.
6882 * statement.cs (TypeInfo, VariableMap): New public classes.
6883 (VariableInfo): New public class. This is now responsible for
6884 checking whether a variable has been assigned. It is used for
6885 parameters and local variables.
6886 (Block.EmitMeta): Take the InternalParameters as argument; compute
6887 the layout of the flow vectors here.
6888 (Block.LocalMap, Block.ParameterMap): New public properties.
6889 (FlowBranching): The .ctor doesn't get the InternalParameters
6890 anymore since Block.EmitMeta() now computes the layout of the flow
6892 (MyStructInfo): This class is now known as `StructInfo' and nested
6893 in `TypeInfo'; we don't access this directly anymore.
6895 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6896 property and removed IsAssigned(), IsFieldAssigned(),
6897 SetAssigned() and SetFieldAssigned(); we now call them on the
6898 VariableInfo so we don't need to duplicate this code everywhere.
6900 * expression.cs (ParameterReference): Added `Block block' argument
6902 (LocalVariableReference, ParameterReference, This): The new
6903 VariableInfo class is now responsible for all the definite
6906 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6907 IsParameterAssigned, SetParameterAssigned): Removed.
6909 2003-05-18 Martin Baulig <martin@ximian.com>
6911 * typemanager.cs (InitCoreTypes): Try calling
6912 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6913 the 3-args-version. Corlib now also needs our `void_type'.
6914 (GetMethod): Added overloaded version which takes an optional
6915 `bool report_errors' to allow lookups of optional methods.
6917 2003-05-12 Martin Baulig <martin@ximian.com>
6919 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6920 only used for locals and not for parameters.
6922 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6924 * support.cs (InternalParameters.ParameterType): Return the
6925 ExternalType of the parameter.
6927 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6930 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6932 * class.cs (MethodData.Define): Do not set the `newslot' on
6933 interface members, if they are also flagged as "override".
6935 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6936 better code for ++i and i++. This only works for static fields
6937 and local variables.
6939 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6940 want to pull the DeclSpace out of the builder_to_declspace instead
6941 of the TypeBuilder (like in TypeContainer.FindMembers).
6943 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6944 instead of LookupTypeContainer. Fixes the crash on .NET for
6945 looking up interface members.
6947 * const.cs: Create our own emit context during the Definition
6948 stage, so that constants are evaluated in the proper context, when
6949 a recursive definition happens.
6951 2003-05-11 Martin Baulig <martin@ximian.com>
6953 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6954 new block for a switch section.
6955 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6956 the adding/lookup in the switch block. Fixes #39828.
6958 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6960 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6961 functionality: I needed to convert the data after I had performed
6962 the add/sub operation into the operands type size.
6964 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6965 pass the type for the box operation, otherwise the resulting
6966 object would have been of type object.
6968 (BoxedCast): Add constructor to specify the type to box as.
6970 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6972 * iterators.cs: I was reusing the `count' variable inadvertently,
6973 take steps to not allow this to happen.
6975 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6977 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6978 by creating an array at the point where the params starts and
6979 putting all those arguments there, then adjusting the size of the
6982 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6984 * expression.cs (New.AddressOf): Implement interface
6985 IMemoryLocation. This is used when the `new' operator is used in
6986 the context of an invocation to a method on a value type.
6988 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6991 * namespace.cs: Also check the using aliases here.
6993 * driver.cs: Move the test for using validity after the types have
6994 been entered, so we do a single pass that also includes the using
6997 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6998 in the regular case. CreateSiblingForFinally is doing extra
7001 * attribute.cs (GetAttributeArgumentExpression): Store the result
7002 on an out value, and use the return value to indicate failure
7003 instead of using null (which is a valid return for Constant.GetValue).
7005 * statement.cs: Perform the analysis flow for the increment
7006 portion after the statement, because this will be the real flow of
7007 execution. Fixes #42385
7009 * codegen.cs (EmitContext.EmitArgument,
7010 EmitContext.EmitStoreArgument): New helper functions when the
7011 RemapToProxy flag is set.
7013 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7016 Add support for remapping parameters.
7018 * iterators.cs: Propagate parameter values; Store parameter
7019 values in the proxy classes.
7021 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7023 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7024 need a proxy reference; I do not know what I was thinking
7026 * cs-parser.jay (constructor_initializer): catch another error,
7027 and display nice message.
7029 (field_declaration): catch void field declaration
7030 to flag a better error.
7032 * class.cs (MemberBase.CheckBase): Report an error instead of a
7033 warning if a new protected member is declared in a struct.
7034 (Field.Define): catch the error of readonly/volatile.
7036 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7038 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7039 volatile variable is taken
7041 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7043 * statement.cs (Fixed.Resolve): Report an error if we are not in
7046 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7048 * typemanager.cs: reuse the code that handles type clashes for
7049 delegates and enumerations.
7051 * class.cs (Report28): Always report.
7053 * expression.cs (EncodeAsAttribute): Allow nulls here.
7055 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7057 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7058 the functionality for testing whether an expression is valid for
7059 an attribute here. Also handle the case of arrays of elements
7062 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7063 encoding a linear array into an array of objects that are suitable
7064 to be passed to an CustomAttributeBuilder.
7066 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7068 * ecore.cs: (FieldExpr): Handle field remapping here.
7070 * iteratators.cs: Pass the instance variable (if the method is an
7071 instance method) to the constructors, so we can access the field
7072 variables on the class.
7074 TODO: Test this with structs. I think the THIS variable on
7075 structs might have to be a pointer, and not a refenrece
7077 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7079 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7080 local variables to fields in a proxy class.
7082 * iterators.cs (PopulateProxy): Rename our internal fields to
7084 Create a <THIS> field if we are an instance method, so we can
7085 reference our parent container variables.
7086 (MapVariable): Called back from the EmitContext code to enter a
7087 new variable to field mapping into the proxy class (we just create
7091 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7092 for using the remapped locals to fields.
7094 I placed the code here, because that gives the same semantics to
7095 local variables, and only changes the Emit code.
7097 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7098 statements inside iterators.
7099 (VariableInfo): Add a FieldBuilder for the cases when we are
7100 remapping local variables to fields in a proxy class
7102 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7103 current_block != null.
7105 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7106 not cope with strings, as it has been moved to the
7107 TableSwitchEmit. Fixed bug in switch generation.
7109 * expression.cs (New.DoResolve): Provide more context for the user
7110 when reporting an error.
7112 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7115 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7116 check the permissions for it. Note than in a type-resolution
7117 context the check was already present in DeclSpace.ResolveType,
7118 but was missing from the MemberAccess.
7120 (ArrayCreation.CheckIndices): warn if the user has
7121 more nested levels of expressions, but there are no more
7122 dimensions specified. Avoids crash on bug 41906.
7124 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7126 * statement.cs (Block): replace Implicit bool, for a generic
7128 New flag: `Unchecked'. This is used during the EmitMeta phase
7129 (which is out-of-line with the regular Resolve/Emit process for a
7130 statement, as this is done ahead of time, but still gets a chance
7131 to call constant resolve).
7133 (Block.Flags): new enum for adding a new flag.
7135 (Block.EmitMeta): track the state of unchecked.
7137 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7138 to enable constant resolution to work there as well.
7140 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7142 * typemanager.cs (ienumerable_type): Also look up
7143 System.Collections.IEnumerable.
7145 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7147 TODO: Test more than one conditional per method.
7149 * class.cs (Indexer.Define): Report the location where the user is
7150 referencing the unsupported feature.
7152 (MethodData): Overload the use of `conditionals' to
7153 minimize the creation of needless ArrayLists. This saves roughly
7154 212kb on my machine.
7156 (Method): Implement the new IIteratorContainer interface.
7157 (Method.SetYields): Implement the method by setting the ModFlags
7158 to contain METHOD_YIELDS.
7160 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7161 which just got set to null.
7163 * iterators.cs: New file.
7165 (Yield, YieldBreak): New statements.
7167 * statement.cs (Return.Resolve): Flag an error if we are used in
7170 * codegen.cs (InIterator): New flag set if the code is being
7171 compiled in an iterator method.
7173 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7174 internal modifier, and we just use it to avoid adding extra
7175 fields, as this is seldom used.
7177 * cs-parser.jay: Add yield_statement (yield and yield break).
7179 * driver.cs: New flag -v2 to turn on version 2 features.
7181 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7182 hashtable when v2 is enabled.
7184 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7186 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7187 there is already a namespace defined with this name.
7189 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7190 people upgraded their corlibs.
7192 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7193 always use fully qualified types, no need to use the compiler
7196 (TypeManager.IsNamespace): Use binarysearch.
7198 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7199 AddDelegate): I did not quite use the new IsValid API properly: I
7200 have to pass the short-name and the fullname. I was passing only
7201 the basename instead of the fullname sometimes.
7203 (TypeContainer.DefineType): call NamespaceClash.
7205 * interface.cs (Interface.DefineType): use NamespaceClash before
7208 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7211 * enum.cs: (Enum.DefineType): use NamespaceClash before
7214 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7215 speed increase. First, use the negative_hits cache when we get a
7216 negative. Second, add the type with its full original name
7217 instead of the new . and + encoded name (reflection uses + to
7218 separate type from a nested type). Use LookupTypeReflection
7219 directly which bypasses the type->name hashtable (that we already
7220 know does not contain the type.
7222 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7223 location/container type.
7225 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7227 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7229 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7231 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7232 method is being referenced in the method group from a static
7233 context, and report error 120 if so.
7235 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7238 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7239 is created, we create the A namespace).
7241 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7244 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7246 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7247 invocation to ModuleBuilder.GetType with the same values will
7248 return a new type instance, so we need to cache its return
7251 * expression.cs (Binary.ResolveOperator): Only allow the compare
7252 operators on enums if they are of the same type.
7254 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7255 types of ValueType on their own case. Before we were giving them
7256 the same treatment as objects.
7258 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7259 fullname. Short name is used to compare against container name.
7260 Fullname is used to check against defined namespace names.
7262 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7263 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7265 (Method.CheckBase): Call parent.
7266 (MemberBase.CheckBase): Check for protected members on sealed
7268 (PropertyBase.CheckBase): Call parent.
7269 (Field.Define): Call parent.
7271 * report.cs: Negative error codes are now mapped to 8000 - code,
7272 so that the display is render more nicely.
7274 * typemanager.cs: Do not use try/catch, instead report a regular
7277 (GetPointerType, GetReferenceType): These methods provide
7278 mechanisms to obtain the T* and T& from a T. We had the code
7279 previously scattered around the code base, and it also used
7280 TypeManager.LookupType that would go through plenty of caches.
7281 This one goes directly to the type source.
7283 In some places we did the Type.GetType followed by
7284 ModuleBuilder.GetType, but not in others, so this unifies the
7287 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7288 statements now that we have namespace information.
7290 * typemanager.cs (IsNamespace): New method, returns whether the
7291 string presented is a namespace or not.
7293 (ComputeNamespaces): New public entry point, computes the list of
7294 available namespaces, using the GetNamespaces API call in Mono, or
7295 the slower version in MS.NET.
7297 Now before we start the semantic analysis phase, we have a
7298 complete list of namespaces including everything that the user has
7301 Deleted old code to cache namespaces in .nsc files.
7303 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7305 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7306 class/struct location definition Location for the implicit
7307 constructor location.
7309 (Operator.Define): Use the location of the operator for the
7310 implicit Method definition.
7312 (Constructor.Emit): use the constructor location for the implicit
7313 base initializer constructor.
7315 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7316 and the Expression class now contains two new methods:
7318 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7319 isolate type lookup from the rest of the resolution process.
7321 Since we use Expressions to hold type definitions due to the way
7322 we parse the input we have historically overloaded Resolve to
7323 perform the Type lookups if a special flag is passed. Now this is
7324 eliminated and two methods take their place.
7326 The differences in the two methods between xStep and xTerminal is
7327 that xStep is involved in our current lookup system that uses
7328 SimpleNames to compose a name, while xTerminal is used just to
7329 catch the case where the simplename lookup failed.
7331 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7333 * expression.cs (ResolveMemberAccess): Remove redundant code.
7334 TypeExpr expressions are always born fully resolved.
7336 * interface.cs (PopulateMethod): Do not lookup the types twice.
7337 We were doing it once during SemanticAnalysis and once during
7340 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7341 in local variable type definitions, were being returned as a
7342 SimpleName (we decomposed everything into a string), that is
7343 because primary_expression was being used instead of a type in the
7344 grammar (reduce/reduce conflicts).
7346 The part that was wrong is that we converted the expression into a
7347 string (an oversimplification in one hand, compounded with primary
7348 expressions doing string concatenation).
7354 Would return "A.B.C[]" as a SimpleName. This stopped things like
7355 using clauses from working on this particular context. And a type
7356 was being matched directly against "A.B.C[]".
7358 We now use the correct approach, and allow for ComposedCast to be
7359 part of the unary expression. So the "A.B.C []" become a composed
7360 cast of "A.B.C" (as a nested group of MemberAccess with a
7361 SimpleName at the end) plus the rank composition "[]".
7365 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7367 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7368 for the access level checking.
7370 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7371 `TypeContainer container', because I kept getting confused when I
7372 was debugging this code.
7374 * expression.cs (Indexers): Instead of tracking getters/setters,
7375 we now track them in parallel. We create one arraylist less, but
7376 most importantly it is possible now for the LValue code to find a
7377 matching get for a set.
7379 (IndexerAccess.DoResolveLValue): Update the code.
7380 GetIndexersForType has been modified already to extract all the
7381 indexers from a type. The code assumed it did not.
7383 Also make the code set the correct return type for the indexer.
7384 This was fixed a long time ago for properties, but was missing for
7385 indexers. It used to be void_type.
7387 (Binary.Emit): Test first for doubles instead of
7388 floats, as they are more common.
7390 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7391 when dealing with floats and the <=, >= operators. This fixes bug
7394 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7395 to load the array value by emitting a load on the foreach variable
7396 type. This was incorrect.
7398 We now emit the code to load an element using the the array
7399 variable type, and then we emit the conversion operator.
7403 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7405 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7407 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7409 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7410 test for protection before we test for signatures.
7412 (MethodSignature.ToString): implement.
7414 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7415 to the case where we reduced into a LongConstant.
7417 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7418 depend on whether the information is acurrate, because the
7419 Microsoft runtime will always claim that the array type is public,
7420 regardless of the real state.
7422 If the type is a pointer, another problem happens: the type is
7423 reported as non-public in Microsoft.
7425 In both cases we have to call CheckAccessLevel recursively with
7426 the underlying type as the argument to be tested.
7428 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7430 * assign.cs (Assign.Emit): If we are dealing with a compound
7431 assignment expression, we should use the code path that stores the
7432 intermediate result in a temporary value. This fixes #40903.
7434 *expression.cs (Indirection.ToString): Provide ToString method for
7437 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7439 * class.cs: Null out fields holding references to Block objects so
7440 they can be garbage collected.
7442 * expression.cs (OverloadResolve): Remove unused local.
7444 2003-04-07 Martin Baulig <martin@ximian.com>
7446 * codegen.cs (EmitContext.CurrentFile): New public field.
7447 (EmitContext.Mark): Use the CurrentFile to check whether the
7448 location is in the correct file.
7449 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7451 2003-04-07 Martin Baulig <martin@ximian.com>
7453 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7455 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7456 location. [FIXME: The location argument which gets passed to this
7457 method is sometimes wrong!]
7459 2003-04-07 Nick Drochak <ndrochak@gol.com>
7461 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7463 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7465 * expression.cs (Indirection.EmitAssign): We were using the
7466 temporary, but returning immediately instead of continuing the
7469 2003-04-06 Martin Baulig <martin@ximian.com>
7471 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7472 if it's a nested child, but also deriving from the outer class.
7475 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7476 nested child, but also deriving from the outer class. See
7478 (FilterWithClosure): We may access private members of the outer
7479 class if we're a nested child and deriving from the outer class.
7480 (RealMemberLookup): Only set `closure_private_ok' if the
7481 `original_bf' contained BindingFlags.NonPublic.
7483 2003-04-05 Martin Baulig <martin@ximian.com>
7485 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7487 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7489 * class.cs (Event.Define): Do not allow abstract events to have
7492 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7494 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7495 block in event declarations.
7497 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7498 value type, get its address.
7500 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7501 leaving a class on the stack instead of a boolean value (int
7502 0/1). Change the code so we compare against null, and then the
7503 result against zero.
7505 * class.cs (TypeContainer.GetClassBases): We were checking for the
7506 parent class being sealed too late.
7508 * expression.cs (Binary.Emit): For <= and >= when dealing with
7509 floating point values, use cgt.un and clt.un instead of cgt and
7512 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7514 * statement.cs: Apply the same optimization as MS: skip the
7515 GetEnumerator returning an IEnumerator, and use the one returning a
7516 CharEnumerator instead. This allows us to avoid the try-finally block
7519 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7521 * cs-parser.jay: Attributes cannot be applied to
7522 namespaces. Fixes #40473
7524 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7527 (Add*): check if the name is valid using the full name for constants,
7528 fields, properties and events.
7530 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7532 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7533 char constants to be part of the enumeration.
7535 * expression.cs (Conditional.DoResolve): Add support for operator
7536 true. Implements the missing functionality from 14.12
7538 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7539 operator true/false as required by the spec.
7541 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7542 implicit conversion to boolean.
7544 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7545 also one where the type implements `operator true'.
7547 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7548 get an expression that will invoke operator true based on an
7551 (GetConversionOperators): Removed the hack that called op_True
7554 (Expression.ResolveBoolean): Move this from Statement.
7556 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7558 * ecore.cs (FieldExpr): do not allow initialization of initonly
7559 fields on derived classes
7561 2003-03-13 Martin Baulig <martin@ximian.com>
7563 * statement.cs (Block.Emit): Call ig.BeginScope() and
7564 ig.EndScope() when compiling with debugging info; call
7565 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7567 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7569 * expression.cs (Indexers): Do not construct immediately, allow
7570 for new members to be appended as we go. Fixes 38143
7572 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7574 * expression.cs: save/restore context when resolving an unchecked
7577 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7579 * cfold.cs: Catch division by zero in modulus operator during
7582 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7584 * interface.cs (Interface.DefineMembers): Avoid defining members
7587 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7589 * driver.cs: handle the +/- options for -noconfig
7591 * statement.cs (Unckeched.Resolve): Also track the state of
7592 unchecked in the Resolve phase.
7594 2003-02-27 Martin Baulig <martin@ximian.com>
7596 * ecore.cs (Expression.MemberLookup): Don't create a
7597 MethodGroupExpr for something which is not a method. Fixes #38291.
7599 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7601 * class.cs (MemberBase.CheckParameters): Also check that the type
7602 is unmanaged if it is a pointer.
7604 * expression.cs (SizeOf.Resolve): Add location information.
7606 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7607 a managed type is declared.
7609 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7610 parameter modifiers as well. Fixes bug 38606
7612 * class.cs: Very sad. Am backing out the speed up changes
7613 introduced by the ArrayList -> Array in the TypeContainer, as they
7614 were not actually that much faster, and introduced a bug (no error
7615 reports on duplicated methods).
7617 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7618 source first, this will guarantee that we have a valid expression
7619 before calling in lower levels functions that will require a
7620 resolved object. Then use this original_source in the
7621 target.ResolveLValue instead of the original source that was
7624 Another change. Use target.Resolve instead of LValueResolve.
7625 Although we are resolving for LValues, we will let the Assign code
7626 take care of that (it will be called again from Resolve). This
7627 basically allows code like this:
7629 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7630 class Y { void A (X x) { x [0] += o; }
7632 The problem was that the indexer was trying to resolve for
7633 set_Item (idx, object o) and never finding one. The real set_Item
7634 was set_Item (idx, X). By delaying the process we get the right
7639 2003-02-23 Martin Baulig <martin@ximian.com>
7641 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7642 while calling DoEmit ().
7644 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7645 source files; if you use the #line directive inside a method, the
7646 compiler stops emitting line numbers for the debugger until it
7647 reaches the end of the method or another #line directive which
7648 restores the original file.
7650 2003-02-23 Martin Baulig <martin@ximian.com>
7652 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7654 2003-02-23 Martin Baulig <martin@ximian.com>
7656 * statement.cs (Block.AddChildVariableNames): We need to call this
7657 recursively, not just for our immediate children.
7659 2003-02-23 Martin Baulig <martin@ximian.com>
7661 * class.cs (Event.Define): Always make the field private, like csc does.
7663 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7664 actually work, fixes bug #37521.
7666 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7668 * delegate.cs: When creating the various temporary "Parameters"
7669 classes, make sure that we call the ComputeAndDefineParameterTypes
7670 on those new parameters (just like we do with the formal ones), to
7671 allow them to be resolved in the context of the DeclSpace.
7673 This fixes the bug that Dick observed in Bugzilla #38530.
7675 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7677 * expression.cs (ResolveMemberAccess): When resolving a constant,
7678 do not attempt to pull a constant if the value was not able to
7679 generate a valid constant.
7681 * const.cs (LookupConstantValue): Do not report more errors than required.
7683 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7685 * expression.cs: fixes bug #38328.
7687 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7689 * class.cs: Changed all the various members that can be part of a
7690 class from being an ArrayList to be an Array of the right type.
7691 During the DefineType type_list, interface_list, delegate_list and
7692 enum_list are turned into types, interfaces, delegates and enums
7695 And during the member population, indexer_list, event_list,
7696 constant_list, field_list, instance_constructor_list, method_list,
7697 operator_list and property_list are turned into their real arrays.
7699 Although we could probably perform this operation earlier, for
7700 good error reporting we need to keep the lists and remove the
7701 lists for longer than required.
7703 This optimization was triggered by Paolo profiling the compiler
7704 speed on the output of `gen-sample-program.pl' perl script.
7706 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7707 not crash in methods like MemberLookupFailed that use this field.
7709 This problem arises when the compiler fails to resolve a type
7710 during interface type definition for example.
7712 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7714 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7715 inherit from System.Object, so we have to stop at null, not only
7716 when reaching System.Object.
7718 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7720 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7721 DeclaredOnly because the parent indexer might have had a different
7722 name, but did not loop until the top of the hierarchy was reached.
7724 The problem this one fixes is 35492: when a class implemented an
7725 indexer from an interface, we were getting the interface method
7726 (which was abstract) and we were flagging an error (can not invoke
7729 This also keeps bug 33089 functioning, and test-148 functioning.
7731 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7732 out if a method is special is to see if it is declared in a
7733 property or event, or whether it is one of the predefined operator
7734 names. This should fix correctly #36804.
7736 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7738 The goal here is to remove the dependency on EmptyCast.Peel ().
7739 Killing it completely.
7741 The problem is that currently in a number of places where
7742 constants are expected, we have to "probe" for an EmptyCast, and
7743 Peel, which is not the correct thing to do, as this will be
7744 repetitive and will likely lead to errors.
7746 The idea is to remove any EmptyCasts that are used in casts that
7747 can be reduced to constants, so we only have to cope with
7750 This bug hunt was triggered by Bug 37363 and the desire to remove
7751 the duplicate pattern where we were "peeling" emptycasts to check
7752 whether they were constants. Now constants will always be
7755 * ecore.cs: Use an enumconstant here instead of wrapping with
7758 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7759 throwing me off. By handling this we can get rid of a few hacks.
7761 * statement.cs (Switch): Removed Peel() code.
7763 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7765 * class.cs: Location information for error 508
7767 * expression.cs (New.DoResolve): Add a guard against double
7768 resolution of an expression.
7770 The New DoResolve might be called twice when initializing field
7771 expressions (see EmitFieldInitializers, the call to
7772 GetInitializerExpression will perform a resolve on the expression,
7773 and later the assign will trigger another resolution
7775 This leads to bugs (#37014)
7777 * delegate.cs: The signature for EndInvoke should contain any ref
7778 or out parameters as well. We were not doing this in the past.
7780 * class.cs (Field.Define): Do not overwrite the type definition
7781 inside the `volatile' group. Turns out that volatile enumerations
7782 were changing the type here to perform a validity test, which
7785 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7787 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7788 and structs, we do not want to load the instance variable
7790 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7791 enum_type has to be handled like an object reference (implicit
7792 conversions exists from this to object), but the regular IsClass
7793 and IsValueType tests will never return true for this one.
7795 Also we use TypeManager.IsValueType instead of type.IsValueType,
7796 just for consistency with the rest of the code (this is only
7797 needed if we ever use the construct exposed by test-180.cs inside
7798 corlib, which we dont today).
7800 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7802 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7805 2003-02-09 Martin Baulig <martin@ximian.com>
7807 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7808 (Namespace.DefineNamespaces): New static public method; this is
7809 called when we're compiling with debugging to add all namespaces
7812 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7813 pass it to the Namespace's .ctor.
7815 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7816 and MethodBase arguments; pass the namespace ID to the symwriter;
7817 pass the MethodBase instead of the token to the symwriter.
7818 (SymbolWriter.DefineNamespace): New method to add a namespace to
7821 2003-02-09 Martin Baulig <martin@ximian.com>
7823 * symbolwriter.cs: New file. This is a wrapper around
7824 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7825 methods here in near future.
7827 2003-02-09 Martin Baulig <martin@ximian.com>
7829 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7830 ILGenerator.MarkSequencePoint() which are actually used by the
7833 2003-02-09 Martin Baulig <martin@ximian.com>
7835 * location.cs (SourceFile): New public sealed class. This
7836 contains the name and an index which is used in the location's token.
7837 (Location): Reserve an appropriate number of bits in the token for
7838 the source file instead of walking over that list, this gives us a
7839 really huge performance improvement when compiling with debugging.
7841 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7842 `SourceFile' argument instead of a string.
7843 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7844 but don't parse/tokenize here, we need to generate the list of all
7845 source files before we do that.
7846 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7849 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7850 instead of a string.
7852 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7855 2003-02-09 Martin Baulig <martin@ximian.com>
7857 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7858 filename on `#line default'.
7860 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7862 * statement.cs: don't clear the pinned var when the fixed statement
7863 returns from the method (fixes bug#37752).
7865 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7867 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7870 2003-02-07 Martin Baulig <martin@ximian.com>
7872 * driver.cs: Removed the `--debug-args' command line argument.
7874 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7875 automatically by the AsssemblyBuilder.
7876 (CodeGen.InitializeSymbolWriter): We don't need to call any
7877 initialization function on the symbol writer anymore. This method
7878 doesn't take any arguments.
7880 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7882 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7883 from referenced assemblies as well.
7885 2003-02-02 Martin Baulig <martin@ximian.com>
7887 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7889 2003-02-02 Martin Baulig <martin@ximian.com>
7891 * class.cs (Constructor.Emit): Open the symbol writer before
7892 emitting the constructor initializer.
7893 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7894 single-stepping through constructor initializers.
7896 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7898 * class.cs: Handle error 549: do not allow virtual methods in
7901 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7903 * decl.cs: Check access levels when resolving types
7905 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7907 * statement.cs: Add parameters and locals set in catch blocks that might
7908 return to set vector
7910 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7912 * class.cs (Operator): Set the SpecialName flags for operators.
7914 * expression.cs (Invocation.DoResolve): Only block calls to
7915 accessors and operators on SpecialName methods.
7917 (Cast.TryReduce): Handle conversions from char constants.
7920 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7922 * statement.cs: small memory and time optimization in FlowBranching.
7924 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7926 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7927 problem that the last fix but in the other sid (Set).
7929 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7930 access when there is no indexer in the hierarchy.
7932 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7934 * class.cs: Combine some if statements.
7936 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7938 * driver.cs: fixed bug #37187.
7940 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7942 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7943 any indexer, it's needed to build a list with all the indexers in the
7944 hierarchy (AllGetters), else we have problems. Fixes #35653.
7946 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7948 * class.cs (MethodData.Define): It is wrong for an interface
7949 implementation to be static in both cases: explicit and implicit.
7950 We were only handling this in one case.
7952 Improve the if situation there to not have negations.
7954 * class.cs (Field.Define): Turns out that we do not need to check
7955 the unsafe bit on field definition, only on usage. Remove the test.
7957 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7959 * driver.cs: use assembly.Location instead of Codebase (the latest
7960 patch made mcs fail when using MS assemblies).
7962 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7964 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7965 get the path to *corlib.dll.
7967 2003-01-21 Nick Drochak <ndrochak@gol.com>
7971 * typemanager.cs: Remove compiler warnings
7973 2003-01-20 Duncan Mak <duncan@ximian.com>
7975 * AssemblyInfo.cs: Bump the version number to 0.19.
7977 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7979 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7981 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7983 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7985 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7987 * cs-parser.jay: Small fix: we were not comparing the constructor
7988 name correctly. Thanks to Zoltan for the initial pointer.
7990 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7992 * cs-tokenizer.cs: Set file name when specified with #line
7994 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7996 * cs-parser.jay: Only perform the constructor checks here if we
7997 are named like the class; This will help provider a better
7998 error. The constructor path is taken when a type definition is
7999 not found, but most likely the user forgot to add the type, so
8000 report that rather than the constructor error.
8002 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8004 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8007 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8009 * cs-parser.jay: Add cleanup call.
8011 2003-01-13 Duncan Mak <duncan@ximian.com>
8013 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8014 consistent with other methods.
8016 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8018 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8020 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8022 * attribute.cs: only set GuidAttr to true when we have a
8025 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8029 * typemanager.cs: fixes to allow mcs compile corlib with the new
8030 Type.IsSubclassOf fix.
8032 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8034 * expression.cs (LocalVariableReference.DoResolve): Classify a
8035 constant as a value, not as a variable. Also, set the type for
8038 * cs-parser.jay (fixed_statement): take a type instead of a
8039 pointer_type, so we can produce a better error message later.
8041 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8044 (For.DoEmit): Make inifinite loops have a
8045 non-conditional branch back.
8047 (Fixed.DoEmit): First populate the pinned variables, then emit the
8048 statement, then clear the variables. Before I was emitting the
8049 code once for each fixed piece.
8052 2003-01-08 Martin Baulig <martin@ximian.com>
8054 * statement.cs (FlowBranching.MergeChild): A break in a
8055 SWITCH_SECTION does not leave a loop. Fixes #36155.
8057 2003-01-08 Martin Baulig <martin@ximian.com>
8059 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8060 lives in the same number space than `param_map'. Fixes #36154.
8062 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8064 * cs-parser.jay (constructor_declaration): Set the
8065 Constructor.ModFlags before probing for it. This makes the
8066 compiler report 514, 515 and 132 (the code was there, but got
8069 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8070 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8071 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8073 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8075 * enum.cs: create the enum static fields using the enum type.
8077 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8079 * class.cs: don't try to create the ParamBuilder for the return
8080 type if it's not needed (and handle it breaking for the ms runtime
8083 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8085 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8087 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8089 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8090 the command. This showed up while compiling the JANET source
8091 code, which used \r as its only newline separator.
8093 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8095 * class.cs (Method.Define): If we are an operator (because it
8096 reuses our code), then set the SpecialName and HideBySig. #36128
8098 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8100 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8101 exception, report error 120 `object reference required'.
8103 * driver.cs: Add --pause option, used during to measure the size
8104 of the process as it goes with --timestamp.
8106 * expression.cs (Invocation.DoResolve): Do not allow methods with
8107 SpecialName to be invoked.
8109 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8111 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8112 number before adding it.
8114 2002-12-21 Ravi Pratap <ravi@ximian.com>
8116 * ecore.cs (StandardImplicitConversion): When in an unsafe
8117 context, we allow conversion between void * to any other pointer
8118 type. This fixes bug #35973.
8120 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8122 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8123 is not thrown when extensionless outputs are used
8125 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8127 * rootcontext.cs: fixed compilation of corlib.
8129 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8131 * attribute.cs (Attributes.Contains): Add new method.
8133 * class.cs (MethodCore.LabelParameters): if the parameter is an
8134 `out' parameter, check that no attribute `[In]' has been passed.
8136 * enum.cs: Handle the `value__' name in an enumeration.
8138 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8140 * decl.cs: Added special case to allow overrides on "protected
8143 2002-12-18 Ravi Pratap <ravi@ximian.com>
8145 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8146 since it makes much more sense.
8148 (Attributes.ctor): Don't require a Location parameter.
8150 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8152 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8153 since we already have that information per attribute.
8155 * everywhere : make appropriate changes.
8157 * class.cs (LabelParameters): Write the code which actually
8158 applies attributes to the return type. We can't do this on the MS
8159 .NET runtime so we flag a warning in the case an exception is
8162 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8164 * const.cs: Handle implicit null conversions here too.
8166 2002-12-17 Ravi Pratap <ravi@ximian.com>
8168 * class.cs (MethodCore.LabelParameters): Remove the extra
8169 Type [] parameter since it is completely unnecessary. Instead
8170 pass in the method's attributes so that we can extract
8171 the "return" attribute.
8173 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8175 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8176 of ignoring it and letting the compile continue.
8178 * typemanager.cs (ChangeType): use an extra argument to return an
8179 error condition instead of throwing an exception.
8181 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8183 * expression.cs (Unary.TryReduce): mimic the code for the regular
8184 code path. Perform an implicit cast in the cases where we can
8185 implicitly convert to one of the integral types, and then reduce
8186 based on that constant. This fixes bug #35483.
8188 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8190 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8192 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8194 * namespace.cs: fixed bug #35489.
8196 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8198 * class.cs: Remove some dead code.
8200 * cs-parser.jay: Estimate the number of methods needed
8201 (RootContext.MethodCount);
8203 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8204 numbers instead of StringBuilders.
8206 * support.cs (PtrHashtable): Add constructor with initial size;
8207 We can now reduce reallocations of the method table.
8209 2002-12-10 Ravi Pratap <ravi@ximian.com>
8211 * attribute.cs (ApplyAttributes): Keep track of the emitted
8212 attributes on a per-target basis. This fixes bug #35413.
8214 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8216 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8217 default to the Windows 1252 encoding.
8219 (UnixParseOption): Support version, thanks to Alp for the missing
8222 * AssemblyInfo.cs: Add nice assembly information.
8224 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8227 * cs-parser.jay: Allow a trailing comma before the close bracked
8228 in the attribute_section production.
8230 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8231 address of the instance was being taken, I will take this out,
8232 because we take the address of the object immediately here.
8234 2002-12-09 Ravi Pratap <ravi@ximian.com>
8236 * typemanager.cs (AreMultipleAllowed): Take care of the most
8237 obvious case where attribute type is not in the current assembly -
8240 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8242 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8243 definitions, instead of doing that afterwards.
8245 Also we use a nice little hack, depending on the constructor, we
8246 know if we are a "composed" name or a simple name. Hence, we
8247 avoid the IndexOf test, and we avoid
8249 * codegen.cs: Add code to assist in a bug reporter to track down
8250 the source of a compiler crash.
8252 2002-12-07 Ravi Pratap <ravi@ximian.com>
8254 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8255 types have been emitted for a given element and flag an error
8256 if something which does not have AllowMultiple set is used more
8259 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8260 attribute types and their corresponding AllowMultiple properties
8262 (AreMultipleAllowed): Check the property for a given type.
8264 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8265 property in the case we have a TypeContainer.
8267 (Attributes.AddAttribute): Detect duplicates and just skip on
8268 adding them. This trivial fix catches a pretty gross error in our
8269 attribute emission - global attributes were being emitted twice!
8271 Bugzilla bug #33187 is now fixed.
8273 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8275 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8278 * expression.cs (Binary.ResolveOperator): I can only use the
8279 Concat (string, string, string) and Concat (string, string,
8280 string, string) if the child is actually a concatenation of
8283 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8285 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8286 context where we need a 2-character lookahead.
8288 * pending.cs (PendingImplementation): Rework so we can keep track
8289 of interface types all the time, and flag those which were
8290 implemented by parents as optional.
8292 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8294 * expression.cs (Binary.ResolveOperator): Use
8295 String.Concat(string,string,string) or
8296 String.Concat(string,string,string,string) when possible.
8298 * typemanager: More helper methods.
8301 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8303 * pending.cs: remove the bogus return from GetMissingInterfaces()
8304 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8306 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8308 * namespace.cs: avoid duplicated 'using xxx' being added to
8309 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8310 when we get more than one 'using' statement for the same namespace.
8311 Report a CS0105 warning for it.
8313 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8315 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8316 of calling getChar/putback, uses internal knowledge of it.
8318 (xtoken): Reorder tokenizer so most common patterns are checked
8319 first. This reduces the compilation time in another 5% (from 8.11s
8320 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8322 The parsing time is 22% of the compilation in mcs, and from that
8323 64% is spent on the tokenization process.
8325 I tried using a binary search for keywords, but this is slower
8326 than the hashtable. Another option would be to do a couple of
8329 * Not use a StringBuilder, instead use an array of chars,
8330 with a set value. Notice that this way we could catch
8331 the 645 error without having to do it *afterwards*.
8333 * We could write a hand-parser to avoid the hashtable
8334 compares altogether.
8336 The identifier consumption process takes 37% of the tokenization
8337 time. Another 15% is spent on is_number. 56% of the time spent
8338 on is_number is spent on Int64.Parse:
8340 * We could probably choose based on the string length to
8341 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8344 Another 3% is spend on wrapping `xtoken' in the `token' function.
8346 Handle 0xa0 as whitespace (#34752)
8348 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8350 * typemanager.cs (IsCLRType): New routine to tell whether a type
8351 is one of the builtin types.
8353 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8354 typecode in more places instead of doing pointer comparissions.
8355 We could leverage some knowledge about the way the typecodes are
8358 New code to cache namespaces in assemblies, it is currently not
8359 invoked, to be used soon.
8361 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8363 * expression.cs (Binary.ResolveOperator): specially handle
8364 strings, and do not perform user-defined operator overloading for
8367 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8369 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8370 internalcall as it is a pretty simple operation; Avoid whenever
8371 possible to call Char.IsLetter.
8373 (consume_identifier): Cut by half the number of
8374 hashtable calls by merging the is_keyword and GetKeyword behavior.
8376 Do not short-circuit, because if we do, we
8377 report errors (ie, #if false && true would produce an invalid
8381 2002-11-24 Martin Baulig <martin@ximian.com>
8383 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8384 check constant ranges and report a CS0221. Fixes #33186.
8386 2002-11-24 Martin Baulig <martin@ximian.com>
8388 * cs-parser.jay: Make this work for uninitialized variable
8389 declarations in the `for' initializer. Fixes #32416.
8391 2002-11-24 Martin Baulig <martin@ximian.com>
8393 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8394 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8396 2002-11-24 Martin Baulig <martin@ximian.com>
8398 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8399 argument; if true, we also check for user-defined conversions.
8400 This is only needed if both arguments are of a user-defined type.
8401 Fixes #30443, added test-175.cs.
8402 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8404 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8406 2002-11-24 Martin Baulig <martin@ximian.com>
8408 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8409 function to get the store opcode.
8410 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8411 only emit the Ldelema if the store opcode is Stobj. You must run
8412 both test-34 and test-167 to test this. Fixes #34529.
8414 2002-11-23 Martin Baulig <martin@ximian.com>
8416 * ecore.cs (Expression.MemberLookup): Added additional
8417 `qualifier_type' argument which is used when we're being called
8418 from MemberAccess.DoResolve() and null if we're called from a
8420 (Expression.MemberLookupFailed): New method to report errors; this
8421 does the CS1540 check and reports the correct error message.
8423 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8424 argument for the CS1540 check and redone the way how we're dealing
8425 with private members. See the comment in the source code for details.
8426 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8427 `closure_start_type' to `closure_qualifier_type' and check whether
8428 it's not null. It was not this filter being broken, it was just
8429 being called with the wrong arguments.
8431 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8432 and pass it the correct `qualifier_type'; this also does the error
8435 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8437 * expression.cs (Invocation.EmitParams): If the we are dealing
8438 with a non-built-in value type, load its address as well.
8440 (ArrayCreation): Use a a pretty constant instead
8441 of the hardcoded value 2. Use 6 instead of 2 for the number of
8442 static initializers.
8444 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8445 because they are not really value types, just glorified integers.
8447 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8449 * ecore.cs: Remove redundant code for enumerations, make them use
8450 the same code path as everything else, fixes the casting issue
8451 with enumerations in Windows.Forms.
8453 * attribute.cs: Do only cast to string if it is a string, the
8454 validation happens later.
8456 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8457 people upgrade their corlibs.
8459 * ecore.cs: Oops, enumerations were not following the entire code path
8461 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8463 * typemanager.cs (FilterWithClosure): Commented out the test for
8464 1540 in typemanager.cs, as it has problems when accessing
8465 protected methods from a parent class (see test-174.cs).
8467 * attribute.cs (Attribute.ValidateGuid): new method.
8468 (Attribute.Resolve): Use above.
8470 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8472 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8474 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8475 handling for enumerations, as we only needed the TypeContainer
8476 functionality to begin with (this is required for the fix below to
8477 work for enums that reference constants in a container class for
8480 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8482 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8483 a valid TypeBuilder to perform lookups on.o
8485 * class.cs (InheritableMemberSignatureCompare): Use true in the
8486 call to GetGetMethod and GetSetMethod, because we are comparing
8487 the signature, and we need to get the methods *even* if they are
8490 (PropertyBase.CheckBase): ditto.
8492 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8493 GotoCase.Resolve): Use Peel on EmpytCasts.
8495 * ecore.cs (EmptyCast): drop child, add Peel method.
8497 2002-11-17 Martin Baulig <martin@ximian.com>
8499 * ecore.cs (EmptyCast.Child): New public property.
8501 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8502 label resolved to an EmptyCast. Fixes #34162.
8503 (GotoCase.Resolve): Likewise.
8504 (Block.EmitMeta): Likewise.
8506 2002-11-17 Martin Baulig <martin@ximian.com>
8508 * expression.cs (Invocation.BetterConversion): Prefer int over
8509 uint; short over ushort; long over ulong for integer literals.
8510 Use ImplicitConversionExists instead of StandardConversionExists
8511 since we also need to check for user-defined implicit conversions.
8512 Fixes #34165. Added test-173.cs.
8514 2002-11-16 Martin Baulig <martin@ximian.com>
8516 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8517 with the `true' and `false' literals. Fixes #33151.
8519 2002-11-16 Martin Baulig <martin@ximian.com>
8521 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8522 October 22nd; don't do the cs1540 check for static members.
8524 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8525 now using our own filter here and doing the cs1540 check again.
8527 2002-11-16 Martin Baulig <martin@ximian.com>
8529 * support.cs (InternalParameters): Don't crash if we don't have
8530 any fixed parameters. Fixes #33532.
8532 2002-11-16 Martin Baulig <martin@ximian.com>
8534 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8535 when looking up static methods to make this work on Windows.
8538 2002-11-16 Martin Baulig <martin@ximian.com>
8540 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8541 a setter rather than using PropertyInfo.CanWrite.
8543 2002-11-15 Nick Drochak <ndrochak@gol.com>
8545 * class.cs: Allow acces to block member by subclasses. Fixes build
8548 2002-11-14 Martin Baulig <martin@ximian.com>
8550 * class.cs (Constructor.Emit): Added the extern/block check.
8553 2002-11-14 Martin Baulig <martin@ximian.com>
8555 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8556 iteration while looking for indexers, this is needed because the
8557 indexer may have a different name in our base classes. Fixed the
8558 error reporting (no indexers at all, not get accessor, no
8559 overloaded match). Fixes bug #33089.
8560 (IndexerAccess.DoResolveLValue): Likewise.
8562 2002-11-14 Martin Baulig <martin@ximian.com>
8564 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8565 indexers. Fixes the first part of bug #33089.
8566 (MethodSignature.InheritableMemberSignatureCompare): Added support
8569 2002-11-13 Ravi Pratap <ravi@ximian.com>
8571 * attribute.cs (Attribute.Resolve): Catch the
8572 NullReferenceException and report it since it isn't supposed to
8575 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8577 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8578 LogicalOr and LogicalAnd that can benefit from recursively
8579 handling EmitBranchable. The code now should be nice for Paolo.
8581 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8583 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8584 the Type lookups, as we perform quite a number of lookups on
8585 non-Types. This can be removed once we can deterministically tell
8586 whether we have a type or a namespace in advance.
8588 But this might require special hacks from our corlib.
8592 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8593 and double which avoids a conversion from an integer to a double.
8595 * expression.cs: tiny optimization, avoid calling IsConstant,
8596 because it effectively performs the lookup twice.
8598 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8600 But a bogus return here to keep the semantics of the old code
8601 until the Mono runtime is fixed.
8603 * pending.cs (GetMissingInterfaces): New method used to remove all
8604 the interfaces that are already implemented by our parent
8605 classes from the list of pending methods.
8607 * interface.cs: Add checks for calls after ResolveTypeExpr.
8609 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8611 * class.cs (Class.Emit): Report warning 67: event not used if the
8612 warning level is beyond 3.
8614 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8615 being a NullLiteral.
8617 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8620 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8621 path that might fail if a type can not be resolved.
8623 * expression.cs (Binary.Emit): Emit unsigned versions of the
8626 * driver.cs: use error 5.
8628 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8630 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8632 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8634 * cs-parser.jay (switch_section): A beautiful patch from Martin
8635 Baulig that fixed 33094.
8637 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8639 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8640 Check whether the base is abstract and report an error if so.
8642 * expression.cs (IndexerAccess.DoResolveLValue,
8643 IndexerAccess.DoResolve): ditto.
8645 (Invocation.DoResolve): ditto.
8647 (Invocation.FullMethodDesc): Improve the report string.
8649 * statement.cs (Block): Eliminate IsVariableDefined as it is
8650 basically just a wrapper for GetVariableInfo.
8652 * ecore.cs (SimpleName): Use new
8654 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8655 type, as we return the actual parameter ref/unref state on a
8658 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8660 * support.cs: Return proper flags REF/OUT fixing the previous
8663 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8664 not used to mean `ref' but `ref or out' in ParameterReference
8666 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8667 full type signature instead of calling TypeManger.CSharpName
8670 * support.cs (InternalParameters.ParameterDesc): Do not compare
8671 directly to the modflags, because REF/OUT will actually be bitsets
8674 * delegate.cs (VerifyMethod): Check also the modifiers.
8676 * cs-tokenizer.cs: Fix bug where floating point values with an
8677 exponent where a sign was missing was ignored.
8679 * driver.cs: Allow multiple assemblies to be specified in a single
8682 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8684 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8685 because identifiers after a parenthesis would end up in this kind
8686 of production, and we needed to desamiguate it for having casts
8689 (UserDefinedType *) xxx
8691 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8693 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8694 we should set on the Bindingflags.NonPublic, but not turn on
8695 private_ok. private_ok controls whether a Private member is
8696 returned (this is chekced on the filter routine), while the
8697 BindingFlags.NonPublic just controls whether private/protected
8698 will be allowed. This fixes the problem part of the problem of
8699 private properties being allowed to be used in derived classes.
8701 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8702 so we can call the children DoResolveLValue method (this will
8703 properly signal errors on lvalue assignments to base properties)
8705 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8706 getter are null, and we have a property info, we know that this
8707 happened because the lookup failed, so we report an error 122 for
8708 protection level violation.
8710 We also silently return if setter and getter are null in the
8711 resolve functions, this condition only happens if we have flagged
8712 the error before. This is the other half of the problem.
8714 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8715 not have accessibility information, that is why we were returning
8716 true in the filter function in typemanager.cs.
8718 To properly report 122 (property is inaccessible because of its
8719 protection level) correctly, we report this error in ResolveAccess
8720 by failing if both the setter and the getter are lacking (ie, the
8723 DoResolve and DoLResolve have been modified to check for both
8724 setter/getter being null and returning silently, the reason being
8725 that I did not want to put the knowledge about this error in upper
8728 int old = Report.Errors;
8729 x = new PropertyExpr (...);
8730 if (old != Report.Errors)
8735 So the property expr is returned, but it is invalid, so the error
8736 will be flagged during the resolve process.
8738 * class.cs: Remove InheritablePropertySignatureCompare from the
8739 class, as we no longer depend on the property signature to compute
8740 whether it is possible to implement a method or not.
8742 The reason is that calling PropertyInfo.GetGetMethod will return
8743 null (in .NET, in Mono it works, and we should change this), in
8744 cases where the Get Method does not exist in that particular
8749 class X { public virtual int A { get { return 1; } } }
8751 class Z : Y { public override int A { get { return 2; } } }
8753 Would fail in Z because the parent (Y) would not have the property
8754 defined. So we avoid this completely now (because the alternative
8755 fix was ugly and slow), and we now depend exclusively on the
8758 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8759 reference method, instead of using the property.
8761 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8762 routines are gone now.
8764 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8765 names, they were incorrectly named.
8767 * cs-tokenizer.cs: Return are more gentle token on failure.
8769 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8770 had an out-of-sync index variable, which caused it to remove from
8771 the list of pending methods the wrong method sometimes.
8773 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8775 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8776 CanWrite, because those refer to this particular instance of the
8777 property, and do not take into account the fact that we can
8778 override single members of a property.
8780 Constructor requires an EmitContext. The resolution process does
8781 not happen here, but we need to compute the accessors before,
8782 because the resolution does not always happen for properties.
8784 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8785 subclass, before we did not update this flag, but we did update
8788 (GetAccessors): Drop this routine, as it did not work in the
8789 presence of partially overwritten set/get methods.
8791 Notice that this broke the cs1540 detection, but that will require
8794 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8798 * driver.cs: issue a warning instead of an error if we don't support
8799 debugging for the platform. Also ignore a couple of errors that may
8800 arise when trying to write the symbols. Undo my previous patch.
8802 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8804 * driver.cs: ignore /debug switch except for Unix platforms.
8806 2002-10-23 Nick Drochak <ndrochak@gol.com>
8808 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8810 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8812 * driver.cs: Do not make mcs-debug conditional, so we do not break
8815 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8816 review this patch. But basically after all the children variables
8817 have been merged, the value of "Breaks" was not being set to
8818 new_breaks for Switch blocks. I think that it should be set after
8819 it has executed. Currently I set this to the value of new_breaks,
8820 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8821 conservative, but I do not understand this code very well.
8823 I did not break anything in the build, so that is good ;-)
8825 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8827 2002-10-20 Mark Crichton <crichton@gimp.org>
8829 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8831 2002-10-20 Nick Drochak <ndrochak@gol.com>
8833 * cfold.cs: Fixed compile blocker.
8835 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8837 * driver.cs: I was chekcing the key, not the file.
8839 2002-10-19 Ravi Pratap <ravi@ximian.com>
8841 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8842 message that we were generating - we just need to silently return
8845 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8847 * class.cs (Event.Define): Change my previous commit, as this
8848 breaks the debugger. This is a temporary hack, as it seems like
8849 the compiler is generating events incorrectly to begin with.
8851 * expression.cs (Binary.ResolveOperator): Added support for
8852 "U operator - (E x, E y)"
8854 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8857 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8858 init-only variables, but this path did not take into account that
8859 there might be also instance readonly variables. Correct this
8862 This fixes bug 32253
8864 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8867 * driver.cs: Change the extension for modules to `netmodule'
8869 * cs-parser.jay: Improved slightly the location tracking for
8870 the debugger symbols.
8872 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8873 modifiers that were specified instead of the hardcoded value
8874 (FamAndAssem). This was basically ignoring the static modifier,
8875 and others. Fixes 32429.
8877 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8878 fixed a bug in the process (32476)
8880 * expression.cs (ArrayAccess.EmitAssign): Patch from
8881 hwang_rob@yahoo.ca that fixes bug 31834.3
8883 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8885 * driver.cs: Make the module extension .netmodule.
8887 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8889 * driver.cs: Report an error if the resource file is not found
8890 instead of crashing.
8892 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8893 false, like Emit does.
8895 2002-10-16 Nick Drochak <ndrochak@gol.com>
8897 * typemanager.cs: Remove unused private member. Also reported mcs
8898 bug to report this as a warning like csc.
8900 2002-10-15 Martin Baulig <martin@gnome.org>
8902 * statement.cs (Statement.Emit): Made this a virtual method; emits
8903 the line number info and calls DoEmit().
8904 (Statement.DoEmit): New protected abstract method, formerly knows
8905 as Statement.Emit().
8907 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8909 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8911 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8912 have fixed a remaining problem: not every AddXXXX was adding a
8913 fully qualified name.
8915 Now everyone registers a fully qualified name in the DeclSpace as
8916 being defined instead of the partial name.
8918 Downsides: we are slower than we need to be due to the excess
8919 copies and the names being registered this way.
8921 The reason for this is that we currently depend (on the corlib
8922 bootstrap for instance) that types are fully qualified, because
8923 we dump all the types in the namespace, and we should really have
8924 types inserted into the proper namespace, so we can only store the
8925 basenames in the defined_names array.
8927 2002-10-10 Martin Baulig <martin@gnome.org>
8929 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8930 from bug #31834, see the bug report for a testcase which is
8933 2002-10-10 Martin Baulig <martin@gnome.org>
8935 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8936 flow analysis code for this.
8938 * statement.cs (Do, While, For): Tell the flow analysis code about
8940 (FlowBranching.UsageVector): Added support for infinite loops.
8941 (Block.Resolve): Moved the dead code elimination here and use flow
8944 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8946 * class.cs (Field.Define): Catch cycles on struct type
8949 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8950 fields if the fields are static. We only need to check instance
8953 * expression.cs (As.DoResolve): Test for reference type.
8955 * statement.cs (Using.ResolveExpression): Use
8956 ConvertImplicitRequired, not ConvertImplicit which reports an
8958 (Using.ResolveLocalVariableDecls): ditto.
8960 * expression.cs (Binary.ResolveOperator): Report errors in a few
8961 places where we had to.
8963 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8965 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8967 * expression.cs: Use StoreFromPtr instead of extracting the type
8968 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8970 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8971 an enumeration value to a System.Enum, but System.Enum is not a
8972 value type, but an class type, so we need to box.
8974 (Expression.ConvertExplicit): One codepath could return
8975 errors but not flag them. Fix this. Fixes #31853
8977 * parameter.cs (Resolve): Do not allow void as a parameter type.
8979 2002-10-06 Martin Baulig <martin@gnome.org>
8981 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8982 if it's a class type and not a struct. Fixes #31815.
8984 2002-10-06 Martin Baulig <martin@gnome.org>
8986 * statement.cs: Reworked the flow analysis code a bit to make it
8987 usable for dead code elimination.
8989 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8991 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8993 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8995 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8996 to fix the test 165, will investigate deeper.
8998 2002-10-04 Martin Baulig <martin@gnome.org>
9000 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9001 finally blocks actually work.
9002 (Try.Resolve): We don't need to create a sibling for `finally' if
9003 there is no finally block.
9005 2002-10-04 Martin Baulig <martin@gnome.org>
9007 * class.cs (Constructor.Define): The default accessibility for a
9008 non-default constructor is private, not public.
9010 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9012 * class.cs (Constructor): Make AllowedModifiers public, add
9015 * cs-parser.jay: Perform the modifiers test here, as the
9016 constructor for the Constructor class usually receives a zero
9017 because of the way we create it (first we create, later we
9018 customize, and we were never checking the modifiers).
9020 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9021 is a version of LookupTypeReflection that includes the type-name
9022 cache. This can be used as a fast path for functions that know
9023 the fully qualified name and are only calling into *.GetType() to
9024 obtain a composed type.
9026 This is also used by TypeManager.LookupType during its type
9029 (LookupType): We now also track the real type name, as sometimes
9030 we can get a quey for the real type name from things like
9031 ComposedCast. This fixes bug 31422.
9033 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9034 complete type fullname, it does not have to go through the type
9035 resolution system to obtain the composed version of the type (for
9036 obtaining arrays or pointers).
9038 (Conditional.Emit): Use the EmitBoolExpression to
9039 generate nicer code, as requested by Paolo.
9041 (ArrayCreation.CheckIndices): Use the patch from
9042 hwang_rob@yahoo.ca to validate the array initializers.
9044 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9046 * class.cs (ConstructorInitializer.Emit): simplify code by using
9047 Invocation.EmitCall, and at the same time, fix the bugs in calling
9048 parent constructors that took variable arguments.
9050 * ecore.cs (Expression.ConvertNumericExplicit,
9051 Expression.ImplicitNumericConversion): Remove the code that
9052 manually wrapped decimal (InternalTypeConstructor call is now gone
9055 * expression.cs (Cast.TryReduce): Also handle decimal types when
9056 trying to perform a constant fold on the type.
9058 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9060 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9061 that only turned off an error report, and did nothing else.
9063 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9065 * driver.cs: Handle and ignore /fullpaths
9067 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9069 * expression.cs (Binary.ResolveOperator): Catch the case where
9070 DoNumericPromotions returns true,
9072 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9074 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9076 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9079 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9081 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9082 conversion exists, but it is also required that the conversion be
9083 performed. This manifested in "(Type64Enum) 2".
9085 * class.cs (TypeManager.AddMethod): The fix is not to change
9086 AddEnum, because that one was using a fully qualified name (every
9087 DeclSpace derivative does), but to change the AddMethod routine
9088 that was using an un-namespaced name. This now correctly reports
9089 the duplicated name.
9091 Revert patch until I can properly fix it. The issue
9092 is that we have a shared Type space across all namespaces
9093 currently, which is wrong.
9095 Options include making the Namespace a DeclSpace, and merge
9096 current_namespace/current_container in the parser.
9098 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9100 * cs-parser.jay: Improve error reporting when we get a different
9101 kind of expression in local_variable_type and
9102 local_variable_pointer_type.
9104 Propagate this to avoid missleading errors being reported.
9106 * ecore.cs (ImplicitReferenceConversion): treat
9107 TypeManager.value_type as a target just like object_type. As
9112 Is valid, and needs to result in the int 1 being boxed before it
9113 is assigned to the value type v.
9115 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9116 to validate the enumeration name.
9118 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9119 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9120 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9122 * ecore.cs (TryImplicitIntConversion): When doing an
9123 implicit-enumeration-conversion, check if the type is 64-bits and
9124 perform a conversion before passing to EnumConstant.
9126 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9128 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9129 report ambiguous type references. Unlike the MS version, we
9130 report what the ambiguity is. Innovation at work ;-)
9132 (DeclSpace.FindType): Require a location argument to
9133 display when we display an ambiguous error.
9135 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9137 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9139 * expression.cs (EmitDynamicInitializers): Apply patch from
9140 hwang_rob@yahoo.ca that fixes the order in which we emit our
9143 2002-09-21 Martin Baulig <martin@gnome.org>
9145 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9146 delegate takes no arguments.
9148 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9150 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9153 * expression.cs: Extract the underlying type.
9155 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9157 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9159 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9161 * class.cs (TypeContainer.DefineType): We can not use the nice
9162 PackingSize with the size set to 1 DefineType method, because it
9163 will not allow us to define the interfaces that the struct
9166 This completes the fixing of bug 27287
9168 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9169 means also structs. This fixes part of the problem.
9170 (Expresion.ImplicitReferenceConversionExists): ditto.
9172 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9173 error if there were no errors reported during the type lookup
9174 process, to avoid duplicates or redundant errors. Without this
9175 you would get an ambiguous errors plus a type not found. We have
9176 beaten the user enough with the first error.
9178 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9181 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9182 during the resolution process, stop the lookup, this avoids
9183 repeated error reports (same error twice).
9185 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9187 * typemanager.cs (LookupType): Redo the type lookup code to match
9188 the needs of System.Reflection.
9190 The issue is that System.Reflection requires references to nested
9191 types to begin with a "+" sign instead of a dot. So toplevel
9192 types look like: "NameSpace.TopLevelClass", and nested ones look
9193 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9196 2002-09-19 Martin Baulig <martin@gnome.org>
9198 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9199 says that a method always returns or always throws an exception,
9200 don't report the CS0161.
9202 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9203 set `Returns = new_returns'.
9205 2002-09-19 Martin Baulig <martin@gnome.org>
9207 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9208 to an enum constant, check for a CS0176.
9210 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9212 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9213 for operators that must be in pairs and report errors.
9215 * ecore.cs (SimpleName.DoResolveType): During the initial type
9216 resolution process, when we define types recursively, we must
9217 check first for types in our current scope before we perform
9218 lookups in the enclosing scopes.
9220 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9222 (Invocation.VerifyArgumentsCompat): Call
9223 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9224 I thought we were supposed to always call this, but there are a
9225 few places in the code where we dont do it.
9227 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9229 * driver.cs: Add support in -linkres and -resource to specify the
9230 name of the identifier.
9232 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9234 * ecore.cs (StandardConversionExists): Sync with the conversion
9235 code: allow anything-* to void* conversions.
9237 (FindMostSpecificSource): Use an Expression argument
9238 instead of a Type, because we might be handed over a Literal which
9239 gets a few more implicit conversions that plain types do not. So
9240 this information was being lost.
9242 Also, we drop the temporary type-holder expression when not
9245 2002-09-17 Martin Baulig <martin@gnome.org>
9247 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9248 this is an explicit interface implementation.
9250 2002-09-17 Martin Baulig <martin@gnome.org>
9252 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9253 different `IndexerName' attributes.
9255 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9256 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9257 virtual CommonResolve().
9259 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9261 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9262 and convert that to the UnderlyingType.
9264 * statement.cs (Foreach.Resolve): Indexers are just like variables
9265 or PropertyAccesses.
9267 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9268 inside quoted strings, we were not doing this before.
9270 2002-09-16 Martin Baulig <martin@gnome.org>
9272 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9273 resolve it. This is needed for the definite assignment check of the
9274 instance expression, fixes bug #29846.
9275 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9277 2002-09-16 Nick Drochak <ndrochak@gol.com>
9279 * parameter.cs: Fix compile error. Cannot reference static member
9280 from an instance object. Is this an mcs bug?
9282 2002-09-14 Martin Baulig <martin@gnome.org>
9284 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9285 multiple times. Fixes bug #30295, added test-166.cs.
9287 2002-09-14 Martin Baulig <martin@gnome.org>
9289 * statement.cs (Block.Emit): Don't emit unreachable code.
9290 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9292 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9294 2002-09-14 Martin Baulig <martin@gnome.org>
9296 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9299 2002-09-14 Martin Baulig <martin@gnome.org>
9301 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9302 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9303 be false on the ms runtime.
9305 2002-09-13 Martin Baulig <martin@gnome.org>
9307 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9308 the CS0038 error message.
9310 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9312 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9313 constant inside, return it.
9315 2002-09-12 Martin Baulig <martin@gnome.org>
9317 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9318 implicit conversion can be done between enum types.
9320 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9321 check whether an implicit conversion to the current enum's UnderlyingType
9322 exists and report an error if not.
9324 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9325 without debugging support.
9327 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9328 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9330 2002-09-12 Martin Baulig <martin@gnome.org>
9332 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9334 * ecore.cs (IMemberExpr.DeclaringType): New property.
9335 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9336 nonstatic member of an outer type (CS0038).
9338 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9340 * driver.cs: Activate the using-error detector at warning level
9341 4 (at least for MS-compatible APIs).
9343 * namespace.cs (VerifyUsing): Small buglett fix.
9345 * pending.cs (PendingImplementation): pass the container pointer.
9347 * interface.cs (GetMethods): Allow for recursive definition. Long
9348 term, I would like to move every type to support recursive
9349 definitions, not the current ordering mechanism that we have right
9352 The situation is this: Attributes are handled before interfaces,
9353 so we can apply attributes to interfaces. But some attributes
9354 implement interfaces, we will now handle the simple cases
9355 (recursive definitions will just get an error).
9357 * parameter.cs: Only invalidate types at the end if we fail to
9360 2002-09-09 Martin Baulig <martin@gnome.org>
9362 * ecore.cs (PropertyExpr.Emit): Also check for
9363 TypeManager.system_int_array_get_length so this'll also work when
9364 compiling corlib. Fixes #30003.
9366 2002-09-09 Martin Baulig <martin@gnome.org>
9368 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9369 and throw an exception if we can't get the type's size. Fixed #30040,
9372 2002-09-09 Martin Baulig <martin@gnome.org>
9374 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9376 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9377 context. Fixes bug #30027.
9379 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9380 virtual functions. Fixes bug #30043, added test-164.cs.
9382 2002-09-08 Ravi Pratap <ravi@ximian.com>
9384 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9386 2002-09-08 Nick Drochak <ndrochak@gol.com>
9388 * driver.cs: Use an object to get the windows codepage since it's not a
9391 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9393 * statement.cs (For.Emit): for infinite loops (test == null)
9394 return whether there is a break inside, not always "true".
9396 * namespace.cs (UsingEntry): New struct to hold the name of the
9397 using definition, the location where it is defined, and whether it
9398 has been used in a successful type lookup.
9400 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9405 2002-09-06 Ravi Pratap <ravi@ximian.com>
9407 * attribute.cs : Fix incorrect code which relied on catching
9408 a NullReferenceException to detect a null being passed in
9409 where an object was expected.
9411 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9413 * statement.cs (Try): flag the catch variable as assigned
9415 * expression.cs (Cast): Simplified by using ResolveType instead of
9418 * statement.cs (Catch): Fix bug by using ResolveType.
9420 2002-09-06 Ravi Pratap <ravi@ximian.com>
9422 * expression.cs (BetterConversion): Special case for when we have
9423 a NullLiteral as the argument and we have to choose between string
9424 and object types - we choose string the way csc does.
9426 * attribute.cs (Attribute.Resolve): Catch the
9427 NullReferenceException and report error #182 since the Mono
9428 runtime no more has the bug and having this exception raised means
9429 we tried to select a constructor which takes an object and is
9432 2002-09-05 Ravi Pratap <ravi@ximian.com>
9434 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9435 message (1502, 1503) when we can't locate a method after overload
9436 resolution. This is much more informative and closes the bug
9439 * interface.cs (PopulateMethod): Return if there are no argument
9440 types. Fixes a NullReferenceException bug.
9442 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9443 expressions too. Previously we were checking only in one place for
9444 positional arguments leaving out named arguments.
9446 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9447 type to the enum type is not allowed. Remove code corresponding to
9450 (ConvertNumericExplicit): Allow explicit conversions from
9451 the underlying type to enum type. This precisely follows the spec
9452 and closes a bug filed by Gonzalo.
9454 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9457 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9459 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9461 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9462 it was important that we stored the right value after the
9463 reduction in `converted'.
9465 2002-09-04 Martin Baulig <martin@gnome.org>
9467 * location.cs (Location.SymbolDocument): Use full pathnames for the
9470 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9472 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9473 of the expression resolve mechanism, because that will catch the
9474 SimpleName error failures.
9476 (Conditional): If we can not resolve the
9477 expression, return, do not crash.
9479 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9482 (location): display token name instead of its number.
9484 2002-08-28 Martin Baulig <martin@gnome.org>
9486 * expression.cs (Binary.ResolveOperator): Don't silently return
9487 but return an error if an operator cannot be applied between two
9490 2002-08-28 Martin Baulig <martin@gnome.org>
9492 * class.cs (Constructor.Define): Set the permission attributes
9493 correctly instead of making all constructors public.
9495 2002-08-28 Martin Baulig <martin@gnome.org>
9497 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9498 for private members before reporting a CS0103; if we find anything,
9501 2002-08-28 Martin Baulig <martin@gnome.org>
9503 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9504 to check whether `closure_start_type == closure_invocation_type',
9505 we also need to check whether `m.DeclaringType == closure_invocation_type'
9506 before bypassing the permission checks. We might be accessing
9507 protected/private members from the base class.
9508 (TypeManager.RealMemberLookup): Only set private_ok if private
9509 members were requested via BindingFlags.NonPublic.
9511 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9513 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9514 MethodGroupExpr.IsExplicitImpl if appropriate.
9515 (Invocation.DoResolve): Don't report the CS0120 for explicit
9516 interface implementations.
9518 2002-08-27 Martin Baulig <martin@gnome.org>
9520 * expression.cs (Invocation.DoResolve): If this is a static
9521 method and we don't have an InstanceExpression, we must report
9524 2002-08-25 Martin Baulig <martin@gnome.org>
9526 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9527 `==' between a valuetype and an object.
9529 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9531 * ecore.cs (TypeExpr): Provide a ToString method.
9533 2002-08-24 Martin Baulig <martin@gnome.org>
9535 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9536 now called proggie.dbg and it's a binary file.
9538 2002-08-23 Martin Baulig <martin@gnome.org>
9540 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9542 2002-08-23 Martin Baulig <martin@gnome.org>
9544 * struct.cs (MyStructInfo.ctor): Make this work with empty
9545 structs; it's not allowed to use foreach() on null.
9547 2002-08-23 Martin Baulig <martin@gnome.org>
9549 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9550 writer the full pathname of the generated assembly.
9552 2002-08-23 Martin Baulig <martin@gnome.org>
9554 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9555 A `finally' block never returns or breaks; improved handling of
9558 2002-08-23 Martin Baulig <martin@gnome.org>
9560 * statement.cs (Throw.Resolve): Allow `throw null'.
9562 2002-08-23 Martin Baulig <martin@gnome.org>
9564 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9565 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9566 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9567 MemberLookup would return a wrong event if this is an explicit
9568 interface implementation and the class has an event with the same
9571 2002-08-23 Martin Baulig <martin@gnome.org>
9573 * statement.cs (Block.AddChildVariableNames): New public method.
9574 (Block.AddChildVariableName): Likewise.
9575 (Block.IsVariableNameUsedInChildBlock): Likewise.
9576 (Block.AddVariable): Check whether a variable name has already
9577 been used in a child block.
9579 * cs-parser.jay (declare_local_variables): Mark all variable names
9580 from the current block as being used in a child block in the
9583 2002-08-23 Martin Baulig <martin@gnome.org>
9585 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9586 find the symbol writer.
9588 * driver.cs: csc also allows the arguments to /define being
9589 separated by commas, not only by semicolons.
9591 2002-08-23 Martin Baulig <martin@gnome.org>
9593 * interface.cs (Interface.GetMembers): Added static check for events.
9595 2002-08-15 Martin Baulig <martin@gnome.org>
9597 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9598 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9600 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9601 why the MethodData.EmitDestructor() change was necessary.
9603 2002-08-20 Martin Baulig <martin@gnome.org>
9605 * class.cs (TypeContainer.FindMembers): Added static check for events.
9607 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9609 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9610 use Type.GetEvents(), not Type.FindMembers().
9612 2002-08-20 Martin Baulig <martin@gnome.org>
9614 * decl.cs (MemberCache): Added a special method cache which will
9615 be used for method-only searched. This ensures that a method
9616 search will return a MethodInfo with the correct ReflectedType for
9619 2002-08-20 Martin Baulig <martin@gnome.org>
9621 * decl.cs (DeclSpace.FindMembers): Made this public.
9623 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9625 * delegate.cs: fixed build on windows.
9626 [FIXME: Filed as bug #29150: MCS must report these errors.]
9628 2002-08-19 Ravi Pratap <ravi@ximian.com>
9630 * ecore.cs (StandardConversionExists): Return a false
9631 if we are trying to convert the void type to anything else
9632 since that is not allowed.
9634 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9635 we flag error 70 in the event an event is trying to be accessed
9636 directly from outside the declaring type.
9638 2002-08-20 Martin Baulig <martin@gnome.org>
9640 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9641 MemberCache from typemanager.cs to decl.cs.
9643 2002-08-19 Martin Baulig <martin@gnome.org>
9645 * class.cs (TypeContainer): Implement IMemberContainer.
9646 (TypeContainer.DefineMembers): Create the MemberCache.
9647 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9648 return public members if BindingFlags.Public was given, check
9649 whether members are static.
9651 2002-08-16 Martin Baulig <martin@gnome.org>
9653 * decl.cs (DeclSpace.Define): Splitted this in Define and
9654 DefineMembers. DefineMembers is called first and initializes the
9657 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9658 DefineMembers() on all our DeclSpaces.
9660 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9661 but call DefineMembers() on all nested interfaces. We call their
9662 Define() in our new Define() function.
9664 * interface.cs (Interface): Implement IMemberContainer.
9665 (Interface.Define): Moved all code except the attribute stuf to
9667 (Interface.DefineMembers): Initialize the member cache.
9669 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9670 need this anymore since we can use MemberCache.FindMembers directly.
9672 2002-08-19 Martin Baulig <martin@gnome.org>
9674 * typemanager.cs (MemberCache): When creating the cache for an
9675 interface type, add all inherited members.
9676 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9677 to `out bool used_cache' and documented it.
9678 (TypeManager.MemberLookup): If we already used the cache in the first
9679 iteration, we don't need to do the interfaces check.
9681 2002-08-19 Martin Baulig <martin@gnome.org>
9683 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9684 here from IMemberFinder and don't implement this interface anymore.
9685 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9687 * typemanager.cs (IMemberFinder): This interface is now only used by
9688 classes which actually support the member cache.
9689 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9690 since we only put DeclSpaces into this Hashtable.
9691 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9692 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9694 2002-08-16 Martin Baulig <martin@gnome.org>
9696 * typemanager.cs (ICachingMemberFinder): Removed.
9697 (IMemberFinder.MemberCache): New property.
9698 (TypeManager.FindMembers): Merged this with RealFindMembers().
9699 This function will never be called from TypeManager.MemberLookup()
9700 so we can't use the cache here, just the IMemberFinder.
9701 (TypeManager.MemberLookup_FindMembers): Check whether the
9702 IMemberFinder has a MemberCache and call the cache's FindMembers
9704 (MemberCache): Rewrote larger parts of this yet another time and
9705 cleaned it up a bit.
9707 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9709 * driver.cs (LoadArgs): Support quoting.
9711 (Usage): Show the CSC-like command line arguments.
9713 Improved a few error messages.
9715 2002-08-15 Martin Baulig <martin@gnome.org>
9717 * typemanager.cs (IMemberContainer.Type): New property.
9718 (IMemberContainer.IsInterface): New property.
9720 The following changes are conditional to BROKEN_RUNTIME, which is
9721 defined at the top of the file.
9723 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9724 class'es members, but add all members from TypeHandle.ObjectType
9725 if we're an interface.
9726 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9727 is the current type.
9728 (MemberCache.CacheEntry.Container): Removed this field.
9729 (TypeHandle.GetMembers): Include inherited members.
9731 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9733 * typemanager.cs: fixed compilation and added a comment on a field that
9736 2002-08-15 Martin Baulig <martin@gnome.org>
9738 * class.cs (ConstructorInitializer.Resolve): In the
9739 Expression.MemberLookup call, use the queried_type as
9742 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9743 declared' attribute, it's always true.
9744 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9745 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9746 temporary wrapper for FindMembers which tells MemberLookup whether
9747 members from the base classes are included in the return value.
9748 This will go away soon.
9749 (TypeManager.MemberLookup): Use this temporary hack here; once the
9750 new MemberCache is completed, we don't need to do the DeclaredOnly
9751 looping here anymore since the MemberCache will take care of this.
9752 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9753 (MemberCache): When creating the MemberCache for a class, get
9754 members from the current class and all its base classes.
9755 (MemberCache.CacheEntry.Container): New field. This is a
9756 temporary hack until the Mono runtime is fixed to distinguish
9757 between ReflectedType and DeclaringType. It allows us to use MCS
9758 with both the MS runtime and the unfixed Mono runtime without
9759 problems and without accecting performance.
9760 (MemberCache.SearchMembers): The DeclaredOnly looping from
9761 TypeManager.MemberLookup is now done here.
9763 2002-08-14 Martin Baulig <martin@gnome.org>
9765 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9766 Type.GetFields on dynamic types but get the fields from the
9767 corresponding TypeContainer.
9768 (MyStructInfo.GetStructInfo): Added check for enum types.
9770 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9771 (MemberList.SyncRoot): Implemented.
9772 (TypeManager.FilterWithClosure): No need to check permissions if
9773 closure_start_type == closure_invocation_type, don't crash if
9774 closure_invocation_type is null.
9776 2002-08-13 Martin Baulig <martin@gnome.org>
9778 Rewrote TypeContainer.FindMembers to use a member cache. This
9779 gives us a speed increase of about 35% for the self-hosting MCS
9780 build and of about 15-20% for the class libs (both on GNU/Linux).
9782 * report.cs (Timer): New class to get enhanced profiling. This
9783 whole class is "TIMER" conditional since it remarkably slows down
9786 * class.cs (MemberList): New class. This is an IList wrapper
9787 which we're now using instead of passing MemberInfo[]'s around to
9788 avoid copying this array unnecessarily.
9789 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9790 (ICachingMemberFinder, IMemberContainer): New interface.
9791 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9792 has already been checked, otherwise use it for the name comparision.
9793 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9794 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9795 if possible. Returns a MemberList, not a MemberInfo [].
9796 (TypeHandle): New class, implements IMemberContainer. We create
9797 one instance of this class per type, it contains a MemberCache
9798 which is used to do the member lookups.
9799 (MemberCache): New class. Each instance of this class contains
9800 all members of a type and a name-based hash table.
9801 (MemberCache.FindMembers): This is our new member lookup
9802 function. First, it looks up all members of the requested name in
9803 the hash table. Then, it walks this list and sorts out all
9804 applicable members and returns them.
9806 2002-08-13 Martin Baulig <martin@gnome.org>
9808 In addition to a nice code cleanup, this gives us a performance
9809 increase of about 1.4% on GNU/Linux - not much, but it's already
9810 half a second for the self-hosting MCS compilation.
9812 * typemanager.cs (IMemberFinder): New interface. It is used by
9813 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9814 Enum, Delegate or Interface.
9815 (TypeManager.finder_to_member_finder): New PtrHashtable.
9816 (TypeManager.finder_to_container): Removed.
9817 (TypeManager.finder_to_delegate): Removed.
9818 (TypeManager.finder_to_interface): Removed.
9819 (TypeManager.finder_to_enum): Removed.
9821 * interface.cs (Interface): Implement IMemberFinder.
9823 * delegate.cs (Delegate): Implement IMemberFinder.
9825 * enum.cs (Enum): Implement IMemberFinder.
9827 * class.cs (TypeContainer): Implement IMemberFinder.
9829 2002-08-12 Martin Baulig <martin@gnome.org>
9831 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9833 2002-08-12 Martin Baulig <martin@gnome.org>
9835 * ecore.cs (ITypeExpression): New interface for expressions which
9837 (TypeExpression): Renamed to TypeLookupExpression.
9838 (Expression.DoResolve): If we're doing a types-only lookup, the
9839 expression must implement the ITypeExpression interface and we
9840 call DoResolveType() on it.
9841 (SimpleName): Implement the new ITypeExpression interface.
9842 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9843 hack, the situation that we're only looking up types can't happen
9844 anymore when this method is called. Moved the type lookup code to
9845 DoResolveType() and call it.
9846 (SimpleName.DoResolveType): This ITypeExpression interface method
9847 is now doing the types-only lookup.
9848 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9849 (ResolveFlags): Added MaskExprClass.
9851 * expression.cs (MemberAccess): Implement the ITypeExpression
9853 (MemberAccess.DoResolve): Added support for a types-only lookup
9854 when we're called via ITypeExpression.DoResolveType().
9855 (ComposedCast): Implement the ITypeExpression interface.
9857 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9858 Expression.Resolve() with ResolveFlags.Type instead.
9860 2002-08-12 Martin Baulig <martin@gnome.org>
9862 * interface.cs (Interface.Define): Apply attributes.
9864 * attribute.cs (Attribute.ApplyAttributes): Added support for
9865 interface attributes.
9867 2002-08-11 Martin Baulig <martin@gnome.org>
9869 * statement.cs (Block.Emit): Only check the "this" variable if we
9870 do not always throw an exception.
9872 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9873 whether the property has a set accessor.
9875 2002-08-11 Martin Baulig <martin@gnome.org>
9877 Added control flow analysis support for structs.
9879 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9880 with control flow analysis turned off.
9881 (IVariable): New interface.
9882 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9883 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9884 (FieldExpr.DoResolve): Resolve the instance expression with flow
9885 analysis turned off and do the definite assignment check after the
9886 resolving when we know what the expression will resolve to.
9888 * expression.cs (LocalVariableReference, ParameterReference):
9889 Implement the new IVariable interface, only call the flow analysis
9890 code if ec.DoFlowAnalysis is true.
9891 (This): Added constructor which takes a Block argument. Implement
9892 the new IVariable interface.
9893 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9894 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9895 This does the definite assignment checks for struct members.
9897 * class.cs (Constructor.Emit): If this is a non-static `struct'
9898 constructor which doesn't have any initializer, call
9899 Block.AddThisVariable() to tell the flow analysis code that all
9900 struct elements must be initialized before control returns from
9903 * statement.cs (MyStructInfo): New public class.
9904 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9905 argument to this indexer. If non-zero, check an individual struct
9906 member, not the whole struct.
9907 (FlowBranching.CheckOutParameters): Check struct members.
9908 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9909 overloaded versions of these methods which take an additional
9910 `int field_idx' argument to check struct members.
9911 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9912 overloaded versions of these methods which take an additional
9913 `string field_name' argument to check struct member.s
9914 (VariableInfo): Implement the IVariable interface.
9915 (VariableInfo.StructInfo): New public property. Returns the
9916 MyStructInfo instance of the variable if it's a struct or null.
9917 (Block.AddThisVariable): New public method. This is called from
9918 Constructor.Emit() for non-static `struct' constructor which do
9919 not have any initializer. It creates a special variable for the
9920 "this" instance variable which will be checked by the flow
9921 analysis code to ensure that all of the struct's fields are
9922 initialized before control returns from the constructor.
9923 (UsageVector): Added support for struct members. If a
9924 variable/parameter is a struct with N members, we reserve a slot
9925 in the usage vector for each member. A struct is considered fully
9926 initialized if either the struct itself (slot 0) or all its
9927 members are initialized.
9929 2002-08-08 Martin Baulig <martin@gnome.org>
9931 * driver.cs (Driver.MainDriver): Only report an error CS5001
9932 if there were no compilation errors.
9934 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9935 `UnsafeContext' property to determine whether the parent is in
9936 unsafe context rather than checking the parent's ModFlags:
9937 classes nested in an unsafe class are unsafe as well.
9939 2002-08-08 Martin Baulig <martin@gnome.org>
9941 * statement.cs (UsageVector.MergeChildren): Distinguish between
9942 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9943 we return. Added test17() and test18() to test-154.cs.
9945 2002-08-08 Martin Baulig <martin@gnome.org>
9947 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9948 Family access, make sure the invoking type isn't a subclass of the
9949 queried type (that'd be a CS1540).
9951 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9952 this method which takes an additional `Type invocation_type'.
9954 * expression.cs (BaseAccess.DoResolve): Use the base type as
9955 invocation and query type.
9956 (MemberAccess.DoResolve): If the lookup failed and we're about to
9957 report a CS0122, try a lookup with the ec.ContainerType - if this
9958 succeeds, we must report a CS1540.
9960 2002-08-08 Martin Baulig <martin@gnome.org>
9962 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9963 (MethodGroupExpr): Implement the IMemberExpr interface.
9965 * expression (MemberAccess.ResolveMemberAccess): No need to have
9966 any special code for MethodGroupExprs anymore, they're now
9969 2002-08-08 Martin Baulig <martin@gnome.org>
9971 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9972 Family, FamANDAssem and FamORAssem permissions.
9973 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9975 2002-08-08 Martin Baulig <martin@gnome.org>
9977 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9978 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9981 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9983 * driver.cs: implemented /resource option to embed managed resources.
9985 2002-08-07 Martin Baulig <martin@gnome.org>
9987 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9988 (FieldBase.HasFieldInitializer): New public property.
9989 (FieldBase.GetInitializerExpression): New public method. Resolves and
9990 returns the field initializer and makes sure it is only resolved once.
9991 (TypeContainer.EmitFieldInitializers): Call
9992 FieldBase.GetInitializerExpression to get the initializer, this ensures
9993 that it isn't resolved multiple times.
9995 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9996 the resolving process (SimpleName/MemberLookup) that we're currently
9997 emitting a field initializer (which must not access any instance members,
9998 this is an error CS0236).
10000 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10001 argument, if the `IsFieldInitializer' flag is set, we must report and
10002 error CS0236 and not an error CS0120.
10004 2002-08-07 Martin Baulig <martin@gnome.org>
10006 * ecore.cs (IMemberExpr): New public interface.
10007 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10008 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10009 if the expression is an IMemberExpr.
10011 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10012 to be null, implicitly default to `this' if we're non-static in
10013 this case. Simplified the code a lot by using the new IMemberExpr
10014 interface. Also fixed bug #28176 here.
10016 2002-08-06 Martin Baulig <martin@gnome.org>
10018 * cs-parser.jay (SimpleLookup): Removed. We need to create
10019 ParameterReferences during semantic analysis so that we can do a
10020 type-only search when resolving Cast, TypeOf and SizeOf.
10021 (block): Pass the `current_local_parameters' to the Block's
10024 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10025 argument to the constructor.
10026 (ConstructorInitializer.Resolve): Create a temporary implicit
10027 block with the parameters.
10029 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10030 references here if we aren't doing a type-only search.
10032 * statement.cs (Block): Added constructor which takes a
10033 `Parameters parameters' argument.
10034 (Block.Parameters): New public property.
10036 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10037 to `Parameters' and made it public readonly.
10039 2002-08-06 Martin Baulig <martin@gnome.org>
10041 * ecore.cs (Expression.Warning): Made this public as well.
10043 * report.cs (Report.Debug): Print the contents of collections.
10045 2002-08-06 Martin Baulig <martin@gnome.org>
10047 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10048 used to tell Resolve() which kinds of expressions it may return.
10049 (Expression.Resolve): Added overloaded version of this method which
10050 takes a `ResolveFlags flags' argument. This can be used to tell
10051 Resolve() which kinds of expressions it may return. Reports a
10053 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10054 ResolveFlags.SimpleName.
10055 (Expression.Error118): Added overloaded version of this method which
10056 takes a `ResolveFlags flags' argument. It uses the flags to determine
10057 which kinds of expressions are allowed.
10059 * expression.cs (Argument.ResolveMethodGroup): New public method.
10060 Resolves an argument, but allows a MethodGroup to be returned.
10061 This is used when invoking a delegate.
10063 * TODO: Updated a bit.
10065 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10067 Fixed compilation with csc.
10069 * ecore.cs: Expression.Error made public. Is this correct? Should
10070 Warning be made public too?
10072 * expression.cs: use ea.Location instead of ea.loc.
10073 [FIXME: Filed as bug #28607: MCS must report these errors.]
10075 2002-08-06 Martin Baulig <martin@gnome.org>
10077 * ecore.cs (Expression.loc): Moved the location here instead of
10078 duplicating it in all derived classes.
10079 (Expression.Location): New public property.
10080 (Expression.Error, Expression.Warning): Made them non-static and
10081 removed the location argument.
10082 (Expression.Warning): Added overloaded version which takes an
10083 `int level' argument.
10084 (Expression.Error118): Make this non-static and removed the
10085 expression and location arguments.
10086 (TypeExpr): Added location argument to the constructor.
10088 * expression.cs (StaticCallExpr): Added location argument to
10090 (Indirection, PointerArithmetic): Likewise.
10091 (CheckedExpr, UnCheckedExpr): Likewise.
10092 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10093 (StringPtr): Likewise.
10096 2002-08-05 Martin Baulig <martin@gnome.org>
10098 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10100 * assign.cs (Assign.DoResolve): Check whether the source
10101 expression is a value or variable.
10103 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10104 while resolving the corresponding blocks.
10106 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10107 an error, don't silently return null.
10109 * statement.cs (Block.AddVariable): Do the error reporting here
10110 and distinguish between CS0128 and CS0136.
10111 (Block.DoResolve): Report all unused labels (warning CS0164).
10112 (LabeledStatement): Pass the location to the constructor.
10113 (LabeledStatement.HasBeenReferenced): New property.
10114 (LabeledStatement.Resolve): Set it to true here.
10116 * statement.cs (Return.Emit): Return success even after reporting
10117 a type mismatch error (CS0126 or CS0127), this is what csc does and
10118 it avoids confusing the users with any consecutive errors.
10120 2002-08-05 Martin Baulig <martin@gnome.org>
10122 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10124 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10126 * expression.cs (MemberAccess.DoResolve): Silently return if an
10127 error has already been reported.
10129 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10130 error has already been reported.
10132 2002-08-05 Martin Baulig <martin@gnome.org>
10134 * statement.cs (UsageVector): Only initialize the `parameters'
10135 vector if we actually have any "out" parameters.
10137 2002-08-05 Martin Baulig <martin@gnome.org>
10139 * expression.cs (Binary.ResolveOperator): When combining delegates,
10140 they must have the same type.
10142 2002-08-05 Martin Baulig <martin@gnome.org>
10144 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10145 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10146 work with the ms runtime and we also don't need it: if we're a
10147 PropertyBuilder and not in the `indexer_arguments' hash, then we
10148 are a property and not an indexer.
10150 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10151 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10152 since the latter one doesn't work with the ms runtime.
10154 2002-08-03 Martin Baulig <martin@gnome.org>
10156 Fixed bugs #27998 and #22735.
10158 * class.cs (Method.IsOperator): New public field.
10159 (Method.CheckBase): Report CS0111 if there's already a method
10160 with the same parameters in the current class. Report CS0508 when
10161 attempting to change the return type of an inherited method.
10162 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10163 and it's not marked abstract or extern.
10164 (PropertyBase): New abstract base class for Property and Indexer.
10165 (PropertyBase.CheckBase): Moved here from Property and made it work
10167 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10168 the same so we can reuse it there.
10169 (Property, Indexer): Derive from PropertyBase.
10170 (MethodSignature.inheritable_property_signature_filter): New delegate
10171 to find properties and indexers.
10173 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10174 argument and improved error reporting.
10176 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10177 EmptyReadOnlyParameters and made it a property.
10179 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10180 version of this method which takes a `PropertyInfo indexer'.
10181 (TypeManager.RegisterIndexer): New method.
10183 * class.cs: Added myself as author of this file :-)
10185 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10187 * class.cs: fixed compilation on windoze.
10189 2002-08-03 Martin Baulig <martin@gnome.org>
10191 * interface.cs (Interface.GetInterfaceBases): Check whether all
10192 base interfaces are at least as accessible than the current one.
10194 * class.cs (TypeContainer.GetClassBases): Check whether base types
10195 are at least as accessible than the current type.
10196 (TypeContainer.AsAccessible): Implemented and made non-static.
10197 (MemberBase.CheckParameters): Report errors if the accessibility
10200 * delegate.cs (Delegate.Delegate): The default visibility is
10201 internal for top-level types and private for nested types.
10202 (Delegate.Define): Report errors if the accessibility checks fail.
10204 * enum.cs (Enum.Enum): The default visibility is internal for
10205 top-level types and private for nested types.
10206 (Enum.DefineType): Compute the correct visibility.
10208 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10209 function which takes a `bool is_toplevel' instead of a TypeContainer.
10211 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10214 2002-08-02 Martin Baulig <martin@gnome.org>
10216 * expression.cs (LocalVariableReferenc): Added constructor which
10217 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10218 (LocalVariableReference.IsReadOnly): New property.
10219 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10220 variable is readonly, use our own readonly flag to do this; you can
10221 use the new constructor to get a writable reference to a read-only
10224 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10225 reference to the local variable.
10227 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10229 * rootcontext.cs (ResolveCore): Also include System.Exception
10231 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10232 we reach an EmptyStatement.
10234 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10237 * expression.cs (Binary.ResolveOperator): Check error result in
10240 use brtrue/brfalse directly and avoid compares to null.
10242 2002-08-02 Martin Baulig <martin@gnome.org>
10244 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10245 Fixes bug #28407, added test-155.cs.
10247 2002-08-01 Martin Baulig <martin@gnome.org>
10249 * class.cs (Event.EmitDefaultMethod): Make this work with static
10250 events. Fixes #28311, added verify-3.cs.
10252 2002-08-01 Martin Baulig <martin@gnome.org>
10254 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10255 `is_disposable' fields.
10256 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10257 `hm.is_disposable' if we're using the collection pattern.
10258 (Foreach.EmitCollectionForeach): Use the correct type for the
10259 enumerator's local variable, only emit the try/finally block if
10260 necessary (fixes #27713).
10262 2002-08-01 Martin Baulig <martin@gnome.org>
10264 * ecore.cs (Expression.report118): Renamed to Error118 and made
10267 * statement.cs (Throw.Resolve): Check whether the expression is of
10268 the correct type (CS0118) and whether the type derives from
10269 System.Exception (CS0155).
10270 (Catch.Resolve): New method. Do the type lookup here and check
10271 whether it derives from System.Exception (CS0155).
10272 (Catch.CatchType, Catch.IsGeneral): New public properties.
10274 * typemanager.cs (TypeManager.exception_type): Added.
10276 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10278 * driver.cs: Updated About function.
10280 2002-07-31 Martin Baulig <martin@gnome.org>
10282 Implemented Control Flow Analysis.
10284 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10285 (EmitContext.CurrentBranching): Added.
10286 (EmitContext.StartFlowBranching): Added.
10287 (EmitContext.EndFlowBranching): Added.
10288 (EmitContext.KillFlowBranching): Added.
10289 (EmitContext.IsVariableAssigned): Added.
10290 (EmitContext.SetVariableAssigned): Added.
10291 (EmitContext.IsParameterAssigned): Added.
10292 (EmitContext.SetParameterAssigned): Added.
10293 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10294 Added control flow analysis stuff here.
10296 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10297 resolve the expression as lvalue.
10298 (LocalVariableReference.DoResolve): Check whether the variable has
10299 already been assigned.
10300 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10301 the parameter as assigned here.
10302 (ParameterReference.DoResolve): Check whether the parameter has already
10304 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10305 expression as lvalue.
10307 * statement.cs (FlowBranching): New class for the flow analysis code.
10308 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10309 (LabeledStatement.IsDefined): New public property.
10310 (LabeledStatement.AddUsageVector): New public method to tell flow
10311 analyis that the label may be reached via a forward jump.
10312 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10314 (VariableInfo.Number): New public field. This is used by flow analysis
10315 to number all locals of a block.
10316 (Block.CountVariables): New public property. This is the number of
10317 local variables in this block (including the locals from all parent
10319 (Block.EmitMeta): Number all the variables.
10321 * statement.cs: Added flow analysis support to all classes.
10323 2002-07-31 Martin Baulig <martin@gnome.org>
10325 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10326 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10327 then use this argument.
10329 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10331 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10332 use this to specify /define options.
10334 2002-07-29 Martin Baulig <martin@gnome.org>
10336 * statement.cs (Fixed): Moved all code that does variable lookups
10337 and resolvings from Emit to Resolve.
10339 * statement.cs (For): Moved all code that does variable lookups
10340 and resolvings from Emit to Resolve.
10342 * statement.cs (Using): Moved all code that does variable lookups
10343 and resolvings from Emit to Resolve.
10345 2002-07-29 Martin Baulig <martin@gnome.org>
10347 * attribute.cs (Attribute.Resolve): Explicitly catch a
10348 System.NullReferenceException when creating the
10349 CustromAttributeBuilder and report a different warning message.
10351 2002-07-29 Martin Baulig <martin@gnome.org>
10353 * support.cs (ParameterData.ParameterName): Added method to
10354 get the name of a parameter.
10356 * typemanager.cs (TypeManager.IsValueType): New public method.
10358 2002-07-29 Martin Baulig <martin@gnome.org>
10360 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10361 is a flag which specifies that it's either ref or out.
10362 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10363 the out parameter to `out Parameter.Modifier mod', also set the
10364 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10366 * support.cs (InternalParameters.ParameterModifier): Distinguish
10367 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10368 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10370 * expression.cs (Argument.GetParameterModifier): Distinguish
10371 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10372 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10374 2002-07-29 Martin Baulig <martin@gnome.org>
10376 * expression.cs (ParameterReference.ParameterReference): Added
10377 `Location loc' argument to the constructor.
10379 * cs-parser.jay: Pass location to ParameterReference.
10381 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10383 * statement.cs (Try): Initialize the location.
10385 * cs-parser.jay: pass location to Try.
10387 * expression.cs (Unary.Reduce): Change the prototype to return
10388 whether a constant fold could be performed or not. The result is
10389 returned in an out parameters. In the case of Indirection and
10390 AddressOf, we want to perform the full tests.
10392 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10394 * statement.cs (Statement.Emit): Flag dead code.
10396 2002-07-27 Andrew Birkett <andy@nobugs.org>
10398 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10400 2002-07-27 Martin Baulig <martin@gnome.org>
10402 * class.cs (MethodData.Define): Put back call to
10403 TypeManager.AddMethod(), accidentally commented this out.
10405 * report.cs (Debug): New public method to print debugging information,
10406 this is `[Conditional ("DEBUG")]'.
10408 2002-07-26 Martin Baulig <martin@gnome.org>
10410 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10411 (switch_statement): Push the current_block to the switch_stack and
10412 pop it again when we're done with the switch.
10413 (switch_section): The new block is a child of the current_block.
10414 Fixes bug #24007, added test-152.cs.
10416 2002-07-27 Martin Baulig <martin@gnome.org>
10418 * expression.cs (Invocation.EmitArguments): When calling a varargs
10419 function with only its fixed arguments, we need to pass an empty
10422 2002-07-27 Martin Baulig <martin@gnome.org>
10424 Mono 0.13 has been released.
10426 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10428 * driver.cs: Rename --resource to --linkres, because that is what
10429 we do currently, we dont support --resource yet.
10431 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10433 2002-07-25 Martin Baulig <martin@gnome.org>
10435 * class.cs (MethodData): New public class. This is a `method builder'
10436 class for a method or one accessor of a Property/Indexer/Event.
10437 (MethodData.GetMethodFlags): Moved here from MemberBase.
10438 (MethodData.ApplyAttributes): Likewise.
10439 (MethodData.ApplyObsoleteAttribute): Likewise.
10440 (MethodData.ApplyConditionalAttribute): Likewise.
10441 (MethodData.ApplyDllImportAttribute): Likewise.
10442 (MethodData.CheckAbstractAndExternal): Likewise.
10443 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10444 (MethodData.Emit): Formerly known as Method.Emit().
10445 (MemberBase): Moved everything which was specific to a single
10446 accessor/method to MethodData.
10447 (Method): Create a new MethodData and call Define() and Emit() on it.
10448 (Property, Indexer, Event): Create a new MethodData objects for each
10449 accessor and call Define() and Emit() on them.
10451 2002-07-25 Martin Baulig <martin@gnome.org>
10453 Made MethodCore derive from MemberBase to reuse the code from there.
10454 MemberBase now also checks for attributes.
10456 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10457 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10459 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10460 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10461 (MemberBase.ApplyAttributes): New virtual method; applies the
10462 attributes to a method or accessor.
10463 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10464 (MemberBase.ApplyConditionalAttribute): Likewise.
10465 (MemberBase.ApplyDllImportAttribute): Likewise.
10466 (MemberBase.CheckAbstractAndExternal): Likewise.
10467 (MethodCore.ParameterTypes): This is now a property instead of a
10468 method, it's initialized from DoDefineParameters().
10469 (MethodCore.ParameterInfo): Removed the set accessor.
10470 (MethodCore.DoDefineParameters): New protected virtual method to
10471 initialize ParameterTypes and ParameterInfo.
10472 (Method.GetReturnType): We can now simply return the MemberType.
10473 (Method.GetMethodFlags): Override the MemberBase version and add
10474 the conditional flags.
10475 (Method.CheckBase): Moved some code from Define() here, call
10476 DoDefineParameters() here.
10477 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10478 here to avoid some larger code duplication.
10479 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10480 ensure that abstract and external accessors don't declare a body.
10482 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10483 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10484 lookup in the attribute's parent classes, so we need to abort as soon
10485 as we found the first match.
10486 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10487 the attribute has no arguments.
10489 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10492 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10494 * cs-parser.jay: reverted previous patch.
10496 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10498 * cs-parser.jay: fixed bug #22119.
10500 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10502 * attribute.cs: fixed compilation. The error was:
10503 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10504 be assigned to before control leaves the current method."
10505 [FIXME: Filed as bug #28186: MCS must report this error.]
10507 2002-07-25 Martin Baulig <martin@gnome.org>
10509 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10510 method to pull the condition name ouf of a Conditional attribute.
10511 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10512 the obsolete message and error flag out of an Obsolete attribute.
10514 * class.cs (Method.GetMethodFlags): New public method to get the
10515 TypeManager.MethodFlags for this method.
10516 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10518 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10519 if we're overriding a virtual function, set the new private variable
10520 `parent_method'; call the new TypeManager.AddMethod().
10522 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10523 the MethodBuilder and the Method in a PtrHashtable.
10524 (TypeManager.builder_to_method): Added for this purpose.
10525 (TypeManager.MethodFlags): Added IsObsoleteError.
10526 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10527 Obsolete and Conditional arguments in MethodBuilders. If we discover
10528 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10529 the message from the attribute.
10531 2002-07-24 Martin Baulig <martin@gnome.org>
10533 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10534 preprocessor directives, ensure that the argument to #define/#undef is
10535 exactly one identifier and that it's actually an identifier.
10537 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10540 2002-07-24 Martin Baulig <martin@gnome.org>
10542 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10543 initialize it to TypeManager.object_type in the constructor.
10544 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10545 of the `hm.get_current' method if we're using the collection pattern.
10546 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10547 for the explicit conversion to make it work when we're using the collection
10548 pattern and the `Current' property has a different return type than `object'.
10551 2002-07-24 Martin Baulig <martin@gnome.org>
10553 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10554 does not match, but don't report any errors. This method is called in
10555 order for all methods in a MethodGroupExpr until a matching method is
10556 found, so we don't want to bail out if the first method doesn't match.
10557 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10558 matches, report the 123. Fixes #28070.
10560 2002-07-24 Martin Baulig <martin@gnome.org>
10562 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10563 TypeManager.TypeToCoreType() to the top of the method so the
10564 following equality checks will work. Fixes #28107.
10566 2002-07-24 Martin Baulig <martin@gnome.org>
10568 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10569 operand is of type uint, and the other operand is of type sbyte,
10570 short or int, the operands are converted to type long." -
10571 Actually do what this comment already told us. Fixes bug #28106,
10574 2002-07-24 Martin Baulig <martin@gnome.org>
10576 * class.cs (MethodBase): New abstract class. This is now a base
10577 class for Property, Indexer and Event to avoid some code duplication
10578 in their Define() and DefineMethods() methods.
10579 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10580 generic methods for Define() and DefineMethods().
10581 (FieldBase): Derive from MemberBase, not MemberCore.
10582 (Property): Derive from MemberBase, not MemberCore.
10583 (Property.DefineMethod): Moved all the code from this method to the
10584 new MethodBase.DefineAccessor(), just call it with appropriate
10586 (Property.Define): Call the new Property.DoDefine(), this does some
10587 sanity checks and we don't need to duplicate the code everywhere.
10588 (Event): Derive from MemberBase, not MemberCore.
10589 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10590 accessors, this will also make them work with interface events.
10591 (Indexer): Derive from MemberBase, not MemberCore.
10592 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10593 (Indexer.Define): Use the new MethodBase functions.
10595 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10596 argument to the constructor.
10597 (Interface.FindMembers): Added support for interface events.
10598 (Interface.PopluateEvent): Implemented.
10600 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10602 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10604 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10605 but this is required to check for a method name being the same as
10606 the containing class.
10610 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10612 * interface.cs: initialize variable.
10614 2002-07-23 Martin Baulig <martin@gnome.org>
10616 Implemented the IndexerName attribute in interfaces.
10618 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10619 name if this is an explicit interface implementation.
10620 (Indexer.InterfaceIndexerName): New public variable. If we're
10621 implementing an interface indexer, this is the IndexerName in that
10622 interface. Otherwise, it's the IndexerName.
10623 (Indexer.DefineMethod): If we're implementing interface indexer,
10624 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10625 and Pending.ImplementIndexer methods.
10626 (Indexer.Define): Also define the PropertyBuilder if we're
10627 implementing an interface indexer and this is neither an explicit
10628 interface implementation nor do the IndexerName match the one in
10631 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10632 If a method is defined here, then we always need to create a proxy
10633 for it. This is used when implementing interface indexers.
10634 (Pending.IsInterfaceIndexer): New public method.
10635 (Pending.ImplementIndexer): New public method.
10636 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10637 This is used when implementing interface indexers to define a proxy
10639 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10640 define a proxy if necessary.
10642 * interface.cs (Interface.IndexerName): New public variable.
10643 (Interface.PopulateIndexer): Set the IndexerName.
10644 (Interface.DefineIndexers): New private method. Populate all the
10645 indexers and make sure their IndexerNames match.
10647 * typemanager.cs (IndexerPropertyName): Added support for interface
10650 2002-07-22 Martin Baulig <martin@gnome.org>
10652 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10653 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10654 ret if HasReturnLabel.
10655 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10658 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10659 and set the ec.LoopBeginTryCatchLevel.
10660 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10661 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10662 the current ec.TryCatchLevel, the branch goes out of an exception
10663 block. In this case, we need to use Leave and not Br.
10665 2002-07-22 Martin Baulig <martin@gnome.org>
10667 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10668 block unless the block does not always return or it is contained in
10669 another try { ... } catch { ... } block. Fixes bug #26506.
10670 Added verify-1.cs to the test suite.
10672 2002-07-22 Martin Baulig <martin@gnome.org>
10674 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10675 then we do not always return. Fixes bug #24985.
10677 2002-07-22 Martin Baulig <martin@gnome.org>
10679 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10680 lookup on a per-class level; ie. walk up the class hierarchy until we
10681 found at least one applicable method, then choose the best among them.
10682 Fixes bug #24463 and test-29.cs.
10684 2002-07-22 Martin Baulig <martin@gnome.org>
10686 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10687 return types of the methods. The return type is not part of the
10688 signature and we must not check it to make the `new' modifier work.
10689 Fixes bug #27999, also added test-147.cs.
10690 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10692 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10693 on the method's return type.
10695 2002-07-21 Martin Baulig <martin@gnome.org>
10697 * assign.cs: Make this work if the rightmost source is a constant and
10698 we need to do an implicit type conversion. Also adding a few more tests
10699 to test-38.cs which should have caught this.
10701 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10702 target in the makefile for this. The makefile.gnu is primarily intended
10703 for end-users who don't want to debug the compiler.
10705 2002-07-21 Martin Baulig <martin@gnome.org>
10707 * assign.cs: Improved the Assign class so it can now handle embedded
10708 assignments (X = Y = Z = something). As a side-effect this'll now also
10709 consume less local variables. test-38.cs now passes with MCS, added
10710 a few new test cases to that test.
10712 2002-07-20 Martin Baulig <martin@gnome.org>
10714 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10715 instructions. Fixes bug #27977, also added test-146.cs.
10717 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10719 * cs-tokenizer.cs: fixed getHex ().
10721 2002-07-19 Martin Baulig <martin@gnome.org>
10723 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10724 not Type.GetType() to lookup the array type. This is needed when
10725 we're constructing an array of a user-defined type.
10726 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10727 single-dimensional arrays, but also for single-dimensial arrays of
10730 2002-07-19 Martin Baulig <martin@gnome.org>
10732 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10733 this function is called, it's not allowed to share LocalBuilders
10734 among ILGenerators.
10736 2002-07-19 Martin Baulig <martin@gnome.org>
10738 * expression.cs (Argument.Resolve): Report an error 118 when trying
10739 to pass a type as argument.
10741 2002-07-18 Martin Baulig <martin@gnome.org>
10743 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10744 Conv_R_Un for the signed `long' type.
10746 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10748 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10749 `expr' for the temporary result, as that will fail if we do
10750 multiple resolves on the same expression.
10752 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10754 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10755 ec.TypeContainer for looking up aliases.
10757 * class.cs (TypeContainer): Remove LookupAlias from here.
10759 * decl.cs (DeclSpace); Move here.
10761 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10763 * class.cs (FindMembers): Only call filter if the constructor
10764 bulider is not null.
10766 Also handle delegates in `NestedTypes' now. Now we will perform
10767 type lookups using the standard resolution process. This also
10770 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10771 This uses Expressions (the limited kind that can be parsed by the
10772 tree) instead of strings.
10774 * expression.cs (ComposedCast.ToString): Implement, used to flag
10775 errors since now we have to render expressions.
10777 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10780 * ecore.cs (SimpleName.ToString): ditto.
10782 * cs-parser.jay: Instead of using strings to assemble types, use
10783 Expressions to assemble the type (using SimpleName, ComposedCast,
10784 MemberAccess). This should fix the type lookups in declarations,
10785 because we were using a different code path for this.
10787 * statement.cs (Block.Resolve): Continue processing statements
10788 even when there is an error.
10790 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10792 * class.cs (Event.Define): Also remove the `remove' method from
10793 the list of pending items.
10795 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10796 generate more compact code.
10798 2002-07-17 Martin Baulig <martin@gnome.org>
10800 * const.cs (Const.LookupConstantValue): Add support for constant
10801 `unchecked' and `checked' expressions.
10802 Also adding test case test-140.cs for this.
10804 2002-07-17 Martin Baulig <martin@gnome.org>
10806 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10807 check whether mi.ReturnType implements the IEnumerator interface; the
10808 `==' and the IsAssignableFrom() will fail in this situation.
10810 2002-07-16 Ravi Pratap <ravi@ximian.com>
10812 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10815 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10817 * expression.cs: fixed bug #27811.
10819 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10821 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10822 Molaro: when we are a ref, the value already contains a pointer
10823 value, do not take the address of it.
10825 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10826 * removed mb-parser.jay and mb-tokenizer.cs
10828 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10830 * expression.cs: check against the building corlib void type.
10832 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10834 * ecore.cs: fix for valuetype static readonly fields: when
10835 initializing them, we need their address, not the address of a copy.
10837 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10839 * typemanager.cs: register also enum_type in corlib.
10841 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10843 * class.cs: allow calling this (but not base) initializers in structs.
10845 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10847 * ecore.cs: make sure we compare against the building base types
10850 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10852 * typemanager.cs: fix TypeToCoreType() to handle void and object
10853 (corlib gets no more typerefs after this change).
10855 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10857 * expression.cs (ArrayCreation.EmitArrayArguments): use
10858 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10860 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10861 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10862 array indexes, the runtime actually forbids them.
10864 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10865 for array arguments here.
10867 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10868 instead of the default for ValueTypes.
10870 (New.DoEmit): Use IsValueType instead of
10871 IsSubclassOf (value_type)
10872 (New.DoResolve): ditto.
10873 (Invocation.EmitCall): ditto.
10875 * assign.cs (Assign): ditto.
10877 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10878 Statements *are* currently doing part of their resolution during
10881 Expressions do always resolve during resolve, but statements are
10882 only required to propagate resolution to their children.
10884 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10886 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10888 (LoadAssembly): Do not add the dll if it is already specified
10890 (MainDriver): Add the System directory to the link path at the end,
10891 after all the other -L arguments.
10893 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10894 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10895 ldelem.u1) and using the opposite for sbytes.
10897 This fixes Digger, and we can finally run it.
10899 * driver.cs (UnixParseOption): Move the option parsing here.
10900 (CSCParseOption): Implement CSC-like parsing of options.
10902 We now support both modes of operation, the old Unix way, and the
10903 new CSC-like way. This should help those who wanted to make cross
10904 platform makefiles.
10906 The only thing broken is that /r:, /reference: and /lib: are not
10907 implemented, because I want to make those have the same semantics
10908 as the CSC compiler has, and kill once and for all the confussion
10909 around this. Will be doing this tomorrow.
10911 * statement.cs (Unsafe.Resolve): The state is checked during
10912 resolve, not emit, so we have to set the flags for IsUnsfe here.
10914 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10916 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10917 not catch the Error_ObjectRefRequired in SimpleName (as it is
10918 possible to have a class/instance variable name that later gets
10919 deambiguated), we have to check this here.
10921 2002-07-10 Ravi Pratap <ravi@ximian.com>
10923 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10924 make static and put into Expression.
10926 (Event.Define): Register the private field of the event with the
10927 TypeManager so that GetFieldFromEvent can get at it.
10929 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10930 keep track of the private field associated with an event which
10933 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10936 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10938 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10940 * expression.cs (Binary.EmitBranchable): this routine emits the
10941 Binary expression in a branchable context. This basically means:
10942 we need to branch somewhere, not just get the value on the stack.
10944 This works together with Statement.EmitBoolExpression.
10946 * statement.cs (Statement.EmitBoolExpression): Use
10949 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10951 * statement.cs (For): Reduce the number of jumps in loops.
10953 (For): Implement loop inversion for the For statement.
10955 (Break): We can be breaking out of a Try/Catch controlled section
10956 (foreach might have an implicit try/catch clause), so we need to
10957 use Leave instead of Br.
10959 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10960 now). If the instace expression supports IMemoryLocation, we use
10961 the AddressOf method from the IMemoryLocation to extract the
10962 address instead of emitting the instance.
10964 This showed up with `This', as we were emitting the instance
10965 always (Emit) instead of the Address of This. Particularly
10966 interesting when This is a value type, as we dont want the Emit
10967 effect (which was to load the object).
10969 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10971 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10973 * statement.cs (Checked): Set the CheckedState during the resolve
10974 process too, as the ConvCast operations track the checked state on
10975 the resolve process, and not emit.
10977 * cs-parser.jay (namespace_member_declaration): Flag that we have
10978 found a declaration when we do. This is used to flag error 1529
10980 * driver.cs: Report ok when we display the help only.
10982 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10984 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10986 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10988 * cs-tokenizer.cs (define): We also have to track locally the
10989 defines. AllDefines is just used for the Conditional Attribute,
10990 but we also need the local defines for the current source code.
10992 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10994 * statement.cs (While, For, Do): These loops can exit through a
10995 Break statement, use this information to tell whether the
10996 statement is the last piece of code.
10998 (Break): Flag that we break.
11000 * codegen.cs (EmitContexts): New `Breaks' state variable.
11002 2002-07-03 Martin Baulig <martin@gnome.org>
11004 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11005 modifiers in method declarations in structs. Otherwise, you won't
11006 be able to override things like Object.Equals().
11008 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11010 * class.cs (Method, Property, Indexer): Do not allow the public
11011 modifier to be used in explicit interface implementations.
11013 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11014 override modifiers in method declarations in structs
11016 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11018 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11019 integer or real overflow, report an error
11021 2002-07-02 Martin Baulig <martin@gnome.org>
11023 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11024 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11025 to tell the runtime about our newly created System.Object and
11026 System.ValueType types.
11028 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11030 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11031 struct instead of Ldarg/Starg.
11033 2002-07-02 Martin Baulig <martin@gnome.org>
11035 * expression.cs (Indirection.Indirection): Call
11036 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11038 2002-07-02 Martin Baulig <martin@gnome.org>
11040 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11041 ValueType, call TypeManager.TypeToCoreType() on it.
11042 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11043 the OpCodes.Newarr argument.
11045 2002-07-02 Martin Baulig <martin@gnome.org>
11047 * expression.cs (Invocation.EmitCall): When compiling corlib,
11048 replace all calls to the system's System.Array type to calls to
11049 the newly created one.
11051 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11052 System.Array methods.
11053 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11054 from the system's System.Array type which must be replaced.
11056 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11058 * typemanager.cs: load unverifiable_code_ctor so we can build
11059 corlib using the correct type. Avoid using GetTypeCode() with
11061 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11062 TypeManager.object_type to allow building corlib.
11064 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11066 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11068 2002-07-01 Martin Baulig <martin@gnome.org>
11070 * class.cs: Make the last change actually work, we need to check
11071 whether `ifaces != null' to avoid a crash.
11073 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11075 * class.cs: when we build structs without fields that implement
11076 interfaces, we need to add the interfaces separately, since there is
11077 no API to both set the size and add the interfaces at type creation
11080 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11082 * expression.cs: the dimension arguments to the array constructors
11083 need to be converted if they are a long.
11085 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11087 * class.cs: don't emit ldarg.0 if there is no parent constructor
11088 (fixes showstopper for corlib).
11090 2002-06-29 Martin Baulig <martin@gnome.org>
11092 MCS now compiles corlib on GNU/Linux :-)
11094 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11095 ie. check for MethodImplOptions.InternalCall.
11097 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11098 and TypeManager.attribute_type are null, so we must explicitly check
11099 whether parent is not null to find out whether it's an attribute type.
11100 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11101 and SetBuilder, not only if the property is neither abstract nor external.
11102 This is necessary to set the MethodImplOptions on the accessor methods.
11103 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11104 SetBuilder, see Property.Emit().
11106 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11107 populate "System.Object", "System.ValueType" and "System.Attribute" since
11108 they've already been populated from BootCorlib_PopulateCoreTypes().
11110 2002-06-29 Martin Baulig <martin@gnome.org>
11112 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11113 is the NullLiteral, we also need to make sure that target_type is not
11116 2002-06-29 Martin Baulig <martin@gnome.org>
11118 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11119 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11120 before calling BootstrapCorlib_ResolveDelegate ().
11122 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11124 * statement.cs: fixed build-breaker. All tests passed ok.
11126 2002-06-27 Martin Baulig <martin@gnome.org>
11128 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11129 for System.Decimal when compiling corlib.
11131 2002-06-27 Martin Baulig <martin@gnome.org>
11133 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11134 switch blocks which contain nothing but a default clause.
11136 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11138 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11140 2002-06-27 Martin Baulig <martin@gnome.org>
11142 * ecore.cs (PropertyExpr.PropertyExpr): Call
11143 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11145 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11146 is already a TypeBuilder.
11148 2002-06-27 Martin Baulig <martin@gnome.org>
11150 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11151 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11152 the "from an array-type to System.Array" case. This makes it work
11153 when compiling corlib.
11155 2002-06-27 Martin Baulig <martin@gnome.org>
11157 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11158 non-static PropertyExpr, set its InstanceExpression. This makes
11159 the `ICollection.Count' property work in System/Array.cs.
11161 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11163 * driver.cs: Made error handling more consistent. Errors now
11164 tracked by Report class, so many methods which used to return int
11165 now return void. Main() now prints success/failure and
11166 errors/warnings message.
11168 Renamed '--probe' compiler argument to '--expect-error'. Removed
11169 the magic number return values (123 and 124). Now, if the
11170 expected error occurs, the compiler exits with success (exit value
11171 0). If the compilation completes without seeing that particular
11172 error, the compiler exits with failure (exit value 1). The
11173 makefile in mcs/errors has been changed to handle the new behaviour.
11175 * report.cs: Made 'expected error' number a property and renamed
11176 it from 'Probe' to 'ExpectedError'.
11178 * genericparser.cs: Removed error handling support, since it is
11179 now all done by Report class.
11181 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11182 class, so parse() no longer returns an int.
11184 * namespace.cs: Use Report.Error instead of GenericParser.error
11186 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11188 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11189 TypeContainer.AddOperator): At the front of the list put the
11190 explicit implementations, so they get resolved/defined first.
11192 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11194 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11195 interface type is implemented by this TypeContainer. Used during
11196 explicit interface implementation.
11198 (Property.Define, Indexer.Define, Method.Define): Validate that
11199 the given interface in the explicit implementation is one of the
11200 base classes for the containing type.
11202 Also if we are explicitly implementing an interface, but there is
11203 no match in the pending implementation table, report an error.
11205 (Property.Define): Only define the property if we are
11206 not explicitly implementing a property from an interface. Use the
11207 correct name also for those properties (the same CSC uses,
11208 although that is really not needed).
11210 (Property.Emit): Do not emit attributes for explicitly implemented
11211 properties, as there is no TypeBuilder.
11213 (Indexer.Emit): ditto.
11215 Hiding then means that we do not really *implement* a pending
11216 implementation, which makes code fail.
11218 2002-06-22 Martin Baulig <martin@gnome.org>
11220 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11221 the return value of Object.GetType(). [FIXME: we need to do this whenever
11222 we get a type back from the reflection library].
11224 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11226 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11228 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11230 * attribute.cs: Return null if we can not look up the type.
11232 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11233 the interface types found.
11235 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11236 interface types found.
11238 * typemanager.cs (GetInterfaces): Make this routine returns alll
11239 the interfaces and work around the lame differences between
11240 System.Type and System.Reflection.Emit.TypeBuilder in the results
11241 result for GetInterfaces.
11243 (ExpandInterfaces): Given an array of interface types, expand and
11244 eliminate repeated ocurrences of an interface. This expands in
11245 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11248 2002-06-21 Martin Baulig <martin@gnome.org>
11250 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11253 2002-06-21 Martin Baulig <martin@gnome.org>
11255 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11256 and called with one of the core types, return the corresponding typebuilder for
11259 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11262 2002-06-21 Martin Baulig <martin@gnome.org>
11264 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11265 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11266 (Expression.ConvertReferenceExplicit): Likewise.
11268 * expression.cs (ElementAccess.DoResolve): Likewise.
11269 (ElementAccess.DoResolveLValue): Likewise.
11271 2002-06-10 Martin Baulig <martin@gnome.org>
11273 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11274 add the "value" parameter to the parameter list.
11276 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11279 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11281 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11282 the argument to an int, uint, long or ulong, per the spec. Also
11283 catch negative constants in array creation.
11285 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11287 * class.cs: do not allow the same interface to appear twice in
11288 the definition list.
11290 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11292 * ecore.cs: don't use ldlen with System.Array.
11294 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11296 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11298 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11300 * modifiers.cs: produce correct field attributes for protected
11301 internal. Easy fix so miguel can work on ther harder stuff:-)
11303 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11305 * pending.cs: New file. Move the code from class.cs here.
11306 Support clearning the pending flag for all methods (when not doing
11307 explicit interface implementation).
11309 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11311 * rootcontext.cs: added a couple more types needed to bootstrap.
11313 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11315 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11316 constructor in the type, instead of any constructor in the type
11317 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11318 a bug in the Mono runtime when applying the params attribute).
11320 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11321 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11323 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11325 * expression.cs (Unary.ResolveOperator): Use TypeManager
11326 to resolve the type.
11328 2002-06-13 Ravi Pratap <ravi@ximian.com>
11330 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11333 * enum.cs (AddEnumMember): Add support to store the attributes associated
11334 with each member too.
11336 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11337 field builders too - this takes care of the enum member case.
11339 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11341 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11342 address-of operator on both value types and pointers.
11344 2002-06-10 Martin Baulig <martin@gnome.org>
11346 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11347 PropertyBuilder to the `property_builders' list.
11349 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11350 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11351 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11352 find any indexers which are inherited from an interface.
11354 2002-06-09 Martin Baulig <martin@gnome.org>
11356 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11357 the same type as the constant if necessary. There's also a test-130.cs
11360 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11362 * typemanager.cs (TypeManager.ChangeType): Previously known as
11363 Enum.ChangeEnumType().
11365 2002-06-09 Martin Baulig <martin@gnome.org>
11367 * expression.cs (Cast.TryReduce): Added support for consts.
11369 2002-06-08 Ravi Pratap <ravi@ximian.com>
11371 * class.cs (Accessor): Hold attributes information so we can pass
11374 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11375 Modify to pass in attributes attached to the methods.
11377 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11379 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11380 to handle the Accessor kind :-)
11382 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11384 2002-06-08 Martin Baulig <martin@gnome.org>
11386 * expression.cs (Unary.TryReduceNegative): Added support for
11389 2002-06-08 Martin Baulig <martin@gnome.org>
11391 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11392 name can't be found in the `defined_names' - the caller will do a
11393 MemberLookup in this case and thus find methods in System.Enum
11394 such as Enum.IsDefined().
11396 2002-06-08 Martin Baulig <martin@gnome.org>
11398 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11399 Convert.ChangeType() which works with TypeBuilder created types.
11400 (Enum.LookupEnumValue, Enum.Define): Use it here.
11402 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11403 `TypeBuilder.BaseType != null' check.
11404 (TypeContainer.FindMembers): Only lookup parent members if we
11405 actually have a parent.
11406 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11407 (ConstructorInitializer.Resolve): Likewise.
11409 * interface.cs (Interface.FindMembers): Added
11410 `TypeBuilder.BaseType != null' check.
11412 * rootcontext.cs (RootContext.ResolveCore): Added
11413 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11414 classes_second_stage.
11416 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11417 debug_type and trace_type when compiling with --nostdlib.
11419 2002-06-07 Martin Baulig <martin@gnome.org>
11421 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11422 (AddField): Set it to true when adding a non-static field.
11423 (DefineType): Use `have_nonstatic_fields' to find out whether we
11424 have non-static fields, not `Fields != null'.
11426 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11428 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11429 dereferencing a null on the static-field code path)
11431 2002-05-30 Martin Baulig <martin@gnome.org>
11433 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11434 to take command line arguments. Use reflection to call the new
11435 custom `Initialize' function on the symbol writer and pass it the
11436 command line arguments.
11438 * driver.cs (--debug-args): New command line argument to pass command
11439 line arguments to the symbol writer.
11441 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11443 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11444 the target type for indexers and properties. Thanks to Joe for
11447 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11449 * typemanager.cs (MethodFlags): returns the method flags
11450 (Obsolete/ShouldIgnore) that control warning emission and whether
11451 the invocation should be made, or ignored.
11453 * expression.cs (Invocation.Emit): Remove previous hack, we should
11454 not do this on matching a base type, we should do this based on an attribute
11456 Only emit calls to System.Diagnostics.Debug and
11457 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11458 on the command line.
11460 * rootcontext.cs: Global settings for tracing and debugging.
11462 * cs-tokenizer.cs (define): New utility function to track
11463 defines. Set the global settings for TRACE and DEBUG if found.
11465 2002-05-25 Ravi Pratap <ravi@ximian.com>
11467 * interface.cs (Populate*): Pass in the TypeContainer as well as
11468 the DeclSpace as parameters so that we can create EmitContexts and
11469 then use that to apply attributes etc.
11471 (PopulateMethod, PopulateEvent, PopulateProperty)
11472 (PopulateIndexer): Apply attributes everywhere.
11474 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11477 (ApplyAttributes): Update accordingly.
11479 We now apply interface attributes for all members too.
11481 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11483 * class.cs (Indexer.Define); Correctly check if we are explicit
11484 implementation (instead of checking the Name for a ".", we
11485 directly look up if the InterfaceType was specified).
11487 Delay the creation of the PropertyBuilder.
11489 Only create the PropertyBuilder if we are not an explicit
11490 interface implementation. This means that explicit interface
11491 implementation members do not participate in regular function
11492 lookups, and hence fixes another major ambiguity problem in
11493 overload resolution (that was the visible effect).
11495 (DefineMethod): Return whether we are doing an interface
11498 * typemanager.cs: Temporary hack until we get attributes in
11499 interfaces (Ravi is working on that) and we get IndexerName
11500 support in interfaces.
11502 * interface.cs: Register the indexers as properties.
11504 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11505 warning, I have verified that this is a bug in the .NET runtime
11506 (JavaScript suffers of the same problem).
11508 * typemanager.cs (MemberLookup): When looking up members for
11509 interfaces, the parent of an interface is the implicit
11510 System.Object (so we succeed in searches of Object methods in an
11511 interface method invocation. Example: IEnumerable x; x.ToString
11514 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11516 * class.cs (Event): Events should also register if they do
11517 implement the methods that an interface requires.
11519 * typemanager.cs (MemberLookup); use the new GetInterfaces
11522 (GetInterfaces): The code used to lookup interfaces for a type is
11523 used in more than one place, factor it here.
11525 * driver.cs: Track the errors at the bottom of the file, we kept
11528 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11529 instance if the method we are calling is static!
11531 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11533 * attribute.cs (ApplyAttributes): Make this function filter out
11534 the IndexerName attribute (as that attribute in reality is never
11535 applied) and return the string constant for the IndexerName
11538 * class.cs (TypeContainer.Emit): Validate that all the indexers
11539 have the same IndexerName attribute, and if so, set the
11540 DefaultName attribute on the class.
11542 * typemanager.cs: The return value might contain other stuff (not
11543 only methods). For instance, consider a method with an "Item"
11544 property and an Item method.
11546 * class.cs: If there is a problem with the parameter types,
11549 2002-05-24 Ravi Pratap <ravi@ximian.com>
11551 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11552 looks at user defined conversion after making a call to
11553 StandardConversionExists - we need this for overload resolution.
11555 * expression.cs : Update accordingly the various method calls.
11557 This fixes 2 bugs filed against implicit user defined conversions
11559 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11561 * statement.cs: Track the result of the assignment.
11563 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11565 * expression.cs (MemberAccess): Improved error reporting for
11566 inaccessible members.
11568 2002-05-22 Martin Baulig <martin@gnome.org>
11570 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11571 itself with debugging support.
11573 2002-05-22 Martin Baulig <martin@gnome.org>
11575 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11576 Removed, this isn't needed anymore.
11578 2002-05-20 Martin Baulig <martin@gnome.org>
11580 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11581 be underlying type for an enum.
11583 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11585 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11586 that splits out the loading of just the core types.
11588 * rootcontext.cs (ResolveCore): Split the struct resolution in
11589 two, so we can load the enumeration underlying types before any
11592 * expression.cs (Is): Bandaid until we fix properly Switch (see
11593 bug #24985 for details).
11595 * typemanager.cs (ImplementsInterface): The hashtable will contain
11596 a null if there are no interfaces implemented.
11598 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11600 * cs-parser.jay (indexer_declarator): It is fine to have array
11603 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11605 * typemanager.cs: (RegisterBuilder): New function used to register
11606 TypeBuilders that implement interfaces. Since
11607 TypeBuilder.GetInterfaces (as usual) does not work with lame
11609 (AddUserType): register interfaces.
11611 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11612 dealing with TypeBuilder. Also, arrays are showing up as
11613 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11614 methods can not be invoked on them!
11616 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11617 (ImplicitReferenceConversionExists): Split out from
11618 StandardConversionExists.
11620 * expression.cs (As): We were only implementing one of the three
11621 cases for the as operator. We now implement them all.
11622 (Is): Implement the various other cases for Is as well.
11624 * typemanager.cs (CACHE): New define used to control if we want or
11625 not the FindMembers cache. Seems to have a negative impact on
11626 performance currently
11628 (MemberLookup): Nested types have full acess to
11629 enclosing type members
11631 Remove code that coped with instance/static returns for events, we
11632 now catch this in RealFindMembers.
11634 (RealFindMembers): only perform static lookup if the instance
11635 lookup did not return a type or an event.
11637 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11639 * assign.cs (CompoundAssign): We pass more semantic information
11640 now to Compound Assignments than we did before: now we have all
11641 the information at hand, and now we resolve the target *before* we
11642 do the expression expansion, which allows the "CacheValue" method
11643 to have the effect we intended (before, a [x] += 1 would generate
11644 two differen ArrayAccess expressions from the ElementAccess,
11645 during the resolution process).
11647 (CompoundAssign.DoResolve): Resolve target and original_source here.
11649 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11651 * expression.cs (ArrayAccess): dropped debugging information.
11653 * typemanager.cs: Small bug fix: I was always returning i_members,
11654 instead of one of i_members or s_members (depending on which had
11657 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11658 method is invoked before any code generation takes place, and it
11659 is a mechanism to inform that the expression will be invoked more
11660 than once, and that the method should use temporary values to
11661 avoid having side effects
11663 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11665 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11668 * expression.cs (Indirection, ArrayAccess): Add support for
11669 CacheTemporaries in these two bad boys.
11671 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11672 ldobj or ldind_ref.
11673 (StoreFromPtr): Handle stobj as well.
11675 * expression.cs (UnaryMutator): Share more code.
11677 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11678 down: I was not tracking the Filter function as well, which
11679 was affecting the results of the cache.
11681 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11683 * attribute.cs: Remove the hack to handle the CharSet property on
11686 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11688 * attribute.cs (DoResolve): More uglyness, we now only try to
11689 resolve the attribute partially, to extract the CharSet
11690 information (only if we are a StructLayout attribute). Otherwise
11692 (GetExtraTypeInfo): Add some code to conditionally kill in the
11693 future this. I am more and more convinced that the .NET
11694 framework has special code to handle the attribute setting on
11697 * expression.cs (IsParamsMethodApplicable): Revert my previous
11698 foreach change here, it was wrong.
11700 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11702 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11703 (pp_expr): do not abort on unknown input, just return.
11704 (eval): abort if there are pending chars.
11706 * attribute.cs (Attribute.Resolve): Positional parameters are
11707 optional. Deal with that case.
11709 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11710 the Ansi/Unicode/Auto information for the type.
11712 (TypeContainer.DefineType): instantiate the EmitContext here, as
11713 we will be using it during the type definition (to resolve
11714 attributes) and during the emit phase.
11716 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11717 to pull type information out of the attributes
11719 (Attribute.Resolve): track the constructor builder, and allow for
11720 multiple invocations (structs and classes will use this).
11722 * ecore.cs (MemberLookupFinal): new version with all the
11723 parameters customizable.
11725 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11726 constructors. Return if the result value is null (as the error
11727 would have been flagged already by MemberLookupFinal)
11729 Do not allow instances of abstract classes or interfaces to be
11732 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11733 We have to compare the assembly property here when dealing with
11734 FamANDAssem and Assembly access modifiers, because we might be
11735 creating an assembly from *modules* (that means that we are not
11736 getting TypeBuilders for types defined in other modules that are
11737 part of this assembly).
11739 (Method.Emit): If the method is marked abstract and has a body,
11742 (TypeContainer.DefineMembers): If both the defined member and the
11743 parent name match are methods, then do not emit any warnings: let
11744 the Method.Define routine take care of flagging warnings. But if
11745 there is a mismatch (method overrides something else, or method is
11746 overriwritten by something, then emit warning).
11748 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11749 set to null, this means `do not check for the return type on the
11752 (Method.Define): set the return type for the method signature to
11753 null, so that we get methods with the same name and parameters and
11754 different return types. This is used to flag warning 114 (you are
11755 hiding a method, and you probably want to use the new/override
11758 * typemanager.cs (MemberLookup): Implemented proper access
11759 control, closing a long standing set of bug reports. The problem
11760 was that the Framework only has two bits: Public and NonPublic,
11761 and NonPublic includes private and protected methods, but we need
11762 to enforce the FamANDAssem, FamOrAssem and Family.
11764 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11766 * statement.cs (GotoCase): Return true: Ammounts to giving up
11767 knowledge on whether we return or not, and letting the other case
11768 be responsible for it.
11770 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11772 * driver.cs: Do not load directories for each file processed, only
11773 do it if there is a pattern.
11775 * ecore.cs: Report readonly assigns here as well, as we might have
11776 been resolved only by MemberAccess.
11778 (SimpleName.SimpleNameResolve): Also be useful for LValue
11779 resolution. We need this to propagate assign to local readonly variables
11781 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11782 do not want to reuse potential criteria memory.
11784 * class.cs (MyEventBuilder): Set reflected_type;
11786 * ecore.cs (Constantify): Added support for constifying bools.
11788 (RootContext.LookupType): Added a cache for values looked up in
11789 the declaration space.
11791 * typemanager.cs (FindMembers): Now is a front-end to
11792 RealFindMembers, and provides a two-level hashtable-based cache to
11795 15% performance improvement: from 22.5 to 19.2 seconds.
11797 * expression.cs (IsParamsMethodApplicable): use foreach.
11798 (Invocation.DoResolve): ditto.
11799 (New.DoResolve): ditto.
11800 (ArrayCreation.DoResolve): ditto.
11802 * ecore.cs (FindMostEncompassingType): use foreach.
11804 * delegate.cs (NewDelegate.DoResolve): Use foreach
11806 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11807 (RemoveMethods): use foreach.
11809 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11810 nested foreach statements instead of for, and also break out of
11811 the inner loop once a match is found.
11813 (Invocation.OverloadResolve): Use foreach, simplify the code.
11815 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11817 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11818 we actually unwrap the expression to allow for extra information
11821 * expression.cs: Use Shr_Un on unsigned operations.
11823 2002-05-08 Ravi Pratap <ravi@ximian.com>
11825 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11826 applicable operators was not being considered correctly. This closes
11827 the bug Miguel reported.
11829 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11831 * attribute.cs: check that the type derives from System.Attribute
11832 and report the correct error in that case (moved the duplicate code to
11833 its own method, too).
11835 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11837 * attribute.cs: lookup attribute type name as the spec says: first the
11838 bare attribute name and then name + "Attribute" (nant compiles with
11839 mcs after this fix).
11841 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11843 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11844 Because of the way we parse things, we should try to see if a
11845 UIntConstant can fit in an integer.
11847 2002-05-07 Ravi Pratap <ravi@ximian.com>
11849 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11850 when we are in an explicit context.
11852 (ConvertReferenceExplicit): When converting from Iface type S to Class
11853 T make sure the rules are implemented as an OR.
11855 * parameter.cs (ParameterType): Make it a property for now although the
11856 purpose really isn't anything immediate.
11858 * expression.cs (Is*Applicable): Do better checking on the parameter type
11859 of a ref/out parameter. The ones from the system assemblies are already
11860 marked with the correct type so we don't need to do any correction.
11862 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11863 the object type is standard too so include that.
11865 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11867 * ecore.cs (StandardConversionExists): Augment with missing code:
11868 deal with IntConstant, LongConstants and Enumerations.
11870 * assign.cs: Report the error, instead of failing silently
11872 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11873 typecontainer that they are declared, because the
11874 typecontainer/namespace will have the list of using clauses that
11875 need to be applied.
11877 Assembly Attributes were escaping the normal registration
11880 (EmitCode): Apply attributes within an EmitContext that represents
11881 the container they were declared on.
11883 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11885 2002-05-06 Ravi Pratap <ravi@ximian.com>
11887 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11888 Revamp completely - make much cleaner as we now operate only
11891 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11892 to implement the logic detailed in the spec more correctly.
11894 (UserDefinedConversion): Update accordingly.
11896 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11898 * statement.cs: Return flow analysis information up.
11900 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11903 (token): Do not consume an extra character before calling
11906 2002-05-06 Piers Haken <piersh@friskit.com>
11908 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11910 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11912 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11913 EmitContext during the instance constructor initializer
11914 resolution, to stop access to instance variables.
11916 This is mandated by the spec, last paragraph of the `constructor
11917 initializers' section.
11919 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11921 * cs-parser.jay, class.cs (Accessor): new class used to represent
11922 an accessor (get or set). In the past we used `null' to represent
11923 a missing accessor. But this is ambiguous because there was no
11924 way to tell in abstract indexers/properties if one of them was
11927 Now there is a way of addressing that.
11929 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11930 instead of FindMembers.
11932 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11933 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11935 * attribute.cs: Treat indexers and properties as the same in terms
11936 of applying attributes
11938 * ecore.cs (FindMostEncompassedType): Use statically initialized
11939 EmptyExpressions()s like we do elsewhere to avoid creating useless
11940 objects (and we take this out of the tight loop).
11942 (GetConversionOperators): Move the code to extract the actual
11943 operators to a separate routine to clean things up.
11945 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11947 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11948 events are always registered FieldBuilders.
11950 * class.cs (FieldBase): New class shared by Fields
11952 * delegate.cs: If we are a toplevel delegate, use our full name.
11953 If we are a nested delegate, then only use our tail name.
11955 2002-05-02 Ravi Pratap <ravi@ximian.com>
11957 * expression.cs (IsApplicable): Ensure that we add the "&" to
11958 ref/out types before comparing it with the type of the argument.
11960 (IsParamsMethodApplicable): Ditto.
11962 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11965 * delegate.cs : Handle the case when we have more than one applicable
11966 method. Flag an error only when we finish checking all.
11968 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11970 * expression.cs: Add support for boolean static initializers.
11972 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11974 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11976 * parameter.cs (ComputeParameterTypes,
11977 ComputeAndDefineParameterTypes): Better error handling: now we
11978 clear the `types' cache if we fail during any of the type lookups.
11979 We also return the status code correctly to our caller
11981 * delegate.cs: If we fail to define a delegate, abort the extra
11984 * expression.cs (Binary.ResolveOperator): for
11985 operator==(object,object) and operator !=(object, object) we also
11986 have to verify that there is an implicit conversion from one to
11989 (ArrayAccess.DoResolve): Array Access can operate on
11992 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11994 * assign.cs (CompoundAssign): A new class used as a "flag" that
11995 the assignment actually is happening as part of a compound
11996 assignment operator.
11998 During compound assignment, a few new rules exist to enable things
12005 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12006 to the type of x) if y is implicitly convertible to the type of x,
12007 and the operator is a builtin operator and the return type of the
12008 operator is explicitly convertible to the type of x.
12010 * rootcontext.cs: Reset warning level to 2. 4 catches various
12011 "interesting" features in mcs, we must clean this up at some
12012 point, but currently am trying to kill other bugs ;-)
12014 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12015 in container classes as well.
12017 * expression.cs (Binary.ResolveOperator): Handle string case
12018 before anything else (as operator overloading does emit an error
12019 before doing anything else).
12021 This code could go away when we move to a table driven model, but
12022 i could not come up with a good plan last night.
12024 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12026 * typemanager.cs (CSharpName): reimplementation using regex.
12027 * class.cs: added null check for fields in Emit
12028 * rootcontext.cs: set warninglevel to 4
12030 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12032 * typemanager.cs (CSharpName): reimplemented with Lupus
12035 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12037 * statement.cs (If): correclty implement Resolve, because we were
12038 not catching sem errors in there. The same process is needed
12040 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12043 (Statement.Warning_DeadCodeFound): Factorize code.
12044 (While): Report dead code here too.
12046 (Statement): Added Resolve virtual method to allow
12047 for resolution split from the emit code.
12049 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12051 * statement.cs (EmitBoolExpression): No longer try to resolve the
12053 (MakeBoolean): New utility function that resolve, implicitly
12054 converts to boolean and tags the expression.
12057 (If, Do): Implement dead code elimination.
12058 (While): Implement loop inversion
12060 (Do, While, For, If): Resolve the expression prior to calling our
12063 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12066 - added method Report28 (warning: program has more than one entry point)
12067 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12068 - modified method Method.Define, the part at the end of the method
12070 * rootcontext.cs: added static public Location EntryPointLocation;
12072 * ../errors/cs0028.cs : Add test case for the above warning.
12075 - modified method CSharpName to allow arrays of primitive type to
12076 be printed nicely (e.g. instead of System.Int32[][] it now prints
12078 - added method CSharpSignature: returns the signature of a method
12079 in string format to be used in reporting errors, warnings, etc.
12081 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12084 2002-04-26 Ravi Pratap <ravi@ximian.com>
12086 * delegate.cs (Define): Fix extremely silly bug where I was
12087 setting the type of the 'object' parameter of the BeginInvoke
12088 method to System.IAsyncResult instead of System.Object ;-)
12090 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12092 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12095 (Constructor.Emit): return if we fail to initialize the
12096 constructor. Another door closed!
12098 * expression.cs (New.DoResolve): Improve error message (from -6 to
12099 1501). Use DeclaredOnly lookup to find the exact constructor.
12101 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12102 loop. This is useful.
12104 * cs-parser.jay: Adjust the default parameters so that destructors
12105 have the proper signature.
12107 2002-04-26 Martin Baulig <martin@gnome.org>
12109 * driver.cs (LoadAssembly): If `assembly' contains any characters
12110 which are only valid in path names and not in assembly names
12111 (currently slash, backslash and point), use Assembly.LoadFrom ()
12112 instead of Assembly.Load () on the `assembly' (before iteration
12113 over the link_paths).
12115 2002-04-26 Martin Baulig <martin@gnome.org>
12117 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12119 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12121 * class.cs (Property): use the new typemanager.MemberLookup
12123 (TypeContainer.MemberLookup): Implement using the
12124 TypeManager.MemberLookup now.
12126 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12127 and return MemberInfos, so that these can be used without an
12128 EmitContext (what we had before).
12130 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12132 * expression.cs: Fix the case where the argument to params if the
12133 type of the params. I omitted handling this before. Fixed
12135 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12137 * driver.cs: Call BootCorlib_PopulateCoreType
12139 * class.cs (Property.CheckBase): Check for properties only, not
12142 * interface.cs: Temporary hack: try/catch around the
12143 CustomAttributeBuilder, because I am getting an exception that I
12146 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12147 types whose definitions are required to be there (attributes are
12148 defined before standard types).
12150 Compute definitions as we boot the various types, as they are used
12151 immediately (value_type class will need object_type, but if we do
12152 not initialize object_type, we will pass a null, which will let
12153 the runtime pick the System.Object from the existing corlib, which
12154 is not what we want).
12156 2002-04-22 Patrik Torstensson <totte@labs2.com>
12158 * cs-tokenizer.cs: fixed a number of trim() issues.
12160 2002-04-22 Ravi Pratap <ravi@ximian.com>
12162 * expression.cs (Argument.Type): Ensure that we return the correct
12163 type when we have out or ref parameters [in which case we
12166 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12168 * class.cs (Property, Indexer): Allow extern modifier in there.
12170 * typemanager.cs (InitBaseTypes): Initializes object_type and
12171 value_type, since those will be used early on during the bootstrap
12172 process to compile corlib.
12174 (InitCoreTypes): Move code from here to InitBaseTypes.
12176 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12178 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12179 single-dimension arrays as using the ldlen opcode.
12181 Daniel Lewis discovered this optimization.
12183 * typemanager.cs: Add signature for System.Array::get_Length
12185 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12187 * statement.cs: report the error when the foreach does not apply to an
12188 array nor a collection.
12190 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12192 * expression.cs: Add implicit conversions to the operator ~.
12194 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12196 * typemanager.cs: Locate the decimal constructor.
12198 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12200 * attribute.cs: use the new property of TypeOf.
12201 * expression.cs: added 'get' property around typearg.
12203 These changes fix a build breaker reported by NickD. Is this the
12204 correct way to fix? If not, please, revert my changes and make it
12207 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12209 * attribute.cs: Add support for typeof in attribute invocations.
12210 I am not sure that this is right though.
12212 2002-04-14 Duncan Mak <duncan@ximian.com>
12214 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12215 Binary.Operator.Division case.
12217 2002-04-13 Ravi Pratap <ravi@ximian.com>
12219 * class.cs (DefineType): Ensure that we do a proper check on
12220 attribute types and also register it with the TypeManager.
12222 (TypeContainer.Targets): The default for attribute types is
12223 AttributeTargets.All.
12225 * attribute.cs (ApplyAttributes): Registering the attribute type
12226 is done elsewhere, not when we discover we have a Usage attribute.
12228 2002-04-12 Ravi Pratap <ravi@ximian.com>
12230 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12231 and get rid of is_delegate parameter.
12233 * everywhere : update.
12235 2002-04-12 Ravi Pratap <ravi@ximian.com>
12237 * cs-parser.jay (compilation_unit): Revamp completely to use
12238 some new ideas that I got from Rhys' grammar to solve the problems
12239 with assembly level attributes.
12241 (outer_declaration): New grammar production.
12243 (attribute_sections): Add.
12245 (opt_attributes): Base on attribute_sections
12247 (namespace_declaration): Allow opt_attributes to tackle the case
12248 when we have assembly level attributes - we are clever in this
12251 * attribute.cs (ApplyAttributes): Do not worry about assembly
12252 attributes in the non-global context.
12254 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12255 instead of SetGlobalAttributes.
12257 * class.cs, rootcontext.cs : Ensure we define and generate
12258 attribute types before anything else.
12260 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12261 and flag the new error -20 for the case when the attribute type
12262 does not have valid targets specified. csc does not catch this.
12264 * ../errors/errors.txt : update for error # -20
12266 2002-04-11 Ravi Pratap <ravi@ximian.com>
12268 * support.cs (InternalParameters.ParameterModifier): Do some null
12269 checking and return sane values.
12271 * class.cs (Method.Define): If we are a PInvoke method, ensure
12272 that we are static and extern. Report error # 601
12274 * ../errors/cs0601.cs : Add test case for the above error.
12276 2002-04-07 Ravi Pratap <ravi@ximian.com>
12278 * rootcontext.cs (attribute_types): We need to keep type of
12279 all attribute types separately and emit code for them first.
12281 (RegisterAttribute) : Implement.
12283 * class.cs (DefineType): Check if the current Type is a custom
12284 attribute type and register it accordingly.
12286 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12287 adding the first attribute twice and rename to
12289 (SetGlobalAttributes): this.
12291 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12294 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12295 if we are processing global arguments. Hmm, I am unsure of this.
12297 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12299 * expression.cs: added static array of strings to avoid calling
12300 Enum.ToString () for Operator in Binary. Significant recover of
12303 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12305 * class.cs (FindMembers): Allow the Builders of the various
12306 members to be null. If they are skip them. This only happens
12307 during the PInvoke declaration.
12309 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12311 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12312 failure, so we do not keep going afterwards.
12314 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12315 wanted to pass `false' as the `is_delegate' argument. If this is
12316 the case, why not use delegate_type == null to mean `is_delegate =
12317 false' and anything else as is_delegate = true.
12319 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12321 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12322 code for the section, not the beginning of the tests.
12324 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12326 * cfold.cs: Handle operator + (Enum x, Underlying x)
12328 * expression.cs (Binary): same. Warn about errors where we have
12329 Enum/Enum in operator + as well.
12331 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12334 - added support for switch(bool)
12335 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12336 - add TableSwitchEmit() to handle table-based switch statements
12338 2002-04-05 Ravi Pratap <ravi@ximian.com>
12340 * expression.cs (Invocation.OverloadResolve): Factor out code which
12341 does parameter compatibility checking with arguments so that we can
12342 re-use the code even from Delegate.VerifyApplicability
12344 (VerifyArgumentsCompat): Move above code here.
12346 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12347 and instead make a call to the above method.
12349 2002-03-31 Ravi Pratap <ravi@ximian.com>
12351 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12352 We use it to keep track of classes which are attribute types.
12354 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12356 * delegate.cs (Delegate.Define): Correctly define the types in the
12357 presence of fixed and array parameters.
12359 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12362 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12363 include NonPublic after the first iteration.
12365 * class.cs (Indexer.CheckBase): Only check if both parents are
12368 * cs-parser.jay (accessor_body): If empty, set to null.
12370 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12371 same code path here to resolve constants names that we did have in
12372 MemberAccess.DoResolve. There is too much code duplicated here.
12374 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12376 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12378 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12381 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12382 tokens, numbers and strings.
12384 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12387 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12388 asyncronous parameters and the regular parameters.
12390 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12391 specify the target directory.
12393 * expression.cs: (This.DoResolve): Simplify
12394 (As.Emit): Optimize, do not generate IsInst if the expression is
12395 always of the given type.
12397 (Is.DoResolve): Bug fix, we were reporting both always/never for
12400 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12401 creating too many unnecessary arrays.
12403 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12405 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12406 fields instead of rolling our own initializer. Takes care of all
12407 implicit conversions, and drops unnecessary static checks/argument.
12409 2002-03-31 Dick Porter <dick@ximian.com>
12411 * driver.cs: use the GetDirectories() return values properly, and
12412 use "/" as path separator.
12414 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12416 * expression.cs (Unary): Optimize - - expr into expr.
12417 (Binary): Optimize a + (-b) into a -b.
12419 * codegen.cs (CodeGen): Made all methods static.
12421 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12425 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12426 TypeBuilder property.
12428 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12431 * tree.cs: Removed the various RecordXXXX, and replaced with a
12432 single RecordDecl. Removed all the accessor methods, and just
12433 left a single access point Type
12435 * enum.cs: Rename DefineEnum to DefineType.
12437 * decl.cs: New abstract method `DefineType' used to unify the
12438 Defines for Enumerations, Interfaces, TypeContainers and
12441 (FindType): Moved LookupInterfaceOrClass here. Moved the
12442 LookupBaseClasses method that used to live in class.cs and
12443 interface.cs here, and renamed to FindType.
12445 * delegate.cs: Implement DefineType. Take advantage of the
12446 refactored pattern for locating the parent builder without taking
12447 the parent_builder argument (which we know does not work if we are
12448 nested, and triggering a toplevel definition).
12450 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12452 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12453 accessibility of a member has changed during override and report
12456 * class.cs (Method.Define, Property.Define): Only complain on
12457 overrides if the method is private, any other accessibility is
12458 fine (and since we just checked the permission is the same, we are
12461 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12462 and elif are processed always. The other pre-processing
12463 directives are only processed if we are "taking" the path
12465 2002-03-29 Martin Baulig <martin@gnome.org>
12467 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12468 current location is not Null.
12470 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12471 a separate method so we can profile it.
12473 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12474 `span.Seconds' are just seconds, but no minutes or hours.
12475 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12477 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12479 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12480 Remove the gratuitous set of Final:
12482 // If an interface implementation, then we can set Final.
12483 if (((flags & MethodAttributes.Abstract) == 0) &&
12484 implementing.DeclaringType.IsInterface)
12485 flags |= MethodAttributes.Final;
12487 I do not know what I was smoking when I used that.
12490 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12491 step into fixing the name resolution issues for delegates and
12492 unifying the toplevel name resolution.
12494 2002-03-28 Martin Baulig <martin@gnome.org>
12496 * class.cs (Method.Emit): If we have a symbol writer, call its
12497 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12498 tell it about the current method.
12500 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12501 writer that we're going to emit the first byte of IL code for a new
12502 statement (a new source line).
12503 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12504 EmitContext.Mark() before emitting any code.
12506 * location.cs (SymbolDocument): Return null when we're Null.
12508 * statement.cs (Statement): Moved the `Location loc' variable here.
12509 (Statement.EmitBoolExpression): If we have a symbol writer, call
12510 ec.Mark() before emitting any code to tell it that we're at the
12511 beginning of a new statement.
12512 (StatementExpression): Added `Location' argument to the constructor.
12513 (Block): Added public readonly variable `StartLocation' and public
12514 variable `EndLocation'. The latter is to be set using SetEndLocation().
12515 (Block): Added constructor which takes a start and end location.
12516 (Block.SetEndLocation): New method. This sets the end location.
12517 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12518 local variables we create.
12519 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12520 each statement and do also mark the begin and end of the block.
12522 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12523 tell it the current lexer.Location, use Location.Null for the end of the
12525 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12526 current block, set its end location using SetEndLocation().
12527 (statement_expression): StatementExpression constructor now takes the
12528 lexer.Location as additional argument.
12529 (for_statement, declare_local_variables): Likewise.
12530 (declare_local_variables): When creating a new implicit block, use the
12531 new Block constructor and pass it the lexer.Location.
12533 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12535 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12536 members also on the parent interfaces recursively.
12538 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12540 * report.cs: Use new formats, since Gonzalo finished the missing
12543 * expression.cs (Binary.ResolveOperator): added missing operator|
12544 operator& and operator^ for bool/bool.
12546 * cs-parser.jay: CheckDef now takes a Location argument that is
12547 used to report errors more precisly (instead of reporting the end
12548 of a definition, we try to track something which is a lot closer
12549 to the source of the problem).
12551 * cs-tokenizer.cs: Track global token use, so we can properly flag
12552 the use of #define/#undef after the first token has been seen.
12554 Also, rename the reportXXXX to Error_DescriptiveName
12556 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12557 TypeContainer, so that Enum and Interface can use this too.
12559 * class.cs (TypeContainer.LookupInterfaceOrClass,
12560 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12561 `builder' argument. Typically this was used to pass the parent
12562 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12565 The problem is that a nested class could trigger the definition of
12566 a toplevel class, and the builder would be obviously wrong in that
12569 So we drop this argument, and we compute dynamically the
12570 TypeBuilder/ModuleBuilder (the correct information was available
12571 to us anyways from DeclSpace.Parent)
12573 * interface.cs (Interface.DefineInterface): Drop builder
12574 parameter cleanup like class.cs
12576 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12579 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12582 (Try.Emit): Propagate the returns value from the statement.
12584 (Return.Emit): Even if we are leavning
12586 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12588 * modifiers.cs: Fix the computation of MethodAttributes flags.
12590 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12592 * driver.cs: allow compilation of files that start with '/'.
12593 Add a default case when checking the argument of --target.
12595 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12597 * interface.cs: Implement the same search algorithm for types in
12598 the interface code.
12600 * delegate.cs: Do not allow multiple definition.
12602 * Recovered ChangeLog that got accidentally amputated
12604 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12606 * rootcontext.cs: Load manually enum to allow core classes to
12607 contain enumerations.
12609 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12610 Update to new static methods in TypeManager.
12612 * typemanager.cs (GetMethod, GetConstructor): Use our
12613 implementation of FindMembers to find the members, since during
12614 corlib compilation, the types are TypeBuilders and GetMethod and
12615 GetConstructor do not work.
12617 Make all methods in TypeManager static.
12619 (InitCodeHelpers): Split the functionality from
12620 the InitCodeTypes function.
12622 * driver.cs: Call InitCodeHelpers after we have populated the
12625 * cs-parser.jay (delegate_declaration): we did not used to compute
12626 the delegate name correctly for void delegates.
12628 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12630 * rootcontext.cs (RootContext): Init the interface_resolve_order
12631 and type_container_resolve_order always.
12633 (ResolveCore, BootstrapCorlib_ResolveClass,
12634 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12635 compiler when compiling with --nostdlib
12637 * class.cs (TypeContainer.DefineType): Check that our parent is
12638 not null. This test is most important when we are bootstraping
12641 * codegen.cs: Split out the symbol writing code.
12643 2002-03-25 Martin Baulig <martin@gnome.org>
12645 * driver.cs (-g): Made -g an alias for --debug.
12647 2002-03-24 Martin Baulig <martin@gnome.org>
12649 * codegen.cs (SymbolWriter): New public variable. Returns the
12650 current symbol writer.
12651 (CodeGen): Added `bool want_debugging_support' argument to the
12652 constructor. If true, tell the ModuleBuild that we want debugging
12653 support and ask it for the ISymbolWriter.
12654 (Save): If we have a symbol writer, call it's Close() method after
12655 saving the assembly.
12657 * driver.c (--debug): New command line argument to create a
12658 debugger information file.
12660 * location.cs (SymbolDocument): New public property. Returns an
12661 ISymbolDocumentWriter object for the current source file or null
12662 if we don't have a symbol writer.
12664 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12666 * driver.cs (LoadAssembly): Correctly return when all the paths
12667 have been tried and not before.
12669 * statement.cs (Switch.Emit): return the actual coverage for this
12670 statement (returns/not-returns)
12672 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12673 switch of the statement if we are the last switch section. That
12674 kills two problems: try/catch problems (we used to emit an empty
12675 nop at the end) and switch statements where all branches would
12678 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12680 * driver.cs: Add default assemblies (the equivalent to the
12681 Microsoft CSC.RSP file)
12683 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12684 also update tokens_seen and set it to false.
12686 * driver.cs: Implement --recurse for Mike.
12688 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12689 correctly splitting out the paths.
12691 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12693 * interface.cs (Interface.PopulateProperty): Instead of using
12694 `parent' as the declaration space for the set parameters, use
12697 * support.cs (InternalParameters): InternalParameters constructor
12698 takes a DeclSpace instead of a TypeContainer.
12700 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12701 types are being initialized, load the address of it before calling
12704 (New): Provide a mechanism to disable the generation of local
12705 value type temporaries when the caller will be providing us with
12706 an address to store it.
12708 (ArrayCreation.EmitDynamicInitializers): Use it.
12710 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12712 * expression.cs (Invocation.EmitArguments): Only probe for array
12713 property if there is more than one argument. Sorry about that.
12715 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12716 empty param arrays.
12718 * class.cs (Method.LabelParameters): Fix incorrect code path that
12719 prevented the `ParamArrayAttribute' from being applied to the
12722 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12724 * support.cs (ReflectionParameters): Correctly compute whether the
12725 last argument is a params array. Fixes the problem with
12728 * typemanager.cs: Make the assemblies array always be non-null
12729 (empty, but non-null)
12731 * tree.cs (RecordDecl): New function that abstracts the recording
12732 of names. This reports error 101, and provides a pointer to the
12733 previous declaration. Fixes a crash in the compiler.
12735 * cs-parser.jay (constructor_declaration): Update to new grammar,
12736 and provide a constructor_body that can be empty.
12738 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12740 * driver.cs: Add support for --resources.
12742 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12743 Make all types for the various array helper methods be integer.
12745 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12746 CheckState to ConvCast.
12748 (ConvCast): Now it takes a `checked' state argument, to avoid
12749 depending on the emit context for the conversion, and just using
12750 the resolve time setting.
12752 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12753 instead of Invocation.EmitArguments. We do not emit the original
12754 arguments, instead we emit those which have been converted to
12755 unsigned int expressions.
12757 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12759 * codegen.cs: ditto.
12761 * expression.cs (LocalVariableReference): Drop the use of the
12762 Store function that depended on the variable index.
12764 * statement.cs (VariableInfo): Drop the `Idx' property from this
12765 class, as this is not taking into account the indexes for
12766 temporaries tat we generate during the execution, getting the
12769 * class.cs: First emit class initializers, then call the parent
12772 * expression.cs (Binary): Fix opcode emision.
12773 (UnaryMutator.EmitCode): Support checked code generation
12775 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12776 matches for events for both the Static and Instance scans,
12777 pointing to the same element. Fix that.
12779 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12781 * rootcontext.cs (ResolveTree): Always set the
12782 interface_resolve_order, because nested interfaces will be calling
12785 * class.cs (GetInterfaceOrClass): Track the same resolution
12786 process used by TypeManager.LookupType. This fixes the nested
12787 type lookups in class declarations (separate path from
12790 (TypeContainer.DefineType): Also define nested interfaces.
12791 (TypeContainer.RegisterOrder): New public function used to
12792 register the order in which child interfaces need to be closed.
12794 Nested interfaces need to be closed after their parents have been
12797 * interface.cs (InterfaceAttr): Put all the logic for computing
12798 the interface attribute here.
12800 (DefineInterface): Register our interface order with the
12801 RootContext or with the TypeContainer depending on the case.
12803 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12805 * cs-parser.jay: rework foreach statement to work with the new
12806 changes to the policy on SimpleNames.
12808 * report.cs: support Stacktrace on warnings as well.
12810 * makefile: drop --unsafe and /unsafe from the compile.
12812 2002-03-13 Ravi Pratap <ravi@ximian.com>
12814 * ecore.cs (StandardConversionExists): Modify to take an Expression
12815 as the first parameter. Ensure we do null -> reference type conversion
12818 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12819 temporary Expression objects.
12821 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12823 * interface.cs: workaround bug in method overloading resolution
12824 (there is already a bugzilla bug for it).
12826 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12828 We could also solve this problem by having a separate path for
12829 performing type lookups, instead of DoResolve, we could have a
12830 ResolveType entry point, and only participating pieces of the
12831 production (simplename, deref, array) would implement this.
12833 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12834 signal SimpleName to only resolve type names and not attempt to
12835 resolve anything else.
12837 * expression.cs (Cast): Set the flag.
12839 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12841 * class.cs: Only report 108 if there is no `new' modifier.
12843 * cs-parser.jay: rework foreach statement to work with the new
12844 changes to the policy on SimpleNames.
12846 * report.cs: support Stacktrace on warnings as well.
12848 * makefile: drop --unsafe and /unsafe from the compile.
12850 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12852 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12853 lookups here, instead of doing that at parse time. This means
12854 that our grammar will not introduce `LocalVariableReferences' as
12855 expressions at this point. That solves the problem of code like
12859 static void Main ()
12863 This is only half the fix. The full fix requires parameters to
12864 also be handled in this way.
12866 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12867 makes the use more obvious of the DeclSpace. The
12868 ec.TypeContainer.TypeBuilder is now only used to pull the
12869 TypeBuilder for it.
12871 My theory is that I can get rid of the TypeBuilder completely from
12872 the EmitContext, and have typecasts where it is used (from
12873 DeclSpace to where it matters).
12875 The only pending problem is that the code that implements Aliases
12876 is on TypeContainer, and probably should go in DeclSpace.
12878 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12879 lookups here, instead of doing that at parse time. This means
12880 that our grammar will not introduce `LocalVariableReferences' as
12881 expressions at this point. That solves the problem of code like
12885 static void Main ()
12889 This is only half the fix. The full fix requires parameters to
12890 also be handled in this way.
12892 * class.cs (Property.DefineMethod): When implementing an interface
12893 method, set newslot, when implementing an abstract method, do not
12894 set the flag (before we tried never setting it, or always setting
12895 it, which is the difference).
12896 (Indexer.DefineMethod): same.
12897 (Method.DefineMethod): same.
12899 * ecore.cs: Only set the status used flag if we get back a Field.
12901 * attribute.cs: Temporary hack, so Paolo can keep working.
12903 2002-03-08 Ravi Pratap <ravi@ximian.com>
12905 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12906 the unmanaged type in the case we have a MarshalAs attribute.
12908 (Resolve): Handle the case when we are parsing the special MarshalAs
12909 attribute [we need to store the unmanaged type to use later]
12911 * typemanager.cs (marshal_as_attr_type): Built in type for the
12912 MarshalAs Attribute.
12914 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12915 on parameters and accordingly set the marshalling info.
12917 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12919 * class.cs: Optimizing slightly by removing redundant code after
12920 we switched to the `NoTypes' return value.
12921 (Property.DefineMethod): use NoTypes here too.
12923 This fixes the bug I introduced in my last batch of changes.
12925 2002-03-05 Ravi Pratap <ravi@ximian.com>
12927 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12929 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12930 Enums since those are types too.
12932 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12934 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12935 thanks to a call during the lookup process.
12937 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12939 * statement.cs (Foreach): Lots of work to accomodate a particular
12940 kind of foreach statement that I had not kept in mind. It is
12941 possible to have foreachs on classes that provide a GetEnumerator
12942 method that return objects that implement the "pattern" for using
12943 a foreach, there is no need to support GetEnumerator
12946 This is needed to compile nant.
12948 * decl.cs: Only report 114 if the member is not `Finalize' and if
12949 the warning level is at least 2.
12951 * class.cs: Moved the compare function from Method to
12954 (MethodSignature.InheritableMemberSignatureCompare): Add new
12955 filter function that is used to extract inheritable methods from a
12958 (Method.Define): Use the new `inheritable_method_signature_filter'
12961 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12964 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12966 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12968 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12970 * expression.cs: Pass location information to
12971 ConvertImplicitStandard.
12973 * class.cs: Added debugging code to track return values from
12976 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12978 * expression.cs (Is.DoResolve): If either side of the `is' is an
12979 interface, do not flag the warning.
12981 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12984 * report.cs: Allow for --fatal to be used with --probe.
12986 * typemanager.cs (NoTypes): Move the definition for the empty Type
12989 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12991 (TypeContainer.DefineProxy): New function used to proxy to parent
12992 implementations when implementing interfaces.
12993 (TypeContainer.ParentImplements): used to lookup if our parent
12994 implements a public function that is required by an interface.
12995 (TypeContainer.VerifyPendingMethods): Hook this up.
12997 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12998 `modules' and `assemblies' arraylists into arrays. We only grow
12999 these are the very early start up of the program, so this improves
13000 the speedof LookupType (nicely measured).
13002 * expression.cs (MakeByteBlob): Replaced unsafe code with
13003 BitConverter, as suggested by Paolo.
13005 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13006 folding of string concatenation, but if either side is a string,
13007 and the other is not, then return null, and let the runtime use
13008 the concatenation on the string plus the object (using
13009 `Object.ToString').
13011 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13013 Constant Folding has been implemented now.
13015 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13016 the error instead on types that are not supported in one's
13019 * constant.cs (Constant and all children): New set of functions to
13020 perform implict and explicit conversions.
13022 * ecore.cs (EnumConstant): Implement the new functions to perform
13023 conversion by proxying to the child expression.
13025 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13026 own separate setting that can not be turned off from the command
13027 line using --unchecked or --checked and is only controlled using
13028 the checked/unchecked statements and expressions. This setting is
13029 used by the constant folder to flag errors.
13031 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13032 ConstantCheckState as well.
13034 During Resolve, they also have to flag the state, because the
13035 constant folder runs completely in the Resolve phase.
13037 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13040 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13042 * cfold.cs: New file, this file contains the constant folder.
13044 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13045 argument to track whether we are using the resulting address to
13046 load or store a value and provide better error messages.
13048 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13049 new AddressOf arguments.
13051 * statement.cs (Foreach.EmitCollectionForeach): Update
13053 * expression.cs (Argument.Emit): Call AddressOf with proper
13054 arguments to track usage.
13056 (New.DoEmit): Call AddressOf with new arguments.
13058 (Unary.Emit): Adjust AddressOf call.
13060 2002-03-01 Ravi Pratap <ravi@ximian.com>
13062 * cs-parser.jay (member_access): Change the case for pre-defined types
13063 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13066 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13069 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13070 essentially like methods and apply attributes like MethodImplOptions to them too.
13072 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13075 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13076 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13079 * Update code everywhere accordingly.
13081 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13083 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13085 2002-02-28 Ravi Pratap <ravi@ximian.com>
13087 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13088 try performing lookups against those instead of jumping straight into using
13089 the 'using' clauses.
13091 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13093 (LookupType): Perform lookups in implicit parents too.
13095 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13096 sequence as RootContext.LookupType.
13098 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13099 the various cases of namespace lookups into this method.
13101 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13103 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13104 in positional arguments)
13106 * class.cs (Operator): Update the AllowedModifiers to contain
13109 * cs-parser.jay: Update operator declaration to allow for the
13110 operator body to be empty.
13112 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13115 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13117 * class.cs (Method.Emit): Label parameters.
13119 * driver.cs: Return 1 or 0 as the program exit code.
13121 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13123 * expression.cs: Special case the `null' object when trying to
13124 auto-compute the type, as anything can be explicitly converted to
13127 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13128 spotting this Paolo.
13130 (Expression.ImplicitNumericConversion): Perform comparissions of
13131 the type using the underlying type in the case of an enumeration
13132 rather than using the enumeration type for the compare.
13134 Cope with the underlying == type case, which is not possible to
13137 (Expression.ConvertNumericExplicit): Perform comparissions of
13138 the type using the underlying type in the case of an enumeration
13139 rather than using the enumeration type for the compare.
13141 * driver.cs: If the user does not supply an extension, assume .exe
13143 * cs-parser.jay (if_statement): Rewrote so that we can track the
13144 location for the if statement.
13146 * expression.cs (Binary.ConstantFold): Only concat strings when
13147 the operation is "+", not everything ;-)
13149 * statement.cs (Statement.EmitBoolExpression): Take a location
13151 (If, While, Do): Track location.
13153 * expression.cs (Binary.ResolveOperator): In the object + string
13154 case, I was missing a call to ConvertImplicit
13156 2002-02-25 Ravi Pratap <ravi@ximian.com>
13158 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13159 Location arguments. Ensure we use RootContext.LookupType to do our work
13160 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13162 * interface.cs (PopulateMethod): Handle the type of the parameter being
13165 * expression.cs (Invocation.BetterFunction): Handle the case when we
13166 have a params method with no fixed arguments and a call is made with no
13169 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13171 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13172 the verbatim-string-literal
13174 * support.cs (InternalParameters.ParameterModifier): handle null
13176 (InternalParameters.ParameterType): ditto.
13178 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13179 duplicating the name of the variable parameter.
13180 (GetParameterByName): Fix bug where we were not looking up array
13181 paramters if they were the only present (thanks Paolo!).
13182 (GetParameterInfo): We only have an empty set of types if both
13183 fixed and array are set to null.
13184 (GetParameterInfo-idx): Handle FixedParameter == null
13186 * cs-parser.jay: Handle the case where there is no catch
13187 statements (missing null test).
13189 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13191 * driver.cs (MainDriver): Be conservative on our command line
13194 Catch DirectoryNotFoundException when calling GetFiles.
13196 (SplitPathAndPattern): Used to split the input specification into
13197 a path and a pattern that we can feed to Directory.GetFiles.
13199 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13201 * statement.cs (Fixed): Implement the last case of the Fixed
13202 statement (string handling).
13204 * expression.cs (StringPtr): New class used to return a char * to
13205 a string; Used by the Fixed statement.
13207 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13209 * expression.cs (Binary.ResolveOperator): Remove redundant
13210 MemberLookup pn parent type.
13211 Optimize union call, we do not need a union if the types are the same.
13212 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13215 Specialize the use of MemberLookup everywhere, instead of using
13216 the default settings.
13218 (StackAlloc): Implement stackalloc keyword.
13220 * cs-parser.jay: Add rule to parse stackalloc.
13222 * driver.cs: Handle /h, /help, /?
13224 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13225 before we supported unsafe code.
13227 * makefile: add --unsafe to the self compilation of mcs.
13229 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13231 * expression.cs (PointerArithmetic): New class that is used to
13232 perform pointer arithmetic.
13233 (Binary.Resolve): Handle pointer arithmetic
13234 Handle pointer comparission.
13235 (ArrayPtr): Utility expression class that is used to take the
13236 address of an array.
13238 (ElementAccess): Implement array access for pointers
13240 * statement.cs (Fixed): Implement fixed statement for arrays, we
13241 are missing one more case before we are done.
13243 * expression.cs (Indirection): Implement EmitAssign and set the
13244 ExprClass to Variable. This allows pointer dereferences to be
13245 treated as variables, and to have values assigned to them.
13247 * ecore.cs (Expression.StoreFromPtr): New utility function to
13248 store values dereferencing.
13250 2002-02-20 Ravi Pratap <ravi@ximian.com>
13252 * expression.cs (Binary.ResolveOperator): Ensure that we are
13253 not trying to operate on a void type - this fixes the reported
13256 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13257 the parent implementation is sealed.
13259 * ../errors/cs0239.cs : Add.
13261 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13263 * typemanager.cs (unverifiable_code_type): Corresponds to
13264 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13265 which have unsafe code in them.
13267 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13270 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13272 * cs-tokenizer.cs: Add support for @"litreal strings"
13274 Make tokenizer accept pre-processor directives
13275 on any column (remove the old C-like limitation).
13277 * rootcontext.cs (EmitCode): Emit any global attributes.
13278 (AddGlobalAttributes): Used to keep track of assembly attributes.
13280 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13282 * cs-parser.jay: Add support for global attributes.
13284 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13286 * expression.cs (Indirection): New helper class. Unary will
13287 create Indirection classes to be able to implement the
13288 IMemoryLocation interface on it.
13290 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13292 * cs-parser.jay (fixed_statement): reference the right statement.
13294 * statement.cs (Fixed.Emit): Finish implementing the fixed
13295 statement for the &x case.
13297 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13299 * class.cs (Property.Define, Method.Define): Remove newslot when
13302 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13303 wrong. NewSlot should only be used if the `new' keyword is present.
13305 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13306 locating our system dir. Sorry about this.
13308 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13310 * driver.cs (GetSystemDir): Compute correctly the location of our
13311 system assemblies. I was using the compiler directory instead of
13312 the library directory.
13314 2002-02-13 Ravi Pratap <ravi@ximian.com>
13316 * expression.cs (BetterFunction): Put back in what Miguel commented out
13317 since it is the correct fix. The problem is elsewhere ;-)
13319 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13320 parameters of the parms method are themselves compatible or not !
13322 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13323 to check that a class implements an interface before saying that an implicit
13324 conversion was allowed. Use ImplementsInterface to do the checking.
13326 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13328 * class.cs (Method.Define): Track whether we are an explicit
13329 implementation or not. And only call DefineMethodOverride if we
13330 are an explicit implementation.
13332 (Property.DefineMethod): Ditto.
13334 2002-02-11 Ravi Pratap <ravi@ximian.com>
13336 * expression.cs (BetterFunction): Catch hideous bug which was
13337 preventing us from detecting ambiguous calls due to implicit casts i.e
13340 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13342 * support.cs (Pair): Remove un-needed method. I figured why I was
13343 getting the error in cs-parser.jay, the variable in a foreach loop
13344 is readonly, and the compiler does not really treat this as a variable.
13346 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13347 instead of EQUALS in grammar.
13349 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13351 * expression.cs (Unary.DoResolve): Check whether the argument is
13354 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13356 * support.cs: Api for Pair to set a value. Despite the fact that
13357 the variables are public the MS C# compiler refuses to compile
13358 code that accesses the field if the variable is part of a foreach
13361 * statement.cs (Fixed): Begin implementation of the fixed
13364 (Block.AddVariable): Return the VariableInfo on success and null
13365 on failure instead of true/false.
13367 * cs-parser.jay (foreach): Catch errors on variables already
13368 defined (we were ignoring this value before) and properly unwind
13369 the block hierarchy
13371 (fixed_statement): grammar for the fixed statement.
13373 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13375 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13376 pointer types to be incretemented.
13378 (SizeOf): Implement.
13380 * cs-parser.jay (pointer_member_access): Implement
13381 expr->IDENTIFIER production.
13383 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13384 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13387 (Unary): Implement indirection.
13389 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13390 use in non-unsafe context).
13392 (SimpleName.DoResolve): Check for pointers in field access on safe
13395 (Expression.LoadFromPtr): Factor the load-indirect code in this
13396 function. This was duplicated in UnboxCast and ParameterReference
13398 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13400 * expression.cs (ComposedCast): report an error if a pointer cast
13401 is used in a safe region.
13403 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13404 pointer type casts in unsafe context.
13406 * codegen.cs (EmitContext): Set up IsUnsafe.
13408 * cs-parser.jay (non_expression_type): Add productions for pointer
13411 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13412 code. We should not use force into static mode if the method is
13413 not virtual. Fixes bug in MIS
13415 * statement.cs (Do.Emit, While.Emit, For.Emit,
13416 Statement.EmitBoolExpression): Add support to Do and While to
13417 propagate infinite loop as `I do return' semantics.
13419 Improve the For case to also test for boolean constants.
13421 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13422 to the list of attributes we can add.
13424 Remove `EmitContext' argument.
13426 * class.cs (Method.Define): Apply parameter attributes.
13427 (Constructor.Define): Apply parameter attributes.
13428 (MethodCore.LabelParameters): Move here the core of labeling
13431 * support.cs (ReflectionParameters.ParameterModifier,
13432 InternalParameters.ParameterModifier): Use IsByRef on the type and
13433 only return the OUT bit for these parameters instead of in/out/ref
13436 This is because I miss-understood things. The ParameterInfo.IsIn
13437 and IsOut represent whether the parameter has the [In] and [Out]
13440 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13442 * ecore.cs (FieldExpr.Emit): Release temporaries.
13444 * assign.cs (LocalTemporary.Release): new function.
13446 * codegen.cs (EmitContext.GetTemporaryStorage,
13447 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13448 temporary storage. Now we can "put back" localbuilders when we
13451 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13453 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13454 need to make a copy of the variable to generate verifiable code.
13456 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13458 * driver.cs: Compute dynamically the system directory.
13460 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13461 Slower, but more generally useful. Used by the abstract
13462 registering implementation.
13464 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13465 the rules for the special rule on Type/instances. First check if
13466 we have the same name, and if so, try that special static path
13467 rather than the instance path.
13469 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13471 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13474 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13475 Enum, ValueType, Delegate or Array for non-corlib compiles.
13477 * cs-tokenizer.cs: Catch long identifiers (645)
13479 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13482 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13483 fix, we were returning too early, so we were not registering
13484 pending methods from abstract classes.
13486 Do not register pending methods if the class is abstract.
13488 * expression.cs (Conditional.DoResolve): Report circular implicit
13489 conversions when we neecd to compute it for conditional
13492 (Is.DoResolve): If the expression is always of the provided type,
13493 flag warning 183. If the expression can not ever be of the
13494 provided type flag warning 184.
13496 * class.cs: Catch 169 as well.
13498 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13501 2002-01-18 Nick Drochak <ndrochak@gol.com>
13503 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13505 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13507 * interface.cs: (PopulateMethod): Check for pointers being defined
13508 only if the unsafe context is active.
13509 (PopulateProperty): ditto.
13510 (PopulateIndexer): ditto.
13512 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13513 specified. If pointers are present, make sure that they are
13514 present in an unsafe context.
13515 (Constructor, Constructor.Define): ditto.
13516 (Field, Field.Define): ditto.
13517 (Property, Property.Define): ditto.
13518 (Event, Event.Define): ditto.
13520 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13521 hashtable if there are classes or structs defined.
13523 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13524 code, as the constant resolution moved.
13526 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13527 the metadata, so we can flag error 133.
13529 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13530 pointer is being declared in an unsafe context.
13532 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13534 * modifiers.cs (Modifiers.Check): Require a Location argument.
13535 Report error 227 for Unsafe use.
13537 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13539 * statement.cs (For.Emit): If the test is null, then report that
13540 we do `return', as we wont reach anything afterwards.
13542 (Switch.SwitchGoverningType): Track the expression that matched
13545 * driver.cs: Allow negative numbers as an error code to flag.
13547 * cs-parser.jay: Handle 1551.
13549 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13551 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13553 * cs-parser.jay: Report 1518 (type declaration can only contain
13554 class, struct, interface, enum or delegate)
13556 (switch_label): Report 1523 (keywords `case' or `default' must
13559 (opt_switch_sections): Report 1522 (empty switch)
13561 * driver.cs: Report 1515 (response file specified multiple times)
13562 Report 1516 (Source file specified multiple times).
13564 * expression.cs (Argument.Resolve): Signal 1510
13566 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13567 access not allowed in static code)
13569 2002-01-11 Ravi Pratap <ravi@ximian.com>
13571 * typemanager.cs (IsPointerType): Utility method which we are going
13574 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13575 the object type, so we take care of that.
13577 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13579 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13580 added to non-params parameters :-)
13582 * typemanager.cs (CSharpName): Include 'void' type too.
13584 (void_ptr_type): Include in the set of core types.
13586 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13589 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13592 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13593 completely forgotten about it.
13595 2002-01-10 Ravi Pratap <ravi@ximian.com>
13597 * cs-parser.jay (pointer_type): Add. This begins our implementation
13598 of parsing rules for unsafe code.
13600 (unsafe_statement): Implement.
13602 (embedded_statement): Modify to include the above.
13604 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13606 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13607 if the current context is an unsafe one.
13609 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13610 are handled differently, we need separate rules for them.
13612 (local_variable_declaration): Update to use local_variable_pointer_type
13613 to allow variable declarations of unmanaged pointer types.
13615 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13616 in unsafe contexts.
13618 * ../errors/cs0214.cs : Add.
13620 2002-01-16 Nick Drochak <ndrochak@gol.com>
13622 * makefile: remove 'response' file when cleaning.
13624 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13626 * cs-parser.jay: Report 1524.
13628 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13630 * typemanager.cs (RegisterMethod): drop checking if we have
13631 registered this from here
13633 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13635 * class.cs (Method.EmitDestructor): Implement calling our base
13638 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13639 value of InFinally.
13641 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13642 this routine and will wrap the call in a try/catch block. Deal
13645 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13647 * ecore.cs (Expression.MemberLookup): instead of taking a
13648 parameter `same_type' that was used to tell whether we could
13649 access private members we compute our containing type from the
13652 (FieldExpr): Added partial support for volatile fields. This does
13653 not work for volatile fields exposed from assemblies, as I can not
13654 figure out how to extract the modreq from it.
13656 Updated all the source files to use this.
13658 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13659 because it is referenced by MemberLookup very often.
13661 2002-01-09 Ravi Pratap <ravi@ximian.com>
13663 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13664 TypeBuilder.GetCustomAttributes to retrieve what we need.
13666 Get rid of redundant default_member_attr_type as this is the same as
13667 default_member_type which already exists.
13669 * interface.cs, attribute.cs : Update accordingly.
13671 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13673 * typemanager.cs: Enable IndexerPropertyName again. It does not
13674 work for TYpeBuilders though. Ravi, can you please fix this?
13676 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13678 * expression.cs (Argument.Emit): Handle the case of ref objects
13679 being passed to ref functions;
13681 (ParameterReference.EmitLoad): Loads the content of the pointer
13682 without dereferencing.
13684 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13686 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13688 2002-01-08 Ravi Pratap <ravi@ximian.com>
13690 * class.cs (Indexer.DefineMethod): Incorporate the interface
13691 type in the name of the method if we are doing explicit interface
13694 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13696 (BetterConversion): Fix extremely trivial bug where we were referring to
13697 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13700 * ../errors/bug16.cs : Add although we have fixed it.
13702 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13704 * expression.cs (BaseIndexer): Begin implementation.
13706 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13708 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13709 production directly to remove a shift/reduce, and implement
13710 explicit interface implementation.
13712 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13713 after a floating point suffix.
13715 * expression.cs (DoNumericPromotions): Improved the conversion for
13716 uint/uint. If we have a constant, we avoid doing a typecast to a
13719 * class.cs (Indexer): Implement explicit interface implementation
13722 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13724 * class.cs: make the default instance constructor public and hidebysig.
13726 2001-01-03 Ravi Pratap <ravi@ximian.com>
13728 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13729 so we can call it from elsewhere.
13731 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13732 we emit it internally if the class has a defined indexer; otherwise the user
13733 emits it by decorating the class definition with the DefaultMemberAttribute.
13735 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13736 attribute is not used on a type which defines an indexer.
13738 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13739 character when we skip whitespace.
13741 * ../errors/cs0646.cs : Add.
13743 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13745 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13748 * makefile: Add practical target `mcs3.exe' which builds the third
13749 generation compiler.
13751 * expression.cs (New): Fix structures constructor calling.
13753 * class.cs (Property, Method, Indexer): Emit Final flag on the
13754 method if we are an interface implementation and we are not
13757 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13758 whether this property is referencing a `base' method.
13760 * expression.cs (Invocation.EmitCall): take an extra argument:
13761 is_base, this is used to determine whether the `call' or
13762 `callvirt' opcode should be used.
13765 * delegate.cs: update EmitCall.
13767 * class.cs (Method.Define): Set NewSlot for the cases where we are
13768 not implementing an interface method.
13770 (Property.Define): ditto.
13772 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13774 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13775 'r'. Allows mcs to parse itself fully.
13777 2002-01-02 Ravi Pratap <ravi@ximian.com>
13779 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13780 of the number of initializers that require the InitializeArray method.
13782 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13783 update the above field where necessary.
13785 (MakeByteBlob): Update accordingly.
13787 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13790 (EmitDynamicInitializers): Update in accordance with the new optimization.
13792 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13793 same OpCode applies.
13795 * cs-parser.jay : Fix some glaring errors I introduced.
13797 2002-01-01 Ravi Pratap <ravi@ximian.com>
13799 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13800 so that we can check for name clashes there too.
13802 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13803 for interface indexers.
13805 * interfaces.cs (Define): Emit the default member attribute.
13807 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13808 variable was being referred to while setting the value ;-)
13810 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13812 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13813 byte-by-byte information when we know the data is zero.
13815 Make the block always a multiple of 4, because
13816 DefineInitializedData has a bug.
13818 * assign.cs: Fix, we should assign from the temporary, not from
13821 * expression.cs (MakeByteBlob): Fix my incorrect code.
13823 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13825 * typemanager.cs (EnumToUnderlying): This function is used to get
13826 the underlying type from an enumeration, because it does not
13829 * constant.cs: Use the I4_S form for values between -128 and 127.
13831 * statement.cs (Block.LookupLabel): Looks up a label.
13832 (Block): Drop support for labeled blocks.
13834 (LabeledStatement): New kind of statement that represents a label
13837 (Goto): Finally implement this bad boy.
13839 * cs-parser.jay: Update to reflect new mechanism to implement
13842 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13844 * codegen.cs (EmitContext.This): a codegen property that keeps the
13845 a single instance of this instead of creating many different this
13848 * delegate.cs (Delegate.DoResolve): Update to use the property;
13850 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13852 * expression.cs (BaseAccess.DoResolve): Ditto.
13854 2001-12-29 Ravi Pratap <ravi@ximian.com>
13856 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13857 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13859 (InitCoreTypes): Update accordingly.
13861 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13862 so we can quickly store the state.
13864 (ApplyAttributes): Set the correct implementation flags
13865 for InternalCall methods.
13867 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13869 * expression.cs (EmitCall): if a method is not virtual, then do
13870 not use callvirt on it.
13872 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13873 user defined stuff) requires the use of stobj, which takes an
13874 address on the stack instead of an array and an index. So emit
13875 the Ldelema operation for it.
13877 (EmitStoreOpcode): Use stobj for valuetypes.
13879 (UnaryMutator.EmitCode): Use the right 1 value depending on
13880 whether we are dealing with int64/uint64, float or doubles.
13882 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13883 constructors that I implemented last night.
13885 (Constructor.IsDefault): Fix to work properly for static
13888 * cs-parser.jay (CheckDef): report method signature errors.
13889 Update error number 103 to be 132.
13891 * decl.cs: New AdditionResult enumeration value: MethodExists.
13892 Although we do this check for methods later on in the semantic
13893 analysis, catching repeated default constructors is so easy that
13894 we catch these here.
13896 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13899 (ParameterReference.EmitAssign, Emit): handle
13902 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13903 (ArrayAccess.EmitStoreOpcode): ditto.
13905 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13907 * expression.cs (MakeByteBlob): Complete all the missing types
13908 (uint, short, ushort, byte, sbyte)
13910 * class.cs: Only init instance field initializers on instance
13913 Rename `constructors' to instance_constructors.
13915 (TypeContainer.AddConstructor): Only add constructors to the list
13916 if it is not static.
13918 Make sure that we handle default_static_constructor independently
13919 everywhere where we handle instance_constructors
13921 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13923 * class.cs: Do not lookup or create a base initializer for a
13924 static constructor.
13926 (ConstructorInitializer.Resolve): use the proper type to lookup
13929 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13931 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13934 * decl.cs: CloseType is now an virtual method, the default
13935 implementation just closes this type.
13937 2001-12-28 Ravi Pratap <ravi@ximian.com>
13939 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13940 to PreserveSig by default. Also emit HideBySig on such methods.
13942 Basically, set the defaults to standard values.
13944 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13945 argument, if candidate is better, it can't be worse than the best !
13947 (Invocation): Re-write bits to differentiate between methods being
13948 applicable in their expanded form and their normal form - for params
13951 Get rid of use_standard everywhere as only standard conversions are allowed
13952 in overload resolution.
13954 More spec conformance.
13956 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13958 * driver.cs: Add --timestamp, to see where the compiler spends
13961 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13962 `this' in static code.
13964 (SimpleName.DoResolve): Implement in terms of a helper function
13965 that allows static-references to be passed upstream to
13968 (Expression.ResolveWithSimpleName): Resolve specially simple
13969 names when called by MemberAccess to implement the special
13972 (Expression.ImplicitReferenceConversion): Handle conversions from
13973 Null to reference types before others, as Null's type is
13976 * expression.cs (Invocation.EmitCall): Handle the special case of
13977 calling methods declared on a reference type from a ValueType
13978 (Base classes System.Object and System.Enum)
13980 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13981 the left hand side is a TypeExpr, not on every enumeration.
13983 (Binary.Resolve): If types are reference types, then do a cast to
13984 object on operators != and == of both arguments.
13986 * typemanager.cs (FindMembers): Extract instance and static
13987 members if requested.
13989 * interface.cs (PopulateProperty): Use void_type instead of null
13990 as the return type for the setter method.
13992 (PopulateIndexer): ditto.
13994 2001-12-27 Ravi Pratap <ravi@ximian.com>
13996 * support.cs (ReflectionParameters): Fix minor bug where we
13997 were examining the wrong parameter for the ParamArray attribute.
13999 Cope with requests for the type of the parameter at position
14000 greater than the params parameter's. We now return the element
14001 type of the params array as that makes more sense.
14003 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14004 accordingly as we no longer have to extract the element type
14007 (Invocation.OverloadResolve): Update.
14009 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14011 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14012 against IEnumerator, test whether the return value is a descendant
14013 of the IEnumerator interface.
14015 * class.cs (Indexer.Define): Use an auxiliary method to implement
14016 the other bits of the method definition. Begin support for
14017 explicit interface implementation.
14019 (Property.DefineMethod): Use TypeManager.void_type instead of null
14020 for an empty return value.
14022 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14024 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14025 dealing with a FieldExpr which is composed of a FieldBuilder, in
14026 the code path we did extract the constant, but we should have
14027 obtained the underlying value to be able to cast it (otherwise we
14028 end up in an infinite loop, this is what Ravi was running into).
14030 (ArrayCreation.UpdateIndices): Arrays might be empty.
14032 (MemberAccess.ResolveMemberAccess): Add support for section
14033 14.5.4.1 that deals with the special case of E.I when E is a type
14034 and something else, that I can be a reference to a static member.
14036 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14037 handle a particular array type to create byte blobs, it is just
14038 something we dont generate byteblobs for.
14040 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14043 * location.cs (Push): remove the key from the hashtable that we
14044 are about to add. This happens for empty files.
14046 * driver.cs: Dispose files after we have parsed them.
14048 (tokenize): new function that only runs the tokenizer on its
14049 input, for speed testing.
14051 2001-12-26 Ravi Pratap <ravi@ximian.com>
14053 * class.cs (Event.Define): Define the private field only if there
14054 are no accessors defined.
14056 * expression.cs (ResolveMemberAccess): If there is no associated
14057 field with the event, that means we have an event defined with its
14058 own accessors and we should flag error cs0070 since transforming
14059 ourselves into a field is not valid in that case.
14061 * ecore.cs (SimpleName.DoResolve): Same as above.
14063 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14064 and charset to sane values.
14066 2001-12-25 Ravi Pratap <ravi@ximian.com>
14068 * assign.cs (DoResolve): Perform check on events only if they
14069 are being accessed outside the declaring type.
14071 * cs-parser.jay (event_declarations): Update rules to correctly
14072 set the type of the implicit parameter etc.
14074 (add_accessor, remove_accessor): Set current local parameters.
14076 * expression.cs (Binary): For delegate addition and subtraction,
14077 cast the return value from the method into the appropriate delegate
14080 2001-12-24 Ravi Pratap <ravi@ximian.com>
14082 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14083 of these as the workaround is unnecessary.
14085 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14086 delegate data - none of that is needed at all.
14088 Re-write bits to extract the instance expression and the delegate method
14091 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14094 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14095 of attaching attributes instead of duplicating code everywhere.
14097 * everywhere : Update code to do attribute emission using the above method.
14099 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14101 * expression.cs (IsParamsMethodApplicable): if there are not
14102 parameters, return immediately.
14104 * ecore.cs: The 0 literal can be implicity converted to an enum
14107 (SimpleName.DoResolve): First lookup the type, then lookup the
14110 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14111 want to get its address. If the InstanceExpression is not
14112 addressable, store the result in a temporary variable, then get
14115 * codegen.cs: Only display 219 errors on warning level or above.
14117 * expression.cs (ArrayAccess): Make it implement the
14118 IMemoryLocation interface.
14120 (Binary.DoResolve): handle the operator == (object a, object b)
14121 and operator != (object a, object b) without incurring into a
14122 BoxedCast (because 5 != o should never be performed).
14124 Handle binary enumerator operators.
14126 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14127 value type, otherwise use Ldelem_ref.
14129 Use precomputed names;
14131 (AddressOf): Implement address of
14133 * cs-parser.jay (labeled_statement): Fix recursive block
14134 addition by reworking the production.
14136 * expression.cs (New.DoEmit): New has a special case:
14138 If we are dealing with a ValueType, we have a few
14139 situations to deal with:
14141 * The target of New is a ValueType variable, that is
14142 easy, we just pass this as the variable reference
14144 * The target of New is being passed as an argument,
14145 to a boxing operation or a function that takes a
14148 In this case, we need to create a temporary variable
14149 that is the argument of New.
14152 2001-12-23 Ravi Pratap <ravi@ximian.com>
14154 * rootcontext.cs (LookupType): Check that current_type is not null before
14155 going about looking at nested types.
14157 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14158 not implement the IAssignMethod interface any more.
14160 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14161 where we tranform them into FieldExprs if they are being resolved from within
14162 the declaring type.
14164 * ecore.cs (SimpleName.DoResolve): Do the same here.
14166 * assign.cs (DoResolve, Emit): Clean up code considerably.
14168 * ../errors/bug10.cs : Add.
14170 * ../errors/cs0070.cs : Add.
14172 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14174 * assign.cs : Get rid of EventIsLocal everywhere.
14176 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14178 * ecore.cs (ConvertIntLiteral): finished the implementation.
14180 * statement.cs (SwitchLabel): Convert the value we are using as a
14181 key before looking up the table.
14183 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14185 * codegen.cs (EmitTopBlock): Require a Location argument now.
14187 * cs-parser.jay (constructor_declarator): We need to setup
14188 current_local_parameters before we parse the
14189 opt_constructor_initializer, to allow the variables to be bound
14190 to the constructor arguments.
14192 * rootcontext.cs (LookupType): First lookup nested classes in our
14193 class and our parents before we go looking outside our class.
14195 * expression.cs (ConstantFold): Extract/debox the values at the
14198 * rootcontext.cs (EmitCode): Resolve the constants first before we
14199 resolve the types. This is not really needed, but it helps debugging.
14201 * statement.cs: report location.
14203 * cs-parser.jay: pass location to throw statement.
14205 * driver.cs: Small bug fix.
14207 * report.cs: Updated format to be 4-zero filled digits.
14209 2001-12-22 Ravi Pratap <ravi@ximian.com>
14211 * expression.cs (CheckIndices): Fix minor bug where the wrong
14212 variable was being referred to ;-)
14214 (DoEmit): Do not call EmitStaticInitializers when the
14215 underlying type is System.Object.
14217 2001-12-21 Ravi Pratap <ravi@ximian.com>
14219 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14220 and do the usual workaround for SRE.
14222 * class.cs (MyEventBuilder.EventType): New member to get at the type
14223 of the event, quickly.
14225 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14227 * assign.cs (Assign.DoResolve): Handle the case when the target
14228 is an EventExpr and perform the necessary checks.
14230 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14233 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14235 (EventExpr): Set the type in the constructor itself since we
14236 are meant to be born fully resolved.
14238 (EventExpr.Define): Revert code I wrote earlier.
14240 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14241 instance expression is null. The instance expression is a This in that case
14242 or a null, depending on whether it is a static method or not.
14244 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14245 refers to more than one method.
14247 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14248 and accordingly flag errors.
14250 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14252 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14254 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14256 * location.cs (ToString): Provide useful rutine.
14258 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14260 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14261 objects, return the actual integral boxed.
14263 * statement.cs (SwitchLabel): define an ILLabel for each
14266 (Switch.CheckSwitch): If the value is a Literal, extract
14267 the underlying literal.
14269 Also in the unused hashtable we had, add the SwitchLabel so we can
14270 quickly look this value up.
14272 * constant.cs: Implement a bunch of new constants. Rewrite
14273 Literal based on this. Made changes everywhere to adapt to this.
14275 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14276 dereferencing array only once, and also copes with enumrations.
14278 bytes are two bytes wide, not one.
14280 (Cast): Perform constant conversions.
14282 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14283 wrappers to the literals here.
14285 * expression.cs (DoNumericPromotions): long literals can converted
14286 to ulong implicity (this is taken care of elsewhere, but I was
14287 missing this spot).
14289 * ecore.cs (Expression.Literalize): Make the return type Literal,
14290 to improve type checking.
14292 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14294 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14296 * literal.cs: Revert code from ravi that checked the bounds. The
14297 bounds are sane by the definition of the type itself.
14299 * typemanager.cs: Fix implementation of ImplementsInterface. We
14300 need to actually look up in our parent hierarchy for interfaces
14303 * const.cs: Use the underlying type for enumerations
14305 * delegate.cs: Compute the basename for the delegate creation,
14306 that should fix the delegate test case, and restore the correct
14307 Type Lookup semantics in rootcontext
14309 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14310 referencing a nested type with the Reflection API is using the "+"
14313 * cs-parser.jay: Do not require EOF token at the end.
14315 2001-12-20 Ravi Pratap <ravi@ximian.com>
14317 * rootcontext.cs (LookupType): Concatenate type names with
14318 a '.' instead of a '+' The test suite passes again.
14320 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14321 field of the enumeration.
14323 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14324 the case when the member is an EventExpr.
14326 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14327 static has an associated instance expression.
14329 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14331 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14333 * class.cs (Event.Define): Register event and perform appropriate checks
14336 We define the Add and Remove methods even if the use provides none because
14337 in that case, we provide default implementations ourselves.
14339 Define a private field of the type of the event. This is done by the CSC compiler
14340 and we should be doing it too ;-)
14342 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14343 More methods we use in code we generate.
14345 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14348 (InitCoreTypes): Update accordingly for the above.
14350 * class.cs (Event.Emit): Generate code for default accessors that we provide
14352 (EmitDefaultMethod): Do the job in the above.
14354 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14357 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14359 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14360 builders even if we were missing one.
14362 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14363 pass the Basename as our class name instead of the Name. The
14364 basename will be correctly composed for us.
14366 * parameter.cs (Paramters): Now takes a Location argument.
14368 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14369 make all the code call directly LookupType in RootContext and take
14370 this chance to pass the Location information everywhere.
14372 * Everywhere: pass Location information.
14374 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14376 * class.cs (Constructor.Define): Updated way of detecting the
14377 length of the parameters.
14379 (TypeContainer.DefineType): Use basename as the type name for
14382 (TypeContainer.Define): Do not recursively define types here, as
14383 definition is taken care in order by the RootContext.
14385 * tree.cs: Keep track of namespaces in a per-file basis.
14387 * parameter.cs (Parameter.ComputeSignature): Update to use
14390 (Parameters.GetSignature): ditto.
14392 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14393 instead of a TypeContainer.
14395 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14396 resolve names. Because we need to be resolve in our context, not
14399 * driver.cs: Implement response files.
14401 * class.cs (TypeContainer.DefineType): If we are defined, do not
14402 redefine ourselves.
14404 (Event.Emit): Emit the code for add/remove handlers.
14405 (Event.Define): Save the MethodBuilders for add/remove.
14407 * typemanager.cs: Use pair here too.
14409 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14410 DictionaryEntry requires the first argument to be non-null.
14412 (enum_declaration): Compute full name for registering the
14415 (delegate_declaration): Instead of using
14416 formal_parameter_list, use opt_formal_parameter_list as the list
14419 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14420 (EventParsing): New property that controls whether `add' and
14421 `remove' are returned as tokens or identifiers (for events);
14423 2001-12-19 Ravi Pratap <ravi@ximian.com>
14425 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14426 use MyEventBuilder only and let it wrap the real builder for us.
14428 (MyEventBuilder): Revamp constructor etc.
14430 Implement all operations that we perform on EventBuilder in precisely the same
14433 (FindMembers): Update to use the EventBuilder member.
14435 (Event.Emit): Update accordingly.
14437 2001-12-18 Ravi Pratap <ravi@ximian.com>
14439 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14440 by calling the appropriate methods.
14442 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14445 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14447 2001-12-17 Ravi Pratap <ravi@ximian.com>
14449 * delegate.cs (Delegate.Populate): Check that the return type
14450 and various parameters types are indeed accessible.
14452 * class.cs (Constructor.Define): Same here.
14454 (Field.Define): Ditto.
14456 (Event.Define): Ditto.
14458 (Operator.Define): Check that the underlying Method defined itself
14459 correctly - so it's MethodBuilder should not be null.
14461 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14462 expression happens to be null.
14464 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14465 members but as of now we don't seem to be able to do anything really useful with it.
14467 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14468 not the EventBuilder.
14470 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14472 * cs-tokenizer.cs: Add support for defines.
14473 Add support for #if, #elif, #else, #endif
14475 (eval_var): evaluates a variable.
14476 (eval): stubbed for evaluating functions.
14478 * cs-parser.jay: Pass the defines information
14480 * driver.cs: Add --define command line option.
14482 * decl.cs: Move MemberCore here.
14484 Make it the base class for DeclSpace. This allows us to catch and
14485 report 108 and 109 for everything now.
14487 * class.cs (TypeContainer.Define): Extract all the members
14488 before populating and emit the warning 108 (new keyword required
14489 to override) instead of having each member implement this.
14491 (MemberCore.Define): New abstract method, we will be using this in
14492 the warning reporting engine in Populate.
14494 (Operator.Define): Adjust to new MemberCore protocol.
14496 * const.cs (Const): This does not derive from Expression, it is a
14497 temporary object we use to create fields, it is a MemberCore.
14499 * class.cs (Method.Define): Allow the entry point to be in a
14502 * driver.cs: Rewrite the argument handler to clean it up a bit.
14504 * rootcontext.cs: Made it just an auxiliary namespace feature by
14505 making everything static.
14507 * driver.cs: Adapt code to use RootContext type name instead of
14510 * delegate.cs: Remove RootContext argument.
14512 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14515 * class.cs (Event.Define): The lookup can fail.
14517 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14519 * expression.cs: Resolve the this instance before invoking the code.
14521 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14523 * cs-parser.jay: Add a production in element_access that allows
14524 the thing to become a "type" reference. This way we can parse
14525 things like "(string [])" as a type.
14527 Note that this still does not handle the more complex rules of
14531 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14533 * ecore.cs: (CopyNewMethods): new utility function used to
14534 assemble the list of methods from running FindMembers.
14536 (MemberLookup): Rework FindMembers so that
14538 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14540 * class.cs (TypeContainer): Remove Delegates who fail to be
14543 * delegate.cs (Populate): Verify that we dont get null return
14544 values. TODO: Check for AsAccessible.
14546 * cs-parser.jay: Use basename to emit error 574 (destructor should
14547 have the same name as container class), not the full name.
14549 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14550 possible representation.
14552 Also implements integer type suffixes U and L.
14554 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14556 * expression.cs (ArrayCreation.DoResolve): We need to do the
14557 argument resolution *always*.
14559 * decl.cs: Make this hold the namespace. Hold the root context as
14561 (LookupType): Move here.
14563 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14565 * location.cs (Row, Name): Fixed the code, it was always returning
14566 references to the first file.
14568 * interface.cs: Register properties defined through interfaces.
14570 * driver.cs: Add support for globbing on the command line
14572 * class.cs (Field): Make it derive from MemberCore as well.
14575 2001-12-15 Ravi Pratap <ravi@ximian.com>
14577 * class.cs (Event::Define): Check that the type of the event is a delegate
14578 type else flag error #66.
14580 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14583 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14584 values of EntryPoint, CharSet etc etc.
14586 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14588 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14589 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14590 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14591 which needs this to do its work.
14593 * ../errors/cs0066.cs : Add.
14595 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14597 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14600 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14601 clears out the parameters field.
14602 (MemberSignatureCompare): Cleanup
14604 (MemberCore): New base class used to share code between MethodCore
14607 (RegisterRequiredImplementations) BindingFlags.Public requires
14608 either BindingFlags.Instace or Static. Use instance here.
14610 (Property): Refactored code to cope better with the full spec.
14612 * parameter.cs (GetParameterInfo): Return an empty array instead
14615 * class.cs (Property): Abstract or extern properties have no bodies.
14617 * parameter.cs (GetParameterInfo): return a zero-sized array.
14619 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14620 method modifier validation to the typecontainer so we can reuse
14621 this on properties.
14623 (MethodCore.ParameterTypes): return an empty sized array of types.
14625 (Property.Define): Test property modifier validity.
14627 Add tests for sealed/override too.
14629 (Method.Emit): abstract or extern methods have no bodies.
14631 2001-12-14 Ravi Pratap <ravi@ximian.com>
14633 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14636 (Method::Define, ::Emit): Modify accordingly.
14638 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14640 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14642 * makefile: Pass in /unsafe.
14644 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14646 * class.cs (MakeKey): Kill routine.
14648 * class.cs (TypeContainer.Define): Correctly define explicit
14649 method implementations (they require the full interface name plus
14652 * typemanager.cs: Deply the PtrHashtable here and stop using the
14653 lame keys. Things work so much better.
14655 This of course broke everyone who depended on `RegisterMethod' to
14656 do the `test for existance' test. This has to be done elsewhere.
14658 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14659 the object stupid Equals method (because, that like fails all over
14660 the place). We still do not use it.
14662 * class.cs (TypeContainer.SetRequiredInterface,
14663 TypeContainer.RequireMethods): Killed these two routines and moved
14664 all the functionality to RegisterRequiredImplementations.
14666 (TypeContainer.RegisterRequiredImplementations): This routine now
14667 registers all the implementations required in an array for the
14668 interfaces and abstract methods. We use an array of structures
14669 which can be computed ahead of time to reduce memory usage and we
14670 also assume that lookups are cheap as most classes will not
14671 implement too many interfaces.
14673 We also avoid creating too many MethodSignatures.
14675 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14676 clear the "pending" bit if we find that there are problems with
14679 (TypeContainer.VerifyPendingMethods): Update to report errors of
14680 methods that look like implementations but are not.
14682 (TypeContainer.Define): Add support for explicit interface method
14685 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14687 * typemanager.cs: Keep track of the parameters here instead of
14688 being a feature of the TypeContainer.
14690 * class.cs: Drop the registration of parameters here, as
14691 InterfaceMethods are also interface declarations.
14693 * delegate.cs: Register methods with the TypeManager not only with
14694 the TypeContainer. This code was buggy.
14696 * interface.cs: Full registation here.
14698 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14700 * expression.cs: Remove reducer for binary expressions, it can not
14703 * const.cs: Put here the code that used to go into constant.cs
14705 * constant.cs: Put here the code for constants, this is a new base
14706 class for Literals.
14708 * literal.cs: Make Literal derive from Constant.
14710 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14712 * statement.cs (Return.Emit): Report error 157 if the user
14713 attempts to return from a finally block.
14715 (Return.Emit): Instead of emitting a return, jump to the end of
14718 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14719 LocalBuilder to store the result of the function. ReturnLabel is
14720 the target where we jump.
14723 2001-12-09 Radek Doulik <rodo@ximian.com>
14725 * cs-parser.jay: remember alias in current namespace
14727 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14730 * class.cs (LookupAlias): lookup alias in my_namespace
14732 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14734 (LookupAlias): lookup alias in this and if needed in parent
14737 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14741 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14742 making things static. I need this to avoid passing the
14743 TypeContainer when calling ParameterType.
14745 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14746 that did string manipulation to compute the type and then call
14747 GetType. Use Parameter.ParameterType instead.
14749 * cs-tokenizer.cs: Consume the suffix for floating values.
14751 * expression.cs (ParameterReference): figure out whether this is a
14752 reference parameter or not. Kill an extra variable by computing
14753 the arg_idx during emission.
14755 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14756 function that returns whether a parameter is an out/ref value or not.
14758 (Parameter.ParameterType): The type of the parameter (base,
14759 without ref/out applied).
14761 (Parameter.Resolve): Perform resolution here.
14762 (Parameter.ExternalType): The full type (with ref/out applied).
14764 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14765 support for expressions on the using statement.
14767 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14769 * statement.cs (Using.EmitLocalVariableDecls): Split the
14770 localvariable handling of the using statement.
14772 (Block.EmitMeta): Keep track of variable count across blocks. We
14773 were reusing slots on separate branches of blocks.
14775 (Try.Emit): Emit the general code block, we were not emitting it.
14777 Check the type of the declaration to be an IDisposable or
14778 something that can be implicity converted to it.
14780 Emit conversions if required.
14782 * ecore.cs (EmptyExpression): New utility class.
14783 (Expression.ImplicitConversionExists): New utility function.
14785 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14787 * statement.cs (Using): Implement.
14789 * expression.cs (LocalVariableReference): Support read only variables.
14791 * statement.cs: Remove the explicit emit for the Leave opcode.
14792 (VariableInfo): Add a readonly field.
14794 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14796 * ecore.cs (ConvCast): new class used to encapsulate the various
14797 explicit integer conversions that works in both checked and
14798 unchecked contexts.
14800 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14801 properly generate the overflow opcodes.
14803 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14805 * statement.cs: The correct type for the EmptyExpression is the
14806 element_type, not the variable type. Ravi pointed this out.
14808 2001-12-04 Ravi Pratap <ravi@ximian.com>
14810 * class.cs (Method::Define): Handle PInvoke methods specially
14811 by using DefinePInvokeMethod instead of the usual one.
14813 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14814 above to do the task of extracting information and defining the method.
14816 2001-12-04 Ravi Pratap <ravi@ximian.com>
14818 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14819 of the condition for string type.
14821 (Emit): Move that here.
14823 (ArrayCreation::CheckIndices): Keep string literals in their expression
14826 (EmitDynamicInitializers): Handle strings appropriately.
14828 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14830 * codegen.cs (EmitContext): Replace multiple variables with a
14831 single pointer to the current Switch statement.
14833 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14836 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14840 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14843 (Foreach.Emit): Foreach on arrays was not setting
14844 up the loop variables (for break/continue).
14846 (GotoCase): Semi-implented.
14848 2001-12-03 Ravi Pratap <ravi@ximian.com>
14850 * attribute.cs (CheckAttribute): Handle system attributes by using
14851 Attribute.GetAttributes to examine information we need.
14853 (GetValidPlaces): Same here.
14855 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14857 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14859 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14861 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14863 (Method::Emit): Handle the case when we are a PInvoke method.
14865 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14867 * expression.cs: Use ResolveWithSimpleName on compound names.
14869 2001-12-02 Ravi Pratap <ravi@ximian.com>
14871 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14872 before trying to reduce it.
14874 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14876 * constant.cs (LookupConstantValue): Implement.
14878 (EmitConstant): Use the above in emitting the constant.
14880 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14881 that are user-defined by doing a LookupConstantValue on them.
14883 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14886 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14888 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14890 (BaseAccess.DoResolve): Implement.
14892 (MemberAccess.DoResolve): Split this routine into a
14893 ResolveMemberAccess routine that can be used independently
14895 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14897 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14898 As that share bits of the implementation. Is returns a boolean,
14899 while As returns the Type that is being probed.
14901 2001-12-01 Ravi Pratap <ravi@ximian.com>
14903 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14904 instead of a Literal - much easier.
14906 (EnumInTransit): Remove - utterly useless :-)
14908 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14910 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14912 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14913 chain when we have no associated expression.
14915 2001-11-30 Ravi Pratap <ravi@ximian.com>
14917 * constant.cs (Define): Use Location while reporting the errror.
14919 Also emit a warning when 'new' is used and there is no inherited
14922 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14925 (LookupEnumValue): Implement to lookup an enum member's value and define it
14928 (Populate): Re-write accordingly to use the above routine.
14930 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14932 * expression.cs (This): Fix prototype for DoResolveLValue to
14933 override the base class DoResolveLValue.
14935 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14938 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14939 (we need to load the address of the field here). This fixes
14942 (FieldExpr.DoResolveLValue): Call the DoResolve
14943 function to initialize the Instance expression.
14945 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14946 correctly the GetEnumerator operation on a value type.
14948 * cs-parser.jay: Add more simple parsing error catches.
14950 * statement.cs (Switch): Add support for string switches.
14951 Handle null specially.
14953 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14955 2001-11-28 Ravi Pratap <ravi@ximian.com>
14957 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14959 (declare_local_constant): New helper function.
14961 * statement.cs (AddConstant): Keep a separate record of constants
14963 (IsConstant): Implement to determine if a variable is a constant.
14965 (GetConstantExpression): Implement.
14967 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14969 * statement.cs (IsVariableDefined): Re-write.
14971 2001-11-27 Ravi Pratap <ravi@ximian.com>
14973 * class.cs (TypeContainer::FindMembers): Look for constants
14974 in the case when we are looking for MemberTypes.Field
14976 * expression.cs (MemberAccess::DoResolve): Check that in the
14977 case we are a FieldExpr and a Literal, we are not being accessed
14978 by an instance reference.
14980 * cs-parser.jay (local_constant_declaration): Implement.
14982 (declaration_statement): Implement for constant declarations.
14984 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14986 * statement.cs (Switch): Catch double defaults.
14988 (Switch): More work on the switch() statement
14989 implementation. It works for integral values now, need to finish
14993 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14995 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14996 integer literals into other integer literals. To be used by
14999 2001-11-24 Ravi Pratap <ravi@ximian.com>
15001 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15004 (EmitDynamicInitializers): Cope with the above since we extract data
15005 directly from ArrayData now.
15007 (ExpectInitializers): Keep track of whether initializers are mandatory
15010 (Bounds): Make it a hashtable to prevent the same dimension being
15011 recorded for every element in that dimension.
15013 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15016 Also fix bug which was causing the indices to be emitted in the reverse
15019 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15021 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15022 unfinished. They do not work, because the underlying code is
15025 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15027 * cs-parser.jay: Remove bogus fixme.
15029 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15030 on Switch statement.
15032 2001-11-23 Ravi Pratap <ravi@ximian.com>
15034 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15037 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15038 parameter. Apparently, any expression is allowed.
15040 (ValidateInitializers): Update accordingly.
15042 (CheckIndices): Fix some tricky bugs thanks to recursion.
15044 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15045 I was being completely brain-dead.
15047 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15048 and re-write acordingly.
15050 (DelegateInvocation): Re-write accordingly.
15052 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15054 (MakeByteBlob): Handle types more correctly.
15056 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15057 initialization from expressions but it is incomplete because I am a complete
15060 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15062 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15063 on If. Basically, we have to return `true' (ie, we do return to
15064 our caller) only if both branches of the if return.
15066 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15067 short-circuit operators, handle them as short circuit operators.
15069 (Cast.DoResolve): Resolve type.
15070 (Cast.Cast): Take an expression as the target type.
15072 * cs-parser.jay (cast_expression): Remove old hack that only
15073 allowed a limited set of types to be handled. Now we take a
15074 unary_expression and we resolve to a type during semantic
15077 Use the grammar productions from Rhys to handle casts (this is
15078 not complete like Rhys syntax yet, we fail to handle that corner
15079 case that C# has regarding (-x), but we will get there.
15081 2001-11-22 Ravi Pratap <ravi@ximian.com>
15083 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15084 field which is an array type.
15086 * cs-parser.jay (declare_local_variables): Support array initialization too.
15088 * typemanager.cs (MakeKey): Implement.
15090 (everywhere): Use the above appropriately.
15092 * cs-parser.jay (for_statement): Update for array initialization while
15093 declaring variables.
15095 * ecore.cs : The error message was correct, it's the variable's names that
15096 were misleading ;-) Make the code more readable.
15098 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15099 the correct type etc.
15101 (ConvertExplicit): Handle Enum types by examining the underlying type.
15103 2001-11-21 Ravi Pratap <ravi@ximian.com>
15105 * parameter.cs (GetCallingConvention): Always return
15106 CallingConventions.Standard for now.
15108 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15110 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15111 and `r' after calling DoNumericPromotions.
15113 * ecore.cs: Fix error message (the types were in the wrong order).
15115 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15116 BindingFlags.Instance as well
15118 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15119 implicit int literal conversion in an empty cast so that we
15120 propagate the right type upstream.
15122 (UnboxCast): new class used to unbox value types.
15123 (Expression.ConvertExplicit): Add explicit type conversions done
15126 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15127 the target type before applying the implicit LongLiterals to ULong
15130 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15132 * cs-parser.jay (for_statement): Reworked the way For works: now
15133 we declare manually any variables that are introduced in
15134 for_initializer to solve the problem of having out-of-band code
15135 emition (that is what got for broken).
15137 (declaration_statement): Perform the actual variable declaration
15138 that used to be done in local_variable_declaration here.
15140 (local_variable_declaration): Do not declare anything, just pass
15141 the information on a DictionaryEntry
15143 2001-11-20 Ravi Pratap <ravi@ximian.com>
15145 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15146 re-write of the logic to now make it recursive.
15148 (UpdateIndices): Re-write accordingly.
15150 Store element data in a separate ArrayData list in the above methods.
15152 (MakeByteBlob): Implement to dump the array data into a byte array.
15154 2001-11-19 Ravi Pratap <ravi@ximian.com>
15156 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15159 * constant.cs (Define): Implement.
15161 (EmitConstant): Re-write fully.
15163 Pass in location info.
15165 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15168 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15169 DictionaryEntry since we need location info too.
15171 (constant_declaration): Update accordingly.
15173 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15174 code into another method : UpdateIndices.
15176 2001-11-18 Ravi Pratap <ravi@ximian.com>
15178 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15179 some type checking etc.
15181 2001-11-17 Ravi Pratap <ravi@ximian.com>
15183 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15184 bits to provide dimension info if the user skips doing that.
15186 Update second constructor to store the rank correctly.
15188 2001-11-16 Ravi Pratap <ravi@ximian.com>
15190 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15191 and try to implement.
15193 * ../errors/cs0150.cs : Add.
15195 * ../errors/cs0178.cs : Add.
15197 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15199 * statement.cs: Implement foreach on multi-dimensional arrays.
15201 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15202 name of the params argument.
15204 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15205 initializing the array.
15207 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15208 we can use this elsewhere.
15210 * statement.cs: Finish implementation of foreach for single
15213 * cs-parser.jay: Use an out-of-band stack to pass information
15214 around, I wonder why I need this.
15216 foreach_block: Make the new foreach_block the current_block.
15218 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15219 function used to return a static Parameters structure. Used for
15220 empty parameters, as those are created very frequently.
15222 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15224 2001-11-15 Ravi Pratap <ravi@ximian.com>
15226 * interface.cs : Default modifier is private, not public. The
15227 make verify test passes again.
15229 2001-11-15 Ravi Pratap <ravi@ximian.com>
15231 * support.cs (ReflectionParameters): Fix logic to determine
15232 whether the last parameter is a params one. Test 9 passes again.
15234 * delegate.cs (Populate): Register the builders we define with
15235 RegisterParameterForBuilder. Test 19 passes again.
15237 * cs-parser.jay (property_declaration): Reference $6 instead
15238 of $$ to get at the location.
15240 (indexer_declaration): Similar stuff.
15242 (attribute): Ditto.
15244 * class.cs (Property): Register parameters for the Get and Set methods
15245 if they exist. Test 23 passes again.
15247 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15248 call to EmitArguments as we are sure there aren't any params arguments.
15249 Test 32 passes again.
15251 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15252 IndexOutOfRangeException.
15254 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15255 Test 33 now passes again.
15257 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15259 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15260 broke a bunch of things. Will have to come up with a better way
15261 of tracking locations.
15263 * statement.cs: Implemented foreach for single dimension arrays.
15265 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15267 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15268 an error. This removes the lookup from the critical path.
15270 * cs-parser.jay: Removed use of temporary_loc, which is completely
15273 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15275 * support.cs (ReflectionParameters.ParameterModifier): Report
15276 whether the argument is a PARAMS argument or not.
15278 * class.cs: Set the attribute `ParamArrayAttribute' on the
15279 parameter argument.
15281 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15282 and cons_param_array_attribute (ConstructorInfo for
15283 ParamArrayAttribute).,
15285 * codegen.cs: Emit the return using the `Return' statement, that
15286 way we can report the error correctly for missing return values.
15288 * class.cs (Method.Emit): Clean up.
15290 * expression.cs (Argument.Resolve): Take another argument: the
15291 location where this argument is used. Notice that this is not
15292 part of the "Argument" class as to reduce the size of the
15293 structure (we know the approximate location anyways).
15295 Test if the argument is a variable-reference, if not, then
15296 complain with a 206.
15298 (Argument.Emit): Emit addresses of variables.
15300 (Argument.FullDesc): Simplify.
15302 (Invocation.DoResolve): Update for Argument.Resolve.
15304 (ElementAccess.DoResolve): ditto.
15306 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15307 method should be virtual, as this method is always virtual.
15309 (NewDelegate.DoResolve): Update for Argument.Resolve.
15311 * class.cs (ConstructorInitializer.DoResolve): ditto.
15313 * attribute.cs (Attribute.Resolve): ditto.
15315 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15317 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15319 * expression.cs (ParameterReference): Drop IStackStorage and implement
15320 IAssignMethod instead.
15322 (LocalVariableReference): ditto.
15324 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15325 IAssignMethod instead.
15327 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15329 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15330 enumerations that are used in heavily used structures derive from
15331 byte in a laughable and pathetic attempt to reduce memory usage.
15332 This is the kind of pre-optimzations that you should not do at
15333 home without adult supervision.
15335 * expression.cs (UnaryMutator): New class, used to handle ++ and
15336 -- separatedly from the other unary operators. Cleans up the
15337 code, and kills the ExpressionStatement dependency in Unary.
15339 (Unary): Removed `method' and `Arguments' from this class, making
15340 it smaller, and moving it all to SimpleCall, so I can reuse this
15341 code in other locations and avoid creating a lot of transient data
15342 strucutres when not required.
15344 * cs-parser.jay: Adjust for new changes.
15346 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15348 * enum.cs (Enum.Populate): If there is a failure during
15351 * cs-parser.jay (opt_enum_base): we used to catch type errors
15352 here, but this is really incorrect. The type error should be
15353 catched during semantic analysis.
15355 2001-12-11 Ravi Pratap <ravi@ximian.com>
15357 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15358 current_local_parameters as expected since I, in my stupidity, had forgotten
15361 * attribute.cs (GetValidPlaces): Fix stupid bug.
15363 * class.cs (Method::Emit): Perform check on applicability of attributes.
15365 (Constructor::Emit): Ditto.
15367 (Field::Emit): Ditto.
15369 (Field.Location): Store location information.
15371 (Property, Event, Indexer, Operator): Ditto.
15373 * cs-parser.jay (field_declaration): Pass in location for each field.
15375 * ../errors/cs0592.cs : Add.
15377 2001-11-12 Ravi Pratap <ravi@ximian.com>
15379 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15381 (InitCoreTypes): Update accordingly.
15383 (RegisterAttrType, LookupAttr): Implement.
15385 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15386 info about the same.
15388 (Resolve): Update to populate the above as necessary.
15390 (Error592): Helper.
15392 (GetValidPlaces): Helper to the above.
15394 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15396 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15398 2001-11-12 Ravi Pratap <ravi@ximian.com>
15400 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15402 * ../errors/cs0617.cs : Add.
15404 2001-11-11 Ravi Pratap <ravi@ximian.com>
15406 * enum.cs (Emit): Rename to Populate to be more consistent with what
15407 we expect it to do and when exactly it is called.
15409 * class.cs, rootcontext.cs : Update accordingly.
15411 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15412 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15414 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15416 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15417 of a fieldinfo using the above, when dealing with a FieldBuilder.
15419 2001-11-10 Ravi Pratap <ravi@ximian.com>
15421 * ../errors/cs0031.cs : Add.
15423 * ../errors/cs1008.cs : Add.
15425 * ../errrors/cs0543.cs : Add.
15427 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15430 (FindMembers): Implement.
15432 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15433 enums and delegates too.
15435 (enum_types): Rename to builder_to_enum.
15437 (delegate_types): Rename to builder_to_delegate.
15439 * delegate.cs (FindMembers): Implement.
15441 2001-11-09 Ravi Pratap <ravi@ximian.com>
15443 * typemanager.cs (IsEnumType): Implement.
15445 * enum.cs (Emit): Re-write parts to account for the underlying type
15446 better and perform checking etc.
15448 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15449 of the underlying type.
15451 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15454 * enum.cs (error31): Helper to report error #31.
15456 * cs-parser.jay (enum_declaration): Store location of each member too.
15458 * enum.cs (member_to_location): New hashtable.
15460 (AddEnumMember): Update location hashtable.
15462 (Emit): Use the location of each member while reporting errors.
15464 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15466 * cs-parser.jay: A for_initializer if is a
15467 local_variable_declaration really ammount to have an implicit
15468 block with the variable declaration and no initializer for for.
15470 * statement.cs (For.Emit): Cope with null initializers.
15472 This fixes the infinite loop on for initializers.
15474 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15476 * enum.cs: More cleanup.
15478 * ecore.cs: Remove dead code.
15480 * class.cs (Property.Emit): More simplification.
15481 (Event.Emit): ditto.
15483 Reworked to have less levels of indentation.
15485 2001-11-08 Ravi Pratap <ravi@ximian.com>
15487 * class.cs (Property): Emit attributes.
15497 * enum.cs (Emit): Ditto.
15499 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15502 * class.cs (Field, Event, etc.): Move attribute generation into the
15503 Emit method everywhere.
15505 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15506 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15507 as we had no way of defining nested enums !
15509 * rootcontext.cs : Adjust code accordingly.
15511 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15513 2001-11-07 Ravi Pratap <ravi@ximian.com>
15515 * expression.cs (EvalConstantExpression): Move into ecore.cs
15517 * enum.cs (Enum): Rename some members and make them public and readonly
15518 according to our convention.
15520 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15523 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15525 (Enum::Emit): Write a simple version for now which doesn't try to compute
15526 expressions. I shall modify this to be more robust in just a while.
15528 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15530 (TypeContainer::CloseType): Create the Enum types too.
15532 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15534 * expression.cs (EvalConstantExpression): Get rid of completely.
15536 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15537 user-defined values and other cases.
15539 (IsValidEnumLiteral): Helper function.
15541 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15542 out there in the case we had a literal FieldExpr.
15544 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15546 (Literalize): Revamp a bit to take two arguments.
15548 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15550 2001-11-06 Ravi Pratap <ravi@ximian.com>
15552 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15554 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15556 (Resolve): Use the above to ensure we have proper initializers.
15558 2001-11-05 Ravi Pratap <ravi@ximian.com>
15560 * expression.cs (Expression::EvalConstantExpression): New method to
15561 evaluate constant expressions.
15563 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15565 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15567 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15570 (Binary.ResolveOperator): Handle operator != (object a, object b)
15571 and operator == (object a, object b);
15573 (Binary.DoNumericPromotions): Indicate whether the numeric
15574 promotion was possible.
15576 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15579 Made the ArrayAccess implement interface IAssignMethod instead of
15580 IStackStore as the order in which arguments are passed reflects
15583 * assign.cs: Instead of using expr.ExprClass to select the way of
15584 assinging, probe for the IStackStore/IAssignMethod interfaces.
15586 * typemanager.cs: Load InitializeArray definition.
15588 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15589 static data that can be used to initialize arrays.
15591 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15593 * expression.cs: Handle operator== and operator!= for booleans.
15595 (Conditioal.Reduce): Implement reducer for the ?: operator.
15597 (Conditional.Resolve): Implement dead code elimination.
15599 (Binary.Resolve): Catch string literals and return a new
15600 concatenated string.
15602 (Unary.Reduce): Implement reduction of unary expressions.
15604 * ecore.cs: Split out the expression core handling here.
15606 (Expression.Reduce): New method used to perform constant folding
15607 and CSE. This is needed to support constant-expressions.
15609 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15610 targets, and optimize for !x.
15612 2001-11-04 Ravi Pratap <ravi@ximian.com>
15614 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15615 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15616 set custom atttributes.
15618 * literal.cs (Literal::GetValue): New abstract method to return the actual
15619 value of the literal, cast as an object.
15621 (*Literal): Implement GetValue method.
15623 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15624 expressions to the arraylist but objects of type Argument.
15626 * class.cs (TypeContainer::Emit): Emit our attributes too.
15628 (Method::Emit, Constructor::Emit): Ditto.
15630 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15631 to be ignoring earlier.
15633 2001-11-03 Ravi Pratap <ravi@ximian.com>
15635 * attribute.cs (AttributeSection::Define): Implement to do the business
15636 of constructing a CustomAttributeBuilder.
15638 (Attribute): New trivial class. Increases readability of code.
15640 * cs-parser.jay : Update accordingly.
15642 (positional_argument_list, named_argument_list, named_argument): New rules
15644 (attribute_arguments): Use the above so that we are more correct.
15646 2001-11-02 Ravi Pratap <ravi@ximian.com>
15648 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15649 to perform all checks for a method with a params parameter.
15651 (Invocation::OverloadResolve): Update to use the above method and therefore
15652 cope correctly with params method invocations.
15654 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15657 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15658 constructors in our parent too because we can't afford to miss out on
15661 * attribute.cs (AttributeSection): New name for the class Attribute
15663 Other trivial changes to improve readability.
15665 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15666 use the new class names.
15668 2001-11-01 Ravi Pratap <ravi@ximian.com>
15670 * class.cs (Method::Define): Complete definition for params types too
15672 (Indexer::Define): Ditto.
15674 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15675 Cope everywhere with a request for info about the array parameter.
15677 2001-11-01 Ravi Pratap <ravi@ximian.com>
15679 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15681 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15682 local_variable_type to extract the string corresponding to the type.
15684 (local_variable_type): Fixup the action to use the new helper method.
15686 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15689 * expression.cs : Clean out code which uses the above.
15691 2001-10-31 Ravi Pratap <ravi@ximian.com>
15693 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15694 and bale out if necessary by returning a false.
15696 (RegisterProperty): Ditto.
15698 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15699 and print out appropriate error messages.
15701 * interface.cs (everywhere): Ditto.
15703 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15704 location to constructor.
15706 * class.cs (Property, Event, Indexer): Update accordingly.
15708 * ../errors/cs111.cs : Added.
15710 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15711 of a method, as laid down by the spec.
15713 (Invocation::OverloadResolve): Use the above method.
15715 2001-10-31 Ravi Pratap <ravi@ximian.com>
15717 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15718 now take a TypeContainer and a Parameters object.
15720 (ParameterData): Modify return type of ParameterModifier method to be
15721 Parameter.Modifier and not a string.
15723 (ReflectionParameters, InternalParameters): Update accordingly.
15725 * expression.cs (Argument::GetParameterModifier): Same here.
15727 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15728 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15729 symbol in it at all so maybe this is only for now.
15731 2001-10-30 Ravi Pratap <ravi@ximian.com>
15733 * support.cs (InternalParameters): Constructor now takes an extra argument
15734 which is the actual Parameters class.
15736 (ParameterDesc): Update to provide info on ref/out modifiers.
15738 * class.cs (everywhere): Update call to InternalParameters to pass in
15739 the second argument too.
15741 * support.cs (ParameterData): Add ParameterModifier, which is a method
15742 to return the modifier info [ref/out etc]
15744 (InternalParameters, ReflectionParameters): Implement the above.
15746 * expression.cs (Argument::ParameterModifier): Similar function to return
15747 info about the argument's modifiers.
15749 (Invocation::OverloadResolve): Update to take into account matching modifiers
15752 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15753 a new SetFormalParameters object which we pass to InternalParameters.
15755 2001-10-30 Ravi Pratap <ravi@ximian.com>
15757 * expression.cs (NewArray): Merge into the ArrayCreation class.
15759 2001-10-29 Ravi Pratap <ravi@ximian.com>
15761 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15762 NewUserdefinedArray into one as there wasn't much of a use in having
15765 * expression.cs (Argument): Change field's name to ArgType from Type.
15767 (Type): New readonly property which returns the proper type, taking into
15768 account ref/out modifiers.
15770 (everywhere): Adjust code accordingly for the above.
15772 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15773 whether we are emitting for a ref or out parameter.
15775 * expression.cs (Argument::Emit): Use the above field to set the state.
15777 (LocalVariableReference::Emit): Update to honour the flag and emit the
15780 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15782 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15784 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15786 (ReflectionParameters, InternalParameters): Implement the above method.
15788 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15791 (Invocation::FullMethodDesc): Ditto.
15793 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15795 * cs-parser.jay: Add extra production for the second form of array
15798 * expression.cs (ArrayCreation): Update to reflect the above
15801 * Small changes to prepare for Array initialization.
15803 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15805 * typemanager.cs (ImplementsInterface): interface might be null;
15806 Deal with this problem;
15808 Also, we do store negative hits on the cache (null values), so use
15809 this instead of calling t.GetInterfaces on the type everytime.
15811 2001-10-28 Ravi Pratap <ravi@ximian.com>
15813 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15815 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15816 split functionality out into different classes.
15818 (New::FormArrayType): Move into NewBuiltinArray.
15820 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15823 (NewBuiltinArray): New class to handle creation of built-in arrays.
15825 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15826 account creation of one-dimensional arrays.
15828 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15830 (NewUserdefinedArray::DoResolve): Implement.
15832 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15834 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15835 we maintain inside the TypeManager. This is necessary to perform lookups on the
15838 (LookupType): Update to perform GetType on the module builders too.
15840 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15842 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15844 2001-10-23 Ravi Pratap <ravi@ximian.com>
15846 * expression.cs (New::DoResolve): Implement guts of array creation.
15848 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15850 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15852 * expression.cs: Fix bug I introduced lsat night that broke
15855 (Expression.Resolve): Report a 246 error (can not resolve name)
15856 if we find a SimpleName in the stream.
15858 (Expression.ResolveLValue): Ditto.
15860 (Expression.ResolveWithSimpleName): This function is a variant of
15861 ResolveName, this one allows SimpleNames to be returned without a
15862 warning. The only consumer of SimpleNames is MemberAccess
15864 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15866 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15867 might arrive here. I have my doubts that this is correct.
15869 * statement.cs (Lock): Implement lock statement.
15871 * cs-parser.jay: Small fixes to support `lock' and `using'
15873 * cs-tokenizer.cs: Remove extra space
15875 * driver.cs: New flag --checked, allows to turn on integer math
15878 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15879 Threading.Monitor.Exit
15881 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15883 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15884 Expression Class to be IndexerAccess.
15886 Notice that Indexer::DoResolve sets the eclass to Value.
15888 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15890 * class.cs (TypeContainer::Emit): Emit code for indexers.
15892 * assign.cs (IAssignMethod): New interface implemented by Indexers
15893 and Properties for handling assignment.
15895 (Assign::Emit): Simplify and reuse code.
15897 * expression.cs (IndexerAccess, PropertyExpr): Implement
15898 IAssignMethod, clean up old code.
15900 2001-10-22 Ravi Pratap <ravi@ximian.com>
15902 * typemanager.cs (ImplementsInterface): New method to determine if a type
15903 implements a given interface. Provides a nice cache too.
15905 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15908 (ConvertReferenceExplicit): Ditto.
15910 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15911 various methods, with correct names etc.
15913 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15914 Operator.UnaryNegation.
15916 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15917 we have a unary plus or minus operator.
15919 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15922 * everywhere : update accordingly.
15924 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15927 * class.cs (Method::Define): For the case where we are implementing a method
15928 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15929 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15931 2001-10-21 Ravi Pratap <ravi@ximian.com>
15933 * interface.cs (FindMembers): Implement to work around S.R.E
15936 * typemanager.cs (IsInterfaceType): Implement.
15938 (FindMembers): Update to handle interface types too.
15940 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15941 use IsAssignableFrom as that is not correct - it doesn't work.
15943 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15944 and accordingly override EmitStatement.
15946 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15947 using the correct logic :-)
15949 2001-10-19 Ravi Pratap <ravi@ximian.com>
15951 * ../errors/cs-11.cs : Add to demonstrate error -11
15953 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15955 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15956 then pass this as a hint to ResolveLValue.
15958 * expression.cs (FieldExpr): Add Location information
15960 (FieldExpr::LValueResolve): Report assignment to readonly
15963 (Expression::ExprClassFromMemberInfo): Pass location information.
15965 (Expression::ResolveLValue): Add new method that resolves an
15968 (Expression::DoResolveLValue): Default invocation calls
15971 (Indexers): New class used to keep track of indexers in a given
15974 (IStackStore): Renamed from LValue, as it did not really describe
15975 what this did. Also ResolveLValue is gone from this interface and
15976 now is part of Expression.
15978 (ElementAccess): Depending on the element access type
15980 * typemanager.cs: Add `indexer_name_type' as a Core type
15981 (System.Runtime.CompilerServices.IndexerNameAttribute)
15983 * statement.cs (Goto): Take a location.
15985 2001-10-18 Ravi Pratap <ravi@ximian.com>
15987 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15988 if two delegates are compatible.
15990 (NewDelegate::DoResolve): Update to take care of the case when
15991 we instantiate a delegate from another delegate.
15993 * typemanager.cs (FindMembers): Don't even try to look up members
15994 of Delegate types for now.
15996 2001-10-18 Ravi Pratap <ravi@ximian.com>
15998 * delegate.cs (NewDelegate): New class to take care of delegate
16001 * expression.cs (New): Split the delegate related code out into
16002 the NewDelegate class.
16004 * delegate.cs (DelegateInvocation): New class to handle delegate
16007 * expression.cs (Invocation): Split out delegate related code into
16008 the DelegateInvocation class.
16010 2001-10-17 Ravi Pratap <ravi@ximian.com>
16012 * expression.cs (New::DoResolve): Implement delegate creation fully
16013 and according to the spec.
16015 (New::DoEmit): Update to handle delegates differently.
16017 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16018 because of which we were printing out arguments in reverse order !
16020 * delegate.cs (VerifyMethod): Implement to check if the given method
16021 matches the delegate.
16023 (FullDelegateDesc): Implement.
16025 (VerifyApplicability): Implement.
16027 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16028 delegate invocations too.
16030 (Invocation::Emit): Ditto.
16032 * ../errors/cs1593.cs : Added.
16034 * ../errors/cs1594.cs : Added.
16036 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16038 2001-10-16 Ravi Pratap <ravi@ximian.com>
16040 * typemanager.cs (intptr_type): Core type for System.IntPtr
16042 (InitCoreTypes): Update for the same.
16044 (iasyncresult_type, asynccallback_type): Ditto.
16046 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16049 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16052 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16053 the builders for the 4 members of a delegate type :-)
16055 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16058 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16060 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16062 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16064 * statement.cs (Break::Emit): Implement.
16065 (Continue::Emit): Implement.
16067 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16068 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16069 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16070 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16073 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16074 properties that track the label for the current loop (begin of the
16075 loop and end of the loop).
16077 2001-10-15 Ravi Pratap <ravi@ximian.com>
16079 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16080 use of emitting anything at all.
16082 * class.cs, rootcontext.cs : Get rid of calls to the same.
16084 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16086 (Populate): Define the constructor correctly and set the implementation
16089 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16092 (AddDelegateType): Implement.
16094 (IsDelegateType): Implement helper method.
16096 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16098 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16099 and accordingly handle it.
16101 * delegate.cs (Populate): Take TypeContainer argument.
16102 Implement bits to define the Invoke method. However, I still haven't figured out
16103 how to take care of the native int bit :-(
16105 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16106 Qualify the name of the delegate, not its return type !
16108 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16111 (StandardConversionExists): Checking for array types turns out to be recursive.
16113 (ConvertReferenceExplicit): Implement array conversion.
16115 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16117 2001-10-12 Ravi Pratap <ravi@ximian.com>
16119 * cs-parser.jay (delegate_declaration): Store the fully qualified
16120 name as it is a type declaration.
16122 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16125 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16126 as TypeContainer::DefineType.
16128 (Populate): Method in which all the definition of the various methods (Invoke)
16131 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16134 (CloseDelegate): Finally creates the delegate.
16136 * class.cs (TypeContainer::DefineType): Update to define delegates.
16137 (Populate, Emit and CloseType): Do the same thing here too.
16139 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16140 delegates in all these operations.
16142 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16144 * expression.cs: LocalTemporary: a new expression used to
16145 reference a temporary that has been created.
16147 * assign.cs: Handle PropertyAccess back here, so that we can
16148 provide the proper semantic access to properties.
16150 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16151 a few more explicit conversions.
16153 * modifiers.cs: `NEW' modifier maps to HideBySig.
16155 * expression.cs (PropertyExpr): Make this into an
16156 ExpressionStatement, and support the EmitStatement code path.
16158 Perform get/set error checking, clean up the interface.
16160 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16161 them into toplevel access objects.
16163 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16165 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16168 * typemanager.cs: Keep track here of our PropertyBuilders again to
16169 work around lameness in SRE.
16171 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16173 * expression.cs (LValue::LValueResolve): New method in the
16174 interface, used to perform a second resolution pass for LValues.
16176 (This::DoResolve): Catch the use of this in static methods.
16178 (This::LValueResolve): Implement.
16180 (This::Store): Remove warning, assigning to `this' in structures
16183 (Invocation::Emit): Deal with invocation of
16184 methods on value types. We need to pass the address to structure
16185 methods rather than the object itself. (The equivalent code to
16186 emit "this" for structures leaves the entire structure on the
16187 stack instead of a pointer to it).
16189 (ParameterReference::DoResolve): Compute the real index for the
16190 argument based on whether the method takes or not a `this' pointer
16191 (ie, the method is static).
16193 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16194 value types returned from functions when we need to invoke a
16195 method on the sturcture.
16198 2001-10-11 Ravi Pratap <ravi@ximian.com>
16200 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16201 defining the type in the Modulebuilder or Typebuilder. This is to take
16202 care of nested types which need to be defined on the TypeBuilder using
16203 DefineNestedMethod.
16205 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16206 methods in RootContext, only ported to be part of TypeContainer.
16208 (TypeContainer::GetInterfaceOrClass): Ditto.
16210 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16212 * interface.cs (Interface::DefineInterface): New method. Does exactly
16213 what RootContext.CreateInterface did earlier, only it takes care of nested types
16216 (Interface::GetInterfaces): Move from RootContext here and port.
16218 (Interface::GetInterfaceByName): Same here.
16220 * rootcontext.cs (ResolveTree): Re-write.
16222 (PopulateTypes): Re-write.
16224 * class.cs (TypeContainer::Populate): Populate nested types too.
16225 (TypeContainer::Emit): Emit nested members too.
16227 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16228 instead just use the name argument passed in as it is already fully
16231 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16232 to TypeContainer mapping to see if a type is user-defined.
16234 * class.cs (TypeContainer::CloseType): Implement.
16236 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16237 the default constructor.
16239 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16242 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16244 * interface.cs (CloseType): Create the type here.
16246 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16249 Remove all the methods which are now in TypeContainer.
16251 2001-10-10 Ravi Pratap <ravi@ximian.com>
16253 * delegate.cs (Define): Re-write bits to define the delegate
16256 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16258 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16260 * expression.cs (ImplicitReferenceConversion): handle null as well
16261 as a source to convert to any reference type.
16263 * statement.cs (Return): Perform any implicit conversions to
16264 expected return type.
16266 Validate use of return statement.
16268 * codegen.cs (EmitContext): Pass the expected return type here.
16270 * class.cs (Method, Constructor, Property): Pass expected return
16271 type to EmitContext.
16273 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16275 * expression.cs: Make DoResolve take an EmitContext instead of a
16278 Replaced `l' and `location' for `loc', for consistency.
16280 (Error, Warning): Remove unneeded Tc argument.
16282 * assign.cs, literal.cs, constant.cs: Update to new calling
16285 * codegen.cs: EmitContext now contains a flag indicating whether
16286 code is being generated in a static method or not.
16288 * cs-parser.jay: DecomposeQI, new function that replaces the old
16289 QualifiedIdentifier. Now we always decompose the assembled
16290 strings from qualified_identifier productions into a group of
16293 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16295 * rootcontext.cs: Deal with field-less struct types correctly now
16296 by passing the size option to Define Type.
16298 * class.cs: Removed hack that created one static field.
16300 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16302 * statement.cs: Moved most of the code generation here.
16304 2001-10-09 Ravi Pratap <ravi@ximian.com>
16306 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16309 (ElementAccess): Remove useless bits for now - keep checks as the spec
16312 2001-10-08 Ravi Pratap <ravi@ximian.com>
16314 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16315 and start performing checks according to the spec.
16317 2001-10-07 Ravi Pratap <ravi@ximian.com>
16319 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16320 rank_specifiers instead.
16322 (rank_specifiers): Change the order in which the rank specifiers are stored
16324 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16326 * expression.cs (ElementAccess): Implement the LValue interface too.
16328 2001-10-06 Ravi Pratap <ravi@ximian.com>
16330 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16331 except that user defined conversions are not included.
16333 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16334 perform the conversion of the return type, if necessary.
16336 (New::DoResolve): Check whether we are creating an array or an object
16337 and accordingly do the needful.
16339 (New::Emit): Same here.
16341 (New::DoResolve): Implement guts of array creation.
16343 (New::FormLookupType): Helper function.
16345 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16347 * codegen.cs: Removed most of the code generation here, and move the
16348 corresponding code generation bits to the statement classes.
16350 Added support for try/catch/finalize and throw.
16352 * cs-parser.jay: Added support for try/catch/finalize.
16354 * class.cs: Catch static methods having the flags override,
16355 virtual or abstract.
16357 * expression.cs (UserCast): This user cast was not really doing
16358 what it was supposed to do. Which is to be born in fully resolved
16359 state. Parts of the resolution were being performed at Emit time!
16363 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16365 * expression.cs: Implicity convert the result from UserCast.
16367 2001-10-05 Ravi Pratap <ravi@ximian.com>
16369 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16370 prevented it from working correctly.
16372 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16373 merely ConvertImplicit.
16375 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16377 * typemanager.cs: Make the LookupTypeContainer function static,
16378 and not per-instance.
16380 * class.cs: Make static FindMembers (the one that takes a Type
16383 * codegen.cs: Add EmitForeach here.
16385 * cs-parser.jay: Make foreach a toplevel object instead of the
16386 inline expansion, as we need to perform semantic analysis on it.
16388 2001-10-05 Ravi Pratap <ravi@ximian.com>
16390 * expression.cs (Expression::ImplicitUserConversion): Rename to
16391 UserDefinedConversion.
16393 (Expression::UserDefinedConversion): Take an extra argument specifying
16394 whether we look for explicit user conversions too.
16396 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16398 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16400 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16401 with the appropriate arguments.
16403 * cs-parser.jay (cast_expression): Record location too.
16405 * expression.cs (Cast): Record location info.
16407 (Expression::ConvertExplicit): Take location argument.
16409 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16410 to determine if we are doing explicit conversions.
16412 (UserCast::Emit): Update accordingly.
16414 (Expression::ConvertExplicit): Report an error if everything fails.
16416 * ../errors/cs0030.cs : Add.
16418 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16420 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16421 virtual and newslot bits.
16423 * class.cs (TypeContainer::RegisterRequiredImplementations):
16424 Record methods we need.
16426 (TypeContainer::MakeKey): Helper function to make keys for
16427 MethodBases, since the Methodbase key is useless.
16429 (TypeContainer::Populate): Call RegisterRequiredImplementations
16430 before defining the methods.
16432 Create a mapping for method_builders_to_methods ahead of time
16433 instead of inside a tight loop.
16435 (::RequireMethods): Accept an object as the data to set into the
16436 hashtable so we can report interface vs abstract method mismatch.
16438 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16440 * report.cs: Make all of it static.
16442 * rootcontext.cs: Drop object_type and value_type computations, as
16443 we have those in the TypeManager anyways.
16445 Drop report instance variable too, now it is a global.
16447 * driver.cs: Use try/catch on command line handling.
16449 Add --probe option to debug the error reporting system with a test
16452 * report.cs: Add support for exiting program when a probe
16453 condition is reached.
16455 2001-10-03 Ravi Pratap <ravi@ximian.com>
16457 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16458 we do a forcible conversion regardless of type, to check if
16459 ForceConversion returns a null.
16461 (Binary::error19): Use location to report error.
16463 (Unary::error23): Use location here too.
16465 * ../errors/cs0019.cs : Check in.
16467 * ../errors/cs0023.cs : Check in.
16469 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16470 case of a non-null MethodInfo object with a length of 0 !
16472 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16473 an applicable member - according to the spec :-)
16474 Also fix logic to find members in base types.
16476 (Unary::ResolveOperator): Same here.
16478 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16479 as I was getting thoroughly confused between this and error19 :-)
16481 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16482 (::FindMostEncompassedType): Implement.
16483 (::FindMostEncompassingType): Implement.
16484 (::StandardConversionExists): Implement.
16486 (UserImplicitCast): Re-vamp. We now need info about most specific
16487 source and target types so that we can do the necessary conversions.
16489 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16490 mathematical union with no duplicates.
16492 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16494 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16495 in order from base classes to child classes, so that we can in
16496 child classes look up in our parent for method names and
16497 attributes (required for handling abstract, virtual, new, override
16498 constructs: we need to instrospect our base class, and if we dont
16499 populate the classes in order, the introspection might be
16500 incorrect. For example, a method could query its parent before
16501 the parent has any methods and would determine that the parent has
16502 no abstract methods (while it could have had them)).
16504 (RootContext::CreateType): Record the order in which we define the
16507 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16509 * class.cs (TypeContainer::Populate): Also method definitions can
16510 fail now, keep track of this.
16512 (TypeContainer::FindMembers): Implement support for
16513 DeclaredOnly/noDeclaredOnly flag.
16515 (Constructor::Emit) Return the ConstructorBuilder.
16517 (Method::Emit) Return the MethodBuilder.
16518 Check for abstract or virtual methods to be public.
16520 * rootcontext.cs (RootContext::CreateType): Register all the
16521 abstract methods required for the class to be complete and the
16522 interface methods that must be implemented.
16524 * cs-parser.jay: Report error 501 (method requires body if it is
16525 not marked abstract or extern).
16527 * expression.cs (TypeOf::Emit): Implement.
16529 * typemanager.cs: runtime_handle_type, new global type.
16531 * class.cs (Property::Emit): Generate code for properties.
16533 2001-10-02 Ravi Pratap <ravi@ximian.com>
16535 * expression.cs (Unary::ResolveOperator): Find operators on base type
16536 too - we now conform exactly to the spec.
16538 (Binary::ResolveOperator): Same here.
16540 * class.cs (Operator::Define): Fix minor quirk in the tests.
16542 * ../errors/cs0215.cs : Added.
16544 * ../errors/cs0556.cs : Added.
16546 * ../errors/cs0555.cs : Added.
16548 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16550 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16551 single integer which is really efficient
16553 2001-10-01 Ravi Pratap <ravi@ximian.com>
16555 * expression.cs (Expression::ImplicitUserConversion): Use location
16556 even in the case when we are examining True operators.
16558 * class.cs (Operator::Define): Perform extensive checks to conform
16559 with the rules for operator overloading in the spec.
16561 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16562 some of the other conversions mentioned in the spec.
16564 * typemanager.cs (array_type): New static member for the System.Array built-in
16567 (cloneable_interface): For System.ICloneable interface.
16569 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16570 we start resolving the tree and populating types.
16572 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16574 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16576 * expression.cs (Expression::ExprClassFromMemberInfo,
16577 Expression::Literalize): Create literal expressions from
16578 FieldInfos which are literals.
16580 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16581 type casts, because they were wrong. The test suite in tests
16584 (ImplicitNumericConversion): ushort to ulong requires a widening
16587 Int32 constant to long requires widening cast as well.
16589 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16590 for integers because the type on the stack is not i4.
16592 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16594 * expression.cs (report118): require location argument.
16596 * parameter.cs: Do not dereference potential null value.
16598 * class.cs: Catch methods that lack the `new' keyword when
16599 overriding a name. Report warnings when `new' is used without
16600 anything being there to override.
16602 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16604 * class.cs: Only add constructor to hashtable if it is non-null
16605 (as now constructors can fail on define).
16607 (TypeManager, Class, Struct): Take location arguments.
16609 Catch field instance initialization in structs as errors.
16611 accepting_filter: a new filter for FindMembers that is static so
16612 that we dont create an instance per invocation.
16614 (Constructor::Define): Catch errors where a struct constructor is
16617 * cs-parser.jay: Pass location information for various new
16620 * delegate.cs (Delegate): take a location argument.
16622 * driver.cs: Do not call EmitCode if there were problesm in the
16623 Definition of the types, as many Builders wont be there.
16625 * decl.cs (Decl::Decl): Require a location argument.
16627 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16628 into integers, and find the most appropiate integer for it.
16630 * literal.cs: Implement ULongLiteral.
16632 * rootcontext.cs: Provide better information about the location of
16633 failure when CreateType fails.
16635 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16637 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16640 * expression.cs (Binary::CheckShiftArguments): Add missing type
16642 (Binary::ResolveOperator): Add type to the logical and and logical
16643 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16646 (Binary::DoNumericPromotions): In the case where either argument
16647 is ulong (and most signed types combined with ulong cause an
16648 error) perform implicit integer constant conversions as well.
16650 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16652 * expression.cs (UserImplicitCast): Method should always be
16654 (Invocation::BetterConversion): Simplified test for IntLiteral.
16656 (Expression::ImplicitNumericConversion): Split this routine out.
16657 Put the code that performs implicit constant integer conversions
16660 (Expression::Resolve): Become a wrapper around DoResolve so we can
16661 check eclass and type being set after resolve.
16663 (Invocation::Badness): Remove this dead function
16665 (Binary::ResolveOperator): Do not compute the expensive argumnets
16666 unless we have a union for it.
16668 (Probe::Emit): Is needs to do an isinst and then
16669 compare against null.
16671 (::CanConvert): Added Location argument. If the Location argument
16672 is null (Location.Null), then we do not report errors. This is
16673 used by the `probe' mechanism of the Explicit conversion. We do
16674 not want to generate an error for something that the user
16675 explicitly requested to be casted. But the pipeline for an
16676 explicit cast first tests for potential implicit casts.
16678 So for now, if the Location is null, it means `Probe only' to
16679 avoid adding another argument. Might have to revise this
16682 (ClassCast): New class used to type cast objects into arbitrary
16683 classes (used in Explicit Reference Conversions).
16685 Implement `as' as well.
16687 Reverted all the patches from Ravi below: they were broken:
16689 * The use of `level' as a mechanism to stop recursive
16690 invocations is wrong. That was there just to catch the
16691 bug with a strack trace but not as a way of addressing
16694 To fix the problem we have to *understand* what is going
16695 on and the interactions and come up with a plan, not
16696 just get things going.
16698 * The use of the type conversion cache that I proposed
16699 last night had an open topic: How does this work across
16700 protection domains. A user defined conversion might not
16701 be public in the location where we are applying the
16702 conversion, a different conversion might be selected
16703 (ie, private A->B (better) but public B->A (worse),
16704 inside A, A->B applies, but outside it, B->A will
16707 * On top of that (ie, even if the above is solved),
16708 conversions in a cache need to be abstract. Ie, `To
16709 convert from an Int to a Short use an OpcodeCast', not
16710 `To convert from an Int to a Short use the OpcodeCast on
16711 the variable 5' (which is what this patch was doing).
16713 2001-09-28 Ravi Pratap <ravi@ximian.com>
16715 * expression.cs (Invocation::ConversionExists): Re-write to use
16716 the conversion cache
16718 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16719 cache all conversions done, not just user-defined ones.
16721 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16722 to determine if a conversion exists instead of acutually trying to
16723 perform the conversion. It's faster too.
16725 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16726 and only then attempt the implicit conversion.
16728 2001-09-28 Ravi Pratap <ravi@ximian.com>
16730 * expression.cs (ConvertImplicit): Use a cache for conversions
16731 already found. Check level of recursion and bail out if necessary.
16733 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16735 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16736 Export standard methods that we expect for string operations.
16738 * statement.cs (Block::UsageWarning): Track usage of variables and
16739 report the errors for not used variables.
16741 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16744 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16746 * codegen.cs: remove unnneded code
16748 * expression.cs: Removed BuiltinTypeAccess class
16750 Fix the order in which implicit conversions are
16753 The previous fixed dropped support for boxed conversions (adding a
16754 test to the test suite now)
16756 (UserImplicitCast::CanConvert): Remove test for source being null,
16757 that code is broken. We should not feed a null to begin with, if
16758 we do, then we should track the bug where the problem originates
16759 and not try to cover it up here.
16761 Return a resolved expression of type UserImplicitCast on success
16762 rather than true/false. Ravi: this is what I was talking about,
16763 the pattern is to use a static method as a "constructor" for
16766 Also, do not create arguments until the very last minute,
16767 otherwise we always create the arguments even for lookups that
16768 will never be performed.
16770 (UserImplicitCast::Resolve): Eliminate, objects of type
16771 UserImplicitCast are born in a fully resolved state.
16773 * typemanager.cs (InitCoreTypes): Init also value_type
16774 (System.ValueType).
16776 * expression.cs (Cast::Resolve): First resolve the child expression.
16778 (LValue): Add new method AddressOf to be used by
16781 Change the argument of Store to take an EmitContext instead of an
16782 ILGenerator, because things like FieldExpr need to be able to call
16783 their children expression to generate the instance code.
16785 (Expression::Error, Expression::Warning): Sugar functions for
16788 (Expression::MemberLookup): Accept a TypeContainer instead of a
16789 Report as the first argument.
16791 (Expression::ResolvePrimary): Killed. I still want to improve
16792 this as currently the code is just not right.
16794 (Expression::ResolveMemberAccess): Simplify, but it is still
16797 (Unary::Resolve): Catch errors in AddressOf operators.
16799 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16800 index to a byte for the short-version, or the compiler will choose
16801 the wrong Emit call, which generates the wrong data.
16803 (ParameterReference::Emit, ::Store): same.
16805 (FieldExpr::AddressOf): Implement.
16807 * typemanager.cs: TypeManager: made public variable instead of
16810 * driver.cs: document --fatal.
16812 * report.cs (ErrorMessage, WarningMessage): new names for the old
16813 Error and Warning classes.
16815 * cs-parser.jay (member_access): Turn built-in access to types
16816 into a normal simplename
16818 2001-09-27 Ravi Pratap <ravi@ximian.com>
16820 * expression.cs (Invocation::BetterConversion): Fix to cope
16821 with q being null, since this was introducing a bug.
16823 * expression.cs (ConvertImplicit): Do built-in conversions first.
16825 2001-09-27 Ravi Pratap <ravi@ximian.com>
16827 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16829 2001-09-27 Ravi Pratap <ravi@ximian.com>
16831 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16832 I had introduced long ago (what's new ?).
16834 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16835 the work of all the checking.
16836 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16837 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16839 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16840 that is the right way.
16842 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16843 overloading resolution. Use everywhere instead of cutting and pasting code.
16845 (Binary::ResolveOperator): Use MakeUnionSet.
16847 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16848 we have to convert to bool types. Not complete yet.
16850 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16852 * typemanager.cs (TypeManager::CSharpName): support ushort.
16854 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16855 to provide an expression that performsn an implicit constant int
16856 conversion (section 6.1.6).
16857 (Expression::ConvertImplicitRequired): Reworked to include
16858 implicit constant expression conversions.
16860 (Expression::ConvertNumericExplicit): Finished.
16862 (Invocation::Emit): If InstanceExpression is null, then it means
16863 that we perform a call on this.
16865 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16867 * expression.cs (Unary::Emit): Remove some dead code.
16868 (Probe): Implement Resolve and Emit for `is'.
16869 (Expression::ConvertImplicitRequired): Attempt to do constant
16870 expression conversions here. Maybe should be moved to
16871 ConvertImplicit, but I am not sure.
16872 (Expression::ImplicitLongConstantConversionPossible,
16873 Expression::ImplicitIntConstantConversionPossible): New functions
16874 that tell whether is it possible to apply an implicit constant
16875 expression conversion.
16877 (ConvertNumericExplicit): Started work on explicit numeric
16880 * cs-parser.jay: Update operator constants.
16882 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16883 (Parameters::GetSignature): Hook up VerifyArgs here.
16884 (Parameters::VerifyArgs): Verifies that no two arguments have the
16887 * class.cs (Operator): Update the operator names to reflect the
16888 ones that the spec expects (as we are just stringizing the
16891 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16892 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16893 previous usage did only work for our methods.
16894 (Expression::ConvertImplicit): Handle decimal implicit numeric
16895 conversions as well.
16896 (Expression::InternalTypeConstructor): Used to invoke constructors
16897 on internal types for default promotions.
16899 (Unary::Emit): Implement special handling for the pre/post
16900 increment/decrement for overloaded operators, as they need to have
16901 the same semantics as the other operators.
16903 (Binary::ResolveOperator): ditto.
16904 (Invocation::ConversionExists): ditto.
16905 (UserImplicitCast::Resolve): ditto.
16907 2001-09-26 Ravi Pratap <ravi@ximian.com>
16909 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16910 operator, return after emitting body. Regression tests pass again !
16912 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16913 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16914 (Invocation::OverloadResolve): Ditto.
16915 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16917 * everywhere : update calls to the above methods accordingly.
16919 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16921 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16923 * expression.cs (ExpressionStatement): New base class used for
16924 expressions that can appear in statements, so that we can provide
16925 an alternate path to generate expression that do not leave a value
16928 (Expression::Emit, and all the derivatives): We no longer return
16929 whether a value is left on the stack or not. Every expression
16930 after being emitted leaves a single value on the stack.
16932 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16933 facilties of ExpressionStatement if possible.
16935 * cs-parser.jay: Update statement_expression.
16937 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16939 * driver.cs: Change the wording of message
16941 2001-09-25 Ravi Pratap <ravi@ximian.com>
16943 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16944 the type of the expression to the return type of the method if
16945 we have an overloaded operator match ! The regression tests pass again !
16946 (Unary::ResolveOperator): Ditto.
16948 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16949 to find "op_Implicit", not "implicit" ;-)
16950 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16951 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16953 * everywhere : Correct calls to the above accordingly.
16955 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16956 (ConvertImplicit): Do user-defined conversion if it exists.
16958 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16960 * assign.cs: track location.
16961 (Resolve): Use implicit conversions on assignment.
16963 * literal.cs: Oops. Not good, Emit of short access values should
16964 pass (Bytes) or the wrong argument will be selected.
16966 * expression.cs (Unary::Emit): Emit code for -expr.
16968 (Unary::ResolveOperator): Handle `Substract' for non-constants
16969 (substract from zero from the non-constants).
16970 Deal with Doubles as well.
16972 (Expression::ConvertImplicitRequired): New routine that reports an
16973 error if no implicit conversion exists.
16975 (Invocation::OverloadResolve): Store the converted implicit
16976 expressions if we make them
16978 2001-09-24 Ravi Pratap <ravi@ximian.com>
16980 * class.cs (ConstructorInitializer): Take a Location argument.
16981 (ConstructorBaseInitializer): Same here.
16982 (ConstructorThisInitializer): Same here.
16984 * cs-parser.jay : Update all calls accordingly.
16986 * expression.cs (Unary, Binary, New): Take location argument.
16987 Update accordingly everywhere.
16989 * cs-parser.jay : Update all calls to the above to take a location
16992 * class.cs : Ditto.
16994 2001-09-24 Ravi Pratap <ravi@ximian.com>
16996 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16997 (Invocation::BetterConversion): Same here
16998 (Invocation::ConversionExists): Ditto.
17000 (Invocation::ConversionExists): Implement.
17002 2001-09-22 Ravi Pratap <ravi@ximian.com>
17004 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17005 Also take an additional TypeContainer argument.
17007 * All over : Pass in TypeContainer as argument to OverloadResolve.
17009 * typemanager.cs (CSharpName): Update to check for the string type and return
17012 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17015 2001-09-21 Ravi Pratap <ravi@ximian.com>
17017 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17018 (Invocation::BetterFunction): Implement.
17019 (Invocation::BetterConversion): Implement.
17020 (Invocation::ConversionExists): Skeleton, no implementation yet.
17022 Okay, things work fine !
17024 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17026 * typemanager.cs: declare and load enum_type, delegate_type and
17029 * expression.cs (Expression::Emit): Now emit returns a value that
17030 tells whether a value is left on the stack or not. This strategy
17031 might be reveted tomorrow with a mechanism that would address
17032 multiple assignments.
17033 (Expression::report118): Utility routine to report mismatches on
17036 (Unary::Report23): Report impossible type/operator combination
17039 (Unary::IsIncrementableNumber): Whether the type can be
17040 incremented or decremented with add.
17041 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17043 (Unary::ResolveOperator): Implement ++, !, ~,
17045 (Invocation::Emit): Deal with new Emit convetion.
17047 * All Expression derivatives: Updated their Emit method to return
17048 whether they leave values on the stack or not.
17050 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17051 stack for expressions that are statements.
17053 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17055 * expression.cs (LValue): New interface. Must be implemented by
17057 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17060 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17061 interface for generating code, simplifies the code.
17063 2001-09-20 Ravi Pratap <ravi@ximian.com>
17065 * expression.cs (everywhere): Comment out return statements in ::Resolve
17066 methods to avoid the warnings.
17068 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17070 * driver.cs (parse): Report error 2001 if we can not open the
17073 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17076 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17079 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17080 otherwise nested blocks end up with the same index.
17082 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17084 * expression.cs: Instead of having FIXMEs in the Resolve
17085 functions, throw exceptions so it is obvious that we are facing a
17088 * cs-parser.jay (invocation_expression): Pass Location information.
17090 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17091 Use a basename for those routines because .NET does not like paths
17094 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17097 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17099 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17100 are loading the correct data types (throws an exception if not).
17101 (TypeManager::InitCoreTypes): Use CoreLookupType
17103 * expression.cs (Unary::ResolveOperator): return the child
17104 expression for expressions which are just +expr.
17105 (Unary::ResolveOperator): Return negative literals for -LITERAL
17106 expressions (otherwise they are Unary {Literal}).
17107 (Invocation::Badness): Take into account `Implicit constant
17108 expression conversions'.
17110 * literal.cs (LongLiteral): Implement long literal class.
17111 (IntLiteral): export the `Value' of the intliteral.
17113 2001-09-19 Ravi Pratap <ravi@ximian.com>
17115 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17117 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17118 instead of 'Operator'
17120 * expression.cs (Binary::ResolveOperator): Update accordingly.
17121 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17124 * cs-parser.jay (unary_expression): Update to use the new names.
17126 * gen-treedump.cs (GetUnary): Same here.
17128 * expression.cs (Unary::Resolve): Implement.
17129 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17130 operators are found instead of making noise ;-)
17131 (Unary::ResolveOperator): New method to do precisely the same thing which
17132 Binary::ResolveOperator does for Binary expressions.
17133 (Unary.method, .Arguments): Add.
17134 (Unary::OperName): Implement.
17135 (Unary::ForceConversion): Copy and Paste !
17137 * class.cs (Operator::Define): Fix a small bug for the case when we have
17140 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17141 for the inbuilt operators. Only overloading works for now ;-)
17143 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17145 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17146 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17148 * expression.cs (This::Emit): Implement.
17149 (This::Resolve): Implement.
17150 (TypeOf:Resolve): Implement.
17151 (Expression::ResolveSimpleName): Add an implicit this to instance
17153 (MemberAccess::Resolve): Deal with Parameters and Fields.
17154 Bind instance variable to Field expressions.
17155 (FieldExpr::Instance): New field used to track the expression that
17156 represents the object instance.
17157 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17159 (FieldExpr::Emit): Implement.
17161 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17162 the last instruction contains a return opcode to avoid generating
17163 the last `ret' instruction (this generates correct code, and it is
17164 nice to pass the peverify output).
17166 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17167 initializer for static and instance variables.
17168 (Constructor::Emit): Allow initializer to be null in the case of
17169 static constructors. Only emit initializer for instance
17172 (TypeContainer::FindMembers): Return a null array if there are no
17175 Also fix the code for the MemberTypes.Method branch, as it was not
17176 scanning that for operators (or tried to access null variables before).
17178 * assign.cs (Assign::Emit): Handle instance and static fields.
17182 * driver.cs: Stop compilation if there are parse errors.
17184 * cs-parser.jay (constructor_declaration): Provide default base
17185 initializer for non-static constructors.
17186 (constructor_declarator): Do not provide a default base
17187 initializers if none was specified.
17188 Catch the fact that constructors should not have parameters.
17190 * class.cs: Do not emit parent class initializers for static
17191 constructors, that should be flagged as an error.
17193 2001-09-18 Ravi Pratap <ravi@ximian.com>
17195 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17196 Move back code into TypeContainer::Populate.
17198 2001-09-18 Ravi Pratap <ravi@ximian.com>
17200 * class.cs (TypeContainer::AddConstructor): Fix the check to
17201 compare against Name, not Basename.
17202 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17204 * cs-parser.jay : Update accordingly.
17206 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17207 for methods, don't forget to look into the operators too.
17208 (RegisterMethodBuilder): Helper method to take care of this for
17209 methods, constructors and operators.
17210 (Operator::Define): Completely revamp.
17211 (Operator.OperatorMethod, MethodName): New fields.
17212 (TypeContainer::Populate): Move the registering of builders into
17213 RegisterMethodBuilder.
17214 (Operator::Emit): Re-write.
17216 * expression.cs (Binary::Emit): Comment out code path to emit method
17217 invocation stuff for the case when we have a user defined operator. I am
17218 just not able to get it right !
17220 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17222 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17225 (Expression::MemberLookup): Provide a version that allows to
17226 specify the MemberTypes and BindingFlags.
17228 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17229 so it was not fetching variable information from outer blocks.
17231 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17232 Beforefieldinit as it was buggy.
17234 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17235 that Ravi put here.
17237 * class.cs (Constructor::Emit): Only emit if block is not null.
17238 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17239 deal with this by semantically definining it as if the user had
17242 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17243 constructors as we now "emit" them at a higher level.
17245 (TypeContainer::DefineDefaultConstructor): Used to define the
17246 default constructors if none was provided.
17248 (ConstructorInitializer): Add methods Resolve and Emit.
17250 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17252 2001-09-17 Ravi Pratap <ravi@ximian.com>
17254 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17255 the default constructor builder with our hashtable for methodbuilders
17258 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17259 and argument_count is 0 in which case we have a match.
17260 (Binary::ResolveOperator): More null checking and miscellaneous coding
17263 2001-09-17 Ravi Pratap <ravi@ximian.com>
17265 * rootcontext.cs (IsNameSpace): Compare against null.
17267 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17269 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17270 and Unary::Operator.
17272 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17275 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17276 we have overloaded operators.
17277 (Binary::ResolveOperator): Implement the part which does the operator overload
17280 * class.cs (Operator::Emit): Implement.
17281 (TypeContainer::Emit): Emit the operators we have too.
17283 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17284 the case when we have a user-defined operator.
17286 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17288 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17290 2001-09-16 Ravi Pratap <ravi@ximian.com>
17292 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17293 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17294 (Constructor::Emit): Implement.
17295 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17296 if we have no work to do.
17297 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17300 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17301 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17303 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17306 2001-09-15 Ravi Pratap <ravi@ximian.com>
17308 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17310 (Tree::RecordNamespace): Method to do what the name says ;-)
17311 (Tree::Namespaces): Property to get at the namespaces hashtable.
17313 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17316 * rootcontext.cs (IsNamespace): Fixed it :-)
17318 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17320 * class.cs (TypeContainer::FindMembers): Add support for
17322 (MethodCore): New class that encapsulates both the shared aspects
17323 of a Constructor and a Method.
17324 (Method, Constructor): Factored pieces into MethodCore.
17326 * driver.cs: Added --fatal which makes errors throw exceptions.
17327 Load System assembly as well as part of the standard library.
17329 * report.cs: Allow throwing exceptions on errors for debugging.
17331 * modifiers.cs: Do not use `parent', instead use the real type
17332 container to evaluate permission settings.
17334 * class.cs: Put Ravi's patch back in. He is right, and we will
17335 have to cope with the
17337 2001-09-14 Ravi Pratap <ravi@ximian.com>
17339 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17340 FamORAssem, not FamANDAssem.
17342 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17344 * driver.cs: Added --parse option that only parses its input files
17347 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17348 incorrect. IsTopLevel is not used to tell whether an object is
17349 root_types or not (that can be achieved by testing this ==
17350 root_types). But to see if this is a top-level *class* (not
17351 necessarly our "toplevel" container).
17353 2001-09-14 Ravi Pratap <ravi@ximian.com>
17355 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17356 parent instead of a direct call to GetType.
17358 2001-09-14 Ravi Pratap <ravi@ximian.com>
17360 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17361 Modifiers.TypeAttr. This should just be a call to that method.
17363 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17364 object so that we can determine if we are top-level or not.
17366 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17369 * enum.cs (Enum::Define): Ditto.
17371 * modifiers.cs (FieldAttr): Re-write.
17373 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17374 (TypeContainer::HaveStaticConstructor): New property to provide access
17375 to precisely that info.
17377 * modifiers.cs (MethodAttr): Re-write.
17378 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17380 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17381 of top-level types as claimed.
17383 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17385 * expression.cs (MemberLookup): Fruitless attempt to lookup
17386 constructors. Maybe I need to emit default constructors? That
17387 might be it (currently .NET emits this for me automatically).
17388 (Invocation::OverloadResolve): Cope with Arguments == null.
17389 (Invocation::EmitArguments): new function, shared by the new
17390 constructor and us.
17391 (Invocation::Emit): Handle static and instance methods. Emit
17392 proper call instruction for virtual or non-virtual invocations.
17393 (New::Emit): Implement.
17394 (New::Resolve): Implement.
17395 (MemberAccess:Resolve): Implement.
17396 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17397 to track instances.
17398 (FieldExpr::Resolve): Set type.
17400 * support.cs: Handle empty arguments.
17402 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17403 SimpleLookup): Auxiliary routines to help parse a qualifier
17406 Update qualifier_identifier rule.
17408 * codegen.cs: Removed debugging messages.
17410 * class.cs: Make this a global thing, this acts just as a "key" to
17411 objects that we might have around.
17413 (Populate): Only initialize method_builders_to_methods once.
17415 * expression.cs (PropertyExpr): Initialize type from the
17418 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17419 Resolve pattern. Attempt to implicitly convert value to boolean.
17422 * expression.cs: Set the type for the int32/int32 argument case.
17423 (Binary::ResolveOperator): Set the return type to boolean for
17424 comparission operators
17426 * typemanager.cs: Remove debugging print code.
17428 (Invocation::Resolve): resolve type.
17430 * class.cs: Allocate a MemberInfo of the correct size, as the code
17431 elsewhere depends on the test to reflect the correct contents.
17433 (Method::) Keep track of parameters, due to System.Reflection holes
17435 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17438 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17439 of the exact size and return that.
17441 (Class::LookupMethodByBuilder): New function that maps
17442 MethodBuilders to its methods. Required to locate the information
17443 on methods because System.Reflection bit us again.
17445 * support.cs: New file, contains an interface ParameterData and
17446 two implementations: ReflectionParameters and InternalParameters
17447 used to access Parameter information. We will need to grow this
17450 * expression.cs (Invocation::GetParameterData): implement a cache
17451 and a wrapper around the ParameterData creation for methods.
17452 (Invocation::OverloadResolve): Use new code.
17454 2001-09-13 Ravi Pratap <ravi@ximian.com>
17456 * class.cs (TypeContainer::EmitField): Remove and move into
17457 (Field::Define): here and modify accordingly.
17458 (Field.FieldBuilder): New member.
17459 (TypeContainer::Populate): Update accordingly.
17460 (TypeContainer::FindMembers): Implement.
17462 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17464 * statement.cs: (VariableInfo::VariableType): New field to be
17465 initialized with the full type once it is resolved.
17467 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17469 * parameter.cs (GetParameterInfo): Use a type cache to compute
17470 things only once, and to reuse this information
17472 * expression.cs (LocalVariableReference::Emit): Implement.
17473 (OpcodeCast::Emit): fix.
17475 (ParameterReference::Resolve): Implement.
17476 (ParameterReference::Emit): Implement.
17478 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17479 that are expressions need to stay as Expressions.
17481 * typemanager.cs (CSharpName): Returns the C# name of a type if
17484 * expression.cs (Expression::ConvertImplicit): New function that
17485 implements implicit type conversions.
17487 (Expression::ImplicitReferenceConversion): Implements implicit
17488 reference conversions.
17490 (EmptyCast): New type for transparent casts.
17492 (OpcodeCast): New type for casts of types that are performed with
17493 a sequence of bytecodes.
17495 (BoxedCast): New type used for casting value types into reference
17496 types. Emits a box opcode.
17498 (Binary::DoNumericPromotions): Implements numeric promotions of
17499 and computation of the Binary::Type.
17501 (Binary::EmitBranchable): Optimization.
17503 (Binary::Emit): Implement code emission for expressions.
17505 * typemanager.cs (TypeManager): Added two new core types: sbyte
17508 2001-09-12 Ravi Pratap <ravi@ximian.com>
17510 * class.cs (TypeContainer::FindMembers): Method which does exactly
17511 what Type.FindMembers does, only we don't have to use reflection. No
17512 implementation yet.
17514 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17515 typecontainer objects as we need to get at them.
17516 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17518 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17519 typecontainer object.
17521 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17522 of just a Report object.
17524 2001-09-11 Ravi Pratap <ravi@ximian.com>
17526 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17528 (TypeContainer::Populate): Now define the delegates of the type too.
17529 (TypeContainer.Delegates): Property to access the list of delegates defined
17532 * delegates.cs (Delegate::Define): Implement partially.
17534 * modifiers.cs (TypeAttr): Handle more flags.
17536 2001-09-11 Ravi Pratap <ravi@ximian.com>
17538 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17540 (Operator::Define): Re-write logic to get types by using the LookupType method
17541 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17542 (Indexer::Define): Ditto.
17543 (Event::Define): Ditto.
17544 (Property::Define): Ditto.
17546 2001-09-10 Ravi Pratap <ravi@ximian.com>
17548 * class.cs (TypeContainer::Populate): Now define operators too.
17549 (TypeContainer.Operators): New property to access the list of operators
17551 (Operator.OperatorMethodBuilder): New member to hold the method builder
17552 for the operator we are defining.
17553 (Operator::Define): Implement.
17555 2001-09-10 Ravi Pratap <ravi@ximian.com>
17557 * class.cs (Event::Define): Make the prefixes of the accessor methods
17558 addOn_ and removeOn_
17560 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17561 of the location being passed in too. Ideally, this should go later since all
17562 error reporting should be done through the Report object.
17564 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17565 (Populate): Iterate thru the indexers we have and define them too.
17566 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17567 for the get and set accessors.
17568 (Indexer::Define): Implement.
17570 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17572 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17573 my previous implementation, did not work.
17575 * typemanager.cs: Add a couple of missing types (the longs).
17577 * literal.cs: Use TypeManager.bool_type instead of getting it.
17579 * expression.cs (EventExpr): New kind of expressions.
17580 (Expressio::ExprClassFromMemberInfo): finish
17582 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17584 * assign.cs: Emit stores to static fields differently.
17586 2001-09-08 Ravi Pratap <ravi@ximian.com>
17588 * Merge in changes and adjust code to tackle conflicts. Backed out my
17589 code in Assign::Resolve ;-)
17591 2001-09-08 Ravi Pratap <ravi@ximian.com>
17593 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17594 instead Report.Error and also pass in the location.
17595 (CSharpParser::Lexer): New readonly property to return the reference
17596 to the Tokenizer object.
17597 (declare_local_variables): Use Report.Error with location instead of plain
17601 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17602 (Operator.CheckBinaryOperator): Ditto.
17604 * cs-parser.jay (operator_declarator): Update accordingly.
17606 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17607 (CheckBinaryOperator): Same here.
17609 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17610 on the name without any prefixes of namespace names etc. This is because we
17611 already might have something already fully qualified like
17612 'System.Console.WriteLine'
17614 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17616 2001-09-07 Ravi Pratap <ravi@ximian.com>
17618 * cs-tokenizer.cs (location): Return a string which also contains
17621 * expression.cs (ElementAccess): New class for expressions of the
17622 type 'element access.'
17623 (BaseAccess): New class for expressions of the type 'base access.'
17624 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17627 * cs-parser.jay (element_access): Implement action.
17628 (base_access): Implement actions.
17629 (checked_expression, unchecked_expression): Implement.
17631 * cs-parser.jay (local_variable_type): Correct and implement.
17632 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17634 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17636 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17637 name and the specifiers.
17639 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17641 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17642 making them all public ;-)
17644 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17647 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17649 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17651 (FieldExpr, PropertyExprs): New resolved expressions.
17652 (SimpleName::MemberStaticCheck): Perform static checks for access
17653 to non-static fields on static methods. Maybe this should be
17654 generalized for MemberAccesses.
17655 (SimpleName::ResolveSimpleName): More work on simple name
17658 * cs-parser.jay (primary_expression/qualified_identifier): track
17659 the parameter index.
17661 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17662 (EmitContext::EmitBoolExpression): Chain to expression generation
17663 instead of temporary hack.
17664 (::EmitStatementExpression): Put generic expression code generation.
17666 * assign.cs (Assign::Emit): Implement variable assignments to
17667 local variables, parameters and fields.
17669 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17671 * statement.cs (Block::GetVariableInfo): New method, returns the
17672 VariableInfo for a variable name in a block.
17673 (Block::GetVariableType): Implement in terms of GetVariableInfo
17675 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17676 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17678 2001-09-06 Ravi Pratap <ravi@ximian.com>
17680 * cs-parser.jay (operator_declaration): Continue on my quest : update
17681 to take attributes argument.
17682 (event_declaration): Ditto.
17683 (enum_declaration): Ditto.
17684 (indexer_declaration): Ditto.
17686 * class.cs (Operator::Operator): Update constructor accordingly.
17687 (Event::Event): Ditto.
17689 * delegate.cs (Delegate::Delegate): Same here.
17691 * enum.cs (Enum::Enum): Same here.
17693 2001-09-05 Ravi Pratap <ravi@ximian.com>
17695 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17697 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17699 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17700 being passed around as an arraylist.
17701 (Attributes::AddAttribute): Method to add attribute sections.
17703 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17704 (struct_declaration): Update accordingly.
17705 (constant_declaration): Update.
17706 (field_declaration): Update.
17707 (method_header): Update.
17708 (fixed_parameter): Update.
17709 (parameter_array): Ditto.
17710 (property_declaration): Ditto.
17711 (destructor_declaration): Ditto.
17713 * class.cs (Struct::Struct): Update constructors accordingly.
17714 (Class::Class): Ditto.
17715 (Field::Field): Ditto.
17716 (Method::Method): Ditto.
17717 (Property::Property): Ditto.
17718 (TypeContainer::OptAttribute): update property's return type.
17720 * interface.cs (Interface.opt_attributes): New member.
17721 (Interface::Interface): Update to take the extra Attributes argument.
17723 * parameter.cs (Parameter::Parameter): Ditto.
17725 * constant.cs (Constant::Constant): Ditto.
17727 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17728 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17729 the attributes as a parameter.
17730 (InterfaceProperty): Update constructor call.
17731 (InterfaceEvent): Ditto.
17732 (InterfaceMethod): Ditto.
17733 (InterfaceIndexer): Ditto.
17735 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17736 pass the attributes too.
17737 (interface_event_declaration): Ditto.
17738 (interface_property_declaration): Ditto.
17739 (interface_method_declaration): Ditto.
17740 (interface_declaration): Ditto.
17742 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17744 * class.cs (Method::Define): Track the "static Main" definition to
17745 create an entry point.
17747 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17748 EntryPoint if we find it.
17750 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17751 (EmitContext::ig): Make this variable public.
17753 * driver.cs: Make the default output file be the first file name
17754 with the .exe extension.
17756 Detect empty compilations
17758 Handle various kinds of output targets. Handle --target and
17759 rename -t to --dumper.
17761 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17762 methods inherited from Expression return now an Expression. This
17763 will is used during the tree rewriting as we resolve them during
17766 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17767 the spec. Missing entirely is the information about
17768 accessability of elements of it.
17770 (Expression::ExprClassFromMemberInfo): New constructor for
17771 Expressions that creates a fully initialized Expression based on
17772 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17775 (Invocation::Resolve): Begin implementing resolution of invocations.
17777 * literal.cs (StringLiteral): Implement Emit.
17779 2001-09-05 Ravi Pratap <ravi@ximian.com>
17781 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17784 2001-09-04 Ravi Pratap <ravi@ximian.com>
17786 * cs-parser.jay (attribute_arguments): Implement actions.
17787 (attribute): Fix bug in production. Implement action.
17788 (attribute_list): Implement.
17789 (attribute_target): Implement.
17790 (attribute_target_specifier, opt_target_specifier): Implement
17791 (CheckAttributeTarget): New method to check if the attribute target
17793 (attribute_section): Implement.
17794 (opt_attributes): Implement.
17796 * attribute.cs : New file to handle attributes.
17797 (Attribute): Class to hold attribute info.
17799 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17800 (attribute_section): Modify production to use 2 different rules to
17801 achieve the same thing. 1 s/r conflict down !
17802 Clean out commented, useless, non-reducing dimension_separator rules.
17804 * class.cs (TypeContainer.attributes): New member to hold list
17805 of attributes for a type.
17806 (Struct::Struct): Modify to take one more argument, the attribute list.
17807 (Class::Class): Ditto.
17808 (Field::Field): Ditto.
17809 (Method::Method): Ditto.
17810 (Property::Property): Ditto.
17812 * cs-parser.jay (struct_declaration): Update constructor call to
17813 pass in the attributes too.
17814 (class_declaration): Ditto.
17815 (constant_declaration): Ditto.
17816 (field_declaration): Ditto.
17817 (method_header): Ditto.
17818 (fixed_parameter): Ditto.
17819 (parameter_array): Ditto.
17820 (property_declaration): Ditto.
17822 * constant.cs (Constant::Constant): Update constructor similarly.
17823 Use System.Collections.
17825 * parameter.cs (Parameter::Parameter): Update as above.
17827 2001-09-02 Ravi Pratap <ravi@ximian.com>
17829 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17830 (TypeContainer.delegates): New member to hold list of delegates.
17832 * cs-parser.jay (delegate_declaration): Implement the action correctly
17833 this time as I seem to be on crack ;-)
17835 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17837 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17838 tell whether an identifier represents a namespace.
17840 * expression.cs (NamespaceExpr): A namespace expression, used only
17841 temporarly during expression resolution.
17842 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17843 utility functions to resolve names on expressions.
17845 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17847 * codegen.cs: Add hook for StatementExpressions.
17849 * class.cs: Fix inverted test for static flag in methods.
17851 2001-09-02 Ravi Pratap <ravi@ximian.com>
17853 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17854 to make it coincide with MS' number.
17855 (Operator::CheckBinaryOperator): Ditto.
17857 * ../errors/errors.txt : Remove error numbers added earlier.
17859 * ../errors/cs1019.cs : Test case for error # 1019
17861 * ../errros/cs1020.cs : Test case for error # 1020
17863 * cs-parser.jay : Clean out commented cruft.
17864 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17865 used anywhere - non-reducing rule.
17866 (namespace_declarations): Non-reducing rule - comment out.
17868 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17869 with TypeContainer::AddEnum.
17871 * delegate.cs : New file for delegate handling classes.
17872 (Delegate): Class for declaring delegates.
17874 * makefile : Update.
17876 * cs-parser.jay (delegate_declaration): Implement.
17878 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17880 * class.cs (Event::Define): Implement.
17881 (Event.EventBuilder): New member.
17883 * class.cs (TypeContainer::Populate): Update to define all enums and events
17885 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17886 readonly fields for all these cases ?
17888 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17890 * class.cs (Property): Revamp to use the convention of making fields readonly.
17891 Accordingly modify code elsewhere.
17893 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17894 the Define method of the Property class.
17896 * class.cs : Clean up applied patch and update references to variables etc. Fix
17898 (TypeContainer::Populate): Update to define all the properties we have. Also
17899 define all enumerations.
17901 * enum.cs (Define): Implement.
17903 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17905 * cs-parser.jay (overloadable_operator): The semantic value is an
17906 enum of the Operator class.
17907 (operator_declarator): Implement actions.
17908 (operator_declaration): Implement.
17910 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17911 validity of definitions.
17912 (Operator::CheckBinaryOperator): Static method to check for binary operators
17913 (TypeContainer::AddOperator): New method to add an operator to a type.
17915 * cs-parser.jay (indexer_declaration): Added line to actually call the
17916 AddIndexer method so it gets added ;-)
17918 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17919 already taken care of by the MS compiler ?
17921 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17923 * class.cs (Operator): New class for operator declarations.
17924 (Operator::OpType): Enum for the various operators.
17926 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17928 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17929 ostensibly handle this in semantic analysis.
17931 * cs-parser.jay (general_catch_clause): Comment out
17932 (specific_catch_clauses, specific_catch_clause): Ditto.
17933 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17934 (catch_args, opt_catch_args): New productions.
17935 (catch_clause): Rewrite to use the new productions above
17936 (catch_clauses): Modify accordingly.
17937 (opt_catch_clauses): New production to use in try_statement
17938 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17939 and re-write the code in the actions to extract the specific and
17940 general catch clauses by being a little smart ;-)
17942 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17943 Hooray, try and catch statements parse fine !
17945 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17947 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17948 string from the hashtable of variables.
17950 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17951 I end up making that mistake ;-)
17952 (catch_clauses): Fixed gross error which made Key and Value of the
17953 DictionaryEntry the same : $1 !!
17955 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17957 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17959 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17960 when the add and remove accessors are specified.
17962 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17964 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17965 information about indexer_declarator.
17966 (indexer_declarator): Implement actions.
17967 (parsing_indexer): New local boolean used to keep track of whether
17968 we are parsing indexers or properties. This is necessary because
17969 implicit_parameters come into picture even for the get accessor in the
17970 case of an indexer.
17971 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17973 * class.cs (Indexer): New class for indexer declarations.
17974 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17975 (TypeContainer::indexers): New member to hold list of indexers for the
17978 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17980 * cs-parser.jay (add_accessor_declaration): Implement action.
17981 (remove_accessor_declaration): Implement action.
17982 (event_accessors_declaration): Implement
17983 (variable_declarators): swap statements for first rule - trivial.
17985 * class.cs (Event): New class to hold information about event
17987 (TypeContainer::AddEvent): New method to add an event to a type
17988 (TypeContainer::events): New member to hold list of events.
17990 * cs-parser.jay (event_declaration): Implement actions.
17992 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17994 * cs-parser.jay (dim_separators): Implement. Make it a string
17995 concatenating all the commas together, just as they appear.
17996 (opt_dim_separators): Modify accordingly
17997 (rank_specifiers): Update accordingly. Basically do the same
17998 thing - instead, collect the brackets here.
17999 (opt_rank_sepcifiers): Modify accordingly.
18000 (array_type): Modify to actually return the complete type string
18001 instead of ignoring the rank_specifiers.
18002 (expression_list): Implement to collect the expressions
18003 (variable_initializer): Implement. We make it a list of expressions
18004 essentially so that we can handle the array_initializer case neatly too.
18005 (variable_initializer_list): Implement.
18006 (array_initializer): Make it a list of variable_initializers
18007 (opt_array_initializer): Modify accordingly.
18009 * expression.cs (New::NType): Add enumeration to help us
18010 keep track of whether we have an object/delegate creation
18011 or an array creation.
18012 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18013 members to hold data about array creation.
18014 (New:New): Modify to update NewType
18015 (New:New): New Overloaded contructor for the array creation
18018 * cs-parser.jay (array_creation_expression): Implement to call
18019 the overloaded New constructor.
18021 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18023 * class.cs (TypeContainer::Constructors): Return member
18024 constructors instead of returning null.
18026 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18028 * typemanager.cs (InitCoreTypes): Initialize the various core
18029 types after we have populated the type manager with the user
18030 defined types (this distinction will be important later while
18031 compiling corlib.dll)
18033 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18034 on Expression Classification. Now all expressions have a method
18035 `Resolve' and a method `Emit'.
18037 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18038 generation from working. Also add some temporary debugging
18041 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18043 * codegen.cs: Lots of code generation pieces. This is only the
18044 beginning, will continue tomorrow with more touches of polish. We
18045 handle the fundamentals of if, while, do, for, return. Others are
18046 trickier and I need to start working on invocations soon.
18048 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18051 * codegen.cs (EmitContext): New struct, used during code
18052 emission to keep a context. Most of the code generation will be
18055 * cs-parser.jay: Add embedded blocks to the list of statements of
18056 this block. So code generation proceeds in a top down fashion.
18058 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18060 * statement.cs: Add support for multiple child blocks.
18062 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18064 * codegen.cs (EmitCode): New function, will emit the code for a
18065 Block of code given a TypeContainer and its ILGenerator.
18067 * statement.cs (Block): Standard public readonly optimization.
18068 (Block::Block constructors): Link children.
18069 (Block::Child): Child Linker.
18070 (Block::EmitVariables): Emits IL variable declarations.
18072 * class.cs: Drop support for MethodGroups here, delay until
18074 (Method::): Applied the same simplification that I did before, and
18075 move from Properties to public readonly fields.
18076 (Method::ParameterTypes): Returns the parameter types for the
18077 function, and implements a cache that will be useful later when I
18078 do error checking and the semantic analysis on the methods is
18080 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18081 and made a method, optional argument tells whether this is a class
18082 or a structure to apply the `has-this' bit.
18083 (Method::GetCallingConvention): Implement, returns the calling
18085 (Method::Define): Defines the type, a second pass is performed
18086 later to populate the methods.
18088 (Constructor::ParameterTypes): implement a cache similar to the
18089 one on Method::ParameterTypes, useful later when we do semantic
18092 (TypeContainer::EmitMethod): New method. Emits methods.
18094 * expression.cs: Removed MethodGroup class from here.
18096 * parameter.cs (Parameters::GetCallingConvention): new method.
18098 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18100 * class.cs (TypeContainer::Populate): Drop RootContext from the
18103 (Constructor::CallingConvention): Returns the calling convention.
18104 (Constructor::ParameterTypes): Returns the constructor parameter
18107 (TypeContainer::AddConstructor): Keep track of default constructor
18108 and the default static constructor.
18110 (Constructor::) Another class that starts using `public readonly'
18111 instead of properties.
18113 (Constructor::IsDefault): Whether this is a default constructor.
18115 (Field::) use readonly public fields instead of properties also.
18117 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18118 track of static constructors; If none is used, turn on
18119 BeforeFieldInit in the TypeAttributes.
18121 * cs-parser.jay (opt_argument_list): now the return can be null
18122 for the cases where there are no arguments.
18124 (constructor_declarator): If there is no implicit `base' or
18125 `this', then invoke the default parent constructor.
18127 * modifiers.cs (MethodAttr): New static function maps a set of
18128 modifiers flags into a MethodAttributes enum
18129 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18130 MethodAttr, TypeAttr to represent the various mappings where the
18131 modifiers are used.
18132 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18134 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18136 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18139 * interface.cs (PopulateIndexer): Implemented the code generator
18140 for interface indexers.
18142 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18144 * interface.cs (InterfaceMemberBase): Now we track the new status
18147 (PopulateProperty): Implement property population. Woohoo! Got
18148 Methods and Properties going today.
18150 Removed all the properties for interfaces, and replaced them with
18151 `public readonly' fields.
18153 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18155 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18156 initialize their hashtables/arraylists only when they are needed
18157 instead of doing this always.
18159 * parameter.cs: Handle refs and out parameters.
18161 * cs-parser.jay: Use an ArrayList to construct the arguments
18162 instead of the ParameterCollection, and then cast that to a
18165 * parameter.cs: Drop the use of ParameterCollection and use
18166 instead arrays of Parameters.
18168 (GetParameterInfo): Use the Type, not the Name when resolving
18171 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18173 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18174 and instead use public readonly fields.
18176 * class.cs: Put back walking code for type containers.
18178 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18180 * class.cs (MakeConstant): Code to define constants.
18182 * rootcontext.cs (LookupType): New function. Used to locate types
18185 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18187 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18188 this System.Reflection code is. Kudos to Microsoft
18190 * typemanager.cs: Implement a type cache and avoid loading all
18191 types at boot time. Wrap in LookupType the internals. This made
18192 the compiler so much faster. Wow. I rule!
18194 * driver.cs: Make sure we always load mscorlib first (for
18195 debugging purposes, nothing really important).
18197 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18198 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18200 * rootcontext.cs: Lookup types on their namespace; Lookup types
18201 on namespaces that have been imported using the `using' keyword.
18203 * class.cs (TypeContainer::TypeAttr): Virtualize.
18204 (Class::TypeAttr): Return attributes suitable for this bad boy.
18205 (Struct::TypeAttr): ditto.
18206 Handle nested classes.
18207 (TypeContainer::) Remove all the type visiting code, it is now
18208 replaced with the rootcontext.cs code
18210 * rootcontext.cs (GetClassBases): Added support for structs.
18212 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18214 * interface.cs, statement.cs, class.cs, parameter.cs,
18215 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18216 Drop use of TypeRefs, and use strings instead.
18218 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18222 * class.cs (Struct::Struct): set the SEALED flags after
18223 checking the modifiers.
18224 (TypeContainer::TypeAttr): new property, returns the
18225 TypeAttributes for a class.
18227 * cs-parser.jay (type_list): Oops, list production was creating a
18228 new list of base types.
18230 * rootcontext.cs (StdLib): New property.
18231 (GetInterfaceTypeByName): returns an interface by type name, and
18232 encapsulates error handling here.
18233 (GetInterfaces): simplified.
18234 (ResolveTree): Encapsulated all the tree resolution here.
18235 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18238 * driver.cs: Add support for --nostdlib, to avoid loading the
18239 default assemblies.
18240 (Main): Do not put tree resolution here.
18242 * rootcontext.cs: Beginning of the class resolution.
18244 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18246 * rootcontext.cs: Provide better error reporting.
18248 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18250 * rootcontext.cs (CreateInterface): Handle the case where there
18251 are no parent interfaces.
18253 (CloseTypes): Routine to flush types at the end.
18254 (CreateInterface): Track types.
18255 (GetInterfaces): Returns an array of Types from the list of
18256 defined interfaces.
18258 * typemanager.c (AddUserType): Mechanism to track user types (puts
18259 the type on the global type hash, and allows us to close it at the
18262 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18264 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18265 RecordInterface instead.
18267 * cs-parser.jay: Updated to reflect changes above.
18269 * decl.cs (Definition): Keep track of the TypeBuilder type that
18270 represents this type here. Not sure we will use it in the long
18271 run, but wont hurt for now.
18273 * driver.cs: Smaller changes to accomodate the new code.
18275 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18278 * rootcontext.cs (CreateInterface): New method, used to create
18279 the System.TypeBuilder type for interfaces.
18280 (ResolveInterfaces): new entry point to resolve the interface
18282 (CodeGen): Property, used to keep track of the code generator.
18284 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18286 * cs-parser.jay: Add a second production for delegate_declaration
18289 (enum_body): Put an opt_comma here instead of putting it on
18290 enum_body or enum_member_declarations so we can handle trailing
18291 commas on enumeration members. Gets rid of a shift/reduce.
18293 (type_list): Need a COMMA in the middle.
18295 (indexer_declaration): Tell tokenizer to recognize get/set
18297 * Remove old targets.
18299 * Re-add the parser target.
18301 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18303 * cs-parser.jay: Add precendence rules for a number of operators
18304 ot reduce the number of shift/reduce conflicts in the grammar.
18306 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18308 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18311 Get rid of old crufty code.
18313 * rootcontext.cs: Use this to keep track of the parsed
18314 representation and the defined types available to the program.
18316 * gen-treedump.cs: adjust for new convention.
18318 * type.cs: Split out the type manager, and the assembly builder
18321 * typemanager.cs: the type manager will live here now.
18323 * cil-codegen.cs: And the code generator here.
18325 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18327 * makefile: Fixed up for easy making.
18329 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18331 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18334 (unary_expression): Expand pre_increment_expression and
18335 post_decrement_expression to reduce a shift/reduce.
18337 2001-07-11 Simon Cozens
18339 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18341 Improve allow_keyword_as_indent name.
18343 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18345 * Adjustments for Beta2.
18347 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18349 * decl.cs: Added `Define' abstract method.
18350 (InTransit): new property, used to catch recursive definitions.
18352 * interface.cs: Implement `Define'.
18354 * modifiers.cs: Map Modifiers.constants to
18355 System.Reflection.TypeAttribute flags.
18357 * class.cs: Keep track of types and user-defined types.
18358 (BuilderInit): New method for creating an assembly
18359 (ResolveType): New function to launch the resolution process, only
18360 used by interfaces for now.
18362 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18363 that are inserted into the name space.
18365 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18367 * ARGH. I have screwed up my tree so many times due to the use of
18368 rsync rather than using CVS. Going to fix this at once.
18370 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18373 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18375 * Experiment successful: Use System.Type rather that our own
18378 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18380 * cs-parser.jay: Removed nsAliases from here.
18382 Use new namespaces, handle `using XXX;'
18384 * namespace.cs: Reimplemented namespace handling, use a recursive
18385 definition of the class. Now we can keep track of using clauses
18386 and catch invalid using clauses.
18388 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18390 * gen-treedump.cs: Adapted for all the renaming.
18392 * expression.cs (Expression): this class now has a Type property
18393 which returns an expression Type.
18395 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18396 `Type', as this has a different meaning now in the base
18398 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18400 * interface.cs, class.cs: Removed from all the sources the
18401 references to signature computation, as we can not do method
18402 signature computation during the parsing time, as we are not
18403 trying to solve at that point distinguishing:
18407 void a (NS.Blah x) {}
18410 Which depending on the context might be valid or not, as we do not
18411 know if Blah is the same thing as NS.Blah at that point.
18413 * Redid everything so the code uses TypeRefs now instead of
18414 Types. TypeRefs are just temporary type placeholders, that need
18415 to be resolved. They initially have a pointer to a string and the
18416 current scope in which they are used. This is used later by the
18417 compiler to resolve the reference to an actual Type.
18419 * DeclSpace is no longer a CIR.Type, and neither are
18420 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18421 are all DeclSpaces, but no Types.
18423 * type.cs (TypeRefManager): This implements the TypeRef manager,
18424 which keeps track of all the types that need to be resolved after
18425 the parsing has finished.
18427 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18429 * ARGH. We are going to have to store `foreach' as a class rather
18430 than resolving it, as we need to verify error 1579 after name
18431 resolution. *OR* we could keep a flag that says `This request to
18432 IEnumerator comes from a foreach statement' which we can then use
18433 to generate the error.
18435 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18437 * class.cs (TypeContainer.AddMethod): we now add methods to the
18438 MethodGroup instead of the method hashtable.
18440 * expression.cs: Add MethodGroup abstraction, which gets us one
18441 step closer to the specification in the way we handle method
18444 * cs-parser.jay (primary_expression): qualified_identifier now
18445 tried to match up an identifier to a local variable reference or
18446 to a parameter reference.
18448 current_local_parameters is now a parser global variable that
18449 points to the current parameters for the block, used during name
18452 (property_declaration): Now creates an implicit `value' argument to
18455 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18457 * parameter.cs: Do not use `param' arguments as part of the
18458 signature, per the spec.
18460 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18462 * decl.cs: Base class for classes, structs and interfaces. This
18463 is the "Declaration Space"
18465 * cs-parser.jay: Use CheckDef for checking declaration errors
18466 instead of having one on each function.
18468 * class.cs: Factor out some code for handling error handling in
18469 accordance to the "Declarations" section in the "Basic Concepts"
18470 chapter in the ECMA C# spec.
18472 * interface.cs: Make all interface member classes derive from
18473 InterfaceMemberBase.
18475 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18477 * Many things: all interfaces are parsed and generated in
18478 gen-treedump. Support for member variables, constructors,
18479 destructors, properties, constants is there.
18481 Beginning of the IL backend, but very little done, just there for
18484 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18486 * cs-parser.jay: Fix labeled statement.
18488 * cs-tokenizer.cs (escape): Escape " and ' always.
18489 ref_line, ref_name: keep track of the line/filename as instructed
18490 by #line by the compiler.
18493 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18495 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18496 to match the values in System.CodeDOM.
18498 Divid renamed to Divide.
18500 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18502 (Statements.set): remove.
18504 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18507 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18508 falseStatements always have valid values.
18510 * cs-parser.jay: Use System.CodeDOM now.