1 2010-05-05 Marek Safar <marek.safar@gmail.com>
3 * anonymous.cs: Mutate correct set of constraints.
5 2010-05-05 Marek Safar <marek.safar@gmail.com>
8 * expression.cs: Resolve all array bound arguments.
10 2010-05-05 Marek Safar <marek.safar@gmail.com>
12 * import.cs: Don't import private fields.
14 2010-04-30 Marek Safar <marek.safar@gmail.com>
16 Partially based on patch by <sami.lamti@gmail.com>
18 * eval.cs, ecore.cs: Fixed eval show methods.
20 2010-04-30 Marek Safar <marek.safar@gmail.com>
22 * generic.cs, delegate.cs: Implement output type inference of
23 methodgroup now when the specification was cleared at least little
26 2010-04-29 Marek Safar <marek.safar@gmail.com>
29 * class.cs: Fix recursive unmanaged recursice sruct check.
31 2010-04-29 Marek Safar <marek.safar@gmail.com>
34 * expression.cs: Implement typeof unbounded nested generic types.
36 2010-04-29 Marek Safar <marek.safar@gmail.com>
39 * class.cs: Fix valid recursive base type definition.
41 2010-04-29 Marek Safar <marek.safar@gmail.com>
44 * convert.cs, expression.cs: A boxing conversion exists from a
45 nullable-type to a reference type, if a boxing conversion exists
46 from the underlying non-nullable-value-type to the reference type.
48 2010-04-29 Marek Safar <marek.safar@gmail.com>
51 * import.cs: Import volatile modifier.
53 2010-04-29 Marek Safar <marek.safar@gmail.com>
56 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
59 2010-04-29 Marek Safar <marek.safar@gmail.com>
62 * statements.cs: Handle recursive scope initializers.
64 2010-04-28 Marek Safar <marek.safar@gmail.com>
67 * anonymous.cs: Always get inflated version of hoisted variable
68 on generic type definition.
70 2010-04-28 Marek Safar <marek.safar@gmail.com>
72 * import.cs, membercache.cs: Relax rules for valid properties.
74 2010-04-28 Marek Safar <marek.safar@gmail.com>
76 * import.cs: Intern arrays used in generic arguments.
78 2010-04-28 Marek Safar <marek.safar@gmail.com>
81 * convert.cs: Actually use effective base type for the comparison.
83 2010-04-28 Marek Safar <marek.safar@gmail.com>
86 * ecore.cs: Pass arity to base member lookup.
88 2010-04-28 Marek Safar <marek.safar@gmail.com>
91 * expression.cs: MemberAccess is of generic type based on right
94 2010-05-28 Marek Safar <marek.safar@gmail.com>
96 * cs-tokenizer.cs: Made tab size configurable.
98 2010-05-27 Marek Safar <marek.safar@gmail.com>
100 * attribute.cs: Ensure Obsolete members are defined before doing
103 2010-05-27 Marek Safar <marek.safar@gmail.com>
105 * visit.cs: Add DOM visitor skeleton.
109 2010-05-27 Marek Safar <marek.safar@gmail.com>
111 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
113 2010-05-27 Marek Safar <marek.safar@gmail.com>
115 * *.cs: Major rewrite of compiler internals to better work with
116 unmodified System.Reflection.Emit. Some of the key changes are
117 - TypeSpec replaces reflection specific System.Type.
118 - All Type(TypeSpec) operations are now done in compiler therefore
119 no dependency on SRE to inflate generic members and types or to
120 query unclosed types.
121 - MemberCache is now the only and full hierarchical topology.
122 - Generic constraints are implemented properly.
123 - And as a bonus compilation is on average 30% faster.
125 2010-04-15 Jb Evain <jbevain@novell.com>
127 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
129 2010-04-12 Marek Safar <marek.safar@gmail.com>
131 * expression.cs, attribute.cs, parameter.cs: More attribute type
134 2010-04-12 Marek Safar <marek.safar@gmail.com>
136 A fix for bug #593342
138 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
139 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
140 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
141 codegen.cs: Add custom attribute encoder to deal with unfinished
142 types and easier corlib bootstrap from its own types.
144 2010-03-26 Marek Safar <marek.safar@gmail.com>
146 * cs-parser.jay: Report invalid constraint types.
148 2010-03-16 Jb Evain <jbevain@novell.com>
150 * Makefile: rename the net_2_1 profile to moonlight.
152 2010-03-11 Marek Safar <marek.safar@gmail.com>
154 * statement.cs, cs-parser.jay: Use correct location for empty
157 2010-03-11 Marek Safar <marek.safar@gmail.com>
159 * cs-parser.jay: Disable Location from expression.
161 * generic.cs: Check constraints for overrides in the parser.
163 2010-03-09 Marek Safar <marek.safar@gmail.com>
165 * cs-parser.jay (GetLocation): Use an expression when available.
167 2010-03-04 Marek Safar <marek.safar@gmail.com>
169 A fix for bug #582579
170 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
172 2010-03-04 Marek Safar <marek.safar@gmail.com>
174 A patch by kornelpal@gmail.com
176 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
177 compiler generated classes sealed by default. Emit and close top
178 level compiler generated classes as well.
180 * support.cs: Use RuntimeHelpers.GetHashCode.
182 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
184 * Makefile: We need to use the internal bootstrapping gmcs for
185 net_2_1_bootstrap too now.
187 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
189 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
191 2010-03-02 Marek Safar <marek.safar@gmail.com>
193 * cs-tokenizer.cs: Missed few locations in previous fix.
195 2010-03-02 Marek Safar <marek.safar@gmail.com>
197 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
198 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
199 Report correct location for operator errors.
201 2010-03-02 Marek Safar <marek.safar@gmail.com>
203 * typemanager.cs (IsDynamicType): Don't check external types when
204 the attribute is not external.
206 2010-02-24 Marek Safar <marek.safar@gmail.com>
208 A fix for bug #582579
209 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
212 2010-02-24 Marek Safar <marek.safar@gmail.com>
214 A fix for bug #581804
215 * ecore.cs: Fixed type comparison.
217 2010-02-08 Miguel de Icaza <miguel@novell.com>
219 * namespace.cs (CompletionGetTypesStartingWith): Do not include
220 private types in the completion results.
222 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
225 2010-02-17 Marek Safar <marek.safar@gmail.com>
227 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
230 2010-02-14 Miguel de Icaza <miguel@novell.com>
232 * eval.cs: Do not do the report printer dance unless the user has
233 set the DescribeTypes feature.
235 2010-02-10 Marek Safar <marek.safar@gmail.com>
237 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
239 2010-02-08 Marek Safar <marek.safar@gmail.com>
241 A fix for bug #577029
242 * anonymous.cs: Fixed TypeBuilder* check.
244 2010-02-06 Miguel de Icaza <miguel@novell.com>
246 * eval.cs (CompileBlock): Also undo if there are problems during
247 semantic analysis, fixes various cases where invalid C# code would
248 be reported, but the internal changes would not be undone.
250 2010-02-03 Miguel de Icaza <miguel@novell.com>
252 * driver.cs: Change the --fatal flag to allow a number to be
253 passed, this ignores the first N fatal errors. Useful to debug
254 errors that do not happen on the first hit.
256 * cs-parser.jay (invocation_expression): accept both the
257 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
258 inside an invocation.
260 * driver.cs: Expose FatalErrors.
262 * eval.cs: Initialize the printer's Fatal property from the
263 Driver's FatalError flag, this allows csharp --fatal to work
266 Add support for calling Describe (typeof (TYPE)) if the expression
269 2010-02-02 Marek Safar <marek.safar@gmail.com>
271 A fix for bug #574991
272 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
275 2010-02-02 Marek Safar <marek.safar@gmail.com>
277 A fix for bug #575986
278 * expression.cs: Don't mutate typeof type definitions.
280 2010-01-28 Marek Safar <marek.safar@gmail.com>
282 * decl.cs: Use only one set of modifiers.
284 2010-01-26 Marek Safar <marek.safar@gmail.com>
286 A fix for bug #573329
287 * eval.cs: Don't disable error reporting completely on silent mode.
289 2010-01-25 Marek Safar <marek.safar@gmail.com>
291 A fix for bug #573312
292 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
293 pointer index of unknown size types greater than 2.
295 2010-01-15 Marek Safar <marek.safar@gmail.com>
297 * *.cs: Use only 1 member kind enum.
299 2010-01-15 Marek Safar <marek.safar@gmail.com>
301 * *.cs: Add event specification.
303 2010-01-14 Marek Safar <marek.safar@gmail.com>
305 * membercache.cs: Extracted from decl.cs.
307 * *.cs: Put more infrastructure in place.
309 2010-01-13 Marek Safar <marek.safar@gmail.com>
311 * *.cs: Add property specification, unused yet.
313 2010-01-13 Marek Safar <marek.safar@gmail.com>
315 * property.cs: Move all property based declarations into a new file.
317 2010-01-13 Marek Safar <marek.safar at gmail.com>
319 * expression.cs (Conditional): Resolve reduced expression.
321 2010-01-13 Marek Safar <marek.safar at gmail.com>
323 * *.cs: Introduced non-generic method specification.
325 2010-01-07 Marek Safar <marek.safar@gmail.com>
327 * method.cs: Move all method based declarations into a new file.
329 2010-01-07 Marek Safar <marek.safar@gmail.com>
331 * *.cs: Extract field specification.
333 2009-12-17 Marek Safar <marek.safar@gmail.com>
335 * field.cs: Extracted from class.cs
337 2009-12-15 Marek Safar <marek.safar@gmail.com>
339 * attribute.cs (GetFixedBuffer): Work on field definition only.
341 2009-12-15 Marek Safar <marek.safar@gmail.com>
343 * *.cs: Clean up NET_4_0 conditional where possible.
345 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
347 support.cs (DynamicType): Assembly property returns the assembly builder.
348 This is required due to how compiler context works in corlib.
350 2009-12-14 Marek Safar <marek.safar@gmail.com>
352 A fix for bug #564376
353 * assign.cs (LocalTemporary): Removed no longer needed special
356 2009-12-11 Marek Safar <marek.safar@gmail.com>
358 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
359 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
360 enum for easier debugging.
362 2009-12-10 Marek Safar <marek.safar@gmail.com>
364 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
367 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
370 2009-12-10 Marek Safar <marek.safar@gmail.com>
372 * cs-parser.jay, statement.cs: Handle parser error in code
375 2009-12-10 Marek Safar <marek.safar@gmail.com>
377 * ecore.cs: Ignore base imported methods when they are already
380 * eval.cs: Handle non-existent keys.
382 * report.cs, driver.cs: Make fatal work with console printer only.
384 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
386 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
388 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
390 * typemanager.cs: Add MakeGenericMethod that checks if the method
391 is really the generic method definition.
393 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
394 to inflate generic methods.
396 2009-12-08 Marek Safar <marek.safar@gmail.com>
398 A fix for bug #561149
399 * anonymous.cs: Use actual type parameters when checking for generic
402 2009-12-08 Marek Safar <marek.safar@gmail.com>
404 A fix for bug #561369
405 * expression.cs (DoNumericPromotion): Fixed typo.
407 2009-12-08 Marek Safar <marek.safar@gmail.com>
409 *.cs: Moving to generics world.
411 cs-parser.jay: Removed current_array_type.
413 2009-12-07 Marek Safar <marek.safar@gmail.com>
415 *.cs: Moving to generics world.
417 2009-12-04 Marek Safar <marek.safar@gmail.com>
419 *.cs: Moving to generics world (day 2).
421 2009-12-03 Marek Safar <marek.safar@gmail.com>
423 *.cs: Moving to generics world.
425 2009-12-02 Marek Safar <marek.safar@gmail.com>
427 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
428 Encode dynamic type attribute for elements where attributes cannot
431 2009-12-01 Marek Safar <marek.safar@gmail.com>
433 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
436 2009-12-01 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #360455
439 * class.cs: Never report a unused warning for generic events to
440 workaround wrong expression type.
442 2009-11-30 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #558305
445 * decl.cs, class.cs: Check partial method definitions using correct
448 2009-11-30 Marek Safar <marek.safar@gmail.com>
450 * argument.cs: Don't cache rarely used dynamic flag.
452 2009-11-27 Marek Safar <marek.safar@gmail.com>
454 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
456 2009-11-27 Marek Safar <marek.safar@gmail.com>
458 * ecore.cs (SimpleName): Removed no longer needed in_transit as
459 Resolve is now non-reentrant (saves ~0.6MB for corlib).
461 2009-11-26 Marek Safar <marek.safar@gmail.com>
463 A fix for bug #545081
464 * decl.cs: Check private nested types of nested types recursively.
466 2009-11-26 Marek Safar <marek.safar@gmail.com>
468 A fix for bug #558305
469 * location.cs: Ignore self referencing #line directive
471 2009-11-26 Marek Safar <marek.safar@gmail.com>
473 A fix for bug #558292
474 * class.cs: Allow single unsafe fixed buffer fields.
476 2009-11-26 Marek Safar <marek.safar@gmail.com>
478 * expression: Optimize few more zero-based operations.
480 2009-11-26 Marek Safar <marek.safar@gmail.com>
482 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
483 avoids boxing of literal values.
485 2009-11-26 Marek Safar <marek.safar@gmail.com>
487 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
488 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
489 codegen.cs: LocatedToken redesing to avoid excessive allocation and
490 boxing (saves ~7MB for corlib). Also fixes presise token location.
492 2009-11-25 Marek Safar <marek.safar@gmail.com>
494 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
497 2009-11-24 Marek Safar <marek.safar@gmail.com>
499 * expression.cs: Lower static array initializer barrier.
501 * support.cs, driver.cs: Share reader buffer.
503 2009-11-23 Marek Safar <marek.safar@gmail.com>
505 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
507 2009-11-23 Marek Safar <marek.safar@gmail.com>
509 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
510 cleanup some obsolete code.
512 2009-11-20 Marek Safar <marek.safar@gmail.com>
514 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
517 2009-11-20 Marek Safar <marek.safar@gmail.com>
519 * *.cs: Resolved expressions are never resolved again, this helps to
520 uncover some not easy to find bugs and improve the performance.
522 2009-11-19 Marek Safar <marek.safar@gmail.com>
524 * *.cs: Made constant expressions fully compatible with any other
527 2009-11-19 Marek Safar <marek.safar@gmail.com>
529 * *.cs: DoResolve is a worker method and has to be protected.
531 2009-11-18 Marek Safar <marek.safar@gmail.com>
533 * *.cs: More context specific handling.
535 2009-11-17 Marek Safar <marek.safar@gmail.com>
537 * *.cs: More context specific handling.
539 2009-11-16 Marek Safar <marek.safar@gmail.com>
541 * dynamic.cs, class.cs: Removed few fixed user types conversions.
543 * symbolwriter.cs: Uses public ILOffset.
545 2009-11-13 Marek Safar <marek.safar@gmail.com>
547 A fix for bug #553650
548 * generic.cs: Another missing TypeToCoreType, still too many to fix.
550 2009-11-13 Marek Safar <marek.safar@gmail.com>
552 A fix for bug #555170
554 * class.cs, delegate.cs, enum.cs: Constants have to be available
555 for parameters resolve.
557 2009-11-12 Marek Safar <marek.safar@gmail.com>
559 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
562 2009-11-12 Marek Safar <marek.safar@gmail.com>
564 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
565 with a statically known candidate set.
567 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
569 * generic.cs: Made type inflation for generic constraint checks
570 recursive. This fixes BGO #553655.
572 2009-11-11 Marek Safar <marek.safar@gmail.com>
574 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
577 2009-11-10 Marek Safar <marek.safar@gmail.com>
579 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
580 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
581 attribute.cs: Add some dynamic error checking.
583 2009-11-07 Marek Safar <marek.safar@gmail.com>
585 A fix for bug #553465
587 * expression.cs: Fixed mixed version of expression tree anonymous
590 2009-11-06 Marek Safar <marek.safar@gmail.com>
592 A fix for bug #553031
594 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
595 expression tree version of anonymous type with members declaration.
597 2009-11-05 Marek Safar <marek.safar@gmail.com>
599 * parameter.cs: Handle nullable parameter default expression.
601 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
602 class.cs, attribute.cs: Check for wrong dynamic arguments.
604 2009-11-05 Marek Safar <marek.safar@gmail.com>
606 * statement.cs: Dynamic statements.
608 2009-11-04 Marek Safar <marek.safar@gmail.com>
610 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
611 Compound assignments over dynamic type.
613 2009-11-03 Marek Safar <marek.safar@gmail.com>
615 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
616 constructor arguments.
618 2009-10-30 Marek Safar <marek.safar@gmail.com>
620 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
621 codegen.cs: Unary mutator on dynamic member access expression.
623 2009-10-29 Marek Safar <marek.safar@gmail.com>
625 A fix for bug #550580
626 * convert.cs: Don't eliminate explicit precission casts.
628 2009-10-28 Marek Safar <marek.safar@gmail.com>
630 A fix for bug #550404
632 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
633 expression.cs, statement.cs, ecore.cs: Quote any nested expression
636 2009-10-27 Marek Safar <marek.safar@gmail.com>
638 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
641 * class.cs: Allow nullable binary user operators.
643 2009-10-26 Marek Safar <marek.safar@gmail.com>
645 * expression.cs: Move binary expression optimization at the end of
648 2009-10-23 Marek Safar <marek.safar@gmail.com>
650 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
651 Separate NullConstant from NullLiteral.
653 2009-10-23 Marek Safar <marek.safar@gmail.com>
655 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
656 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
657 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
658 ModuleContainer. Add common unclosed member check routine.
660 2009-10-22 Marek Safar <marek.safar@gmail.com>
662 * argument.cs: Use literal flag for real literals only.
664 * dynamic.cs: Use correct return type for custom delegates.
666 2009-10-22 Marek Safar <marek.safar@gmail.com>
668 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
671 2009-10-22 Marek Safar <marek.safar@gmail.com>
673 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
675 2009-10-21 Marek Safar <marek.safar@gmail.com>
677 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
680 2009-10-21 Marek Safar <marek.safar@gmail.com>
682 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
685 2009-10-20 Marek Safar <marek.safar@gmail.com>
687 * argument.cs, dynamic.cs, expression.cs: Latest API update.
689 2009-10-19 Marek Safar <marek.safar@gmail.com>
691 * typemanager.cs, expression.cs: Dynamic array initializer.
693 2009-10-16 Marek Safar <marek.safar@gmail.com>
695 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
698 2009-10-16 Marek Safar <marek.safar@gmail.com>
700 A fix for bug #493523, #507067
701 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
702 standard nullable conversion using underlying standard conversion
703 and not full conversion.
705 2009-10-15 Marek Safar <marek.safar@gmail.com>
707 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
708 type in VerifyArgumentsCompat.
710 2009-10-15 Marek Safar <marek.safar@gmail.com>
712 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
713 Reject variable used with type arguments.
715 2009-10-14 Marek Safar <marek.safar@gmail.com>
717 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
718 Implement dynamic expressions assignment.
720 2009-10-14 Marek Safar <marek.safar@gmail.com>
722 * expression.cs: Build underlying expression when resolving unary
725 2009-10-14 Marek Safar <marek.safar@gmail.com>
727 * expression.cs: Emit enum array initializer using binary blob.
729 2009-10-08 Marek Safar <marek.safar@gmail.com>
731 * typemanager.cs, constant.cs: Optimize decimal constants which fit
734 2009-10-07 Marek Safar <marek.safar@gmail.com>
736 * typemanager.cs: Reset object_type.
738 * assign: Made SimpleAssign public.
740 2009-10-06 Marek Safar <marek.safar@gmail.com>
742 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
743 invocation assembly to IsThisOrFriendAssembly.
745 2009-10-05 Marek Safar <marek.safar@gmail.com>
747 * expression.cs: Equality comparison of generic parameter with
750 2009-10-05 Marek Safar <marek.safar@gmail.com>
752 A fix for bug #543570
753 * generic.cs: Import predefined constraints correctly.
755 2009-10-02 Marek Safar <marek.safar@gmail.com>
757 * ecore.cs: Don't crash on overloads with optional paremeters where
758 arguments count overflows.
760 * parameter.cs: Import optional parameter constants using optional
763 2009-10-01 Marek Safar <marek.safar@gmail.com>
765 * Makefile: Default is gmcs compiler.
767 2009-10-01 Marek Safar <marek.safar@gmail.com>
769 * cs-parser.jay: Fixed few NRE.
771 2009-10-01 Marek Safar <marek.safar@gmail.com>
773 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
775 2009-09-30 Marek Safar <marek.safar@gmail.com>
777 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
778 ShimExpression, ImplicitCast.
780 2009-09-30 Marek Safar <marek.safar@gmail.com>
782 A fix for bug #542959
783 * delegate.cs: Emit correct delegate instance variable when there
784 are static and non-static overloads.
786 2009-09-29 Marek Safar <marek.safar@gmail.com>
788 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
789 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
791 2009-09-28 Marek Safar <marek.safar@gmail.com>
793 A fix for bug #542487
794 * ecore.cs: Resolve extension methods hidden by properties.
796 2009-09-25 Marek Safar <marek.safar@gmail.com>
798 * expression.cs, ecore.cs: More dynamic binary expressions.
800 2009-09-22 Marek Safar <marek.safar@gmail.com>
802 * nullable.cs, expression.cs: Fixed null lifted conversion for
803 bitwise enum operations.
805 2009-09-22 Marek Safar <marek.safar@gmail.com>
807 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
808 values in checked context.
810 2009-09-22 Marek Safar <marek.safar@gmail.com>
812 * expression.cs, ecore.cs: Fixed array index constant conversion.
814 2009-09-20 Miguel de Icaza <miguel@novell.com>
816 * expression.cs: Do not crash when MemberLookup returns something
817 that is not a MemberExpr here. Report error 582 instead.
821 2009-09-18 Marek Safar <marek.safar@gmail.com>
823 * decl.cs, class.cs: Check protected property accessors.
825 2009-09-18 Marek Safar <marek.safar@gmail.com>
827 * dynamic.cs, assign.cs: Dynamic compound assignment.
829 2009-09-17 Marek Safar <marek.safar@gmail.com>
831 * expression.cs: Fixed compound assignment explicit conversion.
833 2009-09-17 Marek Safar <marek.safar@gmail.com>
835 * expression.cs, ecore.cs: Cannot infer variables from method group.
837 2009-09-16 Marek Safar <marek.safar@gmail.com>
839 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
840 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
841 codegen.cs: Dynamic binary operations scaffolding.
843 2009-09-15 Marek Safar <marek.safar@gmail.com>
845 * expression.cs: Fixes nullable promotion for enum type variables.
847 2009-09-11 Marek Safar <marek.safar@gmail.com>
849 * driver.cs, dynamic.cs: Reset more static variables.
851 2009-09-11 Marek Safar <marek.safar@gmail.com>
853 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
854 driver.cs: Introduced Expression::MakeExpression.
856 2009-09-11 Marek Safar <marek.safar@gmail.com>
858 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
860 2009-09-09 Marek Safar <marek.safar@gmail.com>
862 * eval.cs, report.cs: Use Console.Out for all eval error or warning
865 2009-09-09 Marek Safar <marek.safar@gmail.com>
867 A fix for bug #518707
868 * expression.cs (Is): Optimize only generic parameter type
869 expression probing value type generic parameter.
871 2009-09-09 Marek Safar <marek.safar@gmail.com>
873 A fix for bug #532571
874 * ecore.cs: Check for simple name type arguments used with
877 2009-09-08 Marek Safar <marek.safar@gmail.com>
879 A fix for bug #497421
880 * generic.cs (CheckConstraint): Don't use buildin types to check for
881 parameterless constructor.
883 2009-09-08 Marek Safar <marek.safar@gmail.com>
885 A fix for bug #537402
886 * generic.cs (CheckConstraint): Correctly inflate generic type
887 arguments when checking generic method.
889 2009-09-08 Marek Safar <marek.safar@gmail.com>
891 A fix for bug #536463
892 * decl.cs (AddToContainer): Don't report collision between explicit
893 and parameterless non-explicit members.
895 2009-09-08 Marek Safar <marek.safar@gmail.com>
897 * eval.cs: Reset more static stuff.
899 2009-09-07 Marek Safar <marek.safar@gmail.com>
901 A fix for bug #324625
902 * expression.cs, ecore.cs: Create nested generic type expression
903 using declaring and not current type.
905 2009-09-07 Marek Safar <marek.safar@gmail.com>
907 * *.cs: Changed Report class to accept various output printers and
908 be an instance class. An expression resolver can now use different
909 message reporter for each call and Report.Error can safely throw
910 an exception. Part of ongoing work to turn mcs into proper library.
912 2009-09-04 Marek Safar <marek.safar@gmail.com>
914 * statement.cs, ecore.cs: Removed error reporting from emit code.
916 2009-09-04 Marek Safar <marek.safar@gmail.com>
918 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
920 2009-09-03 Marek Safar <marek.safar@gmail.com>
922 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
923 parser checks out of constructors.
925 2009-09-02 Marek Safar <marek.safar@gmail.com>
927 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
929 2009-09-02 Marek Safar <marek.safar@gmail.com>
931 A fix for bug #535448
932 * anonymous.cs, class.cs: Copy return label between all contexts.
934 2009-09-02 Marek Safar <marek.safar@gmail.com>
936 A fix for bug #535395
937 * namespace.cs: Resolve context can be null.
939 2009-08-25 Marek Safar <marek.safar@gmail.com>
941 A fix for bug #533912
942 * generic.cs: Use correct context for constraints resolving.
944 2009-08-25 Marek Safar <marek.safar@gmail.com>
946 A fix for bug #532630
947 * driver.cs: Trim conditional symbols.
949 2009-08-25 Marek Safar <marek.safar@gmail.com>
951 * context.cs: New file.
953 * *.exe.sources, *.csproj: Updated.
955 2009-08-25 Marek Safar <marek.safar@gmail.com>
957 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
958 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
959 IMembercontext, some small cleanups.
961 2009-08-24 Marek Safar <marek.safar@gmail.com>
963 * *.cs: Split ResolveContext and EmitContext.
965 2009-08-24 Marek Safar <marek.safar@gmail.com>
967 * *.cs: Only ResolveContext implements IMemberContext.
969 2009-08-21 Marek Safar <marek.safar@gmail.com>
971 * *.cs: Renamed IResolveContext to IMemberContext.
973 2009-08-21 Marek Safar <marek.safar@gmail.com>
975 * *.cs: Detached ResolveContext from EmitContext.
977 2009-08-21 Marek Safar <marek.safar@gmail.com>
979 * codegen.cs: Moved flow-analysis to BlockContext.
981 2009-08-21 Marek Safar <marek.safar@gmail.com>
983 * *.cs: Detached BlockContext from EmitContext.
985 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
987 * statement.cs: avoid nullref when the return value of GetEnumerator()
988 does not contain any MoveNext() method.
990 2009-08-19 Marek Safar <marek.safar@gmail.com>
992 * *.cs: Removed IResolveContext::GenericDeclContainer.
994 2009-08-19 Marek Safar <marek.safar@gmail.com>
996 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
998 2009-08-19 Marek Safar <marek.safar@gmail.com>
1000 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1001 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1003 2009-08-18 Marek Safar <marek.safar@gmail.com>
1005 * *.cs: Removed boolean fields from EmitContext.
1007 2009-08-18 Marek Safar <marek.safar@gmail.com>
1009 * *.cs: Add IResolveContext::IsStatic.
1011 2009-08-18 Marek Safar <marek.safar@gmail.com>
1013 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1015 2009-08-17 Marek Safar <marek.safar@gmail.com>
1017 * *.cs: Removed DeclContainer from EmitContext.
1019 2009-08-17 Marek Safar <marek.safar@gmail.com>
1021 * *.cs: Add IResolveContext::CurrentTypeParameters.
1023 2009-08-14 Marek Safar <marek.safar@gmail.com>
1025 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1027 2009-08-14 Marek Safar <marek.safar@gmail.com>
1029 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1030 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1032 2009-08-13 Marek Safar <marek.safar@gmail.com>
1034 * decl.cs: Look in PartialContainer for parent type parameters.
1036 2009-08-13 Marek Safar <marek.safar@gmail.com>
1038 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1039 codegen.cs: Add IResolveContext::LookupTypeParameter.
1041 2009-08-13 Marek Safar <marek.safar@gmail.com>
1043 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1044 Moved resolved logic from Emit to Resolve.
1046 2009-08-13 Marek Safar <marek.safar@gmail.com>
1048 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1049 codegen.cs: Reworked atttributes handling of ResolveContext.
1051 2009-08-12 Marek Safar <marek.safar@gmail.com>
1053 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1054 LookupNamespaceOrType to ResolveContext.
1056 2009-08-12 Marek Safar <marek.safar@gmail.com>
1058 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1059 class.cs: Removed unused parameters and methods.
1061 2009-08-11 Marek Safar <marek.safar@gmail.com>
1063 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1064 codegen.cs: Finding the best common type of a set of expressions for
1067 2009-08-07 Marek Safar <marek.safar@gmail.com>
1069 * dynamic.cs, expression.cs: More dynamic conversions.
1071 2009-08-06 Miguel de Icaza <miguel@novell.com>
1073 * generic.cs: This loop was incorrect, it was increment ii, but
1074 checking for `i'. This was a change introduced to fix #327497,
1077 * class.cs: Catch another case for cs0533 error, fixes #324782.
1079 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1081 * typemanager.cs (GetGenericArguments): SRE returns null for
1082 generic methods on type builder instances if they are not generic
1083 themselves. For example, for Foo<int>::Bar() it returns null, but
1084 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1086 2009-08-05 Marek Safar <marek.safar@gmail.com>
1088 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1089 delegate.cs: Work on dynamic binding.
1091 2009-08-04 Marek Safar <marek.safar@gmail.com>
1093 A second fix for bug #525342
1094 * class.cs: Attach partial method attributes to method
1097 2009-08-03 Marek Safar <marek.safar@gmail.com>
1099 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1102 * rootcontext.cs: Default to langversion v4.
1104 2009-08-03 Marek Safar <marek.safar@gmail.com>
1106 * pending.cs: Check return type before member info is set.
1108 2009-08-03 Marek Safar <marek.safar@gmail.com>
1110 * anonymous.cs: Fully initialize generic hoisted field expression.
1112 2009-08-02 Miguel de Icaza <miguel@novell.com>
1114 * cs-parser.jay: Flag variables declared on the interactive shell
1115 as used to prevent the 168 warning about local variable not being
1118 2009-07-31 Marek Safar <marek.safar@gmail.com>
1120 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1121 attribute.cs: Emit dynamic export attribute.
1123 2009-07-30 Marek Safar <marek.safar@gmail.com>
1125 * expression.cs: More verifier work.
1127 2009-07-29 Marek Safar <marek.safar@gmail.com>
1129 * nullable.cs: Fixed SRE crash during corlib compilation.
1131 2009-07-29 Marek Safar <marek.safar@gmail.com>
1133 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1134 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1135 More TypeManager.TypeToCoreType needed.
1137 2009-07-29 Marek Safar <marek.safar@gmail.com>
1139 * anonymous.cs: Update after recent SRE fixes.
1141 2009-07-28 Marek Safar <marek.safar@gmail.com>
1143 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1144 version of GetFieldHandle for fields of generic types.
1146 2009-07-27 Marek Safar <marek.safar@gmail.com>
1148 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1149 ecore.cs: Add TypeManager.IsDynamicType,
1150 PredefinedAttributes.Dynamic.
1152 2009-07-27 Marek Safar <marek.safar@gmail.com>
1154 A fix for bug #415375
1155 * expression.cs: Fixed object and reference type parameter
1158 2009-07-27 Marek Safar <marek.safar@gmail.com>
1160 A fix for bug #525342
1161 * class.cs: Attach partial method attributes to method
1164 2009-07-24 Marek Safar <marek.safar@gmail.com>
1166 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1169 2009-07-24 Marek Safar <marek.safar@gmail.com>
1171 * anonymous.cs (MutateField): Add imported types handling.
1173 2009-07-23 Marek Safar <marek.safar@gmail.com>
1175 * expression.cs, delegate.cs: Moved arguments resolve into their
1176 counterparts expressions. Removed argument resolve from
1177 CollectionElementInitializer.
1179 2009-07-23 Marek Safar <marek.safar@gmail.com>
1181 A fix for bug #523683
1182 * convert.cs, delegate.cs: Use common overload mechanism for method
1183 group conversion check.
1185 2009-07-22 Marek Safar <marek.safar@gmail.com>
1187 A fix for bug #523899
1188 * generics.cs: Exact type inference with other bound types.
1190 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1192 Don't complain when the same type is implemented by the output
1193 assembly as well as multiple referenced assemblies
1194 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1195 'must_be_unique' flag.
1196 (GlobalRootNamespace): Update to changes.
1197 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1198 already have a type in hand.
1200 2009-07-22 Marek Safar <marek.safar@gmail.com>
1202 * expression.cs: More verifier instrumentation.
1204 * statement.cs: Do proper throw expression conversion.
1206 2009-07-22 Marek Safar <marek.safar@gmail.com>
1208 A fix for bug #522789
1209 * expression.cs: Mutate invocation return type.
1211 2009-07-16 Marek Safar <marek.safar@gmail.com>
1213 * anonymous.cs: Split assignable and readonly generated variable
1216 2009-07-16 Marek Safar <marek.safar@gmail.com>
1218 A fix for bug #521671
1219 * statement.cs: Fixed crash when checking missing type.
1221 2009-07-16 Marek Safar <marek.safar@gmail.com>
1223 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1224 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1225 class.cs, driver.cs: Work on dynamic binding.
1227 * dynamic.cs: New file.
1229 * *.sources, *.proj: Updated.
1231 2009-07-15 Marek Safar <marek.safar@gmail.com>
1233 * expression.cs (Conditional): Avoid double Resolve.
1235 2009-07-13 Marcus Griep <marcus@griep.us>
1237 * ecore.cs: Fix obscure bug with resolving members of interfaces
1238 that hide parent interface members. Fixes bug #444388 and corrects
1241 2009-07-13 Marek Safar <marek.safar@gmail.com>
1243 * expression.cs (LocalVariableReference): Bounce resolve.
1245 2009-07-10 Marek Safar <marek.safar@gmail.com>
1247 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1248 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1251 * support.cs: New dynamic type wrapper.
1253 2009-07-08 Marek Safar <marek.safar@gmail.com>
1255 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1256 typed local variable.
1258 2009-07-06 Marek Safar <marek.safar@gmail.com>
1260 A fix for bug #519005
1261 * anonymous.cs: Use null_type as no return type placeholder.
1263 2009-07-02 Marek Safar <marek.safar@gmail.com>
1265 * generic.cs: Handle type inference of identical type parameters
1266 with different bounds.
1268 2009-07-01 Marek Safar <marek.safar@gmail.com>
1270 * expression.cs, class.cs: Events variance.
1272 * cs-parser.jay: Interface events error messages.
1274 2009-07-01 Marek Safar <marek.safar@gmail.com>
1276 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1278 2009-06-29 Marek Safar <marek.safar@gmail.com>
1280 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1281 parameter expression can be value-type New.
1283 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1285 2009-06-26 Marek Safar <marek.safar@gmail.com>
1287 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1288 Implemented C# 4.0 named arguments.
1290 2009-06-24 Marek Safar <marek.safar@gmail.com>
1292 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1293 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1294 parameter modifier. Also fixes bug #515497.
1296 2009-06-24 Marek Safar <marek.safar@gmail.com>
1298 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1299 arguments expression to be implemented.
1301 *.sources: Add argument.cs
1303 2009-06-23 Marek Safar <marek.safar@gmail.com>
1305 * parameter.cs: Moved GetParameterIndexByName to base class.
1307 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1308 unused AType. Use argument's version of GetExpressionTree.
1310 2009-06-22 Marek Safar <marek.safar@gmail.com>
1312 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1315 2009-06-17 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #514096
1318 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1320 2009-06-17 Marek Safar <marek.safar@gmail.com>
1322 * expression.cs: The first multi-dimensional array nested array
1323 initializers was not checked.
1325 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1327 2009-06-17 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #513400
1330 * nullable.cs (EmitEquality): Operands emit could be simplified for
1331 built-in types when we now emit user operators differently.
1333 2009-06-16 Marek Safar <marek.safar@gmail.com>
1335 * ecore.cs: Report inaccessible delegate methods correctly.
1337 2009-06-16 Marek Safar <marek.safar@gmail.com>
1339 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1340 cs-parser.jay: Implemented C# 4.0 optional parameters.
1342 2009-06-16 Marek Safar <marek.safar@gmail.com>
1344 * driver.cs: Removed broken DefineManifestResource.
1346 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1348 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1349 Use $(BOOTSTRAP_PROFILE) instead.
1351 2009-06-12 Jb Evain <jbevain@novell.com>
1353 * rootcontext.cs: add a Platform field.
1354 * driver.cs: handle /platform.
1355 * codegen.cs: pass the proper flags according to
1356 the platform when saving the assembly.
1358 2009-06-11 Marek Safar <marek.safar@gmail.com>
1360 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1361 Add optional parameters grammar.
1363 2009-06-10 Marek Safar <marek.safar@gmail.com>
1365 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1366 driver.cs: Split lang version and metadata version.
1368 2009-06-10 Marek Safar <marek.safar@gmail.com>
1370 * decl.cs: Better overload ctor collision error message.
1372 2009-06-05 Jb Evain <jbevain@novell.com>
1374 * driver.cs (EmbededResource): avoid using an internal method
1375 in gmcs to embed manifest resources.
1377 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1379 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1380 the compiler from older mono versions (like moon's bots)
1382 2009-06-04 Marek Safar <marek.safar@gmail.com>
1384 * namespace.cs (LookupTypeReflection): Ignore collisions between
1387 2009-06-04 Marek Safar <marek.safar@gmail.com>
1389 * codegen.cs: Enabled generic type forwarders.
1391 2009-06-04 Marek Safar <marek.safar@gmail.com>
1393 * dmcs.*: Add another version of SRE compiler.
1395 2009-06-03 Marek Safar <marek.safar@gmail.com>
1397 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1398 generic-mcs.cs: Fixed variant type conversions.
1400 2009-06-02 Marek Safar <marek.safar@gmail.com>
1402 A fix for bug #507863
1403 * codegen.cs: Fixes a crash on invalid string value attribute.
1405 2009-06-01 Marek Safar <marek.safar@gmail.com>
1407 A fix for bug #508334
1408 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1409 cs-parser.jay: Fully import __arglist modifier.
1411 2009-05-29 Marek Safar <marek.safar@gmail.com>
1413 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1414 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1415 actually work with closed generic types.
1417 2009-05-27 Alan McGovern <amcgovern@novell.com>
1419 * class.cs, decl.cs, delegate.cs, parameter.cs:
1420 Fix the build by replacing the use of 'var' with the actual type.
1422 2009-05-27 Marek Safar <marek.safar@gmail.com>
1424 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1425 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1428 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1431 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1432 Marek Safar <marek.safar@gmail.com>
1434 A fix for bug #377509
1435 * parameter.cs: Use predefined and not empty name for implicit
1438 2009-05-21 Marek Safar <marek.safar@gmail.com>
1440 * class.cs: Don't report wrong warnings for event fields.
1442 2009-05-21 Marek Safar <marek.safar@gmail.com>
1444 A fix for bug #504667
1445 * class.cs: Check for static class using parent container instead of
1448 2009-05-08 Marek Safar <marek.safar@gmail.com>
1450 A fix for bug #496922
1451 * expression.cs: Always use temporary variable when using object
1454 2009-04-28 Marek Safar <marek.safar@gmail.com>
1456 A fix for bug #495112
1457 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1460 2009-04-27 Miguel de Icaza <miguel@novell.com>
1462 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1464 2009-04-24 Miguel de Icaza <miguel@novell.com>
1466 * complete.cs: No idea how gonzalo got a null in the list, but
1469 2009-04-24 Miguel de Icaza <miguel@novell.com>
1471 * complete.cs (CompletionElementInitializer): New completion class
1472 to support completing inside a C# 3 element initializer, so this
1473 allows completion for Silverlight situations where it is very
1476 new TextBlock () { Fo<TAB>
1478 (CompletionSimpleName): Expose the prefix that was
1479 passed to the simple name.
1481 * cs-parser.jay (object_or_collection_initializer): Add support
1482 for element_initializers.
1484 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1485 special case completion expressions as this method aggressively
1486 collects data before it operates, and errors were being thrown
1487 earlier than we were able to complete.
1489 2009-04-23 Miguel de Icaza <miguel@novell.com>
1491 * eval.cs: Make getcompletions silent and enable debugging output
1492 if the -v option is passed.
1494 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1495 Consider looking up the namespace that matches the prefix being
1498 This is part of the support for allowing completions like:
1499 `System.Co<TAB>' to complete to System.Console.
1501 * complete.cs (CompletionSimpleName.AppendResults): Make this
1504 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1506 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1507 COMPLETE_COMPLETION as internal.
1509 2009-04-17 Miguel de Icaza <miguel@novell.com>
1511 * complete.cs: Include namespace resolution in simple names as
1512 well as global types and types in the using scope in the
1515 * namespace.cs: Supporting infrastrcture to provide completions
1516 based on the current using scope.
1518 * eval.cs: Introduce an entry point that allows for initialization
1519 to return a list of the files passed on the command line.
1521 2009-04-14 Marek Safar <marek.safar@gmail.com>
1523 A fix for bug #494243
1524 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1526 2009-04-13 Marek Safar <marek.safar@gmail.com>
1528 A fix for bug #493887
1529 * statement.cs: Don't skip string multi-section with default or
1530 null label when populating string hashtable.
1532 2009-04-06 Marek Safar <marek.safar@gmail.com>
1534 A fix for bug #492329
1535 * expression.cs (New): Load variable when assigning type parameter
1538 2009-04-06 Marek Safar <marek.safar@gmail.com>
1540 A fix for bug #488960
1541 * decl.cs: Compare MVAR types using non-null values.
1543 2009-03-27 Marek Safar <marek.safar@gmail.com>
1545 * typemanager.cs, expression.cs: Removed unused nullable checks.
1547 2009-03-27 Marek Safar <marek.safar@gmail.com>
1549 * *.cs: Removed some gmcs conditionals.
1551 2009-03-26 Marek Safar <marek.safar@gmail.com>
1553 * generic.cs, support.cs: Moved generics stuff out of support.cs
1555 2009-03-24 Marek Safar <marek.safar@gmail.com>
1557 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1560 2009-03-23 Marek Safar <marek.safar@gmail.com>
1562 * attribute.cs: Consider all members for error reporting when
1563 checking named arguments.
1565 2009-03-23 Marek Safar <marek.safar@gmail.com>
1567 A fix for bug #487625
1568 * namespace.cs: Use a warning for all predefined type conflicts.
1570 2009-03-23 Marek Safar <marek.safar@gmail.com>
1572 A fix for bug #485706
1573 * statement.cs: Explicitly type catch type argument to pass verifier
1576 2009-03-22 Miguel de Icaza <miguel@novell.com>
1578 Initial support to provide code completion facilities to consumers
1579 of the evaluator API.
1581 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1582 support the completion engine. When we reach the end of the
1583 input stream instead of returning EOF, when this flag is true the
1584 tokenizer instead produces:
1586 One GENERATE_COMPLETION token: this token then must be
1587 handled in the grammar at every point where the user
1588 would likely request a completion.
1590 As many COMPLETE_COMPLETION tokens as necessary. These
1591 tokens are generated to assist the parser in unwinding and
1592 producing a valid parse tree.
1594 The parser rules do not have to be perfect, the parser needs to be
1595 augmented with judicious use of GENERATE_COMPLETION tokens to
1596 improve the areas where we can provide completion and the parser
1597 needs to add support for COMPLETE_COMPLETION tokens in productions
1600 It is common to not have enough support for COMPLETE_COMPLETION
1601 under certain rules and that even if we generated the
1602 GENERATE_COMPLETION token that the resulting tree will be invalid
1603 due to the missing rules that support COMPLETE_COMPLETION.
1605 The final EOF token is produced by having the parser notify the
1606 tokenizer when it reaches the root production that the next token
1609 * support.cs (CompletionResult): New Exception. This exception
1610 is thrown to return the completion results when one of the special
1611 completion expressions is reached.
1613 This exception is thrown by the completing ExpressionStatements
1614 classes that live in complete.cs
1616 * complete.cs (CompletingExpression): a new base class for
1617 completing expressions. This derives from the
1618 ExpressionStatement class and not from Expression as it allows
1619 completion to happen not only where expressions are expected in
1620 the grammar, but also where statements are expected.
1622 (CompletionSimpleName): A new class used to provide completions
1623 for SimpleNames. This currently only resolves to local
1624 variables from the evaluator context (GetVars call).
1626 (CompletionMemberAccess): Implements support for completing member
1629 * cs-parser.jay: Add support for completion in a few places.
1631 * eval.cs (GetCompletions): New public API for the evaluator that
1632 returns a list of possible completions given the input. The
1633 return value is an array of completions
1635 * anonymous.cs (Compatible): If the exception thrown from the
1636 resolved expression is a CompletionResult exception let that one
1637 through instead of printing a diagnostic error in the try/catch.
1639 2009-03-22 Miguel de Icaza <miguel@novell.com>
1643 * driver.cs (Main): Use Environment.Exit to quit quickly and
1644 prevent the compiler from doing the usual wait for helper thread
1647 This is to prevent a slowdown that was reported by Gonzalo on
1650 2009-03-19 Marek Safar <marek.safar@gmail.com>
1652 * ecore.cs: Load build-in types directly instead of accessing
1655 2009-03-18 Marek Safar <marek.safar@gmail.com>
1657 * ecore.cs: Always use unbox.any when available.
1659 2009-03-18 Marek Safar <marek.safar@gmail.com>
1661 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1663 2009-03-17 Marek Safar <marek.safar@gmail.com>
1665 * generic.cs: Removed obsolete version of type inference.
1667 2009-03-16 Marek Safar <marek.safar@gmail.com>
1669 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1670 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1671 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1672 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1674 2009-03-11 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #482996
1677 * anonymous.cs: Make sure we are not infering return type when
1678 checking type compatibility.
1680 2009-03-11 Marek Safar <marek.safar@gmail.com>
1682 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1683 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1684 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1685 attributes in their own structure. Needed when accessing their
1686 properties before they are resolved.
1688 2009-03-09 Marek Safar <marek.safar@gmail.com>
1690 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1691 hashtable (~10x faster).
1693 * driver.cs: Removed wrong Reset.
1695 2009-03-08 Marek Safar <marek.safar@gmail.com>
1697 * class.cs: Use correct common base type for unmanaged delayed
1700 * rootcontext.cs: Wrap unhandled exception.
1702 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1704 Make SeekableStreamReader self-tuning and arbitrarily seekable
1705 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1707 (SeekableStreamReader.Position.set): Use it. Simplify logic
1708 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1709 buffer size when the stream needs to be re-read from the beginning.
1711 2009-03-05 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #480100
1714 * parameter.cs: A parameter is not hoisted when used directly as ET.
1716 2009-03-04 Marek Safar <marek.safar@gmail.com>
1718 * statement.cs: Fixed an issue when using variable is of interface
1721 2009-03-03 Marek Safar <marek.safar@gmail.com>
1723 A fix for bug #480319
1724 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1726 2009-03-03 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #480867
1729 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1730 expression to have no valid type.
1732 2009-03-03 Marek Safar <marek.safar@gmail.com>
1734 A fix for bug #481258
1735 * class.cs: Set extension method flag in partial container.
1737 2009-03-03 Marek Safar <marek.safar@gmail.com>
1739 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1741 * attribute.cs: Add sanity check.
1743 2009-02-27 Marek Safar <marek.safar@gmail.com>
1745 * class.cs: Add external constructor error.
1747 2009-02-26 Marek Safar <marek.safar@gmail.com>
1749 A fix for bug #475354
1750 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1751 correctly user defined nullable equality operators.
1753 2009-02-25 Marek Safar <marek.safar@gmail.com>
1755 A fix for bug #479532
1756 * expression.cs: Implement NewInitialize::AddressOf.
1758 2009-02-25 Marek Safar <marek.safar@gmail.com>
1760 A fix for bug #413633
1761 * expression.cs: Iterate all base class-constraint types.
1763 2009-02-24 Marek Safar <marek.safar@gmail.com>
1765 A fix for bug #479209
1766 * literal.cs: Mutate null underlying type.
1768 2009-02-24 Marek Safar <marek.safar@gmail.com>
1770 A fix for bug #476295
1771 * convert.cs: Avoid wrapping implicitly convertible reference type.
1773 2009-02-23 Marek Safar <marek.safar@gmail.com>
1775 * iterators.cs: Create MemberName correctly.
1777 2009-02-23 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #478655
1780 * literal.cs: Check also underlying null type conversion.
1782 2009-02-21 Marek Safar <marek.safar@gmail.com>
1784 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1786 2009-02-20 Marek Safar <marek.safar@gmail.com>
1788 A fix for bug #477447
1789 * statement.cs: Add reference to correct parent storey when this
1790 is accessible from deep children storey (more than 1 level).
1792 2009-02-19 Marek Safar <marek.safar@gmail.com>
1794 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1795 * class.cs: Define base type members before setting up member cache.
1797 2009-02-18 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #477378
1800 * nullable.cs, expression.cs, statement.cs: More precise null type
1803 2009-02-18 Marek Safar <marek.safar@gmail.com>
1805 A fix for bug #472805
1806 * typemanager.cs, namespace.cs: Import only visible extension method
1809 2009-02-18 Marek Safar <marek.safar@gmail.com>
1811 A fix for bug #476895
1812 * attribute.cs: Use correct resolve context for attribute type.
1814 2009-02-18 Marek Safar <marek.safar@gmail.com>
1816 A fix for bug #476266
1817 * anonymous.cs: Mutate multi-dimensional arrays.
1819 2009-02-18 Marek Safar <marek.safar@gmail.com>
1821 A fix for bug #476400
1822 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1824 2009-02-18 Marek Safar <marek.safar@gmail.com>
1826 A fix for bug #476811
1827 * generics.cs: Fixed null-literal check.
1829 2009-02-17 Marek Safar <marek.safar@gmail.com>
1831 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1832 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1833 messing with static variables.
1835 2009-02-16 Marek Safar <marek.safar@gmail.com>
1837 A fix for bug #475965
1838 * generics.cs: Check generic parameter type after extracting from
1841 2009-02-16 Marek Safar <marek.safar@gmail.com>
1843 A fix for bug #475823
1844 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1847 2009-02-14 Marek Safar <marek.safar@gmail.com>
1849 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1850 Simplified event field definition using backing field and not
1851 field builder directly.
1853 * expression.cs (EmitLdArg): Optimize fast paths.
1855 2009-02-13 Marek Safar <marek.safar@gmail.com>
1857 A fix for bug #475327
1858 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1860 2009-02-13 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #475342
1863 * cs-parser.jay: Using 'super' instead of 'base' to call base
1864 constructor crashes compiler.
1866 2009-02-13 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #475354
1869 * expression.cs (Constantify): Add nullable types.
1871 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1873 2009-02-12 Marek Safar <marek.safar@gmail.com>
1875 A fix for bug #475246
1876 * expression.cs: More broken flowanalysis hacking needed.
1878 2009-02-12 Marek Safar <marek.safar@gmail.com>
1880 * attribute.cs: Compare only ref/out array modifiers.
1882 2009-02-11 Marek Safar <marek.safar@gmail.com>
1884 * statement.cs: Use member cache when looking for foreach members.
1886 2009-02-11 Marek Safar <marek.safar@gmail.com>
1888 * expression.cs: Don't expose internal initializer types.
1890 * statement.cs: Check also explicit conversions for goto case.
1892 2009-02-11 Marek Safar <marek.safar@gmail.com>
1894 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1896 2009-02-10 Marek Safar <marek.safar@gmail.com>
1898 * *.cs: Replace null-type with NullLiteral where appropriate.
1900 2009-02-09 Marek Safar <marek.safar@gmail.com>
1902 * expression.cs: Initializer of reference argument use temporary
1903 variable to be verifiable.
1905 * parameter.cs: Share EmitLdArg.
1907 2009-02-09 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #473559
1910 * class.cs: Fixed: Not reporting error about nested class with the
1913 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1915 Contributed under the MIT/X11 license.
1917 * generic.cs: Added VerifyVariantTypeParameters which performs new
1918 variance verification logic. The old logic, based on the spec, was
1919 wrong because the spec is full of LIES!
1921 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1923 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1926 * ecore.cs: Added calls to the new variance verification logic.
1929 * delegate.cs: Removed calls to the old variance verification logic.
1931 2009-02-06 Marek Safar <marek.safar@gmail.com>
1933 * delegate.cs: Use cached Invoke method directly.
1935 2009-02-06 Marek Safar <marek.safar@gmail.com>
1937 * expression.cs: Emit expression tree for hoisted variable access.
1939 2009-02-04 Marek Safar <marek.safar@gmail.com>
1941 * namespace.cs: Add better extension class check.
1943 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1945 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1947 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1949 This patch adds initial generic variance support to the compiler.
1950 It is contributed under the MIT/X11 license.
1952 * typemanager.cs: Modified ImplementsInterface to check variance.
1953 Added VerifyVariantTypeParameters which checks the specified type to see
1954 if it uses a variant type parameter as a type argument (which is not
1955 allowed). Added IsVariantOf which determins if the first type is a
1956 variant of the second. NOTE: This only supports reference types at
1957 the moment to conform with the current level of VM support. When the
1958 VM supports value types, this will follow step.
1960 * generic.cs: Added the Variance enum. Added a Variance property to
1961 TypeParameter and added variance support to definition phase. Added a
1962 Variance property to TypeParameterName. Also check to make sure that
1963 no variant types appear in generic method parameters.
1965 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1966 keywords if the langversion supports it.
1968 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1969 that variant types are only used in legal positions. Also added
1970 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1973 * decl.cs: Construct TypeParameter with the variance information.
1975 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1976 and ImplicitConversionStandard.
1978 * rootcontext.cs: Added new "Future" language version.
1980 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1981 type parameters are not used as type arguments in interface inheritance.
1982 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1983 parameters are not used as method return types. In MemberBase.
1984 ResolveMemberType, ensure that variant type parameters are not used
1985 as type arguments. Also call VerifyNoVariantTypeParameters on every
1986 set of parameters which are resolved.
1988 * delegate.cs: Modified Delegate.Define to ensure that variant
1989 parameters are not used as type arguments and that a contravariant
1990 parameter is not used as the return type. Also call
1991 VerifyNoVariantTypeParameters on the delegate parameters.
1993 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1994 to specify generic variance.
1996 * driver.cs: Added support for LanguageVersion.Future in the form of
1997 "-langversion:future".
1999 * generic-mcs.cs: Stubbed out new members in generic.cs.
2001 2009-02-03 Marek Safar <marek.safar@gmail.com>
2003 * class.cs, generic.cs: Emit type parameter constraints for nested
2006 2009-02-02 Marek Safar <marek.safar@gmail.com>
2008 A fix for bug #471213
2009 * class.cs: Avoid emitting backing field for abstract event fields.
2011 2009-02-01 Marek Safar <marek.safar@gmail.com>
2013 A fix for bug #359731
2014 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2017 2009-01-30 Marek Safar <marek.safar@gmail.com>
2019 A fix for bug #470767
2020 * statement.cs: Introduced BlockScopeExpression, needed when
2021 expression tree conversion has to emit scope variables.
2023 2009-01-29 Marek Safar <marek.safar@gmail.com>
2025 * class.cs: Remove duplicate CallingConvention.
2027 2009-01-29 Marek Safar <marek.safar@gmail.com>
2029 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2030 when I finally found the right naming convention.
2032 2009-01-29 Marek Safar <marek.safar@gmail.com>
2034 * cs-tokenizer.cs: Put back different open parens optimization.
2036 2009-01-28 Marek Safar <marek.safar@gmail.com>
2038 A fix for bug #470227
2039 * cs-tokenizer.cs: Remove too agressive parser optimization.
2041 2009-01-28 Marek Safar <marek.safar@gmail.com>
2043 A fix for bug #324319
2044 * class.cs: Remove too early base type resolve.
2046 2009-01-27 Marek Safar <marek.safar@gmail.com>
2048 A fix for bug #324319
2049 * ecore.cs: Explicitly type null when assigning to type argument to
2050 make pass verifier check.
2052 2009-01-27 Marek Safar <marek.safar@gmail.com>
2054 * anonymous.cs: Fixed recent regression when initializing captured
2057 2009-01-26 Marek Safar <marek.safar@gmail.com>
2059 A fix for bug #469019
2060 * anonymous.cs: Use all parent type parameters when instantiating
2061 nested generic storey.
2063 2009-01-26 Marek Safar <marek.safar@gmail.com>
2065 * expression.cs: Check for null instance methodgroup expression.
2067 2009-01-26 Marek Safar <marek.safar@gmail.com>
2069 A fix for bug #469244
2070 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2071 instance inside a conditional expression.
2073 2009-01-23 Marek Safar <marek.safar@gmail.com>
2075 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2076 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2077 GetElementType and HasElementType. IsValueType clean up.
2079 2009-01-23 Marek Safar <marek.safar@gmail.com>
2081 * nullable.cs: Use common EmitCall.
2083 * expression.cs: Emit constraint. for virtual calls only.
2085 2009-01-23 Marek Safar <marek.safar@gmail.com>
2087 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2088 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2089 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2092 2009-01-22 Jb Evain <jbevain@novell.com>
2094 * anonymous.cs: make anonymous types' ToString implementation
2095 match what csc outputs.
2097 2009-01-21 Marek Safar <marek.safar@gmail.com>
2099 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2102 2009-01-17 Marek Safar <marek.safar@gmail.com>
2104 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2107 2009-01-16 Marek Safar <marek.safar@gmail.com>
2109 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2112 2009-01-15 Marek Safar <marek.safar@gmail.com>
2114 A fix for bug #466634
2115 * statement.cs: Add reference for nested storey when only this
2118 2009-01-15 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #466474
2121 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2124 2009-01-15 Marek Safar <marek.safar@gmail.com>
2126 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2127 Fixed nested stories parent referencing process. Also fixes #463985.
2129 2009-01-06 Marek Safar <marek.safar@gmail.com>
2131 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2132 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2133 implementation. Also fixes #463108.
2135 2009-01-05 Marek Safar <marek.safar@gmail.com>
2137 A fix for bug #416109
2138 * decl.cs: Issue correct CLSAttribute warning location.
2140 2009-01-05 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #456775
2143 * attribute.cs: Use attribute owner scope when resolving attribute
2146 2009-01-05 Marek Safar <marek.safar@gmail.com>
2148 A fix for bug #457257
2149 * decl.cs: Fixed incorrect member declaring type comparison.
2151 2009-01-05 Marek Safar <marek.safar@gmail.com>
2153 A fix for bug #460896
2154 * driver.cs: Handle /RES resources as embeddable.
2156 2009-01-05 Marek Safar <marek.safar@gmail.com>
2158 A fix for bug #462515
2159 * ecore.cs: Report inacessible members upwards.
2161 2009-01-05 Marek Safar <marek.safar@gmail.com>
2163 A fix for bug #463190, #463192
2164 * decl.cs, namespace.cs: Also import internal extension classes.
2166 2009-01-04 Marek Safar <marek.safar@gmail.com>
2168 A fix for bug #463415
2169 * generic.cs: Use right index for RemoveDependentTypes.
2171 2009-01-02 Marek Safar <marek.safar@gmail.com>
2173 A fix for bug #463196
2174 * expression.cs: Fixed enum to null comparison.
2176 2009-01-02 Marek Safar <marek.safar@gmail.com>
2178 A fix for bug #463121
2179 * nullable.cs: Fixed nullable user equality operator comparison.
2181 2009-01-02 Marek Safar <marek.safar@gmail.com>
2183 A fix for bug #462950
2184 * class.cs, decl.cs: Use full explicit name when defining automatic
2185 property backing field.
2187 2009-01-02 Marek Safar <marek.safar@gmail.com>
2189 A fix for bug #462592
2190 * pending.cs: Emit type arguments for generic proxy method.
2192 2008-12-30 Marek Safar <marek.safar@gmail.com>
2194 * expression.cs (As): Mutate all type arguments.
2196 2008-12-29 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #462622
2199 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2202 2008-12-29 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #450782
2205 * ecore.cs: Consider more variables of form V.I to be fixed.
2207 2008-12-29 Marek Safar <marek.safar@gmail.com>
2209 A fix for bug #460712
2210 * typemanager.cs: Core types could be imported.
2212 2008-12-28 Marek Safar <marek.safar@gmail.com>
2214 A fix for bugs #460847, #460772, #458049, #457339, #447807
2215 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2216 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2217 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2218 user lambdas used inside query clauses.
2220 2008-12-18 Marek Safar <marek.safar@gmail.com>
2222 A fix for bug #460229
2223 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2225 2008-12-18 Marek Safar <marek.safar@gmail.com>
2227 A fix for bug #459952
2228 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2230 2008-12-18 Marek Safar <marek.safar@gmail.com>
2232 A fix for bug #459630
2233 * convert.cs: Enum to valuetype conversion is not allowed.
2235 2008-12-18 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #457087
2238 * generic.cs: Don't crash when constraint comes from type
2241 2008-12-16 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #459221
2244 * anonymous.cs, statement.cs: Delay only captured this
2247 2008-12-12 Marek Safar <marek.safar@gmail.com>
2249 A fix for bug #457489
2250 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2251 and initialization to capture scope initializers correctly.
2253 2008-12-11 Marek Safar <marek.safar@gmail.com>
2255 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2256 ParameterReference refactoring.
2258 2008-12-03 Marek Safar <marek.safar@gmail.com>
2260 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2261 to be imported from any assembly.
2263 2008-12-03 Marek Safar <marek.safar@gmail.com>
2265 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2266 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2267 from anonymous method and lambda expression.
2269 2008-12-01 Marek Safar <marek.safar@gmail.com>
2271 A fix for bug #448560
2272 * expression.cs (As): Box any generic type arguments to be
2275 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2277 Add tripwire for implicit conversion bugs
2278 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2280 (MethodGroupExpr.OverloadResolve): Add sanity check between
2281 IsApplicable and VerifyArgumentsCompat.
2282 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2284 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2286 Fix build break in System.Data_test
2287 * convert.cs (ImplicitConversionExists): Move NullLiteral
2289 (ImplicitStandardConversionExists): ... here.
2291 2008-11-28 Marek Safar <marek.safar@gmail.com>
2293 * literal.cs: Emit correctly explicit null to nullable cast.
2295 2008-11-28 Marek Safar <marek.safar@gmail.com>
2297 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2300 2008-11-28 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #449005
2303 * convert.cs, nullable.cs: Use only one implicit nullable
2306 2008-11-27 Marek Safar <marek.safar@gmail.com>
2308 * convert.cs, literal.cs: More Convert cleanup is needed.
2310 2008-11-27 Marek Safar <marek.safar@gmail.com>
2312 * decl.cs, class.cs: Fixed misleading error message.
2314 2008-11-26 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #449005
2317 * nullable.cs (EmitEquality): Disable optimization for user operator
2320 2008-11-25 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #447027
2323 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2324 with context variables stored as expression instances.
2326 2008-11-25 Marek Safar <marek.safar@gmail.com>
2328 A fix for bug #447027
2329 * delegate.cs: Fixed delegate VerifyMethod logic.
2331 2008-11-24 Marek Safar <marek.safar@gmail.com>
2333 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2336 2008-11-21 Marek Safar <marek.safar@gmail.com>
2338 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2339 member type resolve to follow normal flow, instead of random
2342 2008-11-21 Marek Safar <marek.safar@gmail.com>
2344 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2347 2008-11-21 Marek Safar <marek.safar@gmail.com>
2349 * const.cs: Emit decimal array constant as literal.
2351 2008-11-20 Marek Safar <marek.safar@gmail.com>
2353 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2355 2008-11-19 Marek Safar <marek.safar@gmail.com>
2357 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2358 into real property (saves 8 MB for corlib compilation).
2360 2008-11-19 Marek Safar <marek.safar@gmail.com>
2362 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2363 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2364 generic-mcs.cs: Small cleanup of TypeArguments.
2366 2008-11-18 Marek Safar <marek.safar@gmail.com>
2368 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2369 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2370 of ConstructedType expression, renamed to GenericTypeExpr.
2372 2008-11-17 Marek Safar <marek.safar@gmail.com>
2374 A fix for bug #445303
2375 * location.cs (IsConditionalDefined): Handle undefined global
2378 2008-11-17 Marek Safar <marek.safar@gmail.com>
2380 A fix for bug #444678
2381 * expression.cs (TryReduceConstant): Always create new constant
2384 2008-11-17 Marek Safar <marek.safar@gmail.com>
2386 A fix for bug #444673
2387 * ecore.cs: Ignore open generic types when used as generic type
2390 2008-11-17 Marek Safar <marek.safar@gmail.com>
2392 A fix for bug #445458
2393 * expression.cs, cs-parser.jay: Don't crash when an expression
2396 2008-11-17 Marek Safar <marek.safar@gmail.com>
2398 A fix for bug #445464
2399 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2400 inside unbound type.
2402 2008-11-14 Jb Evain <jbevain@novell.com>
2404 * driver.cs: ignore empty -nowarn argument such as
2405 the one in -nowarn:12,13,,.
2407 2008-11-13 Marek Safar <marek.safar@gmail.com>
2409 A fix for bug #444271
2410 * anonymous.cs: Rescan parent storeys when best candidate was
2413 2008-11-13 Marek Safar <marek.safar@gmail.com>
2415 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2416 useless UnboundTypeExpression.
2418 * attribute.cs: Do check obsolete attribute on generic types.
2420 2008-11-12 Marek Safar <marek.safar@gmail.com>
2422 A fix for bugs #425680, #400139
2423 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2426 2008-11-11 Marek Safar <marek.safar@gmail.com>
2428 A fix for bug #435747
2429 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2430 compound value types assignment. Few micro optimizations added.
2432 2008-11-10 Marek Safar <marek.safar@gmail.com>
2434 A fix for bug #442610
2435 * anonymous.cs (MutateConstructor): More SRE hacking.
2437 2008-11-10 Marek Safar <marek.safar@gmail.com>
2439 A fix for bug #442579
2440 * ecore.cs: Also initialize expanded form of a method with 1 params
2443 2008-11-06 Marek Safar <marek.safar@gmail.com>
2445 * expression.cs (UnaryMutator): Do early l-side check.
2447 2008-11-05 Miguel de Icaza <miguel@novell.com>
2449 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2450 Init, otherwise we would crash later on when checking for friend
2453 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2454 Otherwise we never get any meaningful information as to what
2457 2008-11-05 Marek Safar <marek.safar@gmail.com>
2459 A fix for bug #436318
2460 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2462 2008-11-05 Miguel de Icaza <miguel@novell.com>
2464 * namespace.cs: Turns out that it was a really bad idea to hide
2465 the errors for namespaces not found here in eval mode.
2467 * eval.cs: When we process using clauses, only enter those into
2468 the list of valid using clauses after they have been validated.
2470 The above change gives the proper semantics: it does not
2471 senselessly report the same errors with broken using statements by
2472 never storing them in the first place when they are invalid.
2474 2008-11-05 Marek Safar <marek.safar@gmail.com>
2476 A fix for bug #421839
2477 * cs-parser.jay: Remove expression from coalesce rule to force lower
2478 priority than the assignment operator.
2480 2008-11-05 Marek Safar <marek.safar@gmail.com>
2482 A fix for bug #437875
2483 * nullable.cs: Compile correctly method group operand used with null
2484 coalescing operator.
2486 2008-11-04 Marek Safar <marek.safar@gmail.com>
2488 A fix for bug #434589
2489 * expression.cs (Binary): Ignore lifted conversions when at least
2490 one operand is of reference type.
2492 2008-11-04 Marek Safar <marek.safar@gmail.com>
2494 * cs-parser.jay: Better syntax error report.
2496 2008-11-03 Marek Safar <marek.safar@gmail.com>
2498 A fix for bug #436792
2499 * cs-parser.jay: Use GetLocation to access location.
2501 2008-11-03 Marek Safar <marek.safar@gmail.com>
2503 A fix for bug #440774
2504 * cs-parser.jay: Also set current_array_type when parsing local
2507 2008-11-03 Marek Safar <marek.safar@gmail.com>
2509 A fix for bug #440785
2510 * expression.cs (As): Don't resolve self modifing expression
2513 2008-11-03 Marek Safar <marek.safar@gmail.com>
2515 A fix for bug #439447
2516 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2518 2008-11-03 Marek Safar <marek.safar@gmail.com>
2520 A fix for bug #437571
2521 * cs-parser.jay: Fixes internal error for invalid expression
2524 2008-10-17 Marek Safar <marek.safar@gmail.com>
2526 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2528 2008-10-17 Marek Safar <marek.safar@gmail.com>
2530 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2532 2008-10-17 Marek Safar <marek.safar@gmail.com>
2534 * cs-tokenizer.cs: More precise cast parsing.
2536 2008-10-16 Martin Baulig <martin@ximian.com>
2538 * anonymous.cs (AnonymousMethodStorey): Put back the
2539 `hoisted_locals' hashtable and use it in EmitType().
2541 2008-10-15 Marek Safar <marek.safar@gmail.com>
2543 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2544 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2547 2008-10-14 Marek Safar <marek.safar@gmail.com>
2549 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2551 2008-10-14 Marek Safar <marek.safar@gmail.com>
2553 * statement.cs: Mutate scope initializers.
2555 2008-10-14 Marek Safar <marek.safar@gmail.com>
2557 * expression.cs: Use typeless value for This constant.
2559 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2561 2008-10-14 Marek Safar <marek.safar@gmail.com>
2563 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2566 2008-10-13 Marek Safar <marek.safar@gmail.com>
2568 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2571 2008-10-13 Marek Safar <marek.safar@gmail.com>
2573 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2574 parser and tokenizer. Fixes many ambiguities including #433258.
2576 2008-10-10 Marek Safar <marek.safar@gmail.com>
2578 * cs-parser.jay: Fixed missing accessor recovery.
2580 2008-10-10 Marek Safar <marek.safar@gmail.com>
2582 A fix for bug #433701
2583 * expression.cs: Better error message.
2585 2008-10-10 Marek Safar <marek.safar@gmail.com>
2587 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2589 * Makefile: Disabled unused debug symbols.
2591 Also fixes: #320556, #321097, #321656, #321876, #351316
2593 2008-10-09 Miguel de Icaza <miguel@novell.com>
2595 * eval.cs: rename "<interactive>" to "{interactive}", to work
2596 around a requirement in the compiler that this be a valid
2597 filename, and in Windows it is not (433886).
2599 2008-10-09 Marek Safar <marek.safar@gmail.com>
2601 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2603 2008-10-08 Marek Safar <marek.safar@gmail.com>
2605 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2606 cs-parser.jay: Generic type declaration and type arguments cleanup.
2608 2008-10-05 Marek Safar <marek.safar@gmail.com>
2610 * cs-parser.jay: Allow parsing weird array creation construct.
2612 2008-10-05 Marek Safar <marek.safar@gmail.com>
2614 * cs-parser.jay: Conflicts reduction.
2616 2008-10-04 Marek Safar <marek.safar@gmail.com>
2618 * cs-parser.jay: Conflicts reduction.
2620 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2623 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2624 property. Add a 'count' hint about the use of the shared vector.
2625 Ensure that we don't leak out dirty bits.
2626 (UsageVector.MergeChild): Throw away information about variables
2628 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2630 2008-10-03 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #431746
2633 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2634 parameters when iterator is created.
2636 2008-10-03 Marek Safar <marek.safar@gmail.com>
2638 A fix for bug #431827
2639 * expression.cs: Fixed right based pointer arithmetic operations
2642 2008-10-03 Marek Safar <marek.safar@gmail.com>
2644 A fix for bug #353779
2645 * assign.cs, expression.cs: Fixed compound assignment conversions.
2647 2008-10-02 Marek Safar <marek.safar@gmail.com>
2649 A fix for bug #375262
2650 * statement.cs: Refactor ArrayForeach to be usable with string
2651 indexer. Optimized single dimentional arrays foreach.
2653 2008-10-02 Marek Safar <marek.safar@gmail.com>
2655 A fix for bug #431255
2656 * anonymous.cs, expression.cs: Removed broken optimization.
2658 2008-10-01 Marek Safar <marek.safar@gmail.com>
2660 * anonymous.cs: Use full type parameters of parent generic
2661 containers. Removed unnecessary AddParentStoreyReference call.
2663 2008-10-01 Marek Safar <marek.safar@gmail.com>
2665 A fix for bug #324702
2666 * class.cs: Use better shorter names for explicit interface member
2669 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2671 2008-10-01 Marek Safar <marek.safar@gmail.com>
2673 * expression.cs: Use new interface to check fixed expression.
2675 2008-10-01 Marek Safar <marek.safar@gmail.com>
2677 A fix for bug #421101
2678 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2679 interface to check for fixed fixed-buffers.
2681 2008-10-01 Marek Safar <marek.safar@gmail.com>
2683 A fix for bug #429264
2684 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2686 * delegate.cs: Removed unnecessary casts.
2688 2008-09-30 Marek Safar <marek.safar@gmail.com>
2690 A fix for bug #352151
2691 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2692 class.cs: Fixed already defined explicit interface members check.
2694 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2696 cs-tokenizer.cs: Fix typo.
2698 2008-09-28 Miguel de Icaza <miguel@novell.com>
2700 * eval.cs (InteractiveBase): The quit command now just sets a
2701 flag, instead of calling Environment.Exit(), it is milder on
2704 CompiledMethod is now in Mono.CSharp, not nested inside
2705 the Evaluator, it was inconvenient to use.
2707 2008-09-27 Miguel de Icaza <miguel@novell.com>
2709 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2710 code to be invoked without having to reparse.
2712 2008-09-27 Miguel de Icaza <miguel@novell.com>
2714 * ecore.cs: The recent changes to FieldExpr broke this as well.
2715 Fixes LINQ queries in the interactive shell.
2717 * Multiple files: indentation fixing for the Mono coding
2718 guidelines for the switch statement.
2720 * eval.cs: Make the Evaluator API thread safe.
2722 2008-09-26 Marek Safar <marek.safar@gmail.com>
2724 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2725 constructor parsing.
2727 2008-09-26 Marek Safar <marek.safar@gmail.com>
2729 A fix for bug #325326
2730 * statement.cs: Check possible mistaken empty statement using
2731 explicit blocks only.
2733 2008-09-25 Miguel de Icaza <miguel@novell.com>
2735 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2736 RootNamespace.ComputeNamespaces to update the internal list of
2737 namespaces, this is no longer done for us.
2739 (InteractiveBase): Use the Evaluator APIs instead of calling into
2742 2008-09-25 Marek Safar <marek.safar@gmail.com>
2744 A fix for bug #429264
2745 * expression.cs: Missing mutator for access to multidimensional
2748 2008-09-25 Marek Safar <marek.safar@gmail.com>
2750 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2753 * driver.cs: Missing input argument check.
2755 2008-09-25 Marek Safar <marek.safar@gmail.com>
2757 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2758 expression.cs, statement.cs, rootcontext.cs, class.cs,
2759 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2762 2008-09-24 Miguel de Icaza <miguel@novell.com>
2764 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2765 fully constructed FieldExpr, fixes the regression introduced in
2768 * ecore.cs, expression.cs: Plug back the eclass initialization as
2769 otherwise it regresses `csharp'.
2771 2008-09-24 Marek Safar <marek.safar@gmail.com>
2773 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2774 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2775 phase to resolve phase. It resolves problems with expression trees
2776 and fixes bugs #323796, #325156.
2778 2008-09-23 Marek Safar <marek.safar@gmail.com>
2780 * codegen.cs: Report better error when symbol writer is missing.
2782 2008-09-23 Marek Safar <marek.safar@gmail.com>
2784 * codegen.cs: Set .NET symbol writer.
2786 * decl.cs: Guard against null generic arguments.
2788 * report.cs: Don't report exactly same additional details.
2790 2008-09-22 Marek Safar <marek.safar@gmail.com>
2792 A fix for bug #324917
2793 * cs-parser.jay: Add missing multidimensional non-expression type
2796 2008-09-22 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #428191
2799 * anonymous.cs: Create an outer generic fields also for non-storey
2802 2008-09-22 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #378294
2805 * class.cs: Make fixed size buffers gmcs feature only.
2807 2008-09-22 Marek Safar <marek.safar@gmail.com>
2809 A fix for bug #355622, #324993
2810 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2813 2008-09-19 Marek Safar <marek.safar@gmail.com>
2815 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2818 2008-09-19 Marek Safar <marek.safar@gmail.com>
2820 A fix for bug #416110
2821 * generic.cs: Struct constraint results in default ctor and
2822 ValueType base type constraint to be set.
2824 2008-09-19 Marek Safar <marek.safar@gmail.com>
2826 A fix for bug #423791
2827 * generic.cs: Fixed params output type type-inference.
2829 2008-09-19 Marek Safar <marek.safar@gmail.com>
2831 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2833 2008-09-19 Marek Safar <marek.safar@gmail.com>
2835 * cs-tokenizer.cs: Don't break on extra partial modifier.
2837 2008-09-19 Marek Safar <marek.safar@gmail.com>
2839 A fix for bug #427592
2840 * generic.cs: Use common parameter resolve method.
2842 2008-09-18 Marek Safar <marek.safar@gmail.com>
2844 A fix for bug #414758
2845 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2848 2008-09-18 Marek Safar <marek.safar@gmail.com>
2850 * driver.cs, namespace.cs: Read types and namespaces after all
2851 requested assemblies are loaded, fixes issues with System.Core
2852 auto-reference, and #419888.
2854 2008-09-18 Marek Safar <marek.safar@gmail.com>
2856 A fix for bug #417705
2857 * cs-parser.jay: Fixed as/is operator expression split.
2859 2008-09-18 Marek Safar <marek.safar@gmail.com>
2861 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2862 Fixed expression tree representation of empty new expression and
2863 new initializer expression.
2865 2008-09-18 Miguel de Icaza <miguel@novell.com>
2867 * eval.cs: Remove warning, keep reference to driver around.
2869 * Hide fields that do not need to be public.
2871 2008-09-17 Marek Safar <marek.safar@gmail.com>
2873 A fix for bug #426385
2874 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2875 conversion for array elements.
2877 2008-09-17 Marek Safar <marek.safar@gmail.com>
2879 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2880 void parsing conflicts.
2882 2008-09-15 Marek Safar <marek.safar@gmail.com>
2884 A fix for bug #425601
2885 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2886 System.Core only when there is no custom ExtensionAttribute
2889 2008-09-15 Miguel de Icaza <miguel@novell.com>
2891 * namespace.cs: Do not report CS0246 (name
2893 2008-09-12 Marek Safar <marek.safar@gmail.com>
2895 A fix for bug #425669
2896 * generic.cs: Don't cache generic static anonymous method
2899 2008-09-12 Marek Safar <marek.safar@gmail.com>
2901 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2902 conflicting constraints.
2904 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2906 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2909 2008-09-12 Marek Safar <marek.safar@gmail.com>
2911 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2912 to null pointer conversion fixes.
2914 2008-09-11 Marek Safar <marek.safar@gmail.com>
2916 * cs-parser.jay, expression.cs: An implicitly typed local variable
2917 declarator cannot use an array initializer.
2919 2008-09-11 Marek Safar <marek.safar@gmail.com>
2921 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2923 2008-09-11 Marek Safar <marek.safar@gmail.com>
2925 * generic.cs (InflatedConstraints): Don't crash when constraints
2928 * cs-parser.jay: const_declarator is a block.
2930 * constant.cs: Check for not allowed NaN conversions.
2932 2008-09-10 Miguel de Icaza <miguel@novell.com>
2934 * driver.cs: Drop --shell argument, the compiler is no longer a
2937 * eval.cs: Move most of the code that deals with evaluation into
2938 this file and document the public API from repl.cs
2940 * repl.cs: Remove from here.
2942 2008-09-10 Marek Safar <marek.safar@gmail.com>
2944 A fix for bug #424684
2945 * generic.cs: Generic class constraints must come first.
2947 2008-09-09 Miguel de Icaza <miguel@novell.com>
2949 * cs-parser.jay: Improve error reporting for syntax errors in
2950 statements and expressions, we now report the expected tokens
2951 instead of reporting the useless "; expected".
2953 Drop the strings from the token declaration, it turns out that
2954 they did not do what I thought they did. Instead they were adding
2955 two sets of tokens to the tables.
2957 2008-09-09 Marek Safar <marek.safar@gmail.com>
2959 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2960 delegate.cs: Share special type check.
2962 2008-09-09 Marek Safar <marek.safar@gmail.com>
2964 A fix for bug #423981
2965 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2967 2008-09-09 Marek Safar <marek.safar@gmail.com>
2969 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2972 2008-09-09 Marek Safar <marek.safar@gmail.com>
2974 A fix for bugs: #324750, #335946
2975 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2976 lookup rule to determine ?-based tokens.
2978 2008-09-08 Miguel de Icaza <miguel@novell.com>
2980 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2981 expressions (like event adding or removing) end up here, so we
2982 need to treat those as statements.
2984 Add LoadAssembly method.
2986 2008-09-04 Miguel de Icaza <miguel@novell.com>
2988 * repl.cs: Add Time method.
2990 2008-09-05 Marek Safar <marek.safar@gmail.com>
2992 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2994 2008-09-05 Miguel de Icaza <miguel@novell.com>
2996 * repl.cs: Add workaround for old compilers.
2998 2008-09-04 Jb Evain <jbevain@novell.com>
3000 * repl.cs (PrettyPrint): pretty print everything that
3001 implements IDictionary, as well as IEnumerables. Also,
3002 add a quit helper property.
3004 2008-09-04 Marek Safar <marek.safar@gmail.com>
3006 * constant.cs: Better error reporting for decimal literals.
3008 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3011 2008-09-04 Marek Safar <marek.safar@gmail.com>
3012 Miguel de Icaza <miguel@novell.com>
3014 A fix for bug #422951
3015 * assign.cs (Assign.DoResolve): Perform the type conversions
3016 checks before we attempt to initialize `New' initializers.
3018 2008-09-04 Marek Safar <marek.safar@gmail.com>
3020 A fix for bug #422853
3021 * delegate.cs (DelegateCreation): Add special handling for
3022 EmptyExpression.Null instance expression which is just another
3023 hack for undecided member instance exression.
3025 2008-09-04 Marek Safar <marek.safar@gmail.com>
3027 * expression.cs, ecore.cs: Emit full expression tree for reduced
3030 2008-09-04 Marek Safar <marek.safar@gmail.com>
3032 * expression.cs (This): Guard against multi-resolving.
3034 * ecore.cs, statement.cs (Throw): Simplified.
3036 * flowanalysis.cs: Also verify event fields.
3038 2008-09-04 Miguel de Icaza <miguel@novell.com>
3040 * assign.cs (Assign.DoResolve): Perform the type conversions
3041 checks before we attempt to initialize `New' initializers.
3043 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3045 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3048 * repl.cs: Update help.
3050 2008-09-03 Miguel de Icaza <miguel@novell.com>
3052 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3053 handling of the default config handling, including the special
3054 treatment of System.Core assembly.
3056 Fixes the REPL processing for LINQ.
3058 2008-09-03 Marek Safar <marek.safar@gmail.com>
3060 A fix for bug #422507
3061 * expression.cs (UnboxCast): Add missing child expression mutator.
3063 2008-09-03 Marek Safar <marek.safar@gmail.com>
3065 * driver.cs: Don't self reference System.Core assembly.
3067 2008-09-03 Marek Safar <marek.safar@gmail.com>
3069 A fix for bug #422507
3070 * expression.cs (StringConcat): Add missing type mutator.
3072 2008-09-03 Marek Safar <marek.safar@gmail.com>
3074 * generic.cs (TypeInferenceContext): Follow equality rule for
3075 constructed type lower bound type inference.
3077 2008-09-02 Miguel de Icaza <miguel@novell.com>
3079 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3080 <dblank@cs.brynmawr.edu> which updates the cursor position on
3083 2008-09-02 Marek Safar <marek.safar@gmail.com>
3085 A fix for bug #367145
3086 * driver.cs: Fixed import of extension methods when using -noconfig
3089 2008-09-02 Marek Safar <marek.safar@gmail.com>
3091 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3092 version from non-generic implementation instead.
3094 2008-09-01 Marek Safar <marek.safar@gmail.com>
3096 A fix for bug #418908
3097 * class.cs: Use AddScopeStatement for field initializers.
3099 2008-09-01 Marek Safar <marek.safar@gmail.com>
3101 A fix for bug #415385
3102 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3104 2008-09-01 Marek Safar <marek.safar@gmail.com>
3106 A fix for bug #421736
3107 * iterators.cs: Don't crash on unreachable iterators.
3109 2008-09-01 Marek Safar <marek.safar@gmail.com>
3111 A fix for bug #421628
3112 * parameter.cs, attribute.cs: Clone also parameter attributes.
3114 2008-08-30 Miguel de Icaza <miguel@novell.com>
3116 * namespace.cs (LookupType): In EvalMode, try to replace
3117 the TypeBuilder from our cache with a Type as Reflection.Emit does
3118 not like to mix code from older assemblies emitted and new
3121 This sounds like a serious Mono bug that prevents multiple
3122 assemblies to be generated and consumed at the same time.
3124 * cs-parser.jay (push_current_class): Do not make interactive
3125 classes internal or private, make them public as we currently
3126 generate each new class in a new assembly.
3128 2008-08-29 Miguel de Icaza <miguel@novell.com>
3130 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3131 remove types that are entered into the global namespace during
3132 parsing so that we can remove them on failure.
3134 * cs-parser.jay: Parsing: we now keep track of types that are
3135 entered into global variables and queue those in case the parsing
3138 This happens in a few situations: during partial-input, we invoke
3139 the parser repeatedly for example with the string "class X", this
3140 would cause X to be registed, and we need to remove this
3141 registration so that another parse attempt later with say "class X {"
3142 would actually work.
3144 Additionally, if there is an error in the resolution phase, for
3145 example: "class X : NonExistant {}" th
3147 * cs-parser.jay: Be more precise with the errors being raised,
3148 instead of flagging all exceptions during parsing to be attributed
3149 to the parsing process, distinguish those from errors happening in
3150 the actions and hint that using -v would produce the actual
3153 * repl.cs: Do not load all compiler references on each reset,
3154 doing the partial reset takes care of this.
3156 2008-08-28 Miguel de Icaza <miguel@novell.com>
3158 * repl.cs: Add support for loading all the files from
3159 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3162 Introduce a micro-parser that is able to deambiguate on its input
3163 whether we are dealing with a compilation unit (namespace, class,
3164 interface, struct, delegate) declaration or a statement. This
3165 allows both declarations and statements to be entered.
3167 Set history size by default to 300 lines.
3169 Instead of distinguishing based on the parser.InteractiveResult,
3170 have only two cases: statements were parsed, or a compilation unit
3171 was. Always pull the Using statement additions from the
3172 compilation unit parse.
3174 * cs-tokenizer.cs: Rename tokens to better describe their intent
3175 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3177 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3178 EvalMode is used to trigger the lookup of global variables while
3179 StatementMode is used turn variable declarations into static
3182 * getline.cs: Allow history size to be set.
3184 2008-08-29 Marek Safar <marek.safar@gmail.com>
3186 A fix for bug #360755
3187 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3189 2008-08-29 Marek Safar <marek.safar@gmail.com>
3191 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3193 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3194 member name, it is too confusing
3196 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3198 * rootcontext.cs: Finally default to warning level 4.
3200 2008-08-28 Marek Safar <marek.safar@gmail.com>
3202 * class.cs (CheckBase): Ignore overloaded operators.
3204 2008-08-28 Marek Safar <marek.safar@gmail.com>
3206 A fix for bug #420830
3207 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3209 2008-08-28 Marek Safar <marek.safar@gmail.com>
3211 A fix for bug #420832
3212 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3214 2008-08-28 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #420386
3217 * nullables.cs: Fixed logic of nullable user comparison operators involving
3220 2008-08-28 Marek Safar <marek.safar@gmail.com>
3222 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3224 2008-08-27 Miguel de Icaza <miguel@novell.com>
3226 * repl.cs: Add support for aborting the running code with C-c.
3228 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3230 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3232 2008-08-27 Miguel de Icaza <miguel@novell.com>
3234 * cs-parser.jay (interactive_statement_list): A new set of rules
3235 for hosting statements that uses the "interactive_" prefix.
3237 * repl.cs: Add support for parsing `using' as a statement or as a
3238 directive. Deambiguating before passing this to the parser.
3240 We need to distinguish statement_expressions that occur at the
3241 toplevel vs those that occur embedded into expressions.
3243 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3244 that fixes the cursor key handling, and a history bug.
3246 2008-08-26 Miguel de Icaza <miguel@novell.com>
3248 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3249 limitations in Console, instead the 2.0 bootstrap libraries now
3250 include the Console bits.
3252 Also, remove the use of Nullables from getline.cs
3256 Interactive support for the C# compiler. Use gmcs --shell to
3257 enter a read-eval-print loop shell.
3259 Docs: http://www.mono-project.com/CsharpRepl
3261 * sources: include repl.cs here and getline.cs for gmcs.exe,
3262 everything else is getline.cs impaired.
3264 * Makefile: when bootstrapping pass a special flag
3265 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3266 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3267 This distinguishes those two cases.
3269 * repl.cs: Support for a read-eval-print loop. Will be soon
3270 refactored into eval support and then REPL on top of it.
3272 * ecore.cs: If a simplename lookup fails, before erroring out,
3273 if we are in EvalMode to resolve the name to a declaration in the
3276 This means that variable declarations that happened in previous
3277 classes (as repl puts every statement in a separate class) are
3278 made visible in this way.
3280 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3281 triggered an error due to the end of file being reached. This is
3282 used to do multi-line input, and notify the caller that the user
3283 needs to provide more text before a successful parse.
3285 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3286 to drive the evaluation with a custom wrapper.
3288 * driver.cs: Add support for --shell, and refactor some code to be
3291 * namespace.cs: Add support for serializing the contents of the
3292 namespaces and reloading them.
3294 * getline.cs: A managed implementation of ReadLine under
3295 X11/Apache2 license terms. Easy to embed in other applications as
3298 * namespace.cs: Add some functions to save and restore the
3301 * rootcontext.cs: New public field.
3303 * cs-tokenizer.cs: Add support for one of the possible characters
3304 we introduce into the token stream.
3306 This patch does not affect the regular tokenization process, the
3307 only performance hit would happen if there is an invalid character
3308 on the input string.
3310 * support.cs: Move isatty helper routine here.
3312 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3313 code generator for in-memory assemblies.
3315 2008-08-26 Marek Safar <marek.safar@gmail.com>
3317 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3318 parameter cannot be always used as a type.
3320 2008-08-21 Marek Safar <marek.safar@gmail.com>
3322 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3324 2008-08-21 Marek Safar <marek.safar@gmail.com>
3326 * convert.cs: Implement explicit array to IList<T> conversion.
3328 2008-08-20 Marek Safar <marek.safar@gmail.com>
3330 A fix for bug #362740
3331 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3333 2008-08-20 Marek Safar <marek.safar@gmail.com>
3335 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3336 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3337 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3338 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3339 handling to use just one type of infrastructure and deal with generics
3342 2008-07-23 Martin Baulig <martin@ximian.com>
3344 *** Merged this from trunk revision 108527 ***
3347 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3348 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3351 2008-08-15 Marek Safar <marek.safar@gmail.com>
3353 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3356 2008-08-15 Marek Safar <marek.safar@gmail.com>
3358 * delegate.cs: Fixed compiler crash when creating delegate using partial
3361 * typemanager.cs: MulticastDelegate is not a delegate.
3363 2008-08-14 Marek Safar <marek.safar@gmail.com>
3365 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3368 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3370 * cs-parser.jay (type): Allow 'var' in mcs too.
3371 (local_variable_type): Likewise.
3373 2008-08-14 Marek Safar <marek.safar@gmail.com>
3375 * driver.cs: Removed broken -noconfig variants.
3377 2008-08-14 Marek Safar <marek.safar@gmail.com>
3379 A fix for bug #417078
3380 * expression.cs: Emit correctly left side pointer operators.
3382 2008-08-13 Marek Safar <marek.safar@gmail.com>
3384 * generic.cs, lambda.cs: Inflate method generic arguments only.
3386 2008-08-12 Marek Safar <marek.safar@gmail.com>
3388 * class.cs: Fixed struct layout check regression.
3390 2008-08-12 Marek Safar <marek.safar@gmail.com>
3392 * cs-parser.jay, enum.cs: Simplified enum parsing.
3394 * decl.cs: Check all type parameters conflicts.
3396 * expression.cs, statement.cs, attribute.cs: More expression checks.
3398 2008-08-11 Marek Safar <marek.safar@gmail.com>
3400 * generic.cs: Add type inference types restriction.
3402 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3403 anonymous.cs, expression.cs: Allocate less accessor parameters.
3405 2008-08-08 Marek Safar <marek.safar@gmail.com>
3407 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3410 2008-08-08 Marek Safar <marek.safar@gmail.com>
3412 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3414 2008-08-07 Marek Safar <marek.safar@gmail.com>
3416 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3417 Also fixes #362146 and #381592.
3419 2008-08-07 Marek Safar <marek.safar@gmail.com>
3421 * ecore.cs: Reduced constant cannot be used as an attribute value.
3423 * cs-parser.jay: Base expression has to be a type.
3425 * expression.cs (Conditional): Uses ReducedExpression.
3427 2008-08-06 Marek Safar <marek.safar@gmail.com>
3429 A fix for bug #376826
3430 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3431 address of hoisted local variable or parameter cannot be taken.
3433 2008-08-05 Marek Safar <marek.safar@gmail.com>
3435 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3436 anonymous method inside checked/unchecked expression.
3438 2008-08-05 Marek Safar <marek.safar@gmail.com>
3440 * typemanager.cs (IsEqual): Guard against null.
3442 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3443 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3444 routine. Fixed few misleading conversion errors.
3446 2008-08-04 Marek Safar <marek.safar@gmail.com>
3448 * class.cs: Consider generics when checking cycles in struct layout.
3450 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3452 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3454 2008-08-04 Marek Safar <marek.safar@gmail.com>
3456 A fix for bug #414165
3457 * anonymous.cs: Use same anonymous implementation method for all anonymous
3460 2008-08-04 Marek Safar <marek.safar@gmail.com>
3462 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3465 2008-08-04 Marek Safar <marek.safar@gmail.com>
3467 * cs-parser.jay: Typeof argument has to be a type expression.
3469 * namespace.cs: Check alias and namespace definitions collisions.
3471 * class.cs, pending.cs: Moved explicit interface accessor implementation
3474 * delegate.cs, expression.cs: Verify special name invocations.
3476 2008-08-01 Marek Safar <marek.safar@gmail.com>
3478 * cs-parser.jay: Don't choke on empty generic type arguments.
3480 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3482 * expression.cs, ecore.cs: Minor expressions bugs.
3484 2008-08-01 Marek Safar <marek.safar@gmail.com>
3486 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3487 and added more error handling.
3489 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3491 * modifiers.cs, enum.cs: Fixed.
3493 2008-07-31 Jb Evain <jbevain@novell.com>
3495 * driver.cs: remove -pkg ability of smcs.
3497 2008-07-30 Marek Safar <marek.safar@gmail.com>
3499 * statement.cs (Switch): Correctly set empty default target for single
3502 2008-07-30 Marek Safar <marek.safar@gmail.com>
3504 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3505 string switch statement implementation to use string dictionary which
3506 significantly (2-8x) improves performance of generated code.
3508 2008-07-29 Marek Safar <marek.safar@gmail.com>
3510 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3511 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3513 2008-07-29 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #412595
3516 * typemanager.cs, convert.cs, expression.cs: Some types are never
3517 convertible to each other.
3519 2008-07-29 Marek Safar <marek.safar@gmail.com>
3521 * nullable.cs (CreateNullConstant): An error messages update.
3523 2008-07-29 Marek Safar <marek.safar@gmail.com>
3525 A fix for bug #412595
3526 * cfold.cs: Don't cast undefined bool constant.
3528 2008-07-29 Martin Baulig <martin@ximian.com>
3531 (SymbolWriter.Reset): New public static method.
3534 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3536 2008-07-28 Marek Safar <marek.safar@gmail.com>
3538 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3540 * expression.cs (ElementAccess): Exact size allocation.
3542 2008-07-26 Marek Safar <marek.safar@gmail.com>
3544 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3546 2008-07-25 Marek Safar <marek.safar@gmail.com>
3548 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3550 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3553 2008-07-25 Marek Safar <marek.safar@gmail.com>
3555 A fix for bug #412217
3556 * assign.cs: Mutate also assignment type.
3558 2008-07-25 Marek Safar <marek.safar@gmail.com>
3560 A fix for bug #323644
3561 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3564 2008-07-25 Marek Safar <marek.safar@gmail.com>
3566 A fix for bug #412134
3567 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3568 non-enumerable operands when overloading equality or bitwise operators.
3570 2008-07-25 Marek Safar <marek.safar@gmail.com>
3572 * anonymous.cs: Cache closed generic anonymous method delegates.
3574 2008-07-24 Marek Safar <marek.safar@gmail.com>
3576 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3577 anonymous.cs, statement.cs: Always emit anonymous method as static method
3578 when is instance free. Use nesting for nested anynomous methods blocks.
3580 2008-07-23 Marek Safar <marek.safar@gmail.com>
3582 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3585 2008-07-23 Marek Safar <marek.safar@gmail.com>
3587 * expression.cs: Removed MakeSimpleCall.
3589 2008-07-23 Marek Safar <marek.safar@gmail.com>
3591 A fix for bug #323012
3592 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3593 Base method implementing interface has to be public.
3595 2008-07-23 Marek Safar <marek.safar@gmail.com>
3597 * cs-parser.jay: Don't break on missing argument.
3599 2008-07-22 Marek Safar <marek.safar@gmail.com>
3601 A fix for bug #320993
3602 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3603 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3605 2008-07-22 Marek Safar <marek.safar@gmail.com>
3607 A fix for bug #320748
3608 * convert.cs: Implicit user operators cannot convert to interfaces
3610 2008-07-22 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #312686
3613 * driver.cs: Ignore empty assembly references.
3615 2008-07-22 Marek Safar <marek.safar@gmail.com>
3617 A fix for bug #387040
3618 * ecore.cs: Skip constrains check for an explicit implementation.
3620 2008-07-21 Marek Safar <marek.safar@gmail.com>
3622 A fix for bug #409045
3623 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3624 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3625 identifiers are file specific unless passed as input arguments.
3627 2008-07-21 Marek Safar <marek.safar@gmail.com>
3629 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3630 to emit UnmanagedMarshal data under 2.0 profile.
3632 2008-07-21 Marek Safar <marek.safar@gmail.com>
3634 A fix for bug #410369
3635 * parameter.cs: Clone correctly ParamsParameter.
3637 2008-07-21 Marek Safar <marek.safar@gmail.com>
3639 * expression.cs (Argument): Always report type for type based expressions
3642 2008-07-18 Marek Safar <marek.safar@gmail.com>
3644 A fix for bug #410666
3645 * anonymous.cs: Correctly initialize generic storey reference.
3647 2008-07-18 Marek Safar <marek.safar@gmail.com>
3649 * convert.cs: Don't box same type arguments.
3651 2008-07-18 Marek Safar <marek.safar@gmail.com>
3653 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3654 Finished missing generic type mutators.
3656 2008-07-18 Marek Safar <marek.safar@gmail.com>
3658 * iterators.cs, statement.cs: Finished statements CloneTo.
3660 2008-07-18 Marek Safar <marek.safar@gmail.com>
3662 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3664 * expression.cs: Emit optimized default value expressions in expression tree
3667 2008-07-18 Marek Safar <marek.safar@gmail.com>
3669 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3671 2008-07-17 Marek Safar <marek.safar@gmail.com>
3673 A fix for bug #367536
3674 * cs-parser.jay: Check static constructor of generic types for an access
3677 2008-07-17 Marek Safar <marek.safar@gmail.com>
3679 A fix for bug #353800
3680 * lambda.cs: Emit ret for contextual statements.
3682 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3683 up emitting redundant ret for all anonymous methods with return.
3685 2008-07-17 Marek Safar <marek.safar@gmail.com>
3687 A fix for bug #365188
3688 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3689 create anonymous method storey in unreachable block.
3691 2008-07-17 Marek Safar <marek.safar@gmail.com>
3693 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3694 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3695 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3696 statement.cs: Fixed relevant defects found by Gendarme.
3698 2008-07-17 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #325291
3701 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3702 statement.cs: Replaced IAnonymousHost with top level block flag.
3704 2008-07-17 Marek Safar <marek.safar@gmail.com>
3706 * cs-parser.jay: Clean up unused open_parens.
3708 2008-07-17 Marek Safar <marek.safar@gmail.com>
3710 * ecore.cs: Custom error message for a range variable assignment.
3712 2008-07-16 Marek Safar <marek.safar@gmail.com>
3714 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3717 2008-07-16 Marek Safar <marek.safar@gmail.com>
3719 * literal.cs: Null literal is of object type.
3721 2008-07-16 Marek Safar <marek.safar@gmail.com>
3723 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3724 expression of nullable equality comparison.
3726 2008-07-15 Marek Safar <marek.safar@gmail.com>
3728 * expression.cs(PointerArithmetic): Removed redundant assignment.
3730 2008-07-15 Marek Safar <marek.safar@gmail.com>
3732 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3734 2008-07-14 Marek Safar <marek.safar@gmail.com>
3736 A fix for bug #408361
3737 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3738 they are replaced by GetMethod.
3740 2008-07-14 Marek Safar <marek.safar@gmail.com>
3742 A fix for bug #408721 by jeremie.laval@gmail.com
3743 * expression.cs (Indirection): Implemented CloneTo.
3745 2008-07-14 Marek Safar <marek.safar@gmail.com>
3747 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3750 2008-07-14 Marek Safar <marek.safar@gmail.com>
3752 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3754 2008-07-11 Marek Safar <marek.safar@gmail.com>
3756 * linq.cs: Reset tranparent parameter counter in probing mode.
3758 2008-07-11 Marek Safar <marek.safar@gmail.com>
3760 * anonymous.cs: Mutate anonymous method type.
3762 2008-07-11 Marek Safar <marek.safar@gmail.com>
3764 * ecore.cs, anonymous.cs: Mutate field expressions.
3766 2008-07-10 Marek Safar <marek.safar@gmail.com>
3768 A fix for bug #369670
3769 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3771 2008-07-10 Marek Safar <marek.safar@gmail.com>
3773 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3775 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3778 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3779 only one '>', and finds a '>>', abort the generic lookahead.
3781 2008-07-10 Marek Safar <marek.safar@gmail.com>
3783 A fix for bug #319902
3784 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3786 2008-07-10 Marek Safar <marek.safar@gmail.com>
3788 A fix for bug #406371
3789 * statement.cs: Moved EmitSymbolInfo to Block.
3791 2008-07-09 Marek Safar <marek.safar@gmail.com>
3793 * ecore.cs: Report better error for extension method overload failures.
3795 2008-07-09 Marek Safar <marek.safar@gmail.com>
3797 * expression.cs (Is): No need to box reference values.
3799 2008-07-09 Marek Safar <marek.safar@gmail.com>
3801 * class.cs: Use event resolve context when initializing CreateEmitContext.
3803 2008-07-09 Marek Safar <marek.safar@gmail.com>
3805 A fix for bug #394436
3806 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3807 method used inside expression trees. Added more LINQ to expression tree
3810 2008-07-08 Marek Safar <marek.safar@gmail.com>
3812 A fix for bug #378189, #370577
3813 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3816 2008-07-08 Marek Safar <marek.safar@gmail.com>
3818 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3821 2008-07-08 Marek Safar <marek.safar@gmail.com>
3823 A fix for bug #406702
3824 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3826 2008-07-07 Marek Safar <marek.safar@gmail.com>
3828 A fix for bug #406648
3829 * cs-parser.jay: Report nullable use in mcs for some cases.
3831 2008-07-07 Marek Safar <marek.safar@gmail.com>
3833 * ecore.cs: Improved argument mismatch error messages.
3835 2008-07-07 Marek Safar <marek.safar@gmail.com>
3837 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3839 2008-07-07 Marek Safar <marek.safar@gmail.com>
3841 * expression.cs (TypeOf): Mutate type argument.
3843 2008-07-04 Marek Safar <marek.safar@gmail.com>
3845 * class.cs: Report missing partial modifier for correct type.
3847 2008-07-04 Marek Safar <marek.safar@gmail.com>
3849 * ecore.cs, expression.cs (VariableReference): Variable property is
3852 2008-07-04 Marek Safar <marek.safar@gmail.com>
3854 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3856 2008-07-04 Marek Safar <marek.safar@gmail.com>
3858 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3861 2008-07-04 Marek Safar <marek.safar@gmail.com>
3863 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3864 anonymous method storey to an instance method when only "this" is hoisted.
3866 2008-07-03 Marek Safar <marek.safar@gmail.com>
3868 A fix for bug #321615
3869 * expression.cs: Pointer comparisons use unsigned operator.
3871 2008-07-03 Marek Safar <marek.safar@gmail.com>
3873 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3875 2008-07-02 Marek Safar <marek.safar@gmail.com>
3877 A fix for bug #404905
3878 * class.cs: Always initialize local unsafe variables.
3880 2008-06-30 Marek Safar <marek.safar@gmail.com>
3882 A fix for bug #396987
3883 * expression.cs (NewInitialize): Clear local temporary variable for next run
3885 2008-06-27 Marek Safar <marek.safar@gmail.com>
3887 A fix for bug #401020
3888 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3890 2008-06-27 Marek Safar <marek.safar@gmail.com>
3892 A fix for bug #398319
3893 * cs-parser.jay: Implemented undocumented base access expression inside
3896 2008-06-26 Marek Safar <marek.safar@gmail.com>
3898 A fix for bug #404227
3899 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3901 2008-06-26 Marek Safar <marek.safar@gmail.com>
3903 A fix for bug #404227
3904 * convert.cs: Fixed explicit array to interface cast.
3906 2008-06-26 Marek Safar <marek.safar@gmail.com>
3908 A fix for bug #403894
3909 * delegate.cs: Mutate DelegateInvocation type.
3911 2008-06-26 Marek Safar <marek.safar@gmail.com>
3913 A fix for bug #379348
3914 * delegate.cs: Box a load of generic parameters.
3916 2008-06-26 Marek Safar <marek.safar@gmail.com>
3918 * expression.cs: Add an array creation arguments mutate.
3920 2008-06-26 Marek Safar <marek.safar@gmail.com>
3922 A fix for bug #386068
3923 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3926 2008-06-25 Marek Safar <marek.safar@gmail.com>
3928 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3931 2008-06-25 Marek Safar <marek.safar@gmail.com>
3933 A fix for bug #403518
3934 * delegate.cs: Type correctly anonymous method new invocation.
3936 2008-06-24 Marek Safar <marek.safar@gmail.com>
3938 A fix for bug #394826
3939 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3942 2008-06-24 Marek Safar <marek.safar@gmail.com>
3944 A fix for bug #394826
3945 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3948 2008-06-24 Marek Safar <marek.safar@gmail.com>
3950 * class.cs: Clone indexer parameters for localized capturing.
3952 2008-06-24 Marek Safar <marek.safar@gmail.com>
3954 A fix for bug #402379
3955 * expression.cs: Don't crash when an object initializer resolve fails.
3957 2008-06-24 Marek Safar <marek.safar@gmail.com>
3959 A fix for bug #402888
3960 * expression.cs: Mutate conditional expression.
3962 2008-06-24 Marek Safar <marek.safar@gmail.com>
3964 A fix for bug #401012
3965 * class.cs: Keep StructLayout in shared container.
3967 2008-06-24 Marek Safar <marek.safar@gmail.com>
3969 A fix for bug #400438
3970 * decl.cs, class.cs: Only properties can be automatically implemented.
3972 2008-06-24 Marek Safar <marek.safar@gmail.com>
3974 * statement.cs (ChangeToIterator): Copy also labels.
3976 2008-06-23 Marek Safar <marek.safar@gmail.com>
3978 * ecore.cs: Pass type argument details to parent extension method.
3980 2008-06-23 Marek Safar <marek.safar@gmail.com>
3982 A fix for bug #375966
3983 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3985 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3987 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3989 2008-06-22 Marek Safar <marek.safar@gmail.com>
3991 A fix for bug #394347
3992 * anonymous.cs: Cache compatible delegates as compatibility check produces
3993 a new method every time.
3995 2008-06-20 Marek Safar <marek.safar@gmail.com>
3997 * anonymous.cs: Propagate storey reference for single references.
3999 2008-06-20 Marek Safar <marek.safar@gmail.com>
4001 A fix for bug #387615
4002 * assign.cs, expression.cs: Correctly clone compound assignment.
4004 2008-06-19 Marek Safar <marek.safar@gmail.com>
4006 A fix for bug #359611, #359604
4007 * anonymous.cs: Mutate all types of hoisted parameters.
4009 2008-06-19 Marek Safar <marek.safar@gmail.com>
4011 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4012 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4013 expression.cs, codegen.cs, statement.cs
4015 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4016 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4018 ** Anonymous methods, lambda expressions rewrite **
4020 Anonymous expressions are now resolved when an explicit block is resolved
4021 and they don't require any registration procedure anymore. Further,
4022 anonymous methods are defined when explicit block is emitted which allows
4023 better control of whole process and opens possibilities for more
4024 optimizations as well as alternative to reverse whole process.
4026 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4027 process consistent and to correctly emit hoisted generic methods when they
4028 have at least 1 hoisted variable.
4030 2008-06-17 Martin Baulig <martin@ximian.com>
4032 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4034 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4035 virtual property; check it in Emit().
4036 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4038 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4040 (Indexer.Define): Likewise.
4042 2008-06-17 Marek Safar <marek.safar@gmail.com>
4044 * convert.cs: Don't use IsInterface on type arguments.
4046 * delegate.cs: DelegateInvocation uses MethodInfo.
4048 * parameter.cs: Removed IsTypeParameter.
4050 * generic-mcs.cs: More missing stuff.
4052 2008-06-16 Martin Baulig <martin@ximian.com>
4055 (Modifiers.DEBUGGER_HIDDEN): New public const.
4058 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4061 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4062 (AbstractPropertyEventMethod): Likewise.
4063 (Constructor.Emit): Likewise.
4064 (SourceMethod.SetCompilerGenerated): Removed.
4066 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4070 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4071 if we're an `IteratorHost'.
4072 (AnonymousMethodMethod..ctor): Don't set
4073 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4076 2008-06-16 Marek Safar <marek.safar@gmail.com>
4078 * statement.cs: Clean-up foreach statements.
4080 2008-06-12 Marek Safar <marek.safar@gmail.com>
4082 * class.cs: Stop using public method which should not exist
4083 (MethodBuilder.SetGenericMethodSignature).
4085 2008-06-11 Martin Baulig <martin@ximian.com>
4088 (Location.LookupFile): Add `CompilationUnit' argument; when given
4089 a relative file name, make it relative to the directory the .cs
4090 file is located in instead of using the current directory.
4092 2008-06-11 Martin Baulig <martin@ximian.com>
4095 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4096 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4097 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4098 (SourceMethod.SetCompilerGenerated): Likewise.
4100 2008-06-11 Marek Safar <marek.safar@gmail.com>
4102 * codegen.cs, driver: Only write symbol file when it's asked for.
4104 2008-06-11 Marek Safar <marek.safar@gmail.com>
4106 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4108 2008-06-10 Martin Baulig <martin@ximian.com>
4110 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4112 2008-06-09 Marek Safar <marek.safar@gmail.com>
4114 A fix for bug #316290
4115 * expression.cs: Include decimal operators in predefined table.
4117 * parameters.cs: More readonlyness.
4119 2008-06-09 Marek Safar <marek.safar@gmail.com>
4121 A fix for bug #397213
4122 * cs-parser.jay: One more missing current_local_parameters reset.
4124 2008-06-09 Marek Safar <marek.safar@gmail.com>
4126 A fix for bug #396633
4127 * class.cs: Host backing field in partial container.
4129 2008-06-09 Marek Safar <marek.safar@gmail.com>
4131 A fix for bug #397068
4132 * expression.cs: Check both operand types when predefined operator is used.
4134 2008-06-05 Martin Baulig <martin@ximian.com>
4136 Merged the `debugger-kahalo' branch.
4139 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4140 we're an iterator method.
4141 (SourceMethod): Reflect latest symbol writer changes;
4142 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4143 now `start_row' and `end_row'.
4144 (Constructor.Emit): Fix the logic whether to emit symbol information.
4146 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4150 (CompilationUnit): New public class; derives from `SourceFile'.
4151 (SourceFileEntry.DefineSymbolInfo): New public method.
4152 (SourceFileEntry.SetChecksum): New public method.
4153 (Location): Encode hidden line numbers by using `column == 255';
4154 the .ctor now accepts `column == -1' to mark a hidden line number.
4155 (Location.Hidden): New public property.
4156 (Location.CheckPoint): Add `CompilationUnit'.
4157 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4158 (Location.Push): Add `CompilationUnit compile_unit' argument.
4159 (Location.CompilationUnit): New public property.
4162 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4164 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4166 * driver.cs: `SourceFile' -> `CompilationUnit'.
4168 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4170 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4172 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4176 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4177 new symbol writer API to also pass the file.
4179 2008-06-05 Marek Safar <marek.safar@gmail.com>
4181 * statement.cs: Emit catch variable assignment using variable expression.
4183 2008-06-05 Marek Safar <marek.safar@gmail.com>
4185 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4186 with other variable types.
4188 2008-06-04 Marek Safar <marek.safar@gmail.com>
4190 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4191 GetLength method emit, it breaks resolve rules.
4193 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4194 Marek Safar <marek.safar@gmail.com>
4196 A fix for bug #395542
4197 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4200 2008-06-02 Marek Safar <marek.safar@gmail.com>
4202 A fix for bug #395287
4203 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4205 2008-05-31 Marek Safar <marek.safar@gmail.com>
4207 A fix for bug #395845
4208 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4209 non-nullable parameter type.
4211 2008-05-31 Marek Safar <marek.safar@gmail.com>
4213 * class.cs: Handle contructor initializer as a statement in top-level block.
4215 2008-05-30 Marek Safar <marek.safar@gmail.com>
4217 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4218 security attributes.
4220 2008-05-24 Marek Safar <marek.safar@gmail.com>
4222 * ecore.cs, expression.cs: Small IVariable refactoring.
4224 2008-05-22 Marek Safar <marek.safar@gmail.com>
4226 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4228 2008-05-21 Marek Safar <marek.safar@gmail.com>
4230 * cs-parser.jay: Removed redundant catch type check.
4232 2008-05-21 Marek Safar <marek.safar@gmail.com>
4234 A fix for bug #390372
4235 * nullable.cs: Set correct return type.
4237 2008-05-21 Marek Safar <marek.safar@gmail.com>
4239 A fix for bug #391062
4240 * typemanager.cs: Fixed crash when comparing null types.
4242 2008-05-21 Marek Safar <marek.safar@gmail.com>
4244 A fix for bug #391871
4245 * cs-parser.jay: Better error handling for invalid catch type.
4247 2008-05-20 Marek Safar <marek.safar@gmail.com>
4249 A fix for bug #392155
4250 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4252 2008-05-15 Marek Safar <marek.safar@gmail.com>
4254 A fix for bug #390666
4255 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4258 2008-05-15 Marek Safar <marek.safar@gmail.com>
4260 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4263 2008-05-13 Marek Safar <marek.safar@gmail.com>
4265 A fix for bug #389625
4266 * delegate.cs, generic.cs: Some progress on method group return type
4269 2008-05-13 Marek Safar <marek.safar@gmail.com>
4271 A fix for bug #378419
4272 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4274 2008-05-12 Marek Safar <marek.safar@gmail.com>
4276 * class.cs (Constructor): Added IsCompilerGenerated.
4278 2008-05-12 Marek Safar <marek.safar@gmail.com>
4280 * expression.cs: Enum binary operators can accept non-enum operand only when
4281 is implicitly convertible to underlying type.
4283 2008-05-12 Marek Safar <marek.safar@gmail.com>
4285 A fix for bug #389272
4286 * support.cs: Workaround System.InvalidOperationException for enums.
4288 2008-05-12 Marek Safar <marek.safar@gmail.com>
4290 A fix for bug #389073
4291 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4293 2008-05-10 Marek Safar <marek.safar@gmail.com>
4295 * driver.cs: Split Parse.
4297 * location.cs (LookupFile): Uses string.Empty.
4299 2008-05-07 Marek Safar <marek.safar@gmail.com>
4301 * expression.cs, parameter.cs: Small ParameterReference clean up.
4303 2008-05-07 Marek Safar <marek.safar@gmail.com>
4305 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4306 hack. Fixes #387502.
4308 2008-05-06 Martin Baulig <martin@ximian.com>
4310 * class.cs (Constructor.Emit): Fix the logic whether to emit
4313 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4316 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4317 InvalidOperationException when the iterator is before the start or
4320 2008-05-06 Marek Safar <marek.safar@gmail.com>
4322 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4323 when left is nullable type.
4325 2008-05-06 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #386628
4328 * expression.cs (LocalVariableReference): Continue in resolving when
4329 variable is not assigned.
4331 2008-05-05 Marek Safar <marek.safar@gmail.com>
4333 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4334 nullable operations.
4336 2008-05-04 Marek Safar <marek.safar@gmail.com>
4338 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4339 it saves many redundant temporary variables for nullable operations.
4341 2008-05-03 Marek Safar <marek.safar@gmail.com>
4343 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4345 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4348 * nullable.cs: Constant coalescing operator optimizations.
4350 2008-05-03 Marek Safar <marek.safar@gmail.com>
4352 * constant.cs: Use unsigned conversion for values which are unsigned only.
4354 2008-05-03 Marek Safar <marek.safar@gmail.com>
4356 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4357 coalescing operator as it should be.
4359 2008-05-02 Marek Safar <marek.safar@gmail.com>
4361 A fix for bug #371016
4362 * expression.cs: All predefined delegate operators require implicit method
4365 2008-05-02 Marek Safar <marek.safar@gmail.com>
4367 * constant.cs: Emit long constant as uint when fits the range.
4369 * convert.cs, expression.cs: Fixed few unsafe conversions.
4371 2008-05-02 Marek Safar <marek.safar@gmail.com>
4373 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4375 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4378 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4380 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4382 2008-05-01 Marek Safar <marek.safar@gmail.com>
4384 * constant.cs, literal.cs: IsLiteral property for error reporting.
4386 * ecore.cs, expression.cs: Implemented Property expression.
4388 2008-05-01 Marek Safar <marek.safar@gmail.com>
4390 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4392 * nullable.cs: Implemented nullable coalescing null operator.
4394 * ecore.cs, expression.cs: Expression trees work.
4396 2008-05-01 Marek Safar <marek.safar@gmail.com>
4398 * ecore.cs: CreateExpressionTree is finally abstract.
4400 * expression.cs, linq.cs: Updated.
4402 2008-05-01 Marek Safar <marek.safar@gmail.com>
4404 * expression.cs, ecore.cs: Block base access expression inside expression
4407 2008-05-01 Marek Safar <marek.safar@gmail.com>
4409 A fix for bug #385058
4410 * expression.cs: User-defined operator implementations always take
4411 precedence over predefined operator implementations.
4413 2008-04-30 Marek Safar <marek.safar@gmail.com>
4415 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4416 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4417 expression tree conversions.
4419 2008-04-30 Marek Safar <marek.safar@gmail.com>
4421 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4422 operators method details to Operator class.
4424 2008-04-30 Marek Safar <marek.safar@gmail.com>
4426 * anonymous.cs: Pass unsafe flags to anonymous container.
4428 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4429 inside expression tree.
4431 2008-04-29 Martin Baulig <martin@ximian.com>
4433 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4434 (Tokenizer.PopPosition): Also restore the `line'.
4436 2008-04-29 Marek Safar <marek.safar@gmail.com>
4438 * delegate.cs: Implemented Invoke expression.
4440 2008-04-29 Marek Safar <marek.safar@gmail.com>
4442 * expression.cs: Fixed equality reference comparison regression.
4444 2008-04-29 Marek Safar <marek.safar@gmail.com>
4446 * ecore.cs: Clean up EmptyCast hack.
4448 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4449 using correct conversion rules. Also fixes #383993.
4451 2008-04-28 Martin Baulig <martin@ximian.com>
4453 * class.cs (Constructor.Emit): Don't emit debugging information
4454 for generated default .ctor's.
4456 2008-04-28 Marek Safar <marek.safar@gmail.com>
4458 * convert.cs: Empty-cast ushort to int conversion.
4460 2008-04-28 Marek Safar <marek.safar@gmail.com>
4462 A fix for bug #384191
4463 * ecore.cs, expression.cs: Fixed expression cloning.
4465 2008-04-28 Marek Safar <marek.safar@gmail.com>
4467 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4469 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4471 Fix #381559, test-638.cs, test-639.cs
4472 * assign.cs (CompoundAssign.Helper): New wrapper.
4473 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4475 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4476 Pass unconverted expressions to the params array creation expression.
4477 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4478 (PropertyExpr.EmitAssign): Likewise.
4479 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4480 element if it is of kind CompoundAssign.Helper.
4481 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4482 first before anything else.
4483 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4484 (ArrayAccess.LoadArrayAndArguments): Simplify.
4486 2008-04-27 Marek Safar <marek.safar@gmail.com>
4488 * expression.cs: Fixed cloning of typeof(void).
4490 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4492 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4493 (Assign.Emit): Likewise. Move it to ...
4494 (CompoundAssign.DoResolve): ... here and ...
4495 (CompoundAssign.Emit): ... here.
4496 (EventAddOrRemove): New helper to handle += and -= on events, and
4497 avoid the use of BinaryDelegates.
4498 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4499 (EventExpr.EmitAddOrRemove): Improve.
4500 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4502 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4503 create VarExprs for 'foo.bar.var'.
4504 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4505 is a highly inappropriate name for its functionality.
4507 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4509 Simplify handling of multiple assignments
4510 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4512 (SimpleAssign): New. Class to be used for normal assignments.
4513 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4514 * expression.cs, parameter.cs, statement.cs: Likewise.
4516 2008-04-25 Marek Safar <marek.safar@gmail.com>
4518 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4519 for incompatible underlying types, more to come, uff.
4521 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4524 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4525 Handle 'leave_copy'.
4527 2008-04-25 Marek Safar <marek.safar@gmail.com>
4529 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4531 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4533 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4534 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4535 * statement.cs (While, Do, For): Allow test to have side effects.
4536 (For.DoEmit): Always emit InitStatement.
4539 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4540 Always create SideEffectConstant.
4541 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4542 of type EnumConstant.
4544 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4545 Handle 'right' being SideEffectConstant of type 'bool'.
4547 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4548 Use left.EmitBranchable instead of open coding it, so as to
4549 improve optimization opportunities.
4551 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4553 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4555 (Expression.EmitSideEffect): Document.
4557 2008-04-23 Marek Safar <marek.safar@gmail.com>
4559 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4561 2008-04-23 Marek Safar <marek.safar@gmail.com>
4563 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4565 2008-04-23 Marek Safar <marek.safar@gmail.com>
4567 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4568 conversion to expression tree.
4570 2008-04-23 Marek Safar <marek.safar@gmail.com>
4572 * ecore.cs: Removed unused expression.
4574 2008-04-22 Marek Safar <marek.safar@gmail.com>
4576 * expression.cs: Implemented NegateChecked and New expressions.
4578 2008-04-22 Marek Safar <marek.safar@gmail.com>
4580 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4582 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4585 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4586 needing final 'ret' instruction.
4588 2008-04-22 Marek Safar <marek.safar@gmail.com>
4590 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4592 2008-04-21 Marek Safar <marek.safar@gmail.com>
4594 * expression.cs: Emit ldnull and not null expression as an instance argument
4595 of static method expression calls.
4597 2008-04-21 Marek Safar <marek.safar@gmail.com>
4599 A fix for bug #378200
4600 * expression.cs: Fixed crash when creating parameterless expression tree
4603 2008-04-21 Marek Safar <marek.safar@gmail.com>
4605 A fix for bug #375297
4606 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4609 2008-04-21 Marek Safar <marek.safar@gmail.com>
4611 A fix for bug #377596
4612 * decl.cs, class.cs: Emit delegate type argument attributes.
4614 2008-04-21 Marek Safar <marek.safar@gmail.com>
4616 A fix for bug #365314
4617 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4619 2008-04-21 Marek Safar <marek.safar@gmail.com>
4621 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4624 2008-04-21 Marek Safar <marek.safar@gmail.com>
4626 * generic.cs (TypeParameter): Removed redundant location.
4628 2008-04-19 Marek Safar <marek.safar@gmail.com>
4630 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4631 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4632 FullNamedExpression in all declaration type expression, statements will come
4635 2008-04-18 Marek Safar <marek.safar@gmail.com>
4637 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4638 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4640 2008-04-18 Marek Safar <marek.safar@gmail.com>
4642 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4645 2008-04-17 Marek Safar <marek.safar@gmail.com>
4647 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4650 2008-04-17 Marek Safar <marek.safar@gmail.com>
4652 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4656 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4658 Hook up 'EmitSideEffect'
4659 * constant.cs (Constant.EmitSideEffect): New.
4660 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4661 (SideEffectConstant.EmitSideEffect): New.
4662 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4663 unconditional branch in EmitBranchable.
4664 (FieldExpr.EmitBranchable): New.
4665 * expression.cs (Unary.EmitSideEffect): New.
4666 (Binary.EmitSideEffect): New.
4667 (VariableReference.EmitSideEffect): New. Do nothing.
4669 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4671 Introduce 'EmitSideEffect'
4672 * ecore.cs (Expression.EmitSideEffect): New.
4673 (TypeCast): Rename from EmptyCast.
4675 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4676 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4677 * convert.cs, nullable.cs: Update to changes.
4679 2008-04-16 Marek Safar <marek.safar@gmail.com>
4681 * class.cs, cs-parser.jay: Early check for base types expression.
4683 2008-04-16 Marek Safar <marek.safar@gmail.com>
4685 * decl.cs (MemberName): Declare PrettyName as obsolete.
4687 2008-04-16 Marek Safar <marek.safar@gmail.com>
4689 * namespace.cs: Use MemberName comparison.
4691 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4694 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4696 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4697 (MemberName.FullyQualifiedName): New. Provides the functionality
4698 that users assume FullName would have.
4699 * ecore.cs, namespace.cs: Update to changes.
4701 * statement.cs (Using.assign): Make into ExpressionStatement.
4702 (Using.EmitPreTryBody): Simplify.
4704 2008-04-16 Marek Safar <marek.safar@gmail.com>
4706 * report.cs: ColorFormat is protected.
4708 * rootcontext.cs: Unused fields clean-up.
4710 * namespace.cs: Made UsingEntry name private.
4712 2008-04-16 Marek Safar <marek.safar@gmail.com>
4714 * cs-tokenizer.cs, location.cs: Removed unused field.
4716 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4717 Raja R Harinath <harinath@hurrynot.org>
4720 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4721 (SideEffectConstant.side_effect): Rename from 'right'.
4722 (SideEffectConstant..ctor): Normalize 'side_effect'.
4723 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4724 value of this constant.
4725 * cfold.cs: Update to changes.
4727 2008-04-15 Marek Safar <marek.safar@gmail.com>
4729 * cs-paser.jay: Removed unused variable.
4731 * driver.cs: Made Compile instance method.
4733 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4735 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4737 2008-04-15 Marek Safar <marek.safar@gmail.com>
4739 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4741 2008-04-13 Jb Evain <jbevain@novell.com>
4743 * namespace.cs: update the System.Core fullname for 2.1
4744 * driver.cs: update the list of required assemblies for 2.1.
4745 Merged from the Moonlight 2 branch.
4747 2008-04-11 Marek Safar <marek.safar@gmail.com>
4749 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4750 types and user defined operators. User operators arguments has to be checked
4751 for null value before invocation, which also means no operator is called
4752 when any argument is not convertible to unwrapped nullable type.
4754 2008-04-09 Marek Safar <marek.safar@gmail.com>
4756 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4757 of Unary expressions to follow operator overloading rules precisely.
4758 Also fixes #321794, #323794
4760 2008-04-08 Marek Safar <marek.safar@gmail.com>
4762 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4765 2008-04-08 Marek Safar <marek.safar@gmail.com>
4767 * expression.cs, ecore.cs: Implemented MemberInit expression.
4769 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4771 Fix mono/tests/exception4.cs
4772 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4773 ec.NeedReturnLabel () rather emitting a 'nop'.
4775 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4777 (TryCatch.SomeCodeFollows): Likewise.
4778 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4779 for 'break', 'continue' and 'return' statements inside a try.
4780 We're fairly sure that the generated IL stream will have more
4781 instructions textually following the try.
4782 (FlowBranchingTryCatch): Likewise.
4784 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4785 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4788 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4789 wrapper -- forward everything to CollectionForeach.
4790 (CollectionForeach.NonDisposableWrapper): New.
4791 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4792 instead of a pop + branch to end.
4794 2008-04-07 Marek Safar <marek.safar@gmail.com>
4796 A fix for bug #377485
4797 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4798 Propagate location for extension method groups. Report conversion failure at
4801 2008-04-07 Marek Safar <marek.safar@gmail.com>
4803 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4804 ListInit and Field expressions.
4806 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4808 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4809 Since $PC is always -1 inside the body of MoveNext, the fault
4811 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4812 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4813 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4815 The denouement! Fix #324708
4816 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4817 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4818 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4819 'finally' inside the finally clause.
4821 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4822 inside an iterator. Don't emit the body of the 'finally' inside
4823 the finally clause yet.
4825 Use the ResumableStatement infrastructure for MoveNext ()
4826 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4827 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4828 'old_resume_points'. Move dispatcher upfront.
4829 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4830 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4831 in an enumerator. This encodes the main fix in this patch series
4832 -- we can only jump into the first instruction of a try from the
4833 outside, but we want to emit try/finally regions in iterators and
4834 resume in the middle of them.
4836 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4838 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4839 of NeedReturnLabel here.
4841 Introduce a common point for emitting try/finally to IL
4842 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4843 features of the various subclasses, which are now driven by ...
4844 (ExceptionStatement.EmitPreTryBody): ... this and ...
4845 (ExceptionStatement.EmitTryBody): ... this and the original
4847 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4848 Remove DoEmit and update to follow above protocol.
4850 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4851 of the dispatcher are the same, skip emitting the 'switch'.
4852 * iterator.cs (Iterator.EmitDispose): Update to changes.
4854 Clean up handling of 'using' statement
4855 * statement.cs (UsingTemporary): New. Carved out of ...
4856 (Using): ... this. Simplify drastically. Handle exactly
4858 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4859 or Using as appropriate. If there are multiple variable declared,
4860 create nested Using statements.
4861 (resource_acquisition): Kill.
4863 * statement.cs (ExceptionStatement.EmitForDispose): Use
4864 EmitFinallyBody, not EmitFinally.
4866 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4867 * iterator.cs: Update to changes.
4869 Start using the ResumableStatement infrastructure
4870 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4871 (ResumableStatement.EmitForDispose): New.
4872 (ExceptionStatement): Override them.
4873 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4874 EmitForDispose to create the body of the Dispose method. Don't
4877 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4878 * statement.cs (Toplevel.AddResumePoint): ... here.
4879 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4880 * flowanalysis.cs (FlowBranchingIterator): New.
4881 * codegen.cs (EmitContext): Update to changes.
4883 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4884 (Iterator.old_resume_points): Rename from 'resume_points'.
4885 (Iterator.MoveNextStatement): Remove unused class.
4887 New infrastructure for try/finally in iterators (still unused)
4888 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4889 (FlowBranchingToplevel.AddResumePoint): Hook into
4890 ToplevelBlock.AddResumePoint.
4891 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4892 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4893 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4894 resume points and assign program-counter values.
4895 (ExceptionBlock.AddResumePoint): Collect resume points for
4896 de-muxer at the top of try block.
4897 * iterators.cs (Yield.CheckContext): Simplify.
4898 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4900 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4902 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4903 argument to an ExitStatement.
4904 (FlowBranchingException): Refactor saved origins code.
4905 * statement.cs (ExitStatement): Update to cahges.
4906 * iterator.cs (YieldBreak): Likewise.
4908 * statement.cs (ResumableStatement): New. Common base class for
4909 YieldReturn and ExceptionStatement.
4910 (ExitStatement): New. Common base class for Return and YieldBreak.
4911 (Return): Update to changes.
4912 * iterator.cs (YieldBreak): Likewise.
4913 * lambda.cs (ContextualReturn): Likewise.
4916 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4917 emit a meaningful error message.
4919 Fix #324765, #319508
4920 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4921 (VariableInfo.SetAssigned): Set it.
4922 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4923 determine if CS0219 or CS0168 is appropriate. Don't use
4924 flow-analysis information.
4925 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4926 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4927 (EmitContext.EndFlowBranching): ... this.
4929 2008-04-03 Marek Safar <marek.safar@gmail.com>
4931 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4933 2008-04-03 Marek Safar <marek.safar@gmail.com>
4935 A fix for bug #376508
4936 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4937 ImplicitConversionExists.
4939 2008-04-03 Marek Safar <marek.safar@gmail.com>
4941 * expression.cs (Binary): Added remaining binary operators to expression
4944 * nullable.cs: Optimize shift with null argument.
4946 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4948 Fix minor IL regression
4949 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4950 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4951 * cs-parser.jay (try_statement): Update to changes.
4953 * statement.cs (TryFinally.need_exc_block): Delete.
4954 (TryFinally): Update to changes.
4956 Now all ExceptionStatements are unconditional
4957 * statement.cs (CollectionForeach.DisposableWrapper): New.
4958 Extract out the try/finally code into a new wrapper.
4959 (CollectionForeach.Resolve): Use it to simplify the code.
4961 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4963 Start at simplifying ExceptionStatement semantics a bit
4964 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4965 * cs-parser.jay (try_statement): Update to changes.
4966 (opt_catch_clauses): Remove.
4967 * flowanalysis.cs: Update to changes.
4968 (FlowBranching.BranchingType.TryCatch): New.
4969 (FlowBranchingTryCatch): New.
4971 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4972 (FlowBranching.CreateBranching): Update to changes.
4973 (FlowBranchingBlock.AddSibling): Add sanity check.
4974 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4977 * iterators.cs (Iterator.MarkFinally): Remove.
4978 * statement.cs (ExceptionStatement): Update to changes.
4980 Add support for skipping over finally blocks at runtime. First
4981 in a series to fix #324708
4982 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4983 (Iterator.EmitMoveNext): Initialize it.
4984 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4985 branch over the body of the 'finally' clause.
4987 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4989 Avoid lopsided use of Foo/DoFoo names
4990 * statement.cs (ExpressionStatement.EmitFinallyBody):
4991 Rename from EmitFinally.
4992 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4993 * iterator.cs: Update to changes.
4995 2008-04-02 Marek Safar <marek.safar@gmail.com>
4997 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4998 based on UserOperatorCall. More binary nullable operators clean up.
5000 2008-04-02 Martin Baulig <martin@ximian.com>
5002 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5004 2008-04-02 Marek Safar <marek.safar@gmail.com>
5006 * nullable.cs: Merge user and empty conversions when lifting expression
5009 * expression.cs (StringConcat): Implemented expression tree representation.
5011 2008-04-01 Marek Safar <marek.safar@gmail.com>
5013 * nullable.cs: When lifting null literal and a user operator exists, no call
5016 2008-04-01 Marek Safar <marek.safar@gmail.com>
5018 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5021 2008-04-01 Marek Safar <marek.safar@gmail.com>
5023 * nullable.cs, expression.cs: Use namespace instead heavily nested
5024 monster abstract class.
5026 2008-04-01 Marek Safar <marek.safar@gmail.com>
5028 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5029 lifting of null literal and user operators. Clean up of some temporary
5032 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5034 Fix #368224, test-629.cs
5035 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5036 if it crossed an unwind-protect boundary.
5037 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5038 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5039 inside an unwind-protected region.
5040 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5041 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5042 'leave' instead of a 'br' if unwind-protected.
5043 (Iterator.EmitYieldBreak): Likewise.
5045 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5047 * driver.cs: Only define versioninfo resources if no win32 resource
5050 2008-03-28 Marek Safar <marek.safar@gmail.com>
5052 A fix for bug #372375
5053 * convert.cs: Fixed boxing of nullable types.
5055 2008-03-28 Marek Safar <marek.safar@gmail.com>
5057 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5060 2008-03-28 Marek Safar <marek.safar@gmail.com>
5062 A fix for bug #374619
5063 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5065 2008-03-27 Marek Safar <marek.safar@gmail.com>
5067 * lambda.cs: Check return type only for invocation.
5069 2008-03-27 Marek Safar <marek.safar@gmail.com>
5071 A fix for bug #374214
5072 * ecore.cs: Correctly report argument type mismatch.
5074 2008-03-27 Marek Safar <marek.safar@gmail.com>
5076 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5077 and not rely on broken IsEnum.
5079 2008-03-27 Marek Safar <marek.safar@gmail.com>
5081 * nullable.cs: New file, extracted from generic.cs.
5083 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5085 2008-03-27 Marek Safar <marek.safar@gmail.com>
5087 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5088 predefined comparison operators and null literals.
5090 * report.cs: New warning ID.
5092 2008-03-25 Marek Safar <marek.safar@gmail.com>
5094 A fix for bug #370577
5095 * lambda.cs: Check return type too.
5097 2008-03-25 Marek Safar <marek.safar@gmail.com>
5099 A fix for bug #372846
5100 * class.cs: Automatic properties can be declared as unsafe.
5102 2008-03-20 Marek Safar <marek.safar@gmail.com>
5104 * location.cs: Use string based concatenation.
5106 * expression.cs: LiftedBinaryOperator is gmcs only.
5108 2008-03-20 Marek Safar <marek.safar@gmail.com>
5110 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5111 conversions rules and expression trees.
5113 2008-03-19 Marek Safar <marek.safar@gmail.com>
5115 * delegate.cs: Use extension method source as delegate target.
5117 2008-03-19 Marek Safar <marek.safar@gmail.com>
5119 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5120 binary operations to be purely based on binary operations and optimized
5121 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5122 and other ET refactoring.
5124 * typemanager.cs: Fixed warning.
5126 2008-03-17 Marek Safar <marek.safar@gmail.com>
5128 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5130 * symbolwriter.cs: Fixed.
5132 2008-03-17 Marek Safar <marek.safar@gmail.com>
5134 * anonymous.cs, driver.cs: Reset anonymous types counters.
5136 2008-03-17 Marek Safar <marek.safar@gmail.com>
5138 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5140 * class.cs: Use fullname for all type member definitions.
5142 2008-02-19 Martin Baulig <martin@ximian.com>
5145 (IMethodData.EmitExtraSymbolInfo): New interface method.
5146 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5147 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5148 interface method here as an empty public virtual method.
5151 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5152 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5153 CodeGen.SymbolWriter.SetRealMethodName().
5155 2008-02-18 Martin Baulig <martin@ximian.com>
5158 (ScopeInfo.EmitType): Override this and emit debugging
5159 information for captured variables.
5160 (RootScopeInfo.EmitType): Override this and emit symbol
5161 information for a captured `this'.
5163 2008-02-15 Martin Baulig <martin@ximian.com>
5165 * iterators.cs: Emit debugging info.
5168 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5169 (EmitContext.OmitDebuggingInfo): New public property.
5172 (While): Override Emit() and don't emit symbol info there; do it
5173 inside DoEmit() instead.
5174 (Block.Emit): Omit symbol information while emitting the scope
5175 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5177 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5178 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5179 .ctor to make `IsIterator' work.
5181 2008-03-14 Martin Baulig <martin@ximian.com>
5183 * symbolwriter.cs: Added the new symbol writer function from the
5184 debugger's `terrania' branch; temporarily enclose them inside
5185 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5188 2008-03-14 Martin Baulig <martin@ximian.com>
5191 (SymbolWriter): Make this a public static class.
5194 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5195 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5197 2008-03-14 Marek Safar <marek.safar@gmail.com>
5199 A fix for bug #370577
5200 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5203 2008-03-14 Marek Safar <marek.safar@gmail.com>
5205 * typemanager.cs (CSharpName): Made 250 times faster.
5207 2008-03-13 Marek Safar <marek.safar@gmail.com>
5209 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5211 2008-03-12 Marek Safar <marek.safar@gmail.com>
5213 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5214 crash when predefined field does not exist.
5216 2008-03-12 Marek Safar <marek.safar@gmail.com>
5218 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5220 2008-03-12 Marek Safar <marek.safar@gmail.com>
5222 * class.cs (FixedField): Don't crash when contructors are missing.
5224 2008-03-11 Marek Safar <marek.safar@gmail.com>
5226 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5227 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5228 check internal types accessibility for internal and external types.
5229 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5231 2008-03-11 Marek Safar <marek.safar@gmail.com>
5233 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5234 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5235 attribute.cs, statement: Use corect instance of predefined types (work
5236 related to #364674).
5238 2008-03-07 Marek Safar <marek.safar@gmail.com>
5240 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5242 2008-03-07 Marek Safar <marek.safar@gmail.com>
5244 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5245 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5246 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5247 predefined types clean up, delayed predefined types members initialization
5248 (work related to #364674).
5250 2008-03-05 Marek Safar <marek.safar@gmail.com>
5252 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5254 2008-03-05 Marek Safar <marek.safar@gmail.com>
5256 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5257 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5258 predefined types clean up (work related to #364674).
5260 2008-03-04 Marek Safar <marek.safar@gmail.com>
5262 * ecore.cs: Print an error message instead of throwing exception.
5264 2008-03-04 Marek Safar <marek.safar@gmail.com>
5266 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5267 expression.cs, statement.cs: Unififed null literal representation.
5269 2008-03-03 Marek Safar <marek.safar@gmail.com>
5271 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5272 expression.cs: Refactored binary operators resolve phase and improved speed.
5273 The nullable code is still missing and won't work correctly, more fixes
5276 It also fixes #323726, #324312, #324248, and many other unreported issues.
5278 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5280 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5283 2008-02-27 Marek Safar <marek.safar@gmail.com>
5285 * ecore.cs: Clean-up and split BetterConversion.
5287 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5290 * enum.cs (EnumMember.Value): Only access 'value' if
5291 ResolveValue says it's ok.
5292 (EnumMember.DoResolveValue): Don't set prev_member.value.
5293 (Enum.GetDefinition): Reverse arguments of Equals --
5294 EnumMember.Value can return 'null'.
5296 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5298 2008-02-22 Marek Safar <marek.safar@gmail.com>
5300 * generic.cs, expression.cs: More ongoing work on expression trees.
5302 2008-02-21 Marek Safar <marek.safar@gmail.com>
5304 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5305 handle missing matches when mutiple operators exist.
5307 2008-02-20 Marek Safar <marek.safar@gmail.com>
5309 A fix for bug #363218
5310 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5313 2008-02-20 Marek Safar <marek.safar@gmail.com>
5315 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5316 update. This time to deal correctly with SideEffectConstant expression used
5317 as an argument for another constant folding.
5319 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5321 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5324 2008-02-19 Marek Safar <marek.safar@gmail.com>
5326 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5328 2008-02-19 Marek Safar <marek.safar@gmail.com>
5330 A fix for bug #328136
5331 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5332 side is a false constant, because we still need to evaluate the right-hand
5335 * statement.cs (If): Emit two types of boolean constants (simple constant,
5336 side-effect constant).
5338 2008-02-19 Marek Safar <marek.safar@gmail.com>
5340 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5342 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5345 2008-02-18 Marek Safar <marek.safar@gmail.com>
5347 A fix for bug #361457
5348 * ecore.cs (IsApplicable): Params methods have lower priority.
5350 * support.cs: Return correct parameter modifier for params types.
5352 2008-02-18 Marek Safar <marek.safar@gmail.com>
5354 * generic.cs (TypeParameter): Cache attribute target name.
5356 * support.cs: Removed unused variable.
5358 * typemanager.cs: Removed debugging leftover.
5360 * ecore.cs: Use local type instead of a property;
5362 * class.cs (VerifyMembers): Consider also parent to test whether type member
5365 * expression.cs (FullMethodDesc): Removed.
5367 * attribute.cs (IsValidArgumentType): Made static.
5369 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5371 Cleanup to be more readable.
5372 * Makefile (GMCS_PROFILE): Remove.
5373 (COMPILER_NAME): New helper.
5375 2008-02-15 Miguel de Icaza <miguel@novell.com>
5377 * cs-tokenizer.cs: if a conditional expression happens inside a
5378 (...) this also means that we do not need to de-ambiguate between
5379 an parenthesized expression and a cast.
5383 * constant.cs (SideEffectConstant): a constant value that happens
5384 to have a side effect.
5386 Fixes the build regressions introduced by the fix for #359789
5388 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5390 * expression.cs (Conditional.Emit): when emitting the ternary
5391 operator, use local variables to generate code verifiable code.
5393 The verifier cannot infer that the type on stack before the
5394 stloc.0 is executed is of type ParentB. This happens because the
5395 stack merge algorithm uses only parent types when deciding which
5396 is the common type. This is described in Part III 1.8.1.3 of ECMA
5399 This code compiled with mcs is not verifiable under MS. The MS
5400 verifier picks the first common interface of Foo and Bar, which is
5401 wrong, but doesn't use a full join type of the 2 interfaces.
5403 CSC uses a clever hack to compile such code in a verifiable
5404 way. It stores the intermediate values in a local variable with
5409 2008-02-14 Miguel de Icaza <miguel@novell.com>
5411 * expression.cs: Do not fold BitwiseAnd operators when the left
5412 side is a false constant, because we still need to evaluate the
5417 * support.cs: Instead of throwing an InternalErrorException when
5418 the position of the stream is outside the boundary of our buffer,
5419 reset the state of the reader, and restart the reading from the
5420 beginning of the file.
5422 2008-02-14 Marek Safar <marek.safar@gmail.com>
5424 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5426 2008-02-14 Marek Safar <marek.safar@gmail.com>
5428 A fix for bug #361686
5429 * decl.cs: A protected types used inside a private class which parents
5430 derives from the protected class are accessible.
5432 2008-02-13 Marek Safar <marek.safar@gmail.com>
5434 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5435 the parameterless constructor.
5437 2008-02-13 Marek Safar <marek.safar@gmail.com>
5439 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5440 lookup methods to use standard member cache when doing member lookup.
5442 2008-02-12 Marek Safar <marek.safar@gmail.com>
5444 * driver.cs: Don't report full path for referenced module as assembly error.
5446 2008-02-12 Marek Safar <marek.safar@gmail.com>
5448 * Makefile: Fixed `qh' target to work on all machines.
5450 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5451 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5452 and HasElementType with TypeManager implementation.
5454 2008-02-08 Marek Safar <marek.safar@gmail.com>
5456 A fix for bugs #325134, #359749
5457 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5458 first binds point to non-method member expression.
5460 2008-02-08 Marek Safar <marek.safar@gmail.com>
5462 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5464 2008-02-08 Marek Safar <marek.safar@gmail.com>
5466 A fix for bugs #321394, #323028
5467 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5468 Reworked naive IsAccessibleAs implementation to handle nested types.
5470 2008-02-05 Jb Evain <jbevain@novell.com>
5472 * class.cs: use generic type comparison for parameters
5475 2008-02-05 Marek Safar <marek.safar@gmail.com>
5477 A fix for bug #325372
5478 * class.cs: Use generic type comparison when testing method signatures.
5480 2008-02-05 Marek Safar <marek.safar@gmail.com>
5482 A fix for bug #357047
5483 * ecore.cs: Applied C# 3.0 changes to better conversion.
5485 2008-02-05 Marek Safar <marek.safar@gmail.com>
5487 A fix for bug #358374
5488 * cs-parser.jay: Correctly set modifiers for all constructor types.
5490 2008-02-04 Marek Safar <marek.safar@gmail.com>
5492 A fix for bug #355251
5493 * generic.cs: Added base class constraint based type inference.
5495 2008-02-01 Marek Safar <marek.safar@gmail.com>
5497 A fix for bug #357255
5498 * decl.cs: One more missing visibility check.
5500 2008-02-01 Marek Safar <marek.safar@gmail.com>
5502 * support.cs: Fixed broken return.
5504 2008-01-25 Marek Safar <marek.safar@gmail.com>
5506 * report.cs: Correctly reset warnings count after probing.
5508 2008-01-25 Martin Baulig <martin@ximian.com>
5511 (NamespaceEntry.SymbolFileID): Make this work again after
5512 MemberName.ToString() is gone.
5514 2008-01-25 Marek Safar <marek.safar@gmail.com>
5516 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5519 2008-01-25 Marek Safar <marek.safar@gmail.com>
5521 * generic.cs: Use full implicit conversion for type inference fixing.
5523 2008-01-24 Marek Safar <marek.safar@gmail.com>
5525 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5526 Fixed user operator conversions.
5528 2008-01-24 Marek Safar <marek.safar@gmail.com>
5530 * generic.cs: Do nullable type to null comparison optimization during
5533 2008-01-24 Marek Safar <marek.safar@gmail.com>
5535 A fix for bug #355163
5536 * generic.cs: Enabled l-value resolve on nullable expressions.
5538 2008-01-24 Marek Safar <marek.safar@gmail.com>
5540 A fix for bug #353986
5541 * class.cs: Ingore static ctors with parameters for any further checks.
5543 2008-01-24 Marek Safar <marek.safar@gmail.com>
5545 A fix for bug #354310
5546 * namespace.cs: Removed redundant check.
5548 2008-01-24 Marek Safar <marek.safar@gmail.com>
5550 A fix for bug #354928
5551 * expression.cs: ElementInitializers can be resolved only once.
5553 2008-01-24 Marek Safar <marek.safar@gmail.com>
5555 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5556 Condition expressions.
5558 2008-01-23 Marek Safar <marek.safar@gmail.com>
5560 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5562 2008-01-22 Marek Safar <marek.safar@gmail.com>
5564 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5567 * generic.cs: Implemented coalesce expression.
5569 2008-01-22 Marek Safar <marek.safar@gmail.com>
5571 A fix for bug #355145
5572 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5573 expression tree type inference.
5575 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5578 * expression.cs (Binary.IsUnsignedType): Fix typo.
5580 2008-01-22 Marek Safar <marek.safar@gmail.com>
5582 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5584 2008-01-22 Marek Safar <marek.safar@gmail.com>
5586 A fix for bug #355161
5587 * ecore.cs, expression.cs: Wider range of extension method supported
5590 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5592 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5593 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5596 2008-01-22 Marek Safar <marek.safar@gmail.com>
5598 A fix for bug #355148
5599 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5601 2008-01-22 Miguel de Icaza <miguel@novell.com>
5603 * expression.cs (CreateExpressionTree): Add support for or and
5604 logical or, and indent following the coding conventions.
5606 * typemanager.cs (LinqExpression): renamed from
5607 ExpressionTreeManager, for a shorter name.
5609 Use TypeManager.CoreLookupType to lookup types from our core
5610 assemblies and turn those into "Type" variables.
5612 Consumers that previously used "Namespace" and "Type" from this
5613 class should instead use the TypeExpression which is a type that
5614 is fully resolved (without involving the regular C# resolution
5617 This typically looks like this:
5619 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5620 new MemberAccess (texpr, name, type_arguments, loc)
5622 This avoids the problem in: #355178
5624 2008-01-21 Marek Safar <marek.safar@gmail.com>
5626 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5627 feature in parser only as we do in other cases.
5629 2008-01-21 Marek Safar <marek.safar@gmail.com>
5631 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5632 typemanager.cs: A refactoring of params arguments to reuse existing
5633 expressions (params -> array initializer) to emit params argument instead
5634 of specialized handling.
5635 It was required by expression tree implementation and it has other benefits
5636 as well, we now apply same optimization for params arguments as we do for
5639 2008-01-18 Marek Safar <marek.safar@gmail.com>
5641 A fix for bug #353526
5642 * generic.cs: A type inference of params arguments may not required any
5643 temporary array creation.
5645 2008-01-18 Marek Safar <marek.safar@gmail.com>
5647 A fix for bug #353534
5648 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5649 supported for delegates only.
5651 2008-01-18 Marek Safar <marek.safar@gmail.com>
5653 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5654 type for more than 1 candidates.
5656 2008-01-18 Marek Safar <marek.safar@gmail.com>
5658 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5661 2008-01-16 Marek Safar <marek.safar@gmail.com>
5663 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5664 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5665 operator) expressions.
5667 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5669 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5670 not accessed from the generated IL.
5672 2008-01-14 Marek Safar <marek.safar@gmail.com>
5674 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5675 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5676 statement.cs: The first expression tree implementation drop, mostly
5677 infrastructure work.
5679 2008-01-14 Marek Safar <marek.safar@gmail.com>
5681 * ecore.cs (IsNestedChild): Refactored.
5683 2008-01-11 Marek Safar <marek.safar@gmail.com>
5685 * lambda.cs: Don't use a cast on unknown expression statement.
5687 2008-01-10 Geoff Norton <gnorton@novell.com>
5689 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5692 2008-01-09 Marek Safar <marek.safar@gmail.com>
5694 * doc.cs: Report better /doc crash details.
5696 2008-01-09 Marek Safar <marek.safar@gmail.com>
5698 A fix for bug #352536
5699 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5701 2008-01-08 Marek Safar <marek.safar@gmail.com>
5703 A fix for bug #352287
5704 * ecore.cs, expression.cs: Do `this' access checking in all member access
5707 2008-01-08 Marek Safar <marek.safar@gmail.com>
5709 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5711 * report.cs: Reset message stacks.
5713 2008-01-08 Marek Safar <marek.safar@gmail.com>
5715 * generic.cs (InferInPhases): Correctly calculate params position.
5717 2008-01-08 Marek Safar <marek.safar@gmail.com>
5719 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5722 2008-01-07 Marek Safar <marek.safar@gmail.com>
5724 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5726 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5728 * driver.cs: Updated --help option.
5730 2008-01-07 Marek Safar <marek.safar@gmail.com>
5732 * generic.cs (InferParamsTypeArguments): Removed.
5733 (InferInPhases): Add params type inference.
5734 (LowerBoundInference): Fixed scoring mechanism.
5736 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5738 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5740 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5741 byte array for unsigned "baked" assemblies.
5743 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5745 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5746 array for assemblies that are not strongnamed.
5748 2008-01-04 Marek Safar <marek.safar@gmail.com>
5750 A fix for bug #351481
5751 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5752 declaring type for nested generic types.
5754 2008-01-04 Marek Safar <marek.safar@gmail.com>
5756 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5757 instead of ToString.
5759 2008-01-03 Marek Safar <marek.safar@gmail.com>
5761 A fix for bug #351047
5762 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5763 null and structs only when equality and inequality operators are defined
5764 either as an user-operators or predefined operators.
5766 2008-01-03 Marek Safar <marek.safar@gmail.com>
5768 A fix for bug #351047
5769 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5771 2008-01-03 Marek Safar <marek.safar@gmail.com>
5773 A fix for bug #351257
5774 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5776 2008-01-03 Marek Safar <marek.safar@gmail.com>
5778 A fix for bug #351157
5779 * class.cs (Using): Fixed yet another broken cloning.
5781 (Block): Put back more sensible default value for statements.
5783 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5785 * codegen.cs: Allow AssemblyVersion with only major version component.
5788 2007-12-29 Marek Safar <marek.safar@gmail.com>
5790 A fix for bug #324654
5791 * class.cs: Use FullName property as member name.
5793 2007-12-28 Marek Safar <marek.safar@gmail.com>
5795 A fix for bug #342117
5796 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5797 constructor constraint.
5799 2007-12-28 Marek Safar <marek.safar@gmail.com>
5801 A fix for bug #338273
5802 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5805 2007-12-28 Marek Safar <marek.safar@gmail.com>
5807 A fix for bug #350839
5808 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5810 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5812 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5815 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5817 * statement.cs: Changed some Hashtables to use HybridDictionaries
5818 instead. It was observed that some HashTables only contained a few
5819 items in the vast majority of cases. Since HybridDictionary is
5820 more efficient on small sets (<10 elements), "known_variables"
5821 from class ExplicitBlock as well as "labels" and "constants " from
5822 class Block were changed to HybridDictionaries.
5824 Atsai results: (56216kb->54987kb)
5826 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5829 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5831 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5834 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5836 * expression.cs: foreach loop to for loop, saved on allocation of
5837 enumerator (59333kb->59141kb)
5839 * statement.cs. Changed foreach loops to for loops, saved on
5840 allocation of enumerator (59141kb->59006kb)
5842 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5843 when constructed with no specified capacity. This was causing a
5844 few ArrayLists to allocate more memory than they would potentially
5845 need in the Block class and MemberCache class. Setting the
5846 ArrayLists to construct with a capacity of 1 saves some
5847 memory. (56216kb->55585kb)
5849 2007-12-27 Marek Safar <marek.safar@gmail.com>
5851 A fix for bug #347189 (2nd issue)
5852 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5855 2007-12-27 Miguel de Icaza <miguel@novell.com>
5857 * report.cs: Do not use colors if stdout and stderr are not a
5860 2007-12-27 Marek Safar <marek.safar@gmail.com>
5862 A fix for bug #346998
5863 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5866 2007-12-27 Marek Safar <marek.safar@gmail.com>
5868 A fix for bug #343465
5869 * class.cs: Explicit method name for nested types uses dots only.
5871 2007-12-27 Marek Safar <marek.safar@gmail.com>
5873 A fix for bug #343707
5874 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5876 2007-12-27 Marek Safar <marek.safar@gmail.com>
5878 * ecore.cs: Report type inference errors only when arguments count matches
5881 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5883 * expression.cs, report.cs: New warning.
5885 * typemanager.cs: Catch anonymous method type too.
5887 2007-12-23 Marek Safar <marek.safar@gmail.com>
5889 A fix for bug #346379
5890 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5892 2007-12-23 Marek Safar <marek.safar@gmail.com>
5894 A fix for bug #347359
5895 * expression.cs (Invocation): Don't resolve already resolved expression.
5897 2007-12-23 Marek Safar <marek.safar@gmail.com>
5899 A fix for bug #347189
5900 * class.cs (FixedField): Use non-dependent code only in the define phase.
5902 2007-12-23 Marek Safar <marek.safar@gmail.com>
5904 A fix for bug #348076
5905 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5907 2007-12-22 Marek Safar <marek.safar@gmail.com>
5909 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5910 discovered extension methods.
5912 2007-12-22 Marek Safar <marek.safar@gmail.com>
5914 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5917 2007-12-21 Miguel de Icaza <miguel@novell.com>
5919 * report.cs (ErrorMessage): Add support for using colors on
5920 terminals that support it.
5922 2007-12-21 Marek Safar <marek.safar@gmail.com>
5924 * ecore.cs: Use information about expanded params for error reporting.
5926 2007-12-21 Marek Safar <marek.safar@gmail.com>
5928 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5929 and logic for params overloads.
5931 2007-12-15 Miguel de Icaza <miguel@novell.com>
5933 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5934 as this is also created from the parser. Fixes #349034
5936 2007-12-12 Miguel de Icaza <miguel@novell.com>
5938 * statement.cs (Throw.CloneTo): it is valid to have empty
5939 expressions for throw.
5941 2007-12-03 Marek Safar <marek.safar@gmail.com>
5943 * cs-parser.jay: Set delegate constraint parsing region correctly.
5945 2007-12-03 Marek Safar <marek.safar@gmail.com>
5947 A fix for bug #345467
5948 * typemanager.cs (IsEqual): Compare generic parameters position only.
5950 2007-11-28 Marek Safar <marek.safar@gmail.com>
5952 * expression.cs (BaseAccess): Type arguments can be null.
5954 2007-11-27 Raja R Harinath <harinath@gmail.com>
5956 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5957 consistent even when an error has occured.
5958 (Switch.Resolve): Likewise.
5960 2007-11-22 Marek Safar <marek.safar@gmail.com>
5962 A fix for bug #334505
5963 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5966 2007-11-22 Marek Safar <marek.safar@gmail.com>
5968 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5969 refactorings required to resolve extension methods correctly when mixing
5970 generics and non-generics members.
5972 2007-11-20 Marek Safar <marek.safar@gmail.com>
5974 A fix for bug #342584
5975 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5978 2007-11-19 Marek Safar <marek.safar@gmail.com>
5980 A fix for bug #342512
5981 * delegate.cs: Use delegate argument expression when is available. Don't
5982 emit virtual call when class is sealed.
5984 2007-11-16 Marek Safar <marek.safar@gmail.com>
5986 A fix for bug #325423
5987 * assign.cs (FieldInitializer): Use resolved expression for emit.
5989 * class.cs: Print less confusing error message.
5991 2007-11-16 Marek Safar <marek.safar@gmail.com>
5993 * cs-tokenizer.cs: Removed GMCS ifdefs.
5995 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5998 * cs-parser.jay: Disabled nullable check.
6000 * generic-mcs: Copied more generic stuff.
6002 2007-11-16 Marek Safar <marek.safar@gmail.com>
6004 * gcs-parser.jay: Merged to cs-parser.jay.
6006 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6007 * *.csproj, *.sources: Updated to use only jay parser file.
6009 2007-11-16 Marek Safar <marek.safar@gmail.com>
6011 * gcs-parser.jay: Added nullable and default expression feature checks.
6013 2007-11-16 Marek Safar <marek.safar@gmail.com>
6015 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6016 it fixes many TODOs and hidden bugs.
6018 * expression: Removed duplicate error check.
6020 2007-11-15 Marek Safar <marek.safar@gmail.com>
6022 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6023 implicitly type local variable only when it is used in a declaration.
6025 2007-11-15 Marek Safar <marek.safar@gmail.com>
6027 * attribute.cs: Use CS0612 for empty strings.
6029 2007-11-14 Marek Safar <marek.safar@gmail.com>
6031 * lambda.cs, statement.cs: Contextual return may act as a statement.
6033 2007-11-14 Marek Safar <marek.safar@gmail.com>
6035 A fix for a regression cause by #324222
6036 * class.cs: Don't report unused even when it implements an interface.
6038 2007-11-13 Marek Safar <marek.safar@gmail.com>
6040 A fix for bug #341205
6041 * ecore.cs, expression.cs: Method group expression cannot do static
6042 method access with an instance reference check before overloading takes
6045 2007-11-13 Marek Safar <marek.safar@gmail.com>
6047 A fix for bug #325359
6048 * class.cs: Use predictable name for automatically generated property.
6050 2007-11-12 Marek Safar <marek.safar@gmail.com>
6052 A fix for bug #324996
6053 * expression.cs (Is): Handle case where D is nullable and T is not
6056 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6058 2007-11-12 Marek Safar <marek.safar@gmail.com>
6060 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6061 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6062 Flush small error reporting changes.
6064 2007-11-09 Marek Safar <marek.safar@gmail.com>
6066 A fix for bug #324996
6067 * expression.cs: Rewrote Is expression implementation to work with
6068 generics, nullable types, anonymous method. A const result expression
6069 uses existing infrastructure instead of custom not fully-featured one.
6071 2007-11-08 Marek Safar <marek.safar@gmail.com>
6073 A fix for bug #340202
6074 * class.cs: Consider generics for volatile field.
6076 2007-11-08 Marek Safar <marek.safar@gmail.com>
6078 A fix for bug #335594
6079 * expression.cs: Use conversion rules when handling string addition.
6081 2007-11-07 Marek Safar <marek.safar@gmail.com>
6083 A fix for bug #336651
6084 * expression.cs: Fixed a crash when probing is on.
6086 2007-11-07 Marek Safar <marek.safar@gmail.com>
6088 A fix for bug #324242
6089 * covert.cs: Added a conversion from any nullable-type with an
6090 underlying enum-type to the type System.Enum.
6092 2007-11-07 Marek Safar <marek.safar@gmail.com>
6094 A fix for bug #324222
6095 * class.cs: Report all non-used event fields.
6097 2007-11-07 Marek Safar <marek.safar@gmail.com>
6099 A fix for bug #325161
6100 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6101 qualifier for generic types.
6103 2007-11-07 Marek Safar <marek.safar@gmail.com>
6105 A fix for bug #322971
6106 * expression.cs, ecore.cs: Added intermediate result value check for
6109 2007-11-07 Marek Safar <marek.safar@gmail.com>
6111 A fix for bug #324754
6112 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6113 when it was requested.
6115 2007-11-07 Marek Safar <marek.safar@gmail.com>
6117 A fix for bug #325101
6118 * expression.cs: Do type not value comparison for `is' expression.
6120 2007-11-07 Marek Safar <marek.safar@gmail.com>
6122 A fix for bug #320236
6123 * convert.cs: Don't apply user conversion on underlying target type.
6125 2007-11-06 Marek Safar <marek.safar@gmail.com>
6127 * expression.cs: Don't use unresolved expression for error reporting.
6129 2007-11-06 Marek Safar <marek.safar@gmail.com>
6131 A fix for bugs #337712, #324490
6132 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6133 overloading resolution too.
6135 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6136 the process consistent and more robust.
6138 * expression.cs, linq.cs, report.cs: Update.
6140 2007-11-02 Marek Safar <marek.safar@gmail.com>
6142 A fix for bug #332909
6143 * attribute.cs: Resolve attributes in correct context using error
6146 * rootcontext.cs: Define Obsolete attribute members as core members.
6148 2007-11-02 Marek Safar <marek.safar@gmail.com>
6150 * statement.cs: Removed unused methods.
6152 2007-10-31 Wade Berrier <wberrier@novell.com>
6154 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6155 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6158 2007-10-31 Marek Safar <marek.safar@gmail.com>
6160 A fix for bug #338102
6161 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6162 methods registered as non-generics.
6164 2007-10-31 Marek Safar <marek.safar@gmail.com>
6166 A fix for bugs #337712, #324490
6167 * delegate.cs: Delegate covariance and contravariance is not allowed for
6170 2007-10-31 Marek Safar <marek.safar@gmail.com>
6172 A fix for bug #337719
6173 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6176 2007-10-30 Marek Safar <marek.safar@gmail.com>
6178 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6180 2007-10-29 Marek Safar <marek.safar@gmail.com>
6182 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6185 2007-10-29 Raja R Harinath <rharinath@novell.com>
6187 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6189 2007-10-29 Marek Safar <marek.safar@gmail.com>
6191 A fix for bug #334652
6192 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6193 extension methods when we have not found the best candidate in normal
6196 2007-10-27 Marek Safar <marek.safar@gmail.com>
6198 * AssemblyInfo.cs: Keep up-to-date.
6200 2007-10-27 Marek Safar <marek.safar@gmail.com>
6202 * Makefile: Fixed generics compiler name.
6204 2007-10-27 Marek Safar <marek.safar@gmail.com>
6206 * lambda.test: removed, lambda parsing is done differently.
6208 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6210 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6212 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6214 2007-10-27 Marek Safar <marek.safar@gmail.com>
6216 * Makefile, *.sources : All C# compilers are in mcs folder.
6218 * *.cs: Use existing 2_1 define for smcs.
6220 2007-10-26 Marek Safar <marek.safar@gmail.com>
6222 A fix for bug #335847
6223 * assign.cs, expression.cs: Couple of changes to avoid creating a
6224 temporary variable for each object initializer assignment statement. It
6225 simplifies struct initialization too, otherwise two temporary variables
6227 Implemented optimization of redundant default element initializers.
6229 2007-10-25 Marek Safar <marek.safar@gmail.com>
6231 A fix for bug #336766
6232 * expression.cs (Class.CheckBase): Use generic name when method is
6235 2007-10-25 Marek Safar <marek.safar@gmail.com>
6237 A fix for bug #334737
6238 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6239 variable and not variable argument for prepared copies.
6241 2007-10-24 Marek Safar <marek.safar@gmail.com>
6243 A fix for bug #325110
6244 * class.cs, expression.cs, attribute.cs: Use open generic method when
6245 checking conditional attribute.
6247 2007-10-24 Marek Safar <marek.safar@gmail.com>
6249 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6250 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6251 FeatureIsNotAvailable.
6253 2007-10-24 Marek Safar <marek.safar@gmail.com>
6255 ** C# 3.0 Partial methods
6257 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6258 methods support. Because of member cache issue with generics only
6259 non-generics partial methods are fully supported.
6261 2007-10-23 Marek Safar <marek.safar@gmail.com>
6263 * class.cs, decl.cs: Rewrote member overloads check to cope with
6264 generics and to use member cache for member checking. It also improves
6265 performance and fixes remaining overloads issues.
6267 2007-10-20 Marek Safar <marek.safar@gmail.com>
6269 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6270 roottypes.cs, typemanager.cs:
6272 A member cache creation logic changed to add members immediately and
6273 not rely on fallback. The member cache is now only prefered way
6274 how to access and find type declaration members. It saves 5 MB of memory
6275 during MWF compilation and makes code ready for more optimizations and
6276 clean-ups, it's also a pre-requirement for partial methods.
6278 2007-10-18 Raja R Harinath <harinath@gmail.com>
6280 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6281 handling for generic parameters.
6283 2007-10-15 Marek Safar <marek.safar@gmail.com>
6285 * class.cs (FixedField): Removed redundant volatile check.
6287 2007-10-15 Marek Safar <marek.safar@gmail.com>
6289 * class.cs, decl.cs: Fixed overload members verification to do only one
6290 check per possible collision.
6292 2007-10-13 Marek Safar <marek.safar@gmail.com>
6294 A fix for bug #325478
6295 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6296 and create only one disposable flags container.
6298 2007-10-12 Marek Safar <marek.safar@gmail.com>
6300 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6301 * statement.cs (Fixed): Fixed variables cloning.
6303 2007-10-12 Marek Safar <marek.safar@gmail.com>
6305 A fix for bug #333342
6306 * class.cs (EventField): Don't mark value type event as synchronized.
6308 2007-10-12 Marek Safar <marek.safar@gmail.com>
6310 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6311 inference to identify best candidate method correctly.
6312 (ProperyExpr): A range variable is read only and cannot be modified.
6314 2007-10-11 Marek Safar <marek.safar@gmail.com>
6316 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6317 logic to identify best candidate method correctly.
6319 2007-10-11 Marek Safar <marek.safar@gmail.com>
6321 * location.cs (Equals, GetHashCode): Removed.
6323 2007-10-11 Marek Safar <marek.safar@gmail.com>
6325 * report.cs: Implemented message recorder. It is used mainly for lambda
6326 expressions to capture otherwise swallowed error messages.
6328 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6330 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6332 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6334 * expression.cs (MemberAccess): Always report lookup failure.
6336 * location.cs: Implemented Equals, GetHashCode.
6338 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6340 2007-10-10 Jb Evain <jbevain@novell.com>
6342 * codegen.cs: re-enable assembly version check.
6344 2007-10-09 Marek Safar <marek.safar@gmail.com>
6346 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6349 * namespace.cs (UsingAlias): Do correct version check.
6351 2007-10-08 Marek Safar <marek.safar@gmail.com>
6353 * expresison.cs, ecore.cs: Issue extension method error message when
6356 * rootcontext.cs: Added ISO_2 compiler mode option.
6358 2007-10-08 Marek Safar <marek.safar@gmail.com>
6360 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6363 2007-10-08 Marek Safar <marek.safar@gmail.com>
6365 * attribute.cs (GetString, GetBoolean): Work with both literal and
6368 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6369 Moved method overload specific methods to MethodGroupExpr.
6371 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6372 it should be less memory consuming.
6374 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6376 * codegen.cs: remove the assembly version check until the buildbot is
6379 2007-10-07 Jb Evain <jbevain@novell.com>
6381 * attribute.cs (Attribute.GetString): if the value
6382 expression is a StringConstant, return its string value.
6384 2007-10-07 Jb Evain <jbevain@novell.com>
6386 * typemanager.cs: add `assembly_version_attribute_type`.
6387 * codegen.cs: on attribute emission, check that the
6388 AssemblyVersionAttribute doesn't overflow.
6390 2007-10-05 Marek Safar <marek.safar@gmail.com>
6392 A fix for bug #324677
6393 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6394 parent container of a scope container with currently resolved one.
6396 2007-10-05 Marek Safar <marek.safar@gmail.com>
6398 A fix for bug #325534
6399 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6402 2007-10-05 Marek Safar <marek.safar@gmail.com>
6404 A fix for bug #327504
6405 * class.cs (Operator.Define): Refactored implicit and explicit user
6406 operator conversion rules.
6408 2007-10-05 Marek Safar <marek.safar@gmail.com>
6410 A fix for bug #327520
6411 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6413 2007-10-04 Marek Safar <marek.safar@gmail.com>
6415 A fix for bug #328022
6416 * class.cs (MethodData.Define): Use correct method to check whether
6417 a method implementents an accessor.
6419 2007-10-04 Marek Safar <marek.safar@gmail.com>
6421 A fix for bug #330069
6422 * statement.cs (Fixed.Resolve): Read the first array element only when
6423 an array is instantiated.
6425 2007-10-04 Marek Safar <marek.safar@gmail.com>
6427 * expression.cs, assign.cs, generics.cs: Print correct operator when
6428 compound assignment is used.
6430 2007-10-04 Marek Safar <marek.safar@gmail.com>
6432 A fix for bug #325841
6433 * expression.cs (ArrayAccess): Use full argument cloning only for
6434 string compound concatenation.
6436 2007-10-03 Marek Safar <marek.safar@gmail.com>
6438 A fix for bug #328774
6439 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6441 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6444 2007-10-03 Raja R Harinath <rharinath@novell.com>
6447 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6448 Event accessibility checks here. Remove some bogus code that
6449 accidently made GenericMethods work.
6450 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6452 2007-09-25 Marek Safar <marek.safar@gmail.com>
6454 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6456 * statement.cs (Block): Refactored AddVariable to allow error handling
6459 * generic.cs: New stub.
6461 2007-09-23 Marek Safar <marek.safar@gmail.com>
6463 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6466 2007-09-17 Marek Safar <marek.safar@gmail.com>
6468 * class.cs: Use partial container to record whether any partial part
6469 contains static field initializer and therefore default contructor has
6472 2007-09-14 Marek Safar <marek.safar@gmail.com>
6474 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6475 mono-list when only one of two partial parts has defined accessibility
6478 2007-09-14 Marek Safar <marek.safar@gmail.com>
6480 A fix for bug #82845
6482 * class.cs (TypeContainer): Set correct resolve context for all field
6485 2007-09-13 Marek Safar <marek.safar@gmail.com>
6487 * assign.cs: Fixed a crash when field is resolved twice with an error.
6489 * codegen.cs: Changed InFieldInitializer to be flag.
6491 * anonymous.cs, ecore.cs, expression.cs: Update after
6492 IsInFieldInitializer rename.
6494 * const.cs: Removed unused parameter.
6496 * class.cs: Changed the way how we resolve and emit field initializers.
6497 The field initilizers have to have access to contructor block to emit
6498 compiler generated code.
6500 2007-09-13 Marek Safar <marek.safar@gmail.com>
6502 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6503 generics use TypeContainer instead.
6505 2007-09-12 Marek Safar <marek.safar@gmail.com>
6507 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6509 * lambda.cs (ResolveParameters): Use more powerful
6510 InflateGenericArgument.
6512 * parameters.cs: Better exception message.
6514 2007-09-10 Marek Safar <marek.safar@gmail.com>
6516 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6517 correct expression block type.
6519 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6521 * expression.cs (Invocation): Extracted method group resolve to
6524 2007-09-07 Marek Safar <marek.safar@gmail.com>
6526 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6527 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6529 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6530 generic extension methods.
6532 2007-09-06 Marek Safar <marek.safar@gmail.com>
6534 A fix for bug #82676 (Do I get it right now?)
6535 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6536 object before a standard conversion is applied.
6538 2007-09-06 Marek Safar <marek.safar@gmail.com>
6540 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6543 2007-09-05 Marek Safar <marek.safar@gmail.com>
6545 A fix for bug #82676
6546 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6547 non-generic interface types.
6549 2007-09-05 Marek Safar <marek.safar@gmail.com>
6551 A fix for bug #82690
6552 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6554 2007-09-05 Marek Safar <marek.safar@gmail.com>
6556 A fix for bug #82571
6557 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6558 modifier for container based methods.
6560 2007-09-05 Marek Safar <marek.safar@gmail.com>
6562 A fix for bug #82676
6563 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6564 any interface-type T means to any of interface type T.
6566 2007-09-04 Marek Safar <marek.safar@gmail.com>
6568 * namespace.cs: We have 2 versions of System.Core assembly.
6570 2007-09-04 Marek Safar <marek.safar@gmail.com>
6572 A fix for bug #82652
6573 * class.cs (Class.GetClassBases): Compare types and not expressions.
6575 2007-09-04 Marek Safar <marek.safar@gmail.com>
6577 A fix for bug #82620
6578 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6579 actually never worked before.
6580 (IndexerAccess): Emit prepared arguments before they are modified.
6582 2007-09-04 Marek Safar <marek.safar@gmail.com>
6584 A fix for bug #82563
6585 * assign.cs: Revert wrong fix.
6587 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6589 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6590 Instead of ldelema/stdind we have to use temporary variables to handle
6591 cases like String.Concat (params string[]).
6593 2007-08-31 Marek Safar <marek.safar@gmail.com>
6595 * class.cs: EmitAttributes to Emit rename.
6597 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6599 (MemberCore.HasClsCompliantAttribute): Don't depend on
6600 GetClsCompliantAttributeValue execution.
6602 2007-08-31 Marek Safar <marek.safar@gmail.com>
6604 * anonymous.cs: Use shorter type prefix.
6606 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6609 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6610 variables when probing is on.
6612 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6613 unresolved variables.
6614 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6615 handle transparent identifiers.
6617 2007-08-26 Marek Safar <marek.safar@gmail.com>
6619 * attribute.cs (IsClsCompliant): Add nullable types test.
6621 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6623 * doc.cs : catch other types of exception than XmlException to
6624 report CS1570. Fixed bug #82565.
6626 2007-08-23 Marek Safar <marek.safar@gmail.com>
6628 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6629 The number of delegate parameters has to match.
6630 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6633 2007-08-21 Marek Safar <marek.safar@gmail.com>
6635 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6636 to fix problem with private arguments.
6638 2007-08-20 Marek Safar <marek.safar@gmail.com>
6640 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6642 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6644 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6645 empty. Add cloning suport.
6647 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6649 2007-08-20 Marek Safar <marek.safar@gmail.com>
6651 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6652 to create EmptyCast. It handles EmptyConstantCast specialization for
6655 2007-08-18 Marek Safar <marek.safar@gmail.com>
6657 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6658 (EmitArrayArgument): One routine for array arguments.
6659 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6661 2007-08-17 Marek Safar <marek.safar@gmail.com>
6663 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6665 2007-08-17 Marek Safar <marek.safar@gmail.com>
6667 * anonymous.cs: MemberLookupFinal update.
6669 * class.cs (ConstructorInitializer): Is expression based.
6671 * delegate.cs: MethodGroupExpr update.
6673 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6675 (Error_MemberLookupFailed): Customizable error override.
6676 (MethodGroupExpr): Keep queried type for later usage.
6677 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6680 * expression.cs: Error_MemberLookupFailed refactoring.
6681 (New.DoResolve): Resolve as much as possible.
6682 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6683 customization for invalid member types.
6685 * statement.cs: MethodGroupExpr update.
6687 2007-08-16 Marek Safar <marek.safar@gmail.com>
6689 * modifier.cs (Check): Check all modifiers and not only accessibility
6692 2007-08-16 Marek Safar <marek.safar@gmail.com>
6694 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6695 type and not an expression.
6697 2007-08-16 Marek Safar <marek.safar@gmail.com>
6699 * statement.cs (Catch.Clone): Type and variable can be null.
6701 2007-08-16 Marek Safar <marek.safar@gmail.com>
6703 A fix for bug #81979
6704 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6705 I am really not sure whether this is the best fix.
6707 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6710 2007-08-14 Marek Safar <marek.safar@gmail.com>
6712 ** C# 3.0 Object and collection initializers (major re-write)
6714 * assign.cs (DoResolve): Initializers are not assign related.
6716 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6717 used during collection or object initialization.
6719 * expression.cs (Error_InvalidArguments): Add initializers specific
6720 messages. More will come later because it requires some general
6722 (New.DoResolve): Better error handling for unsafe types.
6723 (EmptyExpressionStatement): New class.
6724 (ElementInitializer): An object initializer expression.
6725 (CollectionElementInitializer): A collection initializer expression.
6726 (CollectionOrObjectInitializers): A block of object or collection
6728 (NewInitialize): New expression with element/object initializers.
6730 * statement.cs: Reverted object/collection initializer hacks.
6732 * typemanager.cs (CSharpName): Filter __arglist type.
6734 2007-08-09 Marek Safar <marek.safar@gmail.com>
6736 ** C# 3.0 Anonymous Types (update to the latest standard)
6738 * expression.cs (Binary.ResolveOperator): Threat all null based types
6740 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6741 (AnonymousTypeParameter): Updated.
6743 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6744 (AnonymousTypeClass): New anonymous type container.
6746 * class.cs (AddField): Return operation result.
6748 * generic.cs: Another empty TypeArguments overload.
6750 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6751 are stored at top of normal hierarchy.
6753 * typemanager.cs (CSharpName): Filter anonymous types.
6755 2007-08-09 Marek Safar <marek.safar@gmail.com>
6757 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6758 as single Concat call. How could we miss that :-(
6760 2007-08-08 Marek Safar <marek.safar@gmail.com>
6762 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6764 2007-08-07 Miguel de Icaza <miguel@novell.com>
6766 * expression.cs: Fix the previous commit, the creation of the
6767 arguments array list needs also to be conditional on the arguments
6770 * class.cs: Add a little bit of help to help narrow down problems.
6772 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6773 not try to copy in that case.
6775 * driver.cs: When building SMCS, include a new different set of
6776 default assemblies here. Do this here so we can control whether
6777 to include the default assemblies with /noconfig.
6779 2007-08-03 Marek Safar <marek.safar@gmail.com>
6781 A fix for bug #81979
6782 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6785 2007-08-03 Marek Safar <marek.safar@gmail.com>
6787 A fix for bug #82300
6789 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6790 we are in probing scope.
6792 2007-08-03 Marek Safar <marek.safar@gmail.com>
6794 A fix for bug #82301
6796 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6797 (Statement.CloneTo): Clone and not map children blocks.
6799 2007-08-03 Marek Safar <marek.safar@gmail.com>
6801 A fix for bug #82299
6803 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6806 * statement.cs (Statement.CloneTo): Clone variables before statements
6807 to allow remaping of local variables.
6809 2007-08-03 Marek Safar <marek.safar@gmail.com>
6811 A fix for bug #82296
6814 * report.cs: Log crash details for future clone problems.
6816 * statement.cs (Return.Clone): Don't clone non-existent expression.
6818 2007-08-03 Raja R Harinath <harinath@gmail.com>
6820 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6821 (Class.AddBasesForPart): Move CS0537 check here from ...
6822 * cs-parser.jay (class_declaration): ... here. Move calling of
6823 'AddBasesForPart' to ...
6824 (class_bases): ... here.
6825 (struct_declaration, interface_declaration): Update to changes.
6827 2007-08-02 Marek Safar <marek.safar@gmail.com>
6829 A fix for bug #81923
6831 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6832 conversion is allowed.
6834 2007-08-02 Marek Safar <marek.safar@gmail.com>
6836 A fix for bug #81564
6838 * ecore.cs (EventExpr): Add IsBase handling.
6840 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6843 2007-08-02 Raja R Harinath <harinath@gmail.com>
6845 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6846 * cs-parser.jay: Some whitespace cleanups.
6847 (current_delegate): New.
6849 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6850 a dummy code block, and use 'type_name' instead of 'member_name'.
6851 (interface_declaration, class_declaration): Likewise.
6852 (delegate_declaration): Likewise. Rearrange slightly and use
6854 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6855 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6857 2007-08-02 Marek Safar <marek.safar@gmail.com>
6859 A fix for bug #82039
6861 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6864 * typemanager.cs (CSharpName): Split to string overload.
6866 2007-08-02 Marek Safar <marek.safar@gmail.com>
6869 * report.cs: Updated warning CS0472.
6871 2007-08-01 Marek Safar <marek.safar@gmail.com>
6873 A fix for bug #82181
6875 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6877 2007-08-01 Marek Safar <marek.safar@gmail.com>
6879 A fix for bug #82277
6880 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6882 2007-08-01 Marek Safar <marek.safar@gmail.com>
6884 ** C# 3.0 Type Inference (major bits are working)
6886 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6887 (.ImplicitStandardConversionExists): Uses compatible.
6888 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6889 (.InferReturnType): New method.
6890 (.Compatible): Refactored.
6891 (.ResolveParameters): Uses factory to create resolved parameters.
6892 (.CompatibleMethod): Add probing mode support.
6893 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6894 clearly distinguish between 2 different operations.
6895 (LambdaMethod): Moved to lambda.cs.
6896 (AnonymousMethod): Removed unused fields and methods.
6897 (AnonymousDelegate): Simplified.
6899 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6901 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6903 * delegate.cs (Delegate): New mehods to reduce code duplication.
6904 (.GetConstructor): New method.
6905 (.GetInvokeMethod): New method.
6906 (DelegateCreation): Updated.
6908 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6910 (OverloadResolve): Made probing little bit faster.
6912 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6915 * generic.cs (TypeInferenceContext): Dummy implementation.
6917 * iterators.cs: Updated after Resolve/Define rename.
6919 * lambda.cs (LambdaExpression)
6920 (.ResolveParameters): Handles both type of arguments and type inference too.
6922 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6923 (InflateTypes): Updated.
6925 * support.cs (InflateTypes): Changed signature and updated.
6927 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6928 (MemberLookup_FindMembers): More MS tricks.
6929 (GetParameterData): Ditto.
6930 (GetDelegateParameters): Uses quick path for dynamic types.
6932 2007-08-01 Marek Safar <marek.safar@gmail.com>
6934 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6937 2007-07-31 Marek Safar <marek.safar@gmail.com>
6939 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6942 2007-07-26 Jb Evain <jbevain@novell.com>
6944 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6945 which takes a boolean 'report_errors', similar to the GetMethod.
6946 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6947 in .net 2.1, do not report errors here.
6949 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6950 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6951 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6954 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6955 of the type InternalsVisibleToAttribute before the first call
6956 to CoreLookupType which is allowed to fail (third boolean parameter
6957 to true). Because, during the resolution for a type that is not
6958 immediately found, we try to check if the type is not defined in
6959 a friend assembly, and to do so, we need the
6960 InternalVisibleToAttribute.
6962 2007-07-23 Miguel de Icaza <miguel@novell.com>
6964 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6965 feature that allows structs to be compared against null and inline
6966 the result as true or false.
6968 Notice that the same code is not permitted inside a generic block
6969 of code that would do:
6971 class Foo<T> where T : struct {
6978 It is only allowed if the type of T is not bound (no where
6979 clause). In my opinion, this CSC 2 behavior is broken but people
6980 seem to be using it (IronRuby does, a few bug reports on bugzilla
6981 have it and some people have complained about it).
6983 All of the users that depend on this behavior have code that is
6986 * report.cs (Warning, Error): make these take object arguments,
6987 not strings, as that allows us to take advantage of Format.
6989 2007-07-20 William Holmes <billholmes54@gmail.com>
6991 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6992 Left member variable for the Count.
6993 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6994 MemberName.CountTypeArguments to avoid a NRE.
6996 This code is contributed under the MIT X11 license
6998 2007-07-18 Marek Safar <marek.safar@gmail.com>
7000 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7002 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7004 * doc.cs : generic method arguments are written as ``x while generic
7005 type arguments are `x. Combined with the previous change, fixed bug
7008 2007-07-18 Raja R Harinath <rharinath@novell.com>
7011 * expression.cs (Binary.ResolveOperator): When converting
7012 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7014 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7016 * doc.cs : when T: or whatever x: is specified, it does not really
7017 check the doc comment's syntax correctness. Fixed bug #82006.
7019 2007-07-18 Marek Safar <marek.safar@gmail.com>
7021 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7022 LambdaExpression better.
7024 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7026 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7028 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7029 as it can be generated.
7031 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7034 * lambda.cs (LambdaExpression): Refactored to share same code with
7035 AnonymousMethodExpression.
7037 2007-07-17 Marek Safar <marek.safar@gmail.com>
7039 * anonymous.cs (MakeName): Include host name for easier debugging.
7040 (LambdaMethod): New class for lambda spcecific stuff.
7042 * attribute.cs: Set EmitContext return type.
7044 * class.cs: Set EmitContext return type.
7046 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7047 with null/void meaning.
7049 * iterators.cs (ContainerType): Implemented.
7051 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7053 * statement.cs (Return): Updated to lambda expressions.
7054 (Block.CloneTo): Parent can be null.
7056 2007-07-13 Marek Safar <marek.safar@gmail.com>
7058 A fix for bug #81917
7059 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7061 * class.cs (FixedField): Check whether field is in unsafe scope.
7063 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7064 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7066 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7069 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7071 2007-07-13 Marek Safar <marek.safar@gmail.com>
7073 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7074 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7077 2007-07-13 Marek Safar <marek.safar@gmail.com>
7079 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7081 2007-07-13 Marek Safar <marek.safar@gmail.com>
7083 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7084 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7086 * codegen.cs(EmitContext): Add ProbingMode flag.
7088 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7090 * driver.cs: For now set both warning values.
7092 * ecore.cs (SimpleName): Name is readonly.
7093 (MethodGroup.OverloadResolve): One quick path for probing.
7095 * expression.cs (Unary): Set Oper r/o.
7096 (Binary): Set Oper r/o.
7097 (ParameterReference): Set few instance variables as r/o.
7098 (ParameterReference.DoResolveBase): Don't capture aruments when
7100 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7101 (Arglist): arguments are private.
7102 (SizeOf): type is private and r/o.
7103 (MemberAccess): arguments are private.
7105 * report.cs: Enhanced reporting on/off capabilities.
7107 * lambda.cs: Uses ec.IsInProbingMode.
7108 (ContextualReturn): Derives from return.
7110 * rootcontext.cs: For now set both warning values.
7112 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7114 (Return.Resolve): Don't die immediately.
7115 (Block.Resolve): Speed-up probing.
7116 (Block.CloneTo): Clone only child blocks.
7118 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7120 * iterators.cs: reverted Miguel's latest change (r81925) as it
7121 breaks the build in System.
7123 2007-07-13 Miguel de Icaza <miguel@novell.com>
7125 * iterators.cs (Yield.CheckContext): Check for the iterator type
7126 also here as we can call into Yield even in codepaths that are not
7128 (MethodOrOperator is the only path that was checked).
7130 In addition to the standard check, use a more specific check for
7131 constructors to report a more verbose error.
7133 2007-07-12 Miguel de Icaza <miguel@novell.com>
7135 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7136 report the warning and continue
7138 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7139 values on the stack on the call to Emit. Use EmitStatement if
7140 possible, or using Emit + Pop if not possible. Fixes #82064
7142 2007-07-12 Raja R Harinath <rharinath@novell.com>
7144 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7145 avoid try...finally in some cases.
7147 2007-07-10 Marek Safar <marek.safar@gmail.com>
7149 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7151 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7152 instead of method. Re-use standard error handling.
7153 (ConstructorInitializer.Emit): Simplified.
7155 * delegate.cs: Updated after Invocation.EmitCall change.
7157 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7158 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7159 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7160 method and don't permanently changing input arguments.
7161 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7162 is resolved it has one of the candidates is the best one which is later
7163 used to emit. Removed a few unused method.
7164 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7166 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7167 (Binary.ResolveOperator): Ditto.
7168 (ConditionalLogicalOperator.DoResolve): Ditto.
7169 (Invocation): Uses method group.
7170 (Invocation.DoResolve): Simplified.
7171 (Invocation.EmitCall): Removed useless is_static.
7172 (Invocation.Emit): Delegate to method group.
7173 (Invocation.EmitStatement): Simplified.
7174 (New): Uses method group.
7175 (MemberAccess.DoResolve): Don't destroy original expression.
7177 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7179 2007-07-04 Marek Safar <marek.safar@gmail.com>
7181 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7184 * lambda.cs: Add custom error message type.
7186 2007-07-03 Marek Safar <marek.safar@gmail.com>
7188 * lambda.cs: Simplified little bit.
7190 * parameter.cs: Introduced ImplicitLambdaParameter.
7191 (Parameters.CreateFullyResolved): New factory instead of ctor.
7195 * delegate.cs: Updated parameter creation.
7197 2007-07-03 Marek Safar <marek.safar@gmail.com>
7199 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7202 * generic.cs: Synchronized with gmcs.
7204 2007-07-03 Marek Safar <marek.safar@gmail.com>
7206 * class.cs (Indexer): Check return type as soon as possible.
7208 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7211 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7213 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7215 * parameter.cs (Parameter): Use expression type when it is available.
7217 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7218 method modifier for the first parameter only.
7220 2007-06-24 Marek Safar <marek.safar@gmail.com>
7222 A fix for bug #81938
7223 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7225 * constant.cs: Tide up an exception message.
7227 2007-06-22 Marek Safar <marek.safar@gmail.com>
7229 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7230 an uninitialized variable is used.
7232 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7234 2007-06-22 Marek Safar <marek.safar@gmail.com>
7236 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7237 not found error handling.
7239 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7241 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7242 (ArrayCreation.DoResolve): Simplified.
7243 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7244 its own resolve process.
7245 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7247 2007-06-20 Marek Safar <marek.safar@gmail.com>
7249 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7252 2007-06-20 Marek Safar <marek.safar@gmail.com>
7254 * cs-tokenizer.cs: Removed var related stuff.
7256 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7257 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7258 a type and a keyword at same time.
7260 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7263 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7264 implicitly typed arrays, more changes will follow.
7266 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7268 2007-06-19 Marek Safar <marek.safar@gmail.com>
7270 * ecore.cs (VarExpr): Removed Handled field.
7272 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7273 build-in assign functionality.
7274 (ForEach.Resolve): Removed all implicitly typed local variable code and
7276 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7277 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7279 2007-06-18 Marek Safar <marek.safar@gmail.com>
7281 * assign.cs: Removed implicitly typed local variable check.
7283 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7284 referencing implicitly typed local variable.
7285 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7288 * statement.cs (Fixed): Removed unsupported implicitly typed local
7291 2007-06-15 Marek Safar <marek.safar@gmail.com>
7293 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7295 2007-06-14 Marek Safar <marek.safar@gmail.com>
7297 A fix for bugs #81855 and #76274
7298 * attribute.cs (AttachTo): Always set owner for global attributes to
7301 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7304 * cs-parser.jay: Assembly and module attributes must precede all other
7305 elements except using clauses and extern alias declarations.
7307 2007-06-13 Marek Safar <marek.safar@gmail.com>
7309 A fix for bug #81748
7311 * expression.cs: More checks for non ISO-1 features.
7313 2007-06-12 Marek Safar <marek.safar@gmail.com>
7315 A fix for bug #81807
7316 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7317 present inside switch statement and it is required by nullable check.
7319 2007-06-12 Marek Safar <marek.safar@gmail.com>
7321 A fix for bug #81840
7322 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7323 when type matching fails.
7325 * namespace.cs: Tiny error message change.
7327 2007-06-12 Marek Safar <marek.safar@gmail.com>
7329 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7330 reporting. Added automatic property check.
7332 * class.cs: Updated after CheckAbstractAndExtern relocation.
7333 (AEventPropertyAccessor.GetSignatureForError): Customized.
7335 2007-06-11 Marek Safar <marek.safar@gmail.com>
7337 * class.cs (DefineBaseTypes): Base type can be undefined.
7339 * ecore.cs (TypeLookup): Minor refactoring.
7340 (DoResolveAsTypeStep): Removed redundant check.
7342 * namespace.cs (Lookup): Removed redundant check.
7344 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7345 ResolveAsTypeTerminal step.
7346 (BootstrapCorlib_*): Simplified.
7347 (PopulateCoreType): Core types can be now external.
7349 2007-06-07 Marek Safar <marek.safar@gmail.com>
7351 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7353 (InferTypeArguments): Infers anonymous expression type arguments.
7354 (Compatible): Split to Compatible and InferTypeArguments.
7356 * lambda.cs: Updated.
7358 2007-06-08 Marek Safar <marek.safar@gmail.com>
7360 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7362 2007-06-07 Raja R Harinath <harinath@gmail.com>
7364 Fix #80477, cs0135-2.cs, cs0135-3.cs
7365 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7366 names to the "known" variables list.
7367 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7368 parameter names are also "known".
7369 (Block.CheckError136): Remove.
7370 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7373 2007-06-07 Marek Safar <marek.safar@gmail.com>
7375 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7377 2007-06-06 Marek Safar <marek.safar@gmail.com>
7379 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7380 internal error not an user error.
7382 * expression.cs (IsApplicable): Refactored to make debugging easier.
7384 * support.cs: More tricks for non-mono runtimes.
7386 * typemanager.cs (CoreLookupType): Made public.
7387 (InitSystemCore): All linq specific stuff moved to linq.cs
7389 2007-06-05 Marek Safar <marek.safar@gmail.com>
7391 * typemanager.cs (CSharpSignature): One more missing build-in types
7393 More tricks for non-mono runtime.
7395 2007-06-05 Raja R Harinath <harinath@gmail.com>
7397 * statement.cs (Block.CheckError136_InParents): Remove.
7398 (Block.AddVariable): Use GetParameterInfo instead.
7399 (ToplevelBlock.ProcessArguments): Likewise.
7401 2007-06-04 Raja R Harinath <rharinath@novell.com>
7403 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7405 (ToplevelBlock.GetParameterInfo): Split out of ...
7406 (ToplevelBlock.GetParameterRefernce): ... this.
7407 (ToplevelBlock.ParameterMap): Remove.
7408 * expression.cs (ParameterReference): Update to use
7409 ToplevelParameterInfo.
7411 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7414 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7415 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7417 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7418 (ToplevelBlock.ProcessParameters) ... here.
7419 (ToplevelBlock..ctor): Invoke it.
7421 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7424 * statement.cs (IKnownVariable): New interface.
7425 (LocalInfo): Implement it.
7426 (ToplevelParameterInfo): New class.
7427 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7428 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7429 GetKnownVariableInfo.
7431 2007-06-03 Raja R Harinath <harinath@gmail.com>
7433 Partly speed up CS0136 error checks.
7434 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7435 'recurse' parameter.
7436 (Block.DoCheckError136): Only check errors in parameters. Move
7437 local variable checks ...
7438 (Block.AddVariable): ... here, and ...
7439 (ToplevelBlock.ResolveMeta): ... here.
7441 2007-06-02 Raja R Harinath <harinath@gmail.com>
7443 * statement.cs (Block.IsChildOf): Remove.
7445 * statement.cs (Statement.Clone): Move special case code ...
7446 (Block.CloneTo): ... here.
7448 2007-05-29 Raja R Harinath <rharinath@novell.com>
7450 * statement.cs (ToplevelBlock.container): Remove field. It's
7451 redundant with 'Parent'.
7452 (ToplevelBlock.ContainerBlock): Remove accessor.
7453 (ToplevelBlock..ctor): Update to changes. Register anonymous
7454 child with parent here, ...
7455 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7457 (start_anonymous): Don't save current_block.
7458 (top_current_block): Remove.
7460 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7461 (Block.Resolve): Update to changes.
7462 (Block..ctor): Move setting of "correct" 'Toplevel'
7463 and 'Explicit' fields to ...
7464 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7466 2007-05-27 Raja R Harinath <harinath@gmail.com>
7469 * statement.cs (Block.Implicit): Remove.
7470 (Block): Update to changes.
7471 * flowanalysis.cs: Likewise.
7473 Mildly speed up CheckInvariantMeaningInBlock
7474 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7475 Recursively call AddKnownVariable to all enclosing blocks.
7476 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7477 Remove recursive calls.
7478 (Block): Update to changes.
7480 New ExplicitBlock invariants
7481 * statement.cs (Block.Explicit): New field. It points to the
7482 immediately enclosing non-implicit block.
7483 (Block..ctor): Maintain the invariant.
7484 * cs-parser.jay: Take advantage of invariant.
7486 Introduce ExplicitBlock
7487 * statement.cs (ExplicitBlock): New.
7488 (ToplevelBlock): Derive from it.
7489 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7491 (Block.Implicit): Update to changes.
7492 * cs-parser.jay: Update to changes.
7495 * codegen.cs (EmitContext.IsLastStatement): Remove.
7496 * statement.cs (Block.DoEmit): Update to changes.
7498 2007-05-25 Raja R Harinath <rharinath@novell.com>
7500 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7501 modifying current_block directly.
7503 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7505 * class.cs: Implemented automatic properties (C# 3.0)
7506 Thanks to Marek for the help.
7508 2007-05-23 Raja R Harinath <rharinath@novell.com>
7510 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7511 variable as assigned, note also that all its components are
7513 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7515 2007-05-19 Marek Safar <marek.safar@gmail.com>
7517 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7518 member is marked as compiler generated.
7520 * decl.cs (MemberCore): Refactored ModFlags into property.
7522 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7523 (Check): Check only accessibility modifiers.
7525 2007-05-18 Raja R Harinath <rharinath@novell.com>
7527 Track all assignable slots in one bit array
7528 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7529 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7530 logic from VariableMap constructor here. Use the same 'offset'
7531 variable that's later used for computing offsets of local
7533 * flowanalysis.cs (UsageVector.parameters): Remove.
7534 (UsageVector): Update to changes.
7535 (VariableMap): Remove.
7537 Avoid creating ParameterMap in every block
7538 * statement.cs (Block.ParameterMap): Move ...
7539 (ToplevelBlock.ParameterMap): ... here.
7540 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7542 * flowanalysis.cs (FlowBranching.param_map): Remove.
7543 (FlowBranching.UsageVector): Update to changes.
7544 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7546 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7548 * expression.cs (ParameterReference): Distinguish between block
7549 where parameter was referenced and declared.
7551 2007-05-18 Marek Safar <marek.safar@gmail.com>
7553 * flowanalysis.cs, statement.cs: Put back improved error handling.
7555 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7559 Imporved object and collection initialization (C# 3.0).
7561 2007-05-15 Marek Safar <marek.safar@gmail.com>
7563 A fix for bug #81380
7564 * expression.cs (Is.DoResolve): Only value types have constant `is'
7567 2007-05-15 Raja R Harinath <rharinath@novell.com>
7569 * statement.cs (ToplevelBlock.child): Remove.
7571 2007-05-15 Raja R Harinath <harinath@gmail.com>
7573 Rationalize ResolveMeta: refactoring
7574 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7575 out constant handling code into ...
7576 (Block.DoResolveConstants): ... this.
7578 Rationalize ResolveMeta: kill local_map
7579 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7580 (Block.AssignableSlots): New.
7581 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7582 for locals -- move code from VariableMap here. Avoid unnecessary
7584 * flowanalysis.cs (FlowBranching.local_map): Remove.
7585 (FlowBranching..ctor): Use Block.AssignableSlots.
7586 (VariableMap): Remove unused constructors.
7588 2007-05-11 Raja R Harinath <rharinath@novell.com>
7590 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7592 2007-05-11 Marek Safar <marek.safar@gmail.com>
7594 * typemanager.cs (IsFriendAssembly): Should not be called for building
7597 2007-05-09 Marek Safar <marek.safar@gmail.com>
7599 * literal.cs (NullConstant): Print null in all cases.
7601 * expression.cs (Binary.ResolveOperator): Implemented delegate
7602 comparison based on C# 2.0 changes.
7604 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7606 This code is contributed under the MIT X11 license
7608 The following enables support for several C# 3.0 language features:
7610 * cs-tokenizer.cs: Added support for the "var" keyword.
7612 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7613 Added VarExpr class to facilitate type inferencing.
7615 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7616 to support anonymous types.
7618 * assign.cs: Added support for type inferencing and initialization.
7620 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7622 * expression.cs: Added implicit array support to ArrayCreation.
7623 Added 5 types and 1 interface:
7625 IInitializable Implementing classes can inject initializing
7626 statements after object instantiation.
7628 Initializer Stores data for object initialization.
7630 AnonymousType An expression for anonymous types.
7632 AnonymousTypeParameter Stores data about an anonymous type's field.
7634 NewInitialize An expression for object initialization.
7636 CollectionInitialize An expression for collection initialization.
7638 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7641 2007-05-06 Marek Safar <marek.safar@gmail.com>
7643 A fix for bug #81500
7644 * cs-tokenizer.cs: Add special handling for coalescing operator.
7646 2007-05-06 Marek Safar <marek.safar@gmail.com>
7648 A fix for bug #81529
7649 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7650 its value from base class until it is redefined.
7652 2007-05-02 Raja R Harinath <rharinath@novell.com>
7654 Fix regression in cs0631-3.cs
7655 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7656 fallback. Make error fallback catch more cases.
7658 2007-05-01 Miguel de Icaza <miguel@novell.com>
7660 * cs-parser.jay: Allow parameters in operator declarations to have
7663 2007-04-27 Miguel de Icaza <miguel@novell.com>
7665 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7668 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7669 inside the ContextualReturn, it does not have to be an
7670 ExpressionStatement.
7672 2007-04-24 Miguel de Icaza <miguel@novell.com>
7674 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7677 2007-04-23 Miguel de Icaza <miguel@novell.com>
7679 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7680 method in two methods: ResolveNoDefine and Resolve.
7682 ResolveNoDefine will stop just after ResolveTopBlock has been
7685 Resolve will then continue by creating a method and issuing the
7686 call to method.Define ().
7688 (AnonymousMethod): Split and implement the new Resolve and
7689 ResolveNoDefine as well.
7691 * lambda.cs (LambdaExpression): Split the anonymous method
7692 resolution code into a separate routine (CoreCompatibilityTest)
7693 from DoCompatibleTest.
7695 (LambdaExpression.TryBuild): New method, this method tries to
7696 build the LambdaExpression with the given set of types to be used
7697 as the types for the various parameters of the lambda expression.
7699 If the compilation succeed with the given types, the infered type
7700 of the Anonymous method is returned, otherwise null is returned.
7702 2007-04-23 Marek Safar <marek.safar@gmail.com>
7704 A fix for bug #81414
7705 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7707 2007-04-22 Miguel de Icaza <miguel@novell.com>
7709 * cs-tokenizer.cs: Change various identifiers here from the
7710 camelCasing to the recommended Linux-like style for instance
7711 variables from the Coding Guidelines.
7713 2007-04-19 Martin Baulig <martin@ximian.com>
7716 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7717 System.Enum to System.ValueType.
7719 2007-04-13 Martin Baulig <martin@ximian.com>
7721 Rewrote implicit reference conversions. We need to distinguish
7722 between implicit reference conversions (13.1.4) and implicit
7723 boxing conversions (13.1.5).
7725 According to the spec, there's an an implicit conversion
7726 "From a one-dimensional array-type S[] to IList<T> and base
7727 interfaces of this interface, provided there is an implicit
7728 reference conversion from S to T." Note that this does not
7729 include boxing conversions.
7732 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7733 (Convert.ImplicitReferenceConversion): Split into
7734 ImplicitReferenceConversionCore() and
7735 ImplicitBoxingConversionExist().
7736 (Convert.ImplicitReferenceConversionExists): Use the new
7737 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7739 2007-04-12 Martin Baulig <martin@ximian.com>
7741 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7742 `TypeManager.null_type' checks up to the top of the method.
7744 2007-04-11 Marek Safar <marek.safar@gmail.com>
7746 A fix for bug #81350
7747 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7750 2007-04-11 Martin Baulig <martin@ximian.com>
7752 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7753 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7754 to make this work for generic classes; fixes #79561.
7756 2007-04-11 Martin Baulig <martin@ximian.com>
7758 * expression.cs (As): Add support for nullable types; fixes #79371.
7760 2007-04-11 Martin Baulig <martin@ximian.com>
7762 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7763 `type.FullName' is null; fixes #80243.
7765 2007-04-11 Martin Baulig <martin@ximian.com>
7767 * expression.cs (Invocation.IsApplicable): Don't modify the method
7768 if type inference succeeded, but the method was not applicable.
7771 2007-04-10 Marek Safar <marek.safar@gmail.com>
7773 A fix for bug #81324
7774 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7775 internal and external namespaces containers.
7777 2007-04-10 Martin Baulig <martin@ximian.com>
7779 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7780 TypeManager.DropGenericMethodArguments() so we also call
7781 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7783 2007-04-10 Martin Baulig <martin@ximian.com>
7785 * iterators.cs (Iterator.CreateIterator): Don't crash if
7786 `method.ReturnType' is null. This happens if something went wrong
7787 while resolving that typ (we already reported an error in this case).
7789 2007-04-10 Martin Baulig <martin@ximian.com>
7791 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7792 generic interfaces; report the CS0144 directly.
7794 2007-04-10 Martin Baulig <martin@ximian.com>
7796 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7797 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7799 2007-04-10 Martin Baulig <martin@ximian.com>
7801 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7803 2007-04-09 Raja R Harinath <rharinath@novell.com>
7806 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7807 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7810 * statement.cs (For.Resolve): If resolution fails, use
7813 2007-04-08 Marek Safar <marek.safar@gmail.com>
7815 * anonymous.cs (MakeName): Make faster and zero-based.
7816 (VerifyExplicitParameterCompatibility): Back to mode where generic
7817 parameter is ignored.
7818 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7820 * class.cs (EmitType): Method can emit another new method.
7822 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7824 * driver.cs: Updated.
7826 * lambda.cs: Reuse predefined empty parameters.
7828 * parameter.cs: Updated
7830 * support.cs: Implemented InflateTypes.
7832 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7833 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7835 2007-04-03 Martin Baulig <martin@ximian.com>
7839 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7840 version of TypeManager.IsOverride() which also works with generic
7843 2007-04-03 Martin Baulig <martin@ximian.com>
7848 (Convert.ExplicitReferenceConversion): We need to cast when
7849 converting from IList<T> to S[].
7851 2007-04-01 Marek Safar <marek.safar@gmail.com>
7853 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7856 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7858 2007-03-31 Marek Safar <marek.safar@gmail.com>
7860 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7861 argument and return type inferring.
7863 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7864 (ReturnType): Turned to property.
7866 * statement.cs (Return): Implemented return type inferring.
7868 * support.cs (ReflectionParameters): Use local types if possible.
7870 2007-03-30 Raja R Harinath <rharinath@novell.com>
7872 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7873 (FlowBranching.UsageVector): Update to changes.
7875 Prepare to kill 'Reachability'
7876 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7877 argument of constructor.
7879 2007-03-29 Raja R Harinath <rharinath@novell.com>
7881 Prepare to kill 'Reachability'
7882 * flowanalysis.cs (UsageVector.is_unreachable): New.
7883 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7884 'reachability', and verify they're consistent.
7887 * expression.cs (New.EmitStatement): Handle type parameters here too.
7889 2007-03-29 Martin Baulig <martin@ximian.com>
7894 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7895 CompilerGeneratedClass.
7896 (ScopeInfo.EmitScopeInstance): Make this protected.
7897 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7898 `ec.CurrentAnonymousMethod.Scope == Scope'.
7900 * statement.cs (Block.ScopeInfo): Make this a property.
7902 2007-03-27 Raja R Harinath <harinath@gmail.com>
7904 Prepare to kill 'Reachability'
7905 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7906 (FlowBranching.UsageVector.Reachability): Remove property.
7907 (FlowBranching.UsageVector.IsUnreachable): New property.
7908 (FlowBranching.UsageVector.ResetBarrier): New.
7909 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7910 * codegen.cs, statement.cs: Update to changes.
7912 2007-03-27 Martin Baulig <martin@ximian.com>
7917 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7920 2007-03-26 Raja R Harinath <rharinath@novell.com>
7922 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7923 instead of TriState. Remove all mention of TriState.
7925 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7926 replaced by a boolean. Add boolean 'is_unreachable' field, check
7927 and maintain invariants.
7929 2007-03-25 Marek Safar <marek.safar@gmail.com>
7931 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7933 2007-03-25 Marek Safar <marek.safar@gmail.com>
7935 * expression.cs: Stop using obsolete 2.0 opcodes.
7937 2007-03-25 Marek Safar <marek.safar@gmail.com>
7939 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7940 one of the latests Martin's fixes.
7942 2007-03-23 Miguel de Icaza <miguel@novell.com>
7944 * expression.cs: On BigEndian systems, swap the bytes, temporary
7945 solution until we get a new bitconverter class.
7947 2007-03-23 Martin Baulig <martin@ximian.com>
7951 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7952 "Method" and "Method`1". Normally, a cache lookup is done on the
7953 "Method" form (ie. without the generic arity), but this one makes
7954 lookups on the full form work as well.
7956 2007-03-22 Raja R Harinath <rharinath@novell.com>
7958 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7961 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7963 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7964 ordered_member_list, to TypeBuilder to store members to be defined
7965 in the order they were parsed in.
7966 - ordered_explicit_member_list contains all properties indexers
7967 and methods that are defined as explicit implementation of an
7968 interface or base class.
7969 - ordered_member_list contains all properties indexers and methods
7970 that are not defined as explicit implementation of an interface
7973 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7974 functionality in these removed classes has been replaced with
7975 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7976 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7978 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7979 to CheckForDuplications inside GetMethod and SetMethod Define Method
7980 to handle method property and indexer name conflicts.
7984 All code is contributed under the MIT/X11 license.
7986 2007-03-20 Martin Baulig <martin@ximian.com>
7988 * class.cs (TypeContainer.Interfaces): Removed; they're now
7989 included in `TypeContainer.Types'.
7991 2007-03-20 Martin Baulig <martin@ximian.com>
7993 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7995 * class.cs (TypeContainer.CreateType): New public method. This is
7996 now called before DefineType() to create the TypeBuilders.
7997 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7998 has already been created by CreateType().
7999 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8000 don't resolve our base classes here; this has been moved into
8001 DefineBaseTypes(). We're now called from CreateType().
8002 (TypeContainer.DefineBaseTypes): New private method; resolve our
8003 base classes here. We're now called from DefineType().
8006 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8007 our types first to create all the TypeBuilders. After that, call
8008 TypeContainer.DefineType() on all the types which'll resolve their
8009 base classes and setup the resolve order.
8011 2007-03-20 Martin Baulig <martin@ximian.com>
8013 * class.cs (TypeContainer.Enums): Removed; they're now included in
8014 `TypeContainer.Types'.
8016 2007-03-20 Martin Baulig <martin@ximian.com>
8019 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8020 (TypeContainer.DoResolveMembers): Call DefineType() on our
8021 `compiler_generated' classes; moved here from DefineNestedTypes().
8024 (RootContext.ResolveTree): Call ResolveMembers() on all
8025 TypeContainer's in the `type_container_resolve_order'.
8027 2007-03-19 Marek Safar <marek.safar@gmail.com>
8029 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8031 2007-03-17 Marek Safar <marek.safar@gmail.com>
8033 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8034 implementation flags.
8036 2007-03-17 Marek Safar <marek.safar@gmail.com>
8038 * class.cs: More optimizations for type parameters.
8040 2007-03-15 Marek Safar <marek.safar@gmail.com>
8042 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8044 * ecore.cs, parameter.cs: More common code for both corlibs.
8046 * typemanager.cs (IsGenericMethod): Simplified.
8048 2007-03-15 Raja R Harinath <rharinath@novell.com>
8050 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8052 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8054 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8055 unconditionally. Simplify explanation.
8056 (Try.Resolve, Using.Resolve): Likewise.
8058 2007-03-15 Martin Baulig <martin@ximian.com>
8062 * decl.cs (DeclSpace): If we're a partial class, use our
8063 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8065 2007-03-15 Raja R Harinath <rharinath@novell.com>
8067 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8069 (FlowBranching.UsageVector): Update to changes.
8070 (FlowBranching.MergeSiblings): Likewise.
8071 * statement.cs: Likewise.
8073 2007-03-15 Martin Baulig <martin@ximian.com>
8078 (MemberCache): Added a special .ctor for type parameters.
8081 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8084 2007-03-09 Martin Baulig <martin@ximian.com>
8086 * enum.cs (Enum): Make this a TypeContainer.
8087 (EnumMember): Derive from `Const'.
8090 (Const.DoResolveValue): New protected virtual method; move most of
8091 the functionality of ResolveValue() here so we can override it in
8093 (Const.CreateConstantReference): Make this virtual.
8095 * class.cs (Kind): Add `Kind.Enum'.
8096 (TypeContainer.Emit): Don't emit the enums here; they're already
8097 in the `RootContext.typecontainer_resolve_order'.
8099 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8100 here; they're already in the `typecontainer_resolve_order'.
8102 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8103 TypeManager.DropGenericTypeArguments().
8106 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8107 (TypeManager.IsEnumType): Likewise.
8108 (TypeManager.EnumToUnderlying): Likewise.
8109 (TypeManager.IsEqual): Add support for enums.
8111 2007-03-12 Raja R Harinath <rharinath@novell.com>
8113 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8114 DefaultParameterValueAttribute to be undefined, say if System.dll
8117 2007-03-11 Marek Safar <marek.safar@gmail.com>
8119 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8122 2007-03-10 Marek Safar <marek.safar@gmail.com>
8124 * class.cs, parameter.cs: Unified parameters verification.
8126 2007-03-08 Martin Baulig <martin@ximian.com>
8128 * cs-parser.jay (constructor_header): Pass the location to the
8129 newly created TopLevelBlock.
8131 2007-03-07 Martin Baulig <martin@ximian.com>
8133 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8135 2007-03-06 Miguel de Icaza <miguel@novell.com>
8137 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8138 with the changes from David, fixes the build.
8140 2007-03-05 David Mitchell <dmitchell@logos.com>
8142 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8143 and its base interfaces to a one-dimensional array type S[],
8144 provided there is an implicit or explicit reference conversion
8147 2007-03-03 Marek Safar <marek.safar@gmail.com>
8149 * cs-tokenizer.cs: Implemented basic linq grammar.
8151 * driver.cs: Set linq lang version on demand.
8153 2007-02-26 Marek Safar <marek.safar@gmail.com>
8155 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8157 2007-02-25 Marek Safar <marek.safar@gmail.com>
8159 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8162 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8164 Check property and event extern attributes.
8166 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8169 2007-02-24 Marek Safar <marek.safar@gmail.com>
8171 A fix for bug #80407
8172 * ecore.cs: Don't report ambiguity error when methods have same parent.
8174 2007-02-23 Marek Safar <marek.safar@gmail.com>
8176 A fix for bug #80878
8177 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8179 2007-02-22 Marek Safar <marek.safar@gmail.com>
8181 * attribute.cs: Enable ExtensionAttribute presence test.
8183 2007-02-22 Marek Safar <marek.safar@gmail.com>
8185 * class.cs: Warn about missing GetHashCode only when Equals is override.
8187 * decl.cs: Check accessibility of type arguments.
8189 * typemanager.cs: Correctly report nullable array.
8191 2007-02-20 Marek Safar <marek.safar@gmail.com>
8193 * class.cs, report.cs: Capture more details when things go wrong.
8195 2007-02-20 Marek Safar <marek.safar@gmail.com>
8197 A fix for bug #80650
8198 * cs-parser.jay: Anonymous container starts at constructor declaration
8199 and not at block beginning because it has to be usable in constructor
8202 * statement.cs: Use context location and not block one for error reporting.
8204 2007-02-18 Marek Safar <marek.safar@gmail.com>
8206 A fix for bug #78712
8207 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8210 2007-02-18 Marek Safar <marek.safar@gmail.com>
8212 A fix for bug #80493 by Atsushi Enomoto
8213 * cs-parser.jay: Ignore invalid attribute target.
8215 2007-02-18 Marek Safar <marek.safar@gmail.com>
8217 * cs-tokenizer.cs: Ignore '\0' as white space character.
8219 2007-02-17 Miguel de Icaza <miguel@novell.com>
8221 * cs-parser.jay: Add support for lambda expressions to the mcs
8224 * lambda.cs: Only clone when we are probing, not on the final call
8225 (Compatible is the final call).
8227 * statement.cs (CloneContext): Introduce class to provide block
8228 remapping during clone.
8230 All statements Clone themselves now.
8232 (Clone): special handling for blocks, when we clone a block, we
8233 register the block inside this routine, as children of the block
8234 might trigger a lookup.
8236 * expression.cs: Add support for CloneContext in all expressions.
8238 2007-02-17 Marek Safar <marek.safar@gmail.com>
8240 A fix for bug #80493
8241 * statement.cs: Report ambiguous warning when interfaces are not related.
8243 2007-02-15 Marek Safar <marek.safar@gmail.com>
8245 C# 3.0 extension methods.
8247 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8248 cannot be used directly.
8250 * class.cs (Class.Emit): Emit extension attribute if any class method
8251 is extension method.
8252 (Method.Define): Add basic extension method validation conditions.
8253 (Method.Emit): Emit extension attribute for method.
8255 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8256 extension method exists. Currently we follow same approach as Microsoft
8257 does, emit even if a method or a class are private but this can change
8260 * cs-parser.jay: Add handling of `this' keyword in method parameters
8263 * decl.cs (DeclSpace.IsStaticClass): New property.
8264 (MemberCache.FindExtensionMethods): Looks for extension methods with
8265 defined name and extension type.
8267 * doc.cs: Updated after OverloadResolve changes.
8269 * driver.cs: Add new soft reference to System.Core.dll.
8271 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8272 (ExtensionMethodGroupExpr): Represents group of extension methods.
8274 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8275 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8276 to MethodGroupExpr and made non-static for easier customization.
8277 (Invocation.DoResolve): Add extension method lookup when no standard
8279 (MemberAccess.DoResolve): Try extension methods if no member exists.
8281 * modifiers.cs: Add METHOD_EXTENSION modifier.
8283 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8284 as well as candidate extension type.
8285 (ComputeNamespaces): When assembly constains extension methods registers
8287 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8288 extension method lookup.
8289 (Namespace.LookupExtensionMethod): Looks for extension method in this
8291 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8292 find a method which matches name and extensionType.
8294 * parameter.cs (Parameter): Add This modifer.
8295 (HasExtensionMethodModifier): New property.
8296 (Resolve): Add extension parameter check.
8297 (ModFlags): turned to property to exclude this modifier as it is not real
8299 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8301 * support.cs (ParameterData): Add ExtensionMethodType.
8302 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8304 * typemanager.cs: Add type and ctor extension attribute type.
8306 2007-02-15 Miguel de Icaza <miguel@novell.com>
8308 * report.cs (DisableErrors, EnableErrors): used to prevent error
8309 output when we are "trying" to compile various methods with
8312 * ecore.cs (Expression): Add Clone method that calls the virtual
8313 CloneTo method. The current CloneTo method in Expression throws
8314 an exception so we can track down all the places where this must
8315 be implemented (not using abstract, because that would be a lot of
8316 up-front-work before we can start testing the implementation
8319 Important: we only need Clone capabilities for expressions created
8320 by the parser, as the expressions we will be cloning are
8321 expressions in the pre-resolved state. This vastly simplifies
8324 (SimpleName): Add CloneTo that does nothing.
8325 (EmptyCast): Add CloneTo.
8327 * expression.cs (Binary): Implement CloneTo.
8328 (Invocation.IsApplicable): Store the current ec in
8329 EmitContext.TempEc and restore it on return. This is used so we
8330 do not have to sprinkle hundres of methods with an extra
8331 EmitContext, we know that the only user is the lambda expression
8332 ImplicitConversionExists code.
8334 (Argument): Add Cloning capabilities.
8335 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8336 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8337 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8338 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8339 IndexerAccess): Add Clone capability.
8341 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8343 (Argument): Add cloning capability.
8345 * assign.cs (Assign): Implement CloneTo.
8347 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8349 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8350 version by calling Convert with the EmitContext (that we are
8351 currently storing in ec, this is not great, but will do for now,
8352 to avoid passing EmitContext parameters to hundreds of functions
8353 that do not need them now).
8355 (SetExpression): Remove, it is not needed.
8357 (ContextualReturn): Implement CloneTo.
8359 * statement.cs (Statement): Implement cloning infrastructure,
8360 similar to expressions.
8362 (Block): Partial implementation of Clone for statements.
8364 (Return): Implement clone.
8366 * constant.cs (Constant.CloneTo): New method, does nothing.
8368 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8369 solution, until we decide how to exactly do this.
8371 2007-02-14 Marek Safar <marek.safar@gmail.com>
8373 A fix for bug #80493
8374 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8375 a property is override we need to use second accessor.
8377 2007-02-13 Marek Safar <marek.safar@gmail.com>
8379 A fix for bug #80418
8380 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8383 2007-02-13 Marek Safar <marek.safar@gmail.com>
8385 Another fix for bug #80749
8386 * pending.cs: Abstract class has priority over interfaces.
8388 2007-02-13 Marek Safar <marek.safar@gmail.com>
8390 Another fix for bug #80749
8391 * pending.cs: Abstract class has priority over interfaces.
8393 2007-02-13 Marek Safar <marek.safar@gmail.com>
8395 Another fix for bug #80749
8396 * pending.cs: Abstract class has priority over interfaces.
8398 2007-02-13 Marek Safar <marek.safar@gmail.com>
8400 Another fix for bug #80749
8401 * pending.cs: Abstract class has priority over interfaces.
8403 2007-02-13 Marek Safar <marek.safar@gmail.com>
8405 * class.cs Better error message.
8407 * driver.cs: Add shorter versions of -optimize option.
8409 2007-02-13 Martin Baulig <martin@ximian.com>
8411 * class.cs (Constructor.Emit): Check the return value of
8412 ec.ResolveTopBlock() and return on error.
8414 2007-02-13 Raja R Harinath <rharinath@novell.com>
8416 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8417 message to fix error message regression.
8419 2007-02-12 Marek Safar <marek.safar@gmail.com>
8421 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8423 2007-02-12 Marek Safar <marek.safar@gmail.com>
8425 A fix for bug #80749
8426 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8427 its parent container.
8429 * class.cs (DefineFieldInitializers): Each initializer can has different
8432 * const.cs: Updated.
8434 2007-02-11 Miguel de Icaza <miguel@novell.com>
8436 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8437 now all the heavy lifting to check that embedded statements or
8438 expressions have the right form is done in the ContextualReturn.
8440 (ContextualReturn): New class.
8442 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8443 method that can be invoked to report 201, so we do not replicate
8446 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8448 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8449 treating tabs as spaces.
8451 2007-02-09 Marek Safar <marek.safar@gmail.com>
8453 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8454 * assign.cs: Use full implicit conversion for right side check.
8456 2007-02-09 Marek Safar <marek.safar@gmail.com>
8458 * statement.cs (Switch): Switch over boolean type is not standardized.
8460 2007-02-08 Marek Safar <marek.safar@gmail.com>
8462 A fix for bug #80755
8463 * decl.cs (FindBaseEvent): Don't use method cache for events.
8465 2007-02-07 Marek Safar <marek.safar@gmail.com>
8467 * cs-parser.jay: Better syntax error handling.
8469 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8470 instead of underlying type value.
8472 2007-02-06 Marek Safar <marek.safar@gmail.com>
8474 * driver.cs: Check define identifier before is registered.
8476 * namespace.cs: Use existing error message.
8478 * report.cs: New warning.
8480 2007-02-06 Marek Safar <marek.safar@gmail.com>
8482 A fix for bug #80742
8483 * expression.cs: Delegate Invoke method can be called directly.
8485 2007-02-06 Marek Safar <marek.safar@gmail.com>
8487 A fix for bug #80676
8488 * class.cs (IsEntryPoint): The Main method can have params modifier.
8490 2007-02-04 Miguel de Icaza <miguel@novell.com>
8492 * parameter.cs (Parameter, Parameters): Add Clone method.
8494 * anonymous.cs (Compatible): Turn method into virtual method, so
8495 LambdaExpression can implement a different behavior.
8497 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8498 out the basic checking here, so it can be used by
8501 * lambda.cs: Introduce "Compatible" function that will do the
8504 2007-02-02 Marek Safar <marek.safar@gmail.com>
8506 * attribute.cs: Unified one error message.
8508 * class.cs (Class): Use type attributes and not properties to test static
8510 (IsEntryPoint): Don's pass local variable.
8512 * convert.cs: Removed duplicate check.
8514 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8516 * driver.cs: Don't crash when soft reference does not exist.
8518 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8519 (UsingEntry): Removed redundant allocation.
8521 * parameter.cs: Add fast path for type parameters.
8523 * support.cs: Don't allocate attribute when it's not used.
8525 2007-01-30 Miguel de Icaza <miguel@novell.com>
8528 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8529 this into a virtual method, so we can override it in LambdaExpression.
8531 * driver.cs: Improve diagnostics in case of failure.
8533 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8534 write a function that is slightly more complex and that parses:
8536 type identifier [, type identifier]* )
8538 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8541 (canEmpty ? i >= 0 : i > 0)
8543 2007-01-30 Raja R Harinath <rharinath@novell.com>
8545 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8546 exception on possibly valid code.
8548 2007-01-29 Raja R Harinath <rharinath@novell.com>
8550 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8552 (parse_opt_type_arguments): Remove. It's almost the same as
8554 (parse_namespace_or_typename): Use parse_less_than.
8556 2007-01-28 Miguel de Icaza <miguel@novell.com>
8558 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8559 this bug took a few hours to find, because the state saved and
8560 restored by PushPosition and PopPosition was ignoring the state of
8561 parse_generic_less_than.
8563 I can also now remove the handling of OP_LT and OP_GT, this solves
8566 * cs-tokenizer.cs: store the location for the ARROW token, we use
8569 (PushPosition, PopPosition): save/restore also `current_token',
8570 restore `parse_generic_less_than' (was missing).
8572 (parse_opt_type_arguments): use parse_type, not
8573 parse_namespace_or_typename to parse types.
8575 * lambda.cs: Empty new file, will eventually have the lambda
8576 expression implementation.
8578 * lambda.test: used to test the internal tokenizer.
8580 * report.cs (FeatureIsNotISO1): Rename from
8581 FeatureIsNotStandardized, because it was about the language level
8582 (1 vs 2) it was not about standarization.
8584 (FeatureRequiresLINQ): New.
8586 * support.cs (SeekableStreamReader): Only require that the reader
8587 is a TextReader, not a StreamReader, so we can plug StringReader.
8589 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8590 given position in the input stream the following tokens can be
8591 parsed as a type followed by an identifier.
8593 (is_punct): after a '(' if parse_type_and_parameter returns true,
8594 then return a special token OPEN_PARENS_LAMBDA which is used to
8595 avoid reduce/reduce errors in the grammar for the
8596 lambda_expression rules.
8598 (parse_type): implement a type parser inside the
8599 tokenizer, the parser only returns true or false depending on
8600 whether the input at a given position can be parsed as a type.
8602 (peek_token): new method used during type parsing.
8604 2007-01-28 Raja R Harinath <rharinath@novell.com>
8607 * anonymous.cs (ScopeInfo.InflateParameters): New.
8608 (AnonymousContainer.Resolve): Use it to redirect types of
8609 delegate parameters.
8611 2007-01-27 Raja R Harinath <rharinath@novell.com>
8614 * expression.cs (Error_InvalidArguments): Don't use two different
8615 messages for CS1503. Use ExtraInformation and
8616 SymbolRelatedToPreviousError instead.
8619 * decl.cs (DeclSpace.initialize_type_params): Don't access
8620 'type_params' of a partial class directly.
8622 2007-01-26 Miguel de Icaza <miguel@novell.com>
8624 * constant.cs: Removed a handful of out-of-range checks that were
8627 2007-01-25 Marek Safar <marek.safar@gmail.com>
8629 * expression.cs (CheckUselessComparison): Add additional check for char
8632 * namespace.cs: Fixed typo.
8634 2007-01-23 Miguel de Icaza <miguel@novell.com>
8636 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8637 gone, instead we inline the test, preventing the needless casts to
8638 longs, ulongs and doubles for the parameters, avoiding calls to
8639 methods that overchecked stuff, and instead inlined things
8642 2007-01-20 Marek Safar <marek.safar@gmail.com>
8644 * cs-parser.jay: Better parameter error handling.
8646 2007-01-17 Marek Safar <marek.safar@gmail.com>
8648 A fix for bug #80368, #80522
8649 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8650 whether array initializer contains constants only.
8651 (ArrayCreation.Emit): Use better formula to decide when
8652 are array initializers for static initialization.
8653 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8654 have to emit even constants otherwise they are pre-initialized.
8656 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8657 Raja R Harinath <rharinath@novell.com>
8659 Fix emit order of 'get' vs. 'set'.
8660 * support.cs (Accessors): New.
8661 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8662 Note the order in which accessors are declared in the source.
8663 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8664 Refactored from Property.Define and Indexer.Define.
8665 (PropertyBase.DefineAccessors): New helper that calls the above in
8666 appropriate order as noted by the parser.
8667 (Property.Define, Indexer.Define): Update to changes.
8668 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8670 2007-01-17 Raja R Harinath <rharinath@novell.com>
8672 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8673 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8674 there's an implicit conversion from the current type to the target
8675 type before converting the underlying constant.
8677 2007-01-16 Marek Safar <marek.safar@gmail.com>
8679 * const.cs (ResolveValue): Updated after constant conversion was made more
8682 * constant.cs (GetAttributableValue): constant to object conversion is
8683 used for attributes only.
8684 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8685 constant conversions.
8686 (LongConstant.ConvertImplicitly): Ditto.
8688 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8689 (ImplicitConversionStandard): Handle constant conversion as extra step.
8690 It solves the issue when constant conversion was called indirectly like
8691 inside array initializer and constant folding was skipped.
8693 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8696 * statement.cs(ImplicitConversionStandard): Updated after constant
8697 conversion was made more generic.
8699 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8701 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8702 Constraints, solves the problem where the compiler incorrectly
8703 reported that a type parameter was not constrained to a class (Bug
8706 2007-01-14 Marek Habersack <grendello@gmail.com>
8708 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8710 2007-01-14 Marek Safar <marek.safar@gmail.com>
8712 A fix for bug #80368
8713 * assign.cs (FieldInitializer): New class implements field
8714 initializer statement.
8716 * attribute.cs: Update after FieldMember rename.
8718 * class.cs (PropertyBasedMember): New common class for property based
8720 (InterfaceMemberBase): New base class for all members which can be used as
8721 an interface members.
8722 (MethodCore): Moved really common code to InterfaceMemberBase.
8723 (Method.Define): Equal and GetHasCode detection is relevant for methods
8725 (MethodData.Define): Don't assume that public event implements an
8726 interface automatically.
8727 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8729 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8730 (FieldMember): Merged with FieldBase.
8731 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8732 event extern modifier can be used.
8733 (EventField.EventFieldAccessor): Moved event field specific code here.
8734 (Event.AllowedModifiers): Even event can be extern.
8735 (Event.FindOutBaseMethod): New override specific to events.
8736 (Indexer.parameters): Reintroduce parameters because base class holds
8737 only properties common data.
8738 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8739 need do extra parameters check.
8741 * const.cs: Update after FieldMember rename.
8743 * decl.cs (MemberCache.FindBaseEvent): New method.
8745 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8746 to reflect that indexer is now derived from PropertyBased.
8748 * ecore.cs (GetMemberType): Made public.
8749 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8752 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8754 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8755 (RegisterEvent): Removed.
8756 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8757 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8759 2007-01-11 Raja R Harinath <rharinath@novell.com>
8762 * statement.cs (CollectionForeach.TryType): Prefer generic
8763 GetEnumerator over non-generic variant. Fix code to follow comments.
8765 2007-01-09 Raja R Harinath <rharinath@novell.com>
8768 * support.cs (ReflectionParameter): Don't use an invalid index on
8769 the generic parameter data.
8771 2007-01-08 Miguel de Icaza <miguel@novell.com>
8773 * driver.cs: Just add a tiny bit of infrastructure.
8775 2007-01-02 Marek Safar <marek.safar@gmail.com>
8777 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8778 where field type is struct from current assembly.
8780 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8783 2007-01-02 Marek Safar <marek.safar@gmail.com>
8785 A fix for bug #80381
8786 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8789 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8791 (Namespace.LookupType): Always use core types from corlib when speficied.
8793 * report.cs: A new warning.
8795 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8796 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8797 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8799 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8800 (InitCoreTypes): Set expression type of object_type and value_type
8801 immediately after lookup.
8803 2007-01-01 Miguel de Icaza <miguel@novell.com>
8805 * cs-tokenizer.cs: Accept Pc class characters (Connector
8806 Punctuation) as valid identifiers. Fixes #78259
8808 * expression.cs (Invocation.DoResolve): Moved the check for the
8809 use of `this' for doing method calls to the Invocation resolution
8810 step, after overload resolution has taken place instead of doing
8811 the check at the low-level `This.DoResolve' level.
8813 The `This.DoResolve'(appens before overload resolution, so it has
8814 no way of knowing if the method that will be called will be
8815 instace or static, triggering an erroneous report for cs0188 (Bug
8818 We now do the check for instance method invocations after we know
8819 what method will be called.
8821 (This.CheckThisUsage): Move the actual use of this structure
8822 checking into its own method and expose it.
8824 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8827 Exceptions: Null.ConvertImplicitly,
8828 Constant.ImplicitConversionRequired as there are too many call
8829 sites for passing the ec.
8831 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8832 EmitContext, if the value is null, then we do not try to provide
8833 the extra information from the error (If a userdefined conversion
8834 exists, as UserDefinedConversion requires a non null-EmitContext).
8838 2006-12-30 Raja R Harinath <rharinath@novell.com>
8840 * flowanalysis.cs (MyBitVector): Document some invariants.
8841 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8842 introduced below, and add a couple of others,
8844 2006-12-30 Marek Safar <marek.safar@gmail.com>
8846 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8847 GetPropertyFromAccessor and GetEventFromAccessor.
8849 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8850 overrides non-obsolete one.
8851 (Indexer.Define): Error message has been moved to the parser.
8853 * cs-parser.jay: Better syntax errors handling.
8855 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8856 when an invocation has no arguments.
8858 * ecore.cs: Removed not used caching.
8860 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8863 * report.cs: Add a new warning.
8865 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8867 * typemanager.cs (enumeration_type): Removed.
8868 (CSharpSignature): Reuses IsSpecialMethod.
8869 (IsEqual): Hack for MS BCL.
8870 (GetPropertyFromAccessor): New method.
8871 (GetEventFromAccessor): New method.
8872 (IsSpecialMethod): Fixed to handle more cases.
8874 2006-12-30 Marek Safar <marek.safar@gmail.com>
8876 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8877 Made white spaces array static.
8879 * ecore.cs (RemoveGenericArity): Optimized.
8881 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8883 (MyBitVector.initialize_vector): Simplified.
8885 2006-12-22 Miguel de Icaza <miguel@novell.com>
8887 * ecore.cs: Am not entirely happy with this hack, but it seems to
8888 address the issue in 80257 (a small test case for
8891 I set the MethodGroupExpr.Type to an internal compiler type
8892 (itself in this case) to force the resolution to take place. Why
8893 it does not take place with a null is beyond me.
8895 2006-12-20 Marek Safar <marek.safar@gmail.com>
8897 A fix for bug #80288
8898 * expression.cs (ResolveOperator): Consider user defined conversion for
8899 logical and operator too.
8900 (EmitBranchable): Optimization for logical and when full constant folding
8901 could not be applied but one operand is constant.
8903 2006-12-19 Marek Safar <marek.safar@gmail.com>
8905 * class.cs (GetClassBases): Write 5 times every day, will never use
8906 FullName for error reporting.
8908 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8910 2006-12-19 Martin Baulig <martin@ximian.com>
8912 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8913 the symbol file info here.
8915 2006-12-18 Marek Safar <marek.safar@gmail.com>
8917 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8918 of `elseif' is taking then following sections are not taking.
8919 Fixes an issue reported on mono mailing list.
8921 2006-12-18 Marek Safar <marek.safar@gmail.com>
8923 A fix for bug #80300
8924 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8925 a caller is not taking.
8927 2006-12-18 Raja R Harinath <rharinath@novell.com>
8929 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8930 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8931 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8932 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8933 * class.cs: Update to changes.
8935 2006-12-17 Marek Safar <marek.safar@gmail.com>
8937 A fix for bug #79934
8938 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8941 * class.cs (ResolveMembers): Register an iterator in current container and
8944 2006-12-16 Raja R Harinath <rharinath@novell.com>
8947 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8948 satisfy a params annotated parameter.
8950 2006-12-16 Marek Safar <marek.safar@gmail.com>
8952 A fix for bug #77014
8953 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8954 paramters correctly and not rely on hacks in Parameters class.
8955 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8957 (Invocation.VerifyArgumentsCompat): Ditto.
8958 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8961 * parameter.cs (HasParams): Don't assume that params is the last one.
8963 * support.cs (ReflectionParameters.ctor): Look for params attribute
8965 (ReflectionParameters.ParameterType): Removed hack when we returned last
8966 parameter for out of range parameters.
8967 (ParameterName, ParameterModifier): Ditto.
8969 2006-12-14 Marek Safar <marek.safar@gmail.com>
8971 A fix for bug #79987
8972 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8973 when assembly is not CLS compliant but type is. I have no idea why is this
8976 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8978 2006-12-13 Miguel de Icaza <miguel@novell.com>
8980 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8981 in struct constructors, they are basically no-ops.
8983 2006-12-12 Marek Safar <marek.safar@gmail.com>
8985 * cs-tokenizer.cs (Position): Save preprocessor status too.
8987 2006-12-12 Marek Safar <marek.safar@gmail.com>
8989 A fix for bug #77794
8990 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8992 2006-12-12 Marek Safar <marek.safar@gmail.com>
8994 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8996 (pp_expr): Report error for an invalid expression.
8997 (handle_preprocessing_directive): Simplified; add more error checking.
8999 2006-12-11 Marek Safar <marek.safar@gmail.com>
9001 A fix for bug #74939
9002 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9003 directives handling.
9005 2006-12-10 Marek Safar <marek.safar@gmail.com>
9007 A fix for bugs #80093, and #75984
9008 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9009 logic, it seems to me as it worked before "by coincidence".
9010 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9011 (cleanup): Enabled endif check.
9013 2006-12-09 Marek Safar <marek.safar@gmail.com>
9015 A fix for bug #80162
9016 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9017 enumerators are never ambiguous.
9019 2006-12-08 Raja R Harinath <rharinath@novell.com>
9022 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9024 2006-12-06 Marek Safar <marek.safar@gmail.com>
9026 A fix for bug #80144
9027 * class.cs (EventProperty.Define): Explicit implementation means
9028 that an even is used.
9030 2006-12-06 Marek Safar <marek.safar@gmail.com>
9032 Fixes the operators implementation (part II)
9034 * cfold.cs (DoConstantNumericPromotions): Renamed to
9035 DoBinaryNumericPromotions and simplified.
9036 (BinaryFold): Couple of conversion fixes; simplified.
9038 * constant.cs, ecore.cs, literal.cs
9039 (ToType): Renamed to ConvertImplicitly.
9040 (Reduce): Renamed to ConvertExplicitly.
9042 * class.cs, convert.cs: Updated.
9044 * expression.cs: TryReduce doesn't throw an exception.
9046 2006-12-01 Marek Safar <marek.safar@gmail.com>
9048 A fix for bug #80108
9049 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9052 2006-11-30 Marek Safar <marek.safar@gmail.com>
9054 Fixes unary operators implementation (part I)
9057 * cfold.cs (Error_CompileTimeOverflow): Made internal
9059 * const.cs (IConstant): Changed to use reference to constant and
9060 not constant itself.
9061 Updated IConstant implementations.
9063 * constant.cs (CreateConstant): New factory method.
9064 Updated IConstant implementation.
9066 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9068 * ecore.cs: Updated to use CreateConstantReference.
9070 * enum.cs: Reflects IConstant changes.
9072 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9074 * literal.cs (NullConstant): Change to be independently usable.
9076 2006-11-29 Martin Baulig <martin@ximian.com>
9078 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9079 we need to emit the scope initializer before calling the base .ctor.
9081 * anonymous.cs: Merged back from the new anonymous methods branch.
9082 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9084 * expression.cs (ParameterReference.DoResolveBase): Create a
9085 "normal" ScopeInfo when capturing parameters rather than using the
9086 root scope; this makes things work with anonymous methods having
9090 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9092 2006-11-22 Marek Safar <marek.safar@gmail.com>
9094 A fix for bug #79987
9095 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9096 check to a base class.
9097 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9098 only when assembly has missing attribute.
9099 * report.cs: Update.
9101 2006-11-21 Marek Safar <marek.safar@gmail.com>
9103 * cs-tokenizer.cs: Merged with gmcs version.
9105 2006-11-20 Marek Safar <marek.safar@gmail.com>
9108 * cs-parser.jay: Better error message when partial keyword is misplaced.
9110 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9112 A fix for bug #79810
9113 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9114 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9115 a RuntimeWrappedException by default.
9117 2006-11-18 Marek Safar <marek.safar@gmail.com>
9119 A fix for bug #79843
9120 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9122 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9124 2006-11-18 Marek Safar <marek.safar@gmail.com>
9126 * driver.cs, namespace.cs: Uses faster IndexOf version.
9128 2006-11-17 Marek Safar <marek.safar@gmail.com>
9130 A fix for bug #79941
9131 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9133 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9134 even if internal name is different.
9135 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9136 (UserDefinedConversion): Simplified as the operators cannot be internal.
9137 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9139 (MethodLookup): Replaced EmitContext with parentType.
9140 * expression.cs: Updated.
9142 2006-11-09 Raja R Harinath <rharinath@novell.com>
9144 * driver.cs (BadAssembly): Handle all the ugliness of
9145 DefineDynamicAssembly.
9147 2006-11-08 Raja R Harinath <rharinath@novell.com>
9149 Address parts of #58244 -- most of what's left is in the runtime
9150 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9151 CS1509 error checks, and handle them for all assembly loads, not
9152 just the first invocation.
9153 (LoadModule): Likewise. Move handling of 'adder_method' ...
9154 * codegen.cs (AssemblyClass.AddModule): ... here.
9156 2006-11-02 Marek Safar <marek.safar@gmail.com>
9158 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9159 IEnumerable<T> is ambiguous.
9161 2006-10-31 Marek Safar <marek.safar@gmail.com>
9163 A fix for bug #67689
9164 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9165 GetEnumerator is ambiguous.
9167 * report.cs: Add new warning.
9169 2006-10-29 Marek Safar <marek.safar@gmail.com>
9171 A fix for bug #78602
9172 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9173 to protected member can be nested type.
9175 2006-10-28 Marek Safar <marek.safar@gmail.com>
9177 A fix for bug #78965
9178 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9179 to protected member must derive from current type.
9181 2006-10-27 Marek Safar <marek.safar@gmail.com>
9183 assign.cs: Reuses error method.
9185 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9186 instead of type for constants.
9187 (Expression.Error_ValueAssignment): Common error method.
9189 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9192 2006-10-27 Marek Safar <marek.safar@gmail.com>
9194 A fix for bug #79081
9195 * expression.cs (MemberAccess.DoResolve): Check nested type
9198 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9200 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9202 2006-10-26 Marek Safar <marek.safar@gmail.com>
9204 A fix for bug #76591
9205 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9207 2006-10-26 Marek Safar <marek.safar@gmail.com>
9209 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9210 type forwarder of the same type multiple times.
9212 2006-10-26 Raja R Harinath <rharinath@novell.com>
9215 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9216 instance as an rvalue, even when we later resolve as an lvalue.
9218 2006-10-25 Martin Baulig <martin@ximian.com>
9220 * anonymous.cs: Fix #79673.
9222 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9224 A fix for bug #79666
9225 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9226 ignored when is optimized (= default value) as its value is already set.
9228 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9230 A fix for bug #79724
9231 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9232 TypeContainer for type lookup.
9234 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9236 A fix for bug #79231
9237 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9238 * expression.cs (OverloadResolve): Always convert type name for
9240 (ResolveNamespaceOrType): Don't confuse a nested type with any
9243 2006-10-18 Martin Baulig <martin@ximian.com>
9245 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9247 2006-10-17 Miguel de Icaza <miguel@novell.com>
9249 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9250 an int32, but requesting an int64 from the conversion
9252 2006-10-12 Martin Baulig <martin@ximian.com>
9255 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9257 2006-10-12 Martin Baulig <martin@ximian.com>
9260 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9262 2006-10-11 Miguel de Icaza <miguel@novell.com>
9264 * convert.cs: Remove broken code: I was doing the "Existance"
9265 tests for Implicit conversions.
9267 2006-10-10 Miguel de Icaza <miguel@novell.com>
9269 * convert.cs: Added one missing case in
9270 ImplicitStandardConversionExists uint64 to intptr.
9274 * typemanager.cs (uintptr_type): another core known type.
9276 * ecore.cs (OperatorCast): routine used to do cast operations that
9277 depend on op_Explicit. We could change some of the Decimal
9278 conversions to use this.
9280 This one has a probe mechanism that checks both types for an op_
9281 which it coudl be used to eliminate two classes: CastToDecimal
9282 and CastFromDecimal.
9284 * convert.cs: Implement the conversions documented in #59800
9286 2006-10-10 Martin Baulig <martin@ximian.com>
9288 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9289 before RootScope.ResolveMembers().
9291 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9292 `CurrentType' if appropriate.
9294 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9296 A fix for bug #78568
9297 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9298 when contains binary operators.
9299 * cs-parser.jay: Updated.
9301 2006-10-09 Martin Baulig <martin@ximian.com>
9304 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9305 moved that into Define() and also do the other type parameter
9306 checks there. Fixes #79094. Added gtest-292.cs.
9309 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9310 since that doesn't include type parameters; don't use `Ldelema'
9311 for type parameters. Fixes #78980. Added gtest-293.cs.
9313 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9316 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9317 conversion is allowed.
9319 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9321 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9322 error reporting when no error occurs.
9324 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9326 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9329 2006-10-06 Raja R Harinath <rharinath@novell.com>
9332 * class.cs (DefineTypeBuilder): Check circular dependencies before
9333 setting the parent of the TypeBuilder.
9334 (CheckRecursiveDefinition): Don't use 'BaseType', since
9335 it may not be valid until after DefineTypeBuilder. Use
9336 'base_type' instead.
9338 2006-10-04 Martin Baulig <martin@ximian.com>
9340 Merged the Anonymous Methods patch.
9342 * anonymous.cs, iterators.cs: The new anonymous methods code.
9344 * statement.cs (Variable): New public abstract class.
9345 (LocalInfo.Variable): New public property.
9346 (LocalInfo.ResolveVariable): New public method.
9347 (Block.Flags): Add `IsIterator'.
9348 (Block.AddVariable): Improved the CS0136 check.
9349 (Block.AnonymousChildren): New public property.
9350 (Block.AddAnonymousChild): New public method.
9351 (ToplevelBlock): Update to use the new anonymous method framework.
9352 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9353 `ToplevelBlock'; this is required to correctly implement the
9355 (Fixed, Using): Use `TemporaryVariable' instead of directly
9356 creating the `LocalBuilder'.
9358 * parameter.cs (Parameter.ResolveVariable): New public method.
9359 (Parameters.ResolveVariable): Likewise.
9361 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9363 * class.cs (TypeContainer): Replaced the `iterators' list and
9364 corresponding methods with a list of `CompilerGeneratedClass'es.
9365 (TypeContainer.ResolveMembers): New public method.
9366 (Method): `IIteratorContainer' has been replaced by
9369 * expression.cs (VariableReference): New public abstract base
9370 class for `LocalVariableReference', `ParameterReference' and
9373 * codegen.cs (EmitContext): Removed `capture_context',
9374 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9375 (EmitContext.EmitThis): Removed.
9377 * cs-parser.jay: Replace `iterator_container' with
9380 2006-10-04 Martin Baulig <martin@ximian.com>
9382 * generic.cs (GenericMethod): Don't make this abstract.
9383 (Constraints.Clone): Added dummy implementation.
9385 2006-10-04 Raja R Harinath <harinath@gmail.com>
9388 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9389 'declspaces'. Avoid allocating arrays willy-nilly.
9392 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9393 cases out of the switch.
9395 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9397 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9398 message when non-generic type is used with the type arguments.
9399 * expression.cs: Updated.
9401 2006-09-28 Raja R Harinath <rharinath@novell.com>
9404 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9405 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9406 Change semantics slightly. Don't insist on having only one
9407 temporary EmptyExpression -- just throttle the creation of new ones.
9410 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9411 non-interfaces too. If no methods are found, don't try to create
9414 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9416 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9419 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9420 us produce better error message.
9422 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9424 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9425 of the `|' operator.
9427 * report.cs: A new warning added.
9429 2006-09-27 Martin Baulig <martin@ximian.com>
9431 * generic.cs (GenericMethod): Don't make this abstract.
9433 2006-09-27 Martin Baulig <martin@ximian.com>
9436 (InternalErrorException): Added overloaded ctor taking a params array.
9438 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9440 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9441 Fixed the cases when same error was reported twice.
9443 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9444 now report symbol information.
9446 2006-09-25 Martin Baulig <martin@ximian.com>
9448 * class.cs: Completely unified with the gmcs version.
9450 2006-09-25 Martin Baulig <martin@ximian.com>
9452 * typemanager.cs (TypeManager.IsNullableType): New public function.
9453 (TypeManager.IsNullableTypeOf): Likewise.
9454 (TypeManager.IsNullableValueType): Likewise.
9456 * class.cs (MethodCore): Added the `GenericMethod' argument from
9457 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9459 2006-09-24 Raja R Harinath <harinath@gmail.com>
9461 * convert.cs: Unify with gmcs version.
9463 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9465 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9466 verify them as well.
9468 * report.cs: New warning.
9470 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9472 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9473 for anonymous block with out argument.
9475 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9477 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9478 not used private events only.
9480 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9482 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9484 * const.cs (Const.Define): Check for constant type.
9485 (Const.IsConstantTypeValid): Looks for valid constant types.
9487 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9489 * ecore.cs (EmptyConstantCast): New common class for all constant based
9492 * expression.cs (Is.DoResolve): Handle null constant especially.
9493 (New.DoResolve): Check for new void().
9494 (MemberAccess.DoResolve): Cope with all kind of nulls.
9496 * literal.cs (NullConstant): Uses EmptyConstantCast.
9497 (NullDefault): Based on EmptyConstantCast.
9498 (NullLiteral): Uses EmptyConstantCast.
9500 * statement.cs (Block.ResolveMeta): Check for constant type.
9502 2006-09-22 Martin Baulig <martin@ximian.com>
9504 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9506 2006-09-22 Raja R Harinath <rharinath@novell.com>
9508 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9512 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9513 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9516 2006-09-22 Martin Baulig <martin@ximian.com>
9518 * ecore.cs: Merged with the gmcs version.
9520 * generic.cs (ConstructedType): New dummy class.
9521 (TypeArguments): Don't make this abstract.
9524 (TypeManager.IsGenericTypeDefinition): New method.
9525 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9527 2006-09-22 Raja R Harinath <rharinath@novell.com>
9529 * expression.cs (ComposedCast): Check for arrays of TypedReference
9530 before creating the type, not after.
9532 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9534 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9535 after ToType change.
9537 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9538 when constant must be implicitly convertible.
9540 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9542 * ecore.cs (NullCast): Derives from NullConstant.
9544 * expression.cs (Is.DoResolve): Removed useless variables.
9545 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9546 (New.Constantify): Add enum support.
9547 (MemberAccess.DoResolve): Add warning when accessing null constant or
9550 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9553 * literal.cs (NullConstant): New abstract class with common
9554 functionality for all null specializations.
9555 (NullDefault): Represents default(X) when result can be
9557 (NullLiteral): Updated.
9559 * report.cs: Add new warning.
9561 2006-09-21 Martin Baulig <martin@ximian.com>
9563 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9565 2006-09-21 Martin Baulig <martin@ximian.com>
9567 * generic.cs (GenericConstraints): New dummy class.
9568 (Constraints): Likewise.
9569 (TypeParameter): Likewise.
9570 (TypeParameterName): Likewise.
9571 (GenericMethod): Likewise.
9573 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9575 * decl.cs: Merged with the gmcs version.
9577 2006-09-21 Raja R Harinath <rharinath@novell.com>
9579 * generic.cs (TypeParameter): Implement IMemberContainer.
9580 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9582 * rootcontext.cs: Unify with gmcs version.
9584 * report.cs: Unify with gmcs version.
9585 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9586 from gmcs/generics.cs.
9587 * generics.cs (TypeParameter): New dummy class.
9589 * support.cs: Unify with gmcs version.
9591 2006-09-20 Raja R Harinath <rharinath@novell.com>
9593 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9594 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9596 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9597 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9598 * mcs.exe.sources: Add generic.cs.
9600 * codegen.cs: Unify with gmcs version.
9602 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9603 (EmitContext): Add GenericDeclContainer implementation.
9604 * decl.cs (MemberCore, DeclSpace): Likewise.
9605 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9607 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9608 MCS TypeManager has a corresponding dummy method.
9610 2006-09-19 Martin Baulig <martin@ximian.com>
9612 * expression.cs: Completely merged with the gmcs version.
9614 2006-09-19 Martin Baulig <martin@ximian.com>
9616 * expression.cs (Invocation): Merged with the gmcs version.
9617 (ArrayAccess.GetStoreOpcode): Likewise.
9619 2006-09-19 Martin Baulig <martin@ximian.com>
9622 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9623 (TypeManager.IsGenericMethodDefinition): Likewise.
9625 2006-09-19 Martin Baulig <martin@ximian.com>
9628 (TypeManager.IsEqual): Moved the gmcs implementation here.
9629 (TypeManager.DropGenericTypeArguments): Likewise.
9630 (TypeManager.DropGenericMethodArguments): Likewise.
9631 (TypeManager.GetTypeArguments): Moved here from gmcs.
9632 (TypeManager.HasGenericArguments): Likewise.
9634 2006-09-19 Martin Baulig <martin@ximian.com>
9636 * expression.cs (Binary): Merged with the gmcs version.
9638 2006-09-19 Martin Baulig <martin@ximian.com>
9640 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9642 2006-09-19 Martin Baulig <martin@ximian.com>
9644 * typemanager.cs: Merged with the gmcs version.
9646 2006-09-16 Raja R Harinath <rharinath@novell.com>
9648 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9649 * driver.cs: Likewise.
9651 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9654 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9655 only if parent type is class.
9656 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9659 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9662 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9664 * typemanager.cs(CSharpName): Converts NullType to null.
9666 2006-09-15 Martin Baulig <martin@ximian.com>
9669 (TypeManager.GetMethodName): Added mcs implementation.
9670 (TypeManager.IsEqual): Likewise.
9673 (SimpleName.RemoveGenericArity): Added dummy implementation.
9675 * pending.cs: Merged with the gmcs version.
9677 2006-09-15 Martin Baulig <martin@ximian.com>
9679 * statement.cs: Merge with the gmcs version.
9681 2006-09-15 Martin Baulig <martin@ximian.com>
9683 * statement.cs (Switch): Merge with the gmcs implementation
9684 (without nullables), which is newer.
9686 2006-09-15 Martin Baulig <martin@ximian.com>
9688 * statement.cs (Block.Variables): Make this public.
9689 (ToplevelBlock.Parameters): Make this a property.
9690 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9692 2006-09-15 Martin Baulig <martin@ximian.com>
9694 * namespace.cs: Merge with the gmcs version.
9696 2006-09-15 Martin Baulig <martin@ximian.com>
9698 * decl.cs (MemberName): Minor code cleanups.
9700 2006-09-15 Martin Baulig <martin@ximian.com>
9702 * parameter.cs: Merge with the gmcs version.
9704 2006-09-15 Martin Baulig <martin@ximian.com>
9706 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9707 and an error in mcs.
9709 2006-09-15 Martin Baulig <martin@ximian.com>
9711 * flowanalysis.cs: Merged from GMCS; added the generics code into
9712 a `GMCS_SOURCE' conditional so we can share this file.
9714 2006-09-08 Martin Baulig <martin@ximian.com>
9716 * typemanager.cs (TypeManager.interlocked_type): New public field.
9717 (TypeManager.int_interlocked_compare-exchange): New public field.
9718 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9719 enumerator types here and call InitGenericCoreTypes().
9720 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9721 after calling InitEnumUnderlyingTypes().
9724 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9725 `classes_second_stage'.
9727 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9729 * assign.cs, ecore.cs, expression.cs: Share error message text.
9730 * class.cs (FieldMember.Define): Check for varible of static type.
9731 * driver.cs (LoadAssembly): Uses error output for errors.
9732 * statement.cs: Updated.
9734 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9736 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9739 2006-09-07 Martin Baulig <martin@ximian.com>
9742 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9744 2006-08-29 Miguel de Icaza <miguel@novell.com>
9746 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9748 2006-08-17 Miguel de Icaza <miguel@novell.com>
9750 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9751 #52019 and #79064, the use of the \uXXXX sequence in source code
9752 to represent unicode characters.
9754 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9756 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9758 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9760 2006-08-13 Miguel de Icaza <miguel@novell.com>
9762 * assign.cs: Catch attempts to assign to a method groups in += and
9765 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9768 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9770 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9772 * class.cs (Method.Define): Issue a warning when generic method looks like
9774 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9777 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9779 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9781 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9782 search all base interfaces as a member can be ambiguous.
9783 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9784 Constructor member type filter.
9785 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9786 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9787 reporting for returned memberinfos.
9788 * report.cs: Updated.
9789 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9790 version to work on all runtimes.
9791 (TypeManager.RealMemberLookup): Removed members filtering.
9793 2006-08-08 Raja R Harinath <rharinath@novell.com>
9795 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9796 (PropertyExpr.EmitAssign): Likewise.
9797 * expression.cs (Indirection.EmitAssign): Likewise.
9798 (LocalVariableReference.EmitAssign): Likewise.
9799 (ParameterReference.EmitAssign): Likewise.
9800 (Invocation.EmitArguments): Likewise.
9801 (ArrayAccess.EmitAssign): Likewise.
9802 (IndexerAccess.EmitAssign): Likewise.
9803 (This.EmitAssign): Likewise.
9804 (ConditionalLogicalOperator.Emit): Likewise.
9807 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9808 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9809 leave it in after returning it.
9810 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9812 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9814 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9817 2006-08-03 Raja R Harinath <rharinath@novell.com>
9819 Fix cs0146-3.cs and cs0146-4.cs.
9820 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9821 enclosing types don't depend on the current type.
9823 2006-08-02 Raja R Harinath <rharinath@novell.com>
9826 * class.cs (TypeContainer.DoDefineMembers): Use
9827 FindBaseMemberWithSameName on Parent, since we're interested in
9828 whether we hide inherited members or not.
9829 (FindBaseMemberWithSameName): Make slightly more robust.
9831 Fix the non-generic testcase from #77396
9832 * decl.cs (DeclSpace.DeclContainer): Remove override.
9834 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9835 declspaces for doppelgangers too.
9836 (UsingEntry): Implement IResolveContext.
9837 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9838 'this' as the resolve context.
9839 (LocalAliasEntry): Likewise.
9841 Implement parts of #77403
9842 * roottypes.cs (RootDeclSpace): New. Used to represent the
9843 toplevel declaration space. Each namespace declaration introduces
9844 a "partial" root declaretion space.
9845 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9846 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9847 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9848 from 'current_namespace.SlaveDeclSpace'.
9849 (namespace_declaration): Likewise.
9850 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9851 check. It can't happen now.
9852 * decl.cs (DeclSpace.LookupType): Likewise.
9853 * driver.cs (MainDriver): Sanity check.
9855 2006-08-01 Raja R Harinath <rharinath@novell.com>
9857 * decl.cs (DeclSpace.FindNestedType): Remove.
9858 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9859 LookupTypeContainer to get the container of the nested type.
9860 * class.cs (TypeContainer.FindNestedType): Make non-override.
9862 2006-07-31 Raja R Harinath <rharinath@novell.com>
9864 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9865 * class.cs (TypeContainer.PartialContainer): ... here.
9866 (TypeContainer.AddBasesForPart): New helper.
9867 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9869 * cs-parser.jay (current_class): Convert to DeclSpace.
9870 (struct_declaration, interface_declaration, class_declaration):
9871 Use AddBasesForPart instead of .Bases directly.
9872 * const.cs, iterators.cs: Update to changes.
9874 2006-07-28 Raja R Harinath <rharinath@novell.com>
9876 * class.cs (TypeContainer.AddMemberType): Rename from
9878 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9879 (AddTypeContainer): New. Combine AddClassOrStruct and
9881 (AddPartial): Update. Add 'is_partial' argument.
9882 * roottypes.cs: Update to changes.
9883 * cs-parser.jay (push_current_class): New helper for handling
9884 current_container and current_class.
9885 (struct_declaration, interface_declaration, class_declaration):
9888 2006-07-26 Raja R Harinath <rharinath@novell.com>
9890 * roottypes.cs: Rename from tree.cs.
9892 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9893 * tree.cs (Tree, ITreeDump): Remove types.
9894 * rootcontext.cs (tree, Tree): Remove fields.
9895 (root, ToplevelTypes): New.
9896 * *.cs: Update to rename.
9898 * tree.cs (Tree.RecordDecl): Remove.
9899 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9901 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9903 2006-07-23 Raja R Harinath <harinath@gmail.com>
9905 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9906 DoFlowAnalysis and OmitStructFlowAnalysis here.
9907 (ec.With): Rename from WithUnsafe and generalize.
9908 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9909 (ec.WithFlowAnalyis): New.
9910 * ecore.cs, expression.cs, statement.cs: Update.
9912 2006-07-22 Raja R Harinath <harinath@gmail.com>
9914 * statement.cs (Block.ResolveMeta): Simplify slightly.
9916 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9917 multiple boolean fields. Convert InUnsafe, constant_check_state,
9918 check_state to flags.
9919 (CheckState, ConstantCheckState): Update.
9920 (InUnsafe): New read-only property.
9921 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9923 (WithUnsafe): New helper similar to WithCheckState.
9924 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9925 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9927 2006-07-21 Raja R Harinath <rharinath@novell.com>
9929 Make comparisons use the same IL irrespective of whether they're
9930 in a 'checked' or 'unchecked' context: one of the issues in #78899
9931 * codegen.cs (EmitContext.CheckState): Make read-only property.
9932 (EmitContext.ConstantCheckState): Likewise.
9933 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9934 helper that implement a save/restore stack for CheckState
9935 values. This is the only way to change check-state.
9936 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9937 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9938 (CheckedExpr.EmitBranchable): New forwarding method.
9939 (UnCheckedExpr): Likewise.
9940 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9941 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9942 (Checked.Resolve, checked.DoEmit): Likewise.
9944 2006-07-20 Miguel de Icaza <miguel@novell.com>
9946 * anonymous.cs: Cache the resolved anonymous delegate, and return
9947 this so that the ResolveTopBlock is only triggered once, not
9950 Currently we trigger ResolvetopBlock twice due to a first pass of
9951 argument check compatibility, and a second pass that does the
9954 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9956 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9958 * rootcontext.cs (Reset): Add helper_classes.
9960 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9963 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9966 2006-07-13 Miguel de Icaza <miguel@novell.com>
9968 * statement.cs (Lock): Handle expressions of type
9969 TypeManager.null_type specially. Fixes #78770
9971 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9973 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9976 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9978 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9979 for accessors as well.
9980 * ecore.cs (EventExpr): Add AccessorTable.
9982 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9985 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9986 for CS0122 where appropriate.
9987 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9989 (Filter): Assembly can be null in the case of top level attributes.
9991 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9995 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9996 is done at global level.
9998 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10000 A fix for #77002, Implemented TypeForwarder support.
10002 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10003 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10004 * typemanager.cs (): Add type_forwarder_attr_type.
10006 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10008 * report.cs: Add CS0469 warning.
10010 2006-06-21 Martin Baulig <martin@ximian.com>
10012 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10013 the `try'-block, so we also report CS0016 etc. there.
10015 2006-06-21 Martin Baulig <martin@ximian.com>
10018 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10020 2006-06-21 Martin Baulig <martin@ximian.com>
10022 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10023 also report CS1686 for parameters.
10025 2006-06-21 Martin Baulig <martin@ximian.com>
10027 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10028 instead of an error if the value is not implicitly convertible to
10029 the switch types; fixes #77964.
10031 2006-06-21 Raja R Harinath <rharinath@novell.com>
10034 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10035 FieldBuilder is null.
10038 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10039 'left' and 'right' before error-checking.
10041 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10043 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10045 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10046 (FieldExpr.DoResolve): likewise.
10047 (PropertyExpr.InstanceResolve): likewise.
10048 (EventExpr.InstanceResolve): likewise.
10050 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10052 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10053 attribute applicable tests for attribute argument.
10055 2006-06-02 Raja R Harinath <rharinath@novell.com>
10058 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10059 (Binary.OverloadResolve_PredefinedIntegral): New.
10060 (Binary.OverloadResolve_PredefinedFloating): New.
10061 (Binary.OverloadResolve_PredefinedString): New.
10062 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10063 Follow the standard more closely, and treat numeric promotions in
10064 terms of overload resolution.
10065 (Binary.CheckShiftArguments): Simplify.
10067 2006-06-01 Raja R Harinath <rharinath@novell.com>
10069 * flowanalysis.cs (MyBitVector): Simplify representation.
10070 (MyBitVector.Clone): Avoid allocating BitArray.
10071 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10072 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10073 (*): Update. Change all references to MyBitVector.And and
10074 MyBitVector.Or to &= and |=.
10076 2006-05-29 Raja R Harinath <rharinath@novell.com>
10078 Fix cs0231-[34].cs.
10079 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10080 to param arguments too.
10082 2006-05-26 Miguel de Icaza <miguel@novell.com>
10084 * cs-parser.jay: Catch another parsing form for arglist being
10085 followed by other arguments. Fixes #78313.
10087 2006-05-24 Raja R Harinath <rharinath@novell.com>
10089 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10090 checking of out parameters to ...
10091 (FlowBranchingToplevel.Merge): ... here.
10092 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10093 set, propagate the origin upward, and only complain if there was
10095 (FlowBranchingException.AddContinueOrigin): Likewise.
10096 (FlowBranchingException.AddReturnOrigin): Likewise.
10097 (FlowBranchingException.AddGotoOrigin): Likewise.
10099 2006-05-23 Raja R Harinath <rharinath@novell.com>
10101 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10102 unreachable, skip it.
10103 (FlowBranchingException.Merge): Always propagate jumps, even if
10104 the finally block renders subsequent code unreachable.
10106 2006-05-18 Raja R Harinath <rharinath@novell.com>
10109 * statement.cs (Goto.Resolve): Move responsibility for resolving
10110 'goto' to FlowBranching.AddGotoOrigin.
10111 (Goto.SetResolvedTarget): New. Callback to set the
10112 LabeledStatement that's the target of the goto.
10113 (Goto.DoEmit): Use Leave instead of Br when crossing an
10114 unwind-protect boundary.
10115 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10116 LookupLabel and adjust to new semantics.
10117 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10118 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10119 Goto.SetResolvedTarget to update target.
10120 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10121 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10122 AddBreakOrigin & co. Delay propagation until ...
10123 (FlowBranchingException.Merge): ... this.
10125 * statement.cs (Block.Resolve): Always depend on flow-branching to
10126 determine unreachability. Kill workaround that originally emitted
10127 only one statement after an "unreachable" label (see infloop in
10130 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10131 This is still "wrong", but anything better would probably need a
10132 multi-pass algorithm.
10133 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10134 usage vector. Force current usage vector to be reachable, to
10135 optimistically signify backward jumps.
10136 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10138 (FlowBranchingLabeled.Merge): New. If no backward jump was
10139 detected, return the original salted-away usage vector instead,
10140 updated with appropriate changes. Print unreachable warning if
10142 * statement.cs (Block.Resolve): Don't print unreachable warning on
10143 a labeled statement.
10145 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10147 * driver.cs: Pass filename without path to AssemblyBuilder's
10148 AddResourceFile. Fixes bug #78407.
10150 2006-05-17 Raja R Harinath <rharinath@novell.com>
10152 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10153 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10154 (FlowBranching.MergeChild): Overwrite
10155 reachability information from Labeled branchings too.
10157 2006-05-16 Raja R Harinath <rharinath@novell.com>
10159 * statement.cs (Goto.Resolve): Merge jump origins here ...
10160 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10162 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10163 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10164 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10165 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10167 * statement.cs (Goto.Resolve): ... not here.
10168 (Goto.Emit): Remove CS1632 check.
10170 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10172 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10175 2006-05-11 Raja R Harinath <rharinath@novell.com>
10177 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10178 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10179 (FlowBranchingException.Label): Likewise.
10181 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10183 (MyBitVector.Or): Use it to avoid losing information (Count).
10184 (FlowBranching.MergeOrigins): Likewise.
10186 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10187 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10188 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10189 (UsageVector.ToString): Simplify.
10190 (UsageVector.MergeSiblings): Move here from ...
10191 (FlowBranching.Merge): ... here.
10192 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10195 2006-05-10 Raja R Harinath <rharinath@novell.com>
10197 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10198 null bitvector is treated as all-true.
10200 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10201 (MyBitVector): Rationalize invariants. 'vector != null' implies
10202 that we have our own copy of the bitvector. Otherwise,
10203 'InheritsFrom == null' implies all inherited bits are true.
10205 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10207 * statement.cs (LocalInfo): Add IsConstant.
10208 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10209 local variable for constants.
10211 2006-05-09 Raja R Harinath <rharinath@novell.com>
10213 * flowanalysis.cs (MyBitVector.Empty): New.
10214 (MyBitVector): Don't allow InheritedFrom to be null.
10215 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10216 (UsageVector, FlowBranching): Update to changes.
10218 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10219 recursion. The 'Parent == null' condition isn't sufficient for
10221 (FlowBranching.AddBreakOrigin): Likewise.
10222 (FlowBranching.AddContinueOrigin): Likewise.
10223 (FlowBranching.AddReturnOrigin): Likewise.
10224 (FlowBranching.StealFinallyClauses): Likewise.
10225 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10226 (FlowBranching.CheckOutParameters): Likewise.
10227 (FlowBranchingToplevel): Terminate all the above recursions here.
10228 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10229 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10231 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10233 (FlowBranchingToplevel): New. Empty for now.
10234 (FlowBranching.MergeTopBlock): Update.
10235 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10236 branching for the anonymous delegate.
10237 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10239 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10240 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10241 information at the start of the merge. Reorganize.
10243 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10245 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10247 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10249 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10250 to newly introduced ctor.
10252 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10253 message to one place.
10254 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10257 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10259 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10261 * ecore.cs (Expression.ResolveAsConstant): Updated.
10263 * statement.cs (ResolveMeta): Updated.
10265 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10267 * cs-parser.jay: __arglist cannot be used in initializer.
10269 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10272 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10275 2006-05-05 Raja R Harinath <rharinath@novell.com>
10277 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10278 (LabeledStatement): Add 'name' parameter.
10279 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10280 (Block.AddLabel): Update to changes.
10281 * cs-parser.jay (labeled_statement): Likewise.
10283 * flowanalysis.cs (BranchingType.Labeled): New.
10284 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10285 (FlowBranchingLabeled): New. Does nothing for now, but will
10286 eventually handle 'goto' flows.
10287 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10288 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10289 that's terminated ...
10290 (Block.Resolve): ... here.
10292 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10293 (UsageVector.MergeFinallyOrigins): Likewise.
10294 (FlowBranching.InTryOrCatch): Likewise.
10295 (FlowBranching.AddFinallyVector): Likewise.
10296 (FlowBranchingException): Update to changes.
10299 * statement.cs (Return.Resolve): Move error checking to ...
10300 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10301 (FlowBranchingException): Handle return origins like break and
10303 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10305 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10308 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10311 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10314 * class.cs (MethodData.Define): Do public accessor check only when method
10315 implements an interface.
10317 2006-05-04 Raja R Harinath <rharinath@novell.com>
10319 Remove special handling of 'break'
10320 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10321 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10322 (UsageVector.Break): Remove.
10323 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10325 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10327 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10328 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10330 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10333 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10334 be the interface member.
10336 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10339 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10340 for emitting small (int) values.
10342 2006-05-03 Raja R Harinath <rharinath@novell.com>
10345 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10346 control-flow passes through the 'finally' after merging-in all the
10347 control-flows from 'try' and the 'catch' clauses.
10349 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10350 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10351 always true at the only non-recursive entry point.
10352 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10353 FlowBranchingBreakable.
10354 (FlowBranchingLoop): Remove.
10355 * statement.cs (Return.DoResolve): Update to changes.
10358 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10359 (FlowBranching.CreateBranching): Handle it: create a
10360 FlowBranchingContinuable.
10361 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10362 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10363 except that it handles the 'continue' command.
10364 (FlowBranching.UsageVector.MergeOrigins): Rename from
10366 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10367 except that it overrides AddContinueOrigin.
10368 (FlowBranchingException): Override AddContinueOrigin, similar to
10370 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10371 Create a new branching around the embedded statement.
10372 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10373 control flow after the embedded statement.
10374 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10376 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10377 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10378 FlowBranchingBreakable.
10379 (FlowBranchingSwitch): Remove.
10382 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10383 error reporting to ...
10384 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10385 Rename from 'AddBreakVector'. Add new location argument. Return
10386 a bool indicating whether the 'break' crosses an unwind-protect.
10387 (FlowBranchingException.AddBreakOrigin): Add.
10388 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10389 flowbranching after updating with the effects of the 'finally'
10391 (FlowBranchingBreakable): New common base class for
10392 FlowBranchingLoop and FlowBranchingSwitch.
10394 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10395 embedded statement.
10396 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10398 2006-05-02 Raja R Harinath <rharinath@novell.com>
10400 * statement.cs (Do.Resolve): If the loop is infinite, set the
10402 (While.Resolve, For.Resolve): Set a barrier after the embedded
10403 statement. There's no direct control flow that goes from the end
10404 of the embedded statement to the end of the loop.
10405 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10406 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10407 above ensure that the reachability is correctly computed.
10409 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10410 (UsageVector.MergeBreakOrigins): If the current path is
10411 unreachable, treat it as if all parameters/locals are initialized.
10412 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10413 infinite loops before merging-in break origins.
10415 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10416 (Reachability.Reachable): Split part into ...
10417 (Reachability.Unreachable): ... this. Simplify.
10418 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10420 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10421 (Reachability.SetThrowsSometimes): Likewise.
10422 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10423 TriState.Always, use corresponding property.
10424 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10425 (Block.Resolve): Likewise. Remove some redundant checks.
10427 2006-05-02 Raja R Harinath <harinath@gmail.com>
10429 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10430 (Reachability.Meet): Don't bother checking AlwaysThrows --
10431 barrier is always set.
10432 (FlowBranchingBlock.Merge): Likewise.
10434 2006-05-01 Raja R Harinath <harinath@gmail.com>
10436 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10437 checks for unreachable.
10439 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10442 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10444 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10445 whether field is really assigned.
10447 2006-04-30 Raja R Harinath <harinath@gmail.com>
10449 * flowanalysis.cs (Reachability): Make 4-argument constructor
10451 (Reachability.Meet): Rename from 'And'. Remove static variant.
10452 (Reachability.Always): Rename from the highly misleading
10453 'Reachability.Never'.
10454 (FlowBranching.Merge): Update to changes. Mark an impossible
10455 situation with a 'throw'.
10456 (*): Update to changes.
10458 2006-04-29 Raja R Harinath <harinath@gmail.com>
10460 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10461 Remove 'Undefined'.
10462 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10463 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10464 (*): Update to changes.
10465 * statement.cs: Update to changes.
10467 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10470 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10472 2006-04-28 Raja R Harinath <harinath@gmail.com>
10474 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10477 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10478 argument to two arguments: an usage-vector and a bool. Move call
10479 to FlowBranching.Merge () ...
10480 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10482 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10483 handling of loop and switch reachability to ...
10484 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10486 2006-04-27 Raja R Harinath <harinath@gmail.com>
10488 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10489 handling to FlowBranchingLoop.InLoop.
10490 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10492 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10495 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10496 anonymous method is allowed from AnonymousContainer here.
10498 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10500 2006-04-24 Raja R Harinath <rharinath@novell.com>
10503 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10505 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10508 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10509 (DoubleConstant.Reduce): Ditto.
10511 2006-04-23 Raja R Harinath <rharinath@novell.com>
10513 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10514 Remove 'lvalue_right_side' argument. Move parts to ...
10515 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10516 (LocalVariable.DoResolveLValue): ... these.
10518 2006-04-21 Raja R Harinath <rharinath@novell.com>
10521 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10522 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10523 (LocalVariableReference.DoResolveBase): Use it to implement new
10525 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10526 (Argument.Resolve): Simplify. Move CS1510 check ...
10527 * ecore.cs (Expression.ResolveLValue): ... here.
10528 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10529 (PropertyExpr.DoResolveLValue): Likewise.
10530 (FieldExpr.Report_AssignToReadonly): Likewise.
10531 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10532 LValueMemberAccess or LValueMemberOutAccess on instance depending
10534 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10535 DoResolve as appropriate.
10537 2006-04-20 Raja R Harinath <rharinath@novell.com>
10540 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10541 implicit conversions on 'out' and 'ref' arguments.
10543 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10544 improve clarity. Remove dead code.
10547 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10548 (Catch.Resolve): Resolve VarBlock if it exists.
10550 2006-04-19 Miguel de Icaza <miguel@novell.com>
10552 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10553 twice, this was some residual code, the enumerator was emitted
10554 properly in the two branche of if later.
10556 2006-04-19 Raja R Harinath <rharinath@novell.com>
10558 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10559 cast is never an lvalue.
10560 (Cast.DoResolve, Cast.ResolveRest): Combine.
10561 (Argument.Emit): Simplify slightly. Move 'Expr is
10562 IMemoryLocation' check ...
10563 (Argument.Resolve): ... here.
10564 (Argument.Error_LValueRequired): Remove. Inline into only user.
10566 Simplifications. Fix cs0191-2.cs
10567 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10568 CS1649 and CS1651 to ...
10569 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10570 the actual selection of the error code and message to a lookup
10571 table. Add a dummy return value to simplify callsites.
10572 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10573 readonly fields of other instances of the same type. Move CS0197
10575 * expression.cs (Argument.Resolve): ... here. Simplify code.
10576 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10577 resolution of an out or ref argument. The code simplification
10578 above uses this invariant.
10580 2006-04-18 Raja R Harinath <rharinath@novell.com>
10582 Possibly fix #77752. Fix cs1690-[4-7].cs.
10583 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10584 CheckMarshallByRefAccess. Drop parameter.
10585 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10587 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10588 InstanceExpression.
10589 * report.cs (AllWarnings): Add CS1690.
10590 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10591 for ref access too.
10592 (LocalVariableReference.DoResolveBase): Update.
10594 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10596 * class.cs (MethodOrOperator): Moved common parts from method class.
10597 detect obsolete attributes.
10598 (Method.Define): Simplified as it reuses code from base.
10599 (Constructor.ValidAttributeTargets): Fixed issue found during
10601 (Destructor.ValidAttributeTargets): Fixed issue found during
10603 (Operator): Finished refactoring set off by #78020. Operator class is now
10604 ordinary method class.
10606 * anonymous.cs: Updated.
10608 * decl.cs (DeclSpace): Add IsGeneric
10610 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10612 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10614 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10616 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10617 detect obsolete attributes.
10618 (Method.CreateEmitContext): Moved to MethodOrOperator.
10620 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10623 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10624 customized exception to make crash detection easier.
10625 (MethodOrOperator): Started to work on new base class for methods and
10627 (Method): Derives from MethodOrOperator.
10628 (Constructor.Emit): Emits its own attributes.
10629 (AbstractPropertyEventMethod.Emit): Ditto.
10630 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10632 (Operator.Emit): It's temporary more tricky than should be.
10634 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10636 * report.cs (InternalErrorException): Add ctor with inner exception.
10638 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10641 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10644 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10647 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10650 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10652 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10653 attribute is present and Guid not.
10654 (Interface.ApplyAttributeBuilder): Ditto.
10656 * attribute.cs: Add error message.
10658 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10662 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10663 sources (it's composite) so hold them in extra array as they are used in
10664 Emit phase only. It worked in the previous versions by mistake.
10665 (Attribute.Emit): Emit attribute for more owners when exist.
10667 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10668 it has now different behaviour.
10670 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10672 * constant.cs (Constant.IsDefaultInitializer): New method.
10674 * class.cs: Updated.
10676 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10677 re-initialize default values. It saves KBs almost for every assembly.
10678 Thanks Zoltan for the idea.
10679 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10680 (ArrayCreation.DoResolve): Resolve only once.
10681 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10682 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10684 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10686 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10689 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10691 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10692 in an embedded statement too.
10694 2006-04-01 Raja R Harinath <rharinath@novell.com>
10697 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10699 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10703 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10706 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10708 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10710 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10713 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10714 LocalTemporary change.
10716 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10718 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10719 initializers optimization.
10720 (ClassOrStruct.TypeAttr): Moved from modifiers.
10721 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10722 (FieldBase.ResolveInitializer): Resolves initializer.
10723 (FieldBase.HasDefaultInitializer): New property.
10725 * cs-parser.jay: Removed message.
10727 * expression.cs (CompilerGeneratedThis): New specialization.
10729 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10731 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10733 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10735 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10737 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10738 be now EnumConstants only.
10740 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10742 * attribute.cs, driver.cs: Reset more caches.
10744 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10746 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10748 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10750 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10751 for easier reuse. Updated all overrides.
10752 (IntegralConstant): New base class for all integral constants.
10753 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10754 of the constant range, report custom error.
10755 (UIntConstant.Reduce): Fixed uint conversion.
10757 * ecore.cs, literal.cs: Reduce updates.
10759 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10763 * class.cs (Constructor.Define): Removed extra if for default ctors.
10764 A patch from Atsushi Enomoto.
10766 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10768 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10769 GetAttributableValue.
10771 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10774 * convert.cs (ImplicitConversionRequired): Error message moved to
10777 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10778 automatic implicit conversion of an output value.
10779 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10781 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10783 (TypeOf.GetAttributableValue): Add extra handling for object type.
10785 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10786 special error message.
10788 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10790 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10792 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10793 compatible with MS runtime.
10795 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10797 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10798 attribute arguments here.
10800 * class.cs (Indexer.Define): The check was moved to attribute class.
10802 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10804 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10805 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10808 2006-03-22 Raja R Harinath <rharinath@novell.com>
10810 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10811 mcs to keep code differences small.
10812 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10813 * typemanager.cs (parameter_default_value_attribute_type): New.
10814 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10817 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10819 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10821 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10823 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10825 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10828 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10830 * doc-bootstrap.cs : fix build.
10832 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10834 * expression.cs (StringConcat.Append): Issue a warning when empty string
10835 is going to append.
10837 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10839 * assign.cs (CompoundAssign.ResolveSource): Removed.
10841 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10844 * class.cs (TypeContainer.FindMethods): Removed.
10845 (TypeContainer.CheckMemberUsage): Made static.
10847 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10849 * constant.cs (CheckRange): Removed unused type argument.
10850 (CheckUnsigned): Removed unused type argument.
10852 * cs-parser.jay: Updated after MemberAccess clean up.
10853 Uses Length for empty string test.
10855 * cs-tokenizer.cs: Uses Length for empty string test.
10856 (IsCastToken): Made static.
10857 (is_hex): Made static.
10858 (real_type_suffix): Made static.
10860 * decl.cs (SetupCache): Made static.
10861 (OnGenerateDocComment): Removed unused ds argument.
10863 * delegate.cs (VerifyDelegate): Removed unused argument.
10865 * doc.cs: Uses Length for empty string test.
10867 * driver.cs: Uses Length for empty string test.
10869 * enum.cs (IsValidEnumType): Made static
10871 * expression.cs (EnumLiftUp): Removed unused argument.
10872 (ResolveMethodGroup): Ditto.
10873 (BetterConversion): Ditto.
10874 (GetVarargsTypes): Ditto.
10875 (UpdateIndices): Ditto.
10876 (ValidateInitializers): Ditto.
10877 (MemberAccess.ctor): Ditto.
10878 (GetIndexersForType): Ditto.
10880 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10882 * iterators.cs: Updated after MemberAccess clean up.
10884 * location.cs: Uses Length for empty string test.
10886 * namespace.cs: Uses Length for empty string test.
10888 * report.cs (CheckWarningCode): Made static.
10890 * statement.cs (LabeledStatement): Removed unused argument.
10892 * typemanager.cs (FilterNone): Removed.
10894 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10896 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10899 * class.cs: Updated.
10901 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10903 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10905 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10909 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10910 reporting, it's more tricky than I thought.
10912 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10916 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10918 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10919 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10920 Add more error reporting; Fixed issue with params.
10922 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10924 * cs-parser.jay: AnonymousMethod requires host container.
10926 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10928 2006-03-18 Raja R Harinath <harinath@gmail.com>
10930 * class.cs: Change 'TypeContainer ds' constructor argument to
10931 'DeclSpace parent'. Some classes were missed below due to
10932 different naming convention.
10934 * class.cs (MemberCore.Parent): Delete. This makes the
10935 ParentContainer changes below enforceable by the compiler.
10937 Treat pointers to enclosing declaration space as 'DeclSpace', not
10939 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10940 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10942 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10944 (Block.AddThisVariable): Likewise.
10945 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10946 (AbstractPropertyEventMethod.Emit): Likewise.
10947 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10948 (GetMethod.Define, SetMethod.Define): Likewise.
10949 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10950 (DelegateMethod.EmitMethod): Likewise.
10952 Fix regression test-partial-13.cs.
10953 Rationalize use of PartialContainer. Ensure that the partial
10954 class semantics can be tied to type-correctness, i.e., any
10955 violation will cause a compile error.
10956 * class.cs, const.cs: Access all fields that belong to class
10957 TypeContainer via ParentContainer. Arguments of EmitContexts and
10958 Resolve()-like functions still use 'Parent'.
10960 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10961 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10962 (PropertyMethod.CheckModifiers): Remove unused argument.
10963 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10966 2006-03-17 Raja R Harinath <harinath@gmail.com>
10968 Make semantics of PartialContainer simpler.
10969 * decl.cs (DeclSpace.IsPartial): Remove.
10970 * class.cs (TypeContainer.IsPartial): Likewise.
10971 (TypeContainer..ctor): Set PartialContainer to point to self.
10972 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10973 (TypeContainer.FindNestedType): Likewise.
10974 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10976 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10978 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10980 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10982 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10985 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10987 * class.cs (Operator.Define): An error for base conversion was not
10988 reported correctly.
10990 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10992 * iterator.cs : yield break is allowed in try statement which has
10993 catch clauses. Fixed bug #77767.
10995 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10997 A fix for #77593, #77574.
10999 * class.cs (MethodCore.CheckBase): Another if for operator.
11001 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11003 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11006 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11007 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11010 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11013 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11014 Updated after another emitcontext usage was clean up. It should help us to
11015 synchronize with gmcs easier.
11017 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11021 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11022 (Event.Define): ditto
11023 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11025 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11026 Removed redundant code and set NewSlot for Invoke method too.
11028 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11029 (Parameters.MergeGenerated): New method. Use this method when you merge
11030 compiler generated argument with user arguments.
11032 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11034 * attribute.cs (ResolveAsTypeTerminal): Removed.
11036 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11037 specialization for predefined types; 30% speed up.
11038 Finally placed obsolete check to right place.
11039 (Expression.ResolveType): Removed.
11041 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11042 Updated after ResolveType was removed.
11044 * expression.cs (Cast.ctor): Check void cast.
11045 (Binary.ResolveAsTypeTerminal): Is never type.
11046 (Conditional.ResolveAsTypeTerminal): Is never type.
11048 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11050 2006-03-01 Raja R Harinath <rharinath@novell.com>
11053 * expression.cs (ParameterReference.DoResolveBase): Change return
11055 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11059 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11062 * typemanager.cs (GetFullNameSignature): Don't nullref on
11063 protected accessors.
11065 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11067 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11068 these two separated members to simplify the code.
11069 (Attribute.Resolve): Refactored to use new fields and methods.
11070 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11071 implemented obsolete attribute checking.
11072 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11073 implemented obsolete checking again. It look line never ending quest ;-)
11074 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11076 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11078 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11080 *class.cs (Property.Define): Add RegisterProperty call.
11082 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11083 argument groups (only 2).
11085 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11086 encoding expression to arguments.
11087 (Expression.ExprClassToResolveFlags): Just turned to property.
11089 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11090 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11091 optimized as well as implemented support for zero-length attributes.
11093 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11094 Add caching of PropertyInfo's.
11096 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11098 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11099 error multiple times.
11101 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11103 New partial class implementation.
11104 A fix for #77027, #77029, #77403
11106 * attribute.cs (Attributable): Made attributes protected.
11108 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11109 the replacements of ClassPart and PartialContainer.
11110 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11111 (TypeContainer.AddInterface): Ditto.
11112 (TypeContainer.AddPartial): The main method for partial classes. It checks
11113 for errors and merges ModFlags and attributes. At the end class is added to
11114 partial_parts list.
11115 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11117 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11118 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11119 from the rest of partial classes.
11120 (TypeContainer.GetClassBases): Simplified.
11121 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11123 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11124 (TypeContainer.HasExplicitLayout): Uses Flags now.
11125 (PartialContainer): Removed.
11126 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11127 (StaticClass): Was merged with Class.
11128 (Class.GetClassBases): class and static class bases are verified here.
11129 (Class.TypeAttr): Added static attributes when class is static.
11130 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11131 (MemberBase): In some cases we need to call parent container for partial
11132 class. It should be eliminated but it's not easy now.
11134 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11136 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11137 partial classed to accumulate class comments.
11138 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11140 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11142 * driver.cs (MainDriver): Tree.GetDecl was removed.
11144 * modifiers.cs (Modifiers): Add partial modifier.
11146 * tree.cs (Tree.decl): Removed.
11147 (RootTypes): Started to use this class more often for root types
11150 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11154 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11155 external interface does not have an attribute.
11157 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11159 Another prerequisites for new partial classs implementation.
11161 * attribute.cs (Attribute.Equal): Implemented.
11162 (Attribute.Emit): Changed as attributes can be applied more than twice.
11163 (Attributes.Emit): Check for duplicate attributes here.
11165 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11166 as a parameter, clean-up.
11168 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11172 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11173 contains obsolete attribute check which can in some cases look for base
11174 type of current class which is not initialized yet.
11175 (TypeContainer.BaseType): Replacement of ptype.
11177 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11179 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11181 First of prerequisites for new partial classs implemention.
11183 * attribute.cs (Attributable): Extended by ResolveContext;
11184 Attributes finally have correct context for resolving in all cases.
11185 (AttachTo): Attribute owner is assigned here.
11187 * codegen.cs (IResolveContext): Introduce new interface to hold
11188 all information needed in resolving phase.
11189 (EmitContext): Implements IResolveContext; more clean-up needed here.
11191 * decl.cs (MemberCore): Implemented IResolveContext.
11193 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11194 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11195 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11196 Refactored to use new IResolveContext instead of EmitContext; cleanup
11198 2006-02-06 Miguel de Icaza <miguel@novell.com>
11200 * codegen.cs (EmitScopeInitFromBlock): check here the
11201 capture_context, there is no need to make two calls to the
11204 * anonymous.cs: Add some debugging messages that might help me
11205 track other instances of this problem in the future (the
11206 regression of test 467).
11208 * cs-parser.jay: track the variable block, as we need to initalize
11209 any captured variables declared in this block for the "catch"
11210 portion of the "Try" statement.
11212 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11213 scope initialization for captured variables.
11215 Also, move the emit for the variables after the block location has
11218 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11220 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11222 2006-02-02 Miguel de Icaza <miguel@novell.com>
11224 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11225 commit yesterday, the initialization for the roots is necessary.
11226 What is not necessary is the scope activation.
11228 2006-02-02 Raja R Harinath <rharinath@novell.com>
11230 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11231 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11233 (Argument.Resolve): Remove CS0206 checks.
11235 2006-02-01 Miguel de Icaza <miguel@novell.com>
11237 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11238 scopes for all the roots, the scopes will now be emitted when the
11239 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11241 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11242 code. This reduces a lot of existing cruft.
11244 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11245 that the ScopeInfo is generated as we enter the scope, not at the
11246 time of use, which is what we used to do before.
11248 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11249 every time a Block is about to be emitted if we have a
11252 2006-02-01 Raja R Harinath <rharinath@novell.com>
11254 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11256 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11258 * typemanager.cs (cons_param_array_attribute): Make private.
11259 (Reset): Set it to null.
11260 (InitCoreHelpers): Don't initialize it.
11261 (ConsParamArrayAttribute): New. Initialize it as needed.
11262 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11264 2006-01-31 Miguel de Icaza <miguel@novell.com>
11266 * expression.cs: There might be errors reported during the
11267 selection of applicable methods. If there are errors, do not
11268 continue execution as it will lead the compiler to crash.
11270 2006-01-30 Miguel de Icaza <miguel@novell.com>
11272 * expression.cs: Member access is not allowed on anonymous
11273 methods. Fixes #77402.
11275 2006-01-30 Raja R Harinath <rharinath@novell.com>
11278 * cs-parser.jay (VariableDeclaration): Don't set
11279 current_array_type to null.
11280 (field_declaration, event_declaration, declaration_statement):
11281 Set it to null here.
11283 2006-01-28 Raja R Harinath <harinath@gmail.com>
11285 * typemanager.cs (GenericParameterPosition): New.
11288 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11290 * doc.cs : To process "include" elements, first we should create
11291 another list than XmlNodeList, because it could result in node
11292 removal, which could result in that the XmlNodeList gives up
11293 yielding next node.
11295 (Also made code identical to gmcs again.)
11297 2006-01-25 Miguel de Icaza <miguel@novell.com>
11299 * ecore.cs: Introduce an error report that we were not catching
11300 before, if not silent, we must report the error. Gonzalo ran into
11303 2006-01-23 Miguel de Icaza <miguel@novell.com>
11305 A fix for bug: #76957
11307 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11308 ComputeMethodHost before creating the method, this is a new
11311 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11312 that this method references (RegisterScope). The actual scope
11313 where the method is hosted is computed with the ComputeMethodHost
11314 before we create the method.
11316 Moved the Deepest routine here.
11318 (AnonymousContainer.ComputeMethodHost): New routine used to
11319 compute the proper ScopeInfo that will host the anonymous method.
11321 (ScopeInfo): Deal with multiple roots. The problem was that we
11322 did not have a unique root where all ScopeInfos could be hanged
11323 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11326 Remove AdjustMethodScope which is now computed at the end. Remove
11327 LinkScope which did a partial link, instead link all ScopeInfos
11328 before code generation from the new "LinkScopes" routine.
11330 Simplify all the Add* routines as they no longer need to maintain
11331 the tree, they just need to record that they are using variables
11334 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11335 routines to produce the forest of ScopeInfo trees.
11337 * class.cs (TypeContainer.AppendMethod): This is just like
11338 AddMethod, but ensures that an interface implementation method
11339 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11340 methods, but at the end.
11342 We use this functionality to ensure that the generated MoveNext
11343 method in the iterator class is resolved/emitted before the
11344 enumerator methods created.
11346 This is required because the MoveNext method computes the right
11347 ScopeInfo for the method. And the other methods will eventually
11348 need to resolve and fetch information computed from the anonymous
11351 2006-01-21 Raja R Harinath <harinath@gmail.com>
11352 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11354 Fix rest of #76995.
11355 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11356 the 'aliases' hash.
11357 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11358 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11360 2006-01-18 Raja R Harinath <rharinath@novell.com>
11362 Fix #76656, cs0231-2.cs.
11363 * cs-parser.jay (formal_parameter_list): Make error case catch
11365 (parenthesized_expression_0): Add CS1026 check.
11366 (invocation_expression): Remove unused { $$ = lexer.Location }.
11368 2006-01-17 Raja R Harinath <rharinath@novell.com>
11371 * cs-parser.jay (statement_expression): Don't list out the
11372 individual statement-expressions. Convert syntax error into
11375 2006-01-16 Raja R Harinath <rharinath@novell.com>
11378 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11379 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11380 CheckIntermediateModification.
11381 (FieldExpr.DoResolve): Add new two-argument version that
11382 allows us to resolve the InstanceExpression as an lvalue.
11383 The one-argument variant is now just a wrapper.
11384 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11385 Resolve the lhs as an lvalue if the it has a value type.
11386 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11387 from Assign.DoResolve.
11388 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11389 resolved as an lvalue.
11390 (PropertyExpr.DoResolve): Update.
11391 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11392 has a value type. Move CS1612 check here from
11393 CheckIntermediateModification.
11394 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11395 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11396 'right_side' of a ResolveLValue on an 'out' argument.
11397 (EmptyExpression.LValueMemberAccess): New. Used as the
11398 'right_side' of a propagated ResolveLValue on a value type.
11399 (LocalVariableReference.DoResolveBase): Recognize
11400 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11402 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11403 EmptyExpression.Null.
11405 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11407 * typemanager.cs : added IsGenericParameter(). In mcs it always
11409 * doc.cs : for generic parameters, use GenericParameterPosition,
11412 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11414 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11416 2006-01-12 Miguel de Icaza <miguel@novell.com>
11418 This fixes the problem where we used ldfld instead of ldflda to
11419 load the "THIS" pointer on captured parameters, when THIS is a
11420 value type. See bug #77205.
11422 * iterators.cs (CapturedThisReference.Emit): Pass false to
11423 EmitThis (we do not need the address).
11425 * codegen.cs (EmitThis): it needs to know whether we need the
11426 address of `this' or not. This is used by value types.
11428 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11429 every other call passes false.
11431 2006-01-12 Raja R Harinath <rharinath@novell.com>
11434 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11436 * expression.cs (Invocation.OverloadResolve): Update.
11437 (Invocation.DoResolve): Avoid double resolution of invocation.
11439 2006-01-11 Raja R Harinath <rharinath@novell.com>
11442 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11443 unary negation of floating point types as 0-expr; negation cannot
11444 overflow in floating point types.
11447 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11448 on operands of 'void' type.
11451 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11452 and ExclusiveOr for boolean constants too.
11454 2006-01-09 Raja R Harinath <rharinath@novell.com>
11457 * expression.cs (Invocation.OverloadResolve): Replace reflected
11458 override methods with their base virtual methods, rather than
11459 skipping over them.
11460 * typemanager.cs (TypeManager.GetOverride): New.
11462 2006-01-05 Jb Evain <jbevain@gmail.com>
11464 * class.cs (Property.Define, Indexer.Define): do not tag the
11465 properties as SpecialName | RTSpecialName.
11467 2006-01-04 Miguel de Icaza <miguel@novell.com>
11469 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11470 doing a low-level comparission of parameter types. It was lacking
11471 a check for __argslist.
11473 2005-12-30 Miguel de Icaza <miguel@novell.com>
11475 * expression.cs (ParameterReference.DoResolveBase): Allow
11476 reference parameters if they are local to this block.
11478 This allows the ref and out parameters of a delegate to be used in
11479 an anonymous method, for example:
11481 delegate void set (out int x);
11483 set s = delegate (out int x){
11487 This is used by functionality introduced late in the C# language.
11489 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11490 method that take ref and out parameters.
11492 Fixes #77119 which was a late change in the spec.
11494 2005-12-23 Miguel de Icaza <miguel@novell.com>
11496 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11497 parent if its the same scope. Fixes #77060.
11499 2005-12-21 Miguel de Icaza <miguel@novell.com>
11501 * driver.cs: Report the case of no source files and no -out:
11504 2005-12-20 Raja R Harinath <rharinath@novell.com>
11507 * expression.cs (ComposedCast.GetSignatureForError): Define.
11509 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11513 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11514 ListDictionary, to contain the ExternAliasEntry entries (in
11515 addition to the NamespaceEntry.aliases hashtable). This field is
11516 shared between the original entry and its doppelganger (bodyless
11518 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11519 extern_aliases field.
11520 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11521 lookup in extern_aliases.
11523 2005-12-16 Raja R Harinath <rharinath@novell.com>
11526 * class.cs (TypeContainer.Mark_HasEquals): New.
11527 (TypeContainer.Mark_HasGetHashCode): New.
11528 (ClassPart): Override them.
11529 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11532 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11533 'parent' argument to the base constructor.
11535 Remove all mention of TypeContainer from decl.cs.
11536 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11537 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11538 (DeclSpace.DeclSpace): Likewise.
11539 (DeclSpace.DefineMembers): Remove unused argument.
11540 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11541 debugging check -- we don't care if the debug code throws an
11542 InvalidCastException instead of an InternalErrorException.
11543 * class.cs (TypeContainer.DefineMembers): Update to changes.
11544 (TypeContainer.DoDefineMembers): Likewise.
11545 (TypeContainer.GetMethods): Likewise.
11546 (PropertyMember.Define): Likewise.
11547 (MemberBase.Parent): New property that forwards to
11548 MemberCore.Parent, but ensures that we get a TypeContainer.
11549 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11550 (RootContext.PopulateTypes): Likewise. Remove special case code
11551 for !RootContext.StdLib: DefineMembers is idempotent.
11553 2005-12-14 Miguel de Icaza <miguel@novell.com>
11555 * convert.cs (ExplicitConversionCore): Check the return value from
11556 ExplicitConversionCore which can return null on failure. Fixes #76914
11558 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11560 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11562 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11564 * doc.cs : The search for referenced namespace was insufficient to
11565 get global one as it used to do. Fixed bug #76965.
11567 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11569 * doc.cs : check name in cref in the last phase that whether it is
11572 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11574 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11577 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11579 * doc.cs : so it turned out that we cannot skip override check for
11580 interface members. Fixed bug #76954.
11582 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11584 * cs-tokenizer.cs : fixed bug #75984:
11585 - #warning and #error should not be handled when the source line
11587 - #line is not checked strictly when the source line is disabled.
11588 - #define and #undef is on the other hand checked strictly at any
11591 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11593 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11596 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11598 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11600 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11601 event initializers.
11602 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11603 (FieldBase.Initializer): Initializer is now optional.
11604 (EventField.Define): Only event field can have initializer.
11606 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11608 * const.cs (Const): Reuse initializer.
11610 * cs-parser.jay: Updated after FieldBase changes.
11611 Added current_array_type to simplify array initializers.
11613 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11615 * expression.cs, iterators.cs: Updated.
11617 * namespace.cs (NamespaceEntry): Made UsingFound private.
11619 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11621 * parameterCollection.cs: Obsolete, removed.
11622 * parser.cs: Obsolete, removed.
11624 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11627 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11629 * enum.cs (Enum.Define): Set obsolete context here.
11631 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11634 - FindDocumentedMember() now expects 1) paramList as null
11635 when "we don't have to check the number of parameters" and
11636 2) Type.EmptyTypes when "there is no arguments".
11637 - Introduced FoundMember struct to hold the exact type which was
11638 used to find the documented member (the above change broke
11639 test-xml-044; it might be better just to use DeclaringType than
11640 what MS does, like this change does, but it depends on usage.)
11642 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11644 * doc.cs : documented member might be from DeclaringType for nested
11645 types. Fixed bug #76782.
11647 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11649 * anonymous.cs: Have the param code handle leaving copies on the
11650 stack etc. Allows anonymous params to take part in the assignment
11651 code (++, +=, etc). Fixes bug #76550
11653 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11654 it down to the anon code.
11656 * iterators.cs: Use dummy var here
11658 * codegen.cs: Handle new vars
11660 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11663 * class.cs (MethodData.Define): Set proper Obsolete context.
11665 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11667 (FieldExpr.DoResolve): Ditto.
11669 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11672 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11673 parent is not obsolete.
11675 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11677 * doc.cs : (FindDocumentedMember) find parameterless members first
11678 and get CS0419 in the early stage. Fixed first case of bug #76727.
11680 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11683 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11684 no error was reported.
11686 *expression.cs (Binary.DoResolve): left can be null.
11688 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11691 * class.cs (MethodData.Emit): Parameters should be labeled first.
11693 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11696 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11698 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11700 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11702 * class.cs (MethodCore): Parameter clean up.
11703 (IMethodData): Added ParameterInfo.
11704 (MethodData): Parameter clean up.
11705 (Indexer.Define): Parameter clean up.
11717 * typemanager.cs: Parameter clean up.
11719 * delegate.cs (Define): Get rid of duplicated code.
11721 * expression.cs (ParameterReference): Removed useless parameters
11723 (Invocation): Ditto.
11725 * parameter.cs (ParamsParameter): New class, params specialization.
11726 (ArglistParameter): Attemp to separate arglist.
11727 (Parameter): Refactored to be reusable and faster.
11728 (Parameter.Modifier): Made understandable.
11729 (Parameters): Changed to be used as a class for `this' assembly
11730 parameters. Refactored to use new specialized classes.
11732 * support.cs (ParameterData): Added Types property.
11733 (InternalParameters): Deleted.
11735 2005-08-20 Martin Baulig <martin@ximian.com>
11737 Merging this patch from GMCS to fix #75867.
11739 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11740 scope if we don't already have it.
11742 2005-11-17 Martin Baulig <martin@ximian.com>
11745 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11746 inherit the scope from our parent. Fixes #76653.
11748 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11750 * doc.cs : the previous patch does not actually fix the bug.
11751 PropertyInfo override check is now implemented and really fixed it.
11752 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11754 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11756 * doc.cs : apply "override filter" also to properties.
11759 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11761 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11762 no need to check overrides. For classes, omit those results from
11763 interfaces since they must exist in the class. Fixed bug #76726.
11765 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11767 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11768 with different parameters. Fixed the second problem in #76685.
11770 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11772 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11773 get expected 'protected' access in CheckValidFamilyAccess()).
11776 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11778 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11779 Fixed bug #76705. CS1569 was incorrectly commented out.
11781 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11783 * doc.cs : use Invocation.IsOverride() to do real override check.
11784 * expression.cs : made Invocation.IsOverride() internal.
11786 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11788 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11789 TypeBuilder.FindMembers() and filter overriden base members out.
11792 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11794 * doc.cs : ref/out parameters are represented as '@' (instead of
11795 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11797 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11799 * doc.cs : when there was no '.' in cref to methods in doc comment,
11800 then parameters were missing in the output. Fixed bug #76691.
11802 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11804 * driver.cs : don't output docs when there is an error.
11807 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11810 Now it should detect indexers. Fixed primary concern in bug #76685.
11811 Fixed CS0419 message to not show the identical member signature in
11814 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11816 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11817 instead of Type.FindMembers() since it does not handle events.
11820 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11822 * codegen.cs: Fixed typo (speficied -> specified).
11824 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11827 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11829 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11831 * attribute.cs: Changed error message.
11833 * cs-tokenizer.cs: One more check.
11835 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11837 * statement.cs (Block.Resolve): Ignore empty statement.
11839 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11841 * report.cs: Made error/warning methods more strict to avoid
11844 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11845 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11846 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11847 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11849 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11851 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11852 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11854 * class.cs (TypeContainer.IsComImport): New property.
11855 (Constructor.Define): Create proper ctor for ComImport types.
11857 * expression.cs (New.CheckComImport): Fixed.
11859 2005-11-07 Miguel de Icaza <miguel@novell.com>
11861 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11862 that a parameter has been captured does not mean that we do not
11863 have to do the rest of the processing. This fixes the second part
11864 of #76592. If there was another anonymous method capturing
11865 values in the past, the Scope would never be set for the second
11866 method that captured the same parameter.
11868 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11869 properly manipulate the stack. Second part of fix for #76592.
11871 * expression.cs (New): Add support for invoking "new" on
11872 interfaces that have been flagged with the ComImport attribute and
11873 the CoClass. Fixes #76637
11875 * statement.cs (Try.DoEmit): When a variable is captured, do not
11876 try to emit the vi.LocalBuilder variable as it has been captured.
11877 Create a temporary variable and store the results on the
11878 FieldBuilder. Fixes #76642
11880 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11882 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11884 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11886 * expression.cs (Binary.DoResolve): Added && optimalization.
11888 * typemanager.cs (AddUserType): Removed useless argument.
11890 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11892 * statement.cs (Block.variables): Uses ListDictionary.
11894 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11897 * class.cs (PartialContainer.EmitType): Customized to emit
11898 security attributes.
11899 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11900 for partial classes.
11902 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11905 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11906 access has to be fixed.
11908 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11910 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11913 * ecore.cs (NullCast.Reduce): Implemented.
11915 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11918 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11920 (Foreach.Resolve): Catch null properly.
11922 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11924 * cs-tokenizer.cs: Warning text fix.
11926 * driver.cs: AllWarningNumbers exposed on public interface.
11928 * report.cs (): Reviewed warning numbers.
11929 (IsValidWarning): Use binary search.
11931 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11933 * driver.cs: Implemeted resource visibility.
11934 (Resources): New class for code sharing between /res: and
11937 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11940 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11943 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11946 * ecore.cs (NullCast): Child is contant only.
11948 * literal.cs (NullLiteral.Reduce): null can be converted to any
11951 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11953 * driver.cs: Use Encoding.Default as default code page instead
11956 2005-10-27 Raja R Harinath <rharinath@novell.com>
11959 * expression.cs (Invocation.Error_InvalidArguments): Handle
11960 __arglist parameters.
11961 (Invocation.VerifyArgumentsCompat): Likewise.
11962 * support.cs (ReflectionParameters.GetSignatureForError): Print
11963 __arglist parameters.
11964 (InternalParamters.GetSignatureForError): Likewise.
11965 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11967 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11969 * attribute.cs (GetPropertyValue): Made public.
11971 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11973 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11975 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11978 * driver.cs: Reflect method name change.
11980 * statement.cs (Try.Resolve): Warn when try has both general
11981 exception handlers.
11983 * typemanager.cs: runtime_compatibility_attr_type new predefined
11986 2005-10-26 Raja R Harinath <harinath@gmail.com>
11989 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11990 treat it as an empty parameter list.
11992 2005-10-26 Raja R Harinath <rharinath@novell.com>
11995 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11996 ResolveAsTypeStep silent.
11997 * statement.cs (Block.AddConstant): Mark block as used.
11998 (Block.ResolveMeta): Avoid piling on error messages
11999 if a constant initializer resolution fails.
12001 2005-10-25 Raja R Harinath <rharinath@novell.com>
12003 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12005 (NamespaceEntry.VerifyAllUsing): New.
12006 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12007 behaviour. Delegates actual resolution of alias to ...
12008 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12009 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12011 * driver.cs (Driver.MainDriver): Update.
12013 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12014 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12016 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12018 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12019 RootNamespace.DefineNamespacesForAll.
12021 2005-10-24 Raja R Harinath <harinath@gmail.com>
12023 * typemanager.cs (assemblies, external_aliases, modules)
12024 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12025 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12026 overhead. Move resposibility ...
12027 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12028 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12030 2005-10-23 Raja R Harinath <harinath@gmail.com>
12032 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12033 cached_namespaces. Improve usage.
12034 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12035 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12036 Move from GlobalRootNamespace and simplify.
12037 (RootNamespace.Global): Make instance variable.
12038 (RootNamespace.RootNamespace): Add "alias name" parameter.
12039 (GlobalRootNamespace): Simplify drastically.
12040 (Namespace.Lookup): Don't use GetNamespace.
12041 * typemanager.cs (GetRootNamespace): Rename from
12042 ComputeNamespaceForAlias.
12043 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12045 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12047 * anonymous.cs (AnonymousContainer): Don't crash when container
12050 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12052 * expression.cs (Binary.DoResolve): Warn when comparing same
12055 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12058 * expression.cs (Binary.DoResolve): It looks like there are no
12059 convetsion rules in enum context.
12061 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12063 Add support for extern alias qualifiers.
12064 * typemanager.cs: Move some LookupTypeReflection code
12065 to namespace.cs, to have cleaner code. Added some methods
12066 to help us keep track of the extern aliased references.
12067 * driver.cs: Add suport for extern alias assemblies on command
12068 line and check for their warnings/errors. Also keep track of the
12069 extern aliased assemblies.
12070 * namespace.cs: Move the global functionality of Namespace
12071 to GlobalRootNamespace/RootNamespace. Now the global namespace
12072 is GlobalRootNamespace.Globa. Also the code moved from
12073 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12074 Finally added LocalAliasEntry (AliasEntry before) and
12075 ExternAliasEntry, to handle alias statements.
12076 * cs-parser.jay: Add support in the grammar for extern alias
12078 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12079 Update callings to Namespace (now in GlobalRootNamespace).
12081 2005-10-18 Raja R Harinath <rharinath@novell.com>
12084 * class.cs (TypeContainer.DefineType): Move updating of
12085 topological sort earlier in the code.
12086 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12088 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12091 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12093 * constant.cs (Constant.TryReduce): Moved from Cast class.
12094 (Reduce): Made little bit more OO and fixed missing conversions.
12096 * ecore.cs (Reduce): Implemented.
12097 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12099 * literal.cs (Reduce): Implemented.
12101 * class.cs: Reverted Miguel's wrong commit.
12103 2005-10-14 Miguel de Icaza <miguel@novell.com>
12105 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12107 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12109 * cs-parser.jay, expression.cs : CS0214 was missing error location
12110 for constants. Fixed bug #76404.
12112 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12115 * convert.cs (ExplicitConversionCore): Fixed object->enum
12118 2005-10-10 Raja R Harinath <rharinath@novell.com>
12120 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12121 InstanceExpression.
12122 (PropertyExpr.EmitCall): Likewise.
12123 * expression.cs (Invocation.EmitArguments): Handle case where
12125 (Invocation.EmitCall): Avoid allocating temporary variable if
12126 there are no arguments.
12128 2005-10-07 Raja R Harinath <rharinath@novell.com>
12131 * convert.cs (ImplicitConversionStandard): Move conversion of
12132 void* to arbitrary pointer types ...
12133 (ExplicitConversionStandard): .. here.
12134 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12135 error to always print typenames.
12137 2005-10-07 Raja R Harinath <rharinath@novell.com>
12139 * convert.cs (GetConversionOperator): Rename from
12140 GetConversionOperators. Move operator selection code from ...
12141 (UserDefinedConversion): ... here.
12143 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12145 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12148 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12150 * assign.cs (Assign.DoResolve): Error method changed.
12152 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12154 * const.cs (ResolveValue): Reset in_transit immediately.
12156 * constant.cs: Error method changed.
12158 * convert.cs: Removed useless location parameter.
12159 (ExplicitNumericConversion): Don't do double enum check.
12160 (ExplicitConversionCore): Renamed from ExplicitConversion.
12161 (ExplicitUnsafe): Extracted from ExplicitConversion.
12162 (ExplicitConversion): Uses for error reporting.
12164 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12166 (ResolveBoolean): Uses common error method.
12167 (CastToDecimal): Get rid of ec.
12168 (CastFromDecimal): Optimized.
12169 (ConvCast): Get rid of ec.
12171 * enum.cs (ResolveValue): Reset in_transit immediately.
12172 (Emit): Return after first error.
12174 * expression.cs: Convert changes.
12176 * literal.cs: Error method changed.
12178 * statement.cs: Error method changed.
12180 2005-10-03 Raja R Harinath <rharinath@novell.com>
12182 * support.cs (SeekableStreamReader.Position): Don't error out when
12183 the requested position is just beyond the end of the current
12186 2005-09-28 Raja R Harinath <rharinath@novell.com>
12188 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12189 try to keep in sync with the byte count of the underlying Stream.
12190 However, this limits us to a window size of 2048 characters: i.e.,
12191 the maximum lookahead of our lexer/parser can be 2048 characters.
12193 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12196 * driver.cs: Fix compilation files with full root path.
12198 2005-09-25 Miguel de Icaza <miguel@novell.com>
12200 * report.cs (SymbolRelatedToPreviousError): Format the output so
12201 it does not use an open parenthesis that is never closed.
12203 * driver.cs: Follow coding guidelines
12205 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12208 * const.cs (Const.ResolveValue): Check for assigning non-null
12209 value to reference type.
12211 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12213 * anonymous.cs: Implemented ExprClassName.
12215 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12218 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12221 * class.cs (StaticClass.DefineContainerMembers): Report protected
12224 * codegen.cs: if(ed) PRODUCTION.
12226 * convert.cs (Error_CannotImplicitConversion): Better error
12229 * cs-parser.jay: More error checks.
12231 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12233 * driver.cs (CSCParseOption): Enabled wrong option check.
12235 * ecore.cs (Expression.ExprClassName): Turned to property.
12236 (MemberExpr.CheckIntermediateModification): For checking boxed
12237 value types modification.
12239 * statement.cs (Fixed.Resolve): Expression type must be
12240 convertible to fixed type.
12241 (CollectionForeach.GetEnumeratorFilter,TryType):
12242 Small refactoring for easier error checking.
12244 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12246 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12249 * class.cs (GeneratedBaseInitializer): New class for customization
12250 compiler generated initializers.
12251 (MemberBase.DoDefine): Check Obsolete attribute here.
12252 (FieldMember.DoDefine): Ditto.
12254 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12257 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12258 (MemberCore.GetObsoleteAttribute): Removed argument.
12259 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12260 (MemberCore.CheckObsoleteType): New helper.
12264 * statement.cs: Updates after MemberCore changes.
12266 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12267 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12269 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12270 obsolete attribute for compiler construct.
12271 (As.DoResolve): Cache result.
12273 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12275 2005-09-26 Raja R Harinath <rharinath@novell.com>
12278 * expression.cs (This.VerifyFixed): In a value type T, the type of
12279 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12280 value type R, 'this' is treated as a value parameter.
12282 2005-09-22 Miguel de Icaza <miguel@novell.com>
12284 * statement.cs (Lock): Use the TemporaryVariable class instead of
12285 manually using local variables as those do not work when variables
12288 * ecore.cs: Moved the TemporaryVariable class from being a nested
12289 class inside Foreach to be a public class that can be employed in
12292 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12294 * cs-parser.jay: interface_accessors replaced by
12295 accessor_declarations.
12297 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12300 * statement.cs (GotoCase.Resolve): Convert null constant to
12302 (SwitchLabel.ResolveAndReduce): Ditto.
12303 (SwitchLabel.NullStringCase): Custom null stamp.
12304 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12306 typemanager.cs (CSharpSignature): Don't skip first argument
12309 2005-09-18 Miguel de Icaza <miguel@novell.com>
12311 * driver.cs: Set InEmacs based on the environment variable EMACS.
12313 * location.cs (InEmacs): in this mode, do not report column
12314 location as it confuses Emacs.
12316 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12318 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12319 expression.cs, iterators.cs, literal.cs: Store constants and
12322 * class.cs (MemberBase.ShortName): Pass location.
12324 * cs-parser.jay: Some location fixes.
12326 * ecore.cs (Expression.Location): Made virtual.
12328 2005-09-05 Miguel de Icaza <miguel@novell.com>
12330 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12331 if the underlying types are the same, otherwise we need to produce
12332 code that will do the proper cast.
12334 This was exposed by Marek's constant rewrite which produced
12335 invalid code for the call site:
12337 enum X : long { a }
12338 void Method (X v) {}
12342 This fixes test-49.cs
12344 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12346 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12347 Type/Object should be allowed as well. Fixed bug #75968.
12349 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12351 * expression.cs : (Binary.DoResolve): when one is enum constant and
12352 another is constant 0, then return enum one *as enum type*.
12355 2005-09-02 Raja R Harinath <rharinath@novell.com>
12357 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12361 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12362 flow-branching for LocalVariableReferences in case we were invoked
12363 from a MemberAccess.
12364 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12366 (LocalVariableReference.DoResolveBase): ... this.
12367 (MemberAccess.Resolve): Do the check that was disabled during
12370 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12373 (PartialContainer.Create): check abstract/sealed/static strictly
12374 but abstract/sealed can exist only at one side. Fixed bug #75883.
12376 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12379 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12380 specified, don't default to UnmanagedType.I4.
12382 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12384 * expression.cs : conditional operator should check possibly
12385 incorrect assign expression. Fixed bug #75946.
12387 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12389 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12390 Reverting the change. gmcs is much complex than mcs on this matter.
12392 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12394 * cs-tokenizer.cs : To read another token ahead of the actual
12395 consumption, use new SavedToken and cache token instead of moving
12396 back the stream with SeekableStreamReader (it seemed problematic).
12398 driver.cs : Thus use StreamReader directly.
12399 * support.cs : Thus removed SeekableStreamReader.
12401 2005-08-30 Raja R Harinath <rharinath@novell.com>
12404 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12405 (ScopeInfo.EmitScopeType): Use it to construct field names from
12406 names of captured locals.
12409 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12410 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12411 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12412 (ExplicitConversion): Remove enum cases already handled by
12413 implicit conversion. Move implicit conversion check to the beginning.
12414 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12415 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12416 Don't treat System.Enum as a struct.
12418 2005-08-30 Jb Evain <jbevain@gmail.com>
12420 * attribute.cs: handles as expression in parameters.
12422 2005-08-30 Raja R Harinath <rharinath@novell.com>
12425 * class.cs (TypeContainer.VerifyClsName): Don't use a
12426 PartialContainer when verifying CLS compliance.
12427 (AbstractPropertyEventMethod): Set Parent here, ...
12428 (PropertyMethod): ... not here.
12430 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12432 * attribute.cs : escaped attribute name should not be allowed to be
12433 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12435 2005-08-29 Raja R Harinath <rharinath@novell.com>
12438 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12439 when converting a long constant to unsigned long.
12440 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12441 detect where IsApplicable and VerifyArgumentsCompat disagree.
12443 2005-08-29 Raja R Harinath <rharinath@novell.com>
12444 and Carlos Alberto Cortez <carlos@unixmexico.org>
12447 * class.cs (TypeContainer.CanElideInitializer): New helper.
12448 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12449 can safely emitting the initializer of a field.
12451 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12453 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12454 allowed inside a switch (without loop). Fixed bug #75433.
12456 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12458 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12459 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12461 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12463 * driver.cs : kinda reverting the default encoding changes (not exact
12464 revert since I noticed that "codepage:reset" might not work fine).
12466 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12468 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12469 Location. Now getter and setter store location correctly.
12470 (errors/cs0111-12.cs now reports the expected location.)
12472 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12474 * driver.cs : Use default encoding on the environment.
12475 Removed (now that) extra parameter for SeekableStreamReader.
12476 * support.cs : (SeekableStreamReader) third .ctor() argument for
12477 StreamReader is not required (always true). preamble size could
12478 be acquired in simpler and safe way.
12480 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12482 * cs-parser.jay: report CS0642 at warning level 3
12483 and report CS0642 for an if else statement also
12484 fixes bug #74745. Patch by John Luke (and a bit
12486 Removed extra CS0642 warning check for "while",
12488 * statement.cs: In Block.Resolve(), CS0642 check
12489 is reimplemented to check a sequence of an empty
12490 statement and a block.
12492 Both fix bug #66777.
12494 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12496 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12497 detection until I fix it.
12499 * cs-tokenizer.cs: Changed error message.
12501 * cs-parser.jay: Fixed 2 error locations.
12503 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12504 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12507 * enum.cs (GetSignatureForError): Fixed.
12509 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12513 * typemanager.cs (RegisterProperty): Removed.
12515 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12517 2005-08-24 Raja R Harinath <rharinath@novell.com>
12520 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12521 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12523 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12525 * expression.cs : tiny fix is required for not warning positive ulong.
12528 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12530 * expression.cs : add CS0652 check for constant and integral
12531 expression. Fixed bug #53974.
12533 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12535 * expression.cs : in DoNumericPromotions(), check if there is implicit
12536 conversion overload for string (to check CS0034). Fixed bug #52492.
12538 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12540 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12542 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12544 * ecore.cs : report location when it is *not* Null.
12546 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12552 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12553 correctly. Fixed bug #75721.
12555 2005-08-23 Raja R Harinath <rharinath@novell.com>
12557 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12558 loop that performs 'min (pos, char_count)'.
12561 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12562 converted value in Operator.OnesComplement.
12564 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12566 * anonymous.cs: If the anon method is pulled into a helper class,
12567 it needs to be `internal' not `private'. Fixes runtime behavior on
12570 2005-08-20 Martin Baulig <martin@ximian.com>
12572 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12573 scope if we don't already have it.
12575 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12576 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12579 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12582 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12583 is a partial class.
12585 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12587 The big constants rewrite
12588 Fix #75746, #75685 and more
12589 As a side effect saved 1MB for MWF ;-)
12591 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12592 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12593 enum based for corlib compilation.
12595 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12598 * class.cs (FixedField.Define): Use ResolveAsConstant.
12600 * const.cs (IConstant): Interface constants and enums.
12601 (Const.ResolveValue): New method for constant resolvning.
12602 (ExternalConstant): Constants from imported assemblies.
12604 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12605 conversion; like enums.
12606 (Constant.ToType): Converts this constant to different type.
12607 (Constant.Increment): Adds 1.
12609 * convert.cs (ImplicitConversionRequired): Simplified.
12611 * cs-parser.jay: Create EnumMember directly.
12613 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12615 * doc.cs (GenerateEnumDocComment): Removed.
12617 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12618 (ConvertIntLiteral): Removed.
12619 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12621 * enum.cs (EnumMember): Implement IConstant.
12622 (Enum.IsValidEnumConstant): Removed.
12623 (Enum.GetNextDefaultValue): Removed.
12624 (Enum.FindMembers): Updated.
12625 (Enum.GenerateDocComment): Iterate enum members.
12627 * expression.cs (Cast.TryReduce): Handle enums correctly.
12628 (New.Constantify): Made public.
12629 (MemberAccess.DoResolve): Removed contant specific if(s).
12631 * literal.cs (NullLiteral): Implement new abstract methods.
12633 * statement.cs (GotoCase.Resolve): Use new constant methods.
12634 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12636 * typemanager.cs (LookupEnum): Removed.
12637 (IsEnumType): Fixed to work with corlib.
12638 (RegisterConstant): Removed.
12639 (LookupConstant): Removed.
12640 (GetConstant): Changed to work with IConstant.
12642 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12644 * location.cs : Fixed overflown (>255) column number.
12646 2005-08-03 Raja R Harinath <rharinath@novell.com>
12648 First cut of the qualified-alias-member feature.
12649 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12651 * cs-parser.jay (DOUBLE_COLON): New token.
12652 (namespace_or_type_name): Add rule for recognizing
12653 qualified-alias-members.
12654 (primary_expression): Likewise.
12655 (element_access): Allow QualifiedAliasMember as a possible
12656 type-bearing expression.
12657 (local_variable_type, local_variable_pointer_type): Likewise.
12658 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12659 aliases in the current and enclosing namespace declarations.
12660 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12661 * decl.cs (MemberName.is_double_colon): New.
12662 (MemberName.MemberName): Add new constructor for alias-member.
12663 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12664 * expression.cs (QualifiedAliasMember): New expression type.
12666 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12668 * location.cs : it borked when no argument was specified.
12670 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12672 * location.cs : tiny ToString() format fix.
12674 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12676 * statement.cs : oops, it was missing.
12678 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12680 A set of fixes for precise line/column location.
12683 "token" field now holds a file/line "delta", a line number offset
12684 from the segment, and a column number. See also:
12685 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12686 December/009508.html
12687 Removed static IsNull. Use instance IsNull property instead.
12688 * cs-tokenizer.cs :
12689 For some tokens it stores Location. For Identifier it stores
12690 LocatedToken which is a pair of string name and location.
12691 Column numbers are adjusted only at getChar().
12693 Use Location.ToString() for reporting (it now contains column).
12695 Largely modified to use LocatedToken instead of
12696 string (IDENTIFIER), and to acquire Location from some tokens.
12697 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12698 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12700 Now MemberName holds Location. DeclSpace.ctor() receives Location
12701 as a parameter. Removed extra parameters to all derived classes.
12702 Replaced Location.IsNull() with instance property.
12703 * assign.cs, expression.cs :
12704 Added .ctor() overload that omits Location.
12706 Added "nameEscaped" flag that indicates the identifier was escaped
12707 in the source file. This fixes bug #57047.
12709 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12711 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12712 New method, looking for lo-case imported cls type.
12714 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12717 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12719 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12721 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12722 all_imported_types.
12723 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12725 Optimized to save 3.5 MB for SWF compilation.
12727 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12729 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12730 (PartialContainer.Create): Moved logic AddToContainer.
12731 (PartialContainer.MarkForDuplicationCheck): Shares name.
12733 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12736 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12738 (Namespace.GetSignatureForError): New method.
12740 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12741 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12743 2005-08-01 Raja R Harinath <rharinath@novell.com>
12746 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12747 member lookup rather than qualifier_type, since qualifier_type can
12750 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12752 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12755 2005-07-31 Miguel de Icaza <miguel@novell.com>
12757 * statement.cs: Copy the local exception into the exception
12758 captured local. Fixes 75674
12760 2005-07-31 Raja R Harinath <harinath@gmail.com>
12763 * expression.cs (Invocation.OverloadResolve): Don't report error
12764 CS1501 if error CS1502 has been reported.
12765 (New.DoResolve): Delegate CS1501 reporting to
12766 Invocation.OverloadResolve.
12769 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12770 invariant-meaning-in-block property in an enclosing block if
12773 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12775 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12776 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12777 (Switch.CheckSwitch): Just save 50kb for SWF.
12779 2005-07-27 Martin Baulig <martin@ximian.com>
12781 * anonymous.cs (CaptureContext.AddField): Added
12782 `AnonymousContainer am' argument; compute its toplevel scope if
12783 it's not already computed. Fixes #75649.
12785 2005-07-26 Raja R Harinath <rharinath@novell.com>
12788 * class.cs (Constructor.Emit): Reset block to null if the block
12791 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12793 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12795 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12797 * class.cs (MethodData.Define): Check whether accessor implementing
12798 interface is public.
12800 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12802 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12805 * namespace.cs (LookupType): Moved same type check to...
12807 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12808 with the same name.
12810 2005-07-21 Raja R Harinath <rharinath@novell.com>
12812 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12813 already found a typebuilder.
12814 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12815 MemberNames, not strings.
12817 * const.cs (Error_ExpressionMustBeConst):
12818 Rename from Error_EpressionMustBeConst.
12819 * const.cs, class.cs, statement.cd: Update.
12821 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12825 * const.cs (Const.LookupConstantValue): Report missing contant expression
12827 (Error_EpressionMustBeConstant): Only one error method.
12829 * class.cs, statement.c: Updated.
12831 2005-07-20 Raja R Harinath <rharinath@novell.com>
12833 * statement.cs (Block.Flags): Add back HasVarargs.
12834 (Block.flags): Make protected.
12835 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12837 * typemanager.cs (types, typecontainers, user_types): Remove.
12838 (UserTypes, TypeContainers): Likewise.
12839 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12840 (CleanUp, Reset): Update.
12841 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12842 (GetNestedType): Use Type.GetNestedType.
12843 (CoreLookupType): Take two arguments, the namespace and the
12844 basename of the type. Update to use the Namespace.Lookup
12846 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12847 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12848 string concatenation and substring matches.
12849 * class.cs, enum.cs, delegate.cs: Update to changes.
12851 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12853 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12854 Expression and made virtual.
12856 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12857 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12859 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12861 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12864 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12867 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12870 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12871 AssemblyCultureAttribute is not used on executable.
12874 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12876 2005-07-16 Raja R Harinath <rharinath@novell.com>
12879 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12880 New. Reports CS0252/CS0253.
12881 Mostly taken from preliminary patch by Duncak Mak.
12882 (Binary.DoResolveOperator): Store results of operator lookup.
12883 Use them to detect if we need to warn about unintended reference
12886 2005-07-15 Raja R Harinath <rharinath@novell.com>
12889 * namespace.cs (Namespace.Lookup): Add back location parameter.
12890 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12891 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12893 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12894 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12895 (Namespace.LookupType): ... this.
12896 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12898 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12899 purported to handle pointers.
12900 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12903 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12905 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12908 2005-07-15 Raja R Harinath <rharinath@novell.com>
12910 * namespace.cs (Namespace.Lookup): Drop location parameter.
12911 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12912 (NamespaceEntry.Lookup): ... this.
12913 (NamespaceEntry.Error_AmbiguousTypeReference):
12914 Move here from DeclSpace.
12915 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12917 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12918 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12919 Move to NamespaceEntry.
12920 * delegate.cs, expression.cs: Update to changes.
12922 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12924 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12925 CheckAttributeType and refactored.
12926 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12927 ResolveAsTypeTerminal error handling.
12928 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12930 (GetSignatureForError): Print errors in same way.
12933 * codegen.cs: Reflect attribute GetSignatureForError change.
12936 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12938 * namespace.cs (UsingEntry): Refactored to make fields private.
12941 statement.cs: Error_UnexpectedKind has extra parameter.
12943 2005-07-14 Raja R Harinath <rharinath@novell.com>
12945 * ecore.cs (IAlias): Remove.
12946 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12947 that implement the interface.
12948 * namespace.cs (Namespace): Likewise.
12949 (Namespace.declspaces): Renamed from 'defined_names'.
12950 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12951 DeclSpace instead of an IAlias.
12952 * tree.cs (Tree.AddDecl): Update.
12954 2005-07-12 Raja R Harinath <rharinath@novell.com>
12956 * statement.cs (Block.Flags); Remove HasVarargs.
12957 (Block.HasVarargs): Move to ToplevelBlock.
12958 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12959 (Block.Variables): Make protected. Initialize variable hashtable
12961 (Block.AddVariable): Update.
12962 (Block.Resolve): Update to changes.
12963 (ToplevelBlock.HasVarargs): New boolean.
12964 (ToplevelBlock.ThisVariable): Move here from Block.
12965 (ToplevelBlock.AddThisVariable): Likewise.
12966 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12967 * expression.cs (This.ResolveBase): Update to changes.
12968 (ArglistAccess.DoResolve): Likewise.
12970 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12973 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12975 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12976 not used and not used & assigned.
12977 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12979 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12982 * expression.cs (Is.DoResolve): null is never provided type.
12984 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12987 * cs-parser.jay: Less strict event error rule to catch more errors.
12989 2005-07-08 Martin Baulig <martin@ximian.com>
12991 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12992 gettter (allowed) or setter (not allowed).
12994 * class.cs (Accessor): Implement IIteratorContainer.
12995 (Accessor.Yields): New public field.
12996 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12997 per-accessor basis.
13000 (get_accessor_declaration, set_accessor_declaration): Set the
13001 `yields' flag on the accessor, not the property.
13002 (property_declaration): Do the iterators check on a per-accessor
13003 basis and not for the whole property.
13005 2005-07-08 Martin Baulig <martin@ximian.com>
13007 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13008 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13010 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13013 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13014 (ExtractSecurityPermissionSet): Cope with self referencing security
13015 attributes properly.
13017 * driver.cs (SetOutputFile): Made public property OutputFile.
13019 2005-07-07 Raja R Harinath <rharinath@novell.com>
13022 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13023 has_nonstatic_fields. Make into a FieldBase pointer.
13024 (TypeContainer.AddField): Add CS0282 check.
13025 (TypeContainer.EmitType): Update.
13027 2005-07-06 Miguel de Icaza <miguel@novell.com>
13029 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13030 compare if they start with __.
13032 2005-07-06 Raja R Harinath <rharinath@novell.com>
13034 * statement.cs (Switch.SwitchGoverningType): Only look at
13035 UserCasts that don't need implicit standard conversions to one of
13036 the allowed switch types (Fixes test-322.cs).
13037 (LocalInfo.Resolve): Re-enable sanity-test.
13039 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13041 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13043 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13045 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13047 2005-07-06 Raja R Harinath <rharinath@novell.com>
13050 * ecore.cs (SimpleName.GetSignatureForError): Add.
13051 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13052 (MemberAccess.GetSignatureForError): Add.
13054 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13056 The big error and warning messages review.
13086 * typemanager.cs: Updated.
13088 * class.cs: (MethodCore.SetYields): Moved here to share.
13089 (PropertyMethod.Define): Moved iterator setup here.
13091 * iterators.cs: Add orig_method to have full access to parent
13094 2005-07-05 Raja R Harinath <rharinath@novell.com>
13096 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13097 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13098 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13099 variable of struct type.
13100 * expression.cs (Unary.ResolveOperator): Update to change.
13101 (Indirection.VerifyFixed): Likewise.
13102 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13103 (ParameterReference.VerifyFixed): Value parameters are fixed.
13104 (This.VerifyFixed): Treat 'this' as a value parameter.
13105 * statement.cs (LocalInfo.IsFixed): Remove.
13107 2005-07-01 Martin Baulig <martin@ximian.com>
13109 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13110 `ec.EmitThis ()' to get the correct scope.
13112 2005-07-01 Martin Baulig <martin@ximian.com>
13114 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13115 instance is a ParameterReference; fixes #75299.
13117 2005-07-01 Martin Baulig <martin@ximian.com>
13119 Reverted Marek's latest patch (r46725):
13120 - it contains structural changes which are neither mentioned in
13121 the ChangeLog nor explained anywhere; for example the additional
13122 argument of EmitContext's and Iterator's .ctor's and the
13123 TypeContainer.DefineMembers() change.
13124 - structural changes like this should go in in seperate patches
13125 and not be hidden in a huge patch which just seems to affect
13126 warnings and errors.
13127 a big and hard to understand patch.
13128 - it breaks iterators and causes regressions, for instance in
13131 2005-06-30 Raja R Harinath <rharinath@novell.com>
13134 * expression.cs (Indexers.map): Remove.
13135 (Indexers.Append): Filter out inaccessible setters and getters.
13136 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13139 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13140 Refactored from ...
13141 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13142 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13143 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13144 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13146 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13149 * class.cs (FieldBase.GetInitializerExpression): One more field
13152 2005-06-28 Miguel de Icaza <miguel@novell.com>
13154 * pending.cs: Do not define a proxy if the base method is virtual,
13155 it will be picked up by the runtime (bug 75270).
13157 2005-06-08 Martin Baulig <martin@ximian.com>
13159 The big Iterators rewrite :-)
13161 * iterators.cs: Rewrite this to use the anonymous methods framework.
13163 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13164 before the TypeContainers; see 2test-21.cs.
13167 (TypeContainer.DefineType): Don't create a new EmitContext if we
13168 already have one (this only happens if we're an Iterator).
13169 (TypeContainer.Define): Also call Define() on all our iterators.
13170 (Method.CreateEmitContext): Added support for iterators.
13173 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13174 (AnonymousContainer.CreateMethodHost): Moved here from
13175 AnonymousMethod and made abstract.
13176 (AnonymousContainer.CreateScopeType): New abstract method.
13177 (AnonymousContainer.IsIterator): New public property.
13178 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13179 get the ScopeTypeBuilder rather than manually defining it here.
13180 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13183 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13184 before RootContext.DefineTypes().
13186 * codegen.cs (EmitContext.RemapToProxy): Removed.
13187 (EmitContext.CurrentAnonymousMethod): Changed type from
13188 AnonymousMethod -> AnonymousContainer.
13189 (EmitContext.ResolveTopBlock): Protect from being called twice.
13190 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13191 (EmitContext.EmitThis): Removed the iterators hacks; use the
13192 anonymous methods framework for that.
13195 (ToplevelBlock.Container): Make this a property, not a field.
13196 (ToplevelBlock.ReParent): New public method; move the
13197 ToplevelBlock into a new container.
13198 (Foreach.TemporaryVariable): Simplify.
13200 2005-06-05 Martin Baulig <martin@ximian.com>
13202 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13203 (Block.AddTemporaryVariable): New public method; creates a new
13204 `LocalInfo' for a temporary variable.
13205 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13207 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13208 non-iterator variables.
13210 2005-06-05 Martin Baulig <martin@ximian.com>
13212 * statement.cs (Foreach.TemporaryVariable): Create the
13213 LocalBuilder in the Emit phase and not in Resolve since in some
13214 situations, we don't have an ILGenerator during Resolve; see
13215 2test-19.cs for an example.
13217 2005-06-04 Martin Baulig <martin@ximian.com>
13219 **** Merged r45395 from GCS ****
13221 The big Foreach rewrite - Part II.
13223 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13224 with `PropertyInfo ienumerator_getcurrent'.
13226 * codegen.cs (VariableStorage): Removed.
13229 (Foreach): Derive from Statement, not ExceptionStatement.
13230 (Foreach.CollectionForeach): New nested class. Moved all the code
13231 dealing with collection foreach here.
13232 (Foreach.ForeachHelperMethods): Removed.
13233 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13235 2005-05-23 Martin Baulig <martin@ximian.com>
13237 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13238 don't need to. Fix #75014.
13240 2005-05-20 Martin Baulig <martin@ximian.com>
13242 Merged r44808 from GMCS.
13244 * class.cs (TypeContainer.CircularDepException): Removed.
13245 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13246 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13247 (CS0146) and interface (CS0529) dependencies here.
13249 2005-06-21 Raja R Harinath <rharinath@novell.com>
13251 * expression.cs (Invocation.EmitCall): Fix initialization
13252 'this_call' to reflect current behaviour. Fix indentation.
13254 * convert.cs (FindMostEncompassedType): Add two trivial special
13255 cases (number_of_types == 0 || number_of_types == 1).
13256 (FindMostEncompasingType): Likewise.
13258 2005-06-17 Raja R Harinath <rharinath@novell.com>
13260 Some cleanups preparing for the fix of #75283.
13261 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13263 (EventExpr.InstanceResolve): Likewise.
13264 (EventExpr.DoResolve): Remove redundant checks.
13266 2005-06-10 Duncan Mak <duncan@novell.com>
13268 * cs-tokenizer.cs (process_directives): New flag for controlling
13269 the processing of preprocessor directives.
13270 (x_token): After seeing a '#', return Token.NONE instead of going
13271 to handle_preprocessing_directive() when not processing
13272 directives. This avoids unnecessary processing during the token peek in
13277 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13278 the existing error reporting methods instead of Report.Error.
13280 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13281 after Raja's rewrite.
13283 2005-06-08 Miguel de Icaza <miguel@novell.com>
13285 * class.cs: Small fix.
13287 2005-06-08 Raja R Harinath <rharinath@novell.com>
13290 * class.cs (GetPartialBases): Fix return value check of
13291 part.GetClassBases.
13293 2005-06-07 Raja R Harinath <rharinath@novell.com>
13295 Ensure that partial classes are registered in their enclosing
13296 namespace. Initial part of fix of #75160.
13297 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13298 Register declspace with namespace here, not in
13299 DeclSpace.RecordDecl.
13300 * cs-parser.jay: Pass namespace to RecordDecl.
13301 * class.cs (PartialContainer.Create): Likewise.
13302 (ClassPart.DefineType): New sanity-check. Throws an exception if
13304 * decl.cs (Declspace.RecordDecl): Remove.
13305 * namespace.cs (NamespaceEntry.DefineName): Remove.
13307 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13309 * rootcontext.cs: Reset TargetExt as well.
13311 2005-06-03 Raja R Harinath <rharinath@novell.com>
13313 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13314 -langversion:ISO-1.
13316 2005-06-02 Raja R Harinath <rharinath@novell.com>
13318 Fix #75080, cs0119.cs.
13319 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13321 (Expression.Resolve): ... this. Use it. Remove bogus code
13322 allowing ExprClass.Type and ExprClass.Namespace for
13323 ResolveFlags.VariableOrValue.
13324 (Expression.Resolve) [1-argument variant]: Change default resolve
13325 flags based on language version.
13326 (Expression.Error_UnexpectedKind): Use a simple string array
13327 rather than an ArrayList.
13328 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13329 not ExprClass.Type.
13330 (TypeOfVoid.DoResolve): Likewise.
13331 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13332 flags argument -- it always has the same value.
13334 2005-05-31 Raja R Harinath <rharinath@novell.com>
13337 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13338 Use it in the error message.
13339 * assign.cs, expression.cs, statement.cs: Update.
13341 2005-05-30 Raja R Harinath <rharinath@novell.com>
13344 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13345 the "almostMatchedMember" case too.
13346 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13347 that failed the accessibility checks to 'almost_match'.
13349 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13351 * attribute.cs: Use internal MethodBuilder methods to set
13352 ExactSpelling and SetLastError on PInvoke methods, instead
13353 of passing them via charset. Fixes #75060.
13355 2005-05-27 Raja R Harinath <rharinath@novell.com>
13357 * parameter.cs (Parameter): Remove TODO comment.
13358 (Parameter.DefineParameter): Remove Location parameter.
13359 (Parameters.LabelParameters): Likewise.
13360 * class.cs (Constructor.Emit): Update to change.
13361 (MethodData.Emit): Likewise.
13362 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13363 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13365 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13368 Removed Parameters.Location and added Parameter.Location instead.
13369 Removed Location parameter from Emit() and GetSignature().
13376 Modified all related calls.
13378 2005-05-26 Raja R Harinath <rharinath@novell.com>
13380 Improve user-defined conversion handling.
13381 * convert.cs (GetConversionOperators): Rewrite. Return only the
13382 applicable operators.
13383 (AddConversionOperators): New. Helper for GetConversionOperators.
13384 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13385 there is only one most encompassed/encompassing type.
13386 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13387 "applicable operator" handling.
13388 (UserConversion): Move cache here from GetConversionOperators.
13389 Directly cache the chosen operator, rather than the whole
13391 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13392 case. Allow conversion of decimal to sbyte and byte too.
13393 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13394 New static methods. Used to avoid allocating EmptyExpressions in
13397 2005-05-24 Duncan Mak <duncan@novell.com>
13399 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13400 another class, used in Convert.ExplicitNumericConversion.
13401 (CastToDecimal): New class, similar to above, but casts to
13402 System.Decimal, used in Convert.ImplicitNumericConversion and also
13403 in explicit convesion from double/float to decimal.
13405 * convert.cs (ImplicitNumericConversion): Handle implicit
13406 conversions to System.Decimal.
13407 (ExplicitNumericConversion): handle explicit conversions to
13412 2005-05-20 Miguel de Icaza <miguel@novell.com>
13414 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13415 know the type at this stage, just break through. Fixes #75008
13417 2005-05-19 Martin Baulig <martin@ximian.com>
13420 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13421 to disable error reporting.
13423 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13424 here since we don't want to report an error; see the new test-336.cs.
13426 2005-05-19 Raja R Harinath <rharinath@novell.com>
13428 * statement.cs (ToplevelBlock.GetParameterReference)
13429 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13430 Move here from class Block.
13431 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13432 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13434 2005-05-18 Martin Baulig <martin@ximian.com>
13439 (FlowBranching.Reachability): Add non-static public And() and Or()
13441 (FlowBranchingSwitch): New class; do the `break_origins' thing
13442 like in FlowBranchingLoop.
13443 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13444 reachability, not just locals and parameters.
13445 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13446 switch; MergeBreakOrigins() now takes care of that.
13448 2005-05-18 Martin Baulig <martin@ximian.com>
13450 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13451 a loop and may leave it, reset the barrier; fixes #74974.
13453 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13455 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13458 * cs-parser.jay: Catch more lexical errors.
13460 * report.cs: Add one more Error method.
13463 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13465 2005-05-17 Martin Baulig <martin@ximian.com>
13467 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13470 2005-05-16 Raja R Harinath <rharinath@novell.com>
13472 Fix test-382.cs. Emit values of decimal constants.
13473 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13475 (TypeContainer.AddField): ... this.
13476 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13477 with initializers to include 'Const's.
13478 (ClassPart.RegisterFieldForInitialization): Forward to
13480 * const.cs (Const.Const): Pass initializer to base class.
13481 (Const.Define): In case of decimal constants, register them for
13482 initialization in a static constructor.
13484 2005-05-14 Martin Baulig <martin@ximian.com>
13486 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13487 do not call ResolveUnreachable() on unreachable statements in
13488 here, see the comment in the source code.
13490 2005-05-13 Raja R Harinath <rharinath@novell.com>
13493 * expression.cs (BinaryResolveOperator): If one of the operands of
13494 an equality comparison is 'null' and the other is a pointer type,
13495 convert the null to a NullPointer.
13496 * convert.cs (ImplicitReferenceConversion): If the expression is a
13497 NullLiteral and the target type is a pointer type, return a
13498 NullPointer instead.
13499 (ImplicitConversionStandard): Likewise.
13501 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13503 * cs-parser.jay: Set readonly context based on special constructs.
13505 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13506 readonly variable error handling.
13508 * rootcontext.cs (EmitCode): Don't verify members when error
13511 * statement.cs (LocalInfo): Add reaodnly context information.
13512 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13514 2005-05-13 Raja R Harinath <rharinath@novell.com>
13516 * statement.cs (Block.Resolve): Revert change below. Modify fix
13517 for #74041 to initialize 'resolved' to false only for explicit
13518 blocks. Fixes #74873.
13520 2005-05-12 Raja R Harinath <harinath@gmail.com>
13523 * typemanager.cs (unmanaged_enclosing_types): New.
13524 (IsUnmanagedType): Avoid infloops by using
13525 'unmanaged_enclosing_types' to talk with recursive invocations.
13527 2005-05-13 Martin Baulig <martin@ximian.com>
13529 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13530 instance variable, not a local. Fix #74873.
13531 (Block.ResolveUnreachable): Set it to true here.
13533 2005-05-11 Duncan Mak <duncan@novell.com>
13535 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13536 continuing to process for 'arg'.
13537 (handle_preprocessing_directive): Check the argument of the #endif
13538 directive and report error CS1025 if there are any trailing
13541 According to the C# spec, having even whitespace after the #endif
13542 directive is illegal; however, because we call arg.TrimEnd ()
13543 beforehand, we have the same behavior as csc, allowing whitespace
13544 after the directive.
13548 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13552 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13553 (Constructor.GetObsoleteAttribute): Implemented correctly.
13555 2005-05-10 Martin Baulig <martin@ximian.com>
13557 * support.cs (ReflectionParameters.ParameterModifier): Use
13558 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13559 and `ParameterAttributes.In'. Fixes #74884.
13561 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13563 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13565 * expression.cs (Argument.GetParameterModifier): Turned to property.
13566 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13568 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13571 2005-05-09 Raja R Harinath <rharinath@novell.com>
13574 * decl.cs (MemberCache.AddMethods): Register override methods,
13575 rather than non-override methods.
13576 * typemanager.cs (RegisterOverride): New.
13577 (IsOverride): Update.
13579 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13583 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13584 recursive declaration.
13586 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13588 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13590 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13592 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13594 2005-05-05 Raja R Harinath <rharinath@novell.com>
13597 * decl.cs (DeclSpace.FamilyAccessible):
13598 Use TypeManager.IsNestedFamilyAccessible.
13600 Fix reopened #64812.
13601 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13604 2005-05-04 Raja R Harinath <rharinath@novell.com>
13605 Abin Thomas <projectmonokochi@rediffmail.com>
13606 Anoob V E <projectmonokochi@rediffmail.com>
13607 Harilal P R <projectmonokochi@rediffmail.com>
13610 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13611 allow access to all static members.
13613 2005-05-04 Martin Baulig <martin@ximian.com>
13615 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13617 2005-05-04 Martin Baulig <martin@ximian.com>
13621 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13622 section at the end; make things work if `default' is not the last
13625 2005-05-04 Martin Baulig <martin@ximian.com>
13629 * statement.cs (Switch): Replaced the `got_default' field with a
13630 `default_section' one.
13631 (Switch.CheckSwitch): Set `default_section' here.
13632 (Switch.Resolve): If we're a constant switch and the constant is
13633 not found, use the default section.
13635 2005-05-03 Martin Baulig <martin@ximian.com>
13637 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13639 * statement.cs (Foreach.ArrayForeach): New nested class.
13640 (Foreach.TemporaryVariable): New nested class.
13641 (Foreach.EmitArrayForeach): Removed; this is now in the new
13642 ArrayForeach class.
13644 2005-05-03 Raja R Harinath <rharinath@novell.com>
13646 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13648 (VerifyPendingMethods): Revert change below.
13650 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13651 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13652 that used to trigger warning -28. Remove warning -28.
13653 * expression.cs (Invocation.OverloadResolve): Use
13654 TypeManager.IsOverride to distinguish override methods.
13657 * pending.cs (VerifyPendingMethods): If a base type implements the
13658 requested interface, don't bother checking individual methods of
13659 the base type. As a side-effect, this prevents the creation of
13660 unnecessary proxies.
13662 2005-05-02 Martin Baulig <martin@ximian.com>
13666 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13667 Also `And' the locals if the old vector is null.
13668 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13669 null; in this case we basically reset all the variables.
13671 2005-05-02 Martin Baulig <martin@ximian.com>
13675 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13676 Added `FlowBranching branching' argument; always `and' the
13677 variables instead of `or'ing them unless we're an infinite loop.
13679 * statement.cs (While.Resolve): Create a new sibling unless we're
13682 2005-05-02 Martin Baulig <martin@ximian.com>
13686 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13687 arguments; use it instead of creating a new TopLevelBlock.
13688 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13689 our ConstructorInitializer.
13692 (TopLevelBlock.TopLevelBranching): New public property.
13693 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13694 and create our `TopLevelBranching'.
13696 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13697 anonymous method host, use `block.TopLevelBranching' rather than
13698 creating a new branching.
13700 2005-04-20 Miguel de Icaza <miguel@novell.com>
13702 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13703 a ScopeInfo, if any of the current children is a child of the new
13704 entry, move those children there.
13706 2005-04-30 Martin Baulig <martin@ximian.com>
13708 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13709 at the beginning of a SwitchSection. Fix #73335.
13711 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13714 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13716 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13717 (FieldExpr.DoResolve): Obsolete members are ignored for field
13720 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13722 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13723 of arrays detection.
13725 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13727 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13729 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13732 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13734 * cs-parser.jay: Use the prefered version of -unsafe in error
13737 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13739 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13742 2005-04-20 John Luke <john.luke@gmail.com>
13744 * driver.cs: fix typo in error message, --outout to --output
13746 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13748 * codegen.cs (InRefOutArgumentResolving): New field.
13750 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13751 fields outside contructor.
13753 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13755 2005-04-19 Miguel de Icaza <miguel@novell.com>
13757 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13758 parameter code was not completed ever, so it was not as up-to-date
13759 as local variables. Must finish it.
13761 The bug fix was to compare the Toplevel of the block, not the
13762 current block. Thanks for Ben for pointing this out.
13764 2005-04-19 Raja R Harinath <rharinath@novell.com>
13766 * decl.cs (AddMethods): Use the declaring type of the problem
13767 method to determine if we want to squash a warning.
13769 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13771 * attribute.cs: Removed debug output.
13773 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13775 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13778 2005-04-18 Raja R Harinath <rharinath@novell.com>
13781 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13782 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13783 all null comparisons against reference types.
13785 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13788 * class.cs (TypeContainer.CircularDepException) New nested
13790 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13791 (TypeContainer.DefineType): Removed error, reset InTransit before
13793 (Class.DefineType): Throw exception when is in Transit.
13794 Catch exception and report error.
13795 (Struct.DefineType): Throw exception when is in Transit.
13796 Catch exception and report error.
13797 (Interface.DefineType): Throw exception when is in Transit.
13798 Catch exception and report error.
13800 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13801 handle nested exception handlers.
13803 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13806 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13807 InFinally and InCatch storage.
13809 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13810 (Catch.Resolve): Set and Restore ec.InCatch.
13811 (Try.Resolve): Set and Restore ec.InFinally.
13812 (Try.HasCatch): True when try has catch.
13814 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13816 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13817 for the same event member, so exclude such cases from warning 419.
13820 2005-04-16 Miguel de Icaza <miguel@novell.com>
13822 * expression.cs (Binary.ResolveOperator): Apply patch from John
13823 Luke to fix bug 59864: operators &, | and ^ on enumerations
13824 require that the same enum type on both sides.
13826 * driver.cs: Add warnings to old flag usage, this is to assist
13827 people who produce Makefiles and hope that the Makefiles will be
13830 * class.cs (TypeContainer.EmitType): Moved the definition of the
13831 special $PRIVATE$ field from the resolve phase to the Emit phase.
13832 During resolve we do not know if we are a struct with
13833 HasExplicitLayout, we know this only after the attributes for the
13836 Set the FieldOffset to zero on the dummy field that we create for
13837 the class. Fixes 74590.
13839 2005-04-16 Raja R Harinath <rharinath@novell.com>
13842 * ecore.cs (PropertyExpr.resolved): New.
13843 (DoResolve): Use it to handle a case of double resolution here.
13844 Handle a case of identical-name-and-type-name.
13845 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13846 resolution by storing the results of expression resolution back
13847 into the "probes" array.
13849 2005-04-15 Raja R Harinath <rharinath@novell.com>
13851 Fix cs0208-7.cs and cs0208-8.cs.
13852 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13853 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13854 error reporting to point out the reason a struct is not unmanaged.
13856 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13858 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13859 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13861 2005-04-13 Raja R Harinath <rharinath@novell.com>
13864 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13865 IdenticalNameAndTypeName here.
13866 (EventExpr.InstanceResolve): Likewise.
13868 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13870 C# 2.0 DefaultCharSetAttribute implementation
13872 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13873 which allows us to set GlobalNamespace for every resolve.
13874 (Attribute.ResolveArguments): Cut from Resolve.
13875 (Attribute.GetCharSetValue): Returns CharSet named argument.
13876 (Attribute.DefinePInvokeMethod): Gets default charset from
13878 (GlobalAttribute.ResolveAsTypeStep): Override.
13879 (GlobalAttribute.ResolveArguments): Override.
13881 * class.cs (TypeAttr): Is protected.
13883 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13884 (ModuleClass.DefaultCharSetType): New memeber.
13885 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13887 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13888 charset from module.
13890 * delegate.cs (TypeAttr): Override.
13891 (Delegate.DefineType): Use this TypeAttr.
13893 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13894 at very early stage (before types are defined) to resolve model
13895 module attributes. It will probably not work with corlib but it
13898 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13899 charset from module.
13901 * typemanager.cs (default_charset_type): New type.
13903 2005-04-13 Raja R Harinath <rharinath@novell.com>
13905 * decl.cs (MemberCache.AddMethods): Don't warn if
13906 System.Object.Finalize has buggy MethodAttributes.
13908 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13911 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13913 * doc.cs : detect ambiguous reference to overloaded members.
13914 Fixed bug #71603. MS 1.1 csc does not detect it.
13916 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13918 * doc.cs : delegates must not be referenced with parameters.
13921 2005-04-12 Miguel de Icaza <miguel@novell.com>
13923 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13925 2005-04-10 Miguel de Icaza <miguel@novell.com>
13927 * driver.cs (MainDriver): Stop processing if the CLS stage found
13930 (CompilerCallableEntryPoint.InvokeCompiler): Always
13931 reset after execution; Take a TextWriter argument for the
13934 * report.cs: Use the error stream instead of hardcoding stderr.
13936 2005-04-09 Miguel de Icaza <miguel@novell.com>
13938 * class.cs: Reduce code paths to test, too small of an
13939 optimization to make it worth the extra testing. Always perform
13942 2005-04-08 Raja R Harinath <rharinath@novell.com>
13945 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13946 operators that had errors reported on them.
13948 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13950 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13952 (Attribute.Resolve): Add named argument type checking.
13954 * class.cs (FixedField.Define): Use IsPrimitiveType
13956 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13958 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13959 unsafe parameter types.
13961 * statement.cs (Using.ResolveExpression): Add better error description.
13963 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13965 2005-04-08 Raja R Harinath <rharinath@novell.com>
13968 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13969 AttributeUsageAttribute in the emitcontext of the attribute class,
13970 not in the emitcontext of the attributable entity it was attached to.
13971 * cs-parser.jay: Use 'current_class', not 'current_container',
13972 when creating a GlobalAttribute.
13974 2005-04-08 Alp Toker <alp@atoker.com>
13976 * pending.cs: The fix to #58413 failed to compile methods implementing
13977 interfaces with/without params modifiers and vice versa, even though
13978 params modifiers aren't part of the signature. Make the modifier check
13979 less strict as in csc.
13981 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13982 Anoob V E <projectmonokochi@rediffmail.com>
13983 Harilal P R <projectmonokochi@rediffmail.com>
13986 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13987 modifiers of pending methods.
13988 (PendingImplementation.PendingImplementation): Initialize it.
13989 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13990 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13991 with ParameterData. Add check for modifiers.
13992 * class.cs (MethodData.Define): Update to changes.
13994 2005-04-07 Raja R Harinath <rharinath@novell.com>
13996 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13998 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14000 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14003 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14006 * typemanager.cs: Registered RequiredAttributeAttribute.
14008 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14010 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14011 Warning CS0169 is back at level 3.
14012 (IMethodData.SetMemberIsUsed): New method.
14014 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14015 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14017 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14019 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14021 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14024 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14027 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14028 to avoid the problems with nested types.
14030 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14031 Anoob V.E <projectmonokochi@rediffmail.com>
14032 Harilal P.R <projectmonokochi@rediffmail.com>
14033 Raja R Harinath <rharinath@novell.com>
14036 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14038 * typemanager (GetConstructor): Make public.
14040 2005-04-05 John Luke <john.luke@gmail.com>
14041 Raja R Harinath <rharinath@novell.com>
14044 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14045 struct too. Return false quicker in a few cases.
14046 (VerifyUnManaged): Use it.
14048 2005-04-05 Raja R Harinath <rharinath@novell.com>
14051 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14052 not 'unreachable_seen'.
14054 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14056 * attribute.cs (Attribute.GetValue): Removed unused.
14058 * codegen.cs (CodeGen.TrimExt): Removed unused.
14060 * cs-parser.jay (output): Removed unused.
14062 * cs-tokenizer.cs (hex_digits): Removed unused.
14064 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14066 * expression.cs (Indirection.LoadExprValue): Removed unused.
14067 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14069 * iterators.cs (Iterator.param_types): Removed unused.
14071 * statement.cs (Goto.block): Removed unused.
14072 (ToplevelBlock.did): Removed unused.
14073 (Switch.ResolveConstantSwitch): Removed unused.
14075 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14077 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14080 2005-04-01 Raja R Harinath <rharinath@novell.com>
14082 Fix #74232 and cs0208-3.cs.
14083 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14084 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14085 unmanaged type. Don't use FieldBuilders when 't' is a
14086 TypeBuilder. Use ModFlags and MemberType fields.
14087 * class.cs (MemberBase.member_type): Rename from MemberType.
14088 (MemberBase.MemberType): New property. Determines member_type on
14090 (MemberBase.DoDefine): Don't initialize MemberType here.
14091 (FieldMember.Define): Likewise.
14093 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14096 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14097 Attributes are emitted there.
14099 2005-04-01 Raja R Harinath <rharinath@novell.com>
14101 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14102 keyword in 'partial enum' too.
14103 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14105 Report from Kamil Skalski <nazgul@omega.pl>.
14108 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14109 have partial containers too.
14111 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14112 in block' checks to Block.CheckInvariantMeaningInBlock.
14113 * statement.cs (Block.GetKnownVariableInfo): Make private.
14114 (Block.IsVariableUsedInChildBlock): Remove.
14115 (Block.IsVariableUsedInBlock): Likewise.
14116 (Block.CheckInvariantMeaningInBlock): New. Show location of
14117 conflicting declaration.
14118 (Block.AddVariable): Make error messages less long-winded and more
14119 specific. Show location of conflicting declaration.
14120 * parameter.cs (Parameters.Location): New readonly property.
14122 2005-03-31 Raja R Harinath <rharinath@novell.com>
14124 Clean up semantics of invoking ResolveMemberAccess.
14125 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14126 can have an instance, ensure that we pass in a non-TypeExpression
14127 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14128 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14129 argument. Update to changes and simplify.
14130 (FieldExpr.Emitinstance): Remove CS0120 check.
14131 (PropertyExpr.EmitInstance): Likewise.
14132 * expression.cs (Argument.Resolve): Likewise.
14133 (Invocation.DoResolve): Update to changes in semantics of
14134 InstanceExpression.
14136 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14139 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14142 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14144 2005-03-31 Raja R Harinath <rharinath@novell.com>
14146 Fix difference in behaviour with commandline invocation.
14147 * driver.cs (Driver.Reset): New.
14148 (CompilerCallableEntryPoint): Call it.
14150 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14151 variable" warnings if the boolean expression failed to resolve.
14153 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14155 * attribute.cs: Fix the union of several permissions when some of them
14156 are unrestricted (so the result isn't an unrestricted permission set).
14159 2005-03-30 Raja R Harinath <rharinath@novell.com>
14161 * ecore.cs (MemberExpr): New class. Convert from interface
14163 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14164 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14166 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14167 (MethodGroupExpr.IsExplicitImpl): Remove.
14168 (Expression.GetFieldFromEvent): Remove.
14169 (SimpleName.MemberStaticCheck): Remove.
14170 (SimpleName.DoSimpleNameResolve): Update to changes.
14171 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14172 (MemberAccess.IdenticalNameAndTypeName): Remove.
14173 (MemberAccess.error176): Move to MemberExpr.
14174 (MemberAccess.DoResolve): Update to changes.
14175 (BaseAccess.DoResolve): Likewise.
14177 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14179 C# 2.0 Conditional attribute class implementation
14181 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14182 Analyzes class whether it has attribute which has ConditionalAttribute
14183 and its condition is not defined.
14185 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14186 (Class.IsExcluded): New method. Search for at least one defined
14187 condition in ConditionalAttribute of attribute class.
14189 2005-03-30 Raja R Harinath <rharinath@novell.com>
14191 * ecore.cs (PropertyExpr): Derive from Expression, not
14192 ExpressionStatement.
14193 (PropertyExpr.EmitStatement): Remove.
14195 2005-03-29 Raja R Harinath <rharinath@novell.com>
14198 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14199 internal field "value__" of an enum be private. The examples for
14200 "value__" that I found on MSDN all used FieldAttributes.Private.
14202 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14203 Don't mention IL method attribute names.
14205 Fix #47991. Remove a TODO.
14206 * statement.cs (Block.Toplevel): Make into a field.
14207 (Block.Parameters): Move into ToplevelBlock.
14208 (Block.known_variables): Rename from child_variable_names.
14209 (Block.Block): Remove variants that take Parameters. Initialize
14210 'Toplevel' with the immediately surrounding toplevel block.
14211 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14212 LocalInfo parameter.
14213 (Block.GetKnownVariableInfo): New.
14214 (Block.IsVariableNameUsedInChildBlock): Update.
14215 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14216 the block, even though it may not be in scope.
14217 (Block.AddVariable): Remove Parameters parameter. Use
14218 Toplevel.Parameters instead.
14219 (Block.AddConstant): Remove Parameters parameter.
14220 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14221 (Block.IsParamaterReference): Likewise.
14222 (Block.IsLocalParameter): Likewise. Simplify a lot.
14223 (ToplevelBlock.Parameters): New. Moved from Block.
14224 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14225 initialize Parameters to a non-null value.
14226 * cs-parser.jay: Update to changes.
14227 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14228 simple names that mean different things in the same block. Use
14229 Block.IsVariableNameUsedInBlock.
14231 2005-03-28 Raja R Harinath <rharinath@novell.com>
14233 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14234 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14235 GetTypeHandle. It is possible for a reflected type to derive from
14236 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14237 System.Array during mscorlib compilation).
14238 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14239 contain a method_hash, don't create one either. Don't create a
14240 deep copy of the base cache's method_hash.
14241 (MemberCache.SetupCache): Rename back from DeepCopy.
14242 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14243 already initialized. If we see an override function, add its
14244 underlying base virtual function to the member_hash too.
14246 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14248 2005-03-26 Raja R Harinath <harinath@acm.org>
14251 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14252 fails to resolve, ensure that the LHS is still resolved as an
14255 2005-03-25 Raja R Harinath <harinath@acm.org>
14257 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14259 (Enum.current_ec): Remove.
14260 (Enum.LookupEnumValue): Remove EmitContext argument.
14261 Just uses the one created during DefineType.
14262 (Enum.FindMembers): Update.
14263 * expression.cs (MemberAccess.DoResolve): Update.
14265 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14267 * assign.cs (Assign.DoResolve): Check for CS1717 when
14268 source and target are same (uses Equals).
14270 * expression.cs (LocalVariableReference, ParameterReference,
14271 This): Implemented Equals, GetHashCode.
14273 * statement.cs (Block.GetParameterReference): Removed useless
14276 2005-03-22 Raja R Harinath <rharinath@novell.com>
14279 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14280 blocks before deciding whether the error is cs0136 or cs0128.
14282 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14283 (using_alias_directive, using_namespace_directive): Pass
14284 MemberName, not an expression to Namespace.UsingAlias and
14286 (MakeName): Use the MemberName of the namespace.
14287 * namespace.cs (Namespace.MemberName): New.
14288 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14289 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14291 * decl.cs (MemberName.Name): Make readonly.
14292 (MemberName.FromDotted): New "constructor".
14293 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14294 (MemberCore.Name): Compute from MemberName on demand.
14295 (MemberCore.SetMemberName): Provide a way to change the
14297 (MemberCore.AddToContainer): Don't take a fullname parameter.
14298 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14299 fully qualified name of the container to the member name.
14300 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14301 only if the type is a member of the root container.
14302 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14303 MemberName.Left rather than searching for an embedded ".".
14304 (PartialContainer.CreatePart): Update to changes in RootContext.
14305 (MemberBase.ShortName): Turn into a property. Use
14306 MemberCore.SetMemberName.
14307 (MemberBase.ExplicitInterfaceName): Remove.
14308 (MemberBase.UpdateMemberName): Remove.
14309 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14310 (PropertyBase.SetMemberName): New override.
14311 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14312 (Tree.GetDecl): New.
14313 (Tree.AllDecls): Rename from Decls.
14314 * attribute.cs, enum.cs, report.cs: Update to changes.
14315 * driver.cs (MainDriver): Use MemberName.FromDotted on
14316 RootContext.MainClass.
14318 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14320 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14323 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14325 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14327 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14328 property accessor modifiers.
14330 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14331 fixed buffer attribute (CS1716).
14332 (PropertyMethod.HasCustomAccessModifier): When property accessor
14333 has custom modifier.
14335 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14337 (PropertyExpr.DoResolveLValue): Add CS0272.
14339 2005-03-17 Miguel de Icaza <miguel@novell.com>
14341 * convert.cs: When converting to a pointer, use the proper Conv.U
14342 or Conv.I depending on the source data type.
14344 * cs-tokenizer.cs: Make the size for large decimal constants,
14347 2005-03-17 Martin Baulig <martin@ximian.com>
14349 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14350 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14352 2005-03-17 Martin Baulig <martin@ximian.com>
14354 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14355 to bool so we can return an error condition.
14356 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14359 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14361 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14364 2005-03-16 Raja R Harinath <rharinath@novell.com>
14366 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14367 Refactor to avoid traversing the list of assemblies, and to avoid
14368 string concatenation.
14369 * typemanager.cs (guid_attr_type): Remove.
14370 (negative_hits, pointers, references): Remove hashes.
14372 (GetConstructedType): New. Uses type_hash to handle constructed
14373 types (arrays, references, pointers).
14374 (GetReferenceType, GetPointerType): Use it.
14375 (GetNestedType): New. Uses type_hash to handle nested types of
14377 (LookupType, LookupTypeDirect): Remove.
14378 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14379 'types' hash and LookupTypeReflection directly.
14380 (params_string, params_object): Use GetConstructedType.
14381 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14383 (Namespace.Lookup): Use cached_types.
14384 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14385 provided by old TypeManager.LookupType.
14386 * rootcontext.cs (MakeFQN): Remove.
14387 * decl.cs (DeclSpace.MakeFQN): Likewise.
14388 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14389 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14390 TypeManager.GetConstructedType.
14391 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14393 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14395 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14398 * cs-parser.jay: Reports CS1527 for any namespace element.
14400 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14403 * expression.cs (ParameterReference.IsAssigned): Changed error to
14405 (Error_WrongNumArguments): Moved CS0245 detection here.
14407 * statement.cs (Return.Resolve): Add CS1622 report.
14409 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14411 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14413 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14415 * attribute.cs expression.cs: Get rid of some allocations.
14417 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14419 * doc.cs : just eliminate the latest change.
14421 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14423 * doc.cs : commented out the latest change. It breaks xml-030.cs
14425 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14427 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14428 fail. So invoke CreateType() in FindDocumentedType().
14430 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14432 * cs-tokenizer.cs : added IsKeyword().
14433 * doc.cs : Detect keyword incorrectly used as identifier.
14434 Allow identifiers prefixed by @.
14436 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14438 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14439 It caused exception in namespace resolving (again!).
14441 * class.cs (Class.ctor): Removed exit.
14442 (PropertyMethod.ctor): ditto.
14444 * codegen.cs (Codegen.Reset): Reset static data.
14445 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14447 * cs-tokenizer.cs (Cleanup): Removed.
14449 * driver.cs (GetSystemDir): Rewrote to one line command.
14450 It caused problem with unloaded dynamic modules.
14451 (UnixParseOption): Removed Exit.
14452 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14453 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14454 Now can be mcs used as library.
14456 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14459 * location.cs (Reset): Reset static data.
14461 * namespace.cs (Reset): Reset static data.
14463 * report.cs (Report.Reset): Reset static data.
14465 * rootcontext.cs (RootContext.Reset): Reset static data.
14467 * tree.cs (RootTypes.ctor): Use Location.Null
14469 * typemanager.cs (TypeManager.Reset): Reset static data.
14470 (CoreLookupType): Removed Exit.
14471 (TypeHandle.Reset): Reset static data.
14473 2005-03-10 Raja R Harinath <rharinath@novell.com>
14476 * typemanager.cs (ComputeNamespaces): Import namespaces from
14477 referenced modules too.
14479 2005-03-09 Raja R Harinath <rharinath@novell.com>
14481 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14484 2005-03-09 Raja R Harinath <rharinath@novell.com>
14486 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14487 enclosing DeclSpace. This ensures that a name-lookup populates
14488 more caches and there are fewer 'TypeExpression's. Carve out
14489 nested type lookup into ...
14490 (LookupNestedTypeInHierarchy): ... this.
14492 2005-03-09 Raja R Harinath <rharinath@novell.com>
14494 Clean up a few partial-class semantics.
14495 Fixes test-357.cs and cs1618-2.cs.
14496 * cs-parser.jay (struct_declaration): Use 'current_class' as
14497 parent of newly-created struct. Remove call to Register ().
14498 Use 'pop_current_class' to complete handing the current struct.
14499 (interface_declaration): Likewise.
14500 (class_declaration): Likewise.
14501 (enum_declaration): Use 'current_class' as parent of newly created
14503 (delegate_declaration): Likewise.
14504 (pop_current_class): New function. This is used to handle closing
14505 up the 'current_class' and 'current_container', and pointing them
14506 to the enclosing class/container.
14507 (CSharpParser): Initialize 'current_class' too.
14508 * decl.cs (MemberCore): Add check for invariant: a partial
14509 container is not a parsed entity, and thus does not enclose any
14511 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14512 (DeclSpace.BaseTypeExpr): Use it.
14513 (DeclSpace.LookupType): Add check for invariant.
14514 * class.cs (TypeContainer): Add check for invariant: a nested
14515 class should have the same NamespaceEntry as its enclosing class.
14516 (TypeContainer.EmitFieldInitializers): Make virtual.
14517 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14519 (TypeContainer.Register): Remove.
14520 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14521 null. Use TypeResolveEmitContext for resolving base types and
14522 interfaces. Move initialization of Parts.TypeBuilder here from
14524 (TypeContainer.DefineNestedTypes): ... here.
14525 (PartialContainer): Take a Namespace not a NamespaceEntry.
14526 (PartialContainer.Create): Don't use Register. Call the
14527 appropriate Add... function directly.
14528 (ClassPart): Take both the PartialContainer and the enclosing
14529 class as constructor arguments.
14530 (ClassPart.EmitFieldInitializers): Override.
14531 (ClassPart.PartFindNestedTypes): Remove.
14532 (FieldBase.GetInitializerExpression): Resolve the initializer
14533 expression in the emit context of the enclosing class.
14534 * tree.cs (RootTypes): Remove Register ().
14536 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14538 * cs-parser.jay: Removed CS0134.
14540 * driver.cs: Removed CS1901.
14542 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14543 for predefined types.
14545 2005-03-07 Duncan Mak <duncan@novell.com>
14547 * codegen.cs (Save): Catch UnauthorizedAccessException as
14548 well. Fixes bug #73454.
14550 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14552 * cs-tokenizer.cs (xtoken): Add CS1035.
14554 * class.cs (MethodData.Define): Add CS0683.
14555 (FieldMember.ctor): Add CS0681.
14557 2005-03-07 Raja R Harinath <rharinath@novell.com>
14559 * ecore.cs (SimpleName.DoResolve): Rename from
14560 SimpleName.DoResolveAllowStatic.
14561 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14562 Pass 'intermediate' flag to MemberStaticCheck.
14563 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14564 of "intermediate" lookups via MemberAccess.
14565 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14566 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14568 2005-03-07 Raja R Harinath <rharinath@novell.com>
14571 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14572 slipped in because of variable names that are identical to a
14573 builtin type's BCL equivalent ('string String;', 'int Int32;').
14574 (PropertyExpr.EmitInstance): Likewise.
14576 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14578 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14580 * report.cs (warning_ignore_table): Made public.
14582 2005-03-04 Raja R Harinath <rharinath@novell.com>
14585 * class.cs (MethodData.Emit): Pass 'container' to
14586 container.GetObsoleteAttribute instead of 'container.Parent'.
14588 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14590 * cs-parser.jay: Add 1534 error test.
14592 * iterators.cs (Yield.CheckContext): Add error 1629.
14593 (Iterator.ctor): Save unsafe modifier.
14594 (MoveNextMethod.DoEmit): Restore unsafe context.
14596 * namespace.cs (UsingAlias): Better error message.
14598 2005-03-03 Dan Winship <danw@novell.com>
14600 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14601 the warning message [#73219]
14603 2005-03-03 Raja R Harinath <rharinath@novell.com>
14605 Fix compile with MCS 1.0.0.0.
14606 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14607 w_restore to not depend on string constant folding.
14609 2005-03-03 Raja R Harinath <rharinath@novell.com>
14611 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14612 CS0246 check to users who passed 'silent = false'.
14613 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14615 (SimpleName.SimpleNameResolve): Update.
14616 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14617 (MemberAccess.IdenticalNameAndTypeName): Update.
14618 * doc.cs (FindDocumentedTypeNonArray): Update.
14620 2005-03-03 Raja R Harinath <rharinath@novell.com>
14622 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14623 * parameters.cs (ComputeAndDefineParameters): Remove.
14624 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14625 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14626 Use GetParameterInfo.
14628 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14630 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14632 2005-03-02 Raja R Harinath <rharinath@novell.com>
14634 Unify DeclSpace.LookupType and DeclSpace.FindType.
14635 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14636 is in charge of defining nested types on demand.
14637 (DeclSpace.LookupType): Use it when the current_type is a
14638 TypeBuilder. Use LookupTypeDirect for reflected types.
14639 (DeclSpace.FindType): Remove.
14640 (DeclSpace.LookupInterfaceOrClass): Likewise.
14641 (DeclSpace.DefineTypeAndParents): Likewise.
14642 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14643 DeclSpace.LookupType.
14644 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14645 * typemanager.cs (LookupType): Simplify.
14646 (AddUserType): Remove type from negative_hits.
14647 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14648 * class.cs (TypeContainer.FindMembers): Move handling of nested
14650 (TypeContainer.FindMembers_NestedTypes): ... here.
14651 (TypeContainer.FindNestedType): Implement override.
14652 (ClassPart.FindNestedType): Delegate to PartialContainer.
14653 (ClassPart.PartFindNestedType): Looks up the nested types of the
14656 2005-03-02 Martin Baulig <martin@ximian.com>
14658 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14659 static constructor in static classes.
14661 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14663 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14664 sizeParamIndex is not specified.
14666 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14669 * report.cs (WarningMessage.IsEnabled): Missing null check.
14671 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14673 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14674 in the fields and not in the properties.
14676 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14678 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14681 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14683 * attribute.cs: Small refactoring (improved robustness).
14684 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14685 (ValidateGuid): Removed.
14686 (Resolve): Removed referenced to above mentioned.
14687 (GetAttributeUsage): Made private and changed to work without
14689 (GetIndexerAttributeValue): Don't crash.
14690 (GetConditionalAttributeValue): Ditto.
14691 (GetClsCompliantAttributeValue): Ditto.
14692 (ExtractSecurityPermissionSet): All attributes exceptions are
14694 (GetPropertyValue): New helper.
14695 (GetMethodImplOptions): New method.
14696 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14697 some missing properties.
14699 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14700 (Method.ApplyAttributeBuilder): Updated.
14702 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14705 2005-02-28 Raja R Harinath <rharinath@novell.com>
14708 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14709 non-simple types (array, pointer, reference).
14711 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14713 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14715 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14717 (Method.CheckBase): Catch wrong destructor here.
14718 (MethodData.Define): Add errors 550, 668.
14720 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14722 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14724 * pending.cs (VerifyPendingMethods): Add error 551.
14726 * typemanager.cs (CSharpName): Next error report helper.
14728 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14730 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14731 attributes. Removed useless attribute double check.
14732 It saves almost 2MBs for corlib.
14734 2005-02-25 Raja R Harinath <rharinath@novell.com>
14737 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14738 called twice in case of error.
14740 2005-02-23 Chris Toshok <toshok@ximian.com>
14742 Fix compiler portions of #72827.
14743 * statement.cs (Block.Emit): call Begin/EndScope on the
14744 EmitContext instead of the ILGenerator.
14746 * codegen.cs (EmitContext.BeginScope): new method, call
14747 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14749 (EmitContext.BeginScope): same, but EndScope and CloseScope
14751 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14752 offset and call the superclass's OpenScope(int) with it.
14753 (SymbolWriter.CloseScope): get the current il
14754 offset and call superclass's CloseScope(int) with it.
14756 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14758 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14759 CS1677 for out and ref as well.
14761 * class.cs (Method.Define): Add error CS1599 detection.
14763 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14765 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14767 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14769 * support.cs.cs (ModifierDesc): New helper method.
14771 2005-02-23 Raja R Harinath <rharinath@novell.com>
14772 Abin Thomas <projectmonokochi@rediffmail.com>
14773 Anoob V E <projectmonokochi@rediffmail.com>
14774 Harilal P R <projectmonokochi@rediffmail.com>
14776 Fix #57851, #72718.
14777 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14778 MemberLookup (used for error reporting) actually returns a result.
14779 Fix error report number (122, not 112).
14781 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14782 Anoob V E <projectmonokochi@rediffmail.com>
14783 Harilal P R <projectmonokochi@rediffmail.com>
14786 * pending.cs (PendingImplementation.GetAbstractMethods):
14787 Find NonPublic members too.
14789 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14791 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14794 * class.cs (MethodCore.CheckMethodAgainstBase):
14795 Add error 239 report.
14797 2005-02-21 Raja R Harinath <rharinath@novell.com>
14800 * expression.cs (Invocation.IsApplicable): Make public.
14801 (Invocation.IsParamsMethodApplicable): Likewise.
14802 * delegate.cs (Delegate.VerifyApplicability): Don't use
14803 Invocation.VerifyArgumentCompat for parameter applicability
14804 testing. Use Invocation.IsApplicable and
14805 Invocation.IsParamsMethodApplicable.
14807 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14809 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14811 * class.cs (Operator.Define): Add error 217 report.
14813 2005-02-21 Raja R Harinath <rharinath@novell.com>
14815 * namespace.cs (UsingEntry.Resolve): Undo change below.
14817 2005-02-21 Raja R Harinath <rharinath@novell.com>
14820 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14821 disable the error message when the extended MemberLookup also
14823 (Expression.MemberLookupFinal): Update.
14824 (SimpleName.DoSimpleNameResolve): Update.
14825 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14826 Don't use MemberLookupFinal.
14827 (New.DoResolve): Update.
14828 (BaseAccess.CommonResolve): Update.
14830 2005-02-21 Raja R Harinath <rharinath@novell.com>
14833 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14834 occured previously, don't resolve again.
14836 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14839 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14840 argument. Call ResolveAttributeUsage for unresolved.
14841 when types doesn't match ctor arguments.
14843 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14844 for nested attribute classes.
14845 (Class.attribute_usage): Removed.
14846 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14847 for attribute class.
14849 * ecore.cs (IsAttribute): Removed.
14851 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14853 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14855 (attribute_types): Removed.
14856 (EmitCode): Global attributes are emited as the latest.
14858 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14860 * class.cs (EmitFieldInitializers): Don't emit field initializer
14861 for default values when optimilization is on.
14863 * constant.cs (Constant.IsDefaultValue): New property.
14865 * driver.cs: Add /optimize handling.
14869 * literal.cs: Implement new IsDefaultValue property.
14871 * rootcontext.cs (Optimize): New field, holds /optimize option.
14873 2005-02-18 Raja R Harinath <rharinath@novell.com>
14875 Fix crasher in re-opened #72347.
14876 * namespace.cs (Namespace.Lookup): Return null if
14877 DeclSpace.DefineType returns null.
14880 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14882 2005-02-18 Raja R Harinath <rharinath@novell.com>
14884 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14885 now returns null if it cannot resolve to an lvalue.
14886 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14887 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14888 returned null. Remove check for SimpleName.
14889 (EventExpr.DoResolveLValue): New.
14890 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14891 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14893 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14894 avoid CS0131 error.
14895 (Unary.ResolveOperator): Move CS0211 check ...
14896 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14898 (Unary.DoResolveLValue): Simplify.
14899 (AddressOf.DoResolveLValue): New.
14900 (ArrayAccess.DoResolveLValue): New.
14902 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14904 * attribute.cs (Attribute.Resolve): Add arguments casting for
14905 when types doesn't match ctor arguments.
14907 2005-02-16 Raja R Harinath <rharinath@novell.com>
14909 Fix parts of #63202.
14910 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14911 lookup of operator in base type. Ensure that all checks happen
14912 when the operator resolves to an "op_..." method.
14914 2005-02-15 Raja R Harinath <rharinath@novell.com>
14917 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14918 'ignore_cs0104' parameter. Pass it to ...
14919 (NamespaceEntry.Lookup): ... this.
14920 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14921 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14922 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14923 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14924 Update. Request that cs0104 errors be ignored.
14925 (ComposedCast.ResolveAsTypeStep): Update.
14927 2005-02-14 Raja R Harinath <rharinath@novell.com>
14930 * expression.cs (Invocation.BetterFunction): Remove support for
14931 comparing virtual functions and their overrides.
14932 (Invocation.IsOverride): New.
14933 (Invocation.OverloadResolve): Don't consider 'override' functions
14934 during candidate selection. Store them in a lookaside list.
14935 If the selected method is a 'virtual' function, use the list to
14936 find any overrides that are closer to the LHS type.
14938 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14940 * expression.cs (New.DoResolve): Add complex core type reduction.
14941 (New.Constantify): Converts complex core type syntax like 'new int ()'
14942 to simple constant.
14944 2005-02-14 Raja R Harinath <rharinath@novell.com>
14946 * decl.cs (EntryType.EntryType): New constructor to create an
14947 updated copy of a cache entry.
14948 (MemberCache.AddMethods): Use it.
14949 (MemberCache.ClearDeclaredOnly): Remove.
14950 (MemberCache.MemberCache): Update.
14952 2005-02-11 Miguel de Icaza <miguel@novell.com>
14954 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14955 variable. This one is represents the actual low-level declaration
14956 of the method, as opposed to the semantic level `IsStatic'.
14958 An anonymous method which is hosted into a static method might be
14959 actually an instance method. IsStatic would reflect the
14960 container, while MethodIsStatic represents the actual code
14963 * expression.cs (ParameterReference): Use the new MethodIsStatic
14964 instead of IsStatic.
14966 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14967 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14968 set on the current EmitContext.
14970 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14971 resolve our casted expression as an LValue. This triggers the
14972 proper LValue processing that is later required by Assign.
14976 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14978 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14980 C# 2.0 Fixed buffer implementation
14982 * anonymous.cs: Update after RegisterHelperClass renaming.
14984 * attribute.cs (AttributeTester.fixed_buffer_cache):
14985 Cache of external fixed buffers.
14986 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14987 implementation if field is fixed buffer else null.
14990 (TypeContainer.AddField): Accept FieldMember instead of Field.
14991 (FieldBase.IsFieldClsCompliant): Extracted code from
14992 VerifyClsCompliance descendant customization.
14993 (FixedField): New class handles fixed buffer fields.
14994 (FixedFieldExternal): Keeps information about imported fixed
14996 (IFixedField): Make access to internal or external fixed buffer
14999 * cs-parser.jay: Add fixed buffer parsing.
15001 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15004 * expression.cs (Indirection): Extended implementation to accept
15005 fixed buffer field.
15006 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15007 (ElementAccess.MakePointerAccess): Get type as parameter.
15008 (DoResolve): Add fixed buffer field expression conversion.
15009 (DoResolveLValue): Ditto.
15010 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15011 (ArrayPtr): Derives from FixedBufferPtr.
15012 (ArrayPtr.Emit): Add extra emit for array elements.
15014 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15016 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15017 for compiler generated types.
15018 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15020 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15021 and consume less memory.
15022 (Fixed.Resolve): Add fixed buffer case.
15024 * typemanager.cs (compiler_generated_attr_ctor,
15025 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15026 (HasElementType): Add our own implementation to work on every
15029 2005-02-11 Miguel de Icaza <miguel@novell.com>
15031 * anonymous.cs (CaptureContext): Track whether `this' has been
15034 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15035 only captured `this' if it was implicitly done (instance
15036 methods/variables were used).
15038 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15039 `this' must be captured.
15041 2005-01-30 Miguel de Icaza <miguel@novell.com>
15043 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15044 is null it means that there has been no need to capture anything,
15045 so we just create a sibling.
15047 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15049 Just a partial fix. The other half is fairly elusive.
15051 2005-02-10 Raja R Harinath <rharinath@novell.com>
15053 Fix #52586, cs0121-4.cs.
15054 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15055 and return a hashtable.
15056 (MemberCache.ClearDeclaredOnly): New.
15057 (MemberCache.MemberCache): Update to change. Make a deep copy of
15058 the method_hash of a base type too.
15059 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15060 type methods. Overwrite entries with the same MethodHandle so
15061 that the ReflectedType is correct. The process leaves in base
15062 virtual functions and their overrides as distinct entries.
15063 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15064 matters since it was boxed in a ArrayList before.
15065 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15067 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15068 case of a virtual function and its override (choose the overload
15070 (Invocation.OverloadResolve): Avoid 'override' members during
15071 'applicable_type' calculation.
15073 2005-02-09 Raja R Harinath <rharinath@novell.com>
15075 Combine two near-redundant caches.
15076 * typemanager.cs (method_params): Rename from method_internal_params.
15077 (TypeManager.GetParameterData): New. Replace
15078 Invocation.GetParameterData.
15079 (TypeManager.LookupParametersByBuilder): Remove.
15080 * expression.cs (Invocation.method_parameter_cache): Remove.
15081 (Invocation.GetParameterData): Remove.
15083 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15086 2005-02-08 Raja R Harinath <rharinath@novell.com>
15089 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15090 TypeManager.multicast_delegate_type is null, resolve it by looking
15091 up "System.MulticastDelegate".
15092 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15094 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15095 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15096 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15099 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15100 (LabeledStatement.AddReference): New. Set 'referenced'.
15101 (Goto.Resolve): Use it.
15103 2005-02-05 John Luke <john.luke@gmail.com>
15105 * driver.cs: remove duplicate -doc line in Usage ()
15107 2005-02-04 Raja R Harinath <rharinath@novell.com>
15109 * location.cs (Location.AddFile): Fix CS2002 error report.
15111 2005-02-02 Martin Baulig <martin@ximian.com>
15113 * delegate.cs (Delegate.DefineType): Report an internal error if
15114 TypeManager.multicast_delegate_type is null. See bug #72015 for
15117 2005-02-02 Raja R Harinath <rharinath@novell.com>
15119 Fix a crasher in a variant of #31984.
15120 * const.cs (Constant.CheckBase): New override that defers the
15121 new-or-override check in case the base type hasn't been populated
15123 (Constant.Define): Ensure the new-or-override check is performed.
15125 2005-02-01 Duncan Mak <duncan@ximian.com>
15127 * const.cs (LookupConstantValue): Check that `ce' is not null
15128 before calling GetValue ().
15130 2005-02-01 Raja R Harinath <rharinath@novell.com>
15132 Fix test-334.cs (#69519).
15133 * cs-parser.jay (using_alias_directive): Pass in an expression to
15134 NamespaceEntry.UsingAlias.
15135 (using_namespace_directive): Pass in an expression to
15136 NamespaceEntry.Using.
15137 (namespace_name): Don't flatten to a string.
15138 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15139 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15141 (NamespaceEntry.UsingEntry): Likewise.
15142 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15144 (NamespaceEntry.LookupForUsing): Remove.
15145 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15147 (NamespaceEntry.Lookup): Remove support for dotted names.
15149 2005-02-01 Raja R Harinath <rharinath@novell.com>
15151 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15153 (NamespaceEntry.ImplicitParent): Compute on demand.
15154 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15155 parallels the current.
15156 (NamespaceEntry.LookupForUsing): Use it.
15157 (NamespaceEntry.Lookup): If the current namespace-entry is
15158 implicit, don't search aliases and using tables.
15160 2005-02-01 Raja R Harinath <rharinath@novell.com>
15163 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15165 (TypeContainer.BaseCache): Compute on demand.
15166 (TypeContainer.FindMembers): Define constants and types if they're
15167 not already created.
15168 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15170 * const.cs (Constant.Define): Make idempotent.
15172 2005-01-29 Miguel de Icaza <miguel@novell.com>
15174 * pending.cs: Produce better code (no nops produced by using Ldarg
15177 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15178 i - 1' it should be arg + 1.
15182 2005-01-28 Raja R Harinath <rharinath@novell.com>
15184 * attribute.cs (Attribute.CheckAttributeType): Make private
15186 (Attribute.ResolveType): Make virtual.
15187 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15188 handling of RootContext.Tree.Types.
15190 2005-01-27 Raja R Harinath <rharinath@novell.com>
15192 Update attribute-handling to use the SimpleName/MemberAccess
15194 * cs-parser.jay (attribute): Pass in an expression to the
15195 constructors of Attribute and GlobalAttribute.
15196 * attribute.cs (Attribute): Take an expression for the name.
15197 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15198 passed in attribute name expression.
15199 (Attribute.CheckAttributeType): Use it.
15200 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15201 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15202 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15203 argument to prevent error messages if the lookup fails.
15205 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15207 * expression.cs (Indirection): Implemented IVariable interface
15208 to support indirection in AddressOf operator.
15209 (PointerArithmetic.Emit): Add optimalization for case where
15210 result can be precomputed.
15212 2005-01-26 Martin Baulig <martin@ximian.com>
15214 * class.cs (TypeContainer.AttributeTargets): Return the correct
15215 AttributeTargets depending on our `Kind' instead of throwing an
15216 exception; fixes #71632.
15218 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15221 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15224 2005-01-25 Raja R Harinath <rharinath@novell.com>
15227 * expression.cs (MemberAccess.DoResolve): Don't complain with
15228 cs0572 when the LHS of a member access has identical name and type
15231 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15234 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15236 Create custom PermissionSet only for PermissionSetAttribute.
15238 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15241 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15242 delegates in static class.
15244 2005-01-24 Martin Baulig <martin@ximian.com>
15246 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15247 merging an implicit block, just use its reachability.
15249 * statement.cs (Block.Resolve): Make the unreachable code check
15250 work wrt. implicit blocks; see test-337 from #63842.
15252 2005-01-21 Alp Toker <alp@atoker.com>
15254 * cs-parser.jay: destructor_declaration's container is PartialContainer
15255 not Class when partial types are used, so use Kind prop instead of
15258 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15260 * cs-parser.jay: Improve error reporting when an interface
15261 declares new types.
15263 2005-01-20 Dick Porter <dick@ximian.com>
15265 * support.cs: SeekableStreamReader fix from Sandor Dobos
15266 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15267 chars are read. Fixes bug 70369.
15269 2005-01-20 Raja R Harinath <rharinath@novell.com>
15271 * cs-parser.jay (catch_clause): Simplify current_block handling
15274 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15276 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15277 code with ImplicitStandardConversion to handle the implicit
15278 conversion of method groups into valid delegate invocations.
15280 The problem is that in parameter handling we were using this code
15281 path. Fixes bug #64698
15283 2005-01-19 Raja R Harinath <rharinath@novell.com>
15285 * cs-parser.jay: Fix several infelicities.
15286 - Avoid assigning to the parser value stack. Code like
15287 '$3 = null' is unclean. Synthesize a value for the code block
15289 - Avoid using oob_stack for storing location information. Use ...
15290 (_mark_): ... this. New (empty) rule. Saves the current location
15292 (foreach_statement): Avoid using oob_stack for current_block
15293 handling. Use technique used in for_statement and
15294 using_statement. Synthesize a value for the code block to store
15295 additional intermediate information.
15297 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15299 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15300 of a different type is only allowed to private fields of a
15301 containing type, not on fields of a base class.
15303 See test-174.cs and error cs0122-9.cs
15305 2005-01-13 Raja R Harinath <rharinath@novell.com>
15307 Fix test-335.cs (bug #58126).
15308 * cs-parser.jay (argument): Split out non-expression parts of the
15309 rule into 'non_simple_argument'.
15310 (invocation_expression): Support parenthesized invocations with
15311 multiple arguments, and with single non-simple arguments.
15313 2005-01-13 Raja R Harinath <rharinath@novell.com>
15315 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15318 2005-01-12 Raja R Harinath <rharinath@novell.com>
15320 Fix cs0038-1.cs, cs1640-6.cs.
15321 * ecore.cs (Expression.Resolve): Remove special-case for
15322 SimpleName in error-handling.
15323 (Expression.almostMatchedMembers): Relax access permission to
15325 (Expression.MemberLookupFailed): Handle duplicates in
15326 almostMatchedMembers list.
15327 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15328 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15329 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15330 overload if the passed in MemberInfo is a MethodBase.
15332 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15335 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15336 for non-CAS & merge permission sets properly.
15338 2005-01-11 Raja R Harinath <rharinath@novell.com>
15340 Improve standard-compliance of simple name and member access
15341 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15342 * ecore.cs (FullNamedExpression): New abstract base class
15343 for Namespaces and TypeExpressions.
15344 (ResolveFlags.SimpleName): Remove.
15345 (SimpleName): Remove support for dotted names.
15346 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15347 DeclSpace.FindType and DeclSpace.LookupType.
15348 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15349 (Expression.ExprClassName): Make member function.
15350 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15351 a namespace. Remove creation of dotted "SimpleName"s.
15352 (MemberAccess.DoResolve): Likewise.
15353 * decl.cs (DeclSpace.Cache): Make private.
15354 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15355 (DeclSpace.FindType): Update.
15356 (DeclSpace.LookupType): Move here from RootContext. Return a
15357 FullNamedExpression.
15358 * namespace.cs (Namespace): Derive from FullNamedExpression
15359 so that it can be part of expression resolution.
15360 (Namespace.Lookup): Return an FullNamedExpression.
15361 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15363 * rootcontext.cs (NamespaceLookup): Remove.
15364 (LookupType): Move to DeclSpace.
15365 * attribute.cs (CheckAttributeType): Update.
15366 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15367 (FindDocumentedTypeNonArray): Likewise.
15369 2005-01-11 Raja R Harinath <rharinath@novell.com>
15371 Fix cs0509.cs, cs1632.cs.
15372 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15373 is the same as IsInterface.
15374 (TypeContainer.GetClassBases): Likewise.
15375 * statement.cs (LabeledStatement.ig): New field.
15376 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15378 (LabeledStatement.DoEmit): Check that the label was created with
15379 the same ILGenerator.
15381 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15384 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15385 accessors to its properties.
15387 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15388 from accessors to property.
15390 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15393 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15394 only for overrides.
15396 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15398 * attribute.cs: Check for null and empty strings.
15400 I have lost another battle to Paolo.
15402 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15405 * class.cs (PropertyMethod): Set Parent field in ctors.
15406 (SetMethod.InternalParameters): Add unsafe switch hack.
15407 Override MarkForDuplicationCheck where it is appropriate.
15409 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15410 It says whether container allows members with the same name.
15411 Base default is no.
15412 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15413 Removed is_method parameter.
15415 2005-01-06 Duncan Mak <duncan@ximian.com>
15417 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15418 because the previous change led to incorrect reporting of CS1032
15419 ("Cannot define/undefine preprocessor symbols after first token in
15420 file"). Instead of using `tokens_seen' as the only flag that
15421 triggers CS1040, introduce `comments_seen'. This new flag is used
15422 to signify having seen comments on the current line, so it is
15423 unset after a newline.
15425 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15427 * doc.cs : When searching for a type, find nested type too.
15428 This fixes bug #71040.
15430 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15433 - Warn missing member comment on those classes which also does not
15434 have doc comments. Fixed bug #71041.
15435 - Don't warn missing doc comment on default constructor.
15438 2005-01-06 Duncan Mak <duncan@ximian.com>
15440 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15441 comments, set `tokens_seen' to true. This allows us to detect
15442 misplaced preprocessor directives (i.e. not at the beginning of
15443 the a line, nor after whitespaces). In that case, report error
15444 CS1040. This fixes bug #56460.
15446 * cs-parser.jay (interface_member_declaration): Add checks for
15447 IsExplicitImpl, and report CS0541 error if an interface member is
15448 defined as an explicit interface declaration.
15450 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15453 * class.cs (PropertyMethod): Set Parent field in ctors.
15454 (SetMethod.InternalParameters): Add unsafe switch hack.
15456 * decl.cs (MemberCore.Parent): Cannot be readonly.
15458 2005-01-06 Raja R Harinath <rharinath@novell.com>
15460 * decl.cs (DeclSpace.ResolveType): Remove.
15461 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15462 Merge in code from ...
15463 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15464 * class.cs, enum.cs: Update to changes.
15466 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15468 * anonymous.cs: Ensure that we init the scope of our parent if it
15469 has not been initialized yet.
15471 2004-12-30 Duncan Mak <duncan@ximian.com>
15473 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15474 if field.FieldBuilder is null. Fixes #70758.
15476 * convert.cs: Fixed some typos and updated some of the comments.
15477 (ImplicitStandardConversionExists):
15478 (TryImplicitIntConversion): If `target_type' is an interface and
15479 the type of `ic' implements this interface, return true or a new
15480 BoxedCast instead of null. This fixes #70468.
15482 2004-12-29 Duncan Mak <duncan@ximian.com>
15484 * expression.cs (Argument.Emit): Check that Expr is
15485 IMemoryLocation before casting to it, and report CS1510 otherwise.
15489 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15491 * statement.cs (Block.ThisVariable): remove the recursion here, to
15492 make the --profile more sane.
15494 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15496 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15497 assembly, by JB Evain.
15499 2004-12-17 Raja R Harinath <rharinath@novell.com>
15501 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15502 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15503 "parent" refers to enclosing type/class. "base" refers to superclass.
15505 2004-12-17 Raja R Harinath <rharinath@novell.com>
15507 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15508 Ensure that we only have GlobalAttributes.
15509 * attribute.cs (Attribute.Emit): Make non-virtual.
15510 (GlobalAttribute.Emit): Remove.
15511 (Attribute.Resolve): Make virtual.
15512 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15513 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15514 the argument. Don't create one.
15515 (Attribute.GetObsoleteAttribute): Likewise.
15516 (Attribute.GetClsCompliantAttributeValue): Likewise.
15517 * class.cs, decl.cs: Update to changes.
15519 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15521 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15523 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15525 * statement.cs (Foreach.Resolve): Add error 186 report.
15527 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15529 * expression.cs (Conditional.DoResolve): Add warning 429.
15531 * statement.cs (If.Resolve): Add warning 665.
15533 2004-12-16 Raja R Harinath <rharinath@novell.com>
15535 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15536 except when in the parser, and in GlobalAttribute.
15537 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15538 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15539 RootContext.Tree.Types.NamespaceEntry once work is done.
15540 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15541 and resets RootContext.Tree.Types.NamespaceEntry.
15543 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15545 * cs-parser.jay: Don't create a block for every variable.
15547 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15549 * location.cs: Provide extra information.
15551 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15552 variables from the captured environment, it is the ldarg_0.
15554 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15556 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15559 * class.cs: Changed warning level for 169 to avoid developer
15560 displeasure from warning flooding. It will be changed back when they
15561 fix most of current BCL warnings.
15563 * RootContext.cs: Pushed default WarningLevel to 3.
15565 * statement.cs: Removed unused variable.
15567 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15569 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15570 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15571 Add error 502 report.
15572 (StaticClass.DefineType): Add error 441 report.
15573 (Class.AllowedModifiersProp): New virtual property as temporary
15574 extension to AllowedModifiers.
15575 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15576 to share implementation with StaticClass and don't call virtual
15579 * driver.cs (MainDriver): Add error 1558 test.
15581 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15582 report. Moved error 36 test here.
15584 * statement.cs (Throw.Resolve): Add error 724 report.
15586 * typemanager.cs: Add out_attribute_type core type.
15588 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15590 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15592 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15594 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15597 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15599 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15600 Add error 3023 report.
15601 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15603 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15606 2004-12-12 John Luke <john.luke@gmail.com>
15608 * driver.cs (AddArgs): take -- into account when
15609 adding arguments, fixes bug 65710
15611 2004-12-12 Martin Baulig <martin@ximian.com>
15613 * expression.cs (Unary.TryReduceNegative): Added support for
15614 SByteConstant and ByteConstant.
15615 (Unary.Reduce): Check error values from TryReduceNegative().
15617 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15619 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15620 and report exception as error 182.
15622 2004-12-10 Raja R Harinath <rharinath@novell.com>
15624 * driver.cs (Main): Fix message when there are warnings.
15626 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15628 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15630 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15632 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15633 Reduced number of warnings.
15635 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15637 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15639 * driver.cs: Removed message.
15641 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15643 2004-12-08 <vargaz@freemail.hu>
15645 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15647 2004-12-08 Martin Baulig <martin@ximian.com>
15649 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15650 instead of a CS3002 for properties and indexer.
15652 2004-12-08 Martin Baulig <martin@ximian.com>
15654 * decl.cs (MemberName.ToString): Make this work again.
15656 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15658 * attribute.cs (Resolve): Add error 591 detection.
15660 * class.cs (FieldMember.Define): Add error 1547 detection.
15661 (Indexer.Define): Add error 620 detection.
15662 (Operator.Define): Add error 590 detection.
15664 * ecore.cs: Missing argument for error 79.
15666 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15669 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15672 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15675 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15677 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15678 Some operator comments were suppressed.
15679 * doc.cs : Implicit/explicit operator name in doc comments are like
15680 "op_Explicit(type)~returnType", so added suffix handling.
15682 2004-12-07 Martin Baulig <martin@ximian.com>
15685 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15686 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15687 (DeclSpace.ec): New protected field; store the EmitContext here.
15688 (DeclSpace.EmitContext): New public property; moved here from
15690 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15693 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15694 (Enum.Emit): Don't create a new EmitContext.
15696 * delegate.cs (Delegate.DefineType): Always create the
15699 * iterators.cs (Iterators.DefineIterator): Create a new
15700 EmitContext and store it in `ec'.
15702 2004-08-24 Martin Baulig <martin@ximian.com>
15705 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15706 this for accessibility checks.
15707 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15708 IsNestedFamilyAccessible.
15709 (TypeManager.IsSubclassOf): New method, do what the name actually
15712 2004-12-06 Raja R Harinath <rharinath@novell.com>
15714 Fix crash on cs0657-17.cs.
15715 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15716 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15717 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15718 the case where the NamespaceEntry gets overwritten.
15720 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15722 Fixed #69195, #56821
15723 * ecore.cs (ResolveBoolean): Tiny refactoring.
15725 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15726 of right expression resolving when left is false constant and
15727 operator is LogicalAnd OR true constant and operator is LogicalOr.
15729 * statement.cs (ResolveUnreachable): Always reports warning.
15731 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15733 * class.cs: Distinguish between 1721 and 1722 (just a little help
15734 for the programmer).
15736 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15738 * delegate.cs: Only allow this on new versions of the language.
15740 2004-12-02 Duncan Mak <duncan@ximian.com>
15742 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15744 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15745 here as a static method. Take an additional bool out parameter
15746 `must_do_cs1540_check' for signaling to InstanceResolve.
15747 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15748 member field from PropertyExpr class and made it an argument of
15749 the method instead.
15750 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15751 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15752 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15753 and `remove_accessor' as well as InstanceResolve: report CS0122
15758 2004-12-03 Raja R Harinath <rharinath@novell.com>
15760 Fix test-327.cs, test-328.cs, and put in early infrastructure
15761 for eventually fixing #52697.
15762 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15763 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15764 from other methods.
15765 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15766 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15767 (VerifyUsing, error246): Update.
15768 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15769 'NamespaceEntry.LookupNamespaceOrType'.
15771 2004-12-03 Martin Baulig <martin@ximian.com>
15773 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15774 method as our child, call AnonymousMethod.Compatible() on it.
15776 2004-12-03 Raja R Harinath <rharinath@novell.com>
15778 Disable XML documentation support in 'basic' profile.
15779 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15780 Redirect XmlElement to System.Object.
15781 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15782 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15783 * mcs.exe.sources: Add doc-bootstrap.cs.
15784 * doc-bootstrap.cs: New file. Contains empty stub implementation
15787 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15789 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15790 comments are allowed.
15792 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15794 * delegate.cs: Add checks for subtypes in paramaters and return values
15795 in VerifyMethod () to add support for Covariance/Contravariance
15798 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15800 * report.cs: Remove extra closing parenthesis.
15802 * convert.cs (Error_CannotImplicitConversion): If the name of the
15803 types are the same, provide some extra information.
15805 * class.cs (FieldBase): Use an unused bit field from the field to
15806 encode the `has_offset' property from the FieldMember. This saves
15807 a couple of Ks on bootstrap compilation.
15809 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15810 method as our child, return the AnonymousMethod resolved
15813 * expression.cs (New.DoResolve): Allow return values from
15814 NewDelegate to also include AnonymousMethods.
15818 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15821 * attribute.cs (Resolve): Improved implementation of params
15822 attribute arguments.
15824 * support.cs (ParameterData): Add HasParams to be faster.
15826 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15828 all things are for /doc support:
15830 * doc.cs: new file that supports XML documentation generation.
15831 * mcs.exe.sources: added doc.cs.
15833 Handle /doc command line option.
15834 Report error 2006 instead of 5 for missing file name for /doc.
15835 Generate XML documentation when required, after type resolution.
15837 Added support for picking up documentation (/// and /** ... */),
15838 including a new XmlCommentState enumeration.
15840 Added lines to fill Documentation element for field, constant,
15841 property, indexer, method, constructor, destructor, operator, event
15842 and class, struct, interface, delegate, enum.
15843 Added lines to warn incorrect comment.
15845 Added Documentation field (passed only when /doc was specified).
15847 Added DocComment, DocCommentHeader, GenerateDocComment() and
15848 OnGenerateDocComment() and some supporting private members for
15849 /doc feature to MemberCore.
15851 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15853 Added overriden DocCommentHeader.
15855 Added overriden DocCommentHeader and GenerateDocComment().
15857 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15859 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15860 unwrapping the enumeration values, chain to
15861 DoConstantNumericPromotions again, so we can promote things to the
15862 fundamental types (takes care of enums that are bytes, sbytes).
15866 2004-12-01 Raja R Harinath <rharinath@novell.com>
15868 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15869 Fix long-standing bug in type-lookup. Use FindType instead of
15870 LookupType when ec.ResolvingTypeTree.
15871 (Attribute.ResolveType, Attribute.Resolve)
15872 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15874 (Attributes.Search): Remove internal version. Update.
15875 (Attributes.SearchMulti): Update.
15876 (Attributes.GetClsCompliantAttribute): Remove.
15877 (Attributes.GetIndexerNameAttribute): Remove.
15878 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15879 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15880 * class.cs (Indexer.Define): Likewise.
15882 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15885 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15886 MarshallByReference members access.
15888 * expression.cs: Use CheckMarshallByRefAccess;
15889 Better error CS0197 message.
15891 * report.cs: Print whole related error message.
15893 2004-11-30 Raja R Harinath <rharinath@novell.com>
15895 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15896 the current directory to help debugging.
15898 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15900 * class (GetClassBases): Better error 60 report.
15901 (EventProperty): Disabled warning 67 detection.
15903 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15906 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15908 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15911 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15914 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15916 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15918 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15920 * attribute.cs (Attribute.Resolve): Refine error reporting and
15921 report a cs0117 if the identifier does not exist, to distinguish
15922 from 0617 which is a miss-use of the actual identifier.
15924 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15925 between cs0070 and cs0079.
15927 * class.cs (MemberBase.DoDefine): When reporting a wrong
15928 accessibility level, we use MethodCore to compare instead of
15929 Method (this was a regression in some refactoring effort).
15931 So now we correctly report cs0056 again.
15933 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15934 testing the target_type (which was known to be object_type) and
15935 not the source type (which is anonymous_method).
15937 Fixed reporting of error cs1660.
15939 * expression.cs (UserCast.Source): Expose the underlying cast.
15941 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15942 allowed types to find a match to int32 first (most common).
15944 In addition, it ignores any ImplicitUserConversions that did an
15945 internal implicit conversion (as the switch statement allows only
15946 one integral conversion to exist).
15948 * class.cs (PartialContainer.Create): rename `name' to
15949 `member_name' for clarity. Then replace the string calls with a
15950 call to MemberName.GetPartialName, as now using
15951 MemberName.ToString is an error (this is due to the side effects
15952 it had, that were fixed in the past).
15954 This will restore the error reporting on a number of partial class
15955 errors that were missusing this (and getting an exception as a
15956 results, which is now just a plain textual warning, because
15957 yyparse debug output would crash otherwise).
15959 2004-11-26 Raja R Harinath <rharinath@novell.com>
15961 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15963 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15965 * rootcontext.cs (LookupType): Make sure to cache lookups that
15966 don't give us a negative result. This saves about 5% of corlib
15969 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15971 * report.cs (AbstractMessage.Print): messages are sent to stderr
15973 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15974 non-interface in the list of interfaces (at this point, either
15975 parent was properly set, or a base class is being listed in the
15976 interfaces section).
15978 This flags error 1722, and resolves the crash from bug 69259.
15980 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15982 * statement.cs (Using.EmitExpressionFinally): make this work right
15983 for valuetypes. Fixes 69926.
15985 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15987 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15988 converted to an enum" here, before we try to change the underlying
15989 type. This code exists, but it is a different code path than the
15990 one used while encoding constants.
15992 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15993 old bug: when converting from the null literal to a pointer,
15994 return an EmptyCast, not the NullLiteral.
15996 This fixes #69921, the recent null_type changes probably made this
15997 bug more prominent.
15999 (ImplicitReferenceConversionExists): In addition, resynchronized
16000 the code here, so it matches the same code in
16001 ImplicitReferenceConversionExists for the `from any class-type S
16002 to any interface-type T'.
16005 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16007 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16009 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16011 * cs-parser.jay: Use verbosity accordingly.
16013 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16015 * expression.cs (Unary.ResolveOperator): Do not report warning;
16016 AddressOf reads from variable.
16018 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16020 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16024 * attribute.cs (Attributable): Removed CheckTargets.
16025 (Attributes.Emit): Explicit attribute targets are tested here.
16027 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16028 not enabled for interfaces.
16030 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16031 (GetAssemblyName): Ouch next bug there.
16033 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16035 * expression.cs: Error 275 added.
16037 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16039 Fix bug #69177 (Implemented decimal constant support)
16041 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16042 (BinaryFold): Add DecimalConstant.
16044 * const.cs (Define): Decimal constant
16046 (ChangeType): Add decimal type handling.
16047 (LookupConstantValue): Don't set value for decimal type but
16048 emit DecimalConstantAttribute. Needed for constant optimization.
16050 * constant.cs (ToDecimal): New method.
16051 (ConvertToDecimal): New method.
16052 (IntConstant): Implemented ConvertToDecimal.
16053 (DecimalConstant.Emit): Emit optimized version for decimals in
16056 * expression.cs (ResolveOperator): Changed order of constant
16057 reduction to work correctly with native types which have
16058 overloaded operators.
16059 (ResolveMemberAccess): Extract constant value from attribute
16062 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16064 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16065 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16066 (ChangeType): Decimal is special.
16067 (TypeToCoreType): Add decimal type.
16069 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16071 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16074 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16076 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16079 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16081 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16083 * pending.cs (PendingImplementation): Grab only interfaces.
16085 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16087 * statement.cs (ForeachHelperMethods): Add location member and
16088 error 202 detection.
16090 2004-11-19 Raja R Harinath <rharinath@novell.com>
16092 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16093 automatically handled by executable.make.
16094 (PROGRAM): Make profile-specific.
16096 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16098 * expression.cs (DoResolveBase): Fixed wrong warning for out
16101 2004-11-18 Martin Baulig <martin@ximian.com>
16103 Merged latest changes into gmcs. Please keep this comment in
16104 here, it makes it easier for me to see what changed in MCS since
16105 the last time I merged.
16107 2004-11-17 Raja R Harinath <rharinath@novell.com>
16109 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16110 (TypeHandle.GetMemberCache): New.
16111 (TypeHandle.TypeHandle): Update.
16112 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16113 (TypeManager.LookupParentInterfacesCache):
16114 Rename from LookupInterfaceCache. Optimize slightly.
16115 (TypeManager.MemberLookup_FindMembers): Update.
16116 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16117 multi-type variant.
16118 (AddCacheContents): Rename from AddHashtable.
16119 * class.cs (TypeContainer.parent_container): Remove.
16120 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16121 (TypeContainer.DoDefineMembers): Don't initialize it.
16122 Update to name changes.
16124 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16126 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16127 that factors the code to check access modifiers on override.
16129 (PropertyBase): Use the code here.
16131 Patch from Lluis S'anchez, fixes bug #69361.
16133 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16135 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16136 routine that is used to report the use of a captured variable
16137 whose address has been taken.
16139 There are two checks: one when variables are being captured and
16140 the other check is when the address of a variable is taken.
16142 (because an anonymous methods might be resolved before *or* after
16143 the address has been taken) and
16145 * expression.cs (Conditional.DoResolve): Remove the special
16146 casing that Martin added to trueExpr and falseExpr being both
16147 NullLiteral. We get the right behavior now just by introducing
16148 the null_type into the compiler.
16150 * convert.cs (ExplicitConversion): Change the code to use
16151 null_type instead of testing `expr is NullLiteral'.
16152 (ImplicitConversionStandard): use null_type too.
16153 (ImplicitReferenceConversionExists): use null_type too.
16154 (ImplicitReferenceConversion): use null_type too.
16156 * literal.cs: The type of `NullLiteral' is now null_type instead
16158 (Resolve): Set the type here.
16160 * typemanager.cs: Introduce null_type.
16162 2004-11-17 Martin Baulig <martin@ximian.com>
16164 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16165 direction, like FindMembers() does. Fixes #69546, testcase is in
16168 2004-11-16 Martin Baulig <martin@ximian.com>
16170 This is based on a patch from Marek Safar, see bug #69082.
16171 Fixes bugs #63705 and #67130.
16173 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16174 method; create a MemberCache for an interface type and cache the
16177 * decl.cs (IMemberContainer.ParentContainer): Removed.
16178 (IMemberContainer.ParentCache): New property.
16179 (MemberCache.SetupCacheForInterface): Removed.
16180 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16181 to create a cache for an interface's "parent".
16183 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16186 2004-11-16 Martin Baulig <martin@ximian.com>
16188 Merged back from gmcs; these changes already went into gmcs a
16189 couple of weeks ago.
16192 (TypeManager.AddUserType): Removed the `ifaces' argument.
16193 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16195 (TypeManager.AddUserInterface): Removed.
16196 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16198 (TypeManager.GetInterfaces): Likewise.
16199 (TypeManager.GetExplicitInterfaces): Likewise.
16201 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16203 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16204 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16206 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16208 * statement.cs: Avoid adding bools to a hashtable.
16210 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16212 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16213 calling an unsafe method from a safe location.
16215 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16218 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16220 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16222 * namespace.cs (VerifyUsing): use GetPartialName instead of
16225 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16227 * statement.cs (Return.Resolve): Fix regression in typo: if
16228 `in_exc', we have to request a NeedReturnLabel, this was a typo
16229 introduced in the anonymous method check-in. Fixes #69131.
16231 * Indexers were using the ShortName when defining themselves,
16232 causing a regression in the compiler bootstrap when applying the
16233 patch from 2004-11-02 (first part), now they use their full name
16234 and the bug is gone.
16236 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16238 * driver.cs: Strip the path from the names of embedded resources. Fixes
16241 2004-11-04 Raja R Harinath <rharinath@novell.com>
16243 Fix error message regression: cs0104-2.cs.
16244 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16245 (AliasEntry.Resolve): Update.
16246 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16248 (RootContext.LookupType): Update.
16250 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16252 * cs-parser.jay: Add support for handling accessor modifiers
16253 * class: Add support port accessor modifiers and error checking,
16254 define PropertyMethod.Define as virtual (not abstract anymore)
16255 * ecore.cs: Add checking for proeprties access with access modifiers
16256 * iterators.cs: Modify Accessor constructor call based in the modified
16258 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16260 * expression.cs (StringConcat): Handle being called twice,
16261 as when we have a concat in a field init with more than two
16264 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16266 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16267 special case explicit implementations, we should always produce
16268 the .property or .event declaration.
16270 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16271 since it will not return correct data if people use this
16272 unresolved in the presence of using statements (see test-313).
16274 * class.cs (MethodData.Define): If we are an explicit interface
16275 implementation, set the method name to the full name of the
16276 interface plus the name of the method.
16278 Notice that using the method.MethodName.GetFullName() does not
16279 work, as it will only contain the name as declared on the source
16280 file (it can be a shorthand in the presence of using statements)
16281 and not the fully qualifed type name, for example:
16285 class D : ICloneable {
16286 object ICloneable.Clone () {
16290 Would produce a method called `ICloneable.Clone' instead of
16291 `System.ICloneable.Clone'.
16293 * namespace.cs (Alias.Resolve): Use GetPartialName.
16295 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16297 * cs-parser.jay: Add error 1055 report.
16299 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16301 * assign.cs (Assign.DoResolve): Only do the transform of
16302 assignment into a New if the types are compatible, if not, fall
16303 through and let the implicit code deal with the errors and with
16304 the necessary conversions.
16306 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16308 * cs-parser.jay: Add error 1031 report.
16310 * cs-tokenizer.cs: Add location for error 1038.
16312 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16314 * cs-parser.jay: Add error 1016 report.
16316 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16318 * cs-parser.jay: Add errors 1575,1611 report.
16320 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16322 * cs-parser.jay: Add error 1001 report.
16324 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16327 * attribute.cs (GetMarshal): Add method argument for
16328 caller identification.
16330 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16331 agument for GetMarshal and RuntimeMissingSupport.
16333 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16335 * attribute.cs (ExtractSecurityPermissionSet): Removed
16336 TypeManager.code_access_permission_type.
16338 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16340 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16342 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16343 for obsolete use of a variable here. Fixes regression on errors
16344 cs0619-25 and cs0619-26.
16346 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16348 Fix #62358, implemented security attribute encoding.
16350 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16351 Tests permitted SecurityAction for assembly or other types.
16352 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16353 data from SecurityPermissionAttribute to PermisionSet class.
16355 * class.cs (ApplyAttributeBuilder): Added special handling
16356 for System.Security.Permissions.SecurityAttribute based types.
16358 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16359 special handling for System.Security.Permissions.SecurityAttribute
16362 * enum.cs (ApplyAttributeBuilder): Added special handling
16363 for System.Security.Permissions.SecurityAttribute based types.
16365 * parameter.cs (ApplyAttributeBuilder): Added special handling
16366 for System.Security.Permissions.SecurityAttribute based types.
16368 * rootcontext.cs: Next 2 core types.
16370 * typemanager.cs (TypeManager.security_permission_attr_type):
16371 Built in type for the SecurityPermission Attribute.
16372 (code_access_permission_type): Build in type.
16374 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16376 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16377 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16378 all of this information into
16379 EmitContext.EmitCapturedVariableInstance.
16381 * codegen.cs (EmitCapturedVariableInstance): move here the
16382 funcionality of emitting an ldarg.0 in the presence of a
16383 remapping. This centralizes the instance emit code.
16385 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16386 then emit a load of this: it means that we have reached the
16387 topmost ScopeInfo: the one that contains the pointer to the
16388 instance of the class hosting the anonymous method.
16390 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16391 captures to the topmost CaptureContext.
16393 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16395 * expression.cs (LocalVariableReference): Move the knowledge about
16396 the iterators into codegen's EmitCapturedVariableInstance.
16398 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16400 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16401 all code paths return a value from an anonymous method (it is the
16402 same as the 161 error, but for anonymous methods).
16404 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16406 The introduction of anonymous methods in the compiler changed
16407 various ways of doing things in the compiler. The most
16408 significant one is the hard split between the resolution phase
16409 and the emission phases of the compiler.
16411 For instance, routines that referenced local variables no
16412 longer can safely create temporary variables during the
16413 resolution phase: they must do so from the emission phase,
16414 since the variable might have been "captured", hence access to
16415 it can not be done with the local-variable operations from the runtime.
16419 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16420 is a toplevel block.
16422 (ToplevelBlock): A new kind of Block, these are the blocks that
16423 are created by the parser for all toplevel method bodies. These
16424 include methods, accessors and anonymous methods.
16426 These contain some extra information not found in regular blocks:
16427 A pointer to an optional CaptureContext (for tracking captured
16428 local variables and parameters). A pointer to the parent
16431 (Return.Resolve): Catch missmatches when returning a value from an
16432 anonymous method (error 1662).
16433 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16436 (Break.Resolve): ditto.
16438 (SwitchLabel): instead of defining the labels during the
16439 resolution phase, we now turned the public ILLabel and ILLabelCode
16440 labels into methods called GetILLabelCode() and GetILLabel() that
16441 only define the label during the Emit phase.
16443 (GotoCase): Track the SwitchLabel instead of the computed label
16444 (its contained therein). Emit the code by using
16445 SwitchLabel.GetILLabelCode ().
16447 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16448 whether the Local has been captured or not.
16450 (LocalInfo.IsCaptured): New property, used to tell whether the
16451 local has been captured.
16453 * anonymous.cs: Vastly updated to contain the anonymous method
16456 The main classes here are: CaptureContext which tracks any
16457 captured information for a toplevel block and ScopeInfo used to
16458 track the activation frames for various local variables.
16460 Each toplevel block has an optional capture context associated
16461 with it. When a method contains an anonymous method both the
16462 toplevel method and the anonymous method will create a capture
16463 context. When variables or parameters are captured, they are
16464 recorded on the CaptureContext that owns them, for example:
16468 MyDelegate d = delegate {
16473 Here `a' will be recorded as captured on the toplevel
16474 CapturedContext, the inner captured context will not have anything
16475 (it will only have data if local variables or parameters from it
16476 are captured in a nested anonymous method.
16478 The ScopeInfo is used to track the activation frames for local
16479 variables, for example:
16481 for (int i = 0; i < 10; i++)
16482 for (int j = 0; j < 10; j++){
16483 MyDelegate d = delegate {
16488 At runtime this captures a single captured variable `i', but it
16489 captures 10 different versions of the variable `j'. The variable
16490 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16491 recorded on a child.
16493 The toplevel ScopeInfo will also track information like the `this'
16494 pointer if instance variables were referenced (this is necessary
16495 as the anonymous method lives inside a nested class in the host
16496 type of the method).
16498 (AnonymousMethod): Expanded to track the Toplevel, implement
16499 `AnonymousMethod.Compatible' to tell whether an anonymous method
16500 can be converted to a target delegate type.
16502 The routine now also produces the anonymous method content
16504 (AnonymousDelegate): A helper class that derives from
16505 DelegateCreation, this is used to generate the code necessary to
16506 produce the delegate for the anonymous method that was created.
16508 * assign.cs: API adjustments for new changes in
16509 Convert.ImplicitStandardConversionExists.
16511 * class.cs: Adjustments to cope with the fact that now toplevel
16512 blocks are of type `ToplevelBlock'.
16514 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16515 insteda of standard blocks.
16517 Flag errors if params arguments are passed to anonymous methods.
16519 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16520 `CurrentAnonymousMethod' which points to the current Anonymous
16521 Method. The variable points to the AnonymousMethod class that
16522 holds the code being compiled. It is set in the new EmitContext
16523 created for the anonymous method.
16525 (EmitContext.Phase): Introduce a variable and an enumeration to
16526 assist in enforcing some rules about when and where we are allowed
16527 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16528 only one that enfonces this right now).
16530 (EmitContext.HaveCaptureInfo): new helper method that returns
16531 whether we have a CapturedContext initialized.
16533 (EmitContext.CaptureVariable): New method used to register that a
16534 LocalInfo must be flagged for capturing.
16536 (EmitContext.CapturedParameter): New method used to register that a
16537 parameters must be flagged for capturing.
16539 (EmitContext.CapturedField): New method used to register that a
16540 field must be flagged for capturing.
16542 (EmitContext.HaveCapturedVariables,
16543 EmitContext.HaveCapturedFields): Return whether there are captured
16544 variables or fields.
16546 (EmitContext.EmitMethodHostInstance): This is used to emit the
16547 instance for the anonymous method. The instance might be null
16548 (static methods), this (for anonymous methods that capture nothing
16549 and happen to live side-by-side with the current method body) or a
16550 more complicated expression if the method has a CaptureContext.
16552 (EmitContext.EmitTopBlock): Routine that drives the emission of
16553 code: it will first resolve the top block, then emit any metadata
16554 and then emit the code. The split is done so that we can extract
16555 any anonymous methods and flag any captured variables/parameters.
16557 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16558 during this phase, the ILGenerator should not be used as labels
16559 and local variables declared here might not be accessible to any
16560 code that is part of an anonymous method.
16562 Exceptions to this include the temporary variables that are
16563 created by some statements internally for holding temporary
16566 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16569 (EmitContext.TemporaryReturn): This method is typically called
16570 from the Emit phase, and its the only place where we allow the
16571 ReturnLabel to be defined other than the EmitMeta. The reason is
16572 that otherwise we would have to duplicate a lot of logic in the
16573 Resolve phases of various methods that today is on the Emit
16576 (EmitContext.NeedReturnLabel): This no longer creates the label,
16577 as the ILGenerator is not valid during the resolve phase.
16579 (EmitContext.EmitThis): Extended the knowledge in this class to
16580 work in anonymous methods in addition to iterators.
16582 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16583 code is necessary on the stack to access the instance to a local
16584 variable (the variable will be accessed as a field).
16586 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16587 EmitContext.EmitAddressOfParameter): Routines to support
16588 parameters (not completed at this point).
16590 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16591 will also remove the parameters.
16593 * convert.cs (Convert): Define a `ConstantEC' which points to a
16594 null. This is just to prefity some code that uses
16595 ImplicitStandardConversion code and do not have an EmitContext
16598 The idea is to flag explicitly that at that point in time, it is
16599 known that the conversion will not trigger the delegate checking
16600 code in implicit conversions (which requires a valid
16603 Everywhere: pass new EmitContext parameter since
16604 ImplicitStandardConversionExists now requires it to check for
16605 anonymous method conversions.
16607 (Convert.ImplicitStandardConversionExists): If the type of an
16608 expression is the anonymous_method_type, and the type is a
16609 delegate, we invoke the AnonymousMethod.Compatible method to check
16610 whether an implicit conversion is possible.
16612 (Convert.ImplicitConversionStandard): Only do implicit method
16613 group conversions if the language level is not ISO_1.
16615 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16616 MethodInfo for the Invoke method. used by Delegate and
16619 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16620 method conversions if the target type is a delegate.
16622 Removed extra debugging nops.
16624 (LocalVariableReference): Turn the `local_info' into a public
16627 Add `prepared' field, the same hack used for FieldExprs to cope
16628 with composed assignments, as Local variables do not necessarily
16629 operate purely on the stack as they used to: they can be captured
16632 Add `temp' for a temporary result, like fields.
16634 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16636 It now copes with Local variables that are captured and emits the
16637 proper instance variable to load it from a field in the captured
16640 (ParameterReference.DoResolveBase): During the resolve phase,
16641 capture parameters if we are in an anonymous method.
16643 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16644 anonymous method, use the EmitContext helper routines to emit the
16645 parameter reference.
16647 * iterators.cs: Set RemapToProxy to true/false during the
16650 * parameters.cs (GetParameterByName): New helper method.
16652 * typemanager.cs (anonymous_method_type) a new type that
16653 represents an anonyous method. This is always an internal type,
16654 used as a fencepost to test against the anonymous-methodness of an
16657 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16659 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16661 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16663 2004-10-18 Martin Baulig <martin@ximian.com>
16665 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16666 `Type' directly, but call ResolveType() on it.
16667 (Catch.Resolve): Likewise.
16668 (Foreach.Resolve): Likewise.
16670 2004-10-18 Martin Baulig <martin@ximian.com>
16672 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16673 `Type' directly, but call ResolveType() on it.
16674 (Probe.DoResolve): Likewise.
16675 (ArrayCreation.LookupType): Likewise.
16676 (TypeOf.DoResolve): Likewise.
16677 (SizeOf.DoResolve): Likewise.
16679 2004-10-18 Martin Baulig <martin@ximian.com>
16681 * expression.cs (Invocation.BetterFunction): Put back
16682 TypeManager.TypeToCoreType().
16684 2004-10-18 Raja R Harinath <rharinath@novell.com>
16686 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16689 2004-10-18 Martin Baulig <martin@ximian.com>
16691 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16692 `Type' directly, but call ResolveType() on it.
16694 2004-10-18 Martin Baulig <martin@ximian.com>
16696 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16697 `Type' directly, but call ResolveType() on it.
16698 (MemberBase.DoDefine): Likewise.
16700 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16701 `Type' directly, but call ResolveType() on it.
16702 (ComposedCast.DoResolveAsTypeStep): Likewise.
16704 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16705 `Type' directly, but call ResolveType() on it.
16707 2004-10-17 John Luke <john.luke@gmail.com>
16709 * class.cs (Operator.GetSignatureForError): use CSharpName
16711 * parameter.cs (Parameter.GetSignatureForError): Returns
16712 correct name even if was not defined.
16714 2004-10-13 Raja R Harinath <rharinath@novell.com>
16717 * class.cs (TypeContainer.EmitContext): New property.
16718 (DefineNestedTypes): Create an emitcontext for each part.
16719 (MethodCore.DoDefineParameters): Use container's emitcontext.
16720 Pass type array to InternalParameters.
16721 (MemberBase.DoDefine): Use container's emitcontext.
16722 (FieldMember.Define): Likewise.
16723 (Event.Define): Likewise.
16724 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16725 Pass type array to InternalParameters.
16726 (SetIndexerMethod.GetParameterInfo): Likewise.
16727 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16728 * delegate.cs (Define): Pass emitcontext to
16729 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16730 array to InternalParameters.
16731 * expression.cs (ParameterReference.DoResolveBase): Pass
16732 emitcontext to GetParameterInfo.
16733 (ComposedCast.DoResolveAsTypeStep): Remove check on
16734 ec.ResolvingTypeTree.
16735 * parameter.cs (Parameter.Resolve): Change argument to
16736 EmitContext. Use ResolveAsTypeTerminal.
16737 (Parameter.GetSignature): Change argument to EmitContext.
16738 (Parameters.ComputeSignature): Likewise.
16739 (Parameters.ComputeParameterTypes): Likewise.
16740 (Parameters.GetParameterInfo): Likewise.
16741 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16742 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16743 * support.cs (InternalParameters..ctor): Remove variant that takes
16745 * typemanager.cs (system_intptr_expr): New.
16746 (InitExpressionTypes): Initialize it.
16748 2004-10-12 Chris Toshok <toshok@ximian.com>
16750 * cs-parser.jay: fix location for try_statement and catch_clause.
16752 2004-10-11 Martin Baulig <martin@ximian.com>
16754 * report.cs: Don't make --fatal abort on warnings, we have
16755 -warnaserror for that.
16757 2004-10-07 Raja R Harinath <rharinath@novell.com>
16759 More DeclSpace.ResolveType avoidance.
16760 * decl.cs (MemberCore.InUnsafe): New property.
16761 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16762 with newly created EmitContext.
16763 (FieldMember.Define): Likewise.
16764 * delegate.cs (Delegate.Define): Likewise.
16765 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16766 only if normal name-lookup fails.
16767 (TypeExpr.DoResolve): Enable error-checking.
16768 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16769 (SizeOf.DoResolve): Likewise.
16770 (ComposedCast.DoResolveAsTypeStep): Likewise.
16771 (StackAlloc.DoResolve): Likewise.
16772 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16773 (Block.Unsafe): New property.
16774 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16775 (Unsafe): Set 'unsafe' flag of contained block.
16776 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16777 (Fixed.Resolve): Likewise.
16778 (Catch.Resolve): Likewise.
16779 (Using.ResolveLocalVariableDecls): Likewise.
16780 (Foreach.Resolve): Likewise.
16782 2004-10-05 John Luke <john.luke@gmail.com>
16784 * cs-parser.jay: add location to error CS0175
16786 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16788 * ecore.cs (Expression.Constantity): Add support for turning null
16791 * const.cs (Const.Define): Allow constants to be reference types
16792 as long as the value is Null.
16794 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16796 * namespace.cs (NamespaceEntry.Using): No matter which warning
16797 level is set, check if this namespace name has already been added.
16799 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16801 * expression.cs: reftype [!=]= null should always use br[true,false].
16804 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16807 * attribute.cs: Enum conversion moved to
16808 GetAttributeArgumentExpression to be applied to the all
16811 2004-10-01 Raja R Harinath <rharinath@novell.com>
16813 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16814 * class.c (TypeContainer.DefineType): Flag error if
16815 base types aren't accessible due to access permissions.
16816 * decl.cs (DeclSpace.ResolveType): Move logic to
16817 Expression.ResolveAsTypeTerminal.
16818 (DeclSpace.ResolveTypeExpr): Thin layer over
16819 Expression.ResolveAsTypeTerminal.
16820 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16821 Refactor code into NestedAccess. Use it.
16822 (DeclSpace.NestedAccess): New.
16823 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16824 argument to silence errors. Check access permissions.
16825 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16826 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16827 (Cast.DoResolve): Likewise.
16828 (New.DoResolve): Likewise.
16829 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16830 (TypeOf.DoResolve): Likewise.
16832 * expression.cs (Invocation.BetterConversion): Return the Type of
16833 the better conversion. Implement section 14.4.2.3 more faithfully.
16834 (Invocation.BetterFunction): Make boolean. Make correspondence to
16835 section 14.4.2.2 explicit.
16836 (Invocation.OverloadResolve): Update.
16837 (Invocation): Remove is_base field.
16838 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16839 (Invocation.Emit): Likewise.
16841 2004-09-27 Raja R Harinath <rharinath@novell.com>
16843 * README: Update to changes.
16845 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16847 * cs-parser.jay: Reverted 642 warning fix.
16849 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16852 * decl.cs (FindMemberWithSameName): Indexer can have more than
16855 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16857 * expression.cs (LocalVariableReference.DoResolveLValue):
16858 Do not report warning 219 for out values.
16859 (EmptyExpression.Null): New member to avoid extra allocations.
16861 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16863 * cs-parser.jay: Fix wrong warning 642 report.
16865 * cs-tokenizer.cs (CheckNextToken): New helper;
16866 Inspect next character if is same as expected.
16868 2004-09-23 Martin Baulig <martin@ximian.com>
16870 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16871 (Convert.ImplicitReferenceConversionExists): Likewise.
16873 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16875 * class.cs (Operator.Define): Add error 448 and 559 report.
16877 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16879 * class.cs (MemberBase.IsTypePermitted): New protected
16880 method for checking error CS0610.
16882 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16884 * class.cs (TypeContainer.HasExplicitLayout): New property
16885 Returns whether container has StructLayout attribute set Explicit.
16886 (FieldMember): New abstract class for consts and fields.
16887 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16888 (Field): Reuse FieldMember.
16890 * const.cs (Const): Reuse FieldMember.
16892 * rootcontext.cs: EmitConstants call moved to class.
16894 2004-09-22 Martin Baulig <martin@ximian.com>
16896 Thanks to Peter Sestoft for this bug report.
16898 * expression.cs (Conditional): If both the `trueExpr' and the
16899 `falseExpr' is a NullLiteral, return a NullLiteral.
16901 2004-09-22 Martin Baulig <martin@ximian.com>
16903 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16904 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16905 for the "get_Current" call.
16907 2004-09-22 Martin Baulig <martin@ximian.com>
16909 Marek and me just fixed one of our oldest bugs: #28562 :-)
16911 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16913 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16914 we're an EnumConstant, just return that.
16915 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16916 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16917 to get the value which'll actually be written into the attribute.
16918 However, we have to use GetValue() to access the attribute's value
16921 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16923 * constant.cs (Constant.IsNegative): New abstract property
16926 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16927 (StackAlloc.DoResolve): Reused IsNegative.
16929 2004-09-21 Martin Baulig <martin@ximian.com>
16931 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16932 if we're used in an iterator, we may be called from different
16935 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16936 we actually have an exception block.
16938 2004-09-20 John Luke <jluke@cfl.rr.com>
16940 * class.cs, cs-parser.jay: Improve the error report for 1520:
16941 report the actual line where the error happens, not where the
16942 class was declared.
16944 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16945 Pass location information that was available elsewhere.
16947 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16949 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16950 runtime to delay sign assemblies.
16952 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16954 * cs-parser.jay: Do not report the stack trace, this is barely
16957 2004-08-22 John Luke <john.luke@gmail.com>
16959 * driver.cs : check that a resource id is not already used
16960 before adding it, report CS1508 if it is, bug #63637
16962 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16964 * ecore.cs: Removed dead code.
16966 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16968 * class.cs: Do not report warning CS0067 on the interfaces.
16970 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16972 * cs-parser.jay: Add error 504 report.
16974 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16976 * rootcontext.cs: WarningLevel is 4 by default now.
16978 * statement.cs (Fixed.Resolve): Do not null
16981 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16984 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16985 deep search when property is not virtual.
16986 (PropertyExpr.ResolveAccessors): Make one call for both
16989 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16992 * statement.cs: Error 152 report constains also location.
16994 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16997 * const.cs: Explicitly set constant as static.
16999 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17002 * cs-parser.jay: Add error 1017 report.
17004 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17006 Fixed bug #59980, #64224
17007 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17009 * typemanager.cs (IsSpecialMethod): Simplified
17011 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17013 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17014 condition with better params.
17016 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17019 * attribute.cs (Resolve): Property has to have both
17022 2004-09-14 Martin Baulig <martin@ximian.com>
17024 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17026 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17029 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17030 called and is obsolete then this member suppress message
17031 when call is inside next [Obsolete] method or type.
17033 * expression.cs: Use TestObsoleteMethodUsage member.
17035 2004-09-14 Martin Baulig <martin@ximian.com>
17037 * cs-parser.jay: Sync a bit with the GMCS version.
17039 2004-09-14 Martin Baulig <martin@ximian.com>
17041 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17042 (CSharpParser.yacc_verbose_flag): New public field.
17044 * genericparser.cs: Removed.
17046 2004-09-14 Raja R Harinath <rharinath@novell.com>
17048 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17050 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17052 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17054 2004-09-10 Martin Baulig <martin@ximian.com>
17056 Backported my MemberName changes from GMCS into MCS.
17058 - we are now using a special `MemberName' class instead of using
17059 strings; in GMCS, the `MemberName' also contains the type
17062 - changed the grammar rules a bit:
17063 * the old `member_name' is now a `namespace_or_type_name':
17064 The rule is that we use `namespace_or_type_name' everywhere
17065 where we expect either a "member name" (GetEnumerator) or a
17066 "member name" with an explicit interface name
17067 (IEnumerable.GetEnumerator).
17068 In GMCS, the explicit interface name may include type arguments
17069 (IEnumerable<T>.GetEnumerator).
17070 * we use `member_name' instead of just `IDENTIFIER' for
17072 The rule is that we use `member_name' wherever a member may
17073 have type parameters in GMCS.
17075 * decl.cs (MemberName): New public class.
17076 (MemberCore.MemberName): New public readonly field.
17077 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17078 (DeclSpace): Likewise.
17080 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17081 * enum.cs (Enum.ctor): Likewise.
17083 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17085 (AliasEntry.ctor): Take a MemberName, not an Expression.
17086 (AliasEntry.UsingAlias): Likewise.
17088 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17089 (IMethodData.MemberName): Changed type from string to MemberName.
17090 (MemberBase.ExplicitInterfaceName): Likewise.
17091 (AbstractPropertyEventMethod.SetupName): Make this private.
17092 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17093 argument; compute the member name here.
17094 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17095 on the `member.MemberName' and the `prefix'.
17097 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17099 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17100 thus, we get a `MemberName' instead of a `string'. These
17101 declarations may have type parameters in GMCS.
17102 (interface_method_declaration, delegate_declaration): Likewise.
17103 (class_declaration, interface_declaration): Likewise.
17104 (method_header): Use `namespace_or_type_name' instead of
17105 `member_name'. We may be an explicit interface implementation.
17106 (property_declaration, event_declaration): Likewise.
17107 (member_name): This is now just an `IDENTIFIER', not a
17108 `namespace_or_type_name'.
17109 (type_name, interface_type): Removed.
17110 (namespace_or_type_name): Return a MemberName, not an Expression.
17111 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17112 call GetTypeExpression() on the MemberName to get an expression.
17113 (IndexerDeclaration.interface_type): Changed type from string to
17115 (MakeName): Operate on MemberName's instead of string's.
17117 2004-09-13 Raja R Harinath <rharinath@novell.com>
17120 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17121 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17122 lookup to avoid symbols introduced by 'using'.
17123 * rootcontext.cs (NamespaceLookup): Update.
17125 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17127 * class.cs (TypeContainer.DoDefineMembers): Do not call
17128 DefineDefaultConstructor for static classes.
17130 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17132 * attribute.cs (Attribute.Resolve): Add error 653 report.
17134 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17136 (Method.ApplyAttributeBuilder): Add error 685 report.
17137 (Operator.Define): Add error 564 report.
17139 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17141 * expression.cs (Invocation.DoResolve): Add error
17142 245 and 250 report.
17144 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17147 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17149 * class.cs (ConstructorInitializer.Resolve):
17150 Wrong error number (515->516).
17152 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17154 * class.cs (Indexer.Define): Add error 631 report.
17156 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17158 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17160 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17162 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17164 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17166 * cs-parser.jay: Added error CS0241 report.
17168 2004-09-10 Raja R Harinath <rharinath@novell.com>
17170 * cs-parser.jay (fixed_statement): Introduce a scope for the
17171 declaration in the 'fixed' statement.
17173 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17175 * cs-parser.jay: Added CS0230 error report.
17177 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17179 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17181 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17183 * expression.cs (Argument.Resolve): Added error CS0192 and
17186 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17188 C# 2.0 #pragma warning feature
17190 * cs-tokenizer.cs (PreProcessPragma): New method;
17191 Handles #pragma directive.
17193 * report.cs (WarningRegions): New class; Support
17194 class for #pragma warning directive. It tests whether
17195 warning is enabled for a given line.
17197 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17199 * const.cs: Add more descriptive error report, tahnks to
17202 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17204 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17206 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17208 * expression.cs: Apply patch from Ben: Remove dead code from
17209 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17210 as that code just threw an exception anwyays.
17212 * const.cs: Remove the call to the turnintoconstant, for details
17215 * literal.cs: The type of the null-literal is the null type; So
17216 we use a placeholder type (literal.cs:System.Null, defined here)
17219 * expression.cs (Conditional.DoResolve): Remove some old code that
17220 is no longer needed, conversions have been fixed.
17222 (ArrayCreationExpression.DoResolve): Return false if we fail to
17223 resolve the inner expression.
17225 2004-09-07 Raja R Harinath <rharinath@novell.com>
17228 * cs-parser.jay (delegate_declaration): Record a delegate
17229 declaration as a type declaration.
17230 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17232 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17234 * parameter.cs: Do not crash if the type can not be resolved.
17236 * expression.cs: Report errors with unsafe pointers, fixes #64896
17238 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17240 * expression.cs: Pointer arith always needs to do a conv.i
17241 if the operand is a long. fix 65320
17243 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17245 Fixed cs0619-37.cs, cs0619-38.cs
17247 * enum.cs (GetObsoleteAttribute): Removed.
17249 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17250 on Enum member is double staged. The first is tested member
17253 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17255 Fixed #56986, #63631, #65231
17257 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17258 adds member to name container.
17259 (TypeContainer.AddToTypeContainer): New method, adds type to
17261 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17262 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17263 AddOperator): Simplified by reusing AddToMemberContainer.
17264 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17266 (Method.CheckForDuplications): Fixed implementation to test all
17268 (MemberBase): Detection whether member is explicit interface
17269 implementation is now in constructor.
17270 (MemberBase.UpdateMemberName): Handles IndexerName.
17271 (Accessor): Changed to keep also location information.
17272 (AbstractPropertyEventMethod): Is derived from MemberCore.
17273 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17274 will be emited or not.
17275 (PropertyBase.AreAccessorsDuplicateImplementation):
17276 Tests whether accessors are not in collision with some method.
17277 (Operator): Is derived from MethodCore to simplify common
17280 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17282 (DeclSpace.AddToContainer): Adds the member to defined_names
17283 table. It tests for duplications and enclosing name conflicts.
17285 * enum.cs (EnumMember): Clean up to reuse the base structures
17287 2004-09-03 Martin Baulig <martin@ximian.com>
17289 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17290 into TypeContainer, to make partial classes work again.
17292 2004-09-03 Martin Baulig <martin@ximian.com>
17294 * rootcontext.cs (RootContext.V2): Removed.
17296 2004-03-23 Martin Baulig <martin@ximian.com>
17298 * expression.cs (Invocation.OverloadResolve): Added `bool
17299 may_fail' argument and use it instead of the Location.IsNull() hack.
17301 2004-09-03 Martin Baulig <martin@ximian.com>
17303 Merged latest changes into gmcs. Please keep this comment in
17304 here, it makes it easier for me to see what changed in MCS since
17305 the last time I merged.
17307 2004-09-03 Raja R Harinath <rharinath@novell.com>
17310 * expression.cs (BetterConversion): Don't allow either conversion
17311 to be null. Remove redundant implicit conversion test when 'q ==
17312 null' -- when this function is invoked, we already know that the
17313 implicit conversion exists.
17314 (BetterFunction): Assume that 'best' is non-null. Remove
17315 redundant reimplementation of IsApplicable when 'best' is null.
17316 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17317 number of arguments.
17318 (IsAncestralType): Extract from OverloadResolve.
17319 (OverloadResolve): Make robust to the MethodGroupExpr being
17320 unsorted. Implement all the logic of Section 14.5.5.1, and
17321 support overloading of methods from multiple applicable types.
17322 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17324 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17325 (RealError, Warning): Append type of report to related symbol.
17327 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17329 * enum.cs: Fixed CLS-Compliance checks for enum members.
17330 Error tests cs3008-8.cs, cs3014-8.cs
17332 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17334 Fixed bug #62342, #63102
17335 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17336 like ImplementMethod.
17338 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17340 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17343 2004-09-02 Martin Baulig <martin@ximian.com>
17345 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17346 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17349 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17351 C# 2.0 Static classes implemented
17353 * class.cs (TypeContainer): instance_constructors,
17354 initialized_fields, initialized_static_fields,
17355 default_constructor, base_inteface_types are protected to be
17356 accessible from StaticClass.
17357 (TypeContainer.DefineDefaultConstructor): New virtual method
17358 for custom default constructor generating
17359 (StaticClass): New class to handle "Static classes" feature.
17361 * cs-parser.jay: Handle static keyword on class like instance
17364 * driver.cs: Added "/langversion" command line switch with two
17365 options (iso-1, default).
17367 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17369 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17371 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17373 * delegate.cs: Style.
17375 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17377 * delegate.cs: Add seperate instance expr field for miguel.
17379 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17381 * PointerArithmetic (Resolve): make sure we are not doing
17382 pointer arith on void*. Also, make sure we are resolved
17383 by not setting eclass until resolve.
17385 All callers: Make sure that PointerArithmetic gets resolved.
17387 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17389 * ArrayCreation (LookupType): If the type does not resolve
17390 to an array, give an error.
17392 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17394 * statement.cs (Try.Resolve): Fixed bug #64222
17396 2004-08-27 Martin Baulig <martin@ximian.com>
17399 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17402 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17404 * ecore.cs (Constantify): Get underlying type via
17405 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17406 Windows in special cases.
17408 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17410 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17411 for obtaining also private methods.
17412 (GetRemoveMethod): Used GetRemoveMethod (true)
17413 for obtaining also private methods.
17415 2004-08-24 Martin Baulig <martin@ximian.com>
17417 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17418 MethodAttributes.HideBySig for operators.
17420 2004-08-23 Martin Baulig <martin@ximian.com>
17422 Back to the old error reporting system :-)
17424 * report.cs (Message): Removed.
17425 (Report.MessageData, ErrorData, WarningData): Removed.
17426 (Report.Error, Warning): Back to the old system.
17428 2004-08-23 Martin Baulig <martin@ximian.com>
17430 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17432 * class.cs (TypeContainer.ParentContainer): New public virtual
17433 method; replaces the explicit interface implementation.
17434 (ClassPart.ParentContainer): Override.
17436 2004-08-23 Martin Baulig <martin@ximian.com>
17438 * statement.cs (Switch): Added support for constant switches; see
17439 #59428 or test-285.cs.
17441 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17444 * statement.cs (GetEnumeratorFilter): Removed useless
17445 logic because C# specs is strict. GetEnumerator must be
17448 2004-08-22 Martin Baulig <martin@ximian.com>
17450 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17451 a switch and may break, reset the barrier. Fixes #59867.
17453 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17455 CLS-Compliance speed up (~5% for corlib)
17457 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17458 New method. Tests container for CLS-Compliant names
17460 * class.cs (TypeContainer.VerifyClsName): New method.
17461 Checks whether container name is CLS Compliant.
17462 (Constructor): Implements IMethodData.
17464 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17465 low-case table for CLS Compliance test.
17466 (MemberCache.VerifyClsParameterConflict): New method.
17467 Checks method parameters for CS3006 error.
17469 * enum.cs (EnumMember): Is derived from MemberCore.
17470 (Enum.VerifyClsName): Optimized for better performance.
17472 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17474 * report.cs: Renamed Error_T to Error and changed all
17477 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17479 * class.cs (TypeContainer.IndexerArrayList): New inner class
17480 container for indexers.
17481 (TypeContainer.DefaultIndexerName): New constant for default
17482 indexer name. Replaced all "Item" with this constant.
17483 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17485 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17486 DefaultMemberAttribute constructor.
17488 2004-08-05 Martin Baulig <martin@ximian.com>
17490 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17493 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17495 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17496 multi platforms problem.
17498 * compiler.csproj: Included shared files.
17500 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17502 Fix bug 60333, 55971 in the more general way
17503 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17504 Added arg_type argument for constant conversion.
17505 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17507 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17510 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17511 OperatorArrayList, MethodCoreArrayList for typecontainer
17512 containers. Changed class member types to these new types.
17513 (MethodArrayList.DefineMembers): Added test for CS0659.
17515 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17517 * cfold.cs: Synchronize the folding with the code in expression.cs
17518 Binary.DoNumericPromotions for uint operands.
17520 * attribute.cs: Revert patch from Raja, it introduced a regression
17521 while building Blam-1.2.1 (hard to isolate a test case).
17523 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17527 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17529 (MethodCore.parent_method): New member. The method we're overriding
17530 if this is an override method.
17531 (MethodCore.CheckBase): Moved from Method class and made common.
17532 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17534 (MethodCore.CheckForDuplications): New abstract method. For custom
17535 member duplication search in a container
17536 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17537 method and its return type.
17538 (Event.conflict_symbol): New member. Symbol with same name in the
17542 (MemberCache.FindMemberWithSameName): New method. The method
17543 is looking for conflict with inherited symbols.
17545 2004-08-04 Martin Baulig <martin@ximian.com>
17547 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17549 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17551 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17553 * report.cs (Message): New enum for better error, warning reference in
17555 (MessageData): New inner abstract class. It generally handles printing of
17556 error and warning messages.
17557 Removed unused Error, Warning, Message methods.
17559 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17561 Fix for cs0592-8.cs test
17563 (Attributable.ValidAttributeTargets): Made public.
17564 (Attribute.ExplicitTarget): New member for explicit target value.
17565 (Attribute.CheckTargets): Now we translate explicit attribute
17566 target to Target here.
17568 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17570 * ecore.cs (MethodGroupExpr): new IsBase property.
17572 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17574 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17575 rather than an instance expr.
17577 (DelegateCreation.Emit): Use the method group rather than
17578 the instance expression. Also, if you have base.Foo as the
17579 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17581 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17583 (NewDelegate.DoResolve): Only check for the existance of Invoke
17584 if the method is going to be needed. Use MethodGroupExpr.
17586 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17588 * expression.cs: For pointer arith., make sure to use
17589 the size of the type, not the size of the pointer to
17592 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17595 * class.cs (Class): Added error CS0502 test.
17597 2004-08-03 John Luke <jluke@cfl.rr.com>
17598 Raja R Harinath <rharinath@novell.com>
17601 * attribute.cs (Attribute.complained_before): New flag.
17602 (Attribute.ResolveType, Attribute.Resolve),
17603 (Attribute.DefinePInvokeMethod): Set it.
17604 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17606 2004-08-03 Martin Baulig <martin@ximian.com>
17608 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17609 use a user-defined operator; we still need to do numeric
17610 promotions in case one argument is a builtin type and the other
17611 one has an implicit conversion to that type. Fixes #62322.
17613 2004-08-02 Martin Baulig <martin@ximian.com>
17615 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17616 (LocalInfo.IsThis): New public property.
17617 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17619 2004-08-01 Martin Baulig <martin@ximian.com>
17621 * class.cs (TypeContainer.GetClassBases): Don't set the default
17622 here since we may get called from GetPartialBases().
17623 (TypeContainer.DefineType): If GetClassBases() didn't return a
17624 parent, use the default one.
17626 2004-07-30 Duncan Mak <duncan@ximian.com>
17628 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17630 2004-07-30 Martin Baulig <martin@ximian.com>
17632 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17634 * class.cs (SourceMethod): New public class, derive from the
17635 symbol writer's ISourceMethod.
17636 (Method): Use the new symbol writer API.
17638 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17639 as argument and use the new symbol writer.
17642 (SourceFile): Implement the symbol writer's ISourceFile.
17643 (Location.SymbolDocument): Removed.
17644 (Location.SourceFile): New public property.
17646 * symbolwriter.cs: Use the new symbol writer API.
17648 2004-07-30 Raja R Harinath <rharinath@novell.com>
17650 * Makefile (install-local): Remove. Functionality moved to
17653 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17655 * Makefile: Install mcs.exe.config file together with mcs.exe.
17656 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17657 correct runtime version.
17659 2004-07-25 Martin Baulig <martin@ximian.com>
17662 (TypeContainer.RegisterOrder): Removed, this was unused.
17663 (TypeContainer, interface_order): Removed.
17664 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17665 TypeContainer as argument since we can also be called with a
17666 `PartialContainer' for a partial class/struct/interface.
17667 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17668 of checking whether we're an `Interface' - we could be a
17669 `PartialContainer'.
17670 (PartialContainer.Register): Override; call
17671 AddClass()/AddStruct()/AddInterface() on our parent.
17673 * cs-parser.jay (interface_member_declaration): Add things to the
17674 `current_container', not the `current_class'.
17676 * rootcontext.cs (RegisterOrder): The overloaded version which
17677 takes an `Interface' was unused, removed.
17679 * typemanager.cs (TypeManager.LookupInterface): Return a
17680 `TypeContainer', not an `Interface'.
17681 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17682 contain a `PartialContainer' for an interface, so check it's
17683 `Kind' to figure out what it is.
17685 2004-07-25 Martin Baulig <martin@ximian.com>
17687 * class.cs (Class.DefaultTypeAttributes): New public constant.
17688 (Struct.DefaultTypeAttributes): Likewise.
17689 (Interface.DefaultTypeAttributes): Likewise.
17690 (PartialContainer.TypeAttr): Override this and add the
17691 DefaultTypeAttributes.
17693 2004-07-25 Martin Baulig <martin@ximian.com>
17695 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17696 we can just use the `Parent' field instead.
17698 2004-07-25 Martin Baulig <martin@ximian.com>
17700 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17702 2004-07-25 Martin Baulig <martin@ximian.com>
17704 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17705 our parts before defining any methods.
17706 (TypeContainer.VerifyImplements): Make this virtual.
17707 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17708 on our PartialContainer.
17710 2004-07-25 Martin Baulig <martin@ximian.com>
17712 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17714 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17715 argument, we can just use the `Parent' field instead.
17718 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17719 (MemberBase.DoDefine): Likewise.
17721 2004-07-24 Martin Baulig <martin@ximian.com>
17723 * decl.cs (MemberCore.Parent): New public field.
17724 (DeclSpace.Parent): Moved to MemberCore.
17726 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17727 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17729 (FieldBase, Field, Operator): Likewise.
17730 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17731 (EventField, Event): Likewise.
17733 2004-07-23 Martin Baulig <martin@ximian.com>
17735 * class.cs (PartialContainer): New public class.
17736 (ClassPart): New public class.
17737 (TypeContainer): Added support for partial classes.
17738 (TypeContainer.GetClassBases): Splitted some of the functionality
17739 out into GetNormalBases() and GetPartialBases().
17741 * cs-tokenizer.cs (Token.PARTIAL): New token.
17742 (Tokenizer.consume_identifier): Added some hacks to recognize
17743 `partial', but only if it's immediately followed by `class',
17744 `struct' or `interface'.
17746 * cs-parser.jay: Added support for partial clases.
17748 2004-07-23 Martin Baulig <martin@ximian.com>
17750 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17751 a `DeclSpace' and also made it readonly.
17752 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17753 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17754 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17756 * cs-parser.jay: Pass the `current_class', not the
17757 `current_container' (at the moment, this is still the same thing)
17758 to a new Method, Property, Event, Indexer or Constructor.
17760 2004-07-23 Martin Baulig <martin@ximian.com>
17762 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17763 and removed the `current_interface' one.
17764 (struct_declaration, class_declaration, interface_declaration):
17765 Set `current_class' to the newly created class/struct/interface;
17766 set their `Bases' and call Register() before parsing their body.
17768 2004-07-23 Martin Baulig <martin@ximian.com>
17770 * class.cs (Kind): New public enum.
17771 (TypeContainer): Made this class abstract.
17772 (TypeContainer.Kind): New public readonly field.
17773 (TypeContainer.CheckDef): New public method; moved here from
17775 (TypeContainer.Register): New public abstract method.
17776 (TypeContainer.GetPendingImplementations): New public abstract
17778 (TypeContainer.GetClassBases): Removed the `is_class' and
17779 `is_iface' parameters.
17780 (TypeContainer.DefineNestedTypes): Formerly known as
17782 (ClassOrStruct): Made this class abstract.
17784 * tree.cs (RootTypes): New public type.
17786 2004-07-20 Martin Baulig <martin@ximian.com>
17788 * tree.cs (Tree.RecordNamespace): Removed.
17789 (Tree.Namespaces): Removed.
17791 * rootcontext.cs (RootContext.IsNamespace): Removed.
17793 * cs-parser.jay (namespace_declaration): Just create a new
17794 NamespaceEntry here.
17796 2004-07-20 Martin Baulig <martin@ximian.com>
17798 * statement.cs (ExceptionStatement): New abstract class. This is
17799 now used as a base class for everyone who's using `finally'.
17800 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17801 our local variables before using them.
17803 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17804 virtual method. This is used by Yield.Resolve() to "steal" an
17805 outer block's `finally' clauses.
17806 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17809 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17810 version which takes an ExceptionStatement. This version must be
17811 used to create exception branchings.
17814 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17815 (Iterator.EmitMoveNext): Added exception support; protect the
17816 block with a `fault' clause, properly handle 'finally' clauses.
17817 (Iterator.EmitDispose): Run all the `finally' clauses here.
17819 2004-07-20 Martin Baulig <martin@ximian.com>
17821 * iterator.cs: This is the first of a set of changes in the
17822 iterator code. Match the spec more closely: if we're an
17823 IEnumerable, then GetEnumerator() must be called. The first time
17824 GetEnumerator() is called, it returns the current instance; all
17825 subsequent invocations (if any) must create a copy.
17827 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17829 * expression.cs: Resolve the constant expression before returning
17832 2004-07-19 Martin Baulig <martin@ximian.com>
17834 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17835 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17836 the return type of the new EmitContext.
17838 2004-07-18 Martin Baulig <martin@ximian.com>
17840 * class.cs (Property.Define): Fix iterators.
17842 * iterators.cs (Iterator.Define): Moved the
17843 `container.AddInterator (this)' call here from the .ctor; only do
17844 it if we resolved successfully.
17846 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17848 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17849 `true' for preprocessing directives that we parse. The return
17850 value indicates whether we should return to regular tokenizing or
17851 not, not whether it was parsed successfully.
17853 In the past if we were in: #if false ... #line #endif, we would
17854 resume parsing after `#line'. See bug 61604.
17856 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17857 building: IsEnumType should return true only for enums, not for
17858 enums or System.Enum itself. This fixes #61593.
17860 Likely what happened is that corlib was wrong: mcs depended on
17861 this bug in some places. The bug got fixed, we had to add the
17862 hack, which caused bug 61593.
17864 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17865 that was a workaround for the older conditions.
17867 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17869 * assign.cs: IAssignMethod has a new interface, as documented
17870 inline. All assignment code now uses this new api.
17872 * ecore.cs, expression.cs: All classes which implement
17873 IAssignMethod now use the new interface.
17875 * expression.cs (Invocation): add a hack to EmitCall so that
17876 IndexerAccess can be the target of a compound assignment without
17877 evaluating its arguments twice.
17879 * statement.cs: Handle changes in Invocation api.
17881 2004-07-16 Martin Baulig <martin@ximian.com>
17883 * iterators.cs: Rewrote this. We're now using one single Proxy
17884 class for both the IEnumerable and the IEnumerator interface and
17885 `Iterator' derives from Class so we can use the high-level API.
17887 * class.cs (TypeContainer.AddIterator): New method.
17888 (TypeContainer.DoDefineType): New protected virtual method, which
17889 is called from DefineType().
17890 (TypeContainer.DoDefineMembers): Call DefineType() and
17891 DefineMembers() on all our iterators.
17892 (TypeContainer.Emit): Call Emit() on all our iterators.
17893 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17895 * codegen.cs (EmitContext.CurrentIterator): New public field.
17897 2004-07-15 Martin Baulig <martin@ximian.com>
17900 (TypeManager.not_supported_exception_type): New type.
17902 2004-07-14 Martin Baulig <martin@ximian.com>
17904 * iterators.cs: Use real error numbers.
17906 2004-07-14 Martin Baulig <martin@ximian.com>
17908 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17909 requires this to be a System.Collection.IEnumerable and not a
17910 class implementing that interface.
17911 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17913 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17915 * class.cs: Fixed previous fix, it broke some error tests.
17917 2004-07-12 Martin Baulig <martin@ximian.com>
17919 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17922 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17924 * assign.cs (LocalTemporary): Add new argument: is_address,If
17925 `is_address' is true, then the value that we store is the address
17926 to the real value, and not the value itself.
17928 * ecore.cs (PropertyExpr): use the new local temporary
17929 stuff to allow us to handle X.Y += z (where X is a struct)
17931 2004-07-08 Martin Baulig <martin@ximian.com>
17933 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17934 not always return, just like we're doing in Using.Resolve().
17936 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17938 * cs-parser.jay (fixed_statement): flag this as Pinned.
17940 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17942 * typemanager.cs (TypeManager): Removed MakePinned method, this
17943 mechanism is replaced with the .NET 2.x compatible mechanism of
17944 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17946 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17947 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17948 `IsFixed' property which has a different meaning.
17950 2004-07-02 Raja R Harinath <rharinath@novell.com>
17952 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17953 visible from inside a nested class, not just the names of the
17954 immediately enclosing class.
17955 Fix for bug #60730.
17957 2004-06-24 Raja R Harinath <rharinath@novell.com>
17959 * expression.cs (BetterConversion): Remove buggy special-case
17960 handling of "implicit constant expression conversions". At this
17961 point, we already know that the conversion is possible -- we're
17962 only checking to see which is better.
17964 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17966 * cs-parser.jay: Added error CS0210 test.
17968 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17970 * cs-parser.jay: Added error CS0134 test.
17972 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17975 * cs-parser.jay: Added error CS0145 test.
17977 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17979 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17981 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17983 * expression.cs (StackAlloc.Resolve): The argument may not
17984 be a constant; deal with this case.
17986 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17988 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17989 GetIndexerAttributeValue.
17990 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17992 * class.cs (Indexer.Define): Added error tests for CS0415,
17995 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17997 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18000 2004-06-23 Martin Baulig <martin@ximian.com>
18002 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18003 neither return nor throw, reset the barrier as well. Fixes #60457.
18005 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18007 * class.cs : EventAttributes is now set to None by default.
18008 This fixes bug #60459.
18010 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18013 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18014 Don't throw exception but return null (it's sufficient now).
18016 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18018 * typemanager.cs (GetArgumentTypes): Faster implementation.
18020 2004-06-18 Martin Baulig <martin@ximian.com>
18022 * attribute.cs (Attribute.Resolve): Check whether we're an
18023 EmptyCast which a Constant child. Fixes #60333.
18025 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18027 * statement.cs (EmitCollectionForeach): Account for the fact that
18028 not all valuetypes are in areas which we can take the address of.
18029 For these variables, we store to a temporary variable. Also, make
18030 sure that we dont emit a `callvirt' on a valuetype method.
18032 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18034 * expression.cs (StackAlloc.DoReSolve): Added test for
18035 negative parameter (CS0247).
18037 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18040 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18042 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18045 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18048 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18050 Fix bug #58254 & cs1555.cs, cs1556.cs
18051 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18053 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18055 * cs-parser.jay: Added error CS1669 test for indexers.
18057 2004-06-11 Martin Baulig <martin@ximian.com>
18059 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18060 call this twice: for params and varargs methods.
18062 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18065 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18067 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18069 * attribute.cs (Attribute.GetValidTargets): Made public.
18072 (AbstractPropertyEventMethod): New class for better code sharing.
18073 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18075 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18077 2004-06-11 Raja R Harinath <rharinath@novell.com>
18080 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18081 that the call to Resolve is part of a MemberAccess.
18082 (Expression.Resolve): Use it for SimpleName resolution.
18083 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18084 Add 'intermediate' boolean argument.
18085 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18086 error message when the SimpleName can be resolved ambiguously
18087 between an expression and a type.
18088 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18090 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18091 call on the left-side.
18093 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18096 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18098 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18100 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18102 2004-06-11 Martin Baulig <martin@ximian.com>
18104 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18105 varargs methods if applicable.
18107 2004-06-11 Martin Baulig <martin@ximian.com>
18109 * expression.cs (Invocation.EmitCall): Don't use
18110 `method.CallingConvention == CallingConventions.VarArgs' since the
18111 method could also have `CallingConventions.HasThis'.
18113 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18115 * class.cs (Event.GetSignatureForError): Implemented.
18116 Fixed crash in error test cs3010.cs
18118 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18120 * cs-tokenizer.cs: Change the way we track __arglist to be
18121 consistent with the other keywords.
18123 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18125 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18128 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18130 * codegen.cs: Check that all referenced assemblies have a strongname
18131 before strongnaming the compiled assembly. If not report error CS1577.
18132 Fix bug #56563. Patch by Jackson Harper.
18133 * typemanager.cs: Added a method to return all referenced assemblies.
18134 Fix bug #56563. Patch by Jackson Harper.
18136 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18139 (Method.ApplyAttributeBuilder): Moved and added conditional
18140 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18143 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18145 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18148 * class.cs: (EventField.attribute_targets): Changed default target.
18150 2004-06-08 Martin Baulig <martin@ximian.com>
18152 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18154 2004-06-08 Martin Baulig <martin@ximian.com>
18156 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18158 2004-06-07 Martin Baulig <martin@ximian.com>
18160 Added support for varargs methods.
18162 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18165 * cs-parser.jay: Added support for `__arglist'.
18167 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18169 * expression.cs (Argument.AType): Added `ArgList'.
18170 (Invocation): Added support for varargs methods.
18171 (ArglistAccess): New public class.
18172 (Arglist): New public class.
18174 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18176 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18177 a method's top-level block if the method has varargs.
18179 * support.cs (ReflectionParameters, InternalParameters): Added
18180 support for varargs methods.
18182 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18184 * class.cs: Provide location in indexer error report.
18186 * driver.cs: Use standard names.
18188 * namespace.cs: Catch the use of using after a namespace has been
18189 declared also on using aliases.
18191 2004-06-03 Raja R Harinath <rharinath@novell.com>
18194 * typemanager.cs (closure_private_ok, closure_invocation_type)
18195 (closure_qualifier_type, closure_invocation_assembly)
18196 (FilterWithClosure): Move to ...
18197 (Closure): New internal nested class.
18198 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18199 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18200 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18201 (MemberLookup, MemberLookupFailed): Use it.
18202 * expression.cs (New.DoResolve): Treat the lookup for the
18203 constructor as being qualified by the 'new'ed type.
18204 (Indexers.GetIndexersForTypeOrInterface): Update.
18206 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18209 (GetConditionalAttributeValue): New method. Returns
18210 condition of ConditionalAttribute.
18211 (SearchMulti): New method. Returns all attributes of type 't'.
18212 Use it when attribute is AllowMultiple = true.
18213 (IsConditionalMethodExcluded): New method.
18216 (Method.IsExcluded): Implemented. Returns true if method has conditional
18217 attribute and the conditions is not defined (method is excluded).
18218 (IMethodData): Extended interface for ConditionalAttribute support.
18219 (PropertyMethod.IsExcluded): Implemented.
18222 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18225 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18228 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18230 * expression.cs (ArrayCreationExpression): Make this just an
18231 `expression'. It can't be a statement, so the code here was
18234 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18237 * typemanager.cs (GetFullNameSignature): New method for
18240 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18243 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18244 Use this method when MethodBuilder is null.
18245 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18246 Added test for error CS0626 (MONO reports error for this situation).
18247 (IMethodData.GetSignatureForError): Extended interface.
18249 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18252 (AttributeTester.GetObsoleteAttribute): Returns instance of
18253 ObsoleteAttribute when type is obsolete.
18256 (TypeContainer.VerifyObsoleteAttribute): Override.
18257 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18258 (MethodCode.VerifyObsoleteAttribute): Override.
18259 (MemberBase.VerifyObsoleteAttribute): Override.
18262 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18263 and report proper error.
18266 Delegate.VerifyObsoleteAttribute): Override.
18269 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18270 and report proper error.
18271 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18274 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18278 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18279 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18280 Added test for ObsoleteAttribute.
18283 (Catch): Derived from Statement.
18285 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18287 Fixed bug #59071 & cs0160.cs
18289 * statement.cs (Try.Resolve): Check here whether order of catch
18290 clauses matches their dependencies.
18292 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18294 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18295 caused a regression: #59343. Referencing nested classes from an
18296 assembly stopped working.
18298 2004-05-31 Martin Baulig <martin@ximian.com>
18300 MCS is now frozen for beta 2.
18302 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18304 * convert.cs: add a trivial cache for overload operator resolution.
18306 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18308 * decl.cs: If possible, use lookuptypedirect here. We can only do
18309 this if there is no `.' after the namespace. Avoids using
18310 LookupType, which does lots of slow processing.
18311 (FindNestedType) New method, does what it says :-).
18312 * namespace.cs: use LookupTypeDirect.
18313 * rootcontext.cs: use membercache, if possible.
18314 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18316 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18319 According to the spec,
18321 In a member access of the form E.I, if E is a single identifier,
18322 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18323 field, property, localvariable, or parameter with the same type as
18324 the meaning of E as a type-name (§3.8), then both possible
18325 meanings of E are permitted.
18327 We did not check that E as a simple-name had the same type as E as
18330 This trivial check gives us 5-7% on bootstrap time.
18332 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18334 * expression.cs (Invocation.OverloadResolve): Avoid the
18335 use of hashtables and boxing here by allocating on demand.
18337 2004-05-30 Martin Baulig <martin@ximian.com>
18339 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18340 we're doing a silent lookup. Don't try to lookup nested types in
18341 TypeManager.object_type (thanks to Ben Maurer).
18343 2004-05-30 Martin Baulig <martin@ximian.com>
18345 Committing a patch from Ben Maurer.
18347 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18349 2004-05-29 Martin Baulig <martin@ximian.com>
18351 * class.cs (IMethodData.ShouldIgnore): New method.
18353 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18354 `Location' argument, we don't need it anywhere. Use
18355 `IMethodData.ShouldIgnore ()' instead of
18356 `MethodData.GetMethodFlags ()'.
18357 (TypeManager.AddMethod): Removed.
18358 (TypeManager.AddMethod2): Renamed to AddMethod.
18360 2004-05-29 Martin Baulig <martin@ximian.com>
18362 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18364 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18365 converting from a class type S to an interface type and we already
18366 have an object on the stack, don't box it again. Fixes #52578.
18368 2004-05-29 Martin Baulig <martin@ximian.com>
18370 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18371 Added support for `params' parameters. Fixes #59267.
18373 2004-05-29 Martin Baulig <martin@ximian.com>
18375 * literal.cs (NullPointer): Provide a private .ctor which sets
18376 `type' to TypeManager.object_type. Fixes #59048.
18378 2004-05-29 Martin Baulig <martin@ximian.com>
18380 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18381 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18383 * ecore.cs (EventExpr.instance_expr): Make the field private.
18385 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18387 Fixed bug #50080 & cs0214-2.cs
18388 * expression.cs (Cast.DoResolve): Check unsafe context here.
18390 * statement.cs (Resolve.DoResolve): Likewise.
18392 2004-05-26 Martin Baulig <martin@ximian.com>
18394 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18396 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18397 (RootContext.LookupType): Pass down the `silent' flag.
18399 2004-05-25 Martin Baulig <martin@ximian.com>
18402 (MethodGroupExpr.IdenticalTypeName): New public property.
18403 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18404 expression actually refers to a type.
18406 2004-05-25 Martin Baulig <martin@ximian.com>
18408 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18409 for #56176 and made it actually work.
18411 2004-05-25 Martin Baulig <martin@ximian.com>
18413 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18414 (FieldExpr, PropertyExpr): Override and implement
18415 CacheTemporaries. Fixes #52279.
18417 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18419 * location.cs: In the new compiler listing a file twice is a
18420 warning, not an error.
18422 2004-05-24 Martin Baulig <martin@ximian.com>
18424 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18425 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18427 2004-05-24 Martin Baulig <martin@ximian.com>
18429 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18430 walking the `using' list. Fixes #53921.
18432 2004-05-24 Martin Baulig <martin@ximian.com>
18434 * const.cs (Const.LookupConstantValue): Added support for
18435 EmptyCast's; fixes #55251.
18437 2004-05-24 Martin Baulig <martin@ximian.com>
18439 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18440 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18441 which does the CS0135 check. The reason is that we first need to
18442 check whether the variable actually exists.
18444 2004-05-24 Martin Baulig <martin@ximian.com>
18446 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18447 than RootContext.LookupType() to find the explicit interface
18448 type. Fixes #58584.
18450 2004-05-24 Raja R Harinath <rharinath@novell.com>
18452 * Makefile: Simplify. Use executable.make.
18453 * mcs.exe.sources: New file. List of sources of mcs.exe.
18455 2004-05-24 Anders Carlsson <andersca@gnome.org>
18459 Use the invariant culture when doing String.Compare for CLS case
18462 2004-05-23 Martin Baulig <martin@ximian.com>
18464 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18465 don't have any dots. Fixes #52622, added cs0246-8.cs.
18467 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18469 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18471 * class.cs (MemberBase.Define): Reuse MemberType member for
18472 resolved type. Other methods can use it too.
18474 2004-05-23 Martin Baulig <martin@ximian.com>
18476 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18477 the variable also exists in the current block (otherwise, we need
18478 to report a CS0103). Fixes #58670.
18480 2004-05-23 Martin Baulig <martin@ximian.com>
18482 * flowanalysis.cs (Reachability.Reachable): Compute this
18483 on-the-fly rather than storing it as a field.
18485 2004-05-23 Martin Baulig <martin@ximian.com>
18487 * flowanalysis.cs (Reachability.And): Manually compute the
18488 resulting `barrier' from the reachability.
18490 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18493 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18494 instance of ObsoleteAttribute when symbol is obsolete.
18497 (IMethodData): Extended interface for ObsoleteAttribute support.
18499 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18501 * attribute.cs: Fix bug #55970
18503 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18507 (GetObsoleteAttribute): New method. Creates the instance of
18509 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18510 ObsoleteAttribute when member is obsolete.
18511 (AttributeTester.Report_ObsoleteMessage): Common method for
18512 Obsolete error/warning reporting.
18515 (TypeContainer.base_classs_type): New member for storing parent type.
18518 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18519 for this MemberCore.
18521 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18523 * attribute.cs, const.cs: Fix bug #58590
18525 2004-05-21 Martin Baulig <martin@ximian.com>
18527 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18528 out parameters if the end of the method is unreachable. Fixes
18531 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18533 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18534 Hari was right, why extra method.
18536 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18538 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18540 2004-05-20 Martin Baulig <martin@ximian.com>
18542 Merged this back from gmcs to keep the differences to a minumum.
18544 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18545 instead of a Declspace.
18546 (Attribute.ResolveType): Likewise.
18547 (Attributes.Search): Likewise.
18548 (Attributes.Contains): Likewise.
18549 (Attributes.GetClsCompliantAttribute): Likewise.
18551 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18553 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18556 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18558 Fix bug #58688 (MCS does not report error when the same attribute
18561 * attribute.cs (Attribute.Emit): Distinction between null and default.
18563 2004-05-19 Raja R Harinath <rharinath@novell.com>
18565 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18566 of a top-level attribute without an attribute target.
18567 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18569 (Attribute.Conditional_GetConditionName),
18570 (Attribute.Obsolete_GetObsoleteMessage): Update.
18571 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18572 part of ScanForIndexerName.
18573 (Attribute.CanIgnoreInvalidAttribute): New function.
18574 (Attribute.ScanForIndexerName): Move to ...
18575 (Attributes.ScanForIndexerName): ... here.
18576 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18577 (Attributes.Search): New internal variant that can choose not to
18578 complain if types aren't resolved. The original signature now
18580 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18581 complaints suppressed.
18582 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18583 only if it not useful.
18584 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18585 top-level for attributes that are shared between the assembly
18586 and a top-level class.
18587 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18588 * class.cs: Update to reflect changes.
18589 (DefineIndexers): Fuse loops.
18590 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18591 a couple more variants of attribute names.
18593 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18595 Fix bug #52585 (Implemented explicit attribute declaration)
18598 (Attributable.ValidAttributeTargets): New abstract method. It gets
18599 list of valid attribute targets for explicit target declaration.
18600 (Attribute.Target): It holds target itself.
18601 (AttributeSection): Removed.
18602 (Attribute.CheckTargets): New method. It checks whether attribute
18603 target is valid for the current element.
18606 (EventProperty): New class. For events that are declared like
18607 property (with add and remove accessors).
18608 (EventField): New class. For events that are declared like field.
18611 * cs-parser.jay: Implemented explicit attribute target declaration.
18613 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18614 Override ValidAttributeTargets.
18617 (ReturnParameter): Class for applying custom attributes on
18619 (ParameterAtribute): New class. Class for applying custom
18620 attributes on the parameter type.
18622 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18624 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18627 (Method): Allow UNSAFE here.
18629 * modifiers.cs: Support unsafe reporting.
18631 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18633 * decl.cs: Fix bug #58478.
18635 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18637 * statement.cs: When checking for unreachable code on an EmptyStatement,
18638 set the location. Fixes bug #58488.
18640 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18642 * driver.cs: Add -pkg handling.
18644 From Gonzalo: UseShelLExecute=false
18646 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18649 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18651 (Attribute.IsClsCompliaceRequired): Moved to base for better
18653 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18654 when attribute is AttributeUsageAttribute.
18655 (Attribute.GetValidTargets): Simplified.
18656 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18657 attribute for this type.
18658 (Attribute.ApplyAttributes): Method renamed to Emit and make
18660 (GlobalAttributeSection): New class for special handling of global
18661 attributes (assembly, module).
18662 (AttributeSection.Emit): New method.
18664 * class.cs: Implemented Attributable abstract methods.
18665 (MethodCore.LabelParameters): Moved to Parameter class.
18666 (Accessor): Is back simple class.
18667 (PropertyMethod): Implemented Attributable abstract class.
18668 (DelegateMethod): Implemented Attributable abstract class.
18669 (Event): New constructor for disctintion between normal Event
18670 and Event with accessors.
18672 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18674 * codegen.cs, const.cs, decl.cs, delegate.cs:
18675 (CommonAssemblyModulClass): Implemented Attributable abstract class
18678 * enum.cs: Implement IAttributeSupport interface.
18679 (EnumMember): New class for emum members. Implemented Attributable
18683 (ParameterBase): Is abstract.
18684 (ReturnParameter): New class for easier [return:] attribute handling.
18686 * typemanager.cs: Removed builder_to_attr.
18688 2004-05-11 Raja R Harinath <rharinath@novell.com>
18691 * attribute.cs (Attribute.GetPositionalValue): New function.
18692 * class.cs (TypeContainer.VerifyMembers): New function.
18693 (TypeContainer.Emit): Use it.
18694 (ClassOrStruct): New base class for Class and Struct.
18695 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18696 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18698 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18699 then each non-static field should have a FieldOffset attribute.
18700 Otherwise, none of the fields should have a FieldOffset attribute.
18701 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18702 and FieldOffset attributes.
18703 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18704 (TypeManager.field_offset_attribute_type): New core types.
18705 (TypeManager.InitCoreTypes): Initialize them.
18707 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18709 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18710 Return correct type.
18713 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18715 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18716 be implicitly converted to ulong.
18718 * expression.cs: The logic for allowing operator &, | and ^ worked
18719 was wrong, it worked before because we did not report an error in
18720 an else branch. Fixes 57895.
18722 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18723 allow volatile fields to be reference types.
18725 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18727 * driver.cs: Add support for /debug-
18729 2004-05-07 Raja R Harinath <rharinath@novell.com>
18731 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18732 Add a 'complain' parameter to silence errors.
18733 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18734 silently overlooked type-resolutions.
18735 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18736 to reflect changes.
18737 (Attributes.Search): New function.
18738 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18739 (Attributes.GetAttributeFullName): Remove hack.
18740 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18741 Update to reflect changes.
18742 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18743 Use Attributes.Search instead of nested loops.
18745 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18748 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18749 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18750 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18752 * report.cs: (Report.Warning): Renamed to Warning_T because of
18753 parameter collision.
18755 2004-05-05 Raja R Harinath <rharinath@novell.com>
18757 * expression.cs (MemberAccess.ResolveMemberAccess):
18758 Exit with non-zero status after Report.Error.
18759 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18761 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18763 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18765 * support.cs: Don't hang when the file is empty.
18767 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18769 * support.cs: In SeekableStreamReader, compute the preamble size of the
18770 underlying stream. Position changes should take into account that initial
18773 2004-05-03 Todd Berman <tberman@sevenl.net>
18775 * driver.cs: remove unused GetSysVersion function.
18777 2004-05-03 Todd Berman <tberman@sevenl.net>
18779 * driver.cs: Remove the hack from saturday, as well as the hack
18780 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18781 link_paths to get that bit proper.
18783 2004-05-01 Todd Berman <tberman@sevenl.net>
18785 * driver.cs: Try a LoadFrom before a Load, this checks the current
18786 path. This is currently a bug in mono that is be fixed, however, this
18787 provides a workaround for now. This will be removed when the bug
18790 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18792 * CryptoConvert.cs: Updated to latest version. Fix issue with
18793 incomplete key pairs (#57941).
18795 2004-05-01 Todd Berman <tberman@sevenl.net>
18797 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18800 2004-04-30 Jackson Harper <jackson@ximian.com>
18802 * codegen.cs: Open keys readonly.
18804 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18806 * typemanager.cs: don't report cyclic struct layout when a struct
18807 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18808 which has 2 Pango.Rectangle fields.
18810 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18812 * expression.cs: Handle IntPtr comparisons with IL code
18813 rather than a method call.
18815 2004-04-29 Martin Baulig <martin@ximian.com>
18817 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18818 the list of PropertyInfo's in class hierarchy and find the
18819 accessor. Fixes #56013.
18821 2004-04-29 Martin Baulig <martin@ximian.com>
18823 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18825 2004-04-29 Martin Baulig <martin@ximian.com>
18827 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18829 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18831 2004-04-29 Martin Baulig <martin@ximian.com>
18833 * class.cs (ConstructorInitializer.Resolve): Check whether the
18834 parent .ctor is accessible. Fixes #52146.
18836 2004-04-29 Martin Baulig <martin@ximian.com>
18838 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18840 * statement.cs (Using.EmitLocalVariableDecls): Use
18841 TypeManager.idisposable_type, not typeof (IDisposable).
18842 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18844 2004-04-29 Martin Baulig <martin@ximian.com>
18846 * class.cs (Event.Define): Don't emit the field and don't set
18847 RTSpecialName and SpecialName for events on interfaces. Fixes
18850 2004-04-29 Raja R Harinath <rharinath@novell.com>
18852 Refactor Attribute.ApplyAttributes.
18853 * attribute.cs (Attributable): New base class for objects that can
18854 have Attributes applied on them.
18855 (Attribute): Make AttributeUsage fields public.
18856 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18857 (Attribute.IsInternalCall): New property.
18858 (Attribute.UsageAttr): Convert to a public read-only property.
18859 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18860 (Attribute.ResolveType, Attribute.Resolve)
18861 (Attribute.ScanForIndexerName): Update to reflect changes.
18862 (Attribute.CheckAttributeTarget): Re-format.
18863 (Attribute.ApplyAttributes): Refactor, to various
18864 Attributable.ApplyAttributeBuilder methods.
18865 * decl.cs (MemberCore): Make Attributable.
18866 * class.cs (Accessor): Make Attributable.
18867 (MethodData.ApplyAttributes): Use proper attribute types, not
18869 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18870 (TypeContainer.ApplyAttributeBuilder)
18871 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18872 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18873 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18874 (Operator.ApplyAttributeBuilder): New factored-out methods.
18875 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18876 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18877 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18878 * parameter.cs (ParameterBase): New Attributable base class
18879 that can also represent Return types.
18880 (Parameter): Update to the changes.
18882 2004-04-29 Jackson Harper <jackson@ximian.com>
18884 * driver.cs: Prefer the corlib system version when looking for
18885 assemblies in the GAC. This is still a hack, but its a better hack
18888 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18890 * decl.cs, enum.cs: Improved error 3005 reporting.
18892 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18893 (related_symbols): New private member for list of symbols
18894 related to reported error/warning.
18896 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18898 2004-04-29 Martin Baulig <martin@ximian.com>
18900 * ecore.cs (Expression.Constantify): If we're an enum and
18901 TypeManager.TypeToCoreType() doesn't give us another type, use
18902 t.UnderlyingSystemType. Fixes #56178.
18904 2004-04-29 Martin Baulig <martin@ximian.com>
18906 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18907 interfaces and for each interface, only add members directly
18908 declared in that interface. Fixes #53255.
18910 2004-04-28 Martin Baulig <martin@ximian.com>
18912 * expression.cs (ConditionalLogicalOperator): Use a temporary
18913 variable for `left' to avoid that we evaluate it more than once;
18916 2004-04-28 Martin Baulig <martin@ximian.com>
18918 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18921 2004-04-28 Martin Baulig <martin@ximian.com>
18923 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18926 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18927 whether the type is not void (CS1547).
18929 2004-04-28 Martin Baulig <martin@ximian.com>
18931 * expression.cs (Unary.DoResolveLValue): Override this and report
18932 CS0131 for anything but Operator.Indirection.
18934 2004-04-28 Martin Baulig <martin@ximian.com>
18936 Committing a patch from Ben Maurer; see bug #50820.
18938 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18941 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18944 2004-04-28 Martin Baulig <martin@ximian.com>
18946 Committing a patch from Ben Maurer; see bug #50820.
18948 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18951 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18954 2004-04-28 Martin Baulig <martin@ximian.com>
18956 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18957 (Block.AddLabel): Call DoLookupLabel() to only search in the
18960 2004-04-28 Martin Baulig <martin@ximian.com>
18962 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18963 comparing StringConstants and NullLiterals in Equality and Inequality.
18965 2004-04-28 Jackson Harper <jackson@ximian.com>
18967 * driver.cs: Attempt to load referenced assemblies from the
18968 GAC. This is the quick and dirty version of this method that
18969 doesnt take into account versions and just takes the first
18970 canidate found. Will be good enough for now as we will not have more
18971 then one version installed into the GAC until I update this method.
18973 2004-04-28 Martin Baulig <martin@ximian.com>
18975 * typemanager.cs (TypeManager.CheckStructCycles): New public
18976 static method to check for cycles in the struct layout.
18978 * rootcontext.cs (RootContext.PopulateTypes): Call
18979 TypeManager.CheckStructCycles() for each TypeContainer.
18980 [Note: We only need to visit each type once.]
18982 2004-04-28 Martin Baulig <martin@ximian.com>
18984 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18986 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18987 success and added `out object value'. Use a `bool resolved' field
18988 to check whether we've already been called rather than
18989 `ConstantValue != null' since this breaks for NullLiterals.
18991 2004-04-28 Raja R Harinath <rharinath@novell.com>
18993 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18994 setting of this flag, since the 'set' method may be non-public.
18996 2004-04-28 Raja R Harinath <rharinath@novell.com>
18998 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18999 check on current_vector.Block.
19001 2004-04-27 Martin Baulig <martin@ximian.com>
19003 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19004 a field initializer. Fixes #56459.
19006 2004-04-27 Martin Baulig <martin@ximian.com>
19008 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19009 we're not attempting to use an indexer. Fixes #52154.
19011 2004-04-27 Martin Baulig <martin@ximian.com>
19013 * statement.cs (Return): Don't create a return label if we don't
19014 need it; reverts my change from January 20th. Thanks to Ben
19017 2004-04-27 Martin Baulig <martin@ximian.com>
19019 According to the spec, `goto' can only leave a nested scope, but
19022 * statement.cs (Block.LookupLabel): Only lookup in the current
19023 block, don't recurse into parent or child blocks.
19024 (Block.AddLabel): Check in parent and child blocks, report
19025 CS0140/CS0158 if we find a duplicate.
19026 (Block): Removed this indexer for label lookups.
19027 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19028 this already does the error reporting for us.
19031 (FlowBranching.UsageVector.Block): New public variable; may be null.
19032 (FlowBranching.CreateSibling): Added `Block' argument.
19033 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19034 label for the target of a `goto' and check whether we're not
19035 leaving a `finally'.
19037 2004-04-27 Martin Baulig <martin@ximian.com>
19039 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19040 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19043 2004-04-27 Martin Baulig <martin@ximian.com>
19045 * statement.cs (Block.AddLabel): Also check for implicit blocks
19046 and added a CS0158 check.
19048 2004-04-27 Martin Baulig <martin@ximian.com>
19050 * flowanalysis.cs (FlowBranchingLoop): New class.
19051 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19052 UsageVector's instead of an ArrayList.
19053 (FlowBranching.Label): Likewise.
19054 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19055 (FlowBranching.AddBreakVector): New method.
19057 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19059 * attribute.cs: Small regression fix: only convert the type if we
19060 the type is different, fixes System.Drawing build.
19062 2004-04-27 Martin Baulig <martin@ximian.com>
19064 * attribute.cs (Attribute.Resolve): If we have a constant value
19065 for a named field or property, implicity convert it to the correct
19068 2004-04-27 Raja R Harinath <rharinath@novell.com>
19070 * statement.cs (Block.Block): Implicit blocks share
19071 'child_variable_names' fields with parent blocks.
19072 (Block.AddChildVariableNames): Remove.
19073 (Block.AddVariable): Mark variable as "used by a child block" in
19074 every surrounding block.
19075 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19076 been used in a child block, complain about violation of "Invariant
19077 meaning in blocks" rule.
19078 * cs-parser.jay (declare_local_variables): Don't use
19079 AddChildVariableNames.
19080 (foreach_statement): Don't create an implicit block: 'foreach'
19081 introduces a scope.
19083 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19085 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19086 converting from 0L to ulong. Fixes 57522.
19088 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19090 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19091 derived class hides via 'new' keyword field from base class (test-242.cs).
19092 TODO: Handle this in the more general way.
19094 * class.cs (CheckBase): Ditto.
19096 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19098 * decl.cs (caching_flags): New member for storing cached values
19100 (MemberCore.Flags): New enum where bit flags for caching_flags
19102 (MemberCore.cls_compliance): Moved to caching_flags.
19103 (DeclSpace.Created): Moved to caching_flags.
19105 * class.cs: Use caching_flags instead of DeclSpace.Created
19107 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19109 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19110 if we are only a derived class, not a nested class.
19112 * typemanager.cs: Same as above, but do this at the MemberLookup
19113 level (used by field and methods, properties are handled in
19114 PropertyExpr). Allow for the qualified access if we are a nested
19117 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19119 * class.cs: Refactoring.
19120 (IMethodData): New inteface; Holds links to parent members
19121 to avoid member duplication (reduced memory allocation).
19122 (Method): Implemented IMethodData interface.
19123 (PropertyBase): New inner classes for get/set methods.
19124 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19125 (Event): New inner classes for add/remove methods.
19126 (Event.DelegateMethod): Implemented IMethodData interface.
19128 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19129 EmitContext (related to class.cs refactoring).
19131 2004-04-21 Raja R Harinath <rharinath@novell.com>
19133 * delegate.cs (Delegate.VerifyApplicability): If the number of
19134 arguments are the same as the number of parameters, first try to
19135 verify applicability ignoring any 'params' modifier on the last
19139 2004-04-16 Raja R Harinath <rharinath@novell.com>
19141 * class.cs (TypeContainer.AddIndexer): Use
19142 'ExplicitInterfaceName' to determine if interface name was
19143 explicitly specified. 'InterfaceType' is not initialized at this time.
19144 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19145 Indexers array is already in the required order. Initialize
19146 'IndexerName' only if there are normal indexers.
19147 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19148 (TypeContainer.Emit): Emit DefaultMember attribute only if
19149 IndexerName is initialized.
19152 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19154 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19157 2004-04-15 Raja R Harinath <rharinath@novell.com>
19159 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19163 * attribute.cs (Attribute.Resolve): Check for duplicate named
19167 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19169 * iterators.cs (MarkYield): track whether we are in an exception,
19170 and generate code accordingly. Use a temporary value to store the
19171 result for our state.
19173 I had ignored a bit the interaction of try/catch with iterators
19174 since their behavior was not entirely obvious, but now it is
19175 possible to verify that our behavior is the same as MS .NET 2.0
19179 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19181 * iterators.cs: Avoid creating temporaries if there is no work to
19184 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19185 Enumerations, use TypeManager.EnumToUnderlying and call
19188 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19191 (This.Emit): Use EmitContext.EmitThis to emit our
19194 (This.EmitAssign): Ditto.
19196 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19197 codepaths, we will move all the functionality into
19200 (FieldExpr.EmitAssign): Ditto.
19202 This fixes several hidden bugs that I uncovered while doing a code
19203 review of this today.
19205 * codegen.cs (EmitThis): reworked so the semantics are more clear
19206 and also support value types "this" instances.
19208 * iterators.cs: Changed so that for iterators in value types, we
19209 do not pass the value type as a parameter.
19211 Initialization of the enumerator helpers is now done in the caller
19212 instead of passing the parameters to the constructors and having
19213 the constructor set the fields.
19215 The fields have now `assembly' visibility instead of private.
19217 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19219 * expression.cs (Argument.Resolve): Check if fields passed as ref
19220 or out are contained in a MarshalByRefObject.
19222 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19223 another compiler type.
19225 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19227 * class.cs (Indexer.Define): use the new name checking method.
19228 Also, return false on an error.
19229 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19230 (is_identifier_[start/part]_character): make static.
19232 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19234 * expression.cs (Binary.ResolveOperator): Do no append strings
19235 twice: since we can be invoked more than once (array evaluation)
19236 on the same concatenation, take care of this here. Based on a fix
19237 from Ben (bug #56454)
19239 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19241 * codegen.cs: Fix another case where CS1548 must be reported (when
19242 delay-sign isn't specified and no private is available #56564). Fix
19243 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19244 error when MCS is used on the MS runtime and we need to delay-sign
19245 (which seems unsupported by AssemblyBuilder - see #56621).
19247 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19249 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19250 (TypeManager.ComputeNamespaces): Faster implementation for
19253 * compiler.csproj: Updated AssemblyName to mcs.
19255 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19257 * rootcontext.cs: Add new types to the boot resolution.
19259 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19260 MulticastDelegate is not allowed.
19262 * typemanager.cs: Add new types to lookup: System.TypedReference
19265 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19266 check for TypedReference or ArgIterator, they are not allowed.
19268 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19269 makes us properly catch 1510 in some conditions (see bug 56016 for
19272 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19274 * CryptoConvert.cs: update from corlib version
19277 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19279 * class.cs (Indexer.Define): Check indexername declaration
19281 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19283 * attribute.cs (IsClsCompliant): Fixed problem with handling
19284 all three states (compliant, not-compliant, undetected).
19286 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19288 * attribute.cs (Attribute): Location is now public.
19289 (Resolve): Store resolved arguments (pos_values) in attribute class.
19290 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19291 (GetClsCompliantAttributeValue): New method that gets
19292 CLSCompliantAttribute value.
19293 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19294 if exists else null.
19295 (AttributeTester): New class for CLS-Compliant verification routines.
19297 * class.cs (Emit): Add CLS-Compliant verification.
19298 (Method.GetSignatureForError): Implemented.
19299 (Constructor.GetSignatureForError): Implemented
19300 (Constructor.HasCompliantArgs): Returns if constructor has
19301 CLS-Compliant arguments.
19302 (Constructor.Emit): Override.
19303 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19304 is needed to test only parameters.
19305 (FieldBase.GetSignatureForError): Implemented.
19306 (TypeContainer): New member for storing base interfaces.
19307 (TypeContainer.FindMembers): Search in base interfaces too.
19309 * codegen.cs (GetClsComplianceAttribute): New method that gets
19310 assembly or module CLSCompliantAttribute value.
19311 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19313 (ModuleClass.Emit): Add error 3012 test.
19315 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19317 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19318 state for all decl types.
19319 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19320 if CLS-Compliant tests are required.
19321 (IsClsCompliaceRequired): New method. Analyze whether code
19322 must be CLS-Compliant.
19323 (IsExposedFromAssembly): New method. Returns true when MemberCore
19324 is exposed from assembly.
19325 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19326 value or gets cached value.
19327 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19328 is explicitly marked with CLSCompliantAttribute.
19329 (IsIdentifierClsCompliant): New abstract method. This method is
19330 used to testing error 3005.
19331 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19332 for identifier and parameters CLS-Compliant testing.
19333 (VerifyClsCompliance): New method. The main virtual method for
19334 CLS-Compliant verifications.
19335 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19336 null. I don't know why is null (too many public members !).
19337 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19338 and get value of first CLSCompliantAttribute that found.
19340 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19341 (VerifyClsCompliance): Override and add extra tests.
19343 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19344 clscheck- disable CLS-Compliant verification event if assembly is has
19345 CLSCompliantAttribute(true).
19347 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19348 ApllyAttribute is now called in emit section as in the other cases.
19349 Possible future Emit integration.
19350 (IsIdentifierClsCompliant): New override.
19351 (VerifyClsCompliance): New override.
19352 (GetEnumeratorName): Returns full enum name.
19354 * parameter.cs (GetSignatureForError): Implemented.
19356 * report.cs (WarningData): New struct for Warning message information.
19357 (LocationOfPreviousError): New method.
19358 (Warning): New method. Reports warning based on the warning table.
19359 (Error_T): New method. Reports error based on the error table.
19361 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19362 verifications are done here.
19364 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19366 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19367 CLSCompliantAttribute.
19368 (all_imported_types): New member holds all imported types from other
19370 (LoadAllImportedTypes): New method fills static table with exported types
19371 from all referenced assemblies.
19372 (Modules): New property returns all assembly modules.
19374 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19376 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19377 throwing a parser error.
19379 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19380 which removes the hardcoded get_/set_ prefixes for properties, as
19381 IL allows for the properties to be named something else.
19385 * expression.cs: Do not override operand before we know if it is
19386 non-null. Fix 56207
19388 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19390 * typemanager.cs: support for pinned variables.
19392 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19394 * decl.cs, typemanager.cs: Avoid using an arraylist
19395 as a buffer if there is only one result set.
19397 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19399 * expression.cs: Make sure you cant call a static method
19400 with an instance expression, bug #56174.
19402 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19404 * class.cs (IsDuplicateImplementation): Improve error reporting to
19405 flag 663 (method only differs in parameter modifier).
19407 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19408 in preprocessor directives.
19410 * location.cs (LookupFile): Allow for the empty path.
19412 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19413 better approach for some of that patch, but its failing with the
19414 CharSet enumeration. For now try/catch will do.
19416 * typemanager.cs: Do not crash if a struct does not have fields.
19419 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19421 * expression.cs: cs0213, cant fix a fixed expression.
19424 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19426 * cs-parser.jay: detect invalid embeded statements gracefully.
19429 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19431 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19434 the invocation type may not be a subclass of the tye of the item/
19435 The type of the item must be a subclass of the invocation item.
19440 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19442 * attribute.cs: Added methods to get a string and a bool from an
19443 attribute. Required to information from AssemblyKeyFileAttribute,
19444 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19445 * codegen.cs: Modified AssemblyName creation to include support for
19446 strongnames. Catch additional exceptions to report them as CS1548.
19447 * compiler.csproj: Updated include CryptoConvert.cs.
19448 * compiler.csproj.user: Removed file - user specific configuration.
19449 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19450 Mono.Security assembly. The original class is maintained and tested in
19451 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19452 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19453 like CSC 8.0 (C# v2) supports.
19454 * Makefile: Added CryptoConvert.cs to mcs sources.
19455 * rootcontext.cs: Added new options for strongnames.
19457 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19459 * driver.cs: For --expect-error, report error code `2'
19460 if the program compiled with no errors, error code `1' if
19461 it compiled with an error other than the one expected.
19463 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19465 * compiler.csproj: Updated for Visual Studio .NET 2003.
19466 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19467 * compiler.sln: Updated for Visual Studio .NET 2003.
19469 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19471 * expression.cs: Fix bug #47234. We basically need to apply the
19472 rule that we prefer the conversion of null to a reference type
19473 when faced with a conversion to 'object' (csc behaviour).
19475 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19477 * statement.cs: Shorter form for foreach, eliminates
19478 a local variable. r=Martin.
19480 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19482 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19483 checks if we can use brtrue/brfalse to test for 0.
19484 * expression.cs: use the above in the test for using brtrue/brfalse.
19485 cleanup code a bit.
19487 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19489 * expression.cs: Rewrite string concat stuff. Benefits:
19491 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19492 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19493 rather than a concat chain.
19495 * typemanager.cs: Add lookups for more concat overloads.
19497 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19499 * expression.cs: Emit shorter il code for array init.
19516 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19518 * statement.cs: Before, two switch blocks would be merged if the
19519 total size of the blocks (end_item - begin_item + 1) was less than
19520 two times the combined sizes of the blocks.
19522 Now, it will only merge if after the merge at least half of the
19527 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19529 * class.cs : csc build fix for GetMethods(). See bug #52503.
19531 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19533 * expression.cs: Make sure fp comparisons work with NaN.
19534 This fixes bug #54303. Mig approved this patch a long
19535 time ago, but we were not able to test b/c the runtime
19538 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19540 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19542 2004-03-19 Martin Baulig <martin@ximian.com>
19544 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19545 error here and not in our caller.
19547 2004-03-19 Martin Baulig <martin@ximian.com>
19549 * interface.cs: Completely killed this file.
19550 (Interface): We're now a TypeContainer and live in class.cs.
19552 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19553 argument; we're now also called for interfaces.
19554 (TypeContainer.DefineMembers): Allow this method being called
19556 (TypeContainer.GetMethods): New public method; formerly known as
19557 Interface.GetMethod(). This is used by PendingImplementation.
19558 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19559 it's now private and non-static.
19560 (Interface): Moved this here; it's now implemented similar to
19562 (Method, Property, Event, Indexer): Added `bool is_interface'
19563 argument to their .ctor's.
19564 (MemberBase.IsInterface): New public field.
19566 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19567 instances instead of InterfaceMethod, InterfaceProperty, etc.
19568 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19569 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19571 2004-03-19 Martin Baulig <martin@ximian.com>
19573 * class.cs (MethodCore.IsDuplicateImplementation): New private
19574 method which does the CS0111 checking.
19575 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19576 Use IsDuplicateImplementation().
19578 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19580 * decl.cs (FindMemberToOverride): New method to find the correct
19581 method or property to override in the base class.
19583 - Make Method/Property use the above method to find the
19584 version in the base class.
19585 - Remove the InheritableMemberSignatureCompare as it is now
19588 This patch makes large code bases much faster to compile, as it is
19589 O(n) rather than O(n^2) to do this validation.
19591 Also, it fixes bug 52458 which is that nested classes are not
19592 taken into account when finding the base class member.
19594 Reviewed/Approved by Martin.
19596 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19598 * interface.cs: In all interface classes removed redundant
19599 member initialization.
19601 2004-03-16 Martin Baulig <martin@ximian.com>
19603 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19605 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19607 * decl.cs (DefineTypeAndParents): New helper method to define a
19608 type's containers before the type itself is defined; This is a
19609 bug exposed by the recent changes to Windows.Forms when an
19610 implemented interface was defined inside a class that had not been
19613 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19615 (Check): Loop correctly to report errors modifiers
19616 (UNSAFE was not in the loop, since it was the same as TOP).
19618 * interface.cs: Every interface member now takes a ModFlags,
19619 instead of a "is_new" bool, which we set on the base MemberCore.
19621 Every place where we called "UnsafeOk" in the interface, now we
19622 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19623 the unsafe settings from the member declaration instead of the
19624 container interface.
19626 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19628 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19629 `set_indexer_name' to the pending bits (one per type).
19631 We fixed a bug today that was picking the wrong method to
19632 override, since for properties the existing InterfaceMethod code
19633 basically ignored the method name. Now we make sure that the
19634 method name is one of the valid indexer names.
19636 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19638 * support.cs (SeekableStreamReader): Keep track of stream byte
19639 positions and don't mix them with character offsets to the buffer.
19641 Patch from Gustavo Giráldez
19643 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19645 * interface.cs (InterfaceSetGetBase): Removed double member
19646 initialization, base class does it as well.
19648 2004-03-13 Martin Baulig <martin@ximian.com>
19650 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19651 when compiling corlib.
19653 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19655 * convert.cs (ExplicitConversion): We were reporting an error on
19656 certain conversions (object_type source to a value type, when the
19657 expression was `null') before we had a chance to pass it through
19658 the user defined conversions.
19660 * driver.cs: Replace / and \ in resource specifications to dots.
19663 * class.cs: Add check for duplicate operators. Fixes 52477
19665 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19667 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19668 that are in the middle of the statements, not only at the end.
19671 * class.cs (TypeContainer.AddField): No longer set the
19672 `HaveStaticConstructor' flag, now we call it
19673 `UserDefineStaticConstructor' to diferentiate the slightly
19674 semantic difference.
19676 The situation is that we were not adding BeforeFieldInit (from
19677 Modifiers.TypeAttr) to classes that could have it.
19678 BeforeFieldInit should be set to classes that have no static
19683 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19685 And most importantly Zoltan's comment:
19687 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19689 "I think beforefieldinit means 'it's ok to initialize the type sometime
19690 before its static fields are used', i.e. initialization does not need
19691 to be triggered by the first access to the type. Setting this flag
19692 helps the JIT to compile better code, since it can run the static
19693 constructor at JIT time, and does not need to generate code to call it
19694 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19695 this flag for lots of classes like String.
19697 csc sets this flag if the type does not have an explicit static
19698 constructor. The reasoning seems to be that if there are only static
19699 initalizers for a type, and no static constructor, then the programmer
19700 does not care when this initialization happens, so beforefieldinit
19703 This bug prevents the AOT compiler from being usable, since it
19704 generates so many calls to mono_runtime_class_init that the AOT code
19705 is much slower than the JITted code. The JITted code is faster,
19706 because it does not generate these calls if the vtable is type is
19707 already initialized, which is true in the majority of cases. But the
19708 AOT compiler can't do this."
19710 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19712 * class.cs (MethodData.Emit): Refactor the code so symbolic
19713 information is generated for destructors; For some reasons we
19714 were taking a code path that did not generate symbolic information
19717 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19719 * class.cs: Create a Constructor.CheckBase method that
19720 takes care of all validation type code. The method
19721 contains some code that was moved from Define.
19723 It also includes new code that checks for duplicate ctors.
19724 This fixes bug #55148.
19726 2004-03-09 Joshua Tauberer <tauberer@for.net>
19728 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19729 a { ... }-style array creation invokes EmitStaticInitializers
19730 which is not good for reference-type arrays. String, decimal
19731 and now null constants (NullCast) are not counted toward
19732 static initializers.
19734 2004-03-05 Martin Baulig <martin@ximian.com>
19736 * location.cs (SourceFile.HasLineDirective): New public field;
19737 specifies whether the file contains or is referenced by a "#line"
19739 (Location.DefineSymbolDocuments): Ignore source files which
19740 either contain or are referenced by a "#line" directive.
19742 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19744 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19745 direct access to our parent, so check the method inline there.
19747 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19749 * expression.cs (Invocation.EmitCall): Miguel's last commit
19750 caused a regression. If you had:
19755 In Foo the implict this would be null.
19757 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19759 * expression.cs (Invocation.EmitCall): If the method is not
19760 virtual, do not emit a CallVirt to it, use Call.
19762 * typemanager.cs (GetFullNameSignature): Improve the method to
19763 cope with ".ctor" and replace it with the type name.
19765 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19766 as an argument the ConstructorBuilder where it is being defined,
19767 to catch the recursive constructor invocations.
19769 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19771 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19772 routines to check if a type is an enumerable/enumerator allow
19773 classes that implement the IEnumerable or IEnumerator interfaces.
19775 * class.cs (Property, Operator): Implement IIteratorContainer, and
19776 implement SetYields.
19778 (Property.Define): Do the block swapping for get_methods in the
19779 context of iterators. We need to check if Properties also
19780 include indexers or not.
19782 (Operator): Assign the Block before invoking the
19783 OperatorMethod.Define, so we can trigger the Iterator code
19786 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19787 Property and Operator classes are not created when we parse the
19788 declarator but until we have the block completed, so we use a
19789 singleton SimpleIteratorContainer.Simple to flag whether the
19790 SetYields has been invoked.
19792 We propagate this setting then to the Property or the Operator to
19793 allow the `yield' to function.
19795 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19797 * codegen.cs: Implemented attribute support for modules.
19798 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19799 Assembly/Module functionality.
19801 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19802 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19803 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19805 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19807 * interface.cs (FindMembers): The operation is performed on all base
19808 interfaces and not only on the first. It is required for future CLS Compliance patch.
19810 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19812 * statement.cs, codegen.cs:
19813 This patch deals with patterns such as:
19815 public class List : IEnumerable {
19817 public MyEnumerator GetEnumerator () {
19818 return new MyEnumerator(this);
19821 IEnumerator IEnumerable.GetEnumerator () {
19825 public struct MyEnumerator : IEnumerator {
19830 Before, there were a few things we did wrong:
19831 1) we would emit callvirt on a struct, which is illegal
19832 2) we emited ldarg when we needed to emit ldarga
19833 3) we would mistakenly call the interface methods on an enumerator
19834 type that derived from IEnumerator and was in another assembly. For example:
19836 public class MyEnumerator : IEnumerator
19838 Would have the interface methods called, even if there were public impls of the
19839 method. In a struct, this lead to invalid IL code.
19841 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19843 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19846 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19848 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19850 * cs-parser.jay: Fix small regression: we were not testing V2
19851 compiler features correctly.
19853 * interface.cs: If the emit context is null, then create one
19855 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19857 * decl.cs (GetSignatureForError): New virtual method to get full name
19858 for error messages.
19860 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19861 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19863 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19864 Duplicated members and code in these classes has been removed.
19865 Better encapsulation in these classes.
19867 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19869 * assign.cs (Assign.DoResolve): When dealing with compound
19870 assignments, there is a new rule in ECMA C# 2.4 (might have been
19871 there before, but it is documented here) that states that in:
19875 If b is of type int, and the `op' is a shift-operator, then the
19876 above is evaluated as:
19880 * expression.cs (Binary.ResolveOperator): Instead of testing for
19881 int/uint/long/ulong, try to implicitly convert to any of those
19882 types and use that in pointer arithmetic.
19884 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19885 method to print information for from the type, not from the
19886 null-method we were given.
19888 2004-02-01 Duncan Mak <duncan@ximian.com>
19890 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19891 parsing for cmd, fixes bug #53694.
19893 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19895 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19896 in the member name duplication tests. Property and operator name duplication
19897 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19899 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19901 * interface.cs (PopulateMethod): Fixed crash when interface method
19902 returns not existing type (error test cs0246-3.cs).
19904 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19906 * cs-parser.jay (interface_accessors): Re-write actions to also
19907 store attributes attached to get and set methods. Fix spelling
19910 (inteface_property_declaration): Modify accordingly.
19912 (InterfaceAccessorInfo): New helper class to store information to pass
19913 around between rules that use interface_accessors.
19915 * interface.cs (Emit): Apply attributes on the get and set
19916 accessors of properties and indexers too.
19918 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19919 right MethodBuilder when applying attributes to the get and set accessors.
19921 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19923 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19925 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19927 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19929 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19931 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19932 changes that treat `yield' specially when present before `break'
19933 or `return' tokens.
19935 * cs-tokenizer.cs: yield is no longer a keyword.
19937 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19939 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19940 setting for default constructors.
19941 For default constructors are almost every time set wrong Modifier. The
19942 generated IL code has been alright. But inside mcs this values was
19943 wrong and this was reason why several of my CLS Compliance tests
19946 2004-01-22 Martin Baulig <martin@ximian.com>
19948 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19949 not a QualifiedIdentifier. This is what `type_name_expression'
19950 was previously doing.
19951 (type_name_expression): Removed; the code is now in
19952 `namespace_or_type_name'.
19953 (qualified_identifier): Removed, use `namespace_or_type_name'
19955 (QualifiedIdentifier): Removed this class.
19957 2004-01-22 Martin Baulig <martin@ximian.com>
19959 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19960 not a string as alias name.
19962 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19964 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19965 #52730 bug, and instead compute correctly the need to use a
19966 temporary variable when requesting an address based on the
19967 static/instace modified of the field and the constructor.
19969 2004-01-21 Martin Baulig <martin@ximian.com>
19971 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19972 class and namespace before looking up aliases. Fixes #52517.
19974 2004-01-21 Martin Baulig <martin@ximian.com>
19976 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19977 assinged in a 'try'; fixes exception4.cs.
19979 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19980 * class.cs : Implemented parameter-less constructor for TypeContainer
19982 * decl.cs: Attributes are now stored here. New property OptAttributes
19984 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19986 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19988 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19990 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19991 (CSharpSignature): New method for indexer and property signature.
19993 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19995 * pending.cs (IsVirtualFilter): Faster implementation.
19997 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19999 * typemanager.cs: Avoid inclusion of same assembly more than once.
20001 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20003 * cs-parser.jay: Fixed problem where the last assembly attribute
20004 has been applied also to following declaration (class, struct, etc.)
20006 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20008 * class.cs: Added error CS0538, CS0539 reporting.
20009 Fixed crash on Microsoft runtime when field type is void.
20011 * cs-parser.jay: Added error CS0537 reporting.
20013 * pending.cs: Added error CS0535 reporting.
20014 Improved error report for errors CS0536, CS0534.
20016 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20018 Merge a few bits from the Anonymous Method MCS tree.
20020 * statement.cs (ToplevelBlock): New class for toplevel methods,
20021 will hold anonymous methods, lifted variables.
20023 * cs-parser.jay: Create toplevel blocks for delegates and for
20024 regular blocks of code.
20026 2004-01-20 Martin Baulig <martin@ximian.com>
20028 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20029 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20030 and `NeedExplicitReturn'; added `IsLastStatement'.
20031 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20032 have a `ReturnLabel' or we're not unreachable.
20034 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20035 child's reachability; don't just override ours with it. Fixes
20036 #58058 (lluis's example).
20037 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20038 InFinally(), InLoop(), InSwitch() and
20039 BreakCrossesTryCatchBoundary() methods.
20041 * statement.cs (Return): Do all error checking in Resolve().
20042 Unless we are the last statement in a top-level block, always
20043 create a return label and jump to it.
20044 (Break, Continue): Do all error checking in Resolve(); also make
20045 sure we aren't leaving a `finally'.
20046 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20047 statement in a top-level block.
20048 (Block.Flags): Added `IsDestructor'.
20049 (Block.IsDestructor): New public property.
20051 2004-01-20 Martin Baulig <martin@ximian.com>
20053 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20055 2004-01-20 Martin Baulig <martin@ximian.com>
20057 * statement.cs (Statement.ResolveUnreachable): New public method.
20058 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20059 (Block.Resolve): Resolve unreachable statements.
20061 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20063 * expression.cs: We need to fix the case where we do
20064 not have a temp variable here.
20066 * assign.cs: Only expression compound assignments need
20067 temporary variables.
20069 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20071 * flowanalysis.cs: Reduce memory allocation in a few ways:
20072 - A block with no variables should not allocate a bit
20074 - A method with no out parameters does not need any tracking
20075 for assignment of the parameters, so we need not allocate
20078 public readonly Type[] VariableTypes;
20079 public readonly string[] VariableNames;
20080 Are redundant. The data is already stored in the variable
20081 map, so we need not allocate another array for it.
20082 - We need to add alot of checks for if (params | locals) == null
20083 due to the first two changes.
20085 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20087 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20088 implement IMemoryLocation, we store a copy on a local variable and
20089 take the address of it. Patch from Benjamin Jemlich
20091 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20092 to use a special "type_name_expression" rule which reduces the
20093 number of "QualifiedIdentifier" classes created, and instead
20094 directly creates MemberAccess expressions.
20096 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20098 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20099 that fixes #52853. Null literal assignment to ValueType
20101 * class.cs (MethodData.Emit): Instead of checking the name of the
20102 method to determine if its a destructor, create a new derived
20103 class from Method called Destructor, and test for that.
20105 * cs-parser.jay: Create a Destructor object instead of a Method.
20107 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20111 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20113 * expression.cs (Binary.ResolveOperator): Perform an implicit
20114 conversion from MethodGroups to their delegate types on the
20115 Addition operation.
20117 * delegate.cs: Introduce a new class DelegateCreation that is the
20118 base class for `NewDelegate' and `ImplicitDelegateCreation',
20119 factor some code in here.
20121 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20122 conversion from MethodGroups to compatible delegate types.
20124 * ecore.cs (Expression.Resolve): Do not flag error 654
20125 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20126 we allow conversions from MethodGroups to delegate types now.
20128 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20129 assignments in v2 either.
20131 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20133 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20134 static read-only fields in ctors.
20136 Applied patch from Benjamin Jemlich
20138 * expression.cs (UnaryMutator): Avoid leaking local variables.
20140 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20142 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20143 here to return true, as they can be used like this:
20145 (XXX) int.MEMBER ()
20147 Fixed 49836 and all the other dups
20149 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20151 * driver.cs: Implement /win32res and /win32icon.
20153 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20155 * cs-parser.jay: Add a rule to improve error handling for the
20156 common mistake of placing modifiers after the type.
20158 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20160 * cs-parser.jay (interface_event_declaration): Catch
20161 initialization of events on interfaces, and report cs0068
20163 * cs-parser.jay (interface_event_declaration): Catch
20164 initialization of events.
20166 * ecore.cs: Better report missing constructors.
20168 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20169 the error reporting done in the wrong place. Fix.
20171 * expression.cs (Binary.ResolveOperator): Catch the
20172 operator + (E x, E y) error earlier, and later allow for implicit
20173 conversions in operator +/- (E e, U x) from U to the underlying
20176 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20177 52596, if the container class is abstract, the default constructor
20178 is protected otherwise its public (before, we were always public).
20180 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20183 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20184 Jemlich that fixes bug #52597, MCS was generating invalid code for
20185 idisposable structs. Thanks to Ben for following up with this
20188 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20190 * driver.cs: Allow assemblies without code to be generated, fixes
20193 2004-01-07 Nick Drochak <ndrochak@gol.com>
20195 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20197 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20199 * cs-parser.jay: Add rules to improve error reporting if fields or
20200 methods are declared at the namespace level (error 116)
20202 * Add rules to catch event add/remove
20204 2004-01-04 David Sheldon <dave-mono@earth.li>
20206 * expression.cs: Added matching ")" to error message for
20209 2004-01-03 Todd Berman <tberman@gentoo.org>
20211 * ecore.cs, attribute.cs:
20212 Applying fix from #52429.
20214 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20216 * ecore.cs, expression.cs, statement.cs:
20217 Total rewrite of how we handle branching. We
20218 now handle complex boolean expressions with fewer
20219 jumps. As well if (x == 0) no longer emits a ceq.
20221 if (x is Foo) is much faster now, because we generate
20224 Overall, we get a pretty big improvement on our benchmark
20225 tests. The code we generate is smaller and more readable.
20227 I did a full two-stage bootstrap. The patch was reviewed
20228 by Martin and Miguel.
20230 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20232 * cs-parser.jay: Make primary_expression not take a QI.
20233 we dont need this because the member_access rule covers
20234 us here. So we replace the rule with just IDENTIFIER.
20236 This has two good effects. First, we remove a s/r conflict.
20237 Second, we allocate many fewer QualifiedIdentifier objects.
20239 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20241 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20242 set the correct information via SRE. This prevents
20243 hanging on the MS runtime. Fixes #29374.
20245 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20247 * convert.cs: correctly handle conversions to value types
20248 from Enum and ValueType as unboxing conversions.
20250 Fixes bug #52569. Patch by Benjamin Jemlich.
20252 2004-01-02 Ravi Pratap <ravi@ximian.com>
20254 * expression.cs (BetterConversion): Prefer int -> uint
20255 over int -> ulong (csc's behaviour). This fixed bug #52046.
20257 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20259 * decl.cs (MemberCache.FindMembers): now returns a
20262 * typemanager.cs: In general, go with with ^^.
20263 (CopyNewMethods): take an IList.
20264 (RealMemberLookup): Only allocate an arraylist
20265 if we copy from two sets of methods.
20267 This change basically does two things:
20268 1) Fewer array lists allocated due to CopyNewMethods.
20269 2) the explicit cast in MemberList costed ALOT.
20271 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20273 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20274 a hashtable to avoid needless string allocations when an identifier is
20275 used more than once (the common case).
20277 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20279 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20280 is broken, it will not return anything. So, we
20281 have to use the information we have in mcs to
20284 * typemanager.cs: Add a cache for GetInterfaces,
20285 since this will now be used more often (due to ^^)
20287 (GetExplicitInterfaces) New method that gets the
20288 declared, not effective, interfaces on a type
20289 builder (eg, if you have interface IFoo, interface
20290 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20293 This patch makes MCS able to bootstrap itself on
20296 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20298 * expression.cs: Remove the Nop's that Miguel put
20301 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20303 * report.cs, codegen.cs: Give the real stack trace to
20304 the error when an exception is thrown.
20306 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20308 * decl.cs: only allocate hashtables for ifaces if
20311 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20313 * expression.cs: fix the error from cs0121-2.cs
20314 (a parent interface has two child interfaces that
20315 have a function with the same name and 0 params
20316 and the function is called through the parent).
20318 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20320 * class.cs, rootcontext.cs, typmanager.cs: do not
20323 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20325 * codegen.cs: remove stack for the ec flow branching.
20326 It is already a linked list, so no need.
20328 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20330 * Makefile: Allow custom profiler here.
20332 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20334 * typemanager.cs (LookupType):
20335 - Use a static char [], because split takes
20336 a param array for args, so it was allocating
20338 - Do not store true in a hashtable, it boxes.
20340 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20342 * flowanalysis.cs: bytify common enums.
20344 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20346 * modifiers.cs: Add a new set of flags for the
20347 flags allowed on explicit interface impls.
20348 * cs-parser.jay: catch the use of modifiers in
20349 interfaces correctly.
20350 * class.cs: catch private void IFoo.Blah ().
20352 All related to bug #50572.
20354 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20356 * decl.cs: Rewrite the consistant accessability checking.
20357 Accessability is not linear, it must be implemented in
20358 a tableish way. Fixes #49704.
20360 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20362 * expression.cs: Handle negation in a checked context.
20363 We must use subtraction from zero. Fixes #38674.
20365 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20367 * class.cs: Ignore static void main in DLLs.
20368 * rootcontext.cs: Handle the target type here,
20369 since we are have to access it from class.cs
20370 * driver.cs: account for the above.
20372 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20374 * report.cs: Give line numbers and files if available.
20376 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20378 * driver.cs: Implement /addmodule.
20380 * typemanager.cs: Change 'modules' field so it now contains Modules not
20383 2003-12-20 Martin Baulig <martin@ximian.com>
20385 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20386 (FieldBase.IsAssigned): Removed this field.
20387 (FieldBase.SetAssigned): New public method.
20388 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20390 2003-12-20 Martin Baulig <martin@ximian.com>
20392 * expression.cs (LocalVariableReference.DoResolve): Don't set
20393 `vi.Used' if we're called from DoResolveLValue().
20395 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20396 returns the usage vector it just merged into the current one -
20397 pass this one to UsageWarning().
20398 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20399 of the `EmitContext', don't call this recursively on our children.
20401 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20403 * driver.cs: Implement /target:module.
20405 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20407 * support.cs (CharArrayHashtable): New helper class.
20409 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20410 char arrays, not strings, so we can avoid creating a string in
20411 consume_identifier if the identifier is a keyword.
20413 2003-12-16 Martin Baulig <martin@ximian.com>
20415 * statement.cs (LocalInfo.Assigned): Removed this property.
20416 (LocalInfo.Flags): Removed `Assigned'.
20417 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20418 and uses flow analysis.
20419 (Block.UsageWarning): Made this method private.
20420 (Block.Resolve): Call UsageWarning() if appropriate.
20422 * expression.cs (LocalVariableReference.DoResolve): Always set
20423 LocalInfo.Used here.
20425 2003-12-13 Martin Baulig <martin@ximian.com>
20427 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20428 any value here; we're now using flow analysis to figure out
20429 whether a statement/block returns a value.
20431 2003-12-13 Martin Baulig <martin@ximian.com>
20433 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20435 (FlowBranching.MergeFinally): Don't call
20436 `branching.CheckOutParameters()' here, this is called in
20438 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20439 when adding the `finally' vector.
20441 2003-12-13 Martin Baulig <martin@ximian.com>
20444 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20445 actually work and also fix #48962.
20447 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20449 * decl.cs: Do not check System.Object for nested types,
20450 since we know it does not have any. Big bang for buck:
20453 Run 1: 8.35 seconds
20454 Run 2: 8.32 seconds
20455 corlib: 17.99 seconds
20457 Run 1: 8.17 seconds
20458 Run 2: 8.17 seconds
20459 corlib: 17.39 seconds
20461 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20463 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20464 time we are returning 0 members, so we save alot here.
20466 2003-12-11 Martin Baulig <martin@ximian.com>
20468 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20469 `MergeChild()', also just take the `FlowBranching' as argument;
20470 call Merge() on it and return the result.
20471 (FlowBranching.Merge): We don't need to do anything if we just
20474 2003-12-11 Martin Baulig <martin@ximian.com>
20476 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20477 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20478 Maurer for this idea.
20480 2003-12-11 Martin Baulig <martin@ximian.com>
20482 * flowanalysis.cs (MergeResult): This class is now gone; we now
20483 use the `UsageVector' for this. The reason for this is that if a
20484 branching just has one sibling, we don't need to "merge" them at
20485 all - that's the next step to do.
20486 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20489 2003-12-11 Martin Baulig <martin@ximian.com>
20491 Reworked flow analyis and made it more precise and bug-free. The
20492 most important change is that we're now using a special `Reachability'
20493 class instead of having "magic" meanings of `FlowReturns'. I'll
20494 do some more cleanups and optimizations and also add some more
20495 documentation this week.
20497 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20498 largely reworked this class.
20499 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20500 the new `Reachability' class instead of having "magic" values here.
20501 (FlowBranching): We're now using an instance of `Reachability'
20502 instead of having separate `Returns', `Breaks' etc. fields.
20504 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20505 based on flow analysis; ignore the return value of block.Emit ().
20507 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20509 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20510 if they are private.
20512 2003-12-09 Martin Baulig <martin@ximian.com>
20514 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20515 call them directly on the UsageVector.
20517 2003-12-09 Martin Baulig <martin@ximian.com>
20519 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20520 Changed return type from `FlowReturns' to `Reachability'.
20522 2003-12-09 Martin Baulig <martin@ximian.com>
20524 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20525 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20526 `Reachable' fields with a single `Reachability' one.
20528 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20530 * class.cs (FindMembers): Remove foreach's.
20535 Run 1: 8.74 seconds
20536 Run 2: 8.71 seconds
20539 Run 1: 8.64 seconds
20540 Run 2: 8.58 seconds
20543 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20548 This patch does a few things:
20549 1. EmptyStatement is now a singleton, so it is never reallocated.
20550 2. All blah is EmptyStatement constructs have been changed to
20551 blah == EmptyStatement.Value, which is much faster and valid
20552 now that EmptyStatement is a singleton.
20553 3. When resolving a block, rather than allocating a new array for
20554 the non-empty statements, empty statements are replaced with
20555 EmptyStatement.Value
20556 4. Some recursive functions have been made non-recursive.
20557 Mainly the performance impact is from (3), however (1) and (2) are needed for
20558 this to work. (4) does not make a big difference in normal situations, however
20559 it makes the profile look saner.
20564 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20565 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20566 Total memory allocated: 56397 KB
20569 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20570 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20571 Total memory allocated: 55666 KB
20573 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20575 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20576 than the hashtable in a hashtable version
20578 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20579 we always end up concating a string. This results in a huge perf
20580 loss, because many strings have to be tracked by the GC. In this
20581 patch, we first use a hashtable that works with two keys, so that
20582 the strings do not need to be concat'ed.
20586 Run 1: 8.74 seconds
20587 Run 2: 8.71 seconds
20590 Run 1: 8.65 seconds
20591 Run 2: 8.56 seconds
20593 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20595 * Makefile: Add a new target `do-time' that does a quick and simple
20596 profile, leaving easy to parse output.
20598 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20600 * codegen.cs (Init): Create the dynamic assembly with
20601 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20603 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20605 * support.cs: Make the PtrHashtable use only one
20606 instance of its comparer.
20608 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20610 * typemanager.cs: Fix lookup of GetNamespaces.
20612 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20614 * expression.cs: Removed redundant line.
20616 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20617 ArrayLists, use for loops with bounds.
20619 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20622 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20623 arraylists, use for loop with bounds.
20625 The above three changes give us a 0.071 second performance
20626 improvement out of 3.294 seconds down to 3.223. On my machine
20627 the above changes reduced the memory usage by 1,387 KB during
20628 compiler bootstrap.
20630 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20631 QualifiedIdentifiers. Before we created a new string through
20632 concatenation, and mostly later on, the result would be
20633 manipulated by DecomposeQI through string manipulation.
20635 This reduced the compiler memory usage for bootstrapping from
20636 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20637 compile times in 0.05 seconds.
20639 2003-11-28 Dick Porter <dick@ximian.com>
20641 * support.cs: Do string compares with the Invariant culture.
20649 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20650 the comparison is done with the Invariant culture.
20652 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20654 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20655 GetEnumerator method.
20657 (ProbeCollectionType): Iterate starting at the most specific type
20658 upwards looking for a GetEnumerator
20660 * expression.cs: Shift count can be up to 31 for int/uint and 63
20663 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20665 * statement.cs (Block.LookupLabel): Also look for the label on the
20666 children blocks. Use a hash table to keep track of visited
20669 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20670 we actually did transform the other operand, otherwise fall back
20671 to the common codepath that casts to long.
20673 * cs-tokenizer.cs: Use the same code pattern as the int case.
20674 Maybe I should do the parsing myself, and avoid depending on the
20675 Parse routines to get this done.
20677 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20679 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20680 which fixes bug 51347. This time test it.
20682 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20683 attributes for example can not tell the difference between these.
20684 The difference was only a syntax feature of the language.
20686 * attribute.cs: Apply attributes to delegates.
20688 * delegate.cs: Call the apply attributes method.
20690 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20692 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20693 comparing 0 vs Byte.MinValue, not the value
20695 (ImplicitConversionRequired): When reporting a conversion error,
20696 use error 31 to print out the constant error instead of the
20699 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20700 which fixes bug 51347.
20702 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20704 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20705 which fixes the -warnaserror command line option.
20707 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20709 * cfold.cs (DoNumericPromotions): During constant folding of
20710 additions on UIntConstant, special case intconstants with
20711 IntConstants like we do on the expression binary operator.
20713 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20715 * convert.cs (ImplicitReferenceConversion): We were missing a case
20716 (System.Enum are not value types or class types, so we need to
20717 classify them separatedly).
20719 * driver.cs: We do not support error 2007.
20721 2003-11-12 Jackson Harper <jackson@ximian.com>
20723 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20724 system directory. Also use the full file name so users can
20725 libraries names mscorlib-o-tron.dll in a non system dir.
20727 2003-11-10 Martin Baulig <martin@ximian.com>
20729 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20730 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20731 calling `ResolveType()' on them, directly assign their `Type'.
20733 2003-11-08 Martin Baulig <martin@ximian.com>
20735 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20736 return value and the `out parent' parameter.
20737 (TypeContainer.DefineType): Moved the CS0644 check into
20738 GetClassBases(). Don't pass the interface types to the
20739 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20740 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20742 * ecore.cs (TypeExpr.IsAttribute): New property.
20743 (TypeExpr.GetInterfaces): New method.
20745 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20746 TypeExpr instead of a Type.
20747 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20748 (Interface.DefineType): Don't pass the interface types to the
20749 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20750 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20752 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20753 instead of a `Type[]'.
20754 (TypeManager.RegisterBuilder): Likewise.
20755 (TypeManager.AddUserInterface): Likewise.
20756 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20757 `Type[]' and also return a `TypeExpr[]'.
20758 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20760 2003-11-08 Martin Baulig <martin@ximian.com>
20762 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20765 2003-11-08 Martin Baulig <martin@ximian.com>
20767 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20768 TypeManager.ResolveExpressionTypes().
20770 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20771 instead of an Expression.
20772 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20773 (TypeExpression): New public class; formerly known as `TypeExpr'.
20775 * expression.cs (ComposedCast): Derive from TypeExpr.
20777 * typemanager.cs (TypeManager.system_*_expr): These are now
20778 TypExpr's instead of Expression's.
20779 (TypeManager.ResolveExpressionTypes): New public static function;
20780 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20783 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20785 * expression.cs (New.DoResolve): Do not dereference value that
20786 might be a null return.
20788 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20789 sure that the constant value has the right type. Fixes an
20790 unreported bug, similar to 50425.
20792 * const.cs (Const.LookupConstantValue): Call
20793 ImplicitStandardConversionExists before doing a conversion to
20794 avoid havng the TypeManager.ChangeType do conversions.
20796 Reduced the number of casts used
20798 (Const.ChangeType): New routine to enable reuse of the constant
20799 type changing code from statement.
20801 * typemanager.cs (ChangeType): Move common initialization to
20802 static global variables.
20806 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20807 every value type to go through, even if it was void. Fix that.
20809 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20810 character of the define, and the is_identifier_part_character for
20811 the rest of the string.
20813 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20815 * expression.cs (UnaryMutator.EmitCode): When I updated
20816 LocalVariableReference.DoResolve, I overdid it, and dropped an
20817 optimization done on local variable references.
20819 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20821 * ecore.cs: Convert the return from Ldlen into an int.
20823 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20825 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20826 the accessibility, this is a special case for toplevel non-public
20827 classes (internal for instance).
20829 2003-10-20 Nick Drochak <ndrochak@gol.com>
20831 * ecore.cs: Fix typo and build. Needed another right paren.
20833 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20835 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20836 `internal' case regular and protected, but not allowing protected
20837 to be evaluated later. Bug 49840
20839 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20841 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20842 to kb.Nlast, and not the kb.nFirst to isolate the switch
20845 Extract the underlying type, so enumerations of long/ulong are
20846 treated like long/ulong.
20848 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20850 * expression.cs (New): Overload the meaning of RequestedType to
20851 track the possible creation of the NewDelegate type, since
20852 DoResolve is invoked more than once for new constructors on field
20855 See bugs: #48800 and #37014
20857 * cs-parser.jay (declare_local_constants): Take an arraylist
20858 instead of a single constant.
20860 (local_constant_declaration): It should take a
20861 constant_declarators, not a constant_declarator. Fixes 49487
20863 * convert.cs: Fix error report.
20865 2003-10-13 Jackson Harper <jackson@ximian.com>
20867 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20870 2003-10-09 Martin Baulig <martin@ximian.com>
20872 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20874 (MethodCore.DoDefineParameters): Removed the TypeContainer
20875 argument; use the DeclSpace which was passed to the .ctor instead.
20876 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20877 TypeContainer; we only need a DeclSpace here.
20879 2003-10-09 Martin Baulig <martin@ximian.com>
20881 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20883 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20884 EmitContext's .ctor.
20886 2003-10-09 Martin Baulig <martin@ximian.com>
20888 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20889 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20890 AsAccessible(), moved them as well.
20892 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20894 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20896 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20898 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20900 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20901 generation for >=, as spotted by Paolo, bug 48679.
20902 Patch from David Waite.
20904 * cs-tokenizer.cs: Add handling for #pragma.
20906 * cs-parser.jay: Allow for both yield and yield return in the
20907 syntax. The anti-cobolization of C# fight will go on!
20909 * class.cs (TypeBuilder.DefineType): Catch error condition here
20910 (Parent.DefineType erroring out and returning null).
20912 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20913 coping with enumerations variables, we were mistakenly processing
20914 them as a regular value type instead of built-in types. Fixes the
20917 * typemanager.cs (IsBuiltinOrEnum): New method.
20919 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20921 * cs-parser.jay: Upgrade: yield now needs the return clause.
20923 2003-09-19 Martin Baulig <martin@ximian.com>
20925 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20926 `MemberCache parent' argument. Normally, an interface doesn't
20927 have a parent type except System.Object, but we use this in gmcs
20928 for generic type parameters.
20930 2003-09-18 Martin Baulig <martin@ximian.com>
20932 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20933 on `type.IsInterface'; don't check whether the type has a parent
20934 to determine whether it's an interface.
20936 2003-09-15 Martin Baulig <martin@ximian.com>
20938 * class.cs (TypeContainer.DefineType): Added an error flag to
20939 avoid reporting duplicate CS0146's ("class definition is
20942 * driver.cs (Driver.MainDriver): Abort if
20943 RootContext.ResolveTree() reported any errors.
20945 2003-09-07 Martin Baulig <martin@ximian.com>
20947 * report.cs (Error, Warning): Added overloaded versions which take
20948 a `params object[] args' and call String.Format().
20950 2003-09-07 Martin Baulig <martin@ximian.com>
20952 * decl.cs (DeclSpace..ctor): Don't call
20953 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20954 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20955 (DeclSpace.RecordDecl): New method.
20957 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20959 2003-09-02 Ravi Pratap <ravi@ximian.com>
20961 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20962 value attributes to be applied to ParameterBuilders.
20964 * class.cs (MethodCore.LabelParameters): Make static and more
20965 generic so that it can be used from other places - like interface
20966 methods, for instance.
20968 * interface.cs (Interface.Emit): Call LabelParameters before
20969 emitting attributes on the InterfaceMethod.
20971 2003-08-26 Martin Baulig <martin@ximian.com>
20973 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20974 resolving aliases; fixes #47927.
20976 2003-08-26 Martin Baulig <martin@ximian.com>
20978 * statement.cs (Using.DoResolve): This is internally emitting a
20979 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20980 do not always return. Fixes #47681.
20982 2003-08-26 Martin Baulig <martin@ximian.com>
20984 * decl.cs (MemberCore): Moved WarningNotHiding(),
20985 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20987 (AdditionResult): Make this nested in DeclSpace.
20988 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20989 argument; call NamespaceEntry.Define() unless we're nested in a
20992 * namespace.cs (Namespace.DefineName): New public function. This
20993 is called from DeclSpace's .ctor to add
20994 (Namespace.Lookup): Include DeclSpaces in the lookup.
20996 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20998 * const.cs (Const): Derive from MemberBase, not MemberCore.
21000 2003-08-25 Martin Baulig <martin@ximian.com>
21002 * convert.cs (Convert.ExplicitReferenceConversion): When
21003 converting from an interface type to a class, unbox if the target
21004 type is a struct type. Fixes #47822.
21006 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21008 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21011 2003-08-22 Martin Baulig <martin@ximian.com>
21013 * class.cs (TypeManager.DefineType): When defining a nested type,
21014 call DefineType() on our parent; fixes #47801.
21016 2003-08-22 Martin Baulig <martin@ximian.com>
21018 * class.cs (MethodData.Define): While checking if a method is an
21019 interface implementation, improve the test a bit more to fix #47654.
21021 2003-08-22 Martin Baulig <martin@ximian.com>
21023 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21024 correctly; fixes #47722.
21026 2003-08-22 Martin Baulig <martin@ximian.com>
21028 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21029 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21031 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21033 2003-08-22 Martin Baulig <martin@ximian.com>
21035 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21036 can only be assigned in static constructors. Fixes #47161.
21038 2003-08-22 Martin Baulig <martin@ximian.com>
21040 Rewrote and improved the flow analysis code.
21042 * flowbranching.cs (FlowBranching): Make this class abstract.
21043 (FlowBranching.CreateBranching): New static function to create a
21044 new flow branching.
21045 (FlowBranchingBlock, FlowBranchingException): New classes.
21046 (FlowBranching.UsageVector.Type): New public readonly field.
21047 (FlowBranching.UsageVector.Breaks): Removed the setter.
21048 (FlowBranching.UsageVector.Returns): Removed the setter.
21049 (FlowBranching.UsageVector): Added Break(), Return(),
21050 NeverReachable() and Throw() methods to modify the reachability.
21051 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21052 done by FlowBranching.Merge().
21053 (FlowBranching.UsageVector.MergeChild): New method; merges the
21054 merge result into the current vector.
21055 (FlowBranching.Merge): New abstract method to merge a branching.
21057 2003-08-12 Martin Baulig <martin@ximian.com>
21059 * expression.cs (Indirection.CacheTemporaries): Create the
21060 LocalTemporary with the pointer type, not its element type.
21062 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21064 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21065 token was a keyword or not.
21067 Add `error' options where an IDENTIFIER was expected; Provide
21068 CheckToken and CheckIdentifierToken convenience error reporting
21071 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21073 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21074 NameSpaceEntry NameSpaceEntry.
21076 (LookupInterfaceOrClass): Avoid creating a full qualified name
21077 from namespace and name: avoid doing lookups when we know the
21078 namespace is non-existant. Use new Tree.LookupByNamespace which
21079 looks up DeclSpaces based on their namespace, name pair.
21081 * driver.cs: Provide a new `parser verbose' to display the
21082 exception thrown during parsing. This is turned off by default
21083 now, so the output of a failure from mcs is more graceful.
21085 * namespace.cs: Track all the namespaces defined in a hashtable
21088 (IsNamespace): New method
21090 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21092 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21093 we know that we need to concatenate (full typename can never be
21098 * statement.cs: Use a bitfield; Do not initialize to null things
21099 which are done by the constructor by default.
21101 * cs-parser.jay: bug fix, parameter was 4, not 3.
21103 * expression.cs: Just use the property;
21105 * statement.cs: No need for GetVariableInfo method.
21107 2003-08-08 Martin Baulig <martin@ximian.com>
21109 * flowanalysis.cs (FlowReturns): This is now nested in the
21110 `FlowBranching' class.
21111 (MyBitVector): Moved this here from statement.cs.
21112 (FlowBranching.SiblingType): New enum type.
21113 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21115 2003-08-07 Martin Baulig <martin@ximian.com>
21117 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21118 `FlowBranching' class and called `BranchingType'.
21120 2003-08-07 Martin Baulig <martin@ximian.com>
21122 * flowanalysis.cs: Moved all the control flow analysis code into
21125 2003-08-07 Martin Baulig <martin@ximian.com>
21127 * assign.cs (Assign.DoResolve): `target' must either be an
21128 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21131 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21133 * expression.cs (BinaryMethod): This kind of expression is created by the
21134 Binary class if it determines that the operator has to be handled
21137 (BinaryDelegate): This kind of expression is created if we are
21138 dealing with a + or - operator on delegates.
21140 (Binary): remove method, argumetns, and DelegateOperator: when
21141 dealing with methods,
21143 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21145 * statement.cs (Block): use bitfields for the three extra booleans
21146 we had in use. Remove unused topblock parameter.
21148 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21150 * assign.cs: Drop extra unneeded tests.
21152 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21154 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21156 * statement.cs (Foreach): Use VariableStorage instead of
21159 * codegen.cs (VariableStorage): New class used by clients that
21160 require a variable stored: locals or fields for variables that
21161 need to live across yield.
21163 Maybe provide a convenience api for EmitThis+EmitLoad?
21165 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21168 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21170 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21171 RemapParameterLValue): New methods that are used to turn a
21172 precomputed FieldInfo into an expression like this:
21176 The idea is to use this instead of making LocalVariableReference
21177 have more than one meaning.
21179 * cs-parser.jay: Add error production to BASE.
21181 * ecore.cs: Deal with TypeManager.GetField returning null, which
21182 is now a valid return value.
21184 (FieldExprNoAddress): New expression for Fields whose address can
21187 * expression.cs (LocalVariableReference): During the resolve
21188 phases, create new expressions if we are in a remapping context.
21189 Remove code that dealt with remapping here.
21191 (ParameterReference): same.
21193 (ProxyInstance): New expression, like the `This' expression, but
21194 it is born fully resolved. We know what we are doing, so remove
21195 the errors that are targeted to user-provided uses of `this'.
21197 * statement.cs (Foreach): our variable is now stored as an
21198 Expression; During resolution, follow the protocol, dont just
21199 assume it will return this.
21201 2003-08-06 Martin Baulig <martin@ximian.com>
21203 * support.cs (SeekableStreamReader.cs): New public class.
21205 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21206 SeekableStreamReader instead of the normal StreamReader.
21208 2003-08-04 Martin Baulig <martin@ximian.com>
21210 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21211 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21212 deambiguate casts and delegate invocations.
21213 (parenthesized_expression): Use the new tokens to ensure this is
21214 not a cast of method invocation.
21216 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21217 when reading a `)' and Deambiguate_CloseParens () was previously
21220 * expression.cs (ParenthesizedExpression): New class. This is
21221 just used for the CS0075 test.
21222 (Binary.DoResolve): Check for CS0075.
21224 2003-07-29 Ravi Pratap <ravi@ximian.com>
21226 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21227 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21228 reference comparison.
21230 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21231 examine the ReturnType for equality - this is necessary in the
21232 cases of implicit and explicit operators whose signature also
21233 includes the return type.
21235 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21237 * namespace.cs: Cache the result of the namespace computation,
21238 instead of computing it every time.
21240 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21242 * decl.cs: Use a global arraylist that we reuse over invocations
21243 to avoid excesive memory consumption. Reduces memory usage on an
21244 mcs compile by one meg (45 average).
21246 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21247 private, work around that.
21249 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21251 * literal.cs (IntLiteral): Define Zero and One static literals.
21253 * cs-parser.jay (integer_literal): use static literals to reduce
21254 memory usage for the most used literals (0, 1 and -1). 211kb
21255 reduced in memory usage.
21257 Replace all calls to `new ArrayList' with `new
21258 ArrayList(4)' which is a good average number for most allocations,
21259 and also requires only 16 bytes of memory for its buffer by
21262 This reduced MCS memory usage in seven megabytes for the RSS after
21265 2003-07-28 Ravi Pratap <ravi@ximian.com>
21267 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21268 handle params methods the correct way by forming only one
21269 applicable set with params and normal methods in them. Earlier we
21270 were looking at params methods only if we found no normal methods
21271 which was not the correct thing to do.
21273 (Invocation.BetterFunction): Take separate arguments indicating
21274 when candidate and the best method are params methods in their
21277 This fixes bugs #43367 and #46199.
21279 * attribute.cs: Documentation updates.
21281 (CheckAttribute): Rename to CheckAttributeTarget.
21282 (GetValidPlaces): Rename to GetValidTargets.
21284 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21285 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21289 2003-07-28 Martin Baulig <martin@ximian.com>
21291 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21292 name when looking up the base class of a nested class. Fixes #46977.
21294 2003-07-26 Martin Baulig <martin@ximian.com>
21296 * expression.cs (Indexers.Indexer): New nested struct; contains
21297 getter, setter and the indexer's type.
21298 (Indexers.Properties): This is now an ArrayList of
21299 Indexers.Indexer's.
21300 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21301 indexer doesn't have any getters.
21303 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21304 for embedded property and indexer assignments.
21306 2003-07-26 Martin Baulig <martin@ximian.com>
21308 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21309 preprocessor directive is not the first non-whitespace character
21312 2003-07-26 Martin Baulig <martin@ximian.com>
21314 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21315 namespace parsing, follow the spec more closely.
21317 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21318 NamespaceEntry.Lookup().
21320 2003-07-25 Martin Baulig <martin@ximian.com>
21322 * MethodCore.cs (OverridesSomething): New public field; it's set
21323 from TypeContainer.DefineMembers if this method overrides
21324 something (which doesn't need to be a method). Fix #39462.
21326 2003-07-25 Ravi Pratap <ravi@ximian.com>
21328 * typemanager.cs (GetMembers): Ensure that the list of members is
21329 reversed. This keeps things in sync.
21331 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21332 find an AttributeUsage attribute.
21334 * expression.cs (Invocation.OverloadResolve): Perform the check
21335 which disallows Invoke to be directly called on a Delegate.
21337 (Error_InvokeOnDelegate): Report error cs1533.
21339 2003-07-25 Martin Baulig <martin@ximian.com>
21341 * expression.cs (Indexers.GetIndexersForType): Only look in the
21342 interface hierarchy if the requested type is already an
21343 interface. Fixes #46788 while keeping #46502 fixed.
21345 2003-07-25 Martin Baulig <martin@ximian.com>
21347 * class.cs (TypeContainer.DefineMembers): Check whether all
21348 readonly fields have been assigned and report warning CS0649 if
21351 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21354 2003-07-24 Ravi Pratap <ravi@ximian.com>
21356 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21357 returned from GetMethods to make things consistent with the
21358 assumptions MCS makes about ordering of methods.
21360 This should comprehensively fix bug #45127 and it does :-)
21362 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21363 ordering is actually reverse.
21365 * Clean up some debug messages I left lying around.
21367 * interface.cs (Populate*): Get rid of code which emits attributes
21368 since the stage in which we emit attributes is the 'Emit' stage,
21369 not the define stage.
21371 (Emit): Move attribute emission for interface members here.
21373 2003-07-22 Ravi Pratap <ravi@ximian.com>
21375 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21376 closely: we eliminate methods in base types when we have an
21377 applicable method in a top-level type.
21379 Please see section 14.5.5.1 for an exact description of what goes
21382 This fixes bug #45127 and a host of other related to corlib compilation.
21384 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21385 array is the method corresponding to the top-level type (this is
21386 because of the changes made to icall.c) so we change this
21389 (MethodGroupExpr.Name): This too.
21391 * typemanager.cs (GetElementType): New method which does the right
21392 thing when compiling corlib.
21394 * everywhere: Make use of the above in the relevant places.
21396 2003-07-22 Martin Baulig <martin@ximian.com>
21398 * cs-parser.jay (invocation_expression): Moved
21399 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21400 `cast_expression', but create a InvocationOrCast which later
21401 resolves to either an Invocation or a Cast.
21403 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21404 method; call this before EmitStatement() to make sure that this
21405 expression can be used as a statement.
21407 * expression.cs (InvocationOrCast): New class; resolves to either
21408 an Invocation or a Cast.
21410 * statement.cs (StatementExpression): Call ResolveStatement() on
21411 the ExpressionStatement before emitting it.
21413 2003-07-21 Martin Baulig <martin@ximian.com>
21415 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21416 `ref' and `out' attributes match; fixes #46220.
21417 (MemberAccess.ResolveMemberAccess): You can't reference a type
21418 through an expression; fixes #33180.
21419 (Indexers.GetIndexersForType): Don't return the indexers from
21420 interfaces the class implements; fixes #46502.
21422 2003-07-21 Martin Baulig <martin@ximian.com>
21424 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21425 CS0661 checks; fixes bug #30442.
21427 2003-07-21 Martin Baulig <martin@ximian.com>
21429 * decl.cs (AdditionResult): Added `Error'.
21431 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21433 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21434 makes cs0031.cs actually work.
21436 2003-07-20 Martin Baulig <martin@ximian.com>
21438 * namespace.cs: Fixed that bug which caused a crash when compiling
21439 the debugger's GUI.
21441 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21443 * typemanager.cs (LookupTypeReflection): Never expose types which
21444 are NotPublic, NestedPrivate, NestedAssembly, or
21445 NestedFamANDAssem. We used to return these, and later do a check
21446 that would report a meaningful error, but the problem is that we
21447 would not get the real match, if there was a name override.
21449 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21451 * namespace.cs (Namespace, Name): Do not compute the namespace
21452 name dynamically, compute it in the constructor. This reduced
21453 memory usage by 1697 KB.
21455 * driver.cs: Use --pause to pause at the end.
21457 2003-07-17 Peter Williams <peter@newton.cx>
21459 * Makefile: Change the name of the test target so that it doesn't
21460 conflict with the recursive test target.
21462 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21464 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21465 AddressOf): Do not use EmitThis, that was wrong, use the actual
21468 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21470 * class.cs (MethodData.Define): While checking if a method is an
21471 interface implementation, improve the test: If we are not public
21472 (use new test here: use the computed MethodAttributes directly,
21473 instead of the parsed modifier flags) check if the `implementing'
21474 method comes from an interface or not.
21476 * pending.cs (VerifyPendingMethods): Slightly better error
21479 * makefile: add test target that does the mcs bootstrap.
21481 2003-07-16 Ravi Pratap <ravi@ximian.com>
21483 * interface.cs (Define): Do nothing here since there are no
21484 members to populate etc. Move the attribute emission out of here
21485 since this was just totally the wrong place to put it. Attribute
21486 application happens during the 'Emit' phase, not in the 'Define'
21489 (Emit): Add this method and move the attribute emission here
21491 * rootcontext.cs (EmitCode): Call the Emit method on interface
21494 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21496 * expression.cs (OverloadResolve): Report error only if Location
21497 is not 'Null' which means that there was a probe going on.
21499 2003-07-14 Martin Baulig <martin@ximian.com>
21501 * expression.cs (ConditionalLogicalOperator): New public class to
21502 implement user defined conditional logical operators.
21503 This is section 14.11.2 in the spec and bug #40505.
21505 2003-07-14 Martin Baulig <martin@ximian.com>
21507 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21509 2003-07-14 Martin Baulig <martin@ximian.com>
21511 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21513 * ecore.cs (IVariable.VerifyFixed): New interface method.
21515 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21516 operator, check whether the variable is actually fixed. Fixes bug
21517 #36055. Set a variable definitely assigned when taking its
21518 address as required by the spec.
21520 * statement.cs (LocalInfo.IsFixed): New field.
21521 (LocalInfo.MakePinned): Set `IsFixed' to true.
21523 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21525 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21526 for .ctors, ensure that we only ask for members declared in the
21527 attribute type (BindingFlags.DeclaredOnly).
21531 * expression.cs (Error_WrongNumArguments): Report error 1501
21532 correctly the way CSC does.
21534 2003-07-13 Martin Baulig <martin@ximian.com>
21536 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21537 lookup on the fully qualified name, to make things like "X.X" work
21538 where "X.X" is a fully qualified type name, but we also have a
21539 namespace "X" in the using list. Fixes #41975.
21541 2003-07-13 Martin Baulig <martin@ximian.com>
21543 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21544 function. If we're a CompoundAssign, we need to create an embedded
21545 CompoundAssign, not an embedded Assign.
21546 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21549 2003-07-13 Martin Baulig <martin@ximian.com>
21551 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21552 work to fix bug #46088.
21554 2003-07-13 Ravi Pratap <ravi@ximian.com>
21556 * class.cs (Operator.Emit): Do not emit attributes here - it is
21557 taken care of by the Method class that we delegate too. This takes
21558 care of bug #45876.
21560 2003-07-10 Martin Baulig <martin@ximian.com>
21562 * expression.cs (TypeOfVoid): New class.
21563 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21565 2003-07-10 Martin Baulig <martin@ximian.com>
21567 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21570 2003-07-10 Martin Baulig <martin@ximian.com>
21572 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21573 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21575 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21577 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21579 2003-07-10 Martin Baulig <martin@ximian.com>
21581 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21582 of decimal. Fixes #42850.
21584 NOTE: I also fixed the created byte blob, but this doesn't work on
21585 the MS runtime and csc never produces any byte blobs for decimal
21588 2003-07-10 Martin Baulig <martin@ximian.com>
21590 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21591 structs; fixes #32068.
21592 (Block.AddChildVariableNames): Fixed #44302.
21594 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21596 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21598 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21600 * attribute.cs: And this test is onger needed.
21602 2003-07-08 Martin Baulig <martin@ximian.com>
21604 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21605 inaccessible types. Fixes #36313.
21607 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21609 * namespace.cs (NamespaceEntry): Create implicit entries for all
21610 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21611 implicit entries for N1.N2 and N1.
21613 2003-07-08 Martin Baulig <martin@ximian.com>
21615 Rewrote the handling of namespaces to fix a lot of the issues
21616 wrt. `using' aliases etc.
21618 * namespace.cs (Namespace): Splitted this class into a
21619 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21621 * typemanager.cs (TypeManager.IsNamespace): Removed.
21622 (TypeManager.ComputeNamespaces): Only compute namespaces from
21623 loaded assemblies here, not the namespaces from the assembly we're
21624 currently compiling.
21626 2003-07-08 Martin Baulig <martin@ximian.com>
21628 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21630 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21632 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21635 I thought about the memory savings here, but LookupTypeReflection
21636 is used under already very constrained scenarios. Compiling
21637 corlib or mcs only exposes one hit, so it would not really reduce
21638 any memory consumption.
21640 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21642 * typemanager.cs: fixes bug #45889 by only adding public types from
21643 other assemblies to the list of known types.
21645 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21647 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21648 on the type we resolved.
21650 2003-07-05 Martin Baulig <martin@ximian.com>
21652 * pending.cs (PendingImplementation.ParentImplements): Don't
21653 create the proxy if the parent is abstract.
21655 * class.cs (TypeContainer.DefineIndexers): Process explicit
21656 interface implementations first. Fixes #37714.
21658 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21660 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21661 defined recursively; but since we modify the input parameters
21662 (left is set to `this' temporarily), we reset this value if the
21663 left_is_explicit is false, which gives the original semantics to
21666 * literal.cs (NullPointer): new class used to represent a null
21667 literal in a pointer context.
21669 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21670 type is a pointer, use a NullPointer object instead of a
21671 NullLiteral. Closes 43687
21673 (ExplicitConversion): Convert pointer values using
21674 the conv opcode to the proper type.
21676 * ecore.cs (New): change ValueTypeVariable property into a method,
21677 that returns whether the valuetype is suitable for being used.
21679 * expression.cs (Binary.DoNumericPromotions): Only return if we
21680 the int constant was a valid uint, and we can return both left and
21681 right as uints. If not, we continue processing, to trigger the
21682 type conversion. This fixes 39018.
21684 * statement.cs (Block.EmitMeta): During constant resolution, set
21685 the CurrentBlock property on the emitcontext, so that we resolve
21686 constants propertly.
21688 2003-07-02 Martin Baulig <martin@ximian.com>
21690 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21691 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21693 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21694 than emitting it here.
21696 * statement.cs: Fixed some more flow analysis bugs.
21698 2003-07-02 Martin Baulig <martin@ximian.com>
21700 * class.cs (MethodData.Define): When implementing interface
21701 methods, set Final unless we're Virtual.
21703 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21704 check work for interface methods.
21706 2003-07-01 Martin Baulig <martin@ximian.com>
21708 * ecore.cs (EmitContext.This): Replaced this property with a
21709 GetThis() method which takes a Location argument. This ensures
21710 that we get the correct error location for a CS0188.
21712 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21714 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21715 ImplicitStandardConversion.
21717 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21719 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21721 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21724 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21726 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21729 (MethodData.Define): Turn off initlocals for unsafe methods.
21731 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21733 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21734 complete; Fixes #37521.
21736 * delegate.cs: Use Modifiers.TypeAttr to compute the
21737 TypeAttributes, instead of rolling our own. This makes the flags
21738 correct for the delegates.
21740 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21742 * class.cs (Constructor.Define): Set the private flag for static
21743 constructors as well.
21745 * cs-parser.jay (statement_expression): Set the return value to
21746 null, to avoid a crash when we catch an error.
21748 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21750 * cs-parser.jay: Applied patch from Jackson that adds support for
21751 extern and unsafe modifiers to destructor declarations.
21753 * expression.cs: Report error 21 if the user is trying to index a
21756 * driver.cs: Add an error message, suggested by the bug report.
21758 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21759 if we do not have a ": this ()" constructor initializer. Fixes 45149
21761 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21763 * namespace.cs: Add some information to reduce FAQs.
21765 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21767 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21768 underlying enumeration types. Fixes #43915.
21770 * expression.cs: Treat ushort/short as legal values to be used in
21771 bitwise operations.
21773 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21775 * delegate.cs: transfer custom attributes for paramenters from
21776 the delegate declaration to Invoke and BeginInvoke.
21778 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21780 * attribute.cs: handle custom marshalers and emit marshal info
21783 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21785 * makefile.gnu: Added anonymous.cs to the compiler sources.
21787 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21789 * iterators.cs: Change the name of the proxy class to include two
21792 * cs-parser.jay: Update grammar to include anonymous methods.
21794 * anonymous.cs: new file.
21796 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21798 * class.cs (Field.Define): Add missing test for pointers and
21801 2003-05-27 Ravi Pratap <ravi@ximian.com>
21803 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21804 we use the stobj opcode.
21806 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21807 since it wasn't the correct fix.
21809 It still is puzzling that we are required to use stobj for IntPtr
21810 which seems to be a ValueType.
21812 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21814 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21815 during regular simple name resolution. Now, the trick is that
21816 instead of returning for processing the simplename, we do a
21817 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21818 contextual lookup type). If a match is found, return that, if
21819 not, return for further composition.
21821 This fixes long-standing 30485.
21823 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21824 using the address to initialize an object, do an Stobj instead of
21825 using the regular Stelem.
21827 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21828 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21829 Because if we are a BaseIndexerAccess that value will be true.
21832 * statement.cs (GotoCase.Resolve): Return after reporting an
21833 error, do not attempt to continue.
21835 * expression.cs (PointerArithmetic.Emit): If our operand is a
21836 long, convert our constants to match the operand before
21837 multiplying. Convert to I type before adding. Fixes 43670.
21839 2003-05-14 Ravi Pratap <ravi@ximian.com>
21841 * enum.cs (ImplicitConversionExists) : Rename to
21842 ImplicitEnumConversionExists to remove ambiguity.
21844 * ecore.cs (NullCast): New type of cast expression class which
21845 basically is very similar to EmptyCast with the difference being
21846 it still is a constant since it is used only to cast a null to
21848 (eg. (string) null)
21850 * convert.cs (ImplicitReferenceConversion): When casting a null
21851 literal, we return a NullCast.
21853 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21854 should be around anymore.
21856 The renaming (reported was slightly wrong). Corrections:
21858 ConvertImplicitStandard -> ImplicitConversionStandard
21859 ConvertExplicitStandard -> ExplicitConversionStandard
21861 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21862 before passing them in !
21864 * convert.cs (ImplicitConversionStandard): When comparing for
21865 equal expr and target types, ensure that expr is not a
21868 In general, we must not be checking (expr_type ==
21869 target_type) in the top level conversion methods
21870 (ImplicitConversion, ExplicitConversion etc). This checking is
21871 done in the methods that they delegate to.
21873 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21875 * convert.cs: Move Error_CannotConvertType,
21876 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21877 ImplicitNumericConversion, ImplicitConversionExists,
21878 ImplicitUserConversionExists, StandardConversionExists,
21879 FindMostEncompassedType, FindMostSpecificSource,
21880 FindMostSpecificTarget, ImplicitUserConversion,
21881 ExplicitUserConversion, GetConversionOperators,
21882 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21883 TryImplicitIntConversion, Error_CannotConvertImplicit,
21884 ConvertImplicitRequired, ConvertNumericExplicit,
21885 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21886 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21889 Perform the following renames:
21891 StandardConversionExists -> ImplicitStandardConversionExists
21892 ConvertImplicit -> ImplicitConversion
21893 ConvertImplicitStandard -> ImplicitStandardConversion
21894 TryImplicitIntConversion -> ImplicitIntConversion
21895 ConvertImplicitRequired -> ImplicitConversionRequired
21896 ConvertNumericExplicit -> ExplicitNumericConversion
21897 ConvertReferenceExplicit -> ExplicitReferenceConversion
21898 ConvertExplicit -> ExplicitConversion
21899 ConvertExplicitStandard -> ExplicitStandardConversion
21901 2003-05-19 Martin Baulig <martin@ximian.com>
21903 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21904 (TypeInfo): Added support for structs having structs as fields.
21906 * ecore.cs (FieldExpr): Implement IVariable.
21907 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21908 VariableInfo for the field.
21910 2003-05-18 Martin Baulig <martin@ximian.com>
21912 * expression.cs (This.DoResolve): Report a CS0027 if we're
21913 emitting a field initializer.
21915 2003-05-18 Martin Baulig <martin@ximian.com>
21917 * expression.cs (This.ResolveBase): New public function.
21918 (This.DoResolve): Check for CS0188.
21920 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21923 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21924 `instance_expression' to null if we don't have any non-static
21927 2003-05-18 Martin Baulig <martin@ximian.com>
21929 Reworked the way how local variables and parameters are handled by
21930 the flow analysis code.
21932 * statement.cs (TypeInfo, VariableMap): New public classes.
21933 (VariableInfo): New public class. This is now responsible for
21934 checking whether a variable has been assigned. It is used for
21935 parameters and local variables.
21936 (Block.EmitMeta): Take the InternalParameters as argument; compute
21937 the layout of the flow vectors here.
21938 (Block.LocalMap, Block.ParameterMap): New public properties.
21939 (FlowBranching): The .ctor doesn't get the InternalParameters
21940 anymore since Block.EmitMeta() now computes the layout of the flow
21942 (MyStructInfo): This class is now known as `StructInfo' and nested
21943 in `TypeInfo'; we don't access this directly anymore.
21945 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21946 property and removed IsAssigned(), IsFieldAssigned(),
21947 SetAssigned() and SetFieldAssigned(); we now call them on the
21948 VariableInfo so we don't need to duplicate this code everywhere.
21950 * expression.cs (ParameterReference): Added `Block block' argument
21952 (LocalVariableReference, ParameterReference, This): The new
21953 VariableInfo class is now responsible for all the definite
21956 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21957 IsParameterAssigned, SetParameterAssigned): Removed.
21959 2003-05-18 Martin Baulig <martin@ximian.com>
21961 * typemanager.cs (InitCoreTypes): Try calling
21962 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21963 the 3-args-version. Corlib now also needs our `void_type'.
21964 (GetMethod): Added overloaded version which takes an optional
21965 `bool report_errors' to allow lookups of optional methods.
21967 2003-05-12 Martin Baulig <martin@ximian.com>
21969 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21970 only used for locals and not for parameters.
21972 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21974 * support.cs (InternalParameters.ParameterType): Return the
21975 ExternalType of the parameter.
21977 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21980 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21982 * class.cs (MethodData.Define): Do not set the `newslot' on
21983 interface members, if they are also flagged as "override".
21985 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21986 better code for ++i and i++. This only works for static fields
21987 and local variables.
21989 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21990 want to pull the DeclSpace out of the builder_to_declspace instead
21991 of the TypeBuilder (like in TypeContainer.FindMembers).
21993 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21994 instead of LookupTypeContainer. Fixes the crash on .NET for
21995 looking up interface members.
21997 * const.cs: Create our own emit context during the Definition
21998 stage, so that constants are evaluated in the proper context, when
21999 a recursive definition happens.
22001 2003-05-11 Martin Baulig <martin@ximian.com>
22003 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22004 new block for a switch section.
22005 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22006 the adding/lookup in the switch block. Fixes #39828.
22008 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22010 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22011 functionality: I needed to convert the data after I had performed
22012 the add/sub operation into the operands type size.
22014 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22015 pass the type for the box operation, otherwise the resulting
22016 object would have been of type object.
22018 (BoxedCast): Add constructor to specify the type to box as.
22020 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22022 * iterators.cs: I was reusing the `count' variable inadvertently,
22023 take steps to not allow this to happen.
22025 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22027 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22028 by creating an array at the point where the params starts and
22029 putting all those arguments there, then adjusting the size of the
22032 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22034 * expression.cs (New.AddressOf): Implement interface
22035 IMemoryLocation. This is used when the `new' operator is used in
22036 the context of an invocation to a method on a value type.
22038 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22041 * namespace.cs: Also check the using aliases here.
22043 * driver.cs: Move the test for using validity after the types have
22044 been entered, so we do a single pass that also includes the using
22047 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22048 in the regular case. CreateSiblingForFinally is doing extra
22051 * attribute.cs (GetAttributeArgumentExpression): Store the result
22052 on an out value, and use the return value to indicate failure
22053 instead of using null (which is a valid return for Constant.GetValue).
22055 * statement.cs: Perform the analysis flow for the increment
22056 portion after the statement, because this will be the real flow of
22057 execution. Fixes #42385
22059 * codegen.cs (EmitContext.EmitArgument,
22060 EmitContext.EmitStoreArgument): New helper functions when the
22061 RemapToProxy flag is set.
22063 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22066 Add support for remapping parameters.
22068 * iterators.cs: Propagate parameter values; Store parameter
22069 values in the proxy classes.
22071 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22073 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22074 need a proxy reference; I do not know what I was thinking
22076 * cs-parser.jay (constructor_initializer): catch another error,
22077 and display nice message.
22079 (field_declaration): catch void field declaration
22080 to flag a better error.
22082 * class.cs (MemberBase.CheckBase): Report an error instead of a
22083 warning if a new protected member is declared in a struct.
22084 (Field.Define): catch the error of readonly/volatile.
22086 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22088 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22089 volatile variable is taken
22091 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22093 * statement.cs (Fixed.Resolve): Report an error if we are not in
22096 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22098 * typemanager.cs: reuse the code that handles type clashes for
22099 delegates and enumerations.
22101 * class.cs (Report28): Always report.
22103 * expression.cs (EncodeAsAttribute): Allow nulls here.
22105 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22107 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22108 the functionality for testing whether an expression is valid for
22109 an attribute here. Also handle the case of arrays of elements
22112 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22113 encoding a linear array into an array of objects that are suitable
22114 to be passed to an CustomAttributeBuilder.
22116 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22118 * ecore.cs: (FieldExpr): Handle field remapping here.
22120 * iteratators.cs: Pass the instance variable (if the method is an
22121 instance method) to the constructors, so we can access the field
22122 variables on the class.
22124 TODO: Test this with structs. I think the THIS variable on
22125 structs might have to be a pointer, and not a refenrece
22127 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22129 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22130 local variables to fields in a proxy class.
22132 * iterators.cs (PopulateProxy): Rename our internal fields to
22134 Create a <THIS> field if we are an instance method, so we can
22135 reference our parent container variables.
22136 (MapVariable): Called back from the EmitContext code to enter a
22137 new variable to field mapping into the proxy class (we just create
22141 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22142 for using the remapped locals to fields.
22144 I placed the code here, because that gives the same semantics to
22145 local variables, and only changes the Emit code.
22147 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22148 statements inside iterators.
22149 (VariableInfo): Add a FieldBuilder for the cases when we are
22150 remapping local variables to fields in a proxy class
22152 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22153 current_block != null.
22155 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22156 not cope with strings, as it has been moved to the
22157 TableSwitchEmit. Fixed bug in switch generation.
22159 * expression.cs (New.DoResolve): Provide more context for the user
22160 when reporting an error.
22162 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22165 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22166 check the permissions for it. Note than in a type-resolution
22167 context the check was already present in DeclSpace.ResolveType,
22168 but was missing from the MemberAccess.
22170 (ArrayCreation.CheckIndices): warn if the user has
22171 more nested levels of expressions, but there are no more
22172 dimensions specified. Avoids crash on bug 41906.
22174 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22176 * statement.cs (Block): replace Implicit bool, for a generic
22178 New flag: `Unchecked'. This is used during the EmitMeta phase
22179 (which is out-of-line with the regular Resolve/Emit process for a
22180 statement, as this is done ahead of time, but still gets a chance
22181 to call constant resolve).
22183 (Block.Flags): new enum for adding a new flag.
22185 (Block.EmitMeta): track the state of unchecked.
22187 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22188 to enable constant resolution to work there as well.
22190 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22192 * typemanager.cs (ienumerable_type): Also look up
22193 System.Collections.IEnumerable.
22195 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22197 TODO: Test more than one conditional per method.
22199 * class.cs (Indexer.Define): Report the location where the user is
22200 referencing the unsupported feature.
22202 (MethodData): Overload the use of `conditionals' to
22203 minimize the creation of needless ArrayLists. This saves roughly
22204 212kb on my machine.
22206 (Method): Implement the new IIteratorContainer interface.
22207 (Method.SetYields): Implement the method by setting the ModFlags
22208 to contain METHOD_YIELDS.
22210 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22211 which just got set to null.
22213 * iterators.cs: New file.
22215 (Yield, YieldBreak): New statements.
22217 * statement.cs (Return.Resolve): Flag an error if we are used in
22218 an iterator method.
22220 * codegen.cs (InIterator): New flag set if the code is being
22221 compiled in an iterator method.
22223 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22224 internal modifier, and we just use it to avoid adding extra
22225 fields, as this is seldom used.
22227 * cs-parser.jay: Add yield_statement (yield and yield break).
22229 * driver.cs: New flag -v2 to turn on version 2 features.
22231 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22232 hashtable when v2 is enabled.
22234 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22236 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22237 there is already a namespace defined with this name.
22239 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22240 people upgraded their corlibs.
22242 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22243 always use fully qualified types, no need to use the compiler
22246 (TypeManager.IsNamespace): Use binarysearch.
22248 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22249 AddDelegate): I did not quite use the new IsValid API properly: I
22250 have to pass the short-name and the fullname. I was passing only
22251 the basename instead of the fullname sometimes.
22253 (TypeContainer.DefineType): call NamespaceClash.
22255 * interface.cs (Interface.DefineType): use NamespaceClash before
22258 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22261 * enum.cs: (Enum.DefineType): use NamespaceClash before
22264 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22265 speed increase. First, use the negative_hits cache when we get a
22266 negative. Second, add the type with its full original name
22267 instead of the new . and + encoded name (reflection uses + to
22268 separate type from a nested type). Use LookupTypeReflection
22269 directly which bypasses the type->name hashtable (that we already
22270 know does not contain the type.
22272 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22273 location/container type.
22275 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22277 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22279 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22281 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22282 method is being referenced in the method group from a static
22283 context, and report error 120 if so.
22285 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22288 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22289 is created, we create the A namespace).
22291 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22294 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22296 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22297 invocation to ModuleBuilder.GetType with the same values will
22298 return a new type instance, so we need to cache its return
22301 * expression.cs (Binary.ResolveOperator): Only allow the compare
22302 operators on enums if they are of the same type.
22304 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22305 types of ValueType on their own case. Before we were giving them
22306 the same treatment as objects.
22308 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22309 fullname. Short name is used to compare against container name.
22310 Fullname is used to check against defined namespace names.
22312 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22313 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22315 (Method.CheckBase): Call parent.
22316 (MemberBase.CheckBase): Check for protected members on sealed
22318 (PropertyBase.CheckBase): Call parent.
22319 (Field.Define): Call parent.
22321 * report.cs: Negative error codes are now mapped to 8000 - code,
22322 so that the display is render more nicely.
22324 * typemanager.cs: Do not use try/catch, instead report a regular
22327 (GetPointerType, GetReferenceType): These methods provide
22328 mechanisms to obtain the T* and T& from a T. We had the code
22329 previously scattered around the code base, and it also used
22330 TypeManager.LookupType that would go through plenty of caches.
22331 This one goes directly to the type source.
22333 In some places we did the Type.GetType followed by
22334 ModuleBuilder.GetType, but not in others, so this unifies the
22335 processing as well.
22337 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22338 statements now that we have namespace information.
22340 * typemanager.cs (IsNamespace): New method, returns whether the
22341 string presented is a namespace or not.
22343 (ComputeNamespaces): New public entry point, computes the list of
22344 available namespaces, using the GetNamespaces API call in Mono, or
22345 the slower version in MS.NET.
22347 Now before we start the semantic analysis phase, we have a
22348 complete list of namespaces including everything that the user has
22351 Deleted old code to cache namespaces in .nsc files.
22353 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22355 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22356 class/struct location definition Location for the implicit
22357 constructor location.
22359 (Operator.Define): Use the location of the operator for the
22360 implicit Method definition.
22362 (Constructor.Emit): use the constructor location for the implicit
22363 base initializer constructor.
22365 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22366 and the Expression class now contains two new methods:
22368 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22369 isolate type lookup from the rest of the resolution process.
22371 Since we use Expressions to hold type definitions due to the way
22372 we parse the input we have historically overloaded Resolve to
22373 perform the Type lookups if a special flag is passed. Now this is
22374 eliminated and two methods take their place.
22376 The differences in the two methods between xStep and xTerminal is
22377 that xStep is involved in our current lookup system that uses
22378 SimpleNames to compose a name, while xTerminal is used just to
22379 catch the case where the simplename lookup failed.
22381 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22383 * expression.cs (ResolveMemberAccess): Remove redundant code.
22384 TypeExpr expressions are always born fully resolved.
22386 * interface.cs (PopulateMethod): Do not lookup the types twice.
22387 We were doing it once during SemanticAnalysis and once during
22390 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22391 in local variable type definitions, were being returned as a
22392 SimpleName (we decomposed everything into a string), that is
22393 because primary_expression was being used instead of a type in the
22394 grammar (reduce/reduce conflicts).
22396 The part that was wrong is that we converted the expression into a
22397 string (an oversimplification in one hand, compounded with primary
22398 expressions doing string concatenation).
22404 Would return "A.B.C[]" as a SimpleName. This stopped things like
22405 using clauses from working on this particular context. And a type
22406 was being matched directly against "A.B.C[]".
22408 We now use the correct approach, and allow for ComposedCast to be
22409 part of the unary expression. So the "A.B.C []" become a composed
22410 cast of "A.B.C" (as a nested group of MemberAccess with a
22411 SimpleName at the end) plus the rank composition "[]".
22415 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22417 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22418 for the access level checking.
22420 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22421 `TypeContainer container', because I kept getting confused when I
22422 was debugging this code.
22424 * expression.cs (Indexers): Instead of tracking getters/setters,
22425 we now track them in parallel. We create one arraylist less, but
22426 most importantly it is possible now for the LValue code to find a
22427 matching get for a set.
22429 (IndexerAccess.DoResolveLValue): Update the code.
22430 GetIndexersForType has been modified already to extract all the
22431 indexers from a type. The code assumed it did not.
22433 Also make the code set the correct return type for the indexer.
22434 This was fixed a long time ago for properties, but was missing for
22435 indexers. It used to be void_type.
22437 (Binary.Emit): Test first for doubles instead of
22438 floats, as they are more common.
22440 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22441 when dealing with floats and the <=, >= operators. This fixes bug
22444 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22445 to load the array value by emitting a load on the foreach variable
22446 type. This was incorrect.
22448 We now emit the code to load an element using the the array
22449 variable type, and then we emit the conversion operator.
22453 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22455 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22457 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22459 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22460 test for protection before we test for signatures.
22462 (MethodSignature.ToString): implement.
22464 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22465 to the case where we reduced into a LongConstant.
22467 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22468 depend on whether the information is acurrate, because the
22469 Microsoft runtime will always claim that the array type is public,
22470 regardless of the real state.
22472 If the type is a pointer, another problem happens: the type is
22473 reported as non-public in Microsoft.
22475 In both cases we have to call CheckAccessLevel recursively with
22476 the underlying type as the argument to be tested.
22478 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22480 * assign.cs (Assign.Emit): If we are dealing with a compound
22481 assignment expression, we should use the code path that stores the
22482 intermediate result in a temporary value. This fixes #40903.
22484 *expression.cs (Indirection.ToString): Provide ToString method for
22487 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22489 * class.cs: Null out fields holding references to Block objects so
22490 they can be garbage collected.
22492 * expression.cs (OverloadResolve): Remove unused local.
22494 2003-04-07 Martin Baulig <martin@ximian.com>
22496 * codegen.cs (EmitContext.CurrentFile): New public field.
22497 (EmitContext.Mark): Use the CurrentFile to check whether the
22498 location is in the correct file.
22499 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22501 2003-04-07 Martin Baulig <martin@ximian.com>
22503 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22505 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22506 location. [FIXME: The location argument which gets passed to this
22507 method is sometimes wrong!]
22509 2003-04-07 Nick Drochak <ndrochak@gol.com>
22511 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22513 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22515 * expression.cs (Indirection.EmitAssign): We were using the
22516 temporary, but returning immediately instead of continuing the
22519 2003-04-06 Martin Baulig <martin@ximian.com>
22521 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22522 if it's a nested child, but also deriving from the outer class.
22525 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22526 nested child, but also deriving from the outer class. See
22528 (FilterWithClosure): We may access private members of the outer
22529 class if we're a nested child and deriving from the outer class.
22530 (RealMemberLookup): Only set `closure_private_ok' if the
22531 `original_bf' contained BindingFlags.NonPublic.
22533 2003-04-05 Martin Baulig <martin@ximian.com>
22535 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22537 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22539 * class.cs (Event.Define): Do not allow abstract events to have
22542 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22544 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22545 block in event declarations.
22547 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22548 value type, get its address.
22550 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22551 leaving a class on the stack instead of a boolean value (int
22552 0/1). Change the code so we compare against null, and then the
22553 result against zero.
22555 * class.cs (TypeContainer.GetClassBases): We were checking for the
22556 parent class being sealed too late.
22558 * expression.cs (Binary.Emit): For <= and >= when dealing with
22559 floating point values, use cgt.un and clt.un instead of cgt and
22562 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22564 * statement.cs: Apply the same optimization as MS: skip the
22565 GetEnumerator returning an IEnumerator, and use the one returning a
22566 CharEnumerator instead. This allows us to avoid the try-finally block
22569 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22571 * cs-parser.jay: Attributes cannot be applied to
22572 namespaces. Fixes #40473
22574 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22577 (Add*): check if the name is valid using the full name for constants,
22578 fields, properties and events.
22580 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22582 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22583 char constants to be part of the enumeration.
22585 * expression.cs (Conditional.DoResolve): Add support for operator
22586 true. Implements the missing functionality from 14.12
22588 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22589 operator true/false as required by the spec.
22591 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22592 implicit conversion to boolean.
22594 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22595 also one where the type implements `operator true'.
22597 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22598 get an expression that will invoke operator true based on an
22601 (GetConversionOperators): Removed the hack that called op_True
22604 (Expression.ResolveBoolean): Move this from Statement.
22606 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22608 * ecore.cs (FieldExpr): do not allow initialization of initonly
22609 fields on derived classes
22611 2003-03-13 Martin Baulig <martin@ximian.com>
22613 * statement.cs (Block.Emit): Call ig.BeginScope() and
22614 ig.EndScope() when compiling with debugging info; call
22615 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22617 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22619 * expression.cs (Indexers): Do not construct immediately, allow
22620 for new members to be appended as we go. Fixes 38143
22622 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22624 * expression.cs: save/restore context when resolving an unchecked
22627 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22629 * cfold.cs: Catch division by zero in modulus operator during
22632 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22634 * interface.cs (Interface.DefineMembers): Avoid defining members
22637 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22639 * driver.cs: handle the +/- options for -noconfig
22641 * statement.cs (Unckeched.Resolve): Also track the state of
22642 unchecked in the Resolve phase.
22644 2003-02-27 Martin Baulig <martin@ximian.com>
22646 * ecore.cs (Expression.MemberLookup): Don't create a
22647 MethodGroupExpr for something which is not a method. Fixes #38291.
22649 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22651 * class.cs (MemberBase.CheckParameters): Also check that the type
22652 is unmanaged if it is a pointer.
22654 * expression.cs (SizeOf.Resolve): Add location information.
22656 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22657 a managed type is declared.
22659 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22660 parameter modifiers as well. Fixes bug 38606
22662 * class.cs: Very sad. Am backing out the speed up changes
22663 introduced by the ArrayList -> Array in the TypeContainer, as they
22664 were not actually that much faster, and introduced a bug (no error
22665 reports on duplicated methods).
22667 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22668 source first, this will guarantee that we have a valid expression
22669 before calling in lower levels functions that will require a
22670 resolved object. Then use this original_source in the
22671 target.ResolveLValue instead of the original source that was
22674 Another change. Use target.Resolve instead of LValueResolve.
22675 Although we are resolving for LValues, we will let the Assign code
22676 take care of that (it will be called again from Resolve). This
22677 basically allows code like this:
22679 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22680 class Y { void A (X x) { x [0] += o; }
22682 The problem was that the indexer was trying to resolve for
22683 set_Item (idx, object o) and never finding one. The real set_Item
22684 was set_Item (idx, X). By delaying the process we get the right
22689 2003-02-23 Martin Baulig <martin@ximian.com>
22691 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22692 while calling DoEmit ().
22694 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22695 source files; if you use the #line directive inside a method, the
22696 compiler stops emitting line numbers for the debugger until it
22697 reaches the end of the method or another #line directive which
22698 restores the original file.
22700 2003-02-23 Martin Baulig <martin@ximian.com>
22702 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22704 2003-02-23 Martin Baulig <martin@ximian.com>
22706 * statement.cs (Block.AddChildVariableNames): We need to call this
22707 recursively, not just for our immediate children.
22709 2003-02-23 Martin Baulig <martin@ximian.com>
22711 * class.cs (Event.Define): Always make the field private, like csc does.
22713 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22714 actually work, fixes bug #37521.
22716 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22718 * delegate.cs: When creating the various temporary "Parameters"
22719 classes, make sure that we call the ComputeAndDefineParameterTypes
22720 on those new parameters (just like we do with the formal ones), to
22721 allow them to be resolved in the context of the DeclSpace.
22723 This fixes the bug that Dick observed in Bugzilla #38530.
22725 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22727 * expression.cs (ResolveMemberAccess): When resolving a constant,
22728 do not attempt to pull a constant if the value was not able to
22729 generate a valid constant.
22731 * const.cs (LookupConstantValue): Do not report more errors than required.
22733 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22735 * expression.cs: fixes bug #38328.
22737 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22739 * class.cs: Changed all the various members that can be part of a
22740 class from being an ArrayList to be an Array of the right type.
22741 During the DefineType type_list, interface_list, delegate_list and
22742 enum_list are turned into types, interfaces, delegates and enums
22745 And during the member population, indexer_list, event_list,
22746 constant_list, field_list, instance_constructor_list, method_list,
22747 operator_list and property_list are turned into their real arrays.
22749 Although we could probably perform this operation earlier, for
22750 good error reporting we need to keep the lists and remove the
22751 lists for longer than required.
22753 This optimization was triggered by Paolo profiling the compiler
22754 speed on the output of `gen-sample-program.pl' perl script.
22756 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22757 not crash in methods like MemberLookupFailed that use this field.
22759 This problem arises when the compiler fails to resolve a type
22760 during interface type definition for example.
22762 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22764 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22765 inherit from System.Object, so we have to stop at null, not only
22766 when reaching System.Object.
22768 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22770 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22771 DeclaredOnly because the parent indexer might have had a different
22772 name, but did not loop until the top of the hierarchy was reached.
22774 The problem this one fixes is 35492: when a class implemented an
22775 indexer from an interface, we were getting the interface method
22776 (which was abstract) and we were flagging an error (can not invoke
22779 This also keeps bug 33089 functioning, and test-148 functioning.
22781 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22782 out if a method is special is to see if it is declared in a
22783 property or event, or whether it is one of the predefined operator
22784 names. This should fix correctly #36804.
22786 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22788 The goal here is to remove the dependency on EmptyCast.Peel ().
22789 Killing it completely.
22791 The problem is that currently in a number of places where
22792 constants are expected, we have to "probe" for an EmptyCast, and
22793 Peel, which is not the correct thing to do, as this will be
22794 repetitive and will likely lead to errors.
22796 The idea is to remove any EmptyCasts that are used in casts that
22797 can be reduced to constants, so we only have to cope with
22800 This bug hunt was triggered by Bug 37363 and the desire to remove
22801 the duplicate pattern where we were "peeling" emptycasts to check
22802 whether they were constants. Now constants will always be
22805 * ecore.cs: Use an enumconstant here instead of wrapping with
22808 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22809 throwing me off. By handling this we can get rid of a few hacks.
22811 * statement.cs (Switch): Removed Peel() code.
22813 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22815 * class.cs: Location information for error 508
22817 * expression.cs (New.DoResolve): Add a guard against double
22818 resolution of an expression.
22820 The New DoResolve might be called twice when initializing field
22821 expressions (see EmitFieldInitializers, the call to
22822 GetInitializerExpression will perform a resolve on the expression,
22823 and later the assign will trigger another resolution
22825 This leads to bugs (#37014)
22827 * delegate.cs: The signature for EndInvoke should contain any ref
22828 or out parameters as well. We were not doing this in the past.
22830 * class.cs (Field.Define): Do not overwrite the type definition
22831 inside the `volatile' group. Turns out that volatile enumerations
22832 were changing the type here to perform a validity test, which
22835 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22837 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22838 and structs, we do not want to load the instance variable
22840 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22841 enum_type has to be handled like an object reference (implicit
22842 conversions exists from this to object), but the regular IsClass
22843 and IsValueType tests will never return true for this one.
22845 Also we use TypeManager.IsValueType instead of type.IsValueType,
22846 just for consistency with the rest of the code (this is only
22847 needed if we ever use the construct exposed by test-180.cs inside
22848 corlib, which we dont today).
22850 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22852 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22855 2003-02-09 Martin Baulig <martin@ximian.com>
22857 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22858 (Namespace.DefineNamespaces): New static public method; this is
22859 called when we're compiling with debugging to add all namespaces
22860 to the symbol file.
22862 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22863 pass it to the Namespace's .ctor.
22865 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22866 and MethodBase arguments; pass the namespace ID to the symwriter;
22867 pass the MethodBase instead of the token to the symwriter.
22868 (SymbolWriter.DefineNamespace): New method to add a namespace to
22871 2003-02-09 Martin Baulig <martin@ximian.com>
22873 * symbolwriter.cs: New file. This is a wrapper around
22874 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22875 methods here in near future.
22877 2003-02-09 Martin Baulig <martin@ximian.com>
22879 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22880 ILGenerator.MarkSequencePoint() which are actually used by the
22883 2003-02-09 Martin Baulig <martin@ximian.com>
22885 * location.cs (SourceFile): New public sealed class. This
22886 contains the name and an index which is used in the location's token.
22887 (Location): Reserve an appropriate number of bits in the token for
22888 the source file instead of walking over that list, this gives us a
22889 really huge performance improvement when compiling with debugging.
22891 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22892 `SourceFile' argument instead of a string.
22893 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22894 but don't parse/tokenize here, we need to generate the list of all
22895 source files before we do that.
22896 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22899 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22900 instead of a string.
22902 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22905 2003-02-09 Martin Baulig <martin@ximian.com>
22907 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22908 filename on `#line default'.
22910 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22912 * statement.cs: don't clear the pinned var when the fixed statement
22913 returns from the method (fixes bug#37752).
22915 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22917 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22920 2003-02-07 Martin Baulig <martin@ximian.com>
22922 * driver.cs: Removed the `--debug-args' command line argument.
22924 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22925 automatically by the AsssemblyBuilder.
22926 (CodeGen.InitializeSymbolWriter): We don't need to call any
22927 initialization function on the symbol writer anymore. This method
22928 doesn't take any arguments.
22930 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22932 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22933 from referenced assemblies as well.
22935 2003-02-02 Martin Baulig <martin@ximian.com>
22937 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22939 2003-02-02 Martin Baulig <martin@ximian.com>
22941 * class.cs (Constructor.Emit): Open the symbol writer before
22942 emitting the constructor initializer.
22943 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22944 single-stepping through constructor initializers.
22946 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22948 * class.cs: Handle error 549: do not allow virtual methods in
22951 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22953 * decl.cs: Check access levels when resolving types
22955 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22957 * statement.cs: Add parameters and locals set in catch blocks that might
22958 return to set vector
22960 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22962 * class.cs (Operator): Set the SpecialName flags for operators.
22964 * expression.cs (Invocation.DoResolve): Only block calls to
22965 accessors and operators on SpecialName methods.
22967 (Cast.TryReduce): Handle conversions from char constants.
22970 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22972 * statement.cs: small memory and time optimization in FlowBranching.
22974 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22976 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22977 problem that the last fix but in the other sid (Set).
22979 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22980 access when there is no indexer in the hierarchy.
22982 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22984 * class.cs: Combine some if statements.
22986 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22988 * driver.cs: fixed bug #37187.
22990 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22992 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22993 any indexer, it's needed to build a list with all the indexers in the
22994 hierarchy (AllGetters), else we have problems. Fixes #35653.
22996 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22998 * class.cs (MethodData.Define): It is wrong for an interface
22999 implementation to be static in both cases: explicit and implicit.
23000 We were only handling this in one case.
23002 Improve the if situation there to not have negations.
23004 * class.cs (Field.Define): Turns out that we do not need to check
23005 the unsafe bit on field definition, only on usage. Remove the test.
23007 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23009 * driver.cs: use assembly.Location instead of Codebase (the latest
23010 patch made mcs fail when using MS assemblies).
23012 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23014 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23015 get the path to *corlib.dll.
23017 2003-01-21 Nick Drochak <ndrochak@gol.com>
23021 * typemanager.cs: Remove compiler warnings
23023 2003-01-20 Duncan Mak <duncan@ximian.com>
23025 * AssemblyInfo.cs: Bump the version number to 0.19.
23027 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23029 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23031 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23033 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23035 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23037 * cs-parser.jay: Small fix: we were not comparing the constructor
23038 name correctly. Thanks to Zoltan for the initial pointer.
23040 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23042 * cs-tokenizer.cs: Set file name when specified with #line
23044 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23046 * cs-parser.jay: Only perform the constructor checks here if we
23047 are named like the class; This will help provider a better
23048 error. The constructor path is taken when a type definition is
23049 not found, but most likely the user forgot to add the type, so
23050 report that rather than the constructor error.
23052 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23054 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23057 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23059 * cs-parser.jay: Add cleanup call.
23061 2003-01-13 Duncan Mak <duncan@ximian.com>
23063 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23064 consistent with other methods.
23066 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23068 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23070 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23072 * attribute.cs: only set GuidAttr to true when we have a
23075 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23079 * typemanager.cs: fixes to allow mcs compile corlib with the new
23080 Type.IsSubclassOf fix.
23082 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23084 * expression.cs (LocalVariableReference.DoResolve): Classify a
23085 constant as a value, not as a variable. Also, set the type for
23088 * cs-parser.jay (fixed_statement): take a type instead of a
23089 pointer_type, so we can produce a better error message later.
23091 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23094 (For.DoEmit): Make inifinite loops have a
23095 non-conditional branch back.
23097 (Fixed.DoEmit): First populate the pinned variables, then emit the
23098 statement, then clear the variables. Before I was emitting the
23099 code once for each fixed piece.
23102 2003-01-08 Martin Baulig <martin@ximian.com>
23104 * statement.cs (FlowBranching.MergeChild): A break in a
23105 SWITCH_SECTION does not leave a loop. Fixes #36155.
23107 2003-01-08 Martin Baulig <martin@ximian.com>
23109 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23110 lives in the same number space than `param_map'. Fixes #36154.
23112 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23114 * cs-parser.jay (constructor_declaration): Set the
23115 Constructor.ModFlags before probing for it. This makes the
23116 compiler report 514, 515 and 132 (the code was there, but got
23119 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23120 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23121 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23123 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23125 * enum.cs: create the enum static fields using the enum type.
23127 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23129 * class.cs: don't try to create the ParamBuilder for the return
23130 type if it's not needed (and handle it breaking for the ms runtime
23133 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23135 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23137 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23139 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23140 the command. This showed up while compiling the JANET source
23141 code, which used \r as its only newline separator.
23143 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23145 * class.cs (Method.Define): If we are an operator (because it
23146 reuses our code), then set the SpecialName and HideBySig. #36128
23148 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23150 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23151 exception, report error 120 `object reference required'.
23153 * driver.cs: Add --pause option, used during to measure the size
23154 of the process as it goes with --timestamp.
23156 * expression.cs (Invocation.DoResolve): Do not allow methods with
23157 SpecialName to be invoked.
23159 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23161 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23162 number before adding it.
23164 2002-12-21 Ravi Pratap <ravi@ximian.com>
23166 * ecore.cs (StandardImplicitConversion): When in an unsafe
23167 context, we allow conversion between void * to any other pointer
23168 type. This fixes bug #35973.
23170 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23172 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23173 is not thrown when extensionless outputs are used
23175 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23177 * rootcontext.cs: fixed compilation of corlib.
23179 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23181 * attribute.cs (Attributes.Contains): Add new method.
23183 * class.cs (MethodCore.LabelParameters): if the parameter is an
23184 `out' parameter, check that no attribute `[In]' has been passed.
23186 * enum.cs: Handle the `value__' name in an enumeration.
23188 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23190 * decl.cs: Added special case to allow overrides on "protected
23193 2002-12-18 Ravi Pratap <ravi@ximian.com>
23195 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23196 since it makes much more sense.
23198 (Attributes.ctor): Don't require a Location parameter.
23200 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23202 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23203 since we already have that information per attribute.
23205 * everywhere : make appropriate changes.
23207 * class.cs (LabelParameters): Write the code which actually
23208 applies attributes to the return type. We can't do this on the MS
23209 .NET runtime so we flag a warning in the case an exception is
23212 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23214 * const.cs: Handle implicit null conversions here too.
23216 2002-12-17 Ravi Pratap <ravi@ximian.com>
23218 * class.cs (MethodCore.LabelParameters): Remove the extra
23219 Type [] parameter since it is completely unnecessary. Instead
23220 pass in the method's attributes so that we can extract
23221 the "return" attribute.
23223 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23225 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23226 of ignoring it and letting the compile continue.
23228 * typemanager.cs (ChangeType): use an extra argument to return an
23229 error condition instead of throwing an exception.
23231 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23233 * expression.cs (Unary.TryReduce): mimic the code for the regular
23234 code path. Perform an implicit cast in the cases where we can
23235 implicitly convert to one of the integral types, and then reduce
23236 based on that constant. This fixes bug #35483.
23238 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23240 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23242 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23244 * namespace.cs: fixed bug #35489.
23246 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23248 * class.cs: Remove some dead code.
23250 * cs-parser.jay: Estimate the number of methods needed
23251 (RootContext.MethodCount);
23253 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23254 numbers instead of StringBuilders.
23256 * support.cs (PtrHashtable): Add constructor with initial size;
23257 We can now reduce reallocations of the method table.
23259 2002-12-10 Ravi Pratap <ravi@ximian.com>
23261 * attribute.cs (ApplyAttributes): Keep track of the emitted
23262 attributes on a per-target basis. This fixes bug #35413.
23264 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23266 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23267 default to the Windows 1252 encoding.
23269 (UnixParseOption): Support version, thanks to Alp for the missing
23272 * AssemblyInfo.cs: Add nice assembly information.
23274 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23277 * cs-parser.jay: Allow a trailing comma before the close bracked
23278 in the attribute_section production.
23280 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23281 address of the instance was being taken, I will take this out,
23282 because we take the address of the object immediately here.
23284 2002-12-09 Ravi Pratap <ravi@ximian.com>
23286 * typemanager.cs (AreMultipleAllowed): Take care of the most
23287 obvious case where attribute type is not in the current assembly -
23290 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23292 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23293 definitions, instead of doing that afterwards.
23295 Also we use a nice little hack, depending on the constructor, we
23296 know if we are a "composed" name or a simple name. Hence, we
23297 avoid the IndexOf test, and we avoid
23299 * codegen.cs: Add code to assist in a bug reporter to track down
23300 the source of a compiler crash.
23302 2002-12-07 Ravi Pratap <ravi@ximian.com>
23304 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23305 types have been emitted for a given element and flag an error
23306 if something which does not have AllowMultiple set is used more
23309 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23310 attribute types and their corresponding AllowMultiple properties
23312 (AreMultipleAllowed): Check the property for a given type.
23314 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23315 property in the case we have a TypeContainer.
23317 (Attributes.AddAttribute): Detect duplicates and just skip on
23318 adding them. This trivial fix catches a pretty gross error in our
23319 attribute emission - global attributes were being emitted twice!
23321 Bugzilla bug #33187 is now fixed.
23323 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23325 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23326 instead of pp_and).
23328 * expression.cs (Binary.ResolveOperator): I can only use the
23329 Concat (string, string, string) and Concat (string, string,
23330 string, string) if the child is actually a concatenation of
23333 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23335 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23336 context where we need a 2-character lookahead.
23338 * pending.cs (PendingImplementation): Rework so we can keep track
23339 of interface types all the time, and flag those which were
23340 implemented by parents as optional.
23342 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23344 * expression.cs (Binary.ResolveOperator): Use
23345 String.Concat(string,string,string) or
23346 String.Concat(string,string,string,string) when possible.
23348 * typemanager: More helper methods.
23351 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23353 * pending.cs: remove the bogus return from GetMissingInterfaces()
23354 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23356 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23358 * namespace.cs: avoid duplicated 'using xxx' being added to
23359 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23360 when we get more than one 'using' statement for the same namespace.
23361 Report a CS0105 warning for it.
23363 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23365 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23366 of calling getChar/putback, uses internal knowledge of it.
23368 (xtoken): Reorder tokenizer so most common patterns are checked
23369 first. This reduces the compilation time in another 5% (from 8.11s
23370 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23372 The parsing time is 22% of the compilation in mcs, and from that
23373 64% is spent on the tokenization process.
23375 I tried using a binary search for keywords, but this is slower
23376 than the hashtable. Another option would be to do a couple of
23379 * Not use a StringBuilder, instead use an array of chars,
23380 with a set value. Notice that this way we could catch
23381 the 645 error without having to do it *afterwards*.
23383 * We could write a hand-parser to avoid the hashtable
23384 compares altogether.
23386 The identifier consumption process takes 37% of the tokenization
23387 time. Another 15% is spent on is_number. 56% of the time spent
23388 on is_number is spent on Int64.Parse:
23390 * We could probably choose based on the string length to
23391 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23394 Another 3% is spend on wrapping `xtoken' in the `token' function.
23396 Handle 0xa0 as whitespace (#34752)
23398 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23400 * typemanager.cs (IsCLRType): New routine to tell whether a type
23401 is one of the builtin types.
23403 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23404 typecode in more places instead of doing pointer comparissions.
23405 We could leverage some knowledge about the way the typecodes are
23408 New code to cache namespaces in assemblies, it is currently not
23409 invoked, to be used soon.
23411 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23413 * expression.cs (Binary.ResolveOperator): specially handle
23414 strings, and do not perform user-defined operator overloading for
23417 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23419 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23420 internalcall as it is a pretty simple operation; Avoid whenever
23421 possible to call Char.IsLetter.
23423 (consume_identifier): Cut by half the number of
23424 hashtable calls by merging the is_keyword and GetKeyword behavior.
23426 Do not short-circuit, because if we do, we
23427 report errors (ie, #if false && true would produce an invalid
23431 2002-11-24 Martin Baulig <martin@ximian.com>
23433 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23434 check constant ranges and report a CS0221. Fixes #33186.
23436 2002-11-24 Martin Baulig <martin@ximian.com>
23438 * cs-parser.jay: Make this work for uninitialized variable
23439 declarations in the `for' initializer. Fixes #32416.
23441 2002-11-24 Martin Baulig <martin@ximian.com>
23443 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23444 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23446 2002-11-24 Martin Baulig <martin@ximian.com>
23448 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23449 argument; if true, we also check for user-defined conversions.
23450 This is only needed if both arguments are of a user-defined type.
23451 Fixes #30443, added test-175.cs.
23452 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23454 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23456 2002-11-24 Martin Baulig <martin@ximian.com>
23458 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23459 function to get the store opcode.
23460 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23461 only emit the Ldelema if the store opcode is Stobj. You must run
23462 both test-34 and test-167 to test this. Fixes #34529.
23464 2002-11-23 Martin Baulig <martin@ximian.com>
23466 * ecore.cs (Expression.MemberLookup): Added additional
23467 `qualifier_type' argument which is used when we're being called
23468 from MemberAccess.DoResolve() and null if we're called from a
23470 (Expression.MemberLookupFailed): New method to report errors; this
23471 does the CS1540 check and reports the correct error message.
23473 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23474 argument for the CS1540 check and redone the way how we're dealing
23475 with private members. See the comment in the source code for details.
23476 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23477 `closure_start_type' to `closure_qualifier_type' and check whether
23478 it's not null. It was not this filter being broken, it was just
23479 being called with the wrong arguments.
23481 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23482 and pass it the correct `qualifier_type'; this also does the error
23485 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23487 * expression.cs (Invocation.EmitParams): If the we are dealing
23488 with a non-built-in value type, load its address as well.
23490 (ArrayCreation): Use a a pretty constant instead
23491 of the hardcoded value 2. Use 6 instead of 2 for the number of
23492 static initializers.
23494 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23495 because they are not really value types, just glorified integers.
23497 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23499 * ecore.cs: Remove redundant code for enumerations, make them use
23500 the same code path as everything else, fixes the casting issue
23501 with enumerations in Windows.Forms.
23503 * attribute.cs: Do only cast to string if it is a string, the
23504 validation happens later.
23506 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23507 people upgrade their corlibs.
23509 * ecore.cs: Oops, enumerations were not following the entire code path
23511 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23513 * typemanager.cs (FilterWithClosure): Commented out the test for
23514 1540 in typemanager.cs, as it has problems when accessing
23515 protected methods from a parent class (see test-174.cs).
23517 * attribute.cs (Attribute.ValidateGuid): new method.
23518 (Attribute.Resolve): Use above.
23520 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23522 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23524 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23525 handling for enumerations, as we only needed the TypeContainer
23526 functionality to begin with (this is required for the fix below to
23527 work for enums that reference constants in a container class for
23530 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23532 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23533 a valid TypeBuilder to perform lookups on.o
23535 * class.cs (InheritableMemberSignatureCompare): Use true in the
23536 call to GetGetMethod and GetSetMethod, because we are comparing
23537 the signature, and we need to get the methods *even* if they are
23540 (PropertyBase.CheckBase): ditto.
23542 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23543 GotoCase.Resolve): Use Peel on EmpytCasts.
23545 * ecore.cs (EmptyCast): drop child, add Peel method.
23547 2002-11-17 Martin Baulig <martin@ximian.com>
23549 * ecore.cs (EmptyCast.Child): New public property.
23551 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23552 label resolved to an EmptyCast. Fixes #34162.
23553 (GotoCase.Resolve): Likewise.
23554 (Block.EmitMeta): Likewise.
23556 2002-11-17 Martin Baulig <martin@ximian.com>
23558 * expression.cs (Invocation.BetterConversion): Prefer int over
23559 uint; short over ushort; long over ulong for integer literals.
23560 Use ImplicitConversionExists instead of StandardConversionExists
23561 since we also need to check for user-defined implicit conversions.
23562 Fixes #34165. Added test-173.cs.
23564 2002-11-16 Martin Baulig <martin@ximian.com>
23566 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23567 with the `true' and `false' literals. Fixes #33151.
23569 2002-11-16 Martin Baulig <martin@ximian.com>
23571 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23572 October 22nd; don't do the cs1540 check for static members.
23574 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23575 now using our own filter here and doing the cs1540 check again.
23577 2002-11-16 Martin Baulig <martin@ximian.com>
23579 * support.cs (InternalParameters): Don't crash if we don't have
23580 any fixed parameters. Fixes #33532.
23582 2002-11-16 Martin Baulig <martin@ximian.com>
23584 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23585 when looking up static methods to make this work on Windows.
23588 2002-11-16 Martin Baulig <martin@ximian.com>
23590 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23591 a setter rather than using PropertyInfo.CanWrite.
23593 2002-11-15 Nick Drochak <ndrochak@gol.com>
23595 * class.cs: Allow acces to block member by subclasses. Fixes build
23598 2002-11-14 Martin Baulig <martin@ximian.com>
23600 * class.cs (Constructor.Emit): Added the extern/block check.
23603 2002-11-14 Martin Baulig <martin@ximian.com>
23605 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23606 iteration while looking for indexers, this is needed because the
23607 indexer may have a different name in our base classes. Fixed the
23608 error reporting (no indexers at all, not get accessor, no
23609 overloaded match). Fixes bug #33089.
23610 (IndexerAccess.DoResolveLValue): Likewise.
23612 2002-11-14 Martin Baulig <martin@ximian.com>
23614 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23615 indexers. Fixes the first part of bug #33089.
23616 (MethodSignature.InheritableMemberSignatureCompare): Added support
23619 2002-11-13 Ravi Pratap <ravi@ximian.com>
23621 * attribute.cs (Attribute.Resolve): Catch the
23622 NullReferenceException and report it since it isn't supposed to
23625 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23627 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23628 LogicalOr and LogicalAnd that can benefit from recursively
23629 handling EmitBranchable. The code now should be nice for Paolo.
23631 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23633 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23634 the Type lookups, as we perform quite a number of lookups on
23635 non-Types. This can be removed once we can deterministically tell
23636 whether we have a type or a namespace in advance.
23638 But this might require special hacks from our corlib.
23642 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23643 and double which avoids a conversion from an integer to a double.
23645 * expression.cs: tiny optimization, avoid calling IsConstant,
23646 because it effectively performs the lookup twice.
23648 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23650 But a bogus return here to keep the semantics of the old code
23651 until the Mono runtime is fixed.
23653 * pending.cs (GetMissingInterfaces): New method used to remove all
23654 the interfaces that are already implemented by our parent
23655 classes from the list of pending methods.
23657 * interface.cs: Add checks for calls after ResolveTypeExpr.
23659 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23661 * class.cs (Class.Emit): Report warning 67: event not used if the
23662 warning level is beyond 3.
23664 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23665 being a NullLiteral.
23667 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23670 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23671 path that might fail if a type can not be resolved.
23673 * expression.cs (Binary.Emit): Emit unsigned versions of the
23676 * driver.cs: use error 5.
23678 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23680 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23682 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23684 * cs-parser.jay (switch_section): A beautiful patch from Martin
23685 Baulig that fixed 33094.
23687 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23689 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23690 Check whether the base is abstract and report an error if so.
23692 * expression.cs (IndexerAccess.DoResolveLValue,
23693 IndexerAccess.DoResolve): ditto.
23695 (Invocation.DoResolve): ditto.
23697 (Invocation.FullMethodDesc): Improve the report string.
23699 * statement.cs (Block): Eliminate IsVariableDefined as it is
23700 basically just a wrapper for GetVariableInfo.
23702 * ecore.cs (SimpleName): Use new
23704 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23705 type, as we return the actual parameter ref/unref state on a
23708 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23710 * support.cs: Return proper flags REF/OUT fixing the previous
23713 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23714 not used to mean `ref' but `ref or out' in ParameterReference
23716 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23717 full type signature instead of calling TypeManger.CSharpName
23720 * support.cs (InternalParameters.ParameterDesc): Do not compare
23721 directly to the modflags, because REF/OUT will actually be bitsets
23724 * delegate.cs (VerifyMethod): Check also the modifiers.
23726 * cs-tokenizer.cs: Fix bug where floating point values with an
23727 exponent where a sign was missing was ignored.
23729 * driver.cs: Allow multiple assemblies to be specified in a single
23732 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23734 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23735 because identifiers after a parenthesis would end up in this kind
23736 of production, and we needed to desamiguate it for having casts
23739 (UserDefinedType *) xxx
23741 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23743 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23744 we should set on the Bindingflags.NonPublic, but not turn on
23745 private_ok. private_ok controls whether a Private member is
23746 returned (this is chekced on the filter routine), while the
23747 BindingFlags.NonPublic just controls whether private/protected
23748 will be allowed. This fixes the problem part of the problem of
23749 private properties being allowed to be used in derived classes.
23751 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23752 so we can call the children DoResolveLValue method (this will
23753 properly signal errors on lvalue assignments to base properties)
23755 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23756 getter are null, and we have a property info, we know that this
23757 happened because the lookup failed, so we report an error 122 for
23758 protection level violation.
23760 We also silently return if setter and getter are null in the
23761 resolve functions, this condition only happens if we have flagged
23762 the error before. This is the other half of the problem.
23764 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23765 not have accessibility information, that is why we were returning
23766 true in the filter function in typemanager.cs.
23768 To properly report 122 (property is inaccessible because of its
23769 protection level) correctly, we report this error in ResolveAccess
23770 by failing if both the setter and the getter are lacking (ie, the
23773 DoResolve and DoLResolve have been modified to check for both
23774 setter/getter being null and returning silently, the reason being
23775 that I did not want to put the knowledge about this error in upper
23778 int old = Report.Errors;
23779 x = new PropertyExpr (...);
23780 if (old != Report.Errors)
23785 So the property expr is returned, but it is invalid, so the error
23786 will be flagged during the resolve process.
23788 * class.cs: Remove InheritablePropertySignatureCompare from the
23789 class, as we no longer depend on the property signature to compute
23790 whether it is possible to implement a method or not.
23792 The reason is that calling PropertyInfo.GetGetMethod will return
23793 null (in .NET, in Mono it works, and we should change this), in
23794 cases where the Get Method does not exist in that particular
23799 class X { public virtual int A { get { return 1; } } }
23801 class Z : Y { public override int A { get { return 2; } } }
23803 Would fail in Z because the parent (Y) would not have the property
23804 defined. So we avoid this completely now (because the alternative
23805 fix was ugly and slow), and we now depend exclusively on the
23808 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23809 reference method, instead of using the property.
23811 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23812 routines are gone now.
23814 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23815 names, they were incorrectly named.
23817 * cs-tokenizer.cs: Return are more gentle token on failure.
23819 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23820 had an out-of-sync index variable, which caused it to remove from
23821 the list of pending methods the wrong method sometimes.
23823 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23825 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23826 CanWrite, because those refer to this particular instance of the
23827 property, and do not take into account the fact that we can
23828 override single members of a property.
23830 Constructor requires an EmitContext. The resolution process does
23831 not happen here, but we need to compute the accessors before,
23832 because the resolution does not always happen for properties.
23834 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23835 subclass, before we did not update this flag, but we did update
23838 (GetAccessors): Drop this routine, as it did not work in the
23839 presence of partially overwritten set/get methods.
23841 Notice that this broke the cs1540 detection, but that will require
23844 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23848 * driver.cs: issue a warning instead of an error if we don't support
23849 debugging for the platform. Also ignore a couple of errors that may
23850 arise when trying to write the symbols. Undo my previous patch.
23852 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23854 * driver.cs: ignore /debug switch except for Unix platforms.
23856 2002-10-23 Nick Drochak <ndrochak@gol.com>
23858 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23860 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23862 * driver.cs: Do not make mcs-debug conditional, so we do not break
23863 builds that use it.
23865 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23866 review this patch. But basically after all the children variables
23867 have been merged, the value of "Breaks" was not being set to
23868 new_breaks for Switch blocks. I think that it should be set after
23869 it has executed. Currently I set this to the value of new_breaks,
23870 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23871 conservative, but I do not understand this code very well.
23873 I did not break anything in the build, so that is good ;-)
23875 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23877 2002-10-20 Mark Crichton <crichton@gimp.org>
23879 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23881 2002-10-20 Nick Drochak <ndrochak@gol.com>
23883 * cfold.cs: Fixed compile blocker.
23885 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23887 * driver.cs: I was chekcing the key, not the file.
23889 2002-10-19 Ravi Pratap <ravi@ximian.com>
23891 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23892 message that we were generating - we just need to silently return
23895 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23897 * class.cs (Event.Define): Change my previous commit, as this
23898 breaks the debugger. This is a temporary hack, as it seems like
23899 the compiler is generating events incorrectly to begin with.
23901 * expression.cs (Binary.ResolveOperator): Added support for
23902 "U operator - (E x, E y)"
23904 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23907 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23908 init-only variables, but this path did not take into account that
23909 there might be also instance readonly variables. Correct this
23912 This fixes bug 32253
23914 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23917 * driver.cs: Change the extension for modules to `netmodule'
23919 * cs-parser.jay: Improved slightly the location tracking for
23920 the debugger symbols.
23922 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23923 modifiers that were specified instead of the hardcoded value
23924 (FamAndAssem). This was basically ignoring the static modifier,
23925 and others. Fixes 32429.
23927 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23928 fixed a bug in the process (32476)
23930 * expression.cs (ArrayAccess.EmitAssign): Patch from
23931 hwang_rob@yahoo.ca that fixes bug 31834.3
23933 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23935 * driver.cs: Make the module extension .netmodule.
23937 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23939 * driver.cs: Report an error if the resource file is not found
23940 instead of crashing.
23942 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23943 false, like Emit does.
23945 2002-10-16 Nick Drochak <ndrochak@gol.com>
23947 * typemanager.cs: Remove unused private member. Also reported mcs
23948 bug to report this as a warning like csc.
23950 2002-10-15 Martin Baulig <martin@gnome.org>
23952 * statement.cs (Statement.Emit): Made this a virtual method; emits
23953 the line number info and calls DoEmit().
23954 (Statement.DoEmit): New protected abstract method, formerly knows
23955 as Statement.Emit().
23957 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23959 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23961 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23962 have fixed a remaining problem: not every AddXXXX was adding a
23963 fully qualified name.
23965 Now everyone registers a fully qualified name in the DeclSpace as
23966 being defined instead of the partial name.
23968 Downsides: we are slower than we need to be due to the excess
23969 copies and the names being registered this way.
23971 The reason for this is that we currently depend (on the corlib
23972 bootstrap for instance) that types are fully qualified, because
23973 we dump all the types in the namespace, and we should really have
23974 types inserted into the proper namespace, so we can only store the
23975 basenames in the defined_names array.
23977 2002-10-10 Martin Baulig <martin@gnome.org>
23979 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23980 from bug #31834, see the bug report for a testcase which is
23983 2002-10-10 Martin Baulig <martin@gnome.org>
23985 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23986 flow analysis code for this.
23988 * statement.cs (Do, While, For): Tell the flow analysis code about
23990 (FlowBranching.UsageVector): Added support for infinite loops.
23991 (Block.Resolve): Moved the dead code elimination here and use flow
23994 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23996 * class.cs (Field.Define): Catch cycles on struct type
23999 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24000 fields if the fields are static. We only need to check instance
24003 * expression.cs (As.DoResolve): Test for reference type.
24005 * statement.cs (Using.ResolveExpression): Use
24006 ConvertImplicitRequired, not ConvertImplicit which reports an
24008 (Using.ResolveLocalVariableDecls): ditto.
24010 * expression.cs (Binary.ResolveOperator): Report errors in a few
24011 places where we had to.
24013 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24015 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24017 * expression.cs: Use StoreFromPtr instead of extracting the type
24018 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24020 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24021 an enumeration value to a System.Enum, but System.Enum is not a
24022 value type, but an class type, so we need to box.
24024 (Expression.ConvertExplicit): One codepath could return
24025 errors but not flag them. Fix this. Fixes #31853
24027 * parameter.cs (Resolve): Do not allow void as a parameter type.
24029 2002-10-06 Martin Baulig <martin@gnome.org>
24031 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24032 if it's a class type and not a struct. Fixes #31815.
24034 2002-10-06 Martin Baulig <martin@gnome.org>
24036 * statement.cs: Reworked the flow analysis code a bit to make it
24037 usable for dead code elimination.
24039 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24041 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24043 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24045 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24046 to fix the test 165, will investigate deeper.
24048 2002-10-04 Martin Baulig <martin@gnome.org>
24050 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24051 finally blocks actually work.
24052 (Try.Resolve): We don't need to create a sibling for `finally' if
24053 there is no finally block.
24055 2002-10-04 Martin Baulig <martin@gnome.org>
24057 * class.cs (Constructor.Define): The default accessibility for a
24058 non-default constructor is private, not public.
24060 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24062 * class.cs (Constructor): Make AllowedModifiers public, add
24065 * cs-parser.jay: Perform the modifiers test here, as the
24066 constructor for the Constructor class usually receives a zero
24067 because of the way we create it (first we create, later we
24068 customize, and we were never checking the modifiers).
24070 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24071 is a version of LookupTypeReflection that includes the type-name
24072 cache. This can be used as a fast path for functions that know
24073 the fully qualified name and are only calling into *.GetType() to
24074 obtain a composed type.
24076 This is also used by TypeManager.LookupType during its type
24079 (LookupType): We now also track the real type name, as sometimes
24080 we can get a quey for the real type name from things like
24081 ComposedCast. This fixes bug 31422.
24083 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24084 complete type fullname, it does not have to go through the type
24085 resolution system to obtain the composed version of the type (for
24086 obtaining arrays or pointers).
24088 (Conditional.Emit): Use the EmitBoolExpression to
24089 generate nicer code, as requested by Paolo.
24091 (ArrayCreation.CheckIndices): Use the patch from
24092 hwang_rob@yahoo.ca to validate the array initializers.
24094 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24096 * class.cs (ConstructorInitializer.Emit): simplify code by using
24097 Invocation.EmitCall, and at the same time, fix the bugs in calling
24098 parent constructors that took variable arguments.
24100 * ecore.cs (Expression.ConvertNumericExplicit,
24101 Expression.ImplicitNumericConversion): Remove the code that
24102 manually wrapped decimal (InternalTypeConstructor call is now gone
24105 * expression.cs (Cast.TryReduce): Also handle decimal types when
24106 trying to perform a constant fold on the type.
24108 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24110 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24111 that only turned off an error report, and did nothing else.
24113 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24115 * driver.cs: Handle and ignore /fullpaths
24117 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24119 * expression.cs (Binary.ResolveOperator): Catch the case where
24120 DoNumericPromotions returns true,
24122 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24124 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24126 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24129 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24131 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24132 conversion exists, but it is also required that the conversion be
24133 performed. This manifested in "(Type64Enum) 2".
24135 * class.cs (TypeManager.AddMethod): The fix is not to change
24136 AddEnum, because that one was using a fully qualified name (every
24137 DeclSpace derivative does), but to change the AddMethod routine
24138 that was using an un-namespaced name. This now correctly reports
24139 the duplicated name.
24141 Revert patch until I can properly fix it. The issue
24142 is that we have a shared Type space across all namespaces
24143 currently, which is wrong.
24145 Options include making the Namespace a DeclSpace, and merge
24146 current_namespace/current_container in the parser.
24148 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24150 * cs-parser.jay: Improve error reporting when we get a different
24151 kind of expression in local_variable_type and
24152 local_variable_pointer_type.
24154 Propagate this to avoid missleading errors being reported.
24156 * ecore.cs (ImplicitReferenceConversion): treat
24157 TypeManager.value_type as a target just like object_type. As
24162 Is valid, and needs to result in the int 1 being boxed before it
24163 is assigned to the value type v.
24165 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24166 to validate the enumeration name.
24168 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24169 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24170 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24172 * ecore.cs (TryImplicitIntConversion): When doing an
24173 implicit-enumeration-conversion, check if the type is 64-bits and
24174 perform a conversion before passing to EnumConstant.
24176 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24178 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24179 report ambiguous type references. Unlike the MS version, we
24180 report what the ambiguity is. Innovation at work ;-)
24182 (DeclSpace.FindType): Require a location argument to
24183 display when we display an ambiguous error.
24185 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24187 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24189 * expression.cs (EmitDynamicInitializers): Apply patch from
24190 hwang_rob@yahoo.ca that fixes the order in which we emit our
24193 2002-09-21 Martin Baulig <martin@gnome.org>
24195 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24196 delegate takes no arguments.
24198 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24200 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24203 * expression.cs: Extract the underlying type.
24205 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24207 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24209 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24211 * class.cs (TypeContainer.DefineType): We can not use the nice
24212 PackingSize with the size set to 1 DefineType method, because it
24213 will not allow us to define the interfaces that the struct
24216 This completes the fixing of bug 27287
24218 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24219 means also structs. This fixes part of the problem.
24220 (Expresion.ImplicitReferenceConversionExists): ditto.
24222 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24223 error if there were no errors reported during the type lookup
24224 process, to avoid duplicates or redundant errors. Without this
24225 you would get an ambiguous errors plus a type not found. We have
24226 beaten the user enough with the first error.
24228 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24231 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24232 during the resolution process, stop the lookup, this avoids
24233 repeated error reports (same error twice).
24235 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24237 * typemanager.cs (LookupType): Redo the type lookup code to match
24238 the needs of System.Reflection.
24240 The issue is that System.Reflection requires references to nested
24241 types to begin with a "+" sign instead of a dot. So toplevel
24242 types look like: "NameSpace.TopLevelClass", and nested ones look
24243 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24246 2002-09-19 Martin Baulig <martin@gnome.org>
24248 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24249 says that a method always returns or always throws an exception,
24250 don't report the CS0161.
24252 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24253 set `Returns = new_returns'.
24255 2002-09-19 Martin Baulig <martin@gnome.org>
24257 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24258 to an enum constant, check for a CS0176.
24260 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24262 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24263 for operators that must be in pairs and report errors.
24265 * ecore.cs (SimpleName.DoResolveType): During the initial type
24266 resolution process, when we define types recursively, we must
24267 check first for types in our current scope before we perform
24268 lookups in the enclosing scopes.
24270 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24272 (Invocation.VerifyArgumentsCompat): Call
24273 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24274 I thought we were supposed to always call this, but there are a
24275 few places in the code where we dont do it.
24277 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24279 * driver.cs: Add support in -linkres and -resource to specify the
24280 name of the identifier.
24282 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24284 * ecore.cs (StandardConversionExists): Sync with the conversion
24285 code: allow anything-* to void* conversions.
24287 (FindMostSpecificSource): Use an Expression argument
24288 instead of a Type, because we might be handed over a Literal which
24289 gets a few more implicit conversions that plain types do not. So
24290 this information was being lost.
24292 Also, we drop the temporary type-holder expression when not
24295 2002-09-17 Martin Baulig <martin@gnome.org>
24297 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24298 this is an explicit interface implementation.
24300 2002-09-17 Martin Baulig <martin@gnome.org>
24302 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24303 different `IndexerName' attributes.
24305 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24306 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24307 virtual CommonResolve().
24309 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24311 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24312 and convert that to the UnderlyingType.
24314 * statement.cs (Foreach.Resolve): Indexers are just like variables
24315 or PropertyAccesses.
24317 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24318 inside quoted strings, we were not doing this before.
24320 2002-09-16 Martin Baulig <martin@gnome.org>
24322 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24323 resolve it. This is needed for the definite assignment check of the
24324 instance expression, fixes bug #29846.
24325 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24327 2002-09-16 Nick Drochak <ndrochak@gol.com>
24329 * parameter.cs: Fix compile error. Cannot reference static member
24330 from an instance object. Is this an mcs bug?
24332 2002-09-14 Martin Baulig <martin@gnome.org>
24334 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24335 multiple times. Fixes bug #30295, added test-166.cs.
24337 2002-09-14 Martin Baulig <martin@gnome.org>
24339 * statement.cs (Block.Emit): Don't emit unreachable code.
24340 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24341 `break' statements.
24342 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24344 2002-09-14 Martin Baulig <martin@gnome.org>
24346 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24349 2002-09-14 Martin Baulig <martin@gnome.org>
24351 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24352 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24353 be false on the ms runtime.
24355 2002-09-13 Martin Baulig <martin@gnome.org>
24357 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24358 the CS0038 error message.
24360 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24362 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24363 constant inside, return it.
24365 2002-09-12 Martin Baulig <martin@gnome.org>
24367 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24368 implicit conversion can be done between enum types.
24370 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24371 check whether an implicit conversion to the current enum's UnderlyingType
24372 exists and report an error if not.
24374 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24375 without debugging support.
24377 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24378 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24380 2002-09-12 Martin Baulig <martin@gnome.org>
24382 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24384 * ecore.cs (IMemberExpr.DeclaringType): New property.
24385 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24386 nonstatic member of an outer type (CS0038).
24388 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24390 * driver.cs: Activate the using-error detector at warning level
24391 4 (at least for MS-compatible APIs).
24393 * namespace.cs (VerifyUsing): Small buglett fix.
24395 * pending.cs (PendingImplementation): pass the container pointer.
24397 * interface.cs (GetMethods): Allow for recursive definition. Long
24398 term, I would like to move every type to support recursive
24399 definitions, not the current ordering mechanism that we have right
24402 The situation is this: Attributes are handled before interfaces,
24403 so we can apply attributes to interfaces. But some attributes
24404 implement interfaces, we will now handle the simple cases
24405 (recursive definitions will just get an error).
24407 * parameter.cs: Only invalidate types at the end if we fail to
24410 2002-09-09 Martin Baulig <martin@gnome.org>
24412 * ecore.cs (PropertyExpr.Emit): Also check for
24413 TypeManager.system_int_array_get_length so this'll also work when
24414 compiling corlib. Fixes #30003.
24416 2002-09-09 Martin Baulig <martin@gnome.org>
24418 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24419 and throw an exception if we can't get the type's size. Fixed #30040,
24422 2002-09-09 Martin Baulig <martin@gnome.org>
24424 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24426 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24427 context. Fixes bug #30027.
24429 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24430 virtual functions. Fixes bug #30043, added test-164.cs.
24432 2002-09-08 Ravi Pratap <ravi@ximian.com>
24434 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24436 2002-09-08 Nick Drochak <ndrochak@gol.com>
24438 * driver.cs: Use an object to get the windows codepage since it's not a
24441 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24443 * statement.cs (For.Emit): for infinite loops (test == null)
24444 return whether there is a break inside, not always "true".
24446 * namespace.cs (UsingEntry): New struct to hold the name of the
24447 using definition, the location where it is defined, and whether it
24448 has been used in a successful type lookup.
24450 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24455 2002-09-06 Ravi Pratap <ravi@ximian.com>
24457 * attribute.cs : Fix incorrect code which relied on catching
24458 a NullReferenceException to detect a null being passed in
24459 where an object was expected.
24461 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24463 * statement.cs (Try): flag the catch variable as assigned
24465 * expression.cs (Cast): Simplified by using ResolveType instead of
24466 manually resolving.
24468 * statement.cs (Catch): Fix bug by using ResolveType.
24470 2002-09-06 Ravi Pratap <ravi@ximian.com>
24472 * expression.cs (BetterConversion): Special case for when we have
24473 a NullLiteral as the argument and we have to choose between string
24474 and object types - we choose string the way csc does.
24476 * attribute.cs (Attribute.Resolve): Catch the
24477 NullReferenceException and report error #182 since the Mono
24478 runtime no more has the bug and having this exception raised means
24479 we tried to select a constructor which takes an object and is
24482 2002-09-05 Ravi Pratap <ravi@ximian.com>
24484 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24485 message (1502, 1503) when we can't locate a method after overload
24486 resolution. This is much more informative and closes the bug
24489 * interface.cs (PopulateMethod): Return if there are no argument
24490 types. Fixes a NullReferenceException bug.
24492 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24493 expressions too. Previously we were checking only in one place for
24494 positional arguments leaving out named arguments.
24496 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24497 type to the enum type is not allowed. Remove code corresponding to
24500 (ConvertNumericExplicit): Allow explicit conversions from
24501 the underlying type to enum type. This precisely follows the spec
24502 and closes a bug filed by Gonzalo.
24504 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24507 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24509 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24511 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24512 it was important that we stored the right value after the
24513 reduction in `converted'.
24515 2002-09-04 Martin Baulig <martin@gnome.org>
24517 * location.cs (Location.SymbolDocument): Use full pathnames for the
24520 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24522 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24523 of the expression resolve mechanism, because that will catch the
24524 SimpleName error failures.
24526 (Conditional): If we can not resolve the
24527 expression, return, do not crash.
24529 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24532 (location): display token name instead of its number.
24534 2002-08-28 Martin Baulig <martin@gnome.org>
24536 * expression.cs (Binary.ResolveOperator): Don't silently return
24537 but return an error if an operator cannot be applied between two
24540 2002-08-28 Martin Baulig <martin@gnome.org>
24542 * class.cs (Constructor.Define): Set the permission attributes
24543 correctly instead of making all constructors public.
24545 2002-08-28 Martin Baulig <martin@gnome.org>
24547 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24548 for private members before reporting a CS0103; if we find anything,
24551 2002-08-28 Martin Baulig <martin@gnome.org>
24553 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24554 to check whether `closure_start_type == closure_invocation_type',
24555 we also need to check whether `m.DeclaringType == closure_invocation_type'
24556 before bypassing the permission checks. We might be accessing
24557 protected/private members from the base class.
24558 (TypeManager.RealMemberLookup): Only set private_ok if private
24559 members were requested via BindingFlags.NonPublic.
24561 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24563 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24564 MethodGroupExpr.IsExplicitImpl if appropriate.
24565 (Invocation.DoResolve): Don't report the CS0120 for explicit
24566 interface implementations.
24568 2002-08-27 Martin Baulig <martin@gnome.org>
24570 * expression.cs (Invocation.DoResolve): If this is a static
24571 method and we don't have an InstanceExpression, we must report
24574 2002-08-25 Martin Baulig <martin@gnome.org>
24576 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24577 `==' between a valuetype and an object.
24579 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24581 * ecore.cs (TypeExpr): Provide a ToString method.
24583 2002-08-24 Martin Baulig <martin@gnome.org>
24585 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24586 now called proggie.dbg and it's a binary file.
24588 2002-08-23 Martin Baulig <martin@gnome.org>
24590 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24592 2002-08-23 Martin Baulig <martin@gnome.org>
24594 * struct.cs (MyStructInfo.ctor): Make this work with empty
24595 structs; it's not allowed to use foreach() on null.
24597 2002-08-23 Martin Baulig <martin@gnome.org>
24599 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24600 writer the full pathname of the generated assembly.
24602 2002-08-23 Martin Baulig <martin@gnome.org>
24604 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24605 A `finally' block never returns or breaks; improved handling of
24608 2002-08-23 Martin Baulig <martin@gnome.org>
24610 * statement.cs (Throw.Resolve): Allow `throw null'.
24612 2002-08-23 Martin Baulig <martin@gnome.org>
24614 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24615 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24616 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24617 MemberLookup would return a wrong event if this is an explicit
24618 interface implementation and the class has an event with the same
24621 2002-08-23 Martin Baulig <martin@gnome.org>
24623 * statement.cs (Block.AddChildVariableNames): New public method.
24624 (Block.AddChildVariableName): Likewise.
24625 (Block.IsVariableNameUsedInChildBlock): Likewise.
24626 (Block.AddVariable): Check whether a variable name has already
24627 been used in a child block.
24629 * cs-parser.jay (declare_local_variables): Mark all variable names
24630 from the current block as being used in a child block in the
24633 2002-08-23 Martin Baulig <martin@gnome.org>
24635 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24636 find the symbol writer.
24638 * driver.cs: csc also allows the arguments to /define being
24639 separated by commas, not only by semicolons.
24641 2002-08-23 Martin Baulig <martin@gnome.org>
24643 * interface.cs (Interface.GetMembers): Added static check for events.
24645 2002-08-15 Martin Baulig <martin@gnome.org>
24647 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24648 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24650 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24651 why the MethodData.EmitDestructor() change was necessary.
24653 2002-08-20 Martin Baulig <martin@gnome.org>
24655 * class.cs (TypeContainer.FindMembers): Added static check for events.
24657 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24659 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24660 use Type.GetEvents(), not Type.FindMembers().
24662 2002-08-20 Martin Baulig <martin@gnome.org>
24664 * decl.cs (MemberCache): Added a special method cache which will
24665 be used for method-only searched. This ensures that a method
24666 search will return a MethodInfo with the correct ReflectedType for
24669 2002-08-20 Martin Baulig <martin@gnome.org>
24671 * decl.cs (DeclSpace.FindMembers): Made this public.
24673 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24675 * delegate.cs: fixed build on windows.
24676 [FIXME: Filed as bug #29150: MCS must report these errors.]
24678 2002-08-19 Ravi Pratap <ravi@ximian.com>
24680 * ecore.cs (StandardConversionExists): Return a false
24681 if we are trying to convert the void type to anything else
24682 since that is not allowed.
24684 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24685 we flag error 70 in the event an event is trying to be accessed
24686 directly from outside the declaring type.
24688 2002-08-20 Martin Baulig <martin@gnome.org>
24690 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24691 MemberCache from typemanager.cs to decl.cs.
24693 2002-08-19 Martin Baulig <martin@gnome.org>
24695 * class.cs (TypeContainer): Implement IMemberContainer.
24696 (TypeContainer.DefineMembers): Create the MemberCache.
24697 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24698 return public members if BindingFlags.Public was given, check
24699 whether members are static.
24701 2002-08-16 Martin Baulig <martin@gnome.org>
24703 * decl.cs (DeclSpace.Define): Splitted this in Define and
24704 DefineMembers. DefineMembers is called first and initializes the
24707 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24708 DefineMembers() on all our DeclSpaces.
24710 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24711 but call DefineMembers() on all nested interfaces. We call their
24712 Define() in our new Define() function.
24714 * interface.cs (Interface): Implement IMemberContainer.
24715 (Interface.Define): Moved all code except the attribute stuf to
24717 (Interface.DefineMembers): Initialize the member cache.
24719 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24720 need this anymore since we can use MemberCache.FindMembers directly.
24722 2002-08-19 Martin Baulig <martin@gnome.org>
24724 * typemanager.cs (MemberCache): When creating the cache for an
24725 interface type, add all inherited members.
24726 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24727 to `out bool used_cache' and documented it.
24728 (TypeManager.MemberLookup): If we already used the cache in the first
24729 iteration, we don't need to do the interfaces check.
24731 2002-08-19 Martin Baulig <martin@gnome.org>
24733 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24734 here from IMemberFinder and don't implement this interface anymore.
24735 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24737 * typemanager.cs (IMemberFinder): This interface is now only used by
24738 classes which actually support the member cache.
24739 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24740 since we only put DeclSpaces into this Hashtable.
24741 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24742 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24744 2002-08-16 Martin Baulig <martin@gnome.org>
24746 * typemanager.cs (ICachingMemberFinder): Removed.
24747 (IMemberFinder.MemberCache): New property.
24748 (TypeManager.FindMembers): Merged this with RealFindMembers().
24749 This function will never be called from TypeManager.MemberLookup()
24750 so we can't use the cache here, just the IMemberFinder.
24751 (TypeManager.MemberLookup_FindMembers): Check whether the
24752 IMemberFinder has a MemberCache and call the cache's FindMembers
24754 (MemberCache): Rewrote larger parts of this yet another time and
24755 cleaned it up a bit.
24757 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24759 * driver.cs (LoadArgs): Support quoting.
24761 (Usage): Show the CSC-like command line arguments.
24763 Improved a few error messages.
24765 2002-08-15 Martin Baulig <martin@gnome.org>
24767 * typemanager.cs (IMemberContainer.Type): New property.
24768 (IMemberContainer.IsInterface): New property.
24770 The following changes are conditional to BROKEN_RUNTIME, which is
24771 defined at the top of the file.
24773 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24774 class'es members, but add all members from TypeHandle.ObjectType
24775 if we're an interface.
24776 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24777 is the current type.
24778 (MemberCache.CacheEntry.Container): Removed this field.
24779 (TypeHandle.GetMembers): Include inherited members.
24781 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24783 * typemanager.cs: fixed compilation and added a comment on a field that
24786 2002-08-15 Martin Baulig <martin@gnome.org>
24788 * class.cs (ConstructorInitializer.Resolve): In the
24789 Expression.MemberLookup call, use the queried_type as
24792 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24793 declared' attribute, it's always true.
24794 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24795 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24796 temporary wrapper for FindMembers which tells MemberLookup whether
24797 members from the base classes are included in the return value.
24798 This will go away soon.
24799 (TypeManager.MemberLookup): Use this temporary hack here; once the
24800 new MemberCache is completed, we don't need to do the DeclaredOnly
24801 looping here anymore since the MemberCache will take care of this.
24802 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24803 (MemberCache): When creating the MemberCache for a class, get
24804 members from the current class and all its base classes.
24805 (MemberCache.CacheEntry.Container): New field. This is a
24806 temporary hack until the Mono runtime is fixed to distinguish
24807 between ReflectedType and DeclaringType. It allows us to use MCS
24808 with both the MS runtime and the unfixed Mono runtime without
24809 problems and without accecting performance.
24810 (MemberCache.SearchMembers): The DeclaredOnly looping from
24811 TypeManager.MemberLookup is now done here.
24813 2002-08-14 Martin Baulig <martin@gnome.org>
24815 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24816 Type.GetFields on dynamic types but get the fields from the
24817 corresponding TypeContainer.
24818 (MyStructInfo.GetStructInfo): Added check for enum types.
24820 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24821 (MemberList.SyncRoot): Implemented.
24822 (TypeManager.FilterWithClosure): No need to check permissions if
24823 closure_start_type == closure_invocation_type, don't crash if
24824 closure_invocation_type is null.
24826 2002-08-13 Martin Baulig <martin@gnome.org>
24828 Rewrote TypeContainer.FindMembers to use a member cache. This
24829 gives us a speed increase of about 35% for the self-hosting MCS
24830 build and of about 15-20% for the class libs (both on GNU/Linux).
24832 * report.cs (Timer): New class to get enhanced profiling. This
24833 whole class is "TIMER" conditional since it remarkably slows down
24836 * class.cs (MemberList): New class. This is an IList wrapper
24837 which we're now using instead of passing MemberInfo[]'s around to
24838 avoid copying this array unnecessarily.
24839 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24840 (ICachingMemberFinder, IMemberContainer): New interface.
24841 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24842 has already been checked, otherwise use it for the name comparision.
24843 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24844 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24845 if possible. Returns a MemberList, not a MemberInfo [].
24846 (TypeHandle): New class, implements IMemberContainer. We create
24847 one instance of this class per type, it contains a MemberCache
24848 which is used to do the member lookups.
24849 (MemberCache): New class. Each instance of this class contains
24850 all members of a type and a name-based hash table.
24851 (MemberCache.FindMembers): This is our new member lookup
24852 function. First, it looks up all members of the requested name in
24853 the hash table. Then, it walks this list and sorts out all
24854 applicable members and returns them.
24856 2002-08-13 Martin Baulig <martin@gnome.org>
24858 In addition to a nice code cleanup, this gives us a performance
24859 increase of about 1.4% on GNU/Linux - not much, but it's already
24860 half a second for the self-hosting MCS compilation.
24862 * typemanager.cs (IMemberFinder): New interface. It is used by
24863 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24864 Enum, Delegate or Interface.
24865 (TypeManager.finder_to_member_finder): New PtrHashtable.
24866 (TypeManager.finder_to_container): Removed.
24867 (TypeManager.finder_to_delegate): Removed.
24868 (TypeManager.finder_to_interface): Removed.
24869 (TypeManager.finder_to_enum): Removed.
24871 * interface.cs (Interface): Implement IMemberFinder.
24873 * delegate.cs (Delegate): Implement IMemberFinder.
24875 * enum.cs (Enum): Implement IMemberFinder.
24877 * class.cs (TypeContainer): Implement IMemberFinder.
24879 2002-08-12 Martin Baulig <martin@gnome.org>
24881 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24883 2002-08-12 Martin Baulig <martin@gnome.org>
24885 * ecore.cs (ITypeExpression): New interface for expressions which
24887 (TypeExpression): Renamed to TypeLookupExpression.
24888 (Expression.DoResolve): If we're doing a types-only lookup, the
24889 expression must implement the ITypeExpression interface and we
24890 call DoResolveType() on it.
24891 (SimpleName): Implement the new ITypeExpression interface.
24892 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24893 hack, the situation that we're only looking up types can't happen
24894 anymore when this method is called. Moved the type lookup code to
24895 DoResolveType() and call it.
24896 (SimpleName.DoResolveType): This ITypeExpression interface method
24897 is now doing the types-only lookup.
24898 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24899 (ResolveFlags): Added MaskExprClass.
24901 * expression.cs (MemberAccess): Implement the ITypeExpression
24903 (MemberAccess.DoResolve): Added support for a types-only lookup
24904 when we're called via ITypeExpression.DoResolveType().
24905 (ComposedCast): Implement the ITypeExpression interface.
24907 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24908 Expression.Resolve() with ResolveFlags.Type instead.
24910 2002-08-12 Martin Baulig <martin@gnome.org>
24912 * interface.cs (Interface.Define): Apply attributes.
24914 * attribute.cs (Attribute.ApplyAttributes): Added support for
24915 interface attributes.
24917 2002-08-11 Martin Baulig <martin@gnome.org>
24919 * statement.cs (Block.Emit): Only check the "this" variable if we
24920 do not always throw an exception.
24922 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24923 whether the property has a set accessor.
24925 2002-08-11 Martin Baulig <martin@gnome.org>
24927 Added control flow analysis support for structs.
24929 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24930 with control flow analysis turned off.
24931 (IVariable): New interface.
24932 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24933 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24934 (FieldExpr.DoResolve): Resolve the instance expression with flow
24935 analysis turned off and do the definite assignment check after the
24936 resolving when we know what the expression will resolve to.
24938 * expression.cs (LocalVariableReference, ParameterReference):
24939 Implement the new IVariable interface, only call the flow analysis
24940 code if ec.DoFlowAnalysis is true.
24941 (This): Added constructor which takes a Block argument. Implement
24942 the new IVariable interface.
24943 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24944 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24945 This does the definite assignment checks for struct members.
24947 * class.cs (Constructor.Emit): If this is a non-static `struct'
24948 constructor which doesn't have any initializer, call
24949 Block.AddThisVariable() to tell the flow analysis code that all
24950 struct elements must be initialized before control returns from
24953 * statement.cs (MyStructInfo): New public class.
24954 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24955 argument to this indexer. If non-zero, check an individual struct
24956 member, not the whole struct.
24957 (FlowBranching.CheckOutParameters): Check struct members.
24958 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24959 overloaded versions of these methods which take an additional
24960 `int field_idx' argument to check struct members.
24961 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24962 overloaded versions of these methods which take an additional
24963 `string field_name' argument to check struct member.s
24964 (VariableInfo): Implement the IVariable interface.
24965 (VariableInfo.StructInfo): New public property. Returns the
24966 MyStructInfo instance of the variable if it's a struct or null.
24967 (Block.AddThisVariable): New public method. This is called from
24968 Constructor.Emit() for non-static `struct' constructor which do
24969 not have any initializer. It creates a special variable for the
24970 "this" instance variable which will be checked by the flow
24971 analysis code to ensure that all of the struct's fields are
24972 initialized before control returns from the constructor.
24973 (UsageVector): Added support for struct members. If a
24974 variable/parameter is a struct with N members, we reserve a slot
24975 in the usage vector for each member. A struct is considered fully
24976 initialized if either the struct itself (slot 0) or all its
24977 members are initialized.
24979 2002-08-08 Martin Baulig <martin@gnome.org>
24981 * driver.cs (Driver.MainDriver): Only report an error CS5001
24982 if there were no compilation errors.
24984 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24985 `UnsafeContext' property to determine whether the parent is in
24986 unsafe context rather than checking the parent's ModFlags:
24987 classes nested in an unsafe class are unsafe as well.
24989 2002-08-08 Martin Baulig <martin@gnome.org>
24991 * statement.cs (UsageVector.MergeChildren): Distinguish between
24992 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24993 we return. Added test17() and test18() to test-154.cs.
24995 2002-08-08 Martin Baulig <martin@gnome.org>
24997 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24998 Family access, make sure the invoking type isn't a subclass of the
24999 queried type (that'd be a CS1540).
25001 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25002 this method which takes an additional `Type invocation_type'.
25004 * expression.cs (BaseAccess.DoResolve): Use the base type as
25005 invocation and query type.
25006 (MemberAccess.DoResolve): If the lookup failed and we're about to
25007 report a CS0122, try a lookup with the ec.ContainerType - if this
25008 succeeds, we must report a CS1540.
25010 2002-08-08 Martin Baulig <martin@gnome.org>
25012 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25013 (MethodGroupExpr): Implement the IMemberExpr interface.
25015 * expression (MemberAccess.ResolveMemberAccess): No need to have
25016 any special code for MethodGroupExprs anymore, they're now
25019 2002-08-08 Martin Baulig <martin@gnome.org>
25021 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25022 Family, FamANDAssem and FamORAssem permissions.
25023 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25025 2002-08-08 Martin Baulig <martin@gnome.org>
25027 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25028 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25031 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25033 * driver.cs: implemented /resource option to embed managed resources.
25035 2002-08-07 Martin Baulig <martin@gnome.org>
25037 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25038 (FieldBase.HasFieldInitializer): New public property.
25039 (FieldBase.GetInitializerExpression): New public method. Resolves and
25040 returns the field initializer and makes sure it is only resolved once.
25041 (TypeContainer.EmitFieldInitializers): Call
25042 FieldBase.GetInitializerExpression to get the initializer, this ensures
25043 that it isn't resolved multiple times.
25045 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25046 the resolving process (SimpleName/MemberLookup) that we're currently
25047 emitting a field initializer (which must not access any instance members,
25048 this is an error CS0236).
25050 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25051 argument, if the `IsFieldInitializer' flag is set, we must report and
25052 error CS0236 and not an error CS0120.
25054 2002-08-07 Martin Baulig <martin@gnome.org>
25056 * ecore.cs (IMemberExpr): New public interface.
25057 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25058 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25059 if the expression is an IMemberExpr.
25061 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25062 to be null, implicitly default to `this' if we're non-static in
25063 this case. Simplified the code a lot by using the new IMemberExpr
25064 interface. Also fixed bug #28176 here.
25066 2002-08-06 Martin Baulig <martin@gnome.org>
25068 * cs-parser.jay (SimpleLookup): Removed. We need to create
25069 ParameterReferences during semantic analysis so that we can do a
25070 type-only search when resolving Cast, TypeOf and SizeOf.
25071 (block): Pass the `current_local_parameters' to the Block's
25074 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25075 argument to the constructor.
25076 (ConstructorInitializer.Resolve): Create a temporary implicit
25077 block with the parameters.
25079 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25080 references here if we aren't doing a type-only search.
25082 * statement.cs (Block): Added constructor which takes a
25083 `Parameters parameters' argument.
25084 (Block.Parameters): New public property.
25086 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25087 to `Parameters' and made it public readonly.
25089 2002-08-06 Martin Baulig <martin@gnome.org>
25091 * ecore.cs (Expression.Warning): Made this public as well.
25093 * report.cs (Report.Debug): Print the contents of collections.
25095 2002-08-06 Martin Baulig <martin@gnome.org>
25097 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25098 used to tell Resolve() which kinds of expressions it may return.
25099 (Expression.Resolve): Added overloaded version of this method which
25100 takes a `ResolveFlags flags' argument. This can be used to tell
25101 Resolve() which kinds of expressions it may return. Reports a
25103 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25104 ResolveFlags.SimpleName.
25105 (Expression.Error118): Added overloaded version of this method which
25106 takes a `ResolveFlags flags' argument. It uses the flags to determine
25107 which kinds of expressions are allowed.
25109 * expression.cs (Argument.ResolveMethodGroup): New public method.
25110 Resolves an argument, but allows a MethodGroup to be returned.
25111 This is used when invoking a delegate.
25113 * TODO: Updated a bit.
25115 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25117 Fixed compilation with csc.
25119 * ecore.cs: Expression.Error made public. Is this correct? Should
25120 Warning be made public too?
25122 * expression.cs: use ea.Location instead of ea.loc.
25123 [FIXME: Filed as bug #28607: MCS must report these errors.]
25125 2002-08-06 Martin Baulig <martin@gnome.org>
25127 * ecore.cs (Expression.loc): Moved the location here instead of
25128 duplicating it in all derived classes.
25129 (Expression.Location): New public property.
25130 (Expression.Error, Expression.Warning): Made them non-static and
25131 removed the location argument.
25132 (Expression.Warning): Added overloaded version which takes an
25133 `int level' argument.
25134 (Expression.Error118): Make this non-static and removed the
25135 expression and location arguments.
25136 (TypeExpr): Added location argument to the constructor.
25138 * expression.cs (StaticCallExpr): Added location argument to
25140 (Indirection, PointerArithmetic): Likewise.
25141 (CheckedExpr, UnCheckedExpr): Likewise.
25142 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25143 (StringPtr): Likewise.
25146 2002-08-05 Martin Baulig <martin@gnome.org>
25148 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25150 * assign.cs (Assign.DoResolve): Check whether the source
25151 expression is a value or variable.
25153 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25154 while resolving the corresponding blocks.
25156 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25157 an error, don't silently return null.
25159 * statement.cs (Block.AddVariable): Do the error reporting here
25160 and distinguish between CS0128 and CS0136.
25161 (Block.DoResolve): Report all unused labels (warning CS0164).
25162 (LabeledStatement): Pass the location to the constructor.
25163 (LabeledStatement.HasBeenReferenced): New property.
25164 (LabeledStatement.Resolve): Set it to true here.
25166 * statement.cs (Return.Emit): Return success even after reporting
25167 a type mismatch error (CS0126 or CS0127), this is what csc does and
25168 it avoids confusing the users with any consecutive errors.
25170 2002-08-05 Martin Baulig <martin@gnome.org>
25172 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25174 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25176 * expression.cs (MemberAccess.DoResolve): Silently return if an
25177 error has already been reported.
25179 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25180 error has already been reported.
25182 2002-08-05 Martin Baulig <martin@gnome.org>
25184 * statement.cs (UsageVector): Only initialize the `parameters'
25185 vector if we actually have any "out" parameters.
25187 2002-08-05 Martin Baulig <martin@gnome.org>
25189 * expression.cs (Binary.ResolveOperator): When combining delegates,
25190 they must have the same type.
25192 2002-08-05 Martin Baulig <martin@gnome.org>
25194 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25195 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25196 work with the ms runtime and we also don't need it: if we're a
25197 PropertyBuilder and not in the `indexer_arguments' hash, then we
25198 are a property and not an indexer.
25200 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25201 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25202 since the latter one doesn't work with the ms runtime.
25204 2002-08-03 Martin Baulig <martin@gnome.org>
25206 Fixed bugs #27998 and #22735.
25208 * class.cs (Method.IsOperator): New public field.
25209 (Method.CheckBase): Report CS0111 if there's already a method
25210 with the same parameters in the current class. Report CS0508 when
25211 attempting to change the return type of an inherited method.
25212 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25213 and it's not marked abstract or extern.
25214 (PropertyBase): New abstract base class for Property and Indexer.
25215 (PropertyBase.CheckBase): Moved here from Property and made it work
25217 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25218 the same so we can reuse it there.
25219 (Property, Indexer): Derive from PropertyBase.
25220 (MethodSignature.inheritable_property_signature_filter): New delegate
25221 to find properties and indexers.
25223 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25224 argument and improved error reporting.
25226 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25227 EmptyReadOnlyParameters and made it a property.
25229 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25230 version of this method which takes a `PropertyInfo indexer'.
25231 (TypeManager.RegisterIndexer): New method.
25233 * class.cs: Added myself as author of this file :-)
25235 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25237 * class.cs: fixed compilation on windoze.
25239 2002-08-03 Martin Baulig <martin@gnome.org>
25241 * interface.cs (Interface.GetInterfaceBases): Check whether all
25242 base interfaces are at least as accessible than the current one.
25244 * class.cs (TypeContainer.GetClassBases): Check whether base types
25245 are at least as accessible than the current type.
25246 (TypeContainer.AsAccessible): Implemented and made non-static.
25247 (MemberBase.CheckParameters): Report errors if the accessibility
25250 * delegate.cs (Delegate.Delegate): The default visibility is
25251 internal for top-level types and private for nested types.
25252 (Delegate.Define): Report errors if the accessibility checks fail.
25254 * enum.cs (Enum.Enum): The default visibility is internal for
25255 top-level types and private for nested types.
25256 (Enum.DefineType): Compute the correct visibility.
25258 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25259 function which takes a `bool is_toplevel' instead of a TypeContainer.
25261 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25264 2002-08-02 Martin Baulig <martin@gnome.org>
25266 * expression.cs (LocalVariableReferenc): Added constructor which
25267 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25268 (LocalVariableReference.IsReadOnly): New property.
25269 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25270 variable is readonly, use our own readonly flag to do this; you can
25271 use the new constructor to get a writable reference to a read-only
25274 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25275 reference to the local variable.
25277 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25279 * rootcontext.cs (ResolveCore): Also include System.Exception
25281 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25282 we reach an EmptyStatement.
25284 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25287 * expression.cs (Binary.ResolveOperator): Check error result in
25290 use brtrue/brfalse directly and avoid compares to null.
25292 2002-08-02 Martin Baulig <martin@gnome.org>
25294 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25295 Fixes bug #28407, added test-155.cs.
25297 2002-08-01 Martin Baulig <martin@gnome.org>
25299 * class.cs (Event.EmitDefaultMethod): Make this work with static
25300 events. Fixes #28311, added verify-3.cs.
25302 2002-08-01 Martin Baulig <martin@gnome.org>
25304 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25305 `is_disposable' fields.
25306 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25307 `hm.is_disposable' if we're using the collection pattern.
25308 (Foreach.EmitCollectionForeach): Use the correct type for the
25309 enumerator's local variable, only emit the try/finally block if
25310 necessary (fixes #27713).
25312 2002-08-01 Martin Baulig <martin@gnome.org>
25314 * ecore.cs (Expression.report118): Renamed to Error118 and made
25317 * statement.cs (Throw.Resolve): Check whether the expression is of
25318 the correct type (CS0118) and whether the type derives from
25319 System.Exception (CS0155).
25320 (Catch.Resolve): New method. Do the type lookup here and check
25321 whether it derives from System.Exception (CS0155).
25322 (Catch.CatchType, Catch.IsGeneral): New public properties.
25324 * typemanager.cs (TypeManager.exception_type): Added.
25326 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25328 * driver.cs: Updated About function.
25330 2002-07-31 Martin Baulig <martin@gnome.org>
25332 Implemented Control Flow Analysis.
25334 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25335 (EmitContext.CurrentBranching): Added.
25336 (EmitContext.StartFlowBranching): Added.
25337 (EmitContext.EndFlowBranching): Added.
25338 (EmitContext.KillFlowBranching): Added.
25339 (EmitContext.IsVariableAssigned): Added.
25340 (EmitContext.SetVariableAssigned): Added.
25341 (EmitContext.IsParameterAssigned): Added.
25342 (EmitContext.SetParameterAssigned): Added.
25343 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25344 Added control flow analysis stuff here.
25346 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25347 resolve the expression as lvalue.
25348 (LocalVariableReference.DoResolve): Check whether the variable has
25349 already been assigned.
25350 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25351 the parameter as assigned here.
25352 (ParameterReference.DoResolve): Check whether the parameter has already
25354 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25355 expression as lvalue.
25357 * statement.cs (FlowBranching): New class for the flow analysis code.
25358 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25359 (LabeledStatement.IsDefined): New public property.
25360 (LabeledStatement.AddUsageVector): New public method to tell flow
25361 analyis that the label may be reached via a forward jump.
25362 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25364 (VariableInfo.Number): New public field. This is used by flow analysis
25365 to number all locals of a block.
25366 (Block.CountVariables): New public property. This is the number of
25367 local variables in this block (including the locals from all parent
25369 (Block.EmitMeta): Number all the variables.
25371 * statement.cs: Added flow analysis support to all classes.
25373 2002-07-31 Martin Baulig <martin@gnome.org>
25375 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25376 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25377 then use this argument.
25379 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25381 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25382 use this to specify /define options.
25384 2002-07-29 Martin Baulig <martin@gnome.org>
25386 * statement.cs (Fixed): Moved all code that does variable lookups
25387 and resolvings from Emit to Resolve.
25389 * statement.cs (For): Moved all code that does variable lookups
25390 and resolvings from Emit to Resolve.
25392 * statement.cs (Using): Moved all code that does variable lookups
25393 and resolvings from Emit to Resolve.
25395 2002-07-29 Martin Baulig <martin@gnome.org>
25397 * attribute.cs (Attribute.Resolve): Explicitly catch a
25398 System.NullReferenceException when creating the
25399 CustromAttributeBuilder and report a different warning message.
25401 2002-07-29 Martin Baulig <martin@gnome.org>
25403 * support.cs (ParameterData.ParameterName): Added method to
25404 get the name of a parameter.
25406 * typemanager.cs (TypeManager.IsValueType): New public method.
25408 2002-07-29 Martin Baulig <martin@gnome.org>
25410 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25411 is a flag which specifies that it's either ref or out.
25412 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25413 the out parameter to `out Parameter.Modifier mod', also set the
25414 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25416 * support.cs (InternalParameters.ParameterModifier): Distinguish
25417 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25418 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25420 * expression.cs (Argument.GetParameterModifier): Distinguish
25421 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25422 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25424 2002-07-29 Martin Baulig <martin@gnome.org>
25426 * expression.cs (ParameterReference.ParameterReference): Added
25427 `Location loc' argument to the constructor.
25429 * cs-parser.jay: Pass location to ParameterReference.
25431 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25433 * statement.cs (Try): Initialize the location.
25435 * cs-parser.jay: pass location to Try.
25437 * expression.cs (Unary.Reduce): Change the prototype to return
25438 whether a constant fold could be performed or not. The result is
25439 returned in an out parameters. In the case of Indirection and
25440 AddressOf, we want to perform the full tests.
25442 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25444 * statement.cs (Statement.Emit): Flag dead code.
25446 2002-07-27 Andrew Birkett <andy@nobugs.org>
25448 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25450 2002-07-27 Martin Baulig <martin@gnome.org>
25452 * class.cs (MethodData.Define): Put back call to
25453 TypeManager.AddMethod(), accidentally commented this out.
25455 * report.cs (Debug): New public method to print debugging information,
25456 this is `[Conditional ("DEBUG")]'.
25458 2002-07-26 Martin Baulig <martin@gnome.org>
25460 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25461 (switch_statement): Push the current_block to the switch_stack and
25462 pop it again when we're done with the switch.
25463 (switch_section): The new block is a child of the current_block.
25464 Fixes bug #24007, added test-152.cs.
25466 2002-07-27 Martin Baulig <martin@gnome.org>
25468 * expression.cs (Invocation.EmitArguments): When calling a varargs
25469 function with only its fixed arguments, we need to pass an empty
25472 2002-07-27 Martin Baulig <martin@gnome.org>
25474 Mono 0.13 has been released.
25476 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25478 * driver.cs: Rename --resource to --linkres, because that is what
25479 we do currently, we dont support --resource yet.
25481 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25483 2002-07-25 Martin Baulig <martin@gnome.org>
25485 * class.cs (MethodData): New public class. This is a `method builder'
25486 class for a method or one accessor of a Property/Indexer/Event.
25487 (MethodData.GetMethodFlags): Moved here from MemberBase.
25488 (MethodData.ApplyAttributes): Likewise.
25489 (MethodData.ApplyObsoleteAttribute): Likewise.
25490 (MethodData.ApplyConditionalAttribute): Likewise.
25491 (MethodData.ApplyDllImportAttribute): Likewise.
25492 (MethodData.CheckAbstractAndExternal): Likewise.
25493 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25494 (MethodData.Emit): Formerly known as Method.Emit().
25495 (MemberBase): Moved everything which was specific to a single
25496 accessor/method to MethodData.
25497 (Method): Create a new MethodData and call Define() and Emit() on it.
25498 (Property, Indexer, Event): Create a new MethodData objects for each
25499 accessor and call Define() and Emit() on them.
25501 2002-07-25 Martin Baulig <martin@gnome.org>
25503 Made MethodCore derive from MemberBase to reuse the code from there.
25504 MemberBase now also checks for attributes.
25506 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25507 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25509 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25510 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25511 (MemberBase.ApplyAttributes): New virtual method; applies the
25512 attributes to a method or accessor.
25513 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25514 (MemberBase.ApplyConditionalAttribute): Likewise.
25515 (MemberBase.ApplyDllImportAttribute): Likewise.
25516 (MemberBase.CheckAbstractAndExternal): Likewise.
25517 (MethodCore.ParameterTypes): This is now a property instead of a
25518 method, it's initialized from DoDefineParameters().
25519 (MethodCore.ParameterInfo): Removed the set accessor.
25520 (MethodCore.DoDefineParameters): New protected virtual method to
25521 initialize ParameterTypes and ParameterInfo.
25522 (Method.GetReturnType): We can now simply return the MemberType.
25523 (Method.GetMethodFlags): Override the MemberBase version and add
25524 the conditional flags.
25525 (Method.CheckBase): Moved some code from Define() here, call
25526 DoDefineParameters() here.
25527 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25528 here to avoid some larger code duplication.
25529 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25530 ensure that abstract and external accessors don't declare a body.
25532 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25533 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25534 lookup in the attribute's parent classes, so we need to abort as soon
25535 as we found the first match.
25536 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25537 the attribute has no arguments.
25539 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25542 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25544 * cs-parser.jay: reverted previous patch.
25546 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25548 * cs-parser.jay: fixed bug #22119.
25550 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25552 * attribute.cs: fixed compilation. The error was:
25553 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25554 be assigned to before control leaves the current method."
25555 [FIXME: Filed as bug #28186: MCS must report this error.]
25557 2002-07-25 Martin Baulig <martin@gnome.org>
25559 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25560 method to pull the condition name ouf of a Conditional attribute.
25561 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25562 the obsolete message and error flag out of an Obsolete attribute.
25564 * class.cs (Method.GetMethodFlags): New public method to get the
25565 TypeManager.MethodFlags for this method.
25566 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25568 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25569 if we're overriding a virtual function, set the new private variable
25570 `parent_method'; call the new TypeManager.AddMethod().
25572 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25573 the MethodBuilder and the Method in a PtrHashtable.
25574 (TypeManager.builder_to_method): Added for this purpose.
25575 (TypeManager.MethodFlags): Added IsObsoleteError.
25576 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25577 Obsolete and Conditional arguments in MethodBuilders. If we discover
25578 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25579 the message from the attribute.
25581 2002-07-24 Martin Baulig <martin@gnome.org>
25583 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25584 preprocessor directives, ensure that the argument to #define/#undef is
25585 exactly one identifier and that it's actually an identifier.
25587 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25590 2002-07-24 Martin Baulig <martin@gnome.org>
25592 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25593 initialize it to TypeManager.object_type in the constructor.
25594 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25595 of the `hm.get_current' method if we're using the collection pattern.
25596 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25597 for the explicit conversion to make it work when we're using the collection
25598 pattern and the `Current' property has a different return type than `object'.
25601 2002-07-24 Martin Baulig <martin@gnome.org>
25603 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25604 does not match, but don't report any errors. This method is called in
25605 order for all methods in a MethodGroupExpr until a matching method is
25606 found, so we don't want to bail out if the first method doesn't match.
25607 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25608 matches, report the 123. Fixes #28070.
25610 2002-07-24 Martin Baulig <martin@gnome.org>
25612 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25613 TypeManager.TypeToCoreType() to the top of the method so the
25614 following equality checks will work. Fixes #28107.
25616 2002-07-24 Martin Baulig <martin@gnome.org>
25618 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25619 operand is of type uint, and the other operand is of type sbyte,
25620 short or int, the operands are converted to type long." -
25621 Actually do what this comment already told us. Fixes bug #28106,
25624 2002-07-24 Martin Baulig <martin@gnome.org>
25626 * class.cs (MethodBase): New abstract class. This is now a base
25627 class for Property, Indexer and Event to avoid some code duplication
25628 in their Define() and DefineMethods() methods.
25629 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25630 generic methods for Define() and DefineMethods().
25631 (FieldBase): Derive from MemberBase, not MemberCore.
25632 (Property): Derive from MemberBase, not MemberCore.
25633 (Property.DefineMethod): Moved all the code from this method to the
25634 new MethodBase.DefineAccessor(), just call it with appropriate
25636 (Property.Define): Call the new Property.DoDefine(), this does some
25637 sanity checks and we don't need to duplicate the code everywhere.
25638 (Event): Derive from MemberBase, not MemberCore.
25639 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25640 accessors, this will also make them work with interface events.
25641 (Indexer): Derive from MemberBase, not MemberCore.
25642 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25643 (Indexer.Define): Use the new MethodBase functions.
25645 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25646 argument to the constructor.
25647 (Interface.FindMembers): Added support for interface events.
25648 (Interface.PopluateEvent): Implemented.
25650 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25652 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25654 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25655 but this is required to check for a method name being the same as
25656 the containing class.
25660 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25662 * interface.cs: initialize variable.
25664 2002-07-23 Martin Baulig <martin@gnome.org>
25666 Implemented the IndexerName attribute in interfaces.
25668 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25669 name if this is an explicit interface implementation.
25670 (Indexer.InterfaceIndexerName): New public variable. If we're
25671 implementing an interface indexer, this is the IndexerName in that
25672 interface. Otherwise, it's the IndexerName.
25673 (Indexer.DefineMethod): If we're implementing interface indexer,
25674 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25675 and Pending.ImplementIndexer methods.
25676 (Indexer.Define): Also define the PropertyBuilder if we're
25677 implementing an interface indexer and this is neither an explicit
25678 interface implementation nor do the IndexerName match the one in
25681 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25682 If a method is defined here, then we always need to create a proxy
25683 for it. This is used when implementing interface indexers.
25684 (Pending.IsInterfaceIndexer): New public method.
25685 (Pending.ImplementIndexer): New public method.
25686 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25687 This is used when implementing interface indexers to define a proxy
25689 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25690 define a proxy if necessary.
25692 * interface.cs (Interface.IndexerName): New public variable.
25693 (Interface.PopulateIndexer): Set the IndexerName.
25694 (Interface.DefineIndexers): New private method. Populate all the
25695 indexers and make sure their IndexerNames match.
25697 * typemanager.cs (IndexerPropertyName): Added support for interface
25700 2002-07-22 Martin Baulig <martin@gnome.org>
25702 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25703 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25704 ret if HasReturnLabel.
25705 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25708 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25709 and set the ec.LoopBeginTryCatchLevel.
25710 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25711 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25712 the current ec.TryCatchLevel, the branch goes out of an exception
25713 block. In this case, we need to use Leave and not Br.
25715 2002-07-22 Martin Baulig <martin@gnome.org>
25717 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25718 block unless the block does not always return or it is contained in
25719 another try { ... } catch { ... } block. Fixes bug #26506.
25720 Added verify-1.cs to the test suite.
25722 2002-07-22 Martin Baulig <martin@gnome.org>
25724 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25725 then we do not always return. Fixes bug #24985.
25727 2002-07-22 Martin Baulig <martin@gnome.org>
25729 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25730 lookup on a per-class level; ie. walk up the class hierarchy until we
25731 found at least one applicable method, then choose the best among them.
25732 Fixes bug #24463 and test-29.cs.
25734 2002-07-22 Martin Baulig <martin@gnome.org>
25736 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25737 return types of the methods. The return type is not part of the
25738 signature and we must not check it to make the `new' modifier work.
25739 Fixes bug #27999, also added test-147.cs.
25740 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25742 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25743 on the method's return type.
25745 2002-07-21 Martin Baulig <martin@gnome.org>
25747 * assign.cs: Make this work if the rightmost source is a constant and
25748 we need to do an implicit type conversion. Also adding a few more tests
25749 to test-38.cs which should have caught this.
25751 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25752 target in the makefile for this. The makefile.gnu is primarily intended
25753 for end-users who don't want to debug the compiler.
25755 2002-07-21 Martin Baulig <martin@gnome.org>
25757 * assign.cs: Improved the Assign class so it can now handle embedded
25758 assignments (X = Y = Z = something). As a side-effect this'll now also
25759 consume less local variables. test-38.cs now passes with MCS, added
25760 a few new test cases to that test.
25762 2002-07-20 Martin Baulig <martin@gnome.org>
25764 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25765 instructions. Fixes bug #27977, also added test-146.cs.
25767 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25769 * cs-tokenizer.cs: fixed getHex ().
25771 2002-07-19 Martin Baulig <martin@gnome.org>
25773 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25774 not Type.GetType() to lookup the array type. This is needed when
25775 we're constructing an array of a user-defined type.
25776 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25777 single-dimensional arrays, but also for single-dimensial arrays of
25780 2002-07-19 Martin Baulig <martin@gnome.org>
25782 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25783 this function is called, it's not allowed to share LocalBuilders
25784 among ILGenerators.
25786 2002-07-19 Martin Baulig <martin@gnome.org>
25788 * expression.cs (Argument.Resolve): Report an error 118 when trying
25789 to pass a type as argument.
25791 2002-07-18 Martin Baulig <martin@gnome.org>
25793 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25794 Conv_R_Un for the signed `long' type.
25796 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25798 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25799 `expr' for the temporary result, as that will fail if we do
25800 multiple resolves on the same expression.
25802 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25804 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25805 ec.TypeContainer for looking up aliases.
25807 * class.cs (TypeContainer): Remove LookupAlias from here.
25809 * decl.cs (DeclSpace); Move here.
25811 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25813 * class.cs (FindMembers): Only call filter if the constructor
25814 bulider is not null.
25816 Also handle delegates in `NestedTypes' now. Now we will perform
25817 type lookups using the standard resolution process. This also
25820 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25821 This uses Expressions (the limited kind that can be parsed by the
25822 tree) instead of strings.
25824 * expression.cs (ComposedCast.ToString): Implement, used to flag
25825 errors since now we have to render expressions.
25827 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25830 * ecore.cs (SimpleName.ToString): ditto.
25832 * cs-parser.jay: Instead of using strings to assemble types, use
25833 Expressions to assemble the type (using SimpleName, ComposedCast,
25834 MemberAccess). This should fix the type lookups in declarations,
25835 because we were using a different code path for this.
25837 * statement.cs (Block.Resolve): Continue processing statements
25838 even when there is an error.
25840 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25842 * class.cs (Event.Define): Also remove the `remove' method from
25843 the list of pending items.
25845 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25846 generate more compact code.
25848 2002-07-17 Martin Baulig <martin@gnome.org>
25850 * const.cs (Const.LookupConstantValue): Add support for constant
25851 `unchecked' and `checked' expressions.
25852 Also adding test case test-140.cs for this.
25854 2002-07-17 Martin Baulig <martin@gnome.org>
25856 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25857 check whether mi.ReturnType implements the IEnumerator interface; the
25858 `==' and the IsAssignableFrom() will fail in this situation.
25860 2002-07-16 Ravi Pratap <ravi@ximian.com>
25862 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25865 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25867 * expression.cs: fixed bug #27811.
25869 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25871 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25872 Molaro: when we are a ref, the value already contains a pointer
25873 value, do not take the address of it.
25875 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25876 * removed mb-parser.jay and mb-tokenizer.cs
25878 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25880 * expression.cs: check against the building corlib void type.
25882 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25884 * ecore.cs: fix for valuetype static readonly fields: when
25885 initializing them, we need their address, not the address of a copy.
25887 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25889 * typemanager.cs: register also enum_type in corlib.
25891 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25893 * class.cs: allow calling this (but not base) initializers in structs.
25895 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25897 * ecore.cs: make sure we compare against the building base types
25900 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25902 * typemanager.cs: fix TypeToCoreType() to handle void and object
25903 (corlib gets no more typerefs after this change).
25905 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25907 * expression.cs (ArrayCreation.EmitArrayArguments): use
25908 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25910 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25911 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25912 array indexes, the runtime actually forbids them.
25914 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25915 for array arguments here.
25917 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25918 instead of the default for ValueTypes.
25920 (New.DoEmit): Use IsValueType instead of
25921 IsSubclassOf (value_type)
25922 (New.DoResolve): ditto.
25923 (Invocation.EmitCall): ditto.
25925 * assign.cs (Assign): ditto.
25927 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25928 Statements *are* currently doing part of their resolution during
25931 Expressions do always resolve during resolve, but statements are
25932 only required to propagate resolution to their children.
25934 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25936 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25938 (LoadAssembly): Do not add the dll if it is already specified
25940 (MainDriver): Add the System directory to the link path at the end,
25941 after all the other -L arguments.
25943 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25944 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25945 ldelem.u1) and using the opposite for sbytes.
25947 This fixes Digger, and we can finally run it.
25949 * driver.cs (UnixParseOption): Move the option parsing here.
25950 (CSCParseOption): Implement CSC-like parsing of options.
25952 We now support both modes of operation, the old Unix way, and the
25953 new CSC-like way. This should help those who wanted to make cross
25954 platform makefiles.
25956 The only thing broken is that /r:, /reference: and /lib: are not
25957 implemented, because I want to make those have the same semantics
25958 as the CSC compiler has, and kill once and for all the confussion
25959 around this. Will be doing this tomorrow.
25961 * statement.cs (Unsafe.Resolve): The state is checked during
25962 resolve, not emit, so we have to set the flags for IsUnsfe here.
25964 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25966 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25967 not catch the Error_ObjectRefRequired in SimpleName (as it is
25968 possible to have a class/instance variable name that later gets
25969 deambiguated), we have to check this here.
25971 2002-07-10 Ravi Pratap <ravi@ximian.com>
25973 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25974 make static and put into Expression.
25976 (Event.Define): Register the private field of the event with the
25977 TypeManager so that GetFieldFromEvent can get at it.
25979 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25980 keep track of the private field associated with an event which
25983 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25986 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25988 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25990 * expression.cs (Binary.EmitBranchable): this routine emits the
25991 Binary expression in a branchable context. This basically means:
25992 we need to branch somewhere, not just get the value on the stack.
25994 This works together with Statement.EmitBoolExpression.
25996 * statement.cs (Statement.EmitBoolExpression): Use
25999 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26001 * statement.cs (For): Reduce the number of jumps in loops.
26003 (For): Implement loop inversion for the For statement.
26005 (Break): We can be breaking out of a Try/Catch controlled section
26006 (foreach might have an implicit try/catch clause), so we need to
26007 use Leave instead of Br.
26009 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26010 now). If the instace expression supports IMemoryLocation, we use
26011 the AddressOf method from the IMemoryLocation to extract the
26012 address instead of emitting the instance.
26014 This showed up with `This', as we were emitting the instance
26015 always (Emit) instead of the Address of This. Particularly
26016 interesting when This is a value type, as we dont want the Emit
26017 effect (which was to load the object).
26019 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26021 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26023 * statement.cs (Checked): Set the CheckedState during the resolve
26024 process too, as the ConvCast operations track the checked state on
26025 the resolve process, and not emit.
26027 * cs-parser.jay (namespace_member_declaration): Flag that we have
26028 found a declaration when we do. This is used to flag error 1529
26030 * driver.cs: Report ok when we display the help only.
26032 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26034 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26036 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26038 * cs-tokenizer.cs (define): We also have to track locally the
26039 defines. AllDefines is just used for the Conditional Attribute,
26040 but we also need the local defines for the current source code.
26042 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26044 * statement.cs (While, For, Do): These loops can exit through a
26045 Break statement, use this information to tell whether the
26046 statement is the last piece of code.
26048 (Break): Flag that we break.
26050 * codegen.cs (EmitContexts): New `Breaks' state variable.
26052 2002-07-03 Martin Baulig <martin@gnome.org>
26054 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26055 modifiers in method declarations in structs. Otherwise, you won't
26056 be able to override things like Object.Equals().
26058 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26060 * class.cs (Method, Property, Indexer): Do not allow the public
26061 modifier to be used in explicit interface implementations.
26063 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26064 override modifiers in method declarations in structs
26066 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26068 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26069 integer or real overflow, report an error
26071 2002-07-02 Martin Baulig <martin@gnome.org>
26073 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26074 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26075 to tell the runtime about our newly created System.Object and
26076 System.ValueType types.
26078 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26080 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26081 struct instead of Ldarg/Starg.
26083 2002-07-02 Martin Baulig <martin@gnome.org>
26085 * expression.cs (Indirection.Indirection): Call
26086 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26088 2002-07-02 Martin Baulig <martin@gnome.org>
26090 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26091 ValueType, call TypeManager.TypeToCoreType() on it.
26092 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26093 the OpCodes.Newarr argument.
26095 2002-07-02 Martin Baulig <martin@gnome.org>
26097 * expression.cs (Invocation.EmitCall): When compiling corlib,
26098 replace all calls to the system's System.Array type to calls to
26099 the newly created one.
26101 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26102 System.Array methods.
26103 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26104 from the system's System.Array type which must be replaced.
26106 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26108 * typemanager.cs: load unverifiable_code_ctor so we can build
26109 corlib using the correct type. Avoid using GetTypeCode() with
26111 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26112 TypeManager.object_type to allow building corlib.
26114 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26116 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26118 2002-07-01 Martin Baulig <martin@gnome.org>
26120 * class.cs: Make the last change actually work, we need to check
26121 whether `ifaces != null' to avoid a crash.
26123 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26125 * class.cs: when we build structs without fields that implement
26126 interfaces, we need to add the interfaces separately, since there is
26127 no API to both set the size and add the interfaces at type creation
26130 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26132 * expression.cs: the dimension arguments to the array constructors
26133 need to be converted if they are a long.
26135 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26137 * class.cs: don't emit ldarg.0 if there is no parent constructor
26138 (fixes showstopper for corlib).
26140 2002-06-29 Martin Baulig <martin@gnome.org>
26142 MCS now compiles corlib on GNU/Linux :-)
26144 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26145 ie. check for MethodImplOptions.InternalCall.
26147 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26148 and TypeManager.attribute_type are null, so we must explicitly check
26149 whether parent is not null to find out whether it's an attribute type.
26150 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26151 and SetBuilder, not only if the property is neither abstract nor external.
26152 This is necessary to set the MethodImplOptions on the accessor methods.
26153 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26154 SetBuilder, see Property.Emit().
26156 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26157 populate "System.Object", "System.ValueType" and "System.Attribute" since
26158 they've already been populated from BootCorlib_PopulateCoreTypes().
26160 2002-06-29 Martin Baulig <martin@gnome.org>
26162 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26163 is the NullLiteral, we also need to make sure that target_type is not
26166 2002-06-29 Martin Baulig <martin@gnome.org>
26168 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26169 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26170 before calling BootstrapCorlib_ResolveDelegate ().
26172 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26174 * statement.cs: fixed build-breaker. All tests passed ok.
26176 2002-06-27 Martin Baulig <martin@gnome.org>
26178 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26179 for System.Decimal when compiling corlib.
26181 2002-06-27 Martin Baulig <martin@gnome.org>
26183 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26184 switch blocks which contain nothing but a default clause.
26186 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26188 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26190 2002-06-27 Martin Baulig <martin@gnome.org>
26192 * ecore.cs (PropertyExpr.PropertyExpr): Call
26193 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26195 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26196 is already a TypeBuilder.
26198 2002-06-27 Martin Baulig <martin@gnome.org>
26200 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26201 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26202 the "from an array-type to System.Array" case. This makes it work
26203 when compiling corlib.
26205 2002-06-27 Martin Baulig <martin@gnome.org>
26207 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26208 non-static PropertyExpr, set its InstanceExpression. This makes
26209 the `ICollection.Count' property work in System/Array.cs.
26211 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26213 * driver.cs: Made error handling more consistent. Errors now
26214 tracked by Report class, so many methods which used to return int
26215 now return void. Main() now prints success/failure and
26216 errors/warnings message.
26218 Renamed '--probe' compiler argument to '--expect-error'. Removed
26219 the magic number return values (123 and 124). Now, if the
26220 expected error occurs, the compiler exits with success (exit value
26221 0). If the compilation completes without seeing that particular
26222 error, the compiler exits with failure (exit value 1). The
26223 makefile in mcs/errors has been changed to handle the new behaviour.
26225 * report.cs: Made 'expected error' number a property and renamed
26226 it from 'Probe' to 'ExpectedError'.
26228 * genericparser.cs: Removed error handling support, since it is
26229 now all done by Report class.
26231 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26232 class, so parse() no longer returns an int.
26234 * namespace.cs: Use Report.Error instead of GenericParser.error
26236 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26238 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26239 TypeContainer.AddOperator): At the front of the list put the
26240 explicit implementations, so they get resolved/defined first.
26242 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26244 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26245 interface type is implemented by this TypeContainer. Used during
26246 explicit interface implementation.
26248 (Property.Define, Indexer.Define, Method.Define): Validate that
26249 the given interface in the explicit implementation is one of the
26250 base classes for the containing type.
26252 Also if we are explicitly implementing an interface, but there is
26253 no match in the pending implementation table, report an error.
26255 (Property.Define): Only define the property if we are
26256 not explicitly implementing a property from an interface. Use the
26257 correct name also for those properties (the same CSC uses,
26258 although that is really not needed).
26260 (Property.Emit): Do not emit attributes for explicitly implemented
26261 properties, as there is no TypeBuilder.
26263 (Indexer.Emit): ditto.
26265 Hiding then means that we do not really *implement* a pending
26266 implementation, which makes code fail.
26268 2002-06-22 Martin Baulig <martin@gnome.org>
26270 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26271 the return value of Object.GetType(). [FIXME: we need to do this whenever
26272 we get a type back from the reflection library].
26274 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26276 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26278 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26280 * attribute.cs: Return null if we can not look up the type.
26282 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26283 the interface types found.
26285 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26286 interface types found.
26288 * typemanager.cs (GetInterfaces): Make this routine returns alll
26289 the interfaces and work around the lame differences between
26290 System.Type and System.Reflection.Emit.TypeBuilder in the results
26291 result for GetInterfaces.
26293 (ExpandInterfaces): Given an array of interface types, expand and
26294 eliminate repeated ocurrences of an interface. This expands in
26295 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26298 2002-06-21 Martin Baulig <martin@gnome.org>
26300 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26303 2002-06-21 Martin Baulig <martin@gnome.org>
26305 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26306 and called with one of the core types, return the corresponding typebuilder for
26309 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26312 2002-06-21 Martin Baulig <martin@gnome.org>
26314 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26315 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26316 (Expression.ConvertReferenceExplicit): Likewise.
26318 * expression.cs (ElementAccess.DoResolve): Likewise.
26319 (ElementAccess.DoResolveLValue): Likewise.
26321 2002-06-10 Martin Baulig <martin@gnome.org>
26323 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26324 add the "value" parameter to the parameter list.
26326 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26329 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26331 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26332 the argument to an int, uint, long or ulong, per the spec. Also
26333 catch negative constants in array creation.
26335 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26337 * class.cs: do not allow the same interface to appear twice in
26338 the definition list.
26340 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26342 * ecore.cs: don't use ldlen with System.Array.
26344 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26346 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26348 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26350 * modifiers.cs: produce correct field attributes for protected
26351 internal. Easy fix so miguel can work on ther harder stuff:-)
26353 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26355 * pending.cs: New file. Move the code from class.cs here.
26356 Support clearning the pending flag for all methods (when not doing
26357 explicit interface implementation).
26359 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26361 * rootcontext.cs: added a couple more types needed to bootstrap.
26363 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26365 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26366 constructor in the type, instead of any constructor in the type
26367 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26368 a bug in the Mono runtime when applying the params attribute).
26370 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26371 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26373 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26375 * expression.cs (Unary.ResolveOperator): Use TypeManager
26376 to resolve the type.
26378 2002-06-13 Ravi Pratap <ravi@ximian.com>
26380 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26383 * enum.cs (AddEnumMember): Add support to store the attributes associated
26384 with each member too.
26386 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26387 field builders too - this takes care of the enum member case.
26389 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26391 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26392 address-of operator on both value types and pointers.
26394 2002-06-10 Martin Baulig <martin@gnome.org>
26396 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26397 PropertyBuilder to the `property_builders' list.
26399 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26400 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26401 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26402 find any indexers which are inherited from an interface.
26404 2002-06-09 Martin Baulig <martin@gnome.org>
26406 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26407 the same type as the constant if necessary. There's also a test-130.cs
26410 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26412 * typemanager.cs (TypeManager.ChangeType): Previously known as
26413 Enum.ChangeEnumType().
26415 2002-06-09 Martin Baulig <martin@gnome.org>
26417 * expression.cs (Cast.TryReduce): Added support for consts.
26419 2002-06-08 Ravi Pratap <ravi@ximian.com>
26421 * class.cs (Accessor): Hold attributes information so we can pass
26424 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26425 Modify to pass in attributes attached to the methods.
26427 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26429 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26430 to handle the Accessor kind :-)
26432 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26434 2002-06-08 Martin Baulig <martin@gnome.org>
26436 * expression.cs (Unary.TryReduceNegative): Added support for
26439 2002-06-08 Martin Baulig <martin@gnome.org>
26441 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26442 name can't be found in the `defined_names' - the caller will do a
26443 MemberLookup in this case and thus find methods in System.Enum
26444 such as Enum.IsDefined().
26446 2002-06-08 Martin Baulig <martin@gnome.org>
26448 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26449 Convert.ChangeType() which works with TypeBuilder created types.
26450 (Enum.LookupEnumValue, Enum.Define): Use it here.
26452 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26453 `TypeBuilder.BaseType != null' check.
26454 (TypeContainer.FindMembers): Only lookup parent members if we
26455 actually have a parent.
26456 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26457 (ConstructorInitializer.Resolve): Likewise.
26459 * interface.cs (Interface.FindMembers): Added
26460 `TypeBuilder.BaseType != null' check.
26462 * rootcontext.cs (RootContext.ResolveCore): Added
26463 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26464 classes_second_stage.
26466 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26467 debug_type and trace_type when compiling with --nostdlib.
26469 2002-06-07 Martin Baulig <martin@gnome.org>
26471 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26472 (AddField): Set it to true when adding a non-static field.
26473 (DefineType): Use `have_nonstatic_fields' to find out whether we
26474 have non-static fields, not `Fields != null'.
26476 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26478 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26479 dereferencing a null on the static-field code path)
26481 2002-05-30 Martin Baulig <martin@gnome.org>
26483 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26484 to take command line arguments. Use reflection to call the new
26485 custom `Initialize' function on the symbol writer and pass it the
26486 command line arguments.
26488 * driver.cs (--debug-args): New command line argument to pass command
26489 line arguments to the symbol writer.
26491 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26493 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26494 the target type for indexers and properties. Thanks to Joe for
26497 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26499 * typemanager.cs (MethodFlags): returns the method flags
26500 (Obsolete/ShouldIgnore) that control warning emission and whether
26501 the invocation should be made, or ignored.
26503 * expression.cs (Invocation.Emit): Remove previous hack, we should
26504 not do this on matching a base type, we should do this based on an attribute
26506 Only emit calls to System.Diagnostics.Debug and
26507 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26508 on the command line.
26510 * rootcontext.cs: Global settings for tracing and debugging.
26512 * cs-tokenizer.cs (define): New utility function to track
26513 defines. Set the global settings for TRACE and DEBUG if found.
26515 2002-05-25 Ravi Pratap <ravi@ximian.com>
26517 * interface.cs (Populate*): Pass in the TypeContainer as well as
26518 the DeclSpace as parameters so that we can create EmitContexts and
26519 then use that to apply attributes etc.
26521 (PopulateMethod, PopulateEvent, PopulateProperty)
26522 (PopulateIndexer): Apply attributes everywhere.
26524 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26527 (ApplyAttributes): Update accordingly.
26529 We now apply interface attributes for all members too.
26531 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26533 * class.cs (Indexer.Define); Correctly check if we are explicit
26534 implementation (instead of checking the Name for a ".", we
26535 directly look up if the InterfaceType was specified).
26537 Delay the creation of the PropertyBuilder.
26539 Only create the PropertyBuilder if we are not an explicit
26540 interface implementation. This means that explicit interface
26541 implementation members do not participate in regular function
26542 lookups, and hence fixes another major ambiguity problem in
26543 overload resolution (that was the visible effect).
26545 (DefineMethod): Return whether we are doing an interface
26548 * typemanager.cs: Temporary hack until we get attributes in
26549 interfaces (Ravi is working on that) and we get IndexerName
26550 support in interfaces.
26552 * interface.cs: Register the indexers as properties.
26554 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26555 warning, I have verified that this is a bug in the .NET runtime
26556 (JavaScript suffers of the same problem).
26558 * typemanager.cs (MemberLookup): When looking up members for
26559 interfaces, the parent of an interface is the implicit
26560 System.Object (so we succeed in searches of Object methods in an
26561 interface method invocation. Example: IEnumerable x; x.ToString
26564 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26566 * class.cs (Event): Events should also register if they do
26567 implement the methods that an interface requires.
26569 * typemanager.cs (MemberLookup); use the new GetInterfaces
26572 (GetInterfaces): The code used to lookup interfaces for a type is
26573 used in more than one place, factor it here.
26575 * driver.cs: Track the errors at the bottom of the file, we kept
26578 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26579 instance if the method we are calling is static!
26581 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26583 * attribute.cs (ApplyAttributes): Make this function filter out
26584 the IndexerName attribute (as that attribute in reality is never
26585 applied) and return the string constant for the IndexerName
26588 * class.cs (TypeContainer.Emit): Validate that all the indexers
26589 have the same IndexerName attribute, and if so, set the
26590 DefaultName attribute on the class.
26592 * typemanager.cs: The return value might contain other stuff (not
26593 only methods). For instance, consider a method with an "Item"
26594 property and an Item method.
26596 * class.cs: If there is a problem with the parameter types,
26599 2002-05-24 Ravi Pratap <ravi@ximian.com>
26601 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26602 looks at user defined conversion after making a call to
26603 StandardConversionExists - we need this for overload resolution.
26605 * expression.cs : Update accordingly the various method calls.
26607 This fixes 2 bugs filed against implicit user defined conversions
26609 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26611 * statement.cs: Track the result of the assignment.
26613 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26615 * expression.cs (MemberAccess): Improved error reporting for
26616 inaccessible members.
26618 2002-05-22 Martin Baulig <martin@gnome.org>
26620 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26621 itself with debugging support.
26623 2002-05-22 Martin Baulig <martin@gnome.org>
26625 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26626 Removed, this isn't needed anymore.
26628 2002-05-20 Martin Baulig <martin@gnome.org>
26630 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26631 be underlying type for an enum.
26633 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26635 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26636 that splits out the loading of just the core types.
26638 * rootcontext.cs (ResolveCore): Split the struct resolution in
26639 two, so we can load the enumeration underlying types before any
26642 * expression.cs (Is): Bandaid until we fix properly Switch (see
26643 bug #24985 for details).
26645 * typemanager.cs (ImplementsInterface): The hashtable will contain
26646 a null if there are no interfaces implemented.
26648 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26650 * cs-parser.jay (indexer_declarator): It is fine to have array
26653 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26655 * typemanager.cs: (RegisterBuilder): New function used to register
26656 TypeBuilders that implement interfaces. Since
26657 TypeBuilder.GetInterfaces (as usual) does not work with lame
26659 (AddUserType): register interfaces.
26661 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26662 dealing with TypeBuilder. Also, arrays are showing up as
26663 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26664 methods can not be invoked on them!
26666 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26667 (ImplicitReferenceConversionExists): Split out from
26668 StandardConversionExists.
26670 * expression.cs (As): We were only implementing one of the three
26671 cases for the as operator. We now implement them all.
26672 (Is): Implement the various other cases for Is as well.
26674 * typemanager.cs (CACHE): New define used to control if we want or
26675 not the FindMembers cache. Seems to have a negative impact on
26676 performance currently
26678 (MemberLookup): Nested types have full acess to
26679 enclosing type members
26681 Remove code that coped with instance/static returns for events, we
26682 now catch this in RealFindMembers.
26684 (RealFindMembers): only perform static lookup if the instance
26685 lookup did not return a type or an event.
26687 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26689 * assign.cs (CompoundAssign): We pass more semantic information
26690 now to Compound Assignments than we did before: now we have all
26691 the information at hand, and now we resolve the target *before* we
26692 do the expression expansion, which allows the "CacheValue" method
26693 to have the effect we intended (before, a [x] += 1 would generate
26694 two differen ArrayAccess expressions from the ElementAccess,
26695 during the resolution process).
26697 (CompoundAssign.DoResolve): Resolve target and original_source here.
26699 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26701 * expression.cs (ArrayAccess): dropped debugging information.
26703 * typemanager.cs: Small bug fix: I was always returning i_members,
26704 instead of one of i_members or s_members (depending on which had
26707 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26708 method is invoked before any code generation takes place, and it
26709 is a mechanism to inform that the expression will be invoked more
26710 than once, and that the method should use temporary values to
26711 avoid having side effects
26713 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26715 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26718 * expression.cs (Indirection, ArrayAccess): Add support for
26719 CacheTemporaries in these two bad boys.
26721 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26722 ldobj or ldind_ref.
26723 (StoreFromPtr): Handle stobj as well.
26725 * expression.cs (UnaryMutator): Share more code.
26727 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26728 down: I was not tracking the Filter function as well, which
26729 was affecting the results of the cache.
26731 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26733 * attribute.cs: Remove the hack to handle the CharSet property on
26736 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26738 * attribute.cs (DoResolve): More uglyness, we now only try to
26739 resolve the attribute partially, to extract the CharSet
26740 information (only if we are a StructLayout attribute). Otherwise
26742 (GetExtraTypeInfo): Add some code to conditionally kill in the
26743 future this. I am more and more convinced that the .NET
26744 framework has special code to handle the attribute setting on
26747 * expression.cs (IsParamsMethodApplicable): Revert my previous
26748 foreach change here, it was wrong.
26750 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26752 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26753 (pp_expr): do not abort on unknown input, just return.
26754 (eval): abort if there are pending chars.
26756 * attribute.cs (Attribute.Resolve): Positional parameters are
26757 optional. Deal with that case.
26759 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26760 the Ansi/Unicode/Auto information for the type.
26762 (TypeContainer.DefineType): instantiate the EmitContext here, as
26763 we will be using it during the type definition (to resolve
26764 attributes) and during the emit phase.
26766 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26767 to pull type information out of the attributes
26769 (Attribute.Resolve): track the constructor builder, and allow for
26770 multiple invocations (structs and classes will use this).
26772 * ecore.cs (MemberLookupFinal): new version with all the
26773 parameters customizable.
26775 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26776 constructors. Return if the result value is null (as the error
26777 would have been flagged already by MemberLookupFinal)
26779 Do not allow instances of abstract classes or interfaces to be
26782 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26783 We have to compare the assembly property here when dealing with
26784 FamANDAssem and Assembly access modifiers, because we might be
26785 creating an assembly from *modules* (that means that we are not
26786 getting TypeBuilders for types defined in other modules that are
26787 part of this assembly).
26789 (Method.Emit): If the method is marked abstract and has a body,
26792 (TypeContainer.DefineMembers): If both the defined member and the
26793 parent name match are methods, then do not emit any warnings: let
26794 the Method.Define routine take care of flagging warnings. But if
26795 there is a mismatch (method overrides something else, or method is
26796 overriwritten by something, then emit warning).
26798 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26799 set to null, this means `do not check for the return type on the
26802 (Method.Define): set the return type for the method signature to
26803 null, so that we get methods with the same name and parameters and
26804 different return types. This is used to flag warning 114 (you are
26805 hiding a method, and you probably want to use the new/override
26808 * typemanager.cs (MemberLookup): Implemented proper access
26809 control, closing a long standing set of bug reports. The problem
26810 was that the Framework only has two bits: Public and NonPublic,
26811 and NonPublic includes private and protected methods, but we need
26812 to enforce the FamANDAssem, FamOrAssem and Family.
26814 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26816 * statement.cs (GotoCase): Return true: Ammounts to giving up
26817 knowledge on whether we return or not, and letting the other case
26818 be responsible for it.
26820 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26822 * driver.cs: Do not load directories for each file processed, only
26823 do it if there is a pattern.
26825 * ecore.cs: Report readonly assigns here as well, as we might have
26826 been resolved only by MemberAccess.
26828 (SimpleName.SimpleNameResolve): Also be useful for LValue
26829 resolution. We need this to propagate assign to local readonly variables
26831 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26832 do not want to reuse potential criteria memory.
26834 * class.cs (MyEventBuilder): Set reflected_type;
26836 * ecore.cs (Constantify): Added support for constifying bools.
26838 (RootContext.LookupType): Added a cache for values looked up in
26839 the declaration space.
26841 * typemanager.cs (FindMembers): Now is a front-end to
26842 RealFindMembers, and provides a two-level hashtable-based cache to
26845 15% performance improvement: from 22.5 to 19.2 seconds.
26847 * expression.cs (IsParamsMethodApplicable): use foreach.
26848 (Invocation.DoResolve): ditto.
26849 (New.DoResolve): ditto.
26850 (ArrayCreation.DoResolve): ditto.
26852 * ecore.cs (FindMostEncompassingType): use foreach.
26854 * delegate.cs (NewDelegate.DoResolve): Use foreach
26856 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26857 (RemoveMethods): use foreach.
26859 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26860 nested foreach statements instead of for, and also break out of
26861 the inner loop once a match is found.
26863 (Invocation.OverloadResolve): Use foreach, simplify the code.
26865 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26867 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26868 we actually unwrap the expression to allow for extra information
26871 * expression.cs: Use Shr_Un on unsigned operations.
26873 2002-05-08 Ravi Pratap <ravi@ximian.com>
26875 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26876 applicable operators was not being considered correctly. This closes
26877 the bug Miguel reported.
26879 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26881 * attribute.cs: check that the type derives from System.Attribute
26882 and report the correct error in that case (moved the duplicate code to
26883 its own method, too).
26885 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26887 * attribute.cs: lookup attribute type name as the spec says: first the
26888 bare attribute name and then name + "Attribute" (nant compiles with
26889 mcs after this fix).
26891 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26893 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26894 Because of the way we parse things, we should try to see if a
26895 UIntConstant can fit in an integer.
26897 2002-05-07 Ravi Pratap <ravi@ximian.com>
26899 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26900 when we are in an explicit context.
26902 (ConvertReferenceExplicit): When converting from Iface type S to Class
26903 T make sure the rules are implemented as an OR.
26905 * parameter.cs (ParameterType): Make it a property for now although the
26906 purpose really isn't anything immediate.
26908 * expression.cs (Is*Applicable): Do better checking on the parameter type
26909 of a ref/out parameter. The ones from the system assemblies are already
26910 marked with the correct type so we don't need to do any correction.
26912 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26913 the object type is standard too so include that.
26915 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26917 * ecore.cs (StandardConversionExists): Augment with missing code:
26918 deal with IntConstant, LongConstants and Enumerations.
26920 * assign.cs: Report the error, instead of failing silently
26922 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26923 typecontainer that they are declared, because the
26924 typecontainer/namespace will have the list of using clauses that
26925 need to be applied.
26927 Assembly Attributes were escaping the normal registration
26930 (EmitCode): Apply attributes within an EmitContext that represents
26931 the container they were declared on.
26933 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26935 2002-05-06 Ravi Pratap <ravi@ximian.com>
26937 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26938 Revamp completely - make much cleaner as we now operate only
26941 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26942 to implement the logic detailed in the spec more correctly.
26944 (UserDefinedConversion): Update accordingly.
26946 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26948 * statement.cs: Return flow analysis information up.
26950 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26953 (token): Do not consume an extra character before calling
26956 2002-05-06 Piers Haken <piersh@friskit.com>
26958 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26960 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26962 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26963 EmitContext during the instance constructor initializer
26964 resolution, to stop access to instance variables.
26966 This is mandated by the spec, last paragraph of the `constructor
26967 initializers' section.
26969 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26971 * cs-parser.jay, class.cs (Accessor): new class used to represent
26972 an accessor (get or set). In the past we used `null' to represent
26973 a missing accessor. But this is ambiguous because there was no
26974 way to tell in abstract indexers/properties if one of them was
26977 Now there is a way of addressing that.
26979 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26980 instead of FindMembers.
26982 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26983 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26985 * attribute.cs: Treat indexers and properties as the same in terms
26986 of applying attributes
26988 * ecore.cs (FindMostEncompassedType): Use statically initialized
26989 EmptyExpressions()s like we do elsewhere to avoid creating useless
26990 objects (and we take this out of the tight loop).
26992 (GetConversionOperators): Move the code to extract the actual
26993 operators to a separate routine to clean things up.
26995 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26997 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26998 events are always registered FieldBuilders.
27000 * class.cs (FieldBase): New class shared by Fields
27002 * delegate.cs: If we are a toplevel delegate, use our full name.
27003 If we are a nested delegate, then only use our tail name.
27005 2002-05-02 Ravi Pratap <ravi@ximian.com>
27007 * expression.cs (IsApplicable): Ensure that we add the "&" to
27008 ref/out types before comparing it with the type of the argument.
27010 (IsParamsMethodApplicable): Ditto.
27012 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27015 * delegate.cs : Handle the case when we have more than one applicable
27016 method. Flag an error only when we finish checking all.
27018 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27020 * expression.cs: Add support for boolean static initializers.
27022 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27024 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27026 * parameter.cs (ComputeParameterTypes,
27027 ComputeAndDefineParameterTypes): Better error handling: now we
27028 clear the `types' cache if we fail during any of the type lookups.
27029 We also return the status code correctly to our caller
27031 * delegate.cs: If we fail to define a delegate, abort the extra
27034 * expression.cs (Binary.ResolveOperator): for
27035 operator==(object,object) and operator !=(object, object) we also
27036 have to verify that there is an implicit conversion from one to
27039 (ArrayAccess.DoResolve): Array Access can operate on
27042 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27044 * assign.cs (CompoundAssign): A new class used as a "flag" that
27045 the assignment actually is happening as part of a compound
27046 assignment operator.
27048 During compound assignment, a few new rules exist to enable things
27055 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27056 to the type of x) if y is implicitly convertible to the type of x,
27057 and the operator is a builtin operator and the return type of the
27058 operator is explicitly convertible to the type of x.
27060 * rootcontext.cs: Reset warning level to 2. 4 catches various
27061 "interesting" features in mcs, we must clean this up at some
27062 point, but currently am trying to kill other bugs ;-)
27064 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27065 in container classes as well.
27067 * expression.cs (Binary.ResolveOperator): Handle string case
27068 before anything else (as operator overloading does emit an error
27069 before doing anything else).
27071 This code could go away when we move to a table driven model, but
27072 i could not come up with a good plan last night.
27074 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27076 * typemanager.cs (CSharpName): reimplementation using regex.
27077 * class.cs: added null check for fields in Emit
27078 * rootcontext.cs: set warninglevel to 4
27080 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27082 * typemanager.cs (CSharpName): reimplemented with Lupus
27085 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27087 * statement.cs (If): correclty implement Resolve, because we were
27088 not catching sem errors in there. The same process is needed
27090 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27093 (Statement.Warning_DeadCodeFound): Factorize code.
27094 (While): Report dead code here too.
27096 (Statement): Added Resolve virtual method to allow
27097 for resolution split from the emit code.
27099 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27101 * statement.cs (EmitBoolExpression): No longer try to resolve the
27103 (MakeBoolean): New utility function that resolve, implicitly
27104 converts to boolean and tags the expression.
27107 (If, Do): Implement dead code elimination.
27108 (While): Implement loop inversion
27110 (Do, While, For, If): Resolve the expression prior to calling our
27113 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27116 - added method Report28 (warning: program has more than one entry point)
27117 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27118 - modified method Method.Define, the part at the end of the method
27120 * rootcontext.cs: added static public Location EntryPointLocation;
27122 * ../errors/cs0028.cs : Add test case for the above warning.
27125 - modified method CSharpName to allow arrays of primitive type to
27126 be printed nicely (e.g. instead of System.Int32[][] it now prints
27128 - added method CSharpSignature: returns the signature of a method
27129 in string format to be used in reporting errors, warnings, etc.
27131 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27134 2002-04-26 Ravi Pratap <ravi@ximian.com>
27136 * delegate.cs (Define): Fix extremely silly bug where I was
27137 setting the type of the 'object' parameter of the BeginInvoke
27138 method to System.IAsyncResult instead of System.Object ;-)
27140 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27142 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27145 (Constructor.Emit): return if we fail to initialize the
27146 constructor. Another door closed!
27148 * expression.cs (New.DoResolve): Improve error message (from -6 to
27149 1501). Use DeclaredOnly lookup to find the exact constructor.
27151 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27152 loop. This is useful.
27154 * cs-parser.jay: Adjust the default parameters so that destructors
27155 have the proper signature.
27157 2002-04-26 Martin Baulig <martin@gnome.org>
27159 * driver.cs (LoadAssembly): If `assembly' contains any characters
27160 which are only valid in path names and not in assembly names
27161 (currently slash, backslash and point), use Assembly.LoadFrom ()
27162 instead of Assembly.Load () on the `assembly' (before iteration
27163 over the link_paths).
27165 2002-04-26 Martin Baulig <martin@gnome.org>
27167 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27169 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27171 * class.cs (Property): use the new typemanager.MemberLookup
27173 (TypeContainer.MemberLookup): Implement using the
27174 TypeManager.MemberLookup now.
27176 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27177 and return MemberInfos, so that these can be used without an
27178 EmitContext (what we had before).
27180 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27182 * expression.cs: Fix the case where the argument to params if the
27183 type of the params. I omitted handling this before. Fixed
27185 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27187 * driver.cs: Call BootCorlib_PopulateCoreType
27189 * class.cs (Property.CheckBase): Check for properties only, not
27192 * interface.cs: Temporary hack: try/catch around the
27193 CustomAttributeBuilder, because I am getting an exception that I
27196 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27197 types whose definitions are required to be there (attributes are
27198 defined before standard types).
27200 Compute definitions as we boot the various types, as they are used
27201 immediately (value_type class will need object_type, but if we do
27202 not initialize object_type, we will pass a null, which will let
27203 the runtime pick the System.Object from the existing corlib, which
27204 is not what we want).
27206 2002-04-22 Patrik Torstensson <totte@labs2.com>
27208 * cs-tokenizer.cs: fixed a number of trim() issues.
27210 2002-04-22 Ravi Pratap <ravi@ximian.com>
27212 * expression.cs (Argument.Type): Ensure that we return the correct
27213 type when we have out or ref parameters [in which case we
27216 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27218 * class.cs (Property, Indexer): Allow extern modifier in there.
27220 * typemanager.cs (InitBaseTypes): Initializes object_type and
27221 value_type, since those will be used early on during the bootstrap
27222 process to compile corlib.
27224 (InitCoreTypes): Move code from here to InitBaseTypes.
27226 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27228 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27229 single-dimension arrays as using the ldlen opcode.
27231 Daniel Lewis discovered this optimization.
27233 * typemanager.cs: Add signature for System.Array::get_Length
27235 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27237 * statement.cs: report the error when the foreach does not apply to an
27238 array nor a collection.
27240 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27242 * expression.cs: Add implicit conversions to the operator ~.
27244 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27246 * typemanager.cs: Locate the decimal constructor.
27248 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27250 * attribute.cs: use the new property of TypeOf.
27251 * expression.cs: added 'get' property around typearg.
27253 These changes fix a build breaker reported by NickD. Is this the
27254 correct way to fix? If not, please, revert my changes and make it
27257 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27259 * attribute.cs: Add support for typeof in attribute invocations.
27260 I am not sure that this is right though.
27262 2002-04-14 Duncan Mak <duncan@ximian.com>
27264 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27265 Binary.Operator.Division case.
27267 2002-04-13 Ravi Pratap <ravi@ximian.com>
27269 * class.cs (DefineType): Ensure that we do a proper check on
27270 attribute types and also register it with the TypeManager.
27272 (TypeContainer.Targets): The default for attribute types is
27273 AttributeTargets.All.
27275 * attribute.cs (ApplyAttributes): Registering the attribute type
27276 is done elsewhere, not when we discover we have a Usage attribute.
27278 2002-04-12 Ravi Pratap <ravi@ximian.com>
27280 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27281 and get rid of is_delegate parameter.
27283 * everywhere : update.
27285 2002-04-12 Ravi Pratap <ravi@ximian.com>
27287 * cs-parser.jay (compilation_unit): Revamp completely to use
27288 some new ideas that I got from Rhys' grammar to solve the problems
27289 with assembly level attributes.
27291 (outer_declaration): New grammar production.
27293 (attribute_sections): Add.
27295 (opt_attributes): Base on attribute_sections
27297 (namespace_declaration): Allow opt_attributes to tackle the case
27298 when we have assembly level attributes - we are clever in this
27301 * attribute.cs (ApplyAttributes): Do not worry about assembly
27302 attributes in the non-global context.
27304 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27305 instead of SetGlobalAttributes.
27307 * class.cs, rootcontext.cs : Ensure we define and generate
27308 attribute types before anything else.
27310 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27311 and flag the new error -20 for the case when the attribute type
27312 does not have valid targets specified. csc does not catch this.
27314 * ../errors/errors.txt : update for error # -20
27316 2002-04-11 Ravi Pratap <ravi@ximian.com>
27318 * support.cs (InternalParameters.ParameterModifier): Do some null
27319 checking and return sane values.
27321 * class.cs (Method.Define): If we are a PInvoke method, ensure
27322 that we are static and extern. Report error # 601
27324 * ../errors/cs0601.cs : Add test case for the above error.
27326 2002-04-07 Ravi Pratap <ravi@ximian.com>
27328 * rootcontext.cs (attribute_types): We need to keep type of
27329 all attribute types separately and emit code for them first.
27331 (RegisterAttribute) : Implement.
27333 * class.cs (DefineType): Check if the current Type is a custom
27334 attribute type and register it accordingly.
27336 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27337 adding the first attribute twice and rename to
27339 (SetGlobalAttributes): this.
27341 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27344 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27345 if we are processing global arguments. Hmm, I am unsure of this.
27347 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27349 * expression.cs: added static array of strings to avoid calling
27350 Enum.ToString () for Operator in Binary. Significant recover of
27353 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27355 * class.cs (FindMembers): Allow the Builders of the various
27356 members to be null. If they are skip them. This only happens
27357 during the PInvoke declaration.
27359 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27361 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27362 failure, so we do not keep going afterwards.
27364 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27365 wanted to pass `false' as the `is_delegate' argument. If this is
27366 the case, why not use delegate_type == null to mean `is_delegate =
27367 false' and anything else as is_delegate = true.
27369 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27371 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27372 code for the section, not the beginning of the tests.
27374 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27376 * cfold.cs: Handle operator + (Enum x, Underlying x)
27378 * expression.cs (Binary): same. Warn about errors where we have
27379 Enum/Enum in operator + as well.
27381 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27384 - added support for switch(bool)
27385 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27386 - add TableSwitchEmit() to handle table-based switch statements
27388 2002-04-05 Ravi Pratap <ravi@ximian.com>
27390 * expression.cs (Invocation.OverloadResolve): Factor out code which
27391 does parameter compatibility checking with arguments so that we can
27392 re-use the code even from Delegate.VerifyApplicability
27394 (VerifyArgumentsCompat): Move above code here.
27396 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27397 and instead make a call to the above method.
27399 2002-03-31 Ravi Pratap <ravi@ximian.com>
27401 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27402 We use it to keep track of classes which are attribute types.
27404 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27406 * delegate.cs (Delegate.Define): Correctly define the types in the
27407 presence of fixed and array parameters.
27409 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27412 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27413 include NonPublic after the first iteration.
27415 * class.cs (Indexer.CheckBase): Only check if both parents are
27418 * cs-parser.jay (accessor_body): If empty, set to null.
27420 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27421 same code path here to resolve constants names that we did have in
27422 MemberAccess.DoResolve. There is too much code duplicated here.
27424 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27426 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27428 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27431 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27432 tokens, numbers and strings.
27434 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27437 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27438 asyncronous parameters and the regular parameters.
27440 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27441 specify the target directory.
27443 * expression.cs: (This.DoResolve): Simplify
27444 (As.Emit): Optimize, do not generate IsInst if the expression is
27445 always of the given type.
27447 (Is.DoResolve): Bug fix, we were reporting both always/never for
27450 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27451 creating too many unnecessary arrays.
27453 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27455 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27456 fields instead of rolling our own initializer. Takes care of all
27457 implicit conversions, and drops unnecessary static checks/argument.
27459 2002-03-31 Dick Porter <dick@ximian.com>
27461 * driver.cs: use the GetDirectories() return values properly, and
27462 use "/" as path separator.
27464 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27466 * expression.cs (Unary): Optimize - - expr into expr.
27467 (Binary): Optimize a + (-b) into a -b.
27469 * codegen.cs (CodeGen): Made all methods static.
27471 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27475 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27476 TypeBuilder property.
27478 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27481 * tree.cs: Removed the various RecordXXXX, and replaced with a
27482 single RecordDecl. Removed all the accessor methods, and just
27483 left a single access point Type
27485 * enum.cs: Rename DefineEnum to DefineType.
27487 * decl.cs: New abstract method `DefineType' used to unify the
27488 Defines for Enumerations, Interfaces, TypeContainers and
27491 (FindType): Moved LookupInterfaceOrClass here. Moved the
27492 LookupBaseClasses method that used to live in class.cs and
27493 interface.cs here, and renamed to FindType.
27495 * delegate.cs: Implement DefineType. Take advantage of the
27496 refactored pattern for locating the parent builder without taking
27497 the parent_builder argument (which we know does not work if we are
27498 nested, and triggering a toplevel definition).
27500 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27502 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27503 accessibility of a member has changed during override and report
27506 * class.cs (Method.Define, Property.Define): Only complain on
27507 overrides if the method is private, any other accessibility is
27508 fine (and since we just checked the permission is the same, we are
27511 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27512 and elif are processed always. The other pre-processing
27513 directives are only processed if we are "taking" the path
27515 2002-03-29 Martin Baulig <martin@gnome.org>
27517 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27518 current location is not Null.
27520 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27521 a separate method so we can profile it.
27523 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27524 `span.Seconds' are just seconds, but no minutes or hours.
27525 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27527 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27529 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27530 Remove the gratuitous set of Final:
27532 // If an interface implementation, then we can set Final.
27533 if (((flags & MethodAttributes.Abstract) == 0) &&
27534 implementing.DeclaringType.IsInterface)
27535 flags |= MethodAttributes.Final;
27537 I do not know what I was smoking when I used that.
27540 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27541 step into fixing the name resolution issues for delegates and
27542 unifying the toplevel name resolution.
27544 2002-03-28 Martin Baulig <martin@gnome.org>
27546 * class.cs (Method.Emit): If we have a symbol writer, call its
27547 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27548 tell it about the current method.
27550 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27551 writer that we're going to emit the first byte of IL code for a new
27552 statement (a new source line).
27553 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27554 EmitContext.Mark() before emitting any code.
27556 * location.cs (SymbolDocument): Return null when we're Null.
27558 * statement.cs (Statement): Moved the `Location loc' variable here.
27559 (Statement.EmitBoolExpression): If we have a symbol writer, call
27560 ec.Mark() before emitting any code to tell it that we're at the
27561 beginning of a new statement.
27562 (StatementExpression): Added `Location' argument to the constructor.
27563 (Block): Added public readonly variable `StartLocation' and public
27564 variable `EndLocation'. The latter is to be set using SetEndLocation().
27565 (Block): Added constructor which takes a start and end location.
27566 (Block.SetEndLocation): New method. This sets the end location.
27567 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27568 local variables we create.
27569 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27570 each statement and do also mark the begin and end of the block.
27572 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27573 tell it the current lexer.Location, use Location.Null for the end of the
27575 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27576 current block, set its end location using SetEndLocation().
27577 (statement_expression): StatementExpression constructor now takes the
27578 lexer.Location as additional argument.
27579 (for_statement, declare_local_variables): Likewise.
27580 (declare_local_variables): When creating a new implicit block, use the
27581 new Block constructor and pass it the lexer.Location.
27583 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27585 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27586 members also on the parent interfaces recursively.
27588 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27590 * report.cs: Use new formats, since Gonzalo finished the missing
27593 * expression.cs (Binary.ResolveOperator): added missing operator|
27594 operator& and operator^ for bool/bool.
27596 * cs-parser.jay: CheckDef now takes a Location argument that is
27597 used to report errors more precisly (instead of reporting the end
27598 of a definition, we try to track something which is a lot closer
27599 to the source of the problem).
27601 * cs-tokenizer.cs: Track global token use, so we can properly flag
27602 the use of #define/#undef after the first token has been seen.
27604 Also, rename the reportXXXX to Error_DescriptiveName
27606 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27607 TypeContainer, so that Enum and Interface can use this too.
27609 * class.cs (TypeContainer.LookupInterfaceOrClass,
27610 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27611 `builder' argument. Typically this was used to pass the parent
27612 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27615 The problem is that a nested class could trigger the definition of
27616 a toplevel class, and the builder would be obviously wrong in that
27619 So we drop this argument, and we compute dynamically the
27620 TypeBuilder/ModuleBuilder (the correct information was available
27621 to us anyways from DeclSpace.Parent)
27623 * interface.cs (Interface.DefineInterface): Drop builder
27624 parameter cleanup like class.cs
27626 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27629 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27632 (Try.Emit): Propagate the returns value from the statement.
27634 (Return.Emit): Even if we are leavning
27636 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27638 * modifiers.cs: Fix the computation of MethodAttributes flags.
27640 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27642 * driver.cs: allow compilation of files that start with '/'.
27643 Add a default case when checking the argument of --target.
27645 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27647 * interface.cs: Implement the same search algorithm for types in
27648 the interface code.
27650 * delegate.cs: Do not allow multiple definition.
27652 * Recovered ChangeLog that got accidentally amputated
27654 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27656 * rootcontext.cs: Load manually enum to allow core classes to
27657 contain enumerations.
27659 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27660 Update to new static methods in TypeManager.
27662 * typemanager.cs (GetMethod, GetConstructor): Use our
27663 implementation of FindMembers to find the members, since during
27664 corlib compilation, the types are TypeBuilders and GetMethod and
27665 GetConstructor do not work.
27667 Make all methods in TypeManager static.
27669 (InitCodeHelpers): Split the functionality from
27670 the InitCodeTypes function.
27672 * driver.cs: Call InitCodeHelpers after we have populated the
27675 * cs-parser.jay (delegate_declaration): we did not used to compute
27676 the delegate name correctly for void delegates.
27678 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27680 * rootcontext.cs (RootContext): Init the interface_resolve_order
27681 and type_container_resolve_order always.
27683 (ResolveCore, BootstrapCorlib_ResolveClass,
27684 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27685 compiler when compiling with --nostdlib
27687 * class.cs (TypeContainer.DefineType): Check that our parent is
27688 not null. This test is most important when we are bootstraping
27691 * codegen.cs: Split out the symbol writing code.
27693 2002-03-25 Martin Baulig <martin@gnome.org>
27695 * driver.cs (-g): Made -g an alias for --debug.
27697 2002-03-24 Martin Baulig <martin@gnome.org>
27699 * codegen.cs (SymbolWriter): New public variable. Returns the
27700 current symbol writer.
27701 (CodeGen): Added `bool want_debugging_support' argument to the
27702 constructor. If true, tell the ModuleBuild that we want debugging
27703 support and ask it for the ISymbolWriter.
27704 (Save): If we have a symbol writer, call it's Close() method after
27705 saving the assembly.
27707 * driver.c (--debug): New command line argument to create a
27708 debugger information file.
27710 * location.cs (SymbolDocument): New public property. Returns an
27711 ISymbolDocumentWriter object for the current source file or null
27712 if we don't have a symbol writer.
27714 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27716 * driver.cs (LoadAssembly): Correctly return when all the paths
27717 have been tried and not before.
27719 * statement.cs (Switch.Emit): return the actual coverage for this
27720 statement (returns/not-returns)
27722 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27723 switch of the statement if we are the last switch section. That
27724 kills two problems: try/catch problems (we used to emit an empty
27725 nop at the end) and switch statements where all branches would
27728 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27730 * driver.cs: Add default assemblies (the equivalent to the
27731 Microsoft CSC.RSP file)
27733 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27734 also update tokens_seen and set it to false.
27736 * driver.cs: Implement --recurse for Mike.
27738 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27739 correctly splitting out the paths.
27741 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27743 * interface.cs (Interface.PopulateProperty): Instead of using
27744 `parent' as the declaration space for the set parameters, use
27747 * support.cs (InternalParameters): InternalParameters constructor
27748 takes a DeclSpace instead of a TypeContainer.
27750 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27751 types are being initialized, load the address of it before calling
27754 (New): Provide a mechanism to disable the generation of local
27755 value type temporaries when the caller will be providing us with
27756 an address to store it.
27758 (ArrayCreation.EmitDynamicInitializers): Use it.
27760 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27762 * expression.cs (Invocation.EmitArguments): Only probe for array
27763 property if there is more than one argument. Sorry about that.
27765 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27766 empty param arrays.
27768 * class.cs (Method.LabelParameters): Fix incorrect code path that
27769 prevented the `ParamArrayAttribute' from being applied to the
27772 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27774 * support.cs (ReflectionParameters): Correctly compute whether the
27775 last argument is a params array. Fixes the problem with
27778 * typemanager.cs: Make the assemblies array always be non-null
27779 (empty, but non-null)
27781 * tree.cs (RecordDecl): New function that abstracts the recording
27782 of names. This reports error 101, and provides a pointer to the
27783 previous declaration. Fixes a crash in the compiler.
27785 * cs-parser.jay (constructor_declaration): Update to new grammar,
27786 and provide a constructor_body that can be empty.
27788 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27790 * driver.cs: Add support for --resources.
27792 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27793 Make all types for the various array helper methods be integer.
27795 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27796 CheckState to ConvCast.
27798 (ConvCast): Now it takes a `checked' state argument, to avoid
27799 depending on the emit context for the conversion, and just using
27800 the resolve time setting.
27802 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27803 instead of Invocation.EmitArguments. We do not emit the original
27804 arguments, instead we emit those which have been converted to
27805 unsigned int expressions.
27807 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27809 * codegen.cs: ditto.
27811 * expression.cs (LocalVariableReference): Drop the use of the
27812 Store function that depended on the variable index.
27814 * statement.cs (VariableInfo): Drop the `Idx' property from this
27815 class, as this is not taking into account the indexes for
27816 temporaries tat we generate during the execution, getting the
27819 * class.cs: First emit class initializers, then call the parent
27822 * expression.cs (Binary): Fix opcode emision.
27823 (UnaryMutator.EmitCode): Support checked code generation
27825 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27826 matches for events for both the Static and Instance scans,
27827 pointing to the same element. Fix that.
27829 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27831 * rootcontext.cs (ResolveTree): Always set the
27832 interface_resolve_order, because nested interfaces will be calling
27835 * class.cs (GetInterfaceOrClass): Track the same resolution
27836 process used by TypeManager.LookupType. This fixes the nested
27837 type lookups in class declarations (separate path from
27840 (TypeContainer.DefineType): Also define nested interfaces.
27841 (TypeContainer.RegisterOrder): New public function used to
27842 register the order in which child interfaces need to be closed.
27844 Nested interfaces need to be closed after their parents have been
27847 * interface.cs (InterfaceAttr): Put all the logic for computing
27848 the interface attribute here.
27850 (DefineInterface): Register our interface order with the
27851 RootContext or with the TypeContainer depending on the case.
27853 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27855 * cs-parser.jay: rework foreach statement to work with the new
27856 changes to the policy on SimpleNames.
27858 * report.cs: support Stacktrace on warnings as well.
27860 * makefile: drop --unsafe and /unsafe from the compile.
27862 2002-03-13 Ravi Pratap <ravi@ximian.com>
27864 * ecore.cs (StandardConversionExists): Modify to take an Expression
27865 as the first parameter. Ensure we do null -> reference type conversion
27868 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27869 temporary Expression objects.
27871 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27873 * interface.cs: workaround bug in method overloading resolution
27874 (there is already a bugzilla bug for it).
27876 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27878 We could also solve this problem by having a separate path for
27879 performing type lookups, instead of DoResolve, we could have a
27880 ResolveType entry point, and only participating pieces of the
27881 production (simplename, deref, array) would implement this.
27883 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27884 signal SimpleName to only resolve type names and not attempt to
27885 resolve anything else.
27887 * expression.cs (Cast): Set the flag.
27889 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27891 * class.cs: Only report 108 if there is no `new' modifier.
27893 * cs-parser.jay: rework foreach statement to work with the new
27894 changes to the policy on SimpleNames.
27896 * report.cs: support Stacktrace on warnings as well.
27898 * makefile: drop --unsafe and /unsafe from the compile.
27900 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27902 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27903 lookups here, instead of doing that at parse time. This means
27904 that our grammar will not introduce `LocalVariableReferences' as
27905 expressions at this point. That solves the problem of code like
27909 static void Main ()
27913 This is only half the fix. The full fix requires parameters to
27914 also be handled in this way.
27916 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27917 makes the use more obvious of the DeclSpace. The
27918 ec.TypeContainer.TypeBuilder is now only used to pull the
27919 TypeBuilder for it.
27921 My theory is that I can get rid of the TypeBuilder completely from
27922 the EmitContext, and have typecasts where it is used (from
27923 DeclSpace to where it matters).
27925 The only pending problem is that the code that implements Aliases
27926 is on TypeContainer, and probably should go in DeclSpace.
27928 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27929 lookups here, instead of doing that at parse time. This means
27930 that our grammar will not introduce `LocalVariableReferences' as
27931 expressions at this point. That solves the problem of code like
27935 static void Main ()
27939 This is only half the fix. The full fix requires parameters to
27940 also be handled in this way.
27942 * class.cs (Property.DefineMethod): When implementing an interface
27943 method, set newslot, when implementing an abstract method, do not
27944 set the flag (before we tried never setting it, or always setting
27945 it, which is the difference).
27946 (Indexer.DefineMethod): same.
27947 (Method.DefineMethod): same.
27949 * ecore.cs: Only set the status used flag if we get back a Field.
27951 * attribute.cs: Temporary hack, so Paolo can keep working.
27953 2002-03-08 Ravi Pratap <ravi@ximian.com>
27955 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27956 the unmanaged type in the case we have a MarshalAs attribute.
27958 (Resolve): Handle the case when we are parsing the special MarshalAs
27959 attribute [we need to store the unmanaged type to use later]
27961 * typemanager.cs (marshal_as_attr_type): Built in type for the
27962 MarshalAs Attribute.
27964 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27965 on parameters and accordingly set the marshalling info.
27967 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27969 * class.cs: Optimizing slightly by removing redundant code after
27970 we switched to the `NoTypes' return value.
27971 (Property.DefineMethod): use NoTypes here too.
27973 This fixes the bug I introduced in my last batch of changes.
27975 2002-03-05 Ravi Pratap <ravi@ximian.com>
27977 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27979 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27980 Enums since those are types too.
27982 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27984 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27985 thanks to a call during the lookup process.
27987 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27989 * statement.cs (Foreach): Lots of work to accomodate a particular
27990 kind of foreach statement that I had not kept in mind. It is
27991 possible to have foreachs on classes that provide a GetEnumerator
27992 method that return objects that implement the "pattern" for using
27993 a foreach, there is no need to support GetEnumerator
27996 This is needed to compile nant.
27998 * decl.cs: Only report 114 if the member is not `Finalize' and if
27999 the warning level is at least 2.
28001 * class.cs: Moved the compare function from Method to
28004 (MethodSignature.InheritableMemberSignatureCompare): Add new
28005 filter function that is used to extract inheritable methods from a
28008 (Method.Define): Use the new `inheritable_method_signature_filter'
28011 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28014 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28016 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28018 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28020 * expression.cs: Pass location information to
28021 ConvertImplicitStandard.
28023 * class.cs: Added debugging code to track return values from
28026 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28028 * expression.cs (Is.DoResolve): If either side of the `is' is an
28029 interface, do not flag the warning.
28031 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28034 * report.cs: Allow for --fatal to be used with --probe.
28036 * typemanager.cs (NoTypes): Move the definition for the empty Type
28039 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28041 (TypeContainer.DefineProxy): New function used to proxy to parent
28042 implementations when implementing interfaces.
28043 (TypeContainer.ParentImplements): used to lookup if our parent
28044 implements a public function that is required by an interface.
28045 (TypeContainer.VerifyPendingMethods): Hook this up.
28047 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28048 `modules' and `assemblies' arraylists into arrays. We only grow
28049 these are the very early start up of the program, so this improves
28050 the speedof LookupType (nicely measured).
28052 * expression.cs (MakeByteBlob): Replaced unsafe code with
28053 BitConverter, as suggested by Paolo.
28055 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28056 folding of string concatenation, but if either side is a string,
28057 and the other is not, then return null, and let the runtime use
28058 the concatenation on the string plus the object (using
28059 `Object.ToString').
28061 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28063 Constant Folding has been implemented now.
28065 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28066 the error instead on types that are not supported in one's
28069 * constant.cs (Constant and all children): New set of functions to
28070 perform implict and explicit conversions.
28072 * ecore.cs (EnumConstant): Implement the new functions to perform
28073 conversion by proxying to the child expression.
28075 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28076 own separate setting that can not be turned off from the command
28077 line using --unchecked or --checked and is only controlled using
28078 the checked/unchecked statements and expressions. This setting is
28079 used by the constant folder to flag errors.
28081 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28082 ConstantCheckState as well.
28084 During Resolve, they also have to flag the state, because the
28085 constant folder runs completely in the Resolve phase.
28087 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28090 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28092 * cfold.cs: New file, this file contains the constant folder.
28094 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28095 argument to track whether we are using the resulting address to
28096 load or store a value and provide better error messages.
28098 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28099 new AddressOf arguments.
28101 * statement.cs (Foreach.EmitCollectionForeach): Update
28103 * expression.cs (Argument.Emit): Call AddressOf with proper
28104 arguments to track usage.
28106 (New.DoEmit): Call AddressOf with new arguments.
28108 (Unary.Emit): Adjust AddressOf call.
28110 2002-03-01 Ravi Pratap <ravi@ximian.com>
28112 * cs-parser.jay (member_access): Change the case for pre-defined types
28113 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28116 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28119 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28120 essentially like methods and apply attributes like MethodImplOptions to them too.
28122 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28125 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28126 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28129 * Update code everywhere accordingly.
28131 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28133 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28135 2002-02-28 Ravi Pratap <ravi@ximian.com>
28137 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28138 try performing lookups against those instead of jumping straight into using
28139 the 'using' clauses.
28141 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28143 (LookupType): Perform lookups in implicit parents too.
28145 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28146 sequence as RootContext.LookupType.
28148 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28149 the various cases of namespace lookups into this method.
28151 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28153 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28154 in positional arguments)
28156 * class.cs (Operator): Update the AllowedModifiers to contain
28159 * cs-parser.jay: Update operator declaration to allow for the
28160 operator body to be empty.
28162 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28165 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28167 * class.cs (Method.Emit): Label parameters.
28169 * driver.cs: Return 1 or 0 as the program exit code.
28171 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28173 * expression.cs: Special case the `null' object when trying to
28174 auto-compute the type, as anything can be explicitly converted to
28177 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28178 spotting this Paolo.
28180 (Expression.ImplicitNumericConversion): Perform comparissions of
28181 the type using the underlying type in the case of an enumeration
28182 rather than using the enumeration type for the compare.
28184 Cope with the underlying == type case, which is not possible to
28187 (Expression.ConvertNumericExplicit): Perform comparissions of
28188 the type using the underlying type in the case of an enumeration
28189 rather than using the enumeration type for the compare.
28191 * driver.cs: If the user does not supply an extension, assume .exe
28193 * cs-parser.jay (if_statement): Rewrote so that we can track the
28194 location for the if statement.
28196 * expression.cs (Binary.ConstantFold): Only concat strings when
28197 the operation is "+", not everything ;-)
28199 * statement.cs (Statement.EmitBoolExpression): Take a location
28201 (If, While, Do): Track location.
28203 * expression.cs (Binary.ResolveOperator): In the object + string
28204 case, I was missing a call to ConvertImplicit
28206 2002-02-25 Ravi Pratap <ravi@ximian.com>
28208 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28209 Location arguments. Ensure we use RootContext.LookupType to do our work
28210 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28212 * interface.cs (PopulateMethod): Handle the type of the parameter being
28215 * expression.cs (Invocation.BetterFunction): Handle the case when we
28216 have a params method with no fixed arguments and a call is made with no
28219 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28221 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28222 the verbatim-string-literal
28224 * support.cs (InternalParameters.ParameterModifier): handle null
28226 (InternalParameters.ParameterType): ditto.
28228 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28229 duplicating the name of the variable parameter.
28230 (GetParameterByName): Fix bug where we were not looking up array
28231 paramters if they were the only present (thanks Paolo!).
28232 (GetParameterInfo): We only have an empty set of types if both
28233 fixed and array are set to null.
28234 (GetParameterInfo-idx): Handle FixedParameter == null
28236 * cs-parser.jay: Handle the case where there is no catch
28237 statements (missing null test).
28239 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28241 * driver.cs (MainDriver): Be conservative on our command line
28244 Catch DirectoryNotFoundException when calling GetFiles.
28246 (SplitPathAndPattern): Used to split the input specification into
28247 a path and a pattern that we can feed to Directory.GetFiles.
28249 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28251 * statement.cs (Fixed): Implement the last case of the Fixed
28252 statement (string handling).
28254 * expression.cs (StringPtr): New class used to return a char * to
28255 a string; Used by the Fixed statement.
28257 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28259 * expression.cs (Binary.ResolveOperator): Remove redundant
28260 MemberLookup pn parent type.
28261 Optimize union call, we do not need a union if the types are the same.
28262 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28265 Specialize the use of MemberLookup everywhere, instead of using
28266 the default settings.
28268 (StackAlloc): Implement stackalloc keyword.
28270 * cs-parser.jay: Add rule to parse stackalloc.
28272 * driver.cs: Handle /h, /help, /?
28274 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28275 before we supported unsafe code.
28277 * makefile: add --unsafe to the self compilation of mcs.
28279 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28281 * expression.cs (PointerArithmetic): New class that is used to
28282 perform pointer arithmetic.
28283 (Binary.Resolve): Handle pointer arithmetic
28284 Handle pointer comparission.
28285 (ArrayPtr): Utility expression class that is used to take the
28286 address of an array.
28288 (ElementAccess): Implement array access for pointers
28290 * statement.cs (Fixed): Implement fixed statement for arrays, we
28291 are missing one more case before we are done.
28293 * expression.cs (Indirection): Implement EmitAssign and set the
28294 ExprClass to Variable. This allows pointer dereferences to be
28295 treated as variables, and to have values assigned to them.
28297 * ecore.cs (Expression.StoreFromPtr): New utility function to
28298 store values dereferencing.
28300 2002-02-20 Ravi Pratap <ravi@ximian.com>
28302 * expression.cs (Binary.ResolveOperator): Ensure that we are
28303 not trying to operate on a void type - this fixes the reported
28306 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28307 the parent implementation is sealed.
28309 * ../errors/cs0239.cs : Add.
28311 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28313 * typemanager.cs (unverifiable_code_type): Corresponds to
28314 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28315 which have unsafe code in them.
28317 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28320 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28322 * cs-tokenizer.cs: Add support for @"litreal strings"
28324 Make tokenizer accept pre-processor directives
28325 on any column (remove the old C-like limitation).
28327 * rootcontext.cs (EmitCode): Emit any global attributes.
28328 (AddGlobalAttributes): Used to keep track of assembly attributes.
28330 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28332 * cs-parser.jay: Add support for global attributes.
28334 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28336 * expression.cs (Indirection): New helper class. Unary will
28337 create Indirection classes to be able to implement the
28338 IMemoryLocation interface on it.
28340 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28342 * cs-parser.jay (fixed_statement): reference the right statement.
28344 * statement.cs (Fixed.Emit): Finish implementing the fixed
28345 statement for the &x case.
28347 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28349 * class.cs (Property.Define, Method.Define): Remove newslot when
28352 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28353 wrong. NewSlot should only be used if the `new' keyword is present.
28355 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28356 locating our system dir. Sorry about this.
28358 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28360 * driver.cs (GetSystemDir): Compute correctly the location of our
28361 system assemblies. I was using the compiler directory instead of
28362 the library directory.
28364 2002-02-13 Ravi Pratap <ravi@ximian.com>
28366 * expression.cs (BetterFunction): Put back in what Miguel commented out
28367 since it is the correct fix. The problem is elsewhere ;-)
28369 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28370 parameters of the parms method are themselves compatible or not !
28372 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28373 to check that a class implements an interface before saying that an implicit
28374 conversion was allowed. Use ImplementsInterface to do the checking.
28376 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28378 * class.cs (Method.Define): Track whether we are an explicit
28379 implementation or not. And only call DefineMethodOverride if we
28380 are an explicit implementation.
28382 (Property.DefineMethod): Ditto.
28384 2002-02-11 Ravi Pratap <ravi@ximian.com>
28386 * expression.cs (BetterFunction): Catch hideous bug which was
28387 preventing us from detecting ambiguous calls due to implicit casts i.e
28390 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28392 * support.cs (Pair): Remove un-needed method. I figured why I was
28393 getting the error in cs-parser.jay, the variable in a foreach loop
28394 is readonly, and the compiler does not really treat this as a variable.
28396 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28397 instead of EQUALS in grammar.
28399 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28401 * expression.cs (Unary.DoResolve): Check whether the argument is
28404 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28406 * support.cs: Api for Pair to set a value. Despite the fact that
28407 the variables are public the MS C# compiler refuses to compile
28408 code that accesses the field if the variable is part of a foreach
28411 * statement.cs (Fixed): Begin implementation of the fixed
28414 (Block.AddVariable): Return the VariableInfo on success and null
28415 on failure instead of true/false.
28417 * cs-parser.jay (foreach): Catch errors on variables already
28418 defined (we were ignoring this value before) and properly unwind
28419 the block hierarchy
28421 (fixed_statement): grammar for the fixed statement.
28423 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28425 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28426 pointer types to be incretemented.
28428 (SizeOf): Implement.
28430 * cs-parser.jay (pointer_member_access): Implement
28431 expr->IDENTIFIER production.
28433 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28434 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28437 (Unary): Implement indirection.
28439 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28440 use in non-unsafe context).
28442 (SimpleName.DoResolve): Check for pointers in field access on safe
28445 (Expression.LoadFromPtr): Factor the load-indirect code in this
28446 function. This was duplicated in UnboxCast and ParameterReference
28448 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28450 * expression.cs (ComposedCast): report an error if a pointer cast
28451 is used in a safe region.
28453 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28454 pointer type casts in unsafe context.
28456 * codegen.cs (EmitContext): Set up IsUnsafe.
28458 * cs-parser.jay (non_expression_type): Add productions for pointer
28461 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28462 code. We should not use force into static mode if the method is
28463 not virtual. Fixes bug in MIS
28465 * statement.cs (Do.Emit, While.Emit, For.Emit,
28466 Statement.EmitBoolExpression): Add support to Do and While to
28467 propagate infinite loop as `I do return' semantics.
28469 Improve the For case to also test for boolean constants.
28471 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28472 to the list of attributes we can add.
28474 Remove `EmitContext' argument.
28476 * class.cs (Method.Define): Apply parameter attributes.
28477 (Constructor.Define): Apply parameter attributes.
28478 (MethodCore.LabelParameters): Move here the core of labeling
28481 * support.cs (ReflectionParameters.ParameterModifier,
28482 InternalParameters.ParameterModifier): Use IsByRef on the type and
28483 only return the OUT bit for these parameters instead of in/out/ref
28486 This is because I miss-understood things. The ParameterInfo.IsIn
28487 and IsOut represent whether the parameter has the [In] and [Out]
28490 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28492 * ecore.cs (FieldExpr.Emit): Release temporaries.
28494 * assign.cs (LocalTemporary.Release): new function.
28496 * codegen.cs (EmitContext.GetTemporaryStorage,
28497 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28498 temporary storage. Now we can "put back" localbuilders when we
28501 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28503 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28504 need to make a copy of the variable to generate verifiable code.
28506 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28508 * driver.cs: Compute dynamically the system directory.
28510 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28511 Slower, but more generally useful. Used by the abstract
28512 registering implementation.
28514 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28515 the rules for the special rule on Type/instances. First check if
28516 we have the same name, and if so, try that special static path
28517 rather than the instance path.
28519 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28521 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28524 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28525 Enum, ValueType, Delegate or Array for non-corlib compiles.
28527 * cs-tokenizer.cs: Catch long identifiers (645)
28529 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28532 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28533 fix, we were returning too early, so we were not registering
28534 pending methods from abstract classes.
28536 Do not register pending methods if the class is abstract.
28538 * expression.cs (Conditional.DoResolve): Report circular implicit
28539 conversions when we neecd to compute it for conditional
28542 (Is.DoResolve): If the expression is always of the provided type,
28543 flag warning 183. If the expression can not ever be of the
28544 provided type flag warning 184.
28546 * class.cs: Catch 169 as well.
28548 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28551 2002-01-18 Nick Drochak <ndrochak@gol.com>
28553 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28555 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28557 * interface.cs: (PopulateMethod): Check for pointers being defined
28558 only if the unsafe context is active.
28559 (PopulateProperty): ditto.
28560 (PopulateIndexer): ditto.
28562 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28563 specified. If pointers are present, make sure that they are
28564 present in an unsafe context.
28565 (Constructor, Constructor.Define): ditto.
28566 (Field, Field.Define): ditto.
28567 (Property, Property.Define): ditto.
28568 (Event, Event.Define): ditto.
28570 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28571 hashtable if there are classes or structs defined.
28573 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28574 code, as the constant resolution moved.
28576 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28577 the metadata, so we can flag error 133.
28579 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28580 pointer is being declared in an unsafe context.
28582 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28584 * modifiers.cs (Modifiers.Check): Require a Location argument.
28585 Report error 227 for Unsafe use.
28587 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28589 * statement.cs (For.Emit): If the test is null, then report that
28590 we do `return', as we wont reach anything afterwards.
28592 (Switch.SwitchGoverningType): Track the expression that matched
28595 * driver.cs: Allow negative numbers as an error code to flag.
28597 * cs-parser.jay: Handle 1551.
28599 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28601 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28603 * cs-parser.jay: Report 1518 (type declaration can only contain
28604 class, struct, interface, enum or delegate)
28606 (switch_label): Report 1523 (keywords `case' or `default' must
28609 (opt_switch_sections): Report 1522 (empty switch)
28611 * driver.cs: Report 1515 (response file specified multiple times)
28612 Report 1516 (Source file specified multiple times).
28614 * expression.cs (Argument.Resolve): Signal 1510
28616 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28617 access not allowed in static code)
28619 2002-01-11 Ravi Pratap <ravi@ximian.com>
28621 * typemanager.cs (IsPointerType): Utility method which we are going
28624 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28625 the object type, so we take care of that.
28627 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28629 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28630 added to non-params parameters :-)
28632 * typemanager.cs (CSharpName): Include 'void' type too.
28634 (void_ptr_type): Include in the set of core types.
28636 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28639 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28642 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28643 completely forgotten about it.
28645 2002-01-10 Ravi Pratap <ravi@ximian.com>
28647 * cs-parser.jay (pointer_type): Add. This begins our implementation
28648 of parsing rules for unsafe code.
28650 (unsafe_statement): Implement.
28652 (embedded_statement): Modify to include the above.
28654 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28656 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28657 if the current context is an unsafe one.
28659 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28660 are handled differently, we need separate rules for them.
28662 (local_variable_declaration): Update to use local_variable_pointer_type
28663 to allow variable declarations of unmanaged pointer types.
28665 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28666 in unsafe contexts.
28668 * ../errors/cs0214.cs : Add.
28670 2002-01-16 Nick Drochak <ndrochak@gol.com>
28672 * makefile: remove 'response' file when cleaning.
28674 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28676 * cs-parser.jay: Report 1524.
28678 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28680 * typemanager.cs (RegisterMethod): drop checking if we have
28681 registered this from here
28683 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28685 * class.cs (Method.EmitDestructor): Implement calling our base
28688 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28689 value of InFinally.
28691 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28692 this routine and will wrap the call in a try/catch block. Deal
28695 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28697 * ecore.cs (Expression.MemberLookup): instead of taking a
28698 parameter `same_type' that was used to tell whether we could
28699 access private members we compute our containing type from the
28702 (FieldExpr): Added partial support for volatile fields. This does
28703 not work for volatile fields exposed from assemblies, as I can not
28704 figure out how to extract the modreq from it.
28706 Updated all the source files to use this.
28708 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28709 because it is referenced by MemberLookup very often.
28711 2002-01-09 Ravi Pratap <ravi@ximian.com>
28713 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28714 TypeBuilder.GetCustomAttributes to retrieve what we need.
28716 Get rid of redundant default_member_attr_type as this is the same as
28717 default_member_type which already exists.
28719 * interface.cs, attribute.cs : Update accordingly.
28721 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28723 * typemanager.cs: Enable IndexerPropertyName again. It does not
28724 work for TYpeBuilders though. Ravi, can you please fix this?
28726 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28728 * expression.cs (Argument.Emit): Handle the case of ref objects
28729 being passed to ref functions;
28731 (ParameterReference.EmitLoad): Loads the content of the pointer
28732 without dereferencing.
28734 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28736 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28738 2002-01-08 Ravi Pratap <ravi@ximian.com>
28740 * class.cs (Indexer.DefineMethod): Incorporate the interface
28741 type in the name of the method if we are doing explicit interface
28744 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28746 (BetterConversion): Fix extremely trivial bug where we were referring to
28747 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28750 * ../errors/bug16.cs : Add although we have fixed it.
28752 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28754 * expression.cs (BaseIndexer): Begin implementation.
28756 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28758 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28759 production directly to remove a shift/reduce, and implement
28760 explicit interface implementation.
28762 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28763 after a floating point suffix.
28765 * expression.cs (DoNumericPromotions): Improved the conversion for
28766 uint/uint. If we have a constant, we avoid doing a typecast to a
28769 * class.cs (Indexer): Implement explicit interface implementation
28772 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28774 * class.cs: make the default instance constructor public and hidebysig.
28776 2001-01-03 Ravi Pratap <ravi@ximian.com>
28778 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28779 so we can call it from elsewhere.
28781 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28782 we emit it internally if the class has a defined indexer; otherwise the user
28783 emits it by decorating the class definition with the DefaultMemberAttribute.
28785 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28786 attribute is not used on a type which defines an indexer.
28788 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28789 character when we skip whitespace.
28791 * ../errors/cs0646.cs : Add.
28793 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28795 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28798 * makefile: Add practical target `mcs3.exe' which builds the third
28799 generation compiler.
28801 * expression.cs (New): Fix structures constructor calling.
28803 * class.cs (Property, Method, Indexer): Emit Final flag on the
28804 method if we are an interface implementation and we are not
28807 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28808 whether this property is referencing a `base' method.
28810 * expression.cs (Invocation.EmitCall): take an extra argument:
28811 is_base, this is used to determine whether the `call' or
28812 `callvirt' opcode should be used.
28815 * delegate.cs: update EmitCall.
28817 * class.cs (Method.Define): Set NewSlot for the cases where we are
28818 not implementing an interface method.
28820 (Property.Define): ditto.
28822 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28824 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28825 'r'. Allows mcs to parse itself fully.
28827 2002-01-02 Ravi Pratap <ravi@ximian.com>
28829 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28830 of the number of initializers that require the InitializeArray method.
28832 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28833 update the above field where necessary.
28835 (MakeByteBlob): Update accordingly.
28837 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28840 (EmitDynamicInitializers): Update in accordance with the new optimization.
28842 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28843 same OpCode applies.
28845 * cs-parser.jay : Fix some glaring errors I introduced.
28847 2002-01-01 Ravi Pratap <ravi@ximian.com>
28849 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28850 so that we can check for name clashes there too.
28852 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28853 for interface indexers.
28855 * interfaces.cs (Define): Emit the default member attribute.
28857 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28858 variable was being referred to while setting the value ;-)
28860 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28862 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28863 byte-by-byte information when we know the data is zero.
28865 Make the block always a multiple of 4, because
28866 DefineInitializedData has a bug.
28868 * assign.cs: Fix, we should assign from the temporary, not from
28871 * expression.cs (MakeByteBlob): Fix my incorrect code.
28873 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28875 * typemanager.cs (EnumToUnderlying): This function is used to get
28876 the underlying type from an enumeration, because it does not
28879 * constant.cs: Use the I4_S form for values between -128 and 127.
28881 * statement.cs (Block.LookupLabel): Looks up a label.
28882 (Block): Drop support for labeled blocks.
28884 (LabeledStatement): New kind of statement that represents a label
28887 (Goto): Finally implement this bad boy.
28889 * cs-parser.jay: Update to reflect new mechanism to implement
28892 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28894 * codegen.cs (EmitContext.This): a codegen property that keeps the
28895 a single instance of this instead of creating many different this
28898 * delegate.cs (Delegate.DoResolve): Update to use the property;
28900 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28902 * expression.cs (BaseAccess.DoResolve): Ditto.
28904 2001-12-29 Ravi Pratap <ravi@ximian.com>
28906 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28907 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28909 (InitCoreTypes): Update accordingly.
28911 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28912 so we can quickly store the state.
28914 (ApplyAttributes): Set the correct implementation flags
28915 for InternalCall methods.
28917 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28919 * expression.cs (EmitCall): if a method is not virtual, then do
28920 not use callvirt on it.
28922 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28923 user defined stuff) requires the use of stobj, which takes an
28924 address on the stack instead of an array and an index. So emit
28925 the Ldelema operation for it.
28927 (EmitStoreOpcode): Use stobj for valuetypes.
28929 (UnaryMutator.EmitCode): Use the right 1 value depending on
28930 whether we are dealing with int64/uint64, float or doubles.
28932 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28933 constructors that I implemented last night.
28935 (Constructor.IsDefault): Fix to work properly for static
28938 * cs-parser.jay (CheckDef): report method signature errors.
28939 Update error number 103 to be 132.
28941 * decl.cs: New AdditionResult enumeration value: MethodExists.
28942 Although we do this check for methods later on in the semantic
28943 analysis, catching repeated default constructors is so easy that
28944 we catch these here.
28946 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28949 (ParameterReference.EmitAssign, Emit): handle
28952 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28953 (ArrayAccess.EmitStoreOpcode): ditto.
28955 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28957 * expression.cs (MakeByteBlob): Complete all the missing types
28958 (uint, short, ushort, byte, sbyte)
28960 * class.cs: Only init instance field initializers on instance
28963 Rename `constructors' to instance_constructors.
28965 (TypeContainer.AddConstructor): Only add constructors to the list
28966 if it is not static.
28968 Make sure that we handle default_static_constructor independently
28969 everywhere where we handle instance_constructors
28971 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28973 * class.cs: Do not lookup or create a base initializer for a
28974 static constructor.
28976 (ConstructorInitializer.Resolve): use the proper type to lookup
28979 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28981 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28984 * decl.cs: CloseType is now an virtual method, the default
28985 implementation just closes this type.
28987 2001-12-28 Ravi Pratap <ravi@ximian.com>
28989 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28990 to PreserveSig by default. Also emit HideBySig on such methods.
28992 Basically, set the defaults to standard values.
28994 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28995 argument, if candidate is better, it can't be worse than the best !
28997 (Invocation): Re-write bits to differentiate between methods being
28998 applicable in their expanded form and their normal form - for params
29001 Get rid of use_standard everywhere as only standard conversions are allowed
29002 in overload resolution.
29004 More spec conformance.
29006 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29008 * driver.cs: Add --timestamp, to see where the compiler spends
29011 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29012 `this' in static code.
29014 (SimpleName.DoResolve): Implement in terms of a helper function
29015 that allows static-references to be passed upstream to
29018 (Expression.ResolveWithSimpleName): Resolve specially simple
29019 names when called by MemberAccess to implement the special
29022 (Expression.ImplicitReferenceConversion): Handle conversions from
29023 Null to reference types before others, as Null's type is
29026 * expression.cs (Invocation.EmitCall): Handle the special case of
29027 calling methods declared on a reference type from a ValueType
29028 (Base classes System.Object and System.Enum)
29030 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29031 the left hand side is a TypeExpr, not on every enumeration.
29033 (Binary.Resolve): If types are reference types, then do a cast to
29034 object on operators != and == of both arguments.
29036 * typemanager.cs (FindMembers): Extract instance and static
29037 members if requested.
29039 * interface.cs (PopulateProperty): Use void_type instead of null
29040 as the return type for the setter method.
29042 (PopulateIndexer): ditto.
29044 2001-12-27 Ravi Pratap <ravi@ximian.com>
29046 * support.cs (ReflectionParameters): Fix minor bug where we
29047 were examining the wrong parameter for the ParamArray attribute.
29049 Cope with requests for the type of the parameter at position
29050 greater than the params parameter's. We now return the element
29051 type of the params array as that makes more sense.
29053 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29054 accordingly as we no longer have to extract the element type
29057 (Invocation.OverloadResolve): Update.
29059 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29061 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29062 against IEnumerator, test whether the return value is a descendant
29063 of the IEnumerator interface.
29065 * class.cs (Indexer.Define): Use an auxiliary method to implement
29066 the other bits of the method definition. Begin support for
29067 explicit interface implementation.
29069 (Property.DefineMethod): Use TypeManager.void_type instead of null
29070 for an empty return value.
29072 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29074 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29075 dealing with a FieldExpr which is composed of a FieldBuilder, in
29076 the code path we did extract the constant, but we should have
29077 obtained the underlying value to be able to cast it (otherwise we
29078 end up in an infinite loop, this is what Ravi was running into).
29080 (ArrayCreation.UpdateIndices): Arrays might be empty.
29082 (MemberAccess.ResolveMemberAccess): Add support for section
29083 14.5.4.1 that deals with the special case of E.I when E is a type
29084 and something else, that I can be a reference to a static member.
29086 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29087 handle a particular array type to create byte blobs, it is just
29088 something we dont generate byteblobs for.
29090 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29093 * location.cs (Push): remove the key from the hashtable that we
29094 are about to add. This happens for empty files.
29096 * driver.cs: Dispose files after we have parsed them.
29098 (tokenize): new function that only runs the tokenizer on its
29099 input, for speed testing.
29101 2001-12-26 Ravi Pratap <ravi@ximian.com>
29103 * class.cs (Event.Define): Define the private field only if there
29104 are no accessors defined.
29106 * expression.cs (ResolveMemberAccess): If there is no associated
29107 field with the event, that means we have an event defined with its
29108 own accessors and we should flag error cs0070 since transforming
29109 ourselves into a field is not valid in that case.
29111 * ecore.cs (SimpleName.DoResolve): Same as above.
29113 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29114 and charset to sane values.
29116 2001-12-25 Ravi Pratap <ravi@ximian.com>
29118 * assign.cs (DoResolve): Perform check on events only if they
29119 are being accessed outside the declaring type.
29121 * cs-parser.jay (event_declarations): Update rules to correctly
29122 set the type of the implicit parameter etc.
29124 (add_accessor, remove_accessor): Set current local parameters.
29126 * expression.cs (Binary): For delegate addition and subtraction,
29127 cast the return value from the method into the appropriate delegate
29130 2001-12-24 Ravi Pratap <ravi@ximian.com>
29132 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29133 of these as the workaround is unnecessary.
29135 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29136 delegate data - none of that is needed at all.
29138 Re-write bits to extract the instance expression and the delegate method
29141 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29144 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29145 of attaching attributes instead of duplicating code everywhere.
29147 * everywhere : Update code to do attribute emission using the above method.
29149 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29151 * expression.cs (IsParamsMethodApplicable): if there are not
29152 parameters, return immediately.
29154 * ecore.cs: The 0 literal can be implicity converted to an enum
29157 (SimpleName.DoResolve): First lookup the type, then lookup the
29160 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29161 want to get its address. If the InstanceExpression is not
29162 addressable, store the result in a temporary variable, then get
29165 * codegen.cs: Only display 219 errors on warning level or above.
29167 * expression.cs (ArrayAccess): Make it implement the
29168 IMemoryLocation interface.
29170 (Binary.DoResolve): handle the operator == (object a, object b)
29171 and operator != (object a, object b) without incurring into a
29172 BoxedCast (because 5 != o should never be performed).
29174 Handle binary enumerator operators.
29176 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29177 value type, otherwise use Ldelem_ref.
29179 Use precomputed names;
29181 (AddressOf): Implement address of
29183 * cs-parser.jay (labeled_statement): Fix recursive block
29184 addition by reworking the production.
29186 * expression.cs (New.DoEmit): New has a special case:
29188 If we are dealing with a ValueType, we have a few
29189 situations to deal with:
29191 * The target of New is a ValueType variable, that is
29192 easy, we just pass this as the variable reference
29194 * The target of New is being passed as an argument,
29195 to a boxing operation or a function that takes a
29198 In this case, we need to create a temporary variable
29199 that is the argument of New.
29202 2001-12-23 Ravi Pratap <ravi@ximian.com>
29204 * rootcontext.cs (LookupType): Check that current_type is not null before
29205 going about looking at nested types.
29207 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29208 not implement the IAssignMethod interface any more.
29210 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29211 where we tranform them into FieldExprs if they are being resolved from within
29212 the declaring type.
29214 * ecore.cs (SimpleName.DoResolve): Do the same here.
29216 * assign.cs (DoResolve, Emit): Clean up code considerably.
29218 * ../errors/bug10.cs : Add.
29220 * ../errors/cs0070.cs : Add.
29222 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29224 * assign.cs : Get rid of EventIsLocal everywhere.
29226 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29228 * ecore.cs (ConvertIntLiteral): finished the implementation.
29230 * statement.cs (SwitchLabel): Convert the value we are using as a
29231 key before looking up the table.
29233 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29235 * codegen.cs (EmitTopBlock): Require a Location argument now.
29237 * cs-parser.jay (constructor_declarator): We need to setup
29238 current_local_parameters before we parse the
29239 opt_constructor_initializer, to allow the variables to be bound
29240 to the constructor arguments.
29242 * rootcontext.cs (LookupType): First lookup nested classes in our
29243 class and our parents before we go looking outside our class.
29245 * expression.cs (ConstantFold): Extract/debox the values at the
29248 * rootcontext.cs (EmitCode): Resolve the constants first before we
29249 resolve the types. This is not really needed, but it helps debugging.
29251 * statement.cs: report location.
29253 * cs-parser.jay: pass location to throw statement.
29255 * driver.cs: Small bug fix.
29257 * report.cs: Updated format to be 4-zero filled digits.
29259 2001-12-22 Ravi Pratap <ravi@ximian.com>
29261 * expression.cs (CheckIndices): Fix minor bug where the wrong
29262 variable was being referred to ;-)
29264 (DoEmit): Do not call EmitStaticInitializers when the
29265 underlying type is System.Object.
29267 2001-12-21 Ravi Pratap <ravi@ximian.com>
29269 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29270 and do the usual workaround for SRE.
29272 * class.cs (MyEventBuilder.EventType): New member to get at the type
29273 of the event, quickly.
29275 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29277 * assign.cs (Assign.DoResolve): Handle the case when the target
29278 is an EventExpr and perform the necessary checks.
29280 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29283 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29285 (EventExpr): Set the type in the constructor itself since we
29286 are meant to be born fully resolved.
29288 (EventExpr.Define): Revert code I wrote earlier.
29290 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29291 instance expression is null. The instance expression is a This in that case
29292 or a null, depending on whether it is a static method or not.
29294 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29295 refers to more than one method.
29297 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29298 and accordingly flag errors.
29300 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29302 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29304 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29306 * location.cs (ToString): Provide useful rutine.
29308 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29310 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29311 objects, return the actual integral boxed.
29313 * statement.cs (SwitchLabel): define an ILLabel for each
29316 (Switch.CheckSwitch): If the value is a Literal, extract
29317 the underlying literal.
29319 Also in the unused hashtable we had, add the SwitchLabel so we can
29320 quickly look this value up.
29322 * constant.cs: Implement a bunch of new constants. Rewrite
29323 Literal based on this. Made changes everywhere to adapt to this.
29325 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29326 dereferencing array only once, and also copes with enumrations.
29328 bytes are two bytes wide, not one.
29330 (Cast): Perform constant conversions.
29332 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29333 wrappers to the literals here.
29335 * expression.cs (DoNumericPromotions): long literals can converted
29336 to ulong implicity (this is taken care of elsewhere, but I was
29337 missing this spot).
29339 * ecore.cs (Expression.Literalize): Make the return type Literal,
29340 to improve type checking.
29342 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29344 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29346 * literal.cs: Revert code from ravi that checked the bounds. The
29347 bounds are sane by the definition of the type itself.
29349 * typemanager.cs: Fix implementation of ImplementsInterface. We
29350 need to actually look up in our parent hierarchy for interfaces
29353 * const.cs: Use the underlying type for enumerations
29355 * delegate.cs: Compute the basename for the delegate creation,
29356 that should fix the delegate test case, and restore the correct
29357 Type Lookup semantics in rootcontext
29359 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29360 referencing a nested type with the Reflection API is using the "+"
29363 * cs-parser.jay: Do not require EOF token at the end.
29365 2001-12-20 Ravi Pratap <ravi@ximian.com>
29367 * rootcontext.cs (LookupType): Concatenate type names with
29368 a '.' instead of a '+' The test suite passes again.
29370 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29371 field of the enumeration.
29373 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29374 the case when the member is an EventExpr.
29376 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29377 static has an associated instance expression.
29379 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29381 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29383 * class.cs (Event.Define): Register event and perform appropriate checks
29386 We define the Add and Remove methods even if the use provides none because
29387 in that case, we provide default implementations ourselves.
29389 Define a private field of the type of the event. This is done by the CSC compiler
29390 and we should be doing it too ;-)
29392 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29393 More methods we use in code we generate.
29395 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29398 (InitCoreTypes): Update accordingly for the above.
29400 * class.cs (Event.Emit): Generate code for default accessors that we provide
29402 (EmitDefaultMethod): Do the job in the above.
29404 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29407 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29409 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29410 builders even if we were missing one.
29412 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29413 pass the Basename as our class name instead of the Name. The
29414 basename will be correctly composed for us.
29416 * parameter.cs (Paramters): Now takes a Location argument.
29418 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29419 make all the code call directly LookupType in RootContext and take
29420 this chance to pass the Location information everywhere.
29422 * Everywhere: pass Location information.
29424 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29426 * class.cs (Constructor.Define): Updated way of detecting the
29427 length of the parameters.
29429 (TypeContainer.DefineType): Use basename as the type name for
29432 (TypeContainer.Define): Do not recursively define types here, as
29433 definition is taken care in order by the RootContext.
29435 * tree.cs: Keep track of namespaces in a per-file basis.
29437 * parameter.cs (Parameter.ComputeSignature): Update to use
29440 (Parameters.GetSignature): ditto.
29442 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29443 instead of a TypeContainer.
29445 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29446 resolve names. Because we need to be resolve in our context, not
29449 * driver.cs: Implement response files.
29451 * class.cs (TypeContainer.DefineType): If we are defined, do not
29452 redefine ourselves.
29454 (Event.Emit): Emit the code for add/remove handlers.
29455 (Event.Define): Save the MethodBuilders for add/remove.
29457 * typemanager.cs: Use pair here too.
29459 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29460 DictionaryEntry requires the first argument to be non-null.
29462 (enum_declaration): Compute full name for registering the
29465 (delegate_declaration): Instead of using
29466 formal_parameter_list, use opt_formal_parameter_list as the list
29469 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29470 (EventParsing): New property that controls whether `add' and
29471 `remove' are returned as tokens or identifiers (for events);
29473 2001-12-19 Ravi Pratap <ravi@ximian.com>
29475 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29476 use MyEventBuilder only and let it wrap the real builder for us.
29478 (MyEventBuilder): Revamp constructor etc.
29480 Implement all operations that we perform on EventBuilder in precisely the same
29483 (FindMembers): Update to use the EventBuilder member.
29485 (Event.Emit): Update accordingly.
29487 2001-12-18 Ravi Pratap <ravi@ximian.com>
29489 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29490 by calling the appropriate methods.
29492 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29495 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29497 2001-12-17 Ravi Pratap <ravi@ximian.com>
29499 * delegate.cs (Delegate.Populate): Check that the return type
29500 and various parameters types are indeed accessible.
29502 * class.cs (Constructor.Define): Same here.
29504 (Field.Define): Ditto.
29506 (Event.Define): Ditto.
29508 (Operator.Define): Check that the underlying Method defined itself
29509 correctly - so it's MethodBuilder should not be null.
29511 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29512 expression happens to be null.
29514 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29515 members but as of now we don't seem to be able to do anything really useful with it.
29517 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29518 not the EventBuilder.
29520 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29522 * cs-tokenizer.cs: Add support for defines.
29523 Add support for #if, #elif, #else, #endif
29525 (eval_var): evaluates a variable.
29526 (eval): stubbed for evaluating functions.
29528 * cs-parser.jay: Pass the defines information
29530 * driver.cs: Add --define command line option.
29532 * decl.cs: Move MemberCore here.
29534 Make it the base class for DeclSpace. This allows us to catch and
29535 report 108 and 109 for everything now.
29537 * class.cs (TypeContainer.Define): Extract all the members
29538 before populating and emit the warning 108 (new keyword required
29539 to override) instead of having each member implement this.
29541 (MemberCore.Define): New abstract method, we will be using this in
29542 the warning reporting engine in Populate.
29544 (Operator.Define): Adjust to new MemberCore protocol.
29546 * const.cs (Const): This does not derive from Expression, it is a
29547 temporary object we use to create fields, it is a MemberCore.
29549 * class.cs (Method.Define): Allow the entry point to be in a
29552 * driver.cs: Rewrite the argument handler to clean it up a bit.
29554 * rootcontext.cs: Made it just an auxiliary namespace feature by
29555 making everything static.
29557 * driver.cs: Adapt code to use RootContext type name instead of
29560 * delegate.cs: Remove RootContext argument.
29562 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29565 * class.cs (Event.Define): The lookup can fail.
29567 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29569 * expression.cs: Resolve the this instance before invoking the code.
29571 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29573 * cs-parser.jay: Add a production in element_access that allows
29574 the thing to become a "type" reference. This way we can parse
29575 things like "(string [])" as a type.
29577 Note that this still does not handle the more complex rules of
29581 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29583 * ecore.cs: (CopyNewMethods): new utility function used to
29584 assemble the list of methods from running FindMembers.
29586 (MemberLookup): Rework FindMembers so that
29588 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29590 * class.cs (TypeContainer): Remove Delegates who fail to be
29593 * delegate.cs (Populate): Verify that we dont get null return
29594 values. TODO: Check for AsAccessible.
29596 * cs-parser.jay: Use basename to emit error 574 (destructor should
29597 have the same name as container class), not the full name.
29599 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29600 possible representation.
29602 Also implements integer type suffixes U and L.
29604 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29606 * expression.cs (ArrayCreation.DoResolve): We need to do the
29607 argument resolution *always*.
29609 * decl.cs: Make this hold the namespace. Hold the root context as
29611 (LookupType): Move here.
29613 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29615 * location.cs (Row, Name): Fixed the code, it was always returning
29616 references to the first file.
29618 * interface.cs: Register properties defined through interfaces.
29620 * driver.cs: Add support for globbing on the command line
29622 * class.cs (Field): Make it derive from MemberCore as well.
29625 2001-12-15 Ravi Pratap <ravi@ximian.com>
29627 * class.cs (Event::Define): Check that the type of the event is a delegate
29628 type else flag error #66.
29630 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29633 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29634 values of EntryPoint, CharSet etc etc.
29636 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29638 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29639 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29640 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29641 which needs this to do its work.
29643 * ../errors/cs0066.cs : Add.
29645 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29647 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29650 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29651 clears out the parameters field.
29652 (MemberSignatureCompare): Cleanup
29654 (MemberCore): New base class used to share code between MethodCore
29657 (RegisterRequiredImplementations) BindingFlags.Public requires
29658 either BindingFlags.Instace or Static. Use instance here.
29660 (Property): Refactored code to cope better with the full spec.
29662 * parameter.cs (GetParameterInfo): Return an empty array instead
29665 * class.cs (Property): Abstract or extern properties have no bodies.
29667 * parameter.cs (GetParameterInfo): return a zero-sized array.
29669 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29670 method modifier validation to the typecontainer so we can reuse
29671 this on properties.
29673 (MethodCore.ParameterTypes): return an empty sized array of types.
29675 (Property.Define): Test property modifier validity.
29677 Add tests for sealed/override too.
29679 (Method.Emit): abstract or extern methods have no bodies.
29681 2001-12-14 Ravi Pratap <ravi@ximian.com>
29683 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29686 (Method::Define, ::Emit): Modify accordingly.
29688 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29690 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29692 * makefile: Pass in /unsafe.
29694 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29696 * class.cs (MakeKey): Kill routine.
29698 * class.cs (TypeContainer.Define): Correctly define explicit
29699 method implementations (they require the full interface name plus
29702 * typemanager.cs: Deply the PtrHashtable here and stop using the
29703 lame keys. Things work so much better.
29705 This of course broke everyone who depended on `RegisterMethod' to
29706 do the `test for existance' test. This has to be done elsewhere.
29708 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29709 the object stupid Equals method (because, that like fails all over
29710 the place). We still do not use it.
29712 * class.cs (TypeContainer.SetRequiredInterface,
29713 TypeContainer.RequireMethods): Killed these two routines and moved
29714 all the functionality to RegisterRequiredImplementations.
29716 (TypeContainer.RegisterRequiredImplementations): This routine now
29717 registers all the implementations required in an array for the
29718 interfaces and abstract methods. We use an array of structures
29719 which can be computed ahead of time to reduce memory usage and we
29720 also assume that lookups are cheap as most classes will not
29721 implement too many interfaces.
29723 We also avoid creating too many MethodSignatures.
29725 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29726 clear the "pending" bit if we find that there are problems with
29729 (TypeContainer.VerifyPendingMethods): Update to report errors of
29730 methods that look like implementations but are not.
29732 (TypeContainer.Define): Add support for explicit interface method
29735 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29737 * typemanager.cs: Keep track of the parameters here instead of
29738 being a feature of the TypeContainer.
29740 * class.cs: Drop the registration of parameters here, as
29741 InterfaceMethods are also interface declarations.
29743 * delegate.cs: Register methods with the TypeManager not only with
29744 the TypeContainer. This code was buggy.
29746 * interface.cs: Full registation here.
29748 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29750 * expression.cs: Remove reducer for binary expressions, it can not
29753 * const.cs: Put here the code that used to go into constant.cs
29755 * constant.cs: Put here the code for constants, this is a new base
29756 class for Literals.
29758 * literal.cs: Make Literal derive from Constant.
29760 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29762 * statement.cs (Return.Emit): Report error 157 if the user
29763 attempts to return from a finally block.
29765 (Return.Emit): Instead of emitting a return, jump to the end of
29768 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29769 LocalBuilder to store the result of the function. ReturnLabel is
29770 the target where we jump.
29773 2001-12-09 Radek Doulik <rodo@ximian.com>
29775 * cs-parser.jay: remember alias in current namespace
29777 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29780 * class.cs (LookupAlias): lookup alias in my_namespace
29782 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29784 (LookupAlias): lookup alias in this and if needed in parent
29787 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29791 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29792 making things static. I need this to avoid passing the
29793 TypeContainer when calling ParameterType.
29795 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29796 that did string manipulation to compute the type and then call
29797 GetType. Use Parameter.ParameterType instead.
29799 * cs-tokenizer.cs: Consume the suffix for floating values.
29801 * expression.cs (ParameterReference): figure out whether this is a
29802 reference parameter or not. Kill an extra variable by computing
29803 the arg_idx during emission.
29805 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29806 function that returns whether a parameter is an out/ref value or not.
29808 (Parameter.ParameterType): The type of the parameter (base,
29809 without ref/out applied).
29811 (Parameter.Resolve): Perform resolution here.
29812 (Parameter.ExternalType): The full type (with ref/out applied).
29814 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29815 support for expressions on the using statement.
29817 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29819 * statement.cs (Using.EmitLocalVariableDecls): Split the
29820 localvariable handling of the using statement.
29822 (Block.EmitMeta): Keep track of variable count across blocks. We
29823 were reusing slots on separate branches of blocks.
29825 (Try.Emit): Emit the general code block, we were not emitting it.
29827 Check the type of the declaration to be an IDisposable or
29828 something that can be implicity converted to it.
29830 Emit conversions if required.
29832 * ecore.cs (EmptyExpression): New utility class.
29833 (Expression.ImplicitConversionExists): New utility function.
29835 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29837 * statement.cs (Using): Implement.
29839 * expression.cs (LocalVariableReference): Support read only variables.
29841 * statement.cs: Remove the explicit emit for the Leave opcode.
29842 (VariableInfo): Add a readonly field.
29844 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29846 * ecore.cs (ConvCast): new class used to encapsulate the various
29847 explicit integer conversions that works in both checked and
29848 unchecked contexts.
29850 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29851 properly generate the overflow opcodes.
29853 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29855 * statement.cs: The correct type for the EmptyExpression is the
29856 element_type, not the variable type. Ravi pointed this out.
29858 2001-12-04 Ravi Pratap <ravi@ximian.com>
29860 * class.cs (Method::Define): Handle PInvoke methods specially
29861 by using DefinePInvokeMethod instead of the usual one.
29863 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29864 above to do the task of extracting information and defining the method.
29866 2001-12-04 Ravi Pratap <ravi@ximian.com>
29868 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29869 of the condition for string type.
29871 (Emit): Move that here.
29873 (ArrayCreation::CheckIndices): Keep string literals in their expression
29876 (EmitDynamicInitializers): Handle strings appropriately.
29878 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29880 * codegen.cs (EmitContext): Replace multiple variables with a
29881 single pointer to the current Switch statement.
29883 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29886 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29890 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29893 (Foreach.Emit): Foreach on arrays was not setting
29894 up the loop variables (for break/continue).
29896 (GotoCase): Semi-implented.
29898 2001-12-03 Ravi Pratap <ravi@ximian.com>
29900 * attribute.cs (CheckAttribute): Handle system attributes by using
29901 Attribute.GetAttributes to examine information we need.
29903 (GetValidPlaces): Same here.
29905 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29907 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29909 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29911 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29913 (Method::Emit): Handle the case when we are a PInvoke method.
29915 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29917 * expression.cs: Use ResolveWithSimpleName on compound names.
29919 2001-12-02 Ravi Pratap <ravi@ximian.com>
29921 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29922 before trying to reduce it.
29924 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29926 * constant.cs (LookupConstantValue): Implement.
29928 (EmitConstant): Use the above in emitting the constant.
29930 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29931 that are user-defined by doing a LookupConstantValue on them.
29933 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29936 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29938 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29940 (BaseAccess.DoResolve): Implement.
29942 (MemberAccess.DoResolve): Split this routine into a
29943 ResolveMemberAccess routine that can be used independently
29945 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29947 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29948 As that share bits of the implementation. Is returns a boolean,
29949 while As returns the Type that is being probed.
29951 2001-12-01 Ravi Pratap <ravi@ximian.com>
29953 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29954 instead of a Literal - much easier.
29956 (EnumInTransit): Remove - utterly useless :-)
29958 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29960 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29962 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29963 chain when we have no associated expression.
29965 2001-11-30 Ravi Pratap <ravi@ximian.com>
29967 * constant.cs (Define): Use Location while reporting the errror.
29969 Also emit a warning when 'new' is used and there is no inherited
29972 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29975 (LookupEnumValue): Implement to lookup an enum member's value and define it
29978 (Populate): Re-write accordingly to use the above routine.
29980 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29982 * expression.cs (This): Fix prototype for DoResolveLValue to
29983 override the base class DoResolveLValue.
29985 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29988 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29989 (we need to load the address of the field here). This fixes
29992 (FieldExpr.DoResolveLValue): Call the DoResolve
29993 function to initialize the Instance expression.
29995 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29996 correctly the GetEnumerator operation on a value type.
29998 * cs-parser.jay: Add more simple parsing error catches.
30000 * statement.cs (Switch): Add support for string switches.
30001 Handle null specially.
30003 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30005 2001-11-28 Ravi Pratap <ravi@ximian.com>
30007 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30009 (declare_local_constant): New helper function.
30011 * statement.cs (AddConstant): Keep a separate record of constants
30013 (IsConstant): Implement to determine if a variable is a constant.
30015 (GetConstantExpression): Implement.
30017 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30019 * statement.cs (IsVariableDefined): Re-write.
30021 2001-11-27 Ravi Pratap <ravi@ximian.com>
30023 * class.cs (TypeContainer::FindMembers): Look for constants
30024 in the case when we are looking for MemberTypes.Field
30026 * expression.cs (MemberAccess::DoResolve): Check that in the
30027 case we are a FieldExpr and a Literal, we are not being accessed
30028 by an instance reference.
30030 * cs-parser.jay (local_constant_declaration): Implement.
30032 (declaration_statement): Implement for constant declarations.
30034 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30036 * statement.cs (Switch): Catch double defaults.
30038 (Switch): More work on the switch() statement
30039 implementation. It works for integral values now, need to finish
30043 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30045 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30046 integer literals into other integer literals. To be used by
30049 2001-11-24 Ravi Pratap <ravi@ximian.com>
30051 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30054 (EmitDynamicInitializers): Cope with the above since we extract data
30055 directly from ArrayData now.
30057 (ExpectInitializers): Keep track of whether initializers are mandatory
30060 (Bounds): Make it a hashtable to prevent the same dimension being
30061 recorded for every element in that dimension.
30063 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30066 Also fix bug which was causing the indices to be emitted in the reverse
30069 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30071 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30072 unfinished. They do not work, because the underlying code is
30075 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30077 * cs-parser.jay: Remove bogus fixme.
30079 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30080 on Switch statement.
30082 2001-11-23 Ravi Pratap <ravi@ximian.com>
30084 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30087 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30088 parameter. Apparently, any expression is allowed.
30090 (ValidateInitializers): Update accordingly.
30092 (CheckIndices): Fix some tricky bugs thanks to recursion.
30094 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30095 I was being completely brain-dead.
30097 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30098 and re-write acordingly.
30100 (DelegateInvocation): Re-write accordingly.
30102 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30104 (MakeByteBlob): Handle types more correctly.
30106 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30107 initialization from expressions but it is incomplete because I am a complete
30110 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30112 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30113 on If. Basically, we have to return `true' (ie, we do return to
30114 our caller) only if both branches of the if return.
30116 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30117 short-circuit operators, handle them as short circuit operators.
30119 (Cast.DoResolve): Resolve type.
30120 (Cast.Cast): Take an expression as the target type.
30122 * cs-parser.jay (cast_expression): Remove old hack that only
30123 allowed a limited set of types to be handled. Now we take a
30124 unary_expression and we resolve to a type during semantic
30127 Use the grammar productions from Rhys to handle casts (this is
30128 not complete like Rhys syntax yet, we fail to handle that corner
30129 case that C# has regarding (-x), but we will get there.
30131 2001-11-22 Ravi Pratap <ravi@ximian.com>
30133 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30134 field which is an array type.
30136 * cs-parser.jay (declare_local_variables): Support array initialization too.
30138 * typemanager.cs (MakeKey): Implement.
30140 (everywhere): Use the above appropriately.
30142 * cs-parser.jay (for_statement): Update for array initialization while
30143 declaring variables.
30145 * ecore.cs : The error message was correct, it's the variable's names that
30146 were misleading ;-) Make the code more readable.
30148 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30149 the correct type etc.
30151 (ConvertExplicit): Handle Enum types by examining the underlying type.
30153 2001-11-21 Ravi Pratap <ravi@ximian.com>
30155 * parameter.cs (GetCallingConvention): Always return
30156 CallingConventions.Standard for now.
30158 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30160 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30161 and `r' after calling DoNumericPromotions.
30163 * ecore.cs: Fix error message (the types were in the wrong order).
30165 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30166 BindingFlags.Instance as well
30168 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30169 implicit int literal conversion in an empty cast so that we
30170 propagate the right type upstream.
30172 (UnboxCast): new class used to unbox value types.
30173 (Expression.ConvertExplicit): Add explicit type conversions done
30176 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30177 the target type before applying the implicit LongLiterals to ULong
30180 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30182 * cs-parser.jay (for_statement): Reworked the way For works: now
30183 we declare manually any variables that are introduced in
30184 for_initializer to solve the problem of having out-of-band code
30185 emition (that is what got for broken).
30187 (declaration_statement): Perform the actual variable declaration
30188 that used to be done in local_variable_declaration here.
30190 (local_variable_declaration): Do not declare anything, just pass
30191 the information on a DictionaryEntry
30193 2001-11-20 Ravi Pratap <ravi@ximian.com>
30195 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30196 re-write of the logic to now make it recursive.
30198 (UpdateIndices): Re-write accordingly.
30200 Store element data in a separate ArrayData list in the above methods.
30202 (MakeByteBlob): Implement to dump the array data into a byte array.
30204 2001-11-19 Ravi Pratap <ravi@ximian.com>
30206 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30209 * constant.cs (Define): Implement.
30211 (EmitConstant): Re-write fully.
30213 Pass in location info.
30215 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30218 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30219 DictionaryEntry since we need location info too.
30221 (constant_declaration): Update accordingly.
30223 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30224 code into another method : UpdateIndices.
30226 2001-11-18 Ravi Pratap <ravi@ximian.com>
30228 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30229 some type checking etc.
30231 2001-11-17 Ravi Pratap <ravi@ximian.com>
30233 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30234 bits to provide dimension info if the user skips doing that.
30236 Update second constructor to store the rank correctly.
30238 2001-11-16 Ravi Pratap <ravi@ximian.com>
30240 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30241 and try to implement.
30243 * ../errors/cs0150.cs : Add.
30245 * ../errors/cs0178.cs : Add.
30247 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30249 * statement.cs: Implement foreach on multi-dimensional arrays.
30251 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30252 name of the params argument.
30254 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30255 initializing the array.
30257 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30258 we can use this elsewhere.
30260 * statement.cs: Finish implementation of foreach for single
30263 * cs-parser.jay: Use an out-of-band stack to pass information
30264 around, I wonder why I need this.
30266 foreach_block: Make the new foreach_block the current_block.
30268 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30269 function used to return a static Parameters structure. Used for
30270 empty parameters, as those are created very frequently.
30272 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30274 2001-11-15 Ravi Pratap <ravi@ximian.com>
30276 * interface.cs : Default modifier is private, not public. The
30277 make verify test passes again.
30279 2001-11-15 Ravi Pratap <ravi@ximian.com>
30281 * support.cs (ReflectionParameters): Fix logic to determine
30282 whether the last parameter is a params one. Test 9 passes again.
30284 * delegate.cs (Populate): Register the builders we define with
30285 RegisterParameterForBuilder. Test 19 passes again.
30287 * cs-parser.jay (property_declaration): Reference $6 instead
30288 of $$ to get at the location.
30290 (indexer_declaration): Similar stuff.
30292 (attribute): Ditto.
30294 * class.cs (Property): Register parameters for the Get and Set methods
30295 if they exist. Test 23 passes again.
30297 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30298 call to EmitArguments as we are sure there aren't any params arguments.
30299 Test 32 passes again.
30301 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30302 IndexOutOfRangeException.
30304 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30305 Test 33 now passes again.
30307 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30309 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30310 broke a bunch of things. Will have to come up with a better way
30311 of tracking locations.
30313 * statement.cs: Implemented foreach for single dimension arrays.
30315 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30317 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30318 an error. This removes the lookup from the critical path.
30320 * cs-parser.jay: Removed use of temporary_loc, which is completely
30323 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30325 * support.cs (ReflectionParameters.ParameterModifier): Report
30326 whether the argument is a PARAMS argument or not.
30328 * class.cs: Set the attribute `ParamArrayAttribute' on the
30329 parameter argument.
30331 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30332 and cons_param_array_attribute (ConstructorInfo for
30333 ParamArrayAttribute).,
30335 * codegen.cs: Emit the return using the `Return' statement, that
30336 way we can report the error correctly for missing return values.
30338 * class.cs (Method.Emit): Clean up.
30340 * expression.cs (Argument.Resolve): Take another argument: the
30341 location where this argument is used. Notice that this is not
30342 part of the "Argument" class as to reduce the size of the
30343 structure (we know the approximate location anyways).
30345 Test if the argument is a variable-reference, if not, then
30346 complain with a 206.
30348 (Argument.Emit): Emit addresses of variables.
30350 (Argument.FullDesc): Simplify.
30352 (Invocation.DoResolve): Update for Argument.Resolve.
30354 (ElementAccess.DoResolve): ditto.
30356 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30357 method should be virtual, as this method is always virtual.
30359 (NewDelegate.DoResolve): Update for Argument.Resolve.
30361 * class.cs (ConstructorInitializer.DoResolve): ditto.
30363 * attribute.cs (Attribute.Resolve): ditto.
30365 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30367 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30369 * expression.cs (ParameterReference): Drop IStackStorage and implement
30370 IAssignMethod instead.
30372 (LocalVariableReference): ditto.
30374 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30375 IAssignMethod instead.
30377 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30379 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30380 enumerations that are used in heavily used structures derive from
30381 byte in a laughable and pathetic attempt to reduce memory usage.
30382 This is the kind of pre-optimzations that you should not do at
30383 home without adult supervision.
30385 * expression.cs (UnaryMutator): New class, used to handle ++ and
30386 -- separatedly from the other unary operators. Cleans up the
30387 code, and kills the ExpressionStatement dependency in Unary.
30389 (Unary): Removed `method' and `Arguments' from this class, making
30390 it smaller, and moving it all to SimpleCall, so I can reuse this
30391 code in other locations and avoid creating a lot of transient data
30392 strucutres when not required.
30394 * cs-parser.jay: Adjust for new changes.
30396 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30398 * enum.cs (Enum.Populate): If there is a failure during
30401 * cs-parser.jay (opt_enum_base): we used to catch type errors
30402 here, but this is really incorrect. The type error should be
30403 catched during semantic analysis.
30405 2001-12-11 Ravi Pratap <ravi@ximian.com>
30407 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30408 current_local_parameters as expected since I, in my stupidity, had forgotten
30411 * attribute.cs (GetValidPlaces): Fix stupid bug.
30413 * class.cs (Method::Emit): Perform check on applicability of attributes.
30415 (Constructor::Emit): Ditto.
30417 (Field::Emit): Ditto.
30419 (Field.Location): Store location information.
30421 (Property, Event, Indexer, Operator): Ditto.
30423 * cs-parser.jay (field_declaration): Pass in location for each field.
30425 * ../errors/cs0592.cs : Add.
30427 2001-11-12 Ravi Pratap <ravi@ximian.com>
30429 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30431 (InitCoreTypes): Update accordingly.
30433 (RegisterAttrType, LookupAttr): Implement.
30435 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30436 info about the same.
30438 (Resolve): Update to populate the above as necessary.
30440 (Error592): Helper.
30442 (GetValidPlaces): Helper to the above.
30444 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30446 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30448 2001-11-12 Ravi Pratap <ravi@ximian.com>
30450 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30452 * ../errors/cs0617.cs : Add.
30454 2001-11-11 Ravi Pratap <ravi@ximian.com>
30456 * enum.cs (Emit): Rename to Populate to be more consistent with what
30457 we expect it to do and when exactly it is called.
30459 * class.cs, rootcontext.cs : Update accordingly.
30461 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30462 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30464 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30466 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30467 of a fieldinfo using the above, when dealing with a FieldBuilder.
30469 2001-11-10 Ravi Pratap <ravi@ximian.com>
30471 * ../errors/cs0031.cs : Add.
30473 * ../errors/cs1008.cs : Add.
30475 * ../errrors/cs0543.cs : Add.
30477 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30480 (FindMembers): Implement.
30482 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30483 enums and delegates too.
30485 (enum_types): Rename to builder_to_enum.
30487 (delegate_types): Rename to builder_to_delegate.
30489 * delegate.cs (FindMembers): Implement.
30491 2001-11-09 Ravi Pratap <ravi@ximian.com>
30493 * typemanager.cs (IsEnumType): Implement.
30495 * enum.cs (Emit): Re-write parts to account for the underlying type
30496 better and perform checking etc.
30498 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30499 of the underlying type.
30501 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30504 * enum.cs (error31): Helper to report error #31.
30506 * cs-parser.jay (enum_declaration): Store location of each member too.
30508 * enum.cs (member_to_location): New hashtable.
30510 (AddEnumMember): Update location hashtable.
30512 (Emit): Use the location of each member while reporting errors.
30514 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30516 * cs-parser.jay: A for_initializer if is a
30517 local_variable_declaration really ammount to have an implicit
30518 block with the variable declaration and no initializer for for.
30520 * statement.cs (For.Emit): Cope with null initializers.
30522 This fixes the infinite loop on for initializers.
30524 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30526 * enum.cs: More cleanup.
30528 * ecore.cs: Remove dead code.
30530 * class.cs (Property.Emit): More simplification.
30531 (Event.Emit): ditto.
30533 Reworked to have less levels of indentation.
30535 2001-11-08 Ravi Pratap <ravi@ximian.com>
30537 * class.cs (Property): Emit attributes.
30547 * enum.cs (Emit): Ditto.
30549 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30552 * class.cs (Field, Event, etc.): Move attribute generation into the
30553 Emit method everywhere.
30555 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30556 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30557 as we had no way of defining nested enums !
30559 * rootcontext.cs : Adjust code accordingly.
30561 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30563 2001-11-07 Ravi Pratap <ravi@ximian.com>
30565 * expression.cs (EvalConstantExpression): Move into ecore.cs
30567 * enum.cs (Enum): Rename some members and make them public and readonly
30568 according to our convention.
30570 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30573 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30575 (Enum::Emit): Write a simple version for now which doesn't try to compute
30576 expressions. I shall modify this to be more robust in just a while.
30578 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30580 (TypeContainer::CloseType): Create the Enum types too.
30582 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30584 * expression.cs (EvalConstantExpression): Get rid of completely.
30586 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30587 user-defined values and other cases.
30589 (IsValidEnumLiteral): Helper function.
30591 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30592 out there in the case we had a literal FieldExpr.
30594 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30596 (Literalize): Revamp a bit to take two arguments.
30598 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30600 2001-11-06 Ravi Pratap <ravi@ximian.com>
30602 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30604 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30606 (Resolve): Use the above to ensure we have proper initializers.
30608 2001-11-05 Ravi Pratap <ravi@ximian.com>
30610 * expression.cs (Expression::EvalConstantExpression): New method to
30611 evaluate constant expressions.
30613 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30615 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30617 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30620 (Binary.ResolveOperator): Handle operator != (object a, object b)
30621 and operator == (object a, object b);
30623 (Binary.DoNumericPromotions): Indicate whether the numeric
30624 promotion was possible.
30626 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30629 Made the ArrayAccess implement interface IAssignMethod instead of
30630 IStackStore as the order in which arguments are passed reflects
30633 * assign.cs: Instead of using expr.ExprClass to select the way of
30634 assinging, probe for the IStackStore/IAssignMethod interfaces.
30636 * typemanager.cs: Load InitializeArray definition.
30638 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30639 static data that can be used to initialize arrays.
30641 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30643 * expression.cs: Handle operator== and operator!= for booleans.
30645 (Conditioal.Reduce): Implement reducer for the ?: operator.
30647 (Conditional.Resolve): Implement dead code elimination.
30649 (Binary.Resolve): Catch string literals and return a new
30650 concatenated string.
30652 (Unary.Reduce): Implement reduction of unary expressions.
30654 * ecore.cs: Split out the expression core handling here.
30656 (Expression.Reduce): New method used to perform constant folding
30657 and CSE. This is needed to support constant-expressions.
30659 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30660 targets, and optimize for !x.
30662 2001-11-04 Ravi Pratap <ravi@ximian.com>
30664 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30665 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30666 set custom atttributes.
30668 * literal.cs (Literal::GetValue): New abstract method to return the actual
30669 value of the literal, cast as an object.
30671 (*Literal): Implement GetValue method.
30673 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30674 expressions to the arraylist but objects of type Argument.
30676 * class.cs (TypeContainer::Emit): Emit our attributes too.
30678 (Method::Emit, Constructor::Emit): Ditto.
30680 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30681 to be ignoring earlier.
30683 2001-11-03 Ravi Pratap <ravi@ximian.com>
30685 * attribute.cs (AttributeSection::Define): Implement to do the business
30686 of constructing a CustomAttributeBuilder.
30688 (Attribute): New trivial class. Increases readability of code.
30690 * cs-parser.jay : Update accordingly.
30692 (positional_argument_list, named_argument_list, named_argument): New rules
30694 (attribute_arguments): Use the above so that we are more correct.
30696 2001-11-02 Ravi Pratap <ravi@ximian.com>
30698 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30699 to perform all checks for a method with a params parameter.
30701 (Invocation::OverloadResolve): Update to use the above method and therefore
30702 cope correctly with params method invocations.
30704 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30707 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30708 constructors in our parent too because we can't afford to miss out on
30711 * attribute.cs (AttributeSection): New name for the class Attribute
30713 Other trivial changes to improve readability.
30715 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30716 use the new class names.
30718 2001-11-01 Ravi Pratap <ravi@ximian.com>
30720 * class.cs (Method::Define): Complete definition for params types too
30722 (Indexer::Define): Ditto.
30724 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30725 Cope everywhere with a request for info about the array parameter.
30727 2001-11-01 Ravi Pratap <ravi@ximian.com>
30729 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30731 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30732 local_variable_type to extract the string corresponding to the type.
30734 (local_variable_type): Fixup the action to use the new helper method.
30736 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30739 * expression.cs : Clean out code which uses the above.
30741 2001-10-31 Ravi Pratap <ravi@ximian.com>
30743 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30744 and bale out if necessary by returning a false.
30746 (RegisterProperty): Ditto.
30748 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30749 and print out appropriate error messages.
30751 * interface.cs (everywhere): Ditto.
30753 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30754 location to constructor.
30756 * class.cs (Property, Event, Indexer): Update accordingly.
30758 * ../errors/cs111.cs : Added.
30760 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30761 of a method, as laid down by the spec.
30763 (Invocation::OverloadResolve): Use the above method.
30765 2001-10-31 Ravi Pratap <ravi@ximian.com>
30767 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30768 now take a TypeContainer and a Parameters object.
30770 (ParameterData): Modify return type of ParameterModifier method to be
30771 Parameter.Modifier and not a string.
30773 (ReflectionParameters, InternalParameters): Update accordingly.
30775 * expression.cs (Argument::GetParameterModifier): Same here.
30777 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30778 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30779 symbol in it at all so maybe this is only for now.
30781 2001-10-30 Ravi Pratap <ravi@ximian.com>
30783 * support.cs (InternalParameters): Constructor now takes an extra argument
30784 which is the actual Parameters class.
30786 (ParameterDesc): Update to provide info on ref/out modifiers.
30788 * class.cs (everywhere): Update call to InternalParameters to pass in
30789 the second argument too.
30791 * support.cs (ParameterData): Add ParameterModifier, which is a method
30792 to return the modifier info [ref/out etc]
30794 (InternalParameters, ReflectionParameters): Implement the above.
30796 * expression.cs (Argument::ParameterModifier): Similar function to return
30797 info about the argument's modifiers.
30799 (Invocation::OverloadResolve): Update to take into account matching modifiers
30802 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30803 a new SetFormalParameters object which we pass to InternalParameters.
30805 2001-10-30 Ravi Pratap <ravi@ximian.com>
30807 * expression.cs (NewArray): Merge into the ArrayCreation class.
30809 2001-10-29 Ravi Pratap <ravi@ximian.com>
30811 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30812 NewUserdefinedArray into one as there wasn't much of a use in having
30815 * expression.cs (Argument): Change field's name to ArgType from Type.
30817 (Type): New readonly property which returns the proper type, taking into
30818 account ref/out modifiers.
30820 (everywhere): Adjust code accordingly for the above.
30822 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30823 whether we are emitting for a ref or out parameter.
30825 * expression.cs (Argument::Emit): Use the above field to set the state.
30827 (LocalVariableReference::Emit): Update to honour the flag and emit the
30830 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30832 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30834 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30836 (ReflectionParameters, InternalParameters): Implement the above method.
30838 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30841 (Invocation::FullMethodDesc): Ditto.
30843 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30845 * cs-parser.jay: Add extra production for the second form of array
30848 * expression.cs (ArrayCreation): Update to reflect the above
30851 * Small changes to prepare for Array initialization.
30853 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30855 * typemanager.cs (ImplementsInterface): interface might be null;
30856 Deal with this problem;
30858 Also, we do store negative hits on the cache (null values), so use
30859 this instead of calling t.GetInterfaces on the type everytime.
30861 2001-10-28 Ravi Pratap <ravi@ximian.com>
30863 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30865 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30866 split functionality out into different classes.
30868 (New::FormArrayType): Move into NewBuiltinArray.
30870 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30873 (NewBuiltinArray): New class to handle creation of built-in arrays.
30875 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30876 account creation of one-dimensional arrays.
30878 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30880 (NewUserdefinedArray::DoResolve): Implement.
30882 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30884 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30885 we maintain inside the TypeManager. This is necessary to perform lookups on the
30888 (LookupType): Update to perform GetType on the module builders too.
30890 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30892 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30894 2001-10-23 Ravi Pratap <ravi@ximian.com>
30896 * expression.cs (New::DoResolve): Implement guts of array creation.
30898 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30900 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30902 * expression.cs: Fix bug I introduced lsat night that broke
30905 (Expression.Resolve): Report a 246 error (can not resolve name)
30906 if we find a SimpleName in the stream.
30908 (Expression.ResolveLValue): Ditto.
30910 (Expression.ResolveWithSimpleName): This function is a variant of
30911 ResolveName, this one allows SimpleNames to be returned without a
30912 warning. The only consumer of SimpleNames is MemberAccess
30914 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30916 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30917 might arrive here. I have my doubts that this is correct.
30919 * statement.cs (Lock): Implement lock statement.
30921 * cs-parser.jay: Small fixes to support `lock' and `using'
30923 * cs-tokenizer.cs: Remove extra space
30925 * driver.cs: New flag --checked, allows to turn on integer math
30928 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30929 Threading.Monitor.Exit
30931 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30933 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30934 Expression Class to be IndexerAccess.
30936 Notice that Indexer::DoResolve sets the eclass to Value.
30938 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30940 * class.cs (TypeContainer::Emit): Emit code for indexers.
30942 * assign.cs (IAssignMethod): New interface implemented by Indexers
30943 and Properties for handling assignment.
30945 (Assign::Emit): Simplify and reuse code.
30947 * expression.cs (IndexerAccess, PropertyExpr): Implement
30948 IAssignMethod, clean up old code.
30950 2001-10-22 Ravi Pratap <ravi@ximian.com>
30952 * typemanager.cs (ImplementsInterface): New method to determine if a type
30953 implements a given interface. Provides a nice cache too.
30955 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30958 (ConvertReferenceExplicit): Ditto.
30960 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30961 various methods, with correct names etc.
30963 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30964 Operator.UnaryNegation.
30966 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30967 we have a unary plus or minus operator.
30969 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30972 * everywhere : update accordingly.
30974 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30977 * class.cs (Method::Define): For the case where we are implementing a method
30978 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30979 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30981 2001-10-21 Ravi Pratap <ravi@ximian.com>
30983 * interface.cs (FindMembers): Implement to work around S.R.E
30986 * typemanager.cs (IsInterfaceType): Implement.
30988 (FindMembers): Update to handle interface types too.
30990 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30991 use IsAssignableFrom as that is not correct - it doesn't work.
30993 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30994 and accordingly override EmitStatement.
30996 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30997 using the correct logic :-)
30999 2001-10-19 Ravi Pratap <ravi@ximian.com>
31001 * ../errors/cs-11.cs : Add to demonstrate error -11
31003 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31005 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31006 then pass this as a hint to ResolveLValue.
31008 * expression.cs (FieldExpr): Add Location information
31010 (FieldExpr::LValueResolve): Report assignment to readonly
31013 (Expression::ExprClassFromMemberInfo): Pass location information.
31015 (Expression::ResolveLValue): Add new method that resolves an
31018 (Expression::DoResolveLValue): Default invocation calls
31021 (Indexers): New class used to keep track of indexers in a given
31024 (IStackStore): Renamed from LValue, as it did not really describe
31025 what this did. Also ResolveLValue is gone from this interface and
31026 now is part of Expression.
31028 (ElementAccess): Depending on the element access type
31030 * typemanager.cs: Add `indexer_name_type' as a Core type
31031 (System.Runtime.CompilerServices.IndexerNameAttribute)
31033 * statement.cs (Goto): Take a location.
31035 2001-10-18 Ravi Pratap <ravi@ximian.com>
31037 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31038 if two delegates are compatible.
31040 (NewDelegate::DoResolve): Update to take care of the case when
31041 we instantiate a delegate from another delegate.
31043 * typemanager.cs (FindMembers): Don't even try to look up members
31044 of Delegate types for now.
31046 2001-10-18 Ravi Pratap <ravi@ximian.com>
31048 * delegate.cs (NewDelegate): New class to take care of delegate
31051 * expression.cs (New): Split the delegate related code out into
31052 the NewDelegate class.
31054 * delegate.cs (DelegateInvocation): New class to handle delegate
31057 * expression.cs (Invocation): Split out delegate related code into
31058 the DelegateInvocation class.
31060 2001-10-17 Ravi Pratap <ravi@ximian.com>
31062 * expression.cs (New::DoResolve): Implement delegate creation fully
31063 and according to the spec.
31065 (New::DoEmit): Update to handle delegates differently.
31067 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31068 because of which we were printing out arguments in reverse order !
31070 * delegate.cs (VerifyMethod): Implement to check if the given method
31071 matches the delegate.
31073 (FullDelegateDesc): Implement.
31075 (VerifyApplicability): Implement.
31077 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31078 delegate invocations too.
31080 (Invocation::Emit): Ditto.
31082 * ../errors/cs1593.cs : Added.
31084 * ../errors/cs1594.cs : Added.
31086 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31088 2001-10-16 Ravi Pratap <ravi@ximian.com>
31090 * typemanager.cs (intptr_type): Core type for System.IntPtr
31092 (InitCoreTypes): Update for the same.
31094 (iasyncresult_type, asynccallback_type): Ditto.
31096 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31099 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31102 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31103 the builders for the 4 members of a delegate type :-)
31105 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31108 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31110 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31112 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31114 * statement.cs (Break::Emit): Implement.
31115 (Continue::Emit): Implement.
31117 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31118 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31119 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31120 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31123 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31124 properties that track the label for the current loop (begin of the
31125 loop and end of the loop).
31127 2001-10-15 Ravi Pratap <ravi@ximian.com>
31129 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31130 use of emitting anything at all.
31132 * class.cs, rootcontext.cs : Get rid of calls to the same.
31134 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31136 (Populate): Define the constructor correctly and set the implementation
31139 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31142 (AddDelegateType): Implement.
31144 (IsDelegateType): Implement helper method.
31146 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31148 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31149 and accordingly handle it.
31151 * delegate.cs (Populate): Take TypeContainer argument.
31152 Implement bits to define the Invoke method. However, I still haven't figured out
31153 how to take care of the native int bit :-(
31155 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31156 Qualify the name of the delegate, not its return type !
31158 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31161 (StandardConversionExists): Checking for array types turns out to be recursive.
31163 (ConvertReferenceExplicit): Implement array conversion.
31165 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31167 2001-10-12 Ravi Pratap <ravi@ximian.com>
31169 * cs-parser.jay (delegate_declaration): Store the fully qualified
31170 name as it is a type declaration.
31172 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31175 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31176 as TypeContainer::DefineType.
31178 (Populate): Method in which all the definition of the various methods (Invoke)
31181 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31184 (CloseDelegate): Finally creates the delegate.
31186 * class.cs (TypeContainer::DefineType): Update to define delegates.
31187 (Populate, Emit and CloseType): Do the same thing here too.
31189 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31190 delegates in all these operations.
31192 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31194 * expression.cs: LocalTemporary: a new expression used to
31195 reference a temporary that has been created.
31197 * assign.cs: Handle PropertyAccess back here, so that we can
31198 provide the proper semantic access to properties.
31200 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31201 a few more explicit conversions.
31203 * modifiers.cs: `NEW' modifier maps to HideBySig.
31205 * expression.cs (PropertyExpr): Make this into an
31206 ExpressionStatement, and support the EmitStatement code path.
31208 Perform get/set error checking, clean up the interface.
31210 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31211 them into toplevel access objects.
31213 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31215 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31218 * typemanager.cs: Keep track here of our PropertyBuilders again to
31219 work around lameness in SRE.
31221 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31223 * expression.cs (LValue::LValueResolve): New method in the
31224 interface, used to perform a second resolution pass for LValues.
31226 (This::DoResolve): Catch the use of this in static methods.
31228 (This::LValueResolve): Implement.
31230 (This::Store): Remove warning, assigning to `this' in structures
31233 (Invocation::Emit): Deal with invocation of
31234 methods on value types. We need to pass the address to structure
31235 methods rather than the object itself. (The equivalent code to
31236 emit "this" for structures leaves the entire structure on the
31237 stack instead of a pointer to it).
31239 (ParameterReference::DoResolve): Compute the real index for the
31240 argument based on whether the method takes or not a `this' pointer
31241 (ie, the method is static).
31243 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31244 value types returned from functions when we need to invoke a
31245 method on the sturcture.
31248 2001-10-11 Ravi Pratap <ravi@ximian.com>
31250 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31251 defining the type in the Modulebuilder or Typebuilder. This is to take
31252 care of nested types which need to be defined on the TypeBuilder using
31253 DefineNestedMethod.
31255 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31256 methods in RootContext, only ported to be part of TypeContainer.
31258 (TypeContainer::GetInterfaceOrClass): Ditto.
31260 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31262 * interface.cs (Interface::DefineInterface): New method. Does exactly
31263 what RootContext.CreateInterface did earlier, only it takes care of nested types
31266 (Interface::GetInterfaces): Move from RootContext here and port.
31268 (Interface::GetInterfaceByName): Same here.
31270 * rootcontext.cs (ResolveTree): Re-write.
31272 (PopulateTypes): Re-write.
31274 * class.cs (TypeContainer::Populate): Populate nested types too.
31275 (TypeContainer::Emit): Emit nested members too.
31277 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31278 instead just use the name argument passed in as it is already fully
31281 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31282 to TypeContainer mapping to see if a type is user-defined.
31284 * class.cs (TypeContainer::CloseType): Implement.
31286 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31287 the default constructor.
31289 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31292 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31294 * interface.cs (CloseType): Create the type here.
31296 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31299 Remove all the methods which are now in TypeContainer.
31301 2001-10-10 Ravi Pratap <ravi@ximian.com>
31303 * delegate.cs (Define): Re-write bits to define the delegate
31306 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31308 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31310 * expression.cs (ImplicitReferenceConversion): handle null as well
31311 as a source to convert to any reference type.
31313 * statement.cs (Return): Perform any implicit conversions to
31314 expected return type.
31316 Validate use of return statement.
31318 * codegen.cs (EmitContext): Pass the expected return type here.
31320 * class.cs (Method, Constructor, Property): Pass expected return
31321 type to EmitContext.
31323 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31325 * expression.cs: Make DoResolve take an EmitContext instead of a
31328 Replaced `l' and `location' for `loc', for consistency.
31330 (Error, Warning): Remove unneeded Tc argument.
31332 * assign.cs, literal.cs, constant.cs: Update to new calling
31335 * codegen.cs: EmitContext now contains a flag indicating whether
31336 code is being generated in a static method or not.
31338 * cs-parser.jay: DecomposeQI, new function that replaces the old
31339 QualifiedIdentifier. Now we always decompose the assembled
31340 strings from qualified_identifier productions into a group of
31343 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31345 * rootcontext.cs: Deal with field-less struct types correctly now
31346 by passing the size option to Define Type.
31348 * class.cs: Removed hack that created one static field.
31350 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31352 * statement.cs: Moved most of the code generation here.
31354 2001-10-09 Ravi Pratap <ravi@ximian.com>
31356 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31359 (ElementAccess): Remove useless bits for now - keep checks as the spec
31362 2001-10-08 Ravi Pratap <ravi@ximian.com>
31364 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31365 and start performing checks according to the spec.
31367 2001-10-07 Ravi Pratap <ravi@ximian.com>
31369 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31370 rank_specifiers instead.
31372 (rank_specifiers): Change the order in which the rank specifiers are stored
31374 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31376 * expression.cs (ElementAccess): Implement the LValue interface too.
31378 2001-10-06 Ravi Pratap <ravi@ximian.com>
31380 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31381 except that user defined conversions are not included.
31383 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31384 perform the conversion of the return type, if necessary.
31386 (New::DoResolve): Check whether we are creating an array or an object
31387 and accordingly do the needful.
31389 (New::Emit): Same here.
31391 (New::DoResolve): Implement guts of array creation.
31393 (New::FormLookupType): Helper function.
31395 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31397 * codegen.cs: Removed most of the code generation here, and move the
31398 corresponding code generation bits to the statement classes.
31400 Added support for try/catch/finalize and throw.
31402 * cs-parser.jay: Added support for try/catch/finalize.
31404 * class.cs: Catch static methods having the flags override,
31405 virtual or abstract.
31407 * expression.cs (UserCast): This user cast was not really doing
31408 what it was supposed to do. Which is to be born in fully resolved
31409 state. Parts of the resolution were being performed at Emit time!
31413 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31415 * expression.cs: Implicity convert the result from UserCast.
31417 2001-10-05 Ravi Pratap <ravi@ximian.com>
31419 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31420 prevented it from working correctly.
31422 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31423 merely ConvertImplicit.
31425 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31427 * typemanager.cs: Make the LookupTypeContainer function static,
31428 and not per-instance.
31430 * class.cs: Make static FindMembers (the one that takes a Type
31433 * codegen.cs: Add EmitForeach here.
31435 * cs-parser.jay: Make foreach a toplevel object instead of the
31436 inline expansion, as we need to perform semantic analysis on it.
31438 2001-10-05 Ravi Pratap <ravi@ximian.com>
31440 * expression.cs (Expression::ImplicitUserConversion): Rename to
31441 UserDefinedConversion.
31443 (Expression::UserDefinedConversion): Take an extra argument specifying
31444 whether we look for explicit user conversions too.
31446 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31448 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31450 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31451 with the appropriate arguments.
31453 * cs-parser.jay (cast_expression): Record location too.
31455 * expression.cs (Cast): Record location info.
31457 (Expression::ConvertExplicit): Take location argument.
31459 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31460 to determine if we are doing explicit conversions.
31462 (UserCast::Emit): Update accordingly.
31464 (Expression::ConvertExplicit): Report an error if everything fails.
31466 * ../errors/cs0030.cs : Add.
31468 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31470 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31471 virtual and newslot bits.
31473 * class.cs (TypeContainer::RegisterRequiredImplementations):
31474 Record methods we need.
31476 (TypeContainer::MakeKey): Helper function to make keys for
31477 MethodBases, since the Methodbase key is useless.
31479 (TypeContainer::Populate): Call RegisterRequiredImplementations
31480 before defining the methods.
31482 Create a mapping for method_builders_to_methods ahead of time
31483 instead of inside a tight loop.
31485 (::RequireMethods): Accept an object as the data to set into the
31486 hashtable so we can report interface vs abstract method mismatch.
31488 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31490 * report.cs: Make all of it static.
31492 * rootcontext.cs: Drop object_type and value_type computations, as
31493 we have those in the TypeManager anyways.
31495 Drop report instance variable too, now it is a global.
31497 * driver.cs: Use try/catch on command line handling.
31499 Add --probe option to debug the error reporting system with a test
31502 * report.cs: Add support for exiting program when a probe
31503 condition is reached.
31505 2001-10-03 Ravi Pratap <ravi@ximian.com>
31507 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31508 we do a forcible conversion regardless of type, to check if
31509 ForceConversion returns a null.
31511 (Binary::error19): Use location to report error.
31513 (Unary::error23): Use location here too.
31515 * ../errors/cs0019.cs : Check in.
31517 * ../errors/cs0023.cs : Check in.
31519 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31520 case of a non-null MethodInfo object with a length of 0 !
31522 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31523 an applicable member - according to the spec :-)
31524 Also fix logic to find members in base types.
31526 (Unary::ResolveOperator): Same here.
31528 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31529 as I was getting thoroughly confused between this and error19 :-)
31531 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31532 (::FindMostEncompassedType): Implement.
31533 (::FindMostEncompassingType): Implement.
31534 (::StandardConversionExists): Implement.
31536 (UserImplicitCast): Re-vamp. We now need info about most specific
31537 source and target types so that we can do the necessary conversions.
31539 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31540 mathematical union with no duplicates.
31542 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31544 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31545 in order from base classes to child classes, so that we can in
31546 child classes look up in our parent for method names and
31547 attributes (required for handling abstract, virtual, new, override
31548 constructs: we need to instrospect our base class, and if we dont
31549 populate the classes in order, the introspection might be
31550 incorrect. For example, a method could query its parent before
31551 the parent has any methods and would determine that the parent has
31552 no abstract methods (while it could have had them)).
31554 (RootContext::CreateType): Record the order in which we define the
31557 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31559 * class.cs (TypeContainer::Populate): Also method definitions can
31560 fail now, keep track of this.
31562 (TypeContainer::FindMembers): Implement support for
31563 DeclaredOnly/noDeclaredOnly flag.
31565 (Constructor::Emit) Return the ConstructorBuilder.
31567 (Method::Emit) Return the MethodBuilder.
31568 Check for abstract or virtual methods to be public.
31570 * rootcontext.cs (RootContext::CreateType): Register all the
31571 abstract methods required for the class to be complete and the
31572 interface methods that must be implemented.
31574 * cs-parser.jay: Report error 501 (method requires body if it is
31575 not marked abstract or extern).
31577 * expression.cs (TypeOf::Emit): Implement.
31579 * typemanager.cs: runtime_handle_type, new global type.
31581 * class.cs (Property::Emit): Generate code for properties.
31583 2001-10-02 Ravi Pratap <ravi@ximian.com>
31585 * expression.cs (Unary::ResolveOperator): Find operators on base type
31586 too - we now conform exactly to the spec.
31588 (Binary::ResolveOperator): Same here.
31590 * class.cs (Operator::Define): Fix minor quirk in the tests.
31592 * ../errors/cs0215.cs : Added.
31594 * ../errors/cs0556.cs : Added.
31596 * ../errors/cs0555.cs : Added.
31598 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31600 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31601 single integer which is really efficient
31603 2001-10-01 Ravi Pratap <ravi@ximian.com>
31605 * expression.cs (Expression::ImplicitUserConversion): Use location
31606 even in the case when we are examining True operators.
31608 * class.cs (Operator::Define): Perform extensive checks to conform
31609 with the rules for operator overloading in the spec.
31611 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31612 some of the other conversions mentioned in the spec.
31614 * typemanager.cs (array_type): New static member for the System.Array built-in
31617 (cloneable_interface): For System.ICloneable interface.
31619 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31620 we start resolving the tree and populating types.
31622 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31624 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31626 * expression.cs (Expression::ExprClassFromMemberInfo,
31627 Expression::Literalize): Create literal expressions from
31628 FieldInfos which are literals.
31630 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31631 type casts, because they were wrong. The test suite in tests
31634 (ImplicitNumericConversion): ushort to ulong requires a widening
31637 Int32 constant to long requires widening cast as well.
31639 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31640 for integers because the type on the stack is not i4.
31642 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31644 * expression.cs (report118): require location argument.
31646 * parameter.cs: Do not dereference potential null value.
31648 * class.cs: Catch methods that lack the `new' keyword when
31649 overriding a name. Report warnings when `new' is used without
31650 anything being there to override.
31652 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31654 * class.cs: Only add constructor to hashtable if it is non-null
31655 (as now constructors can fail on define).
31657 (TypeManager, Class, Struct): Take location arguments.
31659 Catch field instance initialization in structs as errors.
31661 accepting_filter: a new filter for FindMembers that is static so
31662 that we dont create an instance per invocation.
31664 (Constructor::Define): Catch errors where a struct constructor is
31667 * cs-parser.jay: Pass location information for various new
31670 * delegate.cs (Delegate): take a location argument.
31672 * driver.cs: Do not call EmitCode if there were problesm in the
31673 Definition of the types, as many Builders wont be there.
31675 * decl.cs (Decl::Decl): Require a location argument.
31677 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31678 into integers, and find the most appropiate integer for it.
31680 * literal.cs: Implement ULongLiteral.
31682 * rootcontext.cs: Provide better information about the location of
31683 failure when CreateType fails.
31685 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31687 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31690 * expression.cs (Binary::CheckShiftArguments): Add missing type
31692 (Binary::ResolveOperator): Add type to the logical and and logical
31693 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31696 (Binary::DoNumericPromotions): In the case where either argument
31697 is ulong (and most signed types combined with ulong cause an
31698 error) perform implicit integer constant conversions as well.
31700 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31702 * expression.cs (UserImplicitCast): Method should always be
31704 (Invocation::BetterConversion): Simplified test for IntLiteral.
31706 (Expression::ImplicitNumericConversion): Split this routine out.
31707 Put the code that performs implicit constant integer conversions
31710 (Expression::Resolve): Become a wrapper around DoResolve so we can
31711 check eclass and type being set after resolve.
31713 (Invocation::Badness): Remove this dead function
31715 (Binary::ResolveOperator): Do not compute the expensive argumnets
31716 unless we have a union for it.
31718 (Probe::Emit): Is needs to do an isinst and then
31719 compare against null.
31721 (::CanConvert): Added Location argument. If the Location argument
31722 is null (Location.Null), then we do not report errors. This is
31723 used by the `probe' mechanism of the Explicit conversion. We do
31724 not want to generate an error for something that the user
31725 explicitly requested to be casted. But the pipeline for an
31726 explicit cast first tests for potential implicit casts.
31728 So for now, if the Location is null, it means `Probe only' to
31729 avoid adding another argument. Might have to revise this
31732 (ClassCast): New class used to type cast objects into arbitrary
31733 classes (used in Explicit Reference Conversions).
31735 Implement `as' as well.
31737 Reverted all the patches from Ravi below: they were broken:
31739 * The use of `level' as a mechanism to stop recursive
31740 invocations is wrong. That was there just to catch the
31741 bug with a strack trace but not as a way of addressing
31744 To fix the problem we have to *understand* what is going
31745 on and the interactions and come up with a plan, not
31746 just get things going.
31748 * The use of the type conversion cache that I proposed
31749 last night had an open topic: How does this work across
31750 protection domains. A user defined conversion might not
31751 be public in the location where we are applying the
31752 conversion, a different conversion might be selected
31753 (ie, private A->B (better) but public B->A (worse),
31754 inside A, A->B applies, but outside it, B->A will
31757 * On top of that (ie, even if the above is solved),
31758 conversions in a cache need to be abstract. Ie, `To
31759 convert from an Int to a Short use an OpcodeCast', not
31760 `To convert from an Int to a Short use the OpcodeCast on
31761 the variable 5' (which is what this patch was doing).
31763 2001-09-28 Ravi Pratap <ravi@ximian.com>
31765 * expression.cs (Invocation::ConversionExists): Re-write to use
31766 the conversion cache
31768 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31769 cache all conversions done, not just user-defined ones.
31771 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31772 to determine if a conversion exists instead of acutually trying to
31773 perform the conversion. It's faster too.
31775 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31776 and only then attempt the implicit conversion.
31778 2001-09-28 Ravi Pratap <ravi@ximian.com>
31780 * expression.cs (ConvertImplicit): Use a cache for conversions
31781 already found. Check level of recursion and bail out if necessary.
31783 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31785 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31786 Export standard methods that we expect for string operations.
31788 * statement.cs (Block::UsageWarning): Track usage of variables and
31789 report the errors for not used variables.
31791 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31794 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31796 * codegen.cs: remove unnneded code
31798 * expression.cs: Removed BuiltinTypeAccess class
31800 Fix the order in which implicit conversions are
31803 The previous fixed dropped support for boxed conversions (adding a
31804 test to the test suite now)
31806 (UserImplicitCast::CanConvert): Remove test for source being null,
31807 that code is broken. We should not feed a null to begin with, if
31808 we do, then we should track the bug where the problem originates
31809 and not try to cover it up here.
31811 Return a resolved expression of type UserImplicitCast on success
31812 rather than true/false. Ravi: this is what I was talking about,
31813 the pattern is to use a static method as a "constructor" for
31816 Also, do not create arguments until the very last minute,
31817 otherwise we always create the arguments even for lookups that
31818 will never be performed.
31820 (UserImplicitCast::Resolve): Eliminate, objects of type
31821 UserImplicitCast are born in a fully resolved state.
31823 * typemanager.cs (InitCoreTypes): Init also value_type
31824 (System.ValueType).
31826 * expression.cs (Cast::Resolve): First resolve the child expression.
31828 (LValue): Add new method AddressOf to be used by
31831 Change the argument of Store to take an EmitContext instead of an
31832 ILGenerator, because things like FieldExpr need to be able to call
31833 their children expression to generate the instance code.
31835 (Expression::Error, Expression::Warning): Sugar functions for
31838 (Expression::MemberLookup): Accept a TypeContainer instead of a
31839 Report as the first argument.
31841 (Expression::ResolvePrimary): Killed. I still want to improve
31842 this as currently the code is just not right.
31844 (Expression::ResolveMemberAccess): Simplify, but it is still
31847 (Unary::Resolve): Catch errors in AddressOf operators.
31849 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31850 index to a byte for the short-version, or the compiler will choose
31851 the wrong Emit call, which generates the wrong data.
31853 (ParameterReference::Emit, ::Store): same.
31855 (FieldExpr::AddressOf): Implement.
31857 * typemanager.cs: TypeManager: made public variable instead of
31860 * driver.cs: document --fatal.
31862 * report.cs (ErrorMessage, WarningMessage): new names for the old
31863 Error and Warning classes.
31865 * cs-parser.jay (member_access): Turn built-in access to types
31866 into a normal simplename
31868 2001-09-27 Ravi Pratap <ravi@ximian.com>
31870 * expression.cs (Invocation::BetterConversion): Fix to cope
31871 with q being null, since this was introducing a bug.
31873 * expression.cs (ConvertImplicit): Do built-in conversions first.
31875 2001-09-27 Ravi Pratap <ravi@ximian.com>
31877 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31879 2001-09-27 Ravi Pratap <ravi@ximian.com>
31881 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31882 I had introduced long ago (what's new ?).
31884 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31885 the work of all the checking.
31886 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31887 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31889 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31890 that is the right way.
31892 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31893 overloading resolution. Use everywhere instead of cutting and pasting code.
31895 (Binary::ResolveOperator): Use MakeUnionSet.
31897 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31898 we have to convert to bool types. Not complete yet.
31900 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31902 * typemanager.cs (TypeManager::CSharpName): support ushort.
31904 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31905 to provide an expression that performsn an implicit constant int
31906 conversion (section 6.1.6).
31907 (Expression::ConvertImplicitRequired): Reworked to include
31908 implicit constant expression conversions.
31910 (Expression::ConvertNumericExplicit): Finished.
31912 (Invocation::Emit): If InstanceExpression is null, then it means
31913 that we perform a call on this.
31915 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31917 * expression.cs (Unary::Emit): Remove some dead code.
31918 (Probe): Implement Resolve and Emit for `is'.
31919 (Expression::ConvertImplicitRequired): Attempt to do constant
31920 expression conversions here. Maybe should be moved to
31921 ConvertImplicit, but I am not sure.
31922 (Expression::ImplicitLongConstantConversionPossible,
31923 Expression::ImplicitIntConstantConversionPossible): New functions
31924 that tell whether is it possible to apply an implicit constant
31925 expression conversion.
31927 (ConvertNumericExplicit): Started work on explicit numeric
31930 * cs-parser.jay: Update operator constants.
31932 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31933 (Parameters::GetSignature): Hook up VerifyArgs here.
31934 (Parameters::VerifyArgs): Verifies that no two arguments have the
31937 * class.cs (Operator): Update the operator names to reflect the
31938 ones that the spec expects (as we are just stringizing the
31941 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31942 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31943 previous usage did only work for our methods.
31944 (Expression::ConvertImplicit): Handle decimal implicit numeric
31945 conversions as well.
31946 (Expression::InternalTypeConstructor): Used to invoke constructors
31947 on internal types for default promotions.
31949 (Unary::Emit): Implement special handling for the pre/post
31950 increment/decrement for overloaded operators, as they need to have
31951 the same semantics as the other operators.
31953 (Binary::ResolveOperator): ditto.
31954 (Invocation::ConversionExists): ditto.
31955 (UserImplicitCast::Resolve): ditto.
31957 2001-09-26 Ravi Pratap <ravi@ximian.com>
31959 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31960 operator, return after emitting body. Regression tests pass again !
31962 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31963 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31964 (Invocation::OverloadResolve): Ditto.
31965 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31967 * everywhere : update calls to the above methods accordingly.
31969 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31971 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31973 * expression.cs (ExpressionStatement): New base class used for
31974 expressions that can appear in statements, so that we can provide
31975 an alternate path to generate expression that do not leave a value
31978 (Expression::Emit, and all the derivatives): We no longer return
31979 whether a value is left on the stack or not. Every expression
31980 after being emitted leaves a single value on the stack.
31982 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31983 facilties of ExpressionStatement if possible.
31985 * cs-parser.jay: Update statement_expression.
31987 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31989 * driver.cs: Change the wording of message
31991 2001-09-25 Ravi Pratap <ravi@ximian.com>
31993 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31994 the type of the expression to the return type of the method if
31995 we have an overloaded operator match ! The regression tests pass again !
31996 (Unary::ResolveOperator): Ditto.
31998 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31999 to find "op_Implicit", not "implicit" ;-)
32000 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32001 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32003 * everywhere : Correct calls to the above accordingly.
32005 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32006 (ConvertImplicit): Do user-defined conversion if it exists.
32008 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32010 * assign.cs: track location.
32011 (Resolve): Use implicit conversions on assignment.
32013 * literal.cs: Oops. Not good, Emit of short access values should
32014 pass (Bytes) or the wrong argument will be selected.
32016 * expression.cs (Unary::Emit): Emit code for -expr.
32018 (Unary::ResolveOperator): Handle `Substract' for non-constants
32019 (substract from zero from the non-constants).
32020 Deal with Doubles as well.
32022 (Expression::ConvertImplicitRequired): New routine that reports an
32023 error if no implicit conversion exists.
32025 (Invocation::OverloadResolve): Store the converted implicit
32026 expressions if we make them
32028 2001-09-24 Ravi Pratap <ravi@ximian.com>
32030 * class.cs (ConstructorInitializer): Take a Location argument.
32031 (ConstructorBaseInitializer): Same here.
32032 (ConstructorThisInitializer): Same here.
32034 * cs-parser.jay : Update all calls accordingly.
32036 * expression.cs (Unary, Binary, New): Take location argument.
32037 Update accordingly everywhere.
32039 * cs-parser.jay : Update all calls to the above to take a location
32042 * class.cs : Ditto.
32044 2001-09-24 Ravi Pratap <ravi@ximian.com>
32046 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32047 (Invocation::BetterConversion): Same here
32048 (Invocation::ConversionExists): Ditto.
32050 (Invocation::ConversionExists): Implement.
32052 2001-09-22 Ravi Pratap <ravi@ximian.com>
32054 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32055 Also take an additional TypeContainer argument.
32057 * All over : Pass in TypeContainer as argument to OverloadResolve.
32059 * typemanager.cs (CSharpName): Update to check for the string type and return
32062 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32065 2001-09-21 Ravi Pratap <ravi@ximian.com>
32067 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32068 (Invocation::BetterFunction): Implement.
32069 (Invocation::BetterConversion): Implement.
32070 (Invocation::ConversionExists): Skeleton, no implementation yet.
32072 Okay, things work fine !
32074 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32076 * typemanager.cs: declare and load enum_type, delegate_type and
32079 * expression.cs (Expression::Emit): Now emit returns a value that
32080 tells whether a value is left on the stack or not. This strategy
32081 might be reveted tomorrow with a mechanism that would address
32082 multiple assignments.
32083 (Expression::report118): Utility routine to report mismatches on
32086 (Unary::Report23): Report impossible type/operator combination
32089 (Unary::IsIncrementableNumber): Whether the type can be
32090 incremented or decremented with add.
32091 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32093 (Unary::ResolveOperator): Implement ++, !, ~,
32095 (Invocation::Emit): Deal with new Emit convetion.
32097 * All Expression derivatives: Updated their Emit method to return
32098 whether they leave values on the stack or not.
32100 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32101 stack for expressions that are statements.
32103 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32105 * expression.cs (LValue): New interface. Must be implemented by
32107 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32110 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32111 interface for generating code, simplifies the code.
32113 2001-09-20 Ravi Pratap <ravi@ximian.com>
32115 * expression.cs (everywhere): Comment out return statements in ::Resolve
32116 methods to avoid the warnings.
32118 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32120 * driver.cs (parse): Report error 2001 if we can not open the
32123 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32126 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32129 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32130 otherwise nested blocks end up with the same index.
32132 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32134 * expression.cs: Instead of having FIXMEs in the Resolve
32135 functions, throw exceptions so it is obvious that we are facing a
32138 * cs-parser.jay (invocation_expression): Pass Location information.
32140 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32141 Use a basename for those routines because .NET does not like paths
32144 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32147 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32149 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32150 are loading the correct data types (throws an exception if not).
32151 (TypeManager::InitCoreTypes): Use CoreLookupType
32153 * expression.cs (Unary::ResolveOperator): return the child
32154 expression for expressions which are just +expr.
32155 (Unary::ResolveOperator): Return negative literals for -LITERAL
32156 expressions (otherwise they are Unary {Literal}).
32157 (Invocation::Badness): Take into account `Implicit constant
32158 expression conversions'.
32160 * literal.cs (LongLiteral): Implement long literal class.
32161 (IntLiteral): export the `Value' of the intliteral.
32163 2001-09-19 Ravi Pratap <ravi@ximian.com>
32165 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32167 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32168 instead of 'Operator'
32170 * expression.cs (Binary::ResolveOperator): Update accordingly.
32171 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32174 * cs-parser.jay (unary_expression): Update to use the new names.
32176 * gen-treedump.cs (GetUnary): Same here.
32178 * expression.cs (Unary::Resolve): Implement.
32179 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32180 operators are found instead of making noise ;-)
32181 (Unary::ResolveOperator): New method to do precisely the same thing which
32182 Binary::ResolveOperator does for Binary expressions.
32183 (Unary.method, .Arguments): Add.
32184 (Unary::OperName): Implement.
32185 (Unary::ForceConversion): Copy and Paste !
32187 * class.cs (Operator::Define): Fix a small bug for the case when we have
32190 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32191 for the inbuilt operators. Only overloading works for now ;-)
32193 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32195 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32196 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32198 * expression.cs (This::Emit): Implement.
32199 (This::Resolve): Implement.
32200 (TypeOf:Resolve): Implement.
32201 (Expression::ResolveSimpleName): Add an implicit this to instance
32203 (MemberAccess::Resolve): Deal with Parameters and Fields.
32204 Bind instance variable to Field expressions.
32205 (FieldExpr::Instance): New field used to track the expression that
32206 represents the object instance.
32207 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32209 (FieldExpr::Emit): Implement.
32211 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32212 the last instruction contains a return opcode to avoid generating
32213 the last `ret' instruction (this generates correct code, and it is
32214 nice to pass the peverify output).
32216 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32217 initializer for static and instance variables.
32218 (Constructor::Emit): Allow initializer to be null in the case of
32219 static constructors. Only emit initializer for instance
32222 (TypeContainer::FindMembers): Return a null array if there are no
32225 Also fix the code for the MemberTypes.Method branch, as it was not
32226 scanning that for operators (or tried to access null variables before).
32228 * assign.cs (Assign::Emit): Handle instance and static fields.
32232 * driver.cs: Stop compilation if there are parse errors.
32234 * cs-parser.jay (constructor_declaration): Provide default base
32235 initializer for non-static constructors.
32236 (constructor_declarator): Do not provide a default base
32237 initializers if none was specified.
32238 Catch the fact that constructors should not have parameters.
32240 * class.cs: Do not emit parent class initializers for static
32241 constructors, that should be flagged as an error.
32243 2001-09-18 Ravi Pratap <ravi@ximian.com>
32245 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32246 Move back code into TypeContainer::Populate.
32248 2001-09-18 Ravi Pratap <ravi@ximian.com>
32250 * class.cs (TypeContainer::AddConstructor): Fix the check to
32251 compare against Name, not Basename.
32252 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32254 * cs-parser.jay : Update accordingly.
32256 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32257 for methods, don't forget to look into the operators too.
32258 (RegisterMethodBuilder): Helper method to take care of this for
32259 methods, constructors and operators.
32260 (Operator::Define): Completely revamp.
32261 (Operator.OperatorMethod, MethodName): New fields.
32262 (TypeContainer::Populate): Move the registering of builders into
32263 RegisterMethodBuilder.
32264 (Operator::Emit): Re-write.
32266 * expression.cs (Binary::Emit): Comment out code path to emit method
32267 invocation stuff for the case when we have a user defined operator. I am
32268 just not able to get it right !
32270 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32272 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32275 (Expression::MemberLookup): Provide a version that allows to
32276 specify the MemberTypes and BindingFlags.
32278 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32279 so it was not fetching variable information from outer blocks.
32281 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32282 Beforefieldinit as it was buggy.
32284 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32285 that Ravi put here.
32287 * class.cs (Constructor::Emit): Only emit if block is not null.
32288 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32289 deal with this by semantically definining it as if the user had
32292 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32293 constructors as we now "emit" them at a higher level.
32295 (TypeContainer::DefineDefaultConstructor): Used to define the
32296 default constructors if none was provided.
32298 (ConstructorInitializer): Add methods Resolve and Emit.
32300 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32302 2001-09-17 Ravi Pratap <ravi@ximian.com>
32304 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32305 the default constructor builder with our hashtable for methodbuilders
32308 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32309 and argument_count is 0 in which case we have a match.
32310 (Binary::ResolveOperator): More null checking and miscellaneous coding
32313 2001-09-17 Ravi Pratap <ravi@ximian.com>
32315 * rootcontext.cs (IsNameSpace): Compare against null.
32317 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32319 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32320 and Unary::Operator.
32322 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32325 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32326 we have overloaded operators.
32327 (Binary::ResolveOperator): Implement the part which does the operator overload
32330 * class.cs (Operator::Emit): Implement.
32331 (TypeContainer::Emit): Emit the operators we have too.
32333 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32334 the case when we have a user-defined operator.
32336 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32338 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32340 2001-09-16 Ravi Pratap <ravi@ximian.com>
32342 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32343 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32344 (Constructor::Emit): Implement.
32345 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32346 if we have no work to do.
32347 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32350 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32351 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32353 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32356 2001-09-15 Ravi Pratap <ravi@ximian.com>
32358 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32360 (Tree::RecordNamespace): Method to do what the name says ;-)
32361 (Tree::Namespaces): Property to get at the namespaces hashtable.
32363 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32366 * rootcontext.cs (IsNamespace): Fixed it :-)
32368 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32370 * class.cs (TypeContainer::FindMembers): Add support for
32372 (MethodCore): New class that encapsulates both the shared aspects
32373 of a Constructor and a Method.
32374 (Method, Constructor): Factored pieces into MethodCore.
32376 * driver.cs: Added --fatal which makes errors throw exceptions.
32377 Load System assembly as well as part of the standard library.
32379 * report.cs: Allow throwing exceptions on errors for debugging.
32381 * modifiers.cs: Do not use `parent', instead use the real type
32382 container to evaluate permission settings.
32384 * class.cs: Put Ravi's patch back in. He is right, and we will
32385 have to cope with the
32387 2001-09-14 Ravi Pratap <ravi@ximian.com>
32389 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32390 FamORAssem, not FamANDAssem.
32392 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32394 * driver.cs: Added --parse option that only parses its input files
32397 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32398 incorrect. IsTopLevel is not used to tell whether an object is
32399 root_types or not (that can be achieved by testing this ==
32400 root_types). But to see if this is a top-level *class* (not
32401 necessarly our "toplevel" container).
32403 2001-09-14 Ravi Pratap <ravi@ximian.com>
32405 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32406 parent instead of a direct call to GetType.
32408 2001-09-14 Ravi Pratap <ravi@ximian.com>
32410 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32411 Modifiers.TypeAttr. This should just be a call to that method.
32413 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32414 object so that we can determine if we are top-level or not.
32416 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32419 * enum.cs (Enum::Define): Ditto.
32421 * modifiers.cs (FieldAttr): Re-write.
32423 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32424 (TypeContainer::HaveStaticConstructor): New property to provide access
32425 to precisely that info.
32427 * modifiers.cs (MethodAttr): Re-write.
32428 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32430 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32431 of top-level types as claimed.
32433 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32435 * expression.cs (MemberLookup): Fruitless attempt to lookup
32436 constructors. Maybe I need to emit default constructors? That
32437 might be it (currently .NET emits this for me automatically).
32438 (Invocation::OverloadResolve): Cope with Arguments == null.
32439 (Invocation::EmitArguments): new function, shared by the new
32440 constructor and us.
32441 (Invocation::Emit): Handle static and instance methods. Emit
32442 proper call instruction for virtual or non-virtual invocations.
32443 (New::Emit): Implement.
32444 (New::Resolve): Implement.
32445 (MemberAccess:Resolve): Implement.
32446 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32447 to track instances.
32448 (FieldExpr::Resolve): Set type.
32450 * support.cs: Handle empty arguments.
32452 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32453 SimpleLookup): Auxiliary routines to help parse a qualifier
32456 Update qualifier_identifier rule.
32458 * codegen.cs: Removed debugging messages.
32460 * class.cs: Make this a global thing, this acts just as a "key" to
32461 objects that we might have around.
32463 (Populate): Only initialize method_builders_to_methods once.
32465 * expression.cs (PropertyExpr): Initialize type from the
32468 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32469 Resolve pattern. Attempt to implicitly convert value to boolean.
32472 * expression.cs: Set the type for the int32/int32 argument case.
32473 (Binary::ResolveOperator): Set the return type to boolean for
32474 comparission operators
32476 * typemanager.cs: Remove debugging print code.
32478 (Invocation::Resolve): resolve type.
32480 * class.cs: Allocate a MemberInfo of the correct size, as the code
32481 elsewhere depends on the test to reflect the correct contents.
32483 (Method::) Keep track of parameters, due to System.Reflection holes
32485 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32488 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32489 of the exact size and return that.
32491 (Class::LookupMethodByBuilder): New function that maps
32492 MethodBuilders to its methods. Required to locate the information
32493 on methods because System.Reflection bit us again.
32495 * support.cs: New file, contains an interface ParameterData and
32496 two implementations: ReflectionParameters and InternalParameters
32497 used to access Parameter information. We will need to grow this
32500 * expression.cs (Invocation::GetParameterData): implement a cache
32501 and a wrapper around the ParameterData creation for methods.
32502 (Invocation::OverloadResolve): Use new code.
32504 2001-09-13 Ravi Pratap <ravi@ximian.com>
32506 * class.cs (TypeContainer::EmitField): Remove and move into
32507 (Field::Define): here and modify accordingly.
32508 (Field.FieldBuilder): New member.
32509 (TypeContainer::Populate): Update accordingly.
32510 (TypeContainer::FindMembers): Implement.
32512 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32514 * statement.cs: (VariableInfo::VariableType): New field to be
32515 initialized with the full type once it is resolved.
32517 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32519 * parameter.cs (GetParameterInfo): Use a type cache to compute
32520 things only once, and to reuse this information
32522 * expression.cs (LocalVariableReference::Emit): Implement.
32523 (OpcodeCast::Emit): fix.
32525 (ParameterReference::Resolve): Implement.
32526 (ParameterReference::Emit): Implement.
32528 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32529 that are expressions need to stay as Expressions.
32531 * typemanager.cs (CSharpName): Returns the C# name of a type if
32534 * expression.cs (Expression::ConvertImplicit): New function that
32535 implements implicit type conversions.
32537 (Expression::ImplicitReferenceConversion): Implements implicit
32538 reference conversions.
32540 (EmptyCast): New type for transparent casts.
32542 (OpcodeCast): New type for casts of types that are performed with
32543 a sequence of bytecodes.
32545 (BoxedCast): New type used for casting value types into reference
32546 types. Emits a box opcode.
32548 (Binary::DoNumericPromotions): Implements numeric promotions of
32549 and computation of the Binary::Type.
32551 (Binary::EmitBranchable): Optimization.
32553 (Binary::Emit): Implement code emission for expressions.
32555 * typemanager.cs (TypeManager): Added two new core types: sbyte
32558 2001-09-12 Ravi Pratap <ravi@ximian.com>
32560 * class.cs (TypeContainer::FindMembers): Method which does exactly
32561 what Type.FindMembers does, only we don't have to use reflection. No
32562 implementation yet.
32564 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32565 typecontainer objects as we need to get at them.
32566 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32568 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32569 typecontainer object.
32571 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32572 of just a Report object.
32574 2001-09-11 Ravi Pratap <ravi@ximian.com>
32576 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32578 (TypeContainer::Populate): Now define the delegates of the type too.
32579 (TypeContainer.Delegates): Property to access the list of delegates defined
32582 * delegates.cs (Delegate::Define): Implement partially.
32584 * modifiers.cs (TypeAttr): Handle more flags.
32586 2001-09-11 Ravi Pratap <ravi@ximian.com>
32588 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32590 (Operator::Define): Re-write logic to get types by using the LookupType method
32591 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32592 (Indexer::Define): Ditto.
32593 (Event::Define): Ditto.
32594 (Property::Define): Ditto.
32596 2001-09-10 Ravi Pratap <ravi@ximian.com>
32598 * class.cs (TypeContainer::Populate): Now define operators too.
32599 (TypeContainer.Operators): New property to access the list of operators
32601 (Operator.OperatorMethodBuilder): New member to hold the method builder
32602 for the operator we are defining.
32603 (Operator::Define): Implement.
32605 2001-09-10 Ravi Pratap <ravi@ximian.com>
32607 * class.cs (Event::Define): Make the prefixes of the accessor methods
32608 addOn_ and removeOn_
32610 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32611 of the location being passed in too. Ideally, this should go later since all
32612 error reporting should be done through the Report object.
32614 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32615 (Populate): Iterate thru the indexers we have and define them too.
32616 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32617 for the get and set accessors.
32618 (Indexer::Define): Implement.
32620 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32622 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32623 my previous implementation, did not work.
32625 * typemanager.cs: Add a couple of missing types (the longs).
32627 * literal.cs: Use TypeManager.bool_type instead of getting it.
32629 * expression.cs (EventExpr): New kind of expressions.
32630 (Expressio::ExprClassFromMemberInfo): finish
32632 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32634 * assign.cs: Emit stores to static fields differently.
32636 2001-09-08 Ravi Pratap <ravi@ximian.com>
32638 * Merge in changes and adjust code to tackle conflicts. Backed out my
32639 code in Assign::Resolve ;-)
32641 2001-09-08 Ravi Pratap <ravi@ximian.com>
32643 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32644 instead Report.Error and also pass in the location.
32645 (CSharpParser::Lexer): New readonly property to return the reference
32646 to the Tokenizer object.
32647 (declare_local_variables): Use Report.Error with location instead of plain
32651 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32652 (Operator.CheckBinaryOperator): Ditto.
32654 * cs-parser.jay (operator_declarator): Update accordingly.
32656 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32657 (CheckBinaryOperator): Same here.
32659 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32660 on the name without any prefixes of namespace names etc. This is because we
32661 already might have something already fully qualified like
32662 'System.Console.WriteLine'
32664 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32666 2001-09-07 Ravi Pratap <ravi@ximian.com>
32668 * cs-tokenizer.cs (location): Return a string which also contains
32671 * expression.cs (ElementAccess): New class for expressions of the
32672 type 'element access.'
32673 (BaseAccess): New class for expressions of the type 'base access.'
32674 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32677 * cs-parser.jay (element_access): Implement action.
32678 (base_access): Implement actions.
32679 (checked_expression, unchecked_expression): Implement.
32681 * cs-parser.jay (local_variable_type): Correct and implement.
32682 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32684 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32686 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32687 name and the specifiers.
32689 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32691 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32692 making them all public ;-)
32694 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32697 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32699 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32701 (FieldExpr, PropertyExprs): New resolved expressions.
32702 (SimpleName::MemberStaticCheck): Perform static checks for access
32703 to non-static fields on static methods. Maybe this should be
32704 generalized for MemberAccesses.
32705 (SimpleName::ResolveSimpleName): More work on simple name
32708 * cs-parser.jay (primary_expression/qualified_identifier): track
32709 the parameter index.
32711 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32712 (EmitContext::EmitBoolExpression): Chain to expression generation
32713 instead of temporary hack.
32714 (::EmitStatementExpression): Put generic expression code generation.
32716 * assign.cs (Assign::Emit): Implement variable assignments to
32717 local variables, parameters and fields.
32719 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32721 * statement.cs (Block::GetVariableInfo): New method, returns the
32722 VariableInfo for a variable name in a block.
32723 (Block::GetVariableType): Implement in terms of GetVariableInfo
32725 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32726 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32728 2001-09-06 Ravi Pratap <ravi@ximian.com>
32730 * cs-parser.jay (operator_declaration): Continue on my quest : update
32731 to take attributes argument.
32732 (event_declaration): Ditto.
32733 (enum_declaration): Ditto.
32734 (indexer_declaration): Ditto.
32736 * class.cs (Operator::Operator): Update constructor accordingly.
32737 (Event::Event): Ditto.
32739 * delegate.cs (Delegate::Delegate): Same here.
32741 * enum.cs (Enum::Enum): Same here.
32743 2001-09-05 Ravi Pratap <ravi@ximian.com>
32745 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32747 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32749 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32750 being passed around as an arraylist.
32751 (Attributes::AddAttribute): Method to add attribute sections.
32753 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32754 (struct_declaration): Update accordingly.
32755 (constant_declaration): Update.
32756 (field_declaration): Update.
32757 (method_header): Update.
32758 (fixed_parameter): Update.
32759 (parameter_array): Ditto.
32760 (property_declaration): Ditto.
32761 (destructor_declaration): Ditto.
32763 * class.cs (Struct::Struct): Update constructors accordingly.
32764 (Class::Class): Ditto.
32765 (Field::Field): Ditto.
32766 (Method::Method): Ditto.
32767 (Property::Property): Ditto.
32768 (TypeContainer::OptAttribute): update property's return type.
32770 * interface.cs (Interface.opt_attributes): New member.
32771 (Interface::Interface): Update to take the extra Attributes argument.
32773 * parameter.cs (Parameter::Parameter): Ditto.
32775 * constant.cs (Constant::Constant): Ditto.
32777 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32778 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32779 the attributes as a parameter.
32780 (InterfaceProperty): Update constructor call.
32781 (InterfaceEvent): Ditto.
32782 (InterfaceMethod): Ditto.
32783 (InterfaceIndexer): Ditto.
32785 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32786 pass the attributes too.
32787 (interface_event_declaration): Ditto.
32788 (interface_property_declaration): Ditto.
32789 (interface_method_declaration): Ditto.
32790 (interface_declaration): Ditto.
32792 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32794 * class.cs (Method::Define): Track the "static Main" definition to
32795 create an entry point.
32797 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32798 EntryPoint if we find it.
32800 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32801 (EmitContext::ig): Make this variable public.
32803 * driver.cs: Make the default output file be the first file name
32804 with the .exe extension.
32806 Detect empty compilations
32808 Handle various kinds of output targets. Handle --target and
32809 rename -t to --dumper.
32811 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32812 methods inherited from Expression return now an Expression. This
32813 will is used during the tree rewriting as we resolve them during
32816 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32817 the spec. Missing entirely is the information about
32818 accessability of elements of it.
32820 (Expression::ExprClassFromMemberInfo): New constructor for
32821 Expressions that creates a fully initialized Expression based on
32822 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32825 (Invocation::Resolve): Begin implementing resolution of invocations.
32827 * literal.cs (StringLiteral): Implement Emit.
32829 2001-09-05 Ravi Pratap <ravi@ximian.com>
32831 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32834 2001-09-04 Ravi Pratap <ravi@ximian.com>
32836 * cs-parser.jay (attribute_arguments): Implement actions.
32837 (attribute): Fix bug in production. Implement action.
32838 (attribute_list): Implement.
32839 (attribute_target): Implement.
32840 (attribute_target_specifier, opt_target_specifier): Implement
32841 (CheckAttributeTarget): New method to check if the attribute target
32843 (attribute_section): Implement.
32844 (opt_attributes): Implement.
32846 * attribute.cs : New file to handle attributes.
32847 (Attribute): Class to hold attribute info.
32849 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32850 (attribute_section): Modify production to use 2 different rules to
32851 achieve the same thing. 1 s/r conflict down !
32852 Clean out commented, useless, non-reducing dimension_separator rules.
32854 * class.cs (TypeContainer.attributes): New member to hold list
32855 of attributes for a type.
32856 (Struct::Struct): Modify to take one more argument, the attribute list.
32857 (Class::Class): Ditto.
32858 (Field::Field): Ditto.
32859 (Method::Method): Ditto.
32860 (Property::Property): Ditto.
32862 * cs-parser.jay (struct_declaration): Update constructor call to
32863 pass in the attributes too.
32864 (class_declaration): Ditto.
32865 (constant_declaration): Ditto.
32866 (field_declaration): Ditto.
32867 (method_header): Ditto.
32868 (fixed_parameter): Ditto.
32869 (parameter_array): Ditto.
32870 (property_declaration): Ditto.
32872 * constant.cs (Constant::Constant): Update constructor similarly.
32873 Use System.Collections.
32875 * parameter.cs (Parameter::Parameter): Update as above.
32877 2001-09-02 Ravi Pratap <ravi@ximian.com>
32879 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32880 (TypeContainer.delegates): New member to hold list of delegates.
32882 * cs-parser.jay (delegate_declaration): Implement the action correctly
32883 this time as I seem to be on crack ;-)
32885 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32887 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32888 tell whether an identifier represents a namespace.
32890 * expression.cs (NamespaceExpr): A namespace expression, used only
32891 temporarly during expression resolution.
32892 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32893 utility functions to resolve names on expressions.
32895 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32897 * codegen.cs: Add hook for StatementExpressions.
32899 * class.cs: Fix inverted test for static flag in methods.
32901 2001-09-02 Ravi Pratap <ravi@ximian.com>
32903 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32904 to make it coincide with MS' number.
32905 (Operator::CheckBinaryOperator): Ditto.
32907 * ../errors/errors.txt : Remove error numbers added earlier.
32909 * ../errors/cs1019.cs : Test case for error # 1019
32911 * ../errros/cs1020.cs : Test case for error # 1020
32913 * cs-parser.jay : Clean out commented cruft.
32914 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32915 used anywhere - non-reducing rule.
32916 (namespace_declarations): Non-reducing rule - comment out.
32918 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32919 with TypeContainer::AddEnum.
32921 * delegate.cs : New file for delegate handling classes.
32922 (Delegate): Class for declaring delegates.
32924 * makefile : Update.
32926 * cs-parser.jay (delegate_declaration): Implement.
32928 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32930 * class.cs (Event::Define): Implement.
32931 (Event.EventBuilder): New member.
32933 * class.cs (TypeContainer::Populate): Update to define all enums and events
32935 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32936 readonly fields for all these cases ?
32938 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32940 * class.cs (Property): Revamp to use the convention of making fields readonly.
32941 Accordingly modify code elsewhere.
32943 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32944 the Define method of the Property class.
32946 * class.cs : Clean up applied patch and update references to variables etc. Fix
32948 (TypeContainer::Populate): Update to define all the properties we have. Also
32949 define all enumerations.
32951 * enum.cs (Define): Implement.
32953 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32955 * cs-parser.jay (overloadable_operator): The semantic value is an
32956 enum of the Operator class.
32957 (operator_declarator): Implement actions.
32958 (operator_declaration): Implement.
32960 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32961 validity of definitions.
32962 (Operator::CheckBinaryOperator): Static method to check for binary operators
32963 (TypeContainer::AddOperator): New method to add an operator to a type.
32965 * cs-parser.jay (indexer_declaration): Added line to actually call the
32966 AddIndexer method so it gets added ;-)
32968 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32969 already taken care of by the MS compiler ?
32971 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32973 * class.cs (Operator): New class for operator declarations.
32974 (Operator::OpType): Enum for the various operators.
32976 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32978 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32979 ostensibly handle this in semantic analysis.
32981 * cs-parser.jay (general_catch_clause): Comment out
32982 (specific_catch_clauses, specific_catch_clause): Ditto.
32983 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32984 (catch_args, opt_catch_args): New productions.
32985 (catch_clause): Rewrite to use the new productions above
32986 (catch_clauses): Modify accordingly.
32987 (opt_catch_clauses): New production to use in try_statement
32988 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32989 and re-write the code in the actions to extract the specific and
32990 general catch clauses by being a little smart ;-)
32992 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32993 Hooray, try and catch statements parse fine !
32995 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32997 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32998 string from the hashtable of variables.
33000 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33001 I end up making that mistake ;-)
33002 (catch_clauses): Fixed gross error which made Key and Value of the
33003 DictionaryEntry the same : $1 !!
33005 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33007 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33009 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33010 when the add and remove accessors are specified.
33012 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33014 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33015 information about indexer_declarator.
33016 (indexer_declarator): Implement actions.
33017 (parsing_indexer): New local boolean used to keep track of whether
33018 we are parsing indexers or properties. This is necessary because
33019 implicit_parameters come into picture even for the get accessor in the
33020 case of an indexer.
33021 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33023 * class.cs (Indexer): New class for indexer declarations.
33024 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33025 (TypeContainer::indexers): New member to hold list of indexers for the
33028 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33030 * cs-parser.jay (add_accessor_declaration): Implement action.
33031 (remove_accessor_declaration): Implement action.
33032 (event_accessors_declaration): Implement
33033 (variable_declarators): swap statements for first rule - trivial.
33035 * class.cs (Event): New class to hold information about event
33037 (TypeContainer::AddEvent): New method to add an event to a type
33038 (TypeContainer::events): New member to hold list of events.
33040 * cs-parser.jay (event_declaration): Implement actions.
33042 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33044 * cs-parser.jay (dim_separators): Implement. Make it a string
33045 concatenating all the commas together, just as they appear.
33046 (opt_dim_separators): Modify accordingly
33047 (rank_specifiers): Update accordingly. Basically do the same
33048 thing - instead, collect the brackets here.
33049 (opt_rank_sepcifiers): Modify accordingly.
33050 (array_type): Modify to actually return the complete type string
33051 instead of ignoring the rank_specifiers.
33052 (expression_list): Implement to collect the expressions
33053 (variable_initializer): Implement. We make it a list of expressions
33054 essentially so that we can handle the array_initializer case neatly too.
33055 (variable_initializer_list): Implement.
33056 (array_initializer): Make it a list of variable_initializers
33057 (opt_array_initializer): Modify accordingly.
33059 * expression.cs (New::NType): Add enumeration to help us
33060 keep track of whether we have an object/delegate creation
33061 or an array creation.
33062 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33063 members to hold data about array creation.
33064 (New:New): Modify to update NewType
33065 (New:New): New Overloaded contructor for the array creation
33068 * cs-parser.jay (array_creation_expression): Implement to call
33069 the overloaded New constructor.
33071 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33073 * class.cs (TypeContainer::Constructors): Return member
33074 constructors instead of returning null.
33076 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33078 * typemanager.cs (InitCoreTypes): Initialize the various core
33079 types after we have populated the type manager with the user
33080 defined types (this distinction will be important later while
33081 compiling corlib.dll)
33083 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33084 on Expression Classification. Now all expressions have a method
33085 `Resolve' and a method `Emit'.
33087 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33088 generation from working. Also add some temporary debugging
33091 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33093 * codegen.cs: Lots of code generation pieces. This is only the
33094 beginning, will continue tomorrow with more touches of polish. We
33095 handle the fundamentals of if, while, do, for, return. Others are
33096 trickier and I need to start working on invocations soon.
33098 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33101 * codegen.cs (EmitContext): New struct, used during code
33102 emission to keep a context. Most of the code generation will be
33105 * cs-parser.jay: Add embedded blocks to the list of statements of
33106 this block. So code generation proceeds in a top down fashion.
33108 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33110 * statement.cs: Add support for multiple child blocks.
33112 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33114 * codegen.cs (EmitCode): New function, will emit the code for a
33115 Block of code given a TypeContainer and its ILGenerator.
33117 * statement.cs (Block): Standard public readonly optimization.
33118 (Block::Block constructors): Link children.
33119 (Block::Child): Child Linker.
33120 (Block::EmitVariables): Emits IL variable declarations.
33122 * class.cs: Drop support for MethodGroups here, delay until
33124 (Method::): Applied the same simplification that I did before, and
33125 move from Properties to public readonly fields.
33126 (Method::ParameterTypes): Returns the parameter types for the
33127 function, and implements a cache that will be useful later when I
33128 do error checking and the semantic analysis on the methods is
33130 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33131 and made a method, optional argument tells whether this is a class
33132 or a structure to apply the `has-this' bit.
33133 (Method::GetCallingConvention): Implement, returns the calling
33135 (Method::Define): Defines the type, a second pass is performed
33136 later to populate the methods.
33138 (Constructor::ParameterTypes): implement a cache similar to the
33139 one on Method::ParameterTypes, useful later when we do semantic
33142 (TypeContainer::EmitMethod): New method. Emits methods.
33144 * expression.cs: Removed MethodGroup class from here.
33146 * parameter.cs (Parameters::GetCallingConvention): new method.
33148 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33150 * class.cs (TypeContainer::Populate): Drop RootContext from the
33153 (Constructor::CallingConvention): Returns the calling convention.
33154 (Constructor::ParameterTypes): Returns the constructor parameter
33157 (TypeContainer::AddConstructor): Keep track of default constructor
33158 and the default static constructor.
33160 (Constructor::) Another class that starts using `public readonly'
33161 instead of properties.
33163 (Constructor::IsDefault): Whether this is a default constructor.
33165 (Field::) use readonly public fields instead of properties also.
33167 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33168 track of static constructors; If none is used, turn on
33169 BeforeFieldInit in the TypeAttributes.
33171 * cs-parser.jay (opt_argument_list): now the return can be null
33172 for the cases where there are no arguments.
33174 (constructor_declarator): If there is no implicit `base' or
33175 `this', then invoke the default parent constructor.
33177 * modifiers.cs (MethodAttr): New static function maps a set of
33178 modifiers flags into a MethodAttributes enum
33179 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33180 MethodAttr, TypeAttr to represent the various mappings where the
33181 modifiers are used.
33182 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33184 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33186 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33189 * interface.cs (PopulateIndexer): Implemented the code generator
33190 for interface indexers.
33192 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33194 * interface.cs (InterfaceMemberBase): Now we track the new status
33197 (PopulateProperty): Implement property population. Woohoo! Got
33198 Methods and Properties going today.
33200 Removed all the properties for interfaces, and replaced them with
33201 `public readonly' fields.
33203 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33205 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33206 initialize their hashtables/arraylists only when they are needed
33207 instead of doing this always.
33209 * parameter.cs: Handle refs and out parameters.
33211 * cs-parser.jay: Use an ArrayList to construct the arguments
33212 instead of the ParameterCollection, and then cast that to a
33215 * parameter.cs: Drop the use of ParameterCollection and use
33216 instead arrays of Parameters.
33218 (GetParameterInfo): Use the Type, not the Name when resolving
33221 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33223 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33224 and instead use public readonly fields.
33226 * class.cs: Put back walking code for type containers.
33228 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33230 * class.cs (MakeConstant): Code to define constants.
33232 * rootcontext.cs (LookupType): New function. Used to locate types
33235 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33237 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33238 this System.Reflection code is. Kudos to Microsoft
33240 * typemanager.cs: Implement a type cache and avoid loading all
33241 types at boot time. Wrap in LookupType the internals. This made
33242 the compiler so much faster. Wow. I rule!
33244 * driver.cs: Make sure we always load mscorlib first (for
33245 debugging purposes, nothing really important).
33247 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33248 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33250 * rootcontext.cs: Lookup types on their namespace; Lookup types
33251 on namespaces that have been imported using the `using' keyword.
33253 * class.cs (TypeContainer::TypeAttr): Virtualize.
33254 (Class::TypeAttr): Return attributes suitable for this bad boy.
33255 (Struct::TypeAttr): ditto.
33256 Handle nested classes.
33257 (TypeContainer::) Remove all the type visiting code, it is now
33258 replaced with the rootcontext.cs code
33260 * rootcontext.cs (GetClassBases): Added support for structs.
33262 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33264 * interface.cs, statement.cs, class.cs, parameter.cs,
33265 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33266 Drop use of TypeRefs, and use strings instead.
33268 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33272 * class.cs (Struct::Struct): set the SEALED flags after
33273 checking the modifiers.
33274 (TypeContainer::TypeAttr): new property, returns the
33275 TypeAttributes for a class.
33277 * cs-parser.jay (type_list): Oops, list production was creating a
33278 new list of base types.
33280 * rootcontext.cs (StdLib): New property.
33281 (GetInterfaceTypeByName): returns an interface by type name, and
33282 encapsulates error handling here.
33283 (GetInterfaces): simplified.
33284 (ResolveTree): Encapsulated all the tree resolution here.
33285 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33288 * driver.cs: Add support for --nostdlib, to avoid loading the
33289 default assemblies.
33290 (Main): Do not put tree resolution here.
33292 * rootcontext.cs: Beginning of the class resolution.
33294 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33296 * rootcontext.cs: Provide better error reporting.
33298 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33300 * rootcontext.cs (CreateInterface): Handle the case where there
33301 are no parent interfaces.
33303 (CloseTypes): Routine to flush types at the end.
33304 (CreateInterface): Track types.
33305 (GetInterfaces): Returns an array of Types from the list of
33306 defined interfaces.
33308 * typemanager.c (AddUserType): Mechanism to track user types (puts
33309 the type on the global type hash, and allows us to close it at the
33312 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33314 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33315 RecordInterface instead.
33317 * cs-parser.jay: Updated to reflect changes above.
33319 * decl.cs (Definition): Keep track of the TypeBuilder type that
33320 represents this type here. Not sure we will use it in the long
33321 run, but wont hurt for now.
33323 * driver.cs: Smaller changes to accomodate the new code.
33325 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33328 * rootcontext.cs (CreateInterface): New method, used to create
33329 the System.TypeBuilder type for interfaces.
33330 (ResolveInterfaces): new entry point to resolve the interface
33332 (CodeGen): Property, used to keep track of the code generator.
33334 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33336 * cs-parser.jay: Add a second production for delegate_declaration
33339 (enum_body): Put an opt_comma here instead of putting it on
33340 enum_body or enum_member_declarations so we can handle trailing
33341 commas on enumeration members. Gets rid of a shift/reduce.
33343 (type_list): Need a COMMA in the middle.
33345 (indexer_declaration): Tell tokenizer to recognize get/set
33347 * Remove old targets.
33349 * Re-add the parser target.
33351 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33353 * cs-parser.jay: Add precendence rules for a number of operators
33354 ot reduce the number of shift/reduce conflicts in the grammar.
33356 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33358 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33361 Get rid of old crufty code.
33363 * rootcontext.cs: Use this to keep track of the parsed
33364 representation and the defined types available to the program.
33366 * gen-treedump.cs: adjust for new convention.
33368 * type.cs: Split out the type manager, and the assembly builder
33371 * typemanager.cs: the type manager will live here now.
33373 * cil-codegen.cs: And the code generator here.
33375 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33377 * makefile: Fixed up for easy making.
33379 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33381 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33384 (unary_expression): Expand pre_increment_expression and
33385 post_decrement_expression to reduce a shift/reduce.
33387 2001-07-11 Simon Cozens
33389 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33391 Improve allow_keyword_as_indent name.
33393 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33395 * Adjustments for Beta2.
33397 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33399 * decl.cs: Added `Define' abstract method.
33400 (InTransit): new property, used to catch recursive definitions.
33402 * interface.cs: Implement `Define'.
33404 * modifiers.cs: Map Modifiers.constants to
33405 System.Reflection.TypeAttribute flags.
33407 * class.cs: Keep track of types and user-defined types.
33408 (BuilderInit): New method for creating an assembly
33409 (ResolveType): New function to launch the resolution process, only
33410 used by interfaces for now.
33412 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33413 that are inserted into the name space.
33415 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33417 * ARGH. I have screwed up my tree so many times due to the use of
33418 rsync rather than using CVS. Going to fix this at once.
33420 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33423 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33425 * Experiment successful: Use System.Type rather that our own
33428 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33430 * cs-parser.jay: Removed nsAliases from here.
33432 Use new namespaces, handle `using XXX;'
33434 * namespace.cs: Reimplemented namespace handling, use a recursive
33435 definition of the class. Now we can keep track of using clauses
33436 and catch invalid using clauses.
33438 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33440 * gen-treedump.cs: Adapted for all the renaming.
33442 * expression.cs (Expression): this class now has a Type property
33443 which returns an expression Type.
33445 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33446 `Type', as this has a different meaning now in the base
33448 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33450 * interface.cs, class.cs: Removed from all the sources the
33451 references to signature computation, as we can not do method
33452 signature computation during the parsing time, as we are not
33453 trying to solve at that point distinguishing:
33457 void a (NS.Blah x) {}
33460 Which depending on the context might be valid or not, as we do not
33461 know if Blah is the same thing as NS.Blah at that point.
33463 * Redid everything so the code uses TypeRefs now instead of
33464 Types. TypeRefs are just temporary type placeholders, that need
33465 to be resolved. They initially have a pointer to a string and the
33466 current scope in which they are used. This is used later by the
33467 compiler to resolve the reference to an actual Type.
33469 * DeclSpace is no longer a CIR.Type, and neither are
33470 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33471 are all DeclSpaces, but no Types.
33473 * type.cs (TypeRefManager): This implements the TypeRef manager,
33474 which keeps track of all the types that need to be resolved after
33475 the parsing has finished.
33477 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33479 * ARGH. We are going to have to store `foreach' as a class rather
33480 than resolving it, as we need to verify error 1579 after name
33481 resolution. *OR* we could keep a flag that says `This request to
33482 IEnumerator comes from a foreach statement' which we can then use
33483 to generate the error.
33485 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33487 * class.cs (TypeContainer.AddMethod): we now add methods to the
33488 MethodGroup instead of the method hashtable.
33490 * expression.cs: Add MethodGroup abstraction, which gets us one
33491 step closer to the specification in the way we handle method
33494 * cs-parser.jay (primary_expression): qualified_identifier now
33495 tried to match up an identifier to a local variable reference or
33496 to a parameter reference.
33498 current_local_parameters is now a parser global variable that
33499 points to the current parameters for the block, used during name
33502 (property_declaration): Now creates an implicit `value' argument to
33505 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33507 * parameter.cs: Do not use `param' arguments as part of the
33508 signature, per the spec.
33510 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33512 * decl.cs: Base class for classes, structs and interfaces. This
33513 is the "Declaration Space"
33515 * cs-parser.jay: Use CheckDef for checking declaration errors
33516 instead of having one on each function.
33518 * class.cs: Factor out some code for handling error handling in
33519 accordance to the "Declarations" section in the "Basic Concepts"
33520 chapter in the ECMA C# spec.
33522 * interface.cs: Make all interface member classes derive from
33523 InterfaceMemberBase.
33525 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33527 * Many things: all interfaces are parsed and generated in
33528 gen-treedump. Support for member variables, constructors,
33529 destructors, properties, constants is there.
33531 Beginning of the IL backend, but very little done, just there for
33534 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33536 * cs-parser.jay: Fix labeled statement.
33538 * cs-tokenizer.cs (escape): Escape " and ' always.
33539 ref_line, ref_name: keep track of the line/filename as instructed
33540 by #line by the compiler.
33543 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33545 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33546 to match the values in System.CodeDOM.
33548 Divid renamed to Divide.
33550 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33552 (Statements.set): remove.
33554 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33557 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33558 falseStatements always have valid values.
33560 * cs-parser.jay: Use System.CodeDOM now.