1 2010-04-12 Marek Safar <marek.safar@gmail.com>
3 * expression.cs, attribute.cs: More attribute type checks.
5 2010-04-12 Marek Safar <marek.safar@gmail.com>
9 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
10 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
11 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
12 codegen.cs: Add custom attribute encoder to deal with unfinished
13 types and easier corlib bootstrap from its own types.
15 2010-03-26 Marek Safar <marek.safar@gmail.com>
17 * cs-parser.jay: Report invalid constraint types.
19 2010-03-16 Jb Evain <jbevain@novell.com>
21 * Makefile: rename the net_2_1 profile to moonlight.
23 2010-03-11 Marek Safar <marek.safar@gmail.com>
25 * statement.cs, cs-parser.jay: Use correct location for empty
28 2010-03-11 Marek Safar <marek.safar@gmail.com>
30 * cs-parser.jay: Disable Location from expression.
32 * generic.cs: Check constraints for overrides in the parser.
34 2010-03-09 Marek Safar <marek.safar@gmail.com>
36 * cs-parser.jay (GetLocation): Use an expression when available.
38 2010-03-04 Marek Safar <marek.safar@gmail.com>
41 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
43 2010-03-04 Marek Safar <marek.safar@gmail.com>
45 A patch by kornelpal@gmail.com
47 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
48 compiler generated classes sealed by default. Emit and close top
49 level compiler generated classes as well.
51 * support.cs: Use RuntimeHelpers.GetHashCode.
53 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
55 * Makefile: We need to use the internal bootstrapping gmcs for
56 net_2_1_bootstrap too now.
58 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
60 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
62 2010-03-02 Marek Safar <marek.safar@gmail.com>
64 * cs-tokenizer.cs: Missed few locations in previous fix.
66 2010-03-02 Marek Safar <marek.safar@gmail.com>
68 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
69 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
70 Report correct location for operator errors.
72 2010-03-02 Marek Safar <marek.safar@gmail.com>
74 * typemanager.cs (IsDynamicType): Don't check external types when
75 the attribute is not external.
77 2010-02-24 Marek Safar <marek.safar@gmail.com>
80 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
83 2010-02-24 Marek Safar <marek.safar@gmail.com>
86 * ecore.cs: Fixed type comparison.
88 2010-02-08 Miguel de Icaza <miguel@novell.com>
90 * namespace.cs (CompletionGetTypesStartingWith): Do not include
91 private types in the completion results.
93 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
96 2010-02-17 Marek Safar <marek.safar@gmail.com>
98 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
101 2010-02-14 Miguel de Icaza <miguel@novell.com>
103 * eval.cs: Do not do the report printer dance unless the user has
104 set the DescribeTypes feature.
106 2010-02-10 Marek Safar <marek.safar@gmail.com>
108 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
110 2010-02-08 Marek Safar <marek.safar@gmail.com>
112 A fix for bug #577029
113 * anonymous.cs: Fixed TypeBuilder* check.
115 2010-02-06 Miguel de Icaza <miguel@novell.com>
117 * eval.cs (CompileBlock): Also undo if there are problems during
118 semantic analysis, fixes various cases where invalid C# code would
119 be reported, but the internal changes would not be undone.
121 2010-02-03 Miguel de Icaza <miguel@novell.com>
123 * driver.cs: Change the --fatal flag to allow a number to be
124 passed, this ignores the first N fatal errors. Useful to debug
125 errors that do not happen on the first hit.
127 * cs-parser.jay (invocation_expression): accept both the
128 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
129 inside an invocation.
131 * driver.cs: Expose FatalErrors.
133 * eval.cs: Initialize the printer's Fatal property from the
134 Driver's FatalError flag, this allows csharp --fatal to work
137 Add support for calling Describe (typeof (TYPE)) if the expression
140 2010-02-02 Marek Safar <marek.safar@gmail.com>
142 A fix for bug #574991
143 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
146 2010-02-02 Marek Safar <marek.safar@gmail.com>
148 A fix for bug #575986
149 * expression.cs: Don't mutate typeof type definitions.
151 2010-01-28 Marek Safar <marek.safar@gmail.com>
153 * decl.cs: Use only one set of modifiers.
155 2010-01-26 Marek Safar <marek.safar@gmail.com>
157 A fix for bug #573329
158 * eval.cs: Don't disable error reporting completely on silent mode.
160 2010-01-25 Marek Safar <marek.safar@gmail.com>
162 A fix for bug #573312
163 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
164 pointer index of unknown size types greater than 2.
166 2010-01-15 Marek Safar <marek.safar@gmail.com>
168 * *.cs: Use only 1 member kind enum.
170 2010-01-15 Marek Safar <marek.safar@gmail.com>
172 * *.cs: Add event specification.
174 2010-01-14 Marek Safar <marek.safar@gmail.com>
176 * membercache.cs: Extracted from decl.cs.
178 * *.cs: Put more infrastructure in place.
180 2010-01-13 Marek Safar <marek.safar@gmail.com>
182 * *.cs: Add property specification, unused yet.
184 2010-01-13 Marek Safar <marek.safar@gmail.com>
186 * property.cs: Move all property based declarations into a new file.
188 2010-01-13 Marek Safar <marek.safar at gmail.com>
190 * expression.cs (Conditional): Resolve reduced expression.
192 2010-01-13 Marek Safar <marek.safar at gmail.com>
194 * *.cs: Introduced non-generic method specification.
196 2010-01-07 Marek Safar <marek.safar@gmail.com>
198 * method.cs: Move all method based declarations into a new file.
200 2010-01-07 Marek Safar <marek.safar@gmail.com>
202 * *.cs: Extract field specification.
204 2009-12-17 Marek Safar <marek.safar@gmail.com>
206 * field.cs: Extracted from class.cs
208 2009-12-15 Marek Safar <marek.safar@gmail.com>
210 * attribute.cs (GetFixedBuffer): Work on field definition only.
212 2009-12-15 Marek Safar <marek.safar@gmail.com>
214 * *.cs: Clean up NET_4_0 conditional where possible.
216 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
218 support.cs (DynamicType): Assembly property returns the assembly builder.
219 This is required due to how compiler context works in corlib.
221 2009-12-14 Marek Safar <marek.safar@gmail.com>
223 A fix for bug #564376
224 * assign.cs (LocalTemporary): Removed no longer needed special
227 2009-12-11 Marek Safar <marek.safar@gmail.com>
229 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
230 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
231 enum for easier debugging.
233 2009-12-10 Marek Safar <marek.safar@gmail.com>
235 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
238 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
241 2009-12-10 Marek Safar <marek.safar@gmail.com>
243 * cs-parser.jay, statement.cs: Handle parser error in code
246 2009-12-10 Marek Safar <marek.safar@gmail.com>
248 * ecore.cs: Ignore base imported methods when they are already
251 * eval.cs: Handle non-existent keys.
253 * report.cs, driver.cs: Make fatal work with console printer only.
255 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
257 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
259 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
261 * typemanager.cs: Add MakeGenericMethod that checks if the method
262 is really the generic method definition.
264 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
265 to inflate generic methods.
267 2009-12-08 Marek Safar <marek.safar@gmail.com>
269 A fix for bug #561149
270 * anonymous.cs: Use actual type parameters when checking for generic
273 2009-12-08 Marek Safar <marek.safar@gmail.com>
275 A fix for bug #561369
276 * expression.cs (DoNumericPromotion): Fixed typo.
278 2009-12-08 Marek Safar <marek.safar@gmail.com>
280 *.cs: Moving to generics world.
282 cs-parser.jay: Removed current_array_type.
284 2009-12-07 Marek Safar <marek.safar@gmail.com>
286 *.cs: Moving to generics world.
288 2009-12-04 Marek Safar <marek.safar@gmail.com>
290 *.cs: Moving to generics world (day 2).
292 2009-12-03 Marek Safar <marek.safar@gmail.com>
294 *.cs: Moving to generics world.
296 2009-12-02 Marek Safar <marek.safar@gmail.com>
298 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
299 Encode dynamic type attribute for elements where attributes cannot
302 2009-12-01 Marek Safar <marek.safar@gmail.com>
304 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
307 2009-12-01 Marek Safar <marek.safar@gmail.com>
309 A fix for bug #360455
310 * class.cs: Never report a unused warning for generic events to
311 workaround wrong expression type.
313 2009-11-30 Marek Safar <marek.safar@gmail.com>
315 A fix for bug #558305
316 * decl.cs, class.cs: Check partial method definitions using correct
319 2009-11-30 Marek Safar <marek.safar@gmail.com>
321 * argument.cs: Don't cache rarely used dynamic flag.
323 2009-11-27 Marek Safar <marek.safar@gmail.com>
325 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
327 2009-11-27 Marek Safar <marek.safar@gmail.com>
329 * ecore.cs (SimpleName): Removed no longer needed in_transit as
330 Resolve is now non-reentrant (saves ~0.6MB for corlib).
332 2009-11-26 Marek Safar <marek.safar@gmail.com>
334 A fix for bug #545081
335 * decl.cs: Check private nested types of nested types recursively.
337 2009-11-26 Marek Safar <marek.safar@gmail.com>
339 A fix for bug #558305
340 * location.cs: Ignore self referencing #line directive
342 2009-11-26 Marek Safar <marek.safar@gmail.com>
344 A fix for bug #558292
345 * class.cs: Allow single unsafe fixed buffer fields.
347 2009-11-26 Marek Safar <marek.safar@gmail.com>
349 * expression: Optimize few more zero-based operations.
351 2009-11-26 Marek Safar <marek.safar@gmail.com>
353 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
354 avoids boxing of literal values.
356 2009-11-26 Marek Safar <marek.safar@gmail.com>
358 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
359 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
360 codegen.cs: LocatedToken redesing to avoid excessive allocation and
361 boxing (saves ~7MB for corlib). Also fixes presise token location.
363 2009-11-25 Marek Safar <marek.safar@gmail.com>
365 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
368 2009-11-24 Marek Safar <marek.safar@gmail.com>
370 * expression.cs: Lower static array initializer barrier.
372 * support.cs, driver.cs: Share reader buffer.
374 2009-11-23 Marek Safar <marek.safar@gmail.com>
376 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
378 2009-11-23 Marek Safar <marek.safar@gmail.com>
380 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
381 cleanup some obsolete code.
383 2009-11-20 Marek Safar <marek.safar@gmail.com>
385 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
388 2009-11-20 Marek Safar <marek.safar@gmail.com>
390 * *.cs: Resolved expressions are never resolved again, this helps to
391 uncover some not easy to find bugs and improve the performance.
393 2009-11-19 Marek Safar <marek.safar@gmail.com>
395 * *.cs: Made constant expressions fully compatible with any other
398 2009-11-19 Marek Safar <marek.safar@gmail.com>
400 * *.cs: DoResolve is a worker method and has to be protected.
402 2009-11-18 Marek Safar <marek.safar@gmail.com>
404 * *.cs: More context specific handling.
406 2009-11-17 Marek Safar <marek.safar@gmail.com>
408 * *.cs: More context specific handling.
410 2009-11-16 Marek Safar <marek.safar@gmail.com>
412 * dynamic.cs, class.cs: Removed few fixed user types conversions.
414 * symbolwriter.cs: Uses public ILOffset.
416 2009-11-13 Marek Safar <marek.safar@gmail.com>
418 A fix for bug #553650
419 * generic.cs: Another missing TypeToCoreType, still too many to fix.
421 2009-11-13 Marek Safar <marek.safar@gmail.com>
423 A fix for bug #555170
425 * class.cs, delegate.cs, enum.cs: Constants have to be available
426 for parameters resolve.
428 2009-11-12 Marek Safar <marek.safar@gmail.com>
430 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
433 2009-11-12 Marek Safar <marek.safar@gmail.com>
435 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
436 with a statically known candidate set.
438 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
440 * generic.cs: Made type inflation for generic constraint checks
441 recursive. This fixes BGO #553655.
443 2009-11-11 Marek Safar <marek.safar@gmail.com>
445 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
448 2009-11-10 Marek Safar <marek.safar@gmail.com>
450 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
451 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
452 attribute.cs: Add some dynamic error checking.
454 2009-11-07 Marek Safar <marek.safar@gmail.com>
456 A fix for bug #553465
458 * expression.cs: Fixed mixed version of expression tree anonymous
461 2009-11-06 Marek Safar <marek.safar@gmail.com>
463 A fix for bug #553031
465 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
466 expression tree version of anonymous type with members declaration.
468 2009-11-05 Marek Safar <marek.safar@gmail.com>
470 * parameter.cs: Handle nullable parameter default expression.
472 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
473 class.cs, attribute.cs: Check for wrong dynamic arguments.
475 2009-11-05 Marek Safar <marek.safar@gmail.com>
477 * statement.cs: Dynamic statements.
479 2009-11-04 Marek Safar <marek.safar@gmail.com>
481 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
482 Compound assignments over dynamic type.
484 2009-11-03 Marek Safar <marek.safar@gmail.com>
486 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
487 constructor arguments.
489 2009-10-30 Marek Safar <marek.safar@gmail.com>
491 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
492 codegen.cs: Unary mutator on dynamic member access expression.
494 2009-10-29 Marek Safar <marek.safar@gmail.com>
496 A fix for bug #550580
497 * convert.cs: Don't eliminate explicit precission casts.
499 2009-10-28 Marek Safar <marek.safar@gmail.com>
501 A fix for bug #550404
503 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
504 expression.cs, statement.cs, ecore.cs: Quote any nested expression
507 2009-10-27 Marek Safar <marek.safar@gmail.com>
509 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
512 * class.cs: Allow nullable binary user operators.
514 2009-10-26 Marek Safar <marek.safar@gmail.com>
516 * expression.cs: Move binary expression optimization at the end of
519 2009-10-23 Marek Safar <marek.safar@gmail.com>
521 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
522 Separate NullConstant from NullLiteral.
524 2009-10-23 Marek Safar <marek.safar@gmail.com>
526 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
527 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
528 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
529 ModuleContainer. Add common unclosed member check routine.
531 2009-10-22 Marek Safar <marek.safar@gmail.com>
533 * argument.cs: Use literal flag for real literals only.
535 * dynamic.cs: Use correct return type for custom delegates.
537 2009-10-22 Marek Safar <marek.safar@gmail.com>
539 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
542 2009-10-22 Marek Safar <marek.safar@gmail.com>
544 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
546 2009-10-21 Marek Safar <marek.safar@gmail.com>
548 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
551 2009-10-21 Marek Safar <marek.safar@gmail.com>
553 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
556 2009-10-20 Marek Safar <marek.safar@gmail.com>
558 * argument.cs, dynamic.cs, expression.cs: Latest API update.
560 2009-10-19 Marek Safar <marek.safar@gmail.com>
562 * typemanager.cs, expression.cs: Dynamic array initializer.
564 2009-10-16 Marek Safar <marek.safar@gmail.com>
566 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
569 2009-10-16 Marek Safar <marek.safar@gmail.com>
571 A fix for bug #493523, #507067
572 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
573 standard nullable conversion using underlying standard conversion
574 and not full conversion.
576 2009-10-15 Marek Safar <marek.safar@gmail.com>
578 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
579 type in VerifyArgumentsCompat.
581 2009-10-15 Marek Safar <marek.safar@gmail.com>
583 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
584 Reject variable used with type arguments.
586 2009-10-14 Marek Safar <marek.safar@gmail.com>
588 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
589 Implement dynamic expressions assignment.
591 2009-10-14 Marek Safar <marek.safar@gmail.com>
593 * expression.cs: Build underlying expression when resolving unary
596 2009-10-14 Marek Safar <marek.safar@gmail.com>
598 * expression.cs: Emit enum array initializer using binary blob.
600 2009-10-08 Marek Safar <marek.safar@gmail.com>
602 * typemanager.cs, constant.cs: Optimize decimal constants which fit
605 2009-10-07 Marek Safar <marek.safar@gmail.com>
607 * typemanager.cs: Reset object_type.
609 * assign: Made SimpleAssign public.
611 2009-10-06 Marek Safar <marek.safar@gmail.com>
613 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
614 invocation assembly to IsThisOrFriendAssembly.
616 2009-10-05 Marek Safar <marek.safar@gmail.com>
618 * expression.cs: Equality comparison of generic parameter with
621 2009-10-05 Marek Safar <marek.safar@gmail.com>
623 A fix for bug #543570
624 * generic.cs: Import predefined constraints correctly.
626 2009-10-02 Marek Safar <marek.safar@gmail.com>
628 * ecore.cs: Don't crash on overloads with optional paremeters where
629 arguments count overflows.
631 * parameter.cs: Import optional parameter constants using optional
634 2009-10-01 Marek Safar <marek.safar@gmail.com>
636 * Makefile: Default is gmcs compiler.
638 2009-10-01 Marek Safar <marek.safar@gmail.com>
640 * cs-parser.jay: Fixed few NRE.
642 2009-10-01 Marek Safar <marek.safar@gmail.com>
644 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
646 2009-09-30 Marek Safar <marek.safar@gmail.com>
648 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
649 ShimExpression, ImplicitCast.
651 2009-09-30 Marek Safar <marek.safar@gmail.com>
653 A fix for bug #542959
654 * delegate.cs: Emit correct delegate instance variable when there
655 are static and non-static overloads.
657 2009-09-29 Marek Safar <marek.safar@gmail.com>
659 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
660 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
662 2009-09-28 Marek Safar <marek.safar@gmail.com>
664 A fix for bug #542487
665 * ecore.cs: Resolve extension methods hidden by properties.
667 2009-09-25 Marek Safar <marek.safar@gmail.com>
669 * expression.cs, ecore.cs: More dynamic binary expressions.
671 2009-09-22 Marek Safar <marek.safar@gmail.com>
673 * nullable.cs, expression.cs: Fixed null lifted conversion for
674 bitwise enum operations.
676 2009-09-22 Marek Safar <marek.safar@gmail.com>
678 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
679 values in checked context.
681 2009-09-22 Marek Safar <marek.safar@gmail.com>
683 * expression.cs, ecore.cs: Fixed array index constant conversion.
685 2009-09-20 Miguel de Icaza <miguel@novell.com>
687 * expression.cs: Do not crash when MemberLookup returns something
688 that is not a MemberExpr here. Report error 582 instead.
692 2009-09-18 Marek Safar <marek.safar@gmail.com>
694 * decl.cs, class.cs: Check protected property accessors.
696 2009-09-18 Marek Safar <marek.safar@gmail.com>
698 * dynamic.cs, assign.cs: Dynamic compound assignment.
700 2009-09-17 Marek Safar <marek.safar@gmail.com>
702 * expression.cs: Fixed compound assignment explicit conversion.
704 2009-09-17 Marek Safar <marek.safar@gmail.com>
706 * expression.cs, ecore.cs: Cannot infer variables from method group.
708 2009-09-16 Marek Safar <marek.safar@gmail.com>
710 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
711 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
712 codegen.cs: Dynamic binary operations scaffolding.
714 2009-09-15 Marek Safar <marek.safar@gmail.com>
716 * expression.cs: Fixes nullable promotion for enum type variables.
718 2009-09-11 Marek Safar <marek.safar@gmail.com>
720 * driver.cs, dynamic.cs: Reset more static variables.
722 2009-09-11 Marek Safar <marek.safar@gmail.com>
724 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
725 driver.cs: Introduced Expression::MakeExpression.
727 2009-09-11 Marek Safar <marek.safar@gmail.com>
729 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
731 2009-09-09 Marek Safar <marek.safar@gmail.com>
733 * eval.cs, report.cs: Use Console.Out for all eval error or warning
736 2009-09-09 Marek Safar <marek.safar@gmail.com>
738 A fix for bug #518707
739 * expression.cs (Is): Optimize only generic parameter type
740 expression probing value type generic parameter.
742 2009-09-09 Marek Safar <marek.safar@gmail.com>
744 A fix for bug #532571
745 * ecore.cs: Check for simple name type arguments used with
748 2009-09-08 Marek Safar <marek.safar@gmail.com>
750 A fix for bug #497421
751 * generic.cs (CheckConstraint): Don't use buildin types to check for
752 parameterless constructor.
754 2009-09-08 Marek Safar <marek.safar@gmail.com>
756 A fix for bug #537402
757 * generic.cs (CheckConstraint): Correctly inflate generic type
758 arguments when checking generic method.
760 2009-09-08 Marek Safar <marek.safar@gmail.com>
762 A fix for bug #536463
763 * decl.cs (AddToContainer): Don't report collision between explicit
764 and parameterless non-explicit members.
766 2009-09-08 Marek Safar <marek.safar@gmail.com>
768 * eval.cs: Reset more static stuff.
770 2009-09-07 Marek Safar <marek.safar@gmail.com>
772 A fix for bug #324625
773 * expression.cs, ecore.cs: Create nested generic type expression
774 using declaring and not current type.
776 2009-09-07 Marek Safar <marek.safar@gmail.com>
778 * *.cs: Changed Report class to accept various output printers and
779 be an instance class. An expression resolver can now use different
780 message reporter for each call and Report.Error can safely throw
781 an exception. Part of ongoing work to turn mcs into proper library.
783 2009-09-04 Marek Safar <marek.safar@gmail.com>
785 * statement.cs, ecore.cs: Removed error reporting from emit code.
787 2009-09-04 Marek Safar <marek.safar@gmail.com>
789 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
791 2009-09-03 Marek Safar <marek.safar@gmail.com>
793 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
794 parser checks out of constructors.
796 2009-09-02 Marek Safar <marek.safar@gmail.com>
798 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
800 2009-09-02 Marek Safar <marek.safar@gmail.com>
802 A fix for bug #535448
803 * anonymous.cs, class.cs: Copy return label between all contexts.
805 2009-09-02 Marek Safar <marek.safar@gmail.com>
807 A fix for bug #535395
808 * namespace.cs: Resolve context can be null.
810 2009-08-25 Marek Safar <marek.safar@gmail.com>
812 A fix for bug #533912
813 * generic.cs: Use correct context for constraints resolving.
815 2009-08-25 Marek Safar <marek.safar@gmail.com>
817 A fix for bug #532630
818 * driver.cs: Trim conditional symbols.
820 2009-08-25 Marek Safar <marek.safar@gmail.com>
822 * context.cs: New file.
824 * *.exe.sources, *.csproj: Updated.
826 2009-08-25 Marek Safar <marek.safar@gmail.com>
828 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
829 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
830 IMembercontext, some small cleanups.
832 2009-08-24 Marek Safar <marek.safar@gmail.com>
834 * *.cs: Split ResolveContext and EmitContext.
836 2009-08-24 Marek Safar <marek.safar@gmail.com>
838 * *.cs: Only ResolveContext implements IMemberContext.
840 2009-08-21 Marek Safar <marek.safar@gmail.com>
842 * *.cs: Renamed IResolveContext to IMemberContext.
844 2009-08-21 Marek Safar <marek.safar@gmail.com>
846 * *.cs: Detached ResolveContext from EmitContext.
848 2009-08-21 Marek Safar <marek.safar@gmail.com>
850 * codegen.cs: Moved flow-analysis to BlockContext.
852 2009-08-21 Marek Safar <marek.safar@gmail.com>
854 * *.cs: Detached BlockContext from EmitContext.
856 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
858 * statement.cs: avoid nullref when the return value of GetEnumerator()
859 does not contain any MoveNext() method.
861 2009-08-19 Marek Safar <marek.safar@gmail.com>
863 * *.cs: Removed IResolveContext::GenericDeclContainer.
865 2009-08-19 Marek Safar <marek.safar@gmail.com>
867 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
869 2009-08-19 Marek Safar <marek.safar@gmail.com>
871 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
872 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
874 2009-08-18 Marek Safar <marek.safar@gmail.com>
876 * *.cs: Removed boolean fields from EmitContext.
878 2009-08-18 Marek Safar <marek.safar@gmail.com>
880 * *.cs: Add IResolveContext::IsStatic.
882 2009-08-18 Marek Safar <marek.safar@gmail.com>
884 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
886 2009-08-17 Marek Safar <marek.safar@gmail.com>
888 * *.cs: Removed DeclContainer from EmitContext.
890 2009-08-17 Marek Safar <marek.safar@gmail.com>
892 * *.cs: Add IResolveContext::CurrentTypeParameters.
894 2009-08-14 Marek Safar <marek.safar@gmail.com>
896 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
898 2009-08-14 Marek Safar <marek.safar@gmail.com>
900 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
901 codegen.cs: Add IResolveContext::LookupExtensionMethod.
903 2009-08-13 Marek Safar <marek.safar@gmail.com>
905 * decl.cs: Look in PartialContainer for parent type parameters.
907 2009-08-13 Marek Safar <marek.safar@gmail.com>
909 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
910 codegen.cs: Add IResolveContext::LookupTypeParameter.
912 2009-08-13 Marek Safar <marek.safar@gmail.com>
914 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
915 Moved resolved logic from Emit to Resolve.
917 2009-08-13 Marek Safar <marek.safar@gmail.com>
919 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
920 codegen.cs: Reworked atttributes handling of ResolveContext.
922 2009-08-12 Marek Safar <marek.safar@gmail.com>
924 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
925 LookupNamespaceOrType to ResolveContext.
927 2009-08-12 Marek Safar <marek.safar@gmail.com>
929 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
930 class.cs: Removed unused parameters and methods.
932 2009-08-11 Marek Safar <marek.safar@gmail.com>
934 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
935 codegen.cs: Finding the best common type of a set of expressions for
938 2009-08-07 Marek Safar <marek.safar@gmail.com>
940 * dynamic.cs, expression.cs: More dynamic conversions.
942 2009-08-06 Miguel de Icaza <miguel@novell.com>
944 * generic.cs: This loop was incorrect, it was increment ii, but
945 checking for `i'. This was a change introduced to fix #327497,
948 * class.cs: Catch another case for cs0533 error, fixes #324782.
950 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
952 * typemanager.cs (GetGenericArguments): SRE returns null for
953 generic methods on type builder instances if they are not generic
954 themselves. For example, for Foo<int>::Bar() it returns null, but
955 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
957 2009-08-05 Marek Safar <marek.safar@gmail.com>
959 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
960 delegate.cs: Work on dynamic binding.
962 2009-08-04 Marek Safar <marek.safar@gmail.com>
964 A second fix for bug #525342
965 * class.cs: Attach partial method attributes to method
968 2009-08-03 Marek Safar <marek.safar@gmail.com>
970 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
973 * rootcontext.cs: Default to langversion v4.
975 2009-08-03 Marek Safar <marek.safar@gmail.com>
977 * pending.cs: Check return type before member info is set.
979 2009-08-03 Marek Safar <marek.safar@gmail.com>
981 * anonymous.cs: Fully initialize generic hoisted field expression.
983 2009-08-02 Miguel de Icaza <miguel@novell.com>
985 * cs-parser.jay: Flag variables declared on the interactive shell
986 as used to prevent the 168 warning about local variable not being
989 2009-07-31 Marek Safar <marek.safar@gmail.com>
991 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
992 attribute.cs: Emit dynamic export attribute.
994 2009-07-30 Marek Safar <marek.safar@gmail.com>
996 * expression.cs: More verifier work.
998 2009-07-29 Marek Safar <marek.safar@gmail.com>
1000 * nullable.cs: Fixed SRE crash during corlib compilation.
1002 2009-07-29 Marek Safar <marek.safar@gmail.com>
1004 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1005 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1006 More TypeManager.TypeToCoreType needed.
1008 2009-07-29 Marek Safar <marek.safar@gmail.com>
1010 * anonymous.cs: Update after recent SRE fixes.
1012 2009-07-28 Marek Safar <marek.safar@gmail.com>
1014 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1015 version of GetFieldHandle for fields of generic types.
1017 2009-07-27 Marek Safar <marek.safar@gmail.com>
1019 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1020 ecore.cs: Add TypeManager.IsDynamicType,
1021 PredefinedAttributes.Dynamic.
1023 2009-07-27 Marek Safar <marek.safar@gmail.com>
1025 A fix for bug #415375
1026 * expression.cs: Fixed object and reference type parameter
1029 2009-07-27 Marek Safar <marek.safar@gmail.com>
1031 A fix for bug #525342
1032 * class.cs: Attach partial method attributes to method
1035 2009-07-24 Marek Safar <marek.safar@gmail.com>
1037 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1040 2009-07-24 Marek Safar <marek.safar@gmail.com>
1042 * anonymous.cs (MutateField): Add imported types handling.
1044 2009-07-23 Marek Safar <marek.safar@gmail.com>
1046 * expression.cs, delegate.cs: Moved arguments resolve into their
1047 counterparts expressions. Removed argument resolve from
1048 CollectionElementInitializer.
1050 2009-07-23 Marek Safar <marek.safar@gmail.com>
1052 A fix for bug #523683
1053 * convert.cs, delegate.cs: Use common overload mechanism for method
1054 group conversion check.
1056 2009-07-22 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #523899
1059 * generics.cs: Exact type inference with other bound types.
1061 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1063 Don't complain when the same type is implemented by the output
1064 assembly as well as multiple referenced assemblies
1065 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1066 'must_be_unique' flag.
1067 (GlobalRootNamespace): Update to changes.
1068 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1069 already have a type in hand.
1071 2009-07-22 Marek Safar <marek.safar@gmail.com>
1073 * expression.cs: More verifier instrumentation.
1075 * statement.cs: Do proper throw expression conversion.
1077 2009-07-22 Marek Safar <marek.safar@gmail.com>
1079 A fix for bug #522789
1080 * expression.cs: Mutate invocation return type.
1082 2009-07-16 Marek Safar <marek.safar@gmail.com>
1084 * anonymous.cs: Split assignable and readonly generated variable
1087 2009-07-16 Marek Safar <marek.safar@gmail.com>
1089 A fix for bug #521671
1090 * statement.cs: Fixed crash when checking missing type.
1092 2009-07-16 Marek Safar <marek.safar@gmail.com>
1094 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1095 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1096 class.cs, driver.cs: Work on dynamic binding.
1098 * dynamic.cs: New file.
1100 * *.sources, *.proj: Updated.
1102 2009-07-15 Marek Safar <marek.safar@gmail.com>
1104 * expression.cs (Conditional): Avoid double Resolve.
1106 2009-07-13 Marcus Griep <marcus@griep.us>
1108 * ecore.cs: Fix obscure bug with resolving members of interfaces
1109 that hide parent interface members. Fixes bug #444388 and corrects
1112 2009-07-13 Marek Safar <marek.safar@gmail.com>
1114 * expression.cs (LocalVariableReference): Bounce resolve.
1116 2009-07-10 Marek Safar <marek.safar@gmail.com>
1118 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1119 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1122 * support.cs: New dynamic type wrapper.
1124 2009-07-08 Marek Safar <marek.safar@gmail.com>
1126 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1127 typed local variable.
1129 2009-07-06 Marek Safar <marek.safar@gmail.com>
1131 A fix for bug #519005
1132 * anonymous.cs: Use null_type as no return type placeholder.
1134 2009-07-02 Marek Safar <marek.safar@gmail.com>
1136 * generic.cs: Handle type inference of identical type parameters
1137 with different bounds.
1139 2009-07-01 Marek Safar <marek.safar@gmail.com>
1141 * expression.cs, class.cs: Events variance.
1143 * cs-parser.jay: Interface events error messages.
1145 2009-07-01 Marek Safar <marek.safar@gmail.com>
1147 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1149 2009-06-29 Marek Safar <marek.safar@gmail.com>
1151 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1152 parameter expression can be value-type New.
1154 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1156 2009-06-26 Marek Safar <marek.safar@gmail.com>
1158 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1159 Implemented C# 4.0 named arguments.
1161 2009-06-24 Marek Safar <marek.safar@gmail.com>
1163 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1164 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1165 parameter modifier. Also fixes bug #515497.
1167 2009-06-24 Marek Safar <marek.safar@gmail.com>
1169 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1170 arguments expression to be implemented.
1172 *.sources: Add argument.cs
1174 2009-06-23 Marek Safar <marek.safar@gmail.com>
1176 * parameter.cs: Moved GetParameterIndexByName to base class.
1178 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1179 unused AType. Use argument's version of GetExpressionTree.
1181 2009-06-22 Marek Safar <marek.safar@gmail.com>
1183 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1186 2009-06-17 Marek Safar <marek.safar@gmail.com>
1188 A fix for bug #514096
1189 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1191 2009-06-17 Marek Safar <marek.safar@gmail.com>
1193 * expression.cs: The first multi-dimensional array nested array
1194 initializers was not checked.
1196 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1198 2009-06-17 Marek Safar <marek.safar@gmail.com>
1200 A fix for bug #513400
1201 * nullable.cs (EmitEquality): Operands emit could be simplified for
1202 built-in types when we now emit user operators differently.
1204 2009-06-16 Marek Safar <marek.safar@gmail.com>
1206 * ecore.cs: Report inaccessible delegate methods correctly.
1208 2009-06-16 Marek Safar <marek.safar@gmail.com>
1210 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1211 cs-parser.jay: Implemented C# 4.0 optional parameters.
1213 2009-06-16 Marek Safar <marek.safar@gmail.com>
1215 * driver.cs: Removed broken DefineManifestResource.
1217 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1219 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1220 Use $(BOOTSTRAP_PROFILE) instead.
1222 2009-06-12 Jb Evain <jbevain@novell.com>
1224 * rootcontext.cs: add a Platform field.
1225 * driver.cs: handle /platform.
1226 * codegen.cs: pass the proper flags according to
1227 the platform when saving the assembly.
1229 2009-06-11 Marek Safar <marek.safar@gmail.com>
1231 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1232 Add optional parameters grammar.
1234 2009-06-10 Marek Safar <marek.safar@gmail.com>
1236 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1237 driver.cs: Split lang version and metadata version.
1239 2009-06-10 Marek Safar <marek.safar@gmail.com>
1241 * decl.cs: Better overload ctor collision error message.
1243 2009-06-05 Jb Evain <jbevain@novell.com>
1245 * driver.cs (EmbededResource): avoid using an internal method
1246 in gmcs to embed manifest resources.
1248 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1250 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1251 the compiler from older mono versions (like moon's bots)
1253 2009-06-04 Marek Safar <marek.safar@gmail.com>
1255 * namespace.cs (LookupTypeReflection): Ignore collisions between
1258 2009-06-04 Marek Safar <marek.safar@gmail.com>
1260 * codegen.cs: Enabled generic type forwarders.
1262 2009-06-04 Marek Safar <marek.safar@gmail.com>
1264 * dmcs.*: Add another version of SRE compiler.
1266 2009-06-03 Marek Safar <marek.safar@gmail.com>
1268 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1269 generic-mcs.cs: Fixed variant type conversions.
1271 2009-06-02 Marek Safar <marek.safar@gmail.com>
1273 A fix for bug #507863
1274 * codegen.cs: Fixes a crash on invalid string value attribute.
1276 2009-06-01 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #508334
1279 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1280 cs-parser.jay: Fully import __arglist modifier.
1282 2009-05-29 Marek Safar <marek.safar@gmail.com>
1284 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1285 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1286 actually work with closed generic types.
1288 2009-05-27 Alan McGovern <amcgovern@novell.com>
1290 * class.cs, decl.cs, delegate.cs, parameter.cs:
1291 Fix the build by replacing the use of 'var' with the actual type.
1293 2009-05-27 Marek Safar <marek.safar@gmail.com>
1295 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1296 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1299 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1302 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1303 Marek Safar <marek.safar@gmail.com>
1305 A fix for bug #377509
1306 * parameter.cs: Use predefined and not empty name for implicit
1309 2009-05-21 Marek Safar <marek.safar@gmail.com>
1311 * class.cs: Don't report wrong warnings for event fields.
1313 2009-05-21 Marek Safar <marek.safar@gmail.com>
1315 A fix for bug #504667
1316 * class.cs: Check for static class using parent container instead of
1319 2009-05-08 Marek Safar <marek.safar@gmail.com>
1321 A fix for bug #496922
1322 * expression.cs: Always use temporary variable when using object
1325 2009-04-28 Marek Safar <marek.safar@gmail.com>
1327 A fix for bug #495112
1328 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1331 2009-04-27 Miguel de Icaza <miguel@novell.com>
1333 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1335 2009-04-24 Miguel de Icaza <miguel@novell.com>
1337 * complete.cs: No idea how gonzalo got a null in the list, but
1340 2009-04-24 Miguel de Icaza <miguel@novell.com>
1342 * complete.cs (CompletionElementInitializer): New completion class
1343 to support completing inside a C# 3 element initializer, so this
1344 allows completion for Silverlight situations where it is very
1347 new TextBlock () { Fo<TAB>
1349 (CompletionSimpleName): Expose the prefix that was
1350 passed to the simple name.
1352 * cs-parser.jay (object_or_collection_initializer): Add support
1353 for element_initializers.
1355 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1356 special case completion expressions as this method aggressively
1357 collects data before it operates, and errors were being thrown
1358 earlier than we were able to complete.
1360 2009-04-23 Miguel de Icaza <miguel@novell.com>
1362 * eval.cs: Make getcompletions silent and enable debugging output
1363 if the -v option is passed.
1365 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1366 Consider looking up the namespace that matches the prefix being
1369 This is part of the support for allowing completions like:
1370 `System.Co<TAB>' to complete to System.Console.
1372 * complete.cs (CompletionSimpleName.AppendResults): Make this
1375 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1377 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1378 COMPLETE_COMPLETION as internal.
1380 2009-04-17 Miguel de Icaza <miguel@novell.com>
1382 * complete.cs: Include namespace resolution in simple names as
1383 well as global types and types in the using scope in the
1386 * namespace.cs: Supporting infrastrcture to provide completions
1387 based on the current using scope.
1389 * eval.cs: Introduce an entry point that allows for initialization
1390 to return a list of the files passed on the command line.
1392 2009-04-14 Marek Safar <marek.safar@gmail.com>
1394 A fix for bug #494243
1395 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1397 2009-04-13 Marek Safar <marek.safar@gmail.com>
1399 A fix for bug #493887
1400 * statement.cs: Don't skip string multi-section with default or
1401 null label when populating string hashtable.
1403 2009-04-06 Marek Safar <marek.safar@gmail.com>
1405 A fix for bug #492329
1406 * expression.cs (New): Load variable when assigning type parameter
1409 2009-04-06 Marek Safar <marek.safar@gmail.com>
1411 A fix for bug #488960
1412 * decl.cs: Compare MVAR types using non-null values.
1414 2009-03-27 Marek Safar <marek.safar@gmail.com>
1416 * typemanager.cs, expression.cs: Removed unused nullable checks.
1418 2009-03-27 Marek Safar <marek.safar@gmail.com>
1420 * *.cs: Removed some gmcs conditionals.
1422 2009-03-26 Marek Safar <marek.safar@gmail.com>
1424 * generic.cs, support.cs: Moved generics stuff out of support.cs
1426 2009-03-24 Marek Safar <marek.safar@gmail.com>
1428 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1431 2009-03-23 Marek Safar <marek.safar@gmail.com>
1433 * attribute.cs: Consider all members for error reporting when
1434 checking named arguments.
1436 2009-03-23 Marek Safar <marek.safar@gmail.com>
1438 A fix for bug #487625
1439 * namespace.cs: Use a warning for all predefined type conflicts.
1441 2009-03-23 Marek Safar <marek.safar@gmail.com>
1443 A fix for bug #485706
1444 * statement.cs: Explicitly type catch type argument to pass verifier
1447 2009-03-22 Miguel de Icaza <miguel@novell.com>
1449 Initial support to provide code completion facilities to consumers
1450 of the evaluator API.
1452 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1453 support the completion engine. When we reach the end of the
1454 input stream instead of returning EOF, when this flag is true the
1455 tokenizer instead produces:
1457 One GENERATE_COMPLETION token: this token then must be
1458 handled in the grammar at every point where the user
1459 would likely request a completion.
1461 As many COMPLETE_COMPLETION tokens as necessary. These
1462 tokens are generated to assist the parser in unwinding and
1463 producing a valid parse tree.
1465 The parser rules do not have to be perfect, the parser needs to be
1466 augmented with judicious use of GENERATE_COMPLETION tokens to
1467 improve the areas where we can provide completion and the parser
1468 needs to add support for COMPLETE_COMPLETION tokens in productions
1471 It is common to not have enough support for COMPLETE_COMPLETION
1472 under certain rules and that even if we generated the
1473 GENERATE_COMPLETION token that the resulting tree will be invalid
1474 due to the missing rules that support COMPLETE_COMPLETION.
1476 The final EOF token is produced by having the parser notify the
1477 tokenizer when it reaches the root production that the next token
1480 * support.cs (CompletionResult): New Exception. This exception
1481 is thrown to return the completion results when one of the special
1482 completion expressions is reached.
1484 This exception is thrown by the completing ExpressionStatements
1485 classes that live in complete.cs
1487 * complete.cs (CompletingExpression): a new base class for
1488 completing expressions. This derives from the
1489 ExpressionStatement class and not from Expression as it allows
1490 completion to happen not only where expressions are expected in
1491 the grammar, but also where statements are expected.
1493 (CompletionSimpleName): A new class used to provide completions
1494 for SimpleNames. This currently only resolves to local
1495 variables from the evaluator context (GetVars call).
1497 (CompletionMemberAccess): Implements support for completing member
1500 * cs-parser.jay: Add support for completion in a few places.
1502 * eval.cs (GetCompletions): New public API for the evaluator that
1503 returns a list of possible completions given the input. The
1504 return value is an array of completions
1506 * anonymous.cs (Compatible): If the exception thrown from the
1507 resolved expression is a CompletionResult exception let that one
1508 through instead of printing a diagnostic error in the try/catch.
1510 2009-03-22 Miguel de Icaza <miguel@novell.com>
1514 * driver.cs (Main): Use Environment.Exit to quit quickly and
1515 prevent the compiler from doing the usual wait for helper thread
1518 This is to prevent a slowdown that was reported by Gonzalo on
1521 2009-03-19 Marek Safar <marek.safar@gmail.com>
1523 * ecore.cs: Load build-in types directly instead of accessing
1526 2009-03-18 Marek Safar <marek.safar@gmail.com>
1528 * ecore.cs: Always use unbox.any when available.
1530 2009-03-18 Marek Safar <marek.safar@gmail.com>
1532 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1534 2009-03-17 Marek Safar <marek.safar@gmail.com>
1536 * generic.cs: Removed obsolete version of type inference.
1538 2009-03-16 Marek Safar <marek.safar@gmail.com>
1540 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1541 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1542 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1543 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1545 2009-03-11 Marek Safar <marek.safar@gmail.com>
1547 A fix for bug #482996
1548 * anonymous.cs: Make sure we are not infering return type when
1549 checking type compatibility.
1551 2009-03-11 Marek Safar <marek.safar@gmail.com>
1553 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1554 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1555 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1556 attributes in their own structure. Needed when accessing their
1557 properties before they are resolved.
1559 2009-03-09 Marek Safar <marek.safar@gmail.com>
1561 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1562 hashtable (~10x faster).
1564 * driver.cs: Removed wrong Reset.
1566 2009-03-08 Marek Safar <marek.safar@gmail.com>
1568 * class.cs: Use correct common base type for unmanaged delayed
1571 * rootcontext.cs: Wrap unhandled exception.
1573 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1575 Make SeekableStreamReader self-tuning and arbitrarily seekable
1576 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1578 (SeekableStreamReader.Position.set): Use it. Simplify logic
1579 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1580 buffer size when the stream needs to be re-read from the beginning.
1582 2009-03-05 Marek Safar <marek.safar@gmail.com>
1584 A fix for bug #480100
1585 * parameter.cs: A parameter is not hoisted when used directly as ET.
1587 2009-03-04 Marek Safar <marek.safar@gmail.com>
1589 * statement.cs: Fixed an issue when using variable is of interface
1592 2009-03-03 Marek Safar <marek.safar@gmail.com>
1594 A fix for bug #480319
1595 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1597 2009-03-03 Marek Safar <marek.safar@gmail.com>
1599 A fix for bug #480867
1600 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1601 expression to have no valid type.
1603 2009-03-03 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #481258
1606 * class.cs: Set extension method flag in partial container.
1608 2009-03-03 Marek Safar <marek.safar@gmail.com>
1610 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1612 * attribute.cs: Add sanity check.
1614 2009-02-27 Marek Safar <marek.safar@gmail.com>
1616 * class.cs: Add external constructor error.
1618 2009-02-26 Marek Safar <marek.safar@gmail.com>
1620 A fix for bug #475354
1621 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1622 correctly user defined nullable equality operators.
1624 2009-02-25 Marek Safar <marek.safar@gmail.com>
1626 A fix for bug #479532
1627 * expression.cs: Implement NewInitialize::AddressOf.
1629 2009-02-25 Marek Safar <marek.safar@gmail.com>
1631 A fix for bug #413633
1632 * expression.cs: Iterate all base class-constraint types.
1634 2009-02-24 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #479209
1637 * literal.cs: Mutate null underlying type.
1639 2009-02-24 Marek Safar <marek.safar@gmail.com>
1641 A fix for bug #476295
1642 * convert.cs: Avoid wrapping implicitly convertible reference type.
1644 2009-02-23 Marek Safar <marek.safar@gmail.com>
1646 * iterators.cs: Create MemberName correctly.
1648 2009-02-23 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #478655
1651 * literal.cs: Check also underlying null type conversion.
1653 2009-02-21 Marek Safar <marek.safar@gmail.com>
1655 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1657 2009-02-20 Marek Safar <marek.safar@gmail.com>
1659 A fix for bug #477447
1660 * statement.cs: Add reference to correct parent storey when this
1661 is accessible from deep children storey (more than 1 level).
1663 2009-02-19 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1666 * class.cs: Define base type members before setting up member cache.
1668 2009-02-18 Marek Safar <marek.safar@gmail.com>
1670 A fix for bug #477378
1671 * nullable.cs, expression.cs, statement.cs: More precise null type
1674 2009-02-18 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #472805
1677 * typemanager.cs, namespace.cs: Import only visible extension method
1680 2009-02-18 Marek Safar <marek.safar@gmail.com>
1682 A fix for bug #476895
1683 * attribute.cs: Use correct resolve context for attribute type.
1685 2009-02-18 Marek Safar <marek.safar@gmail.com>
1687 A fix for bug #476266
1688 * anonymous.cs: Mutate multi-dimensional arrays.
1690 2009-02-18 Marek Safar <marek.safar@gmail.com>
1692 A fix for bug #476400
1693 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1695 2009-02-18 Marek Safar <marek.safar@gmail.com>
1697 A fix for bug #476811
1698 * generics.cs: Fixed null-literal check.
1700 2009-02-17 Marek Safar <marek.safar@gmail.com>
1702 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1703 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1704 messing with static variables.
1706 2009-02-16 Marek Safar <marek.safar@gmail.com>
1708 A fix for bug #475965
1709 * generics.cs: Check generic parameter type after extracting from
1712 2009-02-16 Marek Safar <marek.safar@gmail.com>
1714 A fix for bug #475823
1715 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1718 2009-02-14 Marek Safar <marek.safar@gmail.com>
1720 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1721 Simplified event field definition using backing field and not
1722 field builder directly.
1724 * expression.cs (EmitLdArg): Optimize fast paths.
1726 2009-02-13 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #475327
1729 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1731 2009-02-13 Marek Safar <marek.safar@gmail.com>
1733 A fix for bug #475342
1734 * cs-parser.jay: Using 'super' instead of 'base' to call base
1735 constructor crashes compiler.
1737 2009-02-13 Marek Safar <marek.safar@gmail.com>
1739 A fix for bug #475354
1740 * expression.cs (Constantify): Add nullable types.
1742 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1744 2009-02-12 Marek Safar <marek.safar@gmail.com>
1746 A fix for bug #475246
1747 * expression.cs: More broken flowanalysis hacking needed.
1749 2009-02-12 Marek Safar <marek.safar@gmail.com>
1751 * attribute.cs: Compare only ref/out array modifiers.
1753 2009-02-11 Marek Safar <marek.safar@gmail.com>
1755 * statement.cs: Use member cache when looking for foreach members.
1757 2009-02-11 Marek Safar <marek.safar@gmail.com>
1759 * expression.cs: Don't expose internal initializer types.
1761 * statement.cs: Check also explicit conversions for goto case.
1763 2009-02-11 Marek Safar <marek.safar@gmail.com>
1765 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1767 2009-02-10 Marek Safar <marek.safar@gmail.com>
1769 * *.cs: Replace null-type with NullLiteral where appropriate.
1771 2009-02-09 Marek Safar <marek.safar@gmail.com>
1773 * expression.cs: Initializer of reference argument use temporary
1774 variable to be verifiable.
1776 * parameter.cs: Share EmitLdArg.
1778 2009-02-09 Marek Safar <marek.safar@gmail.com>
1780 A fix for bug #473559
1781 * class.cs: Fixed: Not reporting error about nested class with the
1784 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1786 Contributed under the MIT/X11 license.
1788 * generic.cs: Added VerifyVariantTypeParameters which performs new
1789 variance verification logic. The old logic, based on the spec, was
1790 wrong because the spec is full of LIES!
1792 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1794 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1797 * ecore.cs: Added calls to the new variance verification logic.
1800 * delegate.cs: Removed calls to the old variance verification logic.
1802 2009-02-06 Marek Safar <marek.safar@gmail.com>
1804 * delegate.cs: Use cached Invoke method directly.
1806 2009-02-06 Marek Safar <marek.safar@gmail.com>
1808 * expression.cs: Emit expression tree for hoisted variable access.
1810 2009-02-04 Marek Safar <marek.safar@gmail.com>
1812 * namespace.cs: Add better extension class check.
1814 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1816 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1818 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1820 This patch adds initial generic variance support to the compiler.
1821 It is contributed under the MIT/X11 license.
1823 * typemanager.cs: Modified ImplementsInterface to check variance.
1824 Added VerifyVariantTypeParameters which checks the specified type to see
1825 if it uses a variant type parameter as a type argument (which is not
1826 allowed). Added IsVariantOf which determins if the first type is a
1827 variant of the second. NOTE: This only supports reference types at
1828 the moment to conform with the current level of VM support. When the
1829 VM supports value types, this will follow step.
1831 * generic.cs: Added the Variance enum. Added a Variance property to
1832 TypeParameter and added variance support to definition phase. Added a
1833 Variance property to TypeParameterName. Also check to make sure that
1834 no variant types appear in generic method parameters.
1836 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1837 keywords if the langversion supports it.
1839 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1840 that variant types are only used in legal positions. Also added
1841 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1844 * decl.cs: Construct TypeParameter with the variance information.
1846 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1847 and ImplicitConversionStandard.
1849 * rootcontext.cs: Added new "Future" language version.
1851 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1852 type parameters are not used as type arguments in interface inheritance.
1853 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1854 parameters are not used as method return types. In MemberBase.
1855 ResolveMemberType, ensure that variant type parameters are not used
1856 as type arguments. Also call VerifyNoVariantTypeParameters on every
1857 set of parameters which are resolved.
1859 * delegate.cs: Modified Delegate.Define to ensure that variant
1860 parameters are not used as type arguments and that a contravariant
1861 parameter is not used as the return type. Also call
1862 VerifyNoVariantTypeParameters on the delegate parameters.
1864 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1865 to specify generic variance.
1867 * driver.cs: Added support for LanguageVersion.Future in the form of
1868 "-langversion:future".
1870 * generic-mcs.cs: Stubbed out new members in generic.cs.
1872 2009-02-03 Marek Safar <marek.safar@gmail.com>
1874 * class.cs, generic.cs: Emit type parameter constraints for nested
1877 2009-02-02 Marek Safar <marek.safar@gmail.com>
1879 A fix for bug #471213
1880 * class.cs: Avoid emitting backing field for abstract event fields.
1882 2009-02-01 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #359731
1885 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1888 2009-01-30 Marek Safar <marek.safar@gmail.com>
1890 A fix for bug #470767
1891 * statement.cs: Introduced BlockScopeExpression, needed when
1892 expression tree conversion has to emit scope variables.
1894 2009-01-29 Marek Safar <marek.safar@gmail.com>
1896 * class.cs: Remove duplicate CallingConvention.
1898 2009-01-29 Marek Safar <marek.safar@gmail.com>
1900 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1901 when I finally found the right naming convention.
1903 2009-01-29 Marek Safar <marek.safar@gmail.com>
1905 * cs-tokenizer.cs: Put back different open parens optimization.
1907 2009-01-28 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #470227
1910 * cs-tokenizer.cs: Remove too agressive parser optimization.
1912 2009-01-28 Marek Safar <marek.safar@gmail.com>
1914 A fix for bug #324319
1915 * class.cs: Remove too early base type resolve.
1917 2009-01-27 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #324319
1920 * ecore.cs: Explicitly type null when assigning to type argument to
1921 make pass verifier check.
1923 2009-01-27 Marek Safar <marek.safar@gmail.com>
1925 * anonymous.cs: Fixed recent regression when initializing captured
1928 2009-01-26 Marek Safar <marek.safar@gmail.com>
1930 A fix for bug #469019
1931 * anonymous.cs: Use all parent type parameters when instantiating
1932 nested generic storey.
1934 2009-01-26 Marek Safar <marek.safar@gmail.com>
1936 * expression.cs: Check for null instance methodgroup expression.
1938 2009-01-26 Marek Safar <marek.safar@gmail.com>
1940 A fix for bug #469244
1941 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1942 instance inside a conditional expression.
1944 2009-01-23 Marek Safar <marek.safar@gmail.com>
1946 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1947 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1948 GetElementType and HasElementType. IsValueType clean up.
1950 2009-01-23 Marek Safar <marek.safar@gmail.com>
1952 * nullable.cs: Use common EmitCall.
1954 * expression.cs: Emit constraint. for virtual calls only.
1956 2009-01-23 Marek Safar <marek.safar@gmail.com>
1958 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1959 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1960 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1963 2009-01-22 Jb Evain <jbevain@novell.com>
1965 * anonymous.cs: make anonymous types' ToString implementation
1966 match what csc outputs.
1968 2009-01-21 Marek Safar <marek.safar@gmail.com>
1970 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1973 2009-01-17 Marek Safar <marek.safar@gmail.com>
1975 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1978 2009-01-16 Marek Safar <marek.safar@gmail.com>
1980 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1983 2009-01-15 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #466634
1986 * statement.cs: Add reference for nested storey when only this
1989 2009-01-15 Marek Safar <marek.safar@gmail.com>
1991 A fix for bug #466474
1992 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1995 2009-01-15 Marek Safar <marek.safar@gmail.com>
1997 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1998 Fixed nested stories parent referencing process. Also fixes #463985.
2000 2009-01-06 Marek Safar <marek.safar@gmail.com>
2002 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2003 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2004 implementation. Also fixes #463108.
2006 2009-01-05 Marek Safar <marek.safar@gmail.com>
2008 A fix for bug #416109
2009 * decl.cs: Issue correct CLSAttribute warning location.
2011 2009-01-05 Marek Safar <marek.safar@gmail.com>
2013 A fix for bug #456775
2014 * attribute.cs: Use attribute owner scope when resolving attribute
2017 2009-01-05 Marek Safar <marek.safar@gmail.com>
2019 A fix for bug #457257
2020 * decl.cs: Fixed incorrect member declaring type comparison.
2022 2009-01-05 Marek Safar <marek.safar@gmail.com>
2024 A fix for bug #460896
2025 * driver.cs: Handle /RES resources as embeddable.
2027 2009-01-05 Marek Safar <marek.safar@gmail.com>
2029 A fix for bug #462515
2030 * ecore.cs: Report inacessible members upwards.
2032 2009-01-05 Marek Safar <marek.safar@gmail.com>
2034 A fix for bug #463190, #463192
2035 * decl.cs, namespace.cs: Also import internal extension classes.
2037 2009-01-04 Marek Safar <marek.safar@gmail.com>
2039 A fix for bug #463415
2040 * generic.cs: Use right index for RemoveDependentTypes.
2042 2009-01-02 Marek Safar <marek.safar@gmail.com>
2044 A fix for bug #463196
2045 * expression.cs: Fixed enum to null comparison.
2047 2009-01-02 Marek Safar <marek.safar@gmail.com>
2049 A fix for bug #463121
2050 * nullable.cs: Fixed nullable user equality operator comparison.
2052 2009-01-02 Marek Safar <marek.safar@gmail.com>
2054 A fix for bug #462950
2055 * class.cs, decl.cs: Use full explicit name when defining automatic
2056 property backing field.
2058 2009-01-02 Marek Safar <marek.safar@gmail.com>
2060 A fix for bug #462592
2061 * pending.cs: Emit type arguments for generic proxy method.
2063 2008-12-30 Marek Safar <marek.safar@gmail.com>
2065 * expression.cs (As): Mutate all type arguments.
2067 2008-12-29 Marek Safar <marek.safar@gmail.com>
2069 A fix for bug #462622
2070 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2073 2008-12-29 Marek Safar <marek.safar@gmail.com>
2075 A fix for bug #450782
2076 * ecore.cs: Consider more variables of form V.I to be fixed.
2078 2008-12-29 Marek Safar <marek.safar@gmail.com>
2080 A fix for bug #460712
2081 * typemanager.cs: Core types could be imported.
2083 2008-12-28 Marek Safar <marek.safar@gmail.com>
2085 A fix for bugs #460847, #460772, #458049, #457339, #447807
2086 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2087 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2088 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2089 user lambdas used inside query clauses.
2091 2008-12-18 Marek Safar <marek.safar@gmail.com>
2093 A fix for bug #460229
2094 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2096 2008-12-18 Marek Safar <marek.safar@gmail.com>
2098 A fix for bug #459952
2099 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2101 2008-12-18 Marek Safar <marek.safar@gmail.com>
2103 A fix for bug #459630
2104 * convert.cs: Enum to valuetype conversion is not allowed.
2106 2008-12-18 Marek Safar <marek.safar@gmail.com>
2108 A fix for bug #457087
2109 * generic.cs: Don't crash when constraint comes from type
2112 2008-12-16 Marek Safar <marek.safar@gmail.com>
2114 A fix for bug #459221
2115 * anonymous.cs, statement.cs: Delay only captured this
2118 2008-12-12 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #457489
2121 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2122 and initialization to capture scope initializers correctly.
2124 2008-12-11 Marek Safar <marek.safar@gmail.com>
2126 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2127 ParameterReference refactoring.
2129 2008-12-03 Marek Safar <marek.safar@gmail.com>
2131 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2132 to be imported from any assembly.
2134 2008-12-03 Marek Safar <marek.safar@gmail.com>
2136 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2137 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2138 from anonymous method and lambda expression.
2140 2008-12-01 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #448560
2143 * expression.cs (As): Box any generic type arguments to be
2146 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2148 Add tripwire for implicit conversion bugs
2149 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2151 (MethodGroupExpr.OverloadResolve): Add sanity check between
2152 IsApplicable and VerifyArgumentsCompat.
2153 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2155 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2157 Fix build break in System.Data_test
2158 * convert.cs (ImplicitConversionExists): Move NullLiteral
2160 (ImplicitStandardConversionExists): ... here.
2162 2008-11-28 Marek Safar <marek.safar@gmail.com>
2164 * literal.cs: Emit correctly explicit null to nullable cast.
2166 2008-11-28 Marek Safar <marek.safar@gmail.com>
2168 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2171 2008-11-28 Marek Safar <marek.safar@gmail.com>
2173 A fix for bug #449005
2174 * convert.cs, nullable.cs: Use only one implicit nullable
2177 2008-11-27 Marek Safar <marek.safar@gmail.com>
2179 * convert.cs, literal.cs: More Convert cleanup is needed.
2181 2008-11-27 Marek Safar <marek.safar@gmail.com>
2183 * decl.cs, class.cs: Fixed misleading error message.
2185 2008-11-26 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #449005
2188 * nullable.cs (EmitEquality): Disable optimization for user operator
2191 2008-11-25 Marek Safar <marek.safar@gmail.com>
2193 A fix for bug #447027
2194 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2195 with context variables stored as expression instances.
2197 2008-11-25 Marek Safar <marek.safar@gmail.com>
2199 A fix for bug #447027
2200 * delegate.cs: Fixed delegate VerifyMethod logic.
2202 2008-11-24 Marek Safar <marek.safar@gmail.com>
2204 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2207 2008-11-21 Marek Safar <marek.safar@gmail.com>
2209 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2210 member type resolve to follow normal flow, instead of random
2213 2008-11-21 Marek Safar <marek.safar@gmail.com>
2215 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2218 2008-11-21 Marek Safar <marek.safar@gmail.com>
2220 * const.cs: Emit decimal array constant as literal.
2222 2008-11-20 Marek Safar <marek.safar@gmail.com>
2224 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2226 2008-11-19 Marek Safar <marek.safar@gmail.com>
2228 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2229 into real property (saves 8 MB for corlib compilation).
2231 2008-11-19 Marek Safar <marek.safar@gmail.com>
2233 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2234 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2235 generic-mcs.cs: Small cleanup of TypeArguments.
2237 2008-11-18 Marek Safar <marek.safar@gmail.com>
2239 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2240 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2241 of ConstructedType expression, renamed to GenericTypeExpr.
2243 2008-11-17 Marek Safar <marek.safar@gmail.com>
2245 A fix for bug #445303
2246 * location.cs (IsConditionalDefined): Handle undefined global
2249 2008-11-17 Marek Safar <marek.safar@gmail.com>
2251 A fix for bug #444678
2252 * expression.cs (TryReduceConstant): Always create new constant
2255 2008-11-17 Marek Safar <marek.safar@gmail.com>
2257 A fix for bug #444673
2258 * ecore.cs: Ignore open generic types when used as generic type
2261 2008-11-17 Marek Safar <marek.safar@gmail.com>
2263 A fix for bug #445458
2264 * expression.cs, cs-parser.jay: Don't crash when an expression
2267 2008-11-17 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #445464
2270 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2271 inside unbound type.
2273 2008-11-14 Jb Evain <jbevain@novell.com>
2275 * driver.cs: ignore empty -nowarn argument such as
2276 the one in -nowarn:12,13,,.
2278 2008-11-13 Marek Safar <marek.safar@gmail.com>
2280 A fix for bug #444271
2281 * anonymous.cs: Rescan parent storeys when best candidate was
2284 2008-11-13 Marek Safar <marek.safar@gmail.com>
2286 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2287 useless UnboundTypeExpression.
2289 * attribute.cs: Do check obsolete attribute on generic types.
2291 2008-11-12 Marek Safar <marek.safar@gmail.com>
2293 A fix for bugs #425680, #400139
2294 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2297 2008-11-11 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #435747
2300 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2301 compound value types assignment. Few micro optimizations added.
2303 2008-11-10 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #442610
2306 * anonymous.cs (MutateConstructor): More SRE hacking.
2308 2008-11-10 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #442579
2311 * ecore.cs: Also initialize expanded form of a method with 1 params
2314 2008-11-06 Marek Safar <marek.safar@gmail.com>
2316 * expression.cs (UnaryMutator): Do early l-side check.
2318 2008-11-05 Miguel de Icaza <miguel@novell.com>
2320 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2321 Init, otherwise we would crash later on when checking for friend
2324 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2325 Otherwise we never get any meaningful information as to what
2328 2008-11-05 Marek Safar <marek.safar@gmail.com>
2330 A fix for bug #436318
2331 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2333 2008-11-05 Miguel de Icaza <miguel@novell.com>
2335 * namespace.cs: Turns out that it was a really bad idea to hide
2336 the errors for namespaces not found here in eval mode.
2338 * eval.cs: When we process using clauses, only enter those into
2339 the list of valid using clauses after they have been validated.
2341 The above change gives the proper semantics: it does not
2342 senselessly report the same errors with broken using statements by
2343 never storing them in the first place when they are invalid.
2345 2008-11-05 Marek Safar <marek.safar@gmail.com>
2347 A fix for bug #421839
2348 * cs-parser.jay: Remove expression from coalesce rule to force lower
2349 priority than the assignment operator.
2351 2008-11-05 Marek Safar <marek.safar@gmail.com>
2353 A fix for bug #437875
2354 * nullable.cs: Compile correctly method group operand used with null
2355 coalescing operator.
2357 2008-11-04 Marek Safar <marek.safar@gmail.com>
2359 A fix for bug #434589
2360 * expression.cs (Binary): Ignore lifted conversions when at least
2361 one operand is of reference type.
2363 2008-11-04 Marek Safar <marek.safar@gmail.com>
2365 * cs-parser.jay: Better syntax error report.
2367 2008-11-03 Marek Safar <marek.safar@gmail.com>
2369 A fix for bug #436792
2370 * cs-parser.jay: Use GetLocation to access location.
2372 2008-11-03 Marek Safar <marek.safar@gmail.com>
2374 A fix for bug #440774
2375 * cs-parser.jay: Also set current_array_type when parsing local
2378 2008-11-03 Marek Safar <marek.safar@gmail.com>
2380 A fix for bug #440785
2381 * expression.cs (As): Don't resolve self modifing expression
2384 2008-11-03 Marek Safar <marek.safar@gmail.com>
2386 A fix for bug #439447
2387 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2389 2008-11-03 Marek Safar <marek.safar@gmail.com>
2391 A fix for bug #437571
2392 * cs-parser.jay: Fixes internal error for invalid expression
2395 2008-10-17 Marek Safar <marek.safar@gmail.com>
2397 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2399 2008-10-17 Marek Safar <marek.safar@gmail.com>
2401 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2403 2008-10-17 Marek Safar <marek.safar@gmail.com>
2405 * cs-tokenizer.cs: More precise cast parsing.
2407 2008-10-16 Martin Baulig <martin@ximian.com>
2409 * anonymous.cs (AnonymousMethodStorey): Put back the
2410 `hoisted_locals' hashtable and use it in EmitType().
2412 2008-10-15 Marek Safar <marek.safar@gmail.com>
2414 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2415 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2418 2008-10-14 Marek Safar <marek.safar@gmail.com>
2420 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2422 2008-10-14 Marek Safar <marek.safar@gmail.com>
2424 * statement.cs: Mutate scope initializers.
2426 2008-10-14 Marek Safar <marek.safar@gmail.com>
2428 * expression.cs: Use typeless value for This constant.
2430 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2432 2008-10-14 Marek Safar <marek.safar@gmail.com>
2434 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2437 2008-10-13 Marek Safar <marek.safar@gmail.com>
2439 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2442 2008-10-13 Marek Safar <marek.safar@gmail.com>
2444 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2445 parser and tokenizer. Fixes many ambiguities including #433258.
2447 2008-10-10 Marek Safar <marek.safar@gmail.com>
2449 * cs-parser.jay: Fixed missing accessor recovery.
2451 2008-10-10 Marek Safar <marek.safar@gmail.com>
2453 A fix for bug #433701
2454 * expression.cs: Better error message.
2456 2008-10-10 Marek Safar <marek.safar@gmail.com>
2458 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2460 * Makefile: Disabled unused debug symbols.
2462 Also fixes: #320556, #321097, #321656, #321876, #351316
2464 2008-10-09 Miguel de Icaza <miguel@novell.com>
2466 * eval.cs: rename "<interactive>" to "{interactive}", to work
2467 around a requirement in the compiler that this be a valid
2468 filename, and in Windows it is not (433886).
2470 2008-10-09 Marek Safar <marek.safar@gmail.com>
2472 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2474 2008-10-08 Marek Safar <marek.safar@gmail.com>
2476 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2477 cs-parser.jay: Generic type declaration and type arguments cleanup.
2479 2008-10-05 Marek Safar <marek.safar@gmail.com>
2481 * cs-parser.jay: Allow parsing weird array creation construct.
2483 2008-10-05 Marek Safar <marek.safar@gmail.com>
2485 * cs-parser.jay: Conflicts reduction.
2487 2008-10-04 Marek Safar <marek.safar@gmail.com>
2489 * cs-parser.jay: Conflicts reduction.
2491 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2494 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2495 property. Add a 'count' hint about the use of the shared vector.
2496 Ensure that we don't leak out dirty bits.
2497 (UsageVector.MergeChild): Throw away information about variables
2499 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2501 2008-10-03 Marek Safar <marek.safar@gmail.com>
2503 A fix for bug #431746
2504 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2505 parameters when iterator is created.
2507 2008-10-03 Marek Safar <marek.safar@gmail.com>
2509 A fix for bug #431827
2510 * expression.cs: Fixed right based pointer arithmetic operations
2513 2008-10-03 Marek Safar <marek.safar@gmail.com>
2515 A fix for bug #353779
2516 * assign.cs, expression.cs: Fixed compound assignment conversions.
2518 2008-10-02 Marek Safar <marek.safar@gmail.com>
2520 A fix for bug #375262
2521 * statement.cs: Refactor ArrayForeach to be usable with string
2522 indexer. Optimized single dimentional arrays foreach.
2524 2008-10-02 Marek Safar <marek.safar@gmail.com>
2526 A fix for bug #431255
2527 * anonymous.cs, expression.cs: Removed broken optimization.
2529 2008-10-01 Marek Safar <marek.safar@gmail.com>
2531 * anonymous.cs: Use full type parameters of parent generic
2532 containers. Removed unnecessary AddParentStoreyReference call.
2534 2008-10-01 Marek Safar <marek.safar@gmail.com>
2536 A fix for bug #324702
2537 * class.cs: Use better shorter names for explicit interface member
2540 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2542 2008-10-01 Marek Safar <marek.safar@gmail.com>
2544 * expression.cs: Use new interface to check fixed expression.
2546 2008-10-01 Marek Safar <marek.safar@gmail.com>
2548 A fix for bug #421101
2549 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2550 interface to check for fixed fixed-buffers.
2552 2008-10-01 Marek Safar <marek.safar@gmail.com>
2554 A fix for bug #429264
2555 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2557 * delegate.cs: Removed unnecessary casts.
2559 2008-09-30 Marek Safar <marek.safar@gmail.com>
2561 A fix for bug #352151
2562 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2563 class.cs: Fixed already defined explicit interface members check.
2565 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2567 cs-tokenizer.cs: Fix typo.
2569 2008-09-28 Miguel de Icaza <miguel@novell.com>
2571 * eval.cs (InteractiveBase): The quit command now just sets a
2572 flag, instead of calling Environment.Exit(), it is milder on
2575 CompiledMethod is now in Mono.CSharp, not nested inside
2576 the Evaluator, it was inconvenient to use.
2578 2008-09-27 Miguel de Icaza <miguel@novell.com>
2580 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2581 code to be invoked without having to reparse.
2583 2008-09-27 Miguel de Icaza <miguel@novell.com>
2585 * ecore.cs: The recent changes to FieldExpr broke this as well.
2586 Fixes LINQ queries in the interactive shell.
2588 * Multiple files: indentation fixing for the Mono coding
2589 guidelines for the switch statement.
2591 * eval.cs: Make the Evaluator API thread safe.
2593 2008-09-26 Marek Safar <marek.safar@gmail.com>
2595 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2596 constructor parsing.
2598 2008-09-26 Marek Safar <marek.safar@gmail.com>
2600 A fix for bug #325326
2601 * statement.cs: Check possible mistaken empty statement using
2602 explicit blocks only.
2604 2008-09-25 Miguel de Icaza <miguel@novell.com>
2606 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2607 RootNamespace.ComputeNamespaces to update the internal list of
2608 namespaces, this is no longer done for us.
2610 (InteractiveBase): Use the Evaluator APIs instead of calling into
2613 2008-09-25 Marek Safar <marek.safar@gmail.com>
2615 A fix for bug #429264
2616 * expression.cs: Missing mutator for access to multidimensional
2619 2008-09-25 Marek Safar <marek.safar@gmail.com>
2621 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2624 * driver.cs: Missing input argument check.
2626 2008-09-25 Marek Safar <marek.safar@gmail.com>
2628 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2629 expression.cs, statement.cs, rootcontext.cs, class.cs,
2630 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2633 2008-09-24 Miguel de Icaza <miguel@novell.com>
2635 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2636 fully constructed FieldExpr, fixes the regression introduced in
2639 * ecore.cs, expression.cs: Plug back the eclass initialization as
2640 otherwise it regresses `csharp'.
2642 2008-09-24 Marek Safar <marek.safar@gmail.com>
2644 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2645 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2646 phase to resolve phase. It resolves problems with expression trees
2647 and fixes bugs #323796, #325156.
2649 2008-09-23 Marek Safar <marek.safar@gmail.com>
2651 * codegen.cs: Report better error when symbol writer is missing.
2653 2008-09-23 Marek Safar <marek.safar@gmail.com>
2655 * codegen.cs: Set .NET symbol writer.
2657 * decl.cs: Guard against null generic arguments.
2659 * report.cs: Don't report exactly same additional details.
2661 2008-09-22 Marek Safar <marek.safar@gmail.com>
2663 A fix for bug #324917
2664 * cs-parser.jay: Add missing multidimensional non-expression type
2667 2008-09-22 Marek Safar <marek.safar@gmail.com>
2669 A fix for bug #428191
2670 * anonymous.cs: Create an outer generic fields also for non-storey
2673 2008-09-22 Marek Safar <marek.safar@gmail.com>
2675 A fix for bug #378294
2676 * class.cs: Make fixed size buffers gmcs feature only.
2678 2008-09-22 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #355622, #324993
2681 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2684 2008-09-19 Marek Safar <marek.safar@gmail.com>
2686 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2689 2008-09-19 Marek Safar <marek.safar@gmail.com>
2691 A fix for bug #416110
2692 * generic.cs: Struct constraint results in default ctor and
2693 ValueType base type constraint to be set.
2695 2008-09-19 Marek Safar <marek.safar@gmail.com>
2697 A fix for bug #423791
2698 * generic.cs: Fixed params output type type-inference.
2700 2008-09-19 Marek Safar <marek.safar@gmail.com>
2702 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2704 2008-09-19 Marek Safar <marek.safar@gmail.com>
2706 * cs-tokenizer.cs: Don't break on extra partial modifier.
2708 2008-09-19 Marek Safar <marek.safar@gmail.com>
2710 A fix for bug #427592
2711 * generic.cs: Use common parameter resolve method.
2713 2008-09-18 Marek Safar <marek.safar@gmail.com>
2715 A fix for bug #414758
2716 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2719 2008-09-18 Marek Safar <marek.safar@gmail.com>
2721 * driver.cs, namespace.cs: Read types and namespaces after all
2722 requested assemblies are loaded, fixes issues with System.Core
2723 auto-reference, and #419888.
2725 2008-09-18 Marek Safar <marek.safar@gmail.com>
2727 A fix for bug #417705
2728 * cs-parser.jay: Fixed as/is operator expression split.
2730 2008-09-18 Marek Safar <marek.safar@gmail.com>
2732 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2733 Fixed expression tree representation of empty new expression and
2734 new initializer expression.
2736 2008-09-18 Miguel de Icaza <miguel@novell.com>
2738 * eval.cs: Remove warning, keep reference to driver around.
2740 * Hide fields that do not need to be public.
2742 2008-09-17 Marek Safar <marek.safar@gmail.com>
2744 A fix for bug #426385
2745 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2746 conversion for array elements.
2748 2008-09-17 Marek Safar <marek.safar@gmail.com>
2750 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2751 void parsing conflicts.
2753 2008-09-15 Marek Safar <marek.safar@gmail.com>
2755 A fix for bug #425601
2756 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2757 System.Core only when there is no custom ExtensionAttribute
2760 2008-09-15 Miguel de Icaza <miguel@novell.com>
2762 * namespace.cs: Do not report CS0246 (name
2764 2008-09-12 Marek Safar <marek.safar@gmail.com>
2766 A fix for bug #425669
2767 * generic.cs: Don't cache generic static anonymous method
2770 2008-09-12 Marek Safar <marek.safar@gmail.com>
2772 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2773 conflicting constraints.
2775 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2777 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2780 2008-09-12 Marek Safar <marek.safar@gmail.com>
2782 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2783 to null pointer conversion fixes.
2785 2008-09-11 Marek Safar <marek.safar@gmail.com>
2787 * cs-parser.jay, expression.cs: An implicitly typed local variable
2788 declarator cannot use an array initializer.
2790 2008-09-11 Marek Safar <marek.safar@gmail.com>
2792 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2794 2008-09-11 Marek Safar <marek.safar@gmail.com>
2796 * generic.cs (InflatedConstraints): Don't crash when constraints
2799 * cs-parser.jay: const_declarator is a block.
2801 * constant.cs: Check for not allowed NaN conversions.
2803 2008-09-10 Miguel de Icaza <miguel@novell.com>
2805 * driver.cs: Drop --shell argument, the compiler is no longer a
2808 * eval.cs: Move most of the code that deals with evaluation into
2809 this file and document the public API from repl.cs
2811 * repl.cs: Remove from here.
2813 2008-09-10 Marek Safar <marek.safar@gmail.com>
2815 A fix for bug #424684
2816 * generic.cs: Generic class constraints must come first.
2818 2008-09-09 Miguel de Icaza <miguel@novell.com>
2820 * cs-parser.jay: Improve error reporting for syntax errors in
2821 statements and expressions, we now report the expected tokens
2822 instead of reporting the useless "; expected".
2824 Drop the strings from the token declaration, it turns out that
2825 they did not do what I thought they did. Instead they were adding
2826 two sets of tokens to the tables.
2828 2008-09-09 Marek Safar <marek.safar@gmail.com>
2830 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2831 delegate.cs: Share special type check.
2833 2008-09-09 Marek Safar <marek.safar@gmail.com>
2835 A fix for bug #423981
2836 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2838 2008-09-09 Marek Safar <marek.safar@gmail.com>
2840 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2843 2008-09-09 Marek Safar <marek.safar@gmail.com>
2845 A fix for bugs: #324750, #335946
2846 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2847 lookup rule to determine ?-based tokens.
2849 2008-09-08 Miguel de Icaza <miguel@novell.com>
2851 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2852 expressions (like event adding or removing) end up here, so we
2853 need to treat those as statements.
2855 Add LoadAssembly method.
2857 2008-09-04 Miguel de Icaza <miguel@novell.com>
2859 * repl.cs: Add Time method.
2861 2008-09-05 Marek Safar <marek.safar@gmail.com>
2863 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2865 2008-09-05 Miguel de Icaza <miguel@novell.com>
2867 * repl.cs: Add workaround for old compilers.
2869 2008-09-04 Jb Evain <jbevain@novell.com>
2871 * repl.cs (PrettyPrint): pretty print everything that
2872 implements IDictionary, as well as IEnumerables. Also,
2873 add a quit helper property.
2875 2008-09-04 Marek Safar <marek.safar@gmail.com>
2877 * constant.cs: Better error reporting for decimal literals.
2879 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2882 2008-09-04 Marek Safar <marek.safar@gmail.com>
2883 Miguel de Icaza <miguel@novell.com>
2885 A fix for bug #422951
2886 * assign.cs (Assign.DoResolve): Perform the type conversions
2887 checks before we attempt to initialize `New' initializers.
2889 2008-09-04 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #422853
2892 * delegate.cs (DelegateCreation): Add special handling for
2893 EmptyExpression.Null instance expression which is just another
2894 hack for undecided member instance exression.
2896 2008-09-04 Marek Safar <marek.safar@gmail.com>
2898 * expression.cs, ecore.cs: Emit full expression tree for reduced
2901 2008-09-04 Marek Safar <marek.safar@gmail.com>
2903 * expression.cs (This): Guard against multi-resolving.
2905 * ecore.cs, statement.cs (Throw): Simplified.
2907 * flowanalysis.cs: Also verify event fields.
2909 2008-09-04 Miguel de Icaza <miguel@novell.com>
2911 * assign.cs (Assign.DoResolve): Perform the type conversions
2912 checks before we attempt to initialize `New' initializers.
2914 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2916 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2919 * repl.cs: Update help.
2921 2008-09-03 Miguel de Icaza <miguel@novell.com>
2923 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2924 handling of the default config handling, including the special
2925 treatment of System.Core assembly.
2927 Fixes the REPL processing for LINQ.
2929 2008-09-03 Marek Safar <marek.safar@gmail.com>
2931 A fix for bug #422507
2932 * expression.cs (UnboxCast): Add missing child expression mutator.
2934 2008-09-03 Marek Safar <marek.safar@gmail.com>
2936 * driver.cs: Don't self reference System.Core assembly.
2938 2008-09-03 Marek Safar <marek.safar@gmail.com>
2940 A fix for bug #422507
2941 * expression.cs (StringConcat): Add missing type mutator.
2943 2008-09-03 Marek Safar <marek.safar@gmail.com>
2945 * generic.cs (TypeInferenceContext): Follow equality rule for
2946 constructed type lower bound type inference.
2948 2008-09-02 Miguel de Icaza <miguel@novell.com>
2950 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2951 <dblank@cs.brynmawr.edu> which updates the cursor position on
2954 2008-09-02 Marek Safar <marek.safar@gmail.com>
2956 A fix for bug #367145
2957 * driver.cs: Fixed import of extension methods when using -noconfig
2960 2008-09-02 Marek Safar <marek.safar@gmail.com>
2962 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2963 version from non-generic implementation instead.
2965 2008-09-01 Marek Safar <marek.safar@gmail.com>
2967 A fix for bug #418908
2968 * class.cs: Use AddScopeStatement for field initializers.
2970 2008-09-01 Marek Safar <marek.safar@gmail.com>
2972 A fix for bug #415385
2973 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2975 2008-09-01 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #421736
2978 * iterators.cs: Don't crash on unreachable iterators.
2980 2008-09-01 Marek Safar <marek.safar@gmail.com>
2982 A fix for bug #421628
2983 * parameter.cs, attribute.cs: Clone also parameter attributes.
2985 2008-08-30 Miguel de Icaza <miguel@novell.com>
2987 * namespace.cs (LookupType): In EvalMode, try to replace
2988 the TypeBuilder from our cache with a Type as Reflection.Emit does
2989 not like to mix code from older assemblies emitted and new
2992 This sounds like a serious Mono bug that prevents multiple
2993 assemblies to be generated and consumed at the same time.
2995 * cs-parser.jay (push_current_class): Do not make interactive
2996 classes internal or private, make them public as we currently
2997 generate each new class in a new assembly.
2999 2008-08-29 Miguel de Icaza <miguel@novell.com>
3001 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3002 remove types that are entered into the global namespace during
3003 parsing so that we can remove them on failure.
3005 * cs-parser.jay: Parsing: we now keep track of types that are
3006 entered into global variables and queue those in case the parsing
3009 This happens in a few situations: during partial-input, we invoke
3010 the parser repeatedly for example with the string "class X", this
3011 would cause X to be registed, and we need to remove this
3012 registration so that another parse attempt later with say "class X {"
3013 would actually work.
3015 Additionally, if there is an error in the resolution phase, for
3016 example: "class X : NonExistant {}" th
3018 * cs-parser.jay: Be more precise with the errors being raised,
3019 instead of flagging all exceptions during parsing to be attributed
3020 to the parsing process, distinguish those from errors happening in
3021 the actions and hint that using -v would produce the actual
3024 * repl.cs: Do not load all compiler references on each reset,
3025 doing the partial reset takes care of this.
3027 2008-08-28 Miguel de Icaza <miguel@novell.com>
3029 * repl.cs: Add support for loading all the files from
3030 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3033 Introduce a micro-parser that is able to deambiguate on its input
3034 whether we are dealing with a compilation unit (namespace, class,
3035 interface, struct, delegate) declaration or a statement. This
3036 allows both declarations and statements to be entered.
3038 Set history size by default to 300 lines.
3040 Instead of distinguishing based on the parser.InteractiveResult,
3041 have only two cases: statements were parsed, or a compilation unit
3042 was. Always pull the Using statement additions from the
3043 compilation unit parse.
3045 * cs-tokenizer.cs: Rename tokens to better describe their intent
3046 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3048 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3049 EvalMode is used to trigger the lookup of global variables while
3050 StatementMode is used turn variable declarations into static
3053 * getline.cs: Allow history size to be set.
3055 2008-08-29 Marek Safar <marek.safar@gmail.com>
3057 A fix for bug #360755
3058 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3060 2008-08-29 Marek Safar <marek.safar@gmail.com>
3062 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3064 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3065 member name, it is too confusing
3067 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3069 * rootcontext.cs: Finally default to warning level 4.
3071 2008-08-28 Marek Safar <marek.safar@gmail.com>
3073 * class.cs (CheckBase): Ignore overloaded operators.
3075 2008-08-28 Marek Safar <marek.safar@gmail.com>
3077 A fix for bug #420830
3078 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3080 2008-08-28 Marek Safar <marek.safar@gmail.com>
3082 A fix for bug #420832
3083 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3085 2008-08-28 Marek Safar <marek.safar@gmail.com>
3087 A fix for bug #420386
3088 * nullables.cs: Fixed logic of nullable user comparison operators involving
3091 2008-08-28 Marek Safar <marek.safar@gmail.com>
3093 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3095 2008-08-27 Miguel de Icaza <miguel@novell.com>
3097 * repl.cs: Add support for aborting the running code with C-c.
3099 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3101 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3103 2008-08-27 Miguel de Icaza <miguel@novell.com>
3105 * cs-parser.jay (interactive_statement_list): A new set of rules
3106 for hosting statements that uses the "interactive_" prefix.
3108 * repl.cs: Add support for parsing `using' as a statement or as a
3109 directive. Deambiguating before passing this to the parser.
3111 We need to distinguish statement_expressions that occur at the
3112 toplevel vs those that occur embedded into expressions.
3114 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3115 that fixes the cursor key handling, and a history bug.
3117 2008-08-26 Miguel de Icaza <miguel@novell.com>
3119 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3120 limitations in Console, instead the 2.0 bootstrap libraries now
3121 include the Console bits.
3123 Also, remove the use of Nullables from getline.cs
3127 Interactive support for the C# compiler. Use gmcs --shell to
3128 enter a read-eval-print loop shell.
3130 Docs: http://www.mono-project.com/CsharpRepl
3132 * sources: include repl.cs here and getline.cs for gmcs.exe,
3133 everything else is getline.cs impaired.
3135 * Makefile: when bootstrapping pass a special flag
3136 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3137 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3138 This distinguishes those two cases.
3140 * repl.cs: Support for a read-eval-print loop. Will be soon
3141 refactored into eval support and then REPL on top of it.
3143 * ecore.cs: If a simplename lookup fails, before erroring out,
3144 if we are in EvalMode to resolve the name to a declaration in the
3147 This means that variable declarations that happened in previous
3148 classes (as repl puts every statement in a separate class) are
3149 made visible in this way.
3151 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3152 triggered an error due to the end of file being reached. This is
3153 used to do multi-line input, and notify the caller that the user
3154 needs to provide more text before a successful parse.
3156 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3157 to drive the evaluation with a custom wrapper.
3159 * driver.cs: Add support for --shell, and refactor some code to be
3162 * namespace.cs: Add support for serializing the contents of the
3163 namespaces and reloading them.
3165 * getline.cs: A managed implementation of ReadLine under
3166 X11/Apache2 license terms. Easy to embed in other applications as
3169 * namespace.cs: Add some functions to save and restore the
3172 * rootcontext.cs: New public field.
3174 * cs-tokenizer.cs: Add support for one of the possible characters
3175 we introduce into the token stream.
3177 This patch does not affect the regular tokenization process, the
3178 only performance hit would happen if there is an invalid character
3179 on the input string.
3181 * support.cs: Move isatty helper routine here.
3183 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3184 code generator for in-memory assemblies.
3186 2008-08-26 Marek Safar <marek.safar@gmail.com>
3188 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3189 parameter cannot be always used as a type.
3191 2008-08-21 Marek Safar <marek.safar@gmail.com>
3193 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3195 2008-08-21 Marek Safar <marek.safar@gmail.com>
3197 * convert.cs: Implement explicit array to IList<T> conversion.
3199 2008-08-20 Marek Safar <marek.safar@gmail.com>
3201 A fix for bug #362740
3202 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3204 2008-08-20 Marek Safar <marek.safar@gmail.com>
3206 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3207 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3208 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3209 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3210 handling to use just one type of infrastructure and deal with generics
3213 2008-07-23 Martin Baulig <martin@ximian.com>
3215 *** Merged this from trunk revision 108527 ***
3218 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3219 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3222 2008-08-15 Marek Safar <marek.safar@gmail.com>
3224 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3227 2008-08-15 Marek Safar <marek.safar@gmail.com>
3229 * delegate.cs: Fixed compiler crash when creating delegate using partial
3232 * typemanager.cs: MulticastDelegate is not a delegate.
3234 2008-08-14 Marek Safar <marek.safar@gmail.com>
3236 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3239 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3241 * cs-parser.jay (type): Allow 'var' in mcs too.
3242 (local_variable_type): Likewise.
3244 2008-08-14 Marek Safar <marek.safar@gmail.com>
3246 * driver.cs: Removed broken -noconfig variants.
3248 2008-08-14 Marek Safar <marek.safar@gmail.com>
3250 A fix for bug #417078
3251 * expression.cs: Emit correctly left side pointer operators.
3253 2008-08-13 Marek Safar <marek.safar@gmail.com>
3255 * generic.cs, lambda.cs: Inflate method generic arguments only.
3257 2008-08-12 Marek Safar <marek.safar@gmail.com>
3259 * class.cs: Fixed struct layout check regression.
3261 2008-08-12 Marek Safar <marek.safar@gmail.com>
3263 * cs-parser.jay, enum.cs: Simplified enum parsing.
3265 * decl.cs: Check all type parameters conflicts.
3267 * expression.cs, statement.cs, attribute.cs: More expression checks.
3269 2008-08-11 Marek Safar <marek.safar@gmail.com>
3271 * generic.cs: Add type inference types restriction.
3273 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3274 anonymous.cs, expression.cs: Allocate less accessor parameters.
3276 2008-08-08 Marek Safar <marek.safar@gmail.com>
3278 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3281 2008-08-08 Marek Safar <marek.safar@gmail.com>
3283 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3285 2008-08-07 Marek Safar <marek.safar@gmail.com>
3287 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3288 Also fixes #362146 and #381592.
3290 2008-08-07 Marek Safar <marek.safar@gmail.com>
3292 * ecore.cs: Reduced constant cannot be used as an attribute value.
3294 * cs-parser.jay: Base expression has to be a type.
3296 * expression.cs (Conditional): Uses ReducedExpression.
3298 2008-08-06 Marek Safar <marek.safar@gmail.com>
3300 A fix for bug #376826
3301 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3302 address of hoisted local variable or parameter cannot be taken.
3304 2008-08-05 Marek Safar <marek.safar@gmail.com>
3306 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3307 anonymous method inside checked/unchecked expression.
3309 2008-08-05 Marek Safar <marek.safar@gmail.com>
3311 * typemanager.cs (IsEqual): Guard against null.
3313 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3314 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3315 routine. Fixed few misleading conversion errors.
3317 2008-08-04 Marek Safar <marek.safar@gmail.com>
3319 * class.cs: Consider generics when checking cycles in struct layout.
3321 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3323 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3325 2008-08-04 Marek Safar <marek.safar@gmail.com>
3327 A fix for bug #414165
3328 * anonymous.cs: Use same anonymous implementation method for all anonymous
3331 2008-08-04 Marek Safar <marek.safar@gmail.com>
3333 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3336 2008-08-04 Marek Safar <marek.safar@gmail.com>
3338 * cs-parser.jay: Typeof argument has to be a type expression.
3340 * namespace.cs: Check alias and namespace definitions collisions.
3342 * class.cs, pending.cs: Moved explicit interface accessor implementation
3345 * delegate.cs, expression.cs: Verify special name invocations.
3347 2008-08-01 Marek Safar <marek.safar@gmail.com>
3349 * cs-parser.jay: Don't choke on empty generic type arguments.
3351 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3353 * expression.cs, ecore.cs: Minor expressions bugs.
3355 2008-08-01 Marek Safar <marek.safar@gmail.com>
3357 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3358 and added more error handling.
3360 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3362 * modifiers.cs, enum.cs: Fixed.
3364 2008-07-31 Jb Evain <jbevain@novell.com>
3366 * driver.cs: remove -pkg ability of smcs.
3368 2008-07-30 Marek Safar <marek.safar@gmail.com>
3370 * statement.cs (Switch): Correctly set empty default target for single
3373 2008-07-30 Marek Safar <marek.safar@gmail.com>
3375 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3376 string switch statement implementation to use string dictionary which
3377 significantly (2-8x) improves performance of generated code.
3379 2008-07-29 Marek Safar <marek.safar@gmail.com>
3381 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3382 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3384 2008-07-29 Marek Safar <marek.safar@gmail.com>
3386 A fix for bug #412595
3387 * typemanager.cs, convert.cs, expression.cs: Some types are never
3388 convertible to each other.
3390 2008-07-29 Marek Safar <marek.safar@gmail.com>
3392 * nullable.cs (CreateNullConstant): An error messages update.
3394 2008-07-29 Marek Safar <marek.safar@gmail.com>
3396 A fix for bug #412595
3397 * cfold.cs: Don't cast undefined bool constant.
3399 2008-07-29 Martin Baulig <martin@ximian.com>
3402 (SymbolWriter.Reset): New public static method.
3405 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3407 2008-07-28 Marek Safar <marek.safar@gmail.com>
3409 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3411 * expression.cs (ElementAccess): Exact size allocation.
3413 2008-07-26 Marek Safar <marek.safar@gmail.com>
3415 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3417 2008-07-25 Marek Safar <marek.safar@gmail.com>
3419 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3421 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3424 2008-07-25 Marek Safar <marek.safar@gmail.com>
3426 A fix for bug #412217
3427 * assign.cs: Mutate also assignment type.
3429 2008-07-25 Marek Safar <marek.safar@gmail.com>
3431 A fix for bug #323644
3432 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3435 2008-07-25 Marek Safar <marek.safar@gmail.com>
3437 A fix for bug #412134
3438 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3439 non-enumerable operands when overloading equality or bitwise operators.
3441 2008-07-25 Marek Safar <marek.safar@gmail.com>
3443 * anonymous.cs: Cache closed generic anonymous method delegates.
3445 2008-07-24 Marek Safar <marek.safar@gmail.com>
3447 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3448 anonymous.cs, statement.cs: Always emit anonymous method as static method
3449 when is instance free. Use nesting for nested anynomous methods blocks.
3451 2008-07-23 Marek Safar <marek.safar@gmail.com>
3453 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3456 2008-07-23 Marek Safar <marek.safar@gmail.com>
3458 * expression.cs: Removed MakeSimpleCall.
3460 2008-07-23 Marek Safar <marek.safar@gmail.com>
3462 A fix for bug #323012
3463 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3464 Base method implementing interface has to be public.
3466 2008-07-23 Marek Safar <marek.safar@gmail.com>
3468 * cs-parser.jay: Don't break on missing argument.
3470 2008-07-22 Marek Safar <marek.safar@gmail.com>
3472 A fix for bug #320993
3473 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3474 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3476 2008-07-22 Marek Safar <marek.safar@gmail.com>
3478 A fix for bug #320748
3479 * convert.cs: Implicit user operators cannot convert to interfaces
3481 2008-07-22 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #312686
3484 * driver.cs: Ignore empty assembly references.
3486 2008-07-22 Marek Safar <marek.safar@gmail.com>
3488 A fix for bug #387040
3489 * ecore.cs: Skip constrains check for an explicit implementation.
3491 2008-07-21 Marek Safar <marek.safar@gmail.com>
3493 A fix for bug #409045
3494 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3495 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3496 identifiers are file specific unless passed as input arguments.
3498 2008-07-21 Marek Safar <marek.safar@gmail.com>
3500 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3501 to emit UnmanagedMarshal data under 2.0 profile.
3503 2008-07-21 Marek Safar <marek.safar@gmail.com>
3505 A fix for bug #410369
3506 * parameter.cs: Clone correctly ParamsParameter.
3508 2008-07-21 Marek Safar <marek.safar@gmail.com>
3510 * expression.cs (Argument): Always report type for type based expressions
3513 2008-07-18 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #410666
3516 * anonymous.cs: Correctly initialize generic storey reference.
3518 2008-07-18 Marek Safar <marek.safar@gmail.com>
3520 * convert.cs: Don't box same type arguments.
3522 2008-07-18 Marek Safar <marek.safar@gmail.com>
3524 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3525 Finished missing generic type mutators.
3527 2008-07-18 Marek Safar <marek.safar@gmail.com>
3529 * iterators.cs, statement.cs: Finished statements CloneTo.
3531 2008-07-18 Marek Safar <marek.safar@gmail.com>
3533 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3535 * expression.cs: Emit optimized default value expressions in expression tree
3538 2008-07-18 Marek Safar <marek.safar@gmail.com>
3540 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3542 2008-07-17 Marek Safar <marek.safar@gmail.com>
3544 A fix for bug #367536
3545 * cs-parser.jay: Check static constructor of generic types for an access
3548 2008-07-17 Marek Safar <marek.safar@gmail.com>
3550 A fix for bug #353800
3551 * lambda.cs: Emit ret for contextual statements.
3553 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3554 up emitting redundant ret for all anonymous methods with return.
3556 2008-07-17 Marek Safar <marek.safar@gmail.com>
3558 A fix for bug #365188
3559 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3560 create anonymous method storey in unreachable block.
3562 2008-07-17 Marek Safar <marek.safar@gmail.com>
3564 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3565 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3566 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3567 statement.cs: Fixed relevant defects found by Gendarme.
3569 2008-07-17 Marek Safar <marek.safar@gmail.com>
3571 A fix for bug #325291
3572 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3573 statement.cs: Replaced IAnonymousHost with top level block flag.
3575 2008-07-17 Marek Safar <marek.safar@gmail.com>
3577 * cs-parser.jay: Clean up unused open_parens.
3579 2008-07-17 Marek Safar <marek.safar@gmail.com>
3581 * ecore.cs: Custom error message for a range variable assignment.
3583 2008-07-16 Marek Safar <marek.safar@gmail.com>
3585 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3588 2008-07-16 Marek Safar <marek.safar@gmail.com>
3590 * literal.cs: Null literal is of object type.
3592 2008-07-16 Marek Safar <marek.safar@gmail.com>
3594 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3595 expression of nullable equality comparison.
3597 2008-07-15 Marek Safar <marek.safar@gmail.com>
3599 * expression.cs(PointerArithmetic): Removed redundant assignment.
3601 2008-07-15 Marek Safar <marek.safar@gmail.com>
3603 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3605 2008-07-14 Marek Safar <marek.safar@gmail.com>
3607 A fix for bug #408361
3608 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3609 they are replaced by GetMethod.
3611 2008-07-14 Marek Safar <marek.safar@gmail.com>
3613 A fix for bug #408721 by jeremie.laval@gmail.com
3614 * expression.cs (Indirection): Implemented CloneTo.
3616 2008-07-14 Marek Safar <marek.safar@gmail.com>
3618 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3621 2008-07-14 Marek Safar <marek.safar@gmail.com>
3623 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3625 2008-07-11 Marek Safar <marek.safar@gmail.com>
3627 * linq.cs: Reset tranparent parameter counter in probing mode.
3629 2008-07-11 Marek Safar <marek.safar@gmail.com>
3631 * anonymous.cs: Mutate anonymous method type.
3633 2008-07-11 Marek Safar <marek.safar@gmail.com>
3635 * ecore.cs, anonymous.cs: Mutate field expressions.
3637 2008-07-10 Marek Safar <marek.safar@gmail.com>
3639 A fix for bug #369670
3640 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3642 2008-07-10 Marek Safar <marek.safar@gmail.com>
3644 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3646 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3649 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3650 only one '>', and finds a '>>', abort the generic lookahead.
3652 2008-07-10 Marek Safar <marek.safar@gmail.com>
3654 A fix for bug #319902
3655 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3657 2008-07-10 Marek Safar <marek.safar@gmail.com>
3659 A fix for bug #406371
3660 * statement.cs: Moved EmitSymbolInfo to Block.
3662 2008-07-09 Marek Safar <marek.safar@gmail.com>
3664 * ecore.cs: Report better error for extension method overload failures.
3666 2008-07-09 Marek Safar <marek.safar@gmail.com>
3668 * expression.cs (Is): No need to box reference values.
3670 2008-07-09 Marek Safar <marek.safar@gmail.com>
3672 * class.cs: Use event resolve context when initializing CreateEmitContext.
3674 2008-07-09 Marek Safar <marek.safar@gmail.com>
3676 A fix for bug #394436
3677 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3678 method used inside expression trees. Added more LINQ to expression tree
3681 2008-07-08 Marek Safar <marek.safar@gmail.com>
3683 A fix for bug #378189, #370577
3684 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3687 2008-07-08 Marek Safar <marek.safar@gmail.com>
3689 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3692 2008-07-08 Marek Safar <marek.safar@gmail.com>
3694 A fix for bug #406702
3695 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3697 2008-07-07 Marek Safar <marek.safar@gmail.com>
3699 A fix for bug #406648
3700 * cs-parser.jay: Report nullable use in mcs for some cases.
3702 2008-07-07 Marek Safar <marek.safar@gmail.com>
3704 * ecore.cs: Improved argument mismatch error messages.
3706 2008-07-07 Marek Safar <marek.safar@gmail.com>
3708 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3710 2008-07-07 Marek Safar <marek.safar@gmail.com>
3712 * expression.cs (TypeOf): Mutate type argument.
3714 2008-07-04 Marek Safar <marek.safar@gmail.com>
3716 * class.cs: Report missing partial modifier for correct type.
3718 2008-07-04 Marek Safar <marek.safar@gmail.com>
3720 * ecore.cs, expression.cs (VariableReference): Variable property is
3723 2008-07-04 Marek Safar <marek.safar@gmail.com>
3725 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3727 2008-07-04 Marek Safar <marek.safar@gmail.com>
3729 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3732 2008-07-04 Marek Safar <marek.safar@gmail.com>
3734 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3735 anonymous method storey to an instance method when only "this" is hoisted.
3737 2008-07-03 Marek Safar <marek.safar@gmail.com>
3739 A fix for bug #321615
3740 * expression.cs: Pointer comparisons use unsigned operator.
3742 2008-07-03 Marek Safar <marek.safar@gmail.com>
3744 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3746 2008-07-02 Marek Safar <marek.safar@gmail.com>
3748 A fix for bug #404905
3749 * class.cs: Always initialize local unsafe variables.
3751 2008-06-30 Marek Safar <marek.safar@gmail.com>
3753 A fix for bug #396987
3754 * expression.cs (NewInitialize): Clear local temporary variable for next run
3756 2008-06-27 Marek Safar <marek.safar@gmail.com>
3758 A fix for bug #401020
3759 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3761 2008-06-27 Marek Safar <marek.safar@gmail.com>
3763 A fix for bug #398319
3764 * cs-parser.jay: Implemented undocumented base access expression inside
3767 2008-06-26 Marek Safar <marek.safar@gmail.com>
3769 A fix for bug #404227
3770 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3772 2008-06-26 Marek Safar <marek.safar@gmail.com>
3774 A fix for bug #404227
3775 * convert.cs: Fixed explicit array to interface cast.
3777 2008-06-26 Marek Safar <marek.safar@gmail.com>
3779 A fix for bug #403894
3780 * delegate.cs: Mutate DelegateInvocation type.
3782 2008-06-26 Marek Safar <marek.safar@gmail.com>
3784 A fix for bug #379348
3785 * delegate.cs: Box a load of generic parameters.
3787 2008-06-26 Marek Safar <marek.safar@gmail.com>
3789 * expression.cs: Add an array creation arguments mutate.
3791 2008-06-26 Marek Safar <marek.safar@gmail.com>
3793 A fix for bug #386068
3794 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3797 2008-06-25 Marek Safar <marek.safar@gmail.com>
3799 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3802 2008-06-25 Marek Safar <marek.safar@gmail.com>
3804 A fix for bug #403518
3805 * delegate.cs: Type correctly anonymous method new invocation.
3807 2008-06-24 Marek Safar <marek.safar@gmail.com>
3809 A fix for bug #394826
3810 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3813 2008-06-24 Marek Safar <marek.safar@gmail.com>
3815 A fix for bug #394826
3816 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3819 2008-06-24 Marek Safar <marek.safar@gmail.com>
3821 * class.cs: Clone indexer parameters for localized capturing.
3823 2008-06-24 Marek Safar <marek.safar@gmail.com>
3825 A fix for bug #402379
3826 * expression.cs: Don't crash when an object initializer resolve fails.
3828 2008-06-24 Marek Safar <marek.safar@gmail.com>
3830 A fix for bug #402888
3831 * expression.cs: Mutate conditional expression.
3833 2008-06-24 Marek Safar <marek.safar@gmail.com>
3835 A fix for bug #401012
3836 * class.cs: Keep StructLayout in shared container.
3838 2008-06-24 Marek Safar <marek.safar@gmail.com>
3840 A fix for bug #400438
3841 * decl.cs, class.cs: Only properties can be automatically implemented.
3843 2008-06-24 Marek Safar <marek.safar@gmail.com>
3845 * statement.cs (ChangeToIterator): Copy also labels.
3847 2008-06-23 Marek Safar <marek.safar@gmail.com>
3849 * ecore.cs: Pass type argument details to parent extension method.
3851 2008-06-23 Marek Safar <marek.safar@gmail.com>
3853 A fix for bug #375966
3854 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3856 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3858 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3860 2008-06-22 Marek Safar <marek.safar@gmail.com>
3862 A fix for bug #394347
3863 * anonymous.cs: Cache compatible delegates as compatibility check produces
3864 a new method every time.
3866 2008-06-20 Marek Safar <marek.safar@gmail.com>
3868 * anonymous.cs: Propagate storey reference for single references.
3870 2008-06-20 Marek Safar <marek.safar@gmail.com>
3872 A fix for bug #387615
3873 * assign.cs, expression.cs: Correctly clone compound assignment.
3875 2008-06-19 Marek Safar <marek.safar@gmail.com>
3877 A fix for bug #359611, #359604
3878 * anonymous.cs: Mutate all types of hoisted parameters.
3880 2008-06-19 Marek Safar <marek.safar@gmail.com>
3882 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3883 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3884 expression.cs, codegen.cs, statement.cs
3886 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3887 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3889 ** Anonymous methods, lambda expressions rewrite **
3891 Anonymous expressions are now resolved when an explicit block is resolved
3892 and they don't require any registration procedure anymore. Further,
3893 anonymous methods are defined when explicit block is emitted which allows
3894 better control of whole process and opens possibilities for more
3895 optimizations as well as alternative to reverse whole process.
3897 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3898 process consistent and to correctly emit hoisted generic methods when they
3899 have at least 1 hoisted variable.
3901 2008-06-17 Martin Baulig <martin@ximian.com>
3903 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3905 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3906 virtual property; check it in Emit().
3907 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3909 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3911 (Indexer.Define): Likewise.
3913 2008-06-17 Marek Safar <marek.safar@gmail.com>
3915 * convert.cs: Don't use IsInterface on type arguments.
3917 * delegate.cs: DelegateInvocation uses MethodInfo.
3919 * parameter.cs: Removed IsTypeParameter.
3921 * generic-mcs.cs: More missing stuff.
3923 2008-06-16 Martin Baulig <martin@ximian.com>
3926 (Modifiers.DEBUGGER_HIDDEN): New public const.
3929 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3932 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3933 (AbstractPropertyEventMethod): Likewise.
3934 (Constructor.Emit): Likewise.
3935 (SourceMethod.SetCompilerGenerated): Removed.
3937 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3941 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3942 if we're an `IteratorHost'.
3943 (AnonymousMethodMethod..ctor): Don't set
3944 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3947 2008-06-16 Marek Safar <marek.safar@gmail.com>
3949 * statement.cs: Clean-up foreach statements.
3951 2008-06-12 Marek Safar <marek.safar@gmail.com>
3953 * class.cs: Stop using public method which should not exist
3954 (MethodBuilder.SetGenericMethodSignature).
3956 2008-06-11 Martin Baulig <martin@ximian.com>
3959 (Location.LookupFile): Add `CompilationUnit' argument; when given
3960 a relative file name, make it relative to the directory the .cs
3961 file is located in instead of using the current directory.
3963 2008-06-11 Martin Baulig <martin@ximian.com>
3966 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3967 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3968 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3969 (SourceMethod.SetCompilerGenerated): Likewise.
3971 2008-06-11 Marek Safar <marek.safar@gmail.com>
3973 * codegen.cs, driver: Only write symbol file when it's asked for.
3975 2008-06-11 Marek Safar <marek.safar@gmail.com>
3977 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3979 2008-06-10 Martin Baulig <martin@ximian.com>
3981 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3983 2008-06-09 Marek Safar <marek.safar@gmail.com>
3985 A fix for bug #316290
3986 * expression.cs: Include decimal operators in predefined table.
3988 * parameters.cs: More readonlyness.
3990 2008-06-09 Marek Safar <marek.safar@gmail.com>
3992 A fix for bug #397213
3993 * cs-parser.jay: One more missing current_local_parameters reset.
3995 2008-06-09 Marek Safar <marek.safar@gmail.com>
3997 A fix for bug #396633
3998 * class.cs: Host backing field in partial container.
4000 2008-06-09 Marek Safar <marek.safar@gmail.com>
4002 A fix for bug #397068
4003 * expression.cs: Check both operand types when predefined operator is used.
4005 2008-06-05 Martin Baulig <martin@ximian.com>
4007 Merged the `debugger-kahalo' branch.
4010 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4011 we're an iterator method.
4012 (SourceMethod): Reflect latest symbol writer changes;
4013 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4014 now `start_row' and `end_row'.
4015 (Constructor.Emit): Fix the logic whether to emit symbol information.
4017 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4021 (CompilationUnit): New public class; derives from `SourceFile'.
4022 (SourceFileEntry.DefineSymbolInfo): New public method.
4023 (SourceFileEntry.SetChecksum): New public method.
4024 (Location): Encode hidden line numbers by using `column == 255';
4025 the .ctor now accepts `column == -1' to mark a hidden line number.
4026 (Location.Hidden): New public property.
4027 (Location.CheckPoint): Add `CompilationUnit'.
4028 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4029 (Location.Push): Add `CompilationUnit compile_unit' argument.
4030 (Location.CompilationUnit): New public property.
4033 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4035 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4037 * driver.cs: `SourceFile' -> `CompilationUnit'.
4039 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4041 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4043 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4047 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4048 new symbol writer API to also pass the file.
4050 2008-06-05 Marek Safar <marek.safar@gmail.com>
4052 * statement.cs: Emit catch variable assignment using variable expression.
4054 2008-06-05 Marek Safar <marek.safar@gmail.com>
4056 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4057 with other variable types.
4059 2008-06-04 Marek Safar <marek.safar@gmail.com>
4061 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4062 GetLength method emit, it breaks resolve rules.
4064 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4065 Marek Safar <marek.safar@gmail.com>
4067 A fix for bug #395542
4068 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4071 2008-06-02 Marek Safar <marek.safar@gmail.com>
4073 A fix for bug #395287
4074 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4076 2008-05-31 Marek Safar <marek.safar@gmail.com>
4078 A fix for bug #395845
4079 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4080 non-nullable parameter type.
4082 2008-05-31 Marek Safar <marek.safar@gmail.com>
4084 * class.cs: Handle contructor initializer as a statement in top-level block.
4086 2008-05-30 Marek Safar <marek.safar@gmail.com>
4088 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4089 security attributes.
4091 2008-05-24 Marek Safar <marek.safar@gmail.com>
4093 * ecore.cs, expression.cs: Small IVariable refactoring.
4095 2008-05-22 Marek Safar <marek.safar@gmail.com>
4097 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4099 2008-05-21 Marek Safar <marek.safar@gmail.com>
4101 * cs-parser.jay: Removed redundant catch type check.
4103 2008-05-21 Marek Safar <marek.safar@gmail.com>
4105 A fix for bug #390372
4106 * nullable.cs: Set correct return type.
4108 2008-05-21 Marek Safar <marek.safar@gmail.com>
4110 A fix for bug #391062
4111 * typemanager.cs: Fixed crash when comparing null types.
4113 2008-05-21 Marek Safar <marek.safar@gmail.com>
4115 A fix for bug #391871
4116 * cs-parser.jay: Better error handling for invalid catch type.
4118 2008-05-20 Marek Safar <marek.safar@gmail.com>
4120 A fix for bug #392155
4121 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4123 2008-05-15 Marek Safar <marek.safar@gmail.com>
4125 A fix for bug #390666
4126 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4129 2008-05-15 Marek Safar <marek.safar@gmail.com>
4131 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4134 2008-05-13 Marek Safar <marek.safar@gmail.com>
4136 A fix for bug #389625
4137 * delegate.cs, generic.cs: Some progress on method group return type
4140 2008-05-13 Marek Safar <marek.safar@gmail.com>
4142 A fix for bug #378419
4143 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4145 2008-05-12 Marek Safar <marek.safar@gmail.com>
4147 * class.cs (Constructor): Added IsCompilerGenerated.
4149 2008-05-12 Marek Safar <marek.safar@gmail.com>
4151 * expression.cs: Enum binary operators can accept non-enum operand only when
4152 is implicitly convertible to underlying type.
4154 2008-05-12 Marek Safar <marek.safar@gmail.com>
4156 A fix for bug #389272
4157 * support.cs: Workaround System.InvalidOperationException for enums.
4159 2008-05-12 Marek Safar <marek.safar@gmail.com>
4161 A fix for bug #389073
4162 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4164 2008-05-10 Marek Safar <marek.safar@gmail.com>
4166 * driver.cs: Split Parse.
4168 * location.cs (LookupFile): Uses string.Empty.
4170 2008-05-07 Marek Safar <marek.safar@gmail.com>
4172 * expression.cs, parameter.cs: Small ParameterReference clean up.
4174 2008-05-07 Marek Safar <marek.safar@gmail.com>
4176 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4177 hack. Fixes #387502.
4179 2008-05-06 Martin Baulig <martin@ximian.com>
4181 * class.cs (Constructor.Emit): Fix the logic whether to emit
4184 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4187 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4188 InvalidOperationException when the iterator is before the start or
4191 2008-05-06 Marek Safar <marek.safar@gmail.com>
4193 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4194 when left is nullable type.
4196 2008-05-06 Marek Safar <marek.safar@gmail.com>
4198 A fix for bug #386628
4199 * expression.cs (LocalVariableReference): Continue in resolving when
4200 variable is not assigned.
4202 2008-05-05 Marek Safar <marek.safar@gmail.com>
4204 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4205 nullable operations.
4207 2008-05-04 Marek Safar <marek.safar@gmail.com>
4209 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4210 it saves many redundant temporary variables for nullable operations.
4212 2008-05-03 Marek Safar <marek.safar@gmail.com>
4214 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4216 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4219 * nullable.cs: Constant coalescing operator optimizations.
4221 2008-05-03 Marek Safar <marek.safar@gmail.com>
4223 * constant.cs: Use unsigned conversion for values which are unsigned only.
4225 2008-05-03 Marek Safar <marek.safar@gmail.com>
4227 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4228 coalescing operator as it should be.
4230 2008-05-02 Marek Safar <marek.safar@gmail.com>
4232 A fix for bug #371016
4233 * expression.cs: All predefined delegate operators require implicit method
4236 2008-05-02 Marek Safar <marek.safar@gmail.com>
4238 * constant.cs: Emit long constant as uint when fits the range.
4240 * convert.cs, expression.cs: Fixed few unsafe conversions.
4242 2008-05-02 Marek Safar <marek.safar@gmail.com>
4244 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4246 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4249 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4251 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4253 2008-05-01 Marek Safar <marek.safar@gmail.com>
4255 * constant.cs, literal.cs: IsLiteral property for error reporting.
4257 * ecore.cs, expression.cs: Implemented Property expression.
4259 2008-05-01 Marek Safar <marek.safar@gmail.com>
4261 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4263 * nullable.cs: Implemented nullable coalescing null operator.
4265 * ecore.cs, expression.cs: Expression trees work.
4267 2008-05-01 Marek Safar <marek.safar@gmail.com>
4269 * ecore.cs: CreateExpressionTree is finally abstract.
4271 * expression.cs, linq.cs: Updated.
4273 2008-05-01 Marek Safar <marek.safar@gmail.com>
4275 * expression.cs, ecore.cs: Block base access expression inside expression
4278 2008-05-01 Marek Safar <marek.safar@gmail.com>
4280 A fix for bug #385058
4281 * expression.cs: User-defined operator implementations always take
4282 precedence over predefined operator implementations.
4284 2008-04-30 Marek Safar <marek.safar@gmail.com>
4286 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4287 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4288 expression tree conversions.
4290 2008-04-30 Marek Safar <marek.safar@gmail.com>
4292 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4293 operators method details to Operator class.
4295 2008-04-30 Marek Safar <marek.safar@gmail.com>
4297 * anonymous.cs: Pass unsafe flags to anonymous container.
4299 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4300 inside expression tree.
4302 2008-04-29 Martin Baulig <martin@ximian.com>
4304 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4305 (Tokenizer.PopPosition): Also restore the `line'.
4307 2008-04-29 Marek Safar <marek.safar@gmail.com>
4309 * delegate.cs: Implemented Invoke expression.
4311 2008-04-29 Marek Safar <marek.safar@gmail.com>
4313 * expression.cs: Fixed equality reference comparison regression.
4315 2008-04-29 Marek Safar <marek.safar@gmail.com>
4317 * ecore.cs: Clean up EmptyCast hack.
4319 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4320 using correct conversion rules. Also fixes #383993.
4322 2008-04-28 Martin Baulig <martin@ximian.com>
4324 * class.cs (Constructor.Emit): Don't emit debugging information
4325 for generated default .ctor's.
4327 2008-04-28 Marek Safar <marek.safar@gmail.com>
4329 * convert.cs: Empty-cast ushort to int conversion.
4331 2008-04-28 Marek Safar <marek.safar@gmail.com>
4333 A fix for bug #384191
4334 * ecore.cs, expression.cs: Fixed expression cloning.
4336 2008-04-28 Marek Safar <marek.safar@gmail.com>
4338 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4340 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4342 Fix #381559, test-638.cs, test-639.cs
4343 * assign.cs (CompoundAssign.Helper): New wrapper.
4344 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4346 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4347 Pass unconverted expressions to the params array creation expression.
4348 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4349 (PropertyExpr.EmitAssign): Likewise.
4350 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4351 element if it is of kind CompoundAssign.Helper.
4352 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4353 first before anything else.
4354 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4355 (ArrayAccess.LoadArrayAndArguments): Simplify.
4357 2008-04-27 Marek Safar <marek.safar@gmail.com>
4359 * expression.cs: Fixed cloning of typeof(void).
4361 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4363 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4364 (Assign.Emit): Likewise. Move it to ...
4365 (CompoundAssign.DoResolve): ... here and ...
4366 (CompoundAssign.Emit): ... here.
4367 (EventAddOrRemove): New helper to handle += and -= on events, and
4368 avoid the use of BinaryDelegates.
4369 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4370 (EventExpr.EmitAddOrRemove): Improve.
4371 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4373 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4374 create VarExprs for 'foo.bar.var'.
4375 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4376 is a highly inappropriate name for its functionality.
4378 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4380 Simplify handling of multiple assignments
4381 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4383 (SimpleAssign): New. Class to be used for normal assignments.
4384 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4385 * expression.cs, parameter.cs, statement.cs: Likewise.
4387 2008-04-25 Marek Safar <marek.safar@gmail.com>
4389 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4390 for incompatible underlying types, more to come, uff.
4392 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4395 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4396 Handle 'leave_copy'.
4398 2008-04-25 Marek Safar <marek.safar@gmail.com>
4400 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4402 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4404 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4405 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4406 * statement.cs (While, Do, For): Allow test to have side effects.
4407 (For.DoEmit): Always emit InitStatement.
4410 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4411 Always create SideEffectConstant.
4412 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4413 of type EnumConstant.
4415 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4416 Handle 'right' being SideEffectConstant of type 'bool'.
4418 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4419 Use left.EmitBranchable instead of open coding it, so as to
4420 improve optimization opportunities.
4422 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4424 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4426 (Expression.EmitSideEffect): Document.
4428 2008-04-23 Marek Safar <marek.safar@gmail.com>
4430 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4432 2008-04-23 Marek Safar <marek.safar@gmail.com>
4434 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4436 2008-04-23 Marek Safar <marek.safar@gmail.com>
4438 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4439 conversion to expression tree.
4441 2008-04-23 Marek Safar <marek.safar@gmail.com>
4443 * ecore.cs: Removed unused expression.
4445 2008-04-22 Marek Safar <marek.safar@gmail.com>
4447 * expression.cs: Implemented NegateChecked and New expressions.
4449 2008-04-22 Marek Safar <marek.safar@gmail.com>
4451 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4453 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4456 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4457 needing final 'ret' instruction.
4459 2008-04-22 Marek Safar <marek.safar@gmail.com>
4461 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4463 2008-04-21 Marek Safar <marek.safar@gmail.com>
4465 * expression.cs: Emit ldnull and not null expression as an instance argument
4466 of static method expression calls.
4468 2008-04-21 Marek Safar <marek.safar@gmail.com>
4470 A fix for bug #378200
4471 * expression.cs: Fixed crash when creating parameterless expression tree
4474 2008-04-21 Marek Safar <marek.safar@gmail.com>
4476 A fix for bug #375297
4477 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4480 2008-04-21 Marek Safar <marek.safar@gmail.com>
4482 A fix for bug #377596
4483 * decl.cs, class.cs: Emit delegate type argument attributes.
4485 2008-04-21 Marek Safar <marek.safar@gmail.com>
4487 A fix for bug #365314
4488 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4490 2008-04-21 Marek Safar <marek.safar@gmail.com>
4492 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4495 2008-04-21 Marek Safar <marek.safar@gmail.com>
4497 * generic.cs (TypeParameter): Removed redundant location.
4499 2008-04-19 Marek Safar <marek.safar@gmail.com>
4501 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4502 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4503 FullNamedExpression in all declaration type expression, statements will come
4506 2008-04-18 Marek Safar <marek.safar@gmail.com>
4508 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4509 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4511 2008-04-18 Marek Safar <marek.safar@gmail.com>
4513 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4516 2008-04-17 Marek Safar <marek.safar@gmail.com>
4518 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4521 2008-04-17 Marek Safar <marek.safar@gmail.com>
4523 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4527 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4529 Hook up 'EmitSideEffect'
4530 * constant.cs (Constant.EmitSideEffect): New.
4531 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4532 (SideEffectConstant.EmitSideEffect): New.
4533 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4534 unconditional branch in EmitBranchable.
4535 (FieldExpr.EmitBranchable): New.
4536 * expression.cs (Unary.EmitSideEffect): New.
4537 (Binary.EmitSideEffect): New.
4538 (VariableReference.EmitSideEffect): New. Do nothing.
4540 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4542 Introduce 'EmitSideEffect'
4543 * ecore.cs (Expression.EmitSideEffect): New.
4544 (TypeCast): Rename from EmptyCast.
4546 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4547 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4548 * convert.cs, nullable.cs: Update to changes.
4550 2008-04-16 Marek Safar <marek.safar@gmail.com>
4552 * class.cs, cs-parser.jay: Early check for base types expression.
4554 2008-04-16 Marek Safar <marek.safar@gmail.com>
4556 * decl.cs (MemberName): Declare PrettyName as obsolete.
4558 2008-04-16 Marek Safar <marek.safar@gmail.com>
4560 * namespace.cs: Use MemberName comparison.
4562 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4565 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4567 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4568 (MemberName.FullyQualifiedName): New. Provides the functionality
4569 that users assume FullName would have.
4570 * ecore.cs, namespace.cs: Update to changes.
4572 * statement.cs (Using.assign): Make into ExpressionStatement.
4573 (Using.EmitPreTryBody): Simplify.
4575 2008-04-16 Marek Safar <marek.safar@gmail.com>
4577 * report.cs: ColorFormat is protected.
4579 * rootcontext.cs: Unused fields clean-up.
4581 * namespace.cs: Made UsingEntry name private.
4583 2008-04-16 Marek Safar <marek.safar@gmail.com>
4585 * cs-tokenizer.cs, location.cs: Removed unused field.
4587 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4588 Raja R Harinath <harinath@hurrynot.org>
4591 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4592 (SideEffectConstant.side_effect): Rename from 'right'.
4593 (SideEffectConstant..ctor): Normalize 'side_effect'.
4594 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4595 value of this constant.
4596 * cfold.cs: Update to changes.
4598 2008-04-15 Marek Safar <marek.safar@gmail.com>
4600 * cs-paser.jay: Removed unused variable.
4602 * driver.cs: Made Compile instance method.
4604 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4606 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4608 2008-04-15 Marek Safar <marek.safar@gmail.com>
4610 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4612 2008-04-13 Jb Evain <jbevain@novell.com>
4614 * namespace.cs: update the System.Core fullname for 2.1
4615 * driver.cs: update the list of required assemblies for 2.1.
4616 Merged from the Moonlight 2 branch.
4618 2008-04-11 Marek Safar <marek.safar@gmail.com>
4620 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4621 types and user defined operators. User operators arguments has to be checked
4622 for null value before invocation, which also means no operator is called
4623 when any argument is not convertible to unwrapped nullable type.
4625 2008-04-09 Marek Safar <marek.safar@gmail.com>
4627 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4628 of Unary expressions to follow operator overloading rules precisely.
4629 Also fixes #321794, #323794
4631 2008-04-08 Marek Safar <marek.safar@gmail.com>
4633 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4636 2008-04-08 Marek Safar <marek.safar@gmail.com>
4638 * expression.cs, ecore.cs: Implemented MemberInit expression.
4640 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4642 Fix mono/tests/exception4.cs
4643 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4644 ec.NeedReturnLabel () rather emitting a 'nop'.
4646 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4648 (TryCatch.SomeCodeFollows): Likewise.
4649 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4650 for 'break', 'continue' and 'return' statements inside a try.
4651 We're fairly sure that the generated IL stream will have more
4652 instructions textually following the try.
4653 (FlowBranchingTryCatch): Likewise.
4655 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4656 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4659 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4660 wrapper -- forward everything to CollectionForeach.
4661 (CollectionForeach.NonDisposableWrapper): New.
4662 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4663 instead of a pop + branch to end.
4665 2008-04-07 Marek Safar <marek.safar@gmail.com>
4667 A fix for bug #377485
4668 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4669 Propagate location for extension method groups. Report conversion failure at
4672 2008-04-07 Marek Safar <marek.safar@gmail.com>
4674 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4675 ListInit and Field expressions.
4677 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4679 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4680 Since $PC is always -1 inside the body of MoveNext, the fault
4682 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4683 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4684 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4686 The denouement! Fix #324708
4687 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4688 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4689 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4690 'finally' inside the finally clause.
4692 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4693 inside an iterator. Don't emit the body of the 'finally' inside
4694 the finally clause yet.
4696 Use the ResumableStatement infrastructure for MoveNext ()
4697 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4698 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4699 'old_resume_points'. Move dispatcher upfront.
4700 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4701 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4702 in an enumerator. This encodes the main fix in this patch series
4703 -- we can only jump into the first instruction of a try from the
4704 outside, but we want to emit try/finally regions in iterators and
4705 resume in the middle of them.
4707 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4709 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4710 of NeedReturnLabel here.
4712 Introduce a common point for emitting try/finally to IL
4713 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4714 features of the various subclasses, which are now driven by ...
4715 (ExceptionStatement.EmitPreTryBody): ... this and ...
4716 (ExceptionStatement.EmitTryBody): ... this and the original
4718 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4719 Remove DoEmit and update to follow above protocol.
4721 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4722 of the dispatcher are the same, skip emitting the 'switch'.
4723 * iterator.cs (Iterator.EmitDispose): Update to changes.
4725 Clean up handling of 'using' statement
4726 * statement.cs (UsingTemporary): New. Carved out of ...
4727 (Using): ... this. Simplify drastically. Handle exactly
4729 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4730 or Using as appropriate. If there are multiple variable declared,
4731 create nested Using statements.
4732 (resource_acquisition): Kill.
4734 * statement.cs (ExceptionStatement.EmitForDispose): Use
4735 EmitFinallyBody, not EmitFinally.
4737 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4738 * iterator.cs: Update to changes.
4740 Start using the ResumableStatement infrastructure
4741 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4742 (ResumableStatement.EmitForDispose): New.
4743 (ExceptionStatement): Override them.
4744 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4745 EmitForDispose to create the body of the Dispose method. Don't
4748 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4749 * statement.cs (Toplevel.AddResumePoint): ... here.
4750 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4751 * flowanalysis.cs (FlowBranchingIterator): New.
4752 * codegen.cs (EmitContext): Update to changes.
4754 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4755 (Iterator.old_resume_points): Rename from 'resume_points'.
4756 (Iterator.MoveNextStatement): Remove unused class.
4758 New infrastructure for try/finally in iterators (still unused)
4759 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4760 (FlowBranchingToplevel.AddResumePoint): Hook into
4761 ToplevelBlock.AddResumePoint.
4762 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4763 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4764 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4765 resume points and assign program-counter values.
4766 (ExceptionBlock.AddResumePoint): Collect resume points for
4767 de-muxer at the top of try block.
4768 * iterators.cs (Yield.CheckContext): Simplify.
4769 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4771 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4773 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4774 argument to an ExitStatement.
4775 (FlowBranchingException): Refactor saved origins code.
4776 * statement.cs (ExitStatement): Update to cahges.
4777 * iterator.cs (YieldBreak): Likewise.
4779 * statement.cs (ResumableStatement): New. Common base class for
4780 YieldReturn and ExceptionStatement.
4781 (ExitStatement): New. Common base class for Return and YieldBreak.
4782 (Return): Update to changes.
4783 * iterator.cs (YieldBreak): Likewise.
4784 * lambda.cs (ContextualReturn): Likewise.
4787 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4788 emit a meaningful error message.
4790 Fix #324765, #319508
4791 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4792 (VariableInfo.SetAssigned): Set it.
4793 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4794 determine if CS0219 or CS0168 is appropriate. Don't use
4795 flow-analysis information.
4796 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4797 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4798 (EmitContext.EndFlowBranching): ... this.
4800 2008-04-03 Marek Safar <marek.safar@gmail.com>
4802 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4804 2008-04-03 Marek Safar <marek.safar@gmail.com>
4806 A fix for bug #376508
4807 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4808 ImplicitConversionExists.
4810 2008-04-03 Marek Safar <marek.safar@gmail.com>
4812 * expression.cs (Binary): Added remaining binary operators to expression
4815 * nullable.cs: Optimize shift with null argument.
4817 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4819 Fix minor IL regression
4820 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4821 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4822 * cs-parser.jay (try_statement): Update to changes.
4824 * statement.cs (TryFinally.need_exc_block): Delete.
4825 (TryFinally): Update to changes.
4827 Now all ExceptionStatements are unconditional
4828 * statement.cs (CollectionForeach.DisposableWrapper): New.
4829 Extract out the try/finally code into a new wrapper.
4830 (CollectionForeach.Resolve): Use it to simplify the code.
4832 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4834 Start at simplifying ExceptionStatement semantics a bit
4835 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4836 * cs-parser.jay (try_statement): Update to changes.
4837 (opt_catch_clauses): Remove.
4838 * flowanalysis.cs: Update to changes.
4839 (FlowBranching.BranchingType.TryCatch): New.
4840 (FlowBranchingTryCatch): New.
4842 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4843 (FlowBranching.CreateBranching): Update to changes.
4844 (FlowBranchingBlock.AddSibling): Add sanity check.
4845 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4848 * iterators.cs (Iterator.MarkFinally): Remove.
4849 * statement.cs (ExceptionStatement): Update to changes.
4851 Add support for skipping over finally blocks at runtime. First
4852 in a series to fix #324708
4853 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4854 (Iterator.EmitMoveNext): Initialize it.
4855 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4856 branch over the body of the 'finally' clause.
4858 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4860 Avoid lopsided use of Foo/DoFoo names
4861 * statement.cs (ExpressionStatement.EmitFinallyBody):
4862 Rename from EmitFinally.
4863 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4864 * iterator.cs: Update to changes.
4866 2008-04-02 Marek Safar <marek.safar@gmail.com>
4868 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4869 based on UserOperatorCall. More binary nullable operators clean up.
4871 2008-04-02 Martin Baulig <martin@ximian.com>
4873 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4875 2008-04-02 Marek Safar <marek.safar@gmail.com>
4877 * nullable.cs: Merge user and empty conversions when lifting expression
4880 * expression.cs (StringConcat): Implemented expression tree representation.
4882 2008-04-01 Marek Safar <marek.safar@gmail.com>
4884 * nullable.cs: When lifting null literal and a user operator exists, no call
4887 2008-04-01 Marek Safar <marek.safar@gmail.com>
4889 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4892 2008-04-01 Marek Safar <marek.safar@gmail.com>
4894 * nullable.cs, expression.cs: Use namespace instead heavily nested
4895 monster abstract class.
4897 2008-04-01 Marek Safar <marek.safar@gmail.com>
4899 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4900 lifting of null literal and user operators. Clean up of some temporary
4903 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4905 Fix #368224, test-629.cs
4906 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4907 if it crossed an unwind-protect boundary.
4908 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4909 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4910 inside an unwind-protected region.
4911 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4912 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4913 'leave' instead of a 'br' if unwind-protected.
4914 (Iterator.EmitYieldBreak): Likewise.
4916 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4918 * driver.cs: Only define versioninfo resources if no win32 resource
4921 2008-03-28 Marek Safar <marek.safar@gmail.com>
4923 A fix for bug #372375
4924 * convert.cs: Fixed boxing of nullable types.
4926 2008-03-28 Marek Safar <marek.safar@gmail.com>
4928 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4931 2008-03-28 Marek Safar <marek.safar@gmail.com>
4933 A fix for bug #374619
4934 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4936 2008-03-27 Marek Safar <marek.safar@gmail.com>
4938 * lambda.cs: Check return type only for invocation.
4940 2008-03-27 Marek Safar <marek.safar@gmail.com>
4942 A fix for bug #374214
4943 * ecore.cs: Correctly report argument type mismatch.
4945 2008-03-27 Marek Safar <marek.safar@gmail.com>
4947 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4948 and not rely on broken IsEnum.
4950 2008-03-27 Marek Safar <marek.safar@gmail.com>
4952 * nullable.cs: New file, extracted from generic.cs.
4954 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4956 2008-03-27 Marek Safar <marek.safar@gmail.com>
4958 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4959 predefined comparison operators and null literals.
4961 * report.cs: New warning ID.
4963 2008-03-25 Marek Safar <marek.safar@gmail.com>
4965 A fix for bug #370577
4966 * lambda.cs: Check return type too.
4968 2008-03-25 Marek Safar <marek.safar@gmail.com>
4970 A fix for bug #372846
4971 * class.cs: Automatic properties can be declared as unsafe.
4973 2008-03-20 Marek Safar <marek.safar@gmail.com>
4975 * location.cs: Use string based concatenation.
4977 * expression.cs: LiftedBinaryOperator is gmcs only.
4979 2008-03-20 Marek Safar <marek.safar@gmail.com>
4981 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4982 conversions rules and expression trees.
4984 2008-03-19 Marek Safar <marek.safar@gmail.com>
4986 * delegate.cs: Use extension method source as delegate target.
4988 2008-03-19 Marek Safar <marek.safar@gmail.com>
4990 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4991 binary operations to be purely based on binary operations and optimized
4992 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4993 and other ET refactoring.
4995 * typemanager.cs: Fixed warning.
4997 2008-03-17 Marek Safar <marek.safar@gmail.com>
4999 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5001 * symbolwriter.cs: Fixed.
5003 2008-03-17 Marek Safar <marek.safar@gmail.com>
5005 * anonymous.cs, driver.cs: Reset anonymous types counters.
5007 2008-03-17 Marek Safar <marek.safar@gmail.com>
5009 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5011 * class.cs: Use fullname for all type member definitions.
5013 2008-02-19 Martin Baulig <martin@ximian.com>
5016 (IMethodData.EmitExtraSymbolInfo): New interface method.
5017 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5018 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5019 interface method here as an empty public virtual method.
5022 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5023 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5024 CodeGen.SymbolWriter.SetRealMethodName().
5026 2008-02-18 Martin Baulig <martin@ximian.com>
5029 (ScopeInfo.EmitType): Override this and emit debugging
5030 information for captured variables.
5031 (RootScopeInfo.EmitType): Override this and emit symbol
5032 information for a captured `this'.
5034 2008-02-15 Martin Baulig <martin@ximian.com>
5036 * iterators.cs: Emit debugging info.
5039 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5040 (EmitContext.OmitDebuggingInfo): New public property.
5043 (While): Override Emit() and don't emit symbol info there; do it
5044 inside DoEmit() instead.
5045 (Block.Emit): Omit symbol information while emitting the scope
5046 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5048 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5049 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5050 .ctor to make `IsIterator' work.
5052 2008-03-14 Martin Baulig <martin@ximian.com>
5054 * symbolwriter.cs: Added the new symbol writer function from the
5055 debugger's `terrania' branch; temporarily enclose them inside
5056 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5059 2008-03-14 Martin Baulig <martin@ximian.com>
5062 (SymbolWriter): Make this a public static class.
5065 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5066 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5068 2008-03-14 Marek Safar <marek.safar@gmail.com>
5070 A fix for bug #370577
5071 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5074 2008-03-14 Marek Safar <marek.safar@gmail.com>
5076 * typemanager.cs (CSharpName): Made 250 times faster.
5078 2008-03-13 Marek Safar <marek.safar@gmail.com>
5080 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5082 2008-03-12 Marek Safar <marek.safar@gmail.com>
5084 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5085 crash when predefined field does not exist.
5087 2008-03-12 Marek Safar <marek.safar@gmail.com>
5089 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5091 2008-03-12 Marek Safar <marek.safar@gmail.com>
5093 * class.cs (FixedField): Don't crash when contructors are missing.
5095 2008-03-11 Marek Safar <marek.safar@gmail.com>
5097 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5098 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5099 check internal types accessibility for internal and external types.
5100 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5102 2008-03-11 Marek Safar <marek.safar@gmail.com>
5104 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5105 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5106 attribute.cs, statement: Use corect instance of predefined types (work
5107 related to #364674).
5109 2008-03-07 Marek Safar <marek.safar@gmail.com>
5111 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5113 2008-03-07 Marek Safar <marek.safar@gmail.com>
5115 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5116 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5117 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5118 predefined types clean up, delayed predefined types members initialization
5119 (work related to #364674).
5121 2008-03-05 Marek Safar <marek.safar@gmail.com>
5123 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5125 2008-03-05 Marek Safar <marek.safar@gmail.com>
5127 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5128 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5129 predefined types clean up (work related to #364674).
5131 2008-03-04 Marek Safar <marek.safar@gmail.com>
5133 * ecore.cs: Print an error message instead of throwing exception.
5135 2008-03-04 Marek Safar <marek.safar@gmail.com>
5137 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5138 expression.cs, statement.cs: Unififed null literal representation.
5140 2008-03-03 Marek Safar <marek.safar@gmail.com>
5142 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5143 expression.cs: Refactored binary operators resolve phase and improved speed.
5144 The nullable code is still missing and won't work correctly, more fixes
5147 It also fixes #323726, #324312, #324248, and many other unreported issues.
5149 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5151 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5154 2008-02-27 Marek Safar <marek.safar@gmail.com>
5156 * ecore.cs: Clean-up and split BetterConversion.
5158 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5161 * enum.cs (EnumMember.Value): Only access 'value' if
5162 ResolveValue says it's ok.
5163 (EnumMember.DoResolveValue): Don't set prev_member.value.
5164 (Enum.GetDefinition): Reverse arguments of Equals --
5165 EnumMember.Value can return 'null'.
5167 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5169 2008-02-22 Marek Safar <marek.safar@gmail.com>
5171 * generic.cs, expression.cs: More ongoing work on expression trees.
5173 2008-02-21 Marek Safar <marek.safar@gmail.com>
5175 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5176 handle missing matches when mutiple operators exist.
5178 2008-02-20 Marek Safar <marek.safar@gmail.com>
5180 A fix for bug #363218
5181 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5184 2008-02-20 Marek Safar <marek.safar@gmail.com>
5186 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5187 update. This time to deal correctly with SideEffectConstant expression used
5188 as an argument for another constant folding.
5190 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5192 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5195 2008-02-19 Marek Safar <marek.safar@gmail.com>
5197 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5199 2008-02-19 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #328136
5202 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5203 side is a false constant, because we still need to evaluate the right-hand
5206 * statement.cs (If): Emit two types of boolean constants (simple constant,
5207 side-effect constant).
5209 2008-02-19 Marek Safar <marek.safar@gmail.com>
5211 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5213 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5216 2008-02-18 Marek Safar <marek.safar@gmail.com>
5218 A fix for bug #361457
5219 * ecore.cs (IsApplicable): Params methods have lower priority.
5221 * support.cs: Return correct parameter modifier for params types.
5223 2008-02-18 Marek Safar <marek.safar@gmail.com>
5225 * generic.cs (TypeParameter): Cache attribute target name.
5227 * support.cs: Removed unused variable.
5229 * typemanager.cs: Removed debugging leftover.
5231 * ecore.cs: Use local type instead of a property;
5233 * class.cs (VerifyMembers): Consider also parent to test whether type member
5236 * expression.cs (FullMethodDesc): Removed.
5238 * attribute.cs (IsValidArgumentType): Made static.
5240 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5242 Cleanup to be more readable.
5243 * Makefile (GMCS_PROFILE): Remove.
5244 (COMPILER_NAME): New helper.
5246 2008-02-15 Miguel de Icaza <miguel@novell.com>
5248 * cs-tokenizer.cs: if a conditional expression happens inside a
5249 (...) this also means that we do not need to de-ambiguate between
5250 an parenthesized expression and a cast.
5254 * constant.cs (SideEffectConstant): a constant value that happens
5255 to have a side effect.
5257 Fixes the build regressions introduced by the fix for #359789
5259 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5261 * expression.cs (Conditional.Emit): when emitting the ternary
5262 operator, use local variables to generate code verifiable code.
5264 The verifier cannot infer that the type on stack before the
5265 stloc.0 is executed is of type ParentB. This happens because the
5266 stack merge algorithm uses only parent types when deciding which
5267 is the common type. This is described in Part III 1.8.1.3 of ECMA
5270 This code compiled with mcs is not verifiable under MS. The MS
5271 verifier picks the first common interface of Foo and Bar, which is
5272 wrong, but doesn't use a full join type of the 2 interfaces.
5274 CSC uses a clever hack to compile such code in a verifiable
5275 way. It stores the intermediate values in a local variable with
5280 2008-02-14 Miguel de Icaza <miguel@novell.com>
5282 * expression.cs: Do not fold BitwiseAnd operators when the left
5283 side is a false constant, because we still need to evaluate the
5288 * support.cs: Instead of throwing an InternalErrorException when
5289 the position of the stream is outside the boundary of our buffer,
5290 reset the state of the reader, and restart the reading from the
5291 beginning of the file.
5293 2008-02-14 Marek Safar <marek.safar@gmail.com>
5295 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5297 2008-02-14 Marek Safar <marek.safar@gmail.com>
5299 A fix for bug #361686
5300 * decl.cs: A protected types used inside a private class which parents
5301 derives from the protected class are accessible.
5303 2008-02-13 Marek Safar <marek.safar@gmail.com>
5305 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5306 the parameterless constructor.
5308 2008-02-13 Marek Safar <marek.safar@gmail.com>
5310 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5311 lookup methods to use standard member cache when doing member lookup.
5313 2008-02-12 Marek Safar <marek.safar@gmail.com>
5315 * driver.cs: Don't report full path for referenced module as assembly error.
5317 2008-02-12 Marek Safar <marek.safar@gmail.com>
5319 * Makefile: Fixed `qh' target to work on all machines.
5321 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5322 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5323 and HasElementType with TypeManager implementation.
5325 2008-02-08 Marek Safar <marek.safar@gmail.com>
5327 A fix for bugs #325134, #359749
5328 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5329 first binds point to non-method member expression.
5331 2008-02-08 Marek Safar <marek.safar@gmail.com>
5333 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5335 2008-02-08 Marek Safar <marek.safar@gmail.com>
5337 A fix for bugs #321394, #323028
5338 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5339 Reworked naive IsAccessibleAs implementation to handle nested types.
5341 2008-02-05 Jb Evain <jbevain@novell.com>
5343 * class.cs: use generic type comparison for parameters
5346 2008-02-05 Marek Safar <marek.safar@gmail.com>
5348 A fix for bug #325372
5349 * class.cs: Use generic type comparison when testing method signatures.
5351 2008-02-05 Marek Safar <marek.safar@gmail.com>
5353 A fix for bug #357047
5354 * ecore.cs: Applied C# 3.0 changes to better conversion.
5356 2008-02-05 Marek Safar <marek.safar@gmail.com>
5358 A fix for bug #358374
5359 * cs-parser.jay: Correctly set modifiers for all constructor types.
5361 2008-02-04 Marek Safar <marek.safar@gmail.com>
5363 A fix for bug #355251
5364 * generic.cs: Added base class constraint based type inference.
5366 2008-02-01 Marek Safar <marek.safar@gmail.com>
5368 A fix for bug #357255
5369 * decl.cs: One more missing visibility check.
5371 2008-02-01 Marek Safar <marek.safar@gmail.com>
5373 * support.cs: Fixed broken return.
5375 2008-01-25 Marek Safar <marek.safar@gmail.com>
5377 * report.cs: Correctly reset warnings count after probing.
5379 2008-01-25 Martin Baulig <martin@ximian.com>
5382 (NamespaceEntry.SymbolFileID): Make this work again after
5383 MemberName.ToString() is gone.
5385 2008-01-25 Marek Safar <marek.safar@gmail.com>
5387 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5390 2008-01-25 Marek Safar <marek.safar@gmail.com>
5392 * generic.cs: Use full implicit conversion for type inference fixing.
5394 2008-01-24 Marek Safar <marek.safar@gmail.com>
5396 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5397 Fixed user operator conversions.
5399 2008-01-24 Marek Safar <marek.safar@gmail.com>
5401 * generic.cs: Do nullable type to null comparison optimization during
5404 2008-01-24 Marek Safar <marek.safar@gmail.com>
5406 A fix for bug #355163
5407 * generic.cs: Enabled l-value resolve on nullable expressions.
5409 2008-01-24 Marek Safar <marek.safar@gmail.com>
5411 A fix for bug #353986
5412 * class.cs: Ingore static ctors with parameters for any further checks.
5414 2008-01-24 Marek Safar <marek.safar@gmail.com>
5416 A fix for bug #354310
5417 * namespace.cs: Removed redundant check.
5419 2008-01-24 Marek Safar <marek.safar@gmail.com>
5421 A fix for bug #354928
5422 * expression.cs: ElementInitializers can be resolved only once.
5424 2008-01-24 Marek Safar <marek.safar@gmail.com>
5426 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5427 Condition expressions.
5429 2008-01-23 Marek Safar <marek.safar@gmail.com>
5431 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5433 2008-01-22 Marek Safar <marek.safar@gmail.com>
5435 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5438 * generic.cs: Implemented coalesce expression.
5440 2008-01-22 Marek Safar <marek.safar@gmail.com>
5442 A fix for bug #355145
5443 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5444 expression tree type inference.
5446 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5449 * expression.cs (Binary.IsUnsignedType): Fix typo.
5451 2008-01-22 Marek Safar <marek.safar@gmail.com>
5453 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5455 2008-01-22 Marek Safar <marek.safar@gmail.com>
5457 A fix for bug #355161
5458 * ecore.cs, expression.cs: Wider range of extension method supported
5461 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5463 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5464 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5467 2008-01-22 Marek Safar <marek.safar@gmail.com>
5469 A fix for bug #355148
5470 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5472 2008-01-22 Miguel de Icaza <miguel@novell.com>
5474 * expression.cs (CreateExpressionTree): Add support for or and
5475 logical or, and indent following the coding conventions.
5477 * typemanager.cs (LinqExpression): renamed from
5478 ExpressionTreeManager, for a shorter name.
5480 Use TypeManager.CoreLookupType to lookup types from our core
5481 assemblies and turn those into "Type" variables.
5483 Consumers that previously used "Namespace" and "Type" from this
5484 class should instead use the TypeExpression which is a type that
5485 is fully resolved (without involving the regular C# resolution
5488 This typically looks like this:
5490 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5491 new MemberAccess (texpr, name, type_arguments, loc)
5493 This avoids the problem in: #355178
5495 2008-01-21 Marek Safar <marek.safar@gmail.com>
5497 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5498 feature in parser only as we do in other cases.
5500 2008-01-21 Marek Safar <marek.safar@gmail.com>
5502 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5503 typemanager.cs: A refactoring of params arguments to reuse existing
5504 expressions (params -> array initializer) to emit params argument instead
5505 of specialized handling.
5506 It was required by expression tree implementation and it has other benefits
5507 as well, we now apply same optimization for params arguments as we do for
5510 2008-01-18 Marek Safar <marek.safar@gmail.com>
5512 A fix for bug #353526
5513 * generic.cs: A type inference of params arguments may not required any
5514 temporary array creation.
5516 2008-01-18 Marek Safar <marek.safar@gmail.com>
5518 A fix for bug #353534
5519 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5520 supported for delegates only.
5522 2008-01-18 Marek Safar <marek.safar@gmail.com>
5524 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5525 type for more than 1 candidates.
5527 2008-01-18 Marek Safar <marek.safar@gmail.com>
5529 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5532 2008-01-16 Marek Safar <marek.safar@gmail.com>
5534 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5535 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5536 operator) expressions.
5538 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5540 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5541 not accessed from the generated IL.
5543 2008-01-14 Marek Safar <marek.safar@gmail.com>
5545 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5546 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5547 statement.cs: The first expression tree implementation drop, mostly
5548 infrastructure work.
5550 2008-01-14 Marek Safar <marek.safar@gmail.com>
5552 * ecore.cs (IsNestedChild): Refactored.
5554 2008-01-11 Marek Safar <marek.safar@gmail.com>
5556 * lambda.cs: Don't use a cast on unknown expression statement.
5558 2008-01-10 Geoff Norton <gnorton@novell.com>
5560 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5563 2008-01-09 Marek Safar <marek.safar@gmail.com>
5565 * doc.cs: Report better /doc crash details.
5567 2008-01-09 Marek Safar <marek.safar@gmail.com>
5569 A fix for bug #352536
5570 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5572 2008-01-08 Marek Safar <marek.safar@gmail.com>
5574 A fix for bug #352287
5575 * ecore.cs, expression.cs: Do `this' access checking in all member access
5578 2008-01-08 Marek Safar <marek.safar@gmail.com>
5580 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5582 * report.cs: Reset message stacks.
5584 2008-01-08 Marek Safar <marek.safar@gmail.com>
5586 * generic.cs (InferInPhases): Correctly calculate params position.
5588 2008-01-08 Marek Safar <marek.safar@gmail.com>
5590 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5593 2008-01-07 Marek Safar <marek.safar@gmail.com>
5595 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5597 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5599 * driver.cs: Updated --help option.
5601 2008-01-07 Marek Safar <marek.safar@gmail.com>
5603 * generic.cs (InferParamsTypeArguments): Removed.
5604 (InferInPhases): Add params type inference.
5605 (LowerBoundInference): Fixed scoring mechanism.
5607 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5609 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5611 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5612 byte array for unsigned "baked" assemblies.
5614 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5616 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5617 array for assemblies that are not strongnamed.
5619 2008-01-04 Marek Safar <marek.safar@gmail.com>
5621 A fix for bug #351481
5622 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5623 declaring type for nested generic types.
5625 2008-01-04 Marek Safar <marek.safar@gmail.com>
5627 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5628 instead of ToString.
5630 2008-01-03 Marek Safar <marek.safar@gmail.com>
5632 A fix for bug #351047
5633 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5634 null and structs only when equality and inequality operators are defined
5635 either as an user-operators or predefined operators.
5637 2008-01-03 Marek Safar <marek.safar@gmail.com>
5639 A fix for bug #351047
5640 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5642 2008-01-03 Marek Safar <marek.safar@gmail.com>
5644 A fix for bug #351257
5645 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5647 2008-01-03 Marek Safar <marek.safar@gmail.com>
5649 A fix for bug #351157
5650 * class.cs (Using): Fixed yet another broken cloning.
5652 (Block): Put back more sensible default value for statements.
5654 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5656 * codegen.cs: Allow AssemblyVersion with only major version component.
5659 2007-12-29 Marek Safar <marek.safar@gmail.com>
5661 A fix for bug #324654
5662 * class.cs: Use FullName property as member name.
5664 2007-12-28 Marek Safar <marek.safar@gmail.com>
5666 A fix for bug #342117
5667 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5668 constructor constraint.
5670 2007-12-28 Marek Safar <marek.safar@gmail.com>
5672 A fix for bug #338273
5673 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5676 2007-12-28 Marek Safar <marek.safar@gmail.com>
5678 A fix for bug #350839
5679 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5681 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5683 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5686 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5688 * statement.cs: Changed some Hashtables to use HybridDictionaries
5689 instead. It was observed that some HashTables only contained a few
5690 items in the vast majority of cases. Since HybridDictionary is
5691 more efficient on small sets (<10 elements), "known_variables"
5692 from class ExplicitBlock as well as "labels" and "constants " from
5693 class Block were changed to HybridDictionaries.
5695 Atsai results: (56216kb->54987kb)
5697 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5700 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5702 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5705 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5707 * expression.cs: foreach loop to for loop, saved on allocation of
5708 enumerator (59333kb->59141kb)
5710 * statement.cs. Changed foreach loops to for loops, saved on
5711 allocation of enumerator (59141kb->59006kb)
5713 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5714 when constructed with no specified capacity. This was causing a
5715 few ArrayLists to allocate more memory than they would potentially
5716 need in the Block class and MemberCache class. Setting the
5717 ArrayLists to construct with a capacity of 1 saves some
5718 memory. (56216kb->55585kb)
5720 2007-12-27 Marek Safar <marek.safar@gmail.com>
5722 A fix for bug #347189 (2nd issue)
5723 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5726 2007-12-27 Miguel de Icaza <miguel@novell.com>
5728 * report.cs: Do not use colors if stdout and stderr are not a
5731 2007-12-27 Marek Safar <marek.safar@gmail.com>
5733 A fix for bug #346998
5734 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5737 2007-12-27 Marek Safar <marek.safar@gmail.com>
5739 A fix for bug #343465
5740 * class.cs: Explicit method name for nested types uses dots only.
5742 2007-12-27 Marek Safar <marek.safar@gmail.com>
5744 A fix for bug #343707
5745 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5747 2007-12-27 Marek Safar <marek.safar@gmail.com>
5749 * ecore.cs: Report type inference errors only when arguments count matches
5752 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5754 * expression.cs, report.cs: New warning.
5756 * typemanager.cs: Catch anonymous method type too.
5758 2007-12-23 Marek Safar <marek.safar@gmail.com>
5760 A fix for bug #346379
5761 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5763 2007-12-23 Marek Safar <marek.safar@gmail.com>
5765 A fix for bug #347359
5766 * expression.cs (Invocation): Don't resolve already resolved expression.
5768 2007-12-23 Marek Safar <marek.safar@gmail.com>
5770 A fix for bug #347189
5771 * class.cs (FixedField): Use non-dependent code only in the define phase.
5773 2007-12-23 Marek Safar <marek.safar@gmail.com>
5775 A fix for bug #348076
5776 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5778 2007-12-22 Marek Safar <marek.safar@gmail.com>
5780 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5781 discovered extension methods.
5783 2007-12-22 Marek Safar <marek.safar@gmail.com>
5785 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5788 2007-12-21 Miguel de Icaza <miguel@novell.com>
5790 * report.cs (ErrorMessage): Add support for using colors on
5791 terminals that support it.
5793 2007-12-21 Marek Safar <marek.safar@gmail.com>
5795 * ecore.cs: Use information about expanded params for error reporting.
5797 2007-12-21 Marek Safar <marek.safar@gmail.com>
5799 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5800 and logic for params overloads.
5802 2007-12-15 Miguel de Icaza <miguel@novell.com>
5804 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5805 as this is also created from the parser. Fixes #349034
5807 2007-12-12 Miguel de Icaza <miguel@novell.com>
5809 * statement.cs (Throw.CloneTo): it is valid to have empty
5810 expressions for throw.
5812 2007-12-03 Marek Safar <marek.safar@gmail.com>
5814 * cs-parser.jay: Set delegate constraint parsing region correctly.
5816 2007-12-03 Marek Safar <marek.safar@gmail.com>
5818 A fix for bug #345467
5819 * typemanager.cs (IsEqual): Compare generic parameters position only.
5821 2007-11-28 Marek Safar <marek.safar@gmail.com>
5823 * expression.cs (BaseAccess): Type arguments can be null.
5825 2007-11-27 Raja R Harinath <harinath@gmail.com>
5827 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5828 consistent even when an error has occured.
5829 (Switch.Resolve): Likewise.
5831 2007-11-22 Marek Safar <marek.safar@gmail.com>
5833 A fix for bug #334505
5834 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5837 2007-11-22 Marek Safar <marek.safar@gmail.com>
5839 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5840 refactorings required to resolve extension methods correctly when mixing
5841 generics and non-generics members.
5843 2007-11-20 Marek Safar <marek.safar@gmail.com>
5845 A fix for bug #342584
5846 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5849 2007-11-19 Marek Safar <marek.safar@gmail.com>
5851 A fix for bug #342512
5852 * delegate.cs: Use delegate argument expression when is available. Don't
5853 emit virtual call when class is sealed.
5855 2007-11-16 Marek Safar <marek.safar@gmail.com>
5857 A fix for bug #325423
5858 * assign.cs (FieldInitializer): Use resolved expression for emit.
5860 * class.cs: Print less confusing error message.
5862 2007-11-16 Marek Safar <marek.safar@gmail.com>
5864 * cs-tokenizer.cs: Removed GMCS ifdefs.
5866 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5869 * cs-parser.jay: Disabled nullable check.
5871 * generic-mcs: Copied more generic stuff.
5873 2007-11-16 Marek Safar <marek.safar@gmail.com>
5875 * gcs-parser.jay: Merged to cs-parser.jay.
5877 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5878 * *.csproj, *.sources: Updated to use only jay parser file.
5880 2007-11-16 Marek Safar <marek.safar@gmail.com>
5882 * gcs-parser.jay: Added nullable and default expression feature checks.
5884 2007-11-16 Marek Safar <marek.safar@gmail.com>
5886 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5887 it fixes many TODOs and hidden bugs.
5889 * expression: Removed duplicate error check.
5891 2007-11-15 Marek Safar <marek.safar@gmail.com>
5893 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5894 implicitly type local variable only when it is used in a declaration.
5896 2007-11-15 Marek Safar <marek.safar@gmail.com>
5898 * attribute.cs: Use CS0612 for empty strings.
5900 2007-11-14 Marek Safar <marek.safar@gmail.com>
5902 * lambda.cs, statement.cs: Contextual return may act as a statement.
5904 2007-11-14 Marek Safar <marek.safar@gmail.com>
5906 A fix for a regression cause by #324222
5907 * class.cs: Don't report unused even when it implements an interface.
5909 2007-11-13 Marek Safar <marek.safar@gmail.com>
5911 A fix for bug #341205
5912 * ecore.cs, expression.cs: Method group expression cannot do static
5913 method access with an instance reference check before overloading takes
5916 2007-11-13 Marek Safar <marek.safar@gmail.com>
5918 A fix for bug #325359
5919 * class.cs: Use predictable name for automatically generated property.
5921 2007-11-12 Marek Safar <marek.safar@gmail.com>
5923 A fix for bug #324996
5924 * expression.cs (Is): Handle case where D is nullable and T is not
5927 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5929 2007-11-12 Marek Safar <marek.safar@gmail.com>
5931 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5932 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5933 Flush small error reporting changes.
5935 2007-11-09 Marek Safar <marek.safar@gmail.com>
5937 A fix for bug #324996
5938 * expression.cs: Rewrote Is expression implementation to work with
5939 generics, nullable types, anonymous method. A const result expression
5940 uses existing infrastructure instead of custom not fully-featured one.
5942 2007-11-08 Marek Safar <marek.safar@gmail.com>
5944 A fix for bug #340202
5945 * class.cs: Consider generics for volatile field.
5947 2007-11-08 Marek Safar <marek.safar@gmail.com>
5949 A fix for bug #335594
5950 * expression.cs: Use conversion rules when handling string addition.
5952 2007-11-07 Marek Safar <marek.safar@gmail.com>
5954 A fix for bug #336651
5955 * expression.cs: Fixed a crash when probing is on.
5957 2007-11-07 Marek Safar <marek.safar@gmail.com>
5959 A fix for bug #324242
5960 * covert.cs: Added a conversion from any nullable-type with an
5961 underlying enum-type to the type System.Enum.
5963 2007-11-07 Marek Safar <marek.safar@gmail.com>
5965 A fix for bug #324222
5966 * class.cs: Report all non-used event fields.
5968 2007-11-07 Marek Safar <marek.safar@gmail.com>
5970 A fix for bug #325161
5971 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5972 qualifier for generic types.
5974 2007-11-07 Marek Safar <marek.safar@gmail.com>
5976 A fix for bug #322971
5977 * expression.cs, ecore.cs: Added intermediate result value check for
5980 2007-11-07 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #324754
5983 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5984 when it was requested.
5986 2007-11-07 Marek Safar <marek.safar@gmail.com>
5988 A fix for bug #325101
5989 * expression.cs: Do type not value comparison for `is' expression.
5991 2007-11-07 Marek Safar <marek.safar@gmail.com>
5993 A fix for bug #320236
5994 * convert.cs: Don't apply user conversion on underlying target type.
5996 2007-11-06 Marek Safar <marek.safar@gmail.com>
5998 * expression.cs: Don't use unresolved expression for error reporting.
6000 2007-11-06 Marek Safar <marek.safar@gmail.com>
6002 A fix for bugs #337712, #324490
6003 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6004 overloading resolution too.
6006 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6007 the process consistent and more robust.
6009 * expression.cs, linq.cs, report.cs: Update.
6011 2007-11-02 Marek Safar <marek.safar@gmail.com>
6013 A fix for bug #332909
6014 * attribute.cs: Resolve attributes in correct context using error
6017 * rootcontext.cs: Define Obsolete attribute members as core members.
6019 2007-11-02 Marek Safar <marek.safar@gmail.com>
6021 * statement.cs: Removed unused methods.
6023 2007-10-31 Wade Berrier <wberrier@novell.com>
6025 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6026 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6029 2007-10-31 Marek Safar <marek.safar@gmail.com>
6031 A fix for bug #338102
6032 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6033 methods registered as non-generics.
6035 2007-10-31 Marek Safar <marek.safar@gmail.com>
6037 A fix for bugs #337712, #324490
6038 * delegate.cs: Delegate covariance and contravariance is not allowed for
6041 2007-10-31 Marek Safar <marek.safar@gmail.com>
6043 A fix for bug #337719
6044 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6047 2007-10-30 Marek Safar <marek.safar@gmail.com>
6049 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6051 2007-10-29 Marek Safar <marek.safar@gmail.com>
6053 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6056 2007-10-29 Raja R Harinath <rharinath@novell.com>
6058 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6060 2007-10-29 Marek Safar <marek.safar@gmail.com>
6062 A fix for bug #334652
6063 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6064 extension methods when we have not found the best candidate in normal
6067 2007-10-27 Marek Safar <marek.safar@gmail.com>
6069 * AssemblyInfo.cs: Keep up-to-date.
6071 2007-10-27 Marek Safar <marek.safar@gmail.com>
6073 * Makefile: Fixed generics compiler name.
6075 2007-10-27 Marek Safar <marek.safar@gmail.com>
6077 * lambda.test: removed, lambda parsing is done differently.
6079 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6081 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6083 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6085 2007-10-27 Marek Safar <marek.safar@gmail.com>
6087 * Makefile, *.sources : All C# compilers are in mcs folder.
6089 * *.cs: Use existing 2_1 define for smcs.
6091 2007-10-26 Marek Safar <marek.safar@gmail.com>
6093 A fix for bug #335847
6094 * assign.cs, expression.cs: Couple of changes to avoid creating a
6095 temporary variable for each object initializer assignment statement. It
6096 simplifies struct initialization too, otherwise two temporary variables
6098 Implemented optimization of redundant default element initializers.
6100 2007-10-25 Marek Safar <marek.safar@gmail.com>
6102 A fix for bug #336766
6103 * expression.cs (Class.CheckBase): Use generic name when method is
6106 2007-10-25 Marek Safar <marek.safar@gmail.com>
6108 A fix for bug #334737
6109 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6110 variable and not variable argument for prepared copies.
6112 2007-10-24 Marek Safar <marek.safar@gmail.com>
6114 A fix for bug #325110
6115 * class.cs, expression.cs, attribute.cs: Use open generic method when
6116 checking conditional attribute.
6118 2007-10-24 Marek Safar <marek.safar@gmail.com>
6120 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6121 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6122 FeatureIsNotAvailable.
6124 2007-10-24 Marek Safar <marek.safar@gmail.com>
6126 ** C# 3.0 Partial methods
6128 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6129 methods support. Because of member cache issue with generics only
6130 non-generics partial methods are fully supported.
6132 2007-10-23 Marek Safar <marek.safar@gmail.com>
6134 * class.cs, decl.cs: Rewrote member overloads check to cope with
6135 generics and to use member cache for member checking. It also improves
6136 performance and fixes remaining overloads issues.
6138 2007-10-20 Marek Safar <marek.safar@gmail.com>
6140 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6141 roottypes.cs, typemanager.cs:
6143 A member cache creation logic changed to add members immediately and
6144 not rely on fallback. The member cache is now only prefered way
6145 how to access and find type declaration members. It saves 5 MB of memory
6146 during MWF compilation and makes code ready for more optimizations and
6147 clean-ups, it's also a pre-requirement for partial methods.
6149 2007-10-18 Raja R Harinath <harinath@gmail.com>
6151 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6152 handling for generic parameters.
6154 2007-10-15 Marek Safar <marek.safar@gmail.com>
6156 * class.cs (FixedField): Removed redundant volatile check.
6158 2007-10-15 Marek Safar <marek.safar@gmail.com>
6160 * class.cs, decl.cs: Fixed overload members verification to do only one
6161 check per possible collision.
6163 2007-10-13 Marek Safar <marek.safar@gmail.com>
6165 A fix for bug #325478
6166 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6167 and create only one disposable flags container.
6169 2007-10-12 Marek Safar <marek.safar@gmail.com>
6171 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6172 * statement.cs (Fixed): Fixed variables cloning.
6174 2007-10-12 Marek Safar <marek.safar@gmail.com>
6176 A fix for bug #333342
6177 * class.cs (EventField): Don't mark value type event as synchronized.
6179 2007-10-12 Marek Safar <marek.safar@gmail.com>
6181 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6182 inference to identify best candidate method correctly.
6183 (ProperyExpr): A range variable is read only and cannot be modified.
6185 2007-10-11 Marek Safar <marek.safar@gmail.com>
6187 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6188 logic to identify best candidate method correctly.
6190 2007-10-11 Marek Safar <marek.safar@gmail.com>
6192 * location.cs (Equals, GetHashCode): Removed.
6194 2007-10-11 Marek Safar <marek.safar@gmail.com>
6196 * report.cs: Implemented message recorder. It is used mainly for lambda
6197 expressions to capture otherwise swallowed error messages.
6199 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6201 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6203 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6205 * expression.cs (MemberAccess): Always report lookup failure.
6207 * location.cs: Implemented Equals, GetHashCode.
6209 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6211 2007-10-10 Jb Evain <jbevain@novell.com>
6213 * codegen.cs: re-enable assembly version check.
6215 2007-10-09 Marek Safar <marek.safar@gmail.com>
6217 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6220 * namespace.cs (UsingAlias): Do correct version check.
6222 2007-10-08 Marek Safar <marek.safar@gmail.com>
6224 * expresison.cs, ecore.cs: Issue extension method error message when
6227 * rootcontext.cs: Added ISO_2 compiler mode option.
6229 2007-10-08 Marek Safar <marek.safar@gmail.com>
6231 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6234 2007-10-08 Marek Safar <marek.safar@gmail.com>
6236 * attribute.cs (GetString, GetBoolean): Work with both literal and
6239 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6240 Moved method overload specific methods to MethodGroupExpr.
6242 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6243 it should be less memory consuming.
6245 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6247 * codegen.cs: remove the assembly version check until the buildbot is
6250 2007-10-07 Jb Evain <jbevain@novell.com>
6252 * attribute.cs (Attribute.GetString): if the value
6253 expression is a StringConstant, return its string value.
6255 2007-10-07 Jb Evain <jbevain@novell.com>
6257 * typemanager.cs: add `assembly_version_attribute_type`.
6258 * codegen.cs: on attribute emission, check that the
6259 AssemblyVersionAttribute doesn't overflow.
6261 2007-10-05 Marek Safar <marek.safar@gmail.com>
6263 A fix for bug #324677
6264 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6265 parent container of a scope container with currently resolved one.
6267 2007-10-05 Marek Safar <marek.safar@gmail.com>
6269 A fix for bug #325534
6270 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6273 2007-10-05 Marek Safar <marek.safar@gmail.com>
6275 A fix for bug #327504
6276 * class.cs (Operator.Define): Refactored implicit and explicit user
6277 operator conversion rules.
6279 2007-10-05 Marek Safar <marek.safar@gmail.com>
6281 A fix for bug #327520
6282 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6284 2007-10-04 Marek Safar <marek.safar@gmail.com>
6286 A fix for bug #328022
6287 * class.cs (MethodData.Define): Use correct method to check whether
6288 a method implementents an accessor.
6290 2007-10-04 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #330069
6293 * statement.cs (Fixed.Resolve): Read the first array element only when
6294 an array is instantiated.
6296 2007-10-04 Marek Safar <marek.safar@gmail.com>
6298 * expression.cs, assign.cs, generics.cs: Print correct operator when
6299 compound assignment is used.
6301 2007-10-04 Marek Safar <marek.safar@gmail.com>
6303 A fix for bug #325841
6304 * expression.cs (ArrayAccess): Use full argument cloning only for
6305 string compound concatenation.
6307 2007-10-03 Marek Safar <marek.safar@gmail.com>
6309 A fix for bug #328774
6310 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6312 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6315 2007-10-03 Raja R Harinath <rharinath@novell.com>
6318 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6319 Event accessibility checks here. Remove some bogus code that
6320 accidently made GenericMethods work.
6321 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6323 2007-09-25 Marek Safar <marek.safar@gmail.com>
6325 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6327 * statement.cs (Block): Refactored AddVariable to allow error handling
6330 * generic.cs: New stub.
6332 2007-09-23 Marek Safar <marek.safar@gmail.com>
6334 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6337 2007-09-17 Marek Safar <marek.safar@gmail.com>
6339 * class.cs: Use partial container to record whether any partial part
6340 contains static field initializer and therefore default contructor has
6343 2007-09-14 Marek Safar <marek.safar@gmail.com>
6345 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6346 mono-list when only one of two partial parts has defined accessibility
6349 2007-09-14 Marek Safar <marek.safar@gmail.com>
6351 A fix for bug #82845
6353 * class.cs (TypeContainer): Set correct resolve context for all field
6356 2007-09-13 Marek Safar <marek.safar@gmail.com>
6358 * assign.cs: Fixed a crash when field is resolved twice with an error.
6360 * codegen.cs: Changed InFieldInitializer to be flag.
6362 * anonymous.cs, ecore.cs, expression.cs: Update after
6363 IsInFieldInitializer rename.
6365 * const.cs: Removed unused parameter.
6367 * class.cs: Changed the way how we resolve and emit field initializers.
6368 The field initilizers have to have access to contructor block to emit
6369 compiler generated code.
6371 2007-09-13 Marek Safar <marek.safar@gmail.com>
6373 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6374 generics use TypeContainer instead.
6376 2007-09-12 Marek Safar <marek.safar@gmail.com>
6378 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6380 * lambda.cs (ResolveParameters): Use more powerful
6381 InflateGenericArgument.
6383 * parameters.cs: Better exception message.
6385 2007-09-10 Marek Safar <marek.safar@gmail.com>
6387 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6388 correct expression block type.
6390 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6392 * expression.cs (Invocation): Extracted method group resolve to
6395 2007-09-07 Marek Safar <marek.safar@gmail.com>
6397 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6398 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6400 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6401 generic extension methods.
6403 2007-09-06 Marek Safar <marek.safar@gmail.com>
6405 A fix for bug #82676 (Do I get it right now?)
6406 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6407 object before a standard conversion is applied.
6409 2007-09-06 Marek Safar <marek.safar@gmail.com>
6411 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6414 2007-09-05 Marek Safar <marek.safar@gmail.com>
6416 A fix for bug #82676
6417 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6418 non-generic interface types.
6420 2007-09-05 Marek Safar <marek.safar@gmail.com>
6422 A fix for bug #82690
6423 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6425 2007-09-05 Marek Safar <marek.safar@gmail.com>
6427 A fix for bug #82571
6428 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6429 modifier for container based methods.
6431 2007-09-05 Marek Safar <marek.safar@gmail.com>
6433 A fix for bug #82676
6434 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6435 any interface-type T means to any of interface type T.
6437 2007-09-04 Marek Safar <marek.safar@gmail.com>
6439 * namespace.cs: We have 2 versions of System.Core assembly.
6441 2007-09-04 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #82652
6444 * class.cs (Class.GetClassBases): Compare types and not expressions.
6446 2007-09-04 Marek Safar <marek.safar@gmail.com>
6448 A fix for bug #82620
6449 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6450 actually never worked before.
6451 (IndexerAccess): Emit prepared arguments before they are modified.
6453 2007-09-04 Marek Safar <marek.safar@gmail.com>
6455 A fix for bug #82563
6456 * assign.cs: Revert wrong fix.
6458 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6460 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6461 Instead of ldelema/stdind we have to use temporary variables to handle
6462 cases like String.Concat (params string[]).
6464 2007-08-31 Marek Safar <marek.safar@gmail.com>
6466 * class.cs: EmitAttributes to Emit rename.
6468 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6470 (MemberCore.HasClsCompliantAttribute): Don't depend on
6471 GetClsCompliantAttributeValue execution.
6473 2007-08-31 Marek Safar <marek.safar@gmail.com>
6475 * anonymous.cs: Use shorter type prefix.
6477 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6480 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6481 variables when probing is on.
6483 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6484 unresolved variables.
6485 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6486 handle transparent identifiers.
6488 2007-08-26 Marek Safar <marek.safar@gmail.com>
6490 * attribute.cs (IsClsCompliant): Add nullable types test.
6492 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6494 * doc.cs : catch other types of exception than XmlException to
6495 report CS1570. Fixed bug #82565.
6497 2007-08-23 Marek Safar <marek.safar@gmail.com>
6499 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6500 The number of delegate parameters has to match.
6501 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6504 2007-08-21 Marek Safar <marek.safar@gmail.com>
6506 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6507 to fix problem with private arguments.
6509 2007-08-20 Marek Safar <marek.safar@gmail.com>
6511 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6513 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6515 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6516 empty. Add cloning suport.
6518 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6520 2007-08-20 Marek Safar <marek.safar@gmail.com>
6522 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6523 to create EmptyCast. It handles EmptyConstantCast specialization for
6526 2007-08-18 Marek Safar <marek.safar@gmail.com>
6528 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6529 (EmitArrayArgument): One routine for array arguments.
6530 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6532 2007-08-17 Marek Safar <marek.safar@gmail.com>
6534 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6536 2007-08-17 Marek Safar <marek.safar@gmail.com>
6538 * anonymous.cs: MemberLookupFinal update.
6540 * class.cs (ConstructorInitializer): Is expression based.
6542 * delegate.cs: MethodGroupExpr update.
6544 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6546 (Error_MemberLookupFailed): Customizable error override.
6547 (MethodGroupExpr): Keep queried type for later usage.
6548 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6551 * expression.cs: Error_MemberLookupFailed refactoring.
6552 (New.DoResolve): Resolve as much as possible.
6553 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6554 customization for invalid member types.
6556 * statement.cs: MethodGroupExpr update.
6558 2007-08-16 Marek Safar <marek.safar@gmail.com>
6560 * modifier.cs (Check): Check all modifiers and not only accessibility
6563 2007-08-16 Marek Safar <marek.safar@gmail.com>
6565 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6566 type and not an expression.
6568 2007-08-16 Marek Safar <marek.safar@gmail.com>
6570 * statement.cs (Catch.Clone): Type and variable can be null.
6572 2007-08-16 Marek Safar <marek.safar@gmail.com>
6574 A fix for bug #81979
6575 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6576 I am really not sure whether this is the best fix.
6578 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6581 2007-08-14 Marek Safar <marek.safar@gmail.com>
6583 ** C# 3.0 Object and collection initializers (major re-write)
6585 * assign.cs (DoResolve): Initializers are not assign related.
6587 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6588 used during collection or object initialization.
6590 * expression.cs (Error_InvalidArguments): Add initializers specific
6591 messages. More will come later because it requires some general
6593 (New.DoResolve): Better error handling for unsafe types.
6594 (EmptyExpressionStatement): New class.
6595 (ElementInitializer): An object initializer expression.
6596 (CollectionElementInitializer): A collection initializer expression.
6597 (CollectionOrObjectInitializers): A block of object or collection
6599 (NewInitialize): New expression with element/object initializers.
6601 * statement.cs: Reverted object/collection initializer hacks.
6603 * typemanager.cs (CSharpName): Filter __arglist type.
6605 2007-08-09 Marek Safar <marek.safar@gmail.com>
6607 ** C# 3.0 Anonymous Types (update to the latest standard)
6609 * expression.cs (Binary.ResolveOperator): Threat all null based types
6611 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6612 (AnonymousTypeParameter): Updated.
6614 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6615 (AnonymousTypeClass): New anonymous type container.
6617 * class.cs (AddField): Return operation result.
6619 * generic.cs: Another empty TypeArguments overload.
6621 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6622 are stored at top of normal hierarchy.
6624 * typemanager.cs (CSharpName): Filter anonymous types.
6626 2007-08-09 Marek Safar <marek.safar@gmail.com>
6628 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6629 as single Concat call. How could we miss that :-(
6631 2007-08-08 Marek Safar <marek.safar@gmail.com>
6633 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6635 2007-08-07 Miguel de Icaza <miguel@novell.com>
6637 * expression.cs: Fix the previous commit, the creation of the
6638 arguments array list needs also to be conditional on the arguments
6641 * class.cs: Add a little bit of help to help narrow down problems.
6643 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6644 not try to copy in that case.
6646 * driver.cs: When building SMCS, include a new different set of
6647 default assemblies here. Do this here so we can control whether
6648 to include the default assemblies with /noconfig.
6650 2007-08-03 Marek Safar <marek.safar@gmail.com>
6652 A fix for bug #81979
6653 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6656 2007-08-03 Marek Safar <marek.safar@gmail.com>
6658 A fix for bug #82300
6660 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6661 we are in probing scope.
6663 2007-08-03 Marek Safar <marek.safar@gmail.com>
6665 A fix for bug #82301
6667 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6668 (Statement.CloneTo): Clone and not map children blocks.
6670 2007-08-03 Marek Safar <marek.safar@gmail.com>
6672 A fix for bug #82299
6674 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6677 * statement.cs (Statement.CloneTo): Clone variables before statements
6678 to allow remaping of local variables.
6680 2007-08-03 Marek Safar <marek.safar@gmail.com>
6682 A fix for bug #82296
6685 * report.cs: Log crash details for future clone problems.
6687 * statement.cs (Return.Clone): Don't clone non-existent expression.
6689 2007-08-03 Raja R Harinath <harinath@gmail.com>
6691 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6692 (Class.AddBasesForPart): Move CS0537 check here from ...
6693 * cs-parser.jay (class_declaration): ... here. Move calling of
6694 'AddBasesForPart' to ...
6695 (class_bases): ... here.
6696 (struct_declaration, interface_declaration): Update to changes.
6698 2007-08-02 Marek Safar <marek.safar@gmail.com>
6700 A fix for bug #81923
6702 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6703 conversion is allowed.
6705 2007-08-02 Marek Safar <marek.safar@gmail.com>
6707 A fix for bug #81564
6709 * ecore.cs (EventExpr): Add IsBase handling.
6711 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6714 2007-08-02 Raja R Harinath <harinath@gmail.com>
6716 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6717 * cs-parser.jay: Some whitespace cleanups.
6718 (current_delegate): New.
6720 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6721 a dummy code block, and use 'type_name' instead of 'member_name'.
6722 (interface_declaration, class_declaration): Likewise.
6723 (delegate_declaration): Likewise. Rearrange slightly and use
6725 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6726 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6728 2007-08-02 Marek Safar <marek.safar@gmail.com>
6730 A fix for bug #82039
6732 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6735 * typemanager.cs (CSharpName): Split to string overload.
6737 2007-08-02 Marek Safar <marek.safar@gmail.com>
6740 * report.cs: Updated warning CS0472.
6742 2007-08-01 Marek Safar <marek.safar@gmail.com>
6744 A fix for bug #82181
6746 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6748 2007-08-01 Marek Safar <marek.safar@gmail.com>
6750 A fix for bug #82277
6751 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6753 2007-08-01 Marek Safar <marek.safar@gmail.com>
6755 ** C# 3.0 Type Inference (major bits are working)
6757 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6758 (.ImplicitStandardConversionExists): Uses compatible.
6759 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6760 (.InferReturnType): New method.
6761 (.Compatible): Refactored.
6762 (.ResolveParameters): Uses factory to create resolved parameters.
6763 (.CompatibleMethod): Add probing mode support.
6764 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6765 clearly distinguish between 2 different operations.
6766 (LambdaMethod): Moved to lambda.cs.
6767 (AnonymousMethod): Removed unused fields and methods.
6768 (AnonymousDelegate): Simplified.
6770 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6772 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6774 * delegate.cs (Delegate): New mehods to reduce code duplication.
6775 (.GetConstructor): New method.
6776 (.GetInvokeMethod): New method.
6777 (DelegateCreation): Updated.
6779 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6781 (OverloadResolve): Made probing little bit faster.
6783 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6786 * generic.cs (TypeInferenceContext): Dummy implementation.
6788 * iterators.cs: Updated after Resolve/Define rename.
6790 * lambda.cs (LambdaExpression)
6791 (.ResolveParameters): Handles both type of arguments and type inference too.
6793 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6794 (InflateTypes): Updated.
6796 * support.cs (InflateTypes): Changed signature and updated.
6798 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6799 (MemberLookup_FindMembers): More MS tricks.
6800 (GetParameterData): Ditto.
6801 (GetDelegateParameters): Uses quick path for dynamic types.
6803 2007-08-01 Marek Safar <marek.safar@gmail.com>
6805 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6808 2007-07-31 Marek Safar <marek.safar@gmail.com>
6810 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6813 2007-07-26 Jb Evain <jbevain@novell.com>
6815 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6816 which takes a boolean 'report_errors', similar to the GetMethod.
6817 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6818 in .net 2.1, do not report errors here.
6820 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6821 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6822 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6825 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6826 of the type InternalsVisibleToAttribute before the first call
6827 to CoreLookupType which is allowed to fail (third boolean parameter
6828 to true). Because, during the resolution for a type that is not
6829 immediately found, we try to check if the type is not defined in
6830 a friend assembly, and to do so, we need the
6831 InternalVisibleToAttribute.
6833 2007-07-23 Miguel de Icaza <miguel@novell.com>
6835 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6836 feature that allows structs to be compared against null and inline
6837 the result as true or false.
6839 Notice that the same code is not permitted inside a generic block
6840 of code that would do:
6842 class Foo<T> where T : struct {
6849 It is only allowed if the type of T is not bound (no where
6850 clause). In my opinion, this CSC 2 behavior is broken but people
6851 seem to be using it (IronRuby does, a few bug reports on bugzilla
6852 have it and some people have complained about it).
6854 All of the users that depend on this behavior have code that is
6857 * report.cs (Warning, Error): make these take object arguments,
6858 not strings, as that allows us to take advantage of Format.
6860 2007-07-20 William Holmes <billholmes54@gmail.com>
6862 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6863 Left member variable for the Count.
6864 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6865 MemberName.CountTypeArguments to avoid a NRE.
6867 This code is contributed under the MIT X11 license
6869 2007-07-18 Marek Safar <marek.safar@gmail.com>
6871 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6873 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6875 * doc.cs : generic method arguments are written as ``x while generic
6876 type arguments are `x. Combined with the previous change, fixed bug
6879 2007-07-18 Raja R Harinath <rharinath@novell.com>
6882 * expression.cs (Binary.ResolveOperator): When converting
6883 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6885 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6887 * doc.cs : when T: or whatever x: is specified, it does not really
6888 check the doc comment's syntax correctness. Fixed bug #82006.
6890 2007-07-18 Marek Safar <marek.safar@gmail.com>
6892 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6893 LambdaExpression better.
6895 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6897 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6899 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6900 as it can be generated.
6902 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6905 * lambda.cs (LambdaExpression): Refactored to share same code with
6906 AnonymousMethodExpression.
6908 2007-07-17 Marek Safar <marek.safar@gmail.com>
6910 * anonymous.cs (MakeName): Include host name for easier debugging.
6911 (LambdaMethod): New class for lambda spcecific stuff.
6913 * attribute.cs: Set EmitContext return type.
6915 * class.cs: Set EmitContext return type.
6917 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6918 with null/void meaning.
6920 * iterators.cs (ContainerType): Implemented.
6922 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6924 * statement.cs (Return): Updated to lambda expressions.
6925 (Block.CloneTo): Parent can be null.
6927 2007-07-13 Marek Safar <marek.safar@gmail.com>
6929 A fix for bug #81917
6930 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6932 * class.cs (FixedField): Check whether field is in unsafe scope.
6934 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6935 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6937 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6940 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6942 2007-07-13 Marek Safar <marek.safar@gmail.com>
6944 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6945 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6948 2007-07-13 Marek Safar <marek.safar@gmail.com>
6950 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6952 2007-07-13 Marek Safar <marek.safar@gmail.com>
6954 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6955 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6957 * codegen.cs(EmitContext): Add ProbingMode flag.
6959 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6961 * driver.cs: For now set both warning values.
6963 * ecore.cs (SimpleName): Name is readonly.
6964 (MethodGroup.OverloadResolve): One quick path for probing.
6966 * expression.cs (Unary): Set Oper r/o.
6967 (Binary): Set Oper r/o.
6968 (ParameterReference): Set few instance variables as r/o.
6969 (ParameterReference.DoResolveBase): Don't capture aruments when
6971 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6972 (Arglist): arguments are private.
6973 (SizeOf): type is private and r/o.
6974 (MemberAccess): arguments are private.
6976 * report.cs: Enhanced reporting on/off capabilities.
6978 * lambda.cs: Uses ec.IsInProbingMode.
6979 (ContextualReturn): Derives from return.
6981 * rootcontext.cs: For now set both warning values.
6983 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6985 (Return.Resolve): Don't die immediately.
6986 (Block.Resolve): Speed-up probing.
6987 (Block.CloneTo): Clone only child blocks.
6989 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6991 * iterators.cs: reverted Miguel's latest change (r81925) as it
6992 breaks the build in System.
6994 2007-07-13 Miguel de Icaza <miguel@novell.com>
6996 * iterators.cs (Yield.CheckContext): Check for the iterator type
6997 also here as we can call into Yield even in codepaths that are not
6999 (MethodOrOperator is the only path that was checked).
7001 In addition to the standard check, use a more specific check for
7002 constructors to report a more verbose error.
7004 2007-07-12 Miguel de Icaza <miguel@novell.com>
7006 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7007 report the warning and continue
7009 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7010 values on the stack on the call to Emit. Use EmitStatement if
7011 possible, or using Emit + Pop if not possible. Fixes #82064
7013 2007-07-12 Raja R Harinath <rharinath@novell.com>
7015 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7016 avoid try...finally in some cases.
7018 2007-07-10 Marek Safar <marek.safar@gmail.com>
7020 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7022 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7023 instead of method. Re-use standard error handling.
7024 (ConstructorInitializer.Emit): Simplified.
7026 * delegate.cs: Updated after Invocation.EmitCall change.
7028 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7029 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7030 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7031 method and don't permanently changing input arguments.
7032 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7033 is resolved it has one of the candidates is the best one which is later
7034 used to emit. Removed a few unused method.
7035 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7037 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7038 (Binary.ResolveOperator): Ditto.
7039 (ConditionalLogicalOperator.DoResolve): Ditto.
7040 (Invocation): Uses method group.
7041 (Invocation.DoResolve): Simplified.
7042 (Invocation.EmitCall): Removed useless is_static.
7043 (Invocation.Emit): Delegate to method group.
7044 (Invocation.EmitStatement): Simplified.
7045 (New): Uses method group.
7046 (MemberAccess.DoResolve): Don't destroy original expression.
7048 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7050 2007-07-04 Marek Safar <marek.safar@gmail.com>
7052 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7055 * lambda.cs: Add custom error message type.
7057 2007-07-03 Marek Safar <marek.safar@gmail.com>
7059 * lambda.cs: Simplified little bit.
7061 * parameter.cs: Introduced ImplicitLambdaParameter.
7062 (Parameters.CreateFullyResolved): New factory instead of ctor.
7066 * delegate.cs: Updated parameter creation.
7068 2007-07-03 Marek Safar <marek.safar@gmail.com>
7070 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7073 * generic.cs: Synchronized with gmcs.
7075 2007-07-03 Marek Safar <marek.safar@gmail.com>
7077 * class.cs (Indexer): Check return type as soon as possible.
7079 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7082 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7084 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7086 * parameter.cs (Parameter): Use expression type when it is available.
7088 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7089 method modifier for the first parameter only.
7091 2007-06-24 Marek Safar <marek.safar@gmail.com>
7093 A fix for bug #81938
7094 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7096 * constant.cs: Tide up an exception message.
7098 2007-06-22 Marek Safar <marek.safar@gmail.com>
7100 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7101 an uninitialized variable is used.
7103 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7105 2007-06-22 Marek Safar <marek.safar@gmail.com>
7107 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7108 not found error handling.
7110 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7112 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7113 (ArrayCreation.DoResolve): Simplified.
7114 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7115 its own resolve process.
7116 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7118 2007-06-20 Marek Safar <marek.safar@gmail.com>
7120 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7123 2007-06-20 Marek Safar <marek.safar@gmail.com>
7125 * cs-tokenizer.cs: Removed var related stuff.
7127 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7128 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7129 a type and a keyword at same time.
7131 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7134 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7135 implicitly typed arrays, more changes will follow.
7137 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7139 2007-06-19 Marek Safar <marek.safar@gmail.com>
7141 * ecore.cs (VarExpr): Removed Handled field.
7143 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7144 build-in assign functionality.
7145 (ForEach.Resolve): Removed all implicitly typed local variable code and
7147 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7148 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7150 2007-06-18 Marek Safar <marek.safar@gmail.com>
7152 * assign.cs: Removed implicitly typed local variable check.
7154 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7155 referencing implicitly typed local variable.
7156 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7159 * statement.cs (Fixed): Removed unsupported implicitly typed local
7162 2007-06-15 Marek Safar <marek.safar@gmail.com>
7164 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7166 2007-06-14 Marek Safar <marek.safar@gmail.com>
7168 A fix for bugs #81855 and #76274
7169 * attribute.cs (AttachTo): Always set owner for global attributes to
7172 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7175 * cs-parser.jay: Assembly and module attributes must precede all other
7176 elements except using clauses and extern alias declarations.
7178 2007-06-13 Marek Safar <marek.safar@gmail.com>
7180 A fix for bug #81748
7182 * expression.cs: More checks for non ISO-1 features.
7184 2007-06-12 Marek Safar <marek.safar@gmail.com>
7186 A fix for bug #81807
7187 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7188 present inside switch statement and it is required by nullable check.
7190 2007-06-12 Marek Safar <marek.safar@gmail.com>
7192 A fix for bug #81840
7193 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7194 when type matching fails.
7196 * namespace.cs: Tiny error message change.
7198 2007-06-12 Marek Safar <marek.safar@gmail.com>
7200 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7201 reporting. Added automatic property check.
7203 * class.cs: Updated after CheckAbstractAndExtern relocation.
7204 (AEventPropertyAccessor.GetSignatureForError): Customized.
7206 2007-06-11 Marek Safar <marek.safar@gmail.com>
7208 * class.cs (DefineBaseTypes): Base type can be undefined.
7210 * ecore.cs (TypeLookup): Minor refactoring.
7211 (DoResolveAsTypeStep): Removed redundant check.
7213 * namespace.cs (Lookup): Removed redundant check.
7215 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7216 ResolveAsTypeTerminal step.
7217 (BootstrapCorlib_*): Simplified.
7218 (PopulateCoreType): Core types can be now external.
7220 2007-06-07 Marek Safar <marek.safar@gmail.com>
7222 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7224 (InferTypeArguments): Infers anonymous expression type arguments.
7225 (Compatible): Split to Compatible and InferTypeArguments.
7227 * lambda.cs: Updated.
7229 2007-06-08 Marek Safar <marek.safar@gmail.com>
7231 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7233 2007-06-07 Raja R Harinath <harinath@gmail.com>
7235 Fix #80477, cs0135-2.cs, cs0135-3.cs
7236 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7237 names to the "known" variables list.
7238 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7239 parameter names are also "known".
7240 (Block.CheckError136): Remove.
7241 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7244 2007-06-07 Marek Safar <marek.safar@gmail.com>
7246 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7248 2007-06-06 Marek Safar <marek.safar@gmail.com>
7250 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7251 internal error not an user error.
7253 * expression.cs (IsApplicable): Refactored to make debugging easier.
7255 * support.cs: More tricks for non-mono runtimes.
7257 * typemanager.cs (CoreLookupType): Made public.
7258 (InitSystemCore): All linq specific stuff moved to linq.cs
7260 2007-06-05 Marek Safar <marek.safar@gmail.com>
7262 * typemanager.cs (CSharpSignature): One more missing build-in types
7264 More tricks for non-mono runtime.
7266 2007-06-05 Raja R Harinath <harinath@gmail.com>
7268 * statement.cs (Block.CheckError136_InParents): Remove.
7269 (Block.AddVariable): Use GetParameterInfo instead.
7270 (ToplevelBlock.ProcessArguments): Likewise.
7272 2007-06-04 Raja R Harinath <rharinath@novell.com>
7274 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7276 (ToplevelBlock.GetParameterInfo): Split out of ...
7277 (ToplevelBlock.GetParameterRefernce): ... this.
7278 (ToplevelBlock.ParameterMap): Remove.
7279 * expression.cs (ParameterReference): Update to use
7280 ToplevelParameterInfo.
7282 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7285 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7286 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7288 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7289 (ToplevelBlock.ProcessParameters) ... here.
7290 (ToplevelBlock..ctor): Invoke it.
7292 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7295 * statement.cs (IKnownVariable): New interface.
7296 (LocalInfo): Implement it.
7297 (ToplevelParameterInfo): New class.
7298 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7299 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7300 GetKnownVariableInfo.
7302 2007-06-03 Raja R Harinath <harinath@gmail.com>
7304 Partly speed up CS0136 error checks.
7305 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7306 'recurse' parameter.
7307 (Block.DoCheckError136): Only check errors in parameters. Move
7308 local variable checks ...
7309 (Block.AddVariable): ... here, and ...
7310 (ToplevelBlock.ResolveMeta): ... here.
7312 2007-06-02 Raja R Harinath <harinath@gmail.com>
7314 * statement.cs (Block.IsChildOf): Remove.
7316 * statement.cs (Statement.Clone): Move special case code ...
7317 (Block.CloneTo): ... here.
7319 2007-05-29 Raja R Harinath <rharinath@novell.com>
7321 * statement.cs (ToplevelBlock.container): Remove field. It's
7322 redundant with 'Parent'.
7323 (ToplevelBlock.ContainerBlock): Remove accessor.
7324 (ToplevelBlock..ctor): Update to changes. Register anonymous
7325 child with parent here, ...
7326 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7328 (start_anonymous): Don't save current_block.
7329 (top_current_block): Remove.
7331 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7332 (Block.Resolve): Update to changes.
7333 (Block..ctor): Move setting of "correct" 'Toplevel'
7334 and 'Explicit' fields to ...
7335 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7337 2007-05-27 Raja R Harinath <harinath@gmail.com>
7340 * statement.cs (Block.Implicit): Remove.
7341 (Block): Update to changes.
7342 * flowanalysis.cs: Likewise.
7344 Mildly speed up CheckInvariantMeaningInBlock
7345 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7346 Recursively call AddKnownVariable to all enclosing blocks.
7347 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7348 Remove recursive calls.
7349 (Block): Update to changes.
7351 New ExplicitBlock invariants
7352 * statement.cs (Block.Explicit): New field. It points to the
7353 immediately enclosing non-implicit block.
7354 (Block..ctor): Maintain the invariant.
7355 * cs-parser.jay: Take advantage of invariant.
7357 Introduce ExplicitBlock
7358 * statement.cs (ExplicitBlock): New.
7359 (ToplevelBlock): Derive from it.
7360 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7362 (Block.Implicit): Update to changes.
7363 * cs-parser.jay: Update to changes.
7366 * codegen.cs (EmitContext.IsLastStatement): Remove.
7367 * statement.cs (Block.DoEmit): Update to changes.
7369 2007-05-25 Raja R Harinath <rharinath@novell.com>
7371 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7372 modifying current_block directly.
7374 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7376 * class.cs: Implemented automatic properties (C# 3.0)
7377 Thanks to Marek for the help.
7379 2007-05-23 Raja R Harinath <rharinath@novell.com>
7381 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7382 variable as assigned, note also that all its components are
7384 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7386 2007-05-19 Marek Safar <marek.safar@gmail.com>
7388 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7389 member is marked as compiler generated.
7391 * decl.cs (MemberCore): Refactored ModFlags into property.
7393 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7394 (Check): Check only accessibility modifiers.
7396 2007-05-18 Raja R Harinath <rharinath@novell.com>
7398 Track all assignable slots in one bit array
7399 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7400 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7401 logic from VariableMap constructor here. Use the same 'offset'
7402 variable that's later used for computing offsets of local
7404 * flowanalysis.cs (UsageVector.parameters): Remove.
7405 (UsageVector): Update to changes.
7406 (VariableMap): Remove.
7408 Avoid creating ParameterMap in every block
7409 * statement.cs (Block.ParameterMap): Move ...
7410 (ToplevelBlock.ParameterMap): ... here.
7411 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7413 * flowanalysis.cs (FlowBranching.param_map): Remove.
7414 (FlowBranching.UsageVector): Update to changes.
7415 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7417 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7419 * expression.cs (ParameterReference): Distinguish between block
7420 where parameter was referenced and declared.
7422 2007-05-18 Marek Safar <marek.safar@gmail.com>
7424 * flowanalysis.cs, statement.cs: Put back improved error handling.
7426 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7430 Imporved object and collection initialization (C# 3.0).
7432 2007-05-15 Marek Safar <marek.safar@gmail.com>
7434 A fix for bug #81380
7435 * expression.cs (Is.DoResolve): Only value types have constant `is'
7438 2007-05-15 Raja R Harinath <rharinath@novell.com>
7440 * statement.cs (ToplevelBlock.child): Remove.
7442 2007-05-15 Raja R Harinath <harinath@gmail.com>
7444 Rationalize ResolveMeta: refactoring
7445 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7446 out constant handling code into ...
7447 (Block.DoResolveConstants): ... this.
7449 Rationalize ResolveMeta: kill local_map
7450 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7451 (Block.AssignableSlots): New.
7452 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7453 for locals -- move code from VariableMap here. Avoid unnecessary
7455 * flowanalysis.cs (FlowBranching.local_map): Remove.
7456 (FlowBranching..ctor): Use Block.AssignableSlots.
7457 (VariableMap): Remove unused constructors.
7459 2007-05-11 Raja R Harinath <rharinath@novell.com>
7461 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7463 2007-05-11 Marek Safar <marek.safar@gmail.com>
7465 * typemanager.cs (IsFriendAssembly): Should not be called for building
7468 2007-05-09 Marek Safar <marek.safar@gmail.com>
7470 * literal.cs (NullConstant): Print null in all cases.
7472 * expression.cs (Binary.ResolveOperator): Implemented delegate
7473 comparison based on C# 2.0 changes.
7475 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7477 This code is contributed under the MIT X11 license
7479 The following enables support for several C# 3.0 language features:
7481 * cs-tokenizer.cs: Added support for the "var" keyword.
7483 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7484 Added VarExpr class to facilitate type inferencing.
7486 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7487 to support anonymous types.
7489 * assign.cs: Added support for type inferencing and initialization.
7491 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7493 * expression.cs: Added implicit array support to ArrayCreation.
7494 Added 5 types and 1 interface:
7496 IInitializable Implementing classes can inject initializing
7497 statements after object instantiation.
7499 Initializer Stores data for object initialization.
7501 AnonymousType An expression for anonymous types.
7503 AnonymousTypeParameter Stores data about an anonymous type's field.
7505 NewInitialize An expression for object initialization.
7507 CollectionInitialize An expression for collection initialization.
7509 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7512 2007-05-06 Marek Safar <marek.safar@gmail.com>
7514 A fix for bug #81500
7515 * cs-tokenizer.cs: Add special handling for coalescing operator.
7517 2007-05-06 Marek Safar <marek.safar@gmail.com>
7519 A fix for bug #81529
7520 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7521 its value from base class until it is redefined.
7523 2007-05-02 Raja R Harinath <rharinath@novell.com>
7525 Fix regression in cs0631-3.cs
7526 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7527 fallback. Make error fallback catch more cases.
7529 2007-05-01 Miguel de Icaza <miguel@novell.com>
7531 * cs-parser.jay: Allow parameters in operator declarations to have
7534 2007-04-27 Miguel de Icaza <miguel@novell.com>
7536 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7539 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7540 inside the ContextualReturn, it does not have to be an
7541 ExpressionStatement.
7543 2007-04-24 Miguel de Icaza <miguel@novell.com>
7545 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7548 2007-04-23 Miguel de Icaza <miguel@novell.com>
7550 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7551 method in two methods: ResolveNoDefine and Resolve.
7553 ResolveNoDefine will stop just after ResolveTopBlock has been
7556 Resolve will then continue by creating a method and issuing the
7557 call to method.Define ().
7559 (AnonymousMethod): Split and implement the new Resolve and
7560 ResolveNoDefine as well.
7562 * lambda.cs (LambdaExpression): Split the anonymous method
7563 resolution code into a separate routine (CoreCompatibilityTest)
7564 from DoCompatibleTest.
7566 (LambdaExpression.TryBuild): New method, this method tries to
7567 build the LambdaExpression with the given set of types to be used
7568 as the types for the various parameters of the lambda expression.
7570 If the compilation succeed with the given types, the infered type
7571 of the Anonymous method is returned, otherwise null is returned.
7573 2007-04-23 Marek Safar <marek.safar@gmail.com>
7575 A fix for bug #81414
7576 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7578 2007-04-22 Miguel de Icaza <miguel@novell.com>
7580 * cs-tokenizer.cs: Change various identifiers here from the
7581 camelCasing to the recommended Linux-like style for instance
7582 variables from the Coding Guidelines.
7584 2007-04-19 Martin Baulig <martin@ximian.com>
7587 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7588 System.Enum to System.ValueType.
7590 2007-04-13 Martin Baulig <martin@ximian.com>
7592 Rewrote implicit reference conversions. We need to distinguish
7593 between implicit reference conversions (13.1.4) and implicit
7594 boxing conversions (13.1.5).
7596 According to the spec, there's an an implicit conversion
7597 "From a one-dimensional array-type S[] to IList<T> and base
7598 interfaces of this interface, provided there is an implicit
7599 reference conversion from S to T." Note that this does not
7600 include boxing conversions.
7603 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7604 (Convert.ImplicitReferenceConversion): Split into
7605 ImplicitReferenceConversionCore() and
7606 ImplicitBoxingConversionExist().
7607 (Convert.ImplicitReferenceConversionExists): Use the new
7608 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7610 2007-04-12 Martin Baulig <martin@ximian.com>
7612 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7613 `TypeManager.null_type' checks up to the top of the method.
7615 2007-04-11 Marek Safar <marek.safar@gmail.com>
7617 A fix for bug #81350
7618 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7621 2007-04-11 Martin Baulig <martin@ximian.com>
7623 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7624 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7625 to make this work for generic classes; fixes #79561.
7627 2007-04-11 Martin Baulig <martin@ximian.com>
7629 * expression.cs (As): Add support for nullable types; fixes #79371.
7631 2007-04-11 Martin Baulig <martin@ximian.com>
7633 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7634 `type.FullName' is null; fixes #80243.
7636 2007-04-11 Martin Baulig <martin@ximian.com>
7638 * expression.cs (Invocation.IsApplicable): Don't modify the method
7639 if type inference succeeded, but the method was not applicable.
7642 2007-04-10 Marek Safar <marek.safar@gmail.com>
7644 A fix for bug #81324
7645 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7646 internal and external namespaces containers.
7648 2007-04-10 Martin Baulig <martin@ximian.com>
7650 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7651 TypeManager.DropGenericMethodArguments() so we also call
7652 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7654 2007-04-10 Martin Baulig <martin@ximian.com>
7656 * iterators.cs (Iterator.CreateIterator): Don't crash if
7657 `method.ReturnType' is null. This happens if something went wrong
7658 while resolving that typ (we already reported an error in this case).
7660 2007-04-10 Martin Baulig <martin@ximian.com>
7662 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7663 generic interfaces; report the CS0144 directly.
7665 2007-04-10 Martin Baulig <martin@ximian.com>
7667 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7668 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7670 2007-04-10 Martin Baulig <martin@ximian.com>
7672 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7674 2007-04-09 Raja R Harinath <rharinath@novell.com>
7677 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7678 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7681 * statement.cs (For.Resolve): If resolution fails, use
7684 2007-04-08 Marek Safar <marek.safar@gmail.com>
7686 * anonymous.cs (MakeName): Make faster and zero-based.
7687 (VerifyExplicitParameterCompatibility): Back to mode where generic
7688 parameter is ignored.
7689 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7691 * class.cs (EmitType): Method can emit another new method.
7693 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7695 * driver.cs: Updated.
7697 * lambda.cs: Reuse predefined empty parameters.
7699 * parameter.cs: Updated
7701 * support.cs: Implemented InflateTypes.
7703 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7704 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7706 2007-04-03 Martin Baulig <martin@ximian.com>
7710 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7711 version of TypeManager.IsOverride() which also works with generic
7714 2007-04-03 Martin Baulig <martin@ximian.com>
7719 (Convert.ExplicitReferenceConversion): We need to cast when
7720 converting from IList<T> to S[].
7722 2007-04-01 Marek Safar <marek.safar@gmail.com>
7724 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7727 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7729 2007-03-31 Marek Safar <marek.safar@gmail.com>
7731 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7732 argument and return type inferring.
7734 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7735 (ReturnType): Turned to property.
7737 * statement.cs (Return): Implemented return type inferring.
7739 * support.cs (ReflectionParameters): Use local types if possible.
7741 2007-03-30 Raja R Harinath <rharinath@novell.com>
7743 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7744 (FlowBranching.UsageVector): Update to changes.
7746 Prepare to kill 'Reachability'
7747 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7748 argument of constructor.
7750 2007-03-29 Raja R Harinath <rharinath@novell.com>
7752 Prepare to kill 'Reachability'
7753 * flowanalysis.cs (UsageVector.is_unreachable): New.
7754 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7755 'reachability', and verify they're consistent.
7758 * expression.cs (New.EmitStatement): Handle type parameters here too.
7760 2007-03-29 Martin Baulig <martin@ximian.com>
7765 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7766 CompilerGeneratedClass.
7767 (ScopeInfo.EmitScopeInstance): Make this protected.
7768 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7769 `ec.CurrentAnonymousMethod.Scope == Scope'.
7771 * statement.cs (Block.ScopeInfo): Make this a property.
7773 2007-03-27 Raja R Harinath <harinath@gmail.com>
7775 Prepare to kill 'Reachability'
7776 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7777 (FlowBranching.UsageVector.Reachability): Remove property.
7778 (FlowBranching.UsageVector.IsUnreachable): New property.
7779 (FlowBranching.UsageVector.ResetBarrier): New.
7780 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7781 * codegen.cs, statement.cs: Update to changes.
7783 2007-03-27 Martin Baulig <martin@ximian.com>
7788 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7791 2007-03-26 Raja R Harinath <rharinath@novell.com>
7793 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7794 instead of TriState. Remove all mention of TriState.
7796 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7797 replaced by a boolean. Add boolean 'is_unreachable' field, check
7798 and maintain invariants.
7800 2007-03-25 Marek Safar <marek.safar@gmail.com>
7802 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7804 2007-03-25 Marek Safar <marek.safar@gmail.com>
7806 * expression.cs: Stop using obsolete 2.0 opcodes.
7808 2007-03-25 Marek Safar <marek.safar@gmail.com>
7810 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7811 one of the latests Martin's fixes.
7813 2007-03-23 Miguel de Icaza <miguel@novell.com>
7815 * expression.cs: On BigEndian systems, swap the bytes, temporary
7816 solution until we get a new bitconverter class.
7818 2007-03-23 Martin Baulig <martin@ximian.com>
7822 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7823 "Method" and "Method`1". Normally, a cache lookup is done on the
7824 "Method" form (ie. without the generic arity), but this one makes
7825 lookups on the full form work as well.
7827 2007-03-22 Raja R Harinath <rharinath@novell.com>
7829 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7832 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7834 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7835 ordered_member_list, to TypeBuilder to store members to be defined
7836 in the order they were parsed in.
7837 - ordered_explicit_member_list contains all properties indexers
7838 and methods that are defined as explicit implementation of an
7839 interface or base class.
7840 - ordered_member_list contains all properties indexers and methods
7841 that are not defined as explicit implementation of an interface
7844 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7845 functionality in these removed classes has been replaced with
7846 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7847 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7849 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7850 to CheckForDuplications inside GetMethod and SetMethod Define Method
7851 to handle method property and indexer name conflicts.
7855 All code is contributed under the MIT/X11 license.
7857 2007-03-20 Martin Baulig <martin@ximian.com>
7859 * class.cs (TypeContainer.Interfaces): Removed; they're now
7860 included in `TypeContainer.Types'.
7862 2007-03-20 Martin Baulig <martin@ximian.com>
7864 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7866 * class.cs (TypeContainer.CreateType): New public method. This is
7867 now called before DefineType() to create the TypeBuilders.
7868 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7869 has already been created by CreateType().
7870 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7871 don't resolve our base classes here; this has been moved into
7872 DefineBaseTypes(). We're now called from CreateType().
7873 (TypeContainer.DefineBaseTypes): New private method; resolve our
7874 base classes here. We're now called from DefineType().
7877 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7878 our types first to create all the TypeBuilders. After that, call
7879 TypeContainer.DefineType() on all the types which'll resolve their
7880 base classes and setup the resolve order.
7882 2007-03-20 Martin Baulig <martin@ximian.com>
7884 * class.cs (TypeContainer.Enums): Removed; they're now included in
7885 `TypeContainer.Types'.
7887 2007-03-20 Martin Baulig <martin@ximian.com>
7890 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7891 (TypeContainer.DoResolveMembers): Call DefineType() on our
7892 `compiler_generated' classes; moved here from DefineNestedTypes().
7895 (RootContext.ResolveTree): Call ResolveMembers() on all
7896 TypeContainer's in the `type_container_resolve_order'.
7898 2007-03-19 Marek Safar <marek.safar@gmail.com>
7900 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7902 2007-03-17 Marek Safar <marek.safar@gmail.com>
7904 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7905 implementation flags.
7907 2007-03-17 Marek Safar <marek.safar@gmail.com>
7909 * class.cs: More optimizations for type parameters.
7911 2007-03-15 Marek Safar <marek.safar@gmail.com>
7913 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7915 * ecore.cs, parameter.cs: More common code for both corlibs.
7917 * typemanager.cs (IsGenericMethod): Simplified.
7919 2007-03-15 Raja R Harinath <rharinath@novell.com>
7921 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7923 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7925 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7926 unconditionally. Simplify explanation.
7927 (Try.Resolve, Using.Resolve): Likewise.
7929 2007-03-15 Martin Baulig <martin@ximian.com>
7933 * decl.cs (DeclSpace): If we're a partial class, use our
7934 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7936 2007-03-15 Raja R Harinath <rharinath@novell.com>
7938 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7940 (FlowBranching.UsageVector): Update to changes.
7941 (FlowBranching.MergeSiblings): Likewise.
7942 * statement.cs: Likewise.
7944 2007-03-15 Martin Baulig <martin@ximian.com>
7949 (MemberCache): Added a special .ctor for type parameters.
7952 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7955 2007-03-09 Martin Baulig <martin@ximian.com>
7957 * enum.cs (Enum): Make this a TypeContainer.
7958 (EnumMember): Derive from `Const'.
7961 (Const.DoResolveValue): New protected virtual method; move most of
7962 the functionality of ResolveValue() here so we can override it in
7964 (Const.CreateConstantReference): Make this virtual.
7966 * class.cs (Kind): Add `Kind.Enum'.
7967 (TypeContainer.Emit): Don't emit the enums here; they're already
7968 in the `RootContext.typecontainer_resolve_order'.
7970 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7971 here; they're already in the `typecontainer_resolve_order'.
7973 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7974 TypeManager.DropGenericTypeArguments().
7977 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7978 (TypeManager.IsEnumType): Likewise.
7979 (TypeManager.EnumToUnderlying): Likewise.
7980 (TypeManager.IsEqual): Add support for enums.
7982 2007-03-12 Raja R Harinath <rharinath@novell.com>
7984 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7985 DefaultParameterValueAttribute to be undefined, say if System.dll
7988 2007-03-11 Marek Safar <marek.safar@gmail.com>
7990 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7993 2007-03-10 Marek Safar <marek.safar@gmail.com>
7995 * class.cs, parameter.cs: Unified parameters verification.
7997 2007-03-08 Martin Baulig <martin@ximian.com>
7999 * cs-parser.jay (constructor_header): Pass the location to the
8000 newly created TopLevelBlock.
8002 2007-03-07 Martin Baulig <martin@ximian.com>
8004 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8006 2007-03-06 Miguel de Icaza <miguel@novell.com>
8008 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8009 with the changes from David, fixes the build.
8011 2007-03-05 David Mitchell <dmitchell@logos.com>
8013 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8014 and its base interfaces to a one-dimensional array type S[],
8015 provided there is an implicit or explicit reference conversion
8018 2007-03-03 Marek Safar <marek.safar@gmail.com>
8020 * cs-tokenizer.cs: Implemented basic linq grammar.
8022 * driver.cs: Set linq lang version on demand.
8024 2007-02-26 Marek Safar <marek.safar@gmail.com>
8026 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8028 2007-02-25 Marek Safar <marek.safar@gmail.com>
8030 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8033 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8035 Check property and event extern attributes.
8037 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8040 2007-02-24 Marek Safar <marek.safar@gmail.com>
8042 A fix for bug #80407
8043 * ecore.cs: Don't report ambiguity error when methods have same parent.
8045 2007-02-23 Marek Safar <marek.safar@gmail.com>
8047 A fix for bug #80878
8048 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8050 2007-02-22 Marek Safar <marek.safar@gmail.com>
8052 * attribute.cs: Enable ExtensionAttribute presence test.
8054 2007-02-22 Marek Safar <marek.safar@gmail.com>
8056 * class.cs: Warn about missing GetHashCode only when Equals is override.
8058 * decl.cs: Check accessibility of type arguments.
8060 * typemanager.cs: Correctly report nullable array.
8062 2007-02-20 Marek Safar <marek.safar@gmail.com>
8064 * class.cs, report.cs: Capture more details when things go wrong.
8066 2007-02-20 Marek Safar <marek.safar@gmail.com>
8068 A fix for bug #80650
8069 * cs-parser.jay: Anonymous container starts at constructor declaration
8070 and not at block beginning because it has to be usable in constructor
8073 * statement.cs: Use context location and not block one for error reporting.
8075 2007-02-18 Marek Safar <marek.safar@gmail.com>
8077 A fix for bug #78712
8078 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8081 2007-02-18 Marek Safar <marek.safar@gmail.com>
8083 A fix for bug #80493 by Atsushi Enomoto
8084 * cs-parser.jay: Ignore invalid attribute target.
8086 2007-02-18 Marek Safar <marek.safar@gmail.com>
8088 * cs-tokenizer.cs: Ignore '\0' as white space character.
8090 2007-02-17 Miguel de Icaza <miguel@novell.com>
8092 * cs-parser.jay: Add support for lambda expressions to the mcs
8095 * lambda.cs: Only clone when we are probing, not on the final call
8096 (Compatible is the final call).
8098 * statement.cs (CloneContext): Introduce class to provide block
8099 remapping during clone.
8101 All statements Clone themselves now.
8103 (Clone): special handling for blocks, when we clone a block, we
8104 register the block inside this routine, as children of the block
8105 might trigger a lookup.
8107 * expression.cs: Add support for CloneContext in all expressions.
8109 2007-02-17 Marek Safar <marek.safar@gmail.com>
8111 A fix for bug #80493
8112 * statement.cs: Report ambiguous warning when interfaces are not related.
8114 2007-02-15 Marek Safar <marek.safar@gmail.com>
8116 C# 3.0 extension methods.
8118 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8119 cannot be used directly.
8121 * class.cs (Class.Emit): Emit extension attribute if any class method
8122 is extension method.
8123 (Method.Define): Add basic extension method validation conditions.
8124 (Method.Emit): Emit extension attribute for method.
8126 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8127 extension method exists. Currently we follow same approach as Microsoft
8128 does, emit even if a method or a class are private but this can change
8131 * cs-parser.jay: Add handling of `this' keyword in method parameters
8134 * decl.cs (DeclSpace.IsStaticClass): New property.
8135 (MemberCache.FindExtensionMethods): Looks for extension methods with
8136 defined name and extension type.
8138 * doc.cs: Updated after OverloadResolve changes.
8140 * driver.cs: Add new soft reference to System.Core.dll.
8142 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8143 (ExtensionMethodGroupExpr): Represents group of extension methods.
8145 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8146 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8147 to MethodGroupExpr and made non-static for easier customization.
8148 (Invocation.DoResolve): Add extension method lookup when no standard
8150 (MemberAccess.DoResolve): Try extension methods if no member exists.
8152 * modifiers.cs: Add METHOD_EXTENSION modifier.
8154 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8155 as well as candidate extension type.
8156 (ComputeNamespaces): When assembly constains extension methods registers
8158 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8159 extension method lookup.
8160 (Namespace.LookupExtensionMethod): Looks for extension method in this
8162 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8163 find a method which matches name and extensionType.
8165 * parameter.cs (Parameter): Add This modifer.
8166 (HasExtensionMethodModifier): New property.
8167 (Resolve): Add extension parameter check.
8168 (ModFlags): turned to property to exclude this modifier as it is not real
8170 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8172 * support.cs (ParameterData): Add ExtensionMethodType.
8173 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8175 * typemanager.cs: Add type and ctor extension attribute type.
8177 2007-02-15 Miguel de Icaza <miguel@novell.com>
8179 * report.cs (DisableErrors, EnableErrors): used to prevent error
8180 output when we are "trying" to compile various methods with
8183 * ecore.cs (Expression): Add Clone method that calls the virtual
8184 CloneTo method. The current CloneTo method in Expression throws
8185 an exception so we can track down all the places where this must
8186 be implemented (not using abstract, because that would be a lot of
8187 up-front-work before we can start testing the implementation
8190 Important: we only need Clone capabilities for expressions created
8191 by the parser, as the expressions we will be cloning are
8192 expressions in the pre-resolved state. This vastly simplifies
8195 (SimpleName): Add CloneTo that does nothing.
8196 (EmptyCast): Add CloneTo.
8198 * expression.cs (Binary): Implement CloneTo.
8199 (Invocation.IsApplicable): Store the current ec in
8200 EmitContext.TempEc and restore it on return. This is used so we
8201 do not have to sprinkle hundres of methods with an extra
8202 EmitContext, we know that the only user is the lambda expression
8203 ImplicitConversionExists code.
8205 (Argument): Add Cloning capabilities.
8206 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8207 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8208 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8209 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8210 IndexerAccess): Add Clone capability.
8212 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8214 (Argument): Add cloning capability.
8216 * assign.cs (Assign): Implement CloneTo.
8218 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8220 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8221 version by calling Convert with the EmitContext (that we are
8222 currently storing in ec, this is not great, but will do for now,
8223 to avoid passing EmitContext parameters to hundreds of functions
8224 that do not need them now).
8226 (SetExpression): Remove, it is not needed.
8228 (ContextualReturn): Implement CloneTo.
8230 * statement.cs (Statement): Implement cloning infrastructure,
8231 similar to expressions.
8233 (Block): Partial implementation of Clone for statements.
8235 (Return): Implement clone.
8237 * constant.cs (Constant.CloneTo): New method, does nothing.
8239 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8240 solution, until we decide how to exactly do this.
8242 2007-02-14 Marek Safar <marek.safar@gmail.com>
8244 A fix for bug #80493
8245 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8246 a property is override we need to use second accessor.
8248 2007-02-13 Marek Safar <marek.safar@gmail.com>
8250 A fix for bug #80418
8251 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8254 2007-02-13 Marek Safar <marek.safar@gmail.com>
8256 Another fix for bug #80749
8257 * pending.cs: Abstract class has priority over interfaces.
8259 2007-02-13 Marek Safar <marek.safar@gmail.com>
8261 Another fix for bug #80749
8262 * pending.cs: Abstract class has priority over interfaces.
8264 2007-02-13 Marek Safar <marek.safar@gmail.com>
8266 Another fix for bug #80749
8267 * pending.cs: Abstract class has priority over interfaces.
8269 2007-02-13 Marek Safar <marek.safar@gmail.com>
8271 Another fix for bug #80749
8272 * pending.cs: Abstract class has priority over interfaces.
8274 2007-02-13 Marek Safar <marek.safar@gmail.com>
8276 * class.cs Better error message.
8278 * driver.cs: Add shorter versions of -optimize option.
8280 2007-02-13 Martin Baulig <martin@ximian.com>
8282 * class.cs (Constructor.Emit): Check the return value of
8283 ec.ResolveTopBlock() and return on error.
8285 2007-02-13 Raja R Harinath <rharinath@novell.com>
8287 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8288 message to fix error message regression.
8290 2007-02-12 Marek Safar <marek.safar@gmail.com>
8292 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8294 2007-02-12 Marek Safar <marek.safar@gmail.com>
8296 A fix for bug #80749
8297 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8298 its parent container.
8300 * class.cs (DefineFieldInitializers): Each initializer can has different
8303 * const.cs: Updated.
8305 2007-02-11 Miguel de Icaza <miguel@novell.com>
8307 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8308 now all the heavy lifting to check that embedded statements or
8309 expressions have the right form is done in the ContextualReturn.
8311 (ContextualReturn): New class.
8313 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8314 method that can be invoked to report 201, so we do not replicate
8317 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8319 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8320 treating tabs as spaces.
8322 2007-02-09 Marek Safar <marek.safar@gmail.com>
8324 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8325 * assign.cs: Use full implicit conversion for right side check.
8327 2007-02-09 Marek Safar <marek.safar@gmail.com>
8329 * statement.cs (Switch): Switch over boolean type is not standardized.
8331 2007-02-08 Marek Safar <marek.safar@gmail.com>
8333 A fix for bug #80755
8334 * decl.cs (FindBaseEvent): Don't use method cache for events.
8336 2007-02-07 Marek Safar <marek.safar@gmail.com>
8338 * cs-parser.jay: Better syntax error handling.
8340 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8341 instead of underlying type value.
8343 2007-02-06 Marek Safar <marek.safar@gmail.com>
8345 * driver.cs: Check define identifier before is registered.
8347 * namespace.cs: Use existing error message.
8349 * report.cs: New warning.
8351 2007-02-06 Marek Safar <marek.safar@gmail.com>
8353 A fix for bug #80742
8354 * expression.cs: Delegate Invoke method can be called directly.
8356 2007-02-06 Marek Safar <marek.safar@gmail.com>
8358 A fix for bug #80676
8359 * class.cs (IsEntryPoint): The Main method can have params modifier.
8361 2007-02-04 Miguel de Icaza <miguel@novell.com>
8363 * parameter.cs (Parameter, Parameters): Add Clone method.
8365 * anonymous.cs (Compatible): Turn method into virtual method, so
8366 LambdaExpression can implement a different behavior.
8368 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8369 out the basic checking here, so it can be used by
8372 * lambda.cs: Introduce "Compatible" function that will do the
8375 2007-02-02 Marek Safar <marek.safar@gmail.com>
8377 * attribute.cs: Unified one error message.
8379 * class.cs (Class): Use type attributes and not properties to test static
8381 (IsEntryPoint): Don's pass local variable.
8383 * convert.cs: Removed duplicate check.
8385 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8387 * driver.cs: Don't crash when soft reference does not exist.
8389 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8390 (UsingEntry): Removed redundant allocation.
8392 * parameter.cs: Add fast path for type parameters.
8394 * support.cs: Don't allocate attribute when it's not used.
8396 2007-01-30 Miguel de Icaza <miguel@novell.com>
8399 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8400 this into a virtual method, so we can override it in LambdaExpression.
8402 * driver.cs: Improve diagnostics in case of failure.
8404 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8405 write a function that is slightly more complex and that parses:
8407 type identifier [, type identifier]* )
8409 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8412 (canEmpty ? i >= 0 : i > 0)
8414 2007-01-30 Raja R Harinath <rharinath@novell.com>
8416 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8417 exception on possibly valid code.
8419 2007-01-29 Raja R Harinath <rharinath@novell.com>
8421 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8423 (parse_opt_type_arguments): Remove. It's almost the same as
8425 (parse_namespace_or_typename): Use parse_less_than.
8427 2007-01-28 Miguel de Icaza <miguel@novell.com>
8429 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8430 this bug took a few hours to find, because the state saved and
8431 restored by PushPosition and PopPosition was ignoring the state of
8432 parse_generic_less_than.
8434 I can also now remove the handling of OP_LT and OP_GT, this solves
8437 * cs-tokenizer.cs: store the location for the ARROW token, we use
8440 (PushPosition, PopPosition): save/restore also `current_token',
8441 restore `parse_generic_less_than' (was missing).
8443 (parse_opt_type_arguments): use parse_type, not
8444 parse_namespace_or_typename to parse types.
8446 * lambda.cs: Empty new file, will eventually have the lambda
8447 expression implementation.
8449 * lambda.test: used to test the internal tokenizer.
8451 * report.cs (FeatureIsNotISO1): Rename from
8452 FeatureIsNotStandardized, because it was about the language level
8453 (1 vs 2) it was not about standarization.
8455 (FeatureRequiresLINQ): New.
8457 * support.cs (SeekableStreamReader): Only require that the reader
8458 is a TextReader, not a StreamReader, so we can plug StringReader.
8460 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8461 given position in the input stream the following tokens can be
8462 parsed as a type followed by an identifier.
8464 (is_punct): after a '(' if parse_type_and_parameter returns true,
8465 then return a special token OPEN_PARENS_LAMBDA which is used to
8466 avoid reduce/reduce errors in the grammar for the
8467 lambda_expression rules.
8469 (parse_type): implement a type parser inside the
8470 tokenizer, the parser only returns true or false depending on
8471 whether the input at a given position can be parsed as a type.
8473 (peek_token): new method used during type parsing.
8475 2007-01-28 Raja R Harinath <rharinath@novell.com>
8478 * anonymous.cs (ScopeInfo.InflateParameters): New.
8479 (AnonymousContainer.Resolve): Use it to redirect types of
8480 delegate parameters.
8482 2007-01-27 Raja R Harinath <rharinath@novell.com>
8485 * expression.cs (Error_InvalidArguments): Don't use two different
8486 messages for CS1503. Use ExtraInformation and
8487 SymbolRelatedToPreviousError instead.
8490 * decl.cs (DeclSpace.initialize_type_params): Don't access
8491 'type_params' of a partial class directly.
8493 2007-01-26 Miguel de Icaza <miguel@novell.com>
8495 * constant.cs: Removed a handful of out-of-range checks that were
8498 2007-01-25 Marek Safar <marek.safar@gmail.com>
8500 * expression.cs (CheckUselessComparison): Add additional check for char
8503 * namespace.cs: Fixed typo.
8505 2007-01-23 Miguel de Icaza <miguel@novell.com>
8507 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8508 gone, instead we inline the test, preventing the needless casts to
8509 longs, ulongs and doubles for the parameters, avoiding calls to
8510 methods that overchecked stuff, and instead inlined things
8513 2007-01-20 Marek Safar <marek.safar@gmail.com>
8515 * cs-parser.jay: Better parameter error handling.
8517 2007-01-17 Marek Safar <marek.safar@gmail.com>
8519 A fix for bug #80368, #80522
8520 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8521 whether array initializer contains constants only.
8522 (ArrayCreation.Emit): Use better formula to decide when
8523 are array initializers for static initialization.
8524 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8525 have to emit even constants otherwise they are pre-initialized.
8527 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8528 Raja R Harinath <rharinath@novell.com>
8530 Fix emit order of 'get' vs. 'set'.
8531 * support.cs (Accessors): New.
8532 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8533 Note the order in which accessors are declared in the source.
8534 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8535 Refactored from Property.Define and Indexer.Define.
8536 (PropertyBase.DefineAccessors): New helper that calls the above in
8537 appropriate order as noted by the parser.
8538 (Property.Define, Indexer.Define): Update to changes.
8539 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8541 2007-01-17 Raja R Harinath <rharinath@novell.com>
8543 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8544 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8545 there's an implicit conversion from the current type to the target
8546 type before converting the underlying constant.
8548 2007-01-16 Marek Safar <marek.safar@gmail.com>
8550 * const.cs (ResolveValue): Updated after constant conversion was made more
8553 * constant.cs (GetAttributableValue): constant to object conversion is
8554 used for attributes only.
8555 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8556 constant conversions.
8557 (LongConstant.ConvertImplicitly): Ditto.
8559 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8560 (ImplicitConversionStandard): Handle constant conversion as extra step.
8561 It solves the issue when constant conversion was called indirectly like
8562 inside array initializer and constant folding was skipped.
8564 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8567 * statement.cs(ImplicitConversionStandard): Updated after constant
8568 conversion was made more generic.
8570 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8572 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8573 Constraints, solves the problem where the compiler incorrectly
8574 reported that a type parameter was not constrained to a class (Bug
8577 2007-01-14 Marek Habersack <grendello@gmail.com>
8579 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8581 2007-01-14 Marek Safar <marek.safar@gmail.com>
8583 A fix for bug #80368
8584 * assign.cs (FieldInitializer): New class implements field
8585 initializer statement.
8587 * attribute.cs: Update after FieldMember rename.
8589 * class.cs (PropertyBasedMember): New common class for property based
8591 (InterfaceMemberBase): New base class for all members which can be used as
8592 an interface members.
8593 (MethodCore): Moved really common code to InterfaceMemberBase.
8594 (Method.Define): Equal and GetHasCode detection is relevant for methods
8596 (MethodData.Define): Don't assume that public event implements an
8597 interface automatically.
8598 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8600 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8601 (FieldMember): Merged with FieldBase.
8602 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8603 event extern modifier can be used.
8604 (EventField.EventFieldAccessor): Moved event field specific code here.
8605 (Event.AllowedModifiers): Even event can be extern.
8606 (Event.FindOutBaseMethod): New override specific to events.
8607 (Indexer.parameters): Reintroduce parameters because base class holds
8608 only properties common data.
8609 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8610 need do extra parameters check.
8612 * const.cs: Update after FieldMember rename.
8614 * decl.cs (MemberCache.FindBaseEvent): New method.
8616 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8617 to reflect that indexer is now derived from PropertyBased.
8619 * ecore.cs (GetMemberType): Made public.
8620 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8623 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8625 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8626 (RegisterEvent): Removed.
8627 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8628 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8630 2007-01-11 Raja R Harinath <rharinath@novell.com>
8633 * statement.cs (CollectionForeach.TryType): Prefer generic
8634 GetEnumerator over non-generic variant. Fix code to follow comments.
8636 2007-01-09 Raja R Harinath <rharinath@novell.com>
8639 * support.cs (ReflectionParameter): Don't use an invalid index on
8640 the generic parameter data.
8642 2007-01-08 Miguel de Icaza <miguel@novell.com>
8644 * driver.cs: Just add a tiny bit of infrastructure.
8646 2007-01-02 Marek Safar <marek.safar@gmail.com>
8648 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8649 where field type is struct from current assembly.
8651 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8654 2007-01-02 Marek Safar <marek.safar@gmail.com>
8656 A fix for bug #80381
8657 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8660 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8662 (Namespace.LookupType): Always use core types from corlib when speficied.
8664 * report.cs: A new warning.
8666 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8667 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8668 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8670 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8671 (InitCoreTypes): Set expression type of object_type and value_type
8672 immediately after lookup.
8674 2007-01-01 Miguel de Icaza <miguel@novell.com>
8676 * cs-tokenizer.cs: Accept Pc class characters (Connector
8677 Punctuation) as valid identifiers. Fixes #78259
8679 * expression.cs (Invocation.DoResolve): Moved the check for the
8680 use of `this' for doing method calls to the Invocation resolution
8681 step, after overload resolution has taken place instead of doing
8682 the check at the low-level `This.DoResolve' level.
8684 The `This.DoResolve'(appens before overload resolution, so it has
8685 no way of knowing if the method that will be called will be
8686 instace or static, triggering an erroneous report for cs0188 (Bug
8689 We now do the check for instance method invocations after we know
8690 what method will be called.
8692 (This.CheckThisUsage): Move the actual use of this structure
8693 checking into its own method and expose it.
8695 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8698 Exceptions: Null.ConvertImplicitly,
8699 Constant.ImplicitConversionRequired as there are too many call
8700 sites for passing the ec.
8702 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8703 EmitContext, if the value is null, then we do not try to provide
8704 the extra information from the error (If a userdefined conversion
8705 exists, as UserDefinedConversion requires a non null-EmitContext).
8709 2006-12-30 Raja R Harinath <rharinath@novell.com>
8711 * flowanalysis.cs (MyBitVector): Document some invariants.
8712 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8713 introduced below, and add a couple of others,
8715 2006-12-30 Marek Safar <marek.safar@gmail.com>
8717 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8718 GetPropertyFromAccessor and GetEventFromAccessor.
8720 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8721 overrides non-obsolete one.
8722 (Indexer.Define): Error message has been moved to the parser.
8724 * cs-parser.jay: Better syntax errors handling.
8726 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8727 when an invocation has no arguments.
8729 * ecore.cs: Removed not used caching.
8731 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8734 * report.cs: Add a new warning.
8736 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8738 * typemanager.cs (enumeration_type): Removed.
8739 (CSharpSignature): Reuses IsSpecialMethod.
8740 (IsEqual): Hack for MS BCL.
8741 (GetPropertyFromAccessor): New method.
8742 (GetEventFromAccessor): New method.
8743 (IsSpecialMethod): Fixed to handle more cases.
8745 2006-12-30 Marek Safar <marek.safar@gmail.com>
8747 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8748 Made white spaces array static.
8750 * ecore.cs (RemoveGenericArity): Optimized.
8752 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8754 (MyBitVector.initialize_vector): Simplified.
8756 2006-12-22 Miguel de Icaza <miguel@novell.com>
8758 * ecore.cs: Am not entirely happy with this hack, but it seems to
8759 address the issue in 80257 (a small test case for
8762 I set the MethodGroupExpr.Type to an internal compiler type
8763 (itself in this case) to force the resolution to take place. Why
8764 it does not take place with a null is beyond me.
8766 2006-12-20 Marek Safar <marek.safar@gmail.com>
8768 A fix for bug #80288
8769 * expression.cs (ResolveOperator): Consider user defined conversion for
8770 logical and operator too.
8771 (EmitBranchable): Optimization for logical and when full constant folding
8772 could not be applied but one operand is constant.
8774 2006-12-19 Marek Safar <marek.safar@gmail.com>
8776 * class.cs (GetClassBases): Write 5 times every day, will never use
8777 FullName for error reporting.
8779 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8781 2006-12-19 Martin Baulig <martin@ximian.com>
8783 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8784 the symbol file info here.
8786 2006-12-18 Marek Safar <marek.safar@gmail.com>
8788 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8789 of `elseif' is taking then following sections are not taking.
8790 Fixes an issue reported on mono mailing list.
8792 2006-12-18 Marek Safar <marek.safar@gmail.com>
8794 A fix for bug #80300
8795 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8796 a caller is not taking.
8798 2006-12-18 Raja R Harinath <rharinath@novell.com>
8800 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8801 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8802 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8803 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8804 * class.cs: Update to changes.
8806 2006-12-17 Marek Safar <marek.safar@gmail.com>
8808 A fix for bug #79934
8809 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8812 * class.cs (ResolveMembers): Register an iterator in current container and
8815 2006-12-16 Raja R Harinath <rharinath@novell.com>
8818 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8819 satisfy a params annotated parameter.
8821 2006-12-16 Marek Safar <marek.safar@gmail.com>
8823 A fix for bug #77014
8824 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8825 paramters correctly and not rely on hacks in Parameters class.
8826 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8828 (Invocation.VerifyArgumentsCompat): Ditto.
8829 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8832 * parameter.cs (HasParams): Don't assume that params is the last one.
8834 * support.cs (ReflectionParameters.ctor): Look for params attribute
8836 (ReflectionParameters.ParameterType): Removed hack when we returned last
8837 parameter for out of range parameters.
8838 (ParameterName, ParameterModifier): Ditto.
8840 2006-12-14 Marek Safar <marek.safar@gmail.com>
8842 A fix for bug #79987
8843 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8844 when assembly is not CLS compliant but type is. I have no idea why is this
8847 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8849 2006-12-13 Miguel de Icaza <miguel@novell.com>
8851 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8852 in struct constructors, they are basically no-ops.
8854 2006-12-12 Marek Safar <marek.safar@gmail.com>
8856 * cs-tokenizer.cs (Position): Save preprocessor status too.
8858 2006-12-12 Marek Safar <marek.safar@gmail.com>
8860 A fix for bug #77794
8861 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8863 2006-12-12 Marek Safar <marek.safar@gmail.com>
8865 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8867 (pp_expr): Report error for an invalid expression.
8868 (handle_preprocessing_directive): Simplified; add more error checking.
8870 2006-12-11 Marek Safar <marek.safar@gmail.com>
8872 A fix for bug #74939
8873 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8874 directives handling.
8876 2006-12-10 Marek Safar <marek.safar@gmail.com>
8878 A fix for bugs #80093, and #75984
8879 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8880 logic, it seems to me as it worked before "by coincidence".
8881 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8882 (cleanup): Enabled endif check.
8884 2006-12-09 Marek Safar <marek.safar@gmail.com>
8886 A fix for bug #80162
8887 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8888 enumerators are never ambiguous.
8890 2006-12-08 Raja R Harinath <rharinath@novell.com>
8893 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8895 2006-12-06 Marek Safar <marek.safar@gmail.com>
8897 A fix for bug #80144
8898 * class.cs (EventProperty.Define): Explicit implementation means
8899 that an even is used.
8901 2006-12-06 Marek Safar <marek.safar@gmail.com>
8903 Fixes the operators implementation (part II)
8905 * cfold.cs (DoConstantNumericPromotions): Renamed to
8906 DoBinaryNumericPromotions and simplified.
8907 (BinaryFold): Couple of conversion fixes; simplified.
8909 * constant.cs, ecore.cs, literal.cs
8910 (ToType): Renamed to ConvertImplicitly.
8911 (Reduce): Renamed to ConvertExplicitly.
8913 * class.cs, convert.cs: Updated.
8915 * expression.cs: TryReduce doesn't throw an exception.
8917 2006-12-01 Marek Safar <marek.safar@gmail.com>
8919 A fix for bug #80108
8920 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8923 2006-11-30 Marek Safar <marek.safar@gmail.com>
8925 Fixes unary operators implementation (part I)
8928 * cfold.cs (Error_CompileTimeOverflow): Made internal
8930 * const.cs (IConstant): Changed to use reference to constant and
8931 not constant itself.
8932 Updated IConstant implementations.
8934 * constant.cs (CreateConstant): New factory method.
8935 Updated IConstant implementation.
8937 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8939 * ecore.cs: Updated to use CreateConstantReference.
8941 * enum.cs: Reflects IConstant changes.
8943 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8945 * literal.cs (NullConstant): Change to be independently usable.
8947 2006-11-29 Martin Baulig <martin@ximian.com>
8949 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8950 we need to emit the scope initializer before calling the base .ctor.
8952 * anonymous.cs: Merged back from the new anonymous methods branch.
8953 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8955 * expression.cs (ParameterReference.DoResolveBase): Create a
8956 "normal" ScopeInfo when capturing parameters rather than using the
8957 root scope; this makes things work with anonymous methods having
8961 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8963 2006-11-22 Marek Safar <marek.safar@gmail.com>
8965 A fix for bug #79987
8966 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8967 check to a base class.
8968 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8969 only when assembly has missing attribute.
8970 * report.cs: Update.
8972 2006-11-21 Marek Safar <marek.safar@gmail.com>
8974 * cs-tokenizer.cs: Merged with gmcs version.
8976 2006-11-20 Marek Safar <marek.safar@gmail.com>
8979 * cs-parser.jay: Better error message when partial keyword is misplaced.
8981 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8983 A fix for bug #79810
8984 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8985 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8986 a RuntimeWrappedException by default.
8988 2006-11-18 Marek Safar <marek.safar@gmail.com>
8990 A fix for bug #79843
8991 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8993 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8995 2006-11-18 Marek Safar <marek.safar@gmail.com>
8997 * driver.cs, namespace.cs: Uses faster IndexOf version.
8999 2006-11-17 Marek Safar <marek.safar@gmail.com>
9001 A fix for bug #79941
9002 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9004 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9005 even if internal name is different.
9006 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9007 (UserDefinedConversion): Simplified as the operators cannot be internal.
9008 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9010 (MethodLookup): Replaced EmitContext with parentType.
9011 * expression.cs: Updated.
9013 2006-11-09 Raja R Harinath <rharinath@novell.com>
9015 * driver.cs (BadAssembly): Handle all the ugliness of
9016 DefineDynamicAssembly.
9018 2006-11-08 Raja R Harinath <rharinath@novell.com>
9020 Address parts of #58244 -- most of what's left is in the runtime
9021 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9022 CS1509 error checks, and handle them for all assembly loads, not
9023 just the first invocation.
9024 (LoadModule): Likewise. Move handling of 'adder_method' ...
9025 * codegen.cs (AssemblyClass.AddModule): ... here.
9027 2006-11-02 Marek Safar <marek.safar@gmail.com>
9029 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9030 IEnumerable<T> is ambiguous.
9032 2006-10-31 Marek Safar <marek.safar@gmail.com>
9034 A fix for bug #67689
9035 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9036 GetEnumerator is ambiguous.
9038 * report.cs: Add new warning.
9040 2006-10-29 Marek Safar <marek.safar@gmail.com>
9042 A fix for bug #78602
9043 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9044 to protected member can be nested type.
9046 2006-10-28 Marek Safar <marek.safar@gmail.com>
9048 A fix for bug #78965
9049 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9050 to protected member must derive from current type.
9052 2006-10-27 Marek Safar <marek.safar@gmail.com>
9054 assign.cs: Reuses error method.
9056 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9057 instead of type for constants.
9058 (Expression.Error_ValueAssignment): Common error method.
9060 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9063 2006-10-27 Marek Safar <marek.safar@gmail.com>
9065 A fix for bug #79081
9066 * expression.cs (MemberAccess.DoResolve): Check nested type
9069 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9071 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9073 2006-10-26 Marek Safar <marek.safar@gmail.com>
9075 A fix for bug #76591
9076 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9078 2006-10-26 Marek Safar <marek.safar@gmail.com>
9080 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9081 type forwarder of the same type multiple times.
9083 2006-10-26 Raja R Harinath <rharinath@novell.com>
9086 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9087 instance as an rvalue, even when we later resolve as an lvalue.
9089 2006-10-25 Martin Baulig <martin@ximian.com>
9091 * anonymous.cs: Fix #79673.
9093 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9095 A fix for bug #79666
9096 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9097 ignored when is optimized (= default value) as its value is already set.
9099 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9101 A fix for bug #79724
9102 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9103 TypeContainer for type lookup.
9105 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9107 A fix for bug #79231
9108 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9109 * expression.cs (OverloadResolve): Always convert type name for
9111 (ResolveNamespaceOrType): Don't confuse a nested type with any
9114 2006-10-18 Martin Baulig <martin@ximian.com>
9116 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9118 2006-10-17 Miguel de Icaza <miguel@novell.com>
9120 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9121 an int32, but requesting an int64 from the conversion
9123 2006-10-12 Martin Baulig <martin@ximian.com>
9126 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9128 2006-10-12 Martin Baulig <martin@ximian.com>
9131 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9133 2006-10-11 Miguel de Icaza <miguel@novell.com>
9135 * convert.cs: Remove broken code: I was doing the "Existance"
9136 tests for Implicit conversions.
9138 2006-10-10 Miguel de Icaza <miguel@novell.com>
9140 * convert.cs: Added one missing case in
9141 ImplicitStandardConversionExists uint64 to intptr.
9145 * typemanager.cs (uintptr_type): another core known type.
9147 * ecore.cs (OperatorCast): routine used to do cast operations that
9148 depend on op_Explicit. We could change some of the Decimal
9149 conversions to use this.
9151 This one has a probe mechanism that checks both types for an op_
9152 which it coudl be used to eliminate two classes: CastToDecimal
9153 and CastFromDecimal.
9155 * convert.cs: Implement the conversions documented in #59800
9157 2006-10-10 Martin Baulig <martin@ximian.com>
9159 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9160 before RootScope.ResolveMembers().
9162 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9163 `CurrentType' if appropriate.
9165 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9167 A fix for bug #78568
9168 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9169 when contains binary operators.
9170 * cs-parser.jay: Updated.
9172 2006-10-09 Martin Baulig <martin@ximian.com>
9175 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9176 moved that into Define() and also do the other type parameter
9177 checks there. Fixes #79094. Added gtest-292.cs.
9180 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9181 since that doesn't include type parameters; don't use `Ldelema'
9182 for type parameters. Fixes #78980. Added gtest-293.cs.
9184 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9187 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9188 conversion is allowed.
9190 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9192 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9193 error reporting when no error occurs.
9195 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9197 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9200 2006-10-06 Raja R Harinath <rharinath@novell.com>
9203 * class.cs (DefineTypeBuilder): Check circular dependencies before
9204 setting the parent of the TypeBuilder.
9205 (CheckRecursiveDefinition): Don't use 'BaseType', since
9206 it may not be valid until after DefineTypeBuilder. Use
9207 'base_type' instead.
9209 2006-10-04 Martin Baulig <martin@ximian.com>
9211 Merged the Anonymous Methods patch.
9213 * anonymous.cs, iterators.cs: The new anonymous methods code.
9215 * statement.cs (Variable): New public abstract class.
9216 (LocalInfo.Variable): New public property.
9217 (LocalInfo.ResolveVariable): New public method.
9218 (Block.Flags): Add `IsIterator'.
9219 (Block.AddVariable): Improved the CS0136 check.
9220 (Block.AnonymousChildren): New public property.
9221 (Block.AddAnonymousChild): New public method.
9222 (ToplevelBlock): Update to use the new anonymous method framework.
9223 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9224 `ToplevelBlock'; this is required to correctly implement the
9226 (Fixed, Using): Use `TemporaryVariable' instead of directly
9227 creating the `LocalBuilder'.
9229 * parameter.cs (Parameter.ResolveVariable): New public method.
9230 (Parameters.ResolveVariable): Likewise.
9232 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9234 * class.cs (TypeContainer): Replaced the `iterators' list and
9235 corresponding methods with a list of `CompilerGeneratedClass'es.
9236 (TypeContainer.ResolveMembers): New public method.
9237 (Method): `IIteratorContainer' has been replaced by
9240 * expression.cs (VariableReference): New public abstract base
9241 class for `LocalVariableReference', `ParameterReference' and
9244 * codegen.cs (EmitContext): Removed `capture_context',
9245 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9246 (EmitContext.EmitThis): Removed.
9248 * cs-parser.jay: Replace `iterator_container' with
9251 2006-10-04 Martin Baulig <martin@ximian.com>
9253 * generic.cs (GenericMethod): Don't make this abstract.
9254 (Constraints.Clone): Added dummy implementation.
9256 2006-10-04 Raja R Harinath <harinath@gmail.com>
9259 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9260 'declspaces'. Avoid allocating arrays willy-nilly.
9263 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9264 cases out of the switch.
9266 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9268 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9269 message when non-generic type is used with the type arguments.
9270 * expression.cs: Updated.
9272 2006-09-28 Raja R Harinath <rharinath@novell.com>
9275 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9276 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9277 Change semantics slightly. Don't insist on having only one
9278 temporary EmptyExpression -- just throttle the creation of new ones.
9281 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9282 non-interfaces too. If no methods are found, don't try to create
9285 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9287 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9290 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9291 us produce better error message.
9293 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9295 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9296 of the `|' operator.
9298 * report.cs: A new warning added.
9300 2006-09-27 Martin Baulig <martin@ximian.com>
9302 * generic.cs (GenericMethod): Don't make this abstract.
9304 2006-09-27 Martin Baulig <martin@ximian.com>
9307 (InternalErrorException): Added overloaded ctor taking a params array.
9309 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9311 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9312 Fixed the cases when same error was reported twice.
9314 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9315 now report symbol information.
9317 2006-09-25 Martin Baulig <martin@ximian.com>
9319 * class.cs: Completely unified with the gmcs version.
9321 2006-09-25 Martin Baulig <martin@ximian.com>
9323 * typemanager.cs (TypeManager.IsNullableType): New public function.
9324 (TypeManager.IsNullableTypeOf): Likewise.
9325 (TypeManager.IsNullableValueType): Likewise.
9327 * class.cs (MethodCore): Added the `GenericMethod' argument from
9328 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9330 2006-09-24 Raja R Harinath <harinath@gmail.com>
9332 * convert.cs: Unify with gmcs version.
9334 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9336 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9337 verify them as well.
9339 * report.cs: New warning.
9341 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9343 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9344 for anonymous block with out argument.
9346 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9348 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9349 not used private events only.
9351 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9353 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9355 * const.cs (Const.Define): Check for constant type.
9356 (Const.IsConstantTypeValid): Looks for valid constant types.
9358 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9360 * ecore.cs (EmptyConstantCast): New common class for all constant based
9363 * expression.cs (Is.DoResolve): Handle null constant especially.
9364 (New.DoResolve): Check for new void().
9365 (MemberAccess.DoResolve): Cope with all kind of nulls.
9367 * literal.cs (NullConstant): Uses EmptyConstantCast.
9368 (NullDefault): Based on EmptyConstantCast.
9369 (NullLiteral): Uses EmptyConstantCast.
9371 * statement.cs (Block.ResolveMeta): Check for constant type.
9373 2006-09-22 Martin Baulig <martin@ximian.com>
9375 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9377 2006-09-22 Raja R Harinath <rharinath@novell.com>
9379 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9383 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9384 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9387 2006-09-22 Martin Baulig <martin@ximian.com>
9389 * ecore.cs: Merged with the gmcs version.
9391 * generic.cs (ConstructedType): New dummy class.
9392 (TypeArguments): Don't make this abstract.
9395 (TypeManager.IsGenericTypeDefinition): New method.
9396 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9398 2006-09-22 Raja R Harinath <rharinath@novell.com>
9400 * expression.cs (ComposedCast): Check for arrays of TypedReference
9401 before creating the type, not after.
9403 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9405 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9406 after ToType change.
9408 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9409 when constant must be implicitly convertible.
9411 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9413 * ecore.cs (NullCast): Derives from NullConstant.
9415 * expression.cs (Is.DoResolve): Removed useless variables.
9416 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9417 (New.Constantify): Add enum support.
9418 (MemberAccess.DoResolve): Add warning when accessing null constant or
9421 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9424 * literal.cs (NullConstant): New abstract class with common
9425 functionality for all null specializations.
9426 (NullDefault): Represents default(X) when result can be
9428 (NullLiteral): Updated.
9430 * report.cs: Add new warning.
9432 2006-09-21 Martin Baulig <martin@ximian.com>
9434 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9436 2006-09-21 Martin Baulig <martin@ximian.com>
9438 * generic.cs (GenericConstraints): New dummy class.
9439 (Constraints): Likewise.
9440 (TypeParameter): Likewise.
9441 (TypeParameterName): Likewise.
9442 (GenericMethod): Likewise.
9444 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9446 * decl.cs: Merged with the gmcs version.
9448 2006-09-21 Raja R Harinath <rharinath@novell.com>
9450 * generic.cs (TypeParameter): Implement IMemberContainer.
9451 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9453 * rootcontext.cs: Unify with gmcs version.
9455 * report.cs: Unify with gmcs version.
9456 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9457 from gmcs/generics.cs.
9458 * generics.cs (TypeParameter): New dummy class.
9460 * support.cs: Unify with gmcs version.
9462 2006-09-20 Raja R Harinath <rharinath@novell.com>
9464 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9465 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9467 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9468 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9469 * mcs.exe.sources: Add generic.cs.
9471 * codegen.cs: Unify with gmcs version.
9473 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9474 (EmitContext): Add GenericDeclContainer implementation.
9475 * decl.cs (MemberCore, DeclSpace): Likewise.
9476 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9478 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9479 MCS TypeManager has a corresponding dummy method.
9481 2006-09-19 Martin Baulig <martin@ximian.com>
9483 * expression.cs: Completely merged with the gmcs version.
9485 2006-09-19 Martin Baulig <martin@ximian.com>
9487 * expression.cs (Invocation): Merged with the gmcs version.
9488 (ArrayAccess.GetStoreOpcode): Likewise.
9490 2006-09-19 Martin Baulig <martin@ximian.com>
9493 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9494 (TypeManager.IsGenericMethodDefinition): Likewise.
9496 2006-09-19 Martin Baulig <martin@ximian.com>
9499 (TypeManager.IsEqual): Moved the gmcs implementation here.
9500 (TypeManager.DropGenericTypeArguments): Likewise.
9501 (TypeManager.DropGenericMethodArguments): Likewise.
9502 (TypeManager.GetTypeArguments): Moved here from gmcs.
9503 (TypeManager.HasGenericArguments): Likewise.
9505 2006-09-19 Martin Baulig <martin@ximian.com>
9507 * expression.cs (Binary): Merged with the gmcs version.
9509 2006-09-19 Martin Baulig <martin@ximian.com>
9511 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9513 2006-09-19 Martin Baulig <martin@ximian.com>
9515 * typemanager.cs: Merged with the gmcs version.
9517 2006-09-16 Raja R Harinath <rharinath@novell.com>
9519 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9520 * driver.cs: Likewise.
9522 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9525 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9526 only if parent type is class.
9527 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9530 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9533 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9535 * typemanager.cs(CSharpName): Converts NullType to null.
9537 2006-09-15 Martin Baulig <martin@ximian.com>
9540 (TypeManager.GetMethodName): Added mcs implementation.
9541 (TypeManager.IsEqual): Likewise.
9544 (SimpleName.RemoveGenericArity): Added dummy implementation.
9546 * pending.cs: Merged with the gmcs version.
9548 2006-09-15 Martin Baulig <martin@ximian.com>
9550 * statement.cs: Merge with the gmcs version.
9552 2006-09-15 Martin Baulig <martin@ximian.com>
9554 * statement.cs (Switch): Merge with the gmcs implementation
9555 (without nullables), which is newer.
9557 2006-09-15 Martin Baulig <martin@ximian.com>
9559 * statement.cs (Block.Variables): Make this public.
9560 (ToplevelBlock.Parameters): Make this a property.
9561 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9563 2006-09-15 Martin Baulig <martin@ximian.com>
9565 * namespace.cs: Merge with the gmcs version.
9567 2006-09-15 Martin Baulig <martin@ximian.com>
9569 * decl.cs (MemberName): Minor code cleanups.
9571 2006-09-15 Martin Baulig <martin@ximian.com>
9573 * parameter.cs: Merge with the gmcs version.
9575 2006-09-15 Martin Baulig <martin@ximian.com>
9577 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9578 and an error in mcs.
9580 2006-09-15 Martin Baulig <martin@ximian.com>
9582 * flowanalysis.cs: Merged from GMCS; added the generics code into
9583 a `GMCS_SOURCE' conditional so we can share this file.
9585 2006-09-08 Martin Baulig <martin@ximian.com>
9587 * typemanager.cs (TypeManager.interlocked_type): New public field.
9588 (TypeManager.int_interlocked_compare-exchange): New public field.
9589 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9590 enumerator types here and call InitGenericCoreTypes().
9591 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9592 after calling InitEnumUnderlyingTypes().
9595 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9596 `classes_second_stage'.
9598 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9600 * assign.cs, ecore.cs, expression.cs: Share error message text.
9601 * class.cs (FieldMember.Define): Check for varible of static type.
9602 * driver.cs (LoadAssembly): Uses error output for errors.
9603 * statement.cs: Updated.
9605 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9607 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9610 2006-09-07 Martin Baulig <martin@ximian.com>
9613 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9615 2006-08-29 Miguel de Icaza <miguel@novell.com>
9617 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9619 2006-08-17 Miguel de Icaza <miguel@novell.com>
9621 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9622 #52019 and #79064, the use of the \uXXXX sequence in source code
9623 to represent unicode characters.
9625 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9627 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9629 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9631 2006-08-13 Miguel de Icaza <miguel@novell.com>
9633 * assign.cs: Catch attempts to assign to a method groups in += and
9636 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9639 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9641 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9643 * class.cs (Method.Define): Issue a warning when generic method looks like
9645 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9648 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9650 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9652 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9653 search all base interfaces as a member can be ambiguous.
9654 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9655 Constructor member type filter.
9656 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9657 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9658 reporting for returned memberinfos.
9659 * report.cs: Updated.
9660 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9661 version to work on all runtimes.
9662 (TypeManager.RealMemberLookup): Removed members filtering.
9664 2006-08-08 Raja R Harinath <rharinath@novell.com>
9666 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9667 (PropertyExpr.EmitAssign): Likewise.
9668 * expression.cs (Indirection.EmitAssign): Likewise.
9669 (LocalVariableReference.EmitAssign): Likewise.
9670 (ParameterReference.EmitAssign): Likewise.
9671 (Invocation.EmitArguments): Likewise.
9672 (ArrayAccess.EmitAssign): Likewise.
9673 (IndexerAccess.EmitAssign): Likewise.
9674 (This.EmitAssign): Likewise.
9675 (ConditionalLogicalOperator.Emit): Likewise.
9678 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9679 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9680 leave it in after returning it.
9681 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9683 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9685 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9688 2006-08-03 Raja R Harinath <rharinath@novell.com>
9690 Fix cs0146-3.cs and cs0146-4.cs.
9691 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9692 enclosing types don't depend on the current type.
9694 2006-08-02 Raja R Harinath <rharinath@novell.com>
9697 * class.cs (TypeContainer.DoDefineMembers): Use
9698 FindBaseMemberWithSameName on Parent, since we're interested in
9699 whether we hide inherited members or not.
9700 (FindBaseMemberWithSameName): Make slightly more robust.
9702 Fix the non-generic testcase from #77396
9703 * decl.cs (DeclSpace.DeclContainer): Remove override.
9705 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9706 declspaces for doppelgangers too.
9707 (UsingEntry): Implement IResolveContext.
9708 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9709 'this' as the resolve context.
9710 (LocalAliasEntry): Likewise.
9712 Implement parts of #77403
9713 * roottypes.cs (RootDeclSpace): New. Used to represent the
9714 toplevel declaration space. Each namespace declaration introduces
9715 a "partial" root declaretion space.
9716 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9717 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9718 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9719 from 'current_namespace.SlaveDeclSpace'.
9720 (namespace_declaration): Likewise.
9721 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9722 check. It can't happen now.
9723 * decl.cs (DeclSpace.LookupType): Likewise.
9724 * driver.cs (MainDriver): Sanity check.
9726 2006-08-01 Raja R Harinath <rharinath@novell.com>
9728 * decl.cs (DeclSpace.FindNestedType): Remove.
9729 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9730 LookupTypeContainer to get the container of the nested type.
9731 * class.cs (TypeContainer.FindNestedType): Make non-override.
9733 2006-07-31 Raja R Harinath <rharinath@novell.com>
9735 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9736 * class.cs (TypeContainer.PartialContainer): ... here.
9737 (TypeContainer.AddBasesForPart): New helper.
9738 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9740 * cs-parser.jay (current_class): Convert to DeclSpace.
9741 (struct_declaration, interface_declaration, class_declaration):
9742 Use AddBasesForPart instead of .Bases directly.
9743 * const.cs, iterators.cs: Update to changes.
9745 2006-07-28 Raja R Harinath <rharinath@novell.com>
9747 * class.cs (TypeContainer.AddMemberType): Rename from
9749 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9750 (AddTypeContainer): New. Combine AddClassOrStruct and
9752 (AddPartial): Update. Add 'is_partial' argument.
9753 * roottypes.cs: Update to changes.
9754 * cs-parser.jay (push_current_class): New helper for handling
9755 current_container and current_class.
9756 (struct_declaration, interface_declaration, class_declaration):
9759 2006-07-26 Raja R Harinath <rharinath@novell.com>
9761 * roottypes.cs: Rename from tree.cs.
9763 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9764 * tree.cs (Tree, ITreeDump): Remove types.
9765 * rootcontext.cs (tree, Tree): Remove fields.
9766 (root, ToplevelTypes): New.
9767 * *.cs: Update to rename.
9769 * tree.cs (Tree.RecordDecl): Remove.
9770 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9772 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9774 2006-07-23 Raja R Harinath <harinath@gmail.com>
9776 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9777 DoFlowAnalysis and OmitStructFlowAnalysis here.
9778 (ec.With): Rename from WithUnsafe and generalize.
9779 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9780 (ec.WithFlowAnalyis): New.
9781 * ecore.cs, expression.cs, statement.cs: Update.
9783 2006-07-22 Raja R Harinath <harinath@gmail.com>
9785 * statement.cs (Block.ResolveMeta): Simplify slightly.
9787 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9788 multiple boolean fields. Convert InUnsafe, constant_check_state,
9789 check_state to flags.
9790 (CheckState, ConstantCheckState): Update.
9791 (InUnsafe): New read-only property.
9792 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9794 (WithUnsafe): New helper similar to WithCheckState.
9795 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9796 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9798 2006-07-21 Raja R Harinath <rharinath@novell.com>
9800 Make comparisons use the same IL irrespective of whether they're
9801 in a 'checked' or 'unchecked' context: one of the issues in #78899
9802 * codegen.cs (EmitContext.CheckState): Make read-only property.
9803 (EmitContext.ConstantCheckState): Likewise.
9804 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9805 helper that implement a save/restore stack for CheckState
9806 values. This is the only way to change check-state.
9807 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9808 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9809 (CheckedExpr.EmitBranchable): New forwarding method.
9810 (UnCheckedExpr): Likewise.
9811 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9812 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9813 (Checked.Resolve, checked.DoEmit): Likewise.
9815 2006-07-20 Miguel de Icaza <miguel@novell.com>
9817 * anonymous.cs: Cache the resolved anonymous delegate, and return
9818 this so that the ResolveTopBlock is only triggered once, not
9821 Currently we trigger ResolvetopBlock twice due to a first pass of
9822 argument check compatibility, and a second pass that does the
9825 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9827 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9829 * rootcontext.cs (Reset): Add helper_classes.
9831 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9834 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9837 2006-07-13 Miguel de Icaza <miguel@novell.com>
9839 * statement.cs (Lock): Handle expressions of type
9840 TypeManager.null_type specially. Fixes #78770
9842 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9844 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9847 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9849 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9850 for accessors as well.
9851 * ecore.cs (EventExpr): Add AccessorTable.
9853 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9856 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9857 for CS0122 where appropriate.
9858 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9860 (Filter): Assembly can be null in the case of top level attributes.
9862 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9866 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9867 is done at global level.
9869 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9871 A fix for #77002, Implemented TypeForwarder support.
9873 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9874 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9875 * typemanager.cs (): Add type_forwarder_attr_type.
9877 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9879 * report.cs: Add CS0469 warning.
9881 2006-06-21 Martin Baulig <martin@ximian.com>
9883 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9884 the `try'-block, so we also report CS0016 etc. there.
9886 2006-06-21 Martin Baulig <martin@ximian.com>
9889 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9891 2006-06-21 Martin Baulig <martin@ximian.com>
9893 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9894 also report CS1686 for parameters.
9896 2006-06-21 Martin Baulig <martin@ximian.com>
9898 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9899 instead of an error if the value is not implicitly convertible to
9900 the switch types; fixes #77964.
9902 2006-06-21 Raja R Harinath <rharinath@novell.com>
9905 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9906 FieldBuilder is null.
9909 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9910 'left' and 'right' before error-checking.
9912 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9914 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9916 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9917 (FieldExpr.DoResolve): likewise.
9918 (PropertyExpr.InstanceResolve): likewise.
9919 (EventExpr.InstanceResolve): likewise.
9921 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9923 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9924 attribute applicable tests for attribute argument.
9926 2006-06-02 Raja R Harinath <rharinath@novell.com>
9929 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9930 (Binary.OverloadResolve_PredefinedIntegral): New.
9931 (Binary.OverloadResolve_PredefinedFloating): New.
9932 (Binary.OverloadResolve_PredefinedString): New.
9933 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9934 Follow the standard more closely, and treat numeric promotions in
9935 terms of overload resolution.
9936 (Binary.CheckShiftArguments): Simplify.
9938 2006-06-01 Raja R Harinath <rharinath@novell.com>
9940 * flowanalysis.cs (MyBitVector): Simplify representation.
9941 (MyBitVector.Clone): Avoid allocating BitArray.
9942 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9943 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9944 (*): Update. Change all references to MyBitVector.And and
9945 MyBitVector.Or to &= and |=.
9947 2006-05-29 Raja R Harinath <rharinath@novell.com>
9950 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9951 to param arguments too.
9953 2006-05-26 Miguel de Icaza <miguel@novell.com>
9955 * cs-parser.jay: Catch another parsing form for arglist being
9956 followed by other arguments. Fixes #78313.
9958 2006-05-24 Raja R Harinath <rharinath@novell.com>
9960 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9961 checking of out parameters to ...
9962 (FlowBranchingToplevel.Merge): ... here.
9963 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9964 set, propagate the origin upward, and only complain if there was
9966 (FlowBranchingException.AddContinueOrigin): Likewise.
9967 (FlowBranchingException.AddReturnOrigin): Likewise.
9968 (FlowBranchingException.AddGotoOrigin): Likewise.
9970 2006-05-23 Raja R Harinath <rharinath@novell.com>
9972 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9973 unreachable, skip it.
9974 (FlowBranchingException.Merge): Always propagate jumps, even if
9975 the finally block renders subsequent code unreachable.
9977 2006-05-18 Raja R Harinath <rharinath@novell.com>
9980 * statement.cs (Goto.Resolve): Move responsibility for resolving
9981 'goto' to FlowBranching.AddGotoOrigin.
9982 (Goto.SetResolvedTarget): New. Callback to set the
9983 LabeledStatement that's the target of the goto.
9984 (Goto.DoEmit): Use Leave instead of Br when crossing an
9985 unwind-protect boundary.
9986 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9987 LookupLabel and adjust to new semantics.
9988 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9989 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9990 Goto.SetResolvedTarget to update target.
9991 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9992 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9993 AddBreakOrigin & co. Delay propagation until ...
9994 (FlowBranchingException.Merge): ... this.
9996 * statement.cs (Block.Resolve): Always depend on flow-branching to
9997 determine unreachability. Kill workaround that originally emitted
9998 only one statement after an "unreachable" label (see infloop in
10001 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10002 This is still "wrong", but anything better would probably need a
10003 multi-pass algorithm.
10004 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10005 usage vector. Force current usage vector to be reachable, to
10006 optimistically signify backward jumps.
10007 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10009 (FlowBranchingLabeled.Merge): New. If no backward jump was
10010 detected, return the original salted-away usage vector instead,
10011 updated with appropriate changes. Print unreachable warning if
10013 * statement.cs (Block.Resolve): Don't print unreachable warning on
10014 a labeled statement.
10016 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10018 * driver.cs: Pass filename without path to AssemblyBuilder's
10019 AddResourceFile. Fixes bug #78407.
10021 2006-05-17 Raja R Harinath <rharinath@novell.com>
10023 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10024 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10025 (FlowBranching.MergeChild): Overwrite
10026 reachability information from Labeled branchings too.
10028 2006-05-16 Raja R Harinath <rharinath@novell.com>
10030 * statement.cs (Goto.Resolve): Merge jump origins here ...
10031 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10033 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10034 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10035 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10036 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10038 * statement.cs (Goto.Resolve): ... not here.
10039 (Goto.Emit): Remove CS1632 check.
10041 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10043 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10046 2006-05-11 Raja R Harinath <rharinath@novell.com>
10048 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10049 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10050 (FlowBranchingException.Label): Likewise.
10052 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10054 (MyBitVector.Or): Use it to avoid losing information (Count).
10055 (FlowBranching.MergeOrigins): Likewise.
10057 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10058 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10059 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10060 (UsageVector.ToString): Simplify.
10061 (UsageVector.MergeSiblings): Move here from ...
10062 (FlowBranching.Merge): ... here.
10063 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10066 2006-05-10 Raja R Harinath <rharinath@novell.com>
10068 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10069 null bitvector is treated as all-true.
10071 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10072 (MyBitVector): Rationalize invariants. 'vector != null' implies
10073 that we have our own copy of the bitvector. Otherwise,
10074 'InheritsFrom == null' implies all inherited bits are true.
10076 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10078 * statement.cs (LocalInfo): Add IsConstant.
10079 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10080 local variable for constants.
10082 2006-05-09 Raja R Harinath <rharinath@novell.com>
10084 * flowanalysis.cs (MyBitVector.Empty): New.
10085 (MyBitVector): Don't allow InheritedFrom to be null.
10086 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10087 (UsageVector, FlowBranching): Update to changes.
10089 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10090 recursion. The 'Parent == null' condition isn't sufficient for
10092 (FlowBranching.AddBreakOrigin): Likewise.
10093 (FlowBranching.AddContinueOrigin): Likewise.
10094 (FlowBranching.AddReturnOrigin): Likewise.
10095 (FlowBranching.StealFinallyClauses): Likewise.
10096 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10097 (FlowBranching.CheckOutParameters): Likewise.
10098 (FlowBranchingToplevel): Terminate all the above recursions here.
10099 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10100 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10102 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10104 (FlowBranchingToplevel): New. Empty for now.
10105 (FlowBranching.MergeTopBlock): Update.
10106 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10107 branching for the anonymous delegate.
10108 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10110 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10111 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10112 information at the start of the merge. Reorganize.
10114 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10116 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10118 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10120 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10121 to newly introduced ctor.
10123 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10124 message to one place.
10125 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10128 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10130 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10132 * ecore.cs (Expression.ResolveAsConstant): Updated.
10134 * statement.cs (ResolveMeta): Updated.
10136 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10138 * cs-parser.jay: __arglist cannot be used in initializer.
10140 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10143 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10146 2006-05-05 Raja R Harinath <rharinath@novell.com>
10148 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10149 (LabeledStatement): Add 'name' parameter.
10150 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10151 (Block.AddLabel): Update to changes.
10152 * cs-parser.jay (labeled_statement): Likewise.
10154 * flowanalysis.cs (BranchingType.Labeled): New.
10155 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10156 (FlowBranchingLabeled): New. Does nothing for now, but will
10157 eventually handle 'goto' flows.
10158 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10159 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10160 that's terminated ...
10161 (Block.Resolve): ... here.
10163 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10164 (UsageVector.MergeFinallyOrigins): Likewise.
10165 (FlowBranching.InTryOrCatch): Likewise.
10166 (FlowBranching.AddFinallyVector): Likewise.
10167 (FlowBranchingException): Update to changes.
10170 * statement.cs (Return.Resolve): Move error checking to ...
10171 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10172 (FlowBranchingException): Handle return origins like break and
10174 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10176 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10179 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10182 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10185 * class.cs (MethodData.Define): Do public accessor check only when method
10186 implements an interface.
10188 2006-05-04 Raja R Harinath <rharinath@novell.com>
10190 Remove special handling of 'break'
10191 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10192 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10193 (UsageVector.Break): Remove.
10194 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10196 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10198 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10199 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10201 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10204 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10205 be the interface member.
10207 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10210 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10211 for emitting small (int) values.
10213 2006-05-03 Raja R Harinath <rharinath@novell.com>
10216 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10217 control-flow passes through the 'finally' after merging-in all the
10218 control-flows from 'try' and the 'catch' clauses.
10220 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10221 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10222 always true at the only non-recursive entry point.
10223 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10224 FlowBranchingBreakable.
10225 (FlowBranchingLoop): Remove.
10226 * statement.cs (Return.DoResolve): Update to changes.
10229 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10230 (FlowBranching.CreateBranching): Handle it: create a
10231 FlowBranchingContinuable.
10232 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10233 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10234 except that it handles the 'continue' command.
10235 (FlowBranching.UsageVector.MergeOrigins): Rename from
10237 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10238 except that it overrides AddContinueOrigin.
10239 (FlowBranchingException): Override AddContinueOrigin, similar to
10241 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10242 Create a new branching around the embedded statement.
10243 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10244 control flow after the embedded statement.
10245 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10247 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10248 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10249 FlowBranchingBreakable.
10250 (FlowBranchingSwitch): Remove.
10253 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10254 error reporting to ...
10255 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10256 Rename from 'AddBreakVector'. Add new location argument. Return
10257 a bool indicating whether the 'break' crosses an unwind-protect.
10258 (FlowBranchingException.AddBreakOrigin): Add.
10259 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10260 flowbranching after updating with the effects of the 'finally'
10262 (FlowBranchingBreakable): New common base class for
10263 FlowBranchingLoop and FlowBranchingSwitch.
10265 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10266 embedded statement.
10267 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10269 2006-05-02 Raja R Harinath <rharinath@novell.com>
10271 * statement.cs (Do.Resolve): If the loop is infinite, set the
10273 (While.Resolve, For.Resolve): Set a barrier after the embedded
10274 statement. There's no direct control flow that goes from the end
10275 of the embedded statement to the end of the loop.
10276 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10277 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10278 above ensure that the reachability is correctly computed.
10280 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10281 (UsageVector.MergeBreakOrigins): If the current path is
10282 unreachable, treat it as if all parameters/locals are initialized.
10283 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10284 infinite loops before merging-in break origins.
10286 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10287 (Reachability.Reachable): Split part into ...
10288 (Reachability.Unreachable): ... this. Simplify.
10289 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10291 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10292 (Reachability.SetThrowsSometimes): Likewise.
10293 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10294 TriState.Always, use corresponding property.
10295 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10296 (Block.Resolve): Likewise. Remove some redundant checks.
10298 2006-05-02 Raja R Harinath <harinath@gmail.com>
10300 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10301 (Reachability.Meet): Don't bother checking AlwaysThrows --
10302 barrier is always set.
10303 (FlowBranchingBlock.Merge): Likewise.
10305 2006-05-01 Raja R Harinath <harinath@gmail.com>
10307 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10308 checks for unreachable.
10310 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10313 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10315 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10316 whether field is really assigned.
10318 2006-04-30 Raja R Harinath <harinath@gmail.com>
10320 * flowanalysis.cs (Reachability): Make 4-argument constructor
10322 (Reachability.Meet): Rename from 'And'. Remove static variant.
10323 (Reachability.Always): Rename from the highly misleading
10324 'Reachability.Never'.
10325 (FlowBranching.Merge): Update to changes. Mark an impossible
10326 situation with a 'throw'.
10327 (*): Update to changes.
10329 2006-04-29 Raja R Harinath <harinath@gmail.com>
10331 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10332 Remove 'Undefined'.
10333 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10334 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10335 (*): Update to changes.
10336 * statement.cs: Update to changes.
10338 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10341 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10343 2006-04-28 Raja R Harinath <harinath@gmail.com>
10345 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10348 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10349 argument to two arguments: an usage-vector and a bool. Move call
10350 to FlowBranching.Merge () ...
10351 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10353 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10354 handling of loop and switch reachability to ...
10355 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10357 2006-04-27 Raja R Harinath <harinath@gmail.com>
10359 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10360 handling to FlowBranchingLoop.InLoop.
10361 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10363 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10366 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10367 anonymous method is allowed from AnonymousContainer here.
10369 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10371 2006-04-24 Raja R Harinath <rharinath@novell.com>
10374 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10376 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10379 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10380 (DoubleConstant.Reduce): Ditto.
10382 2006-04-23 Raja R Harinath <rharinath@novell.com>
10384 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10385 Remove 'lvalue_right_side' argument. Move parts to ...
10386 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10387 (LocalVariable.DoResolveLValue): ... these.
10389 2006-04-21 Raja R Harinath <rharinath@novell.com>
10392 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10393 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10394 (LocalVariableReference.DoResolveBase): Use it to implement new
10396 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10397 (Argument.Resolve): Simplify. Move CS1510 check ...
10398 * ecore.cs (Expression.ResolveLValue): ... here.
10399 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10400 (PropertyExpr.DoResolveLValue): Likewise.
10401 (FieldExpr.Report_AssignToReadonly): Likewise.
10402 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10403 LValueMemberAccess or LValueMemberOutAccess on instance depending
10405 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10406 DoResolve as appropriate.
10408 2006-04-20 Raja R Harinath <rharinath@novell.com>
10411 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10412 implicit conversions on 'out' and 'ref' arguments.
10414 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10415 improve clarity. Remove dead code.
10418 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10419 (Catch.Resolve): Resolve VarBlock if it exists.
10421 2006-04-19 Miguel de Icaza <miguel@novell.com>
10423 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10424 twice, this was some residual code, the enumerator was emitted
10425 properly in the two branche of if later.
10427 2006-04-19 Raja R Harinath <rharinath@novell.com>
10429 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10430 cast is never an lvalue.
10431 (Cast.DoResolve, Cast.ResolveRest): Combine.
10432 (Argument.Emit): Simplify slightly. Move 'Expr is
10433 IMemoryLocation' check ...
10434 (Argument.Resolve): ... here.
10435 (Argument.Error_LValueRequired): Remove. Inline into only user.
10437 Simplifications. Fix cs0191-2.cs
10438 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10439 CS1649 and CS1651 to ...
10440 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10441 the actual selection of the error code and message to a lookup
10442 table. Add a dummy return value to simplify callsites.
10443 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10444 readonly fields of other instances of the same type. Move CS0197
10446 * expression.cs (Argument.Resolve): ... here. Simplify code.
10447 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10448 resolution of an out or ref argument. The code simplification
10449 above uses this invariant.
10451 2006-04-18 Raja R Harinath <rharinath@novell.com>
10453 Possibly fix #77752. Fix cs1690-[4-7].cs.
10454 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10455 CheckMarshallByRefAccess. Drop parameter.
10456 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10458 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10459 InstanceExpression.
10460 * report.cs (AllWarnings): Add CS1690.
10461 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10462 for ref access too.
10463 (LocalVariableReference.DoResolveBase): Update.
10465 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10467 * class.cs (MethodOrOperator): Moved common parts from method class.
10468 detect obsolete attributes.
10469 (Method.Define): Simplified as it reuses code from base.
10470 (Constructor.ValidAttributeTargets): Fixed issue found during
10472 (Destructor.ValidAttributeTargets): Fixed issue found during
10474 (Operator): Finished refactoring set off by #78020. Operator class is now
10475 ordinary method class.
10477 * anonymous.cs: Updated.
10479 * decl.cs (DeclSpace): Add IsGeneric
10481 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10483 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10485 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10487 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10488 detect obsolete attributes.
10489 (Method.CreateEmitContext): Moved to MethodOrOperator.
10491 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10494 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10495 customized exception to make crash detection easier.
10496 (MethodOrOperator): Started to work on new base class for methods and
10498 (Method): Derives from MethodOrOperator.
10499 (Constructor.Emit): Emits its own attributes.
10500 (AbstractPropertyEventMethod.Emit): Ditto.
10501 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10503 (Operator.Emit): It's temporary more tricky than should be.
10505 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10507 * report.cs (InternalErrorException): Add ctor with inner exception.
10509 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10512 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10515 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10518 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10521 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10523 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10524 attribute is present and Guid not.
10525 (Interface.ApplyAttributeBuilder): Ditto.
10527 * attribute.cs: Add error message.
10529 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10533 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10534 sources (it's composite) so hold them in extra array as they are used in
10535 Emit phase only. It worked in the previous versions by mistake.
10536 (Attribute.Emit): Emit attribute for more owners when exist.
10538 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10539 it has now different behaviour.
10541 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10543 * constant.cs (Constant.IsDefaultInitializer): New method.
10545 * class.cs: Updated.
10547 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10548 re-initialize default values. It saves KBs almost for every assembly.
10549 Thanks Zoltan for the idea.
10550 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10551 (ArrayCreation.DoResolve): Resolve only once.
10552 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10553 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10555 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10557 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10560 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10562 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10563 in an embedded statement too.
10565 2006-04-01 Raja R Harinath <rharinath@novell.com>
10568 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10570 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10574 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10577 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10579 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10581 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10584 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10585 LocalTemporary change.
10587 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10589 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10590 initializers optimization.
10591 (ClassOrStruct.TypeAttr): Moved from modifiers.
10592 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10593 (FieldBase.ResolveInitializer): Resolves initializer.
10594 (FieldBase.HasDefaultInitializer): New property.
10596 * cs-parser.jay: Removed message.
10598 * expression.cs (CompilerGeneratedThis): New specialization.
10600 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10602 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10604 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10606 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10608 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10609 be now EnumConstants only.
10611 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10613 * attribute.cs, driver.cs: Reset more caches.
10615 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10617 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10619 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10621 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10622 for easier reuse. Updated all overrides.
10623 (IntegralConstant): New base class for all integral constants.
10624 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10625 of the constant range, report custom error.
10626 (UIntConstant.Reduce): Fixed uint conversion.
10628 * ecore.cs, literal.cs: Reduce updates.
10630 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10634 * class.cs (Constructor.Define): Removed extra if for default ctors.
10635 A patch from Atsushi Enomoto.
10637 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10639 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10640 GetAttributableValue.
10642 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10645 * convert.cs (ImplicitConversionRequired): Error message moved to
10648 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10649 automatic implicit conversion of an output value.
10650 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10652 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10654 (TypeOf.GetAttributableValue): Add extra handling for object type.
10656 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10657 special error message.
10659 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10661 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10663 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10664 compatible with MS runtime.
10666 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10668 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10669 attribute arguments here.
10671 * class.cs (Indexer.Define): The check was moved to attribute class.
10673 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10675 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10676 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10679 2006-03-22 Raja R Harinath <rharinath@novell.com>
10681 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10682 mcs to keep code differences small.
10683 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10684 * typemanager.cs (parameter_default_value_attribute_type): New.
10685 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10688 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10690 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10692 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10694 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10696 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10699 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10701 * doc-bootstrap.cs : fix build.
10703 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10705 * expression.cs (StringConcat.Append): Issue a warning when empty string
10706 is going to append.
10708 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10710 * assign.cs (CompoundAssign.ResolveSource): Removed.
10712 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10715 * class.cs (TypeContainer.FindMethods): Removed.
10716 (TypeContainer.CheckMemberUsage): Made static.
10718 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10720 * constant.cs (CheckRange): Removed unused type argument.
10721 (CheckUnsigned): Removed unused type argument.
10723 * cs-parser.jay: Updated after MemberAccess clean up.
10724 Uses Length for empty string test.
10726 * cs-tokenizer.cs: Uses Length for empty string test.
10727 (IsCastToken): Made static.
10728 (is_hex): Made static.
10729 (real_type_suffix): Made static.
10731 * decl.cs (SetupCache): Made static.
10732 (OnGenerateDocComment): Removed unused ds argument.
10734 * delegate.cs (VerifyDelegate): Removed unused argument.
10736 * doc.cs: Uses Length for empty string test.
10738 * driver.cs: Uses Length for empty string test.
10740 * enum.cs (IsValidEnumType): Made static
10742 * expression.cs (EnumLiftUp): Removed unused argument.
10743 (ResolveMethodGroup): Ditto.
10744 (BetterConversion): Ditto.
10745 (GetVarargsTypes): Ditto.
10746 (UpdateIndices): Ditto.
10747 (ValidateInitializers): Ditto.
10748 (MemberAccess.ctor): Ditto.
10749 (GetIndexersForType): Ditto.
10751 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10753 * iterators.cs: Updated after MemberAccess clean up.
10755 * location.cs: Uses Length for empty string test.
10757 * namespace.cs: Uses Length for empty string test.
10759 * report.cs (CheckWarningCode): Made static.
10761 * statement.cs (LabeledStatement): Removed unused argument.
10763 * typemanager.cs (FilterNone): Removed.
10765 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10767 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10770 * class.cs: Updated.
10772 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10774 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10776 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10780 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10781 reporting, it's more tricky than I thought.
10783 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10787 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10789 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10790 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10791 Add more error reporting; Fixed issue with params.
10793 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10795 * cs-parser.jay: AnonymousMethod requires host container.
10797 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10799 2006-03-18 Raja R Harinath <harinath@gmail.com>
10801 * class.cs: Change 'TypeContainer ds' constructor argument to
10802 'DeclSpace parent'. Some classes were missed below due to
10803 different naming convention.
10805 * class.cs (MemberCore.Parent): Delete. This makes the
10806 ParentContainer changes below enforceable by the compiler.
10808 Treat pointers to enclosing declaration space as 'DeclSpace', not
10810 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10811 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10813 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10815 (Block.AddThisVariable): Likewise.
10816 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10817 (AbstractPropertyEventMethod.Emit): Likewise.
10818 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10819 (GetMethod.Define, SetMethod.Define): Likewise.
10820 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10821 (DelegateMethod.EmitMethod): Likewise.
10823 Fix regression test-partial-13.cs.
10824 Rationalize use of PartialContainer. Ensure that the partial
10825 class semantics can be tied to type-correctness, i.e., any
10826 violation will cause a compile error.
10827 * class.cs, const.cs: Access all fields that belong to class
10828 TypeContainer via ParentContainer. Arguments of EmitContexts and
10829 Resolve()-like functions still use 'Parent'.
10831 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10832 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10833 (PropertyMethod.CheckModifiers): Remove unused argument.
10834 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10837 2006-03-17 Raja R Harinath <harinath@gmail.com>
10839 Make semantics of PartialContainer simpler.
10840 * decl.cs (DeclSpace.IsPartial): Remove.
10841 * class.cs (TypeContainer.IsPartial): Likewise.
10842 (TypeContainer..ctor): Set PartialContainer to point to self.
10843 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10844 (TypeContainer.FindNestedType): Likewise.
10845 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10847 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10849 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10851 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10853 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10856 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10858 * class.cs (Operator.Define): An error for base conversion was not
10859 reported correctly.
10861 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10863 * iterator.cs : yield break is allowed in try statement which has
10864 catch clauses. Fixed bug #77767.
10866 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10868 A fix for #77593, #77574.
10870 * class.cs (MethodCore.CheckBase): Another if for operator.
10872 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10874 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10877 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10878 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10881 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10884 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10885 Updated after another emitcontext usage was clean up. It should help us to
10886 synchronize with gmcs easier.
10888 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10892 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10893 (Event.Define): ditto
10894 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10896 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10897 Removed redundant code and set NewSlot for Invoke method too.
10899 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10900 (Parameters.MergeGenerated): New method. Use this method when you merge
10901 compiler generated argument with user arguments.
10903 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10905 * attribute.cs (ResolveAsTypeTerminal): Removed.
10907 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10908 specialization for predefined types; 30% speed up.
10909 Finally placed obsolete check to right place.
10910 (Expression.ResolveType): Removed.
10912 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10913 Updated after ResolveType was removed.
10915 * expression.cs (Cast.ctor): Check void cast.
10916 (Binary.ResolveAsTypeTerminal): Is never type.
10917 (Conditional.ResolveAsTypeTerminal): Is never type.
10919 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10921 2006-03-01 Raja R Harinath <rharinath@novell.com>
10924 * expression.cs (ParameterReference.DoResolveBase): Change return
10926 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10930 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10933 * typemanager.cs (GetFullNameSignature): Don't nullref on
10934 protected accessors.
10936 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10938 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10939 these two separated members to simplify the code.
10940 (Attribute.Resolve): Refactored to use new fields and methods.
10941 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10942 implemented obsolete attribute checking.
10943 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10944 implemented obsolete checking again. It look line never ending quest ;-)
10945 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10947 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10949 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10951 *class.cs (Property.Define): Add RegisterProperty call.
10953 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10954 argument groups (only 2).
10956 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10957 encoding expression to arguments.
10958 (Expression.ExprClassToResolveFlags): Just turned to property.
10960 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10961 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10962 optimized as well as implemented support for zero-length attributes.
10964 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10965 Add caching of PropertyInfo's.
10967 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10969 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10970 error multiple times.
10972 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10974 New partial class implementation.
10975 A fix for #77027, #77029, #77403
10977 * attribute.cs (Attributable): Made attributes protected.
10979 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10980 the replacements of ClassPart and PartialContainer.
10981 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10982 (TypeContainer.AddInterface): Ditto.
10983 (TypeContainer.AddPartial): The main method for partial classes. It checks
10984 for errors and merges ModFlags and attributes. At the end class is added to
10985 partial_parts list.
10986 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10988 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10989 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10990 from the rest of partial classes.
10991 (TypeContainer.GetClassBases): Simplified.
10992 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10994 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10995 (TypeContainer.HasExplicitLayout): Uses Flags now.
10996 (PartialContainer): Removed.
10997 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10998 (StaticClass): Was merged with Class.
10999 (Class.GetClassBases): class and static class bases are verified here.
11000 (Class.TypeAttr): Added static attributes when class is static.
11001 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11002 (MemberBase): In some cases we need to call parent container for partial
11003 class. It should be eliminated but it's not easy now.
11005 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11007 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11008 partial classed to accumulate class comments.
11009 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11011 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11013 * driver.cs (MainDriver): Tree.GetDecl was removed.
11015 * modifiers.cs (Modifiers): Add partial modifier.
11017 * tree.cs (Tree.decl): Removed.
11018 (RootTypes): Started to use this class more often for root types
11021 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11025 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11026 external interface does not have an attribute.
11028 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11030 Another prerequisites for new partial classs implementation.
11032 * attribute.cs (Attribute.Equal): Implemented.
11033 (Attribute.Emit): Changed as attributes can be applied more than twice.
11034 (Attributes.Emit): Check for duplicate attributes here.
11036 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11037 as a parameter, clean-up.
11039 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11043 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11044 contains obsolete attribute check which can in some cases look for base
11045 type of current class which is not initialized yet.
11046 (TypeContainer.BaseType): Replacement of ptype.
11048 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11050 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11052 First of prerequisites for new partial classs implemention.
11054 * attribute.cs (Attributable): Extended by ResolveContext;
11055 Attributes finally have correct context for resolving in all cases.
11056 (AttachTo): Attribute owner is assigned here.
11058 * codegen.cs (IResolveContext): Introduce new interface to hold
11059 all information needed in resolving phase.
11060 (EmitContext): Implements IResolveContext; more clean-up needed here.
11062 * decl.cs (MemberCore): Implemented IResolveContext.
11064 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11065 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11066 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11067 Refactored to use new IResolveContext instead of EmitContext; cleanup
11069 2006-02-06 Miguel de Icaza <miguel@novell.com>
11071 * codegen.cs (EmitScopeInitFromBlock): check here the
11072 capture_context, there is no need to make two calls to the
11075 * anonymous.cs: Add some debugging messages that might help me
11076 track other instances of this problem in the future (the
11077 regression of test 467).
11079 * cs-parser.jay: track the variable block, as we need to initalize
11080 any captured variables declared in this block for the "catch"
11081 portion of the "Try" statement.
11083 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11084 scope initialization for captured variables.
11086 Also, move the emit for the variables after the block location has
11089 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11091 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11093 2006-02-02 Miguel de Icaza <miguel@novell.com>
11095 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11096 commit yesterday, the initialization for the roots is necessary.
11097 What is not necessary is the scope activation.
11099 2006-02-02 Raja R Harinath <rharinath@novell.com>
11101 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11102 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11104 (Argument.Resolve): Remove CS0206 checks.
11106 2006-02-01 Miguel de Icaza <miguel@novell.com>
11108 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11109 scopes for all the roots, the scopes will now be emitted when the
11110 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11112 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11113 code. This reduces a lot of existing cruft.
11115 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11116 that the ScopeInfo is generated as we enter the scope, not at the
11117 time of use, which is what we used to do before.
11119 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11120 every time a Block is about to be emitted if we have a
11123 2006-02-01 Raja R Harinath <rharinath@novell.com>
11125 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11127 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11129 * typemanager.cs (cons_param_array_attribute): Make private.
11130 (Reset): Set it to null.
11131 (InitCoreHelpers): Don't initialize it.
11132 (ConsParamArrayAttribute): New. Initialize it as needed.
11133 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11135 2006-01-31 Miguel de Icaza <miguel@novell.com>
11137 * expression.cs: There might be errors reported during the
11138 selection of applicable methods. If there are errors, do not
11139 continue execution as it will lead the compiler to crash.
11141 2006-01-30 Miguel de Icaza <miguel@novell.com>
11143 * expression.cs: Member access is not allowed on anonymous
11144 methods. Fixes #77402.
11146 2006-01-30 Raja R Harinath <rharinath@novell.com>
11149 * cs-parser.jay (VariableDeclaration): Don't set
11150 current_array_type to null.
11151 (field_declaration, event_declaration, declaration_statement):
11152 Set it to null here.
11154 2006-01-28 Raja R Harinath <harinath@gmail.com>
11156 * typemanager.cs (GenericParameterPosition): New.
11159 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11161 * doc.cs : To process "include" elements, first we should create
11162 another list than XmlNodeList, because it could result in node
11163 removal, which could result in that the XmlNodeList gives up
11164 yielding next node.
11166 (Also made code identical to gmcs again.)
11168 2006-01-25 Miguel de Icaza <miguel@novell.com>
11170 * ecore.cs: Introduce an error report that we were not catching
11171 before, if not silent, we must report the error. Gonzalo ran into
11174 2006-01-23 Miguel de Icaza <miguel@novell.com>
11176 A fix for bug: #76957
11178 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11179 ComputeMethodHost before creating the method, this is a new
11182 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11183 that this method references (RegisterScope). The actual scope
11184 where the method is hosted is computed with the ComputeMethodHost
11185 before we create the method.
11187 Moved the Deepest routine here.
11189 (AnonymousContainer.ComputeMethodHost): New routine used to
11190 compute the proper ScopeInfo that will host the anonymous method.
11192 (ScopeInfo): Deal with multiple roots. The problem was that we
11193 did not have a unique root where all ScopeInfos could be hanged
11194 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11197 Remove AdjustMethodScope which is now computed at the end. Remove
11198 LinkScope which did a partial link, instead link all ScopeInfos
11199 before code generation from the new "LinkScopes" routine.
11201 Simplify all the Add* routines as they no longer need to maintain
11202 the tree, they just need to record that they are using variables
11205 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11206 routines to produce the forest of ScopeInfo trees.
11208 * class.cs (TypeContainer.AppendMethod): This is just like
11209 AddMethod, but ensures that an interface implementation method
11210 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11211 methods, but at the end.
11213 We use this functionality to ensure that the generated MoveNext
11214 method in the iterator class is resolved/emitted before the
11215 enumerator methods created.
11217 This is required because the MoveNext method computes the right
11218 ScopeInfo for the method. And the other methods will eventually
11219 need to resolve and fetch information computed from the anonymous
11222 2006-01-21 Raja R Harinath <harinath@gmail.com>
11223 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11225 Fix rest of #76995.
11226 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11227 the 'aliases' hash.
11228 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11229 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11231 2006-01-18 Raja R Harinath <rharinath@novell.com>
11233 Fix #76656, cs0231-2.cs.
11234 * cs-parser.jay (formal_parameter_list): Make error case catch
11236 (parenthesized_expression_0): Add CS1026 check.
11237 (invocation_expression): Remove unused { $$ = lexer.Location }.
11239 2006-01-17 Raja R Harinath <rharinath@novell.com>
11242 * cs-parser.jay (statement_expression): Don't list out the
11243 individual statement-expressions. Convert syntax error into
11246 2006-01-16 Raja R Harinath <rharinath@novell.com>
11249 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11250 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11251 CheckIntermediateModification.
11252 (FieldExpr.DoResolve): Add new two-argument version that
11253 allows us to resolve the InstanceExpression as an lvalue.
11254 The one-argument variant is now just a wrapper.
11255 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11256 Resolve the lhs as an lvalue if the it has a value type.
11257 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11258 from Assign.DoResolve.
11259 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11260 resolved as an lvalue.
11261 (PropertyExpr.DoResolve): Update.
11262 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11263 has a value type. Move CS1612 check here from
11264 CheckIntermediateModification.
11265 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11266 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11267 'right_side' of a ResolveLValue on an 'out' argument.
11268 (EmptyExpression.LValueMemberAccess): New. Used as the
11269 'right_side' of a propagated ResolveLValue on a value type.
11270 (LocalVariableReference.DoResolveBase): Recognize
11271 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11273 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11274 EmptyExpression.Null.
11276 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11278 * typemanager.cs : added IsGenericParameter(). In mcs it always
11280 * doc.cs : for generic parameters, use GenericParameterPosition,
11283 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11285 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11287 2006-01-12 Miguel de Icaza <miguel@novell.com>
11289 This fixes the problem where we used ldfld instead of ldflda to
11290 load the "THIS" pointer on captured parameters, when THIS is a
11291 value type. See bug #77205.
11293 * iterators.cs (CapturedThisReference.Emit): Pass false to
11294 EmitThis (we do not need the address).
11296 * codegen.cs (EmitThis): it needs to know whether we need the
11297 address of `this' or not. This is used by value types.
11299 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11300 every other call passes false.
11302 2006-01-12 Raja R Harinath <rharinath@novell.com>
11305 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11307 * expression.cs (Invocation.OverloadResolve): Update.
11308 (Invocation.DoResolve): Avoid double resolution of invocation.
11310 2006-01-11 Raja R Harinath <rharinath@novell.com>
11313 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11314 unary negation of floating point types as 0-expr; negation cannot
11315 overflow in floating point types.
11318 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11319 on operands of 'void' type.
11322 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11323 and ExclusiveOr for boolean constants too.
11325 2006-01-09 Raja R Harinath <rharinath@novell.com>
11328 * expression.cs (Invocation.OverloadResolve): Replace reflected
11329 override methods with their base virtual methods, rather than
11330 skipping over them.
11331 * typemanager.cs (TypeManager.GetOverride): New.
11333 2006-01-05 Jb Evain <jbevain@gmail.com>
11335 * class.cs (Property.Define, Indexer.Define): do not tag the
11336 properties as SpecialName | RTSpecialName.
11338 2006-01-04 Miguel de Icaza <miguel@novell.com>
11340 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11341 doing a low-level comparission of parameter types. It was lacking
11342 a check for __argslist.
11344 2005-12-30 Miguel de Icaza <miguel@novell.com>
11346 * expression.cs (ParameterReference.DoResolveBase): Allow
11347 reference parameters if they are local to this block.
11349 This allows the ref and out parameters of a delegate to be used in
11350 an anonymous method, for example:
11352 delegate void set (out int x);
11354 set s = delegate (out int x){
11358 This is used by functionality introduced late in the C# language.
11360 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11361 method that take ref and out parameters.
11363 Fixes #77119 which was a late change in the spec.
11365 2005-12-23 Miguel de Icaza <miguel@novell.com>
11367 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11368 parent if its the same scope. Fixes #77060.
11370 2005-12-21 Miguel de Icaza <miguel@novell.com>
11372 * driver.cs: Report the case of no source files and no -out:
11375 2005-12-20 Raja R Harinath <rharinath@novell.com>
11378 * expression.cs (ComposedCast.GetSignatureForError): Define.
11380 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11384 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11385 ListDictionary, to contain the ExternAliasEntry entries (in
11386 addition to the NamespaceEntry.aliases hashtable). This field is
11387 shared between the original entry and its doppelganger (bodyless
11389 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11390 extern_aliases field.
11391 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11392 lookup in extern_aliases.
11394 2005-12-16 Raja R Harinath <rharinath@novell.com>
11397 * class.cs (TypeContainer.Mark_HasEquals): New.
11398 (TypeContainer.Mark_HasGetHashCode): New.
11399 (ClassPart): Override them.
11400 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11403 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11404 'parent' argument to the base constructor.
11406 Remove all mention of TypeContainer from decl.cs.
11407 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11408 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11409 (DeclSpace.DeclSpace): Likewise.
11410 (DeclSpace.DefineMembers): Remove unused argument.
11411 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11412 debugging check -- we don't care if the debug code throws an
11413 InvalidCastException instead of an InternalErrorException.
11414 * class.cs (TypeContainer.DefineMembers): Update to changes.
11415 (TypeContainer.DoDefineMembers): Likewise.
11416 (TypeContainer.GetMethods): Likewise.
11417 (PropertyMember.Define): Likewise.
11418 (MemberBase.Parent): New property that forwards to
11419 MemberCore.Parent, but ensures that we get a TypeContainer.
11420 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11421 (RootContext.PopulateTypes): Likewise. Remove special case code
11422 for !RootContext.StdLib: DefineMembers is idempotent.
11424 2005-12-14 Miguel de Icaza <miguel@novell.com>
11426 * convert.cs (ExplicitConversionCore): Check the return value from
11427 ExplicitConversionCore which can return null on failure. Fixes #76914
11429 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11431 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11433 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11435 * doc.cs : The search for referenced namespace was insufficient to
11436 get global one as it used to do. Fixed bug #76965.
11438 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11440 * doc.cs : check name in cref in the last phase that whether it is
11443 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11445 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11448 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11450 * doc.cs : so it turned out that we cannot skip override check for
11451 interface members. Fixed bug #76954.
11453 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11455 * cs-tokenizer.cs : fixed bug #75984:
11456 - #warning and #error should not be handled when the source line
11458 - #line is not checked strictly when the source line is disabled.
11459 - #define and #undef is on the other hand checked strictly at any
11462 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11464 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11467 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11469 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11471 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11472 event initializers.
11473 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11474 (FieldBase.Initializer): Initializer is now optional.
11475 (EventField.Define): Only event field can have initializer.
11477 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11479 * const.cs (Const): Reuse initializer.
11481 * cs-parser.jay: Updated after FieldBase changes.
11482 Added current_array_type to simplify array initializers.
11484 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11486 * expression.cs, iterators.cs: Updated.
11488 * namespace.cs (NamespaceEntry): Made UsingFound private.
11490 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11492 * parameterCollection.cs: Obsolete, removed.
11493 * parser.cs: Obsolete, removed.
11495 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11498 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11500 * enum.cs (Enum.Define): Set obsolete context here.
11502 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11505 - FindDocumentedMember() now expects 1) paramList as null
11506 when "we don't have to check the number of parameters" and
11507 2) Type.EmptyTypes when "there is no arguments".
11508 - Introduced FoundMember struct to hold the exact type which was
11509 used to find the documented member (the above change broke
11510 test-xml-044; it might be better just to use DeclaringType than
11511 what MS does, like this change does, but it depends on usage.)
11513 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11515 * doc.cs : documented member might be from DeclaringType for nested
11516 types. Fixed bug #76782.
11518 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11520 * anonymous.cs: Have the param code handle leaving copies on the
11521 stack etc. Allows anonymous params to take part in the assignment
11522 code (++, +=, etc). Fixes bug #76550
11524 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11525 it down to the anon code.
11527 * iterators.cs: Use dummy var here
11529 * codegen.cs: Handle new vars
11531 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11534 * class.cs (MethodData.Define): Set proper Obsolete context.
11536 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11538 (FieldExpr.DoResolve): Ditto.
11540 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11543 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11544 parent is not obsolete.
11546 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11548 * doc.cs : (FindDocumentedMember) find parameterless members first
11549 and get CS0419 in the early stage. Fixed first case of bug #76727.
11551 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11554 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11555 no error was reported.
11557 *expression.cs (Binary.DoResolve): left can be null.
11559 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11562 * class.cs (MethodData.Emit): Parameters should be labeled first.
11564 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11567 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11569 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11571 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11573 * class.cs (MethodCore): Parameter clean up.
11574 (IMethodData): Added ParameterInfo.
11575 (MethodData): Parameter clean up.
11576 (Indexer.Define): Parameter clean up.
11588 * typemanager.cs: Parameter clean up.
11590 * delegate.cs (Define): Get rid of duplicated code.
11592 * expression.cs (ParameterReference): Removed useless parameters
11594 (Invocation): Ditto.
11596 * parameter.cs (ParamsParameter): New class, params specialization.
11597 (ArglistParameter): Attemp to separate arglist.
11598 (Parameter): Refactored to be reusable and faster.
11599 (Parameter.Modifier): Made understandable.
11600 (Parameters): Changed to be used as a class for `this' assembly
11601 parameters. Refactored to use new specialized classes.
11603 * support.cs (ParameterData): Added Types property.
11604 (InternalParameters): Deleted.
11606 2005-08-20 Martin Baulig <martin@ximian.com>
11608 Merging this patch from GMCS to fix #75867.
11610 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11611 scope if we don't already have it.
11613 2005-11-17 Martin Baulig <martin@ximian.com>
11616 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11617 inherit the scope from our parent. Fixes #76653.
11619 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11621 * doc.cs : the previous patch does not actually fix the bug.
11622 PropertyInfo override check is now implemented and really fixed it.
11623 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11625 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11627 * doc.cs : apply "override filter" also to properties.
11630 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11632 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11633 no need to check overrides. For classes, omit those results from
11634 interfaces since they must exist in the class. Fixed bug #76726.
11636 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11638 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11639 with different parameters. Fixed the second problem in #76685.
11641 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11643 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11644 get expected 'protected' access in CheckValidFamilyAccess()).
11647 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11649 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11650 Fixed bug #76705. CS1569 was incorrectly commented out.
11652 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11654 * doc.cs : use Invocation.IsOverride() to do real override check.
11655 * expression.cs : made Invocation.IsOverride() internal.
11657 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11659 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11660 TypeBuilder.FindMembers() and filter overriden base members out.
11663 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11665 * doc.cs : ref/out parameters are represented as '@' (instead of
11666 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11668 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11670 * doc.cs : when there was no '.' in cref to methods in doc comment,
11671 then parameters were missing in the output. Fixed bug #76691.
11673 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11675 * driver.cs : don't output docs when there is an error.
11678 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11681 Now it should detect indexers. Fixed primary concern in bug #76685.
11682 Fixed CS0419 message to not show the identical member signature in
11685 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11687 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11688 instead of Type.FindMembers() since it does not handle events.
11691 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11693 * codegen.cs: Fixed typo (speficied -> specified).
11695 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11698 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11700 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11702 * attribute.cs: Changed error message.
11704 * cs-tokenizer.cs: One more check.
11706 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11708 * statement.cs (Block.Resolve): Ignore empty statement.
11710 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11712 * report.cs: Made error/warning methods more strict to avoid
11715 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11716 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11717 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11718 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11720 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11722 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11723 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11725 * class.cs (TypeContainer.IsComImport): New property.
11726 (Constructor.Define): Create proper ctor for ComImport types.
11728 * expression.cs (New.CheckComImport): Fixed.
11730 2005-11-07 Miguel de Icaza <miguel@novell.com>
11732 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11733 that a parameter has been captured does not mean that we do not
11734 have to do the rest of the processing. This fixes the second part
11735 of #76592. If there was another anonymous method capturing
11736 values in the past, the Scope would never be set for the second
11737 method that captured the same parameter.
11739 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11740 properly manipulate the stack. Second part of fix for #76592.
11742 * expression.cs (New): Add support for invoking "new" on
11743 interfaces that have been flagged with the ComImport attribute and
11744 the CoClass. Fixes #76637
11746 * statement.cs (Try.DoEmit): When a variable is captured, do not
11747 try to emit the vi.LocalBuilder variable as it has been captured.
11748 Create a temporary variable and store the results on the
11749 FieldBuilder. Fixes #76642
11751 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11753 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11755 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11757 * expression.cs (Binary.DoResolve): Added && optimalization.
11759 * typemanager.cs (AddUserType): Removed useless argument.
11761 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11763 * statement.cs (Block.variables): Uses ListDictionary.
11765 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11768 * class.cs (PartialContainer.EmitType): Customized to emit
11769 security attributes.
11770 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11771 for partial classes.
11773 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11776 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11777 access has to be fixed.
11779 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11781 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11784 * ecore.cs (NullCast.Reduce): Implemented.
11786 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11789 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11791 (Foreach.Resolve): Catch null properly.
11793 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11795 * cs-tokenizer.cs: Warning text fix.
11797 * driver.cs: AllWarningNumbers exposed on public interface.
11799 * report.cs (): Reviewed warning numbers.
11800 (IsValidWarning): Use binary search.
11802 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11804 * driver.cs: Implemeted resource visibility.
11805 (Resources): New class for code sharing between /res: and
11808 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11811 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11814 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11817 * ecore.cs (NullCast): Child is contant only.
11819 * literal.cs (NullLiteral.Reduce): null can be converted to any
11822 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11824 * driver.cs: Use Encoding.Default as default code page instead
11827 2005-10-27 Raja R Harinath <rharinath@novell.com>
11830 * expression.cs (Invocation.Error_InvalidArguments): Handle
11831 __arglist parameters.
11832 (Invocation.VerifyArgumentsCompat): Likewise.
11833 * support.cs (ReflectionParameters.GetSignatureForError): Print
11834 __arglist parameters.
11835 (InternalParamters.GetSignatureForError): Likewise.
11836 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11838 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11840 * attribute.cs (GetPropertyValue): Made public.
11842 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11844 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11846 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11849 * driver.cs: Reflect method name change.
11851 * statement.cs (Try.Resolve): Warn when try has both general
11852 exception handlers.
11854 * typemanager.cs: runtime_compatibility_attr_type new predefined
11857 2005-10-26 Raja R Harinath <harinath@gmail.com>
11860 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11861 treat it as an empty parameter list.
11863 2005-10-26 Raja R Harinath <rharinath@novell.com>
11866 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11867 ResolveAsTypeStep silent.
11868 * statement.cs (Block.AddConstant): Mark block as used.
11869 (Block.ResolveMeta): Avoid piling on error messages
11870 if a constant initializer resolution fails.
11872 2005-10-25 Raja R Harinath <rharinath@novell.com>
11874 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11876 (NamespaceEntry.VerifyAllUsing): New.
11877 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11878 behaviour. Delegates actual resolution of alias to ...
11879 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11880 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11882 * driver.cs (Driver.MainDriver): Update.
11884 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11885 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11887 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11889 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11890 RootNamespace.DefineNamespacesForAll.
11892 2005-10-24 Raja R Harinath <harinath@gmail.com>
11894 * typemanager.cs (assemblies, external_aliases, modules)
11895 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11896 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11897 overhead. Move resposibility ...
11898 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11899 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11901 2005-10-23 Raja R Harinath <harinath@gmail.com>
11903 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11904 cached_namespaces. Improve usage.
11905 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11906 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11907 Move from GlobalRootNamespace and simplify.
11908 (RootNamespace.Global): Make instance variable.
11909 (RootNamespace.RootNamespace): Add "alias name" parameter.
11910 (GlobalRootNamespace): Simplify drastically.
11911 (Namespace.Lookup): Don't use GetNamespace.
11912 * typemanager.cs (GetRootNamespace): Rename from
11913 ComputeNamespaceForAlias.
11914 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11916 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11918 * anonymous.cs (AnonymousContainer): Don't crash when container
11921 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11923 * expression.cs (Binary.DoResolve): Warn when comparing same
11926 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11929 * expression.cs (Binary.DoResolve): It looks like there are no
11930 convetsion rules in enum context.
11932 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11934 Add support for extern alias qualifiers.
11935 * typemanager.cs: Move some LookupTypeReflection code
11936 to namespace.cs, to have cleaner code. Added some methods
11937 to help us keep track of the extern aliased references.
11938 * driver.cs: Add suport for extern alias assemblies on command
11939 line and check for their warnings/errors. Also keep track of the
11940 extern aliased assemblies.
11941 * namespace.cs: Move the global functionality of Namespace
11942 to GlobalRootNamespace/RootNamespace. Now the global namespace
11943 is GlobalRootNamespace.Globa. Also the code moved from
11944 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11945 Finally added LocalAliasEntry (AliasEntry before) and
11946 ExternAliasEntry, to handle alias statements.
11947 * cs-parser.jay: Add support in the grammar for extern alias
11949 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11950 Update callings to Namespace (now in GlobalRootNamespace).
11952 2005-10-18 Raja R Harinath <rharinath@novell.com>
11955 * class.cs (TypeContainer.DefineType): Move updating of
11956 topological sort earlier in the code.
11957 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11959 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11962 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11964 * constant.cs (Constant.TryReduce): Moved from Cast class.
11965 (Reduce): Made little bit more OO and fixed missing conversions.
11967 * ecore.cs (Reduce): Implemented.
11968 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11970 * literal.cs (Reduce): Implemented.
11972 * class.cs: Reverted Miguel's wrong commit.
11974 2005-10-14 Miguel de Icaza <miguel@novell.com>
11976 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11978 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11980 * cs-parser.jay, expression.cs : CS0214 was missing error location
11981 for constants. Fixed bug #76404.
11983 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11986 * convert.cs (ExplicitConversionCore): Fixed object->enum
11989 2005-10-10 Raja R Harinath <rharinath@novell.com>
11991 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11992 InstanceExpression.
11993 (PropertyExpr.EmitCall): Likewise.
11994 * expression.cs (Invocation.EmitArguments): Handle case where
11996 (Invocation.EmitCall): Avoid allocating temporary variable if
11997 there are no arguments.
11999 2005-10-07 Raja R Harinath <rharinath@novell.com>
12002 * convert.cs (ImplicitConversionStandard): Move conversion of
12003 void* to arbitrary pointer types ...
12004 (ExplicitConversionStandard): .. here.
12005 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12006 error to always print typenames.
12008 2005-10-07 Raja R Harinath <rharinath@novell.com>
12010 * convert.cs (GetConversionOperator): Rename from
12011 GetConversionOperators. Move operator selection code from ...
12012 (UserDefinedConversion): ... here.
12014 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12016 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12019 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12021 * assign.cs (Assign.DoResolve): Error method changed.
12023 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12025 * const.cs (ResolveValue): Reset in_transit immediately.
12027 * constant.cs: Error method changed.
12029 * convert.cs: Removed useless location parameter.
12030 (ExplicitNumericConversion): Don't do double enum check.
12031 (ExplicitConversionCore): Renamed from ExplicitConversion.
12032 (ExplicitUnsafe): Extracted from ExplicitConversion.
12033 (ExplicitConversion): Uses for error reporting.
12035 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12037 (ResolveBoolean): Uses common error method.
12038 (CastToDecimal): Get rid of ec.
12039 (CastFromDecimal): Optimized.
12040 (ConvCast): Get rid of ec.
12042 * enum.cs (ResolveValue): Reset in_transit immediately.
12043 (Emit): Return after first error.
12045 * expression.cs: Convert changes.
12047 * literal.cs: Error method changed.
12049 * statement.cs: Error method changed.
12051 2005-10-03 Raja R Harinath <rharinath@novell.com>
12053 * support.cs (SeekableStreamReader.Position): Don't error out when
12054 the requested position is just beyond the end of the current
12057 2005-09-28 Raja R Harinath <rharinath@novell.com>
12059 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12060 try to keep in sync with the byte count of the underlying Stream.
12061 However, this limits us to a window size of 2048 characters: i.e.,
12062 the maximum lookahead of our lexer/parser can be 2048 characters.
12064 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12067 * driver.cs: Fix compilation files with full root path.
12069 2005-09-25 Miguel de Icaza <miguel@novell.com>
12071 * report.cs (SymbolRelatedToPreviousError): Format the output so
12072 it does not use an open parenthesis that is never closed.
12074 * driver.cs: Follow coding guidelines
12076 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12079 * const.cs (Const.ResolveValue): Check for assigning non-null
12080 value to reference type.
12082 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12084 * anonymous.cs: Implemented ExprClassName.
12086 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12089 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12092 * class.cs (StaticClass.DefineContainerMembers): Report protected
12095 * codegen.cs: if(ed) PRODUCTION.
12097 * convert.cs (Error_CannotImplicitConversion): Better error
12100 * cs-parser.jay: More error checks.
12102 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12104 * driver.cs (CSCParseOption): Enabled wrong option check.
12106 * ecore.cs (Expression.ExprClassName): Turned to property.
12107 (MemberExpr.CheckIntermediateModification): For checking boxed
12108 value types modification.
12110 * statement.cs (Fixed.Resolve): Expression type must be
12111 convertible to fixed type.
12112 (CollectionForeach.GetEnumeratorFilter,TryType):
12113 Small refactoring for easier error checking.
12115 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12117 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12120 * class.cs (GeneratedBaseInitializer): New class for customization
12121 compiler generated initializers.
12122 (MemberBase.DoDefine): Check Obsolete attribute here.
12123 (FieldMember.DoDefine): Ditto.
12125 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12128 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12129 (MemberCore.GetObsoleteAttribute): Removed argument.
12130 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12131 (MemberCore.CheckObsoleteType): New helper.
12135 * statement.cs: Updates after MemberCore changes.
12137 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12138 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12140 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12141 obsolete attribute for compiler construct.
12142 (As.DoResolve): Cache result.
12144 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12146 2005-09-26 Raja R Harinath <rharinath@novell.com>
12149 * expression.cs (This.VerifyFixed): In a value type T, the type of
12150 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12151 value type R, 'this' is treated as a value parameter.
12153 2005-09-22 Miguel de Icaza <miguel@novell.com>
12155 * statement.cs (Lock): Use the TemporaryVariable class instead of
12156 manually using local variables as those do not work when variables
12159 * ecore.cs: Moved the TemporaryVariable class from being a nested
12160 class inside Foreach to be a public class that can be employed in
12163 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12165 * cs-parser.jay: interface_accessors replaced by
12166 accessor_declarations.
12168 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12171 * statement.cs (GotoCase.Resolve): Convert null constant to
12173 (SwitchLabel.ResolveAndReduce): Ditto.
12174 (SwitchLabel.NullStringCase): Custom null stamp.
12175 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12177 typemanager.cs (CSharpSignature): Don't skip first argument
12180 2005-09-18 Miguel de Icaza <miguel@novell.com>
12182 * driver.cs: Set InEmacs based on the environment variable EMACS.
12184 * location.cs (InEmacs): in this mode, do not report column
12185 location as it confuses Emacs.
12187 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12189 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12190 expression.cs, iterators.cs, literal.cs: Store constants and
12193 * class.cs (MemberBase.ShortName): Pass location.
12195 * cs-parser.jay: Some location fixes.
12197 * ecore.cs (Expression.Location): Made virtual.
12199 2005-09-05 Miguel de Icaza <miguel@novell.com>
12201 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12202 if the underlying types are the same, otherwise we need to produce
12203 code that will do the proper cast.
12205 This was exposed by Marek's constant rewrite which produced
12206 invalid code for the call site:
12208 enum X : long { a }
12209 void Method (X v) {}
12213 This fixes test-49.cs
12215 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12217 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12218 Type/Object should be allowed as well. Fixed bug #75968.
12220 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12222 * expression.cs : (Binary.DoResolve): when one is enum constant and
12223 another is constant 0, then return enum one *as enum type*.
12226 2005-09-02 Raja R Harinath <rharinath@novell.com>
12228 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12232 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12233 flow-branching for LocalVariableReferences in case we were invoked
12234 from a MemberAccess.
12235 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12237 (LocalVariableReference.DoResolveBase): ... this.
12238 (MemberAccess.Resolve): Do the check that was disabled during
12241 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12244 (PartialContainer.Create): check abstract/sealed/static strictly
12245 but abstract/sealed can exist only at one side. Fixed bug #75883.
12247 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12250 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12251 specified, don't default to UnmanagedType.I4.
12253 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12255 * expression.cs : conditional operator should check possibly
12256 incorrect assign expression. Fixed bug #75946.
12258 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12260 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12261 Reverting the change. gmcs is much complex than mcs on this matter.
12263 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12265 * cs-tokenizer.cs : To read another token ahead of the actual
12266 consumption, use new SavedToken and cache token instead of moving
12267 back the stream with SeekableStreamReader (it seemed problematic).
12269 driver.cs : Thus use StreamReader directly.
12270 * support.cs : Thus removed SeekableStreamReader.
12272 2005-08-30 Raja R Harinath <rharinath@novell.com>
12275 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12276 (ScopeInfo.EmitScopeType): Use it to construct field names from
12277 names of captured locals.
12280 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12281 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12282 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12283 (ExplicitConversion): Remove enum cases already handled by
12284 implicit conversion. Move implicit conversion check to the beginning.
12285 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12286 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12287 Don't treat System.Enum as a struct.
12289 2005-08-30 Jb Evain <jbevain@gmail.com>
12291 * attribute.cs: handles as expression in parameters.
12293 2005-08-30 Raja R Harinath <rharinath@novell.com>
12296 * class.cs (TypeContainer.VerifyClsName): Don't use a
12297 PartialContainer when verifying CLS compliance.
12298 (AbstractPropertyEventMethod): Set Parent here, ...
12299 (PropertyMethod): ... not here.
12301 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12303 * attribute.cs : escaped attribute name should not be allowed to be
12304 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12306 2005-08-29 Raja R Harinath <rharinath@novell.com>
12309 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12310 when converting a long constant to unsigned long.
12311 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12312 detect where IsApplicable and VerifyArgumentsCompat disagree.
12314 2005-08-29 Raja R Harinath <rharinath@novell.com>
12315 and Carlos Alberto Cortez <carlos@unixmexico.org>
12318 * class.cs (TypeContainer.CanElideInitializer): New helper.
12319 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12320 can safely emitting the initializer of a field.
12322 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12324 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12325 allowed inside a switch (without loop). Fixed bug #75433.
12327 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12329 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12330 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12332 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12334 * driver.cs : kinda reverting the default encoding changes (not exact
12335 revert since I noticed that "codepage:reset" might not work fine).
12337 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12339 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12340 Location. Now getter and setter store location correctly.
12341 (errors/cs0111-12.cs now reports the expected location.)
12343 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12345 * driver.cs : Use default encoding on the environment.
12346 Removed (now that) extra parameter for SeekableStreamReader.
12347 * support.cs : (SeekableStreamReader) third .ctor() argument for
12348 StreamReader is not required (always true). preamble size could
12349 be acquired in simpler and safe way.
12351 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12353 * cs-parser.jay: report CS0642 at warning level 3
12354 and report CS0642 for an if else statement also
12355 fixes bug #74745. Patch by John Luke (and a bit
12357 Removed extra CS0642 warning check for "while",
12359 * statement.cs: In Block.Resolve(), CS0642 check
12360 is reimplemented to check a sequence of an empty
12361 statement and a block.
12363 Both fix bug #66777.
12365 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12367 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12368 detection until I fix it.
12370 * cs-tokenizer.cs: Changed error message.
12372 * cs-parser.jay: Fixed 2 error locations.
12374 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12375 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12378 * enum.cs (GetSignatureForError): Fixed.
12380 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12384 * typemanager.cs (RegisterProperty): Removed.
12386 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12388 2005-08-24 Raja R Harinath <rharinath@novell.com>
12391 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12392 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12394 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12396 * expression.cs : tiny fix is required for not warning positive ulong.
12399 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12401 * expression.cs : add CS0652 check for constant and integral
12402 expression. Fixed bug #53974.
12404 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12406 * expression.cs : in DoNumericPromotions(), check if there is implicit
12407 conversion overload for string (to check CS0034). Fixed bug #52492.
12409 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12411 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12413 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12415 * ecore.cs : report location when it is *not* Null.
12417 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12423 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12424 correctly. Fixed bug #75721.
12426 2005-08-23 Raja R Harinath <rharinath@novell.com>
12428 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12429 loop that performs 'min (pos, char_count)'.
12432 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12433 converted value in Operator.OnesComplement.
12435 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12437 * anonymous.cs: If the anon method is pulled into a helper class,
12438 it needs to be `internal' not `private'. Fixes runtime behavior on
12441 2005-08-20 Martin Baulig <martin@ximian.com>
12443 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12444 scope if we don't already have it.
12446 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12447 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12450 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12453 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12454 is a partial class.
12456 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12458 The big constants rewrite
12459 Fix #75746, #75685 and more
12460 As a side effect saved 1MB for MWF ;-)
12462 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12463 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12464 enum based for corlib compilation.
12466 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12469 * class.cs (FixedField.Define): Use ResolveAsConstant.
12471 * const.cs (IConstant): Interface constants and enums.
12472 (Const.ResolveValue): New method for constant resolvning.
12473 (ExternalConstant): Constants from imported assemblies.
12475 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12476 conversion; like enums.
12477 (Constant.ToType): Converts this constant to different type.
12478 (Constant.Increment): Adds 1.
12480 * convert.cs (ImplicitConversionRequired): Simplified.
12482 * cs-parser.jay: Create EnumMember directly.
12484 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12486 * doc.cs (GenerateEnumDocComment): Removed.
12488 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12489 (ConvertIntLiteral): Removed.
12490 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12492 * enum.cs (EnumMember): Implement IConstant.
12493 (Enum.IsValidEnumConstant): Removed.
12494 (Enum.GetNextDefaultValue): Removed.
12495 (Enum.FindMembers): Updated.
12496 (Enum.GenerateDocComment): Iterate enum members.
12498 * expression.cs (Cast.TryReduce): Handle enums correctly.
12499 (New.Constantify): Made public.
12500 (MemberAccess.DoResolve): Removed contant specific if(s).
12502 * literal.cs (NullLiteral): Implement new abstract methods.
12504 * statement.cs (GotoCase.Resolve): Use new constant methods.
12505 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12507 * typemanager.cs (LookupEnum): Removed.
12508 (IsEnumType): Fixed to work with corlib.
12509 (RegisterConstant): Removed.
12510 (LookupConstant): Removed.
12511 (GetConstant): Changed to work with IConstant.
12513 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12515 * location.cs : Fixed overflown (>255) column number.
12517 2005-08-03 Raja R Harinath <rharinath@novell.com>
12519 First cut of the qualified-alias-member feature.
12520 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12522 * cs-parser.jay (DOUBLE_COLON): New token.
12523 (namespace_or_type_name): Add rule for recognizing
12524 qualified-alias-members.
12525 (primary_expression): Likewise.
12526 (element_access): Allow QualifiedAliasMember as a possible
12527 type-bearing expression.
12528 (local_variable_type, local_variable_pointer_type): Likewise.
12529 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12530 aliases in the current and enclosing namespace declarations.
12531 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12532 * decl.cs (MemberName.is_double_colon): New.
12533 (MemberName.MemberName): Add new constructor for alias-member.
12534 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12535 * expression.cs (QualifiedAliasMember): New expression type.
12537 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12539 * location.cs : it borked when no argument was specified.
12541 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12543 * location.cs : tiny ToString() format fix.
12545 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12547 * statement.cs : oops, it was missing.
12549 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12551 A set of fixes for precise line/column location.
12554 "token" field now holds a file/line "delta", a line number offset
12555 from the segment, and a column number. See also:
12556 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12557 December/009508.html
12558 Removed static IsNull. Use instance IsNull property instead.
12559 * cs-tokenizer.cs :
12560 For some tokens it stores Location. For Identifier it stores
12561 LocatedToken which is a pair of string name and location.
12562 Column numbers are adjusted only at getChar().
12564 Use Location.ToString() for reporting (it now contains column).
12566 Largely modified to use LocatedToken instead of
12567 string (IDENTIFIER), and to acquire Location from some tokens.
12568 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12569 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12571 Now MemberName holds Location. DeclSpace.ctor() receives Location
12572 as a parameter. Removed extra parameters to all derived classes.
12573 Replaced Location.IsNull() with instance property.
12574 * assign.cs, expression.cs :
12575 Added .ctor() overload that omits Location.
12577 Added "nameEscaped" flag that indicates the identifier was escaped
12578 in the source file. This fixes bug #57047.
12580 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12582 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12583 New method, looking for lo-case imported cls type.
12585 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12588 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12590 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12592 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12593 all_imported_types.
12594 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12596 Optimized to save 3.5 MB for SWF compilation.
12598 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12600 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12601 (PartialContainer.Create): Moved logic AddToContainer.
12602 (PartialContainer.MarkForDuplicationCheck): Shares name.
12604 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12607 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12609 (Namespace.GetSignatureForError): New method.
12611 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12612 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12614 2005-08-01 Raja R Harinath <rharinath@novell.com>
12617 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12618 member lookup rather than qualifier_type, since qualifier_type can
12621 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12623 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12626 2005-07-31 Miguel de Icaza <miguel@novell.com>
12628 * statement.cs: Copy the local exception into the exception
12629 captured local. Fixes 75674
12631 2005-07-31 Raja R Harinath <harinath@gmail.com>
12634 * expression.cs (Invocation.OverloadResolve): Don't report error
12635 CS1501 if error CS1502 has been reported.
12636 (New.DoResolve): Delegate CS1501 reporting to
12637 Invocation.OverloadResolve.
12640 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12641 invariant-meaning-in-block property in an enclosing block if
12644 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12646 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12647 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12648 (Switch.CheckSwitch): Just save 50kb for SWF.
12650 2005-07-27 Martin Baulig <martin@ximian.com>
12652 * anonymous.cs (CaptureContext.AddField): Added
12653 `AnonymousContainer am' argument; compute its toplevel scope if
12654 it's not already computed. Fixes #75649.
12656 2005-07-26 Raja R Harinath <rharinath@novell.com>
12659 * class.cs (Constructor.Emit): Reset block to null if the block
12662 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12664 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12666 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12668 * class.cs (MethodData.Define): Check whether accessor implementing
12669 interface is public.
12671 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12673 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12676 * namespace.cs (LookupType): Moved same type check to...
12678 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12679 with the same name.
12681 2005-07-21 Raja R Harinath <rharinath@novell.com>
12683 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12684 already found a typebuilder.
12685 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12686 MemberNames, not strings.
12688 * const.cs (Error_ExpressionMustBeConst):
12689 Rename from Error_EpressionMustBeConst.
12690 * const.cs, class.cs, statement.cd: Update.
12692 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12696 * const.cs (Const.LookupConstantValue): Report missing contant expression
12698 (Error_EpressionMustBeConstant): Only one error method.
12700 * class.cs, statement.c: Updated.
12702 2005-07-20 Raja R Harinath <rharinath@novell.com>
12704 * statement.cs (Block.Flags): Add back HasVarargs.
12705 (Block.flags): Make protected.
12706 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12708 * typemanager.cs (types, typecontainers, user_types): Remove.
12709 (UserTypes, TypeContainers): Likewise.
12710 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12711 (CleanUp, Reset): Update.
12712 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12713 (GetNestedType): Use Type.GetNestedType.
12714 (CoreLookupType): Take two arguments, the namespace and the
12715 basename of the type. Update to use the Namespace.Lookup
12717 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12718 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12719 string concatenation and substring matches.
12720 * class.cs, enum.cs, delegate.cs: Update to changes.
12722 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12724 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12725 Expression and made virtual.
12727 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12728 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12730 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12732 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12735 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12738 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12741 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12742 AssemblyCultureAttribute is not used on executable.
12745 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12747 2005-07-16 Raja R Harinath <rharinath@novell.com>
12750 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12751 New. Reports CS0252/CS0253.
12752 Mostly taken from preliminary patch by Duncak Mak.
12753 (Binary.DoResolveOperator): Store results of operator lookup.
12754 Use them to detect if we need to warn about unintended reference
12757 2005-07-15 Raja R Harinath <rharinath@novell.com>
12760 * namespace.cs (Namespace.Lookup): Add back location parameter.
12761 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12762 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12764 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12765 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12766 (Namespace.LookupType): ... this.
12767 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12769 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12770 purported to handle pointers.
12771 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12774 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12776 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12779 2005-07-15 Raja R Harinath <rharinath@novell.com>
12781 * namespace.cs (Namespace.Lookup): Drop location parameter.
12782 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12783 (NamespaceEntry.Lookup): ... this.
12784 (NamespaceEntry.Error_AmbiguousTypeReference):
12785 Move here from DeclSpace.
12786 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12788 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12789 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12790 Move to NamespaceEntry.
12791 * delegate.cs, expression.cs: Update to changes.
12793 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12795 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12796 CheckAttributeType and refactored.
12797 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12798 ResolveAsTypeTerminal error handling.
12799 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12801 (GetSignatureForError): Print errors in same way.
12804 * codegen.cs: Reflect attribute GetSignatureForError change.
12807 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12809 * namespace.cs (UsingEntry): Refactored to make fields private.
12812 statement.cs: Error_UnexpectedKind has extra parameter.
12814 2005-07-14 Raja R Harinath <rharinath@novell.com>
12816 * ecore.cs (IAlias): Remove.
12817 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12818 that implement the interface.
12819 * namespace.cs (Namespace): Likewise.
12820 (Namespace.declspaces): Renamed from 'defined_names'.
12821 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12822 DeclSpace instead of an IAlias.
12823 * tree.cs (Tree.AddDecl): Update.
12825 2005-07-12 Raja R Harinath <rharinath@novell.com>
12827 * statement.cs (Block.Flags); Remove HasVarargs.
12828 (Block.HasVarargs): Move to ToplevelBlock.
12829 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12830 (Block.Variables): Make protected. Initialize variable hashtable
12832 (Block.AddVariable): Update.
12833 (Block.Resolve): Update to changes.
12834 (ToplevelBlock.HasVarargs): New boolean.
12835 (ToplevelBlock.ThisVariable): Move here from Block.
12836 (ToplevelBlock.AddThisVariable): Likewise.
12837 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12838 * expression.cs (This.ResolveBase): Update to changes.
12839 (ArglistAccess.DoResolve): Likewise.
12841 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12844 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12846 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12847 not used and not used & assigned.
12848 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12850 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12853 * expression.cs (Is.DoResolve): null is never provided type.
12855 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12858 * cs-parser.jay: Less strict event error rule to catch more errors.
12860 2005-07-08 Martin Baulig <martin@ximian.com>
12862 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12863 gettter (allowed) or setter (not allowed).
12865 * class.cs (Accessor): Implement IIteratorContainer.
12866 (Accessor.Yields): New public field.
12867 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12868 per-accessor basis.
12871 (get_accessor_declaration, set_accessor_declaration): Set the
12872 `yields' flag on the accessor, not the property.
12873 (property_declaration): Do the iterators check on a per-accessor
12874 basis and not for the whole property.
12876 2005-07-08 Martin Baulig <martin@ximian.com>
12878 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12879 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12881 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12884 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12885 (ExtractSecurityPermissionSet): Cope with self referencing security
12886 attributes properly.
12888 * driver.cs (SetOutputFile): Made public property OutputFile.
12890 2005-07-07 Raja R Harinath <rharinath@novell.com>
12893 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12894 has_nonstatic_fields. Make into a FieldBase pointer.
12895 (TypeContainer.AddField): Add CS0282 check.
12896 (TypeContainer.EmitType): Update.
12898 2005-07-06 Miguel de Icaza <miguel@novell.com>
12900 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12901 compare if they start with __.
12903 2005-07-06 Raja R Harinath <rharinath@novell.com>
12905 * statement.cs (Switch.SwitchGoverningType): Only look at
12906 UserCasts that don't need implicit standard conversions to one of
12907 the allowed switch types (Fixes test-322.cs).
12908 (LocalInfo.Resolve): Re-enable sanity-test.
12910 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12912 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12914 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12916 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12918 2005-07-06 Raja R Harinath <rharinath@novell.com>
12921 * ecore.cs (SimpleName.GetSignatureForError): Add.
12922 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12923 (MemberAccess.GetSignatureForError): Add.
12925 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12927 The big error and warning messages review.
12957 * typemanager.cs: Updated.
12959 * class.cs: (MethodCore.SetYields): Moved here to share.
12960 (PropertyMethod.Define): Moved iterator setup here.
12962 * iterators.cs: Add orig_method to have full access to parent
12965 2005-07-05 Raja R Harinath <rharinath@novell.com>
12967 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12968 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12969 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12970 variable of struct type.
12971 * expression.cs (Unary.ResolveOperator): Update to change.
12972 (Indirection.VerifyFixed): Likewise.
12973 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12974 (ParameterReference.VerifyFixed): Value parameters are fixed.
12975 (This.VerifyFixed): Treat 'this' as a value parameter.
12976 * statement.cs (LocalInfo.IsFixed): Remove.
12978 2005-07-01 Martin Baulig <martin@ximian.com>
12980 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12981 `ec.EmitThis ()' to get the correct scope.
12983 2005-07-01 Martin Baulig <martin@ximian.com>
12985 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12986 instance is a ParameterReference; fixes #75299.
12988 2005-07-01 Martin Baulig <martin@ximian.com>
12990 Reverted Marek's latest patch (r46725):
12991 - it contains structural changes which are neither mentioned in
12992 the ChangeLog nor explained anywhere; for example the additional
12993 argument of EmitContext's and Iterator's .ctor's and the
12994 TypeContainer.DefineMembers() change.
12995 - structural changes like this should go in in seperate patches
12996 and not be hidden in a huge patch which just seems to affect
12997 warnings and errors.
12998 a big and hard to understand patch.
12999 - it breaks iterators and causes regressions, for instance in
13002 2005-06-30 Raja R Harinath <rharinath@novell.com>
13005 * expression.cs (Indexers.map): Remove.
13006 (Indexers.Append): Filter out inaccessible setters and getters.
13007 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13010 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13011 Refactored from ...
13012 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13013 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13014 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13015 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13017 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13020 * class.cs (FieldBase.GetInitializerExpression): One more field
13023 2005-06-28 Miguel de Icaza <miguel@novell.com>
13025 * pending.cs: Do not define a proxy if the base method is virtual,
13026 it will be picked up by the runtime (bug 75270).
13028 2005-06-08 Martin Baulig <martin@ximian.com>
13030 The big Iterators rewrite :-)
13032 * iterators.cs: Rewrite this to use the anonymous methods framework.
13034 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13035 before the TypeContainers; see 2test-21.cs.
13038 (TypeContainer.DefineType): Don't create a new EmitContext if we
13039 already have one (this only happens if we're an Iterator).
13040 (TypeContainer.Define): Also call Define() on all our iterators.
13041 (Method.CreateEmitContext): Added support for iterators.
13044 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13045 (AnonymousContainer.CreateMethodHost): Moved here from
13046 AnonymousMethod and made abstract.
13047 (AnonymousContainer.CreateScopeType): New abstract method.
13048 (AnonymousContainer.IsIterator): New public property.
13049 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13050 get the ScopeTypeBuilder rather than manually defining it here.
13051 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13054 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13055 before RootContext.DefineTypes().
13057 * codegen.cs (EmitContext.RemapToProxy): Removed.
13058 (EmitContext.CurrentAnonymousMethod): Changed type from
13059 AnonymousMethod -> AnonymousContainer.
13060 (EmitContext.ResolveTopBlock): Protect from being called twice.
13061 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13062 (EmitContext.EmitThis): Removed the iterators hacks; use the
13063 anonymous methods framework for that.
13066 (ToplevelBlock.Container): Make this a property, not a field.
13067 (ToplevelBlock.ReParent): New public method; move the
13068 ToplevelBlock into a new container.
13069 (Foreach.TemporaryVariable): Simplify.
13071 2005-06-05 Martin Baulig <martin@ximian.com>
13073 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13074 (Block.AddTemporaryVariable): New public method; creates a new
13075 `LocalInfo' for a temporary variable.
13076 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13078 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13079 non-iterator variables.
13081 2005-06-05 Martin Baulig <martin@ximian.com>
13083 * statement.cs (Foreach.TemporaryVariable): Create the
13084 LocalBuilder in the Emit phase and not in Resolve since in some
13085 situations, we don't have an ILGenerator during Resolve; see
13086 2test-19.cs for an example.
13088 2005-06-04 Martin Baulig <martin@ximian.com>
13090 **** Merged r45395 from GCS ****
13092 The big Foreach rewrite - Part II.
13094 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13095 with `PropertyInfo ienumerator_getcurrent'.
13097 * codegen.cs (VariableStorage): Removed.
13100 (Foreach): Derive from Statement, not ExceptionStatement.
13101 (Foreach.CollectionForeach): New nested class. Moved all the code
13102 dealing with collection foreach here.
13103 (Foreach.ForeachHelperMethods): Removed.
13104 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13106 2005-05-23 Martin Baulig <martin@ximian.com>
13108 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13109 don't need to. Fix #75014.
13111 2005-05-20 Martin Baulig <martin@ximian.com>
13113 Merged r44808 from GMCS.
13115 * class.cs (TypeContainer.CircularDepException): Removed.
13116 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13117 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13118 (CS0146) and interface (CS0529) dependencies here.
13120 2005-06-21 Raja R Harinath <rharinath@novell.com>
13122 * expression.cs (Invocation.EmitCall): Fix initialization
13123 'this_call' to reflect current behaviour. Fix indentation.
13125 * convert.cs (FindMostEncompassedType): Add two trivial special
13126 cases (number_of_types == 0 || number_of_types == 1).
13127 (FindMostEncompasingType): Likewise.
13129 2005-06-17 Raja R Harinath <rharinath@novell.com>
13131 Some cleanups preparing for the fix of #75283.
13132 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13134 (EventExpr.InstanceResolve): Likewise.
13135 (EventExpr.DoResolve): Remove redundant checks.
13137 2005-06-10 Duncan Mak <duncan@novell.com>
13139 * cs-tokenizer.cs (process_directives): New flag for controlling
13140 the processing of preprocessor directives.
13141 (x_token): After seeing a '#', return Token.NONE instead of going
13142 to handle_preprocessing_directive() when not processing
13143 directives. This avoids unnecessary processing during the token peek in
13148 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13149 the existing error reporting methods instead of Report.Error.
13151 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13152 after Raja's rewrite.
13154 2005-06-08 Miguel de Icaza <miguel@novell.com>
13156 * class.cs: Small fix.
13158 2005-06-08 Raja R Harinath <rharinath@novell.com>
13161 * class.cs (GetPartialBases): Fix return value check of
13162 part.GetClassBases.
13164 2005-06-07 Raja R Harinath <rharinath@novell.com>
13166 Ensure that partial classes are registered in their enclosing
13167 namespace. Initial part of fix of #75160.
13168 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13169 Register declspace with namespace here, not in
13170 DeclSpace.RecordDecl.
13171 * cs-parser.jay: Pass namespace to RecordDecl.
13172 * class.cs (PartialContainer.Create): Likewise.
13173 (ClassPart.DefineType): New sanity-check. Throws an exception if
13175 * decl.cs (Declspace.RecordDecl): Remove.
13176 * namespace.cs (NamespaceEntry.DefineName): Remove.
13178 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13180 * rootcontext.cs: Reset TargetExt as well.
13182 2005-06-03 Raja R Harinath <rharinath@novell.com>
13184 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13185 -langversion:ISO-1.
13187 2005-06-02 Raja R Harinath <rharinath@novell.com>
13189 Fix #75080, cs0119.cs.
13190 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13192 (Expression.Resolve): ... this. Use it. Remove bogus code
13193 allowing ExprClass.Type and ExprClass.Namespace for
13194 ResolveFlags.VariableOrValue.
13195 (Expression.Resolve) [1-argument variant]: Change default resolve
13196 flags based on language version.
13197 (Expression.Error_UnexpectedKind): Use a simple string array
13198 rather than an ArrayList.
13199 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13200 not ExprClass.Type.
13201 (TypeOfVoid.DoResolve): Likewise.
13202 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13203 flags argument -- it always has the same value.
13205 2005-05-31 Raja R Harinath <rharinath@novell.com>
13208 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13209 Use it in the error message.
13210 * assign.cs, expression.cs, statement.cs: Update.
13212 2005-05-30 Raja R Harinath <rharinath@novell.com>
13215 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13216 the "almostMatchedMember" case too.
13217 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13218 that failed the accessibility checks to 'almost_match'.
13220 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13222 * attribute.cs: Use internal MethodBuilder methods to set
13223 ExactSpelling and SetLastError on PInvoke methods, instead
13224 of passing them via charset. Fixes #75060.
13226 2005-05-27 Raja R Harinath <rharinath@novell.com>
13228 * parameter.cs (Parameter): Remove TODO comment.
13229 (Parameter.DefineParameter): Remove Location parameter.
13230 (Parameters.LabelParameters): Likewise.
13231 * class.cs (Constructor.Emit): Update to change.
13232 (MethodData.Emit): Likewise.
13233 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13234 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13236 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13239 Removed Parameters.Location and added Parameter.Location instead.
13240 Removed Location parameter from Emit() and GetSignature().
13247 Modified all related calls.
13249 2005-05-26 Raja R Harinath <rharinath@novell.com>
13251 Improve user-defined conversion handling.
13252 * convert.cs (GetConversionOperators): Rewrite. Return only the
13253 applicable operators.
13254 (AddConversionOperators): New. Helper for GetConversionOperators.
13255 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13256 there is only one most encompassed/encompassing type.
13257 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13258 "applicable operator" handling.
13259 (UserConversion): Move cache here from GetConversionOperators.
13260 Directly cache the chosen operator, rather than the whole
13262 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13263 case. Allow conversion of decimal to sbyte and byte too.
13264 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13265 New static methods. Used to avoid allocating EmptyExpressions in
13268 2005-05-24 Duncan Mak <duncan@novell.com>
13270 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13271 another class, used in Convert.ExplicitNumericConversion.
13272 (CastToDecimal): New class, similar to above, but casts to
13273 System.Decimal, used in Convert.ImplicitNumericConversion and also
13274 in explicit convesion from double/float to decimal.
13276 * convert.cs (ImplicitNumericConversion): Handle implicit
13277 conversions to System.Decimal.
13278 (ExplicitNumericConversion): handle explicit conversions to
13283 2005-05-20 Miguel de Icaza <miguel@novell.com>
13285 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13286 know the type at this stage, just break through. Fixes #75008
13288 2005-05-19 Martin Baulig <martin@ximian.com>
13291 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13292 to disable error reporting.
13294 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13295 here since we don't want to report an error; see the new test-336.cs.
13297 2005-05-19 Raja R Harinath <rharinath@novell.com>
13299 * statement.cs (ToplevelBlock.GetParameterReference)
13300 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13301 Move here from class Block.
13302 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13303 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13305 2005-05-18 Martin Baulig <martin@ximian.com>
13310 (FlowBranching.Reachability): Add non-static public And() and Or()
13312 (FlowBranchingSwitch): New class; do the `break_origins' thing
13313 like in FlowBranchingLoop.
13314 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13315 reachability, not just locals and parameters.
13316 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13317 switch; MergeBreakOrigins() now takes care of that.
13319 2005-05-18 Martin Baulig <martin@ximian.com>
13321 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13322 a loop and may leave it, reset the barrier; fixes #74974.
13324 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13326 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13329 * cs-parser.jay: Catch more lexical errors.
13331 * report.cs: Add one more Error method.
13334 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13336 2005-05-17 Martin Baulig <martin@ximian.com>
13338 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13341 2005-05-16 Raja R Harinath <rharinath@novell.com>
13343 Fix test-382.cs. Emit values of decimal constants.
13344 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13346 (TypeContainer.AddField): ... this.
13347 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13348 with initializers to include 'Const's.
13349 (ClassPart.RegisterFieldForInitialization): Forward to
13351 * const.cs (Const.Const): Pass initializer to base class.
13352 (Const.Define): In case of decimal constants, register them for
13353 initialization in a static constructor.
13355 2005-05-14 Martin Baulig <martin@ximian.com>
13357 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13358 do not call ResolveUnreachable() on unreachable statements in
13359 here, see the comment in the source code.
13361 2005-05-13 Raja R Harinath <rharinath@novell.com>
13364 * expression.cs (BinaryResolveOperator): If one of the operands of
13365 an equality comparison is 'null' and the other is a pointer type,
13366 convert the null to a NullPointer.
13367 * convert.cs (ImplicitReferenceConversion): If the expression is a
13368 NullLiteral and the target type is a pointer type, return a
13369 NullPointer instead.
13370 (ImplicitConversionStandard): Likewise.
13372 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13374 * cs-parser.jay: Set readonly context based on special constructs.
13376 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13377 readonly variable error handling.
13379 * rootcontext.cs (EmitCode): Don't verify members when error
13382 * statement.cs (LocalInfo): Add reaodnly context information.
13383 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13385 2005-05-13 Raja R Harinath <rharinath@novell.com>
13387 * statement.cs (Block.Resolve): Revert change below. Modify fix
13388 for #74041 to initialize 'resolved' to false only for explicit
13389 blocks. Fixes #74873.
13391 2005-05-12 Raja R Harinath <harinath@gmail.com>
13394 * typemanager.cs (unmanaged_enclosing_types): New.
13395 (IsUnmanagedType): Avoid infloops by using
13396 'unmanaged_enclosing_types' to talk with recursive invocations.
13398 2005-05-13 Martin Baulig <martin@ximian.com>
13400 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13401 instance variable, not a local. Fix #74873.
13402 (Block.ResolveUnreachable): Set it to true here.
13404 2005-05-11 Duncan Mak <duncan@novell.com>
13406 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13407 continuing to process for 'arg'.
13408 (handle_preprocessing_directive): Check the argument of the #endif
13409 directive and report error CS1025 if there are any trailing
13412 According to the C# spec, having even whitespace after the #endif
13413 directive is illegal; however, because we call arg.TrimEnd ()
13414 beforehand, we have the same behavior as csc, allowing whitespace
13415 after the directive.
13419 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13423 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13424 (Constructor.GetObsoleteAttribute): Implemented correctly.
13426 2005-05-10 Martin Baulig <martin@ximian.com>
13428 * support.cs (ReflectionParameters.ParameterModifier): Use
13429 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13430 and `ParameterAttributes.In'. Fixes #74884.
13432 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13434 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13436 * expression.cs (Argument.GetParameterModifier): Turned to property.
13437 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13439 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13442 2005-05-09 Raja R Harinath <rharinath@novell.com>
13445 * decl.cs (MemberCache.AddMethods): Register override methods,
13446 rather than non-override methods.
13447 * typemanager.cs (RegisterOverride): New.
13448 (IsOverride): Update.
13450 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13454 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13455 recursive declaration.
13457 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13459 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13461 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13463 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13465 2005-05-05 Raja R Harinath <rharinath@novell.com>
13468 * decl.cs (DeclSpace.FamilyAccessible):
13469 Use TypeManager.IsNestedFamilyAccessible.
13471 Fix reopened #64812.
13472 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13475 2005-05-04 Raja R Harinath <rharinath@novell.com>
13476 Abin Thomas <projectmonokochi@rediffmail.com>
13477 Anoob V E <projectmonokochi@rediffmail.com>
13478 Harilal P R <projectmonokochi@rediffmail.com>
13481 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13482 allow access to all static members.
13484 2005-05-04 Martin Baulig <martin@ximian.com>
13486 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13488 2005-05-04 Martin Baulig <martin@ximian.com>
13492 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13493 section at the end; make things work if `default' is not the last
13496 2005-05-04 Martin Baulig <martin@ximian.com>
13500 * statement.cs (Switch): Replaced the `got_default' field with a
13501 `default_section' one.
13502 (Switch.CheckSwitch): Set `default_section' here.
13503 (Switch.Resolve): If we're a constant switch and the constant is
13504 not found, use the default section.
13506 2005-05-03 Martin Baulig <martin@ximian.com>
13508 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13510 * statement.cs (Foreach.ArrayForeach): New nested class.
13511 (Foreach.TemporaryVariable): New nested class.
13512 (Foreach.EmitArrayForeach): Removed; this is now in the new
13513 ArrayForeach class.
13515 2005-05-03 Raja R Harinath <rharinath@novell.com>
13517 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13519 (VerifyPendingMethods): Revert change below.
13521 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13522 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13523 that used to trigger warning -28. Remove warning -28.
13524 * expression.cs (Invocation.OverloadResolve): Use
13525 TypeManager.IsOverride to distinguish override methods.
13528 * pending.cs (VerifyPendingMethods): If a base type implements the
13529 requested interface, don't bother checking individual methods of
13530 the base type. As a side-effect, this prevents the creation of
13531 unnecessary proxies.
13533 2005-05-02 Martin Baulig <martin@ximian.com>
13537 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13538 Also `And' the locals if the old vector is null.
13539 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13540 null; in this case we basically reset all the variables.
13542 2005-05-02 Martin Baulig <martin@ximian.com>
13546 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13547 Added `FlowBranching branching' argument; always `and' the
13548 variables instead of `or'ing them unless we're an infinite loop.
13550 * statement.cs (While.Resolve): Create a new sibling unless we're
13553 2005-05-02 Martin Baulig <martin@ximian.com>
13557 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13558 arguments; use it instead of creating a new TopLevelBlock.
13559 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13560 our ConstructorInitializer.
13563 (TopLevelBlock.TopLevelBranching): New public property.
13564 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13565 and create our `TopLevelBranching'.
13567 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13568 anonymous method host, use `block.TopLevelBranching' rather than
13569 creating a new branching.
13571 2005-04-20 Miguel de Icaza <miguel@novell.com>
13573 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13574 a ScopeInfo, if any of the current children is a child of the new
13575 entry, move those children there.
13577 2005-04-30 Martin Baulig <martin@ximian.com>
13579 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13580 at the beginning of a SwitchSection. Fix #73335.
13582 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13585 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13587 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13588 (FieldExpr.DoResolve): Obsolete members are ignored for field
13591 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13593 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13594 of arrays detection.
13596 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13598 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13600 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13603 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13605 * cs-parser.jay: Use the prefered version of -unsafe in error
13608 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13610 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13613 2005-04-20 John Luke <john.luke@gmail.com>
13615 * driver.cs: fix typo in error message, --outout to --output
13617 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13619 * codegen.cs (InRefOutArgumentResolving): New field.
13621 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13622 fields outside contructor.
13624 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13626 2005-04-19 Miguel de Icaza <miguel@novell.com>
13628 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13629 parameter code was not completed ever, so it was not as up-to-date
13630 as local variables. Must finish it.
13632 The bug fix was to compare the Toplevel of the block, not the
13633 current block. Thanks for Ben for pointing this out.
13635 2005-04-19 Raja R Harinath <rharinath@novell.com>
13637 * decl.cs (AddMethods): Use the declaring type of the problem
13638 method to determine if we want to squash a warning.
13640 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13642 * attribute.cs: Removed debug output.
13644 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13646 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13649 2005-04-18 Raja R Harinath <rharinath@novell.com>
13652 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13653 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13654 all null comparisons against reference types.
13656 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13659 * class.cs (TypeContainer.CircularDepException) New nested
13661 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13662 (TypeContainer.DefineType): Removed error, reset InTransit before
13664 (Class.DefineType): Throw exception when is in Transit.
13665 Catch exception and report error.
13666 (Struct.DefineType): Throw exception when is in Transit.
13667 Catch exception and report error.
13668 (Interface.DefineType): Throw exception when is in Transit.
13669 Catch exception and report error.
13671 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13672 handle nested exception handlers.
13674 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13677 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13678 InFinally and InCatch storage.
13680 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13681 (Catch.Resolve): Set and Restore ec.InCatch.
13682 (Try.Resolve): Set and Restore ec.InFinally.
13683 (Try.HasCatch): True when try has catch.
13685 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13687 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13688 for the same event member, so exclude such cases from warning 419.
13691 2005-04-16 Miguel de Icaza <miguel@novell.com>
13693 * expression.cs (Binary.ResolveOperator): Apply patch from John
13694 Luke to fix bug 59864: operators &, | and ^ on enumerations
13695 require that the same enum type on both sides.
13697 * driver.cs: Add warnings to old flag usage, this is to assist
13698 people who produce Makefiles and hope that the Makefiles will be
13701 * class.cs (TypeContainer.EmitType): Moved the definition of the
13702 special $PRIVATE$ field from the resolve phase to the Emit phase.
13703 During resolve we do not know if we are a struct with
13704 HasExplicitLayout, we know this only after the attributes for the
13707 Set the FieldOffset to zero on the dummy field that we create for
13708 the class. Fixes 74590.
13710 2005-04-16 Raja R Harinath <rharinath@novell.com>
13713 * ecore.cs (PropertyExpr.resolved): New.
13714 (DoResolve): Use it to handle a case of double resolution here.
13715 Handle a case of identical-name-and-type-name.
13716 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13717 resolution by storing the results of expression resolution back
13718 into the "probes" array.
13720 2005-04-15 Raja R Harinath <rharinath@novell.com>
13722 Fix cs0208-7.cs and cs0208-8.cs.
13723 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13724 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13725 error reporting to point out the reason a struct is not unmanaged.
13727 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13729 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13730 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13732 2005-04-13 Raja R Harinath <rharinath@novell.com>
13735 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13736 IdenticalNameAndTypeName here.
13737 (EventExpr.InstanceResolve): Likewise.
13739 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13741 C# 2.0 DefaultCharSetAttribute implementation
13743 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13744 which allows us to set GlobalNamespace for every resolve.
13745 (Attribute.ResolveArguments): Cut from Resolve.
13746 (Attribute.GetCharSetValue): Returns CharSet named argument.
13747 (Attribute.DefinePInvokeMethod): Gets default charset from
13749 (GlobalAttribute.ResolveAsTypeStep): Override.
13750 (GlobalAttribute.ResolveArguments): Override.
13752 * class.cs (TypeAttr): Is protected.
13754 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13755 (ModuleClass.DefaultCharSetType): New memeber.
13756 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13758 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13759 charset from module.
13761 * delegate.cs (TypeAttr): Override.
13762 (Delegate.DefineType): Use this TypeAttr.
13764 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13765 at very early stage (before types are defined) to resolve model
13766 module attributes. It will probably not work with corlib but it
13769 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13770 charset from module.
13772 * typemanager.cs (default_charset_type): New type.
13774 2005-04-13 Raja R Harinath <rharinath@novell.com>
13776 * decl.cs (MemberCache.AddMethods): Don't warn if
13777 System.Object.Finalize has buggy MethodAttributes.
13779 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13782 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13784 * doc.cs : detect ambiguous reference to overloaded members.
13785 Fixed bug #71603. MS 1.1 csc does not detect it.
13787 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13789 * doc.cs : delegates must not be referenced with parameters.
13792 2005-04-12 Miguel de Icaza <miguel@novell.com>
13794 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13796 2005-04-10 Miguel de Icaza <miguel@novell.com>
13798 * driver.cs (MainDriver): Stop processing if the CLS stage found
13801 (CompilerCallableEntryPoint.InvokeCompiler): Always
13802 reset after execution; Take a TextWriter argument for the
13805 * report.cs: Use the error stream instead of hardcoding stderr.
13807 2005-04-09 Miguel de Icaza <miguel@novell.com>
13809 * class.cs: Reduce code paths to test, too small of an
13810 optimization to make it worth the extra testing. Always perform
13813 2005-04-08 Raja R Harinath <rharinath@novell.com>
13816 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13817 operators that had errors reported on them.
13819 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13821 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13823 (Attribute.Resolve): Add named argument type checking.
13825 * class.cs (FixedField.Define): Use IsPrimitiveType
13827 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13829 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13830 unsafe parameter types.
13832 * statement.cs (Using.ResolveExpression): Add better error description.
13834 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13836 2005-04-08 Raja R Harinath <rharinath@novell.com>
13839 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13840 AttributeUsageAttribute in the emitcontext of the attribute class,
13841 not in the emitcontext of the attributable entity it was attached to.
13842 * cs-parser.jay: Use 'current_class', not 'current_container',
13843 when creating a GlobalAttribute.
13845 2005-04-08 Alp Toker <alp@atoker.com>
13847 * pending.cs: The fix to #58413 failed to compile methods implementing
13848 interfaces with/without params modifiers and vice versa, even though
13849 params modifiers aren't part of the signature. Make the modifier check
13850 less strict as in csc.
13852 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13853 Anoob V E <projectmonokochi@rediffmail.com>
13854 Harilal P R <projectmonokochi@rediffmail.com>
13857 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13858 modifiers of pending methods.
13859 (PendingImplementation.PendingImplementation): Initialize it.
13860 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13861 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13862 with ParameterData. Add check for modifiers.
13863 * class.cs (MethodData.Define): Update to changes.
13865 2005-04-07 Raja R Harinath <rharinath@novell.com>
13867 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13869 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13871 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13874 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13877 * typemanager.cs: Registered RequiredAttributeAttribute.
13879 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13881 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13882 Warning CS0169 is back at level 3.
13883 (IMethodData.SetMemberIsUsed): New method.
13885 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13886 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13888 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13890 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13892 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13895 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13898 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13899 to avoid the problems with nested types.
13901 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13902 Anoob V.E <projectmonokochi@rediffmail.com>
13903 Harilal P.R <projectmonokochi@rediffmail.com>
13904 Raja R Harinath <rharinath@novell.com>
13907 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13909 * typemanager (GetConstructor): Make public.
13911 2005-04-05 John Luke <john.luke@gmail.com>
13912 Raja R Harinath <rharinath@novell.com>
13915 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13916 struct too. Return false quicker in a few cases.
13917 (VerifyUnManaged): Use it.
13919 2005-04-05 Raja R Harinath <rharinath@novell.com>
13922 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13923 not 'unreachable_seen'.
13925 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13927 * attribute.cs (Attribute.GetValue): Removed unused.
13929 * codegen.cs (CodeGen.TrimExt): Removed unused.
13931 * cs-parser.jay (output): Removed unused.
13933 * cs-tokenizer.cs (hex_digits): Removed unused.
13935 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13937 * expression.cs (Indirection.LoadExprValue): Removed unused.
13938 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13940 * iterators.cs (Iterator.param_types): Removed unused.
13942 * statement.cs (Goto.block): Removed unused.
13943 (ToplevelBlock.did): Removed unused.
13944 (Switch.ResolveConstantSwitch): Removed unused.
13946 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13948 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13951 2005-04-01 Raja R Harinath <rharinath@novell.com>
13953 Fix #74232 and cs0208-3.cs.
13954 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13955 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13956 unmanaged type. Don't use FieldBuilders when 't' is a
13957 TypeBuilder. Use ModFlags and MemberType fields.
13958 * class.cs (MemberBase.member_type): Rename from MemberType.
13959 (MemberBase.MemberType): New property. Determines member_type on
13961 (MemberBase.DoDefine): Don't initialize MemberType here.
13962 (FieldMember.Define): Likewise.
13964 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13967 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13968 Attributes are emitted there.
13970 2005-04-01 Raja R Harinath <rharinath@novell.com>
13972 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13973 keyword in 'partial enum' too.
13974 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13976 Report from Kamil Skalski <nazgul@omega.pl>.
13979 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13980 have partial containers too.
13982 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13983 in block' checks to Block.CheckInvariantMeaningInBlock.
13984 * statement.cs (Block.GetKnownVariableInfo): Make private.
13985 (Block.IsVariableUsedInChildBlock): Remove.
13986 (Block.IsVariableUsedInBlock): Likewise.
13987 (Block.CheckInvariantMeaningInBlock): New. Show location of
13988 conflicting declaration.
13989 (Block.AddVariable): Make error messages less long-winded and more
13990 specific. Show location of conflicting declaration.
13991 * parameter.cs (Parameters.Location): New readonly property.
13993 2005-03-31 Raja R Harinath <rharinath@novell.com>
13995 Clean up semantics of invoking ResolveMemberAccess.
13996 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13997 can have an instance, ensure that we pass in a non-TypeExpression
13998 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13999 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14000 argument. Update to changes and simplify.
14001 (FieldExpr.Emitinstance): Remove CS0120 check.
14002 (PropertyExpr.EmitInstance): Likewise.
14003 * expression.cs (Argument.Resolve): Likewise.
14004 (Invocation.DoResolve): Update to changes in semantics of
14005 InstanceExpression.
14007 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14010 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14013 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14015 2005-03-31 Raja R Harinath <rharinath@novell.com>
14017 Fix difference in behaviour with commandline invocation.
14018 * driver.cs (Driver.Reset): New.
14019 (CompilerCallableEntryPoint): Call it.
14021 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14022 variable" warnings if the boolean expression failed to resolve.
14024 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14026 * attribute.cs: Fix the union of several permissions when some of them
14027 are unrestricted (so the result isn't an unrestricted permission set).
14030 2005-03-30 Raja R Harinath <rharinath@novell.com>
14032 * ecore.cs (MemberExpr): New class. Convert from interface
14034 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14035 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14037 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14038 (MethodGroupExpr.IsExplicitImpl): Remove.
14039 (Expression.GetFieldFromEvent): Remove.
14040 (SimpleName.MemberStaticCheck): Remove.
14041 (SimpleName.DoSimpleNameResolve): Update to changes.
14042 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14043 (MemberAccess.IdenticalNameAndTypeName): Remove.
14044 (MemberAccess.error176): Move to MemberExpr.
14045 (MemberAccess.DoResolve): Update to changes.
14046 (BaseAccess.DoResolve): Likewise.
14048 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14050 C# 2.0 Conditional attribute class implementation
14052 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14053 Analyzes class whether it has attribute which has ConditionalAttribute
14054 and its condition is not defined.
14056 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14057 (Class.IsExcluded): New method. Search for at least one defined
14058 condition in ConditionalAttribute of attribute class.
14060 2005-03-30 Raja R Harinath <rharinath@novell.com>
14062 * ecore.cs (PropertyExpr): Derive from Expression, not
14063 ExpressionStatement.
14064 (PropertyExpr.EmitStatement): Remove.
14066 2005-03-29 Raja R Harinath <rharinath@novell.com>
14069 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14070 internal field "value__" of an enum be private. The examples for
14071 "value__" that I found on MSDN all used FieldAttributes.Private.
14073 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14074 Don't mention IL method attribute names.
14076 Fix #47991. Remove a TODO.
14077 * statement.cs (Block.Toplevel): Make into a field.
14078 (Block.Parameters): Move into ToplevelBlock.
14079 (Block.known_variables): Rename from child_variable_names.
14080 (Block.Block): Remove variants that take Parameters. Initialize
14081 'Toplevel' with the immediately surrounding toplevel block.
14082 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14083 LocalInfo parameter.
14084 (Block.GetKnownVariableInfo): New.
14085 (Block.IsVariableNameUsedInChildBlock): Update.
14086 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14087 the block, even though it may not be in scope.
14088 (Block.AddVariable): Remove Parameters parameter. Use
14089 Toplevel.Parameters instead.
14090 (Block.AddConstant): Remove Parameters parameter.
14091 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14092 (Block.IsParamaterReference): Likewise.
14093 (Block.IsLocalParameter): Likewise. Simplify a lot.
14094 (ToplevelBlock.Parameters): New. Moved from Block.
14095 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14096 initialize Parameters to a non-null value.
14097 * cs-parser.jay: Update to changes.
14098 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14099 simple names that mean different things in the same block. Use
14100 Block.IsVariableNameUsedInBlock.
14102 2005-03-28 Raja R Harinath <rharinath@novell.com>
14104 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14105 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14106 GetTypeHandle. It is possible for a reflected type to derive from
14107 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14108 System.Array during mscorlib compilation).
14109 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14110 contain a method_hash, don't create one either. Don't create a
14111 deep copy of the base cache's method_hash.
14112 (MemberCache.SetupCache): Rename back from DeepCopy.
14113 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14114 already initialized. If we see an override function, add its
14115 underlying base virtual function to the member_hash too.
14117 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14119 2005-03-26 Raja R Harinath <harinath@acm.org>
14122 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14123 fails to resolve, ensure that the LHS is still resolved as an
14126 2005-03-25 Raja R Harinath <harinath@acm.org>
14128 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14130 (Enum.current_ec): Remove.
14131 (Enum.LookupEnumValue): Remove EmitContext argument.
14132 Just uses the one created during DefineType.
14133 (Enum.FindMembers): Update.
14134 * expression.cs (MemberAccess.DoResolve): Update.
14136 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14138 * assign.cs (Assign.DoResolve): Check for CS1717 when
14139 source and target are same (uses Equals).
14141 * expression.cs (LocalVariableReference, ParameterReference,
14142 This): Implemented Equals, GetHashCode.
14144 * statement.cs (Block.GetParameterReference): Removed useless
14147 2005-03-22 Raja R Harinath <rharinath@novell.com>
14150 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14151 blocks before deciding whether the error is cs0136 or cs0128.
14153 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14154 (using_alias_directive, using_namespace_directive): Pass
14155 MemberName, not an expression to Namespace.UsingAlias and
14157 (MakeName): Use the MemberName of the namespace.
14158 * namespace.cs (Namespace.MemberName): New.
14159 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14160 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14162 * decl.cs (MemberName.Name): Make readonly.
14163 (MemberName.FromDotted): New "constructor".
14164 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14165 (MemberCore.Name): Compute from MemberName on demand.
14166 (MemberCore.SetMemberName): Provide a way to change the
14168 (MemberCore.AddToContainer): Don't take a fullname parameter.
14169 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14170 fully qualified name of the container to the member name.
14171 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14172 only if the type is a member of the root container.
14173 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14174 MemberName.Left rather than searching for an embedded ".".
14175 (PartialContainer.CreatePart): Update to changes in RootContext.
14176 (MemberBase.ShortName): Turn into a property. Use
14177 MemberCore.SetMemberName.
14178 (MemberBase.ExplicitInterfaceName): Remove.
14179 (MemberBase.UpdateMemberName): Remove.
14180 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14181 (PropertyBase.SetMemberName): New override.
14182 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14183 (Tree.GetDecl): New.
14184 (Tree.AllDecls): Rename from Decls.
14185 * attribute.cs, enum.cs, report.cs: Update to changes.
14186 * driver.cs (MainDriver): Use MemberName.FromDotted on
14187 RootContext.MainClass.
14189 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14191 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14194 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14196 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14198 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14199 property accessor modifiers.
14201 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14202 fixed buffer attribute (CS1716).
14203 (PropertyMethod.HasCustomAccessModifier): When property accessor
14204 has custom modifier.
14206 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14208 (PropertyExpr.DoResolveLValue): Add CS0272.
14210 2005-03-17 Miguel de Icaza <miguel@novell.com>
14212 * convert.cs: When converting to a pointer, use the proper Conv.U
14213 or Conv.I depending on the source data type.
14215 * cs-tokenizer.cs: Make the size for large decimal constants,
14218 2005-03-17 Martin Baulig <martin@ximian.com>
14220 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14221 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14223 2005-03-17 Martin Baulig <martin@ximian.com>
14225 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14226 to bool so we can return an error condition.
14227 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14230 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14232 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14235 2005-03-16 Raja R Harinath <rharinath@novell.com>
14237 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14238 Refactor to avoid traversing the list of assemblies, and to avoid
14239 string concatenation.
14240 * typemanager.cs (guid_attr_type): Remove.
14241 (negative_hits, pointers, references): Remove hashes.
14243 (GetConstructedType): New. Uses type_hash to handle constructed
14244 types (arrays, references, pointers).
14245 (GetReferenceType, GetPointerType): Use it.
14246 (GetNestedType): New. Uses type_hash to handle nested types of
14248 (LookupType, LookupTypeDirect): Remove.
14249 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14250 'types' hash and LookupTypeReflection directly.
14251 (params_string, params_object): Use GetConstructedType.
14252 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14254 (Namespace.Lookup): Use cached_types.
14255 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14256 provided by old TypeManager.LookupType.
14257 * rootcontext.cs (MakeFQN): Remove.
14258 * decl.cs (DeclSpace.MakeFQN): Likewise.
14259 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14260 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14261 TypeManager.GetConstructedType.
14262 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14264 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14266 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14269 * cs-parser.jay: Reports CS1527 for any namespace element.
14271 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14274 * expression.cs (ParameterReference.IsAssigned): Changed error to
14276 (Error_WrongNumArguments): Moved CS0245 detection here.
14278 * statement.cs (Return.Resolve): Add CS1622 report.
14280 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14282 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14284 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14286 * attribute.cs expression.cs: Get rid of some allocations.
14288 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14290 * doc.cs : just eliminate the latest change.
14292 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14294 * doc.cs : commented out the latest change. It breaks xml-030.cs
14296 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14298 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14299 fail. So invoke CreateType() in FindDocumentedType().
14301 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14303 * cs-tokenizer.cs : added IsKeyword().
14304 * doc.cs : Detect keyword incorrectly used as identifier.
14305 Allow identifiers prefixed by @.
14307 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14309 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14310 It caused exception in namespace resolving (again!).
14312 * class.cs (Class.ctor): Removed exit.
14313 (PropertyMethod.ctor): ditto.
14315 * codegen.cs (Codegen.Reset): Reset static data.
14316 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14318 * cs-tokenizer.cs (Cleanup): Removed.
14320 * driver.cs (GetSystemDir): Rewrote to one line command.
14321 It caused problem with unloaded dynamic modules.
14322 (UnixParseOption): Removed Exit.
14323 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14324 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14325 Now can be mcs used as library.
14327 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14330 * location.cs (Reset): Reset static data.
14332 * namespace.cs (Reset): Reset static data.
14334 * report.cs (Report.Reset): Reset static data.
14336 * rootcontext.cs (RootContext.Reset): Reset static data.
14338 * tree.cs (RootTypes.ctor): Use Location.Null
14340 * typemanager.cs (TypeManager.Reset): Reset static data.
14341 (CoreLookupType): Removed Exit.
14342 (TypeHandle.Reset): Reset static data.
14344 2005-03-10 Raja R Harinath <rharinath@novell.com>
14347 * typemanager.cs (ComputeNamespaces): Import namespaces from
14348 referenced modules too.
14350 2005-03-09 Raja R Harinath <rharinath@novell.com>
14352 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14355 2005-03-09 Raja R Harinath <rharinath@novell.com>
14357 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14358 enclosing DeclSpace. This ensures that a name-lookup populates
14359 more caches and there are fewer 'TypeExpression's. Carve out
14360 nested type lookup into ...
14361 (LookupNestedTypeInHierarchy): ... this.
14363 2005-03-09 Raja R Harinath <rharinath@novell.com>
14365 Clean up a few partial-class semantics.
14366 Fixes test-357.cs and cs1618-2.cs.
14367 * cs-parser.jay (struct_declaration): Use 'current_class' as
14368 parent of newly-created struct. Remove call to Register ().
14369 Use 'pop_current_class' to complete handing the current struct.
14370 (interface_declaration): Likewise.
14371 (class_declaration): Likewise.
14372 (enum_declaration): Use 'current_class' as parent of newly created
14374 (delegate_declaration): Likewise.
14375 (pop_current_class): New function. This is used to handle closing
14376 up the 'current_class' and 'current_container', and pointing them
14377 to the enclosing class/container.
14378 (CSharpParser): Initialize 'current_class' too.
14379 * decl.cs (MemberCore): Add check for invariant: a partial
14380 container is not a parsed entity, and thus does not enclose any
14382 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14383 (DeclSpace.BaseTypeExpr): Use it.
14384 (DeclSpace.LookupType): Add check for invariant.
14385 * class.cs (TypeContainer): Add check for invariant: a nested
14386 class should have the same NamespaceEntry as its enclosing class.
14387 (TypeContainer.EmitFieldInitializers): Make virtual.
14388 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14390 (TypeContainer.Register): Remove.
14391 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14392 null. Use TypeResolveEmitContext for resolving base types and
14393 interfaces. Move initialization of Parts.TypeBuilder here from
14395 (TypeContainer.DefineNestedTypes): ... here.
14396 (PartialContainer): Take a Namespace not a NamespaceEntry.
14397 (PartialContainer.Create): Don't use Register. Call the
14398 appropriate Add... function directly.
14399 (ClassPart): Take both the PartialContainer and the enclosing
14400 class as constructor arguments.
14401 (ClassPart.EmitFieldInitializers): Override.
14402 (ClassPart.PartFindNestedTypes): Remove.
14403 (FieldBase.GetInitializerExpression): Resolve the initializer
14404 expression in the emit context of the enclosing class.
14405 * tree.cs (RootTypes): Remove Register ().
14407 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14409 * cs-parser.jay: Removed CS0134.
14411 * driver.cs: Removed CS1901.
14413 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14414 for predefined types.
14416 2005-03-07 Duncan Mak <duncan@novell.com>
14418 * codegen.cs (Save): Catch UnauthorizedAccessException as
14419 well. Fixes bug #73454.
14421 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14423 * cs-tokenizer.cs (xtoken): Add CS1035.
14425 * class.cs (MethodData.Define): Add CS0683.
14426 (FieldMember.ctor): Add CS0681.
14428 2005-03-07 Raja R Harinath <rharinath@novell.com>
14430 * ecore.cs (SimpleName.DoResolve): Rename from
14431 SimpleName.DoResolveAllowStatic.
14432 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14433 Pass 'intermediate' flag to MemberStaticCheck.
14434 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14435 of "intermediate" lookups via MemberAccess.
14436 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14437 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14439 2005-03-07 Raja R Harinath <rharinath@novell.com>
14442 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14443 slipped in because of variable names that are identical to a
14444 builtin type's BCL equivalent ('string String;', 'int Int32;').
14445 (PropertyExpr.EmitInstance): Likewise.
14447 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14449 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14451 * report.cs (warning_ignore_table): Made public.
14453 2005-03-04 Raja R Harinath <rharinath@novell.com>
14456 * class.cs (MethodData.Emit): Pass 'container' to
14457 container.GetObsoleteAttribute instead of 'container.Parent'.
14459 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14461 * cs-parser.jay: Add 1534 error test.
14463 * iterators.cs (Yield.CheckContext): Add error 1629.
14464 (Iterator.ctor): Save unsafe modifier.
14465 (MoveNextMethod.DoEmit): Restore unsafe context.
14467 * namespace.cs (UsingAlias): Better error message.
14469 2005-03-03 Dan Winship <danw@novell.com>
14471 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14472 the warning message [#73219]
14474 2005-03-03 Raja R Harinath <rharinath@novell.com>
14476 Fix compile with MCS 1.0.0.0.
14477 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14478 w_restore to not depend on string constant folding.
14480 2005-03-03 Raja R Harinath <rharinath@novell.com>
14482 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14483 CS0246 check to users who passed 'silent = false'.
14484 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14486 (SimpleName.SimpleNameResolve): Update.
14487 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14488 (MemberAccess.IdenticalNameAndTypeName): Update.
14489 * doc.cs (FindDocumentedTypeNonArray): Update.
14491 2005-03-03 Raja R Harinath <rharinath@novell.com>
14493 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14494 * parameters.cs (ComputeAndDefineParameters): Remove.
14495 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14496 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14497 Use GetParameterInfo.
14499 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14501 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14503 2005-03-02 Raja R Harinath <rharinath@novell.com>
14505 Unify DeclSpace.LookupType and DeclSpace.FindType.
14506 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14507 is in charge of defining nested types on demand.
14508 (DeclSpace.LookupType): Use it when the current_type is a
14509 TypeBuilder. Use LookupTypeDirect for reflected types.
14510 (DeclSpace.FindType): Remove.
14511 (DeclSpace.LookupInterfaceOrClass): Likewise.
14512 (DeclSpace.DefineTypeAndParents): Likewise.
14513 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14514 DeclSpace.LookupType.
14515 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14516 * typemanager.cs (LookupType): Simplify.
14517 (AddUserType): Remove type from negative_hits.
14518 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14519 * class.cs (TypeContainer.FindMembers): Move handling of nested
14521 (TypeContainer.FindMembers_NestedTypes): ... here.
14522 (TypeContainer.FindNestedType): Implement override.
14523 (ClassPart.FindNestedType): Delegate to PartialContainer.
14524 (ClassPart.PartFindNestedType): Looks up the nested types of the
14527 2005-03-02 Martin Baulig <martin@ximian.com>
14529 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14530 static constructor in static classes.
14532 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14534 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14535 sizeParamIndex is not specified.
14537 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14540 * report.cs (WarningMessage.IsEnabled): Missing null check.
14542 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14544 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14545 in the fields and not in the properties.
14547 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14549 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14552 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14554 * attribute.cs: Small refactoring (improved robustness).
14555 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14556 (ValidateGuid): Removed.
14557 (Resolve): Removed referenced to above mentioned.
14558 (GetAttributeUsage): Made private and changed to work without
14560 (GetIndexerAttributeValue): Don't crash.
14561 (GetConditionalAttributeValue): Ditto.
14562 (GetClsCompliantAttributeValue): Ditto.
14563 (ExtractSecurityPermissionSet): All attributes exceptions are
14565 (GetPropertyValue): New helper.
14566 (GetMethodImplOptions): New method.
14567 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14568 some missing properties.
14570 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14571 (Method.ApplyAttributeBuilder): Updated.
14573 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14576 2005-02-28 Raja R Harinath <rharinath@novell.com>
14579 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14580 non-simple types (array, pointer, reference).
14582 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14584 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14586 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14588 (Method.CheckBase): Catch wrong destructor here.
14589 (MethodData.Define): Add errors 550, 668.
14591 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14593 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14595 * pending.cs (VerifyPendingMethods): Add error 551.
14597 * typemanager.cs (CSharpName): Next error report helper.
14599 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14601 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14602 attributes. Removed useless attribute double check.
14603 It saves almost 2MBs for corlib.
14605 2005-02-25 Raja R Harinath <rharinath@novell.com>
14608 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14609 called twice in case of error.
14611 2005-02-23 Chris Toshok <toshok@ximian.com>
14613 Fix compiler portions of #72827.
14614 * statement.cs (Block.Emit): call Begin/EndScope on the
14615 EmitContext instead of the ILGenerator.
14617 * codegen.cs (EmitContext.BeginScope): new method, call
14618 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14620 (EmitContext.BeginScope): same, but EndScope and CloseScope
14622 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14623 offset and call the superclass's OpenScope(int) with it.
14624 (SymbolWriter.CloseScope): get the current il
14625 offset and call superclass's CloseScope(int) with it.
14627 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14629 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14630 CS1677 for out and ref as well.
14632 * class.cs (Method.Define): Add error CS1599 detection.
14634 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14636 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14638 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14640 * support.cs.cs (ModifierDesc): New helper method.
14642 2005-02-23 Raja R Harinath <rharinath@novell.com>
14643 Abin Thomas <projectmonokochi@rediffmail.com>
14644 Anoob V E <projectmonokochi@rediffmail.com>
14645 Harilal P R <projectmonokochi@rediffmail.com>
14647 Fix #57851, #72718.
14648 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14649 MemberLookup (used for error reporting) actually returns a result.
14650 Fix error report number (122, not 112).
14652 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14653 Anoob V E <projectmonokochi@rediffmail.com>
14654 Harilal P R <projectmonokochi@rediffmail.com>
14657 * pending.cs (PendingImplementation.GetAbstractMethods):
14658 Find NonPublic members too.
14660 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14662 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14665 * class.cs (MethodCore.CheckMethodAgainstBase):
14666 Add error 239 report.
14668 2005-02-21 Raja R Harinath <rharinath@novell.com>
14671 * expression.cs (Invocation.IsApplicable): Make public.
14672 (Invocation.IsParamsMethodApplicable): Likewise.
14673 * delegate.cs (Delegate.VerifyApplicability): Don't use
14674 Invocation.VerifyArgumentCompat for parameter applicability
14675 testing. Use Invocation.IsApplicable and
14676 Invocation.IsParamsMethodApplicable.
14678 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14680 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14682 * class.cs (Operator.Define): Add error 217 report.
14684 2005-02-21 Raja R Harinath <rharinath@novell.com>
14686 * namespace.cs (UsingEntry.Resolve): Undo change below.
14688 2005-02-21 Raja R Harinath <rharinath@novell.com>
14691 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14692 disable the error message when the extended MemberLookup also
14694 (Expression.MemberLookupFinal): Update.
14695 (SimpleName.DoSimpleNameResolve): Update.
14696 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14697 Don't use MemberLookupFinal.
14698 (New.DoResolve): Update.
14699 (BaseAccess.CommonResolve): Update.
14701 2005-02-21 Raja R Harinath <rharinath@novell.com>
14704 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14705 occured previously, don't resolve again.
14707 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14710 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14711 argument. Call ResolveAttributeUsage for unresolved.
14712 when types doesn't match ctor arguments.
14714 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14715 for nested attribute classes.
14716 (Class.attribute_usage): Removed.
14717 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14718 for attribute class.
14720 * ecore.cs (IsAttribute): Removed.
14722 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14724 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14726 (attribute_types): Removed.
14727 (EmitCode): Global attributes are emited as the latest.
14729 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14731 * class.cs (EmitFieldInitializers): Don't emit field initializer
14732 for default values when optimilization is on.
14734 * constant.cs (Constant.IsDefaultValue): New property.
14736 * driver.cs: Add /optimize handling.
14740 * literal.cs: Implement new IsDefaultValue property.
14742 * rootcontext.cs (Optimize): New field, holds /optimize option.
14744 2005-02-18 Raja R Harinath <rharinath@novell.com>
14746 Fix crasher in re-opened #72347.
14747 * namespace.cs (Namespace.Lookup): Return null if
14748 DeclSpace.DefineType returns null.
14751 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14753 2005-02-18 Raja R Harinath <rharinath@novell.com>
14755 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14756 now returns null if it cannot resolve to an lvalue.
14757 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14758 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14759 returned null. Remove check for SimpleName.
14760 (EventExpr.DoResolveLValue): New.
14761 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14762 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14764 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14765 avoid CS0131 error.
14766 (Unary.ResolveOperator): Move CS0211 check ...
14767 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14769 (Unary.DoResolveLValue): Simplify.
14770 (AddressOf.DoResolveLValue): New.
14771 (ArrayAccess.DoResolveLValue): New.
14773 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14775 * attribute.cs (Attribute.Resolve): Add arguments casting for
14776 when types doesn't match ctor arguments.
14778 2005-02-16 Raja R Harinath <rharinath@novell.com>
14780 Fix parts of #63202.
14781 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14782 lookup of operator in base type. Ensure that all checks happen
14783 when the operator resolves to an "op_..." method.
14785 2005-02-15 Raja R Harinath <rharinath@novell.com>
14788 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14789 'ignore_cs0104' parameter. Pass it to ...
14790 (NamespaceEntry.Lookup): ... this.
14791 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14792 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14793 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14794 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14795 Update. Request that cs0104 errors be ignored.
14796 (ComposedCast.ResolveAsTypeStep): Update.
14798 2005-02-14 Raja R Harinath <rharinath@novell.com>
14801 * expression.cs (Invocation.BetterFunction): Remove support for
14802 comparing virtual functions and their overrides.
14803 (Invocation.IsOverride): New.
14804 (Invocation.OverloadResolve): Don't consider 'override' functions
14805 during candidate selection. Store them in a lookaside list.
14806 If the selected method is a 'virtual' function, use the list to
14807 find any overrides that are closer to the LHS type.
14809 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14811 * expression.cs (New.DoResolve): Add complex core type reduction.
14812 (New.Constantify): Converts complex core type syntax like 'new int ()'
14813 to simple constant.
14815 2005-02-14 Raja R Harinath <rharinath@novell.com>
14817 * decl.cs (EntryType.EntryType): New constructor to create an
14818 updated copy of a cache entry.
14819 (MemberCache.AddMethods): Use it.
14820 (MemberCache.ClearDeclaredOnly): Remove.
14821 (MemberCache.MemberCache): Update.
14823 2005-02-11 Miguel de Icaza <miguel@novell.com>
14825 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14826 variable. This one is represents the actual low-level declaration
14827 of the method, as opposed to the semantic level `IsStatic'.
14829 An anonymous method which is hosted into a static method might be
14830 actually an instance method. IsStatic would reflect the
14831 container, while MethodIsStatic represents the actual code
14834 * expression.cs (ParameterReference): Use the new MethodIsStatic
14835 instead of IsStatic.
14837 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14838 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14839 set on the current EmitContext.
14841 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14842 resolve our casted expression as an LValue. This triggers the
14843 proper LValue processing that is later required by Assign.
14847 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14849 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14851 C# 2.0 Fixed buffer implementation
14853 * anonymous.cs: Update after RegisterHelperClass renaming.
14855 * attribute.cs (AttributeTester.fixed_buffer_cache):
14856 Cache of external fixed buffers.
14857 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14858 implementation if field is fixed buffer else null.
14861 (TypeContainer.AddField): Accept FieldMember instead of Field.
14862 (FieldBase.IsFieldClsCompliant): Extracted code from
14863 VerifyClsCompliance descendant customization.
14864 (FixedField): New class handles fixed buffer fields.
14865 (FixedFieldExternal): Keeps information about imported fixed
14867 (IFixedField): Make access to internal or external fixed buffer
14870 * cs-parser.jay: Add fixed buffer parsing.
14872 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14875 * expression.cs (Indirection): Extended implementation to accept
14876 fixed buffer field.
14877 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14878 (ElementAccess.MakePointerAccess): Get type as parameter.
14879 (DoResolve): Add fixed buffer field expression conversion.
14880 (DoResolveLValue): Ditto.
14881 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14882 (ArrayPtr): Derives from FixedBufferPtr.
14883 (ArrayPtr.Emit): Add extra emit for array elements.
14885 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14887 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14888 for compiler generated types.
14889 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14891 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14892 and consume less memory.
14893 (Fixed.Resolve): Add fixed buffer case.
14895 * typemanager.cs (compiler_generated_attr_ctor,
14896 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14897 (HasElementType): Add our own implementation to work on every
14900 2005-02-11 Miguel de Icaza <miguel@novell.com>
14902 * anonymous.cs (CaptureContext): Track whether `this' has been
14905 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14906 only captured `this' if it was implicitly done (instance
14907 methods/variables were used).
14909 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14910 `this' must be captured.
14912 2005-01-30 Miguel de Icaza <miguel@novell.com>
14914 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14915 is null it means that there has been no need to capture anything,
14916 so we just create a sibling.
14918 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14920 Just a partial fix. The other half is fairly elusive.
14922 2005-02-10 Raja R Harinath <rharinath@novell.com>
14924 Fix #52586, cs0121-4.cs.
14925 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14926 and return a hashtable.
14927 (MemberCache.ClearDeclaredOnly): New.
14928 (MemberCache.MemberCache): Update to change. Make a deep copy of
14929 the method_hash of a base type too.
14930 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14931 type methods. Overwrite entries with the same MethodHandle so
14932 that the ReflectedType is correct. The process leaves in base
14933 virtual functions and their overrides as distinct entries.
14934 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14935 matters since it was boxed in a ArrayList before.
14936 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14938 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14939 case of a virtual function and its override (choose the overload
14941 (Invocation.OverloadResolve): Avoid 'override' members during
14942 'applicable_type' calculation.
14944 2005-02-09 Raja R Harinath <rharinath@novell.com>
14946 Combine two near-redundant caches.
14947 * typemanager.cs (method_params): Rename from method_internal_params.
14948 (TypeManager.GetParameterData): New. Replace
14949 Invocation.GetParameterData.
14950 (TypeManager.LookupParametersByBuilder): Remove.
14951 * expression.cs (Invocation.method_parameter_cache): Remove.
14952 (Invocation.GetParameterData): Remove.
14954 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14957 2005-02-08 Raja R Harinath <rharinath@novell.com>
14960 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14961 TypeManager.multicast_delegate_type is null, resolve it by looking
14962 up "System.MulticastDelegate".
14963 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14965 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14966 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14967 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14970 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14971 (LabeledStatement.AddReference): New. Set 'referenced'.
14972 (Goto.Resolve): Use it.
14974 2005-02-05 John Luke <john.luke@gmail.com>
14976 * driver.cs: remove duplicate -doc line in Usage ()
14978 2005-02-04 Raja R Harinath <rharinath@novell.com>
14980 * location.cs (Location.AddFile): Fix CS2002 error report.
14982 2005-02-02 Martin Baulig <martin@ximian.com>
14984 * delegate.cs (Delegate.DefineType): Report an internal error if
14985 TypeManager.multicast_delegate_type is null. See bug #72015 for
14988 2005-02-02 Raja R Harinath <rharinath@novell.com>
14990 Fix a crasher in a variant of #31984.
14991 * const.cs (Constant.CheckBase): New override that defers the
14992 new-or-override check in case the base type hasn't been populated
14994 (Constant.Define): Ensure the new-or-override check is performed.
14996 2005-02-01 Duncan Mak <duncan@ximian.com>
14998 * const.cs (LookupConstantValue): Check that `ce' is not null
14999 before calling GetValue ().
15001 2005-02-01 Raja R Harinath <rharinath@novell.com>
15003 Fix test-334.cs (#69519).
15004 * cs-parser.jay (using_alias_directive): Pass in an expression to
15005 NamespaceEntry.UsingAlias.
15006 (using_namespace_directive): Pass in an expression to
15007 NamespaceEntry.Using.
15008 (namespace_name): Don't flatten to a string.
15009 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15010 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15012 (NamespaceEntry.UsingEntry): Likewise.
15013 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15015 (NamespaceEntry.LookupForUsing): Remove.
15016 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15018 (NamespaceEntry.Lookup): Remove support for dotted names.
15020 2005-02-01 Raja R Harinath <rharinath@novell.com>
15022 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15024 (NamespaceEntry.ImplicitParent): Compute on demand.
15025 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15026 parallels the current.
15027 (NamespaceEntry.LookupForUsing): Use it.
15028 (NamespaceEntry.Lookup): If the current namespace-entry is
15029 implicit, don't search aliases and using tables.
15031 2005-02-01 Raja R Harinath <rharinath@novell.com>
15034 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15036 (TypeContainer.BaseCache): Compute on demand.
15037 (TypeContainer.FindMembers): Define constants and types if they're
15038 not already created.
15039 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15041 * const.cs (Constant.Define): Make idempotent.
15043 2005-01-29 Miguel de Icaza <miguel@novell.com>
15045 * pending.cs: Produce better code (no nops produced by using Ldarg
15048 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15049 i - 1' it should be arg + 1.
15053 2005-01-28 Raja R Harinath <rharinath@novell.com>
15055 * attribute.cs (Attribute.CheckAttributeType): Make private
15057 (Attribute.ResolveType): Make virtual.
15058 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15059 handling of RootContext.Tree.Types.
15061 2005-01-27 Raja R Harinath <rharinath@novell.com>
15063 Update attribute-handling to use the SimpleName/MemberAccess
15065 * cs-parser.jay (attribute): Pass in an expression to the
15066 constructors of Attribute and GlobalAttribute.
15067 * attribute.cs (Attribute): Take an expression for the name.
15068 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15069 passed in attribute name expression.
15070 (Attribute.CheckAttributeType): Use it.
15071 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15072 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15073 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15074 argument to prevent error messages if the lookup fails.
15076 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15078 * expression.cs (Indirection): Implemented IVariable interface
15079 to support indirection in AddressOf operator.
15080 (PointerArithmetic.Emit): Add optimalization for case where
15081 result can be precomputed.
15083 2005-01-26 Martin Baulig <martin@ximian.com>
15085 * class.cs (TypeContainer.AttributeTargets): Return the correct
15086 AttributeTargets depending on our `Kind' instead of throwing an
15087 exception; fixes #71632.
15089 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15092 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15095 2005-01-25 Raja R Harinath <rharinath@novell.com>
15098 * expression.cs (MemberAccess.DoResolve): Don't complain with
15099 cs0572 when the LHS of a member access has identical name and type
15102 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15105 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15107 Create custom PermissionSet only for PermissionSetAttribute.
15109 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15112 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15113 delegates in static class.
15115 2005-01-24 Martin Baulig <martin@ximian.com>
15117 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15118 merging an implicit block, just use its reachability.
15120 * statement.cs (Block.Resolve): Make the unreachable code check
15121 work wrt. implicit blocks; see test-337 from #63842.
15123 2005-01-21 Alp Toker <alp@atoker.com>
15125 * cs-parser.jay: destructor_declaration's container is PartialContainer
15126 not Class when partial types are used, so use Kind prop instead of
15129 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15131 * cs-parser.jay: Improve error reporting when an interface
15132 declares new types.
15134 2005-01-20 Dick Porter <dick@ximian.com>
15136 * support.cs: SeekableStreamReader fix from Sandor Dobos
15137 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15138 chars are read. Fixes bug 70369.
15140 2005-01-20 Raja R Harinath <rharinath@novell.com>
15142 * cs-parser.jay (catch_clause): Simplify current_block handling
15145 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15147 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15148 code with ImplicitStandardConversion to handle the implicit
15149 conversion of method groups into valid delegate invocations.
15151 The problem is that in parameter handling we were using this code
15152 path. Fixes bug #64698
15154 2005-01-19 Raja R Harinath <rharinath@novell.com>
15156 * cs-parser.jay: Fix several infelicities.
15157 - Avoid assigning to the parser value stack. Code like
15158 '$3 = null' is unclean. Synthesize a value for the code block
15160 - Avoid using oob_stack for storing location information. Use ...
15161 (_mark_): ... this. New (empty) rule. Saves the current location
15163 (foreach_statement): Avoid using oob_stack for current_block
15164 handling. Use technique used in for_statement and
15165 using_statement. Synthesize a value for the code block to store
15166 additional intermediate information.
15168 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15170 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15171 of a different type is only allowed to private fields of a
15172 containing type, not on fields of a base class.
15174 See test-174.cs and error cs0122-9.cs
15176 2005-01-13 Raja R Harinath <rharinath@novell.com>
15178 Fix test-335.cs (bug #58126).
15179 * cs-parser.jay (argument): Split out non-expression parts of the
15180 rule into 'non_simple_argument'.
15181 (invocation_expression): Support parenthesized invocations with
15182 multiple arguments, and with single non-simple arguments.
15184 2005-01-13 Raja R Harinath <rharinath@novell.com>
15186 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15189 2005-01-12 Raja R Harinath <rharinath@novell.com>
15191 Fix cs0038-1.cs, cs1640-6.cs.
15192 * ecore.cs (Expression.Resolve): Remove special-case for
15193 SimpleName in error-handling.
15194 (Expression.almostMatchedMembers): Relax access permission to
15196 (Expression.MemberLookupFailed): Handle duplicates in
15197 almostMatchedMembers list.
15198 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15199 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15200 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15201 overload if the passed in MemberInfo is a MethodBase.
15203 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15206 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15207 for non-CAS & merge permission sets properly.
15209 2005-01-11 Raja R Harinath <rharinath@novell.com>
15211 Improve standard-compliance of simple name and member access
15212 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15213 * ecore.cs (FullNamedExpression): New abstract base class
15214 for Namespaces and TypeExpressions.
15215 (ResolveFlags.SimpleName): Remove.
15216 (SimpleName): Remove support for dotted names.
15217 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15218 DeclSpace.FindType and DeclSpace.LookupType.
15219 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15220 (Expression.ExprClassName): Make member function.
15221 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15222 a namespace. Remove creation of dotted "SimpleName"s.
15223 (MemberAccess.DoResolve): Likewise.
15224 * decl.cs (DeclSpace.Cache): Make private.
15225 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15226 (DeclSpace.FindType): Update.
15227 (DeclSpace.LookupType): Move here from RootContext. Return a
15228 FullNamedExpression.
15229 * namespace.cs (Namespace): Derive from FullNamedExpression
15230 so that it can be part of expression resolution.
15231 (Namespace.Lookup): Return an FullNamedExpression.
15232 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15234 * rootcontext.cs (NamespaceLookup): Remove.
15235 (LookupType): Move to DeclSpace.
15236 * attribute.cs (CheckAttributeType): Update.
15237 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15238 (FindDocumentedTypeNonArray): Likewise.
15240 2005-01-11 Raja R Harinath <rharinath@novell.com>
15242 Fix cs0509.cs, cs1632.cs.
15243 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15244 is the same as IsInterface.
15245 (TypeContainer.GetClassBases): Likewise.
15246 * statement.cs (LabeledStatement.ig): New field.
15247 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15249 (LabeledStatement.DoEmit): Check that the label was created with
15250 the same ILGenerator.
15252 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15255 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15256 accessors to its properties.
15258 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15259 from accessors to property.
15261 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15264 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15265 only for overrides.
15267 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15269 * attribute.cs: Check for null and empty strings.
15271 I have lost another battle to Paolo.
15273 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15276 * class.cs (PropertyMethod): Set Parent field in ctors.
15277 (SetMethod.InternalParameters): Add unsafe switch hack.
15278 Override MarkForDuplicationCheck where it is appropriate.
15280 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15281 It says whether container allows members with the same name.
15282 Base default is no.
15283 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15284 Removed is_method parameter.
15286 2005-01-06 Duncan Mak <duncan@ximian.com>
15288 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15289 because the previous change led to incorrect reporting of CS1032
15290 ("Cannot define/undefine preprocessor symbols after first token in
15291 file"). Instead of using `tokens_seen' as the only flag that
15292 triggers CS1040, introduce `comments_seen'. This new flag is used
15293 to signify having seen comments on the current line, so it is
15294 unset after a newline.
15296 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15298 * doc.cs : When searching for a type, find nested type too.
15299 This fixes bug #71040.
15301 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15304 - Warn missing member comment on those classes which also does not
15305 have doc comments. Fixed bug #71041.
15306 - Don't warn missing doc comment on default constructor.
15309 2005-01-06 Duncan Mak <duncan@ximian.com>
15311 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15312 comments, set `tokens_seen' to true. This allows us to detect
15313 misplaced preprocessor directives (i.e. not at the beginning of
15314 the a line, nor after whitespaces). In that case, report error
15315 CS1040. This fixes bug #56460.
15317 * cs-parser.jay (interface_member_declaration): Add checks for
15318 IsExplicitImpl, and report CS0541 error if an interface member is
15319 defined as an explicit interface declaration.
15321 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15324 * class.cs (PropertyMethod): Set Parent field in ctors.
15325 (SetMethod.InternalParameters): Add unsafe switch hack.
15327 * decl.cs (MemberCore.Parent): Cannot be readonly.
15329 2005-01-06 Raja R Harinath <rharinath@novell.com>
15331 * decl.cs (DeclSpace.ResolveType): Remove.
15332 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15333 Merge in code from ...
15334 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15335 * class.cs, enum.cs: Update to changes.
15337 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15339 * anonymous.cs: Ensure that we init the scope of our parent if it
15340 has not been initialized yet.
15342 2004-12-30 Duncan Mak <duncan@ximian.com>
15344 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15345 if field.FieldBuilder is null. Fixes #70758.
15347 * convert.cs: Fixed some typos and updated some of the comments.
15348 (ImplicitStandardConversionExists):
15349 (TryImplicitIntConversion): If `target_type' is an interface and
15350 the type of `ic' implements this interface, return true or a new
15351 BoxedCast instead of null. This fixes #70468.
15353 2004-12-29 Duncan Mak <duncan@ximian.com>
15355 * expression.cs (Argument.Emit): Check that Expr is
15356 IMemoryLocation before casting to it, and report CS1510 otherwise.
15360 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15362 * statement.cs (Block.ThisVariable): remove the recursion here, to
15363 make the --profile more sane.
15365 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15367 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15368 assembly, by JB Evain.
15370 2004-12-17 Raja R Harinath <rharinath@novell.com>
15372 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15373 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15374 "parent" refers to enclosing type/class. "base" refers to superclass.
15376 2004-12-17 Raja R Harinath <rharinath@novell.com>
15378 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15379 Ensure that we only have GlobalAttributes.
15380 * attribute.cs (Attribute.Emit): Make non-virtual.
15381 (GlobalAttribute.Emit): Remove.
15382 (Attribute.Resolve): Make virtual.
15383 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15384 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15385 the argument. Don't create one.
15386 (Attribute.GetObsoleteAttribute): Likewise.
15387 (Attribute.GetClsCompliantAttributeValue): Likewise.
15388 * class.cs, decl.cs: Update to changes.
15390 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15392 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15394 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15396 * statement.cs (Foreach.Resolve): Add error 186 report.
15398 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15400 * expression.cs (Conditional.DoResolve): Add warning 429.
15402 * statement.cs (If.Resolve): Add warning 665.
15404 2004-12-16 Raja R Harinath <rharinath@novell.com>
15406 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15407 except when in the parser, and in GlobalAttribute.
15408 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15409 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15410 RootContext.Tree.Types.NamespaceEntry once work is done.
15411 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15412 and resets RootContext.Tree.Types.NamespaceEntry.
15414 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15416 * cs-parser.jay: Don't create a block for every variable.
15418 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15420 * location.cs: Provide extra information.
15422 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15423 variables from the captured environment, it is the ldarg_0.
15425 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15427 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15430 * class.cs: Changed warning level for 169 to avoid developer
15431 displeasure from warning flooding. It will be changed back when they
15432 fix most of current BCL warnings.
15434 * RootContext.cs: Pushed default WarningLevel to 3.
15436 * statement.cs: Removed unused variable.
15438 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15440 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15441 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15442 Add error 502 report.
15443 (StaticClass.DefineType): Add error 441 report.
15444 (Class.AllowedModifiersProp): New virtual property as temporary
15445 extension to AllowedModifiers.
15446 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15447 to share implementation with StaticClass and don't call virtual
15450 * driver.cs (MainDriver): Add error 1558 test.
15452 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15453 report. Moved error 36 test here.
15455 * statement.cs (Throw.Resolve): Add error 724 report.
15457 * typemanager.cs: Add out_attribute_type core type.
15459 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15461 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15463 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15465 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15468 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15470 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15471 Add error 3023 report.
15472 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15474 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15477 2004-12-12 John Luke <john.luke@gmail.com>
15479 * driver.cs (AddArgs): take -- into account when
15480 adding arguments, fixes bug 65710
15482 2004-12-12 Martin Baulig <martin@ximian.com>
15484 * expression.cs (Unary.TryReduceNegative): Added support for
15485 SByteConstant and ByteConstant.
15486 (Unary.Reduce): Check error values from TryReduceNegative().
15488 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15490 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15491 and report exception as error 182.
15493 2004-12-10 Raja R Harinath <rharinath@novell.com>
15495 * driver.cs (Main): Fix message when there are warnings.
15497 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15499 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15501 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15503 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15504 Reduced number of warnings.
15506 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15508 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15510 * driver.cs: Removed message.
15512 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15514 2004-12-08 <vargaz@freemail.hu>
15516 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15518 2004-12-08 Martin Baulig <martin@ximian.com>
15520 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15521 instead of a CS3002 for properties and indexer.
15523 2004-12-08 Martin Baulig <martin@ximian.com>
15525 * decl.cs (MemberName.ToString): Make this work again.
15527 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15529 * attribute.cs (Resolve): Add error 591 detection.
15531 * class.cs (FieldMember.Define): Add error 1547 detection.
15532 (Indexer.Define): Add error 620 detection.
15533 (Operator.Define): Add error 590 detection.
15535 * ecore.cs: Missing argument for error 79.
15537 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15540 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15543 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15546 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15548 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15549 Some operator comments were suppressed.
15550 * doc.cs : Implicit/explicit operator name in doc comments are like
15551 "op_Explicit(type)~returnType", so added suffix handling.
15553 2004-12-07 Martin Baulig <martin@ximian.com>
15556 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15557 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15558 (DeclSpace.ec): New protected field; store the EmitContext here.
15559 (DeclSpace.EmitContext): New public property; moved here from
15561 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15564 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15565 (Enum.Emit): Don't create a new EmitContext.
15567 * delegate.cs (Delegate.DefineType): Always create the
15570 * iterators.cs (Iterators.DefineIterator): Create a new
15571 EmitContext and store it in `ec'.
15573 2004-08-24 Martin Baulig <martin@ximian.com>
15576 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15577 this for accessibility checks.
15578 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15579 IsNestedFamilyAccessible.
15580 (TypeManager.IsSubclassOf): New method, do what the name actually
15583 2004-12-06 Raja R Harinath <rharinath@novell.com>
15585 Fix crash on cs0657-17.cs.
15586 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15587 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15588 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15589 the case where the NamespaceEntry gets overwritten.
15591 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15593 Fixed #69195, #56821
15594 * ecore.cs (ResolveBoolean): Tiny refactoring.
15596 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15597 of right expression resolving when left is false constant and
15598 operator is LogicalAnd OR true constant and operator is LogicalOr.
15600 * statement.cs (ResolveUnreachable): Always reports warning.
15602 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15604 * class.cs: Distinguish between 1721 and 1722 (just a little help
15605 for the programmer).
15607 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15609 * delegate.cs: Only allow this on new versions of the language.
15611 2004-12-02 Duncan Mak <duncan@ximian.com>
15613 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15615 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15616 here as a static method. Take an additional bool out parameter
15617 `must_do_cs1540_check' for signaling to InstanceResolve.
15618 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15619 member field from PropertyExpr class and made it an argument of
15620 the method instead.
15621 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15622 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15623 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15624 and `remove_accessor' as well as InstanceResolve: report CS0122
15629 2004-12-03 Raja R Harinath <rharinath@novell.com>
15631 Fix test-327.cs, test-328.cs, and put in early infrastructure
15632 for eventually fixing #52697.
15633 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15634 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15635 from other methods.
15636 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15637 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15638 (VerifyUsing, error246): Update.
15639 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15640 'NamespaceEntry.LookupNamespaceOrType'.
15642 2004-12-03 Martin Baulig <martin@ximian.com>
15644 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15645 method as our child, call AnonymousMethod.Compatible() on it.
15647 2004-12-03 Raja R Harinath <rharinath@novell.com>
15649 Disable XML documentation support in 'basic' profile.
15650 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15651 Redirect XmlElement to System.Object.
15652 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15653 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15654 * mcs.exe.sources: Add doc-bootstrap.cs.
15655 * doc-bootstrap.cs: New file. Contains empty stub implementation
15658 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15660 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15661 comments are allowed.
15663 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15665 * delegate.cs: Add checks for subtypes in paramaters and return values
15666 in VerifyMethod () to add support for Covariance/Contravariance
15669 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15671 * report.cs: Remove extra closing parenthesis.
15673 * convert.cs (Error_CannotImplicitConversion): If the name of the
15674 types are the same, provide some extra information.
15676 * class.cs (FieldBase): Use an unused bit field from the field to
15677 encode the `has_offset' property from the FieldMember. This saves
15678 a couple of Ks on bootstrap compilation.
15680 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15681 method as our child, return the AnonymousMethod resolved
15684 * expression.cs (New.DoResolve): Allow return values from
15685 NewDelegate to also include AnonymousMethods.
15689 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15692 * attribute.cs (Resolve): Improved implementation of params
15693 attribute arguments.
15695 * support.cs (ParameterData): Add HasParams to be faster.
15697 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15699 all things are for /doc support:
15701 * doc.cs: new file that supports XML documentation generation.
15702 * mcs.exe.sources: added doc.cs.
15704 Handle /doc command line option.
15705 Report error 2006 instead of 5 for missing file name for /doc.
15706 Generate XML documentation when required, after type resolution.
15708 Added support for picking up documentation (/// and /** ... */),
15709 including a new XmlCommentState enumeration.
15711 Added lines to fill Documentation element for field, constant,
15712 property, indexer, method, constructor, destructor, operator, event
15713 and class, struct, interface, delegate, enum.
15714 Added lines to warn incorrect comment.
15716 Added Documentation field (passed only when /doc was specified).
15718 Added DocComment, DocCommentHeader, GenerateDocComment() and
15719 OnGenerateDocComment() and some supporting private members for
15720 /doc feature to MemberCore.
15722 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15724 Added overriden DocCommentHeader.
15726 Added overriden DocCommentHeader and GenerateDocComment().
15728 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15730 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15731 unwrapping the enumeration values, chain to
15732 DoConstantNumericPromotions again, so we can promote things to the
15733 fundamental types (takes care of enums that are bytes, sbytes).
15737 2004-12-01 Raja R Harinath <rharinath@novell.com>
15739 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15740 Fix long-standing bug in type-lookup. Use FindType instead of
15741 LookupType when ec.ResolvingTypeTree.
15742 (Attribute.ResolveType, Attribute.Resolve)
15743 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15745 (Attributes.Search): Remove internal version. Update.
15746 (Attributes.SearchMulti): Update.
15747 (Attributes.GetClsCompliantAttribute): Remove.
15748 (Attributes.GetIndexerNameAttribute): Remove.
15749 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15750 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15751 * class.cs (Indexer.Define): Likewise.
15753 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15756 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15757 MarshallByReference members access.
15759 * expression.cs: Use CheckMarshallByRefAccess;
15760 Better error CS0197 message.
15762 * report.cs: Print whole related error message.
15764 2004-11-30 Raja R Harinath <rharinath@novell.com>
15766 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15767 the current directory to help debugging.
15769 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15771 * class (GetClassBases): Better error 60 report.
15772 (EventProperty): Disabled warning 67 detection.
15774 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15777 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15779 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15782 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15785 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15787 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15789 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15791 * attribute.cs (Attribute.Resolve): Refine error reporting and
15792 report a cs0117 if the identifier does not exist, to distinguish
15793 from 0617 which is a miss-use of the actual identifier.
15795 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15796 between cs0070 and cs0079.
15798 * class.cs (MemberBase.DoDefine): When reporting a wrong
15799 accessibility level, we use MethodCore to compare instead of
15800 Method (this was a regression in some refactoring effort).
15802 So now we correctly report cs0056 again.
15804 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15805 testing the target_type (which was known to be object_type) and
15806 not the source type (which is anonymous_method).
15808 Fixed reporting of error cs1660.
15810 * expression.cs (UserCast.Source): Expose the underlying cast.
15812 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15813 allowed types to find a match to int32 first (most common).
15815 In addition, it ignores any ImplicitUserConversions that did an
15816 internal implicit conversion (as the switch statement allows only
15817 one integral conversion to exist).
15819 * class.cs (PartialContainer.Create): rename `name' to
15820 `member_name' for clarity. Then replace the string calls with a
15821 call to MemberName.GetPartialName, as now using
15822 MemberName.ToString is an error (this is due to the side effects
15823 it had, that were fixed in the past).
15825 This will restore the error reporting on a number of partial class
15826 errors that were missusing this (and getting an exception as a
15827 results, which is now just a plain textual warning, because
15828 yyparse debug output would crash otherwise).
15830 2004-11-26 Raja R Harinath <rharinath@novell.com>
15832 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15834 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15836 * rootcontext.cs (LookupType): Make sure to cache lookups that
15837 don't give us a negative result. This saves about 5% of corlib
15840 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15842 * report.cs (AbstractMessage.Print): messages are sent to stderr
15844 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15845 non-interface in the list of interfaces (at this point, either
15846 parent was properly set, or a base class is being listed in the
15847 interfaces section).
15849 This flags error 1722, and resolves the crash from bug 69259.
15851 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15853 * statement.cs (Using.EmitExpressionFinally): make this work right
15854 for valuetypes. Fixes 69926.
15856 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15858 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15859 converted to an enum" here, before we try to change the underlying
15860 type. This code exists, but it is a different code path than the
15861 one used while encoding constants.
15863 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15864 old bug: when converting from the null literal to a pointer,
15865 return an EmptyCast, not the NullLiteral.
15867 This fixes #69921, the recent null_type changes probably made this
15868 bug more prominent.
15870 (ImplicitReferenceConversionExists): In addition, resynchronized
15871 the code here, so it matches the same code in
15872 ImplicitReferenceConversionExists for the `from any class-type S
15873 to any interface-type T'.
15876 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15878 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15880 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15882 * cs-parser.jay: Use verbosity accordingly.
15884 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15886 * expression.cs (Unary.ResolveOperator): Do not report warning;
15887 AddressOf reads from variable.
15889 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15891 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15895 * attribute.cs (Attributable): Removed CheckTargets.
15896 (Attributes.Emit): Explicit attribute targets are tested here.
15898 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15899 not enabled for interfaces.
15901 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15902 (GetAssemblyName): Ouch next bug there.
15904 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15906 * expression.cs: Error 275 added.
15908 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15910 Fix bug #69177 (Implemented decimal constant support)
15912 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15913 (BinaryFold): Add DecimalConstant.
15915 * const.cs (Define): Decimal constant
15917 (ChangeType): Add decimal type handling.
15918 (LookupConstantValue): Don't set value for decimal type but
15919 emit DecimalConstantAttribute. Needed for constant optimization.
15921 * constant.cs (ToDecimal): New method.
15922 (ConvertToDecimal): New method.
15923 (IntConstant): Implemented ConvertToDecimal.
15924 (DecimalConstant.Emit): Emit optimized version for decimals in
15927 * expression.cs (ResolveOperator): Changed order of constant
15928 reduction to work correctly with native types which have
15929 overloaded operators.
15930 (ResolveMemberAccess): Extract constant value from attribute
15933 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15935 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15936 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15937 (ChangeType): Decimal is special.
15938 (TypeToCoreType): Add decimal type.
15940 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15942 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15945 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15947 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15950 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15952 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15954 * pending.cs (PendingImplementation): Grab only interfaces.
15956 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15958 * statement.cs (ForeachHelperMethods): Add location member and
15959 error 202 detection.
15961 2004-11-19 Raja R Harinath <rharinath@novell.com>
15963 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15964 automatically handled by executable.make.
15965 (PROGRAM): Make profile-specific.
15967 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15969 * expression.cs (DoResolveBase): Fixed wrong warning for out
15972 2004-11-18 Martin Baulig <martin@ximian.com>
15974 Merged latest changes into gmcs. Please keep this comment in
15975 here, it makes it easier for me to see what changed in MCS since
15976 the last time I merged.
15978 2004-11-17 Raja R Harinath <rharinath@novell.com>
15980 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15981 (TypeHandle.GetMemberCache): New.
15982 (TypeHandle.TypeHandle): Update.
15983 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15984 (TypeManager.LookupParentInterfacesCache):
15985 Rename from LookupInterfaceCache. Optimize slightly.
15986 (TypeManager.MemberLookup_FindMembers): Update.
15987 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15988 multi-type variant.
15989 (AddCacheContents): Rename from AddHashtable.
15990 * class.cs (TypeContainer.parent_container): Remove.
15991 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15992 (TypeContainer.DoDefineMembers): Don't initialize it.
15993 Update to name changes.
15995 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15997 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15998 that factors the code to check access modifiers on override.
16000 (PropertyBase): Use the code here.
16002 Patch from Lluis S'anchez, fixes bug #69361.
16004 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16006 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16007 routine that is used to report the use of a captured variable
16008 whose address has been taken.
16010 There are two checks: one when variables are being captured and
16011 the other check is when the address of a variable is taken.
16013 (because an anonymous methods might be resolved before *or* after
16014 the address has been taken) and
16016 * expression.cs (Conditional.DoResolve): Remove the special
16017 casing that Martin added to trueExpr and falseExpr being both
16018 NullLiteral. We get the right behavior now just by introducing
16019 the null_type into the compiler.
16021 * convert.cs (ExplicitConversion): Change the code to use
16022 null_type instead of testing `expr is NullLiteral'.
16023 (ImplicitConversionStandard): use null_type too.
16024 (ImplicitReferenceConversionExists): use null_type too.
16025 (ImplicitReferenceConversion): use null_type too.
16027 * literal.cs: The type of `NullLiteral' is now null_type instead
16029 (Resolve): Set the type here.
16031 * typemanager.cs: Introduce null_type.
16033 2004-11-17 Martin Baulig <martin@ximian.com>
16035 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16036 direction, like FindMembers() does. Fixes #69546, testcase is in
16039 2004-11-16 Martin Baulig <martin@ximian.com>
16041 This is based on a patch from Marek Safar, see bug #69082.
16042 Fixes bugs #63705 and #67130.
16044 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16045 method; create a MemberCache for an interface type and cache the
16048 * decl.cs (IMemberContainer.ParentContainer): Removed.
16049 (IMemberContainer.ParentCache): New property.
16050 (MemberCache.SetupCacheForInterface): Removed.
16051 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16052 to create a cache for an interface's "parent".
16054 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16057 2004-11-16 Martin Baulig <martin@ximian.com>
16059 Merged back from gmcs; these changes already went into gmcs a
16060 couple of weeks ago.
16063 (TypeManager.AddUserType): Removed the `ifaces' argument.
16064 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16066 (TypeManager.AddUserInterface): Removed.
16067 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16069 (TypeManager.GetInterfaces): Likewise.
16070 (TypeManager.GetExplicitInterfaces): Likewise.
16072 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16074 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16075 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16077 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16079 * statement.cs: Avoid adding bools to a hashtable.
16081 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16083 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16084 calling an unsafe method from a safe location.
16086 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16089 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16091 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16093 * namespace.cs (VerifyUsing): use GetPartialName instead of
16096 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16098 * statement.cs (Return.Resolve): Fix regression in typo: if
16099 `in_exc', we have to request a NeedReturnLabel, this was a typo
16100 introduced in the anonymous method check-in. Fixes #69131.
16102 * Indexers were using the ShortName when defining themselves,
16103 causing a regression in the compiler bootstrap when applying the
16104 patch from 2004-11-02 (first part), now they use their full name
16105 and the bug is gone.
16107 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16109 * driver.cs: Strip the path from the names of embedded resources. Fixes
16112 2004-11-04 Raja R Harinath <rharinath@novell.com>
16114 Fix error message regression: cs0104-2.cs.
16115 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16116 (AliasEntry.Resolve): Update.
16117 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16119 (RootContext.LookupType): Update.
16121 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16123 * cs-parser.jay: Add support for handling accessor modifiers
16124 * class: Add support port accessor modifiers and error checking,
16125 define PropertyMethod.Define as virtual (not abstract anymore)
16126 * ecore.cs: Add checking for proeprties access with access modifiers
16127 * iterators.cs: Modify Accessor constructor call based in the modified
16129 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16131 * expression.cs (StringConcat): Handle being called twice,
16132 as when we have a concat in a field init with more than two
16135 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16137 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16138 special case explicit implementations, we should always produce
16139 the .property or .event declaration.
16141 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16142 since it will not return correct data if people use this
16143 unresolved in the presence of using statements (see test-313).
16145 * class.cs (MethodData.Define): If we are an explicit interface
16146 implementation, set the method name to the full name of the
16147 interface plus the name of the method.
16149 Notice that using the method.MethodName.GetFullName() does not
16150 work, as it will only contain the name as declared on the source
16151 file (it can be a shorthand in the presence of using statements)
16152 and not the fully qualifed type name, for example:
16156 class D : ICloneable {
16157 object ICloneable.Clone () {
16161 Would produce a method called `ICloneable.Clone' instead of
16162 `System.ICloneable.Clone'.
16164 * namespace.cs (Alias.Resolve): Use GetPartialName.
16166 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16168 * cs-parser.jay: Add error 1055 report.
16170 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16172 * assign.cs (Assign.DoResolve): Only do the transform of
16173 assignment into a New if the types are compatible, if not, fall
16174 through and let the implicit code deal with the errors and with
16175 the necessary conversions.
16177 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16179 * cs-parser.jay: Add error 1031 report.
16181 * cs-tokenizer.cs: Add location for error 1038.
16183 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16185 * cs-parser.jay: Add error 1016 report.
16187 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16189 * cs-parser.jay: Add errors 1575,1611 report.
16191 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16193 * cs-parser.jay: Add error 1001 report.
16195 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16198 * attribute.cs (GetMarshal): Add method argument for
16199 caller identification.
16201 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16202 agument for GetMarshal and RuntimeMissingSupport.
16204 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16206 * attribute.cs (ExtractSecurityPermissionSet): Removed
16207 TypeManager.code_access_permission_type.
16209 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16211 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16213 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16214 for obsolete use of a variable here. Fixes regression on errors
16215 cs0619-25 and cs0619-26.
16217 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16219 Fix #62358, implemented security attribute encoding.
16221 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16222 Tests permitted SecurityAction for assembly or other types.
16223 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16224 data from SecurityPermissionAttribute to PermisionSet class.
16226 * class.cs (ApplyAttributeBuilder): Added special handling
16227 for System.Security.Permissions.SecurityAttribute based types.
16229 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16230 special handling for System.Security.Permissions.SecurityAttribute
16233 * enum.cs (ApplyAttributeBuilder): Added special handling
16234 for System.Security.Permissions.SecurityAttribute based types.
16236 * parameter.cs (ApplyAttributeBuilder): Added special handling
16237 for System.Security.Permissions.SecurityAttribute based types.
16239 * rootcontext.cs: Next 2 core types.
16241 * typemanager.cs (TypeManager.security_permission_attr_type):
16242 Built in type for the SecurityPermission Attribute.
16243 (code_access_permission_type): Build in type.
16245 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16247 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16248 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16249 all of this information into
16250 EmitContext.EmitCapturedVariableInstance.
16252 * codegen.cs (EmitCapturedVariableInstance): move here the
16253 funcionality of emitting an ldarg.0 in the presence of a
16254 remapping. This centralizes the instance emit code.
16256 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16257 then emit a load of this: it means that we have reached the
16258 topmost ScopeInfo: the one that contains the pointer to the
16259 instance of the class hosting the anonymous method.
16261 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16262 captures to the topmost CaptureContext.
16264 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16266 * expression.cs (LocalVariableReference): Move the knowledge about
16267 the iterators into codegen's EmitCapturedVariableInstance.
16269 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16271 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16272 all code paths return a value from an anonymous method (it is the
16273 same as the 161 error, but for anonymous methods).
16275 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16277 The introduction of anonymous methods in the compiler changed
16278 various ways of doing things in the compiler. The most
16279 significant one is the hard split between the resolution phase
16280 and the emission phases of the compiler.
16282 For instance, routines that referenced local variables no
16283 longer can safely create temporary variables during the
16284 resolution phase: they must do so from the emission phase,
16285 since the variable might have been "captured", hence access to
16286 it can not be done with the local-variable operations from the runtime.
16290 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16291 is a toplevel block.
16293 (ToplevelBlock): A new kind of Block, these are the blocks that
16294 are created by the parser for all toplevel method bodies. These
16295 include methods, accessors and anonymous methods.
16297 These contain some extra information not found in regular blocks:
16298 A pointer to an optional CaptureContext (for tracking captured
16299 local variables and parameters). A pointer to the parent
16302 (Return.Resolve): Catch missmatches when returning a value from an
16303 anonymous method (error 1662).
16304 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16307 (Break.Resolve): ditto.
16309 (SwitchLabel): instead of defining the labels during the
16310 resolution phase, we now turned the public ILLabel and ILLabelCode
16311 labels into methods called GetILLabelCode() and GetILLabel() that
16312 only define the label during the Emit phase.
16314 (GotoCase): Track the SwitchLabel instead of the computed label
16315 (its contained therein). Emit the code by using
16316 SwitchLabel.GetILLabelCode ().
16318 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16319 whether the Local has been captured or not.
16321 (LocalInfo.IsCaptured): New property, used to tell whether the
16322 local has been captured.
16324 * anonymous.cs: Vastly updated to contain the anonymous method
16327 The main classes here are: CaptureContext which tracks any
16328 captured information for a toplevel block and ScopeInfo used to
16329 track the activation frames for various local variables.
16331 Each toplevel block has an optional capture context associated
16332 with it. When a method contains an anonymous method both the
16333 toplevel method and the anonymous method will create a capture
16334 context. When variables or parameters are captured, they are
16335 recorded on the CaptureContext that owns them, for example:
16339 MyDelegate d = delegate {
16344 Here `a' will be recorded as captured on the toplevel
16345 CapturedContext, the inner captured context will not have anything
16346 (it will only have data if local variables or parameters from it
16347 are captured in a nested anonymous method.
16349 The ScopeInfo is used to track the activation frames for local
16350 variables, for example:
16352 for (int i = 0; i < 10; i++)
16353 for (int j = 0; j < 10; j++){
16354 MyDelegate d = delegate {
16359 At runtime this captures a single captured variable `i', but it
16360 captures 10 different versions of the variable `j'. The variable
16361 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16362 recorded on a child.
16364 The toplevel ScopeInfo will also track information like the `this'
16365 pointer if instance variables were referenced (this is necessary
16366 as the anonymous method lives inside a nested class in the host
16367 type of the method).
16369 (AnonymousMethod): Expanded to track the Toplevel, implement
16370 `AnonymousMethod.Compatible' to tell whether an anonymous method
16371 can be converted to a target delegate type.
16373 The routine now also produces the anonymous method content
16375 (AnonymousDelegate): A helper class that derives from
16376 DelegateCreation, this is used to generate the code necessary to
16377 produce the delegate for the anonymous method that was created.
16379 * assign.cs: API adjustments for new changes in
16380 Convert.ImplicitStandardConversionExists.
16382 * class.cs: Adjustments to cope with the fact that now toplevel
16383 blocks are of type `ToplevelBlock'.
16385 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16386 insteda of standard blocks.
16388 Flag errors if params arguments are passed to anonymous methods.
16390 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16391 `CurrentAnonymousMethod' which points to the current Anonymous
16392 Method. The variable points to the AnonymousMethod class that
16393 holds the code being compiled. It is set in the new EmitContext
16394 created for the anonymous method.
16396 (EmitContext.Phase): Introduce a variable and an enumeration to
16397 assist in enforcing some rules about when and where we are allowed
16398 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16399 only one that enfonces this right now).
16401 (EmitContext.HaveCaptureInfo): new helper method that returns
16402 whether we have a CapturedContext initialized.
16404 (EmitContext.CaptureVariable): New method used to register that a
16405 LocalInfo must be flagged for capturing.
16407 (EmitContext.CapturedParameter): New method used to register that a
16408 parameters must be flagged for capturing.
16410 (EmitContext.CapturedField): New method used to register that a
16411 field must be flagged for capturing.
16413 (EmitContext.HaveCapturedVariables,
16414 EmitContext.HaveCapturedFields): Return whether there are captured
16415 variables or fields.
16417 (EmitContext.EmitMethodHostInstance): This is used to emit the
16418 instance for the anonymous method. The instance might be null
16419 (static methods), this (for anonymous methods that capture nothing
16420 and happen to live side-by-side with the current method body) or a
16421 more complicated expression if the method has a CaptureContext.
16423 (EmitContext.EmitTopBlock): Routine that drives the emission of
16424 code: it will first resolve the top block, then emit any metadata
16425 and then emit the code. The split is done so that we can extract
16426 any anonymous methods and flag any captured variables/parameters.
16428 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16429 during this phase, the ILGenerator should not be used as labels
16430 and local variables declared here might not be accessible to any
16431 code that is part of an anonymous method.
16433 Exceptions to this include the temporary variables that are
16434 created by some statements internally for holding temporary
16437 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16440 (EmitContext.TemporaryReturn): This method is typically called
16441 from the Emit phase, and its the only place where we allow the
16442 ReturnLabel to be defined other than the EmitMeta. The reason is
16443 that otherwise we would have to duplicate a lot of logic in the
16444 Resolve phases of various methods that today is on the Emit
16447 (EmitContext.NeedReturnLabel): This no longer creates the label,
16448 as the ILGenerator is not valid during the resolve phase.
16450 (EmitContext.EmitThis): Extended the knowledge in this class to
16451 work in anonymous methods in addition to iterators.
16453 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16454 code is necessary on the stack to access the instance to a local
16455 variable (the variable will be accessed as a field).
16457 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16458 EmitContext.EmitAddressOfParameter): Routines to support
16459 parameters (not completed at this point).
16461 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16462 will also remove the parameters.
16464 * convert.cs (Convert): Define a `ConstantEC' which points to a
16465 null. This is just to prefity some code that uses
16466 ImplicitStandardConversion code and do not have an EmitContext
16469 The idea is to flag explicitly that at that point in time, it is
16470 known that the conversion will not trigger the delegate checking
16471 code in implicit conversions (which requires a valid
16474 Everywhere: pass new EmitContext parameter since
16475 ImplicitStandardConversionExists now requires it to check for
16476 anonymous method conversions.
16478 (Convert.ImplicitStandardConversionExists): If the type of an
16479 expression is the anonymous_method_type, and the type is a
16480 delegate, we invoke the AnonymousMethod.Compatible method to check
16481 whether an implicit conversion is possible.
16483 (Convert.ImplicitConversionStandard): Only do implicit method
16484 group conversions if the language level is not ISO_1.
16486 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16487 MethodInfo for the Invoke method. used by Delegate and
16490 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16491 method conversions if the target type is a delegate.
16493 Removed extra debugging nops.
16495 (LocalVariableReference): Turn the `local_info' into a public
16498 Add `prepared' field, the same hack used for FieldExprs to cope
16499 with composed assignments, as Local variables do not necessarily
16500 operate purely on the stack as they used to: they can be captured
16503 Add `temp' for a temporary result, like fields.
16505 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16507 It now copes with Local variables that are captured and emits the
16508 proper instance variable to load it from a field in the captured
16511 (ParameterReference.DoResolveBase): During the resolve phase,
16512 capture parameters if we are in an anonymous method.
16514 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16515 anonymous method, use the EmitContext helper routines to emit the
16516 parameter reference.
16518 * iterators.cs: Set RemapToProxy to true/false during the
16521 * parameters.cs (GetParameterByName): New helper method.
16523 * typemanager.cs (anonymous_method_type) a new type that
16524 represents an anonyous method. This is always an internal type,
16525 used as a fencepost to test against the anonymous-methodness of an
16528 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16530 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16532 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16534 2004-10-18 Martin Baulig <martin@ximian.com>
16536 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16537 `Type' directly, but call ResolveType() on it.
16538 (Catch.Resolve): Likewise.
16539 (Foreach.Resolve): Likewise.
16541 2004-10-18 Martin Baulig <martin@ximian.com>
16543 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16544 `Type' directly, but call ResolveType() on it.
16545 (Probe.DoResolve): Likewise.
16546 (ArrayCreation.LookupType): Likewise.
16547 (TypeOf.DoResolve): Likewise.
16548 (SizeOf.DoResolve): Likewise.
16550 2004-10-18 Martin Baulig <martin@ximian.com>
16552 * expression.cs (Invocation.BetterFunction): Put back
16553 TypeManager.TypeToCoreType().
16555 2004-10-18 Raja R Harinath <rharinath@novell.com>
16557 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16560 2004-10-18 Martin Baulig <martin@ximian.com>
16562 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16563 `Type' directly, but call ResolveType() on it.
16565 2004-10-18 Martin Baulig <martin@ximian.com>
16567 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16568 `Type' directly, but call ResolveType() on it.
16569 (MemberBase.DoDefine): Likewise.
16571 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16572 `Type' directly, but call ResolveType() on it.
16573 (ComposedCast.DoResolveAsTypeStep): Likewise.
16575 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16576 `Type' directly, but call ResolveType() on it.
16578 2004-10-17 John Luke <john.luke@gmail.com>
16580 * class.cs (Operator.GetSignatureForError): use CSharpName
16582 * parameter.cs (Parameter.GetSignatureForError): Returns
16583 correct name even if was not defined.
16585 2004-10-13 Raja R Harinath <rharinath@novell.com>
16588 * class.cs (TypeContainer.EmitContext): New property.
16589 (DefineNestedTypes): Create an emitcontext for each part.
16590 (MethodCore.DoDefineParameters): Use container's emitcontext.
16591 Pass type array to InternalParameters.
16592 (MemberBase.DoDefine): Use container's emitcontext.
16593 (FieldMember.Define): Likewise.
16594 (Event.Define): Likewise.
16595 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16596 Pass type array to InternalParameters.
16597 (SetIndexerMethod.GetParameterInfo): Likewise.
16598 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16599 * delegate.cs (Define): Pass emitcontext to
16600 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16601 array to InternalParameters.
16602 * expression.cs (ParameterReference.DoResolveBase): Pass
16603 emitcontext to GetParameterInfo.
16604 (ComposedCast.DoResolveAsTypeStep): Remove check on
16605 ec.ResolvingTypeTree.
16606 * parameter.cs (Parameter.Resolve): Change argument to
16607 EmitContext. Use ResolveAsTypeTerminal.
16608 (Parameter.GetSignature): Change argument to EmitContext.
16609 (Parameters.ComputeSignature): Likewise.
16610 (Parameters.ComputeParameterTypes): Likewise.
16611 (Parameters.GetParameterInfo): Likewise.
16612 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16613 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16614 * support.cs (InternalParameters..ctor): Remove variant that takes
16616 * typemanager.cs (system_intptr_expr): New.
16617 (InitExpressionTypes): Initialize it.
16619 2004-10-12 Chris Toshok <toshok@ximian.com>
16621 * cs-parser.jay: fix location for try_statement and catch_clause.
16623 2004-10-11 Martin Baulig <martin@ximian.com>
16625 * report.cs: Don't make --fatal abort on warnings, we have
16626 -warnaserror for that.
16628 2004-10-07 Raja R Harinath <rharinath@novell.com>
16630 More DeclSpace.ResolveType avoidance.
16631 * decl.cs (MemberCore.InUnsafe): New property.
16632 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16633 with newly created EmitContext.
16634 (FieldMember.Define): Likewise.
16635 * delegate.cs (Delegate.Define): Likewise.
16636 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16637 only if normal name-lookup fails.
16638 (TypeExpr.DoResolve): Enable error-checking.
16639 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16640 (SizeOf.DoResolve): Likewise.
16641 (ComposedCast.DoResolveAsTypeStep): Likewise.
16642 (StackAlloc.DoResolve): Likewise.
16643 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16644 (Block.Unsafe): New property.
16645 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16646 (Unsafe): Set 'unsafe' flag of contained block.
16647 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16648 (Fixed.Resolve): Likewise.
16649 (Catch.Resolve): Likewise.
16650 (Using.ResolveLocalVariableDecls): Likewise.
16651 (Foreach.Resolve): Likewise.
16653 2004-10-05 John Luke <john.luke@gmail.com>
16655 * cs-parser.jay: add location to error CS0175
16657 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16659 * ecore.cs (Expression.Constantity): Add support for turning null
16662 * const.cs (Const.Define): Allow constants to be reference types
16663 as long as the value is Null.
16665 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16667 * namespace.cs (NamespaceEntry.Using): No matter which warning
16668 level is set, check if this namespace name has already been added.
16670 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16672 * expression.cs: reftype [!=]= null should always use br[true,false].
16675 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16678 * attribute.cs: Enum conversion moved to
16679 GetAttributeArgumentExpression to be applied to the all
16682 2004-10-01 Raja R Harinath <rharinath@novell.com>
16684 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16685 * class.c (TypeContainer.DefineType): Flag error if
16686 base types aren't accessible due to access permissions.
16687 * decl.cs (DeclSpace.ResolveType): Move logic to
16688 Expression.ResolveAsTypeTerminal.
16689 (DeclSpace.ResolveTypeExpr): Thin layer over
16690 Expression.ResolveAsTypeTerminal.
16691 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16692 Refactor code into NestedAccess. Use it.
16693 (DeclSpace.NestedAccess): New.
16694 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16695 argument to silence errors. Check access permissions.
16696 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16697 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16698 (Cast.DoResolve): Likewise.
16699 (New.DoResolve): Likewise.
16700 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16701 (TypeOf.DoResolve): Likewise.
16703 * expression.cs (Invocation.BetterConversion): Return the Type of
16704 the better conversion. Implement section 14.4.2.3 more faithfully.
16705 (Invocation.BetterFunction): Make boolean. Make correspondence to
16706 section 14.4.2.2 explicit.
16707 (Invocation.OverloadResolve): Update.
16708 (Invocation): Remove is_base field.
16709 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16710 (Invocation.Emit): Likewise.
16712 2004-09-27 Raja R Harinath <rharinath@novell.com>
16714 * README: Update to changes.
16716 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16718 * cs-parser.jay: Reverted 642 warning fix.
16720 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16723 * decl.cs (FindMemberWithSameName): Indexer can have more than
16726 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16728 * expression.cs (LocalVariableReference.DoResolveLValue):
16729 Do not report warning 219 for out values.
16730 (EmptyExpression.Null): New member to avoid extra allocations.
16732 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16734 * cs-parser.jay: Fix wrong warning 642 report.
16736 * cs-tokenizer.cs (CheckNextToken): New helper;
16737 Inspect next character if is same as expected.
16739 2004-09-23 Martin Baulig <martin@ximian.com>
16741 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16742 (Convert.ImplicitReferenceConversionExists): Likewise.
16744 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16746 * class.cs (Operator.Define): Add error 448 and 559 report.
16748 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16750 * class.cs (MemberBase.IsTypePermitted): New protected
16751 method for checking error CS0610.
16753 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16755 * class.cs (TypeContainer.HasExplicitLayout): New property
16756 Returns whether container has StructLayout attribute set Explicit.
16757 (FieldMember): New abstract class for consts and fields.
16758 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16759 (Field): Reuse FieldMember.
16761 * const.cs (Const): Reuse FieldMember.
16763 * rootcontext.cs: EmitConstants call moved to class.
16765 2004-09-22 Martin Baulig <martin@ximian.com>
16767 Thanks to Peter Sestoft for this bug report.
16769 * expression.cs (Conditional): If both the `trueExpr' and the
16770 `falseExpr' is a NullLiteral, return a NullLiteral.
16772 2004-09-22 Martin Baulig <martin@ximian.com>
16774 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16775 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16776 for the "get_Current" call.
16778 2004-09-22 Martin Baulig <martin@ximian.com>
16780 Marek and me just fixed one of our oldest bugs: #28562 :-)
16782 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16784 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16785 we're an EnumConstant, just return that.
16786 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16787 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16788 to get the value which'll actually be written into the attribute.
16789 However, we have to use GetValue() to access the attribute's value
16792 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16794 * constant.cs (Constant.IsNegative): New abstract property
16797 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16798 (StackAlloc.DoResolve): Reused IsNegative.
16800 2004-09-21 Martin Baulig <martin@ximian.com>
16802 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16803 if we're used in an iterator, we may be called from different
16806 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16807 we actually have an exception block.
16809 2004-09-20 John Luke <jluke@cfl.rr.com>
16811 * class.cs, cs-parser.jay: Improve the error report for 1520:
16812 report the actual line where the error happens, not where the
16813 class was declared.
16815 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16816 Pass location information that was available elsewhere.
16818 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16820 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16821 runtime to delay sign assemblies.
16823 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16825 * cs-parser.jay: Do not report the stack trace, this is barely
16828 2004-08-22 John Luke <john.luke@gmail.com>
16830 * driver.cs : check that a resource id is not already used
16831 before adding it, report CS1508 if it is, bug #63637
16833 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16835 * ecore.cs: Removed dead code.
16837 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16839 * class.cs: Do not report warning CS0067 on the interfaces.
16841 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16843 * cs-parser.jay: Add error 504 report.
16845 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16847 * rootcontext.cs: WarningLevel is 4 by default now.
16849 * statement.cs (Fixed.Resolve): Do not null
16852 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16855 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16856 deep search when property is not virtual.
16857 (PropertyExpr.ResolveAccessors): Make one call for both
16860 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16863 * statement.cs: Error 152 report constains also location.
16865 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16868 * const.cs: Explicitly set constant as static.
16870 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16873 * cs-parser.jay: Add error 1017 report.
16875 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16877 Fixed bug #59980, #64224
16878 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16880 * typemanager.cs (IsSpecialMethod): Simplified
16882 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16884 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16885 condition with better params.
16887 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16890 * attribute.cs (Resolve): Property has to have both
16893 2004-09-14 Martin Baulig <martin@ximian.com>
16895 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16897 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16900 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16901 called and is obsolete then this member suppress message
16902 when call is inside next [Obsolete] method or type.
16904 * expression.cs: Use TestObsoleteMethodUsage member.
16906 2004-09-14 Martin Baulig <martin@ximian.com>
16908 * cs-parser.jay: Sync a bit with the GMCS version.
16910 2004-09-14 Martin Baulig <martin@ximian.com>
16912 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16913 (CSharpParser.yacc_verbose_flag): New public field.
16915 * genericparser.cs: Removed.
16917 2004-09-14 Raja R Harinath <rharinath@novell.com>
16919 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16921 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16923 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16925 2004-09-10 Martin Baulig <martin@ximian.com>
16927 Backported my MemberName changes from GMCS into MCS.
16929 - we are now using a special `MemberName' class instead of using
16930 strings; in GMCS, the `MemberName' also contains the type
16933 - changed the grammar rules a bit:
16934 * the old `member_name' is now a `namespace_or_type_name':
16935 The rule is that we use `namespace_or_type_name' everywhere
16936 where we expect either a "member name" (GetEnumerator) or a
16937 "member name" with an explicit interface name
16938 (IEnumerable.GetEnumerator).
16939 In GMCS, the explicit interface name may include type arguments
16940 (IEnumerable<T>.GetEnumerator).
16941 * we use `member_name' instead of just `IDENTIFIER' for
16943 The rule is that we use `member_name' wherever a member may
16944 have type parameters in GMCS.
16946 * decl.cs (MemberName): New public class.
16947 (MemberCore.MemberName): New public readonly field.
16948 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16949 (DeclSpace): Likewise.
16951 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16952 * enum.cs (Enum.ctor): Likewise.
16954 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16956 (AliasEntry.ctor): Take a MemberName, not an Expression.
16957 (AliasEntry.UsingAlias): Likewise.
16959 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16960 (IMethodData.MemberName): Changed type from string to MemberName.
16961 (MemberBase.ExplicitInterfaceName): Likewise.
16962 (AbstractPropertyEventMethod.SetupName): Make this private.
16963 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16964 argument; compute the member name here.
16965 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16966 on the `member.MemberName' and the `prefix'.
16968 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16970 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16971 thus, we get a `MemberName' instead of a `string'. These
16972 declarations may have type parameters in GMCS.
16973 (interface_method_declaration, delegate_declaration): Likewise.
16974 (class_declaration, interface_declaration): Likewise.
16975 (method_header): Use `namespace_or_type_name' instead of
16976 `member_name'. We may be an explicit interface implementation.
16977 (property_declaration, event_declaration): Likewise.
16978 (member_name): This is now just an `IDENTIFIER', not a
16979 `namespace_or_type_name'.
16980 (type_name, interface_type): Removed.
16981 (namespace_or_type_name): Return a MemberName, not an Expression.
16982 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16983 call GetTypeExpression() on the MemberName to get an expression.
16984 (IndexerDeclaration.interface_type): Changed type from string to
16986 (MakeName): Operate on MemberName's instead of string's.
16988 2004-09-13 Raja R Harinath <rharinath@novell.com>
16991 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16992 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16993 lookup to avoid symbols introduced by 'using'.
16994 * rootcontext.cs (NamespaceLookup): Update.
16996 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16998 * class.cs (TypeContainer.DoDefineMembers): Do not call
16999 DefineDefaultConstructor for static classes.
17001 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17003 * attribute.cs (Attribute.Resolve): Add error 653 report.
17005 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17007 (Method.ApplyAttributeBuilder): Add error 685 report.
17008 (Operator.Define): Add error 564 report.
17010 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17012 * expression.cs (Invocation.DoResolve): Add error
17013 245 and 250 report.
17015 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17018 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17020 * class.cs (ConstructorInitializer.Resolve):
17021 Wrong error number (515->516).
17023 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17025 * class.cs (Indexer.Define): Add error 631 report.
17027 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17029 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17031 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17033 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17035 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17037 * cs-parser.jay: Added error CS0241 report.
17039 2004-09-10 Raja R Harinath <rharinath@novell.com>
17041 * cs-parser.jay (fixed_statement): Introduce a scope for the
17042 declaration in the 'fixed' statement.
17044 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17046 * cs-parser.jay: Added CS0230 error report.
17048 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17050 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17052 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17054 * expression.cs (Argument.Resolve): Added error CS0192 and
17057 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17059 C# 2.0 #pragma warning feature
17061 * cs-tokenizer.cs (PreProcessPragma): New method;
17062 Handles #pragma directive.
17064 * report.cs (WarningRegions): New class; Support
17065 class for #pragma warning directive. It tests whether
17066 warning is enabled for a given line.
17068 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17070 * const.cs: Add more descriptive error report, tahnks to
17073 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17075 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17077 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17079 * expression.cs: Apply patch from Ben: Remove dead code from
17080 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17081 as that code just threw an exception anwyays.
17083 * const.cs: Remove the call to the turnintoconstant, for details
17086 * literal.cs: The type of the null-literal is the null type; So
17087 we use a placeholder type (literal.cs:System.Null, defined here)
17090 * expression.cs (Conditional.DoResolve): Remove some old code that
17091 is no longer needed, conversions have been fixed.
17093 (ArrayCreationExpression.DoResolve): Return false if we fail to
17094 resolve the inner expression.
17096 2004-09-07 Raja R Harinath <rharinath@novell.com>
17099 * cs-parser.jay (delegate_declaration): Record a delegate
17100 declaration as a type declaration.
17101 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17103 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17105 * parameter.cs: Do not crash if the type can not be resolved.
17107 * expression.cs: Report errors with unsafe pointers, fixes #64896
17109 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17111 * expression.cs: Pointer arith always needs to do a conv.i
17112 if the operand is a long. fix 65320
17114 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17116 Fixed cs0619-37.cs, cs0619-38.cs
17118 * enum.cs (GetObsoleteAttribute): Removed.
17120 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17121 on Enum member is double staged. The first is tested member
17124 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17126 Fixed #56986, #63631, #65231
17128 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17129 adds member to name container.
17130 (TypeContainer.AddToTypeContainer): New method, adds type to
17132 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17133 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17134 AddOperator): Simplified by reusing AddToMemberContainer.
17135 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17137 (Method.CheckForDuplications): Fixed implementation to test all
17139 (MemberBase): Detection whether member is explicit interface
17140 implementation is now in constructor.
17141 (MemberBase.UpdateMemberName): Handles IndexerName.
17142 (Accessor): Changed to keep also location information.
17143 (AbstractPropertyEventMethod): Is derived from MemberCore.
17144 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17145 will be emited or not.
17146 (PropertyBase.AreAccessorsDuplicateImplementation):
17147 Tests whether accessors are not in collision with some method.
17148 (Operator): Is derived from MethodCore to simplify common
17151 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17153 (DeclSpace.AddToContainer): Adds the member to defined_names
17154 table. It tests for duplications and enclosing name conflicts.
17156 * enum.cs (EnumMember): Clean up to reuse the base structures
17158 2004-09-03 Martin Baulig <martin@ximian.com>
17160 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17161 into TypeContainer, to make partial classes work again.
17163 2004-09-03 Martin Baulig <martin@ximian.com>
17165 * rootcontext.cs (RootContext.V2): Removed.
17167 2004-03-23 Martin Baulig <martin@ximian.com>
17169 * expression.cs (Invocation.OverloadResolve): Added `bool
17170 may_fail' argument and use it instead of the Location.IsNull() hack.
17172 2004-09-03 Martin Baulig <martin@ximian.com>
17174 Merged latest changes into gmcs. Please keep this comment in
17175 here, it makes it easier for me to see what changed in MCS since
17176 the last time I merged.
17178 2004-09-03 Raja R Harinath <rharinath@novell.com>
17181 * expression.cs (BetterConversion): Don't allow either conversion
17182 to be null. Remove redundant implicit conversion test when 'q ==
17183 null' -- when this function is invoked, we already know that the
17184 implicit conversion exists.
17185 (BetterFunction): Assume that 'best' is non-null. Remove
17186 redundant reimplementation of IsApplicable when 'best' is null.
17187 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17188 number of arguments.
17189 (IsAncestralType): Extract from OverloadResolve.
17190 (OverloadResolve): Make robust to the MethodGroupExpr being
17191 unsorted. Implement all the logic of Section 14.5.5.1, and
17192 support overloading of methods from multiple applicable types.
17193 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17195 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17196 (RealError, Warning): Append type of report to related symbol.
17198 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17200 * enum.cs: Fixed CLS-Compliance checks for enum members.
17201 Error tests cs3008-8.cs, cs3014-8.cs
17203 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17205 Fixed bug #62342, #63102
17206 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17207 like ImplementMethod.
17209 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17211 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17214 2004-09-02 Martin Baulig <martin@ximian.com>
17216 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17217 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17220 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17222 C# 2.0 Static classes implemented
17224 * class.cs (TypeContainer): instance_constructors,
17225 initialized_fields, initialized_static_fields,
17226 default_constructor, base_inteface_types are protected to be
17227 accessible from StaticClass.
17228 (TypeContainer.DefineDefaultConstructor): New virtual method
17229 for custom default constructor generating
17230 (StaticClass): New class to handle "Static classes" feature.
17232 * cs-parser.jay: Handle static keyword on class like instance
17235 * driver.cs: Added "/langversion" command line switch with two
17236 options (iso-1, default).
17238 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17240 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17242 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17244 * delegate.cs: Style.
17246 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17248 * delegate.cs: Add seperate instance expr field for miguel.
17250 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17252 * PointerArithmetic (Resolve): make sure we are not doing
17253 pointer arith on void*. Also, make sure we are resolved
17254 by not setting eclass until resolve.
17256 All callers: Make sure that PointerArithmetic gets resolved.
17258 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17260 * ArrayCreation (LookupType): If the type does not resolve
17261 to an array, give an error.
17263 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17265 * statement.cs (Try.Resolve): Fixed bug #64222
17267 2004-08-27 Martin Baulig <martin@ximian.com>
17270 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17273 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17275 * ecore.cs (Constantify): Get underlying type via
17276 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17277 Windows in special cases.
17279 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17281 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17282 for obtaining also private methods.
17283 (GetRemoveMethod): Used GetRemoveMethod (true)
17284 for obtaining also private methods.
17286 2004-08-24 Martin Baulig <martin@ximian.com>
17288 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17289 MethodAttributes.HideBySig for operators.
17291 2004-08-23 Martin Baulig <martin@ximian.com>
17293 Back to the old error reporting system :-)
17295 * report.cs (Message): Removed.
17296 (Report.MessageData, ErrorData, WarningData): Removed.
17297 (Report.Error, Warning): Back to the old system.
17299 2004-08-23 Martin Baulig <martin@ximian.com>
17301 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17303 * class.cs (TypeContainer.ParentContainer): New public virtual
17304 method; replaces the explicit interface implementation.
17305 (ClassPart.ParentContainer): Override.
17307 2004-08-23 Martin Baulig <martin@ximian.com>
17309 * statement.cs (Switch): Added support for constant switches; see
17310 #59428 or test-285.cs.
17312 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17315 * statement.cs (GetEnumeratorFilter): Removed useless
17316 logic because C# specs is strict. GetEnumerator must be
17319 2004-08-22 Martin Baulig <martin@ximian.com>
17321 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17322 a switch and may break, reset the barrier. Fixes #59867.
17324 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17326 CLS-Compliance speed up (~5% for corlib)
17328 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17329 New method. Tests container for CLS-Compliant names
17331 * class.cs (TypeContainer.VerifyClsName): New method.
17332 Checks whether container name is CLS Compliant.
17333 (Constructor): Implements IMethodData.
17335 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17336 low-case table for CLS Compliance test.
17337 (MemberCache.VerifyClsParameterConflict): New method.
17338 Checks method parameters for CS3006 error.
17340 * enum.cs (EnumMember): Is derived from MemberCore.
17341 (Enum.VerifyClsName): Optimized for better performance.
17343 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17345 * report.cs: Renamed Error_T to Error and changed all
17348 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17350 * class.cs (TypeContainer.IndexerArrayList): New inner class
17351 container for indexers.
17352 (TypeContainer.DefaultIndexerName): New constant for default
17353 indexer name. Replaced all "Item" with this constant.
17354 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17356 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17357 DefaultMemberAttribute constructor.
17359 2004-08-05 Martin Baulig <martin@ximian.com>
17361 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17364 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17366 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17367 multi platforms problem.
17369 * compiler.csproj: Included shared files.
17371 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17373 Fix bug 60333, 55971 in the more general way
17374 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17375 Added arg_type argument for constant conversion.
17376 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17378 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17381 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17382 OperatorArrayList, MethodCoreArrayList for typecontainer
17383 containers. Changed class member types to these new types.
17384 (MethodArrayList.DefineMembers): Added test for CS0659.
17386 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17388 * cfold.cs: Synchronize the folding with the code in expression.cs
17389 Binary.DoNumericPromotions for uint operands.
17391 * attribute.cs: Revert patch from Raja, it introduced a regression
17392 while building Blam-1.2.1 (hard to isolate a test case).
17394 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17398 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17400 (MethodCore.parent_method): New member. The method we're overriding
17401 if this is an override method.
17402 (MethodCore.CheckBase): Moved from Method class and made common.
17403 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17405 (MethodCore.CheckForDuplications): New abstract method. For custom
17406 member duplication search in a container
17407 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17408 method and its return type.
17409 (Event.conflict_symbol): New member. Symbol with same name in the
17413 (MemberCache.FindMemberWithSameName): New method. The method
17414 is looking for conflict with inherited symbols.
17416 2004-08-04 Martin Baulig <martin@ximian.com>
17418 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17420 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17422 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17424 * report.cs (Message): New enum for better error, warning reference in
17426 (MessageData): New inner abstract class. It generally handles printing of
17427 error and warning messages.
17428 Removed unused Error, Warning, Message methods.
17430 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17432 Fix for cs0592-8.cs test
17434 (Attributable.ValidAttributeTargets): Made public.
17435 (Attribute.ExplicitTarget): New member for explicit target value.
17436 (Attribute.CheckTargets): Now we translate explicit attribute
17437 target to Target here.
17439 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17441 * ecore.cs (MethodGroupExpr): new IsBase property.
17443 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17445 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17446 rather than an instance expr.
17448 (DelegateCreation.Emit): Use the method group rather than
17449 the instance expression. Also, if you have base.Foo as the
17450 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17452 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17454 (NewDelegate.DoResolve): Only check for the existance of Invoke
17455 if the method is going to be needed. Use MethodGroupExpr.
17457 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17459 * expression.cs: For pointer arith., make sure to use
17460 the size of the type, not the size of the pointer to
17463 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17466 * class.cs (Class): Added error CS0502 test.
17468 2004-08-03 John Luke <jluke@cfl.rr.com>
17469 Raja R Harinath <rharinath@novell.com>
17472 * attribute.cs (Attribute.complained_before): New flag.
17473 (Attribute.ResolveType, Attribute.Resolve),
17474 (Attribute.DefinePInvokeMethod): Set it.
17475 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17477 2004-08-03 Martin Baulig <martin@ximian.com>
17479 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17480 use a user-defined operator; we still need to do numeric
17481 promotions in case one argument is a builtin type and the other
17482 one has an implicit conversion to that type. Fixes #62322.
17484 2004-08-02 Martin Baulig <martin@ximian.com>
17486 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17487 (LocalInfo.IsThis): New public property.
17488 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17490 2004-08-01 Martin Baulig <martin@ximian.com>
17492 * class.cs (TypeContainer.GetClassBases): Don't set the default
17493 here since we may get called from GetPartialBases().
17494 (TypeContainer.DefineType): If GetClassBases() didn't return a
17495 parent, use the default one.
17497 2004-07-30 Duncan Mak <duncan@ximian.com>
17499 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17501 2004-07-30 Martin Baulig <martin@ximian.com>
17503 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17505 * class.cs (SourceMethod): New public class, derive from the
17506 symbol writer's ISourceMethod.
17507 (Method): Use the new symbol writer API.
17509 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17510 as argument and use the new symbol writer.
17513 (SourceFile): Implement the symbol writer's ISourceFile.
17514 (Location.SymbolDocument): Removed.
17515 (Location.SourceFile): New public property.
17517 * symbolwriter.cs: Use the new symbol writer API.
17519 2004-07-30 Raja R Harinath <rharinath@novell.com>
17521 * Makefile (install-local): Remove. Functionality moved to
17524 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17526 * Makefile: Install mcs.exe.config file together with mcs.exe.
17527 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17528 correct runtime version.
17530 2004-07-25 Martin Baulig <martin@ximian.com>
17533 (TypeContainer.RegisterOrder): Removed, this was unused.
17534 (TypeContainer, interface_order): Removed.
17535 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17536 TypeContainer as argument since we can also be called with a
17537 `PartialContainer' for a partial class/struct/interface.
17538 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17539 of checking whether we're an `Interface' - we could be a
17540 `PartialContainer'.
17541 (PartialContainer.Register): Override; call
17542 AddClass()/AddStruct()/AddInterface() on our parent.
17544 * cs-parser.jay (interface_member_declaration): Add things to the
17545 `current_container', not the `current_class'.
17547 * rootcontext.cs (RegisterOrder): The overloaded version which
17548 takes an `Interface' was unused, removed.
17550 * typemanager.cs (TypeManager.LookupInterface): Return a
17551 `TypeContainer', not an `Interface'.
17552 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17553 contain a `PartialContainer' for an interface, so check it's
17554 `Kind' to figure out what it is.
17556 2004-07-25 Martin Baulig <martin@ximian.com>
17558 * class.cs (Class.DefaultTypeAttributes): New public constant.
17559 (Struct.DefaultTypeAttributes): Likewise.
17560 (Interface.DefaultTypeAttributes): Likewise.
17561 (PartialContainer.TypeAttr): Override this and add the
17562 DefaultTypeAttributes.
17564 2004-07-25 Martin Baulig <martin@ximian.com>
17566 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17567 we can just use the `Parent' field instead.
17569 2004-07-25 Martin Baulig <martin@ximian.com>
17571 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17573 2004-07-25 Martin Baulig <martin@ximian.com>
17575 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17576 our parts before defining any methods.
17577 (TypeContainer.VerifyImplements): Make this virtual.
17578 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17579 on our PartialContainer.
17581 2004-07-25 Martin Baulig <martin@ximian.com>
17583 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17585 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17586 argument, we can just use the `Parent' field instead.
17589 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17590 (MemberBase.DoDefine): Likewise.
17592 2004-07-24 Martin Baulig <martin@ximian.com>
17594 * decl.cs (MemberCore.Parent): New public field.
17595 (DeclSpace.Parent): Moved to MemberCore.
17597 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17598 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17600 (FieldBase, Field, Operator): Likewise.
17601 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17602 (EventField, Event): Likewise.
17604 2004-07-23 Martin Baulig <martin@ximian.com>
17606 * class.cs (PartialContainer): New public class.
17607 (ClassPart): New public class.
17608 (TypeContainer): Added support for partial classes.
17609 (TypeContainer.GetClassBases): Splitted some of the functionality
17610 out into GetNormalBases() and GetPartialBases().
17612 * cs-tokenizer.cs (Token.PARTIAL): New token.
17613 (Tokenizer.consume_identifier): Added some hacks to recognize
17614 `partial', but only if it's immediately followed by `class',
17615 `struct' or `interface'.
17617 * cs-parser.jay: Added support for partial clases.
17619 2004-07-23 Martin Baulig <martin@ximian.com>
17621 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17622 a `DeclSpace' and also made it readonly.
17623 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17624 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17625 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17627 * cs-parser.jay: Pass the `current_class', not the
17628 `current_container' (at the moment, this is still the same thing)
17629 to a new Method, Property, Event, Indexer or Constructor.
17631 2004-07-23 Martin Baulig <martin@ximian.com>
17633 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17634 and removed the `current_interface' one.
17635 (struct_declaration, class_declaration, interface_declaration):
17636 Set `current_class' to the newly created class/struct/interface;
17637 set their `Bases' and call Register() before parsing their body.
17639 2004-07-23 Martin Baulig <martin@ximian.com>
17641 * class.cs (Kind): New public enum.
17642 (TypeContainer): Made this class abstract.
17643 (TypeContainer.Kind): New public readonly field.
17644 (TypeContainer.CheckDef): New public method; moved here from
17646 (TypeContainer.Register): New public abstract method.
17647 (TypeContainer.GetPendingImplementations): New public abstract
17649 (TypeContainer.GetClassBases): Removed the `is_class' and
17650 `is_iface' parameters.
17651 (TypeContainer.DefineNestedTypes): Formerly known as
17653 (ClassOrStruct): Made this class abstract.
17655 * tree.cs (RootTypes): New public type.
17657 2004-07-20 Martin Baulig <martin@ximian.com>
17659 * tree.cs (Tree.RecordNamespace): Removed.
17660 (Tree.Namespaces): Removed.
17662 * rootcontext.cs (RootContext.IsNamespace): Removed.
17664 * cs-parser.jay (namespace_declaration): Just create a new
17665 NamespaceEntry here.
17667 2004-07-20 Martin Baulig <martin@ximian.com>
17669 * statement.cs (ExceptionStatement): New abstract class. This is
17670 now used as a base class for everyone who's using `finally'.
17671 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17672 our local variables before using them.
17674 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17675 virtual method. This is used by Yield.Resolve() to "steal" an
17676 outer block's `finally' clauses.
17677 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17680 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17681 version which takes an ExceptionStatement. This version must be
17682 used to create exception branchings.
17685 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17686 (Iterator.EmitMoveNext): Added exception support; protect the
17687 block with a `fault' clause, properly handle 'finally' clauses.
17688 (Iterator.EmitDispose): Run all the `finally' clauses here.
17690 2004-07-20 Martin Baulig <martin@ximian.com>
17692 * iterator.cs: This is the first of a set of changes in the
17693 iterator code. Match the spec more closely: if we're an
17694 IEnumerable, then GetEnumerator() must be called. The first time
17695 GetEnumerator() is called, it returns the current instance; all
17696 subsequent invocations (if any) must create a copy.
17698 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17700 * expression.cs: Resolve the constant expression before returning
17703 2004-07-19 Martin Baulig <martin@ximian.com>
17705 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17706 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17707 the return type of the new EmitContext.
17709 2004-07-18 Martin Baulig <martin@ximian.com>
17711 * class.cs (Property.Define): Fix iterators.
17713 * iterators.cs (Iterator.Define): Moved the
17714 `container.AddInterator (this)' call here from the .ctor; only do
17715 it if we resolved successfully.
17717 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17719 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17720 `true' for preprocessing directives that we parse. The return
17721 value indicates whether we should return to regular tokenizing or
17722 not, not whether it was parsed successfully.
17724 In the past if we were in: #if false ... #line #endif, we would
17725 resume parsing after `#line'. See bug 61604.
17727 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17728 building: IsEnumType should return true only for enums, not for
17729 enums or System.Enum itself. This fixes #61593.
17731 Likely what happened is that corlib was wrong: mcs depended on
17732 this bug in some places. The bug got fixed, we had to add the
17733 hack, which caused bug 61593.
17735 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17736 that was a workaround for the older conditions.
17738 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17740 * assign.cs: IAssignMethod has a new interface, as documented
17741 inline. All assignment code now uses this new api.
17743 * ecore.cs, expression.cs: All classes which implement
17744 IAssignMethod now use the new interface.
17746 * expression.cs (Invocation): add a hack to EmitCall so that
17747 IndexerAccess can be the target of a compound assignment without
17748 evaluating its arguments twice.
17750 * statement.cs: Handle changes in Invocation api.
17752 2004-07-16 Martin Baulig <martin@ximian.com>
17754 * iterators.cs: Rewrote this. We're now using one single Proxy
17755 class for both the IEnumerable and the IEnumerator interface and
17756 `Iterator' derives from Class so we can use the high-level API.
17758 * class.cs (TypeContainer.AddIterator): New method.
17759 (TypeContainer.DoDefineType): New protected virtual method, which
17760 is called from DefineType().
17761 (TypeContainer.DoDefineMembers): Call DefineType() and
17762 DefineMembers() on all our iterators.
17763 (TypeContainer.Emit): Call Emit() on all our iterators.
17764 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17766 * codegen.cs (EmitContext.CurrentIterator): New public field.
17768 2004-07-15 Martin Baulig <martin@ximian.com>
17771 (TypeManager.not_supported_exception_type): New type.
17773 2004-07-14 Martin Baulig <martin@ximian.com>
17775 * iterators.cs: Use real error numbers.
17777 2004-07-14 Martin Baulig <martin@ximian.com>
17779 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17780 requires this to be a System.Collection.IEnumerable and not a
17781 class implementing that interface.
17782 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17784 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17786 * class.cs: Fixed previous fix, it broke some error tests.
17788 2004-07-12 Martin Baulig <martin@ximian.com>
17790 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17793 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17795 * assign.cs (LocalTemporary): Add new argument: is_address,If
17796 `is_address' is true, then the value that we store is the address
17797 to the real value, and not the value itself.
17799 * ecore.cs (PropertyExpr): use the new local temporary
17800 stuff to allow us to handle X.Y += z (where X is a struct)
17802 2004-07-08 Martin Baulig <martin@ximian.com>
17804 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17805 not always return, just like we're doing in Using.Resolve().
17807 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17809 * cs-parser.jay (fixed_statement): flag this as Pinned.
17811 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17813 * typemanager.cs (TypeManager): Removed MakePinned method, this
17814 mechanism is replaced with the .NET 2.x compatible mechanism of
17815 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17817 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17818 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17819 `IsFixed' property which has a different meaning.
17821 2004-07-02 Raja R Harinath <rharinath@novell.com>
17823 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17824 visible from inside a nested class, not just the names of the
17825 immediately enclosing class.
17826 Fix for bug #60730.
17828 2004-06-24 Raja R Harinath <rharinath@novell.com>
17830 * expression.cs (BetterConversion): Remove buggy special-case
17831 handling of "implicit constant expression conversions". At this
17832 point, we already know that the conversion is possible -- we're
17833 only checking to see which is better.
17835 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17837 * cs-parser.jay: Added error CS0210 test.
17839 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17841 * cs-parser.jay: Added error CS0134 test.
17843 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17846 * cs-parser.jay: Added error CS0145 test.
17848 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17850 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17852 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17854 * expression.cs (StackAlloc.Resolve): The argument may not
17855 be a constant; deal with this case.
17857 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17859 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17860 GetIndexerAttributeValue.
17861 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17863 * class.cs (Indexer.Define): Added error tests for CS0415,
17866 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17868 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17871 2004-06-23 Martin Baulig <martin@ximian.com>
17873 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17874 neither return nor throw, reset the barrier as well. Fixes #60457.
17876 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17878 * class.cs : EventAttributes is now set to None by default.
17879 This fixes bug #60459.
17881 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17884 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17885 Don't throw exception but return null (it's sufficient now).
17887 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17889 * typemanager.cs (GetArgumentTypes): Faster implementation.
17891 2004-06-18 Martin Baulig <martin@ximian.com>
17893 * attribute.cs (Attribute.Resolve): Check whether we're an
17894 EmptyCast which a Constant child. Fixes #60333.
17896 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17898 * statement.cs (EmitCollectionForeach): Account for the fact that
17899 not all valuetypes are in areas which we can take the address of.
17900 For these variables, we store to a temporary variable. Also, make
17901 sure that we dont emit a `callvirt' on a valuetype method.
17903 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17905 * expression.cs (StackAlloc.DoReSolve): Added test for
17906 negative parameter (CS0247).
17908 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17911 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17913 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17916 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17919 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17921 Fix bug #58254 & cs1555.cs, cs1556.cs
17922 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17924 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17926 * cs-parser.jay: Added error CS1669 test for indexers.
17928 2004-06-11 Martin Baulig <martin@ximian.com>
17930 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17931 call this twice: for params and varargs methods.
17933 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17936 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17938 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17940 * attribute.cs (Attribute.GetValidTargets): Made public.
17943 (AbstractPropertyEventMethod): New class for better code sharing.
17944 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17946 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17948 2004-06-11 Raja R Harinath <rharinath@novell.com>
17951 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17952 that the call to Resolve is part of a MemberAccess.
17953 (Expression.Resolve): Use it for SimpleName resolution.
17954 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17955 Add 'intermediate' boolean argument.
17956 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17957 error message when the SimpleName can be resolved ambiguously
17958 between an expression and a type.
17959 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17961 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17962 call on the left-side.
17964 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17967 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17969 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17971 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17973 2004-06-11 Martin Baulig <martin@ximian.com>
17975 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17976 varargs methods if applicable.
17978 2004-06-11 Martin Baulig <martin@ximian.com>
17980 * expression.cs (Invocation.EmitCall): Don't use
17981 `method.CallingConvention == CallingConventions.VarArgs' since the
17982 method could also have `CallingConventions.HasThis'.
17984 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17986 * class.cs (Event.GetSignatureForError): Implemented.
17987 Fixed crash in error test cs3010.cs
17989 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17991 * cs-tokenizer.cs: Change the way we track __arglist to be
17992 consistent with the other keywords.
17994 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17996 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17999 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18001 * codegen.cs: Check that all referenced assemblies have a strongname
18002 before strongnaming the compiled assembly. If not report error CS1577.
18003 Fix bug #56563. Patch by Jackson Harper.
18004 * typemanager.cs: Added a method to return all referenced assemblies.
18005 Fix bug #56563. Patch by Jackson Harper.
18007 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18010 (Method.ApplyAttributeBuilder): Moved and added conditional
18011 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18014 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18016 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18019 * class.cs: (EventField.attribute_targets): Changed default target.
18021 2004-06-08 Martin Baulig <martin@ximian.com>
18023 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18025 2004-06-08 Martin Baulig <martin@ximian.com>
18027 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18029 2004-06-07 Martin Baulig <martin@ximian.com>
18031 Added support for varargs methods.
18033 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18036 * cs-parser.jay: Added support for `__arglist'.
18038 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18040 * expression.cs (Argument.AType): Added `ArgList'.
18041 (Invocation): Added support for varargs methods.
18042 (ArglistAccess): New public class.
18043 (Arglist): New public class.
18045 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18047 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18048 a method's top-level block if the method has varargs.
18050 * support.cs (ReflectionParameters, InternalParameters): Added
18051 support for varargs methods.
18053 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18055 * class.cs: Provide location in indexer error report.
18057 * driver.cs: Use standard names.
18059 * namespace.cs: Catch the use of using after a namespace has been
18060 declared also on using aliases.
18062 2004-06-03 Raja R Harinath <rharinath@novell.com>
18065 * typemanager.cs (closure_private_ok, closure_invocation_type)
18066 (closure_qualifier_type, closure_invocation_assembly)
18067 (FilterWithClosure): Move to ...
18068 (Closure): New internal nested class.
18069 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18070 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18071 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18072 (MemberLookup, MemberLookupFailed): Use it.
18073 * expression.cs (New.DoResolve): Treat the lookup for the
18074 constructor as being qualified by the 'new'ed type.
18075 (Indexers.GetIndexersForTypeOrInterface): Update.
18077 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18080 (GetConditionalAttributeValue): New method. Returns
18081 condition of ConditionalAttribute.
18082 (SearchMulti): New method. Returns all attributes of type 't'.
18083 Use it when attribute is AllowMultiple = true.
18084 (IsConditionalMethodExcluded): New method.
18087 (Method.IsExcluded): Implemented. Returns true if method has conditional
18088 attribute and the conditions is not defined (method is excluded).
18089 (IMethodData): Extended interface for ConditionalAttribute support.
18090 (PropertyMethod.IsExcluded): Implemented.
18093 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18096 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18099 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18101 * expression.cs (ArrayCreationExpression): Make this just an
18102 `expression'. It can't be a statement, so the code here was
18105 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18108 * typemanager.cs (GetFullNameSignature): New method for
18111 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18114 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18115 Use this method when MethodBuilder is null.
18116 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18117 Added test for error CS0626 (MONO reports error for this situation).
18118 (IMethodData.GetSignatureForError): Extended interface.
18120 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18123 (AttributeTester.GetObsoleteAttribute): Returns instance of
18124 ObsoleteAttribute when type is obsolete.
18127 (TypeContainer.VerifyObsoleteAttribute): Override.
18128 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18129 (MethodCode.VerifyObsoleteAttribute): Override.
18130 (MemberBase.VerifyObsoleteAttribute): Override.
18133 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18134 and report proper error.
18137 Delegate.VerifyObsoleteAttribute): Override.
18140 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18141 and report proper error.
18142 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18145 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18149 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18150 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18151 Added test for ObsoleteAttribute.
18154 (Catch): Derived from Statement.
18156 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18158 Fixed bug #59071 & cs0160.cs
18160 * statement.cs (Try.Resolve): Check here whether order of catch
18161 clauses matches their dependencies.
18163 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18165 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18166 caused a regression: #59343. Referencing nested classes from an
18167 assembly stopped working.
18169 2004-05-31 Martin Baulig <martin@ximian.com>
18171 MCS is now frozen for beta 2.
18173 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18175 * convert.cs: add a trivial cache for overload operator resolution.
18177 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18179 * decl.cs: If possible, use lookuptypedirect here. We can only do
18180 this if there is no `.' after the namespace. Avoids using
18181 LookupType, which does lots of slow processing.
18182 (FindNestedType) New method, does what it says :-).
18183 * namespace.cs: use LookupTypeDirect.
18184 * rootcontext.cs: use membercache, if possible.
18185 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18187 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18190 According to the spec,
18192 In a member access of the form E.I, if E is a single identifier,
18193 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18194 field, property, localvariable, or parameter with the same type as
18195 the meaning of E as a type-name (§3.8), then both possible
18196 meanings of E are permitted.
18198 We did not check that E as a simple-name had the same type as E as
18201 This trivial check gives us 5-7% on bootstrap time.
18203 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18205 * expression.cs (Invocation.OverloadResolve): Avoid the
18206 use of hashtables and boxing here by allocating on demand.
18208 2004-05-30 Martin Baulig <martin@ximian.com>
18210 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18211 we're doing a silent lookup. Don't try to lookup nested types in
18212 TypeManager.object_type (thanks to Ben Maurer).
18214 2004-05-30 Martin Baulig <martin@ximian.com>
18216 Committing a patch from Ben Maurer.
18218 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18220 2004-05-29 Martin Baulig <martin@ximian.com>
18222 * class.cs (IMethodData.ShouldIgnore): New method.
18224 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18225 `Location' argument, we don't need it anywhere. Use
18226 `IMethodData.ShouldIgnore ()' instead of
18227 `MethodData.GetMethodFlags ()'.
18228 (TypeManager.AddMethod): Removed.
18229 (TypeManager.AddMethod2): Renamed to AddMethod.
18231 2004-05-29 Martin Baulig <martin@ximian.com>
18233 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18235 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18236 converting from a class type S to an interface type and we already
18237 have an object on the stack, don't box it again. Fixes #52578.
18239 2004-05-29 Martin Baulig <martin@ximian.com>
18241 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18242 Added support for `params' parameters. Fixes #59267.
18244 2004-05-29 Martin Baulig <martin@ximian.com>
18246 * literal.cs (NullPointer): Provide a private .ctor which sets
18247 `type' to TypeManager.object_type. Fixes #59048.
18249 2004-05-29 Martin Baulig <martin@ximian.com>
18251 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18252 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18254 * ecore.cs (EventExpr.instance_expr): Make the field private.
18256 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18258 Fixed bug #50080 & cs0214-2.cs
18259 * expression.cs (Cast.DoResolve): Check unsafe context here.
18261 * statement.cs (Resolve.DoResolve): Likewise.
18263 2004-05-26 Martin Baulig <martin@ximian.com>
18265 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18267 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18268 (RootContext.LookupType): Pass down the `silent' flag.
18270 2004-05-25 Martin Baulig <martin@ximian.com>
18273 (MethodGroupExpr.IdenticalTypeName): New public property.
18274 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18275 expression actually refers to a type.
18277 2004-05-25 Martin Baulig <martin@ximian.com>
18279 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18280 for #56176 and made it actually work.
18282 2004-05-25 Martin Baulig <martin@ximian.com>
18284 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18285 (FieldExpr, PropertyExpr): Override and implement
18286 CacheTemporaries. Fixes #52279.
18288 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18290 * location.cs: In the new compiler listing a file twice is a
18291 warning, not an error.
18293 2004-05-24 Martin Baulig <martin@ximian.com>
18295 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18296 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18298 2004-05-24 Martin Baulig <martin@ximian.com>
18300 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18301 walking the `using' list. Fixes #53921.
18303 2004-05-24 Martin Baulig <martin@ximian.com>
18305 * const.cs (Const.LookupConstantValue): Added support for
18306 EmptyCast's; fixes #55251.
18308 2004-05-24 Martin Baulig <martin@ximian.com>
18310 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18311 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18312 which does the CS0135 check. The reason is that we first need to
18313 check whether the variable actually exists.
18315 2004-05-24 Martin Baulig <martin@ximian.com>
18317 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18318 than RootContext.LookupType() to find the explicit interface
18319 type. Fixes #58584.
18321 2004-05-24 Raja R Harinath <rharinath@novell.com>
18323 * Makefile: Simplify. Use executable.make.
18324 * mcs.exe.sources: New file. List of sources of mcs.exe.
18326 2004-05-24 Anders Carlsson <andersca@gnome.org>
18330 Use the invariant culture when doing String.Compare for CLS case
18333 2004-05-23 Martin Baulig <martin@ximian.com>
18335 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18336 don't have any dots. Fixes #52622, added cs0246-8.cs.
18338 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18340 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18342 * class.cs (MemberBase.Define): Reuse MemberType member for
18343 resolved type. Other methods can use it too.
18345 2004-05-23 Martin Baulig <martin@ximian.com>
18347 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18348 the variable also exists in the current block (otherwise, we need
18349 to report a CS0103). Fixes #58670.
18351 2004-05-23 Martin Baulig <martin@ximian.com>
18353 * flowanalysis.cs (Reachability.Reachable): Compute this
18354 on-the-fly rather than storing it as a field.
18356 2004-05-23 Martin Baulig <martin@ximian.com>
18358 * flowanalysis.cs (Reachability.And): Manually compute the
18359 resulting `barrier' from the reachability.
18361 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18364 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18365 instance of ObsoleteAttribute when symbol is obsolete.
18368 (IMethodData): Extended interface for ObsoleteAttribute support.
18370 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18372 * attribute.cs: Fix bug #55970
18374 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18378 (GetObsoleteAttribute): New method. Creates the instance of
18380 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18381 ObsoleteAttribute when member is obsolete.
18382 (AttributeTester.Report_ObsoleteMessage): Common method for
18383 Obsolete error/warning reporting.
18386 (TypeContainer.base_classs_type): New member for storing parent type.
18389 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18390 for this MemberCore.
18392 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18394 * attribute.cs, const.cs: Fix bug #58590
18396 2004-05-21 Martin Baulig <martin@ximian.com>
18398 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18399 out parameters if the end of the method is unreachable. Fixes
18402 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18404 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18405 Hari was right, why extra method.
18407 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18409 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18411 2004-05-20 Martin Baulig <martin@ximian.com>
18413 Merged this back from gmcs to keep the differences to a minumum.
18415 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18416 instead of a Declspace.
18417 (Attribute.ResolveType): Likewise.
18418 (Attributes.Search): Likewise.
18419 (Attributes.Contains): Likewise.
18420 (Attributes.GetClsCompliantAttribute): Likewise.
18422 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18424 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18427 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18429 Fix bug #58688 (MCS does not report error when the same attribute
18432 * attribute.cs (Attribute.Emit): Distinction between null and default.
18434 2004-05-19 Raja R Harinath <rharinath@novell.com>
18436 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18437 of a top-level attribute without an attribute target.
18438 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18440 (Attribute.Conditional_GetConditionName),
18441 (Attribute.Obsolete_GetObsoleteMessage): Update.
18442 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18443 part of ScanForIndexerName.
18444 (Attribute.CanIgnoreInvalidAttribute): New function.
18445 (Attribute.ScanForIndexerName): Move to ...
18446 (Attributes.ScanForIndexerName): ... here.
18447 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18448 (Attributes.Search): New internal variant that can choose not to
18449 complain if types aren't resolved. The original signature now
18451 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18452 complaints suppressed.
18453 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18454 only if it not useful.
18455 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18456 top-level for attributes that are shared between the assembly
18457 and a top-level class.
18458 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18459 * class.cs: Update to reflect changes.
18460 (DefineIndexers): Fuse loops.
18461 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18462 a couple more variants of attribute names.
18464 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18466 Fix bug #52585 (Implemented explicit attribute declaration)
18469 (Attributable.ValidAttributeTargets): New abstract method. It gets
18470 list of valid attribute targets for explicit target declaration.
18471 (Attribute.Target): It holds target itself.
18472 (AttributeSection): Removed.
18473 (Attribute.CheckTargets): New method. It checks whether attribute
18474 target is valid for the current element.
18477 (EventProperty): New class. For events that are declared like
18478 property (with add and remove accessors).
18479 (EventField): New class. For events that are declared like field.
18482 * cs-parser.jay: Implemented explicit attribute target declaration.
18484 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18485 Override ValidAttributeTargets.
18488 (ReturnParameter): Class for applying custom attributes on
18490 (ParameterAtribute): New class. Class for applying custom
18491 attributes on the parameter type.
18493 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18495 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18498 (Method): Allow UNSAFE here.
18500 * modifiers.cs: Support unsafe reporting.
18502 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18504 * decl.cs: Fix bug #58478.
18506 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18508 * statement.cs: When checking for unreachable code on an EmptyStatement,
18509 set the location. Fixes bug #58488.
18511 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18513 * driver.cs: Add -pkg handling.
18515 From Gonzalo: UseShelLExecute=false
18517 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18520 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18522 (Attribute.IsClsCompliaceRequired): Moved to base for better
18524 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18525 when attribute is AttributeUsageAttribute.
18526 (Attribute.GetValidTargets): Simplified.
18527 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18528 attribute for this type.
18529 (Attribute.ApplyAttributes): Method renamed to Emit and make
18531 (GlobalAttributeSection): New class for special handling of global
18532 attributes (assembly, module).
18533 (AttributeSection.Emit): New method.
18535 * class.cs: Implemented Attributable abstract methods.
18536 (MethodCore.LabelParameters): Moved to Parameter class.
18537 (Accessor): Is back simple class.
18538 (PropertyMethod): Implemented Attributable abstract class.
18539 (DelegateMethod): Implemented Attributable abstract class.
18540 (Event): New constructor for disctintion between normal Event
18541 and Event with accessors.
18543 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18545 * codegen.cs, const.cs, decl.cs, delegate.cs:
18546 (CommonAssemblyModulClass): Implemented Attributable abstract class
18549 * enum.cs: Implement IAttributeSupport interface.
18550 (EnumMember): New class for emum members. Implemented Attributable
18554 (ParameterBase): Is abstract.
18555 (ReturnParameter): New class for easier [return:] attribute handling.
18557 * typemanager.cs: Removed builder_to_attr.
18559 2004-05-11 Raja R Harinath <rharinath@novell.com>
18562 * attribute.cs (Attribute.GetPositionalValue): New function.
18563 * class.cs (TypeContainer.VerifyMembers): New function.
18564 (TypeContainer.Emit): Use it.
18565 (ClassOrStruct): New base class for Class and Struct.
18566 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18567 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18569 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18570 then each non-static field should have a FieldOffset attribute.
18571 Otherwise, none of the fields should have a FieldOffset attribute.
18572 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18573 and FieldOffset attributes.
18574 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18575 (TypeManager.field_offset_attribute_type): New core types.
18576 (TypeManager.InitCoreTypes): Initialize them.
18578 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18580 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18581 Return correct type.
18584 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18586 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18587 be implicitly converted to ulong.
18589 * expression.cs: The logic for allowing operator &, | and ^ worked
18590 was wrong, it worked before because we did not report an error in
18591 an else branch. Fixes 57895.
18593 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18594 allow volatile fields to be reference types.
18596 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18598 * driver.cs: Add support for /debug-
18600 2004-05-07 Raja R Harinath <rharinath@novell.com>
18602 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18603 Add a 'complain' parameter to silence errors.
18604 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18605 silently overlooked type-resolutions.
18606 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18607 to reflect changes.
18608 (Attributes.Search): New function.
18609 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18610 (Attributes.GetAttributeFullName): Remove hack.
18611 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18612 Update to reflect changes.
18613 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18614 Use Attributes.Search instead of nested loops.
18616 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18619 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18620 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18621 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18623 * report.cs: (Report.Warning): Renamed to Warning_T because of
18624 parameter collision.
18626 2004-05-05 Raja R Harinath <rharinath@novell.com>
18628 * expression.cs (MemberAccess.ResolveMemberAccess):
18629 Exit with non-zero status after Report.Error.
18630 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18632 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18634 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18636 * support.cs: Don't hang when the file is empty.
18638 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18640 * support.cs: In SeekableStreamReader, compute the preamble size of the
18641 underlying stream. Position changes should take into account that initial
18644 2004-05-03 Todd Berman <tberman@sevenl.net>
18646 * driver.cs: remove unused GetSysVersion function.
18648 2004-05-03 Todd Berman <tberman@sevenl.net>
18650 * driver.cs: Remove the hack from saturday, as well as the hack
18651 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18652 link_paths to get that bit proper.
18654 2004-05-01 Todd Berman <tberman@sevenl.net>
18656 * driver.cs: Try a LoadFrom before a Load, this checks the current
18657 path. This is currently a bug in mono that is be fixed, however, this
18658 provides a workaround for now. This will be removed when the bug
18661 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18663 * CryptoConvert.cs: Updated to latest version. Fix issue with
18664 incomplete key pairs (#57941).
18666 2004-05-01 Todd Berman <tberman@sevenl.net>
18668 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18671 2004-04-30 Jackson Harper <jackson@ximian.com>
18673 * codegen.cs: Open keys readonly.
18675 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18677 * typemanager.cs: don't report cyclic struct layout when a struct
18678 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18679 which has 2 Pango.Rectangle fields.
18681 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18683 * expression.cs: Handle IntPtr comparisons with IL code
18684 rather than a method call.
18686 2004-04-29 Martin Baulig <martin@ximian.com>
18688 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18689 the list of PropertyInfo's in class hierarchy and find the
18690 accessor. Fixes #56013.
18692 2004-04-29 Martin Baulig <martin@ximian.com>
18694 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18696 2004-04-29 Martin Baulig <martin@ximian.com>
18698 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18700 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18702 2004-04-29 Martin Baulig <martin@ximian.com>
18704 * class.cs (ConstructorInitializer.Resolve): Check whether the
18705 parent .ctor is accessible. Fixes #52146.
18707 2004-04-29 Martin Baulig <martin@ximian.com>
18709 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18711 * statement.cs (Using.EmitLocalVariableDecls): Use
18712 TypeManager.idisposable_type, not typeof (IDisposable).
18713 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18715 2004-04-29 Martin Baulig <martin@ximian.com>
18717 * class.cs (Event.Define): Don't emit the field and don't set
18718 RTSpecialName and SpecialName for events on interfaces. Fixes
18721 2004-04-29 Raja R Harinath <rharinath@novell.com>
18723 Refactor Attribute.ApplyAttributes.
18724 * attribute.cs (Attributable): New base class for objects that can
18725 have Attributes applied on them.
18726 (Attribute): Make AttributeUsage fields public.
18727 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18728 (Attribute.IsInternalCall): New property.
18729 (Attribute.UsageAttr): Convert to a public read-only property.
18730 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18731 (Attribute.ResolveType, Attribute.Resolve)
18732 (Attribute.ScanForIndexerName): Update to reflect changes.
18733 (Attribute.CheckAttributeTarget): Re-format.
18734 (Attribute.ApplyAttributes): Refactor, to various
18735 Attributable.ApplyAttributeBuilder methods.
18736 * decl.cs (MemberCore): Make Attributable.
18737 * class.cs (Accessor): Make Attributable.
18738 (MethodData.ApplyAttributes): Use proper attribute types, not
18740 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18741 (TypeContainer.ApplyAttributeBuilder)
18742 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18743 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18744 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18745 (Operator.ApplyAttributeBuilder): New factored-out methods.
18746 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18747 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18748 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18749 * parameter.cs (ParameterBase): New Attributable base class
18750 that can also represent Return types.
18751 (Parameter): Update to the changes.
18753 2004-04-29 Jackson Harper <jackson@ximian.com>
18755 * driver.cs: Prefer the corlib system version when looking for
18756 assemblies in the GAC. This is still a hack, but its a better hack
18759 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18761 * decl.cs, enum.cs: Improved error 3005 reporting.
18763 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18764 (related_symbols): New private member for list of symbols
18765 related to reported error/warning.
18767 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18769 2004-04-29 Martin Baulig <martin@ximian.com>
18771 * ecore.cs (Expression.Constantify): If we're an enum and
18772 TypeManager.TypeToCoreType() doesn't give us another type, use
18773 t.UnderlyingSystemType. Fixes #56178.
18775 2004-04-29 Martin Baulig <martin@ximian.com>
18777 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18778 interfaces and for each interface, only add members directly
18779 declared in that interface. Fixes #53255.
18781 2004-04-28 Martin Baulig <martin@ximian.com>
18783 * expression.cs (ConditionalLogicalOperator): Use a temporary
18784 variable for `left' to avoid that we evaluate it more than once;
18787 2004-04-28 Martin Baulig <martin@ximian.com>
18789 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18792 2004-04-28 Martin Baulig <martin@ximian.com>
18794 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18797 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18798 whether the type is not void (CS1547).
18800 2004-04-28 Martin Baulig <martin@ximian.com>
18802 * expression.cs (Unary.DoResolveLValue): Override this and report
18803 CS0131 for anything but Operator.Indirection.
18805 2004-04-28 Martin Baulig <martin@ximian.com>
18807 Committing a patch from Ben Maurer; see bug #50820.
18809 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18812 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18815 2004-04-28 Martin Baulig <martin@ximian.com>
18817 Committing a patch from Ben Maurer; see bug #50820.
18819 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18822 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18825 2004-04-28 Martin Baulig <martin@ximian.com>
18827 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18828 (Block.AddLabel): Call DoLookupLabel() to only search in the
18831 2004-04-28 Martin Baulig <martin@ximian.com>
18833 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18834 comparing StringConstants and NullLiterals in Equality and Inequality.
18836 2004-04-28 Jackson Harper <jackson@ximian.com>
18838 * driver.cs: Attempt to load referenced assemblies from the
18839 GAC. This is the quick and dirty version of this method that
18840 doesnt take into account versions and just takes the first
18841 canidate found. Will be good enough for now as we will not have more
18842 then one version installed into the GAC until I update this method.
18844 2004-04-28 Martin Baulig <martin@ximian.com>
18846 * typemanager.cs (TypeManager.CheckStructCycles): New public
18847 static method to check for cycles in the struct layout.
18849 * rootcontext.cs (RootContext.PopulateTypes): Call
18850 TypeManager.CheckStructCycles() for each TypeContainer.
18851 [Note: We only need to visit each type once.]
18853 2004-04-28 Martin Baulig <martin@ximian.com>
18855 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18857 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18858 success and added `out object value'. Use a `bool resolved' field
18859 to check whether we've already been called rather than
18860 `ConstantValue != null' since this breaks for NullLiterals.
18862 2004-04-28 Raja R Harinath <rharinath@novell.com>
18864 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18865 setting of this flag, since the 'set' method may be non-public.
18867 2004-04-28 Raja R Harinath <rharinath@novell.com>
18869 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18870 check on current_vector.Block.
18872 2004-04-27 Martin Baulig <martin@ximian.com>
18874 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18875 a field initializer. Fixes #56459.
18877 2004-04-27 Martin Baulig <martin@ximian.com>
18879 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18880 we're not attempting to use an indexer. Fixes #52154.
18882 2004-04-27 Martin Baulig <martin@ximian.com>
18884 * statement.cs (Return): Don't create a return label if we don't
18885 need it; reverts my change from January 20th. Thanks to Ben
18888 2004-04-27 Martin Baulig <martin@ximian.com>
18890 According to the spec, `goto' can only leave a nested scope, but
18893 * statement.cs (Block.LookupLabel): Only lookup in the current
18894 block, don't recurse into parent or child blocks.
18895 (Block.AddLabel): Check in parent and child blocks, report
18896 CS0140/CS0158 if we find a duplicate.
18897 (Block): Removed this indexer for label lookups.
18898 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18899 this already does the error reporting for us.
18902 (FlowBranching.UsageVector.Block): New public variable; may be null.
18903 (FlowBranching.CreateSibling): Added `Block' argument.
18904 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18905 label for the target of a `goto' and check whether we're not
18906 leaving a `finally'.
18908 2004-04-27 Martin Baulig <martin@ximian.com>
18910 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18911 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18914 2004-04-27 Martin Baulig <martin@ximian.com>
18916 * statement.cs (Block.AddLabel): Also check for implicit blocks
18917 and added a CS0158 check.
18919 2004-04-27 Martin Baulig <martin@ximian.com>
18921 * flowanalysis.cs (FlowBranchingLoop): New class.
18922 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18923 UsageVector's instead of an ArrayList.
18924 (FlowBranching.Label): Likewise.
18925 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18926 (FlowBranching.AddBreakVector): New method.
18928 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18930 * attribute.cs: Small regression fix: only convert the type if we
18931 the type is different, fixes System.Drawing build.
18933 2004-04-27 Martin Baulig <martin@ximian.com>
18935 * attribute.cs (Attribute.Resolve): If we have a constant value
18936 for a named field or property, implicity convert it to the correct
18939 2004-04-27 Raja R Harinath <rharinath@novell.com>
18941 * statement.cs (Block.Block): Implicit blocks share
18942 'child_variable_names' fields with parent blocks.
18943 (Block.AddChildVariableNames): Remove.
18944 (Block.AddVariable): Mark variable as "used by a child block" in
18945 every surrounding block.
18946 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18947 been used in a child block, complain about violation of "Invariant
18948 meaning in blocks" rule.
18949 * cs-parser.jay (declare_local_variables): Don't use
18950 AddChildVariableNames.
18951 (foreach_statement): Don't create an implicit block: 'foreach'
18952 introduces a scope.
18954 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18956 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18957 converting from 0L to ulong. Fixes 57522.
18959 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18961 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18962 derived class hides via 'new' keyword field from base class (test-242.cs).
18963 TODO: Handle this in the more general way.
18965 * class.cs (CheckBase): Ditto.
18967 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18969 * decl.cs (caching_flags): New member for storing cached values
18971 (MemberCore.Flags): New enum where bit flags for caching_flags
18973 (MemberCore.cls_compliance): Moved to caching_flags.
18974 (DeclSpace.Created): Moved to caching_flags.
18976 * class.cs: Use caching_flags instead of DeclSpace.Created
18978 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18980 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18981 if we are only a derived class, not a nested class.
18983 * typemanager.cs: Same as above, but do this at the MemberLookup
18984 level (used by field and methods, properties are handled in
18985 PropertyExpr). Allow for the qualified access if we are a nested
18988 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18990 * class.cs: Refactoring.
18991 (IMethodData): New inteface; Holds links to parent members
18992 to avoid member duplication (reduced memory allocation).
18993 (Method): Implemented IMethodData interface.
18994 (PropertyBase): New inner classes for get/set methods.
18995 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18996 (Event): New inner classes for add/remove methods.
18997 (Event.DelegateMethod): Implemented IMethodData interface.
18999 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19000 EmitContext (related to class.cs refactoring).
19002 2004-04-21 Raja R Harinath <rharinath@novell.com>
19004 * delegate.cs (Delegate.VerifyApplicability): If the number of
19005 arguments are the same as the number of parameters, first try to
19006 verify applicability ignoring any 'params' modifier on the last
19010 2004-04-16 Raja R Harinath <rharinath@novell.com>
19012 * class.cs (TypeContainer.AddIndexer): Use
19013 'ExplicitInterfaceName' to determine if interface name was
19014 explicitly specified. 'InterfaceType' is not initialized at this time.
19015 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19016 Indexers array is already in the required order. Initialize
19017 'IndexerName' only if there are normal indexers.
19018 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19019 (TypeContainer.Emit): Emit DefaultMember attribute only if
19020 IndexerName is initialized.
19023 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19025 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19028 2004-04-15 Raja R Harinath <rharinath@novell.com>
19030 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19034 * attribute.cs (Attribute.Resolve): Check for duplicate named
19038 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19040 * iterators.cs (MarkYield): track whether we are in an exception,
19041 and generate code accordingly. Use a temporary value to store the
19042 result for our state.
19044 I had ignored a bit the interaction of try/catch with iterators
19045 since their behavior was not entirely obvious, but now it is
19046 possible to verify that our behavior is the same as MS .NET 2.0
19050 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19052 * iterators.cs: Avoid creating temporaries if there is no work to
19055 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19056 Enumerations, use TypeManager.EnumToUnderlying and call
19059 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19062 (This.Emit): Use EmitContext.EmitThis to emit our
19065 (This.EmitAssign): Ditto.
19067 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19068 codepaths, we will move all the functionality into
19071 (FieldExpr.EmitAssign): Ditto.
19073 This fixes several hidden bugs that I uncovered while doing a code
19074 review of this today.
19076 * codegen.cs (EmitThis): reworked so the semantics are more clear
19077 and also support value types "this" instances.
19079 * iterators.cs: Changed so that for iterators in value types, we
19080 do not pass the value type as a parameter.
19082 Initialization of the enumerator helpers is now done in the caller
19083 instead of passing the parameters to the constructors and having
19084 the constructor set the fields.
19086 The fields have now `assembly' visibility instead of private.
19088 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19090 * expression.cs (Argument.Resolve): Check if fields passed as ref
19091 or out are contained in a MarshalByRefObject.
19093 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19094 another compiler type.
19096 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19098 * class.cs (Indexer.Define): use the new name checking method.
19099 Also, return false on an error.
19100 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19101 (is_identifier_[start/part]_character): make static.
19103 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19105 * expression.cs (Binary.ResolveOperator): Do no append strings
19106 twice: since we can be invoked more than once (array evaluation)
19107 on the same concatenation, take care of this here. Based on a fix
19108 from Ben (bug #56454)
19110 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19112 * codegen.cs: Fix another case where CS1548 must be reported (when
19113 delay-sign isn't specified and no private is available #56564). Fix
19114 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19115 error when MCS is used on the MS runtime and we need to delay-sign
19116 (which seems unsupported by AssemblyBuilder - see #56621).
19118 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19120 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19121 (TypeManager.ComputeNamespaces): Faster implementation for
19124 * compiler.csproj: Updated AssemblyName to mcs.
19126 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19128 * rootcontext.cs: Add new types to the boot resolution.
19130 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19131 MulticastDelegate is not allowed.
19133 * typemanager.cs: Add new types to lookup: System.TypedReference
19136 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19137 check for TypedReference or ArgIterator, they are not allowed.
19139 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19140 makes us properly catch 1510 in some conditions (see bug 56016 for
19143 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19145 * CryptoConvert.cs: update from corlib version
19148 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19150 * class.cs (Indexer.Define): Check indexername declaration
19152 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19154 * attribute.cs (IsClsCompliant): Fixed problem with handling
19155 all three states (compliant, not-compliant, undetected).
19157 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19159 * attribute.cs (Attribute): Location is now public.
19160 (Resolve): Store resolved arguments (pos_values) in attribute class.
19161 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19162 (GetClsCompliantAttributeValue): New method that gets
19163 CLSCompliantAttribute value.
19164 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19165 if exists else null.
19166 (AttributeTester): New class for CLS-Compliant verification routines.
19168 * class.cs (Emit): Add CLS-Compliant verification.
19169 (Method.GetSignatureForError): Implemented.
19170 (Constructor.GetSignatureForError): Implemented
19171 (Constructor.HasCompliantArgs): Returns if constructor has
19172 CLS-Compliant arguments.
19173 (Constructor.Emit): Override.
19174 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19175 is needed to test only parameters.
19176 (FieldBase.GetSignatureForError): Implemented.
19177 (TypeContainer): New member for storing base interfaces.
19178 (TypeContainer.FindMembers): Search in base interfaces too.
19180 * codegen.cs (GetClsComplianceAttribute): New method that gets
19181 assembly or module CLSCompliantAttribute value.
19182 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19184 (ModuleClass.Emit): Add error 3012 test.
19186 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19188 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19189 state for all decl types.
19190 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19191 if CLS-Compliant tests are required.
19192 (IsClsCompliaceRequired): New method. Analyze whether code
19193 must be CLS-Compliant.
19194 (IsExposedFromAssembly): New method. Returns true when MemberCore
19195 is exposed from assembly.
19196 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19197 value or gets cached value.
19198 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19199 is explicitly marked with CLSCompliantAttribute.
19200 (IsIdentifierClsCompliant): New abstract method. This method is
19201 used to testing error 3005.
19202 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19203 for identifier and parameters CLS-Compliant testing.
19204 (VerifyClsCompliance): New method. The main virtual method for
19205 CLS-Compliant verifications.
19206 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19207 null. I don't know why is null (too many public members !).
19208 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19209 and get value of first CLSCompliantAttribute that found.
19211 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19212 (VerifyClsCompliance): Override and add extra tests.
19214 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19215 clscheck- disable CLS-Compliant verification event if assembly is has
19216 CLSCompliantAttribute(true).
19218 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19219 ApllyAttribute is now called in emit section as in the other cases.
19220 Possible future Emit integration.
19221 (IsIdentifierClsCompliant): New override.
19222 (VerifyClsCompliance): New override.
19223 (GetEnumeratorName): Returns full enum name.
19225 * parameter.cs (GetSignatureForError): Implemented.
19227 * report.cs (WarningData): New struct for Warning message information.
19228 (LocationOfPreviousError): New method.
19229 (Warning): New method. Reports warning based on the warning table.
19230 (Error_T): New method. Reports error based on the error table.
19232 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19233 verifications are done here.
19235 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19237 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19238 CLSCompliantAttribute.
19239 (all_imported_types): New member holds all imported types from other
19241 (LoadAllImportedTypes): New method fills static table with exported types
19242 from all referenced assemblies.
19243 (Modules): New property returns all assembly modules.
19245 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19247 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19248 throwing a parser error.
19250 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19251 which removes the hardcoded get_/set_ prefixes for properties, as
19252 IL allows for the properties to be named something else.
19256 * expression.cs: Do not override operand before we know if it is
19257 non-null. Fix 56207
19259 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19261 * typemanager.cs: support for pinned variables.
19263 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19265 * decl.cs, typemanager.cs: Avoid using an arraylist
19266 as a buffer if there is only one result set.
19268 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19270 * expression.cs: Make sure you cant call a static method
19271 with an instance expression, bug #56174.
19273 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19275 * class.cs (IsDuplicateImplementation): Improve error reporting to
19276 flag 663 (method only differs in parameter modifier).
19278 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19279 in preprocessor directives.
19281 * location.cs (LookupFile): Allow for the empty path.
19283 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19284 better approach for some of that patch, but its failing with the
19285 CharSet enumeration. For now try/catch will do.
19287 * typemanager.cs: Do not crash if a struct does not have fields.
19290 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19292 * expression.cs: cs0213, cant fix a fixed expression.
19295 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19297 * cs-parser.jay: detect invalid embeded statements gracefully.
19300 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19302 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19305 the invocation type may not be a subclass of the tye of the item/
19306 The type of the item must be a subclass of the invocation item.
19311 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19313 * attribute.cs: Added methods to get a string and a bool from an
19314 attribute. Required to information from AssemblyKeyFileAttribute,
19315 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19316 * codegen.cs: Modified AssemblyName creation to include support for
19317 strongnames. Catch additional exceptions to report them as CS1548.
19318 * compiler.csproj: Updated include CryptoConvert.cs.
19319 * compiler.csproj.user: Removed file - user specific configuration.
19320 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19321 Mono.Security assembly. The original class is maintained and tested in
19322 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19323 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19324 like CSC 8.0 (C# v2) supports.
19325 * Makefile: Added CryptoConvert.cs to mcs sources.
19326 * rootcontext.cs: Added new options for strongnames.
19328 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19330 * driver.cs: For --expect-error, report error code `2'
19331 if the program compiled with no errors, error code `1' if
19332 it compiled with an error other than the one expected.
19334 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19336 * compiler.csproj: Updated for Visual Studio .NET 2003.
19337 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19338 * compiler.sln: Updated for Visual Studio .NET 2003.
19340 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19342 * expression.cs: Fix bug #47234. We basically need to apply the
19343 rule that we prefer the conversion of null to a reference type
19344 when faced with a conversion to 'object' (csc behaviour).
19346 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19348 * statement.cs: Shorter form for foreach, eliminates
19349 a local variable. r=Martin.
19351 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19353 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19354 checks if we can use brtrue/brfalse to test for 0.
19355 * expression.cs: use the above in the test for using brtrue/brfalse.
19356 cleanup code a bit.
19358 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19360 * expression.cs: Rewrite string concat stuff. Benefits:
19362 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19363 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19364 rather than a concat chain.
19366 * typemanager.cs: Add lookups for more concat overloads.
19368 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19370 * expression.cs: Emit shorter il code for array init.
19387 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19389 * statement.cs: Before, two switch blocks would be merged if the
19390 total size of the blocks (end_item - begin_item + 1) was less than
19391 two times the combined sizes of the blocks.
19393 Now, it will only merge if after the merge at least half of the
19398 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19400 * class.cs : csc build fix for GetMethods(). See bug #52503.
19402 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19404 * expression.cs: Make sure fp comparisons work with NaN.
19405 This fixes bug #54303. Mig approved this patch a long
19406 time ago, but we were not able to test b/c the runtime
19409 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19411 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19413 2004-03-19 Martin Baulig <martin@ximian.com>
19415 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19416 error here and not in our caller.
19418 2004-03-19 Martin Baulig <martin@ximian.com>
19420 * interface.cs: Completely killed this file.
19421 (Interface): We're now a TypeContainer and live in class.cs.
19423 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19424 argument; we're now also called for interfaces.
19425 (TypeContainer.DefineMembers): Allow this method being called
19427 (TypeContainer.GetMethods): New public method; formerly known as
19428 Interface.GetMethod(). This is used by PendingImplementation.
19429 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19430 it's now private and non-static.
19431 (Interface): Moved this here; it's now implemented similar to
19433 (Method, Property, Event, Indexer): Added `bool is_interface'
19434 argument to their .ctor's.
19435 (MemberBase.IsInterface): New public field.
19437 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19438 instances instead of InterfaceMethod, InterfaceProperty, etc.
19439 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19440 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19442 2004-03-19 Martin Baulig <martin@ximian.com>
19444 * class.cs (MethodCore.IsDuplicateImplementation): New private
19445 method which does the CS0111 checking.
19446 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19447 Use IsDuplicateImplementation().
19449 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19451 * decl.cs (FindMemberToOverride): New method to find the correct
19452 method or property to override in the base class.
19454 - Make Method/Property use the above method to find the
19455 version in the base class.
19456 - Remove the InheritableMemberSignatureCompare as it is now
19459 This patch makes large code bases much faster to compile, as it is
19460 O(n) rather than O(n^2) to do this validation.
19462 Also, it fixes bug 52458 which is that nested classes are not
19463 taken into account when finding the base class member.
19465 Reviewed/Approved by Martin.
19467 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19469 * interface.cs: In all interface classes removed redundant
19470 member initialization.
19472 2004-03-16 Martin Baulig <martin@ximian.com>
19474 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19476 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19478 * decl.cs (DefineTypeAndParents): New helper method to define a
19479 type's containers before the type itself is defined; This is a
19480 bug exposed by the recent changes to Windows.Forms when an
19481 implemented interface was defined inside a class that had not been
19484 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19486 (Check): Loop correctly to report errors modifiers
19487 (UNSAFE was not in the loop, since it was the same as TOP).
19489 * interface.cs: Every interface member now takes a ModFlags,
19490 instead of a "is_new" bool, which we set on the base MemberCore.
19492 Every place where we called "UnsafeOk" in the interface, now we
19493 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19494 the unsafe settings from the member declaration instead of the
19495 container interface.
19497 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19499 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19500 `set_indexer_name' to the pending bits (one per type).
19502 We fixed a bug today that was picking the wrong method to
19503 override, since for properties the existing InterfaceMethod code
19504 basically ignored the method name. Now we make sure that the
19505 method name is one of the valid indexer names.
19507 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19509 * support.cs (SeekableStreamReader): Keep track of stream byte
19510 positions and don't mix them with character offsets to the buffer.
19512 Patch from Gustavo Giráldez
19514 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19516 * interface.cs (InterfaceSetGetBase): Removed double member
19517 initialization, base class does it as well.
19519 2004-03-13 Martin Baulig <martin@ximian.com>
19521 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19522 when compiling corlib.
19524 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19526 * convert.cs (ExplicitConversion): We were reporting an error on
19527 certain conversions (object_type source to a value type, when the
19528 expression was `null') before we had a chance to pass it through
19529 the user defined conversions.
19531 * driver.cs: Replace / and \ in resource specifications to dots.
19534 * class.cs: Add check for duplicate operators. Fixes 52477
19536 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19538 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19539 that are in the middle of the statements, not only at the end.
19542 * class.cs (TypeContainer.AddField): No longer set the
19543 `HaveStaticConstructor' flag, now we call it
19544 `UserDefineStaticConstructor' to diferentiate the slightly
19545 semantic difference.
19547 The situation is that we were not adding BeforeFieldInit (from
19548 Modifiers.TypeAttr) to classes that could have it.
19549 BeforeFieldInit should be set to classes that have no static
19554 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19556 And most importantly Zoltan's comment:
19558 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19560 "I think beforefieldinit means 'it's ok to initialize the type sometime
19561 before its static fields are used', i.e. initialization does not need
19562 to be triggered by the first access to the type. Setting this flag
19563 helps the JIT to compile better code, since it can run the static
19564 constructor at JIT time, and does not need to generate code to call it
19565 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19566 this flag for lots of classes like String.
19568 csc sets this flag if the type does not have an explicit static
19569 constructor. The reasoning seems to be that if there are only static
19570 initalizers for a type, and no static constructor, then the programmer
19571 does not care when this initialization happens, so beforefieldinit
19574 This bug prevents the AOT compiler from being usable, since it
19575 generates so many calls to mono_runtime_class_init that the AOT code
19576 is much slower than the JITted code. The JITted code is faster,
19577 because it does not generate these calls if the vtable is type is
19578 already initialized, which is true in the majority of cases. But the
19579 AOT compiler can't do this."
19581 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19583 * class.cs (MethodData.Emit): Refactor the code so symbolic
19584 information is generated for destructors; For some reasons we
19585 were taking a code path that did not generate symbolic information
19588 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19590 * class.cs: Create a Constructor.CheckBase method that
19591 takes care of all validation type code. The method
19592 contains some code that was moved from Define.
19594 It also includes new code that checks for duplicate ctors.
19595 This fixes bug #55148.
19597 2004-03-09 Joshua Tauberer <tauberer@for.net>
19599 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19600 a { ... }-style array creation invokes EmitStaticInitializers
19601 which is not good for reference-type arrays. String, decimal
19602 and now null constants (NullCast) are not counted toward
19603 static initializers.
19605 2004-03-05 Martin Baulig <martin@ximian.com>
19607 * location.cs (SourceFile.HasLineDirective): New public field;
19608 specifies whether the file contains or is referenced by a "#line"
19610 (Location.DefineSymbolDocuments): Ignore source files which
19611 either contain or are referenced by a "#line" directive.
19613 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19615 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19616 direct access to our parent, so check the method inline there.
19618 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19620 * expression.cs (Invocation.EmitCall): Miguel's last commit
19621 caused a regression. If you had:
19626 In Foo the implict this would be null.
19628 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19630 * expression.cs (Invocation.EmitCall): If the method is not
19631 virtual, do not emit a CallVirt to it, use Call.
19633 * typemanager.cs (GetFullNameSignature): Improve the method to
19634 cope with ".ctor" and replace it with the type name.
19636 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19637 as an argument the ConstructorBuilder where it is being defined,
19638 to catch the recursive constructor invocations.
19640 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19642 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19643 routines to check if a type is an enumerable/enumerator allow
19644 classes that implement the IEnumerable or IEnumerator interfaces.
19646 * class.cs (Property, Operator): Implement IIteratorContainer, and
19647 implement SetYields.
19649 (Property.Define): Do the block swapping for get_methods in the
19650 context of iterators. We need to check if Properties also
19651 include indexers or not.
19653 (Operator): Assign the Block before invoking the
19654 OperatorMethod.Define, so we can trigger the Iterator code
19657 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19658 Property and Operator classes are not created when we parse the
19659 declarator but until we have the block completed, so we use a
19660 singleton SimpleIteratorContainer.Simple to flag whether the
19661 SetYields has been invoked.
19663 We propagate this setting then to the Property or the Operator to
19664 allow the `yield' to function.
19666 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19668 * codegen.cs: Implemented attribute support for modules.
19669 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19670 Assembly/Module functionality.
19672 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19673 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19674 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19676 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19678 * interface.cs (FindMembers): The operation is performed on all base
19679 interfaces and not only on the first. It is required for future CLS Compliance patch.
19681 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19683 * statement.cs, codegen.cs:
19684 This patch deals with patterns such as:
19686 public class List : IEnumerable {
19688 public MyEnumerator GetEnumerator () {
19689 return new MyEnumerator(this);
19692 IEnumerator IEnumerable.GetEnumerator () {
19696 public struct MyEnumerator : IEnumerator {
19701 Before, there were a few things we did wrong:
19702 1) we would emit callvirt on a struct, which is illegal
19703 2) we emited ldarg when we needed to emit ldarga
19704 3) we would mistakenly call the interface methods on an enumerator
19705 type that derived from IEnumerator and was in another assembly. For example:
19707 public class MyEnumerator : IEnumerator
19709 Would have the interface methods called, even if there were public impls of the
19710 method. In a struct, this lead to invalid IL code.
19712 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19714 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19717 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19719 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19721 * cs-parser.jay: Fix small regression: we were not testing V2
19722 compiler features correctly.
19724 * interface.cs: If the emit context is null, then create one
19726 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19728 * decl.cs (GetSignatureForError): New virtual method to get full name
19729 for error messages.
19731 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19732 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19734 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19735 Duplicated members and code in these classes has been removed.
19736 Better encapsulation in these classes.
19738 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19740 * assign.cs (Assign.DoResolve): When dealing with compound
19741 assignments, there is a new rule in ECMA C# 2.4 (might have been
19742 there before, but it is documented here) that states that in:
19746 If b is of type int, and the `op' is a shift-operator, then the
19747 above is evaluated as:
19751 * expression.cs (Binary.ResolveOperator): Instead of testing for
19752 int/uint/long/ulong, try to implicitly convert to any of those
19753 types and use that in pointer arithmetic.
19755 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19756 method to print information for from the type, not from the
19757 null-method we were given.
19759 2004-02-01 Duncan Mak <duncan@ximian.com>
19761 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19762 parsing for cmd, fixes bug #53694.
19764 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19766 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19767 in the member name duplication tests. Property and operator name duplication
19768 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19770 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19772 * interface.cs (PopulateMethod): Fixed crash when interface method
19773 returns not existing type (error test cs0246-3.cs).
19775 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19777 * cs-parser.jay (interface_accessors): Re-write actions to also
19778 store attributes attached to get and set methods. Fix spelling
19781 (inteface_property_declaration): Modify accordingly.
19783 (InterfaceAccessorInfo): New helper class to store information to pass
19784 around between rules that use interface_accessors.
19786 * interface.cs (Emit): Apply attributes on the get and set
19787 accessors of properties and indexers too.
19789 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19790 right MethodBuilder when applying attributes to the get and set accessors.
19792 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19794 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19796 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19798 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19800 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19802 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19803 changes that treat `yield' specially when present before `break'
19804 or `return' tokens.
19806 * cs-tokenizer.cs: yield is no longer a keyword.
19808 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19810 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19811 setting for default constructors.
19812 For default constructors are almost every time set wrong Modifier. The
19813 generated IL code has been alright. But inside mcs this values was
19814 wrong and this was reason why several of my CLS Compliance tests
19817 2004-01-22 Martin Baulig <martin@ximian.com>
19819 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19820 not a QualifiedIdentifier. This is what `type_name_expression'
19821 was previously doing.
19822 (type_name_expression): Removed; the code is now in
19823 `namespace_or_type_name'.
19824 (qualified_identifier): Removed, use `namespace_or_type_name'
19826 (QualifiedIdentifier): Removed this class.
19828 2004-01-22 Martin Baulig <martin@ximian.com>
19830 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19831 not a string as alias name.
19833 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19835 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19836 #52730 bug, and instead compute correctly the need to use a
19837 temporary variable when requesting an address based on the
19838 static/instace modified of the field and the constructor.
19840 2004-01-21 Martin Baulig <martin@ximian.com>
19842 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19843 class and namespace before looking up aliases. Fixes #52517.
19845 2004-01-21 Martin Baulig <martin@ximian.com>
19847 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19848 assinged in a 'try'; fixes exception4.cs.
19850 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19851 * class.cs : Implemented parameter-less constructor for TypeContainer
19853 * decl.cs: Attributes are now stored here. New property OptAttributes
19855 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19857 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19859 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19861 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19862 (CSharpSignature): New method for indexer and property signature.
19864 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19866 * pending.cs (IsVirtualFilter): Faster implementation.
19868 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19870 * typemanager.cs: Avoid inclusion of same assembly more than once.
19872 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19874 * cs-parser.jay: Fixed problem where the last assembly attribute
19875 has been applied also to following declaration (class, struct, etc.)
19877 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19879 * class.cs: Added error CS0538, CS0539 reporting.
19880 Fixed crash on Microsoft runtime when field type is void.
19882 * cs-parser.jay: Added error CS0537 reporting.
19884 * pending.cs: Added error CS0535 reporting.
19885 Improved error report for errors CS0536, CS0534.
19887 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19889 Merge a few bits from the Anonymous Method MCS tree.
19891 * statement.cs (ToplevelBlock): New class for toplevel methods,
19892 will hold anonymous methods, lifted variables.
19894 * cs-parser.jay: Create toplevel blocks for delegates and for
19895 regular blocks of code.
19897 2004-01-20 Martin Baulig <martin@ximian.com>
19899 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19900 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19901 and `NeedExplicitReturn'; added `IsLastStatement'.
19902 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19903 have a `ReturnLabel' or we're not unreachable.
19905 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19906 child's reachability; don't just override ours with it. Fixes
19907 #58058 (lluis's example).
19908 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19909 InFinally(), InLoop(), InSwitch() and
19910 BreakCrossesTryCatchBoundary() methods.
19912 * statement.cs (Return): Do all error checking in Resolve().
19913 Unless we are the last statement in a top-level block, always
19914 create a return label and jump to it.
19915 (Break, Continue): Do all error checking in Resolve(); also make
19916 sure we aren't leaving a `finally'.
19917 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19918 statement in a top-level block.
19919 (Block.Flags): Added `IsDestructor'.
19920 (Block.IsDestructor): New public property.
19922 2004-01-20 Martin Baulig <martin@ximian.com>
19924 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19926 2004-01-20 Martin Baulig <martin@ximian.com>
19928 * statement.cs (Statement.ResolveUnreachable): New public method.
19929 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19930 (Block.Resolve): Resolve unreachable statements.
19932 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19934 * expression.cs: We need to fix the case where we do
19935 not have a temp variable here.
19937 * assign.cs: Only expression compound assignments need
19938 temporary variables.
19940 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19942 * flowanalysis.cs: Reduce memory allocation in a few ways:
19943 - A block with no variables should not allocate a bit
19945 - A method with no out parameters does not need any tracking
19946 for assignment of the parameters, so we need not allocate
19949 public readonly Type[] VariableTypes;
19950 public readonly string[] VariableNames;
19951 Are redundant. The data is already stored in the variable
19952 map, so we need not allocate another array for it.
19953 - We need to add alot of checks for if (params | locals) == null
19954 due to the first two changes.
19956 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19958 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19959 implement IMemoryLocation, we store a copy on a local variable and
19960 take the address of it. Patch from Benjamin Jemlich
19962 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19963 to use a special "type_name_expression" rule which reduces the
19964 number of "QualifiedIdentifier" classes created, and instead
19965 directly creates MemberAccess expressions.
19967 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19969 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19970 that fixes #52853. Null literal assignment to ValueType
19972 * class.cs (MethodData.Emit): Instead of checking the name of the
19973 method to determine if its a destructor, create a new derived
19974 class from Method called Destructor, and test for that.
19976 * cs-parser.jay: Create a Destructor object instead of a Method.
19978 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19982 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19984 * expression.cs (Binary.ResolveOperator): Perform an implicit
19985 conversion from MethodGroups to their delegate types on the
19986 Addition operation.
19988 * delegate.cs: Introduce a new class DelegateCreation that is the
19989 base class for `NewDelegate' and `ImplicitDelegateCreation',
19990 factor some code in here.
19992 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19993 conversion from MethodGroups to compatible delegate types.
19995 * ecore.cs (Expression.Resolve): Do not flag error 654
19996 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19997 we allow conversions from MethodGroups to delegate types now.
19999 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20000 assignments in v2 either.
20002 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20004 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20005 static read-only fields in ctors.
20007 Applied patch from Benjamin Jemlich
20009 * expression.cs (UnaryMutator): Avoid leaking local variables.
20011 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20013 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20014 here to return true, as they can be used like this:
20016 (XXX) int.MEMBER ()
20018 Fixed 49836 and all the other dups
20020 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20022 * driver.cs: Implement /win32res and /win32icon.
20024 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20026 * cs-parser.jay: Add a rule to improve error handling for the
20027 common mistake of placing modifiers after the type.
20029 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20031 * cs-parser.jay (interface_event_declaration): Catch
20032 initialization of events on interfaces, and report cs0068
20034 * cs-parser.jay (interface_event_declaration): Catch
20035 initialization of events.
20037 * ecore.cs: Better report missing constructors.
20039 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20040 the error reporting done in the wrong place. Fix.
20042 * expression.cs (Binary.ResolveOperator): Catch the
20043 operator + (E x, E y) error earlier, and later allow for implicit
20044 conversions in operator +/- (E e, U x) from U to the underlying
20047 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20048 52596, if the container class is abstract, the default constructor
20049 is protected otherwise its public (before, we were always public).
20051 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20054 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20055 Jemlich that fixes bug #52597, MCS was generating invalid code for
20056 idisposable structs. Thanks to Ben for following up with this
20059 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20061 * driver.cs: Allow assemblies without code to be generated, fixes
20064 2004-01-07 Nick Drochak <ndrochak@gol.com>
20066 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20068 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20070 * cs-parser.jay: Add rules to improve error reporting if fields or
20071 methods are declared at the namespace level (error 116)
20073 * Add rules to catch event add/remove
20075 2004-01-04 David Sheldon <dave-mono@earth.li>
20077 * expression.cs: Added matching ")" to error message for
20080 2004-01-03 Todd Berman <tberman@gentoo.org>
20082 * ecore.cs, attribute.cs:
20083 Applying fix from #52429.
20085 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20087 * ecore.cs, expression.cs, statement.cs:
20088 Total rewrite of how we handle branching. We
20089 now handle complex boolean expressions with fewer
20090 jumps. As well if (x == 0) no longer emits a ceq.
20092 if (x is Foo) is much faster now, because we generate
20095 Overall, we get a pretty big improvement on our benchmark
20096 tests. The code we generate is smaller and more readable.
20098 I did a full two-stage bootstrap. The patch was reviewed
20099 by Martin and Miguel.
20101 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20103 * cs-parser.jay: Make primary_expression not take a QI.
20104 we dont need this because the member_access rule covers
20105 us here. So we replace the rule with just IDENTIFIER.
20107 This has two good effects. First, we remove a s/r conflict.
20108 Second, we allocate many fewer QualifiedIdentifier objects.
20110 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20112 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20113 set the correct information via SRE. This prevents
20114 hanging on the MS runtime. Fixes #29374.
20116 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20118 * convert.cs: correctly handle conversions to value types
20119 from Enum and ValueType as unboxing conversions.
20121 Fixes bug #52569. Patch by Benjamin Jemlich.
20123 2004-01-02 Ravi Pratap <ravi@ximian.com>
20125 * expression.cs (BetterConversion): Prefer int -> uint
20126 over int -> ulong (csc's behaviour). This fixed bug #52046.
20128 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20130 * decl.cs (MemberCache.FindMembers): now returns a
20133 * typemanager.cs: In general, go with with ^^.
20134 (CopyNewMethods): take an IList.
20135 (RealMemberLookup): Only allocate an arraylist
20136 if we copy from two sets of methods.
20138 This change basically does two things:
20139 1) Fewer array lists allocated due to CopyNewMethods.
20140 2) the explicit cast in MemberList costed ALOT.
20142 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20144 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20145 a hashtable to avoid needless string allocations when an identifier is
20146 used more than once (the common case).
20148 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20150 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20151 is broken, it will not return anything. So, we
20152 have to use the information we have in mcs to
20155 * typemanager.cs: Add a cache for GetInterfaces,
20156 since this will now be used more often (due to ^^)
20158 (GetExplicitInterfaces) New method that gets the
20159 declared, not effective, interfaces on a type
20160 builder (eg, if you have interface IFoo, interface
20161 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20164 This patch makes MCS able to bootstrap itself on
20167 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20169 * expression.cs: Remove the Nop's that Miguel put
20172 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20174 * report.cs, codegen.cs: Give the real stack trace to
20175 the error when an exception is thrown.
20177 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20179 * decl.cs: only allocate hashtables for ifaces if
20182 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20184 * expression.cs: fix the error from cs0121-2.cs
20185 (a parent interface has two child interfaces that
20186 have a function with the same name and 0 params
20187 and the function is called through the parent).
20189 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20191 * class.cs, rootcontext.cs, typmanager.cs: do not
20194 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20196 * codegen.cs: remove stack for the ec flow branching.
20197 It is already a linked list, so no need.
20199 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20201 * Makefile: Allow custom profiler here.
20203 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20205 * typemanager.cs (LookupType):
20206 - Use a static char [], because split takes
20207 a param array for args, so it was allocating
20209 - Do not store true in a hashtable, it boxes.
20211 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20213 * flowanalysis.cs: bytify common enums.
20215 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20217 * modifiers.cs: Add a new set of flags for the
20218 flags allowed on explicit interface impls.
20219 * cs-parser.jay: catch the use of modifiers in
20220 interfaces correctly.
20221 * class.cs: catch private void IFoo.Blah ().
20223 All related to bug #50572.
20225 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20227 * decl.cs: Rewrite the consistant accessability checking.
20228 Accessability is not linear, it must be implemented in
20229 a tableish way. Fixes #49704.
20231 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20233 * expression.cs: Handle negation in a checked context.
20234 We must use subtraction from zero. Fixes #38674.
20236 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20238 * class.cs: Ignore static void main in DLLs.
20239 * rootcontext.cs: Handle the target type here,
20240 since we are have to access it from class.cs
20241 * driver.cs: account for the above.
20243 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20245 * report.cs: Give line numbers and files if available.
20247 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20249 * driver.cs: Implement /addmodule.
20251 * typemanager.cs: Change 'modules' field so it now contains Modules not
20254 2003-12-20 Martin Baulig <martin@ximian.com>
20256 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20257 (FieldBase.IsAssigned): Removed this field.
20258 (FieldBase.SetAssigned): New public method.
20259 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20261 2003-12-20 Martin Baulig <martin@ximian.com>
20263 * expression.cs (LocalVariableReference.DoResolve): Don't set
20264 `vi.Used' if we're called from DoResolveLValue().
20266 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20267 returns the usage vector it just merged into the current one -
20268 pass this one to UsageWarning().
20269 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20270 of the `EmitContext', don't call this recursively on our children.
20272 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20274 * driver.cs: Implement /target:module.
20276 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20278 * support.cs (CharArrayHashtable): New helper class.
20280 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20281 char arrays, not strings, so we can avoid creating a string in
20282 consume_identifier if the identifier is a keyword.
20284 2003-12-16 Martin Baulig <martin@ximian.com>
20286 * statement.cs (LocalInfo.Assigned): Removed this property.
20287 (LocalInfo.Flags): Removed `Assigned'.
20288 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20289 and uses flow analysis.
20290 (Block.UsageWarning): Made this method private.
20291 (Block.Resolve): Call UsageWarning() if appropriate.
20293 * expression.cs (LocalVariableReference.DoResolve): Always set
20294 LocalInfo.Used here.
20296 2003-12-13 Martin Baulig <martin@ximian.com>
20298 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20299 any value here; we're now using flow analysis to figure out
20300 whether a statement/block returns a value.
20302 2003-12-13 Martin Baulig <martin@ximian.com>
20304 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20306 (FlowBranching.MergeFinally): Don't call
20307 `branching.CheckOutParameters()' here, this is called in
20309 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20310 when adding the `finally' vector.
20312 2003-12-13 Martin Baulig <martin@ximian.com>
20315 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20316 actually work and also fix #48962.
20318 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20320 * decl.cs: Do not check System.Object for nested types,
20321 since we know it does not have any. Big bang for buck:
20324 Run 1: 8.35 seconds
20325 Run 2: 8.32 seconds
20326 corlib: 17.99 seconds
20328 Run 1: 8.17 seconds
20329 Run 2: 8.17 seconds
20330 corlib: 17.39 seconds
20332 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20334 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20335 time we are returning 0 members, so we save alot here.
20337 2003-12-11 Martin Baulig <martin@ximian.com>
20339 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20340 `MergeChild()', also just take the `FlowBranching' as argument;
20341 call Merge() on it and return the result.
20342 (FlowBranching.Merge): We don't need to do anything if we just
20345 2003-12-11 Martin Baulig <martin@ximian.com>
20347 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20348 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20349 Maurer for this idea.
20351 2003-12-11 Martin Baulig <martin@ximian.com>
20353 * flowanalysis.cs (MergeResult): This class is now gone; we now
20354 use the `UsageVector' for this. The reason for this is that if a
20355 branching just has one sibling, we don't need to "merge" them at
20356 all - that's the next step to do.
20357 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20360 2003-12-11 Martin Baulig <martin@ximian.com>
20362 Reworked flow analyis and made it more precise and bug-free. The
20363 most important change is that we're now using a special `Reachability'
20364 class instead of having "magic" meanings of `FlowReturns'. I'll
20365 do some more cleanups and optimizations and also add some more
20366 documentation this week.
20368 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20369 largely reworked this class.
20370 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20371 the new `Reachability' class instead of having "magic" values here.
20372 (FlowBranching): We're now using an instance of `Reachability'
20373 instead of having separate `Returns', `Breaks' etc. fields.
20375 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20376 based on flow analysis; ignore the return value of block.Emit ().
20378 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20380 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20381 if they are private.
20383 2003-12-09 Martin Baulig <martin@ximian.com>
20385 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20386 call them directly on the UsageVector.
20388 2003-12-09 Martin Baulig <martin@ximian.com>
20390 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20391 Changed return type from `FlowReturns' to `Reachability'.
20393 2003-12-09 Martin Baulig <martin@ximian.com>
20395 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20396 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20397 `Reachable' fields with a single `Reachability' one.
20399 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20401 * class.cs (FindMembers): Remove foreach's.
20406 Run 1: 8.74 seconds
20407 Run 2: 8.71 seconds
20410 Run 1: 8.64 seconds
20411 Run 2: 8.58 seconds
20414 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20419 This patch does a few things:
20420 1. EmptyStatement is now a singleton, so it is never reallocated.
20421 2. All blah is EmptyStatement constructs have been changed to
20422 blah == EmptyStatement.Value, which is much faster and valid
20423 now that EmptyStatement is a singleton.
20424 3. When resolving a block, rather than allocating a new array for
20425 the non-empty statements, empty statements are replaced with
20426 EmptyStatement.Value
20427 4. Some recursive functions have been made non-recursive.
20428 Mainly the performance impact is from (3), however (1) and (2) are needed for
20429 this to work. (4) does not make a big difference in normal situations, however
20430 it makes the profile look saner.
20435 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20436 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20437 Total memory allocated: 56397 KB
20440 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20441 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20442 Total memory allocated: 55666 KB
20444 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20446 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20447 than the hashtable in a hashtable version
20449 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20450 we always end up concating a string. This results in a huge perf
20451 loss, because many strings have to be tracked by the GC. In this
20452 patch, we first use a hashtable that works with two keys, so that
20453 the strings do not need to be concat'ed.
20457 Run 1: 8.74 seconds
20458 Run 2: 8.71 seconds
20461 Run 1: 8.65 seconds
20462 Run 2: 8.56 seconds
20464 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20466 * Makefile: Add a new target `do-time' that does a quick and simple
20467 profile, leaving easy to parse output.
20469 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20471 * codegen.cs (Init): Create the dynamic assembly with
20472 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20474 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20476 * support.cs: Make the PtrHashtable use only one
20477 instance of its comparer.
20479 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20481 * typemanager.cs: Fix lookup of GetNamespaces.
20483 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20485 * expression.cs: Removed redundant line.
20487 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20488 ArrayLists, use for loops with bounds.
20490 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20493 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20494 arraylists, use for loop with bounds.
20496 The above three changes give us a 0.071 second performance
20497 improvement out of 3.294 seconds down to 3.223. On my machine
20498 the above changes reduced the memory usage by 1,387 KB during
20499 compiler bootstrap.
20501 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20502 QualifiedIdentifiers. Before we created a new string through
20503 concatenation, and mostly later on, the result would be
20504 manipulated by DecomposeQI through string manipulation.
20506 This reduced the compiler memory usage for bootstrapping from
20507 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20508 compile times in 0.05 seconds.
20510 2003-11-28 Dick Porter <dick@ximian.com>
20512 * support.cs: Do string compares with the Invariant culture.
20520 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20521 the comparison is done with the Invariant culture.
20523 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20525 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20526 GetEnumerator method.
20528 (ProbeCollectionType): Iterate starting at the most specific type
20529 upwards looking for a GetEnumerator
20531 * expression.cs: Shift count can be up to 31 for int/uint and 63
20534 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20536 * statement.cs (Block.LookupLabel): Also look for the label on the
20537 children blocks. Use a hash table to keep track of visited
20540 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20541 we actually did transform the other operand, otherwise fall back
20542 to the common codepath that casts to long.
20544 * cs-tokenizer.cs: Use the same code pattern as the int case.
20545 Maybe I should do the parsing myself, and avoid depending on the
20546 Parse routines to get this done.
20548 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20550 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20551 which fixes bug 51347. This time test it.
20553 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20554 attributes for example can not tell the difference between these.
20555 The difference was only a syntax feature of the language.
20557 * attribute.cs: Apply attributes to delegates.
20559 * delegate.cs: Call the apply attributes method.
20561 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20563 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20564 comparing 0 vs Byte.MinValue, not the value
20566 (ImplicitConversionRequired): When reporting a conversion error,
20567 use error 31 to print out the constant error instead of the
20570 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20571 which fixes bug 51347.
20573 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20575 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20576 which fixes the -warnaserror command line option.
20578 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20580 * cfold.cs (DoNumericPromotions): During constant folding of
20581 additions on UIntConstant, special case intconstants with
20582 IntConstants like we do on the expression binary operator.
20584 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20586 * convert.cs (ImplicitReferenceConversion): We were missing a case
20587 (System.Enum are not value types or class types, so we need to
20588 classify them separatedly).
20590 * driver.cs: We do not support error 2007.
20592 2003-11-12 Jackson Harper <jackson@ximian.com>
20594 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20595 system directory. Also use the full file name so users can
20596 libraries names mscorlib-o-tron.dll in a non system dir.
20598 2003-11-10 Martin Baulig <martin@ximian.com>
20600 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20601 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20602 calling `ResolveType()' on them, directly assign their `Type'.
20604 2003-11-08 Martin Baulig <martin@ximian.com>
20606 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20607 return value and the `out parent' parameter.
20608 (TypeContainer.DefineType): Moved the CS0644 check into
20609 GetClassBases(). Don't pass the interface types to the
20610 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20611 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20613 * ecore.cs (TypeExpr.IsAttribute): New property.
20614 (TypeExpr.GetInterfaces): New method.
20616 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20617 TypeExpr instead of a Type.
20618 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20619 (Interface.DefineType): Don't pass the interface types to the
20620 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20621 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20623 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20624 instead of a `Type[]'.
20625 (TypeManager.RegisterBuilder): Likewise.
20626 (TypeManager.AddUserInterface): Likewise.
20627 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20628 `Type[]' and also return a `TypeExpr[]'.
20629 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20631 2003-11-08 Martin Baulig <martin@ximian.com>
20633 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20636 2003-11-08 Martin Baulig <martin@ximian.com>
20638 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20639 TypeManager.ResolveExpressionTypes().
20641 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20642 instead of an Expression.
20643 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20644 (TypeExpression): New public class; formerly known as `TypeExpr'.
20646 * expression.cs (ComposedCast): Derive from TypeExpr.
20648 * typemanager.cs (TypeManager.system_*_expr): These are now
20649 TypExpr's instead of Expression's.
20650 (TypeManager.ResolveExpressionTypes): New public static function;
20651 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20654 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20656 * expression.cs (New.DoResolve): Do not dereference value that
20657 might be a null return.
20659 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20660 sure that the constant value has the right type. Fixes an
20661 unreported bug, similar to 50425.
20663 * const.cs (Const.LookupConstantValue): Call
20664 ImplicitStandardConversionExists before doing a conversion to
20665 avoid havng the TypeManager.ChangeType do conversions.
20667 Reduced the number of casts used
20669 (Const.ChangeType): New routine to enable reuse of the constant
20670 type changing code from statement.
20672 * typemanager.cs (ChangeType): Move common initialization to
20673 static global variables.
20677 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20678 every value type to go through, even if it was void. Fix that.
20680 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20681 character of the define, and the is_identifier_part_character for
20682 the rest of the string.
20684 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20686 * expression.cs (UnaryMutator.EmitCode): When I updated
20687 LocalVariableReference.DoResolve, I overdid it, and dropped an
20688 optimization done on local variable references.
20690 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20692 * ecore.cs: Convert the return from Ldlen into an int.
20694 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20696 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20697 the accessibility, this is a special case for toplevel non-public
20698 classes (internal for instance).
20700 2003-10-20 Nick Drochak <ndrochak@gol.com>
20702 * ecore.cs: Fix typo and build. Needed another right paren.
20704 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20706 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20707 `internal' case regular and protected, but not allowing protected
20708 to be evaluated later. Bug 49840
20710 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20712 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20713 to kb.Nlast, and not the kb.nFirst to isolate the switch
20716 Extract the underlying type, so enumerations of long/ulong are
20717 treated like long/ulong.
20719 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20721 * expression.cs (New): Overload the meaning of RequestedType to
20722 track the possible creation of the NewDelegate type, since
20723 DoResolve is invoked more than once for new constructors on field
20726 See bugs: #48800 and #37014
20728 * cs-parser.jay (declare_local_constants): Take an arraylist
20729 instead of a single constant.
20731 (local_constant_declaration): It should take a
20732 constant_declarators, not a constant_declarator. Fixes 49487
20734 * convert.cs: Fix error report.
20736 2003-10-13 Jackson Harper <jackson@ximian.com>
20738 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20741 2003-10-09 Martin Baulig <martin@ximian.com>
20743 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20745 (MethodCore.DoDefineParameters): Removed the TypeContainer
20746 argument; use the DeclSpace which was passed to the .ctor instead.
20747 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20748 TypeContainer; we only need a DeclSpace here.
20750 2003-10-09 Martin Baulig <martin@ximian.com>
20752 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20754 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20755 EmitContext's .ctor.
20757 2003-10-09 Martin Baulig <martin@ximian.com>
20759 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20760 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20761 AsAccessible(), moved them as well.
20763 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20765 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20767 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20769 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20771 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20772 generation for >=, as spotted by Paolo, bug 48679.
20773 Patch from David Waite.
20775 * cs-tokenizer.cs: Add handling for #pragma.
20777 * cs-parser.jay: Allow for both yield and yield return in the
20778 syntax. The anti-cobolization of C# fight will go on!
20780 * class.cs (TypeBuilder.DefineType): Catch error condition here
20781 (Parent.DefineType erroring out and returning null).
20783 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20784 coping with enumerations variables, we were mistakenly processing
20785 them as a regular value type instead of built-in types. Fixes the
20788 * typemanager.cs (IsBuiltinOrEnum): New method.
20790 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20792 * cs-parser.jay: Upgrade: yield now needs the return clause.
20794 2003-09-19 Martin Baulig <martin@ximian.com>
20796 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20797 `MemberCache parent' argument. Normally, an interface doesn't
20798 have a parent type except System.Object, but we use this in gmcs
20799 for generic type parameters.
20801 2003-09-18 Martin Baulig <martin@ximian.com>
20803 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20804 on `type.IsInterface'; don't check whether the type has a parent
20805 to determine whether it's an interface.
20807 2003-09-15 Martin Baulig <martin@ximian.com>
20809 * class.cs (TypeContainer.DefineType): Added an error flag to
20810 avoid reporting duplicate CS0146's ("class definition is
20813 * driver.cs (Driver.MainDriver): Abort if
20814 RootContext.ResolveTree() reported any errors.
20816 2003-09-07 Martin Baulig <martin@ximian.com>
20818 * report.cs (Error, Warning): Added overloaded versions which take
20819 a `params object[] args' and call String.Format().
20821 2003-09-07 Martin Baulig <martin@ximian.com>
20823 * decl.cs (DeclSpace..ctor): Don't call
20824 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20825 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20826 (DeclSpace.RecordDecl): New method.
20828 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20830 2003-09-02 Ravi Pratap <ravi@ximian.com>
20832 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20833 value attributes to be applied to ParameterBuilders.
20835 * class.cs (MethodCore.LabelParameters): Make static and more
20836 generic so that it can be used from other places - like interface
20837 methods, for instance.
20839 * interface.cs (Interface.Emit): Call LabelParameters before
20840 emitting attributes on the InterfaceMethod.
20842 2003-08-26 Martin Baulig <martin@ximian.com>
20844 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20845 resolving aliases; fixes #47927.
20847 2003-08-26 Martin Baulig <martin@ximian.com>
20849 * statement.cs (Using.DoResolve): This is internally emitting a
20850 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20851 do not always return. Fixes #47681.
20853 2003-08-26 Martin Baulig <martin@ximian.com>
20855 * decl.cs (MemberCore): Moved WarningNotHiding(),
20856 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20858 (AdditionResult): Make this nested in DeclSpace.
20859 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20860 argument; call NamespaceEntry.Define() unless we're nested in a
20863 * namespace.cs (Namespace.DefineName): New public function. This
20864 is called from DeclSpace's .ctor to add
20865 (Namespace.Lookup): Include DeclSpaces in the lookup.
20867 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20869 * const.cs (Const): Derive from MemberBase, not MemberCore.
20871 2003-08-25 Martin Baulig <martin@ximian.com>
20873 * convert.cs (Convert.ExplicitReferenceConversion): When
20874 converting from an interface type to a class, unbox if the target
20875 type is a struct type. Fixes #47822.
20877 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20879 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20882 2003-08-22 Martin Baulig <martin@ximian.com>
20884 * class.cs (TypeManager.DefineType): When defining a nested type,
20885 call DefineType() on our parent; fixes #47801.
20887 2003-08-22 Martin Baulig <martin@ximian.com>
20889 * class.cs (MethodData.Define): While checking if a method is an
20890 interface implementation, improve the test a bit more to fix #47654.
20892 2003-08-22 Martin Baulig <martin@ximian.com>
20894 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20895 correctly; fixes #47722.
20897 2003-08-22 Martin Baulig <martin@ximian.com>
20899 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20900 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20902 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20904 2003-08-22 Martin Baulig <martin@ximian.com>
20906 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20907 can only be assigned in static constructors. Fixes #47161.
20909 2003-08-22 Martin Baulig <martin@ximian.com>
20911 Rewrote and improved the flow analysis code.
20913 * flowbranching.cs (FlowBranching): Make this class abstract.
20914 (FlowBranching.CreateBranching): New static function to create a
20915 new flow branching.
20916 (FlowBranchingBlock, FlowBranchingException): New classes.
20917 (FlowBranching.UsageVector.Type): New public readonly field.
20918 (FlowBranching.UsageVector.Breaks): Removed the setter.
20919 (FlowBranching.UsageVector.Returns): Removed the setter.
20920 (FlowBranching.UsageVector): Added Break(), Return(),
20921 NeverReachable() and Throw() methods to modify the reachability.
20922 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20923 done by FlowBranching.Merge().
20924 (FlowBranching.UsageVector.MergeChild): New method; merges the
20925 merge result into the current vector.
20926 (FlowBranching.Merge): New abstract method to merge a branching.
20928 2003-08-12 Martin Baulig <martin@ximian.com>
20930 * expression.cs (Indirection.CacheTemporaries): Create the
20931 LocalTemporary with the pointer type, not its element type.
20933 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20935 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20936 token was a keyword or not.
20938 Add `error' options where an IDENTIFIER was expected; Provide
20939 CheckToken and CheckIdentifierToken convenience error reporting
20942 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20944 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20945 NameSpaceEntry NameSpaceEntry.
20947 (LookupInterfaceOrClass): Avoid creating a full qualified name
20948 from namespace and name: avoid doing lookups when we know the
20949 namespace is non-existant. Use new Tree.LookupByNamespace which
20950 looks up DeclSpaces based on their namespace, name pair.
20952 * driver.cs: Provide a new `parser verbose' to display the
20953 exception thrown during parsing. This is turned off by default
20954 now, so the output of a failure from mcs is more graceful.
20956 * namespace.cs: Track all the namespaces defined in a hashtable
20959 (IsNamespace): New method
20961 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20963 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20964 we know that we need to concatenate (full typename can never be
20969 * statement.cs: Use a bitfield; Do not initialize to null things
20970 which are done by the constructor by default.
20972 * cs-parser.jay: bug fix, parameter was 4, not 3.
20974 * expression.cs: Just use the property;
20976 * statement.cs: No need for GetVariableInfo method.
20978 2003-08-08 Martin Baulig <martin@ximian.com>
20980 * flowanalysis.cs (FlowReturns): This is now nested in the
20981 `FlowBranching' class.
20982 (MyBitVector): Moved this here from statement.cs.
20983 (FlowBranching.SiblingType): New enum type.
20984 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20986 2003-08-07 Martin Baulig <martin@ximian.com>
20988 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20989 `FlowBranching' class and called `BranchingType'.
20991 2003-08-07 Martin Baulig <martin@ximian.com>
20993 * flowanalysis.cs: Moved all the control flow analysis code into
20996 2003-08-07 Martin Baulig <martin@ximian.com>
20998 * assign.cs (Assign.DoResolve): `target' must either be an
20999 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21002 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21004 * expression.cs (BinaryMethod): This kind of expression is created by the
21005 Binary class if it determines that the operator has to be handled
21008 (BinaryDelegate): This kind of expression is created if we are
21009 dealing with a + or - operator on delegates.
21011 (Binary): remove method, argumetns, and DelegateOperator: when
21012 dealing with methods,
21014 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21016 * statement.cs (Block): use bitfields for the three extra booleans
21017 we had in use. Remove unused topblock parameter.
21019 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21021 * assign.cs: Drop extra unneeded tests.
21023 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21025 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21027 * statement.cs (Foreach): Use VariableStorage instead of
21030 * codegen.cs (VariableStorage): New class used by clients that
21031 require a variable stored: locals or fields for variables that
21032 need to live across yield.
21034 Maybe provide a convenience api for EmitThis+EmitLoad?
21036 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21039 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21041 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21042 RemapParameterLValue): New methods that are used to turn a
21043 precomputed FieldInfo into an expression like this:
21047 The idea is to use this instead of making LocalVariableReference
21048 have more than one meaning.
21050 * cs-parser.jay: Add error production to BASE.
21052 * ecore.cs: Deal with TypeManager.GetField returning null, which
21053 is now a valid return value.
21055 (FieldExprNoAddress): New expression for Fields whose address can
21058 * expression.cs (LocalVariableReference): During the resolve
21059 phases, create new expressions if we are in a remapping context.
21060 Remove code that dealt with remapping here.
21062 (ParameterReference): same.
21064 (ProxyInstance): New expression, like the `This' expression, but
21065 it is born fully resolved. We know what we are doing, so remove
21066 the errors that are targeted to user-provided uses of `this'.
21068 * statement.cs (Foreach): our variable is now stored as an
21069 Expression; During resolution, follow the protocol, dont just
21070 assume it will return this.
21072 2003-08-06 Martin Baulig <martin@ximian.com>
21074 * support.cs (SeekableStreamReader.cs): New public class.
21076 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21077 SeekableStreamReader instead of the normal StreamReader.
21079 2003-08-04 Martin Baulig <martin@ximian.com>
21081 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21082 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21083 deambiguate casts and delegate invocations.
21084 (parenthesized_expression): Use the new tokens to ensure this is
21085 not a cast of method invocation.
21087 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21088 when reading a `)' and Deambiguate_CloseParens () was previously
21091 * expression.cs (ParenthesizedExpression): New class. This is
21092 just used for the CS0075 test.
21093 (Binary.DoResolve): Check for CS0075.
21095 2003-07-29 Ravi Pratap <ravi@ximian.com>
21097 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21098 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21099 reference comparison.
21101 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21102 examine the ReturnType for equality - this is necessary in the
21103 cases of implicit and explicit operators whose signature also
21104 includes the return type.
21106 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21108 * namespace.cs: Cache the result of the namespace computation,
21109 instead of computing it every time.
21111 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21113 * decl.cs: Use a global arraylist that we reuse over invocations
21114 to avoid excesive memory consumption. Reduces memory usage on an
21115 mcs compile by one meg (45 average).
21117 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21118 private, work around that.
21120 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21122 * literal.cs (IntLiteral): Define Zero and One static literals.
21124 * cs-parser.jay (integer_literal): use static literals to reduce
21125 memory usage for the most used literals (0, 1 and -1). 211kb
21126 reduced in memory usage.
21128 Replace all calls to `new ArrayList' with `new
21129 ArrayList(4)' which is a good average number for most allocations,
21130 and also requires only 16 bytes of memory for its buffer by
21133 This reduced MCS memory usage in seven megabytes for the RSS after
21136 2003-07-28 Ravi Pratap <ravi@ximian.com>
21138 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21139 handle params methods the correct way by forming only one
21140 applicable set with params and normal methods in them. Earlier we
21141 were looking at params methods only if we found no normal methods
21142 which was not the correct thing to do.
21144 (Invocation.BetterFunction): Take separate arguments indicating
21145 when candidate and the best method are params methods in their
21148 This fixes bugs #43367 and #46199.
21150 * attribute.cs: Documentation updates.
21152 (CheckAttribute): Rename to CheckAttributeTarget.
21153 (GetValidPlaces): Rename to GetValidTargets.
21155 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21156 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21160 2003-07-28 Martin Baulig <martin@ximian.com>
21162 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21163 name when looking up the base class of a nested class. Fixes #46977.
21165 2003-07-26 Martin Baulig <martin@ximian.com>
21167 * expression.cs (Indexers.Indexer): New nested struct; contains
21168 getter, setter and the indexer's type.
21169 (Indexers.Properties): This is now an ArrayList of
21170 Indexers.Indexer's.
21171 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21172 indexer doesn't have any getters.
21174 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21175 for embedded property and indexer assignments.
21177 2003-07-26 Martin Baulig <martin@ximian.com>
21179 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21180 preprocessor directive is not the first non-whitespace character
21183 2003-07-26 Martin Baulig <martin@ximian.com>
21185 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21186 namespace parsing, follow the spec more closely.
21188 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21189 NamespaceEntry.Lookup().
21191 2003-07-25 Martin Baulig <martin@ximian.com>
21193 * MethodCore.cs (OverridesSomething): New public field; it's set
21194 from TypeContainer.DefineMembers if this method overrides
21195 something (which doesn't need to be a method). Fix #39462.
21197 2003-07-25 Ravi Pratap <ravi@ximian.com>
21199 * typemanager.cs (GetMembers): Ensure that the list of members is
21200 reversed. This keeps things in sync.
21202 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21203 find an AttributeUsage attribute.
21205 * expression.cs (Invocation.OverloadResolve): Perform the check
21206 which disallows Invoke to be directly called on a Delegate.
21208 (Error_InvokeOnDelegate): Report error cs1533.
21210 2003-07-25 Martin Baulig <martin@ximian.com>
21212 * expression.cs (Indexers.GetIndexersForType): Only look in the
21213 interface hierarchy if the requested type is already an
21214 interface. Fixes #46788 while keeping #46502 fixed.
21216 2003-07-25 Martin Baulig <martin@ximian.com>
21218 * class.cs (TypeContainer.DefineMembers): Check whether all
21219 readonly fields have been assigned and report warning CS0649 if
21222 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21225 2003-07-24 Ravi Pratap <ravi@ximian.com>
21227 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21228 returned from GetMethods to make things consistent with the
21229 assumptions MCS makes about ordering of methods.
21231 This should comprehensively fix bug #45127 and it does :-)
21233 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21234 ordering is actually reverse.
21236 * Clean up some debug messages I left lying around.
21238 * interface.cs (Populate*): Get rid of code which emits attributes
21239 since the stage in which we emit attributes is the 'Emit' stage,
21240 not the define stage.
21242 (Emit): Move attribute emission for interface members here.
21244 2003-07-22 Ravi Pratap <ravi@ximian.com>
21246 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21247 closely: we eliminate methods in base types when we have an
21248 applicable method in a top-level type.
21250 Please see section 14.5.5.1 for an exact description of what goes
21253 This fixes bug #45127 and a host of other related to corlib compilation.
21255 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21256 array is the method corresponding to the top-level type (this is
21257 because of the changes made to icall.c) so we change this
21260 (MethodGroupExpr.Name): This too.
21262 * typemanager.cs (GetElementType): New method which does the right
21263 thing when compiling corlib.
21265 * everywhere: Make use of the above in the relevant places.
21267 2003-07-22 Martin Baulig <martin@ximian.com>
21269 * cs-parser.jay (invocation_expression): Moved
21270 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21271 `cast_expression', but create a InvocationOrCast which later
21272 resolves to either an Invocation or a Cast.
21274 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21275 method; call this before EmitStatement() to make sure that this
21276 expression can be used as a statement.
21278 * expression.cs (InvocationOrCast): New class; resolves to either
21279 an Invocation or a Cast.
21281 * statement.cs (StatementExpression): Call ResolveStatement() on
21282 the ExpressionStatement before emitting it.
21284 2003-07-21 Martin Baulig <martin@ximian.com>
21286 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21287 `ref' and `out' attributes match; fixes #46220.
21288 (MemberAccess.ResolveMemberAccess): You can't reference a type
21289 through an expression; fixes #33180.
21290 (Indexers.GetIndexersForType): Don't return the indexers from
21291 interfaces the class implements; fixes #46502.
21293 2003-07-21 Martin Baulig <martin@ximian.com>
21295 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21296 CS0661 checks; fixes bug #30442.
21298 2003-07-21 Martin Baulig <martin@ximian.com>
21300 * decl.cs (AdditionResult): Added `Error'.
21302 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21304 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21305 makes cs0031.cs actually work.
21307 2003-07-20 Martin Baulig <martin@ximian.com>
21309 * namespace.cs: Fixed that bug which caused a crash when compiling
21310 the debugger's GUI.
21312 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21314 * typemanager.cs (LookupTypeReflection): Never expose types which
21315 are NotPublic, NestedPrivate, NestedAssembly, or
21316 NestedFamANDAssem. We used to return these, and later do a check
21317 that would report a meaningful error, but the problem is that we
21318 would not get the real match, if there was a name override.
21320 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21322 * namespace.cs (Namespace, Name): Do not compute the namespace
21323 name dynamically, compute it in the constructor. This reduced
21324 memory usage by 1697 KB.
21326 * driver.cs: Use --pause to pause at the end.
21328 2003-07-17 Peter Williams <peter@newton.cx>
21330 * Makefile: Change the name of the test target so that it doesn't
21331 conflict with the recursive test target.
21333 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21335 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21336 AddressOf): Do not use EmitThis, that was wrong, use the actual
21339 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21341 * class.cs (MethodData.Define): While checking if a method is an
21342 interface implementation, improve the test: If we are not public
21343 (use new test here: use the computed MethodAttributes directly,
21344 instead of the parsed modifier flags) check if the `implementing'
21345 method comes from an interface or not.
21347 * pending.cs (VerifyPendingMethods): Slightly better error
21350 * makefile: add test target that does the mcs bootstrap.
21352 2003-07-16 Ravi Pratap <ravi@ximian.com>
21354 * interface.cs (Define): Do nothing here since there are no
21355 members to populate etc. Move the attribute emission out of here
21356 since this was just totally the wrong place to put it. Attribute
21357 application happens during the 'Emit' phase, not in the 'Define'
21360 (Emit): Add this method and move the attribute emission here
21362 * rootcontext.cs (EmitCode): Call the Emit method on interface
21365 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21367 * expression.cs (OverloadResolve): Report error only if Location
21368 is not 'Null' which means that there was a probe going on.
21370 2003-07-14 Martin Baulig <martin@ximian.com>
21372 * expression.cs (ConditionalLogicalOperator): New public class to
21373 implement user defined conditional logical operators.
21374 This is section 14.11.2 in the spec and bug #40505.
21376 2003-07-14 Martin Baulig <martin@ximian.com>
21378 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21380 2003-07-14 Martin Baulig <martin@ximian.com>
21382 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21384 * ecore.cs (IVariable.VerifyFixed): New interface method.
21386 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21387 operator, check whether the variable is actually fixed. Fixes bug
21388 #36055. Set a variable definitely assigned when taking its
21389 address as required by the spec.
21391 * statement.cs (LocalInfo.IsFixed): New field.
21392 (LocalInfo.MakePinned): Set `IsFixed' to true.
21394 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21396 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21397 for .ctors, ensure that we only ask for members declared in the
21398 attribute type (BindingFlags.DeclaredOnly).
21402 * expression.cs (Error_WrongNumArguments): Report error 1501
21403 correctly the way CSC does.
21405 2003-07-13 Martin Baulig <martin@ximian.com>
21407 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21408 lookup on the fully qualified name, to make things like "X.X" work
21409 where "X.X" is a fully qualified type name, but we also have a
21410 namespace "X" in the using list. Fixes #41975.
21412 2003-07-13 Martin Baulig <martin@ximian.com>
21414 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21415 function. If we're a CompoundAssign, we need to create an embedded
21416 CompoundAssign, not an embedded Assign.
21417 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21420 2003-07-13 Martin Baulig <martin@ximian.com>
21422 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21423 work to fix bug #46088.
21425 2003-07-13 Ravi Pratap <ravi@ximian.com>
21427 * class.cs (Operator.Emit): Do not emit attributes here - it is
21428 taken care of by the Method class that we delegate too. This takes
21429 care of bug #45876.
21431 2003-07-10 Martin Baulig <martin@ximian.com>
21433 * expression.cs (TypeOfVoid): New class.
21434 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21436 2003-07-10 Martin Baulig <martin@ximian.com>
21438 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21441 2003-07-10 Martin Baulig <martin@ximian.com>
21443 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21444 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21446 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21448 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21450 2003-07-10 Martin Baulig <martin@ximian.com>
21452 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21453 of decimal. Fixes #42850.
21455 NOTE: I also fixed the created byte blob, but this doesn't work on
21456 the MS runtime and csc never produces any byte blobs for decimal
21459 2003-07-10 Martin Baulig <martin@ximian.com>
21461 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21462 structs; fixes #32068.
21463 (Block.AddChildVariableNames): Fixed #44302.
21465 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21467 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21469 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21471 * attribute.cs: And this test is onger needed.
21473 2003-07-08 Martin Baulig <martin@ximian.com>
21475 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21476 inaccessible types. Fixes #36313.
21478 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21480 * namespace.cs (NamespaceEntry): Create implicit entries for all
21481 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21482 implicit entries for N1.N2 and N1.
21484 2003-07-08 Martin Baulig <martin@ximian.com>
21486 Rewrote the handling of namespaces to fix a lot of the issues
21487 wrt. `using' aliases etc.
21489 * namespace.cs (Namespace): Splitted this class into a
21490 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21492 * typemanager.cs (TypeManager.IsNamespace): Removed.
21493 (TypeManager.ComputeNamespaces): Only compute namespaces from
21494 loaded assemblies here, not the namespaces from the assembly we're
21495 currently compiling.
21497 2003-07-08 Martin Baulig <martin@ximian.com>
21499 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21501 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21503 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21506 I thought about the memory savings here, but LookupTypeReflection
21507 is used under already very constrained scenarios. Compiling
21508 corlib or mcs only exposes one hit, so it would not really reduce
21509 any memory consumption.
21511 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21513 * typemanager.cs: fixes bug #45889 by only adding public types from
21514 other assemblies to the list of known types.
21516 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21518 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21519 on the type we resolved.
21521 2003-07-05 Martin Baulig <martin@ximian.com>
21523 * pending.cs (PendingImplementation.ParentImplements): Don't
21524 create the proxy if the parent is abstract.
21526 * class.cs (TypeContainer.DefineIndexers): Process explicit
21527 interface implementations first. Fixes #37714.
21529 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21531 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21532 defined recursively; but since we modify the input parameters
21533 (left is set to `this' temporarily), we reset this value if the
21534 left_is_explicit is false, which gives the original semantics to
21537 * literal.cs (NullPointer): new class used to represent a null
21538 literal in a pointer context.
21540 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21541 type is a pointer, use a NullPointer object instead of a
21542 NullLiteral. Closes 43687
21544 (ExplicitConversion): Convert pointer values using
21545 the conv opcode to the proper type.
21547 * ecore.cs (New): change ValueTypeVariable property into a method,
21548 that returns whether the valuetype is suitable for being used.
21550 * expression.cs (Binary.DoNumericPromotions): Only return if we
21551 the int constant was a valid uint, and we can return both left and
21552 right as uints. If not, we continue processing, to trigger the
21553 type conversion. This fixes 39018.
21555 * statement.cs (Block.EmitMeta): During constant resolution, set
21556 the CurrentBlock property on the emitcontext, so that we resolve
21557 constants propertly.
21559 2003-07-02 Martin Baulig <martin@ximian.com>
21561 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21562 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21564 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21565 than emitting it here.
21567 * statement.cs: Fixed some more flow analysis bugs.
21569 2003-07-02 Martin Baulig <martin@ximian.com>
21571 * class.cs (MethodData.Define): When implementing interface
21572 methods, set Final unless we're Virtual.
21574 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21575 check work for interface methods.
21577 2003-07-01 Martin Baulig <martin@ximian.com>
21579 * ecore.cs (EmitContext.This): Replaced this property with a
21580 GetThis() method which takes a Location argument. This ensures
21581 that we get the correct error location for a CS0188.
21583 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21585 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21586 ImplicitStandardConversion.
21588 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21590 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21592 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21595 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21597 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21600 (MethodData.Define): Turn off initlocals for unsafe methods.
21602 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21604 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21605 complete; Fixes #37521.
21607 * delegate.cs: Use Modifiers.TypeAttr to compute the
21608 TypeAttributes, instead of rolling our own. This makes the flags
21609 correct for the delegates.
21611 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21613 * class.cs (Constructor.Define): Set the private flag for static
21614 constructors as well.
21616 * cs-parser.jay (statement_expression): Set the return value to
21617 null, to avoid a crash when we catch an error.
21619 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21621 * cs-parser.jay: Applied patch from Jackson that adds support for
21622 extern and unsafe modifiers to destructor declarations.
21624 * expression.cs: Report error 21 if the user is trying to index a
21627 * driver.cs: Add an error message, suggested by the bug report.
21629 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21630 if we do not have a ": this ()" constructor initializer. Fixes 45149
21632 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21634 * namespace.cs: Add some information to reduce FAQs.
21636 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21638 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21639 underlying enumeration types. Fixes #43915.
21641 * expression.cs: Treat ushort/short as legal values to be used in
21642 bitwise operations.
21644 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21646 * delegate.cs: transfer custom attributes for paramenters from
21647 the delegate declaration to Invoke and BeginInvoke.
21649 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21651 * attribute.cs: handle custom marshalers and emit marshal info
21654 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21656 * makefile.gnu: Added anonymous.cs to the compiler sources.
21658 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21660 * iterators.cs: Change the name of the proxy class to include two
21663 * cs-parser.jay: Update grammar to include anonymous methods.
21665 * anonymous.cs: new file.
21667 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21669 * class.cs (Field.Define): Add missing test for pointers and
21672 2003-05-27 Ravi Pratap <ravi@ximian.com>
21674 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21675 we use the stobj opcode.
21677 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21678 since it wasn't the correct fix.
21680 It still is puzzling that we are required to use stobj for IntPtr
21681 which seems to be a ValueType.
21683 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21685 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21686 during regular simple name resolution. Now, the trick is that
21687 instead of returning for processing the simplename, we do a
21688 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21689 contextual lookup type). If a match is found, return that, if
21690 not, return for further composition.
21692 This fixes long-standing 30485.
21694 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21695 using the address to initialize an object, do an Stobj instead of
21696 using the regular Stelem.
21698 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21699 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21700 Because if we are a BaseIndexerAccess that value will be true.
21703 * statement.cs (GotoCase.Resolve): Return after reporting an
21704 error, do not attempt to continue.
21706 * expression.cs (PointerArithmetic.Emit): If our operand is a
21707 long, convert our constants to match the operand before
21708 multiplying. Convert to I type before adding. Fixes 43670.
21710 2003-05-14 Ravi Pratap <ravi@ximian.com>
21712 * enum.cs (ImplicitConversionExists) : Rename to
21713 ImplicitEnumConversionExists to remove ambiguity.
21715 * ecore.cs (NullCast): New type of cast expression class which
21716 basically is very similar to EmptyCast with the difference being
21717 it still is a constant since it is used only to cast a null to
21719 (eg. (string) null)
21721 * convert.cs (ImplicitReferenceConversion): When casting a null
21722 literal, we return a NullCast.
21724 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21725 should be around anymore.
21727 The renaming (reported was slightly wrong). Corrections:
21729 ConvertImplicitStandard -> ImplicitConversionStandard
21730 ConvertExplicitStandard -> ExplicitConversionStandard
21732 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21733 before passing them in !
21735 * convert.cs (ImplicitConversionStandard): When comparing for
21736 equal expr and target types, ensure that expr is not a
21739 In general, we must not be checking (expr_type ==
21740 target_type) in the top level conversion methods
21741 (ImplicitConversion, ExplicitConversion etc). This checking is
21742 done in the methods that they delegate to.
21744 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21746 * convert.cs: Move Error_CannotConvertType,
21747 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21748 ImplicitNumericConversion, ImplicitConversionExists,
21749 ImplicitUserConversionExists, StandardConversionExists,
21750 FindMostEncompassedType, FindMostSpecificSource,
21751 FindMostSpecificTarget, ImplicitUserConversion,
21752 ExplicitUserConversion, GetConversionOperators,
21753 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21754 TryImplicitIntConversion, Error_CannotConvertImplicit,
21755 ConvertImplicitRequired, ConvertNumericExplicit,
21756 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21757 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21760 Perform the following renames:
21762 StandardConversionExists -> ImplicitStandardConversionExists
21763 ConvertImplicit -> ImplicitConversion
21764 ConvertImplicitStandard -> ImplicitStandardConversion
21765 TryImplicitIntConversion -> ImplicitIntConversion
21766 ConvertImplicitRequired -> ImplicitConversionRequired
21767 ConvertNumericExplicit -> ExplicitNumericConversion
21768 ConvertReferenceExplicit -> ExplicitReferenceConversion
21769 ConvertExplicit -> ExplicitConversion
21770 ConvertExplicitStandard -> ExplicitStandardConversion
21772 2003-05-19 Martin Baulig <martin@ximian.com>
21774 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21775 (TypeInfo): Added support for structs having structs as fields.
21777 * ecore.cs (FieldExpr): Implement IVariable.
21778 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21779 VariableInfo for the field.
21781 2003-05-18 Martin Baulig <martin@ximian.com>
21783 * expression.cs (This.DoResolve): Report a CS0027 if we're
21784 emitting a field initializer.
21786 2003-05-18 Martin Baulig <martin@ximian.com>
21788 * expression.cs (This.ResolveBase): New public function.
21789 (This.DoResolve): Check for CS0188.
21791 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21794 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21795 `instance_expression' to null if we don't have any non-static
21798 2003-05-18 Martin Baulig <martin@ximian.com>
21800 Reworked the way how local variables and parameters are handled by
21801 the flow analysis code.
21803 * statement.cs (TypeInfo, VariableMap): New public classes.
21804 (VariableInfo): New public class. This is now responsible for
21805 checking whether a variable has been assigned. It is used for
21806 parameters and local variables.
21807 (Block.EmitMeta): Take the InternalParameters as argument; compute
21808 the layout of the flow vectors here.
21809 (Block.LocalMap, Block.ParameterMap): New public properties.
21810 (FlowBranching): The .ctor doesn't get the InternalParameters
21811 anymore since Block.EmitMeta() now computes the layout of the flow
21813 (MyStructInfo): This class is now known as `StructInfo' and nested
21814 in `TypeInfo'; we don't access this directly anymore.
21816 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21817 property and removed IsAssigned(), IsFieldAssigned(),
21818 SetAssigned() and SetFieldAssigned(); we now call them on the
21819 VariableInfo so we don't need to duplicate this code everywhere.
21821 * expression.cs (ParameterReference): Added `Block block' argument
21823 (LocalVariableReference, ParameterReference, This): The new
21824 VariableInfo class is now responsible for all the definite
21827 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21828 IsParameterAssigned, SetParameterAssigned): Removed.
21830 2003-05-18 Martin Baulig <martin@ximian.com>
21832 * typemanager.cs (InitCoreTypes): Try calling
21833 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21834 the 3-args-version. Corlib now also needs our `void_type'.
21835 (GetMethod): Added overloaded version which takes an optional
21836 `bool report_errors' to allow lookups of optional methods.
21838 2003-05-12 Martin Baulig <martin@ximian.com>
21840 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21841 only used for locals and not for parameters.
21843 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21845 * support.cs (InternalParameters.ParameterType): Return the
21846 ExternalType of the parameter.
21848 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21851 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21853 * class.cs (MethodData.Define): Do not set the `newslot' on
21854 interface members, if they are also flagged as "override".
21856 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21857 better code for ++i and i++. This only works for static fields
21858 and local variables.
21860 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21861 want to pull the DeclSpace out of the builder_to_declspace instead
21862 of the TypeBuilder (like in TypeContainer.FindMembers).
21864 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21865 instead of LookupTypeContainer. Fixes the crash on .NET for
21866 looking up interface members.
21868 * const.cs: Create our own emit context during the Definition
21869 stage, so that constants are evaluated in the proper context, when
21870 a recursive definition happens.
21872 2003-05-11 Martin Baulig <martin@ximian.com>
21874 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21875 new block for a switch section.
21876 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21877 the adding/lookup in the switch block. Fixes #39828.
21879 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21881 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21882 functionality: I needed to convert the data after I had performed
21883 the add/sub operation into the operands type size.
21885 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21886 pass the type for the box operation, otherwise the resulting
21887 object would have been of type object.
21889 (BoxedCast): Add constructor to specify the type to box as.
21891 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21893 * iterators.cs: I was reusing the `count' variable inadvertently,
21894 take steps to not allow this to happen.
21896 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21898 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21899 by creating an array at the point where the params starts and
21900 putting all those arguments there, then adjusting the size of the
21903 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21905 * expression.cs (New.AddressOf): Implement interface
21906 IMemoryLocation. This is used when the `new' operator is used in
21907 the context of an invocation to a method on a value type.
21909 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21912 * namespace.cs: Also check the using aliases here.
21914 * driver.cs: Move the test for using validity after the types have
21915 been entered, so we do a single pass that also includes the using
21918 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21919 in the regular case. CreateSiblingForFinally is doing extra
21922 * attribute.cs (GetAttributeArgumentExpression): Store the result
21923 on an out value, and use the return value to indicate failure
21924 instead of using null (which is a valid return for Constant.GetValue).
21926 * statement.cs: Perform the analysis flow for the increment
21927 portion after the statement, because this will be the real flow of
21928 execution. Fixes #42385
21930 * codegen.cs (EmitContext.EmitArgument,
21931 EmitContext.EmitStoreArgument): New helper functions when the
21932 RemapToProxy flag is set.
21934 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21937 Add support for remapping parameters.
21939 * iterators.cs: Propagate parameter values; Store parameter
21940 values in the proxy classes.
21942 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21944 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21945 need a proxy reference; I do not know what I was thinking
21947 * cs-parser.jay (constructor_initializer): catch another error,
21948 and display nice message.
21950 (field_declaration): catch void field declaration
21951 to flag a better error.
21953 * class.cs (MemberBase.CheckBase): Report an error instead of a
21954 warning if a new protected member is declared in a struct.
21955 (Field.Define): catch the error of readonly/volatile.
21957 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21959 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21960 volatile variable is taken
21962 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21964 * statement.cs (Fixed.Resolve): Report an error if we are not in
21967 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21969 * typemanager.cs: reuse the code that handles type clashes for
21970 delegates and enumerations.
21972 * class.cs (Report28): Always report.
21974 * expression.cs (EncodeAsAttribute): Allow nulls here.
21976 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21978 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21979 the functionality for testing whether an expression is valid for
21980 an attribute here. Also handle the case of arrays of elements
21983 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21984 encoding a linear array into an array of objects that are suitable
21985 to be passed to an CustomAttributeBuilder.
21987 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21989 * ecore.cs: (FieldExpr): Handle field remapping here.
21991 * iteratators.cs: Pass the instance variable (if the method is an
21992 instance method) to the constructors, so we can access the field
21993 variables on the class.
21995 TODO: Test this with structs. I think the THIS variable on
21996 structs might have to be a pointer, and not a refenrece
21998 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22000 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22001 local variables to fields in a proxy class.
22003 * iterators.cs (PopulateProxy): Rename our internal fields to
22005 Create a <THIS> field if we are an instance method, so we can
22006 reference our parent container variables.
22007 (MapVariable): Called back from the EmitContext code to enter a
22008 new variable to field mapping into the proxy class (we just create
22012 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22013 for using the remapped locals to fields.
22015 I placed the code here, because that gives the same semantics to
22016 local variables, and only changes the Emit code.
22018 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22019 statements inside iterators.
22020 (VariableInfo): Add a FieldBuilder for the cases when we are
22021 remapping local variables to fields in a proxy class
22023 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22024 current_block != null.
22026 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22027 not cope with strings, as it has been moved to the
22028 TableSwitchEmit. Fixed bug in switch generation.
22030 * expression.cs (New.DoResolve): Provide more context for the user
22031 when reporting an error.
22033 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22036 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22037 check the permissions for it. Note than in a type-resolution
22038 context the check was already present in DeclSpace.ResolveType,
22039 but was missing from the MemberAccess.
22041 (ArrayCreation.CheckIndices): warn if the user has
22042 more nested levels of expressions, but there are no more
22043 dimensions specified. Avoids crash on bug 41906.
22045 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22047 * statement.cs (Block): replace Implicit bool, for a generic
22049 New flag: `Unchecked'. This is used during the EmitMeta phase
22050 (which is out-of-line with the regular Resolve/Emit process for a
22051 statement, as this is done ahead of time, but still gets a chance
22052 to call constant resolve).
22054 (Block.Flags): new enum for adding a new flag.
22056 (Block.EmitMeta): track the state of unchecked.
22058 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22059 to enable constant resolution to work there as well.
22061 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22063 * typemanager.cs (ienumerable_type): Also look up
22064 System.Collections.IEnumerable.
22066 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22068 TODO: Test more than one conditional per method.
22070 * class.cs (Indexer.Define): Report the location where the user is
22071 referencing the unsupported feature.
22073 (MethodData): Overload the use of `conditionals' to
22074 minimize the creation of needless ArrayLists. This saves roughly
22075 212kb on my machine.
22077 (Method): Implement the new IIteratorContainer interface.
22078 (Method.SetYields): Implement the method by setting the ModFlags
22079 to contain METHOD_YIELDS.
22081 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22082 which just got set to null.
22084 * iterators.cs: New file.
22086 (Yield, YieldBreak): New statements.
22088 * statement.cs (Return.Resolve): Flag an error if we are used in
22089 an iterator method.
22091 * codegen.cs (InIterator): New flag set if the code is being
22092 compiled in an iterator method.
22094 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22095 internal modifier, and we just use it to avoid adding extra
22096 fields, as this is seldom used.
22098 * cs-parser.jay: Add yield_statement (yield and yield break).
22100 * driver.cs: New flag -v2 to turn on version 2 features.
22102 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22103 hashtable when v2 is enabled.
22105 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22107 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22108 there is already a namespace defined with this name.
22110 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22111 people upgraded their corlibs.
22113 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22114 always use fully qualified types, no need to use the compiler
22117 (TypeManager.IsNamespace): Use binarysearch.
22119 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22120 AddDelegate): I did not quite use the new IsValid API properly: I
22121 have to pass the short-name and the fullname. I was passing only
22122 the basename instead of the fullname sometimes.
22124 (TypeContainer.DefineType): call NamespaceClash.
22126 * interface.cs (Interface.DefineType): use NamespaceClash before
22129 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22132 * enum.cs: (Enum.DefineType): use NamespaceClash before
22135 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22136 speed increase. First, use the negative_hits cache when we get a
22137 negative. Second, add the type with its full original name
22138 instead of the new . and + encoded name (reflection uses + to
22139 separate type from a nested type). Use LookupTypeReflection
22140 directly which bypasses the type->name hashtable (that we already
22141 know does not contain the type.
22143 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22144 location/container type.
22146 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22148 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22150 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22152 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22153 method is being referenced in the method group from a static
22154 context, and report error 120 if so.
22156 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22159 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22160 is created, we create the A namespace).
22162 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22165 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22167 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22168 invocation to ModuleBuilder.GetType with the same values will
22169 return a new type instance, so we need to cache its return
22172 * expression.cs (Binary.ResolveOperator): Only allow the compare
22173 operators on enums if they are of the same type.
22175 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22176 types of ValueType on their own case. Before we were giving them
22177 the same treatment as objects.
22179 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22180 fullname. Short name is used to compare against container name.
22181 Fullname is used to check against defined namespace names.
22183 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22184 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22186 (Method.CheckBase): Call parent.
22187 (MemberBase.CheckBase): Check for protected members on sealed
22189 (PropertyBase.CheckBase): Call parent.
22190 (Field.Define): Call parent.
22192 * report.cs: Negative error codes are now mapped to 8000 - code,
22193 so that the display is render more nicely.
22195 * typemanager.cs: Do not use try/catch, instead report a regular
22198 (GetPointerType, GetReferenceType): These methods provide
22199 mechanisms to obtain the T* and T& from a T. We had the code
22200 previously scattered around the code base, and it also used
22201 TypeManager.LookupType that would go through plenty of caches.
22202 This one goes directly to the type source.
22204 In some places we did the Type.GetType followed by
22205 ModuleBuilder.GetType, but not in others, so this unifies the
22206 processing as well.
22208 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22209 statements now that we have namespace information.
22211 * typemanager.cs (IsNamespace): New method, returns whether the
22212 string presented is a namespace or not.
22214 (ComputeNamespaces): New public entry point, computes the list of
22215 available namespaces, using the GetNamespaces API call in Mono, or
22216 the slower version in MS.NET.
22218 Now before we start the semantic analysis phase, we have a
22219 complete list of namespaces including everything that the user has
22222 Deleted old code to cache namespaces in .nsc files.
22224 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22226 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22227 class/struct location definition Location for the implicit
22228 constructor location.
22230 (Operator.Define): Use the location of the operator for the
22231 implicit Method definition.
22233 (Constructor.Emit): use the constructor location for the implicit
22234 base initializer constructor.
22236 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22237 and the Expression class now contains two new methods:
22239 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22240 isolate type lookup from the rest of the resolution process.
22242 Since we use Expressions to hold type definitions due to the way
22243 we parse the input we have historically overloaded Resolve to
22244 perform the Type lookups if a special flag is passed. Now this is
22245 eliminated and two methods take their place.
22247 The differences in the two methods between xStep and xTerminal is
22248 that xStep is involved in our current lookup system that uses
22249 SimpleNames to compose a name, while xTerminal is used just to
22250 catch the case where the simplename lookup failed.
22252 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22254 * expression.cs (ResolveMemberAccess): Remove redundant code.
22255 TypeExpr expressions are always born fully resolved.
22257 * interface.cs (PopulateMethod): Do not lookup the types twice.
22258 We were doing it once during SemanticAnalysis and once during
22261 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22262 in local variable type definitions, were being returned as a
22263 SimpleName (we decomposed everything into a string), that is
22264 because primary_expression was being used instead of a type in the
22265 grammar (reduce/reduce conflicts).
22267 The part that was wrong is that we converted the expression into a
22268 string (an oversimplification in one hand, compounded with primary
22269 expressions doing string concatenation).
22275 Would return "A.B.C[]" as a SimpleName. This stopped things like
22276 using clauses from working on this particular context. And a type
22277 was being matched directly against "A.B.C[]".
22279 We now use the correct approach, and allow for ComposedCast to be
22280 part of the unary expression. So the "A.B.C []" become a composed
22281 cast of "A.B.C" (as a nested group of MemberAccess with a
22282 SimpleName at the end) plus the rank composition "[]".
22286 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22288 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22289 for the access level checking.
22291 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22292 `TypeContainer container', because I kept getting confused when I
22293 was debugging this code.
22295 * expression.cs (Indexers): Instead of tracking getters/setters,
22296 we now track them in parallel. We create one arraylist less, but
22297 most importantly it is possible now for the LValue code to find a
22298 matching get for a set.
22300 (IndexerAccess.DoResolveLValue): Update the code.
22301 GetIndexersForType has been modified already to extract all the
22302 indexers from a type. The code assumed it did not.
22304 Also make the code set the correct return type for the indexer.
22305 This was fixed a long time ago for properties, but was missing for
22306 indexers. It used to be void_type.
22308 (Binary.Emit): Test first for doubles instead of
22309 floats, as they are more common.
22311 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22312 when dealing with floats and the <=, >= operators. This fixes bug
22315 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22316 to load the array value by emitting a load on the foreach variable
22317 type. This was incorrect.
22319 We now emit the code to load an element using the the array
22320 variable type, and then we emit the conversion operator.
22324 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22326 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22328 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22330 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22331 test for protection before we test for signatures.
22333 (MethodSignature.ToString): implement.
22335 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22336 to the case where we reduced into a LongConstant.
22338 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22339 depend on whether the information is acurrate, because the
22340 Microsoft runtime will always claim that the array type is public,
22341 regardless of the real state.
22343 If the type is a pointer, another problem happens: the type is
22344 reported as non-public in Microsoft.
22346 In both cases we have to call CheckAccessLevel recursively with
22347 the underlying type as the argument to be tested.
22349 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22351 * assign.cs (Assign.Emit): If we are dealing with a compound
22352 assignment expression, we should use the code path that stores the
22353 intermediate result in a temporary value. This fixes #40903.
22355 *expression.cs (Indirection.ToString): Provide ToString method for
22358 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22360 * class.cs: Null out fields holding references to Block objects so
22361 they can be garbage collected.
22363 * expression.cs (OverloadResolve): Remove unused local.
22365 2003-04-07 Martin Baulig <martin@ximian.com>
22367 * codegen.cs (EmitContext.CurrentFile): New public field.
22368 (EmitContext.Mark): Use the CurrentFile to check whether the
22369 location is in the correct file.
22370 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22372 2003-04-07 Martin Baulig <martin@ximian.com>
22374 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22376 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22377 location. [FIXME: The location argument which gets passed to this
22378 method is sometimes wrong!]
22380 2003-04-07 Nick Drochak <ndrochak@gol.com>
22382 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22384 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22386 * expression.cs (Indirection.EmitAssign): We were using the
22387 temporary, but returning immediately instead of continuing the
22390 2003-04-06 Martin Baulig <martin@ximian.com>
22392 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22393 if it's a nested child, but also deriving from the outer class.
22396 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22397 nested child, but also deriving from the outer class. See
22399 (FilterWithClosure): We may access private members of the outer
22400 class if we're a nested child and deriving from the outer class.
22401 (RealMemberLookup): Only set `closure_private_ok' if the
22402 `original_bf' contained BindingFlags.NonPublic.
22404 2003-04-05 Martin Baulig <martin@ximian.com>
22406 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22408 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22410 * class.cs (Event.Define): Do not allow abstract events to have
22413 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22415 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22416 block in event declarations.
22418 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22419 value type, get its address.
22421 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22422 leaving a class on the stack instead of a boolean value (int
22423 0/1). Change the code so we compare against null, and then the
22424 result against zero.
22426 * class.cs (TypeContainer.GetClassBases): We were checking for the
22427 parent class being sealed too late.
22429 * expression.cs (Binary.Emit): For <= and >= when dealing with
22430 floating point values, use cgt.un and clt.un instead of cgt and
22433 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22435 * statement.cs: Apply the same optimization as MS: skip the
22436 GetEnumerator returning an IEnumerator, and use the one returning a
22437 CharEnumerator instead. This allows us to avoid the try-finally block
22440 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22442 * cs-parser.jay: Attributes cannot be applied to
22443 namespaces. Fixes #40473
22445 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22448 (Add*): check if the name is valid using the full name for constants,
22449 fields, properties and events.
22451 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22453 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22454 char constants to be part of the enumeration.
22456 * expression.cs (Conditional.DoResolve): Add support for operator
22457 true. Implements the missing functionality from 14.12
22459 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22460 operator true/false as required by the spec.
22462 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22463 implicit conversion to boolean.
22465 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22466 also one where the type implements `operator true'.
22468 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22469 get an expression that will invoke operator true based on an
22472 (GetConversionOperators): Removed the hack that called op_True
22475 (Expression.ResolveBoolean): Move this from Statement.
22477 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22479 * ecore.cs (FieldExpr): do not allow initialization of initonly
22480 fields on derived classes
22482 2003-03-13 Martin Baulig <martin@ximian.com>
22484 * statement.cs (Block.Emit): Call ig.BeginScope() and
22485 ig.EndScope() when compiling with debugging info; call
22486 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22488 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22490 * expression.cs (Indexers): Do not construct immediately, allow
22491 for new members to be appended as we go. Fixes 38143
22493 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22495 * expression.cs: save/restore context when resolving an unchecked
22498 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22500 * cfold.cs: Catch division by zero in modulus operator during
22503 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22505 * interface.cs (Interface.DefineMembers): Avoid defining members
22508 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22510 * driver.cs: handle the +/- options for -noconfig
22512 * statement.cs (Unckeched.Resolve): Also track the state of
22513 unchecked in the Resolve phase.
22515 2003-02-27 Martin Baulig <martin@ximian.com>
22517 * ecore.cs (Expression.MemberLookup): Don't create a
22518 MethodGroupExpr for something which is not a method. Fixes #38291.
22520 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22522 * class.cs (MemberBase.CheckParameters): Also check that the type
22523 is unmanaged if it is a pointer.
22525 * expression.cs (SizeOf.Resolve): Add location information.
22527 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22528 a managed type is declared.
22530 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22531 parameter modifiers as well. Fixes bug 38606
22533 * class.cs: Very sad. Am backing out the speed up changes
22534 introduced by the ArrayList -> Array in the TypeContainer, as they
22535 were not actually that much faster, and introduced a bug (no error
22536 reports on duplicated methods).
22538 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22539 source first, this will guarantee that we have a valid expression
22540 before calling in lower levels functions that will require a
22541 resolved object. Then use this original_source in the
22542 target.ResolveLValue instead of the original source that was
22545 Another change. Use target.Resolve instead of LValueResolve.
22546 Although we are resolving for LValues, we will let the Assign code
22547 take care of that (it will be called again from Resolve). This
22548 basically allows code like this:
22550 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22551 class Y { void A (X x) { x [0] += o; }
22553 The problem was that the indexer was trying to resolve for
22554 set_Item (idx, object o) and never finding one. The real set_Item
22555 was set_Item (idx, X). By delaying the process we get the right
22560 2003-02-23 Martin Baulig <martin@ximian.com>
22562 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22563 while calling DoEmit ().
22565 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22566 source files; if you use the #line directive inside a method, the
22567 compiler stops emitting line numbers for the debugger until it
22568 reaches the end of the method or another #line directive which
22569 restores the original file.
22571 2003-02-23 Martin Baulig <martin@ximian.com>
22573 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22575 2003-02-23 Martin Baulig <martin@ximian.com>
22577 * statement.cs (Block.AddChildVariableNames): We need to call this
22578 recursively, not just for our immediate children.
22580 2003-02-23 Martin Baulig <martin@ximian.com>
22582 * class.cs (Event.Define): Always make the field private, like csc does.
22584 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22585 actually work, fixes bug #37521.
22587 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22589 * delegate.cs: When creating the various temporary "Parameters"
22590 classes, make sure that we call the ComputeAndDefineParameterTypes
22591 on those new parameters (just like we do with the formal ones), to
22592 allow them to be resolved in the context of the DeclSpace.
22594 This fixes the bug that Dick observed in Bugzilla #38530.
22596 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22598 * expression.cs (ResolveMemberAccess): When resolving a constant,
22599 do not attempt to pull a constant if the value was not able to
22600 generate a valid constant.
22602 * const.cs (LookupConstantValue): Do not report more errors than required.
22604 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22606 * expression.cs: fixes bug #38328.
22608 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22610 * class.cs: Changed all the various members that can be part of a
22611 class from being an ArrayList to be an Array of the right type.
22612 During the DefineType type_list, interface_list, delegate_list and
22613 enum_list are turned into types, interfaces, delegates and enums
22616 And during the member population, indexer_list, event_list,
22617 constant_list, field_list, instance_constructor_list, method_list,
22618 operator_list and property_list are turned into their real arrays.
22620 Although we could probably perform this operation earlier, for
22621 good error reporting we need to keep the lists and remove the
22622 lists for longer than required.
22624 This optimization was triggered by Paolo profiling the compiler
22625 speed on the output of `gen-sample-program.pl' perl script.
22627 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22628 not crash in methods like MemberLookupFailed that use this field.
22630 This problem arises when the compiler fails to resolve a type
22631 during interface type definition for example.
22633 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22635 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22636 inherit from System.Object, so we have to stop at null, not only
22637 when reaching System.Object.
22639 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22641 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22642 DeclaredOnly because the parent indexer might have had a different
22643 name, but did not loop until the top of the hierarchy was reached.
22645 The problem this one fixes is 35492: when a class implemented an
22646 indexer from an interface, we were getting the interface method
22647 (which was abstract) and we were flagging an error (can not invoke
22650 This also keeps bug 33089 functioning, and test-148 functioning.
22652 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22653 out if a method is special is to see if it is declared in a
22654 property or event, or whether it is one of the predefined operator
22655 names. This should fix correctly #36804.
22657 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22659 The goal here is to remove the dependency on EmptyCast.Peel ().
22660 Killing it completely.
22662 The problem is that currently in a number of places where
22663 constants are expected, we have to "probe" for an EmptyCast, and
22664 Peel, which is not the correct thing to do, as this will be
22665 repetitive and will likely lead to errors.
22667 The idea is to remove any EmptyCasts that are used in casts that
22668 can be reduced to constants, so we only have to cope with
22671 This bug hunt was triggered by Bug 37363 and the desire to remove
22672 the duplicate pattern where we were "peeling" emptycasts to check
22673 whether they were constants. Now constants will always be
22676 * ecore.cs: Use an enumconstant here instead of wrapping with
22679 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22680 throwing me off. By handling this we can get rid of a few hacks.
22682 * statement.cs (Switch): Removed Peel() code.
22684 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22686 * class.cs: Location information for error 508
22688 * expression.cs (New.DoResolve): Add a guard against double
22689 resolution of an expression.
22691 The New DoResolve might be called twice when initializing field
22692 expressions (see EmitFieldInitializers, the call to
22693 GetInitializerExpression will perform a resolve on the expression,
22694 and later the assign will trigger another resolution
22696 This leads to bugs (#37014)
22698 * delegate.cs: The signature for EndInvoke should contain any ref
22699 or out parameters as well. We were not doing this in the past.
22701 * class.cs (Field.Define): Do not overwrite the type definition
22702 inside the `volatile' group. Turns out that volatile enumerations
22703 were changing the type here to perform a validity test, which
22706 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22708 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22709 and structs, we do not want to load the instance variable
22711 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22712 enum_type has to be handled like an object reference (implicit
22713 conversions exists from this to object), but the regular IsClass
22714 and IsValueType tests will never return true for this one.
22716 Also we use TypeManager.IsValueType instead of type.IsValueType,
22717 just for consistency with the rest of the code (this is only
22718 needed if we ever use the construct exposed by test-180.cs inside
22719 corlib, which we dont today).
22721 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22723 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22726 2003-02-09 Martin Baulig <martin@ximian.com>
22728 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22729 (Namespace.DefineNamespaces): New static public method; this is
22730 called when we're compiling with debugging to add all namespaces
22731 to the symbol file.
22733 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22734 pass it to the Namespace's .ctor.
22736 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22737 and MethodBase arguments; pass the namespace ID to the symwriter;
22738 pass the MethodBase instead of the token to the symwriter.
22739 (SymbolWriter.DefineNamespace): New method to add a namespace to
22742 2003-02-09 Martin Baulig <martin@ximian.com>
22744 * symbolwriter.cs: New file. This is a wrapper around
22745 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22746 methods here in near future.
22748 2003-02-09 Martin Baulig <martin@ximian.com>
22750 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22751 ILGenerator.MarkSequencePoint() which are actually used by the
22754 2003-02-09 Martin Baulig <martin@ximian.com>
22756 * location.cs (SourceFile): New public sealed class. This
22757 contains the name and an index which is used in the location's token.
22758 (Location): Reserve an appropriate number of bits in the token for
22759 the source file instead of walking over that list, this gives us a
22760 really huge performance improvement when compiling with debugging.
22762 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22763 `SourceFile' argument instead of a string.
22764 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22765 but don't parse/tokenize here, we need to generate the list of all
22766 source files before we do that.
22767 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22770 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22771 instead of a string.
22773 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22776 2003-02-09 Martin Baulig <martin@ximian.com>
22778 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22779 filename on `#line default'.
22781 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22783 * statement.cs: don't clear the pinned var when the fixed statement
22784 returns from the method (fixes bug#37752).
22786 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22788 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22791 2003-02-07 Martin Baulig <martin@ximian.com>
22793 * driver.cs: Removed the `--debug-args' command line argument.
22795 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22796 automatically by the AsssemblyBuilder.
22797 (CodeGen.InitializeSymbolWriter): We don't need to call any
22798 initialization function on the symbol writer anymore. This method
22799 doesn't take any arguments.
22801 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22803 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22804 from referenced assemblies as well.
22806 2003-02-02 Martin Baulig <martin@ximian.com>
22808 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22810 2003-02-02 Martin Baulig <martin@ximian.com>
22812 * class.cs (Constructor.Emit): Open the symbol writer before
22813 emitting the constructor initializer.
22814 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22815 single-stepping through constructor initializers.
22817 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22819 * class.cs: Handle error 549: do not allow virtual methods in
22822 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22824 * decl.cs: Check access levels when resolving types
22826 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22828 * statement.cs: Add parameters and locals set in catch blocks that might
22829 return to set vector
22831 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22833 * class.cs (Operator): Set the SpecialName flags for operators.
22835 * expression.cs (Invocation.DoResolve): Only block calls to
22836 accessors and operators on SpecialName methods.
22838 (Cast.TryReduce): Handle conversions from char constants.
22841 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22843 * statement.cs: small memory and time optimization in FlowBranching.
22845 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22847 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22848 problem that the last fix but in the other sid (Set).
22850 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22851 access when there is no indexer in the hierarchy.
22853 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22855 * class.cs: Combine some if statements.
22857 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22859 * driver.cs: fixed bug #37187.
22861 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22863 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22864 any indexer, it's needed to build a list with all the indexers in the
22865 hierarchy (AllGetters), else we have problems. Fixes #35653.
22867 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22869 * class.cs (MethodData.Define): It is wrong for an interface
22870 implementation to be static in both cases: explicit and implicit.
22871 We were only handling this in one case.
22873 Improve the if situation there to not have negations.
22875 * class.cs (Field.Define): Turns out that we do not need to check
22876 the unsafe bit on field definition, only on usage. Remove the test.
22878 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22880 * driver.cs: use assembly.Location instead of Codebase (the latest
22881 patch made mcs fail when using MS assemblies).
22883 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22885 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22886 get the path to *corlib.dll.
22888 2003-01-21 Nick Drochak <ndrochak@gol.com>
22892 * typemanager.cs: Remove compiler warnings
22894 2003-01-20 Duncan Mak <duncan@ximian.com>
22896 * AssemblyInfo.cs: Bump the version number to 0.19.
22898 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22900 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22902 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22904 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22906 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22908 * cs-parser.jay: Small fix: we were not comparing the constructor
22909 name correctly. Thanks to Zoltan for the initial pointer.
22911 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22913 * cs-tokenizer.cs: Set file name when specified with #line
22915 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22917 * cs-parser.jay: Only perform the constructor checks here if we
22918 are named like the class; This will help provider a better
22919 error. The constructor path is taken when a type definition is
22920 not found, but most likely the user forgot to add the type, so
22921 report that rather than the constructor error.
22923 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22925 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22928 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22930 * cs-parser.jay: Add cleanup call.
22932 2003-01-13 Duncan Mak <duncan@ximian.com>
22934 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22935 consistent with other methods.
22937 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22939 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22941 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22943 * attribute.cs: only set GuidAttr to true when we have a
22946 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22950 * typemanager.cs: fixes to allow mcs compile corlib with the new
22951 Type.IsSubclassOf fix.
22953 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22955 * expression.cs (LocalVariableReference.DoResolve): Classify a
22956 constant as a value, not as a variable. Also, set the type for
22959 * cs-parser.jay (fixed_statement): take a type instead of a
22960 pointer_type, so we can produce a better error message later.
22962 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22965 (For.DoEmit): Make inifinite loops have a
22966 non-conditional branch back.
22968 (Fixed.DoEmit): First populate the pinned variables, then emit the
22969 statement, then clear the variables. Before I was emitting the
22970 code once for each fixed piece.
22973 2003-01-08 Martin Baulig <martin@ximian.com>
22975 * statement.cs (FlowBranching.MergeChild): A break in a
22976 SWITCH_SECTION does not leave a loop. Fixes #36155.
22978 2003-01-08 Martin Baulig <martin@ximian.com>
22980 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22981 lives in the same number space than `param_map'. Fixes #36154.
22983 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22985 * cs-parser.jay (constructor_declaration): Set the
22986 Constructor.ModFlags before probing for it. This makes the
22987 compiler report 514, 515 and 132 (the code was there, but got
22990 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22991 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22992 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22994 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22996 * enum.cs: create the enum static fields using the enum type.
22998 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23000 * class.cs: don't try to create the ParamBuilder for the return
23001 type if it's not needed (and handle it breaking for the ms runtime
23004 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23006 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23008 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23010 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23011 the command. This showed up while compiling the JANET source
23012 code, which used \r as its only newline separator.
23014 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23016 * class.cs (Method.Define): If we are an operator (because it
23017 reuses our code), then set the SpecialName and HideBySig. #36128
23019 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23021 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23022 exception, report error 120 `object reference required'.
23024 * driver.cs: Add --pause option, used during to measure the size
23025 of the process as it goes with --timestamp.
23027 * expression.cs (Invocation.DoResolve): Do not allow methods with
23028 SpecialName to be invoked.
23030 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23032 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23033 number before adding it.
23035 2002-12-21 Ravi Pratap <ravi@ximian.com>
23037 * ecore.cs (StandardImplicitConversion): When in an unsafe
23038 context, we allow conversion between void * to any other pointer
23039 type. This fixes bug #35973.
23041 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23043 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23044 is not thrown when extensionless outputs are used
23046 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23048 * rootcontext.cs: fixed compilation of corlib.
23050 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23052 * attribute.cs (Attributes.Contains): Add new method.
23054 * class.cs (MethodCore.LabelParameters): if the parameter is an
23055 `out' parameter, check that no attribute `[In]' has been passed.
23057 * enum.cs: Handle the `value__' name in an enumeration.
23059 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23061 * decl.cs: Added special case to allow overrides on "protected
23064 2002-12-18 Ravi Pratap <ravi@ximian.com>
23066 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23067 since it makes much more sense.
23069 (Attributes.ctor): Don't require a Location parameter.
23071 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23073 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23074 since we already have that information per attribute.
23076 * everywhere : make appropriate changes.
23078 * class.cs (LabelParameters): Write the code which actually
23079 applies attributes to the return type. We can't do this on the MS
23080 .NET runtime so we flag a warning in the case an exception is
23083 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23085 * const.cs: Handle implicit null conversions here too.
23087 2002-12-17 Ravi Pratap <ravi@ximian.com>
23089 * class.cs (MethodCore.LabelParameters): Remove the extra
23090 Type [] parameter since it is completely unnecessary. Instead
23091 pass in the method's attributes so that we can extract
23092 the "return" attribute.
23094 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23096 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23097 of ignoring it and letting the compile continue.
23099 * typemanager.cs (ChangeType): use an extra argument to return an
23100 error condition instead of throwing an exception.
23102 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23104 * expression.cs (Unary.TryReduce): mimic the code for the regular
23105 code path. Perform an implicit cast in the cases where we can
23106 implicitly convert to one of the integral types, and then reduce
23107 based on that constant. This fixes bug #35483.
23109 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23111 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23113 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23115 * namespace.cs: fixed bug #35489.
23117 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23119 * class.cs: Remove some dead code.
23121 * cs-parser.jay: Estimate the number of methods needed
23122 (RootContext.MethodCount);
23124 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23125 numbers instead of StringBuilders.
23127 * support.cs (PtrHashtable): Add constructor with initial size;
23128 We can now reduce reallocations of the method table.
23130 2002-12-10 Ravi Pratap <ravi@ximian.com>
23132 * attribute.cs (ApplyAttributes): Keep track of the emitted
23133 attributes on a per-target basis. This fixes bug #35413.
23135 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23137 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23138 default to the Windows 1252 encoding.
23140 (UnixParseOption): Support version, thanks to Alp for the missing
23143 * AssemblyInfo.cs: Add nice assembly information.
23145 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23148 * cs-parser.jay: Allow a trailing comma before the close bracked
23149 in the attribute_section production.
23151 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23152 address of the instance was being taken, I will take this out,
23153 because we take the address of the object immediately here.
23155 2002-12-09 Ravi Pratap <ravi@ximian.com>
23157 * typemanager.cs (AreMultipleAllowed): Take care of the most
23158 obvious case where attribute type is not in the current assembly -
23161 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23163 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23164 definitions, instead of doing that afterwards.
23166 Also we use a nice little hack, depending on the constructor, we
23167 know if we are a "composed" name or a simple name. Hence, we
23168 avoid the IndexOf test, and we avoid
23170 * codegen.cs: Add code to assist in a bug reporter to track down
23171 the source of a compiler crash.
23173 2002-12-07 Ravi Pratap <ravi@ximian.com>
23175 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23176 types have been emitted for a given element and flag an error
23177 if something which does not have AllowMultiple set is used more
23180 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23181 attribute types and their corresponding AllowMultiple properties
23183 (AreMultipleAllowed): Check the property for a given type.
23185 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23186 property in the case we have a TypeContainer.
23188 (Attributes.AddAttribute): Detect duplicates and just skip on
23189 adding them. This trivial fix catches a pretty gross error in our
23190 attribute emission - global attributes were being emitted twice!
23192 Bugzilla bug #33187 is now fixed.
23194 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23196 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23197 instead of pp_and).
23199 * expression.cs (Binary.ResolveOperator): I can only use the
23200 Concat (string, string, string) and Concat (string, string,
23201 string, string) if the child is actually a concatenation of
23204 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23206 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23207 context where we need a 2-character lookahead.
23209 * pending.cs (PendingImplementation): Rework so we can keep track
23210 of interface types all the time, and flag those which were
23211 implemented by parents as optional.
23213 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23215 * expression.cs (Binary.ResolveOperator): Use
23216 String.Concat(string,string,string) or
23217 String.Concat(string,string,string,string) when possible.
23219 * typemanager: More helper methods.
23222 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23224 * pending.cs: remove the bogus return from GetMissingInterfaces()
23225 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23227 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23229 * namespace.cs: avoid duplicated 'using xxx' being added to
23230 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23231 when we get more than one 'using' statement for the same namespace.
23232 Report a CS0105 warning for it.
23234 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23236 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23237 of calling getChar/putback, uses internal knowledge of it.
23239 (xtoken): Reorder tokenizer so most common patterns are checked
23240 first. This reduces the compilation time in another 5% (from 8.11s
23241 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23243 The parsing time is 22% of the compilation in mcs, and from that
23244 64% is spent on the tokenization process.
23246 I tried using a binary search for keywords, but this is slower
23247 than the hashtable. Another option would be to do a couple of
23250 * Not use a StringBuilder, instead use an array of chars,
23251 with a set value. Notice that this way we could catch
23252 the 645 error without having to do it *afterwards*.
23254 * We could write a hand-parser to avoid the hashtable
23255 compares altogether.
23257 The identifier consumption process takes 37% of the tokenization
23258 time. Another 15% is spent on is_number. 56% of the time spent
23259 on is_number is spent on Int64.Parse:
23261 * We could probably choose based on the string length to
23262 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23265 Another 3% is spend on wrapping `xtoken' in the `token' function.
23267 Handle 0xa0 as whitespace (#34752)
23269 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23271 * typemanager.cs (IsCLRType): New routine to tell whether a type
23272 is one of the builtin types.
23274 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23275 typecode in more places instead of doing pointer comparissions.
23276 We could leverage some knowledge about the way the typecodes are
23279 New code to cache namespaces in assemblies, it is currently not
23280 invoked, to be used soon.
23282 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23284 * expression.cs (Binary.ResolveOperator): specially handle
23285 strings, and do not perform user-defined operator overloading for
23288 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23290 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23291 internalcall as it is a pretty simple operation; Avoid whenever
23292 possible to call Char.IsLetter.
23294 (consume_identifier): Cut by half the number of
23295 hashtable calls by merging the is_keyword and GetKeyword behavior.
23297 Do not short-circuit, because if we do, we
23298 report errors (ie, #if false && true would produce an invalid
23302 2002-11-24 Martin Baulig <martin@ximian.com>
23304 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23305 check constant ranges and report a CS0221. Fixes #33186.
23307 2002-11-24 Martin Baulig <martin@ximian.com>
23309 * cs-parser.jay: Make this work for uninitialized variable
23310 declarations in the `for' initializer. Fixes #32416.
23312 2002-11-24 Martin Baulig <martin@ximian.com>
23314 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23315 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23317 2002-11-24 Martin Baulig <martin@ximian.com>
23319 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23320 argument; if true, we also check for user-defined conversions.
23321 This is only needed if both arguments are of a user-defined type.
23322 Fixes #30443, added test-175.cs.
23323 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23325 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23327 2002-11-24 Martin Baulig <martin@ximian.com>
23329 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23330 function to get the store opcode.
23331 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23332 only emit the Ldelema if the store opcode is Stobj. You must run
23333 both test-34 and test-167 to test this. Fixes #34529.
23335 2002-11-23 Martin Baulig <martin@ximian.com>
23337 * ecore.cs (Expression.MemberLookup): Added additional
23338 `qualifier_type' argument which is used when we're being called
23339 from MemberAccess.DoResolve() and null if we're called from a
23341 (Expression.MemberLookupFailed): New method to report errors; this
23342 does the CS1540 check and reports the correct error message.
23344 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23345 argument for the CS1540 check and redone the way how we're dealing
23346 with private members. See the comment in the source code for details.
23347 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23348 `closure_start_type' to `closure_qualifier_type' and check whether
23349 it's not null. It was not this filter being broken, it was just
23350 being called with the wrong arguments.
23352 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23353 and pass it the correct `qualifier_type'; this also does the error
23356 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23358 * expression.cs (Invocation.EmitParams): If the we are dealing
23359 with a non-built-in value type, load its address as well.
23361 (ArrayCreation): Use a a pretty constant instead
23362 of the hardcoded value 2. Use 6 instead of 2 for the number of
23363 static initializers.
23365 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23366 because they are not really value types, just glorified integers.
23368 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23370 * ecore.cs: Remove redundant code for enumerations, make them use
23371 the same code path as everything else, fixes the casting issue
23372 with enumerations in Windows.Forms.
23374 * attribute.cs: Do only cast to string if it is a string, the
23375 validation happens later.
23377 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23378 people upgrade their corlibs.
23380 * ecore.cs: Oops, enumerations were not following the entire code path
23382 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23384 * typemanager.cs (FilterWithClosure): Commented out the test for
23385 1540 in typemanager.cs, as it has problems when accessing
23386 protected methods from a parent class (see test-174.cs).
23388 * attribute.cs (Attribute.ValidateGuid): new method.
23389 (Attribute.Resolve): Use above.
23391 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23393 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23395 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23396 handling for enumerations, as we only needed the TypeContainer
23397 functionality to begin with (this is required for the fix below to
23398 work for enums that reference constants in a container class for
23401 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23403 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23404 a valid TypeBuilder to perform lookups on.o
23406 * class.cs (InheritableMemberSignatureCompare): Use true in the
23407 call to GetGetMethod and GetSetMethod, because we are comparing
23408 the signature, and we need to get the methods *even* if they are
23411 (PropertyBase.CheckBase): ditto.
23413 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23414 GotoCase.Resolve): Use Peel on EmpytCasts.
23416 * ecore.cs (EmptyCast): drop child, add Peel method.
23418 2002-11-17 Martin Baulig <martin@ximian.com>
23420 * ecore.cs (EmptyCast.Child): New public property.
23422 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23423 label resolved to an EmptyCast. Fixes #34162.
23424 (GotoCase.Resolve): Likewise.
23425 (Block.EmitMeta): Likewise.
23427 2002-11-17 Martin Baulig <martin@ximian.com>
23429 * expression.cs (Invocation.BetterConversion): Prefer int over
23430 uint; short over ushort; long over ulong for integer literals.
23431 Use ImplicitConversionExists instead of StandardConversionExists
23432 since we also need to check for user-defined implicit conversions.
23433 Fixes #34165. Added test-173.cs.
23435 2002-11-16 Martin Baulig <martin@ximian.com>
23437 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23438 with the `true' and `false' literals. Fixes #33151.
23440 2002-11-16 Martin Baulig <martin@ximian.com>
23442 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23443 October 22nd; don't do the cs1540 check for static members.
23445 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23446 now using our own filter here and doing the cs1540 check again.
23448 2002-11-16 Martin Baulig <martin@ximian.com>
23450 * support.cs (InternalParameters): Don't crash if we don't have
23451 any fixed parameters. Fixes #33532.
23453 2002-11-16 Martin Baulig <martin@ximian.com>
23455 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23456 when looking up static methods to make this work on Windows.
23459 2002-11-16 Martin Baulig <martin@ximian.com>
23461 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23462 a setter rather than using PropertyInfo.CanWrite.
23464 2002-11-15 Nick Drochak <ndrochak@gol.com>
23466 * class.cs: Allow acces to block member by subclasses. Fixes build
23469 2002-11-14 Martin Baulig <martin@ximian.com>
23471 * class.cs (Constructor.Emit): Added the extern/block check.
23474 2002-11-14 Martin Baulig <martin@ximian.com>
23476 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23477 iteration while looking for indexers, this is needed because the
23478 indexer may have a different name in our base classes. Fixed the
23479 error reporting (no indexers at all, not get accessor, no
23480 overloaded match). Fixes bug #33089.
23481 (IndexerAccess.DoResolveLValue): Likewise.
23483 2002-11-14 Martin Baulig <martin@ximian.com>
23485 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23486 indexers. Fixes the first part of bug #33089.
23487 (MethodSignature.InheritableMemberSignatureCompare): Added support
23490 2002-11-13 Ravi Pratap <ravi@ximian.com>
23492 * attribute.cs (Attribute.Resolve): Catch the
23493 NullReferenceException and report it since it isn't supposed to
23496 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23498 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23499 LogicalOr and LogicalAnd that can benefit from recursively
23500 handling EmitBranchable. The code now should be nice for Paolo.
23502 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23504 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23505 the Type lookups, as we perform quite a number of lookups on
23506 non-Types. This can be removed once we can deterministically tell
23507 whether we have a type or a namespace in advance.
23509 But this might require special hacks from our corlib.
23513 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23514 and double which avoids a conversion from an integer to a double.
23516 * expression.cs: tiny optimization, avoid calling IsConstant,
23517 because it effectively performs the lookup twice.
23519 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23521 But a bogus return here to keep the semantics of the old code
23522 until the Mono runtime is fixed.
23524 * pending.cs (GetMissingInterfaces): New method used to remove all
23525 the interfaces that are already implemented by our parent
23526 classes from the list of pending methods.
23528 * interface.cs: Add checks for calls after ResolveTypeExpr.
23530 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23532 * class.cs (Class.Emit): Report warning 67: event not used if the
23533 warning level is beyond 3.
23535 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23536 being a NullLiteral.
23538 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23541 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23542 path that might fail if a type can not be resolved.
23544 * expression.cs (Binary.Emit): Emit unsigned versions of the
23547 * driver.cs: use error 5.
23549 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23551 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23553 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23555 * cs-parser.jay (switch_section): A beautiful patch from Martin
23556 Baulig that fixed 33094.
23558 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23560 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23561 Check whether the base is abstract and report an error if so.
23563 * expression.cs (IndexerAccess.DoResolveLValue,
23564 IndexerAccess.DoResolve): ditto.
23566 (Invocation.DoResolve): ditto.
23568 (Invocation.FullMethodDesc): Improve the report string.
23570 * statement.cs (Block): Eliminate IsVariableDefined as it is
23571 basically just a wrapper for GetVariableInfo.
23573 * ecore.cs (SimpleName): Use new
23575 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23576 type, as we return the actual parameter ref/unref state on a
23579 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23581 * support.cs: Return proper flags REF/OUT fixing the previous
23584 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23585 not used to mean `ref' but `ref or out' in ParameterReference
23587 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23588 full type signature instead of calling TypeManger.CSharpName
23591 * support.cs (InternalParameters.ParameterDesc): Do not compare
23592 directly to the modflags, because REF/OUT will actually be bitsets
23595 * delegate.cs (VerifyMethod): Check also the modifiers.
23597 * cs-tokenizer.cs: Fix bug where floating point values with an
23598 exponent where a sign was missing was ignored.
23600 * driver.cs: Allow multiple assemblies to be specified in a single
23603 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23605 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23606 because identifiers after a parenthesis would end up in this kind
23607 of production, and we needed to desamiguate it for having casts
23610 (UserDefinedType *) xxx
23612 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23614 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23615 we should set on the Bindingflags.NonPublic, but not turn on
23616 private_ok. private_ok controls whether a Private member is
23617 returned (this is chekced on the filter routine), while the
23618 BindingFlags.NonPublic just controls whether private/protected
23619 will be allowed. This fixes the problem part of the problem of
23620 private properties being allowed to be used in derived classes.
23622 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23623 so we can call the children DoResolveLValue method (this will
23624 properly signal errors on lvalue assignments to base properties)
23626 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23627 getter are null, and we have a property info, we know that this
23628 happened because the lookup failed, so we report an error 122 for
23629 protection level violation.
23631 We also silently return if setter and getter are null in the
23632 resolve functions, this condition only happens if we have flagged
23633 the error before. This is the other half of the problem.
23635 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23636 not have accessibility information, that is why we were returning
23637 true in the filter function in typemanager.cs.
23639 To properly report 122 (property is inaccessible because of its
23640 protection level) correctly, we report this error in ResolveAccess
23641 by failing if both the setter and the getter are lacking (ie, the
23644 DoResolve and DoLResolve have been modified to check for both
23645 setter/getter being null and returning silently, the reason being
23646 that I did not want to put the knowledge about this error in upper
23649 int old = Report.Errors;
23650 x = new PropertyExpr (...);
23651 if (old != Report.Errors)
23656 So the property expr is returned, but it is invalid, so the error
23657 will be flagged during the resolve process.
23659 * class.cs: Remove InheritablePropertySignatureCompare from the
23660 class, as we no longer depend on the property signature to compute
23661 whether it is possible to implement a method or not.
23663 The reason is that calling PropertyInfo.GetGetMethod will return
23664 null (in .NET, in Mono it works, and we should change this), in
23665 cases where the Get Method does not exist in that particular
23670 class X { public virtual int A { get { return 1; } } }
23672 class Z : Y { public override int A { get { return 2; } } }
23674 Would fail in Z because the parent (Y) would not have the property
23675 defined. So we avoid this completely now (because the alternative
23676 fix was ugly and slow), and we now depend exclusively on the
23679 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23680 reference method, instead of using the property.
23682 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23683 routines are gone now.
23685 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23686 names, they were incorrectly named.
23688 * cs-tokenizer.cs: Return are more gentle token on failure.
23690 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23691 had an out-of-sync index variable, which caused it to remove from
23692 the list of pending methods the wrong method sometimes.
23694 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23696 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23697 CanWrite, because those refer to this particular instance of the
23698 property, and do not take into account the fact that we can
23699 override single members of a property.
23701 Constructor requires an EmitContext. The resolution process does
23702 not happen here, but we need to compute the accessors before,
23703 because the resolution does not always happen for properties.
23705 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23706 subclass, before we did not update this flag, but we did update
23709 (GetAccessors): Drop this routine, as it did not work in the
23710 presence of partially overwritten set/get methods.
23712 Notice that this broke the cs1540 detection, but that will require
23715 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23719 * driver.cs: issue a warning instead of an error if we don't support
23720 debugging for the platform. Also ignore a couple of errors that may
23721 arise when trying to write the symbols. Undo my previous patch.
23723 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23725 * driver.cs: ignore /debug switch except for Unix platforms.
23727 2002-10-23 Nick Drochak <ndrochak@gol.com>
23729 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23731 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23733 * driver.cs: Do not make mcs-debug conditional, so we do not break
23734 builds that use it.
23736 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23737 review this patch. But basically after all the children variables
23738 have been merged, the value of "Breaks" was not being set to
23739 new_breaks for Switch blocks. I think that it should be set after
23740 it has executed. Currently I set this to the value of new_breaks,
23741 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23742 conservative, but I do not understand this code very well.
23744 I did not break anything in the build, so that is good ;-)
23746 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23748 2002-10-20 Mark Crichton <crichton@gimp.org>
23750 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23752 2002-10-20 Nick Drochak <ndrochak@gol.com>
23754 * cfold.cs: Fixed compile blocker.
23756 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23758 * driver.cs: I was chekcing the key, not the file.
23760 2002-10-19 Ravi Pratap <ravi@ximian.com>
23762 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23763 message that we were generating - we just need to silently return
23766 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23768 * class.cs (Event.Define): Change my previous commit, as this
23769 breaks the debugger. This is a temporary hack, as it seems like
23770 the compiler is generating events incorrectly to begin with.
23772 * expression.cs (Binary.ResolveOperator): Added support for
23773 "U operator - (E x, E y)"
23775 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23778 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23779 init-only variables, but this path did not take into account that
23780 there might be also instance readonly variables. Correct this
23783 This fixes bug 32253
23785 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23788 * driver.cs: Change the extension for modules to `netmodule'
23790 * cs-parser.jay: Improved slightly the location tracking for
23791 the debugger symbols.
23793 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23794 modifiers that were specified instead of the hardcoded value
23795 (FamAndAssem). This was basically ignoring the static modifier,
23796 and others. Fixes 32429.
23798 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23799 fixed a bug in the process (32476)
23801 * expression.cs (ArrayAccess.EmitAssign): Patch from
23802 hwang_rob@yahoo.ca that fixes bug 31834.3
23804 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23806 * driver.cs: Make the module extension .netmodule.
23808 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23810 * driver.cs: Report an error if the resource file is not found
23811 instead of crashing.
23813 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23814 false, like Emit does.
23816 2002-10-16 Nick Drochak <ndrochak@gol.com>
23818 * typemanager.cs: Remove unused private member. Also reported mcs
23819 bug to report this as a warning like csc.
23821 2002-10-15 Martin Baulig <martin@gnome.org>
23823 * statement.cs (Statement.Emit): Made this a virtual method; emits
23824 the line number info and calls DoEmit().
23825 (Statement.DoEmit): New protected abstract method, formerly knows
23826 as Statement.Emit().
23828 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23830 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23832 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23833 have fixed a remaining problem: not every AddXXXX was adding a
23834 fully qualified name.
23836 Now everyone registers a fully qualified name in the DeclSpace as
23837 being defined instead of the partial name.
23839 Downsides: we are slower than we need to be due to the excess
23840 copies and the names being registered this way.
23842 The reason for this is that we currently depend (on the corlib
23843 bootstrap for instance) that types are fully qualified, because
23844 we dump all the types in the namespace, and we should really have
23845 types inserted into the proper namespace, so we can only store the
23846 basenames in the defined_names array.
23848 2002-10-10 Martin Baulig <martin@gnome.org>
23850 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23851 from bug #31834, see the bug report for a testcase which is
23854 2002-10-10 Martin Baulig <martin@gnome.org>
23856 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23857 flow analysis code for this.
23859 * statement.cs (Do, While, For): Tell the flow analysis code about
23861 (FlowBranching.UsageVector): Added support for infinite loops.
23862 (Block.Resolve): Moved the dead code elimination here and use flow
23865 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23867 * class.cs (Field.Define): Catch cycles on struct type
23870 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23871 fields if the fields are static. We only need to check instance
23874 * expression.cs (As.DoResolve): Test for reference type.
23876 * statement.cs (Using.ResolveExpression): Use
23877 ConvertImplicitRequired, not ConvertImplicit which reports an
23879 (Using.ResolveLocalVariableDecls): ditto.
23881 * expression.cs (Binary.ResolveOperator): Report errors in a few
23882 places where we had to.
23884 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23886 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23888 * expression.cs: Use StoreFromPtr instead of extracting the type
23889 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23891 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23892 an enumeration value to a System.Enum, but System.Enum is not a
23893 value type, but an class type, so we need to box.
23895 (Expression.ConvertExplicit): One codepath could return
23896 errors but not flag them. Fix this. Fixes #31853
23898 * parameter.cs (Resolve): Do not allow void as a parameter type.
23900 2002-10-06 Martin Baulig <martin@gnome.org>
23902 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23903 if it's a class type and not a struct. Fixes #31815.
23905 2002-10-06 Martin Baulig <martin@gnome.org>
23907 * statement.cs: Reworked the flow analysis code a bit to make it
23908 usable for dead code elimination.
23910 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23912 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23914 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23916 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23917 to fix the test 165, will investigate deeper.
23919 2002-10-04 Martin Baulig <martin@gnome.org>
23921 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23922 finally blocks actually work.
23923 (Try.Resolve): We don't need to create a sibling for `finally' if
23924 there is no finally block.
23926 2002-10-04 Martin Baulig <martin@gnome.org>
23928 * class.cs (Constructor.Define): The default accessibility for a
23929 non-default constructor is private, not public.
23931 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23933 * class.cs (Constructor): Make AllowedModifiers public, add
23936 * cs-parser.jay: Perform the modifiers test here, as the
23937 constructor for the Constructor class usually receives a zero
23938 because of the way we create it (first we create, later we
23939 customize, and we were never checking the modifiers).
23941 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23942 is a version of LookupTypeReflection that includes the type-name
23943 cache. This can be used as a fast path for functions that know
23944 the fully qualified name and are only calling into *.GetType() to
23945 obtain a composed type.
23947 This is also used by TypeManager.LookupType during its type
23950 (LookupType): We now also track the real type name, as sometimes
23951 we can get a quey for the real type name from things like
23952 ComposedCast. This fixes bug 31422.
23954 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23955 complete type fullname, it does not have to go through the type
23956 resolution system to obtain the composed version of the type (for
23957 obtaining arrays or pointers).
23959 (Conditional.Emit): Use the EmitBoolExpression to
23960 generate nicer code, as requested by Paolo.
23962 (ArrayCreation.CheckIndices): Use the patch from
23963 hwang_rob@yahoo.ca to validate the array initializers.
23965 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23967 * class.cs (ConstructorInitializer.Emit): simplify code by using
23968 Invocation.EmitCall, and at the same time, fix the bugs in calling
23969 parent constructors that took variable arguments.
23971 * ecore.cs (Expression.ConvertNumericExplicit,
23972 Expression.ImplicitNumericConversion): Remove the code that
23973 manually wrapped decimal (InternalTypeConstructor call is now gone
23976 * expression.cs (Cast.TryReduce): Also handle decimal types when
23977 trying to perform a constant fold on the type.
23979 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23981 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23982 that only turned off an error report, and did nothing else.
23984 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23986 * driver.cs: Handle and ignore /fullpaths
23988 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23990 * expression.cs (Binary.ResolveOperator): Catch the case where
23991 DoNumericPromotions returns true,
23993 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23995 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23997 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24000 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24002 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24003 conversion exists, but it is also required that the conversion be
24004 performed. This manifested in "(Type64Enum) 2".
24006 * class.cs (TypeManager.AddMethod): The fix is not to change
24007 AddEnum, because that one was using a fully qualified name (every
24008 DeclSpace derivative does), but to change the AddMethod routine
24009 that was using an un-namespaced name. This now correctly reports
24010 the duplicated name.
24012 Revert patch until I can properly fix it. The issue
24013 is that we have a shared Type space across all namespaces
24014 currently, which is wrong.
24016 Options include making the Namespace a DeclSpace, and merge
24017 current_namespace/current_container in the parser.
24019 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24021 * cs-parser.jay: Improve error reporting when we get a different
24022 kind of expression in local_variable_type and
24023 local_variable_pointer_type.
24025 Propagate this to avoid missleading errors being reported.
24027 * ecore.cs (ImplicitReferenceConversion): treat
24028 TypeManager.value_type as a target just like object_type. As
24033 Is valid, and needs to result in the int 1 being boxed before it
24034 is assigned to the value type v.
24036 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24037 to validate the enumeration name.
24039 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24040 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24041 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24043 * ecore.cs (TryImplicitIntConversion): When doing an
24044 implicit-enumeration-conversion, check if the type is 64-bits and
24045 perform a conversion before passing to EnumConstant.
24047 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24049 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24050 report ambiguous type references. Unlike the MS version, we
24051 report what the ambiguity is. Innovation at work ;-)
24053 (DeclSpace.FindType): Require a location argument to
24054 display when we display an ambiguous error.
24056 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24058 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24060 * expression.cs (EmitDynamicInitializers): Apply patch from
24061 hwang_rob@yahoo.ca that fixes the order in which we emit our
24064 2002-09-21 Martin Baulig <martin@gnome.org>
24066 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24067 delegate takes no arguments.
24069 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24071 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24074 * expression.cs: Extract the underlying type.
24076 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24078 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24080 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24082 * class.cs (TypeContainer.DefineType): We can not use the nice
24083 PackingSize with the size set to 1 DefineType method, because it
24084 will not allow us to define the interfaces that the struct
24087 This completes the fixing of bug 27287
24089 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24090 means also structs. This fixes part of the problem.
24091 (Expresion.ImplicitReferenceConversionExists): ditto.
24093 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24094 error if there were no errors reported during the type lookup
24095 process, to avoid duplicates or redundant errors. Without this
24096 you would get an ambiguous errors plus a type not found. We have
24097 beaten the user enough with the first error.
24099 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24102 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24103 during the resolution process, stop the lookup, this avoids
24104 repeated error reports (same error twice).
24106 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24108 * typemanager.cs (LookupType): Redo the type lookup code to match
24109 the needs of System.Reflection.
24111 The issue is that System.Reflection requires references to nested
24112 types to begin with a "+" sign instead of a dot. So toplevel
24113 types look like: "NameSpace.TopLevelClass", and nested ones look
24114 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24117 2002-09-19 Martin Baulig <martin@gnome.org>
24119 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24120 says that a method always returns or always throws an exception,
24121 don't report the CS0161.
24123 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24124 set `Returns = new_returns'.
24126 2002-09-19 Martin Baulig <martin@gnome.org>
24128 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24129 to an enum constant, check for a CS0176.
24131 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24133 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24134 for operators that must be in pairs and report errors.
24136 * ecore.cs (SimpleName.DoResolveType): During the initial type
24137 resolution process, when we define types recursively, we must
24138 check first for types in our current scope before we perform
24139 lookups in the enclosing scopes.
24141 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24143 (Invocation.VerifyArgumentsCompat): Call
24144 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24145 I thought we were supposed to always call this, but there are a
24146 few places in the code where we dont do it.
24148 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24150 * driver.cs: Add support in -linkres and -resource to specify the
24151 name of the identifier.
24153 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24155 * ecore.cs (StandardConversionExists): Sync with the conversion
24156 code: allow anything-* to void* conversions.
24158 (FindMostSpecificSource): Use an Expression argument
24159 instead of a Type, because we might be handed over a Literal which
24160 gets a few more implicit conversions that plain types do not. So
24161 this information was being lost.
24163 Also, we drop the temporary type-holder expression when not
24166 2002-09-17 Martin Baulig <martin@gnome.org>
24168 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24169 this is an explicit interface implementation.
24171 2002-09-17 Martin Baulig <martin@gnome.org>
24173 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24174 different `IndexerName' attributes.
24176 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24177 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24178 virtual CommonResolve().
24180 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24182 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24183 and convert that to the UnderlyingType.
24185 * statement.cs (Foreach.Resolve): Indexers are just like variables
24186 or PropertyAccesses.
24188 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24189 inside quoted strings, we were not doing this before.
24191 2002-09-16 Martin Baulig <martin@gnome.org>
24193 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24194 resolve it. This is needed for the definite assignment check of the
24195 instance expression, fixes bug #29846.
24196 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24198 2002-09-16 Nick Drochak <ndrochak@gol.com>
24200 * parameter.cs: Fix compile error. Cannot reference static member
24201 from an instance object. Is this an mcs bug?
24203 2002-09-14 Martin Baulig <martin@gnome.org>
24205 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24206 multiple times. Fixes bug #30295, added test-166.cs.
24208 2002-09-14 Martin Baulig <martin@gnome.org>
24210 * statement.cs (Block.Emit): Don't emit unreachable code.
24211 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24212 `break' statements.
24213 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24215 2002-09-14 Martin Baulig <martin@gnome.org>
24217 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24220 2002-09-14 Martin Baulig <martin@gnome.org>
24222 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24223 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24224 be false on the ms runtime.
24226 2002-09-13 Martin Baulig <martin@gnome.org>
24228 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24229 the CS0038 error message.
24231 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24233 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24234 constant inside, return it.
24236 2002-09-12 Martin Baulig <martin@gnome.org>
24238 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24239 implicit conversion can be done between enum types.
24241 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24242 check whether an implicit conversion to the current enum's UnderlyingType
24243 exists and report an error if not.
24245 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24246 without debugging support.
24248 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24249 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24251 2002-09-12 Martin Baulig <martin@gnome.org>
24253 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24255 * ecore.cs (IMemberExpr.DeclaringType): New property.
24256 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24257 nonstatic member of an outer type (CS0038).
24259 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24261 * driver.cs: Activate the using-error detector at warning level
24262 4 (at least for MS-compatible APIs).
24264 * namespace.cs (VerifyUsing): Small buglett fix.
24266 * pending.cs (PendingImplementation): pass the container pointer.
24268 * interface.cs (GetMethods): Allow for recursive definition. Long
24269 term, I would like to move every type to support recursive
24270 definitions, not the current ordering mechanism that we have right
24273 The situation is this: Attributes are handled before interfaces,
24274 so we can apply attributes to interfaces. But some attributes
24275 implement interfaces, we will now handle the simple cases
24276 (recursive definitions will just get an error).
24278 * parameter.cs: Only invalidate types at the end if we fail to
24281 2002-09-09 Martin Baulig <martin@gnome.org>
24283 * ecore.cs (PropertyExpr.Emit): Also check for
24284 TypeManager.system_int_array_get_length so this'll also work when
24285 compiling corlib. Fixes #30003.
24287 2002-09-09 Martin Baulig <martin@gnome.org>
24289 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24290 and throw an exception if we can't get the type's size. Fixed #30040,
24293 2002-09-09 Martin Baulig <martin@gnome.org>
24295 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24297 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24298 context. Fixes bug #30027.
24300 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24301 virtual functions. Fixes bug #30043, added test-164.cs.
24303 2002-09-08 Ravi Pratap <ravi@ximian.com>
24305 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24307 2002-09-08 Nick Drochak <ndrochak@gol.com>
24309 * driver.cs: Use an object to get the windows codepage since it's not a
24312 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24314 * statement.cs (For.Emit): for infinite loops (test == null)
24315 return whether there is a break inside, not always "true".
24317 * namespace.cs (UsingEntry): New struct to hold the name of the
24318 using definition, the location where it is defined, and whether it
24319 has been used in a successful type lookup.
24321 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24326 2002-09-06 Ravi Pratap <ravi@ximian.com>
24328 * attribute.cs : Fix incorrect code which relied on catching
24329 a NullReferenceException to detect a null being passed in
24330 where an object was expected.
24332 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24334 * statement.cs (Try): flag the catch variable as assigned
24336 * expression.cs (Cast): Simplified by using ResolveType instead of
24337 manually resolving.
24339 * statement.cs (Catch): Fix bug by using ResolveType.
24341 2002-09-06 Ravi Pratap <ravi@ximian.com>
24343 * expression.cs (BetterConversion): Special case for when we have
24344 a NullLiteral as the argument and we have to choose between string
24345 and object types - we choose string the way csc does.
24347 * attribute.cs (Attribute.Resolve): Catch the
24348 NullReferenceException and report error #182 since the Mono
24349 runtime no more has the bug and having this exception raised means
24350 we tried to select a constructor which takes an object and is
24353 2002-09-05 Ravi Pratap <ravi@ximian.com>
24355 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24356 message (1502, 1503) when we can't locate a method after overload
24357 resolution. This is much more informative and closes the bug
24360 * interface.cs (PopulateMethod): Return if there are no argument
24361 types. Fixes a NullReferenceException bug.
24363 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24364 expressions too. Previously we were checking only in one place for
24365 positional arguments leaving out named arguments.
24367 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24368 type to the enum type is not allowed. Remove code corresponding to
24371 (ConvertNumericExplicit): Allow explicit conversions from
24372 the underlying type to enum type. This precisely follows the spec
24373 and closes a bug filed by Gonzalo.
24375 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24378 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24380 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24382 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24383 it was important that we stored the right value after the
24384 reduction in `converted'.
24386 2002-09-04 Martin Baulig <martin@gnome.org>
24388 * location.cs (Location.SymbolDocument): Use full pathnames for the
24391 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24393 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24394 of the expression resolve mechanism, because that will catch the
24395 SimpleName error failures.
24397 (Conditional): If we can not resolve the
24398 expression, return, do not crash.
24400 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24403 (location): display token name instead of its number.
24405 2002-08-28 Martin Baulig <martin@gnome.org>
24407 * expression.cs (Binary.ResolveOperator): Don't silently return
24408 but return an error if an operator cannot be applied between two
24411 2002-08-28 Martin Baulig <martin@gnome.org>
24413 * class.cs (Constructor.Define): Set the permission attributes
24414 correctly instead of making all constructors public.
24416 2002-08-28 Martin Baulig <martin@gnome.org>
24418 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24419 for private members before reporting a CS0103; if we find anything,
24422 2002-08-28 Martin Baulig <martin@gnome.org>
24424 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24425 to check whether `closure_start_type == closure_invocation_type',
24426 we also need to check whether `m.DeclaringType == closure_invocation_type'
24427 before bypassing the permission checks. We might be accessing
24428 protected/private members from the base class.
24429 (TypeManager.RealMemberLookup): Only set private_ok if private
24430 members were requested via BindingFlags.NonPublic.
24432 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24434 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24435 MethodGroupExpr.IsExplicitImpl if appropriate.
24436 (Invocation.DoResolve): Don't report the CS0120 for explicit
24437 interface implementations.
24439 2002-08-27 Martin Baulig <martin@gnome.org>
24441 * expression.cs (Invocation.DoResolve): If this is a static
24442 method and we don't have an InstanceExpression, we must report
24445 2002-08-25 Martin Baulig <martin@gnome.org>
24447 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24448 `==' between a valuetype and an object.
24450 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24452 * ecore.cs (TypeExpr): Provide a ToString method.
24454 2002-08-24 Martin Baulig <martin@gnome.org>
24456 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24457 now called proggie.dbg and it's a binary file.
24459 2002-08-23 Martin Baulig <martin@gnome.org>
24461 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24463 2002-08-23 Martin Baulig <martin@gnome.org>
24465 * struct.cs (MyStructInfo.ctor): Make this work with empty
24466 structs; it's not allowed to use foreach() on null.
24468 2002-08-23 Martin Baulig <martin@gnome.org>
24470 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24471 writer the full pathname of the generated assembly.
24473 2002-08-23 Martin Baulig <martin@gnome.org>
24475 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24476 A `finally' block never returns or breaks; improved handling of
24479 2002-08-23 Martin Baulig <martin@gnome.org>
24481 * statement.cs (Throw.Resolve): Allow `throw null'.
24483 2002-08-23 Martin Baulig <martin@gnome.org>
24485 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24486 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24487 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24488 MemberLookup would return a wrong event if this is an explicit
24489 interface implementation and the class has an event with the same
24492 2002-08-23 Martin Baulig <martin@gnome.org>
24494 * statement.cs (Block.AddChildVariableNames): New public method.
24495 (Block.AddChildVariableName): Likewise.
24496 (Block.IsVariableNameUsedInChildBlock): Likewise.
24497 (Block.AddVariable): Check whether a variable name has already
24498 been used in a child block.
24500 * cs-parser.jay (declare_local_variables): Mark all variable names
24501 from the current block as being used in a child block in the
24504 2002-08-23 Martin Baulig <martin@gnome.org>
24506 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24507 find the symbol writer.
24509 * driver.cs: csc also allows the arguments to /define being
24510 separated by commas, not only by semicolons.
24512 2002-08-23 Martin Baulig <martin@gnome.org>
24514 * interface.cs (Interface.GetMembers): Added static check for events.
24516 2002-08-15 Martin Baulig <martin@gnome.org>
24518 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24519 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24521 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24522 why the MethodData.EmitDestructor() change was necessary.
24524 2002-08-20 Martin Baulig <martin@gnome.org>
24526 * class.cs (TypeContainer.FindMembers): Added static check for events.
24528 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24530 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24531 use Type.GetEvents(), not Type.FindMembers().
24533 2002-08-20 Martin Baulig <martin@gnome.org>
24535 * decl.cs (MemberCache): Added a special method cache which will
24536 be used for method-only searched. This ensures that a method
24537 search will return a MethodInfo with the correct ReflectedType for
24540 2002-08-20 Martin Baulig <martin@gnome.org>
24542 * decl.cs (DeclSpace.FindMembers): Made this public.
24544 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24546 * delegate.cs: fixed build on windows.
24547 [FIXME: Filed as bug #29150: MCS must report these errors.]
24549 2002-08-19 Ravi Pratap <ravi@ximian.com>
24551 * ecore.cs (StandardConversionExists): Return a false
24552 if we are trying to convert the void type to anything else
24553 since that is not allowed.
24555 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24556 we flag error 70 in the event an event is trying to be accessed
24557 directly from outside the declaring type.
24559 2002-08-20 Martin Baulig <martin@gnome.org>
24561 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24562 MemberCache from typemanager.cs to decl.cs.
24564 2002-08-19 Martin Baulig <martin@gnome.org>
24566 * class.cs (TypeContainer): Implement IMemberContainer.
24567 (TypeContainer.DefineMembers): Create the MemberCache.
24568 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24569 return public members if BindingFlags.Public was given, check
24570 whether members are static.
24572 2002-08-16 Martin Baulig <martin@gnome.org>
24574 * decl.cs (DeclSpace.Define): Splitted this in Define and
24575 DefineMembers. DefineMembers is called first and initializes the
24578 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24579 DefineMembers() on all our DeclSpaces.
24581 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24582 but call DefineMembers() on all nested interfaces. We call their
24583 Define() in our new Define() function.
24585 * interface.cs (Interface): Implement IMemberContainer.
24586 (Interface.Define): Moved all code except the attribute stuf to
24588 (Interface.DefineMembers): Initialize the member cache.
24590 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24591 need this anymore since we can use MemberCache.FindMembers directly.
24593 2002-08-19 Martin Baulig <martin@gnome.org>
24595 * typemanager.cs (MemberCache): When creating the cache for an
24596 interface type, add all inherited members.
24597 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24598 to `out bool used_cache' and documented it.
24599 (TypeManager.MemberLookup): If we already used the cache in the first
24600 iteration, we don't need to do the interfaces check.
24602 2002-08-19 Martin Baulig <martin@gnome.org>
24604 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24605 here from IMemberFinder and don't implement this interface anymore.
24606 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24608 * typemanager.cs (IMemberFinder): This interface is now only used by
24609 classes which actually support the member cache.
24610 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24611 since we only put DeclSpaces into this Hashtable.
24612 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24613 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24615 2002-08-16 Martin Baulig <martin@gnome.org>
24617 * typemanager.cs (ICachingMemberFinder): Removed.
24618 (IMemberFinder.MemberCache): New property.
24619 (TypeManager.FindMembers): Merged this with RealFindMembers().
24620 This function will never be called from TypeManager.MemberLookup()
24621 so we can't use the cache here, just the IMemberFinder.
24622 (TypeManager.MemberLookup_FindMembers): Check whether the
24623 IMemberFinder has a MemberCache and call the cache's FindMembers
24625 (MemberCache): Rewrote larger parts of this yet another time and
24626 cleaned it up a bit.
24628 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24630 * driver.cs (LoadArgs): Support quoting.
24632 (Usage): Show the CSC-like command line arguments.
24634 Improved a few error messages.
24636 2002-08-15 Martin Baulig <martin@gnome.org>
24638 * typemanager.cs (IMemberContainer.Type): New property.
24639 (IMemberContainer.IsInterface): New property.
24641 The following changes are conditional to BROKEN_RUNTIME, which is
24642 defined at the top of the file.
24644 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24645 class'es members, but add all members from TypeHandle.ObjectType
24646 if we're an interface.
24647 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24648 is the current type.
24649 (MemberCache.CacheEntry.Container): Removed this field.
24650 (TypeHandle.GetMembers): Include inherited members.
24652 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24654 * typemanager.cs: fixed compilation and added a comment on a field that
24657 2002-08-15 Martin Baulig <martin@gnome.org>
24659 * class.cs (ConstructorInitializer.Resolve): In the
24660 Expression.MemberLookup call, use the queried_type as
24663 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24664 declared' attribute, it's always true.
24665 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24666 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24667 temporary wrapper for FindMembers which tells MemberLookup whether
24668 members from the base classes are included in the return value.
24669 This will go away soon.
24670 (TypeManager.MemberLookup): Use this temporary hack here; once the
24671 new MemberCache is completed, we don't need to do the DeclaredOnly
24672 looping here anymore since the MemberCache will take care of this.
24673 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24674 (MemberCache): When creating the MemberCache for a class, get
24675 members from the current class and all its base classes.
24676 (MemberCache.CacheEntry.Container): New field. This is a
24677 temporary hack until the Mono runtime is fixed to distinguish
24678 between ReflectedType and DeclaringType. It allows us to use MCS
24679 with both the MS runtime and the unfixed Mono runtime without
24680 problems and without accecting performance.
24681 (MemberCache.SearchMembers): The DeclaredOnly looping from
24682 TypeManager.MemberLookup is now done here.
24684 2002-08-14 Martin Baulig <martin@gnome.org>
24686 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24687 Type.GetFields on dynamic types but get the fields from the
24688 corresponding TypeContainer.
24689 (MyStructInfo.GetStructInfo): Added check for enum types.
24691 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24692 (MemberList.SyncRoot): Implemented.
24693 (TypeManager.FilterWithClosure): No need to check permissions if
24694 closure_start_type == closure_invocation_type, don't crash if
24695 closure_invocation_type is null.
24697 2002-08-13 Martin Baulig <martin@gnome.org>
24699 Rewrote TypeContainer.FindMembers to use a member cache. This
24700 gives us a speed increase of about 35% for the self-hosting MCS
24701 build and of about 15-20% for the class libs (both on GNU/Linux).
24703 * report.cs (Timer): New class to get enhanced profiling. This
24704 whole class is "TIMER" conditional since it remarkably slows down
24707 * class.cs (MemberList): New class. This is an IList wrapper
24708 which we're now using instead of passing MemberInfo[]'s around to
24709 avoid copying this array unnecessarily.
24710 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24711 (ICachingMemberFinder, IMemberContainer): New interface.
24712 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24713 has already been checked, otherwise use it for the name comparision.
24714 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24715 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24716 if possible. Returns a MemberList, not a MemberInfo [].
24717 (TypeHandle): New class, implements IMemberContainer. We create
24718 one instance of this class per type, it contains a MemberCache
24719 which is used to do the member lookups.
24720 (MemberCache): New class. Each instance of this class contains
24721 all members of a type and a name-based hash table.
24722 (MemberCache.FindMembers): This is our new member lookup
24723 function. First, it looks up all members of the requested name in
24724 the hash table. Then, it walks this list and sorts out all
24725 applicable members and returns them.
24727 2002-08-13 Martin Baulig <martin@gnome.org>
24729 In addition to a nice code cleanup, this gives us a performance
24730 increase of about 1.4% on GNU/Linux - not much, but it's already
24731 half a second for the self-hosting MCS compilation.
24733 * typemanager.cs (IMemberFinder): New interface. It is used by
24734 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24735 Enum, Delegate or Interface.
24736 (TypeManager.finder_to_member_finder): New PtrHashtable.
24737 (TypeManager.finder_to_container): Removed.
24738 (TypeManager.finder_to_delegate): Removed.
24739 (TypeManager.finder_to_interface): Removed.
24740 (TypeManager.finder_to_enum): Removed.
24742 * interface.cs (Interface): Implement IMemberFinder.
24744 * delegate.cs (Delegate): Implement IMemberFinder.
24746 * enum.cs (Enum): Implement IMemberFinder.
24748 * class.cs (TypeContainer): Implement IMemberFinder.
24750 2002-08-12 Martin Baulig <martin@gnome.org>
24752 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24754 2002-08-12 Martin Baulig <martin@gnome.org>
24756 * ecore.cs (ITypeExpression): New interface for expressions which
24758 (TypeExpression): Renamed to TypeLookupExpression.
24759 (Expression.DoResolve): If we're doing a types-only lookup, the
24760 expression must implement the ITypeExpression interface and we
24761 call DoResolveType() on it.
24762 (SimpleName): Implement the new ITypeExpression interface.
24763 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24764 hack, the situation that we're only looking up types can't happen
24765 anymore when this method is called. Moved the type lookup code to
24766 DoResolveType() and call it.
24767 (SimpleName.DoResolveType): This ITypeExpression interface method
24768 is now doing the types-only lookup.
24769 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24770 (ResolveFlags): Added MaskExprClass.
24772 * expression.cs (MemberAccess): Implement the ITypeExpression
24774 (MemberAccess.DoResolve): Added support for a types-only lookup
24775 when we're called via ITypeExpression.DoResolveType().
24776 (ComposedCast): Implement the ITypeExpression interface.
24778 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24779 Expression.Resolve() with ResolveFlags.Type instead.
24781 2002-08-12 Martin Baulig <martin@gnome.org>
24783 * interface.cs (Interface.Define): Apply attributes.
24785 * attribute.cs (Attribute.ApplyAttributes): Added support for
24786 interface attributes.
24788 2002-08-11 Martin Baulig <martin@gnome.org>
24790 * statement.cs (Block.Emit): Only check the "this" variable if we
24791 do not always throw an exception.
24793 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24794 whether the property has a set accessor.
24796 2002-08-11 Martin Baulig <martin@gnome.org>
24798 Added control flow analysis support for structs.
24800 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24801 with control flow analysis turned off.
24802 (IVariable): New interface.
24803 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24804 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24805 (FieldExpr.DoResolve): Resolve the instance expression with flow
24806 analysis turned off and do the definite assignment check after the
24807 resolving when we know what the expression will resolve to.
24809 * expression.cs (LocalVariableReference, ParameterReference):
24810 Implement the new IVariable interface, only call the flow analysis
24811 code if ec.DoFlowAnalysis is true.
24812 (This): Added constructor which takes a Block argument. Implement
24813 the new IVariable interface.
24814 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24815 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24816 This does the definite assignment checks for struct members.
24818 * class.cs (Constructor.Emit): If this is a non-static `struct'
24819 constructor which doesn't have any initializer, call
24820 Block.AddThisVariable() to tell the flow analysis code that all
24821 struct elements must be initialized before control returns from
24824 * statement.cs (MyStructInfo): New public class.
24825 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24826 argument to this indexer. If non-zero, check an individual struct
24827 member, not the whole struct.
24828 (FlowBranching.CheckOutParameters): Check struct members.
24829 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24830 overloaded versions of these methods which take an additional
24831 `int field_idx' argument to check struct members.
24832 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24833 overloaded versions of these methods which take an additional
24834 `string field_name' argument to check struct member.s
24835 (VariableInfo): Implement the IVariable interface.
24836 (VariableInfo.StructInfo): New public property. Returns the
24837 MyStructInfo instance of the variable if it's a struct or null.
24838 (Block.AddThisVariable): New public method. This is called from
24839 Constructor.Emit() for non-static `struct' constructor which do
24840 not have any initializer. It creates a special variable for the
24841 "this" instance variable which will be checked by the flow
24842 analysis code to ensure that all of the struct's fields are
24843 initialized before control returns from the constructor.
24844 (UsageVector): Added support for struct members. If a
24845 variable/parameter is a struct with N members, we reserve a slot
24846 in the usage vector for each member. A struct is considered fully
24847 initialized if either the struct itself (slot 0) or all its
24848 members are initialized.
24850 2002-08-08 Martin Baulig <martin@gnome.org>
24852 * driver.cs (Driver.MainDriver): Only report an error CS5001
24853 if there were no compilation errors.
24855 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24856 `UnsafeContext' property to determine whether the parent is in
24857 unsafe context rather than checking the parent's ModFlags:
24858 classes nested in an unsafe class are unsafe as well.
24860 2002-08-08 Martin Baulig <martin@gnome.org>
24862 * statement.cs (UsageVector.MergeChildren): Distinguish between
24863 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24864 we return. Added test17() and test18() to test-154.cs.
24866 2002-08-08 Martin Baulig <martin@gnome.org>
24868 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24869 Family access, make sure the invoking type isn't a subclass of the
24870 queried type (that'd be a CS1540).
24872 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24873 this method which takes an additional `Type invocation_type'.
24875 * expression.cs (BaseAccess.DoResolve): Use the base type as
24876 invocation and query type.
24877 (MemberAccess.DoResolve): If the lookup failed and we're about to
24878 report a CS0122, try a lookup with the ec.ContainerType - if this
24879 succeeds, we must report a CS1540.
24881 2002-08-08 Martin Baulig <martin@gnome.org>
24883 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24884 (MethodGroupExpr): Implement the IMemberExpr interface.
24886 * expression (MemberAccess.ResolveMemberAccess): No need to have
24887 any special code for MethodGroupExprs anymore, they're now
24890 2002-08-08 Martin Baulig <martin@gnome.org>
24892 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24893 Family, FamANDAssem and FamORAssem permissions.
24894 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24896 2002-08-08 Martin Baulig <martin@gnome.org>
24898 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24899 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24902 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24904 * driver.cs: implemented /resource option to embed managed resources.
24906 2002-08-07 Martin Baulig <martin@gnome.org>
24908 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24909 (FieldBase.HasFieldInitializer): New public property.
24910 (FieldBase.GetInitializerExpression): New public method. Resolves and
24911 returns the field initializer and makes sure it is only resolved once.
24912 (TypeContainer.EmitFieldInitializers): Call
24913 FieldBase.GetInitializerExpression to get the initializer, this ensures
24914 that it isn't resolved multiple times.
24916 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24917 the resolving process (SimpleName/MemberLookup) that we're currently
24918 emitting a field initializer (which must not access any instance members,
24919 this is an error CS0236).
24921 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24922 argument, if the `IsFieldInitializer' flag is set, we must report and
24923 error CS0236 and not an error CS0120.
24925 2002-08-07 Martin Baulig <martin@gnome.org>
24927 * ecore.cs (IMemberExpr): New public interface.
24928 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24929 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24930 if the expression is an IMemberExpr.
24932 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24933 to be null, implicitly default to `this' if we're non-static in
24934 this case. Simplified the code a lot by using the new IMemberExpr
24935 interface. Also fixed bug #28176 here.
24937 2002-08-06 Martin Baulig <martin@gnome.org>
24939 * cs-parser.jay (SimpleLookup): Removed. We need to create
24940 ParameterReferences during semantic analysis so that we can do a
24941 type-only search when resolving Cast, TypeOf and SizeOf.
24942 (block): Pass the `current_local_parameters' to the Block's
24945 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24946 argument to the constructor.
24947 (ConstructorInitializer.Resolve): Create a temporary implicit
24948 block with the parameters.
24950 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24951 references here if we aren't doing a type-only search.
24953 * statement.cs (Block): Added constructor which takes a
24954 `Parameters parameters' argument.
24955 (Block.Parameters): New public property.
24957 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24958 to `Parameters' and made it public readonly.
24960 2002-08-06 Martin Baulig <martin@gnome.org>
24962 * ecore.cs (Expression.Warning): Made this public as well.
24964 * report.cs (Report.Debug): Print the contents of collections.
24966 2002-08-06 Martin Baulig <martin@gnome.org>
24968 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24969 used to tell Resolve() which kinds of expressions it may return.
24970 (Expression.Resolve): Added overloaded version of this method which
24971 takes a `ResolveFlags flags' argument. This can be used to tell
24972 Resolve() which kinds of expressions it may return. Reports a
24974 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24975 ResolveFlags.SimpleName.
24976 (Expression.Error118): Added overloaded version of this method which
24977 takes a `ResolveFlags flags' argument. It uses the flags to determine
24978 which kinds of expressions are allowed.
24980 * expression.cs (Argument.ResolveMethodGroup): New public method.
24981 Resolves an argument, but allows a MethodGroup to be returned.
24982 This is used when invoking a delegate.
24984 * TODO: Updated a bit.
24986 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24988 Fixed compilation with csc.
24990 * ecore.cs: Expression.Error made public. Is this correct? Should
24991 Warning be made public too?
24993 * expression.cs: use ea.Location instead of ea.loc.
24994 [FIXME: Filed as bug #28607: MCS must report these errors.]
24996 2002-08-06 Martin Baulig <martin@gnome.org>
24998 * ecore.cs (Expression.loc): Moved the location here instead of
24999 duplicating it in all derived classes.
25000 (Expression.Location): New public property.
25001 (Expression.Error, Expression.Warning): Made them non-static and
25002 removed the location argument.
25003 (Expression.Warning): Added overloaded version which takes an
25004 `int level' argument.
25005 (Expression.Error118): Make this non-static and removed the
25006 expression and location arguments.
25007 (TypeExpr): Added location argument to the constructor.
25009 * expression.cs (StaticCallExpr): Added location argument to
25011 (Indirection, PointerArithmetic): Likewise.
25012 (CheckedExpr, UnCheckedExpr): Likewise.
25013 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25014 (StringPtr): Likewise.
25017 2002-08-05 Martin Baulig <martin@gnome.org>
25019 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25021 * assign.cs (Assign.DoResolve): Check whether the source
25022 expression is a value or variable.
25024 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25025 while resolving the corresponding blocks.
25027 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25028 an error, don't silently return null.
25030 * statement.cs (Block.AddVariable): Do the error reporting here
25031 and distinguish between CS0128 and CS0136.
25032 (Block.DoResolve): Report all unused labels (warning CS0164).
25033 (LabeledStatement): Pass the location to the constructor.
25034 (LabeledStatement.HasBeenReferenced): New property.
25035 (LabeledStatement.Resolve): Set it to true here.
25037 * statement.cs (Return.Emit): Return success even after reporting
25038 a type mismatch error (CS0126 or CS0127), this is what csc does and
25039 it avoids confusing the users with any consecutive errors.
25041 2002-08-05 Martin Baulig <martin@gnome.org>
25043 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25045 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25047 * expression.cs (MemberAccess.DoResolve): Silently return if an
25048 error has already been reported.
25050 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25051 error has already been reported.
25053 2002-08-05 Martin Baulig <martin@gnome.org>
25055 * statement.cs (UsageVector): Only initialize the `parameters'
25056 vector if we actually have any "out" parameters.
25058 2002-08-05 Martin Baulig <martin@gnome.org>
25060 * expression.cs (Binary.ResolveOperator): When combining delegates,
25061 they must have the same type.
25063 2002-08-05 Martin Baulig <martin@gnome.org>
25065 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25066 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25067 work with the ms runtime and we also don't need it: if we're a
25068 PropertyBuilder and not in the `indexer_arguments' hash, then we
25069 are a property and not an indexer.
25071 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25072 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25073 since the latter one doesn't work with the ms runtime.
25075 2002-08-03 Martin Baulig <martin@gnome.org>
25077 Fixed bugs #27998 and #22735.
25079 * class.cs (Method.IsOperator): New public field.
25080 (Method.CheckBase): Report CS0111 if there's already a method
25081 with the same parameters in the current class. Report CS0508 when
25082 attempting to change the return type of an inherited method.
25083 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25084 and it's not marked abstract or extern.
25085 (PropertyBase): New abstract base class for Property and Indexer.
25086 (PropertyBase.CheckBase): Moved here from Property and made it work
25088 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25089 the same so we can reuse it there.
25090 (Property, Indexer): Derive from PropertyBase.
25091 (MethodSignature.inheritable_property_signature_filter): New delegate
25092 to find properties and indexers.
25094 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25095 argument and improved error reporting.
25097 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25098 EmptyReadOnlyParameters and made it a property.
25100 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25101 version of this method which takes a `PropertyInfo indexer'.
25102 (TypeManager.RegisterIndexer): New method.
25104 * class.cs: Added myself as author of this file :-)
25106 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25108 * class.cs: fixed compilation on windoze.
25110 2002-08-03 Martin Baulig <martin@gnome.org>
25112 * interface.cs (Interface.GetInterfaceBases): Check whether all
25113 base interfaces are at least as accessible than the current one.
25115 * class.cs (TypeContainer.GetClassBases): Check whether base types
25116 are at least as accessible than the current type.
25117 (TypeContainer.AsAccessible): Implemented and made non-static.
25118 (MemberBase.CheckParameters): Report errors if the accessibility
25121 * delegate.cs (Delegate.Delegate): The default visibility is
25122 internal for top-level types and private for nested types.
25123 (Delegate.Define): Report errors if the accessibility checks fail.
25125 * enum.cs (Enum.Enum): The default visibility is internal for
25126 top-level types and private for nested types.
25127 (Enum.DefineType): Compute the correct visibility.
25129 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25130 function which takes a `bool is_toplevel' instead of a TypeContainer.
25132 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25135 2002-08-02 Martin Baulig <martin@gnome.org>
25137 * expression.cs (LocalVariableReferenc): Added constructor which
25138 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25139 (LocalVariableReference.IsReadOnly): New property.
25140 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25141 variable is readonly, use our own readonly flag to do this; you can
25142 use the new constructor to get a writable reference to a read-only
25145 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25146 reference to the local variable.
25148 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25150 * rootcontext.cs (ResolveCore): Also include System.Exception
25152 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25153 we reach an EmptyStatement.
25155 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25158 * expression.cs (Binary.ResolveOperator): Check error result in
25161 use brtrue/brfalse directly and avoid compares to null.
25163 2002-08-02 Martin Baulig <martin@gnome.org>
25165 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25166 Fixes bug #28407, added test-155.cs.
25168 2002-08-01 Martin Baulig <martin@gnome.org>
25170 * class.cs (Event.EmitDefaultMethod): Make this work with static
25171 events. Fixes #28311, added verify-3.cs.
25173 2002-08-01 Martin Baulig <martin@gnome.org>
25175 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25176 `is_disposable' fields.
25177 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25178 `hm.is_disposable' if we're using the collection pattern.
25179 (Foreach.EmitCollectionForeach): Use the correct type for the
25180 enumerator's local variable, only emit the try/finally block if
25181 necessary (fixes #27713).
25183 2002-08-01 Martin Baulig <martin@gnome.org>
25185 * ecore.cs (Expression.report118): Renamed to Error118 and made
25188 * statement.cs (Throw.Resolve): Check whether the expression is of
25189 the correct type (CS0118) and whether the type derives from
25190 System.Exception (CS0155).
25191 (Catch.Resolve): New method. Do the type lookup here and check
25192 whether it derives from System.Exception (CS0155).
25193 (Catch.CatchType, Catch.IsGeneral): New public properties.
25195 * typemanager.cs (TypeManager.exception_type): Added.
25197 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25199 * driver.cs: Updated About function.
25201 2002-07-31 Martin Baulig <martin@gnome.org>
25203 Implemented Control Flow Analysis.
25205 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25206 (EmitContext.CurrentBranching): Added.
25207 (EmitContext.StartFlowBranching): Added.
25208 (EmitContext.EndFlowBranching): Added.
25209 (EmitContext.KillFlowBranching): Added.
25210 (EmitContext.IsVariableAssigned): Added.
25211 (EmitContext.SetVariableAssigned): Added.
25212 (EmitContext.IsParameterAssigned): Added.
25213 (EmitContext.SetParameterAssigned): Added.
25214 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25215 Added control flow analysis stuff here.
25217 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25218 resolve the expression as lvalue.
25219 (LocalVariableReference.DoResolve): Check whether the variable has
25220 already been assigned.
25221 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25222 the parameter as assigned here.
25223 (ParameterReference.DoResolve): Check whether the parameter has already
25225 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25226 expression as lvalue.
25228 * statement.cs (FlowBranching): New class for the flow analysis code.
25229 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25230 (LabeledStatement.IsDefined): New public property.
25231 (LabeledStatement.AddUsageVector): New public method to tell flow
25232 analyis that the label may be reached via a forward jump.
25233 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25235 (VariableInfo.Number): New public field. This is used by flow analysis
25236 to number all locals of a block.
25237 (Block.CountVariables): New public property. This is the number of
25238 local variables in this block (including the locals from all parent
25240 (Block.EmitMeta): Number all the variables.
25242 * statement.cs: Added flow analysis support to all classes.
25244 2002-07-31 Martin Baulig <martin@gnome.org>
25246 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25247 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25248 then use this argument.
25250 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25252 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25253 use this to specify /define options.
25255 2002-07-29 Martin Baulig <martin@gnome.org>
25257 * statement.cs (Fixed): Moved all code that does variable lookups
25258 and resolvings from Emit to Resolve.
25260 * statement.cs (For): Moved all code that does variable lookups
25261 and resolvings from Emit to Resolve.
25263 * statement.cs (Using): Moved all code that does variable lookups
25264 and resolvings from Emit to Resolve.
25266 2002-07-29 Martin Baulig <martin@gnome.org>
25268 * attribute.cs (Attribute.Resolve): Explicitly catch a
25269 System.NullReferenceException when creating the
25270 CustromAttributeBuilder and report a different warning message.
25272 2002-07-29 Martin Baulig <martin@gnome.org>
25274 * support.cs (ParameterData.ParameterName): Added method to
25275 get the name of a parameter.
25277 * typemanager.cs (TypeManager.IsValueType): New public method.
25279 2002-07-29 Martin Baulig <martin@gnome.org>
25281 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25282 is a flag which specifies that it's either ref or out.
25283 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25284 the out parameter to `out Parameter.Modifier mod', also set the
25285 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25287 * support.cs (InternalParameters.ParameterModifier): Distinguish
25288 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25289 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25291 * expression.cs (Argument.GetParameterModifier): Distinguish
25292 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25293 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25295 2002-07-29 Martin Baulig <martin@gnome.org>
25297 * expression.cs (ParameterReference.ParameterReference): Added
25298 `Location loc' argument to the constructor.
25300 * cs-parser.jay: Pass location to ParameterReference.
25302 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25304 * statement.cs (Try): Initialize the location.
25306 * cs-parser.jay: pass location to Try.
25308 * expression.cs (Unary.Reduce): Change the prototype to return
25309 whether a constant fold could be performed or not. The result is
25310 returned in an out parameters. In the case of Indirection and
25311 AddressOf, we want to perform the full tests.
25313 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25315 * statement.cs (Statement.Emit): Flag dead code.
25317 2002-07-27 Andrew Birkett <andy@nobugs.org>
25319 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25321 2002-07-27 Martin Baulig <martin@gnome.org>
25323 * class.cs (MethodData.Define): Put back call to
25324 TypeManager.AddMethod(), accidentally commented this out.
25326 * report.cs (Debug): New public method to print debugging information,
25327 this is `[Conditional ("DEBUG")]'.
25329 2002-07-26 Martin Baulig <martin@gnome.org>
25331 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25332 (switch_statement): Push the current_block to the switch_stack and
25333 pop it again when we're done with the switch.
25334 (switch_section): The new block is a child of the current_block.
25335 Fixes bug #24007, added test-152.cs.
25337 2002-07-27 Martin Baulig <martin@gnome.org>
25339 * expression.cs (Invocation.EmitArguments): When calling a varargs
25340 function with only its fixed arguments, we need to pass an empty
25343 2002-07-27 Martin Baulig <martin@gnome.org>
25345 Mono 0.13 has been released.
25347 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25349 * driver.cs: Rename --resource to --linkres, because that is what
25350 we do currently, we dont support --resource yet.
25352 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25354 2002-07-25 Martin Baulig <martin@gnome.org>
25356 * class.cs (MethodData): New public class. This is a `method builder'
25357 class for a method or one accessor of a Property/Indexer/Event.
25358 (MethodData.GetMethodFlags): Moved here from MemberBase.
25359 (MethodData.ApplyAttributes): Likewise.
25360 (MethodData.ApplyObsoleteAttribute): Likewise.
25361 (MethodData.ApplyConditionalAttribute): Likewise.
25362 (MethodData.ApplyDllImportAttribute): Likewise.
25363 (MethodData.CheckAbstractAndExternal): Likewise.
25364 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25365 (MethodData.Emit): Formerly known as Method.Emit().
25366 (MemberBase): Moved everything which was specific to a single
25367 accessor/method to MethodData.
25368 (Method): Create a new MethodData and call Define() and Emit() on it.
25369 (Property, Indexer, Event): Create a new MethodData objects for each
25370 accessor and call Define() and Emit() on them.
25372 2002-07-25 Martin Baulig <martin@gnome.org>
25374 Made MethodCore derive from MemberBase to reuse the code from there.
25375 MemberBase now also checks for attributes.
25377 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25378 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25380 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25381 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25382 (MemberBase.ApplyAttributes): New virtual method; applies the
25383 attributes to a method or accessor.
25384 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25385 (MemberBase.ApplyConditionalAttribute): Likewise.
25386 (MemberBase.ApplyDllImportAttribute): Likewise.
25387 (MemberBase.CheckAbstractAndExternal): Likewise.
25388 (MethodCore.ParameterTypes): This is now a property instead of a
25389 method, it's initialized from DoDefineParameters().
25390 (MethodCore.ParameterInfo): Removed the set accessor.
25391 (MethodCore.DoDefineParameters): New protected virtual method to
25392 initialize ParameterTypes and ParameterInfo.
25393 (Method.GetReturnType): We can now simply return the MemberType.
25394 (Method.GetMethodFlags): Override the MemberBase version and add
25395 the conditional flags.
25396 (Method.CheckBase): Moved some code from Define() here, call
25397 DoDefineParameters() here.
25398 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25399 here to avoid some larger code duplication.
25400 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25401 ensure that abstract and external accessors don't declare a body.
25403 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25404 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25405 lookup in the attribute's parent classes, so we need to abort as soon
25406 as we found the first match.
25407 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25408 the attribute has no arguments.
25410 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25413 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25415 * cs-parser.jay: reverted previous patch.
25417 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25419 * cs-parser.jay: fixed bug #22119.
25421 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25423 * attribute.cs: fixed compilation. The error was:
25424 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25425 be assigned to before control leaves the current method."
25426 [FIXME: Filed as bug #28186: MCS must report this error.]
25428 2002-07-25 Martin Baulig <martin@gnome.org>
25430 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25431 method to pull the condition name ouf of a Conditional attribute.
25432 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25433 the obsolete message and error flag out of an Obsolete attribute.
25435 * class.cs (Method.GetMethodFlags): New public method to get the
25436 TypeManager.MethodFlags for this method.
25437 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25439 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25440 if we're overriding a virtual function, set the new private variable
25441 `parent_method'; call the new TypeManager.AddMethod().
25443 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25444 the MethodBuilder and the Method in a PtrHashtable.
25445 (TypeManager.builder_to_method): Added for this purpose.
25446 (TypeManager.MethodFlags): Added IsObsoleteError.
25447 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25448 Obsolete and Conditional arguments in MethodBuilders. If we discover
25449 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25450 the message from the attribute.
25452 2002-07-24 Martin Baulig <martin@gnome.org>
25454 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25455 preprocessor directives, ensure that the argument to #define/#undef is
25456 exactly one identifier and that it's actually an identifier.
25458 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25461 2002-07-24 Martin Baulig <martin@gnome.org>
25463 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25464 initialize it to TypeManager.object_type in the constructor.
25465 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25466 of the `hm.get_current' method if we're using the collection pattern.
25467 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25468 for the explicit conversion to make it work when we're using the collection
25469 pattern and the `Current' property has a different return type than `object'.
25472 2002-07-24 Martin Baulig <martin@gnome.org>
25474 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25475 does not match, but don't report any errors. This method is called in
25476 order for all methods in a MethodGroupExpr until a matching method is
25477 found, so we don't want to bail out if the first method doesn't match.
25478 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25479 matches, report the 123. Fixes #28070.
25481 2002-07-24 Martin Baulig <martin@gnome.org>
25483 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25484 TypeManager.TypeToCoreType() to the top of the method so the
25485 following equality checks will work. Fixes #28107.
25487 2002-07-24 Martin Baulig <martin@gnome.org>
25489 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25490 operand is of type uint, and the other operand is of type sbyte,
25491 short or int, the operands are converted to type long." -
25492 Actually do what this comment already told us. Fixes bug #28106,
25495 2002-07-24 Martin Baulig <martin@gnome.org>
25497 * class.cs (MethodBase): New abstract class. This is now a base
25498 class for Property, Indexer and Event to avoid some code duplication
25499 in their Define() and DefineMethods() methods.
25500 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25501 generic methods for Define() and DefineMethods().
25502 (FieldBase): Derive from MemberBase, not MemberCore.
25503 (Property): Derive from MemberBase, not MemberCore.
25504 (Property.DefineMethod): Moved all the code from this method to the
25505 new MethodBase.DefineAccessor(), just call it with appropriate
25507 (Property.Define): Call the new Property.DoDefine(), this does some
25508 sanity checks and we don't need to duplicate the code everywhere.
25509 (Event): Derive from MemberBase, not MemberCore.
25510 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25511 accessors, this will also make them work with interface events.
25512 (Indexer): Derive from MemberBase, not MemberCore.
25513 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25514 (Indexer.Define): Use the new MethodBase functions.
25516 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25517 argument to the constructor.
25518 (Interface.FindMembers): Added support for interface events.
25519 (Interface.PopluateEvent): Implemented.
25521 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25523 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25525 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25526 but this is required to check for a method name being the same as
25527 the containing class.
25531 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25533 * interface.cs: initialize variable.
25535 2002-07-23 Martin Baulig <martin@gnome.org>
25537 Implemented the IndexerName attribute in interfaces.
25539 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25540 name if this is an explicit interface implementation.
25541 (Indexer.InterfaceIndexerName): New public variable. If we're
25542 implementing an interface indexer, this is the IndexerName in that
25543 interface. Otherwise, it's the IndexerName.
25544 (Indexer.DefineMethod): If we're implementing interface indexer,
25545 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25546 and Pending.ImplementIndexer methods.
25547 (Indexer.Define): Also define the PropertyBuilder if we're
25548 implementing an interface indexer and this is neither an explicit
25549 interface implementation nor do the IndexerName match the one in
25552 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25553 If a method is defined here, then we always need to create a proxy
25554 for it. This is used when implementing interface indexers.
25555 (Pending.IsInterfaceIndexer): New public method.
25556 (Pending.ImplementIndexer): New public method.
25557 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25558 This is used when implementing interface indexers to define a proxy
25560 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25561 define a proxy if necessary.
25563 * interface.cs (Interface.IndexerName): New public variable.
25564 (Interface.PopulateIndexer): Set the IndexerName.
25565 (Interface.DefineIndexers): New private method. Populate all the
25566 indexers and make sure their IndexerNames match.
25568 * typemanager.cs (IndexerPropertyName): Added support for interface
25571 2002-07-22 Martin Baulig <martin@gnome.org>
25573 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25574 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25575 ret if HasReturnLabel.
25576 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25579 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25580 and set the ec.LoopBeginTryCatchLevel.
25581 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25582 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25583 the current ec.TryCatchLevel, the branch goes out of an exception
25584 block. In this case, we need to use Leave and not Br.
25586 2002-07-22 Martin Baulig <martin@gnome.org>
25588 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25589 block unless the block does not always return or it is contained in
25590 another try { ... } catch { ... } block. Fixes bug #26506.
25591 Added verify-1.cs to the test suite.
25593 2002-07-22 Martin Baulig <martin@gnome.org>
25595 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25596 then we do not always return. Fixes bug #24985.
25598 2002-07-22 Martin Baulig <martin@gnome.org>
25600 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25601 lookup on a per-class level; ie. walk up the class hierarchy until we
25602 found at least one applicable method, then choose the best among them.
25603 Fixes bug #24463 and test-29.cs.
25605 2002-07-22 Martin Baulig <martin@gnome.org>
25607 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25608 return types of the methods. The return type is not part of the
25609 signature and we must not check it to make the `new' modifier work.
25610 Fixes bug #27999, also added test-147.cs.
25611 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25613 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25614 on the method's return type.
25616 2002-07-21 Martin Baulig <martin@gnome.org>
25618 * assign.cs: Make this work if the rightmost source is a constant and
25619 we need to do an implicit type conversion. Also adding a few more tests
25620 to test-38.cs which should have caught this.
25622 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25623 target in the makefile for this. The makefile.gnu is primarily intended
25624 for end-users who don't want to debug the compiler.
25626 2002-07-21 Martin Baulig <martin@gnome.org>
25628 * assign.cs: Improved the Assign class so it can now handle embedded
25629 assignments (X = Y = Z = something). As a side-effect this'll now also
25630 consume less local variables. test-38.cs now passes with MCS, added
25631 a few new test cases to that test.
25633 2002-07-20 Martin Baulig <martin@gnome.org>
25635 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25636 instructions. Fixes bug #27977, also added test-146.cs.
25638 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25640 * cs-tokenizer.cs: fixed getHex ().
25642 2002-07-19 Martin Baulig <martin@gnome.org>
25644 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25645 not Type.GetType() to lookup the array type. This is needed when
25646 we're constructing an array of a user-defined type.
25647 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25648 single-dimensional arrays, but also for single-dimensial arrays of
25651 2002-07-19 Martin Baulig <martin@gnome.org>
25653 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25654 this function is called, it's not allowed to share LocalBuilders
25655 among ILGenerators.
25657 2002-07-19 Martin Baulig <martin@gnome.org>
25659 * expression.cs (Argument.Resolve): Report an error 118 when trying
25660 to pass a type as argument.
25662 2002-07-18 Martin Baulig <martin@gnome.org>
25664 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25665 Conv_R_Un for the signed `long' type.
25667 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25669 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25670 `expr' for the temporary result, as that will fail if we do
25671 multiple resolves on the same expression.
25673 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25675 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25676 ec.TypeContainer for looking up aliases.
25678 * class.cs (TypeContainer): Remove LookupAlias from here.
25680 * decl.cs (DeclSpace); Move here.
25682 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25684 * class.cs (FindMembers): Only call filter if the constructor
25685 bulider is not null.
25687 Also handle delegates in `NestedTypes' now. Now we will perform
25688 type lookups using the standard resolution process. This also
25691 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25692 This uses Expressions (the limited kind that can be parsed by the
25693 tree) instead of strings.
25695 * expression.cs (ComposedCast.ToString): Implement, used to flag
25696 errors since now we have to render expressions.
25698 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25701 * ecore.cs (SimpleName.ToString): ditto.
25703 * cs-parser.jay: Instead of using strings to assemble types, use
25704 Expressions to assemble the type (using SimpleName, ComposedCast,
25705 MemberAccess). This should fix the type lookups in declarations,
25706 because we were using a different code path for this.
25708 * statement.cs (Block.Resolve): Continue processing statements
25709 even when there is an error.
25711 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25713 * class.cs (Event.Define): Also remove the `remove' method from
25714 the list of pending items.
25716 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25717 generate more compact code.
25719 2002-07-17 Martin Baulig <martin@gnome.org>
25721 * const.cs (Const.LookupConstantValue): Add support for constant
25722 `unchecked' and `checked' expressions.
25723 Also adding test case test-140.cs for this.
25725 2002-07-17 Martin Baulig <martin@gnome.org>
25727 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25728 check whether mi.ReturnType implements the IEnumerator interface; the
25729 `==' and the IsAssignableFrom() will fail in this situation.
25731 2002-07-16 Ravi Pratap <ravi@ximian.com>
25733 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25736 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25738 * expression.cs: fixed bug #27811.
25740 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25742 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25743 Molaro: when we are a ref, the value already contains a pointer
25744 value, do not take the address of it.
25746 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25747 * removed mb-parser.jay and mb-tokenizer.cs
25749 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25751 * expression.cs: check against the building corlib void type.
25753 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25755 * ecore.cs: fix for valuetype static readonly fields: when
25756 initializing them, we need their address, not the address of a copy.
25758 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25760 * typemanager.cs: register also enum_type in corlib.
25762 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25764 * class.cs: allow calling this (but not base) initializers in structs.
25766 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25768 * ecore.cs: make sure we compare against the building base types
25771 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25773 * typemanager.cs: fix TypeToCoreType() to handle void and object
25774 (corlib gets no more typerefs after this change).
25776 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25778 * expression.cs (ArrayCreation.EmitArrayArguments): use
25779 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25781 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25782 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25783 array indexes, the runtime actually forbids them.
25785 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25786 for array arguments here.
25788 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25789 instead of the default for ValueTypes.
25791 (New.DoEmit): Use IsValueType instead of
25792 IsSubclassOf (value_type)
25793 (New.DoResolve): ditto.
25794 (Invocation.EmitCall): ditto.
25796 * assign.cs (Assign): ditto.
25798 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25799 Statements *are* currently doing part of their resolution during
25802 Expressions do always resolve during resolve, but statements are
25803 only required to propagate resolution to their children.
25805 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25807 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25809 (LoadAssembly): Do not add the dll if it is already specified
25811 (MainDriver): Add the System directory to the link path at the end,
25812 after all the other -L arguments.
25814 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25815 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25816 ldelem.u1) and using the opposite for sbytes.
25818 This fixes Digger, and we can finally run it.
25820 * driver.cs (UnixParseOption): Move the option parsing here.
25821 (CSCParseOption): Implement CSC-like parsing of options.
25823 We now support both modes of operation, the old Unix way, and the
25824 new CSC-like way. This should help those who wanted to make cross
25825 platform makefiles.
25827 The only thing broken is that /r:, /reference: and /lib: are not
25828 implemented, because I want to make those have the same semantics
25829 as the CSC compiler has, and kill once and for all the confussion
25830 around this. Will be doing this tomorrow.
25832 * statement.cs (Unsafe.Resolve): The state is checked during
25833 resolve, not emit, so we have to set the flags for IsUnsfe here.
25835 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25837 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25838 not catch the Error_ObjectRefRequired in SimpleName (as it is
25839 possible to have a class/instance variable name that later gets
25840 deambiguated), we have to check this here.
25842 2002-07-10 Ravi Pratap <ravi@ximian.com>
25844 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25845 make static and put into Expression.
25847 (Event.Define): Register the private field of the event with the
25848 TypeManager so that GetFieldFromEvent can get at it.
25850 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25851 keep track of the private field associated with an event which
25854 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25857 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25859 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25861 * expression.cs (Binary.EmitBranchable): this routine emits the
25862 Binary expression in a branchable context. This basically means:
25863 we need to branch somewhere, not just get the value on the stack.
25865 This works together with Statement.EmitBoolExpression.
25867 * statement.cs (Statement.EmitBoolExpression): Use
25870 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25872 * statement.cs (For): Reduce the number of jumps in loops.
25874 (For): Implement loop inversion for the For statement.
25876 (Break): We can be breaking out of a Try/Catch controlled section
25877 (foreach might have an implicit try/catch clause), so we need to
25878 use Leave instead of Br.
25880 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25881 now). If the instace expression supports IMemoryLocation, we use
25882 the AddressOf method from the IMemoryLocation to extract the
25883 address instead of emitting the instance.
25885 This showed up with `This', as we were emitting the instance
25886 always (Emit) instead of the Address of This. Particularly
25887 interesting when This is a value type, as we dont want the Emit
25888 effect (which was to load the object).
25890 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25892 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25894 * statement.cs (Checked): Set the CheckedState during the resolve
25895 process too, as the ConvCast operations track the checked state on
25896 the resolve process, and not emit.
25898 * cs-parser.jay (namespace_member_declaration): Flag that we have
25899 found a declaration when we do. This is used to flag error 1529
25901 * driver.cs: Report ok when we display the help only.
25903 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25905 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25907 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25909 * cs-tokenizer.cs (define): We also have to track locally the
25910 defines. AllDefines is just used for the Conditional Attribute,
25911 but we also need the local defines for the current source code.
25913 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25915 * statement.cs (While, For, Do): These loops can exit through a
25916 Break statement, use this information to tell whether the
25917 statement is the last piece of code.
25919 (Break): Flag that we break.
25921 * codegen.cs (EmitContexts): New `Breaks' state variable.
25923 2002-07-03 Martin Baulig <martin@gnome.org>
25925 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25926 modifiers in method declarations in structs. Otherwise, you won't
25927 be able to override things like Object.Equals().
25929 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25931 * class.cs (Method, Property, Indexer): Do not allow the public
25932 modifier to be used in explicit interface implementations.
25934 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25935 override modifiers in method declarations in structs
25937 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25939 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25940 integer or real overflow, report an error
25942 2002-07-02 Martin Baulig <martin@gnome.org>
25944 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25945 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25946 to tell the runtime about our newly created System.Object and
25947 System.ValueType types.
25949 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25951 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25952 struct instead of Ldarg/Starg.
25954 2002-07-02 Martin Baulig <martin@gnome.org>
25956 * expression.cs (Indirection.Indirection): Call
25957 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25959 2002-07-02 Martin Baulig <martin@gnome.org>
25961 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25962 ValueType, call TypeManager.TypeToCoreType() on it.
25963 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25964 the OpCodes.Newarr argument.
25966 2002-07-02 Martin Baulig <martin@gnome.org>
25968 * expression.cs (Invocation.EmitCall): When compiling corlib,
25969 replace all calls to the system's System.Array type to calls to
25970 the newly created one.
25972 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25973 System.Array methods.
25974 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25975 from the system's System.Array type which must be replaced.
25977 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25979 * typemanager.cs: load unverifiable_code_ctor so we can build
25980 corlib using the correct type. Avoid using GetTypeCode() with
25982 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25983 TypeManager.object_type to allow building corlib.
25985 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25987 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25989 2002-07-01 Martin Baulig <martin@gnome.org>
25991 * class.cs: Make the last change actually work, we need to check
25992 whether `ifaces != null' to avoid a crash.
25994 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25996 * class.cs: when we build structs without fields that implement
25997 interfaces, we need to add the interfaces separately, since there is
25998 no API to both set the size and add the interfaces at type creation
26001 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26003 * expression.cs: the dimension arguments to the array constructors
26004 need to be converted if they are a long.
26006 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26008 * class.cs: don't emit ldarg.0 if there is no parent constructor
26009 (fixes showstopper for corlib).
26011 2002-06-29 Martin Baulig <martin@gnome.org>
26013 MCS now compiles corlib on GNU/Linux :-)
26015 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26016 ie. check for MethodImplOptions.InternalCall.
26018 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26019 and TypeManager.attribute_type are null, so we must explicitly check
26020 whether parent is not null to find out whether it's an attribute type.
26021 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26022 and SetBuilder, not only if the property is neither abstract nor external.
26023 This is necessary to set the MethodImplOptions on the accessor methods.
26024 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26025 SetBuilder, see Property.Emit().
26027 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26028 populate "System.Object", "System.ValueType" and "System.Attribute" since
26029 they've already been populated from BootCorlib_PopulateCoreTypes().
26031 2002-06-29 Martin Baulig <martin@gnome.org>
26033 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26034 is the NullLiteral, we also need to make sure that target_type is not
26037 2002-06-29 Martin Baulig <martin@gnome.org>
26039 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26040 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26041 before calling BootstrapCorlib_ResolveDelegate ().
26043 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26045 * statement.cs: fixed build-breaker. All tests passed ok.
26047 2002-06-27 Martin Baulig <martin@gnome.org>
26049 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26050 for System.Decimal when compiling corlib.
26052 2002-06-27 Martin Baulig <martin@gnome.org>
26054 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26055 switch blocks which contain nothing but a default clause.
26057 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26059 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26061 2002-06-27 Martin Baulig <martin@gnome.org>
26063 * ecore.cs (PropertyExpr.PropertyExpr): Call
26064 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26066 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26067 is already a TypeBuilder.
26069 2002-06-27 Martin Baulig <martin@gnome.org>
26071 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26072 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26073 the "from an array-type to System.Array" case. This makes it work
26074 when compiling corlib.
26076 2002-06-27 Martin Baulig <martin@gnome.org>
26078 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26079 non-static PropertyExpr, set its InstanceExpression. This makes
26080 the `ICollection.Count' property work in System/Array.cs.
26082 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26084 * driver.cs: Made error handling more consistent. Errors now
26085 tracked by Report class, so many methods which used to return int
26086 now return void. Main() now prints success/failure and
26087 errors/warnings message.
26089 Renamed '--probe' compiler argument to '--expect-error'. Removed
26090 the magic number return values (123 and 124). Now, if the
26091 expected error occurs, the compiler exits with success (exit value
26092 0). If the compilation completes without seeing that particular
26093 error, the compiler exits with failure (exit value 1). The
26094 makefile in mcs/errors has been changed to handle the new behaviour.
26096 * report.cs: Made 'expected error' number a property and renamed
26097 it from 'Probe' to 'ExpectedError'.
26099 * genericparser.cs: Removed error handling support, since it is
26100 now all done by Report class.
26102 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26103 class, so parse() no longer returns an int.
26105 * namespace.cs: Use Report.Error instead of GenericParser.error
26107 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26109 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26110 TypeContainer.AddOperator): At the front of the list put the
26111 explicit implementations, so they get resolved/defined first.
26113 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26115 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26116 interface type is implemented by this TypeContainer. Used during
26117 explicit interface implementation.
26119 (Property.Define, Indexer.Define, Method.Define): Validate that
26120 the given interface in the explicit implementation is one of the
26121 base classes for the containing type.
26123 Also if we are explicitly implementing an interface, but there is
26124 no match in the pending implementation table, report an error.
26126 (Property.Define): Only define the property if we are
26127 not explicitly implementing a property from an interface. Use the
26128 correct name also for those properties (the same CSC uses,
26129 although that is really not needed).
26131 (Property.Emit): Do not emit attributes for explicitly implemented
26132 properties, as there is no TypeBuilder.
26134 (Indexer.Emit): ditto.
26136 Hiding then means that we do not really *implement* a pending
26137 implementation, which makes code fail.
26139 2002-06-22 Martin Baulig <martin@gnome.org>
26141 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26142 the return value of Object.GetType(). [FIXME: we need to do this whenever
26143 we get a type back from the reflection library].
26145 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26147 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26149 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26151 * attribute.cs: Return null if we can not look up the type.
26153 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26154 the interface types found.
26156 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26157 interface types found.
26159 * typemanager.cs (GetInterfaces): Make this routine returns alll
26160 the interfaces and work around the lame differences between
26161 System.Type and System.Reflection.Emit.TypeBuilder in the results
26162 result for GetInterfaces.
26164 (ExpandInterfaces): Given an array of interface types, expand and
26165 eliminate repeated ocurrences of an interface. This expands in
26166 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26169 2002-06-21 Martin Baulig <martin@gnome.org>
26171 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26174 2002-06-21 Martin Baulig <martin@gnome.org>
26176 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26177 and called with one of the core types, return the corresponding typebuilder for
26180 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26183 2002-06-21 Martin Baulig <martin@gnome.org>
26185 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26186 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26187 (Expression.ConvertReferenceExplicit): Likewise.
26189 * expression.cs (ElementAccess.DoResolve): Likewise.
26190 (ElementAccess.DoResolveLValue): Likewise.
26192 2002-06-10 Martin Baulig <martin@gnome.org>
26194 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26195 add the "value" parameter to the parameter list.
26197 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26200 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26202 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26203 the argument to an int, uint, long or ulong, per the spec. Also
26204 catch negative constants in array creation.
26206 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26208 * class.cs: do not allow the same interface to appear twice in
26209 the definition list.
26211 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26213 * ecore.cs: don't use ldlen with System.Array.
26215 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26217 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26219 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26221 * modifiers.cs: produce correct field attributes for protected
26222 internal. Easy fix so miguel can work on ther harder stuff:-)
26224 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26226 * pending.cs: New file. Move the code from class.cs here.
26227 Support clearning the pending flag for all methods (when not doing
26228 explicit interface implementation).
26230 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26232 * rootcontext.cs: added a couple more types needed to bootstrap.
26234 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26236 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26237 constructor in the type, instead of any constructor in the type
26238 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26239 a bug in the Mono runtime when applying the params attribute).
26241 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26242 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26244 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26246 * expression.cs (Unary.ResolveOperator): Use TypeManager
26247 to resolve the type.
26249 2002-06-13 Ravi Pratap <ravi@ximian.com>
26251 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26254 * enum.cs (AddEnumMember): Add support to store the attributes associated
26255 with each member too.
26257 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26258 field builders too - this takes care of the enum member case.
26260 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26262 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26263 address-of operator on both value types and pointers.
26265 2002-06-10 Martin Baulig <martin@gnome.org>
26267 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26268 PropertyBuilder to the `property_builders' list.
26270 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26271 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26272 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26273 find any indexers which are inherited from an interface.
26275 2002-06-09 Martin Baulig <martin@gnome.org>
26277 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26278 the same type as the constant if necessary. There's also a test-130.cs
26281 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26283 * typemanager.cs (TypeManager.ChangeType): Previously known as
26284 Enum.ChangeEnumType().
26286 2002-06-09 Martin Baulig <martin@gnome.org>
26288 * expression.cs (Cast.TryReduce): Added support for consts.
26290 2002-06-08 Ravi Pratap <ravi@ximian.com>
26292 * class.cs (Accessor): Hold attributes information so we can pass
26295 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26296 Modify to pass in attributes attached to the methods.
26298 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26300 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26301 to handle the Accessor kind :-)
26303 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26305 2002-06-08 Martin Baulig <martin@gnome.org>
26307 * expression.cs (Unary.TryReduceNegative): Added support for
26310 2002-06-08 Martin Baulig <martin@gnome.org>
26312 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26313 name can't be found in the `defined_names' - the caller will do a
26314 MemberLookup in this case and thus find methods in System.Enum
26315 such as Enum.IsDefined().
26317 2002-06-08 Martin Baulig <martin@gnome.org>
26319 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26320 Convert.ChangeType() which works with TypeBuilder created types.
26321 (Enum.LookupEnumValue, Enum.Define): Use it here.
26323 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26324 `TypeBuilder.BaseType != null' check.
26325 (TypeContainer.FindMembers): Only lookup parent members if we
26326 actually have a parent.
26327 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26328 (ConstructorInitializer.Resolve): Likewise.
26330 * interface.cs (Interface.FindMembers): Added
26331 `TypeBuilder.BaseType != null' check.
26333 * rootcontext.cs (RootContext.ResolveCore): Added
26334 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26335 classes_second_stage.
26337 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26338 debug_type and trace_type when compiling with --nostdlib.
26340 2002-06-07 Martin Baulig <martin@gnome.org>
26342 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26343 (AddField): Set it to true when adding a non-static field.
26344 (DefineType): Use `have_nonstatic_fields' to find out whether we
26345 have non-static fields, not `Fields != null'.
26347 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26349 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26350 dereferencing a null on the static-field code path)
26352 2002-05-30 Martin Baulig <martin@gnome.org>
26354 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26355 to take command line arguments. Use reflection to call the new
26356 custom `Initialize' function on the symbol writer and pass it the
26357 command line arguments.
26359 * driver.cs (--debug-args): New command line argument to pass command
26360 line arguments to the symbol writer.
26362 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26364 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26365 the target type for indexers and properties. Thanks to Joe for
26368 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26370 * typemanager.cs (MethodFlags): returns the method flags
26371 (Obsolete/ShouldIgnore) that control warning emission and whether
26372 the invocation should be made, or ignored.
26374 * expression.cs (Invocation.Emit): Remove previous hack, we should
26375 not do this on matching a base type, we should do this based on an attribute
26377 Only emit calls to System.Diagnostics.Debug and
26378 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26379 on the command line.
26381 * rootcontext.cs: Global settings for tracing and debugging.
26383 * cs-tokenizer.cs (define): New utility function to track
26384 defines. Set the global settings for TRACE and DEBUG if found.
26386 2002-05-25 Ravi Pratap <ravi@ximian.com>
26388 * interface.cs (Populate*): Pass in the TypeContainer as well as
26389 the DeclSpace as parameters so that we can create EmitContexts and
26390 then use that to apply attributes etc.
26392 (PopulateMethod, PopulateEvent, PopulateProperty)
26393 (PopulateIndexer): Apply attributes everywhere.
26395 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26398 (ApplyAttributes): Update accordingly.
26400 We now apply interface attributes for all members too.
26402 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26404 * class.cs (Indexer.Define); Correctly check if we are explicit
26405 implementation (instead of checking the Name for a ".", we
26406 directly look up if the InterfaceType was specified).
26408 Delay the creation of the PropertyBuilder.
26410 Only create the PropertyBuilder if we are not an explicit
26411 interface implementation. This means that explicit interface
26412 implementation members do not participate in regular function
26413 lookups, and hence fixes another major ambiguity problem in
26414 overload resolution (that was the visible effect).
26416 (DefineMethod): Return whether we are doing an interface
26419 * typemanager.cs: Temporary hack until we get attributes in
26420 interfaces (Ravi is working on that) and we get IndexerName
26421 support in interfaces.
26423 * interface.cs: Register the indexers as properties.
26425 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26426 warning, I have verified that this is a bug in the .NET runtime
26427 (JavaScript suffers of the same problem).
26429 * typemanager.cs (MemberLookup): When looking up members for
26430 interfaces, the parent of an interface is the implicit
26431 System.Object (so we succeed in searches of Object methods in an
26432 interface method invocation. Example: IEnumerable x; x.ToString
26435 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26437 * class.cs (Event): Events should also register if they do
26438 implement the methods that an interface requires.
26440 * typemanager.cs (MemberLookup); use the new GetInterfaces
26443 (GetInterfaces): The code used to lookup interfaces for a type is
26444 used in more than one place, factor it here.
26446 * driver.cs: Track the errors at the bottom of the file, we kept
26449 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26450 instance if the method we are calling is static!
26452 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26454 * attribute.cs (ApplyAttributes): Make this function filter out
26455 the IndexerName attribute (as that attribute in reality is never
26456 applied) and return the string constant for the IndexerName
26459 * class.cs (TypeContainer.Emit): Validate that all the indexers
26460 have the same IndexerName attribute, and if so, set the
26461 DefaultName attribute on the class.
26463 * typemanager.cs: The return value might contain other stuff (not
26464 only methods). For instance, consider a method with an "Item"
26465 property and an Item method.
26467 * class.cs: If there is a problem with the parameter types,
26470 2002-05-24 Ravi Pratap <ravi@ximian.com>
26472 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26473 looks at user defined conversion after making a call to
26474 StandardConversionExists - we need this for overload resolution.
26476 * expression.cs : Update accordingly the various method calls.
26478 This fixes 2 bugs filed against implicit user defined conversions
26480 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26482 * statement.cs: Track the result of the assignment.
26484 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26486 * expression.cs (MemberAccess): Improved error reporting for
26487 inaccessible members.
26489 2002-05-22 Martin Baulig <martin@gnome.org>
26491 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26492 itself with debugging support.
26494 2002-05-22 Martin Baulig <martin@gnome.org>
26496 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26497 Removed, this isn't needed anymore.
26499 2002-05-20 Martin Baulig <martin@gnome.org>
26501 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26502 be underlying type for an enum.
26504 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26506 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26507 that splits out the loading of just the core types.
26509 * rootcontext.cs (ResolveCore): Split the struct resolution in
26510 two, so we can load the enumeration underlying types before any
26513 * expression.cs (Is): Bandaid until we fix properly Switch (see
26514 bug #24985 for details).
26516 * typemanager.cs (ImplementsInterface): The hashtable will contain
26517 a null if there are no interfaces implemented.
26519 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26521 * cs-parser.jay (indexer_declarator): It is fine to have array
26524 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26526 * typemanager.cs: (RegisterBuilder): New function used to register
26527 TypeBuilders that implement interfaces. Since
26528 TypeBuilder.GetInterfaces (as usual) does not work with lame
26530 (AddUserType): register interfaces.
26532 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26533 dealing with TypeBuilder. Also, arrays are showing up as
26534 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26535 methods can not be invoked on them!
26537 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26538 (ImplicitReferenceConversionExists): Split out from
26539 StandardConversionExists.
26541 * expression.cs (As): We were only implementing one of the three
26542 cases for the as operator. We now implement them all.
26543 (Is): Implement the various other cases for Is as well.
26545 * typemanager.cs (CACHE): New define used to control if we want or
26546 not the FindMembers cache. Seems to have a negative impact on
26547 performance currently
26549 (MemberLookup): Nested types have full acess to
26550 enclosing type members
26552 Remove code that coped with instance/static returns for events, we
26553 now catch this in RealFindMembers.
26555 (RealFindMembers): only perform static lookup if the instance
26556 lookup did not return a type or an event.
26558 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26560 * assign.cs (CompoundAssign): We pass more semantic information
26561 now to Compound Assignments than we did before: now we have all
26562 the information at hand, and now we resolve the target *before* we
26563 do the expression expansion, which allows the "CacheValue" method
26564 to have the effect we intended (before, a [x] += 1 would generate
26565 two differen ArrayAccess expressions from the ElementAccess,
26566 during the resolution process).
26568 (CompoundAssign.DoResolve): Resolve target and original_source here.
26570 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26572 * expression.cs (ArrayAccess): dropped debugging information.
26574 * typemanager.cs: Small bug fix: I was always returning i_members,
26575 instead of one of i_members or s_members (depending on which had
26578 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26579 method is invoked before any code generation takes place, and it
26580 is a mechanism to inform that the expression will be invoked more
26581 than once, and that the method should use temporary values to
26582 avoid having side effects
26584 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26586 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26589 * expression.cs (Indirection, ArrayAccess): Add support for
26590 CacheTemporaries in these two bad boys.
26592 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26593 ldobj or ldind_ref.
26594 (StoreFromPtr): Handle stobj as well.
26596 * expression.cs (UnaryMutator): Share more code.
26598 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26599 down: I was not tracking the Filter function as well, which
26600 was affecting the results of the cache.
26602 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26604 * attribute.cs: Remove the hack to handle the CharSet property on
26607 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26609 * attribute.cs (DoResolve): More uglyness, we now only try to
26610 resolve the attribute partially, to extract the CharSet
26611 information (only if we are a StructLayout attribute). Otherwise
26613 (GetExtraTypeInfo): Add some code to conditionally kill in the
26614 future this. I am more and more convinced that the .NET
26615 framework has special code to handle the attribute setting on
26618 * expression.cs (IsParamsMethodApplicable): Revert my previous
26619 foreach change here, it was wrong.
26621 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26623 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26624 (pp_expr): do not abort on unknown input, just return.
26625 (eval): abort if there are pending chars.
26627 * attribute.cs (Attribute.Resolve): Positional parameters are
26628 optional. Deal with that case.
26630 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26631 the Ansi/Unicode/Auto information for the type.
26633 (TypeContainer.DefineType): instantiate the EmitContext here, as
26634 we will be using it during the type definition (to resolve
26635 attributes) and during the emit phase.
26637 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26638 to pull type information out of the attributes
26640 (Attribute.Resolve): track the constructor builder, and allow for
26641 multiple invocations (structs and classes will use this).
26643 * ecore.cs (MemberLookupFinal): new version with all the
26644 parameters customizable.
26646 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26647 constructors. Return if the result value is null (as the error
26648 would have been flagged already by MemberLookupFinal)
26650 Do not allow instances of abstract classes or interfaces to be
26653 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26654 We have to compare the assembly property here when dealing with
26655 FamANDAssem and Assembly access modifiers, because we might be
26656 creating an assembly from *modules* (that means that we are not
26657 getting TypeBuilders for types defined in other modules that are
26658 part of this assembly).
26660 (Method.Emit): If the method is marked abstract and has a body,
26663 (TypeContainer.DefineMembers): If both the defined member and the
26664 parent name match are methods, then do not emit any warnings: let
26665 the Method.Define routine take care of flagging warnings. But if
26666 there is a mismatch (method overrides something else, or method is
26667 overriwritten by something, then emit warning).
26669 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26670 set to null, this means `do not check for the return type on the
26673 (Method.Define): set the return type for the method signature to
26674 null, so that we get methods with the same name and parameters and
26675 different return types. This is used to flag warning 114 (you are
26676 hiding a method, and you probably want to use the new/override
26679 * typemanager.cs (MemberLookup): Implemented proper access
26680 control, closing a long standing set of bug reports. The problem
26681 was that the Framework only has two bits: Public and NonPublic,
26682 and NonPublic includes private and protected methods, but we need
26683 to enforce the FamANDAssem, FamOrAssem and Family.
26685 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26687 * statement.cs (GotoCase): Return true: Ammounts to giving up
26688 knowledge on whether we return or not, and letting the other case
26689 be responsible for it.
26691 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26693 * driver.cs: Do not load directories for each file processed, only
26694 do it if there is a pattern.
26696 * ecore.cs: Report readonly assigns here as well, as we might have
26697 been resolved only by MemberAccess.
26699 (SimpleName.SimpleNameResolve): Also be useful for LValue
26700 resolution. We need this to propagate assign to local readonly variables
26702 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26703 do not want to reuse potential criteria memory.
26705 * class.cs (MyEventBuilder): Set reflected_type;
26707 * ecore.cs (Constantify): Added support for constifying bools.
26709 (RootContext.LookupType): Added a cache for values looked up in
26710 the declaration space.
26712 * typemanager.cs (FindMembers): Now is a front-end to
26713 RealFindMembers, and provides a two-level hashtable-based cache to
26716 15% performance improvement: from 22.5 to 19.2 seconds.
26718 * expression.cs (IsParamsMethodApplicable): use foreach.
26719 (Invocation.DoResolve): ditto.
26720 (New.DoResolve): ditto.
26721 (ArrayCreation.DoResolve): ditto.
26723 * ecore.cs (FindMostEncompassingType): use foreach.
26725 * delegate.cs (NewDelegate.DoResolve): Use foreach
26727 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26728 (RemoveMethods): use foreach.
26730 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26731 nested foreach statements instead of for, and also break out of
26732 the inner loop once a match is found.
26734 (Invocation.OverloadResolve): Use foreach, simplify the code.
26736 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26738 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26739 we actually unwrap the expression to allow for extra information
26742 * expression.cs: Use Shr_Un on unsigned operations.
26744 2002-05-08 Ravi Pratap <ravi@ximian.com>
26746 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26747 applicable operators was not being considered correctly. This closes
26748 the bug Miguel reported.
26750 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26752 * attribute.cs: check that the type derives from System.Attribute
26753 and report the correct error in that case (moved the duplicate code to
26754 its own method, too).
26756 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26758 * attribute.cs: lookup attribute type name as the spec says: first the
26759 bare attribute name and then name + "Attribute" (nant compiles with
26760 mcs after this fix).
26762 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26764 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26765 Because of the way we parse things, we should try to see if a
26766 UIntConstant can fit in an integer.
26768 2002-05-07 Ravi Pratap <ravi@ximian.com>
26770 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26771 when we are in an explicit context.
26773 (ConvertReferenceExplicit): When converting from Iface type S to Class
26774 T make sure the rules are implemented as an OR.
26776 * parameter.cs (ParameterType): Make it a property for now although the
26777 purpose really isn't anything immediate.
26779 * expression.cs (Is*Applicable): Do better checking on the parameter type
26780 of a ref/out parameter. The ones from the system assemblies are already
26781 marked with the correct type so we don't need to do any correction.
26783 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26784 the object type is standard too so include that.
26786 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26788 * ecore.cs (StandardConversionExists): Augment with missing code:
26789 deal with IntConstant, LongConstants and Enumerations.
26791 * assign.cs: Report the error, instead of failing silently
26793 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26794 typecontainer that they are declared, because the
26795 typecontainer/namespace will have the list of using clauses that
26796 need to be applied.
26798 Assembly Attributes were escaping the normal registration
26801 (EmitCode): Apply attributes within an EmitContext that represents
26802 the container they were declared on.
26804 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26806 2002-05-06 Ravi Pratap <ravi@ximian.com>
26808 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26809 Revamp completely - make much cleaner as we now operate only
26812 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26813 to implement the logic detailed in the spec more correctly.
26815 (UserDefinedConversion): Update accordingly.
26817 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26819 * statement.cs: Return flow analysis information up.
26821 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26824 (token): Do not consume an extra character before calling
26827 2002-05-06 Piers Haken <piersh@friskit.com>
26829 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26831 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26833 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26834 EmitContext during the instance constructor initializer
26835 resolution, to stop access to instance variables.
26837 This is mandated by the spec, last paragraph of the `constructor
26838 initializers' section.
26840 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26842 * cs-parser.jay, class.cs (Accessor): new class used to represent
26843 an accessor (get or set). In the past we used `null' to represent
26844 a missing accessor. But this is ambiguous because there was no
26845 way to tell in abstract indexers/properties if one of them was
26848 Now there is a way of addressing that.
26850 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26851 instead of FindMembers.
26853 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26854 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26856 * attribute.cs: Treat indexers and properties as the same in terms
26857 of applying attributes
26859 * ecore.cs (FindMostEncompassedType): Use statically initialized
26860 EmptyExpressions()s like we do elsewhere to avoid creating useless
26861 objects (and we take this out of the tight loop).
26863 (GetConversionOperators): Move the code to extract the actual
26864 operators to a separate routine to clean things up.
26866 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26868 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26869 events are always registered FieldBuilders.
26871 * class.cs (FieldBase): New class shared by Fields
26873 * delegate.cs: If we are a toplevel delegate, use our full name.
26874 If we are a nested delegate, then only use our tail name.
26876 2002-05-02 Ravi Pratap <ravi@ximian.com>
26878 * expression.cs (IsApplicable): Ensure that we add the "&" to
26879 ref/out types before comparing it with the type of the argument.
26881 (IsParamsMethodApplicable): Ditto.
26883 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26886 * delegate.cs : Handle the case when we have more than one applicable
26887 method. Flag an error only when we finish checking all.
26889 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26891 * expression.cs: Add support for boolean static initializers.
26893 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26895 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26897 * parameter.cs (ComputeParameterTypes,
26898 ComputeAndDefineParameterTypes): Better error handling: now we
26899 clear the `types' cache if we fail during any of the type lookups.
26900 We also return the status code correctly to our caller
26902 * delegate.cs: If we fail to define a delegate, abort the extra
26905 * expression.cs (Binary.ResolveOperator): for
26906 operator==(object,object) and operator !=(object, object) we also
26907 have to verify that there is an implicit conversion from one to
26910 (ArrayAccess.DoResolve): Array Access can operate on
26913 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26915 * assign.cs (CompoundAssign): A new class used as a "flag" that
26916 the assignment actually is happening as part of a compound
26917 assignment operator.
26919 During compound assignment, a few new rules exist to enable things
26926 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26927 to the type of x) if y is implicitly convertible to the type of x,
26928 and the operator is a builtin operator and the return type of the
26929 operator is explicitly convertible to the type of x.
26931 * rootcontext.cs: Reset warning level to 2. 4 catches various
26932 "interesting" features in mcs, we must clean this up at some
26933 point, but currently am trying to kill other bugs ;-)
26935 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26936 in container classes as well.
26938 * expression.cs (Binary.ResolveOperator): Handle string case
26939 before anything else (as operator overloading does emit an error
26940 before doing anything else).
26942 This code could go away when we move to a table driven model, but
26943 i could not come up with a good plan last night.
26945 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26947 * typemanager.cs (CSharpName): reimplementation using regex.
26948 * class.cs: added null check for fields in Emit
26949 * rootcontext.cs: set warninglevel to 4
26951 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26953 * typemanager.cs (CSharpName): reimplemented with Lupus
26956 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26958 * statement.cs (If): correclty implement Resolve, because we were
26959 not catching sem errors in there. The same process is needed
26961 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26964 (Statement.Warning_DeadCodeFound): Factorize code.
26965 (While): Report dead code here too.
26967 (Statement): Added Resolve virtual method to allow
26968 for resolution split from the emit code.
26970 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26972 * statement.cs (EmitBoolExpression): No longer try to resolve the
26974 (MakeBoolean): New utility function that resolve, implicitly
26975 converts to boolean and tags the expression.
26978 (If, Do): Implement dead code elimination.
26979 (While): Implement loop inversion
26981 (Do, While, For, If): Resolve the expression prior to calling our
26984 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26987 - added method Report28 (warning: program has more than one entry point)
26988 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26989 - modified method Method.Define, the part at the end of the method
26991 * rootcontext.cs: added static public Location EntryPointLocation;
26993 * ../errors/cs0028.cs : Add test case for the above warning.
26996 - modified method CSharpName to allow arrays of primitive type to
26997 be printed nicely (e.g. instead of System.Int32[][] it now prints
26999 - added method CSharpSignature: returns the signature of a method
27000 in string format to be used in reporting errors, warnings, etc.
27002 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27005 2002-04-26 Ravi Pratap <ravi@ximian.com>
27007 * delegate.cs (Define): Fix extremely silly bug where I was
27008 setting the type of the 'object' parameter of the BeginInvoke
27009 method to System.IAsyncResult instead of System.Object ;-)
27011 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27013 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27016 (Constructor.Emit): return if we fail to initialize the
27017 constructor. Another door closed!
27019 * expression.cs (New.DoResolve): Improve error message (from -6 to
27020 1501). Use DeclaredOnly lookup to find the exact constructor.
27022 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27023 loop. This is useful.
27025 * cs-parser.jay: Adjust the default parameters so that destructors
27026 have the proper signature.
27028 2002-04-26 Martin Baulig <martin@gnome.org>
27030 * driver.cs (LoadAssembly): If `assembly' contains any characters
27031 which are only valid in path names and not in assembly names
27032 (currently slash, backslash and point), use Assembly.LoadFrom ()
27033 instead of Assembly.Load () on the `assembly' (before iteration
27034 over the link_paths).
27036 2002-04-26 Martin Baulig <martin@gnome.org>
27038 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27040 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27042 * class.cs (Property): use the new typemanager.MemberLookup
27044 (TypeContainer.MemberLookup): Implement using the
27045 TypeManager.MemberLookup now.
27047 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27048 and return MemberInfos, so that these can be used without an
27049 EmitContext (what we had before).
27051 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27053 * expression.cs: Fix the case where the argument to params if the
27054 type of the params. I omitted handling this before. Fixed
27056 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27058 * driver.cs: Call BootCorlib_PopulateCoreType
27060 * class.cs (Property.CheckBase): Check for properties only, not
27063 * interface.cs: Temporary hack: try/catch around the
27064 CustomAttributeBuilder, because I am getting an exception that I
27067 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27068 types whose definitions are required to be there (attributes are
27069 defined before standard types).
27071 Compute definitions as we boot the various types, as they are used
27072 immediately (value_type class will need object_type, but if we do
27073 not initialize object_type, we will pass a null, which will let
27074 the runtime pick the System.Object from the existing corlib, which
27075 is not what we want).
27077 2002-04-22 Patrik Torstensson <totte@labs2.com>
27079 * cs-tokenizer.cs: fixed a number of trim() issues.
27081 2002-04-22 Ravi Pratap <ravi@ximian.com>
27083 * expression.cs (Argument.Type): Ensure that we return the correct
27084 type when we have out or ref parameters [in which case we
27087 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27089 * class.cs (Property, Indexer): Allow extern modifier in there.
27091 * typemanager.cs (InitBaseTypes): Initializes object_type and
27092 value_type, since those will be used early on during the bootstrap
27093 process to compile corlib.
27095 (InitCoreTypes): Move code from here to InitBaseTypes.
27097 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27099 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27100 single-dimension arrays as using the ldlen opcode.
27102 Daniel Lewis discovered this optimization.
27104 * typemanager.cs: Add signature for System.Array::get_Length
27106 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27108 * statement.cs: report the error when the foreach does not apply to an
27109 array nor a collection.
27111 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27113 * expression.cs: Add implicit conversions to the operator ~.
27115 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27117 * typemanager.cs: Locate the decimal constructor.
27119 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27121 * attribute.cs: use the new property of TypeOf.
27122 * expression.cs: added 'get' property around typearg.
27124 These changes fix a build breaker reported by NickD. Is this the
27125 correct way to fix? If not, please, revert my changes and make it
27128 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27130 * attribute.cs: Add support for typeof in attribute invocations.
27131 I am not sure that this is right though.
27133 2002-04-14 Duncan Mak <duncan@ximian.com>
27135 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27136 Binary.Operator.Division case.
27138 2002-04-13 Ravi Pratap <ravi@ximian.com>
27140 * class.cs (DefineType): Ensure that we do a proper check on
27141 attribute types and also register it with the TypeManager.
27143 (TypeContainer.Targets): The default for attribute types is
27144 AttributeTargets.All.
27146 * attribute.cs (ApplyAttributes): Registering the attribute type
27147 is done elsewhere, not when we discover we have a Usage attribute.
27149 2002-04-12 Ravi Pratap <ravi@ximian.com>
27151 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27152 and get rid of is_delegate parameter.
27154 * everywhere : update.
27156 2002-04-12 Ravi Pratap <ravi@ximian.com>
27158 * cs-parser.jay (compilation_unit): Revamp completely to use
27159 some new ideas that I got from Rhys' grammar to solve the problems
27160 with assembly level attributes.
27162 (outer_declaration): New grammar production.
27164 (attribute_sections): Add.
27166 (opt_attributes): Base on attribute_sections
27168 (namespace_declaration): Allow opt_attributes to tackle the case
27169 when we have assembly level attributes - we are clever in this
27172 * attribute.cs (ApplyAttributes): Do not worry about assembly
27173 attributes in the non-global context.
27175 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27176 instead of SetGlobalAttributes.
27178 * class.cs, rootcontext.cs : Ensure we define and generate
27179 attribute types before anything else.
27181 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27182 and flag the new error -20 for the case when the attribute type
27183 does not have valid targets specified. csc does not catch this.
27185 * ../errors/errors.txt : update for error # -20
27187 2002-04-11 Ravi Pratap <ravi@ximian.com>
27189 * support.cs (InternalParameters.ParameterModifier): Do some null
27190 checking and return sane values.
27192 * class.cs (Method.Define): If we are a PInvoke method, ensure
27193 that we are static and extern. Report error # 601
27195 * ../errors/cs0601.cs : Add test case for the above error.
27197 2002-04-07 Ravi Pratap <ravi@ximian.com>
27199 * rootcontext.cs (attribute_types): We need to keep type of
27200 all attribute types separately and emit code for them first.
27202 (RegisterAttribute) : Implement.
27204 * class.cs (DefineType): Check if the current Type is a custom
27205 attribute type and register it accordingly.
27207 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27208 adding the first attribute twice and rename to
27210 (SetGlobalAttributes): this.
27212 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27215 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27216 if we are processing global arguments. Hmm, I am unsure of this.
27218 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27220 * expression.cs: added static array of strings to avoid calling
27221 Enum.ToString () for Operator in Binary. Significant recover of
27224 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27226 * class.cs (FindMembers): Allow the Builders of the various
27227 members to be null. If they are skip them. This only happens
27228 during the PInvoke declaration.
27230 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27232 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27233 failure, so we do not keep going afterwards.
27235 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27236 wanted to pass `false' as the `is_delegate' argument. If this is
27237 the case, why not use delegate_type == null to mean `is_delegate =
27238 false' and anything else as is_delegate = true.
27240 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27242 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27243 code for the section, not the beginning of the tests.
27245 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27247 * cfold.cs: Handle operator + (Enum x, Underlying x)
27249 * expression.cs (Binary): same. Warn about errors where we have
27250 Enum/Enum in operator + as well.
27252 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27255 - added support for switch(bool)
27256 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27257 - add TableSwitchEmit() to handle table-based switch statements
27259 2002-04-05 Ravi Pratap <ravi@ximian.com>
27261 * expression.cs (Invocation.OverloadResolve): Factor out code which
27262 does parameter compatibility checking with arguments so that we can
27263 re-use the code even from Delegate.VerifyApplicability
27265 (VerifyArgumentsCompat): Move above code here.
27267 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27268 and instead make a call to the above method.
27270 2002-03-31 Ravi Pratap <ravi@ximian.com>
27272 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27273 We use it to keep track of classes which are attribute types.
27275 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27277 * delegate.cs (Delegate.Define): Correctly define the types in the
27278 presence of fixed and array parameters.
27280 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27283 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27284 include NonPublic after the first iteration.
27286 * class.cs (Indexer.CheckBase): Only check if both parents are
27289 * cs-parser.jay (accessor_body): If empty, set to null.
27291 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27292 same code path here to resolve constants names that we did have in
27293 MemberAccess.DoResolve. There is too much code duplicated here.
27295 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27297 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27299 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27302 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27303 tokens, numbers and strings.
27305 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27308 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27309 asyncronous parameters and the regular parameters.
27311 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27312 specify the target directory.
27314 * expression.cs: (This.DoResolve): Simplify
27315 (As.Emit): Optimize, do not generate IsInst if the expression is
27316 always of the given type.
27318 (Is.DoResolve): Bug fix, we were reporting both always/never for
27321 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27322 creating too many unnecessary arrays.
27324 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27326 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27327 fields instead of rolling our own initializer. Takes care of all
27328 implicit conversions, and drops unnecessary static checks/argument.
27330 2002-03-31 Dick Porter <dick@ximian.com>
27332 * driver.cs: use the GetDirectories() return values properly, and
27333 use "/" as path separator.
27335 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27337 * expression.cs (Unary): Optimize - - expr into expr.
27338 (Binary): Optimize a + (-b) into a -b.
27340 * codegen.cs (CodeGen): Made all methods static.
27342 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27346 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27347 TypeBuilder property.
27349 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27352 * tree.cs: Removed the various RecordXXXX, and replaced with a
27353 single RecordDecl. Removed all the accessor methods, and just
27354 left a single access point Type
27356 * enum.cs: Rename DefineEnum to DefineType.
27358 * decl.cs: New abstract method `DefineType' used to unify the
27359 Defines for Enumerations, Interfaces, TypeContainers and
27362 (FindType): Moved LookupInterfaceOrClass here. Moved the
27363 LookupBaseClasses method that used to live in class.cs and
27364 interface.cs here, and renamed to FindType.
27366 * delegate.cs: Implement DefineType. Take advantage of the
27367 refactored pattern for locating the parent builder without taking
27368 the parent_builder argument (which we know does not work if we are
27369 nested, and triggering a toplevel definition).
27371 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27373 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27374 accessibility of a member has changed during override and report
27377 * class.cs (Method.Define, Property.Define): Only complain on
27378 overrides if the method is private, any other accessibility is
27379 fine (and since we just checked the permission is the same, we are
27382 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27383 and elif are processed always. The other pre-processing
27384 directives are only processed if we are "taking" the path
27386 2002-03-29 Martin Baulig <martin@gnome.org>
27388 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27389 current location is not Null.
27391 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27392 a separate method so we can profile it.
27394 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27395 `span.Seconds' are just seconds, but no minutes or hours.
27396 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27398 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27400 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27401 Remove the gratuitous set of Final:
27403 // If an interface implementation, then we can set Final.
27404 if (((flags & MethodAttributes.Abstract) == 0) &&
27405 implementing.DeclaringType.IsInterface)
27406 flags |= MethodAttributes.Final;
27408 I do not know what I was smoking when I used that.
27411 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27412 step into fixing the name resolution issues for delegates and
27413 unifying the toplevel name resolution.
27415 2002-03-28 Martin Baulig <martin@gnome.org>
27417 * class.cs (Method.Emit): If we have a symbol writer, call its
27418 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27419 tell it about the current method.
27421 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27422 writer that we're going to emit the first byte of IL code for a new
27423 statement (a new source line).
27424 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27425 EmitContext.Mark() before emitting any code.
27427 * location.cs (SymbolDocument): Return null when we're Null.
27429 * statement.cs (Statement): Moved the `Location loc' variable here.
27430 (Statement.EmitBoolExpression): If we have a symbol writer, call
27431 ec.Mark() before emitting any code to tell it that we're at the
27432 beginning of a new statement.
27433 (StatementExpression): Added `Location' argument to the constructor.
27434 (Block): Added public readonly variable `StartLocation' and public
27435 variable `EndLocation'. The latter is to be set using SetEndLocation().
27436 (Block): Added constructor which takes a start and end location.
27437 (Block.SetEndLocation): New method. This sets the end location.
27438 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27439 local variables we create.
27440 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27441 each statement and do also mark the begin and end of the block.
27443 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27444 tell it the current lexer.Location, use Location.Null for the end of the
27446 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27447 current block, set its end location using SetEndLocation().
27448 (statement_expression): StatementExpression constructor now takes the
27449 lexer.Location as additional argument.
27450 (for_statement, declare_local_variables): Likewise.
27451 (declare_local_variables): When creating a new implicit block, use the
27452 new Block constructor and pass it the lexer.Location.
27454 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27456 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27457 members also on the parent interfaces recursively.
27459 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27461 * report.cs: Use new formats, since Gonzalo finished the missing
27464 * expression.cs (Binary.ResolveOperator): added missing operator|
27465 operator& and operator^ for bool/bool.
27467 * cs-parser.jay: CheckDef now takes a Location argument that is
27468 used to report errors more precisly (instead of reporting the end
27469 of a definition, we try to track something which is a lot closer
27470 to the source of the problem).
27472 * cs-tokenizer.cs: Track global token use, so we can properly flag
27473 the use of #define/#undef after the first token has been seen.
27475 Also, rename the reportXXXX to Error_DescriptiveName
27477 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27478 TypeContainer, so that Enum and Interface can use this too.
27480 * class.cs (TypeContainer.LookupInterfaceOrClass,
27481 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27482 `builder' argument. Typically this was used to pass the parent
27483 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27486 The problem is that a nested class could trigger the definition of
27487 a toplevel class, and the builder would be obviously wrong in that
27490 So we drop this argument, and we compute dynamically the
27491 TypeBuilder/ModuleBuilder (the correct information was available
27492 to us anyways from DeclSpace.Parent)
27494 * interface.cs (Interface.DefineInterface): Drop builder
27495 parameter cleanup like class.cs
27497 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27500 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27503 (Try.Emit): Propagate the returns value from the statement.
27505 (Return.Emit): Even if we are leavning
27507 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27509 * modifiers.cs: Fix the computation of MethodAttributes flags.
27511 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27513 * driver.cs: allow compilation of files that start with '/'.
27514 Add a default case when checking the argument of --target.
27516 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27518 * interface.cs: Implement the same search algorithm for types in
27519 the interface code.
27521 * delegate.cs: Do not allow multiple definition.
27523 * Recovered ChangeLog that got accidentally amputated
27525 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27527 * rootcontext.cs: Load manually enum to allow core classes to
27528 contain enumerations.
27530 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27531 Update to new static methods in TypeManager.
27533 * typemanager.cs (GetMethod, GetConstructor): Use our
27534 implementation of FindMembers to find the members, since during
27535 corlib compilation, the types are TypeBuilders and GetMethod and
27536 GetConstructor do not work.
27538 Make all methods in TypeManager static.
27540 (InitCodeHelpers): Split the functionality from
27541 the InitCodeTypes function.
27543 * driver.cs: Call InitCodeHelpers after we have populated the
27546 * cs-parser.jay (delegate_declaration): we did not used to compute
27547 the delegate name correctly for void delegates.
27549 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27551 * rootcontext.cs (RootContext): Init the interface_resolve_order
27552 and type_container_resolve_order always.
27554 (ResolveCore, BootstrapCorlib_ResolveClass,
27555 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27556 compiler when compiling with --nostdlib
27558 * class.cs (TypeContainer.DefineType): Check that our parent is
27559 not null. This test is most important when we are bootstraping
27562 * codegen.cs: Split out the symbol writing code.
27564 2002-03-25 Martin Baulig <martin@gnome.org>
27566 * driver.cs (-g): Made -g an alias for --debug.
27568 2002-03-24 Martin Baulig <martin@gnome.org>
27570 * codegen.cs (SymbolWriter): New public variable. Returns the
27571 current symbol writer.
27572 (CodeGen): Added `bool want_debugging_support' argument to the
27573 constructor. If true, tell the ModuleBuild that we want debugging
27574 support and ask it for the ISymbolWriter.
27575 (Save): If we have a symbol writer, call it's Close() method after
27576 saving the assembly.
27578 * driver.c (--debug): New command line argument to create a
27579 debugger information file.
27581 * location.cs (SymbolDocument): New public property. Returns an
27582 ISymbolDocumentWriter object for the current source file or null
27583 if we don't have a symbol writer.
27585 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27587 * driver.cs (LoadAssembly): Correctly return when all the paths
27588 have been tried and not before.
27590 * statement.cs (Switch.Emit): return the actual coverage for this
27591 statement (returns/not-returns)
27593 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27594 switch of the statement if we are the last switch section. That
27595 kills two problems: try/catch problems (we used to emit an empty
27596 nop at the end) and switch statements where all branches would
27599 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27601 * driver.cs: Add default assemblies (the equivalent to the
27602 Microsoft CSC.RSP file)
27604 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27605 also update tokens_seen and set it to false.
27607 * driver.cs: Implement --recurse for Mike.
27609 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27610 correctly splitting out the paths.
27612 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27614 * interface.cs (Interface.PopulateProperty): Instead of using
27615 `parent' as the declaration space for the set parameters, use
27618 * support.cs (InternalParameters): InternalParameters constructor
27619 takes a DeclSpace instead of a TypeContainer.
27621 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27622 types are being initialized, load the address of it before calling
27625 (New): Provide a mechanism to disable the generation of local
27626 value type temporaries when the caller will be providing us with
27627 an address to store it.
27629 (ArrayCreation.EmitDynamicInitializers): Use it.
27631 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27633 * expression.cs (Invocation.EmitArguments): Only probe for array
27634 property if there is more than one argument. Sorry about that.
27636 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27637 empty param arrays.
27639 * class.cs (Method.LabelParameters): Fix incorrect code path that
27640 prevented the `ParamArrayAttribute' from being applied to the
27643 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27645 * support.cs (ReflectionParameters): Correctly compute whether the
27646 last argument is a params array. Fixes the problem with
27649 * typemanager.cs: Make the assemblies array always be non-null
27650 (empty, but non-null)
27652 * tree.cs (RecordDecl): New function that abstracts the recording
27653 of names. This reports error 101, and provides a pointer to the
27654 previous declaration. Fixes a crash in the compiler.
27656 * cs-parser.jay (constructor_declaration): Update to new grammar,
27657 and provide a constructor_body that can be empty.
27659 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27661 * driver.cs: Add support for --resources.
27663 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27664 Make all types for the various array helper methods be integer.
27666 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27667 CheckState to ConvCast.
27669 (ConvCast): Now it takes a `checked' state argument, to avoid
27670 depending on the emit context for the conversion, and just using
27671 the resolve time setting.
27673 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27674 instead of Invocation.EmitArguments. We do not emit the original
27675 arguments, instead we emit those which have been converted to
27676 unsigned int expressions.
27678 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27680 * codegen.cs: ditto.
27682 * expression.cs (LocalVariableReference): Drop the use of the
27683 Store function that depended on the variable index.
27685 * statement.cs (VariableInfo): Drop the `Idx' property from this
27686 class, as this is not taking into account the indexes for
27687 temporaries tat we generate during the execution, getting the
27690 * class.cs: First emit class initializers, then call the parent
27693 * expression.cs (Binary): Fix opcode emision.
27694 (UnaryMutator.EmitCode): Support checked code generation
27696 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27697 matches for events for both the Static and Instance scans,
27698 pointing to the same element. Fix that.
27700 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27702 * rootcontext.cs (ResolveTree): Always set the
27703 interface_resolve_order, because nested interfaces will be calling
27706 * class.cs (GetInterfaceOrClass): Track the same resolution
27707 process used by TypeManager.LookupType. This fixes the nested
27708 type lookups in class declarations (separate path from
27711 (TypeContainer.DefineType): Also define nested interfaces.
27712 (TypeContainer.RegisterOrder): New public function used to
27713 register the order in which child interfaces need to be closed.
27715 Nested interfaces need to be closed after their parents have been
27718 * interface.cs (InterfaceAttr): Put all the logic for computing
27719 the interface attribute here.
27721 (DefineInterface): Register our interface order with the
27722 RootContext or with the TypeContainer depending on the case.
27724 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27726 * cs-parser.jay: rework foreach statement to work with the new
27727 changes to the policy on SimpleNames.
27729 * report.cs: support Stacktrace on warnings as well.
27731 * makefile: drop --unsafe and /unsafe from the compile.
27733 2002-03-13 Ravi Pratap <ravi@ximian.com>
27735 * ecore.cs (StandardConversionExists): Modify to take an Expression
27736 as the first parameter. Ensure we do null -> reference type conversion
27739 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27740 temporary Expression objects.
27742 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27744 * interface.cs: workaround bug in method overloading resolution
27745 (there is already a bugzilla bug for it).
27747 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27749 We could also solve this problem by having a separate path for
27750 performing type lookups, instead of DoResolve, we could have a
27751 ResolveType entry point, and only participating pieces of the
27752 production (simplename, deref, array) would implement this.
27754 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27755 signal SimpleName to only resolve type names and not attempt to
27756 resolve anything else.
27758 * expression.cs (Cast): Set the flag.
27760 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27762 * class.cs: Only report 108 if there is no `new' modifier.
27764 * cs-parser.jay: rework foreach statement to work with the new
27765 changes to the policy on SimpleNames.
27767 * report.cs: support Stacktrace on warnings as well.
27769 * makefile: drop --unsafe and /unsafe from the compile.
27771 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27773 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27774 lookups here, instead of doing that at parse time. This means
27775 that our grammar will not introduce `LocalVariableReferences' as
27776 expressions at this point. That solves the problem of code like
27780 static void Main ()
27784 This is only half the fix. The full fix requires parameters to
27785 also be handled in this way.
27787 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27788 makes the use more obvious of the DeclSpace. The
27789 ec.TypeContainer.TypeBuilder is now only used to pull the
27790 TypeBuilder for it.
27792 My theory is that I can get rid of the TypeBuilder completely from
27793 the EmitContext, and have typecasts where it is used (from
27794 DeclSpace to where it matters).
27796 The only pending problem is that the code that implements Aliases
27797 is on TypeContainer, and probably should go in DeclSpace.
27799 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27800 lookups here, instead of doing that at parse time. This means
27801 that our grammar will not introduce `LocalVariableReferences' as
27802 expressions at this point. That solves the problem of code like
27806 static void Main ()
27810 This is only half the fix. The full fix requires parameters to
27811 also be handled in this way.
27813 * class.cs (Property.DefineMethod): When implementing an interface
27814 method, set newslot, when implementing an abstract method, do not
27815 set the flag (before we tried never setting it, or always setting
27816 it, which is the difference).
27817 (Indexer.DefineMethod): same.
27818 (Method.DefineMethod): same.
27820 * ecore.cs: Only set the status used flag if we get back a Field.
27822 * attribute.cs: Temporary hack, so Paolo can keep working.
27824 2002-03-08 Ravi Pratap <ravi@ximian.com>
27826 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27827 the unmanaged type in the case we have a MarshalAs attribute.
27829 (Resolve): Handle the case when we are parsing the special MarshalAs
27830 attribute [we need to store the unmanaged type to use later]
27832 * typemanager.cs (marshal_as_attr_type): Built in type for the
27833 MarshalAs Attribute.
27835 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27836 on parameters and accordingly set the marshalling info.
27838 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27840 * class.cs: Optimizing slightly by removing redundant code after
27841 we switched to the `NoTypes' return value.
27842 (Property.DefineMethod): use NoTypes here too.
27844 This fixes the bug I introduced in my last batch of changes.
27846 2002-03-05 Ravi Pratap <ravi@ximian.com>
27848 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27850 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27851 Enums since those are types too.
27853 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27855 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27856 thanks to a call during the lookup process.
27858 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27860 * statement.cs (Foreach): Lots of work to accomodate a particular
27861 kind of foreach statement that I had not kept in mind. It is
27862 possible to have foreachs on classes that provide a GetEnumerator
27863 method that return objects that implement the "pattern" for using
27864 a foreach, there is no need to support GetEnumerator
27867 This is needed to compile nant.
27869 * decl.cs: Only report 114 if the member is not `Finalize' and if
27870 the warning level is at least 2.
27872 * class.cs: Moved the compare function from Method to
27875 (MethodSignature.InheritableMemberSignatureCompare): Add new
27876 filter function that is used to extract inheritable methods from a
27879 (Method.Define): Use the new `inheritable_method_signature_filter'
27882 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27885 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27887 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27889 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27891 * expression.cs: Pass location information to
27892 ConvertImplicitStandard.
27894 * class.cs: Added debugging code to track return values from
27897 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27899 * expression.cs (Is.DoResolve): If either side of the `is' is an
27900 interface, do not flag the warning.
27902 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27905 * report.cs: Allow for --fatal to be used with --probe.
27907 * typemanager.cs (NoTypes): Move the definition for the empty Type
27910 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27912 (TypeContainer.DefineProxy): New function used to proxy to parent
27913 implementations when implementing interfaces.
27914 (TypeContainer.ParentImplements): used to lookup if our parent
27915 implements a public function that is required by an interface.
27916 (TypeContainer.VerifyPendingMethods): Hook this up.
27918 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27919 `modules' and `assemblies' arraylists into arrays. We only grow
27920 these are the very early start up of the program, so this improves
27921 the speedof LookupType (nicely measured).
27923 * expression.cs (MakeByteBlob): Replaced unsafe code with
27924 BitConverter, as suggested by Paolo.
27926 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27927 folding of string concatenation, but if either side is a string,
27928 and the other is not, then return null, and let the runtime use
27929 the concatenation on the string plus the object (using
27930 `Object.ToString').
27932 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27934 Constant Folding has been implemented now.
27936 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27937 the error instead on types that are not supported in one's
27940 * constant.cs (Constant and all children): New set of functions to
27941 perform implict and explicit conversions.
27943 * ecore.cs (EnumConstant): Implement the new functions to perform
27944 conversion by proxying to the child expression.
27946 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27947 own separate setting that can not be turned off from the command
27948 line using --unchecked or --checked and is only controlled using
27949 the checked/unchecked statements and expressions. This setting is
27950 used by the constant folder to flag errors.
27952 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27953 ConstantCheckState as well.
27955 During Resolve, they also have to flag the state, because the
27956 constant folder runs completely in the Resolve phase.
27958 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27961 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27963 * cfold.cs: New file, this file contains the constant folder.
27965 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27966 argument to track whether we are using the resulting address to
27967 load or store a value and provide better error messages.
27969 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27970 new AddressOf arguments.
27972 * statement.cs (Foreach.EmitCollectionForeach): Update
27974 * expression.cs (Argument.Emit): Call AddressOf with proper
27975 arguments to track usage.
27977 (New.DoEmit): Call AddressOf with new arguments.
27979 (Unary.Emit): Adjust AddressOf call.
27981 2002-03-01 Ravi Pratap <ravi@ximian.com>
27983 * cs-parser.jay (member_access): Change the case for pre-defined types
27984 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27987 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27990 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27991 essentially like methods and apply attributes like MethodImplOptions to them too.
27993 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27996 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27997 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28000 * Update code everywhere accordingly.
28002 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28004 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28006 2002-02-28 Ravi Pratap <ravi@ximian.com>
28008 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28009 try performing lookups against those instead of jumping straight into using
28010 the 'using' clauses.
28012 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28014 (LookupType): Perform lookups in implicit parents too.
28016 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28017 sequence as RootContext.LookupType.
28019 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28020 the various cases of namespace lookups into this method.
28022 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28024 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28025 in positional arguments)
28027 * class.cs (Operator): Update the AllowedModifiers to contain
28030 * cs-parser.jay: Update operator declaration to allow for the
28031 operator body to be empty.
28033 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28036 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28038 * class.cs (Method.Emit): Label parameters.
28040 * driver.cs: Return 1 or 0 as the program exit code.
28042 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28044 * expression.cs: Special case the `null' object when trying to
28045 auto-compute the type, as anything can be explicitly converted to
28048 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28049 spotting this Paolo.
28051 (Expression.ImplicitNumericConversion): Perform comparissions of
28052 the type using the underlying type in the case of an enumeration
28053 rather than using the enumeration type for the compare.
28055 Cope with the underlying == type case, which is not possible to
28058 (Expression.ConvertNumericExplicit): Perform comparissions of
28059 the type using the underlying type in the case of an enumeration
28060 rather than using the enumeration type for the compare.
28062 * driver.cs: If the user does not supply an extension, assume .exe
28064 * cs-parser.jay (if_statement): Rewrote so that we can track the
28065 location for the if statement.
28067 * expression.cs (Binary.ConstantFold): Only concat strings when
28068 the operation is "+", not everything ;-)
28070 * statement.cs (Statement.EmitBoolExpression): Take a location
28072 (If, While, Do): Track location.
28074 * expression.cs (Binary.ResolveOperator): In the object + string
28075 case, I was missing a call to ConvertImplicit
28077 2002-02-25 Ravi Pratap <ravi@ximian.com>
28079 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28080 Location arguments. Ensure we use RootContext.LookupType to do our work
28081 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28083 * interface.cs (PopulateMethod): Handle the type of the parameter being
28086 * expression.cs (Invocation.BetterFunction): Handle the case when we
28087 have a params method with no fixed arguments and a call is made with no
28090 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28092 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28093 the verbatim-string-literal
28095 * support.cs (InternalParameters.ParameterModifier): handle null
28097 (InternalParameters.ParameterType): ditto.
28099 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28100 duplicating the name of the variable parameter.
28101 (GetParameterByName): Fix bug where we were not looking up array
28102 paramters if they were the only present (thanks Paolo!).
28103 (GetParameterInfo): We only have an empty set of types if both
28104 fixed and array are set to null.
28105 (GetParameterInfo-idx): Handle FixedParameter == null
28107 * cs-parser.jay: Handle the case where there is no catch
28108 statements (missing null test).
28110 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28112 * driver.cs (MainDriver): Be conservative on our command line
28115 Catch DirectoryNotFoundException when calling GetFiles.
28117 (SplitPathAndPattern): Used to split the input specification into
28118 a path and a pattern that we can feed to Directory.GetFiles.
28120 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28122 * statement.cs (Fixed): Implement the last case of the Fixed
28123 statement (string handling).
28125 * expression.cs (StringPtr): New class used to return a char * to
28126 a string; Used by the Fixed statement.
28128 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28130 * expression.cs (Binary.ResolveOperator): Remove redundant
28131 MemberLookup pn parent type.
28132 Optimize union call, we do not need a union if the types are the same.
28133 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28136 Specialize the use of MemberLookup everywhere, instead of using
28137 the default settings.
28139 (StackAlloc): Implement stackalloc keyword.
28141 * cs-parser.jay: Add rule to parse stackalloc.
28143 * driver.cs: Handle /h, /help, /?
28145 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28146 before we supported unsafe code.
28148 * makefile: add --unsafe to the self compilation of mcs.
28150 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28152 * expression.cs (PointerArithmetic): New class that is used to
28153 perform pointer arithmetic.
28154 (Binary.Resolve): Handle pointer arithmetic
28155 Handle pointer comparission.
28156 (ArrayPtr): Utility expression class that is used to take the
28157 address of an array.
28159 (ElementAccess): Implement array access for pointers
28161 * statement.cs (Fixed): Implement fixed statement for arrays, we
28162 are missing one more case before we are done.
28164 * expression.cs (Indirection): Implement EmitAssign and set the
28165 ExprClass to Variable. This allows pointer dereferences to be
28166 treated as variables, and to have values assigned to them.
28168 * ecore.cs (Expression.StoreFromPtr): New utility function to
28169 store values dereferencing.
28171 2002-02-20 Ravi Pratap <ravi@ximian.com>
28173 * expression.cs (Binary.ResolveOperator): Ensure that we are
28174 not trying to operate on a void type - this fixes the reported
28177 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28178 the parent implementation is sealed.
28180 * ../errors/cs0239.cs : Add.
28182 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28184 * typemanager.cs (unverifiable_code_type): Corresponds to
28185 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28186 which have unsafe code in them.
28188 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28191 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28193 * cs-tokenizer.cs: Add support for @"litreal strings"
28195 Make tokenizer accept pre-processor directives
28196 on any column (remove the old C-like limitation).
28198 * rootcontext.cs (EmitCode): Emit any global attributes.
28199 (AddGlobalAttributes): Used to keep track of assembly attributes.
28201 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28203 * cs-parser.jay: Add support for global attributes.
28205 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28207 * expression.cs (Indirection): New helper class. Unary will
28208 create Indirection classes to be able to implement the
28209 IMemoryLocation interface on it.
28211 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28213 * cs-parser.jay (fixed_statement): reference the right statement.
28215 * statement.cs (Fixed.Emit): Finish implementing the fixed
28216 statement for the &x case.
28218 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28220 * class.cs (Property.Define, Method.Define): Remove newslot when
28223 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28224 wrong. NewSlot should only be used if the `new' keyword is present.
28226 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28227 locating our system dir. Sorry about this.
28229 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28231 * driver.cs (GetSystemDir): Compute correctly the location of our
28232 system assemblies. I was using the compiler directory instead of
28233 the library directory.
28235 2002-02-13 Ravi Pratap <ravi@ximian.com>
28237 * expression.cs (BetterFunction): Put back in what Miguel commented out
28238 since it is the correct fix. The problem is elsewhere ;-)
28240 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28241 parameters of the parms method are themselves compatible or not !
28243 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28244 to check that a class implements an interface before saying that an implicit
28245 conversion was allowed. Use ImplementsInterface to do the checking.
28247 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28249 * class.cs (Method.Define): Track whether we are an explicit
28250 implementation or not. And only call DefineMethodOverride if we
28251 are an explicit implementation.
28253 (Property.DefineMethod): Ditto.
28255 2002-02-11 Ravi Pratap <ravi@ximian.com>
28257 * expression.cs (BetterFunction): Catch hideous bug which was
28258 preventing us from detecting ambiguous calls due to implicit casts i.e
28261 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28263 * support.cs (Pair): Remove un-needed method. I figured why I was
28264 getting the error in cs-parser.jay, the variable in a foreach loop
28265 is readonly, and the compiler does not really treat this as a variable.
28267 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28268 instead of EQUALS in grammar.
28270 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28272 * expression.cs (Unary.DoResolve): Check whether the argument is
28275 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28277 * support.cs: Api for Pair to set a value. Despite the fact that
28278 the variables are public the MS C# compiler refuses to compile
28279 code that accesses the field if the variable is part of a foreach
28282 * statement.cs (Fixed): Begin implementation of the fixed
28285 (Block.AddVariable): Return the VariableInfo on success and null
28286 on failure instead of true/false.
28288 * cs-parser.jay (foreach): Catch errors on variables already
28289 defined (we were ignoring this value before) and properly unwind
28290 the block hierarchy
28292 (fixed_statement): grammar for the fixed statement.
28294 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28296 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28297 pointer types to be incretemented.
28299 (SizeOf): Implement.
28301 * cs-parser.jay (pointer_member_access): Implement
28302 expr->IDENTIFIER production.
28304 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28305 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28308 (Unary): Implement indirection.
28310 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28311 use in non-unsafe context).
28313 (SimpleName.DoResolve): Check for pointers in field access on safe
28316 (Expression.LoadFromPtr): Factor the load-indirect code in this
28317 function. This was duplicated in UnboxCast and ParameterReference
28319 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28321 * expression.cs (ComposedCast): report an error if a pointer cast
28322 is used in a safe region.
28324 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28325 pointer type casts in unsafe context.
28327 * codegen.cs (EmitContext): Set up IsUnsafe.
28329 * cs-parser.jay (non_expression_type): Add productions for pointer
28332 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28333 code. We should not use force into static mode if the method is
28334 not virtual. Fixes bug in MIS
28336 * statement.cs (Do.Emit, While.Emit, For.Emit,
28337 Statement.EmitBoolExpression): Add support to Do and While to
28338 propagate infinite loop as `I do return' semantics.
28340 Improve the For case to also test for boolean constants.
28342 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28343 to the list of attributes we can add.
28345 Remove `EmitContext' argument.
28347 * class.cs (Method.Define): Apply parameter attributes.
28348 (Constructor.Define): Apply parameter attributes.
28349 (MethodCore.LabelParameters): Move here the core of labeling
28352 * support.cs (ReflectionParameters.ParameterModifier,
28353 InternalParameters.ParameterModifier): Use IsByRef on the type and
28354 only return the OUT bit for these parameters instead of in/out/ref
28357 This is because I miss-understood things. The ParameterInfo.IsIn
28358 and IsOut represent whether the parameter has the [In] and [Out]
28361 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28363 * ecore.cs (FieldExpr.Emit): Release temporaries.
28365 * assign.cs (LocalTemporary.Release): new function.
28367 * codegen.cs (EmitContext.GetTemporaryStorage,
28368 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28369 temporary storage. Now we can "put back" localbuilders when we
28372 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28374 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28375 need to make a copy of the variable to generate verifiable code.
28377 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28379 * driver.cs: Compute dynamically the system directory.
28381 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28382 Slower, but more generally useful. Used by the abstract
28383 registering implementation.
28385 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28386 the rules for the special rule on Type/instances. First check if
28387 we have the same name, and if so, try that special static path
28388 rather than the instance path.
28390 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28392 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28395 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28396 Enum, ValueType, Delegate or Array for non-corlib compiles.
28398 * cs-tokenizer.cs: Catch long identifiers (645)
28400 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28403 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28404 fix, we were returning too early, so we were not registering
28405 pending methods from abstract classes.
28407 Do not register pending methods if the class is abstract.
28409 * expression.cs (Conditional.DoResolve): Report circular implicit
28410 conversions when we neecd to compute it for conditional
28413 (Is.DoResolve): If the expression is always of the provided type,
28414 flag warning 183. If the expression can not ever be of the
28415 provided type flag warning 184.
28417 * class.cs: Catch 169 as well.
28419 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28422 2002-01-18 Nick Drochak <ndrochak@gol.com>
28424 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28426 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28428 * interface.cs: (PopulateMethod): Check for pointers being defined
28429 only if the unsafe context is active.
28430 (PopulateProperty): ditto.
28431 (PopulateIndexer): ditto.
28433 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28434 specified. If pointers are present, make sure that they are
28435 present in an unsafe context.
28436 (Constructor, Constructor.Define): ditto.
28437 (Field, Field.Define): ditto.
28438 (Property, Property.Define): ditto.
28439 (Event, Event.Define): ditto.
28441 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28442 hashtable if there are classes or structs defined.
28444 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28445 code, as the constant resolution moved.
28447 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28448 the metadata, so we can flag error 133.
28450 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28451 pointer is being declared in an unsafe context.
28453 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28455 * modifiers.cs (Modifiers.Check): Require a Location argument.
28456 Report error 227 for Unsafe use.
28458 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28460 * statement.cs (For.Emit): If the test is null, then report that
28461 we do `return', as we wont reach anything afterwards.
28463 (Switch.SwitchGoverningType): Track the expression that matched
28466 * driver.cs: Allow negative numbers as an error code to flag.
28468 * cs-parser.jay: Handle 1551.
28470 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28472 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28474 * cs-parser.jay: Report 1518 (type declaration can only contain
28475 class, struct, interface, enum or delegate)
28477 (switch_label): Report 1523 (keywords `case' or `default' must
28480 (opt_switch_sections): Report 1522 (empty switch)
28482 * driver.cs: Report 1515 (response file specified multiple times)
28483 Report 1516 (Source file specified multiple times).
28485 * expression.cs (Argument.Resolve): Signal 1510
28487 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28488 access not allowed in static code)
28490 2002-01-11 Ravi Pratap <ravi@ximian.com>
28492 * typemanager.cs (IsPointerType): Utility method which we are going
28495 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28496 the object type, so we take care of that.
28498 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28500 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28501 added to non-params parameters :-)
28503 * typemanager.cs (CSharpName): Include 'void' type too.
28505 (void_ptr_type): Include in the set of core types.
28507 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28510 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28513 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28514 completely forgotten about it.
28516 2002-01-10 Ravi Pratap <ravi@ximian.com>
28518 * cs-parser.jay (pointer_type): Add. This begins our implementation
28519 of parsing rules for unsafe code.
28521 (unsafe_statement): Implement.
28523 (embedded_statement): Modify to include the above.
28525 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28527 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28528 if the current context is an unsafe one.
28530 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28531 are handled differently, we need separate rules for them.
28533 (local_variable_declaration): Update to use local_variable_pointer_type
28534 to allow variable declarations of unmanaged pointer types.
28536 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28537 in unsafe contexts.
28539 * ../errors/cs0214.cs : Add.
28541 2002-01-16 Nick Drochak <ndrochak@gol.com>
28543 * makefile: remove 'response' file when cleaning.
28545 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28547 * cs-parser.jay: Report 1524.
28549 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28551 * typemanager.cs (RegisterMethod): drop checking if we have
28552 registered this from here
28554 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28556 * class.cs (Method.EmitDestructor): Implement calling our base
28559 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28560 value of InFinally.
28562 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28563 this routine and will wrap the call in a try/catch block. Deal
28566 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28568 * ecore.cs (Expression.MemberLookup): instead of taking a
28569 parameter `same_type' that was used to tell whether we could
28570 access private members we compute our containing type from the
28573 (FieldExpr): Added partial support for volatile fields. This does
28574 not work for volatile fields exposed from assemblies, as I can not
28575 figure out how to extract the modreq from it.
28577 Updated all the source files to use this.
28579 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28580 because it is referenced by MemberLookup very often.
28582 2002-01-09 Ravi Pratap <ravi@ximian.com>
28584 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28585 TypeBuilder.GetCustomAttributes to retrieve what we need.
28587 Get rid of redundant default_member_attr_type as this is the same as
28588 default_member_type which already exists.
28590 * interface.cs, attribute.cs : Update accordingly.
28592 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28594 * typemanager.cs: Enable IndexerPropertyName again. It does not
28595 work for TYpeBuilders though. Ravi, can you please fix this?
28597 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28599 * expression.cs (Argument.Emit): Handle the case of ref objects
28600 being passed to ref functions;
28602 (ParameterReference.EmitLoad): Loads the content of the pointer
28603 without dereferencing.
28605 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28607 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28609 2002-01-08 Ravi Pratap <ravi@ximian.com>
28611 * class.cs (Indexer.DefineMethod): Incorporate the interface
28612 type in the name of the method if we are doing explicit interface
28615 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28617 (BetterConversion): Fix extremely trivial bug where we were referring to
28618 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28621 * ../errors/bug16.cs : Add although we have fixed it.
28623 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28625 * expression.cs (BaseIndexer): Begin implementation.
28627 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28629 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28630 production directly to remove a shift/reduce, and implement
28631 explicit interface implementation.
28633 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28634 after a floating point suffix.
28636 * expression.cs (DoNumericPromotions): Improved the conversion for
28637 uint/uint. If we have a constant, we avoid doing a typecast to a
28640 * class.cs (Indexer): Implement explicit interface implementation
28643 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28645 * class.cs: make the default instance constructor public and hidebysig.
28647 2001-01-03 Ravi Pratap <ravi@ximian.com>
28649 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28650 so we can call it from elsewhere.
28652 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28653 we emit it internally if the class has a defined indexer; otherwise the user
28654 emits it by decorating the class definition with the DefaultMemberAttribute.
28656 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28657 attribute is not used on a type which defines an indexer.
28659 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28660 character when we skip whitespace.
28662 * ../errors/cs0646.cs : Add.
28664 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28666 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28669 * makefile: Add practical target `mcs3.exe' which builds the third
28670 generation compiler.
28672 * expression.cs (New): Fix structures constructor calling.
28674 * class.cs (Property, Method, Indexer): Emit Final flag on the
28675 method if we are an interface implementation and we are not
28678 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28679 whether this property is referencing a `base' method.
28681 * expression.cs (Invocation.EmitCall): take an extra argument:
28682 is_base, this is used to determine whether the `call' or
28683 `callvirt' opcode should be used.
28686 * delegate.cs: update EmitCall.
28688 * class.cs (Method.Define): Set NewSlot for the cases where we are
28689 not implementing an interface method.
28691 (Property.Define): ditto.
28693 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28695 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28696 'r'. Allows mcs to parse itself fully.
28698 2002-01-02 Ravi Pratap <ravi@ximian.com>
28700 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28701 of the number of initializers that require the InitializeArray method.
28703 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28704 update the above field where necessary.
28706 (MakeByteBlob): Update accordingly.
28708 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28711 (EmitDynamicInitializers): Update in accordance with the new optimization.
28713 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28714 same OpCode applies.
28716 * cs-parser.jay : Fix some glaring errors I introduced.
28718 2002-01-01 Ravi Pratap <ravi@ximian.com>
28720 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28721 so that we can check for name clashes there too.
28723 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28724 for interface indexers.
28726 * interfaces.cs (Define): Emit the default member attribute.
28728 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28729 variable was being referred to while setting the value ;-)
28731 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28733 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28734 byte-by-byte information when we know the data is zero.
28736 Make the block always a multiple of 4, because
28737 DefineInitializedData has a bug.
28739 * assign.cs: Fix, we should assign from the temporary, not from
28742 * expression.cs (MakeByteBlob): Fix my incorrect code.
28744 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28746 * typemanager.cs (EnumToUnderlying): This function is used to get
28747 the underlying type from an enumeration, because it does not
28750 * constant.cs: Use the I4_S form for values between -128 and 127.
28752 * statement.cs (Block.LookupLabel): Looks up a label.
28753 (Block): Drop support for labeled blocks.
28755 (LabeledStatement): New kind of statement that represents a label
28758 (Goto): Finally implement this bad boy.
28760 * cs-parser.jay: Update to reflect new mechanism to implement
28763 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28765 * codegen.cs (EmitContext.This): a codegen property that keeps the
28766 a single instance of this instead of creating many different this
28769 * delegate.cs (Delegate.DoResolve): Update to use the property;
28771 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28773 * expression.cs (BaseAccess.DoResolve): Ditto.
28775 2001-12-29 Ravi Pratap <ravi@ximian.com>
28777 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28778 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28780 (InitCoreTypes): Update accordingly.
28782 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28783 so we can quickly store the state.
28785 (ApplyAttributes): Set the correct implementation flags
28786 for InternalCall methods.
28788 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28790 * expression.cs (EmitCall): if a method is not virtual, then do
28791 not use callvirt on it.
28793 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28794 user defined stuff) requires the use of stobj, which takes an
28795 address on the stack instead of an array and an index. So emit
28796 the Ldelema operation for it.
28798 (EmitStoreOpcode): Use stobj for valuetypes.
28800 (UnaryMutator.EmitCode): Use the right 1 value depending on
28801 whether we are dealing with int64/uint64, float or doubles.
28803 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28804 constructors that I implemented last night.
28806 (Constructor.IsDefault): Fix to work properly for static
28809 * cs-parser.jay (CheckDef): report method signature errors.
28810 Update error number 103 to be 132.
28812 * decl.cs: New AdditionResult enumeration value: MethodExists.
28813 Although we do this check for methods later on in the semantic
28814 analysis, catching repeated default constructors is so easy that
28815 we catch these here.
28817 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28820 (ParameterReference.EmitAssign, Emit): handle
28823 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28824 (ArrayAccess.EmitStoreOpcode): ditto.
28826 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28828 * expression.cs (MakeByteBlob): Complete all the missing types
28829 (uint, short, ushort, byte, sbyte)
28831 * class.cs: Only init instance field initializers on instance
28834 Rename `constructors' to instance_constructors.
28836 (TypeContainer.AddConstructor): Only add constructors to the list
28837 if it is not static.
28839 Make sure that we handle default_static_constructor independently
28840 everywhere where we handle instance_constructors
28842 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28844 * class.cs: Do not lookup or create a base initializer for a
28845 static constructor.
28847 (ConstructorInitializer.Resolve): use the proper type to lookup
28850 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28852 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28855 * decl.cs: CloseType is now an virtual method, the default
28856 implementation just closes this type.
28858 2001-12-28 Ravi Pratap <ravi@ximian.com>
28860 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28861 to PreserveSig by default. Also emit HideBySig on such methods.
28863 Basically, set the defaults to standard values.
28865 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28866 argument, if candidate is better, it can't be worse than the best !
28868 (Invocation): Re-write bits to differentiate between methods being
28869 applicable in their expanded form and their normal form - for params
28872 Get rid of use_standard everywhere as only standard conversions are allowed
28873 in overload resolution.
28875 More spec conformance.
28877 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28879 * driver.cs: Add --timestamp, to see where the compiler spends
28882 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28883 `this' in static code.
28885 (SimpleName.DoResolve): Implement in terms of a helper function
28886 that allows static-references to be passed upstream to
28889 (Expression.ResolveWithSimpleName): Resolve specially simple
28890 names when called by MemberAccess to implement the special
28893 (Expression.ImplicitReferenceConversion): Handle conversions from
28894 Null to reference types before others, as Null's type is
28897 * expression.cs (Invocation.EmitCall): Handle the special case of
28898 calling methods declared on a reference type from a ValueType
28899 (Base classes System.Object and System.Enum)
28901 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28902 the left hand side is a TypeExpr, not on every enumeration.
28904 (Binary.Resolve): If types are reference types, then do a cast to
28905 object on operators != and == of both arguments.
28907 * typemanager.cs (FindMembers): Extract instance and static
28908 members if requested.
28910 * interface.cs (PopulateProperty): Use void_type instead of null
28911 as the return type for the setter method.
28913 (PopulateIndexer): ditto.
28915 2001-12-27 Ravi Pratap <ravi@ximian.com>
28917 * support.cs (ReflectionParameters): Fix minor bug where we
28918 were examining the wrong parameter for the ParamArray attribute.
28920 Cope with requests for the type of the parameter at position
28921 greater than the params parameter's. We now return the element
28922 type of the params array as that makes more sense.
28924 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28925 accordingly as we no longer have to extract the element type
28928 (Invocation.OverloadResolve): Update.
28930 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28932 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28933 against IEnumerator, test whether the return value is a descendant
28934 of the IEnumerator interface.
28936 * class.cs (Indexer.Define): Use an auxiliary method to implement
28937 the other bits of the method definition. Begin support for
28938 explicit interface implementation.
28940 (Property.DefineMethod): Use TypeManager.void_type instead of null
28941 for an empty return value.
28943 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28945 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28946 dealing with a FieldExpr which is composed of a FieldBuilder, in
28947 the code path we did extract the constant, but we should have
28948 obtained the underlying value to be able to cast it (otherwise we
28949 end up in an infinite loop, this is what Ravi was running into).
28951 (ArrayCreation.UpdateIndices): Arrays might be empty.
28953 (MemberAccess.ResolveMemberAccess): Add support for section
28954 14.5.4.1 that deals with the special case of E.I when E is a type
28955 and something else, that I can be a reference to a static member.
28957 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28958 handle a particular array type to create byte blobs, it is just
28959 something we dont generate byteblobs for.
28961 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28964 * location.cs (Push): remove the key from the hashtable that we
28965 are about to add. This happens for empty files.
28967 * driver.cs: Dispose files after we have parsed them.
28969 (tokenize): new function that only runs the tokenizer on its
28970 input, for speed testing.
28972 2001-12-26 Ravi Pratap <ravi@ximian.com>
28974 * class.cs (Event.Define): Define the private field only if there
28975 are no accessors defined.
28977 * expression.cs (ResolveMemberAccess): If there is no associated
28978 field with the event, that means we have an event defined with its
28979 own accessors and we should flag error cs0070 since transforming
28980 ourselves into a field is not valid in that case.
28982 * ecore.cs (SimpleName.DoResolve): Same as above.
28984 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28985 and charset to sane values.
28987 2001-12-25 Ravi Pratap <ravi@ximian.com>
28989 * assign.cs (DoResolve): Perform check on events only if they
28990 are being accessed outside the declaring type.
28992 * cs-parser.jay (event_declarations): Update rules to correctly
28993 set the type of the implicit parameter etc.
28995 (add_accessor, remove_accessor): Set current local parameters.
28997 * expression.cs (Binary): For delegate addition and subtraction,
28998 cast the return value from the method into the appropriate delegate
29001 2001-12-24 Ravi Pratap <ravi@ximian.com>
29003 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29004 of these as the workaround is unnecessary.
29006 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29007 delegate data - none of that is needed at all.
29009 Re-write bits to extract the instance expression and the delegate method
29012 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29015 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29016 of attaching attributes instead of duplicating code everywhere.
29018 * everywhere : Update code to do attribute emission using the above method.
29020 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29022 * expression.cs (IsParamsMethodApplicable): if there are not
29023 parameters, return immediately.
29025 * ecore.cs: The 0 literal can be implicity converted to an enum
29028 (SimpleName.DoResolve): First lookup the type, then lookup the
29031 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29032 want to get its address. If the InstanceExpression is not
29033 addressable, store the result in a temporary variable, then get
29036 * codegen.cs: Only display 219 errors on warning level or above.
29038 * expression.cs (ArrayAccess): Make it implement the
29039 IMemoryLocation interface.
29041 (Binary.DoResolve): handle the operator == (object a, object b)
29042 and operator != (object a, object b) without incurring into a
29043 BoxedCast (because 5 != o should never be performed).
29045 Handle binary enumerator operators.
29047 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29048 value type, otherwise use Ldelem_ref.
29050 Use precomputed names;
29052 (AddressOf): Implement address of
29054 * cs-parser.jay (labeled_statement): Fix recursive block
29055 addition by reworking the production.
29057 * expression.cs (New.DoEmit): New has a special case:
29059 If we are dealing with a ValueType, we have a few
29060 situations to deal with:
29062 * The target of New is a ValueType variable, that is
29063 easy, we just pass this as the variable reference
29065 * The target of New is being passed as an argument,
29066 to a boxing operation or a function that takes a
29069 In this case, we need to create a temporary variable
29070 that is the argument of New.
29073 2001-12-23 Ravi Pratap <ravi@ximian.com>
29075 * rootcontext.cs (LookupType): Check that current_type is not null before
29076 going about looking at nested types.
29078 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29079 not implement the IAssignMethod interface any more.
29081 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29082 where we tranform them into FieldExprs if they are being resolved from within
29083 the declaring type.
29085 * ecore.cs (SimpleName.DoResolve): Do the same here.
29087 * assign.cs (DoResolve, Emit): Clean up code considerably.
29089 * ../errors/bug10.cs : Add.
29091 * ../errors/cs0070.cs : Add.
29093 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29095 * assign.cs : Get rid of EventIsLocal everywhere.
29097 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29099 * ecore.cs (ConvertIntLiteral): finished the implementation.
29101 * statement.cs (SwitchLabel): Convert the value we are using as a
29102 key before looking up the table.
29104 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29106 * codegen.cs (EmitTopBlock): Require a Location argument now.
29108 * cs-parser.jay (constructor_declarator): We need to setup
29109 current_local_parameters before we parse the
29110 opt_constructor_initializer, to allow the variables to be bound
29111 to the constructor arguments.
29113 * rootcontext.cs (LookupType): First lookup nested classes in our
29114 class and our parents before we go looking outside our class.
29116 * expression.cs (ConstantFold): Extract/debox the values at the
29119 * rootcontext.cs (EmitCode): Resolve the constants first before we
29120 resolve the types. This is not really needed, but it helps debugging.
29122 * statement.cs: report location.
29124 * cs-parser.jay: pass location to throw statement.
29126 * driver.cs: Small bug fix.
29128 * report.cs: Updated format to be 4-zero filled digits.
29130 2001-12-22 Ravi Pratap <ravi@ximian.com>
29132 * expression.cs (CheckIndices): Fix minor bug where the wrong
29133 variable was being referred to ;-)
29135 (DoEmit): Do not call EmitStaticInitializers when the
29136 underlying type is System.Object.
29138 2001-12-21 Ravi Pratap <ravi@ximian.com>
29140 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29141 and do the usual workaround for SRE.
29143 * class.cs (MyEventBuilder.EventType): New member to get at the type
29144 of the event, quickly.
29146 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29148 * assign.cs (Assign.DoResolve): Handle the case when the target
29149 is an EventExpr and perform the necessary checks.
29151 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29154 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29156 (EventExpr): Set the type in the constructor itself since we
29157 are meant to be born fully resolved.
29159 (EventExpr.Define): Revert code I wrote earlier.
29161 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29162 instance expression is null. The instance expression is a This in that case
29163 or a null, depending on whether it is a static method or not.
29165 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29166 refers to more than one method.
29168 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29169 and accordingly flag errors.
29171 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29173 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29175 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29177 * location.cs (ToString): Provide useful rutine.
29179 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29181 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29182 objects, return the actual integral boxed.
29184 * statement.cs (SwitchLabel): define an ILLabel for each
29187 (Switch.CheckSwitch): If the value is a Literal, extract
29188 the underlying literal.
29190 Also in the unused hashtable we had, add the SwitchLabel so we can
29191 quickly look this value up.
29193 * constant.cs: Implement a bunch of new constants. Rewrite
29194 Literal based on this. Made changes everywhere to adapt to this.
29196 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29197 dereferencing array only once, and also copes with enumrations.
29199 bytes are two bytes wide, not one.
29201 (Cast): Perform constant conversions.
29203 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29204 wrappers to the literals here.
29206 * expression.cs (DoNumericPromotions): long literals can converted
29207 to ulong implicity (this is taken care of elsewhere, but I was
29208 missing this spot).
29210 * ecore.cs (Expression.Literalize): Make the return type Literal,
29211 to improve type checking.
29213 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29215 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29217 * literal.cs: Revert code from ravi that checked the bounds. The
29218 bounds are sane by the definition of the type itself.
29220 * typemanager.cs: Fix implementation of ImplementsInterface. We
29221 need to actually look up in our parent hierarchy for interfaces
29224 * const.cs: Use the underlying type for enumerations
29226 * delegate.cs: Compute the basename for the delegate creation,
29227 that should fix the delegate test case, and restore the correct
29228 Type Lookup semantics in rootcontext
29230 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29231 referencing a nested type with the Reflection API is using the "+"
29234 * cs-parser.jay: Do not require EOF token at the end.
29236 2001-12-20 Ravi Pratap <ravi@ximian.com>
29238 * rootcontext.cs (LookupType): Concatenate type names with
29239 a '.' instead of a '+' The test suite passes again.
29241 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29242 field of the enumeration.
29244 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29245 the case when the member is an EventExpr.
29247 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29248 static has an associated instance expression.
29250 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29252 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29254 * class.cs (Event.Define): Register event and perform appropriate checks
29257 We define the Add and Remove methods even if the use provides none because
29258 in that case, we provide default implementations ourselves.
29260 Define a private field of the type of the event. This is done by the CSC compiler
29261 and we should be doing it too ;-)
29263 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29264 More methods we use in code we generate.
29266 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29269 (InitCoreTypes): Update accordingly for the above.
29271 * class.cs (Event.Emit): Generate code for default accessors that we provide
29273 (EmitDefaultMethod): Do the job in the above.
29275 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29278 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29280 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29281 builders even if we were missing one.
29283 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29284 pass the Basename as our class name instead of the Name. The
29285 basename will be correctly composed for us.
29287 * parameter.cs (Paramters): Now takes a Location argument.
29289 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29290 make all the code call directly LookupType in RootContext and take
29291 this chance to pass the Location information everywhere.
29293 * Everywhere: pass Location information.
29295 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29297 * class.cs (Constructor.Define): Updated way of detecting the
29298 length of the parameters.
29300 (TypeContainer.DefineType): Use basename as the type name for
29303 (TypeContainer.Define): Do not recursively define types here, as
29304 definition is taken care in order by the RootContext.
29306 * tree.cs: Keep track of namespaces in a per-file basis.
29308 * parameter.cs (Parameter.ComputeSignature): Update to use
29311 (Parameters.GetSignature): ditto.
29313 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29314 instead of a TypeContainer.
29316 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29317 resolve names. Because we need to be resolve in our context, not
29320 * driver.cs: Implement response files.
29322 * class.cs (TypeContainer.DefineType): If we are defined, do not
29323 redefine ourselves.
29325 (Event.Emit): Emit the code for add/remove handlers.
29326 (Event.Define): Save the MethodBuilders for add/remove.
29328 * typemanager.cs: Use pair here too.
29330 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29331 DictionaryEntry requires the first argument to be non-null.
29333 (enum_declaration): Compute full name for registering the
29336 (delegate_declaration): Instead of using
29337 formal_parameter_list, use opt_formal_parameter_list as the list
29340 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29341 (EventParsing): New property that controls whether `add' and
29342 `remove' are returned as tokens or identifiers (for events);
29344 2001-12-19 Ravi Pratap <ravi@ximian.com>
29346 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29347 use MyEventBuilder only and let it wrap the real builder for us.
29349 (MyEventBuilder): Revamp constructor etc.
29351 Implement all operations that we perform on EventBuilder in precisely the same
29354 (FindMembers): Update to use the EventBuilder member.
29356 (Event.Emit): Update accordingly.
29358 2001-12-18 Ravi Pratap <ravi@ximian.com>
29360 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29361 by calling the appropriate methods.
29363 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29366 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29368 2001-12-17 Ravi Pratap <ravi@ximian.com>
29370 * delegate.cs (Delegate.Populate): Check that the return type
29371 and various parameters types are indeed accessible.
29373 * class.cs (Constructor.Define): Same here.
29375 (Field.Define): Ditto.
29377 (Event.Define): Ditto.
29379 (Operator.Define): Check that the underlying Method defined itself
29380 correctly - so it's MethodBuilder should not be null.
29382 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29383 expression happens to be null.
29385 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29386 members but as of now we don't seem to be able to do anything really useful with it.
29388 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29389 not the EventBuilder.
29391 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29393 * cs-tokenizer.cs: Add support for defines.
29394 Add support for #if, #elif, #else, #endif
29396 (eval_var): evaluates a variable.
29397 (eval): stubbed for evaluating functions.
29399 * cs-parser.jay: Pass the defines information
29401 * driver.cs: Add --define command line option.
29403 * decl.cs: Move MemberCore here.
29405 Make it the base class for DeclSpace. This allows us to catch and
29406 report 108 and 109 for everything now.
29408 * class.cs (TypeContainer.Define): Extract all the members
29409 before populating and emit the warning 108 (new keyword required
29410 to override) instead of having each member implement this.
29412 (MemberCore.Define): New abstract method, we will be using this in
29413 the warning reporting engine in Populate.
29415 (Operator.Define): Adjust to new MemberCore protocol.
29417 * const.cs (Const): This does not derive from Expression, it is a
29418 temporary object we use to create fields, it is a MemberCore.
29420 * class.cs (Method.Define): Allow the entry point to be in a
29423 * driver.cs: Rewrite the argument handler to clean it up a bit.
29425 * rootcontext.cs: Made it just an auxiliary namespace feature by
29426 making everything static.
29428 * driver.cs: Adapt code to use RootContext type name instead of
29431 * delegate.cs: Remove RootContext argument.
29433 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29436 * class.cs (Event.Define): The lookup can fail.
29438 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29440 * expression.cs: Resolve the this instance before invoking the code.
29442 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29444 * cs-parser.jay: Add a production in element_access that allows
29445 the thing to become a "type" reference. This way we can parse
29446 things like "(string [])" as a type.
29448 Note that this still does not handle the more complex rules of
29452 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29454 * ecore.cs: (CopyNewMethods): new utility function used to
29455 assemble the list of methods from running FindMembers.
29457 (MemberLookup): Rework FindMembers so that
29459 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29461 * class.cs (TypeContainer): Remove Delegates who fail to be
29464 * delegate.cs (Populate): Verify that we dont get null return
29465 values. TODO: Check for AsAccessible.
29467 * cs-parser.jay: Use basename to emit error 574 (destructor should
29468 have the same name as container class), not the full name.
29470 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29471 possible representation.
29473 Also implements integer type suffixes U and L.
29475 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29477 * expression.cs (ArrayCreation.DoResolve): We need to do the
29478 argument resolution *always*.
29480 * decl.cs: Make this hold the namespace. Hold the root context as
29482 (LookupType): Move here.
29484 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29486 * location.cs (Row, Name): Fixed the code, it was always returning
29487 references to the first file.
29489 * interface.cs: Register properties defined through interfaces.
29491 * driver.cs: Add support for globbing on the command line
29493 * class.cs (Field): Make it derive from MemberCore as well.
29496 2001-12-15 Ravi Pratap <ravi@ximian.com>
29498 * class.cs (Event::Define): Check that the type of the event is a delegate
29499 type else flag error #66.
29501 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29504 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29505 values of EntryPoint, CharSet etc etc.
29507 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29509 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29510 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29511 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29512 which needs this to do its work.
29514 * ../errors/cs0066.cs : Add.
29516 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29518 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29521 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29522 clears out the parameters field.
29523 (MemberSignatureCompare): Cleanup
29525 (MemberCore): New base class used to share code between MethodCore
29528 (RegisterRequiredImplementations) BindingFlags.Public requires
29529 either BindingFlags.Instace or Static. Use instance here.
29531 (Property): Refactored code to cope better with the full spec.
29533 * parameter.cs (GetParameterInfo): Return an empty array instead
29536 * class.cs (Property): Abstract or extern properties have no bodies.
29538 * parameter.cs (GetParameterInfo): return a zero-sized array.
29540 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29541 method modifier validation to the typecontainer so we can reuse
29542 this on properties.
29544 (MethodCore.ParameterTypes): return an empty sized array of types.
29546 (Property.Define): Test property modifier validity.
29548 Add tests for sealed/override too.
29550 (Method.Emit): abstract or extern methods have no bodies.
29552 2001-12-14 Ravi Pratap <ravi@ximian.com>
29554 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29557 (Method::Define, ::Emit): Modify accordingly.
29559 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29561 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29563 * makefile: Pass in /unsafe.
29565 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29567 * class.cs (MakeKey): Kill routine.
29569 * class.cs (TypeContainer.Define): Correctly define explicit
29570 method implementations (they require the full interface name plus
29573 * typemanager.cs: Deply the PtrHashtable here and stop using the
29574 lame keys. Things work so much better.
29576 This of course broke everyone who depended on `RegisterMethod' to
29577 do the `test for existance' test. This has to be done elsewhere.
29579 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29580 the object stupid Equals method (because, that like fails all over
29581 the place). We still do not use it.
29583 * class.cs (TypeContainer.SetRequiredInterface,
29584 TypeContainer.RequireMethods): Killed these two routines and moved
29585 all the functionality to RegisterRequiredImplementations.
29587 (TypeContainer.RegisterRequiredImplementations): This routine now
29588 registers all the implementations required in an array for the
29589 interfaces and abstract methods. We use an array of structures
29590 which can be computed ahead of time to reduce memory usage and we
29591 also assume that lookups are cheap as most classes will not
29592 implement too many interfaces.
29594 We also avoid creating too many MethodSignatures.
29596 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29597 clear the "pending" bit if we find that there are problems with
29600 (TypeContainer.VerifyPendingMethods): Update to report errors of
29601 methods that look like implementations but are not.
29603 (TypeContainer.Define): Add support for explicit interface method
29606 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29608 * typemanager.cs: Keep track of the parameters here instead of
29609 being a feature of the TypeContainer.
29611 * class.cs: Drop the registration of parameters here, as
29612 InterfaceMethods are also interface declarations.
29614 * delegate.cs: Register methods with the TypeManager not only with
29615 the TypeContainer. This code was buggy.
29617 * interface.cs: Full registation here.
29619 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29621 * expression.cs: Remove reducer for binary expressions, it can not
29624 * const.cs: Put here the code that used to go into constant.cs
29626 * constant.cs: Put here the code for constants, this is a new base
29627 class for Literals.
29629 * literal.cs: Make Literal derive from Constant.
29631 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29633 * statement.cs (Return.Emit): Report error 157 if the user
29634 attempts to return from a finally block.
29636 (Return.Emit): Instead of emitting a return, jump to the end of
29639 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29640 LocalBuilder to store the result of the function. ReturnLabel is
29641 the target where we jump.
29644 2001-12-09 Radek Doulik <rodo@ximian.com>
29646 * cs-parser.jay: remember alias in current namespace
29648 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29651 * class.cs (LookupAlias): lookup alias in my_namespace
29653 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29655 (LookupAlias): lookup alias in this and if needed in parent
29658 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29662 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29663 making things static. I need this to avoid passing the
29664 TypeContainer when calling ParameterType.
29666 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29667 that did string manipulation to compute the type and then call
29668 GetType. Use Parameter.ParameterType instead.
29670 * cs-tokenizer.cs: Consume the suffix for floating values.
29672 * expression.cs (ParameterReference): figure out whether this is a
29673 reference parameter or not. Kill an extra variable by computing
29674 the arg_idx during emission.
29676 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29677 function that returns whether a parameter is an out/ref value or not.
29679 (Parameter.ParameterType): The type of the parameter (base,
29680 without ref/out applied).
29682 (Parameter.Resolve): Perform resolution here.
29683 (Parameter.ExternalType): The full type (with ref/out applied).
29685 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29686 support for expressions on the using statement.
29688 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29690 * statement.cs (Using.EmitLocalVariableDecls): Split the
29691 localvariable handling of the using statement.
29693 (Block.EmitMeta): Keep track of variable count across blocks. We
29694 were reusing slots on separate branches of blocks.
29696 (Try.Emit): Emit the general code block, we were not emitting it.
29698 Check the type of the declaration to be an IDisposable or
29699 something that can be implicity converted to it.
29701 Emit conversions if required.
29703 * ecore.cs (EmptyExpression): New utility class.
29704 (Expression.ImplicitConversionExists): New utility function.
29706 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29708 * statement.cs (Using): Implement.
29710 * expression.cs (LocalVariableReference): Support read only variables.
29712 * statement.cs: Remove the explicit emit for the Leave opcode.
29713 (VariableInfo): Add a readonly field.
29715 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29717 * ecore.cs (ConvCast): new class used to encapsulate the various
29718 explicit integer conversions that works in both checked and
29719 unchecked contexts.
29721 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29722 properly generate the overflow opcodes.
29724 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29726 * statement.cs: The correct type for the EmptyExpression is the
29727 element_type, not the variable type. Ravi pointed this out.
29729 2001-12-04 Ravi Pratap <ravi@ximian.com>
29731 * class.cs (Method::Define): Handle PInvoke methods specially
29732 by using DefinePInvokeMethod instead of the usual one.
29734 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29735 above to do the task of extracting information and defining the method.
29737 2001-12-04 Ravi Pratap <ravi@ximian.com>
29739 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29740 of the condition for string type.
29742 (Emit): Move that here.
29744 (ArrayCreation::CheckIndices): Keep string literals in their expression
29747 (EmitDynamicInitializers): Handle strings appropriately.
29749 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29751 * codegen.cs (EmitContext): Replace multiple variables with a
29752 single pointer to the current Switch statement.
29754 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29757 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29761 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29764 (Foreach.Emit): Foreach on arrays was not setting
29765 up the loop variables (for break/continue).
29767 (GotoCase): Semi-implented.
29769 2001-12-03 Ravi Pratap <ravi@ximian.com>
29771 * attribute.cs (CheckAttribute): Handle system attributes by using
29772 Attribute.GetAttributes to examine information we need.
29774 (GetValidPlaces): Same here.
29776 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29778 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29780 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29782 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29784 (Method::Emit): Handle the case when we are a PInvoke method.
29786 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29788 * expression.cs: Use ResolveWithSimpleName on compound names.
29790 2001-12-02 Ravi Pratap <ravi@ximian.com>
29792 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29793 before trying to reduce it.
29795 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29797 * constant.cs (LookupConstantValue): Implement.
29799 (EmitConstant): Use the above in emitting the constant.
29801 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29802 that are user-defined by doing a LookupConstantValue on them.
29804 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29807 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29809 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29811 (BaseAccess.DoResolve): Implement.
29813 (MemberAccess.DoResolve): Split this routine into a
29814 ResolveMemberAccess routine that can be used independently
29816 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29818 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29819 As that share bits of the implementation. Is returns a boolean,
29820 while As returns the Type that is being probed.
29822 2001-12-01 Ravi Pratap <ravi@ximian.com>
29824 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29825 instead of a Literal - much easier.
29827 (EnumInTransit): Remove - utterly useless :-)
29829 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29831 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29833 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29834 chain when we have no associated expression.
29836 2001-11-30 Ravi Pratap <ravi@ximian.com>
29838 * constant.cs (Define): Use Location while reporting the errror.
29840 Also emit a warning when 'new' is used and there is no inherited
29843 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29846 (LookupEnumValue): Implement to lookup an enum member's value and define it
29849 (Populate): Re-write accordingly to use the above routine.
29851 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29853 * expression.cs (This): Fix prototype for DoResolveLValue to
29854 override the base class DoResolveLValue.
29856 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29859 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29860 (we need to load the address of the field here). This fixes
29863 (FieldExpr.DoResolveLValue): Call the DoResolve
29864 function to initialize the Instance expression.
29866 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29867 correctly the GetEnumerator operation on a value type.
29869 * cs-parser.jay: Add more simple parsing error catches.
29871 * statement.cs (Switch): Add support for string switches.
29872 Handle null specially.
29874 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29876 2001-11-28 Ravi Pratap <ravi@ximian.com>
29878 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29880 (declare_local_constant): New helper function.
29882 * statement.cs (AddConstant): Keep a separate record of constants
29884 (IsConstant): Implement to determine if a variable is a constant.
29886 (GetConstantExpression): Implement.
29888 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29890 * statement.cs (IsVariableDefined): Re-write.
29892 2001-11-27 Ravi Pratap <ravi@ximian.com>
29894 * class.cs (TypeContainer::FindMembers): Look for constants
29895 in the case when we are looking for MemberTypes.Field
29897 * expression.cs (MemberAccess::DoResolve): Check that in the
29898 case we are a FieldExpr and a Literal, we are not being accessed
29899 by an instance reference.
29901 * cs-parser.jay (local_constant_declaration): Implement.
29903 (declaration_statement): Implement for constant declarations.
29905 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29907 * statement.cs (Switch): Catch double defaults.
29909 (Switch): More work on the switch() statement
29910 implementation. It works for integral values now, need to finish
29914 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29916 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29917 integer literals into other integer literals. To be used by
29920 2001-11-24 Ravi Pratap <ravi@ximian.com>
29922 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29925 (EmitDynamicInitializers): Cope with the above since we extract data
29926 directly from ArrayData now.
29928 (ExpectInitializers): Keep track of whether initializers are mandatory
29931 (Bounds): Make it a hashtable to prevent the same dimension being
29932 recorded for every element in that dimension.
29934 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29937 Also fix bug which was causing the indices to be emitted in the reverse
29940 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29942 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29943 unfinished. They do not work, because the underlying code is
29946 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29948 * cs-parser.jay: Remove bogus fixme.
29950 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29951 on Switch statement.
29953 2001-11-23 Ravi Pratap <ravi@ximian.com>
29955 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29958 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29959 parameter. Apparently, any expression is allowed.
29961 (ValidateInitializers): Update accordingly.
29963 (CheckIndices): Fix some tricky bugs thanks to recursion.
29965 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29966 I was being completely brain-dead.
29968 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29969 and re-write acordingly.
29971 (DelegateInvocation): Re-write accordingly.
29973 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29975 (MakeByteBlob): Handle types more correctly.
29977 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29978 initialization from expressions but it is incomplete because I am a complete
29981 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29983 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29984 on If. Basically, we have to return `true' (ie, we do return to
29985 our caller) only if both branches of the if return.
29987 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29988 short-circuit operators, handle them as short circuit operators.
29990 (Cast.DoResolve): Resolve type.
29991 (Cast.Cast): Take an expression as the target type.
29993 * cs-parser.jay (cast_expression): Remove old hack that only
29994 allowed a limited set of types to be handled. Now we take a
29995 unary_expression and we resolve to a type during semantic
29998 Use the grammar productions from Rhys to handle casts (this is
29999 not complete like Rhys syntax yet, we fail to handle that corner
30000 case that C# has regarding (-x), but we will get there.
30002 2001-11-22 Ravi Pratap <ravi@ximian.com>
30004 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30005 field which is an array type.
30007 * cs-parser.jay (declare_local_variables): Support array initialization too.
30009 * typemanager.cs (MakeKey): Implement.
30011 (everywhere): Use the above appropriately.
30013 * cs-parser.jay (for_statement): Update for array initialization while
30014 declaring variables.
30016 * ecore.cs : The error message was correct, it's the variable's names that
30017 were misleading ;-) Make the code more readable.
30019 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30020 the correct type etc.
30022 (ConvertExplicit): Handle Enum types by examining the underlying type.
30024 2001-11-21 Ravi Pratap <ravi@ximian.com>
30026 * parameter.cs (GetCallingConvention): Always return
30027 CallingConventions.Standard for now.
30029 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30031 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30032 and `r' after calling DoNumericPromotions.
30034 * ecore.cs: Fix error message (the types were in the wrong order).
30036 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30037 BindingFlags.Instance as well
30039 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30040 implicit int literal conversion in an empty cast so that we
30041 propagate the right type upstream.
30043 (UnboxCast): new class used to unbox value types.
30044 (Expression.ConvertExplicit): Add explicit type conversions done
30047 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30048 the target type before applying the implicit LongLiterals to ULong
30051 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30053 * cs-parser.jay (for_statement): Reworked the way For works: now
30054 we declare manually any variables that are introduced in
30055 for_initializer to solve the problem of having out-of-band code
30056 emition (that is what got for broken).
30058 (declaration_statement): Perform the actual variable declaration
30059 that used to be done in local_variable_declaration here.
30061 (local_variable_declaration): Do not declare anything, just pass
30062 the information on a DictionaryEntry
30064 2001-11-20 Ravi Pratap <ravi@ximian.com>
30066 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30067 re-write of the logic to now make it recursive.
30069 (UpdateIndices): Re-write accordingly.
30071 Store element data in a separate ArrayData list in the above methods.
30073 (MakeByteBlob): Implement to dump the array data into a byte array.
30075 2001-11-19 Ravi Pratap <ravi@ximian.com>
30077 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30080 * constant.cs (Define): Implement.
30082 (EmitConstant): Re-write fully.
30084 Pass in location info.
30086 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30089 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30090 DictionaryEntry since we need location info too.
30092 (constant_declaration): Update accordingly.
30094 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30095 code into another method : UpdateIndices.
30097 2001-11-18 Ravi Pratap <ravi@ximian.com>
30099 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30100 some type checking etc.
30102 2001-11-17 Ravi Pratap <ravi@ximian.com>
30104 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30105 bits to provide dimension info if the user skips doing that.
30107 Update second constructor to store the rank correctly.
30109 2001-11-16 Ravi Pratap <ravi@ximian.com>
30111 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30112 and try to implement.
30114 * ../errors/cs0150.cs : Add.
30116 * ../errors/cs0178.cs : Add.
30118 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30120 * statement.cs: Implement foreach on multi-dimensional arrays.
30122 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30123 name of the params argument.
30125 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30126 initializing the array.
30128 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30129 we can use this elsewhere.
30131 * statement.cs: Finish implementation of foreach for single
30134 * cs-parser.jay: Use an out-of-band stack to pass information
30135 around, I wonder why I need this.
30137 foreach_block: Make the new foreach_block the current_block.
30139 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30140 function used to return a static Parameters structure. Used for
30141 empty parameters, as those are created very frequently.
30143 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30145 2001-11-15 Ravi Pratap <ravi@ximian.com>
30147 * interface.cs : Default modifier is private, not public. The
30148 make verify test passes again.
30150 2001-11-15 Ravi Pratap <ravi@ximian.com>
30152 * support.cs (ReflectionParameters): Fix logic to determine
30153 whether the last parameter is a params one. Test 9 passes again.
30155 * delegate.cs (Populate): Register the builders we define with
30156 RegisterParameterForBuilder. Test 19 passes again.
30158 * cs-parser.jay (property_declaration): Reference $6 instead
30159 of $$ to get at the location.
30161 (indexer_declaration): Similar stuff.
30163 (attribute): Ditto.
30165 * class.cs (Property): Register parameters for the Get and Set methods
30166 if they exist. Test 23 passes again.
30168 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30169 call to EmitArguments as we are sure there aren't any params arguments.
30170 Test 32 passes again.
30172 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30173 IndexOutOfRangeException.
30175 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30176 Test 33 now passes again.
30178 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30180 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30181 broke a bunch of things. Will have to come up with a better way
30182 of tracking locations.
30184 * statement.cs: Implemented foreach for single dimension arrays.
30186 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30188 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30189 an error. This removes the lookup from the critical path.
30191 * cs-parser.jay: Removed use of temporary_loc, which is completely
30194 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30196 * support.cs (ReflectionParameters.ParameterModifier): Report
30197 whether the argument is a PARAMS argument or not.
30199 * class.cs: Set the attribute `ParamArrayAttribute' on the
30200 parameter argument.
30202 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30203 and cons_param_array_attribute (ConstructorInfo for
30204 ParamArrayAttribute).,
30206 * codegen.cs: Emit the return using the `Return' statement, that
30207 way we can report the error correctly for missing return values.
30209 * class.cs (Method.Emit): Clean up.
30211 * expression.cs (Argument.Resolve): Take another argument: the
30212 location where this argument is used. Notice that this is not
30213 part of the "Argument" class as to reduce the size of the
30214 structure (we know the approximate location anyways).
30216 Test if the argument is a variable-reference, if not, then
30217 complain with a 206.
30219 (Argument.Emit): Emit addresses of variables.
30221 (Argument.FullDesc): Simplify.
30223 (Invocation.DoResolve): Update for Argument.Resolve.
30225 (ElementAccess.DoResolve): ditto.
30227 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30228 method should be virtual, as this method is always virtual.
30230 (NewDelegate.DoResolve): Update for Argument.Resolve.
30232 * class.cs (ConstructorInitializer.DoResolve): ditto.
30234 * attribute.cs (Attribute.Resolve): ditto.
30236 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30238 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30240 * expression.cs (ParameterReference): Drop IStackStorage and implement
30241 IAssignMethod instead.
30243 (LocalVariableReference): ditto.
30245 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30246 IAssignMethod instead.
30248 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30250 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30251 enumerations that are used in heavily used structures derive from
30252 byte in a laughable and pathetic attempt to reduce memory usage.
30253 This is the kind of pre-optimzations that you should not do at
30254 home without adult supervision.
30256 * expression.cs (UnaryMutator): New class, used to handle ++ and
30257 -- separatedly from the other unary operators. Cleans up the
30258 code, and kills the ExpressionStatement dependency in Unary.
30260 (Unary): Removed `method' and `Arguments' from this class, making
30261 it smaller, and moving it all to SimpleCall, so I can reuse this
30262 code in other locations and avoid creating a lot of transient data
30263 strucutres when not required.
30265 * cs-parser.jay: Adjust for new changes.
30267 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30269 * enum.cs (Enum.Populate): If there is a failure during
30272 * cs-parser.jay (opt_enum_base): we used to catch type errors
30273 here, but this is really incorrect. The type error should be
30274 catched during semantic analysis.
30276 2001-12-11 Ravi Pratap <ravi@ximian.com>
30278 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30279 current_local_parameters as expected since I, in my stupidity, had forgotten
30282 * attribute.cs (GetValidPlaces): Fix stupid bug.
30284 * class.cs (Method::Emit): Perform check on applicability of attributes.
30286 (Constructor::Emit): Ditto.
30288 (Field::Emit): Ditto.
30290 (Field.Location): Store location information.
30292 (Property, Event, Indexer, Operator): Ditto.
30294 * cs-parser.jay (field_declaration): Pass in location for each field.
30296 * ../errors/cs0592.cs : Add.
30298 2001-11-12 Ravi Pratap <ravi@ximian.com>
30300 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30302 (InitCoreTypes): Update accordingly.
30304 (RegisterAttrType, LookupAttr): Implement.
30306 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30307 info about the same.
30309 (Resolve): Update to populate the above as necessary.
30311 (Error592): Helper.
30313 (GetValidPlaces): Helper to the above.
30315 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30317 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30319 2001-11-12 Ravi Pratap <ravi@ximian.com>
30321 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30323 * ../errors/cs0617.cs : Add.
30325 2001-11-11 Ravi Pratap <ravi@ximian.com>
30327 * enum.cs (Emit): Rename to Populate to be more consistent with what
30328 we expect it to do and when exactly it is called.
30330 * class.cs, rootcontext.cs : Update accordingly.
30332 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30333 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30335 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30337 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30338 of a fieldinfo using the above, when dealing with a FieldBuilder.
30340 2001-11-10 Ravi Pratap <ravi@ximian.com>
30342 * ../errors/cs0031.cs : Add.
30344 * ../errors/cs1008.cs : Add.
30346 * ../errrors/cs0543.cs : Add.
30348 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30351 (FindMembers): Implement.
30353 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30354 enums and delegates too.
30356 (enum_types): Rename to builder_to_enum.
30358 (delegate_types): Rename to builder_to_delegate.
30360 * delegate.cs (FindMembers): Implement.
30362 2001-11-09 Ravi Pratap <ravi@ximian.com>
30364 * typemanager.cs (IsEnumType): Implement.
30366 * enum.cs (Emit): Re-write parts to account for the underlying type
30367 better and perform checking etc.
30369 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30370 of the underlying type.
30372 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30375 * enum.cs (error31): Helper to report error #31.
30377 * cs-parser.jay (enum_declaration): Store location of each member too.
30379 * enum.cs (member_to_location): New hashtable.
30381 (AddEnumMember): Update location hashtable.
30383 (Emit): Use the location of each member while reporting errors.
30385 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30387 * cs-parser.jay: A for_initializer if is a
30388 local_variable_declaration really ammount to have an implicit
30389 block with the variable declaration and no initializer for for.
30391 * statement.cs (For.Emit): Cope with null initializers.
30393 This fixes the infinite loop on for initializers.
30395 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30397 * enum.cs: More cleanup.
30399 * ecore.cs: Remove dead code.
30401 * class.cs (Property.Emit): More simplification.
30402 (Event.Emit): ditto.
30404 Reworked to have less levels of indentation.
30406 2001-11-08 Ravi Pratap <ravi@ximian.com>
30408 * class.cs (Property): Emit attributes.
30418 * enum.cs (Emit): Ditto.
30420 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30423 * class.cs (Field, Event, etc.): Move attribute generation into the
30424 Emit method everywhere.
30426 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30427 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30428 as we had no way of defining nested enums !
30430 * rootcontext.cs : Adjust code accordingly.
30432 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30434 2001-11-07 Ravi Pratap <ravi@ximian.com>
30436 * expression.cs (EvalConstantExpression): Move into ecore.cs
30438 * enum.cs (Enum): Rename some members and make them public and readonly
30439 according to our convention.
30441 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30444 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30446 (Enum::Emit): Write a simple version for now which doesn't try to compute
30447 expressions. I shall modify this to be more robust in just a while.
30449 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30451 (TypeContainer::CloseType): Create the Enum types too.
30453 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30455 * expression.cs (EvalConstantExpression): Get rid of completely.
30457 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30458 user-defined values and other cases.
30460 (IsValidEnumLiteral): Helper function.
30462 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30463 out there in the case we had a literal FieldExpr.
30465 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30467 (Literalize): Revamp a bit to take two arguments.
30469 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30471 2001-11-06 Ravi Pratap <ravi@ximian.com>
30473 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30475 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30477 (Resolve): Use the above to ensure we have proper initializers.
30479 2001-11-05 Ravi Pratap <ravi@ximian.com>
30481 * expression.cs (Expression::EvalConstantExpression): New method to
30482 evaluate constant expressions.
30484 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30486 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30488 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30491 (Binary.ResolveOperator): Handle operator != (object a, object b)
30492 and operator == (object a, object b);
30494 (Binary.DoNumericPromotions): Indicate whether the numeric
30495 promotion was possible.
30497 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30500 Made the ArrayAccess implement interface IAssignMethod instead of
30501 IStackStore as the order in which arguments are passed reflects
30504 * assign.cs: Instead of using expr.ExprClass to select the way of
30505 assinging, probe for the IStackStore/IAssignMethod interfaces.
30507 * typemanager.cs: Load InitializeArray definition.
30509 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30510 static data that can be used to initialize arrays.
30512 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30514 * expression.cs: Handle operator== and operator!= for booleans.
30516 (Conditioal.Reduce): Implement reducer for the ?: operator.
30518 (Conditional.Resolve): Implement dead code elimination.
30520 (Binary.Resolve): Catch string literals and return a new
30521 concatenated string.
30523 (Unary.Reduce): Implement reduction of unary expressions.
30525 * ecore.cs: Split out the expression core handling here.
30527 (Expression.Reduce): New method used to perform constant folding
30528 and CSE. This is needed to support constant-expressions.
30530 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30531 targets, and optimize for !x.
30533 2001-11-04 Ravi Pratap <ravi@ximian.com>
30535 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30536 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30537 set custom atttributes.
30539 * literal.cs (Literal::GetValue): New abstract method to return the actual
30540 value of the literal, cast as an object.
30542 (*Literal): Implement GetValue method.
30544 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30545 expressions to the arraylist but objects of type Argument.
30547 * class.cs (TypeContainer::Emit): Emit our attributes too.
30549 (Method::Emit, Constructor::Emit): Ditto.
30551 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30552 to be ignoring earlier.
30554 2001-11-03 Ravi Pratap <ravi@ximian.com>
30556 * attribute.cs (AttributeSection::Define): Implement to do the business
30557 of constructing a CustomAttributeBuilder.
30559 (Attribute): New trivial class. Increases readability of code.
30561 * cs-parser.jay : Update accordingly.
30563 (positional_argument_list, named_argument_list, named_argument): New rules
30565 (attribute_arguments): Use the above so that we are more correct.
30567 2001-11-02 Ravi Pratap <ravi@ximian.com>
30569 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30570 to perform all checks for a method with a params parameter.
30572 (Invocation::OverloadResolve): Update to use the above method and therefore
30573 cope correctly with params method invocations.
30575 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30578 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30579 constructors in our parent too because we can't afford to miss out on
30582 * attribute.cs (AttributeSection): New name for the class Attribute
30584 Other trivial changes to improve readability.
30586 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30587 use the new class names.
30589 2001-11-01 Ravi Pratap <ravi@ximian.com>
30591 * class.cs (Method::Define): Complete definition for params types too
30593 (Indexer::Define): Ditto.
30595 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30596 Cope everywhere with a request for info about the array parameter.
30598 2001-11-01 Ravi Pratap <ravi@ximian.com>
30600 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30602 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30603 local_variable_type to extract the string corresponding to the type.
30605 (local_variable_type): Fixup the action to use the new helper method.
30607 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30610 * expression.cs : Clean out code which uses the above.
30612 2001-10-31 Ravi Pratap <ravi@ximian.com>
30614 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30615 and bale out if necessary by returning a false.
30617 (RegisterProperty): Ditto.
30619 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30620 and print out appropriate error messages.
30622 * interface.cs (everywhere): Ditto.
30624 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30625 location to constructor.
30627 * class.cs (Property, Event, Indexer): Update accordingly.
30629 * ../errors/cs111.cs : Added.
30631 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30632 of a method, as laid down by the spec.
30634 (Invocation::OverloadResolve): Use the above method.
30636 2001-10-31 Ravi Pratap <ravi@ximian.com>
30638 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30639 now take a TypeContainer and a Parameters object.
30641 (ParameterData): Modify return type of ParameterModifier method to be
30642 Parameter.Modifier and not a string.
30644 (ReflectionParameters, InternalParameters): Update accordingly.
30646 * expression.cs (Argument::GetParameterModifier): Same here.
30648 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30649 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30650 symbol in it at all so maybe this is only for now.
30652 2001-10-30 Ravi Pratap <ravi@ximian.com>
30654 * support.cs (InternalParameters): Constructor now takes an extra argument
30655 which is the actual Parameters class.
30657 (ParameterDesc): Update to provide info on ref/out modifiers.
30659 * class.cs (everywhere): Update call to InternalParameters to pass in
30660 the second argument too.
30662 * support.cs (ParameterData): Add ParameterModifier, which is a method
30663 to return the modifier info [ref/out etc]
30665 (InternalParameters, ReflectionParameters): Implement the above.
30667 * expression.cs (Argument::ParameterModifier): Similar function to return
30668 info about the argument's modifiers.
30670 (Invocation::OverloadResolve): Update to take into account matching modifiers
30673 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30674 a new SetFormalParameters object which we pass to InternalParameters.
30676 2001-10-30 Ravi Pratap <ravi@ximian.com>
30678 * expression.cs (NewArray): Merge into the ArrayCreation class.
30680 2001-10-29 Ravi Pratap <ravi@ximian.com>
30682 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30683 NewUserdefinedArray into one as there wasn't much of a use in having
30686 * expression.cs (Argument): Change field's name to ArgType from Type.
30688 (Type): New readonly property which returns the proper type, taking into
30689 account ref/out modifiers.
30691 (everywhere): Adjust code accordingly for the above.
30693 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30694 whether we are emitting for a ref or out parameter.
30696 * expression.cs (Argument::Emit): Use the above field to set the state.
30698 (LocalVariableReference::Emit): Update to honour the flag and emit the
30701 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30703 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30705 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30707 (ReflectionParameters, InternalParameters): Implement the above method.
30709 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30712 (Invocation::FullMethodDesc): Ditto.
30714 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30716 * cs-parser.jay: Add extra production for the second form of array
30719 * expression.cs (ArrayCreation): Update to reflect the above
30722 * Small changes to prepare for Array initialization.
30724 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30726 * typemanager.cs (ImplementsInterface): interface might be null;
30727 Deal with this problem;
30729 Also, we do store negative hits on the cache (null values), so use
30730 this instead of calling t.GetInterfaces on the type everytime.
30732 2001-10-28 Ravi Pratap <ravi@ximian.com>
30734 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30736 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30737 split functionality out into different classes.
30739 (New::FormArrayType): Move into NewBuiltinArray.
30741 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30744 (NewBuiltinArray): New class to handle creation of built-in arrays.
30746 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30747 account creation of one-dimensional arrays.
30749 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30751 (NewUserdefinedArray::DoResolve): Implement.
30753 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30755 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30756 we maintain inside the TypeManager. This is necessary to perform lookups on the
30759 (LookupType): Update to perform GetType on the module builders too.
30761 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30763 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30765 2001-10-23 Ravi Pratap <ravi@ximian.com>
30767 * expression.cs (New::DoResolve): Implement guts of array creation.
30769 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30771 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30773 * expression.cs: Fix bug I introduced lsat night that broke
30776 (Expression.Resolve): Report a 246 error (can not resolve name)
30777 if we find a SimpleName in the stream.
30779 (Expression.ResolveLValue): Ditto.
30781 (Expression.ResolveWithSimpleName): This function is a variant of
30782 ResolveName, this one allows SimpleNames to be returned without a
30783 warning. The only consumer of SimpleNames is MemberAccess
30785 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30787 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30788 might arrive here. I have my doubts that this is correct.
30790 * statement.cs (Lock): Implement lock statement.
30792 * cs-parser.jay: Small fixes to support `lock' and `using'
30794 * cs-tokenizer.cs: Remove extra space
30796 * driver.cs: New flag --checked, allows to turn on integer math
30799 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30800 Threading.Monitor.Exit
30802 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30804 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30805 Expression Class to be IndexerAccess.
30807 Notice that Indexer::DoResolve sets the eclass to Value.
30809 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30811 * class.cs (TypeContainer::Emit): Emit code for indexers.
30813 * assign.cs (IAssignMethod): New interface implemented by Indexers
30814 and Properties for handling assignment.
30816 (Assign::Emit): Simplify and reuse code.
30818 * expression.cs (IndexerAccess, PropertyExpr): Implement
30819 IAssignMethod, clean up old code.
30821 2001-10-22 Ravi Pratap <ravi@ximian.com>
30823 * typemanager.cs (ImplementsInterface): New method to determine if a type
30824 implements a given interface. Provides a nice cache too.
30826 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30829 (ConvertReferenceExplicit): Ditto.
30831 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30832 various methods, with correct names etc.
30834 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30835 Operator.UnaryNegation.
30837 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30838 we have a unary plus or minus operator.
30840 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30843 * everywhere : update accordingly.
30845 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30848 * class.cs (Method::Define): For the case where we are implementing a method
30849 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30850 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30852 2001-10-21 Ravi Pratap <ravi@ximian.com>
30854 * interface.cs (FindMembers): Implement to work around S.R.E
30857 * typemanager.cs (IsInterfaceType): Implement.
30859 (FindMembers): Update to handle interface types too.
30861 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30862 use IsAssignableFrom as that is not correct - it doesn't work.
30864 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30865 and accordingly override EmitStatement.
30867 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30868 using the correct logic :-)
30870 2001-10-19 Ravi Pratap <ravi@ximian.com>
30872 * ../errors/cs-11.cs : Add to demonstrate error -11
30874 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30876 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30877 then pass this as a hint to ResolveLValue.
30879 * expression.cs (FieldExpr): Add Location information
30881 (FieldExpr::LValueResolve): Report assignment to readonly
30884 (Expression::ExprClassFromMemberInfo): Pass location information.
30886 (Expression::ResolveLValue): Add new method that resolves an
30889 (Expression::DoResolveLValue): Default invocation calls
30892 (Indexers): New class used to keep track of indexers in a given
30895 (IStackStore): Renamed from LValue, as it did not really describe
30896 what this did. Also ResolveLValue is gone from this interface and
30897 now is part of Expression.
30899 (ElementAccess): Depending on the element access type
30901 * typemanager.cs: Add `indexer_name_type' as a Core type
30902 (System.Runtime.CompilerServices.IndexerNameAttribute)
30904 * statement.cs (Goto): Take a location.
30906 2001-10-18 Ravi Pratap <ravi@ximian.com>
30908 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30909 if two delegates are compatible.
30911 (NewDelegate::DoResolve): Update to take care of the case when
30912 we instantiate a delegate from another delegate.
30914 * typemanager.cs (FindMembers): Don't even try to look up members
30915 of Delegate types for now.
30917 2001-10-18 Ravi Pratap <ravi@ximian.com>
30919 * delegate.cs (NewDelegate): New class to take care of delegate
30922 * expression.cs (New): Split the delegate related code out into
30923 the NewDelegate class.
30925 * delegate.cs (DelegateInvocation): New class to handle delegate
30928 * expression.cs (Invocation): Split out delegate related code into
30929 the DelegateInvocation class.
30931 2001-10-17 Ravi Pratap <ravi@ximian.com>
30933 * expression.cs (New::DoResolve): Implement delegate creation fully
30934 and according to the spec.
30936 (New::DoEmit): Update to handle delegates differently.
30938 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30939 because of which we were printing out arguments in reverse order !
30941 * delegate.cs (VerifyMethod): Implement to check if the given method
30942 matches the delegate.
30944 (FullDelegateDesc): Implement.
30946 (VerifyApplicability): Implement.
30948 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30949 delegate invocations too.
30951 (Invocation::Emit): Ditto.
30953 * ../errors/cs1593.cs : Added.
30955 * ../errors/cs1594.cs : Added.
30957 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30959 2001-10-16 Ravi Pratap <ravi@ximian.com>
30961 * typemanager.cs (intptr_type): Core type for System.IntPtr
30963 (InitCoreTypes): Update for the same.
30965 (iasyncresult_type, asynccallback_type): Ditto.
30967 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30970 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30973 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30974 the builders for the 4 members of a delegate type :-)
30976 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30979 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30981 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30983 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30985 * statement.cs (Break::Emit): Implement.
30986 (Continue::Emit): Implement.
30988 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30989 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30990 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30991 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30994 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30995 properties that track the label for the current loop (begin of the
30996 loop and end of the loop).
30998 2001-10-15 Ravi Pratap <ravi@ximian.com>
31000 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31001 use of emitting anything at all.
31003 * class.cs, rootcontext.cs : Get rid of calls to the same.
31005 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31007 (Populate): Define the constructor correctly and set the implementation
31010 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31013 (AddDelegateType): Implement.
31015 (IsDelegateType): Implement helper method.
31017 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31019 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31020 and accordingly handle it.
31022 * delegate.cs (Populate): Take TypeContainer argument.
31023 Implement bits to define the Invoke method. However, I still haven't figured out
31024 how to take care of the native int bit :-(
31026 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31027 Qualify the name of the delegate, not its return type !
31029 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31032 (StandardConversionExists): Checking for array types turns out to be recursive.
31034 (ConvertReferenceExplicit): Implement array conversion.
31036 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31038 2001-10-12 Ravi Pratap <ravi@ximian.com>
31040 * cs-parser.jay (delegate_declaration): Store the fully qualified
31041 name as it is a type declaration.
31043 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31046 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31047 as TypeContainer::DefineType.
31049 (Populate): Method in which all the definition of the various methods (Invoke)
31052 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31055 (CloseDelegate): Finally creates the delegate.
31057 * class.cs (TypeContainer::DefineType): Update to define delegates.
31058 (Populate, Emit and CloseType): Do the same thing here too.
31060 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31061 delegates in all these operations.
31063 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31065 * expression.cs: LocalTemporary: a new expression used to
31066 reference a temporary that has been created.
31068 * assign.cs: Handle PropertyAccess back here, so that we can
31069 provide the proper semantic access to properties.
31071 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31072 a few more explicit conversions.
31074 * modifiers.cs: `NEW' modifier maps to HideBySig.
31076 * expression.cs (PropertyExpr): Make this into an
31077 ExpressionStatement, and support the EmitStatement code path.
31079 Perform get/set error checking, clean up the interface.
31081 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31082 them into toplevel access objects.
31084 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31086 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31089 * typemanager.cs: Keep track here of our PropertyBuilders again to
31090 work around lameness in SRE.
31092 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31094 * expression.cs (LValue::LValueResolve): New method in the
31095 interface, used to perform a second resolution pass for LValues.
31097 (This::DoResolve): Catch the use of this in static methods.
31099 (This::LValueResolve): Implement.
31101 (This::Store): Remove warning, assigning to `this' in structures
31104 (Invocation::Emit): Deal with invocation of
31105 methods on value types. We need to pass the address to structure
31106 methods rather than the object itself. (The equivalent code to
31107 emit "this" for structures leaves the entire structure on the
31108 stack instead of a pointer to it).
31110 (ParameterReference::DoResolve): Compute the real index for the
31111 argument based on whether the method takes or not a `this' pointer
31112 (ie, the method is static).
31114 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31115 value types returned from functions when we need to invoke a
31116 method on the sturcture.
31119 2001-10-11 Ravi Pratap <ravi@ximian.com>
31121 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31122 defining the type in the Modulebuilder or Typebuilder. This is to take
31123 care of nested types which need to be defined on the TypeBuilder using
31124 DefineNestedMethod.
31126 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31127 methods in RootContext, only ported to be part of TypeContainer.
31129 (TypeContainer::GetInterfaceOrClass): Ditto.
31131 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31133 * interface.cs (Interface::DefineInterface): New method. Does exactly
31134 what RootContext.CreateInterface did earlier, only it takes care of nested types
31137 (Interface::GetInterfaces): Move from RootContext here and port.
31139 (Interface::GetInterfaceByName): Same here.
31141 * rootcontext.cs (ResolveTree): Re-write.
31143 (PopulateTypes): Re-write.
31145 * class.cs (TypeContainer::Populate): Populate nested types too.
31146 (TypeContainer::Emit): Emit nested members too.
31148 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31149 instead just use the name argument passed in as it is already fully
31152 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31153 to TypeContainer mapping to see if a type is user-defined.
31155 * class.cs (TypeContainer::CloseType): Implement.
31157 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31158 the default constructor.
31160 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31163 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31165 * interface.cs (CloseType): Create the type here.
31167 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31170 Remove all the methods which are now in TypeContainer.
31172 2001-10-10 Ravi Pratap <ravi@ximian.com>
31174 * delegate.cs (Define): Re-write bits to define the delegate
31177 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31179 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31181 * expression.cs (ImplicitReferenceConversion): handle null as well
31182 as a source to convert to any reference type.
31184 * statement.cs (Return): Perform any implicit conversions to
31185 expected return type.
31187 Validate use of return statement.
31189 * codegen.cs (EmitContext): Pass the expected return type here.
31191 * class.cs (Method, Constructor, Property): Pass expected return
31192 type to EmitContext.
31194 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31196 * expression.cs: Make DoResolve take an EmitContext instead of a
31199 Replaced `l' and `location' for `loc', for consistency.
31201 (Error, Warning): Remove unneeded Tc argument.
31203 * assign.cs, literal.cs, constant.cs: Update to new calling
31206 * codegen.cs: EmitContext now contains a flag indicating whether
31207 code is being generated in a static method or not.
31209 * cs-parser.jay: DecomposeQI, new function that replaces the old
31210 QualifiedIdentifier. Now we always decompose the assembled
31211 strings from qualified_identifier productions into a group of
31214 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31216 * rootcontext.cs: Deal with field-less struct types correctly now
31217 by passing the size option to Define Type.
31219 * class.cs: Removed hack that created one static field.
31221 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31223 * statement.cs: Moved most of the code generation here.
31225 2001-10-09 Ravi Pratap <ravi@ximian.com>
31227 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31230 (ElementAccess): Remove useless bits for now - keep checks as the spec
31233 2001-10-08 Ravi Pratap <ravi@ximian.com>
31235 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31236 and start performing checks according to the spec.
31238 2001-10-07 Ravi Pratap <ravi@ximian.com>
31240 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31241 rank_specifiers instead.
31243 (rank_specifiers): Change the order in which the rank specifiers are stored
31245 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31247 * expression.cs (ElementAccess): Implement the LValue interface too.
31249 2001-10-06 Ravi Pratap <ravi@ximian.com>
31251 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31252 except that user defined conversions are not included.
31254 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31255 perform the conversion of the return type, if necessary.
31257 (New::DoResolve): Check whether we are creating an array or an object
31258 and accordingly do the needful.
31260 (New::Emit): Same here.
31262 (New::DoResolve): Implement guts of array creation.
31264 (New::FormLookupType): Helper function.
31266 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31268 * codegen.cs: Removed most of the code generation here, and move the
31269 corresponding code generation bits to the statement classes.
31271 Added support for try/catch/finalize and throw.
31273 * cs-parser.jay: Added support for try/catch/finalize.
31275 * class.cs: Catch static methods having the flags override,
31276 virtual or abstract.
31278 * expression.cs (UserCast): This user cast was not really doing
31279 what it was supposed to do. Which is to be born in fully resolved
31280 state. Parts of the resolution were being performed at Emit time!
31284 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31286 * expression.cs: Implicity convert the result from UserCast.
31288 2001-10-05 Ravi Pratap <ravi@ximian.com>
31290 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31291 prevented it from working correctly.
31293 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31294 merely ConvertImplicit.
31296 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31298 * typemanager.cs: Make the LookupTypeContainer function static,
31299 and not per-instance.
31301 * class.cs: Make static FindMembers (the one that takes a Type
31304 * codegen.cs: Add EmitForeach here.
31306 * cs-parser.jay: Make foreach a toplevel object instead of the
31307 inline expansion, as we need to perform semantic analysis on it.
31309 2001-10-05 Ravi Pratap <ravi@ximian.com>
31311 * expression.cs (Expression::ImplicitUserConversion): Rename to
31312 UserDefinedConversion.
31314 (Expression::UserDefinedConversion): Take an extra argument specifying
31315 whether we look for explicit user conversions too.
31317 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31319 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31321 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31322 with the appropriate arguments.
31324 * cs-parser.jay (cast_expression): Record location too.
31326 * expression.cs (Cast): Record location info.
31328 (Expression::ConvertExplicit): Take location argument.
31330 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31331 to determine if we are doing explicit conversions.
31333 (UserCast::Emit): Update accordingly.
31335 (Expression::ConvertExplicit): Report an error if everything fails.
31337 * ../errors/cs0030.cs : Add.
31339 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31341 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31342 virtual and newslot bits.
31344 * class.cs (TypeContainer::RegisterRequiredImplementations):
31345 Record methods we need.
31347 (TypeContainer::MakeKey): Helper function to make keys for
31348 MethodBases, since the Methodbase key is useless.
31350 (TypeContainer::Populate): Call RegisterRequiredImplementations
31351 before defining the methods.
31353 Create a mapping for method_builders_to_methods ahead of time
31354 instead of inside a tight loop.
31356 (::RequireMethods): Accept an object as the data to set into the
31357 hashtable so we can report interface vs abstract method mismatch.
31359 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31361 * report.cs: Make all of it static.
31363 * rootcontext.cs: Drop object_type and value_type computations, as
31364 we have those in the TypeManager anyways.
31366 Drop report instance variable too, now it is a global.
31368 * driver.cs: Use try/catch on command line handling.
31370 Add --probe option to debug the error reporting system with a test
31373 * report.cs: Add support for exiting program when a probe
31374 condition is reached.
31376 2001-10-03 Ravi Pratap <ravi@ximian.com>
31378 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31379 we do a forcible conversion regardless of type, to check if
31380 ForceConversion returns a null.
31382 (Binary::error19): Use location to report error.
31384 (Unary::error23): Use location here too.
31386 * ../errors/cs0019.cs : Check in.
31388 * ../errors/cs0023.cs : Check in.
31390 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31391 case of a non-null MethodInfo object with a length of 0 !
31393 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31394 an applicable member - according to the spec :-)
31395 Also fix logic to find members in base types.
31397 (Unary::ResolveOperator): Same here.
31399 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31400 as I was getting thoroughly confused between this and error19 :-)
31402 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31403 (::FindMostEncompassedType): Implement.
31404 (::FindMostEncompassingType): Implement.
31405 (::StandardConversionExists): Implement.
31407 (UserImplicitCast): Re-vamp. We now need info about most specific
31408 source and target types so that we can do the necessary conversions.
31410 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31411 mathematical union with no duplicates.
31413 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31415 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31416 in order from base classes to child classes, so that we can in
31417 child classes look up in our parent for method names and
31418 attributes (required for handling abstract, virtual, new, override
31419 constructs: we need to instrospect our base class, and if we dont
31420 populate the classes in order, the introspection might be
31421 incorrect. For example, a method could query its parent before
31422 the parent has any methods and would determine that the parent has
31423 no abstract methods (while it could have had them)).
31425 (RootContext::CreateType): Record the order in which we define the
31428 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31430 * class.cs (TypeContainer::Populate): Also method definitions can
31431 fail now, keep track of this.
31433 (TypeContainer::FindMembers): Implement support for
31434 DeclaredOnly/noDeclaredOnly flag.
31436 (Constructor::Emit) Return the ConstructorBuilder.
31438 (Method::Emit) Return the MethodBuilder.
31439 Check for abstract or virtual methods to be public.
31441 * rootcontext.cs (RootContext::CreateType): Register all the
31442 abstract methods required for the class to be complete and the
31443 interface methods that must be implemented.
31445 * cs-parser.jay: Report error 501 (method requires body if it is
31446 not marked abstract or extern).
31448 * expression.cs (TypeOf::Emit): Implement.
31450 * typemanager.cs: runtime_handle_type, new global type.
31452 * class.cs (Property::Emit): Generate code for properties.
31454 2001-10-02 Ravi Pratap <ravi@ximian.com>
31456 * expression.cs (Unary::ResolveOperator): Find operators on base type
31457 too - we now conform exactly to the spec.
31459 (Binary::ResolveOperator): Same here.
31461 * class.cs (Operator::Define): Fix minor quirk in the tests.
31463 * ../errors/cs0215.cs : Added.
31465 * ../errors/cs0556.cs : Added.
31467 * ../errors/cs0555.cs : Added.
31469 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31471 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31472 single integer which is really efficient
31474 2001-10-01 Ravi Pratap <ravi@ximian.com>
31476 * expression.cs (Expression::ImplicitUserConversion): Use location
31477 even in the case when we are examining True operators.
31479 * class.cs (Operator::Define): Perform extensive checks to conform
31480 with the rules for operator overloading in the spec.
31482 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31483 some of the other conversions mentioned in the spec.
31485 * typemanager.cs (array_type): New static member for the System.Array built-in
31488 (cloneable_interface): For System.ICloneable interface.
31490 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31491 we start resolving the tree and populating types.
31493 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31495 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31497 * expression.cs (Expression::ExprClassFromMemberInfo,
31498 Expression::Literalize): Create literal expressions from
31499 FieldInfos which are literals.
31501 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31502 type casts, because they were wrong. The test suite in tests
31505 (ImplicitNumericConversion): ushort to ulong requires a widening
31508 Int32 constant to long requires widening cast as well.
31510 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31511 for integers because the type on the stack is not i4.
31513 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31515 * expression.cs (report118): require location argument.
31517 * parameter.cs: Do not dereference potential null value.
31519 * class.cs: Catch methods that lack the `new' keyword when
31520 overriding a name. Report warnings when `new' is used without
31521 anything being there to override.
31523 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31525 * class.cs: Only add constructor to hashtable if it is non-null
31526 (as now constructors can fail on define).
31528 (TypeManager, Class, Struct): Take location arguments.
31530 Catch field instance initialization in structs as errors.
31532 accepting_filter: a new filter for FindMembers that is static so
31533 that we dont create an instance per invocation.
31535 (Constructor::Define): Catch errors where a struct constructor is
31538 * cs-parser.jay: Pass location information for various new
31541 * delegate.cs (Delegate): take a location argument.
31543 * driver.cs: Do not call EmitCode if there were problesm in the
31544 Definition of the types, as many Builders wont be there.
31546 * decl.cs (Decl::Decl): Require a location argument.
31548 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31549 into integers, and find the most appropiate integer for it.
31551 * literal.cs: Implement ULongLiteral.
31553 * rootcontext.cs: Provide better information about the location of
31554 failure when CreateType fails.
31556 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31558 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31561 * expression.cs (Binary::CheckShiftArguments): Add missing type
31563 (Binary::ResolveOperator): Add type to the logical and and logical
31564 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31567 (Binary::DoNumericPromotions): In the case where either argument
31568 is ulong (and most signed types combined with ulong cause an
31569 error) perform implicit integer constant conversions as well.
31571 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31573 * expression.cs (UserImplicitCast): Method should always be
31575 (Invocation::BetterConversion): Simplified test for IntLiteral.
31577 (Expression::ImplicitNumericConversion): Split this routine out.
31578 Put the code that performs implicit constant integer conversions
31581 (Expression::Resolve): Become a wrapper around DoResolve so we can
31582 check eclass and type being set after resolve.
31584 (Invocation::Badness): Remove this dead function
31586 (Binary::ResolveOperator): Do not compute the expensive argumnets
31587 unless we have a union for it.
31589 (Probe::Emit): Is needs to do an isinst and then
31590 compare against null.
31592 (::CanConvert): Added Location argument. If the Location argument
31593 is null (Location.Null), then we do not report errors. This is
31594 used by the `probe' mechanism of the Explicit conversion. We do
31595 not want to generate an error for something that the user
31596 explicitly requested to be casted. But the pipeline for an
31597 explicit cast first tests for potential implicit casts.
31599 So for now, if the Location is null, it means `Probe only' to
31600 avoid adding another argument. Might have to revise this
31603 (ClassCast): New class used to type cast objects into arbitrary
31604 classes (used in Explicit Reference Conversions).
31606 Implement `as' as well.
31608 Reverted all the patches from Ravi below: they were broken:
31610 * The use of `level' as a mechanism to stop recursive
31611 invocations is wrong. That was there just to catch the
31612 bug with a strack trace but not as a way of addressing
31615 To fix the problem we have to *understand* what is going
31616 on and the interactions and come up with a plan, not
31617 just get things going.
31619 * The use of the type conversion cache that I proposed
31620 last night had an open topic: How does this work across
31621 protection domains. A user defined conversion might not
31622 be public in the location where we are applying the
31623 conversion, a different conversion might be selected
31624 (ie, private A->B (better) but public B->A (worse),
31625 inside A, A->B applies, but outside it, B->A will
31628 * On top of that (ie, even if the above is solved),
31629 conversions in a cache need to be abstract. Ie, `To
31630 convert from an Int to a Short use an OpcodeCast', not
31631 `To convert from an Int to a Short use the OpcodeCast on
31632 the variable 5' (which is what this patch was doing).
31634 2001-09-28 Ravi Pratap <ravi@ximian.com>
31636 * expression.cs (Invocation::ConversionExists): Re-write to use
31637 the conversion cache
31639 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31640 cache all conversions done, not just user-defined ones.
31642 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31643 to determine if a conversion exists instead of acutually trying to
31644 perform the conversion. It's faster too.
31646 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31647 and only then attempt the implicit conversion.
31649 2001-09-28 Ravi Pratap <ravi@ximian.com>
31651 * expression.cs (ConvertImplicit): Use a cache for conversions
31652 already found. Check level of recursion and bail out if necessary.
31654 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31656 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31657 Export standard methods that we expect for string operations.
31659 * statement.cs (Block::UsageWarning): Track usage of variables and
31660 report the errors for not used variables.
31662 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31665 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31667 * codegen.cs: remove unnneded code
31669 * expression.cs: Removed BuiltinTypeAccess class
31671 Fix the order in which implicit conversions are
31674 The previous fixed dropped support for boxed conversions (adding a
31675 test to the test suite now)
31677 (UserImplicitCast::CanConvert): Remove test for source being null,
31678 that code is broken. We should not feed a null to begin with, if
31679 we do, then we should track the bug where the problem originates
31680 and not try to cover it up here.
31682 Return a resolved expression of type UserImplicitCast on success
31683 rather than true/false. Ravi: this is what I was talking about,
31684 the pattern is to use a static method as a "constructor" for
31687 Also, do not create arguments until the very last minute,
31688 otherwise we always create the arguments even for lookups that
31689 will never be performed.
31691 (UserImplicitCast::Resolve): Eliminate, objects of type
31692 UserImplicitCast are born in a fully resolved state.
31694 * typemanager.cs (InitCoreTypes): Init also value_type
31695 (System.ValueType).
31697 * expression.cs (Cast::Resolve): First resolve the child expression.
31699 (LValue): Add new method AddressOf to be used by
31702 Change the argument of Store to take an EmitContext instead of an
31703 ILGenerator, because things like FieldExpr need to be able to call
31704 their children expression to generate the instance code.
31706 (Expression::Error, Expression::Warning): Sugar functions for
31709 (Expression::MemberLookup): Accept a TypeContainer instead of a
31710 Report as the first argument.
31712 (Expression::ResolvePrimary): Killed. I still want to improve
31713 this as currently the code is just not right.
31715 (Expression::ResolveMemberAccess): Simplify, but it is still
31718 (Unary::Resolve): Catch errors in AddressOf operators.
31720 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31721 index to a byte for the short-version, or the compiler will choose
31722 the wrong Emit call, which generates the wrong data.
31724 (ParameterReference::Emit, ::Store): same.
31726 (FieldExpr::AddressOf): Implement.
31728 * typemanager.cs: TypeManager: made public variable instead of
31731 * driver.cs: document --fatal.
31733 * report.cs (ErrorMessage, WarningMessage): new names for the old
31734 Error and Warning classes.
31736 * cs-parser.jay (member_access): Turn built-in access to types
31737 into a normal simplename
31739 2001-09-27 Ravi Pratap <ravi@ximian.com>
31741 * expression.cs (Invocation::BetterConversion): Fix to cope
31742 with q being null, since this was introducing a bug.
31744 * expression.cs (ConvertImplicit): Do built-in conversions first.
31746 2001-09-27 Ravi Pratap <ravi@ximian.com>
31748 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31750 2001-09-27 Ravi Pratap <ravi@ximian.com>
31752 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31753 I had introduced long ago (what's new ?).
31755 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31756 the work of all the checking.
31757 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31758 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31760 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31761 that is the right way.
31763 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31764 overloading resolution. Use everywhere instead of cutting and pasting code.
31766 (Binary::ResolveOperator): Use MakeUnionSet.
31768 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31769 we have to convert to bool types. Not complete yet.
31771 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31773 * typemanager.cs (TypeManager::CSharpName): support ushort.
31775 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31776 to provide an expression that performsn an implicit constant int
31777 conversion (section 6.1.6).
31778 (Expression::ConvertImplicitRequired): Reworked to include
31779 implicit constant expression conversions.
31781 (Expression::ConvertNumericExplicit): Finished.
31783 (Invocation::Emit): If InstanceExpression is null, then it means
31784 that we perform a call on this.
31786 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31788 * expression.cs (Unary::Emit): Remove some dead code.
31789 (Probe): Implement Resolve and Emit for `is'.
31790 (Expression::ConvertImplicitRequired): Attempt to do constant
31791 expression conversions here. Maybe should be moved to
31792 ConvertImplicit, but I am not sure.
31793 (Expression::ImplicitLongConstantConversionPossible,
31794 Expression::ImplicitIntConstantConversionPossible): New functions
31795 that tell whether is it possible to apply an implicit constant
31796 expression conversion.
31798 (ConvertNumericExplicit): Started work on explicit numeric
31801 * cs-parser.jay: Update operator constants.
31803 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31804 (Parameters::GetSignature): Hook up VerifyArgs here.
31805 (Parameters::VerifyArgs): Verifies that no two arguments have the
31808 * class.cs (Operator): Update the operator names to reflect the
31809 ones that the spec expects (as we are just stringizing the
31812 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31813 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31814 previous usage did only work for our methods.
31815 (Expression::ConvertImplicit): Handle decimal implicit numeric
31816 conversions as well.
31817 (Expression::InternalTypeConstructor): Used to invoke constructors
31818 on internal types for default promotions.
31820 (Unary::Emit): Implement special handling for the pre/post
31821 increment/decrement for overloaded operators, as they need to have
31822 the same semantics as the other operators.
31824 (Binary::ResolveOperator): ditto.
31825 (Invocation::ConversionExists): ditto.
31826 (UserImplicitCast::Resolve): ditto.
31828 2001-09-26 Ravi Pratap <ravi@ximian.com>
31830 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31831 operator, return after emitting body. Regression tests pass again !
31833 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31834 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31835 (Invocation::OverloadResolve): Ditto.
31836 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31838 * everywhere : update calls to the above methods accordingly.
31840 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31842 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31844 * expression.cs (ExpressionStatement): New base class used for
31845 expressions that can appear in statements, so that we can provide
31846 an alternate path to generate expression that do not leave a value
31849 (Expression::Emit, and all the derivatives): We no longer return
31850 whether a value is left on the stack or not. Every expression
31851 after being emitted leaves a single value on the stack.
31853 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31854 facilties of ExpressionStatement if possible.
31856 * cs-parser.jay: Update statement_expression.
31858 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31860 * driver.cs: Change the wording of message
31862 2001-09-25 Ravi Pratap <ravi@ximian.com>
31864 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31865 the type of the expression to the return type of the method if
31866 we have an overloaded operator match ! The regression tests pass again !
31867 (Unary::ResolveOperator): Ditto.
31869 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31870 to find "op_Implicit", not "implicit" ;-)
31871 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31872 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31874 * everywhere : Correct calls to the above accordingly.
31876 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31877 (ConvertImplicit): Do user-defined conversion if it exists.
31879 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31881 * assign.cs: track location.
31882 (Resolve): Use implicit conversions on assignment.
31884 * literal.cs: Oops. Not good, Emit of short access values should
31885 pass (Bytes) or the wrong argument will be selected.
31887 * expression.cs (Unary::Emit): Emit code for -expr.
31889 (Unary::ResolveOperator): Handle `Substract' for non-constants
31890 (substract from zero from the non-constants).
31891 Deal with Doubles as well.
31893 (Expression::ConvertImplicitRequired): New routine that reports an
31894 error if no implicit conversion exists.
31896 (Invocation::OverloadResolve): Store the converted implicit
31897 expressions if we make them
31899 2001-09-24 Ravi Pratap <ravi@ximian.com>
31901 * class.cs (ConstructorInitializer): Take a Location argument.
31902 (ConstructorBaseInitializer): Same here.
31903 (ConstructorThisInitializer): Same here.
31905 * cs-parser.jay : Update all calls accordingly.
31907 * expression.cs (Unary, Binary, New): Take location argument.
31908 Update accordingly everywhere.
31910 * cs-parser.jay : Update all calls to the above to take a location
31913 * class.cs : Ditto.
31915 2001-09-24 Ravi Pratap <ravi@ximian.com>
31917 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31918 (Invocation::BetterConversion): Same here
31919 (Invocation::ConversionExists): Ditto.
31921 (Invocation::ConversionExists): Implement.
31923 2001-09-22 Ravi Pratap <ravi@ximian.com>
31925 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31926 Also take an additional TypeContainer argument.
31928 * All over : Pass in TypeContainer as argument to OverloadResolve.
31930 * typemanager.cs (CSharpName): Update to check for the string type and return
31933 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31936 2001-09-21 Ravi Pratap <ravi@ximian.com>
31938 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31939 (Invocation::BetterFunction): Implement.
31940 (Invocation::BetterConversion): Implement.
31941 (Invocation::ConversionExists): Skeleton, no implementation yet.
31943 Okay, things work fine !
31945 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31947 * typemanager.cs: declare and load enum_type, delegate_type and
31950 * expression.cs (Expression::Emit): Now emit returns a value that
31951 tells whether a value is left on the stack or not. This strategy
31952 might be reveted tomorrow with a mechanism that would address
31953 multiple assignments.
31954 (Expression::report118): Utility routine to report mismatches on
31957 (Unary::Report23): Report impossible type/operator combination
31960 (Unary::IsIncrementableNumber): Whether the type can be
31961 incremented or decremented with add.
31962 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31964 (Unary::ResolveOperator): Implement ++, !, ~,
31966 (Invocation::Emit): Deal with new Emit convetion.
31968 * All Expression derivatives: Updated their Emit method to return
31969 whether they leave values on the stack or not.
31971 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31972 stack for expressions that are statements.
31974 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31976 * expression.cs (LValue): New interface. Must be implemented by
31978 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31981 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31982 interface for generating code, simplifies the code.
31984 2001-09-20 Ravi Pratap <ravi@ximian.com>
31986 * expression.cs (everywhere): Comment out return statements in ::Resolve
31987 methods to avoid the warnings.
31989 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31991 * driver.cs (parse): Report error 2001 if we can not open the
31994 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31997 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32000 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32001 otherwise nested blocks end up with the same index.
32003 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32005 * expression.cs: Instead of having FIXMEs in the Resolve
32006 functions, throw exceptions so it is obvious that we are facing a
32009 * cs-parser.jay (invocation_expression): Pass Location information.
32011 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32012 Use a basename for those routines because .NET does not like paths
32015 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32018 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32020 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32021 are loading the correct data types (throws an exception if not).
32022 (TypeManager::InitCoreTypes): Use CoreLookupType
32024 * expression.cs (Unary::ResolveOperator): return the child
32025 expression for expressions which are just +expr.
32026 (Unary::ResolveOperator): Return negative literals for -LITERAL
32027 expressions (otherwise they are Unary {Literal}).
32028 (Invocation::Badness): Take into account `Implicit constant
32029 expression conversions'.
32031 * literal.cs (LongLiteral): Implement long literal class.
32032 (IntLiteral): export the `Value' of the intliteral.
32034 2001-09-19 Ravi Pratap <ravi@ximian.com>
32036 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32038 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32039 instead of 'Operator'
32041 * expression.cs (Binary::ResolveOperator): Update accordingly.
32042 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32045 * cs-parser.jay (unary_expression): Update to use the new names.
32047 * gen-treedump.cs (GetUnary): Same here.
32049 * expression.cs (Unary::Resolve): Implement.
32050 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32051 operators are found instead of making noise ;-)
32052 (Unary::ResolveOperator): New method to do precisely the same thing which
32053 Binary::ResolveOperator does for Binary expressions.
32054 (Unary.method, .Arguments): Add.
32055 (Unary::OperName): Implement.
32056 (Unary::ForceConversion): Copy and Paste !
32058 * class.cs (Operator::Define): Fix a small bug for the case when we have
32061 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32062 for the inbuilt operators. Only overloading works for now ;-)
32064 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32066 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32067 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32069 * expression.cs (This::Emit): Implement.
32070 (This::Resolve): Implement.
32071 (TypeOf:Resolve): Implement.
32072 (Expression::ResolveSimpleName): Add an implicit this to instance
32074 (MemberAccess::Resolve): Deal with Parameters and Fields.
32075 Bind instance variable to Field expressions.
32076 (FieldExpr::Instance): New field used to track the expression that
32077 represents the object instance.
32078 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32080 (FieldExpr::Emit): Implement.
32082 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32083 the last instruction contains a return opcode to avoid generating
32084 the last `ret' instruction (this generates correct code, and it is
32085 nice to pass the peverify output).
32087 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32088 initializer for static and instance variables.
32089 (Constructor::Emit): Allow initializer to be null in the case of
32090 static constructors. Only emit initializer for instance
32093 (TypeContainer::FindMembers): Return a null array if there are no
32096 Also fix the code for the MemberTypes.Method branch, as it was not
32097 scanning that for operators (or tried to access null variables before).
32099 * assign.cs (Assign::Emit): Handle instance and static fields.
32103 * driver.cs: Stop compilation if there are parse errors.
32105 * cs-parser.jay (constructor_declaration): Provide default base
32106 initializer for non-static constructors.
32107 (constructor_declarator): Do not provide a default base
32108 initializers if none was specified.
32109 Catch the fact that constructors should not have parameters.
32111 * class.cs: Do not emit parent class initializers for static
32112 constructors, that should be flagged as an error.
32114 2001-09-18 Ravi Pratap <ravi@ximian.com>
32116 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32117 Move back code into TypeContainer::Populate.
32119 2001-09-18 Ravi Pratap <ravi@ximian.com>
32121 * class.cs (TypeContainer::AddConstructor): Fix the check to
32122 compare against Name, not Basename.
32123 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32125 * cs-parser.jay : Update accordingly.
32127 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32128 for methods, don't forget to look into the operators too.
32129 (RegisterMethodBuilder): Helper method to take care of this for
32130 methods, constructors and operators.
32131 (Operator::Define): Completely revamp.
32132 (Operator.OperatorMethod, MethodName): New fields.
32133 (TypeContainer::Populate): Move the registering of builders into
32134 RegisterMethodBuilder.
32135 (Operator::Emit): Re-write.
32137 * expression.cs (Binary::Emit): Comment out code path to emit method
32138 invocation stuff for the case when we have a user defined operator. I am
32139 just not able to get it right !
32141 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32143 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32146 (Expression::MemberLookup): Provide a version that allows to
32147 specify the MemberTypes and BindingFlags.
32149 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32150 so it was not fetching variable information from outer blocks.
32152 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32153 Beforefieldinit as it was buggy.
32155 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32156 that Ravi put here.
32158 * class.cs (Constructor::Emit): Only emit if block is not null.
32159 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32160 deal with this by semantically definining it as if the user had
32163 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32164 constructors as we now "emit" them at a higher level.
32166 (TypeContainer::DefineDefaultConstructor): Used to define the
32167 default constructors if none was provided.
32169 (ConstructorInitializer): Add methods Resolve and Emit.
32171 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32173 2001-09-17 Ravi Pratap <ravi@ximian.com>
32175 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32176 the default constructor builder with our hashtable for methodbuilders
32179 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32180 and argument_count is 0 in which case we have a match.
32181 (Binary::ResolveOperator): More null checking and miscellaneous coding
32184 2001-09-17 Ravi Pratap <ravi@ximian.com>
32186 * rootcontext.cs (IsNameSpace): Compare against null.
32188 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32190 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32191 and Unary::Operator.
32193 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32196 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32197 we have overloaded operators.
32198 (Binary::ResolveOperator): Implement the part which does the operator overload
32201 * class.cs (Operator::Emit): Implement.
32202 (TypeContainer::Emit): Emit the operators we have too.
32204 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32205 the case when we have a user-defined operator.
32207 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32209 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32211 2001-09-16 Ravi Pratap <ravi@ximian.com>
32213 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32214 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32215 (Constructor::Emit): Implement.
32216 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32217 if we have no work to do.
32218 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32221 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32222 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32224 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32227 2001-09-15 Ravi Pratap <ravi@ximian.com>
32229 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32231 (Tree::RecordNamespace): Method to do what the name says ;-)
32232 (Tree::Namespaces): Property to get at the namespaces hashtable.
32234 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32237 * rootcontext.cs (IsNamespace): Fixed it :-)
32239 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32241 * class.cs (TypeContainer::FindMembers): Add support for
32243 (MethodCore): New class that encapsulates both the shared aspects
32244 of a Constructor and a Method.
32245 (Method, Constructor): Factored pieces into MethodCore.
32247 * driver.cs: Added --fatal which makes errors throw exceptions.
32248 Load System assembly as well as part of the standard library.
32250 * report.cs: Allow throwing exceptions on errors for debugging.
32252 * modifiers.cs: Do not use `parent', instead use the real type
32253 container to evaluate permission settings.
32255 * class.cs: Put Ravi's patch back in. He is right, and we will
32256 have to cope with the
32258 2001-09-14 Ravi Pratap <ravi@ximian.com>
32260 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32261 FamORAssem, not FamANDAssem.
32263 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32265 * driver.cs: Added --parse option that only parses its input files
32268 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32269 incorrect. IsTopLevel is not used to tell whether an object is
32270 root_types or not (that can be achieved by testing this ==
32271 root_types). But to see if this is a top-level *class* (not
32272 necessarly our "toplevel" container).
32274 2001-09-14 Ravi Pratap <ravi@ximian.com>
32276 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32277 parent instead of a direct call to GetType.
32279 2001-09-14 Ravi Pratap <ravi@ximian.com>
32281 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32282 Modifiers.TypeAttr. This should just be a call to that method.
32284 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32285 object so that we can determine if we are top-level or not.
32287 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32290 * enum.cs (Enum::Define): Ditto.
32292 * modifiers.cs (FieldAttr): Re-write.
32294 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32295 (TypeContainer::HaveStaticConstructor): New property to provide access
32296 to precisely that info.
32298 * modifiers.cs (MethodAttr): Re-write.
32299 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32301 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32302 of top-level types as claimed.
32304 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32306 * expression.cs (MemberLookup): Fruitless attempt to lookup
32307 constructors. Maybe I need to emit default constructors? That
32308 might be it (currently .NET emits this for me automatically).
32309 (Invocation::OverloadResolve): Cope with Arguments == null.
32310 (Invocation::EmitArguments): new function, shared by the new
32311 constructor and us.
32312 (Invocation::Emit): Handle static and instance methods. Emit
32313 proper call instruction for virtual or non-virtual invocations.
32314 (New::Emit): Implement.
32315 (New::Resolve): Implement.
32316 (MemberAccess:Resolve): Implement.
32317 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32318 to track instances.
32319 (FieldExpr::Resolve): Set type.
32321 * support.cs: Handle empty arguments.
32323 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32324 SimpleLookup): Auxiliary routines to help parse a qualifier
32327 Update qualifier_identifier rule.
32329 * codegen.cs: Removed debugging messages.
32331 * class.cs: Make this a global thing, this acts just as a "key" to
32332 objects that we might have around.
32334 (Populate): Only initialize method_builders_to_methods once.
32336 * expression.cs (PropertyExpr): Initialize type from the
32339 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32340 Resolve pattern. Attempt to implicitly convert value to boolean.
32343 * expression.cs: Set the type for the int32/int32 argument case.
32344 (Binary::ResolveOperator): Set the return type to boolean for
32345 comparission operators
32347 * typemanager.cs: Remove debugging print code.
32349 (Invocation::Resolve): resolve type.
32351 * class.cs: Allocate a MemberInfo of the correct size, as the code
32352 elsewhere depends on the test to reflect the correct contents.
32354 (Method::) Keep track of parameters, due to System.Reflection holes
32356 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32359 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32360 of the exact size and return that.
32362 (Class::LookupMethodByBuilder): New function that maps
32363 MethodBuilders to its methods. Required to locate the information
32364 on methods because System.Reflection bit us again.
32366 * support.cs: New file, contains an interface ParameterData and
32367 two implementations: ReflectionParameters and InternalParameters
32368 used to access Parameter information. We will need to grow this
32371 * expression.cs (Invocation::GetParameterData): implement a cache
32372 and a wrapper around the ParameterData creation for methods.
32373 (Invocation::OverloadResolve): Use new code.
32375 2001-09-13 Ravi Pratap <ravi@ximian.com>
32377 * class.cs (TypeContainer::EmitField): Remove and move into
32378 (Field::Define): here and modify accordingly.
32379 (Field.FieldBuilder): New member.
32380 (TypeContainer::Populate): Update accordingly.
32381 (TypeContainer::FindMembers): Implement.
32383 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32385 * statement.cs: (VariableInfo::VariableType): New field to be
32386 initialized with the full type once it is resolved.
32388 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32390 * parameter.cs (GetParameterInfo): Use a type cache to compute
32391 things only once, and to reuse this information
32393 * expression.cs (LocalVariableReference::Emit): Implement.
32394 (OpcodeCast::Emit): fix.
32396 (ParameterReference::Resolve): Implement.
32397 (ParameterReference::Emit): Implement.
32399 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32400 that are expressions need to stay as Expressions.
32402 * typemanager.cs (CSharpName): Returns the C# name of a type if
32405 * expression.cs (Expression::ConvertImplicit): New function that
32406 implements implicit type conversions.
32408 (Expression::ImplicitReferenceConversion): Implements implicit
32409 reference conversions.
32411 (EmptyCast): New type for transparent casts.
32413 (OpcodeCast): New type for casts of types that are performed with
32414 a sequence of bytecodes.
32416 (BoxedCast): New type used for casting value types into reference
32417 types. Emits a box opcode.
32419 (Binary::DoNumericPromotions): Implements numeric promotions of
32420 and computation of the Binary::Type.
32422 (Binary::EmitBranchable): Optimization.
32424 (Binary::Emit): Implement code emission for expressions.
32426 * typemanager.cs (TypeManager): Added two new core types: sbyte
32429 2001-09-12 Ravi Pratap <ravi@ximian.com>
32431 * class.cs (TypeContainer::FindMembers): Method which does exactly
32432 what Type.FindMembers does, only we don't have to use reflection. No
32433 implementation yet.
32435 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32436 typecontainer objects as we need to get at them.
32437 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32439 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32440 typecontainer object.
32442 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32443 of just a Report object.
32445 2001-09-11 Ravi Pratap <ravi@ximian.com>
32447 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32449 (TypeContainer::Populate): Now define the delegates of the type too.
32450 (TypeContainer.Delegates): Property to access the list of delegates defined
32453 * delegates.cs (Delegate::Define): Implement partially.
32455 * modifiers.cs (TypeAttr): Handle more flags.
32457 2001-09-11 Ravi Pratap <ravi@ximian.com>
32459 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32461 (Operator::Define): Re-write logic to get types by using the LookupType method
32462 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32463 (Indexer::Define): Ditto.
32464 (Event::Define): Ditto.
32465 (Property::Define): Ditto.
32467 2001-09-10 Ravi Pratap <ravi@ximian.com>
32469 * class.cs (TypeContainer::Populate): Now define operators too.
32470 (TypeContainer.Operators): New property to access the list of operators
32472 (Operator.OperatorMethodBuilder): New member to hold the method builder
32473 for the operator we are defining.
32474 (Operator::Define): Implement.
32476 2001-09-10 Ravi Pratap <ravi@ximian.com>
32478 * class.cs (Event::Define): Make the prefixes of the accessor methods
32479 addOn_ and removeOn_
32481 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32482 of the location being passed in too. Ideally, this should go later since all
32483 error reporting should be done through the Report object.
32485 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32486 (Populate): Iterate thru the indexers we have and define them too.
32487 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32488 for the get and set accessors.
32489 (Indexer::Define): Implement.
32491 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32493 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32494 my previous implementation, did not work.
32496 * typemanager.cs: Add a couple of missing types (the longs).
32498 * literal.cs: Use TypeManager.bool_type instead of getting it.
32500 * expression.cs (EventExpr): New kind of expressions.
32501 (Expressio::ExprClassFromMemberInfo): finish
32503 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32505 * assign.cs: Emit stores to static fields differently.
32507 2001-09-08 Ravi Pratap <ravi@ximian.com>
32509 * Merge in changes and adjust code to tackle conflicts. Backed out my
32510 code in Assign::Resolve ;-)
32512 2001-09-08 Ravi Pratap <ravi@ximian.com>
32514 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32515 instead Report.Error and also pass in the location.
32516 (CSharpParser::Lexer): New readonly property to return the reference
32517 to the Tokenizer object.
32518 (declare_local_variables): Use Report.Error with location instead of plain
32522 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32523 (Operator.CheckBinaryOperator): Ditto.
32525 * cs-parser.jay (operator_declarator): Update accordingly.
32527 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32528 (CheckBinaryOperator): Same here.
32530 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32531 on the name without any prefixes of namespace names etc. This is because we
32532 already might have something already fully qualified like
32533 'System.Console.WriteLine'
32535 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32537 2001-09-07 Ravi Pratap <ravi@ximian.com>
32539 * cs-tokenizer.cs (location): Return a string which also contains
32542 * expression.cs (ElementAccess): New class for expressions of the
32543 type 'element access.'
32544 (BaseAccess): New class for expressions of the type 'base access.'
32545 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32548 * cs-parser.jay (element_access): Implement action.
32549 (base_access): Implement actions.
32550 (checked_expression, unchecked_expression): Implement.
32552 * cs-parser.jay (local_variable_type): Correct and implement.
32553 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32555 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32557 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32558 name and the specifiers.
32560 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32562 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32563 making them all public ;-)
32565 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32568 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32570 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32572 (FieldExpr, PropertyExprs): New resolved expressions.
32573 (SimpleName::MemberStaticCheck): Perform static checks for access
32574 to non-static fields on static methods. Maybe this should be
32575 generalized for MemberAccesses.
32576 (SimpleName::ResolveSimpleName): More work on simple name
32579 * cs-parser.jay (primary_expression/qualified_identifier): track
32580 the parameter index.
32582 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32583 (EmitContext::EmitBoolExpression): Chain to expression generation
32584 instead of temporary hack.
32585 (::EmitStatementExpression): Put generic expression code generation.
32587 * assign.cs (Assign::Emit): Implement variable assignments to
32588 local variables, parameters and fields.
32590 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32592 * statement.cs (Block::GetVariableInfo): New method, returns the
32593 VariableInfo for a variable name in a block.
32594 (Block::GetVariableType): Implement in terms of GetVariableInfo
32596 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32597 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32599 2001-09-06 Ravi Pratap <ravi@ximian.com>
32601 * cs-parser.jay (operator_declaration): Continue on my quest : update
32602 to take attributes argument.
32603 (event_declaration): Ditto.
32604 (enum_declaration): Ditto.
32605 (indexer_declaration): Ditto.
32607 * class.cs (Operator::Operator): Update constructor accordingly.
32608 (Event::Event): Ditto.
32610 * delegate.cs (Delegate::Delegate): Same here.
32612 * enum.cs (Enum::Enum): Same here.
32614 2001-09-05 Ravi Pratap <ravi@ximian.com>
32616 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32618 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32620 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32621 being passed around as an arraylist.
32622 (Attributes::AddAttribute): Method to add attribute sections.
32624 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32625 (struct_declaration): Update accordingly.
32626 (constant_declaration): Update.
32627 (field_declaration): Update.
32628 (method_header): Update.
32629 (fixed_parameter): Update.
32630 (parameter_array): Ditto.
32631 (property_declaration): Ditto.
32632 (destructor_declaration): Ditto.
32634 * class.cs (Struct::Struct): Update constructors accordingly.
32635 (Class::Class): Ditto.
32636 (Field::Field): Ditto.
32637 (Method::Method): Ditto.
32638 (Property::Property): Ditto.
32639 (TypeContainer::OptAttribute): update property's return type.
32641 * interface.cs (Interface.opt_attributes): New member.
32642 (Interface::Interface): Update to take the extra Attributes argument.
32644 * parameter.cs (Parameter::Parameter): Ditto.
32646 * constant.cs (Constant::Constant): Ditto.
32648 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32649 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32650 the attributes as a parameter.
32651 (InterfaceProperty): Update constructor call.
32652 (InterfaceEvent): Ditto.
32653 (InterfaceMethod): Ditto.
32654 (InterfaceIndexer): Ditto.
32656 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32657 pass the attributes too.
32658 (interface_event_declaration): Ditto.
32659 (interface_property_declaration): Ditto.
32660 (interface_method_declaration): Ditto.
32661 (interface_declaration): Ditto.
32663 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32665 * class.cs (Method::Define): Track the "static Main" definition to
32666 create an entry point.
32668 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32669 EntryPoint if we find it.
32671 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32672 (EmitContext::ig): Make this variable public.
32674 * driver.cs: Make the default output file be the first file name
32675 with the .exe extension.
32677 Detect empty compilations
32679 Handle various kinds of output targets. Handle --target and
32680 rename -t to --dumper.
32682 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32683 methods inherited from Expression return now an Expression. This
32684 will is used during the tree rewriting as we resolve them during
32687 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32688 the spec. Missing entirely is the information about
32689 accessability of elements of it.
32691 (Expression::ExprClassFromMemberInfo): New constructor for
32692 Expressions that creates a fully initialized Expression based on
32693 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32696 (Invocation::Resolve): Begin implementing resolution of invocations.
32698 * literal.cs (StringLiteral): Implement Emit.
32700 2001-09-05 Ravi Pratap <ravi@ximian.com>
32702 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32705 2001-09-04 Ravi Pratap <ravi@ximian.com>
32707 * cs-parser.jay (attribute_arguments): Implement actions.
32708 (attribute): Fix bug in production. Implement action.
32709 (attribute_list): Implement.
32710 (attribute_target): Implement.
32711 (attribute_target_specifier, opt_target_specifier): Implement
32712 (CheckAttributeTarget): New method to check if the attribute target
32714 (attribute_section): Implement.
32715 (opt_attributes): Implement.
32717 * attribute.cs : New file to handle attributes.
32718 (Attribute): Class to hold attribute info.
32720 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32721 (attribute_section): Modify production to use 2 different rules to
32722 achieve the same thing. 1 s/r conflict down !
32723 Clean out commented, useless, non-reducing dimension_separator rules.
32725 * class.cs (TypeContainer.attributes): New member to hold list
32726 of attributes for a type.
32727 (Struct::Struct): Modify to take one more argument, the attribute list.
32728 (Class::Class): Ditto.
32729 (Field::Field): Ditto.
32730 (Method::Method): Ditto.
32731 (Property::Property): Ditto.
32733 * cs-parser.jay (struct_declaration): Update constructor call to
32734 pass in the attributes too.
32735 (class_declaration): Ditto.
32736 (constant_declaration): Ditto.
32737 (field_declaration): Ditto.
32738 (method_header): Ditto.
32739 (fixed_parameter): Ditto.
32740 (parameter_array): Ditto.
32741 (property_declaration): Ditto.
32743 * constant.cs (Constant::Constant): Update constructor similarly.
32744 Use System.Collections.
32746 * parameter.cs (Parameter::Parameter): Update as above.
32748 2001-09-02 Ravi Pratap <ravi@ximian.com>
32750 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32751 (TypeContainer.delegates): New member to hold list of delegates.
32753 * cs-parser.jay (delegate_declaration): Implement the action correctly
32754 this time as I seem to be on crack ;-)
32756 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32758 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32759 tell whether an identifier represents a namespace.
32761 * expression.cs (NamespaceExpr): A namespace expression, used only
32762 temporarly during expression resolution.
32763 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32764 utility functions to resolve names on expressions.
32766 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32768 * codegen.cs: Add hook for StatementExpressions.
32770 * class.cs: Fix inverted test for static flag in methods.
32772 2001-09-02 Ravi Pratap <ravi@ximian.com>
32774 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32775 to make it coincide with MS' number.
32776 (Operator::CheckBinaryOperator): Ditto.
32778 * ../errors/errors.txt : Remove error numbers added earlier.
32780 * ../errors/cs1019.cs : Test case for error # 1019
32782 * ../errros/cs1020.cs : Test case for error # 1020
32784 * cs-parser.jay : Clean out commented cruft.
32785 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32786 used anywhere - non-reducing rule.
32787 (namespace_declarations): Non-reducing rule - comment out.
32789 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32790 with TypeContainer::AddEnum.
32792 * delegate.cs : New file for delegate handling classes.
32793 (Delegate): Class for declaring delegates.
32795 * makefile : Update.
32797 * cs-parser.jay (delegate_declaration): Implement.
32799 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32801 * class.cs (Event::Define): Implement.
32802 (Event.EventBuilder): New member.
32804 * class.cs (TypeContainer::Populate): Update to define all enums and events
32806 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32807 readonly fields for all these cases ?
32809 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32811 * class.cs (Property): Revamp to use the convention of making fields readonly.
32812 Accordingly modify code elsewhere.
32814 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32815 the Define method of the Property class.
32817 * class.cs : Clean up applied patch and update references to variables etc. Fix
32819 (TypeContainer::Populate): Update to define all the properties we have. Also
32820 define all enumerations.
32822 * enum.cs (Define): Implement.
32824 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32826 * cs-parser.jay (overloadable_operator): The semantic value is an
32827 enum of the Operator class.
32828 (operator_declarator): Implement actions.
32829 (operator_declaration): Implement.
32831 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32832 validity of definitions.
32833 (Operator::CheckBinaryOperator): Static method to check for binary operators
32834 (TypeContainer::AddOperator): New method to add an operator to a type.
32836 * cs-parser.jay (indexer_declaration): Added line to actually call the
32837 AddIndexer method so it gets added ;-)
32839 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32840 already taken care of by the MS compiler ?
32842 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32844 * class.cs (Operator): New class for operator declarations.
32845 (Operator::OpType): Enum for the various operators.
32847 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32849 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32850 ostensibly handle this in semantic analysis.
32852 * cs-parser.jay (general_catch_clause): Comment out
32853 (specific_catch_clauses, specific_catch_clause): Ditto.
32854 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32855 (catch_args, opt_catch_args): New productions.
32856 (catch_clause): Rewrite to use the new productions above
32857 (catch_clauses): Modify accordingly.
32858 (opt_catch_clauses): New production to use in try_statement
32859 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32860 and re-write the code in the actions to extract the specific and
32861 general catch clauses by being a little smart ;-)
32863 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32864 Hooray, try and catch statements parse fine !
32866 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32868 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32869 string from the hashtable of variables.
32871 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32872 I end up making that mistake ;-)
32873 (catch_clauses): Fixed gross error which made Key and Value of the
32874 DictionaryEntry the same : $1 !!
32876 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32878 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32880 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32881 when the add and remove accessors are specified.
32883 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32885 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32886 information about indexer_declarator.
32887 (indexer_declarator): Implement actions.
32888 (parsing_indexer): New local boolean used to keep track of whether
32889 we are parsing indexers or properties. This is necessary because
32890 implicit_parameters come into picture even for the get accessor in the
32891 case of an indexer.
32892 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32894 * class.cs (Indexer): New class for indexer declarations.
32895 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32896 (TypeContainer::indexers): New member to hold list of indexers for the
32899 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32901 * cs-parser.jay (add_accessor_declaration): Implement action.
32902 (remove_accessor_declaration): Implement action.
32903 (event_accessors_declaration): Implement
32904 (variable_declarators): swap statements for first rule - trivial.
32906 * class.cs (Event): New class to hold information about event
32908 (TypeContainer::AddEvent): New method to add an event to a type
32909 (TypeContainer::events): New member to hold list of events.
32911 * cs-parser.jay (event_declaration): Implement actions.
32913 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32915 * cs-parser.jay (dim_separators): Implement. Make it a string
32916 concatenating all the commas together, just as they appear.
32917 (opt_dim_separators): Modify accordingly
32918 (rank_specifiers): Update accordingly. Basically do the same
32919 thing - instead, collect the brackets here.
32920 (opt_rank_sepcifiers): Modify accordingly.
32921 (array_type): Modify to actually return the complete type string
32922 instead of ignoring the rank_specifiers.
32923 (expression_list): Implement to collect the expressions
32924 (variable_initializer): Implement. We make it a list of expressions
32925 essentially so that we can handle the array_initializer case neatly too.
32926 (variable_initializer_list): Implement.
32927 (array_initializer): Make it a list of variable_initializers
32928 (opt_array_initializer): Modify accordingly.
32930 * expression.cs (New::NType): Add enumeration to help us
32931 keep track of whether we have an object/delegate creation
32932 or an array creation.
32933 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32934 members to hold data about array creation.
32935 (New:New): Modify to update NewType
32936 (New:New): New Overloaded contructor for the array creation
32939 * cs-parser.jay (array_creation_expression): Implement to call
32940 the overloaded New constructor.
32942 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32944 * class.cs (TypeContainer::Constructors): Return member
32945 constructors instead of returning null.
32947 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32949 * typemanager.cs (InitCoreTypes): Initialize the various core
32950 types after we have populated the type manager with the user
32951 defined types (this distinction will be important later while
32952 compiling corlib.dll)
32954 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32955 on Expression Classification. Now all expressions have a method
32956 `Resolve' and a method `Emit'.
32958 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32959 generation from working. Also add some temporary debugging
32962 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32964 * codegen.cs: Lots of code generation pieces. This is only the
32965 beginning, will continue tomorrow with more touches of polish. We
32966 handle the fundamentals of if, while, do, for, return. Others are
32967 trickier and I need to start working on invocations soon.
32969 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32972 * codegen.cs (EmitContext): New struct, used during code
32973 emission to keep a context. Most of the code generation will be
32976 * cs-parser.jay: Add embedded blocks to the list of statements of
32977 this block. So code generation proceeds in a top down fashion.
32979 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32981 * statement.cs: Add support for multiple child blocks.
32983 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32985 * codegen.cs (EmitCode): New function, will emit the code for a
32986 Block of code given a TypeContainer and its ILGenerator.
32988 * statement.cs (Block): Standard public readonly optimization.
32989 (Block::Block constructors): Link children.
32990 (Block::Child): Child Linker.
32991 (Block::EmitVariables): Emits IL variable declarations.
32993 * class.cs: Drop support for MethodGroups here, delay until
32995 (Method::): Applied the same simplification that I did before, and
32996 move from Properties to public readonly fields.
32997 (Method::ParameterTypes): Returns the parameter types for the
32998 function, and implements a cache that will be useful later when I
32999 do error checking and the semantic analysis on the methods is
33001 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33002 and made a method, optional argument tells whether this is a class
33003 or a structure to apply the `has-this' bit.
33004 (Method::GetCallingConvention): Implement, returns the calling
33006 (Method::Define): Defines the type, a second pass is performed
33007 later to populate the methods.
33009 (Constructor::ParameterTypes): implement a cache similar to the
33010 one on Method::ParameterTypes, useful later when we do semantic
33013 (TypeContainer::EmitMethod): New method. Emits methods.
33015 * expression.cs: Removed MethodGroup class from here.
33017 * parameter.cs (Parameters::GetCallingConvention): new method.
33019 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33021 * class.cs (TypeContainer::Populate): Drop RootContext from the
33024 (Constructor::CallingConvention): Returns the calling convention.
33025 (Constructor::ParameterTypes): Returns the constructor parameter
33028 (TypeContainer::AddConstructor): Keep track of default constructor
33029 and the default static constructor.
33031 (Constructor::) Another class that starts using `public readonly'
33032 instead of properties.
33034 (Constructor::IsDefault): Whether this is a default constructor.
33036 (Field::) use readonly public fields instead of properties also.
33038 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33039 track of static constructors; If none is used, turn on
33040 BeforeFieldInit in the TypeAttributes.
33042 * cs-parser.jay (opt_argument_list): now the return can be null
33043 for the cases where there are no arguments.
33045 (constructor_declarator): If there is no implicit `base' or
33046 `this', then invoke the default parent constructor.
33048 * modifiers.cs (MethodAttr): New static function maps a set of
33049 modifiers flags into a MethodAttributes enum
33050 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33051 MethodAttr, TypeAttr to represent the various mappings where the
33052 modifiers are used.
33053 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33055 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33057 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33060 * interface.cs (PopulateIndexer): Implemented the code generator
33061 for interface indexers.
33063 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33065 * interface.cs (InterfaceMemberBase): Now we track the new status
33068 (PopulateProperty): Implement property population. Woohoo! Got
33069 Methods and Properties going today.
33071 Removed all the properties for interfaces, and replaced them with
33072 `public readonly' fields.
33074 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33076 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33077 initialize their hashtables/arraylists only when they are needed
33078 instead of doing this always.
33080 * parameter.cs: Handle refs and out parameters.
33082 * cs-parser.jay: Use an ArrayList to construct the arguments
33083 instead of the ParameterCollection, and then cast that to a
33086 * parameter.cs: Drop the use of ParameterCollection and use
33087 instead arrays of Parameters.
33089 (GetParameterInfo): Use the Type, not the Name when resolving
33092 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33094 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33095 and instead use public readonly fields.
33097 * class.cs: Put back walking code for type containers.
33099 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33101 * class.cs (MakeConstant): Code to define constants.
33103 * rootcontext.cs (LookupType): New function. Used to locate types
33106 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33108 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33109 this System.Reflection code is. Kudos to Microsoft
33111 * typemanager.cs: Implement a type cache and avoid loading all
33112 types at boot time. Wrap in LookupType the internals. This made
33113 the compiler so much faster. Wow. I rule!
33115 * driver.cs: Make sure we always load mscorlib first (for
33116 debugging purposes, nothing really important).
33118 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33119 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33121 * rootcontext.cs: Lookup types on their namespace; Lookup types
33122 on namespaces that have been imported using the `using' keyword.
33124 * class.cs (TypeContainer::TypeAttr): Virtualize.
33125 (Class::TypeAttr): Return attributes suitable for this bad boy.
33126 (Struct::TypeAttr): ditto.
33127 Handle nested classes.
33128 (TypeContainer::) Remove all the type visiting code, it is now
33129 replaced with the rootcontext.cs code
33131 * rootcontext.cs (GetClassBases): Added support for structs.
33133 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33135 * interface.cs, statement.cs, class.cs, parameter.cs,
33136 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33137 Drop use of TypeRefs, and use strings instead.
33139 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33143 * class.cs (Struct::Struct): set the SEALED flags after
33144 checking the modifiers.
33145 (TypeContainer::TypeAttr): new property, returns the
33146 TypeAttributes for a class.
33148 * cs-parser.jay (type_list): Oops, list production was creating a
33149 new list of base types.
33151 * rootcontext.cs (StdLib): New property.
33152 (GetInterfaceTypeByName): returns an interface by type name, and
33153 encapsulates error handling here.
33154 (GetInterfaces): simplified.
33155 (ResolveTree): Encapsulated all the tree resolution here.
33156 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33159 * driver.cs: Add support for --nostdlib, to avoid loading the
33160 default assemblies.
33161 (Main): Do not put tree resolution here.
33163 * rootcontext.cs: Beginning of the class resolution.
33165 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33167 * rootcontext.cs: Provide better error reporting.
33169 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33171 * rootcontext.cs (CreateInterface): Handle the case where there
33172 are no parent interfaces.
33174 (CloseTypes): Routine to flush types at the end.
33175 (CreateInterface): Track types.
33176 (GetInterfaces): Returns an array of Types from the list of
33177 defined interfaces.
33179 * typemanager.c (AddUserType): Mechanism to track user types (puts
33180 the type on the global type hash, and allows us to close it at the
33183 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33185 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33186 RecordInterface instead.
33188 * cs-parser.jay: Updated to reflect changes above.
33190 * decl.cs (Definition): Keep track of the TypeBuilder type that
33191 represents this type here. Not sure we will use it in the long
33192 run, but wont hurt for now.
33194 * driver.cs: Smaller changes to accomodate the new code.
33196 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33199 * rootcontext.cs (CreateInterface): New method, used to create
33200 the System.TypeBuilder type for interfaces.
33201 (ResolveInterfaces): new entry point to resolve the interface
33203 (CodeGen): Property, used to keep track of the code generator.
33205 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33207 * cs-parser.jay: Add a second production for delegate_declaration
33210 (enum_body): Put an opt_comma here instead of putting it on
33211 enum_body or enum_member_declarations so we can handle trailing
33212 commas on enumeration members. Gets rid of a shift/reduce.
33214 (type_list): Need a COMMA in the middle.
33216 (indexer_declaration): Tell tokenizer to recognize get/set
33218 * Remove old targets.
33220 * Re-add the parser target.
33222 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33224 * cs-parser.jay: Add precendence rules for a number of operators
33225 ot reduce the number of shift/reduce conflicts in the grammar.
33227 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33229 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33232 Get rid of old crufty code.
33234 * rootcontext.cs: Use this to keep track of the parsed
33235 representation and the defined types available to the program.
33237 * gen-treedump.cs: adjust for new convention.
33239 * type.cs: Split out the type manager, and the assembly builder
33242 * typemanager.cs: the type manager will live here now.
33244 * cil-codegen.cs: And the code generator here.
33246 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33248 * makefile: Fixed up for easy making.
33250 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33252 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33255 (unary_expression): Expand pre_increment_expression and
33256 post_decrement_expression to reduce a shift/reduce.
33258 2001-07-11 Simon Cozens
33260 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33262 Improve allow_keyword_as_indent name.
33264 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33266 * Adjustments for Beta2.
33268 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33270 * decl.cs: Added `Define' abstract method.
33271 (InTransit): new property, used to catch recursive definitions.
33273 * interface.cs: Implement `Define'.
33275 * modifiers.cs: Map Modifiers.constants to
33276 System.Reflection.TypeAttribute flags.
33278 * class.cs: Keep track of types and user-defined types.
33279 (BuilderInit): New method for creating an assembly
33280 (ResolveType): New function to launch the resolution process, only
33281 used by interfaces for now.
33283 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33284 that are inserted into the name space.
33286 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33288 * ARGH. I have screwed up my tree so many times due to the use of
33289 rsync rather than using CVS. Going to fix this at once.
33291 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33294 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33296 * Experiment successful: Use System.Type rather that our own
33299 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33301 * cs-parser.jay: Removed nsAliases from here.
33303 Use new namespaces, handle `using XXX;'
33305 * namespace.cs: Reimplemented namespace handling, use a recursive
33306 definition of the class. Now we can keep track of using clauses
33307 and catch invalid using clauses.
33309 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33311 * gen-treedump.cs: Adapted for all the renaming.
33313 * expression.cs (Expression): this class now has a Type property
33314 which returns an expression Type.
33316 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33317 `Type', as this has a different meaning now in the base
33319 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33321 * interface.cs, class.cs: Removed from all the sources the
33322 references to signature computation, as we can not do method
33323 signature computation during the parsing time, as we are not
33324 trying to solve at that point distinguishing:
33328 void a (NS.Blah x) {}
33331 Which depending on the context might be valid or not, as we do not
33332 know if Blah is the same thing as NS.Blah at that point.
33334 * Redid everything so the code uses TypeRefs now instead of
33335 Types. TypeRefs are just temporary type placeholders, that need
33336 to be resolved. They initially have a pointer to a string and the
33337 current scope in which they are used. This is used later by the
33338 compiler to resolve the reference to an actual Type.
33340 * DeclSpace is no longer a CIR.Type, and neither are
33341 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33342 are all DeclSpaces, but no Types.
33344 * type.cs (TypeRefManager): This implements the TypeRef manager,
33345 which keeps track of all the types that need to be resolved after
33346 the parsing has finished.
33348 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33350 * ARGH. We are going to have to store `foreach' as a class rather
33351 than resolving it, as we need to verify error 1579 after name
33352 resolution. *OR* we could keep a flag that says `This request to
33353 IEnumerator comes from a foreach statement' which we can then use
33354 to generate the error.
33356 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33358 * class.cs (TypeContainer.AddMethod): we now add methods to the
33359 MethodGroup instead of the method hashtable.
33361 * expression.cs: Add MethodGroup abstraction, which gets us one
33362 step closer to the specification in the way we handle method
33365 * cs-parser.jay (primary_expression): qualified_identifier now
33366 tried to match up an identifier to a local variable reference or
33367 to a parameter reference.
33369 current_local_parameters is now a parser global variable that
33370 points to the current parameters for the block, used during name
33373 (property_declaration): Now creates an implicit `value' argument to
33376 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33378 * parameter.cs: Do not use `param' arguments as part of the
33379 signature, per the spec.
33381 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33383 * decl.cs: Base class for classes, structs and interfaces. This
33384 is the "Declaration Space"
33386 * cs-parser.jay: Use CheckDef for checking declaration errors
33387 instead of having one on each function.
33389 * class.cs: Factor out some code for handling error handling in
33390 accordance to the "Declarations" section in the "Basic Concepts"
33391 chapter in the ECMA C# spec.
33393 * interface.cs: Make all interface member classes derive from
33394 InterfaceMemberBase.
33396 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33398 * Many things: all interfaces are parsed and generated in
33399 gen-treedump. Support for member variables, constructors,
33400 destructors, properties, constants is there.
33402 Beginning of the IL backend, but very little done, just there for
33405 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33407 * cs-parser.jay: Fix labeled statement.
33409 * cs-tokenizer.cs (escape): Escape " and ' always.
33410 ref_line, ref_name: keep track of the line/filename as instructed
33411 by #line by the compiler.
33414 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33416 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33417 to match the values in System.CodeDOM.
33419 Divid renamed to Divide.
33421 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33423 (Statements.set): remove.
33425 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33428 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33429 falseStatements always have valid values.
33431 * cs-parser.jay: Use System.CodeDOM now.