1 2004-07-25 Martin Baulig <martin@ximian.com>
3 Merged latest changes into gmcs. Please keep this comment in
4 here, it makes it easier for me to see what changed in MCS since
5 the last time I merged.
7 2004-08-02 Martin Baulig <martin@ximian.com>
9 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10 (LocalInfo.IsThis): New public property.
11 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13 2004-08-01 Martin Baulig <martin@ximian.com>
15 * class.cs (TypeContainer.GetClassBases): Don't set the default
16 here since we may get called from GetPartialBases().
17 (TypeContainer.DefineType): If GetClassBases() didn't return a
18 parent, use the default one.
20 2004-07-30 Duncan Mak <duncan@ximian.com>
22 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
24 2004-07-30 Martin Baulig <martin@ximian.com>
26 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
28 * class.cs (SourceMethod): New public class, derive from the
29 symbol writer's ISourceMethod.
30 (Method): Use the new symbol writer API.
32 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
33 as argument and use the new symbol writer.
36 (SourceFile): Implement the symbol writer's ISourceFile.
37 (Location.SymbolDocument): Removed.
38 (Location.SourceFile): New public property.
40 * symbolwriter.cs: Use the new symbol writer API.
42 2004-07-30 Raja R Harinath <rharinath@novell.com>
44 * Makefile (install-local): Remove. Functionality moved to
47 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
49 * Makefile: Install mcs.exe.config file together with mcs.exe.
50 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
51 correct runtime version.
53 2004-07-25 Martin Baulig <martin@ximian.com>
56 (TypeContainer.RegisterOrder): Removed, this was unused.
57 (TypeContainer, interface_order): Removed.
58 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
59 TypeContainer as argument since we can also be called with a
60 `PartialContainer' for a partial class/struct/interface.
61 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
62 of checking whether we're an `Interface' - we could be a
64 (PartialContainer.Register): Override; call
65 AddClass()/AddStruct()/AddInterface() on our parent.
67 * cs-parser.jay (interface_member_declaration): Add things to the
68 `current_container', not the `current_class'.
70 * rootcontext.cs (RegisterOrder): The overloaded version which
71 takes an `Interface' was unused, removed.
73 * typemanager.cs (TypeManager.LookupInterface): Return a
74 `TypeContainer', not an `Interface'.
75 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
76 contain a `PartialContainer' for an interface, so check it's
77 `Kind' to figure out what it is.
79 2004-07-25 Martin Baulig <martin@ximian.com>
81 * class.cs (Class.DefaultTypeAttributes): New public constant.
82 (Struct.DefaultTypeAttributes): Likewise.
83 (Interface.DefaultTypeAttributes): Likewise.
84 (PartialContainer.TypeAttr): Override this and add the
85 DefaultTypeAttributes.
87 2004-07-25 Martin Baulig <martin@ximian.com>
89 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
90 we can just use the `Parent' field instead.
92 2004-07-25 Martin Baulig <martin@ximian.com>
94 * class.cs (TypeContainer.Emit): Renamed to EmitType().
96 2004-07-25 Martin Baulig <martin@ximian.com>
98 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
99 our parts before defining any methods.
100 (TypeContainer.VerifyImplements): Make this virtual.
101 (ClassPart.VerifyImplements): Override and call VerifyImplements()
102 on our PartialContainer.
104 2004-07-25 Martin Baulig <martin@ximian.com>
106 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
108 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
109 argument, we can just use the `Parent' field instead.
112 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
113 (MemberBase.DoDefine): Likewise.
115 2004-07-24 Martin Baulig <martin@ximian.com>
117 * decl.cs (MemberCore.Parent): New public field.
118 (DeclSpace.Parent): Moved to MemberCore.
120 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
121 (MemberBase.ctor): Added TypeContainer argument, pass it to our
123 (FieldBase, Field, Operator): Likewise.
124 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
125 (EventField, Event): Likewise.
127 2004-07-23 Martin Baulig <martin@ximian.com>
129 * class.cs (PartialContainer): New public class.
130 (ClassPart): New public class.
131 (TypeContainer): Added support for partial classes.
132 (TypeContainer.GetClassBases): Splitted some of the functionality
133 out into GetNormalBases() and GetPartialBases().
135 * cs-tokenizer.cs (Token.PARTIAL): New token.
136 (Tokenizer.consume_identifier): Added some hacks to recognize
137 `partial', but only if it's immediately followed by `class',
138 `struct' or `interface'.
140 * cs-parser.jay: Added support for partial clases.
142 2004-07-23 Martin Baulig <martin@ximian.com>
144 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
145 a `DeclSpace' and also made it readonly.
146 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
147 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
148 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
150 * cs-parser.jay: Pass the `current_class', not the
151 `current_container' (at the moment, this is still the same thing)
152 to a new Method, Property, Event, Indexer or Constructor.
154 2004-07-23 Martin Baulig <martin@ximian.com>
156 * cs-parser.jay (CSharpParser): Added a new `current_class' field
157 and removed the `current_interface' one.
158 (struct_declaration, class_declaration, interface_declaration):
159 Set `current_class' to the newly created class/struct/interface;
160 set their `Bases' and call Register() before parsing their body.
162 2004-07-23 Martin Baulig <martin@ximian.com>
164 * class.cs (Kind): New public enum.
165 (TypeContainer): Made this class abstract.
166 (TypeContainer.Kind): New public readonly field.
167 (TypeContainer.CheckDef): New public method; moved here from
169 (TypeContainer.Register): New public abstract method.
170 (TypeContainer.GetPendingImplementations): New public abstract
172 (TypeContainer.GetClassBases): Removed the `is_class' and
173 `is_iface' parameters.
174 (TypeContainer.DefineNestedTypes): Formerly known as
176 (ClassOrStruct): Made this class abstract.
178 * tree.cs (RootTypes): New public type.
180 2004-07-20 Martin Baulig <martin@ximian.com>
182 * tree.cs (Tree.RecordNamespace): Removed.
183 (Tree.Namespaces): Removed.
185 * rootcontext.cs (RootContext.IsNamespace): Removed.
187 * cs-parser.jay (namespace_declaration): Just create a new
190 2004-07-20 Martin Baulig <martin@ximian.com>
192 * statement.cs (ExceptionStatement): New abstract class. This is
193 now used as a base class for everyone who's using `finally'.
194 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
195 our local variables before using them.
197 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
198 virtual method. This is used by Yield.Resolve() to "steal" an
199 outer block's `finally' clauses.
200 (FlowBranchingException): The .ctor now takes an ExceptionStatement
203 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
204 version which takes an ExceptionStatement. This version must be
205 used to create exception branchings.
208 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
209 (Iterator.EmitMoveNext): Added exception support; protect the
210 block with a `fault' clause, properly handle 'finally' clauses.
211 (Iterator.EmitDispose): Run all the `finally' clauses here.
213 2004-07-20 Martin Baulig <martin@ximian.com>
215 * iterator.cs: This is the first of a set of changes in the
216 iterator code. Match the spec more closely: if we're an
217 IEnumerable, then GetEnumerator() must be called. The first time
218 GetEnumerator() is called, it returns the current instance; all
219 subsequent invocations (if any) must create a copy.
221 2004-07-19 Miguel de Icaza <miguel@ximian.com>
223 * expression.cs: Resolve the constant expression before returning
226 2004-07-19 Martin Baulig <martin@ximian.com>
228 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
229 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
230 the return type of the new EmitContext.
232 2004-07-18 Martin Baulig <martin@ximian.com>
234 * class.cs (Property.Define): Fix iterators.
236 * iterators.cs (Iterator.Define): Moved the
237 `container.AddInterator (this)' call here from the .ctor; only do
238 it if we resolved successfully.
240 2004-07-17 Miguel de Icaza <miguel@ximian.com>
242 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
243 `true' for preprocessing directives that we parse. The return
244 value indicates whether we should return to regular tokenizing or
245 not, not whether it was parsed successfully.
247 In the past if we were in: #if false ... #line #endif, we would
248 resume parsing after `#line'. See bug 61604.
250 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
251 building: IsEnumType should return true only for enums, not for
252 enums or System.Enum itself. This fixes #61593.
254 Likely what happened is that corlib was wrong: mcs depended on
255 this bug in some places. The bug got fixed, we had to add the
256 hack, which caused bug 61593.
258 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
259 that was a workaround for the older conditions.
261 2004-07-16 Ben Maurer <bmaurer@ximian.com>
263 * assign.cs: IAssignMethod has a new interface, as documented
264 inline. All assignment code now uses this new api.
266 * ecore.cs, expression.cs: All classes which implement
267 IAssignMethod now use the new interface.
269 * expression.cs (Invocation): add a hack to EmitCall so that
270 IndexerAccess can be the target of a compound assignment without
271 evaluating its arguments twice.
273 * statement.cs: Handle changes in Invocation api.
275 2004-07-16 Martin Baulig <martin@ximian.com>
277 * iterators.cs: Rewrote this. We're now using one single Proxy
278 class for both the IEnumerable and the IEnumerator interface and
279 `Iterator' derives from Class so we can use the high-level API.
281 * class.cs (TypeContainer.AddIterator): New method.
282 (TypeContainer.DoDefineType): New protected virtual method, which
283 is called from DefineType().
284 (TypeContainer.DoDefineMembers): Call DefineType() and
285 DefineMembers() on all our iterators.
286 (TypeContainer.Emit): Call Emit() on all our iterators.
287 (TypeContainer.CloseType): Call CloseType() on all our iterators.
289 * codegen.cs (EmitContext.CurrentIterator): New public field.
291 2004-07-15 Martin Baulig <martin@ximian.com>
294 (TypeManager.not_supported_exception_type): New type.
296 2004-07-14 Martin Baulig <martin@ximian.com>
298 * iterators.cs: Use real error numbers.
300 2004-07-14 Martin Baulig <martin@ximian.com>
302 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
303 requires this to be a System.Collection.IEnumerable and not a
304 class implementing that interface.
305 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
307 2004-07-13 Marek Safar <marek.safar@seznam.cz>
309 * class.cs: Fixed previous fix, it broke some error tests.
311 2004-07-12 Martin Baulig <martin@ximian.com>
313 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
316 2004-07-09 Miguel de Icaza <miguel@ximian.com>
318 * assign.cs (LocalTemporary): Add new argument: is_address,If
319 `is_address' is true, then the value that we store is the address
320 to the real value, and not the value itself.
322 * ecore.cs (PropertyExpr): use the new local temporary
323 stuff to allow us to handle X.Y += z (where X is a struct)
325 2004-07-08 Martin Baulig <martin@ximian.com>
327 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
328 not always return, just like we're doing in Using.Resolve().
330 2004-07-07 Miguel de Icaza <miguel@ximian.com>
332 * cs-parser.jay (fixed_statement): flag this as Pinned.
334 2004-07-06 Miguel de Icaza <miguel@ximian.com>
336 * typemanager.cs (TypeManager): Removed MakePinned method, this
337 mechanism is replaced with the .NET 2.x compatible mechanism of
338 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
340 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
341 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
342 `IsFixed' property which has a different meaning.
344 2004-07-02 Raja R Harinath <rharinath@novell.com>
346 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
347 visible from inside a nested class, not just the names of the
348 immediately enclosing class.
351 2004-06-24 Raja R Harinath <rharinath@novell.com>
353 * expression.cs (BetterConversion): Remove buggy special-case
354 handling of "implicit constant expression conversions". At this
355 point, we already know that the conversion is possible -- we're
356 only checking to see which is better.
358 2004-06-24 Marek Safar <marek.safar@seznam.cz>
360 * cs-parser.jay: Added error CS0210 test.
362 2004-06-24 Marek Safar <marek.safar@seznam.cz>
364 * cs-parser.jay: Added error CS0134 test.
366 2004-06-24 Marek Safar <marek.safar@seznam.cz>
369 * cs-parser.jay: Added error CS0145 test.
371 2004-06-24 Marek Safar <marek.safar@seznam.cz>
373 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
375 2004-06-23 Ben Maurer <bmaurer@ximian.com>
377 * expression.cs (StackAlloc.Resolve): The argument may not
378 be a constant; deal with this case.
380 2004-06-23 Marek Safar <marek.safar@seznam.cz>
382 * attribute.cs (IndexerName_GetIndexerName): Renamed to
383 GetIndexerAttributeValue.
384 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
386 * class.cs (Indexer.Define): Added error tests for CS0415,
389 2004-06-23 Miguel de Icaza <miguel@ximian.com>
391 * attribute.cs (Attribute.Resolve): Keep field code in sync with
394 2004-06-23 Martin Baulig <martin@ximian.com>
396 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
397 neither return nor throw, reset the barrier as well. Fixes #60457.
399 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
401 * class.cs : EventAttributes is now set to None by default.
402 This fixes bug #60459.
404 2004-06-18 Marek Safar <marek.safar@seznam.cz>
407 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
408 Don't throw exception but return null (it's sufficient now).
410 2004-06-18 Marek Safar <marek.safar@seznam.cz>
412 * typemanager.cs (GetArgumentTypes): Faster implementation.
414 2004-06-18 Martin Baulig <martin@ximian.com>
416 * attribute.cs (Attribute.Resolve): Check whether we're an
417 EmptyCast which a Constant child. Fixes #60333.
419 2004-06-17 Ben Maurer <bmaurer@ximian.com>
421 * statement.cs (EmitCollectionForeach): Account for the fact that
422 not all valuetypes are in areas which we can take the address of.
423 For these variables, we store to a temporary variable. Also, make
424 sure that we dont emit a `callvirt' on a valuetype method.
426 2004-06-15 Marek Safar <marek.safar@seznam.cz>
428 * expression.cs (StackAlloc.DoReSolve): Added test for
429 negative parameter (CS0247).
431 2004-06-15 Marek Safar <marek.safar@seznam.cz>
434 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
436 2004-06-15 Marek Safar <marek.safar@seznam.cz>
439 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
442 2004-06-14 Marek Safar <marek.safar@seznam.cz>
444 Fix bug #58254 & cs1555.cs, cs1556.cs
445 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
447 2004-06-14 Marek Safar <marek.safar@seznam.cz>
449 * cs-parser.jay: Added error CS1669 test for indexers.
451 2004-06-11 Martin Baulig <martin@ximian.com>
453 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
454 call this twice: for params and varargs methods.
456 2004-06-11 Marek Safar <marek.safar@seznam.cz>
459 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
461 2004-06-11 Marek Safar <marek.safar@seznam.cz>
463 * attribute.cs (Attribute.GetValidTargets): Made public.
466 (AbstractPropertyEventMethod): New class for better code sharing.
467 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
469 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
471 2004-06-11 Raja R Harinath <rharinath@novell.com>
474 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
475 that the call to Resolve is part of a MemberAccess.
476 (Expression.Resolve): Use it for SimpleName resolution.
477 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
478 Add 'intermediate' boolean argument.
479 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
480 error message when the SimpleName can be resolved ambiguously
481 between an expression and a type.
482 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
484 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
485 call on the left-side.
487 2004-06-11 Marek Safar <marek.safar@seznam.cz>
490 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
492 2004-06-11 Marek Safar <marek.safar@seznam.cz>
494 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
496 2004-06-11 Martin Baulig <martin@ximian.com>
498 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
499 varargs methods if applicable.
501 2004-06-11 Martin Baulig <martin@ximian.com>
503 * expression.cs (Invocation.EmitCall): Don't use
504 `method.CallingConvention == CallingConventions.VarArgs' since the
505 method could also have `CallingConventions.HasThis'.
507 2004-06-11 Marek Safar <marek.safar@seznam.cz>
509 * class.cs (Event.GetSignatureForError): Implemented.
510 Fixed crash in error test cs3010.cs
512 2004-06-10 Miguel de Icaza <miguel@ximian.com>
514 * cs-tokenizer.cs: Change the way we track __arglist to be
515 consistent with the other keywords.
517 2004-06-09 Miguel de Icaza <miguel@ximian.com>
519 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
522 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
524 * codegen.cs: Check that all referenced assemblies have a strongname
525 before strongnaming the compiled assembly. If not report error CS1577.
526 Fix bug #56563. Patch by Jackson Harper.
527 * typemanager.cs: Added a method to return all referenced assemblies.
528 Fix bug #56563. Patch by Jackson Harper.
530 2004-06-08 Marek Safar <marek.safar@seznam.cz>
533 (Method.ApplyAttributeBuilder): Moved and added conditional
534 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
537 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
539 2004-06-08 Marek Safar <marek.safar@seznam.cz>
542 * class.cs: (EventField.attribute_targets): Changed default target.
544 2004-06-08 Martin Baulig <martin@ximian.com>
546 * expression.cs (Invocation.EmitCall): Enable varargs methods.
548 2004-06-08 Martin Baulig <martin@ximian.com>
550 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
552 2004-06-07 Martin Baulig <martin@ximian.com>
554 Added support for varargs methods.
556 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
559 * cs-parser.jay: Added support for `__arglist'.
561 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
563 * expression.cs (Argument.AType): Added `ArgList'.
564 (Invocation): Added support for varargs methods.
565 (ArglistAccess): New public class.
566 (Arglist): New public class.
568 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
570 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
571 a method's top-level block if the method has varargs.
573 * support.cs (ReflectionParameters, InternalParameters): Added
574 support for varargs methods.
576 2004-06-07 Miguel de Icaza <miguel@ximian.com>
578 * class.cs: Provide location in indexer error report.
580 * driver.cs: Use standard names.
582 * namespace.cs: Catch the use of using after a namespace has been
583 declared also on using aliases.
585 2004-06-03 Raja R Harinath <rharinath@novell.com>
588 * typemanager.cs (closure_private_ok, closure_invocation_type)
589 (closure_qualifier_type, closure_invocation_assembly)
590 (FilterWithClosure): Move to ...
591 (Closure): New internal nested class.
592 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
593 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
594 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
595 (MemberLookup, MemberLookupFailed): Use it.
596 * expression.cs (New.DoResolve): Treat the lookup for the
597 constructor as being qualified by the 'new'ed type.
598 (Indexers.GetIndexersForTypeOrInterface): Update.
600 2004-06-03 Marek Safar <marek.safar@seznam.cz>
603 (GetConditionalAttributeValue): New method. Returns
604 condition of ConditionalAttribute.
605 (SearchMulti): New method. Returns all attributes of type 't'.
606 Use it when attribute is AllowMultiple = true.
607 (IsConditionalMethodExcluded): New method.
610 (Method.IsExcluded): Implemented. Returns true if method has conditional
611 attribute and the conditions is not defined (method is excluded).
612 (IMethodData): Extended interface for ConditionalAttribute support.
613 (PropertyMethod.IsExcluded): Implemented.
616 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
619 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
622 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
624 * expression.cs (ArrayCreationExpression): Make this just an
625 `expression'. It can't be a statement, so the code here was
628 2004-06-02 Marek Safar <marek.safar@seznam.cz>
631 * typemanager.cs (GetFullNameSignature): New method for
634 2004-06-02 Marek Safar <marek.safar@seznam.cz>
637 * class.cs (MemberBase.GetSignatureForError): New virtual method.
638 Use this method when MethodBuilder is null.
639 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
640 Added test for error CS0626 (MONO reports error for this situation).
641 (IMethodData.GetSignatureForError): Extended interface.
643 2004-06-01 Marek Safar <marek.safar@seznam.cz>
646 (AttributeTester.GetObsoleteAttribute): Returns instance of
647 ObsoleteAttribute when type is obsolete.
650 (TypeContainer.VerifyObsoleteAttribute): Override.
651 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
652 (MethodCode.VerifyObsoleteAttribute): Override.
653 (MemberBase.VerifyObsoleteAttribute): Override.
656 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
657 and report proper error.
660 Delegate.VerifyObsoleteAttribute): Override.
663 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
664 and report proper error.
665 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
668 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
672 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
673 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
674 Added test for ObsoleteAttribute.
677 (Catch): Derived from Statement.
679 2004-06-01 Marek Safar <marek.safar@seznam.cz>
681 Fixed bug #59071 & cs0160.cs
683 * statement.cs (Try.Resolve): Check here whether order of catch
684 clauses matches their dependencies.
686 2004-05-31 Miguel de Icaza <miguel@ximian.com>
688 * Reverted patch to namespace.cs (Use lookuptypedirect). This
689 caused a regression: #59343. Referencing nested classes from an
690 assembly stopped working.
692 2004-05-31 Martin Baulig <martin@ximian.com>
694 MCS is now frozen for beta 2.
696 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
698 * convert.cs: add a trivial cache for overload operator resolution.
700 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
702 * decl.cs: If possible, use lookuptypedirect here. We can only do
703 this if there is no `.' after the namespace. Avoids using
704 LookupType, which does lots of slow processing.
705 (FindNestedType) New method, does what it says :-).
706 * namespace.cs: use LookupTypeDirect.
707 * rootcontext.cs: use membercache, if possible.
708 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
710 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
713 According to the spec,
715 In a member access of the form E.I, if E is a single identifier,
716 and if the meaning of E as a simple-name (§7.5.2) is a constant,
717 field, property, localvariable, or parameter with the same type as
718 the meaning of E as a type-name (§3.8), then both possible
719 meanings of E are permitted.
721 We did not check that E as a simple-name had the same type as E as
724 This trivial check gives us 5-7% on bootstrap time.
726 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
728 * expression.cs (Invocation.OverloadResolve): Avoid the
729 use of hashtables and boxing here by allocating on demand.
731 2004-05-30 Martin Baulig <martin@ximian.com>
733 * rootcontext.cs (RootContext.LookupType): Don't cache things if
734 we're doing a silent lookup. Don't try to lookup nested types in
735 TypeManager.object_type (thanks to Ben Maurer).
737 2004-05-30 Martin Baulig <martin@ximian.com>
739 Committing a patch from Ben Maurer.
741 * rootcontext.cs (RootContext.LookupType): Cache negative results.
743 2004-05-29 Martin Baulig <martin@ximian.com>
745 * class.cs (IMethodData.ShouldIgnore): New method.
747 * typemanager.cs (TypeManager.MethodFlags): Don't take a
748 `Location' argument, we don't need it anywhere. Use
749 `IMethodData.ShouldIgnore ()' instead of
750 `MethodData.GetMethodFlags ()'.
751 (TypeManager.AddMethod): Removed.
752 (TypeManager.AddMethod2): Renamed to AddMethod.
754 2004-05-29 Martin Baulig <martin@ximian.com>
756 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
758 * convert.cs (Convert.ImplicitReferenceConversion): If we're
759 converting from a class type S to an interface type and we already
760 have an object on the stack, don't box it again. Fixes #52578.
762 2004-05-29 Martin Baulig <martin@ximian.com>
764 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
765 Added support for `params' parameters. Fixes #59267.
767 2004-05-29 Martin Baulig <martin@ximian.com>
769 * literal.cs (NullPointer): Provide a private .ctor which sets
770 `type' to TypeManager.object_type. Fixes #59048.
772 2004-05-29 Martin Baulig <martin@ximian.com>
774 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
775 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
777 * ecore.cs (EventExpr.instance_expr): Make the field private.
779 2004-05-26 Marek Safar <marek.safar@seznam.cz>
781 Fixed bug #50080 & cs0214-2.cs
782 * expression.cs (Cast.DoResolve): Check unsafe context here.
784 * statement.cs (Resolve.DoResolve): Likewise.
786 2004-05-26 Martin Baulig <martin@ximian.com>
788 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
790 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
791 (RootContext.LookupType): Pass down the `silent' flag.
793 2004-05-25 Martin Baulig <martin@ximian.com>
796 (MethodGroupExpr.IdenticalTypeName): New public property.
797 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
798 expression actually refers to a type.
800 2004-05-25 Martin Baulig <martin@ximian.com>
802 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
803 for #56176 and made it actually work.
805 2004-05-25 Martin Baulig <martin@ximian.com>
807 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
808 (FieldExpr, PropertyExpr): Override and implement
809 CacheTemporaries. Fixes #52279.
811 2004-05-25 Miguel de Icaza <miguel@ximian.com>
813 * location.cs: In the new compiler listing a file twice is a
814 warning, not an error.
816 2004-05-24 Martin Baulig <martin@ximian.com>
818 * enum.cs (Enum.DefineType): For the `BaseType' to be a
819 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
821 2004-05-24 Martin Baulig <martin@ximian.com>
823 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
824 walking the `using' list. Fixes #53921.
826 2004-05-24 Martin Baulig <martin@ximian.com>
828 * const.cs (Const.LookupConstantValue): Added support for
829 EmptyCast's; fixes #55251.
831 2004-05-24 Martin Baulig <martin@ximian.com>
833 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
834 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
835 which does the CS0135 check. The reason is that we first need to
836 check whether the variable actually exists.
838 2004-05-24 Martin Baulig <martin@ximian.com>
840 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
841 than RootContext.LookupType() to find the explicit interface
844 2004-05-24 Raja R Harinath <rharinath@novell.com>
846 * Makefile: Simplify. Use executable.make.
847 * mcs.exe.sources: New file. List of sources of mcs.exe.
849 2004-05-24 Anders Carlsson <andersca@gnome.org>
853 Use the invariant culture when doing String.Compare for CLS case
856 2004-05-23 Martin Baulig <martin@ximian.com>
858 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
859 don't have any dots. Fixes #52622, added cs0246-8.cs.
861 * namespace.cs (NamespaceEntry.Lookup): Likewise.
863 2004-05-23 Marek Safar <marek.safar@seznam.cz>
865 * class.cs (MemberBase.Define): Reuse MemberType member for
866 resolved type. Other methods can use it too.
868 2004-05-23 Martin Baulig <martin@ximian.com>
870 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
871 the variable also exists in the current block (otherwise, we need
872 to report a CS0103). Fixes #58670.
874 2004-05-23 Martin Baulig <martin@ximian.com>
876 * flowanalysis.cs (Reachability.Reachable): Compute this
877 on-the-fly rather than storing it as a field.
879 2004-05-23 Martin Baulig <martin@ximian.com>
881 * flowanalysis.cs (Reachability.And): Manually compute the
882 resulting `barrier' from the reachability.
884 2004-05-23 Marek Safar <marek.safar@seznam.cz>
887 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
888 instance of ObsoleteAttribute when symbol is obsolete.
891 (IMethodData): Extended interface for ObsoleteAttribute support.
893 2004-05-22 Marek Safar <marek.safar@seznam.cz>
895 * attribute.cs: Fix bug #55970
897 2004-05-22 Marek Safar <marek.safar@seznam.cz>
901 (GetObsoleteAttribute): New method. Creates the instance of
903 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
904 ObsoleteAttribute when member is obsolete.
905 (AttributeTester.Report_ObsoleteMessage): Common method for
906 Obsolete error/warning reporting.
909 (TypeContainer.base_classs_type): New member for storing parent type.
912 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
915 2004-05-21 Marek Safar <marek.safar@seznam.cz>
917 * attribute.cs, const.cs: Fix bug #58590
919 2004-05-21 Martin Baulig <martin@ximian.com>
921 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
922 out parameters if the end of the method is unreachable. Fixes
925 2004-05-21 Marek Safar <marek.safar@seznam.cz>
927 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
928 Hari was right, why extra method.
930 2004-05-21 Marek Safar <marek.safar@seznam.cz>
932 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
934 2004-05-20 Martin Baulig <martin@ximian.com>
936 Merged this back from gmcs to keep the differences to a minumum.
938 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
939 instead of a Declspace.
940 (Attribute.ResolveType): Likewise.
941 (Attributes.Search): Likewise.
942 (Attributes.Contains): Likewise.
943 (Attributes.GetClsCompliantAttribute): Likewise.
945 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
947 (MethodData.ApplyAttributes): Take an EmitContext instead of a
950 2004-05-19 Marek Safar <marek.safar@seznam.cz>
952 Fix bug #58688 (MCS does not report error when the same attribute
955 * attribute.cs (Attribute.Emit): Distinction between null and default.
957 2004-05-19 Raja R Harinath <rharinath@novell.com>
959 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
960 of a top-level attribute without an attribute target.
961 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
963 (Attribute.Conditional_GetConditionName),
964 (Attribute.Obsolete_GetObsoleteMessage): Update.
965 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
966 part of ScanForIndexerName.
967 (Attribute.CanIgnoreInvalidAttribute): New function.
968 (Attribute.ScanForIndexerName): Move to ...
969 (Attributes.ScanForIndexerName): ... here.
970 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
971 (Attributes.Search): New internal variant that can choose not to
972 complain if types aren't resolved. The original signature now
974 (Attributes.GetClsCompliantAttribute): Use internal variant, with
975 complaints suppressed.
976 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
977 only if it not useful.
978 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
979 top-level for attributes that are shared between the assembly
980 and a top-level class.
981 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
982 * class.cs: Update to reflect changes.
983 (DefineIndexers): Fuse loops.
984 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
985 a couple more variants of attribute names.
987 2004-05-18 Marek Safar <marek.safar@seznam.cz>
989 Fix bug #52585 (Implemented explicit attribute declaration)
992 (Attributable.ValidAttributeTargets): New abstract method. It gets
993 list of valid attribute targets for explicit target declaration.
994 (Attribute.Target): It holds target itself.
995 (AttributeSection): Removed.
996 (Attribute.CheckTargets): New method. It checks whether attribute
997 target is valid for the current element.
1000 (EventProperty): New class. For events that are declared like
1001 property (with add and remove accessors).
1002 (EventField): New class. For events that are declared like field.
1005 * cs-parser.jay: Implemented explicit attribute target declaration.
1007 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
1008 Override ValidAttributeTargets.
1011 (ReturnParameter): Class for applying custom attributes on
1013 (ParameterAtribute): New class. Class for applying custom
1014 attributes on the parameter type.
1016 2004-05-17 Miguel de Icaza <miguel@ximian.com>
1018 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
1021 (Method): Allow UNSAFE here.
1023 * modifiers.cs: Support unsafe reporting.
1025 2004-05-17 Marek Safar <marek.safar@seznam.cz>
1027 * decl.cs: Fix bug #58478.
1029 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1031 * statement.cs: When checking for unreachable code on an EmptyStatement,
1032 set the location. Fixes bug #58488.
1034 2004-05-13 Miguel de Icaza <miguel@ximian.com>
1036 * driver.cs: Add -pkg handling.
1038 From Gonzalo: UseShelLExecute=false
1040 2004-05-12 Marek Safar <marek.safar@seznam.cz>
1043 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
1045 (Attribute.IsClsCompliaceRequired): Moved to base for better
1047 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
1048 when attribute is AttributeUsageAttribute.
1049 (Attribute.GetValidTargets): Simplified.
1050 (Attribute.GetAttributeUsage): New method returns AttributeUsage
1051 attribute for this type.
1052 (Attribute.ApplyAttributes): Method renamed to Emit and make
1054 (GlobalAttributeSection): New class for special handling of global
1055 attributes (assembly, module).
1056 (AttributeSection.Emit): New method.
1058 * class.cs: Implemented Attributable abstract methods.
1059 (MethodCore.LabelParameters): Moved to Parameter class.
1060 (Accessor): Is back simple class.
1061 (PropertyMethod): Implemented Attributable abstract class.
1062 (DelegateMethod): Implemented Attributable abstract class.
1063 (Event): New constructor for disctintion between normal Event
1064 and Event with accessors.
1066 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
1068 * codegen.cs, const.cs, decl.cs, delegate.cs:
1069 (CommonAssemblyModulClass): Implemented Attributable abstract class
1072 * enum.cs: Implement IAttributeSupport interface.
1073 (EnumMember): New class for emum members. Implemented Attributable
1077 (ParameterBase): Is abstract.
1078 (ReturnParameter): New class for easier [return:] attribute handling.
1080 * typemanager.cs: Removed builder_to_attr.
1082 2004-05-11 Raja R Harinath <rharinath@novell.com>
1085 * attribute.cs (Attribute.GetPositionalValue): New function.
1086 * class.cs (TypeContainer.VerifyMembers): New function.
1087 (TypeContainer.Emit): Use it.
1088 (ClassOrStruct): New base class for Class and Struct.
1089 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
1090 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
1092 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
1093 then each non-static field should have a FieldOffset attribute.
1094 Otherwise, none of the fields should have a FieldOffset attribute.
1095 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
1096 and FieldOffset attributes.
1097 * typemanager.cs (TypeManager.struct_layout_attribute_type)
1098 (TypeManager.field_offset_attribute_type): New core types.
1099 (TypeManager.InitCoreTypes): Initialize them.
1101 2004-05-11 Michal Moskal <malekith@pld-linux.org>
1103 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
1104 Return correct type.
1107 2004-05-09 Miguel de Icaza <miguel@ximian.com>
1109 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
1110 be implicitly converted to ulong.
1112 * expression.cs: The logic for allowing operator &, | and ^ worked
1113 was wrong, it worked before because we did not report an error in
1114 an else branch. Fixes 57895.
1116 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
1117 allow volatile fields to be reference types.
1119 2004-05-07 Miguel de Icaza <miguel@ximian.com>
1121 * driver.cs: Add support for /debug-
1123 2004-05-07 Raja R Harinath <rharinath@novell.com>
1125 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
1126 Add a 'complain' parameter to silence errors.
1127 (Attribute.Resolve): Update to changes. Put in sanity check to catch
1128 silently overlooked type-resolutions.
1129 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
1131 (Attributes.Search): New function.
1132 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
1133 (Attributes.GetAttributeFullName): Remove hack.
1134 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
1135 Update to reflect changes.
1136 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1137 Use Attributes.Search instead of nested loops.
1139 2004-05-07 Marek Safar <marek.safar@seznam.cz>
1142 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
1143 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
1144 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
1146 * report.cs: (Report.Warning): Renamed to Warning_T because of
1147 parameter collision.
1149 2004-05-05 Raja R Harinath <rharinath@novell.com>
1151 * expression.cs (MemberAccess.ResolveMemberAccess):
1152 Exit with non-zero status after Report.Error.
1153 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
1155 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
1157 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1159 * support.cs: Don't hang when the file is empty.
1161 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1163 * support.cs: In SeekableStreamReader, compute the preamble size of the
1164 underlying stream. Position changes should take into account that initial
1167 2004-05-03 Todd Berman <tberman@sevenl.net>
1169 * driver.cs: remove unused GetSysVersion function.
1171 2004-05-03 Todd Berman <tberman@sevenl.net>
1173 * driver.cs: Remove the hack from saturday, as well as the hack
1174 from jackson (LoadAssemblyFromGac), also adds the CWD to the
1175 link_paths to get that bit proper.
1177 2004-05-01 Todd Berman <tberman@sevenl.net>
1179 * driver.cs: Try a LoadFrom before a Load, this checks the current
1180 path. This is currently a bug in mono that is be fixed, however, this
1181 provides a workaround for now. This will be removed when the bug
1184 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
1186 * CryptoConvert.cs: Updated to latest version. Fix issue with
1187 incomplete key pairs (#57941).
1189 2004-05-01 Todd Berman <tberman@sevenl.net>
1191 * driver.cs: Remove '.' from path_chars, now System.* loads properly
1194 2004-04-30 Jackson Harper <jackson@ximian.com>
1196 * codegen.cs: Open keys readonly.
1198 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1200 * typemanager.cs: don't report cyclic struct layout when a struct
1201 contains 2 or more fields of the same type. Failed for Pango.AttrShape
1202 which has 2 Pango.Rectangle fields.
1204 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
1206 * expression.cs: Handle IntPtr comparisons with IL code
1207 rather than a method call.
1209 2004-04-29 Martin Baulig <martin@ximian.com>
1211 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
1212 the list of PropertyInfo's in class hierarchy and find the
1213 accessor. Fixes #56013.
1215 2004-04-29 Martin Baulig <martin@ximian.com>
1217 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
1219 2004-04-29 Martin Baulig <martin@ximian.com>
1221 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1223 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
1225 2004-04-29 Martin Baulig <martin@ximian.com>
1227 * class.cs (ConstructorInitializer.Resolve): Check whether the
1228 parent .ctor is accessible. Fixes #52146.
1230 2004-04-29 Martin Baulig <martin@ximian.com>
1232 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1234 * statement.cs (Using.EmitLocalVariableDecls): Use
1235 TypeManager.idisposable_type, not typeof (IDisposable).
1236 (Foreach.EmitCollectionForeach): Added support for valuetypes.
1238 2004-04-29 Martin Baulig <martin@ximian.com>
1240 * class.cs (Event.Define): Don't emit the field and don't set
1241 RTSpecialName and SpecialName for events on interfaces. Fixes
1244 2004-04-29 Raja R Harinath <rharinath@novell.com>
1246 Refactor Attribute.ApplyAttributes.
1247 * attribute.cs (Attributable): New base class for objects that can
1248 have Attributes applied on them.
1249 (Attribute): Make AttributeUsage fields public.
1250 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
1251 (Attribute.IsInternalCall): New property.
1252 (Attribute.UsageAttr): Convert to a public read-only property.
1253 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
1254 (Attribute.ResolveType, Attribute.Resolve)
1255 (Attribute.ScanForIndexerName): Update to reflect changes.
1256 (Attribute.CheckAttributeTarget): Re-format.
1257 (Attribute.ApplyAttributes): Refactor, to various
1258 Attributable.ApplyAttributeBuilder methods.
1259 * decl.cs (MemberCore): Make Attributable.
1260 * class.cs (Accessor): Make Attributable.
1261 (MethodData.ApplyAttributes): Use proper attribute types, not
1263 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
1264 (TypeContainer.ApplyAttributeBuilder)
1265 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
1266 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
1267 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
1268 (Operator.ApplyAttributeBuilder): New factored-out methods.
1269 * const.cs (Const.ApplyAttributeBuilder): Likewise.
1270 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
1271 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
1272 * parameter.cs (ParameterBase): New Attributable base class
1273 that can also represent Return types.
1274 (Parameter): Update to the changes.
1276 2004-04-29 Jackson Harper <jackson@ximian.com>
1278 * driver.cs: Prefer the corlib system version when looking for
1279 assemblies in the GAC. This is still a hack, but its a better hack
1282 2004-04-29 Marek Safar <marek.safar@seznam.cz>
1284 * decl.cs, enum.cs: Improved error 3005 reporting.
1286 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
1287 (related_symbols): New private member for list of symbols
1288 related to reported error/warning.
1290 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
1292 2004-04-29 Martin Baulig <martin@ximian.com>
1294 * ecore.cs (Expression.Constantify): If we're an enum and
1295 TypeManager.TypeToCoreType() doesn't give us another type, use
1296 t.UnderlyingSystemType. Fixes #56178.
1298 2004-04-29 Martin Baulig <martin@ximian.com>
1300 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
1301 interfaces and for each interface, only add members directly
1302 declared in that interface. Fixes #53255.
1304 2004-04-28 Martin Baulig <martin@ximian.com>
1306 * expression.cs (ConditionalLogicalOperator): Use a temporary
1307 variable for `left' to avoid that we evaluate it more than once;
1310 2004-04-28 Martin Baulig <martin@ximian.com>
1312 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
1315 2004-04-28 Martin Baulig <martin@ximian.com>
1317 * statement.cs (LocalInfo.Resolve): Check whether the type is not
1320 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
1321 whether the type is not void (CS1547).
1323 2004-04-28 Martin Baulig <martin@ximian.com>
1325 * expression.cs (Unary.DoResolveLValue): Override this and report
1326 CS0131 for anything but Operator.Indirection.
1328 2004-04-28 Martin Baulig <martin@ximian.com>
1330 Committing a patch from Ben Maurer; see bug #50820.
1332 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1335 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1338 2004-04-28 Martin Baulig <martin@ximian.com>
1340 Committing a patch from Ben Maurer; see bug #50820.
1342 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1345 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1348 2004-04-28 Martin Baulig <martin@ximian.com>
1350 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
1351 (Block.AddLabel): Call DoLookupLabel() to only search in the
1354 2004-04-28 Martin Baulig <martin@ximian.com>
1356 * cfold.cs (ConstantFold.BinaryFold): Added special support for
1357 comparing StringConstants and NullLiterals in Equality and Inequality.
1359 2004-04-28 Jackson Harper <jackson@ximian.com>
1361 * driver.cs: Attempt to load referenced assemblies from the
1362 GAC. This is the quick and dirty version of this method that
1363 doesnt take into account versions and just takes the first
1364 canidate found. Will be good enough for now as we will not have more
1365 then one version installed into the GAC until I update this method.
1367 2004-04-28 Martin Baulig <martin@ximian.com>
1369 * typemanager.cs (TypeManager.CheckStructCycles): New public
1370 static method to check for cycles in the struct layout.
1372 * rootcontext.cs (RootContext.PopulateTypes): Call
1373 TypeManager.CheckStructCycles() for each TypeContainer.
1374 [Note: We only need to visit each type once.]
1376 2004-04-28 Martin Baulig <martin@ximian.com>
1378 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
1380 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
1381 success and added `out object value'. Use a `bool resolved' field
1382 to check whether we've already been called rather than
1383 `ConstantValue != null' since this breaks for NullLiterals.
1385 2004-04-28 Raja R Harinath <rharinath@novell.com>
1387 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
1388 setting of this flag, since the 'set' method may be non-public.
1390 2004-04-28 Raja R Harinath <rharinath@novell.com>
1392 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
1393 check on current_vector.Block.
1395 2004-04-27 Martin Baulig <martin@ximian.com>
1397 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
1398 a field initializer. Fixes #56459.
1400 2004-04-27 Martin Baulig <martin@ximian.com>
1402 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
1403 we're not attempting to use an indexer. Fixes #52154.
1405 2004-04-27 Martin Baulig <martin@ximian.com>
1407 * statement.cs (Return): Don't create a return label if we don't
1408 need it; reverts my change from January 20th. Thanks to Ben
1411 2004-04-27 Martin Baulig <martin@ximian.com>
1413 According to the spec, `goto' can only leave a nested scope, but
1416 * statement.cs (Block.LookupLabel): Only lookup in the current
1417 block, don't recurse into parent or child blocks.
1418 (Block.AddLabel): Check in parent and child blocks, report
1419 CS0140/CS0158 if we find a duplicate.
1420 (Block): Removed this indexer for label lookups.
1421 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
1422 this already does the error reporting for us.
1425 (FlowBranching.UsageVector.Block): New public variable; may be null.
1426 (FlowBranching.CreateSibling): Added `Block' argument.
1427 (FlowBranching.LookupLabel): New public virtual method. Lookup a
1428 label for the target of a `goto' and check whether we're not
1429 leaving a `finally'.
1431 2004-04-27 Martin Baulig <martin@ximian.com>
1433 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1434 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
1437 2004-04-27 Martin Baulig <martin@ximian.com>
1439 * statement.cs (Block.AddLabel): Also check for implicit blocks
1440 and added a CS0158 check.
1442 2004-04-27 Martin Baulig <martin@ximian.com>
1444 * flowanalysis.cs (FlowBranchingLoop): New class.
1445 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
1446 UsageVector's instead of an ArrayList.
1447 (FlowBranching.Label): Likewise.
1448 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
1449 (FlowBranching.AddBreakVector): New method.
1451 2004-04-27 Miguel de Icaza <miguel@ximian.com>
1453 * attribute.cs: Small regression fix: only convert the type if we
1454 the type is different, fixes System.Drawing build.
1456 2004-04-27 Martin Baulig <martin@ximian.com>
1458 * attribute.cs (Attribute.Resolve): If we have a constant value
1459 for a named field or property, implicity convert it to the correct
1462 2004-04-27 Raja R Harinath <rharinath@novell.com>
1464 * statement.cs (Block.Block): Implicit blocks share
1465 'child_variable_names' fields with parent blocks.
1466 (Block.AddChildVariableNames): Remove.
1467 (Block.AddVariable): Mark variable as "used by a child block" in
1468 every surrounding block.
1469 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
1470 been used in a child block, complain about violation of "Invariant
1471 meaning in blocks" rule.
1472 * cs-parser.jay (declare_local_variables): Don't use
1473 AddChildVariableNames.
1474 (foreach_statement): Don't create an implicit block: 'foreach'
1477 2004-04-23 Miguel de Icaza <miguel@ximian.com>
1479 * convert.cs (ImplicitNumericConversion): 0 is also positive when
1480 converting from 0L to ulong. Fixes 57522.
1482 2004-04-22 Marek Safar <marek.safar@seznam.cz>
1484 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
1485 derived class hides via 'new' keyword field from base class (test-242.cs).
1486 TODO: Handle this in the more general way.
1488 * class.cs (CheckBase): Ditto.
1490 2004-04-22 Marek Safar <marek.safar@seznam.cz>
1492 * decl.cs (caching_flags): New member for storing cached values
1494 (MemberCore.Flags): New enum where bit flags for caching_flags
1496 (MemberCore.cls_compliance): Moved to caching_flags.
1497 (DeclSpace.Created): Moved to caching_flags.
1499 * class.cs: Use caching_flags instead of DeclSpace.Created
1501 2004-04-21 Miguel de Icaza <miguel@ximian.com>
1503 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
1504 if we are only a derived class, not a nested class.
1506 * typemanager.cs: Same as above, but do this at the MemberLookup
1507 level (used by field and methods, properties are handled in
1508 PropertyExpr). Allow for the qualified access if we are a nested
1511 2004-04-21 Marek Safar <marek.safar@seznam.cz>
1513 * class.cs: Refactoring.
1514 (IMethodData): New inteface; Holds links to parent members
1515 to avoid member duplication (reduced memory allocation).
1516 (Method): Implemented IMethodData interface.
1517 (PropertyBase): New inner classes for get/set methods.
1518 (PropertyBase.PropertyMethod): Implemented IMethodData interface
1519 (Event): New inner classes for add/remove methods.
1520 (Event.DelegateMethod): Implemented IMethodData interface.
1522 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
1523 EmitContext (related to class.cs refactoring).
1525 2004-04-21 Raja R Harinath <rharinath@novell.com>
1527 * delegate.cs (Delegate.VerifyApplicability): If the number of
1528 arguments are the same as the number of parameters, first try to
1529 verify applicability ignoring any 'params' modifier on the last
1533 2004-04-16 Raja R Harinath <rharinath@novell.com>
1535 * class.cs (TypeContainer.AddIndexer): Use
1536 'ExplicitInterfaceName' to determine if interface name was
1537 explicitly specified. 'InterfaceType' is not initialized at this time.
1538 (TypeContainer.DefineIndexers): Remove use of temporary list. The
1539 Indexers array is already in the required order. Initialize
1540 'IndexerName' only if there are normal indexers.
1541 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
1542 (TypeContainer.Emit): Emit DefaultMember attribute only if
1543 IndexerName is initialized.
1546 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
1548 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
1551 2004-04-15 Raja R Harinath <rharinath@novell.com>
1553 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
1557 * attribute.cs (Attribute.Resolve): Check for duplicate named
1561 2004-04-15 Miguel de Icaza <miguel@ximian.com>
1563 * iterators.cs (MarkYield): track whether we are in an exception,
1564 and generate code accordingly. Use a temporary value to store the
1565 result for our state.
1567 I had ignored a bit the interaction of try/catch with iterators
1568 since their behavior was not entirely obvious, but now it is
1569 possible to verify that our behavior is the same as MS .NET 2.0
1573 2004-04-14 Miguel de Icaza <miguel@ximian.com>
1575 * iterators.cs: Avoid creating temporaries if there is no work to
1578 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
1579 Enumerations, use TypeManager.EnumToUnderlying and call
1582 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
1585 (This.Emit): Use EmitContext.EmitThis to emit our
1588 (This.EmitAssign): Ditto.
1590 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
1591 codepaths, we will move all the functionality into
1594 (FieldExpr.EmitAssign): Ditto.
1596 This fixes several hidden bugs that I uncovered while doing a code
1597 review of this today.
1599 * codegen.cs (EmitThis): reworked so the semantics are more clear
1600 and also support value types "this" instances.
1602 * iterators.cs: Changed so that for iterators in value types, we
1603 do not pass the value type as a parameter.
1605 Initialization of the enumerator helpers is now done in the caller
1606 instead of passing the parameters to the constructors and having
1607 the constructor set the fields.
1609 The fields have now `assembly' visibility instead of private.
1611 2004-04-11 Miguel de Icaza <miguel@ximian.com>
1613 * expression.cs (Argument.Resolve): Check if fields passed as ref
1614 or out are contained in a MarshalByRefObject.
1616 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
1617 another compiler type.
1619 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
1621 * class.cs (Indexer.Define): use the new name checking method.
1622 Also, return false on an error.
1623 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
1624 (is_identifier_[start/part]_character): make static.
1626 2004-04-10 Miguel de Icaza <miguel@ximian.com>
1628 * expression.cs (Binary.ResolveOperator): Do no append strings
1629 twice: since we can be invoked more than once (array evaluation)
1630 on the same concatenation, take care of this here. Based on a fix
1631 from Ben (bug #56454)
1633 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
1635 * codegen.cs: Fix another case where CS1548 must be reported (when
1636 delay-sign isn't specified and no private is available #56564). Fix
1637 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
1638 error when MCS is used on the MS runtime and we need to delay-sign
1639 (which seems unsupported by AssemblyBuilder - see #56621).
1641 2004-04-08 Marek Safar <marek.safar@seznam.cz>
1643 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
1644 (TypeManager.ComputeNamespaces): Faster implementation for
1647 * compiler.csproj: Updated AssemblyName to mcs.
1649 2004-04-07 Miguel de Icaza <miguel@ximian.com>
1651 * rootcontext.cs: Add new types to the boot resolution.
1653 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
1654 MulticastDelegate is not allowed.
1656 * typemanager.cs: Add new types to lookup: System.TypedReference
1659 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
1660 check for TypedReference or ArgIterator, they are not allowed.
1662 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
1663 makes us properly catch 1510 in some conditions (see bug 56016 for
1666 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
1668 * CryptoConvert.cs: update from corlib version
1671 2004-04-05 Miguel de Icaza <miguel@ximian.com>
1673 * class.cs (Indexer.Define): Check indexername declaration
1675 2004-04-05 Marek Safar <marek.safar@seznam.cz>
1677 * attribute.cs (IsClsCompliant): Fixed problem with handling
1678 all three states (compliant, not-compliant, undetected).
1680 2004-03-30 Marek Safar <marek.safar@seznam.cz>
1682 * attribute.cs (Attribute): Location is now public.
1683 (Resolve): Store resolved arguments (pos_values) in attribute class.
1684 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
1685 (GetClsCompliantAttributeValue): New method that gets
1686 CLSCompliantAttribute value.
1687 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
1688 if exists else null.
1689 (AttributeTester): New class for CLS-Compliant verification routines.
1691 * class.cs (Emit): Add CLS-Compliant verification.
1692 (Method.GetSignatureForError): Implemented.
1693 (Constructor.GetSignatureForError): Implemented
1694 (Constructor.HasCompliantArgs): Returns if constructor has
1695 CLS-Compliant arguments.
1696 (Constructor.Emit): Override.
1697 (Construcor.IsIdentifierClsCompliant): New method; For constructors
1698 is needed to test only parameters.
1699 (FieldBase.GetSignatureForError): Implemented.
1700 (TypeContainer): New member for storing base interfaces.
1701 (TypeContainer.FindMembers): Search in base interfaces too.
1703 * codegen.cs (GetClsComplianceAttribute): New method that gets
1704 assembly or module CLSCompliantAttribute value.
1705 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
1707 (ModuleClass.Emit): Add error 3012 test.
1709 * const.cs (Emit): Override and call base for CLS-Compliant tests.
1711 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
1712 state for all decl types.
1713 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
1714 if CLS-Compliant tests are required.
1715 (IsClsCompliaceRequired): New method. Analyze whether code
1716 must be CLS-Compliant.
1717 (IsExposedFromAssembly): New method. Returns true when MemberCore
1718 is exposed from assembly.
1719 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
1720 value or gets cached value.
1721 (HasClsCompliantAttribute): New method. Returns true if MemberCore
1722 is explicitly marked with CLSCompliantAttribute.
1723 (IsIdentifierClsCompliant): New abstract method. This method is
1724 used to testing error 3005.
1725 (IsIdentifierAndParamClsCompliant): New method. Common helper method
1726 for identifier and parameters CLS-Compliant testing.
1727 (VerifyClsCompliance): New method. The main virtual method for
1728 CLS-Compliant verifications.
1729 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
1730 null. I don't know why is null (too many public members !).
1731 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
1732 and get value of first CLSCompliantAttribute that found.
1734 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
1735 (VerifyClsCompliance): Override and add extra tests.
1737 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
1738 clscheck- disable CLS-Compliant verification event if assembly is has
1739 CLSCompliantAttribute(true).
1741 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
1742 ApllyAttribute is now called in emit section as in the other cases.
1743 Possible future Emit integration.
1744 (IsIdentifierClsCompliant): New override.
1745 (VerifyClsCompliance): New override.
1746 (GetEnumeratorName): Returns full enum name.
1748 * parameter.cs (GetSignatureForError): Implemented.
1750 * report.cs (WarningData): New struct for Warning message information.
1751 (LocationOfPreviousError): New method.
1752 (Warning): New method. Reports warning based on the warning table.
1753 (Error_T): New method. Reports error based on the error table.
1755 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
1756 verifications are done here.
1758 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
1760 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
1761 CLSCompliantAttribute.
1762 (all_imported_types): New member holds all imported types from other
1764 (LoadAllImportedTypes): New method fills static table with exported types
1765 from all referenced assemblies.
1766 (Modules): New property returns all assembly modules.
1768 2004-03-30 Miguel de Icaza <miguel@ximian.com>
1770 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
1771 throwing a parser error.
1773 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
1774 which removes the hardcoded get_/set_ prefixes for properties, as
1775 IL allows for the properties to be named something else.
1779 * expression.cs: Do not override operand before we know if it is
1782 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1784 * typemanager.cs: support for pinned variables.
1786 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1788 * decl.cs, typemanager.cs: Avoid using an arraylist
1789 as a buffer if there is only one result set.
1791 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1793 * expression.cs: Make sure you cant call a static method
1794 with an instance expression, bug #56174.
1796 2004-03-29 Miguel de Icaza <miguel@ximian.com>
1798 * class.cs (IsDuplicateImplementation): Improve error reporting to
1799 flag 663 (method only differs in parameter modifier).
1801 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
1802 in preprocessor directives.
1804 * location.cs (LookupFile): Allow for the empty path.
1806 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
1807 better approach for some of that patch, but its failing with the
1808 CharSet enumeration. For now try/catch will do.
1810 * typemanager.cs: Do not crash if a struct does not have fields.
1813 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1815 * expression.cs: cs0213, cant fix a fixed expression.
1818 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1820 * cs-parser.jay: detect invalid embeded statements gracefully.
1823 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1825 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
1828 the invocation type may not be a subclass of the tye of the item/
1829 The type of the item must be a subclass of the invocation item.
1834 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
1836 * attribute.cs: Added methods to get a string and a bool from an
1837 attribute. Required to information from AssemblyKeyFileAttribute,
1838 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
1839 * codegen.cs: Modified AssemblyName creation to include support for
1840 strongnames. Catch additional exceptions to report them as CS1548.
1841 * compiler.csproj: Updated include CryptoConvert.cs.
1842 * compiler.csproj.user: Removed file - user specific configuration.
1843 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
1844 Mono.Security assembly. The original class is maintained and tested in
1845 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
1846 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
1847 like CSC 8.0 (C# v2) supports.
1848 * Makefile: Added CryptoConvert.cs to mcs sources.
1849 * rootcontext.cs: Added new options for strongnames.
1851 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
1853 * driver.cs: For --expect-error, report error code `2'
1854 if the program compiled with no errors, error code `1' if
1855 it compiled with an error other than the one expected.
1857 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
1859 * compiler.csproj: Updated for Visual Studio .NET 2003.
1860 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
1861 * compiler.sln: Updated for Visual Studio .NET 2003.
1863 2004-03-24 Ravi Pratap M <ravi@ximian.com>
1865 * expression.cs: Fix bug #47234. We basically need to apply the
1866 rule that we prefer the conversion of null to a reference type
1867 when faced with a conversion to 'object' (csc behaviour).
1869 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1871 * statement.cs: Shorter form for foreach, eliminates
1872 a local variable. r=Martin.
1874 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1876 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
1877 checks if we can use brtrue/brfalse to test for 0.
1878 * expression.cs: use the above in the test for using brtrue/brfalse.
1881 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1883 * expression.cs: Rewrite string concat stuff. Benefits:
1885 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
1886 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
1887 rather than a concat chain.
1889 * typemanager.cs: Add lookups for more concat overloads.
1891 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1893 * expression.cs: Emit shorter il code for array init.
1910 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
1912 * statement.cs: Before, two switch blocks would be merged if the
1913 total size of the blocks (end_item - begin_item + 1) was less than
1914 two times the combined sizes of the blocks.
1916 Now, it will only merge if after the merge at least half of the
1921 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
1923 * class.cs : csc build fix for GetMethods(). See bug #52503.
1925 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
1927 * expression.cs: Make sure fp comparisons work with NaN.
1928 This fixes bug #54303. Mig approved this patch a long
1929 time ago, but we were not able to test b/c the runtime
1932 2004-03-19 Miguel de Icaza <miguel@ximian.com>
1934 * ecore.cs (TypExpr.GetHashCode): implement this overload.
1936 2004-03-19 Martin Baulig <martin@ximian.com>
1938 * class.cs (MemberCore.IsDuplicateImplementation): Report the
1939 error here and not in our caller.
1941 2004-03-19 Martin Baulig <martin@ximian.com>
1943 * interface.cs: Completely killed this file.
1944 (Interface): We're now a TypeContainer and live in class.cs.
1946 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
1947 argument; we're now also called for interfaces.
1948 (TypeContainer.DefineMembers): Allow this method being called
1950 (TypeContainer.GetMethods): New public method; formerly known as
1951 Interface.GetMethod(). This is used by PendingImplementation.
1952 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
1953 it's now private and non-static.
1954 (Interface): Moved this here; it's now implemented similar to
1956 (Method, Property, Event, Indexer): Added `bool is_interface'
1957 argument to their .ctor's.
1958 (MemberBase.IsInterface): New public field.
1960 * cs-parser.jay: Create normal Method, Property, Event, Indexer
1961 instances instead of InterfaceMethod, InterfaceProperty, etc.
1962 (opt_interface_base): Removed; we now use `opt_class_base' instead.
1963 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
1965 2004-03-19 Martin Baulig <martin@ximian.com>
1967 * class.cs (MethodCore.IsDuplicateImplementation): New private
1968 method which does the CS0111 checking.
1969 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
1970 Use IsDuplicateImplementation().
1972 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
1974 * decl.cs (FindMemberToOverride): New method to find the correct
1975 method or property to override in the base class.
1977 - Make Method/Property use the above method to find the
1978 version in the base class.
1979 - Remove the InheritableMemberSignatureCompare as it is now
1982 This patch makes large code bases much faster to compile, as it is
1983 O(n) rather than O(n^2) to do this validation.
1985 Also, it fixes bug 52458 which is that nested classes are not
1986 taken into account when finding the base class member.
1988 Reviewed/Approved by Martin.
1990 2004-03-17 Marek Safar <marek.safar@seznam.cz>
1992 * interface.cs: In all interface classes removed redundant
1993 member initialization.
1995 2004-03-16 Martin Baulig <martin@ximian.com>
1997 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
1999 2004-03-15 Miguel de Icaza <miguel@ximian.com>
2001 * decl.cs (DefineTypeAndParents): New helper method to define a
2002 type's containers before the type itself is defined; This is a
2003 bug exposed by the recent changes to Windows.Forms when an
2004 implemented interface was defined inside a class that had not been
2007 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
2009 (Check): Loop correctly to report errors modifiers
2010 (UNSAFE was not in the loop, since it was the same as TOP).
2012 * interface.cs: Every interface member now takes a ModFlags,
2013 instead of a "is_new" bool, which we set on the base MemberCore.
2015 Every place where we called "UnsafeOk" in the interface, now we
2016 call the proper member (InterfaceMethod.UnsafeOK) instead to get
2017 the unsafe settings from the member declaration instead of the
2018 container interface.
2020 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
2022 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
2023 `set_indexer_name' to the pending bits (one per type).
2025 We fixed a bug today that was picking the wrong method to
2026 override, since for properties the existing InterfaceMethod code
2027 basically ignored the method name. Now we make sure that the
2028 method name is one of the valid indexer names.
2030 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
2032 * support.cs (SeekableStreamReader): Keep track of stream byte
2033 positions and don't mix them with character offsets to the buffer.
2035 Patch from Gustavo Giráldez
2037 2004-03-15 Marek Safar <marek.safar@seznam.cz>
2039 * interface.cs (InterfaceSetGetBase): Removed double member
2040 initialization, base class does it as well.
2042 2004-03-13 Martin Baulig <martin@ximian.com>
2044 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
2045 when compiling corlib.
2047 2004-03-13 Miguel de Icaza <miguel@ximian.com>
2049 * convert.cs (ExplicitConversion): We were reporting an error on
2050 certain conversions (object_type source to a value type, when the
2051 expression was `null') before we had a chance to pass it through
2052 the user defined conversions.
2054 * driver.cs: Replace / and \ in resource specifications to dots.
2057 * class.cs: Add check for duplicate operators. Fixes 52477
2059 2004-03-11 Miguel de Icaza <miguel@ximian.com>
2061 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
2062 that are in the middle of the statements, not only at the end.
2065 * class.cs (TypeContainer.AddField): No longer set the
2066 `HaveStaticConstructor' flag, now we call it
2067 `UserDefineStaticConstructor' to diferentiate the slightly
2068 semantic difference.
2070 The situation is that we were not adding BeforeFieldInit (from
2071 Modifiers.TypeAttr) to classes that could have it.
2072 BeforeFieldInit should be set to classes that have no static
2077 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
2079 And most importantly Zoltan's comment:
2081 http://bugzilla.ximian.com/show_bug.cgi?id=44229
2083 "I think beforefieldinit means 'it's ok to initialize the type sometime
2084 before its static fields are used', i.e. initialization does not need
2085 to be triggered by the first access to the type. Setting this flag
2086 helps the JIT to compile better code, since it can run the static
2087 constructor at JIT time, and does not need to generate code to call it
2088 (possibly lots of times) at runtime. Unfortunately, mcs does not set
2089 this flag for lots of classes like String.
2091 csc sets this flag if the type does not have an explicit static
2092 constructor. The reasoning seems to be that if there are only static
2093 initalizers for a type, and no static constructor, then the programmer
2094 does not care when this initialization happens, so beforefieldinit
2097 This bug prevents the AOT compiler from being usable, since it
2098 generates so many calls to mono_runtime_class_init that the AOT code
2099 is much slower than the JITted code. The JITted code is faster,
2100 because it does not generate these calls if the vtable is type is
2101 already initialized, which is true in the majority of cases. But the
2102 AOT compiler can't do this."
2104 2004-03-10 Miguel de Icaza <miguel@ximian.com>
2106 * class.cs (MethodData.Emit): Refactor the code so symbolic
2107 information is generated for destructors; For some reasons we
2108 were taking a code path that did not generate symbolic information
2111 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
2113 * class.cs: Create a Constructor.CheckBase method that
2114 takes care of all validation type code. The method
2115 contains some code that was moved from Define.
2117 It also includes new code that checks for duplicate ctors.
2118 This fixes bug #55148.
2120 2004-03-09 Joshua Tauberer <tauberer@for.net>
2122 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
2123 a { ... }-style array creation invokes EmitStaticInitializers
2124 which is not good for reference-type arrays. String, decimal
2125 and now null constants (NullCast) are not counted toward
2126 static initializers.
2128 2004-03-05 Martin Baulig <martin@ximian.com>
2130 * location.cs (SourceFile.HasLineDirective): New public field;
2131 specifies whether the file contains or is referenced by a "#line"
2133 (Location.DefineSymbolDocuments): Ignore source files which
2134 either contain or are referenced by a "#line" directive.
2136 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
2138 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
2139 direct access to our parent, so check the method inline there.
2141 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
2143 * expression.cs (Invocation.EmitCall): Miguel's last commit
2144 caused a regression. If you had:
2149 In Foo the implict this would be null.
2151 2004-02-27 Miguel de Icaza <miguel@ximian.com>
2153 * expression.cs (Invocation.EmitCall): If the method is not
2154 virtual, do not emit a CallVirt to it, use Call.
2156 * typemanager.cs (GetFullNameSignature): Improve the method to
2157 cope with ".ctor" and replace it with the type name.
2159 * class.cs (ConstructorInitializer.Resolve): Now the method takes
2160 as an argument the ConstructorBuilder where it is being defined,
2161 to catch the recursive constructor invocations.
2163 2004-02-26 Miguel de Icaza <miguel@ximian.com>
2165 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
2166 routines to check if a type is an enumerable/enumerator allow
2167 classes that implement the IEnumerable or IEnumerator interfaces.
2169 * class.cs (Property, Operator): Implement IIteratorContainer, and
2170 implement SetYields.
2172 (Property.Define): Do the block swapping for get_methods in the
2173 context of iterators. We need to check if Properties also
2174 include indexers or not.
2176 (Operator): Assign the Block before invoking the
2177 OperatorMethod.Define, so we can trigger the Iterator code
2180 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
2181 Property and Operator classes are not created when we parse the
2182 declarator but until we have the block completed, so we use a
2183 singleton SimpleIteratorContainer.Simple to flag whether the
2184 SetYields has been invoked.
2186 We propagate this setting then to the Property or the Operator to
2187 allow the `yield' to function.
2189 2004-02-25 Marek Safar <marek.safar@seznam.cz>
2191 * codegen.cs: Implemented attribute support for modules.
2192 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
2193 Assembly/Module functionality.
2195 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
2196 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
2197 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
2199 2004-02-16 Marek Safar <marek.safar@seznam.cz>
2201 * interface.cs (FindMembers): The operation is performed on all base
2202 interfaces and not only on the first. It is required for future CLS Compliance patch.
2204 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
2206 * statement.cs, codegen.cs:
2207 This patch deals with patterns such as:
2209 public class List : IEnumerable {
2211 public MyEnumerator GetEnumerator () {
2212 return new MyEnumerator(this);
2215 IEnumerator IEnumerable.GetEnumerator () {
2219 public struct MyEnumerator : IEnumerator {
2224 Before, there were a few things we did wrong:
2225 1) we would emit callvirt on a struct, which is illegal
2226 2) we emited ldarg when we needed to emit ldarga
2227 3) we would mistakenly call the interface methods on an enumerator
2228 type that derived from IEnumerator and was in another assembly. For example:
2230 public class MyEnumerator : IEnumerator
2232 Would have the interface methods called, even if there were public impls of the
2233 method. In a struct, this lead to invalid IL code.
2235 2004-02-11 Marek Safar <marek.safar@seznam.cz>
2237 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
2240 * delegate.cs (Define): Fixed crash when delegate type is undefined.
2242 2004-02-11 Miguel de Icaza <miguel@ximian.com>
2244 * cs-parser.jay: Fix small regression: we were not testing V2
2245 compiler features correctly.
2247 * interface.cs: If the emit context is null, then create one
2249 2004-02-09 Marek Safar <marek.safar@seznam.cz>
2251 * decl.cs (GetSignatureForError): New virtual method to get full name
2254 * attribute.cs (IAttributeSupport): New interface for attribute setting.
2255 Now it is possible to rewrite ApplyAttributes method to be less if/else.
2257 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
2258 Duplicated members and code in these classes has been removed.
2259 Better encapsulation in these classes.
2261 2004-02-07 Miguel de Icaza <miguel@ximian.com>
2263 * assign.cs (Assign.DoResolve): When dealing with compound
2264 assignments, there is a new rule in ECMA C# 2.4 (might have been
2265 there before, but it is documented here) that states that in:
2269 If b is of type int, and the `op' is a shift-operator, then the
2270 above is evaluated as:
2274 * expression.cs (Binary.ResolveOperator): Instead of testing for
2275 int/uint/long/ulong, try to implicitly convert to any of those
2276 types and use that in pointer arithmetic.
2278 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
2279 method to print information for from the type, not from the
2280 null-method we were given.
2282 2004-02-01 Duncan Mak <duncan@ximian.com>
2284 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
2285 parsing for cmd, fixes bug #53694.
2287 2004-02-04 Marek Safar <marek.safar@seznam.cz>
2289 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
2290 in the member name duplication tests. Property and operator name duplication
2291 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
2293 2004-02-03 Marek Safar <marek.safar@seznam.cz>
2295 * interface.cs (PopulateMethod): Fixed crash when interface method
2296 returns not existing type (error test cs0246-3.cs).
2298 2004-02-02 Ravi Pratap M <ravi@ximian.com>
2300 * cs-parser.jay (interface_accessors): Re-write actions to also
2301 store attributes attached to get and set methods. Fix spelling
2304 (inteface_property_declaration): Modify accordingly.
2306 (InterfaceAccessorInfo): New helper class to store information to pass
2307 around between rules that use interface_accessors.
2309 * interface.cs (Emit): Apply attributes on the get and set
2310 accessors of properties and indexers too.
2312 * attribute.cs (ApplyAttributes): Modify accordingly to use the
2313 right MethodBuilder when applying attributes to the get and set accessors.
2315 2004-01-31 Miguel de Icaza <miguel@ximian.com>
2317 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
2319 2004-01-26 Miguel de Icaza <miguel@ximian.com>
2321 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
2323 2004-01-25 Miguel de Icaza <miguel@ximian.com>
2325 * cs-parser.jay: Remove YIELD token, instead use the new grammar
2326 changes that treat `yield' specially when present before `break'
2329 * cs-tokenizer.cs: yield is no longer a keyword.
2331 2004-01-23 Marek Safar <marek.safar@seznam.cz>
2333 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
2334 setting for default constructors.
2335 For default constructors are almost every time set wrong Modifier. The
2336 generated IL code has been alright. But inside mcs this values was
2337 wrong and this was reason why several of my CLS Compliance tests
2340 2004-01-22 Martin Baulig <martin@ximian.com>
2342 * cs-parser.jay (namespace_or_type_name): Return an Expression,
2343 not a QualifiedIdentifier. This is what `type_name_expression'
2344 was previously doing.
2345 (type_name_expression): Removed; the code is now in
2346 `namespace_or_type_name'.
2347 (qualified_identifier): Removed, use `namespace_or_type_name'
2349 (QualifiedIdentifier): Removed this class.
2351 2004-01-22 Martin Baulig <martin@ximian.com>
2353 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
2354 not a string as alias name.
2356 2004-01-21 Miguel de Icaza <miguel@ximian.com>
2358 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
2359 #52730 bug, and instead compute correctly the need to use a
2360 temporary variable when requesting an address based on the
2361 static/instace modified of the field and the constructor.
2363 2004-01-21 Martin Baulig <martin@ximian.com>
2365 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
2366 class and namespace before looking up aliases. Fixes #52517.
2368 2004-01-21 Martin Baulig <martin@ximian.com>
2370 * flowanalysis.cs (UsageVector.Merge): Allow variables being
2371 assinged in a 'try'; fixes exception4.cs.
2373 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2374 * class.cs : Implemented parameter-less constructor for TypeContainer
2376 * decl.cs: Attributes are now stored here. New property OptAttributes
2378 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
2380 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
2382 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2384 * typemanager.cs (CSharpSignature): Now reports also inner class name.
2385 (CSharpSignature): New method for indexer and property signature.
2387 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2389 * pending.cs (IsVirtualFilter): Faster implementation.
2391 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2393 * typemanager.cs: Avoid inclusion of same assembly more than once.
2395 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2397 * cs-parser.jay: Fixed problem where the last assembly attribute
2398 has been applied also to following declaration (class, struct, etc.)
2400 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2402 * class.cs: Added error CS0538, CS0539 reporting.
2403 Fixed crash on Microsoft runtime when field type is void.
2405 * cs-parser.jay: Added error CS0537 reporting.
2407 * pending.cs: Added error CS0535 reporting.
2408 Improved error report for errors CS0536, CS0534.
2410 2004-01-20 Miguel de Icaza <miguel@ximian.com>
2412 Merge a few bits from the Anonymous Method MCS tree.
2414 * statement.cs (ToplevelBlock): New class for toplevel methods,
2415 will hold anonymous methods, lifted variables.
2417 * cs-parser.jay: Create toplevel blocks for delegates and for
2418 regular blocks of code.
2420 2004-01-20 Martin Baulig <martin@ximian.com>
2422 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
2423 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
2424 and `NeedExplicitReturn'; added `IsLastStatement'.
2425 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
2426 have a `ReturnLabel' or we're not unreachable.
2428 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
2429 child's reachability; don't just override ours with it. Fixes
2430 #58058 (lluis's example).
2431 (FlowBranching): Added public InTryOrCatch(), InCatch(),
2432 InFinally(), InLoop(), InSwitch() and
2433 BreakCrossesTryCatchBoundary() methods.
2435 * statement.cs (Return): Do all error checking in Resolve().
2436 Unless we are the last statement in a top-level block, always
2437 create a return label and jump to it.
2438 (Break, Continue): Do all error checking in Resolve(); also make
2439 sure we aren't leaving a `finally'.
2440 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
2441 statement in a top-level block.
2442 (Block.Flags): Added `IsDestructor'.
2443 (Block.IsDestructor): New public property.
2445 2004-01-20 Martin Baulig <martin@ximian.com>
2447 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
2449 2004-01-20 Martin Baulig <martin@ximian.com>
2451 * statement.cs (Statement.ResolveUnreachable): New public method.
2452 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
2453 (Block.Resolve): Resolve unreachable statements.
2455 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
2457 * expression.cs: We need to fix the case where we do
2458 not have a temp variable here.
2460 * assign.cs: Only expression compound assignments need
2461 temporary variables.
2463 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
2465 * flowanalysis.cs: Reduce memory allocation in a few ways:
2466 - A block with no variables should not allocate a bit
2468 - A method with no out parameters does not need any tracking
2469 for assignment of the parameters, so we need not allocate
2472 public readonly Type[] VariableTypes;
2473 public readonly string[] VariableNames;
2474 Are redundant. The data is already stored in the variable
2475 map, so we need not allocate another array for it.
2476 - We need to add alot of checks for if (params | locals) == null
2477 due to the first two changes.
2479 2004-01-18 Miguel de Icaza <miguel@ximian.com>
2481 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
2482 implement IMemoryLocation, we store a copy on a local variable and
2483 take the address of it. Patch from Benjamin Jemlich
2485 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
2486 to use a special "type_name_expression" rule which reduces the
2487 number of "QualifiedIdentifier" classes created, and instead
2488 directly creates MemberAccess expressions.
2490 2004-01-17 Miguel de Icaza <miguel@ximian.com>
2492 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
2493 that fixes #52853. Null literal assignment to ValueType
2495 * class.cs (MethodData.Emit): Instead of checking the name of the
2496 method to determine if its a destructor, create a new derived
2497 class from Method called Destructor, and test for that.
2499 * cs-parser.jay: Create a Destructor object instead of a Method.
2501 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
2505 2004-01-16 Miguel de Icaza <miguel@ximian.com>
2507 * expression.cs (Binary.ResolveOperator): Perform an implicit
2508 conversion from MethodGroups to their delegate types on the
2511 * delegate.cs: Introduce a new class DelegateCreation that is the
2512 base class for `NewDelegate' and `ImplicitDelegateCreation',
2513 factor some code in here.
2515 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
2516 conversion from MethodGroups to compatible delegate types.
2518 * ecore.cs (Expression.Resolve): Do not flag error 654
2519 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
2520 we allow conversions from MethodGroups to delegate types now.
2522 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
2523 assignments in v2 either.
2525 2004-01-10 Miguel de Icaza <miguel@ximian.com>
2527 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
2528 static read-only fields in ctors.
2530 Applied patch from Benjamin Jemlich
2532 * expression.cs (UnaryMutator): Avoid leaking local variables.
2534 2004-01-09 Miguel de Icaza <miguel@ximian.com>
2536 * cs-tokenizer.cs (IsCastToken): Allow the various native types
2537 here to return true, as they can be used like this:
2541 Fixed 49836 and all the other dups
2543 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
2545 * driver.cs: Implement /win32res and /win32icon.
2547 2004-01-08 Miguel de Icaza <miguel@ximian.com>
2549 * cs-parser.jay: Add a rule to improve error handling for the
2550 common mistake of placing modifiers after the type.
2552 2004-01-07 Miguel de Icaza <miguel@ximian.com>
2554 * cs-parser.jay (interface_event_declaration): Catch
2555 initialization of events on interfaces, and report cs0068
2557 * cs-parser.jay (interface_event_declaration): Catch
2558 initialization of events.
2560 * ecore.cs: Better report missing constructors.
2562 * expression.cs (Binary.ResolveOperator): My previous bug fix had
2563 the error reporting done in the wrong place. Fix.
2565 * expression.cs (Binary.ResolveOperator): Catch the
2566 operator + (E x, E y) error earlier, and later allow for implicit
2567 conversions in operator +/- (E e, U x) from U to the underlying
2570 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
2571 52596, if the container class is abstract, the default constructor
2572 is protected otherwise its public (before, we were always public).
2574 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
2577 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
2578 Jemlich that fixes bug #52597, MCS was generating invalid code for
2579 idisposable structs. Thanks to Ben for following up with this
2582 2004-01-06 Miguel de Icaza <miguel@ximian.com>
2584 * driver.cs: Allow assemblies without code to be generated, fixes
2587 2004-01-07 Nick Drochak <ndrochak@gol.com>
2589 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
2591 2004-01-05 Miguel de Icaza <miguel@ximian.com>
2593 * cs-parser.jay: Add rules to improve error reporting if fields or
2594 methods are declared at the namespace level (error 116)
2596 * Add rules to catch event add/remove
2598 2004-01-04 David Sheldon <dave-mono@earth.li>
2600 * expression.cs: Added matching ")" to error message for
2603 2004-01-03 Todd Berman <tberman@gentoo.org>
2605 * ecore.cs, attribute.cs:
2606 Applying fix from #52429.
2608 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2610 * ecore.cs, expression.cs, statement.cs:
2611 Total rewrite of how we handle branching. We
2612 now handle complex boolean expressions with fewer
2613 jumps. As well if (x == 0) no longer emits a ceq.
2615 if (x is Foo) is much faster now, because we generate
2618 Overall, we get a pretty big improvement on our benchmark
2619 tests. The code we generate is smaller and more readable.
2621 I did a full two-stage bootstrap. The patch was reviewed
2622 by Martin and Miguel.
2624 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2626 * cs-parser.jay: Make primary_expression not take a QI.
2627 we dont need this because the member_access rule covers
2628 us here. So we replace the rule with just IDENTIFIER.
2630 This has two good effects. First, we remove a s/r conflict.
2631 Second, we allocate many fewer QualifiedIdentifier objects.
2633 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2635 * attribute.cs: Handle MarshalAs attributes as pseudo, and
2636 set the correct information via SRE. This prevents
2637 hanging on the MS runtime. Fixes #29374.
2639 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2641 * convert.cs: correctly handle conversions to value types
2642 from Enum and ValueType as unboxing conversions.
2644 Fixes bug #52569. Patch by Benjamin Jemlich.
2646 2004-01-02 Ravi Pratap <ravi@ximian.com>
2648 * expression.cs (BetterConversion): Prefer int -> uint
2649 over int -> ulong (csc's behaviour). This fixed bug #52046.
2651 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
2653 * decl.cs (MemberCache.FindMembers): now returns a
2656 * typemanager.cs: In general, go with with ^^.
2657 (CopyNewMethods): take an IList.
2658 (RealMemberLookup): Only allocate an arraylist
2659 if we copy from two sets of methods.
2661 This change basically does two things:
2662 1) Fewer array lists allocated due to CopyNewMethods.
2663 2) the explicit cast in MemberList costed ALOT.
2665 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
2667 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
2668 a hashtable to avoid needless string allocations when an identifier is
2669 used more than once (the common case).
2671 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
2673 * pending.cs: MS's TypeBuilder.GetInterfaces ()
2674 is broken, it will not return anything. So, we
2675 have to use the information we have in mcs to
2678 * typemanager.cs: Add a cache for GetInterfaces,
2679 since this will now be used more often (due to ^^)
2681 (GetExplicitInterfaces) New method that gets the
2682 declared, not effective, interfaces on a type
2683 builder (eg, if you have interface IFoo, interface
2684 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
2687 This patch makes MCS able to bootstrap itself on
2690 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
2692 * expression.cs: Remove the Nop's that Miguel put
2695 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2697 * report.cs, codegen.cs: Give the real stack trace to
2698 the error when an exception is thrown.
2700 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2702 * decl.cs: only allocate hashtables for ifaces if
2705 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2707 * expression.cs: fix the error from cs0121-2.cs
2708 (a parent interface has two child interfaces that
2709 have a function with the same name and 0 params
2710 and the function is called through the parent).
2712 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
2714 * class.cs, rootcontext.cs, typmanager.cs: do not
2717 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
2719 * codegen.cs: remove stack for the ec flow branching.
2720 It is already a linked list, so no need.
2722 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
2724 * Makefile: Allow custom profiler here.
2726 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
2728 * typemanager.cs (LookupType):
2729 - Use a static char [], because split takes
2730 a param array for args, so it was allocating
2732 - Do not store true in a hashtable, it boxes.
2734 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
2736 * flowanalysis.cs: bytify common enums.
2738 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2740 * modifiers.cs: Add a new set of flags for the
2741 flags allowed on explicit interface impls.
2742 * cs-parser.jay: catch the use of modifiers in
2743 interfaces correctly.
2744 * class.cs: catch private void IFoo.Blah ().
2746 All related to bug #50572.
2748 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2750 * decl.cs: Rewrite the consistant accessability checking.
2751 Accessability is not linear, it must be implemented in
2752 a tableish way. Fixes #49704.
2754 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2756 * expression.cs: Handle negation in a checked context.
2757 We must use subtraction from zero. Fixes #38674.
2759 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
2761 * class.cs: Ignore static void main in DLLs.
2762 * rootcontext.cs: Handle the target type here,
2763 since we are have to access it from class.cs
2764 * driver.cs: account for the above.
2766 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
2768 * report.cs: Give line numbers and files if available.
2770 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
2772 * driver.cs: Implement /addmodule.
2774 * typemanager.cs: Change 'modules' field so it now contains Modules not
2777 2003-12-20 Martin Baulig <martin@ximian.com>
2779 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
2780 (FieldBase.IsAssigned): Removed this field.
2781 (FieldBase.SetAssigned): New public method.
2782 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
2784 2003-12-20 Martin Baulig <martin@ximian.com>
2786 * expression.cs (LocalVariableReference.DoResolve): Don't set
2787 `vi.Used' if we're called from DoResolveLValue().
2789 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
2790 returns the usage vector it just merged into the current one -
2791 pass this one to UsageWarning().
2792 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
2793 of the `EmitContext', don't call this recursively on our children.
2795 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
2797 * driver.cs: Implement /target:module.
2799 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
2801 * support.cs (CharArrayHashtable): New helper class.
2803 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
2804 char arrays, not strings, so we can avoid creating a string in
2805 consume_identifier if the identifier is a keyword.
2807 2003-12-16 Martin Baulig <martin@ximian.com>
2809 * statement.cs (LocalInfo.Assigned): Removed this property.
2810 (LocalInfo.Flags): Removed `Assigned'.
2811 (LocalInfo.IsAssigned): New public method; takes the EmitContext
2812 and uses flow analysis.
2813 (Block.UsageWarning): Made this method private.
2814 (Block.Resolve): Call UsageWarning() if appropriate.
2816 * expression.cs (LocalVariableReference.DoResolve): Always set
2817 LocalInfo.Used here.
2819 2003-12-13 Martin Baulig <martin@ximian.com>
2821 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
2822 any value here; we're now using flow analysis to figure out
2823 whether a statement/block returns a value.
2825 2003-12-13 Martin Baulig <martin@ximian.com>
2827 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
2829 (FlowBranching.MergeFinally): Don't call
2830 `branching.CheckOutParameters()' here, this is called in
2832 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
2833 when adding the `finally' vector.
2835 2003-12-13 Martin Baulig <martin@ximian.com>
2838 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
2839 actually work and also fix #48962.
2841 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
2843 * decl.cs: Do not check System.Object for nested types,
2844 since we know it does not have any. Big bang for buck:
2849 corlib: 17.99 seconds
2853 corlib: 17.39 seconds
2855 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
2857 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
2858 time we are returning 0 members, so we save alot here.
2860 2003-12-11 Martin Baulig <martin@ximian.com>
2862 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
2863 `MergeChild()', also just take the `FlowBranching' as argument;
2864 call Merge() on it and return the result.
2865 (FlowBranching.Merge): We don't need to do anything if we just
2868 2003-12-11 Martin Baulig <martin@ximian.com>
2870 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
2871 them in an `ArrayList' to reduce memory usage. Thanks to Ben
2872 Maurer for this idea.
2874 2003-12-11 Martin Baulig <martin@ximian.com>
2876 * flowanalysis.cs (MergeResult): This class is now gone; we now
2877 use the `UsageVector' for this. The reason for this is that if a
2878 branching just has one sibling, we don't need to "merge" them at
2879 all - that's the next step to do.
2880 (FlowBranching.Merge): We now return a `UsageVector' instead of a
2883 2003-12-11 Martin Baulig <martin@ximian.com>
2885 Reworked flow analyis and made it more precise and bug-free. The
2886 most important change is that we're now using a special `Reachability'
2887 class instead of having "magic" meanings of `FlowReturns'. I'll
2888 do some more cleanups and optimizations and also add some more
2889 documentation this week.
2891 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
2892 largely reworked this class.
2893 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
2894 the new `Reachability' class instead of having "magic" values here.
2895 (FlowBranching): We're now using an instance of `Reachability'
2896 instead of having separate `Returns', `Breaks' etc. fields.
2898 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
2899 based on flow analysis; ignore the return value of block.Emit ().
2901 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
2903 * driver.cs typemanager.cs: Find the mono extensions to corlib even
2904 if they are private.
2906 2003-12-09 Martin Baulig <martin@ximian.com>
2908 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
2909 call them directly on the UsageVector.
2911 2003-12-09 Martin Baulig <martin@ximian.com>
2913 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
2914 Changed return type from `FlowReturns' to `Reachability'.
2916 2003-12-09 Martin Baulig <martin@ximian.com>
2918 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
2919 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
2920 `Reachable' fields with a single `Reachability' one.
2922 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2924 * class.cs (FindMembers): Remove foreach's.
2937 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2942 This patch does a few things:
2943 1. EmptyStatement is now a singleton, so it is never reallocated.
2944 2. All blah is EmptyStatement constructs have been changed to
2945 blah == EmptyStatement.Value, which is much faster and valid
2946 now that EmptyStatement is a singleton.
2947 3. When resolving a block, rather than allocating a new array for
2948 the non-empty statements, empty statements are replaced with
2949 EmptyStatement.Value
2950 4. Some recursive functions have been made non-recursive.
2951 Mainly the performance impact is from (3), however (1) and (2) are needed for
2952 this to work. (4) does not make a big difference in normal situations, however
2953 it makes the profile look saner.
2958 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
2959 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
2960 Total memory allocated: 56397 KB
2963 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
2964 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
2965 Total memory allocated: 55666 KB
2967 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2969 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
2970 than the hashtable in a hashtable version
2972 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
2973 we always end up concating a string. This results in a huge perf
2974 loss, because many strings have to be tracked by the GC. In this
2975 patch, we first use a hashtable that works with two keys, so that
2976 the strings do not need to be concat'ed.
2987 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2989 * Makefile: Add a new target `do-time' that does a quick and simple
2990 profile, leaving easy to parse output.
2992 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
2994 * codegen.cs (Init): Create the dynamic assembly with
2995 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
2997 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
2999 * support.cs: Make the PtrHashtable use only one
3000 instance of its comparer.
3002 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
3004 * typemanager.cs: Fix lookup of GetNamespaces.
3006 2003-11-29 Miguel de Icaza <miguel@ximian.com>
3008 * expression.cs: Removed redundant line.
3010 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
3011 ArrayLists, use for loops with bounds.
3013 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
3016 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
3017 arraylists, use for loop with bounds.
3019 The above three changes give us a 0.071 second performance
3020 improvement out of 3.294 seconds down to 3.223. On my machine
3021 the above changes reduced the memory usage by 1,387 KB during
3024 * cs-parser.jay (QualifiedIdentifier): New class used to represent
3025 QualifiedIdentifiers. Before we created a new string through
3026 concatenation, and mostly later on, the result would be
3027 manipulated by DecomposeQI through string manipulation.
3029 This reduced the compiler memory usage for bootstrapping from
3030 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
3031 compile times in 0.05 seconds.
3033 2003-11-28 Dick Porter <dick@ximian.com>
3035 * support.cs: Do string compares with the Invariant culture.
3043 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
3044 the comparison is done with the Invariant culture.
3046 2003-11-27 Miguel de Icaza <miguel@ximian.com>
3048 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
3049 GetEnumerator method.
3051 (ProbeCollectionType): Iterate starting at the most specific type
3052 upwards looking for a GetEnumerator
3054 * expression.cs: Shift count can be up to 31 for int/uint and 63
3057 2003-11-26 Miguel de Icaza <miguel@ximian.com>
3059 * statement.cs (Block.LookupLabel): Also look for the label on the
3060 children blocks. Use a hash table to keep track of visited
3063 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
3064 we actually did transform the other operand, otherwise fall back
3065 to the common codepath that casts to long.
3067 * cs-tokenizer.cs: Use the same code pattern as the int case.
3068 Maybe I should do the parsing myself, and avoid depending on the
3069 Parse routines to get this done.
3071 2003-11-25 Miguel de Icaza <miguel@ximian.com>
3073 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3074 which fixes bug 51347. This time test it.
3076 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
3077 attributes for example can not tell the difference between these.
3078 The difference was only a syntax feature of the language.
3080 * attribute.cs: Apply attributes to delegates.
3082 * delegate.cs: Call the apply attributes method.
3084 2003-11-24 Miguel de Icaza <miguel@ximian.com>
3086 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
3087 comparing 0 vs Byte.MinValue, not the value
3089 (ImplicitConversionRequired): When reporting a conversion error,
3090 use error 31 to print out the constant error instead of the
3093 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3094 which fixes bug 51347.
3096 2003-11-22 Miguel de Icaza <miguel@ximian.com>
3098 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
3099 which fixes the -warnaserror command line option.
3101 2003-11-21 Miguel de Icaza <miguel@ximian.com>
3103 * cfold.cs (DoNumericPromotions): During constant folding of
3104 additions on UIntConstant, special case intconstants with
3105 IntConstants like we do on the expression binary operator.
3107 2003-11-12 Miguel de Icaza <miguel@ximian.com>
3109 * convert.cs (ImplicitReferenceConversion): We were missing a case
3110 (System.Enum are not value types or class types, so we need to
3111 classify them separatedly).
3113 * driver.cs: We do not support error 2007.
3115 2003-11-12 Jackson Harper <jackson@ximian.com>
3117 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
3118 system directory. Also use the full file name so users can
3119 libraries names mscorlib-o-tron.dll in a non system dir.
3121 2003-11-10 Martin Baulig <martin@ximian.com>
3123 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
3124 (TypeManager.InitCoreTypes): Initialize them here, but instead of
3125 calling `ResolveType()' on them, directly assign their `Type'.
3127 2003-11-08 Martin Baulig <martin@ximian.com>
3129 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
3130 return value and the `out parent' parameter.
3131 (TypeContainer.DefineType): Moved the CS0644 check into
3132 GetClassBases(). Don't pass the interface types to the
3133 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
3134 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
3136 * ecore.cs (TypeExpr.IsAttribute): New property.
3137 (TypeExpr.GetInterfaces): New method.
3139 * interface.cs (Interface.GetInterfaceTypeByName): Return a
3140 TypeExpr instead of a Type.
3141 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
3142 (Interface.DefineType): Don't pass the interface types to the
3143 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
3144 them later and then call `TypeBulider.AddInterfaceImplementation()'.
3146 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
3147 instead of a `Type[]'.
3148 (TypeManager.RegisterBuilder): Likewise.
3149 (TypeManager.AddUserInterface): Likewise.
3150 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
3151 `Type[]' and also return a `TypeExpr[]'.
3152 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
3154 2003-11-08 Martin Baulig <martin@ximian.com>
3156 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
3159 2003-11-08 Martin Baulig <martin@ximian.com>
3161 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
3162 TypeManager.ResolveExpressionTypes().
3164 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
3165 instead of an Expression.
3166 (TypeExpr): This is now an abstract base class for `TypeExpression'.
3167 (TypeExpression): New public class; formerly known as `TypeExpr'.
3169 * expression.cs (ComposedCast): Derive from TypeExpr.
3171 * typemanager.cs (TypeManager.system_*_expr): These are now
3172 TypExpr's instead of Expression's.
3173 (TypeManager.ResolveExpressionTypes): New public static function;
3174 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
3177 2003-11-06 Miguel de Icaza <miguel@ximian.com>
3179 * expression.cs (New.DoResolve): Do not dereference value that
3180 might be a null return.
3182 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
3183 sure that the constant value has the right type. Fixes an
3184 unreported bug, similar to 50425.
3186 * const.cs (Const.LookupConstantValue): Call
3187 ImplicitStandardConversionExists before doing a conversion to
3188 avoid havng the TypeManager.ChangeType do conversions.
3190 Reduced the number of casts used
3192 (Const.ChangeType): New routine to enable reuse of the constant
3193 type changing code from statement.
3195 * typemanager.cs (ChangeType): Move common initialization to
3196 static global variables.
3200 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
3201 every value type to go through, even if it was void. Fix that.
3203 * cs-tokenizer.cs: Use is_identifier_start_character on the start
3204 character of the define, and the is_identifier_part_character for
3205 the rest of the string.
3207 2003-11-05 Miguel de Icaza <miguel@ximian.com>
3209 * expression.cs (UnaryMutator.EmitCode): When I updated
3210 LocalVariableReference.DoResolve, I overdid it, and dropped an
3211 optimization done on local variable references.
3213 2003-11-04 Miguel de Icaza <miguel@ximian.com>
3215 * ecore.cs: Convert the return from Ldlen into an int.
3217 2003-10-20 Miguel de Icaza <miguel@ximian.com>
3219 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
3220 the accessibility, this is a special case for toplevel non-public
3221 classes (internal for instance).
3223 2003-10-20 Nick Drochak <ndrochak@gol.com>
3225 * ecore.cs: Fix typo and build. Needed another right paren.
3227 2003-10-19 Miguel de Icaza <miguel@ximian.com>
3229 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
3230 `internal' case regular and protected, but not allowing protected
3231 to be evaluated later. Bug 49840
3233 2003-10-15 Miguel de Icaza <miguel@ximian.com>
3235 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
3236 to kb.Nlast, and not the kb.nFirst to isolate the switch
3239 Extract the underlying type, so enumerations of long/ulong are
3240 treated like long/ulong.
3242 2003-10-14 Miguel de Icaza <miguel@ximian.com>
3244 * expression.cs (New): Overload the meaning of RequestedType to
3245 track the possible creation of the NewDelegate type, since
3246 DoResolve is invoked more than once for new constructors on field
3249 See bugs: #48800 and #37014
3251 * cs-parser.jay (declare_local_constants): Take an arraylist
3252 instead of a single constant.
3254 (local_constant_declaration): It should take a
3255 constant_declarators, not a constant_declarator. Fixes 49487
3257 * convert.cs: Fix error report.
3259 2003-10-13 Jackson Harper <jackson@ximian.com>
3261 * typemanager.cs (TypeToCoreType): Add float and double this fixes
3264 2003-10-09 Martin Baulig <martin@ximian.com>
3266 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
3268 (MethodCore.DoDefineParameters): Removed the TypeContainer
3269 argument; use the DeclSpace which was passed to the .ctor instead.
3270 (MethodCore.CheckParameter): Take a DeclSpace instead of a
3271 TypeContainer; we only need a DeclSpace here.
3273 2003-10-09 Martin Baulig <martin@ximian.com>
3275 * class.cs (MethodData): Added additional `DeclSpace ds' argument
3277 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
3278 EmitContext's .ctor.
3280 2003-10-09 Martin Baulig <martin@ximian.com>
3282 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
3283 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
3284 AsAccessible(), moved them as well.
3286 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
3288 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
3290 * cs-parser.jay : Renamed yyName to yyNames related to jay.
3292 2003-10-07 Miguel de Icaza <miguel@ximian.com>
3294 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
3295 generation for >=, as spotted by Paolo, bug 48679.
3296 Patch from David Waite.
3298 * cs-tokenizer.cs: Add handling for #pragma.
3300 * cs-parser.jay: Allow for both yield and yield return in the
3301 syntax. The anti-cobolization of C# fight will go on!
3303 * class.cs (TypeBuilder.DefineType): Catch error condition here
3304 (Parent.DefineType erroring out and returning null).
3306 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
3307 coping with enumerations variables, we were mistakenly processing
3308 them as a regular value type instead of built-in types. Fixes the
3311 * typemanager.cs (IsBuiltinOrEnum): New method.
3313 2003-09-30 Miguel de Icaza <miguel@ximian.com>
3315 * cs-parser.jay: Upgrade: yield now needs the return clause.
3317 2003-09-19 Martin Baulig <martin@ximian.com>
3319 * decl.cs (MemberCache.SetupCacheForInterface): Take a
3320 `MemberCache parent' argument. Normally, an interface doesn't
3321 have a parent type except System.Object, but we use this in gmcs
3322 for generic type parameters.
3324 2003-09-18 Martin Baulig <martin@ximian.com>
3326 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
3327 on `type.IsInterface'; don't check whether the type has a parent
3328 to determine whether it's an interface.
3330 2003-09-15 Martin Baulig <martin@ximian.com>
3332 * class.cs (TypeContainer.DefineType): Added an error flag to
3333 avoid reporting duplicate CS0146's ("class definition is
3336 * driver.cs (Driver.MainDriver): Abort if
3337 RootContext.ResolveTree() reported any errors.
3339 2003-09-07 Martin Baulig <martin@ximian.com>
3341 * report.cs (Error, Warning): Added overloaded versions which take
3342 a `params object[] args' and call String.Format().
3344 2003-09-07 Martin Baulig <martin@ximian.com>
3346 * decl.cs (DeclSpace..ctor): Don't call
3347 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
3348 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
3349 (DeclSpace.RecordDecl): New method.
3351 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
3353 2003-09-02 Ravi Pratap <ravi@ximian.com>
3355 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
3356 value attributes to be applied to ParameterBuilders.
3358 * class.cs (MethodCore.LabelParameters): Make static and more
3359 generic so that it can be used from other places - like interface
3360 methods, for instance.
3362 * interface.cs (Interface.Emit): Call LabelParameters before
3363 emitting attributes on the InterfaceMethod.
3365 2003-08-26 Martin Baulig <martin@ximian.com>
3367 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
3368 resolving aliases; fixes #47927.
3370 2003-08-26 Martin Baulig <martin@ximian.com>
3372 * statement.cs (Using.DoResolve): This is internally emitting a
3373 try/finally clause, so we need to set ec.NeedExplicitReturn if we
3374 do not always return. Fixes #47681.
3376 2003-08-26 Martin Baulig <martin@ximian.com>
3378 * decl.cs (MemberCore): Moved WarningNotHiding(),
3379 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
3381 (AdditionResult): Make this nested in DeclSpace.
3382 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
3383 argument; call NamespaceEntry.Define() unless we're nested in a
3386 * namespace.cs (Namespace.DefineName): New public function. This
3387 is called from DeclSpace's .ctor to add
3388 (Namespace.Lookup): Include DeclSpaces in the lookup.
3390 * class.cs (Operator): Derive from MemberBase, not MemberCore.
3392 * const.cs (Const): Derive from MemberBase, not MemberCore.
3394 2003-08-25 Martin Baulig <martin@ximian.com>
3396 * convert.cs (Convert.ExplicitReferenceConversion): When
3397 converting from an interface type to a class, unbox if the target
3398 type is a struct type. Fixes #47822.
3400 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3402 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
3405 2003-08-22 Martin Baulig <martin@ximian.com>
3407 * class.cs (TypeManager.DefineType): When defining a nested type,
3408 call DefineType() on our parent; fixes #47801.
3410 2003-08-22 Martin Baulig <martin@ximian.com>
3412 * class.cs (MethodData.Define): While checking if a method is an
3413 interface implementation, improve the test a bit more to fix #47654.
3415 2003-08-22 Martin Baulig <martin@ximian.com>
3417 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
3418 correctly; fixes #47722.
3420 2003-08-22 Martin Baulig <martin@ximian.com>
3422 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
3423 LocalVariableReference, ensure it's not read-only. Fixes #47536.
3425 * statement.cs (Fixed.DoResolve): Make all variables read-only.
3427 2003-08-22 Martin Baulig <martin@ximian.com>
3429 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
3430 can only be assigned in static constructors. Fixes #47161.
3432 2003-08-22 Martin Baulig <martin@ximian.com>
3434 Rewrote and improved the flow analysis code.
3436 * flowbranching.cs (FlowBranching): Make this class abstract.
3437 (FlowBranching.CreateBranching): New static function to create a
3439 (FlowBranchingBlock, FlowBranchingException): New classes.
3440 (FlowBranching.UsageVector.Type): New public readonly field.
3441 (FlowBranching.UsageVector.Breaks): Removed the setter.
3442 (FlowBranching.UsageVector.Returns): Removed the setter.
3443 (FlowBranching.UsageVector): Added Break(), Return(),
3444 NeverReachable() and Throw() methods to modify the reachability.
3445 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
3446 done by FlowBranching.Merge().
3447 (FlowBranching.UsageVector.MergeChild): New method; merges the
3448 merge result into the current vector.
3449 (FlowBranching.Merge): New abstract method to merge a branching.
3451 2003-08-12 Martin Baulig <martin@ximian.com>
3453 * expression.cs (Indirection.CacheTemporaries): Create the
3454 LocalTemporary with the pointer type, not its element type.
3456 2003-08-10 Miguel de Icaza <miguel@ximian.com>
3458 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
3459 token was a keyword or not.
3461 Add `error' options where an IDENTIFIER was expected; Provide
3462 CheckToken and CheckIdentifierToken convenience error reporting
3465 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
3467 * decl.cs: Rename `NamespaceEntry Namespace' public field into
3468 NameSpaceEntry NameSpaceEntry.
3470 (LookupInterfaceOrClass): Avoid creating a full qualified name
3471 from namespace and name: avoid doing lookups when we know the
3472 namespace is non-existant. Use new Tree.LookupByNamespace which
3473 looks up DeclSpaces based on their namespace, name pair.
3475 * driver.cs: Provide a new `parser verbose' to display the
3476 exception thrown during parsing. This is turned off by default
3477 now, so the output of a failure from mcs is more graceful.
3479 * namespace.cs: Track all the namespaces defined in a hashtable
3482 (IsNamespace): New method
3484 2003-08-09 Miguel de Icaza <miguel@ximian.com>
3486 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
3487 we know that we need to concatenate (full typename can never be
3492 * statement.cs: Use a bitfield; Do not initialize to null things
3493 which are done by the constructor by default.
3495 * cs-parser.jay: bug fix, parameter was 4, not 3.
3497 * expression.cs: Just use the property;
3499 * statement.cs: No need for GetVariableInfo method.
3501 2003-08-08 Martin Baulig <martin@ximian.com>
3503 * flowanalysis.cs (FlowReturns): This is now nested in the
3504 `FlowBranching' class.
3505 (MyBitVector): Moved this here from statement.cs.
3506 (FlowBranching.SiblingType): New enum type.
3507 (FlowBranching.CreateSibling): Added `SiblingType' argument.
3509 2003-08-07 Martin Baulig <martin@ximian.com>
3511 * flowanalysis.cs (FlowBranchingType): This is now nested in the
3512 `FlowBranching' class and called `BranchingType'.
3514 2003-08-07 Martin Baulig <martin@ximian.com>
3516 * flowanalysis.cs: Moved all the control flow analysis code into
3519 2003-08-07 Martin Baulig <martin@ximian.com>
3521 * assign.cs (Assign.DoResolve): `target' must either be an
3522 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
3525 2003-08-07 Miguel de Icaza <miguel@ximian.com>
3527 * expression.cs (BinaryMethod): This kind of expression is created by the
3528 Binary class if it determines that the operator has to be handled
3531 (BinaryDelegate): This kind of expression is created if we are
3532 dealing with a + or - operator on delegates.
3534 (Binary): remove method, argumetns, and DelegateOperator: when
3535 dealing with methods,
3537 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
3539 * statement.cs (Block): use bitfields for the three extra booleans
3540 we had in use. Remove unused topblock parameter.
3542 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
3544 * assign.cs: Drop extra unneeded tests.
3546 2003-08-06 Miguel de Icaza <miguel@ximian.com>
3548 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
3550 * statement.cs (Foreach): Use VariableStorage instead of
3553 * codegen.cs (VariableStorage): New class used by clients that
3554 require a variable stored: locals or fields for variables that
3555 need to live across yield.
3557 Maybe provide a convenience api for EmitThis+EmitLoad?
3559 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
3562 2003-08-05 Miguel de Icaza <miguel@ximian.com>
3564 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
3565 RemapParameterLValue): New methods that are used to turn a
3566 precomputed FieldInfo into an expression like this:
3570 The idea is to use this instead of making LocalVariableReference
3571 have more than one meaning.
3573 * cs-parser.jay: Add error production to BASE.
3575 * ecore.cs: Deal with TypeManager.GetField returning null, which
3576 is now a valid return value.
3578 (FieldExprNoAddress): New expression for Fields whose address can
3581 * expression.cs (LocalVariableReference): During the resolve
3582 phases, create new expressions if we are in a remapping context.
3583 Remove code that dealt with remapping here.
3585 (ParameterReference): same.
3587 (ProxyInstance): New expression, like the `This' expression, but
3588 it is born fully resolved. We know what we are doing, so remove
3589 the errors that are targeted to user-provided uses of `this'.
3591 * statement.cs (Foreach): our variable is now stored as an
3592 Expression; During resolution, follow the protocol, dont just
3593 assume it will return this.
3595 2003-08-06 Martin Baulig <martin@ximian.com>
3597 * support.cs (SeekableStreamReader.cs): New public class.
3599 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
3600 SeekableStreamReader instead of the normal StreamReader.
3602 2003-08-04 Martin Baulig <martin@ximian.com>
3604 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
3605 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
3606 deambiguate casts and delegate invocations.
3607 (parenthesized_expression): Use the new tokens to ensure this is
3608 not a cast of method invocation.
3610 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
3611 when reading a `)' and Deambiguate_CloseParens () was previously
3614 * expression.cs (ParenthesizedExpression): New class. This is
3615 just used for the CS0075 test.
3616 (Binary.DoResolve): Check for CS0075.
3618 2003-07-29 Ravi Pratap <ravi@ximian.com>
3620 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
3621 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
3622 reference comparison.
3624 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
3625 examine the ReturnType for equality - this is necessary in the
3626 cases of implicit and explicit operators whose signature also
3627 includes the return type.
3629 2003-07-26 Miguel de Icaza <miguel@ximian.com>
3631 * namespace.cs: Cache the result of the namespace computation,
3632 instead of computing it every time.
3634 2003-07-24 Miguel de Icaza <miguel@ximian.com>
3636 * decl.cs: Use a global arraylist that we reuse over invocations
3637 to avoid excesive memory consumption. Reduces memory usage on an
3638 mcs compile by one meg (45 average).
3640 * typemanager.cs (LookupTypeReflection): In .NET pointers are
3641 private, work around that.
3643 2003-07-23 Miguel de Icaza <miguel@ximian.com>
3645 * literal.cs (IntLiteral): Define Zero and One static literals.
3647 * cs-parser.jay (integer_literal): use static literals to reduce
3648 memory usage for the most used literals (0, 1 and -1). 211kb
3649 reduced in memory usage.
3651 Replace all calls to `new ArrayList' with `new
3652 ArrayList(4)' which is a good average number for most allocations,
3653 and also requires only 16 bytes of memory for its buffer by
3656 This reduced MCS memory usage in seven megabytes for the RSS after
3659 2003-07-28 Ravi Pratap <ravi@ximian.com>
3661 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
3662 handle params methods the correct way by forming only one
3663 applicable set with params and normal methods in them. Earlier we
3664 were looking at params methods only if we found no normal methods
3665 which was not the correct thing to do.
3667 (Invocation.BetterFunction): Take separate arguments indicating
3668 when candidate and the best method are params methods in their
3671 This fixes bugs #43367 and #46199.
3673 * attribute.cs: Documentation updates.
3675 (CheckAttribute): Rename to CheckAttributeTarget.
3676 (GetValidPlaces): Rename to GetValidTargets.
3678 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
3679 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
3683 2003-07-28 Martin Baulig <martin@ximian.com>
3685 * class.cs (TypeContainer.DefineMembers): Use the base type's full
3686 name when looking up the base class of a nested class. Fixes #46977.
3688 2003-07-26 Martin Baulig <martin@ximian.com>
3690 * expression.cs (Indexers.Indexer): New nested struct; contains
3691 getter, setter and the indexer's type.
3692 (Indexers.Properties): This is now an ArrayList of
3694 (IndexerAccess.DoResolveLValue): Correctly set the type if the
3695 indexer doesn't have any getters.
3697 * assign.cs (Assign.DoResolve): Also do the implicit conversions
3698 for embedded property and indexer assignments.
3700 2003-07-26 Martin Baulig <martin@ximian.com>
3702 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
3703 preprocessor directive is not the first non-whitespace character
3706 2003-07-26 Martin Baulig <martin@ximian.com>
3708 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
3709 namespace parsing, follow the spec more closely.
3711 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
3712 NamespaceEntry.Lookup().
3714 2003-07-25 Martin Baulig <martin@ximian.com>
3716 * MethodCore.cs (OverridesSomething): New public field; it's set
3717 from TypeContainer.DefineMembers if this method overrides
3718 something (which doesn't need to be a method). Fix #39462.
3720 2003-07-25 Ravi Pratap <ravi@ximian.com>
3722 * typemanager.cs (GetMembers): Ensure that the list of members is
3723 reversed. This keeps things in sync.
3725 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
3726 find an AttributeUsage attribute.
3728 * expression.cs (Invocation.OverloadResolve): Perform the check
3729 which disallows Invoke to be directly called on a Delegate.
3731 (Error_InvokeOnDelegate): Report error cs1533.
3733 2003-07-25 Martin Baulig <martin@ximian.com>
3735 * expression.cs (Indexers.GetIndexersForType): Only look in the
3736 interface hierarchy if the requested type is already an
3737 interface. Fixes #46788 while keeping #46502 fixed.
3739 2003-07-25 Martin Baulig <martin@ximian.com>
3741 * class.cs (TypeContainer.DefineMembers): Check whether all
3742 readonly fields have been assigned and report warning CS0649 if
3745 * statement.cs (LocalInfo.IsFixed): Always return true if this is
3748 2003-07-24 Ravi Pratap <ravi@ximian.com>
3750 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
3751 returned from GetMethods to make things consistent with the
3752 assumptions MCS makes about ordering of methods.
3754 This should comprehensively fix bug #45127 and it does :-)
3756 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
3757 ordering is actually reverse.
3759 * Clean up some debug messages I left lying around.
3761 * interface.cs (Populate*): Get rid of code which emits attributes
3762 since the stage in which we emit attributes is the 'Emit' stage,
3763 not the define stage.
3765 (Emit): Move attribute emission for interface members here.
3767 2003-07-22 Ravi Pratap <ravi@ximian.com>
3769 * expression.cs (Invocation.OverloadResolve): Follow the spec more
3770 closely: we eliminate methods in base types when we have an
3771 applicable method in a top-level type.
3773 Please see section 14.5.5.1 for an exact description of what goes
3776 This fixes bug #45127 and a host of other related to corlib compilation.
3778 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
3779 array is the method corresponding to the top-level type (this is
3780 because of the changes made to icall.c) so we change this
3783 (MethodGroupExpr.Name): This too.
3785 * typemanager.cs (GetElementType): New method which does the right
3786 thing when compiling corlib.
3788 * everywhere: Make use of the above in the relevant places.
3790 2003-07-22 Martin Baulig <martin@ximian.com>
3792 * cs-parser.jay (invocation_expression): Moved
3793 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
3794 `cast_expression', but create a InvocationOrCast which later
3795 resolves to either an Invocation or a Cast.
3797 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
3798 method; call this before EmitStatement() to make sure that this
3799 expression can be used as a statement.
3801 * expression.cs (InvocationOrCast): New class; resolves to either
3802 an Invocation or a Cast.
3804 * statement.cs (StatementExpression): Call ResolveStatement() on
3805 the ExpressionStatement before emitting it.
3807 2003-07-21 Martin Baulig <martin@ximian.com>
3809 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
3810 `ref' and `out' attributes match; fixes #46220.
3811 (MemberAccess.ResolveMemberAccess): You can't reference a type
3812 through an expression; fixes #33180.
3813 (Indexers.GetIndexersForType): Don't return the indexers from
3814 interfaces the class implements; fixes #46502.
3816 2003-07-21 Martin Baulig <martin@ximian.com>
3818 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
3819 CS0661 checks; fixes bug #30442.
3821 2003-07-21 Martin Baulig <martin@ximian.com>
3823 * decl.cs (AdditionResult): Added `Error'.
3825 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
3827 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
3828 makes cs0031.cs actually work.
3830 2003-07-20 Martin Baulig <martin@ximian.com>
3832 * namespace.cs: Fixed that bug which caused a crash when compiling
3835 2003-07-20 Miguel de Icaza <miguel@ximian.com>
3837 * typemanager.cs (LookupTypeReflection): Never expose types which
3838 are NotPublic, NestedPrivate, NestedAssembly, or
3839 NestedFamANDAssem. We used to return these, and later do a check
3840 that would report a meaningful error, but the problem is that we
3841 would not get the real match, if there was a name override.
3843 2003-07-18 Miguel de Icaza <miguel@ximian.com>
3845 * namespace.cs (Namespace, Name): Do not compute the namespace
3846 name dynamically, compute it in the constructor. This reduced
3847 memory usage by 1697 KB.
3849 * driver.cs: Use --pause to pause at the end.
3851 2003-07-17 Peter Williams <peter@newton.cx>
3853 * Makefile: Change the name of the test target so that it doesn't
3854 conflict with the recursive test target.
3856 2003-07-17 Miguel de Icaza <miguel@ximian.com>
3858 * expression.cs (LocalVariableReference.Emit, EmitAssign,
3859 AddressOf): Do not use EmitThis, that was wrong, use the actual
3862 2003-07-15 Miguel de Icaza <miguel@ximian.com>
3864 * class.cs (MethodData.Define): While checking if a method is an
3865 interface implementation, improve the test: If we are not public
3866 (use new test here: use the computed MethodAttributes directly,
3867 instead of the parsed modifier flags) check if the `implementing'
3868 method comes from an interface or not.
3870 * pending.cs (VerifyPendingMethods): Slightly better error
3873 * makefile: add test target that does the mcs bootstrap.
3875 2003-07-16 Ravi Pratap <ravi@ximian.com>
3877 * interface.cs (Define): Do nothing here since there are no
3878 members to populate etc. Move the attribute emission out of here
3879 since this was just totally the wrong place to put it. Attribute
3880 application happens during the 'Emit' phase, not in the 'Define'
3883 (Emit): Add this method and move the attribute emission here
3885 * rootcontext.cs (EmitCode): Call the Emit method on interface
3888 2003-07-14 Ravi Pratap M <ravi@ximian.com>
3890 * expression.cs (OverloadResolve): Report error only if Location
3891 is not 'Null' which means that there was a probe going on.
3893 2003-07-14 Martin Baulig <martin@ximian.com>
3895 * expression.cs (ConditionalLogicalOperator): New public class to
3896 implement user defined conditional logical operators.
3897 This is section 14.11.2 in the spec and bug #40505.
3899 2003-07-14 Martin Baulig <martin@ximian.com>
3901 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
3903 2003-07-14 Martin Baulig <martin@ximian.com>
3905 * codegen.cs (EmitContext.InFixedInitializer): New public field.
3907 * ecore.cs (IVariable.VerifyFixed): New interface method.
3909 * expression.cs (Unary.ResolveOperator): When resolving the `&'
3910 operator, check whether the variable is actually fixed. Fixes bug
3911 #36055. Set a variable definitely assigned when taking its
3912 address as required by the spec.
3914 * statement.cs (LocalInfo.IsFixed): New field.
3915 (LocalInfo.MakePinned): Set `IsFixed' to true.
3917 2003-07-14 Ravi Pratap M <ravi@ximian.com>
3919 * attribute.cs (Attribute.Resolve): While doing a Member lookup
3920 for .ctors, ensure that we only ask for members declared in the
3921 attribute type (BindingFlags.DeclaredOnly).
3925 * expression.cs (Error_WrongNumArguments): Report error 1501
3926 correctly the way CSC does.
3928 2003-07-13 Martin Baulig <martin@ximian.com>
3930 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
3931 lookup on the fully qualified name, to make things like "X.X" work
3932 where "X.X" is a fully qualified type name, but we also have a
3933 namespace "X" in the using list. Fixes #41975.
3935 2003-07-13 Martin Baulig <martin@ximian.com>
3937 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
3938 function. If we're a CompoundAssign, we need to create an embedded
3939 CompoundAssign, not an embedded Assign.
3940 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
3943 2003-07-13 Martin Baulig <martin@ximian.com>
3945 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
3946 work to fix bug #46088.
3948 2003-07-13 Ravi Pratap <ravi@ximian.com>
3950 * class.cs (Operator.Emit): Do not emit attributes here - it is
3951 taken care of by the Method class that we delegate too. This takes
3954 2003-07-10 Martin Baulig <martin@ximian.com>
3956 * expression.cs (TypeOfVoid): New class.
3957 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
3959 2003-07-10 Martin Baulig <martin@ximian.com>
3961 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
3964 2003-07-10 Martin Baulig <martin@ximian.com>
3966 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
3967 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
3969 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
3971 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
3973 2003-07-10 Martin Baulig <martin@ximian.com>
3975 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
3976 of decimal. Fixes #42850.
3978 NOTE: I also fixed the created byte blob, but this doesn't work on
3979 the MS runtime and csc never produces any byte blobs for decimal
3982 2003-07-10 Martin Baulig <martin@ximian.com>
3984 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
3985 structs; fixes #32068.
3986 (Block.AddChildVariableNames): Fixed #44302.
3988 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3990 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
3992 2003-07-07 Miguel de Icaza <miguel@ximian.com>
3994 * attribute.cs: And this test is onger needed.
3996 2003-07-08 Martin Baulig <martin@ximian.com>
3998 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
3999 inaccessible types. Fixes #36313.
4001 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
4003 * namespace.cs (NamespaceEntry): Create implicit entries for all
4004 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
4005 implicit entries for N1.N2 and N1.
4007 2003-07-08 Martin Baulig <martin@ximian.com>
4009 Rewrote the handling of namespaces to fix a lot of the issues
4010 wrt. `using' aliases etc.
4012 * namespace.cs (Namespace): Splitted this class into a
4013 per-assembly `Namespace' and a per-file `NamespaceEntry'.
4015 * typemanager.cs (TypeManager.IsNamespace): Removed.
4016 (TypeManager.ComputeNamespaces): Only compute namespaces from
4017 loaded assemblies here, not the namespaces from the assembly we're
4018 currently compiling.
4020 2003-07-08 Martin Baulig <martin@ximian.com>
4022 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
4024 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4026 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
4029 I thought about the memory savings here, but LookupTypeReflection
4030 is used under already very constrained scenarios. Compiling
4031 corlib or mcs only exposes one hit, so it would not really reduce
4032 any memory consumption.
4034 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4036 * typemanager.cs: fixes bug #45889 by only adding public types from
4037 other assemblies to the list of known types.
4039 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4041 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
4042 on the type we resolved.
4044 2003-07-05 Martin Baulig <martin@ximian.com>
4046 * pending.cs (PendingImplementation.ParentImplements): Don't
4047 create the proxy if the parent is abstract.
4049 * class.cs (TypeContainer.DefineIndexers): Process explicit
4050 interface implementations first. Fixes #37714.
4052 2003-07-04 Miguel de Icaza <miguel@ximian.com>
4054 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
4055 defined recursively; but since we modify the input parameters
4056 (left is set to `this' temporarily), we reset this value if the
4057 left_is_explicit is false, which gives the original semantics to
4060 * literal.cs (NullPointer): new class used to represent a null
4061 literal in a pointer context.
4063 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
4064 type is a pointer, use a NullPointer object instead of a
4065 NullLiteral. Closes 43687
4067 (ExplicitConversion): Convert pointer values using
4068 the conv opcode to the proper type.
4070 * ecore.cs (New): change ValueTypeVariable property into a method,
4071 that returns whether the valuetype is suitable for being used.
4073 * expression.cs (Binary.DoNumericPromotions): Only return if we
4074 the int constant was a valid uint, and we can return both left and
4075 right as uints. If not, we continue processing, to trigger the
4076 type conversion. This fixes 39018.
4078 * statement.cs (Block.EmitMeta): During constant resolution, set
4079 the CurrentBlock property on the emitcontext, so that we resolve
4080 constants propertly.
4082 2003-07-02 Martin Baulig <martin@ximian.com>
4084 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
4085 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
4087 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
4088 than emitting it here.
4090 * statement.cs: Fixed some more flow analysis bugs.
4092 2003-07-02 Martin Baulig <martin@ximian.com>
4094 * class.cs (MethodData.Define): When implementing interface
4095 methods, set Final unless we're Virtual.
4097 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
4098 check work for interface methods.
4100 2003-07-01 Martin Baulig <martin@ximian.com>
4102 * ecore.cs (EmitContext.This): Replaced this property with a
4103 GetThis() method which takes a Location argument. This ensures
4104 that we get the correct error location for a CS0188.
4106 2003-07-01 Miguel de Icaza <miguel@ximian.com>
4108 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
4109 ImplicitStandardConversion.
4111 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
4113 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
4115 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
4118 2003-06-30 Miguel de Icaza <miguel@ximian.com>
4120 * class.cs (Constructor.Define): Turn off initlocals for unsafe
4123 (MethodData.Define): Turn off initlocals for unsafe methods.
4125 2003-06-29 Miguel de Icaza <miguel@ximian.com>
4127 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
4128 complete; Fixes #37521.
4130 * delegate.cs: Use Modifiers.TypeAttr to compute the
4131 TypeAttributes, instead of rolling our own. This makes the flags
4132 correct for the delegates.
4134 2003-06-28 Miguel de Icaza <miguel@ximian.com>
4136 * class.cs (Constructor.Define): Set the private flag for static
4137 constructors as well.
4139 * cs-parser.jay (statement_expression): Set the return value to
4140 null, to avoid a crash when we catch an error.
4142 2003-06-24 Miguel de Icaza <miguel@ximian.com>
4144 * cs-parser.jay: Applied patch from Jackson that adds support for
4145 extern and unsafe modifiers to destructor declarations.
4147 * expression.cs: Report error 21 if the user is trying to index a
4150 * driver.cs: Add an error message, suggested by the bug report.
4152 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
4153 if we do not have a ": this ()" constructor initializer. Fixes 45149
4155 2003-06-14 Miguel de Icaza <miguel@ximian.com>
4157 * namespace.cs: Add some information to reduce FAQs.
4159 2003-06-13 Miguel de Icaza <miguel@ximian.com>
4161 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
4162 underlying enumeration types. Fixes #43915.
4164 * expression.cs: Treat ushort/short as legal values to be used in
4167 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
4169 * delegate.cs: transfer custom attributes for paramenters from
4170 the delegate declaration to Invoke and BeginInvoke.
4172 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
4174 * attribute.cs: handle custom marshalers and emit marshal info
4177 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
4179 * makefile.gnu: Added anonymous.cs to the compiler sources.
4181 2003-05-28 Miguel de Icaza <miguel@ximian.com>
4183 * iterators.cs: Change the name of the proxy class to include two
4186 * cs-parser.jay: Update grammar to include anonymous methods.
4188 * anonymous.cs: new file.
4190 2003-05-27 Miguel de Icaza <miguel@ximian.com>
4192 * class.cs (Field.Define): Add missing test for pointers and
4195 2003-05-27 Ravi Pratap <ravi@ximian.com>
4197 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
4198 we use the stobj opcode.
4200 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
4201 since it wasn't the correct fix.
4203 It still is puzzling that we are required to use stobj for IntPtr
4204 which seems to be a ValueType.
4206 2003-05-26 Miguel de Icaza <miguel@ximian.com>
4208 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
4209 during regular simple name resolution. Now, the trick is that
4210 instead of returning for processing the simplename, we do a
4211 TypeManager.LookupType (ie, a rooted lookup as opposed to a
4212 contextual lookup type). If a match is found, return that, if
4213 not, return for further composition.
4215 This fixes long-standing 30485.
4217 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
4218 using the address to initialize an object, do an Stobj instead of
4219 using the regular Stelem.
4221 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
4222 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
4223 Because if we are a BaseIndexerAccess that value will be true.
4226 * statement.cs (GotoCase.Resolve): Return after reporting an
4227 error, do not attempt to continue.
4229 * expression.cs (PointerArithmetic.Emit): If our operand is a
4230 long, convert our constants to match the operand before
4231 multiplying. Convert to I type before adding. Fixes 43670.
4233 2003-05-14 Ravi Pratap <ravi@ximian.com>
4235 * enum.cs (ImplicitConversionExists) : Rename to
4236 ImplicitEnumConversionExists to remove ambiguity.
4238 * ecore.cs (NullCast): New type of cast expression class which
4239 basically is very similar to EmptyCast with the difference being
4240 it still is a constant since it is used only to cast a null to
4244 * convert.cs (ImplicitReferenceConversion): When casting a null
4245 literal, we return a NullCast.
4247 * literal.cs (NullLiteralTyped): Remove - I don't see why this
4248 should be around anymore.
4250 The renaming (reported was slightly wrong). Corrections:
4252 ConvertImplicitStandard -> ImplicitConversionStandard
4253 ConvertExplicitStandard -> ExplicitConversionStandard
4255 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
4256 before passing them in !
4258 * convert.cs (ImplicitConversionStandard): When comparing for
4259 equal expr and target types, ensure that expr is not a
4262 In general, we must not be checking (expr_type ==
4263 target_type) in the top level conversion methods
4264 (ImplicitConversion, ExplicitConversion etc). This checking is
4265 done in the methods that they delegate to.
4267 2003-05-20 Miguel de Icaza <miguel@ximian.com>
4269 * convert.cs: Move Error_CannotConvertType,
4270 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
4271 ImplicitNumericConversion, ImplicitConversionExists,
4272 ImplicitUserConversionExists, StandardConversionExists,
4273 FindMostEncompassedType, FindMostSpecificSource,
4274 FindMostSpecificTarget, ImplicitUserConversion,
4275 ExplicitUserConversion, GetConversionOperators,
4276 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
4277 TryImplicitIntConversion, Error_CannotConvertImplicit,
4278 ConvertImplicitRequired, ConvertNumericExplicit,
4279 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
4280 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
4283 Perform the following renames:
4285 StandardConversionExists -> ImplicitStandardConversionExists
4286 ConvertImplicit -> ImplicitConversion
4287 ConvertImplicitStandard -> ImplicitStandardConversion
4288 TryImplicitIntConversion -> ImplicitIntConversion
4289 ConvertImplicitRequired -> ImplicitConversionRequired
4290 ConvertNumericExplicit -> ExplicitNumericConversion
4291 ConvertReferenceExplicit -> ExplicitReferenceConversion
4292 ConvertExplicit -> ExplicitConversion
4293 ConvertExplicitStandard -> ExplicitStandardConversion
4295 2003-05-19 Martin Baulig <martin@ximian.com>
4297 * statement.cs (TypeInfo.StructInfo): Made this type protected.
4298 (TypeInfo): Added support for structs having structs as fields.
4300 * ecore.cs (FieldExpr): Implement IVariable.
4301 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
4302 VariableInfo for the field.
4304 2003-05-18 Martin Baulig <martin@ximian.com>
4306 * expression.cs (This.DoResolve): Report a CS0027 if we're
4307 emitting a field initializer.
4309 2003-05-18 Martin Baulig <martin@ximian.com>
4311 * expression.cs (This.ResolveBase): New public function.
4312 (This.DoResolve): Check for CS0188.
4314 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
4317 * ecore.cs (MethodGroupExpr.DoResolve): Set the
4318 `instance_expression' to null if we don't have any non-static
4321 2003-05-18 Martin Baulig <martin@ximian.com>
4323 Reworked the way how local variables and parameters are handled by
4324 the flow analysis code.
4326 * statement.cs (TypeInfo, VariableMap): New public classes.
4327 (VariableInfo): New public class. This is now responsible for
4328 checking whether a variable has been assigned. It is used for
4329 parameters and local variables.
4330 (Block.EmitMeta): Take the InternalParameters as argument; compute
4331 the layout of the flow vectors here.
4332 (Block.LocalMap, Block.ParameterMap): New public properties.
4333 (FlowBranching): The .ctor doesn't get the InternalParameters
4334 anymore since Block.EmitMeta() now computes the layout of the flow
4336 (MyStructInfo): This class is now known as `StructInfo' and nested
4337 in `TypeInfo'; we don't access this directly anymore.
4339 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
4340 property and removed IsAssigned(), IsFieldAssigned(),
4341 SetAssigned() and SetFieldAssigned(); we now call them on the
4342 VariableInfo so we don't need to duplicate this code everywhere.
4344 * expression.cs (ParameterReference): Added `Block block' argument
4346 (LocalVariableReference, ParameterReference, This): The new
4347 VariableInfo class is now responsible for all the definite
4350 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
4351 IsParameterAssigned, SetParameterAssigned): Removed.
4353 2003-05-18 Martin Baulig <martin@ximian.com>
4355 * typemanager.cs (InitCoreTypes): Try calling
4356 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
4357 the 3-args-version. Corlib now also needs our `void_type'.
4358 (GetMethod): Added overloaded version which takes an optional
4359 `bool report_errors' to allow lookups of optional methods.
4361 2003-05-12 Martin Baulig <martin@ximian.com>
4363 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
4364 only used for locals and not for parameters.
4366 2003-05-12 Miguel de Icaza <miguel@ximian.com>
4368 * support.cs (InternalParameters.ParameterType): Return the
4369 ExternalType of the parameter.
4371 * parameter.cs (Parameter.ExternalType): drop the two arguments,
4374 2003-05-11 Miguel de Icaza <miguel@ximian.com>
4376 * class.cs (MethodData.Define): Do not set the `newslot' on
4377 interface members, if they are also flagged as "override".
4379 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
4380 better code for ++i and i++. This only works for static fields
4381 and local variables.
4383 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
4384 want to pull the DeclSpace out of the builder_to_declspace instead
4385 of the TypeBuilder (like in TypeContainer.FindMembers).
4387 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
4388 instead of LookupTypeContainer. Fixes the crash on .NET for
4389 looking up interface members.
4391 * const.cs: Create our own emit context during the Definition
4392 stage, so that constants are evaluated in the proper context, when
4393 a recursive definition happens.
4395 2003-05-11 Martin Baulig <martin@ximian.com>
4397 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
4398 new block for a switch section.
4399 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
4400 the adding/lookup in the switch block. Fixes #39828.
4402 2003-05-09 Miguel de Icaza <miguel@ximian.com>
4404 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
4405 functionality: I needed to convert the data after I had performed
4406 the add/sub operation into the operands type size.
4408 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
4409 pass the type for the box operation, otherwise the resulting
4410 object would have been of type object.
4412 (BoxedCast): Add constructor to specify the type to box as.
4414 2003-05-07 Miguel de Icaza <miguel@ximian.com>
4416 * iterators.cs: I was reusing the `count' variable inadvertently,
4417 take steps to not allow this to happen.
4419 2003-05-06 Miguel de Icaza <miguel@ximian.com>
4421 * attribute.cs (Attribute.Resolve): Params attributes are encoded
4422 by creating an array at the point where the params starts and
4423 putting all those arguments there, then adjusting the size of the
4426 2003-05-05 Miguel de Icaza <miguel@ximian.com>
4428 * expression.cs (New.AddressOf): Implement interface
4429 IMemoryLocation. This is used when the `new' operator is used in
4430 the context of an invocation to a method on a value type.
4432 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
4435 * namespace.cs: Also check the using aliases here.
4437 * driver.cs: Move the test for using validity after the types have
4438 been entered, so we do a single pass that also includes the using
4441 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
4442 in the regular case. CreateSiblingForFinally is doing extra
4445 * attribute.cs (GetAttributeArgumentExpression): Store the result
4446 on an out value, and use the return value to indicate failure
4447 instead of using null (which is a valid return for Constant.GetValue).
4449 * statement.cs: Perform the analysis flow for the increment
4450 portion after the statement, because this will be the real flow of
4451 execution. Fixes #42385
4453 * codegen.cs (EmitContext.EmitArgument,
4454 EmitContext.EmitStoreArgument): New helper functions when the
4455 RemapToProxy flag is set.
4457 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
4460 Add support for remapping parameters.
4462 * iterators.cs: Propagate parameter values; Store parameter
4463 values in the proxy classes.
4465 2003-05-04 Miguel de Icaza <miguel@ximian.com>
4467 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
4468 need a proxy reference; I do not know what I was thinking
4470 * cs-parser.jay (constructor_initializer): catch another error,
4471 and display nice message.
4473 (field_declaration): catch void field declaration
4474 to flag a better error.
4476 * class.cs (MemberBase.CheckBase): Report an error instead of a
4477 warning if a new protected member is declared in a struct.
4478 (Field.Define): catch the error of readonly/volatile.
4480 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
4482 (FieldExpr.AddressOf): ditto. Catch error where the address of a
4483 volatile variable is taken
4485 2003-05-02 Miguel de Icaza <miguel@ximian.com>
4487 * statement.cs (Fixed.Resolve): Report an error if we are not in
4490 2003-05-01 Miguel de Icaza <miguel@ximian.com>
4492 * typemanager.cs: reuse the code that handles type clashes for
4493 delegates and enumerations.
4495 * class.cs (Report28): Always report.
4497 * expression.cs (EncodeAsAttribute): Allow nulls here.
4499 2003-04-28 Miguel de Icaza <miguel@ximian.com>
4501 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
4502 the functionality for testing whether an expression is valid for
4503 an attribute here. Also handle the case of arrays of elements
4506 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
4507 encoding a linear array into an array of objects that are suitable
4508 to be passed to an CustomAttributeBuilder.
4510 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
4512 * ecore.cs: (FieldExpr): Handle field remapping here.
4514 * iteratators.cs: Pass the instance variable (if the method is an
4515 instance method) to the constructors, so we can access the field
4516 variables on the class.
4518 TODO: Test this with structs. I think the THIS variable on
4519 structs might have to be a pointer, and not a refenrece
4521 2003-04-27 Miguel de Icaza <miguel@ximian.com>
4523 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
4524 local variables to fields in a proxy class.
4526 * iterators.cs (PopulateProxy): Rename our internal fields to
4528 Create a <THIS> field if we are an instance method, so we can
4529 reference our parent container variables.
4530 (MapVariable): Called back from the EmitContext code to enter a
4531 new variable to field mapping into the proxy class (we just create
4535 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
4536 for using the remapped locals to fields.
4538 I placed the code here, because that gives the same semantics to
4539 local variables, and only changes the Emit code.
4541 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
4542 statements inside iterators.
4543 (VariableInfo): Add a FieldBuilder for the cases when we are
4544 remapping local variables to fields in a proxy class
4546 * ecore.cs (SimpleNameResolve): Avoid testing two times for
4547 current_block != null.
4549 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
4550 not cope with strings, as it has been moved to the
4551 TableSwitchEmit. Fixed bug in switch generation.
4553 * expression.cs (New.DoResolve): Provide more context for the user
4554 when reporting an error.
4556 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
4559 * expression.cs (MemberAccess.DoResolve): When we get a type back,
4560 check the permissions for it. Note than in a type-resolution
4561 context the check was already present in DeclSpace.ResolveType,
4562 but was missing from the MemberAccess.
4564 (ArrayCreation.CheckIndices): warn if the user has
4565 more nested levels of expressions, but there are no more
4566 dimensions specified. Avoids crash on bug 41906.
4568 2003-04-26 Miguel de Icaza <miguel@ximian.com>
4570 * statement.cs (Block): replace Implicit bool, for a generic
4572 New flag: `Unchecked'. This is used during the EmitMeta phase
4573 (which is out-of-line with the regular Resolve/Emit process for a
4574 statement, as this is done ahead of time, but still gets a chance
4575 to call constant resolve).
4577 (Block.Flags): new enum for adding a new flag.
4579 (Block.EmitMeta): track the state of unchecked.
4581 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
4582 to enable constant resolution to work there as well.
4584 2003-04-22 Miguel de Icaza <miguel@ximian.com>
4586 * typemanager.cs (ienumerable_type): Also look up
4587 System.Collections.IEnumerable.
4589 2003-04-21 Miguel de Icaza <miguel@ximian.com>
4591 TODO: Test more than one conditional per method.
4593 * class.cs (Indexer.Define): Report the location where the user is
4594 referencing the unsupported feature.
4596 (MethodData): Overload the use of `conditionals' to
4597 minimize the creation of needless ArrayLists. This saves roughly
4598 212kb on my machine.
4600 (Method): Implement the new IIteratorContainer interface.
4601 (Method.SetYields): Implement the method by setting the ModFlags
4602 to contain METHOD_YIELDS.
4604 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
4605 which just got set to null.
4607 * iterators.cs: New file.
4609 (Yield, YieldBreak): New statements.
4611 * statement.cs (Return.Resolve): Flag an error if we are used in
4614 * codegen.cs (InIterator): New flag set if the code is being
4615 compiled in an iterator method.
4617 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
4618 internal modifier, and we just use it to avoid adding extra
4619 fields, as this is seldom used.
4621 * cs-parser.jay: Add yield_statement (yield and yield break).
4623 * driver.cs: New flag -v2 to turn on version 2 features.
4625 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
4626 hashtable when v2 is enabled.
4628 2003-04-20 Miguel de Icaza <miguel@ximian.com>
4630 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
4631 there is already a namespace defined with this name.
4633 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
4634 people upgraded their corlibs.
4636 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
4637 always use fully qualified types, no need to use the compiler
4640 (TypeManager.IsNamespace): Use binarysearch.
4642 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
4643 AddDelegate): I did not quite use the new IsValid API properly: I
4644 have to pass the short-name and the fullname. I was passing only
4645 the basename instead of the fullname sometimes.
4647 (TypeContainer.DefineType): call NamespaceClash.
4649 * interface.cs (Interface.DefineType): use NamespaceClash before
4652 * delegate.cs (Delegate.DefineType): use NamespaceClash before
4655 * enum.cs: (Enum.DefineType): use NamespaceClash before
4658 * typemanager.cs (: 3-line patch that gives us some tasty 11%
4659 speed increase. First, use the negative_hits cache when we get a
4660 negative. Second, add the type with its full original name
4661 instead of the new . and + encoded name (reflection uses + to
4662 separate type from a nested type). Use LookupTypeReflection
4663 directly which bypasses the type->name hashtable (that we already
4664 know does not contain the type.
4666 * decl.cs (DeclSpace.ResolveTypeExpr): track the
4667 location/container type.
4669 * driver.cs: When passing utf8, use directly the UTF8Encoding.
4671 2003-04-19 Miguel de Icaza <miguel@ximian.com>
4673 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
4675 * delegate.cs (NewDelegate.Resolve): Test whether an instance
4676 method is being referenced in the method group from a static
4677 context, and report error 120 if so.
4679 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
4682 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
4683 is created, we create the A namespace).
4685 * cs-parser.jay: A namespace also introduces a DeclarationFound.
4688 2003-04-18 Miguel de Icaza <miguel@ximian.com>
4690 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
4691 invocation to ModuleBuilder.GetType with the same values will
4692 return a new type instance, so we need to cache its return
4695 * expression.cs (Binary.ResolveOperator): Only allow the compare
4696 operators on enums if they are of the same type.
4698 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
4699 types of ValueType on their own case. Before we were giving them
4700 the same treatment as objects.
4702 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
4703 fullname. Short name is used to compare against container name.
4704 Fullname is used to check against defined namespace names.
4706 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
4707 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
4709 (Method.CheckBase): Call parent.
4710 (MemberBase.CheckBase): Check for protected members on sealed
4712 (PropertyBase.CheckBase): Call parent.
4713 (Field.Define): Call parent.
4715 * report.cs: Negative error codes are now mapped to 8000 - code,
4716 so that the display is render more nicely.
4718 * typemanager.cs: Do not use try/catch, instead report a regular
4721 (GetPointerType, GetReferenceType): These methods provide
4722 mechanisms to obtain the T* and T& from a T. We had the code
4723 previously scattered around the code base, and it also used
4724 TypeManager.LookupType that would go through plenty of caches.
4725 This one goes directly to the type source.
4727 In some places we did the Type.GetType followed by
4728 ModuleBuilder.GetType, but not in others, so this unifies the
4731 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
4732 statements now that we have namespace information.
4734 * typemanager.cs (IsNamespace): New method, returns whether the
4735 string presented is a namespace or not.
4737 (ComputeNamespaces): New public entry point, computes the list of
4738 available namespaces, using the GetNamespaces API call in Mono, or
4739 the slower version in MS.NET.
4741 Now before we start the semantic analysis phase, we have a
4742 complete list of namespaces including everything that the user has
4745 Deleted old code to cache namespaces in .nsc files.
4747 2003-04-17 Miguel de Icaza <miguel@ximian.com>
4749 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
4750 class/struct location definition Location for the implicit
4751 constructor location.
4753 (Operator.Define): Use the location of the operator for the
4754 implicit Method definition.
4756 (Constructor.Emit): use the constructor location for the implicit
4757 base initializer constructor.
4759 * ecore.cs: Remove ITypeExpression. This interface is now gone,
4760 and the Expression class now contains two new methods:
4762 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
4763 isolate type lookup from the rest of the resolution process.
4765 Since we use Expressions to hold type definitions due to the way
4766 we parse the input we have historically overloaded Resolve to
4767 perform the Type lookups if a special flag is passed. Now this is
4768 eliminated and two methods take their place.
4770 The differences in the two methods between xStep and xTerminal is
4771 that xStep is involved in our current lookup system that uses
4772 SimpleNames to compose a name, while xTerminal is used just to
4773 catch the case where the simplename lookup failed.
4775 2003-04-16 Miguel de Icaza <miguel@ximian.com>
4777 * expression.cs (ResolveMemberAccess): Remove redundant code.
4778 TypeExpr expressions are always born fully resolved.
4780 * interface.cs (PopulateMethod): Do not lookup the types twice.
4781 We were doing it once during SemanticAnalysis and once during
4784 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
4785 in local variable type definitions, were being returned as a
4786 SimpleName (we decomposed everything into a string), that is
4787 because primary_expression was being used instead of a type in the
4788 grammar (reduce/reduce conflicts).
4790 The part that was wrong is that we converted the expression into a
4791 string (an oversimplification in one hand, compounded with primary
4792 expressions doing string concatenation).
4798 Would return "A.B.C[]" as a SimpleName. This stopped things like
4799 using clauses from working on this particular context. And a type
4800 was being matched directly against "A.B.C[]".
4802 We now use the correct approach, and allow for ComposedCast to be
4803 part of the unary expression. So the "A.B.C []" become a composed
4804 cast of "A.B.C" (as a nested group of MemberAccess with a
4805 SimpleName at the end) plus the rank composition "[]".
4809 2003-04-10 Miguel de Icaza <miguel@ximian.com>
4811 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
4812 for the access level checking.
4814 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
4815 `TypeContainer container', because I kept getting confused when I
4816 was debugging this code.
4818 * expression.cs (Indexers): Instead of tracking getters/setters,
4819 we now track them in parallel. We create one arraylist less, but
4820 most importantly it is possible now for the LValue code to find a
4821 matching get for a set.
4823 (IndexerAccess.DoResolveLValue): Update the code.
4824 GetIndexersForType has been modified already to extract all the
4825 indexers from a type. The code assumed it did not.
4827 Also make the code set the correct return type for the indexer.
4828 This was fixed a long time ago for properties, but was missing for
4829 indexers. It used to be void_type.
4831 (Binary.Emit): Test first for doubles instead of
4832 floats, as they are more common.
4834 (Binary.EmitBranchable): Use the .un version of the branch opcodes
4835 when dealing with floats and the <=, >= operators. This fixes bug
4838 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
4839 to load the array value by emitting a load on the foreach variable
4840 type. This was incorrect.
4842 We now emit the code to load an element using the the array
4843 variable type, and then we emit the conversion operator.
4847 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
4849 * attribute.cs: Avoid allocation of ArrayLists in the common case.
4851 2003-04-09 Miguel de Icaza <miguel@ximian.com>
4853 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
4854 test for protection before we test for signatures.
4856 (MethodSignature.ToString): implement.
4858 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
4859 to the case where we reduced into a LongConstant.
4861 * decl.cs (CheckAccessLevel): If the type is an array, we can not
4862 depend on whether the information is acurrate, because the
4863 Microsoft runtime will always claim that the array type is public,
4864 regardless of the real state.
4866 If the type is a pointer, another problem happens: the type is
4867 reported as non-public in Microsoft.
4869 In both cases we have to call CheckAccessLevel recursively with
4870 the underlying type as the argument to be tested.
4872 2003-04-08 Miguel de Icaza <miguel@ximian.com>
4874 * assign.cs (Assign.Emit): If we are dealing with a compound
4875 assignment expression, we should use the code path that stores the
4876 intermediate result in a temporary value. This fixes #40903.
4878 *expression.cs (Indirection.ToString): Provide ToString method for
4881 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
4883 * class.cs: Null out fields holding references to Block objects so
4884 they can be garbage collected.
4886 * expression.cs (OverloadResolve): Remove unused local.
4888 2003-04-07 Martin Baulig <martin@ximian.com>
4890 * codegen.cs (EmitContext.CurrentFile): New public field.
4891 (EmitContext.Mark): Use the CurrentFile to check whether the
4892 location is in the correct file.
4893 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
4895 2003-04-07 Martin Baulig <martin@ximian.com>
4897 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
4899 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
4900 location. [FIXME: The location argument which gets passed to this
4901 method is sometimes wrong!]
4903 2003-04-07 Nick Drochak <ndrochak@gol.com>
4905 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
4907 2003-04-07 Miguel de Icaza <miguel@ximian.com>
4909 * expression.cs (Indirection.EmitAssign): We were using the
4910 temporary, but returning immediately instead of continuing the
4913 2003-04-06 Martin Baulig <martin@ximian.com>
4915 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
4916 if it's a nested child, but also deriving from the outer class.
4919 * typemanager.cs (IsNestedChildOf): Make this work if it's a
4920 nested child, but also deriving from the outer class. See
4922 (FilterWithClosure): We may access private members of the outer
4923 class if we're a nested child and deriving from the outer class.
4924 (RealMemberLookup): Only set `closure_private_ok' if the
4925 `original_bf' contained BindingFlags.NonPublic.
4927 2003-04-05 Martin Baulig <martin@ximian.com>
4929 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
4931 2003-04-02 Miguel de Icaza <miguel@ximian.com>
4933 * class.cs (Event.Define): Do not allow abstract events to have
4936 2003-04-01 Miguel de Icaza <miguel@ximian.com>
4938 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
4939 block in event declarations.
4941 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
4942 value type, get its address.
4944 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
4945 leaving a class on the stack instead of a boolean value (int
4946 0/1). Change the code so we compare against null, and then the
4947 result against zero.
4949 * class.cs (TypeContainer.GetClassBases): We were checking for the
4950 parent class being sealed too late.
4952 * expression.cs (Binary.Emit): For <= and >= when dealing with
4953 floating point values, use cgt.un and clt.un instead of cgt and
4956 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
4958 * statement.cs: Apply the same optimization as MS: skip the
4959 GetEnumerator returning an IEnumerator, and use the one returning a
4960 CharEnumerator instead. This allows us to avoid the try-finally block
4963 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
4965 * cs-parser.jay: Attributes cannot be applied to
4966 namespaces. Fixes #40473
4968 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4971 (Add*): check if the name is valid using the full name for constants,
4972 fields, properties and events.
4974 2003-03-28 Miguel de Icaza <miguel@ximian.com>
4976 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
4977 char constants to be part of the enumeration.
4979 * expression.cs (Conditional.DoResolve): Add support for operator
4980 true. Implements the missing functionality from 14.12
4982 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
4983 operator true/false as required by the spec.
4985 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
4986 implicit conversion to boolean.
4988 * statement.cs (Statement.ResolveBoolean): A boolean expression is
4989 also one where the type implements `operator true'.
4991 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
4992 get an expression that will invoke operator true based on an
4995 (GetConversionOperators): Removed the hack that called op_True
4998 (Expression.ResolveBoolean): Move this from Statement.
5000 2003-03-17 Miguel de Icaza <miguel@ximian.com>
5002 * ecore.cs (FieldExpr): do not allow initialization of initonly
5003 fields on derived classes
5005 2003-03-13 Martin Baulig <martin@ximian.com>
5007 * statement.cs (Block.Emit): Call ig.BeginScope() and
5008 ig.EndScope() when compiling with debugging info; call
5009 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
5011 2003-03-08 Miguel de Icaza <miguel@ximian.com>
5013 * expression.cs (Indexers): Do not construct immediately, allow
5014 for new members to be appended as we go. Fixes 38143
5016 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5018 * expression.cs: save/restore context when resolving an unchecked
5021 2003-03-05 Miguel de Icaza <miguel@ximian.com>
5023 * cfold.cs: Catch division by zero in modulus operator during
5026 2003-03-03 Miguel de Icaza <miguel@ximian.com>
5028 * interface.cs (Interface.DefineMembers): Avoid defining members
5031 2003-02-27 Miguel de Icaza <miguel@ximian.com>
5033 * driver.cs: handle the +/- options for -noconfig
5035 * statement.cs (Unckeched.Resolve): Also track the state of
5036 unchecked in the Resolve phase.
5038 2003-02-27 Martin Baulig <martin@ximian.com>
5040 * ecore.cs (Expression.MemberLookup): Don't create a
5041 MethodGroupExpr for something which is not a method. Fixes #38291.
5043 2003-02-25 Miguel de Icaza <miguel@ximian.com>
5045 * class.cs (MemberBase.CheckParameters): Also check that the type
5046 is unmanaged if it is a pointer.
5048 * expression.cs (SizeOf.Resolve): Add location information.
5050 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
5051 a managed type is declared.
5053 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
5054 parameter modifiers as well. Fixes bug 38606
5056 * class.cs: Very sad. Am backing out the speed up changes
5057 introduced by the ArrayList -> Array in the TypeContainer, as they
5058 were not actually that much faster, and introduced a bug (no error
5059 reports on duplicated methods).
5061 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
5062 source first, this will guarantee that we have a valid expression
5063 before calling in lower levels functions that will require a
5064 resolved object. Then use this original_source in the
5065 target.ResolveLValue instead of the original source that was
5068 Another change. Use target.Resolve instead of LValueResolve.
5069 Although we are resolving for LValues, we will let the Assign code
5070 take care of that (it will be called again from Resolve). This
5071 basically allows code like this:
5073 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
5074 class Y { void A (X x) { x [0] += o; }
5076 The problem was that the indexer was trying to resolve for
5077 set_Item (idx, object o) and never finding one. The real set_Item
5078 was set_Item (idx, X). By delaying the process we get the right
5083 2003-02-23 Martin Baulig <martin@ximian.com>
5085 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
5086 while calling DoEmit ().
5088 * codegen.cs (EmitContext.Mark): Don't mark locations in other
5089 source files; if you use the #line directive inside a method, the
5090 compiler stops emitting line numbers for the debugger until it
5091 reaches the end of the method or another #line directive which
5092 restores the original file.
5094 2003-02-23 Martin Baulig <martin@ximian.com>
5096 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
5098 2003-02-23 Martin Baulig <martin@ximian.com>
5100 * statement.cs (Block.AddChildVariableNames): We need to call this
5101 recursively, not just for our immediate children.
5103 2003-02-23 Martin Baulig <martin@ximian.com>
5105 * class.cs (Event.Define): Always make the field private, like csc does.
5107 * typemanager.cs (TypeManager.RealMemberLookup): Make events
5108 actually work, fixes bug #37521.
5110 2003-02-23 Miguel de Icaza <miguel@ximian.com>
5112 * delegate.cs: When creating the various temporary "Parameters"
5113 classes, make sure that we call the ComputeAndDefineParameterTypes
5114 on those new parameters (just like we do with the formal ones), to
5115 allow them to be resolved in the context of the DeclSpace.
5117 This fixes the bug that Dick observed in Bugzilla #38530.
5119 2003-02-22 Miguel de Icaza <miguel@ximian.com>
5121 * expression.cs (ResolveMemberAccess): When resolving a constant,
5122 do not attempt to pull a constant if the value was not able to
5123 generate a valid constant.
5125 * const.cs (LookupConstantValue): Do not report more errors than required.
5127 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5129 * expression.cs: fixes bug #38328.
5131 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5133 * class.cs: Changed all the various members that can be part of a
5134 class from being an ArrayList to be an Array of the right type.
5135 During the DefineType type_list, interface_list, delegate_list and
5136 enum_list are turned into types, interfaces, delegates and enums
5139 And during the member population, indexer_list, event_list,
5140 constant_list, field_list, instance_constructor_list, method_list,
5141 operator_list and property_list are turned into their real arrays.
5143 Although we could probably perform this operation earlier, for
5144 good error reporting we need to keep the lists and remove the
5145 lists for longer than required.
5147 This optimization was triggered by Paolo profiling the compiler
5148 speed on the output of `gen-sample-program.pl' perl script.
5150 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
5151 not crash in methods like MemberLookupFailed that use this field.
5153 This problem arises when the compiler fails to resolve a type
5154 during interface type definition for example.
5156 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5158 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
5159 inherit from System.Object, so we have to stop at null, not only
5160 when reaching System.Object.
5162 2003-02-17 Miguel de Icaza <miguel@ximian.com>
5164 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
5165 DeclaredOnly because the parent indexer might have had a different
5166 name, but did not loop until the top of the hierarchy was reached.
5168 The problem this one fixes is 35492: when a class implemented an
5169 indexer from an interface, we were getting the interface method
5170 (which was abstract) and we were flagging an error (can not invoke
5173 This also keeps bug 33089 functioning, and test-148 functioning.
5175 * typemanager.cs (IsSpecialMethod): The correct way of figuring
5176 out if a method is special is to see if it is declared in a
5177 property or event, or whether it is one of the predefined operator
5178 names. This should fix correctly #36804.
5180 2003-02-15 Miguel de Icaza <miguel@ximian.com>
5182 The goal here is to remove the dependency on EmptyCast.Peel ().
5183 Killing it completely.
5185 The problem is that currently in a number of places where
5186 constants are expected, we have to "probe" for an EmptyCast, and
5187 Peel, which is not the correct thing to do, as this will be
5188 repetitive and will likely lead to errors.
5190 The idea is to remove any EmptyCasts that are used in casts that
5191 can be reduced to constants, so we only have to cope with
5194 This bug hunt was triggered by Bug 37363 and the desire to remove
5195 the duplicate pattern where we were "peeling" emptycasts to check
5196 whether they were constants. Now constants will always be
5199 * ecore.cs: Use an enumconstant here instead of wrapping with
5202 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
5203 throwing me off. By handling this we can get rid of a few hacks.
5205 * statement.cs (Switch): Removed Peel() code.
5207 2003-02-14 Miguel de Icaza <miguel@ximian.com>
5209 * class.cs: Location information for error 508
5211 * expression.cs (New.DoResolve): Add a guard against double
5212 resolution of an expression.
5214 The New DoResolve might be called twice when initializing field
5215 expressions (see EmitFieldInitializers, the call to
5216 GetInitializerExpression will perform a resolve on the expression,
5217 and later the assign will trigger another resolution
5219 This leads to bugs (#37014)
5221 * delegate.cs: The signature for EndInvoke should contain any ref
5222 or out parameters as well. We were not doing this in the past.
5224 * class.cs (Field.Define): Do not overwrite the type definition
5225 inside the `volatile' group. Turns out that volatile enumerations
5226 were changing the type here to perform a validity test, which
5229 2003-02-12 Miguel de Icaza <miguel@ximian.com>
5231 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
5232 and structs, we do not want to load the instance variable
5234 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
5235 enum_type has to be handled like an object reference (implicit
5236 conversions exists from this to object), but the regular IsClass
5237 and IsValueType tests will never return true for this one.
5239 Also we use TypeManager.IsValueType instead of type.IsValueType,
5240 just for consistency with the rest of the code (this is only
5241 needed if we ever use the construct exposed by test-180.cs inside
5242 corlib, which we dont today).
5244 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
5246 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
5249 2003-02-09 Martin Baulig <martin@ximian.com>
5251 * namespace.cs (Namespace..ctor): Added SourceFile argument.
5252 (Namespace.DefineNamespaces): New static public method; this is
5253 called when we're compiling with debugging to add all namespaces
5256 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
5257 pass it to the Namespace's .ctor.
5259 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
5260 and MethodBase arguments; pass the namespace ID to the symwriter;
5261 pass the MethodBase instead of the token to the symwriter.
5262 (SymbolWriter.DefineNamespace): New method to add a namespace to
5265 2003-02-09 Martin Baulig <martin@ximian.com>
5267 * symbolwriter.cs: New file. This is a wrapper around
5268 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
5269 methods here in near future.
5271 2003-02-09 Martin Baulig <martin@ximian.com>
5273 * codegen.cs (EmitContext.Mark): Just pass the arguments to
5274 ILGenerator.MarkSequencePoint() which are actually used by the
5277 2003-02-09 Martin Baulig <martin@ximian.com>
5279 * location.cs (SourceFile): New public sealed class. This
5280 contains the name and an index which is used in the location's token.
5281 (Location): Reserve an appropriate number of bits in the token for
5282 the source file instead of walking over that list, this gives us a
5283 really huge performance improvement when compiling with debugging.
5285 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
5286 `SourceFile' argument instead of a string.
5287 (Driver.ProcessFile): Add all the files via Location.AddFile(),
5288 but don't parse/tokenize here, we need to generate the list of all
5289 source files before we do that.
5290 (Driver.ProcessFiles): New static function. Parses/tokenizes all
5293 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
5294 instead of a string.
5296 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
5299 2003-02-09 Martin Baulig <martin@ximian.com>
5301 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
5302 filename on `#line default'.
5304 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
5306 * statement.cs: don't clear the pinned var when the fixed statement
5307 returns from the method (fixes bug#37752).
5309 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
5311 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
5314 2003-02-07 Martin Baulig <martin@ximian.com>
5316 * driver.cs: Removed the `--debug-args' command line argument.
5318 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
5319 automatically by the AsssemblyBuilder.
5320 (CodeGen.InitializeSymbolWriter): We don't need to call any
5321 initialization function on the symbol writer anymore. This method
5322 doesn't take any arguments.
5324 2003-02-03 Miguel de Icaza <miguel@ximian.com>
5326 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
5327 from referenced assemblies as well.
5329 2003-02-02 Martin Baulig <martin@ximian.com>
5331 * class.cs (MethodData.Emit): Generate debugging info for external methods.
5333 2003-02-02 Martin Baulig <martin@ximian.com>
5335 * class.cs (Constructor.Emit): Open the symbol writer before
5336 emitting the constructor initializer.
5337 (ConstructorInitializer.Emit): Call ec.Mark() to allow
5338 single-stepping through constructor initializers.
5340 2003-01-30 Miguel de Icaza <miguel@ximian.com>
5342 * class.cs: Handle error 549: do not allow virtual methods in
5345 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
5347 * decl.cs: Check access levels when resolving types
5349 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
5351 * statement.cs: Add parameters and locals set in catch blocks that might
5352 return to set vector
5354 2003-01-29 Miguel de Icaza <miguel@ximian.com>
5356 * class.cs (Operator): Set the SpecialName flags for operators.
5358 * expression.cs (Invocation.DoResolve): Only block calls to
5359 accessors and operators on SpecialName methods.
5361 (Cast.TryReduce): Handle conversions from char constants.
5364 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
5366 * statement.cs: small memory and time optimization in FlowBranching.
5368 2003-01-28 Pedro Mart <yoros@wanadoo.es>
5370 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
5371 problem that the last fix but in the other sid (Set).
5373 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
5374 access when there is no indexer in the hierarchy.
5376 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
5378 * class.cs: Combine some if statements.
5380 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5382 * driver.cs: fixed bug #37187.
5384 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
5386 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
5387 any indexer, it's needed to build a list with all the indexers in the
5388 hierarchy (AllGetters), else we have problems. Fixes #35653.
5390 2003-01-23 Miguel de Icaza <miguel@ximian.com>
5392 * class.cs (MethodData.Define): It is wrong for an interface
5393 implementation to be static in both cases: explicit and implicit.
5394 We were only handling this in one case.
5396 Improve the if situation there to not have negations.
5398 * class.cs (Field.Define): Turns out that we do not need to check
5399 the unsafe bit on field definition, only on usage. Remove the test.
5401 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5403 * driver.cs: use assembly.Location instead of Codebase (the latest
5404 patch made mcs fail when using MS assemblies).
5406 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
5408 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
5409 get the path to *corlib.dll.
5411 2003-01-21 Nick Drochak <ndrochak@gol.com>
5415 * typemanager.cs: Remove compiler warnings
5417 2003-01-20 Duncan Mak <duncan@ximian.com>
5419 * AssemblyInfo.cs: Bump the version number to 0.19.
5421 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5423 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
5425 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
5427 * class.cs (Constructor::Emit): Emit debugging info for constructors.
5429 2003-01-17 Miguel de Icaza <miguel@ximian.com>
5431 * cs-parser.jay: Small fix: we were not comparing the constructor
5432 name correctly. Thanks to Zoltan for the initial pointer.
5434 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
5436 * cs-tokenizer.cs: Set file name when specified with #line
5438 2003-01-15 Miguel de Icaza <miguel@ximian.com>
5440 * cs-parser.jay: Only perform the constructor checks here if we
5441 are named like the class; This will help provider a better
5442 error. The constructor path is taken when a type definition is
5443 not found, but most likely the user forgot to add the type, so
5444 report that rather than the constructor error.
5446 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
5448 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
5451 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
5453 * cs-parser.jay: Add cleanup call.
5455 2003-01-13 Duncan Mak <duncan@ximian.com>
5457 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
5458 consistent with other methods.
5460 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
5462 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
5464 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
5466 * attribute.cs: only set GuidAttr to true when we have a
5469 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5473 * typemanager.cs: fixes to allow mcs compile corlib with the new
5474 Type.IsSubclassOf fix.
5476 2003-01-08 Miguel de Icaza <miguel@ximian.com>
5478 * expression.cs (LocalVariableReference.DoResolve): Classify a
5479 constant as a value, not as a variable. Also, set the type for
5482 * cs-parser.jay (fixed_statement): take a type instead of a
5483 pointer_type, so we can produce a better error message later.
5485 * statement.cs (Fixed.Resolve): Flag types that are not pointers
5488 (For.DoEmit): Make inifinite loops have a
5489 non-conditional branch back.
5491 (Fixed.DoEmit): First populate the pinned variables, then emit the
5492 statement, then clear the variables. Before I was emitting the
5493 code once for each fixed piece.
5496 2003-01-08 Martin Baulig <martin@ximian.com>
5498 * statement.cs (FlowBranching.MergeChild): A break in a
5499 SWITCH_SECTION does not leave a loop. Fixes #36155.
5501 2003-01-08 Martin Baulig <martin@ximian.com>
5503 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
5504 lives in the same number space than `param_map'. Fixes #36154.
5506 2003-01-07 Miguel de Icaza <miguel@ximian.com>
5508 * cs-parser.jay (constructor_declaration): Set the
5509 Constructor.ModFlags before probing for it. This makes the
5510 compiler report 514, 515 and 132 (the code was there, but got
5513 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
5514 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
5515 (GotoCase.Resolve): Set `Returns' to ALWAYS.
5517 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
5519 * enum.cs: create the enum static fields using the enum type.
5521 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
5523 * class.cs: don't try to create the ParamBuilder for the return
5524 type if it's not needed (and handle it breaking for the ms runtime
5527 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
5529 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
5531 2002-12-29 Miguel de Icaza <miguel@ximian.com>
5533 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
5534 the command. This showed up while compiling the JANET source
5535 code, which used \r as its only newline separator.
5537 2002-12-28 Miguel de Icaza <miguel@ximian.com>
5539 * class.cs (Method.Define): If we are an operator (because it
5540 reuses our code), then set the SpecialName and HideBySig. #36128
5542 2002-12-22 Miguel de Icaza <miguel@ximian.com>
5544 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
5545 exception, report error 120 `object reference required'.
5547 * driver.cs: Add --pause option, used during to measure the size
5548 of the process as it goes with --timestamp.
5550 * expression.cs (Invocation.DoResolve): Do not allow methods with
5551 SpecialName to be invoked.
5553 2002-12-21 Miguel de Icaza <miguel@ximian.com>
5555 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
5556 number before adding it.
5558 2002-12-21 Ravi Pratap <ravi@ximian.com>
5560 * ecore.cs (StandardImplicitConversion): When in an unsafe
5561 context, we allow conversion between void * to any other pointer
5562 type. This fixes bug #35973.
5564 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
5566 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
5567 is not thrown when extensionless outputs are used
5569 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5571 * rootcontext.cs: fixed compilation of corlib.
5573 2002-12-19 Miguel de Icaza <miguel@ximian.com>
5575 * attribute.cs (Attributes.Contains): Add new method.
5577 * class.cs (MethodCore.LabelParameters): if the parameter is an
5578 `out' parameter, check that no attribute `[In]' has been passed.
5580 * enum.cs: Handle the `value__' name in an enumeration.
5582 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
5584 * decl.cs: Added special case to allow overrides on "protected
5587 2002-12-18 Ravi Pratap <ravi@ximian.com>
5589 * attribute.cs (Attributes.AddAttributeSection): Rename to this
5590 since it makes much more sense.
5592 (Attributes.ctor): Don't require a Location parameter.
5594 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
5596 * attribute.cs (ApplyAttributes): Remove extra Location parameters
5597 since we already have that information per attribute.
5599 * everywhere : make appropriate changes.
5601 * class.cs (LabelParameters): Write the code which actually
5602 applies attributes to the return type. We can't do this on the MS
5603 .NET runtime so we flag a warning in the case an exception is
5606 2002-12-18 Miguel de Icaza <miguel@ximian.com>
5608 * const.cs: Handle implicit null conversions here too.
5610 2002-12-17 Ravi Pratap <ravi@ximian.com>
5612 * class.cs (MethodCore.LabelParameters): Remove the extra
5613 Type [] parameter since it is completely unnecessary. Instead
5614 pass in the method's attributes so that we can extract
5615 the "return" attribute.
5617 2002-12-17 Miguel de Icaza <miguel@ximian.com>
5619 * cs-parser.jay (parse): Use Report.Error to flag errors instead
5620 of ignoring it and letting the compile continue.
5622 * typemanager.cs (ChangeType): use an extra argument to return an
5623 error condition instead of throwing an exception.
5625 2002-12-15 Miguel de Icaza <miguel@ximian.com>
5627 * expression.cs (Unary.TryReduce): mimic the code for the regular
5628 code path. Perform an implicit cast in the cases where we can
5629 implicitly convert to one of the integral types, and then reduce
5630 based on that constant. This fixes bug #35483.
5632 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5634 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
5636 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5638 * namespace.cs: fixed bug #35489.
5640 2002-12-12 Miguel de Icaza <miguel@ximian.com>
5642 * class.cs: Remove some dead code.
5644 * cs-parser.jay: Estimate the number of methods needed
5645 (RootContext.MethodCount);
5647 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
5648 numbers instead of StringBuilders.
5650 * support.cs (PtrHashtable): Add constructor with initial size;
5651 We can now reduce reallocations of the method table.
5653 2002-12-10 Ravi Pratap <ravi@ximian.com>
5655 * attribute.cs (ApplyAttributes): Keep track of the emitted
5656 attributes on a per-target basis. This fixes bug #35413.
5658 2002-12-10 Miguel de Icaza <miguel@ximian.com>
5660 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
5661 default to the Windows 1252 encoding.
5663 (UnixParseOption): Support version, thanks to Alp for the missing
5666 * AssemblyInfo.cs: Add nice assembly information.
5668 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
5671 * cs-parser.jay: Allow a trailing comma before the close bracked
5672 in the attribute_section production.
5674 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
5675 address of the instance was being taken, I will take this out,
5676 because we take the address of the object immediately here.
5678 2002-12-09 Ravi Pratap <ravi@ximian.com>
5680 * typemanager.cs (AreMultipleAllowed): Take care of the most
5681 obvious case where attribute type is not in the current assembly -
5684 2002-12-08 Miguel de Icaza <miguel@ximian.com>
5686 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
5687 definitions, instead of doing that afterwards.
5689 Also we use a nice little hack, depending on the constructor, we
5690 know if we are a "composed" name or a simple name. Hence, we
5691 avoid the IndexOf test, and we avoid
5693 * codegen.cs: Add code to assist in a bug reporter to track down
5694 the source of a compiler crash.
5696 2002-12-07 Ravi Pratap <ravi@ximian.com>
5698 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
5699 types have been emitted for a given element and flag an error
5700 if something which does not have AllowMultiple set is used more
5703 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
5704 attribute types and their corresponding AllowMultiple properties
5706 (AreMultipleAllowed): Check the property for a given type.
5708 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
5709 property in the case we have a TypeContainer.
5711 (Attributes.AddAttribute): Detect duplicates and just skip on
5712 adding them. This trivial fix catches a pretty gross error in our
5713 attribute emission - global attributes were being emitted twice!
5715 Bugzilla bug #33187 is now fixed.
5717 2002-12-06 Miguel de Icaza <miguel@ximian.com>
5719 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
5722 * expression.cs (Binary.ResolveOperator): I can only use the
5723 Concat (string, string, string) and Concat (string, string,
5724 string, string) if the child is actually a concatenation of
5727 2002-12-04 Miguel de Icaza <miguel@ximian.com>
5729 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
5730 context where we need a 2-character lookahead.
5732 * pending.cs (PendingImplementation): Rework so we can keep track
5733 of interface types all the time, and flag those which were
5734 implemented by parents as optional.
5736 2002-12-03 Miguel de Icaza <miguel@ximian.com>
5738 * expression.cs (Binary.ResolveOperator): Use
5739 String.Concat(string,string,string) or
5740 String.Concat(string,string,string,string) when possible.
5742 * typemanager: More helper methods.
5745 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
5747 * pending.cs: remove the bogus return from GetMissingInterfaces()
5748 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
5750 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5752 * namespace.cs: avoid duplicated 'using xxx' being added to
5753 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
5754 when we get more than one 'using' statement for the same namespace.
5755 Report a CS0105 warning for it.
5757 2002-11-30 Miguel de Icaza <miguel@ximian.com>
5759 * cs-tokenizer.cs (consume_identifier): use read directly, instead
5760 of calling getChar/putback, uses internal knowledge of it.
5762 (xtoken): Reorder tokenizer so most common patterns are checked
5763 first. This reduces the compilation time in another 5% (from 8.11s
5764 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
5766 The parsing time is 22% of the compilation in mcs, and from that
5767 64% is spent on the tokenization process.
5769 I tried using a binary search for keywords, but this is slower
5770 than the hashtable. Another option would be to do a couple of
5773 * Not use a StringBuilder, instead use an array of chars,
5774 with a set value. Notice that this way we could catch
5775 the 645 error without having to do it *afterwards*.
5777 * We could write a hand-parser to avoid the hashtable
5778 compares altogether.
5780 The identifier consumption process takes 37% of the tokenization
5781 time. Another 15% is spent on is_number. 56% of the time spent
5782 on is_number is spent on Int64.Parse:
5784 * We could probably choose based on the string length to
5785 use Int32.Parse or Int64.Parse and avoid all the 64-bit
5788 Another 3% is spend on wrapping `xtoken' in the `token' function.
5790 Handle 0xa0 as whitespace (#34752)
5792 2002-11-26 Miguel de Icaza <miguel@ximian.com>
5794 * typemanager.cs (IsCLRType): New routine to tell whether a type
5795 is one of the builtin types.
5797 Maybe it needs to use TypeCodes to be faster. Maybe we could use
5798 typecode in more places instead of doing pointer comparissions.
5799 We could leverage some knowledge about the way the typecodes are
5802 New code to cache namespaces in assemblies, it is currently not
5803 invoked, to be used soon.
5805 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
5807 * expression.cs (Binary.ResolveOperator): specially handle
5808 strings, and do not perform user-defined operator overloading for
5811 2002-11-24 Miguel de Icaza <miguel@ximian.com>
5813 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
5814 internalcall as it is a pretty simple operation; Avoid whenever
5815 possible to call Char.IsLetter.
5817 (consume_identifier): Cut by half the number of
5818 hashtable calls by merging the is_keyword and GetKeyword behavior.
5820 Do not short-circuit, because if we do, we
5821 report errors (ie, #if false && true would produce an invalid
5825 2002-11-24 Martin Baulig <martin@ximian.com>
5827 * expression.cs (Cast.TryReduce): If we're in checked syntax,
5828 check constant ranges and report a CS0221. Fixes #33186.
5830 2002-11-24 Martin Baulig <martin@ximian.com>
5832 * cs-parser.jay: Make this work for uninitialized variable
5833 declarations in the `for' initializer. Fixes #32416.
5835 2002-11-24 Martin Baulig <martin@ximian.com>
5837 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
5838 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
5840 2002-11-24 Martin Baulig <martin@ximian.com>
5842 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
5843 argument; if true, we also check for user-defined conversions.
5844 This is only needed if both arguments are of a user-defined type.
5845 Fixes #30443, added test-175.cs.
5846 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
5848 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
5850 2002-11-24 Martin Baulig <martin@ximian.com>
5852 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
5853 function to get the store opcode.
5854 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
5855 only emit the Ldelema if the store opcode is Stobj. You must run
5856 both test-34 and test-167 to test this. Fixes #34529.
5858 2002-11-23 Martin Baulig <martin@ximian.com>
5860 * ecore.cs (Expression.MemberLookup): Added additional
5861 `qualifier_type' argument which is used when we're being called
5862 from MemberAccess.DoResolve() and null if we're called from a
5864 (Expression.MemberLookupFailed): New method to report errors; this
5865 does the CS1540 check and reports the correct error message.
5867 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
5868 argument for the CS1540 check and redone the way how we're dealing
5869 with private members. See the comment in the source code for details.
5870 (FilterWithClosure): Reverted this back to revision 1.197; renamed
5871 `closure_start_type' to `closure_qualifier_type' and check whether
5872 it's not null. It was not this filter being broken, it was just
5873 being called with the wrong arguments.
5875 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
5876 and pass it the correct `qualifier_type'; this also does the error
5879 2002-11-22 Miguel de Icaza <miguel@ximian.com>
5881 * expression.cs (Invocation.EmitParams): If the we are dealing
5882 with a non-built-in value type, load its address as well.
5884 (ArrayCreation): Use a a pretty constant instead
5885 of the hardcoded value 2. Use 6 instead of 2 for the number of
5886 static initializers.
5888 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
5889 because they are not really value types, just glorified integers.
5891 * driver.cs: Do not append .exe, the CSC compiler does not do it.
5893 * ecore.cs: Remove redundant code for enumerations, make them use
5894 the same code path as everything else, fixes the casting issue
5895 with enumerations in Windows.Forms.
5897 * attribute.cs: Do only cast to string if it is a string, the
5898 validation happens later.
5900 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
5901 people upgrade their corlibs.
5903 * ecore.cs: Oops, enumerations were not following the entire code path
5905 2002-11-21 Miguel de Icaza <miguel@ximian.com>
5907 * typemanager.cs (FilterWithClosure): Commented out the test for
5908 1540 in typemanager.cs, as it has problems when accessing
5909 protected methods from a parent class (see test-174.cs).
5911 * attribute.cs (Attribute.ValidateGuid): new method.
5912 (Attribute.Resolve): Use above.
5914 2002-11-19 Miguel de Icaza <miguel@ximian.com>
5916 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
5918 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
5919 handling for enumerations, as we only needed the TypeContainer
5920 functionality to begin with (this is required for the fix below to
5921 work for enums that reference constants in a container class for
5924 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
5926 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
5927 a valid TypeBuilder to perform lookups on.o
5929 * class.cs (InheritableMemberSignatureCompare): Use true in the
5930 call to GetGetMethod and GetSetMethod, because we are comparing
5931 the signature, and we need to get the methods *even* if they are
5934 (PropertyBase.CheckBase): ditto.
5936 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
5937 GotoCase.Resolve): Use Peel on EmpytCasts.
5939 * ecore.cs (EmptyCast): drop child, add Peel method.
5941 2002-11-17 Martin Baulig <martin@ximian.com>
5943 * ecore.cs (EmptyCast.Child): New public property.
5945 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
5946 label resolved to an EmptyCast. Fixes #34162.
5947 (GotoCase.Resolve): Likewise.
5948 (Block.EmitMeta): Likewise.
5950 2002-11-17 Martin Baulig <martin@ximian.com>
5952 * expression.cs (Invocation.BetterConversion): Prefer int over
5953 uint; short over ushort; long over ulong for integer literals.
5954 Use ImplicitConversionExists instead of StandardConversionExists
5955 since we also need to check for user-defined implicit conversions.
5956 Fixes #34165. Added test-173.cs.
5958 2002-11-16 Martin Baulig <martin@ximian.com>
5960 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
5961 with the `true' and `false' literals. Fixes #33151.
5963 2002-11-16 Martin Baulig <martin@ximian.com>
5965 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
5966 October 22nd; don't do the cs1540 check for static members.
5968 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
5969 now using our own filter here and doing the cs1540 check again.
5971 2002-11-16 Martin Baulig <martin@ximian.com>
5973 * support.cs (InternalParameters): Don't crash if we don't have
5974 any fixed parameters. Fixes #33532.
5976 2002-11-16 Martin Baulig <martin@ximian.com>
5978 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
5979 when looking up static methods to make this work on Windows.
5982 2002-11-16 Martin Baulig <martin@ximian.com>
5984 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
5985 a setter rather than using PropertyInfo.CanWrite.
5987 2002-11-15 Nick Drochak <ndrochak@gol.com>
5989 * class.cs: Allow acces to block member by subclasses. Fixes build
5992 2002-11-14 Martin Baulig <martin@ximian.com>
5994 * class.cs (Constructor.Emit): Added the extern/block check.
5997 2002-11-14 Martin Baulig <martin@ximian.com>
5999 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
6000 iteration while looking for indexers, this is needed because the
6001 indexer may have a different name in our base classes. Fixed the
6002 error reporting (no indexers at all, not get accessor, no
6003 overloaded match). Fixes bug #33089.
6004 (IndexerAccess.DoResolveLValue): Likewise.
6006 2002-11-14 Martin Baulig <martin@ximian.com>
6008 * class.cs (PropertyBase.CheckBase): Make this work for multiple
6009 indexers. Fixes the first part of bug #33089.
6010 (MethodSignature.InheritableMemberSignatureCompare): Added support
6013 2002-11-13 Ravi Pratap <ravi@ximian.com>
6015 * attribute.cs (Attribute.Resolve): Catch the
6016 NullReferenceException and report it since it isn't supposed to
6019 2002-11-12 Miguel de Icaza <miguel@ximian.com>
6021 * expression.cs (Binary.EmitBranchable): Also handle the cases for
6022 LogicalOr and LogicalAnd that can benefit from recursively
6023 handling EmitBranchable. The code now should be nice for Paolo.
6025 2002-11-08 Miguel de Icaza <miguel@ximian.com>
6027 * typemanager.cs (LookupType): Added a negative-hit hashtable for
6028 the Type lookups, as we perform quite a number of lookups on
6029 non-Types. This can be removed once we can deterministically tell
6030 whether we have a type or a namespace in advance.
6032 But this might require special hacks from our corlib.
6036 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
6037 and double which avoids a conversion from an integer to a double.
6039 * expression.cs: tiny optimization, avoid calling IsConstant,
6040 because it effectively performs the lookup twice.
6042 2002-11-06 Miguel de Icaza <miguel@ximian.com>
6044 But a bogus return here to keep the semantics of the old code
6045 until the Mono runtime is fixed.
6047 * pending.cs (GetMissingInterfaces): New method used to remove all
6048 the interfaces that are already implemented by our parent
6049 classes from the list of pending methods.
6051 * interface.cs: Add checks for calls after ResolveTypeExpr.
6053 2002-11-05 Miguel de Icaza <miguel@ximian.com>
6055 * class.cs (Class.Emit): Report warning 67: event not used if the
6056 warning level is beyond 3.
6058 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
6059 being a NullLiteral.
6061 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
6064 * class.cs (TypeContainer.GetClassBases): Cover a missing code
6065 path that might fail if a type can not be resolved.
6067 * expression.cs (Binary.Emit): Emit unsigned versions of the
6070 * driver.cs: use error 5.
6072 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
6074 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
6076 2002-11-01 Miguel de Icaza <miguel@ximian.com>
6078 * cs-parser.jay (switch_section): A beautiful patch from Martin
6079 Baulig that fixed 33094.
6081 2002-10-31 Miguel de Icaza <miguel@ximian.com>
6083 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
6084 Check whether the base is abstract and report an error if so.
6086 * expression.cs (IndexerAccess.DoResolveLValue,
6087 IndexerAccess.DoResolve): ditto.
6089 (Invocation.DoResolve): ditto.
6091 (Invocation.FullMethodDesc): Improve the report string.
6093 * statement.cs (Block): Eliminate IsVariableDefined as it is
6094 basically just a wrapper for GetVariableInfo.
6096 * ecore.cs (SimpleName): Use new
6098 * support.cs (ReflectionParamter.ParameterType): We unwrap the
6099 type, as we return the actual parameter ref/unref state on a
6102 2002-10-30 Miguel de Icaza <miguel@ximian.com>
6104 * support.cs: Return proper flags REF/OUT fixing the previous
6107 * expression.cs: Reverted last patch, that was wrong. Is_ref is
6108 not used to mean `ref' but `ref or out' in ParameterReference
6110 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
6111 full type signature instead of calling TypeManger.CSharpName
6114 * support.cs (InternalParameters.ParameterDesc): Do not compare
6115 directly to the modflags, because REF/OUT will actually be bitsets
6118 * delegate.cs (VerifyMethod): Check also the modifiers.
6120 * cs-tokenizer.cs: Fix bug where floating point values with an
6121 exponent where a sign was missing was ignored.
6123 * driver.cs: Allow multiple assemblies to be specified in a single
6126 2002-10-28 Miguel de Icaza <miguel@ximian.com>
6128 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
6129 because identifiers after a parenthesis would end up in this kind
6130 of production, and we needed to desamiguate it for having casts
6133 (UserDefinedType *) xxx
6135 2002-10-24 Miguel de Icaza <miguel@ximian.com>
6137 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
6138 we should set on the Bindingflags.NonPublic, but not turn on
6139 private_ok. private_ok controls whether a Private member is
6140 returned (this is chekced on the filter routine), while the
6141 BindingFlags.NonPublic just controls whether private/protected
6142 will be allowed. This fixes the problem part of the problem of
6143 private properties being allowed to be used in derived classes.
6145 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
6146 so we can call the children DoResolveLValue method (this will
6147 properly signal errors on lvalue assignments to base properties)
6149 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
6150 getter are null, and we have a property info, we know that this
6151 happened because the lookup failed, so we report an error 122 for
6152 protection level violation.
6154 We also silently return if setter and getter are null in the
6155 resolve functions, this condition only happens if we have flagged
6156 the error before. This is the other half of the problem.
6158 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
6159 not have accessibility information, that is why we were returning
6160 true in the filter function in typemanager.cs.
6162 To properly report 122 (property is inaccessible because of its
6163 protection level) correctly, we report this error in ResolveAccess
6164 by failing if both the setter and the getter are lacking (ie, the
6167 DoResolve and DoLResolve have been modified to check for both
6168 setter/getter being null and returning silently, the reason being
6169 that I did not want to put the knowledge about this error in upper
6172 int old = Report.Errors;
6173 x = new PropertyExpr (...);
6174 if (old != Report.Errors)
6179 So the property expr is returned, but it is invalid, so the error
6180 will be flagged during the resolve process.
6182 * class.cs: Remove InheritablePropertySignatureCompare from the
6183 class, as we no longer depend on the property signature to compute
6184 whether it is possible to implement a method or not.
6186 The reason is that calling PropertyInfo.GetGetMethod will return
6187 null (in .NET, in Mono it works, and we should change this), in
6188 cases where the Get Method does not exist in that particular
6193 class X { public virtual int A { get { return 1; } } }
6195 class Z : Y { public override int A { get { return 2; } } }
6197 Would fail in Z because the parent (Y) would not have the property
6198 defined. So we avoid this completely now (because the alternative
6199 fix was ugly and slow), and we now depend exclusively on the
6202 (PropertyBase.CheckBase): Use a method-base mechanism to find our
6203 reference method, instead of using the property.
6205 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
6206 routines are gone now.
6208 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
6209 names, they were incorrectly named.
6211 * cs-tokenizer.cs: Return are more gentle token on failure.
6213 * pending.cs (PendingImplementation.InterfaceMethod): This routine
6214 had an out-of-sync index variable, which caused it to remove from
6215 the list of pending methods the wrong method sometimes.
6217 2002-10-22 Miguel de Icaza <miguel@ximian.com>
6219 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
6220 CanWrite, because those refer to this particular instance of the
6221 property, and do not take into account the fact that we can
6222 override single members of a property.
6224 Constructor requires an EmitContext. The resolution process does
6225 not happen here, but we need to compute the accessors before,
6226 because the resolution does not always happen for properties.
6228 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
6229 subclass, before we did not update this flag, but we did update
6232 (GetAccessors): Drop this routine, as it did not work in the
6233 presence of partially overwritten set/get methods.
6235 Notice that this broke the cs1540 detection, but that will require
6238 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6242 * driver.cs: issue a warning instead of an error if we don't support
6243 debugging for the platform. Also ignore a couple of errors that may
6244 arise when trying to write the symbols. Undo my previous patch.
6246 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6248 * driver.cs: ignore /debug switch except for Unix platforms.
6250 2002-10-23 Nick Drochak <ndrochak@gol.com>
6252 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
6254 2002-10-21 Miguel de Icaza <miguel@ximian.com>
6256 * driver.cs: Do not make mcs-debug conditional, so we do not break
6259 * statement.cs (UsageVector.MergeChildren): I would like Martin to
6260 review this patch. But basically after all the children variables
6261 have been merged, the value of "Breaks" was not being set to
6262 new_breaks for Switch blocks. I think that it should be set after
6263 it has executed. Currently I set this to the value of new_breaks,
6264 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
6265 conservative, but I do not understand this code very well.
6267 I did not break anything in the build, so that is good ;-)
6269 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
6271 2002-10-20 Mark Crichton <crichton@gimp.org>
6273 * cfold.cs: Fixed compile blocker. Really fixed it this time.
6275 2002-10-20 Nick Drochak <ndrochak@gol.com>
6277 * cfold.cs: Fixed compile blocker.
6279 2002-10-20 Miguel de Icaza <miguel@ximian.com>
6281 * driver.cs: I was chekcing the key, not the file.
6283 2002-10-19 Ravi Pratap <ravi@ximian.com>
6285 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
6286 message that we were generating - we just need to silently return
6289 2002-10-19 Miguel de Icaza <miguel@ximian.com>
6291 * class.cs (Event.Define): Change my previous commit, as this
6292 breaks the debugger. This is a temporary hack, as it seems like
6293 the compiler is generating events incorrectly to begin with.
6295 * expression.cs (Binary.ResolveOperator): Added support for
6296 "U operator - (E x, E y)"
6298 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
6301 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
6302 init-only variables, but this path did not take into account that
6303 there might be also instance readonly variables. Correct this
6306 This fixes bug 32253
6308 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
6311 * driver.cs: Change the extension for modules to `netmodule'
6313 * cs-parser.jay: Improved slightly the location tracking for
6314 the debugger symbols.
6316 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
6317 modifiers that were specified instead of the hardcoded value
6318 (FamAndAssem). This was basically ignoring the static modifier,
6319 and others. Fixes 32429.
6321 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
6322 fixed a bug in the process (32476)
6324 * expression.cs (ArrayAccess.EmitAssign): Patch from
6325 hwang_rob@yahoo.ca that fixes bug 31834.3
6327 2002-10-18 Miguel de Icaza <miguel@ximian.com>
6329 * driver.cs: Make the module extension .netmodule.
6331 2002-10-16 Miguel de Icaza <miguel@ximian.com>
6333 * driver.cs: Report an error if the resource file is not found
6334 instead of crashing.
6336 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
6337 false, like Emit does.
6339 2002-10-16 Nick Drochak <ndrochak@gol.com>
6341 * typemanager.cs: Remove unused private member. Also reported mcs
6342 bug to report this as a warning like csc.
6344 2002-10-15 Martin Baulig <martin@gnome.org>
6346 * statement.cs (Statement.Emit): Made this a virtual method; emits
6347 the line number info and calls DoEmit().
6348 (Statement.DoEmit): New protected abstract method, formerly knows
6349 as Statement.Emit().
6351 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
6353 2002-10-11 Miguel de Icaza <miguel@ximian.com>
6355 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
6356 have fixed a remaining problem: not every AddXXXX was adding a
6357 fully qualified name.
6359 Now everyone registers a fully qualified name in the DeclSpace as
6360 being defined instead of the partial name.
6362 Downsides: we are slower than we need to be due to the excess
6363 copies and the names being registered this way.
6365 The reason for this is that we currently depend (on the corlib
6366 bootstrap for instance) that types are fully qualified, because
6367 we dump all the types in the namespace, and we should really have
6368 types inserted into the proper namespace, so we can only store the
6369 basenames in the defined_names array.
6371 2002-10-10 Martin Baulig <martin@gnome.org>
6373 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
6374 from bug #31834, see the bug report for a testcase which is
6377 2002-10-10 Martin Baulig <martin@gnome.org>
6379 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
6380 flow analysis code for this.
6382 * statement.cs (Do, While, For): Tell the flow analysis code about
6384 (FlowBranching.UsageVector): Added support for infinite loops.
6385 (Block.Resolve): Moved the dead code elimination here and use flow
6388 2002-10-09 Miguel de Icaza <miguel@ximian.com>
6390 * class.cs (Field.Define): Catch cycles on struct type
6393 * typemanager.cs (IsUnmanagedtype): Do not recursively check
6394 fields if the fields are static. We only need to check instance
6397 * expression.cs (As.DoResolve): Test for reference type.
6399 * statement.cs (Using.ResolveExpression): Use
6400 ConvertImplicitRequired, not ConvertImplicit which reports an
6402 (Using.ResolveLocalVariableDecls): ditto.
6404 * expression.cs (Binary.ResolveOperator): Report errors in a few
6405 places where we had to.
6407 * typemanager.cs (IsUnmanagedtype): Finish implementation.
6409 2002-10-08 Miguel de Icaza <miguel@ximian.com>
6411 * expression.cs: Use StoreFromPtr instead of extracting the type
6412 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
6414 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
6415 an enumeration value to a System.Enum, but System.Enum is not a
6416 value type, but an class type, so we need to box.
6418 (Expression.ConvertExplicit): One codepath could return
6419 errors but not flag them. Fix this. Fixes #31853
6421 * parameter.cs (Resolve): Do not allow void as a parameter type.
6423 2002-10-06 Martin Baulig <martin@gnome.org>
6425 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
6426 if it's a class type and not a struct. Fixes #31815.
6428 2002-10-06 Martin Baulig <martin@gnome.org>
6430 * statement.cs: Reworked the flow analysis code a bit to make it
6431 usable for dead code elimination.
6433 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6435 * cs-parser.jay: allow empty source files. Fixes bug #31781.
6437 2002-10-04 Miguel de Icaza <miguel@ximian.com>
6439 * expression.cs (ComposedCast.DoResolveType): A quick workaround
6440 to fix the test 165, will investigate deeper.
6442 2002-10-04 Martin Baulig <martin@gnome.org>
6444 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
6445 finally blocks actually work.
6446 (Try.Resolve): We don't need to create a sibling for `finally' if
6447 there is no finally block.
6449 2002-10-04 Martin Baulig <martin@gnome.org>
6451 * class.cs (Constructor.Define): The default accessibility for a
6452 non-default constructor is private, not public.
6454 2002-10-04 Miguel de Icaza <miguel@ximian.com>
6456 * class.cs (Constructor): Make AllowedModifiers public, add
6459 * cs-parser.jay: Perform the modifiers test here, as the
6460 constructor for the Constructor class usually receives a zero
6461 because of the way we create it (first we create, later we
6462 customize, and we were never checking the modifiers).
6464 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
6465 is a version of LookupTypeReflection that includes the type-name
6466 cache. This can be used as a fast path for functions that know
6467 the fully qualified name and are only calling into *.GetType() to
6468 obtain a composed type.
6470 This is also used by TypeManager.LookupType during its type
6473 (LookupType): We now also track the real type name, as sometimes
6474 we can get a quey for the real type name from things like
6475 ComposedCast. This fixes bug 31422.
6477 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
6478 complete type fullname, it does not have to go through the type
6479 resolution system to obtain the composed version of the type (for
6480 obtaining arrays or pointers).
6482 (Conditional.Emit): Use the EmitBoolExpression to
6483 generate nicer code, as requested by Paolo.
6485 (ArrayCreation.CheckIndices): Use the patch from
6486 hwang_rob@yahoo.ca to validate the array initializers.
6488 2002-10-03 Miguel de Icaza <miguel@ximian.com>
6490 * class.cs (ConstructorInitializer.Emit): simplify code by using
6491 Invocation.EmitCall, and at the same time, fix the bugs in calling
6492 parent constructors that took variable arguments.
6494 * ecore.cs (Expression.ConvertNumericExplicit,
6495 Expression.ImplicitNumericConversion): Remove the code that
6496 manually wrapped decimal (InternalTypeConstructor call is now gone
6499 * expression.cs (Cast.TryReduce): Also handle decimal types when
6500 trying to perform a constant fold on the type.
6502 * typemanager.cs (IsUnmanagedtype): Partially implemented.
6504 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
6505 that only turned off an error report, and did nothing else.
6507 2002-10-02 Miguel de Icaza <miguel@ximian.com>
6509 * driver.cs: Handle and ignore /fullpaths
6511 2002-10-01 Miguel de Icaza <miguel@ximian.com>
6513 * expression.cs (Binary.ResolveOperator): Catch the case where
6514 DoNumericPromotions returns true,
6516 (Binary.DoNumericPromotions): Simplify the code, and the tests.
6518 2002-09-27 Miguel de Icaza <miguel@ximian.com>
6520 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
6523 2002-09-26 Miguel de Icaza <miguel@ximian.com>
6525 * ecore.cs (ConvertNumericExplicit): It is not enough that the
6526 conversion exists, but it is also required that the conversion be
6527 performed. This manifested in "(Type64Enum) 2".
6529 * class.cs (TypeManager.AddMethod): The fix is not to change
6530 AddEnum, because that one was using a fully qualified name (every
6531 DeclSpace derivative does), but to change the AddMethod routine
6532 that was using an un-namespaced name. This now correctly reports
6533 the duplicated name.
6535 Revert patch until I can properly fix it. The issue
6536 is that we have a shared Type space across all namespaces
6537 currently, which is wrong.
6539 Options include making the Namespace a DeclSpace, and merge
6540 current_namespace/current_container in the parser.
6542 2002-09-25 Miguel de Icaza <miguel@ximian.com>
6544 * cs-parser.jay: Improve error reporting when we get a different
6545 kind of expression in local_variable_type and
6546 local_variable_pointer_type.
6548 Propagate this to avoid missleading errors being reported.
6550 * ecore.cs (ImplicitReferenceConversion): treat
6551 TypeManager.value_type as a target just like object_type. As
6556 Is valid, and needs to result in the int 1 being boxed before it
6557 is assigned to the value type v.
6559 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
6560 to validate the enumeration name.
6562 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
6563 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
6564 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
6566 * ecore.cs (TryImplicitIntConversion): When doing an
6567 implicit-enumeration-conversion, check if the type is 64-bits and
6568 perform a conversion before passing to EnumConstant.
6570 2002-09-23 Miguel de Icaza <miguel@ximian.com>
6572 * decl.cs (Error_AmbiguousTypeReference); New routine used to
6573 report ambiguous type references. Unlike the MS version, we
6574 report what the ambiguity is. Innovation at work ;-)
6576 (DeclSpace.FindType): Require a location argument to
6577 display when we display an ambiguous error.
6579 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
6581 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
6583 * expression.cs (EmitDynamicInitializers): Apply patch from
6584 hwang_rob@yahoo.ca that fixes the order in which we emit our
6587 2002-09-21 Martin Baulig <martin@gnome.org>
6589 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
6590 delegate takes no arguments.
6592 2002-09-20 Miguel de Icaza <miguel@ximian.com>
6594 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
6597 * expression.cs: Extract the underlying type.
6599 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
6601 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
6603 2002-09-19 Miguel de Icaza <miguel@ximian.com>
6605 * class.cs (TypeContainer.DefineType): We can not use the nice
6606 PackingSize with the size set to 1 DefineType method, because it
6607 will not allow us to define the interfaces that the struct
6610 This completes the fixing of bug 27287
6612 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
6613 means also structs. This fixes part of the problem.
6614 (Expresion.ImplicitReferenceConversionExists): ditto.
6616 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
6617 error if there were no errors reported during the type lookup
6618 process, to avoid duplicates or redundant errors. Without this
6619 you would get an ambiguous errors plus a type not found. We have
6620 beaten the user enough with the first error.
6622 (DeclSparce.FindType): Emit a warning if we have an ambiguous
6625 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
6626 during the resolution process, stop the lookup, this avoids
6627 repeated error reports (same error twice).
6629 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
6631 * typemanager.cs (LookupType): Redo the type lookup code to match
6632 the needs of System.Reflection.
6634 The issue is that System.Reflection requires references to nested
6635 types to begin with a "+" sign instead of a dot. So toplevel
6636 types look like: "NameSpace.TopLevelClass", and nested ones look
6637 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
6640 2002-09-19 Martin Baulig <martin@gnome.org>
6642 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
6643 says that a method always returns or always throws an exception,
6644 don't report the CS0161.
6646 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
6647 set `Returns = new_returns'.
6649 2002-09-19 Martin Baulig <martin@gnome.org>
6651 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
6652 to an enum constant, check for a CS0176.
6654 2002-09-18 Miguel de Icaza <miguel@ximian.com>
6656 * class.cs (TypeContainer.CheckPairedOperators): Now we check
6657 for operators that must be in pairs and report errors.
6659 * ecore.cs (SimpleName.DoResolveType): During the initial type
6660 resolution process, when we define types recursively, we must
6661 check first for types in our current scope before we perform
6662 lookups in the enclosing scopes.
6664 * expression.cs (MakeByteBlob): Handle Decimal blobs.
6666 (Invocation.VerifyArgumentsCompat): Call
6667 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
6668 I thought we were supposed to always call this, but there are a
6669 few places in the code where we dont do it.
6671 2002-09-17 Miguel de Icaza <miguel@ximian.com>
6673 * driver.cs: Add support in -linkres and -resource to specify the
6674 name of the identifier.
6676 2002-09-16 Miguel de Icaza <miguel@ximian.com>
6678 * ecore.cs (StandardConversionExists): Sync with the conversion
6679 code: allow anything-* to void* conversions.
6681 (FindMostSpecificSource): Use an Expression argument
6682 instead of a Type, because we might be handed over a Literal which
6683 gets a few more implicit conversions that plain types do not. So
6684 this information was being lost.
6686 Also, we drop the temporary type-holder expression when not
6689 2002-09-17 Martin Baulig <martin@gnome.org>
6691 * class.cs (PropertyBase.CheckBase): Don't check the base class if
6692 this is an explicit interface implementation.
6694 2002-09-17 Martin Baulig <martin@gnome.org>
6696 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
6697 different `IndexerName' attributes.
6699 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
6700 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
6701 virtual CommonResolve().
6703 2002-09-16 Miguel de Icaza <miguel@ximian.com>
6705 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
6706 and convert that to the UnderlyingType.
6708 * statement.cs (Foreach.Resolve): Indexers are just like variables
6709 or PropertyAccesses.
6711 * cs-tokenizer.cs (consume_string): Track line numbers and columns
6712 inside quoted strings, we were not doing this before.
6714 2002-09-16 Martin Baulig <martin@gnome.org>
6716 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
6717 resolve it. This is needed for the definite assignment check of the
6718 instance expression, fixes bug #29846.
6719 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
6721 2002-09-16 Nick Drochak <ndrochak@gol.com>
6723 * parameter.cs: Fix compile error. Cannot reference static member
6724 from an instance object. Is this an mcs bug?
6726 2002-09-14 Martin Baulig <martin@gnome.org>
6728 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
6729 multiple times. Fixes bug #30295, added test-166.cs.
6731 2002-09-14 Martin Baulig <martin@gnome.org>
6733 * statement.cs (Block.Emit): Don't emit unreachable code.
6734 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
6736 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
6738 2002-09-14 Martin Baulig <martin@gnome.org>
6740 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
6743 2002-09-14 Martin Baulig <martin@gnome.org>
6745 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
6746 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
6747 be false on the ms runtime.
6749 2002-09-13 Martin Baulig <martin@gnome.org>
6751 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
6752 the CS0038 error message.
6754 2002-09-12 Miguel de Icaza <miguel@ximian.com>
6756 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
6757 constant inside, return it.
6759 2002-09-12 Martin Baulig <martin@gnome.org>
6761 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
6762 implicit conversion can be done between enum types.
6764 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
6765 check whether an implicit conversion to the current enum's UnderlyingType
6766 exists and report an error if not.
6768 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
6769 without debugging support.
6771 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
6772 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
6774 2002-09-12 Martin Baulig <martin@gnome.org>
6776 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
6778 * ecore.cs (IMemberExpr.DeclaringType): New property.
6779 (SimpleName.SimpleNameResolve): Check whether we're accessing a
6780 nonstatic member of an outer type (CS0038).
6782 2002-09-11 Miguel de Icaza <miguel@ximian.com>
6784 * driver.cs: Activate the using-error detector at warning level
6785 4 (at least for MS-compatible APIs).
6787 * namespace.cs (VerifyUsing): Small buglett fix.
6789 * pending.cs (PendingImplementation): pass the container pointer.
6791 * interface.cs (GetMethods): Allow for recursive definition. Long
6792 term, I would like to move every type to support recursive
6793 definitions, not the current ordering mechanism that we have right
6796 The situation is this: Attributes are handled before interfaces,
6797 so we can apply attributes to interfaces. But some attributes
6798 implement interfaces, we will now handle the simple cases
6799 (recursive definitions will just get an error).
6801 * parameter.cs: Only invalidate types at the end if we fail to
6804 2002-09-09 Martin Baulig <martin@gnome.org>
6806 * ecore.cs (PropertyExpr.Emit): Also check for
6807 TypeManager.system_int_array_get_length so this'll also work when
6808 compiling corlib. Fixes #30003.
6810 2002-09-09 Martin Baulig <martin@gnome.org>
6812 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
6813 and throw an exception if we can't get the type's size. Fixed #30040,
6816 2002-09-09 Martin Baulig <martin@gnome.org>
6818 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
6820 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
6821 context. Fixes bug #30027.
6823 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
6824 virtual functions. Fixes bug #30043, added test-164.cs.
6826 2002-09-08 Ravi Pratap <ravi@ximian.com>
6828 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
6830 2002-09-08 Nick Drochak <ndrochak@gol.com>
6832 * driver.cs: Use an object to get the windows codepage since it's not a
6835 2002-09-08 Miguel de Icaza <miguel@ximian.com>
6837 * statement.cs (For.Emit): for infinite loops (test == null)
6838 return whether there is a break inside, not always "true".
6840 * namespace.cs (UsingEntry): New struct to hold the name of the
6841 using definition, the location where it is defined, and whether it
6842 has been used in a successful type lookup.
6844 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
6849 2002-09-06 Ravi Pratap <ravi@ximian.com>
6851 * attribute.cs : Fix incorrect code which relied on catching
6852 a NullReferenceException to detect a null being passed in
6853 where an object was expected.
6855 2002-09-06 Miguel de Icaza <miguel@ximian.com>
6857 * statement.cs (Try): flag the catch variable as assigned
6859 * expression.cs (Cast): Simplified by using ResolveType instead of
6862 * statement.cs (Catch): Fix bug by using ResolveType.
6864 2002-09-06 Ravi Pratap <ravi@ximian.com>
6866 * expression.cs (BetterConversion): Special case for when we have
6867 a NullLiteral as the argument and we have to choose between string
6868 and object types - we choose string the way csc does.
6870 * attribute.cs (Attribute.Resolve): Catch the
6871 NullReferenceException and report error #182 since the Mono
6872 runtime no more has the bug and having this exception raised means
6873 we tried to select a constructor which takes an object and is
6876 2002-09-05 Ravi Pratap <ravi@ximian.com>
6878 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
6879 message (1502, 1503) when we can't locate a method after overload
6880 resolution. This is much more informative and closes the bug
6883 * interface.cs (PopulateMethod): Return if there are no argument
6884 types. Fixes a NullReferenceException bug.
6886 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
6887 expressions too. Previously we were checking only in one place for
6888 positional arguments leaving out named arguments.
6890 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
6891 type to the enum type is not allowed. Remove code corresponding to
6894 (ConvertNumericExplicit): Allow explicit conversions from
6895 the underlying type to enum type. This precisely follows the spec
6896 and closes a bug filed by Gonzalo.
6898 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6901 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
6903 2002-09-03 Miguel de Icaza <miguel@ximian.com>
6905 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
6906 it was important that we stored the right value after the
6907 reduction in `converted'.
6909 2002-09-04 Martin Baulig <martin@gnome.org>
6911 * location.cs (Location.SymbolDocument): Use full pathnames for the
6914 2002-08-30 Miguel de Icaza <miguel@ximian.com>
6916 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
6917 of the expression resolve mechanism, because that will catch the
6918 SimpleName error failures.
6920 (Conditional): If we can not resolve the
6921 expression, return, do not crash.
6923 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6926 (location): display token name instead of its number.
6928 2002-08-28 Martin Baulig <martin@gnome.org>
6930 * expression.cs (Binary.ResolveOperator): Don't silently return
6931 but return an error if an operator cannot be applied between two
6934 2002-08-28 Martin Baulig <martin@gnome.org>
6936 * class.cs (Constructor.Define): Set the permission attributes
6937 correctly instead of making all constructors public.
6939 2002-08-28 Martin Baulig <martin@gnome.org>
6941 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
6942 for private members before reporting a CS0103; if we find anything,
6945 2002-08-28 Martin Baulig <martin@gnome.org>
6947 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
6948 to check whether `closure_start_type == closure_invocation_type',
6949 we also need to check whether `m.DeclaringType == closure_invocation_type'
6950 before bypassing the permission checks. We might be accessing
6951 protected/private members from the base class.
6952 (TypeManager.RealMemberLookup): Only set private_ok if private
6953 members were requested via BindingFlags.NonPublic.
6955 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
6957 * expression.cs (MemberAccess.ResolveMemberAccess): Set
6958 MethodGroupExpr.IsExplicitImpl if appropriate.
6959 (Invocation.DoResolve): Don't report the CS0120 for explicit
6960 interface implementations.
6962 2002-08-27 Martin Baulig <martin@gnome.org>
6964 * expression.cs (Invocation.DoResolve): If this is a static
6965 method and we don't have an InstanceExpression, we must report
6968 2002-08-25 Martin Baulig <martin@gnome.org>
6970 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
6971 `==' between a valuetype and an object.
6973 2002-08-25 Miguel de Icaza <miguel@ximian.com>
6975 * ecore.cs (TypeExpr): Provide a ToString method.
6977 2002-08-24 Martin Baulig <martin@gnome.org>
6979 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
6980 now called proggie.dbg and it's a binary file.
6982 2002-08-23 Martin Baulig <martin@gnome.org>
6984 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
6986 2002-08-23 Martin Baulig <martin@gnome.org>
6988 * struct.cs (MyStructInfo.ctor): Make this work with empty
6989 structs; it's not allowed to use foreach() on null.
6991 2002-08-23 Martin Baulig <martin@gnome.org>
6993 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
6994 writer the full pathname of the generated assembly.
6996 2002-08-23 Martin Baulig <martin@gnome.org>
6998 * statements.cs (FlowBranching.UsageVector.MergeChildren):
6999 A `finally' block never returns or breaks; improved handling of
7002 2002-08-23 Martin Baulig <martin@gnome.org>
7004 * statement.cs (Throw.Resolve): Allow `throw null'.
7006 2002-08-23 Martin Baulig <martin@gnome.org>
7008 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
7009 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
7010 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
7011 MemberLookup would return a wrong event if this is an explicit
7012 interface implementation and the class has an event with the same
7015 2002-08-23 Martin Baulig <martin@gnome.org>
7017 * statement.cs (Block.AddChildVariableNames): New public method.
7018 (Block.AddChildVariableName): Likewise.
7019 (Block.IsVariableNameUsedInChildBlock): Likewise.
7020 (Block.AddVariable): Check whether a variable name has already
7021 been used in a child block.
7023 * cs-parser.jay (declare_local_variables): Mark all variable names
7024 from the current block as being used in a child block in the
7027 2002-08-23 Martin Baulig <martin@gnome.org>
7029 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
7030 find the symbol writer.
7032 * driver.cs: csc also allows the arguments to /define being
7033 separated by commas, not only by semicolons.
7035 2002-08-23 Martin Baulig <martin@gnome.org>
7037 * interface.cs (Interface.GetMembers): Added static check for events.
7039 2002-08-15 Martin Baulig <martin@gnome.org>
7041 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
7042 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
7044 * ecore.cs (Expression.MemberLookup): Added documentation and explained
7045 why the MethodData.EmitDestructor() change was necessary.
7047 2002-08-20 Martin Baulig <martin@gnome.org>
7049 * class.cs (TypeContainer.FindMembers): Added static check for events.
7051 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
7053 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
7054 use Type.GetEvents(), not Type.FindMembers().
7056 2002-08-20 Martin Baulig <martin@gnome.org>
7058 * decl.cs (MemberCache): Added a special method cache which will
7059 be used for method-only searched. This ensures that a method
7060 search will return a MethodInfo with the correct ReflectedType for
7063 2002-08-20 Martin Baulig <martin@gnome.org>
7065 * decl.cs (DeclSpace.FindMembers): Made this public.
7067 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7069 * delegate.cs: fixed build on windows.
7070 [FIXME: Filed as bug #29150: MCS must report these errors.]
7072 2002-08-19 Ravi Pratap <ravi@ximian.com>
7074 * ecore.cs (StandardConversionExists): Return a false
7075 if we are trying to convert the void type to anything else
7076 since that is not allowed.
7078 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
7079 we flag error 70 in the event an event is trying to be accessed
7080 directly from outside the declaring type.
7082 2002-08-20 Martin Baulig <martin@gnome.org>
7084 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
7085 MemberCache from typemanager.cs to decl.cs.
7087 2002-08-19 Martin Baulig <martin@gnome.org>
7089 * class.cs (TypeContainer): Implement IMemberContainer.
7090 (TypeContainer.DefineMembers): Create the MemberCache.
7091 (TypeContainer.FindMembers): Do better BindingFlags checking; only
7092 return public members if BindingFlags.Public was given, check
7093 whether members are static.
7095 2002-08-16 Martin Baulig <martin@gnome.org>
7097 * decl.cs (DeclSpace.Define): Splitted this in Define and
7098 DefineMembers. DefineMembers is called first and initializes the
7101 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
7102 DefineMembers() on all our DeclSpaces.
7104 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
7105 but call DefineMembers() on all nested interfaces. We call their
7106 Define() in our new Define() function.
7108 * interface.cs (Interface): Implement IMemberContainer.
7109 (Interface.Define): Moved all code except the attribute stuf to
7111 (Interface.DefineMembers): Initialize the member cache.
7113 * typemanager.cs (IMemberFinder): Removed this interface, we don't
7114 need this anymore since we can use MemberCache.FindMembers directly.
7116 2002-08-19 Martin Baulig <martin@gnome.org>
7118 * typemanager.cs (MemberCache): When creating the cache for an
7119 interface type, add all inherited members.
7120 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
7121 to `out bool used_cache' and documented it.
7122 (TypeManager.MemberLookup): If we already used the cache in the first
7123 iteration, we don't need to do the interfaces check.
7125 2002-08-19 Martin Baulig <martin@gnome.org>
7127 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
7128 here from IMemberFinder and don't implement this interface anymore.
7129 (DeclSpace.MemberCache): Moved here from IMemberFinder.
7131 * typemanager.cs (IMemberFinder): This interface is now only used by
7132 classes which actually support the member cache.
7133 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
7134 since we only put DeclSpaces into this Hashtable.
7135 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
7136 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
7138 2002-08-16 Martin Baulig <martin@gnome.org>
7140 * typemanager.cs (ICachingMemberFinder): Removed.
7141 (IMemberFinder.MemberCache): New property.
7142 (TypeManager.FindMembers): Merged this with RealFindMembers().
7143 This function will never be called from TypeManager.MemberLookup()
7144 so we can't use the cache here, just the IMemberFinder.
7145 (TypeManager.MemberLookup_FindMembers): Check whether the
7146 IMemberFinder has a MemberCache and call the cache's FindMembers
7148 (MemberCache): Rewrote larger parts of this yet another time and
7149 cleaned it up a bit.
7151 2002-08-15 Miguel de Icaza <miguel@ximian.com>
7153 * driver.cs (LoadArgs): Support quoting.
7155 (Usage): Show the CSC-like command line arguments.
7157 Improved a few error messages.
7159 2002-08-15 Martin Baulig <martin@gnome.org>
7161 * typemanager.cs (IMemberContainer.Type): New property.
7162 (IMemberContainer.IsInterface): New property.
7164 The following changes are conditional to BROKEN_RUNTIME, which is
7165 defined at the top of the file.
7167 * typemanager.cs (MemberCache.MemberCache): Don't add the base
7168 class'es members, but add all members from TypeHandle.ObjectType
7169 if we're an interface.
7170 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
7171 is the current type.
7172 (MemberCache.CacheEntry.Container): Removed this field.
7173 (TypeHandle.GetMembers): Include inherited members.
7175 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7177 * typemanager.cs: fixed compilation and added a comment on a field that
7180 2002-08-15 Martin Baulig <martin@gnome.org>
7182 * class.cs (ConstructorInitializer.Resolve): In the
7183 Expression.MemberLookup call, use the queried_type as
7186 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
7187 declared' attribute, it's always true.
7188 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
7189 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
7190 temporary wrapper for FindMembers which tells MemberLookup whether
7191 members from the base classes are included in the return value.
7192 This will go away soon.
7193 (TypeManager.MemberLookup): Use this temporary hack here; once the
7194 new MemberCache is completed, we don't need to do the DeclaredOnly
7195 looping here anymore since the MemberCache will take care of this.
7196 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
7197 (MemberCache): When creating the MemberCache for a class, get
7198 members from the current class and all its base classes.
7199 (MemberCache.CacheEntry.Container): New field. This is a
7200 temporary hack until the Mono runtime is fixed to distinguish
7201 between ReflectedType and DeclaringType. It allows us to use MCS
7202 with both the MS runtime and the unfixed Mono runtime without
7203 problems and without accecting performance.
7204 (MemberCache.SearchMembers): The DeclaredOnly looping from
7205 TypeManager.MemberLookup is now done here.
7207 2002-08-14 Martin Baulig <martin@gnome.org>
7209 * statement.cs (MyStructInfo.MyStructInfo): Don't call
7210 Type.GetFields on dynamic types but get the fields from the
7211 corresponding TypeContainer.
7212 (MyStructInfo.GetStructInfo): Added check for enum types.
7214 * typemanager.cs (MemberList.IsSynchronized): Implemented.
7215 (MemberList.SyncRoot): Implemented.
7216 (TypeManager.FilterWithClosure): No need to check permissions if
7217 closure_start_type == closure_invocation_type, don't crash if
7218 closure_invocation_type is null.
7220 2002-08-13 Martin Baulig <martin@gnome.org>
7222 Rewrote TypeContainer.FindMembers to use a member cache. This
7223 gives us a speed increase of about 35% for the self-hosting MCS
7224 build and of about 15-20% for the class libs (both on GNU/Linux).
7226 * report.cs (Timer): New class to get enhanced profiling. This
7227 whole class is "TIMER" conditional since it remarkably slows down
7230 * class.cs (MemberList): New class. This is an IList wrapper
7231 which we're now using instead of passing MemberInfo[]'s around to
7232 avoid copying this array unnecessarily.
7233 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
7234 (ICachingMemberFinder, IMemberContainer): New interface.
7235 (TypeManager.FilterWithClosure): If `criteria' is null, the name
7236 has already been checked, otherwise use it for the name comparision.
7237 (TypeManager.FindMembers): Renamed to RealMemberFinder and
7238 provided wrapper which tries to use ICachingMemberFinder.FindMembers
7239 if possible. Returns a MemberList, not a MemberInfo [].
7240 (TypeHandle): New class, implements IMemberContainer. We create
7241 one instance of this class per type, it contains a MemberCache
7242 which is used to do the member lookups.
7243 (MemberCache): New class. Each instance of this class contains
7244 all members of a type and a name-based hash table.
7245 (MemberCache.FindMembers): This is our new member lookup
7246 function. First, it looks up all members of the requested name in
7247 the hash table. Then, it walks this list and sorts out all
7248 applicable members and returns them.
7250 2002-08-13 Martin Baulig <martin@gnome.org>
7252 In addition to a nice code cleanup, this gives us a performance
7253 increase of about 1.4% on GNU/Linux - not much, but it's already
7254 half a second for the self-hosting MCS compilation.
7256 * typemanager.cs (IMemberFinder): New interface. It is used by
7257 TypeManager.FindMembers to call FindMembers on a TypeContainer,
7258 Enum, Delegate or Interface.
7259 (TypeManager.finder_to_member_finder): New PtrHashtable.
7260 (TypeManager.finder_to_container): Removed.
7261 (TypeManager.finder_to_delegate): Removed.
7262 (TypeManager.finder_to_interface): Removed.
7263 (TypeManager.finder_to_enum): Removed.
7265 * interface.cs (Interface): Implement IMemberFinder.
7267 * delegate.cs (Delegate): Implement IMemberFinder.
7269 * enum.cs (Enum): Implement IMemberFinder.
7271 * class.cs (TypeContainer): Implement IMemberFinder.
7273 2002-08-12 Martin Baulig <martin@gnome.org>
7275 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
7277 2002-08-12 Martin Baulig <martin@gnome.org>
7279 * ecore.cs (ITypeExpression): New interface for expressions which
7281 (TypeExpression): Renamed to TypeLookupExpression.
7282 (Expression.DoResolve): If we're doing a types-only lookup, the
7283 expression must implement the ITypeExpression interface and we
7284 call DoResolveType() on it.
7285 (SimpleName): Implement the new ITypeExpression interface.
7286 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
7287 hack, the situation that we're only looking up types can't happen
7288 anymore when this method is called. Moved the type lookup code to
7289 DoResolveType() and call it.
7290 (SimpleName.DoResolveType): This ITypeExpression interface method
7291 is now doing the types-only lookup.
7292 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
7293 (ResolveFlags): Added MaskExprClass.
7295 * expression.cs (MemberAccess): Implement the ITypeExpression
7297 (MemberAccess.DoResolve): Added support for a types-only lookup
7298 when we're called via ITypeExpression.DoResolveType().
7299 (ComposedCast): Implement the ITypeExpression interface.
7301 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
7302 Expression.Resolve() with ResolveFlags.Type instead.
7304 2002-08-12 Martin Baulig <martin@gnome.org>
7306 * interface.cs (Interface.Define): Apply attributes.
7308 * attribute.cs (Attribute.ApplyAttributes): Added support for
7309 interface attributes.
7311 2002-08-11 Martin Baulig <martin@gnome.org>
7313 * statement.cs (Block.Emit): Only check the "this" variable if we
7314 do not always throw an exception.
7316 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
7317 whether the property has a set accessor.
7319 2002-08-11 Martin Baulig <martin@gnome.org>
7321 Added control flow analysis support for structs.
7323 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
7324 with control flow analysis turned off.
7325 (IVariable): New interface.
7326 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
7327 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
7328 (FieldExpr.DoResolve): Resolve the instance expression with flow
7329 analysis turned off and do the definite assignment check after the
7330 resolving when we know what the expression will resolve to.
7332 * expression.cs (LocalVariableReference, ParameterReference):
7333 Implement the new IVariable interface, only call the flow analysis
7334 code if ec.DoFlowAnalysis is true.
7335 (This): Added constructor which takes a Block argument. Implement
7336 the new IVariable interface.
7337 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
7338 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
7339 This does the definite assignment checks for struct members.
7341 * class.cs (Constructor.Emit): If this is a non-static `struct'
7342 constructor which doesn't have any initializer, call
7343 Block.AddThisVariable() to tell the flow analysis code that all
7344 struct elements must be initialized before control returns from
7347 * statement.cs (MyStructInfo): New public class.
7348 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
7349 argument to this indexer. If non-zero, check an individual struct
7350 member, not the whole struct.
7351 (FlowBranching.CheckOutParameters): Check struct members.
7352 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
7353 overloaded versions of these methods which take an additional
7354 `int field_idx' argument to check struct members.
7355 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
7356 overloaded versions of these methods which take an additional
7357 `string field_name' argument to check struct member.s
7358 (VariableInfo): Implement the IVariable interface.
7359 (VariableInfo.StructInfo): New public property. Returns the
7360 MyStructInfo instance of the variable if it's a struct or null.
7361 (Block.AddThisVariable): New public method. This is called from
7362 Constructor.Emit() for non-static `struct' constructor which do
7363 not have any initializer. It creates a special variable for the
7364 "this" instance variable which will be checked by the flow
7365 analysis code to ensure that all of the struct's fields are
7366 initialized before control returns from the constructor.
7367 (UsageVector): Added support for struct members. If a
7368 variable/parameter is a struct with N members, we reserve a slot
7369 in the usage vector for each member. A struct is considered fully
7370 initialized if either the struct itself (slot 0) or all its
7371 members are initialized.
7373 2002-08-08 Martin Baulig <martin@gnome.org>
7375 * driver.cs (Driver.MainDriver): Only report an error CS5001
7376 if there were no compilation errors.
7378 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
7379 `UnsafeContext' property to determine whether the parent is in
7380 unsafe context rather than checking the parent's ModFlags:
7381 classes nested in an unsafe class are unsafe as well.
7383 2002-08-08 Martin Baulig <martin@gnome.org>
7385 * statement.cs (UsageVector.MergeChildren): Distinguish between
7386 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
7387 we return. Added test17() and test18() to test-154.cs.
7389 2002-08-08 Martin Baulig <martin@gnome.org>
7391 * typemanager.cs (TypeManager.FilterWithClosure): If we have
7392 Family access, make sure the invoking type isn't a subclass of the
7393 queried type (that'd be a CS1540).
7395 * ecore.cs (Expression.MemberLookup): Added overloaded version of
7396 this method which takes an additional `Type invocation_type'.
7398 * expression.cs (BaseAccess.DoResolve): Use the base type as
7399 invocation and query type.
7400 (MemberAccess.DoResolve): If the lookup failed and we're about to
7401 report a CS0122, try a lookup with the ec.ContainerType - if this
7402 succeeds, we must report a CS1540.
7404 2002-08-08 Martin Baulig <martin@gnome.org>
7406 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
7407 (MethodGroupExpr): Implement the IMemberExpr interface.
7409 * expression (MemberAccess.ResolveMemberAccess): No need to have
7410 any special code for MethodGroupExprs anymore, they're now
7413 2002-08-08 Martin Baulig <martin@gnome.org>
7415 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
7416 Family, FamANDAssem and FamORAssem permissions.
7417 (TypeManager.IsSubclassOrNestedChildOf): New public method.
7419 2002-08-08 Martin Baulig <martin@gnome.org>
7421 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
7422 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
7425 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
7427 * driver.cs: implemented /resource option to embed managed resources.
7429 2002-08-07 Martin Baulig <martin@gnome.org>
7431 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
7432 (FieldBase.HasFieldInitializer): New public property.
7433 (FieldBase.GetInitializerExpression): New public method. Resolves and
7434 returns the field initializer and makes sure it is only resolved once.
7435 (TypeContainer.EmitFieldInitializers): Call
7436 FieldBase.GetInitializerExpression to get the initializer, this ensures
7437 that it isn't resolved multiple times.
7439 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
7440 the resolving process (SimpleName/MemberLookup) that we're currently
7441 emitting a field initializer (which must not access any instance members,
7442 this is an error CS0236).
7444 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
7445 argument, if the `IsFieldInitializer' flag is set, we must report and
7446 error CS0236 and not an error CS0120.
7448 2002-08-07 Martin Baulig <martin@gnome.org>
7450 * ecore.cs (IMemberExpr): New public interface.
7451 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
7452 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
7453 if the expression is an IMemberExpr.
7455 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
7456 to be null, implicitly default to `this' if we're non-static in
7457 this case. Simplified the code a lot by using the new IMemberExpr
7458 interface. Also fixed bug #28176 here.
7460 2002-08-06 Martin Baulig <martin@gnome.org>
7462 * cs-parser.jay (SimpleLookup): Removed. We need to create
7463 ParameterReferences during semantic analysis so that we can do a
7464 type-only search when resolving Cast, TypeOf and SizeOf.
7465 (block): Pass the `current_local_parameters' to the Block's
7468 * class.cs (ConstructorInitializer): Added `Parameters parameters'
7469 argument to the constructor.
7470 (ConstructorInitializer.Resolve): Create a temporary implicit
7471 block with the parameters.
7473 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
7474 references here if we aren't doing a type-only search.
7476 * statement.cs (Block): Added constructor which takes a
7477 `Parameters parameters' argument.
7478 (Block.Parameters): New public property.
7480 * support.cs (InternalParameters.Parameters): Renamed `parameters'
7481 to `Parameters' and made it public readonly.
7483 2002-08-06 Martin Baulig <martin@gnome.org>
7485 * ecore.cs (Expression.Warning): Made this public as well.
7487 * report.cs (Report.Debug): Print the contents of collections.
7489 2002-08-06 Martin Baulig <martin@gnome.org>
7491 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
7492 used to tell Resolve() which kinds of expressions it may return.
7493 (Expression.Resolve): Added overloaded version of this method which
7494 takes a `ResolveFlags flags' argument. This can be used to tell
7495 Resolve() which kinds of expressions it may return. Reports a
7497 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
7498 ResolveFlags.SimpleName.
7499 (Expression.Error118): Added overloaded version of this method which
7500 takes a `ResolveFlags flags' argument. It uses the flags to determine
7501 which kinds of expressions are allowed.
7503 * expression.cs (Argument.ResolveMethodGroup): New public method.
7504 Resolves an argument, but allows a MethodGroup to be returned.
7505 This is used when invoking a delegate.
7507 * TODO: Updated a bit.
7509 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7511 Fixed compilation with csc.
7513 * ecore.cs: Expression.Error made public. Is this correct? Should
7514 Warning be made public too?
7516 * expression.cs: use ea.Location instead of ea.loc.
7517 [FIXME: Filed as bug #28607: MCS must report these errors.]
7519 2002-08-06 Martin Baulig <martin@gnome.org>
7521 * ecore.cs (Expression.loc): Moved the location here instead of
7522 duplicating it in all derived classes.
7523 (Expression.Location): New public property.
7524 (Expression.Error, Expression.Warning): Made them non-static and
7525 removed the location argument.
7526 (Expression.Warning): Added overloaded version which takes an
7527 `int level' argument.
7528 (Expression.Error118): Make this non-static and removed the
7529 expression and location arguments.
7530 (TypeExpr): Added location argument to the constructor.
7532 * expression.cs (StaticCallExpr): Added location argument to
7534 (Indirection, PointerArithmetic): Likewise.
7535 (CheckedExpr, UnCheckedExpr): Likewise.
7536 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
7537 (StringPtr): Likewise.
7540 2002-08-05 Martin Baulig <martin@gnome.org>
7542 * expression.cs (BaseAccess.DoResolve): Actually report errors.
7544 * assign.cs (Assign.DoResolve): Check whether the source
7545 expression is a value or variable.
7547 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
7548 while resolving the corresponding blocks.
7550 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
7551 an error, don't silently return null.
7553 * statement.cs (Block.AddVariable): Do the error reporting here
7554 and distinguish between CS0128 and CS0136.
7555 (Block.DoResolve): Report all unused labels (warning CS0164).
7556 (LabeledStatement): Pass the location to the constructor.
7557 (LabeledStatement.HasBeenReferenced): New property.
7558 (LabeledStatement.Resolve): Set it to true here.
7560 * statement.cs (Return.Emit): Return success even after reporting
7561 a type mismatch error (CS0126 or CS0127), this is what csc does and
7562 it avoids confusing the users with any consecutive errors.
7564 2002-08-05 Martin Baulig <martin@gnome.org>
7566 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
7568 * const.cs (Const.LookupConstantValue): Catch circular definitions.
7570 * expression.cs (MemberAccess.DoResolve): Silently return if an
7571 error has already been reported.
7573 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
7574 error has already been reported.
7576 2002-08-05 Martin Baulig <martin@gnome.org>
7578 * statement.cs (UsageVector): Only initialize the `parameters'
7579 vector if we actually have any "out" parameters.
7581 2002-08-05 Martin Baulig <martin@gnome.org>
7583 * expression.cs (Binary.ResolveOperator): When combining delegates,
7584 they must have the same type.
7586 2002-08-05 Martin Baulig <martin@gnome.org>
7588 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
7589 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
7590 work with the ms runtime and we also don't need it: if we're a
7591 PropertyBuilder and not in the `indexer_arguments' hash, then we
7592 are a property and not an indexer.
7594 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
7595 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
7596 since the latter one doesn't work with the ms runtime.
7598 2002-08-03 Martin Baulig <martin@gnome.org>
7600 Fixed bugs #27998 and #22735.
7602 * class.cs (Method.IsOperator): New public field.
7603 (Method.CheckBase): Report CS0111 if there's already a method
7604 with the same parameters in the current class. Report CS0508 when
7605 attempting to change the return type of an inherited method.
7606 (MethodData.Emit): Report CS0179 if a method doesn't have a body
7607 and it's not marked abstract or extern.
7608 (PropertyBase): New abstract base class for Property and Indexer.
7609 (PropertyBase.CheckBase): Moved here from Property and made it work
7611 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
7612 the same so we can reuse it there.
7613 (Property, Indexer): Derive from PropertyBase.
7614 (MethodSignature.inheritable_property_signature_filter): New delegate
7615 to find properties and indexers.
7617 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
7618 argument and improved error reporting.
7620 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
7621 EmptyReadOnlyParameters and made it a property.
7623 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
7624 version of this method which takes a `PropertyInfo indexer'.
7625 (TypeManager.RegisterIndexer): New method.
7627 * class.cs: Added myself as author of this file :-)
7629 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7631 * class.cs: fixed compilation on windoze.
7633 2002-08-03 Martin Baulig <martin@gnome.org>
7635 * interface.cs (Interface.GetInterfaceBases): Check whether all
7636 base interfaces are at least as accessible than the current one.
7638 * class.cs (TypeContainer.GetClassBases): Check whether base types
7639 are at least as accessible than the current type.
7640 (TypeContainer.AsAccessible): Implemented and made non-static.
7641 (MemberBase.CheckParameters): Report errors if the accessibility
7644 * delegate.cs (Delegate.Delegate): The default visibility is
7645 internal for top-level types and private for nested types.
7646 (Delegate.Define): Report errors if the accessibility checks fail.
7648 * enum.cs (Enum.Enum): The default visibility is internal for
7649 top-level types and private for nested types.
7650 (Enum.DefineType): Compute the correct visibility.
7652 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
7653 function which takes a `bool is_toplevel' instead of a TypeContainer.
7655 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
7658 2002-08-02 Martin Baulig <martin@gnome.org>
7660 * expression.cs (LocalVariableReferenc): Added constructor which
7661 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
7662 (LocalVariableReference.IsReadOnly): New property.
7663 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
7664 variable is readonly, use our own readonly flag to do this; you can
7665 use the new constructor to get a writable reference to a read-only
7668 * cs-parser.jay (foreach_statement, using_statement): Get a writable
7669 reference to the local variable.
7671 2002-08-01 Miguel de Icaza <miguel@ximian.com>
7673 * rootcontext.cs (ResolveCore): Also include System.Exception
7675 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
7676 we reach an EmptyStatement.
7678 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
7681 * expression.cs (Binary.ResolveOperator): Check error result in
7684 use brtrue/brfalse directly and avoid compares to null.
7686 2002-08-02 Martin Baulig <martin@gnome.org>
7688 * class.cs (TypeContainer.Define): Define all nested interfaces here.
7689 Fixes bug #28407, added test-155.cs.
7691 2002-08-01 Martin Baulig <martin@gnome.org>
7693 * class.cs (Event.EmitDefaultMethod): Make this work with static
7694 events. Fixes #28311, added verify-3.cs.
7696 2002-08-01 Martin Baulig <martin@gnome.org>
7698 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
7699 `is_disposable' fields.
7700 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
7701 `hm.is_disposable' if we're using the collection pattern.
7702 (Foreach.EmitCollectionForeach): Use the correct type for the
7703 enumerator's local variable, only emit the try/finally block if
7704 necessary (fixes #27713).
7706 2002-08-01 Martin Baulig <martin@gnome.org>
7708 * ecore.cs (Expression.report118): Renamed to Error118 and made
7711 * statement.cs (Throw.Resolve): Check whether the expression is of
7712 the correct type (CS0118) and whether the type derives from
7713 System.Exception (CS0155).
7714 (Catch.Resolve): New method. Do the type lookup here and check
7715 whether it derives from System.Exception (CS0155).
7716 (Catch.CatchType, Catch.IsGeneral): New public properties.
7718 * typemanager.cs (TypeManager.exception_type): Added.
7720 2002-07-31 Miguel de Icaza <miguel@ximian.com>
7722 * driver.cs: Updated About function.
7724 2002-07-31 Martin Baulig <martin@gnome.org>
7726 Implemented Control Flow Analysis.
7728 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
7729 (EmitContext.CurrentBranching): Added.
7730 (EmitContext.StartFlowBranching): Added.
7731 (EmitContext.EndFlowBranching): Added.
7732 (EmitContext.KillFlowBranching): Added.
7733 (EmitContext.IsVariableAssigned): Added.
7734 (EmitContext.SetVariableAssigned): Added.
7735 (EmitContext.IsParameterAssigned): Added.
7736 (EmitContext.SetParameterAssigned): Added.
7737 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
7738 Added control flow analysis stuff here.
7740 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
7741 resolve the expression as lvalue.
7742 (LocalVariableReference.DoResolve): Check whether the variable has
7743 already been assigned.
7744 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
7745 the parameter as assigned here.
7746 (ParameterReference.DoResolve): Check whether the parameter has already
7748 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
7749 expression as lvalue.
7751 * statement.cs (FlowBranching): New class for the flow analysis code.
7752 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
7753 (LabeledStatement.IsDefined): New public property.
7754 (LabeledStatement.AddUsageVector): New public method to tell flow
7755 analyis that the label may be reached via a forward jump.
7756 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
7758 (VariableInfo.Number): New public field. This is used by flow analysis
7759 to number all locals of a block.
7760 (Block.CountVariables): New public property. This is the number of
7761 local variables in this block (including the locals from all parent
7763 (Block.EmitMeta): Number all the variables.
7765 * statement.cs: Added flow analysis support to all classes.
7767 2002-07-31 Martin Baulig <martin@gnome.org>
7769 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
7770 To get debugging messages, compile mcs with /define:MCS_DEBUG and
7771 then use this argument.
7773 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
7775 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
7776 use this to specify /define options.
7778 2002-07-29 Martin Baulig <martin@gnome.org>
7780 * statement.cs (Fixed): Moved all code that does variable lookups
7781 and resolvings from Emit to Resolve.
7783 * statement.cs (For): Moved all code that does variable lookups
7784 and resolvings from Emit to Resolve.
7786 * statement.cs (Using): Moved all code that does variable lookups
7787 and resolvings from Emit to Resolve.
7789 2002-07-29 Martin Baulig <martin@gnome.org>
7791 * attribute.cs (Attribute.Resolve): Explicitly catch a
7792 System.NullReferenceException when creating the
7793 CustromAttributeBuilder and report a different warning message.
7795 2002-07-29 Martin Baulig <martin@gnome.org>
7797 * support.cs (ParameterData.ParameterName): Added method to
7798 get the name of a parameter.
7800 * typemanager.cs (TypeManager.IsValueType): New public method.
7802 2002-07-29 Martin Baulig <martin@gnome.org>
7804 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
7805 is a flag which specifies that it's either ref or out.
7806 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
7807 the out parameter to `out Parameter.Modifier mod', also set the
7808 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
7810 * support.cs (InternalParameters.ParameterModifier): Distinguish
7811 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
7812 Parameter.Modifier.ISBYREF flag if it's either ref or out.
7814 * expression.cs (Argument.GetParameterModifier): Distinguish
7815 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
7816 Parameter.Modifier.ISBYREF flag if it's either ref or out.
7818 2002-07-29 Martin Baulig <martin@gnome.org>
7820 * expression.cs (ParameterReference.ParameterReference): Added
7821 `Location loc' argument to the constructor.
7823 * cs-parser.jay: Pass location to ParameterReference.
7825 2002-07-28 Miguel de Icaza <miguel@ximian.com>
7827 * statement.cs (Try): Initialize the location.
7829 * cs-parser.jay: pass location to Try.
7831 * expression.cs (Unary.Reduce): Change the prototype to return
7832 whether a constant fold could be performed or not. The result is
7833 returned in an out parameters. In the case of Indirection and
7834 AddressOf, we want to perform the full tests.
7836 2002-07-26 Miguel de Icaza <miguel@ximian.com>
7838 * statement.cs (Statement.Emit): Flag dead code.
7840 2002-07-27 Andrew Birkett <andy@nobugs.org>
7842 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
7844 2002-07-27 Martin Baulig <martin@gnome.org>
7846 * class.cs (MethodData.Define): Put back call to
7847 TypeManager.AddMethod(), accidentally commented this out.
7849 * report.cs (Debug): New public method to print debugging information,
7850 this is `[Conditional ("DEBUG")]'.
7852 2002-07-26 Martin Baulig <martin@gnome.org>
7854 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
7855 (switch_statement): Push the current_block to the switch_stack and
7856 pop it again when we're done with the switch.
7857 (switch_section): The new block is a child of the current_block.
7858 Fixes bug #24007, added test-152.cs.
7860 2002-07-27 Martin Baulig <martin@gnome.org>
7862 * expression.cs (Invocation.EmitArguments): When calling a varargs
7863 function with only its fixed arguments, we need to pass an empty
7866 2002-07-27 Martin Baulig <martin@gnome.org>
7868 Mono 0.13 has been released.
7870 2002-07-25 Miguel de Icaza <miguel@ximian.com>
7872 * driver.cs: Rename --resource to --linkres, because that is what
7873 we do currently, we dont support --resource yet.
7875 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
7877 2002-07-25 Martin Baulig <martin@gnome.org>
7879 * class.cs (MethodData): New public class. This is a `method builder'
7880 class for a method or one accessor of a Property/Indexer/Event.
7881 (MethodData.GetMethodFlags): Moved here from MemberBase.
7882 (MethodData.ApplyAttributes): Likewise.
7883 (MethodData.ApplyObsoleteAttribute): Likewise.
7884 (MethodData.ApplyConditionalAttribute): Likewise.
7885 (MethodData.ApplyDllImportAttribute): Likewise.
7886 (MethodData.CheckAbstractAndExternal): Likewise.
7887 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
7888 (MethodData.Emit): Formerly known as Method.Emit().
7889 (MemberBase): Moved everything which was specific to a single
7890 accessor/method to MethodData.
7891 (Method): Create a new MethodData and call Define() and Emit() on it.
7892 (Property, Indexer, Event): Create a new MethodData objects for each
7893 accessor and call Define() and Emit() on them.
7895 2002-07-25 Martin Baulig <martin@gnome.org>
7897 Made MethodCore derive from MemberBase to reuse the code from there.
7898 MemberBase now also checks for attributes.
7900 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
7901 (MemberBase.GetMethodFlags): Moved here from class Method and marked
7903 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
7904 `CallingConventions cc' and `Attributes opt_attrs' arguments.
7905 (MemberBase.ApplyAttributes): New virtual method; applies the
7906 attributes to a method or accessor.
7907 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
7908 (MemberBase.ApplyConditionalAttribute): Likewise.
7909 (MemberBase.ApplyDllImportAttribute): Likewise.
7910 (MemberBase.CheckAbstractAndExternal): Likewise.
7911 (MethodCore.ParameterTypes): This is now a property instead of a
7912 method, it's initialized from DoDefineParameters().
7913 (MethodCore.ParameterInfo): Removed the set accessor.
7914 (MethodCore.DoDefineParameters): New protected virtual method to
7915 initialize ParameterTypes and ParameterInfo.
7916 (Method.GetReturnType): We can now simply return the MemberType.
7917 (Method.GetMethodFlags): Override the MemberBase version and add
7918 the conditional flags.
7919 (Method.CheckBase): Moved some code from Define() here, call
7920 DoDefineParameters() here.
7921 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
7922 here to avoid some larger code duplication.
7923 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
7924 ensure that abstract and external accessors don't declare a body.
7926 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
7927 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
7928 lookup in the attribute's parent classes, so we need to abort as soon
7929 as we found the first match.
7930 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
7931 the attribute has no arguments.
7933 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
7936 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7938 * cs-parser.jay: reverted previous patch.
7940 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7942 * cs-parser.jay: fixed bug #22119.
7944 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7946 * attribute.cs: fixed compilation. The error was:
7947 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
7948 be assigned to before control leaves the current method."
7949 [FIXME: Filed as bug #28186: MCS must report this error.]
7951 2002-07-25 Martin Baulig <martin@gnome.org>
7953 * attribute.cs (Attribute.Conditional_GetConditionName): New static
7954 method to pull the condition name ouf of a Conditional attribute.
7955 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
7956 the obsolete message and error flag out of an Obsolete attribute.
7958 * class.cs (Method.GetMethodFlags): New public method to get the
7959 TypeManager.MethodFlags for this method.
7960 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
7962 (Method.Define): Get and apply the Obsolete and Conditional attributes;
7963 if we're overriding a virtual function, set the new private variable
7964 `parent_method'; call the new TypeManager.AddMethod().
7966 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
7967 the MethodBuilder and the Method in a PtrHashtable.
7968 (TypeManager.builder_to_method): Added for this purpose.
7969 (TypeManager.MethodFlags): Added IsObsoleteError.
7970 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
7971 Obsolete and Conditional arguments in MethodBuilders. If we discover
7972 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
7973 the message from the attribute.
7975 2002-07-24 Martin Baulig <martin@gnome.org>
7977 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
7978 preprocessor directives, ensure that the argument to #define/#undef is
7979 exactly one identifier and that it's actually an identifier.
7981 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
7984 2002-07-24 Martin Baulig <martin@gnome.org>
7986 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
7987 initialize it to TypeManager.object_type in the constructor.
7988 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
7989 of the `hm.get_current' method if we're using the collection pattern.
7990 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
7991 for the explicit conversion to make it work when we're using the collection
7992 pattern and the `Current' property has a different return type than `object'.
7995 2002-07-24 Martin Baulig <martin@gnome.org>
7997 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
7998 does not match, but don't report any errors. This method is called in
7999 order for all methods in a MethodGroupExpr until a matching method is
8000 found, so we don't want to bail out if the first method doesn't match.
8001 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
8002 matches, report the 123. Fixes #28070.
8004 2002-07-24 Martin Baulig <martin@gnome.org>
8006 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
8007 TypeManager.TypeToCoreType() to the top of the method so the
8008 following equality checks will work. Fixes #28107.
8010 2002-07-24 Martin Baulig <martin@gnome.org>
8012 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
8013 operand is of type uint, and the other operand is of type sbyte,
8014 short or int, the operands are converted to type long." -
8015 Actually do what this comment already told us. Fixes bug #28106,
8018 2002-07-24 Martin Baulig <martin@gnome.org>
8020 * class.cs (MethodBase): New abstract class. This is now a base
8021 class for Property, Indexer and Event to avoid some code duplication
8022 in their Define() and DefineMethods() methods.
8023 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
8024 generic methods for Define() and DefineMethods().
8025 (FieldBase): Derive from MemberBase, not MemberCore.
8026 (Property): Derive from MemberBase, not MemberCore.
8027 (Property.DefineMethod): Moved all the code from this method to the
8028 new MethodBase.DefineAccessor(), just call it with appropriate
8030 (Property.Define): Call the new Property.DoDefine(), this does some
8031 sanity checks and we don't need to duplicate the code everywhere.
8032 (Event): Derive from MemberBase, not MemberCore.
8033 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
8034 accessors, this will also make them work with interface events.
8035 (Indexer): Derive from MemberBase, not MemberCore.
8036 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
8037 (Indexer.Define): Use the new MethodBase functions.
8039 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
8040 argument to the constructor.
8041 (Interface.FindMembers): Added support for interface events.
8042 (Interface.PopluateEvent): Implemented.
8044 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
8046 2002-07-22 Miguel de Icaza <miguel@ximian.com>
8048 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
8049 but this is required to check for a method name being the same as
8050 the containing class.
8054 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8056 * interface.cs: initialize variable.
8058 2002-07-23 Martin Baulig <martin@gnome.org>
8060 Implemented the IndexerName attribute in interfaces.
8062 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
8063 name if this is an explicit interface implementation.
8064 (Indexer.InterfaceIndexerName): New public variable. If we're
8065 implementing an interface indexer, this is the IndexerName in that
8066 interface. Otherwise, it's the IndexerName.
8067 (Indexer.DefineMethod): If we're implementing interface indexer,
8068 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
8069 and Pending.ImplementIndexer methods.
8070 (Indexer.Define): Also define the PropertyBuilder if we're
8071 implementing an interface indexer and this is neither an explicit
8072 interface implementation nor do the IndexerName match the one in
8075 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
8076 If a method is defined here, then we always need to create a proxy
8077 for it. This is used when implementing interface indexers.
8078 (Pending.IsInterfaceIndexer): New public method.
8079 (Pending.ImplementIndexer): New public method.
8080 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
8081 This is used when implementing interface indexers to define a proxy
8083 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
8084 define a proxy if necessary.
8086 * interface.cs (Interface.IndexerName): New public variable.
8087 (Interface.PopulateIndexer): Set the IndexerName.
8088 (Interface.DefineIndexers): New private method. Populate all the
8089 indexers and make sure their IndexerNames match.
8091 * typemanager.cs (IndexerPropertyName): Added support for interface
8094 2002-07-22 Martin Baulig <martin@gnome.org>
8096 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
8097 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
8098 ret if HasReturnLabel.
8099 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
8102 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
8103 and set the ec.LoopBeginTryCatchLevel.
8104 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
8105 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
8106 the current ec.TryCatchLevel, the branch goes out of an exception
8107 block. In this case, we need to use Leave and not Br.
8109 2002-07-22 Martin Baulig <martin@gnome.org>
8111 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
8112 block unless the block does not always return or it is contained in
8113 another try { ... } catch { ... } block. Fixes bug #26506.
8114 Added verify-1.cs to the test suite.
8116 2002-07-22 Martin Baulig <martin@gnome.org>
8118 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
8119 then we do not always return. Fixes bug #24985.
8121 2002-07-22 Martin Baulig <martin@gnome.org>
8123 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
8124 lookup on a per-class level; ie. walk up the class hierarchy until we
8125 found at least one applicable method, then choose the best among them.
8126 Fixes bug #24463 and test-29.cs.
8128 2002-07-22 Martin Baulig <martin@gnome.org>
8130 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
8131 return types of the methods. The return type is not part of the
8132 signature and we must not check it to make the `new' modifier work.
8133 Fixes bug #27999, also added test-147.cs.
8134 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
8136 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
8137 on the method's return type.
8139 2002-07-21 Martin Baulig <martin@gnome.org>
8141 * assign.cs: Make this work if the rightmost source is a constant and
8142 we need to do an implicit type conversion. Also adding a few more tests
8143 to test-38.cs which should have caught this.
8145 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
8146 target in the makefile for this. The makefile.gnu is primarily intended
8147 for end-users who don't want to debug the compiler.
8149 2002-07-21 Martin Baulig <martin@gnome.org>
8151 * assign.cs: Improved the Assign class so it can now handle embedded
8152 assignments (X = Y = Z = something). As a side-effect this'll now also
8153 consume less local variables. test-38.cs now passes with MCS, added
8154 a few new test cases to that test.
8156 2002-07-20 Martin Baulig <martin@gnome.org>
8158 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
8159 instructions. Fixes bug #27977, also added test-146.cs.
8161 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8163 * cs-tokenizer.cs: fixed getHex ().
8165 2002-07-19 Martin Baulig <martin@gnome.org>
8167 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
8168 not Type.GetType() to lookup the array type. This is needed when
8169 we're constructing an array of a user-defined type.
8170 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
8171 single-dimensional arrays, but also for single-dimensial arrays of
8174 2002-07-19 Martin Baulig <martin@gnome.org>
8176 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
8177 this function is called, it's not allowed to share LocalBuilders
8180 2002-07-19 Martin Baulig <martin@gnome.org>
8182 * expression.cs (Argument.Resolve): Report an error 118 when trying
8183 to pass a type as argument.
8185 2002-07-18 Martin Baulig <martin@gnome.org>
8187 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
8188 Conv_R_Un for the signed `long' type.
8190 2002-07-15 Miguel de Icaza <miguel@ximian.com>
8192 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
8193 `expr' for the temporary result, as that will fail if we do
8194 multiple resolves on the same expression.
8196 2002-07-05 Miguel de Icaza <miguel@ximian.com>
8198 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
8199 ec.TypeContainer for looking up aliases.
8201 * class.cs (TypeContainer): Remove LookupAlias from here.
8203 * decl.cs (DeclSpace); Move here.
8205 2002-07-01 Miguel de Icaza <miguel@ximian.com>
8207 * class.cs (FindMembers): Only call filter if the constructor
8208 bulider is not null.
8210 Also handle delegates in `NestedTypes' now. Now we will perform
8211 type lookups using the standard resolution process. This also
8214 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
8215 This uses Expressions (the limited kind that can be parsed by the
8216 tree) instead of strings.
8218 * expression.cs (ComposedCast.ToString): Implement, used to flag
8219 errors since now we have to render expressions.
8221 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
8224 * ecore.cs (SimpleName.ToString): ditto.
8226 * cs-parser.jay: Instead of using strings to assemble types, use
8227 Expressions to assemble the type (using SimpleName, ComposedCast,
8228 MemberAccess). This should fix the type lookups in declarations,
8229 because we were using a different code path for this.
8231 * statement.cs (Block.Resolve): Continue processing statements
8232 even when there is an error.
8234 2002-07-17 Miguel de Icaza <miguel@ximian.com>
8236 * class.cs (Event.Define): Also remove the `remove' method from
8237 the list of pending items.
8239 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
8240 generate more compact code.
8242 2002-07-17 Martin Baulig <martin@gnome.org>
8244 * const.cs (Const.LookupConstantValue): Add support for constant
8245 `unchecked' and `checked' expressions.
8246 Also adding test case test-140.cs for this.
8248 2002-07-17 Martin Baulig <martin@gnome.org>
8250 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
8251 check whether mi.ReturnType implements the IEnumerator interface; the
8252 `==' and the IsAssignableFrom() will fail in this situation.
8254 2002-07-16 Ravi Pratap <ravi@ximian.com>
8256 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
8259 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8261 * expression.cs: fixed bug #27811.
8263 2002-07-14 Miguel de Icaza <miguel@ximian.com>
8265 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
8266 Molaro: when we are a ref, the value already contains a pointer
8267 value, do not take the address of it.
8269 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
8270 * removed mb-parser.jay and mb-tokenizer.cs
8272 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
8274 * expression.cs: check against the building corlib void type.
8276 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
8278 * ecore.cs: fix for valuetype static readonly fields: when
8279 initializing them, we need their address, not the address of a copy.
8281 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
8283 * typemanager.cs: register also enum_type in corlib.
8285 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
8287 * class.cs: allow calling this (but not base) initializers in structs.
8289 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
8291 * ecore.cs: make sure we compare against the building base types
8294 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
8296 * typemanager.cs: fix TypeToCoreType() to handle void and object
8297 (corlib gets no more typerefs after this change).
8299 2002-07-12 Miguel de Icaza <miguel@ximian.com>
8301 * expression.cs (ArrayCreation.EmitArrayArguments): use
8302 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
8304 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
8305 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
8306 array indexes, the runtime actually forbids them.
8308 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
8309 for array arguments here.
8311 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
8312 instead of the default for ValueTypes.
8314 (New.DoEmit): Use IsValueType instead of
8315 IsSubclassOf (value_type)
8316 (New.DoResolve): ditto.
8317 (Invocation.EmitCall): ditto.
8319 * assign.cs (Assign): ditto.
8321 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
8322 Statements *are* currently doing part of their resolution during
8325 Expressions do always resolve during resolve, but statements are
8326 only required to propagate resolution to their children.
8328 2002-07-11 Miguel de Icaza <miguel@ximian.com>
8330 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
8332 (LoadAssembly): Do not add the dll if it is already specified
8334 (MainDriver): Add the System directory to the link path at the end,
8335 after all the other -L arguments.
8337 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
8338 wrong opcode for loading bytes and bools (ldelem.i1 instead of
8339 ldelem.u1) and using the opposite for sbytes.
8341 This fixes Digger, and we can finally run it.
8343 * driver.cs (UnixParseOption): Move the option parsing here.
8344 (CSCParseOption): Implement CSC-like parsing of options.
8346 We now support both modes of operation, the old Unix way, and the
8347 new CSC-like way. This should help those who wanted to make cross
8350 The only thing broken is that /r:, /reference: and /lib: are not
8351 implemented, because I want to make those have the same semantics
8352 as the CSC compiler has, and kill once and for all the confussion
8353 around this. Will be doing this tomorrow.
8355 * statement.cs (Unsafe.Resolve): The state is checked during
8356 resolve, not emit, so we have to set the flags for IsUnsfe here.
8358 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8360 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
8361 not catch the Error_ObjectRefRequired in SimpleName (as it is
8362 possible to have a class/instance variable name that later gets
8363 deambiguated), we have to check this here.
8365 2002-07-10 Ravi Pratap <ravi@ximian.com>
8367 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
8368 make static and put into Expression.
8370 (Event.Define): Register the private field of the event with the
8371 TypeManager so that GetFieldFromEvent can get at it.
8373 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
8374 keep track of the private field associated with an event which
8377 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
8380 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
8382 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8384 * expression.cs (Binary.EmitBranchable): this routine emits the
8385 Binary expression in a branchable context. This basically means:
8386 we need to branch somewhere, not just get the value on the stack.
8388 This works together with Statement.EmitBoolExpression.
8390 * statement.cs (Statement.EmitBoolExpression): Use
8393 2002-07-09 Miguel de Icaza <miguel@ximian.com>
8395 * statement.cs (For): Reduce the number of jumps in loops.
8397 (For): Implement loop inversion for the For statement.
8399 (Break): We can be breaking out of a Try/Catch controlled section
8400 (foreach might have an implicit try/catch clause), so we need to
8401 use Leave instead of Br.
8403 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
8404 now). If the instace expression supports IMemoryLocation, we use
8405 the AddressOf method from the IMemoryLocation to extract the
8406 address instead of emitting the instance.
8408 This showed up with `This', as we were emitting the instance
8409 always (Emit) instead of the Address of This. Particularly
8410 interesting when This is a value type, as we dont want the Emit
8411 effect (which was to load the object).
8413 2002-07-08 Miguel de Icaza <miguel@ximian.com>
8415 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
8417 * statement.cs (Checked): Set the CheckedState during the resolve
8418 process too, as the ConvCast operations track the checked state on
8419 the resolve process, and not emit.
8421 * cs-parser.jay (namespace_member_declaration): Flag that we have
8422 found a declaration when we do. This is used to flag error 1529
8424 * driver.cs: Report ok when we display the help only.
8426 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
8428 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
8430 2002-07-04 Miguel de Icaza <miguel@ximian.com>
8432 * cs-tokenizer.cs (define): We also have to track locally the
8433 defines. AllDefines is just used for the Conditional Attribute,
8434 but we also need the local defines for the current source code.
8436 2002-07-03 Miguel de Icaza <miguel@ximian.com>
8438 * statement.cs (While, For, Do): These loops can exit through a
8439 Break statement, use this information to tell whether the
8440 statement is the last piece of code.
8442 (Break): Flag that we break.
8444 * codegen.cs (EmitContexts): New `Breaks' state variable.
8446 2002-07-03 Martin Baulig <martin@gnome.org>
8448 * class.cs (TypeContainer.MethodModifiersValid): Allow override
8449 modifiers in method declarations in structs. Otherwise, you won't
8450 be able to override things like Object.Equals().
8452 2002-07-02 Miguel de Icaza <miguel@ximian.com>
8454 * class.cs (Method, Property, Indexer): Do not allow the public
8455 modifier to be used in explicit interface implementations.
8457 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
8458 override modifiers in method declarations in structs
8460 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
8462 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
8463 integer or real overflow, report an error
8465 2002-07-02 Martin Baulig <martin@gnome.org>
8467 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
8468 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
8469 to tell the runtime about our newly created System.Object and
8470 System.ValueType types.
8472 2002-07-02 Miguel de Icaza <miguel@ximian.com>
8474 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
8475 struct instead of Ldarg/Starg.
8477 2002-07-02 Martin Baulig <martin@gnome.org>
8479 * expression.cs (Indirection.Indirection): Call
8480 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
8482 2002-07-02 Martin Baulig <martin@gnome.org>
8484 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
8485 ValueType, call TypeManager.TypeToCoreType() on it.
8486 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
8487 the OpCodes.Newarr argument.
8489 2002-07-02 Martin Baulig <martin@gnome.org>
8491 * expression.cs (Invocation.EmitCall): When compiling corlib,
8492 replace all calls to the system's System.Array type to calls to
8493 the newly created one.
8495 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
8496 System.Array methods.
8497 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
8498 from the system's System.Array type which must be replaced.
8500 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
8502 * typemanager.cs: load unverifiable_code_ctor so we can build
8503 corlib using the correct type. Avoid using GetTypeCode() with
8505 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
8506 TypeManager.object_type to allow building corlib.
8508 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
8510 * ecore.cs: handle System.Enum separately in LoadFromPtr().
8512 2002-07-01 Martin Baulig <martin@gnome.org>
8514 * class.cs: Make the last change actually work, we need to check
8515 whether `ifaces != null' to avoid a crash.
8517 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
8519 * class.cs: when we build structs without fields that implement
8520 interfaces, we need to add the interfaces separately, since there is
8521 no API to both set the size and add the interfaces at type creation
8524 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
8526 * expression.cs: the dimension arguments to the array constructors
8527 need to be converted if they are a long.
8529 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
8531 * class.cs: don't emit ldarg.0 if there is no parent constructor
8532 (fixes showstopper for corlib).
8534 2002-06-29 Martin Baulig <martin@gnome.org>
8536 MCS now compiles corlib on GNU/Linux :-)
8538 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
8539 ie. check for MethodImplOptions.InternalCall.
8541 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
8542 and TypeManager.attribute_type are null, so we must explicitly check
8543 whether parent is not null to find out whether it's an attribute type.
8544 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
8545 and SetBuilder, not only if the property is neither abstract nor external.
8546 This is necessary to set the MethodImplOptions on the accessor methods.
8547 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
8548 SetBuilder, see Property.Emit().
8550 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
8551 populate "System.Object", "System.ValueType" and "System.Attribute" since
8552 they've already been populated from BootCorlib_PopulateCoreTypes().
8554 2002-06-29 Martin Baulig <martin@gnome.org>
8556 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
8557 is the NullLiteral, we also need to make sure that target_type is not
8560 2002-06-29 Martin Baulig <martin@gnome.org>
8562 * rootcontext.cs (RootContext.ResolveCore): We must initialize
8563 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
8564 before calling BootstrapCorlib_ResolveDelegate ().
8566 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8568 * statement.cs: fixed build-breaker. All tests passed ok.
8570 2002-06-27 Martin Baulig <martin@gnome.org>
8572 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
8573 for System.Decimal when compiling corlib.
8575 2002-06-27 Martin Baulig <martin@gnome.org>
8577 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
8578 switch blocks which contain nothing but a default clause.
8580 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
8582 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
8584 2002-06-27 Martin Baulig <martin@gnome.org>
8586 * ecore.cs (PropertyExpr.PropertyExpr): Call
8587 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
8589 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
8590 is already a TypeBuilder.
8592 2002-06-27 Martin Baulig <martin@gnome.org>
8594 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
8595 `target_type == TypeManager.array_type', not IsAssignableFrom() in
8596 the "from an array-type to System.Array" case. This makes it work
8597 when compiling corlib.
8599 2002-06-27 Martin Baulig <martin@gnome.org>
8601 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
8602 non-static PropertyExpr, set its InstanceExpression. This makes
8603 the `ICollection.Count' property work in System/Array.cs.
8605 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
8607 * driver.cs: Made error handling more consistent. Errors now
8608 tracked by Report class, so many methods which used to return int
8609 now return void. Main() now prints success/failure and
8610 errors/warnings message.
8612 Renamed '--probe' compiler argument to '--expect-error'. Removed
8613 the magic number return values (123 and 124). Now, if the
8614 expected error occurs, the compiler exits with success (exit value
8615 0). If the compilation completes without seeing that particular
8616 error, the compiler exits with failure (exit value 1). The
8617 makefile in mcs/errors has been changed to handle the new behaviour.
8619 * report.cs: Made 'expected error' number a property and renamed
8620 it from 'Probe' to 'ExpectedError'.
8622 * genericparser.cs: Removed error handling support, since it is
8623 now all done by Report class.
8625 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
8626 class, so parse() no longer returns an int.
8628 * namespace.cs: Use Report.Error instead of GenericParser.error
8630 2002-06-22 Miguel de Icaza <miguel@ximian.com>
8632 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
8633 TypeContainer.AddOperator): At the front of the list put the
8634 explicit implementations, so they get resolved/defined first.
8636 2002-06-21 Miguel de Icaza <miguel@ximian.com>
8638 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
8639 interface type is implemented by this TypeContainer. Used during
8640 explicit interface implementation.
8642 (Property.Define, Indexer.Define, Method.Define): Validate that
8643 the given interface in the explicit implementation is one of the
8644 base classes for the containing type.
8646 Also if we are explicitly implementing an interface, but there is
8647 no match in the pending implementation table, report an error.
8649 (Property.Define): Only define the property if we are
8650 not explicitly implementing a property from an interface. Use the
8651 correct name also for those properties (the same CSC uses,
8652 although that is really not needed).
8654 (Property.Emit): Do not emit attributes for explicitly implemented
8655 properties, as there is no TypeBuilder.
8657 (Indexer.Emit): ditto.
8659 Hiding then means that we do not really *implement* a pending
8660 implementation, which makes code fail.
8662 2002-06-22 Martin Baulig <martin@gnome.org>
8664 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
8665 the return value of Object.GetType(). [FIXME: we need to do this whenever
8666 we get a type back from the reflection library].
8668 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
8670 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
8672 2002-06-20 Miguel de Icaza <miguel@ximian.com>
8674 * attribute.cs: Return null if we can not look up the type.
8676 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
8677 the interface types found.
8679 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
8680 interface types found.
8682 * typemanager.cs (GetInterfaces): Make this routine returns alll
8683 the interfaces and work around the lame differences between
8684 System.Type and System.Reflection.Emit.TypeBuilder in the results
8685 result for GetInterfaces.
8687 (ExpandInterfaces): Given an array of interface types, expand and
8688 eliminate repeated ocurrences of an interface. This expands in
8689 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
8692 2002-06-21 Martin Baulig <martin@gnome.org>
8694 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
8697 2002-06-21 Martin Baulig <martin@gnome.org>
8699 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
8700 and called with one of the core types, return the corresponding typebuilder for
8703 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
8706 2002-06-21 Martin Baulig <martin@gnome.org>
8708 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
8709 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
8710 (Expression.ConvertReferenceExplicit): Likewise.
8712 * expression.cs (ElementAccess.DoResolve): Likewise.
8713 (ElementAccess.DoResolveLValue): Likewise.
8715 2002-06-10 Martin Baulig <martin@gnome.org>
8717 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
8718 add the "value" parameter to the parameter list.
8720 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
8723 2002-06-19 Miguel de Icaza <miguel@ximian.com>
8725 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
8726 the argument to an int, uint, long or ulong, per the spec. Also
8727 catch negative constants in array creation.
8729 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
8731 * class.cs: do not allow the same interface to appear twice in
8732 the definition list.
8734 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
8736 * ecore.cs: don't use ldlen with System.Array.
8738 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
8740 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
8742 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
8744 * modifiers.cs: produce correct field attributes for protected
8745 internal. Easy fix so miguel can work on ther harder stuff:-)
8747 2002-06-18 Miguel de Icaza <miguel@ximian.com>
8749 * pending.cs: New file. Move the code from class.cs here.
8750 Support clearning the pending flag for all methods (when not doing
8751 explicit interface implementation).
8753 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
8755 * rootcontext.cs: added a couple more types needed to bootstrap.
8757 2002-06-17 Miguel de Icaza <miguel@ximian.com>
8759 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
8760 constructor in the type, instead of any constructor in the type
8761 hierarchy. Thanks to Paolo for finding this bug (it showed up as
8762 a bug in the Mono runtime when applying the params attribute).
8764 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
8765 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
8767 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
8769 * expression.cs (Unary.ResolveOperator): Use TypeManager
8770 to resolve the type.
8772 2002-06-13 Ravi Pratap <ravi@ximian.com>
8774 * cs-parser.jay (enum_member_declaration): Pass in the attributes
8777 * enum.cs (AddEnumMember): Add support to store the attributes associated
8778 with each member too.
8780 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
8781 field builders too - this takes care of the enum member case.
8783 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
8785 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
8786 address-of operator on both value types and pointers.
8788 2002-06-10 Martin Baulig <martin@gnome.org>
8790 * interface.cs (Interface.PopulateIndexer): Add the indexer's
8791 PropertyBuilder to the `property_builders' list.
8793 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
8794 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
8795 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
8796 find any indexers which are inherited from an interface.
8798 2002-06-09 Martin Baulig <martin@gnome.org>
8800 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
8801 the same type as the constant if necessary. There's also a test-130.cs
8804 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
8806 * typemanager.cs (TypeManager.ChangeType): Previously known as
8807 Enum.ChangeEnumType().
8809 2002-06-09 Martin Baulig <martin@gnome.org>
8811 * expression.cs (Cast.TryReduce): Added support for consts.
8813 2002-06-08 Ravi Pratap <ravi@ximian.com>
8815 * class.cs (Accessor): Hold attributes information so we can pass
8818 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
8819 Modify to pass in attributes attached to the methods.
8821 (add_accessor_declaration, remove_accessor_declaration): Ditto.
8823 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
8824 to handle the Accessor kind :-)
8826 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
8828 2002-06-08 Martin Baulig <martin@gnome.org>
8830 * expression.cs (Unary.TryReduceNegative): Added support for
8833 2002-06-08 Martin Baulig <martin@gnome.org>
8835 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
8836 name can't be found in the `defined_names' - the caller will do a
8837 MemberLookup in this case and thus find methods in System.Enum
8838 such as Enum.IsDefined().
8840 2002-06-08 Martin Baulig <martin@gnome.org>
8842 * enum.cs (Enum.ChangeEnumType): This is a custom version of
8843 Convert.ChangeType() which works with TypeBuilder created types.
8844 (Enum.LookupEnumValue, Enum.Define): Use it here.
8846 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
8847 `TypeBuilder.BaseType != null' check.
8848 (TypeContainer.FindMembers): Only lookup parent members if we
8849 actually have a parent.
8850 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
8851 (ConstructorInitializer.Resolve): Likewise.
8853 * interface.cs (Interface.FindMembers): Added
8854 `TypeBuilder.BaseType != null' check.
8856 * rootcontext.cs (RootContext.ResolveCore): Added
8857 "System.Runtime.CompilerServices.IndexerNameAttribute" to
8858 classes_second_stage.
8860 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
8861 debug_type and trace_type when compiling with --nostdlib.
8863 2002-06-07 Martin Baulig <martin@gnome.org>
8865 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
8866 (AddField): Set it to true when adding a non-static field.
8867 (DefineType): Use `have_nonstatic_fields' to find out whether we
8868 have non-static fields, not `Fields != null'.
8870 2002-06-02 Miguel de Icaza <miguel@ximian.com>
8872 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
8873 dereferencing a null on the static-field code path)
8875 2002-05-30 Martin Baulig <martin@gnome.org>
8877 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
8878 to take command line arguments. Use reflection to call the new
8879 custom `Initialize' function on the symbol writer and pass it the
8880 command line arguments.
8882 * driver.cs (--debug-args): New command line argument to pass command
8883 line arguments to the symbol writer.
8885 2002-05-28 Miguel de Icaza <miguel@ximian.com>
8887 * assign.cs (DoResolve): Forgot to do the implicit conversion to
8888 the target type for indexers and properties. Thanks to Joe for
8891 2002-05-27 Miguel de Icaza <miguel@ximian.com>
8893 * typemanager.cs (MethodFlags): returns the method flags
8894 (Obsolete/ShouldIgnore) that control warning emission and whether
8895 the invocation should be made, or ignored.
8897 * expression.cs (Invocation.Emit): Remove previous hack, we should
8898 not do this on matching a base type, we should do this based on an attribute
8900 Only emit calls to System.Diagnostics.Debug and
8901 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
8902 on the command line.
8904 * rootcontext.cs: Global settings for tracing and debugging.
8906 * cs-tokenizer.cs (define): New utility function to track
8907 defines. Set the global settings for TRACE and DEBUG if found.
8909 2002-05-25 Ravi Pratap <ravi@ximian.com>
8911 * interface.cs (Populate*): Pass in the TypeContainer as well as
8912 the DeclSpace as parameters so that we can create EmitContexts and
8913 then use that to apply attributes etc.
8915 (PopulateMethod, PopulateEvent, PopulateProperty)
8916 (PopulateIndexer): Apply attributes everywhere.
8918 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
8921 (ApplyAttributes): Update accordingly.
8923 We now apply interface attributes for all members too.
8925 2002-05-26 Miguel de Icaza <miguel@ximian.com>
8927 * class.cs (Indexer.Define); Correctly check if we are explicit
8928 implementation (instead of checking the Name for a ".", we
8929 directly look up if the InterfaceType was specified).
8931 Delay the creation of the PropertyBuilder.
8933 Only create the PropertyBuilder if we are not an explicit
8934 interface implementation. This means that explicit interface
8935 implementation members do not participate in regular function
8936 lookups, and hence fixes another major ambiguity problem in
8937 overload resolution (that was the visible effect).
8939 (DefineMethod): Return whether we are doing an interface
8942 * typemanager.cs: Temporary hack until we get attributes in
8943 interfaces (Ravi is working on that) and we get IndexerName
8944 support in interfaces.
8946 * interface.cs: Register the indexers as properties.
8948 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
8949 warning, I have verified that this is a bug in the .NET runtime
8950 (JavaScript suffers of the same problem).
8952 * typemanager.cs (MemberLookup): When looking up members for
8953 interfaces, the parent of an interface is the implicit
8954 System.Object (so we succeed in searches of Object methods in an
8955 interface method invocation. Example: IEnumerable x; x.ToString
8958 2002-05-25 Miguel de Icaza <miguel@ximian.com>
8960 * class.cs (Event): Events should also register if they do
8961 implement the methods that an interface requires.
8963 * typemanager.cs (MemberLookup); use the new GetInterfaces
8966 (GetInterfaces): The code used to lookup interfaces for a type is
8967 used in more than one place, factor it here.
8969 * driver.cs: Track the errors at the bottom of the file, we kept
8972 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
8973 instance if the method we are calling is static!
8975 2002-05-24 Miguel de Icaza <miguel@ximian.com>
8977 * attribute.cs (ApplyAttributes): Make this function filter out
8978 the IndexerName attribute (as that attribute in reality is never
8979 applied) and return the string constant for the IndexerName
8982 * class.cs (TypeContainer.Emit): Validate that all the indexers
8983 have the same IndexerName attribute, and if so, set the
8984 DefaultName attribute on the class.
8986 * typemanager.cs: The return value might contain other stuff (not
8987 only methods). For instance, consider a method with an "Item"
8988 property and an Item method.
8990 * class.cs: If there is a problem with the parameter types,
8993 2002-05-24 Ravi Pratap <ravi@ximian.com>
8995 * ecore.cs (ImplicitConversionExists): Wrapper function which also
8996 looks at user defined conversion after making a call to
8997 StandardConversionExists - we need this for overload resolution.
8999 * expression.cs : Update accordingly the various method calls.
9001 This fixes 2 bugs filed against implicit user defined conversions
9003 2002-05-22 Miguel de Icaza <miguel@ximian.com>
9005 * statement.cs: Track the result of the assignment.
9007 2002-05-21 Miguel de Icaza <miguel@ximian.com>
9009 * expression.cs (MemberAccess): Improved error reporting for
9010 inaccessible members.
9012 2002-05-22 Martin Baulig <martin@gnome.org>
9014 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
9015 itself with debugging support.
9017 2002-05-22 Martin Baulig <martin@gnome.org>
9019 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
9020 Removed, this isn't needed anymore.
9022 2002-05-20 Martin Baulig <martin@gnome.org>
9024 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
9025 be underlying type for an enum.
9027 2002-05-20 Miguel de Icaza <miguel@ximian.com>
9029 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
9030 that splits out the loading of just the core types.
9032 * rootcontext.cs (ResolveCore): Split the struct resolution in
9033 two, so we can load the enumeration underlying types before any
9036 * expression.cs (Is): Bandaid until we fix properly Switch (see
9037 bug #24985 for details).
9039 * typemanager.cs (ImplementsInterface): The hashtable will contain
9040 a null if there are no interfaces implemented.
9042 2002-05-18 Miguel de Icaza <miguel@ximian.com>
9044 * cs-parser.jay (indexer_declarator): It is fine to have array
9047 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9049 * typemanager.cs: (RegisterBuilder): New function used to register
9050 TypeBuilders that implement interfaces. Since
9051 TypeBuilder.GetInterfaces (as usual) does not work with lame
9053 (AddUserType): register interfaces.
9055 (ImplementsInterface): Use the builder_to_ifaces hash if we are
9056 dealing with TypeBuilder. Also, arrays are showing up as
9057 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
9058 methods can not be invoked on them!
9060 * ecore.cs (ExplicitReferenceConversionExists): Made public.
9061 (ImplicitReferenceConversionExists): Split out from
9062 StandardConversionExists.
9064 * expression.cs (As): We were only implementing one of the three
9065 cases for the as operator. We now implement them all.
9066 (Is): Implement the various other cases for Is as well.
9068 * typemanager.cs (CACHE): New define used to control if we want or
9069 not the FindMembers cache. Seems to have a negative impact on
9070 performance currently
9072 (MemberLookup): Nested types have full acess to
9073 enclosing type members
9075 Remove code that coped with instance/static returns for events, we
9076 now catch this in RealFindMembers.
9078 (RealFindMembers): only perform static lookup if the instance
9079 lookup did not return a type or an event.
9081 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9083 * assign.cs (CompoundAssign): We pass more semantic information
9084 now to Compound Assignments than we did before: now we have all
9085 the information at hand, and now we resolve the target *before* we
9086 do the expression expansion, which allows the "CacheValue" method
9087 to have the effect we intended (before, a [x] += 1 would generate
9088 two differen ArrayAccess expressions from the ElementAccess,
9089 during the resolution process).
9091 (CompoundAssign.DoResolve): Resolve target and original_source here.
9093 2002-05-16 Miguel de Icaza <miguel@ximian.com>
9095 * expression.cs (ArrayAccess): dropped debugging information.
9097 * typemanager.cs: Small bug fix: I was always returning i_members,
9098 instead of one of i_members or s_members (depending on which had
9101 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
9102 method is invoked before any code generation takes place, and it
9103 is a mechanism to inform that the expression will be invoked more
9104 than once, and that the method should use temporary values to
9105 avoid having side effects
9107 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
9109 * ecore.cs (Expression.CacheTemporaries): Provide empty default
9112 * expression.cs (Indirection, ArrayAccess): Add support for
9113 CacheTemporaries in these two bad boys.
9115 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
9117 (StoreFromPtr): Handle stobj as well.
9119 * expression.cs (UnaryMutator): Share more code.
9121 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
9122 down: I was not tracking the Filter function as well, which
9123 was affecting the results of the cache.
9125 2002-05-15 Miguel de Icaza <miguel@ximian.com>
9127 * attribute.cs: Remove the hack to handle the CharSet property on
9130 2002-05-14 Miguel de Icaza <miguel@ximian.com>
9132 * attribute.cs (DoResolve): More uglyness, we now only try to
9133 resolve the attribute partially, to extract the CharSet
9134 information (only if we are a StructLayout attribute). Otherwise
9136 (GetExtraTypeInfo): Add some code to conditionally kill in the
9137 future this. I am more and more convinced that the .NET
9138 framework has special code to handle the attribute setting on
9141 * expression.cs (IsParamsMethodApplicable): Revert my previous
9142 foreach change here, it was wrong.
9144 2002-05-13 Miguel de Icaza <miguel@ximian.com>
9146 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
9147 (pp_expr): do not abort on unknown input, just return.
9148 (eval): abort if there are pending chars.
9150 * attribute.cs (Attribute.Resolve): Positional parameters are
9151 optional. Deal with that case.
9153 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
9154 the Ansi/Unicode/Auto information for the type.
9156 (TypeContainer.DefineType): instantiate the EmitContext here, as
9157 we will be using it during the type definition (to resolve
9158 attributes) and during the emit phase.
9160 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
9161 to pull type information out of the attributes
9163 (Attribute.Resolve): track the constructor builder, and allow for
9164 multiple invocations (structs and classes will use this).
9166 * ecore.cs (MemberLookupFinal): new version with all the
9167 parameters customizable.
9169 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
9170 constructors. Return if the result value is null (as the error
9171 would have been flagged already by MemberLookupFinal)
9173 Do not allow instances of abstract classes or interfaces to be
9176 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
9177 We have to compare the assembly property here when dealing with
9178 FamANDAssem and Assembly access modifiers, because we might be
9179 creating an assembly from *modules* (that means that we are not
9180 getting TypeBuilders for types defined in other modules that are
9181 part of this assembly).
9183 (Method.Emit): If the method is marked abstract and has a body,
9186 (TypeContainer.DefineMembers): If both the defined member and the
9187 parent name match are methods, then do not emit any warnings: let
9188 the Method.Define routine take care of flagging warnings. But if
9189 there is a mismatch (method overrides something else, or method is
9190 overriwritten by something, then emit warning).
9192 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
9193 set to null, this means `do not check for the return type on the
9196 (Method.Define): set the return type for the method signature to
9197 null, so that we get methods with the same name and parameters and
9198 different return types. This is used to flag warning 114 (you are
9199 hiding a method, and you probably want to use the new/override
9202 * typemanager.cs (MemberLookup): Implemented proper access
9203 control, closing a long standing set of bug reports. The problem
9204 was that the Framework only has two bits: Public and NonPublic,
9205 and NonPublic includes private and protected methods, but we need
9206 to enforce the FamANDAssem, FamOrAssem and Family.
9208 2002-05-11 Miguel de Icaza <miguel@ximian.com>
9210 * statement.cs (GotoCase): Return true: Ammounts to giving up
9211 knowledge on whether we return or not, and letting the other case
9212 be responsible for it.
9214 2002-05-10 Miguel de Icaza <miguel@ximian.com>
9216 * driver.cs: Do not load directories for each file processed, only
9217 do it if there is a pattern.
9219 * ecore.cs: Report readonly assigns here as well, as we might have
9220 been resolved only by MemberAccess.
9222 (SimpleName.SimpleNameResolve): Also be useful for LValue
9223 resolution. We need this to propagate assign to local readonly variables
9225 * typemanager.cs: Use a ptrhashtable for the criteria, because we
9226 do not want to reuse potential criteria memory.
9228 * class.cs (MyEventBuilder): Set reflected_type;
9230 * ecore.cs (Constantify): Added support for constifying bools.
9232 (RootContext.LookupType): Added a cache for values looked up in
9233 the declaration space.
9235 * typemanager.cs (FindMembers): Now is a front-end to
9236 RealFindMembers, and provides a two-level hashtable-based cache to
9239 15% performance improvement: from 22.5 to 19.2 seconds.
9241 * expression.cs (IsParamsMethodApplicable): use foreach.
9242 (Invocation.DoResolve): ditto.
9243 (New.DoResolve): ditto.
9244 (ArrayCreation.DoResolve): ditto.
9246 * ecore.cs (FindMostEncompassingType): use foreach.
9248 * delegate.cs (NewDelegate.DoResolve): Use foreach
9250 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
9251 (RemoveMethods): use foreach.
9253 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
9254 nested foreach statements instead of for, and also break out of
9255 the inner loop once a match is found.
9257 (Invocation.OverloadResolve): Use foreach, simplify the code.
9259 2002-05-08 Miguel de Icaza <miguel@ximian.com>
9261 * cfold.cs (BinaryFold): During an enumeration evaluation context,
9262 we actually unwrap the expression to allow for extra information
9265 * expression.cs: Use Shr_Un on unsigned operations.
9267 2002-05-08 Ravi Pratap <ravi@ximian.com>
9269 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
9270 applicable operators was not being considered correctly. This closes
9271 the bug Miguel reported.
9273 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
9275 * attribute.cs: check that the type derives from System.Attribute
9276 and report the correct error in that case (moved the duplicate code to
9277 its own method, too).
9279 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
9281 * attribute.cs: lookup attribute type name as the spec says: first the
9282 bare attribute name and then name + "Attribute" (nant compiles with
9283 mcs after this fix).
9285 2002-05-07 Miguel de Icaza <miguel@ximian.com>
9287 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
9288 Because of the way we parse things, we should try to see if a
9289 UIntConstant can fit in an integer.
9291 2002-05-07 Ravi Pratap <ravi@ximian.com>
9293 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
9294 when we are in an explicit context.
9296 (ConvertReferenceExplicit): When converting from Iface type S to Class
9297 T make sure the rules are implemented as an OR.
9299 * parameter.cs (ParameterType): Make it a property for now although the
9300 purpose really isn't anything immediate.
9302 * expression.cs (Is*Applicable): Do better checking on the parameter type
9303 of a ref/out parameter. The ones from the system assemblies are already
9304 marked with the correct type so we don't need to do any correction.
9306 * ecore.cs (StandardConversionExists): Conversion from Interface types to
9307 the object type is standard too so include that.
9309 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9311 * ecore.cs (StandardConversionExists): Augment with missing code:
9312 deal with IntConstant, LongConstants and Enumerations.
9314 * assign.cs: Report the error, instead of failing silently
9316 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
9317 typecontainer that they are declared, because the
9318 typecontainer/namespace will have the list of using clauses that
9321 Assembly Attributes were escaping the normal registration
9324 (EmitCode): Apply attributes within an EmitContext that represents
9325 the container they were declared on.
9327 * cs-parser.jay: Track bases for structs. How did I get this wrong?
9329 2002-05-06 Ravi Pratap <ravi@ximian.com>
9331 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
9332 Revamp completely - make much cleaner as we now operate only
9335 (FindMostSpecificSource, FindMostSpecificTarget): New methods
9336 to implement the logic detailed in the spec more correctly.
9338 (UserDefinedConversion): Update accordingly.
9340 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9342 * statement.cs: Return flow analysis information up.
9344 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
9347 (token): Do not consume an extra character before calling
9350 2002-05-06 Piers Haken <piersh@friskit.com>
9352 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
9354 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9356 * class.cs (Constructor.Emit): Set the IsStatic flag in the
9357 EmitContext during the instance constructor initializer
9358 resolution, to stop access to instance variables.
9360 This is mandated by the spec, last paragraph of the `constructor
9361 initializers' section.
9363 2002-05-05 Miguel de Icaza <miguel@ximian.com>
9365 * cs-parser.jay, class.cs (Accessor): new class used to represent
9366 an accessor (get or set). In the past we used `null' to represent
9367 a missing accessor. But this is ambiguous because there was no
9368 way to tell in abstract indexers/properties if one of them was
9371 Now there is a way of addressing that.
9373 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
9374 instead of FindMembers.
9376 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
9377 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
9379 * attribute.cs: Treat indexers and properties as the same in terms
9380 of applying attributes
9382 * ecore.cs (FindMostEncompassedType): Use statically initialized
9383 EmptyExpressions()s like we do elsewhere to avoid creating useless
9384 objects (and we take this out of the tight loop).
9386 (GetConversionOperators): Move the code to extract the actual
9387 operators to a separate routine to clean things up.
9389 2002-05-04 Miguel de Icaza <miguel@ximian.com>
9391 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
9392 events are always registered FieldBuilders.
9394 * class.cs (FieldBase): New class shared by Fields
9396 * delegate.cs: If we are a toplevel delegate, use our full name.
9397 If we are a nested delegate, then only use our tail name.
9399 2002-05-02 Ravi Pratap <ravi@ximian.com>
9401 * expression.cs (IsApplicable): Ensure that we add the "&" to
9402 ref/out types before comparing it with the type of the argument.
9404 (IsParamsMethodApplicable): Ditto.
9406 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
9409 * delegate.cs : Handle the case when we have more than one applicable
9410 method. Flag an error only when we finish checking all.
9412 2002-05-02 Miguel de Icaza <miguel@ximian.com>
9414 * expression.cs: Add support for boolean static initializers.
9416 2002-05-01 Miguel de Icaza <miguel@ximian.com>
9418 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
9420 * parameter.cs (ComputeParameterTypes,
9421 ComputeAndDefineParameterTypes): Better error handling: now we
9422 clear the `types' cache if we fail during any of the type lookups.
9423 We also return the status code correctly to our caller
9425 * delegate.cs: If we fail to define a delegate, abort the extra
9428 * expression.cs (Binary.ResolveOperator): for
9429 operator==(object,object) and operator !=(object, object) we also
9430 have to verify that there is an implicit conversion from one to
9433 (ArrayAccess.DoResolve): Array Access can operate on
9436 2002-04-30 Miguel de Icaza <miguel@ximian.com>
9438 * assign.cs (CompoundAssign): A new class used as a "flag" that
9439 the assignment actually is happening as part of a compound
9440 assignment operator.
9442 During compound assignment, a few new rules exist to enable things
9449 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
9450 to the type of x) if y is implicitly convertible to the type of x,
9451 and the operator is a builtin operator and the return type of the
9452 operator is explicitly convertible to the type of x.
9454 * rootcontext.cs: Reset warning level to 2. 4 catches various
9455 "interesting" features in mcs, we must clean this up at some
9456 point, but currently am trying to kill other bugs ;-)
9458 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
9459 in container classes as well.
9461 * expression.cs (Binary.ResolveOperator): Handle string case
9462 before anything else (as operator overloading does emit an error
9463 before doing anything else).
9465 This code could go away when we move to a table driven model, but
9466 i could not come up with a good plan last night.
9468 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
9470 * typemanager.cs (CSharpName): reimplementation using regex.
9471 * class.cs: added null check for fields in Emit
9472 * rootcontext.cs: set warninglevel to 4
9474 2002-04-29 Miguel de Icaza <miguel@ximian.com>
9476 * typemanager.cs (CSharpName): reimplemented with Lupus
9479 2002-04-28 Miguel de Icaza <miguel@ximian.com>
9481 * statement.cs (If): correclty implement Resolve, because we were
9482 not catching sem errors in there. The same process is needed
9484 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
9487 (Statement.Warning_DeadCodeFound): Factorize code.
9488 (While): Report dead code here too.
9490 (Statement): Added Resolve virtual method to allow
9491 for resolution split from the emit code.
9493 2002-04-26 Miguel de Icaza <miguel@ximian.com>
9495 * statement.cs (EmitBoolExpression): No longer try to resolve the
9497 (MakeBoolean): New utility function that resolve, implicitly
9498 converts to boolean and tags the expression.
9501 (If, Do): Implement dead code elimination.
9502 (While): Implement loop inversion
9504 (Do, While, For, If): Resolve the expression prior to calling our
9507 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
9510 - added method Report28 (warning: program has more than one entry point)
9511 - added method IsEntryPoint, implements paragraph 10.1 of the spec
9512 - modified method Method.Define, the part at the end of the method
9514 * rootcontext.cs: added static public Location EntryPointLocation;
9516 * ../errors/cs0028.cs : Add test case for the above warning.
9519 - modified method CSharpName to allow arrays of primitive type to
9520 be printed nicely (e.g. instead of System.Int32[][] it now prints
9522 - added method CSharpSignature: returns the signature of a method
9523 in string format to be used in reporting errors, warnings, etc.
9525 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
9528 2002-04-26 Ravi Pratap <ravi@ximian.com>
9530 * delegate.cs (Define): Fix extremely silly bug where I was
9531 setting the type of the 'object' parameter of the BeginInvoke
9532 method to System.IAsyncResult instead of System.Object ;-)
9534 2002-04-26 Miguel de Icaza <miguel@ximian.com>
9536 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
9539 (Constructor.Emit): return if we fail to initialize the
9540 constructor. Another door closed!
9542 * expression.cs (New.DoResolve): Improve error message (from -6 to
9543 1501). Use DeclaredOnly lookup to find the exact constructor.
9545 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
9546 loop. This is useful.
9548 * cs-parser.jay: Adjust the default parameters so that destructors
9549 have the proper signature.
9551 2002-04-26 Martin Baulig <martin@gnome.org>
9553 * driver.cs (LoadAssembly): If `assembly' contains any characters
9554 which are only valid in path names and not in assembly names
9555 (currently slash, backslash and point), use Assembly.LoadFrom ()
9556 instead of Assembly.Load () on the `assembly' (before iteration
9557 over the link_paths).
9559 2002-04-26 Martin Baulig <martin@gnome.org>
9561 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
9563 2002-04-25 Miguel de Icaza <miguel@ximian.com>
9565 * class.cs (Property): use the new typemanager.MemberLookup
9567 (TypeContainer.MemberLookup): Implement using the
9568 TypeManager.MemberLookup now.
9570 * typemanager.cs: Make MemberLookup a function of the TypeManager,
9571 and return MemberInfos, so that these can be used without an
9572 EmitContext (what we had before).
9574 2002-04-24 Miguel de Icaza <miguel@ximian.com>
9576 * expression.cs: Fix the case where the argument to params if the
9577 type of the params. I omitted handling this before. Fixed
9579 2002-04-22 Miguel de Icaza <miguel@ximian.com>
9581 * driver.cs: Call BootCorlib_PopulateCoreType
9583 * class.cs (Property.CheckBase): Check for properties only, not
9586 * interface.cs: Temporary hack: try/catch around the
9587 CustomAttributeBuilder, because I am getting an exception that I
9590 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
9591 types whose definitions are required to be there (attributes are
9592 defined before standard types).
9594 Compute definitions as we boot the various types, as they are used
9595 immediately (value_type class will need object_type, but if we do
9596 not initialize object_type, we will pass a null, which will let
9597 the runtime pick the System.Object from the existing corlib, which
9598 is not what we want).
9600 2002-04-22 Patrik Torstensson <totte@labs2.com>
9602 * cs-tokenizer.cs: fixed a number of trim() issues.
9604 2002-04-22 Ravi Pratap <ravi@ximian.com>
9606 * expression.cs (Argument.Type): Ensure that we return the correct
9607 type when we have out or ref parameters [in which case we
9610 2002-04-22 Miguel de Icaza <miguel@ximian.com>
9612 * class.cs (Property, Indexer): Allow extern modifier in there.
9614 * typemanager.cs (InitBaseTypes): Initializes object_type and
9615 value_type, since those will be used early on during the bootstrap
9616 process to compile corlib.
9618 (InitCoreTypes): Move code from here to InitBaseTypes.
9620 2002-04-21 Miguel de Icaza <miguel@ximian.com>
9622 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
9623 single-dimension arrays as using the ldlen opcode.
9625 Daniel Lewis discovered this optimization.
9627 * typemanager.cs: Add signature for System.Array::get_Length
9629 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9631 * statement.cs: report the error when the foreach does not apply to an
9632 array nor a collection.
9634 2002-04-19 Miguel de Icaza <miguel@ximian.com>
9636 * expression.cs: Add implicit conversions to the operator ~.
9638 * constant.cs (DecimalConstant.Emit): Emit decimal value.
9640 * typemanager.cs: Locate the decimal constructor.
9642 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9644 * attribute.cs: use the new property of TypeOf.
9645 * expression.cs: added 'get' property around typearg.
9647 These changes fix a build breaker reported by NickD. Is this the
9648 correct way to fix? If not, please, revert my changes and make it
9651 2002-04-17 Miguel de Icaza <miguel@ximian.com>
9653 * attribute.cs: Add support for typeof in attribute invocations.
9654 I am not sure that this is right though.
9656 2002-04-14 Duncan Mak <duncan@ximian.com>
9658 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
9659 Binary.Operator.Division case.
9661 2002-04-13 Ravi Pratap <ravi@ximian.com>
9663 * class.cs (DefineType): Ensure that we do a proper check on
9664 attribute types and also register it with the TypeManager.
9666 (TypeContainer.Targets): The default for attribute types is
9667 AttributeTargets.All.
9669 * attribute.cs (ApplyAttributes): Registering the attribute type
9670 is done elsewhere, not when we discover we have a Usage attribute.
9672 2002-04-12 Ravi Pratap <ravi@ximian.com>
9674 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
9675 and get rid of is_delegate parameter.
9677 * everywhere : update.
9679 2002-04-12 Ravi Pratap <ravi@ximian.com>
9681 * cs-parser.jay (compilation_unit): Revamp completely to use
9682 some new ideas that I got from Rhys' grammar to solve the problems
9683 with assembly level attributes.
9685 (outer_declaration): New grammar production.
9687 (attribute_sections): Add.
9689 (opt_attributes): Base on attribute_sections
9691 (namespace_declaration): Allow opt_attributes to tackle the case
9692 when we have assembly level attributes - we are clever in this
9695 * attribute.cs (ApplyAttributes): Do not worry about assembly
9696 attributes in the non-global context.
9698 * rootcontext.cs (AddGlobalAttributes): Go back to using this
9699 instead of SetGlobalAttributes.
9701 * class.cs, rootcontext.cs : Ensure we define and generate
9702 attribute types before anything else.
9704 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
9705 and flag the new error -20 for the case when the attribute type
9706 does not have valid targets specified. csc does not catch this.
9708 * ../errors/errors.txt : update for error # -20
9710 2002-04-11 Ravi Pratap <ravi@ximian.com>
9712 * support.cs (InternalParameters.ParameterModifier): Do some null
9713 checking and return sane values.
9715 * class.cs (Method.Define): If we are a PInvoke method, ensure
9716 that we are static and extern. Report error # 601
9718 * ../errors/cs0601.cs : Add test case for the above error.
9720 2002-04-07 Ravi Pratap <ravi@ximian.com>
9722 * rootcontext.cs (attribute_types): We need to keep type of
9723 all attribute types separately and emit code for them first.
9725 (RegisterAttribute) : Implement.
9727 * class.cs (DefineType): Check if the current Type is a custom
9728 attribute type and register it accordingly.
9730 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
9731 adding the first attribute twice and rename to
9733 (SetGlobalAttributes): this.
9735 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
9738 * attribute.cs (ApplyAttributes): Take an additional argument telling us
9739 if we are processing global arguments. Hmm, I am unsure of this.
9741 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9743 * expression.cs: added static array of strings to avoid calling
9744 Enum.ToString () for Operator in Binary. Significant recover of
9747 2002-04-10 Miguel de Icaza <miguel@ximian.com>
9749 * class.cs (FindMembers): Allow the Builders of the various
9750 members to be null. If they are skip them. This only happens
9751 during the PInvoke declaration.
9753 2002-04-09 Miguel de Icaza <miguel@ximian.com>
9755 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
9756 failure, so we do not keep going afterwards.
9758 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
9759 wanted to pass `false' as the `is_delegate' argument. If this is
9760 the case, why not use delegate_type == null to mean `is_delegate =
9761 false' and anything else as is_delegate = true.
9763 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
9765 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
9766 code for the section, not the beginning of the tests.
9768 2002-04-08 Miguel de Icaza <miguel@ximian.com>
9770 * cfold.cs: Handle operator + (Enum x, Underlying x)
9772 * expression.cs (Binary): same. Warn about errors where we have
9773 Enum/Enum in operator + as well.
9775 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
9778 - added support for switch(bool)
9779 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
9780 - add TableSwitchEmit() to handle table-based switch statements
9782 2002-04-05 Ravi Pratap <ravi@ximian.com>
9784 * expression.cs (Invocation.OverloadResolve): Factor out code which
9785 does parameter compatibility checking with arguments so that we can
9786 re-use the code even from Delegate.VerifyApplicability
9788 (VerifyArgumentsCompat): Move above code here.
9790 * delegate.cs (VerifyApplicability): Get rid of duplicate code
9791 and instead make a call to the above method.
9793 2002-03-31 Ravi Pratap <ravi@ximian.com>
9795 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
9796 We use it to keep track of classes which are attribute types.
9798 2002-04-02 Miguel de Icaza <miguel@ximian.com>
9800 * delegate.cs (Delegate.Define): Correctly define the types in the
9801 presence of fixed and array parameters.
9803 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
9806 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
9807 include NonPublic after the first iteration.
9809 * class.cs (Indexer.CheckBase): Only check if both parents are
9812 * cs-parser.jay (accessor_body): If empty, set to null.
9814 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
9815 same code path here to resolve constants names that we did have in
9816 MemberAccess.DoResolve. There is too much code duplicated here.
9818 2002-04-01 Miguel de Icaza <miguel@ximian.com>
9820 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
9822 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
9825 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
9826 tokens, numbers and strings.
9828 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
9831 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
9832 asyncronous parameters and the regular parameters.
9834 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
9835 specify the target directory.
9837 * expression.cs: (This.DoResolve): Simplify
9838 (As.Emit): Optimize, do not generate IsInst if the expression is
9839 always of the given type.
9841 (Is.DoResolve): Bug fix, we were reporting both always/never for
9844 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
9845 creating too many unnecessary arrays.
9847 2002-03-31 Miguel de Icaza <miguel@ximian.com>
9849 * class.cs (EmitFieldInitializer): Use Assign expression to assign
9850 fields instead of rolling our own initializer. Takes care of all
9851 implicit conversions, and drops unnecessary static checks/argument.
9853 2002-03-31 Dick Porter <dick@ximian.com>
9855 * driver.cs: use the GetDirectories() return values properly, and
9856 use "/" as path separator.
9858 2002-03-30 Miguel de Icaza <miguel@ximian.com>
9860 * expression.cs (Unary): Optimize - - expr into expr.
9861 (Binary): Optimize a + (-b) into a -b.
9863 * codegen.cs (CodeGen): Made all methods static.
9865 2002-03-29 Miguel de Icaza <miguel@ximian.com>
9869 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
9870 TypeBuilder property.
9872 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
9875 * tree.cs: Removed the various RecordXXXX, and replaced with a
9876 single RecordDecl. Removed all the accessor methods, and just
9877 left a single access point Type
9879 * enum.cs: Rename DefineEnum to DefineType.
9881 * decl.cs: New abstract method `DefineType' used to unify the
9882 Defines for Enumerations, Interfaces, TypeContainers and
9885 (FindType): Moved LookupInterfaceOrClass here. Moved the
9886 LookupBaseClasses method that used to live in class.cs and
9887 interface.cs here, and renamed to FindType.
9889 * delegate.cs: Implement DefineType. Take advantage of the
9890 refactored pattern for locating the parent builder without taking
9891 the parent_builder argument (which we know does not work if we are
9892 nested, and triggering a toplevel definition).
9894 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9896 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
9897 accessibility of a member has changed during override and report
9900 * class.cs (Method.Define, Property.Define): Only complain on
9901 overrides if the method is private, any other accessibility is
9902 fine (and since we just checked the permission is the same, we are
9905 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
9906 and elif are processed always. The other pre-processing
9907 directives are only processed if we are "taking" the path
9909 2002-03-29 Martin Baulig <martin@gnome.org>
9911 * class.cs (Method.Emit): Only emit symbolic debugging info if the
9912 current location is not Null.
9914 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
9915 a separate method so we can profile it.
9917 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
9918 `span.Seconds' are just seconds, but no minutes or hours.
9919 (MainDriver): Profile the CodeGen.SaveSymbols calls.
9921 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9923 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
9924 Remove the gratuitous set of Final:
9926 // If an interface implementation, then we can set Final.
9927 if (((flags & MethodAttributes.Abstract) == 0) &&
9928 implementing.DeclaringType.IsInterface)
9929 flags |= MethodAttributes.Final;
9931 I do not know what I was smoking when I used that.
9934 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
9935 step into fixing the name resolution issues for delegates and
9936 unifying the toplevel name resolution.
9938 2002-03-28 Martin Baulig <martin@gnome.org>
9940 * class.cs (Method.Emit): If we have a symbol writer, call its
9941 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
9942 tell it about the current method.
9944 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
9945 writer that we're going to emit the first byte of IL code for a new
9946 statement (a new source line).
9947 (EmitContext.EmitTopBlock): If we have a symbol writer, call
9948 EmitContext.Mark() before emitting any code.
9950 * location.cs (SymbolDocument): Return null when we're Null.
9952 * statement.cs (Statement): Moved the `Location loc' variable here.
9953 (Statement.EmitBoolExpression): If we have a symbol writer, call
9954 ec.Mark() before emitting any code to tell it that we're at the
9955 beginning of a new statement.
9956 (StatementExpression): Added `Location' argument to the constructor.
9957 (Block): Added public readonly variable `StartLocation' and public
9958 variable `EndLocation'. The latter is to be set using SetEndLocation().
9959 (Block): Added constructor which takes a start and end location.
9960 (Block.SetEndLocation): New method. This sets the end location.
9961 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
9962 local variables we create.
9963 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
9964 each statement and do also mark the begin and end of the block.
9966 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
9967 tell it the current lexer.Location, use Location.Null for the end of the
9969 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
9970 current block, set its end location using SetEndLocation().
9971 (statement_expression): StatementExpression constructor now takes the
9972 lexer.Location as additional argument.
9973 (for_statement, declare_local_variables): Likewise.
9974 (declare_local_variables): When creating a new implicit block, use the
9975 new Block constructor and pass it the lexer.Location.
9977 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9979 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
9980 members also on the parent interfaces recursively.
9982 2002-03-27 Miguel de Icaza <miguel@ximian.com>
9984 * report.cs: Use new formats, since Gonzalo finished the missing
9987 * expression.cs (Binary.ResolveOperator): added missing operator|
9988 operator& and operator^ for bool/bool.
9990 * cs-parser.jay: CheckDef now takes a Location argument that is
9991 used to report errors more precisly (instead of reporting the end
9992 of a definition, we try to track something which is a lot closer
9993 to the source of the problem).
9995 * cs-tokenizer.cs: Track global token use, so we can properly flag
9996 the use of #define/#undef after the first token has been seen.
9998 Also, rename the reportXXXX to Error_DescriptiveName
10000 * decl.cs (DeclSpace.IsTopLevel): Move property here from
10001 TypeContainer, so that Enum and Interface can use this too.
10003 * class.cs (TypeContainer.LookupInterfaceOrClass,
10004 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
10005 `builder' argument. Typically this was used to pass the parent
10006 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
10009 The problem is that a nested class could trigger the definition of
10010 a toplevel class, and the builder would be obviously wrong in that
10013 So we drop this argument, and we compute dynamically the
10014 TypeBuilder/ModuleBuilder (the correct information was available
10015 to us anyways from DeclSpace.Parent)
10017 * interface.cs (Interface.DefineInterface): Drop builder
10018 parameter cleanup like class.cs
10020 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
10023 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
10026 (Try.Emit): Propagate the returns value from the statement.
10028 (Return.Emit): Even if we are leavning
10030 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
10032 * modifiers.cs: Fix the computation of MethodAttributes flags.
10034 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
10036 * driver.cs: allow compilation of files that start with '/'.
10037 Add a default case when checking the argument of --target.
10039 2002-03-25 Miguel de Icaza <miguel@ximian.com>
10041 * interface.cs: Implement the same search algorithm for types in
10042 the interface code.
10044 * delegate.cs: Do not allow multiple definition.
10046 * Recovered ChangeLog that got accidentally amputated
10048 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
10050 * rootcontext.cs: Load manually enum to allow core classes to
10051 contain enumerations.
10053 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
10054 Update to new static methods in TypeManager.
10056 * typemanager.cs (GetMethod, GetConstructor): Use our
10057 implementation of FindMembers to find the members, since during
10058 corlib compilation, the types are TypeBuilders and GetMethod and
10059 GetConstructor do not work.
10061 Make all methods in TypeManager static.
10063 (InitCodeHelpers): Split the functionality from
10064 the InitCodeTypes function.
10066 * driver.cs: Call InitCodeHelpers after we have populated the
10069 * cs-parser.jay (delegate_declaration): we did not used to compute
10070 the delegate name correctly for void delegates.
10072 2002-03-24 Miguel de Icaza <miguel@ximian.com>
10074 * rootcontext.cs (RootContext): Init the interface_resolve_order
10075 and type_container_resolve_order always.
10077 (ResolveCore, BootstrapCorlib_ResolveClass,
10078 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
10079 compiler when compiling with --nostdlib
10081 * class.cs (TypeContainer.DefineType): Check that our parent is
10082 not null. This test is most important when we are bootstraping
10085 * codegen.cs: Split out the symbol writing code.
10087 2002-03-25 Martin Baulig <martin@gnome.org>
10089 * driver.cs (-g): Made -g an alias for --debug.
10091 2002-03-24 Martin Baulig <martin@gnome.org>
10093 * codegen.cs (SymbolWriter): New public variable. Returns the
10094 current symbol writer.
10095 (CodeGen): Added `bool want_debugging_support' argument to the
10096 constructor. If true, tell the ModuleBuild that we want debugging
10097 support and ask it for the ISymbolWriter.
10098 (Save): If we have a symbol writer, call it's Close() method after
10099 saving the assembly.
10101 * driver.c (--debug): New command line argument to create a
10102 debugger information file.
10104 * location.cs (SymbolDocument): New public property. Returns an
10105 ISymbolDocumentWriter object for the current source file or null
10106 if we don't have a symbol writer.
10108 2002-03-21 Miguel de Icaza <miguel@ximian.com>
10110 * driver.cs (LoadAssembly): Correctly return when all the paths
10111 have been tried and not before.
10113 * statement.cs (Switch.Emit): return the actual coverage for this
10114 statement (returns/not-returns)
10116 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
10117 switch of the statement if we are the last switch section. That
10118 kills two problems: try/catch problems (we used to emit an empty
10119 nop at the end) and switch statements where all branches would
10122 2002-03-19 Miguel de Icaza <miguel@ximian.com>
10124 * driver.cs: Add default assemblies (the equivalent to the
10125 Microsoft CSC.RSP file)
10127 * cs-tokenizer.cs: When updating `cols and setting it to zero,
10128 also update tokens_seen and set it to false.
10130 * driver.cs: Implement --recurse for Mike.
10132 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
10133 correctly splitting out the paths.
10135 2002-03-18 Miguel de Icaza <miguel@ximian.com>
10137 * interface.cs (Interface.PopulateProperty): Instead of using
10138 `parent' as the declaration space for the set parameters, use
10141 * support.cs (InternalParameters): InternalParameters constructor
10142 takes a DeclSpace instead of a TypeContainer.
10144 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
10145 types are being initialized, load the address of it before calling
10148 (New): Provide a mechanism to disable the generation of local
10149 value type temporaries when the caller will be providing us with
10150 an address to store it.
10152 (ArrayCreation.EmitDynamicInitializers): Use it.
10154 2002-03-17 Miguel de Icaza <miguel@ximian.com>
10156 * expression.cs (Invocation.EmitArguments): Only probe for array
10157 property if there is more than one argument. Sorry about that.
10159 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
10160 empty param arrays.
10162 * class.cs (Method.LabelParameters): Fix incorrect code path that
10163 prevented the `ParamArrayAttribute' from being applied to the
10166 2002-03-16 Miguel de Icaza <miguel@ximian.com>
10168 * support.cs (ReflectionParameters): Correctly compute whether the
10169 last argument is a params array. Fixes the problem with
10172 * typemanager.cs: Make the assemblies array always be non-null
10173 (empty, but non-null)
10175 * tree.cs (RecordDecl): New function that abstracts the recording
10176 of names. This reports error 101, and provides a pointer to the
10177 previous declaration. Fixes a crash in the compiler.
10179 * cs-parser.jay (constructor_declaration): Update to new grammar,
10180 and provide a constructor_body that can be empty.
10182 2002-03-15 Miguel de Icaza <miguel@ximian.com>
10184 * driver.cs: Add support for --resources.
10186 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
10187 Make all types for the various array helper methods be integer.
10189 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
10190 CheckState to ConvCast.
10192 (ConvCast): Now it takes a `checked' state argument, to avoid
10193 depending on the emit context for the conversion, and just using
10194 the resolve time setting.
10196 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
10197 instead of Invocation.EmitArguments. We do not emit the original
10198 arguments, instead we emit those which have been converted to
10199 unsigned int expressions.
10201 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
10203 * codegen.cs: ditto.
10205 * expression.cs (LocalVariableReference): Drop the use of the
10206 Store function that depended on the variable index.
10208 * statement.cs (VariableInfo): Drop the `Idx' property from this
10209 class, as this is not taking into account the indexes for
10210 temporaries tat we generate during the execution, getting the
10213 * class.cs: First emit class initializers, then call the parent
10216 * expression.cs (Binary): Fix opcode emision.
10217 (UnaryMutator.EmitCode): Support checked code generation
10219 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
10220 matches for events for both the Static and Instance scans,
10221 pointing to the same element. Fix that.
10223 2002-03-14 Miguel de Icaza <miguel@ximian.com>
10225 * rootcontext.cs (ResolveTree): Always set the
10226 interface_resolve_order, because nested interfaces will be calling
10229 * class.cs (GetInterfaceOrClass): Track the same resolution
10230 process used by TypeManager.LookupType. This fixes the nested
10231 type lookups in class declarations (separate path from
10234 (TypeContainer.DefineType): Also define nested interfaces.
10235 (TypeContainer.RegisterOrder): New public function used to
10236 register the order in which child interfaces need to be closed.
10238 Nested interfaces need to be closed after their parents have been
10241 * interface.cs (InterfaceAttr): Put all the logic for computing
10242 the interface attribute here.
10244 (DefineInterface): Register our interface order with the
10245 RootContext or with the TypeContainer depending on the case.
10247 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10249 * cs-parser.jay: rework foreach statement to work with the new
10250 changes to the policy on SimpleNames.
10252 * report.cs: support Stacktrace on warnings as well.
10254 * makefile: drop --unsafe and /unsafe from the compile.
10256 2002-03-13 Ravi Pratap <ravi@ximian.com>
10258 * ecore.cs (StandardConversionExists): Modify to take an Expression
10259 as the first parameter. Ensure we do null -> reference type conversion
10262 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
10263 temporary Expression objects.
10265 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
10267 * interface.cs: workaround bug in method overloading resolution
10268 (there is already a bugzilla bug for it).
10270 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10272 We could also solve this problem by having a separate path for
10273 performing type lookups, instead of DoResolve, we could have a
10274 ResolveType entry point, and only participating pieces of the
10275 production (simplename, deref, array) would implement this.
10277 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
10278 signal SimpleName to only resolve type names and not attempt to
10279 resolve anything else.
10281 * expression.cs (Cast): Set the flag.
10283 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
10285 * class.cs: Only report 108 if there is no `new' modifier.
10287 * cs-parser.jay: rework foreach statement to work with the new
10288 changes to the policy on SimpleNames.
10290 * report.cs: support Stacktrace on warnings as well.
10292 * makefile: drop --unsafe and /unsafe from the compile.
10294 2002-03-11 Miguel de Icaza <miguel@ximian.com>
10296 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10297 lookups here, instead of doing that at parse time. This means
10298 that our grammar will not introduce `LocalVariableReferences' as
10299 expressions at this point. That solves the problem of code like
10303 static void Main ()
10307 This is only half the fix. The full fix requires parameters to
10308 also be handled in this way.
10310 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
10311 makes the use more obvious of the DeclSpace. The
10312 ec.TypeContainer.TypeBuilder is now only used to pull the
10313 TypeBuilder for it.
10315 My theory is that I can get rid of the TypeBuilder completely from
10316 the EmitContext, and have typecasts where it is used (from
10317 DeclSpace to where it matters).
10319 The only pending problem is that the code that implements Aliases
10320 is on TypeContainer, and probably should go in DeclSpace.
10322 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10323 lookups here, instead of doing that at parse time. This means
10324 that our grammar will not introduce `LocalVariableReferences' as
10325 expressions at this point. That solves the problem of code like
10329 static void Main ()
10333 This is only half the fix. The full fix requires parameters to
10334 also be handled in this way.
10336 * class.cs (Property.DefineMethod): When implementing an interface
10337 method, set newslot, when implementing an abstract method, do not
10338 set the flag (before we tried never setting it, or always setting
10339 it, which is the difference).
10340 (Indexer.DefineMethod): same.
10341 (Method.DefineMethod): same.
10343 * ecore.cs: Only set the status used flag if we get back a Field.
10345 * attribute.cs: Temporary hack, so Paolo can keep working.
10347 2002-03-08 Ravi Pratap <ravi@ximian.com>
10349 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
10350 the unmanaged type in the case we have a MarshalAs attribute.
10352 (Resolve): Handle the case when we are parsing the special MarshalAs
10353 attribute [we need to store the unmanaged type to use later]
10355 * typemanager.cs (marshal_as_attr_type): Built in type for the
10356 MarshalAs Attribute.
10358 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
10359 on parameters and accordingly set the marshalling info.
10361 2002-03-09 Miguel de Icaza <miguel@ximian.com>
10363 * class.cs: Optimizing slightly by removing redundant code after
10364 we switched to the `NoTypes' return value.
10365 (Property.DefineMethod): use NoTypes here too.
10367 This fixes the bug I introduced in my last batch of changes.
10369 2002-03-05 Ravi Pratap <ravi@ximian.com>
10371 * tree.cs (RecordEnum): Add. We now keep track of enums too.
10373 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
10374 Enums since those are types too.
10376 * cs-parser.jay (enum_declaration): Record enums as we parse them.
10378 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
10379 thanks to a call during the lookup process.
10381 2002-03-07 Miguel de Icaza <miguel@ximian.com>
10383 * statement.cs (Foreach): Lots of work to accomodate a particular
10384 kind of foreach statement that I had not kept in mind. It is
10385 possible to have foreachs on classes that provide a GetEnumerator
10386 method that return objects that implement the "pattern" for using
10387 a foreach, there is no need to support GetEnumerator
10390 This is needed to compile nant.
10392 * decl.cs: Only report 114 if the member is not `Finalize' and if
10393 the warning level is at least 2.
10395 * class.cs: Moved the compare function from Method to
10398 (MethodSignature.InheritableMemberSignatureCompare): Add new
10399 filter function that is used to extract inheritable methods from a
10402 (Method.Define): Use the new `inheritable_method_signature_filter'
10405 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
10408 2002-03-06 Miguel de Icaza <miguel@ximian.com>
10410 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
10412 * cs-parser.jay: Add opt_semicolon to the interface declaration.
10414 * expression.cs: Pass location information to
10415 ConvertImplicitStandard.
10417 * class.cs: Added debugging code to track return values from
10420 2002-03-05 Miguel de Icaza <miguel@ximian.com>
10422 * expression.cs (Is.DoResolve): If either side of the `is' is an
10423 interface, do not flag the warning.
10425 * ecore.cs (ImplicitReferenceConversion): We need a separate test
10428 * report.cs: Allow for --fatal to be used with --probe.
10430 * typemanager.cs (NoTypes): Move the definition for the empty Type
10433 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
10435 (TypeContainer.DefineProxy): New function used to proxy to parent
10436 implementations when implementing interfaces.
10437 (TypeContainer.ParentImplements): used to lookup if our parent
10438 implements a public function that is required by an interface.
10439 (TypeContainer.VerifyPendingMethods): Hook this up.
10441 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
10442 `modules' and `assemblies' arraylists into arrays. We only grow
10443 these are the very early start up of the program, so this improves
10444 the speedof LookupType (nicely measured).
10446 * expression.cs (MakeByteBlob): Replaced unsafe code with
10447 BitConverter, as suggested by Paolo.
10449 * cfold.cs (ConstantFold.Binary): Special case: perform constant
10450 folding of string concatenation, but if either side is a string,
10451 and the other is not, then return null, and let the runtime use
10452 the concatenation on the string plus the object (using
10453 `Object.ToString').
10455 2002-03-04 Miguel de Icaza <miguel@ximian.com>
10457 Constant Folding has been implemented now.
10459 * expression.cs (Unary.Reduce): Do not throw an exception, catch
10460 the error instead on types that are not supported in one's
10463 * constant.cs (Constant and all children): New set of functions to
10464 perform implict and explicit conversions.
10466 * ecore.cs (EnumConstant): Implement the new functions to perform
10467 conversion by proxying to the child expression.
10469 * codegen.cs: (ConstantCheckState): Constant evaluation has its
10470 own separate setting that can not be turned off from the command
10471 line using --unchecked or --checked and is only controlled using
10472 the checked/unchecked statements and expressions. This setting is
10473 used by the constant folder to flag errors.
10475 * expression.cs (CheckedExpr, UncheckedExpr): Set the
10476 ConstantCheckState as well.
10478 During Resolve, they also have to flag the state, because the
10479 constant folder runs completely in the Resolve phase.
10481 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
10484 2002-03-01 Miguel de Icaza <miguel@ximian.com>
10486 * cfold.cs: New file, this file contains the constant folder.
10488 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
10489 argument to track whether we are using the resulting address to
10490 load or store a value and provide better error messages.
10492 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
10493 new AddressOf arguments.
10495 * statement.cs (Foreach.EmitCollectionForeach): Update
10497 * expression.cs (Argument.Emit): Call AddressOf with proper
10498 arguments to track usage.
10500 (New.DoEmit): Call AddressOf with new arguments.
10502 (Unary.Emit): Adjust AddressOf call.
10504 2002-03-01 Ravi Pratap <ravi@ximian.com>
10506 * cs-parser.jay (member_access): Change the case for pre-defined types
10507 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
10510 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
10513 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
10514 essentially like methods and apply attributes like MethodImplOptions to them too.
10516 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
10519 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
10520 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
10523 * Update code everywhere accordingly.
10525 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
10527 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
10529 2002-02-28 Ravi Pratap <ravi@ximian.com>
10531 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
10532 try performing lookups against those instead of jumping straight into using
10533 the 'using' clauses.
10535 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
10537 (LookupType): Perform lookups in implicit parents too.
10539 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
10540 sequence as RootContext.LookupType.
10542 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
10543 the various cases of namespace lookups into this method.
10545 2002-03-01 Miguel de Icaza <miguel@ximian.com>
10547 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
10548 in positional arguments)
10550 * class.cs (Operator): Update the AllowedModifiers to contain
10553 * cs-parser.jay: Update operator declaration to allow for the
10554 operator body to be empty.
10556 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
10559 2002-02-27 Miguel de Icaza <miguel@ximian.com>
10561 * class.cs (Method.Emit): Label parameters.
10563 * driver.cs: Return 1 or 0 as the program exit code.
10565 2002-02-26 Miguel de Icaza <miguel@ximian.com>
10567 * expression.cs: Special case the `null' object when trying to
10568 auto-compute the type, as anything can be explicitly converted to
10571 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
10572 spotting this Paolo.
10574 (Expression.ImplicitNumericConversion): Perform comparissions of
10575 the type using the underlying type in the case of an enumeration
10576 rather than using the enumeration type for the compare.
10578 Cope with the underlying == type case, which is not possible to
10581 (Expression.ConvertNumericExplicit): Perform comparissions of
10582 the type using the underlying type in the case of an enumeration
10583 rather than using the enumeration type for the compare.
10585 * driver.cs: If the user does not supply an extension, assume .exe
10587 * cs-parser.jay (if_statement): Rewrote so that we can track the
10588 location for the if statement.
10590 * expression.cs (Binary.ConstantFold): Only concat strings when
10591 the operation is "+", not everything ;-)
10593 * statement.cs (Statement.EmitBoolExpression): Take a location
10595 (If, While, Do): Track location.
10597 * expression.cs (Binary.ResolveOperator): In the object + string
10598 case, I was missing a call to ConvertImplicit
10600 2002-02-25 Ravi Pratap <ravi@ximian.com>
10602 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
10603 Location arguments. Ensure we use RootContext.LookupType to do our work
10604 and not try to do a direct Type.GetType and ModuleBuilder.GetType
10606 * interface.cs (PopulateMethod): Handle the type of the parameter being
10609 * expression.cs (Invocation.BetterFunction): Handle the case when we
10610 have a params method with no fixed arguments and a call is made with no
10613 2002-02-25 Miguel de Icaza <miguel@ximian.com>
10615 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
10616 the verbatim-string-literal
10618 * support.cs (InternalParameters.ParameterModifier): handle null
10620 (InternalParameters.ParameterType): ditto.
10622 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
10623 duplicating the name of the variable parameter.
10624 (GetParameterByName): Fix bug where we were not looking up array
10625 paramters if they were the only present (thanks Paolo!).
10626 (GetParameterInfo): We only have an empty set of types if both
10627 fixed and array are set to null.
10628 (GetParameterInfo-idx): Handle FixedParameter == null
10630 * cs-parser.jay: Handle the case where there is no catch
10631 statements (missing null test).
10633 2002-02-22 Miguel de Icaza <miguel@ximian.com>
10635 * driver.cs (MainDriver): Be conservative on our command line
10638 Catch DirectoryNotFoundException when calling GetFiles.
10640 (SplitPathAndPattern): Used to split the input specification into
10641 a path and a pattern that we can feed to Directory.GetFiles.
10643 2002-02-21 Miguel de Icaza <miguel@ximian.com>
10645 * statement.cs (Fixed): Implement the last case of the Fixed
10646 statement (string handling).
10648 * expression.cs (StringPtr): New class used to return a char * to
10649 a string; Used by the Fixed statement.
10651 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
10653 * expression.cs (Binary.ResolveOperator): Remove redundant
10654 MemberLookup pn parent type.
10655 Optimize union call, we do not need a union if the types are the same.
10656 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
10659 Specialize the use of MemberLookup everywhere, instead of using
10660 the default settings.
10662 (StackAlloc): Implement stackalloc keyword.
10664 * cs-parser.jay: Add rule to parse stackalloc.
10666 * driver.cs: Handle /h, /help, /?
10668 * expression.cs (MakeByteBlob): Removed the hacks we had in place
10669 before we supported unsafe code.
10671 * makefile: add --unsafe to the self compilation of mcs.
10673 2002-02-20 Miguel de Icaza <miguel@ximian.com>
10675 * expression.cs (PointerArithmetic): New class that is used to
10676 perform pointer arithmetic.
10677 (Binary.Resolve): Handle pointer arithmetic
10678 Handle pointer comparission.
10679 (ArrayPtr): Utility expression class that is used to take the
10680 address of an array.
10682 (ElementAccess): Implement array access for pointers
10684 * statement.cs (Fixed): Implement fixed statement for arrays, we
10685 are missing one more case before we are done.
10687 * expression.cs (Indirection): Implement EmitAssign and set the
10688 ExprClass to Variable. This allows pointer dereferences to be
10689 treated as variables, and to have values assigned to them.
10691 * ecore.cs (Expression.StoreFromPtr): New utility function to
10692 store values dereferencing.
10694 2002-02-20 Ravi Pratap <ravi@ximian.com>
10696 * expression.cs (Binary.ResolveOperator): Ensure that we are
10697 not trying to operate on a void type - this fixes the reported
10700 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
10701 the parent implementation is sealed.
10703 * ../errors/cs0239.cs : Add.
10705 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
10707 * typemanager.cs (unverifiable_code_type): Corresponds to
10708 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
10709 which have unsafe code in them.
10711 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
10714 2002-02-19 Miguel de Icaza <miguel@ximian.com>
10716 * cs-tokenizer.cs: Add support for @"litreal strings"
10718 Make tokenizer accept pre-processor directives
10719 on any column (remove the old C-like limitation).
10721 * rootcontext.cs (EmitCode): Emit any global attributes.
10722 (AddGlobalAttributes): Used to keep track of assembly attributes.
10724 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
10726 * cs-parser.jay: Add support for global attributes.
10728 2002-02-17 Miguel de Icaza <miguel@ximian.com>
10730 * expression.cs (Indirection): New helper class. Unary will
10731 create Indirection classes to be able to implement the
10732 IMemoryLocation interface on it.
10734 2002-02-16 Miguel de Icaza <miguel@ximian.com>
10736 * cs-parser.jay (fixed_statement): reference the right statement.
10738 * statement.cs (Fixed.Emit): Finish implementing the fixed
10739 statement for the &x case.
10741 2002-02-14 Miguel de Icaza <miguel@ximian.com>
10743 * class.cs (Property.Define, Method.Define): Remove newslot when
10746 * modifiers.cs: My use of NewSlot when `Abstract' was set was
10747 wrong. NewSlot should only be used if the `new' keyword is present.
10749 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
10750 locating our system dir. Sorry about this.
10752 2002-02-13 Miguel de Icaza <miguel@ximian.com>
10754 * driver.cs (GetSystemDir): Compute correctly the location of our
10755 system assemblies. I was using the compiler directory instead of
10756 the library directory.
10758 2002-02-13 Ravi Pratap <ravi@ximian.com>
10760 * expression.cs (BetterFunction): Put back in what Miguel commented out
10761 since it is the correct fix. The problem is elsewhere ;-)
10763 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
10764 parameters of the parms method are themselves compatible or not !
10766 (StandardConversionExists): Fix very dangerous bug where we were forgetting
10767 to check that a class implements an interface before saying that an implicit
10768 conversion was allowed. Use ImplementsInterface to do the checking.
10770 2002-02-13 Miguel de Icaza <miguel@ximian.com>
10772 * class.cs (Method.Define): Track whether we are an explicit
10773 implementation or not. And only call DefineMethodOverride if we
10774 are an explicit implementation.
10776 (Property.DefineMethod): Ditto.
10778 2002-02-11 Ravi Pratap <ravi@ximian.com>
10780 * expression.cs (BetterFunction): Catch hideous bug which was
10781 preventing us from detecting ambiguous calls due to implicit casts i.e
10784 2002-01-29 Miguel de Icaza <miguel@ximian.com>
10786 * support.cs (Pair): Remove un-needed method. I figured why I was
10787 getting the error in cs-parser.jay, the variable in a foreach loop
10788 is readonly, and the compiler does not really treat this as a variable.
10790 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
10791 instead of EQUALS in grammar.
10793 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
10795 * expression.cs (Unary.DoResolve): Check whether the argument is
10798 2002-01-28 Miguel de Icaza <miguel@ximian.com>
10800 * support.cs: Api for Pair to set a value. Despite the fact that
10801 the variables are public the MS C# compiler refuses to compile
10802 code that accesses the field if the variable is part of a foreach
10805 * statement.cs (Fixed): Begin implementation of the fixed
10808 (Block.AddVariable): Return the VariableInfo on success and null
10809 on failure instead of true/false.
10811 * cs-parser.jay (foreach): Catch errors on variables already
10812 defined (we were ignoring this value before) and properly unwind
10813 the block hierarchy
10815 (fixed_statement): grammar for the fixed statement.
10817 2002-01-25 Miguel de Icaza <miguel@ximian.com>
10819 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
10820 pointer types to be incretemented.
10822 (SizeOf): Implement.
10824 * cs-parser.jay (pointer_member_access): Implement
10825 expr->IDENTIFIER production.
10827 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
10828 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
10831 (Unary): Implement indirection.
10833 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
10834 use in non-unsafe context).
10836 (SimpleName.DoResolve): Check for pointers in field access on safe
10839 (Expression.LoadFromPtr): Factor the load-indirect code in this
10840 function. This was duplicated in UnboxCast and ParameterReference
10842 2002-01-24 Miguel de Icaza <miguel@ximian.com>
10844 * expression.cs (ComposedCast): report an error if a pointer cast
10845 is used in a safe region.
10847 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
10848 pointer type casts in unsafe context.
10850 * codegen.cs (EmitContext): Set up IsUnsafe.
10852 * cs-parser.jay (non_expression_type): Add productions for pointer
10855 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
10856 code. We should not use force into static mode if the method is
10857 not virtual. Fixes bug in MIS
10859 * statement.cs (Do.Emit, While.Emit, For.Emit,
10860 Statement.EmitBoolExpression): Add support to Do and While to
10861 propagate infinite loop as `I do return' semantics.
10863 Improve the For case to also test for boolean constants.
10865 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
10866 to the list of attributes we can add.
10868 Remove `EmitContext' argument.
10870 * class.cs (Method.Define): Apply parameter attributes.
10871 (Constructor.Define): Apply parameter attributes.
10872 (MethodCore.LabelParameters): Move here the core of labeling
10875 * support.cs (ReflectionParameters.ParameterModifier,
10876 InternalParameters.ParameterModifier): Use IsByRef on the type and
10877 only return the OUT bit for these parameters instead of in/out/ref
10880 This is because I miss-understood things. The ParameterInfo.IsIn
10881 and IsOut represent whether the parameter has the [In] and [Out]
10884 2002-01-22 Miguel de Icaza <miguel@ximian.com>
10886 * ecore.cs (FieldExpr.Emit): Release temporaries.
10888 * assign.cs (LocalTemporary.Release): new function.
10890 * codegen.cs (EmitContext.GetTemporaryStorage,
10891 EmitContext.FreeTemporaryStorage): Rework the way we deal with
10892 temporary storage. Now we can "put back" localbuilders when we
10895 2002-01-21 Miguel de Icaza <miguel@ximian.com>
10897 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
10898 need to make a copy of the variable to generate verifiable code.
10900 2002-01-19 Miguel de Icaza <miguel@ximian.com>
10902 * driver.cs: Compute dynamically the system directory.
10904 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
10905 Slower, but more generally useful. Used by the abstract
10906 registering implementation.
10908 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
10909 the rules for the special rule on Type/instances. First check if
10910 we have the same name, and if so, try that special static path
10911 rather than the instance path.
10913 2002-01-18 Miguel de Icaza <miguel@ximian.com>
10915 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
10918 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
10919 Enum, ValueType, Delegate or Array for non-corlib compiles.
10921 * cs-tokenizer.cs: Catch long identifiers (645)
10923 * typemanager.cs (IndexerPropetyName): Ravi never tested this
10926 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
10927 fix, we were returning too early, so we were not registering
10928 pending methods from abstract classes.
10930 Do not register pending methods if the class is abstract.
10932 * expression.cs (Conditional.DoResolve): Report circular implicit
10933 conversions when we neecd to compute it for conditional
10936 (Is.DoResolve): If the expression is always of the provided type,
10937 flag warning 183. If the expression can not ever be of the
10938 provided type flag warning 184.
10940 * class.cs: Catch 169 as well.
10942 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
10945 2002-01-18 Nick Drochak <ndrochak@gol.com>
10947 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
10949 2002-01-17 Miguel de Icaza <miguel@ximian.com>
10951 * interface.cs: (PopulateMethod): Check for pointers being defined
10952 only if the unsafe context is active.
10953 (PopulateProperty): ditto.
10954 (PopulateIndexer): ditto.
10956 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
10957 specified. If pointers are present, make sure that they are
10958 present in an unsafe context.
10959 (Constructor, Constructor.Define): ditto.
10960 (Field, Field.Define): ditto.
10961 (Property, Property.Define): ditto.
10962 (Event, Event.Define): ditto.
10964 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
10965 hashtable if there are classes or structs defined.
10967 * expression.cs (LocalVariableReference.DoResolve): Simplify this
10968 code, as the constant resolution moved.
10970 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
10971 the metadata, so we can flag error 133.
10973 * decl.cs (MemberCore.UnsafeOK): New function to test that a
10974 pointer is being declared in an unsafe context.
10976 2002-01-16 Miguel de Icaza <miguel@ximian.com>
10978 * modifiers.cs (Modifiers.Check): Require a Location argument.
10979 Report error 227 for Unsafe use.
10981 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
10983 * statement.cs (For.Emit): If the test is null, then report that
10984 we do `return', as we wont reach anything afterwards.
10986 (Switch.SwitchGoverningType): Track the expression that matched
10989 * driver.cs: Allow negative numbers as an error code to flag.
10991 * cs-parser.jay: Handle 1551.
10993 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
10995 2002-01-15 Miguel de Icaza <miguel@ximian.com>
10997 * cs-parser.jay: Report 1518 (type declaration can only contain
10998 class, struct, interface, enum or delegate)
11000 (switch_label): Report 1523 (keywords `case' or `default' must
11003 (opt_switch_sections): Report 1522 (empty switch)
11005 * driver.cs: Report 1515 (response file specified multiple times)
11006 Report 1516 (Source file specified multiple times).
11008 * expression.cs (Argument.Resolve): Signal 1510
11010 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
11011 access not allowed in static code)
11013 2002-01-11 Ravi Pratap <ravi@ximian.com>
11015 * typemanager.cs (IsPointerType): Utility method which we are going
11018 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
11019 the object type, so we take care of that.
11021 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
11023 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
11024 added to non-params parameters :-)
11026 * typemanager.cs (CSharpName): Include 'void' type too.
11028 (void_ptr_type): Include in the set of core types.
11030 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
11033 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
11036 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
11037 completely forgotten about it.
11039 2002-01-10 Ravi Pratap <ravi@ximian.com>
11041 * cs-parser.jay (pointer_type): Add. This begins our implementation
11042 of parsing rules for unsafe code.
11044 (unsafe_statement): Implement.
11046 (embedded_statement): Modify to include the above.
11048 * statement.cs (Unsafe): Implement new class for unsafe blocks.
11050 * codegen.cs (EmitContext.InUnsafe): Add. This determines
11051 if the current context is an unsafe one.
11053 * cs-parser.jay (local_variable_pointer_type): Since local variable types
11054 are handled differently, we need separate rules for them.
11056 (local_variable_declaration): Update to use local_variable_pointer_type
11057 to allow variable declarations of unmanaged pointer types.
11059 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
11060 in unsafe contexts.
11062 * ../errors/cs0214.cs : Add.
11064 2002-01-16 Nick Drochak <ndrochak@gol.com>
11066 * makefile: remove 'response' file when cleaning.
11068 2002-01-15 Miguel de Icaza <miguel@ximian.com>
11070 * cs-parser.jay: Report 1524.
11072 2002-01-14 Miguel de Icaza <miguel@ximian.com>
11074 * typemanager.cs (RegisterMethod): drop checking if we have
11075 registered this from here
11077 2002-01-12 Miguel de Icaza <miguel@ximian.com>
11079 * class.cs (Method.EmitDestructor): Implement calling our base
11082 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
11083 value of InFinally.
11085 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
11086 this routine and will wrap the call in a try/catch block. Deal
11089 2002-01-11 Miguel de Icaza <miguel@ximian.com>
11091 * ecore.cs (Expression.MemberLookup): instead of taking a
11092 parameter `same_type' that was used to tell whether we could
11093 access private members we compute our containing type from the
11096 (FieldExpr): Added partial support for volatile fields. This does
11097 not work for volatile fields exposed from assemblies, as I can not
11098 figure out how to extract the modreq from it.
11100 Updated all the source files to use this.
11102 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
11103 because it is referenced by MemberLookup very often.
11105 2002-01-09 Ravi Pratap <ravi@ximian.com>
11107 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
11108 TypeBuilder.GetCustomAttributes to retrieve what we need.
11110 Get rid of redundant default_member_attr_type as this is the same as
11111 default_member_type which already exists.
11113 * interface.cs, attribute.cs : Update accordingly.
11115 2002-01-08 Miguel de Icaza <miguel@ximian.com>
11117 * typemanager.cs: Enable IndexerPropertyName again. It does not
11118 work for TYpeBuilders though. Ravi, can you please fix this?
11120 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
11122 * expression.cs (Argument.Emit): Handle the case of ref objects
11123 being passed to ref functions;
11125 (ParameterReference.EmitLoad): Loads the content of the pointer
11126 without dereferencing.
11128 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11130 * cs-tokenizer.cs: Implemented the pre-processing expressions.
11132 2002-01-08 Ravi Pratap <ravi@ximian.com>
11134 * class.cs (Indexer.DefineMethod): Incorporate the interface
11135 type in the name of the method if we are doing explicit interface
11138 * expression.cs (ConversionExists): Remove as it is completely obsolete.
11140 (BetterConversion): Fix extremely trivial bug where we were referring to
11141 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
11144 * ../errors/bug16.cs : Add although we have fixed it.
11146 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11148 * expression.cs (BaseIndexer): Begin implementation.
11150 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
11152 * cs-parser.jay (indexer_declarator): Use qualified_identifier
11153 production directly to remove a shift/reduce, and implement
11154 explicit interface implementation.
11156 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
11157 after a floating point suffix.
11159 * expression.cs (DoNumericPromotions): Improved the conversion for
11160 uint/uint. If we have a constant, we avoid doing a typecast to a
11163 * class.cs (Indexer): Implement explicit interface implementation
11166 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
11168 * class.cs: make the default instance constructor public and hidebysig.
11170 2001-01-03 Ravi Pratap <ravi@ximian.com>
11172 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
11173 so we can call it from elsewhere.
11175 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
11176 we emit it internally if the class has a defined indexer; otherwise the user
11177 emits it by decorating the class definition with the DefaultMemberAttribute.
11179 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
11180 attribute is not used on a type which defines an indexer.
11182 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
11183 character when we skip whitespace.
11185 * ../errors/cs0646.cs : Add.
11187 2002-01-03 Miguel de Icaza <miguel@ximian.com>
11189 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
11192 * makefile: Add practical target `mcs3.exe' which builds the third
11193 generation compiler.
11195 * expression.cs (New): Fix structures constructor calling.
11197 * class.cs (Property, Method, Indexer): Emit Final flag on the
11198 method if we are an interface implementation and we are not
11201 * ecore.cs (PropertyExpr): New public field `IsBase', tells
11202 whether this property is referencing a `base' method.
11204 * expression.cs (Invocation.EmitCall): take an extra argument:
11205 is_base, this is used to determine whether the `call' or
11206 `callvirt' opcode should be used.
11209 * delegate.cs: update EmitCall.
11211 * class.cs (Method.Define): Set NewSlot for the cases where we are
11212 not implementing an interface method.
11214 (Property.Define): ditto.
11216 2002-01-02 Miguel de Icaza <miguel@ximian.com>
11218 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
11219 'r'. Allows mcs to parse itself fully.
11221 2002-01-02 Ravi Pratap <ravi@ximian.com>
11223 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
11224 of the number of initializers that require the InitializeArray method.
11226 (CheckIndices): Store the Expression in all cases - not the plain value. Also
11227 update the above field where necessary.
11229 (MakeByteBlob): Update accordingly.
11231 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
11234 (EmitDynamicInitializers): Update in accordance with the new optimization.
11236 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
11237 same OpCode applies.
11239 * cs-parser.jay : Fix some glaring errors I introduced.
11241 2002-01-01 Ravi Pratap <ravi@ximian.com>
11243 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
11244 so that we can check for name clashes there too.
11246 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
11247 for interface indexers.
11249 * interfaces.cs (Define): Emit the default member attribute.
11251 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
11252 variable was being referred to while setting the value ;-)
11254 2002-01-01 Miguel de Icaza <miguel@ximian.com>
11256 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
11257 byte-by-byte information when we know the data is zero.
11259 Make the block always a multiple of 4, because
11260 DefineInitializedData has a bug.
11262 * assign.cs: Fix, we should assign from the temporary, not from
11265 * expression.cs (MakeByteBlob): Fix my incorrect code.
11267 2001-12-31 Miguel de Icaza <miguel@ximian.com>
11269 * typemanager.cs (EnumToUnderlying): This function is used to get
11270 the underlying type from an enumeration, because it does not
11273 * constant.cs: Use the I4_S form for values between -128 and 127.
11275 * statement.cs (Block.LookupLabel): Looks up a label.
11276 (Block): Drop support for labeled blocks.
11278 (LabeledStatement): New kind of statement that represents a label
11281 (Goto): Finally implement this bad boy.
11283 * cs-parser.jay: Update to reflect new mechanism to implement
11286 2001-12-30 Miguel de Icaza <miguel@ximian.com>
11288 * codegen.cs (EmitContext.This): a codegen property that keeps the
11289 a single instance of this instead of creating many different this
11292 * delegate.cs (Delegate.DoResolve): Update to use the property;
11294 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
11296 * expression.cs (BaseAccess.DoResolve): Ditto.
11298 2001-12-29 Ravi Pratap <ravi@ximian.com>
11300 * typemanager.cs (methodimpl_attr_type): Add to hold the type
11301 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
11303 (InitCoreTypes): Update accordingly.
11305 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
11306 so we can quickly store the state.
11308 (ApplyAttributes): Set the correct implementation flags
11309 for InternalCall methods.
11311 2001-12-29 Miguel de Icaza <miguel@ximian.com>
11313 * expression.cs (EmitCall): if a method is not virtual, then do
11314 not use callvirt on it.
11316 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
11317 user defined stuff) requires the use of stobj, which takes an
11318 address on the stack instead of an array and an index. So emit
11319 the Ldelema operation for it.
11321 (EmitStoreOpcode): Use stobj for valuetypes.
11323 (UnaryMutator.EmitCode): Use the right 1 value depending on
11324 whether we are dealing with int64/uint64, float or doubles.
11326 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
11327 constructors that I implemented last night.
11329 (Constructor.IsDefault): Fix to work properly for static
11332 * cs-parser.jay (CheckDef): report method signature errors.
11333 Update error number 103 to be 132.
11335 * decl.cs: New AdditionResult enumeration value: MethodExists.
11336 Although we do this check for methods later on in the semantic
11337 analysis, catching repeated default constructors is so easy that
11338 we catch these here.
11340 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
11343 (ParameterReference.EmitAssign, Emit): handle
11346 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
11347 (ArrayAccess.EmitStoreOpcode): ditto.
11349 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
11351 * expression.cs (MakeByteBlob): Complete all the missing types
11352 (uint, short, ushort, byte, sbyte)
11354 * class.cs: Only init instance field initializers on instance
11357 Rename `constructors' to instance_constructors.
11359 (TypeContainer.AddConstructor): Only add constructors to the list
11360 if it is not static.
11362 Make sure that we handle default_static_constructor independently
11363 everywhere where we handle instance_constructors
11365 2001-12-28 Miguel de Icaza <miguel@ximian.com>
11367 * class.cs: Do not lookup or create a base initializer for a
11368 static constructor.
11370 (ConstructorInitializer.Resolve): use the proper type to lookup
11373 * cs-parser.jay: Report error 1585 (modifiers between type and name).
11375 * enum.cs, interface.cs: Remove CloseType, this is taken care by
11378 * decl.cs: CloseType is now an virtual method, the default
11379 implementation just closes this type.
11381 2001-12-28 Ravi Pratap <ravi@ximian.com>
11383 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
11384 to PreserveSig by default. Also emit HideBySig on such methods.
11386 Basically, set the defaults to standard values.
11388 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
11389 argument, if candidate is better, it can't be worse than the best !
11391 (Invocation): Re-write bits to differentiate between methods being
11392 applicable in their expanded form and their normal form - for params
11395 Get rid of use_standard everywhere as only standard conversions are allowed
11396 in overload resolution.
11398 More spec conformance.
11400 2001-12-27 Miguel de Icaza <miguel@ximian.com>
11402 * driver.cs: Add --timestamp, to see where the compiler spends
11405 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
11406 `this' in static code.
11408 (SimpleName.DoResolve): Implement in terms of a helper function
11409 that allows static-references to be passed upstream to
11412 (Expression.ResolveWithSimpleName): Resolve specially simple
11413 names when called by MemberAccess to implement the special
11416 (Expression.ImplicitReferenceConversion): Handle conversions from
11417 Null to reference types before others, as Null's type is
11420 * expression.cs (Invocation.EmitCall): Handle the special case of
11421 calling methods declared on a reference type from a ValueType
11422 (Base classes System.Object and System.Enum)
11424 (MemberAccess.Resolve): Only perform lookups on Enumerations if
11425 the left hand side is a TypeExpr, not on every enumeration.
11427 (Binary.Resolve): If types are reference types, then do a cast to
11428 object on operators != and == of both arguments.
11430 * typemanager.cs (FindMembers): Extract instance and static
11431 members if requested.
11433 * interface.cs (PopulateProperty): Use void_type instead of null
11434 as the return type for the setter method.
11436 (PopulateIndexer): ditto.
11438 2001-12-27 Ravi Pratap <ravi@ximian.com>
11440 * support.cs (ReflectionParameters): Fix minor bug where we
11441 were examining the wrong parameter for the ParamArray attribute.
11443 Cope with requests for the type of the parameter at position
11444 greater than the params parameter's. We now return the element
11445 type of the params array as that makes more sense.
11447 * expression.cs (Invocation.IsParamsMethodApplicable): Update
11448 accordingly as we no longer have to extract the element type
11451 (Invocation.OverloadResolve): Update.
11453 2001-12-27 Miguel de Icaza <miguel@ximian.com>
11455 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
11456 against IEnumerator, test whether the return value is a descendant
11457 of the IEnumerator interface.
11459 * class.cs (Indexer.Define): Use an auxiliary method to implement
11460 the other bits of the method definition. Begin support for
11461 explicit interface implementation.
11463 (Property.DefineMethod): Use TypeManager.void_type instead of null
11464 for an empty return value.
11466 2001-12-26 Miguel de Icaza <miguel@ximian.com>
11468 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
11469 dealing with a FieldExpr which is composed of a FieldBuilder, in
11470 the code path we did extract the constant, but we should have
11471 obtained the underlying value to be able to cast it (otherwise we
11472 end up in an infinite loop, this is what Ravi was running into).
11474 (ArrayCreation.UpdateIndices): Arrays might be empty.
11476 (MemberAccess.ResolveMemberAccess): Add support for section
11477 14.5.4.1 that deals with the special case of E.I when E is a type
11478 and something else, that I can be a reference to a static member.
11480 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
11481 handle a particular array type to create byte blobs, it is just
11482 something we dont generate byteblobs for.
11484 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
11487 * location.cs (Push): remove the key from the hashtable that we
11488 are about to add. This happens for empty files.
11490 * driver.cs: Dispose files after we have parsed them.
11492 (tokenize): new function that only runs the tokenizer on its
11493 input, for speed testing.
11495 2001-12-26 Ravi Pratap <ravi@ximian.com>
11497 * class.cs (Event.Define): Define the private field only if there
11498 are no accessors defined.
11500 * expression.cs (ResolveMemberAccess): If there is no associated
11501 field with the event, that means we have an event defined with its
11502 own accessors and we should flag error cs0070 since transforming
11503 ourselves into a field is not valid in that case.
11505 * ecore.cs (SimpleName.DoResolve): Same as above.
11507 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
11508 and charset to sane values.
11510 2001-12-25 Ravi Pratap <ravi@ximian.com>
11512 * assign.cs (DoResolve): Perform check on events only if they
11513 are being accessed outside the declaring type.
11515 * cs-parser.jay (event_declarations): Update rules to correctly
11516 set the type of the implicit parameter etc.
11518 (add_accessor, remove_accessor): Set current local parameters.
11520 * expression.cs (Binary): For delegate addition and subtraction,
11521 cast the return value from the method into the appropriate delegate
11524 2001-12-24 Ravi Pratap <ravi@ximian.com>
11526 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
11527 of these as the workaround is unnecessary.
11529 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
11530 delegate data - none of that is needed at all.
11532 Re-write bits to extract the instance expression and the delegate method
11535 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
11538 * attribute.cs (ApplyAttributes): New method to take care of common tasks
11539 of attaching attributes instead of duplicating code everywhere.
11541 * everywhere : Update code to do attribute emission using the above method.
11543 2001-12-23 Miguel de Icaza <miguel@ximian.com>
11545 * expression.cs (IsParamsMethodApplicable): if there are not
11546 parameters, return immediately.
11548 * ecore.cs: The 0 literal can be implicity converted to an enum
11551 (SimpleName.DoResolve): First lookup the type, then lookup the
11554 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
11555 want to get its address. If the InstanceExpression is not
11556 addressable, store the result in a temporary variable, then get
11559 * codegen.cs: Only display 219 errors on warning level or above.
11561 * expression.cs (ArrayAccess): Make it implement the
11562 IMemoryLocation interface.
11564 (Binary.DoResolve): handle the operator == (object a, object b)
11565 and operator != (object a, object b) without incurring into a
11566 BoxedCast (because 5 != o should never be performed).
11568 Handle binary enumerator operators.
11570 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
11571 value type, otherwise use Ldelem_ref.
11573 Use precomputed names;
11575 (AddressOf): Implement address of
11577 * cs-parser.jay (labeled_statement): Fix recursive block
11578 addition by reworking the production.
11580 * expression.cs (New.DoEmit): New has a special case:
11582 If we are dealing with a ValueType, we have a few
11583 situations to deal with:
11585 * The target of New is a ValueType variable, that is
11586 easy, we just pass this as the variable reference
11588 * The target of New is being passed as an argument,
11589 to a boxing operation or a function that takes a
11592 In this case, we need to create a temporary variable
11593 that is the argument of New.
11596 2001-12-23 Ravi Pratap <ravi@ximian.com>
11598 * rootcontext.cs (LookupType): Check that current_type is not null before
11599 going about looking at nested types.
11601 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
11602 not implement the IAssignMethod interface any more.
11604 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
11605 where we tranform them into FieldExprs if they are being resolved from within
11606 the declaring type.
11608 * ecore.cs (SimpleName.DoResolve): Do the same here.
11610 * assign.cs (DoResolve, Emit): Clean up code considerably.
11612 * ../errors/bug10.cs : Add.
11614 * ../errors/cs0070.cs : Add.
11616 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
11618 * assign.cs : Get rid of EventIsLocal everywhere.
11620 2001-12-23 Miguel de Icaza <miguel@ximian.com>
11622 * ecore.cs (ConvertIntLiteral): finished the implementation.
11624 * statement.cs (SwitchLabel): Convert the value we are using as a
11625 key before looking up the table.
11627 2001-12-22 Miguel de Icaza <miguel@ximian.com>
11629 * codegen.cs (EmitTopBlock): Require a Location argument now.
11631 * cs-parser.jay (constructor_declarator): We need to setup
11632 current_local_parameters before we parse the
11633 opt_constructor_initializer, to allow the variables to be bound
11634 to the constructor arguments.
11636 * rootcontext.cs (LookupType): First lookup nested classes in our
11637 class and our parents before we go looking outside our class.
11639 * expression.cs (ConstantFold): Extract/debox the values at the
11642 * rootcontext.cs (EmitCode): Resolve the constants first before we
11643 resolve the types. This is not really needed, but it helps debugging.
11645 * statement.cs: report location.
11647 * cs-parser.jay: pass location to throw statement.
11649 * driver.cs: Small bug fix.
11651 * report.cs: Updated format to be 4-zero filled digits.
11653 2001-12-22 Ravi Pratap <ravi@ximian.com>
11655 * expression.cs (CheckIndices): Fix minor bug where the wrong
11656 variable was being referred to ;-)
11658 (DoEmit): Do not call EmitStaticInitializers when the
11659 underlying type is System.Object.
11661 2001-12-21 Ravi Pratap <ravi@ximian.com>
11663 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
11664 and do the usual workaround for SRE.
11666 * class.cs (MyEventBuilder.EventType): New member to get at the type
11667 of the event, quickly.
11669 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
11671 * assign.cs (Assign.DoResolve): Handle the case when the target
11672 is an EventExpr and perform the necessary checks.
11674 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
11677 (SimpleName.MemberStaticCheck): Include check for EventExpr.
11679 (EventExpr): Set the type in the constructor itself since we
11680 are meant to be born fully resolved.
11682 (EventExpr.Define): Revert code I wrote earlier.
11684 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
11685 instance expression is null. The instance expression is a This in that case
11686 or a null, depending on whether it is a static method or not.
11688 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
11689 refers to more than one method.
11691 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
11692 and accordingly flag errors.
11694 2001-12-21 Miguel de Icaza <miguel@ximian.com>
11696 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
11698 2001-12-22 Miguel de Icaza <miguel@ximian.com>
11700 * location.cs (ToString): Provide useful rutine.
11702 2001-12-21 Miguel de Icaza <miguel@ximian.com>
11704 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
11705 objects, return the actual integral boxed.
11707 * statement.cs (SwitchLabel): define an ILLabel for each
11710 (Switch.CheckSwitch): If the value is a Literal, extract
11711 the underlying literal.
11713 Also in the unused hashtable we had, add the SwitchLabel so we can
11714 quickly look this value up.
11716 * constant.cs: Implement a bunch of new constants. Rewrite
11717 Literal based on this. Made changes everywhere to adapt to this.
11719 * expression.cs (Expression.MakeByteBlob): Optimize routine by
11720 dereferencing array only once, and also copes with enumrations.
11722 bytes are two bytes wide, not one.
11724 (Cast): Perform constant conversions.
11726 * ecore.cs (TryImplicitIntConversion): Return literals instead of
11727 wrappers to the literals here.
11729 * expression.cs (DoNumericPromotions): long literals can converted
11730 to ulong implicity (this is taken care of elsewhere, but I was
11731 missing this spot).
11733 * ecore.cs (Expression.Literalize): Make the return type Literal,
11734 to improve type checking.
11736 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
11738 2001-12-20 Miguel de Icaza <miguel@ximian.com>
11740 * literal.cs: Revert code from ravi that checked the bounds. The
11741 bounds are sane by the definition of the type itself.
11743 * typemanager.cs: Fix implementation of ImplementsInterface. We
11744 need to actually look up in our parent hierarchy for interfaces
11747 * const.cs: Use the underlying type for enumerations
11749 * delegate.cs: Compute the basename for the delegate creation,
11750 that should fix the delegate test case, and restore the correct
11751 Type Lookup semantics in rootcontext
11753 * rootcontext.cs: Revert Ravi's last patch. The correct way of
11754 referencing a nested type with the Reflection API is using the "+"
11757 * cs-parser.jay: Do not require EOF token at the end.
11759 2001-12-20 Ravi Pratap <ravi@ximian.com>
11761 * rootcontext.cs (LookupType): Concatenate type names with
11762 a '.' instead of a '+' The test suite passes again.
11764 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
11765 field of the enumeration.
11767 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
11768 the case when the member is an EventExpr.
11770 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
11771 static has an associated instance expression.
11773 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
11775 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
11777 * class.cs (Event.Define): Register event and perform appropriate checks
11780 We define the Add and Remove methods even if the use provides none because
11781 in that case, we provide default implementations ourselves.
11783 Define a private field of the type of the event. This is done by the CSC compiler
11784 and we should be doing it too ;-)
11786 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
11787 More methods we use in code we generate.
11789 (multicast_delegate_type, delegate_type): Two separate types since the distinction
11792 (InitCoreTypes): Update accordingly for the above.
11794 * class.cs (Event.Emit): Generate code for default accessors that we provide
11796 (EmitDefaultMethod): Do the job in the above.
11798 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
11801 2001-12-20 Miguel de Icaza <miguel@ximian.com>
11803 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
11804 builders even if we were missing one.
11806 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
11807 pass the Basename as our class name instead of the Name. The
11808 basename will be correctly composed for us.
11810 * parameter.cs (Paramters): Now takes a Location argument.
11812 * decl.cs (DeclSpace.LookupType): Removed convenience function and
11813 make all the code call directly LookupType in RootContext and take
11814 this chance to pass the Location information everywhere.
11816 * Everywhere: pass Location information.
11818 2001-12-19 Miguel de Icaza <miguel@ximian.com>
11820 * class.cs (Constructor.Define): Updated way of detecting the
11821 length of the parameters.
11823 (TypeContainer.DefineType): Use basename as the type name for
11826 (TypeContainer.Define): Do not recursively define types here, as
11827 definition is taken care in order by the RootContext.
11829 * tree.cs: Keep track of namespaces in a per-file basis.
11831 * parameter.cs (Parameter.ComputeSignature): Update to use
11834 (Parameters.GetSignature): ditto.
11836 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
11837 instead of a TypeContainer.
11839 (Interface.SemanticAnalysis): Use `this' instead of our parent to
11840 resolve names. Because we need to be resolve in our context, not
11843 * driver.cs: Implement response files.
11845 * class.cs (TypeContainer.DefineType): If we are defined, do not
11846 redefine ourselves.
11848 (Event.Emit): Emit the code for add/remove handlers.
11849 (Event.Define): Save the MethodBuilders for add/remove.
11851 * typemanager.cs: Use pair here too.
11853 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
11854 DictionaryEntry requires the first argument to be non-null.
11856 (enum_declaration): Compute full name for registering the
11859 (delegate_declaration): Instead of using
11860 formal_parameter_list, use opt_formal_parameter_list as the list
11863 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
11864 (EventParsing): New property that controls whether `add' and
11865 `remove' are returned as tokens or identifiers (for events);
11867 2001-12-19 Ravi Pratap <ravi@ximian.com>
11869 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
11870 use MyEventBuilder only and let it wrap the real builder for us.
11872 (MyEventBuilder): Revamp constructor etc.
11874 Implement all operations that we perform on EventBuilder in precisely the same
11877 (FindMembers): Update to use the EventBuilder member.
11879 (Event.Emit): Update accordingly.
11881 2001-12-18 Ravi Pratap <ravi@ximian.com>
11883 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
11884 by calling the appropriate methods.
11886 (GetCustomAttributes): Make stubs as they cannot possibly do anything
11889 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
11891 2001-12-17 Ravi Pratap <ravi@ximian.com>
11893 * delegate.cs (Delegate.Populate): Check that the return type
11894 and various parameters types are indeed accessible.
11896 * class.cs (Constructor.Define): Same here.
11898 (Field.Define): Ditto.
11900 (Event.Define): Ditto.
11902 (Operator.Define): Check that the underlying Method defined itself
11903 correctly - so it's MethodBuilder should not be null.
11905 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
11906 expression happens to be null.
11908 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
11909 members but as of now we don't seem to be able to do anything really useful with it.
11911 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
11912 not the EventBuilder.
11914 2001-12-18 Miguel de Icaza <miguel@ximian.com>
11916 * cs-tokenizer.cs: Add support for defines.
11917 Add support for #if, #elif, #else, #endif
11919 (eval_var): evaluates a variable.
11920 (eval): stubbed for evaluating functions.
11922 * cs-parser.jay: Pass the defines information
11924 * driver.cs: Add --define command line option.
11926 * decl.cs: Move MemberCore here.
11928 Make it the base class for DeclSpace. This allows us to catch and
11929 report 108 and 109 for everything now.
11931 * class.cs (TypeContainer.Define): Extract all the members
11932 before populating and emit the warning 108 (new keyword required
11933 to override) instead of having each member implement this.
11935 (MemberCore.Define): New abstract method, we will be using this in
11936 the warning reporting engine in Populate.
11938 (Operator.Define): Adjust to new MemberCore protocol.
11940 * const.cs (Const): This does not derive from Expression, it is a
11941 temporary object we use to create fields, it is a MemberCore.
11943 * class.cs (Method.Define): Allow the entry point to be in a
11946 * driver.cs: Rewrite the argument handler to clean it up a bit.
11948 * rootcontext.cs: Made it just an auxiliary namespace feature by
11949 making everything static.
11951 * driver.cs: Adapt code to use RootContext type name instead of
11954 * delegate.cs: Remove RootContext argument.
11956 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
11959 * class.cs (Event.Define): The lookup can fail.
11961 * cs-tokenizer.cs: Begin implementation of pre-procesor.
11963 * expression.cs: Resolve the this instance before invoking the code.
11965 2001-12-17 Miguel de Icaza <miguel@ximian.com>
11967 * cs-parser.jay: Add a production in element_access that allows
11968 the thing to become a "type" reference. This way we can parse
11969 things like "(string [])" as a type.
11971 Note that this still does not handle the more complex rules of
11975 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
11977 * ecore.cs: (CopyNewMethods): new utility function used to
11978 assemble the list of methods from running FindMembers.
11980 (MemberLookup): Rework FindMembers so that
11982 2001-12-16 Miguel de Icaza <miguel@ximian.com>
11984 * class.cs (TypeContainer): Remove Delegates who fail to be
11987 * delegate.cs (Populate): Verify that we dont get null return
11988 values. TODO: Check for AsAccessible.
11990 * cs-parser.jay: Use basename to emit error 574 (destructor should
11991 have the same name as container class), not the full name.
11993 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
11994 possible representation.
11996 Also implements integer type suffixes U and L.
11998 2001-12-15 Miguel de Icaza <miguel@ximian.com>
12000 * expression.cs (ArrayCreation.DoResolve): We need to do the
12001 argument resolution *always*.
12003 * decl.cs: Make this hold the namespace. Hold the root context as
12005 (LookupType): Move here.
12007 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
12009 * location.cs (Row, Name): Fixed the code, it was always returning
12010 references to the first file.
12012 * interface.cs: Register properties defined through interfaces.
12014 * driver.cs: Add support for globbing on the command line
12016 * class.cs (Field): Make it derive from MemberCore as well.
12019 2001-12-15 Ravi Pratap <ravi@ximian.com>
12021 * class.cs (Event::Define): Check that the type of the event is a delegate
12022 type else flag error #66.
12024 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
12027 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
12028 values of EntryPoint, CharSet etc etc.
12030 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
12032 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
12033 be null and we should ignore this. I am not sure if this is really clean. Apparently,
12034 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
12035 which needs this to do its work.
12037 * ../errors/cs0066.cs : Add.
12039 2001-12-14 Miguel de Icaza <miguel@ximian.com>
12041 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
12044 * class.cs: (MethodSignature.MethodSignature): Removed hack that
12045 clears out the parameters field.
12046 (MemberSignatureCompare): Cleanup
12048 (MemberCore): New base class used to share code between MethodCore
12051 (RegisterRequiredImplementations) BindingFlags.Public requires
12052 either BindingFlags.Instace or Static. Use instance here.
12054 (Property): Refactored code to cope better with the full spec.
12056 * parameter.cs (GetParameterInfo): Return an empty array instead
12059 * class.cs (Property): Abstract or extern properties have no bodies.
12061 * parameter.cs (GetParameterInfo): return a zero-sized array.
12063 * class.cs (TypeContainer.MethodModifiersValid): Move all the
12064 method modifier validation to the typecontainer so we can reuse
12065 this on properties.
12067 (MethodCore.ParameterTypes): return an empty sized array of types.
12069 (Property.Define): Test property modifier validity.
12071 Add tests for sealed/override too.
12073 (Method.Emit): abstract or extern methods have no bodies.
12075 2001-12-14 Ravi Pratap <ravi@ximian.com>
12077 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
12080 (Method::Define, ::Emit): Modify accordingly.
12082 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
12084 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
12086 * makefile: Pass in /unsafe.
12088 2001-12-13 Miguel de Icaza <miguel@ximian.com>
12090 * class.cs (MakeKey): Kill routine.
12092 * class.cs (TypeContainer.Define): Correctly define explicit
12093 method implementations (they require the full interface name plus
12096 * typemanager.cs: Deply the PtrHashtable here and stop using the
12097 lame keys. Things work so much better.
12099 This of course broke everyone who depended on `RegisterMethod' to
12100 do the `test for existance' test. This has to be done elsewhere.
12102 * support.cs (PtrHashtable): A hashtable that avoid comparing with
12103 the object stupid Equals method (because, that like fails all over
12104 the place). We still do not use it.
12106 * class.cs (TypeContainer.SetRequiredInterface,
12107 TypeContainer.RequireMethods): Killed these two routines and moved
12108 all the functionality to RegisterRequiredImplementations.
12110 (TypeContainer.RegisterRequiredImplementations): This routine now
12111 registers all the implementations required in an array for the
12112 interfaces and abstract methods. We use an array of structures
12113 which can be computed ahead of time to reduce memory usage and we
12114 also assume that lookups are cheap as most classes will not
12115 implement too many interfaces.
12117 We also avoid creating too many MethodSignatures.
12119 (TypeContainer.IsInterfaceMethod): Update and optionally does not
12120 clear the "pending" bit if we find that there are problems with
12123 (TypeContainer.VerifyPendingMethods): Update to report errors of
12124 methods that look like implementations but are not.
12126 (TypeContainer.Define): Add support for explicit interface method
12129 2001-12-12 Miguel de Icaza <miguel@ximian.com>
12131 * typemanager.cs: Keep track of the parameters here instead of
12132 being a feature of the TypeContainer.
12134 * class.cs: Drop the registration of parameters here, as
12135 InterfaceMethods are also interface declarations.
12137 * delegate.cs: Register methods with the TypeManager not only with
12138 the TypeContainer. This code was buggy.
12140 * interface.cs: Full registation here.
12142 2001-12-11 Miguel de Icaza <miguel@ximian.com>
12144 * expression.cs: Remove reducer for binary expressions, it can not
12147 * const.cs: Put here the code that used to go into constant.cs
12149 * constant.cs: Put here the code for constants, this is a new base
12150 class for Literals.
12152 * literal.cs: Make Literal derive from Constant.
12154 2001-12-09 Miguel de Icaza <miguel@ximian.com>
12156 * statement.cs (Return.Emit): Report error 157 if the user
12157 attempts to return from a finally block.
12159 (Return.Emit): Instead of emitting a return, jump to the end of
12162 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
12163 LocalBuilder to store the result of the function. ReturnLabel is
12164 the target where we jump.
12167 2001-12-09 Radek Doulik <rodo@ximian.com>
12169 * cs-parser.jay: remember alias in current namespace
12171 * ecore.cs (SimpleName::DoResolve): use aliases for types or
12174 * class.cs (LookupAlias): lookup alias in my_namespace
12176 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
12178 (LookupAlias): lookup alias in this and if needed in parent
12181 2001-12-08 Miguel de Icaza <miguel@ximian.com>
12185 * rootcontext.cs: (ModuleBuilder) Made static, first step into
12186 making things static. I need this to avoid passing the
12187 TypeContainer when calling ParameterType.
12189 * support.cs (InternalParameters.ParameterType): Remove ugly hack
12190 that did string manipulation to compute the type and then call
12191 GetType. Use Parameter.ParameterType instead.
12193 * cs-tokenizer.cs: Consume the suffix for floating values.
12195 * expression.cs (ParameterReference): figure out whether this is a
12196 reference parameter or not. Kill an extra variable by computing
12197 the arg_idx during emission.
12199 * parameter.cs (Parameters.GetParameterInfo): New overloaded
12200 function that returns whether a parameter is an out/ref value or not.
12202 (Parameter.ParameterType): The type of the parameter (base,
12203 without ref/out applied).
12205 (Parameter.Resolve): Perform resolution here.
12206 (Parameter.ExternalType): The full type (with ref/out applied).
12208 * statement.cs (Using.Emit, Using.EmitExpression): Implement
12209 support for expressions on the using statement.
12211 2001-12-07 Miguel de Icaza <miguel@ximian.com>
12213 * statement.cs (Using.EmitLocalVariableDecls): Split the
12214 localvariable handling of the using statement.
12216 (Block.EmitMeta): Keep track of variable count across blocks. We
12217 were reusing slots on separate branches of blocks.
12219 (Try.Emit): Emit the general code block, we were not emitting it.
12221 Check the type of the declaration to be an IDisposable or
12222 something that can be implicity converted to it.
12224 Emit conversions if required.
12226 * ecore.cs (EmptyExpression): New utility class.
12227 (Expression.ImplicitConversionExists): New utility function.
12229 2001-12-06 Miguel de Icaza <miguel@ximian.com>
12231 * statement.cs (Using): Implement.
12233 * expression.cs (LocalVariableReference): Support read only variables.
12235 * statement.cs: Remove the explicit emit for the Leave opcode.
12236 (VariableInfo): Add a readonly field.
12238 2001-12-05 Miguel de Icaza <miguel@ximian.com>
12240 * ecore.cs (ConvCast): new class used to encapsulate the various
12241 explicit integer conversions that works in both checked and
12242 unchecked contexts.
12244 (Expression.ConvertNumericExplicit): Use new ConvCast class to
12245 properly generate the overflow opcodes.
12247 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12249 * statement.cs: The correct type for the EmptyExpression is the
12250 element_type, not the variable type. Ravi pointed this out.
12252 2001-12-04 Ravi Pratap <ravi@ximian.com>
12254 * class.cs (Method::Define): Handle PInvoke methods specially
12255 by using DefinePInvokeMethod instead of the usual one.
12257 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
12258 above to do the task of extracting information and defining the method.
12260 2001-12-04 Ravi Pratap <ravi@ximian.com>
12262 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
12263 of the condition for string type.
12265 (Emit): Move that here.
12267 (ArrayCreation::CheckIndices): Keep string literals in their expression
12270 (EmitDynamicInitializers): Handle strings appropriately.
12272 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12274 * codegen.cs (EmitContext): Replace multiple variables with a
12275 single pointer to the current Switch statement.
12277 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
12280 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12284 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
12287 (Foreach.Emit): Foreach on arrays was not setting
12288 up the loop variables (for break/continue).
12290 (GotoCase): Semi-implented.
12292 2001-12-03 Ravi Pratap <ravi@ximian.com>
12294 * attribute.cs (CheckAttribute): Handle system attributes by using
12295 Attribute.GetAttributes to examine information we need.
12297 (GetValidPlaces): Same here.
12299 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
12301 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
12303 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
12305 (Method::Define): Set appropriate flags if we have a DllImport attribute.
12307 (Method::Emit): Handle the case when we are a PInvoke method.
12309 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12311 * expression.cs: Use ResolveWithSimpleName on compound names.
12313 2001-12-02 Ravi Pratap <ravi@ximian.com>
12315 * constant.cs (EmitConstant): Make sure we resolve the associated expression
12316 before trying to reduce it.
12318 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
12320 * constant.cs (LookupConstantValue): Implement.
12322 (EmitConstant): Use the above in emitting the constant.
12324 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
12325 that are user-defined by doing a LookupConstantValue on them.
12327 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
12330 2001-11-29 Miguel de Icaza <miguel@ximian.com>
12332 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
12334 (BaseAccess.DoResolve): Implement.
12336 (MemberAccess.DoResolve): Split this routine into a
12337 ResolveMemberAccess routine that can be used independently
12339 2001-11-28 Miguel de Icaza <miguel@ximian.com>
12341 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
12342 As that share bits of the implementation. Is returns a boolean,
12343 while As returns the Type that is being probed.
12345 2001-12-01 Ravi Pratap <ravi@ximian.com>
12347 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
12348 instead of a Literal - much easier.
12350 (EnumInTransit): Remove - utterly useless :-)
12352 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
12354 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
12356 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
12357 chain when we have no associated expression.
12359 2001-11-30 Ravi Pratap <ravi@ximian.com>
12361 * constant.cs (Define): Use Location while reporting the errror.
12363 Also emit a warning when 'new' is used and there is no inherited
12366 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
12369 (LookupEnumValue): Implement to lookup an enum member's value and define it
12372 (Populate): Re-write accordingly to use the above routine.
12374 2001-11-27 Miguel de Icaza <miguel@ximian.com>
12376 * expression.cs (This): Fix prototype for DoResolveLValue to
12377 override the base class DoResolveLValue.
12379 * cs-parser.cs: Report errors cs574 and cs575 (destructor
12382 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
12383 (we need to load the address of the field here). This fixes
12386 (FieldExpr.DoResolveLValue): Call the DoResolve
12387 function to initialize the Instance expression.
12389 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
12390 correctly the GetEnumerator operation on a value type.
12392 * cs-parser.jay: Add more simple parsing error catches.
12394 * statement.cs (Switch): Add support for string switches.
12395 Handle null specially.
12397 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
12399 2001-11-28 Ravi Pratap <ravi@ximian.com>
12401 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
12403 (declare_local_constant): New helper function.
12405 * statement.cs (AddConstant): Keep a separate record of constants
12407 (IsConstant): Implement to determine if a variable is a constant.
12409 (GetConstantExpression): Implement.
12411 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
12413 * statement.cs (IsVariableDefined): Re-write.
12415 2001-11-27 Ravi Pratap <ravi@ximian.com>
12417 * class.cs (TypeContainer::FindMembers): Look for constants
12418 in the case when we are looking for MemberTypes.Field
12420 * expression.cs (MemberAccess::DoResolve): Check that in the
12421 case we are a FieldExpr and a Literal, we are not being accessed
12422 by an instance reference.
12424 * cs-parser.jay (local_constant_declaration): Implement.
12426 (declaration_statement): Implement for constant declarations.
12428 2001-11-26 Miguel de Icaza <miguel@ximian.com>
12430 * statement.cs (Switch): Catch double defaults.
12432 (Switch): More work on the switch() statement
12433 implementation. It works for integral values now, need to finish
12437 2001-11-24 Miguel de Icaza <miguel@ximian.com>
12439 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
12440 integer literals into other integer literals. To be used by
12443 2001-11-24 Ravi Pratap <ravi@ximian.com>
12445 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
12448 (EmitDynamicInitializers): Cope with the above since we extract data
12449 directly from ArrayData now.
12451 (ExpectInitializers): Keep track of whether initializers are mandatory
12454 (Bounds): Make it a hashtable to prevent the same dimension being
12455 recorded for every element in that dimension.
12457 (EmitDynamicInitializers): Fix bug which prevented the Set array method
12460 Also fix bug which was causing the indices to be emitted in the reverse
12463 2001-11-24 Miguel de Icaza <miguel@ximian.com>
12465 * expression.cs (ArrayCreation): Implement the bits that Ravi left
12466 unfinished. They do not work, because the underlying code is
12469 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12471 * cs-parser.jay: Remove bogus fixme.
12473 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
12474 on Switch statement.
12476 2001-11-23 Ravi Pratap <ravi@ximian.com>
12478 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
12481 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
12482 parameter. Apparently, any expression is allowed.
12484 (ValidateInitializers): Update accordingly.
12486 (CheckIndices): Fix some tricky bugs thanks to recursion.
12488 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
12489 I was being completely brain-dead.
12491 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
12492 and re-write acordingly.
12494 (DelegateInvocation): Re-write accordingly.
12496 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
12498 (MakeByteBlob): Handle types more correctly.
12500 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
12501 initialization from expressions but it is incomplete because I am a complete
12504 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12506 * statement.cs (If.Emit): Fix a bug that generated incorrect code
12507 on If. Basically, we have to return `true' (ie, we do return to
12508 our caller) only if both branches of the if return.
12510 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
12511 short-circuit operators, handle them as short circuit operators.
12513 (Cast.DoResolve): Resolve type.
12514 (Cast.Cast): Take an expression as the target type.
12516 * cs-parser.jay (cast_expression): Remove old hack that only
12517 allowed a limited set of types to be handled. Now we take a
12518 unary_expression and we resolve to a type during semantic
12521 Use the grammar productions from Rhys to handle casts (this is
12522 not complete like Rhys syntax yet, we fail to handle that corner
12523 case that C# has regarding (-x), but we will get there.
12525 2001-11-22 Ravi Pratap <ravi@ximian.com>
12527 * class.cs (EmitFieldInitializer): Take care of the case when we have a
12528 field which is an array type.
12530 * cs-parser.jay (declare_local_variables): Support array initialization too.
12532 * typemanager.cs (MakeKey): Implement.
12534 (everywhere): Use the above appropriately.
12536 * cs-parser.jay (for_statement): Update for array initialization while
12537 declaring variables.
12539 * ecore.cs : The error message was correct, it's the variable's names that
12540 were misleading ;-) Make the code more readable.
12542 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
12543 the correct type etc.
12545 (ConvertExplicit): Handle Enum types by examining the underlying type.
12547 2001-11-21 Ravi Pratap <ravi@ximian.com>
12549 * parameter.cs (GetCallingConvention): Always return
12550 CallingConventions.Standard for now.
12552 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12554 * expression.cs (Binary.ResolveOperator): Update the values of `l'
12555 and `r' after calling DoNumericPromotions.
12557 * ecore.cs: Fix error message (the types were in the wrong order).
12559 * statement.cs (Foreach.ProbeCollectionType): Need to pass
12560 BindingFlags.Instance as well
12562 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
12563 implicit int literal conversion in an empty cast so that we
12564 propagate the right type upstream.
12566 (UnboxCast): new class used to unbox value types.
12567 (Expression.ConvertExplicit): Add explicit type conversions done
12570 (Expression.ImplicitNumericConversion): Oops, forgot to test for
12571 the target type before applying the implicit LongLiterals to ULong
12574 2001-11-21 Miguel de Icaza <miguel@ximian.com>
12576 * cs-parser.jay (for_statement): Reworked the way For works: now
12577 we declare manually any variables that are introduced in
12578 for_initializer to solve the problem of having out-of-band code
12579 emition (that is what got for broken).
12581 (declaration_statement): Perform the actual variable declaration
12582 that used to be done in local_variable_declaration here.
12584 (local_variable_declaration): Do not declare anything, just pass
12585 the information on a DictionaryEntry
12587 2001-11-20 Ravi Pratap <ravi@ximian.com>
12589 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
12590 re-write of the logic to now make it recursive.
12592 (UpdateIndices): Re-write accordingly.
12594 Store element data in a separate ArrayData list in the above methods.
12596 (MakeByteBlob): Implement to dump the array data into a byte array.
12598 2001-11-19 Ravi Pratap <ravi@ximian.com>
12600 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
12603 * constant.cs (Define): Implement.
12605 (EmitConstant): Re-write fully.
12607 Pass in location info.
12609 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
12612 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
12613 DictionaryEntry since we need location info too.
12615 (constant_declaration): Update accordingly.
12617 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
12618 code into another method : UpdateIndices.
12620 2001-11-18 Ravi Pratap <ravi@ximian.com>
12622 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
12623 some type checking etc.
12625 2001-11-17 Ravi Pratap <ravi@ximian.com>
12627 * expression.cs (ArrayCreation::ValidateInitializers): Implement
12628 bits to provide dimension info if the user skips doing that.
12630 Update second constructor to store the rank correctly.
12632 2001-11-16 Ravi Pratap <ravi@ximian.com>
12634 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
12635 and try to implement.
12637 * ../errors/cs0150.cs : Add.
12639 * ../errors/cs0178.cs : Add.
12641 2001-11-16 Miguel de Icaza <miguel@ximian.com>
12643 * statement.cs: Implement foreach on multi-dimensional arrays.
12645 * parameter.cs (Parameters.GetParameterByName): Also lookup the
12646 name of the params argument.
12648 * expression.cs: Use EmitStoreOpcode to get the right opcode while
12649 initializing the array.
12651 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
12652 we can use this elsewhere.
12654 * statement.cs: Finish implementation of foreach for single
12657 * cs-parser.jay: Use an out-of-band stack to pass information
12658 around, I wonder why I need this.
12660 foreach_block: Make the new foreach_block the current_block.
12662 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
12663 function used to return a static Parameters structure. Used for
12664 empty parameters, as those are created very frequently.
12666 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
12668 2001-11-15 Ravi Pratap <ravi@ximian.com>
12670 * interface.cs : Default modifier is private, not public. The
12671 make verify test passes again.
12673 2001-11-15 Ravi Pratap <ravi@ximian.com>
12675 * support.cs (ReflectionParameters): Fix logic to determine
12676 whether the last parameter is a params one. Test 9 passes again.
12678 * delegate.cs (Populate): Register the builders we define with
12679 RegisterParameterForBuilder. Test 19 passes again.
12681 * cs-parser.jay (property_declaration): Reference $6 instead
12682 of $$ to get at the location.
12684 (indexer_declaration): Similar stuff.
12686 (attribute): Ditto.
12688 * class.cs (Property): Register parameters for the Get and Set methods
12689 if they exist. Test 23 passes again.
12691 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
12692 call to EmitArguments as we are sure there aren't any params arguments.
12693 Test 32 passes again.
12695 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
12696 IndexOutOfRangeException.
12698 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
12699 Test 33 now passes again.
12701 2001-11-15 Miguel de Icaza <miguel@ximian.com>
12703 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
12704 broke a bunch of things. Will have to come up with a better way
12705 of tracking locations.
12707 * statement.cs: Implemented foreach for single dimension arrays.
12709 2001-11-09 Miguel de Icaza <miguel@ximian.com>
12711 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
12712 an error. This removes the lookup from the critical path.
12714 * cs-parser.jay: Removed use of temporary_loc, which is completely
12717 2001-11-14 Miguel de Icaza <miguel@ximian.com>
12719 * support.cs (ReflectionParameters.ParameterModifier): Report
12720 whether the argument is a PARAMS argument or not.
12722 * class.cs: Set the attribute `ParamArrayAttribute' on the
12723 parameter argument.
12725 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
12726 and cons_param_array_attribute (ConstructorInfo for
12727 ParamArrayAttribute).,
12729 * codegen.cs: Emit the return using the `Return' statement, that
12730 way we can report the error correctly for missing return values.
12732 * class.cs (Method.Emit): Clean up.
12734 * expression.cs (Argument.Resolve): Take another argument: the
12735 location where this argument is used. Notice that this is not
12736 part of the "Argument" class as to reduce the size of the
12737 structure (we know the approximate location anyways).
12739 Test if the argument is a variable-reference, if not, then
12740 complain with a 206.
12742 (Argument.Emit): Emit addresses of variables.
12744 (Argument.FullDesc): Simplify.
12746 (Invocation.DoResolve): Update for Argument.Resolve.
12748 (ElementAccess.DoResolve): ditto.
12750 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
12751 method should be virtual, as this method is always virtual.
12753 (NewDelegate.DoResolve): Update for Argument.Resolve.
12755 * class.cs (ConstructorInitializer.DoResolve): ditto.
12757 * attribute.cs (Attribute.Resolve): ditto.
12759 2001-11-13 Miguel de Icaza <miguel@ximian.com>
12761 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
12763 * expression.cs (ParameterReference): Drop IStackStorage and implement
12764 IAssignMethod instead.
12766 (LocalVariableReference): ditto.
12768 * ecore.cs (FieldExpr): Drop IStackStorage and implement
12769 IAssignMethod instead.
12771 2001-11-13 Miguel de Icaza <miguel@ximian.com>
12773 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
12774 enumerations that are used in heavily used structures derive from
12775 byte in a laughable and pathetic attempt to reduce memory usage.
12776 This is the kind of pre-optimzations that you should not do at
12777 home without adult supervision.
12779 * expression.cs (UnaryMutator): New class, used to handle ++ and
12780 -- separatedly from the other unary operators. Cleans up the
12781 code, and kills the ExpressionStatement dependency in Unary.
12783 (Unary): Removed `method' and `Arguments' from this class, making
12784 it smaller, and moving it all to SimpleCall, so I can reuse this
12785 code in other locations and avoid creating a lot of transient data
12786 strucutres when not required.
12788 * cs-parser.jay: Adjust for new changes.
12790 2001-11-11 Miguel de Icaza <miguel@ximian.com>
12792 * enum.cs (Enum.Populate): If there is a failure during
12795 * cs-parser.jay (opt_enum_base): we used to catch type errors
12796 here, but this is really incorrect. The type error should be
12797 catched during semantic analysis.
12799 2001-12-11 Ravi Pratap <ravi@ximian.com>
12801 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
12802 current_local_parameters as expected since I, in my stupidity, had forgotten
12805 * attribute.cs (GetValidPlaces): Fix stupid bug.
12807 * class.cs (Method::Emit): Perform check on applicability of attributes.
12809 (Constructor::Emit): Ditto.
12811 (Field::Emit): Ditto.
12813 (Field.Location): Store location information.
12815 (Property, Event, Indexer, Operator): Ditto.
12817 * cs-parser.jay (field_declaration): Pass in location for each field.
12819 * ../errors/cs0592.cs : Add.
12821 2001-11-12 Ravi Pratap <ravi@ximian.com>
12823 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
12825 (InitCoreTypes): Update accordingly.
12827 (RegisterAttrType, LookupAttr): Implement.
12829 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
12830 info about the same.
12832 (Resolve): Update to populate the above as necessary.
12834 (Error592): Helper.
12836 (GetValidPlaces): Helper to the above.
12838 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
12840 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
12842 2001-11-12 Ravi Pratap <ravi@ximian.com>
12844 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
12846 * ../errors/cs0617.cs : Add.
12848 2001-11-11 Ravi Pratap <ravi@ximian.com>
12850 * enum.cs (Emit): Rename to Populate to be more consistent with what
12851 we expect it to do and when exactly it is called.
12853 * class.cs, rootcontext.cs : Update accordingly.
12855 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
12856 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
12858 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
12860 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
12861 of a fieldinfo using the above, when dealing with a FieldBuilder.
12863 2001-11-10 Ravi Pratap <ravi@ximian.com>
12865 * ../errors/cs0031.cs : Add.
12867 * ../errors/cs1008.cs : Add.
12869 * ../errrors/cs0543.cs : Add.
12871 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
12874 (FindMembers): Implement.
12876 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
12877 enums and delegates too.
12879 (enum_types): Rename to builder_to_enum.
12881 (delegate_types): Rename to builder_to_delegate.
12883 * delegate.cs (FindMembers): Implement.
12885 2001-11-09 Ravi Pratap <ravi@ximian.com>
12887 * typemanager.cs (IsEnumType): Implement.
12889 * enum.cs (Emit): Re-write parts to account for the underlying type
12890 better and perform checking etc.
12892 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
12893 of the underlying type.
12895 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
12898 * enum.cs (error31): Helper to report error #31.
12900 * cs-parser.jay (enum_declaration): Store location of each member too.
12902 * enum.cs (member_to_location): New hashtable.
12904 (AddEnumMember): Update location hashtable.
12906 (Emit): Use the location of each member while reporting errors.
12908 2001-11-09 Miguel de Icaza <miguel@ximian.com>
12910 * cs-parser.jay: A for_initializer if is a
12911 local_variable_declaration really ammount to have an implicit
12912 block with the variable declaration and no initializer for for.
12914 * statement.cs (For.Emit): Cope with null initializers.
12916 This fixes the infinite loop on for initializers.
12918 2001-11-08 Miguel de Icaza <miguel@ximian.com>
12920 * enum.cs: More cleanup.
12922 * ecore.cs: Remove dead code.
12924 * class.cs (Property.Emit): More simplification.
12925 (Event.Emit): ditto.
12927 Reworked to have less levels of indentation.
12929 2001-11-08 Ravi Pratap <ravi@ximian.com>
12931 * class.cs (Property): Emit attributes.
12941 * enum.cs (Emit): Ditto.
12943 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
12946 * class.cs (Field, Event, etc.): Move attribute generation into the
12947 Emit method everywhere.
12949 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
12950 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
12951 as we had no way of defining nested enums !
12953 * rootcontext.cs : Adjust code accordingly.
12955 * typemanager.cs (AddEnumType): To keep track of enum types separately.
12957 2001-11-07 Ravi Pratap <ravi@ximian.com>
12959 * expression.cs (EvalConstantExpression): Move into ecore.cs
12961 * enum.cs (Enum): Rename some members and make them public and readonly
12962 according to our convention.
12964 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
12967 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
12969 (Enum::Emit): Write a simple version for now which doesn't try to compute
12970 expressions. I shall modify this to be more robust in just a while.
12972 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
12974 (TypeContainer::CloseType): Create the Enum types too.
12976 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
12978 * expression.cs (EvalConstantExpression): Get rid of completely.
12980 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
12981 user-defined values and other cases.
12983 (IsValidEnumLiteral): Helper function.
12985 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
12986 out there in the case we had a literal FieldExpr.
12988 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
12990 (Literalize): Revamp a bit to take two arguments.
12992 (EnumLiteral): New class which derives from Literal to wrap enum literals.
12994 2001-11-06 Ravi Pratap <ravi@ximian.com>
12996 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
12998 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
13000 (Resolve): Use the above to ensure we have proper initializers.
13002 2001-11-05 Ravi Pratap <ravi@ximian.com>
13004 * expression.cs (Expression::EvalConstantExpression): New method to
13005 evaluate constant expressions.
13007 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
13009 2001-11-07 Miguel de Icaza <miguel@ximian.com>
13011 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
13014 (Binary.ResolveOperator): Handle operator != (object a, object b)
13015 and operator == (object a, object b);
13017 (Binary.DoNumericPromotions): Indicate whether the numeric
13018 promotion was possible.
13020 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
13023 Made the ArrayAccess implement interface IAssignMethod instead of
13024 IStackStore as the order in which arguments are passed reflects
13027 * assign.cs: Instead of using expr.ExprClass to select the way of
13028 assinging, probe for the IStackStore/IAssignMethod interfaces.
13030 * typemanager.cs: Load InitializeArray definition.
13032 * rootcontext.cs (RootContext.MakeStaticData): Used to define
13033 static data that can be used to initialize arrays.
13035 2001-11-05 Miguel de Icaza <miguel@ximian.com>
13037 * expression.cs: Handle operator== and operator!= for booleans.
13039 (Conditioal.Reduce): Implement reducer for the ?: operator.
13041 (Conditional.Resolve): Implement dead code elimination.
13043 (Binary.Resolve): Catch string literals and return a new
13044 concatenated string.
13046 (Unary.Reduce): Implement reduction of unary expressions.
13048 * ecore.cs: Split out the expression core handling here.
13050 (Expression.Reduce): New method used to perform constant folding
13051 and CSE. This is needed to support constant-expressions.
13053 * statement.cs (Statement.EmitBoolExpression): Pass true and false
13054 targets, and optimize for !x.
13056 2001-11-04 Ravi Pratap <ravi@ximian.com>
13058 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
13059 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
13060 set custom atttributes.
13062 * literal.cs (Literal::GetValue): New abstract method to return the actual
13063 value of the literal, cast as an object.
13065 (*Literal): Implement GetValue method.
13067 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
13068 expressions to the arraylist but objects of type Argument.
13070 * class.cs (TypeContainer::Emit): Emit our attributes too.
13072 (Method::Emit, Constructor::Emit): Ditto.
13074 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
13075 to be ignoring earlier.
13077 2001-11-03 Ravi Pratap <ravi@ximian.com>
13079 * attribute.cs (AttributeSection::Define): Implement to do the business
13080 of constructing a CustomAttributeBuilder.
13082 (Attribute): New trivial class. Increases readability of code.
13084 * cs-parser.jay : Update accordingly.
13086 (positional_argument_list, named_argument_list, named_argument): New rules
13088 (attribute_arguments): Use the above so that we are more correct.
13090 2001-11-02 Ravi Pratap <ravi@ximian.com>
13092 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
13093 to perform all checks for a method with a params parameter.
13095 (Invocation::OverloadResolve): Update to use the above method and therefore
13096 cope correctly with params method invocations.
13098 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
13101 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
13102 constructors in our parent too because we can't afford to miss out on
13105 * attribute.cs (AttributeSection): New name for the class Attribute
13107 Other trivial changes to improve readability.
13109 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
13110 use the new class names.
13112 2001-11-01 Ravi Pratap <ravi@ximian.com>
13114 * class.cs (Method::Define): Complete definition for params types too
13116 (Indexer::Define): Ditto.
13118 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
13119 Cope everywhere with a request for info about the array parameter.
13121 2001-11-01 Ravi Pratap <ravi@ximian.com>
13123 * tree.cs (RecordNamespace): Fix up to check for the correct key.
13125 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
13126 local_variable_type to extract the string corresponding to the type.
13128 (local_variable_type): Fixup the action to use the new helper method.
13130 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
13133 * expression.cs : Clean out code which uses the above.
13135 2001-10-31 Ravi Pratap <ravi@ximian.com>
13137 * typemanager.cs (RegisterMethod): Check if we already have an existing key
13138 and bale out if necessary by returning a false.
13140 (RegisterProperty): Ditto.
13142 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
13143 and print out appropriate error messages.
13145 * interface.cs (everywhere): Ditto.
13147 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
13148 location to constructor.
13150 * class.cs (Property, Event, Indexer): Update accordingly.
13152 * ../errors/cs111.cs : Added.
13154 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
13155 of a method, as laid down by the spec.
13157 (Invocation::OverloadResolve): Use the above method.
13159 2001-10-31 Ravi Pratap <ravi@ximian.com>
13161 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
13162 now take a TypeContainer and a Parameters object.
13164 (ParameterData): Modify return type of ParameterModifier method to be
13165 Parameter.Modifier and not a string.
13167 (ReflectionParameters, InternalParameters): Update accordingly.
13169 * expression.cs (Argument::GetParameterModifier): Same here.
13171 * support.cs (InternalParameters::ParameterType): Find a better way of determining
13172 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
13173 symbol in it at all so maybe this is only for now.
13175 2001-10-30 Ravi Pratap <ravi@ximian.com>
13177 * support.cs (InternalParameters): Constructor now takes an extra argument
13178 which is the actual Parameters class.
13180 (ParameterDesc): Update to provide info on ref/out modifiers.
13182 * class.cs (everywhere): Update call to InternalParameters to pass in
13183 the second argument too.
13185 * support.cs (ParameterData): Add ParameterModifier, which is a method
13186 to return the modifier info [ref/out etc]
13188 (InternalParameters, ReflectionParameters): Implement the above.
13190 * expression.cs (Argument::ParameterModifier): Similar function to return
13191 info about the argument's modifiers.
13193 (Invocation::OverloadResolve): Update to take into account matching modifiers
13196 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
13197 a new SetFormalParameters object which we pass to InternalParameters.
13199 2001-10-30 Ravi Pratap <ravi@ximian.com>
13201 * expression.cs (NewArray): Merge into the ArrayCreation class.
13203 2001-10-29 Ravi Pratap <ravi@ximian.com>
13205 * expression.cs (NewArray): Merge classes NewBuiltinArray and
13206 NewUserdefinedArray into one as there wasn't much of a use in having
13209 * expression.cs (Argument): Change field's name to ArgType from Type.
13211 (Type): New readonly property which returns the proper type, taking into
13212 account ref/out modifiers.
13214 (everywhere): Adjust code accordingly for the above.
13216 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
13217 whether we are emitting for a ref or out parameter.
13219 * expression.cs (Argument::Emit): Use the above field to set the state.
13221 (LocalVariableReference::Emit): Update to honour the flag and emit the
13224 * parameter.cs (Attributes): Set the correct flags for ref parameters.
13226 * expression.cs (Argument::FullDesc): New function to provide a full desc.
13228 * support.cs (ParameterData): Add method ParameterDesc to the interface.
13230 (ReflectionParameters, InternalParameters): Implement the above method.
13232 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
13235 (Invocation::FullMethodDesc): Ditto.
13237 2001-10-29 Miguel de Icaza <miguel@ximian.com>
13239 * cs-parser.jay: Add extra production for the second form of array
13242 * expression.cs (ArrayCreation): Update to reflect the above
13245 * Small changes to prepare for Array initialization.
13247 2001-10-28 Miguel de Icaza <miguel@ximian.com>
13249 * typemanager.cs (ImplementsInterface): interface might be null;
13250 Deal with this problem;
13252 Also, we do store negative hits on the cache (null values), so use
13253 this instead of calling t.GetInterfaces on the type everytime.
13255 2001-10-28 Ravi Pratap <ravi@ximian.com>
13257 * typemanager.cs (IsBuiltinType): New method to help determine the same.
13259 * expression.cs (New::DoResolve): Get rid of array creation code and instead
13260 split functionality out into different classes.
13262 (New::FormArrayType): Move into NewBuiltinArray.
13264 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
13267 (NewBuiltinArray): New class to handle creation of built-in arrays.
13269 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
13270 account creation of one-dimensional arrays.
13272 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
13274 (NewUserdefinedArray::DoResolve): Implement.
13276 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
13278 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
13279 we maintain inside the TypeManager. This is necessary to perform lookups on the
13282 (LookupType): Update to perform GetType on the module builders too.
13284 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
13286 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
13288 2001-10-23 Ravi Pratap <ravi@ximian.com>
13290 * expression.cs (New::DoResolve): Implement guts of array creation.
13292 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
13294 2001-10-27 Miguel de Icaza <miguel@ximian.com>
13296 * expression.cs: Fix bug I introduced lsat night that broke
13299 (Expression.Resolve): Report a 246 error (can not resolve name)
13300 if we find a SimpleName in the stream.
13302 (Expression.ResolveLValue): Ditto.
13304 (Expression.ResolveWithSimpleName): This function is a variant of
13305 ResolveName, this one allows SimpleNames to be returned without a
13306 warning. The only consumer of SimpleNames is MemberAccess
13308 2001-10-26 Miguel de Icaza <miguel@ximian.com>
13310 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
13311 might arrive here. I have my doubts that this is correct.
13313 * statement.cs (Lock): Implement lock statement.
13315 * cs-parser.jay: Small fixes to support `lock' and `using'
13317 * cs-tokenizer.cs: Remove extra space
13319 * driver.cs: New flag --checked, allows to turn on integer math
13322 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
13323 Threading.Monitor.Exit
13325 2001-10-23 Miguel de Icaza <miguel@ximian.com>
13327 * expression.cs (IndexerAccess::DoResolveLValue): Set the
13328 Expression Class to be IndexerAccess.
13330 Notice that Indexer::DoResolve sets the eclass to Value.
13332 2001-10-22 Miguel de Icaza <miguel@ximian.com>
13334 * class.cs (TypeContainer::Emit): Emit code for indexers.
13336 * assign.cs (IAssignMethod): New interface implemented by Indexers
13337 and Properties for handling assignment.
13339 (Assign::Emit): Simplify and reuse code.
13341 * expression.cs (IndexerAccess, PropertyExpr): Implement
13342 IAssignMethod, clean up old code.
13344 2001-10-22 Ravi Pratap <ravi@ximian.com>
13346 * typemanager.cs (ImplementsInterface): New method to determine if a type
13347 implements a given interface. Provides a nice cache too.
13349 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
13352 (ConvertReferenceExplicit): Ditto.
13354 * delegate.cs (Delegate::Populate): Update to define the parameters on the
13355 various methods, with correct names etc.
13357 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
13358 Operator.UnaryNegation.
13360 * cs-parser.jay (operator_declarator): Be a little clever in the case where
13361 we have a unary plus or minus operator.
13363 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
13366 * everywhere : update accordingly.
13368 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
13371 * class.cs (Method::Define): For the case where we are implementing a method
13372 inherited from an interface, we need to set the MethodAttributes.Final flag too.
13373 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
13375 2001-10-21 Ravi Pratap <ravi@ximian.com>
13377 * interface.cs (FindMembers): Implement to work around S.R.E
13380 * typemanager.cs (IsInterfaceType): Implement.
13382 (FindMembers): Update to handle interface types too.
13384 * expression.cs (ImplicitReferenceConversion): Re-write bits which
13385 use IsAssignableFrom as that is not correct - it doesn't work.
13387 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
13388 and accordingly override EmitStatement.
13390 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
13391 using the correct logic :-)
13393 2001-10-19 Ravi Pratap <ravi@ximian.com>
13395 * ../errors/cs-11.cs : Add to demonstrate error -11
13397 2001-10-17 Miguel de Icaza <miguel@ximian.com>
13399 * assign.cs (Assign::Resolve): Resolve right hand side first, and
13400 then pass this as a hint to ResolveLValue.
13402 * expression.cs (FieldExpr): Add Location information
13404 (FieldExpr::LValueResolve): Report assignment to readonly
13407 (Expression::ExprClassFromMemberInfo): Pass location information.
13409 (Expression::ResolveLValue): Add new method that resolves an
13412 (Expression::DoResolveLValue): Default invocation calls
13415 (Indexers): New class used to keep track of indexers in a given
13418 (IStackStore): Renamed from LValue, as it did not really describe
13419 what this did. Also ResolveLValue is gone from this interface and
13420 now is part of Expression.
13422 (ElementAccess): Depending on the element access type
13424 * typemanager.cs: Add `indexer_name_type' as a Core type
13425 (System.Runtime.CompilerServices.IndexerNameAttribute)
13427 * statement.cs (Goto): Take a location.
13429 2001-10-18 Ravi Pratap <ravi@ximian.com>
13431 * delegate.cs (Delegate::VerifyDelegate): New method to verify
13432 if two delegates are compatible.
13434 (NewDelegate::DoResolve): Update to take care of the case when
13435 we instantiate a delegate from another delegate.
13437 * typemanager.cs (FindMembers): Don't even try to look up members
13438 of Delegate types for now.
13440 2001-10-18 Ravi Pratap <ravi@ximian.com>
13442 * delegate.cs (NewDelegate): New class to take care of delegate
13445 * expression.cs (New): Split the delegate related code out into
13446 the NewDelegate class.
13448 * delegate.cs (DelegateInvocation): New class to handle delegate
13451 * expression.cs (Invocation): Split out delegate related code into
13452 the DelegateInvocation class.
13454 2001-10-17 Ravi Pratap <ravi@ximian.com>
13456 * expression.cs (New::DoResolve): Implement delegate creation fully
13457 and according to the spec.
13459 (New::DoEmit): Update to handle delegates differently.
13461 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
13462 because of which we were printing out arguments in reverse order !
13464 * delegate.cs (VerifyMethod): Implement to check if the given method
13465 matches the delegate.
13467 (FullDelegateDesc): Implement.
13469 (VerifyApplicability): Implement.
13471 * expression.cs (Invocation::DoResolve): Update to accordingly handle
13472 delegate invocations too.
13474 (Invocation::Emit): Ditto.
13476 * ../errors/cs1593.cs : Added.
13478 * ../errors/cs1594.cs : Added.
13480 * delegate.cs (InstanceExpression, TargetMethod): New properties.
13482 2001-10-16 Ravi Pratap <ravi@ximian.com>
13484 * typemanager.cs (intptr_type): Core type for System.IntPtr
13486 (InitCoreTypes): Update for the same.
13488 (iasyncresult_type, asynccallback_type): Ditto.
13490 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
13493 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
13496 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
13497 the builders for the 4 members of a delegate type :-)
13499 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
13502 * expression.cs (New::DoResolve): Implement guts for delegate creation.
13504 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
13506 2001-10-15 Miguel de Icaza <miguel@ximian.com>
13508 * statement.cs (Break::Emit): Implement.
13509 (Continue::Emit): Implement.
13511 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
13512 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
13513 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
13514 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
13517 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
13518 properties that track the label for the current loop (begin of the
13519 loop and end of the loop).
13521 2001-10-15 Ravi Pratap <ravi@ximian.com>
13523 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
13524 use of emitting anything at all.
13526 * class.cs, rootcontext.cs : Get rid of calls to the same.
13528 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
13530 (Populate): Define the constructor correctly and set the implementation
13533 * typemanager.cs (delegate_types): New hashtable to hold delegates that
13536 (AddDelegateType): Implement.
13538 (IsDelegateType): Implement helper method.
13540 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
13542 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
13543 and accordingly handle it.
13545 * delegate.cs (Populate): Take TypeContainer argument.
13546 Implement bits to define the Invoke method. However, I still haven't figured out
13547 how to take care of the native int bit :-(
13549 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
13550 Qualify the name of the delegate, not its return type !
13552 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
13555 (StandardConversionExists): Checking for array types turns out to be recursive.
13557 (ConvertReferenceExplicit): Implement array conversion.
13559 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
13561 2001-10-12 Ravi Pratap <ravi@ximian.com>
13563 * cs-parser.jay (delegate_declaration): Store the fully qualified
13564 name as it is a type declaration.
13566 * delegate.cs (ReturnType, Name): Rename members to these. Make them
13569 (DefineDelegate): Renamed from Define. Does the same thing essentially,
13570 as TypeContainer::DefineType.
13572 (Populate): Method in which all the definition of the various methods (Invoke)
13575 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
13578 (CloseDelegate): Finally creates the delegate.
13580 * class.cs (TypeContainer::DefineType): Update to define delegates.
13581 (Populate, Emit and CloseType): Do the same thing here too.
13583 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
13584 delegates in all these operations.
13586 2001-10-14 Miguel de Icaza <miguel@ximian.com>
13588 * expression.cs: LocalTemporary: a new expression used to
13589 reference a temporary that has been created.
13591 * assign.cs: Handle PropertyAccess back here, so that we can
13592 provide the proper semantic access to properties.
13594 * expression.cs (Expression::ConvertReferenceExplicit): Implement
13595 a few more explicit conversions.
13597 * modifiers.cs: `NEW' modifier maps to HideBySig.
13599 * expression.cs (PropertyExpr): Make this into an
13600 ExpressionStatement, and support the EmitStatement code path.
13602 Perform get/set error checking, clean up the interface.
13604 * assign.cs: recognize PropertyExprs as targets, and if so, turn
13605 them into toplevel access objects.
13607 2001-10-12 Miguel de Icaza <miguel@ximian.com>
13609 * expression.cs: PropertyExpr::PropertyExpr: use work around the
13612 * typemanager.cs: Keep track here of our PropertyBuilders again to
13613 work around lameness in SRE.
13615 2001-10-11 Miguel de Icaza <miguel@ximian.com>
13617 * expression.cs (LValue::LValueResolve): New method in the
13618 interface, used to perform a second resolution pass for LValues.
13620 (This::DoResolve): Catch the use of this in static methods.
13622 (This::LValueResolve): Implement.
13624 (This::Store): Remove warning, assigning to `this' in structures
13627 (Invocation::Emit): Deal with invocation of
13628 methods on value types. We need to pass the address to structure
13629 methods rather than the object itself. (The equivalent code to
13630 emit "this" for structures leaves the entire structure on the
13631 stack instead of a pointer to it).
13633 (ParameterReference::DoResolve): Compute the real index for the
13634 argument based on whether the method takes or not a `this' pointer
13635 (ie, the method is static).
13637 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
13638 value types returned from functions when we need to invoke a
13639 method on the sturcture.
13642 2001-10-11 Ravi Pratap <ravi@ximian.com>
13644 * class.cs (TypeContainer::DefineType): Method to actually do the business of
13645 defining the type in the Modulebuilder or Typebuilder. This is to take
13646 care of nested types which need to be defined on the TypeBuilder using
13647 DefineNestedMethod.
13649 (TypeContainer::GetClassBases): Implement. Essentially the code from the
13650 methods in RootContext, only ported to be part of TypeContainer.
13652 (TypeContainer::GetInterfaceOrClass): Ditto.
13654 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
13656 * interface.cs (Interface::DefineInterface): New method. Does exactly
13657 what RootContext.CreateInterface did earlier, only it takes care of nested types
13660 (Interface::GetInterfaces): Move from RootContext here and port.
13662 (Interface::GetInterfaceByName): Same here.
13664 * rootcontext.cs (ResolveTree): Re-write.
13666 (PopulateTypes): Re-write.
13668 * class.cs (TypeContainer::Populate): Populate nested types too.
13669 (TypeContainer::Emit): Emit nested members too.
13671 * typemanager.cs (AddUserType): Do not make use of the FullName property,
13672 instead just use the name argument passed in as it is already fully
13675 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
13676 to TypeContainer mapping to see if a type is user-defined.
13678 * class.cs (TypeContainer::CloseType): Implement.
13680 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
13681 the default constructor.
13683 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
13686 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
13688 * interface.cs (CloseType): Create the type here.
13690 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
13693 Remove all the methods which are now in TypeContainer.
13695 2001-10-10 Ravi Pratap <ravi@ximian.com>
13697 * delegate.cs (Define): Re-write bits to define the delegate
13700 2001-10-10 Miguel de Icaza <miguel@ximian.com>
13702 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
13704 * expression.cs (ImplicitReferenceConversion): handle null as well
13705 as a source to convert to any reference type.
13707 * statement.cs (Return): Perform any implicit conversions to
13708 expected return type.
13710 Validate use of return statement.
13712 * codegen.cs (EmitContext): Pass the expected return type here.
13714 * class.cs (Method, Constructor, Property): Pass expected return
13715 type to EmitContext.
13717 2001-10-09 Miguel de Icaza <miguel@ximian.com>
13719 * expression.cs: Make DoResolve take an EmitContext instead of a
13722 Replaced `l' and `location' for `loc', for consistency.
13724 (Error, Warning): Remove unneeded Tc argument.
13726 * assign.cs, literal.cs, constant.cs: Update to new calling
13729 * codegen.cs: EmitContext now contains a flag indicating whether
13730 code is being generated in a static method or not.
13732 * cs-parser.jay: DecomposeQI, new function that replaces the old
13733 QualifiedIdentifier. Now we always decompose the assembled
13734 strings from qualified_identifier productions into a group of
13737 2001-10-08 Miguel de Icaza <miguel@ximian.com>
13739 * rootcontext.cs: Deal with field-less struct types correctly now
13740 by passing the size option to Define Type.
13742 * class.cs: Removed hack that created one static field.
13744 2001-10-07 Miguel de Icaza <miguel@ximian.com>
13746 * statement.cs: Moved most of the code generation here.
13748 2001-10-09 Ravi Pratap <ravi@ximian.com>
13750 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
13753 (ElementAccess): Remove useless bits for now - keep checks as the spec
13756 2001-10-08 Ravi Pratap <ravi@ximian.com>
13758 * expression.cs (ElementAccess::DoResolve): Remove my crap code
13759 and start performing checks according to the spec.
13761 2001-10-07 Ravi Pratap <ravi@ximian.com>
13763 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
13764 rank_specifiers instead.
13766 (rank_specifiers): Change the order in which the rank specifiers are stored
13768 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
13770 * expression.cs (ElementAccess): Implement the LValue interface too.
13772 2001-10-06 Ravi Pratap <ravi@ximian.com>
13774 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
13775 except that user defined conversions are not included.
13777 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
13778 perform the conversion of the return type, if necessary.
13780 (New::DoResolve): Check whether we are creating an array or an object
13781 and accordingly do the needful.
13783 (New::Emit): Same here.
13785 (New::DoResolve): Implement guts of array creation.
13787 (New::FormLookupType): Helper function.
13789 2001-10-07 Miguel de Icaza <miguel@ximian.com>
13791 * codegen.cs: Removed most of the code generation here, and move the
13792 corresponding code generation bits to the statement classes.
13794 Added support for try/catch/finalize and throw.
13796 * cs-parser.jay: Added support for try/catch/finalize.
13798 * class.cs: Catch static methods having the flags override,
13799 virtual or abstract.
13801 * expression.cs (UserCast): This user cast was not really doing
13802 what it was supposed to do. Which is to be born in fully resolved
13803 state. Parts of the resolution were being performed at Emit time!
13807 2001-10-05 Miguel de Icaza <miguel@ximian.com>
13809 * expression.cs: Implicity convert the result from UserCast.
13811 2001-10-05 Ravi Pratap <ravi@ximian.com>
13813 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
13814 prevented it from working correctly.
13816 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
13817 merely ConvertImplicit.
13819 2001-10-05 Miguel de Icaza <miguel@ximian.com>
13821 * typemanager.cs: Make the LookupTypeContainer function static,
13822 and not per-instance.
13824 * class.cs: Make static FindMembers (the one that takes a Type
13827 * codegen.cs: Add EmitForeach here.
13829 * cs-parser.jay: Make foreach a toplevel object instead of the
13830 inline expansion, as we need to perform semantic analysis on it.
13832 2001-10-05 Ravi Pratap <ravi@ximian.com>
13834 * expression.cs (Expression::ImplicitUserConversion): Rename to
13835 UserDefinedConversion.
13837 (Expression::UserDefinedConversion): Take an extra argument specifying
13838 whether we look for explicit user conversions too.
13840 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
13842 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
13844 (ExplicitUserConversion): Make it a call to UserDefinedConversion
13845 with the appropriate arguments.
13847 * cs-parser.jay (cast_expression): Record location too.
13849 * expression.cs (Cast): Record location info.
13851 (Expression::ConvertExplicit): Take location argument.
13853 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
13854 to determine if we are doing explicit conversions.
13856 (UserCast::Emit): Update accordingly.
13858 (Expression::ConvertExplicit): Report an error if everything fails.
13860 * ../errors/cs0030.cs : Add.
13862 2001-10-04 Miguel de Icaza <miguel@ximian.com>
13864 * modifiers.cs: If the ABSTRACT keyword is present, also set the
13865 virtual and newslot bits.
13867 * class.cs (TypeContainer::RegisterRequiredImplementations):
13868 Record methods we need.
13870 (TypeContainer::MakeKey): Helper function to make keys for
13871 MethodBases, since the Methodbase key is useless.
13873 (TypeContainer::Populate): Call RegisterRequiredImplementations
13874 before defining the methods.
13876 Create a mapping for method_builders_to_methods ahead of time
13877 instead of inside a tight loop.
13879 (::RequireMethods): Accept an object as the data to set into the
13880 hashtable so we can report interface vs abstract method mismatch.
13882 2001-10-03 Miguel de Icaza <miguel@ximian.com>
13884 * report.cs: Make all of it static.
13886 * rootcontext.cs: Drop object_type and value_type computations, as
13887 we have those in the TypeManager anyways.
13889 Drop report instance variable too, now it is a global.
13891 * driver.cs: Use try/catch on command line handling.
13893 Add --probe option to debug the error reporting system with a test
13896 * report.cs: Add support for exiting program when a probe
13897 condition is reached.
13899 2001-10-03 Ravi Pratap <ravi@ximian.com>
13901 * expression.cs (Binary::DoNumericPromotions): Fix the case when
13902 we do a forcible conversion regardless of type, to check if
13903 ForceConversion returns a null.
13905 (Binary::error19): Use location to report error.
13907 (Unary::error23): Use location here too.
13909 * ../errors/cs0019.cs : Check in.
13911 * ../errors/cs0023.cs : Check in.
13913 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
13914 case of a non-null MethodInfo object with a length of 0 !
13916 (Binary::ResolveOperator): Flag error if overload resolution fails to find
13917 an applicable member - according to the spec :-)
13918 Also fix logic to find members in base types.
13920 (Unary::ResolveOperator): Same here.
13922 (Unary::report23): Change name to error23 and make first argument a TypeContainer
13923 as I was getting thoroughly confused between this and error19 :-)
13925 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
13926 (::FindMostEncompassedType): Implement.
13927 (::FindMostEncompassingType): Implement.
13928 (::StandardConversionExists): Implement.
13930 (UserImplicitCast): Re-vamp. We now need info about most specific
13931 source and target types so that we can do the necessary conversions.
13933 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
13934 mathematical union with no duplicates.
13936 2001-10-03 Miguel de Icaza <miguel@ximian.com>
13938 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
13939 in order from base classes to child classes, so that we can in
13940 child classes look up in our parent for method names and
13941 attributes (required for handling abstract, virtual, new, override
13942 constructs: we need to instrospect our base class, and if we dont
13943 populate the classes in order, the introspection might be
13944 incorrect. For example, a method could query its parent before
13945 the parent has any methods and would determine that the parent has
13946 no abstract methods (while it could have had them)).
13948 (RootContext::CreateType): Record the order in which we define the
13951 2001-10-02 Miguel de Icaza <miguel@ximian.com>
13953 * class.cs (TypeContainer::Populate): Also method definitions can
13954 fail now, keep track of this.
13956 (TypeContainer::FindMembers): Implement support for
13957 DeclaredOnly/noDeclaredOnly flag.
13959 (Constructor::Emit) Return the ConstructorBuilder.
13961 (Method::Emit) Return the MethodBuilder.
13962 Check for abstract or virtual methods to be public.
13964 * rootcontext.cs (RootContext::CreateType): Register all the
13965 abstract methods required for the class to be complete and the
13966 interface methods that must be implemented.
13968 * cs-parser.jay: Report error 501 (method requires body if it is
13969 not marked abstract or extern).
13971 * expression.cs (TypeOf::Emit): Implement.
13973 * typemanager.cs: runtime_handle_type, new global type.
13975 * class.cs (Property::Emit): Generate code for properties.
13977 2001-10-02 Ravi Pratap <ravi@ximian.com>
13979 * expression.cs (Unary::ResolveOperator): Find operators on base type
13980 too - we now conform exactly to the spec.
13982 (Binary::ResolveOperator): Same here.
13984 * class.cs (Operator::Define): Fix minor quirk in the tests.
13986 * ../errors/cs0215.cs : Added.
13988 * ../errors/cs0556.cs : Added.
13990 * ../errors/cs0555.cs : Added.
13992 2001-10-01 Miguel de Icaza <miguel@ximian.com>
13994 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
13995 single integer which is really efficient
13997 2001-10-01 Ravi Pratap <ravi@ximian.com>
13999 * expression.cs (Expression::ImplicitUserConversion): Use location
14000 even in the case when we are examining True operators.
14002 * class.cs (Operator::Define): Perform extensive checks to conform
14003 with the rules for operator overloading in the spec.
14005 * expression.cs (Expression::ImplicitReferenceConversion): Implement
14006 some of the other conversions mentioned in the spec.
14008 * typemanager.cs (array_type): New static member for the System.Array built-in
14011 (cloneable_interface): For System.ICloneable interface.
14013 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
14014 we start resolving the tree and populating types.
14016 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
14018 2001-10-01 Miguel de Icaza <miguel@ximian.com>
14020 * expression.cs (Expression::ExprClassFromMemberInfo,
14021 Expression::Literalize): Create literal expressions from
14022 FieldInfos which are literals.
14024 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
14025 type casts, because they were wrong. The test suite in tests
14028 (ImplicitNumericConversion): ushort to ulong requires a widening
14031 Int32 constant to long requires widening cast as well.
14033 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
14034 for integers because the type on the stack is not i4.
14036 2001-09-30 Miguel de Icaza <miguel@ximian.com>
14038 * expression.cs (report118): require location argument.
14040 * parameter.cs: Do not dereference potential null value.
14042 * class.cs: Catch methods that lack the `new' keyword when
14043 overriding a name. Report warnings when `new' is used without
14044 anything being there to override.
14046 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
14048 * class.cs: Only add constructor to hashtable if it is non-null
14049 (as now constructors can fail on define).
14051 (TypeManager, Class, Struct): Take location arguments.
14053 Catch field instance initialization in structs as errors.
14055 accepting_filter: a new filter for FindMembers that is static so
14056 that we dont create an instance per invocation.
14058 (Constructor::Define): Catch errors where a struct constructor is
14061 * cs-parser.jay: Pass location information for various new
14064 * delegate.cs (Delegate): take a location argument.
14066 * driver.cs: Do not call EmitCode if there were problesm in the
14067 Definition of the types, as many Builders wont be there.
14069 * decl.cs (Decl::Decl): Require a location argument.
14071 * cs-tokenizer.cs: Handle properly hex constants that can not fit
14072 into integers, and find the most appropiate integer for it.
14074 * literal.cs: Implement ULongLiteral.
14076 * rootcontext.cs: Provide better information about the location of
14077 failure when CreateType fails.
14079 2001-09-29 Miguel de Icaza <miguel@ximian.com>
14081 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
14084 * expression.cs (Binary::CheckShiftArguments): Add missing type
14086 (Binary::ResolveOperator): Add type to the logical and and logical
14087 or, Bitwise And/Or and Exclusive Or code paths, it was missing
14090 (Binary::DoNumericPromotions): In the case where either argument
14091 is ulong (and most signed types combined with ulong cause an
14092 error) perform implicit integer constant conversions as well.
14094 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14096 * expression.cs (UserImplicitCast): Method should always be
14098 (Invocation::BetterConversion): Simplified test for IntLiteral.
14100 (Expression::ImplicitNumericConversion): Split this routine out.
14101 Put the code that performs implicit constant integer conversions
14104 (Expression::Resolve): Become a wrapper around DoResolve so we can
14105 check eclass and type being set after resolve.
14107 (Invocation::Badness): Remove this dead function
14109 (Binary::ResolveOperator): Do not compute the expensive argumnets
14110 unless we have a union for it.
14112 (Probe::Emit): Is needs to do an isinst and then
14113 compare against null.
14115 (::CanConvert): Added Location argument. If the Location argument
14116 is null (Location.Null), then we do not report errors. This is
14117 used by the `probe' mechanism of the Explicit conversion. We do
14118 not want to generate an error for something that the user
14119 explicitly requested to be casted. But the pipeline for an
14120 explicit cast first tests for potential implicit casts.
14122 So for now, if the Location is null, it means `Probe only' to
14123 avoid adding another argument. Might have to revise this
14126 (ClassCast): New class used to type cast objects into arbitrary
14127 classes (used in Explicit Reference Conversions).
14129 Implement `as' as well.
14131 Reverted all the patches from Ravi below: they were broken:
14133 * The use of `level' as a mechanism to stop recursive
14134 invocations is wrong. That was there just to catch the
14135 bug with a strack trace but not as a way of addressing
14138 To fix the problem we have to *understand* what is going
14139 on and the interactions and come up with a plan, not
14140 just get things going.
14142 * The use of the type conversion cache that I proposed
14143 last night had an open topic: How does this work across
14144 protection domains. A user defined conversion might not
14145 be public in the location where we are applying the
14146 conversion, a different conversion might be selected
14147 (ie, private A->B (better) but public B->A (worse),
14148 inside A, A->B applies, but outside it, B->A will
14151 * On top of that (ie, even if the above is solved),
14152 conversions in a cache need to be abstract. Ie, `To
14153 convert from an Int to a Short use an OpcodeCast', not
14154 `To convert from an Int to a Short use the OpcodeCast on
14155 the variable 5' (which is what this patch was doing).
14157 2001-09-28 Ravi Pratap <ravi@ximian.com>
14159 * expression.cs (Invocation::ConversionExists): Re-write to use
14160 the conversion cache
14162 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
14163 cache all conversions done, not just user-defined ones.
14165 (Invocation::BetterConversion): The real culprit. Use ConversionExists
14166 to determine if a conversion exists instead of acutually trying to
14167 perform the conversion. It's faster too.
14169 (Expression::ConvertExplicit): Modify to use ConversionExists to check
14170 and only then attempt the implicit conversion.
14172 2001-09-28 Ravi Pratap <ravi@ximian.com>
14174 * expression.cs (ConvertImplicit): Use a cache for conversions
14175 already found. Check level of recursion and bail out if necessary.
14177 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14179 * typemanager.cs (string_concat_string_string, string_concat_object_object):
14180 Export standard methods that we expect for string operations.
14182 * statement.cs (Block::UsageWarning): Track usage of variables and
14183 report the errors for not used variables.
14185 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
14188 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14190 * codegen.cs: remove unnneded code
14192 * expression.cs: Removed BuiltinTypeAccess class
14194 Fix the order in which implicit conversions are
14197 The previous fixed dropped support for boxed conversions (adding a
14198 test to the test suite now)
14200 (UserImplicitCast::CanConvert): Remove test for source being null,
14201 that code is broken. We should not feed a null to begin with, if
14202 we do, then we should track the bug where the problem originates
14203 and not try to cover it up here.
14205 Return a resolved expression of type UserImplicitCast on success
14206 rather than true/false. Ravi: this is what I was talking about,
14207 the pattern is to use a static method as a "constructor" for
14210 Also, do not create arguments until the very last minute,
14211 otherwise we always create the arguments even for lookups that
14212 will never be performed.
14214 (UserImplicitCast::Resolve): Eliminate, objects of type
14215 UserImplicitCast are born in a fully resolved state.
14217 * typemanager.cs (InitCoreTypes): Init also value_type
14218 (System.ValueType).
14220 * expression.cs (Cast::Resolve): First resolve the child expression.
14222 (LValue): Add new method AddressOf to be used by
14225 Change the argument of Store to take an EmitContext instead of an
14226 ILGenerator, because things like FieldExpr need to be able to call
14227 their children expression to generate the instance code.
14229 (Expression::Error, Expression::Warning): Sugar functions for
14232 (Expression::MemberLookup): Accept a TypeContainer instead of a
14233 Report as the first argument.
14235 (Expression::ResolvePrimary): Killed. I still want to improve
14236 this as currently the code is just not right.
14238 (Expression::ResolveMemberAccess): Simplify, but it is still
14241 (Unary::Resolve): Catch errors in AddressOf operators.
14243 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
14244 index to a byte for the short-version, or the compiler will choose
14245 the wrong Emit call, which generates the wrong data.
14247 (ParameterReference::Emit, ::Store): same.
14249 (FieldExpr::AddressOf): Implement.
14251 * typemanager.cs: TypeManager: made public variable instead of
14254 * driver.cs: document --fatal.
14256 * report.cs (ErrorMessage, WarningMessage): new names for the old
14257 Error and Warning classes.
14259 * cs-parser.jay (member_access): Turn built-in access to types
14260 into a normal simplename
14262 2001-09-27 Ravi Pratap <ravi@ximian.com>
14264 * expression.cs (Invocation::BetterConversion): Fix to cope
14265 with q being null, since this was introducing a bug.
14267 * expression.cs (ConvertImplicit): Do built-in conversions first.
14269 2001-09-27 Ravi Pratap <ravi@ximian.com>
14271 * expression.cs (UserImplicitCast::Resolve): Fix bug.
14273 2001-09-27 Ravi Pratap <ravi@ximian.com>
14275 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
14276 I had introduced long ago (what's new ?).
14278 * expression.cs (UserImplicitCast::CanConvert): Static method to do
14279 the work of all the checking.
14280 (ConvertImplicit): Call CanConvert and only then create object if necessary.
14281 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
14283 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
14284 that is the right way.
14286 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
14287 overloading resolution. Use everywhere instead of cutting and pasting code.
14289 (Binary::ResolveOperator): Use MakeUnionSet.
14291 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
14292 we have to convert to bool types. Not complete yet.
14294 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14296 * typemanager.cs (TypeManager::CSharpName): support ushort.
14298 * expression.cs (Expression::TryImplicitIntConversion): Attempts
14299 to provide an expression that performsn an implicit constant int
14300 conversion (section 6.1.6).
14301 (Expression::ConvertImplicitRequired): Reworked to include
14302 implicit constant expression conversions.
14304 (Expression::ConvertNumericExplicit): Finished.
14306 (Invocation::Emit): If InstanceExpression is null, then it means
14307 that we perform a call on this.
14309 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14311 * expression.cs (Unary::Emit): Remove some dead code.
14312 (Probe): Implement Resolve and Emit for `is'.
14313 (Expression::ConvertImplicitRequired): Attempt to do constant
14314 expression conversions here. Maybe should be moved to
14315 ConvertImplicit, but I am not sure.
14316 (Expression::ImplicitLongConstantConversionPossible,
14317 Expression::ImplicitIntConstantConversionPossible): New functions
14318 that tell whether is it possible to apply an implicit constant
14319 expression conversion.
14321 (ConvertNumericExplicit): Started work on explicit numeric
14324 * cs-parser.jay: Update operator constants.
14326 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
14327 (Parameters::GetSignature): Hook up VerifyArgs here.
14328 (Parameters::VerifyArgs): Verifies that no two arguments have the
14331 * class.cs (Operator): Update the operator names to reflect the
14332 ones that the spec expects (as we are just stringizing the
14335 * expression.cs (Unary::ResolveOperator): Fix bug: Use
14336 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
14337 previous usage did only work for our methods.
14338 (Expression::ConvertImplicit): Handle decimal implicit numeric
14339 conversions as well.
14340 (Expression::InternalTypeConstructor): Used to invoke constructors
14341 on internal types for default promotions.
14343 (Unary::Emit): Implement special handling for the pre/post
14344 increment/decrement for overloaded operators, as they need to have
14345 the same semantics as the other operators.
14347 (Binary::ResolveOperator): ditto.
14348 (Invocation::ConversionExists): ditto.
14349 (UserImplicitCast::Resolve): ditto.
14351 2001-09-26 Ravi Pratap <ravi@ximian.com>
14353 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
14354 operator, return after emitting body. Regression tests pass again !
14356 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
14357 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
14358 (Invocation::OverloadResolve): Ditto.
14359 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
14361 * everywhere : update calls to the above methods accordingly.
14363 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14365 * assign.cs (Assign): Make it inherit from ExpressionStatement.
14367 * expression.cs (ExpressionStatement): New base class used for
14368 expressions that can appear in statements, so that we can provide
14369 an alternate path to generate expression that do not leave a value
14372 (Expression::Emit, and all the derivatives): We no longer return
14373 whether a value is left on the stack or not. Every expression
14374 after being emitted leaves a single value on the stack.
14376 * codegen.cs (EmitContext::EmitStatementExpression): Use the
14377 facilties of ExpressionStatement if possible.
14379 * cs-parser.jay: Update statement_expression.
14381 2001-09-25 Miguel de Icaza <miguel@ximian.com>
14383 * driver.cs: Change the wording of message
14385 2001-09-25 Ravi Pratap <ravi@ximian.com>
14387 * expression.cs (Binary::ResolveOperator): Had forgottten to set
14388 the type of the expression to the return type of the method if
14389 we have an overloaded operator match ! The regression tests pass again !
14390 (Unary::ResolveOperator): Ditto.
14392 * expression.cs (Invocation::ConversionExists): Correct the member lookup
14393 to find "op_Implicit", not "implicit" ;-)
14394 (UserImplicitCast): New class to take care of user-defined implicit conversions.
14395 (ConvertImplicit, ForceConversion): Take TypeContainer argument
14397 * everywhere : Correct calls to the above accordingly.
14399 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
14400 (ConvertImplicit): Do user-defined conversion if it exists.
14402 2001-09-24 Miguel de Icaza <miguel@ximian.com>
14404 * assign.cs: track location.
14405 (Resolve): Use implicit conversions on assignment.
14407 * literal.cs: Oops. Not good, Emit of short access values should
14408 pass (Bytes) or the wrong argument will be selected.
14410 * expression.cs (Unary::Emit): Emit code for -expr.
14412 (Unary::ResolveOperator): Handle `Substract' for non-constants
14413 (substract from zero from the non-constants).
14414 Deal with Doubles as well.
14416 (Expression::ConvertImplicitRequired): New routine that reports an
14417 error if no implicit conversion exists.
14419 (Invocation::OverloadResolve): Store the converted implicit
14420 expressions if we make them
14422 2001-09-24 Ravi Pratap <ravi@ximian.com>
14424 * class.cs (ConstructorInitializer): Take a Location argument.
14425 (ConstructorBaseInitializer): Same here.
14426 (ConstructorThisInitializer): Same here.
14428 * cs-parser.jay : Update all calls accordingly.
14430 * expression.cs (Unary, Binary, New): Take location argument.
14431 Update accordingly everywhere.
14433 * cs-parser.jay : Update all calls to the above to take a location
14436 * class.cs : Ditto.
14438 2001-09-24 Ravi Pratap <ravi@ximian.com>
14440 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
14441 (Invocation::BetterConversion): Same here
14442 (Invocation::ConversionExists): Ditto.
14444 (Invocation::ConversionExists): Implement.
14446 2001-09-22 Ravi Pratap <ravi@ximian.com>
14448 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
14449 Also take an additional TypeContainer argument.
14451 * All over : Pass in TypeContainer as argument to OverloadResolve.
14453 * typemanager.cs (CSharpName): Update to check for the string type and return
14456 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
14459 2001-09-21 Ravi Pratap <ravi@ximian.com>
14461 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
14462 (Invocation::BetterFunction): Implement.
14463 (Invocation::BetterConversion): Implement.
14464 (Invocation::ConversionExists): Skeleton, no implementation yet.
14466 Okay, things work fine !
14468 2001-09-21 Miguel de Icaza <miguel@ximian.com>
14470 * typemanager.cs: declare and load enum_type, delegate_type and
14473 * expression.cs (Expression::Emit): Now emit returns a value that
14474 tells whether a value is left on the stack or not. This strategy
14475 might be reveted tomorrow with a mechanism that would address
14476 multiple assignments.
14477 (Expression::report118): Utility routine to report mismatches on
14480 (Unary::Report23): Report impossible type/operator combination
14483 (Unary::IsIncrementableNumber): Whether the type can be
14484 incremented or decremented with add.
14485 (Unary::ResolveOperator): Also allow enumerations to be bitwise
14487 (Unary::ResolveOperator): Implement ++, !, ~,
14489 (Invocation::Emit): Deal with new Emit convetion.
14491 * All Expression derivatives: Updated their Emit method to return
14492 whether they leave values on the stack or not.
14494 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
14495 stack for expressions that are statements.
14497 2001-09-20 Miguel de Icaza <miguel@ximian.com>
14499 * expression.cs (LValue): New interface. Must be implemented by
14501 (LocalVariableReference, ParameterReference, FieldExpr): Implement
14504 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
14505 interface for generating code, simplifies the code.
14507 2001-09-20 Ravi Pratap <ravi@ximian.com>
14509 * expression.cs (everywhere): Comment out return statements in ::Resolve
14510 methods to avoid the warnings.
14512 2001-09-20 Miguel de Icaza <miguel@ximian.com>
14514 * driver.cs (parse): Report error 2001 if we can not open the
14517 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
14520 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
14523 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
14524 otherwise nested blocks end up with the same index.
14526 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
14528 * expression.cs: Instead of having FIXMEs in the Resolve
14529 functions, throw exceptions so it is obvious that we are facing a
14532 * cs-parser.jay (invocation_expression): Pass Location information.
14534 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
14535 Use a basename for those routines because .NET does not like paths
14538 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
14541 2001-09-19 Miguel de Icaza <miguel@ximian.com>
14543 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
14544 are loading the correct data types (throws an exception if not).
14545 (TypeManager::InitCoreTypes): Use CoreLookupType
14547 * expression.cs (Unary::ResolveOperator): return the child
14548 expression for expressions which are just +expr.
14549 (Unary::ResolveOperator): Return negative literals for -LITERAL
14550 expressions (otherwise they are Unary {Literal}).
14551 (Invocation::Badness): Take into account `Implicit constant
14552 expression conversions'.
14554 * literal.cs (LongLiteral): Implement long literal class.
14555 (IntLiteral): export the `Value' of the intliteral.
14557 2001-09-19 Ravi Pratap <ravi@ximian.com>
14559 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
14561 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
14562 instead of 'Operator'
14564 * expression.cs (Binary::ResolveOperator): Update accordingly.
14565 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
14568 * cs-parser.jay (unary_expression): Update to use the new names.
14570 * gen-treedump.cs (GetUnary): Same here.
14572 * expression.cs (Unary::Resolve): Implement.
14573 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
14574 operators are found instead of making noise ;-)
14575 (Unary::ResolveOperator): New method to do precisely the same thing which
14576 Binary::ResolveOperator does for Binary expressions.
14577 (Unary.method, .Arguments): Add.
14578 (Unary::OperName): Implement.
14579 (Unary::ForceConversion): Copy and Paste !
14581 * class.cs (Operator::Define): Fix a small bug for the case when we have
14584 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
14585 for the inbuilt operators. Only overloading works for now ;-)
14587 2001-09-18 Miguel de Icaza <miguel@ximian.com>
14589 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
14590 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
14592 * expression.cs (This::Emit): Implement.
14593 (This::Resolve): Implement.
14594 (TypeOf:Resolve): Implement.
14595 (Expression::ResolveSimpleName): Add an implicit this to instance
14597 (MemberAccess::Resolve): Deal with Parameters and Fields.
14598 Bind instance variable to Field expressions.
14599 (FieldExpr::Instance): New field used to track the expression that
14600 represents the object instance.
14601 (FieldExpr::Resolve): Track potential errors from MemberLookup not
14603 (FieldExpr::Emit): Implement.
14605 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
14606 the last instruction contains a return opcode to avoid generating
14607 the last `ret' instruction (this generates correct code, and it is
14608 nice to pass the peverify output).
14610 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
14611 initializer for static and instance variables.
14612 (Constructor::Emit): Allow initializer to be null in the case of
14613 static constructors. Only emit initializer for instance
14616 (TypeContainer::FindMembers): Return a null array if there are no
14619 Also fix the code for the MemberTypes.Method branch, as it was not
14620 scanning that for operators (or tried to access null variables before).
14622 * assign.cs (Assign::Emit): Handle instance and static fields.
14626 * driver.cs: Stop compilation if there are parse errors.
14628 * cs-parser.jay (constructor_declaration): Provide default base
14629 initializer for non-static constructors.
14630 (constructor_declarator): Do not provide a default base
14631 initializers if none was specified.
14632 Catch the fact that constructors should not have parameters.
14634 * class.cs: Do not emit parent class initializers for static
14635 constructors, that should be flagged as an error.
14637 2001-09-18 Ravi Pratap <ravi@ximian.com>
14639 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
14640 Move back code into TypeContainer::Populate.
14642 2001-09-18 Ravi Pratap <ravi@ximian.com>
14644 * class.cs (TypeContainer::AddConstructor): Fix the check to
14645 compare against Name, not Basename.
14646 (Operator::OpType): Change Plus and Minus to Add and Subtract.
14648 * cs-parser.jay : Update accordingly.
14650 * class.cs (TypeContainer::FindMembers): For the case where we are searching
14651 for methods, don't forget to look into the operators too.
14652 (RegisterMethodBuilder): Helper method to take care of this for
14653 methods, constructors and operators.
14654 (Operator::Define): Completely revamp.
14655 (Operator.OperatorMethod, MethodName): New fields.
14656 (TypeContainer::Populate): Move the registering of builders into
14657 RegisterMethodBuilder.
14658 (Operator::Emit): Re-write.
14660 * expression.cs (Binary::Emit): Comment out code path to emit method
14661 invocation stuff for the case when we have a user defined operator. I am
14662 just not able to get it right !
14664 2001-09-17 Miguel de Icaza <miguel@ximian.com>
14666 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
14669 (Expression::MemberLookup): Provide a version that allows to
14670 specify the MemberTypes and BindingFlags.
14672 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
14673 so it was not fetching variable information from outer blocks.
14675 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
14676 Beforefieldinit as it was buggy.
14678 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
14679 that Ravi put here.
14681 * class.cs (Constructor::Emit): Only emit if block is not null.
14682 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
14683 deal with this by semantically definining it as if the user had
14686 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
14687 constructors as we now "emit" them at a higher level.
14689 (TypeContainer::DefineDefaultConstructor): Used to define the
14690 default constructors if none was provided.
14692 (ConstructorInitializer): Add methods Resolve and Emit.
14694 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
14696 2001-09-17 Ravi Pratap <ravi@ximian.com>
14698 * class.cs (TypeContainer::EmitDefaultConstructor): Register
14699 the default constructor builder with our hashtable for methodbuilders
14702 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
14703 and argument_count is 0 in which case we have a match.
14704 (Binary::ResolveOperator): More null checking and miscellaneous coding
14707 2001-09-17 Ravi Pratap <ravi@ximian.com>
14709 * rootcontext.cs (IsNameSpace): Compare against null.
14711 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
14713 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
14714 and Unary::Operator.
14716 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
14719 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
14720 we have overloaded operators.
14721 (Binary::ResolveOperator): Implement the part which does the operator overload
14724 * class.cs (Operator::Emit): Implement.
14725 (TypeContainer::Emit): Emit the operators we have too.
14727 * expression.cs (Binary::Emit): Update to emit the appropriate code for
14728 the case when we have a user-defined operator.
14730 2001-09-17 Miguel de Icaza <miguel@ximian.com>
14732 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
14734 2001-09-16 Ravi Pratap <ravi@ximian.com>
14736 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
14737 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
14738 (Constructor::Emit): Implement.
14739 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
14740 if we have no work to do.
14741 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
14744 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
14745 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
14747 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
14750 2001-09-15 Ravi Pratap <ravi@ximian.com>
14752 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
14754 (Tree::RecordNamespace): Method to do what the name says ;-)
14755 (Tree::Namespaces): Property to get at the namespaces hashtable.
14757 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
14760 * rootcontext.cs (IsNamespace): Fixed it :-)
14762 2001-09-14 Miguel de Icaza <miguel@ximian.com>
14764 * class.cs (TypeContainer::FindMembers): Add support for
14766 (MethodCore): New class that encapsulates both the shared aspects
14767 of a Constructor and a Method.
14768 (Method, Constructor): Factored pieces into MethodCore.
14770 * driver.cs: Added --fatal which makes errors throw exceptions.
14771 Load System assembly as well as part of the standard library.
14773 * report.cs: Allow throwing exceptions on errors for debugging.
14775 * modifiers.cs: Do not use `parent', instead use the real type
14776 container to evaluate permission settings.
14778 * class.cs: Put Ravi's patch back in. He is right, and we will
14779 have to cope with the
14781 2001-09-14 Ravi Pratap <ravi@ximian.com>
14783 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
14784 FamORAssem, not FamANDAssem.
14786 2001-09-14 Miguel de Icaza <miguel@ximian.com>
14788 * driver.cs: Added --parse option that only parses its input files
14791 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
14792 incorrect. IsTopLevel is not used to tell whether an object is
14793 root_types or not (that can be achieved by testing this ==
14794 root_types). But to see if this is a top-level *class* (not
14795 necessarly our "toplevel" container).
14797 2001-09-14 Ravi Pratap <ravi@ximian.com>
14799 * enum.cs (Enum::Define): Modify to call the Lookup method on the
14800 parent instead of a direct call to GetType.
14802 2001-09-14 Ravi Pratap <ravi@ximian.com>
14804 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
14805 Modifiers.TypeAttr. This should just be a call to that method.
14807 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
14808 object so that we can determine if we are top-level or not.
14810 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
14813 * enum.cs (Enum::Define): Ditto.
14815 * modifiers.cs (FieldAttr): Re-write.
14817 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
14818 (TypeContainer::HaveStaticConstructor): New property to provide access
14819 to precisely that info.
14821 * modifiers.cs (MethodAttr): Re-write.
14822 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
14824 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
14825 of top-level types as claimed.
14827 2001-09-13 Miguel de Icaza <miguel@ximian.com>
14829 * expression.cs (MemberLookup): Fruitless attempt to lookup
14830 constructors. Maybe I need to emit default constructors? That
14831 might be it (currently .NET emits this for me automatically).
14832 (Invocation::OverloadResolve): Cope with Arguments == null.
14833 (Invocation::EmitArguments): new function, shared by the new
14834 constructor and us.
14835 (Invocation::Emit): Handle static and instance methods. Emit
14836 proper call instruction for virtual or non-virtual invocations.
14837 (New::Emit): Implement.
14838 (New::Resolve): Implement.
14839 (MemberAccess:Resolve): Implement.
14840 (MethodGroupExpr::InstanceExpression): used conforming to the spec
14841 to track instances.
14842 (FieldExpr::Resolve): Set type.
14844 * support.cs: Handle empty arguments.
14846 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
14847 SimpleLookup): Auxiliary routines to help parse a qualifier
14850 Update qualifier_identifier rule.
14852 * codegen.cs: Removed debugging messages.
14854 * class.cs: Make this a global thing, this acts just as a "key" to
14855 objects that we might have around.
14857 (Populate): Only initialize method_builders_to_methods once.
14859 * expression.cs (PropertyExpr): Initialize type from the
14862 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
14863 Resolve pattern. Attempt to implicitly convert value to boolean.
14866 * expression.cs: Set the type for the int32/int32 argument case.
14867 (Binary::ResolveOperator): Set the return type to boolean for
14868 comparission operators
14870 * typemanager.cs: Remove debugging print code.
14872 (Invocation::Resolve): resolve type.
14874 * class.cs: Allocate a MemberInfo of the correct size, as the code
14875 elsewhere depends on the test to reflect the correct contents.
14877 (Method::) Keep track of parameters, due to System.Reflection holes
14879 (TypeContainer::Populate): Keep track of MethodBuilders to Method
14882 (TypeContainer::FindMembers): Use ArrayList and then copy an array
14883 of the exact size and return that.
14885 (Class::LookupMethodByBuilder): New function that maps
14886 MethodBuilders to its methods. Required to locate the information
14887 on methods because System.Reflection bit us again.
14889 * support.cs: New file, contains an interface ParameterData and
14890 two implementations: ReflectionParameters and InternalParameters
14891 used to access Parameter information. We will need to grow this
14894 * expression.cs (Invocation::GetParameterData): implement a cache
14895 and a wrapper around the ParameterData creation for methods.
14896 (Invocation::OverloadResolve): Use new code.
14898 2001-09-13 Ravi Pratap <ravi@ximian.com>
14900 * class.cs (TypeContainer::EmitField): Remove and move into
14901 (Field::Define): here and modify accordingly.
14902 (Field.FieldBuilder): New member.
14903 (TypeContainer::Populate): Update accordingly.
14904 (TypeContainer::FindMembers): Implement.
14906 2001-09-13 Miguel de Icaza <miguel@ximian.com>
14908 * statement.cs: (VariableInfo::VariableType): New field to be
14909 initialized with the full type once it is resolved.
14911 2001-09-12 Miguel de Icaza <miguel@ximian.com>
14913 * parameter.cs (GetParameterInfo): Use a type cache to compute
14914 things only once, and to reuse this information
14916 * expression.cs (LocalVariableReference::Emit): Implement.
14917 (OpcodeCast::Emit): fix.
14919 (ParameterReference::Resolve): Implement.
14920 (ParameterReference::Emit): Implement.
14922 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
14923 that are expressions need to stay as Expressions.
14925 * typemanager.cs (CSharpName): Returns the C# name of a type if
14928 * expression.cs (Expression::ConvertImplicit): New function that
14929 implements implicit type conversions.
14931 (Expression::ImplicitReferenceConversion): Implements implicit
14932 reference conversions.
14934 (EmptyCast): New type for transparent casts.
14936 (OpcodeCast): New type for casts of types that are performed with
14937 a sequence of bytecodes.
14939 (BoxedCast): New type used for casting value types into reference
14940 types. Emits a box opcode.
14942 (Binary::DoNumericPromotions): Implements numeric promotions of
14943 and computation of the Binary::Type.
14945 (Binary::EmitBranchable): Optimization.
14947 (Binary::Emit): Implement code emission for expressions.
14949 * typemanager.cs (TypeManager): Added two new core types: sbyte
14952 2001-09-12 Ravi Pratap <ravi@ximian.com>
14954 * class.cs (TypeContainer::FindMembers): Method which does exactly
14955 what Type.FindMembers does, only we don't have to use reflection. No
14956 implementation yet.
14958 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
14959 typecontainer objects as we need to get at them.
14960 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
14962 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
14963 typecontainer object.
14965 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
14966 of just a Report object.
14968 2001-09-11 Ravi Pratap <ravi@ximian.com>
14970 * class.cs (Event::Define): Go back to using the prefixes "add_" and
14972 (TypeContainer::Populate): Now define the delegates of the type too.
14973 (TypeContainer.Delegates): Property to access the list of delegates defined
14976 * delegates.cs (Delegate::Define): Implement partially.
14978 * modifiers.cs (TypeAttr): Handle more flags.
14980 2001-09-11 Ravi Pratap <ravi@ximian.com>
14982 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
14984 (Operator::Define): Re-write logic to get types by using the LookupType method
14985 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
14986 (Indexer::Define): Ditto.
14987 (Event::Define): Ditto.
14988 (Property::Define): Ditto.
14990 2001-09-10 Ravi Pratap <ravi@ximian.com>
14992 * class.cs (TypeContainer::Populate): Now define operators too.
14993 (TypeContainer.Operators): New property to access the list of operators
14995 (Operator.OperatorMethodBuilder): New member to hold the method builder
14996 for the operator we are defining.
14997 (Operator::Define): Implement.
14999 2001-09-10 Ravi Pratap <ravi@ximian.com>
15001 * class.cs (Event::Define): Make the prefixes of the accessor methods
15002 addOn_ and removeOn_
15004 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
15005 of the location being passed in too. Ideally, this should go later since all
15006 error reporting should be done through the Report object.
15008 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
15009 (Populate): Iterate thru the indexers we have and define them too.
15010 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
15011 for the get and set accessors.
15012 (Indexer::Define): Implement.
15014 2001-09-09 Miguel de Icaza <miguel@ximian.com>
15016 * expression.cs (Binary::Resolve): Beginning of it. I scratched
15017 my previous implementation, did not work.
15019 * typemanager.cs: Add a couple of missing types (the longs).
15021 * literal.cs: Use TypeManager.bool_type instead of getting it.
15023 * expression.cs (EventExpr): New kind of expressions.
15024 (Expressio::ExprClassFromMemberInfo): finish
15026 2001-09-08 Miguel de Icaza <miguel@ximian.com>
15028 * assign.cs: Emit stores to static fields differently.
15030 2001-09-08 Ravi Pratap <ravi@ximian.com>
15032 * Merge in changes and adjust code to tackle conflicts. Backed out my
15033 code in Assign::Resolve ;-)
15035 2001-09-08 Ravi Pratap <ravi@ximian.com>
15037 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
15038 instead Report.Error and also pass in the location.
15039 (CSharpParser::Lexer): New readonly property to return the reference
15040 to the Tokenizer object.
15041 (declare_local_variables): Use Report.Error with location instead of plain
15045 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
15046 (Operator.CheckBinaryOperator): Ditto.
15048 * cs-parser.jay (operator_declarator): Update accordingly.
15050 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
15051 (CheckBinaryOperator): Same here.
15053 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
15054 on the name without any prefixes of namespace names etc. This is because we
15055 already might have something already fully qualified like
15056 'System.Console.WriteLine'
15058 * assign.cs (Resolve): Begin implementation. Stuck ;-)
15060 2001-09-07 Ravi Pratap <ravi@ximian.com>
15062 * cs-tokenizer.cs (location): Return a string which also contains
15065 * expression.cs (ElementAccess): New class for expressions of the
15066 type 'element access.'
15067 (BaseAccess): New class for expressions of the type 'base access.'
15068 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
15071 * cs-parser.jay (element_access): Implement action.
15072 (base_access): Implement actions.
15073 (checked_expression, unchecked_expression): Implement.
15075 * cs-parser.jay (local_variable_type): Correct and implement.
15076 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
15078 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
15080 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
15081 name and the specifiers.
15083 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
15085 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
15086 making them all public ;-)
15088 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
15091 2001-09-07 Miguel de Icaza <miguel@ximian.com>
15093 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
15095 (FieldExpr, PropertyExprs): New resolved expressions.
15096 (SimpleName::MemberStaticCheck): Perform static checks for access
15097 to non-static fields on static methods. Maybe this should be
15098 generalized for MemberAccesses.
15099 (SimpleName::ResolveSimpleName): More work on simple name
15102 * cs-parser.jay (primary_expression/qualified_identifier): track
15103 the parameter index.
15105 * codegen.cs (CodeGen::Save): Catch save exception, report error.
15106 (EmitContext::EmitBoolExpression): Chain to expression generation
15107 instead of temporary hack.
15108 (::EmitStatementExpression): Put generic expression code generation.
15110 * assign.cs (Assign::Emit): Implement variable assignments to
15111 local variables, parameters and fields.
15113 2001-09-06 Miguel de Icaza <miguel@ximian.com>
15115 * statement.cs (Block::GetVariableInfo): New method, returns the
15116 VariableInfo for a variable name in a block.
15117 (Block::GetVariableType): Implement in terms of GetVariableInfo
15119 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
15120 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
15122 2001-09-06 Ravi Pratap <ravi@ximian.com>
15124 * cs-parser.jay (operator_declaration): Continue on my quest : update
15125 to take attributes argument.
15126 (event_declaration): Ditto.
15127 (enum_declaration): Ditto.
15128 (indexer_declaration): Ditto.
15130 * class.cs (Operator::Operator): Update constructor accordingly.
15131 (Event::Event): Ditto.
15133 * delegate.cs (Delegate::Delegate): Same here.
15135 * enum.cs (Enum::Enum): Same here.
15137 2001-09-05 Ravi Pratap <ravi@ximian.com>
15139 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
15141 * ../tests/cs0658.cs : New file to demonstrate error 0658.
15143 * attribute.cs (Attributes): New class to encapsulate all attributes which were
15144 being passed around as an arraylist.
15145 (Attributes::AddAttribute): Method to add attribute sections.
15147 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
15148 (struct_declaration): Update accordingly.
15149 (constant_declaration): Update.
15150 (field_declaration): Update.
15151 (method_header): Update.
15152 (fixed_parameter): Update.
15153 (parameter_array): Ditto.
15154 (property_declaration): Ditto.
15155 (destructor_declaration): Ditto.
15157 * class.cs (Struct::Struct): Update constructors accordingly.
15158 (Class::Class): Ditto.
15159 (Field::Field): Ditto.
15160 (Method::Method): Ditto.
15161 (Property::Property): Ditto.
15162 (TypeContainer::OptAttribute): update property's return type.
15164 * interface.cs (Interface.opt_attributes): New member.
15165 (Interface::Interface): Update to take the extra Attributes argument.
15167 * parameter.cs (Parameter::Parameter): Ditto.
15169 * constant.cs (Constant::Constant): Ditto.
15171 * interface.cs (InterfaceMemberBase): New OptAttributes field.
15172 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
15173 the attributes as a parameter.
15174 (InterfaceProperty): Update constructor call.
15175 (InterfaceEvent): Ditto.
15176 (InterfaceMethod): Ditto.
15177 (InterfaceIndexer): Ditto.
15179 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
15180 pass the attributes too.
15181 (interface_event_declaration): Ditto.
15182 (interface_property_declaration): Ditto.
15183 (interface_method_declaration): Ditto.
15184 (interface_declaration): Ditto.
15186 2001-09-05 Miguel de Icaza <miguel@ximian.com>
15188 * class.cs (Method::Define): Track the "static Main" definition to
15189 create an entry point.
15191 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
15192 EntryPoint if we find it.
15194 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
15195 (EmitContext::ig): Make this variable public.
15197 * driver.cs: Make the default output file be the first file name
15198 with the .exe extension.
15200 Detect empty compilations
15202 Handle various kinds of output targets. Handle --target and
15203 rename -t to --dumper.
15205 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
15206 methods inherited from Expression return now an Expression. This
15207 will is used during the tree rewriting as we resolve them during
15210 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
15211 the spec. Missing entirely is the information about
15212 accessability of elements of it.
15214 (Expression::ExprClassFromMemberInfo): New constructor for
15215 Expressions that creates a fully initialized Expression based on
15216 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
15219 (Invocation::Resolve): Begin implementing resolution of invocations.
15221 * literal.cs (StringLiteral): Implement Emit.
15223 2001-09-05 Ravi Pratap <ravi@ximian.com>
15225 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
15228 2001-09-04 Ravi Pratap <ravi@ximian.com>
15230 * cs-parser.jay (attribute_arguments): Implement actions.
15231 (attribute): Fix bug in production. Implement action.
15232 (attribute_list): Implement.
15233 (attribute_target): Implement.
15234 (attribute_target_specifier, opt_target_specifier): Implement
15235 (CheckAttributeTarget): New method to check if the attribute target
15237 (attribute_section): Implement.
15238 (opt_attributes): Implement.
15240 * attribute.cs : New file to handle attributes.
15241 (Attribute): Class to hold attribute info.
15243 * cs-parser.jay (opt_attribute_target_specifier): Remove production
15244 (attribute_section): Modify production to use 2 different rules to
15245 achieve the same thing. 1 s/r conflict down !
15246 Clean out commented, useless, non-reducing dimension_separator rules.
15248 * class.cs (TypeContainer.attributes): New member to hold list
15249 of attributes for a type.
15250 (Struct::Struct): Modify to take one more argument, the attribute list.
15251 (Class::Class): Ditto.
15252 (Field::Field): Ditto.
15253 (Method::Method): Ditto.
15254 (Property::Property): Ditto.
15256 * cs-parser.jay (struct_declaration): Update constructor call to
15257 pass in the attributes too.
15258 (class_declaration): Ditto.
15259 (constant_declaration): Ditto.
15260 (field_declaration): Ditto.
15261 (method_header): Ditto.
15262 (fixed_parameter): Ditto.
15263 (parameter_array): Ditto.
15264 (property_declaration): Ditto.
15266 * constant.cs (Constant::Constant): Update constructor similarly.
15267 Use System.Collections.
15269 * parameter.cs (Parameter::Parameter): Update as above.
15271 2001-09-02 Ravi Pratap <ravi@ximian.com>
15273 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
15274 (TypeContainer.delegates): New member to hold list of delegates.
15276 * cs-parser.jay (delegate_declaration): Implement the action correctly
15277 this time as I seem to be on crack ;-)
15279 2001-09-02 Miguel de Icaza <miguel@ximian.com>
15281 * rootcontext.cs (RootContext::IsNamespace): new function, used to
15282 tell whether an identifier represents a namespace.
15284 * expression.cs (NamespaceExpr): A namespace expression, used only
15285 temporarly during expression resolution.
15286 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
15287 utility functions to resolve names on expressions.
15289 2001-09-01 Miguel de Icaza <miguel@ximian.com>
15291 * codegen.cs: Add hook for StatementExpressions.
15293 * class.cs: Fix inverted test for static flag in methods.
15295 2001-09-02 Ravi Pratap <ravi@ximian.com>
15297 * class.cs (Operator::CheckUnaryOperator): Correct error number used
15298 to make it coincide with MS' number.
15299 (Operator::CheckBinaryOperator): Ditto.
15301 * ../errors/errors.txt : Remove error numbers added earlier.
15303 * ../errors/cs1019.cs : Test case for error # 1019
15305 * ../errros/cs1020.cs : Test case for error # 1020
15307 * cs-parser.jay : Clean out commented cruft.
15308 (dimension_separators, dimension_separator): Comment out. Ostensibly not
15309 used anywhere - non-reducing rule.
15310 (namespace_declarations): Non-reducing rule - comment out.
15312 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
15313 with TypeContainer::AddEnum.
15315 * delegate.cs : New file for delegate handling classes.
15316 (Delegate): Class for declaring delegates.
15318 * makefile : Update.
15320 * cs-parser.jay (delegate_declaration): Implement.
15322 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
15324 * class.cs (Event::Define): Implement.
15325 (Event.EventBuilder): New member.
15327 * class.cs (TypeContainer::Populate): Update to define all enums and events
15329 (Events): New property for the events arraylist we hold. Shouldn't we move to using
15330 readonly fields for all these cases ?
15332 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15334 * class.cs (Property): Revamp to use the convention of making fields readonly.
15335 Accordingly modify code elsewhere.
15337 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
15338 the Define method of the Property class.
15340 * class.cs : Clean up applied patch and update references to variables etc. Fix
15342 (TypeContainer::Populate): Update to define all the properties we have. Also
15343 define all enumerations.
15345 * enum.cs (Define): Implement.
15347 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15349 * cs-parser.jay (overloadable_operator): The semantic value is an
15350 enum of the Operator class.
15351 (operator_declarator): Implement actions.
15352 (operator_declaration): Implement.
15354 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
15355 validity of definitions.
15356 (Operator::CheckBinaryOperator): Static method to check for binary operators
15357 (TypeContainer::AddOperator): New method to add an operator to a type.
15359 * cs-parser.jay (indexer_declaration): Added line to actually call the
15360 AddIndexer method so it gets added ;-)
15362 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
15363 already taken care of by the MS compiler ?
15365 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15367 * class.cs (Operator): New class for operator declarations.
15368 (Operator::OpType): Enum for the various operators.
15370 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15372 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
15373 ostensibly handle this in semantic analysis.
15375 * cs-parser.jay (general_catch_clause): Comment out
15376 (specific_catch_clauses, specific_catch_clause): Ditto.
15377 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
15378 (catch_args, opt_catch_args): New productions.
15379 (catch_clause): Rewrite to use the new productions above
15380 (catch_clauses): Modify accordingly.
15381 (opt_catch_clauses): New production to use in try_statement
15382 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
15383 and re-write the code in the actions to extract the specific and
15384 general catch clauses by being a little smart ;-)
15386 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
15387 Hooray, try and catch statements parse fine !
15389 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15391 * statement.cs (Block::GetVariableType): Fix logic to extract the type
15392 string from the hashtable of variables.
15394 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
15395 I end up making that mistake ;-)
15396 (catch_clauses): Fixed gross error which made Key and Value of the
15397 DictionaryEntry the same : $1 !!
15399 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15401 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
15403 * cs-parser.jay (event_declaration): Correct to remove the semicolon
15404 when the add and remove accessors are specified.
15406 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15408 * cs-parser.jay (IndexerDeclaration): New helper class to hold
15409 information about indexer_declarator.
15410 (indexer_declarator): Implement actions.
15411 (parsing_indexer): New local boolean used to keep track of whether
15412 we are parsing indexers or properties. This is necessary because
15413 implicit_parameters come into picture even for the get accessor in the
15414 case of an indexer.
15415 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
15417 * class.cs (Indexer): New class for indexer declarations.
15418 (TypeContainer::AddIndexer): New method to add an indexer to a type.
15419 (TypeContainer::indexers): New member to hold list of indexers for the
15422 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
15424 * cs-parser.jay (add_accessor_declaration): Implement action.
15425 (remove_accessor_declaration): Implement action.
15426 (event_accessors_declaration): Implement
15427 (variable_declarators): swap statements for first rule - trivial.
15429 * class.cs (Event): New class to hold information about event
15431 (TypeContainer::AddEvent): New method to add an event to a type
15432 (TypeContainer::events): New member to hold list of events.
15434 * cs-parser.jay (event_declaration): Implement actions.
15436 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
15438 * cs-parser.jay (dim_separators): Implement. Make it a string
15439 concatenating all the commas together, just as they appear.
15440 (opt_dim_separators): Modify accordingly
15441 (rank_specifiers): Update accordingly. Basically do the same
15442 thing - instead, collect the brackets here.
15443 (opt_rank_sepcifiers): Modify accordingly.
15444 (array_type): Modify to actually return the complete type string
15445 instead of ignoring the rank_specifiers.
15446 (expression_list): Implement to collect the expressions
15447 (variable_initializer): Implement. We make it a list of expressions
15448 essentially so that we can handle the array_initializer case neatly too.
15449 (variable_initializer_list): Implement.
15450 (array_initializer): Make it a list of variable_initializers
15451 (opt_array_initializer): Modify accordingly.
15453 * expression.cs (New::NType): Add enumeration to help us
15454 keep track of whether we have an object/delegate creation
15455 or an array creation.
15456 (New:NewType, New::Rank, New::Indices, New::Initializers): New
15457 members to hold data about array creation.
15458 (New:New): Modify to update NewType
15459 (New:New): New Overloaded contructor for the array creation
15462 * cs-parser.jay (array_creation_expression): Implement to call
15463 the overloaded New constructor.
15465 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
15467 * class.cs (TypeContainer::Constructors): Return member
15468 constructors instead of returning null.
15470 2001-08-26 Miguel de Icaza <miguel@ximian.com>
15472 * typemanager.cs (InitCoreTypes): Initialize the various core
15473 types after we have populated the type manager with the user
15474 defined types (this distinction will be important later while
15475 compiling corlib.dll)
15477 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
15478 on Expression Classification. Now all expressions have a method
15479 `Resolve' and a method `Emit'.
15481 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
15482 generation from working. Also add some temporary debugging
15485 2001-08-24 Miguel de Icaza <miguel@ximian.com>
15487 * codegen.cs: Lots of code generation pieces. This is only the
15488 beginning, will continue tomorrow with more touches of polish. We
15489 handle the fundamentals of if, while, do, for, return. Others are
15490 trickier and I need to start working on invocations soon.
15492 * gen-treedump.cs: Bug fix, use s.Increment here instead of
15495 * codegen.cs (EmitContext): New struct, used during code
15496 emission to keep a context. Most of the code generation will be
15499 * cs-parser.jay: Add embedded blocks to the list of statements of
15500 this block. So code generation proceeds in a top down fashion.
15502 2001-08-23 Miguel de Icaza <miguel@ximian.com>
15504 * statement.cs: Add support for multiple child blocks.
15506 2001-08-22 Miguel de Icaza <miguel@ximian.com>
15508 * codegen.cs (EmitCode): New function, will emit the code for a
15509 Block of code given a TypeContainer and its ILGenerator.
15511 * statement.cs (Block): Standard public readonly optimization.
15512 (Block::Block constructors): Link children.
15513 (Block::Child): Child Linker.
15514 (Block::EmitVariables): Emits IL variable declarations.
15516 * class.cs: Drop support for MethodGroups here, delay until
15518 (Method::): Applied the same simplification that I did before, and
15519 move from Properties to public readonly fields.
15520 (Method::ParameterTypes): Returns the parameter types for the
15521 function, and implements a cache that will be useful later when I
15522 do error checking and the semantic analysis on the methods is
15524 (Constructor::GetCallingConvention): Renamed from CallingConvetion
15525 and made a method, optional argument tells whether this is a class
15526 or a structure to apply the `has-this' bit.
15527 (Method::GetCallingConvention): Implement, returns the calling
15529 (Method::Define): Defines the type, a second pass is performed
15530 later to populate the methods.
15532 (Constructor::ParameterTypes): implement a cache similar to the
15533 one on Method::ParameterTypes, useful later when we do semantic
15536 (TypeContainer::EmitMethod): New method. Emits methods.
15538 * expression.cs: Removed MethodGroup class from here.
15540 * parameter.cs (Parameters::GetCallingConvention): new method.
15542 2001-08-21 Miguel de Icaza <miguel@ximian.com>
15544 * class.cs (TypeContainer::Populate): Drop RootContext from the
15547 (Constructor::CallingConvention): Returns the calling convention.
15548 (Constructor::ParameterTypes): Returns the constructor parameter
15551 (TypeContainer::AddConstructor): Keep track of default constructor
15552 and the default static constructor.
15554 (Constructor::) Another class that starts using `public readonly'
15555 instead of properties.
15557 (Constructor::IsDefault): Whether this is a default constructor.
15559 (Field::) use readonly public fields instead of properties also.
15561 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
15562 track of static constructors; If none is used, turn on
15563 BeforeFieldInit in the TypeAttributes.
15565 * cs-parser.jay (opt_argument_list): now the return can be null
15566 for the cases where there are no arguments.
15568 (constructor_declarator): If there is no implicit `base' or
15569 `this', then invoke the default parent constructor.
15571 * modifiers.cs (MethodAttr): New static function maps a set of
15572 modifiers flags into a MethodAttributes enum
15573 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
15574 MethodAttr, TypeAttr to represent the various mappings where the
15575 modifiers are used.
15576 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
15578 2001-08-19 Miguel de Icaza <miguel@ximian.com>
15580 * parameter.cs (GetParameterInfo): Fix bug where there would be no
15583 * interface.cs (PopulateIndexer): Implemented the code generator
15584 for interface indexers.
15586 2001-08-17 Miguel de Icaza <miguel@ximian.com>
15588 * interface.cs (InterfaceMemberBase): Now we track the new status
15591 (PopulateProperty): Implement property population. Woohoo! Got
15592 Methods and Properties going today.
15594 Removed all the properties for interfaces, and replaced them with
15595 `public readonly' fields.
15597 2001-08-16 Miguel de Icaza <miguel@ximian.com>
15599 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
15600 initialize their hashtables/arraylists only when they are needed
15601 instead of doing this always.
15603 * parameter.cs: Handle refs and out parameters.
15605 * cs-parser.jay: Use an ArrayList to construct the arguments
15606 instead of the ParameterCollection, and then cast that to a
15609 * parameter.cs: Drop the use of ParameterCollection and use
15610 instead arrays of Parameters.
15612 (GetParameterInfo): Use the Type, not the Name when resolving
15615 2001-08-13 Miguel de Icaza <miguel@ximian.com>
15617 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
15618 and instead use public readonly fields.
15620 * class.cs: Put back walking code for type containers.
15622 2001-08-11 Miguel de Icaza <miguel@ximian.com>
15624 * class.cs (MakeConstant): Code to define constants.
15626 * rootcontext.cs (LookupType): New function. Used to locate types
15629 2001-08-08 Miguel de Icaza <miguel@ximian.com>
15631 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
15632 this System.Reflection code is. Kudos to Microsoft
15634 * typemanager.cs: Implement a type cache and avoid loading all
15635 types at boot time. Wrap in LookupType the internals. This made
15636 the compiler so much faster. Wow. I rule!
15638 * driver.cs: Make sure we always load mscorlib first (for
15639 debugging purposes, nothing really important).
15641 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
15642 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
15644 * rootcontext.cs: Lookup types on their namespace; Lookup types
15645 on namespaces that have been imported using the `using' keyword.
15647 * class.cs (TypeContainer::TypeAttr): Virtualize.
15648 (Class::TypeAttr): Return attributes suitable for this bad boy.
15649 (Struct::TypeAttr): ditto.
15650 Handle nested classes.
15651 (TypeContainer::) Remove all the type visiting code, it is now
15652 replaced with the rootcontext.cs code
15654 * rootcontext.cs (GetClassBases): Added support for structs.
15656 2001-08-06 Miguel de Icaza <miguel@ximian.com>
15658 * interface.cs, statement.cs, class.cs, parameter.cs,
15659 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
15660 Drop use of TypeRefs, and use strings instead.
15662 2001-08-04 Miguel de Icaza <miguel@ximian.com>
15666 * class.cs (Struct::Struct): set the SEALED flags after
15667 checking the modifiers.
15668 (TypeContainer::TypeAttr): new property, returns the
15669 TypeAttributes for a class.
15671 * cs-parser.jay (type_list): Oops, list production was creating a
15672 new list of base types.
15674 * rootcontext.cs (StdLib): New property.
15675 (GetInterfaceTypeByName): returns an interface by type name, and
15676 encapsulates error handling here.
15677 (GetInterfaces): simplified.
15678 (ResolveTree): Encapsulated all the tree resolution here.
15679 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
15682 * driver.cs: Add support for --nostdlib, to avoid loading the
15683 default assemblies.
15684 (Main): Do not put tree resolution here.
15686 * rootcontext.cs: Beginning of the class resolution.
15688 2001-08-03 Miguel de Icaza <miguel@ximian.com>
15690 * rootcontext.cs: Provide better error reporting.
15692 * cs-parser.jay (interface_base): set our $$ to be interfaces.
15694 * rootcontext.cs (CreateInterface): Handle the case where there
15695 are no parent interfaces.
15697 (CloseTypes): Routine to flush types at the end.
15698 (CreateInterface): Track types.
15699 (GetInterfaces): Returns an array of Types from the list of
15700 defined interfaces.
15702 * typemanager.c (AddUserType): Mechanism to track user types (puts
15703 the type on the global type hash, and allows us to close it at the
15706 2001-08-02 Miguel de Icaza <miguel@ximian.com>
15708 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
15709 RecordInterface instead.
15711 * cs-parser.jay: Updated to reflect changes above.
15713 * decl.cs (Definition): Keep track of the TypeBuilder type that
15714 represents this type here. Not sure we will use it in the long
15715 run, but wont hurt for now.
15717 * driver.cs: Smaller changes to accomodate the new code.
15719 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
15722 * rootcontext.cs (CreateInterface): New method, used to create
15723 the System.TypeBuilder type for interfaces.
15724 (ResolveInterfaces): new entry point to resolve the interface
15726 (CodeGen): Property, used to keep track of the code generator.
15728 2001-07-26 Miguel de Icaza <miguel@ximian.com>
15730 * cs-parser.jay: Add a second production for delegate_declaration
15733 (enum_body): Put an opt_comma here instead of putting it on
15734 enum_body or enum_member_declarations so we can handle trailing
15735 commas on enumeration members. Gets rid of a shift/reduce.
15737 (type_list): Need a COMMA in the middle.
15739 (indexer_declaration): Tell tokenizer to recognize get/set
15741 * Remove old targets.
15743 * Re-add the parser target.
15745 2001-07-13 Simon Cozens <simon@simon-cozens.org>
15747 * cs-parser.jay: Add precendence rules for a number of operators
15748 ot reduce the number of shift/reduce conflicts in the grammar.
15750 2001-07-17 Miguel de Icaza <miguel@ximian.com>
15752 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
15755 Get rid of old crufty code.
15757 * rootcontext.cs: Use this to keep track of the parsed
15758 representation and the defined types available to the program.
15760 * gen-treedump.cs: adjust for new convention.
15762 * type.cs: Split out the type manager, and the assembly builder
15765 * typemanager.cs: the type manager will live here now.
15767 * cil-codegen.cs: And the code generator here.
15769 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
15771 * makefile: Fixed up for easy making.
15773 2001-07-13 Simon Cozens <simon@simon-cozens.org>
15775 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
15778 (unary_expression): Expand pre_increment_expression and
15779 post_decrement_expression to reduce a shift/reduce.
15781 2001-07-11 Simon Cozens
15783 * cs-tokenizer.cs: Hex numbers should begin with a 0.
15785 Improve allow_keyword_as_indent name.
15787 2001-06-19 Miguel de Icaza <miguel@ximian.com>
15789 * Adjustments for Beta2.
15791 2001-06-13 Miguel de Icaza <miguel@ximian.com>
15793 * decl.cs: Added `Define' abstract method.
15794 (InTransit): new property, used to catch recursive definitions.
15796 * interface.cs: Implement `Define'.
15798 * modifiers.cs: Map Modifiers.constants to
15799 System.Reflection.TypeAttribute flags.
15801 * class.cs: Keep track of types and user-defined types.
15802 (BuilderInit): New method for creating an assembly
15803 (ResolveType): New function to launch the resolution process, only
15804 used by interfaces for now.
15806 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
15807 that are inserted into the name space.
15809 2001-06-08 Miguel de Icaza <miguel@ximian.com>
15811 * ARGH. I have screwed up my tree so many times due to the use of
15812 rsync rather than using CVS. Going to fix this at once.
15814 * driver.cs: Objetify driver. Load assemblies, use assemblies to
15817 2001-06-07 Miguel de Icaza <miguel@ximian.com>
15819 * Experiment successful: Use System.Type rather that our own
15822 2001-05-25 Miguel de Icaza <miguel@ximian.com>
15824 * cs-parser.jay: Removed nsAliases from here.
15826 Use new namespaces, handle `using XXX;'
15828 * namespace.cs: Reimplemented namespace handling, use a recursive
15829 definition of the class. Now we can keep track of using clauses
15830 and catch invalid using clauses.
15832 2001-05-24 Miguel de Icaza <miguel@ximian.com>
15834 * gen-treedump.cs: Adapted for all the renaming.
15836 * expression.cs (Expression): this class now has a Type property
15837 which returns an expression Type.
15839 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
15840 `Type', as this has a different meaning now in the base
15842 2001-05-22 Miguel de Icaza <miguel@ximian.com>
15844 * interface.cs, class.cs: Removed from all the sources the
15845 references to signature computation, as we can not do method
15846 signature computation during the parsing time, as we are not
15847 trying to solve at that point distinguishing:
15851 void a (NS.Blah x) {}
15854 Which depending on the context might be valid or not, as we do not
15855 know if Blah is the same thing as NS.Blah at that point.
15857 * Redid everything so the code uses TypeRefs now instead of
15858 Types. TypeRefs are just temporary type placeholders, that need
15859 to be resolved. They initially have a pointer to a string and the
15860 current scope in which they are used. This is used later by the
15861 compiler to resolve the reference to an actual Type.
15863 * DeclSpace is no longer a CIR.Type, and neither are
15864 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
15865 are all DeclSpaces, but no Types.
15867 * type.cs (TypeRefManager): This implements the TypeRef manager,
15868 which keeps track of all the types that need to be resolved after
15869 the parsing has finished.
15871 2001-05-13 Miguel de Icaza <miguel@ximian.com>
15873 * ARGH. We are going to have to store `foreach' as a class rather
15874 than resolving it, as we need to verify error 1579 after name
15875 resolution. *OR* we could keep a flag that says `This request to
15876 IEnumerator comes from a foreach statement' which we can then use
15877 to generate the error.
15879 2001-05-10 Miguel de Icaza <miguel@ximian.com>
15881 * class.cs (TypeContainer.AddMethod): we now add methods to the
15882 MethodGroup instead of the method hashtable.
15884 * expression.cs: Add MethodGroup abstraction, which gets us one
15885 step closer to the specification in the way we handle method
15888 * cs-parser.jay (primary_expression): qualified_identifier now
15889 tried to match up an identifier to a local variable reference or
15890 to a parameter reference.
15892 current_local_parameters is now a parser global variable that
15893 points to the current parameters for the block, used during name
15896 (property_declaration): Now creates an implicit `value' argument to
15899 2001-05-09 Miguel de Icaza <miguel@ximian.com>
15901 * parameter.cs: Do not use `param' arguments as part of the
15902 signature, per the spec.
15904 2001-05-08 Miguel de Icaza <miguel@ximian.com>
15906 * decl.cs: Base class for classes, structs and interfaces. This
15907 is the "Declaration Space"
15909 * cs-parser.jay: Use CheckDef for checking declaration errors
15910 instead of having one on each function.
15912 * class.cs: Factor out some code for handling error handling in
15913 accordance to the "Declarations" section in the "Basic Concepts"
15914 chapter in the ECMA C# spec.
15916 * interface.cs: Make all interface member classes derive from
15917 InterfaceMemberBase.
15919 2001-05-07 Miguel de Icaza <miguel@ximian.com>
15921 * Many things: all interfaces are parsed and generated in
15922 gen-treedump. Support for member variables, constructors,
15923 destructors, properties, constants is there.
15925 Beginning of the IL backend, but very little done, just there for
15928 2001-04-29 Miguel de Icaza <miguel@ximian.com>
15930 * cs-parser.jay: Fix labeled statement.
15932 * cs-tokenizer.cs (escape): Escape " and ' always.
15933 ref_line, ref_name: keep track of the line/filename as instructed
15934 by #line by the compiler.
15937 2001-04-27 Miguel de Icaza <miguel@ximian.com>
15939 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
15940 to match the values in System.CodeDOM.
15942 Divid renamed to Divide.
15944 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
15946 (Statements.set): remove.
15948 * System.CodeDOM/CodeCatchClause.cs: always have a valid
15951 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
15952 falseStatements always have valid values.
15954 * cs-parser.jay: Use System.CodeDOM now.